Add more styling to "disassemble"
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
046bebe1
TT
12019-08-06 Tom Tromey <tom@tromey.com>
2
3 * utils.c (set_output_style): Sometimes pass stream to
4 emit_style_escape.
5 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6 * record-btrace.c (btrace_insn_history): Update.
7 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
8 method.
9 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
10 Update initializers.
11 <m_uiout>: New field.
12 <m_di>: Move lower.
13 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
14 Remove "uiout" parameter.
15 (dump_insns): Update.
16 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
17 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
18
ddbcedf5
CB
192019-08-06 Christian Biesinger <cbiesinger@google.com>
20
21 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
22 (error_in_psymtab_expansion): Likewise.
23 (lookup_symbol_via_quick_fns): Likewise.
24 (basic_lookup_transparent_type_quick): Likewise.
25 (basic_lookup_transparent_type_1): Likewise.
26
b08b16c8
TT
272019-08-06 Tom Tromey <tromey@adacore.com>
28
29 * source.c (last_source_error): Now bool.
30 (print_source_lines_base): Make "noprint" bool. Only open
31 source file when last_source_visited changes.
32
cb44333d
TT
332019-08-06 Tom Tromey <tromey@adacore.com>
34
35 * annotate.c (annotate_source_line): Use g_source_cache.
36 * source-cache.c (source_cache::get_plain_source_lines): Change
37 parameters. Populate m_offset_cache.
38 (source_cache::ensure): New method.
39 (source_cache::get_line_charpos): New method.
40 (extract_lines): Move lower. Change parameters.
41 (source_cache::get_source_lines): Move lower.
42 * source-cache.h (class source_cache): Update comment.
43 <get_line_charpos>: New method.
44 <get_source_lines>: Update comment.
45 <clear>: Clear m_offset_cache.
46 <get_plain_source_lines>: Change parameters.
47 <ensure>: New method
48 <m_offset_cache>: New member.
49 * source.c (forget_cached_source_info_for_objfile): Update.
50 (info_source_command): Use g_source_cache.
51 (find_source_lines, open_source_file_with_line_charpos): Remove.
52 (print_source_lines_base, search_command_helper): Use g_source_cache.
53 * source.h (open_source_file_with_line_charpos): Don't declare.
54 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
55 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
56 Use g_source_cache.
57
872dceaa
TT
582019-08-06 Tom Tromey <tromey@adacore.com>
59
60 * source-cache.c (source_cache::get_plain_source_lines):
61 Remove "first_line" and "last_line" parameters.
62 (source_cache::get_source_lines): Cache plain text.
63 * source-cache.h (class source_cache)
64 <get_plain_source_lines>: Update.
65
269249d9
TT
662019-08-06 Tom Tromey <tromey@adacore.com>
67
68 * source-cache.c (extract_lines): No longer a method.
69 Changed type of parameter. Include final newline.
70 (selftests::extract_lines_test): New function.
71 (_initialize_source_cache): Likewise.
72 * source-cache.h (class source_cache)
73 <extract_lines>: Don't declare.
74
c0e8dcd8
TT
752019-08-06 Tom Tromey <tromey@adacore.com>
76
77 * breakpoint.c (init_breakpoint_sal): Update.
78 (breakpoint): Update.
79 * breakpoint.h (struct breakpoint) <filter>: Now a
80 unique_xmalloc_ptr.
81
0b27c27d
CB
822019-08-05 Christian Biesinger <cbiesinger@google.com>
83
84 * NEWS: Mention dictionary access on blocks.
85 * python/py-block.c (blpy_getitem): New function.
86 (block_object_as_mapping): New struct.
87 (block_object_type): Use new struct for tp_as_mapping field.
88
4ee94178
CB
892019-08-05 Christian Biesinger <cbiesinger@google.com>
90
91 * objfiles.h (objfile): Add a comment describing partial symbols.
92
8abfcabc
TT
932019-08-05 Tom Tromey <tromey@adacore.com>
94
95 * compile/compile.c (_initialize_compile): Use _(), not N_().
96 * thread.c (_initialize_thread): Use _(), not N_().
97 * stack.c (_initialize_stack): Use _(), not N_().
98 * printcmd.c (_initialize_printcmd): Use _(), not N_().
99
2b79f376
SM
1002019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
101
102 * dwarf2read.c (struct dw2_symtab_iterator):
103 <want_specific_block>: Remove.
104 <block_index>: Change type to gdb::optional.
105 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
106 change type of BLOCK_INDEX parameter to gdb::optional.
107 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
108 (dw2_lookup_symbol): Don't pass argument for
109 WANT_SPECIFIC_BLOCK.
110 (dw2_expand_symtabs_for_function): Don't pass argument for
111 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
112 (class dw2_debug_names_iterator)
113 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
114 parameter, change BLOCK_INDEX type to gdb::optional.
115 <m_want_specific_block>: Remove.
116 <m_block_index>: Change type to gdb::optional.
117 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
118 gdb::optional. Re-write in function of gdb::optional.
119 (dw2_debug_names_lookup_symbol): Don't pass argument for
120 WANT_SPECIFIC_BLOCK.
121 (dw2_debug_names_expand_symtabs_for_function): Don't pass
122 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
123 BLOCK_INDEX.
124
ae60f04e
PW
1252019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
126
127 * NEWS: Mention changes to "info sources" command.
128
28cd9371
PW
1292019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
130
131 * symtab.c (filename_partial_match_opts): New struct type.
132 (struct output_source_filename_data): New members
133 regexp, c_regexp, partial_match.
134 (output_source_filename): Use new members to decide to print file.
135 (info_sources_option_defs): New variable.
136 (make_info_sources_options_def_group, print_info_sources_header,
137 info_sources_command_completer):
138 New functions.
139 (info_sources_command): Read new optional arguments.
140 (_initialize_symtab): Update info sources help.
141
ca683e3a
AO
1422019-08-02 Alexandre Oliva <oliva@adacore.com>
143
144 * ada-lang.c (exception_support_info_v0): Renamed from...
145 (default_exception_support_info): ... this. Create new
146 definition for v1.
147 (ada_has_this_exception_support): Look up catch_handlers_sym.
148 (ada_exception_support_info_sniffer): Try v0 after default.
149
f1264162
TT
1502019-08-01 Tom Tromey <tromey@adacore.com>
151
152 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
153 gdbarch.h.
154
0a7b2485
CB
1552019-08-01 Christian Biesinger <cbiesinger@google.com>
156
157 * s12z-tdep.c: Fix include path for s12z-opc.h.
158
c6bdbeb7
AH
1592019-08-01 Alan Hayward <alan.hayward@arm.com>
160
161 * NEWS: Require GNU make 3.82.
162
a2bd7b82
TT
1632019-07-16 Tom Tromey <tom@tromey.com>
164
165 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
166 declare.
167
aa3b6533
TT
1682019-07-30 Tom Tromey <tromey@adacore.com>
169
170 * block.c (contained_in): Remove BLOCK_FUNCTION check.
171
a1530dc7
KB
1722019-07-30 Kevin Buettner <kevinb@redhat.com>
173
174 * printcmd.c (print_address_symbolic): Print negative offsets.
175 (build_address_symbolic): Force signed arithmetic when computing
176 offset.
177
2906593f
CB
1782019-07-30 Christian Biesinger <cbiesinger@google.com>
179
180 PR/24474: Add a function to lookup static variables.
181 * NEWS: Mention this new function.
182 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
183 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
184 * python/python.c (python_GdbMethods): Add new function.
185
c620ed88
CB
1862019-07-29 Christian Biesinger <cbiesinger@google.com>
187
188 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
189 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
190 (objfpy_lookup_static_symbol): New function.
191 (objfile_object_methods): Add new functions.
192
bc4268a5
PW
1932019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
194
195 * NEWS: Mention 'set|show print frame-info'. Mention new
196 'presence' value for 'frame-arguments'. Mention new '-frame-info'
197 backtrace argument. Mention that python frame filtering code
198 is now consistent with what 'backtrace' command prints.
199
4b5e8d19
PW
2002019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
201
202 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
203 comments.
204 (print_frame_info_auto, print_frame_info_source_line,
205 print_frame_info_location, print_frame_info_source_and_location,
206 print_frame_info_location_and_address, print_frame_info_short_location):
207 New declarations.
208 (struct frame_print_options): New member print_frame_info.
209 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
210 * stack.h (get_user_print_what_frame_info): New declaration.
211 (frame_show_address): New declaration.
212 * stack.c (print_frame_arguments_choices): New value 'presence'.
213 (print_frame_info_auto, print_frame_info_source_line,
214 print_frame_info_location, print_frame_info_source_and_location,
215 print_frame_info_location_and_address, print_frame_info_short_location,
216 print_frame_info_choices, print_frame_info_print_what): New definitions.
217 (print_frame_args): Only print dots for args if print frame-arguments
218 is 'presence'.
219 (frame_print_option_defs): New element for "frame-info".
220 (get_user_print_what_frame_info): New function.
221 (frame_show_address): Make non static. Move comment to stack.h.
222 (print_frame_info_to_print_what): New function.
223 (print_frame_info): Update comment. Use fp_opts.print_frame_info
224 to decide what to print.
225 (backtrace_command_1): Handle the new print_frame_arguments_presence
226 value.
227 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
228 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
229 (py_print_frame): In non-mi mode, use LOCATION as default for
230 print_what, similarly to frame information printed directly by
231 backtrace command. Handle frame-info user option in non MI mode.
232
6bdfee81
KB
2332019-07-27 Kevin Buettner <kevinb@redhat.com>
234
235 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
236 Add case for debugging 32-bit target on 64-bit host. Revise
237 comment.
238
98a617f8
KB
2392019-07-27 Kevin Buettner <kevinb@redhat.com>
240
241 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
242 instead of find_function_entry_range_from_pc.
243
567238c9
KB
2442019-07-27 Kevin Buettner <kevinb@redhat.com>
245
246 * stack.c (find_frame_funname): Remove code which preferred
247 minsym over symtab sym in "certain pathological cases".
248
2dc80cf8
KB
249 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
250 parameter. Change type of "do_demangle" to bool.
251 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
252 Pass suitable "prefer_sym_over_minsym" flag to
253 build_address_symbolic(). Don't output "+" for negative offsets.
254 * printcmd.c (print_address_symbolic): Update invocation of
255 build_address_symbolic to include a "prefer_sym_over_minsym"
256 flag.
257 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
258 Restrict cases in which use of minimal symbol is preferred to that
259 of a found symbol. Update comments.
260
1aff7173
KB
261 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
262 for entry pc when entry pc is out of range for that FDE.
263
89b085ac
BC
2642019-07-26 Brian Callahan <bcallah@openbsd.org>
265
266 PR gdb/24839:
267 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
268 type.
269
f32feb4a
CB
2702019-07-25 Christian Biesinger <cbiesinger@google.com>
271
272 * python/py-objfile.c (add_separate_debug_file): Fix comment about
273 this function's Python signature.
274
275
2762019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
277
278 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
279 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
280 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
281 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
282 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
283
284
c54e4253
YS
2852019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
286
287 * h8300-tdep.c (h8300_register_name_common): New.
288 h8300_register_name): Use h8300_register_name_common.
289 (h8300s_register_name): Likewise.
290 (h8300sx_register_name): Likewise.
291 (h8300h_register_nam): New.
292 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
293
294
40eadf04
SP
2952019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
296
297 * arm-tdep.c (arm_skip_cmse_entry): New function.
298 (arm_is_sgstubs_section): New function.
299 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
300
bfa2a36d
TT
3012019-07-22 Tom Tromey <tom@tromey.com>
302
303 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
304 Don't self-assign.
305
a8e9d247
AB
3062019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
307
308 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
309 type_print.
310
eb86c5e2
AB
3112019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
312
313 * symtab.c (search_symbols): Adjust msymbol matching type arrays
314 so that GDB doesn't match any msymbols when searching in the
315 TYPES_DOMAIN.
316 (print_symbol_info): Print using typedef_print or type_print based
317 on the type of the symbol. Add updated FIXME comment moved from...
318 (_initialize_symtab): ... move and update FIXME comment to above.
319
a8eab7c6
AB
3202019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
321
322 * NEWS: Mention adding -q option to "info types".
323 * symtab.c (struct info_types_options): New struct.
324 (info_types_options_defs): New variable.
325 (make_info_types_options_def_group): New function.
326 (info_types_command): Use gdb::option framework to parse options.
327 (info_types_command_completer): New function.
328 (_initialize_symtab): Extend the help text on "info types" and
329 register command completer.
330
b4603c34
CB
3312019-07-21 Christian Biesinger <cbiesinger@google.com>
332
333 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
334 (lookup_symbol_in_objfile): Change int to block_enum and add a
335 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
336
c8cdc1e0
CB
3372019-07-20 Christian Biesinger <cbiesinger@google.com>
338
339 * MAINTAINERS (Write After Approval): Add self.
340
01e175fe
AB
3412019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
342
343 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
344 instruction to the dummy code region.
345
56f79b63
TT
3462019-07-19 Tom Tromey <tromey@adacore.com>
347
348 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
349 (ARGSUSED, PARAMS, __func__): Remove rules.
350
4c5aa8e0
AH
3512019-07-19 Alan Hayward <alan.hayward@arm.com>
352
353 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
354 * features/arm/arm-with-iwmmxt.c: Remove.
355 * features/arm/arm-with-iwmmxt.xml: Remove.
356 * features/arm/arm-with-m-fpa-layout.c: Remove.
357 * features/arm/arm-with-m-fpa-layout.xml: Remove.
358 * features/arm/arm-with-m-vfp-d16.c: Remove.
359 * features/arm/arm-with-m-vfp-d16.xml: Remove.
360 * features/arm/arm-with-m.c: Remove.
361 * features/arm/arm-with-m.xml: Remove.
362 * features/arm/arm-with-neon.c: Remove.
363 * features/arm/arm-with-neon.xml: Remove.
364 * features/arm/arm-with-vfpv2.c: Remove.
365 * features/arm/arm-with-vfpv2.xml: Remove.
366 * features/arm/arm-with-vfpv3.c: Remove.
367 * features/arm/arm-with-vfpv3.xml: Remove.
368
f42b2617
AH
3692019-07-19 Alan Hayward <alan.hayward@arm.com>
370
371 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
372
f29ec966
AH
3732019-07-19 Alan Hayward <alan.hayward@arm.com>
374
375 * arch/aarch32.c (aarch32_create_target_description): Create
376 target descriptions using features.
377 * arch/arm.c (arm_create_target_description)
378 (arm_create_mprofile_target_description): Likewise.
379 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
380
d105cce5
AH
3812019-07-19 Alan Hayward <alan.hayward@arm.com>
382
383 * Makefile.in: Add new files.
384 * aarch32-tdep.c: New file.
385 * aarch32-tdep.h: New file.
386 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
387 Call aarch32_read_description.
388 * arch/aarch32.c: New file.
389 * arch/aarch32.h: New file.
390 * arch/arm.c (arm_create_target_description)
391 (arm_create_mprofile_target_description): New function.
392 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
393 (arm_create_target_description)
394 (arm_create_mprofile_target_description): New declaration.
395 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
396 read_description functions.
397 * arm-linux-nat.c (arm_linux_nat_target::read_description):
398 Likewise.
399 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
400 * arm-tdep.c (tdesc_arm_list): New variable.
401 (arm_register_g_packet_guesses): Call create description functions.
402 (arm_read_description) (arm_read_mprofile_description): New
403 function.
404 * arm-tdep.h (arm_read_description)
405 (arm_read_mprofile_description): Add declaration.
406 * configure.tgt: Add new files.
407
afe09f0b
GL
4082019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
409
410 * top.c (new_ui_command): Open specified terminal just once.
411
cd215b2e
TT
4122019-07-18 Tom Tromey <tromey@adacore.com>
413
414 * symtab.c (main_name): Constify return type.
415 * symfile.c (set_initial_language): Update.
416 * symtab.h (main_name): Constify return type.
417
d8f68fcb
TT
4182019-07-17 Tom Tromey <tom@tromey.com>
419
420 * tui/tui-winsource.c (tui_update_source_window)
421 (tui_update_source_window_as_is)
422 (tui_update_source_windows_with_line): Remove return.
423 * tui/tui-disasm.c (tui_show_disassem)
424 (tui_show_disassem_and_update_source): Remove return.
425 * tui/tui.c (tui_reset): Remove return.
426 * tui/tui-wingeneral.c
427 (tui_check_and_display_highlight_if_needed): Remove return.
428
ca5af91e
TT
4292019-07-17 Tom Tromey <tom@tromey.com>
430
431 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
432
5104fe36
TT
4332019-07-17 Tom Tromey <tom@tromey.com>
434
435 * tui/tui-winsource.h (struct tui_exec_info_window)
436 (struct tui_source_window_base): Move from tui-data.h.
437 * tui/tui-winsource.c: Move many method definitions from
438 elsewhere. Remove "structuring" comments.
439 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
440 (tui_source_window_base::refresh_window): Move to
441 tui-winsource.c.
442 * tui/tui-win.c (tui_source_window_base::refresh_all)
443 (tui_source_window_base::update_tab_width)
444 (tui_source_window_base::set_new_height)
445 (tui_source_window_base::do_make_visible_with_new_height): Move to
446 tui-winsource.c.
447 * tui/tui-source.h: Update.
448 * tui/tui-source.c (tui_source_window_base::reset): Move to
449 tui-winsource.c.
450 * tui/tui-disasm.h: Update.
451 * tui/tui-data.h (struct tui_exec_info_window): Move to
452 tui-winsource.h.
453 (struct tui_source_window_base): Likewise.
454 * tui/tui-data.c (tui_source_window_base::clear_detail)
455 (tui_source_window_base, ~tui_source_window_base): Move to
456 tui-winsource.c.
457
daa15dde
TT
4582019-07-17 Tom Tromey <tom@tromey.com>
459
460 * tui/tui-win.c (tui_resize_all)
461 (tui_source_window_base::update_tab_width)
462 (tui_adjust_win_heights): Update.
463 (tui_win_info::make_invisible_and_set_new_height): Rename from
464 make_invisible_and_set_new_height.
465 * tui/tui-data.h (struct tui_win_info)
466 <make_invisible_and_set_new_height>: New method.
467
bfad4537
TT
4682019-07-17 Tom Tromey <tom@tromey.com>
469
470 * tui/tui.c: Update.
471 * tui/tui-source.h (struct tui_source_window): Move from
472 tui-data.h.
473 * tui/tui-layout.c: Update.
474 * tui/tui-disasm.c: Update.
475 * tui/tui-data.h (struct tui_source_window): Move to
476 tui-source.h.
477
88f7e873
TT
4782019-07-17 Tom Tromey <tom@tromey.com>
479
480 * tui/tui-disasm.h (struct tui_disasm_window): Move from
481 tui-data.h.
482 * tui/tui-data.h (struct tui_disasm_window): Move to
483 tui-disasm.h.
484
96bd6233
TT
4852019-07-17 Tom Tromey <tom@tromey.com>
486
487 * tui/tui-regs.h (struct tui_data_item_window): Move from
488 tui-data.h.
489 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
490 * tui/tui-data.h (struct tui_data_item_window): Move to
491 tui-regs.h.
492 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
493
ce38393b
TT
4942019-07-17 Tom Tromey <tom@tromey.com>
495
496 * tui/tui.c: Update.
497 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
498 (tui_cmd_window::max_height): Move to tui-command.c.
499 * tui/tui-layout.c: Update.
500 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
501 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
502 tui-command.c.
503 * tui/tui-command.h (struct tui_cmd_window): Move from
504 tui-data.h.
505 * tui/tui-command.c: Remove "structuring" comments.
506 (tui_cmd_window::clear_detail)
507 (tui_cmd_window::do_make_visible_with_new_height)
508 (tui_cmd_window::max_height): Move from elsewhere.
509
2d8b51cb
TT
5102019-07-17 Tom Tromey <tom@tromey.com>
511
512 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
513 Now static.
514 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
515 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
516
18ab23af
TT
5172019-07-17 Tom Tromey <tom@tromey.com>
518
519 * tui/tui.c: Update.
520 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
521 tui-regs.c.
522 * tui/tui-windata.h: Remove file.
523 * tui/tui-windata.c: Remove file.
524 * tui/tui-win.c (tui_data_window::set_new_height)
525 (tui_data_window::do_make_visible_with_new_height): Move to
526 tui-regs.c.
527 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
528 * tui/tui-regs.c: Remove "structuring" comments.
529 (tui_data_window::first_data_item_displayed)
530 (tui_data_window::delete_data_content_windows)
531 (tui_data_window::erase_data_content)
532 (tui_data_window::display_all_data)
533 (tui_data_window::refresh_all)
534 (tui_data_window::do_scroll_vertical)
535 (tui_data_window::clear_detail, tui_data_window::set_new_height)
536 (tui_data_window::do_make_visible_with_new_height)
537 (tui_data_window::refresh_window): Move from elsewhere.
538 (_initialize_tui_regs): Move to end of file.
539 * tui/tui-layout.c: Update.
540 * tui/tui-hooks.c: Update.
541 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
542 * tui/tui-data.c (tui_data_window::clear_detail): Move to
543 tui-regs.c.
544 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
545
88b7e7cc
TT
5462019-07-17 Tom Tromey <tom@tromey.com>
547
548 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
549 seen.
550
0fcd3711
TT
5512019-07-17 Tom Tromey <tom@tromey.com>
552
553 * tui/tui-win.c (tui_source_window_base::set_new_height)
554 (tui_source_window_base::do_make_visible_with_new_height): Use
555 m_has_locator field directly.
556 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
557 method.
558 (struct tui_source_window_base) <has_locator>: Likewise.
559
4a38112d
TT
5602019-07-17 Tom Tromey <tom@tromey.com>
561
562 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
563 Don't declare.
564 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
565 Remove.
566 * tui/tui-win.c (tui_source_window_base::set_new_height)
567 (tui_source_window_base::set_new_height)
568 (make_invisible_and_set_new_height)
569 (tui_source_window_base::do_make_visible_with_new_height)
570 (tui_source_window_base::do_make_visible_with_new_height):
571 Update.
572 * tui/tui-layout.c (show_source_disasm_command, show_data)
573 (show_source_or_disasm_and_command): Update.
574 * tui/tui-layout.c (show_layout): Update.
575
09129226
TT
5762019-07-17 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-layout.c (make_data_window): Remove.
579 (show_data): Unify creation and re-initialization cases.
580
4a8a5e84
TT
5812019-07-17 Tom Tromey <tom@tromey.com>
582
583 * tui/tui-layout.c (make_source_window, make_disasm_window):
584 Remove.
585 (show_data): Unify creation and re-initialization cases.
586
76d2be8e
TT
5872019-07-17 Tom Tromey <tom@tromey.com>
588
589 * tui/tui-layout.c (make_command_window): Remove.
590 (show_source_disasm_command, show_source_or_disasm_and_command):
591 Unify creation and re-initialization cases.
592
890b8bde
TT
5932019-07-17 Tom Tromey <tom@tromey.com>
594
595 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
596 creation and re-initialization cases.
597
2cdfa113
TT
5982019-07-17 Tom Tromey <tom@tromey.com>
599
600 * tui/tui-regs.c (tui_get_register): Return void.
601
8e3cfd09
TT
6022019-07-17 Tom Tromey <tom@tromey.com>
603
604 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
605 Simplify.
606
f4e04977
TT
6072019-07-17 Tom Tromey <tom@tromey.com>
608
609 * tui/tui-layout.c (show_source_disasm_command): Simplify window
610 resetting.
611
0379b883
TT
6122019-07-17 Tom Tromey <tom@tromey.com>
613
614 * tui/tui.h (tui_set_layout_by_name): Don't declare.
615 * tui/tui-regs.c (tui_reg_layout): New function.
616 (tui_show_registers, tui_reg_command): Use it.
617 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
618 (tui_layout_command): Rename from tui_set_layout_by_name. Change
619 parameters.
620 (tui_layout_command): Remove.
621
b7fbad91
TT
6222019-07-17 Tom Tromey <tom@tromey.com>
623
624 * tui/tui-layout.h (tui/tui-layout): Return void.
625 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
626
4e1e56b9
TT
6272019-07-17 Tom Tromey <tom@tromey.com>
628
629 * tui/tui-layout.c (show_source_disasm_command, show_data):
630 Update.
631 (reset_locator): Remove.
632 (show_source_or_disasm_and_command): Update.
633
1e0c09ba
TT
6342019-07-17 Tom Tromey <tom@tromey.com>
635
636 * tui/tui-source.c (tui_source_window_base::reset): Remove
637 win_type parameter.
638 * tui/tui-layout.c (make_command_window, make_source_window)
639 (make_disasm_window, make_data_window)
640 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
641 (reset_locator, show_source_or_disasm_and_command): Update.
642 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
643 win_type parameter.
644 (struct tui_source_window_base) <reset>: Likewise.
645
1bf605de
TT
6462019-07-17 Tom Tromey <tom@tromey.com>
647
648 * tui/tui-layout.c (show_source_disasm_command): Use
649 reset_locator.
650 (reset_locator): New function.
651 (init_and_make_win): Remove.
652 (show_source_or_disasm_and_command): Use reset_locator.
653
098f9ed4
TT
6542019-07-17 Tom Tromey <tom@tromey.com>
655
656 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
657 condition.
658 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
659 Remove condition.
660 * tui/tui-source.c (tui_source_window_base::reset): New method.
661 * tui/tui-layout.c (make_command_window): Don't call
662 init_and_make_win.
663 (make_source_window, make_disasm_window): Don't call
664 make_source_or_disasm_window.
665 (make_data_window): Don't call init_and_make_win. Change calling
666 convention.
667 (show_source_disasm_command, show_data): Simplify.
668 (make_source_or_disasm_window): Remove.
669 (show_source_or_disasm_and_command): Simplify.
670 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
671 (struct tui_source_window_base) <reset>: Likewise.
672 <execution_info>: Remove initializer.
673 * tui/tui-data.c (tui_source_window_base): Initialize
674 execution_info.
675
80110957
TT
6762019-07-17 Tom Tromey <tom@tromey.com>
677
678 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
679 variable.
680
cf82af05
TT
6812019-07-17 Tom Tromey <tom@tromey.com>
682
683 * tui/tui.c (tui_rl_other_window): Update.
684 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
685 superclass method first. Always iterate over regs_content.
686 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
687 method.
688 * tui/tui-win.c (tui_set_focus_command): Update.
689
01aeb396
TT
6902019-07-17 Tom Tromey <tom@tromey.com>
691
692 * tui/tui-win.c (tui_set_focus_command): Rename from
693 tui_set_focus. Call tui_enable.
694 (tui_set_focus_command): Remove.
695
fd6c75ee
TT
6962019-07-17 Tom Tromey <tom@tromey.com>
697
698 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
699 refresh_window.
700 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
701 touchwin.
702 (tui_data_window::refresh_window): Call refresh_window on data
703 items. Always call superclass refresh_window.
704 (tui_win_info::refresh): Remove.
705 (tui_source_window_base::refresh_window): Update.
706 (tui_refresh_all): Update.
707 * tui/tui-layout.c (show_source_disasm_command): Remove call to
708 refresh_window.
709 (show_source_or_disasm_and_command): Likewise.
710 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
711 (struct tui_source_window_base) <refresh>: Likewise.
712
f6cc34a9
TT
7132019-07-17 Tom Tromey <tom@tromey.com>
714
715 * tui/tui-winsource.c (tui_clear_source_content)
716 (tui_show_source_content): Update.
717 * tui/tui-source.c (tui_source_window::showing_source_p): Check
718 whether content is empty.
719 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
720 Remove.
721
f31ec9af
TT
7222019-07-17 Tom Tromey <tom@tromey.com>
723
724 * tui/tui-winsource.c (tui_erase_source_content): Clear the
725 window's contents.
726 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
727 * tui/tui-source.c (tui_set_source_content_nil): Remove.
728
d1b6f1e5
TT
7292019-07-17 Tom Tromey <tom@tromey.com>
730
731 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
732 (struct tui_data_item_window): Update.
733
d9743a13
TT
7342019-07-17 Tom Tromey <tom@tromey.com>
735
736 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
737 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
738 defines.
739
caf0bc4e
TT
7402019-07-17 Tom Tromey <tom@tromey.com>
741
742 * tui/tui-winsource.h (tui_erase_source_content)
743 (tui_clear_source_content): Remove "display_prompt" parameter.
744 * tui/tui-winsource.c (tui_update_source_window_as_is)
745 (tui_update_source_windows_with_addr): Update.
746 (tui_clear_source_content): Remove "display_prompt" parameter.
747 (tui_erase_source_content): Likewise. Simplify.
748 (tui_show_source_content): Update.
749 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
750 * tui/tui-stack.c (tui_show_frame_info): Update.
751 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
752 Remove defines.
753
9d391078
TT
7542019-07-17 Tom Tromey <tom@tromey.com>
755
756 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
757 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
758 parameter.
759 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
760 parameter.
761
a38da35d
TT
7622019-07-17 Tom Tromey <tom@tromey.com>
763
764 * tui/tui-winsource.c (tui_clear_source_content)
765 (tui_show_source_content, tui_show_exec_info_content)
766 (tui_clear_exec_info_content): Update.
767 * tui/tui-stack.c (tui_show_locator_content): Update.
768 (tui_show_frame_info): Update.
769 * tui/tui-source.h (tui_source_window): Don't declare.
770 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
771 from tui_source_is_displayed.
772 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
773 Remove field.
774 (struct tui_source_window_base) <content_in_use>: New field. Now
775 bool.
776 (struct tui_source_window) <showing_source_p>: New method.
777 (TUI_SRC_WIN): Change cast.
778 * tui/tui-data.c (tui_initialize_static_data): Update.
779
c2cd8994
TT
7802019-07-17 Tom Tromey <tom@tromey.com>
781
782 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
783 location_matches_p.
784 * tui/tui-source.c (tui_source_window::location_matches_p): New
785 method.
786 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
787 method.
788 * tui/tui-data.h (struct tui_source_window_base)
789 <location_matches_p>: New method.
790 (struct tui_source_window, struct tui_disasm_window)
791 <location_matches_p>: Likewise.
792
4dde7b34
TT
7932019-07-17 Tom Tromey <tom@tromey.com>
794
795 * tui/tui-win.c (tui_set_win_height_command): Rename from
796 tui_set_win_height.
797 (tui_set_win_height_command): Remove.
798
b73dd877
TT
7992019-07-17 Tom Tromey <tom@tromey.com>
800
801 * tui/tui-source.c (tui_source_window): New constructor. Add
802 observer.
803 (~tui_source_window): New destructor.
804 (tui_source_window::style_changed): New method.
805 * tui/tui-hooks.c (tui_redisplay_source): Remove.
806 (tui_attach_detach_observers): Update.
807 * tui/tui-data.h (struct tui_source_window): Make constructor not
808 inline. Add destructor.
809 (struct tui_source_window) <style_changed>: New method.
810 <m_observable>: New member.
811
ae2b5380
TT
8122019-07-17 Tom Tromey <tom@tromey.com>
813
814 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
815 * tui/tui-win.c (tui_resize_all): Fix typo.
816
1ce3e844
TT
8172019-07-17 Tom Tromey <tom@tromey.com>
818
819 * tui/tui-wingeneral.h (tui_refresh_all): Update.
820 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
821 (tui_refresh_all): Remove "list" parameter. Use foreach.
822 * tui/tui-win.c (window_name_completer): Use foreach.
823 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
824 (update_tab_width): Likewise.
825 * tui/tui-layout.c (show_layout): Update.
826 * tui/tui-data.h (class tui_window_iterator): New.
827 (struct all_tui_windows): New.
828 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
829
fe3eaf1c
TT
8302019-07-17 Tom Tromey <tom@tromey.com>
831
832 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
833 parameter. Don't reference globals.
834 (tui_reg_command): Update.
835
368c1354
TT
8362019-07-17 Tom Tromey <tom@tromey.com>
837
838 * tui/tui-regs.c (tui_show_registers): Simplify.
839
e80cd204
TT
8402019-07-17 Tom Tromey <tom@tromey.com>
841
842 * tui/tui-regs.c (tui_show_registers): Update.
843 (tui_show_register_group): Add win_info parameter.
844
aca2dd16
TT
8452019-07-17 Tom Tromey <tom@tromey.com>
846
847 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
848 Rename from tui_display_reg_element_at_line.
849 (tui_data_window::display_registers_from_line): Update.
850 * tui/tui-data.h (struct tui_data_window)
851 <display_reg_element_at_line>: New method.
852
517e9505
TT
8532019-07-17 Tom Tromey <tom@tromey.com>
854
855 * tui/tui-regs.h (tui_display_registers_from)
856 (tui_display_registers_from_line): Don't declare.
857 * tui/tui-windata.c (tui_data_window::display_all_data)
858 (tui_data_window::refresh_all)
859 (tui_data_window::do_scroll_vertical): Update.
860 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
861 from tui_display_registers_from.
862 (tui_display_reg_element_at_line): Update.
863 (tui_data_window::display_registers_from_line): Rename from
864 tui_display_registers_from_line.
865 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
866 display_registers_from_line>: New methods.
867
f76d8b19
TT
8682019-07-17 Tom Tromey <tom@tromey.com>
869
870 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
871 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
872 from tui_erase_data_content.
873 (tui_data_window::display_all_data)
874 (tui_data_window::refresh_all)
875 (tui_data_window::do_scroll_vertical): Update.
876 * tui/tui-regs.c (tui_show_registers): Update.
877 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
878 New method.
879
b4094625
TT
8802019-07-17 Tom Tromey <tom@tromey.com>
881
882 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
883 declare.
884 * tui/tui-windata.c
885 (tui_data_window::delete_data_content_windows): Rename from
886 tui_delete_data_content_windows.
887 (tui_data_window::display_all_data)
888 (tui_data_window::do_scroll_vertical): Update.
889 * tui/tui-data.h (struct tui_data_window)
890 <delete_data_content_windows>: New method.
891
c223a729
TT
8922019-07-17 Tom Tromey <tom@tromey.com>
893
894 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
895 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
896
50daf268
TT
8972019-07-17 Tom Tromey <tom@tromey.com>
898
899 * tui/tui-windata.h (tui_display_all_data): Don't declare.
900 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
901 from tui_display_all_data.
902 * tui/tui-win.c
903 (tui_data_window::do_make_visible_with_new_height): Update.
904 * tui/tui-regs.c (tui_show_registers): Update.
905 * tui/tui-layout.c (tui_set_layout): Update.
906 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
907 method.
908
df5f8cab
TT
9092019-07-17 Tom Tromey <tom@tromey.com>
910
911 * tui/tui-windata.h (tui_display_data_from): Don't declare.
912 * tui/tui-windata.c (tui_display_data_from): Remove.
913 (tui_data_window::refresh_all): Update.
914
80cb6c27
TT
9152019-07-17 Tom Tromey <tom@tromey.com>
916
917 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
918 * tui/tui-windata.c (tui_display_data_from_line): Remove.
919 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
920 tui_display_registers_from_line.
921 * tui/tui-regs.h (tui_display_registers_from_line): Update.
922 * tui/tui-regs.c (tui_display_registers_from_line): Remove
923 "force_display" parameter.
924
baff0c28
TT
9252019-07-17 Tom Tromey <tom@tromey.com>
926
927 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
928 declare.
929 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
930 Rename from tui_first_reg_element_no_inline.
931 (tui_display_reg_element_at_line)
932 (tui_display_registers_from_line): Update.
933 * tui/tui-data.h (struct tui_data_window)
934 <first_reg_element_no_inline>: New method.
935
3b23c5f2
TT
9362019-07-17 Tom Tromey <tom@tromey.com>
937
938 * tui/tui-windata.c (tui_display_data_from)
939 (tui_data_window::do_scroll_vertical): Update.
940 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
941 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
942 Rename from tui_line_from_reg_element_no.
943 (tui_display_registers_from_line): Update.
944 * tui/tui-data.h (struct tui_data_window)
945 <line_from_reg_element_no>: New method.
946
0b5ec218
TT
9472019-07-17 Tom Tromey <tom@tromey.com>
948
949 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
950 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
951 tui_last_regs_line_no.
952 (tui_display_reg_element_at_line)
953 (tui_display_registers_from_line): Update.
954 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
955 method.
956
0807ab7b
TT
9572019-07-17 Tom Tromey <tom@tromey.com>
958
959 PR tui/24722:
960 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
961 (tui_update_breakpoint_info): Add "being_deleted" parameter.
962 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
963 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
964 (tui_update_breakpoint_info): Likewise.
965 * tui/tui-hooks.c (tui_event_create_breakpoint)
966 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
967 Update.
968
9ad7fdef
TT
9692019-07-17 Tom Tromey <tom@tromey.com>
970
971 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
972
5813316f
TT
9732019-07-17 Tom Tromey <tom@tromey.com>
974
975 * tui/tui-winsource.c (tui_update_source_window_as_is)
976 (tui_update_source_windows_with_addr): Update.
977 * tui/tui-source.h (tui_set_source_content)
978 (tui_show_symtab_source): Add "win_info" parameter.
979 * tui/tui-source.c (tui_set_source_content): Add "win_info"
980 parameter.
981 (tui_show_symtab_source): Likewise.
982
00e264e7
TT
9832019-07-17 Tom Tromey <tom@tromey.com>
984
985 * tui/tui-wingeneral.c
986 (tui_check_and_display_highlight_if_needed): Check can_highlight.
987
06210ce4
TT
9882019-07-17 Tom Tromey <tom@tromey.com>
989
990 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
991 (struct tui_cmd_window) <can_scroll>: New method.
992 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
993 method.
994
381befee
TT
9952019-07-17 Tom Tromey <tromey@adacore.com>
996
997 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
998 do_field_signed>: Rename. Change type of "value".
999 * ui-out.c (ui_out::field_signed): Rename from field_int.
1000 Change type of "value".
1001 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1002 type of "value".
1003 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1004 do_field_int. Change type of "value".
1005 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1006 do_field_int. Change type of "value".
1007 * tracepoint.c (trace_status_mi, tfind_1)
1008 (print_one_static_tracepoint_marker): Update.
1009 * thread.c (print_thread_info_1, print_selected_thread_frame):
1010 Update.
1011 * stack.c (print_frame, print_frame_info): Update.
1012 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1013 Update.
1014 * source.c (print_source_lines_base): Update.
1015 * skip.c (info_skip_command): Update.
1016 * record-btrace.c (btrace_ui_out_decode_error)
1017 (btrace_call_history_src_line): Update.
1018 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1019 Update.
1020 * progspace.c (print_program_space): Update.
1021 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1022 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1023 do_field_int. Change type of "value".
1024 * mi/mi-out.c (mi_ui_out::do_table_begin)
1025 (mi_ui_out::do_table_header): Update.
1026 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1027 type of "value".
1028 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1029 (mi_cmd_data_list_changed_registers, output_register)
1030 (mi_cmd_data_read_memory, mi_load_progress)
1031 (mi_cmd_trace_frame_collected): Update.
1032 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1033 Update.
1034 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1035 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1036 (mi_cmd_var_list_children, varobj_update_one): Update.
1037 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1038 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1039 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1040 * inferior.c (print_inferior): Update.
1041 * gdb_bfd.c (print_one_bfd): Update.
1042 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1043 Update.
1044 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1045 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1046 do_field_int. Change type of "value".
1047 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1048 do_field_int. Change type of "value".
1049 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1050 (print_one_breakpoint_location, print_it_catch_fork)
1051 (print_one_catch_fork, print_it_catch_vfork)
1052 (print_one_catch_vfork, print_it_catch_solib)
1053 (print_it_catch_exec, print_it_ranged_breakpoint)
1054 (print_mention_watchpoint, print_mention_masked_watchpoint)
1055 (bkpt_print_it, update_static_tracepoint): Update.
1056 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1057 * break-catch-syscall.c (print_it_catch_syscall): Update.
1058 * ada-tasks.c (print_ada_task_info): Update.
1059 * ada-lang.c (print_it_exception, print_mention_exception):
1060 Update.
1061
6b78c3f8
AB
10622019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1063
1064 PR breakpoints/24541
1065 * gdbarch.c: Regenerate.
1066 * gdbarch.h: Regenerate.
1067 * gdbarch.sh: Adjust return type and parameter types for
1068 'stap_adjust_register'.
1069 (i386_stap_adjust_register): Adjust signature and return new
1070 register name.
1071 * stap-probe.c (stap_parse_register_operand): Adjust use of
1072 'gdbarch_stap_adjust_register'.
1073
d72a9b85
TT
10742019-07-17 Tom Tromey <tromey@adacore.com>
1075
1076 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1077 declare VEC.
1078 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1079 std::vector.
1080 (struct s390_process_info): Add initializers.
1081 (s390_add_process): Use new.
1082 (s390_linux_nat_target::low_forget_process): Use delete.
1083 (s390_linux_nat_target::low_new_fork)
1084 (s390_linux_nat_target::stopped_by_watchpoint)
1085 (s390_linux_nat_target::low_prepare_to_resume)
1086 (s390_linux_nat_target::insert_watchpoint)
1087 (s390_linux_nat_target::insert_hw_breakpoint)
1088 (s390_linux_nat_target::remove_watchpoint)
1089 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1090
206e6c58
JB
10912019-07-16 John Baldwin <jhb@FreeBSD.org>
1092
1093 * aarch64-fbsd-nat.c: Include regcache.h.
1094 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1095 argument.
1096 (aarch64_fbsd_nat_target::fetch_registers)
1097 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1098 variable.
1099 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1100
cbde90f2
JB
11012019-07-16 John Baldwin <jhb@FreeBSD.org>
1102
1103 * fbsd-nat.c: Include gdbarch.h.
1104
07128006
TT
11052019-07-15 Tom Tromey <tromey@adacore.com>
1106
1107 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1108
1f77b012
TT
11092019-07-15 Tom Tromey <tromey@adacore.com>
1110
1111 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1112 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1113 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1114 * cli-out.c (cli_ui_out::do_field_int): New method.
1115 * ui-out.c (ui_out::field_unsigned): New method.
1116 * symfile.c (generic_load): Use field_unsigned.
1117 (print_transfer_performance): Likewise.
1118 * record-btrace.c (ui_out_field_uint): Remove.
1119 (btrace_call_history_insn_range, btrace_call_history): Use
1120 field_unsigned.
1121 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1122 field_unsigned.
1123 * ui-out.h (class ui_out) <field_unsigned>: New method.
1124 <do_field_unsigned>: Likewise.
1125
33eca680
TT
11262019-07-15 Tom Tromey <tromey@adacore.com>
1127
1128 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1129 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1130 * target.c (flash_erase_command): Use field_string.
1131 * infrun.c (print_signal_received_reason): Use field_string.
1132 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1133 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1134 field_string.
1135 * ada-tasks.c (print_ada_task_info): Use field_string.
1136
ca8d69be
TT
11372019-07-15 Tom Tromey <tromey@adacore.com>
1138
1139 * target.c (flash_erase_command): Use field_core_addr.
1140 * symfile.c (generic_load): Use field_core_addr.
1141 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1142 Use field_core_addr.
1143 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1144 field_core_addr.
1145
0d4e84ed
AB
11462019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1147
1148 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1149 value if its desired type is smaller than a CORE_ADDR and signed.
1150
9a49df9d
AB
11512019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1152
1153 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1154 of changes to field names, and use new is_reference field to
1155 decide if a property is a reference or not.
1156 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1157 field.
1158 (struct dwarf2_property_baton): Update header comment, rename
1159 'referenced_type' to 'property_type' and update comments.
1160 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1161 default property type, store in property baton, update to take
1162 accound of renamed field.
1163 (read_func_scope): Update call to attr_to_dynamic_prop.
1164 (read_array_type): Likewise.
1165 (dwarf2_per_cu_addr_sized_int_type): New function.
1166 (read_subrange_index_type): Move type finding code to
1167 dwarf2_per_cu_addr_sized_int_type.
1168 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1169 (dwarf2_per_cu_addr_type): New function.
1170 (set_die_type): Update calls to attr_to_dynamic_prop.
1171
b86352cf
AB
11722019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1173
1174 * dwarf2read.c (read_subrange_index_type): New function.
1175 (read_subrange_type): Move code into new function and call it.
1176 * gdbtypes.c (create_range_type): Add some asserts.
1177
603490bf
AB
11782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1179
1180 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1181 update return statements.
1182 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1183 declaration, and update comment to match.
1184 * gdbtypes.c (resolve_dynamic_array): Update call to
1185 dwarf2_evaluate_property to match new return type.
1186
592f9d27
AB
11872019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1188
1189 * valarith.c (value_subscripted_rvalue): Change lowerbound
1190 parameter type from int to LONGEST.
1191 * value.h (value_subscripted_rvalue): Likewise in declaration.
1192
60cfcb20
AB
11932019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1194
1195 * cli/cli-utils.c (info_print_command_completer): New function.
1196 * cli/cli-utils.h: Add 'completer.h' include, and forward
1197 declaration for 'struct cmd_list_element'.
1198 (info_print_command_completer): Declare.
1199 * stack.c (_initialize_stack): Add completer for 'info locals' and
1200 'info args'.
1201 * symtab.c (_initialize_symtab): Add completer for 'info
1202 variables' and 'info functions'.
1203 * NEWS: Mention completion for additional info commands.
1204
b16507e0
AB
12052019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1206
1207 * cli/cli-utils.c (extract_info_print_args): Delete.
1208 (extract_arg_maybe_quoted): Delete.
1209 (info_print_options_defs): New variable.
1210 (make_info_print_options_def_group): New function.
1211 (extract_info_print_options): Define new function.
1212 * cli/cli-utils.h (extract_info_print_args): Delete.
1213 (struct info_print_options): New structure.
1214 (extract_info_print_options): Declare new function.
1215 * stack.c (info_locals_command): Update to use new
1216 extract_info_print_options, also add a header comment.
1217 (info_args_command): Likewise.
1218 * symtab.c (info_variables_command): Likewise.
1219 (info_functions_command): Likewise.
1220
021d8588
AB
12212019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1222
1223 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1224 to extract string arguments.
1225 * common/common-utils.c (extract_string_maybe_quoted): New function.
1226 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1227
b777eb6d
TT
12282019-07-11 Tom Tromey <tromey@adacore.com>
1229
1230 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1231 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1232 * top.h (gdbinit): Don't declare.
1233 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1234 into...
1235 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1236 * top.c (gdb_init): Don't call init_cli_cmds.
1237 (gdbinit): Remove.
1238 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1239
72ee03ff
TT
12402019-07-11 Tom Tromey <tromey@adacore.com>
1241
1242 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1243 after it has been moved.
1244
00db9531
SM
12452019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1246
1247 * valops.c (value_must_coerce_to_target): Change return type to
1248 bool.
1249 * value.h (value_must_coerce_to_target): Likewise.
1250
f2478a7e
SM
12512019-07-10 Simon Marchi <simon.marchi@efficios.com>
1252
1253 * breakpoint.c (is_hardware_watchpoint): Remove
1254 forward-declaration.
1255 (is_masked_watchpoint): Change return type to bool.
1256 (is_tracepoint): Likewise.
1257 (is_breakpoint): Likewise.
1258 (is_hardware_watchpoint): Likewise.
1259 (is_watchpoint): Likewise.
1260 (is_no_memory_software_watchpoint): Likewise.
1261 (is_catchpoint): Likewise.
1262 (breakpoint_1): Make FILTER parameter's return type bool.
1263 is_masked_watchpoint): Change return type to bool.
1264 (save_breakpoints): Make FILTER parameter's return type bool.
1265 * breakpoint.h (is_breakpoint): Change return type to bool.
1266 (is_watchpoint): Likewise.
1267 (is_catchpoint): Likewise.
1268 (is_tracepoint): Likewise.
1269
0d12e84c
TT
12702019-07-10 Tom Tromey <tom@tromey.com>
1271
1272 * defs.h: Don't include gdbarch.h.
1273 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1274 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1275 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1276 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1277 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1278 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1279 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1280 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1281 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1282 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1283 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1284 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1285 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1286 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1287 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1288 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1289 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1290 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1291 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1292 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1293 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1294 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1295 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1296 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1297 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1298 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1299 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1300
f06f1252
TT
13012019-07-10 Tom Tromey <tromey@adacore.com>
1302
1303 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1304 * breakpoint.c (init_ada_exception_breakpoint): Register as
1305 bp_catchpoint.
1306 (print_one_breakpoint_location, print_one_breakpoint): Use
1307 is_ada_exception_catchpoint.
1308 * ada-lang.c (class ada_catchpoint_location): Pass
1309 bp_loc_software_breakpoint to bp_location constructor.
1310 (is_ada_exception_catchpoint): New function.
1311
7a5d944b
TT
13122019-07-10 Tom Tromey <tromey@adacore.com>
1313
1314 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1315 VEC.
1316 (struct arm_exidx_entry): New method operator<.
1317 (struct arm_exidx_data) <section_maps>: Change type.
1318 (arm_exidx_data_free): Remove.
1319 (arm_exidx_data_key): Change type. Move lower.
1320 (arm_exidx_new_objfile): Update.
1321 (arm_compare_exidx_entries): Remove.
1322 (arm_find_exidx_entry, _initialize_arm_tdep)
1323
48c66e1d
TT
13242019-07-10 Tom Tromey <tromey@adacore.com>
1325
1326 * solib-spu.c (ocl_program_data_key): Change type.
1327 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1328 Update.
1329
a269fbf1
TT
13302019-07-10 Tom Tromey <tromey@adacore.com>
1331
1332 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1333 (struct solib_aix_inferior_data) <library_list>: Change type.
1334 (solib_aix_inferior_data_handle): Change type.
1335 (get_solib_aix_inferior_data): Update.
1336 (solib_aix_free_library_list): Remove.
1337 (library_list_start_library): Update.
1338 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1339 return type.
1340 (solib_aix_get_library_list)
1341 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1342 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1343
c294730c
TT
13442019-07-10 Tom Tromey <tromey@adacore.com>
1345
1346 * solib-dsbt.c (struct dsbt_info): Add initializers.
1347 (solib_dsbt_pspace_data): Change type.
1348 (dsbt_pspace_data_cleanup): Remove.
1349 (get_dsbt_info, _initialize_dsbt_solib): Update.
1350
9d52077d
TT
13512019-07-10 Tom Tromey <tromey@adacore.com>
1352
1353 * spu-tdep.c (spu_overlay_data): Change type.
1354 (spu_get_overlay_table, spu_overlay_new_objfile)
1355 (_initialize_spu_tdep): Update.
1356
22a20dca
TT
13572019-07-10 Tom Tromey <tromey@adacore.com>
1358
1359 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1360 destructor.
1361 (dbx_objfile_data_key): Change type and declare later.
1362 (DBX_SYMFILE_INFO): Rewrite.
1363 * dbxread.c (dbx_objfile_data_key): Change type.
1364 (dbx_symfile_init): Update.
1365 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1366 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1367 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1368
cb60f420
TT
13692019-07-10 Tom Tromey <tromey@adacore.com>
1370
1371 * jit.c (jit_program_space_key): Change type. Move lower.
1372 (get_jit_program_space_data): Update.
1373 (jit_program_space_data_cleanup): Remove.
1374 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1375 Update.
1376 (struct jit_program_space_data): Add initializers.
1377
51df2ae3
TT
13782019-07-10 Tom Tromey <tromey@adacore.com>
1379
1380 * solib-darwin.c (struct darwin_info): Add initializers.
1381 (solib_darwin_pspace_data): Change type.
1382 (darwin_pspace_data_cleanup): Remove.
1383 (get_darwin_info, _initialize_darwin_solib): Update.
1384
18101a35
TT
13852019-07-10 Tom Tromey <tromey@adacore.com>
1386
1387 * remote-sim.c (struct sim_inferior_data): Add initializers,
1388 constructor, and destructor.
1389 (sim_inferior_data_key): Change type. Move lower.
1390 (check_for_duplicate_sim_descriptor): Update.
1391 (get_sim_inferior_data): Use new. Update.
1392 (~sim_inferior_data_cleanup): Rename from
1393 sim_inferior_data_cleanup. Simplify.
1394 (gdbsim_close_inferior, simulator_command)
1395 (sim_command_completer, _initialize_remote_sim): Update.
1396 (next_pid, INITIAL_PID): Move earlier.
1397
05b08ac1
TT
13982019-07-10 Tom Tromey <tromey@adacore.com>
1399
1400 * python/python-internal.h (create_thread_object): Return
1401 gdbpy_ref.
1402 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1403 * python/py-inferior.c (struct threadlist_entry): Add
1404 constructor.
1405 <thread_obj>: Now a gdbpy_ref.
1406 (thread_to_thread_object): Update.
1407 (add_thread_object): Use new.
1408 (delete_thread_object): Use delete.
1409 (infpy_threads): Update.
1410 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1411 GIL.
1412
32372d80
TT
14132019-07-10 Tom Tromey <tromey@adacore.com>
1414
1415 * valops.c (value_cast): Specialize error message for Ada.
1416
5c458ae8
SM
14172019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1418
1419 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1420
4c462cb0
SM
14212019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1422
1423 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1424 bpstat_should_step): Return bool, adjust comments.
1425 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1426 bpstat_should_step): Likewise.
1427
89abbcc2
AH
14282019-07-10 Alan Hayward <alan.hayward@arm.com>
1429
1430 * features/Makefile: Use feature target descriptions for Arm.
1431 * features/arm/arm-core.c: Generate new file.
1432 * features/arm/arm-fpa.c: Likewise.
1433 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1434 * features/arm/arm-m-profile.c: Likewise.
1435 * features/arm/arm-vfpv2.c: Likewise.
1436 * features/arm/arm-vfpv3.c: Likewise.
1437 * features/arm/xscale-iwmmxt.c: Likewise.
1438 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1439
166a82be
AH
14402019-07-10 Alan Hayward <alan.hayward@arm.com>
1441
1442 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1443 ptrace earlier.
1444
9fb4c7e9
AH
14452019-07-10 Alan Hayward <alan.hayward@arm.com>
1446
1447 * features/aarch64-pauth.c: Regenerate.
1448
e2d0f980
SM
14492019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
1450
1451 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1452 bool.
1453 (bpstat_what): Use false instead of 0.
1454
a38118e5
PA
14552019-07-09 Pedro Alves <palves@redhat.com>
1456
1457 * break-catch-throw.c (is_exception_catchpoint): New.
1458 * breakpoint.c (print_one_breakpoint_location): New parameter
1459 'raw_loc'. Handle it. Use
1460 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1461 looking at the breakpoint's type.
1462 (print_one_breakpoint): If handling "maint info breakpoints", also
1463 print locations of exception catchpoints.
1464 * breakpoint.h (is_exception_catchpoint): Declare.
1465
cb1e4e32
PA
14662019-07-09 Pedro Alves <palves@redhat.com>
1467
1468 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1469 "addr" field.
1470 (allocate_location_exception_catchpoint): New.
1471 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1472 (initialize_throw_catchpoint_ops): Install
1473 allocate_location_exception_catchpoint as allocate_location
1474 method.
1475 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1476 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1477 bp_loc_other.
1478 (breakpoint_address_is_meaningful): Delete.
1479 (bl_address_is_meaningful): New.
1480 (breakpoint_locations_match): Adjust comment.
1481 (bp_location_from_bp_type): New, factored out of...
1482 (bp_location::bp_location(breakpoint *)): ... this.
1483 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1484 factored out of...
1485 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
1486 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1487 breakpoint_address_is_meaningful.
1488 (bp_locations_compare): Adjust comment.
1489 (update_global_location_list): Use bl_address_is_meaningful
1490 instead of breakpoint_address_is_meaningful.
1491 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1492 explicit.
1493 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1494 * python/py-breakpoint.c (bppy_get_location): No longer check
1495 whether location is null.
1496
b58a68fe
PA
14972019-07-09 Pedro Alves <palves@redhat.com>
1498
1499 PR c++/15468
1500 * breakpoint.c (print_one_breakpoint_location): Remove
1501 single-location assert.
1502
268a13a5
TT
15032019-07-09 Tom Tromey <tom@tromey.com>
1504
1505 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1506 * configure: Rebuild.
1507 * configure.ac: Change common to gdbsupport.
1508 * gdbsupport: Rename from common.
1509 * acinclude.m4: Change common to gdbsupport.
1510 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1511 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1512 gdbsupport.
1513 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1514 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1515 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1516 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1517 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1518 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1519 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1520 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1521 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1522 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1523 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1524 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1525 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1526 coff-pe-read.c, command.h, compile/compile-c-support.c,
1527 compile/compile-c.h, compile/compile-cplus-symbols.c,
1528 compile/compile-cplus-types.c, compile/compile-cplus.h,
1529 compile/compile-loc2c.c, compile/compile.c, completer.c,
1530 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1531 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1532 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1533 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1534 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1535 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1536 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1537 features/aarch64-core.c, features/aarch64-fpu.c,
1538 features/aarch64-pauth.c, features/aarch64-sve.c,
1539 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1540 features/i386/32bit-core.c, features/i386/32bit-linux.c,
1541 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1542 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1543 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1544 features/i386/64bit-core.c, features/i386/64bit-linux.c,
1545 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1546 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1547 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1548 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1549 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1550 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1551 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1552 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1553 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1554 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1555 go32-nat.c, guile/guile.c, guile/scm-ports.c,
1556 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1557 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1558 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1559 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1560 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1561 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1562 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1563 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1564 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1565 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1566 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1567 minsyms.c, mips-linux-tdep.c, namespace.h,
1568 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1569 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1570 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1571 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1572 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1573 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1574 nat/linux-waitpid.c, nat/mips-linux-watch.c,
1575 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1576 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1577 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1578 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1579 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1580 procfs.c, producer.c, progspace.h, psymtab.h,
1581 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1582 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1583 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1584 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1585 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1586 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1587 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1588 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1589 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1590 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1591 target-memory.c, target.c, target.h, target/waitstatus.c,
1592 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1593 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1594 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1595 unittests/array-view-selftests.c,
1596 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1597 unittests/common-utils-selftests.c,
1598 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1599 unittests/format_pieces-selftests.c,
1600 unittests/function-view-selftests.c,
1601 unittests/lookup_name_info-selftests.c,
1602 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1603 unittests/mkdir-recursive-selftests.c,
1604 unittests/observable-selftests.c,
1605 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1606 unittests/parse-connection-spec-selftests.c,
1607 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1608 unittests/scoped_fd-selftests.c,
1609 unittests/scoped_mmap-selftests.c,
1610 unittests/scoped_restore-selftests.c,
1611 unittests/string_view-selftests.c, unittests/style-selftests.c,
1612 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1613 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1614 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1615 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1616 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1617 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1618
5b0e2db4
AB
16192019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1620
1621 * linespec.c (decode_digits_list_mode): Set explicit_line to a
1622 bool value.
1623 (decode_digits_ordinary): Set explicit_line field in sal.
1624 * symtab.c (skip_prologue_sal): Don't skip prologue for a
1625 symtab_and_line that was set on an explicit line number in
1626 assembler code. Do always update the recorded symtab and line if
1627 we do skip the prologue.
1628
0ba852ab
AB
16292019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1630
1631 * breakpoint.c (set_breakpoint_location_function): Remove
1632 explicit_loc parameter.
1633 (momentary_breakpoint_from_master): Update call to
1634 set_breakpoint_location_function.
1635 (add_location_to_breakpoint): Likewise.
1636
b3a7d171
AB
16372019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
1638
1639 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1640 required features based on default bfd type when no specific bfd
1641 is present.
1642
1f6f6e21
PW
16432019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1644
1645 * NEWS: Mention that GDB printf and eval commands can now print
1646 C-style and Ada-style convenience var strings without
1647 calling the inferior.
1648 * printcmd.c (printf_c_string): Locally print GDB internal var
1649 instead of transiting via the inferior.
1650 (printf_wide_c_string): Likewise.
1651
16522019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
1653
1654 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1655
0598af48
TT
16562019-07-04 Tom Tromey <tom@tromey.com>
1657
1658 PR tui/24724:
1659 * tui/tui-winsource.c (tui_clear_source_content): Update.
1660 (tui_source_window_base::set_is_exec_point_at): Fix comment.
1661 (tui_update_breakpoint_info): Update.
1662 (tui_set_exec_info_content): Update.
1663 * tui/tui-source.c (tui_set_source_content_nil): Update.
1664 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1665 has_break.
1666 * tui/tui-data.h (enum tui_bp_flag): New.
1667 (tui_bp_flags): New enum flags type.
1668 (struct tui_source_element) <break_mode>: Change type. Rename
1669 from has_break.
1670 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1671 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
1672 constants.
1673 * tui/tui-winsource.h: Fix comment.
1674
350fab54
AH
16752019-07-04 Alan Hayward <alan.hayward@arm.com>
1676
1677 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1678 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1679 (store_fpregs_to_thread)
1680 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1681 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1682 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1683 (IWMMXT_REGS_SIZE): Add define.
1684 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1685 (fetch_vfp_regs, store_vfp_regs)
1686 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1687 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1688
f0452268
AH
16892019-07-04 Alan Hayward <alan.hayward@arm.com>
1690
1691 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1692 defines.
1693 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1694 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1695 (ARM_INT_REGISTER_SIZE): ...to this.
1696 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1697 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1698 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1699 (arm_linux_collect_gregset, supply_nwfpe_register)
1700 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1701 defines.
1702 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1703 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1704 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1705 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1706 (arm_return_in_memory, arm_store_return_value)
1707 (arm_get_longjmp_target, arm_register_g_packet_guesses)
1708 (arm_record_ld_st_multiple): Likewise.
1709 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1710 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1711
e935475c
AH
17122019-07-04 Alan Hayward <alan.hayward@arm.com>
1713
1714 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1715 AARCH64_DISPLACED_MODIFIED_INSNS.
1716 * aarch64-tdep.c (struct aarch64_displaced_step_data)
1717 (aarch64_displaced_step_copy_insn): Likewise.
1718 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1719 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1720 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1721 ARM_DISPLACED_MODIFIED_INSNS.
1722 * arm-tdep.c (arm_gdbarch_init): Likewise.
1723 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1724 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1725 (struct arm_displaced_step_closure): Use
1726 ARM_DISPLACED_MODIFIED_INSNS.
1727
df0bb381
AH
17282019-07-04 Alan Hayward <alan.hayward@arm.com>
1729
1730 * features/Makefile: Remove unused xml files.
1731 * features/aarch64.xml: Remove.
1732 * features/i386/amd64-avx-avx512-linux.xml: Remove.
1733 * features/i386/amd64-avx-avx512.xml: Remove.
1734 * features/i386/amd64-avx-linux.xml: Remove.
1735 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1736 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1737 * features/i386/amd64-avx-mpx-linux.xml: Remove.
1738 * features/i386/amd64-avx-mpx.xml: Remove.
1739 * features/i386/amd64-avx.xml: Remove.
1740 * features/i386/amd64-linux.xml: Remove.
1741 * features/i386/amd64-mpx-linux.xml: Remove.
1742 * features/i386/amd64-mpx.xml: Remove.
1743 * features/i386/amd64.xml: Remove.
1744 * features/i386/i386-avx-avx512-linux.xml: Remove.
1745 * features/i386/i386-avx-avx512.xml: Remove.
1746 * features/i386/i386-avx-linux.xml: Remove.
1747 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1748 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1749 * features/i386/i386-avx-mpx-linux.xml: Remove.
1750 * features/i386/i386-avx-mpx.xml: Remove.
1751 * features/i386/i386-avx.xml: Remove.
1752 * features/i386/i386-linux.xml: Remove.
1753 * features/i386/i386-mmx-linux.xml: Remove.
1754 * features/i386/i386-mmx.xml: Remove.
1755 * features/i386/i386-mpx-linux.xml: Remove.
1756 * features/i386/i386-mpx.xml: Remove.
1757 * features/i386/i386.xml: Remove.
1758 * features/i386/x32-avx-avx512-linux.xml: Remove.
1759 * features/i386/x32-avx-linux.xml: Remove.
1760 * features/i386/x32-linux.xml: Remove.
1761
edd6266a
AH
17622019-07-04 Alan Hayward <alan.hayward@arm.com>
1763
1764 * regformats/aarch64.dat: Remove.
1765 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1766 * regformats/i386/amd64-avx-linux.dat: Remove.
1767 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1768 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1769 * regformats/i386/amd64-linux.dat: Remove.
1770 * regformats/i386/amd64-mpx-linux.dat: Remove.
1771 * regformats/i386/amd64.dat: Remove.
1772 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1773 * regformats/i386/i386-avx-linux.dat: Remove.
1774 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1775 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1776 * regformats/i386/i386-linux.dat: Remove.
1777 * regformats/i386/i386-mmx-linux.dat: Remove.
1778 * regformats/i386/i386-mpx-linux.dat: Remove.
1779 * regformats/i386/i386.dat: Remove.
1780 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1781 * regformats/i386/x32-avx-linux.dat: Remove.
1782 * regformats/i386/x32-linux.dat: Remove.
1783
2b40fda7
AH
17842019-07-04 Alan Hayward <alan.hayward@arm.com>
1785
1786 * aarch64-tdep.c: Remove xml self tests.
1787 * amd64-linux-tdep.c: Likewise.
1788 * amd64-tdep.c: Likewise.
1789 * i386-linux-tdep.c: Likewise.
1790 * i386-tdep.c: Likewise.
1791
5f4ba3e7
PA
17922019-07-03 Pedro Alves <palves@redhat.com>
1793
1794 PR cli/24732
1795 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1796 (pipe_cmd_option_defs): New.
1797 (make_pipe_cmd_options_def_group): New.
1798 (pipe_command): Use gdb::option::process_options.
1799 (pipe_command_completer): New function.
1800 (_initialize_cli_cmds): Install completer for "pipe" command.
1801
3d9be6f5
PA
18022019-07-03 Pedro Alves <palves@redhat.com>
1803
1804 * cli/cli-option.c (union option_value) <string>: New field.
1805 (struct option_def_and_value): Add ctor, move ctor, dtor and
1806 use DISABLE_COPY_AND_ASSIGN.
1807 (option_def_and_value::clear_value): New.
1808 (parse_option, save_option_value_in_ctx, get_val_type_str)
1809 (add_setshow_cmds_for_options): Handle var_string.
1810 * cli-option.h (union option_def::var_address) <string>: New
1811 field.
1812 (struct string_option_def): New.
1813 * maint-test-options.c (struct test_options_opts): Add default
1814 ctor and use DISABLE_COPY_AND_ASSIGN.
1815 <string_opt>: New field.
1816 (test_options_opts::~test_options_opts): New.
1817 (test_options_opts::dump): Also dump "-string".
1818 (test_options_option_defs): Install "string.
1819
41fc454c
PA
18202019-07-03 Pedro Alves <palves@redhat.com>
1821
1822 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1823 option_value with a null enumeration.
1824 (complete_options): Save the option values in the context.
1825 (save_option_value_in_ctx): New, factored out from ...
1826 (process_options): ... here.
1827 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1828 of the function.
1829 * maint-test-options.c (test_options_opts::dump): New, factored
1830 out from ...
1831 (maintenance_test_options_command_mode): ... here.
1832 (maintenance_test_options_command_completion_result): Delete.
1833 (maintenance_test_options_command_completion_text): Update
1834 comment.
1835 (maintenance_show_test_options_completion_result): Change
1836 prototype. Just print
1837 maintenance_test_options_command_completion_text.
1838 (save_completion_result): New.
1839 (maintenance_test_options_completer_mode): Pass options context to
1840 complete_options, and then save a dump.
1841 (_initialize_maint_test_options): Use add_cmd to install "maint
1842 show test-options-completion-result".
1843
fdbc9870
PA
18442019-07-03 Pedro Alves <palves@redhat.com>
1845
1846 * NEWS (New commands): Mention "with" and "maint with".
1847 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1848 (with_command, with_command_completer): New.
1849 (pipe_command): Adjust to new repeat_previous
1850 interface.
1851 (_initialize_cli_cmds): Install the "with" command and its "w"
1852 alias.
1853 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1854 declarations.
1855 * cli/cli-setshow.c (parse_cli_var_uinteger)
1856 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1857 argument strings for all var_types.
1858 (get_setshow_command_value_string): New, factored out from ...
1859 (do_show_command): ... this.
1860 * cli/cli-setshow.h: Include <string>.
1861 (get_setshow_command_value_string): Declare.
1862 * command.h (repeat_previous): Now returns const char *. Adjust
1863 comment.
1864 * maint.c: Include "cli/cli-cmds.h".
1865 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1866 (_initialize_maint_cmds): Register the "maintenance with" command.
1867 * top.c (repeat_previous): Move bits from pipe_command here:
1868 Return the saved command line, if any; error out if there's no
1869 command to relaunch.
1870
c6ac8931
PA
18712019-07-03 Pedro Alves <palves@redhat.com>
1872
1873 * NEWS (New commands): Mention "maint set/show test-settings"
1874 instead of "maint test-settings".
1875 * maint-test-settings.c (maintenance_test_settings_list): Delete.
1876 (maintenance_test_settings_set_list): Rename to ...
1877 (maintenance_set_test_settings_list): ... this.
1878 (maintenance_test_settings_show_list): Rename to ...
1879 (maintenance_show_test_settings_list): ... this.
1880 (maintenance_test_settings_cmd): Delete.
1881 (maintenance_test_settings_set_cmd): ...
1882 (maintenance_set_test_settings_cmd): ... this.
1883 (maintenance_test_settings_show_cmd): ...
1884 (maintenance_show_test_settings_cmd): ... this.
1885 (maintenance_test_settings_show_value_cmd):
1886 (maintenance_show_test_settings_value_cmd): ... this.
1887 (_initialize_maint_test_settings): No longer install the "maint
1888 test-settings" prefix command. Rename "maint test-settings set"
1889 to "maint set test-settings", and "maint test-settings show" to
1890 "maint show test-settings". Adjust all subcommands.
1891
d1fcf2fd
PA
18922019-07-03 Pedro Alves <palves@redhat.com>
1893
1894 * maint-test-settings.c: Fix file's intro comment. Replace all
1895 references to "test-options" with references to "test-settings",
1896 in comments.
1897
970f9d09
PA
18982019-07-03 Pedro Alves <palves@redhat.com>
1899
1900 * maint-test-settings.c (maintenance_test_settings_xxx)
1901 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1902 New.
1903 (maintenance_test_settings_enums): Use them.
1904 (maintenance_test_settings_enum): Default to
1905 maintenance_test_settings_xxx.
1906 (_initialize_maint_test_settings): Initialize
1907 MAINTENANCE_TEST_SETTINGS_FILENAME.
1908
f3869b1a
SM
19092019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1910
1911 * breakpoint.h (remove_breakpoints_inf): Change return type to
1912 void, move function documentation here.
1913 * breakpoint.c (remove_breakpoints_inf): Change return type to
1914 void, move function documentation to header.
1915
54d66006
PA
19162019-07-02 Pedro Alves <palves@redhat.com>
1917
1918 * NEWS (Completion improvements): Mention "info threads".
1919 * thread.c (struct info_threads_opts, info_threads_option_defs)
1920 (make_info_threads_options_def_group): New.
1921 (info_threads_command): Use gdb::option::process_options.
1922 (info_threads_command_completer): New.
1923 (_initialize_thread): Use gdb::option::build_help to build the
1924 help text for "info threads".
1925
854f6088
SM
19262019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
1927
1928 * defs.h (generic_load): Move from here...
1929 * symfile.h (generic_load): ... to here. Rename name parameter
1930 to args.
1931 * symfile.c (generic_load): Add comment.
1932
54ee4252
TT
19332019-07-01 Tom Tromey <tromey@adacore.com>
1934
1935 * dwarf2read.c
1936 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1937 declaration of without_params. Fix formatting.
1938
65392b3e
TT
19392019-07-01 Tom Tromey <tromey@adacore.com>
1940
1941 * ada-exp.y (find_primitive_type): Update.
1942 * ada-lang.h (ada_lookup_symbol): Update.
1943 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1944 parameter.
1945 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1946
7d7571f0
SDJ
19472019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1948
1949 PR breakpoints/24541
1950 * gdbarch.c: Regenerate.
1951 * gdbarch.h: Regenerate.
1952 * gdbarch.sh: Add 'stap_adjust_register'.
1953 * i386-tdep.c: Include '<unordered_set>'.
1954 (i386_stap_adjust_register): New function.
1955 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1956 * stap-probe.c (stap_parse_register_operand): Call
1957 'gdbarch_stap_adjust_register'.
1958
5af5392a
SDJ
19592019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
1960
1961 PR python/24742
1962 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1963 * python/python.c (do_start_initialization): Use 'xmalloc'
1964 instead of 'PyMem_Malloc'.
1965
10d06d82
TT
19662019-06-28 Tom Tromey <tromey@adacore.com>
1967
1968 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1969 for Ada.
1970
1b7f24cd
TT
19712019-06-27 Tom Tromey <tromey@adacore.com>
1972
1973 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
1974 objfile_key.
1975 (arm_find_mapping_symbol, arm_record_special_symbol)
1976 (_initialize_arm_tdep): Update.
1977 (arm_objfile_data_free): Remove.
1978
3d507ff2
TT
19792019-06-27 Tom Tromey <tromey@adacore.com>
1980
1981 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1982 to cp_print_static_field.
1983
762c164d
TT
19842019-06-26 Tom Tromey <tromey@adacore.com>
1985
1986 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1987 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1988 declare.
1989
aa2f9bcf
AH
19902019-06-26 Alan Hayward <alan.hayward@arm.com>
1991
1992 * features/aarch64-core.c (create_feature_aarch64_core):
1993 Regenerate.
1994 * features/aarch64-core.xml: Add cpsr flags.
1995
3426ae57
AH
19962019-06-26 Alan Hayward <alan.hayward@arm.com>
1997
1998 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1999 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2000
4838e44c
SM
20012019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2002
2003 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2004 field.
2005 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2006 use.
2007 (arm_record_special_symbol): Don't insert new symbol in sorted
2008 position, push it at the end.
2009
54cc7474
SM
20102019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2011
2012 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2013 (arm_mapping_symbol_s): Remove.
2014 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2015 (arm_mapping_symbol_vec): New typedef.
2016 (struct arm_per_objfile): Add constructor.
2017 <section_maps>: Change type to
2018 std::unique_ptr<arm_mapping_symbol_vec[]>.
2019 (arm_compare_mapping_symbols): Remove.
2020 (arm_find_mapping_symbol): Adjust to section_maps type change.
2021 (arm_objfile_data_free): Call delete on arm_per_objfile.
2022 (arm_record_special_symbol): Adjust to section_maps type change.
2023 Allocate arm_per_objfile with new.
2024
b65b566c
PW
20252019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2026
2027 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2028 with the command prefix.
2029
c2fc64f5
TT
20302019-06-25 Tom Tromey <tom@tromey.com>
2031
2032 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2033 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2034
fb54fa76
TT
20352019-06-25 Tom Tromey <tom@tromey.com>
2036
2037 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2038 type.
2039 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2040 protected.
2041
f7952c57
TT
20422019-06-25 Tom Tromey <tom@tromey.com>
2043
2044 * tui/tui-winsource.c
2045 (tui_source_window_base::set_is_exec_point_at): Add check against
2046 LOA_ADDRESS.
2047
17568d78
TT
20482019-06-25 Tom Tromey <tom@tromey.com>
2049
2050 * tui/tui-source.c (tui_set_source_content): Don't check before
2051 xfree.
2052 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2053
53e7cdba
TT
20542019-06-25 Tom Tromey <tom@tromey.com>
2055
2056 * tui/tui-winsource.h (tui_update_source_window_as_is)
2057 (tui_alloc_source_buffer, tui_line_is_displayed)
2058 (tui_addr_is_displayed): Change type of win_info.
2059 * tui/tui-winsource.c (tui_update_source_window_as_is)
2060 (tui_clear_source_content, tui_show_source_line)
2061 (tui_show_source_content, tui_source_window_base::refill)
2062 (tui_source_window_base::set_is_exec_point_at)
2063 (tui_source_window_base::set_is_exec_point_at)
2064 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2065 (tui_alloc_source_buffer, tui_line_is_displayed)
2066 (tui_addr_is_displayed): Change type of win_info. Update.
2067 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2068 (tui_source_window_base::do_make_visible_with_new_height):
2069 Update.
2070 * tui/tui-source.c (tui_set_source_content)
2071 (tui_set_source_content_nil)
2072 (tui_source_window::do_scroll_vertical): Update.
2073 * tui/tui-layout.c (show_layout): Update.
2074 * tui/tui-disasm.c (tui_set_disassem_content)
2075 (tui_disasm_window::do_scroll_vertical): Update.
2076 * tui/tui-data.h (tui_win_content): Remove.
2077 (struct tui_gen_win_info) <content, content_size>: Remove.
2078 (struct tui_source_element): Add initializers and destructor.
2079 (union tui_which_element, struct tui_win_element): Remove.
2080 (struct tui_source_window_base) <content>: New field.
2081 (struct tui_data_window): Remove destructor.
2082 (tui_alloc_content, tui_free_win_content)
2083 (tui_free_all_source_wins_content): Don't declare.
2084 * tui/tui-data.c (tui_initialize_static_data): Update.
2085 (init_content_element, tui_alloc_content): Remove.
2086 (~tui_gen_win_info): Update.
2087 (~tui_data_window, tui_free_all_source_wins_content)
2088 (tui_free_win_content, free_content, free_content_elements):
2089 Remove.
2090
7908abbf
TT
20912019-06-25 Tom Tromey <tom@tromey.com>
2092
2093 * tui/tui-winsource.h (tui_clear_source_content)
2094 (tui_erase_source_content, tui_show_source_content): Change type
2095 of win_info.
2096 * tui/tui-winsource.c (tui_clear_source_content)
2097 (tui_erase_source_content, tui_show_source_content): Change type
2098 of win_info.
2099 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2100 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2101 win_info.
2102 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2103 win_info.
2104 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2105
02c28df0
TT
21062019-06-25 Tom Tromey <tom@tromey.com>
2107
2108 * tui/tui-winsource.c (tui_clear_source_content)
2109 (tui_source_window_base::set_is_exec_point_at): Update.
2110 * tui/tui-source.c (tui_set_source_content_nil): Update.
2111 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2112 a bool.
2113 * tui/tui-data.c (init_content_element): Update.
2114
6658b1bf
TT
21152019-06-25 Tom Tromey <tom@tromey.com>
2116
2117 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2118 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2119 * tui/tui-layout.c (init_and_make_win): Update.
2120 * tui/tui.h (enum tui_win_type): Update.
2121 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2122 tui_win_is_auxillary.
2123 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2124 tui_win_is_auxillary.
2125
21e1c91e
TT
21262019-06-25 Tom Tromey <tom@tromey.com>
2127
2128 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2129 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2130 (tui_delete_data_content_windows, tui_display_all_data)
2131 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2132 Update.
2133 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2134 * tui/tui-regs.c (tui_last_regs_line_no)
2135 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2136 (tui_show_registers): Update.
2137 (tui_show_register_group): Return void. Update.
2138 (tui_display_registers_from, tui_display_reg_element_at_line)
2139 (tui_display_registers_from_line, tui_check_register_values):
2140 Update.
2141 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2142 member.
2143 (struct tui_data_window) <regs_content>: Now a std::vector.
2144 <regs_content_count>: Remove.
2145 (tui_add_content_elements, tui_free_data_content): Don't declare.
2146 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2147 (init_content_element): Remove DATA_WIN case. Add assert.
2148 (tui_add_content_elements): Remove.
2149 (tui_data_window): Update.
2150 (tui_free_data_content): Remove.
2151 (free_content_elements): Remove DATA_WIN case.
2152
115ac53b
TT
21532019-06-25 Tom Tromey <tom@tromey.com>
2154
2155 * tui/tui-data.c (tui_data_item_window): Update.
2156 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2157 * tui/tui-windata.c (tui_display_all_data)
2158 (tui_display_data_from_line): Update.
2159 (tui_check_data_values): Remove.
2160 * tui/tui-regs.c (tui_show_register_group)
2161 (tui_display_reg_element_at_line): Update.
2162 * tui/tui-hooks.c (tui_register_changed)
2163 (tui_refresh_frame_and_register_information): Call
2164 tui_check_register_values.
2165 * tui/tui-data.h (struct tui_data_window) <data_content,
2166 data_content_count, data_type>: Remove.
2167 (enum tui_data_type): Remove.
2168
2169 * tui/tui-data.c (tui_data_window::clear_detail)
2170 (~tui_data_window): Update.
2171
eaf9738b
TT
21722019-06-25 Tom Tromey <tom@tromey.com>
2173
2174 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2175 declare.
2176 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2177 Rename from tui_first_data_item_displayed. Update.
2178 (tui_data_window::refresh_all)
2179 (tui_data_window::do_scroll_vertical): Update.
2180 * tui/tui-data.h (struct tui_data_window)
2181 <first_data_item_displayed>: Declare new method.
2182
31ca4723
TT
21832019-06-25 Tom Tromey <tom@tromey.com>
2184
2185 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2186 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2187 contents...
2188 (tui_initialize_static_data): ...here.
2189
41bcff7f
TT
21902019-06-25 Tom Tromey <tom@tromey.com>
2191
2192 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2193 (tui_display_registers_from, tui_check_register_values): Update.
2194 (tui_display_register): Remove win_info parameter; update.
2195 (tui_get_register): Change type of parameters.
2196 * tui/tui-data.h (struct tui_data_element): Remove.
2197 (union tui_which_element) <data>: Remove.
2198 <data_window>: Change type.
2199 (struct tui_data_item_window): New.
2200 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2201 case. Add assert.
2202 (~tui_data_item_window): New destructor.
2203 (free_content_elements): Remove DATA_ITEM_WIN case.
2204
d2802c33
TT
22052019-06-25 Tom Tromey <tom@tromey.com>
2206
2207 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2208 Remove.
2209
dd835f8b
TT
22102019-06-25 Tom Tromey <tom@tromey.com>
2211
2212 * tui/tui-data.h (struct tui_command_element): Remove.
2213 (union tui_which_element) <command>: Remove.
2214 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2215 assert.
2216 (free_content_elements): Remove CMD_WIN case.
2217
bd7db367
TT
22182019-06-25 Tom Tromey <tom@tromey.com>
2219
2220 * tui/tui-layout.c (tui_set_layout): Update.
2221 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2222 * tui/tui-data.c (layout_def): Update.
2223
3add462f
TT
22242019-06-25 Tom Tromey <tom@tromey.com>
2225
2226 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2227 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2228 (tui_source_window_base::set_new_height): Update.
2229 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2230 Update.
2231 (tui_set_locator_fullname, tui_set_locator_info)
2232 (tui_show_frame_info): Update.
2233 * tui/tui-source.c (tui_set_source_content)
2234 (tui_source_is_displayed): Update.
2235 * tui/tui-layout.c (show_source_disasm_command, show_data)
2236 (show_source_or_disasm_and_command): Update.
2237 * tui/tui-disasm.c (tui_set_disassem_content)
2238 (tui_get_begin_asm_address): Update.
2239 * tui/tui-data.h (struct tui_locator_element): Remove.
2240 (union tui_which_element) <locator>: Remove.
2241 (struct tui_locator_window): New.
2242 (tui_locator_win_info_ptr): Change return type.
2243 * tui/tui-data.c (_locator): Change type.
2244 (tui_locator_win_info_ptr): Change return type.
2245 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2246 (tui_alloc_content): Add assert.
2247
489e9d8b
TT
22482019-06-25 Tom Tromey <tom@tromey.com>
2249
2250 * tui/tui-winsource.c
2251 (tui_exec_info_window::maybe_allocate_content): New method.
2252 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2253 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2254 (make_source_or_disasm_window): Add cast.
2255 * tui/tui-data.h (union tui_which_element) <simple_string>:
2256 Remove.
2257 (struct tui_source_info): New.
2258 (struct tui_source_window_base) <execution_info>: Change type.
2259 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2260 case, and add assert.
2261 (tui_alloc_content): Add assert.
2262
c3fabb7d
TT
22632019-06-25 Tom Tromey <tom@tromey.com>
2264
2265 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2266 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2267 * tui/tui-data.c (tui_alloc_win_info): Remove.
2268
bbc228ee
TT
22692019-06-25 Tom Tromey <tom@tromey.com>
2270
2271 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2272 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2273 can_highlight.
2274
5fcee43a
TT
22752019-06-25 Tom Tromey <tom@tromey.com>
2276
2277 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2278 make_visible_with_new_height method.
2279 (tui_win_info::make_visible_with_new_height): New method.
2280 (tui_source_window_base::do_make_visible_with_new_height)
2281 (tui_data_window::do_make_visible_with_new_height)
2282 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2283 (make_visible_with_new_height): Remove.
2284 (tui_resize_all, tui_adjust_win_heights): Use
2285 make_visible_with_new_height method.
2286 * tui/tui-data.h (struct tui_win_info)
2287 <do_make_visible_with_new_height, make_visible_with_new_height>:
2288 New methods.
2289 (struct tui_source_window_base, struct tui_data_window)
2290 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2291 methods.
2292
d83f1fe6
TT
22932019-06-25 Tom Tromey <tom@tromey.com>
2294
2295 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2296 method.
2297 (update_tab_width): Call update_tab_width method.
2298 * tui/tui-data.h (struct tui_win_info)
2299 (struct tui_source_window_base) <update_tab_width>: New methods.
2300
17374de4
TT
23012019-06-25 Tom Tromey <tom@tromey.com>
2302
2303 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2304 parameter.
2305 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2306 parameter.
2307 (tui_gen_win_info::make_visible): Update.
2308 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2309 parameter.
2310 * tui/tui-data.h (enum tui_box): New enum.
2311 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2312
f936bca2
TT
23132019-06-25 Tom Tromey <tom@tromey.com>
2314
2315 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2316 init_and_make_win for EXEC_INFO_WIN.
2317 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2318 longer inline.
2319 (struct tui_win_info) <~tui_win_info>: Inline.
2320 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2321 Don't declare.
2322 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2323 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2324 Remove.
2325 (tui_initialize_static_data): Update.
2326 (~tui_gen_win_info): Handle more cleanup here.
2327 (~tui_source_window_base): Delete "execution_info".
2328 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2329
d6ba6a11
TT
23302019-06-25 Tom Tromey <tom@tromey.com>
2331
2332 * tui/tui-layout.c (make_command_window): Don't set
2333 can_highlight.
2334 (show_source_disasm_command): Call the reset method.
2335 (show_data): Don't set can_highlight. Call the reset method.
2336 (tui_gen_win_info::reset): Rename from init_gen_win_info
2337 (init_and_make_win): Simplify. Return tui_gen_win_info.
2338 (show_source_or_disasm_and_command): Call the reset method.
2339 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2340 (struct tui_cmd_window): Set can_highlight.
2341
48a3bd16
TT
23422019-06-25 Tom Tromey <tom@tromey.com>
2343
2344 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2345 from make_visible.
2346 (tui_make_visible, tui_make_invisible): Rewrite.
2347 (tui_win_info::make_visible): Remove.
2348 (tui_source_window_base::make_visible): Update.
2349 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2350 method. Moved from...
2351 (struct tui_win_info) <make_visible>: ...here.
2352
c3bd716f
TT
23532019-06-25 Tom Tromey <tom@tromey.com>
2354
2355 * tui/tui-winsource.c
2356 (tui_source_window_base::do_scroll_horizontal): Remove direction
2357 parameter.
2358 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2359 direction parameter.
2360 * tui/tui-win.c (tui_win_info::forward_scroll)
2361 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2362 (tui_win_info::right_scroll): Update.
2363 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2364 direction parameter.
2365 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2366 direction parameter.
2367 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2368 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2369 Remove direction parameter.
2370 (struct tui_source_window_base, struct tui_source_window)
2371 (struct tui_disasm_window, struct tui_data_window)
2372 (struct tui_cmd_window): Update.
2373
21c32dca
TT
23742019-06-25 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-winsource.h (tui_set_exec_info_content)
2377 (tui_show_exec_info_content, tui_erase_exec_info_content)
2378 (tui_clear_exec_info_content, tui_update_exec_info): Change
2379 argument to tui_source_window_base.
2380 * tui/tui-winsource.c (tui_set_exec_info_content)
2381 (tui_show_exec_info_content, tui_erase_exec_info_content)
2382 (tui_clear_exec_info_content, tui_update_exec_info): Change
2383 argument to tui_source_window_base.
2384
73fbdc65
TT
23852019-06-25 Tom Tromey <tom@tromey.com>
2386
2387 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2388 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2389
33325343
TT
23902019-06-25 Tom Tromey <tom@tromey.com>
2391
2392 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2393 check.
2394
29d2c474
TT
23952019-06-25 Tom Tromey <tom@tromey.com>
2396
2397 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2398 type to void.
2399 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2400 type to void.
2401 * tui/tui-source.c (tui_set_source_content): Update.
2402 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2403
152f3f4b
TT
24042019-06-25 Tom Tromey <tom@tromey.com>
2405
2406 * tui/tui-win.c (window_name_completer, tui_set_focus)
2407 (tui_all_windows_info): Use name method.
2408 * tui/tui-data.h (struct tui_gen_win_info)
2409 (struct tui_source_window, struct tui_disasm_window)
2410 (struct tui_data_window, struct tui_cmd_window) <name>: New
2411 method.
2412 (tui_win_name): Don't declare.
2413 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2414 (tui_win_name): Remove.
2415
be4da588
TT
24162019-06-25 Tom Tromey <tom@tromey.com>
2417
2418 * tui/tui-winsource.h (tui_update_source_window)
2419 (tui_update_source_window_as_is): Change parameter type.
2420 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2421 to be a tui_source_window_base.
2422 (tui_update_source_window_as_is): Likewise.
2423 * tui/tui-win.c (make_visible_with_new_height): Update.
2424
5b81daba
TT
24252019-06-25 Tom Tromey <tom@tromey.com>
2426
2427 * tui/tui-winsource.c (tui_erase_source_content)
2428 (tui_show_source_content, tui_show_exec_info_content)
2429 (tui_erase_exec_info_content): Use refresh_window method.
2430 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2431 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2432 from tui_refresh_win.
2433 (tui_data_window::refresh_window): New method.
2434 (tui_win_info::refresh, tui_source_window_base::refresh)
2435 (tui_refresh_all): Use refresh_window method.
2436 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2437 method.
2438 * tui/tui-regs.c (tui_display_register): Call refresh_window
2439 method.
2440 * tui/tui-layout.c (show_source_disasm_command)
2441 (show_source_or_disasm_and_command): Call refresh_window method.
2442 * tui/tui-data.h (struct tui_gen_win_info)
2443 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2444 New method.
2445
cb2ce893
TT
24462019-06-25 Tom Tromey <tom@tromey.com>
2447
2448 * tui/tui.c (tui_rl_other_window, tui_enable)
2449 (tui_is_window_visible, tui_get_command_dimension): Update.
2450 * tui/tui-winsource.c (tui_update_source_window_as_is)
2451 (tui_clear_source_content, tui_erase_source_content)
2452 (tui_show_source_line, tui_source_window_base::refill)
2453 (tui_source_window_base::do_scroll_horizontal)
2454 (tui_source_window_base::set_is_exec_point_at)
2455 (tui_update_breakpoint_info, tui_set_exec_info_content)
2456 (tui_alloc_source_buffer, tui_line_is_displayed)
2457 (tui_addr_is_displayed): Update.
2458 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2459 (tui_check_and_display_highlight_if_needed)
2460 (tui_win_info::make_visible, tui_win_info::refresh)
2461 (tui_refresh_all): Update.
2462 * tui/tui-windata.c (tui_first_data_item_displayed)
2463 (tui_delete_data_content_windows, tui_erase_data_content)
2464 (tui_display_all_data, tui_data_window::refresh_all)
2465 (tui_check_data_values): Update.
2466 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2467 (tui_set_win_focus_to, tui_win_info::forward_scroll)
2468 (tui_win_info::backward_scroll, tui_refresh_all_win)
2469 (tui_resize_all, tui_set_focus, tui_all_windows_info)
2470 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2471 (tui_source_window_base::set_new_height)
2472 (tui_data_window::set_new_height)
2473 (make_invisible_and_set_new_height)
2474 (make_visible_with_new_height, new_height_ok)
2475 (parse_scrolling_args): Update.
2476 * tui/tui-stack.c (tui_show_frame_info): Update.
2477 * tui/tui-source.c (tui_set_source_content)
2478 (tui_set_source_content_nil, tui_source_is_displayed)
2479 (tui_source_window::do_scroll_vertical): Update.
2480 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2481 (tui_display_registers_from, tui_display_reg_element_at_line)
2482 (tui_check_register_values, tui_reg_command): Update.
2483 * tui/tui-layout.c (tui_default_win_height)
2484 (show_source_disasm_command, show_data, init_and_make_win)
2485 (show_source_or_disasm_and_command): Update.
2486 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2487 (tui_redisplay_readline, tui_mld_flush)
2488 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2489 (tui_getc): Update.
2490 * tui/tui-disasm.c (tui_set_disassem_content)
2491 (tui_disasm_window::do_scroll_vertical): Update.
2492 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2493 Now virtual.
2494 (struct tui_win_info): Derive from tui_gen_win_info.
2495 <~tui_win_info>: Mark as override.
2496 <generic>: Remove member.
2497 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2498 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2499 (~tui_data_window, ~tui_win_info)
2500 (tui_free_all_source_wins_content): Update.
2501 * tui/tui-command.c (tui_refresh_cmd_win): Update.
2502
ab313b35
TT
25032019-06-25 Tom Tromey <tom@tromey.com>
2504
2505 * tui/tui-layout.c (init_and_make_win): Use new.
2506 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2507 destructor, initializers.
2508 (tui_alloc_generic_win_info): Don't declare.
2509 * tui/tui-data.c (_locator): Add argument to constructor.
2510 (source_win, disasm_win): New globals.
2511 (exec_info): Remove.
2512 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2513 Update.
2514 (tui_alloc_generic_win_info): Remove.
2515 (init_content_element): Use new.
2516 (tui_win_info::tui_win_info): Update.
2517 (free_content_elements) <case DATA_WIN>: Use delete.
2518
dc2c33e4
TT
25192019-06-25 Tom Tromey <tom@tromey.com>
2520
2521 * tui/tui-wingeneral.c (tui_refresh_win): Update.
2522 * tui/tui-windata.c (tui_first_data_item_displayed)
2523 (tui_delete_data_content_windows): Update.
2524 * tui/tui-win.c (tui_data_window::set_new_height): Update.
2525 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2526 (tui_display_registers_from, tui_check_register_values): Update.
2527 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2528 pointer.
2529 * tui/tui-data.c (init_content_element): Update. Allocate the new
2530 window.
2531 (tui_free_data_content): Update.
2532 (free_content_elements) <case DATA_WIN>: Free the window.
2533
214a5cbe
TT
25342019-06-25 Tom Tromey <tom@tromey.com>
2535
2536 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2537 Update.
2538 * tui/tui-layout.c (make_command_window)
2539 (show_source_disasm_command, show_data, init_and_make_win)
2540 (show_source_or_disasm_and_command): Update.
2541 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2542 method.
2543 <can_highight, is_highlighted>: Now bool.
2544 (tui_set_win_highlight): Don't declare.
2545 * tui/tui-data.c (tui_set_win_highlight): Remove.
2546
8e2daf15
TT
25472019-06-25 Tom Tromey <tom@tromey.com>
2548
2549 * tui/tui-wingeneral.c (make_visible): Remove check of window
2550 type.
2551
8903bd8a
TT
25522019-06-25 Tom Tromey <tom@tromey.com>
2553
2554 * tui/tui-win.c (tui_win_info::max_height)
2555 (tui_cmd_window::max_height): New methods.
2556 (new_height_ok): Call max_height.
2557 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2558 <max_height>: New method.
2559
3f02ce1e
TT
25602019-06-25 Tom Tromey <tom@tromey.com>
2561
2562 * tui/tui-win.c (tui_source_window_base::set_new_height)
2563 (tui_data_window::set_new_height): New methods.
2564 (make_invisible_and_set_new_height): Call set_new_height method.
2565 * tui/tui-data.h (struct tui_win_info)
2566 (struct tui_source_window_base, struct tui_data_window)
2567 <set_new_height>: New method.
2568
1825f487
TT
25692019-06-25 Tom Tromey <tom@tromey.com>
2570
2571 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2572 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2573 tui_refresh_data_win.
2574 * tui/tui-win.c (tui_source_window_base::refresh_all): New
2575 method.
2576 (tui_refresh_all_win): Call the refresh_all method.
2577 (tui_set_focus): Likewise.
2578 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2579 (struct tui_source_window_base, struct tui_data_window) <refresh>:
2580 Likewise.
2581
ad54d15b
TT
25822019-06-25 Tom Tromey <tom@tromey.com>
2583
2584 * tui/tui-winsource.h (tui_refill_source_window)
2585 (tui_set_is_exec_point_at): Don't declare.
2586 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2587 (tui_source_window_base::refill): Rename from
2588 tui_refill_source_window.
2589 (tui_source_window_base::do_scroll_horizontal): Update.
2590 (tui_source_window_base::set_is_exec_point_at): Rename from
2591 tui_set_is_exec_point_at.
2592 (tui_update_all_breakpoint_info): Update.
2593 * tui/tui-stack.c (tui_show_frame_info): Update.
2594 * tui/tui-layout.c (show_data): Add cast.
2595 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2596 * tui/tui-data.h (struct tui_source_window_base) <refill,
2597 set_is_exec_point_at>: New methods.
2598 (tui_source_windows, tui_add_to_source_windows): Update types.
2599 (tui_add_to_source_windows): Remove redundant declaration.
2600 * tui/tui-data.c (source_windows): Store tui_source_window_base.
2601 (tui_source_windows): Change return type.
2602 (tui_clear_source_windows_detail): Update.
2603 (tui_add_to_source_windows): Change type of parameter.
2604 (tui_free_all_source_wins_content): Update.
2605
2042b506
TT
26062019-06-25 Tom Tromey <tom@tromey.com>
2607
2608 * tui/tui-wingeneral.c (tui_win_info::refresh)
2609 (tui_source_window_base::refresh): New methods.
2610 (tui_refresh_all): Call the refresh method.
2611 * tui/tui-data.h (struct tui_win_info)
2612 (struct tui_source_window_base) <refresh>: New method.
2613
56122977
TT
26142019-06-25 Tom Tromey <tom@tromey.com>
2615
2616 * tui/tui.h (tui_is_window_visible): Return bool.
2617 * tui/tui.c (tui_is_window_visible): Return bool.
2618 * tui/tui-wingeneral.c (tui_make_window, make_visible)
2619 (tui_make_visible, tui_make_invisible)
2620 (tui_win_info::make_visible)
2621 (tui_source_window_base::make_visible, make_all_visible)
2622 (tui_make_all_visible, tui_make_all_invisible): Update.
2623 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2624 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2625 bool.
2626 (struct tui_win_info, struct tui_source_window_base)
2627 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2628 * tui/tui-data.c (tui_init_generic_part): Update.
2629
cda37efb
TT
26302019-06-25 Tom Tromey <tom@tromey.com>
2631
2632 * tui/tui-wingeneral.c (tui_win_info::make_visible)
2633 (tui_source_window_base::make_visible): New methods.
2634 (make_all_visible): Make method call.
2635 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2636 (struct tui_source_window_base, struct tui_cmd_window): Override
2637 make_visible.
2638 (tui_win_is_source_type): Don't declare.
2639 * tui/tui-data.c (tui_win_is_source_type): Remove.
2640
6a0ee02c
TT
26412019-06-25 Tom Tromey <tom@tromey.com>
2642
2643 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2644 NULL check.
2645
63901aec
TT
26462019-06-25 Tom Tromey <tom@tromey.com>
2647
2648 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2649 Inline constructor. Add initializers for members.
2650 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2651 constructors; now inline in class.
2652
ceb13a13
TT
26532019-06-25 Tom Tromey <tom@tromey.com>
2654
2655 * tui/tui-regs.c (tui_show_registers): Update.
2656 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2657 bool.
2658 * tui/tui-data.c (tui_data_window::clear_detail)
2659 (tui_data_window): Update.
2660
238eb706
TT
26612019-06-25 Tom Tromey <tom@tromey.com>
2662
2663 * tui/tui-windata.c (tui_display_all_data)
2664 (tui_display_data_from_line, tui_display_data_from)
2665 (tui_check_data_values, tui_data_window::do_scroll_vertical):
2666 Update.
2667 * tui/tui-regs.c (tui_last_regs_line_no)
2668 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2669 (tui_show_registers, tui_show_register_group)
2670 (tui_display_registers_from, tui_display_reg_element_at_line)
2671 (tui_display_registers_from_line, tui_check_register_values)
2672 (tui_reg_next, tui_reg_prev): Update.
2673 * tui/tui-layout.c (tui_set_layout, show_data): Update.
2674 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
2675 tui_data_window.
2676 (struct tui_win_info) <detail>: Remove. Add new fields from
2677 tui_data_info.
2678 (TUI_DATA_WIN): Add cast.
2679 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2680 (~tui_data_window): Simplify.
2681
81491aa0
TT
26822019-06-25 Tom Tromey <tom@tromey.com>
2683
2684 * tui/tui-layout.c (show_source_disasm_command)
2685 (show_source_or_disasm_and_command): Update.
2686 * tui/tui-io.c (update_cmdwin_start_line)
2687 (tui_redisplay_readline): Update.
2688 * tui/tui-data.h (struct tui_command_info): Remove.
2689 (struct tui_win_info) <detail>: Remove command_info member.
2690 (struct tui_data_window) <start_line>: New member, from
2691 tui_command_info.
2692 (TUI_CMD_WIN): Add casts.
2693
e6e41501
TT
26942019-06-25 Tom Tromey <tom@tromey.com>
2695
2696 * tui/tui-winsource.c (tui_update_source_window)
2697 (tui_refill_source_window)
2698 (tui_source_window_base::do_scroll_horizontal)
2699 (tui_update_breakpoint_info, tui_set_exec_info_content)
2700 (tui_show_exec_info_content, tui_erase_exec_info_content)
2701 (tui_clear_exec_info_content): Update.
2702 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2703 Update.
2704 * tui/tui-win.c (make_invisible_and_set_new_height)
2705 (make_visible_with_new_height): Update.
2706 * tui/tui-source.c (tui_set_source_content)
2707 (tui_show_symtab_source): Update.
2708 * tui/tui-layout.c (extract_display_start_addr)
2709 (show_source_disasm_command, show_data)
2710 (make_source_or_disasm_window)
2711 (show_source_or_disasm_and_command): Update.
2712 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2713 (tui_disasm_window::do_scroll_vertical): Remove shadowing
2714 "gdbarch".
2715 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
2716 to tui_source_window_base.
2717 (struct tui_win_info) <detail>: Remove source_info member.
2718 (struct tui_source_window_base) <has_locator>: Inline.
2719 Move contents from tui_source_info; rename has_locator member to
2720 m_has_locator.
2721 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2722 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2723 header file.
2724 (tui_source_window_base::clear_detail, ~tui_source_window_base):
2725 Simplify.
2726 (tui_free_all_source_wins_content): Cast to
2727 tui_source_window_base.
2728
44f0e208
TT
27292019-06-25 Tom Tromey <tom@tromey.com>
2730
2731 * tui/tui-win.c (make_invisible_and_set_new_height)
2732 (make_visible_with_new_height): Call has_locator method.
2733 * tui/tui-layout.c (show_source_disasm_command, show_data)
2734 (show_source_or_disasm_and_command): Update for bool change.
2735 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2736 (tui_win_info) <has_locator>: New method.
2737 (struct tui_source_window_base) <has_locator>: New method.
2738 (tui_win_has_locator): Don't declare.
2739 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2740 from tui_win_has_locator.
2741 (tui_source_window_base): Use false, not FALSE.
2742
7778b912
TT
27432019-06-25 Tom Tromey <tom@tromey.com>
2744
2745 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2746 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2747 clear_detail method directly.
2748 (tui_clear_win_detail): Remove.
2749
f83d391c
TT
27502019-06-25 Tom Tromey <tom@tromey.com>
2751
2752 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2753 "this", not TUI_DISASM_WIN.
2754
13446e05
TT
27552019-06-25 Tom Tromey <tom@tromey.com>
2756
2757 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
2758 declare.
2759 * tui/tui-winsource.c
2760 (tui_source_window_base::do_scroll_horizontal): Rename from
2761 tui_horizontal_source_scroll.
2762 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2763 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2764 from tui_vertical_data_scroll.
2765 * tui/tui-win.h (tui_scroll): Don't declare.
2766 * tui/tui-win.c (tui_win_info::forward_scroll)
2767 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2768 (tui_win_info::right_scroll): Rename and update.
2769 (tui_scroll_forward_command, tui_scroll_backward_command)
2770 (tui_scroll_left_command, tui_scroll_right_command): Update.
2771 (tui_scroll): Remove.
2772 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2773 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2774 from tui_vertical_source_scroll.
2775 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2776 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2777 from tui_vertical_disassem_scroll.
2778 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2779 do_scroll_horizontal>: New methods.
2780 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2781 Likewise.
2782 (struct tui_source_window_base): Add do_scroll_horizontal.
2783 (struct tui_source_window, struct tui_disasm_window): Add
2784 do_scroll_vertical.
2785 (struct tui_data_window, struct tui_cmd_window): Add
2786 do_scroll_horizontal and do_scroll_vertical.
2787 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2788
5cf82909
TT
27892019-06-25 Tom Tromey <tom@tromey.com>
2790
2791 * tui/tui-data.h (struct tui_source_window_base): New struct.
2792 (struct tui_source_window): Derive from tui_source_window_base.
2793 (struct tui_disasm_window): New struct.
2794 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2795 from tui_source_window::clear_detail.
2796 (tui_source_window_base): Rename from tui_source_window.
2797 (~tui_source_window_base): Rename from ~tui_source_window.
2798 (tui_alloc_win_info): Create a tui_disasm_window.
2799
ee1d42d6
TT
28002019-06-25 Tom Tromey <tom@tromey.com>
2801
2802 * tui/tui-data.h (struct tui_source_window)
2803 (struct tui_data_window): Declare destructors.
2804 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2805 destructors.
2806 (tui_win_info): Simplify.
2807
b4eb2452
TT
28082019-06-25 Tom Tromey <tom@tromey.com>
2809
2810 * tui/tui-winsource.c (tui_display_main)
2811 (tui_update_source_windows_with_addr)
2812 (tui_update_all_breakpoint_info): Update.
2813 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2814 (new_height_ok, parse_scrolling_args): Update.
2815 * tui/tui-stack.c (tui_show_frame_info): Update.
2816 * tui/tui-data.h (struct tui_list): Remove.
2817 (tui_source_windows): Return a reference to a std::vector.
2818 * tui/tui-data.c (source_windows): Now a std::vector.
2819 (tui_source_windows): Change return type.
2820 (tui_clear_source_windows): Rewrite.
2821 (tui_clear_source_windows_detail, tui_add_to_source_windows)
2822 (tui_free_all_source_wins_content): Rewrite.
2823
8761a91b
TT
28242019-06-25 Tom Tromey <tom@tromey.com>
2825
2826 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2827 (struct tui_data_window, struct tui_cmd_window): Declare
2828 clear_detail method.
2829 * tui/tui-data.c (tui_source_window::clear_detail)
2830 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2831 methods.
2832 (tui_clear_win_detail): Simplify.
2833
0ed69eda
TT
28342019-06-25 Tom Tromey <tom@tromey.com>
2835
2836 * tui/tui-layout.c (make_source_window, make_disasm_window)
2837 (make_source_or_disasm_window): Remove win_info_ptr parameter.
2838 Return the new window.
2839 (show_source_disasm_command, show_data)
2840 (show_source_or_disasm_and_command): Update.
2841
82432e10
TT
28422019-06-25 Tom Tromey <tom@tromey.com>
2843
2844 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2845 parameter. Return the new window.
2846 (show_source_disasm_command): Update and remove NULL check.
2847 (show_source_or_disasm_and_command): Update.
2848
ec328aa5
TT
28492019-06-25 Tom Tromey <tom@tromey.com>
2850
2851 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2852
33b906ab
TT
28532019-06-25 Tom Tromey <tom@tromey.com>
2854
2855 * tui/tui-data.h (struct tui_win_info): Make constructor
2856 protected. Make destructor virtual. Add initializers.
2857 (tui_source_window, tui_data_window, tui_cmd_window): New
2858 classes.
2859 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
2860 constructor. Add "type" parameter.
2861 (tui_source_window, tui_data_window, tui_cmd_window): New
2862 constructors.
2863 (tui_alloc_win_info): Instantiate the appropriate subclass.
2864
e7e11af4
TT
28652019-06-25 Tom Tromey <tom@tromey.com>
2866
2867 * tui/tui-win.c (tui_resize_all): Use delete.
2868 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2869 destructor.
2870 (tui_free_window): Don't declare.
2871 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2872 Update.
2873
6792b55e
TT
28742019-06-25 Tom Tromey <tom@tromey.com>
2875
2876 * tui/tui-data.h (struct tui_win_info): Add constructor.
2877 * tui/tui-data.c (tui_alloc_win_info): Use new.
2878 (tui_free_window): Use delete.
2879
f95675e1
TT
28802019-06-22 Tom Tromey <tom@tromey.com>
2881
2882 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2883 declare.
2884 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2885
5bff081c
TT
28862019-06-22 Tom Tromey <tom@tromey.com>
2887
2888 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2889 declare.
2890 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2891
47e3f474
TV
28922019-06-22 Tom de Vries <tdevries@suse.de>
2893
2894 * dwarf2read.c (create_addrmap_from_aranges)
2895 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2896 instead of '%zu'.
2897
fd5866f6
SM
28982019-06-21 Simon Marchi <simon.marchi@efficios.com>
2899
2900 * dwarf2read.h (dwarf2_section_info_def): Remove.
2901 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2902 * dwarf2read.c (struct dwo_sections) <types>: Change type to
2903 std::vector<dwarf2_section_info>.
2904 (struct dwo_file) <~dwo_file>: Remove.
2905 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2906 types field.
2907 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2908 (dwarf2_read_debug_names): Likewise.
2909 (create_debug_types_hash_table): Change parameter type to
2910 array_view, adjust code accordingly.
2911 (dwarf2_locate_dwo_sections): Adjust to std::vector.
2912 (partial_die_info::fixup): Likewise.
2913 (determine_prefix): Likewise.
2914 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2915
fb1eb2f9
SM
29162019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2917
2918 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2919 gdb_bfd_ref_ptr.
2920 <~dwo_file>: Remove call to gdb_bfd_unref.
2921 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2922 gdb_bfd_ref_ptr::get.
2923
51ac9db5
SM
29242019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2925
2926 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2927 type to htab_up.
2928 * dwarf2read.c (struct dwo_file): Initialize fields.
2929 <~dwo_file>: New.
2930 (free_dwo_file): Remove, move content to ~dwo_file.
2931 (struct dwo_file_deleter): Remove.
2932 (dwo_file_up>: Remove custom deleter.
2933 (free_dwo_files): Remove.
2934 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2935 dwo_files.
2936 (process_skeletonless_type_units): Call unique_ptr::get.
2937 (allocate_dwo_file_hash_table): Add deleter to created hash
2938 table. Change return type to htab_up.
2939 (lookup_dwo_file_slot): Don't memset dwo_file, call
2940 unique_ptr::get.
2941 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2942 (create_dwo_unit_in_dwp_v2): Likewise.
2943 (open_and_init_dwo_file): Likewise.
2944 (free_dwo_file_from_slot): Remove.
2945
dc4ccb6f
SM
29462019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
2947
2948 * dwarf2read.h (struct dwarf2_section_info) <readin,
2949 is_virtual>: Change type to bool.
2950 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2951 true instead of 1.
2952
e6a1c5cb
TT
29532019-06-19 Tom Tromey <tom@tromey.com>
2954
2955 * tui/tui-data.h (tui_init_content_element): Don't declare.
2956
6f6ffbeb
TT
29572019-06-19 Tom Tromey <tom@tromey.com>
2958
2959 * tui/tui-data.h (tui_init_win_info): Don't declare.
2960
f23f598e
TV
29612019-06-19 Tom de Vries <tdevries@suse.de>
2962
2963 * dwarf2read.h (abstract_to_concrete): Change type to
2964 std::unordered_map<sect_offset, std::vector<sect_offset>,
2965 gdb::hash_enum<sect_offset>>.
2966
680e1bee
TT
29672019-06-19 Tom Tromey <tromey@adacore.com>
2968
2969 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2970 EVAL_AVOID_SIDE_EFFECTS specially.
2971
dcf37923
TT
29722019-06-19 Tom Tromey <tromey@adacore.com>
2973
2974 * source-cache.c (highlighter): New global.
2975 (source_cache::get_source_lines): Create a highlighter on demand.
2976
494986d5
AB
29772019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
2978
2979 * defs.h (deprecated_interactive_hook): Delete declaration.
2980 * interps.c (clear_interpreter_hooks): Remove use of
2981 deprecated_interactive_hook.
2982 * top.c (deprecated_interactive_hook): Delete definition.
2983 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2984
3360b6e7
TV
29852019-06-18 Tom de Vries <tdevries@suse.de>
2986
2987 PR gdb/24515
2988 * dwarf2read.h (abstract_to_concrete): Change type from
2989 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2990 std::unordered_map<sect_offset, std::vector<sect_offset>>.
2991 * dwarf2read.c (read_variable): Update.
2992 (dwarf2_fetch_die_loc_sect_off): Update.
2993
310b3441
TV
29942019-06-17 Tom de Vries <tdevries@suse.de>
2995
2996 PR gdb/24617
2997 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2998 accessing parent[parent_len - 1].
2999
ba9777be
PP
30002019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3001
3002 PR gdb/24364
3003 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3004 call dtrace_process_dof with NULL dof.
3005
2b9f6e89
TV
30062019-06-16 Tom de Vries <tdevries@suse.de>
3007
3008 PR gdb/24445
3009 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3010
431b3ead
TT
30112019-06-16 Tom Tromey <tom@tromey.com>
3012
3013 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3014 (make_all_visible): Use address of member.
3015
d04b44a1
TT
30162019-06-16 Tom Tromey <tom@tromey.com>
3017
3018 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3019 (tui_free_window, free_content, free_content_elements): Remove
3020 unnecessary cast.
3021 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3022 cast.
3023 * tui/tui-regs.c (tui_show_register_group)
3024 (tui_display_registers_from, tui_display_reg_element_at_line):
3025 Remove unnecessary cast.
3026
bf5142e7
AB
30272019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3028
3029 * linux-nat.c (normal_mask): Delete.
3030 (_initialize_linux_nat): Don't initialise normal_mask.
3031
c4973306
SM
30322019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3033
3034 PR gdb/24445
3035 * dwarf-index-write.h (write_psymtabs_to_index): Add
3036 dwz_basename parameter.
3037 * dwarf-index-write.c (write_gdbindex): Move file writing to
3038 write_gdbindex_1. Change return type void.
3039 (assert_file_size): Move up, remove filename parameter.
3040 (write_gdbindex_1): New function.
3041 (write_debug_names): Change return type to void, call
3042 assert_file_size.
3043 (struct index_wip_file): New struct.
3044 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3045 file logic to index_wip_file. Write index for dwz file if
3046 needed.
3047 (save_gdb_index_command): Pass basename of dwz file, if present.
3048 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3049 build-id of dwz file, if present.
3050 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3051 (dwarf2_get_dwz_file): Likewise.
3052 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3053 (dwarf2_get_dwz_file): Likewise.
3054
395f9c91
TT
30552019-06-16 Tom Tromey <tom@tromey.com>
3056
3057 * coffread.c (process_coff_symbol): Use xstrdup.
3058 * value.c (create_internalvar): Use xstrdup.
3059
cafb3438
TT
30602019-06-16 Tom Tromey <tom@tromey.com>
3061
3062 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3063 * breakpoint.c (stopin_command, stopat_command)
3064 (until_break_command, decode_location_default): Remove unnecessary
3065 cast.
3066 * utils.c (subset_compare): Remove unnecessary cast.
3067 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3068 cast.
3069 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3070 cast.
3071 * infcmd.c (path_command): Remove unnecessary cast.
3072 * coffread.c (decode_type): Remove unnecessary cast.
3073 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3074 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3075 * tui/tui-stack.c (tui_show_locator_content)
3076 (tui_show_frame_info): Remove unnecessary cast.
3077 * tui/tui-win.c (tui_scroll_forward_command)
3078 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3079 (parse_scrolling_args): Remove unnecessary cast.
3080 * tui/tui-data.c (init_win_info, tui_del_window)
3081 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3082 (free_content_elements): Remove unnecessary cast.
3083 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3084 unnecessary cast.
3085 * tui/tui-source.c (tui_set_source_content)
3086 (tui_vertical_source_scroll): Remove unnecessary cast.
3087 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3088 cast.
3089 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3090 * tui/tui-regs.c (tui_display_registers_from)
3091 (tui_display_register): Remove unnecessary cast.
3092 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3093 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3094 (make_visible): Remove unnecessary cast.
3095 * tui/tui-winsource.c (tui_erase_source_content)
3096 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3097 unnecessary cast.
3098 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3099 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3100 * stabsread.c (read_type, read_array_type, read_range_type):
3101 Remove unnecessary cast.
3102 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3103 (parse_symbol, parse_type, upgrade_type, parse_external)
3104 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3105 unnecessary cast.
3106 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3107
730ead81
TT
31082019-06-16 Tom Tromey <tom@tromey.com>
3109
3110 * tui/tui-data.c (tui_alloc_generic_win_info)
3111 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3112 checks.
3113
584a927c
AB
31142019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3115 Andrew Burgess <andrew.burgess@embecosm.com>
3116
3117 * f-typeprint.c (f_print_type): Don't return early for not
3118 associated or not allocated types.
3119 (f_type_print_varspec_suffix): Add print_rank parameter and print
3120 ranks of array types in case they dangling.
3121 (f_type_print_base): Add print_rank parameter.
3122
30056ea0
AB
31232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3124
3125 * NEWS: Mention new MI commands.
3126 * break-catch-throw.c (enum exception_event_kind): Move to
3127 breakpoint.h.
3128 (print_mention_exception_catchpoint): Output text as a single
3129 message.
3130 (catch_exception_command_1): Rename to...
3131 (catch_exception_event): ...this, make non-static, update header
3132 command, and change some parameter types.
3133 (catch_catch_command): Update for changes to
3134 catch_exception_command_1.
3135 (catch_throw_command): Likewise.
3136 (catch_rethrow_command): Likewise.
3137 * breakpoint.c (enum exception_event_kind): Delete.
3138 * breakpoint.h (enum exception_event_kind): Moved here from
3139 break-catch-throw.c.
3140 (catch_exception_event): Declare.
3141 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3142 (mi_cmd_catch_throw): New function.
3143 (mi_cmd_catch_rethrow): New function.
3144 (mi_cmd_catch_catch): New function.
3145 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3146 'catch-catch' entries.
3147 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3148 (mi_cmd_catch_rethrow): Declare.
3149 (mi_cmd_catch_catch): Declare.
3150
ec8e2b6d
AB
31512019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3152
3153 * annotate.c (annotate_source_line): Change return type to void,
3154 update implementation to match.
3155 * annotate.h (annotate_source_line): Change return type to void,
3156 update header comment.
3157 * stack.c (print_frame_info): Don't change what frame information
3158 is printed based on whether annotations are on or not.
3159
0d3abd8c
AB
31602019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3161
3162 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3163 (annotate_source): Make static.
3164 (annotate_source_line): Moved from source.c and renamed from
3165 identify_source_line. Update the return type.
3166 * annotate.h (annotate_source): Delete declaration.
3167 (annotate_source_line): Declaration moved from source.h, and
3168 renamed from identify_source_line. Return type updated.
3169 * source.c (identify_source_line): Moved to annotate.c and renamed
3170 to annotate_source_line.
3171 (info_line_command): Remove check of annotation_level.
3172 * source.h (identify_source_line): Move declaration to annotate.h
3173 and rename to annotate_source_line.
3174 * stack.c: Add 'annotate.h' include.
3175 (print_frame_info): Remove check of annotation_level before
3176 calling annotate_source_line.
3177
00df30ae
AB
31782019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3179
3180 * source-cache.c (source_cache::get_plain_source_lines): Use
3181 open_source_file_with_line_charpos instead of just
3182 open_source_file, remove call to find_source_lines.
3183 (source_cache::get_source_lines): Likewise.
3184 * source.c (find_source_lines): Make static.
3185 (get_filename_and_charpos): Renamed into...
3186 (open_source_file_with_line_charpos): ..this along with changes to
3187 return a scoped_fd, and some other minor clean ups.
3188 (identify_source_line): Use open_source_file_with_line_charpos.
3189 (search_command_helper): Use open_source_file_with_line_charpos
3190 instead of just open_source_file, remove call to
3191 find_source_lines.
3192 * source.h (open_source_file_with_line_charpos): Declare new
3193 function.
3194 (find_source_lines): Delete declaration.
3195
afda45a2
AB
31962019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3197
3198 * source.c (get_filename_and_charpos): Remove fullname
3199 parameter.
3200 (identify_source_line): Update call to get_filename_and_charpos.
3201
0735b091
TT
32022019-06-14 Tom Tromey <tromey@adacore.com>
3203
3204 PR gdb/24502:
3205 * ui-style.h (skip_ansi_escape): Update comment.
3206 * ui-file.h (class no_terminal_escape_file): New class.
3207 * ui-file.c (no_terminal_escape_file::write)
3208 (no_terminal_escape_file::puts): New methods.
3209 * cli/cli-logging.c (handle_redirections): Use
3210 no_terminal_escape_file.
3211
52ce35e2
TT
32122019-06-14 Tom Tromey <tromey@adacore.com>
3213
3214 * NEWS: Move convenience variable news above Python news.
3215
73cc7272
TT
32162019-06-14 Tom Tromey <tom@tromey.com>
3217
3218 * gnulib: Move directory to top-level.
3219 * configure.ac: Don't configure gnulib.
3220 * configure: Rebuild.
3221 * common/common-defs.h: Use new path to gnulib.
3222 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3223 (GNULIB_H): Remove.
3224 (INCGNU): Look in new gnulib location.
3225 (HFILES_NO_SRCDIR): Remove gnulib files.
3226 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3227 (generated_files): Remove GNULIB_H.
3228 ($(LIBGNU), all-lib): Remove targets.
3229 (distclean): Don't mention GNULIB_BUILDDIR.
3230 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3231
f5686554
TT
32322019-06-14 Tom Tromey <tromey@adacore.com>
3233
3234 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3235 Warn if symbol file does not provide any symbols.
3236
a0c1ffed
TT
32372019-06-14 Tom Tromey <tromey@adacore.com>
3238
3239 * source.c (find_and_open_source): Respect basenames_may_differ.
3240
7c39e397
AB
32412019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3242
3243 * annotate.c (annotate_breakpoints_invalid): Make use of
3244 scoped_restore_terminal_state.
3245 (annotate_frames_invalid): Likewise.
3246
f411722c
TT
32472019-06-14 Tom Tromey <tromey@adacore.com>
3248
3249 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3250 allow assignment to an internalvar.
3251
4268ec18
TT
32522019-06-14 Tom Tromey <tromey@adacore.com>
3253
3254 * ada-lex.l: Allow "_" in attribute names.
3255
abdb711e
TT
32562019-06-14 Tom Tromey <tromey@adacore.com>
3257
3258 PR gdb/24653:
3259 * regcache.c (registers_changed): Don't call alloca.
3260 * top.c (execute_command): Don't call alloca.
3261
4c048731
PA
32622019-06-13 Pedro Alves <palves@redhat.com>
3263
3264 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3265 'expression'. When parsing an expression, error out if there's
3266 junk after "unlimited".
3267 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3268 (do_set_command): Adjust calls to is_unlimited_literal.
3269
66eb1ed3
PA
32702019-06-13 Pedro Alves <palves@redhat.com>
3271
3272 * compile/compile.c (make_compile_options_def_group): Add braces
3273 around array_view initializer.
3274 * thread.c (make_thread_apply_all_options_def_group)
3275 (make_thread_apply_all_options_def_group): Likewise.
3276
3345721a
PA
32772019-06-13 Pedro Alves <palves@redhat.com>
3278
3279 * NEWS (New commands): Mention "maint test-options
3280 require-delimiter", "maint test-options unknown-is-error", "maint
3281 test-options unknown-is-operand" and "maint show
3282 test-options-completion-result".
3283 (New command options, command completion): New section.
3284 (Completion improvements): New section.
3285 Mention that you can abbreviate "unlimited".
3286
6206060d
PA
32872019-06-13 Pedro Alves <palves@redhat.com>
3288
3289 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3290 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3291 * unittests/cli-utils-selftests.c (test_parse_flags)
3292 (test_parse_flags_qcs): Delete.
3293 (test_cli_utils): Don't call deleted functions.
3294
6665660a
PA
32952019-06-13 Pedro Alves <palves@redhat.com>
3296
3297 * thread.c: Include "cli/cli-option.h".
3298 (tp_array_compar_ascending): Global.
3299 (tp_array_compar): Delete function.
3300 (tp_array_compar_ascending, tp_array_compar_descending): New
3301 functions.
3302 (ascending_option_def, qcs_flag_option_def)
3303 (thr_qcs_flags_option_defs)
3304 (make_thread_apply_all_options_def_group)
3305 (make_thread_apply_options_def_group): New.
3306 (thread_apply_all_command): Use gdb::option::process_options.
3307 (thread_apply_command_completer)
3308 (thread_apply_all_command_completer): New.
3309 (thread_apply_command): Use gdb::option::process_options.
3310 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3311 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3312 to generate help text of "thread apply". Adjust "taas"'s help.
3313 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3314 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3315
f7e13587
PA
33162019-06-13 Pedro Alves <palves@redhat.com>
3317
3318 * thread.c (thread_apply_command): Check for invalid TID with
3319 isdigit instead of !isalpha.
3320
5d707134
PA
33212019-06-13 Pedro Alves <palves@redhat.com>
3322
3323 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3324 (validate_flags_qcs): New.
3325 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3326 (validate_flags_qcs): Declare.
3327 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3328 (make_frame_apply_options_def_group): New.
3329 (frame_apply_command_count): Process options with
3330 gdb::option::process_options.
3331 (frame_apply_completer): New.
3332 (frame_apply_level_completer, frame_apply_all_completer)
3333 (frame_apply_completer): New.
3334 (_initialize_stack): Update help of "frame apply", "frame apply
3335 level", "frame apply all" and "faas" to mention supported options
3336 and install command completers.
3337 * stack.h (frame_apply_all_completer): Declare.
3338 * thread.c: Include "stack.h".
3339 (tfaas_command): Add "--".
3340 (_initialize_thread): Update help "tfaas" to mention supported
3341 options and install command completer.
3342
272d4594
PA
33432019-06-13 Pedro Alves <palves@redhat.com>
3344
3345 * completer.c (complete_nested_command_line): New.
3346 (gdb_completion_word_break_characters_throw): Add assertion.
3347 * completer.h (complete_nested_command_line): Declare.
3348
90a1ef87
PA
33492019-06-13 Pedro Alves <palves@redhat.com>
3350
3351 * stack.c (parse_backtrace_qualifiers): New.
3352 (backtrace_command): Use it.
3353 (backtrace_command_completer): Complete on qualifiers.
3354
d4c16835
PA
33552019-06-13 Pedro Alves <palves@redhat.com>
3356
3357 * frame.c: Include "cli/cli-option.h.
3358 (user_set_backtrace_options): New.
3359 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3360 Delete.
3361 (get_prev_frame): Adjust.
3362 (boolean_option_def, uinteger_option_def)
3363 (set_backtrace_option_defs): New.
3364 (_initialize_frame): Adjust and use
3365 gdb::option::add_setshow_cmds_for_options to install "set
3366 backtrace past-main" and "set backtrace past-entry".
3367 * frame.h: Include "cli/cli-option.h".
3368 (struct frame_print_options): Forward declare.
3369 (print_frame_arguments_all, print_frame_arguments_scalars)
3370 (print_frame_arguments_none): Declare.
3371 (print_entry_values): Delete declaration.
3372 (struct frame_print_options, user_frame_print_options): New.
3373 (struct set_backtrace_options): New.
3374 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3375 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3376 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3377 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3378 (list_args_or_locals): Add frame_print_options parameter.
3379 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3380 * python/py-framefilter.c (enumerate_args): Pass down
3381 USER_FRAME_PRINT_OPTIONS.
3382 * stack.c: Include "cli/cli-option.h".
3383 (print_frame_arguments_all, print_frame_arguments_scalars)
3384 (print_frame_arguments_none): Declare.
3385 (print_raw_frame_arguments, print_entry_values): Delete.
3386 (user_frame_print_options): New.
3387 (boolean_option_def, enum_option_def, frame_print_option_defs):
3388 New.
3389 (struct backtrace_cmd_options): New.
3390 (bt_flag_option_def): New.
3391 (backtrace_command_option_defs): New.
3392 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3393 (print_frame_arg, read_frame_arg, print_frame_args)
3394 (print_frame_info, print_frame): Add frame_print_options parameter
3395 and use it.
3396 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3397 (backtrace_command_1): Add frame_print_options and
3398 backtrace_cmd_options parameters and use them.
3399 (make_backtrace_options_def_group): New.
3400 (backtrace_command): Process command options with
3401 gdb::option::process_options.
3402 (backtrace_command_completer): New.
3403 (_initialize_stack): Extend "backtrace"'s help to mention
3404 supported options. Install completer for "backtrace".
3405 Install some settings commands with add_setshow_cmds_for_options.
3406
2daf894e
PA
34072019-06-13 Pedro Alves <palves@redhat.com>
3408
3409 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3410 and that "set/show print raw frame-arguments" are now deprecated.
3411
3412 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3413 command.
3414 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3415 * stack.c (_initialize_stack): Install "set/show print
3416 raw-frame-arguments", and deprecate "set/show print raw
3417 frame-arguments".
3418 * valprint.c (_initialize_valprint): Deprecate "set/show print
3419 raw".
3420
e6ed716c
PA
34212019-06-13 Pedro Alves <palves@redhat.com>
3422
3423 * compile/compile.c (struct compile_options): New.
3424 (compile_flag_option_def, compile_command_option_defs)
3425 (make_compile_options_def_group): New.
3426 (compile_file_command): Handle options with
3427 gdb::option::process_options.
3428 (compile_file_command_completer): New function.
3429 (compile_code_command): Handle options with
3430 gdb::option::process_options.
3431 (compile_code_command_completer): New function.
3432 (_initialize_compiler): Install completers for "compile code" and
3433 "compile file". Mention available options in "compile code" and
3434 "compile code"'s help.
3435 * completer.c (advance_to_completion_word): New, factored out from
3436 ...
3437 (advance_to_expression_complete_word_point): ... this.
3438 (advance_to_filename_complete_word_point): New.
3439 * completer.h (advance_to_filename_complete_word_point): New
3440 declaration.
3441
7d8062de
PA
34422019-06-13 Pedro Alves <palves@redhat.com>
3443
3444 * compile/compile.c: Include "cli/cli-option.h".
3445 (compile_print_value): Scope data pointer is now a
3446 value_print_options pointer; adjust.
3447 (compile_print_command): Process options. Scope data pointer is
3448 now a value_print_options pointer; adjust.
3449 (_initialize_compile): Update "compile print"'s help to include
3450 supported options. Install a completer for "compile print".
3451 * cp-valprint.c (show_vtblprint, show_objectprint)
3452 (show_static_field_print): Delete.
3453 (_initialize_cp_valprint): Don't install "set print
3454 static-members", "set print vtbl", "set print object" here.
3455 * printcmd.c: Include "cli/cli-option.h" and
3456 "common/gdb_optional.h".
3457 (print_command_parse_format): Rework to fill in a
3458 value_print_options instead of a format_data.
3459 (print_value): Change parameter type from format_data pointer to
3460 value_print_options reference. Adjust.
3461 (print_command_1): Process options. Adjust to pass down a
3462 value_print_options.
3463 (print_command_completer): New.
3464 (_initialize_printcmd): Install print_command_completer as
3465 handle_brkchars completer for the "print" command. Update
3466 "print"'s help to include supported options.
3467 * valprint.c: Include "cli/cli-option.h".
3468 (show_vtblprint, show_objectprint, show_static_field_print): Moved
3469 here from cp-valprint.c.
3470 (boolean_option_def, uinteger_option_def)
3471 (value_print_option_defs, make_value_print_options_def_group):
3472 New. Use gdb::option::add_setshow_cmds_for_options to install
3473 "set print elements", "set print null-stop", "set print repeats",
3474 "set print pretty", "set print union", "set print array", "set
3475 print address", "set print symbol", "set print array-indexes".
3476 * valprint.h: Include <string> and "cli/cli-option.h".
3477 (make_value_print_options_def_group): Declare.
3478 (print_value): Change parameter type from format_data pointer to
3479 value_print_options reference.
3480 (print_command_completer): Declare.
3481
9d0faba9
PA
34822019-06-13 Pedro Alves <palves@redhat.com>
3483
3484 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3485 (COMMON_SFILES): Add maint-test-settings.c.
3486 * cli/cli-decode.c (boolean_enums): New global, factored out from
3487 ...
3488 (add_setshow_boolean_cmd): ... here.
3489 * cli/cli-decode.h (boolean_enums): Declare.
3490 * cli/cli-option.c: New file.
3491 * cli/cli-option.h: New file.
3492 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3493 factored out from ...
3494 (parse_cli_boolean_value(const char *)): ... this.
3495 (is_unlimited_literal): Change parameter type to pointer to
3496 pointer. Adjust and advance ARG pointer.
3497 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3498 (parse_cli_var_enum): New, factored out from ...
3499 (do_set_command): ... this. Adjust.
3500 * cli/cli-setshow.h (parse_cli_boolean_value)
3501 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3502 (parse_cli_var_enum): Declare.
3503 * cli/cli-utils.c: Include "cli/cli-option.h".
3504 (get_ulongest): New.
3505 * cli/cli-utils.h (get_ulongest): Declare.
3506 (check_for_argument): New overloads.
3507 * maint-test-options.c: New file.
3508
2c722807
PA
35092019-06-13 Pedro Alves <palves@redhat.com>
3510
3511 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3512 parse a range if "-" is at the end of the string.
3513
dee7b4c8
PA
35142019-06-13 Pedro Alves <palves@redhat.com>
3515
3516 * cli/cli-setshow.c (parse_auto_binary_operation)
3517 (parse_cli_boolean_value): Don't allow "o".
3518
dca0f6c0
PA
35192019-06-13 Pedro Alves <palves@redhat.com>
3520
3521 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3522 * NEWS: Mention maint test-settings KIND.
3523 * maint-test-settings.c: New file.
3524
597bf39d
PA
35252019-06-13 Pedro Alves <palves@redhat.com>
3526
3527 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3528 completer.
3529 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3530 "set" completers.
3531
48c410fb
PA
35322019-06-13 Pedro Alves <palves@redhat.com>
3533
3534 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3535 after item.
3536
93bcb043
PA
35372019-06-13 Pedro Alves <palves@redhat.com>
3538
3539 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3540
cbba3ecd
PA
35412019-06-13 Pedro Alves <palves@redhat.com>
3542
3543 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3544 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3545 call.
3546 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3547 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3548 calls.
3549 (check_for_argument): Skip spaces after argument.
3550
b9a3f842
PA
35512019-06-13 Pedro Alves <palves@redhat.com>
3552
3553 * thread.c (thread_apply_command): Adjust TID parsing.
3554 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3555 detected before end of string.
3556 (tid_is_in_list): Error out if LIST is invalid.
3557
3844e605
PA
35582019-06-13 Pedro Alves <palves@redhat.com>
3559
3560 * completer.c (complete_line_internal_1): Rewind completion word
3561 point.
3562 (completion_tracker::advance_custom_word_point_by): Change
3563 parameter type to int.
3564 * completer.h (completion_tracker::advance_custom_word_point_by):
3565 Likewise.
3566
00b56dbe
PA
35672019-06-13 Pedro Alves <palves@redhat.com>
3568
3569 * completer.c (advance_to_completion_word): Handle delimiters.
3570
d106773e
PA
35712019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
3572
3573 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3574
08f10e02
TT
35752019-06-11 Tom Tromey <tom@tromey.com>
3576
3577 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3578 (xmalloc_failed): Move to alloc.c.
3579 * alloc.c: New file.
3580 * Makefile.in (COMMON_SFILES): Add alloc.c.
3581
1c7fe951
TT
35822019-06-11 Tom Tromey <tom@tromey.com>
3583
3584 * nat/linux-waitpid.c: Don't include server.h.
3585 (linux_debug): Remove.
3586 (my_waitpid): Update.
3587
89549d7f
TT
35882019-06-11 Tom Tromey <tromey@adacore.com>
3589
3590 * infcall.c (_initialize_infcall): Remove trailing newline from
3591 help.
3592 * user-regs.c (_initialize_user_regs): Remove trailing newline
3593 from help.
3594 * typeprint.c (_initialize_typeprint): Remove trailing newline
3595 from help.
3596 * reverse.c (_initialize_reverse): Remove trailing newlines from
3597 help.
3598 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3599 from help.
3600 * language.c (add_set_language_command): Remove trailing newline
3601 from help.
3602 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3603 help.
3604 * disasm.c (_initialize_disasm): Remove trailing newline from
3605 help.
3606 * top.c (init_main): Remove trailing newline from help.
3607 * interps.c (_initialize_interpreter): Remove trailing newline
3608 from help.
3609 * btrace.c (_initialize_btrace): Remove trailing newlines from
3610 help.
3611 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3612 from help.
3613 * python/python.c (_initialize_python): Remove trailing newline
3614 from help.
3615 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3616 help.
3617 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3618 from help. Reformat some text.
3619 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3620 from help.
3621 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3622 newline from help.
3623
86108c13
TT
36242019-06-11 Tom Tromey <tromey@adacore.com>
3625
3626 * darwin-nat.c (darwin_decode_exception_message)
3627 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3628
a7067863
AB
36292019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
3630
3631 * valops.c (value_slice): Check for not allocated or not
3632 associated values.
3633
9ab08412
TV
36342019-06-10 Tom de Vries <tdevries@suse.de>
3635
3636 PR gdb/24618
3637 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3638 sure an empty slot (defined by a 32-bit zero pair) is recognized as
3639 invalid.
3640
f19e22e9
TV
36412019-06-10 Tom de Vries <tdevries@suse.de>
3642
3643 PR gdb/24611
3644 * linespec.c (linespec_lexer_lex_string): Remove incorrect
3645 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
3646
e99f9db0
TV
36472019-06-10 Tom de Vries <tdevries@suse.de>
3648
3649 PR symtab/24545
3650 * symtab.c (struct demangled_name_entry): Add language field.
3651 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
3652 static minimal symbol". Set and use language field.
3653
9bf7038b
TT
36542019-06-10 Tom Tromey <tromey@adacore.com>
3655
3656 * ada-lang.c (_initialize_ada_language): Update help text.
3657
422186a9
TT
36582019-06-10 Tom Tromey <tromey@adacore.com>
3659
3660 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3661 with a newline.
3662 * guile/guile.c (handle_boot_error): Don't end warning with a
3663 newline.
3664 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3665 warning with a newline.
3666 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3667 newline.
3668 (s12z_frame_cache): Likewise.
3669 * dwarf-index-cache.c (index_cache::store): Don't end warning with
3670 a newline.
3671 * solib-svr4.c (disable_probes_interface): Don't end warning with
3672 a newline.
3673 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3674 newline.
3675 * python/python.c (do_finish_initialization): Don't end warning
3676 with a newline.
3677
25ce02ee
TT
36782019-06-10 Tom Tromey <tom@tromey.com>
3679
3680 * python/py-breakpoint.c (gdbpy_breakpoint_created)
3681 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3682 gdbpy_enter.
3683
caa429d8
TT
36842019-06-10 Tom Tromey <tromey@adacore.com>
3685
3686 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3687 data.
3688 (elf_new_init): Don't call stabsread_new_init.
3689 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3690 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
3691 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3692
81873cc8
TV
36932019-06-10 Tom de Vries <tdevries@suse.de>
3694
3695 PR symtab/16264
3696 PR symtab/24517
3697 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3698
4fa0265e
РИ
36992019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
3700
3701 * source.c (find_and_open_source): Also rewrite relative file
3702 names.
3703
1a3da2cd
AB
37042019-04-26 Amos Bird <amosbird@gmail.com>
3705
3706 * annotate.c (annotate_thread_exited): Add "thread-exited"
3707 annotation.
3708
3847a7bf
TT
37092019-06-06 Tom Tromey <tromey@adacore.com>
3710
3711 * maint.h (class scoped_command_stats): Use
3712 DISABLE_COPY_AND_ASSIGN.
3713 <print_time>: New method.
3714 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3715 print_time.
3716 (scoped_command_stats::print_time): New method.
3717
312617a3
AB
37182019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
3719
3720 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3721 instructions of lengths 6 or 8 bytes.
3722
b02f78f9
PA
37232019-06-04 Pedro Alves <palves@redhat.com>
3724
3725 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3726
3727 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3728 * breakpoint.c (condition_completer): Likewise.
3729 * cli/cli-dump.c (scan_expression): Likewise.
3730 * common/filestuff.c (mkdir_recursive): Likewise.
3731 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3732 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3733 (gdb_abspath): Likewise.
3734 * compile/compile-cplus-types.c
3735 (compile_cplus_instance::decl_name): Likewise.
3736 * completer.c (complete_explicit_location):
3737 (signal_completer, reg_or_group_completer_1): Likewise.
3738 * cp-support.c (cp_remove_params_if_any): Likewise.
3739 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3740 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3741 * infcmd.c (strip_bg_char): Likewise.
3742 * linespec.c (copy_token_string): Likewise.
3743 * mi/mi-main.c (output_cores): Likewise.
3744 * psymtab.c (psymtab_search_name):
3745 * symfile.c (test_set_ext_lang_command): Likewise.
3746 * target.c (target_fileio_read_stralloc): Likewise.
3747 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3748 * value.c (complete_internalvar): Likewise.
3749
e1f2e1a2
CB
37502019-06-04 Christian Biesinger <cbiesinger@google.com>
3751
3752 Add objfile property to gdb.Type.
d3238f7d
PA
3753 * NEWS: Mention Python API addition.
3754 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 3755
e664d728
PW
37562019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3757
3758 * NEWS: Mention the new set|show style [title|highlight].
3759 Mention changes to "show style", "help" and "apropos".
3760
66d8c862
PW
37612019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3762
3763 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3764 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
3765 instead of print_help_for_command.
3766 (print_doc_of_command): New function.
3767 (help_list): Add 'apropos -v word' suggestion.
3768 (print_help_for_command): Style the command name using title style.
3769 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3770 (_initialize_cli_cmds): Describe -v in apropos_command help.
3771
9303eb2f
PW
37722019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3773
3774 * cli/cli-style.h (cli_style_option): Add name in constructor,
3775 add m_name class member, add constructor with intensity,
3776 add name class function.
3777 (cli_style_option::add_setshow_commands): Remove name argument.
3778 (highlight_style, title_style): New styles.
3779 * cli/cli-style.c (do_show): New function that shows a style
3780 characteristic styling the style name with itself.
3781 (set_style_name): New function.
3782 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3783 Update all callers according to the changes in cli/cli-style.h.
3784 * utils.h (fputs_highlighted): New function.
3785 * utils.c (fputs_highlighted): Likewise.
3786
e2c52041
PW
37872019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3788
3789 * NEWS: Mention new pipe command and new convenience variables.
3790
947d3946
PW
37912019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3792
3793 * cli/cli-cmds.c (pipe_command): New function.
3794 (_initialize_cli_cmds): Call add_com for pipe_command.
3795 Define | as an alias for pipe.
3796 (exit_status_set_internal_vars): New function.
3797 (shell_escape): Call exit_status_set_internal_vars.
3798 cli/cli-decode.c (find_command_name_length): Recognize | as
3799 a single character command.
3800
b8fd0918
PW
38012019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3802
3803 * gdbcmd.h (execute_command_to_ui_file): New declaration.
3804 top.c (execute_command_to_ui_file): New function, mostly a copy
3805 of execute_command_to_string.
3806 (execute_command_to_string): Implement by calling
3807 execute_command_to_ui_file.
3808
68bb5386
PW
38092019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3810
3811 * top.h (saved_command_line): Remove declaration.
3812 * top.c (previous_saved_command_line, previous_repeat_arguments):
3813 New variables.
3814 (saved_command_line): Make static, define together with other
3815 'repeat variables'.
3816 (dont_repeat): Clear repeat_arguments.
3817 (repeat_previous, get_saved_command_line, save_command_line):
3818 New functions.
3819 (gdb_init): Initialize saved_command_line
3820 and previous_saved_command_line.
3821 * main.c (captured_main_1): Remove saved_command_line initialization.
3822 * event-top.c (handle_line_of_input): Update to use
3823 the new 'repeat' related functions instead of direct access to
3824 saved_command_line.
3825 * command.h (repeat_previous, get_saved_command_line,
3826 save_command_line): New declarations.
3827 (dont_repeat): Add comment.
3828
bfcdb852
TT
38292019-05-30 Tom Tromey <tromey@adacore.com>
3830
3831 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3832 Fix comment.
3833 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3834
0ef209f2
JV
38352019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
3836
3837 PR cli/24587
3838 * completer.c (complete): Initialize variable word.
3839
955b06fa
SDJ
38402019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
3841
3842 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3843 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3844 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3845 'body' is NULL to the outter 'if', protecting the '!is_define'
3846 situation as well.
3847
fa9c3fa0
TT
38482019-05-29 Tom Tromey <tromey@adacore.com>
3849
3850 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3851 (dwarf_unknown): New function.
3852 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3853 (dwarf_type_encoding_name): Use dwarf_unknown.
3854
4330d61d
TT
38552019-05-29 Tom Tromey <tromey@adacore.com>
3856
3857 PR c++/20020:
3858 * cp-valprint.c (cp_print_value_fields): Call
3859 cp_print_static_field inside "try".
3860
33a6bc35
TT
38612019-05-29 Tom Tromey <tromey@adacore.com>
3862
3863 * inflow.c (struct terminal_info): Add default operator=.
3864 * configure: Rebuild.
3865 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3866 -Wdeprecated-copy-dtor, -Wredundant-move.
3867
000439d5
TT
38682019-05-29 Tom Tromey <tromey@adacore.com>
3869
3870 * NEWS: Add entry.
3871 * infcmd.c (print_return_value_1): Handle finish_print
3872 option.
3873 (show_print_finish): New function.
3874 (_initialize_infcmd): Add "set/show print finish" commands.
3875 * valprint.c (user_print_options): Initialize new member.
3876 * valprint.h (struct value_print_options) <finish_print>: New
3877 member.
3878
c0e70c62
TT
38792019-05-28 Tom Tromey <tromey@adacore.com>
3880
3881 * ada-lang.c (ada_remove_Xbn_suffix)
3882 (find_old_style_renaming_symbol)
3883 (parse_old_style_renaming): Remove.
3884 (ada_find_renaming_symbol): Don't call
3885 find_old_style_renaming_symbol.
3886 (ada_is_renaming_symbol): Rename from
3887 ada_find_renaming_symbol. Remove "block" parameter. Return
3888 bool. Now static.
3889 (ada_read_var_value): Update and simplify.
3890 * ada-exp.y (write_var_or_type): Remove old code.
3891
766f8836
AH
38922019-05-28 Alan Hayward <alan.hayward@arm.com>
3893
3894 * event-top.c: Remove include comment.
3895 * inflow.c (class scoped_ignore_sigttou): Move from here...
3896 * inflow.h (class scoped_ignore_sigttou): ...to here.
3897 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3898 * top.c: Remove include comment.
3899
eb41253a
TT
39002019-05-27 Tom Tromey <tom@tromey.com>
3901
3902 * NEWS: Fix typo.
3903
4ca51187
TT
39042019-05-22 Tom Tromey <tromey@adacore.com>
3905
3906 * target.c (target_follow_exec): Constify parameter.
3907 * target-delegates.c: Rebuild.
3908 * remote.c (remote_target::follow_exec): Constify parameter.
3909 * infrun.c (follow_exec): Constify parameter.
3910 * target.h (struct target_ops) <follow_exec>: Constify parameter.
3911 (target_follow_exec): Likewise.
3912
8fca4da0
AH
39132019-05-22 Alan Hayward <alan.hayward@arm.com>
3914
3915 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3916 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3917
b7060614
AH
39182019-05-22 Alan Hayward <alan.hayward@arm.com>
3919
3920 * NEWS: Add debugredirect and testsuite sections.
3921
0a5954bd
SC
39222019-05-22 Simon Cook <simon.cook@embecosm.com>
3923
3924 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3925 target descriptions using exclusively floating point register name
3926 aliases.
3927
dc42e902
AB
39282019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
3929
3930 PR gdb/18644:
3931 * f-lang.c (build_fortran_types): Handle the case where
3932 gdbarch_floatformat_for_type returns a nullptr.
3933
fb7806c7
TV
39342019-05-21 Tom de Vries <tdevries@suse.de>
3935
3936 PR cli/24587
3937 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3938
34d11c68
AB
39392019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3940
3941 PR gdb/18644:
3942 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3943 16-byte floats.
3944 * i386-tdep.c (i386_floatformat_for_type): Use
3945 floatformats_ia64_quad for the 16-byte floating point component
3946 within a fortran 32-byte complex number.
3947
122cf0f2
AB
39482019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
3949
3950 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3951 delete default constructor.
3952 (find_partial_die): Update to return const struct.
3953 (partial_die_parent_scope): Move variable declaration into scope
3954 of its use and change its type to auto.
3955 (guess_partial_die_structure_name): Likewise.
3956 (partial_die_info::fixup): Likewise.
3957
33d0e35a
TT
39582019-05-17 Tom Tromey <tromey@adacore.com>
3959
3960 * source.c (find_and_open_source): Remove cast.
3961
a45575b0
TT
39622019-05-17 Tom Tromey <tromey@adacore.com>
3963
3964 * annotate.c (annotate_source): Make "filename" const.
3965 * annotate.h (annotate_source): Use const.
3966
81f47ac2
AH
39672019-05-17 Alan Hayward <alan.hayward@arm.com>
3968
3969 * disasm.c (set_disassembler_options): Send errors to stderr.
3970
ca1285d1
AH
39712019-05-17 Alan Hayward <alan.hayward@arm.com>
3972
3973 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3974 (cli_interp_base::set_logging): Check debug_redirect.
3975 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3976 * cli/cli-logging.c (debug_redirect): Add static variable.
3977 (pop_output_files): Add default param.
3978 (handle_redirections): Print debug setting.
3979 (show_logging_command): Likewise.
3980 (_initialize_cli_logging): Add debugredirect command.
3981 * interps.c (current_interp_set_logging): Add debug_redirect
3982 parameter.
3983 * interps.h (set_logging): Add debug_redirect parameter.
3984 (current_interp_set_logging): Likewise.
3985 * mi/mi-common.h: Likewise.
3986 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3987
39882019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
3989 Tom Tromey <tromey@adacore.com>
3990
3991 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3992 directly.
3993 * cli/cli-interp.h (make_logging_output): Remove declaration.
3994 * cli/cli-logging.c (make_logging_output): Remove function.
3995 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3996 directly.
3997 * ui-file.c (tee_file::tee_file): Remove bools.
3998 (tee_file::~tee_file): Remove deletes.
3999 * ui-file.h (tee_file): Remove bools.
4000
26648588
JV
40012019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4002
4003 * mi/mi-cmds.h (mi_cmd_complete): New function.
4004 * mi/mi-main.c (mi_cmd_complete): Likewise.
4005 * mi/mi-cmds.c: Define new MI command -complete.
4006 * NEWS: Mention new -complete command.
4007
6e035501
JV
40082019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4009
4010 * completer.h (complete): New function.
4011 * completer.c (complete): Likewise.
4012 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4013 function defined in completer.h.
4014
7d0e2ece
JV
40152019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4016
e79be6e5 4017 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 4018
fb816e8b
TV
40192019-05-17 Tom de Vries <tdevries@suse.de>
4020
4021 PR gdb/24094
4022 * dwarf2read.c (struct cu_partial_die_info): New struct.
4023 (find_partial_die): Return cu_partial_die_info.
4024 (partial_die_parent_scope, guess_partial_die_structure_name)
4025 (partial_die_info::fixup): Handle new return type of find_partial_die.
4026
677052f2
SDJ
40272019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4028
4029 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4030 "std::string", simplifying the algorithm.
4031
f3da9116
SDJ
40322019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4033
4034 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4035 (stap_static_probe_ops::get_probes): Likewise.
4036
f1bb75ab
SDJ
40372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4038
4039 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4040 '-')" and "else if".
4041 (stap_parse_single_operand): Join checks for
4042 "gdbarch_stap_parse_special_token_p" and
4043 "gdbarch_stap_parse_special_token" in the same "if" statement.
4044 Invert check when verifying for operation on register
4045 displacement.
4046
3ca58cde
SDJ
40472019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4048
4049 * stap-probe.c (stap_get_opcode): Update comment.
4050 (stap_get_expected_argument_type): Likewise.
4051 (handle_stap_probe): Likewise.
4052
af2d9bee
SDJ
40532019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4054
4055 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4056 return type to 'bool'. Adjust comment. Use 'bool' when
4057 appropriate.
4058 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4059 * stap-probe.c (stap_parse_argument_1): Likewise.
4060 (stap_is_operator): Likewise.
4061 (stap_is_generic_prefix): Likewise.
4062 (stap_is_register_prefix): Likewise.
4063 (stap_is_register_indirection_prefix): Likewise.
4064 (stap_is_integer_prefix): Likewise.
4065 (stap_generic_check_suffix): Likewise.
4066 (stap_check_integer_suffix): Likewise.
4067 (stap_check_register_suffix): Likewise.
4068 (stap_check_register_indirection_suffix): Likewise.
4069 (stap_parse_register_operand): Likewise.
4070 (stap_parse_single_operand): Likewise.
4071 (stap_parse_argument_1): Likewise.
4072 (stap_probe::get_argument_count): Likewise.
4073 (stap_is_operator): Likewise.
4074
61c9c421
TT
40752019-05-16 Tom Tromey <tromey@adacore.com>
4076
4077 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4078 keyword to foreach.
4079
9ddc1af1
SM
40802019-05-15 Simon Marchi <simon.marchi@efficios.com>
4081
4082 * linux-thread-db.c (try_thread_db_load_1): Change return type
4083 to bool.
4084 (try_thread_db_load): Likewise.
4085 (try_thread_db_load_from_pdir_1): Likewise.
4086 (try_thread_db_load_from_pdir): Likewise.
4087 (try_thread_db_load_from_sdir): Likewise.
4088 (try_thread_db_load_from_dir): Likewise.
4089 (thread_db_load_search): Likewise.
4090 (has_libpthread): Likewise.
4091 (thread_db_load): Likewise.
4092
7bede828
SDJ
40932019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4094
4095 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4096 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4097 NULL, and complain/return if that's the case.
4098
c5358db4
JD
40992019-05-15 John Darrington <john@darrington.wattle.id.au>
4100
4101 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4102 (advance, posn, abstract_read_memory): New functions.
4103 [struct mem_read_abstraction]: New struct.
4104 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4105
c408a94f
TT
41062019-05-14 Tom Tromey <tromey@adacore.com>
4107
4108 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4109 value is not lval_memory.
4110
e7bd7fba
TT
41112019-05-14 Tom Tromey <tromey@adacore.com>
4112
4113 * solib.c (info_sharedlibrary_command): Style the file name.
4114
a6d0f249
AH
41152019-05-14 Alan Hayward <alan.hayward@arm.com>
4116
4117 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4118 (aarch64_vnv_type): Likewise.
4119 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4120 * common/tdesc.c: Likewise.
4121 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4122 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4123 * features/aarch64-fpu.xml: Add ieee half view.
4124 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4125 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4126 * gdbtypes.h (struct builtin_type): Likewise.
4127 (struct objfile_type): Likewise.
4128
66b8bb74
SM
41292019-05-12 Paul Naert <paul.naert@polymtl.ca>
4130
4131 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4132 typo.
4133 * location.h (string_to_event_location): Likewise.
4134
21c219fd
JB
41352019-05-11 Joel Brobecker <brobecker@adacore.com>
4136
4137 GDB 8.3 released.
4138
13674803
SM
41392019-05-10 Simon Marchi <simon.marchi@efficios.com>
4140
4141 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4142 New variable declaration.
4143 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4144 New variable.
4145 (print_one_breakpoint): Use ui_out::test_flags and new global
4146 variable to compute use_fixed_output.
4147 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4148 Remove.
4149 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4150 (mi_multi_location_breakpoint_output_fixed): Remove.
4151 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4152 new variable.
4153 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4154 fix_multi_location_breakpoint_output flag if version >= 3.
4155 * ui-out.h (enum ui_out_flag)
4156 <fix_multi_location_breakpoint_output>: New enumerator.
4157
a9eac7f9
SM
41582019-05-10 Simon Marchi <simon.marchi@efficios.com>
4159
4160 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4161
71bed2db
TT
41622019-05-10 Tom Tromey <tromey@adacore.com>
4163
4164 * ada-lang.c (catch_ada_completer): New function.
4165 (_initialize_ada_language): Use it.
4166
24c54127
TT
41672019-05-10 Tom Tromey <tromey@adacore.com>
4168
4169 * thread.c (print_thread_info): Make "requested_threads" const.
4170 * gdbthread.h (print_thread_info): Make "requested_threads"
4171 const.
4172 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4173 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4174
7a102139
TT
41752019-05-08 Tom Tromey <tom@tromey.com>
4176
4177 * gdbtypes.c (objfile_type_data): Change type.
4178 (objfile_type, _initialize_gdbtypes): Update.
4179
924d79e2
TT
41802019-05-08 Tom Tromey <tom@tromey.com>
4181
4182 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4183 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4184 (_initialize_dwarf2_frame): Update.
4185
4c58e337
TT
41862019-05-08 Tom Tromey <tom@tromey.com>
4187
4188 * objc-lang.c (objc_objfile_data): Change type.
4189 (find_methods): Update.
4190 (_initialize_objc_lang): Remove.
4191
d772d2ab
TT
41922019-05-08 Tom Tromey <tom@tromey.com>
4193
4194 * stabsread.c (rs6000_builtin_type_data): Change type.
4195 (rs6000_builtin_type, _initialize_stabsread): Update.
4196
d11d83f4
TT
41972019-05-08 Tom Tromey <tom@tromey.com>
4198
4199 * mips-tdep.c (mips_pdr_data): Remove.
4200 (_initialize_mips_tdep): Update.
4201
9a73f0ad
TT
42022019-05-08 Tom Tromey <tom@tromey.com>
4203
4204 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4205 (hppa_init_objfile_priv_data, read_unwind_info)
4206 (find_unwind_entry, _initialize_hppa_tdep): Update.
4207
8127a2fa
TT
42082019-05-08 Tom Tromey <tom@tromey.com>
4209
4210 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4211 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4212 on obstack.
4213 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4214
91d3055d
TT
42152019-05-08 Tom Tromey <tom@tromey.com>
4216
4217 * mdebugread.c (basic_type_data): Change type.
4218 (basic_type, _initialize_mdebugread): Update.
4219
31930bd3
TT
42202019-05-08 Tom Tromey <tom@tromey.com>
4221
4222 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4223
bdb3ed9e
TT
42242019-05-08 Tom Tromey <tom@tromey.com>
4225
4226 * nto-tdep.c (nto_inferior_data_reg): Change type.
4227 (nto_inferior_data): Update.
4228 (nto_inferior_data_cleanup, nto_new_inferior_data)
4229 (_initialize_nto_tdep): Remove.
4230 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4231
f37b313d
TT
42322019-05-08 Tom Tromey <tom@tromey.com>
4233
4234 * ada-lang.c (struct ada_inferior_data): Add initializers.
4235 (ada_inferior_data): Change type.
4236 (ada_inferior_data_cleanup): Remove.
4237 (get_ada_inferior_data, ada_inferior_exit)
4238 (struct ada_pspace_data): Add initializers, destructor.
4239 (ada_pspace_data_handle): Change type.
4240 (get_ada_pspace_data): Update.
4241 (ada_pspace_data_cleanup): Remove.
4242
24699405
TT
42432019-05-08 Tom Tromey <tom@tromey.com>
4244
4245 * coffread.c (struct coff_symfile_info): Add initializers.
4246 (coff_objfile_data_key): Move lower. Change type.
4247 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4248 Update.
4249 (coff_free_info): Remove.
4250
d4e05d2f
TT
42512019-05-08 Tom Tromey <tom@tromey.com>
4252
4253 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4254 (fbsd_pspace_data_handle): Move lower. Change type.
4255 (get_fbsd_pspace_data): Update.
4256 (fbsd_pspace_data_cleanup): Remove.
4257 (_initialize_fbsd_tdep): Update.
4258
14ef6690
TT
42592019-05-08 Tom Tromey <tom@tromey.com>
4260
4261 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4262 (get_ada_tasks_pspace_data): Update.
4263 (ada_tasks_pspace_data_cleanup): Remove.
4264 (_initialize_tasks): Update.
4265 (ada_tasks_inferior_data_handle): Change type.
4266 (get_ada_tasks_inferior_data): Update.
4267 (ada_tasks_inferior_data_cleanup): Remove.
4268 (struct ada_tasks_pspace_data): Add initializers.
4269
814cf43a
TT
42702019-05-08 Tom Tromey <tom@tromey.com>
4271
4272 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4273 * symfile-debug.c (debug_sym_get_probes): Change type.
4274 * stap-probe.c (handle_stap_probe):
4275 (stap_static_probe_ops::get_probes): Change type.
4276 * probe.h (class static_probe_ops) <get_probes>: Change type.
4277 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4278 (parse_probes_in_pspace): Update.
4279 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4280 Update.
4281 (any_static_probe_ops::get_probes): Change type.
4282 * elfread.c (elfread_data): New typedef.
4283 (probe_key): Change type.
4284 (elf_get_probes): Likewise. Update.
4285 (probe_key_free): Remove.
4286 (_initialize_elfread): Update.
4287 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4288 Change type.
4289 (dtrace_process_dof_probe, dtrace_process_dof)
4290 (dtrace_static_probe_ops::get_probe): Change type.
4291
02dc647e
TT
42922019-05-08 Tom Tromey <tom@tromey.com>
4293
4294 * xcoffread.c (struct xcoff_symfile_info): Rename from
4295 coff_symfile_info. Add initializers.
4296 (xcoff_objfile_data_key): Move lower. Change type.
4297 (XCOFF_DATA): Rewrite.
4298 (xcoff_free_info): Remove.
4299 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4300 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4301 (xcoff_initial_scan): Update.
4302
09232438
TT
43032019-05-08 Tom Tromey <tom@tromey.com>
4304
4305 * solib-svr4.c (struct svr4_info): Add initializers and
4306 destructor.
4307 <probes_table>: Now an htab_up.
4308 (solib_svr4_pspace_data): Change type.
4309 (free_probes_table): Simplify.
4310 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4311 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4312 (probes_table_remove_objfile_probes, register_solib_event_probe)
4313 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4314 (_initialize_svr4_solib): Update.
4315
7b4a314f
TT
43162019-05-08 Tom Tromey <tom@tromey.com>
4317
4318 * remote.c (remote_pspace_data): Change type.
4319 (remote_pspace_data_cleanup): Remove.
4320 (get_remote_exec_file, set_pspace_remote_exec_file)
4321 (_initialize_remote): Update.
4322
51d3063a
TT
43232019-05-08 Tom Tromey <tom@tromey.com>
4324
4325 * breakpoint.c (breakpoint_objfile_key): Change type.
4326 (get_breakpoint_objfile_data): Update.
4327 (free_breakpoint_objfile_data): Remove.
4328 (_initialize_breakpoint): Update.
4329
89fb8848
TT
43302019-05-08 Tom Tromey <tom@tromey.com>
4331
4332 * linux-tdep.c (struct linux_info): Add initializers.
4333 (linux_inferior_data): Move. Change type.
4334 (invalidate_linux_cache_inf): Update.
4335 (linux_inferior_data_cleanup): Remove.
4336 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4337
e9b89e2d
TT
43382019-05-08 Tom Tromey <tom@tromey.com>
4339
4340 * auxv.c (auxv_inferior_data): Move. Change type.
4341 (auxv_inferior_data_cleanup): Remove.
4342 (invalidate_auxv_cache_inf): Rewrite.
4343 (get_auxv_inferior_data, _initialize_auxv): Update.
4344
8c42777c
TT
43452019-05-08 Tom Tromey <tom@tromey.com>
4346
4347 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4348 (symfile_debug_objfile_data_key): Change type.
4349 (symfile_debug_installed, debug_qf_has_symbols)
4350 (debug_qf_find_last_source_symtab)
4351 (debug_qf_forget_cached_source_info)
4352 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4353 (debug_qf_print_stats, debug_qf_dump)
4354 (debug_qf_expand_symtabs_for_function)
4355 (debug_qf_expand_all_symtabs)
4356 (debug_qf_expand_symtabs_with_fullname)
4357 (debug_qf_map_matching_symbols)
4358 (debug_qf_expand_symtabs_matching)
4359 (debug_qf_find_pc_sect_compunit_symtab)
4360 (debug_qf_map_symbol_filenames)
4361 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4362 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4363 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4364 (debug_sym_read_linetable, debug_sym_relocate): Update.
4365 (symfile_debug_free_objfile): Remove.
4366 (install_symfile_debug_logging, _initialize_symfile_debug):
4367 Update.
4368
5bfd760d
TT
43692019-05-08 Tom Tromey <tom@tromey.com>
4370
4371 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4372 allocate_on_obstack.
4373 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4374 (get_dwarf2_per_objfile): Update.
4375 (set_dwarf2_per_objfile): Remove.
4376 (dwarf2_has_info, dwarf2_get_section_info): Update.
4377 (dwarf2_free_objfile): Remove.
4378 (_initialize_dwarf2_read): Update.
4379
e85e19b4
TT
43802019-05-08 Tom Tromey <tom@tromey.com>
4381
4382 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4383 initializers.
4384 <unsupported_script_warning_printed,
4385 script_not_found_warning_printed>: Now bool.
4386 (auto_load_pspace_data): Change type.
4387 (~auto_load_pspace_info): Rename from
4388 auto_load_pspace_data_cleanup.
4389 (get_auto_load_pspace_data, init_loaded_scripts_info)
4390 (clear_section_scripts, maybe_print_unsupported_script_warning)
4391 (maybe_print_script_not_found_warning, _initialize_auto_load):
4392 Update.
4393
f6aa7436
TT
43942019-05-08 Tom Tromey <tom@tromey.com>
4395
4396 * objfiles.c (objfile_pspace_info): Add destructor and
4397 initializers.
4398 (objfiles_pspace_data): Change type.
4399 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4400 (get_objfile_pspace_data): Update.
4401 (objfiles_bfd_data): Change type.
4402 (get_objfile_bfd_data): Update.
4403 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4404
6ae614f6
TT
44052019-05-08 Tom Tromey <tom@tromey.com>
4406
4407 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4408 Change type.
4409 (get_catch_syscall_inferior_data): Update.
4410 (catch_syscall_inferior_data_cleanup): Remove.
4411 (_initialize_break_catch_syscall): Update.
4412
6509b8eb
TT
44132019-05-08 Tom Tromey <tom@tromey.com>
4414
4415 * inflow.c (struct terminal_info): Add destructor and
4416 initializers.
4417 (inflow_inferior_data): Change type.
4418 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4419 (get_inflow_inferior_data, inflow_inferior_exit)
4420 (swap_terminal_info, _initialize_inflow): Update.
4421
35632941
TT
44222019-05-08 Tom Tromey <tom@tromey.com>
4423
4424 * target-dcache.c (target_dcache_cleanup): Remove.
4425 (target_dcache_aspace_key): Change type.
4426 (target_dcache_init_p, target_dcache_invalidate)
4427 (target_dcache_get, target_dcache_get_or_init)
4428 (_initialize_target_dcache): Update.
4429 * dcache.h (struct dcache_deleter): New.
4430
3017b94d
TT
44312019-05-08 Tom Tromey <tom@tromey.com>
4432
4433 * symtab.c (struct symbol_cache): Add destructor and
4434 initializers.
4435 (symbol_cache_key): Move. Change type.
4436 (make_symbol_cache, free_symbol_cache): Remove.
4437 (get_symbol_cache): Update.
4438 (symbol_cache_cleanup): Remove.
4439 (ALL_PSPACES, symbol_cache_flush)
4440 (maintenance_print_symbol_cache)
4441 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4442 Update.
4443
a32ad8c5
TT
44442019-05-08 Tom Tromey <tom@tromey.com>
4445
4446 * symtab.c (struct main_info): Add destructor and initializers.
4447 (main_progspace_key): Move. Change type.
4448 (get_main_info): Update.
4449 (main_info_cleanup): Remove.
4450 (_initialize_symtab): Update.
4451
5f6e90a0
TT
44522019-05-08 Tom Tromey <tom@tromey.com>
4453
4454 * registry.h (DECLARE_REGISTRY): Define the _key class.
4455
1bd0c6e4
AB
44562019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
4457
4458 * NEWS: Merge two 'New commands' sections.
4459
2228ef77
XR
44602019-05-08 Joel Brobecker <brobecker@adacore.com>
4461
4462 * ada-valprint.c (ada_val_print_gnat_array): Remove language
4463 parameter and use Ada language definition instead.
4464 (ada_val_print_ptr): Remove unused language parameter.
4465 (ada_val_print_num): Remove language parameter and use Ada language
4466 definition instead.
4467 (ada_val_print_enum, ada_val_print_flt): Remove unused language
4468 parameter.
4469 (ada_val_print_struct_union, ada_val_print_ref): Remove language
4470 parameter and use Ada language definition instead.
4471 (ada_val_print_1): Update all ada_val_print_xxx calls.
4472 Remove language parameter.
4473 (ada_val_print): Update ada_val_print_1 call.
4474
60fcc1c3
TT
44752019-05-08 Tom Tromey <tromey@adacore.com>
4476
4477 * remote.c (remote_hw_watchpoint_limit)
4478 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4479 Now static.
4480
ed2b7c17
TT
44812019-05-08 Tom Tromey <tromey@adacore.com>
4482
4483 * maint.c (_initialize_maint_cmds): Move initialization code to
4484 remote.c.
4485 (watchdog, show_watchdog): Move to remote.c.
4486 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
4487 "watchdog" static.
4488 (_initialize_remote): Move initialization code from maint.c.
4489 * defs.h (watchdog): Don't declare.
4490
b0be6c91
TT
44912019-05-08 Tom Tromey <tromey@adacore.com>
4492
4493 * tui/tui-interp.c: Include main.h.
4494 * interps.c: Include main.h.
4495 * main.h (interpreter_p): Declare.
4496 * defs.h (interpreter_p): Don't declare.
4497
587ee17b
TT
44982019-05-08 Tom Tromey <tromey@adacore.com>
4499
4500 * dwarf2loc.c: Include dwarf2read.h.
4501 * defs.h (read_unsigned_leb128): Don't declare.
4502 * dwarf2read.h (read_unsigned_leb128): Declare.
4503
ca1df239
TT
45042019-05-08 Tom Tromey <tromey@adacore.com>
4505
4506 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4507 method.
4508
99f20f08
TT
45092019-05-08 Tom Tromey <tromey@adacore.com>
4510
4511 * utils.c (fputs_maybe_filtered): Reset style after paging, even
4512 when no wrap column is set.
4513
80e55b13
TT
45142019-05-08 Tom Tromey <tromey@adacore.com>
4515
4516 * c-lang.c (c_get_string): Handle non-C-style arrays.
4517
9d3421af
TT
45182019-05-08 Tom Tromey <tromey@adacore.com>
4519
4520 * typeprint.c (print_offset_data::update): Print the bit offset,
4521 not the number of bits remaining.
4522
844333e2
TT
45232019-05-08 Tom Tromey <tromey@adacore.com>
4524
4525 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4526 padding at end of comment.
4527
988915ee
TT
45282019-05-08 Tom Tromey <tromey@adacore.com>
4529
4530 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4531 Compare main types.
4532
26bfd823
TT
45332019-05-06 Tom Tromey <tom@tromey.com>
4534
4535 * common/scoped_mmap.c: Include common-defs.h.
4536 * common/scoped_mmap.h: Don't include config.h.
4537
89055eaa
TT
45382019-05-04 Tom Tromey <tom@tromey.com>
4539
4540 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4541 (struct aarch64_call_info): Add initializers.
4542 <si>: Now a std::vector.
4543 (pass_on_stack, aarch64_push_dummy_call): Update.
4544
5da01df5
TT
45452019-05-04 Simon Marchi <simon.marchi@efficios.com>
4546 Tom Tromey <tom@tromey.com>
4547
4548 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4549 (ppc_threads): Now a std::vector. Now static.
4550 (hwdebug_find_thread_points_by_tid)
4551 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4552 Update.
4553
fbdf05a1
TT
45542019-05-04 Tom Tromey <tom@tromey.com>
4555
4556 * arc-tdep.c (arc_tdesc_init): Return bool.
4557
06d16ec9
TT
45582019-05-04 Tom Tromey <tom@tromey.com>
4559
4560 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4561 Use gdb_assert_not_reached.
4562
9c056022
TT
45632019-05-04 Tom Tromey <tom@tromey.com>
4564
4565 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4566 "false".
4567
fa9c2a59
TT
45682019-05-04 Tom Tromey <tom@tromey.com>
4569
4570 * arc-tdep.c (arc_tdesc_init): Use bool.
4571
e2eb806a
TT
45722019-05-04 Tom Tromey <tom@tromey.com>
4573
4574 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4575
6fe87677
TT
45762019-05-04 Tom Tromey <tom@tromey.com>
4577
4578 * cli/cli-cmds.c (valid_command_p): Return bool.
4579
7f008c9e
TT
45802019-05-04 Tom Tromey <tom@tromey.com>
4581
4582 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4583 * command.h (valid_user_defined_cmd_name_p): Channge return type.
4584
b6484282
RT
45852019-05-04 Raul Tambre <raul@tambre.ee>
4586
4587 * python/lib/gdb/prompt.py (_ExtendedPrompt)
4588 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4589 operator for comparison.
4590
af97b416
TT
45912019-05-04 Tom Tromey <tom@tromey.com>
4592
4593 * psymtab.c (psymbol_name_matches, match_partial_symbol)
4594 (lookup_partial_symbol, print_partial_symbols)
4595 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4596 (psymbol_compare): Update.
4597 (add_psymbol_to_bcache): Clear the entire psymbol.
4598 (maintenance_check_psymtabs): Update.
4599 * psympriv.h (struct partial_symbol): Don't derive from
4600 general_symbol_info.
4601 <obj_section, unrelocated_address, address,
4602 set_unrelocated_address>: Update.
4603 <ginfo>: New member.
4604 * dwarf-index-write.c (write_psymbols, debug_names::insert)
4605 (debug_names::write_psymbols): Update.
4606
9d6d4be8
TV
46072019-05-04 Tom de Vries <tdevries@suse.de>
4608
4609 * contrib/cc-with-tweaks.sh: Support -n arg.
4610
66452beb
PW
46112019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4612
4613 * corelow.c (core_target::detach): Ensure frame cache and
4614 register caches are cleared.
4615 inferior.c (exit_inferior_1): Likewise.
4616
bde09ab7
TT
46172019-05-03 Sandra Loosemore <sandra@codesourcery.com>
4618 Tom Tromey <tom@tromey.com>
4619
4620 * dictionary.c (collate_pending_symbols_by_language): Remove
4621 "struct" from foreach.
4622 * symtab.c (lookup_global_symbol_from_objfile)
4623 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4624 foreach.
4625 * ser-tcp.c (net_open): Remove "struct" from foreach.
4626 * objfiles.c (objfile_relocate, objfile_rebase)
4627 (objfile_has_symbols): Remove "struct" from foreach.
4628 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4629 from foreach.
4630 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4631 foreach.
4632 * darwin-nat.c (thread_info_from_private_thread_info): Remove
4633 "struct" from foreach.
4634 * ada-lang.c (create_excep_cond_exprs)
4635 (ada_exception_catchpoint_cond_string): Remove "struct" from
4636 foreach.
4637
222a8d25
TT
46382019-05-03 Tom Tromey <tromey@adacore.com>
4639
4640 * ada-exp.y (convert_char_literal): Check suffix of each
4641 enumerator.
4642
fcd60b84
DP
46432019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
4644
4645 PR ada/21406:
4646 * ada-exp.y (yywrap): Don't define.
4647 * ada-lex.l (%option): Add noyywrap
4648 (yywrap): Remove.
4649
5f2459c2
EZ
46502019-05-03 Eli Zaretskii <eliz@gnu.org>
4651
353ea2d1
EZ
4652 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4653 _WIN32_WINNT to the XP level, unless already defined to a higher
4654 level.
4655
4656 * unittests/parse-connection-spec-selftests.c:
4657 * ser-tcp.c:
4658 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
4659 override.
4660
5f2459c2
EZ
4661 * symfile.c (find_separate_debug_file): Remove colon from the
4662 drive spec of DOS/Windows file names of the target, so that the
4663 file name produced from DEBUGDIR and the target's directory will
4664 be valid on DOS/Windows systems.
4665
80062eb9
AB
46662019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
4667
4668 * rust-lang.c (val_print_struct): Handle printing structures
4669 containing strings.
4670
b8c05e85
TT
46712019-05-02 Tom Tromey <tromey@adacore.com>
4672
4673 * valarith.c (_initialize_valarith): Remove.
4674
4504bbde
TT
46752019-05-01 Tom Tromey <tromey@adacore.com>
4676
4677 * ada-lang.c (ada_value_primitive_field): Treat more fields as
4678 bitfields.
4679
d48e62f4
TT
46802019-05-01 Tom Tromey <tromey@adacore.com>
4681
4682 * ada-lang.c (ada_value_assign): Correctly compute starting offset
4683 for big-endian copies.
4684
15f18d14
AT
46852019-04-30 Ali Tamur <tamur@google.com>
4686 * gdb/dwarf2read.c (read_3_bytes): New declaration.
4687 (read_attribute_value): Added DW_FORM_strx1-4 cases.
4688 (read_3_bytes): New function.
4689
ab4ee614
JB
46902019-04-30 Joel Brobecker <brobecker@adacore.com>
4691
4692 * windows-nat.c (main_thread_id): Delete.
4693 (handle_output_debug_string): Replace main_thread_id by
4694 current_event.dwThreadId.
4695 (fake_create_process): Likewise.
4696 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4697 Do not set main_thread_id.
4698 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4699 current_event.dwThreadId.
4700 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4701
8ed5b76e
JB
47022019-04-30 Joel Brobecker <brobecker@adacore.com>
4703
4704 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4705 Use current_event.dwThreadId instead of main_thread_id.
4706
2ff0a947
TT
47072019-04-30 Tom Tromey <tromey@adacore.com>
4708
4709 * ada-lang.c (ada_lookup_simple_minsyms): New function.
4710 (create_excep_cond_exprs): Iterate over program spaces.
4711 (ada_exception_catchpoint_cond_string): Examine all minimal
4712 symbols for exception types.
4713
a776957c
TT
47142019-04-30 Tom Tromey <tromey@adacore.com>
4715
4716 PR c++/24470:
4717 * dwarf2read.c (process_structure_scope): Handle case where type
4718 has template parameters but no symbol was created.
4719
bc68014d
AB
47202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4721 Chris January <chris.january@arm.com>
4722
4723 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4724 qualifier.
4725 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4726
f1fdc960
AB
47272019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4728
4729 * f-typeprint.c (f_print_type): Update rules for printing
4730 whitespace.
4731 (f_type_print_varspec_suffix): Likewise.
4732
bf7a4de1
AB
47332019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4734 Chris January <chris.january@arm.com>
4735
4736 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4737 function arguments.
4738
bbe75b9d
AB
47392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4740
4741 * f-lang.c (build_fortran_types): Change name of void type to
4742 lower case.
4743 * f-typeprint.c (f_type_print_base): Print the name of the void
4744 type, rather than a fixed string.
4745 * f-valprint.c (f_decorations): Use lower case void string.
4746
1db455a7
AB
47472019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4748 Chris January <chris.january@arm.com>
4749
4750 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4751 types for Fortran.
4752
b6d03bb2
AB
47532019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4754 Chris January <chris.january@arm.com>
4755 David Lecomber <david.lecomber@arm.com>
4756
4757 * f-exp.y (BINOP_INTRINSIC): New token.
4758 (exp): New parser rule handling BINOP_INTRINSIC.
4759 (f77_keywords): Add new builtin procedures.
4760 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4761 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4762 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4763 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4764 (print_unop_subexp_f): New function.
4765 (print_binop_subexp_f): New function.
4766 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4767 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4768 (dump_subexp_body_f): Likewise.
4769 (operator_check_f): Likewise.
4770 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4771 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4772
83228e93
AB
47732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4774
4775 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4776 UNOP_KIND.
4777 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4778 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4779 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4780 (operator_length_f): New fuction.
4781 (print_subexp_f): New function.
4782 (op_name_f): New function.
4783 (dump_subexp_body_f): New function.
4784 (operator_check_f): New function.
4785 (exp_descriptor_f): Replace standard expression handling functions
4786 with new functions.
4787 * gdb/fortran-operator.def: New file.
4788 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4789 * gdb/std-operator.def: Remove UNOP_KIND.
4790
6fdcd7cc
AB
47912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
4792
4793 * std-operator.def: Remove unbalanced, stray double quote
4794 character.
4795
2e62ab40
AB
47962019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4797 Chris January <chris.january@arm.com>
4798 Daniel Everett <daniel.everett@arm.com>
4799 Nick Forrington <nick.forrington@arm.com>
4800 Richard Bunt <richard.bunt@arm.com>
4801
4802 * cp-valprint.c (cp_print_value_fields): Allow an additional level
4803 of depth when printing anonymous structs or unions.
4804 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4805 Don't print either the top-level value, or the children if the
4806 max-depth is exceeded.
4807 (ppscm_print_children): When printing the key of a map, allow one
4808 extra level of depth.
4809 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4810 print either the top-level value, or the children if the max-depth
4811 is exceeded.
4812 (print_children): When printing the key of a map, allow one extra
4813 level of depth.
4814 * python/py-value.c (valpy_format_string): Add max_depth keyword.
4815 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4816 (user_print_options): Initialise max_depth field.
4817 (val_print_scalar_or_string_type_p): New function.
4818 (val_print): Check to see if the max depth has been reached.
4819 (val_print_check_max_depth): Define new function.
4820 (show_print_max_depth): New function.
4821 (_initialize_valprint): Add 'print max-depth' option.
4822 * valprint.h (struct value_print_options) <max_depth>: New field.
4823 (val_print_check_max_depth): Declare new function.
4824 * NEWS: Document new feature.
4825
4be290b2
AB
48262019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4827
4828 * ada-lang.c (ada_language_defn): Initialise new field.
4829 * c-lang.c (c_is_string_type_p): New function.
4830 (c_language_defn): Initialise new field.
4831 (cplus_language_defn): Initialise new field.
4832 (asm_language_defn): Initialise new field.
4833 (minimal_language_defn): Initialise new field.
4834 * c-lang.h (c_is_string_type_p): Declare new function.
4835 * d-lang.c (d_language_defn): Initialise new field.
4836 * f-lang.c (f_is_string_type_p): New function.
4837 (f_language_defn): Initialise new field.
4838 * go-lang.c (go_is_string_type_p): New function.
4839 (go_language_defn): Initialise new field.
4840 * language.c (default_is_string_type_p): New function.
4841 (unknown_language_defn): Initialise new field.
4842 (auto_language_defn): Initialise new field.
4843 * language.h (struct language_defn) <la_is_string_type_p>: New
4844 member variable.
4845 (default_is_string_type_p): Declare new function.
4846 * m2-lang.c (m2_language_defn): Initialise new field.
4847 * objc-lang.c (objc_language_defn): Initialise new field.
4848 * opencl-lang.c (opencl_language_defn): Initialise new field.
4849 * p-lang.c (pascal_is_string_type_p): New function.
4850 (pascal_language_defn): Initialise new field.
4851 * rust-lang.c (rust_is_string_type_p): New function.
4852 (rust_language_defn): Initialise new field.
4853
721b08c6
AB
48542019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4855
4856 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4857 New field.
4858 * ada-lang.c (ada_language_defn): Initialise new field.
4859 * c-lang.c (c_language_defn): Likewise.
4860 (cplus_language_defn): Likewise.
4861 (asm_language_defn): Likewise.
4862 (minimal_language_defn): Likewise.
4863 * d-lang.c (d_language_defn): Likewise.
4864 * f-lang.c (f_language_defn): Likewise.
4865 * go-lang.c (go_language_defn): Likewise.
4866 * language.c (unknown_language_defn): Likewise.
4867 (auto_language_defn): Likewise.
4868 * m2-lang.c (m2_language_defn): Likewise.
4869 * objc-lang.c (objc_language_defn): Likewise.
4870 * opencl-lang.c (opencl_language_defn): Likewise.
4871 * p-lang.c (pascal_language_defn): Likewise.
4872 * rust-lang.c (rust_language_defn): Likewise.
4873
fc913e53
AB
48742019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
4875
4876 * ada-lang.c (ada_is_character_type): Change return type to bool.
4877 (ada_is_string_type): Likewise.
4878 * ada-lang.h (ada_is_character_type): Update declaration
4879 (ada_is_string_type): Likewise.
4880
fa731fa0
PW
48812019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4882
4883 Support style in 'frame|thread apply'
4884
4885 * gdbcmd.h (execute_command_to_string): New term_out parameter.
4886 * record.c (record_start, record_stop): Update callers of
4887 execute_command_to_string with false.
4888 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4889 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4890 methods.
4891 (class string_file): New constructor with term_out parameter.
4892 Override methods term_out and can_emit_style_escape. New member
4893 term_out.
4894 (class stdio_file): Override can_emit_style_escape.
4895 (class tee_file): Override term_out and can_emit_style_escape.
4896 * utils.h (can_emit_style_escape): Remove.
4897 * utils.c (can_emit_style_escape): Likewise.
4898 Update all callers of can_emit_style_escape (SOMESTREAM) to
4899 SOMESTREAM->can_emit_style_escape.
4900 * source-cache.c (source_cache::get_source_lines): Likewise.
4901 * stack.c (frame_apply_command_count): Call execute_command_to_string
4902 passing the term_out characteristic of the current gdb_stdout.
4903 * thread.c (thr_try_catch_cmd): Likewise.
4904 * top.c (execute_command_to_string): pass term_out parameter
4905 to construct the string_file for the command output.
4906 * ui-file.c (term_cli_styling): New function (most code moved
4907 from utils.c can_emit_style_escape).
4908 (string_file::string_file, string_file::can_emit_style_escape,
4909 stdio_file::can_emit_style_escape, tee_file::term_out,
4910 tee_file::can_emit_style_escape): New functions.
4911
136afab8
PW
49122019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4913
4914 * NEWS: Mention the new set|show may-call-functions.
4915 * infcall.c (may_call_functions_p): New variable.
4916 (show_may_call_functions_p): New function.
4917 (call_function_by_hand_dummy): Throws an error if not
4918 may-call-functions.
4919 (_initialize_infcall): Call add_setshow_boolean_cmd for
4920 may-call-functions.
4921
725cbb63
KS
49222019-04-25 Keith Seitz <keiths@redhat.com>
4923
4924 PR c++/24367
4925 * cp-support.c (inspect_type): Don't attempt substitutions
4926 of symbol with the same name.
4927
3d1cbb78
TT
49282019-04-25 Tom Tromey <tromey@adacore.com>
4929
4930 PR gdb/24475:
4931 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4932 static.
4933
94aeb44b
TT
49342019-04-25 Tom Tromey <tromey@adacore.com>
4935
4936 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4937 rvalue reference.
4938 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4939 (gdb_xml_parser::parse): Use std::move.
4940 * python/python-internal.h (gdbpy_convert_exception): Take a const
4941 reference.
4942 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4943 std::move.
4944 * python/py-utils.c (gdbpy_convert_exception): Take a const
4945 reference.
4946 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4947 Use std::move.
4948 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4949 Use std::move.
4950 * mi/mi-main.c (mi_print_exception): Take a const reference.
4951 * main.c (handle_command_errors): Take a const reference.
4952 * linespec.c (parse_linespec): Use std::move.
4953 * infcall.c (run_inferior_call): Use std::move.
4954 (call_function_by_hand_dummy): Use std::move.
4955 * exec.c (try_open_exec_file): Use std::move.
4956 * exceptions.h (exception_print, exception_fprintf)
4957 (exception_print_same): Update.
4958 * exceptions.c (print_exception, exception_print)
4959 (exception_fprintf, exception_print_same): Change parameters to
4960 const reference.
4961 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4962 * common/new-op.c: Use std::move.
4963 * common/common-exceptions.h (struct gdb_exception): Add move
4964 constructor.
4965 (struct gdb_exception_error, struct gdb_exception_quit, struct
4966 gdb_quit_bad_alloc): Change constructor to move constructor.
4967 (throw_exception): Change parameter to rvalue reference.
4968 * common/common-exceptions.c (throw_exception): Take rvalue
4969 reference.
4970 * cli/cli-interp.c (safe_execute_command): Use std::move.
4971 * breakpoint.c (insert_bp_location, location_to_sals): Use
4972 std::move.
4973
680d7fd5
TT
49742019-04-25 Tom Tromey <tromey@adacore.com>
4975
4976 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4977 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4978 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4979 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4980 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4981 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4982 guile/scm-value.c: Use unpack.
4983 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4984 gdbscm_gdb_exception.
4985 (gdbscm_throw_gdb_exception): Likewise.
4986 (struct gdbscm_gdb_exception): New.
4987 (unpack): New function.
4988 (gdbscm_wrap): Use unpack.
4989
c6fdd8b2
TT
49902019-04-25 Tom Tromey <tromey@adacore.com>
4991
4992 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4993 (gdb_rl_callback_handler): Use std::move.
4994 * common/common-exceptions.h (struct gdb_exception): Add move
4995 assignment operator.
4996 (throw_exception_sjlj): Change "exception" to const reference.
4997 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4998 (throw_exception_sjlj): Change "exception" to const reference.
4999
cc06b668
TT
50002019-04-25 Tom Tromey <tromey@adacore.com>
5001
5002 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5003 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5004 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5005 Update.
5006 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5007 Update.
5008 * mi/mi-interp.c (mi_interp::exec): Update.
5009 * linespec.c (parse_linespec): Update.
5010 * infcall.c (run_inferior_call): Update.
5011 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5012 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5013 (gdbscm_lookup_global_symbol): Update.
5014 * guile/scm-param.c (gdbscm_parameter_value): Update.
5015 * guile/scm-frame.c (gdbscm_frame_read_register)
5016 (gdbscm_frame_read_var): Update.
5017 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5018 * exec.c (try_open_exec_file): Update.
5019 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5020 (gdb_rl_callback_handler): Update.
5021 * common/common-exceptions.h (exception_none): Don't declare.
5022 * common/common-exceptions.c (exception_none): Don't define.
5023 (struct catcher) <exception>: Update.
5024 * cli/cli-interp.c (safe_execute_command): Update.
5025 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5026
cf532bd1
AT
50272019-04-25 Ali Tamur <tamur@google.com>
5028
5029 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5030 (read_attribute_value): Likewise.
5031 (dwarf2_read_addr_index): Update comment.
5032 (read_str_index): Add DW_FORM_strx.
5033 (dwarf2_string_attr): Likewise.
5034 (dwarf2_const_value_attr): Likewise.
5035 (dump_die_shallow): Likewise.
5036 (dwarf2_fetch_constant_bytes): Likewise.
5037 (skip_form_bytes): Likewise.
5038 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5039
82433e3e
SDJ
50402019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5041
5042 PR corefiles/11608
5043 PR corefiles/18187
5044 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5045 OFFSET. Verify if current mapping contains an ELF header.
5046 (linux_find_memory_regions_full): Adjust call to
5047 dump_mapping_p.
5048
723adb65
SL
50492019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5050 Kang Li <kanglictf@gmail.com>
5051
5052 PR gdb/21600
5053
5054 * dwarf2-frame.c (read_initial_length): Be consistent about using
5055 unsigned representation of length.
5056 (decode_frame_entry_1): Likewise. Check for wraparound of
5057 end pointer as well as buffer overflow.
5058
596179f7
SDJ
50592019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5060
5061 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5062 "vq".
5063
a59240a4
TT
50642019-04-24 Tom Tromey <tromey@adacore.com>
5065
5066 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5067
f872fdbb
AB
50682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5069
5070 * s12z-tdep.c (s12z_unwind_pc): Delete.
5071 (s12z_unwind_sp): Delete.
5072 (s12z_gdbarch_init): Don't register deleted functions with
5073 gdbarch.
5074
b614e6f3
AB
50752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5076
5077 * rl78-tdep.c (rl78_unwind_sp): Delete.
5078 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5079
14faed38
AB
50802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5081
5082 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5083 (xstormy16_unwind_pc): Delete.
5084 (xstormy16_dummy_id): Delete.
5085 (xstormy16_gdbarch_init): Don't register deleted functions with
5086 gdbarch.
5087
541aad8a
AB
50882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5089
5090 * vax-tdep.c (vax_unwind_pc): Delete.
5091 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5092
29222070
AB
50932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5094
5095 * v850-tdep.c (v850_unwind_sp): Delete.
5096 (v850_unwind_pc): Delete.
5097 (v850_dummy_id): Delete.
5098 (v850_gdbarch_init): Don't register deleted functions with
5099 gdbarch.
5100
0f534d76
AB
51012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5102
5103 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5104 (tilegx_unwind_pc): Delete.
5105 (tilegx_unwind_dummy_id): Delete.
5106 (tilegx_gdbarch_init): Don't register deleted functions with
5107 gdbarch.
5108
1ba7b7f9
AB
51092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5110
5111 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5112 (tic6x_dummy_id): Delete.
5113 (tic6x_gdbarch_init): Don't register deleted functions with
5114 gdbarch.
5115
d31f262c
AB
51162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5117
5118 * sparc-tdep.c (sparc_unwind_pc): Delete.
5119 (sparc32_gdbarch_init): Don't register deleted function with
5120 gdbarch.
5121
6d14d64d
AB
51222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5123
5124 * sh-tdep.c (sh_unwind_sp): Delete.
5125 (sh_unwind_pc): Delete.
5126 (sh_dummy_id): Delete.
5127 (sh_gdbarch_init): Don't register deleted functions with
5128 gdbarch.
5129
a40dde9d
AB
51302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5131
5132 * score-tdep.c (score_unwind_sp): Delete.
5133 (score_unwind_pc): Delete.
5134 (score_dummy_id): Delete.
5135 (score_gdbarch_init): Don't register deleted functions with
5136 gdbarch.
5137
47c47d69
AB
51382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5139
5140 * rx-tdep.c (rx_unwind_pc): Delete.
5141 (rx_unwind_sp): Delete.
5142 (rx_dummy_id): Delete.
5143 (rx_gdbarch_init): Don't register deleted functions with
5144 gdbarch. Update comment.
5145
833a4480
AB
51462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5147
5148 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5149 (rs6000_dummy_id): Delete.
5150 (rs6000_gdbarch_init): Don't register deleted functions with
5151 gdbarch.
5152
3f2cef49
AB
51532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5154
5155 * or1k-tdep.c (or1k_dummy_id): Delete.
5156 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5157
96acf884
AB
51582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5159
5160 * nios2-tdep.c (nios2_dummy_id): Delete.
5161 (nios2_unwind_sp): Delete.
5162 (nios2_gdbarch_init): Don't register deleted functions with
5163 gdbarch.
5164
ca0ab0aa
AB
51652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5166
5167 * nds32-tdep.c (nds32_dummy_id): Delete.
5168 (nds32_unwind_pc): Delete.
5169 (nds32_unwind_sp): Delete.
5170 (nds32_gdbarch_init): Don't register deleted functions with
5171 gdbarch.
5172
c8259044
AB
51732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5174
5175 * msp430-tdep.c (msp430_unwind_pc): Delete.
5176 (msp430_unwind_sp): Delete.
5177 (msp430_dummy_id): Delete.
5178 (msp430_gdbarch_init): Don't register deleted functions with
5179 gdbarch.
5180
27f113c8
AB
51812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5182
5183 * moxie-tdep.c (moxie_unwind_sp): Delete.
5184 (moxie_unwind_pc): Delete.
5185 (moxie_dummy_id): Delete.
5186 (moxie_gdbarch_init): Don't register deleted functions with
5187 gdbarch.
5188
aee6c3cd
AB
51892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5190
5191 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5192 (mn10300_unwind_pc): Delete.
5193 (mn10300_unwind_sp): Delete.
5194 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5195 mn10300_unwind_sp.
5196 (mn10300_frame_unwind_init): Don't register deleted functions with
5197 gdbarch.
5198
8e2b5aea
AB
51992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5200
5201 * mep-tdep.c (mep_unwind_pc): Delete.
5202 (mep_unwind_sp): Delete.
5203 (mep_dummy_id): Delete.
5204 (mep_gdbarch_init): Don't register deleted functions with
5205 gdbarch.
5206
43cf3ede
AB
52072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5208
5209 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5210 (m68hc11_unwind_sp): Delete.
5211 (m68hc11_gdbarch_init): Don't register deleted functions with
5212 gdbarch.
5213
5e79b7bb
AB
52142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5215
5216 * m32r-tdep.c (m32r_unwind_sp): Delete.
5217 (m32r_unwind_pc): Delete.
5218 (m32r_dummy_id): Delete.
5219 (m32r_gdbarch_init): Don't register deleted functions with
5220 gdbarch.
5221
89b268d8
AB
52222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5223
5224 * m32c-tdep.c (m32c_unwind_pc): Delete.
5225 (m32c_unwind_sp): Delete.
5226 (m32c_dummy_id): Delete.
5227 (m32c_gdbarch_init): Don't register deleted functions with
5228 gdbarch.
5229
946c28d2
AB
52302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5231
5232 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5233 (lm32_unwind_pc): Delete.
5234 (lm32_dummy_id): Delete.
5235 (lm32_gdbarch_init): Don't register deleted functions with
5236 gdbarch.
5237
bf12844a
AB
52382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5239
5240 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5241 (iq2000_unwind_pc): Delete.
5242 (iq2000_dummy_id): Delete.
5243 (iq2000_gdbarch_init): Don't register deleted functions with
5244 gdbarch.
5245
ecbc06d2
AB
52462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5247
5248 * nds32-tdep.c (nds32_type_align): Delete.
5249 (nds32_push_dummy_call): Use type_align instead.
5250
030197b4
AB
52512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5252
5253 * arm-tdep.c (arm_type_align): Only handle vector override case.
5254 (arm_push_dummy_call): Use type_align.
5255 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5256
b907456c
AB
52572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5258
5259 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5260 case.
5261 (pass_on_stack): Use type_align.
5262 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5263 function.
5264
9e97ba43
TT
52652019-04-23 Tom Tromey <tromey@adacore.com>
5266
5267 * dwarf2read.c (line_header::file_name_at): Remove unused
5268 overload.
5269
6892f601
TV
52702019-04-23 Tom de Vries <tdevries@suse.de>
5271
5272 PR gdb/24438
5273 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5274 invocation.
5275
336d760d
AT
5276
52772019-03-27 Ali Tamur <tamur@google.com>
5278
5279 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5280 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5281 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5282 (dwarf_expr_context::get_addr_index): Likewise
5283 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5284 (symbol_needs_eval_context::get_addr_index): Likewise
5285 (disassemble_dwarf_expression): Add DW_OP_addrx
5286 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5287 (read_cutu_die_from_dwo): Update comment
5288 (skip_one_die): Add DW_FORM_addrx
5289 (read_attribute_value): Likewise
5290 (var_decode_location): Add DW_OP_addrx
5291 (dwarf2_const_value_attr): Add DW_FORM_addrx
5292 (dump_die_shallow): Likewise
5293 (dwarf2_fetch_constant_bytes): Likewise
5294 (decode_locdesc): Add DW_OP_addrx
5295 (skip_form_bytes): Add DW_FORM_addrx
5296
ad9d13f8
AT
52972019-04-22 Ali Tamur <tamur@google.com>
5298
5299 * MAINTAINERS (Write After Approval): Add self.
5300
d70cc3ba
SM
53012019-04-22 Simon Marchi <simon.marchi@efficios.com>
5302
5303 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5304 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5305 (open_symbol_file_object): Likewise.
5306 (svr4_default_sos): Add info parameter.
5307 (svr4_read_so_list): Likewise.
5308 (svr4_current_sos_direct): Adjust functions calls to pass down
5309 info.
5310 (svr4_current_sos_1): Add info parameter.
5311 (svr4_current_sos): Call get_svr4_info, pass info down to
5312 svr4_current_sos_1.
5313 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5314 get_svr4_info.
5315 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5316 get_svr4_info.
5317 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5318 to get_svr4_info.
5319 (probes_table_remove_objfile_probes): Likewise.
5320 (register_solib_event_probe): Add info parameter.
5321 (solist_update_incremental): Pass info parameter down to
5322 svr4_read_so_list.
5323 (disable_probes_interface): Add info parameter.
5324 (svr4_handle_solib_event): Pass current_program_space to
5325 get_svr4_info. Adjust disable_probes_interface cleanup.
5326 (svr4_create_probe_breakpoints): Add info parameter, pass it
5327 down to register_solib_event_probe.
5328 (svr4_create_solib_event_breakpoints): Add info parameter,
5329 pass it down to svr4_create_probe_breakpoints.
5330 (enable_break): Pass info down to
5331 svr4_create_solib_event_breakpoints.
5332 (svr4_solib_create_inferior_hook): Pass current_program_space to
5333 get_svr4_info.
5334 (svr4_clear_solib): Likewise.
5335
7905fc35
PA
53362019-04-22 Pedro Alves <palves@redhat.com>
5337
5338 * solib-svr4.c (svr4_free_objfile_observer): New.
5339 (probe_and_action::objfile): New field.
5340 (probes_table_htab_remove_objfile_probes)
5341 (probes_table_remove_objfile_probes): New functions.
5342 (register_solib_event_probe): Add 'objfile' parameter. Store it
5343 in the new probe_and_action. Don't store the probe in 'lookup'.
5344 (svr4_create_probe_breakpoints): Pass objfile to
5345 register_solib_event_probe.
5346 (_initialize_svr4_solib): Register a free_objfile observer.
5347
fb881986
TT
53482019-04-19 Tom Tromey <tom@tromey.com>
5349
5350 * common/queue.h: Remove.
5351
8732db6c
TT
53522019-04-19 Tom Tromey <tom@tromey.com>
5353
5354 * event-loop.c: Don't include "common/queue.h".
5355
97dfbadd
TT
53562019-04-19 Tom Tromey <tom@tromey.com>
5357
5358 * remote.c (remote_target): Use delete.
5359 * remote-notif.h: Include <list>, not "common/queue.h".
5360 (notif_client_p): Remove typedef.
5361 (remote_notif_state): Add constructor, destructor, initializer.
5362 <notif_queue>: Now a std::list.
5363 (remote_notif_state_xfree): Don't declare.
5364 * remote-notif.c (remote_notif_process, handle_notification)
5365 (remote_notif_state_allocate): Update.
5366 (~remote_notif_state): Rename from remote_notif_state_xfree.
5367
cf250e36
TT
53682019-04-19 Tom Tromey <tom@tromey.com>
5369
5370 * symfile.c (reread_symbols): Update.
5371 * objfiles.c (objfile_register_static_link)
5372 (objfile_lookup_static_link): Update
5373 (~objfile) Don't delete static_links.
5374 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5375
61f4b350
TT
53762019-04-19 Tom Tromey <tom@tromey.com>
5377
5378 * type-stack.h (struct type_stack) <insert>: Constify string.
5379 * type-stack.c (type_stack::insert): Constify string.
5380 * gdbtypes.h (lookup_template_type): Update.
5381 (address_space_name_to_int): Update.
5382 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5383 const.
5384 (lookup_template_type): Make name const.
5385 * c-exp.y: Update rules.
5386 (lex_one_token, classify_name, classify_inner_name)
5387 (c_print_token): Update.
5388 * p-exp.y: Update rules.
5389 (yylex): Update.
5390 * f-exp.y: Update rules.
5391 (yylex): Update.
5392 * d-exp.y: Update rules.
5393 (lex_one_token, classify_name, classify_inner_name): Update.
5394 * parse.c (write_dollar_variable, copy_name): Return std::string.
5395 * parser-defs.h (copy_name): Change return type.
5396 * m2-exp.y: Update rules.
5397 (yylex): Update.
5398 * go-exp.y (lex_one_token): Update.
5399 Update rules.
5400 (classify_unsafe_function, classify_packaged_name)
5401 (classify_name, yylex): Update.
5402
189b8c2e
ST
54032019-04-19 Sergei Trofimovich <siarheit@google.com>
5404
5405 * configure.ac: add --enable-source-highlight switch.
5406 * configure: Regenerate.
5407 * top.c (print_gdb_version): plumb --enable-source-highlight
5408 status to "show configuration".
5409
8ecb59f8
TT
54102019-04-19 Tom Tromey <tromey@adacore.com>
5411
5412 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5413 Check ADA_TYPE_P.
5414 (empty_record, ada_template_to_fixed_record_type_1)
5415 (template_to_static_fixed_type)
5416 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5417 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5418 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5419 macros.
5420
62160ec9
TT
54212019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5422
5423 PR symtab/24423:
5424 * source.c (print_source_lines_base): Advance "iter" when a
5425 control character is seen.
5426
f2ae8bc8
PW
54272019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5428
5429 * inferior.h (struct infcall_suspend_state_deleter):
5430 Catch exception in destructor to avoid crash.
5431
d563b953
PW
54322019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5433
5434 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5435 close to the add_com "shell".
5436
dc34c897
TT
54372019-04-18 Tom Tromey <tromey@adacore.com>
5438
5439 * process-stratum-target.h (class process_stratum_target)
5440 <stratum>: Add "final".
5441
a12e5744
TT
54422019-04-17 Tom Tromey <tromey@adacore.com>
5443
5444 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5445 against nullptr before use.
5446
a7e559cc
AH
54472019-04-17 Alan Hayward <alan.hayward@arm.com>
5448
5449 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5450
c01660c6
AB
54512019-04-17 Jim Wilson <jimw@sifive.com>
5452 Andrew Burgess <andrew.burgess@embecosm.com>
5453
5454 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5455 code read might fail, assume 4-byte breakpoint in that case.
5456
4aa866af
LS
54572019-04-15 Leszek Swirski <leszeks@google.com>
5458
5459 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5460 rather than a hand-rolled POD check when checking for forced MEMORY
5461 classification.
5462
48574d91
AH
54632019-04-15 Alan Hayward <alan.hayward@arm.com>
5464
5465 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5466 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5467 function.
5468 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5469 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5470 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5471 declaration.
5472
4da037ef
AH
54732019-04-15 Alan Hayward <alan.hayward@arm.com>
5474
5475 * aarch64-linux-nat.c
5476 (aarch64_linux_nat_target::thread_architecture): Add override.
5477 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5478 each VQ.
5479
ccb8d7e8
AH
54802019-04-15 Alan Hayward <alan.hayward@arm.com>
5481
5482 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5483
35add35e
AB
54842019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
5485
5486 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5487 target types of size 96-bits, add some additional comments, and
5488 check that the builtin type we found was the correct size.
5489
51196bbc
EZ
54902019-04-12 Eli Zaretskii <eliz@gnu.org>
5491
5492 * utils.c (prompt_for_continue): Don't restore the styling at the
5493 end, as applied_style has the wrong value. This fixes styling in
5494 long lists of file names that are interrupted by the "Continue?"
5495 prompt.
5496
62253a61
AB
54972019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
5498
5499 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5500 * c-lang.c (c_language_defn): Likewise.
5501 (cplus_language_defn): Likewise.
5502 (asm_language_defn): Likewise.
5503 (minimal_language_defn): Likewise.
5504 * d-lang.c (d_language_defn): Likewise.
5505 * f-lang.c (f_language_defn): Likewise.
5506 * go-lang.c (go_language_defn): Likewise.
5507 * language.c (unknown_language_defn): Likewise.
5508 (auto_language_defn): Likewise.
5509 * language.h (struct language_defn): Remove la_magic field.
5510 (LANG_MAGIC): Delete.
5511 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5512 * objc-lang.c (objc_language_defn): Likewise.
5513 * opencl-lang.c (opencl_language_defn): Likewise.
5514 * p-lang.c (pascal_language_defn): Likewise.
5515 * rust-lang.c (rust_language_defn): Likewise.
5516
a9158a86
AB
55172019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5518
5519 * riscv-tdep.c (riscv_type_align): New function.
5520 (riscv_type_alignment): Delete.
5521 (riscv_arg_location): Use 'type_align'.
5522 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5523
41077b66
AB
55242019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5525
5526 * gdbtypes.c (type_align): A struct with no non-static fields also
5527 has alignment of 1.
5528
9f0272f8
AB
55292019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
5530
5531 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5532 component to 0.
5533 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5534 member.
5535 (riscv_struct_info::analyse): New implementation using new
5536 analyse_inner member function.
5537 (riscv_struct_info::field_offset): New member function.
5538 (riscv_struct_info::m_offsets): New member variable.
5539 (riscv_struct_info::analyse_inner): New private member function,
5540 takes the old implementation of riscv_struct_info::analyse but
5541 extended to track field offsets.
5542 (riscv_call_arg_struct): Update the struct folding special cases
5543 to handle cases where empty C++ structs, which are non-zero
5544 length, are found.
5545 (riscv_arg_location): Initialise the length of each location, a
5546 non-zero length now indicates the location is in use.
5547 (riscv_push_dummy_call): Allow for the first location having a
5548 non-zero offset when setting up arguments.
5549 (riscv_return_value): Likewise, but for return values.
5550
02cf60c7
TT
55512019-04-11 Tom Tromey <tromey@adacore.com>
5552
5553 * utils.c (internal_vproblem): Make "msg" const.
5554
68811f8f
AH
55552019-04-11 Alan Hayward <alan.hayward@arm.com>
5556
5557 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5558 * trad-frame.c (trad_frame_reset_saved_regs): New function.
5559 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5560 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5561
3f52fdbc
KB
55622019-04-10 Kevin Buettner <kevinb@redhat.com>
5563
5564 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5565 function.
5566 (fill_gregset): Call amd64_linux_collect_native_gregset instead
5567 of amd64_collect_native_gregset.
5568 (amd64_linux_nat_target::store_registers): Likewise.
5569
e9ad22ee
TT
55702019-04-10 Tom Tromey <tom@tromey.com>
5571
5572 * symtab.c (lookup_global_symbol_from_objfile)
5573 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5574 * objfiles.h (class separate_debug_iterator): New.
5575 (class separate_debug_range): New.
5576 (struct objfile) <separate_debug_objfiles>: New method.
5577 (objfile_separate_debug_iterate): Don't declare.
5578 * objfiles.c (separate_debug_iterator::operator++): Rename from
5579 objfile_separate_debug_iterate.
5580 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5581 iterator.
5582 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5583 iterator.
5584
ee371134
TT
55852019-04-10 Tom Tromey <tom@tromey.com>
5586
5587 * symfile.c (reread_symbols): Remove old comment.
5588 * objfiles.c (free_all_objfiles): Fix a typo.
5589
bf227d61
TT
55902019-04-10 Tom Tromey <tom@tromey.com>
5591
5592 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5593 * minsyms.c (lookup_minimal_symbol): Use foreach.
5594 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5595 (lookup_minimal_symbol_solib_trampoline): Likewise.
5596 * symfile.c (reread_symbols): Use foreach.
5597
8dc433a0
TT
55982019-04-09 Ivan Begert <ivanbegert@gmail.com>
5599 Tom Tromey <tromey@adacore.com>
5600
5601 PR rust/24414:
5602 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5603 (rust_lex_int_test): Change "value" to be LONGEST.
5604 (rust_lex_tests): Add test for long integer literal.
5605
9ab8741a
TT
56062019-04-09 Tom Tromey <tromey@adacore.com>
5607
5608 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5609 to bool.
5610 (extended_remote_target::attach): Update.
5611 (remote_target::remote_notice_new_inferior): Update.
5612 (remote_target::add_current_inferior_and_thread): Update.
5613 * inferior.c (exit_inferior_1): Use "false".
5614 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5615
e242fd12
SM
56162019-04-09 Simon Marchi <simon.marchi@efficios.com>
5617
9ca1957f 5618 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
5619 the "start" command.
5620
2b0c8b01
KB
56212019-04-08 Kevin Buettner <kevinb@redhat.com>
5622
5623 * python/py-inferior.c (infpy_thread_from_thread_handle):
5624 Adjust comments to reflect renaming of thread_from_thread_handle
5625 to thread_from_handle. Adjust keywords. Fix type error message.
5626 (inferior_object_methods): Add thread_from_handle. Retain
5627 thread_from_thread_handle, but mark it as deprecated.
5628
50a82723
KB
56292019-04-08 Kevin Buettner <kevinb@redhat.com>
5630
5631 * gdbthread.h (find_thread_by_handle): Revise declaration.
5632 * thread.c (find_thread_by_handle): Likewise. Adjust
5633 implementation too.
5634 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5635 support for buffer objects as handles.
5636
cf63b016
KB
56372019-04-08 Kevin Buettner <kevinb@redhat.com>
5638
5639 * python/py-infthread.c (thpy_thread_handle): New function.
5640 (thread_object_methods): Register thpy_thread_handle.
5641
3d6c6204
KB
56422019-04-08 Kevin Buettner <kevinb@redhat.com>
5643
5644 * gdbthread.h (thread_to_thread_handle): Declare.
5645 * thread.c (gdbtypes.h): Include.
5646 (thread_to_thread_handle): New function.
5647
5648 * target.h (struct target_ops): Add thread_info_to_thread_handle.
5649 (target_thread_info_to_thread_handle): Declare.
5650 * target.c (target_thread_info_to_thread_handle): New function.
5651 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5652 * target-delegates.c: Regenerate.
5653
5654 * linux-thread-db.c (class thread_db_target): Add method
5655 thread_info_to_thread_handle.
5656 (thread_db_target::thread_info_to_thread_handle): Define.
5657 * remote.c (class remote_target): Add new method
5658 thread_info_to_thread_handle.
5659 (remote_target::thread_info_to_thread_handle): Define.
5660
56be6ea8
PA
56612019-04-08 Pedro Alves <palves@redhat.com>
5662
5663 * common/common-exceptions.c (throw_exception): Don't create
5664 named object to throw; throw directly.
5665 (throw_it): Likewise. Don't initialize gdb_exception::message
5666 here, with new; pass FMT and AP to the ctor instead.
5667 * common/common-exceptions.h: Include <string>.
5668 (gdb_exception::gdb_exception(enum return_reason, enum errors,
5669 const char *, va_list)): New ctor. Use std::make_shared.
5670 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5671 errors)): Delete.
5672 (gdb_exception_error::gdb_exception_error(enum errors, const char
5673 *, va_list)): New.
5674 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5675 Add assertion.
5676 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5677 errors)): Delete.
5678 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5679 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5680 Add assertion.
5681
eedc3f4f
TT
56822019-04-08 Tom Tromey <tom@tromey.com>
5683
5684 * valops.c (value_rtti_indirect_type): Replace throw_exception
5685 with throw.
5686 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5687 with throw.
5688 * thread.c (thr_try_catch_cmd): Replace throw_exception with
5689 throw.
5690 * target.c (target_translate_tls_address): Replace throw_exception
5691 with throw.
5692 * stack.c (frame_apply_command_count): Replace throw_exception
5693 with throw.
5694 * solib-spu.c (append_ocl_sos): Replace throw_exception with
5695 throw.
5696 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5697 with throw.
5698 * rs6000-tdep.c (rs6000_frame_cache)
5699 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5700 * remote.c: Replace throw_exception with throw.
5701 * record-full.c (record_full_message, record_full_wait_1)
5702 (record_full_restore): Replace throw_exception with throw.
5703 * record-btrace.c:
5704 (get_thread_current_frame_id, record_btrace_start_replaying)
5705 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5706 (cmd_record_btrace_start): Replace throw_exception with throw.
5707 * parse.c (parse_exp_in_context_1): Replace throw_exception with
5708 throw.
5709 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5710 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5711 * linespec.c:
5712 (find_linespec_symbols): Replace throw_exception with throw.
5713 * infrun.c (displaced_step_prepare, resume): Replace
5714 throw_exception with throw.
5715 * infcmd.c (post_create_inferior): Replace throw_exception with
5716 throw.
5717 * inf-loop.c (inferior_event_handler): Replace throw_exception
5718 with throw.
5719 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5720 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5721 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5722 (get_prev_frame_always, get_frame_pc_if_available)
5723 (get_frame_address_in_block_if_available, get_frame_language):
5724 Replace throw_exception with throw.
5725 * frame-unwind.c (frame_unwind_try_unwinder): Replace
5726 throw_exception with throw.
5727 * eval.c (fetch_subexp_value, evaluate_var_value)
5728 (evaluate_funcall, evaluate_subexp_standard): Replace
5729 throw_exception with throw.
5730 * dwarf2loc.c (call_site_find_chain)
5731 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5732 Replace throw_exception with throw.
5733 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5734 with throw.
5735 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5736 throw.
5737 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5738 * completer.c (complete_line_internal): Replace throw_exception
5739 with throw.
5740 * compile/compile-object-run.c (compile_object_run): Replace
5741 throw_exception with throw.
5742 * cli/cli-script.c (process_next_line): Replace throw_exception
5743 with throw.
5744 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5745 (btrace_enable, btrace_maint_update_pt_packets): Replace
5746 throw_exception with throw.
5747 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5748 throw_exception with throw.
5749 * break-catch-throw.c (re_set_exception_catchpoint): Replace
5750 throw_exception with throw.
5751 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5752 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5753 * aarch64-tdep.c (aarch64_make_prologue_cache)
5754 (aarch64_make_stub_cache): Replace throw_exception with throw.
5755
26003a20
TT
57562019-04-08 Tom Tromey <tom@tromey.com>
5757
5758 * common/common-exceptions.c (throw_exception): Rename from
5759 throw_exception_cxx. Remove old copy. Make argument const.
5760 (throw_it): Create and throw exception objects directly.
5761 * common/common-exceptions.h (throw_exception): Make argument
5762 const.
5763 (struct gdb_exception_error): Add constructor.
5764 (struct gdb_exception_quit): Add constructor.
5765
d272eb37
TT
57662019-04-08 Tom Tromey <tom@tromey.com>
5767
5768 * common/common-exceptions.h (exception_rethrow): Don't declare.
5769 (TRY_SJLJ): Update comment.
5770 (TRY, CATCH, END_CATCH): Remove.
5771 * common/common-exceptions.c (exception_rethrow): Remove.
5772
230d2906
TT
57732019-04-08 Tom Tromey <tom@tromey.com>
5774
5775 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5776 Remove.
5777 (gdb_exception_error): Rename from
5778 gdb_exception_RETURN_MASK_ERROR.
5779 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5780 (gdb_quit_bad_alloc): Update.
5781 * aarch64-tdep.c: Update.
5782 * ada-lang.c: Update.
5783 * ada-typeprint.c: Update.
5784 * ada-valprint.c: Update.
5785 * amd64-tdep.c: Update.
5786 * arch-utils.c: Update.
5787 * break-catch-throw.c: Update.
5788 * breakpoint.c: Update.
5789 * btrace.c: Update.
5790 * c-varobj.c: Update.
5791 * cli/cli-cmds.c: Update.
5792 * cli/cli-interp.c: Update.
5793 * cli/cli-script.c: Update.
5794 * common/common-exceptions.c: Update.
5795 * common/new-op.c: Update.
5796 * common/selftest.c: Update.
5797 * compile/compile-c-symbols.c: Update.
5798 * compile/compile-cplus-symbols.c: Update.
5799 * compile/compile-object-load.c: Update.
5800 * compile/compile-object-run.c: Update.
5801 * completer.c: Update.
5802 * corelow.c: Update.
5803 * cp-abi.c: Update.
5804 * cp-support.c: Update.
5805 * cp-valprint.c: Update.
5806 * darwin-nat.c: Update.
5807 * disasm-selftests.c: Update.
5808 * dtrace-probe.c: Update.
5809 * dwarf-index-cache.c: Update.
5810 * dwarf-index-write.c: Update.
5811 * dwarf2-frame-tailcall.c: Update.
5812 * dwarf2-frame.c: Update.
5813 * dwarf2loc.c: Update.
5814 * dwarf2read.c: Update.
5815 * eval.c: Update.
5816 * event-loop.c: Update.
5817 * event-top.c: Update.
5818 * exec.c: Update.
5819 * f-valprint.c: Update.
5820 * fbsd-tdep.c: Update.
5821 * frame-unwind.c: Update.
5822 * frame.c: Update.
5823 * gdbtypes.c: Update.
5824 * gnu-v3-abi.c: Update.
5825 * guile/guile-internal.h: Update.
5826 * guile/scm-block.c: Update.
5827 * guile/scm-breakpoint.c: Update.
5828 * guile/scm-cmd.c: Update.
5829 * guile/scm-disasm.c: Update.
5830 * guile/scm-frame.c: Update.
5831 * guile/scm-lazy-string.c: Update.
5832 * guile/scm-math.c: Update.
5833 * guile/scm-param.c: Update.
5834 * guile/scm-ports.c: Update.
5835 * guile/scm-pretty-print.c: Update.
5836 * guile/scm-symbol.c: Update.
5837 * guile/scm-symtab.c: Update.
5838 * guile/scm-type.c: Update.
5839 * guile/scm-value.c: Update.
5840 * i386-linux-tdep.c: Update.
5841 * i386-tdep.c: Update.
5842 * inf-loop.c: Update.
5843 * infcall.c: Update.
5844 * infcmd.c: Update.
5845 * infrun.c: Update.
5846 * jit.c: Update.
5847 * language.c: Update.
5848 * linespec.c: Update.
5849 * linux-fork.c: Update.
5850 * linux-nat.c: Update.
5851 * linux-tdep.c: Update.
5852 * linux-thread-db.c: Update.
5853 * main.c: Update.
5854 * mi/mi-cmd-break.c: Update.
5855 * mi/mi-cmd-stack.c: Update.
5856 * mi/mi-interp.c: Update.
5857 * mi/mi-main.c: Update.
5858 * objc-lang.c: Update.
5859 * p-valprint.c: Update.
5860 * parse.c: Update.
5861 * ppc-linux-tdep.c: Update.
5862 * printcmd.c: Update.
5863 * python/py-arch.c: Update.
5864 * python/py-breakpoint.c: Update.
5865 * python/py-cmd.c: Update.
5866 * python/py-finishbreakpoint.c: Update.
5867 * python/py-frame.c: Update.
5868 * python/py-framefilter.c: Update.
5869 * python/py-gdb-readline.c: Update.
5870 * python/py-inferior.c: Update.
5871 * python/py-infthread.c: Update.
5872 * python/py-lazy-string.c: Update.
5873 * python/py-linetable.c: Update.
5874 * python/py-objfile.c: Update.
5875 * python/py-param.c: Update.
5876 * python/py-prettyprint.c: Update.
5877 * python/py-progspace.c: Update.
5878 * python/py-record-btrace.c: Update.
5879 * python/py-record.c: Update.
5880 * python/py-symbol.c: Update.
5881 * python/py-type.c: Update.
5882 * python/py-unwind.c: Update.
5883 * python/py-utils.c: Update.
5884 * python/py-value.c: Update.
5885 * python/python.c: Update.
5886 * record-btrace.c: Update.
5887 * record-full.c: Update.
5888 * remote-fileio.c: Update.
5889 * remote.c: Update.
5890 * riscv-tdep.c: Update.
5891 * rs6000-aix-tdep.c: Update.
5892 * rs6000-tdep.c: Update.
5893 * rust-exp.y: Update.
5894 * rust-lang.c: Update.
5895 * s390-tdep.c: Update.
5896 * selftest-arch.c: Update.
5897 * solib-dsbt.c: Update.
5898 * solib-frv.c: Update.
5899 * solib-spu.c: Update.
5900 * solib-svr4.c: Update.
5901 * solib.c: Update.
5902 * sparc64-linux-tdep.c: Update.
5903 * stack.c: Update.
5904 * symfile-mem.c: Update.
5905 * symmisc.c: Update.
5906 * target.c: Update.
5907 * thread.c: Update.
5908 * top.c: Update.
5909 * tracefile-tfile.c: Update.
5910 * tui/tui.c: Update.
5911 * typeprint.c: Update.
5912 * unittests/cli-utils-selftests.c: Update.
5913 * unittests/parse-connection-spec-selftests.c: Update.
5914 * valops.c: Update.
5915 * valprint.c: Update.
5916 * value.c: Update.
5917 * varobj.c: Update.
5918 * windows-nat.c: Update.
5919 * x86-linux-nat.c: Update.
5920 * xml-support.c: Update.
5921
a70b8144
TT
59222019-04-08 Tom Tromey <tom@tromey.com>
5923
5924 * xml-support.c: Use C++ exception handling.
5925 * x86-linux-nat.c: Use C++ exception handling.
5926 * windows-nat.c: Use C++ exception handling.
5927 * varobj.c: Use C++ exception handling.
5928 * value.c: Use C++ exception handling.
5929 * valprint.c: Use C++ exception handling.
5930 * valops.c: Use C++ exception handling.
5931 * unittests/parse-connection-spec-selftests.c: Use C++ exception
5932 handling.
5933 * unittests/cli-utils-selftests.c: Use C++ exception handling.
5934 * typeprint.c: Use C++ exception handling.
5935 * tui/tui.c: Use C++ exception handling.
5936 * tracefile-tfile.c: Use C++ exception handling.
5937 * top.c: Use C++ exception handling.
5938 * thread.c: Use C++ exception handling.
5939 * target.c: Use C++ exception handling.
5940 * symmisc.c: Use C++ exception handling.
5941 * symfile-mem.c: Use C++ exception handling.
5942 * stack.c: Use C++ exception handling.
5943 * sparc64-linux-tdep.c: Use C++ exception handling.
5944 * solib.c: Use C++ exception handling.
5945 * solib-svr4.c: Use C++ exception handling.
5946 * solib-spu.c: Use C++ exception handling.
5947 * solib-frv.c: Use C++ exception handling.
5948 * solib-dsbt.c: Use C++ exception handling.
5949 * selftest-arch.c: Use C++ exception handling.
5950 * s390-tdep.c: Use C++ exception handling.
5951 * rust-lang.c: Use C++ exception handling.
5952 * rust-exp.y: Use C++ exception handling.
5953 * rs6000-tdep.c: Use C++ exception handling.
5954 * rs6000-aix-tdep.c: Use C++ exception handling.
5955 * riscv-tdep.c: Use C++ exception handling.
5956 * remote.c: Use C++ exception handling.
5957 * remote-fileio.c: Use C++ exception handling.
5958 * record-full.c: Use C++ exception handling.
5959 * record-btrace.c: Use C++ exception handling.
5960 * python/python.c: Use C++ exception handling.
5961 * python/py-value.c: Use C++ exception handling.
5962 * python/py-utils.c: Use C++ exception handling.
5963 * python/py-unwind.c: Use C++ exception handling.
5964 * python/py-type.c: Use C++ exception handling.
5965 * python/py-symbol.c: Use C++ exception handling.
5966 * python/py-record.c: Use C++ exception handling.
5967 * python/py-record-btrace.c: Use C++ exception handling.
5968 * python/py-progspace.c: Use C++ exception handling.
5969 * python/py-prettyprint.c: Use C++ exception handling.
5970 * python/py-param.c: Use C++ exception handling.
5971 * python/py-objfile.c: Use C++ exception handling.
5972 * python/py-linetable.c: Use C++ exception handling.
5973 * python/py-lazy-string.c: Use C++ exception handling.
5974 * python/py-infthread.c: Use C++ exception handling.
5975 * python/py-inferior.c: Use C++ exception handling.
5976 * python/py-gdb-readline.c: Use C++ exception handling.
5977 * python/py-framefilter.c: Use C++ exception handling.
5978 * python/py-frame.c: Use C++ exception handling.
5979 * python/py-finishbreakpoint.c: Use C++ exception handling.
5980 * python/py-cmd.c: Use C++ exception handling.
5981 * python/py-breakpoint.c: Use C++ exception handling.
5982 * python/py-arch.c: Use C++ exception handling.
5983 * printcmd.c: Use C++ exception handling.
5984 * ppc-linux-tdep.c: Use C++ exception handling.
5985 * parse.c: Use C++ exception handling.
5986 * p-valprint.c: Use C++ exception handling.
5987 * objc-lang.c: Use C++ exception handling.
5988 * mi/mi-main.c: Use C++ exception handling.
5989 * mi/mi-interp.c: Use C++ exception handling.
5990 * mi/mi-cmd-stack.c: Use C++ exception handling.
5991 * mi/mi-cmd-break.c: Use C++ exception handling.
5992 * main.c: Use C++ exception handling.
5993 * linux-thread-db.c: Use C++ exception handling.
5994 * linux-tdep.c: Use C++ exception handling.
5995 * linux-nat.c: Use C++ exception handling.
5996 * linux-fork.c: Use C++ exception handling.
5997 * linespec.c: Use C++ exception handling.
5998 * language.c: Use C++ exception handling.
5999 * jit.c: Use C++ exception handling.
6000 * infrun.c: Use C++ exception handling.
6001 * infcmd.c: Use C++ exception handling.
6002 * infcall.c: Use C++ exception handling.
6003 * inf-loop.c: Use C++ exception handling.
6004 * i386-tdep.c: Use C++ exception handling.
6005 * i386-linux-tdep.c: Use C++ exception handling.
6006 * guile/scm-value.c: Use C++ exception handling.
6007 * guile/scm-type.c: Use C++ exception handling.
6008 * guile/scm-symtab.c: Use C++ exception handling.
6009 * guile/scm-symbol.c: Use C++ exception handling.
6010 * guile/scm-pretty-print.c: Use C++ exception handling.
6011 * guile/scm-ports.c: Use C++ exception handling.
6012 * guile/scm-param.c: Use C++ exception handling.
6013 * guile/scm-math.c: Use C++ exception handling.
6014 * guile/scm-lazy-string.c: Use C++ exception handling.
6015 * guile/scm-frame.c: Use C++ exception handling.
6016 * guile/scm-disasm.c: Use C++ exception handling.
6017 * guile/scm-cmd.c: Use C++ exception handling.
6018 * guile/scm-breakpoint.c: Use C++ exception handling.
6019 * guile/scm-block.c: Use C++ exception handling.
6020 * guile/guile-internal.h: Use C++ exception handling.
6021 * gnu-v3-abi.c: Use C++ exception handling.
6022 * gdbtypes.c: Use C++ exception handling.
6023 * frame.c: Use C++ exception handling.
6024 * frame-unwind.c: Use C++ exception handling.
6025 * fbsd-tdep.c: Use C++ exception handling.
6026 * f-valprint.c: Use C++ exception handling.
6027 * exec.c: Use C++ exception handling.
6028 * event-top.c: Use C++ exception handling.
6029 * event-loop.c: Use C++ exception handling.
6030 * eval.c: Use C++ exception handling.
6031 * dwarf2read.c: Use C++ exception handling.
6032 * dwarf2loc.c: Use C++ exception handling.
6033 * dwarf2-frame.c: Use C++ exception handling.
6034 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6035 * dwarf-index-write.c: Use C++ exception handling.
6036 * dwarf-index-cache.c: Use C++ exception handling.
6037 * dtrace-probe.c: Use C++ exception handling.
6038 * disasm-selftests.c: Use C++ exception handling.
6039 * darwin-nat.c: Use C++ exception handling.
6040 * cp-valprint.c: Use C++ exception handling.
6041 * cp-support.c: Use C++ exception handling.
6042 * cp-abi.c: Use C++ exception handling.
6043 * corelow.c: Use C++ exception handling.
6044 * completer.c: Use C++ exception handling.
6045 * compile/compile-object-run.c: Use C++ exception handling.
6046 * compile/compile-object-load.c: Use C++ exception handling.
6047 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6048 * compile/compile-c-symbols.c: Use C++ exception handling.
6049 * common/selftest.c: Use C++ exception handling.
6050 * common/new-op.c: Use C++ exception handling.
6051 * cli/cli-script.c: Use C++ exception handling.
6052 * cli/cli-interp.c: Use C++ exception handling.
6053 * cli/cli-cmds.c: Use C++ exception handling.
6054 * c-varobj.c: Use C++ exception handling.
6055 * btrace.c: Use C++ exception handling.
6056 * breakpoint.c: Use C++ exception handling.
6057 * break-catch-throw.c: Use C++ exception handling.
6058 * arch-utils.c: Use C++ exception handling.
6059 * amd64-tdep.c: Use C++ exception handling.
6060 * ada-valprint.c: Use C++ exception handling.
6061 * ada-typeprint.c: Use C++ exception handling.
6062 * ada-lang.c: Use C++ exception handling.
6063 * aarch64-tdep.c: Use C++ exception handling.
6064
3d6e9d23
TT
60652019-04-08 Tom Tromey <tom@tromey.com>
6066
6067 * xml-support.c (gdb_xml_parser::parse): Update.
6068 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6069 * value.c (show_convenience): Update.
6070 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6071 (test_parse_flags_qcs): Update.
6072 * thread.c (thr_try_catch_cmd): Update.
6073 * target.c (target_translate_tls_address): Update.
6074 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6075 (info_frame_command_core, frame_apply_command_count): Update.
6076 * rust-exp.y (rust_lex_exception_test): Update.
6077 * riscv-tdep.c (riscv_print_one_register_info): Update.
6078 * remote.c (remote_target::enable_btrace): Update.
6079 * record-btrace.c (record_btrace_enable_warn): Update.
6080 * python/py-utils.c (gdbpy_convert_exception): Update.
6081 * printcmd.c (do_one_display, print_variable_and_value): Update.
6082 * mi/mi-main.c (mi_print_exception): Update.
6083 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6084 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6085 * linux-nat.c (linux_nat_target::attach): Update.
6086 * linux-fork.c (class scoped_switch_fork_info): Update.
6087 * infrun.c (displaced_step_prepare): Update.
6088 * infcall.c (call_function_by_hand_dummy): Update.
6089 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6090 * gnu-v3-abi.c (print_one_vtable): Update.
6091 * frame.c (get_prev_frame_always): Update.
6092 * f-valprint.c (info_common_command_for_block): Update.
6093 * exec.c (try_open_exec_file): Update.
6094 * exceptions.c (print_exception, exception_print)
6095 (exception_fprintf, exception_print_same): Update.
6096 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6097 * dwarf-index-cache.c (index_cache::store)
6098 (index_cache::lookup_gdb_index): Update.
6099 * darwin-nat.c (maybe_cache_shell): Update.
6100 * cp-valprint.c (cp_print_value_fields): Update.
6101 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6102 (gcc_cplus_symbol_address): Update.
6103 * compile/compile-c-symbols.c (gcc_convert_symbol)
6104 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6105 * common/selftest.c: Update.
6106 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6107 a std::string.
6108 (exception_try_scope_entry, exception_try_scope_exit): Don't
6109 declare.
6110 (struct exception_try_scope): Remove.
6111 (TRY): Don't use exception_try_scope.
6112 (struct gdb_exception): Add constructor, operator=.
6113 <what>: New method.
6114 (struct gdb_exception_RETURN_MASK_ALL)
6115 (struct gdb_exception_RETURN_MASK_ERROR)
6116 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6117 (struct gdb_quit_bad_alloc): Update.
6118 * common/common-exceptions.c (exception_none): Change
6119 initializer.
6120 (struct catcher) <state, exception>: Initialize inline.
6121 <prev>: Remove member.
6122 (current_catcher): Remove.
6123 (catchers): New global.
6124 (exceptions_state_mc_init): Simplify.
6125 (catcher_pop): Remove.
6126 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6127 (try_scope_depth, exception_try_scope_entry)
6128 (exception_try_scope_exit): Remove.
6129 (throw_exception_sjlj): Update.
6130 (exception_messages, exception_messages_size): Remove.
6131 (throw_it): Simplify.
6132 (gdb_exception_sliced_copy): Remove.
6133 (throw_exception_cxx): Update.
6134 * cli/cli-script.c (script_from_file): Update.
6135 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6136 Update.
6137 * ada-valprint.c (ada_val_print): Update.
6138 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6139 (create_excep_cond_exprs): Update.
6140
c5c10118
TT
61412019-04-08 Tom Tromey <tom@tromey.com>
6142
6143 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6144 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6145 (TRY, CATCH, END_CATCH): Remove some definitions.
6146 * common/common-exceptions.c: Don't use GDB_XCPT.
6147 (catcher_list_size): Remove.
6148 (throw_exception, throw_it): Simplify.
6149
4de283e4
TT
61502019-04-05 Tom Tromey <tom@tromey.com>
6151
6152 Revert the header-sorting patch.
6153 * ft32-tdep.c: Revert.
6154 * frv-tdep.c: Revert.
6155 * frv-linux-tdep.c: Revert.
6156 * frame.c: Revert.
6157 * frame-unwind.c: Revert.
6158 * frame-base.c: Revert.
6159 * fork-child.c: Revert.
6160 * findvar.c: Revert.
6161 * findcmd.c: Revert.
6162 * filesystem.c: Revert.
6163 * filename-seen-cache.h: Revert.
6164 * filename-seen-cache.c: Revert.
6165 * fbsd-tdep.c: Revert.
6166 * fbsd-nat.h: Revert.
6167 * fbsd-nat.c: Revert.
6168 * f-valprint.c: Revert.
6169 * f-typeprint.c: Revert.
6170 * f-lang.c: Revert.
6171 * extension.h: Revert.
6172 * extension.c: Revert.
6173 * extension-priv.h: Revert.
6174 * expprint.c: Revert.
6175 * exec.h: Revert.
6176 * exec.c: Revert.
6177 * exceptions.c: Revert.
6178 * event-top.c: Revert.
6179 * event-loop.c: Revert.
6180 * eval.c: Revert.
6181 * elfread.c: Revert.
6182 * dwarf2read.h: Revert.
6183 * dwarf2read.c: Revert.
6184 * dwarf2loc.c: Revert.
6185 * dwarf2expr.h: Revert.
6186 * dwarf2expr.c: Revert.
6187 * dwarf2-frame.c: Revert.
6188 * dwarf2-frame-tailcall.c: Revert.
6189 * dwarf-index-write.h: Revert.
6190 * dwarf-index-write.c: Revert.
6191 * dwarf-index-common.c: Revert.
6192 * dwarf-index-cache.h: Revert.
6193 * dwarf-index-cache.c: Revert.
6194 * dummy-frame.c: Revert.
6195 * dtrace-probe.c: Revert.
6196 * disasm.h: Revert.
6197 * disasm.c: Revert.
6198 * disasm-selftests.c: Revert.
6199 * dictionary.c: Revert.
6200 * dicos-tdep.c: Revert.
6201 * demangle.c: Revert.
6202 * dcache.h: Revert.
6203 * dcache.c: Revert.
6204 * darwin-nat.h: Revert.
6205 * darwin-nat.c: Revert.
6206 * darwin-nat-info.c: Revert.
6207 * d-valprint.c: Revert.
6208 * d-namespace.c: Revert.
6209 * d-lang.c: Revert.
6210 * ctf.c: Revert.
6211 * csky-tdep.c: Revert.
6212 * csky-linux-tdep.c: Revert.
6213 * cris-tdep.c: Revert.
6214 * cris-linux-tdep.c: Revert.
6215 * cp-valprint.c: Revert.
6216 * cp-support.c: Revert.
6217 * cp-namespace.c: Revert.
6218 * cp-abi.c: Revert.
6219 * corelow.c: Revert.
6220 * corefile.c: Revert.
6221 * continuations.c: Revert.
6222 * completer.h: Revert.
6223 * completer.c: Revert.
6224 * complaints.c: Revert.
6225 * coffread.c: Revert.
6226 * coff-pe-read.c: Revert.
6227 * cli-out.h: Revert.
6228 * cli-out.c: Revert.
6229 * charset.c: Revert.
6230 * c-varobj.c: Revert.
6231 * c-valprint.c: Revert.
6232 * c-typeprint.c: Revert.
6233 * c-lang.c: Revert.
6234 * buildsym.c: Revert.
6235 * buildsym-legacy.c: Revert.
6236 * build-id.h: Revert.
6237 * build-id.c: Revert.
6238 * btrace.c: Revert.
6239 * bsd-uthread.c: Revert.
6240 * breakpoint.h: Revert.
6241 * breakpoint.c: Revert.
6242 * break-catch-throw.c: Revert.
6243 * break-catch-syscall.c: Revert.
6244 * break-catch-sig.c: Revert.
6245 * blockframe.c: Revert.
6246 * block.c: Revert.
6247 * bfin-tdep.c: Revert.
6248 * bfin-linux-tdep.c: Revert.
6249 * bfd-target.c: Revert.
6250 * bcache.c: Revert.
6251 * ax-general.c: Revert.
6252 * ax-gdb.h: Revert.
6253 * ax-gdb.c: Revert.
6254 * avr-tdep.c: Revert.
6255 * auxv.c: Revert.
6256 * auto-load.c: Revert.
6257 * arm-wince-tdep.c: Revert.
6258 * arm-tdep.c: Revert.
6259 * arm-symbian-tdep.c: Revert.
6260 * arm-pikeos-tdep.c: Revert.
6261 * arm-obsd-tdep.c: Revert.
6262 * arm-nbsd-tdep.c: Revert.
6263 * arm-nbsd-nat.c: Revert.
6264 * arm-linux-tdep.c: Revert.
6265 * arm-linux-nat.c: Revert.
6266 * arm-fbsd-tdep.c: Revert.
6267 * arm-fbsd-nat.c: Revert.
6268 * arm-bsd-tdep.c: Revert.
6269 * arch-utils.c: Revert.
6270 * arc-tdep.c: Revert.
6271 * arc-newlib-tdep.c: Revert.
6272 * annotate.h: Revert.
6273 * annotate.c: Revert.
6274 * amd64-windows-tdep.c: Revert.
6275 * amd64-windows-nat.c: Revert.
6276 * amd64-tdep.c: Revert.
6277 * amd64-sol2-tdep.c: Revert.
6278 * amd64-obsd-tdep.c: Revert.
6279 * amd64-obsd-nat.c: Revert.
6280 * amd64-nbsd-tdep.c: Revert.
6281 * amd64-nbsd-nat.c: Revert.
6282 * amd64-nat.c: Revert.
6283 * amd64-linux-tdep.c: Revert.
6284 * amd64-linux-nat.c: Revert.
6285 * amd64-fbsd-tdep.c: Revert.
6286 * amd64-fbsd-nat.c: Revert.
6287 * amd64-dicos-tdep.c: Revert.
6288 * amd64-darwin-tdep.c: Revert.
6289 * amd64-bsd-nat.c: Revert.
6290 * alpha-tdep.c: Revert.
6291 * alpha-obsd-tdep.c: Revert.
6292 * alpha-nbsd-tdep.c: Revert.
6293 * alpha-mdebug-tdep.c: Revert.
6294 * alpha-linux-tdep.c: Revert.
6295 * alpha-linux-nat.c: Revert.
6296 * alpha-bsd-tdep.c: Revert.
6297 * alpha-bsd-nat.c: Revert.
6298 * aix-thread.c: Revert.
6299 * agent.c: Revert.
6300 * addrmap.c: Revert.
6301 * ada-varobj.c: Revert.
6302 * ada-valprint.c: Revert.
6303 * ada-typeprint.c: Revert.
6304 * ada-tasks.c: Revert.
6305 * ada-lang.c: Revert.
6306 * aarch64-tdep.c: Revert.
6307 * aarch64-ravenscar-thread.c: Revert.
6308 * aarch64-newlib-tdep.c: Revert.
6309 * aarch64-linux-tdep.c: Revert.
6310 * aarch64-linux-nat.c: Revert.
6311 * aarch64-fbsd-tdep.c: Revert.
6312 * aarch64-fbsd-nat.c: Revert.
6313 * aarch32-linux-nat.c: Revert.
6314
d55e5aa6
TT
63152019-04-05 Tom Tromey <tom@tromey.com>
6316
6317 * ft32-tdep.c: Sort headers.
6318 * frv-tdep.c: Sort headers.
6319 * frv-linux-tdep.c: Sort headers.
6320 * frame.c: Sort headers.
6321 * frame-unwind.c: Sort headers.
6322 * frame-base.c: Sort headers.
6323 * fork-child.c: Sort headers.
6324 * findvar.c: Sort headers.
6325 * findcmd.c: Sort headers.
6326 * filesystem.c: Sort headers.
6327 * filename-seen-cache.h: Sort headers.
6328 * filename-seen-cache.c: Sort headers.
6329 * fbsd-tdep.c: Sort headers.
6330 * fbsd-nat.h: Sort headers.
6331 * fbsd-nat.c: Sort headers.
6332 * f-valprint.c: Sort headers.
6333 * f-typeprint.c: Sort headers.
6334 * f-lang.c: Sort headers.
6335 * extension.h: Sort headers.
6336 * extension.c: Sort headers.
6337 * extension-priv.h: Sort headers.
6338 * expprint.c: Sort headers.
6339 * exec.h: Sort headers.
6340 * exec.c: Sort headers.
6341 * exceptions.c: Sort headers.
6342 * event-top.c: Sort headers.
6343 * event-loop.c: Sort headers.
6344 * eval.c: Sort headers.
6345 * elfread.c: Sort headers.
6346 * dwarf2read.h: Sort headers.
6347 * dwarf2read.c: Sort headers.
6348 * dwarf2loc.c: Sort headers.
6349 * dwarf2expr.h: Sort headers.
6350 * dwarf2expr.c: Sort headers.
6351 * dwarf2-frame.c: Sort headers.
6352 * dwarf2-frame-tailcall.c: Sort headers.
6353 * dwarf-index-write.h: Sort headers.
6354 * dwarf-index-write.c: Sort headers.
6355 * dwarf-index-common.c: Sort headers.
6356 * dwarf-index-cache.h: Sort headers.
6357 * dwarf-index-cache.c: Sort headers.
6358 * dummy-frame.c: Sort headers.
6359 * dtrace-probe.c: Sort headers.
6360 * disasm.h: Sort headers.
6361 * disasm.c: Sort headers.
6362 * disasm-selftests.c: Sort headers.
6363 * dictionary.c: Sort headers.
6364 * dicos-tdep.c: Sort headers.
6365 * demangle.c: Sort headers.
6366 * dcache.h: Sort headers.
6367 * dcache.c: Sort headers.
6368 * darwin-nat.h: Sort headers.
6369 * darwin-nat.c: Sort headers.
6370 * darwin-nat-info.c: Sort headers.
6371 * d-valprint.c: Sort headers.
6372 * d-namespace.c: Sort headers.
6373 * d-lang.c: Sort headers.
6374 * ctf.c: Sort headers.
6375 * csky-tdep.c: Sort headers.
6376 * csky-linux-tdep.c: Sort headers.
6377 * cris-tdep.c: Sort headers.
6378 * cris-linux-tdep.c: Sort headers.
6379 * cp-valprint.c: Sort headers.
6380 * cp-support.c: Sort headers.
6381 * cp-namespace.c: Sort headers.
6382 * cp-abi.c: Sort headers.
6383 * corelow.c: Sort headers.
6384 * corefile.c: Sort headers.
6385 * continuations.c: Sort headers.
6386 * completer.h: Sort headers.
6387 * completer.c: Sort headers.
6388 * complaints.c: Sort headers.
6389 * coffread.c: Sort headers.
6390 * coff-pe-read.c: Sort headers.
6391 * cli-out.h: Sort headers.
6392 * cli-out.c: Sort headers.
6393 * charset.c: Sort headers.
6394 * c-varobj.c: Sort headers.
6395 * c-valprint.c: Sort headers.
6396 * c-typeprint.c: Sort headers.
6397 * c-lang.c: Sort headers.
6398 * buildsym.c: Sort headers.
6399 * buildsym-legacy.c: Sort headers.
6400 * build-id.h: Sort headers.
6401 * build-id.c: Sort headers.
6402 * btrace.c: Sort headers.
6403 * bsd-uthread.c: Sort headers.
6404 * breakpoint.h: Sort headers.
6405 * breakpoint.c: Sort headers.
6406 * break-catch-throw.c: Sort headers.
6407 * break-catch-syscall.c: Sort headers.
6408 * break-catch-sig.c: Sort headers.
6409 * blockframe.c: Sort headers.
6410 * block.c: Sort headers.
6411 * bfin-tdep.c: Sort headers.
6412 * bfin-linux-tdep.c: Sort headers.
6413 * bfd-target.c: Sort headers.
6414 * bcache.c: Sort headers.
6415 * ax-general.c: Sort headers.
6416 * ax-gdb.h: Sort headers.
6417 * ax-gdb.c: Sort headers.
6418 * avr-tdep.c: Sort headers.
6419 * auxv.c: Sort headers.
6420 * auto-load.c: Sort headers.
6421 * arm-wince-tdep.c: Sort headers.
6422 * arm-tdep.c: Sort headers.
6423 * arm-symbian-tdep.c: Sort headers.
6424 * arm-pikeos-tdep.c: Sort headers.
6425 * arm-obsd-tdep.c: Sort headers.
6426 * arm-nbsd-tdep.c: Sort headers.
6427 * arm-nbsd-nat.c: Sort headers.
6428 * arm-linux-tdep.c: Sort headers.
6429 * arm-linux-nat.c: Sort headers.
6430 * arm-fbsd-tdep.c: Sort headers.
6431 * arm-fbsd-nat.c: Sort headers.
6432 * arm-bsd-tdep.c: Sort headers.
6433 * arch-utils.c: Sort headers.
6434 * arc-tdep.c: Sort headers.
6435 * arc-newlib-tdep.c: Sort headers.
6436 * annotate.h: Sort headers.
6437 * annotate.c: Sort headers.
6438 * amd64-windows-tdep.c: Sort headers.
6439 * amd64-windows-nat.c: Sort headers.
6440 * amd64-tdep.c: Sort headers.
6441 * amd64-sol2-tdep.c: Sort headers.
6442 * amd64-obsd-tdep.c: Sort headers.
6443 * amd64-obsd-nat.c: Sort headers.
6444 * amd64-nbsd-tdep.c: Sort headers.
6445 * amd64-nbsd-nat.c: Sort headers.
6446 * amd64-nat.c: Sort headers.
6447 * amd64-linux-tdep.c: Sort headers.
6448 * amd64-linux-nat.c: Sort headers.
6449 * amd64-fbsd-tdep.c: Sort headers.
6450 * amd64-fbsd-nat.c: Sort headers.
6451 * amd64-dicos-tdep.c: Sort headers.
6452 * amd64-darwin-tdep.c: Sort headers.
6453 * amd64-bsd-nat.c: Sort headers.
6454 * alpha-tdep.c: Sort headers.
6455 * alpha-obsd-tdep.c: Sort headers.
6456 * alpha-nbsd-tdep.c: Sort headers.
6457 * alpha-mdebug-tdep.c: Sort headers.
6458 * alpha-linux-tdep.c: Sort headers.
6459 * alpha-linux-nat.c: Sort headers.
6460 * alpha-bsd-tdep.c: Sort headers.
6461 * alpha-bsd-nat.c: Sort headers.
6462 * aix-thread.c: Sort headers.
6463 * agent.c: Sort headers.
6464 * addrmap.c: Sort headers.
6465 * ada-varobj.c: Sort headers.
6466 * ada-valprint.c: Sort headers.
6467 * ada-typeprint.c: Sort headers.
6468 * ada-tasks.c: Sort headers.
6469 * ada-lang.c: Sort headers.
6470 * aarch64-tdep.c: Sort headers.
6471 * aarch64-ravenscar-thread.c: Sort headers.
6472 * aarch64-newlib-tdep.c: Sort headers.
6473 * aarch64-linux-tdep.c: Sort headers.
6474 * aarch64-linux-nat.c: Sort headers.
6475 * aarch64-fbsd-tdep.c: Sort headers.
6476 * aarch64-fbsd-nat.c: Sort headers.
6477 * aarch32-linux-nat.c: Sort headers.
6478
699bd4cf
TT
64792019-04-04 Tom Tromey <tom@tromey.com>
6480
6481 * varobj.c (varobj_create): Update.
6482 * rust-exp.y (struct rust_parser) <update_innermost_block,
6483 lookup_symbol>: New methods.
6484 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6485 Rename.
6486 (rust_parser::rust_lookup_type)
6487 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6488 * printcmd.c (display_command, do_one_display): Update.
6489 * parser-defs.h (struct parser_state) <parser_state>: Add
6490 "tracker" parameter.
6491 (block_tracker): New member.
6492 (class innermost_block_tracker) <innermost_block_tracker>: Add
6493 "types" parameter.
6494 <reset>: Remove method.
6495 (innermost_block): Don't declare.
6496 (null_post_parser): Update.
6497 * parse.c (innermost_block): Remove global.
6498 (write_dollar_variable): Update.
6499 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6500 Remove "tracker_types" parameter.
6501 (parse_expression): Add "tracker" parameter.
6502 (parse_expression_for_completion): Update.
6503 (null_post_parser): Add "tracker" parameter.
6504 * p-exp.y: Update rules.
6505 * m2-exp.y: Update rules.
6506 * language.h (struct language_defn) <la_post_parser>: Add
6507 "tracker" parameter.
6508 * go-exp.y: Update rules.
6509 * f-exp.y: Update rules.
6510 * expression.h (parse_expression, parse_exp_1): Add "tracker"
6511 parameter.
6512 * d-exp.y: Update rules.
6513 * c-exp.y: Update rules.
6514 * breakpoint.c (set_breakpoint_condition): Create an
6515 innermost_block_tracker.
6516 (watch_command_1): Likewise.
6517 * ada-lang.c (resolve): Add "tracker" parameter.
6518 (resolve_subexp): Likewise.
6519 * ada-exp.y (write_var_from_sym): Update.
6520
dac43e32
TT
65212019-04-04 Tom Tromey <tom@tromey.com>
6522
6523 * type-stack.h: New file.
6524 * type-stack.c: New file.
6525 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6526 type-stack.h.
6527 (insert_into_type_stack, insert_type, push_type, push_type_int)
6528 (insert_type_address_space, pop_type, pop_type_int)
6529 (pop_typelist, pop_type_stack, append_type_stack)
6530 (push_type_stack, get_type_stack, push_typelist)
6531 (follow_type_instance_flags, follow_types): Don't declare.
6532 * parse.c (type_stack): Remove global.
6533 (parse_exp_in_context): Update.
6534 (insert_into_type_stack, insert_type, push_type, push_type_int)
6535 (insert_type_address_space, pop_type, pop_type_int)
6536 (pop_typelist, pop_type_stack, append_type_stack)
6537 (push_type_stack, get_type_stack, push_typelist)
6538 (follow_type_instance_flags, follow_types): Remove (moved to
6539 type-stack.c).
6540 * f-exp.y (type_stack): New global.
6541 Update rules.
6542 (push_kind_type, f_parse): Update.
6543 * d-exp.y (type_stack): New global.
6544 Update rules.
6545 (d_parse): Update.
6546 * c-exp.y (struct c_parse_state) <type_stack>: New member.
6547 Update rules.
6548 * Makefile.in (COMMON_SFILES): Add type-stack.c.
6549 (HFILES_NO_SRCDIR): Add type-stack.h.
6550
2a612529
TT
65512019-04-04 Tom Tromey <tom@tromey.com>
6552
6553 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6554 (rust_parser::convert_ast_to_expression, rust_parse)
6555 (rust_lex_test_completion, rust_lex_tests): Update.
6556 * parser-defs.h (struct expr_completion_state): New.
6557 (struct parser_state) <parser_state>: Add completion parameter.
6558 <mark_struct_expression, mark_completion_tag>: New methods.
6559 <parse_completion, m_completion_state>: New members.
6560 (prefixify_expression, null_post_parser): Update.
6561 (mark_struct_expression, mark_completion_tag): Don't declare.
6562 * parse.c (parse_completion, expout_last_struct)
6563 (expout_tag_completion_type, expout_completion_name): Remove
6564 globals.
6565 (parser_state::mark_struct_expression)
6566 (parser_state::mark_completion_tag): Now methods.
6567 (prefixify_expression): Add last_struct parameter.
6568 (prefixify_subexp): Likewise.
6569 (parse_exp_1): Update.
6570 (parse_exp_in_context): Add cstate parameter. Update.
6571 (parse_expression_for_completion): Create an
6572 expr_completion_state.
6573 (null_post_parser): Add "completion" parameter.
6574 * p-exp.y: Update rules.
6575 (yylex): Update.
6576 * language.h (struct language_defn) <la_post_parser>: Add
6577 "completing" parameter.
6578 * go-exp.y: Update rules.
6579 (lex_one_token): Update.
6580 * expression.h (parse_completion): Don't declare.
6581 * d-exp.y: Update rules.
6582 (lex_one_token): Update rules.
6583 * c-exp.y: Update rules.
6584 (lex_one_token): Update.
6585 * ada-lang.c (resolve): Add "parse_completion" parameter.
6586 (resolve_subexp): Likewise.
6587 (ada_resolve_function): Likewise.
6588
43476f0b
TT
65892019-04-04 Tom Tromey <tom@tromey.com>
6590
6591 * parser-defs.h (struct parser_state) <start_arglist,
6592 end_arglist>: New methods.
6593 <arglist_len, m_funcall_chain>: New members.
6594 (arglist_len, start_arglist, end_arglist): Don't declare.
6595 * parse.c (arglist_len, funcall_chain): Remove global.
6596 (start_arglist, end_arglist): Remove functions.
6597 (parse_exp_in_context): Update.
6598 * p-exp.y: Update rules.
6599 * m2-exp.y: Update rules.
6600 * go-exp.y: Update rules.
6601 * f-exp.y: Update rules.
6602 * d-exp.y: Update rules.
6603 * c-exp.y: Update rules.
6604
5776fca3
TT
66052019-04-04 Tom Tromey <tom@tromey.com>
6606
6607 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6608 lex_operator, push_back>: New methods.
6609 Update all rules.
6610 (rust_parser::lex_hex, lex_escape): Rename and update.
6611 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6612 (rust_parser::lex_operator): Rename and update.
6613 (rust_parser::lex_number, rustyylex, rustyyerror)
6614 (rust_lex_test_init, rust_lex_test_sequence)
6615 (rust_lex_test_push_back, rust_lex_tests): Update.
6616 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6617 parameter.
6618 <lexptr, prev_lexptr>: New members.
6619 (lexptr, prev_lexptr): Don't declare.
6620 * parse.c (lexptr, prev_lexptr): Remove globals.
6621 (parse_exp_in_context): Update.
6622 * p-exp.y (yylex, yyerror): Update.
6623 * m2-exp.y (parse_number, yylex, yyerror): Update.
6624 * go-exp.y (lex_one_token, yyerror): Update.
6625 * f-exp.y (match_string_literal, yylex, yyerror): Update.
6626 * d-exp.y (lex_one_token, yyerror): Update.
6627 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6628 (lex_one_token, yyerror): Update.
6629 * ada-lex.l (YY_INPUT): Update.
6630 (rewind_to_char): Update.
6631 * ada-exp.y (yyerror): Update.
6632
8621b685
TT
66332019-04-04 Tom Tromey <tom@tromey.com>
6634
6635 * rust-exp.y (rustyylex, rust_lex_tests): Update.
6636 * parser-defs.h (struct parser_state) <parser_state>: Add new
6637 parameter.
6638 <comma_terminates>: New member.
6639 (comma_terminates): Don't declare global.
6640 * parse.c (comma_terminates): Remove global.
6641 (parse_exp_in_context): Update.
6642 * p-exp.y (yylex): Update.
6643 * m2-exp.y (yylex): Update.
6644 * go-exp.y (lex_one_token): Update.
6645 * f-exp.y (yylex): Update.
6646 * d-exp.y (lex_one_token): Update.
6647 * c-exp.y (lex_one_token): Update.
6648 * ada-lex.l: Update.
6649
28aaf3fd
TT
66502019-04-04 Tom Tromey <tom@tromey.com>
6651
6652 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6653 (rustyylex, rust_lex_test_init, rust_lex_test_one)
6654 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6655 * parser-defs.h (paren_depth): Don't declare.
6656 * parse.c (paren_depth): Remove global.
6657 (parse_exp_in_context): Update.
6658 * p-exp.y (paren_depth): New global.
6659 (pascal_parse): Initialize it.
6660 * m2-exp.y (paren_depth): New global.
6661 (m2_parse): Initialize it.
6662 * go-exp.y (paren_depth): New global.
6663 (go_parse): Initialize it.
6664 * f-exp.y (paren_depth): New global.
6665 (f_parse): Initialize it.
6666 * d-exp.y (paren_depth): New global.
6667 (d_parse): Initialize it.
6668 * c-exp.y (paren_depth): New global.
6669 (c_parse): Initialize it.
6670 * ada-lex.l (paren_depth): New global.
6671 (lexer_init): Initialize it.
6672
1e58a4a4
TT
66732019-04-04 Tom Tromey <tom@tromey.com>
6674
6675 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6676 (rust_parser::convert_ast_to_type)
6677 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6678 * parser-defs.h (struct parser_state) <parser_state>: Add
6679 parameters. Initialize new members.
6680 <expression_context_block, expression_context_pc>: New members.
6681 * parse.c (expression_context_block, expression_context_pc):
6682 Remove globals.
6683 (parse_exp_in_context): Update.
6684 * p-exp.y: Update all rules.
6685 (yylex): Update.
6686 * m2-exp.y: Update all rules.
6687 (yylex): Update.
6688 * go-exp.y (yylex): Update.
6689 * f-exp.y (yylex): Update.
6690 * d-exp.y: Update all rules.
6691 (yylex): Update.
6692 * c-exp.y: Update all rules.
6693 (lex_one_token, classify_name, yylex, c_parse): Update.
6694 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6695
37eedb39
TT
66962019-04-04 Tom Tromey <tom@tromey.com>
6697
6698 * gdbarch.h, gdbarch.c: Rebuild.
6699 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6700 * stap-probe.h:
6701 (struct stap_parse_info): Replace "parser_state" with
6702 "expr_builder".
6703 * parser-defs.h (struct expr_builder): Rename from "parser_state".
6704 (parser_state): New class.
6705 * parse.c (expr_builder): Rename.
6706 (expr_builder::release): Rename.
6707 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6708 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6709 (write_exp_elt_longcst, write_exp_elt_floatcst)
6710 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6711 (write_exp_string_vector, write_exp_bitstring)
6712 (write_exp_msymbol, mark_struct_expression)
6713 (write_dollar_variable)
6714 (insert_type_address_space, increase_expout_size): Replace
6715 "parser_state" with "expr_builder".
6716 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6717 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6718 "parser_state" with "expr_builder".
6719
73923d7e
TT
67202019-04-04 Tom Tromey <tom@tromey.com>
6721
6722 * rust-exp.y: Replace "parse_language" with method call.
6723 * p-exp.y:
6724 (yylex): Replace "parse_language" with method call.
6725 * m2-exp.y:
6726 (yylex): Replace "parse_language" with method call.
6727 * go-exp.y (classify_name): Replace "parse_language" with method
6728 call.
6729 * f-exp.y (yylex): Replace "parse_language" with method call.
6730 * d-exp.y (lex_one_token): Replace "parse_language" with method
6731 call.
6732 * c-exp.y:
6733 (lex_one_token, classify_name, yylex): Replace "parse_language"
6734 with method call.
6735 * ada-exp.y (find_primitive_type, type_char)
6736 (type_system_address): Replace "parse_language" with method call.
6737
fa9f5be6
TT
67382019-04-04 Tom Tromey <tom@tromey.com>
6739
6740 * rust-exp.y: Replace "parse_gdbarch" with method call.
6741 * parse.c (write_dollar_variable, insert_type_address_space):
6742 Replace "parse_gdbarch" with method call.
6743 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6744 call.
6745 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6746 call.
6747 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6748 "parse_gdbarch" with method call.
6749 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6750 with method call.
6751 * f-exp.y (parse_type, parse_f_type, yylex): Replace
6752 "parse_gdbarch" with method call.
6753 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6754 "parse_gdbarch" with method call.
6755 * c-exp.y (parse_type, parse_number, classify_name): Replace
6756 "parse_gdbarch" with method call.
6757 * ada-lex.l: Replace "parse_gdbarch" with method call.
6758 * ada-exp.y (parse_type, find_primitive_type, type_char)
6759 (type_system_address): Replace "parse_gdbarch" with method call.
6760
1201a264
TT
67612019-04-04 Tom Tromey <tom@tromey.com>
6762
6763 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6764 * stap-probe.c (stap_parse_argument): Update.
6765 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6766 initial_size parameter.
6767 * rust-exp.y (rust_lex_tests): Update.
6768 * parse.c (parser_state): Update.
6769 (parse_exp_in_context): Update.
6770 * parser-defs.h (struct parser_state) <parser_state>: Remove
6771 "initial_size" parameter.
6772
e3980ce2
TT
67732019-04-04 Tom Tromey <tom@tromey.com>
6774
6775 * parser-defs.h (increase_expout_size): Don't declare.
6776 * parse.c (increase_expout_size): Now static.
6777
e9f8e3f1
TS
67782019-04-04 Thomas Schwinge <thomas@codesourcery.com>
6779
6780 * gnu-nat.c (gnu_nat_target::wait): Fix
6781 target_waitstatus_to_string call.
6782
d7df6549
AB
67832019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6784
6785 * eval.c (evaluate_subexp_standard): Handle internal functions
6786 during Fortran function call handling.
6787
8bdc1658
AB
67882019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
6789
6790 * NEWS: Mention new internal functions.
6791 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6792 (read_base_type): Use dwarf2_init_complex_target_type.
6793 * value.c (creal_internal_fn): New function.
6794 (cimag_internal_fn): New function.
6795 (_initialize_values): Register new internal functions.
6796
c29705b7
PW
67972019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6798
6799 * infrun.c (stop_all_threads): If debug_infrun, always
6800 trace the wait status after wait_one, using
6801 target_waitstatus_to_string and target_pid_to_str.
6802 (handle_inferior_event): Replace various trace of
6803 wait status kind by a single trace.
6804 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6805 wait status kind image by target_waitstatus_to_string.
6806 * target/waitstatus.c (target_waitstatus_to_string): Fix
6807 obsolete comment.
6808
05caa1d2
TT
68092019-04-01 Tom Tromey <tromey@adacore.com>
6810
6811 PR symtab/23331:
6812 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6813
9d1447e0
SDJ
68142019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
6815 Pedro Alves <palves@redhat.com>
6816
6817 * top.c (quit_force): Call 'finalize_values'.
6818 * value.c (finalize_values): New function.
6819 * value.h (finalize_values): Declare.
6820
7734102d
EZ
68212019-03-30 Eli Zaretskii <eliz@gnu.org>
6822
6823 * NEWS: Announce $_gdb_major and $_gdb_minor.
6824
6825 * top.c (init_gdb_version_vars): New function.
6826 (gdb_init): Call init_gdb_version_vars.
6827
188e1fa9
TT
68282019-03-29 Tom Tromey <tromey@adacore.com>
6829
6830 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
6831 help text. Remove dead code.
6832
2880242d
KS
68332019-03-29 Keith Seitz <keiths@redhat.com>
6834
6835 From Siddhesh Poyarekar:
6836 * f-lang.h (f77_get_upperbound): Return LONGEST.
6837 (f77_get_lowerbound): Likewise.
6838 * f-typeprint.c (f_type_print_varspec_suffix): Expand
6839 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
6840 print them.
6841 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
6842 plongest to format print it.
6843 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6844 (f77_get_upperbound): Likewise.
6845 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6846 LOWER_BOUND to LONGEST.
6847 (f77_create_arrayprint_offset_tbl): Likewise.
6848
cc1defb1
KS
68492019-03-29 Keith Seitz <keiths@redhat.com>
6850
6851 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6852 %s/pulongest for TYPE_LENGTH instead of %d in format
6853 strings.
6854 * ada-typerint.c (ada_print_type): Likewise.
6855 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6856 * compile/compile-c-support.c (generate_register_struct): Likewise.
6857 * gdbtypes.c (recursive_dump_type): Likewise.
6858 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6859 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
6860 instead of %d in format strings.
6861 * riscv-tdep.c (riscv_type_alignment): Cast second argument
6862 to std::min to ULONGEST.
6863 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6864 instead of %d in format strings.
6865 * tracepoint.c (info_scope_command): Likewise.
6866 * typeprint.c (print_offset_data::update)
6867 (print_offset_data::finish): Likewise.
6868 * xtensa-tdep.c (xtensa_store_return_value)
6869 (xtensa_push_dummy_call): Likewise.
6870
e432ccf1
JT
68712019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
6872
6873 * windows-nat.c (display_selector): Fixed format specifications
6874 for 64-bit Cygwin.
6875
65d2b333
PW
68762019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6877
6878 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6879
f489207e
SL
68802019-03-28 Sandra Loosemore <sandra@codesourcery.com>
6881
6882 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6883 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6884 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6885 (nios2_linux_init_abi): Install it.
6886
bffa1015
AH
68872019-03-28 Alan Hayward <alan.hayward@arm.com>
6888
6889 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6890
fc96163a
AH
68912019-03-28 Alan Hayward <alan.hayward@arm.com>
6892
6893 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6894
20dc7e9b
PW
68952019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6896 Tom Tromey <tromey@adacore.com>
6897
6898 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6899
7f5331a8
JB
69002019-03-26 Joel Brobecker <brobecker@adacore.com>
6901
6902 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6903 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6904 method to compute the bounds of range types. Also print "[evaluated]"
6905 if the bounds' values come from a dynamic evaluation.
6906
18c77628
AB
69072019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
6908
6909 * cp-valprint.c (cp_print_value_fields): Don't print trailing
6910 whitespace when pretty printing is on.
6911
53c973f2
AH
69122019-03-26 Alan Hayward <alan.hayward@arm.com>
6913
e79be6e5 6914 * ppc-linux-nat.c: Add include.
53c973f2 6915
d851aa71
AH
69162019-03-26 Alan Hayward <alan.hayward@arm.com>
6917
e79be6e5 6918 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 6919
2fe7bab7
AH
69202019-03-26 Alan Hayward <alan.hayward@arm.com>
6921
e79be6e5 6922 * arm-linux-nat.c: Add include.
2fe7bab7 6923
068ef30e
SM
69242019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
6925
6926 * source-cache.c (source_cache::get_source_lines): Re-read
6927 fullname after calling open_source_file.
6928
81a24d04
JB
69292019-03-25 John Baldwin <jhb@FreeBSD.org>
6930
6931 * NEWS: Mention TLS support for FreeBSD.
6932
79e7ae11
TT
69332019-03-25 Tom Tromey <tromey@adacore.com>
6934
6935 * minsyms.c (BUNCH_SIZE): Update comment.
6936 (~minimal_symbol_reader): Remove old comment.
6937 (compact_minimal_symbols): Update comment.
6938 (minimal_symbol_reader::install): Remove old comment. Update
6939 other comments.
6940
d45963c2
AH
69412019-03-25 Alan Hayward <alan.hayward@arm.com>
6942
6943 * s390-linux-nat.c: Add include.
6944
0f83012e
AH
69452019-03-25 Alan Hayward <alan.hayward@arm.com>
6946
6947 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6948 Call linux_get_hwcap.
6949 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6950 Likewise.
6951 (aarch64_linux_get_hwcap): Remove function.
6952 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6953 declaration.
6954 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6955 linux_get_hwcap.
6956 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6957 * linux-tdep.c (linux_get_hwcap): Add function.
6958 (linux_get_hwcap2): Likewise.
6959 * linux-tdep.h (linux_get_hwcap): Add declaration.
6960 (linux_get_hwcap2): Likewise.
6961 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6962 (ppc_linux_get_hwcap2): Likewise.
6963 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6964 linux_get_hwcap.
6965 (ppc_linux_nat_target::insert_watchpoint): Likewise.
6966 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6967 (ppc_linux_nat_target::read_description): Likewise.
6968 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6969 * s390-linux-nat.c: Likewise.
6970 * s390-linux-tdep.c (s390_core_read_description): Likewise.
6971
6640a367
TT
69722019-03-24 Tom Tromey <tom@tromey.com>
6973
6974 * ada-lang.c (standard_lookup): Simplify initialization.
6975 (ada_lookup_symbol_nonlocal): Simplify return.
6976 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6977 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6978 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6979 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6980 initialization.
6981 * solib.c (solib_global_lookup): Simplify.
6982 * symtab.c (null_block_symbol): Remove.
6983 (symbol_cache_lookup): Simplify returns.
6984 (lookup_language_this): Simplify returns.
6985 (lookup_symbol_aux): Simplify return.
6986 (lookup_local_symbol): Simplify returns.
6987 (lookup_global_symbol_from_objfile): Simplify return.
6988 (lookup_symbol_in_objfile_symtabs)
6989 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6990 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6991 (lookup_static_symbol, lookup_global_symbol): Simplify return.
6992 * cp-namespace.c (cp_lookup_bare_symbol)
6993 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6994 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6995 (cp_lookup_nested_symbol): Don't use null_block_symbol.
6996 (cp_lookup_symbol_via_imports): Simplify initialization.
6997 (find_symbol_in_baseclass): Likewise.
6998 * symtab.h (null_block_symbol): Remove.
6999 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7000 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7001 (d_lookup_symbol_module): Likewise.
7002 (find_symbol_in_baseclass): Simplify initialization.
7003
a930ebcd
TT
70042019-03-24 Tom Tromey <tom@tromey.com>
7005
7006 * expression.h: Don't include symtab.h.
7007 (struct block): Forward declare.
7008
582942f4
TT
70092019-03-24 Tom Tromey <tom@tromey.com>
7010
7011 * c-exp.y (typebase): Remove casts.
7012 * gdbtypes.c (lookup_unsigned_typename, )
7013 (lookup_signed_typename): Remove cast.
7014 * eval.c (parse_to_comma_and_eval): Remove cast.
7015 * parse.c (write_dollar_variable): Remove cast.
7016 * block.h (struct block) <superblock>: Now const.
7017 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7018 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7019 (map_block): Make "block" const.
7020 * symfile.h (struct quick_symbol_functions)
7021 <map_matching_symbols>: Constify block argument to "callback".
7022 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7023 const.
7024 (find_pc_sect_compunit_symtab): Make "b" const.
7025 (find_symbol_at_address): Likewise.
7026 (search_symbols): Likewise.
7027 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7028 (dw2_debug_names_lookup_symbol): Likewise.
7029 (dw2_map_matching_symbols): Update.
7030 * p-valprint.c (pascal_val_print): Remove "block".
7031 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7032 (aux_add_nonlocal_symbols): Make "block" const.
7033 (resolve_subexp): Remove cast.
7034 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7035 const.
7036 (iterate_over_file_blocks): Likewise.
7037 * f-exp.y (%union) <bval>: Remove.
7038 * coffread.c (patch_opaque_types): Make "b" const.
7039 * spu-tdep.c (spu_catch_start): Make "block" const.
7040 * c-valprint.c (print_unpacked_pointer): Remove "block".
7041 * symmisc.c (dump_symtab_1): Make "b" const.
7042 (block_depth): Make "block" const.
7043 * d-exp.y (%union) <bval>: Remove.
7044 * cp-support.h (cp_lookup_rtti_type): Update.
7045 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7046 * psymtab.c (psym_lookup_symbol): Make "block" const.
7047 (maintenance_check_psymtabs): Make "b" const.
7048 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7049 (enumerate_locals, enumerate_args): Update.
7050 * python/py-symtab.c (stpy_global_block): Make "block" const.
7051 (stpy_static_block): Likewise.
7052 * inline-frame.c (block_starting_point_at): Make "new_block"
7053 const.
7054 * block.c (find_block_in_blockvector): Make return type const.
7055 (blockvector_for_pc_sect): Make "b" const.
7056 (find_block_in_blockvector): Make "b" const.
7057
7ad417dd
TT
70582019-03-23 Tom Tromey <tom@tromey.com>
7059
7060 * varobj.c (varobj_create): Update.
7061 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7062 * printcmd.c (display_command, do_one_display): Don't reset
7063 innermost_block.
7064 * parser-defs.h (enum innermost_block_tracker_type): Move to
7065 expression.h.
7066 (innermost_block): Update comment.
7067 * parse.c (parse_exp_1): Add tracker_types parameter.
7068 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7069 tracker_types parameter. Reset innermost_block.
7070 (parse_exp_in_context): Remove.
7071 (parse_expression_for_completion): Update.
7072 * objfiles.c (~objfile): Don't reset expression_context_block or
7073 innermost_block.
7074 * expression.h (enum innermost_block_tracker_type): Move from
7075 parser-defs.h.
7076 (parse_exp_1): Add tracker_types parameter.
7077 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7078 reset innermost_block.
7079
b366c208
TT
70802019-03-23 Tom Tromey <tom@tromey.com>
7081
7082 * objfiles.h: Include bcache.h.
7083
9bb9b2f9
TT
70842019-03-23 Tom Tromey <tom@tromey.com>
7085
7086 * linespec.c (get_current_search_block): Use
7087 scoped_restore_current_language.
7088 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7089
59c28372
AH
70902019-03-22 Alan Hayward <alan.hayward@arm.com>
7091 Jiong Wang <jiong.wang@arm.com>
7092
7093 * aarch64-linux-tdep.c
7094 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7095 section.
7096 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7097
17e116a7
AH
70982019-03-22 Alan Hayward <alan.hayward@arm.com>
7099 Jiong Wang <jiong.wang@arm.com>
7100
7101 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7102 instructions.
7103 (aarch64_analyze_prologue_test): Add PACIASP test.
7104 (aarch64_prologue_prev_register): Unmask PC value.
7105
11e1b75f
AH
71062019-03-22 Alan Hayward <alan.hayward@arm.com>
7107 Jiong Wang <jiong.wang@arm.com>
7108
7109 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7110 (aarch64_dwarf2_prev_register): Unmask PC value.
7111 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7112 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7113 DW_CFA_AARCH64_negate_ra_state.
7114 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7115
34dcc7cf
AH
71162019-03-22 Alan Hayward <alan.hayward@arm.com>
7117 Jiong Wang <jiong.wang@arm.com>
7118
7119 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7120 registers.
7121 (aarch64_pseudo_register_name): Likewise.
7122 (aarch64_pseudo_register_type): Likewise.
7123 (aarch64_pseudo_register_reggroup_p): Likewise.
7124 (aarch64_gdbarch_init): Add pauth registers.
7125 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7126 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7127 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7128 (struct gdbarch_tdep): Add regnum for ra_state.
7129
1ef53e6b
AH
71302019-03-22 Alan Hayward <alan.hayward@arm.com>
7131 Jiong Wang <jiong.wang@arm.com>
7132
7133 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7134
76bed0fd
AH
71352019-03-22 Alan Hayward <alan.hayward@arm.com>
7136 Jiong Wang <jiong.wang@arm.com>
7137
7138 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7139 function.
7140 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7141 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7142 (aarch64_gdbarch_init): Add puth registers.
7143 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7144 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7145 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7146
ee4fbcfa
AH
71472019-03-22 Alan Hayward <alan.hayward@arm.com>
7148 Jiong Wang <jiong.wang@arm.com>
7149
7150 * aarch64-linux-nat.c
7151 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7152 * aarch64-linux-tdep.c
7153 (aarch64_linux_core_read_description): Likewise.
7154 (aarch64_linux_get_hwcap): New function.
7155 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7156 (aarch64_linux_get_hwcap): New declaration.
7157
6dc0ebde
AH
71582019-03-22 Alan Hayward <alan.hayward@arm.com>
7159 Jiong Wang <jiong.wang@arm.com>
7160
7161 * aarch64-linux-nat.c
7162 (aarch64_linux_nat_target::read_description): Add pauth param.
7163 * aarch64-linux-tdep.c
7164 (aarch64_linux_core_read_description): Likewise.
7165 * aarch64-tdep.c (struct target_desc): Add in pauth.
7166 (aarch64_read_description): Add pauth param.
7167 (aarch64_gdbarch_init): Likewise.
7168 * aarch64-tdep.h (aarch64_read_description): Likewise.
7169 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7170 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7171 * features/Makefile: Add new files.
7172 * features/aarch64-pauth.c: New file.
7173 * features/aarch64-pauth.xml: New file.
7174
595915c1
TT
71752019-03-20 Tom Tromey <tromey@adacore.com>
7176
7177 * infrun.c (handle_inferior_event): Rename from
7178 handle_inferior_event_1. Create a scoped_value_mark.
7179 (handle_inferior_event): Remove.
7180
4c7d57e7
TT
71812019-03-19 Tom Tromey <tromey@adacore.com>
7182
7183 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7184 * infrun.h (print_stop_event): Add "displays" parameter.
7185 * infrun.c (print_stop_event): Add "displays" parameter.
7186
cb246234
PA
71872019-03-19 Pedro Alves <palves@redhat.com>
7188
7189 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7190 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7191 to -1. Fix TABs vs spaces.
7192 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7193 * tui/tui-out.h (tui_ui_out) Add intro comments.
7194 <m_line, m_start_of_line>: In-class initialize, and add describing
7195 comment.
7196
3a0e45b2
AH
71972019-03-18 Alan Hayward <alan.hayward@arm.com>
7198
7199 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7200 variable names.
7201 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7202
5371b850
PA
72032019-03-18 Pedro Alves <palves@redhat.com>
7204 Eli Zaretskii <eliz@gnu.org>
7205
7206 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7207 m_line and m_start_of_line.
7208
b17c4cd0
EZ
72092019-03-18 Eli Zaretskii <eliz@gnu.org>
7210
7211 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7212 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7213 it returns a newline. This fixes a regression in TU mode, whereby
7214 the next line is output on the same screen line as the user input.
7215
4bd56d18
TT
72162019-03-18 Tom Tromey <tromey@adacore.com>
7217
7218 * minsyms.c (minimal_symbol_reader::install): Remove call to
7219 obstack_blank.
7220
55c10aca
PA
72212019-03-18 Pedro Alves <palves@redhat.com>
7222
7223 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7224 New globals.
7225 (apply_style): New, factored out from ...
7226 (apply_ansi_escape): ... this. Handle reverse video mode.
7227 (tui_set_reverse_mode): New function.
7228 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7229 * tui/tui-winsource.c (tui_show_source_line): Use
7230 tui_set_reverse_mode instead of setting A_STANDOUT.
7231 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7232 New setter methods.
7233
647bb750
HD
72342019-03-18 Hannes Domani <ssbssa@yahoo.de>
7235
7236 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7237 Handle tabs.
7238
bff8c71f
TT
72392019-03-18 Tom Tromey <tromey@adacore.com>
7240
7241 * ada-lang.c (empty_array): Add "high" parameter.
7242 (ada_evaluate_subexp): Update.
7243
58785d98
ST
72442019-03-17 Sergei Trofimovich <siarheit@google.com>
7245
7246 * unittests/string_view-selftests.c: Define
7247 _initialize_string_view_selftests unconditionally.
7248
d4cbef22
ВМ
72492019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7250
7251 PR gdb/24350
7252 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7253
fce4c071
ВМ
72542019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7255
7256 PR gdb/24351
7257 * windows-nat.c (display_selector): Fix format specifiers.
7258
f7f0a123
EZ
72592019-03-17 Eli Zaretskii <eliz@gnu.org>
7260
7261 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7262 tui_refill_source_window instead of tui_refresh_win, to update the
7263 current execution line. This fixes redisplay of the current line
7264 when stepping through the code with "next" or "step".
7265
ab42892f
EZ
72662019-03-16 Eli Zaretskii <eliz@gnu.org>
7267
7268 * source-cache.c (source_cache::get_source_lines): Call
7269 find_source_lines to initialize s->nlines. This fixes vertical
7270 scrolling of TUI source window when the DOWN arrow is pressed.
7271
8d8c087f
PW
72722019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7273
7274 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7275 linux-thread-db.c (_initialize_thread_db): Likewise.
7276
798e1c30
EZ
72772019-03-16 Eli Zaretskii <eliz@gnu.org>
7278
7279 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7280 wclrtoeol in tui_show_source_line". This reverts changes made in
7281 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7282
eefba3da
TT
72832019-03-15 Tom Tromey <tom@tromey.com>
7284
7285 * symtab.h (struct minimal_symbol): Derive from
7286 general_symbol_info.
7287 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7288 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7289 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7290 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7291 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7292 (MSYMBOL_SEARCH_NAME): Update.
7293 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7294 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7295 * minsyms.c (minimal_symbol_reader::record_full): Update.
7296
0de2420c
TT
72972019-03-15 Tom Tromey <tom@tromey.com>
7298
7299 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7300
042d75e4
TT
73012019-03-15 Tom Tromey <tom@tromey.com>
7302
7303 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7304 unique_xmalloc_ptr.
7305 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7306 Update.
7307 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7308 (build_minimal_symbol_hash_tables)
7309 (minimal_symbol_reader::install): Update.
7310
db92718b
TT
73112019-03-15 Tom Tromey <tom@tromey.com>
7312
7313 * symtab.c (create_demangled_names_hash): Update.
7314 (symbol_set_names): Update.
7315 * objfiles.h (struct objfile_per_bfd_storage)
7316 <demangled_names_hash>: Now an htab_up.
7317 * objfiles.c (objfile_per_bfd_storage): Simplify.
7318
d6797f46
TT
73192019-03-15 Tom Tromey <tom@tromey.com>
7320
7321 * objfiles.h (struct objfile_per_bfd_storage): Declare
7322 destructor.
7323 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7324 New.
7325 (get_objfile_bfd_data): Use new. Don't initialize
7326 language_of_main.
7327 (free_objfile_per_bfd_storage): Remove.
7328 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7329
741d7538
TT
73302019-03-15 Tom Tromey <tom@tromey.com>
7331
7332 * symfile.c (reread_symbols): Update.
7333 * objfiles.c (objfile::objfile): Update.
7334 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7335 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7336 comment.
7337 (minimal_symbol_reader::install): Update.
7338 (terminate_minimal_symbol_table): Remove.
7339 * jit.c (jit_object_close_impl): Update.
7340
788c80d1
TT
73412019-03-15 Tom Tromey <tom@tromey.com>
7342
7343 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7344 initializations.
7345
1b7a07cb
TT
73462019-03-15 Tom Tromey <tom@tromey.com>
7347
7348 * objfiles.h (struct objfile_per_bfd_storage)
7349 <demangled_hash_languages>: Now a bitset.
7350 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7351 (lookup_minimal_symbol): Update.
7352
3db066bc
TT
73532019-03-15 Tom Tromey <tom@tromey.com>
7354
7355 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7356 Don't return the symbol.
7357 * coffread.c (record_minimal_symbol): Use record_full.
7358
3fff2c37
EZ
73592019-03-14 Eli Zaretskii <eliz@gnu.org>
7360
7361 The MS-Windows port of ncurses fails to switch to a color pair if
7362 one or both of the colors are the implicit default colors. This
7363 change records the default colors when TUI is initialized, and
7364 then specifies them explicitly when a color pair uses the default
7365 colors. This allows color styling in TUI mode on MS-Windows.
7366
7367 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7368 ncurses_norm_attr.
7369 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7370 colors in ncurses_norm_attr.
7371 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7372 "none", replace it with the default color recorded in
7373 ncurses_norm_attr.
7374
3b336828
TT
73752019-03-14 Tom Tromey <tromey@adacore.com>
7376
7377 * source-cache.h (class source_cache) <get_source_lines>: Return
7378 std::string.
7379 * source-cache.c (source_cache::extract_lines): Handle case where
7380 first_pos==npos. Return std::string.
7381 (source_cache::get_source_lines): Update.
7382
d085f989
TT
73832019-03-14 Tom Tromey <tromey@adacore.com>
7384
7385 * NEWS: Add item for "style sources" commands.
7386 * source-cache.c (source_cache::get_source_lines): Check
7387 source_styling.
7388 * cli/cli-style.c (source_styling): New global.
7389 (_initialize_cli_style): Add "style sources" commands.
7390 (show_style_sources): New function.
7391 * cli/cli-style.h (source_styling): Declare.
7392
6f11e682
TT
73932019-03-14 Pedro Alves <palves@redhat.com>
7394 Tom Tromey <tromey@adacore.com>
7395
7396 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7397 * tui/tui-winsource.c (tui_refill_source_window): New function,
7398 from...
7399 (tui_horizontal_source_scroll): ... here. Move some logic.
7400 * cli/cli-style.c (set_style_enabled): Notify new observable.
7401 * tui/tui-hooks.c (tui_redisplay_source): New function.
7402 (tui_attach_detach_observers): Attach or detach
7403 tui_redisplay_source.
7404 * observable.h (source_styling_changed): New observable.
7405 * observable.c: Define source_styling_changed observable.
7406
a068643d
TT
74072019-03-13 Tom Tromey <tromey@adacore.com>
7408
7409 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7410 (i386_gnu_nat_target::store_registers): Update.
7411 * target-debug.h (target_debug_print_std_string): New macro.
7412 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7413 * windows-tdep.c (display_one_tib): Update.
7414 * tui/tui-stack.c (tui_make_status_line): Update.
7415 * top.c (print_inferior_quit_action): Update.
7416 * thread.c (thr_try_catch_cmd): Update.
7417 (add_thread_with_info): Update.
7418 (thread_target_id_str): Update.
7419 (thr_try_catch_cmd): Update.
7420 (thread_command): Update.
7421 (thread_find_command): Update.
7422 * record-btrace.c (record_btrace_target::info_record)
7423 (record_btrace_resume_thread, record_btrace_target::resume)
7424 (record_btrace_cancel_resume, record_btrace_step_thread)
7425 (record_btrace_target::wait, record_btrace_target::wait)
7426 (record_btrace_target::wait, record_btrace_target::stop): Update.
7427 * progspace.c (print_program_space): Update.
7428 * process-stratum-target.c
7429 (process_stratum_target::thread_address_space): Update.
7430 * linux-fork.c (linux_fork_mourn_inferior)
7431 (detach_checkpoint_command, info_checkpoints_command)
7432 (linux_fork_context): Update.
7433 (linux_fork_detach): Update.
7434 (class scoped_switch_fork_info): Update.
7435 (delete_checkpoint_command): Update.
7436 * infrun.c (follow_fork_inferior): Update.
7437 (follow_fork_inferior): Update.
7438 (proceed_after_vfork_done): Update.
7439 (handle_vfork_child_exec_or_exit): Update.
7440 (follow_exec): Update.
7441 (displaced_step_prepare_throw): Update.
7442 (displaced_step_restore): Update.
7443 (start_step_over): Update.
7444 (resume_1): Update.
7445 (clear_proceed_status_thread): Update.
7446 (proceed): Update.
7447 (print_target_wait_results): Update.
7448 (do_target_wait): Update.
7449 (context_switch): Update.
7450 (stop_all_threads): Update.
7451 (restart_threads): Update.
7452 (finish_step_over): Update.
7453 (handle_signal_stop): Update.
7454 (switch_back_to_stepped_thread): Update.
7455 (keep_going_pass_signal): Update.
7456 (print_exited_reason): Update.
7457 (normal_stop): Update.
7458 * inferior.c (inferior_pid_to_str): Change return type.
7459 (print_selected_inferior): Update.
7460 (add_inferior): Update.
7461 (detach_inferior): Update.
7462 * dummy-frame.c (fprint_dummy_frames): Update.
7463 * dcache.c (dcache_info_1): Update.
7464 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7465 (btrace_fetch, btrace_clear): Update.
7466 * linux-tdep.c (linux_core_pid_to_str): Change return type.
7467 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7468 type.
7469 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7470 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7471 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7472 * gdbarch.c, gdbarch.h: Rebuild.
7473 * gdbarch.sh (core_pid_to_str): Change return type.
7474 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7475 return type.
7476 (windows_nat_target::pid_to_str): Change return type.
7477 (windows_delete_thread): Update.
7478 (windows_nat_target::attach): Update.
7479 (windows_nat_target::files_info): Update.
7480 * target-delegates.c: Rebuild.
7481 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7482 return type.
7483 (sol_thread_target::pid_to_str): Change return type.
7484 * remote.c (class remote_target) <pid_to_str>: Change return
7485 type.
7486 (remote_target::pid_to_str): Change return type.
7487 (extended_remote_target::attach, remote_target::remote_stop_ns)
7488 (remote_target::remote_notif_remove_queued_reply)
7489 (remote_target::push_stop_reply, remote_target::disable_btrace):
7490 Update.
7491 (extended_remote_target::attach): Update.
7492 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7493 type.
7494 (gdbsim_target::pid_to_str): Change return type.
7495 * ravenscar-thread.c (struct ravenscar_thread_target)
7496 <pid_to_str>: Change return type.
7497 (ravenscar_thread_target::pid_to_str): Change return type.
7498 * procfs.c (class procfs_target) <pid_to_str>: Change return
7499 type.
7500 (procfs_target::pid_to_str): Change return type.
7501 (procfs_target::attach): Update.
7502 (procfs_target::detach): Update.
7503 (procfs_target::fetch_registers): Update.
7504 (procfs_target::store_registers): Update.
7505 (procfs_target::wait): Update.
7506 (procfs_target::files_info): Update.
7507 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7508 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7509 return type.
7510 (nto_procfs_target::pid_to_str): Change return type.
7511 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7512 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7513 return type.
7514 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7515 (exit_lwp): Update.
7516 (attach_proc_task_lwp_callback, get_detach_signal)
7517 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7518 (linux_nat_target::resume, wait_lwp, stop_callback)
7519 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7520 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7521 (linux_nat_wait_1, resume_stopped_resumed_lwps)
7522 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7523 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7524 type.
7525 (inf_ptrace_target::attach): Update.
7526 (inf_ptrace_target::files_info): Update.
7527 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7528 type.
7529 (go32_nat_target::pid_to_str): Change return type.
7530 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7531 (gnu_nat_target::wait): Update.
7532 (gnu_nat_target::wait): Update.
7533 (gnu_nat_target::resume): Update.
7534 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7535 (fbsd_nat_target::wait): Update.
7536 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7537 type.
7538 (darwin_nat_target::attach): Update.
7539 * corelow.c (class core_target) <pid_to_str>: Change return type.
7540 (core_target::pid_to_str): Change return type.
7541 * target.c (normal_pid_to_str): Change return type.
7542 (default_pid_to_str): Likewise.
7543 (target_pid_to_str): Change return type.
7544 (target_translate_tls_address): Update.
7545 (target_announce_detach): Update.
7546 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7547 return type.
7548 (bsd_uthread_target::pid_to_str): Change return type.
7549 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7550 type.
7551 (bsd_kvm_target::pid_to_str): Change return type.
7552 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7553 return type.
7554 (aix_thread_target::pid_to_str): Change return type.
7555 * target.h (struct target_ops) <pid_to_str>: Change return type.
7556 (target_pid_to_str, normal_pid_to_str): Likewise.
7557 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7558 type.
7559 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7560 type.
7561 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7562 return type.
7563 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7564 type.
7565 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7566 type.
7567 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7568 return type.
7569
b4be1b06
SM
75702019-03-13 Simon Marchi <simon.marchi@ericsson.com>
7571
7572 * NEWS: Mention that the new default MI version is 3. Mention
7573 changes to the output of commands and events that deal with
7574 multi-location breakpoints.
7575 * breakpoint.c: Include "mi/mi-out.h".
7576 (print_one_breakpoint): Change output syntax if using MI version
7577 >= 3.
7578 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7579 New.
7580 (mi_multi_location_breakpoint_output_fixed): New.
7581 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7582 (mi_cmd_fix_multi_location_breakpoint_output): New.
7583 (mi_multi_location_breakpoint_output_fixed): New.
7584 * mi/mi-cmds.c (mi_cmds): Register command
7585 -fix-multi-location-breakpoint-output.
7586 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7587 interpreter "mi".
7588
8e5e5494
SM
75892019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
7590
7591 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7592 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7593 instantiate mi_ui_out based on interpreter name.
7594 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7595 * mi/mi-main.c (mi_load_progress): Likewise.
7596
197df35e
JB
75972019-03-12 John Baldwin <jhb@FreeBSD.org>
7598
7599 * NEWS: Combine separate "New targets" sections for 8.3.
7600
8399425f
JB
76012019-03-12 John Baldwin <jhb@FreeBSD.org>
7602
7603 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7604 (ppcfbsd_init_abi): Install gdbarch
7605 "fetch_tls_load_module_address" and "get_thread_local_address"
7606 methods.
7607
b0f87ed0
JB
76082019-03-12 John Baldwin <jhb@FreeBSD.org>
7609
7610 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7611 (riscv_fbsd_init_abi): Install gdbarch
7612 "fetch_tls_load_module_address" and "get_thread_local_address"
7613 methods.
7614
ce25aa57
JB
76152019-03-12 John Baldwin <jhb@FreeBSD.org>
7616
7617 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7618 (i386fbsd_init_abi): Install gdbarch
7619 "fetch_tls_load_module_address" and "get_thread_local_address"
7620 methods.
7621
f5424cfa
JB
76222019-03-12 John Baldwin <jhb@FreeBSD.org>
7623
7624 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7625 (amd64fbsd_init_abi): Install gdbarch
7626 "fetch_tls_load_module_address" and "get_thread_local_address"
7627 methods.
7628
945f3901
JB
76292019-03-12 John Baldwin <jhb@FreeBSD.org>
7630
7631 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7632 (struct fbsd_pspace_data): New type.
7633 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7634 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7635 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7636 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7637 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7638
ef0bd204
JB
76392019-03-12 John Baldwin <jhb@FreeBSD.org>
7640
7641 * gdbtypes.c (lookup_struct_elt): New function.
7642 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7643 * gdbtypes.h (struct struct_elt): New type.
7644 (lookup_struct_elt): New prototype.
7645
36c53a02
JB
76462019-03-12 John Baldwin <jhb@FreeBSD.org>
7647
7648 * gdbtypes.c (lookup_struct_elt_type): Update comment and
7649 remove disabled code block.
7650
6e056c81
JB
76512019-03-12 John Baldwin <jhb@FreeBSD.org>
7652
7653 * gdbarch.sh (get_thread_local_address): New method.
7654 * gdbarch.h, gdbarch.c: Regenerate.
7655 * target.c (target_translate_tls_address): Use
7656 gdbarch_get_thread_local_address if present instead of
7657 target::get_thread_local_address.
7658
cd250a18
JB
76592019-03-12 John Baldwin <jhb@FreeBSD.org>
7660
7661 * target.h (target::get_thread_local_address): Update comment.
7662
df22c1e5
JB
76632019-03-12 John Baldwin <jhb@FreeBSD.org>
7664
7665 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7666 objfile->separate_debug_objfile_backlink if not NULL.
7667
dd6876c9
JB
76682019-03-12 John Baldwin <jhb@FreeBSD.org>
7669
7670 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7671 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7672 (amd64bsd_store_inferior_registers): Likewise.
7673 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7674 Enable segment base registers.
7675 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7676 PT_GETFSBASE and PT_GETGSBASE.
7677 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7678 PT_SETGSBASE.
7679 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7680 segment base registers.
7681 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7682
1163a4b7
JB
76832019-03-12 John Baldwin <jhb@FreeBSD.org>
7684
7685 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7686 Update calls to i386_target_description to add 'segments'
7687 parameter.
7688 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
7689 add segment base registers.
7690 * arch/i386.c (i386_create_target_description): Add 'segments'
7691 parameter to enable segment base registers.
7692 * arch/i386.h (i386_create_target_description): Likewise.
7693 * features/i386/32bit-segments.xml: New file.
7694 * features/i386/32bit-segments.c: Generate.
7695 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7696 call to i386_target_description to add 'segments' parameter.
7697 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7698 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7699 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7700 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7701 if feature is present.
7702 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7703 Add 'segments' parameter to call to i386_target_description.
7704 (i386_target_description): Add 'segments' parameter to enable
7705 segment base registers.
7706 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7707 to call to i386_target_description.
7708 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7709 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7710 Define I386_NUM_REGS.
7711 (i386_target_description): Add 'segments' parameter to enable
7712 segment base registers.
7713
3a350822
EZ
77142019-03-12 Eli Zaretskii <eliz@gnu.org>
7715
7716 PR/24325
7717 * source-cache.c: #undef open and close, to avoid unresolved
7718 externals during linking.
7719
ffdd69cf
TT
77202019-03-12 Tom Tromey <tromey@adacore.com>
7721
7722 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7723 const. Add initializers.
7724 (_initialize_remote): Don't initialize ptid globals.
7725
ec148c57
PA
77262019-03-12 Pedro Alves <palves@redhat.com>
7727
7728 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7729
32764270
PA
77302019-03-12 Pedro Alves <palves@redhat.com>
7731
7732 * cp-name-parser.y (main): Remove unused 'len' variable.
7733
17547186
TT
77342019-03-12 Tom Tromey <tromey@adacore.com>
7735
7736 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7737 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7738
d3a70e03
TT
77392019-03-12 Tom Tromey <tromey@adacore.com>
7740
7741 * linux-nat.c (iterate_over_lwps): Update.
7742 (stop_callback): Remove parameter.
7743 (stop_wait_callback, detach_callback, resume_set_callback)
7744 (select_singlestep_lwp_callback, set_ignore_sigint)
7745 (status_callback, resumed_callback, resume_clear_callback)
7746 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7747 data parameter.
7748 (linux_nat_target::detach, linux_nat_target::resume)
7749 (linux_stop_and_wait_all_lwps, select_event_lwp)
7750 (linux_nat_filter_event, linux_nat_wait_1)
7751 (linux_nat_target::kill, linux_nat_target::stop)
7752 (linux_nat_target::stop): Update.
7753 (linux_nat_resume_callback): Change type.
7754 (resume_stopped_resumed_lwps, count_events_callback)
7755 (select_event_lwp_callback): Likewise.
7756 (linux_stop_lwp, linux_nat_stop_lwp): Update.
7757 * arm-linux-nat.c (struct update_registers_data): Remove.
7758 (update_registers_callback): Change type.
7759 (arm_linux_insert_hw_breakpoint1): Update.
7760 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7761 parameter.
7762 (x86_linux_dr_set_addr): Update.
7763 (x86_linux_dr_set_control): Update.
7764 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7765 (iterate_over_lwps): Use gdb::function_view.
7766 * nat/aarch64-linux-hw-point.c (struct
7767 aarch64_dr_update_callback_param): Remove.
7768 (debug_reg_change_callback): Change type.
7769 (aarch64_notify_debug_reg_change): Update.
7770 * s390-linux-nat.c (s390_refresh_per_info): Update.
7771
82cb27ff
TT
77722019-03-11 Tom Tromey <tromey@adacore.com>
7773
7774 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7775 redundant assignment to "this_cu".
7776
568c0683
SM
77772019-03-08 Simon Marchi <simon.marchi@efficios.com>
7778
7779 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7780
f09ce22d
SM
77812019-03-08 Simon Marchi <simon.marchi@efficios.com>
7782
7783 * gdbtypes.c (rank_one_type_parm_set): New function extracted
7784 from...
7785 (rank_one_type): ... this.
7786
595f96a9
SM
77872019-03-08 Simon Marchi <simon.marchi@efficios.com>
7788
7789 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7790 from...
7791 (rank_one_type): ... this.
7792
2598a94b
SM
77932019-03-08 Simon Marchi <simon.marchi@efficios.com>
7794
7795 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7796 from...
7797 (rank_one_type): ... this.
7798
7f17b20d
SM
77992019-03-08 Simon Marchi <simon.marchi@efficios.com>
7800
7801 * gdbtypes.c (rank_one_type_parm_float): New function extracted
7802 from...
7803 (rank_one_type): ... this.
7804
2c509035
SM
78052019-03-08 Simon Marchi <simon.marchi@efficios.com>
7806
7807 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7808 from...
7809 (rank_one_type): ... this.
7810
0dd322dc
SM
78112019-03-08 Simon Marchi <simon.marchi@efficios.com>
7812
7813 * gdbtypes.c (rank_one_type_parm_range): New function extracted
7814 from...
7815 (rank_one_type): ... this.
7816
41ea4728
SM
78172019-03-08 Simon Marchi <simon.marchi@efficios.com>
7818
7819 * gdbtypes.c (rank_one_type_parm_char): New function extracted
7820 from...
7821 (rank_one_type): ... this.
7822
793cd1d2
SM
78232019-03-08 Simon Marchi <simon.marchi@efficios.com>
7824
7825 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7826 from...
7827 (rank_one_type): ... this.
7828
34910087
SM
78292019-03-08 Simon Marchi <simon.marchi@efficios.com>
7830
7831 * gdbtypes.c (rank_one_type_parm_int): New function extracted
7832 from...
7833 (rank_one_type): ... this.
7834
f1f832d6
SM
78352019-03-08 Simon Marchi <simon.marchi@efficios.com>
7836
7837 * gdbtypes.c (rank_one_type_parm_func): New function extracted
7838 from...
7839 (rank_one_type): ... this.
7840
b9f4512f
SM
78412019-03-08 Simon Marchi <simon.marchi@efficios.com>
7842
7843 * gdbtypes.c (rank_one_type_parm_array): New function extracted
7844 from...
7845 (rank_one_type): ... this.
7846
9293fc63
SM
78472019-03-08 Simon Marchi <simon.marchi@efficios.com>
7848
7849 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7850 from...
7851 (rank_one_type): ... this.
7852
e3abbe7e
PW
78532019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7854
7855 * inferior.c (initialize_inferiors): Ensure 'help set/show print
7856 inferior-events' shows the example events.
7857
e4adb939
EZ
78582019-03-08 Eli Zaretskii <eliz@gnu.org>
7859
7860 Support styling on native MS-Windows console
7861
7862 PR/24315
7863 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7864 on MS-Windows if $TERM is not defined.
7865
7866 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7867
7868 * posix-hdep.c (gdb_console_fputs):
7869 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7870 functions.
7871 * ui-file.h (gdb_console_fputs): Add prototype.
7872
7873 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7874 back to fputs only if the former returns zero.
7875
25629dfd
TT
78762019-03-07 Tom Tromey <tom@tromey.com>
7877
7878 * symmisc.c (print_symbol_bcache_statistics): Update.
7879 (print_objfile_statistics): Update.
7880 * symfile.c (allocate_symtab): Update.
7881 * stabsread.c: Don't include bcache.h.
7882 * psymtab.h (struct psymbol_bcache): Don't declare.
7883 (class psymtab_storage) <psymbol_cache>: Now a bcache.
7884 (psymbol_bcache_init, psymbol_bcache_free)
7885 (psymbol_bcache_get_bcache): Don't declare.
7886 * psymtab.c (struct psymbol_bcache): Remove.
7887 (psymtab_storage::psymtab_storage): Update.
7888 (psymtab_storage::~psymtab_storage): Update.
7889 (psymbol_bcache_init, psymbol_bcache_free)
7890 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7891 (add_psymbol_to_bcache): Update.
7892 (allocate_psymtab): Update.
7893 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7894 macro_cache>: No longer pointers.
7895 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7896 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7897 * macrotab.c (macro_bcache): Update.
7898 * macroexp.c: Don't include bcache.h.
7899 * gdbtypes.c (check_types_worklist): Update.
7900 (types_deeply_equal): Remove TRY/CATCH. Update.
7901 * elfread.c (elf_symtab_read): Update.
7902 * dwarf2read.c: Don't include bcache.h.
7903 * buildsym.c (buildsym_compunit::get_macro_table): Update.
7904 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7905 (print_bcache_statistics, bcache_memory_used): Don't declare.
7906 (struct bcache): Move from bcache.c. Add constructor, destructor,
7907 methods. Rename all data members.
7908 * bcache.c (struct bcache): Move to bcache.h.
7909 (bcache::expand_hash_table): Rename from expand_hash_table.
7910 (bcache): Remove.
7911 (bcache::insert): Rename from bcache_full.
7912 (bcache::compare): Rename from bcache_compare.
7913 (bcache_xmalloc): Remove.
7914 (bcache::~bcache): Rename from bcache_xfree.
7915 (bcache::print_statistics): Rename from print_bcache_statistics.
7916 (bcache::memory_used): Rename from bcache_memory_used.
7917
fe726667
PA
79182019-03-07 Pedro Alves <palves@redhat.com>
7919
7920 * infrun.c (normal_stop): Also check for
7921 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7922
7584bb30
AB
79232019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
7924
7925 * f-lang.c (value_from_host_double): Moved to...
7926 * value.c (value_from_host_double): ...here.
7927 * value.h (value_from_host_double): Declare.
7928 * guile/scm-math.c (vlscm_convert_typed_number): Use
7929 value_from_host_double.
7930 (vlscm_convert_number): Likewise.
7931 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7932 * python/py-value.c (convert_value_from_python): Likewise.
7933
a7b1986e
TT
79342019-03-06 Tom Tromey <tom@tromey.com>
7935
7936 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7937
0ccf4211
TT
79382019-03-06 Tom Tromey <tom@tromey.com>
7939
7940 * utils.h (free_current_contents): Don't declare.
7941 * utils.c (free_current_contents): Remove.
7942
fe7b42e5
TT
79432019-03-06 Tom Tromey <tom@tromey.com>
7944
7945 * top.c (quit_force): Update.
7946 * main.c (captured_command_loop): Update.
7947 * common/new-op.c (operator new): Update.
7948 * common/common-exceptions.c (struct catcher)
7949 <save_cleanup_chain>: Remove member.
7950 (exceptions_state_mc_init): Update.
7951 (exception_try_scope_entry): Return nullptr.
7952 (exception_try_scope_exit, exception_rethrow)
7953 (throw_exception_sjlj, throw_exception_cxx): Update.
7954 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7955 (all_cleanups, do_cleanups, discard_cleanups)
7956 (discard_final_cleanups, save_cleanups, save_final_cleanups)
7957 (restore_cleanups, restore_final_cleanups): Don't declare.
7958 (do_final_cleanups): Remove parameter.
7959 * common/cleanups.c (cleanup_chain, make_cleanup)
7960 (make_cleanup_dtor, all_cleanups, do_cleanups)
7961 (discard_my_cleanups, discard_cleanups)
7962 (discard_final_cleanups, save_my_cleanups, save_cleanups)
7963 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7964 (null_cleanup): Remove.
7965 (do_final_cleanups): Remove parameter.
7966
c6321f19
TT
79672019-03-06 Tom Tromey <tom@tromey.com>
7968
7969 * remote.c (remote_target::remote_parse_stop_reply): Use
7970 unique_xmalloc_ptr.
7971
61b30099
TT
79722019-03-06 Tom Tromey <tom@tromey.com>
7973
7974 * stabsread.c (struct stabs_field_info): Rename from field_info.
7975 <list, fnlist>: Add initializers.
7976 <obstack>: New member.
7977 (read_member_functions, read_struct_fields, read_baseclasses):
7978 Allocate on obstack. Don't use cleanups.
7979 (read_one_struct_field, read_member_functions, read_struct_fields)
7980 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7981 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7982 (read_struct_type): Update.
7983
6cceac94
TT
79842019-03-06 Tom Tromey <tom@tromey.com>
7985
7986 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7987 * common/filestuff.h (make_cleanup_close): Don't declare.
7988 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7989 Remove.
7990
72412762
TT
79912019-03-06 Tom Tromey <tom@tromey.com>
7992
7993 * solib-aix.c: Use make_scope_exit.
7994
2b6ff1c0
TT
79952019-03-06 Tom Tromey <tom@tromey.com>
7996
7997 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7998 Use make_scope_exit.
7999
d01c5877
TT
80002019-03-06 Tom Tromey <tom@tromey.com>
8001
8002 * solib-svr4.c (disable_probes_interface): Remove parameter.
8003 (svr4_handle_solib_event): Use make_scope_exit.
8004
32603266
TT
80052019-03-06 Tom Tromey <tom@tromey.com>
8006
8007 * remote.c (struct stop_reply_deleter): Remove.
8008 (stop_reply_up): Update.
8009 (struct stop_reply): Derive from notif_event. Don't typedef.
8010 <regcache>: Now a std::vector.
8011 (stop_reply_xfree): Remove.
8012 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8013 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8014 (remote_target::discard_pending_stop_replies): Use delete.
8015 (remote_target::remote_parse_stop_reply): Update.
8016 (remote_target::process_stop_reply): Update.
8017 * remote-notif.h (struct notif_event): Add virtual destructor.
8018 Remove "dtr" member.
8019 (struct notif_client) <alloc_event>: Return a unique_ptr.
8020 (notif_event_xfree): Don't declare.
8021 (notif_event_up): New typedef.
8022 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8023 (notif_event_xfree, do_notif_event_xfree): Remove.
8024 (remote_notif_state_xfree): Update.
8025
9799571e
TT
80262019-03-06 Tom Tromey <tom@tromey.com>
8027
8028 * infrun.c (displaced_step_clear_cleanup): Now a
8029 forward_scope_exit type.
8030 (displaced_step_prepare_throw): Update.
8031 (displaced_step_fixup): Update.
8032
09e3c4ca
TT
80332019-03-06 Tom Tromey <tom@tromey.com>
8034
8035 * inferior.h (class inferior): Update comment.
8036 * gdbthread.h (class thread_info): Update comment.
8037
e2a03548
TT
80382019-03-06 Joel Brobecker <brobecker@adacore.com>
8039 Tom Tromey <tom@tromey.com>
8040
8041 * stabsread.h (struct stab_section_list): Remove.
8042 (coffstab_build_psymtabs): Update.
8043 * dbxread.c (symbuf_sections): Now a std::vector.
8044 (sect_idx): New global.
8045 (fill_symbuf): Update.
8046 (coffstab_build_psymtabs): Change type of stabsects parameter.
8047 Update.
8048 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8049 std::vector.
8050 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8051 (coff_locate_sections): Update.
8052 (coff_symfile_read): Remove cleanups. Update.
8053 (init_stringtab): Add storage parameter.
8054 (free_stringtab, free_stringtab_cleanup): Remove.
8055 (init_lineno): Add storage parameter.
8056 (free_linetab, free_linetab_cleanup): Remove.
8057
b7e60d85
PA
80582019-03-06 Pedro Alves <palves@redhat.com>
8059
8060 * linux-fork.c (fork_info::clobber_regs): Delete.
8061 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8062 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8063 comment. Adjust.
8064 (scoped_switch_fork_info::scoped_switch_fork_info)
8065 (checkpoint_command, linux_fork_context): Adjust
8066 fork_save_infrun_state calls.
8067
e52c971f
PA
80682019-03-06 Pedro Alves <palves@redhat.com>
8069
8070 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8071 (inf_has_multiple_threads): Return 'bool' and rewrite using
8072 inferior_info::threads().
8073
06974e6c
PA
80742019-03-06 Pedro Alves <palves@redhat.com>
8075
8076 * linux-fork.c: Include <list>.
8077 (fork_list): Now a std::list instance.
8078 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8079 (forks_exist_p, find_last_fork): Adjust.
8080 (new_fork): Delete.
8081 (one_fork_p): New.
8082 (add_fork): Adjust.
8083 (free_fork): Delete, folded into fork_info::~fork_info().
8084 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8085 Adjust.
8086 (init_fork_list): Delete.
8087 (linux_fork_killall, linux_fork_mourn_inferior)
8088 (linux_fork_detach, info_checkpoints_command): Adjust.
8089 (_initialize_linux_fork): No longer call init_fork_list.
8090
72f31aea
PA
80912019-03-06 Pedro Alves <palves@redhat.com>
8092
8093 * linux-fork.c (new_fork): New, split out of ...
8094 (add_fork): ... this. Return void. Move "first fork" special
8095 case from here, to ...
8096 (checkpoint_command): ... here.
8097 * linux-linux.h (add_fork): Return void.
8098
efbecbc1
AB
80992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8100
8101 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8102
0841c79a
AB
81032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8104 Chris January <chris.january@arm.com>
8105 David Lecomber <david.lecomber@arm.com>
8106
8107 * f-exp.y: New token, UNOP_INTRINSIC.
8108 (exp): New pattern using UNOP_INTRINSIC token.
8109 (f77_keywords): Add 'abs' keyword.
8110 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8111 (value_from_host_double): New function.
8112 (evaluate_subexp_f): Support UNOP_ABS.
8113
4a270568
AB
81142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8115
8116 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8117 types.
8118
067630bd
AB
81192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8120
8121 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8122 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8123 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8124
3be47f7a
AB
81252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8126
8127 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8128
4d00f5d8
AB
81292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8130 Chris January <chris.january@arm.com>
8131
8132 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8133 * f-exp.y: Define 'KIND' token.
8134 (exp): New pattern for KIND expressions.
8135 (ptype): Handle types with a kind extension.
8136 (direct_abs_decl): Extend to spot kind extensions.
8137 (f77_keywords): Add 'kind' to the list.
8138 (push_kind_type): New function.
8139 (convert_to_kind_type): New function.
8140 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8141 * parse.c (operator_length_standard): Likewise.
8142 * parser-defs.h (enum type_pieces): Add tp_kind.
8143 * std-operator.def: Add UNOP_KIND.
8144
e454224f
AB
81452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8146
8147 * f-exp.y (f_parse): Set yydebug.
8148
9dad4a58
AB
81492019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8150
8151 * f-lang.c (evaluate_subexp_f): New function.
8152 (exp_descriptor_f): New global.
8153 (f_language_defn): Use exp_descriptor_f instead of
8154 exp_descriptor_standard.
8155
c8f91604
AB
81562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8157
8158 * f-exp.y (struct token): Add comments.
8159 (dot_ops): Remove uppercase versions and the end marker.
8160 (f77_keywords): Likewise.
8161 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8162 entries in the dot_ops array are case insensitive, and use
8163 strncasecmp to compare strings. Also some whitespace cleanup in
8164 this area. Similar for the f77_keywords array, except entries in
8165 this list might be case sensitive.
8166
dd9f2c76
AB
81672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8168
8169 * f-exp.y (struct f77_boolean_val): Add comments.
8170 (boolean_values): Remove uppercase versions, and end marker.
8171 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8172 and use strncasecmp to achieve case insensitivity. Additionally,
8173 perform whitespace cleanup around this code.
8174
67a3048c
TT
81752019-03-06 Tom Tromey <tromey@adacore.com>
8176
8177 * remote-sim.c (gdbsim_target_open): Use result of
8178 gdb_argv::release.
8179
aa3cfbda
RB
81802019-03-06 Richard Bunt <richard.bunt@arm.com>
8181 Dirk Schubert <dirk.schubert@arm.com>
8182 Chris January <chris.january@arm.com>
8183
8184 * eval.c (evaluate_subexp_standard): Call Fortran argument
8185 wrapping logic.
8186 * f-lang.c (struct value): A value which can be passed into a
8187 Fortran function call.
8188 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8189 where appropriate.
8190 (struct type): Value ready for a Fortran function call.
8191 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8192 is needed.
8193 * f-lang.h (fortran_argument_convert): Declaration.
8194 (fortran_preserve_arg_pointer): Declaration.
8195 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8196
ea38e5df
TT
81972019-03-05 Tom Tromey <tromey@adacore.com>
8198
8199 * python/py-prettyprint.c (print_string_repr): Remove #if.
8200 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8201
06b5b831
TT
82022019-03-05 Tom Tromey <tromey@adacore.com>
8203
8204 * target.c (the_dummy_target): Move later. Change type to
8205 "dummy_target".
8206 (initialize_targets): Don't initialize the_dummy_target.
8207
edbd9e45
TT
82082019-03-05 Tom Tromey <tromey@adacore.com>
8209
8210 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8211 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8212
c119e040
TT
82132019-03-05 Tom Tromey <tromey@adacore.com>
8214
8215 * windows-nat.c (windows_nat_target::attach)
8216 (windows_nat_target::detach): Don't call gdb_flush.
8217 * valprint.c (generic_val_print, val_print, val_print_string):
8218 Don't call gdb_flush.
8219 * utils.c (defaulted_query): Don't call gdb_flush.
8220 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8221 * target.c (target_announce_detach): Don't call gdb_flush.
8222 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8223 * remote.c (extended_remote_target::attach): Don't call
8224 gdb_flush.
8225 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8226 * printcmd.c (do_examine): Don't call gdb_flush.
8227 (info_display_command): Don't call gdb_flush.
8228 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8229 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8230 * memattr.c (info_mem_command): Don't call gdb_flush.
8231 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8232 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8233 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8234 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8235 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8236 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8237 (gnu_nat_target::detach): Don't call gdb_flush.
8238 * f-valprint.c (f_val_print): Don't call gdb_flush.
8239 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8240 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8241 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8242 gdb_flush.
8243 * c-valprint.c (c_val_print): Don't call gdb_flush.
8244 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8245
895dafa6
TT
82462019-03-05 Tom Tromey <tromey@adacore.com>
8247
8248 * varobj.c (update_dynamic_varobj_children): Update.
8249 (install_default_visualizer): Use reset, not release.
8250 * value.c (set_internalvar): Update.
8251 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8252 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8253 ATTRIBUTE_UNUSED_RESULT.
8254
88a774b9
TT
82552019-03-05 Tom Tromey <tromey@adacore.com>
8256
8257 * remote.c (class scoped_remote_fd) <release>: Add
8258 ATTRIBUTE_UNUSED_RESULT.
8259
4e4a8b93
TT
82602019-03-05 Tom Tromey <tromey@adacore.com>
8261
8262 * macroexp.c (struct macro_buffer) <release>: Add
8263 ATTRIBUTE_UNUSED_RESULT.
8264
083eef1f
TT
82652019-03-05 Tom Tromey <tromey@adacore.com>
8266
8267 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8268 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8269 ATTRIBUTE_UNUSED_RESULT.
8270
3cabd438
TT
82712019-03-05 Tom Tromey <tromey@adacore.com>
8272
8273 * common/scoped_fd.h (class scoped_fd) <release>: Add
8274 ATTRIBUTE_UNUSED_RESULT.
8275
41e3300a
TT
82762019-03-05 Tom Tromey <tromey@adacore.com>
8277
8278 * parser-defs.h (struct parser_state) <release>: Add
8279 ATTRIBUTE_UNUSED_RESULT.
8280
18cb7c9f
TT
82812019-03-05 Tom Tromey <tromey@adacore.com>
8282
8283 * utils.h (class gdb_argv) <release>: Add
8284 ATTRIBUTE_UNUSED_RESULT.
8285 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8286
41fa577f
EZ
82872019-03-02 Eli Zaretskii <eliz@gnu.org>
8288
a6a4b2c6
EZ
8289 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8290 for-loop range, to avoid compiler warnings.
8291
8292 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8293 avoid compiler warnings about unused variables.
8294
742a7df5
EZ
8295 * NEWS: Mention end of support for native debugging on MS-Windows
8296 before XP.
8297
41fa577f
EZ
8298 PR gdb/24292
8299 * common/netstuff.c:
8300 * gdbserver/gdbreplay.c
8301 * gdbserver/remote-utils.c:
8302 * ser-tcp.c:
8303 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8304 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8305 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8306 'getaddrinfo' and 'freeaddrinfo' were not available before
8307 Windows XP, and mingw.org's MinGW headers by default define
8308 _WIN32_WINNT to 0x500.
8309
827f438f
GB
83102019-03-01 Gary Benson <gbenson@redhat.com>
8311
8312 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8313
92137da0
RO
83142019-02-28 Brian Vandenberg <phantall@gmail.com>
8315 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8316
8317 PR gdb/8527
8318 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8319 set_sigint_trap, clear_sigint_trap.
8320
799efbe8
PW
83212019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8322
8323 * target.c (target_detach): Clear the regcache and the
8324 frame cache.
8325
8ed25214
PA
83262019-02-27 Pedro Alves <palves@redhat.com>
8327
8328 * utils.c (set_screen_size): When we cap the height/width sizes,
8329 tweak the corresponding command variable to show "unlimited":
8330
23031e31
SJ
83312019-02-27 Saagar Jha <saagar@saagarjha.com>
8332 Pedro Alves <palves@redhat.com>
8333
8334 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8335 before calling rl_set_screen_size.
8336
6c28e44a
TT
83372019-02-27 Tom Tromey <tromey@adacore.com>
8338
8339 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8340 define.
8341 * python/py-value.c: Remove Python 2.4 workaround.
8342 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8343 workaround.
8344 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8345 Python 2.4 workaround.
8346 * python/python-internal.h: Remove Python 2.4 comment.
8347 (Py_ssize_t): Don't define.
8348 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8349 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8350 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8351 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8352 * python/python.c (do_start_initialization): Remove Python 2.4
8353 workaround.
8354 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8355 (print_children): Remove Python 2.4 workaround.
8356 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8357 workaround.
8358 (CHARBUFFERPROC_NAME): Remove.
8359 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8360 Python 2.4 workaround.
8361
2c3fc25d 83622019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 8363
2c3fc25d
KB
8364 * NEWS: Note minimum Python version.
8365
6ca62222
KB
83662019-02-27 Kevin Buettner <kevinb@redhat.com>
8367
8368 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8369 code from these functions. Remove corresponding ifdefs. Use
8370 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8371 Remove gotos and target of gotos.
8372 (infpy_search_memory): Likewise.
8373
f4bc7d2c
AB
83742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8375
8376 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8377 (hppa_gdbarch_init): Don't register deleted functions with
8378 gdbarch.
8379
9734a586
AB
83802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8381
8382 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8383 (h8300_unwind_sp): Delete.
8384 (h8300_dummy_id): Delete.
8385 (h8300_gdbarch_init): Don't register deleted functions with
8386 gdbarch.
8387
68b867f3
AB
83882019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8389
8390 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8391 (ft32_unwind_pc): Delete.
8392 (ft32_unwind_sp): Delete.
8393 (ft32_gdbarch_init): Don't register deleted functions with
8394 gdbarch.
8395
2fbe7ad0
AB
83962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8397
8398 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8399 (frv_unwind_pc): Delete.
8400 (frv_unwind_sp): Delete.
8401 (frv_gdbarch_init): Don't register deleted functions with
8402 gdbarch.
8403
76055cbe
AB
84042019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8405
8406 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8407 (riscv_unwind_pc): Delete.
8408 (riscv_unwind_sp): Delete.
8409 (riscv_gdbarch_init): Don't register deleted functions with
8410 gdbarch.
8411
4133e5a1
AB
84122019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8413
8414 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8415 (csky_unwind_pc): Delete.
8416 (csky_unwind_sp): Delete.
8417 (csky_gdbarch_init): Don't register deleted functions with
8418 gdbarch.
8419
8010f576
AB
84202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8421
8422 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8423 (cris_unwind_pc): Delete.
8424 (cris_unwind_sp): Delete.
8425 (cris_gdbarch_init): Don't register deleted functions with
8426 gdbarch.
8427
b56bf084
AB
84282019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8429
8430 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8431 (bfin_unwind_pc): Delete.
8432 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8433
a19a650f
AB
84342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8435
8436 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8437 (arm_unwind_pc): Delete.
8438 (arm_unwind_sp): Delete.
8439 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8440
f8278c3c
AB
84412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8442
8443 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8444 (arc_unwind_pc): Delete.
8445 (arc_unwind_sp): Delete.
8446 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8447
480e46cf
AB
84482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8449
8450 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8451 (alpha_unwind_pc): Delete.
8452 (alpha_gdbarch_init): Don't register deleted functions with
8453 gdbarch.
8454
7a995095
AB
84552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8456
8457 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8458 (aarch64_unwind_pc): Delete.
8459 (aarch64_unwind_sp): Delete.
8460 (aarch64_gdbarch_init): Don't register deleted functions with
8461 gdbarch.
8462
bf9a735e
AB
84632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8464
8465 * gdbtypes.c (type_align): Don't consider static members when
8466 computing structure alignment.
8467
5561fc30
AB
84682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8469
8470 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8471 return 0 for other types.
8472 * arch-utils.c (default_type_align): Always return 0.
8473 * gdbarch.h: Regenerate.
8474 * gdbarch.sh (type_align): Extend comment.
8475 * gdbtypes.c (type_align): Add additional comments, always call
8476 gdbarch_type_align before applying the default rules.
8477 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8478 generic code will then apply a suitable default.
8479 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8480 types, return 0 for other types.
8481
9335e75a
JB
84822019-02-27 Joel Brobecker <brobecker@adacore.com>
8483
8484 * NEWS: Create a new section for the next release branch.
8485 Rename the section of the current branch, now that it has
8486 been cut.
8487
3d34d8de
JB
84882019-02-27 Joel Brobecker <brobecker@adacore.com>
8489
8490 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8491 * version.in: Bump version to 8.3.50.DATE-git.
8492
143420fb
SM
84932019-02-26 Simon Marchi <simon.marchi@efficios.com>
8494
8495 * aix-thread.c (ptid_cmp): Remove unused variable.
8496 (get_signaled_thread): Likewise.
8497 (store_regs_user_thread): Likewise.
8498 (store_regs_kernel_thread): Likewise.
8499 (fetch_regs_kernel_thread): Remove shadowed variable.
8500
172fb711
AB
85012019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
8502
8503 * features/riscv/32bit-cpu.xml: Add register numbers.
8504 * features/riscv/32bit-fpu.c: Regenerate.
8505 * features/riscv/32bit-fpu.xml: Add register numbers.
8506 * features/riscv/64bit-cpu.xml: Add register numbers.
8507 * features/riscv/64bit-fpu.c: Regenerate.
8508 * features/riscv/64bit-fpu.xml: Add register numbers.
8509
26c89782
KB
85102019-02-26 Kevin Buettner <kevinb@redhat.com>
8511
af54ade9 8512 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
8513 * python/py-value.c (convert_buffer_and_type_to_value): New
8514 function.
8515 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8516 Add support for handling an optional second argument. Call
8517 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
8518 * python/python-internal.h (Py_buffer_deleter): New struct.
8519 (Py_buffer_up): New typedef.
8520
0f58c9e8
JB
85212019-02-25 John Baldwin <jhb@FreeBSD.org>
8522
8523 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8524 instead of releasing ownership.
8525
0a0f4c01
JR
85262019-02-25 Jordan Rupprecht <rupprecht@google.com>
8527
8528 * dwarf2read.c (open_and_init_dwp_file): Call
8529 elf_numsections instead of bfd_count_sections to initialize
8530 dwp_file->num_sections.
8531
cd5a152c
TT
85322019-02-25 Tom Tromey <tromey@adacore.com>
8533
8534 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8535
8a6a8513
SDJ
85362019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
8537
8538 * gcore.in: Add '--readnever' option when invoking GDB.
8539
04dcda9c
SM
85402019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8541
8542 * MAINTAINERS: Update my email address.
8543
07bc701d
SM
85442019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
8545
8546 * build-id.c (build_id_to_debug_bfd_1): New function.
8547 (build_id_to_debug_bfd): Look for separate debug file in
8548 sysroot.
8549
c6f4a5d0
AB
85502019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
8551
8552 * gdbarch.sh: Update the copyright year range that is placed into
8553 generated files.
8554
9600246d
KS
85552019-02-22 Keith Seitz <keiths@redhat.com>
8556
8557 PR symtab/23853
8558 * linespec.c (create_sals_line_offset): Search for the default
8559 symtab's filename instead of its fullname.
8560
7557a514
AH
85612019-02-21 Alan Hayward <alan.hayward@arm.com>
8562
8563 * NEWS: Update style defaults.
8564
ee2bcb0c
AH
85652019-02-21 Alan Hayward <alan.hayward@arm.com>
8566
8567 * main.c (captured_main_1): Disable styling in batch mode.
8568
0c95f9ed
TT
85692019-02-20 Tom Tromey <tom@tromey.com>
8570
8571 * symtab.c (symtab_symbol_info): Fix typos.
8572
c763b894
TT
85732019-02-20 Tom Tromey <tromey@adacore.com>
8574
8575 * findcmd.c (_initialize_mem_search): Use upper case for
8576 metasyntactic variables.
8577
0ef8a082
AH
85782019-02-20 Alan Hayward <alan.hayward@arm.com>
8579
8580 * aarch64-tdep.c (aarch64_add_reggroups): New function.
8581 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8582
6caa91b6
SM
85832019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
8584
8585 * top.h (source_file_name): Change to std::string.
8586 * top.c (source_file_name): Likewise.
8587 (command_line_input): Adjust.
8588 * cli/cli-script.c (script_from_file): Adjust.
8589
98814c6c
TT
85902019-02-19 Tom Tromey <tromey@adacore.com>
8591
8592 * ravenscar-thread.c
8593 (ravenscar_thread_target::update_thread_list): Don't call
8594 ada_build_task_list.
8595 * ada-lang.h (ada_build_task_list): Don't declare.
8596 * ada-tasks.c (struct ada_tasks_inferior_data)
8597 <task_list_valid_p>: Now bool.
8598 (read_known_tasks, ada_task_list_changed)
8599 (ada_tasks_invalidate_inferior_data): Update.
8600 (read_known_tasks_array): Return bool.
8601 (read_known_tasks_list): Likewise.
8602 (read_known_tasks): Return void.
8603 (ada_build_task_list): Now static.
8604
70cd633e
AB
86052019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
8606
8607 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8608 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8609
040b3e95
PW
86102019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8611
8612 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8613 variant for ada_tasks_pspace_data_handle and
8614 ada_tasks_inferior_data_handle.
8615 (ada_tasks_pspace_data_cleanup): New function.
8616 (ada_tasks_inferior_data_cleanup): New function.
8617
9409233b
TT
86182019-02-17 Tom Tromey <tom@tromey.com>
8619
8620 * macrotab.h (macro_source_fullname): Return a std::string.
8621 * macrotab.c (macro_include, check_for_redefinition)
8622 (macro_undef, macro_lookup_definition, foreach_macro)
8623 (foreach_macro_in_scope): Update.
8624 (macro_source_fullname): Return a std::string.
8625 * macrocmd.c (show_pp_source_pos): Update.
8626
6506371f
TT
86272019-02-17 Tom Tromey <tom@tromey.com>
8628
8629 * macrocmd.c (show_pp_source_pos): Style the file names.
8630
0c820d67
TT
86312019-02-17 Tom Tromey <tom@tromey.com>
8632
8633 PR tui/24197:
8634 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8635
a0087920
TT
86362019-02-17 Tom Tromey <tom@tromey.com>
8637
8638 * ada-lang.c (user_select_syms): Use filtered printing.
8639 * utils.c (wrap_style): New global.
8640 (desired_style): Remove.
8641 (emit_style_escape): Add stream parameter.
8642 (set_output_style, reset_terminal_style, prompt_for_continue):
8643 Update.
8644 (flush_wrap_buffer): Only flush gdb_stdout.
8645 (wrap_here): Set wrap_style.
8646 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
8647 treat escape sequences as a character. Change when wrap buffer is
8648 flushed.
8649 (fputs_styled): Do not set the output style when the default is
8650 requested.
8651 * ui-style.h (struct ui_file_style) <is_default>: New method.
8652 * source.c (print_source_lines_base): Emit escape sequences in one
8653 piece.
8654
75ba10dc
JB
86552019-02-17 Joel Brobecker <brobecker@adacore.com>
8656
8657 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8658 integers and enumeration types.
8659
a2cd4f14
JB
86602019-02-17 Joel Brobecker <brobecker@adacore.com>
8661
8662 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8663 instead of lookup_symbol_in_language
8664 (do_exact_match): New function.
8665 (ada_get_symbol_name_matcher): Return do_exact_match when
8666 doing a verbatim match.
8667
485b851b
TT
86682019-02-15 Tom Tromey <tromey@adacore.com>
8669
8670 * ravenscar-thread.c (ravenscar_thread_target::resume)
8671 (ravenscar_thread_target::wait): Special case wildcard requests.
8672
0b790b1e
TT
86732019-02-15 Tom Tromey <tromey@adacore.com>
8674
8675 * ravenscar-thread.c (base_ptid): Remove.
8676 (struct ravenscar_thread_target) <close>: New method.
8677 <m_base_ptid>: New member.
8678 <update_inferior_ptid, active_task, task_is_currently_active,
8679 runtime_initialized>: Declare methods.
8680 <ravenscar_thread_target>: Add constructor.
8681 (ravenscar_thread_target::task_is_currently_active)
8682 (ravenscar_thread_target::update_inferior_ptid)
8683 (ravenscar_runtime_initialized): Rename. Now methods.
8684 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8685 (ravenscar_thread_target::update_thread_list): Update.
8686 (ravenscar_thread_target::active_task): Now method.
8687 (ravenscar_thread_target::store_registers)
8688 (ravenscar_thread_target::prepare_to_store)
8689 (ravenscar_thread_target::prepare_to_store)
8690 (ravenscar_thread_target::mourn_inferior): Update.
8691 (ravenscar_inferior_created): Use "new" to create target.
8692 (ravenscar_thread_target::get_ada_task_ptid): Update.
8693 (_initialize_ravenscar): Don't initialize base_ptid.
8694 (ravenscar_ops): Remove global.
8695
dea57a62
TT
86962019-02-15 Tom Tromey <tromey@adacore.com>
8697
8698 * target.h (push_target): Declare new overload.
8699 * target.c (push_target): New overload, taking an rvalue reference.
8700 * remote.c (remote_target::open_1): Use push_target overload.
8701 * corelow.c (core_target_open): Use push_target overload.
8702
989f3c58
TT
87032019-02-15 Tom Tromey <tromey@adacore.com>
8704
8705 * ravenscar-thread.c (is_ravenscar_task)
8706 (ravenscar_task_is_currently_active): Return bool.
8707 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8708 (_initialize_ravenscar): Remove "(void)".
8709 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8710 Return bool.
8711
6cbcc006
TT
87122019-02-15 Tom Tromey <tromey@adacore.com>
8713
8714 * ravenscar-thread.c (ravenscar_runtime_initializer)
8715 (has_ravenscar_runtime, get_running_thread_id)
8716 (ravenscar_thread_target::resume): Fix indentation.
8717
7657f14d
TT
87182019-02-15 Tom Tromey <tromey@adacore.com>
8719
8720 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8721 from ravenscar_arch_ops.
8722 (sparc_ravenscar_ops::fetch_registers)
8723 (sparc_ravenscar_ops::store_registers): Now methods.
8724 (sparc_ravenscar_prepare_to_store): Remove.
8725 (sparc_ravenscar_ops): Redefine.
8726 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8727 methods and destructor. Remove members.
8728 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8729 (ravenscar_thread_target::store_registers)
8730 (ravenscar_thread_target::prepare_to_store): Update.
8731 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8732 Remove.
8733 (struct ppc_ravenscar_powerpc_ops): Derive from
8734 ravenscar_arch_ops.
8735 (ppc_ravenscar_powerpc_ops::fetch_registers)
8736 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8737 (ppc_ravenscar_powerpc_ops): Redefine.
8738 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8739 (ppc_ravenscar_e500_ops::fetch_registers)
8740 (ppc_ravenscar_e500_ops::store_registers): Now methods.
8741 (ppc_ravenscar_e500_ops): Redefine.
8742 * aarch64-ravenscar-thread.c
8743 (aarch64_ravenscar_generic_prepare_to_store): Remove.
8744 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8745 (aarch64_ravenscar_fetch_registers)
8746 (aarch64_ravenscar_store_registers): Now methods.
8747 (aarch64_ravenscar_ops): Redefine.
8748
5b6ea500
TT
87492019-02-15 Tom Tromey <tromey@adacore.com>
8750
8751 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8752 (ravenscar_thread_target::stopped_by_hw_breakpoint)
8753 (ravenscar_thread_target::stopped_by_watchpoint)
8754 (ravenscar_thread_target::stopped_data_address)
8755 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8756
e397fd39
TT
87572019-02-15 Tom Tromey <tromey@adacore.com>
8758
8759 * ravenscar-thread.c: Fix some typos.
8760
cc12f4a8
TT
87612019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8762 Tom Tromey <tromey@adacore.com>
8763
8764 * ada-lang.c (ada_exception_sal): Change addr_string to a
8765 std::string.
8766 (create_ada_exception_catchpoint): Update.
8767
5f486660
TT
87682019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8769 Tom Tromey <tromey@adacore.com>
8770
8771 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8772 (bp_location_ops): Remove.
8773 (base_breakpoint_allocate_location): Update.
8774 (free_bp_location): Update.
8775 * ada-lang.c (class ada_catchpoint_location)
8776 <ada_catchpoint_location>: Remove ops parameter.
8777 (ada_catchpoint_location_dtor): Remove.
8778 (ada_catchpoint_location_ops): Remove.
8779 (allocate_location_exception): Update.
8780 * breakpoint.h (struct bp_location_ops): Remove.
8781 (class bp_location) <bp_location>: Remove bp_location_ops
8782 parameter.
8783 <~bp_location>: Add destructor.
8784 <ops>: Remove.
8785
b671c7fb
TS
87862019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8787 Pedro Alves <palves@redhat.com>
8788
8789 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8790 'PATH_MAX'.
8791
8071c5ce
DM
87922019-02-14 David Michael <fedora.dm0@gmail.com>
8793 Samuel Thibault <samuel.thibault@gnu.org>
8794 Thomas Schwinge <thomas@codesourcery.com>
8795
8796 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8797 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8798
b1041ae0
TS
87992019-02-14 Thomas Schwinge <thomas@codesourcery.com>
8800
924514e1
TS
8801 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8802 (check_empty): Use "const char *".
8803
c29ee8d4
TS
8804 * gnu-nat.c (gnu_nat_target::detach): Instead of
8805 'detach_inferior (pid)' call
8806 'detach_inferior (find_inferior_pid (pid))'.
8807
6c6ef69f
TS
8808 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8809 'nat/fork-inferior.o'.
8810 * gnu-nat.c: #include "nat/fork-inferior.h".
8811
2d0a338c
TS
8812 * gnu-nat.c (gnu_nat_target::detach): Instead of
8813 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8814 * gnu-nat.h: #include "inf-child.h".
8815 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8816 'i386_gnu_nat_target::fetch_registers'.
8817 (gnu_store_registers): Rename/move to
8818 'i386_gnu_nat_target::store_registers'.
8819
cabb5f06
TS
8820 * config/i386/nm-i386gnu.h: Don't "#include" any files.
8821 * gnu-nat.h (mach_thread_info): New function.
8822 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8823
b1041ae0
TS
8824 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8825
2988d01e
KF
88262019-02-14 Frederic Konrad <konrad@adacore.com>
8827
8828 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8829
c559d709
JB
88302019-02-14 Joel Brobecker <brobecker@adacore.com>
8831
8832 * windows-nat.c (windows_add_thread): Add new parameter
8833 "main_thread_p" with default value set to false. Update
8834 function documentation as well as all callers.
8835 (windows_delete_thread): Likewise.
8836 (fake_create_process): Update call to windows_add_thread.
8837 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8838 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8839 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8840 call to windows_delete_thread.
8841
007024cc
SM
88422019-02-13 Simon Marchi <simon.marchi@ericsson.com>
8843
8844 * MAINTAINERS: Add Andrew Burgess as global maintainer.
8845
f62318e9
JB
88462019-02-12 John Baldwin <jhb@FreeBSD.org>
8847
8848 * symfile.c (find_separate_debug_file): Use canonical path of
8849 sysroot with child_path instead of gdb_sysroot if it is valid.
8850
cd4b7848
JB
88512019-02-12 John Baldwin <jhb@FreeBSD.org>
8852
8853 * symfile.c (find_separate_debug_file): Use child_path to
8854 determine if an object file is under a sysroot.
8855
efac4bfe
JB
88562019-02-12 John Baldwin <jhb@FreeBSD.org>
8857
8858 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8859 unittests/child-path-selftests.c.
8860 * common/pathstuff.c (child_path): New function.
8861 * common/pathstuff.h (child_path): New prototype.
8862 * unittests/child-path-selftests.c: New file.
8863
402d2bfe
JB
88642019-02-12 John Baldwin <jhb@FreeBSD.org>
8865
8866 * symfile.c (find_separate_debug_file): Look for separate debug
8867 files in debug directories under the sysroot.
8868
1ed9f74e
PW
88692019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8870
8871 * symtab.h (struct minimal_symbol data_p): New const method.
8872 (struct minimal_symbol text_p): Likewise.
8873 * symtab.c (output_source_filename): Use file name style
8874 to print file name.
8875 (print_symbol_info): Likewise.
8876 (print_msymbol_info): Use address style to print addresses.
8877 Use function name style to print executable text symbols.
8878 (expand_symtab_containing_pc): Use data_p.
8879 (find_pc_sect_compunit_symtab): Likewise.
8880
2636d81d
PW
88812019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8882
8883 * breakpoint.c (describe_other_breakpoints): Use address style
8884 to print addresses.
8885 (say_where): Likewise.
8886
ac8c53cc
PW
88872019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8888
8889 * ada-typeprint.c (print_func_type): Print function name
8890 style to print function name.
8891 * c-typeprint.c (c_print_type_1): Likewise.
8892
ea638c43
AH
88932019-02-11 Alan Hayward <alan.hayward@arm.com>
8894
8895 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8896 for execve.
8897
ab759ca8
PW
88982019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8899
8900 * c-exp.y (direct_abs_decl): Use emplace_back to record the
8901 type_stack.
8902
aff29d1c
JB
89032019-02-10 Joel Brobecker <brobecker@adacore.com>
8904
8905 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8906 TYPE_CODE_REF types.
8907
617126bc
JW
89082019-02-08 Jim Wilson <jimw@sifive.com>
8909
8910 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8911 (riscv_linux_fregset): New.
8912 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8913
46e3ed7f
TT
89142019-02-07 Tom Tromey <tom@tromey.com>
8915
8916 * thread.c (thread_cancel_execution_command): Update.
8917 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8918 methods.
8919 (struct thread_fsm_ops): Remove.
8920 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8921 (thread_fsm_should_stop, thread_fsm_return_value)
8922 (thread_fsm_set_finished, thread_fsm_finished_p)
8923 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8924 Don't declare.
8925 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8926 * infrun.c (clear_proceed_status_thread)
8927 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8928 (print_stop_event): Update.
8929 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8930 Add constructor.
8931 (step_command_fsm_ops): Remove.
8932 (new_step_command_fsm): Remove.
8933 (step_1): Update.
8934 (step_command_fsm::should_stop): Rename from
8935 step_command_fsm_should_stop.
8936 (step_command_fsm::clean_up): Rename from
8937 step_command_fsm_clean_up.
8938 (step_command_fsm::do_async_reply_reason): Rename from
8939 step_command_fsm_async_reply_reason.
8940 (struct until_next_fsm): Inherit from thread_fsm. Add
8941 constructor.
8942 (until_next_fsm_ops): Remove.
8943 (new_until_next_fsm): Remove.
8944 (until_next_fsm::should_stop): Rename from
8945 until_next_fsm_should_stop.
8946 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8947 (until_next_fsm::do_async_reply_reason): Rename from
8948 until_next_fsm_async_reply_reason.
8949 (struct finish_command_fsm): Inherit from thread_fsm. Add
8950 constructor. Change type of breakpoint.
8951 (finish_command_fsm_ops): Remove.
8952 (new_finish_command_fsm): Remove.
8953 (finish_command_fsm::should_stop): Rename from
8954 finish_command_fsm_should_stop.
8955 (finish_command_fsm::clean_up): Rename from
8956 finish_command_fsm_clean_up.
8957 (finish_command_fsm::return_value): Rename from
8958 finish_command_fsm_return_value.
8959 (finish_command_fsm::do_async_reply_reason): Rename from
8960 finish_command_fsm_async_reply_reason.
8961 (finish_command): Update.
8962 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8963 Add constructor.
8964 (call_thread_fsm_ops): Remove.
8965 (call_thread_fsm::call_thread_fsm): Rename from
8966 new_call_thread_fsm.
8967 (call_thread_fsm::should_stop): Rename from
8968 call_thread_fsm_should_stop.
8969 (call_thread_fsm::should_notify_stop): Rename from
8970 call_thread_fsm_should_notify_stop.
8971 (run_inferior_call, call_function_by_hand_dummy): Update.
8972 * cli/cli-interp.c (should_print_stop_to_console): Update.
8973 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8974 Add constructor. Change type of location_breakpoint,
8975 caller_breakpoint.
8976 (until_break_fsm_ops): Remove.
8977 (new_until_break_fsm): Remove.
8978 (until_break_fsm::should_stop): Rename from
8979 until_break_fsm_should_stop.
8980 (until_break_fsm::clean_up): Rename from
8981 until_break_fsm_clean_up.
8982 (until_break_fsm::do_async_reply_reason): Rename from
8983 until_break_fsm_async_reply_reason.
8984 (until_break_command): Update.
8985 * thread-fsm.c: Remove.
8986 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8987
1a5c2598
TT
89882019-02-07 Tom Tromey <tom@tromey.com>
8989
8990 * yy-remap.h: Add include guard.
8991 * xtensa-tdep.h: Add include guard.
8992 * xcoffread.h: Rename include guard.
8993 * varobj-iter.h: Add include guard.
8994 * tui/tui.h: Rename include guard.
8995 * tui/tui-winsource.h: Rename include guard.
8996 * tui/tui-wingeneral.h: Rename include guard.
8997 * tui/tui-windata.h: Rename include guard.
8998 * tui/tui-win.h: Rename include guard.
8999 * tui/tui-stack.h: Rename include guard.
9000 * tui/tui-source.h: Rename include guard.
9001 * tui/tui-regs.h: Rename include guard.
9002 * tui/tui-out.h: Rename include guard.
9003 * tui/tui-layout.h: Rename include guard.
9004 * tui/tui-io.h: Rename include guard.
9005 * tui/tui-hooks.h: Rename include guard.
9006 * tui/tui-file.h: Rename include guard.
9007 * tui/tui-disasm.h: Rename include guard.
9008 * tui/tui-data.h: Rename include guard.
9009 * tui/tui-command.h: Rename include guard.
9010 * tic6x-tdep.h: Add include guard.
9011 * target/waitstatus.h: Rename include guard.
9012 * target/wait.h: Rename include guard.
9013 * target/target.h: Rename include guard.
9014 * target/resume.h: Rename include guard.
9015 * target-float.h: Rename include guard.
9016 * stabsread.h: Add include guard.
9017 * rs6000-tdep.h: Add include guard.
9018 * riscv-fbsd-tdep.h: Add include guard.
9019 * regformats/regdef.h: Rename include guard.
9020 * record.h: Rename include guard.
9021 * python/python.h: Rename include guard.
9022 * python/python-internal.h: Rename include guard.
9023 * python/py-stopevent.h: Rename include guard.
9024 * python/py-ref.h: Rename include guard.
9025 * python/py-record.h: Rename include guard.
9026 * python/py-record-full.h: Rename include guard.
9027 * python/py-record-btrace.h: Rename include guard.
9028 * python/py-instruction.h: Rename include guard.
9029 * python/py-events.h: Rename include guard.
9030 * python/py-event.h: Rename include guard.
9031 * procfs.h: Add include guard.
9032 * proc-utils.h: Add include guard.
9033 * p-lang.h: Add include guard.
9034 * or1k-tdep.h: Rename include guard.
9035 * observable.h: Rename include guard.
9036 * nto-tdep.h: Rename include guard.
9037 * nat/x86-linux.h: Rename include guard.
9038 * nat/x86-linux-dregs.h: Rename include guard.
9039 * nat/x86-gcc-cpuid.h: Add include guard.
9040 * nat/x86-dregs.h: Rename include guard.
9041 * nat/x86-cpuid.h: Rename include guard.
9042 * nat/ppc-linux.h: Rename include guard.
9043 * nat/mips-linux-watch.h: Rename include guard.
9044 * nat/linux-waitpid.h: Rename include guard.
9045 * nat/linux-ptrace.h: Rename include guard.
9046 * nat/linux-procfs.h: Rename include guard.
9047 * nat/linux-osdata.h: Rename include guard.
9048 * nat/linux-nat.h: Rename include guard.
9049 * nat/linux-namespaces.h: Rename include guard.
9050 * nat/linux-btrace.h: Rename include guard.
9051 * nat/glibc_thread_db.h: Rename include guard.
9052 * nat/gdb_thread_db.h: Rename include guard.
9053 * nat/gdb_ptrace.h: Rename include guard.
9054 * nat/fork-inferior.h: Rename include guard.
9055 * nat/amd64-linux-siginfo.h: Rename include guard.
9056 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9057 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9058 * nat/aarch64-linux.h: Rename include guard.
9059 * nat/aarch64-linux-hw-point.h: Rename include guard.
9060 * mn10300-tdep.h: Add include guard.
9061 * mips-linux-tdep.h: Add include guard.
9062 * mi/mi-parse.h: Rename include guard.
9063 * mi/mi-out.h: Rename include guard.
9064 * mi/mi-main.h: Rename include guard.
9065 * mi/mi-interp.h: Rename include guard.
9066 * mi/mi-getopt.h: Rename include guard.
9067 * mi/mi-console.h: Rename include guard.
9068 * mi/mi-common.h: Rename include guard.
9069 * mi/mi-cmds.h: Rename include guard.
9070 * mi/mi-cmd-break.h: Rename include guard.
9071 * m2-lang.h: Add include guard.
9072 * location.h: Rename include guard.
9073 * linux-record.h: Rename include guard.
9074 * linux-nat.h: Add include guard.
9075 * linux-fork.h: Add include guard.
9076 * i386-darwin-tdep.h: Rename include guard.
9077 * hppa-linux-offsets.h: Add include guard.
9078 * guile/guile.h: Rename include guard.
9079 * guile/guile-internal.h: Rename include guard.
9080 * gnu-nat.h: Rename include guard.
9081 * gdb-stabs.h: Rename include guard.
9082 * frv-tdep.h: Add include guard.
9083 * f-lang.h: Add include guard.
9084 * event-loop.h: Add include guard.
9085 * darwin-nat.h: Rename include guard.
9086 * cp-abi.h: Rename include guard.
9087 * config/sparc/nm-sol2.h: Rename include guard.
9088 * config/nm-nto.h: Rename include guard.
9089 * config/nm-linux.h: Add include guard.
9090 * config/i386/nm-i386gnu.h: Rename include guard.
9091 * config/djgpp/nl_types.h: Rename include guard.
9092 * config/djgpp/langinfo.h: Rename include guard.
9093 * compile/gcc-cp-plugin.h: Add include guard.
9094 * compile/gcc-c-plugin.h: Add include guard.
9095 * compile/compile.h: Rename include guard.
9096 * compile/compile-object-run.h: Rename include guard.
9097 * compile/compile-object-load.h: Rename include guard.
9098 * compile/compile-internal.h: Rename include guard.
9099 * compile/compile-cplus.h: Rename include guard.
9100 * compile/compile-c.h: Rename include guard.
9101 * common/xml-utils.h: Rename include guard.
9102 * common/x86-xstate.h: Rename include guard.
9103 * common/version.h: Rename include guard.
9104 * common/vec.h: Rename include guard.
9105 * common/tdesc.h: Rename include guard.
9106 * common/selftest.h: Rename include guard.
9107 * common/scoped_restore.h: Rename include guard.
9108 * common/scoped_mmap.h: Rename include guard.
9109 * common/scoped_fd.h: Rename include guard.
9110 * common/safe-iterator.h: Rename include guard.
9111 * common/run-time-clock.h: Rename include guard.
9112 * common/refcounted-object.h: Rename include guard.
9113 * common/queue.h: Rename include guard.
9114 * common/ptid.h: Rename include guard.
9115 * common/print-utils.h: Rename include guard.
9116 * common/preprocessor.h: Rename include guard.
9117 * common/pathstuff.h: Rename include guard.
9118 * common/observable.h: Rename include guard.
9119 * common/netstuff.h: Rename include guard.
9120 * common/job-control.h: Rename include guard.
9121 * common/host-defs.h: Rename include guard.
9122 * common/gdb_wait.h: Rename include guard.
9123 * common/gdb_vecs.h: Rename include guard.
9124 * common/gdb_unlinker.h: Rename include guard.
9125 * common/gdb_unique_ptr.h: Rename include guard.
9126 * common/gdb_tilde_expand.h: Rename include guard.
9127 * common/gdb_sys_time.h: Rename include guard.
9128 * common/gdb_string_view.h: Rename include guard.
9129 * common/gdb_splay_tree.h: Rename include guard.
9130 * common/gdb_setjmp.h: Rename include guard.
9131 * common/gdb_ref_ptr.h: Rename include guard.
9132 * common/gdb_optional.h: Rename include guard.
9133 * common/gdb_locale.h: Rename include guard.
9134 * common/gdb_assert.h: Rename include guard.
9135 * common/filtered-iterator.h: Rename include guard.
9136 * common/filestuff.h: Rename include guard.
9137 * common/fileio.h: Rename include guard.
9138 * common/environ.h: Rename include guard.
9139 * common/common-utils.h: Rename include guard.
9140 * common/common-types.h: Rename include guard.
9141 * common/common-regcache.h: Rename include guard.
9142 * common/common-inferior.h: Rename include guard.
9143 * common/common-gdbthread.h: Rename include guard.
9144 * common/common-exceptions.h: Rename include guard.
9145 * common/common-defs.h: Rename include guard.
9146 * common/common-debug.h: Rename include guard.
9147 * common/cleanups.h: Rename include guard.
9148 * common/buffer.h: Rename include guard.
9149 * common/btrace-common.h: Rename include guard.
9150 * common/break-common.h: Rename include guard.
9151 * cli/cli-utils.h: Rename include guard.
9152 * cli/cli-style.h: Rename include guard.
9153 * cli/cli-setshow.h: Rename include guard.
9154 * cli/cli-script.h: Rename include guard.
9155 * cli/cli-interp.h: Rename include guard.
9156 * cli/cli-decode.h: Rename include guard.
9157 * cli/cli-cmds.h: Rename include guard.
9158 * charset-list.h: Add include guard.
9159 * buildsym-legacy.h: Rename include guard.
9160 * bfin-tdep.h: Add include guard.
9161 * ax.h: Rename include guard.
9162 * arm-linux-tdep.h: Add include guard.
9163 * arm-fbsd-tdep.h: Add include guard.
9164 * arch/xtensa.h: Rename include guard.
9165 * arch/tic6x.h: Add include guard.
9166 * arch/i386.h: Add include guard.
9167 * arch/arm.h: Rename include guard.
9168 * arch/arm-linux.h: Rename include guard.
9169 * arch/arm-get-next-pcs.h: Rename include guard.
9170 * arch/amd64.h: Add include guard.
9171 * arch/aarch64-insn.h: Rename include guard.
9172 * arch-utils.h: Rename include guard.
9173 * annotate.h: Add include guard.
9174 * amd64-darwin-tdep.h: Rename include guard.
9175 * aarch64-linux-tdep.h: Add include guard.
9176 * aarch64-fbsd-tdep.h: Add include guard.
9177 * aarch32-linux-nat.h: Add include guard.
9178
ab9268d2
PW
91792019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9180
9181 * macrotab.c (macro_define_internal): New function that
9182 factorizes macro_define_object_internal and macro_define_function
9183 code.
9184 (macro_define_object_internal): Use macro_define_internal.
9185 (macro_define_function): Likewise.
9186
bb0da2b4
PW
91872019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9188
9189 * macrocmd.c (extract_identifier): Return
9190 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9191 callers.
9192
424eb552
JB
91932019-02-06 John Baldwin <jhb@FreeBSD.org>
9194
9195 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9196
1688cb29
TT
91972019-02-05 Tom Tromey <tom@tromey.com>
9198
9199 * target.c (target_stack::unpush): Move assertion earlier.
9200
b5eba2d8
TT
92012019-01-30 Tom Tromey <tom@tromey.com>
9202
9203 PR python/23615:
9204 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9205 (gdbpy_parse_and_eval): Likewise.
9206 * python/python-internal.h (gdbpy_allow_threads): New class.
9207
7054e2ff
JB
92082019-01-28 John Baldwin <jhb@FreeBSD.org>
9209
9210 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9211 (aarch64_fbsd_fpregmap): Move earlier.
9212 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9213 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9214 instead of individual calls to trad_frame_set_reg_addr.
9215 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9216 earlier.
9217 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9218 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9219 instead of individual calls to trad_frame_set_reg_addr.
9220
36c25ffa
AH
92212019-01-28 Alan Hayward <alan.hayward@arm.com>
9222
9223 * CONTRIBUTE: Replace contribution list with wiki link.
9224
a0707f3c
TT
92252019-01-25 Tom Tromey <tom@tromey.com>
9226
9227 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9228
0747795c
TT
92292019-01-25 Tom Tromey <tom@tromey.com>
9230
9231 * xtensa-linux-nat.c: Fix common/ includes.
9232 * xml-support.h: Fix common/ includes.
9233 * xml-support.c: Fix common/ includes.
9234 * x86-linux-nat.c: Fix common/ includes.
9235 * windows-nat.c: Fix common/ includes.
9236 * varobj.h: Fix common/ includes.
9237 * varobj.c: Fix common/ includes.
9238 * value.c: Fix common/ includes.
9239 * valops.c: Fix common/ includes.
9240 * utils.c: Fix common/ includes.
9241 * unittests/xml-utils-selftests.c: Fix common/ includes.
9242 * unittests/utils-selftests.c: Fix common/ includes.
9243 * unittests/unpack-selftests.c: Fix common/ includes.
9244 * unittests/tracepoint-selftests.c: Fix common/ includes.
9245 * unittests/style-selftests.c: Fix common/ includes.
9246 * unittests/string_view-selftests.c: Fix common/ includes.
9247 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9248 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9249 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9250 * unittests/rsp-low-selftests.c: Fix common/ includes.
9251 * unittests/parse-connection-spec-selftests.c: Fix common/
9252 includes.
9253 * unittests/optional-selftests.c: Fix common/ includes.
9254 * unittests/offset-type-selftests.c: Fix common/ includes.
9255 * unittests/observable-selftests.c: Fix common/ includes.
9256 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9257 * unittests/memrange-selftests.c: Fix common/ includes.
9258 * unittests/memory-map-selftests.c: Fix common/ includes.
9259 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9260 * unittests/function-view-selftests.c: Fix common/ includes.
9261 * unittests/environ-selftests.c: Fix common/ includes.
9262 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9263 * unittests/common-utils-selftests.c: Fix common/ includes.
9264 * unittests/cli-utils-selftests.c: Fix common/ includes.
9265 * unittests/array-view-selftests.c: Fix common/ includes.
9266 * ui-file.c: Fix common/ includes.
9267 * tui/tui-io.c: Fix common/ includes.
9268 * tracepoint.h: Fix common/ includes.
9269 * tracepoint.c: Fix common/ includes.
9270 * tracefile-tfile.c: Fix common/ includes.
9271 * top.h: Fix common/ includes.
9272 * top.c: Fix common/ includes.
9273 * thread.c: Fix common/ includes.
9274 * target/waitstatus.h: Fix common/ includes.
9275 * target/waitstatus.c: Fix common/ includes.
9276 * target.h: Fix common/ includes.
9277 * target.c: Fix common/ includes.
9278 * target-memory.c: Fix common/ includes.
9279 * target-descriptions.c: Fix common/ includes.
9280 * symtab.h: Fix common/ includes.
9281 * symfile.c: Fix common/ includes.
9282 * stap-probe.c: Fix common/ includes.
9283 * spu-linux-nat.c: Fix common/ includes.
9284 * sparc-nat.c: Fix common/ includes.
9285 * source.c: Fix common/ includes.
9286 * solib.c: Fix common/ includes.
9287 * solib-target.c: Fix common/ includes.
9288 * ser-unix.c: Fix common/ includes.
9289 * ser-tcp.c: Fix common/ includes.
9290 * ser-pipe.c: Fix common/ includes.
9291 * ser-base.c: Fix common/ includes.
9292 * selftest-arch.c: Fix common/ includes.
9293 * s12z-tdep.c: Fix common/ includes.
9294 * rust-exp.y: Fix common/ includes.
9295 * rs6000-aix-tdep.c: Fix common/ includes.
9296 * riscv-tdep.c: Fix common/ includes.
9297 * remote.c: Fix common/ includes.
9298 * remote-notif.h: Fix common/ includes.
9299 * remote-fileio.h: Fix common/ includes.
9300 * remote-fileio.c: Fix common/ includes.
9301 * regcache.h: Fix common/ includes.
9302 * regcache.c: Fix common/ includes.
9303 * record-btrace.c: Fix common/ includes.
9304 * python/python.c: Fix common/ includes.
9305 * python/py-type.c: Fix common/ includes.
9306 * python/py-inferior.c: Fix common/ includes.
9307 * progspace.h: Fix common/ includes.
9308 * producer.c: Fix common/ includes.
9309 * procfs.c: Fix common/ includes.
9310 * proc-api.c: Fix common/ includes.
9311 * printcmd.c: Fix common/ includes.
9312 * ppc-linux-nat.c: Fix common/ includes.
9313 * parser-defs.h: Fix common/ includes.
9314 * osdata.c: Fix common/ includes.
9315 * obsd-nat.c: Fix common/ includes.
9316 * nat/x86-linux.c: Fix common/ includes.
9317 * nat/x86-linux-dregs.c: Fix common/ includes.
9318 * nat/x86-dregs.h: Fix common/ includes.
9319 * nat/x86-dregs.c: Fix common/ includes.
9320 * nat/ppc-linux.c: Fix common/ includes.
9321 * nat/mips-linux-watch.h: Fix common/ includes.
9322 * nat/mips-linux-watch.c: Fix common/ includes.
9323 * nat/linux-waitpid.c: Fix common/ includes.
9324 * nat/linux-ptrace.h: Fix common/ includes.
9325 * nat/linux-ptrace.c: Fix common/ includes.
9326 * nat/linux-procfs.c: Fix common/ includes.
9327 * nat/linux-personality.c: Fix common/ includes.
9328 * nat/linux-osdata.c: Fix common/ includes.
9329 * nat/linux-namespaces.c: Fix common/ includes.
9330 * nat/linux-btrace.h: Fix common/ includes.
9331 * nat/linux-btrace.c: Fix common/ includes.
9332 * nat/fork-inferior.c: Fix common/ includes.
9333 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9334 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9335 * nat/aarch64-linux.c: Fix common/ includes.
9336 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9337 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9338 * namespace.h: Fix common/ includes.
9339 * mips-linux-tdep.c: Fix common/ includes.
9340 * minsyms.c: Fix common/ includes.
9341 * mi/mi-parse.h: Fix common/ includes.
9342 * mi/mi-main.c: Fix common/ includes.
9343 * mi/mi-cmd-env.c: Fix common/ includes.
9344 * memrange.h: Fix common/ includes.
9345 * memattr.c: Fix common/ includes.
9346 * maint.h: Fix common/ includes.
9347 * maint.c: Fix common/ includes.
9348 * main.c: Fix common/ includes.
9349 * machoread.c: Fix common/ includes.
9350 * location.c: Fix common/ includes.
9351 * linux-thread-db.c: Fix common/ includes.
9352 * linux-nat.c: Fix common/ includes.
9353 * linux-fork.c: Fix common/ includes.
9354 * inline-frame.c: Fix common/ includes.
9355 * infrun.c: Fix common/ includes.
9356 * inflow.c: Fix common/ includes.
9357 * inferior.h: Fix common/ includes.
9358 * inferior.c: Fix common/ includes.
9359 * infcmd.c: Fix common/ includes.
9360 * inf-ptrace.c: Fix common/ includes.
9361 * inf-child.c: Fix common/ includes.
9362 * ia64-linux-nat.c: Fix common/ includes.
9363 * i387-tdep.c: Fix common/ includes.
9364 * i386-tdep.c: Fix common/ includes.
9365 * i386-linux-tdep.c: Fix common/ includes.
9366 * i386-linux-nat.c: Fix common/ includes.
9367 * i386-go32-tdep.c: Fix common/ includes.
9368 * i386-fbsd-tdep.c: Fix common/ includes.
9369 * i386-fbsd-nat.c: Fix common/ includes.
9370 * guile/scm-type.c: Fix common/ includes.
9371 * guile/guile.c: Fix common/ includes.
9372 * go32-nat.c: Fix common/ includes.
9373 * gnu-nat.c: Fix common/ includes.
9374 * gdbthread.h: Fix common/ includes.
9375 * gdbarch-selftests.c: Fix common/ includes.
9376 * gdb_usleep.c: Fix common/ includes.
9377 * gdb_select.h: Fix common/ includes.
9378 * gdb_bfd.c: Fix common/ includes.
9379 * gcore.c: Fix common/ includes.
9380 * fork-child.c: Fix common/ includes.
9381 * findvar.c: Fix common/ includes.
9382 * fbsd-nat.c: Fix common/ includes.
9383 * event-top.c: Fix common/ includes.
9384 * event-loop.c: Fix common/ includes.
9385 * dwarf2read.c: Fix common/ includes.
9386 * dwarf2loc.c: Fix common/ includes.
9387 * dwarf2-frame.c: Fix common/ includes.
9388 * dwarf-index-cache.c: Fix common/ includes.
9389 * dtrace-probe.c: Fix common/ includes.
9390 * disasm-selftests.c: Fix common/ includes.
9391 * defs.h: Fix common/ includes.
9392 * csky-tdep.c: Fix common/ includes.
9393 * cp-valprint.c: Fix common/ includes.
9394 * cp-support.h: Fix common/ includes.
9395 * cp-support.c: Fix common/ includes.
9396 * corelow.c: Fix common/ includes.
9397 * completer.h: Fix common/ includes.
9398 * completer.c: Fix common/ includes.
9399 * compile/compile.c: Fix common/ includes.
9400 * compile/compile-loc2c.c: Fix common/ includes.
9401 * compile/compile-cplus-types.c: Fix common/ includes.
9402 * compile/compile-cplus-symbols.c: Fix common/ includes.
9403 * command.h: Fix common/ includes.
9404 * cli/cli-dump.c: Fix common/ includes.
9405 * cli/cli-cmds.c: Fix common/ includes.
9406 * charset.c: Fix common/ includes.
9407 * build-id.c: Fix common/ includes.
9408 * btrace.h: Fix common/ includes.
9409 * btrace.c: Fix common/ includes.
9410 * breakpoint.h: Fix common/ includes.
9411 * breakpoint.c: Fix common/ includes.
9412 * ax.h:
9413 (enum agent_op): Fix common/ includes.
9414 * ax-general.c (struct aop_map): Fix common/ includes.
9415 * ax-gdb.c: Fix common/ includes.
9416 * auxv.c: Fix common/ includes.
9417 * auto-load.c: Fix common/ includes.
9418 * arm-tdep.c: Fix common/ includes.
9419 * arch/riscv.c: Fix common/ includes.
9420 * arch/ppc-linux-common.c: Fix common/ includes.
9421 * arch/i386.c: Fix common/ includes.
9422 * arch/arm.c: Fix common/ includes.
9423 * arch/arm-linux.c: Fix common/ includes.
9424 * arch/arm-get-next-pcs.c: Fix common/ includes.
9425 * arch/amd64.c: Fix common/ includes.
9426 * arch/aarch64.c: Fix common/ includes.
9427 * arch/aarch64-insn.c: Fix common/ includes.
9428 * arch-utils.c: Fix common/ includes.
9429 * amd64-windows-tdep.c: Fix common/ includes.
9430 * amd64-tdep.c: Fix common/ includes.
9431 * amd64-sol2-tdep.c: Fix common/ includes.
9432 * amd64-obsd-tdep.c: Fix common/ includes.
9433 * amd64-nbsd-tdep.c: Fix common/ includes.
9434 * amd64-linux-tdep.c: Fix common/ includes.
9435 * amd64-linux-nat.c: Fix common/ includes.
9436 * amd64-fbsd-tdep.c: Fix common/ includes.
9437 * amd64-fbsd-nat.c: Fix common/ includes.
9438 * amd64-dicos-tdep.c: Fix common/ includes.
9439 * amd64-darwin-tdep.c: Fix common/ includes.
9440 * agent.c: Fix common/ includes.
9441 * ada-lang.h: Fix common/ includes.
9442 * ada-lang.c: Fix common/ includes.
9443 * aarch64-tdep.c: Fix common/ includes.
9444
2f5c153e
TT
94452019-01-25 Tom Tromey <tom@tromey.com>
9446
9447 * common/create-version.sh: Use common/version.h.
9448
adc6a863
PA
94492019-01-24 Pedro Alves <palves@redhat.com>
9450
9451 * infrun.c (signal_stop, signal_print, signal_program)
9452 (signal_catch, signal_pass): Now arrays instead of pointers.
9453 (update_signals_program_target, do_target_resume)
9454 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9455 * linux-nat.c (linux_nat_target::pass_signals)
9456 (linux_nat_target::create_inferior, linux_nat_target::attach):
9457 Adjust.
9458 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9459 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9460 * procfs.c (procfs_target::pass_signals): Adjust.
9461 * record-full.c (record_full_target::resume): Adjust.
9462 * remote.c (remote_target::pass_signals)
9463 (remote_target::program_signals): Adjust.
9464 * target-debug.h (target_debug_print_signals): Now takes a
9465 gdb::array_view as parameter. Adjust.
9466 * target.h (target_ops) <pass_signals, program_signals>: Replace
9467 pointer and length parameters with gdb::array_view.
9468 (target_pass_signals, target_program_signals): Likewise.
9469 * target-delegates.c: Regenerate.
9470
3046d67a
PA
94712019-01-24 Pedro Alves <palves@redhat.com>
9472
9473 * common/forward-scope-exit.h
9474 (forward_scope_exit::forward_scope_exit): Pass arguments to
9475 m_bind_function directly, instead of creating a std::bind and
9476 copying that.
9477
353229bf
AH
94782019-01-24 Alan Hayward <alan.hayward@arm.com>
9479
9480 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9481 for static members.
9482 (pass_in_v_vfp_candidate): Likewise.
9483
311dc83a
TT
94842019-01-23 Tom Tromey <tom@tromey.com>
9485 Pedro Alves <palves@redhat.com>
9486
9487 * regcache.c (class regcache_invalidator): Remove.
9488 (regcache::raw_write): Use make_scope_exit.
9489
296bd123
TT
94902019-01-23 Tom Tromey <tom@tromey.com>
9491
9492 * ui-out.h (class ui_out_emit_type): Update comment.
9493
979a0d13
TT
94942019-01-23 Tom Tromey <tom@tromey.com>
9495
9496 * infrun.c (fetch_inferior_event): Update comment.
9497
d238133d
TT
94982019-01-23 Tom Tromey <tom@tromey.com>
9499 Pedro Alves <palves@redhat.com>
9500
9501 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9502 parameter.
9503 (fetch_inferior_event): Use SCOPE_EXIT.
9504
9505
9885e6bb
TT
95062019-01-23 Tom Tromey <tom@tromey.com>
9507 Pedro Alves <palves@redhat.com>
9508
9509 * infrun.c (disable_thread_events): Delete.
9510 (stop_all_threads): Use SCOPE_EXIT.
9511
286526c1
TT
95122019-01-23 Tom Tromey <tom@tromey.com>
9513 Pedro Alves <palves@redhat.com>
9514
9515 * symfile.c: Include forward-scope-exit.h.
9516 (clear_symtab_users_cleanup): Replace forward declaration with
9517 a FORWARD_SCOPE_EXIT.
9518 (syms_from_objfile_1): Use the forward_scope_exit and
9519 gdb::optional instead of cleanup_function.
9520 (reread_symbols): Use the forward_scope_exit instead of
9521 cleanup_function.
9522 (clear_symtab_users_cleanup): Remove function.
9523
1db93f14
TT
95242019-01-23 Tom Tromey <tom@tromey.com>
9525 Pedro Alves <palves@redhat.com>
9526
9527 * linux-nat.c: Include scope-exit.h.
9528 (cleanup_target_stop): Remove.
9529 (linux_nat_target::static_tracepoint_markers_by_strid): Use
9530 SCOPE_EXIT.
9531
2cc83d1e
TT
95322019-01-23 Tom Tromey <tom@tromey.com>
9533 Pedro Alves <palves@redhat.com>
9534
9535 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9536 (call_function_by_hand_dummy): Use SCOPE_EXIT.
9537
694c6bf5
TT
95382019-01-23 Tom Tromey <tom@tromey.com>
9539 Andrew Burgess <andrew.burgess@embecosm.com>
9540 Pedro Alves <palves@redhat.com>
9541
9542 * infrun.c (fetch_inferior_event): Use scope_exit.
9543 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9544 * top.c (execute_command): Use scope_exit.
9545 * breakpoint.c (bpstat_do_actions): Use scope_exit.
9546 * utils.c (do_bpstat_clear_actions_cleanup)
9547 (make_bpstat_clear_actions_cleanup): Remove.
9548
4c41382a
TT
95492019-01-23 Tom Tromey <tom@tromey.com>
9550 Pedro Alves <palves@redhat.com>
9551
9552 * infrun.c: Include "common/scope-exit.h"
9553 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9554 (wait_for_inferior): Use SCOPE_EXIT.
9555 (fetch_inferior_event): Use scope_exit.
9556
89f8fb50
TT
95572019-01-23 Tom Tromey <tom@tromey.com>
9558 Pedro Alves <palves@redhat.com>
9559
9560 * breakpoint.c (create_breakpoint): Remove cleanup.
9561
5419bdae
TT
95622019-01-23 Tom Tromey <tom@tromey.com>
9563 Andrew Burgess <andrew.burgess@embecosm.com>
9564 Pedro Alves <palves@redhat.com>
9565
e587ef42
PA
95662019-01-23 Pedro Alves <palves@redhat.com>
9567
9568 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9569
77f0e74c
PA
95702019-01-23 Pedro Alves <palves@redhat.com>
9571 Andrew Burgess <andrew.burgess@embecosm.com>
9572
9573 * gdbthread.h: Include "common/forward-scope-exit.h".
9574 (scoped_finish_thread_state): Redefine custom class in terms of
9575 forward_scope_exit.
9576
5b9b3e53
PA
95772019-01-23 Pedro Alves <palves@redhat.com>
9578 Andrew Burgess <andrew.burgess@embecosm.com>
9579
9580 * common/forward-scope-exit.h: New file.
9581
54b65c9b
PA
95822019-01-23 Pedro Alves <palves@redhat.com>
9583 Andrew Burgess <andrew.burgess@embecosm.com>
9584 Tom Tromey <tom@tromey.com>
9585
9586 * common/scope-exit.h: New file.
9587
cf08fb29
PA
95882019-01-23 Pedro Alves <palves@redhat.com>
9589
9590 * common/preprocessor.h (ESC): Rename to ...
9591 (ESC_PARENS): ... this.
9592 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9593 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9594
ae73e2e2
TT
95952019-01-23 Tom Tromey <tom@tromey.com>
9596
9597 * language.h (class scoped_switch_to_sym_language_if_auto):
9598 Initialize m_lang in both cases.
9599
6594e122
AH
96002019-01-23 Alan Hayward <alan.hayward@arm.com>
9601
9602 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9603 with XCNEW.
9604
a7c9855d
TT
96052019-01-22 Tom Tromey <tom@tromey.com>
9606
9607 * corelow.c: Do not include sys/file.h.
9608
93cc1d53
TT
96092019-01-22 Tom Tromey <tom@tromey.com>
9610
9611 * tui/tui-wingeneral.h: Include gdb_curses.h.
9612
38561778
TT
96132019-01-22 Tom Tromey <tom@tromey.com>
9614
9615 * source-cache.h (class source_cache) <get_source_lines,
9616 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9617
37b3ab5b
TT
96182019-01-22 Tom Tromey <tom@tromey.com>
9619
9620 * remote-fileio.h (struct remote_target): Declare.
9621
3fabc016
TT
96222019-01-22 Tom Tromey <tom@tromey.com>
9623
9624 * python/py-arch.c: Do not include py-ref.h.
9625 * python/py-bpevent.c: Do not include py-ref.h.
9626 * python/py-cmd.c: Do not include py-ref.h.
9627 * python/py-continueevent.c: Do not include py-ref.h.
9628 * python/py-event.h: Do not include py-ref.h.
9629 * python/py-evtregistry.c: Do not include py-ref.h.
9630 * python/py-finishbreakpoint.c: Do not include py-ref.h.
9631 * python/py-frame.c: Do not include py-ref.h.
9632 * python/py-framefilter.c: Do not include py-ref.h.
9633 * python/py-function.c: Do not include py-ref.h.
9634 * python/py-infevents.c: Do not include py-ref.h.
9635 * python/py-linetable.c: Do not include py-ref.h.
9636 * python/py-objfile.c: Do not include py-ref.h.
9637 * python/py-param.c: Do not include py-ref.h.
9638 * python/py-prettyprint.c: Do not include py-ref.h.
9639 * python/py-progspace.c: Do not include py-ref.h.
9640 * python/py-symbol.c: Do not include py-ref.h.
9641 * python/py-symtab.c: Do not include py-ref.h.
9642 * python/py-type.c: Do not include py-ref.h.
9643 * python/py-unwind.c: Do not include py-ref.h.
9644 * python/py-utils.c: Do not include py-ref.h.
9645 * python/py-value.c: Do not include py-ref.h.
9646 * python/py-varobj.c: Do not include py-ref.h.
9647 * python/py-xmethods.c: Do not include py-ref.h.
9648 * python/python.c: Do not include py-ref.h.
9649 * varobj.c: Do not include py-ref.h.
9650
6b4d7774
TT
96512019-01-22 Tom Tromey <tom@tromey.com>
9652
9653 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9654 keyword for bcache.
9655
7af7e9b5
TT
96562019-01-22 Tom Tromey <tom@tromey.com>
9657
9658 * compile/compile-cplus-types.c: Remove a comment by #include.
9659
951d1049
TT
96602019-01-22 Tom Tromey <tom@tromey.com>
9661
9662 * compile/gcc-c-plugin.h: Include compile-internal.h.
9663
d65d5705
TT
96642019-01-22 Tom Tromey <tom@tromey.com>
9665
9666 * stabsread.c (EXTERN): Do not define.
9667 (symnum, next_symbol_text_func, processing_gcc_compilation)
9668 (within_function, global_sym_chain, global_stabs)
9669 (previous_stab_code, this_object_header_files)
9670 (n_this_object_header_files)
9671 (n_allocated_this_object_header_files): Define.
9672 * stabsread.h (EXTERN): Never define. Use "extern".
9673
b6fb1ee5
PW
96742019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9675
9676 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9677 history_value.
9678
be6d4f74
TT
96792019-01-21 Tom Tromey <tom@tromey.com>
9680
9681 * ui-out.c: Fix includes.
9682 * tui/tui-source.c: Fix includes.
9683 * target.c: Fix includes.
9684 * remote.c: Fix includes.
9685 * regcache.c: Fix includes.
9686 * python/py-block.c: Fix includes.
9687 * printcmd.c: Fix includes.
9688 * or1k-tdep.c: Fix includes.
9689 * mi/mi-main.c: Fix includes.
9690 * m32r-tdep.c: Fix includes.
9691 * csky-tdep.c: Fix includes.
9692 * compile/compile-cplus-types.c: Fix includes.
9693 * cli/cli-interp.c: Fix includes.
9694
73021deb
AH
96952019-01-21 Alan Hayward <alan.hayward@arm.com>
9696
9697 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9698 for padding.
9699
7932255d
TT
97002019-01-16 Tom Tromey <tom@tromey.com>
9701
9702 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
9703 earlier.
9704 (struct objfile) <msymbols_range>: Move from top level.
9705 <msymbols>: New method.
9706 (class objfile_msymbols): Remove.
9707 * symtab.c (default_collect_symbol_completion_matches_break_on):
9708 Update.
9709 * symmisc.c (dump_msymbols): Update.
9710 * stabsread.c (scan_file_globals): Update.
9711 * objc-lang.c (info_selectors_command, info_classes_command)
9712 (find_methods): Update.
9713 * minsyms.c (find_solib_trampoline_target): Update.
9714 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9715 * coffread.c (coff_symfile_read): Update.
9716 * ada-lang.c (ada_lookup_simple_minsym)
9717 (ada_collect_symbol_completion_matches): Update.
9718
604b1bfb
TT
97192019-01-16 Tom Tromey <tom@tromey.com>
9720
9721 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9722 type. Remove no-argument constructor.
9723 <iterator::operator++>: Simplify.
9724 <begin>: Update.
9725 <end>: Use minimal_symbol_count.
9726
f252c6d5
TT
97272019-01-16 Tom Tromey <tom@tromey.com>
9728
9729 * objfiles.h (struct objfile) <psymtabs>: New method.
9730 (class objfile_psymtabs): Remove.
9731 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9732 typedef.
9733 <range>: New method.
9734 (require_partial_symbols): Change return type.
9735 * psymtab.c (require_partial_symbols)
9736 (psym_expand_symtabs_matching): Update.
9737 * mdebugread.c (parse_partial_symbols): Update.
9738 * dbxread.c (dbx_end_psymtab): Update.
9739
b669c953
TT
97402019-01-15 Tom Tromey <tom@tromey.com>
9741
9742 * symtab.c (lookup_objfile_from_block)
9743 (lookup_symbol_in_objfile_symtabs)
9744 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9745 (find_line_symtab, info_sources_command)
9746 (default_collect_symbol_completion_matches_break_on)
9747 (make_source_files_completion_list): Update.
9748 * symmisc.c (print_objfile_statistics, dump_objfile)
9749 (maintenance_print_symbols, maintenance_info_symtabs)
9750 (maintenance_check_symtabs, maintenance_info_line_tables):
9751 Update.
9752 * source.c (select_source_symtab)
9753 (forget_cached_source_info_for_objfile): Update.
9754 * objfiles.h (class objfile_compunits): Remove.
9755 (struct objfile) <compunits_range>: New typedef.
9756 (compunits): New method.
9757 * objfiles.c (objfile_relocate1): Update.
9758 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9759 * maint.c (count_symtabs_and_blocks): Update.
9760 * linespec.c (iterate_over_all_matching_symtabs): Update.
9761 * cp-support.c (add_symbol_overload_list_qualified): Update.
9762 * coffread.c (coff_symtab_read): Update.
9763 * ada-lang.c (add_nonlocal_symbols)
9764 (ada_collect_symbol_completion_matches)
9765 (ada_add_global_exceptions): Update.
9766
7e955d83
TT
97672019-01-15 Tom Tromey <tom@tromey.com>
9768
9769 * progspace.h (program_space) <objfiles_safe_range>: New
9770 typedef.
9771 <objfiles_safe>: New method.
9772 * objfiles.h (class all_objfiles_safe): Remove.
9773 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9774 * jit.c (jit_inferior_exit_hook): Update.
9775
2030c079
TT
97762019-01-17 Tom Tromey <tom@tromey.com>
9777
9778 * progspace.h (program_space) <objfiles_range>: New typedef.
9779 <objfiles>: New method.
9780 <objfiles_head>: Rename from objfiles.
9781 (object_files): Update.
9782 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9783 * guile/scm-pretty-print.c
9784 (ppscm_find_pretty_printer_from_objfiles): Update.
9785 * guile/scm-objfile.c (gdbscm_objfiles): Update.
9786 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9787 Update.
9788 * python/py-progspace.c (pspy_get_objfiles): Update.
9789 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9790 Update.
9791 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9792 (objfpy_lookup_objfile_by_build_id): Update.
9793 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9794 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9795 Update.
9796 * symtab.c (iterate_over_symtabs, matching_obj_sections)
9797 (expand_symtab_containing_pc, lookup_objfile_from_block)
9798 (lookup_static_symbol, basic_lookup_transparent_type)
9799 (find_pc_sect_compunit_symtab, find_symbol_at_address)
9800 (find_line_symtab, info_sources_command)
9801 (default_collect_symbol_completion_matches_break_on)
9802 (make_source_files_completion_list, find_main_name): Update.
9803 * symmisc.c (print_symbol_bcache_statistics)
9804 (print_objfile_statistics, maintenance_print_symbols)
9805 (maintenance_print_msymbols, maintenance_print_objfiles)
9806 (maintenance_info_symtabs, maintenance_check_symtabs)
9807 (maintenance_expand_symtabs, maintenance_info_line_tables):
9808 Update.
9809 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9810 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9811 (map_overlay_command, unmap_overlay_command)
9812 (simple_overlay_update, expand_symtabs_matching)
9813 (map_symbol_filenames): Update.
9814 * symfile-debug.c (set_debug_symfile): Update.
9815 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9816 Update.
9817 * source.c (select_source_symtab, forget_cached_source_info):
9818 Update.
9819 * solib.c (solib_read_symbols): Update.
9820 * solib-spu.c (append_ocl_sos): Update.
9821 * psymtab.c (maintenance_print_psymbols)
9822 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9823 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9824 * printcmd.c (info_symbol_command): Update.
9825 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9826 Update.
9827 * objfiles.h (class all_objfiles): Remove.
9828 * objfiles.c (have_partial_symbols, have_full_symbols)
9829 (have_minimal_symbols, qsort_cmp, update_section_map)
9830 (shared_objfile_contains_address_p)
9831 (default_iterate_over_objfiles_in_search_order): Update.
9832 * objc-lang.c (info_selectors_command, info_classes_command)
9833 (find_methods): Update.
9834 * minsyms.c (find_solib_trampoline_target): Update.
9835 * maint.c (maintenance_info_sections)
9836 (maintenance_translate_address, count_symtabs_and_blocks):
9837 Update.
9838 * main.c (captured_main_1): Update.
9839 * linux-thread-db.c (try_thread_db_load_from_pdir)
9840 (has_libpthread): Update.
9841 * linespec.c (iterate_over_all_matching_symtabs)
9842 (search_minsyms_for_name): Update.
9843 * jit.c (jit_find_objf_with_entry_addr): Update.
9844 * hppa-tdep.c (find_unwind_entry)
9845 (hppa_lookup_stub_minimal_symbol): Update.
9846 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9847 Update.
9848 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9849 (elf_gnu_ifunc_resolve_by_got): Update.
9850 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9851 * dwarf-index-write.c (save_gdb_index_command): Update.
9852 * cp-support.c (add_symbol_overload_list_qualified): Update.
9853 * breakpoint.c (create_overlay_event_breakpoint)
9854 (create_longjmp_master_breakpoint)
9855 (create_std_terminate_master_breakpoint)
9856 (create_exception_master_breakpoint): Update.
9857 * blockframe.c (find_pc_partial_function): Update.
9858 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9859 (ada_collect_symbol_completion_matches)
9860 (ada_add_global_exceptions): Update.
9861
776489e0
TT
98622019-01-17 Tom Tromey <tom@tromey.com>
9863
9864 * solib-target.c (lm_info_target_p): Remove typedef. Don't
9865 declare VEC.
9866 (solib_target_parse_libraries): Change return type.
9867 (library_list_start_segment, library_list_start_section)
9868 (library_list_end_library, library_list_start_library); Update.
9869 (solib_target_free_library_list): Remove.
9870 (solib_target_parse_libraries): Remove cleanup. Change return
9871 type.
9872 (solib_target_current_sos): Update.
9873
6471e7d2
TT
98742019-01-17 Tom Tromey <tromey@bapiya>
9875
9876 * valprint.c: Replace "the the" with "the".
9877 * symtab.c: Replace "the the" with "the".
9878 * solib.c: Replace "the the" with "the".
9879 * solib-dsbt.c: Replace "the the" with "the".
9880 * linespec.c: Replace "the the" with "the".
9881 * dwarf2loc.h: Replace "the the" with "the".
9882 * amd64-windows-tdep.c: Replace "the the" with "the".
9883 * aarch64-tdep.c: Replace "the the" with "the".
9884
c24bdb02
KS
98852019-01-16 Keith Seitz <keiths@redhat.com>
9886
9887 PR gdb/23773
9888 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9889 <builder>: Rename to ..
9890 <m_builder>: ... this and make private.
9891 (dwarf2_cu::get_builder): New method. Change all users of
9892 `builder' to use this method.
9893 (dwarf2_start_symtab): Move to ...
9894 (dwarf2_cu::start_symtab): ... here. Update all callers
9895 (setup_type_unit_groups): Move to ...
9896 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
9897 callers.
9898 (dwarf2_cu::reset_builder): New method.
9899 (process_full_compunit, process_full_type_unit): Use
9900 dwarf2_cu::reset_builder.
9901 (follow_die_offset): Record the ancestor CU if it is different
9902 from the followed DIE's CU.
9903 (follow_die_sig_1): Likewise.
9904
8d64371b
TT
99052019-01-15 Tom Tromey <tom@tromey.com>
9906
9907 * remote.c (class remote_state) <buf>: Now a char_vector.
9908 <buf_size>: Remove.
9909 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
9910 parameter.
9911 (remote_target::getpkt_or_notif_sane_1)
9912 (remote_target::getpkt_sane)
9913 (remote_target::getpkt_or_notif_sane): Likewise.
9914 (class remote_target) <putpkt>: New overload.
9915 (remote_target::read_frame): Change type of "buf_p". Remove
9916 sizeof_p parameter.
9917 (packet_ok): New overload.
9918 (packet_check_result): New overload.
9919 Update all uses.
9920
bb277751
TT
99212019-01-14 Tom Tromey <tom@tromey.com>
9922
9923 * remote-notif.c (handle_notification, remote_notif_ack)
9924 (remote_notif_parse): Make "buf" const.
9925 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9926 const.
9927 (remote_notif_parse, remote_notif_ack, handle_notification):
9928 Likewise.
9929 * remote.c (remote_notif_stop_parse): Make "buf" const.
9930 (remote_target::remote_parse_stop_reply): Make "buf" const.
9931 (remote_notif_stop_ack): Make "buf" const.
9932
05be00a8
TT
99332019-01-14 Tom Tromey <tom@tromey.com>
9934
9935 * remote.c (remote_console_output): Make parameter const.
9936
491adeca
TT
99372019-01-14 Tom Tromey <tom@tromey.com>
9938
9939 * target-debug.h (target_debug_print_signals): Constify.
9940 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9941 * procfs.c (procfs_target::pass_signals): Update.
9942 * linux-nat.c (linux_nat_target::pass_signals): Update.
9943 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9944 * target-delegates.c: Rebuild.
9945 * remote.c (remote_target::program_signals): Update.
9946 (remote_target::pass_signals): Update.
9947 * target.c (target_pass_signals): Constify argument.
9948 (target_program_signals): Likewise.
9949 * target.h (struct target_ops) <pass_signals, program_signals>:
9950 Constify argument.
9951 (target_pass_signals, target_program_signals): Constify argument.
9952
bbd94648
TT
99532019-01-14 Tom Tromey <tom@tromey.com>
9954
9955 PR tui/28819:
9956 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9957
6f072a10
PFC
99582019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
9959
9960 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9961 field.
9962 * rs6000-tdep.c: Include reggroups.h.
9963 (IS_V_ALIAS_PSEUDOREG): Define.
9964 (rs6000_register_name): Return names for the "vX" aliases.
9965 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9966 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
9967 aliases. Call default_register_reggroup_p for all other
9968 pseudo-registers.
9969 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9970 New functions.
9971 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9972 Handle "vX" aliases.
9973 (v_alias_pseudo_register_collect): New function.
9974 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9975 (rs6000_gdbarch_init): Initialize "vX" aliases as
9976 pseudo-registers. Restore registration of
9977 rs6000_pseudo_register_reggroup_p with
9978 set_tdesc_pseudo_register_reggroup_p.
9979
1a782351
MF
99802019-01-13 Max Filippov <jcmvbkbc@gmail.com>
9981
9982 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9983 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9984 set_gdbarch_num_pseudo_regs.
9985
d73cff18
PW
99862019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9987
9988 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9989 Remove arg prefixname, add do_set and do_show.
9990 Add member functions set_list and show_list.
9991 * cli/cli-style.c (class cli_style_option): Update accordingly.
9992 (style_set_list): Move to file scope.
9993 (style_show_list): Likewise.
9994 (set_style): Call help_list.
9995 (show_style): Call cmd_show_list.
9996 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9997 Update to use the new macro.
9998
60a90376
JB
99992019-10-12 Joel Brobecker <brobecker@adacore.com>
10000
10001 * ada-lang.c (_initialize_ada_language): Expand the help text
10002 for the "catch exception" command.
10003
9d7c67bf
PW
100042019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10005
10006 * symtab.c (matching_obj_sections): Initialize obj,
10007 declare it closer to its usage.
10008
7cf47dc4
TT
100092019-01-10 Tom Tromey <tom@tromey.com>
10010
10011 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10012 (basic_inf_threads_range): Remove.
10013 (inf_threads_range, inf_non_exited_threads_range)
10014 (safe_inf_threads_range): Use next_adapter.
10015
d3cb6808
KS
100162019-01-10 Keith Seitz <keiths@redhat.com>
10017
10018 PR gdb/23712
10019 PR symtab/23010
10020 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10021 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10022
63a20375
KS
100232019-01-10 Keith Seitz <keiths@redhat.com>
10024
10025 PR gdb/23712
10026 PR symtab/23010
10027 * dictionary.c (pending_to_vector): Remove.
10028 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10029 Remove _1 suffix, replacing functions of the same name. Update
10030 all callers.
10031 (dict_create_hashed, dict_create_hashed_expandable)
10032 (dict_create_linear, dict_create_linear_expandable, dict_free)
10033 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10034 Make functions static.
10035
b026f593
KS
100362019-01-10 Keith Seitz <keiths@redhat.com>
10037
10038 PR gdb/23712
10039 PR symtab/23010
10040 * dictionary.h (struct dictionary): Replace declaration with
10041 multidictionary.
10042 (dict_create_hashed, dict_create_hashed_expandable)
10043 (dict_create_linear, dict_create_linear_expandable)
10044 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10045 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10046 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10047 taking multidictionary argument.
10048 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10049 * block.h (struct block) <dict>: Change to multidictionary
10050 and rename `multidict'.
10051 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10052 symmisc.c: Update all dictionary references to multidictionary.
10053
c7748ee9
KS
100542019-01-10 Keith Seitz <keiths@redhat.com>
10055
10056 PR gdb/23712
10057 PR symtab/23010
10058 * dictionary.c: Include unordered_map.
10059 (pending_to_vector): New function.
10060 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10061 Rewrite the non-"_1" functions to take vector instead
10062 of linked list.
10063 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10064 "new" _1 versions of the same name.
10065 (multidictionary): Define.
10066 (std::hash<enum language): New definition.
10067 (collate_pending_symbols_by_language, mdict_create_hashed)
10068 (mdict_create_hashed_expandable, mdict_create_linear)
10069 (mdict_create_linear_expandable, mdict_free)
10070 (find_language_dictionary, create_new_language_dictionary)
10071 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10072 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10073 (mdict_size, mdict_empty): New functions.
10074 * dictionary.h (mdict_iterator): Define.
10075
67aa1f3c
PA
100762019-01-10 Pedro Alves <palves@redhat.com>
10077
10078 * breakpoint.c (read_uploaded_action)
10079 (create_tracepoint_from_upload): Adjust to use
10080 gdb::unique_xmalloc_ptr.
10081 * ctf.c (ctf_write_uploaded_tp):
10082 (SET_ARRAY_FIELD): Use emplace_back.
10083 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10084 * tracefile-tfile.c (tfile_write_uploaded_tp):
10085 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10086 gdb::unique_xmalloc_ptr.
10087 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10088 at_string, cond_string, cmd_strings>: Replace char pointers
10089 with gdb::unique_xmalloc_ptr.
10090
2f667667
PA
100912019-01-10 Pedro Alves <palves@redhat.com>
10092
10093 * solib-target.c (library_list_start_library): Don't xstrdup name.
10094
36cb7237
PA
100952019-01-10 Pedro Alves <palves@redhat.com>
10096
10097 * mdebugread.c (parse_partial_symbols): Use
10098 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10099
da584958
AB
101002019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10101
10102 * linux-fork.c (scoped_switch_fork_info)
10103 <~scoped_switch_fork_info>: Fix incorrect variable name.
10104
1ef8573c
AB
101052019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10106
10107 * linux-fork.c (scoped_switch_fork_info)
10108 <scoped_switch_fork_info>: Make explicit.
10109 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10110
8d7bcccb
TT
101112019-01-10 Tom Tromey <tom@tromey.com>
10112
10113 * objfiles.h (objfile::reset_psymtabs): Update.
10114 * objfiles.c (objfile::objfile): Update.
10115 * psymtab.h (psymtab_storage::obstack): Update.
10116 (psymtab_storage::m_obstack): Use gdb::optional.
10117 (class psymtab_storage): Update comment. Remove objfile
10118 parameter.
10119 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10120
b596a3c7
TT
101212019-01-10 Tom Tromey <tom@tromey.com>
10122
10123 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10124 <free_psymtabs>: Now private.
10125 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10126 (allocate_psymtab): Use new method.
10127
a9342b62
TT
101282019-01-10 Tom Tromey <tom@tromey.com>
10129
10130 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10131 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10132 * mdebugread.c (parse_partial_symbols): Use
10133 allocate_dependencies.
10134 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10135 allocate_dependencies.
10136 (process_psymtab_comp_unit_reader)
10137 (build_type_psymtab_dependencies): Likewise.
10138 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10139
5af70966
TT
101402019-01-10 Tom Tromey <tom@tromey.com>
10141
10142 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10143 PSYMBOL_SET_LANGUAGE.
10144 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10145
5923a04c
TT
101462019-01-10 Tom Tromey <tom@tromey.com>
10147
10148 * psymtab.h (psymtab_storage::obstack): New method.
10149 <m_obstack>: Rename from obstack; now private.
10150 * psymtab.c (psymtab_storage): Update.
10151 * dwarf2read.c (create_addrmap_from_index)
10152 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10153 Update.
10154
6d6a12bf
TT
101552019-01-10 Tom Tromey <tom@tromey.com>
10156
10157 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10158 * objfiles.h (objfile::reset_psymtabs): New method.
10159
d320c2b5
TT
101602019-01-10 Tom Tromey <tom@tromey.com>
10161
10162 * symmisc.c (print_symbol_bcache_statistics): Update.
10163 (print_objfile_statistics): Update.
10164 * symfile.c (reread_symbols): Update.
10165 * psymtab.h (class psymtab_storage): New.
10166 * psymtab.c (psymtab_storage): New constructor.
10167 (~psymtab_storage): New destructor.
10168 (require_partial_symbols): Update.
10169 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10170 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10171 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10172 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10173 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10174 (start_psymtab_common, end_psymtab_common)
10175 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10176 (allocate_psymtab): Update.
10177 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10178 Update.
10179 (dump_psymtab_addrmap, maintenance_print_psymbols)
10180 (maintenance_check_psymtabs): Update.
10181 (class objfile_psymtabs): Move to objfiles.h.
10182 * psympriv.h (discard_psymtab): Now inline.
10183 (psymtab_discarder::psymtab_discarder): Update.
10184 (psymtab_discarder::~psymtab_discarder): Update.
10185 (ALL_OBJFILE_PSYMTABS): Rewrite.
10186 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10187 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10188 Remove fields.
10189 <partial_symtabs>: New field.
10190 (class objfile_psymtabs): Move from psymtab.h. Update.
10191 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10192 psymbol_cache.
10193 (objfile::~objfile): Don't destroy psymbol_cache.
10194 * mdebugread.c (parse_partial_symbols): Update.
10195 * dwarf2read.c (create_addrmap_from_index)
10196 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10197 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10198 (add_partial_subprogram, dwarf2_ranges_read): Update.
10199 * dwarf-index-write.c (write_address_map)
10200 (write_one_signatured_type, recursively_write_psymbols)
10201 (class debug_names, class debug_names, write_psymtabs_to_index):
10202 Update.
10203
1d94a5a3
TT
102042019-01-10 Tom Tromey <tom@tromey.com>
10205
10206 * symtab.h (SYMBOL_SET_NAMES): Update.
10207 (symbol_set_names): Update.
10208 (MSYMBOL_SET_NAMES): Update.
10209 * symtab.c (symbol_set_names): Change argument to be an
10210 objfile_per_bfd_storage.
10211 * psymtab.c (add_psymbol_to_bcache): Update.
10212 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10213
0f14768a
TT
102142019-01-10 Tom Tromey <tom@tromey.com>
10215
10216 * symtab.c (create_demangled_names_hash): Change argument to be an
10217 objfile_per_bfd_storage.
10218 (symbol_set_names): Update.
10219
6eee24ce
TT
102202019-01-10 Tom Tromey <tom@tromey.com>
10221
10222 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10223 init_psymbol_list.
10224 * psymtab.c (init_psymbol_list): Do nothing if already called.
10225 * psympriv.h (init_psymbol_list): Add comment.
10226 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10227 init_psymbol_list.
10228 * dbxread.c (dbx_symfile_read): Unconditionally call
10229 init_psymbol_list.
10230
75aedd27
TT
102312019-01-10 Tom Tromey <tom@tromey.com>
10232
10233 * xcoffread.c (scan_xcoff_symtab): Update.
10234 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10235 "where".
10236 * mdebugread.c (parse_partial_symbols)
10237 (handle_psymbol_enumerators): Update.
10238 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10239 * dbxread.c (read_dbx_symtab): Update.
10240 * psympriv.h (psymbol_placement): New enum.
10241 (add_psymbol_to_list): Update.
10242
939652a5
TT
102432019-01-10 Tom Tromey <tom@tromey.com>
10244
10245 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10246 static_psymbols parameters.
10247 (scan_xcoff_symtab): Update.
10248 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10249 static_psymbols parameters.
10250 * psympriv.h (start_psymtab_common): Update.
10251 * mdebugread.c (parse_partial_symbols): Update.
10252 * dwarf2read.c (create_partial_symtab): Update.
10253 * dbxread.c (read_dbx_symtab): Update.
10254 (start_psymtab): Remove global_psymbols and static_psymbols
10255 parameters.
10256
baa62830
TT
102572019-01-10 Tom Tromey <tom@tromey.com>
10258
10259 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10260 * psymtab.c (allocate_psymtab): Add comment.
10261 * psympriv.h (allocate_psymtab): Add comment.
10262 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10263 initializations.
10264 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10265
0e8f53ba
TT
102662019-01-10 Tom Tromey <tom@tromey.com>
10267
10268 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10269 Don't declare.
10270 * mipsread.c: Include mdebugread.h.
10271 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10272 Declare.
10273 * elfread.c: Include mdebugread.h.
10274
b22a7c6a
TT
102752019-01-09 Tom Tromey <tom@tromey.com>
10276
10277 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10278 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10279 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10280 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10281 (psym_lookup_symbol, psym_find_last_source_symtab)
10282 (psym_forget_cached_source_info, psym_print_stats)
10283 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10284 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10285 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10286 (psym_find_compunit_symtab_by_address)
10287 (maintenance_print_psymbols, maintenance_info_psymtabs)
10288 (maintenance_check_psymtabs): Use ranged for.
10289 * psymtab.h (class objfile_psymtabs): New.
10290 (require_partial_symbols): Return objfile_psymtabs.
10291 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10292
3b9d3ac2
TT
102932019-01-09 Tom Tromey <tom@tromey.com>
10294
10295 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10296 (find_pc_mapped_section, list_overlays_command)
10297 (map_overlay_command, unmap_overlay_command)
10298 (simple_overlay_update): Use all_objfiles.
10299 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10300 * printcmd.c (info_symbol_command): Use all_objfiles.
10301 * objfiles.h (ALL_OBJSECTIONS): Remove.
10302 * maint.c (maintenance_translate_address): Use all_objfiles.
10303 * gcore.c (gcore_create_callback): Use all_objfiles.
10304 (objfile_find_memory_regions): Likewise.
10305
8b31193a
TT
103062019-01-09 Tom Tromey <tom@tromey.com>
10307
10308 * symtab.c (find_line_symtab, info_sources_command)
10309 (make_source_files_completion_list): Use objfile_compunits.
10310 * source.c (select_source_symtab): Use objfile_compunits.
10311 * objfiles.h (struct objfile): Update comment.
10312 (ALL_OBJFILES): Remove.
10313 (ALL_FILETABS): Remove.
10314 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10315 objfile_compunits.
10316
d5da8b3c
TT
103172019-01-09 Tom Tromey <tom@tromey.com>
10318
10319 * symmisc.c (print_objfile_statistics, dump_objfile)
10320 (maintenance_print_symbols): Use compunit_filetabs.
10321 * source.c (forget_cached_source_info_for_objfile): Use
10322 compunit_filetabs.
10323 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10324 (ALL_FILETABS): Use compunit_filetabs.
10325 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10326 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10327
5accd1a0
TT
103282019-01-09 Tom Tromey <tom@tromey.com>
10329
10330 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10331 (compunit_filetabs): New.
10332 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10333 compunit_filetabs.
10334 (info_sources_command, make_source_files_completion_list): Remove
10335 declaration.
10336 * symmisc.c (print_objfile_statistics, dump_objfile)
10337 (maintenance_print_symbols): Remove declaration.
10338 (maintenance_info_symtabs): Use compunit_filetabs.
10339 (maintenance_info_line_tables): Likewise.
10340 * source.c (select_source_symtab): Change local variable name.
10341 (forget_cached_source_info_for_objfile): Remove declaration.
10342 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10343 * objfiles.c (objfile_relocate1): Remove declaration.
10344 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10345 declaration.
10346 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10347 * coffread.c (coff_symtab_read): Remove declaration.
10348 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10349 compunit_filetabs.
10350
d8aeb77f
TT
103512019-01-09 Tom Tromey <tom@tromey.com>
10352
10353 * symtab.c (lookup_objfile_from_block)
10354 (find_pc_sect_compunit_symtab, search_symbols)
10355 (default_collect_symbol_completion_matches_break_on): Use
10356 objfile_compunits.
10357 * objfiles.h (ALL_COMPUNITS): Remove.
10358 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10359 * cp-support.c (add_symbol_overload_list_qualified): Use
10360 objfile_compunits.
10361 * ada-lang.c (ada_collect_symbol_completion_matches)
10362 (ada_add_global_exceptions): Use objfile_compunits.
10363
592553c4
TT
103642019-01-09 Tom Tromey <tom@tromey.com>
10365
10366 * source.c (select_source_symtab)
10367 (forget_cached_source_info_for_objfile): Remove declaration.
10368 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10369 declaration.
10370 * maint.c (count_symtabs_and_blocks): Remove declaration.
10371 * cp-support.c (add_symbol_overload_list_qualified): Remove
10372 declaration.
10373 * coffread.c (coff_symtab_read): Remove declaration.
10374 * symtab.c (lookup_symbol_in_objfile_symtabs)
10375 (basic_lookup_transparent_type_1): Use objfile_compunits.
10376 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10377 (info_sources_command, search_symbols)
10378 (default_collect_symbol_completion_matches_break_on)
10379 (make_source_files_completion_list): Remove declaration.
10380 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10381 (ada_collect_symbol_completion_matches)
10382 (ada_add_global_exceptions): Remove declaration.
10383 * linespec.c (iterate_over_all_matching_symtabs): Use
10384 objfile_compunits.
10385 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10386 (class objfile_compunits): New.
10387 (ALL_COMPUNITS): Use objfile_compunits.
10388 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10389 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10390 objfile_compunits.
10391 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10392
5325b9bf
TT
103932019-01-09 Tom Tromey <tom@tromey.com>
10394
10395 * symtab.c (search_symbols)
10396 (default_collect_symbol_completion_matches_break_on): Use
10397 objfile_msymbols.
10398 * ada-lang.c (ada_lookup_simple_minsym)
10399 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10400 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10401 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10402 objfile_msymbols.
10403 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10404 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10405 * objc-lang.c (find_methods): Use objfile_msymbols.
10406 (info_selectors_command, info_classes_command): Likewise.
10407 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10408 * objfiles.h (class objfile_msymbols): New.
10409 (ALL_OBJFILE_MSYMBOLS): Remove.
10410 (ALL_MSYMBOLS): Remove.
10411
cac85af2
TT
104122019-01-09 Tom Tromey <tom@tromey.com>
10413
10414 * common/next-iterator.h (next_adapter): Add Iterator template
10415 parameter.
10416 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10417 (class all_objfiles_safe): New.
10418 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10419 * objfiles.c (put_objfile_before): Update comment.
10420 (add_separate_debug_objfile): Likewise.
10421 (free_all_objfiles): Use all_objfiles_safe.
10422 (objfile_purge_solibs): Likewise.
10423
aed57c53
TT
104242019-01-09 Tom Tromey <tom@tromey.com>
10425
10426 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10427 (expand_symtab_containing_pc, lookup_static_symbol)
10428 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10429 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10430 all_objfiles.
10431 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10432 * breakpoint.c (create_overlay_event_breakpoint)
10433 (create_longjmp_master_breakpoint)
10434 (create_std_terminate_master_breakpoint)
10435 (create_exception_master_breakpoint): Use all_objfiles.
10436 * linux-thread-db.c (try_thread_db_load_from_pdir)
10437 (has_libpthread): Use all_objfiles.
10438 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10439 * linespec.c (iterate_over_all_matching_symtabs)
10440 (search_minsyms_for_name): Use all_objfiles.
10441 * maint.c (maintenance_info_sections): Use all_objfiles.
10442 * main.c (captured_main_1): Use all_objfiles.
10443 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10444 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10445 * guile/scm-pretty-print.c
10446 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10447 * solib-spu.c (append_ocl_sos): Use all_objfiles.
10448 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10449 (maintenance_print_msymbols): Use all_objfiles.
10450 * source.c (select_source_symtab): Use all_objfiles.
10451 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10452 * symfile.c (remove_symbol_file_command)
10453 (expand_symtabs_matching, map_symbol_filenames): Use
10454 all_objfiles.
10455 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10456 all_objfiles.
10457 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10458 * objc-lang.c (find_methods): Use all_objfiles.
10459 * objfiles.c (have_partial_symbols, have_full_symbols)
10460 (have_minimal_symbols, qsort_cmp)
10461 (default_iterate_over_objfiles_in_search_order): Use
10462 all_objfiles.
10463 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10464 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10465 (maintenance_check_psymtabs): Use all_objfiles.
10466 (ALL_PSYMTABS): Remove.
10467 * compile/compile-object-run.c (do_module_cleanup): Use
10468 all_objfiles.
10469 * blockframe.c (find_pc_partial_function): Use all_objfiles.
10470 * cp-support.c (add_symbol_overload_list_qualified): Use
10471 all_objfiles.
10472 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10473 Use all_objfiles.
10474 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10475 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10476 all_objfiles.
10477 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10478 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10479 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10480 Uses all_objfiles.
10481 * solib.c (solib_read_symbols): Use all_objfiles
10482
99d89cde
TT
104832019-01-09 Tom Tromey <tom@tromey.com>
10484
10485 * probe.c (parse_probes_in_pspace): Use all_objfiles.
10486 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10487 all_objfiles.
10488 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10489 * symmisc.c (print_symbol_bcache_statistics)
10490 (print_objfile_statistics, maintenance_print_objfiles)
10491 (maintenance_info_symtabs, maintenance_check_symtabs)
10492 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10493 all_objfiles.
10494 * source.c (forget_cached_source_info): Use all_objfiles.
10495 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10496 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10497 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10498 * objfiles.c (update_section_map): Use all_objfiles.
10499 (shared_objfile_contains_address_p): Likewise.
10500 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10501 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10502
21708325
TT
105032019-01-09 Tom Tromey <tom@tromey.com>
10504
10505 * common/next-iterator.h: New file.
10506 * objfiles.h (class all_objfiles): New.
10507 (struct objfile_iterator): New.
10508
669e09f6
PW
105092019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10510
10511 * NEWS: Move the description of the changed "frame", "select-frame",
10512 and "info frame" commands to the Changed commands section.
10513
041be526
SM
105142019-01-09 Simon Marchi <simon.marchi@ericsson.com>
10515
10516 * gdbtypes.c (check_stub_method_group): Remove handling of old
10517 mangling schemes.
10518 * linespec.c (find_methods): Likewise.
10519 * stabsread.c (read_member_functions): Likewise.
10520 * valops.c (search_struct_method): Likewise.
10521 (value_struct_elt_for_reference): Likewise.
10522 * NEWS: Mention this change.
10523
0e2a2133
AB
105242019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
10525
10526 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10527 print_source_lines.
10528 * source.c (print_source_lines_base): Update line number check.
10529 (print_source_lines): New function.
10530 (source_lines_range::source_lines_range): New function.
10531 * source.h (class source_lines_range): New class.
10532 (print_source_lines): New declaration.
10533
1055a3b4
PW
105342019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10535
10536 * linespec.c (linespec_state_destructor): Free self->canonical_names.
10537
cfeadda5
TT
105382019-01-08 Tom Tromey <tom@tromey.com>
10539 Simon Marchi <simon.marchi@ericsson.com>
10540
10541 PR gdb/24060
10542 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10543 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10544 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10545 * f-exp.y (DOLLAR_VARIABLE): Likewise.
10546 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10547 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10548
583068ca
AB
105492019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10550
10551 * source.c (select_source_symtab): Move header comment to
10552 declaration in source.h.
10553 (forget_cached_source_info_for_objfile): Likewise.
10554 (forget_cached_source_info): Likewise.
10555 (identify_source_line): Likewise.
10556 * source.h (identify_source_line): Move declaration from symtab.h
10557 and add comment from source.c
10558 (print_source_lines): Likewise.
10559 (forget_cached_source_info_for_objfile): Likewise.
10560 (forget_cached_source_info): Likewise.
10561 (select_source_symtab): Likewise.
10562 (enum print_source_lines_flag): Move definition from symtab.h.
10563 * symtab.h (identify_source_line): Move declaration to source.h.
10564 (print_source_lines): Likewise.
10565 (forget_cached_source_info_for_objfile): Likewise.
10566 (forget_cached_source_info): Likewise.
10567 (select_source_symtab): Likewise.
10568 (enum print_source_lines_flag): Move definition to source.h.
10569 * tui/tui-hooks.c: Add 'source.h' include.
10570
ec98a4ad
AB
105712019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10572
10573 * source.c (print_source_lines_base): Handle requests to print
10574 reverse line number sequences, and guard against empty lines
10575 string.
10576
62ea19c1
AB
105772019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
10578
10579 * source.c (print_source_lines_base): Fix skip of '\r' if next
10580 character is '\n'.
10581
9d30e1fd
TT
105822019-01-06 Tom Tromey <tom@tromey.com>
10583
10584 * c-exp.y (struct c_parse_state) <macro_original_text,
10585 expansion_obstack>: New member.
10586 (macro_original_text, expansion_obstack): Remove globals.
10587 (scan_macro_expansion, scanning_macro_expansion)
10588 (finished_macro_expansion): Update.
10589 (scan_macro_cleanup): Remove.
10590 (yylex, c_parse): Update.
10591
c65bac38
TT
105922019-01-06 Tom Tromey <tom@tromey.com>
10593
10594 * c-exp.y (struct c_parse_state) <strings>: New member.
10595 (operator_stoken): Update.
10596
02e12e38
TT
105972019-01-06 Tom Tromey <tom@tromey.com>
10598
10599 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
10600 (union type_stack_elt) <typelist_val>: Now a pointer to
10601 std::vector.
10602 (type_stack_cleanup): Don't declare.
10603 (push_typelist): Update.
10604 * parse.c (pop_typelist): Return a std::vector.
10605 (push_typelist): Take a std::vector.
10606 (follow_types): Update. Do not free args.
10607 (type_stack_cleanup): Remove.
10608 * c-exp.y (struct c_parse_state): New.
10609 (cpstate): New global.
10610 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10611 (nonempty_typelist): Update.
10612 (func_mod): Create a new vector.
10613 (c_parse): Create a c_parse_state.
10614 (check_parameter_typelist): Do not delete params.
10615 (function_method): Update. Do not delete type_list.
10616
f097f5ad
TT
106172019-01-06 Tom Tromey <tom@tromey.com>
10618
10619 PR gdb/28155:
10620 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10621 check_typedef.
10622 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10623 (print_return_value): Likewise.
10624
d2adf9f1
TT
106252019-01-05 Tom Tromey <tom@tromey.com>
10626
10627 * contrib/cleanup_check.py: Remove.
10628 * contrib/gcc-with-excheck: Remove.
10629 * contrib/exsummary.py: Remove.
10630 * contrib/excheck.py: Remove.
10631
2eab46b1
JB
106322019-01-05 Joel Brobecker <brobecker@adacore.com>
10633
10634 * thread.c (delete_thread_1): Add gdb_assert that THR is not
10635 NULL. Initialize tpprev to NULL instead of assigning it
10636 to NULL on the next statement.
10637 * windows-nat.c (windows_delete_thread): Remove check for
10638 main_thread_id before printing thread exit notifications.
10639 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10640 Remove thread ID check against main_thread_id.
10641 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10642 windows_delete_thread.
10643 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10644
48c5e7e2
TT
106452019-01-04 Tom Tromey <tom@tromey.com>
10646
10647 * compile/compile.c (_initialize_compile): Use upper case for
10648 metasyntactic variables.
10649 * symmisc.c (_initialize_symmisc): Use upper case for
10650 metasyntactic variables.
10651 * psymtab.c (_initialize_psymtab): Use upper case for
10652 metasyntactic variables.
10653 * demangle.c (demangle_command): Use upper case for metasyntactic
10654 variables.
10655 (_initialize_demangler): Likewise.
10656 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10657 variables.
10658
986041cd
TT
106592019-01-03 Tom Tromey <tom@tromey.com>
10660
10661 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10662
7c711119
TT
106632019-01-03 Tom Tromey <tom@tromey.com>
10664
10665 * python/py-symtab.c (salpy_str): Update.
10666 (struct salpy_sal_object) <symtab>: Now a PyObject.
10667 (salpy_dealloc): Update.
10668 (del_objfile_sal): Use gdbpy_ref.
10669
1b20edf0
TT
106702019-01-03 Tom Tromey <tom@tromey.com>
10671
10672 * python/py-type.c (convert_field): Use new_reference. Return
10673 gdbpy_ref.
10674 (make_fielditem): Return gdbpy_ref.
10675 (typy_fields): Update.
10676 (typy_getitem): Update.
10677 (field_name): Return gdbpy_ref. Use new_reference.
10678 (typy_iterator_iternext): Update.
10679
ea41325b
TT
106802019-01-03 Tom Tromey <tom@tromey.com>
10681
10682 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10683
2a3c71d6
TT
106842019-01-03 Tom Tromey <tom@tromey.com>
10685
10686 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10687 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10688 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10689 (pspy_set_frame_filters, pspy_set_frame_unwinders)
10690 (pspy_set_type_printers): Likewise.
10691 * python/py-function.c (fnpy_init): Use gdbpy_ref.
10692 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10693 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10694 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10695 (objfpy_set_type_printers): Likewise.
10696
5c329e6a
TT
106972019-01-03 Tom Tromey <tom@tromey.com>
10698
10699 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10700 (gdbpy_print_stack): Use gdbpy_err_fetch.
10701 * python/python-internal.h (class gdbpy_err_fetch): New class.
10702 (class gdbpy_enter) <m_error_type, m_error_value,
10703 m_error_traceback>: Remove.
10704 <m_error>: New member.
10705 (gdbpy_exception_to_string): Don't declare.
10706 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10707 * python/py-value.c (convert_value_from_python): Use
10708 gdbpy_err_fetch.
10709 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10710 gdbpy_exception_to_string.
10711 (gdbpy_handle_exception): Use gdbpy_err_fetch.
10712 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10713 gdbpy_err_fetch.
10714
169bb27b
AB
107152019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10716
10717 * linux-nat.c (delete_lwp_cleanup): Delete.
10718 (struct lwp_deleter): New struct.
10719 (lwp_info_up): New typedef.
10720 (linux_nat_target::follow_fork): Delete cleanup, and make use of
10721 lwp_info_up.
10722
a07c8880
AB
107232019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10724
10725 * linux-fork.c (class scoped_switch_fork_info): New class.
10726 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10727
26089c49
AB
107282019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10729
10730 * valops.c (find_overload_match): Remove use of null_cleanup, and
10731 calls to do_cleanups.
10732
06d3e5b0
AB
107332019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10734
10735 * compile/compile-cplus-types.c
10736 (compile_cplus_instance::decl_name): Handle changes to
10737 cp_func_name.
10738 * cp-support.c (cp_func_name): Update header comment, update
10739 return type.
10740 * cp-support.h (cp_func_name): Update return type in declaration.
10741 * valops.c (find_overload_match): Move temp_func local to top
10742 level of function and change its type. Use temp_func to hold and
10743 delete temporary string obtained from cp_func_name.
10744
66644cd3
AB
107452019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
10746
10747 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10748 gdb::char_vector, remove cleanup, and update uses of `msg`.
10749
592d8c0a
JW
107502019-01-03 Jim Wilson <jimw@sifive.com>
10751
10752 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10753
c55d06ec
TT
107542019-01-02 Tom Tromey <tom@tromey.com>
10755
10756 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10757 (tdesc_parse_xml): Remove cleanups.
10758 * target-descriptions.h (make_cleanup_free_target_description):
10759 Don't declare.
10760 (target_desc_deleter): New struct.
10761 (target_desc_up): New typedef.
10762 * target-descriptions.c (target_desc_deleter::operator()): Rename
10763 from free_target_description.
10764 (make_cleanup_free_target_description): Remove.
10765
3a6ae42d
TT
107662019-01-02 Tom Tromey <tom@tromey.com>
10767
10768 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
10769 constructor, destructor.
10770 (linespec_parser): Remove typedef.
10771 (~linespec_parser): Rename from linespec_parser_delete.
10772 (linespec_lex_to_end, linespec_complete_label)
10773 (linespec_complete): Update.
10774 (decode_line_full): Remove cleanups.
10775 (decode_line_1): Update.
10776
61fd3e73
TT
107772019-01-02 Tom Tromey <tom@tromey.com>
10778
10779 * python/python-internal.h (inferior_to_inferior_object): Change
10780 return type.
10781 * python/py-exitedevent.c (create_exited_event_object): Update.
10782 * python/py-inferior.c (inferior_to_inferior_object): Return
10783 gdbpy_ref.
10784 (python_new_inferior, python_inferior_deleted)
10785 (thread_to_thread_object, delete_thread_object)
10786 (build_inferior_list, gdbpy_selected_inferior): Update.
10787 * python/py-infthread.c (create_thread_object): Update. Also fail
10788 if inferior_to_inferior_object fails.
10789
d20172fc
SM
107902019-01-02 Simon Marchi <simon.marchi@ericsson.com>
10791
10792 * inferior.h (class inferior) <displaced_step_state>: New field.
10793 * infrun.h (struct displaced_step_state): Move here from
10794 infrun.c. Initialize fields, add constructor.
10795 <inf>: Remove field.
10796 <reset>: New method.
10797 * infrun.c (struct displaced_step_inferior_state): Move to
10798 infrun.h.
10799 (displaced_step_inferior_states): Remove.
10800 (get_displaced_stepping_state): Adust.
10801 (displaced_step_in_progress_any_inferior): Adjust.
10802 (displaced_step_in_progress_thread): Adjust.
10803 (displaced_step_in_progress): Adjust.
10804 (add_displaced_stepping_state): Remove.
10805 (get_displaced_step_closure_by_addr): Adjust.
10806 (remove_displaced_stepping_state): Remove.
10807 (infrun_inferior_exit): Call displaced_step_state.reset.
10808 (use_displaced_stepping): Don't check for NULL.
10809 (displaced_step_prepare_throw): Call
10810 get_displaced_stepping_state.
10811 (displaced_step_fixup): Don't check for NULL.
10812 (prepare_for_detach): Don't check for NULL.
10813
e3319240
PW
108142019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10815
10816 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10817 in case of call that did not complete.
10818
5d36dfb9
AU
108192019-01-02 Andrey Utkin <autkin@undo.io>
10820
10821 * symfile.c (find_separate_debug_file): Fix search of debug files for
10822 remote debuggee.
10823
8833fbf0
TT
108242019-01-02 Tom Tromey <tom@tromey.com>
10825
10826 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10827 indentation.
10828 * python/py-frame.c (frapy_older): Remove cast.
10829 (frapy_newer): Likewise.
10830 * python/py-breakpoint.c (local_setattro): Remove cast.
10831 * python/py-arch.c (archpy_name): Remove local variable.
10832 * python/py-type.c (gdbpy_lookup_type): Remove cast.
10833
4ada3dfd
JB
108342019-01-02 Joel Brobecker <brobecker@adacore.com>
10835
10836 * unittests/basic_string_view/element_access/char/empty.cc:
10837 Fix year range in copyright header.
10838
113b7b81
AB
108392019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
10840
10841 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10842 Delete.
10843 <operator==>: Update with for removed field.
10844 <hash>: Likewise.
10845 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10846 <isa_features>: ...this.
10847 <abi_features>: New field.
10848 (riscv_isa_flen): Update comment.
10849 (riscv_abi_xlen): New declaration.
10850 (riscv_abi_flen): New declaration.
10851 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10852 isa_features.
10853 (riscv_abi_xlen): New function.
10854 (riscv_isa_flen): Update to get answer from isa_features.
10855 (riscv_abi_flen): New function.
10856 (riscv_has_fp_abi): Update to get answer from abi_features.
10857 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10858 xlen and flen.
10859 (riscv_call_info) <xlen, flen>: Update comment.
10860 (riscv_call_arg_struct): Remove invalid assertions
10861 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10862 is removed.
10863 (riscv_gdbarch_init): Gather isa features and abi features
10864 separately, ensure both match on the gdbarch when reusing an old
10865 gdbarch. Relax an error check to allow 32-bit abi float to run on
10866 a target with 64-bit float hardware.
10867
b18ca514
PW
108682019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10869
10870 * source.c (search_command_helper): Stop reverse search
10871 when line 1 has been searched.
10872
ec70d8db
PW
108732019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10874
10875 * record-full.c (record_full_base_target::close): Rewrite
10876 record_full_core_buf_list free logic.
10877
5b38f9c1
PW
108782019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10879
10880 * break-catch-syscall.c (print_one_catch_syscall): xfree
10881 the last text.
10882
66d91b39
JB
108832019-01-01 Joel Brobecker <brobecker@adacore.com>
10884
10885 * top.c (print_gdb_version): Update Copyright year in version
10886 message.
10887
42a4f53d
JB
108882019-01-01 Joel Brobecker <brobecker@adacore.com>
10889
10890 Update copyright year range in all GDB files.
10891
7e955d83 108922019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 10893
5bbd631d 10894 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 10895
5bbd631d 10896For older changes see ChangeLog-2018.
c906108c
SS
10897\f
10898Local Variables:
10899mode: change-log
10900left-margin: 8
10901fill-column: 74
10902version-control: never
57da7796 10903coding: utf-8
c906108c 10904End:
5bbd631d 10905
This page took 2.624578 seconds and 4 git commands to generate.