projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Change set_locator_info to take a symtab_and_line
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
0ab92974
TT		 12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
4 Take a symtab_and_line.
5 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
6 symtab_and_line.
7 (tui_show_frame_info): Update.
8
ae4393e2
TT		 92019-12-20 Tom Tromey <tom@tromey.com>
10
11 * tui/tui-stack.c (tui_show_frame_info): Don't call
12 update_exec_info.
13
77b97e00
TT		 142019-12-20 Tom Tromey <tom@tromey.com>
15
16 * tui/tui.c (tui_enable): Call tui_display_main.
17
52469d76
TT		 182019-12-20 Tom Tromey <tom@tromey.com>
19
20 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
21 get_current_source_symtab_and_line, and main_name.
22
5d49bf1b
TT		 232019-12-20 Tom Tromey <tom@tromey.com>
24
25 * tui/tui.c (tui_show_source): Update.
26 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
27 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
28 a symtab_symbol_info, not a separate symtab and line. Simplify.
29
88180c08
TT		 302019-12-20 Tom Tromey <tom@tromey.com>
31
32 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
33 Simplify.
34
9f7540a5
TT		 352019-12-20 Tom Tromey <tom@tromey.com>
36
37 * tui/tui-winsource.h (struct tui_source_window_base)
38 <set_contents, update_source_window_as_is, update_source_window>:
39 Take a sal, not a separate symtab and tui_line_or_address.
40 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
41 (tui_source_window_base::update_source_window_as_is): Take a sal,
42 not a separate symtab and tui_line_or_address.
43 (tui_update_source_windows_with_addr)
44 (tui_update_source_windows_with_line)
45 (tui_source_window_base::rerender)
46 (tui_source_window_base::refill): Update.
47 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
48 a sal, not a separate symtab and tui_line_or_address.
49 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
50 not a separate symtab and tui_line_or_address.
51 (tui_source_window::maybe_update): Update.
52 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
53 a sal, not a separate symtab and tui_line_or_address.
54 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
55 not a separate symtab and tui_line_or_address.
56 (tui_disasm_window::do_scroll_vertical)
57 (tui_disasm_window::maybe_update): Update.
58
57e4b379
TT		 592019-12-20 Tom Tromey <tom@tromey.com>
60
61 * tui/tui-winsource.c (tui_source_window_base::refill): Use
62 start_line_or_addr.
63 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
64 start_line_or_addr.
65 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
66 start_line_or_addr.
67
61c33f10
TT		 682019-12-20 Tom Tromey <tom@tromey.com>
69
70 * tui/tui-winsource.h (struct tui_source_window_base)
71 <set_contents>: Return bool.
72 * tui/tui-winsource.c
73 (tui_source_window_base::update_source_window_as_is): Update.
74 * tui/tui-source.h (struct tui_source_window) <set_contents>:
75 Return bool.
76 * tui/tui-source.c (tui_source_window::set_contents): Return
77 bool. Simplify.
78 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
79 Return bool.
80 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
81 bool.
82
469b0731
TT		 832019-12-20 Tom Tromey <tom@tromey.com>
84
85 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
86 (tui_update_source_windows_with_line): Call update_source_window.
87 * tui/tui-source.h (struct tui_source_window)
88 <show_symtab_source>: Don't declare.
89 * tui/tui-source.c (tui_source_window::show_symtab_source):
90 Remove.
91
855f89b3
TT		 922019-12-20 Tom Tromey <tom@tromey.com>
93
94 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
95 update_source_window directly.
96 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
97 * tui/tui-disasm.c (tui_show_disassem): Remove.
98
d4669c0f
TT		 992019-12-20 Tom Tromey <tom@tromey.com>
100
101 * tui/tui-winsource.c
102 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
103 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
104
1ae58f0c
TT		 1052019-12-20 Tom Tromey <tom@tromey.com>
106
107 * tui/tui-winsource.h (struct tui_source_window_base)
108 <maybe_update>: Remove line_no and addr parameters.
109 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
110 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
111 Update.
112 * tui/tui-source.c (tui_source_window::maybe_update): Remove
113 line_no and addr parameters.
114 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
115 Update.
116 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
117 line_no and addr parameters.
118
039298ec
TT		 1192019-12-20 Tom Tromey <tom@tromey.com>
120
121 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
122 (tui_source_window_base::update_breakpoint_info): Remove asserts.
123
8acfefcc
TT		 1242019-12-20 Tom Tromey <tom@tromey.com>
125
126 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
127 tui_show_disassem.
128 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
129 declare.
130 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
131
5ebd5402
TT		 1322019-12-20 Tom Tromey <tom@tromey.com>
133
134 * tui/tui.h (tui_show_source): Remove parameters.
135 * tui/tui.c (tui_show_source): Remove parameters.
136 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
137
c1b167d7
TT		 1382019-12-20 Tom Tromey <tom@tromey.com>
139
140 * tui/tui.c (tui_show_source): Update.
141 * tui/tui-winsource.c (tui_display_main): Update.
142 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
143 to symtab.
144 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
145 to symtab.
146 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
147
364d7104
TT		 1482019-12-20 Tom Tromey <tom@tromey.com>
149
150 PR tui/23619:
151 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
152 (tui_redisplay_readline): Use rl_display_prompt.
153 (tui_prep_terminal): Update.
154
0ad6b8ee
CB		 1552019-12-19 Christian Biesinger <cbiesinger@google.com>
156
157 * configure: Regenerate.
158 * configure.ac: Quote variable arguments of test.
159 * gdbsupport/common.m4: Likewise.
160
d411762c
CB		 1612019-12-19 Christian Biesinger <cbiesinger@google.com>
162
163 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
164 2 to pow ().
165
1cd4a20a
CB		 1662019-12-19 Christian Biesinger <cbiesinger@google.com>
167
168 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
169 log10 to double to fix Solaris 11 with gcc 5.5.
170
aa989b27
CB		 1712019-12-19 Christian Biesinger <cbiesinger@google.com>
172
173 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
174 "sun" to "saddr_un".
175
2032eb7e
TT		 1762019-12-19 Tom Tromey <tromey@adacore.com>
177
178 * ui-out.h (enum class field_kind): Fix comment.
179
f69656d0
TT		 1802019-12-11 Tom Tromey <tromey@adacore.com>
181
182 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
183
27e4fac7
TT		 1842019-12-18 Tom Tromey <tromey@adacore.com>
185
186 PR build/25268:
187 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
188 type on macOS. Add comment.
189
e623f035
SM		 1902019-12-18 Simon Marchi <simon.marchi@efficios.com>
191
192 * c-lang.c (c_get_string, asm_language_defn): Remove space
193 before tab.
194
28ce7b07
TT		 1952019-12-18 Tom Tromey <tromey@adacore.com>
196
197 PR build/25250:
198 * ui-out.c (ui_out::vmessage): Update.
199 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
200 Rename.
201 (string_field): Update.
202 (signed_field): Update.
203
bbde7025
SM		 2042019-12-18 Simon Marchi <simon.marchi@efficios.com>
205
206 * top.c (print_gdb_configuration): Adjust indentation.
207
e3169fe0
CB		 2082019-12-17 Christian Biesinger <cbiesinger@google.com>
209
210 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
211
9b30da15
SM		 2122019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
213
214 * tui/tui-layout.h (class tui_layout_base): Add virtual
215 destructor.
216
4a4c04f1
BE		 2172019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
218
219 * infcmd.c (prepare_one_step): Step over skipped inline functions.
220 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
221 (process_event_stop_test): Keep stepping over skipped inline functions.
222
0394eed1
SM		 2232019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
224
225 * jit.c (struct gdb_block) <next>: Remove field.
226 (struct gdb_symtab) <~gdb_symtab>: Remove.
227 <blocks>: Change type to std::forward_list<gdb_block>.
228 (compare_block): Remove.
229 (jit_block_open_impl): Adjust to std::forward_list. Place the new
230 block at the beginning, don't mind about sorting.
231 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
232 before using it.
233
b6112117
SM		 2342019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
235
236 * jit.c (struct gdb_block): Add constructor, initialize
237 real_block and next fields.
238 <name>: Change type to gdb::unique_xmalloc_ptr.
239 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
240 (jit_block_open_impl): Allocate gdb_block with new.
241 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
242
1b61f46d
SM		 2432019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
244
245 * jit.c: Include forward_list.
246 (struct gdb_symtab) <next>: Remove field.
247 (struct gdb_object) <symtabs>: Change type to
248 std::forward_list<gdb_symtab>.
249 (jit_object_open_impl): Allocate gdb_object with new.
250 (jit_symtab_open_impl): Adjust to std::forward_list.
251 (finalize_symtab): Don't delete symtab.
252 (jit_object_close_impl): Adjust to std::forward_list. Free
253 gdb_object with delete.
254
89867184
SM		 2552019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
256
257 * jit.c (struct gdb_symtab): Add constructor, destructor,
258 initialize fields.
259 <linetable>: Change type to unique_xmalloc_ptr.
260 <file_name>: Change type to std::string.
261 (jit_symtab_open_impl): Allocate gdb_symtab with new.
262 (jit_symtab_line_mapping_add_impl): Adjust.
263 (finalize_symtab): Adjust, call delete on stab.
264
d043f8c8
SM		 2652019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
266
267 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
268
d9fa87f4
TT		 2692019-12-16 Tom Tromey <tromey@adacore.com>
270
271 * windows-nat.c (windows_nat_target::attach): Update.
272 * remote.c (extended_remote_target::attach): Update.
273 * procfs.c (procfs_target::attach): Update.
274 * nto-procfs.c (nto_procfs_target::attach): Update.
275 (nto_procfs_target::create_inferior): Update.
276 * inf-ptrace.c (inf_ptrace_target::attach): Update.
277 * gnu-nat.c (gnu_nat_target::attach): Update.
278 (gnu_nat_target::detach): Update.
279 * darwin-nat.c (darwin_nat_target::attach): Update.
280 * corefile.c (get_exec_file): Constify result. Remove extraneous
281 return.
282 * bsd-kvm.c (bsd_kvm_target_open): Update.
283 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
284
c0c3707f
CB		 2852019-12-16 Christian Biesinger <cbiesinger@google.com>
286
287 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
288 (we no longer need to include time.h before pathmax.h)
289
d3ecddab
CB		 2902019-12-15 Christian Biesinger <cbiesinger@google.com>
291
292 * ada-exp.y (write_ambiguous_var): Update.
293 * coffread.c (process_coff_symbol): Update.
294 * ctfread.c (ctf_add_enum_member_cb): Update.
295 (new_symbol): Update.
296 * dwarf2read.c (fixup_go_packaging): Update.
297 (new_symbol): Update.
298 * language.c (language_alloc_type_symbol): Update.
299 * mdebugread.c (new_symbol): Update.
300 * minsyms.c (minimal_symbol_reader::record_full): Update.
301 * psymtab.c (add_psymbol_to_bcache): Update.
302 * stabsread.c (define_symbol): Update.
303 (read_enum_type): Update.
304 * symtab.c (symbol_set_language): Make this a member function...
305 (general_symbol_info::set_language): ... here.
306 * symtab.h (struct general_symbol_info) <set_language>: New function.
307 (SYMBOL_SET_LANGUAGE): Remove.
308 (symbol_set_language): Remove.
309
c1b5c1eb
CB		 3102019-12-15 Christian Biesinger <cbiesinger@google.com>
311
312 * ada-lang.c (ada_add_block_symbols): Update.
313 (ada_collect_symbol_completion_matches): Update.
314 * ax-gdb.c (gen_expr): Update.
315 * block.c (block_lookup_symbol): Update.
316 (block_lookup_symbol_primary): Update.
317 (block_find_symbol): Update.
318 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
319 * dbxread.c (process_one_symbol): Update.
320 * dictionary.c (insert_symbol_hashed): Update.
321 (collate_pending_symbols_by_language): Update.
322 (mdict_add_symbol): Update.
323 * dwarf-index-write.c (write_psymbols): Update.
324 * dwarf2read.c (fixup_go_packaging): Update.
325 * findvar.c (read_var_value): Update.
326 * ft32-tdep.c (ft32_skip_prologue): Update.
327 * go-lang.c (go_symbol_package_name): Update.
328 * language.h (scoped_switch_to_sym_language_if_auto::
329 scoped_switch_to_sym_language_if_auto): Update.
330 * linespec.c (find_method): Update.
331 (find_label_symbols_in_block): Update.
332 * mdebugread.c (parse_symbol): Update.
333 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
334 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
335 (minimal_symbol_reader::install): Update.
336 * moxie-tdep.c (moxie_skip_prologue): Update.
337 * parse.c (parse_exp_in_context): Update.
338 * psymtab.c (psymbol_name_matches): Update.
339 (match_partial_symbol): Update.
340 (lookup_partial_symbol): Update.
341 (psymbol_hash): Update.
342 (psymbol_compare): Update.
343 * python/py-framefilter.c (extract_sym): Update.
344 (py_print_single_arg): Update.
345 * stabsread.c (define_symbol): Update.
346 * stack.c (print_frame_arg): Update.
347 (find_frame_funname): Update.
348 (info_frame_command_core): Update.
349 * symfile.c (set_initial_language): Update.
350 * symtab.c (symbol_set_demangled_name): Update.
351 (symbol_get_demangled_name): Update.
352 (symbol_set_language): Update.
353 (symbol_find_demangled_name): Update.
354 (symbol_set_names): Update.
355 (general_symbol_info::natural_name): Update.
356 (general_symbol_info::demangled_name): Update.
357 (general_symbol_info::search_name): Update.
358 (symbol_matches_search_name): Update.
359 (eq_symbol_entry): Update.
360 (iterate_over_symbols): Update.
361 (completion_list_add_symbol): Update.
362 (completion_list_add_msymbol): Update.
363 (completion_list_add_fields): Update.
364 * symtab.h (struct general_symbol_info) <language>: New function.
365 <language>: Rename to...
366 <m_language>: ...this.
367 (SYMBOL_LANGUAGE): Remove.
368 (MSYMBOL_LANGUAGE): Remove.
369 (struct symbol) <ctor>: Update.
370 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
371
747cfc8c
CB		 3722019-12-15 Christian Biesinger <cbiesinger@google.com>
373
374 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
375 set the language of sym.
376 * language.c (language_alloc_type_symbol): Likewise.
377
ff8577f6
SDJ		 3782019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
379
380 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
381 PR gdb/23613
382 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
383 * corelow.c: Include 'gdbsupport/pathstuff.h'.
384 (core_target_open): Use 'gdb_abspath'.
385 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
386 'current_directory == NULL' case.
387 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
388 explain what happens when 'current_directory' is NULL.
389 * go32-nat.c (go32_nat_target::wait): Check if
390 'current_directory' is NULL before call to 'chdir'.
391 * source.c (add_path): Use 'gdb_abspath'.
392 * top.c: Include 'gdbsupport/pathstuff.h'.
393 (init_history): Use 'gdb_abspath'.
394 (set_history_filename): Likewise.
395 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
396 (tfile_target_open): Use 'gdb_abspath'.
397
234c3068
TT		 3982019-12-13 Tom Tromey <tromey@adacore.com>
399
400 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
401 warning or error.
402
93537683
TT		 4032019-12-13 Tom Tromey <tromey@adacore.com>
404
405 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
406
63456183
TT		 4072019-12-13 Tom Tromey <tromey@adacore.com>
408
409 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
410
98f9338a
TT		 4112019-12-13 Tom Tromey <tromey@adacore.com>
412
413 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
414
3cb5a3a1
TT		 4152019-12-13 Tom Tromey <tromey@adacore.com>
416
417 * gdbsupport/common-utils.c (string_printf, string_vprintf)
418 (string_vappendf): Add ARI comment.
419
c6cbf900
TT		 4202019-12-13 Tom Tromey <tromey@adacore.com>
421
422 * contrib/ari/gdb_ari.sh: Remove "fix" call for
423 floatformat_to_double.
424 * target-float.c (host_float_ops<T>::from_target): Add ARI
425 comment.
426
036003a6
TT		 4272019-12-13 Tom Tromey <tromey@adacore.com>
428
429 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
430 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
431 ARI marker to abort.
432 * event-top.c (handle_sigsegv): Add ARI marker to abort.
433
8aaaf757
TT		 4342019-12-13 Tom Tromey <tromey@adacore.com>
435
436 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
437
fe56157f
TT		 4382019-12-13 Tom Tromey <tromey@adacore.com>
439
440 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
441
a15a95ed
TT		 4422019-12-13 Tom Tromey <tromey@adacore.com>
443
444 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
445 checks.
446
a5513db2
TT		 4472019-12-13 Tom Tromey <tromey@adacore.com>
448
449 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
450 end>: No longer "const".
451
3a90f266
SM		 4522019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
453
454 * jit.c: Fix indentation, replace spaces with tabs where
455 applicable.
456
b3f4b80f
JL		 4572019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
458
459 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
460
e671856c
TT		 4612019-12-12 Tom Tromey <tom@tromey.com>
462
463 * objfiles.h (struct objfile) <partial_symtabs>: Now a
464 unique_ptr.
465
7d7167ce
TT		 4662019-12-12 Tom Tromey <tom@tromey.com>
467
468 * progspace.h (objfile_list): New typedef.
469 (class unwrapping_objfile_iterator)
470 (struct unwrapping_objfile_range): Newl
471 (struct program_space) <objfiles_range>: Change type.
472 <objfiles>: Change return type.
473 <add_objfile>: Change type of "objfile" parameter.
474 <objfiles_list>: Now a list of shared_ptr.
475 * progspace.c (program_space::add_objfile): Change type of
476 "objfile". Update.
477 (program_space::remove_objfile): Update.
478 * objfiles.h (struct objfile) <~objfile>: Make public.
479 * objfiles.c (objfile::make): Update.
480 (objfile::unlink): Don't call delete.
481
343cc952
TT		 4822019-12-12 Tom Tromey <tom@tromey.com>
483
484 * symfile.c (symbol_file_clear): Update.
485 * progspace.h (struct program_space) <free_all_objfiles>: Declare
486 method.
487 * progspace.c (program_space::free_all_objfiles): New method.
488 * objfiles.h (free_all_objfiles): Don't declare.
489 * objfiles.c (free_all_objfiles): Move to program_space.
490
d0801dd8
TT		 4912019-12-12 Tom Tromey <tom@tromey.com>
492
493 * progspace.c (program_space::add_objfile)
494 (program_space::remove_objfile): Update.
495 (program_space::multi_objfile_p): Remove.
496 * objfiles.h (struct objfile) <next>: Remove.
497 * objfiles.c (objfile::objfile): Update.
498 (put_objfile_before): Update.
499 (unlink_objfile): Update.
500 * progspace.h (object_files): Remove.
501 (struct program_space) <objfiles_head>: Remove.
502 <objfiles_list>: New member.
503 <objfiles_range, objfiles_safe_range>: Change type.
504 (objfiles): Change return type.
505 (objfiles_safe): Update.
506 (multi_objfile_p): Rewrite and inline.
507 (object_files): Remove macro.
508
13bff726
TT		 5092019-12-12 Tom Tromey <tom@tromey.com>
510
511 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
512 second constructor.
513 (basic_safe_range): New class.
514
deeafabb
TT		 5152019-12-12 Tom Tromey <tom@tromey.com>
516
517 * progspace.c (program_space::multi_objfile_p): New method.
518 * printcmd.c (info_symbol_command): Update.
519 * maint.c (maintenance_translate_address): Update.
520 * objfiles.h (MULTI_OBJFILE_P): Remove.
521 * progspace.h (struct program_space) <multi_objfile_p>: New
522 method.
523
23452926
TT		 5242019-12-12 Tom Tromey <tom@tromey.com>
525
526 * progspace.h (struct program_space) <remove_objfile>: Declare.
527 * progspace.c (program_space::remove_objfile): New method.
528 * objfiles.c (unlink_objfile): Remove.
529 (objfile::unlink): Call remove_objfile.
530 (objfile): Don't call unlink_objfile.
531
7cac64af
TT		 5322019-12-12 Tom Tromey <tom@tromey.com>
533
534 * progspace.h (struct program_space) <add_objfile>: Declare
535 method.
536 * progspace.c (program_space::add_objfile): New method.
537 * objfiles.c (~objfile): Don't unlink objfile.
538 (put_objfile_before): Remove.
539 (add_separate_debug_objfile): Don't call put_objfile_before.
540 (objfile::make): Call add_objfile. Set new_objfiles_available on
541 the per-program-space data.
542
268e4f09
TT		 5432019-12-12 Tom Tromey <tom@tromey.com>
544
545 * symfile.c (syms_from_objfile_1): Use objfile_up.
546 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
547 method.
548 (reread_symbols): Use objfile_up.
549 * solib.c (update_solib_list, reload_shared_libraries_1): Call
550 unlink method.
551 * objfiles.h (struct objfile) <~objfile>: Now private.
552 <unlink>: New method.
553 (struct objfile_deleter): New.
554 (objfile_up): New typedef.
555 * objfiles.c (objfile::unlink): New method.
556 (free_objfile_separate_debug, free_all_objfiles)
557 (objfile_purge_solibs): Use it.
558 * jit.c (jit_unregister_code): Remove.
559 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
560 objfile.
561 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
562 objfile.
563 * compile/compile-object-load.c (compile_object_load): Use
564 objfile_up.
565
f65fe570
TT		 5662019-12-12 Tom Tromey <tom@tromey.com>
567
568 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
569 objfile::make.
570 * objfiles.h (struct objjfile) <make>: No longer inline.
571 (add_separate_debug_objfile): Don't declare.
572 * objfiles.c (add_separate_debug_objfile): Now static.
573 (objfile::make): Move from objfiles.h. Call
574 add_separate_debug_objfile. Add "parent" parameter.
575
bda13cdc
TT		 5762019-12-12 Tom Tromey <tom@tromey.com>
577
578 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
579 * objfiles.h (struct objfile): Make constructor private.
580 <make>: New static method.
581 * jit.c (jit_object_close_impl): Update.
582
7190276c
SM		 5832019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
584
585 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
586 gdb::byte_vector.
587
d61df897
TT		 5882019-12-12 Tom Tromey <tromey@adacore.com>
589
590 * xml-support.c (xml_fetch_content_from_file): Don't call
591 malloc_failure.
592 * utils.h (class gdb_argv): Remove malloc_failure comment.
593 * utils.c (gdb_argv::reset): Don't call malloc_failure.
594
db3ad2f0
TT		 5952019-12-12 Tom Tromey <tromey@adacore.com>
596
597 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
598 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
599 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
600 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
601 * riscv-ravenscar-thread.c: New file.
602 * riscv-ravenscar-thread.h: New file.
603 * riscv-tdep.c (riscv_gdbarch_init): Call
604 register_riscv_ravenscar_ops.
605
2ffe5b9c
TT		 6062019-12-12 Tom Tromey <tromey@adacore.com>
607
608 * gdbsupport/thread-pool.c (set_thread_name): Use
609 ATTRIBUTE_UNUSED.
610
39f34d7b
LM		 6112019-12-12 Luis Machado <luis.machado@linaro.org>
612
613 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
614 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
615 macros.
616
d4eeccfe
TT		 6172019-12-11 Tom Tromey <tom@tromey.com>
618
619 * tui/tui-win.c (tui_set_win_height_command): Call
620 tui_adjust_window_height.
621 (tui_adjust_win_heights, new_height_ok): Remove.
622 * tui/tui-layout.h (tui_adjust_window_height): Declare.
623 * tui/tui-layout.c (tui_adjust_window_height): New function.
624
3d979945
TT		 6252019-12-11 Tom Tromey <tom@tromey.com>
626
627 * tui/tui-win.c (tui_resize_all): Remove code, call
628 tui_apply_current_layout.
629
2192a9d3
TT		 6302019-12-11 Tom Tromey <tom@tromey.com>
631
632 * tui/tui-layout.h (tui_apply_current_layout): Declare.
633 * tui/tui-layout.c (standard_layouts, applied_layout): New
634 globals.
635 (tui_apply_current_layout): New function.
636 (show_layout): Set applied_layout. Call
637 tui_apply_current_layout.
638 (show_source_command, show_disasm_command)
639 (show_source_disasm_command, show_data)
640 (show_source_or_disasm_and_command): Remove.
641 (initialize_layouts): New function.
642 (_initialize_tui_layout): Call initialize_layouts.
643
389e7ddb
TT		 6442019-12-11 Tom Tromey <tom@tromey.com>
645
646 * tui/tui-layout.h (class tui_layout_base)
647 (class tui_layout_window, class tui_layout_split): New.
648 * tui/tui-layout.c (tui_get_window_by_name)
649 (tui_layout_window::clone, tui_layout_window::apply)
650 (tui_layout_window::get_sizes, tui_layout_window::add_split)
651 (tui_layout_split::add_window, tui_layout_split::clone)
652 (tui_layout_split::get_sizes)
653 (tui_layout_split::set_weights_from_heights)
654 (tui_layout_split::adjust_size, tui_layout_split::apply): New
655 functions.
656 (tui_layout_split::add_split, tui_layout_split::add_split)
657 (tui_layout_split::set_weights_from_heights)
658 (tui_layout_split::set_weights_from_heights): New functions.
659
fb3184d8
TT		 6602019-12-11 Tom Tromey <tom@tromey.com>
661
662 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
663 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
664 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
665 * tui/tui-data.h (struct tui_point): Remove.
666 (struct tui_gen_win_info) <origin>: Remove.
667 <x, y>: New fields.
668 * tui/tui-command.c (tui_cmd_window::resize): Update.
669
dc7ff8a6
TT		 6702019-12-11 Tom Tromey <tom@tromey.com>
671
672 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
673 Implement.
674 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
675 Implement.
676 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
677 method.
678 (struct tui_win_info) <min_height>: Implement.
679
1431937b
TT		 6802019-12-11 Tom Tromey <tom@tromey.com>
681
682 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
683 (struct tui_win_info) <can_box>: Update.
684
c8ec2f43
TT		 6852019-12-11 Tom Tromey <tom@tromey.com>
686
687 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
688 method.
689 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
690 method.
691 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
692 method.
693 (struct tui_win_info) <max_height>: Now override.
694
4decd62b
JB		 6952019-12-11 Joel Brobecker <brobecker@adacore.com>
696
697 * NEWS: Create a new section for the next release branch.
698 Rename the section of the current branch, now that it has
699 been cut.
700
d746744e
JB		 7012019-12-11 Joel Brobecker <brobecker@adacore.com>
702
703 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
704 * version.in: Bump version to 10.0.50.DATE-git.
705
2e744276
TT		 7062019-12-11 Tom Tromey <tromey@adacore.com>
707
708 PR build/25268:
709 * gdbsupport/thread-pool.c (set_thread_name): New function.
710 (thread_pool::set_thread_count): Don't call pthread_setname_np.
711 (thread_pool::thread_function): Call set_thread_name.
712
aac4760f
TT		 7132019-12-11 Tom Tromey <tromey@adacore.com>
714
715 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
716 bfd_get_signed_8.
717
d8edc8b7
PW		 7182019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
719
720 * NEWS: Document -raw-values option and the related setting commands.
721 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
722 only set it on when /r is given.
723 * valprint.c (value_print_option_defs): New element raw-values.
724 * Makefile.in: Add the new file.
725
cb511130
CB		 7262019-12-10 Christian Biesinger <cbiesinger@google.com>
727
728 * gdbsupport/safe-strerror.c: Supress the unused function warning
729 for select_strerror_r.
730
ab7d13f0
CB		 7312019-12-10 Christian Biesinger <cbiesinger@google.com>
732
733 * config.in: Regenerate.
734 * configure: Regenerate.
735 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
736 safe_strerror instead of strerror.
737 * gdbsupport/common.m4: Don't check for strerror.
738 * gdbsupport/safe-strerror.c: Support both the glibc version
739 of strerror_r and the XSI version.
740
6c71eb7d
TT		 7412019-12-10 Tom Tromey <tromey@adacore.com>
742
743 * ada-typeprint.c (print_choices): Use a single "?".
744 (print_variant_part): Print "?" if the discriminant name
745 is not known.
746
bac7c5cf
GB		 7472019-12-10 George Barrett <bob@bob131.so>
748
749 Fix scripted probe breakpoints.
750 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
751 declaration forward.
752 (breakpoint_ops_for_event_location_type)
753 (breakpoint_ops_for_event_location): Add function definitions.
754 (break_command_1, trace_command): Use
755 breakpoint_ops_for_event_location.
756 * breakpoint.h (breakpoint_ops_for_event_location): Add function
757 declarations.
758 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
759 breakpoint_ops_for_event_location.
760 * python/py-breakpoint.c (bppy_init): Use
761 breakpoint_ops_for_event_location.
762
330f1d38
TBA		 7632019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
764
765 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
766 when ranking an lvalue argument for an rvalue parameter.
767
b1f0c0b9
WA		 7682019-12-08 Wataru Ashihara <wataash@wataash.com>
769
770 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
771 template argument for scoped_restore_tmpl from bool to int.
772
aa2d5a42
KS		 7732019-12-07 Keith Seitz <keiths@redhat.com>
774
775 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
776 (build_id_to_debug_bfd): Make static, rewriting to use
777 build_id_to_bfd_suffix.
778 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
779 adding `suffix' parameter. Append SUFFIX to file names
780 when searching for matching files.
781 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
782 (build_id_to_exec_bfd): Likewise.
783 * build-id.h (build_id_to_debug_bfd): Clarify that function
784 searches for BFD of debug info file.
785 (build_id_to_exec_bfd): Declare.
786 * corelow.c: Include build-id.h.
787 (locate_exec_from_corefile_build_id): New function.
788 (core_target_open): If no executable BFD is found,
789 search for a core file BFD using build-id.
790
dfb65191
CB		 7912019-12-06 Christian Biesinger <cbiesinger@google.com>
792
793 * bcache.c: Put in namespace gdb.
794 * bcache.h: Likewise.
795 * gdbtypes.c (check_types_worklist): Update.
796 (types_deeply_equal): Update.
797 * macrotab.c (struct macro_table) <bcache>: Update.
798 (new_macro_table): Update.
799 * macrotab.h (struct bcache): Put this forward declaration
800 inside namespace gdb.
801 (new_macro_table): Update.
802 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
803 Update.
804 <macro_cache>: Update.
805 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
806
93e55f0a
TV		 8072019-12-06 Tom de Vries <tdevries@suse.de>
808
809 PR symtab/24971
810 * block.c (best_symbol, better_symbol): New function.
811 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
812 decl.
813
06acc08f
TBA		 8142019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
815
816 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
817 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
818 for ranking see-through reference cases.
819
e0fad1ea
PW		 8202019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
821 * stack.c (faas_command): Check a command is provided.
822 * thread.c (taas_command, tfaas_command): Likewise.
823
908641f5
PW		 8242019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
825 * inferior.c (prune_inferiors): Only call delete_inferior,
826 Do not modify the inferior list.
827
b858499d
SM		 8282019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
829
830 * c-exp.y: Update calls to lookup_typename,
831 lookup_signed_typename and lookup_unsigned_typename.
832 * c-lang.c (evaluate_subexp_c): Likewise.
833 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
834 Likewise.
835 * eval.c (binop_promote): Likewise.
836 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
837 (lookup_unsigned_typename): Likewise.
838 (lookup_signed_typename): Likewise.
839 * gdbtypes.h (lookup_unsigned_typename): Likewise.
840 (lookup_signed_typename): Likewise.
841 (lookup_typename): Likewise.
842 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
843 lookup_typename, lookup_signed_typename,
844 lookup_unsigned_typename.
845 * m2-exp.y: Likewise.
846 * printcmd.c (printf_wide_c_string): Likewise.
847 (ui_printf): Likewise.
848 * python/py-type.c (typy_lookup_typename): Likewise.
849 * python/py-xmethods.c (python_xmethod_worker::invoke):
850 Likewise.
851 * rust-exp.y: Likewise.
852
3a8fa228
CB		 8532019-12-04 Christian Biesinger <cbiesinger@google.com>
854
855 * configure.nat (obsd64): Add missing files x86-nat.o and
856 nat/x86-dregs.o.
857
2dbc041e
TT		 8582019-12-04 Tom Tromey <tom@tromey.com>
859
860 * valprint.c (val_print_string): Use metadata_style.
861 * go-valprint.c (print_go_string): Use metadata style.
862 * p-valprint.c (pascal_object_print_static_field): Use metadata
863 style.
864 * cp-valprint.c (cp_print_static_field): Use metadata style.
865
36c8fb93
AB		 8662019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
867 Chris January <chris.january@arm.com>
868
869 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
870 tokens.
871 (typebase): New patterns for complex, single/double precision, and
872 single/double complex.
873 (f77_keywords): Change token for complex keyword, and add single,
874 double, and precision keywords.
875
c6170c2c
SM		 8762019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
877
878 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
879 "info io_registers".
880
894ecaf4
SM		 8812019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
882
883 * regcache.c (cooked_read_test): Initialize thread list of
884 mock_inferior.
885
be155ebb
SM		 8862019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
887
888 * aarch64-linux-tdep.c: Remove includes.
889
c577cdd7
SM		 8902019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
891
892 * aarch64-tdep.c: Remove includes.
893
610cfd61
SM		 8942019-12-04 Simon Marchi <simon.marchi@efficios.com>
895
896 * filtered-iterator.h (filtered_iterator) <operator==,
897 operator!=>: Compare wrapped iterators, not wrapped pointers.
898 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
899 unittests/filtered_iterator-selftests.c.
900 * unittests/filtered_iterator-selftests.c: New file.
901
a05cf17a
TT		 9022019-12-04 Tom Tromey <tromey@adacore.com>
903
904 * gdbtypes.c (create_range_type): Inherit endianity
905 from base type.
906
d5a22e77
TT		 9072019-12-04 Tom Tromey <tromey@adacore.com>
908
909 * ada-lang.c (decode_constrained_packed_array)
910 (ada_value_assign, value_assign_to_component): Update.
911 * dwarf2loc.c (rw_pieced_value, access_memory)
912 (dwarf2_compile_expr_to_ax): Update.
913 * dwarf2read.c (dwarf2_add_field): Update.
914 * eval.c (evaluate_subexp_standard): Update.
915 * gdbarch.c, gdbarch.h: Rebuild.
916 * gdbarch.sh (bits_big_endian): Remove.
917 * gdbtypes.h (union field_location): Update comment.
918 * target-descriptions.c (make_gdb_type): Update.
919 * valarith.c (value_bit_index): Update.
920 * value.c (struct value) <bitpos>: Update comment.
921 (unpack_bits_as_long, modify_field): Update.
922 * value.h (value_bitpos): Update comment.
923
7ab4a236
TT		 9242019-12-04 Tom Tromey <tromey@adacore.com>
925
926 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
927 endian-ness.
928
103a685e
TT		 9292019-12-04 Tom Tromey <tromey@adacore.com>
930
931 * dwarf2read.c (dwarf2_init_float_type)
932 (dwarf2_init_complex_target_type): Add byte_order parameter.
933 (read_base_type): Compute byte order earlier.
934 * gdbtypes.c (init_float_type): Add byte_order parameter.
935 * gdbtypes.h (init_float_type): Add byte_order parameter.
936
7a9e9f9f
TT		 9372019-12-04 Tom Tromey <tromey@adacore.com>
938
939 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
940
feee869b
TT		 9412019-12-04 Tom Tromey <tromey@adacore.com>
942
943 * dwarf2read.c (process_structure_scope): Initialize
944 "discr_offset".
945
c2512106
AB		 9462019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
947
948 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
949 add it into the search spec.
950 (parse_max_results_option): New function.
951 (mi_info_functions_or_variables): Parse -max-results flag and pass
952 it to mi_symbol_info.
953 (mi_cmd_symbol_info_modules): Likewise.
954 (mi_cmd_symbol_info_types): Likewise.
955 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
956 return type to bool, change result container into a set, and don't
957 add new results if we have enough already.
958 (global_symbol_searcher::add_matching_msymbols): Change return
959 type to bool, and don't add new results if we have enough already.
960 (sort_search_symbols_remove_dups): Delete.
961 (global_symbol_searcher::search): Early exit from search loop when
962 we have enough results. Use a std::set to collect the results
963 from calling add_matching_symbols.
964 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
965 member function.
966 (global_symbol_searcher) <m_max_search_results>: New member
967 variable.
968 (global_symbol_searcher) <add_matching_symbols>: Update header
969 comment and change return type to bool.
970 (global_symbol_searcher) <add_matching_msymbols>: Update header
971 comment and change return type to bool.
972
f97a63c5
AB		 9732019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
974
975 * symtab.c (symbol_search::compare_search_syms): Update header
976 comment.
977 (global_symbol_searcher::is_suitable_msymbol): New function.
978 (global_symbol_searcher::expand_symtabs): New function.
979 (global_symbol_searcher::add_matching_symbols): New function.
980 (global_symbol_searcher::add_matching_msymbols): New function.
981 (global_symbol_searcher::search): Move most of the content
982 into the new functions above, and call them as needed.
983 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
984 function.
985 (global_symbol_searcher) <add_matching_symbols>: New member
986 function.
987 (global_symbol_searcher) <add_matching_msymbols>: New member
988 function.
989 (global_symbol_searcher) <is_suitable_msymbol>: New member
990 function.
991
293b38d6
AB		 9922019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
993
994 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
995 -symbol-info-module-variables entries.
996 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
997 (mi_cmd_symbol_info_module_variables): Declare.
998 * mi/mi-symbol-cmds.c
999 (module_symbol_search_iterator): New typedef.
1000 (output_module_symbols_in_single_module_and_file): New function.
1001 (output_module_symbols_in_single_module): New function.
1002 (mi_info_module_functions_or_variables): New function.
1003 (mi_cmd_symbol_info_module_functions): New function.
1004 (mi_cmd_symbol_info_module_variables): New function.
1005 * NEWS: Mention new MI command.
1006
4cbd39b2
CB		 10072019-12-03 Christian Biesinger <cbiesinger@google.com>
1008
1009 * bcache.c (hash): Remove.
1010 (hash_continue): Remove.
1011 * bcache.h (hash): Remove.
1012 (hash_continue): Remove.
1013 (struct bcache) <ctor>: Update.
1014 * psymtab.c (psymbol_hash): Update.
1015 * stabsread.c (hashname): Update.
1016 * utils.h (fast_hash): Add an argument for a start value,
1017 defaulting to zero.
1018
82f910ea
PW		 10192019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1020 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1021 (destroy_block_symbol_cache): New function.
1022 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1023 (resize_symbol_cache): Likewise.
1024
de2396d0
TT		 10252019-12-02 Tom Tromey <tom@tromey.com>
1026
1027 * unittests/tui-selftests.c (run_tests): Make conditional.
1028 (_initialize_tui_selftest): Make conditional.
1029
638d85bc
CB		 10302019-12-02 Christian Biesinger <cbiesinger@google.com>
1031
1032 * aix-thread.c (debug_aix_thread): Change type to bool.
1033
7532a164
LM		 10342019-12-02 Luis Machado <luis.machado@linaro.org>
1035
1036 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1037
216a7e6b
AB		 10382019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1039
1040 * dwarf2read.c (read_tag_string_type): Read the fields required to
1041 make a dynamic string, and possibly create a dynamic range for the
1042 string.
1043 (attr_to_dynamic_prop): Setup is_reference based on the type of
1044 attribute being processed.
1045 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1046 (resolve_dynamic_array): Rename to...
1047 (resolve_dynamic_array_or_string): ...this, update header comment,
1048 and accept TYPE_CODE_STRING.
1049 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1050
11a8b164
AB		 10512019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1052
1053 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1054 of its implementation from...
1055 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1056 the new function.
1057
5bbd8269
AB		 10582019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1059
1060 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1061 create a range with stride where appropriate.
1062 * f-valprint.c: Include 'gdbarch.h'.
1063 (f77_print_array_1): Take the stride into account when walking the
1064 array. Also convert the stride into addressable units.
1065 * gdbtypes.c (create_range_type): Initialise the stride to
1066 constant zero.
1067 (create_range_type_with_stride): New function, initialise the
1068 range as normal, and then setup the stride.
1069 (has_static_range): Include the stride here. Also change the
1070 return type to bool.
1071 (create_array_type_with_stride): Consider the range stride if the
1072 array isn't given its own stride.
1073 (resolve_dynamic_range): Resolve the stride if needed.
1074 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1075 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1076 (TYPE_BIT_STRIDE): Define.
1077 (TYPE_ARRAY_BIT_STRIDE): Define.
1078 (create_range_type_with_stride): Declare.
1079 * valarith.c (value_subscripted_rvalue): Take range stride into
1080 account when walking the array.
1081
82e3b564
TT		 10822019-12-01 Tom Tromey <tom@tromey.com>
1083
1084 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1085 specially.
1086
517d261d
TT		 10872019-12-01 Tom Tromey <tom@tromey.com>
1088
1089 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1090 \0.
1091 * unittests/tui-selftests.c: New file.
1092 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1093
484c9b64
TT		 10942019-12-01 Tom Tromey <tom@tromey.com>
1095
1096 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1097
a2a7af0c
TT		 10982019-12-01 Tom Tromey <tom@tromey.com>
1099
1100 * NEWS: Document new settings.
1101 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1102 * tui/tui-win.c (_initialize_tui_win): Add border style
1103 observers.
1104 * tui/tui-io.h (tui_apply_style): Declare.
1105 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1106 longer static.
1107 (apply_ansi_escape, tui_set_reverse_mode): Update.
1108 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1109 Add "skip_intensity" parameter.
1110 <changed>: New member.
1111 <do_set_value>: Declare.
1112 (tui_border_style, tui_active_border_style): Declare.
1113 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1114 globals.
1115 (cli_style_option): Initialize "changed".
1116 (cli_style_option::do_set_value): New function.
1117 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1118 parameter. Update.
1119 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1120 (_initialize_cli_style): Update. Create TUI border style
1121 commands.
1122
d1da6b01
TT		 11232019-12-01 Tom Tromey <tom@tromey.com>
1124
1125 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1126 parameter.
1127 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1128 parameter.
1129 * tui/tui-win.h (compact_source): Declare.
1130 * tui/tui-win.c (compact_source): New global.
1131 (tui_set_compact_source, tui_show_compact_source): New functions.
1132 (_initialize_tui_win): Add "compact-source" setting.
1133 * tui/tui-source.c (tui_source_window::set_contents): Handle
1134 compact_source setting.
1135 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1136 * NEWS: Document new setting.
1137
489dbda6
TT		 11382019-11-30 Tom Tromey <tom@tromey.com>
1139
1140 * dwarf2read.c (dwarf2_add_field): Include field offset when
1141 computing variant part length.
1142
bf498525
PW		 11432019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1144 * NEWS: Mention define-prefix. Tell that command names can now
1145 contain a . character.
1146
be09caf1
PW		 11472019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1148
1149 * command.h (valid_cmd_char_p): Declare.
1150 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1151 the check of valid command char.
1152 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1153 valid_cmd_char_p.
1154 * cli/cli-script.c (validate_comname): Likewise.
1155 * completer.c (gdb_completer_command_word_break_characters):
1156 Do not remove . from the word break char, update comments.
1157 (complete_line_internal_1): Use valid_cmd_char_p.
1158 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1159 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1160
c6ac7fc9
PW		 11612019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1162
1163 * cli/cli-script.c (do_define_command): Ensure a redefined
1164 prefix command is kept as a prefix command.
1165 (define_prefix_command): New function.
1166 (show_user_1): Report user defined prefixes.
1167 (_initialize_cli_script): Create the new 'define-prefix' command.
1168 Add completers for 'define' and 'document'.
1169 * top.c (execute_command): If command is a user-defined prefix only
1170 command, report the list of commands for this prefix command.
1171
a992a3b0
TBA		 11722019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1173
1174 * valops.c (find_oload_champ): Improve debug output.
1175
e9194a1a
TBA		 11762019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1177
1178 * valops.c (find_oload_champ): Print part of debug messages
1179 before the badness vector is std::move'd.
1180
53a008a6
TT		 11812019-11-28 Tom Tromey <tom@tromey.com>
1182
1183 * value.c (creal_internal_fn): Fix comment.
1184
bab05c83
TT		 11852019-11-28 Tom Tromey <tom@tromey.com>
1186
1187 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1188 flag_bound_evaluated>: Now unsigned.
1189
2522f049
TT		 11902019-11-28 Tom Tromey <tom@tromey.com>
1191
1192 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1193 declare.
1194
38b49e22
MS		 11952019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1196
1197 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1198 debug output.
1199 * jit.c (jit_unregister_code): Add debug print to match
1200 `jit_register_code`.
1201
35125921
CB		 12022019-11-27 Christian Biesinger <cbiesinger@google.com>
1203
1204 * NEWS: Mention the new multithreaded symbol loading.
1205
62e77f56
CB		 12062019-11-27 Christian Biesinger <cbiesinger@google.com>
1207
1208 * maint.c (n_worker_threads): Default to 0.
1209 (worker_threads_disabled): New function.
1210 * maint.h (worker_threads_disabled): New function.
1211 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1212 here if worker_threads_disabled () is true.
1213 (minimal_symbol_reader::install): Skip all threading if
1214 worker_threads_disabled () is true.
1215
f29d7f6b
CB		 12162019-11-27 Christian Biesinger <cbiesinger@google.com>
1217
1218 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1219 hash code if possible.
1220 (add_minsym_to_demangled_hash_table): Likewise.
1221 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1222 on the background thread.
1223 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1224 Add these fields.
1225
e76b2246
CB		 12262019-11-27 Christian Biesinger <cbiesinger@google.com>
1227
1228 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1229 of the mangled name on the background thread.
1230 * symtab.c (symbol_set_names): Allow passing in the hash of the
1231 linkage_name.
1232 * symtab.h (symbol_set_names): Likewise.
1233
8d9a2568
KB		 12342019-11-27 Kevin Buettner <kevinb@redhat.com>
1235
1236 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1237 physnames are computed for inherited DIEs.
1238
fad03f6e
TT		 12392019-11-27 Tom Tromey <tromey@adacore.com>
1240
1241 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1242 backslashes.
1243 * cp-support.c: Remove unnecessary backslashes.
1244
43678b0a
CB		 12452019-11-27 Christian Biesinger <cbiesinger@google.com>
1246
1247 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1248 with sym->set_linkage_name.
1249 * coffread.c (coff_read_enum_type): Likewise.
1250 * mdebugread.c (parse_symbol): Likewise.
1251 * stabsread.c (patch_block_stabs): Likewise.
1252 (define_symbol): Likewise.
1253 (read_enum_type): Likewise.
1254 (common_block_end): Likewise.
1255 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1256 function.
1257 (SYMBOL_SET_LINKAGE_NAME): Remove.
1258 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1259 with sym->set_linkage_name.
1260
db5960b4
AB		 12612019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1262
1263 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1264 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1265 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1266 * NEWS: Mention new MI command.
1267
7dc42066
AB		 12682019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1269
1270 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1271 '-symbol-info-types', and '-symbol-info-variables'.
1272 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1273 (mi_cmd_symbol_info_types): Declare.
1274 (mi_cmd_symbol_info_variables): Declare.
1275 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1276 (output_debug_symbol): New function.
1277 (output_nondebug_symbol): New function.
1278 (mi_symbol_info): New function.
1279 (mi_info_functions_or_variables): New function.
1280 (mi_cmd_symbol_info_functions): New function.
1281 (mi_cmd_symbol_info_types): New function.
1282 (mi_cmd_symbol_info_variables): New function.
1283 * NEWS: Mention new commands.
1284
5f512a7d
AB		 12852019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1286
1287 * symtab.c (symbol_to_info_string): New function, most content
1288 moved from print_symbol_info, but updated to return a std::string.
1289 (print_symbol_info): Update to use symbol_to_info_string and print
1290 returned string.
1291 * symtab.h (symbol_to_info_string): Declare new function.
1292
470c0b1c
AB		 12932019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1294
1295 * python/python.c (gdbpy_rbreak): Convert to using
1296 global_symbol_searcher.
1297 * symtab.c (file_matches): Convert return type to bool, change
1298 file list to std::vector, update header comment.
1299 (search_symbols): Rename to...
1300 (global_symbol_searcher::search): ...this and update now its
1301 a member function of global_symbol_searcher. Take account of the
1302 changes to file_matches.
1303 (symtab_symbol_info): Convert to using global_symbol_searcher.
1304 (rbreak_command): Likewise.
1305 (search_module_symbols): Likewise.
1306 * symtab.h (enum symbol_search): Update comment.
1307 (search_symbols): Remove declaration.
1308 (class global_symbol_searcher): New class.
1309
57357d9d
TT		 13102019-11-26 Tom Tromey <tromey@adacore.com>
1311
1312 * cp-support.c (_initialize_cp_support): Conditionally initialize
1313 gdb_demangle_attempt_core_dump.
1314
3ea16160
TT		 13152019-11-26 Tom Tromey <tom@tromey.com>
1316
1317 * python/py-function.c (fnpy_init): Update.
1318 * value.h (add_internal_function): Adjust declaration.
1319 * value.c (function_destroyer): Remove.
1320 (do_add_internal_function): Don't set destroyer or copy name.
1321 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1322 Set name_allocated.
1323 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1324 (cmdpy_init): Set name_allocated.
1325 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1326 member.
1327 (~cmd_list_element): Free "name" if needed.
1328
1a6d41c6
TT		 13292019-11-26 Tom Tromey <tom@tromey.com>
1330
1331 * value.h (add_internal_function): Add new overload. Move
1332 documentation from value.h.
1333 * value.c (do_add_internal_function): New function.
1334 (add_internal_function): Use it. Add new overload.
1335 (function_destroyer): Don't free doc.
1336 * python/py-function.c (fnpy_init): Update.
1337
8318f3c3
TT		 13382019-11-26 Tom Tromey <tom@tromey.com>
1339
1340 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1341 (cmdpy_init): Set "doc_allocated".
1342
4da8c3a8
TT		 13432019-11-26 Tom Tromey <tom@tromey.com>
1344
1345 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1346 name of worker thread.
1347 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1348 pthread_setname_np.
1349 * configure, config.in: Rebuild.
1350
971db5e2
TT		 13512019-11-26 Tom Tromey <tom@tromey.com>
1352
1353 * python/python.c (class gdbpy_gil): New.
1354 (struct gdbpy_event): Add constructor, destructor, operator().
1355 (gdbpy_post_event): Use run_on_main_thread.
1356 (gdbpy_initialize_events): Remove.
1357 (do_start_initialization): Update.
1358
22138db6
TT		 13592019-11-26 Tom Tromey <tom@tromey.com>
1360
1361 * NEWS: Add entry.
1362 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1363 commands. Call update_thread_pool_size.
1364 (update_thread_pool_size, maintenance_set_worker_threads): New
1365 functions.
1366 (n_worker_threads): New global.
1367
d55c9a68
TT		 13682019-11-26 Christian Biesinger <cbiesinger@google.com>
1369 Tom Tromey <tom@tromey.com>
1370
1371 * minsyms.c (minimal_symbol_reader::install): Use
1372 parallel_for_each.
1373 * gdbsupport/parallel-for.h: New file.
1374 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1375
a0b57563
CB		 13762019-11-26 Christian Biesinger <cbiesinger@google.com>
1377 Tom Tromey <tom@tromey.com>
1378
1379 * gdbsupport/thread-pool.h: New file.
1380 * gdbsupport/thread-pool.c: New file.
1381 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1382 (HFILES_NO_SRCDIR): Add thread-pool.h.
1383
3b3978bc
TT		 13842019-11-26 Tom Tromey <tom@tromey.com>
1385
1386 * event-top.h (thread_local_segv_handler): Declare.
1387 * event-top.c (thread_local_segv_handler): New global.
1388 (install_handle_sigsegv, handle_sigsegv): New functions.
1389 (async_init_signals): Install SIGSEGV handler.
1390 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1391 thread-local.
1392 (report_failed_demangle): New function.
1393 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1394 handler-setting code, instead use segv_handler. Run warning code
1395 on main thread.
1396
9411c49e
TT		 13972019-11-26 Tom Tromey <tom@tromey.com>
1398
1399 * run-on-main-thread.c: New file.
1400 * run-on-main-thread.h: New file.
1401 * unittests/main-thread-selftests.c: New file.
1402 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1403 main-thread-selftests.c.
1404 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1405 (COMMON_SFILES): Add run-on-main-thread.c.
1406
c3efb965
TT		 14072019-11-26 Tom Tromey <tom@tromey.com>
1408
1409 * main.c (setup_alternate_signal_stack): Remove.
1410 (captured_main_1): Use gdb::alternate_signal_stack.
1411 * gdbsupport/alt-stack.h: New file.
1412
21987b9c
TT		 14132019-11-26 Tom Tromey <tom@tromey.com>
1414
1415 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1416 Remove comment.
1417 (save_original_signals_state, restore_original_signals_state): Use
1418 gdb_sigmask.
1419 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1420 (_initialize_linux_nat): Use gdb_sigmask.
1421 * guile/guile.c (_initialize_guile): Use block_signals.
1422 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1423 * gdbsupport/gdb-sigmask.h: New file.
1424 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1425 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1426 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1427 pthread_sigmask.
1428 * configure, config.in: Rebuild.
1429 * gdbsupport/block-signals.h: New file.
1430
5e030278
TT		 14312019-11-26 Tom Tromey <tom@tromey.com>
1432
1433 * acinclude.m4: Include ax_pthread.m4.
1434 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1435 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1436 (CLIBS): Use PTHREAD_LIBS.
1437 (aclocal_m4_deps): Add ax_pthread.m4.
1438 * config.in, configure: Rebuild.
1439 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1440
5a79c107
TT		 14412019-11-26 Tom Tromey <tom@tromey.com>
1442
1443 * symtab.h (struct minimal_symbol) <name_set>: New member.
1444 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1445 Don't call symbol_set_names.
1446 (minimal_symbol_reader::install): Call symbol_set_names.
1447
aa369509
PW		 14482019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1449
1450 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1451 restore_active_ext_lang, as GIL is needed for (indirectly)
1452 called PyOS_InterruptOccurred.
1453
cadc9cb8
SM		 14542019-11-26 Simon Marchi <simon.marchi@efficios.com>
1455
1456 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1457 definition.
1458
d04afd58
SM		 14592019-11-26 Simon Marchi <simon.marchi@efficios.com>
1460
1461 * remote-sim.c (simulator_command): Make static, remove
1462 declaration.
1463
dd694d77
SM		 14642019-11-26 Simon Marchi <simon.marchi@efficios.com>
1465
1466 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1467 static.
1468 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1469 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1470 (main): Likewise.
1471 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1472 (main): Likewise.
1473 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1474 (main): Likewise.
1475 * unittests/basic_string_view/element_access/char/1.cc (test01):
1476 Likewise.
1477 (main): Likewise.
1478 * unittests/basic_string_view/element_access/char/empty.cc (main):
1479 Likewise.
1480 * unittests/basic_string_view/element_access/char/front_back.cc
1481 (test01): Likewise.
1482 (main): Likewise.
1483 * unittests/basic_string_view/inserters/char/2.cc (test05):
1484 Likewise.
1485 (main): Likewise.
1486 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1487 (test01): Likewise.
1488 (main): Likewise.
1489 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1490 (test01): Likewise.
1491 (main): Likewise.
1492 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1493 Likewise.
1494 * unittests/basic_string_view/operations/compare/char/1.cc
1495 (test01): Likewise.
1496 (main): Likewise.
1497 * unittests/basic_string_view/operations/compare/char/13650.cc
1498 (test01): Likewise.
1499 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1500 Likewise.
1501 (main): Likewise.
1502 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1503 Likewise.
1504 (main): Likewise.
1505 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1506 Likewise.
1507 (main): Likewise.
1508 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1509 Likewise.
1510 (main): Likewise.
1511 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1512 Likewise.
1513 (main): Likewise.
1514 * unittests/basic_string_view/operations/find/char/4.cc (main):
1515 Likewise.
1516 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1517 Likewise.
1518 (main): Likewise.
1519 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1520 Likewise.
1521 (main): Likewise.
1522 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1523 Likewise.
1524 (main): Likewise.
1525 * unittests/basic_string_view/operations/substr/char/1.cc
1526 (test01): Likewise.
1527 (main): Likewise.
1528 * unittests/basic_string_view/operators/char/2.cc (main):
1529 Likewise.
1530 * unittests/optional/assignment/1.cc (test): Likewise.
1531 * unittests/optional/assignment/2.cc (test): Likewise.
1532 * unittests/optional/assignment/3.cc (test): Likewise.
1533 * unittests/optional/assignment/4.cc (test): Likewise.
1534 * unittests/optional/assignment/5.cc (test): Likewise.
1535 * unittests/optional/assignment/6.cc (test): Likewise.
1536 * unittests/optional/assignment/7.cc (test): Likewise.
1537 * unittests/optional/cons/copy.cc (test): Likewise.
1538 * unittests/optional/cons/default.cc (test): Likewise.
1539 * unittests/optional/cons/move.cc (test): Likewise.
1540 * unittests/optional/cons/value.cc (test): Likewise.
1541 * unittests/optional/in_place.cc (test): Likewise.
1542 * unittests/optional/observers/1.cc (test): Likewise.
1543 * unittests/optional/observers/2.cc (test): Likewise.
1544
3b5c1d49
SM		 15452019-11-26 Simon Marchi <simon.marchi@efficios.com>
1546
1547 * tui-win.h (tui_set_var_cmd): Remove.
1548 * tui-win.c (tui_set_var_cmd): Make static.
1549
adce99fe
SM		 15502019-11-26 Simon Marchi <simon.marchi@efficios.com>
1551
1552 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1553 rbreak_command_wrapper): Remove.
1554 * symtab.c (rbreak_command_wrapper): Remove.
1555
fe3adccf
SM		 15562019-11-26 Simon Marchi <simon.marchi@efficios.com>
1557
1558 * inferior.h (info_terminal_command): Remove declaration.
1559 * inflow.c (info_terminal_command): Make static.
1560
b926335f
SM		 15612019-11-26 Simon Marchi <simon.marchi@efficios.com>
1562
1563 * inferior.c (exit_inferior_silent): Remove.
1564
b62f6f54
SM		 15652019-11-26 Simon Marchi <simon.marchi@efficios.com>
1566
1567 * dictionary.c (dict_empty, mdict_empty): Remove.
1568 * dictionary.c (mdict_empty): Remove.
1569
cb8c24b6
SM		 15702019-11-26 Simon Marchi <simon.marchi@efficios.com>
1571
1572 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1573 (arc_insn_get_memory_offset): Likewise.
1574 (arc_insn_dump): Likewise.
1575 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1576 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1577 * dictionary.c (dict_iterator_next): Likewise.
1578 (dict_iter_match_first): Likewise.
1579 (dict_iter_match_next): Likewise.
1580 * f-lang.c (evaluate_subexp_f): Likewise.
1581 * hppa-tdep.c (hppa_read_pc): Likewise.
1582 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1583 * parse.c (write_exp_elt_msym): Likewise.
1584 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1585 * remote.c (remote_packet_size): Likewise.
1586 (remote_notif_stop_parse): Likewise.
1587 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1588 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1589 * source.c (prepare_path_for_appending): Likewise.
1590 * sparc64-linux-tdep.c
1591 (sparc64_linux_handle_segmentation_fault); Likewise.
1592 * stack.c (frame_selection_by_function_completer): Likewise.
1593
781597ff
SM		 15942019-11-26 Simon Marchi <simon.marchi@efficios.com>
1595
1596 * completer.c (set_gdb_completion_word_break_characters):
1597 Remove.
1598
23baa4cc
SM		 15992019-11-26 Simon Marchi <simon.marchi@efficios.com>
1600
1601 * dwarf-index-write.c: Include dwarf-index-write.h.
1602 * mi/mi-interp.c: Include mi/mi-interp.h.
1603
23767560
SM		 16042019-11-26 Simon Marchi <simon.marchi@efficios.com>
1605
1606 * aarch32-tdep.c: Include aarch32-tdep.h.
1607 * aarch32-tdep.h: Forward-declare struct target_desc.
1608
6d91ce9a
CB		 16092019-11-26 Christian Biesinger <cbiesinger@google.com>
1610
1611 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1612 strerror.
1613 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1614 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1615
3cf2f237
TV		 16162019-11-25 Tom de Vries <tdevries@suse.de>
1617
1618 * contrib/words.sh: Add -c option.
1619
5b89c67a
CB		 16202019-11-25 Christian Biesinger <cbiesinger@google.com>
1621
1622 * solib.c (solib_find_1): Change int to bool.
1623 (exec_file_find): Change int to bool.
1624 (solib_find): Change int to bool.
1625 (solib_read_symbols): Change int to bool.
1626 (solib_used): Change int to bool.
1627 (solib_add): Change int to bool.
1628 (info_sharedlibrary_command): Change int to bool.
1629 (solib_contains_address_p): Change int to bool.
1630 (solib_keep_data_in_core): Change int to bool.
1631 (in_solib_dynsym_resolve_code): Change int to bool.
1632 (reload_shared_libraries_1): Change int to bool.
1633 (gdb_sysroot_changed): Change int to bool.
1634 * solib.h (solib_read_symbols): Change int to bool.
1635 (solib_contains_address_p): Change int to bool.
1636 (solib_keep_data_in_core): Change int to bool.
1637 (in_solib_dynsym_resolve_code): Change int to bool.
1638 (libpthread_name_p): Change int to bool.
1639
6cc8564b
LM		 16402019-11-25 Luis Machado <luis.machado@linaro.org>
1641
1642 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1643 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1644 (remote_packet_max_chars): New static global.
1645 (show_remote_packet_max_chars): New function.
1646 (remote_target::putpkt_binary): Adjust to use new
1647 remote_packet_max_chars option.
1648 (remote_target::getpkt_or_notif_sane_1): Likewise.
1649 (_initialize_remote): Register new remote-packet-max-chars option.
1650
a7cdaa91
SM		 16512019-11-24 Simon Marchi <simon.marchi@efficios.com>
1652
1653 * m68k-linux-nat.c: Include gdbarch.h.
1654
26abc753
TT		 16552019-11-24 Tom Tromey <tom@tromey.com>
1656
1657 * symfile.c (read_symbols): Update.
1658 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1659 bool.
1660 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1661 (psym_lookup_symbol, psym_find_last_source_symtab)
1662 (psym_forget_cached_source_info, psym_print_stats)
1663 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1664 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1665 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1666 (psym_find_compunit_symtab_by_address)
1667 (maintenance_print_psymbols, maintenance_info_psymtabs)
1668 (maintenance_check_psymtabs): Update.
1669 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1670 bool.
1671
012fc909
TT		 16722019-11-22 Tom Tromey <tom@tromey.com>
1673
1674 * observable.h: Update comments.
1675
c83d8d32
TT		 16762019-11-22 Tom Tromey <tromey@adacore.com>
1677
1678 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1679 (print_ada_task_info): Don't try to fetch thread id if task is not
1680 alive.
1681
987012b8
CB		 16822019-11-22 Christian Biesinger <cbiesinger@google.com>
1683
1684 * ada-exp.y: Update.
1685 * ada-lang.c (sort_choices): Update.
1686 (ada_print_symbol_signature): Update.
1687 (resolve_subexp): Update.
1688 (ada_parse_renaming): Update.
1689 (ada_read_renaming_var_value): Update.
1690 (lesseq_defined_than): Update.
1691 (remove_extra_symbols): Update.
1692 (remove_irrelevant_renamings): Update.
1693 (ada_add_block_symbols): Update.
1694 (ada_collect_symbol_completion_matches): Update.
1695 (ada_is_renaming_symbol): Update.
1696 (aggregate_assign_from_choices): Update.
1697 (ada_evaluate_subexp): Update.
1698 (ada_has_this_exception_support): Update.
1699 (ada_is_non_standard_exception_sym): Update.
1700 (ada_add_exceptions_from_frame): Update.
1701 (ada_add_global_exceptions): Update.
1702 (ada_print_subexp): Update.
1703 * ax-gdb.c (gen_var_ref): Update.
1704 (gen_maybe_namespace_elt): Update.
1705 (gen_expr_for_cast): Update.
1706 (gen_expr): Update.
1707 * block.h: Update.
1708 * blockframe.c (find_pc_partial_function): Update.
1709 * breakpoint.c (print_breakpoint_location): Update.
1710 (update_static_tracepoint): Update.
1711 * btrace.c (ftrace_print_function_name): Update.
1712 (ftrace_function_switched): Update.
1713 * buildsym.c (find_symbol_in_list): Update.
1714 * c-exp.y: Update.
1715 * c-typeprint.c (c_print_typedef): Update.
1716 (c_type_print_template_args): Update.
1717 * cli/cli-cmds.c (edit_command): Update.
1718 (list_command): Update.
1719 (print_sal_location): Update.
1720 * coffread.c (patch_opaque_types): Update.
1721 (process_coff_symbol): Update.
1722 (coff_read_enum_type): Update.
1723 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1724 (convert_one_symbol): Update.
1725 (hash_symname): Update.
1726 (eq_symname): Update.
1727 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1728 * compile/compile-cplus-types.c (debug_print_scope): Update.
1729 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1730 * compile/compile-object-load.c (get_out_value_type): Update.
1731 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1732 (search_symbol_list): Update.
1733 (cp_lookup_symbol_imports_or_template): Update.
1734 * cp-support.c (overload_list_add_symbol): Update.
1735 * ctfread.c (psymtab_to_symtab): Update.
1736 * dbxread.c (cp_set_block_scope): Update.
1737 * dictionary.c (iter_match_first_hashed): Update.
1738 (iter_match_next_hashed): Update.
1739 (insert_symbol_hashed): Update.
1740 (iter_match_next_linear): Update.
1741 * dictionary.h: Update.
1742 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1743 (locexpr_describe_location_piece): Update.
1744 (locexpr_describe_location_1): Update.
1745 (locexpr_generate_c_location): Update.
1746 (loclist_describe_location): Update.
1747 (loclist_generate_c_location): Update.
1748 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1749 (read_func_scope): Update.
1750 (process_enumeration_scope): Update.
1751 (new_symbol): Update.
1752 (dwarf2_const_value): Update.
1753 (dwarf2_symbol_mark_computed): Update.
1754 * eval.c (evaluate_funcall): Update.
1755 (evaluate_subexp_standard): Update.
1756 * expprint.c (print_subexp_standard): Update.
1757 (dump_subexp_body_standard): Update.
1758 * f-valprint.c (info_common_command_for_block): Update.
1759 * findvar.c (get_hosting_frame): Update.
1760 (default_read_var_value): Update.
1761 * go-lang.c (go_symbol_package_name): Update.
1762 * guile/scm-block.c (bkscm_print_block_smob): Update.
1763 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1764 (gdbscm_symbol_name): Update.
1765 (gdbscm_symbol_linkage_name): Update.
1766 (gdbscm_symbol_print_name): Update.
1767 * infcall.c (get_function_name): Update.
1768 * infcmd.c (jump_command): Update.
1769 (finish_command): Update.
1770 * infrun.c (insert_exception_resume_breakpoint): Update.
1771 * linespec.c (canonicalize_linespec): Update.
1772 (create_sals_line_offset): Update.
1773 (convert_linespec_to_sals): Update.
1774 (complete_label): Update.
1775 (find_label_symbols_in_block): Update.
1776 * m2-typeprint.c (m2_print_typedef): Update.
1777 * mdebugread.c (mdebug_reg_to_regnum): Update.
1778 (parse_symbol): Update.
1779 (mylookup_symbol): Update.
1780 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1781 (list_args_or_locals): Update.
1782 * objc-lang.c (compare_selectors): Update.
1783 (info_selectors_command): Update.
1784 (compare_classes): Update.
1785 (info_classes_command): Update.
1786 (find_imps): Update.
1787 * p-typeprint.c (pascal_print_typedef): Update.
1788 * printcmd.c (build_address_symbolic): Update.
1789 (info_address_command): Update.
1790 (print_variable_and_value): Update.
1791 * python/py-framefilter.c (extract_sym): Update.
1792 (py_print_single_arg): Update.
1793 * python/py-symbol.c (sympy_str): Update.
1794 (sympy_get_name): Update.
1795 (sympy_get_linkage_name): Update.
1796 * python/python.c (gdbpy_rbreak): Update.
1797 * record-btrace.c (btrace_get_bfun_name): Update.
1798 (btrace_call_history): Update.
1799 * rust-lang.c (rust_print_typedef): Update.
1800 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1801 * stabsread.c (stab_reg_to_regnum): Update.
1802 (define_symbol): Update.
1803 (read_enum_type): Update.
1804 (common_block_end): Update.
1805 (cleanup_undefined_types_1): Update.
1806 (scan_file_globals): Update.
1807 * stack.c (print_frame_arg): Update.
1808 (print_frame_args): Update.
1809 (find_frame_funname): Update.
1810 (info_frame_command_core): Update.
1811 (iterate_over_block_locals): Update.
1812 (print_block_frame_labels): Update.
1813 (do_print_variable_and_value): Update.
1814 (iterate_over_block_arg_vars): Update.
1815 (return_command): Update.
1816 * symmisc.c (dump_symtab_1): Update.
1817 (print_symbol): Update.
1818 * symtab.c (eq_symbol_entry): Update.
1819 (symbol_cache_dump): Update.
1820 (lookup_language_this): Update.
1821 (find_pc_sect_line): Update.
1822 (skip_prologue_sal): Update.
1823 (symbol_search::compare_search_syms): Update.
1824 (treg_matches_sym_type_name): Update.
1825 (search_symbols): Update.
1826 (print_symbol_info): Update.
1827 (rbreak_command): Update.
1828 (completion_list_add_symbol): Update.
1829 (find_gnu_ifunc): Update.
1830 (get_symbol_address): Update.
1831 (search_module_symbols): Update.
1832 (info_module_subcommand): Update.
1833 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1834 (SYMBOL_LINKAGE_NAME): Remove.
1835 (SYMBOL_DEMANGLED_NAME): Remove.
1836 (SYMBOL_PRINT_NAME): Remove.
1837 (SYMBOL_SEARCH_NAME): Remove.
1838 * tracepoint.c (set_traceframe_context): Update.
1839 (validate_actionline): Update.
1840 (collection_list::collect_symbol): Update.
1841 (encode_actions_1): Update.
1842 (info_scope_command): Update.
1843 (print_one_static_tracepoint_marker): Update.
1844 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1845 * valops.c (address_of_variable): Update.
1846 (find_overload_match): Update.
1847 (find_oload_champ): Update.
1848
c9d95fa3
CB		 18492019-11-22 Christian Biesinger <cbiesinger@google.com>
1850
1851 * ada-lang.c (ada_lookup_simple_minsym): Update.
1852 (ada_collect_symbol_completion_matches): Update.
1853 * ada-tasks.c (read_atcb): Update.
1854 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1855 (amd64_windows_skip_trampoline_code): Update.
1856 * arm-tdep.c (skip_prologue_function): Update.
1857 (arm_skip_stack_protector): Update.
1858 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1859 (arm_wince_skip_main_prologue): Update.
1860 * ax-gdb.c (gen_expr): Update.
1861 * block.c (call_site_for_pc): Update.
1862 * blockframe.c (find_pc_partial_function): Update.
1863 * breakpoint.c (set_breakpoint_location_function): Update.
1864 * btrace.c (ftrace_print_function_name): Update.
1865 (ftrace_function_switched): Update.
1866 * c-valprint.c (print_unpacked_pointer): Update.
1867 * coffread.c (coff_symfile_read): Update.
1868 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1869 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1870 * dwarf-index-write.c (write_psymbols): Update.
1871 * dwarf2loc.c (call_site_to_target_addr): Update.
1872 (func_verify_no_selftailcall): Update.
1873 (tailcall_dump): Update.
1874 (call_site_find_chain_1): Update.
1875 (dwarf_expr_reg_to_entry_parameter): Update.
1876 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1877 * eval.c (evaluate_funcall): Update.
1878 (evaluate_subexp_standard): Update.
1879 (evaluate_subexp_for_sizeof): Update.
1880 * expprint.c (print_subexp_standard): Update.
1881 (dump_subexp_body_standard): Update.
1882 * frame.c (get_prev_frame_always_1): Update.
1883 * frv-tdep.c (frv_skip_main_prologue): Update.
1884 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1885 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1886 (gnuv3_get_typename_from_type_info): Update.
1887 (gnuv3_skip_trampoline): Update.
1888 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1889 * i386-tdep.c (i386_skip_main_prologue): Update.
1890 (i386_pe_skip_trampoline_code): Update.
1891 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1892 * infcall.c (get_function_name): Update.
1893 * linespec.c (minsym_found): Update.
1894 * linux-fork.c (info_checkpoints_command): Update.
1895 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1896 (m32c_m16c_pointer_to_address): Update.
1897 * maint.c (maintenance_translate_address): Update.
1898 * minsyms.c (add_minsym_to_hash_table): Update.
1899 (add_minsym_to_demangled_hash_table): Update.
1900 (lookup_minimal_symbol_mangled): Update.
1901 (lookup_minimal_symbol_demangled): Update.
1902 (lookup_minimal_symbol_linkage): Update.
1903 (lookup_minimal_symbol_text): Update.
1904 (lookup_minimal_symbol_by_pc_name): Update.
1905 (minimal_symbol_is_less_than): Update.
1906 (compact_minimal_symbols): Update.
1907 (build_minimal_symbol_hash_tables): Update.
1908 (find_solib_trampoline_target): Update.
1909 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1910 (mips_skip_pic_trampoline_code): Update.
1911 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1912 * objc-lang.c (info_selectors_command): Update.
1913 (info_classes_command): Update.
1914 (find_methods): Update.
1915 (find_imps): Update.
1916 * p-valprint.c (pascal_val_print): Update.
1917 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1918 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1919 * printcmd.c (build_address_symbolic): Update.
1920 (info_symbol_command): Update.
1921 * psymtab.c (psymbol_name_matches): Update.
1922 (match_partial_symbol): Update.
1923 (lookup_partial_symbol): Update.
1924 (print_partial_symbols): Update.
1925 (sort_pst_symbols): Update.
1926 (maintenance_check_psymtabs): Update.
1927 * python/py-framefilter.c (py_print_frame): Update.
1928 * python/python.c (gdbpy_rbreak): Update.
1929 * record-btrace.c (btrace_get_bfun_name): Update.
1930 (btrace_call_history): Update.
1931 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1932 (rs6000_skip_trampoline_code): Update.
1933 * sol-thread.c (info_cb): Update.
1934 * stabsread.c (scan_file_globals): Update.
1935 * stack.c (find_frame_funname): Update.
1936 (info_frame_command_core): Update.
1937 * symmisc.c (dump_msymbols): Update.
1938 * symtab.c (symbol_natural_name): Rename to..,
1939 (general_symbol_info::natural_name): ...this.
1940 (symbol_demangled_name): Rename to...
1941 (general_symbol_info::demangled_name): ...this.
1942 (symbol_search_name): Rename to...
1943 (general_symbol_info::search_name): ...this.
1944 (symbol_matches_search_name): Update.
1945 (find_pc_sect_line): Update.
1946 (skip_prologue_sal): Update.
1947 (search_symbols): Update.
1948 (print_msymbol_info): Update.
1949 (rbreak_command): Update.
1950 (completion_list_add_msymbol): Update.
1951 (completion_list_objc_symbol): Update.
1952 (get_msymbol_address): Update.
1953 * symtab.h (struct general_symbol_info): Add member functions
1954 natural_name (), linkage_name (), print_name (), demangled_name (),
1955 and search_name ().
1956 (SYMBOL_NATURAL_NAME): Update.
1957 (symbol_natural_name): Move to a member function on general_symbol_info.
1958 (SYMBOL_DEMANGLED_NAME): Update.
1959 (symbol_demangled_name): Move to a member function on
1960 general_symbol_info.
1961 (SYMBOL_SEARCH_NAME): Update.
1962 (symbol_search_name): Move to a member function on general_symbol_info.
1963 (MSYMBOL_NATURAL_NAME): Remove.
1964 (MSYMBOL_LINKAGE_NAME): Remove.
1965 (MSYMBOL_PRINT_NAME): Remove.
1966 (MSYMBOL_DEMANGLED_NAME): Remove.
1967 (MSYMBOL_SEARCH_NAME): Remove.
1968 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1969
f8bab2d6
CB		 19702019-11-22 Christian Biesinger <cbiesinger@google.com>
1971
1972 * symtab.c (create_demangled_names_hash): Use per_bfd->
1973 minimal_symbol_count for computing the initial size, if greater
1974 than our default size.
1975
85e7588d
TV		 19762019-11-22 Tom de Vries <tdevries@suse.de>
1977
1978 * contrib/words.sh: Improve words extraction.
1979
f6180073
TV		 19802019-11-22 Tom de Vries <tdevries@suse.de>
1981
1982 * contrib/words.sh: Combine sed invocations.
1983
f10ffa41
CB		 19842019-11-21 Christian Biesinger <cbiesinger@google.com>
1985
1986 * Makefile.in: Update.
1987 * demangle.c: Rename to...
1988 * gdb-demangle.c: ..this.
1989 (is_cplus_marker): Change return type to bool.
1990 (_initialize_demangler): Rename to...
1991 (_initialize_gdb_demangle): ...this.
1992 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1993 * symtab.h (demangle): Remove declaration; instead include
1994 gdb-demangle.h.
1995
6ba18521
TT		 19962019-11-21 Tom Tromey <tromey@adacore.com>
1997
1998 * gdbsupport/format.c (format_pieces): Parse %I64d.
1999 * unittests/format_pieces-selftests.c (test_windows_formats): New
2000 function.
2001 (run_tests): Call it.
2002
34877895
PJ		 20032019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2004
2005 Byte reverse display of variables with DW_END_big, DW_END_little
2006 (DW_AT_endianity) dwarf attributes if different than the native
2007 byte order.
2008 * ada-lang.c (ada_value_binop):
2009 Use type_byte_order instead of gdbarch_byte_order.
2010 * ada-valprint.c (printstr):
2011 (ada_val_print_string):
2012 * ada-lang.c (value_pointer):
2013 (ada_value_binop):
2014 Use type_byte_order instead of gdbarch_byte_order.
2015 * c-lang.c (c_get_string):
2016 Use type_byte_order instead of gdbarch_byte_order.
2017 * c-valprint.c (c_val_print_array):
2018 Use type_byte_order instead of gdbarch_byte_order.
2019 * cp-valprint.c (cp_print_class_member):
2020 Use type_byte_order instead of gdbarch_byte_order.
2021 * dwarf2loc.c (rw_pieced_value):
2022 Use type_byte_order instead of gdbarch_byte_order.
2023 * dwarf2read.c (read_base_type): Handle DW_END_big,
2024 DW_END_little
2025 * f-lang.c (f_get_encoding):
2026 Use type_byte_order instead of gdbarch_byte_order.
2027 * findvar.c (default_read_var_value):
2028 Use type_byte_order instead of gdbarch_byte_order.
2029 * gdbtypes.c (check_types_equal):
2030 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2031 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2032 and TYPE_ENDIANITY_LITTLE if set.
2033 (type_byte_order): new function.
2034 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2035 (struct main_type) <flag_endianity_not_default>:
2036 New field.
2037 (type_byte_order): New function.
2038 * infcmd.c (default_print_one_register_info):
2039 Use type_byte_order instead of gdbarch_byte_order.
2040 * p-lang.c (pascal_printstr):
2041 Use type_byte_order instead of gdbarch_byte_order.
2042 * p-valprint.c (pascal_val_print):
2043 Use type_byte_order instead of gdbarch_byte_order.
2044 * printcmd.c (print_scalar_formatted):
2045 Use type_byte_order instead of gdbarch_byte_order.
2046 * solib-darwin.c (darwin_current_sos):
2047 Use type_byte_order instead of gdbarch_byte_order.
2048 * solib-svr4.c (solib_svr4_r_ldsomap):
2049 Use type_byte_order instead of gdbarch_byte_order.
2050 * stap-probe.c (stap_modify_semaphore):
2051 Use type_byte_order instead of gdbarch_byte_order.
2052 * target-float.c (target_float_same_format_p):
2053 Use type_byte_order instead of gdbarch_byte_order.
2054 * valarith.c (scalar_binop):
2055 (value_bit_index):
2056 Use type_byte_order instead of gdbarch_byte_order.
2057 * valops.c (value_cast):
2058 Use type_byte_order instead of gdbarch_byte_order.
2059 * valprint.c (generic_emit_char):
2060 (generic_printstr):
2061 (val_print_string):
2062 Use type_byte_order instead of gdbarch_byte_order.
2063 * value.c (unpack_long):
2064 (unpack_bits_as_long):
2065 (unpack_value_bitfield):
2066 (modify_field):
2067 (pack_long):
2068 (pack_unsigned_long):
2069 Use type_byte_order instead of gdbarch_byte_order.
2070 * findvar.c (unsigned_pointer_to_address):
2071 (signed_pointer_to_address):
2072 (unsigned_address_to_pointer):
2073 (address_to_signed_pointer):
2074 (default_read_var_value):
2075 (default_value_from_register):
2076 Use type_byte_order instead of gdbarch_byte_order.
2077 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2078 Use type_byte_order instead of gdbarch_byte_order.
2079 * riscv-tdep.c (riscv_print_one_register_info):
2080 Use type_byte_order instead of gdbarch_byte_order.
2081
87fb00ea
SM		 20822019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2083
2084 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2085 (current_ui_gdb_stdin_ptr): Likewise.
2086 (current_ui_gdb_stderr_ptr): Likewise.
2087 (current_ui_gdb_stdlog_ptr): Likewise.
2088 (current_ui_current_uiout_ptr): Likewise.
2089 (gen_ret_current_ui_field_ptr): Remove.
2090
65d1cd5f
TV		 20912019-11-21 Tom de Vries <tdevries@suse.de>
2092
2093 PR gdb/24956
2094 * cli/cli-script.c (execute_control_command): Only switch to
2095 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2096
9f6ad286
TT		 20972019-11-19 Tom Tromey <tom@tromey.com>
2098
2099 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2100 Now static. Change type of "name".
2101 (tui_set_win_height_command): Don't copy "arg".
2102 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2103 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2104
435d3d88
AT		 21052019-11-19 Ali Tamur <tamur@google.com>
2106
2107 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2108 "if (attr != nullptr)".
2109 (dwarf2_find_base_address): Likewise.
2110 (dwarf2_build_include_psymtabs): Likewise.
2111 (read_cutu_die_from_dwo): Likewise.
2112 (read_func_scope): Likewise.
2113 (read_call_site_scope): Likewise.
2114 (dwarf2_get_pc_bounds): Likewise.
2115 (dwarf2_record_block_ranges): Likewise.
2116 (dwarf2_add_field): Likewise.
2117 (dwarf2_add_member_fn): Likewise.
2118 (read_structure_type): Likewise.
2119 (read_enumeration_type): Likewise.
2120 (read_array_type): Likewise.
2121 (read_array_order): Likewise.
2122 (read_set_type): Likewise.
2123 (read_common_block): Likewise.
2124 (read_tag_reference_type): Likewise.
2125 (read_tag_string_type): Likewise.
2126 (read_subroutine_type): Likewise.
2127 (read_base_type): Likewise.
2128 (read_subrange_type): Likewise.
2129 (new_symbol): Likewise.
2130 (prepare_one_comp_unit): Likewise.
2131
c9739b6a
TT		 21322019-11-19 Tom Tromey <tromey@adacore.com>
2133
2134 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2135 result in error when DebugActiveProcess fails.
2136
494409bb
SDJ		 21372019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2138 Pedro Alves <palves@redhat.com>
2139
2140 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2141 * target.c (target_stack::push): Call 'unpush' if there's a
2142 target on top of the stack.
2143
2e953aca
PW		 21442019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2145
2146 * python/py-block.c (blpy_dealloc): Call tp_free.
2147 (blpy_block_syms_dealloc): Likewise.
2148 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2149 * python/py-inferior.c (infpy_dealloc): Likewise.
2150 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2151 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2152 * python/py-symbol.c (sympy_dealloc): Likewise.
2153 * python/py-symtab.c (stpy_dealloc): Likewise.
2154 * python/py-type.c (typy_iterator_dealloc): Likewise.
2155
6edc43ec
CB		 21562019-11-18 Christian Biesinger <cbiesinger@google.com>
2157
2158 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2159 constructor instead of using a class initializer.
2160
cd850b40
CB		 21612019-11-15 Christian Biesinger <cbiesinger@google.com>
2162
2163 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2164 * configure: Regenerate.
2165 * configure.ac: Don't source common.host.
2166 * gdbsupport/common.host: Remove.
2167 * gdbsupport/mingw-strerror.c: Remove.
2168 * gdbsupport/posix-strerror.c: Rename to...
2169 * gdbsupport/safe-strerror.c: ...this.
2170
53fea9c7
CB		 21712019-11-15 Christian Biesinger <cbiesinger@google.com>
2172
2173 * maint.c (scoped_command_stats::print_time): Use localtime_r
2174 instead of localtime (provided through gnulib if necessary).
2175 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2176 of ctime.
2177
f8e27d88
CB		 21782019-11-15 Christian Biesinger <cbiesinger@google.com>
2179
2180 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2181 avoid compile errors.
2182
5abebf3c
CB		 21832019-11-15 Christian Biesinger <cbiesinger@google.com>
2184
2185 * config.in: Regenerate.
2186 * configure: Regenerate.
2187 * gdbsupport/common.m4: No longer check for strerror_r.
2188 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2189 POSIX version of strerror_r, now that gnulib provides it if
2190 necessary.
2191
9a351667
CB		 21922019-11-14 Christian Biesinger <cbiesinger@google.com>
2193
2194 * README (`configure' options): Update.
2195
55708e99
TT		 21962019-11-14 Tom Tromey <tromey@adacore.com>
2197
2198 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2199 expected type for the RHS if the LHS is a convenience variable.
2200
4b09bb2e
SM		 22012019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2202
2203 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2204 Provide explicit default and copy constructor.
2205
bd454f8b
PW		 22062019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2207
2208 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2209 only call Py_INCREF (newbp) in the bppy_pending_object case.
2210
d1aa3cf0
TT		 22112019-11-13 Tom Tromey <tromey@adacore.com>
2212
2213 PR build/25182:
2214 * psympriv.h (partial_symbol): Remove static assert.
2215 * symtab.h (general_symbol_info, symbol): Remove static assert.
2216
e06f3d6e
AB		 22172019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2218
2219 * gdbsupport/format.c (format_pieces::format_pieces): Support
2220 printf 'z' size modifier.
2221 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2222 * printcmd.c (ui_printf): Handle size_t_arg.
2223 * ui-out.c (ui_out::vmessage): Likewise.
2224 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2225 function.
2226 (run_tests): Call test_format_int_sizes.
2227
468c0cbb
CB		 22282019-11-12 Christian Biesinger <cbiesinger@google.com>
2229
2230 * ada-exp.y (write_ambiguous_var): Update.
2231 * buildsym.c (add_symbol_to_list): Update.
2232 * dwarf2read.c (read_variable): Update.
2233 (new_symbol): Update.
2234 * jit.c (finalize_symtab): Update.
2235 * language.c (language_alloc_type_symbol): Update.
2236 * symtab.c (fixup_symbol_section): Update.
2237 (initialize_objfile_symbol_1): Move code to...
2238 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2239 (allocate_symbol): Update.
2240 (allocate_template_symbol): Update.
2241 (get_symbol_address): Update.
2242 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2243 of having as a field, and add a constructor.
2244 (SYMBOL_VALUE): Update.
2245 (SYMBOL_VALUE_ADDRESS): Update.
2246 (SET_SYMBOL_VALUE_ADDRESS): Update.
2247 (SYMBOL_VALUE_BYTES): Update.
2248 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2249 (SYMBOL_BLOCK_VALUE): Update.
2250 (SYMBOL_VALUE_CHAIN): Update.
2251 (SYMBOL_LANGUAGE): Update.
2252 (SYMBOL_SECTION): Update.
2253 (SYMBOL_OBJ_SECTION): Update.
2254 (SYMBOL_SET_LANGUAGE): Update.
2255 (SYMBOL_SET_LINKAGE_NAME): Update.
2256 (SYMBOL_SET_NAMES): Update.
2257 (SYMBOL_NATURAL_NAME): Update.
2258 (SYMBOL_LINKAGE_NAME): Update.
2259 (SYMBOL_DEMANGLED_NAME): Update.
2260 (SYMBOL_SEARCH_NAME): Update.
2261 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2262 (struct symbol): Update.
2263 (struct template_symbol): Update.
2264 (struct rust_vtable_symbol): Update.
2265 * xcoffread.c (SYMBOL_DUP): Update.
2266
ed2c82c3
TT		 22672019-11-12 Tom Tromey <tom@tromey.com>
2268
2269 * tui/tui-layout.c (show_layout): Set current_layout.
2270 (show_source_disasm_command, show_data)
2271 (show_source_or_disasm_and_command): Don't set current_layout.
2272
d9fcefd5
TT		 22732019-11-12 Tom Tromey <tom@tromey.com>
2274
2275 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2276
45e42163
TT		 22772019-11-12 Tom Tromey <tom@tromey.com>
2278
2279 * tui/tui-win.c (resize_message): New global.
2280 (show_tui_resize_message): New function.
2281 (tui_async_resize_screen): Print message if requested.
2282 (_initialize_tui_win): Add tui-resize-message setting.
2283 * NEWS: Add entry for new commands.
2284
c86d74cc
TT		 22852019-11-11 Tom Tromey <tom@tromey.com>
2286
2287 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2288 functions.
2289
7b7b9424
CB		 22902019-11-11 Christian Biesinger <cbiesinger@google.com>
2291
2292 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2293
086baaf1
AB		 22942019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2295
2296 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2297 function.
2298 * python/python-internal.h (gdbpy_lookup_static_symbols):
2299 Declare new function.
2300 * python/python.c (python_GdbMethods): Add
2301 gdb.lookup_static_symbols method.
2302 * NEWS: Mention gdb.lookup_static_symbols.
2303
09ff83af
AB		 23042019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2305
2306 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2307 static block of current object file first. Also fix typo in
2308 header comment.
2309
eb2dd8df
AB		 23102019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2311
2312 * stack.c (set_last_displayed_sal): Delete.
2313 (last_displayed_sal_valid): Delete.
2314 (last_displayed_pspace): Delete.
2315 (last_displayed_addr): Delete.
2316 (last_displayed_symtab): Delete.
2317 (last_displayed_line): Delete.
2318 (class last_displayed_symtab_info_type): New.
2319 (last_displayed_symtab_info): New static global variable.
2320 (print_frame_info): Call methods on last_displayed_symtab_info.
2321 (clear_last_displayed_sal): Update header comment, and make use of
2322 last_displayed_symtab_info.
2323 (last_displayed_sal_is_valid): Likewise.
2324 (get_last_displayed_pspace): Likewise.
2325 (get_last_displayed_addr): Likewise.
2326 (get_last_displayed_symtab): Likewise.
2327 (get_last_displayed_line): Likewise.
2328 (get_last_displayed_sal): Likewise.
2329 * stack.h (clear_last_displayed_sal): Update header comment.
2330 (last_displayed_sal_is_valid): Likewise.
2331 (get_last_displayed_pspace): Likewise.
2332 (get_last_displayed_addr): Likewise.
2333 (get_last_displayed_symtab): Likewise.
2334 (get_last_displayed_line): Likewise.
2335 (get_last_displayed_sal): Likewise.
2336
62137775
AB		 23372019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2338
2339 * stack.c (frame_show_address): Convert return type to bool.
2340 * stack.h (frame_show_address): Likewise, and update header
2341 comment.
2342
cf57ad6d
AB		 23432019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2344
2345 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2346 * unittests/vec-utils-selftests.c: New file.
2347 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2348
0b026263
TT		 23492019-11-10 Tom Tromey <tom@tromey.com>
2350
2351 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2352 (tui_highlight_win): Likewise.
2353 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2354 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2355 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2356 Don't set can_highlight.
2357
b049ce2d
TT		 23582019-11-10 Tom Tromey <tom@tromey.com>
2359
2360 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2361 Remove unused declaration.
2362
992a7040
TT		 23632019-11-08 Tom Tromey <tromey@adacore.com>
2364
2365 * top.c (read_command_file): Update.
2366 (command_line_input): Make return type const.
2367 * python/py-gdb-readline.c: Update.
2368 * linespec.c (decode_line_2): Update.
2369 * defs.h (command_line_input): Make return type const.
2370 * cli/cli-script.c (read_next_line): Make return type const.
2371 * ada-lang.c (get_selections): Update.
2372
ca3a04f6
CB		 23732019-11-06 Christian Biesinger <cbiesinger@google.com>
2374
2375 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2376 * mi/mi-main.c (output_cores): Likewise.
2377 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2378 (linux_xfer_osdata_modules): Likewise.
2379 * remote.c (register_remote_support_xml): Likewise.
2380 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2381 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2382
e0eac551
TT		 23832019-11-06 Tom Tromey <tom@tromey.com>
2384
2385 * tui/tui-interp.c: Don't include readline.h.
2386 * tui/tui-hooks.c: Don't include readline.h.
2387 * symmisc.c: Include tilde.h, not readline.h.
2388 * symfile.c: Include tilde.h, not readline.h.
2389 * source.c: Include tilde.h, not readline.h.
2390 * solib.c: Include tilde.h, not readline.h.
2391 * psymtab.c: Include tilde.h, not readline.h.
2392 * exec.c: Include tilde.h, not readline.h.
2393 * corelow.c: Include tilde.h, not readline.h.
2394 * cli/cli-dump.c: Include tilde.h, not readline.h.
2395 * cli/cli-cmds.c: Don't include readline.h.
2396
825165c5
TT		 23972019-11-05 Tom Tromey <tom@tromey.com>
2398
2399 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2400 (tui_disassemble): Set addr_size.
2401 (tui_disasm_window::set_contents): Use addr_size.
2402
91ae903f
TT		 24032019-11-05 Tom Tromey <tom@tromey.com>
2404
2405 * rust-lang.c (rust_language_defn): Update.
2406 * python/py-value.c (valpy_string): Call c_get_string.
2407 * p-lang.c (pascal_language_defn): Update.
2408 * opencl-lang.c (opencl_language_defn): Update.
2409 * objc-lang.c (objc_language_defn): Update.
2410 * m2-lang.c (m2_language_defn): Update.
2411 * language.c (unknown_language_defn, auto_language_defn): Update.
2412 (default_get_string): Remove.
2413 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2414 * go-lang.c (go_language_defn): Update.
2415 * f-lang.c (f_language_defn): Update.
2416 * d-lang.c (d_language_defn): Update.
2417 * c-lang.c (c_language_defn, cplus_language_defn)
2418 (asm_language_defn, minimal_language_defn): Update.
2419 * ada-lang.c (ada_language_defn): Update.
2420 * language.h (struct language_defn) <la_get_string>: Remove.
2421 (LA_GET_STRING): Remove.
2422 (default_get_string): Don't declare.
2423
1df2f9ef
TT		 24242019-11-05 Tom Tromey <tom@tromey.com>
2425
2426 * tui/tui-source.h (struct tui_source_window): Inline
2427 constructor. Remove destructor.
2428 <style_changed, m_observable>: Move to superclass.
2429 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2430 (struct tui_source_window_base): Move private members to end.
2431 <style_changed, m_observable>: Move from tui_source_window.
2432 * tui/tui-winsource.c (tui_copy_source_line): Move from
2433 tui-source.c. Rename from copy_source_line. Add special handling
2434 for negative line number.
2435 (tui_source_window_base::style_changed): Move from
2436 tui_source_window.
2437 (tui_source_window_base): Register observer.
2438 (~tui_source_window_base): New.
2439 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2440 rename.
2441 (tui_source_window::set_contents): Use tui_copy_source_line.
2442 (tui_source_window::tui_source_window): Move to tui-source.h.
2443 (tui_source_window::~tui_source_window): Remove.
2444 (tui_source_window::style_changed): Move to superclass.
2445 * tui/tui-disasm.c (tui_disassemble): Create string file with
2446 styling, when possible. Add "addr_size" parameter.
2447 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2448 Don't compute maximum size.
2449 (len_without_escapes): New function
2450
5d051055
TT		 24512019-11-05 Tom Tromey <tom@tromey.com>
2452
2453 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2454 std::string.
2455 * tui/tui-winsource.c (tui_show_source_line): Update.
2456 * tui/tui-source.c (tui_source_window::set_contents): Update.
2457 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2458
ade7beea
CB		 24592019-11-05 Christian Biesinger <cbiesinger@google.com>
2460
2461 * symtab.h (gdb_static_assert): Put && operator at the beginning
2462 of the line instead of the end.
2463
3573abe1
CB		 24642019-11-04 Christian Biesinger <cbiesinger@google.com>
2465
2466 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2467 and sizeof (symbol).
2468 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2469
dae8b3eb
RO		 24702019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2471
2472 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2473 * configure.host: Mark *-*-solaris2.10* obsolete.
2474 * configure.tgt: Mark Solaris < 11 obsolete.
2475 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2476 Update target triplet.
2477
5df96a4e
TT		 24782019-11-01 Tom Tromey <tromey@adacore.com>
2479
2480 * utils.c (print_sys_errmsg): Simplify.
2481
b7481649
TT		 24822019-11-01 Tom Tromey <tromey@adacore.com>
2483
2484 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2485
e48f6033
CB		 24862019-11-01 Christian Biesinger <cbiesinger@google.com>
2487
2488 * configure: Regenerate.
2489 * configure.ac: Remove check for strerror_r.
2490 * gdbsupport/common.m4: Check for strerror_r.
2491
bd5766ec
LM		 24922019-11-01 Luis Machado <luis.machado@linaro.org>
2493
2494 PR gdb/25124
2495
2496 * arm-tdep.c (arm_per_objfile): Rename to ...
2497 (arm_per_bfd): ... this.
2498 (arm_objfile_data_key): Rename to ...
2499 (arm_bfd_data_key): ... this.
2500 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2501 data.
2502 (arm_record_special_symbol): Likewise.
2503
e1709896
AB		 25042019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2505
2506 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2507 end.
2508 * c-typeprint.c (c_print_typedef): Likewise.
2509 * f-typeprint.c (f_print_typedef): Likewise.
2510 * m2-typeprint.c (m2_print_typedef): Likewise.
2511 * p-typeprint.c (pascal_print_typedef): Likewise.
2512 * rust-lang.c (rust_print_typedef): Likewise.
2513 * symtab.c (print_symbol_info): Print a newline after calling
2514 typedef_print.
2515
165f8965
AB		 25162019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2517
2518 * symtab.c (info_module_cmdlist): New variable.
2519 (info_module_command): New function.
2520 (search_module_symbols): New function.
2521 (info_module_subcommand): New function.
2522 (struct info_modules_var_func_options): New struct.
2523 (info_modules_var_func_options_defs): New variable.
2524 (make_info_modules_var_func_options_def_group): New function.
2525 (info_module_functions_command): New function.
2526 (info_module_variables_command): New function.
2527 (info_module_var_func_command_completer): New function.
2528 (_initialize_symtab): Register new 'info module functions' and
2529 'info module variables' commands.
2530 * symtab.h (typedef symbol_search_in_module): New typedef.
2531 (search_module_symbols): Declare new function.
2532 * NEWS: Mention new commands.
2533
59c35742
AB		 25342019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2535
2536 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2537 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2538 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2539 MODULES_DOMAIN.
2540 (scan_partial_symbols): Only create partial module symbols for non
2541 declarations.
2542 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2543 and MODULES_DOMAIN.
2544 * symtab.c (search_domain_name): Likewise.
2545 (search_symbols): Likewise.
2546 (print_symbol_info): Likewise.
2547 (symtab_symbol_info): Likewise.
2548 (info_modules_command): New function.
2549 (_initialize_symtab): Register 'info modules' command.
2550 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2551 * NEWS: Mention new 'info modules' command.
2552
aed61d02
PW		 25532019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2554
2555 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2556 and $_gdb_maint_setting_str.
2557
9ad9b77d
PW		 25582019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2559
2560 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2561 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2562 (str_value_from_setting, gdb_setting_str_internal_fn)
2563 (gdb_maint_setting_str_internal_fn): New functions.
2564 (_initialize_cli_cmds): Define the new convenience functions.
2565 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2566 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2567
8d6efaa2
CB		 25682019-10-31 Christian Biesinger <cbiesinger@google.com>
2569
2570 * agent.c (set_can_use_agent): When the setting is turned on,
2571 look up agent symbols if we don't have them yet.
2572 (agent_new_objfile): Don't look up agent symbols when the agent
2573 setting is off.
2574
33cb1647
CB		 25752019-10-31 Christian Biesinger <cbiesinger@google.com>
2576
2577 * config.in: Regenerate.
2578
b231e86a
CB		 25792019-10-31 Christian Biesinger <cbiesinger@google.com>
2580
2581 * configure: Regenerate.
2582 * configure.ac: Check for strerror_r.
2583 * gdbsupport/common-utils.h (safe_strerror): Change return value
2584 to const char * and document that this function is now threadsafe.
2585 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2586 thread_local and call strerror_r, if available.
2587 * utils.c (perror_string): Update.
2588 (print_sys_errmsg): Update.
2589
a2726d4f
LM		 25902019-10-31 Luis Machado <luis.machado@linaro.org>
2591
2592 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2593 objfile_key.
2594 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2595 objfile to fetch per-bfd data.
2596 (arm_find_exidx_entry): Likewise.
2597
75cafaa6
CB		 25982019-10-31 Christian Biesinger <cbiesinger@google.com>
2599
2600 * gdbsupport/agent.c (debug_agent): Change type to bool.
2601 (use_agent): Likewise.
2602 (all_agent_symbols_look_up): Likewise.
2603 (agent_loaded_p): Change return value to bool.
2604 (agent_look_up_symbols): Update.
2605 (agent_capability_check): Change return value to bool.
2606 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2607 (debug_agent): Change type to bool.
2608 (use_agent): Likewise.
2609 (agent_capability_check): Change return value to bool.
2610
808590ec
CB		 26112019-10-30 Christian Biesinger <cbiesinger@google.com>
2612
2613 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2614 (build_minimal_symbol_hash_tables): Code to clear the table moved
2615 to clear_minimal_symbol_hash_tables.
2616 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2617 when needed.
2618
f18ad8a1
SM		 26192019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2620
2621 * infcmd.c: Remove includes.
2622 * infrun.c: Remove includes.
2623
de93309a
SM		 26242019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2625
2626 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2627 (grow_vect): Remove declaration.
2628 (ada_type_of_array): Remove declaration.
2629 (ada_update_initial_language): Remove declaration.
2630 (ada_fold_name): Remove declaration.
2631 (ada_fill_in_ada_prototype): Remove declaration.
2632 (user_select_syms): Remove declaration.
2633 (get_selections): Remove declaration.
2634 (ada_tag_type): Remove declaration.
2635 (ada_value_tag): Remove declaration.
2636 (ada_is_others_clause): Remove declaration.
2637 (ada_in_variant): Remove declaration.
2638 (ada_value_struct_elt): Remove declaration.
2639 (ada_attribute_name): Remove declaration.
2640 (ada_system_address_type): Remove declaration.
2641 * ada-lang.c (ada_watch_location_expression): Make static.
2642 (GROW_VECT): Move here from ada-lang.h.
2643 (grow_vect): Make static.
2644 (ada_update_initial_language): Make static.
2645 (ada_fold_name): Make static.
2646 (ada_type_of_array): Make static.
2647 (encoded_ordered_before): Move up.
2648 (sort_choices): Move up.
2649 (print_signatures): Move up.
2650 (ada_print_symbol_signature): Move up.
2651 (get_selections): Move up and make static.
2652 (user_select_syms): Move up and make static.
2653 (ada_value_struct_elt): Move up and make static.
2654 (ada_tag_type): Make static.
2655 (ada_value_tag): Make static.
2656 (ada_is_others_clause): Make static.
2657 (ada_in_variant): Make static.
2658 (ada_attribute_name): Make static.
2659
cdc46a9f
SM		 26602019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2661
2662 * ada-lang.c: Remove includes.
2663 * ada-typeprint.c: Remove includes.
2664 * ada-valprint.c: Remove includes.
2665
90421c56
SM		 26662019-10-29 Simon Marchi <simon.marchi@efficios.com>
2667
2668 * addrmap.c: Add static assertions of type size, moved from
2669 _initialize_addrmap.
2670 (_initialize_addrmap): Remove.
2671
31edb802
CB		 26722019-10-29 Christian Biesinger <cbiesinger@google.com>
2673
2674 * coffread.c (record_minimal_symbol): Update.
2675 (process_coff_symbol): Update.
2676 * dbxread.c (read_dbx_symtab): Update.
2677 * dwarf2read.c (add_partial_symbol): Update.
2678 (fixup_go_packaging): Update.
2679 (load_partial_dies): Update.
2680 (new_symbol): Update.
2681 * elfread.c (record_minimal_symbol): Change signature to use
2682 gdb::string_view instead of name+len.
2683 (elf_symtab_read): Update.
2684 (elf_rel_plt_read): Update.
2685 * mdebugread.c (parse_partial_symbols): Update.
2686 (handle_psymbol_enumerators): Update.
2687 (new_symbol): Update.
2688 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2689 to use gdb::string_view instead of name+len.
2690 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2691 * psympriv.h (add_psymbol_to_list): Likewise.
2692 * psymtab.c (add_psymbol_to_bcache): Likewise.
2693 (add_psymbol_to_list): Likewise.
2694 * stabsread.c (define_symbol): Update.
2695 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2696 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2697 (symbol_set_names): Likewise.
2698 * xcoffread.c (scan_xcoff_symtab): Update.
2699
0c921b21
CB		 27002019-10-29 Christian Biesinger <cbiesinger@google.com>
2701
2702 * symtab.h (symbol_set_names): Document that copy_name must be
2703 set to true for non-nullterminated strings.
2704 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2705 linkage_name if the entry was not found and we need to demangle.
2706
35e65c49
CB		 27072019-10-29 Christian Biesinger <cbiesinger@google.com>
2708
2709 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2710 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2711 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2712 * gdbsupport/gdb_binary_search.h: New file.
2713
ed2a2229
CB		 27142019-10-29 Christian Biesinger <cbiesinger@google.com>
2715
2716 * NEWS: Mention new --with-system-gdbinit-dir option.
2717 * config.in: Regenerate.
2718 * configure: Regenerate.
2719 * configure.ac: Add new option --with-system-gdbinit-dir.
2720 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2721 for a ".gdb" suffix.
2722 * main.c (get_init_files): Change system_gdbinit argument to
2723 a vector and return the files in SYSTEM_GDBINIT_DIR in
2724 addition to SYSTEM_GDBINIT.
2725 (captured_main_1): Update.
2726 (print_gdb_help): Update.
2727 * top.c (print_gdb_configuration): Also print the value of
2728 SYSTEM_GDBINIT_DIR.
2729
87f34879
CB		 27302019-10-28 Christian Biesinger <cbiesinger@google.com>
2731
2732 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2733 that takes gdb::string_view arguments.
2734
30baf67b
TV		 27352019-10-26 Tom de Vries <tdevries@suse.de>
2736
2737 * aarch64-linux-tdep.c: Fix typos in comments.
2738 * aarch64-tdep.c: Same.
2739 * ada-lang.c: Same.
2740 * amd64-nat.c: Same.
2741 * arc-tdep.c: Same.
2742 * arch/aarch64-insn.c: Same.
2743 * block.c: Same.
2744 * breakpoint.h: Same.
2745 * btrace.h: Same.
2746 * c-varobj.c: Same.
2747 * cli/cli-decode.c: Same.
2748 * cli/cli-script.c: Same.
2749 * cli/cli-utils.h: Same.
2750 * coff-pe-read.c: Same.
2751 * coffread.c: Same.
2752 * compile/compile-cplus-symbols.c: Same.
2753 * compile/compile-object-run.c: Same.
2754 * completer.c: Same.
2755 * corelow.c: Same.
2756 * cp-support.c: Same.
2757 * demangle.c: Same.
2758 * dwarf-index-write.c: Same.
2759 * dwarf2-frame.c: Same.
2760 * dwarf2-frame.h: Same.
2761 * eval.c: Same.
2762 * frame-base.h: Same.
2763 * frame.h: Same.
2764 * gdbcmd.h: Same.
2765 * gdbtypes.h: Same.
2766 * gnu-nat.c: Same.
2767 * guile/scm-objfile.c: Same.
2768 * i386-tdep.c: Same.
2769 * i386-tdep.h: Same.
2770 * infcall.c: Same.
2771 * infcall.h: Same.
2772 * linux-nat.c: Same.
2773 * m68k-tdep.c: Same.
2774 * macroexp.c: Same.
2775 * memattr.c: Same.
2776 * mi/mi-cmd-disas.c: Same.
2777 * mi/mi-getopt.h: Same.
2778 * mi/mi-main.c: Same.
2779 * minsyms.c: Same.
2780 * nat/aarch64-sve-linux-sigcontext.h: Same.
2781 * objfiles.h: Same.
2782 * ppc-linux-nat.c: Same.
2783 * ppc-linux-tdep.c: Same.
2784 * ppc-tdep.h: Same.
2785 * progspace.h: Same.
2786 * prologue-value.h: Same.
2787 * python/py-evtregistry.c: Same.
2788 * python/py-instruction.h: Same.
2789 * record-btrace.c: Same.
2790 * record-full.c: Same.
2791 * remote.c: Same.
2792 * rs6000-tdep.c: Same.
2793 * ser-tcp.c: Same.
2794 * sol-thread.c: Same.
2795 * sparc-sol2-tdep.c: Same.
2796 * sparc64-tdep.c: Same.
2797 * stabsread.c: Same.
2798 * symfile.c: Same.
2799 * symtab.h: Same.
2800 * target.c: Same.
2801 * tracepoint.c: Same.
2802 * tui/tui-data.h: Same.
2803 * tui/tui-io.c: Same.
2804 * tui/tui-win.c: Same.
2805 * tui/tui.c: Same.
2806 * unittests/rsp-low-selftests.c: Same.
2807 * user-regs.h: Same.
2808 * utils.c: Same.
2809 * utils.h: Same.
2810 * valarith.c: Same.
2811 * valops.c: Same.
2812 * valprint.c: Same.
2813 * valprint.h: Same.
2814 * value.c: Same.
2815 * value.h: Same.
2816 * varobj.c: Same.
2817 * x86-nat.h: Same.
2818 * xtensa-tdep.c: Same.
2819
1834d45f
AT		 28202019-10-25 Ali Tamur <tamur@google.com>
2821
2822 * charset.c (find_charset_names): Reflect API change.
2823
5396ae17
CB		 28242019-10-25 Christian Biesinger <cbiesinger@google.com>
2825
2826 * symtab.c (struct demangled_name_entry): Change demangled name
2827 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2828 part of the struct anymore.
2829 (symbol_set_names): No longer obstack allocate + copy the demangled
2830 name, just store the allocated name from bfd.
2831
93878f47
TT		 28322019-10-25 Tom Tromey <tromey@adacore.com>
2833
2834 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2835 (bsearch_cie_cmp, add_cie): Remove.
2836 (find_cie): Reimplement.
2837 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2838 (dwarf2_build_frame_info): Update.
2839
7b71fc97
L		 28402019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2841
2842 PR gdb/25126
2843 * symfile.c (reread_symbols): Call forget_cached_source_info to
2844 clear the stale source cache.
2845
cbb5a2ea
CB		 28462019-10-24 Christian Biesinger <cbiesinger@google.com>
2847
2848 * configure: Regenerate.
2849 * configure.ac: Remove code that sets python_has_threads.
2850
71737c43
CB		 28512019-10-24 Christian Biesinger <cbiesinger@google.com>
2852
2853 * config.in: Regenerate.
2854 * configure: Regenerate.
2855 * configure.ac: Remove the code that uses sed to get the python
2856 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2857
33d569b7
AB		 28582019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2859
2860 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2861 error paths.
2862
f16f7b7c
TT		 28632019-10-23 Tom Tromey <tom@tromey.com>
2864
2865 * arc-tdep.c: Remove ".." from include.
2866 * frv-tdep.c: Remove ".." from include.
2867 * lm32-tdep.c: Remove ".." from include.
2868 * microblaze-tdep.c: Remove ".." from include.
2869 * or1k-tdep.h: Remove ".." from include.
2870 * s12z-tdep.c: Remove ".." from include.
2871 * Makefile.in (OPCODES_CFLAGS): Add comment.
2872 (TOP_CFLAGS): New variable.
2873 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2874
6999161a
TT		 28752019-10-23 Tom Tromey <tom@tromey.com>
2876
2877 * Makefile.in (READLINE_DIR): Update.
2878
12e7c35e
TBA		 28792019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2880
2881 * infcall.c (call_function_by_hand_dummy): Fix the function
2882 comment. And extract out a code section into...
2883 (reserve_stack_space): ...this new function.
2884
37055cad
TBA		 28852019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2886
2887 * infcall.c (value_arg_coerce): Remove an unused parameter.
2888 (call_function_by_hand_dummy): Update the call to
2889 'value_arg_coerce'.
2890
39bcc47c
TBA		 28912019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2892
2893 * infcall.c (call_function_by_hand_dummy): Refactor.
2894
bd888c0f
TBA		 28952019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2896
2897 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2898
c12d372d
TT		 28992019-10-23 Tom Tromey <tom@tromey.com>
2900
2901 * configure: Rebuild.
2902 * configure.ac: Don't check for sigprocmask.
2903 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2904
4d0b984b
TT		 29052019-10-23 Tom Tromey <tom@tromey.com>
2906
2907 * configure: Rebuild.
2908 * acinclude.m4: Use m4_include, not sinclude.
2909
7e785608
TV		 29102019-10-23 Tom de Vries <tdevries@suse.de>
2911
2912 PR breakpoints/24687
2913 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2914
403772ef
CB		 29152019-10-22 Christian Biesinger <cbiesinger@google.com>
2916
2917 * symtab.c (struct demangled_name_entry) <language>: Change from
2918 bitfield to regular variable.
2919
3a494279
CB		 29202019-10-22 Christian Biesinger <cbiesinger@google.com>
2921
2922 * symtab.c (struct demangled_name_entry): Add a constructor.
2923 (free_demangled_name_entry): New function to call the destructor
2924 for demangled_name_entry.
2925 (create_demangled_names_hash): Pass free_demangled_name_entry to
2926 htab_create_alloc.
2927 (symbol_set_names): Call placement new for demangled_name_entry.
2928 * utils.c: No longer include xxhash.h here, now that fast_hash
2929 is inlined in the header.
2930 * utils.h: Instead, include it here.
2931
ccb1ba62
CB		 29322019-10-22 Christian Biesinger <cbiesinger@google.com>
2933
2934 * Makefile.in: Link with libxxhash.
2935 * config.in: Regenerate.
2936 * configure: Regenerate.
2937 * configure.ac: Search for libxxhash.
2938 * utils.c (fast_hash): Use xxhash if present.
2939
1a6ff1a9
CB		 29402019-10-22 Christian Biesinger <cbiesinger@google.com>
2941
2942 * utils.h (fast_hash): New function.
2943 * symtab.c (hash_demangled_name_entry): Call new function
2944 fast_hash.
2945
7bb43059
CB		 29462019-10-22 Christian Biesinger <cbiesinger@google.com>
2947
2948 * symtab.c (struct demangled_name_entry): Change type of mangled
2949 to gdb::string_view. Also adds a constructor that takes the
2950 mangled name.
2951 (hash_demangled_name_entry): Update.
2952 (eq_demangled_name_entry): Update.
2953 (free_demangled_name_entry): New function to call the destructor
2954 now that this is not a POD anymore.
2955 (create_demangled_names_hash): Pass free_demangled_name_entry to
2956 htab_create_alloc.
2957 (symbol_set_names): Update.
2958
7ba99d21
AT		 29592019-10-21 Ali Tamur <tamu@google.com>
2960
2961 * dwarf2read.c (dir_index): Change type.
2962 (file_name_index): Likewise.
2963 (line_header::include_dir_at): Change comment and implementation on
2964 whether it is DWARF 5.
2965 (line_header::is_valid_file_index): New function.
2966 (line_header::file_name_at): Change comment and implementation on
2967 whether it is DWARF 5.
2968 (line_header::file_names): Change to private field renamed as
2969 m_file_names and introduce a new accessor method.
2970 (line_header::file_names_size): New method.
2971 (line_header::include_dirs): Change to private field and rename as
2972 m_include_dirs.
2973 (dw2_get_file_names_reader): Define local var at a smaller scope and
2974 reflect API change.
2975 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2976 (process_structure_scope): Likewise.
2977 (line_header::add_include_dir): Change message and reflect renaming.
2978 (line_header::add_file_name): Likewise.
2979 (read_formatted_entries): Handle DW_FORM_data16.
2980 (dwarf_decode_line_header): Fix line header length calculation.
2981 (psymtab_include_file_name): Change comment and API.
2982 (lnp_state_machine::m_file): Update comment and reflect type change.
2983 (lnp_state_machine::record_line): Reflect type change.
2984 (dwarf_decode_lines): Reflect API change.
2985 (file_file_name): Likewise.
2986 (file_full_name): Likewise.
2987
45f47c3a
AB		 29882019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2989
2990 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2991
e5f3c0e3
TT		 29922019-10-21 Tom Tromey <tom@tromey.com>
2993
2994 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2995
a0a461e5
TT		 29962019-10-21 Tom Tromey <tom@tromey.com>
2997
2998 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2999 NM_H. Use AC_CONFIG_LINKS.
3000 * configure: Rebuild.
3001 * Makefile.in (NM_H): New variable.
3002 (generated_files): Add NM_H. Remove gcore.
3003 (nm.h, stamp-nmh): New targets.
3004
54d83b8d
TT		 30052019-10-20 Tom Tromey <tom@tromey.com>
3006
3007 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3008 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3009 obsolete comment.
3010 (put_objfile_before): Now static.
3011
23771117
SM		 30122019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3013
3014 * gdbsupport/common-utils.h (startswith): Change return type to
3015 bool.
3016
39ef2f62
CB		 30172019-10-19 Christian Biesinger <cbiesinger@google.com>
3018
3019 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3020 * breakpoint.c (bp_locations_compare): Rename to...
3021 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3022 (update_global_location_list): Use std::sort instead of qsort.
3023 * buildsym.c (compare_line_numbers): Rename to...
3024 (lte_is_less_than): ...this, and change to std::sort semantics.
3025 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3026 instead of qsort.
3027 * disasm.c (compare_lines): Rename to...
3028 (line_is_less_than): ...this, and change to std::sort semantics.
3029 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3030 of qsort.
3031 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3032 (fde_is_less_than): ...this, and change to std::sort semantics.
3033 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3034 * mdebugread.c (compare_blocks):
3035 (block_is_less_than): ...this, and change to std::sort semantics.
3036 (sort_blocks): Call std::sort instead of qsort.
3037 * objfiles.c (qsort_cmp): Rename to...
3038 (sort_cmp): ...this, and change to std::sort semantics.
3039 (update_section_map): Call std::sort instead of qsort.
3040 * remote.c (compare_pnums): Remove.
3041 (map_regcache_remote_table): Call std::sort instead of qsort.
3042 * utils.c (compare_positive_ints): Remove.
3043 * utils.h (compare_positive_ints): Remove.
3044 * xcoffread.c (compare_lte): Remove.
3045 (arrange_linetable): Call std::sort instead of qsort.
3046
f71433ee
SDJ		 30472019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3048
3049 * symfile.c (init_entry_point_info): Fix typo.
3050 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3051
85102364
TV		 30522019-10-18 Tom de Vries <tdevries@suse.de>
3053
3054 * aarch64-tdep.c: Fix typos in comments.
3055 * ada-lang.c: Same.
3056 * ada-tasks.c: Same.
3057 * alpha-tdep.c: Same.
3058 * alpha-tdep.h: Same.
3059 * amd64-nat.c: Same.
3060 * amd64-windows-tdep.c: Same.
3061 * arc-tdep.c: Same.
3062 * arc-tdep.h: Same.
3063 * arch-utils.c: Same.
3064 * arm-nbsd-tdep.c: Same.
3065 * arm-tdep.c: Same.
3066 * ax-gdb.c: Same.
3067 * blockframe.c: Same.
3068 * btrace.c: Same.
3069 * c-varobj.c: Same.
3070 * coff-pe-read.c: Same.
3071 * coffread.c: Same.
3072 * cris-tdep.c: Same.
3073 * darwin-nat.c: Same.
3074 * dbxread.c: Same.
3075 * dcache.c: Same.
3076 * disasm.c: Same.
3077 * dtrace-probe.c: Same.
3078 * dwarf-index-write.c: Same.
3079 * dwarf2-frame-tailcall.c: Same.
3080 * dwarf2-frame.c: Same.
3081 * dwarf2read.c: Same.
3082 * eval.c: Same.
3083 * exceptions.c: Same.
3084 * fbsd-tdep.c: Same.
3085 * findvar.c: Same.
3086 * frame.c: Same.
3087 * frv-tdep.c: Same.
3088 * gnu-v3-abi.c: Same.
3089 * go32-nat.c: Same.
3090 * h8300-tdep.c: Same.
3091 * hppa-tdep.c: Same.
3092 * i386-linux-tdep.c: Same.
3093 * i386-tdep.c: Same.
3094 * ia64-libunwind-tdep.c: Same.
3095 * ia64-tdep.c: Same.
3096 * infcmd.c: Same.
3097 * infrun.c: Same.
3098 * linespec.c: Same.
3099 * linux-nat.c: Same.
3100 * linux-thread-db.c: Same.
3101 * machoread.c: Same.
3102 * mdebugread.c: Same.
3103 * mep-tdep.c: Same.
3104 * mn10300-tdep.c: Same.
3105 * namespace.c: Same.
3106 * objfiles.c: Same.
3107 * opencl-lang.c: Same.
3108 * or1k-tdep.c: Same.
3109 * osabi.c: Same.
3110 * ppc-linux-nat.c: Same.
3111 * ppc-linux-tdep.c: Same.
3112 * ppc-sysv-tdep.c: Same.
3113 * printcmd.c: Same.
3114 * procfs.c: Same.
3115 * record-btrace.c: Same.
3116 * record-full.c: Same.
3117 * remote-fileio.c: Same.
3118 * remote.c: Same.
3119 * rs6000-tdep.c: Same.
3120 * s12z-tdep.c: Same.
3121 * score-tdep.c: Same.
3122 * ser-base.c: Same.
3123 * ser-go32.c: Same.
3124 * skip.c: Same.
3125 * sol-thread.c: Same.
3126 * solib-svr4.c: Same.
3127 * solib.c: Same.
3128 * source.c: Same.
3129 * sparc-nat.c: Same.
3130 * sparc-sol2-tdep.c: Same.
3131 * sparc-tdep.c: Same.
3132 * sparc64-tdep.c: Same.
3133 * stabsread.c: Same.
3134 * stack.c: Same.
3135 * symfile.c: Same.
3136 * symtab.c: Same.
3137 * target-descriptions.c: Same.
3138 * target-float.c: Same.
3139 * thread.c: Same.
3140 * utils.c: Same.
3141 * valops.c: Same.
3142 * valprint.c: Same.
3143 * value.c: Same.
3144 * varobj.c: Same.
3145 * windows-nat.c: Same.
3146 * xcoffread.c: Same.
3147 * xstormy16-tdep.c: Same.
3148 * xtensa-tdep.c: Same.
3149
c5adaa19
TT		 31502019-10-17 Tom Tromey <tromey@adacore.com>
3151
3152 * configure: Rebuild.
3153 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3154 in AC_CONFIG_FILES invocation.
3155 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3156 new-style config.status invocation.
3157
405feb71
TV		 31582019-10-17 Tom de Vries <tdevries@suse.de>
3159
3160 * arm-nbsd-nat.c: Fix typos in comments.
3161 * arm-tdep.c: Same.
3162 * darwin-nat-info.c: Same.
3163 * dwarf2read.c: Same.
3164 * elfread.c: Same.
3165 * event-top.c: Same.
3166 * findvar.c: Same.
3167 * gdbtypes.c: Same.
3168 * hppa-tdep.c: Same.
3169 * i386-tdep.c: Same.
3170 * jit.c: Same.
3171 * main.c: Same.
3172 * mdebugread.c: Same.
3173 * moxie-tdep.c: Same.
3174 * nto-procfs.c: Same.
3175 * osabi.c: Same.
3176 * ppc-linux-tdep.c: Same.
3177 * remote.c: Same.
3178 * riscv-tdep.c: Same.
3179 * s390-tdep.c: Same.
3180 * sh-tdep.c: Same.
3181 * sparc-linux-tdep.c: Same.
3182 * sparc-nat.c: Same.
3183 * stack.c: Same.
3184 * target-descriptions.c: Same.
3185 * top.c: Same.
3186 * varobj.c: Same.
3187
befcd486
TT		 31882019-10-16 Tom Tromey <tom@tromey.com>
3189
3190 * objfiles.h (struct objfile) <original_name>: Now const.
3191
17bfe554
CB		 31922019-10-16 Christian Biesinger <cbiesinger@google.com>
3193
3194 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3195 pass on to sigsetjmp's second argument.
3196 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3197
950b7495
KS		 31982019-10-16 Keith Seitz <keiths@redhat.com>
3199
3200 PR gdb/23567
3201 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3202 sections whose size is greater than the file size.
3203
ff371ec9
JW		 32042019-10-16 Jim Wilson <jimw@sifive.com>
3205
3206 * riscv-tdep.c (riscv_gcc_target_options): New.
3207 (riscv_gnu_triplet_regexp): New.
3208 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3209 set_gdbarch_gnu_triplet_regexp.
3210
fec4e896
CB		 32112019-10-16 Christian Biesinger <cbiesinger@google.com>
3212
3213 * Makefile.in: Add xml-builtin.h.
3214 * features/feature_to_c.sh: Add an include for xml-builtin.h
3215 to ensure that the compiler checks that the types match.
3216 * xml-builtin.h: New file.
3217 * xml-support.c (fetch_xml_builtin): Add missing const.
3218 * xml-support.h: Remove declaration of xml_builtins.
3219
d10eccaa
TV		 32202019-10-16 Tom de Vries <tdevries@suse.de>
3221
3222 PR tdep/25096
3223 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3224 (amd64_classify_aggregate): ... here.
3225 (amd64_classify_aggregate_field): Handled fiels of nested structs
3226 recursively.
3227
745ff14e
TV		 32282019-10-16 Tom de Vries <tdevries@suse.de>
3229
3230 PR tdep/24104
3231 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3232 that handles 'theclass'.
3233
791b7405
AB		 32342019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3235
3236 * linespec.c (decode_digits_ordinary): Update comment.
3237 * make-target-delegates: No longer need to handle VEC case.
3238 * memrange.c (normalize_mem_ranges): Update comment.
3239 * namespace.c (add_using_directive): Update comment.
3240 * objc-lang.c (uniquify_strings): Update comment.
3241 * ppc-linux-nat.c (struct thread_points): Update comment.
3242 * probe.h (find_probes_in_objfile): Update comment.
3243 * target.h (enum flash_preserve_mode): Update comment.
3244 * varobj.c (varobj_restrict_range): Update comment.
3245 * varobj.h (varobj_list_children): Update comment.
3246
0dc32745
AB		 32472019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3248
3249 * Makefile.in: Remove references to vec.h and vec.c.
3250 * aarch64-tdep.c: No longer include vec.h.
3251 * ada-lang.c: Likewise.
3252 * ada-lang.h: Likewise.
3253 * arm-tdep.c: Likewise.
3254 * ax.h: Likewise.
3255 * breakpoint.h: Likewise.
3256 * charset.c: Likewise.
3257 * cp-support.h: Likewise.
3258 * dtrace-probe.c: Likewise.
3259 * dwarf2read.c: Likewise.
3260 * extension.h: Likewise.
3261 * gdb_bfd.c: Likewise.
3262 * gdbsupport/gdb_vecs.h: Likewise.
3263 * gdbsupport/vec.c: Remove.
3264 * gdbsupport/vec.h: Remove.
3265 * gdbthread.h: Likewise.
3266 * guile/scm-type.c: Likewise.
3267 * inline-frame.c: Likewise.
3268 * machoread.c: Likewise.
3269 * memattr.c: Likewise.
3270 * memrange.h: Likewise.
3271 * namespace.h: Likewise.
3272 * nat/linux-btrace.h: Likewise.
3273 * osdata.c: Likewise.
3274 * parser-defs.h: Likewise.
3275 * progspace.h: Likewise.
3276 * python/py-type.c: Likewise.
3277 * record-btrace.c: Likewise.
3278 * rust-exp.y: Likewise.
3279 * solib-target.c: Likewise.
3280 * stap-probe.c: Likewise.
3281 * target-descriptions.c: Likewise.
3282 * target-memory.c: Likewise.
3283 * target.h: Likewise.
3284 * varobj.c: Likewise.
3285 * varobj.h: Likewise.
3286 * xml-support.h: Likewise.
3287
ae640021
AB		 32882019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3289
3290 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3291 Update for new std::vector based implementation.
3292 (process_psymtab_comp_unit_reader): Likewise.
3293 (scan_partial_symbols): Likewise.
3294 (recursively_compute_inclusions): Likewise.
3295 (compute_compunit_symtab_includes): Likewise.
3296 (process_imported_unit_die): Likewise.
3297 (queue_and_load_dwo_tu): Likewise.
3298 (follow_die_sig_1): Likewise.
3299 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3300 (typedef dwarf2_per_cu_ptr): Remove.
3301 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3302 function.
3303 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3304 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3305 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3306 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3307 std::vector.
3308
55dfc88f
TT		 33092019-10-15 Tom Tromey <tromey@adacore.com>
3310
3311 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3312 TID.
3313
96b49c5e
TT		 33142019-10-15 Tom Tromey <tromey@adacore.com>
3315
3316 * windows-nat.c (windows_nat_target::fetch_registers)
3317 (windows_nat_target::store_registers): Rename "pid" to "tid".
3318
953cff56
TT		 33192019-10-15 Tom Tromey <tromey@adacore.com>
3320
3321 * gdbarch.h, gdbarch.c: Rebuild.
3322 * gdbarch.sh (gcc_target_options): Change return type to
3323 std::string.
3324 * compile/compile.c (get_args): Update.
3325 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3326 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3327 std::string.
3328 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3329 std::string.
3330 * arch-utils.c (default_gcc_target_options): Return std::string.
3331 * arch-utils.h (default_gcc_target_options): Return std::string.
3332 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3333
81e6b8eb
CB		 33342019-10-15 Christian Biesinger <cbiesinger@google.com>
3335
3336 * breakpoint.c (breakpoint_chain): Make static.
3337 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3338 of accessing breakpoint_chain.
3339
95da600f
CB		 33402019-10-15 Christian Biesinger <cbiesinger@google.com>
3341
3342 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3343 to a gdb::function_view and return value to bool.
3344 * breakpoint.h (iterate_over_breakpoints): Likewise.
3345 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3346 (pop_dummy_frame): Update.
3347 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3348 (gdbscm_breakpoints): Update.
3349 * python/py-breakpoint.c (build_bp_list): Update.
3350 (gdbpy_breakpoints): Update.
3351 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3352 Update.
3353 (bpfinishpy_handle_stop): Update.
3354 (bpfinishpy_handle_exit): Update.
3355 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3356 (svr4_update_solib_event_breakpoints): Update.
3357
ba18312d
AA		 33582019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3359
3360 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3361 when unwrapping single-field structs.
3362
6acc1a0b
SM		 33632019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3364
3365 * dwarf2read.c: Remove includes.
3366
284782de
SM		 33672019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3368
3369 * ui-out.c (ui_out::call_do_message): Silence
3370 -Wformat-nonliteral warning.
3371
073bbbb0
SM		 33722019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3373
3374 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3375 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3376 include: readline/tilde.h.
3377
7b9a15e1
CB		 33782019-10-12 Christian Biesinger <cbiesinger@google.com>
3379
3380 * remote.c (remote_target::get_trace_status): Remove declaration of
3381 trace_regblock_size.
3382
cc8dee1f
CB		 33832019-10-12 Christian Biesinger <cbiesinger@google.com>
3384
3385 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3386 (show_user): Remove declaration of cmdlist.
3387 * cli/cli-cmds.h (max_user_call_depth): Declare.
3388 * cli/cli-script.c (execute_user_command): Remove declaration
3389 of max_user_call_depth.
3390
a83d4ef6
JW		 33912019-10-11 Jim Wilson <jimw@sifive.com>
3392
5f93c5a6
JW		 3393 * gdbsupport/print-utils.h (pulongest): Fix comment.
3394 (plongest): Likewise.
3395 (phex): Add missing comment, mention leading zeros.
3396 (phex_nz): Add mention of no leading zeros to comment.
3397
a83d4ef6
JW		 3398 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3399 plongest instead of unsigned long long cast.
3400
26344e0c
CB		 34012019-10-10 Christian Biesinger <cbiesinger@google.com>
3402
3403 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3404 for external_editor_command and gdbtk_test.
3405
c2c440a9
CB		 34062019-10-10 Christian Biesinger <cbiesinger@google.com>
3407
3408 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3409 * varobj.c (varobjdebug): Move comment to...
3410 * varobj.h (varobjdebug): ...here, and declare.
3411
a31bff9d
TT		 34122019-10-09 Tom Tromey <tom@tromey.com>
3413
3414 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3415 erase_data_content.
3416
7523da63
TT		 34172019-10-09 Tom Tromey <tom@tromey.com>
3418
3419 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3420 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3421 * tui/tui-command.c (tui_cmd_window::resize)
3422 (tui_refresh_cmd_win): Update.
3423 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3424 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3425 * tui/tui-data.c (~tui_gen_win_info): Remove.
3426 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3427 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3428 (tui_redisplay_readline, tui_mld_flush)
3429 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3430 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3431 (tui_data_window::erase_data_content)
3432 (tui_data_item_window::rerender)
3433 (tui_data_item_window::refresh_window): Update.
3434 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3435 (box_win, tui_gen_win_info::make_window)
3436 (tui_gen_win_info::make_visible): Update.
3437 (tui_delete_win): Remove.
3438 * tui/tui-winsource.c
3439 (tui_source_window_base::do_erase_source_content): Update.
3440 (tui_show_source_line, tui_source_window_base::update_tab_width)
3441 (tui_source_window_base::update_exec_info): Update.
3442 * tui/tui-data.h (struct curses_deleter): New.
3443 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3444 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3445
a7798e7f
TT		 34462019-10-09 Tom Tromey <tom@tromey.com>
3447
3448 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3449
5c45899e
TT		 34502019-10-09 Tom Tromey <tom@tromey.com>
3451
3452 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3453 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3454
6d7fd9aa
TT		 34552019-10-09 Tom Tromey <tom@tromey.com>
3456
3457 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3458 window height directly.
3459 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3460 declare.
3461 * tui/tui-layout.c (tui_default_win_height): Remove.
3462 (tui_default_win_viewport_height): Remove.
3463
d2dd1084
TT		 34642019-10-09 Tom Tromey <tom@tromey.com>
3465
3466 * tui/tui.h: Remove comments.
3467
cff32449
TV		 34682019-10-09 Tom de Vries <tdevries@suse.de>
3469
3470 * python/lib/gdb/printer/bound_registers.py: Use
3471 '^builtin_type_bound128' as regexp argument for
3472 add_builtin_pretty_printer.
3473
6a25e8a2
CB		 34742019-10-09 Christian Biesinger <cbiesinger@google.com>
3475
3476 * guile/guile.c (guile_extension_script_ops): Remove forward
3477 declaration and mark as static.
3478 (guile_script_ops): Likewise.
3479 (extension_language_guile): Move further down in the file so
3480 it can reference the definitions for guile_{extension_,}script_ops.
3481
6d9d6da4
AA		 34822019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3483
3484 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3485 except SORTL, DFLTCC, and KDSA.
3486
3abea05d
TT		 34872019-10-08 Tom Tromey <tromey@adacore.com>
3488
3489 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3490 (struct safe_symbol_file_add_args): Remove.
3491
dde996e2
TT		 34922019-10-08 Tom Tromey <tromey@adacore.com>
3493
3494 * windows-nat.c: Don't include buildsym-legacy.h.
3495
cd6fdaa1
TT		 34962019-10-08 Tom Tromey <tromey@adacore.com>
3497
3498 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3499
79bb1944
CB		 35002019-10-08 Christian Biesinger <cbiesinger@google.com>
3501
3502 * gdbtypes.c (overload_debug): Move comment to header.
3503 * gdbtypes.h (overload_debug): Declare.
3504 * valops.c: Remove declaration of overload_debug, instead
3505 include gdbtypes.h.
3506
34916edc
CB		 35072019-10-08 Christian Biesinger <cbiesinger@google.com>
3508
3509 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3510 through _().
3511 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3512 move comment...
3513 * language.h (lang_frame_mismatch_warn): ... here. Also add
3514 declaration.
3515 * top.c (lang_frame_mismatch_warn): Remove declaration.
3516 (check_frame_language_change): Pass lang_frame_mismatch_warn
3517 through _().
3518
bad5c026
CB		 35192019-10-07 Christian Biesinger <cbiesinger@google.com>
3520
3521 * c-lang.h (vtbl_ptr_name): Declare.
3522 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3523 it from the header.
3524 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3525
51f1fdc3
CB		 35262019-10-07 Christian Biesinger <cbiesinger@google.com>
3527
3528 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3529 gdb_static_assert.
3530
30d1f018
WP		 35312019-10-07 Weimin Pan <weimin.pan@oracle.com>
3532
606813d5
WP		 3533 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3534 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3535 * ctfread.c: New file.
3536 * ctfread.h: New file.
3537 * elfread.c: Include ctfread.h.
3538 (struct elfinfo text_p): New member ctfsect.
3539 (elf_locate_sections): Mark CTF section.
3540 (elf_symfile_read): Call elfctf_build_psymtabs.
3541 * Makefile.in (LIBCTF): Add.
3542 (CLIBS): Use it.
3543 (CDEPS): Likewise.
3544 (DIST): Add ctfread.c.
606813d5
WP		 3545
35462019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3547
3548 * ctfread.c (struct nextfield): Renamed to ...
3549 (struct ctf_nextfield): ... this.
3550 (struct field_info): Renamed to ...
3551 (strut ctf_field_info): ... this.
3552 (attach_fields_to_type): Update for renamed structures.
3553 (ctf_add_member_cb): Likewise.
3554 (ctf_add_enum_member_cb): Likewise.
3555 (process_struct_members): Likewise.
3556 (process_enum_type): Likewise.
30d1f018 3557
518fe38c
WP		 35582019-10-07 Weimin Pan <weimin.pan@oracle.com>
3559
3560 * tracectf.h: Rename, was ctf.h.
3561 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3562 * tracefile.c: Likewise.
3563 * tracepoint.c: Remove unused include ctf.h.
3564 * mi/mi-main.c: Likewise.
3565 * Makefile.in Replace ctf.c with tracectf.c.
3566
225f296a
JB		 35672019-10-06 Joel Brobecker <brobecker@adacore.com>
3568
3569 * version.in: Change version number to "9.0.50.DATE-git".
3570
77c2dba3
TT		 35712019-10-03 Tom Tromey <tom@tromey.com>
3572
3573 PR rust/24976:
3574 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3575
179aed7f
AB		 35762019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3577
3578 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3579 cp_search_name_hash.
3580 * NEWS: Add entry about nested function support.
3581
0a4b0913
AB		 35822019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3583 Andrew Burgess <andrew.burgess@embecosm.com>
3584
3585 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3586 for nested static variables when searchin VAR_DOMAIN.
3587 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3588 global scope, update comment.
3589 (add_partial_subprogram): Call add_partial_subprogram recursively
3590 for nested subroutines when processinng Fortran.
3591 (load_partial_dies): Process the child entities of a subprogram
3592 when processing Fortran.
3593 (partial_die_parent_scope): Handle building scope
3594 for Fortran nested functions.
3595 (process_die): Record that nested functions have a scope.
3596 (new_symbol): Always record Fortran subprograms on the global
3597 symbol list.
3598 (determine_prefix): How to build the prefix for Fortran
3599 subprograms.
3600
d8c06f22
AB		 36012019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3602
3603 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3604 have just sent the thread a SIGSTOP and are waiting for it to
3605 arrive.
3606
a8b3b8e9
AB		 36072019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3608
3609 * btrace.c (btrace_add_pc): Remove whitespace before the template
3610 parameter in 'std::vector <...>'.
3611 (parse_xml_btrace_block): Likewise.
3612 (btrace_maint_decode_pt): Likewise.
3613 (btrace_maint_update_packets): Likewise.
3614 (btrace_maint_print_packets): Likewise.
3615 * btrace.h (struct btrace_maint_info): Likewise.
3616 * dwarf2read.c (struct type_unit_group): Likewise.
3617 (build_type_psymtabs_reader): Likewise.
3618 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3619 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3620 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3621
4d825eab
TV		 36222019-10-03 Tom de Vries <tdevries@suse.de>
3623
3624 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3625 the first line of the help text for set/show style metadata.
3626
80fd2826
TT		 36272019-10-02 Tom Tromey <tromey@adacore.com>
3628
3629 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3630 * gdbsupport/common-inferior.c: New file.
3631 * infcmd.c (startup_with_shell): Don't define.
3632 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3633 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3634 * inferior.h (startup_with_shell): Don't declare.
3635
70054538
CB		 36362019-10-02 Christian Biesinger <cbiesinger@google.com>
3637
3638 * gdbsupport/gdb_assert.h: Include errors.h.
3639 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3640
37f6a7f4
TT		 36412019-10-02 Tom Tromey <tromey@adacore.com>
3642
3643 * NEWS: Add $_ada_exception entry.
3644 * ada-lang.c (struct ada_catchpoint): Add constructor.
3645 <m_kind>: New member.
3646 (allocate_location_exception, re_set_exception): Remove
3647 "ex" parameter.
3648 (should_stop_exception): Compute $_ada_exception.
3649 (check_status_exception, print_it_exception)
3650 (print_one_exception, print_mention_exception): Remove
3651 "ex" parameter.
3652 (allocate_location_catch_exception, re_set_catch_exception)
3653 (check_status_exception, print_it_catch_exception)
3654 (print_one_catch_exception, print_mention_catch_exception)
3655 (print_recreate_catch_exception)
3656 (allocate_location_catch_exception_unhandled)
3657 (re_set_catch_exception_unhandled)
3658 (check_status_exception, print_it_catch_exception_unhandled)
3659 (print_one_catch_exception_unhandled)
3660 (print_mention_catch_exception_unhandled)
3661 (print_recreate_catch_exception_unhandled)
3662 (allocate_location_catch_assert, re_set_catch_assert)
3663 (check_status_assert, print_it_catch_assert)
3664 (print_one_catch_assert, print_mention_catch_assert)
3665 (print_recreate_catch_assert)
3666 (allocate_location_catch_handlers, re_set_catch_handlers)
3667 (check_status_handlers, print_it_catch_handlers)
3668 (print_one_catch_handlers, print_mention_catch_handlers)
3669 (print_recreate_catch_handlers): Remove.
3670 (create_ada_exception_catchpoint): Update.
3671 (initialize_ada_catchpoint_ops): Update.
3672
fccf9de1
TT		 36732019-10-02 Tom Tromey <tromey@adacore.com>
3674
3675 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3676 (create_excep_cond_exprs): Simplify exception string computation.
3677 (ada_exception_catchpoint_cond_string): Likewise.
3678
4b610737
TT		 36792019-10-02 Tom Tromey <tromey@adacore.com>
3680
3681 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3682 * ada-lang.c (lesseq_defined_than): Handle
3683 LOC_STATIC.
3684 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3685 parameter.
3686 (dwarf2_has_info): Likewise.
3687 (new_symbol): Set maybe_copied on symbol when
3688 appropriate.
3689 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3690 parameter.
3691 <can_copy>: New member.
3692 * elfread.c (record_minimal_symbol): Set maybe_copied
3693 on symbol when appropriate.
3694 (elf_symfile_read): Update call to dwarf2_has_info.
3695 * minsyms.c (lookup_minimal_symbol_linkage): New
3696 function.
3697 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3698 * symtab.c (get_symbol_address, get_msymbol_address):
3699 New functions.
3700 * symtab.h (get_symbol_address, get_msymbol_address):
3701 Declare.
3702 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3703 maybe_copied.
3704 (struct symbol, struct minimal_symbol) <maybe_copied>:
3705 New member.
3706
1dd58850
TT		 37072019-10-02 Tom Tromey <tromey@adacore.com>
3708
3709 * source.c (struct current_source_location): New.
3710 (current_source_key): New global.
3711 (current_source_symtab, current_source_line)
3712 (current_source_pspace): Remove.
3713 (get_source_location): New function.
3714 (get_current_source_symtab_and_line)
3715 (set_default_source_symtab_and_line)
3716 (set_current_source_symtab_and_line)
3717 (clear_current_source_symtab_and_line, select_source_symtab)
3718 (info_source_command, print_source_lines_base)
3719 (info_line_command, search_command_helper, _initialize_source):
3720 Update.
3721
5c281dbb
TT		 37222019-10-02 Tom Tromey <tromey@adacore.com>
3723
3724 * source.c (select_source_symtab): Don't call
3725 decode_line_with_current_source.
3726
d3d32391
AB		 37272019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3728
3729 * symtab.c (lookup_global_symbol): Search global block.
3730
38583298
TT		 37312019-10-02 Tom Tromey <tromey@adacore.com>
3732
3733 * coffread.c (process_coff_symbol): Update.
3734 * dwarf2read.c (var_decode_location, new_symbol): Update.
3735 * mdebugread.c (parse_symbol): Update.
3736 * objfiles.c (relocate_one_symbol): Update.
3737 * stabsread.c (define_symbol, fix_common_block)
3738 (scan_file_globals): Update.
3739 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3740 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3741 * xcoffread.c (process_xcoff_symbol): Update.
3742
9344c18f
AA		 37432019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3744
3745 * MAINTAINERS: Update my email address.
3746
df07e2c7
AB		 37472019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3748
3749 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3750 std::vector.
3751 (build_type_psymtabs_reader): Update for std::vector.
3752 (build_type_psymtab_dependencies): Likewise.
3753 * dwarf2read.h: Remove use of DEF_VEC_P.
3754 (typedef sig_type_ptr): Delete.
3755
554ac434
AB		 37562019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3757
3758 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3759 to std::vector.
3760 (btrace_maint_decode_pt): Likewise, and move allocation of the
3761 vector outside of the loop.
3762 (btrace_maint_update_packets): Update to handle change from VEC to
3763 std::vector.
3764 (btrace_maint_print_packets): Likewise.
3765 (maint_info_btrace_cmd): Likewise.
3766 * btrace.h: Remove use of DEF_VEC_O.
3767 (typedef btrace_pt_packet_s): Delete.
3768 (struct btrace_maint_info) <packets>: Change fromm VEC to
3769 std::vector.
3770 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3771
46f29a9a
AB		 37722019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3773
3774 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3775 make accesses into the vector constant references.
3776 (btrace_add_pc): Update for std::vector.
3777 (btrace_stitch_bts): Likewise.
3778 (parse_xml_btrace_block): Likewise.
3779 (btrace_maint_update_packets): Likewise.
3780 (btrace_maint_print_packets): Likewise.
3781 (maint_info_btrace_cmd): Likewise.
3782 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3783 std::vector.
3784 (btrace_data::empty): Likewise.
3785 (btrace_data_append): Likewise.
3786 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3787 (typedef btrace_block_s): Delete.
3788 (struct btrace_block): Add constructor.
3789 (struct btrace_data_bts) <blocks>: Change to std::vector.
3790 * nat/linux-btrace.c (perf_event_read_bts): Update for
3791 std::vector.
3792 (linux_read_bts): Likewise.
3793
d770d56f
TT		 37942019-10-01 Tom Tromey <tom@tromey.com>
3795
3796 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3797
9d636d67
TT		 37982019-10-01 Tom Tromey <tom@tromey.com>
3799
3800 * stack.c (print_frame, info_frame_command_core): Use
3801 styled_string.
3802 * linux-thread-db.c (try_thread_db_load_1)
3803 (try_thread_db_load_from_pdir_1): Use styled_string.
3804 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3805 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3806 (maybe_print_unsupported_script_warning)
3807 (maybe_print_script_not_found_warning): Use styled_string.
3808 * ada-lang.c (user_select_syms): Use styled_string.
3809
7f6aba03
TT		 38102019-10-01 Tom Tromey <tom@tromey.com>
3811
3812 * p-lang.c (pascal_printstr): Use metadata style.
3813 * value.c (show_convenience): Use metadata style.
3814 * valprint.c (valprint_check_validity, val_print_optimized_out)
3815 (val_print_not_saved, val_print_unavailable)
3816 (val_print_invalid_address, generic_val_print, val_print)
3817 (value_check_printable, val_print_array_elements): Use metadata
3818 style.
3819 * ui-out.h (class ui_out) <field_fmt>: New overload.
3820 <do_field_fmt>: Add style parameter.
3821 * ui-out.c (ui_out::field_fmt): New overload.
3822 * typeprint.c (type_print_unknown_return_type)
3823 (val_print_not_allocated, val_print_not_associated): Use metadata
3824 style.
3825 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3826 parameter.
3827 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3828 * tracepoint.c (tvariables_info_1): Use metadata style.
3829 * stack.c (print_frame_arg, print_frame_info, print_frame)
3830 (info_frame_command_core): Use metadata style.
3831 * skip.c (info_skip_command): Use metadata style.
3832 * rust-lang.c (rust_print_enum): Use metadata style.
3833 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3834 metadata style.
3835 * python/py-framefilter.c (py_print_single_arg): Use metadata
3836 style.
3837 * printcmd.c (do_one_display, print_variable_and_value): Use
3838 metadata style.
3839 * p-valprint.c (pascal_val_print)
3840 (pascal_object_print_value_fields): Use metadata style.
3841 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3842 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3843 parameter.
3844 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3845 * m2-valprint.c (m2_print_long_set): Use metadata style.
3846 * m2-typeprint.c (m2_print_type): Use metadata style.
3847 * infcmd.c (print_return_value_1): Use metadata style.
3848 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3849 * f-valprint.c (info_common_command_for_block): Use metadata
3850 style.
3851 * f-typeprint.c (f_type_print_base): Use metadata style.
3852 * expprint.c (print_subexp_standard): Use metadata style.
3853 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3854 * cli/cli-style.h (class cli_style_option): Add constructor.
3855 (metadata_style): Declare.
3856 * cli/cli-style.c (metadata_style): New global.
3857 (_initialize_cli_style): Register metadata style.
3858 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3859 parameter.
3860 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3861 * c-typeprint.c (c_type_print_base_struct_union)
3862 (c_type_print_base_1): Use metadata style.
3863 * breakpoint.c (watchpoint_value_print)
3864 (print_one_breakpoint_location): Use metadata style.
3865 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3866 style.
3867 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3868 style.
3869 * ada-valprint.c (val_print_packed_array_elements, printstr)
3870 (print_field_values, ada_val_print_ref, ada_val_print): Use
3871 metadata style.
3872 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3873 style.
3874 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3875 style.
3876 * ada-lang.c (user_select_syms): Use metadata style.
3877
14309bb6
TT		 38782019-10-01 Tom Tromey <tom@tromey.com>
3879
3880 * cli/cli-cmds.c (pwd_command): Style output.
3881
6a831f06
PA		 38822019-10-01 Pedro Alves <palves@redhat.com>
3883 Tom Tromey <tom@tromey.com>
3884
3885 * symtab.c (print_symbol_info): Use %ps.
3886 (print_msymbol_info): Use %ps.
3887 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3888 * printcmd.c (print_variable_and_value): Use %ps.
3889 * macrocmd.c (show_pp_source_pos): Use %ps.
3890 * infrun.c (print_exited_reason): Use ui_out::message.
3891 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3892 (describe_other_breakpoints): Use ui_out::message and new
3893 formats.
3894 (say_where): Use new formats.
3895 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3896 and new formats.
3897
2a3c1174
PA		 38982019-10-01 Pedro Alves <palves@redhat.com>
3899 Tom Tromey <tom@tromey.com>
3900
3901 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3902 (test_gdb_formats): New function.
3903 (run_tests): Call it.
3904 (test_format_specifier): Update.
3905 * utils.h (fputs_filtered): Update comment.
3906 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3907 (fputs_styled_unfiltered): Declare.
3908 * utils.c (fputs_styled_unfiltered): New function.
3909 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3910 (vfprintf_filtered): Update.
3911 (vfprintf_unfiltered, vprintf_filtered): Update.
3912 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3913 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3914 disallow_ui_out_field>: New constants.
3915 (enum class field_kind): New.
3916 (struct base_field_s, struct signed_field_s): New.
3917 (signed_field): New function.
3918 (struct string_field_s): New.
3919 (string_field): New function.
3920 (struct styled_string_s): New.
3921 (styled_string): New function.
3922 (class ui_out) <message>: Add comment.
3923 <vmessage, call_do_message>: New methods.
3924 <do_message>: Add style parameter.
3925 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3926 methods.
3927 (ui_out::message): Rewrite.
3928 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3929 parameter.
3930 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3931 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3932 gdb_extensions parameter.
3933 (class format_piece): Add parameter to constructor.
3934 (n_int_args): New field.
3935 * gdbsupport/format.c (format_pieces::format_pieces): Add
3936 gdb_extensions parameter. Handle '*'.
3937 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3938 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3939 vfprintf_styled_no_gdbfmt.
3940 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3941 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3942 unfiltered output.
3943 * ui-style.h (struct ui_file_style) <ptr>: New method.
3944
0dfe5bfb
TT		 39452019-10-01 Tom Tromey <tom@tromey.com>
3946
3947 * unittests/format_pieces-selftests.c: Update. Add final format.
3948 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3949 empty literal pieces.
3950
e43b10e1
TT		 39512019-10-01 Tom Tromey <tom@tromey.com>
3952
3953 * ui-out.h (enum class ui_out_style_kind): Remove.
3954 (class ui_out) <field_string, field_stsream, do_field_string>:
3955 Change type of "style".
3956 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3957 (ui_out::field_string): Update.
3958 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3959 of "style".
3960 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3961 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3962 * stack.c (print_frame_arg, print_frame_info, print_frame):
3963 Update.
3964 * source.c (print_source_lines_base): Update.
3965 * solib.c (info_sharedlibrary_command): Update.
3966 * skip.c (info_skip_command): Update.
3967 * record-btrace.c (btrace_call_history_src_line)
3968 (btrace_call_history): Update.
3969 * python/py-framefilter.c (py_print_frame): Update.
3970 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3971 "style".
3972 * mi/mi-out.c (mi_ui_out::do_table_header)
3973 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3974 (mi_ui_out::do_field_string): Update.
3975 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3976 Update.
3977 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3978 "style".
3979 * cli-out.c (cli_ui_out::do_table_header)
3980 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3981 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3982 (cli_ui_out::do_field_fmt): Update.
3983 * breakpoint.c (print_breakpoint_location): Update.
3984 (update_static_tracepoint): Update.
3985
cd7c32c3
PW		 39862019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3987
3988 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3989 conversion of gdb_datadir.
3990 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3991 remove not needed c_str ().
3992
8fe0f950
AT		 39932019-09-30 Ali Tamur <tamur@google.com>
3994
3995 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3996 (dwarf2_string_attr): Likewise.
3997
5f48f8f3
AT		 39982019-09-30 Ali Tamur <tamur@google.com>
3999
4000 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4001 (process_full_type_unit): Likewise.
4002 (dump_die_shallow): Likewise.
4003 (cu_debug_loc_section): Likewise.
4004
6fb08628
CB		 40052019-09-28 Christian Biesinger <cbiesinger@google.com>
4006
4007 * minsyms.c (compare_minimal_symbols): Rename to...
4008 (minimal_symbol_is_less_than): ...this, and adjust to STL
4009 conventions (return bool, take arguments as references)
4010 (minimal_symbol_reader::install): Call std::sort instead
4011 of qsort.
4012
c7ee338a
CB		 40132019-09-29 Christian Biesinger <cbiesinger@google.com>
4014
4015 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4016 hash and why.
4017 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4018 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4019
703a86c2
SM		 40202019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4021
4022 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4023 * psympriv.h (add_psymbol_to_list): Move comment here and update
4024 it.
4025
0df0352a
TV		 40262019-09-29 Tom de Vries <tdevries@suse.de>
4027
4028 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4029 Use $tmpdir/$(basename "$output_file").dwz instead of
4030 "${output_file}.dwz".
4031
ad75efa6
SM		 40322019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4033
4034 PR gdb/25045
4035 * hppa-linux-nat.c: Include gdbarch.h.
4036
ececd218
CB		 40372019-09-26 Christian Biesinger <cbiesinger@google.com>
4038
4039 * blockframe.c (find_pc_partial_function): Change return type to bool.
4040 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4041 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4042 (stub_gnu_ifunc_resolve_name): Likewise.
4043 * symtab.c (compare_filenames_for_search): Likewise.
4044 (compare_glob_filenames_for_search): Likewise.
4045 (matching_obj_sections): Likewise.
4046 (symbol_matches_domain): Likewise.
4047 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4048 (find_line_pc): Change return type to bool.
4049 (find_line_pc_range): Likewise.
4050 (producer_is_realview): Likewise.
4051 * symtab.h (symbol_matches_domain): Likewise.
4052 (find_pc_partial_function): Likewise.
4053 (find_pc_line_pc_range): Likewise.
4054 (in_gnu_ifunc_stub): Likewise.
4055 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4056 (find_line_pc): Likewise.
4057 (find_line_pc_range): Likewise.
4058 (matching_obj_sections): Likewise.
4059 (find_line_symtab): Change out parameter to bool.
4060 (producer_is_realview): Change return type to bool.
4061 (compare_filenames_for_search): Likewise.
4062 (compare_glob_filenames_for_search): Likewise.
4063
27a900b8
TT		 40642019-09-26 Tom Tromey <tom@tromey.com>
4065
4066 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4067 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4068 * gdb_usleep.h: Remove.
4069 * gdb_usleep.c: Remove.
4070 * utils.c: Don't include gdb_usleep.h.
4071
5d63b30a
TT		 40722019-09-26 Tom Tromey <tromey@adacore.com>
4073
4074 * python/py-type.c (type_to_type_object): Call check_typedef
4075 for stub types.
4076
12904d37
TT		 40772019-09-26 Tom Tromey <tom@tromey.com>
4078
4079 * utils.h (initialize_utils): Don't declare.
4080 * top.c (gdb_init): Don't call initialize_utils.
4081 * utils.c (initialize_utils): Remove. Move contents...
4082 (_initialize_utils): ... here.
4083
858f25f0
TT		 40842019-09-25 Tom Tromey <tom@tromey.com>
4085
4086 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4087 * utils.h (make_hex_string): Don't declare.
4088 * utils.c (make_hex_string): Remove.
4089
3d435220
TV		 40902019-09-24 Tom de Vries <tdevries@suse.de>
4091
4092 PR gdb/23815
4093 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4094 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4095
ddd44b70
DD		 40962019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4097
4098 * NEWS: Mention new simulator port for PRU.
4099
f945dedf
CB		 41002019-09-23 Christian Biesinger <cbiesinger@google.com>
4101
4102 * ada-exp.y (write_object_remaining): Update.
4103 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4104 and eliminate the static buffer.
4105 (ada_decode_symbol): Update.
4106 (ada_la_decode): Update.
4107 (ada_sniff_from_mangled_name): Update.
4108 (is_valid_name_for_wild_match): Update.
4109 (ada_lookup_name_info::matches): Update and simplify.
4110 (name_matches_regex): Update.
4111 (ada_add_global_exceptions): Update.
4112 * ada-lang.h (ada_decode): Update signature.
4113 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4114 * dwarf-index-write.c (debug_names::insert): Update.
4115
7ab78ccb
SM		 41162019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4117
4118 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4119 formatting.
4120
9252448b
SM		 41212019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4122
4123 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4124 Change "nonzero" to "true" in documentation.
4125
626ca2c0
CB		 41262019-09-20 Christian Biesinger <cbiesinger@google.com>
4127
4128 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4129 (_initialize_darwin_solib): Don't set
4130 darwin_so_ops.lookup_lib_global_symbol.
4131 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4132 set_gdbarch_iterate_over_objfiles_in_search_order.
4133 (elf_lookup_lib_symbol): Rename to...
4134 (svr4_iterate_over_objfiles_in_search_order): this, and update
4135 to iterate semantics.
4136 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4137 * solib.c (solib_global_lookup): Remove.
4138 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4139 (solib_global_lookup): Remove.
4140 * symtab.c (lookup_global_or_static_symbol): Remove call to
4141 solib_global_lookup.
4142
5a3a0d63
JB		 41432019-09-20 Joel Brobecker <brobecker@adacore.com>
4144
4145 * NEWS: Move entries about default MI version now being
4146 version 3, and about the GDB/MI fix for multi-location
4147 breakpoints to the "since GDB 8.3" section.
4148
ffea1427
JB		 41492019-09-20 Joel Brobecker <brobecker@adacore.com>
4150
4151 GDB 8.3.1 released.
4152
abf516c6
UW		 41532019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4154
4155 * NEWS: Mention that Cell/B.E. debugging support was removed.
4156 * MAINTAINERS: Remove spu target.
4157
4158 * config/djgpp/fnchange.lst: Remove entries for removed files.
4159
4160 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4161 spu-multiarch.o, and spu-tdep.o.
4162 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4163 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4164 spu-multiarch.c, and spu-tdep.c.
4165 * spu-linux-nat.c: Remove file.
4166 * spu-multiarch.c: Remove file.
4167 * spu-tdep.c: Remove file.
4168 * spu-tdep.h: Remove file.
4169 * solib-spu.c: Remove file.
4170 * solib-spu.h: Remove file.
4171
4172 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4173 * configure.nat (spu-linux): Remove.
4174 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4175 solib-multiarch.o from gdb_target_obs.
4176 (spu*-*-*): Remove.
4177
4178 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4179 feature flag.
4180 (ppc_linux_no_features): Update.
4181 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4182 Cell/B.E. support.
4183 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4184 (tdesc_powerpc_cell64l): Likewise.
4185 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4186 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4187 Cell/B.E. support.
4188 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4189 Do not include "features/rs6000/powerpc-cell32l.c" or
4190 "features/rs6000/powerpc-cell64l.c".
4191 (ppc_linux_spu_section): Remove.
4192 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4193 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4194 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4195 (ppc_linux_spe_context_lookup): Remove.
4196 (ppc_linux_spe_context_inferior_created): Remove.
4197 (ppc_linux_spe_context_solib_loaded): Remove.
4198 (ppc_linux_spe_context_solib_unloaded): Remove.
4199 (ppc_linux_spe_context): Remove.
4200 (struct ppu2spu_cache): Remove.
4201 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4202 (struct ppu2spu_data): Remove.
4203 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4204 ppu2spu_unwind): Remove.
4205 (ppc_linux_init_abi): Remove Cell/B.E. support.
4206 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4207
4208 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4209 (rs6000/powerpc-cell64l-expedite): Likewise
4210 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4211 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4212 rs6000/powerpc-cell64l.xml.
4213 * features/rs6000/powerpc-cell32l.xml: Remove.
4214 * features/rs6000/powerpc-cell64l.xml: Likewise.
4215 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4216 * features/rs6000/powerpc-cell64l.c: Likewise.
4217 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4218 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4219 * regformats/reg-spu.dat: Remove.
4220
4221 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4222 * corelow.c (struct spuid_list): Remove.
4223 (add_to_spuid_list): Remove.
4224 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4225 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4226 (remote_protocol_features): Remove associated entries.
4227 (_initialize_remote): No longer initialize them.
4228 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4229 * linux-nat.c (SPUFS_MAGIC): Remove.
4230 (linux_proc_xfer_spu): Remove.
4231 (spu_enumerate_spu_ids): Remove.
4232 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4233 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4234 (linux_make_corefile_notes): No longer call it.
4235
4236 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4237 (cooked_write_test): Likewise.
4238
78e8cb91
TT		 42392019-09-20 Tom Tromey <tom@tromey.com>
4240
4241 * NEWS: Mention case-sensitivity of TUI commands.
4242 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4243 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4244 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4245
f074b67e
TT		 42462019-09-20 Tom Tromey <tom@tromey.com>
4247
4248 * tui/tui-source.c (tui_source_window::set_contents): Use
4249 make_unique_xstrdup.
4250 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4251 make_unique_xstrdup.
4252
63c4bf19
TT		 42532019-09-20 Tom Tromey <tom@tromey.com>
4254
4255 * tui/tui-data.c: Remove separator comments.
4256 * tui/tui-layout.c: Remove separator comments.
4257 * tui/tui-win.c: Remove separator comments.
4258 * tui/tui-wingeneral.c: Remove separator comments.
4259
43df9b2f
TT		 42602019-09-20 Tom Tromey <tom@tromey.com>
4261
4262 * tui/tui.h (strcat_to_buf): Don't declare.
4263 * tui/tui.c (strcat_to_buf): Remove.
4264
7226433c
TT		 42652019-09-20 Tom Tromey <tom@tromey.com>
4266
4267 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4268 from "fullname".
4269 * tui/tui-source.c (tui_source_window::set_contents)
4270 (tui_source_window::location_matches_p)
4271 (tui_source_window::maybe_update): Update.
4272
80df3337
TT		 42732019-09-20 Tom Tromey <tom@tromey.com>
4274
4275 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4276 Update.
4277 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4278 prefix.
4279 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4280 (tui_data_window::line_from_reg_element_no)
4281 (tui_data_window::first_reg_element_no_inline)
4282 (tui_data_window::show_registers)
4283 (tui_data_window::show_register_group)
4284 (tui_data_window::display_registers_from)
4285 (tui_data_window::display_registers_from_line)
4286 (tui_data_window::first_data_item_displayed)
4287 (tui_data_window::delete_data_content_windows)
4288 (tui_data_window::erase_data_content)
4289 (tui_data_window::do_scroll_vertical)
4290 (tui_data_window::refresh_window)
4291 (tui_data_window::check_register_values): Update.
4292
9923f347
TT		 42932019-09-20 Tom Tromey <tom@tromey.com>
4294
4295 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4296 (struct tui_locator_window) <full_name, proc_name>: Now
4297 std::string.
4298 * tui/tui-stack.c (tui_locator_window::make_status_line)
4299 (tui_locator_window::set_locator_fullname)
4300 (tui_locator_window::set_locator_info): Update.
4301 * tui/tui-source.c (tui_source_window::set_contents)
4302 (tui_source_window::showing_source_p): Update.
4303
b76251ab
TT		 43042019-09-20 Tom Tromey <tom@tromey.com>
4305
4306 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4307 Don't call tui_locator_win_info_ptr.
4308
0891be08
TT		 43092019-09-20 Tom Tromey <tom@tromey.com>
4310
4311 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4312
1b935acf
TT		 43132019-09-20 Tom Tromey <tom@tromey.com>
4314
4315 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4316 height for locator.
4317 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4318 * tui/tui-layout.c (show_source_disasm_command, show_data)
4319 (show_source_or_disasm_and_command): Use 1 as height for locator.
4320
9abd8a65
TT		 43212019-09-20 Tom Tromey <tom@tromey.com>
4322
4323 * tui/tui.c (tui_enable): Update.
4324 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4325 Update.
4326 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4327 Update.
4328 * tui/tui-data.c (win_resized): Now bool.
4329 (tui_win_resized): Return bool.
4330 (tui_set_win_resized_to): Accept a bool.
4331
b5457826
TT		 43322019-09-20 Tom Tromey <tom@tromey.com>
4333
4334 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4335 Change type of "refresh_values_only".
4336 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4337 type of "refresh_values_only".
4338
6b915f7d
TT		 43392019-09-20 Tom Tromey <tom@tromey.com>
4340
4341 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4342 std::string.
4343 (tui_disassemble): Add "pos" parameter.
4344 (tui_disasm_window::set_contents): Simplify.
4345
2ad52f6f
TT		 43462019-09-20 Tom Tromey <tom@tromey.com>
4347
4348 * tui/tui-winsource.h (struct tui_source_window_base)
4349 <show_source_content>: Now private.
4350 * tui/tui-winsource.c
4351 (tui_source_window_base::show_source_content): Don't handle empty
4352 content case.
4353
b3b1bde6
TT		 43542019-09-20 Tom Tromey <tom@tromey.com>
4355
4356 * tui/tui-layout.c (show_source_disasm_command)
4357 (show_source_or_disasm_and_command): Don't call
4358 show_source_content.
4359
71a25ed2
TT		 43602019-09-20 Tom Tromey <tom@tromey.com>
4361
4362 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4363 Declare.
4364 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4365 from tui_make_status_line.
4366 (tui_locator_window::rerender): Update.
4367
f8532154
TT		 43682019-09-20 Tom Tromey <tom@tromey.com>
4369
4370 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4371 (tui_locator_window::rerender): Update.
4372
2d81b349
TT		 43732019-09-20 Tom Tromey <tom@tromey.com>
4374
4375 * tui/tui-winsource.h (struct tui_source_window_base)
4376 <~tui_source_window_base>: Don't declare.
4377 <fullname>: Remove.
4378 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4379 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4380 member.
4381 * tui/tui-source.c (tui_source_window::set_contents): Update.
4382 (tui_source_window::location_matches_p)
4383 (tui_source_window::maybe_update): Update.
4384
f14bec58
TT		 43852019-09-20 Tom Tromey <tom@tromey.com>
4386
4387 * tui/tui-winsource.h (~tui_source_element): Remove.
4388 (tui_source_element): Update.
4389 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4390 * tui/tui-winsource.c (tui_show_source_line): Update.
4391 * tui/tui-source.c (tui_source_window::set_contents): Update.
4392 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4393
78d5933a
TT		 43942019-09-20 Tom Tromey <tom@tromey.com>
4395
4396 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4397 declare.
4398 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4399 tui_clear_source_windows_detail.
4400 * tui/tui-winsource.h (struct tui_source_window_base)
4401 <clear_detail>: Don't declare.
4402 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4403 Remove.
4404 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4405
d4207696
TT		 44062019-09-20 Tom Tromey <tromey@adacore.com>
4407
4408 PR ada/24919:
4409 * block.c (contained_in): Fix final return value.
4410
00f93c44
AM		 44112019-09-20 Alan Modra <amodra@gmail.com>
4412
4413 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4414 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4415 (read_indirect_string_from_dwz): Use bfd accessor.
4416 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4417 * machoread.c (macho_symfile_read_all_oso): Likewise.
4418 * solib.c (solib_bfd_open): Likewise.
4419
e4153ae6
CB		 44202019-09-19 Christian Biesinger <cbiesinger@google.com>
4421
4422 * eval.c: Move declaration of overload_resolution to...
4423 * value.h: ...here.
4424
c7ae7675
CB		 44252019-09-19 Christian Biesinger <cbiesinger@google.com>
4426
4427 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4428 * arm-linux-tdep.c: Likewise.
4429 * arm-nbsd-nat.c: Likewise.
4430 * arm-tdep.h: Declare arm_apcs_32.
4431 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4432
e86f08d2
CB		 44332019-09-19 Christian Biesinger <cbiesinger@google.com>
4434
4435 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4436 * dwarf2read.h: Declare dwarf_always_disassemble.
4437
f64e2f40
TV		 44382019-09-19 Tom de Vries <tdevries@suse.de>
4439
4440 PR gdb/25009
4441 * source-cache.c (source_cache::ensure): Catch exception thrown during
4442 construction of the highlighter.
4443
fd361982
AM		 44442019-09-18 Alan Modra <amodra@gmail.com>
4445
4446 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4447 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4448 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4449 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4450 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4451 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4452 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4453 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4454 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4455 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4456 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4457 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4458 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4459 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4460 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4461 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4462 * mi/mi-interp.c: Update throughout for bfd section macro and
4463 function changes.
4464 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4465 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4466
11061048
TT		 44672019-09-18 Tom Tromey <tom@tromey.com>
4468
4469 * NEWS: Add entry.
4470 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4471 call rl_initialize.
4472 (tui_enable): Do not call rl_initialize.
4473
7a27b85f
CG		 44742019-09-18 Christian Groessler <chris@groessler.org>
4475
4476 * alpha-linux-nat.c: Include gdbarch.h.
4477
f64eea3a
SM		 44782019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4479
4480 * ui-file.c: Include cli/cli-style.h.
4481 (term_cli_styling): Remove cli_styling declaration.
4482
e6f7f6d1
AM		 44832019-09-18 Alan Modra <amodra@gmail.com>
4484
4485 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4486 to bfd_asymbol_section.
4487
1d38e9d1
AM		 44882019-09-18 Alan Modra <amodra@gmail.com>
4489
4490 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4491 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4492 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4493
90d92a63
AM		 44942019-09-18 Alan Modra <amodra@gmail.com>
4495
4496 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4497 * spu-linux-nat.c (spu_bfd_open): Likewise.
4498
a3d181d2
CB		 44992019-09-18 Christian Biesinger <cbiesinger@google.com>
4500
4501 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4502 to bool to match definition in dwarf2read.c.
4503
491144b5
CB		 45042019-09-17 Christian Biesinger <cbiesinger@google.com>
4505
4506 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4507 (print_signatures): Likewise.
4508 (trust_pad_over_xvs): Likewise.
4509 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4510 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4511 * arm-linux-nat.c (arm_apcs_32): Likewise.
4512 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4513 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4514 * arm-tdep.c (arm_debug): Likewise.
4515 (arm_apcs_32): Likewise.
4516 * auto-load.c (debug_auto_load): Likewise.
4517 (auto_load_gdb_scripts): Likewise.
4518 (global_auto_load): Likewise.
4519 (auto_load_local_gdbinit): Likewise.
4520 (auto_load_local_gdbinit_loaded): Likewise.
4521 * auto-load.h (global_auto_load): Likewise.
4522 (auto_load_local_gdbinit): Likewise.
4523 (auto_load_local_gdbinit_loaded): Likewise.
4524 * breakpoint.c (disconnected_dprintf): Likewise.
4525 (breakpoint_proceeded): Likewise.
4526 (automatic_hardware_breakpoints): Likewise.
4527 (always_inserted_mode): Likewise.
4528 (target_exact_watchpoints): Likewise.
4529 (_initialize_breakpoint): Update.
4530 * breakpoint.h (target_exact_watchpoints): Change to bool.
4531 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4532 * cli/cli-cmds.c (trace_commands): Likewise.
4533 * cli/cli-cmds.h (trace_commands): Likewise.
4534 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4535 to bool*.
4536 * cli/cli-logging.c (logging_overwrite): Change to bool.
4537 (logging_redirect): Likewise.
4538 (debug_redirect): Likewise.
4539 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4540 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4541 to bool.
4542 <boolean_option_def>: Update.
4543 (struct flag_option_def): Change default type of Context to bool
4544 from int.
4545 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4546 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4547 (get_setshow_command_value_string): Likewise.
4548 * cli/cli-style.c (cli_styling): Change to bool.
4549 (source_styling): Likewise.
4550 * cli/cli-style.h (source_styling): Likewise.
4551 (cli_styling): Likewise.
4552 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4553 to bool.
4554 * command.h (var_types): Update comment.
4555 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4556 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4557 bool.
4558 (debug_compile_cplus_scopes): Likewise.
4559 * compile/compile-internal.h (compile_debug): Likewise.
4560 * compile/compile.c (compile_debug): Likewise.
4561 (struct compile_options) <raw>: Likewise.
4562 * cp-support.c (catch_demangler_crashes): Likewise.
4563 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4564 (usr_cmd_cris_dwarf2_cfi): Likewise.
4565 * csky-tdep.c (csky_debug): Likewise.
4566 * darwin-nat.c (enable_mach_exceptions): Likewise.
4567 * dcache.c (dcache_enabled_p): Likewise.
4568 * defs.h (info_verbose): Likewise.
4569 * demangle.c (demangle): Likewise.
4570 (asm_demangle): Likewise.
4571 * dwarf-index-cache.c (debug_index_cache): Likewise.
4572 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4573 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4574 * dwarf2read.c (check_physname): Likewise.
4575 (use_deprecated_index_sections): Likewise.
4576 (dwarf_always_disassemble): Likewise.
4577 * eval.c (overload_resolution): Likewise.
4578 * event-top.c (set_editing_cmd_var): Likewise.
4579 (exec_done_display_p): Likewise.
4580 * event-top.h (set_editing_cmd_var): Likewise.
4581 (exec_done_display_p): Likewise.
4582 * exec.c (write_files): Likewise.
4583 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4584 (debug_fbsd_nat): Likewise.
4585 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4586 Likewise.
4587 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4588 <backtrace_past_entry> Likewise.
4589 * gdb-demangle.h (demangle): Likewise.
4590 (asm_demangle): Likewise.
4591 * gdb_bfd.c (bfd_sharing): Likewise.
4592 * gdbcore.h (write_files): Likewise.
4593 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4594 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4595 * gdbthread.h (print_thread_events): Likewise.
4596 * gdbtypes.c (opaque_type_resolution): Likewise.
4597 (strict_type_checking): Likewise.
4598 * gnu-nat.c (gnu_debug_flag): Likewise.
4599 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4600 * guile/scm-param.c (pascm_variable): Add boolval.
4601 (add_setshow_generic): Update.
4602 (pascm_param_value): Update.
4603 (pascm_set_param_value_x): Update.
4604 * hppa-tdep.c (hppa_debug): Change to bool..
4605 * infcall.c (may_call_functions_p): Likewise.
4606 (coerce_float_to_double_p): Likewise.
4607 (unwind_on_signal_p): Likewise.
4608 (unwind_on_terminating_exception_p): Likewise.
4609 * infcmd.c (startup_with_shell): Likewise.
4610 * inferior.c (print_inferior_events): Likewise.
4611 * inferior.h (startup_with_shell): Likewise.
4612 (print_inferior_events): Likewise.
4613 * infrun.c (step_stop_if_no_debug): Likewise.
4614 (detach_fork): Likewise.
4615 (debug_displaced): Likewise.
4616 (disable_randomization): Likewise.
4617 (non_stop): Likewise.
4618 (non_stop_1): Likewise.
4619 (observer_mode): Likewise.
4620 (observer_mode_1): Likewise.
4621 (set_observer_mode): Update.
4622 (sched_multi): Change to bool.
4623 * infrun.h (debug_displaced): Likewise.
4624 (sched_multi): Likewise.
4625 (step_stop_if_no_debug): Likewise.
4626 (non_stop): Likewise.
4627 (disable_randomization): Likewise.
4628 * linux-tdep.c (use_coredump_filter): Likewise.
4629 (dump_excluded_mappings): Likewise.
4630 * linux-thread-db.c (auto_load_thread_db): Likewise.
4631 (check_thread_db_on_load): Likewise.
4632 * main.c (captured_main_1): Update.
4633 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4634 xx2_opt, boolean_opt>: Change to bool.
4635 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4636 * maint.c (maintenance_profile_p): Likewise.
4637 (per_command_time): Likewise.
4638 (per_command_space): Likewise.
4639 (per_command_symtab): Likewise.
4640 * memattr.c (inaccessible_by_default): Likewise.
4641 * mi/mi-main.c (mi_async): Likewise.
4642 (mi_async_1): Likewise.
4643 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4644 * nat/fork-inferior.h (startup_with_shell): Likewise.
4645 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4646 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4647 * nios2-tdep.c (nios2_debug): Likewise.
4648 * or1k-tdep.c (or1k_debug): Likewise.
4649 * parse.c (parser_debug): Likewise.
4650 * parser-defs.h (parser_debug): Likewise.
4651 * printcmd.c (print_symbol_filename): Likewise.
4652 * proc-api.c (procfs_trace): Likewise.
4653 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4654 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4655 (set_parameter_value): Update.
4656 (add_setshow_generic): Update.
4657 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4658 to bool*.
4659 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4660 int*.
4661 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4662 * record-btrace.c (record_btrace_target::store_registers): Update.
4663 * record-full.c (record_full_memory_query): Change to bool.
4664 (record_full_stop_at_limit): Likewise.
4665 * record-full.h (record_full_memory_query): Likewise.
4666 * remote-notif.c (notif_debug): Likewise.
4667 * remote-notif.h (notif_debug): Likewise.
4668 * remote.c (use_range_stepping): Likewise.
4669 (interrupt_on_connect): Likewise.
4670 (remote_break): Likewise.
4671 * ser-tcp.c (tcp_auto_retry): Likewise.
4672 * ser-unix.c (serial_hwflow): Likewise.
4673 * skip.c (debug_skip): Likewise.
4674 * solib-aix.c (solib_aix_debug): Likewise.
4675 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4676 (spu_auto_flush_cache_p): Likewise.
4677 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4678 Likewise.
4679 (struct info_print_options) <quiet>: Likewise.
4680 * symfile-debug.c (debug_symfile): Likewise.
4681 * symfile.c (auto_solib_add): Likewise.
4682 (separate_debug_file_debug): Likewise.
4683 * symfile.h (auto_solib_add): Likewise.
4684 (separate_debug_file_debug): Likewise.
4685 * symtab.c (basenames_may_differ): Likewise.
4686 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4687 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4688 (struct info_types_options) <quiet>: Likewise.
4689 * symtab.h (demangle): Likewise.
4690 (basenames_may_differ): Likewise.
4691 * target-dcache.c (stack_cache_enabled_1): Likewise.
4692 (code_cache_enabled_1): Likewise.
4693 * target.c (trust_readonly): Likewise.
4694 (may_write_registers): Likewise.
4695 (may_write_memory): Likewise.
4696 (may_insert_breakpoints): Likewise.
4697 (may_insert_tracepoints): Likewise.
4698 (may_insert_fast_tracepoints): Likewise.
4699 (may_stop): Likewise.
4700 (auto_connect_native_target): Likewise.
4701 (target_stop_and_wait): Update.
4702 (target_async_permitted): Change to bool.
4703 (target_async_permitted_1): Likewise.
4704 (may_write_registers_1): Likewise.
4705 (may_write_memory_1): Likewise.
4706 (may_insert_breakpoints_1): Likewise.
4707 (may_insert_tracepoints_1): Likewise.
4708 (may_insert_fast_tracepoints_1): Likewise.
4709 (may_stop_1): Likewise.
4710 * target.h (target_async_permitted): Likewise.
4711 (may_write_registers): Likewise.
4712 (may_write_memory): Likewise.
4713 (may_insert_breakpoints): Likewise.
4714 (may_insert_tracepoints): Likewise.
4715 (may_insert_fast_tracepoints): Likewise.
4716 (may_stop): Likewise.
4717 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4718 (make_thread_apply_all_options_def_group): Change argument from int*
4719 to bool*.
4720 (thread_apply_all_command): Update.
4721 (print_thread_events): Change to bool.
4722 * top.c (confirm): Likewise.
4723 (command_editing_p): Likewise.
4724 (history_expansion_p): Likewise.
4725 (write_history_p): Likewise.
4726 (info_verbose): Likewise.
4727 * top.h (confirm): Likewise.
4728 (history_expansion_p): Likewise.
4729 * tracepoint.c (disconnected_tracing): Likewise.
4730 (circular_trace_buffer): Likewise.
4731 * typeprint.c (print_methods): Likewise.
4732 (print_typedefs): Likewise.
4733 * utils.c (debug_timestamp): Likewise.
4734 (sevenbit_strings): Likewise.
4735 (pagination_enabled): Likewise.
4736 * utils.h (sevenbit_strings): Likewise.
4737 (pagination_enabled): Likewise.
4738 * valops.c (overload_resolution): Likewise.
4739 * valprint.h (struct value_print_options) <prettyformat_arrays,
4740 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4741 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4742 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4743 Likewise.
4744 * windows-nat.c (new_console): Likewise.
4745 (cygwin_exceptions): Likewise.
4746 (new_group): Likewise.
4747 (debug_exec): Likewise.
4748 (debug_events): Likewise.
4749 (debug_memory): Likewise.
4750 (debug_exceptions): Likewise.
4751 (useshell): Likewise.
4752 * windows-tdep.c (maint_display_all_tib): Likewise.
4753 * xml-support.c (debug_xml): Likewise.
4754
f1b620e9
MG		 47552019-09-17 Mike Gulick <mgulick@mathworks.com>
4756
4757 * source.c (prepare_path_for_appending): New function.
4758 (openp): Make use of new function.
4759 (find_and_open_source): Search for the compilation directory and
4760 source file as a relative path beneath the directory search path.
4761
67f3ed6a
AB		 47622019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4763
4764 * source-cache.c (source_cache::get_line_charpos): Catch
4765 exceptions and return false, this matches the behaviour documented
4766 in the header file.
4767
74332189
JB		 47682019-09-17 Joel Brobecker <brobecker@adacore.com>
4769
4770 * ada-tasks.c (info_task): Remove quoting of the task's name.
4771
f2f24aa9
CB		 47722019-09-16 Christian Biesinger <cbiesinger@google.com>
4773
4774 * symfile.c (auto_solib_add): Replace comment with a reference
4775 to the header file.
4776
6a062a93
CB		 47772019-09-14 Christian Biesinger <cbiesinger@google.com>
4778
4779 * NEWS: Mention that gdb can now be compiled with Python 3
4780 on Windows.
4781
ec6c8338
AB		 47822019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4783
4784 * maint.c (maint_print_section_data::maint_print_section_data):
4785 Force use of 'float log10 (float)' by casting the argument to
4786 float.
4787
aa17805f
AB		 47882019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4789
4790 * maint.c: Add 'cmath' include.
4791 (struct maint_print_section_data): New structure.
4792 (print_section_index): New function.
4793 (print_bfd_section_info): Add header comment, small whitespace
4794 cleanup, and update to call new print_section_index function.
4795 (print_objfile_section_info): Likewise.
4796 (maint_obj_section_from_bfd_section): New function.
4797 (print_bfd_section_info_maybe_relocated): New function.
4798 (maintenance_info_sections): Add header comment, always use
4799 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4800
3dd9bb46
AB		 48012019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4802
4803 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4804 inner scope, add check that the objfile has psymtabs before
4805 checking psymtabs_addrmap.
4806 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4807
4993045d
PW		 48082019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4809
4810 * NEWS: Announce that Ada task names are now shown at more places,
4811 and between quotes (except in info task output).
4812 * gdb/ada-tasks.c (task_to_str): New function.
4813 (display_current_task_id): Call task_to_str.
4814 (task_command_1): Likewise.
4815 (print_ada_task_info): In non-mi mode, Properly align headers and data
4816 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4817
7a289707
RO		 48182019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4819
4820 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4821 prstatus.pr_lwp.pr_info instead of making it up.
4822
f2aec7f6
CB		 48232019-09-11 Christian Biesinger <cbiesinger@google.com>
4824
4825 * auto-load.c (auto_load_expand_dir_vars): Update.
4826 * defs.h (gdb_datadir): Change to std::string.
4827 (python_libdir): Likewise.
4828 (relocate_gdb_directory): Change return type to std::string.
4829 * guile/guile.c (gdbscm_data_directory): Update.
4830 (initialize_scheme_side): Update.
4831 * jit.c (jit_reader_dir): Change to std::string.
4832 (jit_reader_load_command): Update.
4833 * main.c (gdb_datadir): Change to std::string.
4834 (python_libdir): Likewise.
4835 (set_gdb_data_directory): Update.
4836 (relocate_path): Change to return std::string.
4837 (relocate_gdb_directory): Change to return std::string.
4838 (relocate_gdbinit_path_maybe_in_datadir): Update.
4839 (captured_main_1): Update.
4840 * python/python.c (do_start_initialization): Update.
4841 * top.c (show_gdb_datadir): Update.
4842 * xml-syscall.c (xml_init_syscalls_info): Update.
4843 (init_syscalls_info): Update.
4844
9224a013
CB		 48452019-09-11 Christian Biesinger <cbiesinger@google.com>
4846
4847 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4848 out of get_init_files.
4849 (get_init_files): Update.
4850
f48cd836
CB		 48512019-09-11 Christian Biesinger <cbiesinger@google.com>
4852
4853 * main.c (get_init_files): Change to use std::string.
4854 (captured_main_1): Update.
4855 (print_gdb_help): Update.
4856
9cab7ecd
AT		 48572019-09-11 Ali Tamur <tamur@google.com>
4858
4859 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4860 implementation.
4861
67547d89
CB		 48622019-09-11 Christian Biesinger <cbiesinger@google.com>
4863
4864 * dbxread.c (read_dbx_symtab): Update.
4865 * dwarf2read.c (load_partial_dies): Update.
4866 * mdebugread.c (parse_partial_symbols): Update.
4867 (handle_psymbol_enumerators): Update.
4868 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4869 * psymtab.c (add_psymbol_to_bcache): Likewise.
4870 (add_psymbol_to_list): Likewise.
4871 * symtab.c (symbol_set_names): Likewise.
4872 * symtab.h (symbol_set_names): Likewise.
4873 * xcoffread.c (scan_xcoff_symtab): Update.
4874
64b2d4a0
TT		 48752019-09-11 Tom Tromey <tom@tromey.com>
4876
4877 * symfile-mem.c (symbol_file_add_from_memory): Use
4878 bfd_set_filename.
4879 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4880 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4881
3b00ef10
TT		 48822019-09-10 Tom Tromey <tromey@adacore.com>
4883
4884 * dwarf-index-write.c (write_psymbols): Extend error message.
4885 (debug_names::insert): Add Ada code.
4886 (debug_names::write_psymbols): Remove Ada check.
4887 (debug_names) <m_string_obstack>: New member.
4888 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4889 (gdb_index_symbol_name_matcher::matches): Remove.
4890 (mapped_index_base::find_name_components_bounds): Add "lang"
4891 parameter.
4892 (mapped_index_base::build_name_components): Also split names
4893 according to Ada syntax.
4894 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4895 type of "match_callback".
4896 (check_match, check_find_bounds_finds)
4897 (dw2_expand_symtabs_matching): Update.
4898 (dw2_debug_names_iterator): Add new constructor.
4899 (dw2_debug_names_map_matching_symbols): New function.
4900 (dw2_debug_names_expand_symtabs_matching): Update.
4901 (dwarf2_debug_names_functions): Use
4902 dw2_debug_names_map_matching_symbols.
4903
aa391654
TT		 49042019-09-10 Tom Tromey <tromey@adacore.com>
4905
4906 * dwarf2read.c (dw2_get_file_names_reader): Add the
4907 CU's file name to the results.
4908
b054970d
TT		 49092019-09-10 Tom Tromey <tromey@adacore.com>
4910
4911 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4912 map_matching_symbols. Update.
4913 * dwarf2read.c (dw2_map_matching_symbols): Update.
4914 * psymtab.c (match_partial_symbol): Change type; update.
4915 (psym_map_matching_symbols): Likewise.
4916 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4917 type; update.
4918 * symfile.h (struct quick_symbol_functions)
4919 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4920 Remove "match".
4921
6a3dbf1b
TT		 49222019-09-10 Tom Tromey <tromey@adacore.com>
4923
4924 * psymtab.c (map_block): Remove.
4925 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4926 * symtab.c (iterate_over_symbols_terminated): New function.
4927 * symtab.c (iterate_over_symbols_terminated): Declare.
4928
6969f124
TT		 49292019-09-10 Tom Tromey <tromey@adacore.com>
4930
4931 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4932 * language.h (struct language_defn) <la_iterate_over_symbols>:
4933 Return bool.
4934 * symtab.c (iterate_over_symbols): Return bool.
4935 * symtab.h (iterate_over_symbols): Return bool.
4936
199b4314
TT		 49372019-09-10 Tom Tromey <tromey@adacore.com>
4938
4939 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4940 (add_nonlocal_symbols): Update.
4941 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4942 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4943 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4944 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4945 Change type of "callback". Remove "data".
4946
a084a2a6
AT		 4947
49482019-09-09 Ali Tamur <tamur@google.com>
4949
4950 * dwarf2read.c (comp_unit_head): Update comment.
4951 (dwarf2_dwo_name): New function declaration.
4952 (dwarf_unit_type_name): New function declaration.
4953 (read_comp_unit_head): Add support for new compilation units,
4954 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4955 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4956 (currently named as "signature") in their header. Also clarify error
4957 messages.
4958 (lookup_dwo_id): New function. Returns the dwo id of the given
4959 compile unit.
4960 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4961 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4962 functions.
4963 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4964 (dwarf2_dwo_name): Get the dwo name if present.
4965 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4966 purposes.
4967
25a2915e
TT		 49682019-09-09 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4971
e4df0874
PW		 49722019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4973
4974 * python/python.c (do_start_initialization): Make progname_copy static,
4975 to avoid a leak report.
4976
8634b462
TT		 49772019-09-08 Tom Tromey <tom@tromey.com>
4978
4979 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4980
c7f839cb
SM		 49812019-09-07 Simon Marchi <simon.marchi@efficios.com>
4982
4983 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4984 Change type to gdb::optional<block_enum>.
4985 (dw2_symtab_iter_init): Change block_index parameter type
4986 to gdb::optional<block_enum>.
4987 (dw2_lookup_symbol): Change block_index parameter
4988 type to block_enum.c
4989 (dw2_debug_names_lookup_symbol): Likewise.
4990 * psymtab.c (psym_lookup_symbol): Likewise.
4991 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4992 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4993 Likewise.
4994
ead0e69a
CB		 49952019-09-06 Christian Biesinger <cbiesinger@google.com>
4996
4997 * defs.h (relocate_gdb_directory): Change int to bool in
4998 signature and rename flag to relocatable.
4999 * main.c (relocate_path): Likewise.
5000 (relocate_gdb_directory): Likewise.
5001
b16c44de
AM		 50022019-09-06 Alan Modra <amodra@gmail.com>
5003
5004 * coffread.c (coff_symfile_read): Constify filename variable.
5005 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5006 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5007 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5008 * solib.c (reload_shared_libraries_1): Likewise.
5009 * symfile.c (reread_symbols): Likewise.
5010 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5011 * solib-darwin.c (darwin_bfd_open): Likewise.
5012 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5013
06ff036e
AB		 50142019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5015
5016 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5017 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5018
4e962e74
TT		 50192019-09-03 Tom Tromey <tromey@adacore.com>
5020
5021 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5022 types.
5023 (has_negatives): Unbias a range type bound.
5024 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5025 * gdbtypes.c (operator==): Handle new field.
5026 (create_range_type): Add "bias" parameter.
5027 (create_static_range_type, resolve_dynamic_range): Update.
5028 * gdbtypes.h (struct range_bounds) <bias>: New member.
5029 (create_range_type): Add bias parameter.
5030 * printcmd.c (print_scalar_formatted): Unbias range types.
5031 * value.c (unpack_long): Unbias range types.
5032 (pack_long): Bias range types.
5033
d90b8f26
AH		 50342019-09-02 Alan Hayward <alan.hayward@arm.com>
5035
5036 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5037 probe arguments.
5038
fe01123e
AH		 50392019-09-02 Alan Hayward <alan.hayward@arm.com>
5040
5041 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5042 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5043 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5044 (compile_probe_arg): Likewise.
5045 * probe.h (get_argument_count): Likewise.
5046 * solib-svr4.c (solib_event_probe_action): Likewise.
5047 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5048
e661ef01
AH		 50492019-09-02 Alan Hayward <alan.hayward@arm.com>
5050
5051 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5052 code to here...
5053 (svr4_create_solib_event_breakpoints): ...from here.
5054
47a536d9
SDJ		 50552019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5056
5057 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5058 suffix from warning message.
5059
d6a00eba
TT		 50602019-08-30 Tom Tromey <tom@tromey.com>
5061
5062 * tui/tui-winsource.h (struct tui_source_window_base)
5063 <refresh_all>: Don't declare.
5064 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5065 Remove.
5066 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5067 tui_show_locator_content.
5068 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5069 declare.
5070 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5071 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5072 declare.
5073
55b2657b
TT		 50742019-08-30 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5077
12a8555a
TT		 50782019-08-30 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5081 Remove unnecessary forward declarations.
5082
900ac242
TT		 50832019-08-30 Tom Tromey <tom@tromey.com>
5084
5085 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5086 rerender.
5087 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5088 tui_show_locator_content.
5089
99ab33fb
TT		 50902019-08-30 Tom Tromey <tom@tromey.com>
5091
5092 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5093 (tui_locator_window::rerender): Rewrite using body of previous
5094 tui_show_locator_content.
5095
e594a5d1
TT		 50962019-08-30 Tom Tromey <tom@tromey.com>
5097
5098 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5099 set_locator_fullname>: New methods.
5100 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5101 Rename from tui_set_locator_fullname.
5102 (tui_locator_window::set_locator_info): Rename from
5103 tui_set_locator_info. Return bool.
5104 (tui_update_locator_fullname, tui_show_frame_info): Update.
5105
715bb467
TT		 51062019-08-30 Tom Tromey <tom@tromey.com>
5107
5108 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5109
772f3f03
TT		 51102019-08-30 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5113 call touchwin.
5114
108e13ab
TT		 51152019-08-30 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-wingeneral.c (box_win): Assume win_info and
5118 win_info->handle cannot be NULL.
5119
cdaa6eb4
TT		 51202019-08-30 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5123 refresh_window>: Declare.
5124 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5125 resize.
5126 (tui_data_item_window::rerender): Rename from
5127 tui_display_register.
5128 (tui_data_item_window::refresh_window): New method.
5129 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5130 no-op.
5131
89df7f90
TT		 51322019-08-30 Tom Tromey <tom@tromey.com>
5133
5134 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5135 regs_column_count, current_group>: Move later. Now private.
5136 <get_current_group>: New method.
5137 * tui/tui-regs.c (tui_reg_command): Update.
5138 * tui/tui-layout.c (tui_set_layout): Update.
5139
1bf2866a
TT		 51402019-08-30 Tom Tromey <tom@tromey.com>
5141
5142 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5143 (tui_data_window::rerender): Don't call
5144 check_and_display_highlight_if_needed.
5145 (tui_data_window::refresh_all): Remove call to
5146 erase_data_content.
5147
0670413d
TT		 51482019-08-30 Tom Tromey <tom@tromey.com>
5149
5150 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5151 (tui_data_window::display_registers_from)
5152 (tui_data_window::display_reg_element_at_line)
5153 (tui_data_window::display_registers_from_line): Remove checks of
5154 "empty".
5155
18bb55c7
TT		 51562019-08-30 Tom Tromey <tom@tromey.com>
5157
5158 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5159 Don't declare.
5160 * tui/tui-regs.c (tui_data_window::show_registers): Call
5161 rerender.
5162 (tui_data_window::rerender): Rename from display_all_data.
5163 (tui_data_window::rerender): Remove old implementation.
5164
1f6d2f10
TT		 51652019-08-30 Tom Tromey <tom@tromey.com>
5166
5167 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5168 text.
5169 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5170
16d01f9c
BW		 51712019-08-29 Bernhard Wodok <barto@gmx.net>
5172 Sergio Durigan Junior <sergiodj@redhat.com>
5173
5174 PR win32/24284
5175 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5176
d8f27c60
AB		 51772019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5178
5179 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5180 when searching for types.
5181
1f20c35e
AB		 51822019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5183
5184 * f-lang.c (f_language_defn): Use f_print_typedef.
5185 * f-lang.h (f_print_typedef): Declare.
5186 * f-typeprint.c (f_print_typedef): Define.
5187
550105b7
CB		 51882019-08-27 Christian Biesinger <cbiesinger@google.com>
5189
5190 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5191
4acfdd20
AB		 51922019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5193
5194 * cli/cli-utils.c (info_print_options_defs): Delete.
5195 (make_info_print_options_def_group): Delete.
5196 (extract_info_print_options): Delete.
5197 (info_print_command_completer): Delete.
5198 (info_print_args_help): Add extra parameter, and optionally
5199 include text about -n flag.
5200 * cli/cli-utils.h (struct info_print_options): Delete.
5201 (extract_info_print_options): Delete declaration.
5202 (info_print_command_completer): Delete declaration.
5203 (info_print_args_help): Add extra parameter, extend header
5204 comment.
5205 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5206 search_symbols.
5207 * stack.c (struct info_print_options): New type.
5208 (info_print_options_defs): New file scoped variable.
5209 (make_info_print_options_def_group): New static function.
5210 (info_print_command_completer): New static function.
5211 (info_locals_command): Update to use new local functions.
5212 (info_args_command): Likewise.
5213 (_initialize_stack): Add extra parameter to calls to
5214 info_print_args_help.
5215 * symtab.c (search_symbols): Add extra parameter, use this to
5216 possibly excluse non-debug symbols.
5217 (symtab_symbol_info): Add extra parameter, which is passed on to
5218 search_symbols.
5219 (struct info_print_options): New type.
5220 (info_print_options_defs): New file scoped variable.
5221 (make_info_print_options_def_group): New static function.
5222 (info_print_command_completer): New static function.
5223 (info_variables_command): Update to use local functions, and pass
5224 extra parameter through to symtab_symbol_info.
5225 (info_functions_command): Likewise.
5226 (info_types_command): Pass additional argument through to
5227 symtab_symbol_info.
5228 (rbreak_command): Pass extra argument to search_symbols.
5229 (_initialize_symtab): Add extra arguments for calls to
5230 info_print_args_help, and update help text for 'info variables',
5231 'whereis', and 'info functions' commands.
5232 * symtab.h (search_symbols): Add extra argument to declaration.
5233 * NEWS: Mention new flags.
5234
9aa55206
CB		 52352019-08-26 Christian Biesinger <cbiesinger@google.com>
5236
5237 * symtab.c (lookup_static_symbol): Call the new function (and move
5238 it down to be next to lookup_global_symbol).
5239 (struct global_sym_lookup_data): Add block_enum member and rename to...
5240 (struct global_or_static_sym_lookup_data): ...this.
5241 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5242 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5243 (lookup_symbol_global_or_static_iterator_cb): ...this.
5244 (lookup_global_or_static_symbol): New function.
5245 (lookup_global_symbol): Call new function.
5246
5c31b358
TV		 52472019-08-26 Tom de Vries <tdevries@suse.de>
5248
5249 PR c++/24852
5250 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5251 when pc_probe.prob == NULL.
5252
23c13d42
SM		 52532019-08-25 Simon Marchi <simon.marchi@efficios.com>
5254
5255 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5256 variable symbol_linkage to symbol_linkage_.
5257
beadd3e8
SM		 52582019-08-25 Simon Marchi <simon.marchi@efficios.com>
5259
5260 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5261 represent whether the symbol is static, dynamic, or we don't
5262 know.
5263
e3ec872f
YS		 52642019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5265
5266 * gdb/rx-tdep.c (rx_register_names): New.
5267 (rx_register_name): Delete.
5268 (rx_psw_type): Delete.
5269 (rx_fpsw_type): Delete.
5270 (rx_register_type): Delete.
5271 (rx_gdbarch_init): Convert target-descriptions.
5272 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5273 * gdb/features/Makefile: Add rx.xml.
5274 * gdb/features/rx.xml: New.
5275 * gdb/features/rx.c: Generated.
5276 * gdb/NEWS: Mention target description support.
5277
d0509ba4
CB		 52782019-08-22 Christian Biesinger <cbiesinger@google.com>
5279
5280 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5281 *slot_ptr.
5282
2d41fa11
SDJ		 52832019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5284
5285 * configure.ac: Don't check for 'dlfcn.h' (moved to
5286 gdbsupport/common.m4).
5287 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5288 'gdbsupport/'.
5289 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5290 * compile/compile-c-support.c: Include
5291 'gdbsupport/gdb-dlfcn.h'.
5292 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5293 * gdb-dlfcn.c: Move to...
5294 * gdbsupport/gdb-dlfcn.c: ... here.
5295 * gdb-dlfcn.h: Move to...
5296 * gdbsupport/gdb-dlfcn.h: ... here.
5297
de8af808
SL		 52982019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5299
5300 * nios2-tdep.c (struct reg_value): Improve comments. Make
5301 the offset field signed.
5302
27204489
CB		 53032019-08-22 Christian Biesinger <cbiesinger@google.com>
5304
5305 * python/lib/gdb/__init__.py (_execute_file): New function.
5306 * python/python.c (python_run_simple_file): Call gdb._execute_file
5307 on Windows.
5308
43771869
AB		 53092019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5310
5311 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5312 all uses as this was never set to anything but a zero value.
5313
26c957f1
PA		 53142019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5315
5316 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5317
c07aae6e
CB		 53182019-08-21 Christian Biesinger <cbiesinger@google.com>
5319
5320 * tui/tui-data.h (tui_gen_win_info): Add an =default
5321 move constructor, required by some GCC versions.
5322
3960cb7a
JF		 53232019-08-21 Jinke Fan <fanjinke51@yeah.net>
5324
5325 * go32-nat.c (go32_sysinfo): Add hygon_p.
5326
04c72a68
TT		 53272019-08-20 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5330 line_from_reg_element_no, first_reg_element_no_inline,
5331 display_all_data, delete_data_content_windows,
5332 erase_data_content>: Now private.
5333
072272ce
TT		 53342019-08-20 Tom Tromey <tom@tromey.com>
5335
5336 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5337 (tui_unhighlight_win, tui_highlight_win)
5338 (tui_win_info::make_window): Update.
5339 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5340
973961bd
TT		 53412019-08-20 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5344 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5345 (MAX_PID_WIDTH): Move to tui-stack.c.
5346 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5347 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5348 (MAX_PID_WIDTH): Move from tui-data.h.
5349
ab0e1f1a
TT		 53502019-08-20 Tom Tromey <tom@tromey.com>
5351
5352 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5353 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5354 (box_win): Update.
5355 (tui_gen_win_info::make_window): Rename from tui_make_window.
5356 (tui_win_info::make_window): New method.
5357 (tui_gen_win_info::make_visible): Update.
5358 * tui/tui-source.c (tui_source_window::set_contents): Update.
5359 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5360 (tui_data_window::display_registers_from): Update.
5361 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5362 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5363 Declare.
5364 <can_box>: Remove.
5365 <title>: Remove.
5366 (struct tui_win_info) <make_window>: Declare.
5367 <can_box>: Now virtual.
5368 <title>: New member.
5369 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5370 * tui/tui-command.c (tui_cmd_window::resize): Update.
5371
100c2bf3
TT		 53722019-08-20 Tom Tromey <tom@tromey.com>
5373
5374 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5375 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5376 (tui_data_window::check_register_values): Update.
5377
fa4dc567
TT		 53782019-08-20 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-regs.h (struct tui_data_window): Use
5381 DISABLE_COPY_AND_ASSIGN.
5382 <regs_content>: Change type, removing unique_ptr.
5383 <tui_data_window>: Add move constructor.
5384 * tui/tui-regs.c (tui_data_window::show_registers)
5385 (tui_data_window::show_register_group)
5386 (tui_data_window::display_registers_from)
5387 (tui_data_window::display_registers_from)
5388 (tui_data_window::first_data_item_displayed)
5389 (tui_data_window::delete_data_content_windows)
5390 (tui_data_window::rerender, tui_data_window::refresh_window)
5391 (tui_data_window::check_register_values): Update.
5392
ca02d7c8
TT		 53932019-08-20 Tom Tromey <tom@tromey.com>
5394
5395 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5396 show_register_group>: Declare.
5397 (tui_show_register_group): Don't declare.
5398 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5399 tui_show_registers.
5400 (tui_data_window::show_register_group): Rename from
5401 tui_show_register_group.
5402 (tui_data_window::check_register_values, tui_reg_command):
5403 Update.
5404 * tui/tui-layout.c (tui_set_layout): Update.
5405
63356bfd
TT		 54062019-08-20 Tom Tromey <tom@tromey.com>
5407
5408 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5409 Declare.
5410 (tui_check_register_values): Don't declare.
5411 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5412 from tui_check_register_values.
5413 * tui/tui-hooks.c (tui_register_changed): Update.
5414
42cc14a7
TT		 54152019-08-20 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-regs.c (tui_reg_layout): Move later.
5418 (tui_show_registers): Don't enable TUI mode or change layout.
5419
b9ad3686
TT		 54202019-08-20 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-regs.h (struct tui_data_item_window)
5423 <~tui_data_item_window>: Remove.
5424 <content>: Now a unique_xmalloc_ptr.
5425 * tui/tui-regs.c (tui_register_format): Return a
5426 unique_xmalloc_ptr.
5427 (tui_get_register): Update.
5428 (~tui_data_item_window): Remove.
5429 (tui_data_window::display_registers_from, tui_display_register):
5430 Update.
5431 * tui/tui-io.h (tui_expand_tabs): Update.
5432 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5433 Remove "col" parameter.
5434
8e114aab
TT		 54352019-08-20 Tom Tromey <tom@tromey.com>
5436
5437 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5438 field.
5439 * tui/tui-regs.c (~tui_data_item_window): Update.
5440
1a4f81dd
TT		 54412019-08-20 Tom Tromey <tom@tromey.com>
5442
5443 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5444 earlier.
5445
0f8d8876
TT		 54462019-08-20 Tom Tromey <tom@tromey.com>
5447
5448 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5449
605dc2c2
TT		 54502019-08-20 Tom Tromey <tom@tromey.com>
5451
5452 * tui/tui-source.h (struct tui_source_window): Update.
5453 * tui/tui-regs.c (tui_show_registers): Update.
5454 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5455 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5456 (NO_REGS_STRING): Remove defines.
5457
aedbe3bb
CM		 54582019-08-20 Conrad Meyer <cem@FreeBSD.org>
5459
5460 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5461 unnecessary thread walk if remote doesn't support the packet.
5462
7ce8f214
TT		 54632019-08-19 Tom Tromey <tromey@adacore.com>
5464
5465 * python/py-value.c (value_has_field): Fix indentation.
5466
f21c2bd7
TT		 54672019-08-19 Tom Tromey <tromey@adacore.com>
5468
5469 * printcmd.c (do_one_display, info_display_command): Update.
5470 * block.h (contained_in): Return bool. Add allow_nested
5471 parameter.
5472 * block.c (contained_in): Return bool. Add allow_nested
5473 parameter.
5474
d806ea2d
TT		 54752019-08-19 Tom Tromey <tom@tromey.com>
5476
5477 * configure: Rebuild.
5478 * configure.ac: Disallow the combination of -static-libstdc++ and
5479 source highlight.
5480 * source-cache.c (get_language_name): Handle rust.
5481 (source_cache::get_source_lines): Ignore highlighting exceptions.
5482
398fdd60
TT		 54832019-08-16 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5486 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5487 (struct tui_source_window_base) <make_visible, refresh_window,
5488 resize>: Remove methods.
5489 <execution_info>: Remove field.
5490 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5491 (tui_show_source_line, tui_source_window_base)
5492 (~tui_source_window_base): Update.
5493 (tui_source_window_base::resize)
5494 (tui_source_window_base::make_visible)
5495 (tui_source_window_base::refresh_window): Remove.
5496 (tui_source_window_base::update_exec_info): Update.
5497 * tui/tui-source.c (tui_source_window::set_contents): Update.
5498 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5499
e699d331
TT		 55002019-08-16 Tom Tromey <tom@tromey.com>
5501
5502 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5503 deprecated_query_hook.
5504
bb01dbfc
TT		 55052019-08-16 Tom Tromey <tom@tromey.com>
5506
5507 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5508 (tui_update_source_windows_with_line): Update.
5509 * tui/tui-source.h (struct tui_source_window)
5510 <show_symtab_source>: Declare.
5511 (tui_show_symtab_source): Don't declare.
5512 * tui/tui-source.c (tui_show_symtab_source): Rename from
5513 tui_show_symtab_source.
5514
81c82c4b
TT		 55152019-08-16 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-winsource.h (struct tui_source_window_base)
5518 <set_contents>: Declare.
5519 * tui/tui-winsource.c
5520 (tui_source_window_base::update_source_window_as_is): Update.
5521 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5522 Declare.
5523 (tui_set_source_content): Don't declare.
5524 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5525 tui_set_source_content.
5526 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5527 Declare.
5528 (tui_set_disassem_content): Don't declare.
5529 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5530 tui_set_disassem_content.
5531
2ddaf614
TT		 55322019-08-16 Tom Tromey <tom@tromey.com>
5533
5534 * tui/tui-winsource.h (struct tui_source_window_base)
5535 <update_breakpoint_info>: Declare.
5536 (tui_update_breakpoint_info): Don't declare.
5537 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5538 (tui_update_all_breakpoint_info): Update.
5539 (tui_source_window_base::update_breakpoint_info): Rename from
5540 tui_update_breakpoint_info.
5541 (tui_source_window_base::update_exec_info): Update.
5542
017f9828
TT		 55432019-08-16 Tom Tromey <tom@tromey.com>
5544
5545 * tui/tui-winsource.h (struct tui_source_window_base)
5546 <update_source_window>: Declare.
5547 (tui_update_source_window): Don't declare.
5548 * tui/tui-winsource.c
5549 (tui_source_window_base::update_source_window): Rename from
5550 tui_update_source_window.
5551 (tui_source_window_base::rerender): Update.
5552 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5553 * tui/tui-disasm.c (tui_show_disassem)
5554 (tui_show_disassem_and_update_source)
5555 (tui_disasm_window::maybe_update): Update.
5556
ed8358e9
TT		 55572019-08-16 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-winsource.h (struct tui_source_window_base)
5560 <update_source_window_as_is>: Declare.
5561 (tui_update_source_window_as_is): Don't declare.
5562 * tui/tui-winsource.c (tui_update_source_window): Update
5563 (tui_source_window_base::update_source_window_as_is): Rename from
5564 tui_update_source_window_as_is.
5565 (tui_source_window_base::refill): Update.
5566 * tui/tui-source.c (tui_show_symtab_source): Update.
5567 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5568 Update.
5569
20149b6b
TT		 55702019-08-16 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-winsource.h (tui_update_source_window)
5573 (tui_update_source_window_as_is): Remove "noerror" parameter.
5574 * tui/tui-winsource.c (tui_update_source_window)
5575 (tui_update_source_window_as_is): Remove "noerror" parameter.
5576 (tui_update_source_windows_with_addr)
5577 (tui_update_source_windows_with_line)
5578 (tui_source_window_base::rerender)
5579 (tui_source_window_base::refill): Update.
5580 * tui/tui-source.h (tui_set_source_content)
5581 (tui_show_symtab_source): Remove "noerror" parameter.
5582 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5583 parameter.
5584 (tui_show_symtab_source): Likewise.
5585 (tui_source_window::maybe_update): Update.
5586 * tui/tui-disasm.c (tui_show_disassem)
5587 (tui_show_disassem_and_update_source)
5588 (tui_disasm_window::do_scroll_vertical)
5589 (tui_disasm_window::maybe_update): Update.
5590
2d83e710
TT		 55912019-08-16 Tom Tromey <tom@tromey.com>
5592
5593 * tui/tui.c (tui_is_window_visible): Update.
5594 * tui/tui-wingeneral.c (tui_make_window)
5595 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5596 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5597 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5598 (tui_set_win_height_command, parse_scrolling_args): Update.
5599 * tui/tui-source.c (tui_source_window::style_changed): Update.
5600 * tui/tui-regs.c (tui_show_registers)
5601 (tui_data_window::first_data_item_displayed)
5602 (tui_data_window::delete_data_content_windows)
5603 (tui_check_register_values, tui_reg_command): Update.
5604 * tui/tui-disasm.c (tui_show_disassem): Update.
5605 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5606 method.
5607 <is_visible>: Remove field.
5608 * tui/tui-data.c (tui_next_win, tui_prev_win)
5609 (tui_delete_invisible_windows): Update.
5610
d4ab829a
TT		 56112019-08-16 Tom Tromey <tom@tromey.com>
5612
5613 * tui/tui-winsource.h (struct tui_source_window_base)
5614 <m_has_locator>: Remove.
5615 * tui/tui-layout.c (show_source_disasm_command, show_data)
5616 (show_source_or_disasm_and_command): Update.
5617
aa7ca1bb
AH		 56182019-08-16 Alan Hayward <alan.hayward@arm.com>
5619
5620 * NEWS (Other MI changes): New subsection.
5621 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5622 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5623 * arch-utils.c (default_get_pc_address_flags): New function.
5624 * arch-utils.h (default_get_pc_address_flags): New declaration.
5625 * gdbarch.sh: Add get_pc_address_flags.
5626 * gdbarch.c: Regenerate.
5627 * gdbarch.h: Likewise.
5628 * stack.c (print_pc): New function.
5629 (print_frame_info) (print_frame): Call print_pc.
5630
6eac171f
TV		 56312019-08-16 Tom de Vries <tdevries@suse.de>
5632
5633 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5634 print_objfile_section_info.
5635
3df505f6
TT		 56362019-08-15 Tom Tromey <tom@tromey.com>
5637
5638 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5639 calling update_cmdwin_start_line.
5640 * tui/tui-winsource.h (struct tui_source_window_base)
5641 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5642 <rerender>: Declare.
5643 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5644 Call rerender.
5645 (tui_source_window_base::set_new_height): Remove.
5646 (tui_source_window_base::rerender): Rename from
5647 do_make_visible_with_new_height.
5648 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5649 resize method.
5650 (tui_win_info::make_invisible_and_set_new_height)
5651 (tui_win_info::make_visible_with_new_height): Remove.
5652 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5653 Declare.
5654 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5655 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5656 do_make_visible_with_new_height>: Don't declare.
5657 <rerender>: Declare.
5658 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5659 set_new_height.
5660 (tui_data_window::do_make_visible_with_new_height): Remove.
5661 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5662 call tui_show_locator_content.
5663 (tui_gen_win_info::resize): Call rerender.
5664 (show_source_or_disasm_and_command): Don't call
5665 tui_show_locator_content.
5666 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5667 method.
5668 (struct tui_win_info) <rerender>: Declare.
5669 <set_new_height, make_invisible_and_set_new_height,
5670 make_visible_with_new_height>: Don't declare.
5671 * tui/tui-data.c (tui_win_list::rerender): New method.
5672 * tui/tui-command.h (struct tui_cmd_window)
5673 <do_make_visible_with_new_height>: Don't declare.
5674 * tui/tui-command.c
5675 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5676
272560b5
TT		 56772019-08-15 Tom Tromey <tromey@adacore.com>
5678
5679 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5680 * ada-lang.c (ada_enum_name): Likewise.
5681
08235187
CB		 56822019-08-15 Christian Biesinger <cbiesinger@google.com>
5683
5684 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5685 leading underscore.
5686 (GdbOutputErrorFile): Likewise.
5687 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5688 accordingly.
5689 (execute_unwinders): Rename to have a leading underscore.
5690 (auto_load_packages): Likewise.
5691 (global scope): Adjust call to auto_load_packages accordingly.
5692 (GdbSetPythonDirectory): Likewise.
5693 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5694 instead of execute_unwinders.
5695
db502012
TT		 56962019-08-15 Tom Tromey <tom@tromey.com>
5697
5698 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5699 (show_data): Don't change window visibility.
5700 (tui_gen_win_info::resize): Remove special case for command
5701 window. Use wresize, when available.
5702 (show_source_or_disasm_and_command): Don't change window
5703 visibility.
5704 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5705 <make_visible>: New method.
5706 * tui/tui-command.c (tui_cmd_window::resize): New method.
5707
3891b65e
TT		 57082019-08-15 Tom Tromey <tom@tromey.com>
5709
5710 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5711 (struct tui_source_windows): New.
5712 * tui/tui-winsource.c (tui_display_main): Update.
5713 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5714 (new_height_ok, parse_scrolling_args): Update.
5715 * tui/tui-layout.c (show_layout, show_data): Update.
5716 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5717 (tui_add_to_source_windows): Don't declare.
5718 * tui/tui-data.c (source_windows, tui_source_windows)
5719 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5720
ee556432
TT		 57212019-08-15 Tom Tromey <tom@tromey.com>
5722
5723 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5724 Rename from reset.
5725 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5726 * tui/tui-layout.c (show_source_disasm_command, show_data):
5727 Update.
5728 (tui_gen_win_info::resize): Rename.
5729 (show_source_or_disasm_and_command): Update.
5730 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5731 reset.
5732
46f438e3
TT		 57332019-08-15 Tom Tromey <tom@tromey.com>
5734
5735 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5736 * tui/tui-interp.c (tui_interp::init): Don't call
5737 tui_initialize_static_data.
5738 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5739
f4ce562c
TT		 57402019-08-15 Tom Tromey <tom@tromey.com>
5741
5742 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5743 examine tui_win_list.
5744
c398c3d0
TT		 57452019-08-15 Tom Tromey <tom@tromey.com>
5746
5747 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5748 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5749 tui_clear_source_content.
5750 (tui_clear_source_content): Remove.
5751 (tui_source_window_base::do_erase_source_content): Hoist call to
5752 content.clear().
5753 * tui/tui-stack.c (tui_show_frame_info): Don't call
5754 tui_clear_source_content.
5755
e25d2004
TT		 57562019-08-15 Tom Tromey <tom@tromey.com>
5757
5758 * tui/tui-winsource.h (struct tui_source_window_base)
5759 <do_erase_source_content>: New method.
5760 <erase_source_content>: New method.
5761 (tui_erase_source_content): Don't declare.
5762 * tui/tui-winsource.c (tui_clear_source_content): Update.
5763 (tui_source_window_base::do_erase_source_content): Rename from
5764 tui_erase_source_content.
5765 (tui_source_window_base::show_source_content): Update.
5766 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5767 * tui/tui-source.h (struct tui_source_window)
5768 <erase_source_content>: New method.
5769 * tui/tui-disasm.h (struct tui_disasm_window)
5770 <erase_source_content>: New method.
5771
002f15c2
TT		 57722019-08-15 Tom Tromey <tom@tromey.com>
5773
5774 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5775 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5776 constructor.
5777 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5778 * tui/tui-source.c (tui_set_source_content): Update.
5779 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5780
c9033fe8
TT		 57812019-08-15 Tom Tromey <tom@tromey.com>
5782
5783 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5784 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5785 tui-source.c.
5786 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5787 Declare.
5788 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5789 method.
5790 (tui_source_window::maybe_update): Update.
5791
088f37dd
TT		 57922019-08-15 Tom Tromey <tom@tromey.com>
5793
5794 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5795 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5796 tui-disasm.c.
5797 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5798 Declare.
5799 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5800 method.
5801 (tui_disasm_window::maybe_update): Update.
5802
a54700c6
TT		 58032019-08-15 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui-winsource.h (struct tui_source_window_base)
5806 <maybe_update>: Declare.
5807 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5808 method.
5809 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5810 Declare.
5811 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5812 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5813 Declare.
5814 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5815
e2a678a5
TT		 58162019-08-15 Tom Tromey <tom@tromey.com>
5817
5818 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5819
f2dda477
TT		 58202019-08-15 Tom Tromey <tom@tromey.com>
5821
5822 * tui/tui-wingeneral.c: Include tui-stack.h.
5823 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5824 (struct tui_locator_window): Move from tui-data.h.
5825 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5826 (tui_initialize_static_data): Move from tui-data.c.
5827 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5828 (struct tui_locator_window): Move to tui-stack.c.
5829 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5830 (tui_initialize_static_data): Move to tui-stack.c.
5831
ed4a1084
TT		 58322019-08-15 Tom Tromey <tom@tromey.com>
5833
5834 * tui/tui-layout.c (show_source_disasm_command)
5835 (show_source_or_disasm_and_command): Use make_visible method, not
5836 tui_make_window.
5837 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5838 Remove.
5839
65962b20
TT		 58402019-08-15 Tom Tromey <tom@tromey.com>
5841
5842 * tui/tui-wingeneral.h (tui_make_window): Update.
5843 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5844 parameter.
5845 (tui_gen_win_info::make_visible): Update.
5846 * tui/tui-regs.c (tui_data_window::display_registers_from):
5847 Update.
5848 * tui/tui-layout.c (show_source_disasm_command)
5849 (show_source_or_disasm_and_command): Update.
5850 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5851 (enum tui_box): Remove.
5852 (struct tui_win_info) <can_box>: New method.
5853 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5854 method.
5855
2208ee91
TV		 58562019-08-15 Tom de Vries <tdevries@suse.de>
5857
5858 * linux-nat-trad.c: Include gdbarch.h.
5859
75faf5c4
AH		 58602019-08-14 Alan Hayward <alan.hayward@arm.com>
5861
5862 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5863 register sizes.
5864
b1c896b3
TT		 58652019-08-14 Tom Tromey <tromey@adacore.com>
5866
5867 * darwin-nat.c: Include gdbarch.h.
5868 * darwin-nat-info.c: Include gdbarch.h.
5869
6405cd73
TT		 58702019-08-13 Tom Tromey <tom@tromey.com>
5871
5872 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5873 Remove.
5874 * tui/tui-data.c (tui_initialize_static_data): Update.
5875
5216580d
TT		 58762019-08-13 Tom Tromey <tom@tromey.com>
5877
5878 * tui/tui-winsource.h (struct tui_exec_info_window)
5879 <~tui_exec_info_window, maybe_allocate_content, get_content,
5880 m_content>: Remove.
5881 (struct tui_source_window_base) <set_exec_info_content,
5882 show_exec_info_content>: Don't declare.
5883 * tui/tui-winsource.c
5884 (tui_exec_info_window::maybe_allocate_content): Remove.
5885 (tui_source_window_base::update_exec_info): Rename from
5886 set_exec_info_content.
5887 (tui_source_window_base::show_exec_info_content)
5888 (tui_source_window_base::update_exec_info): Remove.
5889
93858ad3
TT		 58902019-08-13 Tom Tromey <tom@tromey.com>
5891
5892 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5893 declare.
5894 * tui/tui-winsource.c (tui_update_source_window_as_is)
5895 (tui_update_source_windows_with_addr, tui_erase_source_content):
5896 Update.
5897 (tui_clear_exec_info_content): Remove.
5898
e321e7ce
TT		 58992019-08-13 Tom Tromey <tom@tromey.com>
5900
5901 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5902 declare.
5903 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5904 call tui_erase_exec_info_content.
5905 (tui_clear_exec_info_content): Rename from
5906 tui_erase_exec_info_content.
5907 (tui_clear_exec_info_content): Delete.
5908
8270ac62
TT		 59092019-08-13 Tom Tromey <tom@tromey.com>
5910
5911 * tui/tui-winsource.h (struct tui_source_window_base)
5912 <show_exec_info_content>: Declare.
5913 (tui_show_exec_info_content): Don't declare.
5914 * tui/tui-winsource.c
5915 (tui_source_window_base::show_exec_info_content): Rename from
5916 tui_show_exec_info_content.
5917 (tui_source_window_base::update_exec_info): Update.
5918
7b56485d
TT		 59192019-08-13 Tom Tromey <tom@tromey.com>
5920
5921 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5922 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5923 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5924 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5925 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5926 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5927 ... here.
5928
7ba913dc
TT		 59292019-08-13 Tom Tromey <tom@tromey.com>
5930
5931 * tui/tui-winsource.h (struct tui_source_window_base)
5932 <update_exec_info>: Declare.
5933 (tui_update_exec_info): Don't declare.
5934 * tui/tui-winsource.c (tui_update_source_window_as_is)
5935 (tui_source_window_base::refresh_all)
5936 (tui_update_all_breakpoint_info): Update.
5937 (tui_source_window_base::update_exec_info): Rename from
5938 tui_update_exec_info.
5939 * tui/tui-stack.c (tui_show_frame_info): Update.
5940
37a4a131
TT		 59412019-08-13 Tom Tromey <tom@tromey.com>
5942
5943 * tui/tui-winsource.h (struct tui_source_window_base)
5944 <set_exec_info_content>: Declare.
5945 (tui_set_exec_info_content): Don't declare.
5946 * tui/tui-winsource.c
5947 (tui_source_window_base::set_exec_info_content): Rename from
5948 tui_set_exec_info_content.
5949 (tui_update_exec_info): Update.
5950
0bd27e07
TT		 59512019-08-13 Tom Tromey <tom@tromey.com>
5952
5953 * tui/tui-winsource.h (struct tui_source_window_base)
5954 <show_source_content>: Declare.
5955 (tui_show_source_content): Don't declare.
5956 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5957 (tui_source_window_base::show_source_content): Rename from
5958 tui_show_source_content.
5959 (tui_source_window_base::refresh_all): Update.
5960 * tui/tui-layout.c (show_source_disasm_command)
5961 (show_source_or_disasm_and_command): Update.
5962
b4ef5aeb
TT		 59632019-08-13 Tom Tromey <tom@tromey.com>
5964
5965 * tui/tui-winsource.c (tui_erase_source_content)
5966 (tui_show_source_content, tui_source_window_base::refresh_all):
5967 Update.
5968 * tui/tui-wingeneral.h
5969 (tui_check_and_display_highlight_if_needed): Don't declare.
5970 * tui/tui-wingeneral.c
5971 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5972 check_and_display_highlight_if_needed.
5973 * tui/tui-win.c (tui_rehighlight_all)
5974 (tui_win_info::make_visible_with_new_height): Update.
5975 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5976 (tui_data_window::erase_data_content)
5977 (tui_data_window::display_all_data): Update.
5978 * tui/tui-data.h (struct tui_win_info)
5979 <check_and_display_highlight_if_needed>: Declare.
5980
fede5273
TT		 59812019-08-13 Tom Tromey <tom@tromey.com>
5982
5983 * tui/tui-win.c (tui_resize_all): Call
5984 tui_delete_invisible_windows.
5985 * tui/tui-layout.c (show_layout): Call
5986 tui_delete_invisible_windows.
5987 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5988 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5989
22c3f490
TT		 59902019-08-13 Tom Tromey <tom@tromey.com>
5991
5992 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5993 tui_add_win_to_layout.
5994
16cb7910
TT		 59952019-08-13 Tom Tromey <tom@tromey.com>
5996
5997 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5998 * tui/tui-layout.c (tui_default_win_height): Now static.
5999
cc0c3ffb
TT		 60002019-08-13 Tom Tromey <tom@tromey.com>
6001
6002 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6003 single switch.
6004 (show_source_disasm_command, show_source_or_disasm_and_command):
6005 Don't check current layout.
6006
3f3ffe54
TT		 60072019-08-13 Tom Tromey <tom@tromey.com>
6008
6009 * tui/tui-wingeneral.c (make_all_visible): Remove.
6010 (tui_make_all_invisible): Simplify.
6011 * tui/tui-layout.c (tui_make_all_invisible): Move from
6012 tui-wingeneral.c; simplify.
6013 (show_layout): Hoist call to tui_make_all_invisible.
6014 (show_data): Don't call tui_make_all_invisible.
6015
69258091
TT		 60162019-08-13 Tom Tromey <tom@tromey.com>
6017
6018 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6019 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6020
62cf57fe
TT		 60212019-08-13 Tom Tromey <tom@tromey.com>
6022
6023 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6024 tui-data.c.
6025 (show_source_disasm_command, show_data)
6026 (show_source_or_disasm_and_command): Don't use
6027 tui_set_current_layout_to.
6028 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6029 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6030 tui-layout.c.
6031 (tui_set_current_layout_to): Remove.
6032
2afade5d
TT		 60332019-08-13 Tom Tromey <tom@tromey.com>
6034
6035 * tui/tui-layout.c (tui_set_layout): Update.
6036 * tui/tui-data.h (struct tui_layout_def): Remove.
6037 (tui_layout_def): Don't declare.
6038 * tui/tui-data.c (layout_def): Remove.
6039 (tui_layout_def): Remove.
6040
a3504e96
TT		 60412019-08-13 Tom Tromey <tom@tromey.com>
6042
6043 * tui/tui-winsource.h (struct tui_source_window_base)
6044 <clear_detail>: No longer "override".
6045 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6046 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6047 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6048 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6049 Remove.
6050 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6051
29c92911
TT		 60522019-08-13 Tom Tromey <tromey@adacore.com>
6053
6054 * tracepoint.c: Don't include readline.h or history.h.
6055
86c6b807
TT		 60562019-08-12 Tom Tromey <tom@tromey.com>
6057
6058 * configure: Rebuild.
6059 * configure.ac: Check for readline 7.
6060 * NEWS: Mention readline 7 requirement.
6061 * README: Update.
6062
5db2718c
TT		 60632019-08-12 Tom Tromey <tom@tromey.com>
6064
6065 * mingw-hdep.c (gdb_select): Remove readline hack.
6066
dac36daf
PFC		 60672019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6068
6069 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6070 when the function fails.
6071
1022c627
AA		 60722019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6073
6074 * s390-tdep.c (s390_type_align): New function.
6075 (s390_gdbarch_init): Set it as type_align gdbarch method.
6076
eba4caf2
TV		 60772019-08-09 Tom de Vries <tdevries@suse.de>
6078
6079 PR gdb/24591
6080 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6081 pc_low with relocation offset.
6082
123cd851
TT		 60832019-08-07 Tom Tromey <tromey@adacore.com>
6084
6085 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6086 (print_frame_args): Update.
6087 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6088 Update.
6089 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6090 * frame.h (struct frame_arg): Add initializers.
6091 <error>: Now a unique_xmalloc_ptr.
6092
3d31bc39
AH		 60932019-08-07 Alan Hayward <alan.hayward@arm.com>
6094
6095 * NEWS: Expand the Pointer Authentication entry.
6096 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6097 (aarch64_frame_unmask_lr): ... to this.
6098 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6099 Call aarch64_frame_unmask_lr.
6100 * frame.c (struct frame_info): Add "masked" variable.
6101 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6102 (fprint_frame): Check for masked pc.
6103 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6104 declarations.
6105 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6106 * stack.c (print_frame): Check for masked pc.
6107
0cf9feb9
TT		 61082019-08-06 Tom Tromey <tom@tromey.com>
6109
6110 * stabsread.c (patch_block_stabs, read_one_struct_field)
6111 (read_enum_type): Use obstack_strndup.
6112 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6113 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6114 * dwarf2read.c (guess_full_die_structure_name)
6115 (anonymous_struct_prefix): Use obstack_strndup.
6116 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6117 * c-exp.y (yylex): Use obstack_strndup.
6118 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6119 (write_var_or_type): Use obstack_strndup.
6120
efba19b0
TT		 61212019-08-06 Tom Tromey <tom@tromey.com>
6122
6123 * symfile.c (reread_symbols): Use obstack_strdup.
6124 * stabsread.c (read_type): Use obstack_strdup.
6125 * gdb_obstack.h (obstack_strdup): New overload.
6126 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6127 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6128 (dwarf2_canonicalize_name): Use obstack_strdup.
6129 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6130 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6131 Use obstack_strdup.
6132
f25102f7
TT		 61332019-08-06 Tom Tromey <tom@tromey.com>
6134
6135 * gdb_obstack.h (obstack_strdup): Define.
6136 * gdb_obstack.c (obstack_strdup): Don't define.
6137
021887d8
TT		 61382019-08-06 Tom Tromey <tom@tromey.com>
6139
6140 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6141 obstack_strdup.
6142 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6143 obstack_strdup.
6144 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6145 * stabsread.c (common_block_start): Use obstack_strdup.
6146 * objfiles.c (set_objfile_main_name, objfile): Use
6147 obstack_strdup.
6148 * namespace.c (add_using_directive): Use obstack_strdup.
6149 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6150 * jit.c (finalize_symtab): Use obstack_strdup.
6151 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6152 (guess_partial_die_structure_name, partial_die_info::fixup)
6153 (dwarf2_name): Use obstack_strdup.
6154 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6155 obstack_strdup.
6156 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6157 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6158 obstack_strdup.
6159 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6160
d2834edc
PW		 61612019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6162
6163 * unittests/help-doc-selftests.c: New file.
6164 * Makefile.in: Add the new file.
6165
590042fc
PW		 61662019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6167
6168 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6169 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6170 the full first line, except when FOR_VALUE_PREFIX. In this case,
6171 the trailing '.' is not output, and the first character is uppercased.
6172 (print_help_for_command): Update call to print_doc_line.
6173 (print_doc_of_command): Likewise.
6174 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6175 * cli/cli-option.c (append_indented_doc): Do not append newline.
6176 (build_help_option): Append newline after first appended_indented_doc
6177 only if a second call is done.
6178 (build_help): Append 2 new lines before each option, except the first
6179 one.
6180 * compile/compile.c (_initialize_compile): Add new lines after
6181 %OPTIONS%, when not at the end of the help.
6182 Change help doc or code
6183 producing the help doc to respect the invariants.
6184 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6185 Also removed the new line after 'Options:', as all other commands
6186 do not put an empty line between 'Options:' and the first option.
6187 * printcmd.c (_initialize_printcmd): Likewise.
6188 * stack.c (_initialize_stack): Likewise.
6189 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6190 incorrectly telling COMMAND is optional.
6191 * ada-lang.c (_initialize_ada_language): Change help doc or code
6192 producing the help doc to respect the invariants.
6193 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6194 * breakpoint.c (_initialize_breakpoint): Likewise.
6195 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6196 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6197 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6198 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6199 _initialize_cli_style): Likewise.
6200 * corelow.c (core_target_info): Likewise.
6201 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6202 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6203 * filesystem.c (_initialize_filesystem): Likewise.
6204 * frame.c (_initialize_frame): Likewise.
6205 * gnu-nat.c (add_task_commands): Likewise.
6206 * infcall.c (_initialize_infcall): Likewise.
6207 * infcmd.c (_initialize_infcmd): Likewise.
6208 * interps.c (_initialize_interpreter): Likewise.
6209 * language.c (_initialize_language): Likewise.
6210 * linux-fork.c (_initialize_linux_fork): Likewise.
6211 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6212 * maint.c (_initialize_maint_cmds): Likewise.
6213 * memattr.c (_initialize_mem): Likewise.
6214 * printcmd.c (_initialize_printcmd): Likewise.
6215 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6216 _RegEx): Likewise.
6217 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6218 * record-btrace.c (_initialize_record_btrace): Likewise.
6219 * record-full.c (_initialize_record_full): Likewise.
6220 * record.c (_initialize_record): Likewise.
6221 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6222 * regcache.c (_initialize_regcache): Likewise.
6223 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6224 _initialize_remote): Likewise.
6225 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6226 * serial.c (_initialize_serial): Likewise.
6227 * skip.c (_initialize_step_skip): Likewise.
6228 * source.c (_initialize_source): Likewise.
6229 * stack.c (_initialize_stack): Likewise.
6230 * symfile.c (_initialize_symfile): Likewise.
6231 * symtab.c (_initialize_symtab): Likewise.
6232 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6233 * top.c (init_main): Likewise.
6234 * tracefile-tfile.c (tfile_target_info): Likewise.
6235 * tracepoint.c (_initialize_tracepoint): Likewise.
6236 * tui/tui-win.c (_initialize_tui_win): Likewise.
6237 * utils.c (add_internal_problem_command): Likewise.
6238 * valprint.c (value_print_option_defs): Likewise.
6239
404f2902
FCE		 62402019-08-06 Frank Ch. Eigler <fche@redhat.com>
6241
6242 PR build/24886
6243 * configure.ac: Drop enable-libmcheck support.
6244 * configure, config.in: Rebuild.
6245 * libmcheck.m4: Remove.
6246 * acinclude.m4: Don't include it.
6247 * Makefile.in: Don't distribute it.
6248 * top.c (print_gdb_configuration): Don't mention it.
6249
046bebe1
TT		 62502019-08-06 Tom Tromey <tom@tromey.com>
6251
6252 * utils.c (set_output_style): Sometimes pass stream to
6253 emit_style_escape.
6254 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6255 * record-btrace.c (btrace_insn_history): Update.
6256 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6257 method.
6258 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6259 Update initializers.
6260 <m_uiout>: New field.
6261 <m_di>: Move lower.
6262 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6263 Remove "uiout" parameter.
6264 (dump_insns): Update.
6265 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6266 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6267
ddbcedf5
CB		 62682019-08-06 Christian Biesinger <cbiesinger@google.com>
6269
6270 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6271 (error_in_psymtab_expansion): Likewise.
6272 (lookup_symbol_via_quick_fns): Likewise.
6273 (basic_lookup_transparent_type_quick): Likewise.
6274 (basic_lookup_transparent_type_1): Likewise.
6275
b08b16c8
TT		 62762019-08-06 Tom Tromey <tromey@adacore.com>
6277
6278 * source.c (last_source_error): Now bool.
6279 (print_source_lines_base): Make "noprint" bool. Only open
6280 source file when last_source_visited changes.
6281
cb44333d
TT		 62822019-08-06 Tom Tromey <tromey@adacore.com>
6283
6284 * annotate.c (annotate_source_line): Use g_source_cache.
6285 * source-cache.c (source_cache::get_plain_source_lines): Change
6286 parameters. Populate m_offset_cache.
6287 (source_cache::ensure): New method.
6288 (source_cache::get_line_charpos): New method.
6289 (extract_lines): Move lower. Change parameters.
6290 (source_cache::get_source_lines): Move lower.
6291 * source-cache.h (class source_cache): Update comment.
6292 <get_line_charpos>: New method.
6293 <get_source_lines>: Update comment.
6294 <clear>: Clear m_offset_cache.
6295 <get_plain_source_lines>: Change parameters.
6296 <ensure>: New method
6297 <m_offset_cache>: New member.
6298 * source.c (forget_cached_source_info_for_objfile): Update.
6299 (info_source_command): Use g_source_cache.
6300 (find_source_lines, open_source_file_with_line_charpos): Remove.
6301 (print_source_lines_base, search_command_helper): Use g_source_cache.
6302 * source.h (open_source_file_with_line_charpos): Don't declare.
6303 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6304 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6305 Use g_source_cache.
6306
872dceaa
TT		 63072019-08-06 Tom Tromey <tromey@adacore.com>
6308
6309 * source-cache.c (source_cache::get_plain_source_lines):
6310 Remove "first_line" and "last_line" parameters.
6311 (source_cache::get_source_lines): Cache plain text.
6312 * source-cache.h (class source_cache)
6313 <get_plain_source_lines>: Update.
6314
269249d9
TT		 63152019-08-06 Tom Tromey <tromey@adacore.com>
6316
6317 * source-cache.c (extract_lines): No longer a method.
6318 Changed type of parameter. Include final newline.
6319 (selftests::extract_lines_test): New function.
6320 (_initialize_source_cache): Likewise.
6321 * source-cache.h (class source_cache)
6322 <extract_lines>: Don't declare.
6323
c0e8dcd8
TT		 63242019-08-06 Tom Tromey <tromey@adacore.com>
6325
6326 * breakpoint.c (init_breakpoint_sal): Update.
6327 (breakpoint): Update.
6328 * breakpoint.h (struct breakpoint) <filter>: Now a
6329 unique_xmalloc_ptr.
6330
0b27c27d
CB		 63312019-08-05 Christian Biesinger <cbiesinger@google.com>
6332
6333 * NEWS: Mention dictionary access on blocks.
6334 * python/py-block.c (blpy_getitem): New function.
6335 (block_object_as_mapping): New struct.
6336 (block_object_type): Use new struct for tp_as_mapping field.
6337
4ee94178
CB		 63382019-08-05 Christian Biesinger <cbiesinger@google.com>
6339
6340 * objfiles.h (objfile): Add a comment describing partial symbols.
6341
8abfcabc
TT		 63422019-08-05 Tom Tromey <tromey@adacore.com>
6343
6344 * compile/compile.c (_initialize_compile): Use _(), not N_().
6345 * thread.c (_initialize_thread): Use _(), not N_().
6346 * stack.c (_initialize_stack): Use _(), not N_().
6347 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6348
2b79f376
SM		 63492019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6350
6351 * dwarf2read.c (struct dw2_symtab_iterator):
6352 <want_specific_block>: Remove.
6353 <block_index>: Change type to gdb::optional.
6354 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6355 change type of BLOCK_INDEX parameter to gdb::optional.
6356 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6357 (dw2_lookup_symbol): Don't pass argument for
6358 WANT_SPECIFIC_BLOCK.
6359 (dw2_expand_symtabs_for_function): Don't pass argument for
6360 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6361 (class dw2_debug_names_iterator)
6362 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6363 parameter, change BLOCK_INDEX type to gdb::optional.
6364 <m_want_specific_block>: Remove.
6365 <m_block_index>: Change type to gdb::optional.
6366 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6367 gdb::optional. Re-write in function of gdb::optional.
6368 (dw2_debug_names_lookup_symbol): Don't pass argument for
6369 WANT_SPECIFIC_BLOCK.
6370 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6371 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6372 BLOCK_INDEX.
6373
ae60f04e
PW		 63742019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6375
6376 * NEWS: Mention changes to "info sources" command.
6377
28cd9371
PW		 63782019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6379
6380 * symtab.c (filename_partial_match_opts): New struct type.
6381 (struct output_source_filename_data): New members
6382 regexp, c_regexp, partial_match.
6383 (output_source_filename): Use new members to decide to print file.
6384 (info_sources_option_defs): New variable.
6385 (make_info_sources_options_def_group, print_info_sources_header,
6386 info_sources_command_completer):
6387 New functions.
6388 (info_sources_command): Read new optional arguments.
6389 (_initialize_symtab): Update info sources help.
6390
ca683e3a
AO		 63912019-08-02 Alexandre Oliva <oliva@adacore.com>
6392
6393 * ada-lang.c (exception_support_info_v0): Renamed from...
6394 (default_exception_support_info): ... this. Create new
6395 definition for v1.
6396 (ada_has_this_exception_support): Look up catch_handlers_sym.
6397 (ada_exception_support_info_sniffer): Try v0 after default.
6398
f1264162
TT		 63992019-08-01 Tom Tromey <tromey@adacore.com>
6400
6401 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6402 gdbarch.h.
6403
0a7b2485
CB		 64042019-08-01 Christian Biesinger <cbiesinger@google.com>
6405
6406 * s12z-tdep.c: Fix include path for s12z-opc.h.
6407
c6bdbeb7
AH		 64082019-08-01 Alan Hayward <alan.hayward@arm.com>
6409
6410 * NEWS: Require GNU make 3.82.
6411
a2bd7b82
TT		 64122019-07-16 Tom Tromey <tom@tromey.com>
6413
6414 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6415 declare.
6416
aa3b6533
TT		 64172019-07-30 Tom Tromey <tromey@adacore.com>
6418
6419 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6420
a1530dc7
KB		 64212019-07-30 Kevin Buettner <kevinb@redhat.com>
6422
6423 * printcmd.c (print_address_symbolic): Print negative offsets.
6424 (build_address_symbolic): Force signed arithmetic when computing
6425 offset.
6426
2906593f
CB		 64272019-07-30 Christian Biesinger <cbiesinger@google.com>
6428
6429 PR/24474: Add a function to lookup static variables.
6430 * NEWS: Mention this new function.
6431 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6432 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6433 * python/python.c (python_GdbMethods): Add new function.
6434
c620ed88
CB		 64352019-07-29 Christian Biesinger <cbiesinger@google.com>
6436
6437 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6438 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6439 (objfpy_lookup_static_symbol): New function.
6440 (objfile_object_methods): Add new functions.
6441
bc4268a5
PW		 64422019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6443
6444 * NEWS: Mention 'set|show print frame-info'. Mention new
6445 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6446 backtrace argument. Mention that python frame filtering code
6447 is now consistent with what 'backtrace' command prints.
6448
4b5e8d19
PW		 64492019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6450
6451 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6452 comments.
6453 (print_frame_info_auto, print_frame_info_source_line,
6454 print_frame_info_location, print_frame_info_source_and_location,
6455 print_frame_info_location_and_address, print_frame_info_short_location):
6456 New declarations.
6457 (struct frame_print_options): New member print_frame_info.
6458 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6459 * stack.h (get_user_print_what_frame_info): New declaration.
6460 (frame_show_address): New declaration.
6461 * stack.c (print_frame_arguments_choices): New value 'presence'.
6462 (print_frame_info_auto, print_frame_info_source_line,
6463 print_frame_info_location, print_frame_info_source_and_location,
6464 print_frame_info_location_and_address, print_frame_info_short_location,
6465 print_frame_info_choices, print_frame_info_print_what): New definitions.
6466 (print_frame_args): Only print dots for args if print frame-arguments
6467 is 'presence'.
6468 (frame_print_option_defs): New element for "frame-info".
6469 (get_user_print_what_frame_info): New function.
6470 (frame_show_address): Make non static. Move comment to stack.h.
6471 (print_frame_info_to_print_what): New function.
6472 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6473 to decide what to print.
6474 (backtrace_command_1): Handle the new print_frame_arguments_presence
6475 value.
6476 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6477 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6478 (py_print_frame): In non-mi mode, use LOCATION as default for
6479 print_what, similarly to frame information printed directly by
6480 backtrace command. Handle frame-info user option in non MI mode.
6481
6bdfee81
KB		 64822019-07-27 Kevin Buettner <kevinb@redhat.com>
6483
6484 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6485 Add case for debugging 32-bit target on 64-bit host. Revise
6486 comment.
6487
98a617f8
KB		 64882019-07-27 Kevin Buettner <kevinb@redhat.com>
6489
6490 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6491 instead of find_function_entry_range_from_pc.
6492
567238c9
KB		 64932019-07-27 Kevin Buettner <kevinb@redhat.com>
6494
6495 * stack.c (find_frame_funname): Remove code which preferred
6496 minsym over symtab sym in "certain pathological cases".
6497
2dc80cf8
KB		 6498 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6499 parameter. Change type of "do_demangle" to bool.
6500 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6501 Pass suitable "prefer_sym_over_minsym" flag to
6502 build_address_symbolic(). Don't output "+" for negative offsets.
6503 * printcmd.c (print_address_symbolic): Update invocation of
6504 build_address_symbolic to include a "prefer_sym_over_minsym"
6505 flag.
6506 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6507 Restrict cases in which use of minimal symbol is preferred to that
6508 of a found symbol. Update comments.
6509
1aff7173
KB		 6510 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6511 for entry pc when entry pc is out of range for that FDE.
6512
89b085ac
BC		 65132019-07-26 Brian Callahan <bcallah@openbsd.org>
6514
6515 PR gdb/24839:
6516 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6517 type.
6518
f32feb4a
CB		 65192019-07-25 Christian Biesinger <cbiesinger@google.com>
6520
6521 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6522 this function's Python signature.
6523
6524
65252019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6526
6527 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6528 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6529 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6530 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6531 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6532
6533
c54e4253
YS		 65342019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6535
6536 * h8300-tdep.c (h8300_register_name_common): New.
6537 h8300_register_name): Use h8300_register_name_common.
6538 (h8300s_register_name): Likewise.
6539 (h8300sx_register_name): Likewise.
6540 (h8300h_register_nam): New.
6541 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6542
6543
40eadf04
SP		 65442019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6545
6546 * arm-tdep.c (arm_skip_cmse_entry): New function.
6547 (arm_is_sgstubs_section): New function.
6548 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6549
bfa2a36d
TT		 65502019-07-22 Tom Tromey <tom@tromey.com>
6551
6552 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6553 Don't self-assign.
6554
a8e9d247
AB		 65552019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6556
6557 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6558 type_print.
6559
eb86c5e2
AB		 65602019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6561
6562 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6563 so that GDB doesn't match any msymbols when searching in the
6564 TYPES_DOMAIN.
6565 (print_symbol_info): Print using typedef_print or type_print based
6566 on the type of the symbol. Add updated FIXME comment moved from...
6567 (_initialize_symtab): ... move and update FIXME comment to above.
6568
a8eab7c6
AB		 65692019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6570
6571 * NEWS: Mention adding -q option to "info types".
6572 * symtab.c (struct info_types_options): New struct.
6573 (info_types_options_defs): New variable.
6574 (make_info_types_options_def_group): New function.
6575 (info_types_command): Use gdb::option framework to parse options.
6576 (info_types_command_completer): New function.
6577 (_initialize_symtab): Extend the help text on "info types" and
6578 register command completer.
6579
b4603c34
CB		 65802019-07-21 Christian Biesinger <cbiesinger@google.com>
6581
6582 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6583 (lookup_symbol_in_objfile): Change int to block_enum and add a
6584 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6585
c8cdc1e0
CB		 65862019-07-20 Christian Biesinger <cbiesinger@google.com>
6587
6588 * MAINTAINERS (Write After Approval): Add self.
6589
01e175fe
AB		 65902019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6591
6592 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6593 instruction to the dummy code region.
6594
56f79b63
TT		 65952019-07-19 Tom Tromey <tromey@adacore.com>
6596
6597 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6598 (ARGSUSED, PARAMS, __func__): Remove rules.
6599
4c5aa8e0
AH		 66002019-07-19 Alan Hayward <alan.hayward@arm.com>
6601
6602 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6603 * features/arm/arm-with-iwmmxt.c: Remove.
6604 * features/arm/arm-with-iwmmxt.xml: Remove.
6605 * features/arm/arm-with-m-fpa-layout.c: Remove.
6606 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6607 * features/arm/arm-with-m-vfp-d16.c: Remove.
6608 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6609 * features/arm/arm-with-m.c: Remove.
6610 * features/arm/arm-with-m.xml: Remove.
6611 * features/arm/arm-with-neon.c: Remove.
6612 * features/arm/arm-with-neon.xml: Remove.
6613 * features/arm/arm-with-vfpv2.c: Remove.
6614 * features/arm/arm-with-vfpv2.xml: Remove.
6615 * features/arm/arm-with-vfpv3.c: Remove.
6616 * features/arm/arm-with-vfpv3.xml: Remove.
6617
f42b2617
AH		 66182019-07-19 Alan Hayward <alan.hayward@arm.com>
6619
6620 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6621
f29ec966
AH		 66222019-07-19 Alan Hayward <alan.hayward@arm.com>
6623
6624 * arch/aarch32.c (aarch32_create_target_description): Create
6625 target descriptions using features.
6626 * arch/arm.c (arm_create_target_description)
6627 (arm_create_mprofile_target_description): Likewise.
6628 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6629
d105cce5
AH		 66302019-07-19 Alan Hayward <alan.hayward@arm.com>
6631
6632 * Makefile.in: Add new files.
6633 * aarch32-tdep.c: New file.
6634 * aarch32-tdep.h: New file.
6635 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6636 Call aarch32_read_description.
6637 * arch/aarch32.c: New file.
6638 * arch/aarch32.h: New file.
6639 * arch/arm.c (arm_create_target_description)
6640 (arm_create_mprofile_target_description): New function.
6641 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6642 (arm_create_target_description)
6643 (arm_create_mprofile_target_description): New declaration.
6644 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6645 read_description functions.
6646 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6647 Likewise.
6648 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6649 * arm-tdep.c (tdesc_arm_list): New variable.
6650 (arm_register_g_packet_guesses): Call create description functions.
6651 (arm_read_description) (arm_read_mprofile_description): New
6652 function.
6653 * arm-tdep.h (arm_read_description)
6654 (arm_read_mprofile_description): Add declaration.
6655 * configure.tgt: Add new files.
6656
afe09f0b
GL		 66572019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6658
6659 * top.c (new_ui_command): Open specified terminal just once.
6660
cd215b2e
TT		 66612019-07-18 Tom Tromey <tromey@adacore.com>
6662
6663 * symtab.c (main_name): Constify return type.
6664 * symfile.c (set_initial_language): Update.
6665 * symtab.h (main_name): Constify return type.
6666
d8f68fcb
TT		 66672019-07-17 Tom Tromey <tom@tromey.com>
6668
6669 * tui/tui-winsource.c (tui_update_source_window)
6670 (tui_update_source_window_as_is)
6671 (tui_update_source_windows_with_line): Remove return.
6672 * tui/tui-disasm.c (tui_show_disassem)
6673 (tui_show_disassem_and_update_source): Remove return.
6674 * tui/tui.c (tui_reset): Remove return.
6675 * tui/tui-wingeneral.c
6676 (tui_check_and_display_highlight_if_needed): Remove return.
6677
ca5af91e
TT		 66782019-07-17 Tom Tromey <tom@tromey.com>
6679
6680 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6681
5104fe36
TT		 66822019-07-17 Tom Tromey <tom@tromey.com>
6683
6684 * tui/tui-winsource.h (struct tui_exec_info_window)
6685 (struct tui_source_window_base): Move from tui-data.h.
6686 * tui/tui-winsource.c: Move many method definitions from
6687 elsewhere. Remove "structuring" comments.
6688 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6689 (tui_source_window_base::refresh_window): Move to
6690 tui-winsource.c.
6691 * tui/tui-win.c (tui_source_window_base::refresh_all)
6692 (tui_source_window_base::update_tab_width)
6693 (tui_source_window_base::set_new_height)
6694 (tui_source_window_base::do_make_visible_with_new_height): Move to
6695 tui-winsource.c.
6696 * tui/tui-source.h: Update.
6697 * tui/tui-source.c (tui_source_window_base::reset): Move to
6698 tui-winsource.c.
6699 * tui/tui-disasm.h: Update.
6700 * tui/tui-data.h (struct tui_exec_info_window): Move to
6701 tui-winsource.h.
6702 (struct tui_source_window_base): Likewise.
6703 * tui/tui-data.c (tui_source_window_base::clear_detail)
6704 (tui_source_window_base, ~tui_source_window_base): Move to
6705 tui-winsource.c.
6706
daa15dde
TT		 67072019-07-17 Tom Tromey <tom@tromey.com>
6708
6709 * tui/tui-win.c (tui_resize_all)
6710 (tui_source_window_base::update_tab_width)
6711 (tui_adjust_win_heights): Update.
6712 (tui_win_info::make_invisible_and_set_new_height): Rename from
6713 make_invisible_and_set_new_height.
6714 * tui/tui-data.h (struct tui_win_info)
6715 <make_invisible_and_set_new_height>: New method.
6716
bfad4537
TT		 67172019-07-17 Tom Tromey <tom@tromey.com>
6718
6719 * tui/tui.c: Update.
6720 * tui/tui-source.h (struct tui_source_window): Move from
6721 tui-data.h.
6722 * tui/tui-layout.c: Update.
6723 * tui/tui-disasm.c: Update.
6724 * tui/tui-data.h (struct tui_source_window): Move to
6725 tui-source.h.
6726
88f7e873
TT		 67272019-07-17 Tom Tromey <tom@tromey.com>
6728
6729 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6730 tui-data.h.
6731 * tui/tui-data.h (struct tui_disasm_window): Move to
6732 tui-disasm.h.
6733
96bd6233
TT		 67342019-07-17 Tom Tromey <tom@tromey.com>
6735
6736 * tui/tui-regs.h (struct tui_data_item_window): Move from
6737 tui-data.h.
6738 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6739 * tui/tui-data.h (struct tui_data_item_window): Move to
6740 tui-regs.h.
6741 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6742
ce38393b
TT		 67432019-07-17 Tom Tromey <tom@tromey.com>
6744
6745 * tui/tui.c: Update.
6746 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6747 (tui_cmd_window::max_height): Move to tui-command.c.
6748 * tui/tui-layout.c: Update.
6749 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6750 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6751 tui-command.c.
6752 * tui/tui-command.h (struct tui_cmd_window): Move from
6753 tui-data.h.
6754 * tui/tui-command.c: Remove "structuring" comments.
6755 (tui_cmd_window::clear_detail)
6756 (tui_cmd_window::do_make_visible_with_new_height)
6757 (tui_cmd_window::max_height): Move from elsewhere.
6758
2d8b51cb
TT		 67592019-07-17 Tom Tromey <tom@tromey.com>
6760
6761 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6762 Now static.
6763 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6764 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6765
18ab23af
TT		 67662019-07-17 Tom Tromey <tom@tromey.com>
6767
6768 * tui/tui.c: Update.
6769 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6770 tui-regs.c.
6771 * tui/tui-windata.h: Remove file.
6772 * tui/tui-windata.c: Remove file.
6773 * tui/tui-win.c (tui_data_window::set_new_height)
6774 (tui_data_window::do_make_visible_with_new_height): Move to
6775 tui-regs.c.
6776 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6777 * tui/tui-regs.c: Remove "structuring" comments.
6778 (tui_data_window::first_data_item_displayed)
6779 (tui_data_window::delete_data_content_windows)
6780 (tui_data_window::erase_data_content)
6781 (tui_data_window::display_all_data)
6782 (tui_data_window::refresh_all)
6783 (tui_data_window::do_scroll_vertical)
6784 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6785 (tui_data_window::do_make_visible_with_new_height)
6786 (tui_data_window::refresh_window): Move from elsewhere.
6787 (_initialize_tui_regs): Move to end of file.
6788 * tui/tui-layout.c: Update.
6789 * tui/tui-hooks.c: Update.
6790 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6791 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6792 tui-regs.c.
6793 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6794
88b7e7cc
TT		 67952019-07-17 Tom Tromey <tom@tromey.com>
6796
6797 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6798 seen.
6799
0fcd3711
TT		 68002019-07-17 Tom Tromey <tom@tromey.com>
6801
6802 * tui/tui-win.c (tui_source_window_base::set_new_height)
6803 (tui_source_window_base::do_make_visible_with_new_height): Use
6804 m_has_locator field directly.
6805 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6806 method.
6807 (struct tui_source_window_base) <has_locator>: Likewise.
6808
4a38112d
TT		 68092019-07-17 Tom Tromey <tom@tromey.com>
6810
6811 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6812 Don't declare.
6813 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6814 Remove.
6815 * tui/tui-win.c (tui_source_window_base::set_new_height)
6816 (tui_source_window_base::set_new_height)
6817 (make_invisible_and_set_new_height)
6818 (tui_source_window_base::do_make_visible_with_new_height)
6819 (tui_source_window_base::do_make_visible_with_new_height):
6820 Update.
6821 * tui/tui-layout.c (show_source_disasm_command, show_data)
6822 (show_source_or_disasm_and_command): Update.
6823 * tui/tui-layout.c (show_layout): Update.
6824
09129226
TT		 68252019-07-17 Tom Tromey <tom@tromey.com>
6826
6827 * tui/tui-layout.c (make_data_window): Remove.
6828 (show_data): Unify creation and re-initialization cases.
6829
4a8a5e84
TT		 68302019-07-17 Tom Tromey <tom@tromey.com>
6831
6832 * tui/tui-layout.c (make_source_window, make_disasm_window):
6833 Remove.
6834 (show_data): Unify creation and re-initialization cases.
6835
76d2be8e
TT		 68362019-07-17 Tom Tromey <tom@tromey.com>
6837
6838 * tui/tui-layout.c (make_command_window): Remove.
6839 (show_source_disasm_command, show_source_or_disasm_and_command):
6840 Unify creation and re-initialization cases.
6841
890b8bde
TT		 68422019-07-17 Tom Tromey <tom@tromey.com>
6843
6844 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6845 creation and re-initialization cases.
6846
2cdfa113
TT		 68472019-07-17 Tom Tromey <tom@tromey.com>
6848
6849 * tui/tui-regs.c (tui_get_register): Return void.
6850
8e3cfd09
TT		 68512019-07-17 Tom Tromey <tom@tromey.com>
6852
6853 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6854 Simplify.
6855
f4e04977
TT		 68562019-07-17 Tom Tromey <tom@tromey.com>
6857
6858 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6859 resetting.
6860
0379b883
TT		 68612019-07-17 Tom Tromey <tom@tromey.com>
6862
6863 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6864 * tui/tui-regs.c (tui_reg_layout): New function.
6865 (tui_show_registers, tui_reg_command): Use it.
6866 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6867 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6868 parameters.
6869 (tui_layout_command): Remove.
6870
b7fbad91
TT		 68712019-07-17 Tom Tromey <tom@tromey.com>
6872
6873 * tui/tui-layout.h (tui/tui-layout): Return void.
6874 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6875
4e1e56b9
TT		 68762019-07-17 Tom Tromey <tom@tromey.com>
6877
6878 * tui/tui-layout.c (show_source_disasm_command, show_data):
6879 Update.
6880 (reset_locator): Remove.
6881 (show_source_or_disasm_and_command): Update.
6882
1e0c09ba
TT		 68832019-07-17 Tom Tromey <tom@tromey.com>
6884
6885 * tui/tui-source.c (tui_source_window_base::reset): Remove
6886 win_type parameter.
6887 * tui/tui-layout.c (make_command_window, make_source_window)
6888 (make_disasm_window, make_data_window)
6889 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6890 (reset_locator, show_source_or_disasm_and_command): Update.
6891 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6892 win_type parameter.
6893 (struct tui_source_window_base) <reset>: Likewise.
6894
1bf605de
TT		 68952019-07-17 Tom Tromey <tom@tromey.com>
6896
6897 * tui/tui-layout.c (show_source_disasm_command): Use
6898 reset_locator.
6899 (reset_locator): New function.
6900 (init_and_make_win): Remove.
6901 (show_source_or_disasm_and_command): Use reset_locator.
6902
098f9ed4
TT		 69032019-07-17 Tom Tromey <tom@tromey.com>
6904
6905 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6906 condition.
6907 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6908 Remove condition.
6909 * tui/tui-source.c (tui_source_window_base::reset): New method.
6910 * tui/tui-layout.c (make_command_window): Don't call
6911 init_and_make_win.
6912 (make_source_window, make_disasm_window): Don't call
6913 make_source_or_disasm_window.
6914 (make_data_window): Don't call init_and_make_win. Change calling
6915 convention.
6916 (show_source_disasm_command, show_data): Simplify.
6917 (make_source_or_disasm_window): Remove.
6918 (show_source_or_disasm_and_command): Simplify.
6919 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6920 (struct tui_source_window_base) <reset>: Likewise.
6921 <execution_info>: Remove initializer.
6922 * tui/tui-data.c (tui_source_window_base): Initialize
6923 execution_info.
6924
80110957
TT		 69252019-07-17 Tom Tromey <tom@tromey.com>
6926
6927 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6928 variable.
6929
cf82af05
TT		 69302019-07-17 Tom Tromey <tom@tromey.com>
6931
6932 * tui/tui.c (tui_rl_other_window): Update.
6933 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6934 superclass method first. Always iterate over regs_content.
6935 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6936 method.
6937 * tui/tui-win.c (tui_set_focus_command): Update.
6938
01aeb396
TT		 69392019-07-17 Tom Tromey <tom@tromey.com>
6940
6941 * tui/tui-win.c (tui_set_focus_command): Rename from
6942 tui_set_focus. Call tui_enable.
6943 (tui_set_focus_command): Remove.
6944
fd6c75ee
TT		 69452019-07-17 Tom Tromey <tom@tromey.com>
6946
6947 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6948 refresh_window.
6949 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6950 touchwin.
6951 (tui_data_window::refresh_window): Call refresh_window on data
6952 items. Always call superclass refresh_window.
6953 (tui_win_info::refresh): Remove.
6954 (tui_source_window_base::refresh_window): Update.
6955 (tui_refresh_all): Update.
6956 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6957 refresh_window.
6958 (show_source_or_disasm_and_command): Likewise.
6959 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6960 (struct tui_source_window_base) <refresh>: Likewise.
6961
f6cc34a9
TT		 69622019-07-17 Tom Tromey <tom@tromey.com>
6963
6964 * tui/tui-winsource.c (tui_clear_source_content)
6965 (tui_show_source_content): Update.
6966 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6967 whether content is empty.
6968 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6969 Remove.
6970
f31ec9af
TT		 69712019-07-17 Tom Tromey <tom@tromey.com>
6972
6973 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6974 window's contents.
6975 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6976 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6977
d1b6f1e5
TT		 69782019-07-17 Tom Tromey <tom@tromey.com>
6979
6980 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6981 (struct tui_data_item_window): Update.
6982
d9743a13
TT		 69832019-07-17 Tom Tromey <tom@tromey.com>
6984
6985 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6986 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6987 defines.
6988
caf0bc4e
TT		 69892019-07-17 Tom Tromey <tom@tromey.com>
6990
6991 * tui/tui-winsource.h (tui_erase_source_content)
6992 (tui_clear_source_content): Remove "display_prompt" parameter.
6993 * tui/tui-winsource.c (tui_update_source_window_as_is)
6994 (tui_update_source_windows_with_addr): Update.
6995 (tui_clear_source_content): Remove "display_prompt" parameter.
6996 (tui_erase_source_content): Likewise. Simplify.
6997 (tui_show_source_content): Update.
6998 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6999 * tui/tui-stack.c (tui_show_frame_info): Update.
7000 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7001 Remove defines.
7002
9d391078
TT		 70032019-07-17 Tom Tromey <tom@tromey.com>
7004
7005 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7006 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7007 parameter.
7008 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7009 parameter.
7010
a38da35d
TT		 70112019-07-17 Tom Tromey <tom@tromey.com>
7012
7013 * tui/tui-winsource.c (tui_clear_source_content)
7014 (tui_show_source_content, tui_show_exec_info_content)
7015 (tui_clear_exec_info_content): Update.
7016 * tui/tui-stack.c (tui_show_locator_content): Update.
7017 (tui_show_frame_info): Update.
7018 * tui/tui-source.h (tui_source_window): Don't declare.
7019 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7020 from tui_source_is_displayed.
7021 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7022 Remove field.
7023 (struct tui_source_window_base) <content_in_use>: New field. Now
7024 bool.
7025 (struct tui_source_window) <showing_source_p>: New method.
7026 (TUI_SRC_WIN): Change cast.
7027 * tui/tui-data.c (tui_initialize_static_data): Update.
7028
c2cd8994
TT		 70292019-07-17 Tom Tromey <tom@tromey.com>
7030
7031 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7032 location_matches_p.
7033 * tui/tui-source.c (tui_source_window::location_matches_p): New
7034 method.
7035 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7036 method.
7037 * tui/tui-data.h (struct tui_source_window_base)
7038 <location_matches_p>: New method.
7039 (struct tui_source_window, struct tui_disasm_window)
7040 <location_matches_p>: Likewise.
7041
4dde7b34
TT		 70422019-07-17 Tom Tromey <tom@tromey.com>
7043
7044 * tui/tui-win.c (tui_set_win_height_command): Rename from
7045 tui_set_win_height.
7046 (tui_set_win_height_command): Remove.
7047
b73dd877
TT		 70482019-07-17 Tom Tromey <tom@tromey.com>
7049
7050 * tui/tui-source.c (tui_source_window): New constructor. Add
7051 observer.
7052 (~tui_source_window): New destructor.
7053 (tui_source_window::style_changed): New method.
7054 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7055 (tui_attach_detach_observers): Update.
7056 * tui/tui-data.h (struct tui_source_window): Make constructor not
7057 inline. Add destructor.
7058 (struct tui_source_window) <style_changed>: New method.
7059 <m_observable>: New member.
7060
ae2b5380
TT		 70612019-07-17 Tom Tromey <tom@tromey.com>
7062
7063 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7064 * tui/tui-win.c (tui_resize_all): Fix typo.
7065
1ce3e844
TT		 70662019-07-17 Tom Tromey <tom@tromey.com>
7067
7068 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7069 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7070 (tui_refresh_all): Remove "list" parameter. Use foreach.
7071 * tui/tui-win.c (window_name_completer): Use foreach.
7072 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7073 (update_tab_width): Likewise.
7074 * tui/tui-layout.c (show_layout): Update.
7075 * tui/tui-data.h (class tui_window_iterator): New.
7076 (struct all_tui_windows): New.
7077 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7078
fe3eaf1c
TT		 70792019-07-17 Tom Tromey <tom@tromey.com>
7080
7081 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7082 parameter. Don't reference globals.
7083 (tui_reg_command): Update.
7084
368c1354
TT		 70852019-07-17 Tom Tromey <tom@tromey.com>
7086
7087 * tui/tui-regs.c (tui_show_registers): Simplify.
7088
e80cd204
TT		 70892019-07-17 Tom Tromey <tom@tromey.com>
7090
7091 * tui/tui-regs.c (tui_show_registers): Update.
7092 (tui_show_register_group): Add win_info parameter.
7093
aca2dd16
TT		 70942019-07-17 Tom Tromey <tom@tromey.com>
7095
7096 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7097 Rename from tui_display_reg_element_at_line.
7098 (tui_data_window::display_registers_from_line): Update.
7099 * tui/tui-data.h (struct tui_data_window)
7100 <display_reg_element_at_line>: New method.
7101
517e9505
TT		 71022019-07-17 Tom Tromey <tom@tromey.com>
7103
7104 * tui/tui-regs.h (tui_display_registers_from)
7105 (tui_display_registers_from_line): Don't declare.
7106 * tui/tui-windata.c (tui_data_window::display_all_data)
7107 (tui_data_window::refresh_all)
7108 (tui_data_window::do_scroll_vertical): Update.
7109 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7110 from tui_display_registers_from.
7111 (tui_display_reg_element_at_line): Update.
7112 (tui_data_window::display_registers_from_line): Rename from
7113 tui_display_registers_from_line.
7114 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7115 display_registers_from_line>: New methods.
7116
f76d8b19
TT		 71172019-07-17 Tom Tromey <tom@tromey.com>
7118
7119 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7120 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7121 from tui_erase_data_content.
7122 (tui_data_window::display_all_data)
7123 (tui_data_window::refresh_all)
7124 (tui_data_window::do_scroll_vertical): Update.
7125 * tui/tui-regs.c (tui_show_registers): Update.
7126 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7127 New method.
7128
b4094625
TT		 71292019-07-17 Tom Tromey <tom@tromey.com>
7130
7131 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7132 declare.
7133 * tui/tui-windata.c
7134 (tui_data_window::delete_data_content_windows): Rename from
7135 tui_delete_data_content_windows.
7136 (tui_data_window::display_all_data)
7137 (tui_data_window::do_scroll_vertical): Update.
7138 * tui/tui-data.h (struct tui_data_window)
7139 <delete_data_content_windows>: New method.
7140
c223a729
TT		 71412019-07-17 Tom Tromey <tom@tromey.com>
7142
7143 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7144 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7145
50daf268
TT		 71462019-07-17 Tom Tromey <tom@tromey.com>
7147
7148 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7149 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7150 from tui_display_all_data.
7151 * tui/tui-win.c
7152 (tui_data_window::do_make_visible_with_new_height): Update.
7153 * tui/tui-regs.c (tui_show_registers): Update.
7154 * tui/tui-layout.c (tui_set_layout): Update.
7155 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7156 method.
7157
df5f8cab
TT		 71582019-07-17 Tom Tromey <tom@tromey.com>
7159
7160 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7161 * tui/tui-windata.c (tui_display_data_from): Remove.
7162 (tui_data_window::refresh_all): Update.
7163
80cb6c27
TT		 71642019-07-17 Tom Tromey <tom@tromey.com>
7165
7166 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7167 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7168 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7169 tui_display_registers_from_line.
7170 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7171 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7172 "force_display" parameter.
7173
baff0c28
TT		 71742019-07-17 Tom Tromey <tom@tromey.com>
7175
7176 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7177 declare.
7178 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7179 Rename from tui_first_reg_element_no_inline.
7180 (tui_display_reg_element_at_line)
7181 (tui_display_registers_from_line): Update.
7182 * tui/tui-data.h (struct tui_data_window)
7183 <first_reg_element_no_inline>: New method.
7184
3b23c5f2
TT		 71852019-07-17 Tom Tromey <tom@tromey.com>
7186
7187 * tui/tui-windata.c (tui_display_data_from)
7188 (tui_data_window::do_scroll_vertical): Update.
7189 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7190 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7191 Rename from tui_line_from_reg_element_no.
7192 (tui_display_registers_from_line): Update.
7193 * tui/tui-data.h (struct tui_data_window)
7194 <line_from_reg_element_no>: New method.
7195
0b5ec218
TT		 71962019-07-17 Tom Tromey <tom@tromey.com>
7197
7198 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7199 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7200 tui_last_regs_line_no.
7201 (tui_display_reg_element_at_line)
7202 (tui_display_registers_from_line): Update.
7203 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7204 method.
7205
0807ab7b
TT		 72062019-07-17 Tom Tromey <tom@tromey.com>
7207
7208 PR tui/24722:
7209 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7210 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7211 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7212 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7213 (tui_update_breakpoint_info): Likewise.
7214 * tui/tui-hooks.c (tui_event_create_breakpoint)
7215 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7216 Update.
7217
9ad7fdef
TT		 72182019-07-17 Tom Tromey <tom@tromey.com>
7219
7220 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7221
5813316f
TT		 72222019-07-17 Tom Tromey <tom@tromey.com>
7223
7224 * tui/tui-winsource.c (tui_update_source_window_as_is)
7225 (tui_update_source_windows_with_addr): Update.
7226 * tui/tui-source.h (tui_set_source_content)
7227 (tui_show_symtab_source): Add "win_info" parameter.
7228 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7229 parameter.
7230 (tui_show_symtab_source): Likewise.
7231
00e264e7
TT		 72322019-07-17 Tom Tromey <tom@tromey.com>
7233
7234 * tui/tui-wingeneral.c
7235 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7236
06210ce4
TT		 72372019-07-17 Tom Tromey <tom@tromey.com>
7238
7239 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7240 (struct tui_cmd_window) <can_scroll>: New method.
7241 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7242 method.
7243
381befee
TT		 72442019-07-17 Tom Tromey <tromey@adacore.com>
7245
7246 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7247 do_field_signed>: Rename. Change type of "value".
7248 * ui-out.c (ui_out::field_signed): Rename from field_int.
7249 Change type of "value".
7250 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7251 type of "value".
7252 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7253 do_field_int. Change type of "value".
7254 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7255 do_field_int. Change type of "value".
7256 * tracepoint.c (trace_status_mi, tfind_1)
7257 (print_one_static_tracepoint_marker): Update.
7258 * thread.c (print_thread_info_1, print_selected_thread_frame):
7259 Update.
7260 * stack.c (print_frame, print_frame_info): Update.
7261 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7262 Update.
7263 * source.c (print_source_lines_base): Update.
7264 * skip.c (info_skip_command): Update.
7265 * record-btrace.c (btrace_ui_out_decode_error)
7266 (btrace_call_history_src_line): Update.
7267 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7268 Update.
7269 * progspace.c (print_program_space): Update.
7270 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7271 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7272 do_field_int. Change type of "value".
7273 * mi/mi-out.c (mi_ui_out::do_table_begin)
7274 (mi_ui_out::do_table_header): Update.
7275 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7276 type of "value".
7277 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7278 (mi_cmd_data_list_changed_registers, output_register)
7279 (mi_cmd_data_read_memory, mi_load_progress)
7280 (mi_cmd_trace_frame_collected): Update.
7281 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7282 Update.
7283 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7284 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7285 (mi_cmd_var_list_children, varobj_update_one): Update.
7286 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7287 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7288 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7289 * inferior.c (print_inferior): Update.
7290 * gdb_bfd.c (print_one_bfd): Update.
7291 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7292 Update.
7293 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7294 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7295 do_field_int. Change type of "value".
7296 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7297 do_field_int. Change type of "value".
7298 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7299 (print_one_breakpoint_location, print_it_catch_fork)
7300 (print_one_catch_fork, print_it_catch_vfork)
7301 (print_one_catch_vfork, print_it_catch_solib)
7302 (print_it_catch_exec, print_it_ranged_breakpoint)
7303 (print_mention_watchpoint, print_mention_masked_watchpoint)
7304 (bkpt_print_it, update_static_tracepoint): Update.
7305 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7306 * break-catch-syscall.c (print_it_catch_syscall): Update.
7307 * ada-tasks.c (print_ada_task_info): Update.
7308 * ada-lang.c (print_it_exception, print_mention_exception):
7309 Update.
7310
6b78c3f8
AB		 73112019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7312
7313 PR breakpoints/24541
7314 * gdbarch.c: Regenerate.
7315 * gdbarch.h: Regenerate.
7316 * gdbarch.sh: Adjust return type and parameter types for
7317 'stap_adjust_register'.
7318 (i386_stap_adjust_register): Adjust signature and return new
7319 register name.
7320 * stap-probe.c (stap_parse_register_operand): Adjust use of
7321 'gdbarch_stap_adjust_register'.
7322
d72a9b85
TT		 73232019-07-17 Tom Tromey <tromey@adacore.com>
7324
7325 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7326 declare VEC.
7327 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7328 std::vector.
7329 (struct s390_process_info): Add initializers.
7330 (s390_add_process): Use new.
7331 (s390_linux_nat_target::low_forget_process): Use delete.
7332 (s390_linux_nat_target::low_new_fork)
7333 (s390_linux_nat_target::stopped_by_watchpoint)
7334 (s390_linux_nat_target::low_prepare_to_resume)
7335 (s390_linux_nat_target::insert_watchpoint)
7336 (s390_linux_nat_target::insert_hw_breakpoint)
7337 (s390_linux_nat_target::remove_watchpoint)
7338 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7339
206e6c58
JB		 73402019-07-16 John Baldwin <jhb@FreeBSD.org>
7341
7342 * aarch64-fbsd-nat.c: Include regcache.h.
7343 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7344 argument.
7345 (aarch64_fbsd_nat_target::fetch_registers)
7346 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7347 variable.
7348 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7349
cbde90f2
JB		 73502019-07-16 John Baldwin <jhb@FreeBSD.org>
7351
7352 * fbsd-nat.c: Include gdbarch.h.
7353
07128006
TT		 73542019-07-15 Tom Tromey <tromey@adacore.com>
7355
7356 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7357
1f77b012
TT		 73582019-07-15 Tom Tromey <tromey@adacore.com>
7359
7360 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7361 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7362 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7363 * cli-out.c (cli_ui_out::do_field_int): New method.
7364 * ui-out.c (ui_out::field_unsigned): New method.
7365 * symfile.c (generic_load): Use field_unsigned.
7366 (print_transfer_performance): Likewise.
7367 * record-btrace.c (ui_out_field_uint): Remove.
7368 (btrace_call_history_insn_range, btrace_call_history): Use
7369 field_unsigned.
7370 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7371 field_unsigned.
7372 * ui-out.h (class ui_out) <field_unsigned>: New method.
7373 <do_field_unsigned>: Likewise.
7374
33eca680
TT		 73752019-07-15 Tom Tromey <tromey@adacore.com>
7376
7377 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7378 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7379 * target.c (flash_erase_command): Use field_string.
7380 * infrun.c (print_signal_received_reason): Use field_string.
7381 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7382 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7383 field_string.
7384 * ada-tasks.c (print_ada_task_info): Use field_string.
7385
ca8d69be
TT		 73862019-07-15 Tom Tromey <tromey@adacore.com>
7387
7388 * target.c (flash_erase_command): Use field_core_addr.
7389 * symfile.c (generic_load): Use field_core_addr.
7390 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7391 Use field_core_addr.
7392 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7393 field_core_addr.
7394
0d4e84ed
AB		 73952019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7396
7397 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7398 value if its desired type is smaller than a CORE_ADDR and signed.
7399
9a49df9d
AB		 74002019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7401
7402 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7403 of changes to field names, and use new is_reference field to
7404 decide if a property is a reference or not.
7405 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7406 field.
7407 (struct dwarf2_property_baton): Update header comment, rename
7408 'referenced_type' to 'property_type' and update comments.
7409 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7410 default property type, store in property baton, update to take
7411 accound of renamed field.
7412 (read_func_scope): Update call to attr_to_dynamic_prop.
7413 (read_array_type): Likewise.
7414 (dwarf2_per_cu_addr_sized_int_type): New function.
7415 (read_subrange_index_type): Move type finding code to
7416 dwarf2_per_cu_addr_sized_int_type.
7417 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7418 (dwarf2_per_cu_addr_type): New function.
7419 (set_die_type): Update calls to attr_to_dynamic_prop.
7420
b86352cf
AB		 74212019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7422
7423 * dwarf2read.c (read_subrange_index_type): New function.
7424 (read_subrange_type): Move code into new function and call it.
7425 * gdbtypes.c (create_range_type): Add some asserts.
7426
603490bf
AB		 74272019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7428
7429 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7430 update return statements.
7431 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7432 declaration, and update comment to match.
7433 * gdbtypes.c (resolve_dynamic_array): Update call to
7434 dwarf2_evaluate_property to match new return type.
7435
592f9d27
AB		 74362019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7437
7438 * valarith.c (value_subscripted_rvalue): Change lowerbound
7439 parameter type from int to LONGEST.
7440 * value.h (value_subscripted_rvalue): Likewise in declaration.
7441
60cfcb20
AB		 74422019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7443
7444 * cli/cli-utils.c (info_print_command_completer): New function.
7445 * cli/cli-utils.h: Add 'completer.h' include, and forward
7446 declaration for 'struct cmd_list_element'.
7447 (info_print_command_completer): Declare.
7448 * stack.c (_initialize_stack): Add completer for 'info locals' and
7449 'info args'.
7450 * symtab.c (_initialize_symtab): Add completer for 'info
7451 variables' and 'info functions'.
7452 * NEWS: Mention completion for additional info commands.
7453
b16507e0
AB		 74542019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7455
7456 * cli/cli-utils.c (extract_info_print_args): Delete.
7457 (extract_arg_maybe_quoted): Delete.
7458 (info_print_options_defs): New variable.
7459 (make_info_print_options_def_group): New function.
7460 (extract_info_print_options): Define new function.
7461 * cli/cli-utils.h (extract_info_print_args): Delete.
7462 (struct info_print_options): New structure.
7463 (extract_info_print_options): Declare new function.
7464 * stack.c (info_locals_command): Update to use new
7465 extract_info_print_options, also add a header comment.
7466 (info_args_command): Likewise.
7467 * symtab.c (info_variables_command): Likewise.
7468 (info_functions_command): Likewise.
7469
021d8588
AB		 74702019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7471
7472 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7473 to extract string arguments.
7474 * common/common-utils.c (extract_string_maybe_quoted): New function.
7475 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7476
b777eb6d
TT		 74772019-07-11 Tom Tromey <tromey@adacore.com>
7478
7479 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7480 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7481 * top.h (gdbinit): Don't declare.
7482 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7483 into...
7484 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7485 * top.c (gdb_init): Don't call init_cli_cmds.
7486 (gdbinit): Remove.
7487 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7488
72ee03ff
TT		 74892019-07-11 Tom Tromey <tromey@adacore.com>
7490
7491 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7492 after it has been moved.
7493
00db9531
SM		 74942019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7495
7496 * valops.c (value_must_coerce_to_target): Change return type to
7497 bool.
7498 * value.h (value_must_coerce_to_target): Likewise.
7499
f2478a7e
SM		 75002019-07-10 Simon Marchi <simon.marchi@efficios.com>
7501
7502 * breakpoint.c (is_hardware_watchpoint): Remove
7503 forward-declaration.
7504 (is_masked_watchpoint): Change return type to bool.
7505 (is_tracepoint): Likewise.
7506 (is_breakpoint): Likewise.
7507 (is_hardware_watchpoint): Likewise.
7508 (is_watchpoint): Likewise.
7509 (is_no_memory_software_watchpoint): Likewise.
7510 (is_catchpoint): Likewise.
7511 (breakpoint_1): Make FILTER parameter's return type bool.
7512 is_masked_watchpoint): Change return type to bool.
7513 (save_breakpoints): Make FILTER parameter's return type bool.
7514 * breakpoint.h (is_breakpoint): Change return type to bool.
7515 (is_watchpoint): Likewise.
7516 (is_catchpoint): Likewise.
7517 (is_tracepoint): Likewise.
7518
0d12e84c
TT		 75192019-07-10 Tom Tromey <tom@tromey.com>
7520
7521 * defs.h: Don't include gdbarch.h.
7522 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7523 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7524 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7525 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7526 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7527 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7528 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7529 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7530 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7531 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7532 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7533 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7534 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7535 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7536 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7537 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7538 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7539 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7540 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7541 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7542 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7543 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7544 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7545 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7546 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7547 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7548 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7549
f06f1252
TT		 75502019-07-10 Tom Tromey <tromey@adacore.com>
7551
7552 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7553 * breakpoint.c (init_ada_exception_breakpoint): Register as
7554 bp_catchpoint.
7555 (print_one_breakpoint_location, print_one_breakpoint): Use
7556 is_ada_exception_catchpoint.
7557 * ada-lang.c (class ada_catchpoint_location): Pass
7558 bp_loc_software_breakpoint to bp_location constructor.
7559 (is_ada_exception_catchpoint): New function.
7560
7a5d944b
TT		 75612019-07-10 Tom Tromey <tromey@adacore.com>
7562
7563 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7564 VEC.
7565 (struct arm_exidx_entry): New method operator<.
7566 (struct arm_exidx_data) <section_maps>: Change type.
7567 (arm_exidx_data_free): Remove.
7568 (arm_exidx_data_key): Change type. Move lower.
7569 (arm_exidx_new_objfile): Update.
7570 (arm_compare_exidx_entries): Remove.
7571 (arm_find_exidx_entry, _initialize_arm_tdep)
7572
48c66e1d
TT		 75732019-07-10 Tom Tromey <tromey@adacore.com>
7574
7575 * solib-spu.c (ocl_program_data_key): Change type.
7576 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7577 Update.
7578
a269fbf1
TT		 75792019-07-10 Tom Tromey <tromey@adacore.com>
7580
7581 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7582 (struct solib_aix_inferior_data) <library_list>: Change type.
7583 (solib_aix_inferior_data_handle): Change type.
7584 (get_solib_aix_inferior_data): Update.
7585 (solib_aix_free_library_list): Remove.
7586 (library_list_start_library): Update.
7587 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7588 return type.
7589 (solib_aix_get_library_list)
7590 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7591 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7592
c294730c
TT		 75932019-07-10 Tom Tromey <tromey@adacore.com>
7594
7595 * solib-dsbt.c (struct dsbt_info): Add initializers.
7596 (solib_dsbt_pspace_data): Change type.
7597 (dsbt_pspace_data_cleanup): Remove.
7598 (get_dsbt_info, _initialize_dsbt_solib): Update.
7599
9d52077d
TT		 76002019-07-10 Tom Tromey <tromey@adacore.com>
7601
7602 * spu-tdep.c (spu_overlay_data): Change type.
7603 (spu_get_overlay_table, spu_overlay_new_objfile)
7604 (_initialize_spu_tdep): Update.
7605
22a20dca
TT		 76062019-07-10 Tom Tromey <tromey@adacore.com>
7607
7608 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7609 destructor.
7610 (dbx_objfile_data_key): Change type and declare later.
7611 (DBX_SYMFILE_INFO): Rewrite.
7612 * dbxread.c (dbx_objfile_data_key): Change type.
7613 (dbx_symfile_init): Update.
7614 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7615 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7616 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7617
cb60f420
TT		 76182019-07-10 Tom Tromey <tromey@adacore.com>
7619
7620 * jit.c (jit_program_space_key): Change type. Move lower.
7621 (get_jit_program_space_data): Update.
7622 (jit_program_space_data_cleanup): Remove.
7623 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7624 Update.
7625 (struct jit_program_space_data): Add initializers.
7626
51df2ae3
TT		 76272019-07-10 Tom Tromey <tromey@adacore.com>
7628
7629 * solib-darwin.c (struct darwin_info): Add initializers.
7630 (solib_darwin_pspace_data): Change type.
7631 (darwin_pspace_data_cleanup): Remove.
7632 (get_darwin_info, _initialize_darwin_solib): Update.
7633
18101a35
TT		 76342019-07-10 Tom Tromey <tromey@adacore.com>
7635
7636 * remote-sim.c (struct sim_inferior_data): Add initializers,
7637 constructor, and destructor.
7638 (sim_inferior_data_key): Change type. Move lower.
7639 (check_for_duplicate_sim_descriptor): Update.
7640 (get_sim_inferior_data): Use new. Update.
7641 (~sim_inferior_data_cleanup): Rename from
7642 sim_inferior_data_cleanup. Simplify.
7643 (gdbsim_close_inferior, simulator_command)
7644 (sim_command_completer, _initialize_remote_sim): Update.
7645 (next_pid, INITIAL_PID): Move earlier.
7646
05b08ac1
TT		 76472019-07-10 Tom Tromey <tromey@adacore.com>
7648
7649 * python/python-internal.h (create_thread_object): Return
7650 gdbpy_ref.
7651 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7652 * python/py-inferior.c (struct threadlist_entry): Add
7653 constructor.
7654 <thread_obj>: Now a gdbpy_ref.
7655 (thread_to_thread_object): Update.
7656 (add_thread_object): Use new.
7657 (delete_thread_object): Use delete.
7658 (infpy_threads): Update.
7659 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7660 GIL.
7661
32372d80
TT		 76622019-07-10 Tom Tromey <tromey@adacore.com>
7663
7664 * valops.c (value_cast): Specialize error message for Ada.
7665
5c458ae8
SM		 76662019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7667
7668 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7669
4c462cb0
SM		 76702019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7671
7672 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7673 bpstat_should_step): Return bool, adjust comments.
7674 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7675 bpstat_should_step): Likewise.
7676
89abbcc2
AH		 76772019-07-10 Alan Hayward <alan.hayward@arm.com>
7678
7679 * features/Makefile: Use feature target descriptions for Arm.
7680 * features/arm/arm-core.c: Generate new file.
7681 * features/arm/arm-fpa.c: Likewise.
7682 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7683 * features/arm/arm-m-profile.c: Likewise.
7684 * features/arm/arm-vfpv2.c: Likewise.
7685 * features/arm/arm-vfpv3.c: Likewise.
7686 * features/arm/xscale-iwmmxt.c: Likewise.
7687 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7688
166a82be
AH		 76892019-07-10 Alan Hayward <alan.hayward@arm.com>
7690
7691 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7692 ptrace earlier.
7693
9fb4c7e9
AH		 76942019-07-10 Alan Hayward <alan.hayward@arm.com>
7695
7696 * features/aarch64-pauth.c: Regenerate.
7697
e2d0f980
SM		 76982019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7699
7700 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7701 bool.
7702 (bpstat_what): Use false instead of 0.
7703
a38118e5
PA		 77042019-07-09 Pedro Alves <palves@redhat.com>
7705
7706 * break-catch-throw.c (is_exception_catchpoint): New.
7707 * breakpoint.c (print_one_breakpoint_location): New parameter
7708 'raw_loc'. Handle it. Use
7709 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7710 looking at the breakpoint's type.
7711 (print_one_breakpoint): If handling "maint info breakpoints", also
7712 print locations of exception catchpoints.
7713 * breakpoint.h (is_exception_catchpoint): Declare.
7714
cb1e4e32
PA		 77152019-07-09 Pedro Alves <palves@redhat.com>
7716
7717 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7718 "addr" field.
7719 (allocate_location_exception_catchpoint): New.
7720 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7721 (initialize_throw_catchpoint_ops): Install
7722 allocate_location_exception_catchpoint as allocate_location
7723 method.
7724 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7725 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7726 bp_loc_other.
7727 (breakpoint_address_is_meaningful): Delete.
7728 (bl_address_is_meaningful): New.
7729 (breakpoint_locations_match): Adjust comment.
7730 (bp_location_from_bp_type): New, factored out of...
7731 (bp_location::bp_location(breakpoint *)): ... this.
7732 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7733 factored out of...
7734 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7735 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7736 breakpoint_address_is_meaningful.
7737 (bp_locations_compare): Adjust comment.
7738 (update_global_location_list): Use bl_address_is_meaningful
7739 instead of breakpoint_address_is_meaningful.
7740 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7741 explicit.
7742 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7743 * python/py-breakpoint.c (bppy_get_location): No longer check
7744 whether location is null.
7745
b58a68fe
PA		 77462019-07-09 Pedro Alves <palves@redhat.com>
7747
7748 PR c++/15468
7749 * breakpoint.c (print_one_breakpoint_location): Remove
7750 single-location assert.
7751
268a13a5
TT		 77522019-07-09 Tom Tromey <tom@tromey.com>
7753
7754 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7755 * configure: Rebuild.
7756 * configure.ac: Change common to gdbsupport.
7757 * gdbsupport: Rename from common.
7758 * acinclude.m4: Change common to gdbsupport.
7759 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7760 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7761 gdbsupport.
7762 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7763 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7764 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7765 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7766 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7767 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7768 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7769 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7770 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7771 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7772 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7773 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7774 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7775 coff-pe-read.c, command.h, compile/compile-c-support.c,
7776 compile/compile-c.h, compile/compile-cplus-symbols.c,
7777 compile/compile-cplus-types.c, compile/compile-cplus.h,
7778 compile/compile-loc2c.c, compile/compile.c, completer.c,
7779 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7780 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7781 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7782 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7783 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7784 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7785 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7786 features/aarch64-core.c, features/aarch64-fpu.c,
7787 features/aarch64-pauth.c, features/aarch64-sve.c,
7788 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7789 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7790 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7791 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7792 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7793 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7794 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7795 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7796 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7797 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7798 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7799 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7800 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7801 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7802 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7803 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7804 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7805 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7806 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7807 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7808 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7809 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7810 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7811 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7812 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7813 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7814 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7815 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7816 minsyms.c, mips-linux-tdep.c, namespace.h,
7817 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7818 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7819 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7820 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7821 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7822 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7823 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7824 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7825 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7826 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7827 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7828 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7829 procfs.c, producer.c, progspace.h, psymtab.h,
7830 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7831 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7832 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7833 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7834 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7835 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7836 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7837 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7838 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7839 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7840 target-memory.c, target.c, target.h, target/waitstatus.c,
7841 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7842 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7843 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7844 unittests/array-view-selftests.c,
7845 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7846 unittests/common-utils-selftests.c,
7847 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7848 unittests/format_pieces-selftests.c,
7849 unittests/function-view-selftests.c,
7850 unittests/lookup_name_info-selftests.c,
7851 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7852 unittests/mkdir-recursive-selftests.c,
7853 unittests/observable-selftests.c,
7854 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7855 unittests/parse-connection-spec-selftests.c,
7856 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7857 unittests/scoped_fd-selftests.c,
7858 unittests/scoped_mmap-selftests.c,
7859 unittests/scoped_restore-selftests.c,
7860 unittests/string_view-selftests.c, unittests/style-selftests.c,
7861 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7862 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7863 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7864 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7865 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7866 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7867
5b0e2db4
AB		 78682019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7869
7870 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7871 bool value.
7872 (decode_digits_ordinary): Set explicit_line field in sal.
7873 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7874 symtab_and_line that was set on an explicit line number in
7875 assembler code. Do always update the recorded symtab and line if
7876 we do skip the prologue.
7877
0ba852ab
AB		 78782019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7879
7880 * breakpoint.c (set_breakpoint_location_function): Remove
7881 explicit_loc parameter.
7882 (momentary_breakpoint_from_master): Update call to
7883 set_breakpoint_location_function.
7884 (add_location_to_breakpoint): Likewise.
7885
b3a7d171
AB		 78862019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7887
7888 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7889 required features based on default bfd type when no specific bfd
7890 is present.
7891
1f6f6e21
PW		 78922019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7893
7894 * NEWS: Mention that GDB printf and eval commands can now print
7895 C-style and Ada-style convenience var strings without
7896 calling the inferior.
7897 * printcmd.c (printf_c_string): Locally print GDB internal var
7898 instead of transiting via the inferior.
7899 (printf_wide_c_string): Likewise.
7900
79012019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7902
5862c886 7903 PR breakpoints/25011
ea142fbf
AH		 7904 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7905
0598af48
TT		 79062019-07-04 Tom Tromey <tom@tromey.com>
7907
7908 PR tui/24724:
7909 * tui/tui-winsource.c (tui_clear_source_content): Update.
7910 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7911 (tui_update_breakpoint_info): Update.
7912 (tui_set_exec_info_content): Update.
7913 * tui/tui-source.c (tui_set_source_content_nil): Update.
7914 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7915 has_break.
7916 * tui/tui-data.h (enum tui_bp_flag): New.
7917 (tui_bp_flags): New enum flags type.
7918 (struct tui_source_element) <break_mode>: Change type. Rename
7919 from has_break.
7920 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7921 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7922 constants.
7923 * tui/tui-winsource.h: Fix comment.
7924
350fab54
AH		 79252019-07-04 Alan Hayward <alan.hayward@arm.com>
7926
7927 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7928 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7929 (store_fpregs_to_thread)
7930 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7931 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7932 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7933 (IWMMXT_REGS_SIZE): Add define.
7934 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7935 (fetch_vfp_regs, store_vfp_regs)
7936 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7937 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7938
f0452268
AH		 79392019-07-04 Alan Hayward <alan.hayward@arm.com>
7940
7941 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7942 defines.
7943 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7944 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7945 (ARM_INT_REGISTER_SIZE): ...to this.
7946 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7947 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7948 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7949 (arm_linux_collect_gregset, supply_nwfpe_register)
7950 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7951 defines.
7952 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7953 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7954 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7955 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7956 (arm_return_in_memory, arm_store_return_value)
7957 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7958 (arm_record_ld_st_multiple): Likewise.
7959 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7960 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7961
e935475c
AH		 79622019-07-04 Alan Hayward <alan.hayward@arm.com>
7963
7964 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7965 AARCH64_DISPLACED_MODIFIED_INSNS.
7966 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7967 (aarch64_displaced_step_copy_insn): Likewise.
7968 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7969 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7970 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7971 ARM_DISPLACED_MODIFIED_INSNS.
7972 * arm-tdep.c (arm_gdbarch_init): Likewise.
7973 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7974 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7975 (struct arm_displaced_step_closure): Use
7976 ARM_DISPLACED_MODIFIED_INSNS.
7977
df0bb381
AH		 79782019-07-04 Alan Hayward <alan.hayward@arm.com>
7979
7980 * features/Makefile: Remove unused xml files.
7981 * features/aarch64.xml: Remove.
7982 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7983 * features/i386/amd64-avx-avx512.xml: Remove.
7984 * features/i386/amd64-avx-linux.xml: Remove.
7985 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7986 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7987 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7988 * features/i386/amd64-avx-mpx.xml: Remove.
7989 * features/i386/amd64-avx.xml: Remove.
7990 * features/i386/amd64-linux.xml: Remove.
7991 * features/i386/amd64-mpx-linux.xml: Remove.
7992 * features/i386/amd64-mpx.xml: Remove.
7993 * features/i386/amd64.xml: Remove.
7994 * features/i386/i386-avx-avx512-linux.xml: Remove.
7995 * features/i386/i386-avx-avx512.xml: Remove.
7996 * features/i386/i386-avx-linux.xml: Remove.
7997 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7998 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7999 * features/i386/i386-avx-mpx-linux.xml: Remove.
8000 * features/i386/i386-avx-mpx.xml: Remove.
8001 * features/i386/i386-avx.xml: Remove.
8002 * features/i386/i386-linux.xml: Remove.
8003 * features/i386/i386-mmx-linux.xml: Remove.
8004 * features/i386/i386-mmx.xml: Remove.
8005 * features/i386/i386-mpx-linux.xml: Remove.
8006 * features/i386/i386-mpx.xml: Remove.
8007 * features/i386/i386.xml: Remove.
8008 * features/i386/x32-avx-avx512-linux.xml: Remove.
8009 * features/i386/x32-avx-linux.xml: Remove.
8010 * features/i386/x32-linux.xml: Remove.
8011
edd6266a
AH		 80122019-07-04 Alan Hayward <alan.hayward@arm.com>
8013
8014 * regformats/aarch64.dat: Remove.
8015 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8016 * regformats/i386/amd64-avx-linux.dat: Remove.
8017 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8018 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8019 * regformats/i386/amd64-linux.dat: Remove.
8020 * regformats/i386/amd64-mpx-linux.dat: Remove.
8021 * regformats/i386/amd64.dat: Remove.
8022 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8023 * regformats/i386/i386-avx-linux.dat: Remove.
8024 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8025 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8026 * regformats/i386/i386-linux.dat: Remove.
8027 * regformats/i386/i386-mmx-linux.dat: Remove.
8028 * regformats/i386/i386-mpx-linux.dat: Remove.
8029 * regformats/i386/i386.dat: Remove.
8030 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8031 * regformats/i386/x32-avx-linux.dat: Remove.
8032 * regformats/i386/x32-linux.dat: Remove.
8033
2b40fda7
AH		 80342019-07-04 Alan Hayward <alan.hayward@arm.com>
8035
8036 * aarch64-tdep.c: Remove xml self tests.
8037 * amd64-linux-tdep.c: Likewise.
8038 * amd64-tdep.c: Likewise.
8039 * i386-linux-tdep.c: Likewise.
8040 * i386-tdep.c: Likewise.
8041
5f4ba3e7
PA		 80422019-07-03 Pedro Alves <palves@redhat.com>
8043
8044 PR cli/24732
8045 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8046 (pipe_cmd_option_defs): New.
8047 (make_pipe_cmd_options_def_group): New.
8048 (pipe_command): Use gdb::option::process_options.
8049 (pipe_command_completer): New function.
8050 (_initialize_cli_cmds): Install completer for "pipe" command.
8051
3d9be6f5
PA		 80522019-07-03 Pedro Alves <palves@redhat.com>
8053
8054 * cli/cli-option.c (union option_value) <string>: New field.
8055 (struct option_def_and_value): Add ctor, move ctor, dtor and
8056 use DISABLE_COPY_AND_ASSIGN.
8057 (option_def_and_value::clear_value): New.
8058 (parse_option, save_option_value_in_ctx, get_val_type_str)
8059 (add_setshow_cmds_for_options): Handle var_string.
8060 * cli-option.h (union option_def::var_address) <string>: New
8061 field.
8062 (struct string_option_def): New.
8063 * maint-test-options.c (struct test_options_opts): Add default
8064 ctor and use DISABLE_COPY_AND_ASSIGN.
8065 <string_opt>: New field.
8066 (test_options_opts::~test_options_opts): New.
8067 (test_options_opts::dump): Also dump "-string".
8068 (test_options_option_defs): Install "string.
8069
41fc454c
PA		 80702019-07-03 Pedro Alves <palves@redhat.com>
8071
8072 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8073 option_value with a null enumeration.
8074 (complete_options): Save the option values in the context.
8075 (save_option_value_in_ctx): New, factored out from ...
8076 (process_options): ... here.
8077 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8078 of the function.
8079 * maint-test-options.c (test_options_opts::dump): New, factored
8080 out from ...
8081 (maintenance_test_options_command_mode): ... here.
8082 (maintenance_test_options_command_completion_result): Delete.
8083 (maintenance_test_options_command_completion_text): Update
8084 comment.
8085 (maintenance_show_test_options_completion_result): Change
8086 prototype. Just print
8087 maintenance_test_options_command_completion_text.
8088 (save_completion_result): New.
8089 (maintenance_test_options_completer_mode): Pass options context to
8090 complete_options, and then save a dump.
8091 (_initialize_maint_test_options): Use add_cmd to install "maint
8092 show test-options-completion-result".
8093
fdbc9870
PA		 80942019-07-03 Pedro Alves <palves@redhat.com>
8095
8096 * NEWS (New commands): Mention "with" and "maint with".
8097 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8098 (with_command, with_command_completer): New.
8099 (pipe_command): Adjust to new repeat_previous
8100 interface.
8101 (_initialize_cli_cmds): Install the "with" command and its "w"
8102 alias.
8103 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8104 declarations.
8105 * cli/cli-setshow.c (parse_cli_var_uinteger)
8106 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8107 argument strings for all var_types.
8108 (get_setshow_command_value_string): New, factored out from ...
8109 (do_show_command): ... this.
8110 * cli/cli-setshow.h: Include <string>.
8111 (get_setshow_command_value_string): Declare.
8112 * command.h (repeat_previous): Now returns const char *. Adjust
8113 comment.
8114 * maint.c: Include "cli/cli-cmds.h".
8115 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8116 (_initialize_maint_cmds): Register the "maintenance with" command.
8117 * top.c (repeat_previous): Move bits from pipe_command here:
8118 Return the saved command line, if any; error out if there's no
8119 command to relaunch.
8120
c6ac8931
PA		 81212019-07-03 Pedro Alves <palves@redhat.com>
8122
8123 * NEWS (New commands): Mention "maint set/show test-settings"
8124 instead of "maint test-settings".
8125 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8126 (maintenance_test_settings_set_list): Rename to ...
8127 (maintenance_set_test_settings_list): ... this.
8128 (maintenance_test_settings_show_list): Rename to ...
8129 (maintenance_show_test_settings_list): ... this.
8130 (maintenance_test_settings_cmd): Delete.
8131 (maintenance_test_settings_set_cmd): ...
8132 (maintenance_set_test_settings_cmd): ... this.
8133 (maintenance_test_settings_show_cmd): ...
8134 (maintenance_show_test_settings_cmd): ... this.
8135 (maintenance_test_settings_show_value_cmd):
8136 (maintenance_show_test_settings_value_cmd): ... this.
8137 (_initialize_maint_test_settings): No longer install the "maint
8138 test-settings" prefix command. Rename "maint test-settings set"
8139 to "maint set test-settings", and "maint test-settings show" to
8140 "maint show test-settings". Adjust all subcommands.
8141
d1fcf2fd
PA		 81422019-07-03 Pedro Alves <palves@redhat.com>
8143
8144 * maint-test-settings.c: Fix file's intro comment. Replace all
8145 references to "test-options" with references to "test-settings",
8146 in comments.
8147
970f9d09
PA		 81482019-07-03 Pedro Alves <palves@redhat.com>
8149
8150 * maint-test-settings.c (maintenance_test_settings_xxx)
8151 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8152 New.
8153 (maintenance_test_settings_enums): Use them.
8154 (maintenance_test_settings_enum): Default to
8155 maintenance_test_settings_xxx.
8156 (_initialize_maint_test_settings): Initialize
8157 MAINTENANCE_TEST_SETTINGS_FILENAME.
8158
f3869b1a
SM		 81592019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8160
8161 * breakpoint.h (remove_breakpoints_inf): Change return type to
8162 void, move function documentation here.
8163 * breakpoint.c (remove_breakpoints_inf): Change return type to
8164 void, move function documentation to header.
8165
54d66006
PA		 81662019-07-02 Pedro Alves <palves@redhat.com>
8167
8168 * NEWS (Completion improvements): Mention "info threads".
8169 * thread.c (struct info_threads_opts, info_threads_option_defs)
8170 (make_info_threads_options_def_group): New.
8171 (info_threads_command): Use gdb::option::process_options.
8172 (info_threads_command_completer): New.
8173 (_initialize_thread): Use gdb::option::build_help to build the
8174 help text for "info threads".
8175
854f6088
SM		 81762019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8177
8178 * defs.h (generic_load): Move from here...
8179 * symfile.h (generic_load): ... to here. Rename name parameter
8180 to args.
8181 * symfile.c (generic_load): Add comment.
8182
54ee4252
TT		 81832019-07-01 Tom Tromey <tromey@adacore.com>
8184
8185 * dwarf2read.c
8186 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8187 declaration of without_params. Fix formatting.
8188
65392b3e
TT		 81892019-07-01 Tom Tromey <tromey@adacore.com>
8190
8191 * ada-exp.y (find_primitive_type): Update.
8192 * ada-lang.h (ada_lookup_symbol): Update.
8193 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8194 parameter.
8195 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8196
7d7571f0
SDJ		 81972019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8198
8199 PR breakpoints/24541
8200 * gdbarch.c: Regenerate.
8201 * gdbarch.h: Regenerate.
8202 * gdbarch.sh: Add 'stap_adjust_register'.
8203 * i386-tdep.c: Include '<unordered_set>'.
8204 (i386_stap_adjust_register): New function.
8205 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8206 * stap-probe.c (stap_parse_register_operand): Call
8207 'gdbarch_stap_adjust_register'.
8208
5af5392a
SDJ		 82092019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8210
8211 PR python/24742
8212 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8213 * python/python.c (do_start_initialization): Use 'xmalloc'
8214 instead of 'PyMem_Malloc'.
8215
10d06d82
TT		 82162019-06-28 Tom Tromey <tromey@adacore.com>
8217
8218 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8219 for Ada.
8220
1b7f24cd
TT		 82212019-06-27 Tom Tromey <tromey@adacore.com>
8222
8223 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8224 objfile_key.
8225 (arm_find_mapping_symbol, arm_record_special_symbol)
8226 (_initialize_arm_tdep): Update.
8227 (arm_objfile_data_free): Remove.
8228
3d507ff2
TT		 82292019-06-27 Tom Tromey <tromey@adacore.com>
8230
8231 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8232 to cp_print_static_field.
8233
762c164d
TT		 82342019-06-26 Tom Tromey <tromey@adacore.com>
8235
8236 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8237 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8238 declare.
8239
aa2f9bcf
AH		 82402019-06-26 Alan Hayward <alan.hayward@arm.com>
8241
8242 * features/aarch64-core.c (create_feature_aarch64_core):
8243 Regenerate.
8244 * features/aarch64-core.xml: Add cpsr flags.
8245
3426ae57
AH		 82462019-06-26 Alan Hayward <alan.hayward@arm.com>
8247
8248 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8249 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8250
4838e44c
SM		 82512019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8252
8253 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8254 field.
8255 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8256 use.
8257 (arm_record_special_symbol): Don't insert new symbol in sorted
8258 position, push it at the end.
8259
54cc7474
SM		 82602019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8261
8262 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8263 (arm_mapping_symbol_s): Remove.
8264 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8265 (arm_mapping_symbol_vec): New typedef.
8266 (struct arm_per_objfile): Add constructor.
8267 <section_maps>: Change type to
8268 std::unique_ptr<arm_mapping_symbol_vec[]>.
8269 (arm_compare_mapping_symbols): Remove.
8270 (arm_find_mapping_symbol): Adjust to section_maps type change.
8271 (arm_objfile_data_free): Call delete on arm_per_objfile.
8272 (arm_record_special_symbol): Adjust to section_maps type change.
8273 Allocate arm_per_objfile with new.
8274
b65b566c
PW		 82752019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8276
8277 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8278 with the command prefix.
8279
c2fc64f5
TT		 82802019-06-25 Tom Tromey <tom@tromey.com>
8281
8282 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8283 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8284
fb54fa76
TT		 82852019-06-25 Tom Tromey <tom@tromey.com>
8286
8287 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8288 type.
8289 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8290 protected.
8291
f7952c57
TT		 82922019-06-25 Tom Tromey <tom@tromey.com>
8293
8294 * tui/tui-winsource.c
8295 (tui_source_window_base::set_is_exec_point_at): Add check against
8296 LOA_ADDRESS.
8297
17568d78
TT		 82982019-06-25 Tom Tromey <tom@tromey.com>
8299
8300 * tui/tui-source.c (tui_set_source_content): Don't check before
8301 xfree.
8302 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8303
53e7cdba
TT		 83042019-06-25 Tom Tromey <tom@tromey.com>
8305
8306 * tui/tui-winsource.h (tui_update_source_window_as_is)
8307 (tui_alloc_source_buffer, tui_line_is_displayed)
8308 (tui_addr_is_displayed): Change type of win_info.
8309 * tui/tui-winsource.c (tui_update_source_window_as_is)
8310 (tui_clear_source_content, tui_show_source_line)
8311 (tui_show_source_content, tui_source_window_base::refill)
8312 (tui_source_window_base::set_is_exec_point_at)
8313 (tui_source_window_base::set_is_exec_point_at)
8314 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8315 (tui_alloc_source_buffer, tui_line_is_displayed)
8316 (tui_addr_is_displayed): Change type of win_info. Update.
8317 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8318 (tui_source_window_base::do_make_visible_with_new_height):
8319 Update.
8320 * tui/tui-source.c (tui_set_source_content)
8321 (tui_set_source_content_nil)
8322 (tui_source_window::do_scroll_vertical): Update.
8323 * tui/tui-layout.c (show_layout): Update.
8324 * tui/tui-disasm.c (tui_set_disassem_content)
8325 (tui_disasm_window::do_scroll_vertical): Update.
8326 * tui/tui-data.h (tui_win_content): Remove.
8327 (struct tui_gen_win_info) <content, content_size>: Remove.
8328 (struct tui_source_element): Add initializers and destructor.
8329 (union tui_which_element, struct tui_win_element): Remove.
8330 (struct tui_source_window_base) <content>: New field.
8331 (struct tui_data_window): Remove destructor.
8332 (tui_alloc_content, tui_free_win_content)
8333 (tui_free_all_source_wins_content): Don't declare.
8334 * tui/tui-data.c (tui_initialize_static_data): Update.
8335 (init_content_element, tui_alloc_content): Remove.
8336 (~tui_gen_win_info): Update.
8337 (~tui_data_window, tui_free_all_source_wins_content)
8338 (tui_free_win_content, free_content, free_content_elements):
8339 Remove.
8340
7908abbf
TT		 83412019-06-25 Tom Tromey <tom@tromey.com>
8342
8343 * tui/tui-winsource.h (tui_clear_source_content)
8344 (tui_erase_source_content, tui_show_source_content): Change type
8345 of win_info.
8346 * tui/tui-winsource.c (tui_clear_source_content)
8347 (tui_erase_source_content, tui_show_source_content): Change type
8348 of win_info.
8349 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8350 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8351 win_info.
8352 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8353 win_info.
8354 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8355
02c28df0
TT		 83562019-06-25 Tom Tromey <tom@tromey.com>
8357
8358 * tui/tui-winsource.c (tui_clear_source_content)
8359 (tui_source_window_base::set_is_exec_point_at): Update.
8360 * tui/tui-source.c (tui_set_source_content_nil): Update.
8361 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8362 a bool.
8363 * tui/tui-data.c (init_content_element): Update.
8364
6658b1bf
TT		 83652019-06-25 Tom Tromey <tom@tromey.com>
8366
8367 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8368 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8369 * tui/tui-layout.c (init_and_make_win): Update.
8370 * tui/tui.h (enum tui_win_type): Update.
8371 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8372 tui_win_is_auxillary.
8373 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8374 tui_win_is_auxillary.
8375
21e1c91e
TT		 83762019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8379 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8380 (tui_delete_data_content_windows, tui_display_all_data)
8381 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8382 Update.
8383 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8384 * tui/tui-regs.c (tui_last_regs_line_no)
8385 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8386 (tui_show_registers): Update.
8387 (tui_show_register_group): Return void. Update.
8388 (tui_display_registers_from, tui_display_reg_element_at_line)
8389 (tui_display_registers_from_line, tui_check_register_values):
8390 Update.
8391 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8392 member.
8393 (struct tui_data_window) <regs_content>: Now a std::vector.
8394 <regs_content_count>: Remove.
8395 (tui_add_content_elements, tui_free_data_content): Don't declare.
8396 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8397 (init_content_element): Remove DATA_WIN case. Add assert.
8398 (tui_add_content_elements): Remove.
8399 (tui_data_window): Update.
8400 (tui_free_data_content): Remove.
8401 (free_content_elements): Remove DATA_WIN case.
8402
115ac53b
TT		 84032019-06-25 Tom Tromey <tom@tromey.com>
8404
8405 * tui/tui-data.c (tui_data_item_window): Update.
8406 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8407 * tui/tui-windata.c (tui_display_all_data)
8408 (tui_display_data_from_line): Update.
8409 (tui_check_data_values): Remove.
8410 * tui/tui-regs.c (tui_show_register_group)
8411 (tui_display_reg_element_at_line): Update.
8412 * tui/tui-hooks.c (tui_register_changed)
8413 (tui_refresh_frame_and_register_information): Call
8414 tui_check_register_values.
8415 * tui/tui-data.h (struct tui_data_window) <data_content,
8416 data_content_count, data_type>: Remove.
8417 (enum tui_data_type): Remove.
8418
8419 * tui/tui-data.c (tui_data_window::clear_detail)
8420 (~tui_data_window): Update.
8421
eaf9738b
TT		 84222019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8425 declare.
8426 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8427 Rename from tui_first_data_item_displayed. Update.
8428 (tui_data_window::refresh_all)
8429 (tui_data_window::do_scroll_vertical): Update.
8430 * tui/tui-data.h (struct tui_data_window)
8431 <first_data_item_displayed>: Declare new method.
8432
31ca4723
TT		 84332019-06-25 Tom Tromey <tom@tromey.com>
8434
8435 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8436 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8437 contents...
8438 (tui_initialize_static_data): ...here.
8439
41bcff7f
TT		 84402019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8443 (tui_display_registers_from, tui_check_register_values): Update.
8444 (tui_display_register): Remove win_info parameter; update.
8445 (tui_get_register): Change type of parameters.
8446 * tui/tui-data.h (struct tui_data_element): Remove.
8447 (union tui_which_element) <data>: Remove.
8448 <data_window>: Change type.
8449 (struct tui_data_item_window): New.
8450 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8451 case. Add assert.
8452 (~tui_data_item_window): New destructor.
8453 (free_content_elements): Remove DATA_ITEM_WIN case.
8454
d2802c33
TT		 84552019-06-25 Tom Tromey <tom@tromey.com>
8456
8457 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8458 Remove.
8459
dd835f8b
TT		 84602019-06-25 Tom Tromey <tom@tromey.com>
8461
8462 * tui/tui-data.h (struct tui_command_element): Remove.
8463 (union tui_which_element) <command>: Remove.
8464 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8465 assert.
8466 (free_content_elements): Remove CMD_WIN case.
8467
bd7db367
TT		 84682019-06-25 Tom Tromey <tom@tromey.com>
8469
8470 * tui/tui-layout.c (tui_set_layout): Update.
8471 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8472 * tui/tui-data.c (layout_def): Update.
8473
3add462f
TT		 84742019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8477 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8478 (tui_source_window_base::set_new_height): Update.
8479 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8480 Update.
8481 (tui_set_locator_fullname, tui_set_locator_info)
8482 (tui_show_frame_info): Update.
8483 * tui/tui-source.c (tui_set_source_content)
8484 (tui_source_is_displayed): Update.
8485 * tui/tui-layout.c (show_source_disasm_command, show_data)
8486 (show_source_or_disasm_and_command): Update.
8487 * tui/tui-disasm.c (tui_set_disassem_content)
8488 (tui_get_begin_asm_address): Update.
8489 * tui/tui-data.h (struct tui_locator_element): Remove.
8490 (union tui_which_element) <locator>: Remove.
8491 (struct tui_locator_window): New.
8492 (tui_locator_win_info_ptr): Change return type.
8493 * tui/tui-data.c (_locator): Change type.
8494 (tui_locator_win_info_ptr): Change return type.
8495 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8496 (tui_alloc_content): Add assert.
8497
489e9d8b
TT		 84982019-06-25 Tom Tromey <tom@tromey.com>
8499
8500 * tui/tui-winsource.c
8501 (tui_exec_info_window::maybe_allocate_content): New method.
8502 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8503 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8504 (make_source_or_disasm_window): Add cast.
8505 * tui/tui-data.h (union tui_which_element) <simple_string>:
8506 Remove.
8507 (struct tui_source_info): New.
8508 (struct tui_source_window_base) <execution_info>: Change type.
8509 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8510 case, and add assert.
8511 (tui_alloc_content): Add assert.
8512
c3fabb7d
TT		 85132019-06-25 Tom Tromey <tom@tromey.com>
8514
8515 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8516 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8517 * tui/tui-data.c (tui_alloc_win_info): Remove.
8518
bbc228ee
TT		 85192019-06-25 Tom Tromey <tom@tromey.com>
8520
8521 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8522 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8523 can_highlight.
8524
5fcee43a
TT		 85252019-06-25 Tom Tromey <tom@tromey.com>
8526
8527 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8528 make_visible_with_new_height method.
8529 (tui_win_info::make_visible_with_new_height): New method.
8530 (tui_source_window_base::do_make_visible_with_new_height)
8531 (tui_data_window::do_make_visible_with_new_height)
8532 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8533 (make_visible_with_new_height): Remove.
8534 (tui_resize_all, tui_adjust_win_heights): Use
8535 make_visible_with_new_height method.
8536 * tui/tui-data.h (struct tui_win_info)
8537 <do_make_visible_with_new_height, make_visible_with_new_height>:
8538 New methods.
8539 (struct tui_source_window_base, struct tui_data_window)
8540 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8541 methods.
8542
d83f1fe6
TT		 85432019-06-25 Tom Tromey <tom@tromey.com>
8544
8545 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8546 method.
8547 (update_tab_width): Call update_tab_width method.
8548 * tui/tui-data.h (struct tui_win_info)
8549 (struct tui_source_window_base) <update_tab_width>: New methods.
8550
17374de4
TT		 85512019-06-25 Tom Tromey <tom@tromey.com>
8552
8553 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8554 parameter.
8555 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8556 parameter.
8557 (tui_gen_win_info::make_visible): Update.
8558 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8559 parameter.
8560 * tui/tui-data.h (enum tui_box): New enum.
8561 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8562
f936bca2
TT		 85632019-06-25 Tom Tromey <tom@tromey.com>
8564
8565 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8566 init_and_make_win for EXEC_INFO_WIN.
8567 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8568 longer inline.
8569 (struct tui_win_info) <~tui_win_info>: Inline.
8570 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8571 Don't declare.
8572 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8573 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8574 Remove.
8575 (tui_initialize_static_data): Update.
8576 (~tui_gen_win_info): Handle more cleanup here.
8577 (~tui_source_window_base): Delete "execution_info".
8578 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8579
d6ba6a11
TT		 85802019-06-25 Tom Tromey <tom@tromey.com>
8581
8582 * tui/tui-layout.c (make_command_window): Don't set
8583 can_highlight.
8584 (show_source_disasm_command): Call the reset method.
8585 (show_data): Don't set can_highlight. Call the reset method.
8586 (tui_gen_win_info::reset): Rename from init_gen_win_info
8587 (init_and_make_win): Simplify. Return tui_gen_win_info.
8588 (show_source_or_disasm_and_command): Call the reset method.
8589 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8590 (struct tui_cmd_window): Set can_highlight.
8591
48a3bd16
TT		 85922019-06-25 Tom Tromey <tom@tromey.com>
8593
8594 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8595 from make_visible.
8596 (tui_make_visible, tui_make_invisible): Rewrite.
8597 (tui_win_info::make_visible): Remove.
8598 (tui_source_window_base::make_visible): Update.
8599 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8600 method. Moved from...
8601 (struct tui_win_info) <make_visible>: ...here.
8602
c3bd716f
TT		 86032019-06-25 Tom Tromey <tom@tromey.com>
8604
8605 * tui/tui-winsource.c
8606 (tui_source_window_base::do_scroll_horizontal): Remove direction
8607 parameter.
8608 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8609 direction parameter.
8610 * tui/tui-win.c (tui_win_info::forward_scroll)
8611 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8612 (tui_win_info::right_scroll): Update.
8613 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8614 direction parameter.
8615 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8616 direction parameter.
8617 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8618 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8619 Remove direction parameter.
8620 (struct tui_source_window_base, struct tui_source_window)
8621 (struct tui_disasm_window, struct tui_data_window)
8622 (struct tui_cmd_window): Update.
8623
21c32dca
TT		 86242019-06-25 Tom Tromey <tom@tromey.com>
8625
8626 * tui/tui-winsource.h (tui_set_exec_info_content)
8627 (tui_show_exec_info_content, tui_erase_exec_info_content)
8628 (tui_clear_exec_info_content, tui_update_exec_info): Change
8629 argument to tui_source_window_base.
8630 * tui/tui-winsource.c (tui_set_exec_info_content)
8631 (tui_show_exec_info_content, tui_erase_exec_info_content)
8632 (tui_clear_exec_info_content, tui_update_exec_info): Change
8633 argument to tui_source_window_base.
8634
73fbdc65
TT		 86352019-06-25 Tom Tromey <tom@tromey.com>
8636
8637 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8638 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8639
33325343
TT		 86402019-06-25 Tom Tromey <tom@tromey.com>
8641
8642 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8643 check.
8644
29d2c474
TT		 86452019-06-25 Tom Tromey <tom@tromey.com>
8646
8647 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8648 type to void.
8649 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8650 type to void.
8651 * tui/tui-source.c (tui_set_source_content): Update.
8652 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8653
152f3f4b
TT		 86542019-06-25 Tom Tromey <tom@tromey.com>
8655
8656 * tui/tui-win.c (window_name_completer, tui_set_focus)
8657 (tui_all_windows_info): Use name method.
8658 * tui/tui-data.h (struct tui_gen_win_info)
8659 (struct tui_source_window, struct tui_disasm_window)
8660 (struct tui_data_window, struct tui_cmd_window) <name>: New
8661 method.
8662 (tui_win_name): Don't declare.
8663 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8664 (tui_win_name): Remove.
8665
be4da588
TT		 86662019-06-25 Tom Tromey <tom@tromey.com>
8667
8668 * tui/tui-winsource.h (tui_update_source_window)
8669 (tui_update_source_window_as_is): Change parameter type.
8670 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8671 to be a tui_source_window_base.
8672 (tui_update_source_window_as_is): Likewise.
8673 * tui/tui-win.c (make_visible_with_new_height): Update.
8674
5b81daba
TT		 86752019-06-25 Tom Tromey <tom@tromey.com>
8676
8677 * tui/tui-winsource.c (tui_erase_source_content)
8678 (tui_show_source_content, tui_show_exec_info_content)
8679 (tui_erase_exec_info_content): Use refresh_window method.
8680 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8681 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8682 from tui_refresh_win.
8683 (tui_data_window::refresh_window): New method.
8684 (tui_win_info::refresh, tui_source_window_base::refresh)
8685 (tui_refresh_all): Use refresh_window method.
8686 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8687 method.
8688 * tui/tui-regs.c (tui_display_register): Call refresh_window
8689 method.
8690 * tui/tui-layout.c (show_source_disasm_command)
8691 (show_source_or_disasm_and_command): Call refresh_window method.
8692 * tui/tui-data.h (struct tui_gen_win_info)
8693 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8694 New method.
8695
cb2ce893
TT		 86962019-06-25 Tom Tromey <tom@tromey.com>
8697
8698 * tui/tui.c (tui_rl_other_window, tui_enable)
8699 (tui_is_window_visible, tui_get_command_dimension): Update.
8700 * tui/tui-winsource.c (tui_update_source_window_as_is)
8701 (tui_clear_source_content, tui_erase_source_content)
8702 (tui_show_source_line, tui_source_window_base::refill)
8703 (tui_source_window_base::do_scroll_horizontal)
8704 (tui_source_window_base::set_is_exec_point_at)
8705 (tui_update_breakpoint_info, tui_set_exec_info_content)
8706 (tui_alloc_source_buffer, tui_line_is_displayed)
8707 (tui_addr_is_displayed): Update.
8708 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8709 (tui_check_and_display_highlight_if_needed)
8710 (tui_win_info::make_visible, tui_win_info::refresh)
8711 (tui_refresh_all): Update.
8712 * tui/tui-windata.c (tui_first_data_item_displayed)
8713 (tui_delete_data_content_windows, tui_erase_data_content)
8714 (tui_display_all_data, tui_data_window::refresh_all)
8715 (tui_check_data_values): Update.
8716 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8717 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8718 (tui_win_info::backward_scroll, tui_refresh_all_win)
8719 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8720 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8721 (tui_source_window_base::set_new_height)
8722 (tui_data_window::set_new_height)
8723 (make_invisible_and_set_new_height)
8724 (make_visible_with_new_height, new_height_ok)
8725 (parse_scrolling_args): Update.
8726 * tui/tui-stack.c (tui_show_frame_info): Update.
8727 * tui/tui-source.c (tui_set_source_content)
8728 (tui_set_source_content_nil, tui_source_is_displayed)
8729 (tui_source_window::do_scroll_vertical): Update.
8730 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8731 (tui_display_registers_from, tui_display_reg_element_at_line)
8732 (tui_check_register_values, tui_reg_command): Update.
8733 * tui/tui-layout.c (tui_default_win_height)
8734 (show_source_disasm_command, show_data, init_and_make_win)
8735 (show_source_or_disasm_and_command): Update.
8736 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8737 (tui_redisplay_readline, tui_mld_flush)
8738 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8739 (tui_getc): Update.
8740 * tui/tui-disasm.c (tui_set_disassem_content)
8741 (tui_disasm_window::do_scroll_vertical): Update.
8742 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8743 Now virtual.
8744 (struct tui_win_info): Derive from tui_gen_win_info.
8745 <~tui_win_info>: Mark as override.
8746 <generic>: Remove member.
8747 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8748 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8749 (~tui_data_window, ~tui_win_info)
8750 (tui_free_all_source_wins_content): Update.
8751 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8752
ab313b35
TT		 87532019-06-25 Tom Tromey <tom@tromey.com>
8754
8755 * tui/tui-layout.c (init_and_make_win): Use new.
8756 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8757 destructor, initializers.
8758 (tui_alloc_generic_win_info): Don't declare.
8759 * tui/tui-data.c (_locator): Add argument to constructor.
8760 (source_win, disasm_win): New globals.
8761 (exec_info): Remove.
8762 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8763 Update.
8764 (tui_alloc_generic_win_info): Remove.
8765 (init_content_element): Use new.
8766 (tui_win_info::tui_win_info): Update.
8767 (free_content_elements) <case DATA_WIN>: Use delete.
8768
dc2c33e4
TT		 87692019-06-25 Tom Tromey <tom@tromey.com>
8770
8771 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8772 * tui/tui-windata.c (tui_first_data_item_displayed)
8773 (tui_delete_data_content_windows): Update.
8774 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8775 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8776 (tui_display_registers_from, tui_check_register_values): Update.
8777 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8778 pointer.
8779 * tui/tui-data.c (init_content_element): Update. Allocate the new
8780 window.
8781 (tui_free_data_content): Update.
8782 (free_content_elements) <case DATA_WIN>: Free the window.
8783
214a5cbe
TT		 87842019-06-25 Tom Tromey <tom@tromey.com>
8785
8786 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8787 Update.
8788 * tui/tui-layout.c (make_command_window)
8789 (show_source_disasm_command, show_data, init_and_make_win)
8790 (show_source_or_disasm_and_command): Update.
8791 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8792 method.
8793 <can_highight, is_highlighted>: Now bool.
8794 (tui_set_win_highlight): Don't declare.
8795 * tui/tui-data.c (tui_set_win_highlight): Remove.
8796
8e2daf15
TT		 87972019-06-25 Tom Tromey <tom@tromey.com>
8798
8799 * tui/tui-wingeneral.c (make_visible): Remove check of window
8800 type.
8801
8903bd8a
TT		 88022019-06-25 Tom Tromey <tom@tromey.com>
8803
8804 * tui/tui-win.c (tui_win_info::max_height)
8805 (tui_cmd_window::max_height): New methods.
8806 (new_height_ok): Call max_height.
8807 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8808 <max_height>: New method.
8809
3f02ce1e
TT		 88102019-06-25 Tom Tromey <tom@tromey.com>
8811
8812 * tui/tui-win.c (tui_source_window_base::set_new_height)
8813 (tui_data_window::set_new_height): New methods.
8814 (make_invisible_and_set_new_height): Call set_new_height method.
8815 * tui/tui-data.h (struct tui_win_info)
8816 (struct tui_source_window_base, struct tui_data_window)
8817 <set_new_height>: New method.
8818
1825f487
TT		 88192019-06-25 Tom Tromey <tom@tromey.com>
8820
8821 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8822 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8823 tui_refresh_data_win.
8824 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8825 method.
8826 (tui_refresh_all_win): Call the refresh_all method.
8827 (tui_set_focus): Likewise.
8828 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8829 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8830 Likewise.
8831
ad54d15b
TT		 88322019-06-25 Tom Tromey <tom@tromey.com>
8833
8834 * tui/tui-winsource.h (tui_refill_source_window)
8835 (tui_set_is_exec_point_at): Don't declare.
8836 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8837 (tui_source_window_base::refill): Rename from
8838 tui_refill_source_window.
8839 (tui_source_window_base::do_scroll_horizontal): Update.
8840 (tui_source_window_base::set_is_exec_point_at): Rename from
8841 tui_set_is_exec_point_at.
8842 (tui_update_all_breakpoint_info): Update.
8843 * tui/tui-stack.c (tui_show_frame_info): Update.
8844 * tui/tui-layout.c (show_data): Add cast.
8845 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8846 * tui/tui-data.h (struct tui_source_window_base) <refill,
8847 set_is_exec_point_at>: New methods.
8848 (tui_source_windows, tui_add_to_source_windows): Update types.
8849 (tui_add_to_source_windows): Remove redundant declaration.
8850 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8851 (tui_source_windows): Change return type.
8852 (tui_clear_source_windows_detail): Update.
8853 (tui_add_to_source_windows): Change type of parameter.
8854 (tui_free_all_source_wins_content): Update.
8855
2042b506
TT		 88562019-06-25 Tom Tromey <tom@tromey.com>
8857
8858 * tui/tui-wingeneral.c (tui_win_info::refresh)
8859 (tui_source_window_base::refresh): New methods.
8860 (tui_refresh_all): Call the refresh method.
8861 * tui/tui-data.h (struct tui_win_info)
8862 (struct tui_source_window_base) <refresh>: New method.
8863
56122977
TT		 88642019-06-25 Tom Tromey <tom@tromey.com>
8865
8866 * tui/tui.h (tui_is_window_visible): Return bool.
8867 * tui/tui.c (tui_is_window_visible): Return bool.
8868 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8869 (tui_make_visible, tui_make_invisible)
8870 (tui_win_info::make_visible)
8871 (tui_source_window_base::make_visible, make_all_visible)
8872 (tui_make_all_visible, tui_make_all_invisible): Update.
8873 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8874 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8875 bool.
8876 (struct tui_win_info, struct tui_source_window_base)
8877 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8878 * tui/tui-data.c (tui_init_generic_part): Update.
8879
cda37efb
TT		 88802019-06-25 Tom Tromey <tom@tromey.com>
8881
8882 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8883 (tui_source_window_base::make_visible): New methods.
8884 (make_all_visible): Make method call.
8885 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8886 (struct tui_source_window_base, struct tui_cmd_window): Override
8887 make_visible.
8888 (tui_win_is_source_type): Don't declare.
8889 * tui/tui-data.c (tui_win_is_source_type): Remove.
8890
6a0ee02c
TT		 88912019-06-25 Tom Tromey <tom@tromey.com>
8892
8893 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8894 NULL check.
8895
63901aec
TT		 88962019-06-25 Tom Tromey <tom@tromey.com>
8897
8898 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8899 Inline constructor. Add initializers for members.
8900 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8901 constructors; now inline in class.
8902
ceb13a13
TT		 89032019-06-25 Tom Tromey <tom@tromey.com>
8904
8905 * tui/tui-regs.c (tui_show_registers): Update.
8906 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8907 bool.
8908 * tui/tui-data.c (tui_data_window::clear_detail)
8909 (tui_data_window): Update.
8910
238eb706
TT		 89112019-06-25 Tom Tromey <tom@tromey.com>
8912
8913 * tui/tui-windata.c (tui_display_all_data)
8914 (tui_display_data_from_line, tui_display_data_from)
8915 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8916 Update.
8917 * tui/tui-regs.c (tui_last_regs_line_no)
8918 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8919 (tui_show_registers, tui_show_register_group)
8920 (tui_display_registers_from, tui_display_reg_element_at_line)
8921 (tui_display_registers_from_line, tui_check_register_values)
8922 (tui_reg_next, tui_reg_prev): Update.
8923 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8924 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8925 tui_data_window.
8926 (struct tui_win_info) <detail>: Remove. Add new fields from
8927 tui_data_info.
8928 (TUI_DATA_WIN): Add cast.
8929 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8930 (~tui_data_window): Simplify.
8931
81491aa0
TT		 89322019-06-25 Tom Tromey <tom@tromey.com>
8933
8934 * tui/tui-layout.c (show_source_disasm_command)
8935 (show_source_or_disasm_and_command): Update.
8936 * tui/tui-io.c (update_cmdwin_start_line)
8937 (tui_redisplay_readline): Update.
8938 * tui/tui-data.h (struct tui_command_info): Remove.
8939 (struct tui_win_info) <detail>: Remove command_info member.
8940 (struct tui_data_window) <start_line>: New member, from
8941 tui_command_info.
8942 (TUI_CMD_WIN): Add casts.
8943
e6e41501
TT		 89442019-06-25 Tom Tromey <tom@tromey.com>
8945
8946 * tui/tui-winsource.c (tui_update_source_window)
8947 (tui_refill_source_window)
8948 (tui_source_window_base::do_scroll_horizontal)
8949 (tui_update_breakpoint_info, tui_set_exec_info_content)
8950 (tui_show_exec_info_content, tui_erase_exec_info_content)
8951 (tui_clear_exec_info_content): Update.
8952 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8953 Update.
8954 * tui/tui-win.c (make_invisible_and_set_new_height)
8955 (make_visible_with_new_height): Update.
8956 * tui/tui-source.c (tui_set_source_content)
8957 (tui_show_symtab_source): Update.
8958 * tui/tui-layout.c (extract_display_start_addr)
8959 (show_source_disasm_command, show_data)
8960 (make_source_or_disasm_window)
8961 (show_source_or_disasm_and_command): Update.
8962 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8963 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8964 "gdbarch".
8965 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8966 to tui_source_window_base.
8967 (struct tui_win_info) <detail>: Remove source_info member.
8968 (struct tui_source_window_base) <has_locator>: Inline.
8969 Move contents from tui_source_info; rename has_locator member to
8970 m_has_locator.
8971 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8972 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8973 header file.
8974 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8975 Simplify.
8976 (tui_free_all_source_wins_content): Cast to
8977 tui_source_window_base.
8978
44f0e208
TT		 89792019-06-25 Tom Tromey <tom@tromey.com>
8980
8981 * tui/tui-win.c (make_invisible_and_set_new_height)
8982 (make_visible_with_new_height): Call has_locator method.
8983 * tui/tui-layout.c (show_source_disasm_command, show_data)
8984 (show_source_or_disasm_and_command): Update for bool change.
8985 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8986 (tui_win_info) <has_locator>: New method.
8987 (struct tui_source_window_base) <has_locator>: New method.
8988 (tui_win_has_locator): Don't declare.
8989 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8990 from tui_win_has_locator.
8991 (tui_source_window_base): Use false, not FALSE.
8992
7778b912
TT		 89932019-06-25 Tom Tromey <tom@tromey.com>
8994
8995 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8996 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8997 clear_detail method directly.
8998 (tui_clear_win_detail): Remove.
8999
f83d391c
TT		 90002019-06-25 Tom Tromey <tom@tromey.com>
9001
9002 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9003 "this", not TUI_DISASM_WIN.
9004
13446e05
TT		 90052019-06-25 Tom Tromey <tom@tromey.com>
9006
9007 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9008 declare.
9009 * tui/tui-winsource.c
9010 (tui_source_window_base::do_scroll_horizontal): Rename from
9011 tui_horizontal_source_scroll.
9012 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9013 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9014 from tui_vertical_data_scroll.
9015 * tui/tui-win.h (tui_scroll): Don't declare.
9016 * tui/tui-win.c (tui_win_info::forward_scroll)
9017 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9018 (tui_win_info::right_scroll): Rename and update.
9019 (tui_scroll_forward_command, tui_scroll_backward_command)
9020 (tui_scroll_left_command, tui_scroll_right_command): Update.
9021 (tui_scroll): Remove.
9022 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9023 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9024 from tui_vertical_source_scroll.
9025 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9026 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9027 from tui_vertical_disassem_scroll.
9028 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9029 do_scroll_horizontal>: New methods.
9030 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9031 Likewise.
9032 (struct tui_source_window_base): Add do_scroll_horizontal.
9033 (struct tui_source_window, struct tui_disasm_window): Add
9034 do_scroll_vertical.
9035 (struct tui_data_window, struct tui_cmd_window): Add
9036 do_scroll_horizontal and do_scroll_vertical.
9037 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9038
5cf82909
TT		 90392019-06-25 Tom Tromey <tom@tromey.com>
9040
9041 * tui/tui-data.h (struct tui_source_window_base): New struct.
9042 (struct tui_source_window): Derive from tui_source_window_base.
9043 (struct tui_disasm_window): New struct.
9044 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9045 from tui_source_window::clear_detail.
9046 (tui_source_window_base): Rename from tui_source_window.
9047 (~tui_source_window_base): Rename from ~tui_source_window.
9048 (tui_alloc_win_info): Create a tui_disasm_window.
9049
ee1d42d6
TT		 90502019-06-25 Tom Tromey <tom@tromey.com>
9051
9052 * tui/tui-data.h (struct tui_source_window)
9053 (struct tui_data_window): Declare destructors.
9054 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9055 destructors.
9056 (tui_win_info): Simplify.
9057
b4eb2452
TT		 90582019-06-25 Tom Tromey <tom@tromey.com>
9059
9060 * tui/tui-winsource.c (tui_display_main)
9061 (tui_update_source_windows_with_addr)
9062 (tui_update_all_breakpoint_info): Update.
9063 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9064 (new_height_ok, parse_scrolling_args): Update.
9065 * tui/tui-stack.c (tui_show_frame_info): Update.
9066 * tui/tui-data.h (struct tui_list): Remove.
9067 (tui_source_windows): Return a reference to a std::vector.
9068 * tui/tui-data.c (source_windows): Now a std::vector.
9069 (tui_source_windows): Change return type.
9070 (tui_clear_source_windows): Rewrite.
9071 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9072 (tui_free_all_source_wins_content): Rewrite.
9073
8761a91b
TT		 90742019-06-25 Tom Tromey <tom@tromey.com>
9075
9076 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9077 (struct tui_data_window, struct tui_cmd_window): Declare
9078 clear_detail method.
9079 * tui/tui-data.c (tui_source_window::clear_detail)
9080 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9081 methods.
9082 (tui_clear_win_detail): Simplify.
9083
0ed69eda
TT		 90842019-06-25 Tom Tromey <tom@tromey.com>
9085
9086 * tui/tui-layout.c (make_source_window, make_disasm_window)
9087 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9088 Return the new window.
9089 (show_source_disasm_command, show_data)
9090 (show_source_or_disasm_and_command): Update.
9091
82432e10
TT		 90922019-06-25 Tom Tromey <tom@tromey.com>
9093
9094 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9095 parameter. Return the new window.
9096 (show_source_disasm_command): Update and remove NULL check.
9097 (show_source_or_disasm_and_command): Update.
9098
ec328aa5
TT		 90992019-06-25 Tom Tromey <tom@tromey.com>
9100
9101 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9102
33b906ab
TT		 91032019-06-25 Tom Tromey <tom@tromey.com>
9104
9105 * tui/tui-data.h (struct tui_win_info): Make constructor
9106 protected. Make destructor virtual. Add initializers.
9107 (tui_source_window, tui_data_window, tui_cmd_window): New
9108 classes.
9109 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9110 constructor. Add "type" parameter.
9111 (tui_source_window, tui_data_window, tui_cmd_window): New
9112 constructors.
9113 (tui_alloc_win_info): Instantiate the appropriate subclass.
9114
e7e11af4
TT		 91152019-06-25 Tom Tromey <tom@tromey.com>
9116
9117 * tui/tui-win.c (tui_resize_all): Use delete.
9118 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9119 destructor.
9120 (tui_free_window): Don't declare.
9121 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9122 Update.
9123
6792b55e
TT		 91242019-06-25 Tom Tromey <tom@tromey.com>
9125
9126 * tui/tui-data.h (struct tui_win_info): Add constructor.
9127 * tui/tui-data.c (tui_alloc_win_info): Use new.
9128 (tui_free_window): Use delete.
9129
f95675e1
TT		 91302019-06-22 Tom Tromey <tom@tromey.com>
9131
9132 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9133 declare.
9134 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9135
5bff081c
TT		 91362019-06-22 Tom Tromey <tom@tromey.com>
9137
9138 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9139 declare.
9140 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9141
47e3f474
TV		 91422019-06-22 Tom de Vries <tdevries@suse.de>
9143
9144 * dwarf2read.c (create_addrmap_from_aranges)
9145 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9146 instead of '%zu'.
9147
fd5866f6
SM		 91482019-06-21 Simon Marchi <simon.marchi@efficios.com>
9149
9150 * dwarf2read.h (dwarf2_section_info_def): Remove.
9151 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9152 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9153 std::vector<dwarf2_section_info>.
9154 (struct dwo_file) <~dwo_file>: Remove.
9155 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9156 types field.
9157 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9158 (dwarf2_read_debug_names): Likewise.
9159 (create_debug_types_hash_table): Change parameter type to
9160 array_view, adjust code accordingly.
9161 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9162 (partial_die_info::fixup): Likewise.
9163 (determine_prefix): Likewise.
9164 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9165
fb1eb2f9
SM		 91662019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9167
9168 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9169 gdb_bfd_ref_ptr.
9170 <~dwo_file>: Remove call to gdb_bfd_unref.
9171 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9172 gdb_bfd_ref_ptr::get.
9173
51ac9db5
SM		 91742019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9175
9176 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9177 type to htab_up.
9178 * dwarf2read.c (struct dwo_file): Initialize fields.
9179 <~dwo_file>: New.
9180 (free_dwo_file): Remove, move content to ~dwo_file.
9181 (struct dwo_file_deleter): Remove.
9182 (dwo_file_up>: Remove custom deleter.
9183 (free_dwo_files): Remove.
9184 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9185 dwo_files.
9186 (process_skeletonless_type_units): Call unique_ptr::get.
9187 (allocate_dwo_file_hash_table): Add deleter to created hash
9188 table. Change return type to htab_up.
9189 (lookup_dwo_file_slot): Don't memset dwo_file, call
9190 unique_ptr::get.
9191 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9192 (create_dwo_unit_in_dwp_v2): Likewise.
9193 (open_and_init_dwo_file): Likewise.
9194 (free_dwo_file_from_slot): Remove.
9195
dc4ccb6f
SM		 91962019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9197
9198 * dwarf2read.h (struct dwarf2_section_info) <readin,
9199 is_virtual>: Change type to bool.
9200 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9201 true instead of 1.
9202
e6a1c5cb
TT		 92032019-06-19 Tom Tromey <tom@tromey.com>
9204
9205 * tui/tui-data.h (tui_init_content_element): Don't declare.
9206
6f6ffbeb
TT		 92072019-06-19 Tom Tromey <tom@tromey.com>
9208
9209 * tui/tui-data.h (tui_init_win_info): Don't declare.
9210
f23f598e
TV		 92112019-06-19 Tom de Vries <tdevries@suse.de>
9212
9213 * dwarf2read.h (abstract_to_concrete): Change type to
9214 std::unordered_map<sect_offset, std::vector<sect_offset>,
9215 gdb::hash_enum<sect_offset>>.
9216
680e1bee
TT		 92172019-06-19 Tom Tromey <tromey@adacore.com>
9218
9219 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9220 EVAL_AVOID_SIDE_EFFECTS specially.
9221
dcf37923
TT		 92222019-06-19 Tom Tromey <tromey@adacore.com>
9223
9224 * source-cache.c (highlighter): New global.
9225 (source_cache::get_source_lines): Create a highlighter on demand.
9226
494986d5
AB		 92272019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9228
9229 * defs.h (deprecated_interactive_hook): Delete declaration.
9230 * interps.c (clear_interpreter_hooks): Remove use of
9231 deprecated_interactive_hook.
9232 * top.c (deprecated_interactive_hook): Delete definition.
9233 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9234
3360b6e7
TV		 92352019-06-18 Tom de Vries <tdevries@suse.de>
9236
9237 PR gdb/24515
9238 * dwarf2read.h (abstract_to_concrete): Change type from
9239 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9240 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9241 * dwarf2read.c (read_variable): Update.
9242 (dwarf2_fetch_die_loc_sect_off): Update.
9243
310b3441
TV		 92442019-06-17 Tom de Vries <tdevries@suse.de>
9245
9246 PR gdb/24617
9247 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9248 accessing parent[parent_len - 1].
9249
ba9777be
PP		 92502019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9251
9252 PR gdb/24364
9253 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9254 call dtrace_process_dof with NULL dof.
9255
2b9f6e89
TV		 92562019-06-16 Tom de Vries <tdevries@suse.de>
9257
9258 PR gdb/24445
9259 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9260
431b3ead
TT		 92612019-06-16 Tom Tromey <tom@tromey.com>
9262
9263 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9264 (make_all_visible): Use address of member.
9265
d04b44a1
TT		 92662019-06-16 Tom Tromey <tom@tromey.com>
9267
9268 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9269 (tui_free_window, free_content, free_content_elements): Remove
9270 unnecessary cast.
9271 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9272 cast.
9273 * tui/tui-regs.c (tui_show_register_group)
9274 (tui_display_registers_from, tui_display_reg_element_at_line):
9275 Remove unnecessary cast.
9276
bf5142e7
AB		 92772019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9278
9279 * linux-nat.c (normal_mask): Delete.
9280 (_initialize_linux_nat): Don't initialise normal_mask.
9281
c4973306
SM		 92822019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9283
9284 PR gdb/24445
9285 * dwarf-index-write.h (write_psymtabs_to_index): Add
9286 dwz_basename parameter.
9287 * dwarf-index-write.c (write_gdbindex): Move file writing to
9288 write_gdbindex_1. Change return type void.
9289 (assert_file_size): Move up, remove filename parameter.
9290 (write_gdbindex_1): New function.
9291 (write_debug_names): Change return type to void, call
9292 assert_file_size.
9293 (struct index_wip_file): New struct.
9294 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9295 file logic to index_wip_file. Write index for dwz file if
9296 needed.
9297 (save_gdb_index_command): Pass basename of dwz file, if present.
9298 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9299 build-id of dwz file, if present.
9300 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9301 (dwarf2_get_dwz_file): Likewise.
9302 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9303 (dwarf2_get_dwz_file): Likewise.
9304
395f9c91
TT		 93052019-06-16 Tom Tromey <tom@tromey.com>
9306
9307 * coffread.c (process_coff_symbol): Use xstrdup.
9308 * value.c (create_internalvar): Use xstrdup.
9309
cafb3438
TT		 93102019-06-16 Tom Tromey <tom@tromey.com>
9311
9312 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9313 * breakpoint.c (stopin_command, stopat_command)
9314 (until_break_command, decode_location_default): Remove unnecessary
9315 cast.
9316 * utils.c (subset_compare): Remove unnecessary cast.
9317 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9318 cast.
9319 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9320 cast.
9321 * infcmd.c (path_command): Remove unnecessary cast.
9322 * coffread.c (decode_type): Remove unnecessary cast.
9323 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9324 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9325 * tui/tui-stack.c (tui_show_locator_content)
9326 (tui_show_frame_info): Remove unnecessary cast.
9327 * tui/tui-win.c (tui_scroll_forward_command)
9328 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9329 (parse_scrolling_args): Remove unnecessary cast.
9330 * tui/tui-data.c (init_win_info, tui_del_window)
9331 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9332 (free_content_elements): Remove unnecessary cast.
9333 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9334 unnecessary cast.
9335 * tui/tui-source.c (tui_set_source_content)
9336 (tui_vertical_source_scroll): Remove unnecessary cast.
9337 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9338 cast.
9339 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9340 * tui/tui-regs.c (tui_display_registers_from)
9341 (tui_display_register): Remove unnecessary cast.
9342 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9343 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9344 (make_visible): Remove unnecessary cast.
9345 * tui/tui-winsource.c (tui_erase_source_content)
9346 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9347 unnecessary cast.
9348 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9349 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9350 * stabsread.c (read_type, read_array_type, read_range_type):
9351 Remove unnecessary cast.
9352 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9353 (parse_symbol, parse_type, upgrade_type, parse_external)
9354 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9355 unnecessary cast.
9356 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9357
730ead81
TT		 93582019-06-16 Tom Tromey <tom@tromey.com>
9359
9360 * tui/tui-data.c (tui_alloc_generic_win_info)
9361 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9362 checks.
9363
584a927c
AB		 93642019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9365 Andrew Burgess <andrew.burgess@embecosm.com>
9366
9367 * f-typeprint.c (f_print_type): Don't return early for not
9368 associated or not allocated types.
9369 (f_type_print_varspec_suffix): Add print_rank parameter and print
9370 ranks of array types in case they dangling.
9371 (f_type_print_base): Add print_rank parameter.
9372
30056ea0
AB		 93732019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9374
9375 * NEWS: Mention new MI commands.
9376 * break-catch-throw.c (enum exception_event_kind): Move to
9377 breakpoint.h.
9378 (print_mention_exception_catchpoint): Output text as a single
9379 message.
9380 (catch_exception_command_1): Rename to...
9381 (catch_exception_event): ...this, make non-static, update header
9382 command, and change some parameter types.
9383 (catch_catch_command): Update for changes to
9384 catch_exception_command_1.
9385 (catch_throw_command): Likewise.
9386 (catch_rethrow_command): Likewise.
9387 * breakpoint.c (enum exception_event_kind): Delete.
9388 * breakpoint.h (enum exception_event_kind): Moved here from
9389 break-catch-throw.c.
9390 (catch_exception_event): Declare.
9391 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9392 (mi_cmd_catch_throw): New function.
9393 (mi_cmd_catch_rethrow): New function.
9394 (mi_cmd_catch_catch): New function.
9395 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9396 'catch-catch' entries.
9397 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9398 (mi_cmd_catch_rethrow): Declare.
9399 (mi_cmd_catch_catch): Declare.
9400
ec8e2b6d
AB		 94012019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9402
9403 * annotate.c (annotate_source_line): Change return type to void,
9404 update implementation to match.
9405 * annotate.h (annotate_source_line): Change return type to void,
9406 update header comment.
9407 * stack.c (print_frame_info): Don't change what frame information
9408 is printed based on whether annotations are on or not.
9409
0d3abd8c
AB		 94102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9411
9412 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9413 (annotate_source): Make static.
9414 (annotate_source_line): Moved from source.c and renamed from
9415 identify_source_line. Update the return type.
9416 * annotate.h (annotate_source): Delete declaration.
9417 (annotate_source_line): Declaration moved from source.h, and
9418 renamed from identify_source_line. Return type updated.
9419 * source.c (identify_source_line): Moved to annotate.c and renamed
9420 to annotate_source_line.
9421 (info_line_command): Remove check of annotation_level.
9422 * source.h (identify_source_line): Move declaration to annotate.h
9423 and rename to annotate_source_line.
9424 * stack.c: Add 'annotate.h' include.
9425 (print_frame_info): Remove check of annotation_level before
9426 calling annotate_source_line.
9427
00df30ae
AB		 94282019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9429
9430 * source-cache.c (source_cache::get_plain_source_lines): Use
9431 open_source_file_with_line_charpos instead of just
9432 open_source_file, remove call to find_source_lines.
9433 (source_cache::get_source_lines): Likewise.
9434 * source.c (find_source_lines): Make static.
9435 (get_filename_and_charpos): Renamed into...
9436 (open_source_file_with_line_charpos): ..this along with changes to
9437 return a scoped_fd, and some other minor clean ups.
9438 (identify_source_line): Use open_source_file_with_line_charpos.
9439 (search_command_helper): Use open_source_file_with_line_charpos
9440 instead of just open_source_file, remove call to
9441 find_source_lines.
9442 * source.h (open_source_file_with_line_charpos): Declare new
9443 function.
9444 (find_source_lines): Delete declaration.
9445
afda45a2
AB		 94462019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9447
9448 * source.c (get_filename_and_charpos): Remove fullname
9449 parameter.
9450 (identify_source_line): Update call to get_filename_and_charpos.
9451
0735b091
TT		 94522019-06-14 Tom Tromey <tromey@adacore.com>
9453
9454 PR gdb/24502:
9455 * ui-style.h (skip_ansi_escape): Update comment.
9456 * ui-file.h (class no_terminal_escape_file): New class.
9457 * ui-file.c (no_terminal_escape_file::write)
9458 (no_terminal_escape_file::puts): New methods.
9459 * cli/cli-logging.c (handle_redirections): Use
9460 no_terminal_escape_file.
9461
52ce35e2
TT		 94622019-06-14 Tom Tromey <tromey@adacore.com>
9463
9464 * NEWS: Move convenience variable news above Python news.
9465
73cc7272
TT		 94662019-06-14 Tom Tromey <tom@tromey.com>
9467
9468 * gnulib: Move directory to top-level.
9469 * configure.ac: Don't configure gnulib.
9470 * configure: Rebuild.
9471 * common/common-defs.h: Use new path to gnulib.
9472 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9473 (GNULIB_H): Remove.
9474 (INCGNU): Look in new gnulib location.
9475 (HFILES_NO_SRCDIR): Remove gnulib files.
9476 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9477 (generated_files): Remove GNULIB_H.
9478 ($(LIBGNU), all-lib): Remove targets.
9479 (distclean): Don't mention GNULIB_BUILDDIR.
9480 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9481
f5686554
TT		 94822019-06-14 Tom Tromey <tromey@adacore.com>
9483
9484 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9485 Warn if symbol file does not provide any symbols.
9486
a0c1ffed
TT		 94872019-06-14 Tom Tromey <tromey@adacore.com>
9488
9489 * source.c (find_and_open_source): Respect basenames_may_differ.
9490
7c39e397
AB		 94912019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9492
9493 * annotate.c (annotate_breakpoints_invalid): Make use of
9494 scoped_restore_terminal_state.
9495 (annotate_frames_invalid): Likewise.
9496
f411722c
TT		 94972019-06-14 Tom Tromey <tromey@adacore.com>
9498
9499 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9500 allow assignment to an internalvar.
9501
4268ec18
TT		 95022019-06-14 Tom Tromey <tromey@adacore.com>
9503
9504 * ada-lex.l: Allow "_" in attribute names.
9505
abdb711e
TT		 95062019-06-14 Tom Tromey <tromey@adacore.com>
9507
9508 PR gdb/24653:
9509 * regcache.c (registers_changed): Don't call alloca.
9510 * top.c (execute_command): Don't call alloca.
9511
4c048731
PA		 95122019-06-13 Pedro Alves <palves@redhat.com>
9513
9514 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9515 'expression'. When parsing an expression, error out if there's
9516 junk after "unlimited".
9517 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9518 (do_set_command): Adjust calls to is_unlimited_literal.
9519
66eb1ed3
PA		 95202019-06-13 Pedro Alves <palves@redhat.com>
9521
9522 * compile/compile.c (make_compile_options_def_group): Add braces
9523 around array_view initializer.
9524 * thread.c (make_thread_apply_all_options_def_group)
9525 (make_thread_apply_all_options_def_group): Likewise.
9526
3345721a
PA		 95272019-06-13 Pedro Alves <palves@redhat.com>
9528
9529 * NEWS (New commands): Mention "maint test-options
9530 require-delimiter", "maint test-options unknown-is-error", "maint
9531 test-options unknown-is-operand" and "maint show
9532 test-options-completion-result".
9533 (New command options, command completion): New section.
9534 (Completion improvements): New section.
9535 Mention that you can abbreviate "unlimited".
9536
6206060d
PA		 95372019-06-13 Pedro Alves <palves@redhat.com>
9538
9539 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9540 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9541 * unittests/cli-utils-selftests.c (test_parse_flags)
9542 (test_parse_flags_qcs): Delete.
9543 (test_cli_utils): Don't call deleted functions.
9544
6665660a
PA		 95452019-06-13 Pedro Alves <palves@redhat.com>
9546
9547 * thread.c: Include "cli/cli-option.h".
9548 (tp_array_compar_ascending): Global.
9549 (tp_array_compar): Delete function.
9550 (tp_array_compar_ascending, tp_array_compar_descending): New
9551 functions.
9552 (ascending_option_def, qcs_flag_option_def)
9553 (thr_qcs_flags_option_defs)
9554 (make_thread_apply_all_options_def_group)
9555 (make_thread_apply_options_def_group): New.
9556 (thread_apply_all_command): Use gdb::option::process_options.
9557 (thread_apply_command_completer)
9558 (thread_apply_all_command_completer): New.
9559 (thread_apply_command): Use gdb::option::process_options.
9560 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9561 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9562 to generate help text of "thread apply". Adjust "taas"'s help.
9563 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9564 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9565
f7e13587
PA		 95662019-06-13 Pedro Alves <palves@redhat.com>
9567
9568 * thread.c (thread_apply_command): Check for invalid TID with
9569 isdigit instead of !isalpha.
9570
5d707134
PA		 95712019-06-13 Pedro Alves <palves@redhat.com>
9572
9573 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9574 (validate_flags_qcs): New.
9575 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9576 (validate_flags_qcs): Declare.
9577 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9578 (make_frame_apply_options_def_group): New.
9579 (frame_apply_command_count): Process options with
9580 gdb::option::process_options.
9581 (frame_apply_completer): New.
9582 (frame_apply_level_completer, frame_apply_all_completer)
9583 (frame_apply_completer): New.
9584 (_initialize_stack): Update help of "frame apply", "frame apply
9585 level", "frame apply all" and "faas" to mention supported options
9586 and install command completers.
9587 * stack.h (frame_apply_all_completer): Declare.
9588 * thread.c: Include "stack.h".
9589 (tfaas_command): Add "--".
9590 (_initialize_thread): Update help "tfaas" to mention supported
9591 options and install command completer.
9592
272d4594
PA		 95932019-06-13 Pedro Alves <palves@redhat.com>
9594
9595 * completer.c (complete_nested_command_line): New.
9596 (gdb_completion_word_break_characters_throw): Add assertion.
9597 * completer.h (complete_nested_command_line): Declare.
9598
90a1ef87
PA		 95992019-06-13 Pedro Alves <palves@redhat.com>
9600
9601 * stack.c (parse_backtrace_qualifiers): New.
9602 (backtrace_command): Use it.
9603 (backtrace_command_completer): Complete on qualifiers.
9604
d4c16835
PA		 96052019-06-13 Pedro Alves <palves@redhat.com>
9606
9607 * frame.c: Include "cli/cli-option.h.
9608 (user_set_backtrace_options): New.
9609 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9610 Delete.
9611 (get_prev_frame): Adjust.
9612 (boolean_option_def, uinteger_option_def)
9613 (set_backtrace_option_defs): New.
9614 (_initialize_frame): Adjust and use
9615 gdb::option::add_setshow_cmds_for_options to install "set
9616 backtrace past-main" and "set backtrace past-entry".
9617 * frame.h: Include "cli/cli-option.h".
9618 (struct frame_print_options): Forward declare.
9619 (print_frame_arguments_all, print_frame_arguments_scalars)
9620 (print_frame_arguments_none): Declare.
9621 (print_entry_values): Delete declaration.
9622 (struct frame_print_options, user_frame_print_options): New.
9623 (struct set_backtrace_options): New.
9624 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9625 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9626 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9627 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9628 (list_args_or_locals): Add frame_print_options parameter.
9629 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9630 * python/py-framefilter.c (enumerate_args): Pass down
9631 USER_FRAME_PRINT_OPTIONS.
9632 * stack.c: Include "cli/cli-option.h".
9633 (print_frame_arguments_all, print_frame_arguments_scalars)
9634 (print_frame_arguments_none): Declare.
9635 (print_raw_frame_arguments, print_entry_values): Delete.
9636 (user_frame_print_options): New.
9637 (boolean_option_def, enum_option_def, frame_print_option_defs):
9638 New.
9639 (struct backtrace_cmd_options): New.
9640 (bt_flag_option_def): New.
9641 (backtrace_command_option_defs): New.
9642 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9643 (print_frame_arg, read_frame_arg, print_frame_args)
9644 (print_frame_info, print_frame): Add frame_print_options parameter
9645 and use it.
9646 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9647 (backtrace_command_1): Add frame_print_options and
9648 backtrace_cmd_options parameters and use them.
9649 (make_backtrace_options_def_group): New.
9650 (backtrace_command): Process command options with
9651 gdb::option::process_options.
9652 (backtrace_command_completer): New.
9653 (_initialize_stack): Extend "backtrace"'s help to mention
9654 supported options. Install completer for "backtrace".
9655 Install some settings commands with add_setshow_cmds_for_options.
9656
2daf894e
PA		 96572019-06-13 Pedro Alves <palves@redhat.com>
9658
9659 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9660 and that "set/show print raw frame-arguments" are now deprecated.
9661
9662 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9663 command.
9664 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9665 * stack.c (_initialize_stack): Install "set/show print
9666 raw-frame-arguments", and deprecate "set/show print raw
9667 frame-arguments".
9668 * valprint.c (_initialize_valprint): Deprecate "set/show print
9669 raw".
9670
e6ed716c
PA		 96712019-06-13 Pedro Alves <palves@redhat.com>
9672
9673 * compile/compile.c (struct compile_options): New.
9674 (compile_flag_option_def, compile_command_option_defs)
9675 (make_compile_options_def_group): New.
9676 (compile_file_command): Handle options with
9677 gdb::option::process_options.
9678 (compile_file_command_completer): New function.
9679 (compile_code_command): Handle options with
9680 gdb::option::process_options.
9681 (compile_code_command_completer): New function.
9682 (_initialize_compiler): Install completers for "compile code" and
9683 "compile file". Mention available options in "compile code" and
9684 "compile code"'s help.
9685 * completer.c (advance_to_completion_word): New, factored out from
9686 ...
9687 (advance_to_expression_complete_word_point): ... this.
9688 (advance_to_filename_complete_word_point): New.
9689 * completer.h (advance_to_filename_complete_word_point): New
9690 declaration.
9691
7d8062de
PA		 96922019-06-13 Pedro Alves <palves@redhat.com>
9693
9694 * compile/compile.c: Include "cli/cli-option.h".
9695 (compile_print_value): Scope data pointer is now a
9696 value_print_options pointer; adjust.
9697 (compile_print_command): Process options. Scope data pointer is
9698 now a value_print_options pointer; adjust.
9699 (_initialize_compile): Update "compile print"'s help to include
9700 supported options. Install a completer for "compile print".
9701 * cp-valprint.c (show_vtblprint, show_objectprint)
9702 (show_static_field_print): Delete.
9703 (_initialize_cp_valprint): Don't install "set print
9704 static-members", "set print vtbl", "set print object" here.
9705 * printcmd.c: Include "cli/cli-option.h" and
9706 "common/gdb_optional.h".
9707 (print_command_parse_format): Rework to fill in a
9708 value_print_options instead of a format_data.
9709 (print_value): Change parameter type from format_data pointer to
9710 value_print_options reference. Adjust.
9711 (print_command_1): Process options. Adjust to pass down a
9712 value_print_options.
9713 (print_command_completer): New.
9714 (_initialize_printcmd): Install print_command_completer as
9715 handle_brkchars completer for the "print" command. Update
9716 "print"'s help to include supported options.
9717 * valprint.c: Include "cli/cli-option.h".
9718 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9719 here from cp-valprint.c.
9720 (boolean_option_def, uinteger_option_def)
9721 (value_print_option_defs, make_value_print_options_def_group):
9722 New. Use gdb::option::add_setshow_cmds_for_options to install
9723 "set print elements", "set print null-stop", "set print repeats",
9724 "set print pretty", "set print union", "set print array", "set
9725 print address", "set print symbol", "set print array-indexes".
9726 * valprint.h: Include <string> and "cli/cli-option.h".
9727 (make_value_print_options_def_group): Declare.
9728 (print_value): Change parameter type from format_data pointer to
9729 value_print_options reference.
9730 (print_command_completer): Declare.
9731
9d0faba9
PA		 97322019-06-13 Pedro Alves <palves@redhat.com>
9733
9734 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9735 (COMMON_SFILES): Add maint-test-settings.c.
9736 * cli/cli-decode.c (boolean_enums): New global, factored out from
9737 ...
9738 (add_setshow_boolean_cmd): ... here.
9739 * cli/cli-decode.h (boolean_enums): Declare.
9740 * cli/cli-option.c: New file.
9741 * cli/cli-option.h: New file.
9742 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9743 factored out from ...
9744 (parse_cli_boolean_value(const char *)): ... this.
9745 (is_unlimited_literal): Change parameter type to pointer to
9746 pointer. Adjust and advance ARG pointer.
9747 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9748 (parse_cli_var_enum): New, factored out from ...
9749 (do_set_command): ... this. Adjust.
9750 * cli/cli-setshow.h (parse_cli_boolean_value)
9751 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9752 (parse_cli_var_enum): Declare.
9753 * cli/cli-utils.c: Include "cli/cli-option.h".
9754 (get_ulongest): New.
9755 * cli/cli-utils.h (get_ulongest): Declare.
9756 (check_for_argument): New overloads.
9757 * maint-test-options.c: New file.
9758
2c722807
PA		 97592019-06-13 Pedro Alves <palves@redhat.com>
9760
9761 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9762 parse a range if "-" is at the end of the string.
9763
dee7b4c8
PA		 97642019-06-13 Pedro Alves <palves@redhat.com>
9765
9766 * cli/cli-setshow.c (parse_auto_binary_operation)
9767 (parse_cli_boolean_value): Don't allow "o".
9768
dca0f6c0
PA		 97692019-06-13 Pedro Alves <palves@redhat.com>
9770
9771 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9772 * NEWS: Mention maint test-settings KIND.
9773 * maint-test-settings.c: New file.
9774
597bf39d
PA		 97752019-06-13 Pedro Alves <palves@redhat.com>
9776
9777 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9778 completer.
9779 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9780 "set" completers.
9781
48c410fb
PA		 97822019-06-13 Pedro Alves <palves@redhat.com>
9783
9784 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9785 after item.
9786
93bcb043
PA		 97872019-06-13 Pedro Alves <palves@redhat.com>
9788
9789 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9790
cbba3ecd
PA		 97912019-06-13 Pedro Alves <palves@redhat.com>
9792
9793 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9794 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9795 call.
9796 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9797 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9798 calls.
9799 (check_for_argument): Skip spaces after argument.
9800
b9a3f842
PA		 98012019-06-13 Pedro Alves <palves@redhat.com>
9802
9803 * thread.c (thread_apply_command): Adjust TID parsing.
9804 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9805 detected before end of string.
9806 (tid_is_in_list): Error out if LIST is invalid.
9807
3844e605
PA		 98082019-06-13 Pedro Alves <palves@redhat.com>
9809
9810 * completer.c (complete_line_internal_1): Rewind completion word
9811 point.
9812 (completion_tracker::advance_custom_word_point_by): Change
9813 parameter type to int.
9814 * completer.h (completion_tracker::advance_custom_word_point_by):
9815 Likewise.
9816
00b56dbe
PA		 98172019-06-13 Pedro Alves <palves@redhat.com>
9818
9819 * completer.c (advance_to_completion_word): Handle delimiters.
9820
d106773e
PA		 98212019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9822
9823 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9824
08f10e02
TT		 98252019-06-11 Tom Tromey <tom@tromey.com>
9826
9827 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9828 (xmalloc_failed): Move to alloc.c.
9829 * alloc.c: New file.
9830 * Makefile.in (COMMON_SFILES): Add alloc.c.
9831
1c7fe951
TT		 98322019-06-11 Tom Tromey <tom@tromey.com>
9833
9834 * nat/linux-waitpid.c: Don't include server.h.
9835 (linux_debug): Remove.
9836 (my_waitpid): Update.
9837
89549d7f
TT		 98382019-06-11 Tom Tromey <tromey@adacore.com>
9839
9840 * infcall.c (_initialize_infcall): Remove trailing newline from
9841 help.
9842 * user-regs.c (_initialize_user_regs): Remove trailing newline
9843 from help.
9844 * typeprint.c (_initialize_typeprint): Remove trailing newline
9845 from help.
9846 * reverse.c (_initialize_reverse): Remove trailing newlines from
9847 help.
9848 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9849 from help.
9850 * language.c (add_set_language_command): Remove trailing newline
9851 from help.
9852 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9853 help.
9854 * disasm.c (_initialize_disasm): Remove trailing newline from
9855 help.
9856 * top.c (init_main): Remove trailing newline from help.
9857 * interps.c (_initialize_interpreter): Remove trailing newline
9858 from help.
9859 * btrace.c (_initialize_btrace): Remove trailing newlines from
9860 help.
9861 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9862 from help.
9863 * python/python.c (_initialize_python): Remove trailing newline
9864 from help.
9865 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9866 help.
9867 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9868 from help. Reformat some text.
9869 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9870 from help.
9871 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9872 newline from help.
9873
86108c13
TT		 98742019-06-11 Tom Tromey <tromey@adacore.com>
9875
9876 * darwin-nat.c (darwin_decode_exception_message)
9877 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9878
a7067863
AB		 98792019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9880
9881 * valops.c (value_slice): Check for not allocated or not
9882 associated values.
9883
9ab08412
TV		 98842019-06-10 Tom de Vries <tdevries@suse.de>
9885
9886 PR gdb/24618
9887 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9888 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9889 invalid.
9890
f19e22e9
TV		 98912019-06-10 Tom de Vries <tdevries@suse.de>
9892
9893 PR gdb/24611
9894 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9895 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9896
e99f9db0
TV		 98972019-06-10 Tom de Vries <tdevries@suse.de>
9898
9899 PR symtab/24545
9900 * symtab.c (struct demangled_name_entry): Add language field.
9901 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9902 static minimal symbol". Set and use language field.
9903
9bf7038b
TT		 99042019-06-10 Tom Tromey <tromey@adacore.com>
9905
9906 * ada-lang.c (_initialize_ada_language): Update help text.
9907
422186a9
TT		 99082019-06-10 Tom Tromey <tromey@adacore.com>
9909
9910 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9911 with a newline.
9912 * guile/guile.c (handle_boot_error): Don't end warning with a
9913 newline.
9914 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9915 warning with a newline.
9916 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9917 newline.
9918 (s12z_frame_cache): Likewise.
9919 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9920 a newline.
9921 * solib-svr4.c (disable_probes_interface): Don't end warning with
9922 a newline.
9923 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9924 newline.
9925 * python/python.c (do_finish_initialization): Don't end warning
9926 with a newline.
9927
25ce02ee
TT		 99282019-06-10 Tom Tromey <tom@tromey.com>
9929
9930 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9931 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9932 gdbpy_enter.
9933
caa429d8
TT		 99342019-06-10 Tom Tromey <tromey@adacore.com>
9935
9936 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9937 data.
9938 (elf_new_init): Don't call stabsread_new_init.
9939 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9940 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9941 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9942
81873cc8
TV		 99432019-06-10 Tom de Vries <tdevries@suse.de>
9944
9945 PR symtab/16264
9946 PR symtab/24517
9947 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9948
4fa0265e
РИ		 99492019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9950
9951 * source.c (find_and_open_source): Also rewrite relative file
9952 names.
9953
1a3da2cd
AB		 99542019-04-26 Amos Bird <amosbird@gmail.com>
9955
9956 * annotate.c (annotate_thread_exited): Add "thread-exited"
9957 annotation.
9958
3847a7bf
TT		 99592019-06-06 Tom Tromey <tromey@adacore.com>
9960
9961 * maint.h (class scoped_command_stats): Use
9962 DISABLE_COPY_AND_ASSIGN.
9963 <print_time>: New method.
9964 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9965 print_time.
9966 (scoped_command_stats::print_time): New method.
9967
312617a3
AB		 99682019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9969
9970 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9971 instructions of lengths 6 or 8 bytes.
9972
b02f78f9
PA		 99732019-06-04 Pedro Alves <palves@redhat.com>
9974
9975 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9976
9977 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9978 * breakpoint.c (condition_completer): Likewise.
9979 * cli/cli-dump.c (scan_expression): Likewise.
9980 * common/filestuff.c (mkdir_recursive): Likewise.
9981 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9982 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9983 (gdb_abspath): Likewise.
9984 * compile/compile-cplus-types.c
9985 (compile_cplus_instance::decl_name): Likewise.
9986 * completer.c (complete_explicit_location):
9987 (signal_completer, reg_or_group_completer_1): Likewise.
9988 * cp-support.c (cp_remove_params_if_any): Likewise.
9989 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9990 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9991 * infcmd.c (strip_bg_char): Likewise.
9992 * linespec.c (copy_token_string): Likewise.
9993 * mi/mi-main.c (output_cores): Likewise.
9994 * psymtab.c (psymtab_search_name):
9995 * symfile.c (test_set_ext_lang_command): Likewise.
9996 * target.c (target_fileio_read_stralloc): Likewise.
9997 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9998 * value.c (complete_internalvar): Likewise.
9999
e1f2e1a2
CB		 100002019-06-04 Christian Biesinger <cbiesinger@google.com>
10001
10002 Add objfile property to gdb.Type.
d3238f7d
PA		 10003 * NEWS: Mention Python API addition.
10004 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10005
e664d728
PW		 100062019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10007
10008 * NEWS: Mention the new set|show style [title|highlight].
10009 Mention changes to "show style", "help" and "apropos".
10010
66d8c862
PW		 100112019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10012
10013 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10014 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10015 instead of print_help_for_command.
10016 (print_doc_of_command): New function.
10017 (help_list): Add 'apropos -v word' suggestion.
10018 (print_help_for_command): Style the command name using title style.
10019 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10020 (_initialize_cli_cmds): Describe -v in apropos_command help.
10021
9303eb2f
PW		 100222019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10023
10024 * cli/cli-style.h (cli_style_option): Add name in constructor,
10025 add m_name class member, add constructor with intensity,
10026 add name class function.
10027 (cli_style_option::add_setshow_commands): Remove name argument.
10028 (highlight_style, title_style): New styles.
10029 * cli/cli-style.c (do_show): New function that shows a style
10030 characteristic styling the style name with itself.
10031 (set_style_name): New function.
10032 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10033 Update all callers according to the changes in cli/cli-style.h.
10034 * utils.h (fputs_highlighted): New function.
10035 * utils.c (fputs_highlighted): Likewise.
10036
e2c52041
PW		 100372019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10038
10039 * NEWS: Mention new pipe command and new convenience variables.
10040
947d3946
PW		 100412019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10042
10043 * cli/cli-cmds.c (pipe_command): New function.
10044 (_initialize_cli_cmds): Call add_com for pipe_command.
10045 Define | as an alias for pipe.
10046 (exit_status_set_internal_vars): New function.
10047 (shell_escape): Call exit_status_set_internal_vars.
10048 cli/cli-decode.c (find_command_name_length): Recognize | as
10049 a single character command.
10050
b8fd0918
PW		 100512019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10052
10053 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10054 top.c (execute_command_to_ui_file): New function, mostly a copy
10055 of execute_command_to_string.
10056 (execute_command_to_string): Implement by calling
10057 execute_command_to_ui_file.
10058
68bb5386
PW		 100592019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10060
10061 * top.h (saved_command_line): Remove declaration.
10062 * top.c (previous_saved_command_line, previous_repeat_arguments):
10063 New variables.
10064 (saved_command_line): Make static, define together with other
10065 'repeat variables'.
10066 (dont_repeat): Clear repeat_arguments.
10067 (repeat_previous, get_saved_command_line, save_command_line):
10068 New functions.
10069 (gdb_init): Initialize saved_command_line
10070 and previous_saved_command_line.
10071 * main.c (captured_main_1): Remove saved_command_line initialization.
10072 * event-top.c (handle_line_of_input): Update to use
10073 the new 'repeat' related functions instead of direct access to
10074 saved_command_line.
10075 * command.h (repeat_previous, get_saved_command_line,
10076 save_command_line): New declarations.
10077 (dont_repeat): Add comment.
10078
bfcdb852
TT		 100792019-05-30 Tom Tromey <tromey@adacore.com>
10080
10081 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10082 Fix comment.
10083 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10084
0ef209f2
JV		 100852019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10086
10087 PR cli/24587
10088 * completer.c (complete): Initialize variable word.
10089
955b06fa
SDJ		 100902019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10091
10092 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10093 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10094 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10095 'body' is NULL to the outter 'if', protecting the '!is_define'
10096 situation as well.
10097
fa9c3fa0
TT		 100982019-05-29 Tom Tromey <tromey@adacore.com>
10099
10100 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10101 (dwarf_unknown): New function.
10102 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10103 (dwarf_type_encoding_name): Use dwarf_unknown.
10104
4330d61d
TT		 101052019-05-29 Tom Tromey <tromey@adacore.com>
10106
10107 PR c++/20020:
10108 * cp-valprint.c (cp_print_value_fields): Call
10109 cp_print_static_field inside "try".
10110
33a6bc35
TT		 101112019-05-29 Tom Tromey <tromey@adacore.com>
10112
10113 * inflow.c (struct terminal_info): Add default operator=.
10114 * configure: Rebuild.
10115 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10116 -Wdeprecated-copy-dtor, -Wredundant-move.
10117
000439d5
TT		 101182019-05-29 Tom Tromey <tromey@adacore.com>
10119
10120 * NEWS: Add entry.
10121 * infcmd.c (print_return_value_1): Handle finish_print
10122 option.
10123 (show_print_finish): New function.
10124 (_initialize_infcmd): Add "set/show print finish" commands.
10125 * valprint.c (user_print_options): Initialize new member.
10126 * valprint.h (struct value_print_options) <finish_print>: New
10127 member.
10128
c0e70c62
TT		 101292019-05-28 Tom Tromey <tromey@adacore.com>
10130
10131 * ada-lang.c (ada_remove_Xbn_suffix)
10132 (find_old_style_renaming_symbol)
10133 (parse_old_style_renaming): Remove.
10134 (ada_find_renaming_symbol): Don't call
10135 find_old_style_renaming_symbol.
10136 (ada_is_renaming_symbol): Rename from
10137 ada_find_renaming_symbol. Remove "block" parameter. Return
10138 bool. Now static.
10139 (ada_read_var_value): Update and simplify.
10140 * ada-exp.y (write_var_or_type): Remove old code.
10141
766f8836
AH		 101422019-05-28 Alan Hayward <alan.hayward@arm.com>
10143
68255adc 10144 PR gdb/25010
766f8836
AH		 10145 * event-top.c: Remove include comment.
10146 * inflow.c (class scoped_ignore_sigttou): Move from here...
10147 * inflow.h (class scoped_ignore_sigttou): ...to here.
10148 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10149 * top.c: Remove include comment.
10150
eb41253a
TT		 101512019-05-27 Tom Tromey <tom@tromey.com>
10152
10153 * NEWS: Fix typo.
10154
4ca51187
TT		 101552019-05-22 Tom Tromey <tromey@adacore.com>
10156
10157 * target.c (target_follow_exec): Constify parameter.
10158 * target-delegates.c: Rebuild.
10159 * remote.c (remote_target::follow_exec): Constify parameter.
10160 * infrun.c (follow_exec): Constify parameter.
10161 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10162 (target_follow_exec): Likewise.
10163
8fca4da0
AH		 101642019-05-22 Alan Hayward <alan.hayward@arm.com>
10165
10166 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10167 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10168
b7060614
AH		 101692019-05-22 Alan Hayward <alan.hayward@arm.com>
10170
10171 * NEWS: Add debugredirect and testsuite sections.
10172
0a5954bd
SC		 101732019-05-22 Simon Cook <simon.cook@embecosm.com>
10174
10175 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10176 target descriptions using exclusively floating point register name
10177 aliases.
10178
dc42e902
AB		 101792019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10180
10181 PR gdb/18644:
10182 * f-lang.c (build_fortran_types): Handle the case where
10183 gdbarch_floatformat_for_type returns a nullptr.
10184
fb7806c7
TV		 101852019-05-21 Tom de Vries <tdevries@suse.de>
10186
10187 PR cli/24587
10188 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10189
34d11c68
AB		 101902019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10191
10192 PR gdb/18644:
10193 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10194 16-byte floats.
10195 * i386-tdep.c (i386_floatformat_for_type): Use
10196 floatformats_ia64_quad for the 16-byte floating point component
10197 within a fortran 32-byte complex number.
10198
122cf0f2
AB		 101992019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10200
10201 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10202 delete default constructor.
10203 (find_partial_die): Update to return const struct.
10204 (partial_die_parent_scope): Move variable declaration into scope
10205 of its use and change its type to auto.
10206 (guess_partial_die_structure_name): Likewise.
10207 (partial_die_info::fixup): Likewise.
10208
33d0e35a
TT		 102092019-05-17 Tom Tromey <tromey@adacore.com>
10210
10211 * source.c (find_and_open_source): Remove cast.
10212
a45575b0
TT		 102132019-05-17 Tom Tromey <tromey@adacore.com>
10214
10215 * annotate.c (annotate_source): Make "filename" const.
10216 * annotate.h (annotate_source): Use const.
10217
81f47ac2
AH		 102182019-05-17 Alan Hayward <alan.hayward@arm.com>
10219
10220 * disasm.c (set_disassembler_options): Send errors to stderr.
10221
ca1285d1
AH		 102222019-05-17 Alan Hayward <alan.hayward@arm.com>
10223
10224 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10225 (cli_interp_base::set_logging): Check debug_redirect.
10226 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10227 * cli/cli-logging.c (debug_redirect): Add static variable.
10228 (pop_output_files): Add default param.
10229 (handle_redirections): Print debug setting.
10230 (show_logging_command): Likewise.
10231 (_initialize_cli_logging): Add debugredirect command.
10232 * interps.c (current_interp_set_logging): Add debug_redirect
10233 parameter.
10234 * interps.h (set_logging): Add debug_redirect parameter.
10235 (current_interp_set_logging): Likewise.
10236 * mi/mi-common.h: Likewise.
10237 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10238
102392019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 10240 Tom Tromey <tromey@adacore.com>
10241
10242 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10243 directly.
10244 * cli/cli-interp.h (make_logging_output): Remove declaration.
10245 * cli/cli-logging.c (make_logging_output): Remove function.
10246 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10247 directly.
10248 * ui-file.c (tee_file::tee_file): Remove bools.
10249 (tee_file::~tee_file): Remove deletes.
10250 * ui-file.h (tee_file): Remove bools.
10251
26648588
JV		 102522019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10253
10254 * mi/mi-cmds.h (mi_cmd_complete): New function.
10255 * mi/mi-main.c (mi_cmd_complete): Likewise.
10256 * mi/mi-cmds.c: Define new MI command -complete.
10257 * NEWS: Mention new -complete command.
10258
6e035501
JV		 102592019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10260
10261 * completer.h (complete): New function.
10262 * completer.c (complete): Likewise.
10263 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10264 function defined in completer.h.
10265
7d0e2ece
JV		 102662019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10267
e79be6e5 10268 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10269
fb816e8b
TV		 102702019-05-17 Tom de Vries <tdevries@suse.de>
10271
10272 PR gdb/24094
10273 * dwarf2read.c (struct cu_partial_die_info): New struct.
10274 (find_partial_die): Return cu_partial_die_info.
10275 (partial_die_parent_scope, guess_partial_die_structure_name)
10276 (partial_die_info::fixup): Handle new return type of find_partial_die.
10277
677052f2
SDJ		 102782019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10279
a1726c38 10280 PR breakpoints/24541
677052f2
SDJ		 10281 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10282 "std::string", simplifying the algorithm.
10283
f3da9116
SDJ		 102842019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10285
10286 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10287 (stap_static_probe_ops::get_probes): Likewise.
10288
f1bb75ab
SDJ		 102892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10290
10291 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10292 '-')" and "else if".
10293 (stap_parse_single_operand): Join checks for
10294 "gdbarch_stap_parse_special_token_p" and
10295 "gdbarch_stap_parse_special_token" in the same "if" statement.
10296 Invert check when verifying for operation on register
10297 displacement.
10298
3ca58cde
SDJ		 102992019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10300
10301 * stap-probe.c (stap_get_opcode): Update comment.
10302 (stap_get_expected_argument_type): Likewise.
10303 (handle_stap_probe): Likewise.
10304
af2d9bee
SDJ		 103052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10306
10307 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10308 return type to 'bool'. Adjust comment. Use 'bool' when
10309 appropriate.
10310 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10311 * stap-probe.c (stap_parse_argument_1): Likewise.
10312 (stap_is_operator): Likewise.
10313 (stap_is_generic_prefix): Likewise.
10314 (stap_is_register_prefix): Likewise.
10315 (stap_is_register_indirection_prefix): Likewise.
10316 (stap_is_integer_prefix): Likewise.
10317 (stap_generic_check_suffix): Likewise.
10318 (stap_check_integer_suffix): Likewise.
10319 (stap_check_register_suffix): Likewise.
10320 (stap_check_register_indirection_suffix): Likewise.
10321 (stap_parse_register_operand): Likewise.
10322 (stap_parse_single_operand): Likewise.
10323 (stap_parse_argument_1): Likewise.
10324 (stap_probe::get_argument_count): Likewise.
10325 (stap_is_operator): Likewise.
10326
61c9c421
TT		 103272019-05-16 Tom Tromey <tromey@adacore.com>
10328
10329 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10330 keyword to foreach.
10331
9ddc1af1
SM		 103322019-05-15 Simon Marchi <simon.marchi@efficios.com>
10333
10334 * linux-thread-db.c (try_thread_db_load_1): Change return type
10335 to bool.
10336 (try_thread_db_load): Likewise.
10337 (try_thread_db_load_from_pdir_1): Likewise.
10338 (try_thread_db_load_from_pdir): Likewise.
10339 (try_thread_db_load_from_sdir): Likewise.
10340 (try_thread_db_load_from_dir): Likewise.
10341 (thread_db_load_search): Likewise.
10342 (has_libpthread): Likewise.
10343 (thread_db_load): Likewise.
10344
7bede828
SDJ		 103452019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10346
10347 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10348 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10349 NULL, and complain/return if that's the case.
10350
c5358db4
JD		 103512019-05-15 John Darrington <john@darrington.wattle.id.au>
10352
10353 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10354 (advance, posn, abstract_read_memory): New functions.
10355 [struct mem_read_abstraction]: New struct.
10356 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10357
c408a94f
TT		 103582019-05-14 Tom Tromey <tromey@adacore.com>
10359
10360 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10361 value is not lval_memory.
10362
e7bd7fba
TT		 103632019-05-14 Tom Tromey <tromey@adacore.com>
10364
10365 * solib.c (info_sharedlibrary_command): Style the file name.
10366
a6d0f249
AH		 103672019-05-14 Alan Hayward <alan.hayward@arm.com>
10368
10369 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10370 (aarch64_vnv_type): Likewise.
10371 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10372 * common/tdesc.c: Likewise.
10373 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10374 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10375 * features/aarch64-fpu.xml: Add ieee half view.
10376 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10377 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10378 * gdbtypes.h (struct builtin_type): Likewise.
10379 (struct objfile_type): Likewise.
10380
66b8bb74
SM		 103812019-05-12 Paul Naert <paul.naert@polymtl.ca>
10382
10383 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10384 typo.
10385 * location.h (string_to_event_location): Likewise.
10386
21c219fd
JB		 103872019-05-11 Joel Brobecker <brobecker@adacore.com>
10388
10389 GDB 8.3 released.
10390
13674803
SM		 103912019-05-10 Simon Marchi <simon.marchi@efficios.com>
10392
10393 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10394 New variable declaration.
10395 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10396 New variable.
10397 (print_one_breakpoint): Use ui_out::test_flags and new global
10398 variable to compute use_fixed_output.
10399 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10400 Remove.
10401 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10402 (mi_multi_location_breakpoint_output_fixed): Remove.
10403 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10404 new variable.
10405 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10406 fix_multi_location_breakpoint_output flag if version >= 3.
10407 * ui-out.h (enum ui_out_flag)
10408 <fix_multi_location_breakpoint_output>: New enumerator.
10409
a9eac7f9
SM		 104102019-05-10 Simon Marchi <simon.marchi@efficios.com>
10411
10412 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10413
71bed2db
TT		 104142019-05-10 Tom Tromey <tromey@adacore.com>
10415
10416 * ada-lang.c (catch_ada_completer): New function.
10417 (_initialize_ada_language): Use it.
10418
24c54127
TT		 104192019-05-10 Tom Tromey <tromey@adacore.com>
10420
10421 * thread.c (print_thread_info): Make "requested_threads" const.
10422 * gdbthread.h (print_thread_info): Make "requested_threads"
10423 const.
10424 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10425 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10426
7a102139
TT		 104272019-05-08 Tom Tromey <tom@tromey.com>
10428
10429 * gdbtypes.c (objfile_type_data): Change type.
10430 (objfile_type, _initialize_gdbtypes): Update.
10431
924d79e2
TT		 104322019-05-08 Tom Tromey <tom@tromey.com>
10433
10434 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10435 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10436 (_initialize_dwarf2_frame): Update.
10437
4c58e337
TT		 104382019-05-08 Tom Tromey <tom@tromey.com>
10439
10440 * objc-lang.c (objc_objfile_data): Change type.
10441 (find_methods): Update.
10442 (_initialize_objc_lang): Remove.
10443
d772d2ab
TT		 104442019-05-08 Tom Tromey <tom@tromey.com>
10445
10446 * stabsread.c (rs6000_builtin_type_data): Change type.
10447 (rs6000_builtin_type, _initialize_stabsread): Update.
10448
d11d83f4
TT		 104492019-05-08 Tom Tromey <tom@tromey.com>
10450
10451 * mips-tdep.c (mips_pdr_data): Remove.
10452 (_initialize_mips_tdep): Update.
10453
9a73f0ad
TT		 104542019-05-08 Tom Tromey <tom@tromey.com>
10455
10456 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10457 (hppa_init_objfile_priv_data, read_unwind_info)
10458 (find_unwind_entry, _initialize_hppa_tdep): Update.
10459
8127a2fa
TT		 104602019-05-08 Tom Tromey <tom@tromey.com>
10461
10462 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10463 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10464 on obstack.
10465 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10466
91d3055d
TT		 104672019-05-08 Tom Tromey <tom@tromey.com>
10468
10469 * mdebugread.c (basic_type_data): Change type.
10470 (basic_type, _initialize_mdebugread): Update.
10471
31930bd3
TT		 104722019-05-08 Tom Tromey <tom@tromey.com>
10473
10474 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10475
bdb3ed9e
TT		 104762019-05-08 Tom Tromey <tom@tromey.com>
10477
10478 * nto-tdep.c (nto_inferior_data_reg): Change type.
10479 (nto_inferior_data): Update.
10480 (nto_inferior_data_cleanup, nto_new_inferior_data)
10481 (_initialize_nto_tdep): Remove.
10482 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10483
f37b313d
TT		 104842019-05-08 Tom Tromey <tom@tromey.com>
10485
10486 * ada-lang.c (struct ada_inferior_data): Add initializers.
10487 (ada_inferior_data): Change type.
10488 (ada_inferior_data_cleanup): Remove.
10489 (get_ada_inferior_data, ada_inferior_exit)
10490 (struct ada_pspace_data): Add initializers, destructor.
10491 (ada_pspace_data_handle): Change type.
10492 (get_ada_pspace_data): Update.
10493 (ada_pspace_data_cleanup): Remove.
10494
24699405
TT		 104952019-05-08 Tom Tromey <tom@tromey.com>
10496
10497 * coffread.c (struct coff_symfile_info): Add initializers.
10498 (coff_objfile_data_key): Move lower. Change type.
10499 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10500 Update.
10501 (coff_free_info): Remove.
10502
d4e05d2f
TT		 105032019-05-08 Tom Tromey <tom@tromey.com>
10504
10505 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10506 (fbsd_pspace_data_handle): Move lower. Change type.
10507 (get_fbsd_pspace_data): Update.
10508 (fbsd_pspace_data_cleanup): Remove.
10509 (_initialize_fbsd_tdep): Update.
10510
14ef6690
TT		 105112019-05-08 Tom Tromey <tom@tromey.com>
10512
10513 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10514 (get_ada_tasks_pspace_data): Update.
10515 (ada_tasks_pspace_data_cleanup): Remove.
10516 (_initialize_tasks): Update.
10517 (ada_tasks_inferior_data_handle): Change type.
10518 (get_ada_tasks_inferior_data): Update.
10519 (ada_tasks_inferior_data_cleanup): Remove.
10520 (struct ada_tasks_pspace_data): Add initializers.
10521
814cf43a
TT		 105222019-05-08 Tom Tromey <tom@tromey.com>
10523
10524 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10525 * symfile-debug.c (debug_sym_get_probes): Change type.
10526 * stap-probe.c (handle_stap_probe):
10527 (stap_static_probe_ops::get_probes): Change type.
10528 * probe.h (class static_probe_ops) <get_probes>: Change type.
10529 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10530 (parse_probes_in_pspace): Update.
10531 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10532 Update.
10533 (any_static_probe_ops::get_probes): Change type.
10534 * elfread.c (elfread_data): New typedef.
10535 (probe_key): Change type.
10536 (elf_get_probes): Likewise. Update.
10537 (probe_key_free): Remove.
10538 (_initialize_elfread): Update.
10539 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10540 Change type.
10541 (dtrace_process_dof_probe, dtrace_process_dof)
10542 (dtrace_static_probe_ops::get_probe): Change type.
10543
02dc647e
TT		 105442019-05-08 Tom Tromey <tom@tromey.com>
10545
10546 * xcoffread.c (struct xcoff_symfile_info): Rename from
10547 coff_symfile_info. Add initializers.
10548 (xcoff_objfile_data_key): Move lower. Change type.
10549 (XCOFF_DATA): Rewrite.
10550 (xcoff_free_info): Remove.
10551 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10552 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10553 (xcoff_initial_scan): Update.
10554
09232438
TT		 105552019-05-08 Tom Tromey <tom@tromey.com>
10556
10557 * solib-svr4.c (struct svr4_info): Add initializers and
10558 destructor.
10559 <probes_table>: Now an htab_up.
10560 (solib_svr4_pspace_data): Change type.
10561 (free_probes_table): Simplify.
10562 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10563 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10564 (probes_table_remove_objfile_probes, register_solib_event_probe)
10565 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10566 (_initialize_svr4_solib): Update.
10567
7b4a314f
TT		 105682019-05-08 Tom Tromey <tom@tromey.com>
10569
10570 * remote.c (remote_pspace_data): Change type.
10571 (remote_pspace_data_cleanup): Remove.
10572 (get_remote_exec_file, set_pspace_remote_exec_file)
10573 (_initialize_remote): Update.
10574
51d3063a
TT		 105752019-05-08 Tom Tromey <tom@tromey.com>
10576
10577 * breakpoint.c (breakpoint_objfile_key): Change type.
10578 (get_breakpoint_objfile_data): Update.
10579 (free_breakpoint_objfile_data): Remove.
10580 (_initialize_breakpoint): Update.
10581
89fb8848
TT		 105822019-05-08 Tom Tromey <tom@tromey.com>
10583
10584 * linux-tdep.c (struct linux_info): Add initializers.
10585 (linux_inferior_data): Move. Change type.
10586 (invalidate_linux_cache_inf): Update.
10587 (linux_inferior_data_cleanup): Remove.
10588 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10589
e9b89e2d
TT		 105902019-05-08 Tom Tromey <tom@tromey.com>
10591
10592 * auxv.c (auxv_inferior_data): Move. Change type.
10593 (auxv_inferior_data_cleanup): Remove.
10594 (invalidate_auxv_cache_inf): Rewrite.
10595 (get_auxv_inferior_data, _initialize_auxv): Update.
10596
8c42777c
TT		 105972019-05-08 Tom Tromey <tom@tromey.com>
10598
10599 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10600 (symfile_debug_objfile_data_key): Change type.
10601 (symfile_debug_installed, debug_qf_has_symbols)
10602 (debug_qf_find_last_source_symtab)
10603 (debug_qf_forget_cached_source_info)
10604 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10605 (debug_qf_print_stats, debug_qf_dump)
10606 (debug_qf_expand_symtabs_for_function)
10607 (debug_qf_expand_all_symtabs)
10608 (debug_qf_expand_symtabs_with_fullname)
10609 (debug_qf_map_matching_symbols)
10610 (debug_qf_expand_symtabs_matching)
10611 (debug_qf_find_pc_sect_compunit_symtab)
10612 (debug_qf_map_symbol_filenames)
10613 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10614 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10615 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10616 (debug_sym_read_linetable, debug_sym_relocate): Update.
10617 (symfile_debug_free_objfile): Remove.
10618 (install_symfile_debug_logging, _initialize_symfile_debug):
10619 Update.
10620
5bfd760d
TT		 106212019-05-08 Tom Tromey <tom@tromey.com>
10622
10623 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10624 allocate_on_obstack.
10625 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10626 (get_dwarf2_per_objfile): Update.
10627 (set_dwarf2_per_objfile): Remove.
10628 (dwarf2_has_info, dwarf2_get_section_info): Update.
10629 (dwarf2_free_objfile): Remove.
10630 (_initialize_dwarf2_read): Update.
10631
e85e19b4
TT		 106322019-05-08 Tom Tromey <tom@tromey.com>
10633
10634 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10635 initializers.
10636 <unsupported_script_warning_printed,
10637 script_not_found_warning_printed>: Now bool.
10638 (auto_load_pspace_data): Change type.
10639 (~auto_load_pspace_info): Rename from
10640 auto_load_pspace_data_cleanup.
10641 (get_auto_load_pspace_data, init_loaded_scripts_info)
10642 (clear_section_scripts, maybe_print_unsupported_script_warning)
10643 (maybe_print_script_not_found_warning, _initialize_auto_load):
10644 Update.
10645
f6aa7436
TT		 106462019-05-08 Tom Tromey <tom@tromey.com>
10647
10648 * objfiles.c (objfile_pspace_info): Add destructor and
10649 initializers.
10650 (objfiles_pspace_data): Change type.
10651 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10652 (get_objfile_pspace_data): Update.
10653 (objfiles_bfd_data): Change type.
10654 (get_objfile_bfd_data): Update.
10655 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10656
6ae614f6
TT		 106572019-05-08 Tom Tromey <tom@tromey.com>
10658
10659 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10660 Change type.
10661 (get_catch_syscall_inferior_data): Update.
10662 (catch_syscall_inferior_data_cleanup): Remove.
10663 (_initialize_break_catch_syscall): Update.
10664
6509b8eb
TT		 106652019-05-08 Tom Tromey <tom@tromey.com>
10666
10667 * inflow.c (struct terminal_info): Add destructor and
10668 initializers.
10669 (inflow_inferior_data): Change type.
10670 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10671 (get_inflow_inferior_data, inflow_inferior_exit)
10672 (swap_terminal_info, _initialize_inflow): Update.
10673
35632941
TT		 106742019-05-08 Tom Tromey <tom@tromey.com>
10675
10676 * target-dcache.c (target_dcache_cleanup): Remove.
10677 (target_dcache_aspace_key): Change type.
10678 (target_dcache_init_p, target_dcache_invalidate)
10679 (target_dcache_get, target_dcache_get_or_init)
10680 (_initialize_target_dcache): Update.
10681 * dcache.h (struct dcache_deleter): New.
10682
3017b94d
TT		 106832019-05-08 Tom Tromey <tom@tromey.com>
10684
10685 * symtab.c (struct symbol_cache): Add destructor and
10686 initializers.
10687 (symbol_cache_key): Move. Change type.
10688 (make_symbol_cache, free_symbol_cache): Remove.
10689 (get_symbol_cache): Update.
10690 (symbol_cache_cleanup): Remove.
10691 (ALL_PSPACES, symbol_cache_flush)
10692 (maintenance_print_symbol_cache)
10693 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10694 Update.
10695
a32ad8c5
TT		 106962019-05-08 Tom Tromey <tom@tromey.com>
10697
10698 * symtab.c (struct main_info): Add destructor and initializers.
10699 (main_progspace_key): Move. Change type.
10700 (get_main_info): Update.
10701 (main_info_cleanup): Remove.
10702 (_initialize_symtab): Update.
10703
5f6e90a0
TT		 107042019-05-08 Tom Tromey <tom@tromey.com>
10705
10706 * registry.h (DECLARE_REGISTRY): Define the _key class.
10707
1bd0c6e4
AB		 107082019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10709
10710 * NEWS: Merge two 'New commands' sections.
10711
2228ef77
XR		 107122019-05-08 Joel Brobecker <brobecker@adacore.com>
10713
10714 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10715 parameter and use Ada language definition instead.
10716 (ada_val_print_ptr): Remove unused language parameter.
10717 (ada_val_print_num): Remove language parameter and use Ada language
10718 definition instead.
10719 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10720 parameter.
10721 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10722 parameter and use Ada language definition instead.
10723 (ada_val_print_1): Update all ada_val_print_xxx calls.
10724 Remove language parameter.
10725 (ada_val_print): Update ada_val_print_1 call.
10726
60fcc1c3
TT		 107272019-05-08 Tom Tromey <tromey@adacore.com>
10728
10729 * remote.c (remote_hw_watchpoint_limit)
10730 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10731 Now static.
10732
ed2b7c17
TT		 107332019-05-08 Tom Tromey <tromey@adacore.com>
10734
10735 * maint.c (_initialize_maint_cmds): Move initialization code to
10736 remote.c.
10737 (watchdog, show_watchdog): Move to remote.c.
10738 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10739 "watchdog" static.
10740 (_initialize_remote): Move initialization code from maint.c.
10741 * defs.h (watchdog): Don't declare.
10742
b0be6c91
TT		 107432019-05-08 Tom Tromey <tromey@adacore.com>
10744
10745 * tui/tui-interp.c: Include main.h.
10746 * interps.c: Include main.h.
10747 * main.h (interpreter_p): Declare.
10748 * defs.h (interpreter_p): Don't declare.
10749
587ee17b
TT		 107502019-05-08 Tom Tromey <tromey@adacore.com>
10751
10752 * dwarf2loc.c: Include dwarf2read.h.
10753 * defs.h (read_unsigned_leb128): Don't declare.
10754 * dwarf2read.h (read_unsigned_leb128): Declare.
10755
ca1df239
TT		 107562019-05-08 Tom Tromey <tromey@adacore.com>
10757
10758 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10759 method.
10760
99f20f08
TT		 107612019-05-08 Tom Tromey <tromey@adacore.com>
10762
10763 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10764 when no wrap column is set.
10765
80e55b13
TT		 107662019-05-08 Tom Tromey <tromey@adacore.com>
10767
10768 * c-lang.c (c_get_string): Handle non-C-style arrays.
10769
9d3421af
TT		 107702019-05-08 Tom Tromey <tromey@adacore.com>
10771
10772 * typeprint.c (print_offset_data::update): Print the bit offset,
10773 not the number of bits remaining.
10774
844333e2
TT		 107752019-05-08 Tom Tromey <tromey@adacore.com>
10776
10777 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10778 padding at end of comment.
10779
988915ee
TT		 107802019-05-08 Tom Tromey <tromey@adacore.com>
10781
10782 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10783 Compare main types.
10784
26bfd823
TT		 107852019-05-06 Tom Tromey <tom@tromey.com>
10786
10787 * common/scoped_mmap.c: Include common-defs.h.
10788 * common/scoped_mmap.h: Don't include config.h.
10789
89055eaa
TT		 107902019-05-04 Tom Tromey <tom@tromey.com>
10791
10792 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10793 (struct aarch64_call_info): Add initializers.
10794 <si>: Now a std::vector.
10795 (pass_on_stack, aarch64_push_dummy_call): Update.
10796
5da01df5
TT		 107972019-05-04 Simon Marchi <simon.marchi@efficios.com>
10798 Tom Tromey <tom@tromey.com>
10799
10800 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10801 (ppc_threads): Now a std::vector. Now static.
10802 (hwdebug_find_thread_points_by_tid)
10803 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10804 Update.
10805
fbdf05a1
TT		 108062019-05-04 Tom Tromey <tom@tromey.com>
10807
10808 * arc-tdep.c (arc_tdesc_init): Return bool.
10809
06d16ec9
TT		 108102019-05-04 Tom Tromey <tom@tromey.com>
10811
10812 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10813 Use gdb_assert_not_reached.
10814
9c056022
TT		 108152019-05-04 Tom Tromey <tom@tromey.com>
10816
10817 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10818 "false".
10819
fa9c2a59
TT		 108202019-05-04 Tom Tromey <tom@tromey.com>
10821
10822 * arc-tdep.c (arc_tdesc_init): Use bool.
10823
e2eb806a
TT		 108242019-05-04 Tom Tromey <tom@tromey.com>
10825
10826 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10827
6fe87677
TT		 108282019-05-04 Tom Tromey <tom@tromey.com>
10829
10830 * cli/cli-cmds.c (valid_command_p): Return bool.
10831
7f008c9e
TT		 108322019-05-04 Tom Tromey <tom@tromey.com>
10833
10834 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10835 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10836
b6484282
RT		 108372019-05-04 Raul Tambre <raul@tambre.ee>
10838
10839 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10840 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10841 operator for comparison.
10842
af97b416
TT		 108432019-05-04 Tom Tromey <tom@tromey.com>
10844
10845 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10846 (lookup_partial_symbol, print_partial_symbols)
10847 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10848 (psymbol_compare): Update.
10849 (add_psymbol_to_bcache): Clear the entire psymbol.
10850 (maintenance_check_psymtabs): Update.
10851 * psympriv.h (struct partial_symbol): Don't derive from
10852 general_symbol_info.
10853 <obj_section, unrelocated_address, address,
10854 set_unrelocated_address>: Update.
10855 <ginfo>: New member.
10856 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10857 (debug_names::write_psymbols): Update.
10858
9d6d4be8
TV		 108592019-05-04 Tom de Vries <tdevries@suse.de>
10860
10861 * contrib/cc-with-tweaks.sh: Support -n arg.
10862
66452beb
PW		 108632019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10864
10865 * corelow.c (core_target::detach): Ensure frame cache and
10866 register caches are cleared.
10867 inferior.c (exit_inferior_1): Likewise.
10868
bde09ab7
TT		 108692019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10870 Tom Tromey <tom@tromey.com>
10871
10872 * dictionary.c (collate_pending_symbols_by_language): Remove
10873 "struct" from foreach.
10874 * symtab.c (lookup_global_symbol_from_objfile)
10875 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10876 foreach.
10877 * ser-tcp.c (net_open): Remove "struct" from foreach.
10878 * objfiles.c (objfile_relocate, objfile_rebase)
10879 (objfile_has_symbols): Remove "struct" from foreach.
10880 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10881 from foreach.
10882 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10883 foreach.
10884 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10885 "struct" from foreach.
10886 * ada-lang.c (create_excep_cond_exprs)
10887 (ada_exception_catchpoint_cond_string): Remove "struct" from
10888 foreach.
10889
222a8d25
TT		 108902019-05-03 Tom Tromey <tromey@adacore.com>
10891
10892 * ada-exp.y (convert_char_literal): Check suffix of each
10893 enumerator.
10894
fcd60b84
DP		 108952019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10896
10897 PR ada/21406:
10898 * ada-exp.y (yywrap): Don't define.
10899 * ada-lex.l (%option): Add noyywrap
10900 (yywrap): Remove.
10901
5f2459c2
EZ		 109022019-05-03 Eli Zaretskii <eliz@gnu.org>
10903
353ea2d1
EZ		 10904 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10905 _WIN32_WINNT to the XP level, unless already defined to a higher
10906 level.
10907
10908 * unittests/parse-connection-spec-selftests.c:
10909 * ser-tcp.c:
10910 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10911 override.
10912
5f2459c2
EZ		 10913 * symfile.c (find_separate_debug_file): Remove colon from the
10914 drive spec of DOS/Windows file names of the target, so that the
10915 file name produced from DEBUGDIR and the target's directory will
10916 be valid on DOS/Windows systems.
10917
80062eb9
AB		 109182019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10919
10920 * rust-lang.c (val_print_struct): Handle printing structures
10921 containing strings.
10922
b8c05e85
TT		 109232019-05-02 Tom Tromey <tromey@adacore.com>
10924
10925 * valarith.c (_initialize_valarith): Remove.
10926
4504bbde
TT		 109272019-05-01 Tom Tromey <tromey@adacore.com>
10928
10929 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10930 bitfields.
10931
d48e62f4
TT		 109322019-05-01 Tom Tromey <tromey@adacore.com>
10933
10934 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10935 for big-endian copies.
10936
15f18d14
AT		 109372019-04-30 Ali Tamur <tamur@google.com>
10938 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10939 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10940 (read_3_bytes): New function.
10941
ab4ee614
JB		 109422019-04-30 Joel Brobecker <brobecker@adacore.com>
10943
10944 * windows-nat.c (main_thread_id): Delete.
10945 (handle_output_debug_string): Replace main_thread_id by
10946 current_event.dwThreadId.
10947 (fake_create_process): Likewise.
10948 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10949 Do not set main_thread_id.
10950 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10951 current_event.dwThreadId.
10952 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10953
8ed5b76e
JB		 109542019-04-30 Joel Brobecker <brobecker@adacore.com>
10955
10956 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10957 Use current_event.dwThreadId instead of main_thread_id.
10958
2ff0a947
TT		 109592019-04-30 Tom Tromey <tromey@adacore.com>
10960
10961 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10962 (create_excep_cond_exprs): Iterate over program spaces.
10963 (ada_exception_catchpoint_cond_string): Examine all minimal
10964 symbols for exception types.
10965
a776957c
TT		 109662019-04-30 Tom Tromey <tromey@adacore.com>
10967
10968 PR c++/24470:
10969 * dwarf2read.c (process_structure_scope): Handle case where type
10970 has template parameters but no symbol was created.
10971
bc68014d
AB		 109722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10973 Chris January <chris.january@arm.com>
10974
10975 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10976 qualifier.
10977 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10978
f1fdc960
AB		 109792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10980
10981 * f-typeprint.c (f_print_type): Update rules for printing
10982 whitespace.
10983 (f_type_print_varspec_suffix): Likewise.
10984
bf7a4de1
AB		 109852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10986 Chris January <chris.january@arm.com>
10987
10988 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10989 function arguments.
10990
bbe75b9d
AB		 109912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10992
10993 * f-lang.c (build_fortran_types): Change name of void type to
10994 lower case.
10995 * f-typeprint.c (f_type_print_base): Print the name of the void
10996 type, rather than a fixed string.
10997 * f-valprint.c (f_decorations): Use lower case void string.
10998
1db455a7
AB		 109992019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11000 Chris January <chris.january@arm.com>
11001
11002 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11003 types for Fortran.
11004
b6d03bb2
AB		 110052019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11006 Chris January <chris.january@arm.com>
11007 David Lecomber <david.lecomber@arm.com>
11008
11009 * f-exp.y (BINOP_INTRINSIC): New token.
11010 (exp): New parser rule handling BINOP_INTRINSIC.
11011 (f77_keywords): Add new builtin procedures.
11012 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11013 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11014 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11015 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11016 (print_unop_subexp_f): New function.
11017 (print_binop_subexp_f): New function.
11018 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11019 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11020 (dump_subexp_body_f): Likewise.
11021 (operator_check_f): Likewise.
11022 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11023 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11024
83228e93
AB		 110252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11026
11027 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11028 UNOP_KIND.
11029 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11030 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11031 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11032 (operator_length_f): New fuction.
11033 (print_subexp_f): New function.
11034 (op_name_f): New function.
11035 (dump_subexp_body_f): New function.
11036 (operator_check_f): New function.
11037 (exp_descriptor_f): Replace standard expression handling functions
11038 with new functions.
11039 * gdb/fortran-operator.def: New file.
11040 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11041 * gdb/std-operator.def: Remove UNOP_KIND.
11042
6fdcd7cc
AB		 110432019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11044
11045 * std-operator.def: Remove unbalanced, stray double quote
11046 character.
11047
2e62ab40
AB		 110482019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11049 Chris January <chris.january@arm.com>
11050 Daniel Everett <daniel.everett@arm.com>
11051 Nick Forrington <nick.forrington@arm.com>
11052 Richard Bunt <richard.bunt@arm.com>
11053
11054 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11055 of depth when printing anonymous structs or unions.
11056 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11057 Don't print either the top-level value, or the children if the
11058 max-depth is exceeded.
11059 (ppscm_print_children): When printing the key of a map, allow one
11060 extra level of depth.
11061 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11062 print either the top-level value, or the children if the max-depth
11063 is exceeded.
11064 (print_children): When printing the key of a map, allow one extra
11065 level of depth.
11066 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11067 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11068 (user_print_options): Initialise max_depth field.
11069 (val_print_scalar_or_string_type_p): New function.
11070 (val_print): Check to see if the max depth has been reached.
11071 (val_print_check_max_depth): Define new function.
11072 (show_print_max_depth): New function.
11073 (_initialize_valprint): Add 'print max-depth' option.
11074 * valprint.h (struct value_print_options) <max_depth>: New field.
11075 (val_print_check_max_depth): Declare new function.
11076 * NEWS: Document new feature.
11077
4be290b2
AB		 110782019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11079
11080 * ada-lang.c (ada_language_defn): Initialise new field.
11081 * c-lang.c (c_is_string_type_p): New function.
11082 (c_language_defn): Initialise new field.
11083 (cplus_language_defn): Initialise new field.
11084 (asm_language_defn): Initialise new field.
11085 (minimal_language_defn): Initialise new field.
11086 * c-lang.h (c_is_string_type_p): Declare new function.
11087 * d-lang.c (d_language_defn): Initialise new field.
11088 * f-lang.c (f_is_string_type_p): New function.
11089 (f_language_defn): Initialise new field.
11090 * go-lang.c (go_is_string_type_p): New function.
11091 (go_language_defn): Initialise new field.
11092 * language.c (default_is_string_type_p): New function.
11093 (unknown_language_defn): Initialise new field.
11094 (auto_language_defn): Initialise new field.
11095 * language.h (struct language_defn) <la_is_string_type_p>: New
11096 member variable.
11097 (default_is_string_type_p): Declare new function.
11098 * m2-lang.c (m2_language_defn): Initialise new field.
11099 * objc-lang.c (objc_language_defn): Initialise new field.
11100 * opencl-lang.c (opencl_language_defn): Initialise new field.
11101 * p-lang.c (pascal_is_string_type_p): New function.
11102 (pascal_language_defn): Initialise new field.
11103 * rust-lang.c (rust_is_string_type_p): New function.
11104 (rust_language_defn): Initialise new field.
11105
721b08c6
AB		 111062019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11107
11108 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11109 New field.
11110 * ada-lang.c (ada_language_defn): Initialise new field.
11111 * c-lang.c (c_language_defn): Likewise.
11112 (cplus_language_defn): Likewise.
11113 (asm_language_defn): Likewise.
11114 (minimal_language_defn): Likewise.
11115 * d-lang.c (d_language_defn): Likewise.
11116 * f-lang.c (f_language_defn): Likewise.
11117 * go-lang.c (go_language_defn): Likewise.
11118 * language.c (unknown_language_defn): Likewise.
11119 (auto_language_defn): Likewise.
11120 * m2-lang.c (m2_language_defn): Likewise.
11121 * objc-lang.c (objc_language_defn): Likewise.
11122 * opencl-lang.c (opencl_language_defn): Likewise.
11123 * p-lang.c (pascal_language_defn): Likewise.
11124 * rust-lang.c (rust_language_defn): Likewise.
11125
fc913e53
AB		 111262019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11127
11128 * ada-lang.c (ada_is_character_type): Change return type to bool.
11129 (ada_is_string_type): Likewise.
11130 * ada-lang.h (ada_is_character_type): Update declaration
11131 (ada_is_string_type): Likewise.
11132
fa731fa0
PW		 111332019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11134
11135 Support style in 'frame|thread apply'
11136
11137 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11138 * record.c (record_start, record_stop): Update callers of
11139 execute_command_to_string with false.
11140 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11141 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11142 methods.
11143 (class string_file): New constructor with term_out parameter.
11144 Override methods term_out and can_emit_style_escape. New member
11145 term_out.
11146 (class stdio_file): Override can_emit_style_escape.
11147 (class tee_file): Override term_out and can_emit_style_escape.
11148 * utils.h (can_emit_style_escape): Remove.
11149 * utils.c (can_emit_style_escape): Likewise.
11150 Update all callers of can_emit_style_escape (SOMESTREAM) to
11151 SOMESTREAM->can_emit_style_escape.
11152 * source-cache.c (source_cache::get_source_lines): Likewise.
11153 * stack.c (frame_apply_command_count): Call execute_command_to_string
11154 passing the term_out characteristic of the current gdb_stdout.
11155 * thread.c (thr_try_catch_cmd): Likewise.
11156 * top.c (execute_command_to_string): pass term_out parameter
11157 to construct the string_file for the command output.
11158 * ui-file.c (term_cli_styling): New function (most code moved
11159 from utils.c can_emit_style_escape).
11160 (string_file::string_file, string_file::can_emit_style_escape,
11161 stdio_file::can_emit_style_escape, tee_file::term_out,
11162 tee_file::can_emit_style_escape): New functions.
11163
136afab8
PW		 111642019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11165
11166 * NEWS: Mention the new set|show may-call-functions.
11167 * infcall.c (may_call_functions_p): New variable.
11168 (show_may_call_functions_p): New function.
11169 (call_function_by_hand_dummy): Throws an error if not
11170 may-call-functions.
11171 (_initialize_infcall): Call add_setshow_boolean_cmd for
11172 may-call-functions.
11173
725cbb63
KS		 111742019-04-25 Keith Seitz <keiths@redhat.com>
11175
11176 PR c++/24367
11177 * cp-support.c (inspect_type): Don't attempt substitutions
11178 of symbol with the same name.
11179
3d1cbb78
TT		 111802019-04-25 Tom Tromey <tromey@adacore.com>
11181
11182 PR gdb/24475:
11183 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11184 static.
11185
94aeb44b
TT		 111862019-04-25 Tom Tromey <tromey@adacore.com>
11187
11188 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11189 rvalue reference.
11190 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11191 (gdb_xml_parser::parse): Use std::move.
11192 * python/python-internal.h (gdbpy_convert_exception): Take a const
11193 reference.
11194 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11195 std::move.
11196 * python/py-utils.c (gdbpy_convert_exception): Take a const
11197 reference.
11198 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11199 Use std::move.
11200 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11201 Use std::move.
11202 * mi/mi-main.c (mi_print_exception): Take a const reference.
11203 * main.c (handle_command_errors): Take a const reference.
11204 * linespec.c (parse_linespec): Use std::move.
11205 * infcall.c (run_inferior_call): Use std::move.
11206 (call_function_by_hand_dummy): Use std::move.
11207 * exec.c (try_open_exec_file): Use std::move.
11208 * exceptions.h (exception_print, exception_fprintf)
11209 (exception_print_same): Update.
11210 * exceptions.c (print_exception, exception_print)
11211 (exception_fprintf, exception_print_same): Change parameters to
11212 const reference.
11213 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11214 * common/new-op.c: Use std::move.
11215 * common/common-exceptions.h (struct gdb_exception): Add move
11216 constructor.
11217 (struct gdb_exception_error, struct gdb_exception_quit, struct
11218 gdb_quit_bad_alloc): Change constructor to move constructor.
11219 (throw_exception): Change parameter to rvalue reference.
11220 * common/common-exceptions.c (throw_exception): Take rvalue
11221 reference.
11222 * cli/cli-interp.c (safe_execute_command): Use std::move.
11223 * breakpoint.c (insert_bp_location, location_to_sals): Use
11224 std::move.
11225
680d7fd5
TT		 112262019-04-25 Tom Tromey <tromey@adacore.com>
11227
11228 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11229 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11230 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11231 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11232 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11233 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11234 guile/scm-value.c: Use unpack.
11235 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11236 gdbscm_gdb_exception.
11237 (gdbscm_throw_gdb_exception): Likewise.
11238 (struct gdbscm_gdb_exception): New.
11239 (unpack): New function.
11240 (gdbscm_wrap): Use unpack.
11241
c6fdd8b2
TT		 112422019-04-25 Tom Tromey <tromey@adacore.com>
11243
11244 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11245 (gdb_rl_callback_handler): Use std::move.
11246 * common/common-exceptions.h (struct gdb_exception): Add move
11247 assignment operator.
11248 (throw_exception_sjlj): Change "exception" to const reference.
11249 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11250 (throw_exception_sjlj): Change "exception" to const reference.
11251
cc06b668
TT		 112522019-04-25 Tom Tromey <tromey@adacore.com>
11253
11254 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11255 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11256 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11257 Update.
11258 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11259 Update.
11260 * mi/mi-interp.c (mi_interp::exec): Update.
11261 * linespec.c (parse_linespec): Update.
11262 * infcall.c (run_inferior_call): Update.
11263 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11264 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11265 (gdbscm_lookup_global_symbol): Update.
11266 * guile/scm-param.c (gdbscm_parameter_value): Update.
11267 * guile/scm-frame.c (gdbscm_frame_read_register)
11268 (gdbscm_frame_read_var): Update.
11269 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11270 * exec.c (try_open_exec_file): Update.
11271 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11272 (gdb_rl_callback_handler): Update.
11273 * common/common-exceptions.h (exception_none): Don't declare.
11274 * common/common-exceptions.c (exception_none): Don't define.
11275 (struct catcher) <exception>: Update.
11276 * cli/cli-interp.c (safe_execute_command): Update.
11277 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11278
cf532bd1
AT		 112792019-04-25 Ali Tamur <tamur@google.com>
11280
11281 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11282 (read_attribute_value): Likewise.
11283 (dwarf2_read_addr_index): Update comment.
11284 (read_str_index): Add DW_FORM_strx.
11285 (dwarf2_string_attr): Likewise.
11286 (dwarf2_const_value_attr): Likewise.
11287 (dump_die_shallow): Likewise.
11288 (dwarf2_fetch_constant_bytes): Likewise.
11289 (skip_form_bytes): Likewise.
11290 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11291
82433e3e
SDJ		 112922019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11293
11294 PR corefiles/11608
11295 PR corefiles/18187
11296 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11297 OFFSET. Verify if current mapping contains an ELF header.
11298 (linux_find_memory_regions_full): Adjust call to
11299 dump_mapping_p.
11300
723adb65
SL		 113012019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11302 Kang Li <kanglictf@gmail.com>
11303
11304 PR gdb/21600
11305
11306 * dwarf2-frame.c (read_initial_length): Be consistent about using
11307 unsigned representation of length.
11308 (decode_frame_entry_1): Likewise. Check for wraparound of
11309 end pointer as well as buffer overflow.
11310
596179f7
SDJ		 113112019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11312
11313 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11314 "vq".
11315
a59240a4
TT		 113162019-04-24 Tom Tromey <tromey@adacore.com>
11317
11318 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11319
f872fdbb
AB		 113202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11321
11322 * s12z-tdep.c (s12z_unwind_pc): Delete.
11323 (s12z_unwind_sp): Delete.
11324 (s12z_gdbarch_init): Don't register deleted functions with
11325 gdbarch.
11326
b614e6f3
AB		 113272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11328
11329 * rl78-tdep.c (rl78_unwind_sp): Delete.
11330 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11331
14faed38
AB		 113322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11333
11334 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11335 (xstormy16_unwind_pc): Delete.
11336 (xstormy16_dummy_id): Delete.
11337 (xstormy16_gdbarch_init): Don't register deleted functions with
11338 gdbarch.
11339
541aad8a
AB		 113402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11341
11342 * vax-tdep.c (vax_unwind_pc): Delete.
11343 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11344
29222070
AB		 113452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11346
11347 * v850-tdep.c (v850_unwind_sp): Delete.
11348 (v850_unwind_pc): Delete.
11349 (v850_dummy_id): Delete.
11350 (v850_gdbarch_init): Don't register deleted functions with
11351 gdbarch.
11352
0f534d76
AB		 113532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11354
11355 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11356 (tilegx_unwind_pc): Delete.
11357 (tilegx_unwind_dummy_id): Delete.
11358 (tilegx_gdbarch_init): Don't register deleted functions with
11359 gdbarch.
11360
1ba7b7f9
AB		 113612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11362
11363 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11364 (tic6x_dummy_id): Delete.
11365 (tic6x_gdbarch_init): Don't register deleted functions with
11366 gdbarch.
11367
d31f262c
AB		 113682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11369
11370 * sparc-tdep.c (sparc_unwind_pc): Delete.
11371 (sparc32_gdbarch_init): Don't register deleted function with
11372 gdbarch.
11373
6d14d64d
AB		 113742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11375
11376 * sh-tdep.c (sh_unwind_sp): Delete.
11377 (sh_unwind_pc): Delete.
11378 (sh_dummy_id): Delete.
11379 (sh_gdbarch_init): Don't register deleted functions with
11380 gdbarch.
11381
a40dde9d
AB		 113822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11383
11384 * score-tdep.c (score_unwind_sp): Delete.
11385 (score_unwind_pc): Delete.
11386 (score_dummy_id): Delete.
11387 (score_gdbarch_init): Don't register deleted functions with
11388 gdbarch.
11389
47c47d69
AB		 113902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11391
11392 * rx-tdep.c (rx_unwind_pc): Delete.
11393 (rx_unwind_sp): Delete.
11394 (rx_dummy_id): Delete.
11395 (rx_gdbarch_init): Don't register deleted functions with
11396 gdbarch. Update comment.
11397
833a4480
AB		 113982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11399
11400 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11401 (rs6000_dummy_id): Delete.
11402 (rs6000_gdbarch_init): Don't register deleted functions with
11403 gdbarch.
11404
3f2cef49
AB		 114052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11406
11407 * or1k-tdep.c (or1k_dummy_id): Delete.
11408 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11409
96acf884
AB		 114102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11411
11412 * nios2-tdep.c (nios2_dummy_id): Delete.
11413 (nios2_unwind_sp): Delete.
11414 (nios2_gdbarch_init): Don't register deleted functions with
11415 gdbarch.
11416
ca0ab0aa
AB		 114172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11418
11419 * nds32-tdep.c (nds32_dummy_id): Delete.
11420 (nds32_unwind_pc): Delete.
11421 (nds32_unwind_sp): Delete.
11422 (nds32_gdbarch_init): Don't register deleted functions with
11423 gdbarch.
11424
c8259044
AB		 114252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11426
11427 * msp430-tdep.c (msp430_unwind_pc): Delete.
11428 (msp430_unwind_sp): Delete.
11429 (msp430_dummy_id): Delete.
11430 (msp430_gdbarch_init): Don't register deleted functions with
11431 gdbarch.
11432
27f113c8
AB		 114332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11434
11435 * moxie-tdep.c (moxie_unwind_sp): Delete.
11436 (moxie_unwind_pc): Delete.
11437 (moxie_dummy_id): Delete.
11438 (moxie_gdbarch_init): Don't register deleted functions with
11439 gdbarch.
11440
aee6c3cd
AB		 114412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11442
11443 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11444 (mn10300_unwind_pc): Delete.
11445 (mn10300_unwind_sp): Delete.
11446 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11447 mn10300_unwind_sp.
11448 (mn10300_frame_unwind_init): Don't register deleted functions with
11449 gdbarch.
11450
8e2b5aea
AB		 114512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11452
11453 * mep-tdep.c (mep_unwind_pc): Delete.
11454 (mep_unwind_sp): Delete.
11455 (mep_dummy_id): Delete.
11456 (mep_gdbarch_init): Don't register deleted functions with
11457 gdbarch.
11458
43cf3ede
AB		 114592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11460
11461 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11462 (m68hc11_unwind_sp): Delete.
11463 (m68hc11_gdbarch_init): Don't register deleted functions with
11464 gdbarch.
11465
5e79b7bb
AB		 114662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11467
11468 * m32r-tdep.c (m32r_unwind_sp): Delete.
11469 (m32r_unwind_pc): Delete.
11470 (m32r_dummy_id): Delete.
11471 (m32r_gdbarch_init): Don't register deleted functions with
11472 gdbarch.
11473
89b268d8
AB		 114742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11475
11476 * m32c-tdep.c (m32c_unwind_pc): Delete.
11477 (m32c_unwind_sp): Delete.
11478 (m32c_dummy_id): Delete.
11479 (m32c_gdbarch_init): Don't register deleted functions with
11480 gdbarch.
11481
946c28d2
AB		 114822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11483
11484 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11485 (lm32_unwind_pc): Delete.
11486 (lm32_dummy_id): Delete.
11487 (lm32_gdbarch_init): Don't register deleted functions with
11488 gdbarch.
11489
bf12844a
AB		 114902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11491
11492 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11493 (iq2000_unwind_pc): Delete.
11494 (iq2000_dummy_id): Delete.
11495 (iq2000_gdbarch_init): Don't register deleted functions with
11496 gdbarch.
11497
ecbc06d2
AB		 114982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11499
11500 * nds32-tdep.c (nds32_type_align): Delete.
11501 (nds32_push_dummy_call): Use type_align instead.
11502
030197b4
AB		 115032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11504
11505 * arm-tdep.c (arm_type_align): Only handle vector override case.
11506 (arm_push_dummy_call): Use type_align.
11507 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11508
b907456c
AB		 115092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11510
11511 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11512 case.
11513 (pass_on_stack): Use type_align.
11514 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11515 function.
11516
9e97ba43
TT		 115172019-04-23 Tom Tromey <tromey@adacore.com>
11518
11519 * dwarf2read.c (line_header::file_name_at): Remove unused
11520 overload.
11521
6892f601
TV		 115222019-04-23 Tom de Vries <tdevries@suse.de>
11523
11524 PR gdb/24438
11525 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11526 invocation.
11527
336d760d
AT		 11528
115292019-03-27 Ali Tamur <tamur@google.com>
11530
11531 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11532 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11533 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11534 (dwarf_expr_context::get_addr_index): Likewise
11535 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11536 (symbol_needs_eval_context::get_addr_index): Likewise
11537 (disassemble_dwarf_expression): Add DW_OP_addrx
11538 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11539 (read_cutu_die_from_dwo): Update comment
11540 (skip_one_die): Add DW_FORM_addrx
11541 (read_attribute_value): Likewise
11542 (var_decode_location): Add DW_OP_addrx
11543 (dwarf2_const_value_attr): Add DW_FORM_addrx
11544 (dump_die_shallow): Likewise
11545 (dwarf2_fetch_constant_bytes): Likewise
11546 (decode_locdesc): Add DW_OP_addrx
11547 (skip_form_bytes): Add DW_FORM_addrx
11548
ad9d13f8
AT		 115492019-04-22 Ali Tamur <tamur@google.com>
11550
11551 * MAINTAINERS (Write After Approval): Add self.
11552
d70cc3ba
SM		 115532019-04-22 Simon Marchi <simon.marchi@efficios.com>
11554
11555 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11556 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11557 (open_symbol_file_object): Likewise.
11558 (svr4_default_sos): Add info parameter.
11559 (svr4_read_so_list): Likewise.
11560 (svr4_current_sos_direct): Adjust functions calls to pass down
11561 info.
11562 (svr4_current_sos_1): Add info parameter.
11563 (svr4_current_sos): Call get_svr4_info, pass info down to
11564 svr4_current_sos_1.
11565 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11566 get_svr4_info.
11567 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11568 get_svr4_info.
11569 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11570 to get_svr4_info.
11571 (probes_table_remove_objfile_probes): Likewise.
11572 (register_solib_event_probe): Add info parameter.
11573 (solist_update_incremental): Pass info parameter down to
11574 svr4_read_so_list.
11575 (disable_probes_interface): Add info parameter.
11576 (svr4_handle_solib_event): Pass current_program_space to
11577 get_svr4_info. Adjust disable_probes_interface cleanup.
11578 (svr4_create_probe_breakpoints): Add info parameter, pass it
11579 down to register_solib_event_probe.
11580 (svr4_create_solib_event_breakpoints): Add info parameter,
11581 pass it down to svr4_create_probe_breakpoints.
11582 (enable_break): Pass info down to
11583 svr4_create_solib_event_breakpoints.
11584 (svr4_solib_create_inferior_hook): Pass current_program_space to
11585 get_svr4_info.
11586 (svr4_clear_solib): Likewise.
11587
7905fc35
PA		 115882019-04-22 Pedro Alves <palves@redhat.com>
11589
11590 * solib-svr4.c (svr4_free_objfile_observer): New.
11591 (probe_and_action::objfile): New field.
11592 (probes_table_htab_remove_objfile_probes)
11593 (probes_table_remove_objfile_probes): New functions.
11594 (register_solib_event_probe): Add 'objfile' parameter. Store it
11595 in the new probe_and_action. Don't store the probe in 'lookup'.
11596 (svr4_create_probe_breakpoints): Pass objfile to
11597 register_solib_event_probe.
11598 (_initialize_svr4_solib): Register a free_objfile observer.
11599
fb881986
TT		 116002019-04-19 Tom Tromey <tom@tromey.com>
11601
11602 * common/queue.h: Remove.
11603
8732db6c
TT		 116042019-04-19 Tom Tromey <tom@tromey.com>
11605
11606 * event-loop.c: Don't include "common/queue.h".
11607
97dfbadd
TT		 116082019-04-19 Tom Tromey <tom@tromey.com>
11609
11610 * remote.c (remote_target): Use delete.
11611 * remote-notif.h: Include <list>, not "common/queue.h".
11612 (notif_client_p): Remove typedef.
11613 (remote_notif_state): Add constructor, destructor, initializer.
11614 <notif_queue>: Now a std::list.
11615 (remote_notif_state_xfree): Don't declare.
11616 * remote-notif.c (remote_notif_process, handle_notification)
11617 (remote_notif_state_allocate): Update.
11618 (~remote_notif_state): Rename from remote_notif_state_xfree.
11619
cf250e36
TT		 116202019-04-19 Tom Tromey <tom@tromey.com>
11621
11622 * symfile.c (reread_symbols): Update.
11623 * objfiles.c (objfile_register_static_link)
11624 (objfile_lookup_static_link): Update
11625 (~objfile) Don't delete static_links.
11626 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11627
61f4b350
TT		 116282019-04-19 Tom Tromey <tom@tromey.com>
11629
11630 * type-stack.h (struct type_stack) <insert>: Constify string.
11631 * type-stack.c (type_stack::insert): Constify string.
11632 * gdbtypes.h (lookup_template_type): Update.
11633 (address_space_name_to_int): Update.
11634 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11635 const.
11636 (lookup_template_type): Make name const.
11637 * c-exp.y: Update rules.
11638 (lex_one_token, classify_name, classify_inner_name)
11639 (c_print_token): Update.
11640 * p-exp.y: Update rules.
11641 (yylex): Update.
11642 * f-exp.y: Update rules.
11643 (yylex): Update.
11644 * d-exp.y: Update rules.
11645 (lex_one_token, classify_name, classify_inner_name): Update.
11646 * parse.c (write_dollar_variable, copy_name): Return std::string.
11647 * parser-defs.h (copy_name): Change return type.
11648 * m2-exp.y: Update rules.
11649 (yylex): Update.
11650 * go-exp.y (lex_one_token): Update.
11651 Update rules.
11652 (classify_unsafe_function, classify_packaged_name)
11653 (classify_name, yylex): Update.
11654
189b8c2e
ST		 116552019-04-19 Sergei Trofimovich <siarheit@google.com>
11656
11657 * configure.ac: add --enable-source-highlight switch.
11658 * configure: Regenerate.
11659 * top.c (print_gdb_version): plumb --enable-source-highlight
11660 status to "show configuration".
11661
8ecb59f8
TT		 116622019-04-19 Tom Tromey <tromey@adacore.com>
11663
11664 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11665 Check ADA_TYPE_P.
11666 (empty_record, ada_template_to_fixed_record_type_1)
11667 (template_to_static_fixed_type)
11668 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11669 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11670 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11671 macros.
11672
62160ec9
TT		 116732019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11674
11675 PR symtab/24423:
11676 * source.c (print_source_lines_base): Advance "iter" when a
11677 control character is seen.
11678
f2ae8bc8
PW		 116792019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11680
11681 * inferior.h (struct infcall_suspend_state_deleter):
11682 Catch exception in destructor to avoid crash.
11683
d563b953
PW		 116842019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11685
11686 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11687 close to the add_com "shell".
11688
dc34c897
TT		 116892019-04-18 Tom Tromey <tromey@adacore.com>
11690
11691 * process-stratum-target.h (class process_stratum_target)
11692 <stratum>: Add "final".
11693
a12e5744
TT		 116942019-04-17 Tom Tromey <tromey@adacore.com>
11695
11696 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11697 against nullptr before use.
11698
a7e559cc
AH		 116992019-04-17 Alan Hayward <alan.hayward@arm.com>
11700
11701 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11702
c01660c6
AB		 117032019-04-17 Jim Wilson <jimw@sifive.com>
11704 Andrew Burgess <andrew.burgess@embecosm.com>
11705
11706 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11707 code read might fail, assume 4-byte breakpoint in that case.
11708
4aa866af
LS		 117092019-04-15 Leszek Swirski <leszeks@google.com>
11710
11711 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11712 rather than a hand-rolled POD check when checking for forced MEMORY
11713 classification.
11714
48574d91
AH		 117152019-04-15 Alan Hayward <alan.hayward@arm.com>
11716
11717 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11718 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11719 function.
11720 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11721 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11722 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11723 declaration.
11724
4da037ef
AH		 117252019-04-15 Alan Hayward <alan.hayward@arm.com>
11726
11727 * aarch64-linux-nat.c
11728 (aarch64_linux_nat_target::thread_architecture): Add override.
11729 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11730 each VQ.
11731
ccb8d7e8
AH		 117322019-04-15 Alan Hayward <alan.hayward@arm.com>
11733
11734 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11735
35add35e
AB		 117362019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11737
11738 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11739 target types of size 96-bits, add some additional comments, and
11740 check that the builtin type we found was the correct size.
11741
51196bbc
EZ		 117422019-04-12 Eli Zaretskii <eliz@gnu.org>
11743
11744 * utils.c (prompt_for_continue): Don't restore the styling at the
11745 end, as applied_style has the wrong value. This fixes styling in
11746 long lists of file names that are interrupted by the "Continue?"
11747 prompt.
11748
62253a61
AB		 117492019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11750
11751 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11752 * c-lang.c (c_language_defn): Likewise.
11753 (cplus_language_defn): Likewise.
11754 (asm_language_defn): Likewise.
11755 (minimal_language_defn): Likewise.
11756 * d-lang.c (d_language_defn): Likewise.
11757 * f-lang.c (f_language_defn): Likewise.
11758 * go-lang.c (go_language_defn): Likewise.
11759 * language.c (unknown_language_defn): Likewise.
11760 (auto_language_defn): Likewise.
11761 * language.h (struct language_defn): Remove la_magic field.
11762 (LANG_MAGIC): Delete.
11763 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11764 * objc-lang.c (objc_language_defn): Likewise.
11765 * opencl-lang.c (opencl_language_defn): Likewise.
11766 * p-lang.c (pascal_language_defn): Likewise.
11767 * rust-lang.c (rust_language_defn): Likewise.
11768
a9158a86
AB		 117692019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11770
11771 * riscv-tdep.c (riscv_type_align): New function.
11772 (riscv_type_alignment): Delete.
11773 (riscv_arg_location): Use 'type_align'.
11774 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11775
41077b66
AB		 117762019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11777
11778 * gdbtypes.c (type_align): A struct with no non-static fields also
11779 has alignment of 1.
11780
9f0272f8
AB		 117812019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11782
11783 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11784 component to 0.
11785 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11786 member.
11787 (riscv_struct_info::analyse): New implementation using new
11788 analyse_inner member function.
11789 (riscv_struct_info::field_offset): New member function.
11790 (riscv_struct_info::m_offsets): New member variable.
11791 (riscv_struct_info::analyse_inner): New private member function,
11792 takes the old implementation of riscv_struct_info::analyse but
11793 extended to track field offsets.
11794 (riscv_call_arg_struct): Update the struct folding special cases
11795 to handle cases where empty C++ structs, which are non-zero
11796 length, are found.
11797 (riscv_arg_location): Initialise the length of each location, a
11798 non-zero length now indicates the location is in use.
11799 (riscv_push_dummy_call): Allow for the first location having a
11800 non-zero offset when setting up arguments.
11801 (riscv_return_value): Likewise, but for return values.
11802
02cf60c7
TT		 118032019-04-11 Tom Tromey <tromey@adacore.com>
11804
11805 * utils.c (internal_vproblem): Make "msg" const.
11806
68811f8f
AH		 118072019-04-11 Alan Hayward <alan.hayward@arm.com>
11808
11809 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11810 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11811 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11812 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11813
3f52fdbc
KB		 118142019-04-10 Kevin Buettner <kevinb@redhat.com>
11815
11816 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11817 function.
11818 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11819 of amd64_collect_native_gregset.
11820 (amd64_linux_nat_target::store_registers): Likewise.
11821
e9ad22ee
TT		 118222019-04-10 Tom Tromey <tom@tromey.com>
11823
11824 * symtab.c (lookup_global_symbol_from_objfile)
11825 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11826 * objfiles.h (class separate_debug_iterator): New.
11827 (class separate_debug_range): New.
11828 (struct objfile) <separate_debug_objfiles>: New method.
11829 (objfile_separate_debug_iterate): Don't declare.
11830 * objfiles.c (separate_debug_iterator::operator++): Rename from
11831 objfile_separate_debug_iterate.
11832 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11833 iterator.
11834 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11835 iterator.
11836
ee371134
TT		 118372019-04-10 Tom Tromey <tom@tromey.com>
11838
11839 * symfile.c (reread_symbols): Remove old comment.
11840 * objfiles.c (free_all_objfiles): Fix a typo.
11841
bf227d61
TT		 118422019-04-10 Tom Tromey <tom@tromey.com>
11843
11844 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11845 * minsyms.c (lookup_minimal_symbol): Use foreach.
11846 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11847 (lookup_minimal_symbol_solib_trampoline): Likewise.
11848 * symfile.c (reread_symbols): Use foreach.
11849
8dc433a0
TT		 118502019-04-09 Ivan Begert <ivanbegert@gmail.com>
11851 Tom Tromey <tromey@adacore.com>
11852
11853 PR rust/24414:
11854 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11855 (rust_lex_int_test): Change "value" to be LONGEST.
11856 (rust_lex_tests): Add test for long integer literal.
11857
9ab8741a
TT		 118582019-04-09 Tom Tromey <tromey@adacore.com>
11859
11860 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11861 to bool.
11862 (extended_remote_target::attach): Update.
11863 (remote_target::remote_notice_new_inferior): Update.
11864 (remote_target::add_current_inferior_and_thread): Update.
11865 * inferior.c (exit_inferior_1): Use "false".
11866 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11867
e242fd12
SM		 118682019-04-09 Simon Marchi <simon.marchi@efficios.com>
11869
9ca1957f 11870 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11871 the "start" command.
11872
2b0c8b01
KB		 118732019-04-08 Kevin Buettner <kevinb@redhat.com>
11874
11875 * python/py-inferior.c (infpy_thread_from_thread_handle):
11876 Adjust comments to reflect renaming of thread_from_thread_handle
11877 to thread_from_handle. Adjust keywords. Fix type error message.
11878 (inferior_object_methods): Add thread_from_handle. Retain
11879 thread_from_thread_handle, but mark it as deprecated.
11880
50a82723
KB		 118812019-04-08 Kevin Buettner <kevinb@redhat.com>
11882
11883 * gdbthread.h (find_thread_by_handle): Revise declaration.
11884 * thread.c (find_thread_by_handle): Likewise. Adjust
11885 implementation too.
11886 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11887 support for buffer objects as handles.
11888
cf63b016
KB		 118892019-04-08 Kevin Buettner <kevinb@redhat.com>
11890
11891 * python/py-infthread.c (thpy_thread_handle): New function.
11892 (thread_object_methods): Register thpy_thread_handle.
11893
3d6c6204
KB		 118942019-04-08 Kevin Buettner <kevinb@redhat.com>
11895
11896 * gdbthread.h (thread_to_thread_handle): Declare.
11897 * thread.c (gdbtypes.h): Include.
11898 (thread_to_thread_handle): New function.
11899
11900 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11901 (target_thread_info_to_thread_handle): Declare.
11902 * target.c (target_thread_info_to_thread_handle): New function.
11903 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11904 * target-delegates.c: Regenerate.
11905
11906 * linux-thread-db.c (class thread_db_target): Add method
11907 thread_info_to_thread_handle.
11908 (thread_db_target::thread_info_to_thread_handle): Define.
11909 * remote.c (class remote_target): Add new method
11910 thread_info_to_thread_handle.
11911 (remote_target::thread_info_to_thread_handle): Define.
11912
56be6ea8
PA		 119132019-04-08 Pedro Alves <palves@redhat.com>
11914
11915 * common/common-exceptions.c (throw_exception): Don't create
11916 named object to throw; throw directly.
11917 (throw_it): Likewise. Don't initialize gdb_exception::message
11918 here, with new; pass FMT and AP to the ctor instead.
11919 * common/common-exceptions.h: Include <string>.
11920 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11921 const char *, va_list)): New ctor. Use std::make_shared.
11922 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11923 errors)): Delete.
11924 (gdb_exception_error::gdb_exception_error(enum errors, const char
11925 *, va_list)): New.
11926 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11927 Add assertion.
11928 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11929 errors)): Delete.
11930 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11931 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11932 Add assertion.
11933
eedc3f4f
TT		 119342019-04-08 Tom Tromey <tom@tromey.com>
11935
11936 * valops.c (value_rtti_indirect_type): Replace throw_exception
11937 with throw.
11938 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11939 with throw.
11940 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11941 throw.
11942 * target.c (target_translate_tls_address): Replace throw_exception
11943 with throw.
11944 * stack.c (frame_apply_command_count): Replace throw_exception
11945 with throw.
11946 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11947 throw.
11948 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11949 with throw.
11950 * rs6000-tdep.c (rs6000_frame_cache)
11951 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11952 * remote.c: Replace throw_exception with throw.
11953 * record-full.c (record_full_message, record_full_wait_1)
11954 (record_full_restore): Replace throw_exception with throw.
11955 * record-btrace.c:
11956 (get_thread_current_frame_id, record_btrace_start_replaying)
11957 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11958 (cmd_record_btrace_start): Replace throw_exception with throw.
11959 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11960 throw.
11961 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11962 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11963 * linespec.c:
11964 (find_linespec_symbols): Replace throw_exception with throw.
11965 * infrun.c (displaced_step_prepare, resume): Replace
11966 throw_exception with throw.
11967 * infcmd.c (post_create_inferior): Replace throw_exception with
11968 throw.
11969 * inf-loop.c (inferior_event_handler): Replace throw_exception
11970 with throw.
11971 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11972 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11973 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11974 (get_prev_frame_always, get_frame_pc_if_available)
11975 (get_frame_address_in_block_if_available, get_frame_language):
11976 Replace throw_exception with throw.
11977 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11978 throw_exception with throw.
11979 * eval.c (fetch_subexp_value, evaluate_var_value)
11980 (evaluate_funcall, evaluate_subexp_standard): Replace
11981 throw_exception with throw.
11982 * dwarf2loc.c (call_site_find_chain)
11983 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11984 Replace throw_exception with throw.
11985 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11986 with throw.
11987 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11988 throw.
11989 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11990 * completer.c (complete_line_internal): Replace throw_exception
11991 with throw.
11992 * compile/compile-object-run.c (compile_object_run): Replace
11993 throw_exception with throw.
11994 * cli/cli-script.c (process_next_line): Replace throw_exception
11995 with throw.
11996 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11997 (btrace_enable, btrace_maint_update_pt_packets): Replace
11998 throw_exception with throw.
11999 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12000 throw_exception with throw.
12001 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12002 throw_exception with throw.
12003 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12004 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12005 * aarch64-tdep.c (aarch64_make_prologue_cache)
12006 (aarch64_make_stub_cache): Replace throw_exception with throw.
12007
26003a20
TT		 120082019-04-08 Tom Tromey <tom@tromey.com>
12009
12010 * common/common-exceptions.c (throw_exception): Rename from
12011 throw_exception_cxx. Remove old copy. Make argument const.
12012 (throw_it): Create and throw exception objects directly.
12013 * common/common-exceptions.h (throw_exception): Make argument
12014 const.
12015 (struct gdb_exception_error): Add constructor.
12016 (struct gdb_exception_quit): Add constructor.
12017
d272eb37
TT		 120182019-04-08 Tom Tromey <tom@tromey.com>
12019
12020 * common/common-exceptions.h (exception_rethrow): Don't declare.
12021 (TRY_SJLJ): Update comment.
12022 (TRY, CATCH, END_CATCH): Remove.
12023 * common/common-exceptions.c (exception_rethrow): Remove.
12024
230d2906
TT		 120252019-04-08 Tom Tromey <tom@tromey.com>
12026
12027 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12028 Remove.
12029 (gdb_exception_error): Rename from
12030 gdb_exception_RETURN_MASK_ERROR.
12031 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12032 (gdb_quit_bad_alloc): Update.
12033 * aarch64-tdep.c: Update.
12034 * ada-lang.c: Update.
12035 * ada-typeprint.c: Update.
12036 * ada-valprint.c: Update.
12037 * amd64-tdep.c: Update.
12038 * arch-utils.c: Update.
12039 * break-catch-throw.c: Update.
12040 * breakpoint.c: Update.
12041 * btrace.c: Update.
12042 * c-varobj.c: Update.
12043 * cli/cli-cmds.c: Update.
12044 * cli/cli-interp.c: Update.
12045 * cli/cli-script.c: Update.
12046 * common/common-exceptions.c: Update.
12047 * common/new-op.c: Update.
12048 * common/selftest.c: Update.
12049 * compile/compile-c-symbols.c: Update.
12050 * compile/compile-cplus-symbols.c: Update.
12051 * compile/compile-object-load.c: Update.
12052 * compile/compile-object-run.c: Update.
12053 * completer.c: Update.
12054 * corelow.c: Update.
12055 * cp-abi.c: Update.
12056 * cp-support.c: Update.
12057 * cp-valprint.c: Update.
12058 * darwin-nat.c: Update.
12059 * disasm-selftests.c: Update.
12060 * dtrace-probe.c: Update.
12061 * dwarf-index-cache.c: Update.
12062 * dwarf-index-write.c: Update.
12063 * dwarf2-frame-tailcall.c: Update.
12064 * dwarf2-frame.c: Update.
12065 * dwarf2loc.c: Update.
12066 * dwarf2read.c: Update.
12067 * eval.c: Update.
12068 * event-loop.c: Update.
12069 * event-top.c: Update.
12070 * exec.c: Update.
12071 * f-valprint.c: Update.
12072 * fbsd-tdep.c: Update.
12073 * frame-unwind.c: Update.
12074 * frame.c: Update.
12075 * gdbtypes.c: Update.
12076 * gnu-v3-abi.c: Update.
12077 * guile/guile-internal.h: Update.
12078 * guile/scm-block.c: Update.
12079 * guile/scm-breakpoint.c: Update.
12080 * guile/scm-cmd.c: Update.
12081 * guile/scm-disasm.c: Update.
12082 * guile/scm-frame.c: Update.
12083 * guile/scm-lazy-string.c: Update.
12084 * guile/scm-math.c: Update.
12085 * guile/scm-param.c: Update.
12086 * guile/scm-ports.c: Update.
12087 * guile/scm-pretty-print.c: Update.
12088 * guile/scm-symbol.c: Update.
12089 * guile/scm-symtab.c: Update.
12090 * guile/scm-type.c: Update.
12091 * guile/scm-value.c: Update.
12092 * i386-linux-tdep.c: Update.
12093 * i386-tdep.c: Update.
12094 * inf-loop.c: Update.
12095 * infcall.c: Update.
12096 * infcmd.c: Update.
12097 * infrun.c: Update.
12098 * jit.c: Update.
12099 * language.c: Update.
12100 * linespec.c: Update.
12101 * linux-fork.c: Update.
12102 * linux-nat.c: Update.
12103 * linux-tdep.c: Update.
12104 * linux-thread-db.c: Update.
12105 * main.c: Update.
12106 * mi/mi-cmd-break.c: Update.
12107 * mi/mi-cmd-stack.c: Update.
12108 * mi/mi-interp.c: Update.
12109 * mi/mi-main.c: Update.
12110 * objc-lang.c: Update.
12111 * p-valprint.c: Update.
12112 * parse.c: Update.
12113 * ppc-linux-tdep.c: Update.
12114 * printcmd.c: Update.
12115 * python/py-arch.c: Update.
12116 * python/py-breakpoint.c: Update.
12117 * python/py-cmd.c: Update.
12118 * python/py-finishbreakpoint.c: Update.
12119 * python/py-frame.c: Update.
12120 * python/py-framefilter.c: Update.
12121 * python/py-gdb-readline.c: Update.
12122 * python/py-inferior.c: Update.
12123 * python/py-infthread.c: Update.
12124 * python/py-lazy-string.c: Update.
12125 * python/py-linetable.c: Update.
12126 * python/py-objfile.c: Update.
12127 * python/py-param.c: Update.
12128 * python/py-prettyprint.c: Update.
12129 * python/py-progspace.c: Update.
12130 * python/py-record-btrace.c: Update.
12131 * python/py-record.c: Update.
12132 * python/py-symbol.c: Update.
12133 * python/py-type.c: Update.
12134 * python/py-unwind.c: Update.
12135 * python/py-utils.c: Update.
12136 * python/py-value.c: Update.
12137 * python/python.c: Update.
12138 * record-btrace.c: Update.
12139 * record-full.c: Update.
12140 * remote-fileio.c: Update.
12141 * remote.c: Update.
12142 * riscv-tdep.c: Update.
12143 * rs6000-aix-tdep.c: Update.
12144 * rs6000-tdep.c: Update.
12145 * rust-exp.y: Update.
12146 * rust-lang.c: Update.
12147 * s390-tdep.c: Update.
12148 * selftest-arch.c: Update.
12149 * solib-dsbt.c: Update.
12150 * solib-frv.c: Update.
12151 * solib-spu.c: Update.
12152 * solib-svr4.c: Update.
12153 * solib.c: Update.
12154 * sparc64-linux-tdep.c: Update.
12155 * stack.c: Update.
12156 * symfile-mem.c: Update.
12157 * symmisc.c: Update.
12158 * target.c: Update.
12159 * thread.c: Update.
12160 * top.c: Update.
12161 * tracefile-tfile.c: Update.
12162 * tui/tui.c: Update.
12163 * typeprint.c: Update.
12164 * unittests/cli-utils-selftests.c: Update.
12165 * unittests/parse-connection-spec-selftests.c: Update.
12166 * valops.c: Update.
12167 * valprint.c: Update.
12168 * value.c: Update.
12169 * varobj.c: Update.
12170 * windows-nat.c: Update.
12171 * x86-linux-nat.c: Update.
12172 * xml-support.c: Update.
12173
a70b8144
TT		 121742019-04-08 Tom Tromey <tom@tromey.com>
12175
12176 * xml-support.c: Use C++ exception handling.
12177 * x86-linux-nat.c: Use C++ exception handling.
12178 * windows-nat.c: Use C++ exception handling.
12179 * varobj.c: Use C++ exception handling.
12180 * value.c: Use C++ exception handling.
12181 * valprint.c: Use C++ exception handling.
12182 * valops.c: Use C++ exception handling.
12183 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12184 handling.
12185 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12186 * typeprint.c: Use C++ exception handling.
12187 * tui/tui.c: Use C++ exception handling.
12188 * tracefile-tfile.c: Use C++ exception handling.
12189 * top.c: Use C++ exception handling.
12190 * thread.c: Use C++ exception handling.
12191 * target.c: Use C++ exception handling.
12192 * symmisc.c: Use C++ exception handling.
12193 * symfile-mem.c: Use C++ exception handling.
12194 * stack.c: Use C++ exception handling.
12195 * sparc64-linux-tdep.c: Use C++ exception handling.
12196 * solib.c: Use C++ exception handling.
12197 * solib-svr4.c: Use C++ exception handling.
12198 * solib-spu.c: Use C++ exception handling.
12199 * solib-frv.c: Use C++ exception handling.
12200 * solib-dsbt.c: Use C++ exception handling.
12201 * selftest-arch.c: Use C++ exception handling.
12202 * s390-tdep.c: Use C++ exception handling.
12203 * rust-lang.c: Use C++ exception handling.
12204 * rust-exp.y: Use C++ exception handling.
12205 * rs6000-tdep.c: Use C++ exception handling.
12206 * rs6000-aix-tdep.c: Use C++ exception handling.
12207 * riscv-tdep.c: Use C++ exception handling.
12208 * remote.c: Use C++ exception handling.
12209 * remote-fileio.c: Use C++ exception handling.
12210 * record-full.c: Use C++ exception handling.
12211 * record-btrace.c: Use C++ exception handling.
12212 * python/python.c: Use C++ exception handling.
12213 * python/py-value.c: Use C++ exception handling.
12214 * python/py-utils.c: Use C++ exception handling.
12215 * python/py-unwind.c: Use C++ exception handling.
12216 * python/py-type.c: Use C++ exception handling.
12217 * python/py-symbol.c: Use C++ exception handling.
12218 * python/py-record.c: Use C++ exception handling.
12219 * python/py-record-btrace.c: Use C++ exception handling.
12220 * python/py-progspace.c: Use C++ exception handling.
12221 * python/py-prettyprint.c: Use C++ exception handling.
12222 * python/py-param.c: Use C++ exception handling.
12223 * python/py-objfile.c: Use C++ exception handling.
12224 * python/py-linetable.c: Use C++ exception handling.
12225 * python/py-lazy-string.c: Use C++ exception handling.
12226 * python/py-infthread.c: Use C++ exception handling.
12227 * python/py-inferior.c: Use C++ exception handling.
12228 * python/py-gdb-readline.c: Use C++ exception handling.
12229 * python/py-framefilter.c: Use C++ exception handling.
12230 * python/py-frame.c: Use C++ exception handling.
12231 * python/py-finishbreakpoint.c: Use C++ exception handling.
12232 * python/py-cmd.c: Use C++ exception handling.
12233 * python/py-breakpoint.c: Use C++ exception handling.
12234 * python/py-arch.c: Use C++ exception handling.
12235 * printcmd.c: Use C++ exception handling.
12236 * ppc-linux-tdep.c: Use C++ exception handling.
12237 * parse.c: Use C++ exception handling.
12238 * p-valprint.c: Use C++ exception handling.
12239 * objc-lang.c: Use C++ exception handling.
12240 * mi/mi-main.c: Use C++ exception handling.
12241 * mi/mi-interp.c: Use C++ exception handling.
12242 * mi/mi-cmd-stack.c: Use C++ exception handling.
12243 * mi/mi-cmd-break.c: Use C++ exception handling.
12244 * main.c: Use C++ exception handling.
12245 * linux-thread-db.c: Use C++ exception handling.
12246 * linux-tdep.c: Use C++ exception handling.
12247 * linux-nat.c: Use C++ exception handling.
12248 * linux-fork.c: Use C++ exception handling.
12249 * linespec.c: Use C++ exception handling.
12250 * language.c: Use C++ exception handling.
12251 * jit.c: Use C++ exception handling.
12252 * infrun.c: Use C++ exception handling.
12253 * infcmd.c: Use C++ exception handling.
12254 * infcall.c: Use C++ exception handling.
12255 * inf-loop.c: Use C++ exception handling.
12256 * i386-tdep.c: Use C++ exception handling.
12257 * i386-linux-tdep.c: Use C++ exception handling.
12258 * guile/scm-value.c: Use C++ exception handling.
12259 * guile/scm-type.c: Use C++ exception handling.
12260 * guile/scm-symtab.c: Use C++ exception handling.
12261 * guile/scm-symbol.c: Use C++ exception handling.
12262 * guile/scm-pretty-print.c: Use C++ exception handling.
12263 * guile/scm-ports.c: Use C++ exception handling.
12264 * guile/scm-param.c: Use C++ exception handling.
12265 * guile/scm-math.c: Use C++ exception handling.
12266 * guile/scm-lazy-string.c: Use C++ exception handling.
12267 * guile/scm-frame.c: Use C++ exception handling.
12268 * guile/scm-disasm.c: Use C++ exception handling.
12269 * guile/scm-cmd.c: Use C++ exception handling.
12270 * guile/scm-breakpoint.c: Use C++ exception handling.
12271 * guile/scm-block.c: Use C++ exception handling.
12272 * guile/guile-internal.h: Use C++ exception handling.
12273 * gnu-v3-abi.c: Use C++ exception handling.
12274 * gdbtypes.c: Use C++ exception handling.
12275 * frame.c: Use C++ exception handling.
12276 * frame-unwind.c: Use C++ exception handling.
12277 * fbsd-tdep.c: Use C++ exception handling.
12278 * f-valprint.c: Use C++ exception handling.
12279 * exec.c: Use C++ exception handling.
12280 * event-top.c: Use C++ exception handling.
12281 * event-loop.c: Use C++ exception handling.
12282 * eval.c: Use C++ exception handling.
12283 * dwarf2read.c: Use C++ exception handling.
12284 * dwarf2loc.c: Use C++ exception handling.
12285 * dwarf2-frame.c: Use C++ exception handling.
12286 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12287 * dwarf-index-write.c: Use C++ exception handling.
12288 * dwarf-index-cache.c: Use C++ exception handling.
12289 * dtrace-probe.c: Use C++ exception handling.
12290 * disasm-selftests.c: Use C++ exception handling.
12291 * darwin-nat.c: Use C++ exception handling.
12292 * cp-valprint.c: Use C++ exception handling.
12293 * cp-support.c: Use C++ exception handling.
12294 * cp-abi.c: Use C++ exception handling.
12295 * corelow.c: Use C++ exception handling.
12296 * completer.c: Use C++ exception handling.
12297 * compile/compile-object-run.c: Use C++ exception handling.
12298 * compile/compile-object-load.c: Use C++ exception handling.
12299 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12300 * compile/compile-c-symbols.c: Use C++ exception handling.
12301 * common/selftest.c: Use C++ exception handling.
12302 * common/new-op.c: Use C++ exception handling.
12303 * cli/cli-script.c: Use C++ exception handling.
12304 * cli/cli-interp.c: Use C++ exception handling.
12305 * cli/cli-cmds.c: Use C++ exception handling.
12306 * c-varobj.c: Use C++ exception handling.
12307 * btrace.c: Use C++ exception handling.
12308 * breakpoint.c: Use C++ exception handling.
12309 * break-catch-throw.c: Use C++ exception handling.
12310 * arch-utils.c: Use C++ exception handling.
12311 * amd64-tdep.c: Use C++ exception handling.
12312 * ada-valprint.c: Use C++ exception handling.
12313 * ada-typeprint.c: Use C++ exception handling.
12314 * ada-lang.c: Use C++ exception handling.
12315 * aarch64-tdep.c: Use C++ exception handling.
12316
3d6e9d23
TT		 123172019-04-08 Tom Tromey <tom@tromey.com>
12318
12319 * xml-support.c (gdb_xml_parser::parse): Update.
12320 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12321 * value.c (show_convenience): Update.
12322 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12323 (test_parse_flags_qcs): Update.
12324 * thread.c (thr_try_catch_cmd): Update.
12325 * target.c (target_translate_tls_address): Update.
12326 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12327 (info_frame_command_core, frame_apply_command_count): Update.
12328 * rust-exp.y (rust_lex_exception_test): Update.
12329 * riscv-tdep.c (riscv_print_one_register_info): Update.
12330 * remote.c (remote_target::enable_btrace): Update.
12331 * record-btrace.c (record_btrace_enable_warn): Update.
12332 * python/py-utils.c (gdbpy_convert_exception): Update.
12333 * printcmd.c (do_one_display, print_variable_and_value): Update.
12334 * mi/mi-main.c (mi_print_exception): Update.
12335 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12336 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12337 * linux-nat.c (linux_nat_target::attach): Update.
12338 * linux-fork.c (class scoped_switch_fork_info): Update.
12339 * infrun.c (displaced_step_prepare): Update.
12340 * infcall.c (call_function_by_hand_dummy): Update.
12341 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12342 * gnu-v3-abi.c (print_one_vtable): Update.
12343 * frame.c (get_prev_frame_always): Update.
12344 * f-valprint.c (info_common_command_for_block): Update.
12345 * exec.c (try_open_exec_file): Update.
12346 * exceptions.c (print_exception, exception_print)
12347 (exception_fprintf, exception_print_same): Update.
12348 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12349 * dwarf-index-cache.c (index_cache::store)
12350 (index_cache::lookup_gdb_index): Update.
12351 * darwin-nat.c (maybe_cache_shell): Update.
12352 * cp-valprint.c (cp_print_value_fields): Update.
12353 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12354 (gcc_cplus_symbol_address): Update.
12355 * compile/compile-c-symbols.c (gcc_convert_symbol)
12356 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12357 * common/selftest.c: Update.
12358 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12359 a std::string.
12360 (exception_try_scope_entry, exception_try_scope_exit): Don't
12361 declare.
12362 (struct exception_try_scope): Remove.
12363 (TRY): Don't use exception_try_scope.
12364 (struct gdb_exception): Add constructor, operator=.
12365 <what>: New method.
12366 (struct gdb_exception_RETURN_MASK_ALL)
12367 (struct gdb_exception_RETURN_MASK_ERROR)
12368 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12369 (struct gdb_quit_bad_alloc): Update.
12370 * common/common-exceptions.c (exception_none): Change
12371 initializer.
12372 (struct catcher) <state, exception>: Initialize inline.
12373 <prev>: Remove member.
12374 (current_catcher): Remove.
12375 (catchers): New global.
12376 (exceptions_state_mc_init): Simplify.
12377 (catcher_pop): Remove.
12378 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12379 (try_scope_depth, exception_try_scope_entry)
12380 (exception_try_scope_exit): Remove.
12381 (throw_exception_sjlj): Update.
12382 (exception_messages, exception_messages_size): Remove.
12383 (throw_it): Simplify.
12384 (gdb_exception_sliced_copy): Remove.
12385 (throw_exception_cxx): Update.
12386 * cli/cli-script.c (script_from_file): Update.
12387 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12388 Update.
12389 * ada-valprint.c (ada_val_print): Update.
12390 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12391 (create_excep_cond_exprs): Update.
12392
c5c10118
TT		 123932019-04-08 Tom Tromey <tom@tromey.com>
12394
12395 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12396 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12397 (TRY, CATCH, END_CATCH): Remove some definitions.
12398 * common/common-exceptions.c: Don't use GDB_XCPT.
12399 (catcher_list_size): Remove.
12400 (throw_exception, throw_it): Simplify.
12401
4de283e4
TT		 124022019-04-05 Tom Tromey <tom@tromey.com>
12403
12404 Revert the header-sorting patch.
12405 * ft32-tdep.c: Revert.
12406 * frv-tdep.c: Revert.
12407 * frv-linux-tdep.c: Revert.
12408 * frame.c: Revert.
12409 * frame-unwind.c: Revert.
12410 * frame-base.c: Revert.
12411 * fork-child.c: Revert.
12412 * findvar.c: Revert.
12413 * findcmd.c: Revert.
12414 * filesystem.c: Revert.
12415 * filename-seen-cache.h: Revert.
12416 * filename-seen-cache.c: Revert.
12417 * fbsd-tdep.c: Revert.
12418 * fbsd-nat.h: Revert.
12419 * fbsd-nat.c: Revert.
12420 * f-valprint.c: Revert.
12421 * f-typeprint.c: Revert.
12422 * f-lang.c: Revert.
12423 * extension.h: Revert.
12424 * extension.c: Revert.
12425 * extension-priv.h: Revert.
12426 * expprint.c: Revert.
12427 * exec.h: Revert.
12428 * exec.c: Revert.
12429 * exceptions.c: Revert.
12430 * event-top.c: Revert.
12431 * event-loop.c: Revert.
12432 * eval.c: Revert.
12433 * elfread.c: Revert.
12434 * dwarf2read.h: Revert.
12435 * dwarf2read.c: Revert.
12436 * dwarf2loc.c: Revert.
12437 * dwarf2expr.h: Revert.
12438 * dwarf2expr.c: Revert.
12439 * dwarf2-frame.c: Revert.
12440 * dwarf2-frame-tailcall.c: Revert.
12441 * dwarf-index-write.h: Revert.
12442 * dwarf-index-write.c: Revert.
12443 * dwarf-index-common.c: Revert.
12444 * dwarf-index-cache.h: Revert.
12445 * dwarf-index-cache.c: Revert.
12446 * dummy-frame.c: Revert.
12447 * dtrace-probe.c: Revert.
12448 * disasm.h: Revert.
12449 * disasm.c: Revert.
12450 * disasm-selftests.c: Revert.
12451 * dictionary.c: Revert.
12452 * dicos-tdep.c: Revert.
12453 * demangle.c: Revert.
12454 * dcache.h: Revert.
12455 * dcache.c: Revert.
12456 * darwin-nat.h: Revert.
12457 * darwin-nat.c: Revert.
12458 * darwin-nat-info.c: Revert.
12459 * d-valprint.c: Revert.
12460 * d-namespace.c: Revert.
12461 * d-lang.c: Revert.
12462 * ctf.c: Revert.
12463 * csky-tdep.c: Revert.
12464 * csky-linux-tdep.c: Revert.
12465 * cris-tdep.c: Revert.
12466 * cris-linux-tdep.c: Revert.
12467 * cp-valprint.c: Revert.
12468 * cp-support.c: Revert.
12469 * cp-namespace.c: Revert.
12470 * cp-abi.c: Revert.
12471 * corelow.c: Revert.
12472 * corefile.c: Revert.
12473 * continuations.c: Revert.
12474 * completer.h: Revert.
12475 * completer.c: Revert.
12476 * complaints.c: Revert.
12477 * coffread.c: Revert.
12478 * coff-pe-read.c: Revert.
12479 * cli-out.h: Revert.
12480 * cli-out.c: Revert.
12481 * charset.c: Revert.
12482 * c-varobj.c: Revert.
12483 * c-valprint.c: Revert.
12484 * c-typeprint.c: Revert.
12485 * c-lang.c: Revert.
12486 * buildsym.c: Revert.
12487 * buildsym-legacy.c: Revert.
12488 * build-id.h: Revert.
12489 * build-id.c: Revert.
12490 * btrace.c: Revert.
12491 * bsd-uthread.c: Revert.
12492 * breakpoint.h: Revert.
12493 * breakpoint.c: Revert.
12494 * break-catch-throw.c: Revert.
12495 * break-catch-syscall.c: Revert.
12496 * break-catch-sig.c: Revert.
12497 * blockframe.c: Revert.
12498 * block.c: Revert.
12499 * bfin-tdep.c: Revert.
12500 * bfin-linux-tdep.c: Revert.
12501 * bfd-target.c: Revert.
12502 * bcache.c: Revert.
12503 * ax-general.c: Revert.
12504 * ax-gdb.h: Revert.
12505 * ax-gdb.c: Revert.
12506 * avr-tdep.c: Revert.
12507 * auxv.c: Revert.
12508 * auto-load.c: Revert.
12509 * arm-wince-tdep.c: Revert.
12510 * arm-tdep.c: Revert.
12511 * arm-symbian-tdep.c: Revert.
12512 * arm-pikeos-tdep.c: Revert.
12513 * arm-obsd-tdep.c: Revert.
12514 * arm-nbsd-tdep.c: Revert.
12515 * arm-nbsd-nat.c: Revert.
12516 * arm-linux-tdep.c: Revert.
12517 * arm-linux-nat.c: Revert.
12518 * arm-fbsd-tdep.c: Revert.
12519 * arm-fbsd-nat.c: Revert.
12520 * arm-bsd-tdep.c: Revert.
12521 * arch-utils.c: Revert.
12522 * arc-tdep.c: Revert.
12523 * arc-newlib-tdep.c: Revert.
12524 * annotate.h: Revert.
12525 * annotate.c: Revert.
12526 * amd64-windows-tdep.c: Revert.
12527 * amd64-windows-nat.c: Revert.
12528 * amd64-tdep.c: Revert.
12529 * amd64-sol2-tdep.c: Revert.
12530 * amd64-obsd-tdep.c: Revert.
12531 * amd64-obsd-nat.c: Revert.
12532 * amd64-nbsd-tdep.c: Revert.
12533 * amd64-nbsd-nat.c: Revert.
12534 * amd64-nat.c: Revert.
12535 * amd64-linux-tdep.c: Revert.
12536 * amd64-linux-nat.c: Revert.
12537 * amd64-fbsd-tdep.c: Revert.
12538 * amd64-fbsd-nat.c: Revert.
12539 * amd64-dicos-tdep.c: Revert.
12540 * amd64-darwin-tdep.c: Revert.
12541 * amd64-bsd-nat.c: Revert.
12542 * alpha-tdep.c: Revert.
12543 * alpha-obsd-tdep.c: Revert.
12544 * alpha-nbsd-tdep.c: Revert.
12545 * alpha-mdebug-tdep.c: Revert.
12546 * alpha-linux-tdep.c: Revert.
12547 * alpha-linux-nat.c: Revert.
12548 * alpha-bsd-tdep.c: Revert.
12549 * alpha-bsd-nat.c: Revert.
12550 * aix-thread.c: Revert.
12551 * agent.c: Revert.
12552 * addrmap.c: Revert.
12553 * ada-varobj.c: Revert.
12554 * ada-valprint.c: Revert.
12555 * ada-typeprint.c: Revert.
12556 * ada-tasks.c: Revert.
12557 * ada-lang.c: Revert.
12558 * aarch64-tdep.c: Revert.
12559 * aarch64-ravenscar-thread.c: Revert.
12560 * aarch64-newlib-tdep.c: Revert.
12561 * aarch64-linux-tdep.c: Revert.
12562 * aarch64-linux-nat.c: Revert.
12563 * aarch64-fbsd-tdep.c: Revert.
12564 * aarch64-fbsd-nat.c: Revert.
12565 * aarch32-linux-nat.c: Revert.
12566
d55e5aa6
TT		 125672019-04-05 Tom Tromey <tom@tromey.com>
12568
12569 * ft32-tdep.c: Sort headers.
12570 * frv-tdep.c: Sort headers.
12571 * frv-linux-tdep.c: Sort headers.
12572 * frame.c: Sort headers.
12573 * frame-unwind.c: Sort headers.
12574 * frame-base.c: Sort headers.
12575 * fork-child.c: Sort headers.
12576 * findvar.c: Sort headers.
12577 * findcmd.c: Sort headers.
12578 * filesystem.c: Sort headers.
12579 * filename-seen-cache.h: Sort headers.
12580 * filename-seen-cache.c: Sort headers.
12581 * fbsd-tdep.c: Sort headers.
12582 * fbsd-nat.h: Sort headers.
12583 * fbsd-nat.c: Sort headers.
12584 * f-valprint.c: Sort headers.
12585 * f-typeprint.c: Sort headers.
12586 * f-lang.c: Sort headers.
12587 * extension.h: Sort headers.
12588 * extension.c: Sort headers.
12589 * extension-priv.h: Sort headers.
12590 * expprint.c: Sort headers.
12591 * exec.h: Sort headers.
12592 * exec.c: Sort headers.
12593 * exceptions.c: Sort headers.
12594 * event-top.c: Sort headers.
12595 * event-loop.c: Sort headers.
12596 * eval.c: Sort headers.
12597 * elfread.c: Sort headers.
12598 * dwarf2read.h: Sort headers.
12599 * dwarf2read.c: Sort headers.
12600 * dwarf2loc.c: Sort headers.
12601 * dwarf2expr.h: Sort headers.
12602 * dwarf2expr.c: Sort headers.
12603 * dwarf2-frame.c: Sort headers.
12604 * dwarf2-frame-tailcall.c: Sort headers.
12605 * dwarf-index-write.h: Sort headers.
12606 * dwarf-index-write.c: Sort headers.
12607 * dwarf-index-common.c: Sort headers.
12608 * dwarf-index-cache.h: Sort headers.
12609 * dwarf-index-cache.c: Sort headers.
12610 * dummy-frame.c: Sort headers.
12611 * dtrace-probe.c: Sort headers.
12612 * disasm.h: Sort headers.
12613 * disasm.c: Sort headers.
12614 * disasm-selftests.c: Sort headers.
12615 * dictionary.c: Sort headers.
12616 * dicos-tdep.c: Sort headers.
12617 * demangle.c: Sort headers.
12618 * dcache.h: Sort headers.
12619 * dcache.c: Sort headers.
12620 * darwin-nat.h: Sort headers.
12621 * darwin-nat.c: Sort headers.
12622 * darwin-nat-info.c: Sort headers.
12623 * d-valprint.c: Sort headers.
12624 * d-namespace.c: Sort headers.
12625 * d-lang.c: Sort headers.
12626 * ctf.c: Sort headers.
12627 * csky-tdep.c: Sort headers.
12628 * csky-linux-tdep.c: Sort headers.
12629 * cris-tdep.c: Sort headers.
12630 * cris-linux-tdep.c: Sort headers.
12631 * cp-valprint.c: Sort headers.
12632 * cp-support.c: Sort headers.
12633 * cp-namespace.c: Sort headers.
12634 * cp-abi.c: Sort headers.
12635 * corelow.c: Sort headers.
12636 * corefile.c: Sort headers.
12637 * continuations.c: Sort headers.
12638 * completer.h: Sort headers.
12639 * completer.c: Sort headers.
12640 * complaints.c: Sort headers.
12641 * coffread.c: Sort headers.
12642 * coff-pe-read.c: Sort headers.
12643 * cli-out.h: Sort headers.
12644 * cli-out.c: Sort headers.
12645 * charset.c: Sort headers.
12646 * c-varobj.c: Sort headers.
12647 * c-valprint.c: Sort headers.
12648 * c-typeprint.c: Sort headers.
12649 * c-lang.c: Sort headers.
12650 * buildsym.c: Sort headers.
12651 * buildsym-legacy.c: Sort headers.
12652 * build-id.h: Sort headers.
12653 * build-id.c: Sort headers.
12654 * btrace.c: Sort headers.
12655 * bsd-uthread.c: Sort headers.
12656 * breakpoint.h: Sort headers.
12657 * breakpoint.c: Sort headers.
12658 * break-catch-throw.c: Sort headers.
12659 * break-catch-syscall.c: Sort headers.
12660 * break-catch-sig.c: Sort headers.
12661 * blockframe.c: Sort headers.
12662 * block.c: Sort headers.
12663 * bfin-tdep.c: Sort headers.
12664 * bfin-linux-tdep.c: Sort headers.
12665 * bfd-target.c: Sort headers.
12666 * bcache.c: Sort headers.
12667 * ax-general.c: Sort headers.
12668 * ax-gdb.h: Sort headers.
12669 * ax-gdb.c: Sort headers.
12670 * avr-tdep.c: Sort headers.
12671 * auxv.c: Sort headers.
12672 * auto-load.c: Sort headers.
12673 * arm-wince-tdep.c: Sort headers.
12674 * arm-tdep.c: Sort headers.
12675 * arm-symbian-tdep.c: Sort headers.
12676 * arm-pikeos-tdep.c: Sort headers.
12677 * arm-obsd-tdep.c: Sort headers.
12678 * arm-nbsd-tdep.c: Sort headers.
12679 * arm-nbsd-nat.c: Sort headers.
12680 * arm-linux-tdep.c: Sort headers.
12681 * arm-linux-nat.c: Sort headers.
12682 * arm-fbsd-tdep.c: Sort headers.
12683 * arm-fbsd-nat.c: Sort headers.
12684 * arm-bsd-tdep.c: Sort headers.
12685 * arch-utils.c: Sort headers.
12686 * arc-tdep.c: Sort headers.
12687 * arc-newlib-tdep.c: Sort headers.
12688 * annotate.h: Sort headers.
12689 * annotate.c: Sort headers.
12690 * amd64-windows-tdep.c: Sort headers.
12691 * amd64-windows-nat.c: Sort headers.
12692 * amd64-tdep.c: Sort headers.
12693 * amd64-sol2-tdep.c: Sort headers.
12694 * amd64-obsd-tdep.c: Sort headers.
12695 * amd64-obsd-nat.c: Sort headers.
12696 * amd64-nbsd-tdep.c: Sort headers.
12697 * amd64-nbsd-nat.c: Sort headers.
12698 * amd64-nat.c: Sort headers.
12699 * amd64-linux-tdep.c: Sort headers.
12700 * amd64-linux-nat.c: Sort headers.
12701 * amd64-fbsd-tdep.c: Sort headers.
12702 * amd64-fbsd-nat.c: Sort headers.
12703 * amd64-dicos-tdep.c: Sort headers.
12704 * amd64-darwin-tdep.c: Sort headers.
12705 * amd64-bsd-nat.c: Sort headers.
12706 * alpha-tdep.c: Sort headers.
12707 * alpha-obsd-tdep.c: Sort headers.
12708 * alpha-nbsd-tdep.c: Sort headers.
12709 * alpha-mdebug-tdep.c: Sort headers.
12710 * alpha-linux-tdep.c: Sort headers.
12711 * alpha-linux-nat.c: Sort headers.
12712 * alpha-bsd-tdep.c: Sort headers.
12713 * alpha-bsd-nat.c: Sort headers.
12714 * aix-thread.c: Sort headers.
12715 * agent.c: Sort headers.
12716 * addrmap.c: Sort headers.
12717 * ada-varobj.c: Sort headers.
12718 * ada-valprint.c: Sort headers.
12719 * ada-typeprint.c: Sort headers.
12720 * ada-tasks.c: Sort headers.
12721 * ada-lang.c: Sort headers.
12722 * aarch64-tdep.c: Sort headers.
12723 * aarch64-ravenscar-thread.c: Sort headers.
12724 * aarch64-newlib-tdep.c: Sort headers.
12725 * aarch64-linux-tdep.c: Sort headers.
12726 * aarch64-linux-nat.c: Sort headers.
12727 * aarch64-fbsd-tdep.c: Sort headers.
12728 * aarch64-fbsd-nat.c: Sort headers.
12729 * aarch32-linux-nat.c: Sort headers.
12730
699bd4cf
TT		 127312019-04-04 Tom Tromey <tom@tromey.com>
12732
12733 * varobj.c (varobj_create): Update.
12734 * rust-exp.y (struct rust_parser) <update_innermost_block,
12735 lookup_symbol>: New methods.
12736 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12737 Rename.
12738 (rust_parser::rust_lookup_type)
12739 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12740 * printcmd.c (display_command, do_one_display): Update.
12741 * parser-defs.h (struct parser_state) <parser_state>: Add
12742 "tracker" parameter.
12743 (block_tracker): New member.
12744 (class innermost_block_tracker) <innermost_block_tracker>: Add
12745 "types" parameter.
12746 <reset>: Remove method.
12747 (innermost_block): Don't declare.
12748 (null_post_parser): Update.
12749 * parse.c (innermost_block): Remove global.
12750 (write_dollar_variable): Update.
12751 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12752 Remove "tracker_types" parameter.
12753 (parse_expression): Add "tracker" parameter.
12754 (parse_expression_for_completion): Update.
12755 (null_post_parser): Add "tracker" parameter.
12756 * p-exp.y: Update rules.
12757 * m2-exp.y: Update rules.
12758 * language.h (struct language_defn) <la_post_parser>: Add
12759 "tracker" parameter.
12760 * go-exp.y: Update rules.
12761 * f-exp.y: Update rules.
12762 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12763 parameter.
12764 * d-exp.y: Update rules.
12765 * c-exp.y: Update rules.
12766 * breakpoint.c (set_breakpoint_condition): Create an
12767 innermost_block_tracker.
12768 (watch_command_1): Likewise.
12769 * ada-lang.c (resolve): Add "tracker" parameter.
12770 (resolve_subexp): Likewise.
12771 * ada-exp.y (write_var_from_sym): Update.
12772
dac43e32
TT		 127732019-04-04 Tom Tromey <tom@tromey.com>
12774
12775 * type-stack.h: New file.
12776 * type-stack.c: New file.
12777 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12778 type-stack.h.
12779 (insert_into_type_stack, insert_type, push_type, push_type_int)
12780 (insert_type_address_space, pop_type, pop_type_int)
12781 (pop_typelist, pop_type_stack, append_type_stack)
12782 (push_type_stack, get_type_stack, push_typelist)
12783 (follow_type_instance_flags, follow_types): Don't declare.
12784 * parse.c (type_stack): Remove global.
12785 (parse_exp_in_context): Update.
12786 (insert_into_type_stack, insert_type, push_type, push_type_int)
12787 (insert_type_address_space, pop_type, pop_type_int)
12788 (pop_typelist, pop_type_stack, append_type_stack)
12789 (push_type_stack, get_type_stack, push_typelist)
12790 (follow_type_instance_flags, follow_types): Remove (moved to
12791 type-stack.c).
12792 * f-exp.y (type_stack): New global.
12793 Update rules.
12794 (push_kind_type, f_parse): Update.
12795 * d-exp.y (type_stack): New global.
12796 Update rules.
12797 (d_parse): Update.
12798 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12799 Update rules.
12800 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12801 (HFILES_NO_SRCDIR): Add type-stack.h.
12802
2a612529
TT		 128032019-04-04 Tom Tromey <tom@tromey.com>
12804
12805 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12806 (rust_parser::convert_ast_to_expression, rust_parse)
12807 (rust_lex_test_completion, rust_lex_tests): Update.
12808 * parser-defs.h (struct expr_completion_state): New.
12809 (struct parser_state) <parser_state>: Add completion parameter.
12810 <mark_struct_expression, mark_completion_tag>: New methods.
12811 <parse_completion, m_completion_state>: New members.
12812 (prefixify_expression, null_post_parser): Update.
12813 (mark_struct_expression, mark_completion_tag): Don't declare.
12814 * parse.c (parse_completion, expout_last_struct)
12815 (expout_tag_completion_type, expout_completion_name): Remove
12816 globals.
12817 (parser_state::mark_struct_expression)
12818 (parser_state::mark_completion_tag): Now methods.
12819 (prefixify_expression): Add last_struct parameter.
12820 (prefixify_subexp): Likewise.
12821 (parse_exp_1): Update.
12822 (parse_exp_in_context): Add cstate parameter. Update.
12823 (parse_expression_for_completion): Create an
12824 expr_completion_state.
12825 (null_post_parser): Add "completion" parameter.
12826 * p-exp.y: Update rules.
12827 (yylex): Update.
12828 * language.h (struct language_defn) <la_post_parser>: Add
12829 "completing" parameter.
12830 * go-exp.y: Update rules.
12831 (lex_one_token): Update.
12832 * expression.h (parse_completion): Don't declare.
12833 * d-exp.y: Update rules.
12834 (lex_one_token): Update rules.
12835 * c-exp.y: Update rules.
12836 (lex_one_token): Update.
12837 * ada-lang.c (resolve): Add "parse_completion" parameter.
12838 (resolve_subexp): Likewise.
12839 (ada_resolve_function): Likewise.
12840
43476f0b
TT		 128412019-04-04 Tom Tromey <tom@tromey.com>
12842
12843 * parser-defs.h (struct parser_state) <start_arglist,
12844 end_arglist>: New methods.
12845 <arglist_len, m_funcall_chain>: New members.
12846 (arglist_len, start_arglist, end_arglist): Don't declare.
12847 * parse.c (arglist_len, funcall_chain): Remove global.
12848 (start_arglist, end_arglist): Remove functions.
12849 (parse_exp_in_context): Update.
12850 * p-exp.y: Update rules.
12851 * m2-exp.y: Update rules.
12852 * go-exp.y: Update rules.
12853 * f-exp.y: Update rules.
12854 * d-exp.y: Update rules.
12855 * c-exp.y: Update rules.
12856
5776fca3
TT		 128572019-04-04 Tom Tromey <tom@tromey.com>
12858
12859 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12860 lex_operator, push_back>: New methods.
12861 Update all rules.
12862 (rust_parser::lex_hex, lex_escape): Rename and update.
12863 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12864 (rust_parser::lex_operator): Rename and update.
12865 (rust_parser::lex_number, rustyylex, rustyyerror)
12866 (rust_lex_test_init, rust_lex_test_sequence)
12867 (rust_lex_test_push_back, rust_lex_tests): Update.
12868 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12869 parameter.
12870 <lexptr, prev_lexptr>: New members.
12871 (lexptr, prev_lexptr): Don't declare.
12872 * parse.c (lexptr, prev_lexptr): Remove globals.
12873 (parse_exp_in_context): Update.
12874 * p-exp.y (yylex, yyerror): Update.
12875 * m2-exp.y (parse_number, yylex, yyerror): Update.
12876 * go-exp.y (lex_one_token, yyerror): Update.
12877 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12878 * d-exp.y (lex_one_token, yyerror): Update.
12879 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12880 (lex_one_token, yyerror): Update.
12881 * ada-lex.l (YY_INPUT): Update.
12882 (rewind_to_char): Update.
12883 * ada-exp.y (yyerror): Update.
12884
8621b685
TT		 128852019-04-04 Tom Tromey <tom@tromey.com>
12886
12887 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12888 * parser-defs.h (struct parser_state) <parser_state>: Add new
12889 parameter.
12890 <comma_terminates>: New member.
12891 (comma_terminates): Don't declare global.
12892 * parse.c (comma_terminates): Remove global.
12893 (parse_exp_in_context): Update.
12894 * p-exp.y (yylex): Update.
12895 * m2-exp.y (yylex): Update.
12896 * go-exp.y (lex_one_token): Update.
12897 * f-exp.y (yylex): Update.
12898 * d-exp.y (lex_one_token): Update.
12899 * c-exp.y (lex_one_token): Update.
12900 * ada-lex.l: Update.
12901
28aaf3fd
TT		 129022019-04-04 Tom Tromey <tom@tromey.com>
12903
12904 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12905 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12906 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12907 * parser-defs.h (paren_depth): Don't declare.
12908 * parse.c (paren_depth): Remove global.
12909 (parse_exp_in_context): Update.
12910 * p-exp.y (paren_depth): New global.
12911 (pascal_parse): Initialize it.
12912 * m2-exp.y (paren_depth): New global.
12913 (m2_parse): Initialize it.
12914 * go-exp.y (paren_depth): New global.
12915 (go_parse): Initialize it.
12916 * f-exp.y (paren_depth): New global.
12917 (f_parse): Initialize it.
12918 * d-exp.y (paren_depth): New global.
12919 (d_parse): Initialize it.
12920 * c-exp.y (paren_depth): New global.
12921 (c_parse): Initialize it.
12922 * ada-lex.l (paren_depth): New global.
12923 (lexer_init): Initialize it.
12924
1e58a4a4
TT		 129252019-04-04 Tom Tromey <tom@tromey.com>
12926
12927 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12928 (rust_parser::convert_ast_to_type)
12929 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12930 * parser-defs.h (struct parser_state) <parser_state>: Add
12931 parameters. Initialize new members.
12932 <expression_context_block, expression_context_pc>: New members.
12933 * parse.c (expression_context_block, expression_context_pc):
12934 Remove globals.
12935 (parse_exp_in_context): Update.
12936 * p-exp.y: Update all rules.
12937 (yylex): Update.
12938 * m2-exp.y: Update all rules.
12939 (yylex): Update.
12940 * go-exp.y (yylex): Update.
12941 * f-exp.y (yylex): Update.
12942 * d-exp.y: Update all rules.
12943 (yylex): Update.
12944 * c-exp.y: Update all rules.
12945 (lex_one_token, classify_name, yylex, c_parse): Update.
12946 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12947
37eedb39
TT		 129482019-04-04 Tom Tromey <tom@tromey.com>
12949
12950 * gdbarch.h, gdbarch.c: Rebuild.
12951 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12952 * stap-probe.h:
12953 (struct stap_parse_info): Replace "parser_state" with
12954 "expr_builder".
12955 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12956 (parser_state): New class.
12957 * parse.c (expr_builder): Rename.
12958 (expr_builder::release): Rename.
12959 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12960 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12961 (write_exp_elt_longcst, write_exp_elt_floatcst)
12962 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12963 (write_exp_string_vector, write_exp_bitstring)
12964 (write_exp_msymbol, mark_struct_expression)
12965 (write_dollar_variable)
12966 (insert_type_address_space, increase_expout_size): Replace
12967 "parser_state" with "expr_builder".
12968 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12969 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12970 "parser_state" with "expr_builder".
12971
73923d7e
TT		 129722019-04-04 Tom Tromey <tom@tromey.com>
12973
12974 * rust-exp.y: Replace "parse_language" with method call.
12975 * p-exp.y:
12976 (yylex): Replace "parse_language" with method call.
12977 * m2-exp.y:
12978 (yylex): Replace "parse_language" with method call.
12979 * go-exp.y (classify_name): Replace "parse_language" with method
12980 call.
12981 * f-exp.y (yylex): Replace "parse_language" with method call.
12982 * d-exp.y (lex_one_token): Replace "parse_language" with method
12983 call.
12984 * c-exp.y:
12985 (lex_one_token, classify_name, yylex): Replace "parse_language"
12986 with method call.
12987 * ada-exp.y (find_primitive_type, type_char)
12988 (type_system_address): Replace "parse_language" with method call.
12989
fa9f5be6
TT		 129902019-04-04 Tom Tromey <tom@tromey.com>
12991
12992 * rust-exp.y: Replace "parse_gdbarch" with method call.
12993 * parse.c (write_dollar_variable, insert_type_address_space):
12994 Replace "parse_gdbarch" with method call.
12995 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12996 call.
12997 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12998 call.
12999 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13000 "parse_gdbarch" with method call.
13001 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13002 with method call.
13003 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13004 "parse_gdbarch" with method call.
13005 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13006 "parse_gdbarch" with method call.
13007 * c-exp.y (parse_type, parse_number, classify_name): Replace
13008 "parse_gdbarch" with method call.
13009 * ada-lex.l: Replace "parse_gdbarch" with method call.
13010 * ada-exp.y (parse_type, find_primitive_type, type_char)
13011 (type_system_address): Replace "parse_gdbarch" with method call.
13012
1201a264
TT		 130132019-04-04 Tom Tromey <tom@tromey.com>
13014
13015 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13016 * stap-probe.c (stap_parse_argument): Update.
13017 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13018 initial_size parameter.
13019 * rust-exp.y (rust_lex_tests): Update.
13020 * parse.c (parser_state): Update.
13021 (parse_exp_in_context): Update.
13022 * parser-defs.h (struct parser_state) <parser_state>: Remove
13023 "initial_size" parameter.
13024
e3980ce2
TT		 130252019-04-04 Tom Tromey <tom@tromey.com>
13026
13027 * parser-defs.h (increase_expout_size): Don't declare.
13028 * parse.c (increase_expout_size): Now static.
13029
e9f8e3f1
TS		 130302019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13031
13032 * gnu-nat.c (gnu_nat_target::wait): Fix
13033 target_waitstatus_to_string call.
13034
d7df6549
AB		 130352019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13036
13037 * eval.c (evaluate_subexp_standard): Handle internal functions
13038 during Fortran function call handling.
13039
8bdc1658
AB		 130402019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13041
13042 * NEWS: Mention new internal functions.
13043 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13044 (read_base_type): Use dwarf2_init_complex_target_type.
13045 * value.c (creal_internal_fn): New function.
13046 (cimag_internal_fn): New function.
13047 (_initialize_values): Register new internal functions.
13048
c29705b7
PW		 130492019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13050
13051 * infrun.c (stop_all_threads): If debug_infrun, always
13052 trace the wait status after wait_one, using
13053 target_waitstatus_to_string and target_pid_to_str.
13054 (handle_inferior_event): Replace various trace of
13055 wait status kind by a single trace.
13056 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13057 wait status kind image by target_waitstatus_to_string.
13058 * target/waitstatus.c (target_waitstatus_to_string): Fix
13059 obsolete comment.
13060
05caa1d2
TT		 130612019-04-01 Tom Tromey <tromey@adacore.com>
13062
13063 PR symtab/23331:
13064 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13065
9d1447e0
SDJ		 130662019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13067 Pedro Alves <palves@redhat.com>
13068
13069 * top.c (quit_force): Call 'finalize_values'.
13070 * value.c (finalize_values): New function.
13071 * value.h (finalize_values): Declare.
13072
7734102d
EZ		 130732019-03-30 Eli Zaretskii <eliz@gnu.org>
13074
13075 * NEWS: Announce $_gdb_major and $_gdb_minor.
13076
13077 * top.c (init_gdb_version_vars): New function.
13078 (gdb_init): Call init_gdb_version_vars.
13079
188e1fa9
TT		 130802019-03-29 Tom Tromey <tromey@adacore.com>
13081
13082 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13083 help text. Remove dead code.
13084
2880242d
KS		 130852019-03-29 Keith Seitz <keiths@redhat.com>
13086
13087 From Siddhesh Poyarekar:
13088 * f-lang.h (f77_get_upperbound): Return LONGEST.
13089 (f77_get_lowerbound): Likewise.
13090 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13091 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13092 print them.
13093 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13094 plongest to format print it.
13095 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13096 (f77_get_upperbound): Likewise.
13097 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13098 LOWER_BOUND to LONGEST.
13099 (f77_create_arrayprint_offset_tbl): Likewise.
13100
cc1defb1
KS		 131012019-03-29 Keith Seitz <keiths@redhat.com>
13102
13103 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13104 %s/pulongest for TYPE_LENGTH instead of %d in format
13105 strings.
13106 * ada-typerint.c (ada_print_type): Likewise.
13107 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13108 * compile/compile-c-support.c (generate_register_struct): Likewise.
13109 * gdbtypes.c (recursive_dump_type): Likewise.
13110 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13111 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13112 instead of %d in format strings.
13113 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13114 to std::min to ULONGEST.
13115 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13116 instead of %d in format strings.
13117 * tracepoint.c (info_scope_command): Likewise.
13118 * typeprint.c (print_offset_data::update)
13119 (print_offset_data::finish): Likewise.
13120 * xtensa-tdep.c (xtensa_store_return_value)
13121 (xtensa_push_dummy_call): Likewise.
13122
e432ccf1
JT		 131232019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13124
13125 * windows-nat.c (display_selector): Fixed format specifications
13126 for 64-bit Cygwin.
13127
65d2b333
PW		 131282019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13129
13130 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13131
f489207e
SL		 131322019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13133
13134 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13135 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13136 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13137 (nios2_linux_init_abi): Install it.
13138
bffa1015
AH		 131392019-03-28 Alan Hayward <alan.hayward@arm.com>
13140
13141 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13142
fc96163a
AH		 131432019-03-28 Alan Hayward <alan.hayward@arm.com>
13144
13145 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13146
20dc7e9b
PW		 131472019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13148 Tom Tromey <tromey@adacore.com>
13149
13150 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13151
7f5331a8
JB		 131522019-03-26 Joel Brobecker <brobecker@adacore.com>
13153
13154 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13155 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13156 method to compute the bounds of range types. Also print "[evaluated]"
13157 if the bounds' values come from a dynamic evaluation.
13158
18c77628
AB		 131592019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13160
13161 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13162 whitespace when pretty printing is on.
13163
53c973f2
AH		 131642019-03-26 Alan Hayward <alan.hayward@arm.com>
13165
e79be6e5 13166 * ppc-linux-nat.c: Add include.
53c973f2 13167
d851aa71
AH		 131682019-03-26 Alan Hayward <alan.hayward@arm.com>
13169
e79be6e5 13170 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13171
2fe7bab7
AH		 131722019-03-26 Alan Hayward <alan.hayward@arm.com>
13173
e79be6e5 13174 * arm-linux-nat.c: Add include.
2fe7bab7 13175
068ef30e
SM		 131762019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13177
13178 * source-cache.c (source_cache::get_source_lines): Re-read
13179 fullname after calling open_source_file.
13180
81a24d04
JB		 131812019-03-25 John Baldwin <jhb@FreeBSD.org>
13182
13183 * NEWS: Mention TLS support for FreeBSD.
13184
79e7ae11
TT		 131852019-03-25 Tom Tromey <tromey@adacore.com>
13186
13187 * minsyms.c (BUNCH_SIZE): Update comment.
13188 (~minimal_symbol_reader): Remove old comment.
13189 (compact_minimal_symbols): Update comment.
13190 (minimal_symbol_reader::install): Remove old comment. Update
13191 other comments.
13192
d45963c2
AH		 131932019-03-25 Alan Hayward <alan.hayward@arm.com>
13194
13195 * s390-linux-nat.c: Add include.
13196
0f83012e
AH		 131972019-03-25 Alan Hayward <alan.hayward@arm.com>
13198
13199 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13200 Call linux_get_hwcap.
13201 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13202 Likewise.
13203 (aarch64_linux_get_hwcap): Remove function.
13204 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13205 declaration.
13206 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13207 linux_get_hwcap.
13208 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13209 * linux-tdep.c (linux_get_hwcap): Add function.
13210 (linux_get_hwcap2): Likewise.
13211 * linux-tdep.h (linux_get_hwcap): Add declaration.
13212 (linux_get_hwcap2): Likewise.
13213 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13214 (ppc_linux_get_hwcap2): Likewise.
13215 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13216 linux_get_hwcap.
13217 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13218 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13219 (ppc_linux_nat_target::read_description): Likewise.
13220 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13221 * s390-linux-nat.c: Likewise.
13222 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13223
6640a367
TT		 132242019-03-24 Tom Tromey <tom@tromey.com>
13225
13226 * ada-lang.c (standard_lookup): Simplify initialization.
13227 (ada_lookup_symbol_nonlocal): Simplify return.
13228 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13229 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13230 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13231 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13232 initialization.
13233 * solib.c (solib_global_lookup): Simplify.
13234 * symtab.c (null_block_symbol): Remove.
13235 (symbol_cache_lookup): Simplify returns.
13236 (lookup_language_this): Simplify returns.
13237 (lookup_symbol_aux): Simplify return.
13238 (lookup_local_symbol): Simplify returns.
13239 (lookup_global_symbol_from_objfile): Simplify return.
13240 (lookup_symbol_in_objfile_symtabs)
13241 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13242 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13243 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13244 * cp-namespace.c (cp_lookup_bare_symbol)
13245 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13246 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13247 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13248 (cp_lookup_symbol_via_imports): Simplify initialization.
13249 (find_symbol_in_baseclass): Likewise.
13250 * symtab.h (null_block_symbol): Remove.
13251 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13252 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13253 (d_lookup_symbol_module): Likewise.
13254 (find_symbol_in_baseclass): Simplify initialization.
13255
a930ebcd
TT		 132562019-03-24 Tom Tromey <tom@tromey.com>
13257
13258 * expression.h: Don't include symtab.h.
13259 (struct block): Forward declare.
13260
582942f4
TT		 132612019-03-24 Tom Tromey <tom@tromey.com>
13262
13263 * c-exp.y (typebase): Remove casts.
13264 * gdbtypes.c (lookup_unsigned_typename, )
13265 (lookup_signed_typename): Remove cast.
13266 * eval.c (parse_to_comma_and_eval): Remove cast.
13267 * parse.c (write_dollar_variable): Remove cast.
13268 * block.h (struct block) <superblock>: Now const.
13269 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13270 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13271 (map_block): Make "block" const.
13272 * symfile.h (struct quick_symbol_functions)
13273 <map_matching_symbols>: Constify block argument to "callback".
13274 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13275 const.
13276 (find_pc_sect_compunit_symtab): Make "b" const.
13277 (find_symbol_at_address): Likewise.
13278 (search_symbols): Likewise.
13279 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13280 (dw2_debug_names_lookup_symbol): Likewise.
13281 (dw2_map_matching_symbols): Update.
13282 * p-valprint.c (pascal_val_print): Remove "block".
13283 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13284 (aux_add_nonlocal_symbols): Make "block" const.
13285 (resolve_subexp): Remove cast.
13286 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13287 const.
13288 (iterate_over_file_blocks): Likewise.
13289 * f-exp.y (%union) <bval>: Remove.
13290 * coffread.c (patch_opaque_types): Make "b" const.
13291 * spu-tdep.c (spu_catch_start): Make "block" const.
13292 * c-valprint.c (print_unpacked_pointer): Remove "block".
13293 * symmisc.c (dump_symtab_1): Make "b" const.
13294 (block_depth): Make "block" const.
13295 * d-exp.y (%union) <bval>: Remove.
13296 * cp-support.h (cp_lookup_rtti_type): Update.
13297 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13298 * psymtab.c (psym_lookup_symbol): Make "block" const.
13299 (maintenance_check_psymtabs): Make "b" const.
13300 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13301 (enumerate_locals, enumerate_args): Update.
13302 * python/py-symtab.c (stpy_global_block): Make "block" const.
13303 (stpy_static_block): Likewise.
13304 * inline-frame.c (block_starting_point_at): Make "new_block"
13305 const.
13306 * block.c (find_block_in_blockvector): Make return type const.
13307 (blockvector_for_pc_sect): Make "b" const.
13308 (find_block_in_blockvector): Make "b" const.
13309
7ad417dd
TT		 133102019-03-23 Tom Tromey <tom@tromey.com>
13311
13312 * varobj.c (varobj_create): Update.
13313 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13314 * printcmd.c (display_command, do_one_display): Don't reset
13315 innermost_block.
13316 * parser-defs.h (enum innermost_block_tracker_type): Move to
13317 expression.h.
13318 (innermost_block): Update comment.
13319 * parse.c (parse_exp_1): Add tracker_types parameter.
13320 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13321 tracker_types parameter. Reset innermost_block.
13322 (parse_exp_in_context): Remove.
13323 (parse_expression_for_completion): Update.
13324 * objfiles.c (~objfile): Don't reset expression_context_block or
13325 innermost_block.
13326 * expression.h (enum innermost_block_tracker_type): Move from
13327 parser-defs.h.
13328 (parse_exp_1): Add tracker_types parameter.
13329 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13330 reset innermost_block.
13331
b366c208
TT		 133322019-03-23 Tom Tromey <tom@tromey.com>
13333
13334 * objfiles.h: Include bcache.h.
13335
9bb9b2f9
TT		 133362019-03-23 Tom Tromey <tom@tromey.com>
13337
13338 * linespec.c (get_current_search_block): Use
13339 scoped_restore_current_language.
13340 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13341
59c28372
AH		 133422019-03-22 Alan Hayward <alan.hayward@arm.com>
13343 Jiong Wang <jiong.wang@arm.com>
13344
13345 * aarch64-linux-tdep.c
13346 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13347 section.
13348 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13349
17e116a7
AH		 133502019-03-22 Alan Hayward <alan.hayward@arm.com>
13351 Jiong Wang <jiong.wang@arm.com>
13352
13353 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13354 instructions.
13355 (aarch64_analyze_prologue_test): Add PACIASP test.
13356 (aarch64_prologue_prev_register): Unmask PC value.
13357
11e1b75f
AH		 133582019-03-22 Alan Hayward <alan.hayward@arm.com>
13359 Jiong Wang <jiong.wang@arm.com>
13360
13361 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13362 (aarch64_dwarf2_prev_register): Unmask PC value.
13363 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13364 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13365 DW_CFA_AARCH64_negate_ra_state.
13366 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13367
34dcc7cf
AH		 133682019-03-22 Alan Hayward <alan.hayward@arm.com>
13369 Jiong Wang <jiong.wang@arm.com>
13370
13371 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13372 registers.
13373 (aarch64_pseudo_register_name): Likewise.
13374 (aarch64_pseudo_register_type): Likewise.
13375 (aarch64_pseudo_register_reggroup_p): Likewise.
13376 (aarch64_gdbarch_init): Add pauth registers.
13377 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13378 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13379 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13380 (struct gdbarch_tdep): Add regnum for ra_state.
13381
1ef53e6b
AH		 133822019-03-22 Alan Hayward <alan.hayward@arm.com>
13383 Jiong Wang <jiong.wang@arm.com>
13384
13385 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13386
76bed0fd
AH		 133872019-03-22 Alan Hayward <alan.hayward@arm.com>
13388 Jiong Wang <jiong.wang@arm.com>
13389
13390 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13391 function.
13392 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13393 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13394 (aarch64_gdbarch_init): Add puth registers.
13395 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13396 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13397 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13398
ee4fbcfa
AH		 133992019-03-22 Alan Hayward <alan.hayward@arm.com>
13400 Jiong Wang <jiong.wang@arm.com>
13401
13402 * aarch64-linux-nat.c
13403 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13404 * aarch64-linux-tdep.c
13405 (aarch64_linux_core_read_description): Likewise.
13406 (aarch64_linux_get_hwcap): New function.
13407 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13408 (aarch64_linux_get_hwcap): New declaration.
13409
6dc0ebde
AH		 134102019-03-22 Alan Hayward <alan.hayward@arm.com>
13411 Jiong Wang <jiong.wang@arm.com>
13412
13413 * aarch64-linux-nat.c
13414 (aarch64_linux_nat_target::read_description): Add pauth param.
13415 * aarch64-linux-tdep.c
13416 (aarch64_linux_core_read_description): Likewise.
13417 * aarch64-tdep.c (struct target_desc): Add in pauth.
13418 (aarch64_read_description): Add pauth param.
13419 (aarch64_gdbarch_init): Likewise.
13420 * aarch64-tdep.h (aarch64_read_description): Likewise.
13421 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13422 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13423 * features/Makefile: Add new files.
13424 * features/aarch64-pauth.c: New file.
13425 * features/aarch64-pauth.xml: New file.
13426
595915c1
TT		 134272019-03-20 Tom Tromey <tromey@adacore.com>
13428
13429 * infrun.c (handle_inferior_event): Rename from
13430 handle_inferior_event_1. Create a scoped_value_mark.
13431 (handle_inferior_event): Remove.
13432
4c7d57e7
TT		 134332019-03-19 Tom Tromey <tromey@adacore.com>
13434
13435 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13436 * infrun.h (print_stop_event): Add "displays" parameter.
13437 * infrun.c (print_stop_event): Add "displays" parameter.
13438
cb246234
PA		 134392019-03-19 Pedro Alves <palves@redhat.com>
13440
13441 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13442 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13443 to -1. Fix TABs vs spaces.
13444 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13445 * tui/tui-out.h (tui_ui_out) Add intro comments.
13446 <m_line, m_start_of_line>: In-class initialize, and add describing
13447 comment.
13448
3a0e45b2
AH		 134492019-03-18 Alan Hayward <alan.hayward@arm.com>
13450
13451 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13452 variable names.
13453 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13454
5371b850
PA		 134552019-03-18 Pedro Alves <palves@redhat.com>
13456 Eli Zaretskii <eliz@gnu.org>
13457
13458 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13459 m_line and m_start_of_line.
13460
b17c4cd0
EZ		 134612019-03-18 Eli Zaretskii <eliz@gnu.org>
13462
13463 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13464 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13465 it returns a newline. This fixes a regression in TU mode, whereby
13466 the next line is output on the same screen line as the user input.
13467
4bd56d18
TT		 134682019-03-18 Tom Tromey <tromey@adacore.com>
13469
13470 * minsyms.c (minimal_symbol_reader::install): Remove call to
13471 obstack_blank.
13472
55c10aca
PA		 134732019-03-18 Pedro Alves <palves@redhat.com>
13474
13475 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13476 New globals.
13477 (apply_style): New, factored out from ...
13478 (apply_ansi_escape): ... this. Handle reverse video mode.
13479 (tui_set_reverse_mode): New function.
13480 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13481 * tui/tui-winsource.c (tui_show_source_line): Use
13482 tui_set_reverse_mode instead of setting A_STANDOUT.
13483 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13484 New setter methods.
13485
647bb750
HD		 134862019-03-18 Hannes Domani <ssbssa@yahoo.de>
13487
13488 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13489 Handle tabs.
13490
bff8c71f
TT		 134912019-03-18 Tom Tromey <tromey@adacore.com>
13492
13493 * ada-lang.c (empty_array): Add "high" parameter.
13494 (ada_evaluate_subexp): Update.
13495
58785d98
ST		 134962019-03-17 Sergei Trofimovich <siarheit@google.com>
13497
13498 * unittests/string_view-selftests.c: Define
13499 _initialize_string_view_selftests unconditionally.
13500
d4cbef22
ВМ		 135012019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13502
13503 PR gdb/24350
13504 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13505
fce4c071
ВМ		 135062019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13507
13508 PR gdb/24351
13509 * windows-nat.c (display_selector): Fix format specifiers.
13510
f7f0a123
EZ		 135112019-03-17 Eli Zaretskii <eliz@gnu.org>
13512
13513 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13514 tui_refill_source_window instead of tui_refresh_win, to update the
13515 current execution line. This fixes redisplay of the current line
13516 when stepping through the code with "next" or "step".
13517
ab42892f
EZ		 135182019-03-16 Eli Zaretskii <eliz@gnu.org>
13519
13520 * source-cache.c (source_cache::get_source_lines): Call
13521 find_source_lines to initialize s->nlines. This fixes vertical
13522 scrolling of TUI source window when the DOWN arrow is pressed.
13523
8d8c087f
PW		 135242019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13525
13526 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13527 linux-thread-db.c (_initialize_thread_db): Likewise.
13528
798e1c30
EZ		 135292019-03-16 Eli Zaretskii <eliz@gnu.org>
13530
13531 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13532 wclrtoeol in tui_show_source_line". This reverts changes made in
13533 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13534
eefba3da
TT		 135352019-03-15 Tom Tromey <tom@tromey.com>
13536
13537 * symtab.h (struct minimal_symbol): Derive from
13538 general_symbol_info.
13539 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13540 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13541 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13542 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13543 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13544 (MSYMBOL_SEARCH_NAME): Update.
13545 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13546 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13547 * minsyms.c (minimal_symbol_reader::record_full): Update.
13548
0de2420c
TT		 135492019-03-15 Tom Tromey <tom@tromey.com>
13550
13551 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13552
042d75e4
TT		 135532019-03-15 Tom Tromey <tom@tromey.com>
13554
13555 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13556 unique_xmalloc_ptr.
13557 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13558 Update.
13559 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13560 (build_minimal_symbol_hash_tables)
13561 (minimal_symbol_reader::install): Update.
13562
db92718b
TT		 135632019-03-15 Tom Tromey <tom@tromey.com>
13564
13565 * symtab.c (create_demangled_names_hash): Update.
13566 (symbol_set_names): Update.
13567 * objfiles.h (struct objfile_per_bfd_storage)
13568 <demangled_names_hash>: Now an htab_up.
13569 * objfiles.c (objfile_per_bfd_storage): Simplify.
13570
d6797f46
TT		 135712019-03-15 Tom Tromey <tom@tromey.com>
13572
13573 * objfiles.h (struct objfile_per_bfd_storage): Declare
13574 destructor.
13575 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13576 New.
13577 (get_objfile_bfd_data): Use new. Don't initialize
13578 language_of_main.
13579 (free_objfile_per_bfd_storage): Remove.
13580 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13581
741d7538
TT		 135822019-03-15 Tom Tromey <tom@tromey.com>
13583
13584 * symfile.c (reread_symbols): Update.
13585 * objfiles.c (objfile::objfile): Update.
13586 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13587 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13588 comment.
13589 (minimal_symbol_reader::install): Update.
13590 (terminate_minimal_symbol_table): Remove.
13591 * jit.c (jit_object_close_impl): Update.
13592
788c80d1
TT		 135932019-03-15 Tom Tromey <tom@tromey.com>
13594
13595 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13596 initializations.
13597
1b7a07cb
TT		 135982019-03-15 Tom Tromey <tom@tromey.com>
13599
13600 * objfiles.h (struct objfile_per_bfd_storage)
13601 <demangled_hash_languages>: Now a bitset.
13602 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13603 (lookup_minimal_symbol): Update.
13604
3db066bc
TT		 136052019-03-15 Tom Tromey <tom@tromey.com>
13606
13607 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13608 Don't return the symbol.
13609 * coffread.c (record_minimal_symbol): Use record_full.
13610
3fff2c37
EZ		 136112019-03-14 Eli Zaretskii <eliz@gnu.org>
13612
13613 The MS-Windows port of ncurses fails to switch to a color pair if
13614 one or both of the colors are the implicit default colors. This
13615 change records the default colors when TUI is initialized, and
13616 then specifies them explicitly when a color pair uses the default
13617 colors. This allows color styling in TUI mode on MS-Windows.
13618
13619 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13620 ncurses_norm_attr.
13621 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13622 colors in ncurses_norm_attr.
13623 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13624 "none", replace it with the default color recorded in
13625 ncurses_norm_attr.
13626
3b336828
TT		 136272019-03-14 Tom Tromey <tromey@adacore.com>
13628
13629 * source-cache.h (class source_cache) <get_source_lines>: Return
13630 std::string.
13631 * source-cache.c (source_cache::extract_lines): Handle case where
13632 first_pos==npos. Return std::string.
13633 (source_cache::get_source_lines): Update.
13634
d085f989
TT		 136352019-03-14 Tom Tromey <tromey@adacore.com>
13636
13637 * NEWS: Add item for "style sources" commands.
13638 * source-cache.c (source_cache::get_source_lines): Check
13639 source_styling.
13640 * cli/cli-style.c (source_styling): New global.
13641 (_initialize_cli_style): Add "style sources" commands.
13642 (show_style_sources): New function.
13643 * cli/cli-style.h (source_styling): Declare.
13644
6f11e682
TT		 136452019-03-14 Pedro Alves <palves@redhat.com>
13646 Tom Tromey <tromey@adacore.com>
13647
13648 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13649 * tui/tui-winsource.c (tui_refill_source_window): New function,
13650 from...
13651 (tui_horizontal_source_scroll): ... here. Move some logic.
13652 * cli/cli-style.c (set_style_enabled): Notify new observable.
13653 * tui/tui-hooks.c (tui_redisplay_source): New function.
13654 (tui_attach_detach_observers): Attach or detach
13655 tui_redisplay_source.
13656 * observable.h (source_styling_changed): New observable.
13657 * observable.c: Define source_styling_changed observable.
13658
a068643d
TT		 136592019-03-13 Tom Tromey <tromey@adacore.com>
13660
13661 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13662 (i386_gnu_nat_target::store_registers): Update.
13663 * target-debug.h (target_debug_print_std_string): New macro.
13664 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13665 * windows-tdep.c (display_one_tib): Update.
13666 * tui/tui-stack.c (tui_make_status_line): Update.
13667 * top.c (print_inferior_quit_action): Update.
13668 * thread.c (thr_try_catch_cmd): Update.
13669 (add_thread_with_info): Update.
13670 (thread_target_id_str): Update.
13671 (thr_try_catch_cmd): Update.
13672 (thread_command): Update.
13673 (thread_find_command): Update.
13674 * record-btrace.c (record_btrace_target::info_record)
13675 (record_btrace_resume_thread, record_btrace_target::resume)
13676 (record_btrace_cancel_resume, record_btrace_step_thread)
13677 (record_btrace_target::wait, record_btrace_target::wait)
13678 (record_btrace_target::wait, record_btrace_target::stop): Update.
13679 * progspace.c (print_program_space): Update.
13680 * process-stratum-target.c
13681 (process_stratum_target::thread_address_space): Update.
13682 * linux-fork.c (linux_fork_mourn_inferior)
13683 (detach_checkpoint_command, info_checkpoints_command)
13684 (linux_fork_context): Update.
13685 (linux_fork_detach): Update.
13686 (class scoped_switch_fork_info): Update.
13687 (delete_checkpoint_command): Update.
13688 * infrun.c (follow_fork_inferior): Update.
13689 (follow_fork_inferior): Update.
13690 (proceed_after_vfork_done): Update.
13691 (handle_vfork_child_exec_or_exit): Update.
13692 (follow_exec): Update.
13693 (displaced_step_prepare_throw): Update.
13694 (displaced_step_restore): Update.
13695 (start_step_over): Update.
13696 (resume_1): Update.
13697 (clear_proceed_status_thread): Update.
13698 (proceed): Update.
13699 (print_target_wait_results): Update.
13700 (do_target_wait): Update.
13701 (context_switch): Update.
13702 (stop_all_threads): Update.
13703 (restart_threads): Update.
13704 (finish_step_over): Update.
13705 (handle_signal_stop): Update.
13706 (switch_back_to_stepped_thread): Update.
13707 (keep_going_pass_signal): Update.
13708 (print_exited_reason): Update.
13709 (normal_stop): Update.
13710 * inferior.c (inferior_pid_to_str): Change return type.
13711 (print_selected_inferior): Update.
13712 (add_inferior): Update.
13713 (detach_inferior): Update.
13714 * dummy-frame.c (fprint_dummy_frames): Update.
13715 * dcache.c (dcache_info_1): Update.
13716 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13717 (btrace_fetch, btrace_clear): Update.
13718 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13719 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13720 type.
13721 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13722 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13723 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13724 * gdbarch.c, gdbarch.h: Rebuild.
13725 * gdbarch.sh (core_pid_to_str): Change return type.
13726 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13727 return type.
13728 (windows_nat_target::pid_to_str): Change return type.
13729 (windows_delete_thread): Update.
13730 (windows_nat_target::attach): Update.
13731 (windows_nat_target::files_info): Update.
13732 * target-delegates.c: Rebuild.
13733 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13734 return type.
13735 (sol_thread_target::pid_to_str): Change return type.
13736 * remote.c (class remote_target) <pid_to_str>: Change return
13737 type.
13738 (remote_target::pid_to_str): Change return type.
13739 (extended_remote_target::attach, remote_target::remote_stop_ns)
13740 (remote_target::remote_notif_remove_queued_reply)
13741 (remote_target::push_stop_reply, remote_target::disable_btrace):
13742 Update.
13743 (extended_remote_target::attach): Update.
13744 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13745 type.
13746 (gdbsim_target::pid_to_str): Change return type.
13747 * ravenscar-thread.c (struct ravenscar_thread_target)
13748 <pid_to_str>: Change return type.
13749 (ravenscar_thread_target::pid_to_str): Change return type.
13750 * procfs.c (class procfs_target) <pid_to_str>: Change return
13751 type.
13752 (procfs_target::pid_to_str): Change return type.
13753 (procfs_target::attach): Update.
13754 (procfs_target::detach): Update.
13755 (procfs_target::fetch_registers): Update.
13756 (procfs_target::store_registers): Update.
13757 (procfs_target::wait): Update.
13758 (procfs_target::files_info): Update.
13759 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13760 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13761 return type.
13762 (nto_procfs_target::pid_to_str): Change return type.
13763 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13764 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13765 return type.
13766 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13767 (exit_lwp): Update.
13768 (attach_proc_task_lwp_callback, get_detach_signal)
13769 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13770 (linux_nat_target::resume, wait_lwp, stop_callback)
13771 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13772 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13773 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13774 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13775 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13776 type.
13777 (inf_ptrace_target::attach): Update.
13778 (inf_ptrace_target::files_info): Update.
13779 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13780 type.
13781 (go32_nat_target::pid_to_str): Change return type.
13782 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13783 (gnu_nat_target::wait): Update.
13784 (gnu_nat_target::wait): Update.
13785 (gnu_nat_target::resume): Update.
13786 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13787 (fbsd_nat_target::wait): Update.
13788 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13789 type.
13790 (darwin_nat_target::attach): Update.
13791 * corelow.c (class core_target) <pid_to_str>: Change return type.
13792 (core_target::pid_to_str): Change return type.
13793 * target.c (normal_pid_to_str): Change return type.
13794 (default_pid_to_str): Likewise.
13795 (target_pid_to_str): Change return type.
13796 (target_translate_tls_address): Update.
13797 (target_announce_detach): Update.
13798 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13799 return type.
13800 (bsd_uthread_target::pid_to_str): Change return type.
13801 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13802 type.
13803 (bsd_kvm_target::pid_to_str): Change return type.
13804 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13805 return type.
13806 (aix_thread_target::pid_to_str): Change return type.
13807 * target.h (struct target_ops) <pid_to_str>: Change return type.
13808 (target_pid_to_str, normal_pid_to_str): Likewise.
13809 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13810 type.
13811 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13812 type.
13813 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13814 return type.
13815 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13816 type.
13817 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13818 type.
13819 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13820 return type.
13821
b4be1b06
SM		 138222019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13823
13824 * NEWS: Mention that the new default MI version is 3. Mention
13825 changes to the output of commands and events that deal with
13826 multi-location breakpoints.
13827 * breakpoint.c: Include "mi/mi-out.h".
13828 (print_one_breakpoint): Change output syntax if using MI version
13829 >= 3.
13830 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13831 New.
13832 (mi_multi_location_breakpoint_output_fixed): New.
13833 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13834 (mi_cmd_fix_multi_location_breakpoint_output): New.
13835 (mi_multi_location_breakpoint_output_fixed): New.
13836 * mi/mi-cmds.c (mi_cmds): Register command
13837 -fix-multi-location-breakpoint-output.
13838 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13839 interpreter "mi".
13840
8e5e5494
SM		 138412019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13842
13843 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13844 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13845 instantiate mi_ui_out based on interpreter name.
13846 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13847 * mi/mi-main.c (mi_load_progress): Likewise.
13848
197df35e
JB		 138492019-03-12 John Baldwin <jhb@FreeBSD.org>
13850
13851 * NEWS: Combine separate "New targets" sections for 8.3.
13852
8399425f
JB		 138532019-03-12 John Baldwin <jhb@FreeBSD.org>
13854
13855 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13856 (ppcfbsd_init_abi): Install gdbarch
13857 "fetch_tls_load_module_address" and "get_thread_local_address"
13858 methods.
13859
b0f87ed0
JB		 138602019-03-12 John Baldwin <jhb@FreeBSD.org>
13861
13862 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13863 (riscv_fbsd_init_abi): Install gdbarch
13864 "fetch_tls_load_module_address" and "get_thread_local_address"
13865 methods.
13866
ce25aa57
JB		 138672019-03-12 John Baldwin <jhb@FreeBSD.org>
13868
13869 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13870 (i386fbsd_init_abi): Install gdbarch
13871 "fetch_tls_load_module_address" and "get_thread_local_address"
13872 methods.
13873
f5424cfa
JB		 138742019-03-12 John Baldwin <jhb@FreeBSD.org>
13875
13876 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13877 (amd64fbsd_init_abi): Install gdbarch
13878 "fetch_tls_load_module_address" and "get_thread_local_address"
13879 methods.
13880
945f3901
JB		 138812019-03-12 John Baldwin <jhb@FreeBSD.org>
13882
13883 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13884 (struct fbsd_pspace_data): New type.
13885 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13886 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13887 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13888 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13889 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13890
ef0bd204
JB		 138912019-03-12 John Baldwin <jhb@FreeBSD.org>
13892
13893 * gdbtypes.c (lookup_struct_elt): New function.
13894 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13895 * gdbtypes.h (struct struct_elt): New type.
13896 (lookup_struct_elt): New prototype.
13897
36c53a02
JB		 138982019-03-12 John Baldwin <jhb@FreeBSD.org>
13899
13900 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13901 remove disabled code block.
13902
6e056c81
JB		 139032019-03-12 John Baldwin <jhb@FreeBSD.org>
13904
13905 * gdbarch.sh (get_thread_local_address): New method.
13906 * gdbarch.h, gdbarch.c: Regenerate.
13907 * target.c (target_translate_tls_address): Use
13908 gdbarch_get_thread_local_address if present instead of
13909 target::get_thread_local_address.
13910
cd250a18
JB		 139112019-03-12 John Baldwin <jhb@FreeBSD.org>
13912
13913 * target.h (target::get_thread_local_address): Update comment.
13914
df22c1e5
JB		 139152019-03-12 John Baldwin <jhb@FreeBSD.org>
13916
13917 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13918 objfile->separate_debug_objfile_backlink if not NULL.
13919
dd6876c9
JB		 139202019-03-12 John Baldwin <jhb@FreeBSD.org>
13921
13922 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13923 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13924 (amd64bsd_store_inferior_registers): Likewise.
13925 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13926 Enable segment base registers.
13927 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13928 PT_GETFSBASE and PT_GETGSBASE.
13929 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13930 PT_SETGSBASE.
13931 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13932 segment base registers.
13933 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13934
1163a4b7
JB		 139352019-03-12 John Baldwin <jhb@FreeBSD.org>
13936
13937 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13938 Update calls to i386_target_description to add 'segments'
13939 parameter.
13940 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13941 add segment base registers.
13942 * arch/i386.c (i386_create_target_description): Add 'segments'
13943 parameter to enable segment base registers.
13944 * arch/i386.h (i386_create_target_description): Likewise.
13945 * features/i386/32bit-segments.xml: New file.
13946 * features/i386/32bit-segments.c: Generate.
13947 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13948 call to i386_target_description to add 'segments' parameter.
13949 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13950 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13951 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13952 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13953 if feature is present.
13954 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13955 Add 'segments' parameter to call to i386_target_description.
13956 (i386_target_description): Add 'segments' parameter to enable
13957 segment base registers.
13958 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13959 to call to i386_target_description.
13960 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13961 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13962 Define I386_NUM_REGS.
13963 (i386_target_description): Add 'segments' parameter to enable
13964 segment base registers.
13965
3a350822
EZ		 139662019-03-12 Eli Zaretskii <eliz@gnu.org>
13967
13968 PR/24325
13969 * source-cache.c: #undef open and close, to avoid unresolved
13970 externals during linking.
13971
ffdd69cf
TT		 139722019-03-12 Tom Tromey <tromey@adacore.com>
13973
13974 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13975 const. Add initializers.
13976 (_initialize_remote): Don't initialize ptid globals.
13977
ec148c57
PA		 139782019-03-12 Pedro Alves <palves@redhat.com>
13979
13980 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13981
32764270
PA		 139822019-03-12 Pedro Alves <palves@redhat.com>
13983
13984 * cp-name-parser.y (main): Remove unused 'len' variable.
13985
17547186
TT		 139862019-03-12 Tom Tromey <tromey@adacore.com>
13987
13988 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13989 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13990
d3a70e03
TT		 139912019-03-12 Tom Tromey <tromey@adacore.com>
13992
13993 * linux-nat.c (iterate_over_lwps): Update.
13994 (stop_callback): Remove parameter.
13995 (stop_wait_callback, detach_callback, resume_set_callback)
13996 (select_singlestep_lwp_callback, set_ignore_sigint)
13997 (status_callback, resumed_callback, resume_clear_callback)
13998 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13999 data parameter.
14000 (linux_nat_target::detach, linux_nat_target::resume)
14001 (linux_stop_and_wait_all_lwps, select_event_lwp)
14002 (linux_nat_filter_event, linux_nat_wait_1)
14003 (linux_nat_target::kill, linux_nat_target::stop)
14004 (linux_nat_target::stop): Update.
14005 (linux_nat_resume_callback): Change type.
14006 (resume_stopped_resumed_lwps, count_events_callback)
14007 (select_event_lwp_callback): Likewise.
14008 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14009 * arm-linux-nat.c (struct update_registers_data): Remove.
14010 (update_registers_callback): Change type.
14011 (arm_linux_insert_hw_breakpoint1): Update.
14012 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14013 parameter.
14014 (x86_linux_dr_set_addr): Update.
14015 (x86_linux_dr_set_control): Update.
14016 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14017 (iterate_over_lwps): Use gdb::function_view.
14018 * nat/aarch64-linux-hw-point.c (struct
14019 aarch64_dr_update_callback_param): Remove.
14020 (debug_reg_change_callback): Change type.
14021 (aarch64_notify_debug_reg_change): Update.
14022 * s390-linux-nat.c (s390_refresh_per_info): Update.
14023
82cb27ff
TT		 140242019-03-11 Tom Tromey <tromey@adacore.com>
14025
14026 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14027 redundant assignment to "this_cu".
14028
568c0683
SM		 140292019-03-08 Simon Marchi <simon.marchi@efficios.com>
14030
14031 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14032
f09ce22d
SM		 140332019-03-08 Simon Marchi <simon.marchi@efficios.com>
14034
14035 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14036 from...
14037 (rank_one_type): ... this.
14038
595f96a9
SM		 140392019-03-08 Simon Marchi <simon.marchi@efficios.com>
14040
14041 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14042 from...
14043 (rank_one_type): ... this.
14044
2598a94b
SM		 140452019-03-08 Simon Marchi <simon.marchi@efficios.com>
14046
14047 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14048 from...
14049 (rank_one_type): ... this.
14050
7f17b20d
SM		 140512019-03-08 Simon Marchi <simon.marchi@efficios.com>
14052
14053 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14054 from...
14055 (rank_one_type): ... this.
14056
2c509035
SM		 140572019-03-08 Simon Marchi <simon.marchi@efficios.com>
14058
14059 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14060 from...
14061 (rank_one_type): ... this.
14062
0dd322dc
SM		 140632019-03-08 Simon Marchi <simon.marchi@efficios.com>
14064
14065 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14066 from...
14067 (rank_one_type): ... this.
14068
41ea4728
SM		 140692019-03-08 Simon Marchi <simon.marchi@efficios.com>
14070
14071 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14072 from...
14073 (rank_one_type): ... this.
14074
793cd1d2
SM		 140752019-03-08 Simon Marchi <simon.marchi@efficios.com>
14076
14077 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14078 from...
14079 (rank_one_type): ... this.
14080
34910087
SM		 140812019-03-08 Simon Marchi <simon.marchi@efficios.com>
14082
14083 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14084 from...
14085 (rank_one_type): ... this.
14086
f1f832d6
SM		 140872019-03-08 Simon Marchi <simon.marchi@efficios.com>
14088
14089 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14090 from...
14091 (rank_one_type): ... this.
14092
b9f4512f
SM		 140932019-03-08 Simon Marchi <simon.marchi@efficios.com>
14094
14095 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14096 from...
14097 (rank_one_type): ... this.
14098
9293fc63
SM		 140992019-03-08 Simon Marchi <simon.marchi@efficios.com>
14100
14101 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14102 from...
14103 (rank_one_type): ... this.
14104
e3abbe7e
PW		 141052019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14106
14107 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14108 inferior-events' shows the example events.
14109
e4adb939
EZ		 141102019-03-08 Eli Zaretskii <eliz@gnu.org>
14111
14112 Support styling on native MS-Windows console
14113
14114 PR/24315
14115 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14116 on MS-Windows if $TERM is not defined.
14117
14118 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14119
14120 * posix-hdep.c (gdb_console_fputs):
14121 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14122 functions.
14123 * ui-file.h (gdb_console_fputs): Add prototype.
14124
14125 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14126 back to fputs only if the former returns zero.
14127
25629dfd
TT		 141282019-03-07 Tom Tromey <tom@tromey.com>
14129
14130 * symmisc.c (print_symbol_bcache_statistics): Update.
14131 (print_objfile_statistics): Update.
14132 * symfile.c (allocate_symtab): Update.
14133 * stabsread.c: Don't include bcache.h.
14134 * psymtab.h (struct psymbol_bcache): Don't declare.
14135 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14136 (psymbol_bcache_init, psymbol_bcache_free)
14137 (psymbol_bcache_get_bcache): Don't declare.
14138 * psymtab.c (struct psymbol_bcache): Remove.
14139 (psymtab_storage::psymtab_storage): Update.
14140 (psymtab_storage::~psymtab_storage): Update.
14141 (psymbol_bcache_init, psymbol_bcache_free)
14142 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14143 (add_psymbol_to_bcache): Update.
14144 (allocate_psymtab): Update.
14145 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14146 macro_cache>: No longer pointers.
14147 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14148 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14149 * macrotab.c (macro_bcache): Update.
14150 * macroexp.c: Don't include bcache.h.
14151 * gdbtypes.c (check_types_worklist): Update.
14152 (types_deeply_equal): Remove TRY/CATCH. Update.
14153 * elfread.c (elf_symtab_read): Update.
14154 * dwarf2read.c: Don't include bcache.h.
14155 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14156 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14157 (print_bcache_statistics, bcache_memory_used): Don't declare.
14158 (struct bcache): Move from bcache.c. Add constructor, destructor,
14159 methods. Rename all data members.
14160 * bcache.c (struct bcache): Move to bcache.h.
14161 (bcache::expand_hash_table): Rename from expand_hash_table.
14162 (bcache): Remove.
14163 (bcache::insert): Rename from bcache_full.
14164 (bcache::compare): Rename from bcache_compare.
14165 (bcache_xmalloc): Remove.
14166 (bcache::~bcache): Rename from bcache_xfree.
14167 (bcache::print_statistics): Rename from print_bcache_statistics.
14168 (bcache::memory_used): Rename from bcache_memory_used.
14169
fe726667
PA		 141702019-03-07 Pedro Alves <palves@redhat.com>
14171
14172 * infrun.c (normal_stop): Also check for
14173 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14174
7584bb30
AB		 141752019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14176
14177 * f-lang.c (value_from_host_double): Moved to...
14178 * value.c (value_from_host_double): ...here.
14179 * value.h (value_from_host_double): Declare.
14180 * guile/scm-math.c (vlscm_convert_typed_number): Use
14181 value_from_host_double.
14182 (vlscm_convert_number): Likewise.
14183 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14184 * python/py-value.c (convert_value_from_python): Likewise.
14185
a7b1986e
TT		 141862019-03-06 Tom Tromey <tom@tromey.com>
14187
14188 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14189
0ccf4211
TT		 141902019-03-06 Tom Tromey <tom@tromey.com>
14191
14192 * utils.h (free_current_contents): Don't declare.
14193 * utils.c (free_current_contents): Remove.
14194
fe7b42e5
TT		 141952019-03-06 Tom Tromey <tom@tromey.com>
14196
14197 * top.c (quit_force): Update.
14198 * main.c (captured_command_loop): Update.
14199 * common/new-op.c (operator new): Update.
14200 * common/common-exceptions.c (struct catcher)
14201 <save_cleanup_chain>: Remove member.
14202 (exceptions_state_mc_init): Update.
14203 (exception_try_scope_entry): Return nullptr.
14204 (exception_try_scope_exit, exception_rethrow)
14205 (throw_exception_sjlj, throw_exception_cxx): Update.
14206 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14207 (all_cleanups, do_cleanups, discard_cleanups)
14208 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14209 (restore_cleanups, restore_final_cleanups): Don't declare.
14210 (do_final_cleanups): Remove parameter.
14211 * common/cleanups.c (cleanup_chain, make_cleanup)
14212 (make_cleanup_dtor, all_cleanups, do_cleanups)
14213 (discard_my_cleanups, discard_cleanups)
14214 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14215 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14216 (null_cleanup): Remove.
14217 (do_final_cleanups): Remove parameter.
14218
c6321f19
TT		 142192019-03-06 Tom Tromey <tom@tromey.com>
14220
14221 * remote.c (remote_target::remote_parse_stop_reply): Use
14222 unique_xmalloc_ptr.
14223
61b30099
TT		 142242019-03-06 Tom Tromey <tom@tromey.com>
14225
14226 * stabsread.c (struct stabs_field_info): Rename from field_info.
14227 <list, fnlist>: Add initializers.
14228 <obstack>: New member.
14229 (read_member_functions, read_struct_fields, read_baseclasses):
14230 Allocate on obstack. Don't use cleanups.
14231 (read_one_struct_field, read_member_functions, read_struct_fields)
14232 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14233 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14234 (read_struct_type): Update.
14235
6cceac94
TT		 142362019-03-06 Tom Tromey <tom@tromey.com>
14237
14238 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14239 * common/filestuff.h (make_cleanup_close): Don't declare.
14240 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14241 Remove.
14242
72412762
TT		 142432019-03-06 Tom Tromey <tom@tromey.com>
14244
14245 * solib-aix.c: Use make_scope_exit.
14246
2b6ff1c0
TT		 142472019-03-06 Tom Tromey <tom@tromey.com>
14248
14249 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14250 Use make_scope_exit.
14251
d01c5877
TT		 142522019-03-06 Tom Tromey <tom@tromey.com>
14253
14254 * solib-svr4.c (disable_probes_interface): Remove parameter.
14255 (svr4_handle_solib_event): Use make_scope_exit.
14256
32603266
TT		 142572019-03-06 Tom Tromey <tom@tromey.com>
14258
14259 * remote.c (struct stop_reply_deleter): Remove.
14260 (stop_reply_up): Update.
14261 (struct stop_reply): Derive from notif_event. Don't typedef.
14262 <regcache>: Now a std::vector.
14263 (stop_reply_xfree): Remove.
14264 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14265 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14266 (remote_target::discard_pending_stop_replies): Use delete.
14267 (remote_target::remote_parse_stop_reply): Update.
14268 (remote_target::process_stop_reply): Update.
14269 * remote-notif.h (struct notif_event): Add virtual destructor.
14270 Remove "dtr" member.
14271 (struct notif_client) <alloc_event>: Return a unique_ptr.
14272 (notif_event_xfree): Don't declare.
14273 (notif_event_up): New typedef.
14274 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14275 (notif_event_xfree, do_notif_event_xfree): Remove.
14276 (remote_notif_state_xfree): Update.
14277
9799571e
TT		 142782019-03-06 Tom Tromey <tom@tromey.com>
14279
14280 * infrun.c (displaced_step_clear_cleanup): Now a
14281 forward_scope_exit type.
14282 (displaced_step_prepare_throw): Update.
14283 (displaced_step_fixup): Update.
14284
09e3c4ca
TT		 142852019-03-06 Tom Tromey <tom@tromey.com>
14286
14287 * inferior.h (class inferior): Update comment.
14288 * gdbthread.h (class thread_info): Update comment.
14289
e2a03548
TT		 142902019-03-06 Joel Brobecker <brobecker@adacore.com>
14291 Tom Tromey <tom@tromey.com>
14292
14293 * stabsread.h (struct stab_section_list): Remove.
14294 (coffstab_build_psymtabs): Update.
14295 * dbxread.c (symbuf_sections): Now a std::vector.
14296 (sect_idx): New global.
14297 (fill_symbuf): Update.
14298 (coffstab_build_psymtabs): Change type of stabsects parameter.
14299 Update.
14300 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14301 std::vector.
14302 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14303 (coff_locate_sections): Update.
14304 (coff_symfile_read): Remove cleanups. Update.
14305 (init_stringtab): Add storage parameter.
14306 (free_stringtab, free_stringtab_cleanup): Remove.
14307 (init_lineno): Add storage parameter.
14308 (free_linetab, free_linetab_cleanup): Remove.
14309
b7e60d85
PA		 143102019-03-06 Pedro Alves <palves@redhat.com>
14311
14312 * linux-fork.c (fork_info::clobber_regs): Delete.
14313 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14314 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14315 comment. Adjust.
14316 (scoped_switch_fork_info::scoped_switch_fork_info)
14317 (checkpoint_command, linux_fork_context): Adjust
14318 fork_save_infrun_state calls.
14319
e52c971f
PA		 143202019-03-06 Pedro Alves <palves@redhat.com>
14321
14322 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14323 (inf_has_multiple_threads): Return 'bool' and rewrite using
14324 inferior_info::threads().
14325
06974e6c
PA		 143262019-03-06 Pedro Alves <palves@redhat.com>
14327
14328 * linux-fork.c: Include <list>.
14329 (fork_list): Now a std::list instance.
14330 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14331 (forks_exist_p, find_last_fork): Adjust.
14332 (new_fork): Delete.
14333 (one_fork_p): New.
14334 (add_fork): Adjust.
14335 (free_fork): Delete, folded into fork_info::~fork_info().
14336 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14337 Adjust.
14338 (init_fork_list): Delete.
14339 (linux_fork_killall, linux_fork_mourn_inferior)
14340 (linux_fork_detach, info_checkpoints_command): Adjust.
14341 (_initialize_linux_fork): No longer call init_fork_list.
14342
72f31aea
PA		 143432019-03-06 Pedro Alves <palves@redhat.com>
14344
14345 * linux-fork.c (new_fork): New, split out of ...
14346 (add_fork): ... this. Return void. Move "first fork" special
14347 case from here, to ...
14348 (checkpoint_command): ... here.
14349 * linux-linux.h (add_fork): Return void.
14350
efbecbc1
AB		 143512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14352
14353 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14354
0841c79a
AB		 143552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14356 Chris January <chris.january@arm.com>
14357 David Lecomber <david.lecomber@arm.com>
14358
14359 * f-exp.y: New token, UNOP_INTRINSIC.
14360 (exp): New pattern using UNOP_INTRINSIC token.
14361 (f77_keywords): Add 'abs' keyword.
14362 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14363 (value_from_host_double): New function.
14364 (evaluate_subexp_f): Support UNOP_ABS.
14365
4a270568
AB		 143662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14367
14368 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14369 types.
14370
067630bd
AB		 143712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14372
14373 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14374 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14375 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14376
3be47f7a
AB		 143772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14378
14379 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14380
4d00f5d8
AB		 143812019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14382 Chris January <chris.january@arm.com>
14383
14384 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14385 * f-exp.y: Define 'KIND' token.
14386 (exp): New pattern for KIND expressions.
14387 (ptype): Handle types with a kind extension.
14388 (direct_abs_decl): Extend to spot kind extensions.
14389 (f77_keywords): Add 'kind' to the list.
14390 (push_kind_type): New function.
14391 (convert_to_kind_type): New function.
14392 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14393 * parse.c (operator_length_standard): Likewise.
14394 * parser-defs.h (enum type_pieces): Add tp_kind.
14395 * std-operator.def: Add UNOP_KIND.
14396
e454224f
AB		 143972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14398
14399 * f-exp.y (f_parse): Set yydebug.
14400
9dad4a58
AB		 144012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14402
14403 * f-lang.c (evaluate_subexp_f): New function.
14404 (exp_descriptor_f): New global.
14405 (f_language_defn): Use exp_descriptor_f instead of
14406 exp_descriptor_standard.
14407
c8f91604
AB		 144082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14409
14410 * f-exp.y (struct token): Add comments.
14411 (dot_ops): Remove uppercase versions and the end marker.
14412 (f77_keywords): Likewise.
14413 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14414 entries in the dot_ops array are case insensitive, and use
14415 strncasecmp to compare strings. Also some whitespace cleanup in
14416 this area. Similar for the f77_keywords array, except entries in
14417 this list might be case sensitive.
14418
dd9f2c76
AB		 144192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14420
14421 * f-exp.y (struct f77_boolean_val): Add comments.
14422 (boolean_values): Remove uppercase versions, and end marker.
14423 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14424 and use strncasecmp to achieve case insensitivity. Additionally,
14425 perform whitespace cleanup around this code.
14426
67a3048c
TT		 144272019-03-06 Tom Tromey <tromey@adacore.com>
14428
14429 * remote-sim.c (gdbsim_target_open): Use result of
14430 gdb_argv::release.
14431
aa3cfbda
RB		 144322019-03-06 Richard Bunt <richard.bunt@arm.com>
14433 Dirk Schubert <dirk.schubert@arm.com>
14434 Chris January <chris.january@arm.com>
14435
14436 * eval.c (evaluate_subexp_standard): Call Fortran argument
14437 wrapping logic.
14438 * f-lang.c (struct value): A value which can be passed into a
14439 Fortran function call.
14440 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14441 where appropriate.
14442 (struct type): Value ready for a Fortran function call.
14443 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14444 is needed.
14445 * f-lang.h (fortran_argument_convert): Declaration.
14446 (fortran_preserve_arg_pointer): Declaration.
14447 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14448
ea38e5df
TT		 144492019-03-05 Tom Tromey <tromey@adacore.com>
14450
14451 * python/py-prettyprint.c (print_string_repr): Remove #if.
14452 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14453
06b5b831
TT		 144542019-03-05 Tom Tromey <tromey@adacore.com>
14455
14456 * target.c (the_dummy_target): Move later. Change type to
14457 "dummy_target".
14458 (initialize_targets): Don't initialize the_dummy_target.
14459
edbd9e45
TT		 144602019-03-05 Tom Tromey <tromey@adacore.com>
14461
14462 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14463 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14464
c119e040
TT		 144652019-03-05 Tom Tromey <tromey@adacore.com>
14466
14467 * windows-nat.c (windows_nat_target::attach)
14468 (windows_nat_target::detach): Don't call gdb_flush.
14469 * valprint.c (generic_val_print, val_print, val_print_string):
14470 Don't call gdb_flush.
14471 * utils.c (defaulted_query): Don't call gdb_flush.
14472 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14473 * target.c (target_announce_detach): Don't call gdb_flush.
14474 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14475 * remote.c (extended_remote_target::attach): Don't call
14476 gdb_flush.
14477 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14478 * printcmd.c (do_examine): Don't call gdb_flush.
14479 (info_display_command): Don't call gdb_flush.
14480 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14481 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14482 * memattr.c (info_mem_command): Don't call gdb_flush.
14483 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14484 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14485 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14486 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14487 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14488 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14489 (gnu_nat_target::detach): Don't call gdb_flush.
14490 * f-valprint.c (f_val_print): Don't call gdb_flush.
14491 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14492 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14493 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14494 gdb_flush.
14495 * c-valprint.c (c_val_print): Don't call gdb_flush.
14496 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14497
895dafa6
TT		 144982019-03-05 Tom Tromey <tromey@adacore.com>
14499
14500 * varobj.c (update_dynamic_varobj_children): Update.
14501 (install_default_visualizer): Use reset, not release.
14502 * value.c (set_internalvar): Update.
14503 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14504 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14505 ATTRIBUTE_UNUSED_RESULT.
14506
88a774b9
TT		 145072019-03-05 Tom Tromey <tromey@adacore.com>
14508
14509 * remote.c (class scoped_remote_fd) <release>: Add
14510 ATTRIBUTE_UNUSED_RESULT.
14511
4e4a8b93
TT		 145122019-03-05 Tom Tromey <tromey@adacore.com>
14513
14514 * macroexp.c (struct macro_buffer) <release>: Add
14515 ATTRIBUTE_UNUSED_RESULT.
14516
083eef1f
TT		 145172019-03-05 Tom Tromey <tromey@adacore.com>
14518
14519 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14520 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14521 ATTRIBUTE_UNUSED_RESULT.
14522
3cabd438
TT		 145232019-03-05 Tom Tromey <tromey@adacore.com>
14524
14525 * common/scoped_fd.h (class scoped_fd) <release>: Add
14526 ATTRIBUTE_UNUSED_RESULT.
14527
41e3300a
TT		 145282019-03-05 Tom Tromey <tromey@adacore.com>
14529
14530 * parser-defs.h (struct parser_state) <release>: Add
14531 ATTRIBUTE_UNUSED_RESULT.
14532
18cb7c9f
TT		 145332019-03-05 Tom Tromey <tromey@adacore.com>
14534
14535 * utils.h (class gdb_argv) <release>: Add
14536 ATTRIBUTE_UNUSED_RESULT.
14537 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14538
41fa577f
EZ		 145392019-03-02 Eli Zaretskii <eliz@gnu.org>
14540
a6a4b2c6
EZ		 14541 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14542 for-loop range, to avoid compiler warnings.
14543
14544 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14545 avoid compiler warnings about unused variables.
14546
742a7df5
EZ		 14547 * NEWS: Mention end of support for native debugging on MS-Windows
14548 before XP.
14549
41fa577f
EZ		 14550 PR gdb/24292
14551 * common/netstuff.c:
14552 * gdbserver/gdbreplay.c
14553 * gdbserver/remote-utils.c:
14554 * ser-tcp.c:
14555 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14556 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14557 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14558 'getaddrinfo' and 'freeaddrinfo' were not available before
14559 Windows XP, and mingw.org's MinGW headers by default define
14560 _WIN32_WINNT to 0x500.
14561
827f438f
GB		 145622019-03-01 Gary Benson <gbenson@redhat.com>
14563
14564 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14565
92137da0
RO		 145662019-02-28 Brian Vandenberg <phantall@gmail.com>
14567 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14568
14569 PR gdb/8527
14570 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14571 set_sigint_trap, clear_sigint_trap.
14572
799efbe8
PW		 145732019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14574
14575 * target.c (target_detach): Clear the regcache and the
14576 frame cache.
14577
8ed25214
PA		 145782019-02-27 Pedro Alves <palves@redhat.com>
14579
14580 * utils.c (set_screen_size): When we cap the height/width sizes,
14581 tweak the corresponding command variable to show "unlimited":
14582
23031e31
SJ		 145832019-02-27 Saagar Jha <saagar@saagarjha.com>
14584 Pedro Alves <palves@redhat.com>
14585
14586 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14587 before calling rl_set_screen_size.
14588
6c28e44a
TT		 145892019-02-27 Tom Tromey <tromey@adacore.com>
14590
14591 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14592 define.
14593 * python/py-value.c: Remove Python 2.4 workaround.
14594 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14595 workaround.
14596 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14597 Python 2.4 workaround.
14598 * python/python-internal.h: Remove Python 2.4 comment.
14599 (Py_ssize_t): Don't define.
14600 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14601 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14602 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14603 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14604 * python/python.c (do_start_initialization): Remove Python 2.4
14605 workaround.
14606 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14607 (print_children): Remove Python 2.4 workaround.
14608 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14609 workaround.
14610 (CHARBUFFERPROC_NAME): Remove.
14611 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14612 Python 2.4 workaround.
14613
2c3fc25d 146142019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14615
2c3fc25d
KB		 14616 * NEWS: Note minimum Python version.
14617
6ca62222
KB		 146182019-02-27 Kevin Buettner <kevinb@redhat.com>
14619
14620 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14621 code from these functions. Remove corresponding ifdefs. Use
14622 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14623 Remove gotos and target of gotos.
14624 (infpy_search_memory): Likewise.
14625
f4bc7d2c
AB		 146262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14627
14628 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14629 (hppa_gdbarch_init): Don't register deleted functions with
14630 gdbarch.
14631
9734a586
AB		 146322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14633
14634 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14635 (h8300_unwind_sp): Delete.
14636 (h8300_dummy_id): Delete.
14637 (h8300_gdbarch_init): Don't register deleted functions with
14638 gdbarch.
14639
68b867f3
AB		 146402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14641
14642 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14643 (ft32_unwind_pc): Delete.
14644 (ft32_unwind_sp): Delete.
14645 (ft32_gdbarch_init): Don't register deleted functions with
14646 gdbarch.
14647
2fbe7ad0
AB		 146482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14649
14650 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14651 (frv_unwind_pc): Delete.
14652 (frv_unwind_sp): Delete.
14653 (frv_gdbarch_init): Don't register deleted functions with
14654 gdbarch.
14655
76055cbe
AB		 146562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14657
14658 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14659 (riscv_unwind_pc): Delete.
14660 (riscv_unwind_sp): Delete.
14661 (riscv_gdbarch_init): Don't register deleted functions with
14662 gdbarch.
14663
4133e5a1
AB		 146642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14665
14666 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14667 (csky_unwind_pc): Delete.
14668 (csky_unwind_sp): Delete.
14669 (csky_gdbarch_init): Don't register deleted functions with
14670 gdbarch.
14671
8010f576
AB		 146722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14673
14674 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14675 (cris_unwind_pc): Delete.
14676 (cris_unwind_sp): Delete.
14677 (cris_gdbarch_init): Don't register deleted functions with
14678 gdbarch.
14679
b56bf084
AB		 146802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14681
14682 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14683 (bfin_unwind_pc): Delete.
14684 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14685
a19a650f
AB		 146862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14687
14688 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14689 (arm_unwind_pc): Delete.
14690 (arm_unwind_sp): Delete.
14691 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14692
f8278c3c
AB		 146932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14694
14695 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14696 (arc_unwind_pc): Delete.
14697 (arc_unwind_sp): Delete.
14698 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14699
480e46cf
AB		 147002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14701
14702 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14703 (alpha_unwind_pc): Delete.
14704 (alpha_gdbarch_init): Don't register deleted functions with
14705 gdbarch.
14706
7a995095
AB		 147072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14708
14709 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14710 (aarch64_unwind_pc): Delete.
14711 (aarch64_unwind_sp): Delete.
14712 (aarch64_gdbarch_init): Don't register deleted functions with
14713 gdbarch.
14714
bf9a735e
AB		 147152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14716
14717 * gdbtypes.c (type_align): Don't consider static members when
14718 computing structure alignment.
14719
5561fc30
AB		 147202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14721
14722 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14723 return 0 for other types.
14724 * arch-utils.c (default_type_align): Always return 0.
14725 * gdbarch.h: Regenerate.
14726 * gdbarch.sh (type_align): Extend comment.
14727 * gdbtypes.c (type_align): Add additional comments, always call
14728 gdbarch_type_align before applying the default rules.
14729 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14730 generic code will then apply a suitable default.
14731 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14732 types, return 0 for other types.
14733
9335e75a
JB		 147342019-02-27 Joel Brobecker <brobecker@adacore.com>
14735
14736 * NEWS: Create a new section for the next release branch.
14737 Rename the section of the current branch, now that it has
14738 been cut.
14739
3d34d8de
JB		 147402019-02-27 Joel Brobecker <brobecker@adacore.com>
14741
14742 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14743 * version.in: Bump version to 8.3.50.DATE-git.
14744
143420fb
SM		 147452019-02-26 Simon Marchi <simon.marchi@efficios.com>
14746
14747 * aix-thread.c (ptid_cmp): Remove unused variable.
14748 (get_signaled_thread): Likewise.
14749 (store_regs_user_thread): Likewise.
14750 (store_regs_kernel_thread): Likewise.
14751 (fetch_regs_kernel_thread): Remove shadowed variable.
14752
172fb711
AB		 147532019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14754
14755 * features/riscv/32bit-cpu.xml: Add register numbers.
14756 * features/riscv/32bit-fpu.c: Regenerate.
14757 * features/riscv/32bit-fpu.xml: Add register numbers.
14758 * features/riscv/64bit-cpu.xml: Add register numbers.
14759 * features/riscv/64bit-fpu.c: Regenerate.
14760 * features/riscv/64bit-fpu.xml: Add register numbers.
14761
26c89782
KB		 147622019-02-26 Kevin Buettner <kevinb@redhat.com>
14763
af54ade9 14764 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14765 * python/py-value.c (convert_buffer_and_type_to_value): New
14766 function.
14767 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14768 Add support for handling an optional second argument. Call
14769 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14770 * python/python-internal.h (Py_buffer_deleter): New struct.
14771 (Py_buffer_up): New typedef.
14772
0f58c9e8
JB		 147732019-02-25 John Baldwin <jhb@FreeBSD.org>
14774
14775 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14776 instead of releasing ownership.
14777
0a0f4c01
JR		 147782019-02-25 Jordan Rupprecht <rupprecht@google.com>
14779
14780 * dwarf2read.c (open_and_init_dwp_file): Call
14781 elf_numsections instead of bfd_count_sections to initialize
14782 dwp_file->num_sections.
14783
cd5a152c
TT		 147842019-02-25 Tom Tromey <tromey@adacore.com>
14785
14786 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14787
8a6a8513
SDJ		 147882019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14789
14790 * gcore.in: Add '--readnever' option when invoking GDB.
14791
04dcda9c
SM		 147922019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14793
14794 * MAINTAINERS: Update my email address.
14795
07bc701d
SM		 147962019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14797
14798 * build-id.c (build_id_to_debug_bfd_1): New function.
14799 (build_id_to_debug_bfd): Look for separate debug file in
14800 sysroot.
14801
c6f4a5d0
AB		 148022019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14803
14804 * gdbarch.sh: Update the copyright year range that is placed into
14805 generated files.
14806
9600246d
KS		 148072019-02-22 Keith Seitz <keiths@redhat.com>
14808
14809 PR symtab/23853
14810 * linespec.c (create_sals_line_offset): Search for the default
14811 symtab's filename instead of its fullname.
14812
7557a514
AH		 148132019-02-21 Alan Hayward <alan.hayward@arm.com>
14814
14815 * NEWS: Update style defaults.
14816
ee2bcb0c
AH		 148172019-02-21 Alan Hayward <alan.hayward@arm.com>
14818
14819 * main.c (captured_main_1): Disable styling in batch mode.
14820
0c95f9ed
TT		 148212019-02-20 Tom Tromey <tom@tromey.com>
14822
14823 * symtab.c (symtab_symbol_info): Fix typos.
14824
c763b894
TT		 148252019-02-20 Tom Tromey <tromey@adacore.com>
14826
14827 * findcmd.c (_initialize_mem_search): Use upper case for
14828 metasyntactic variables.
14829
0ef8a082
AH		 148302019-02-20 Alan Hayward <alan.hayward@arm.com>
14831
14832 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14833 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14834
6caa91b6
SM		 148352019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14836
14837 * top.h (source_file_name): Change to std::string.
14838 * top.c (source_file_name): Likewise.
14839 (command_line_input): Adjust.
14840 * cli/cli-script.c (script_from_file): Adjust.
14841
98814c6c
TT		 148422019-02-19 Tom Tromey <tromey@adacore.com>
14843
14844 * ravenscar-thread.c
14845 (ravenscar_thread_target::update_thread_list): Don't call
14846 ada_build_task_list.
14847 * ada-lang.h (ada_build_task_list): Don't declare.
14848 * ada-tasks.c (struct ada_tasks_inferior_data)
14849 <task_list_valid_p>: Now bool.
14850 (read_known_tasks, ada_task_list_changed)
14851 (ada_tasks_invalidate_inferior_data): Update.
14852 (read_known_tasks_array): Return bool.
14853 (read_known_tasks_list): Likewise.
14854 (read_known_tasks): Return void.
14855 (ada_build_task_list): Now static.
14856
70cd633e
AB		 148572019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14858
14859 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14860 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14861
040b3e95
PW		 148622019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14863
14864 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14865 variant for ada_tasks_pspace_data_handle and
14866 ada_tasks_inferior_data_handle.
14867 (ada_tasks_pspace_data_cleanup): New function.
14868 (ada_tasks_inferior_data_cleanup): New function.
14869
9409233b
TT		 148702019-02-17 Tom Tromey <tom@tromey.com>
14871
14872 * macrotab.h (macro_source_fullname): Return a std::string.
14873 * macrotab.c (macro_include, check_for_redefinition)
14874 (macro_undef, macro_lookup_definition, foreach_macro)
14875 (foreach_macro_in_scope): Update.
14876 (macro_source_fullname): Return a std::string.
14877 * macrocmd.c (show_pp_source_pos): Update.
14878
6506371f
TT		 148792019-02-17 Tom Tromey <tom@tromey.com>
14880
14881 * macrocmd.c (show_pp_source_pos): Style the file names.
14882
0c820d67
TT		 148832019-02-17 Tom Tromey <tom@tromey.com>
14884
14885 PR tui/24197:
14886 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14887
a0087920
TT		 148882019-02-17 Tom Tromey <tom@tromey.com>
14889
14890 * ada-lang.c (user_select_syms): Use filtered printing.
14891 * utils.c (wrap_style): New global.
14892 (desired_style): Remove.
14893 (emit_style_escape): Add stream parameter.
14894 (set_output_style, reset_terminal_style, prompt_for_continue):
14895 Update.
14896 (flush_wrap_buffer): Only flush gdb_stdout.
14897 (wrap_here): Set wrap_style.
14898 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14899 treat escape sequences as a character. Change when wrap buffer is
14900 flushed.
14901 (fputs_styled): Do not set the output style when the default is
14902 requested.
14903 * ui-style.h (struct ui_file_style) <is_default>: New method.
14904 * source.c (print_source_lines_base): Emit escape sequences in one
14905 piece.
14906
75ba10dc
JB		 149072019-02-17 Joel Brobecker <brobecker@adacore.com>
14908
14909 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14910 integers and enumeration types.
14911
a2cd4f14
JB		 149122019-02-17 Joel Brobecker <brobecker@adacore.com>
14913
14914 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14915 instead of lookup_symbol_in_language
14916 (do_exact_match): New function.
14917 (ada_get_symbol_name_matcher): Return do_exact_match when
14918 doing a verbatim match.
14919
485b851b
TT		 149202019-02-15 Tom Tromey <tromey@adacore.com>
14921
14922 * ravenscar-thread.c (ravenscar_thread_target::resume)
14923 (ravenscar_thread_target::wait): Special case wildcard requests.
14924
0b790b1e
TT		 149252019-02-15 Tom Tromey <tromey@adacore.com>
14926
14927 * ravenscar-thread.c (base_ptid): Remove.
14928 (struct ravenscar_thread_target) <close>: New method.
14929 <m_base_ptid>: New member.
14930 <update_inferior_ptid, active_task, task_is_currently_active,
14931 runtime_initialized>: Declare methods.
14932 <ravenscar_thread_target>: Add constructor.
14933 (ravenscar_thread_target::task_is_currently_active)
14934 (ravenscar_thread_target::update_inferior_ptid)
14935 (ravenscar_runtime_initialized): Rename. Now methods.
14936 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14937 (ravenscar_thread_target::update_thread_list): Update.
14938 (ravenscar_thread_target::active_task): Now method.
14939 (ravenscar_thread_target::store_registers)
14940 (ravenscar_thread_target::prepare_to_store)
14941 (ravenscar_thread_target::prepare_to_store)
14942 (ravenscar_thread_target::mourn_inferior): Update.
14943 (ravenscar_inferior_created): Use "new" to create target.
14944 (ravenscar_thread_target::get_ada_task_ptid): Update.
14945 (_initialize_ravenscar): Don't initialize base_ptid.
14946 (ravenscar_ops): Remove global.
14947
dea57a62
TT		 149482019-02-15 Tom Tromey <tromey@adacore.com>
14949
14950 * target.h (push_target): Declare new overload.
14951 * target.c (push_target): New overload, taking an rvalue reference.
14952 * remote.c (remote_target::open_1): Use push_target overload.
14953 * corelow.c (core_target_open): Use push_target overload.
14954
989f3c58
TT		 149552019-02-15 Tom Tromey <tromey@adacore.com>
14956
14957 * ravenscar-thread.c (is_ravenscar_task)
14958 (ravenscar_task_is_currently_active): Return bool.
14959 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14960 (_initialize_ravenscar): Remove "(void)".
14961 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14962 Return bool.
14963
6cbcc006
TT		 149642019-02-15 Tom Tromey <tromey@adacore.com>
14965
14966 * ravenscar-thread.c (ravenscar_runtime_initializer)
14967 (has_ravenscar_runtime, get_running_thread_id)
14968 (ravenscar_thread_target::resume): Fix indentation.
14969
7657f14d
TT		 149702019-02-15 Tom Tromey <tromey@adacore.com>
14971
14972 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14973 from ravenscar_arch_ops.
14974 (sparc_ravenscar_ops::fetch_registers)
14975 (sparc_ravenscar_ops::store_registers): Now methods.
14976 (sparc_ravenscar_prepare_to_store): Remove.
14977 (sparc_ravenscar_ops): Redefine.
14978 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14979 methods and destructor. Remove members.
14980 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14981 (ravenscar_thread_target::store_registers)
14982 (ravenscar_thread_target::prepare_to_store): Update.
14983 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14984 Remove.
14985 (struct ppc_ravenscar_powerpc_ops): Derive from
14986 ravenscar_arch_ops.
14987 (ppc_ravenscar_powerpc_ops::fetch_registers)
14988 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14989 (ppc_ravenscar_powerpc_ops): Redefine.
14990 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14991 (ppc_ravenscar_e500_ops::fetch_registers)
14992 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14993 (ppc_ravenscar_e500_ops): Redefine.
14994 * aarch64-ravenscar-thread.c
14995 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14996 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14997 (aarch64_ravenscar_fetch_registers)
14998 (aarch64_ravenscar_store_registers): Now methods.
14999 (aarch64_ravenscar_ops): Redefine.
15000
5b6ea500
TT		 150012019-02-15 Tom Tromey <tromey@adacore.com>
15002
15003 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15004 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15005 (ravenscar_thread_target::stopped_by_watchpoint)
15006 (ravenscar_thread_target::stopped_data_address)
15007 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15008
e397fd39
TT		 150092019-02-15 Tom Tromey <tromey@adacore.com>
15010
15011 * ravenscar-thread.c: Fix some typos.
15012
cc12f4a8
TT		 150132019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15014 Tom Tromey <tromey@adacore.com>
15015
15016 * ada-lang.c (ada_exception_sal): Change addr_string to a
15017 std::string.
15018 (create_ada_exception_catchpoint): Update.
15019
5f486660
TT		 150202019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15021 Tom Tromey <tromey@adacore.com>
15022
15023 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15024 (bp_location_ops): Remove.
15025 (base_breakpoint_allocate_location): Update.
15026 (free_bp_location): Update.
15027 * ada-lang.c (class ada_catchpoint_location)
15028 <ada_catchpoint_location>: Remove ops parameter.
15029 (ada_catchpoint_location_dtor): Remove.
15030 (ada_catchpoint_location_ops): Remove.
15031 (allocate_location_exception): Update.
15032 * breakpoint.h (struct bp_location_ops): Remove.
15033 (class bp_location) <bp_location>: Remove bp_location_ops
15034 parameter.
15035 <~bp_location>: Add destructor.
15036 <ops>: Remove.
15037
b671c7fb
TS		 150382019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15039 Pedro Alves <palves@redhat.com>
15040
15041 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15042 'PATH_MAX'.
15043
8071c5ce
DM		 150442019-02-14 David Michael <fedora.dm0@gmail.com>
15045 Samuel Thibault <samuel.thibault@gnu.org>
15046 Thomas Schwinge <thomas@codesourcery.com>
15047
15048 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15049 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15050
b1041ae0
TS		 150512019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15052
924514e1
TS		 15053 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15054 (check_empty): Use "const char *".
15055
c29ee8d4
TS		 15056 * gnu-nat.c (gnu_nat_target::detach): Instead of
15057 'detach_inferior (pid)' call
15058 'detach_inferior (find_inferior_pid (pid))'.
15059
6c6ef69f
TS		 15060 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15061 'nat/fork-inferior.o'.
15062 * gnu-nat.c: #include "nat/fork-inferior.h".
15063
2d0a338c
TS		 15064 * gnu-nat.c (gnu_nat_target::detach): Instead of
15065 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15066 * gnu-nat.h: #include "inf-child.h".
15067 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15068 'i386_gnu_nat_target::fetch_registers'.
15069 (gnu_store_registers): Rename/move to
15070 'i386_gnu_nat_target::store_registers'.
15071
cabb5f06
TS		 15072 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15073 * gnu-nat.h (mach_thread_info): New function.
15074 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15075
b1041ae0
TS		 15076 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15077
2988d01e
KF		 150782019-02-14 Frederic Konrad <konrad@adacore.com>
15079
15080 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15081
c559d709
JB		 150822019-02-14 Joel Brobecker <brobecker@adacore.com>
15083
15084 * windows-nat.c (windows_add_thread): Add new parameter
15085 "main_thread_p" with default value set to false. Update
15086 function documentation as well as all callers.
15087 (windows_delete_thread): Likewise.
15088 (fake_create_process): Update call to windows_add_thread.
15089 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15090 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15091 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15092 call to windows_delete_thread.
15093
007024cc
SM		 150942019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15095
15096 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15097
f62318e9
JB		 150982019-02-12 John Baldwin <jhb@FreeBSD.org>
15099
15100 * symfile.c (find_separate_debug_file): Use canonical path of
15101 sysroot with child_path instead of gdb_sysroot if it is valid.
15102
cd4b7848
JB		 151032019-02-12 John Baldwin <jhb@FreeBSD.org>
15104
15105 * symfile.c (find_separate_debug_file): Use child_path to
15106 determine if an object file is under a sysroot.
15107
efac4bfe
JB		 151082019-02-12 John Baldwin <jhb@FreeBSD.org>
15109
15110 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15111 unittests/child-path-selftests.c.
15112 * common/pathstuff.c (child_path): New function.
15113 * common/pathstuff.h (child_path): New prototype.
15114 * unittests/child-path-selftests.c: New file.
15115
402d2bfe
JB		 151162019-02-12 John Baldwin <jhb@FreeBSD.org>
15117
15118 * symfile.c (find_separate_debug_file): Look for separate debug
15119 files in debug directories under the sysroot.
15120
1ed9f74e
PW		 151212019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15122
15123 * symtab.h (struct minimal_symbol data_p): New const method.
15124 (struct minimal_symbol text_p): Likewise.
15125 * symtab.c (output_source_filename): Use file name style
15126 to print file name.
15127 (print_symbol_info): Likewise.
15128 (print_msymbol_info): Use address style to print addresses.
15129 Use function name style to print executable text symbols.
15130 (expand_symtab_containing_pc): Use data_p.
15131 (find_pc_sect_compunit_symtab): Likewise.
15132
2636d81d
PW		 151332019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15134
15135 * breakpoint.c (describe_other_breakpoints): Use address style
15136 to print addresses.
15137 (say_where): Likewise.
15138
ac8c53cc
PW		 151392019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15140
15141 * ada-typeprint.c (print_func_type): Print function name
15142 style to print function name.
15143 * c-typeprint.c (c_print_type_1): Likewise.
15144
ea638c43
AH		 151452019-02-11 Alan Hayward <alan.hayward@arm.com>
15146
15147 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15148 for execve.
15149
ab759ca8
PW		 151502019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15151
15152 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15153 type_stack.
15154
aff29d1c
JB		 151552019-02-10 Joel Brobecker <brobecker@adacore.com>
15156
15157 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15158 TYPE_CODE_REF types.
15159
617126bc
JW		 151602019-02-08 Jim Wilson <jimw@sifive.com>
15161
15162 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15163 (riscv_linux_fregset): New.
15164 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15165
46e3ed7f
TT		 151662019-02-07 Tom Tromey <tom@tromey.com>
15167
15168 * thread.c (thread_cancel_execution_command): Update.
15169 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15170 methods.
15171 (struct thread_fsm_ops): Remove.
15172 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15173 (thread_fsm_should_stop, thread_fsm_return_value)
15174 (thread_fsm_set_finished, thread_fsm_finished_p)
15175 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15176 Don't declare.
15177 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15178 * infrun.c (clear_proceed_status_thread)
15179 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15180 (print_stop_event): Update.
15181 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15182 Add constructor.
15183 (step_command_fsm_ops): Remove.
15184 (new_step_command_fsm): Remove.
15185 (step_1): Update.
15186 (step_command_fsm::should_stop): Rename from
15187 step_command_fsm_should_stop.
15188 (step_command_fsm::clean_up): Rename from
15189 step_command_fsm_clean_up.
15190 (step_command_fsm::do_async_reply_reason): Rename from
15191 step_command_fsm_async_reply_reason.
15192 (struct until_next_fsm): Inherit from thread_fsm. Add
15193 constructor.
15194 (until_next_fsm_ops): Remove.
15195 (new_until_next_fsm): Remove.
15196 (until_next_fsm::should_stop): Rename from
15197 until_next_fsm_should_stop.
15198 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15199 (until_next_fsm::do_async_reply_reason): Rename from
15200 until_next_fsm_async_reply_reason.
15201 (struct finish_command_fsm): Inherit from thread_fsm. Add
15202 constructor. Change type of breakpoint.
15203 (finish_command_fsm_ops): Remove.
15204 (new_finish_command_fsm): Remove.
15205 (finish_command_fsm::should_stop): Rename from
15206 finish_command_fsm_should_stop.
15207 (finish_command_fsm::clean_up): Rename from
15208 finish_command_fsm_clean_up.
15209 (finish_command_fsm::return_value): Rename from
15210 finish_command_fsm_return_value.
15211 (finish_command_fsm::do_async_reply_reason): Rename from
15212 finish_command_fsm_async_reply_reason.
15213 (finish_command): Update.
15214 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15215 Add constructor.
15216 (call_thread_fsm_ops): Remove.
15217 (call_thread_fsm::call_thread_fsm): Rename from
15218 new_call_thread_fsm.
15219 (call_thread_fsm::should_stop): Rename from
15220 call_thread_fsm_should_stop.
15221 (call_thread_fsm::should_notify_stop): Rename from
15222 call_thread_fsm_should_notify_stop.
15223 (run_inferior_call, call_function_by_hand_dummy): Update.
15224 * cli/cli-interp.c (should_print_stop_to_console): Update.
15225 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15226 Add constructor. Change type of location_breakpoint,
15227 caller_breakpoint.
15228 (until_break_fsm_ops): Remove.
15229 (new_until_break_fsm): Remove.
15230 (until_break_fsm::should_stop): Rename from
15231 until_break_fsm_should_stop.
15232 (until_break_fsm::clean_up): Rename from
15233 until_break_fsm_clean_up.
15234 (until_break_fsm::do_async_reply_reason): Rename from
15235 until_break_fsm_async_reply_reason.
15236 (until_break_command): Update.
15237 * thread-fsm.c: Remove.
15238 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15239
1a5c2598
TT		 152402019-02-07 Tom Tromey <tom@tromey.com>
15241
15242 * yy-remap.h: Add include guard.
15243 * xtensa-tdep.h: Add include guard.
15244 * xcoffread.h: Rename include guard.
15245 * varobj-iter.h: Add include guard.
15246 * tui/tui.h: Rename include guard.
15247 * tui/tui-winsource.h: Rename include guard.
15248 * tui/tui-wingeneral.h: Rename include guard.
15249 * tui/tui-windata.h: Rename include guard.
15250 * tui/tui-win.h: Rename include guard.
15251 * tui/tui-stack.h: Rename include guard.
15252 * tui/tui-source.h: Rename include guard.
15253 * tui/tui-regs.h: Rename include guard.
15254 * tui/tui-out.h: Rename include guard.
15255 * tui/tui-layout.h: Rename include guard.
15256 * tui/tui-io.h: Rename include guard.
15257 * tui/tui-hooks.h: Rename include guard.
15258 * tui/tui-file.h: Rename include guard.
15259 * tui/tui-disasm.h: Rename include guard.
15260 * tui/tui-data.h: Rename include guard.
15261 * tui/tui-command.h: Rename include guard.
15262 * tic6x-tdep.h: Add include guard.
15263 * target/waitstatus.h: Rename include guard.
15264 * target/wait.h: Rename include guard.
15265 * target/target.h: Rename include guard.
15266 * target/resume.h: Rename include guard.
15267 * target-float.h: Rename include guard.
15268 * stabsread.h: Add include guard.
15269 * rs6000-tdep.h: Add include guard.
15270 * riscv-fbsd-tdep.h: Add include guard.
15271 * regformats/regdef.h: Rename include guard.
15272 * record.h: Rename include guard.
15273 * python/python.h: Rename include guard.
15274 * python/python-internal.h: Rename include guard.
15275 * python/py-stopevent.h: Rename include guard.
15276 * python/py-ref.h: Rename include guard.
15277 * python/py-record.h: Rename include guard.
15278 * python/py-record-full.h: Rename include guard.
15279 * python/py-record-btrace.h: Rename include guard.
15280 * python/py-instruction.h: Rename include guard.
15281 * python/py-events.h: Rename include guard.
15282 * python/py-event.h: Rename include guard.
15283 * procfs.h: Add include guard.
15284 * proc-utils.h: Add include guard.
15285 * p-lang.h: Add include guard.
15286 * or1k-tdep.h: Rename include guard.
15287 * observable.h: Rename include guard.
15288 * nto-tdep.h: Rename include guard.
15289 * nat/x86-linux.h: Rename include guard.
15290 * nat/x86-linux-dregs.h: Rename include guard.
15291 * nat/x86-gcc-cpuid.h: Add include guard.
15292 * nat/x86-dregs.h: Rename include guard.
15293 * nat/x86-cpuid.h: Rename include guard.
15294 * nat/ppc-linux.h: Rename include guard.
15295 * nat/mips-linux-watch.h: Rename include guard.
15296 * nat/linux-waitpid.h: Rename include guard.
15297 * nat/linux-ptrace.h: Rename include guard.
15298 * nat/linux-procfs.h: Rename include guard.
15299 * nat/linux-osdata.h: Rename include guard.
15300 * nat/linux-nat.h: Rename include guard.
15301 * nat/linux-namespaces.h: Rename include guard.
15302 * nat/linux-btrace.h: Rename include guard.
15303 * nat/glibc_thread_db.h: Rename include guard.
15304 * nat/gdb_thread_db.h: Rename include guard.
15305 * nat/gdb_ptrace.h: Rename include guard.
15306 * nat/fork-inferior.h: Rename include guard.
15307 * nat/amd64-linux-siginfo.h: Rename include guard.
15308 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15309 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15310 * nat/aarch64-linux.h: Rename include guard.
15311 * nat/aarch64-linux-hw-point.h: Rename include guard.
15312 * mn10300-tdep.h: Add include guard.
15313 * mips-linux-tdep.h: Add include guard.
15314 * mi/mi-parse.h: Rename include guard.
15315 * mi/mi-out.h: Rename include guard.
15316 * mi/mi-main.h: Rename include guard.
15317 * mi/mi-interp.h: Rename include guard.
15318 * mi/mi-getopt.h: Rename include guard.
15319 * mi/mi-console.h: Rename include guard.
15320 * mi/mi-common.h: Rename include guard.
15321 * mi/mi-cmds.h: Rename include guard.
15322 * mi/mi-cmd-break.h: Rename include guard.
15323 * m2-lang.h: Add include guard.
15324 * location.h: Rename include guard.
15325 * linux-record.h: Rename include guard.
15326 * linux-nat.h: Add include guard.
15327 * linux-fork.h: Add include guard.
15328 * i386-darwin-tdep.h: Rename include guard.
15329 * hppa-linux-offsets.h: Add include guard.
15330 * guile/guile.h: Rename include guard.
15331 * guile/guile-internal.h: Rename include guard.
15332 * gnu-nat.h: Rename include guard.
15333 * gdb-stabs.h: Rename include guard.
15334 * frv-tdep.h: Add include guard.
15335 * f-lang.h: Add include guard.
15336 * event-loop.h: Add include guard.
15337 * darwin-nat.h: Rename include guard.
15338 * cp-abi.h: Rename include guard.
15339 * config/sparc/nm-sol2.h: Rename include guard.
15340 * config/nm-nto.h: Rename include guard.
15341 * config/nm-linux.h: Add include guard.
15342 * config/i386/nm-i386gnu.h: Rename include guard.
15343 * config/djgpp/nl_types.h: Rename include guard.
15344 * config/djgpp/langinfo.h: Rename include guard.
15345 * compile/gcc-cp-plugin.h: Add include guard.
15346 * compile/gcc-c-plugin.h: Add include guard.
15347 * compile/compile.h: Rename include guard.
15348 * compile/compile-object-run.h: Rename include guard.
15349 * compile/compile-object-load.h: Rename include guard.
15350 * compile/compile-internal.h: Rename include guard.
15351 * compile/compile-cplus.h: Rename include guard.
15352 * compile/compile-c.h: Rename include guard.
15353 * common/xml-utils.h: Rename include guard.
15354 * common/x86-xstate.h: Rename include guard.
15355 * common/version.h: Rename include guard.
15356 * common/vec.h: Rename include guard.
15357 * common/tdesc.h: Rename include guard.
15358 * common/selftest.h: Rename include guard.
15359 * common/scoped_restore.h: Rename include guard.
15360 * common/scoped_mmap.h: Rename include guard.
15361 * common/scoped_fd.h: Rename include guard.
15362 * common/safe-iterator.h: Rename include guard.
15363 * common/run-time-clock.h: Rename include guard.
15364 * common/refcounted-object.h: Rename include guard.
15365 * common/queue.h: Rename include guard.
15366 * common/ptid.h: Rename include guard.
15367 * common/print-utils.h: Rename include guard.
15368 * common/preprocessor.h: Rename include guard.
15369 * common/pathstuff.h: Rename include guard.
15370 * common/observable.h: Rename include guard.
15371 * common/netstuff.h: Rename include guard.
15372 * common/job-control.h: Rename include guard.
15373 * common/host-defs.h: Rename include guard.
15374 * common/gdb_wait.h: Rename include guard.
15375 * common/gdb_vecs.h: Rename include guard.
15376 * common/gdb_unlinker.h: Rename include guard.
15377 * common/gdb_unique_ptr.h: Rename include guard.
15378 * common/gdb_tilde_expand.h: Rename include guard.
15379 * common/gdb_sys_time.h: Rename include guard.
15380 * common/gdb_string_view.h: Rename include guard.
15381 * common/gdb_splay_tree.h: Rename include guard.
15382 * common/gdb_setjmp.h: Rename include guard.
15383 * common/gdb_ref_ptr.h: Rename include guard.
15384 * common/gdb_optional.h: Rename include guard.
15385 * common/gdb_locale.h: Rename include guard.
15386 * common/gdb_assert.h: Rename include guard.
15387 * common/filtered-iterator.h: Rename include guard.
15388 * common/filestuff.h: Rename include guard.
15389 * common/fileio.h: Rename include guard.
15390 * common/environ.h: Rename include guard.
15391 * common/common-utils.h: Rename include guard.
15392 * common/common-types.h: Rename include guard.
15393 * common/common-regcache.h: Rename include guard.
15394 * common/common-inferior.h: Rename include guard.
15395 * common/common-gdbthread.h: Rename include guard.
15396 * common/common-exceptions.h: Rename include guard.
15397 * common/common-defs.h: Rename include guard.
15398 * common/common-debug.h: Rename include guard.
15399 * common/cleanups.h: Rename include guard.
15400 * common/buffer.h: Rename include guard.
15401 * common/btrace-common.h: Rename include guard.
15402 * common/break-common.h: Rename include guard.
15403 * cli/cli-utils.h: Rename include guard.
15404 * cli/cli-style.h: Rename include guard.
15405 * cli/cli-setshow.h: Rename include guard.
15406 * cli/cli-script.h: Rename include guard.
15407 * cli/cli-interp.h: Rename include guard.
15408 * cli/cli-decode.h: Rename include guard.
15409 * cli/cli-cmds.h: Rename include guard.
15410 * charset-list.h: Add include guard.
15411 * buildsym-legacy.h: Rename include guard.
15412 * bfin-tdep.h: Add include guard.
15413 * ax.h: Rename include guard.
15414 * arm-linux-tdep.h: Add include guard.
15415 * arm-fbsd-tdep.h: Add include guard.
15416 * arch/xtensa.h: Rename include guard.
15417 * arch/tic6x.h: Add include guard.
15418 * arch/i386.h: Add include guard.
15419 * arch/arm.h: Rename include guard.
15420 * arch/arm-linux.h: Rename include guard.
15421 * arch/arm-get-next-pcs.h: Rename include guard.
15422 * arch/amd64.h: Add include guard.
15423 * arch/aarch64-insn.h: Rename include guard.
15424 * arch-utils.h: Rename include guard.
15425 * annotate.h: Add include guard.
15426 * amd64-darwin-tdep.h: Rename include guard.
15427 * aarch64-linux-tdep.h: Add include guard.
15428 * aarch64-fbsd-tdep.h: Add include guard.
15429 * aarch32-linux-nat.h: Add include guard.
15430
ab9268d2
PW		 154312019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15432
15433 * macrotab.c (macro_define_internal): New function that
15434 factorizes macro_define_object_internal and macro_define_function
15435 code.
15436 (macro_define_object_internal): Use macro_define_internal.
15437 (macro_define_function): Likewise.
15438
bb0da2b4
PW		 154392019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15440
15441 * macrocmd.c (extract_identifier): Return
15442 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15443 callers.
15444
424eb552
JB		 154452019-02-06 John Baldwin <jhb@FreeBSD.org>
15446
15447 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15448
1688cb29
TT		 154492019-02-05 Tom Tromey <tom@tromey.com>
15450
15451 * target.c (target_stack::unpush): Move assertion earlier.
15452
b5eba2d8
TT		 154532019-01-30 Tom Tromey <tom@tromey.com>
15454
15455 PR python/23615:
15456 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15457 (gdbpy_parse_and_eval): Likewise.
15458 * python/python-internal.h (gdbpy_allow_threads): New class.
15459
7054e2ff
JB		 154602019-01-28 John Baldwin <jhb@FreeBSD.org>
15461
15462 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15463 (aarch64_fbsd_fpregmap): Move earlier.
15464 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15465 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15466 instead of individual calls to trad_frame_set_reg_addr.
15467 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15468 earlier.
15469 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15470 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15471 instead of individual calls to trad_frame_set_reg_addr.
15472
36c25ffa
AH		 154732019-01-28 Alan Hayward <alan.hayward@arm.com>
15474
15475 * CONTRIBUTE: Replace contribution list with wiki link.
15476
a0707f3c
TT		 154772019-01-25 Tom Tromey <tom@tromey.com>
15478
15479 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15480
0747795c
TT		 154812019-01-25 Tom Tromey <tom@tromey.com>
15482
15483 * xtensa-linux-nat.c: Fix common/ includes.
15484 * xml-support.h: Fix common/ includes.
15485 * xml-support.c: Fix common/ includes.
15486 * x86-linux-nat.c: Fix common/ includes.
15487 * windows-nat.c: Fix common/ includes.
15488 * varobj.h: Fix common/ includes.
15489 * varobj.c: Fix common/ includes.
15490 * value.c: Fix common/ includes.
15491 * valops.c: Fix common/ includes.
15492 * utils.c: Fix common/ includes.
15493 * unittests/xml-utils-selftests.c: Fix common/ includes.
15494 * unittests/utils-selftests.c: Fix common/ includes.
15495 * unittests/unpack-selftests.c: Fix common/ includes.
15496 * unittests/tracepoint-selftests.c: Fix common/ includes.
15497 * unittests/style-selftests.c: Fix common/ includes.
15498 * unittests/string_view-selftests.c: Fix common/ includes.
15499 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15500 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15501 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15502 * unittests/rsp-low-selftests.c: Fix common/ includes.
15503 * unittests/parse-connection-spec-selftests.c: Fix common/
15504 includes.
15505 * unittests/optional-selftests.c: Fix common/ includes.
15506 * unittests/offset-type-selftests.c: Fix common/ includes.
15507 * unittests/observable-selftests.c: Fix common/ includes.
15508 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15509 * unittests/memrange-selftests.c: Fix common/ includes.
15510 * unittests/memory-map-selftests.c: Fix common/ includes.
15511 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15512 * unittests/function-view-selftests.c: Fix common/ includes.
15513 * unittests/environ-selftests.c: Fix common/ includes.
15514 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15515 * unittests/common-utils-selftests.c: Fix common/ includes.
15516 * unittests/cli-utils-selftests.c: Fix common/ includes.
15517 * unittests/array-view-selftests.c: Fix common/ includes.
15518 * ui-file.c: Fix common/ includes.
15519 * tui/tui-io.c: Fix common/ includes.
15520 * tracepoint.h: Fix common/ includes.
15521 * tracepoint.c: Fix common/ includes.
15522 * tracefile-tfile.c: Fix common/ includes.
15523 * top.h: Fix common/ includes.
15524 * top.c: Fix common/ includes.
15525 * thread.c: Fix common/ includes.
15526 * target/waitstatus.h: Fix common/ includes.
15527 * target/waitstatus.c: Fix common/ includes.
15528 * target.h: Fix common/ includes.
15529 * target.c: Fix common/ includes.
15530 * target-memory.c: Fix common/ includes.
15531 * target-descriptions.c: Fix common/ includes.
15532 * symtab.h: Fix common/ includes.
15533 * symfile.c: Fix common/ includes.
15534 * stap-probe.c: Fix common/ includes.
15535 * spu-linux-nat.c: Fix common/ includes.
15536 * sparc-nat.c: Fix common/ includes.
15537 * source.c: Fix common/ includes.
15538 * solib.c: Fix common/ includes.
15539 * solib-target.c: Fix common/ includes.
15540 * ser-unix.c: Fix common/ includes.
15541 * ser-tcp.c: Fix common/ includes.
15542 * ser-pipe.c: Fix common/ includes.
15543 * ser-base.c: Fix common/ includes.
15544 * selftest-arch.c: Fix common/ includes.
15545 * s12z-tdep.c: Fix common/ includes.
15546 * rust-exp.y: Fix common/ includes.
15547 * rs6000-aix-tdep.c: Fix common/ includes.
15548 * riscv-tdep.c: Fix common/ includes.
15549 * remote.c: Fix common/ includes.
15550 * remote-notif.h: Fix common/ includes.
15551 * remote-fileio.h: Fix common/ includes.
15552 * remote-fileio.c: Fix common/ includes.
15553 * regcache.h: Fix common/ includes.
15554 * regcache.c: Fix common/ includes.
15555 * record-btrace.c: Fix common/ includes.
15556 * python/python.c: Fix common/ includes.
15557 * python/py-type.c: Fix common/ includes.
15558 * python/py-inferior.c: Fix common/ includes.
15559 * progspace.h: Fix common/ includes.
15560 * producer.c: Fix common/ includes.
15561 * procfs.c: Fix common/ includes.
15562 * proc-api.c: Fix common/ includes.
15563 * printcmd.c: Fix common/ includes.
15564 * ppc-linux-nat.c: Fix common/ includes.
15565 * parser-defs.h: Fix common/ includes.
15566 * osdata.c: Fix common/ includes.
15567 * obsd-nat.c: Fix common/ includes.
15568 * nat/x86-linux.c: Fix common/ includes.
15569 * nat/x86-linux-dregs.c: Fix common/ includes.
15570 * nat/x86-dregs.h: Fix common/ includes.
15571 * nat/x86-dregs.c: Fix common/ includes.
15572 * nat/ppc-linux.c: Fix common/ includes.
15573 * nat/mips-linux-watch.h: Fix common/ includes.
15574 * nat/mips-linux-watch.c: Fix common/ includes.
15575 * nat/linux-waitpid.c: Fix common/ includes.
15576 * nat/linux-ptrace.h: Fix common/ includes.
15577 * nat/linux-ptrace.c: Fix common/ includes.
15578 * nat/linux-procfs.c: Fix common/ includes.
15579 * nat/linux-personality.c: Fix common/ includes.
15580 * nat/linux-osdata.c: Fix common/ includes.
15581 * nat/linux-namespaces.c: Fix common/ includes.
15582 * nat/linux-btrace.h: Fix common/ includes.
15583 * nat/linux-btrace.c: Fix common/ includes.
15584 * nat/fork-inferior.c: Fix common/ includes.
15585 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15586 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15587 * nat/aarch64-linux.c: Fix common/ includes.
15588 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15589 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15590 * namespace.h: Fix common/ includes.
15591 * mips-linux-tdep.c: Fix common/ includes.
15592 * minsyms.c: Fix common/ includes.
15593 * mi/mi-parse.h: Fix common/ includes.
15594 * mi/mi-main.c: Fix common/ includes.
15595 * mi/mi-cmd-env.c: Fix common/ includes.
15596 * memrange.h: Fix common/ includes.
15597 * memattr.c: Fix common/ includes.
15598 * maint.h: Fix common/ includes.
15599 * maint.c: Fix common/ includes.
15600 * main.c: Fix common/ includes.
15601 * machoread.c: Fix common/ includes.
15602 * location.c: Fix common/ includes.
15603 * linux-thread-db.c: Fix common/ includes.
15604 * linux-nat.c: Fix common/ includes.
15605 * linux-fork.c: Fix common/ includes.
15606 * inline-frame.c: Fix common/ includes.
15607 * infrun.c: Fix common/ includes.
15608 * inflow.c: Fix common/ includes.
15609 * inferior.h: Fix common/ includes.
15610 * inferior.c: Fix common/ includes.
15611 * infcmd.c: Fix common/ includes.
15612 * inf-ptrace.c: Fix common/ includes.
15613 * inf-child.c: Fix common/ includes.
15614 * ia64-linux-nat.c: Fix common/ includes.
15615 * i387-tdep.c: Fix common/ includes.
15616 * i386-tdep.c: Fix common/ includes.
15617 * i386-linux-tdep.c: Fix common/ includes.
15618 * i386-linux-nat.c: Fix common/ includes.
15619 * i386-go32-tdep.c: Fix common/ includes.
15620 * i386-fbsd-tdep.c: Fix common/ includes.
15621 * i386-fbsd-nat.c: Fix common/ includes.
15622 * guile/scm-type.c: Fix common/ includes.
15623 * guile/guile.c: Fix common/ includes.
15624 * go32-nat.c: Fix common/ includes.
15625 * gnu-nat.c: Fix common/ includes.
15626 * gdbthread.h: Fix common/ includes.
15627 * gdbarch-selftests.c: Fix common/ includes.
15628 * gdb_usleep.c: Fix common/ includes.
15629 * gdb_select.h: Fix common/ includes.
15630 * gdb_bfd.c: Fix common/ includes.
15631 * gcore.c: Fix common/ includes.
15632 * fork-child.c: Fix common/ includes.
15633 * findvar.c: Fix common/ includes.
15634 * fbsd-nat.c: Fix common/ includes.
15635 * event-top.c: Fix common/ includes.
15636 * event-loop.c: Fix common/ includes.
15637 * dwarf2read.c: Fix common/ includes.
15638 * dwarf2loc.c: Fix common/ includes.
15639 * dwarf2-frame.c: Fix common/ includes.
15640 * dwarf-index-cache.c: Fix common/ includes.
15641 * dtrace-probe.c: Fix common/ includes.
15642 * disasm-selftests.c: Fix common/ includes.
15643 * defs.h: Fix common/ includes.
15644 * csky-tdep.c: Fix common/ includes.
15645 * cp-valprint.c: Fix common/ includes.
15646 * cp-support.h: Fix common/ includes.
15647 * cp-support.c: Fix common/ includes.
15648 * corelow.c: Fix common/ includes.
15649 * completer.h: Fix common/ includes.
15650 * completer.c: Fix common/ includes.
15651 * compile/compile.c: Fix common/ includes.
15652 * compile/compile-loc2c.c: Fix common/ includes.
15653 * compile/compile-cplus-types.c: Fix common/ includes.
15654 * compile/compile-cplus-symbols.c: Fix common/ includes.
15655 * command.h: Fix common/ includes.
15656 * cli/cli-dump.c: Fix common/ includes.
15657 * cli/cli-cmds.c: Fix common/ includes.
15658 * charset.c: Fix common/ includes.
15659 * build-id.c: Fix common/ includes.
15660 * btrace.h: Fix common/ includes.
15661 * btrace.c: Fix common/ includes.
15662 * breakpoint.h: Fix common/ includes.
15663 * breakpoint.c: Fix common/ includes.
15664 * ax.h:
15665 (enum agent_op): Fix common/ includes.
15666 * ax-general.c (struct aop_map): Fix common/ includes.
15667 * ax-gdb.c: Fix common/ includes.
15668 * auxv.c: Fix common/ includes.
15669 * auto-load.c: Fix common/ includes.
15670 * arm-tdep.c: Fix common/ includes.
15671 * arch/riscv.c: Fix common/ includes.
15672 * arch/ppc-linux-common.c: Fix common/ includes.
15673 * arch/i386.c: Fix common/ includes.
15674 * arch/arm.c: Fix common/ includes.
15675 * arch/arm-linux.c: Fix common/ includes.
15676 * arch/arm-get-next-pcs.c: Fix common/ includes.
15677 * arch/amd64.c: Fix common/ includes.
15678 * arch/aarch64.c: Fix common/ includes.
15679 * arch/aarch64-insn.c: Fix common/ includes.
15680 * arch-utils.c: Fix common/ includes.
15681 * amd64-windows-tdep.c: Fix common/ includes.
15682 * amd64-tdep.c: Fix common/ includes.
15683 * amd64-sol2-tdep.c: Fix common/ includes.
15684 * amd64-obsd-tdep.c: Fix common/ includes.
15685 * amd64-nbsd-tdep.c: Fix common/ includes.
15686 * amd64-linux-tdep.c: Fix common/ includes.
15687 * amd64-linux-nat.c: Fix common/ includes.
15688 * amd64-fbsd-tdep.c: Fix common/ includes.
15689 * amd64-fbsd-nat.c: Fix common/ includes.
15690 * amd64-dicos-tdep.c: Fix common/ includes.
15691 * amd64-darwin-tdep.c: Fix common/ includes.
15692 * agent.c: Fix common/ includes.
15693 * ada-lang.h: Fix common/ includes.
15694 * ada-lang.c: Fix common/ includes.
15695 * aarch64-tdep.c: Fix common/ includes.
15696
2f5c153e
TT		 156972019-01-25 Tom Tromey <tom@tromey.com>
15698
15699 * common/create-version.sh: Use common/version.h.
15700
adc6a863
PA		 157012019-01-24 Pedro Alves <palves@redhat.com>
15702
15703 * infrun.c (signal_stop, signal_print, signal_program)
15704 (signal_catch, signal_pass): Now arrays instead of pointers.
15705 (update_signals_program_target, do_target_resume)
15706 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15707 * linux-nat.c (linux_nat_target::pass_signals)
15708 (linux_nat_target::create_inferior, linux_nat_target::attach):
15709 Adjust.
15710 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15711 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15712 * procfs.c (procfs_target::pass_signals): Adjust.
15713 * record-full.c (record_full_target::resume): Adjust.
15714 * remote.c (remote_target::pass_signals)
15715 (remote_target::program_signals): Adjust.
15716 * target-debug.h (target_debug_print_signals): Now takes a
15717 gdb::array_view as parameter. Adjust.
15718 * target.h (target_ops) <pass_signals, program_signals>: Replace
15719 pointer and length parameters with gdb::array_view.
15720 (target_pass_signals, target_program_signals): Likewise.
15721 * target-delegates.c: Regenerate.
15722
3046d67a
PA		 157232019-01-24 Pedro Alves <palves@redhat.com>
15724
15725 * common/forward-scope-exit.h
15726 (forward_scope_exit::forward_scope_exit): Pass arguments to
15727 m_bind_function directly, instead of creating a std::bind and
15728 copying that.
15729
353229bf
AH		 157302019-01-24 Alan Hayward <alan.hayward@arm.com>
15731
15732 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15733 for static members.
15734 (pass_in_v_vfp_candidate): Likewise.
15735
311dc83a
TT		 157362019-01-23 Tom Tromey <tom@tromey.com>
15737 Pedro Alves <palves@redhat.com>
15738
15739 * regcache.c (class regcache_invalidator): Remove.
15740 (regcache::raw_write): Use make_scope_exit.
15741
296bd123
TT		 157422019-01-23 Tom Tromey <tom@tromey.com>
15743
15744 * ui-out.h (class ui_out_emit_type): Update comment.
15745
979a0d13
TT		 157462019-01-23 Tom Tromey <tom@tromey.com>
15747
15748 * infrun.c (fetch_inferior_event): Update comment.
15749
d238133d
TT		 157502019-01-23 Tom Tromey <tom@tromey.com>
15751 Pedro Alves <palves@redhat.com>
15752
15753 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15754 parameter.
15755 (fetch_inferior_event): Use SCOPE_EXIT.
15756
15757
9885e6bb
TT		 157582019-01-23 Tom Tromey <tom@tromey.com>
15759 Pedro Alves <palves@redhat.com>
15760
15761 * infrun.c (disable_thread_events): Delete.
15762 (stop_all_threads): Use SCOPE_EXIT.
15763
286526c1
TT		 157642019-01-23 Tom Tromey <tom@tromey.com>
15765 Pedro Alves <palves@redhat.com>
15766
15767 * symfile.c: Include forward-scope-exit.h.
15768 (clear_symtab_users_cleanup): Replace forward declaration with
15769 a FORWARD_SCOPE_EXIT.
15770 (syms_from_objfile_1): Use the forward_scope_exit and
15771 gdb::optional instead of cleanup_function.
15772 (reread_symbols): Use the forward_scope_exit instead of
15773 cleanup_function.
15774 (clear_symtab_users_cleanup): Remove function.
15775
1db93f14
TT		 157762019-01-23 Tom Tromey <tom@tromey.com>
15777 Pedro Alves <palves@redhat.com>
15778
15779 * linux-nat.c: Include scope-exit.h.
15780 (cleanup_target_stop): Remove.
15781 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15782 SCOPE_EXIT.
15783
2cc83d1e
TT		 157842019-01-23 Tom Tromey <tom@tromey.com>
15785 Pedro Alves <palves@redhat.com>
15786
15787 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15788 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15789
694c6bf5
TT		 157902019-01-23 Tom Tromey <tom@tromey.com>
15791 Andrew Burgess <andrew.burgess@embecosm.com>
15792 Pedro Alves <palves@redhat.com>
15793
15794 * infrun.c (fetch_inferior_event): Use scope_exit.
15795 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15796 * top.c (execute_command): Use scope_exit.
15797 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15798 * utils.c (do_bpstat_clear_actions_cleanup)
15799 (make_bpstat_clear_actions_cleanup): Remove.
15800
4c41382a
TT		 158012019-01-23 Tom Tromey <tom@tromey.com>
15802 Pedro Alves <palves@redhat.com>
15803
15804 * infrun.c: Include "common/scope-exit.h"
15805 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15806 (wait_for_inferior): Use SCOPE_EXIT.
15807 (fetch_inferior_event): Use scope_exit.
15808
89f8fb50
TT		 158092019-01-23 Tom Tromey <tom@tromey.com>
15810 Pedro Alves <palves@redhat.com>
15811
15812 * breakpoint.c (create_breakpoint): Remove cleanup.
15813
5419bdae
TT		 158142019-01-23 Tom Tromey <tom@tromey.com>
15815 Andrew Burgess <andrew.burgess@embecosm.com>
15816 Pedro Alves <palves@redhat.com>
15817
e587ef42
PA		 158182019-01-23 Pedro Alves <palves@redhat.com>
15819
15820 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15821
77f0e74c
PA		 158222019-01-23 Pedro Alves <palves@redhat.com>
15823 Andrew Burgess <andrew.burgess@embecosm.com>
15824
15825 * gdbthread.h: Include "common/forward-scope-exit.h".
15826 (scoped_finish_thread_state): Redefine custom class in terms of
15827 forward_scope_exit.
15828
5b9b3e53
PA		 158292019-01-23 Pedro Alves <palves@redhat.com>
15830 Andrew Burgess <andrew.burgess@embecosm.com>
15831
15832 * common/forward-scope-exit.h: New file.
15833
54b65c9b
PA		 158342019-01-23 Pedro Alves <palves@redhat.com>
15835 Andrew Burgess <andrew.burgess@embecosm.com>
15836 Tom Tromey <tom@tromey.com>
15837
15838 * common/scope-exit.h: New file.
15839
cf08fb29
PA		 158402019-01-23 Pedro Alves <palves@redhat.com>
15841
15842 * common/preprocessor.h (ESC): Rename to ...
15843 (ESC_PARENS): ... this.
15844 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15845 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15846
ae73e2e2
TT		 158472019-01-23 Tom Tromey <tom@tromey.com>
15848
15849 * language.h (class scoped_switch_to_sym_language_if_auto):
15850 Initialize m_lang in both cases.
15851
6594e122
AH		 158522019-01-23 Alan Hayward <alan.hayward@arm.com>
15853
15854 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15855 with XCNEW.
15856
a7c9855d
TT		 158572019-01-22 Tom Tromey <tom@tromey.com>
15858
15859 * corelow.c: Do not include sys/file.h.
15860
93cc1d53
TT		 158612019-01-22 Tom Tromey <tom@tromey.com>
15862
15863 * tui/tui-wingeneral.h: Include gdb_curses.h.
15864
38561778
TT		 158652019-01-22 Tom Tromey <tom@tromey.com>
15866
15867 * source-cache.h (class source_cache) <get_source_lines,
15868 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15869
37b3ab5b
TT		 158702019-01-22 Tom Tromey <tom@tromey.com>
15871
15872 * remote-fileio.h (struct remote_target): Declare.
15873
3fabc016
TT		 158742019-01-22 Tom Tromey <tom@tromey.com>
15875
15876 * python/py-arch.c: Do not include py-ref.h.
15877 * python/py-bpevent.c: Do not include py-ref.h.
15878 * python/py-cmd.c: Do not include py-ref.h.
15879 * python/py-continueevent.c: Do not include py-ref.h.
15880 * python/py-event.h: Do not include py-ref.h.
15881 * python/py-evtregistry.c: Do not include py-ref.h.
15882 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15883 * python/py-frame.c: Do not include py-ref.h.
15884 * python/py-framefilter.c: Do not include py-ref.h.
15885 * python/py-function.c: Do not include py-ref.h.
15886 * python/py-infevents.c: Do not include py-ref.h.
15887 * python/py-linetable.c: Do not include py-ref.h.
15888 * python/py-objfile.c: Do not include py-ref.h.
15889 * python/py-param.c: Do not include py-ref.h.
15890 * python/py-prettyprint.c: Do not include py-ref.h.
15891 * python/py-progspace.c: Do not include py-ref.h.
15892 * python/py-symbol.c: Do not include py-ref.h.
15893 * python/py-symtab.c: Do not include py-ref.h.
15894 * python/py-type.c: Do not include py-ref.h.
15895 * python/py-unwind.c: Do not include py-ref.h.
15896 * python/py-utils.c: Do not include py-ref.h.
15897 * python/py-value.c: Do not include py-ref.h.
15898 * python/py-varobj.c: Do not include py-ref.h.
15899 * python/py-xmethods.c: Do not include py-ref.h.
15900 * python/python.c: Do not include py-ref.h.
15901 * varobj.c: Do not include py-ref.h.
15902
6b4d7774
TT		 159032019-01-22 Tom Tromey <tom@tromey.com>
15904
15905 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15906 keyword for bcache.
15907
7af7e9b5
TT		 159082019-01-22 Tom Tromey <tom@tromey.com>
15909
15910 * compile/compile-cplus-types.c: Remove a comment by #include.
15911
951d1049
TT		 159122019-01-22 Tom Tromey <tom@tromey.com>
15913
15914 * compile/gcc-c-plugin.h: Include compile-internal.h.
15915
d65d5705
TT		 159162019-01-22 Tom Tromey <tom@tromey.com>
15917
15918 * stabsread.c (EXTERN): Do not define.
15919 (symnum, next_symbol_text_func, processing_gcc_compilation)
15920 (within_function, global_sym_chain, global_stabs)
15921 (previous_stab_code, this_object_header_files)
15922 (n_this_object_header_files)
15923 (n_allocated_this_object_header_files): Define.
15924 * stabsread.h (EXTERN): Never define. Use "extern".
15925
b6fb1ee5
PW		 159262019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15927
15928 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15929 history_value.
15930
be6d4f74
TT		 159312019-01-21 Tom Tromey <tom@tromey.com>
15932
15933 * ui-out.c: Fix includes.
15934 * tui/tui-source.c: Fix includes.
15935 * target.c: Fix includes.
15936 * remote.c: Fix includes.
15937 * regcache.c: Fix includes.
15938 * python/py-block.c: Fix includes.
15939 * printcmd.c: Fix includes.
15940 * or1k-tdep.c: Fix includes.
15941 * mi/mi-main.c: Fix includes.
15942 * m32r-tdep.c: Fix includes.
15943 * csky-tdep.c: Fix includes.
15944 * compile/compile-cplus-types.c: Fix includes.
15945 * cli/cli-interp.c: Fix includes.
15946
73021deb
AH		 159472019-01-21 Alan Hayward <alan.hayward@arm.com>
15948
15949 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15950 for padding.
15951
7932255d
TT		 159522019-01-16 Tom Tromey <tom@tromey.com>
15953
15954 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15955 earlier.
15956 (struct objfile) <msymbols_range>: Move from top level.
15957 <msymbols>: New method.
15958 (class objfile_msymbols): Remove.
15959 * symtab.c (default_collect_symbol_completion_matches_break_on):
15960 Update.
15961 * symmisc.c (dump_msymbols): Update.
15962 * stabsread.c (scan_file_globals): Update.
15963 * objc-lang.c (info_selectors_command, info_classes_command)
15964 (find_methods): Update.
15965 * minsyms.c (find_solib_trampoline_target): Update.
15966 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15967 * coffread.c (coff_symfile_read): Update.
15968 * ada-lang.c (ada_lookup_simple_minsym)
15969 (ada_collect_symbol_completion_matches): Update.
15970
604b1bfb
TT		 159712019-01-16 Tom Tromey <tom@tromey.com>
15972
15973 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15974 type. Remove no-argument constructor.
15975 <iterator::operator++>: Simplify.
15976 <begin>: Update.
15977 <end>: Use minimal_symbol_count.
15978
f252c6d5
TT		 159792019-01-16 Tom Tromey <tom@tromey.com>
15980
15981 * objfiles.h (struct objfile) <psymtabs>: New method.
15982 (class objfile_psymtabs): Remove.
15983 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15984 typedef.
15985 <range>: New method.
15986 (require_partial_symbols): Change return type.
15987 * psymtab.c (require_partial_symbols)
15988 (psym_expand_symtabs_matching): Update.
15989 * mdebugread.c (parse_partial_symbols): Update.
15990 * dbxread.c (dbx_end_psymtab): Update.
15991
b669c953
TT		 159922019-01-15 Tom Tromey <tom@tromey.com>
15993
15994 * symtab.c (lookup_objfile_from_block)
15995 (lookup_symbol_in_objfile_symtabs)
15996 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15997 (find_line_symtab, info_sources_command)
15998 (default_collect_symbol_completion_matches_break_on)
15999 (make_source_files_completion_list): Update.
16000 * symmisc.c (print_objfile_statistics, dump_objfile)
16001 (maintenance_print_symbols, maintenance_info_symtabs)
16002 (maintenance_check_symtabs, maintenance_info_line_tables):
16003 Update.
16004 * source.c (select_source_symtab)
16005 (forget_cached_source_info_for_objfile): Update.
16006 * objfiles.h (class objfile_compunits): Remove.
16007 (struct objfile) <compunits_range>: New typedef.
16008 (compunits): New method.
16009 * objfiles.c (objfile_relocate1): Update.
16010 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16011 * maint.c (count_symtabs_and_blocks): Update.
16012 * linespec.c (iterate_over_all_matching_symtabs): Update.
16013 * cp-support.c (add_symbol_overload_list_qualified): Update.
16014 * coffread.c (coff_symtab_read): Update.
16015 * ada-lang.c (add_nonlocal_symbols)
16016 (ada_collect_symbol_completion_matches)
16017 (ada_add_global_exceptions): Update.
16018
7e955d83
TT		 160192019-01-15 Tom Tromey <tom@tromey.com>
16020
16021 * progspace.h (program_space) <objfiles_safe_range>: New
16022 typedef.
16023 <objfiles_safe>: New method.
16024 * objfiles.h (class all_objfiles_safe): Remove.
16025 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16026 * jit.c (jit_inferior_exit_hook): Update.
16027
2030c079
TT		 160282019-01-17 Tom Tromey <tom@tromey.com>
16029
16030 * progspace.h (program_space) <objfiles_range>: New typedef.
16031 <objfiles>: New method.
16032 <objfiles_head>: Rename from objfiles.
16033 (object_files): Update.
16034 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16035 * guile/scm-pretty-print.c
16036 (ppscm_find_pretty_printer_from_objfiles): Update.
16037 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16038 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16039 Update.
16040 * python/py-progspace.c (pspy_get_objfiles): Update.
16041 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16042 Update.
16043 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16044 (objfpy_lookup_objfile_by_build_id): Update.
16045 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16046 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16047 Update.
16048 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16049 (expand_symtab_containing_pc, lookup_objfile_from_block)
16050 (lookup_static_symbol, basic_lookup_transparent_type)
16051 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16052 (find_line_symtab, info_sources_command)
16053 (default_collect_symbol_completion_matches_break_on)
16054 (make_source_files_completion_list, find_main_name): Update.
16055 * symmisc.c (print_symbol_bcache_statistics)
16056 (print_objfile_statistics, maintenance_print_symbols)
16057 (maintenance_print_msymbols, maintenance_print_objfiles)
16058 (maintenance_info_symtabs, maintenance_check_symtabs)
16059 (maintenance_expand_symtabs, maintenance_info_line_tables):
16060 Update.
16061 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16062 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16063 (map_overlay_command, unmap_overlay_command)
16064 (simple_overlay_update, expand_symtabs_matching)
16065 (map_symbol_filenames): Update.
16066 * symfile-debug.c (set_debug_symfile): Update.
16067 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16068 Update.
16069 * source.c (select_source_symtab, forget_cached_source_info):
16070 Update.
16071 * solib.c (solib_read_symbols): Update.
16072 * solib-spu.c (append_ocl_sos): Update.
16073 * psymtab.c (maintenance_print_psymbols)
16074 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16075 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16076 * printcmd.c (info_symbol_command): Update.
16077 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16078 Update.
16079 * objfiles.h (class all_objfiles): Remove.
16080 * objfiles.c (have_partial_symbols, have_full_symbols)
16081 (have_minimal_symbols, qsort_cmp, update_section_map)
16082 (shared_objfile_contains_address_p)
16083 (default_iterate_over_objfiles_in_search_order): Update.
16084 * objc-lang.c (info_selectors_command, info_classes_command)
16085 (find_methods): Update.
16086 * minsyms.c (find_solib_trampoline_target): Update.
16087 * maint.c (maintenance_info_sections)
16088 (maintenance_translate_address, count_symtabs_and_blocks):
16089 Update.
16090 * main.c (captured_main_1): Update.
16091 * linux-thread-db.c (try_thread_db_load_from_pdir)
16092 (has_libpthread): Update.
16093 * linespec.c (iterate_over_all_matching_symtabs)
16094 (search_minsyms_for_name): Update.
16095 * jit.c (jit_find_objf_with_entry_addr): Update.
16096 * hppa-tdep.c (find_unwind_entry)
16097 (hppa_lookup_stub_minimal_symbol): Update.
16098 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16099 Update.
16100 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16101 (elf_gnu_ifunc_resolve_by_got): Update.
16102 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16103 * dwarf-index-write.c (save_gdb_index_command): Update.
16104 * cp-support.c (add_symbol_overload_list_qualified): Update.
16105 * breakpoint.c (create_overlay_event_breakpoint)
16106 (create_longjmp_master_breakpoint)
16107 (create_std_terminate_master_breakpoint)
16108 (create_exception_master_breakpoint): Update.
16109 * blockframe.c (find_pc_partial_function): Update.
16110 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16111 (ada_collect_symbol_completion_matches)
16112 (ada_add_global_exceptions): Update.
16113
776489e0
TT		 161142019-01-17 Tom Tromey <tom@tromey.com>
16115
16116 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16117 declare VEC.
16118 (solib_target_parse_libraries): Change return type.
16119 (library_list_start_segment, library_list_start_section)
16120 (library_list_end_library, library_list_start_library); Update.
16121 (solib_target_free_library_list): Remove.
16122 (solib_target_parse_libraries): Remove cleanup. Change return
16123 type.
16124 (solib_target_current_sos): Update.
16125
6471e7d2
TT		 161262019-01-17 Tom Tromey <tromey@bapiya>
16127
16128 * valprint.c: Replace "the the" with "the".
16129 * symtab.c: Replace "the the" with "the".
16130 * solib.c: Replace "the the" with "the".
16131 * solib-dsbt.c: Replace "the the" with "the".
16132 * linespec.c: Replace "the the" with "the".
16133 * dwarf2loc.h: Replace "the the" with "the".
16134 * amd64-windows-tdep.c: Replace "the the" with "the".
16135 * aarch64-tdep.c: Replace "the the" with "the".
16136
c24bdb02
KS		 161372019-01-16 Keith Seitz <keiths@redhat.com>
16138
16139 PR gdb/23773
16140 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16141 <builder>: Rename to ..
16142 <m_builder>: ... this and make private.
16143 (dwarf2_cu::get_builder): New method. Change all users of
16144 `builder' to use this method.
16145 (dwarf2_start_symtab): Move to ...
16146 (dwarf2_cu::start_symtab): ... here. Update all callers
16147 (setup_type_unit_groups): Move to ...
16148 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16149 callers.
16150 (dwarf2_cu::reset_builder): New method.
16151 (process_full_compunit, process_full_type_unit): Use
16152 dwarf2_cu::reset_builder.
16153 (follow_die_offset): Record the ancestor CU if it is different
16154 from the followed DIE's CU.
16155 (follow_die_sig_1): Likewise.
16156
8d64371b
TT		 161572019-01-15 Tom Tromey <tom@tromey.com>
16158
16159 * remote.c (class remote_state) <buf>: Now a char_vector.
16160 <buf_size>: Remove.
16161 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16162 parameter.
16163 (remote_target::getpkt_or_notif_sane_1)
16164 (remote_target::getpkt_sane)
16165 (remote_target::getpkt_or_notif_sane): Likewise.
16166 (class remote_target) <putpkt>: New overload.
16167 (remote_target::read_frame): Change type of "buf_p". Remove
16168 sizeof_p parameter.
16169 (packet_ok): New overload.
16170 (packet_check_result): New overload.
16171 Update all uses.
16172
bb277751
TT		 161732019-01-14 Tom Tromey <tom@tromey.com>
16174
16175 * remote-notif.c (handle_notification, remote_notif_ack)
16176 (remote_notif_parse): Make "buf" const.
16177 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16178 const.
16179 (remote_notif_parse, remote_notif_ack, handle_notification):
16180 Likewise.
16181 * remote.c (remote_notif_stop_parse): Make "buf" const.
16182 (remote_target::remote_parse_stop_reply): Make "buf" const.
16183 (remote_notif_stop_ack): Make "buf" const.
16184
05be00a8
TT		 161852019-01-14 Tom Tromey <tom@tromey.com>
16186
16187 * remote.c (remote_console_output): Make parameter const.
16188
491adeca
TT		 161892019-01-14 Tom Tromey <tom@tromey.com>
16190
16191 * target-debug.h (target_debug_print_signals): Constify.
16192 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16193 * procfs.c (procfs_target::pass_signals): Update.
16194 * linux-nat.c (linux_nat_target::pass_signals): Update.
16195 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16196 * target-delegates.c: Rebuild.
16197 * remote.c (remote_target::program_signals): Update.
16198 (remote_target::pass_signals): Update.
16199 * target.c (target_pass_signals): Constify argument.
16200 (target_program_signals): Likewise.
16201 * target.h (struct target_ops) <pass_signals, program_signals>:
16202 Constify argument.
16203 (target_pass_signals, target_program_signals): Constify argument.
16204
bbd94648
TT		 162052019-01-14 Tom Tromey <tom@tromey.com>
16206
16207 PR tui/28819:
16208 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16209
6f072a10
PFC		 162102019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16211
16212 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16213 field.
16214 * rs6000-tdep.c: Include reggroups.h.
16215 (IS_V_ALIAS_PSEUDOREG): Define.
16216 (rs6000_register_name): Return names for the "vX" aliases.
16217 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16218 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16219 aliases. Call default_register_reggroup_p for all other
16220 pseudo-registers.
16221 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16222 New functions.
16223 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16224 Handle "vX" aliases.
16225 (v_alias_pseudo_register_collect): New function.
16226 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16227 (rs6000_gdbarch_init): Initialize "vX" aliases as
16228 pseudo-registers. Restore registration of
16229 rs6000_pseudo_register_reggroup_p with
16230 set_tdesc_pseudo_register_reggroup_p.
16231
1a782351
MF		 162322019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16233
16234 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16235 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16236 set_gdbarch_num_pseudo_regs.
16237
d73cff18
PW		 162382019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16239
16240 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16241 Remove arg prefixname, add do_set and do_show.
16242 Add member functions set_list and show_list.
16243 * cli/cli-style.c (class cli_style_option): Update accordingly.
16244 (style_set_list): Move to file scope.
16245 (style_show_list): Likewise.
16246 (set_style): Call help_list.
16247 (show_style): Call cmd_show_list.
16248 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16249 Update to use the new macro.
16250
60a90376
JB		 162512019-10-12 Joel Brobecker <brobecker@adacore.com>
16252
16253 * ada-lang.c (_initialize_ada_language): Expand the help text
16254 for the "catch exception" command.
16255
9d7c67bf
PW		 162562019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16257
16258 * symtab.c (matching_obj_sections): Initialize obj,
16259 declare it closer to its usage.
16260
7cf47dc4
TT		 162612019-01-10 Tom Tromey <tom@tromey.com>
16262
16263 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16264 (basic_inf_threads_range): Remove.
16265 (inf_threads_range, inf_non_exited_threads_range)
16266 (safe_inf_threads_range): Use next_adapter.
16267
d3cb6808
KS		 162682019-01-10 Keith Seitz <keiths@redhat.com>
16269
16270 PR gdb/23712
16271 PR symtab/23010
16272 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16273 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16274
63a20375
KS		 162752019-01-10 Keith Seitz <keiths@redhat.com>
16276
16277 PR gdb/23712
16278 PR symtab/23010
16279 * dictionary.c (pending_to_vector): Remove.
16280 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16281 Remove _1 suffix, replacing functions of the same name. Update
16282 all callers.
16283 (dict_create_hashed, dict_create_hashed_expandable)
16284 (dict_create_linear, dict_create_linear_expandable, dict_free)
16285 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16286 Make functions static.
16287
b026f593
KS		 162882019-01-10 Keith Seitz <keiths@redhat.com>
16289
16290 PR gdb/23712
16291 PR symtab/23010
16292 * dictionary.h (struct dictionary): Replace declaration with
16293 multidictionary.
16294 (dict_create_hashed, dict_create_hashed_expandable)
16295 (dict_create_linear, dict_create_linear_expandable)
16296 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16297 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16298 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16299 taking multidictionary argument.
16300 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16301 * block.h (struct block) <dict>: Change to multidictionary
16302 and rename `multidict'.
16303 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16304 symmisc.c: Update all dictionary references to multidictionary.
16305
c7748ee9
KS		 163062019-01-10 Keith Seitz <keiths@redhat.com>
16307
16308 PR gdb/23712
16309 PR symtab/23010
16310 * dictionary.c: Include unordered_map.
16311 (pending_to_vector): New function.
16312 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16313 Rewrite the non-"_1" functions to take vector instead
16314 of linked list.
16315 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16316 "new" _1 versions of the same name.
16317 (multidictionary): Define.
16318 (std::hash<enum language): New definition.
16319 (collate_pending_symbols_by_language, mdict_create_hashed)
16320 (mdict_create_hashed_expandable, mdict_create_linear)
16321 (mdict_create_linear_expandable, mdict_free)
16322 (find_language_dictionary, create_new_language_dictionary)
16323 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16324 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16325 (mdict_size, mdict_empty): New functions.
16326 * dictionary.h (mdict_iterator): Define.
16327
67aa1f3c
PA		 163282019-01-10 Pedro Alves <palves@redhat.com>
16329
16330 * breakpoint.c (read_uploaded_action)
16331 (create_tracepoint_from_upload): Adjust to use
16332 gdb::unique_xmalloc_ptr.
16333 * ctf.c (ctf_write_uploaded_tp):
16334 (SET_ARRAY_FIELD): Use emplace_back.
16335 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16336 * tracefile-tfile.c (tfile_write_uploaded_tp):
16337 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16338 gdb::unique_xmalloc_ptr.
16339 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16340 at_string, cond_string, cmd_strings>: Replace char pointers
16341 with gdb::unique_xmalloc_ptr.
16342
2f667667
PA		 163432019-01-10 Pedro Alves <palves@redhat.com>
16344
16345 * solib-target.c (library_list_start_library): Don't xstrdup name.
16346
36cb7237
PA		 163472019-01-10 Pedro Alves <palves@redhat.com>
16348
16349 * mdebugread.c (parse_partial_symbols): Use
16350 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16351
da584958
AB		 163522019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16353
16354 * linux-fork.c (scoped_switch_fork_info)
16355 <~scoped_switch_fork_info>: Fix incorrect variable name.
16356
1ef8573c
AB		 163572019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16358
16359 * linux-fork.c (scoped_switch_fork_info)
16360 <scoped_switch_fork_info>: Make explicit.
16361 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16362
8d7bcccb
TT		 163632019-01-10 Tom Tromey <tom@tromey.com>
16364
16365 * objfiles.h (objfile::reset_psymtabs): Update.
16366 * objfiles.c (objfile::objfile): Update.
16367 * psymtab.h (psymtab_storage::obstack): Update.
16368 (psymtab_storage::m_obstack): Use gdb::optional.
16369 (class psymtab_storage): Update comment. Remove objfile
16370 parameter.
16371 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16372
b596a3c7
TT		 163732019-01-10 Tom Tromey <tom@tromey.com>
16374
16375 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16376 <free_psymtabs>: Now private.
16377 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16378 (allocate_psymtab): Use new method.
16379
a9342b62
TT		 163802019-01-10 Tom Tromey <tom@tromey.com>
16381
16382 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16383 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16384 * mdebugread.c (parse_partial_symbols): Use
16385 allocate_dependencies.
16386 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16387 allocate_dependencies.
16388 (process_psymtab_comp_unit_reader)
16389 (build_type_psymtab_dependencies): Likewise.
16390 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16391
5af70966
TT		 163922019-01-10 Tom Tromey <tom@tromey.com>
16393
16394 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16395 PSYMBOL_SET_LANGUAGE.
16396 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16397
5923a04c
TT		 163982019-01-10 Tom Tromey <tom@tromey.com>
16399
16400 * psymtab.h (psymtab_storage::obstack): New method.
16401 <m_obstack>: Rename from obstack; now private.
16402 * psymtab.c (psymtab_storage): Update.
16403 * dwarf2read.c (create_addrmap_from_index)
16404 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16405 Update.
16406
6d6a12bf
TT		 164072019-01-10 Tom Tromey <tom@tromey.com>
16408
16409 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16410 * objfiles.h (objfile::reset_psymtabs): New method.
16411
d320c2b5
TT		 164122019-01-10 Tom Tromey <tom@tromey.com>
16413
16414 * symmisc.c (print_symbol_bcache_statistics): Update.
16415 (print_objfile_statistics): Update.
16416 * symfile.c (reread_symbols): Update.
16417 * psymtab.h (class psymtab_storage): New.
16418 * psymtab.c (psymtab_storage): New constructor.
16419 (~psymtab_storage): New destructor.
16420 (require_partial_symbols): Update.
16421 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16422 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16423 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16424 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16425 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16426 (start_psymtab_common, end_psymtab_common)
16427 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16428 (allocate_psymtab): Update.
16429 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16430 Update.
16431 (dump_psymtab_addrmap, maintenance_print_psymbols)
16432 (maintenance_check_psymtabs): Update.
16433 (class objfile_psymtabs): Move to objfiles.h.
16434 * psympriv.h (discard_psymtab): Now inline.
16435 (psymtab_discarder::psymtab_discarder): Update.
16436 (psymtab_discarder::~psymtab_discarder): Update.
16437 (ALL_OBJFILE_PSYMTABS): Rewrite.
16438 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16439 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16440 Remove fields.
16441 <partial_symtabs>: New field.
16442 (class objfile_psymtabs): Move from psymtab.h. Update.
16443 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16444 psymbol_cache.
16445 (objfile::~objfile): Don't destroy psymbol_cache.
16446 * mdebugread.c (parse_partial_symbols): Update.
16447 * dwarf2read.c (create_addrmap_from_index)
16448 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16449 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16450 (add_partial_subprogram, dwarf2_ranges_read): Update.
16451 * dwarf-index-write.c (write_address_map)
16452 (write_one_signatured_type, recursively_write_psymbols)
16453 (class debug_names, class debug_names, write_psymtabs_to_index):
16454 Update.
16455
1d94a5a3
TT		 164562019-01-10 Tom Tromey <tom@tromey.com>
16457
16458 * symtab.h (SYMBOL_SET_NAMES): Update.
16459 (symbol_set_names): Update.
16460 (MSYMBOL_SET_NAMES): Update.
16461 * symtab.c (symbol_set_names): Change argument to be an
16462 objfile_per_bfd_storage.
16463 * psymtab.c (add_psymbol_to_bcache): Update.
16464 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16465
0f14768a
TT		 164662019-01-10 Tom Tromey <tom@tromey.com>
16467
16468 * symtab.c (create_demangled_names_hash): Change argument to be an
16469 objfile_per_bfd_storage.
16470 (symbol_set_names): Update.
16471
6eee24ce
TT		 164722019-01-10 Tom Tromey <tom@tromey.com>
16473
16474 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16475 init_psymbol_list.
16476 * psymtab.c (init_psymbol_list): Do nothing if already called.
16477 * psympriv.h (init_psymbol_list): Add comment.
16478 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16479 init_psymbol_list.
16480 * dbxread.c (dbx_symfile_read): Unconditionally call
16481 init_psymbol_list.
16482
75aedd27
TT		 164832019-01-10 Tom Tromey <tom@tromey.com>
16484
16485 * xcoffread.c (scan_xcoff_symtab): Update.
16486 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16487 "where".
16488 * mdebugread.c (parse_partial_symbols)
16489 (handle_psymbol_enumerators): Update.
16490 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16491 * dbxread.c (read_dbx_symtab): Update.
16492 * psympriv.h (psymbol_placement): New enum.
16493 (add_psymbol_to_list): Update.
16494
939652a5
TT		 164952019-01-10 Tom Tromey <tom@tromey.com>
16496
16497 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16498 static_psymbols parameters.
16499 (scan_xcoff_symtab): Update.
16500 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16501 static_psymbols parameters.
16502 * psympriv.h (start_psymtab_common): Update.
16503 * mdebugread.c (parse_partial_symbols): Update.
16504 * dwarf2read.c (create_partial_symtab): Update.
16505 * dbxread.c (read_dbx_symtab): Update.
16506 (start_psymtab): Remove global_psymbols and static_psymbols
16507 parameters.
16508
baa62830
TT		 165092019-01-10 Tom Tromey <tom@tromey.com>
16510
16511 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16512 * psymtab.c (allocate_psymtab): Add comment.
16513 * psympriv.h (allocate_psymtab): Add comment.
16514 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16515 initializations.
16516 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16517
0e8f53ba
TT		 165182019-01-10 Tom Tromey <tom@tromey.com>
16519
16520 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16521 Don't declare.
16522 * mipsread.c: Include mdebugread.h.
16523 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16524 Declare.
16525 * elfread.c: Include mdebugread.h.
16526
b22a7c6a
TT		 165272019-01-09 Tom Tromey <tom@tromey.com>
16528
16529 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16530 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16531 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16532 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16533 (psym_lookup_symbol, psym_find_last_source_symtab)
16534 (psym_forget_cached_source_info, psym_print_stats)
16535 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16536 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16537 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16538 (psym_find_compunit_symtab_by_address)
16539 (maintenance_print_psymbols, maintenance_info_psymtabs)
16540 (maintenance_check_psymtabs): Use ranged for.
16541 * psymtab.h (class objfile_psymtabs): New.
16542 (require_partial_symbols): Return objfile_psymtabs.
16543 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16544
3b9d3ac2
TT		 165452019-01-09 Tom Tromey <tom@tromey.com>
16546
16547 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16548 (find_pc_mapped_section, list_overlays_command)
16549 (map_overlay_command, unmap_overlay_command)
16550 (simple_overlay_update): Use all_objfiles.
16551 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16552 * printcmd.c (info_symbol_command): Use all_objfiles.
16553 * objfiles.h (ALL_OBJSECTIONS): Remove.
16554 * maint.c (maintenance_translate_address): Use all_objfiles.
16555 * gcore.c (gcore_create_callback): Use all_objfiles.
16556 (objfile_find_memory_regions): Likewise.
16557
8b31193a
TT		 165582019-01-09 Tom Tromey <tom@tromey.com>
16559
16560 * symtab.c (find_line_symtab, info_sources_command)
16561 (make_source_files_completion_list): Use objfile_compunits.
16562 * source.c (select_source_symtab): Use objfile_compunits.
16563 * objfiles.h (struct objfile): Update comment.
16564 (ALL_OBJFILES): Remove.
16565 (ALL_FILETABS): Remove.
16566 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16567 objfile_compunits.
16568
d5da8b3c
TT		 165692019-01-09 Tom Tromey <tom@tromey.com>
16570
16571 * symmisc.c (print_objfile_statistics, dump_objfile)
16572 (maintenance_print_symbols): Use compunit_filetabs.
16573 * source.c (forget_cached_source_info_for_objfile): Use
16574 compunit_filetabs.
16575 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16576 (ALL_FILETABS): Use compunit_filetabs.
16577 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16578 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16579
5accd1a0
TT		 165802019-01-09 Tom Tromey <tom@tromey.com>
16581
16582 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16583 (compunit_filetabs): New.
16584 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16585 compunit_filetabs.
16586 (info_sources_command, make_source_files_completion_list): Remove
16587 declaration.
16588 * symmisc.c (print_objfile_statistics, dump_objfile)
16589 (maintenance_print_symbols): Remove declaration.
16590 (maintenance_info_symtabs): Use compunit_filetabs.
16591 (maintenance_info_line_tables): Likewise.
16592 * source.c (select_source_symtab): Change local variable name.
16593 (forget_cached_source_info_for_objfile): Remove declaration.
16594 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16595 * objfiles.c (objfile_relocate1): Remove declaration.
16596 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16597 declaration.
16598 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16599 * coffread.c (coff_symtab_read): Remove declaration.
16600 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16601 compunit_filetabs.
16602
d8aeb77f
TT		 166032019-01-09 Tom Tromey <tom@tromey.com>
16604
16605 * symtab.c (lookup_objfile_from_block)
16606 (find_pc_sect_compunit_symtab, search_symbols)
16607 (default_collect_symbol_completion_matches_break_on): Use
16608 objfile_compunits.
16609 * objfiles.h (ALL_COMPUNITS): Remove.
16610 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16611 * cp-support.c (add_symbol_overload_list_qualified): Use
16612 objfile_compunits.
16613 * ada-lang.c (ada_collect_symbol_completion_matches)
16614 (ada_add_global_exceptions): Use objfile_compunits.
16615
592553c4
TT		 166162019-01-09 Tom Tromey <tom@tromey.com>
16617
16618 * source.c (select_source_symtab)
16619 (forget_cached_source_info_for_objfile): Remove declaration.
16620 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16621 declaration.
16622 * maint.c (count_symtabs_and_blocks): Remove declaration.
16623 * cp-support.c (add_symbol_overload_list_qualified): Remove
16624 declaration.
16625 * coffread.c (coff_symtab_read): Remove declaration.
16626 * symtab.c (lookup_symbol_in_objfile_symtabs)
16627 (basic_lookup_transparent_type_1): Use objfile_compunits.
16628 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16629 (info_sources_command, search_symbols)
16630 (default_collect_symbol_completion_matches_break_on)
16631 (make_source_files_completion_list): Remove declaration.
16632 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16633 (ada_collect_symbol_completion_matches)
16634 (ada_add_global_exceptions): Remove declaration.
16635 * linespec.c (iterate_over_all_matching_symtabs): Use
16636 objfile_compunits.
16637 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16638 (class objfile_compunits): New.
16639 (ALL_COMPUNITS): Use objfile_compunits.
16640 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16641 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16642 objfile_compunits.
16643 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16644
5325b9bf
TT		 166452019-01-09 Tom Tromey <tom@tromey.com>
16646
16647 * symtab.c (search_symbols)
16648 (default_collect_symbol_completion_matches_break_on): Use
16649 objfile_msymbols.
16650 * ada-lang.c (ada_lookup_simple_minsym)
16651 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16652 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16653 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16654 objfile_msymbols.
16655 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16656 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16657 * objc-lang.c (find_methods): Use objfile_msymbols.
16658 (info_selectors_command, info_classes_command): Likewise.
16659 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16660 * objfiles.h (class objfile_msymbols): New.
16661 (ALL_OBJFILE_MSYMBOLS): Remove.
16662 (ALL_MSYMBOLS): Remove.
16663
cac85af2
TT		 166642019-01-09 Tom Tromey <tom@tromey.com>
16665
16666 * common/next-iterator.h (next_adapter): Add Iterator template
16667 parameter.
16668 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16669 (class all_objfiles_safe): New.
16670 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16671 * objfiles.c (put_objfile_before): Update comment.
16672 (add_separate_debug_objfile): Likewise.
16673 (free_all_objfiles): Use all_objfiles_safe.
16674 (objfile_purge_solibs): Likewise.
16675
aed57c53
TT		 166762019-01-09 Tom Tromey <tom@tromey.com>
16677
16678 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16679 (expand_symtab_containing_pc, lookup_static_symbol)
16680 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16681 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16682 all_objfiles.
16683 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16684 * breakpoint.c (create_overlay_event_breakpoint)
16685 (create_longjmp_master_breakpoint)
16686 (create_std_terminate_master_breakpoint)
16687 (create_exception_master_breakpoint): Use all_objfiles.
16688 * linux-thread-db.c (try_thread_db_load_from_pdir)
16689 (has_libpthread): Use all_objfiles.
16690 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16691 * linespec.c (iterate_over_all_matching_symtabs)
16692 (search_minsyms_for_name): Use all_objfiles.
16693 * maint.c (maintenance_info_sections): Use all_objfiles.
16694 * main.c (captured_main_1): Use all_objfiles.
16695 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16696 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16697 * guile/scm-pretty-print.c
16698 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16699 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16700 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16701 (maintenance_print_msymbols): Use all_objfiles.
16702 * source.c (select_source_symtab): Use all_objfiles.
16703 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16704 * symfile.c (remove_symbol_file_command)
16705 (expand_symtabs_matching, map_symbol_filenames): Use
16706 all_objfiles.
16707 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16708 all_objfiles.
16709 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16710 * objc-lang.c (find_methods): Use all_objfiles.
16711 * objfiles.c (have_partial_symbols, have_full_symbols)
16712 (have_minimal_symbols, qsort_cmp)
16713 (default_iterate_over_objfiles_in_search_order): Use
16714 all_objfiles.
16715 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16716 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16717 (maintenance_check_psymtabs): Use all_objfiles.
16718 (ALL_PSYMTABS): Remove.
16719 * compile/compile-object-run.c (do_module_cleanup): Use
16720 all_objfiles.
16721 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16722 * cp-support.c (add_symbol_overload_list_qualified): Use
16723 all_objfiles.
16724 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16725 Use all_objfiles.
16726 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16727 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16728 all_objfiles.
16729 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16730 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16731 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16732 Uses all_objfiles.
16733 * solib.c (solib_read_symbols): Use all_objfiles
16734
99d89cde
TT		 167352019-01-09 Tom Tromey <tom@tromey.com>
16736
16737 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16738 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16739 all_objfiles.
16740 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16741 * symmisc.c (print_symbol_bcache_statistics)
16742 (print_objfile_statistics, maintenance_print_objfiles)
16743 (maintenance_info_symtabs, maintenance_check_symtabs)
16744 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16745 all_objfiles.
16746 * source.c (forget_cached_source_info): Use all_objfiles.
16747 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16748 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16749 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16750 * objfiles.c (update_section_map): Use all_objfiles.
16751 (shared_objfile_contains_address_p): Likewise.
16752 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16753 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16754
21708325
TT		 167552019-01-09 Tom Tromey <tom@tromey.com>
16756
16757 * common/next-iterator.h: New file.
16758 * objfiles.h (class all_objfiles): New.
16759 (struct objfile_iterator): New.
16760
669e09f6
PW		 167612019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16762
16763 * NEWS: Move the description of the changed "frame", "select-frame",
16764 and "info frame" commands to the Changed commands section.
16765
041be526
SM		 167662019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16767
16768 * gdbtypes.c (check_stub_method_group): Remove handling of old
16769 mangling schemes.
16770 * linespec.c (find_methods): Likewise.
16771 * stabsread.c (read_member_functions): Likewise.
16772 * valops.c (search_struct_method): Likewise.
16773 (value_struct_elt_for_reference): Likewise.
16774 * NEWS: Mention this change.
16775
0e2a2133
AB		 167762019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16777
16778 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16779 print_source_lines.
16780 * source.c (print_source_lines_base): Update line number check.
16781 (print_source_lines): New function.
16782 (source_lines_range::source_lines_range): New function.
16783 * source.h (class source_lines_range): New class.
16784 (print_source_lines): New declaration.
16785
1055a3b4
PW		 167862019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16787
16788 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16789
cfeadda5
TT		 167902019-01-08 Tom Tromey <tom@tromey.com>
16791 Simon Marchi <simon.marchi@ericsson.com>
16792
16793 PR gdb/24060
16794 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16795 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16796 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16797 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16798 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16799 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16800
583068ca
AB		 168012019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16802
16803 * source.c (select_source_symtab): Move header comment to
16804 declaration in source.h.
16805 (forget_cached_source_info_for_objfile): Likewise.
16806 (forget_cached_source_info): Likewise.
16807 (identify_source_line): Likewise.
16808 * source.h (identify_source_line): Move declaration from symtab.h
16809 and add comment from source.c
16810 (print_source_lines): Likewise.
16811 (forget_cached_source_info_for_objfile): Likewise.
16812 (forget_cached_source_info): Likewise.
16813 (select_source_symtab): Likewise.
16814 (enum print_source_lines_flag): Move definition from symtab.h.
16815 * symtab.h (identify_source_line): Move declaration to source.h.
16816 (print_source_lines): Likewise.
16817 (forget_cached_source_info_for_objfile): Likewise.
16818 (forget_cached_source_info): Likewise.
16819 (select_source_symtab): Likewise.
16820 (enum print_source_lines_flag): Move definition to source.h.
16821 * tui/tui-hooks.c: Add 'source.h' include.
16822
ec98a4ad
AB		 168232019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16824
16825 * source.c (print_source_lines_base): Handle requests to print
16826 reverse line number sequences, and guard against empty lines
16827 string.
16828
62ea19c1
AB		 168292019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16830
16831 * source.c (print_source_lines_base): Fix skip of '\r' if next
16832 character is '\n'.
16833
9d30e1fd
TT		 168342019-01-06 Tom Tromey <tom@tromey.com>
16835
16836 * c-exp.y (struct c_parse_state) <macro_original_text,
16837 expansion_obstack>: New member.
16838 (macro_original_text, expansion_obstack): Remove globals.
16839 (scan_macro_expansion, scanning_macro_expansion)
16840 (finished_macro_expansion): Update.
16841 (scan_macro_cleanup): Remove.
16842 (yylex, c_parse): Update.
16843
c65bac38
TT		 168442019-01-06 Tom Tromey <tom@tromey.com>
16845
16846 * c-exp.y (struct c_parse_state) <strings>: New member.
16847 (operator_stoken): Update.
16848
02e12e38
TT		 168492019-01-06 Tom Tromey <tom@tromey.com>
16850
16851 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16852 (union type_stack_elt) <typelist_val>: Now a pointer to
16853 std::vector.
16854 (type_stack_cleanup): Don't declare.
16855 (push_typelist): Update.
16856 * parse.c (pop_typelist): Return a std::vector.
16857 (push_typelist): Take a std::vector.
16858 (follow_types): Update. Do not free args.
16859 (type_stack_cleanup): Remove.
16860 * c-exp.y (struct c_parse_state): New.
16861 (cpstate): New global.
16862 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16863 (nonempty_typelist): Update.
16864 (func_mod): Create a new vector.
16865 (c_parse): Create a c_parse_state.
16866 (check_parameter_typelist): Do not delete params.
16867 (function_method): Update. Do not delete type_list.
16868
f097f5ad
TT		 168692019-01-06 Tom Tromey <tom@tromey.com>
16870
16871 PR gdb/28155:
16872 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16873 check_typedef.
16874 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16875 (print_return_value): Likewise.
16876
d2adf9f1
TT		 168772019-01-05 Tom Tromey <tom@tromey.com>
16878
16879 * contrib/cleanup_check.py: Remove.
16880 * contrib/gcc-with-excheck: Remove.
16881 * contrib/exsummary.py: Remove.
16882 * contrib/excheck.py: Remove.
16883
2eab46b1
JB		 168842019-01-05 Joel Brobecker <brobecker@adacore.com>
16885
16886 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16887 NULL. Initialize tpprev to NULL instead of assigning it
16888 to NULL on the next statement.
16889 * windows-nat.c (windows_delete_thread): Remove check for
16890 main_thread_id before printing thread exit notifications.
16891 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16892 Remove thread ID check against main_thread_id.
16893 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16894 windows_delete_thread.
16895 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16896
48c5e7e2
TT		 168972019-01-04 Tom Tromey <tom@tromey.com>
16898
16899 * compile/compile.c (_initialize_compile): Use upper case for
16900 metasyntactic variables.
16901 * symmisc.c (_initialize_symmisc): Use upper case for
16902 metasyntactic variables.
16903 * psymtab.c (_initialize_psymtab): Use upper case for
16904 metasyntactic variables.
16905 * demangle.c (demangle_command): Use upper case for metasyntactic
16906 variables.
16907 (_initialize_demangler): Likewise.
16908 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16909 variables.
16910
986041cd
TT		 169112019-01-03 Tom Tromey <tom@tromey.com>
16912
16913 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16914
7c711119
TT		 169152019-01-03 Tom Tromey <tom@tromey.com>
16916
16917 * python/py-symtab.c (salpy_str): Update.
16918 (struct salpy_sal_object) <symtab>: Now a PyObject.
16919 (salpy_dealloc): Update.
16920 (del_objfile_sal): Use gdbpy_ref.
16921
1b20edf0
TT		 169222019-01-03 Tom Tromey <tom@tromey.com>
16923
16924 * python/py-type.c (convert_field): Use new_reference. Return
16925 gdbpy_ref.
16926 (make_fielditem): Return gdbpy_ref.
16927 (typy_fields): Update.
16928 (typy_getitem): Update.
16929 (field_name): Return gdbpy_ref. Use new_reference.
16930 (typy_iterator_iternext): Update.
16931
ea41325b
TT		 169322019-01-03 Tom Tromey <tom@tromey.com>
16933
16934 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16935
2a3c71d6
TT		 169362019-01-03 Tom Tromey <tom@tromey.com>
16937
16938 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16939 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16940 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16941 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16942 (pspy_set_type_printers): Likewise.
16943 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16944 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16945 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16946 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16947 (objfpy_set_type_printers): Likewise.
16948
5c329e6a
TT		 169492019-01-03 Tom Tromey <tom@tromey.com>
16950
16951 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16952 (gdbpy_print_stack): Use gdbpy_err_fetch.
16953 * python/python-internal.h (class gdbpy_err_fetch): New class.
16954 (class gdbpy_enter) <m_error_type, m_error_value,
16955 m_error_traceback>: Remove.
16956 <m_error>: New member.
16957 (gdbpy_exception_to_string): Don't declare.
16958 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16959 * python/py-value.c (convert_value_from_python): Use
16960 gdbpy_err_fetch.
16961 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16962 gdbpy_exception_to_string.
16963 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16964 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16965 gdbpy_err_fetch.
16966
169bb27b
AB		 169672019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16968
16969 * linux-nat.c (delete_lwp_cleanup): Delete.
16970 (struct lwp_deleter): New struct.
16971 (lwp_info_up): New typedef.
16972 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16973 lwp_info_up.
16974
a07c8880
AB		 169752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16976
16977 * linux-fork.c (class scoped_switch_fork_info): New class.
16978 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16979
26089c49
AB		 169802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16981
16982 * valops.c (find_overload_match): Remove use of null_cleanup, and
16983 calls to do_cleanups.
16984
06d3e5b0
AB		 169852019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16986
16987 * compile/compile-cplus-types.c
16988 (compile_cplus_instance::decl_name): Handle changes to
16989 cp_func_name.
16990 * cp-support.c (cp_func_name): Update header comment, update
16991 return type.
16992 * cp-support.h (cp_func_name): Update return type in declaration.
16993 * valops.c (find_overload_match): Move temp_func local to top
16994 level of function and change its type. Use temp_func to hold and
16995 delete temporary string obtained from cp_func_name.
16996
66644cd3
AB		 169972019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16998
16999 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17000 gdb::char_vector, remove cleanup, and update uses of `msg`.
17001
592d8c0a
JW		 170022019-01-03 Jim Wilson <jimw@sifive.com>
17003
17004 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17005
c55d06ec
TT		 170062019-01-02 Tom Tromey <tom@tromey.com>
17007
17008 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17009 (tdesc_parse_xml): Remove cleanups.
17010 * target-descriptions.h (make_cleanup_free_target_description):
17011 Don't declare.
17012 (target_desc_deleter): New struct.
17013 (target_desc_up): New typedef.
17014 * target-descriptions.c (target_desc_deleter::operator()): Rename
17015 from free_target_description.
17016 (make_cleanup_free_target_description): Remove.
17017
3a6ae42d
TT		 170182019-01-02 Tom Tromey <tom@tromey.com>
17019
17020 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17021 constructor, destructor.
17022 (linespec_parser): Remove typedef.
17023 (~linespec_parser): Rename from linespec_parser_delete.
17024 (linespec_lex_to_end, linespec_complete_label)
17025 (linespec_complete): Update.
17026 (decode_line_full): Remove cleanups.
17027 (decode_line_1): Update.
17028
61fd3e73
TT		 170292019-01-02 Tom Tromey <tom@tromey.com>
17030
17031 * python/python-internal.h (inferior_to_inferior_object): Change
17032 return type.
17033 * python/py-exitedevent.c (create_exited_event_object): Update.
17034 * python/py-inferior.c (inferior_to_inferior_object): Return
17035 gdbpy_ref.
17036 (python_new_inferior, python_inferior_deleted)
17037 (thread_to_thread_object, delete_thread_object)
17038 (build_inferior_list, gdbpy_selected_inferior): Update.
17039 * python/py-infthread.c (create_thread_object): Update. Also fail
17040 if inferior_to_inferior_object fails.
17041
d20172fc
SM		 170422019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17043
17044 * inferior.h (class inferior) <displaced_step_state>: New field.
17045 * infrun.h (struct displaced_step_state): Move here from
17046 infrun.c. Initialize fields, add constructor.
17047 <inf>: Remove field.
17048 <reset>: New method.
17049 * infrun.c (struct displaced_step_inferior_state): Move to
17050 infrun.h.
17051 (displaced_step_inferior_states): Remove.
17052 (get_displaced_stepping_state): Adust.
17053 (displaced_step_in_progress_any_inferior): Adjust.
17054 (displaced_step_in_progress_thread): Adjust.
17055 (displaced_step_in_progress): Adjust.
17056 (add_displaced_stepping_state): Remove.
17057 (get_displaced_step_closure_by_addr): Adjust.
17058 (remove_displaced_stepping_state): Remove.
17059 (infrun_inferior_exit): Call displaced_step_state.reset.
17060 (use_displaced_stepping): Don't check for NULL.
17061 (displaced_step_prepare_throw): Call
17062 get_displaced_stepping_state.
17063 (displaced_step_fixup): Don't check for NULL.
17064 (prepare_for_detach): Don't check for NULL.
17065
e3319240
PW		 170662019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17067
17068 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17069 in case of call that did not complete.
17070
5d36dfb9
AU		 170712019-01-02 Andrey Utkin <autkin@undo.io>
17072
17073 * symfile.c (find_separate_debug_file): Fix search of debug files for
17074 remote debuggee.
17075
8833fbf0
TT		 170762019-01-02 Tom Tromey <tom@tromey.com>
17077
17078 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17079 indentation.
17080 * python/py-frame.c (frapy_older): Remove cast.
17081 (frapy_newer): Likewise.
17082 * python/py-breakpoint.c (local_setattro): Remove cast.
17083 * python/py-arch.c (archpy_name): Remove local variable.
17084 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17085
4ada3dfd
JB		 170862019-01-02 Joel Brobecker <brobecker@adacore.com>
17087
17088 * unittests/basic_string_view/element_access/char/empty.cc:
17089 Fix year range in copyright header.
17090
113b7b81
AB		 170912019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17092
17093 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17094 Delete.
17095 <operator==>: Update with for removed field.
17096 <hash>: Likewise.
17097 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17098 <isa_features>: ...this.
17099 <abi_features>: New field.
17100 (riscv_isa_flen): Update comment.
17101 (riscv_abi_xlen): New declaration.
17102 (riscv_abi_flen): New declaration.
17103 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17104 isa_features.
17105 (riscv_abi_xlen): New function.
17106 (riscv_isa_flen): Update to get answer from isa_features.
17107 (riscv_abi_flen): New function.
17108 (riscv_has_fp_abi): Update to get answer from abi_features.
17109 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17110 xlen and flen.
17111 (riscv_call_info) <xlen, flen>: Update comment.
17112 (riscv_call_arg_struct): Remove invalid assertions
17113 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17114 is removed.
17115 (riscv_gdbarch_init): Gather isa features and abi features
17116 separately, ensure both match on the gdbarch when reusing an old
17117 gdbarch. Relax an error check to allow 32-bit abi float to run on
17118 a target with 64-bit float hardware.
17119
b18ca514
PW		 171202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17121
17122 * source.c (search_command_helper): Stop reverse search
17123 when line 1 has been searched.
17124
ec70d8db
PW		 171252019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17126
17127 * record-full.c (record_full_base_target::close): Rewrite
17128 record_full_core_buf_list free logic.
17129
5b38f9c1
PW		 171302019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17131
17132 * break-catch-syscall.c (print_one_catch_syscall): xfree
17133 the last text.
17134
66d91b39
JB		 171352019-01-01 Joel Brobecker <brobecker@adacore.com>
17136
17137 * top.c (print_gdb_version): Update Copyright year in version
17138 message.
17139
42a4f53d
JB		 171402019-01-01 Joel Brobecker <brobecker@adacore.com>
17141
17142 Update copyright year range in all GDB files.
17143
7e955d83 171442019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17145
5bbd631d 17146 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17147
5bbd631d 17148For older changes see ChangeLog-2018.
c906108c
SS		 17149\f
17150Local Variables:
17151mode: change-log
17152left-margin: 8
17153fill-column: 74
17154version-control: never
57da7796 17155coding: utf-8
c906108c 17156End:
5bbd631d 17157
GDB Binutils - Deliverables
This page took 3.376056 seconds and 4 git commands to generate.