projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Use bool in tui_before_prompt
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
2dfd3df4
TT		 12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
4 (tui_before_prompt, tui_normal_stop): Update.
5
54217b84
TT		 62019-12-20 Tom Tromey <tom@tromey.com>
7
8 * tui/tui-winsource.c
9 (tui_source_window_base::update_source_window_as_is): Don't call
10 set_current_source_symtab_and_line.
11
0ab92974
TT		 122019-12-20 Tom Tromey <tom@tromey.com>
13
14 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
15 Take a symtab_and_line.
16 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
17 symtab_and_line.
18 (tui_show_frame_info): Update.
19
ae4393e2
TT		 202019-12-20 Tom Tromey <tom@tromey.com>
21
22 * tui/tui-stack.c (tui_show_frame_info): Don't call
23 update_exec_info.
24
77b97e00
TT		 252019-12-20 Tom Tromey <tom@tromey.com>
26
27 * tui/tui.c (tui_enable): Call tui_display_main.
28
52469d76
TT		 292019-12-20 Tom Tromey <tom@tromey.com>
30
31 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
32 get_current_source_symtab_and_line, and main_name.
33
5d49bf1b
TT		 342019-12-20 Tom Tromey <tom@tromey.com>
35
36 * tui/tui.c (tui_show_source): Update.
37 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
38 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
39 a symtab_symbol_info, not a separate symtab and line. Simplify.
40
88180c08
TT		 412019-12-20 Tom Tromey <tom@tromey.com>
42
43 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
44 Simplify.
45
9f7540a5
TT		 462019-12-20 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-winsource.h (struct tui_source_window_base)
49 <set_contents, update_source_window_as_is, update_source_window>:
50 Take a sal, not a separate symtab and tui_line_or_address.
51 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
52 (tui_source_window_base::update_source_window_as_is): Take a sal,
53 not a separate symtab and tui_line_or_address.
54 (tui_update_source_windows_with_addr)
55 (tui_update_source_windows_with_line)
56 (tui_source_window_base::rerender)
57 (tui_source_window_base::refill): Update.
58 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
59 a sal, not a separate symtab and tui_line_or_address.
60 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
61 not a separate symtab and tui_line_or_address.
62 (tui_source_window::maybe_update): Update.
63 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
64 a sal, not a separate symtab and tui_line_or_address.
65 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
66 not a separate symtab and tui_line_or_address.
67 (tui_disasm_window::do_scroll_vertical)
68 (tui_disasm_window::maybe_update): Update.
69
57e4b379
TT		 702019-12-20 Tom Tromey <tom@tromey.com>
71
72 * tui/tui-winsource.c (tui_source_window_base::refill): Use
73 start_line_or_addr.
74 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
75 start_line_or_addr.
76 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
77 start_line_or_addr.
78
61c33f10
TT		 792019-12-20 Tom Tromey <tom@tromey.com>
80
81 * tui/tui-winsource.h (struct tui_source_window_base)
82 <set_contents>: Return bool.
83 * tui/tui-winsource.c
84 (tui_source_window_base::update_source_window_as_is): Update.
85 * tui/tui-source.h (struct tui_source_window) <set_contents>:
86 Return bool.
87 * tui/tui-source.c (tui_source_window::set_contents): Return
88 bool. Simplify.
89 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
90 Return bool.
91 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
92 bool.
93
469b0731
TT		 942019-12-20 Tom Tromey <tom@tromey.com>
95
96 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
97 (tui_update_source_windows_with_line): Call update_source_window.
98 * tui/tui-source.h (struct tui_source_window)
99 <show_symtab_source>: Don't declare.
100 * tui/tui-source.c (tui_source_window::show_symtab_source):
101 Remove.
102
855f89b3
TT		 1032019-12-20 Tom Tromey <tom@tromey.com>
104
105 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
106 update_source_window directly.
107 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
108 * tui/tui-disasm.c (tui_show_disassem): Remove.
109
d4669c0f
TT		 1102019-12-20 Tom Tromey <tom@tromey.com>
111
112 * tui/tui-winsource.c
113 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
114 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
115
1ae58f0c
TT		 1162019-12-20 Tom Tromey <tom@tromey.com>
117
118 * tui/tui-winsource.h (struct tui_source_window_base)
119 <maybe_update>: Remove line_no and addr parameters.
120 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
121 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
122 Update.
123 * tui/tui-source.c (tui_source_window::maybe_update): Remove
124 line_no and addr parameters.
125 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
126 Update.
127 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
128 line_no and addr parameters.
129
039298ec
TT		 1302019-12-20 Tom Tromey <tom@tromey.com>
131
132 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
133 (tui_source_window_base::update_breakpoint_info): Remove asserts.
134
8acfefcc
TT		 1352019-12-20 Tom Tromey <tom@tromey.com>
136
137 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
138 tui_show_disassem.
139 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
140 declare.
141 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
142
5ebd5402
TT		 1432019-12-20 Tom Tromey <tom@tromey.com>
144
145 * tui/tui.h (tui_show_source): Remove parameters.
146 * tui/tui.c (tui_show_source): Remove parameters.
147 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
148
c1b167d7
TT		 1492019-12-20 Tom Tromey <tom@tromey.com>
150
151 * tui/tui.c (tui_show_source): Update.
152 * tui/tui-winsource.c (tui_display_main): Update.
153 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
154 to symtab.
155 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
156 to symtab.
157 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
158
364d7104
TT		 1592019-12-20 Tom Tromey <tom@tromey.com>
160
161 PR tui/23619:
162 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
163 (tui_redisplay_readline): Use rl_display_prompt.
164 (tui_prep_terminal): Update.
165
0ad6b8ee
CB		 1662019-12-19 Christian Biesinger <cbiesinger@google.com>
167
168 * configure: Regenerate.
169 * configure.ac: Quote variable arguments of test.
170 * gdbsupport/common.m4: Likewise.
171
d411762c
CB		 1722019-12-19 Christian Biesinger <cbiesinger@google.com>
173
174 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
175 2 to pow ().
176
1cd4a20a
CB		 1772019-12-19 Christian Biesinger <cbiesinger@google.com>
178
179 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
180 log10 to double to fix Solaris 11 with gcc 5.5.
181
aa989b27
CB		 1822019-12-19 Christian Biesinger <cbiesinger@google.com>
183
184 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
185 "sun" to "saddr_un".
186
2032eb7e
TT		 1872019-12-19 Tom Tromey <tromey@adacore.com>
188
189 * ui-out.h (enum class field_kind): Fix comment.
190
f69656d0
TT		 1912019-12-11 Tom Tromey <tromey@adacore.com>
192
193 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
194
27e4fac7
TT		 1952019-12-18 Tom Tromey <tromey@adacore.com>
196
197 PR build/25268:
198 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
199 type on macOS. Add comment.
200
e623f035
SM		 2012019-12-18 Simon Marchi <simon.marchi@efficios.com>
202
203 * c-lang.c (c_get_string, asm_language_defn): Remove space
204 before tab.
205
28ce7b07
TT		 2062019-12-18 Tom Tromey <tromey@adacore.com>
207
208 PR build/25250:
209 * ui-out.c (ui_out::vmessage): Update.
210 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
211 Rename.
212 (string_field): Update.
213 (signed_field): Update.
214
bbde7025
SM		 2152019-12-18 Simon Marchi <simon.marchi@efficios.com>
216
217 * top.c (print_gdb_configuration): Adjust indentation.
218
e3169fe0
CB		 2192019-12-17 Christian Biesinger <cbiesinger@google.com>
220
221 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
222
9b30da15
SM		 2232019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
224
225 * tui/tui-layout.h (class tui_layout_base): Add virtual
226 destructor.
227
4a4c04f1
BE		 2282019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
229
230 * infcmd.c (prepare_one_step): Step over skipped inline functions.
231 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
232 (process_event_stop_test): Keep stepping over skipped inline functions.
233
0394eed1
SM		 2342019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
235
236 * jit.c (struct gdb_block) <next>: Remove field.
237 (struct gdb_symtab) <~gdb_symtab>: Remove.
238 <blocks>: Change type to std::forward_list<gdb_block>.
239 (compare_block): Remove.
240 (jit_block_open_impl): Adjust to std::forward_list. Place the new
241 block at the beginning, don't mind about sorting.
242 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
243 before using it.
244
b6112117
SM		 2452019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
246
247 * jit.c (struct gdb_block): Add constructor, initialize
248 real_block and next fields.
249 <name>: Change type to gdb::unique_xmalloc_ptr.
250 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
251 (jit_block_open_impl): Allocate gdb_block with new.
252 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
253
1b61f46d
SM		 2542019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
255
256 * jit.c: Include forward_list.
257 (struct gdb_symtab) <next>: Remove field.
258 (struct gdb_object) <symtabs>: Change type to
259 std::forward_list<gdb_symtab>.
260 (jit_object_open_impl): Allocate gdb_object with new.
261 (jit_symtab_open_impl): Adjust to std::forward_list.
262 (finalize_symtab): Don't delete symtab.
263 (jit_object_close_impl): Adjust to std::forward_list. Free
264 gdb_object with delete.
265
89867184
SM		 2662019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
267
268 * jit.c (struct gdb_symtab): Add constructor, destructor,
269 initialize fields.
270 <linetable>: Change type to unique_xmalloc_ptr.
271 <file_name>: Change type to std::string.
272 (jit_symtab_open_impl): Allocate gdb_symtab with new.
273 (jit_symtab_line_mapping_add_impl): Adjust.
274 (finalize_symtab): Adjust, call delete on stab.
275
d043f8c8
SM		 2762019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
277
278 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
279
d9fa87f4
TT		 2802019-12-16 Tom Tromey <tromey@adacore.com>
281
282 * windows-nat.c (windows_nat_target::attach): Update.
283 * remote.c (extended_remote_target::attach): Update.
284 * procfs.c (procfs_target::attach): Update.
285 * nto-procfs.c (nto_procfs_target::attach): Update.
286 (nto_procfs_target::create_inferior): Update.
287 * inf-ptrace.c (inf_ptrace_target::attach): Update.
288 * gnu-nat.c (gnu_nat_target::attach): Update.
289 (gnu_nat_target::detach): Update.
290 * darwin-nat.c (darwin_nat_target::attach): Update.
291 * corefile.c (get_exec_file): Constify result. Remove extraneous
292 return.
293 * bsd-kvm.c (bsd_kvm_target_open): Update.
294 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
295
c0c3707f
CB		 2962019-12-16 Christian Biesinger <cbiesinger@google.com>
297
298 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
299 (we no longer need to include time.h before pathmax.h)
300
d3ecddab
CB		 3012019-12-15 Christian Biesinger <cbiesinger@google.com>
302
303 * ada-exp.y (write_ambiguous_var): Update.
304 * coffread.c (process_coff_symbol): Update.
305 * ctfread.c (ctf_add_enum_member_cb): Update.
306 (new_symbol): Update.
307 * dwarf2read.c (fixup_go_packaging): Update.
308 (new_symbol): Update.
309 * language.c (language_alloc_type_symbol): Update.
310 * mdebugread.c (new_symbol): Update.
311 * minsyms.c (minimal_symbol_reader::record_full): Update.
312 * psymtab.c (add_psymbol_to_bcache): Update.
313 * stabsread.c (define_symbol): Update.
314 (read_enum_type): Update.
315 * symtab.c (symbol_set_language): Make this a member function...
316 (general_symbol_info::set_language): ... here.
317 * symtab.h (struct general_symbol_info) <set_language>: New function.
318 (SYMBOL_SET_LANGUAGE): Remove.
319 (symbol_set_language): Remove.
320
c1b5c1eb
CB		 3212019-12-15 Christian Biesinger <cbiesinger@google.com>
322
323 * ada-lang.c (ada_add_block_symbols): Update.
324 (ada_collect_symbol_completion_matches): Update.
325 * ax-gdb.c (gen_expr): Update.
326 * block.c (block_lookup_symbol): Update.
327 (block_lookup_symbol_primary): Update.
328 (block_find_symbol): Update.
329 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
330 * dbxread.c (process_one_symbol): Update.
331 * dictionary.c (insert_symbol_hashed): Update.
332 (collate_pending_symbols_by_language): Update.
333 (mdict_add_symbol): Update.
334 * dwarf-index-write.c (write_psymbols): Update.
335 * dwarf2read.c (fixup_go_packaging): Update.
336 * findvar.c (read_var_value): Update.
337 * ft32-tdep.c (ft32_skip_prologue): Update.
338 * go-lang.c (go_symbol_package_name): Update.
339 * language.h (scoped_switch_to_sym_language_if_auto::
340 scoped_switch_to_sym_language_if_auto): Update.
341 * linespec.c (find_method): Update.
342 (find_label_symbols_in_block): Update.
343 * mdebugread.c (parse_symbol): Update.
344 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
345 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
346 (minimal_symbol_reader::install): Update.
347 * moxie-tdep.c (moxie_skip_prologue): Update.
348 * parse.c (parse_exp_in_context): Update.
349 * psymtab.c (psymbol_name_matches): Update.
350 (match_partial_symbol): Update.
351 (lookup_partial_symbol): Update.
352 (psymbol_hash): Update.
353 (psymbol_compare): Update.
354 * python/py-framefilter.c (extract_sym): Update.
355 (py_print_single_arg): Update.
356 * stabsread.c (define_symbol): Update.
357 * stack.c (print_frame_arg): Update.
358 (find_frame_funname): Update.
359 (info_frame_command_core): Update.
360 * symfile.c (set_initial_language): Update.
361 * symtab.c (symbol_set_demangled_name): Update.
362 (symbol_get_demangled_name): Update.
363 (symbol_set_language): Update.
364 (symbol_find_demangled_name): Update.
365 (symbol_set_names): Update.
366 (general_symbol_info::natural_name): Update.
367 (general_symbol_info::demangled_name): Update.
368 (general_symbol_info::search_name): Update.
369 (symbol_matches_search_name): Update.
370 (eq_symbol_entry): Update.
371 (iterate_over_symbols): Update.
372 (completion_list_add_symbol): Update.
373 (completion_list_add_msymbol): Update.
374 (completion_list_add_fields): Update.
375 * symtab.h (struct general_symbol_info) <language>: New function.
376 <language>: Rename to...
377 <m_language>: ...this.
378 (SYMBOL_LANGUAGE): Remove.
379 (MSYMBOL_LANGUAGE): Remove.
380 (struct symbol) <ctor>: Update.
381 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
382
747cfc8c
CB		 3832019-12-15 Christian Biesinger <cbiesinger@google.com>
384
385 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
386 set the language of sym.
387 * language.c (language_alloc_type_symbol): Likewise.
388
ff8577f6
SDJ		 3892019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
390
391 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
392 PR gdb/23613
393 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
394 * corelow.c: Include 'gdbsupport/pathstuff.h'.
395 (core_target_open): Use 'gdb_abspath'.
396 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
397 'current_directory == NULL' case.
398 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
399 explain what happens when 'current_directory' is NULL.
400 * go32-nat.c (go32_nat_target::wait): Check if
401 'current_directory' is NULL before call to 'chdir'.
402 * source.c (add_path): Use 'gdb_abspath'.
403 * top.c: Include 'gdbsupport/pathstuff.h'.
404 (init_history): Use 'gdb_abspath'.
405 (set_history_filename): Likewise.
406 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
407 (tfile_target_open): Use 'gdb_abspath'.
408
234c3068
TT		 4092019-12-13 Tom Tromey <tromey@adacore.com>
410
411 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
412 warning or error.
413
93537683
TT		 4142019-12-13 Tom Tromey <tromey@adacore.com>
415
416 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
417
63456183
TT		 4182019-12-13 Tom Tromey <tromey@adacore.com>
419
420 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
421
98f9338a
TT		 4222019-12-13 Tom Tromey <tromey@adacore.com>
423
424 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
425
3cb5a3a1
TT		 4262019-12-13 Tom Tromey <tromey@adacore.com>
427
428 * gdbsupport/common-utils.c (string_printf, string_vprintf)
429 (string_vappendf): Add ARI comment.
430
c6cbf900
TT		 4312019-12-13 Tom Tromey <tromey@adacore.com>
432
433 * contrib/ari/gdb_ari.sh: Remove "fix" call for
434 floatformat_to_double.
435 * target-float.c (host_float_ops<T>::from_target): Add ARI
436 comment.
437
036003a6
TT		 4382019-12-13 Tom Tromey <tromey@adacore.com>
439
440 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
441 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
442 ARI marker to abort.
443 * event-top.c (handle_sigsegv): Add ARI marker to abort.
444
8aaaf757
TT		 4452019-12-13 Tom Tromey <tromey@adacore.com>
446
447 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
448
fe56157f
TT		 4492019-12-13 Tom Tromey <tromey@adacore.com>
450
451 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
452
a15a95ed
TT		 4532019-12-13 Tom Tromey <tromey@adacore.com>
454
455 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
456 checks.
457
a5513db2
TT		 4582019-12-13 Tom Tromey <tromey@adacore.com>
459
460 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
461 end>: No longer "const".
462
3a90f266
SM		 4632019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
464
465 * jit.c: Fix indentation, replace spaces with tabs where
466 applicable.
467
b3f4b80f
JL		 4682019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
469
470 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
471
e671856c
TT		 4722019-12-12 Tom Tromey <tom@tromey.com>
473
474 * objfiles.h (struct objfile) <partial_symtabs>: Now a
475 unique_ptr.
476
7d7167ce
TT		 4772019-12-12 Tom Tromey <tom@tromey.com>
478
479 * progspace.h (objfile_list): New typedef.
480 (class unwrapping_objfile_iterator)
481 (struct unwrapping_objfile_range): Newl
482 (struct program_space) <objfiles_range>: Change type.
483 <objfiles>: Change return type.
484 <add_objfile>: Change type of "objfile" parameter.
485 <objfiles_list>: Now a list of shared_ptr.
486 * progspace.c (program_space::add_objfile): Change type of
487 "objfile". Update.
488 (program_space::remove_objfile): Update.
489 * objfiles.h (struct objfile) <~objfile>: Make public.
490 * objfiles.c (objfile::make): Update.
491 (objfile::unlink): Don't call delete.
492
343cc952
TT		 4932019-12-12 Tom Tromey <tom@tromey.com>
494
495 * symfile.c (symbol_file_clear): Update.
496 * progspace.h (struct program_space) <free_all_objfiles>: Declare
497 method.
498 * progspace.c (program_space::free_all_objfiles): New method.
499 * objfiles.h (free_all_objfiles): Don't declare.
500 * objfiles.c (free_all_objfiles): Move to program_space.
501
d0801dd8
TT		 5022019-12-12 Tom Tromey <tom@tromey.com>
503
504 * progspace.c (program_space::add_objfile)
505 (program_space::remove_objfile): Update.
506 (program_space::multi_objfile_p): Remove.
507 * objfiles.h (struct objfile) <next>: Remove.
508 * objfiles.c (objfile::objfile): Update.
509 (put_objfile_before): Update.
510 (unlink_objfile): Update.
511 * progspace.h (object_files): Remove.
512 (struct program_space) <objfiles_head>: Remove.
513 <objfiles_list>: New member.
514 <objfiles_range, objfiles_safe_range>: Change type.
515 (objfiles): Change return type.
516 (objfiles_safe): Update.
517 (multi_objfile_p): Rewrite and inline.
518 (object_files): Remove macro.
519
13bff726
TT		 5202019-12-12 Tom Tromey <tom@tromey.com>
521
522 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
523 second constructor.
524 (basic_safe_range): New class.
525
deeafabb
TT		 5262019-12-12 Tom Tromey <tom@tromey.com>
527
528 * progspace.c (program_space::multi_objfile_p): New method.
529 * printcmd.c (info_symbol_command): Update.
530 * maint.c (maintenance_translate_address): Update.
531 * objfiles.h (MULTI_OBJFILE_P): Remove.
532 * progspace.h (struct program_space) <multi_objfile_p>: New
533 method.
534
23452926
TT		 5352019-12-12 Tom Tromey <tom@tromey.com>
536
537 * progspace.h (struct program_space) <remove_objfile>: Declare.
538 * progspace.c (program_space::remove_objfile): New method.
539 * objfiles.c (unlink_objfile): Remove.
540 (objfile::unlink): Call remove_objfile.
541 (objfile): Don't call unlink_objfile.
542
7cac64af
TT		 5432019-12-12 Tom Tromey <tom@tromey.com>
544
545 * progspace.h (struct program_space) <add_objfile>: Declare
546 method.
547 * progspace.c (program_space::add_objfile): New method.
548 * objfiles.c (~objfile): Don't unlink objfile.
549 (put_objfile_before): Remove.
550 (add_separate_debug_objfile): Don't call put_objfile_before.
551 (objfile::make): Call add_objfile. Set new_objfiles_available on
552 the per-program-space data.
553
268e4f09
TT		 5542019-12-12 Tom Tromey <tom@tromey.com>
555
556 * symfile.c (syms_from_objfile_1): Use objfile_up.
557 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
558 method.
559 (reread_symbols): Use objfile_up.
560 * solib.c (update_solib_list, reload_shared_libraries_1): Call
561 unlink method.
562 * objfiles.h (struct objfile) <~objfile>: Now private.
563 <unlink>: New method.
564 (struct objfile_deleter): New.
565 (objfile_up): New typedef.
566 * objfiles.c (objfile::unlink): New method.
567 (free_objfile_separate_debug, free_all_objfiles)
568 (objfile_purge_solibs): Use it.
569 * jit.c (jit_unregister_code): Remove.
570 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
571 objfile.
572 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
573 objfile.
574 * compile/compile-object-load.c (compile_object_load): Use
575 objfile_up.
576
f65fe570
TT		 5772019-12-12 Tom Tromey <tom@tromey.com>
578
579 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
580 objfile::make.
581 * objfiles.h (struct objjfile) <make>: No longer inline.
582 (add_separate_debug_objfile): Don't declare.
583 * objfiles.c (add_separate_debug_objfile): Now static.
584 (objfile::make): Move from objfiles.h. Call
585 add_separate_debug_objfile. Add "parent" parameter.
586
bda13cdc
TT		 5872019-12-12 Tom Tromey <tom@tromey.com>
588
589 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
590 * objfiles.h (struct objfile): Make constructor private.
591 <make>: New static method.
592 * jit.c (jit_object_close_impl): Update.
593
7190276c
SM		 5942019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
595
596 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
597 gdb::byte_vector.
598
d61df897
TT		 5992019-12-12 Tom Tromey <tromey@adacore.com>
600
601 * xml-support.c (xml_fetch_content_from_file): Don't call
602 malloc_failure.
603 * utils.h (class gdb_argv): Remove malloc_failure comment.
604 * utils.c (gdb_argv::reset): Don't call malloc_failure.
605
db3ad2f0
TT		 6062019-12-12 Tom Tromey <tromey@adacore.com>
607
608 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
609 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
610 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
611 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
612 * riscv-ravenscar-thread.c: New file.
613 * riscv-ravenscar-thread.h: New file.
614 * riscv-tdep.c (riscv_gdbarch_init): Call
615 register_riscv_ravenscar_ops.
616
2ffe5b9c
TT		 6172019-12-12 Tom Tromey <tromey@adacore.com>
618
619 * gdbsupport/thread-pool.c (set_thread_name): Use
620 ATTRIBUTE_UNUSED.
621
39f34d7b
LM		 6222019-12-12 Luis Machado <luis.machado@linaro.org>
623
624 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
625 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
626 macros.
627
d4eeccfe
TT		 6282019-12-11 Tom Tromey <tom@tromey.com>
629
630 * tui/tui-win.c (tui_set_win_height_command): Call
631 tui_adjust_window_height.
632 (tui_adjust_win_heights, new_height_ok): Remove.
633 * tui/tui-layout.h (tui_adjust_window_height): Declare.
634 * tui/tui-layout.c (tui_adjust_window_height): New function.
635
3d979945
TT		 6362019-12-11 Tom Tromey <tom@tromey.com>
637
638 * tui/tui-win.c (tui_resize_all): Remove code, call
639 tui_apply_current_layout.
640
2192a9d3
TT		 6412019-12-11 Tom Tromey <tom@tromey.com>
642
643 * tui/tui-layout.h (tui_apply_current_layout): Declare.
644 * tui/tui-layout.c (standard_layouts, applied_layout): New
645 globals.
646 (tui_apply_current_layout): New function.
647 (show_layout): Set applied_layout. Call
648 tui_apply_current_layout.
649 (show_source_command, show_disasm_command)
650 (show_source_disasm_command, show_data)
651 (show_source_or_disasm_and_command): Remove.
652 (initialize_layouts): New function.
653 (_initialize_tui_layout): Call initialize_layouts.
654
389e7ddb
TT		 6552019-12-11 Tom Tromey <tom@tromey.com>
656
657 * tui/tui-layout.h (class tui_layout_base)
658 (class tui_layout_window, class tui_layout_split): New.
659 * tui/tui-layout.c (tui_get_window_by_name)
660 (tui_layout_window::clone, tui_layout_window::apply)
661 (tui_layout_window::get_sizes, tui_layout_window::add_split)
662 (tui_layout_split::add_window, tui_layout_split::clone)
663 (tui_layout_split::get_sizes)
664 (tui_layout_split::set_weights_from_heights)
665 (tui_layout_split::adjust_size, tui_layout_split::apply): New
666 functions.
667 (tui_layout_split::add_split, tui_layout_split::add_split)
668 (tui_layout_split::set_weights_from_heights)
669 (tui_layout_split::set_weights_from_heights): New functions.
670
fb3184d8
TT		 6712019-12-11 Tom Tromey <tom@tromey.com>
672
673 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
674 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
675 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
676 * tui/tui-data.h (struct tui_point): Remove.
677 (struct tui_gen_win_info) <origin>: Remove.
678 <x, y>: New fields.
679 * tui/tui-command.c (tui_cmd_window::resize): Update.
680
dc7ff8a6
TT		 6812019-12-11 Tom Tromey <tom@tromey.com>
682
683 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
684 Implement.
685 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
686 Implement.
687 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
688 method.
689 (struct tui_win_info) <min_height>: Implement.
690
1431937b
TT		 6912019-12-11 Tom Tromey <tom@tromey.com>
692
693 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
694 (struct tui_win_info) <can_box>: Update.
695
c8ec2f43
TT		 6962019-12-11 Tom Tromey <tom@tromey.com>
697
698 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
699 method.
700 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
701 method.
702 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
703 method.
704 (struct tui_win_info) <max_height>: Now override.
705
4decd62b
JB		 7062019-12-11 Joel Brobecker <brobecker@adacore.com>
707
708 * NEWS: Create a new section for the next release branch.
709 Rename the section of the current branch, now that it has
710 been cut.
711
d746744e
JB		 7122019-12-11 Joel Brobecker <brobecker@adacore.com>
713
714 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
715 * version.in: Bump version to 10.0.50.DATE-git.
716
2e744276
TT		 7172019-12-11 Tom Tromey <tromey@adacore.com>
718
719 PR build/25268:
720 * gdbsupport/thread-pool.c (set_thread_name): New function.
721 (thread_pool::set_thread_count): Don't call pthread_setname_np.
722 (thread_pool::thread_function): Call set_thread_name.
723
aac4760f
TT		 7242019-12-11 Tom Tromey <tromey@adacore.com>
725
726 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
727 bfd_get_signed_8.
728
d8edc8b7
PW		 7292019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
730
731 * NEWS: Document -raw-values option and the related setting commands.
732 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
733 only set it on when /r is given.
734 * valprint.c (value_print_option_defs): New element raw-values.
735 * Makefile.in: Add the new file.
736
cb511130
CB		 7372019-12-10 Christian Biesinger <cbiesinger@google.com>
738
739 * gdbsupport/safe-strerror.c: Supress the unused function warning
740 for select_strerror_r.
741
ab7d13f0
CB		 7422019-12-10 Christian Biesinger <cbiesinger@google.com>
743
744 * config.in: Regenerate.
745 * configure: Regenerate.
746 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
747 safe_strerror instead of strerror.
748 * gdbsupport/common.m4: Don't check for strerror.
749 * gdbsupport/safe-strerror.c: Support both the glibc version
750 of strerror_r and the XSI version.
751
6c71eb7d
TT		 7522019-12-10 Tom Tromey <tromey@adacore.com>
753
754 * ada-typeprint.c (print_choices): Use a single "?".
755 (print_variant_part): Print "?" if the discriminant name
756 is not known.
757
bac7c5cf
GB		 7582019-12-10 George Barrett <bob@bob131.so>
759
760 Fix scripted probe breakpoints.
761 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
762 declaration forward.
763 (breakpoint_ops_for_event_location_type)
764 (breakpoint_ops_for_event_location): Add function definitions.
765 (break_command_1, trace_command): Use
766 breakpoint_ops_for_event_location.
767 * breakpoint.h (breakpoint_ops_for_event_location): Add function
768 declarations.
769 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
770 breakpoint_ops_for_event_location.
771 * python/py-breakpoint.c (bppy_init): Use
772 breakpoint_ops_for_event_location.
773
330f1d38
TBA		 7742019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
775
776 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
777 when ranking an lvalue argument for an rvalue parameter.
778
b1f0c0b9
WA		 7792019-12-08 Wataru Ashihara <wataash@wataash.com>
780
781 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
782 template argument for scoped_restore_tmpl from bool to int.
783
aa2d5a42
KS		 7842019-12-07 Keith Seitz <keiths@redhat.com>
785
786 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
787 (build_id_to_debug_bfd): Make static, rewriting to use
788 build_id_to_bfd_suffix.
789 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
790 adding `suffix' parameter. Append SUFFIX to file names
791 when searching for matching files.
792 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
793 (build_id_to_exec_bfd): Likewise.
794 * build-id.h (build_id_to_debug_bfd): Clarify that function
795 searches for BFD of debug info file.
796 (build_id_to_exec_bfd): Declare.
797 * corelow.c: Include build-id.h.
798 (locate_exec_from_corefile_build_id): New function.
799 (core_target_open): If no executable BFD is found,
800 search for a core file BFD using build-id.
801
dfb65191
CB		 8022019-12-06 Christian Biesinger <cbiesinger@google.com>
803
804 * bcache.c: Put in namespace gdb.
805 * bcache.h: Likewise.
806 * gdbtypes.c (check_types_worklist): Update.
807 (types_deeply_equal): Update.
808 * macrotab.c (struct macro_table) <bcache>: Update.
809 (new_macro_table): Update.
810 * macrotab.h (struct bcache): Put this forward declaration
811 inside namespace gdb.
812 (new_macro_table): Update.
813 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
814 Update.
815 <macro_cache>: Update.
816 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
817
93e55f0a
TV		 8182019-12-06 Tom de Vries <tdevries@suse.de>
819
820 PR symtab/24971
821 * block.c (best_symbol, better_symbol): New function.
822 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
823 decl.
824
06acc08f
TBA		 8252019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
826
827 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
828 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
829 for ranking see-through reference cases.
830
e0fad1ea
PW		 8312019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
832 * stack.c (faas_command): Check a command is provided.
833 * thread.c (taas_command, tfaas_command): Likewise.
834
908641f5
PW		 8352019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
836 * inferior.c (prune_inferiors): Only call delete_inferior,
837 Do not modify the inferior list.
838
b858499d
SM		 8392019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
840
841 * c-exp.y: Update calls to lookup_typename,
842 lookup_signed_typename and lookup_unsigned_typename.
843 * c-lang.c (evaluate_subexp_c): Likewise.
844 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
845 Likewise.
846 * eval.c (binop_promote): Likewise.
847 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
848 (lookup_unsigned_typename): Likewise.
849 (lookup_signed_typename): Likewise.
850 * gdbtypes.h (lookup_unsigned_typename): Likewise.
851 (lookup_signed_typename): Likewise.
852 (lookup_typename): Likewise.
853 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
854 lookup_typename, lookup_signed_typename,
855 lookup_unsigned_typename.
856 * m2-exp.y: Likewise.
857 * printcmd.c (printf_wide_c_string): Likewise.
858 (ui_printf): Likewise.
859 * python/py-type.c (typy_lookup_typename): Likewise.
860 * python/py-xmethods.c (python_xmethod_worker::invoke):
861 Likewise.
862 * rust-exp.y: Likewise.
863
3a8fa228
CB		 8642019-12-04 Christian Biesinger <cbiesinger@google.com>
865
866 * configure.nat (obsd64): Add missing files x86-nat.o and
867 nat/x86-dregs.o.
868
2dbc041e
TT		 8692019-12-04 Tom Tromey <tom@tromey.com>
870
871 * valprint.c (val_print_string): Use metadata_style.
872 * go-valprint.c (print_go_string): Use metadata style.
873 * p-valprint.c (pascal_object_print_static_field): Use metadata
874 style.
875 * cp-valprint.c (cp_print_static_field): Use metadata style.
876
36c8fb93
AB		 8772019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
878 Chris January <chris.january@arm.com>
879
880 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
881 tokens.
882 (typebase): New patterns for complex, single/double precision, and
883 single/double complex.
884 (f77_keywords): Change token for complex keyword, and add single,
885 double, and precision keywords.
886
c6170c2c
SM		 8872019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
888
889 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
890 "info io_registers".
891
894ecaf4
SM		 8922019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
893
894 * regcache.c (cooked_read_test): Initialize thread list of
895 mock_inferior.
896
be155ebb
SM		 8972019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
898
899 * aarch64-linux-tdep.c: Remove includes.
900
c577cdd7
SM		 9012019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
902
903 * aarch64-tdep.c: Remove includes.
904
610cfd61
SM		 9052019-12-04 Simon Marchi <simon.marchi@efficios.com>
906
907 * filtered-iterator.h (filtered_iterator) <operator==,
908 operator!=>: Compare wrapped iterators, not wrapped pointers.
909 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
910 unittests/filtered_iterator-selftests.c.
911 * unittests/filtered_iterator-selftests.c: New file.
912
a05cf17a
TT		 9132019-12-04 Tom Tromey <tromey@adacore.com>
914
915 * gdbtypes.c (create_range_type): Inherit endianity
916 from base type.
917
d5a22e77
TT		 9182019-12-04 Tom Tromey <tromey@adacore.com>
919
920 * ada-lang.c (decode_constrained_packed_array)
921 (ada_value_assign, value_assign_to_component): Update.
922 * dwarf2loc.c (rw_pieced_value, access_memory)
923 (dwarf2_compile_expr_to_ax): Update.
924 * dwarf2read.c (dwarf2_add_field): Update.
925 * eval.c (evaluate_subexp_standard): Update.
926 * gdbarch.c, gdbarch.h: Rebuild.
927 * gdbarch.sh (bits_big_endian): Remove.
928 * gdbtypes.h (union field_location): Update comment.
929 * target-descriptions.c (make_gdb_type): Update.
930 * valarith.c (value_bit_index): Update.
931 * value.c (struct value) <bitpos>: Update comment.
932 (unpack_bits_as_long, modify_field): Update.
933 * value.h (value_bitpos): Update comment.
934
7ab4a236
TT		 9352019-12-04 Tom Tromey <tromey@adacore.com>
936
937 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
938 endian-ness.
939
103a685e
TT		 9402019-12-04 Tom Tromey <tromey@adacore.com>
941
942 * dwarf2read.c (dwarf2_init_float_type)
943 (dwarf2_init_complex_target_type): Add byte_order parameter.
944 (read_base_type): Compute byte order earlier.
945 * gdbtypes.c (init_float_type): Add byte_order parameter.
946 * gdbtypes.h (init_float_type): Add byte_order parameter.
947
7a9e9f9f
TT		 9482019-12-04 Tom Tromey <tromey@adacore.com>
949
950 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
951
feee869b
TT		 9522019-12-04 Tom Tromey <tromey@adacore.com>
953
954 * dwarf2read.c (process_structure_scope): Initialize
955 "discr_offset".
956
c2512106
AB		 9572019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
958
959 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
960 add it into the search spec.
961 (parse_max_results_option): New function.
962 (mi_info_functions_or_variables): Parse -max-results flag and pass
963 it to mi_symbol_info.
964 (mi_cmd_symbol_info_modules): Likewise.
965 (mi_cmd_symbol_info_types): Likewise.
966 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
967 return type to bool, change result container into a set, and don't
968 add new results if we have enough already.
969 (global_symbol_searcher::add_matching_msymbols): Change return
970 type to bool, and don't add new results if we have enough already.
971 (sort_search_symbols_remove_dups): Delete.
972 (global_symbol_searcher::search): Early exit from search loop when
973 we have enough results. Use a std::set to collect the results
974 from calling add_matching_symbols.
975 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
976 member function.
977 (global_symbol_searcher) <m_max_search_results>: New member
978 variable.
979 (global_symbol_searcher) <add_matching_symbols>: Update header
980 comment and change return type to bool.
981 (global_symbol_searcher) <add_matching_msymbols>: Update header
982 comment and change return type to bool.
983
f97a63c5
AB		 9842019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
985
986 * symtab.c (symbol_search::compare_search_syms): Update header
987 comment.
988 (global_symbol_searcher::is_suitable_msymbol): New function.
989 (global_symbol_searcher::expand_symtabs): New function.
990 (global_symbol_searcher::add_matching_symbols): New function.
991 (global_symbol_searcher::add_matching_msymbols): New function.
992 (global_symbol_searcher::search): Move most of the content
993 into the new functions above, and call them as needed.
994 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
995 function.
996 (global_symbol_searcher) <add_matching_symbols>: New member
997 function.
998 (global_symbol_searcher) <add_matching_msymbols>: New member
999 function.
1000 (global_symbol_searcher) <is_suitable_msymbol>: New member
1001 function.
1002
293b38d6
AB		 10032019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1004
1005 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1006 -symbol-info-module-variables entries.
1007 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1008 (mi_cmd_symbol_info_module_variables): Declare.
1009 * mi/mi-symbol-cmds.c
1010 (module_symbol_search_iterator): New typedef.
1011 (output_module_symbols_in_single_module_and_file): New function.
1012 (output_module_symbols_in_single_module): New function.
1013 (mi_info_module_functions_or_variables): New function.
1014 (mi_cmd_symbol_info_module_functions): New function.
1015 (mi_cmd_symbol_info_module_variables): New function.
1016 * NEWS: Mention new MI command.
1017
4cbd39b2
CB		 10182019-12-03 Christian Biesinger <cbiesinger@google.com>
1019
1020 * bcache.c (hash): Remove.
1021 (hash_continue): Remove.
1022 * bcache.h (hash): Remove.
1023 (hash_continue): Remove.
1024 (struct bcache) <ctor>: Update.
1025 * psymtab.c (psymbol_hash): Update.
1026 * stabsread.c (hashname): Update.
1027 * utils.h (fast_hash): Add an argument for a start value,
1028 defaulting to zero.
1029
82f910ea
PW		 10302019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1031 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1032 (destroy_block_symbol_cache): New function.
1033 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1034 (resize_symbol_cache): Likewise.
1035
de2396d0
TT		 10362019-12-02 Tom Tromey <tom@tromey.com>
1037
1038 * unittests/tui-selftests.c (run_tests): Make conditional.
1039 (_initialize_tui_selftest): Make conditional.
1040
638d85bc
CB		 10412019-12-02 Christian Biesinger <cbiesinger@google.com>
1042
1043 * aix-thread.c (debug_aix_thread): Change type to bool.
1044
7532a164
LM		 10452019-12-02 Luis Machado <luis.machado@linaro.org>
1046
1047 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1048
216a7e6b
AB		 10492019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1050
1051 * dwarf2read.c (read_tag_string_type): Read the fields required to
1052 make a dynamic string, and possibly create a dynamic range for the
1053 string.
1054 (attr_to_dynamic_prop): Setup is_reference based on the type of
1055 attribute being processed.
1056 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1057 (resolve_dynamic_array): Rename to...
1058 (resolve_dynamic_array_or_string): ...this, update header comment,
1059 and accept TYPE_CODE_STRING.
1060 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1061
11a8b164
AB		 10622019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1063
1064 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1065 of its implementation from...
1066 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1067 the new function.
1068
5bbd8269
AB		 10692019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1070
1071 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1072 create a range with stride where appropriate.
1073 * f-valprint.c: Include 'gdbarch.h'.
1074 (f77_print_array_1): Take the stride into account when walking the
1075 array. Also convert the stride into addressable units.
1076 * gdbtypes.c (create_range_type): Initialise the stride to
1077 constant zero.
1078 (create_range_type_with_stride): New function, initialise the
1079 range as normal, and then setup the stride.
1080 (has_static_range): Include the stride here. Also change the
1081 return type to bool.
1082 (create_array_type_with_stride): Consider the range stride if the
1083 array isn't given its own stride.
1084 (resolve_dynamic_range): Resolve the stride if needed.
1085 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1086 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1087 (TYPE_BIT_STRIDE): Define.
1088 (TYPE_ARRAY_BIT_STRIDE): Define.
1089 (create_range_type_with_stride): Declare.
1090 * valarith.c (value_subscripted_rvalue): Take range stride into
1091 account when walking the array.
1092
82e3b564
TT		 10932019-12-01 Tom Tromey <tom@tromey.com>
1094
1095 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1096 specially.
1097
517d261d
TT		 10982019-12-01 Tom Tromey <tom@tromey.com>
1099
1100 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1101 \0.
1102 * unittests/tui-selftests.c: New file.
1103 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1104
484c9b64
TT		 11052019-12-01 Tom Tromey <tom@tromey.com>
1106
1107 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1108
a2a7af0c
TT		 11092019-12-01 Tom Tromey <tom@tromey.com>
1110
1111 * NEWS: Document new settings.
1112 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1113 * tui/tui-win.c (_initialize_tui_win): Add border style
1114 observers.
1115 * tui/tui-io.h (tui_apply_style): Declare.
1116 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1117 longer static.
1118 (apply_ansi_escape, tui_set_reverse_mode): Update.
1119 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1120 Add "skip_intensity" parameter.
1121 <changed>: New member.
1122 <do_set_value>: Declare.
1123 (tui_border_style, tui_active_border_style): Declare.
1124 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1125 globals.
1126 (cli_style_option): Initialize "changed".
1127 (cli_style_option::do_set_value): New function.
1128 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1129 parameter. Update.
1130 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1131 (_initialize_cli_style): Update. Create TUI border style
1132 commands.
1133
d1da6b01
TT		 11342019-12-01 Tom Tromey <tom@tromey.com>
1135
1136 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1137 parameter.
1138 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1139 parameter.
1140 * tui/tui-win.h (compact_source): Declare.
1141 * tui/tui-win.c (compact_source): New global.
1142 (tui_set_compact_source, tui_show_compact_source): New functions.
1143 (_initialize_tui_win): Add "compact-source" setting.
1144 * tui/tui-source.c (tui_source_window::set_contents): Handle
1145 compact_source setting.
1146 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1147 * NEWS: Document new setting.
1148
489dbda6
TT		 11492019-11-30 Tom Tromey <tom@tromey.com>
1150
1151 * dwarf2read.c (dwarf2_add_field): Include field offset when
1152 computing variant part length.
1153
bf498525
PW		 11542019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1155 * NEWS: Mention define-prefix. Tell that command names can now
1156 contain a . character.
1157
be09caf1
PW		 11582019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1159
1160 * command.h (valid_cmd_char_p): Declare.
1161 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1162 the check of valid command char.
1163 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1164 valid_cmd_char_p.
1165 * cli/cli-script.c (validate_comname): Likewise.
1166 * completer.c (gdb_completer_command_word_break_characters):
1167 Do not remove . from the word break char, update comments.
1168 (complete_line_internal_1): Use valid_cmd_char_p.
1169 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1170 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1171
c6ac7fc9
PW		 11722019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1173
1174 * cli/cli-script.c (do_define_command): Ensure a redefined
1175 prefix command is kept as a prefix command.
1176 (define_prefix_command): New function.
1177 (show_user_1): Report user defined prefixes.
1178 (_initialize_cli_script): Create the new 'define-prefix' command.
1179 Add completers for 'define' and 'document'.
1180 * top.c (execute_command): If command is a user-defined prefix only
1181 command, report the list of commands for this prefix command.
1182
a992a3b0
TBA		 11832019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1184
1185 * valops.c (find_oload_champ): Improve debug output.
1186
e9194a1a
TBA		 11872019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1188
1189 * valops.c (find_oload_champ): Print part of debug messages
1190 before the badness vector is std::move'd.
1191
53a008a6
TT		 11922019-11-28 Tom Tromey <tom@tromey.com>
1193
1194 * value.c (creal_internal_fn): Fix comment.
1195
bab05c83
TT		 11962019-11-28 Tom Tromey <tom@tromey.com>
1197
1198 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1199 flag_bound_evaluated>: Now unsigned.
1200
2522f049
TT		 12012019-11-28 Tom Tromey <tom@tromey.com>
1202
1203 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1204 declare.
1205
38b49e22
MS		 12062019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1207
1208 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1209 debug output.
1210 * jit.c (jit_unregister_code): Add debug print to match
1211 `jit_register_code`.
1212
35125921
CB		 12132019-11-27 Christian Biesinger <cbiesinger@google.com>
1214
1215 * NEWS: Mention the new multithreaded symbol loading.
1216
62e77f56
CB		 12172019-11-27 Christian Biesinger <cbiesinger@google.com>
1218
1219 * maint.c (n_worker_threads): Default to 0.
1220 (worker_threads_disabled): New function.
1221 * maint.h (worker_threads_disabled): New function.
1222 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1223 here if worker_threads_disabled () is true.
1224 (minimal_symbol_reader::install): Skip all threading if
1225 worker_threads_disabled () is true.
1226
f29d7f6b
CB		 12272019-11-27 Christian Biesinger <cbiesinger@google.com>
1228
1229 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1230 hash code if possible.
1231 (add_minsym_to_demangled_hash_table): Likewise.
1232 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1233 on the background thread.
1234 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1235 Add these fields.
1236
e76b2246
CB		 12372019-11-27 Christian Biesinger <cbiesinger@google.com>
1238
1239 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1240 of the mangled name on the background thread.
1241 * symtab.c (symbol_set_names): Allow passing in the hash of the
1242 linkage_name.
1243 * symtab.h (symbol_set_names): Likewise.
1244
8d9a2568
KB		 12452019-11-27 Kevin Buettner <kevinb@redhat.com>
1246
1247 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1248 physnames are computed for inherited DIEs.
1249
fad03f6e
TT		 12502019-11-27 Tom Tromey <tromey@adacore.com>
1251
1252 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1253 backslashes.
1254 * cp-support.c: Remove unnecessary backslashes.
1255
43678b0a
CB		 12562019-11-27 Christian Biesinger <cbiesinger@google.com>
1257
1258 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1259 with sym->set_linkage_name.
1260 * coffread.c (coff_read_enum_type): Likewise.
1261 * mdebugread.c (parse_symbol): Likewise.
1262 * stabsread.c (patch_block_stabs): Likewise.
1263 (define_symbol): Likewise.
1264 (read_enum_type): Likewise.
1265 (common_block_end): Likewise.
1266 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1267 function.
1268 (SYMBOL_SET_LINKAGE_NAME): Remove.
1269 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1270 with sym->set_linkage_name.
1271
db5960b4
AB		 12722019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1273
1274 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1275 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1276 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1277 * NEWS: Mention new MI command.
1278
7dc42066
AB		 12792019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1280
1281 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1282 '-symbol-info-types', and '-symbol-info-variables'.
1283 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1284 (mi_cmd_symbol_info_types): Declare.
1285 (mi_cmd_symbol_info_variables): Declare.
1286 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1287 (output_debug_symbol): New function.
1288 (output_nondebug_symbol): New function.
1289 (mi_symbol_info): New function.
1290 (mi_info_functions_or_variables): New function.
1291 (mi_cmd_symbol_info_functions): New function.
1292 (mi_cmd_symbol_info_types): New function.
1293 (mi_cmd_symbol_info_variables): New function.
1294 * NEWS: Mention new commands.
1295
5f512a7d
AB		 12962019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1297
1298 * symtab.c (symbol_to_info_string): New function, most content
1299 moved from print_symbol_info, but updated to return a std::string.
1300 (print_symbol_info): Update to use symbol_to_info_string and print
1301 returned string.
1302 * symtab.h (symbol_to_info_string): Declare new function.
1303
470c0b1c
AB		 13042019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1305
1306 * python/python.c (gdbpy_rbreak): Convert to using
1307 global_symbol_searcher.
1308 * symtab.c (file_matches): Convert return type to bool, change
1309 file list to std::vector, update header comment.
1310 (search_symbols): Rename to...
1311 (global_symbol_searcher::search): ...this and update now its
1312 a member function of global_symbol_searcher. Take account of the
1313 changes to file_matches.
1314 (symtab_symbol_info): Convert to using global_symbol_searcher.
1315 (rbreak_command): Likewise.
1316 (search_module_symbols): Likewise.
1317 * symtab.h (enum symbol_search): Update comment.
1318 (search_symbols): Remove declaration.
1319 (class global_symbol_searcher): New class.
1320
57357d9d
TT		 13212019-11-26 Tom Tromey <tromey@adacore.com>
1322
1323 * cp-support.c (_initialize_cp_support): Conditionally initialize
1324 gdb_demangle_attempt_core_dump.
1325
3ea16160
TT		 13262019-11-26 Tom Tromey <tom@tromey.com>
1327
1328 * python/py-function.c (fnpy_init): Update.
1329 * value.h (add_internal_function): Adjust declaration.
1330 * value.c (function_destroyer): Remove.
1331 (do_add_internal_function): Don't set destroyer or copy name.
1332 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1333 Set name_allocated.
1334 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1335 (cmdpy_init): Set name_allocated.
1336 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1337 member.
1338 (~cmd_list_element): Free "name" if needed.
1339
1a6d41c6
TT		 13402019-11-26 Tom Tromey <tom@tromey.com>
1341
1342 * value.h (add_internal_function): Add new overload. Move
1343 documentation from value.h.
1344 * value.c (do_add_internal_function): New function.
1345 (add_internal_function): Use it. Add new overload.
1346 (function_destroyer): Don't free doc.
1347 * python/py-function.c (fnpy_init): Update.
1348
8318f3c3
TT		 13492019-11-26 Tom Tromey <tom@tromey.com>
1350
1351 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1352 (cmdpy_init): Set "doc_allocated".
1353
4da8c3a8
TT		 13542019-11-26 Tom Tromey <tom@tromey.com>
1355
1356 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1357 name of worker thread.
1358 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1359 pthread_setname_np.
1360 * configure, config.in: Rebuild.
1361
971db5e2
TT		 13622019-11-26 Tom Tromey <tom@tromey.com>
1363
1364 * python/python.c (class gdbpy_gil): New.
1365 (struct gdbpy_event): Add constructor, destructor, operator().
1366 (gdbpy_post_event): Use run_on_main_thread.
1367 (gdbpy_initialize_events): Remove.
1368 (do_start_initialization): Update.
1369
22138db6
TT		 13702019-11-26 Tom Tromey <tom@tromey.com>
1371
1372 * NEWS: Add entry.
1373 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1374 commands. Call update_thread_pool_size.
1375 (update_thread_pool_size, maintenance_set_worker_threads): New
1376 functions.
1377 (n_worker_threads): New global.
1378
d55c9a68
TT		 13792019-11-26 Christian Biesinger <cbiesinger@google.com>
1380 Tom Tromey <tom@tromey.com>
1381
1382 * minsyms.c (minimal_symbol_reader::install): Use
1383 parallel_for_each.
1384 * gdbsupport/parallel-for.h: New file.
1385 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1386
a0b57563
CB		 13872019-11-26 Christian Biesinger <cbiesinger@google.com>
1388 Tom Tromey <tom@tromey.com>
1389
1390 * gdbsupport/thread-pool.h: New file.
1391 * gdbsupport/thread-pool.c: New file.
1392 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1393 (HFILES_NO_SRCDIR): Add thread-pool.h.
1394
3b3978bc
TT		 13952019-11-26 Tom Tromey <tom@tromey.com>
1396
1397 * event-top.h (thread_local_segv_handler): Declare.
1398 * event-top.c (thread_local_segv_handler): New global.
1399 (install_handle_sigsegv, handle_sigsegv): New functions.
1400 (async_init_signals): Install SIGSEGV handler.
1401 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1402 thread-local.
1403 (report_failed_demangle): New function.
1404 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1405 handler-setting code, instead use segv_handler. Run warning code
1406 on main thread.
1407
9411c49e
TT		 14082019-11-26 Tom Tromey <tom@tromey.com>
1409
1410 * run-on-main-thread.c: New file.
1411 * run-on-main-thread.h: New file.
1412 * unittests/main-thread-selftests.c: New file.
1413 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1414 main-thread-selftests.c.
1415 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1416 (COMMON_SFILES): Add run-on-main-thread.c.
1417
c3efb965
TT		 14182019-11-26 Tom Tromey <tom@tromey.com>
1419
1420 * main.c (setup_alternate_signal_stack): Remove.
1421 (captured_main_1): Use gdb::alternate_signal_stack.
1422 * gdbsupport/alt-stack.h: New file.
1423
21987b9c
TT		 14242019-11-26 Tom Tromey <tom@tromey.com>
1425
1426 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1427 Remove comment.
1428 (save_original_signals_state, restore_original_signals_state): Use
1429 gdb_sigmask.
1430 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1431 (_initialize_linux_nat): Use gdb_sigmask.
1432 * guile/guile.c (_initialize_guile): Use block_signals.
1433 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1434 * gdbsupport/gdb-sigmask.h: New file.
1435 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1436 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1437 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1438 pthread_sigmask.
1439 * configure, config.in: Rebuild.
1440 * gdbsupport/block-signals.h: New file.
1441
5e030278
TT		 14422019-11-26 Tom Tromey <tom@tromey.com>
1443
1444 * acinclude.m4: Include ax_pthread.m4.
1445 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1446 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1447 (CLIBS): Use PTHREAD_LIBS.
1448 (aclocal_m4_deps): Add ax_pthread.m4.
1449 * config.in, configure: Rebuild.
1450 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1451
5a79c107
TT		 14522019-11-26 Tom Tromey <tom@tromey.com>
1453
1454 * symtab.h (struct minimal_symbol) <name_set>: New member.
1455 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1456 Don't call symbol_set_names.
1457 (minimal_symbol_reader::install): Call symbol_set_names.
1458
aa369509
PW		 14592019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1460
1461 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1462 restore_active_ext_lang, as GIL is needed for (indirectly)
1463 called PyOS_InterruptOccurred.
1464
cadc9cb8
SM		 14652019-11-26 Simon Marchi <simon.marchi@efficios.com>
1466
1467 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1468 definition.
1469
d04afd58
SM		 14702019-11-26 Simon Marchi <simon.marchi@efficios.com>
1471
1472 * remote-sim.c (simulator_command): Make static, remove
1473 declaration.
1474
dd694d77
SM		 14752019-11-26 Simon Marchi <simon.marchi@efficios.com>
1476
1477 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1478 static.
1479 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1480 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1481 (main): Likewise.
1482 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1483 (main): Likewise.
1484 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1485 (main): Likewise.
1486 * unittests/basic_string_view/element_access/char/1.cc (test01):
1487 Likewise.
1488 (main): Likewise.
1489 * unittests/basic_string_view/element_access/char/empty.cc (main):
1490 Likewise.
1491 * unittests/basic_string_view/element_access/char/front_back.cc
1492 (test01): Likewise.
1493 (main): Likewise.
1494 * unittests/basic_string_view/inserters/char/2.cc (test05):
1495 Likewise.
1496 (main): Likewise.
1497 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1498 (test01): Likewise.
1499 (main): Likewise.
1500 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1501 (test01): Likewise.
1502 (main): Likewise.
1503 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1504 Likewise.
1505 * unittests/basic_string_view/operations/compare/char/1.cc
1506 (test01): Likewise.
1507 (main): Likewise.
1508 * unittests/basic_string_view/operations/compare/char/13650.cc
1509 (test01): Likewise.
1510 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1511 Likewise.
1512 (main): Likewise.
1513 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1514 Likewise.
1515 (main): Likewise.
1516 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1517 Likewise.
1518 (main): Likewise.
1519 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1520 Likewise.
1521 (main): Likewise.
1522 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1523 Likewise.
1524 (main): Likewise.
1525 * unittests/basic_string_view/operations/find/char/4.cc (main):
1526 Likewise.
1527 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1528 Likewise.
1529 (main): Likewise.
1530 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1531 Likewise.
1532 (main): Likewise.
1533 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1534 Likewise.
1535 (main): Likewise.
1536 * unittests/basic_string_view/operations/substr/char/1.cc
1537 (test01): Likewise.
1538 (main): Likewise.
1539 * unittests/basic_string_view/operators/char/2.cc (main):
1540 Likewise.
1541 * unittests/optional/assignment/1.cc (test): Likewise.
1542 * unittests/optional/assignment/2.cc (test): Likewise.
1543 * unittests/optional/assignment/3.cc (test): Likewise.
1544 * unittests/optional/assignment/4.cc (test): Likewise.
1545 * unittests/optional/assignment/5.cc (test): Likewise.
1546 * unittests/optional/assignment/6.cc (test): Likewise.
1547 * unittests/optional/assignment/7.cc (test): Likewise.
1548 * unittests/optional/cons/copy.cc (test): Likewise.
1549 * unittests/optional/cons/default.cc (test): Likewise.
1550 * unittests/optional/cons/move.cc (test): Likewise.
1551 * unittests/optional/cons/value.cc (test): Likewise.
1552 * unittests/optional/in_place.cc (test): Likewise.
1553 * unittests/optional/observers/1.cc (test): Likewise.
1554 * unittests/optional/observers/2.cc (test): Likewise.
1555
3b5c1d49
SM		 15562019-11-26 Simon Marchi <simon.marchi@efficios.com>
1557
1558 * tui-win.h (tui_set_var_cmd): Remove.
1559 * tui-win.c (tui_set_var_cmd): Make static.
1560
adce99fe
SM		 15612019-11-26 Simon Marchi <simon.marchi@efficios.com>
1562
1563 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1564 rbreak_command_wrapper): Remove.
1565 * symtab.c (rbreak_command_wrapper): Remove.
1566
fe3adccf
SM		 15672019-11-26 Simon Marchi <simon.marchi@efficios.com>
1568
1569 * inferior.h (info_terminal_command): Remove declaration.
1570 * inflow.c (info_terminal_command): Make static.
1571
b926335f
SM		 15722019-11-26 Simon Marchi <simon.marchi@efficios.com>
1573
1574 * inferior.c (exit_inferior_silent): Remove.
1575
b62f6f54
SM		 15762019-11-26 Simon Marchi <simon.marchi@efficios.com>
1577
1578 * dictionary.c (dict_empty, mdict_empty): Remove.
1579 * dictionary.c (mdict_empty): Remove.
1580
cb8c24b6
SM		 15812019-11-26 Simon Marchi <simon.marchi@efficios.com>
1582
1583 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1584 (arc_insn_get_memory_offset): Likewise.
1585 (arc_insn_dump): Likewise.
1586 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1587 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1588 * dictionary.c (dict_iterator_next): Likewise.
1589 (dict_iter_match_first): Likewise.
1590 (dict_iter_match_next): Likewise.
1591 * f-lang.c (evaluate_subexp_f): Likewise.
1592 * hppa-tdep.c (hppa_read_pc): Likewise.
1593 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1594 * parse.c (write_exp_elt_msym): Likewise.
1595 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1596 * remote.c (remote_packet_size): Likewise.
1597 (remote_notif_stop_parse): Likewise.
1598 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1599 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1600 * source.c (prepare_path_for_appending): Likewise.
1601 * sparc64-linux-tdep.c
1602 (sparc64_linux_handle_segmentation_fault); Likewise.
1603 * stack.c (frame_selection_by_function_completer): Likewise.
1604
781597ff
SM		 16052019-11-26 Simon Marchi <simon.marchi@efficios.com>
1606
1607 * completer.c (set_gdb_completion_word_break_characters):
1608 Remove.
1609
23baa4cc
SM		 16102019-11-26 Simon Marchi <simon.marchi@efficios.com>
1611
1612 * dwarf-index-write.c: Include dwarf-index-write.h.
1613 * mi/mi-interp.c: Include mi/mi-interp.h.
1614
23767560
SM		 16152019-11-26 Simon Marchi <simon.marchi@efficios.com>
1616
1617 * aarch32-tdep.c: Include aarch32-tdep.h.
1618 * aarch32-tdep.h: Forward-declare struct target_desc.
1619
6d91ce9a
CB		 16202019-11-26 Christian Biesinger <cbiesinger@google.com>
1621
1622 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1623 strerror.
1624 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1625 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1626
3cf2f237
TV		 16272019-11-25 Tom de Vries <tdevries@suse.de>
1628
1629 * contrib/words.sh: Add -c option.
1630
5b89c67a
CB		 16312019-11-25 Christian Biesinger <cbiesinger@google.com>
1632
1633 * solib.c (solib_find_1): Change int to bool.
1634 (exec_file_find): Change int to bool.
1635 (solib_find): Change int to bool.
1636 (solib_read_symbols): Change int to bool.
1637 (solib_used): Change int to bool.
1638 (solib_add): Change int to bool.
1639 (info_sharedlibrary_command): Change int to bool.
1640 (solib_contains_address_p): Change int to bool.
1641 (solib_keep_data_in_core): Change int to bool.
1642 (in_solib_dynsym_resolve_code): Change int to bool.
1643 (reload_shared_libraries_1): Change int to bool.
1644 (gdb_sysroot_changed): Change int to bool.
1645 * solib.h (solib_read_symbols): Change int to bool.
1646 (solib_contains_address_p): Change int to bool.
1647 (solib_keep_data_in_core): Change int to bool.
1648 (in_solib_dynsym_resolve_code): Change int to bool.
1649 (libpthread_name_p): Change int to bool.
1650
6cc8564b
LM		 16512019-11-25 Luis Machado <luis.machado@linaro.org>
1652
1653 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1654 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1655 (remote_packet_max_chars): New static global.
1656 (show_remote_packet_max_chars): New function.
1657 (remote_target::putpkt_binary): Adjust to use new
1658 remote_packet_max_chars option.
1659 (remote_target::getpkt_or_notif_sane_1): Likewise.
1660 (_initialize_remote): Register new remote-packet-max-chars option.
1661
a7cdaa91
SM		 16622019-11-24 Simon Marchi <simon.marchi@efficios.com>
1663
1664 * m68k-linux-nat.c: Include gdbarch.h.
1665
26abc753
TT		 16662019-11-24 Tom Tromey <tom@tromey.com>
1667
1668 * symfile.c (read_symbols): Update.
1669 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1670 bool.
1671 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1672 (psym_lookup_symbol, psym_find_last_source_symtab)
1673 (psym_forget_cached_source_info, psym_print_stats)
1674 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1675 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1676 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1677 (psym_find_compunit_symtab_by_address)
1678 (maintenance_print_psymbols, maintenance_info_psymtabs)
1679 (maintenance_check_psymtabs): Update.
1680 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1681 bool.
1682
012fc909
TT		 16832019-11-22 Tom Tromey <tom@tromey.com>
1684
1685 * observable.h: Update comments.
1686
c83d8d32
TT		 16872019-11-22 Tom Tromey <tromey@adacore.com>
1688
1689 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1690 (print_ada_task_info): Don't try to fetch thread id if task is not
1691 alive.
1692
987012b8
CB		 16932019-11-22 Christian Biesinger <cbiesinger@google.com>
1694
1695 * ada-exp.y: Update.
1696 * ada-lang.c (sort_choices): Update.
1697 (ada_print_symbol_signature): Update.
1698 (resolve_subexp): Update.
1699 (ada_parse_renaming): Update.
1700 (ada_read_renaming_var_value): Update.
1701 (lesseq_defined_than): Update.
1702 (remove_extra_symbols): Update.
1703 (remove_irrelevant_renamings): Update.
1704 (ada_add_block_symbols): Update.
1705 (ada_collect_symbol_completion_matches): Update.
1706 (ada_is_renaming_symbol): Update.
1707 (aggregate_assign_from_choices): Update.
1708 (ada_evaluate_subexp): Update.
1709 (ada_has_this_exception_support): Update.
1710 (ada_is_non_standard_exception_sym): Update.
1711 (ada_add_exceptions_from_frame): Update.
1712 (ada_add_global_exceptions): Update.
1713 (ada_print_subexp): Update.
1714 * ax-gdb.c (gen_var_ref): Update.
1715 (gen_maybe_namespace_elt): Update.
1716 (gen_expr_for_cast): Update.
1717 (gen_expr): Update.
1718 * block.h: Update.
1719 * blockframe.c (find_pc_partial_function): Update.
1720 * breakpoint.c (print_breakpoint_location): Update.
1721 (update_static_tracepoint): Update.
1722 * btrace.c (ftrace_print_function_name): Update.
1723 (ftrace_function_switched): Update.
1724 * buildsym.c (find_symbol_in_list): Update.
1725 * c-exp.y: Update.
1726 * c-typeprint.c (c_print_typedef): Update.
1727 (c_type_print_template_args): Update.
1728 * cli/cli-cmds.c (edit_command): Update.
1729 (list_command): Update.
1730 (print_sal_location): Update.
1731 * coffread.c (patch_opaque_types): Update.
1732 (process_coff_symbol): Update.
1733 (coff_read_enum_type): Update.
1734 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1735 (convert_one_symbol): Update.
1736 (hash_symname): Update.
1737 (eq_symname): Update.
1738 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1739 * compile/compile-cplus-types.c (debug_print_scope): Update.
1740 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1741 * compile/compile-object-load.c (get_out_value_type): Update.
1742 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1743 (search_symbol_list): Update.
1744 (cp_lookup_symbol_imports_or_template): Update.
1745 * cp-support.c (overload_list_add_symbol): Update.
1746 * ctfread.c (psymtab_to_symtab): Update.
1747 * dbxread.c (cp_set_block_scope): Update.
1748 * dictionary.c (iter_match_first_hashed): Update.
1749 (iter_match_next_hashed): Update.
1750 (insert_symbol_hashed): Update.
1751 (iter_match_next_linear): Update.
1752 * dictionary.h: Update.
1753 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1754 (locexpr_describe_location_piece): Update.
1755 (locexpr_describe_location_1): Update.
1756 (locexpr_generate_c_location): Update.
1757 (loclist_describe_location): Update.
1758 (loclist_generate_c_location): Update.
1759 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1760 (read_func_scope): Update.
1761 (process_enumeration_scope): Update.
1762 (new_symbol): Update.
1763 (dwarf2_const_value): Update.
1764 (dwarf2_symbol_mark_computed): Update.
1765 * eval.c (evaluate_funcall): Update.
1766 (evaluate_subexp_standard): Update.
1767 * expprint.c (print_subexp_standard): Update.
1768 (dump_subexp_body_standard): Update.
1769 * f-valprint.c (info_common_command_for_block): Update.
1770 * findvar.c (get_hosting_frame): Update.
1771 (default_read_var_value): Update.
1772 * go-lang.c (go_symbol_package_name): Update.
1773 * guile/scm-block.c (bkscm_print_block_smob): Update.
1774 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1775 (gdbscm_symbol_name): Update.
1776 (gdbscm_symbol_linkage_name): Update.
1777 (gdbscm_symbol_print_name): Update.
1778 * infcall.c (get_function_name): Update.
1779 * infcmd.c (jump_command): Update.
1780 (finish_command): Update.
1781 * infrun.c (insert_exception_resume_breakpoint): Update.
1782 * linespec.c (canonicalize_linespec): Update.
1783 (create_sals_line_offset): Update.
1784 (convert_linespec_to_sals): Update.
1785 (complete_label): Update.
1786 (find_label_symbols_in_block): Update.
1787 * m2-typeprint.c (m2_print_typedef): Update.
1788 * mdebugread.c (mdebug_reg_to_regnum): Update.
1789 (parse_symbol): Update.
1790 (mylookup_symbol): Update.
1791 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1792 (list_args_or_locals): Update.
1793 * objc-lang.c (compare_selectors): Update.
1794 (info_selectors_command): Update.
1795 (compare_classes): Update.
1796 (info_classes_command): Update.
1797 (find_imps): Update.
1798 * p-typeprint.c (pascal_print_typedef): Update.
1799 * printcmd.c (build_address_symbolic): Update.
1800 (info_address_command): Update.
1801 (print_variable_and_value): Update.
1802 * python/py-framefilter.c (extract_sym): Update.
1803 (py_print_single_arg): Update.
1804 * python/py-symbol.c (sympy_str): Update.
1805 (sympy_get_name): Update.
1806 (sympy_get_linkage_name): Update.
1807 * python/python.c (gdbpy_rbreak): Update.
1808 * record-btrace.c (btrace_get_bfun_name): Update.
1809 (btrace_call_history): Update.
1810 * rust-lang.c (rust_print_typedef): Update.
1811 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1812 * stabsread.c (stab_reg_to_regnum): Update.
1813 (define_symbol): Update.
1814 (read_enum_type): Update.
1815 (common_block_end): Update.
1816 (cleanup_undefined_types_1): Update.
1817 (scan_file_globals): Update.
1818 * stack.c (print_frame_arg): Update.
1819 (print_frame_args): Update.
1820 (find_frame_funname): Update.
1821 (info_frame_command_core): Update.
1822 (iterate_over_block_locals): Update.
1823 (print_block_frame_labels): Update.
1824 (do_print_variable_and_value): Update.
1825 (iterate_over_block_arg_vars): Update.
1826 (return_command): Update.
1827 * symmisc.c (dump_symtab_1): Update.
1828 (print_symbol): Update.
1829 * symtab.c (eq_symbol_entry): Update.
1830 (symbol_cache_dump): Update.
1831 (lookup_language_this): Update.
1832 (find_pc_sect_line): Update.
1833 (skip_prologue_sal): Update.
1834 (symbol_search::compare_search_syms): Update.
1835 (treg_matches_sym_type_name): Update.
1836 (search_symbols): Update.
1837 (print_symbol_info): Update.
1838 (rbreak_command): Update.
1839 (completion_list_add_symbol): Update.
1840 (find_gnu_ifunc): Update.
1841 (get_symbol_address): Update.
1842 (search_module_symbols): Update.
1843 (info_module_subcommand): Update.
1844 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1845 (SYMBOL_LINKAGE_NAME): Remove.
1846 (SYMBOL_DEMANGLED_NAME): Remove.
1847 (SYMBOL_PRINT_NAME): Remove.
1848 (SYMBOL_SEARCH_NAME): Remove.
1849 * tracepoint.c (set_traceframe_context): Update.
1850 (validate_actionline): Update.
1851 (collection_list::collect_symbol): Update.
1852 (encode_actions_1): Update.
1853 (info_scope_command): Update.
1854 (print_one_static_tracepoint_marker): Update.
1855 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1856 * valops.c (address_of_variable): Update.
1857 (find_overload_match): Update.
1858 (find_oload_champ): Update.
1859
c9d95fa3
CB		 18602019-11-22 Christian Biesinger <cbiesinger@google.com>
1861
1862 * ada-lang.c (ada_lookup_simple_minsym): Update.
1863 (ada_collect_symbol_completion_matches): Update.
1864 * ada-tasks.c (read_atcb): Update.
1865 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1866 (amd64_windows_skip_trampoline_code): Update.
1867 * arm-tdep.c (skip_prologue_function): Update.
1868 (arm_skip_stack_protector): Update.
1869 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1870 (arm_wince_skip_main_prologue): Update.
1871 * ax-gdb.c (gen_expr): Update.
1872 * block.c (call_site_for_pc): Update.
1873 * blockframe.c (find_pc_partial_function): Update.
1874 * breakpoint.c (set_breakpoint_location_function): Update.
1875 * btrace.c (ftrace_print_function_name): Update.
1876 (ftrace_function_switched): Update.
1877 * c-valprint.c (print_unpacked_pointer): Update.
1878 * coffread.c (coff_symfile_read): Update.
1879 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1880 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1881 * dwarf-index-write.c (write_psymbols): Update.
1882 * dwarf2loc.c (call_site_to_target_addr): Update.
1883 (func_verify_no_selftailcall): Update.
1884 (tailcall_dump): Update.
1885 (call_site_find_chain_1): Update.
1886 (dwarf_expr_reg_to_entry_parameter): Update.
1887 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1888 * eval.c (evaluate_funcall): Update.
1889 (evaluate_subexp_standard): Update.
1890 (evaluate_subexp_for_sizeof): Update.
1891 * expprint.c (print_subexp_standard): Update.
1892 (dump_subexp_body_standard): Update.
1893 * frame.c (get_prev_frame_always_1): Update.
1894 * frv-tdep.c (frv_skip_main_prologue): Update.
1895 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1896 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1897 (gnuv3_get_typename_from_type_info): Update.
1898 (gnuv3_skip_trampoline): Update.
1899 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1900 * i386-tdep.c (i386_skip_main_prologue): Update.
1901 (i386_pe_skip_trampoline_code): Update.
1902 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1903 * infcall.c (get_function_name): Update.
1904 * linespec.c (minsym_found): Update.
1905 * linux-fork.c (info_checkpoints_command): Update.
1906 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1907 (m32c_m16c_pointer_to_address): Update.
1908 * maint.c (maintenance_translate_address): Update.
1909 * minsyms.c (add_minsym_to_hash_table): Update.
1910 (add_minsym_to_demangled_hash_table): Update.
1911 (lookup_minimal_symbol_mangled): Update.
1912 (lookup_minimal_symbol_demangled): Update.
1913 (lookup_minimal_symbol_linkage): Update.
1914 (lookup_minimal_symbol_text): Update.
1915 (lookup_minimal_symbol_by_pc_name): Update.
1916 (minimal_symbol_is_less_than): Update.
1917 (compact_minimal_symbols): Update.
1918 (build_minimal_symbol_hash_tables): Update.
1919 (find_solib_trampoline_target): Update.
1920 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1921 (mips_skip_pic_trampoline_code): Update.
1922 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1923 * objc-lang.c (info_selectors_command): Update.
1924 (info_classes_command): Update.
1925 (find_methods): Update.
1926 (find_imps): Update.
1927 * p-valprint.c (pascal_val_print): Update.
1928 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1929 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1930 * printcmd.c (build_address_symbolic): Update.
1931 (info_symbol_command): Update.
1932 * psymtab.c (psymbol_name_matches): Update.
1933 (match_partial_symbol): Update.
1934 (lookup_partial_symbol): Update.
1935 (print_partial_symbols): Update.
1936 (sort_pst_symbols): Update.
1937 (maintenance_check_psymtabs): Update.
1938 * python/py-framefilter.c (py_print_frame): Update.
1939 * python/python.c (gdbpy_rbreak): Update.
1940 * record-btrace.c (btrace_get_bfun_name): Update.
1941 (btrace_call_history): Update.
1942 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1943 (rs6000_skip_trampoline_code): Update.
1944 * sol-thread.c (info_cb): Update.
1945 * stabsread.c (scan_file_globals): Update.
1946 * stack.c (find_frame_funname): Update.
1947 (info_frame_command_core): Update.
1948 * symmisc.c (dump_msymbols): Update.
1949 * symtab.c (symbol_natural_name): Rename to..,
1950 (general_symbol_info::natural_name): ...this.
1951 (symbol_demangled_name): Rename to...
1952 (general_symbol_info::demangled_name): ...this.
1953 (symbol_search_name): Rename to...
1954 (general_symbol_info::search_name): ...this.
1955 (symbol_matches_search_name): Update.
1956 (find_pc_sect_line): Update.
1957 (skip_prologue_sal): Update.
1958 (search_symbols): Update.
1959 (print_msymbol_info): Update.
1960 (rbreak_command): Update.
1961 (completion_list_add_msymbol): Update.
1962 (completion_list_objc_symbol): Update.
1963 (get_msymbol_address): Update.
1964 * symtab.h (struct general_symbol_info): Add member functions
1965 natural_name (), linkage_name (), print_name (), demangled_name (),
1966 and search_name ().
1967 (SYMBOL_NATURAL_NAME): Update.
1968 (symbol_natural_name): Move to a member function on general_symbol_info.
1969 (SYMBOL_DEMANGLED_NAME): Update.
1970 (symbol_demangled_name): Move to a member function on
1971 general_symbol_info.
1972 (SYMBOL_SEARCH_NAME): Update.
1973 (symbol_search_name): Move to a member function on general_symbol_info.
1974 (MSYMBOL_NATURAL_NAME): Remove.
1975 (MSYMBOL_LINKAGE_NAME): Remove.
1976 (MSYMBOL_PRINT_NAME): Remove.
1977 (MSYMBOL_DEMANGLED_NAME): Remove.
1978 (MSYMBOL_SEARCH_NAME): Remove.
1979 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1980
f8bab2d6
CB		 19812019-11-22 Christian Biesinger <cbiesinger@google.com>
1982
1983 * symtab.c (create_demangled_names_hash): Use per_bfd->
1984 minimal_symbol_count for computing the initial size, if greater
1985 than our default size.
1986
85e7588d
TV		 19872019-11-22 Tom de Vries <tdevries@suse.de>
1988
1989 * contrib/words.sh: Improve words extraction.
1990
f6180073
TV		 19912019-11-22 Tom de Vries <tdevries@suse.de>
1992
1993 * contrib/words.sh: Combine sed invocations.
1994
f10ffa41
CB		 19952019-11-21 Christian Biesinger <cbiesinger@google.com>
1996
1997 * Makefile.in: Update.
1998 * demangle.c: Rename to...
1999 * gdb-demangle.c: ..this.
2000 (is_cplus_marker): Change return type to bool.
2001 (_initialize_demangler): Rename to...
2002 (_initialize_gdb_demangle): ...this.
2003 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2004 * symtab.h (demangle): Remove declaration; instead include
2005 gdb-demangle.h.
2006
6ba18521
TT		 20072019-11-21 Tom Tromey <tromey@adacore.com>
2008
2009 * gdbsupport/format.c (format_pieces): Parse %I64d.
2010 * unittests/format_pieces-selftests.c (test_windows_formats): New
2011 function.
2012 (run_tests): Call it.
2013
34877895
PJ		 20142019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2015
2016 Byte reverse display of variables with DW_END_big, DW_END_little
2017 (DW_AT_endianity) dwarf attributes if different than the native
2018 byte order.
2019 * ada-lang.c (ada_value_binop):
2020 Use type_byte_order instead of gdbarch_byte_order.
2021 * ada-valprint.c (printstr):
2022 (ada_val_print_string):
2023 * ada-lang.c (value_pointer):
2024 (ada_value_binop):
2025 Use type_byte_order instead of gdbarch_byte_order.
2026 * c-lang.c (c_get_string):
2027 Use type_byte_order instead of gdbarch_byte_order.
2028 * c-valprint.c (c_val_print_array):
2029 Use type_byte_order instead of gdbarch_byte_order.
2030 * cp-valprint.c (cp_print_class_member):
2031 Use type_byte_order instead of gdbarch_byte_order.
2032 * dwarf2loc.c (rw_pieced_value):
2033 Use type_byte_order instead of gdbarch_byte_order.
2034 * dwarf2read.c (read_base_type): Handle DW_END_big,
2035 DW_END_little
2036 * f-lang.c (f_get_encoding):
2037 Use type_byte_order instead of gdbarch_byte_order.
2038 * findvar.c (default_read_var_value):
2039 Use type_byte_order instead of gdbarch_byte_order.
2040 * gdbtypes.c (check_types_equal):
2041 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2042 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2043 and TYPE_ENDIANITY_LITTLE if set.
2044 (type_byte_order): new function.
2045 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2046 (struct main_type) <flag_endianity_not_default>:
2047 New field.
2048 (type_byte_order): New function.
2049 * infcmd.c (default_print_one_register_info):
2050 Use type_byte_order instead of gdbarch_byte_order.
2051 * p-lang.c (pascal_printstr):
2052 Use type_byte_order instead of gdbarch_byte_order.
2053 * p-valprint.c (pascal_val_print):
2054 Use type_byte_order instead of gdbarch_byte_order.
2055 * printcmd.c (print_scalar_formatted):
2056 Use type_byte_order instead of gdbarch_byte_order.
2057 * solib-darwin.c (darwin_current_sos):
2058 Use type_byte_order instead of gdbarch_byte_order.
2059 * solib-svr4.c (solib_svr4_r_ldsomap):
2060 Use type_byte_order instead of gdbarch_byte_order.
2061 * stap-probe.c (stap_modify_semaphore):
2062 Use type_byte_order instead of gdbarch_byte_order.
2063 * target-float.c (target_float_same_format_p):
2064 Use type_byte_order instead of gdbarch_byte_order.
2065 * valarith.c (scalar_binop):
2066 (value_bit_index):
2067 Use type_byte_order instead of gdbarch_byte_order.
2068 * valops.c (value_cast):
2069 Use type_byte_order instead of gdbarch_byte_order.
2070 * valprint.c (generic_emit_char):
2071 (generic_printstr):
2072 (val_print_string):
2073 Use type_byte_order instead of gdbarch_byte_order.
2074 * value.c (unpack_long):
2075 (unpack_bits_as_long):
2076 (unpack_value_bitfield):
2077 (modify_field):
2078 (pack_long):
2079 (pack_unsigned_long):
2080 Use type_byte_order instead of gdbarch_byte_order.
2081 * findvar.c (unsigned_pointer_to_address):
2082 (signed_pointer_to_address):
2083 (unsigned_address_to_pointer):
2084 (address_to_signed_pointer):
2085 (default_read_var_value):
2086 (default_value_from_register):
2087 Use type_byte_order instead of gdbarch_byte_order.
2088 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2089 Use type_byte_order instead of gdbarch_byte_order.
2090 * riscv-tdep.c (riscv_print_one_register_info):
2091 Use type_byte_order instead of gdbarch_byte_order.
2092
87fb00ea
SM		 20932019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2094
2095 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2096 (current_ui_gdb_stdin_ptr): Likewise.
2097 (current_ui_gdb_stderr_ptr): Likewise.
2098 (current_ui_gdb_stdlog_ptr): Likewise.
2099 (current_ui_current_uiout_ptr): Likewise.
2100 (gen_ret_current_ui_field_ptr): Remove.
2101
65d1cd5f
TV		 21022019-11-21 Tom de Vries <tdevries@suse.de>
2103
2104 PR gdb/24956
2105 * cli/cli-script.c (execute_control_command): Only switch to
2106 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2107
9f6ad286
TT		 21082019-11-19 Tom Tromey <tom@tromey.com>
2109
2110 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2111 Now static. Change type of "name".
2112 (tui_set_win_height_command): Don't copy "arg".
2113 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2114 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2115
435d3d88
AT		 21162019-11-19 Ali Tamur <tamur@google.com>
2117
2118 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2119 "if (attr != nullptr)".
2120 (dwarf2_find_base_address): Likewise.
2121 (dwarf2_build_include_psymtabs): Likewise.
2122 (read_cutu_die_from_dwo): Likewise.
2123 (read_func_scope): Likewise.
2124 (read_call_site_scope): Likewise.
2125 (dwarf2_get_pc_bounds): Likewise.
2126 (dwarf2_record_block_ranges): Likewise.
2127 (dwarf2_add_field): Likewise.
2128 (dwarf2_add_member_fn): Likewise.
2129 (read_structure_type): Likewise.
2130 (read_enumeration_type): Likewise.
2131 (read_array_type): Likewise.
2132 (read_array_order): Likewise.
2133 (read_set_type): Likewise.
2134 (read_common_block): Likewise.
2135 (read_tag_reference_type): Likewise.
2136 (read_tag_string_type): Likewise.
2137 (read_subroutine_type): Likewise.
2138 (read_base_type): Likewise.
2139 (read_subrange_type): Likewise.
2140 (new_symbol): Likewise.
2141 (prepare_one_comp_unit): Likewise.
2142
c9739b6a
TT		 21432019-11-19 Tom Tromey <tromey@adacore.com>
2144
2145 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2146 result in error when DebugActiveProcess fails.
2147
494409bb
SDJ		 21482019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2149 Pedro Alves <palves@redhat.com>
2150
2151 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2152 * target.c (target_stack::push): Call 'unpush' if there's a
2153 target on top of the stack.
2154
2e953aca
PW		 21552019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2156
2157 * python/py-block.c (blpy_dealloc): Call tp_free.
2158 (blpy_block_syms_dealloc): Likewise.
2159 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2160 * python/py-inferior.c (infpy_dealloc): Likewise.
2161 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2162 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2163 * python/py-symbol.c (sympy_dealloc): Likewise.
2164 * python/py-symtab.c (stpy_dealloc): Likewise.
2165 * python/py-type.c (typy_iterator_dealloc): Likewise.
2166
6edc43ec
CB		 21672019-11-18 Christian Biesinger <cbiesinger@google.com>
2168
2169 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2170 constructor instead of using a class initializer.
2171
cd850b40
CB		 21722019-11-15 Christian Biesinger <cbiesinger@google.com>
2173
2174 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2175 * configure: Regenerate.
2176 * configure.ac: Don't source common.host.
2177 * gdbsupport/common.host: Remove.
2178 * gdbsupport/mingw-strerror.c: Remove.
2179 * gdbsupport/posix-strerror.c: Rename to...
2180 * gdbsupport/safe-strerror.c: ...this.
2181
53fea9c7
CB		 21822019-11-15 Christian Biesinger <cbiesinger@google.com>
2183
2184 * maint.c (scoped_command_stats::print_time): Use localtime_r
2185 instead of localtime (provided through gnulib if necessary).
2186 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2187 of ctime.
2188
f8e27d88
CB		 21892019-11-15 Christian Biesinger <cbiesinger@google.com>
2190
2191 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2192 avoid compile errors.
2193
5abebf3c
CB		 21942019-11-15 Christian Biesinger <cbiesinger@google.com>
2195
2196 * config.in: Regenerate.
2197 * configure: Regenerate.
2198 * gdbsupport/common.m4: No longer check for strerror_r.
2199 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2200 POSIX version of strerror_r, now that gnulib provides it if
2201 necessary.
2202
9a351667
CB		 22032019-11-14 Christian Biesinger <cbiesinger@google.com>
2204
2205 * README (`configure' options): Update.
2206
55708e99
TT		 22072019-11-14 Tom Tromey <tromey@adacore.com>
2208
2209 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2210 expected type for the RHS if the LHS is a convenience variable.
2211
4b09bb2e
SM		 22122019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2213
2214 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2215 Provide explicit default and copy constructor.
2216
bd454f8b
PW		 22172019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2218
2219 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2220 only call Py_INCREF (newbp) in the bppy_pending_object case.
2221
d1aa3cf0
TT		 22222019-11-13 Tom Tromey <tromey@adacore.com>
2223
2224 PR build/25182:
2225 * psympriv.h (partial_symbol): Remove static assert.
2226 * symtab.h (general_symbol_info, symbol): Remove static assert.
2227
e06f3d6e
AB		 22282019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2229
2230 * gdbsupport/format.c (format_pieces::format_pieces): Support
2231 printf 'z' size modifier.
2232 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2233 * printcmd.c (ui_printf): Handle size_t_arg.
2234 * ui-out.c (ui_out::vmessage): Likewise.
2235 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2236 function.
2237 (run_tests): Call test_format_int_sizes.
2238
468c0cbb
CB		 22392019-11-12 Christian Biesinger <cbiesinger@google.com>
2240
2241 * ada-exp.y (write_ambiguous_var): Update.
2242 * buildsym.c (add_symbol_to_list): Update.
2243 * dwarf2read.c (read_variable): Update.
2244 (new_symbol): Update.
2245 * jit.c (finalize_symtab): Update.
2246 * language.c (language_alloc_type_symbol): Update.
2247 * symtab.c (fixup_symbol_section): Update.
2248 (initialize_objfile_symbol_1): Move code to...
2249 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2250 (allocate_symbol): Update.
2251 (allocate_template_symbol): Update.
2252 (get_symbol_address): Update.
2253 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2254 of having as a field, and add a constructor.
2255 (SYMBOL_VALUE): Update.
2256 (SYMBOL_VALUE_ADDRESS): Update.
2257 (SET_SYMBOL_VALUE_ADDRESS): Update.
2258 (SYMBOL_VALUE_BYTES): Update.
2259 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2260 (SYMBOL_BLOCK_VALUE): Update.
2261 (SYMBOL_VALUE_CHAIN): Update.
2262 (SYMBOL_LANGUAGE): Update.
2263 (SYMBOL_SECTION): Update.
2264 (SYMBOL_OBJ_SECTION): Update.
2265 (SYMBOL_SET_LANGUAGE): Update.
2266 (SYMBOL_SET_LINKAGE_NAME): Update.
2267 (SYMBOL_SET_NAMES): Update.
2268 (SYMBOL_NATURAL_NAME): Update.
2269 (SYMBOL_LINKAGE_NAME): Update.
2270 (SYMBOL_DEMANGLED_NAME): Update.
2271 (SYMBOL_SEARCH_NAME): Update.
2272 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2273 (struct symbol): Update.
2274 (struct template_symbol): Update.
2275 (struct rust_vtable_symbol): Update.
2276 * xcoffread.c (SYMBOL_DUP): Update.
2277
ed2c82c3
TT		 22782019-11-12 Tom Tromey <tom@tromey.com>
2279
2280 * tui/tui-layout.c (show_layout): Set current_layout.
2281 (show_source_disasm_command, show_data)
2282 (show_source_or_disasm_and_command): Don't set current_layout.
2283
d9fcefd5
TT		 22842019-11-12 Tom Tromey <tom@tromey.com>
2285
2286 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2287
45e42163
TT		 22882019-11-12 Tom Tromey <tom@tromey.com>
2289
2290 * tui/tui-win.c (resize_message): New global.
2291 (show_tui_resize_message): New function.
2292 (tui_async_resize_screen): Print message if requested.
2293 (_initialize_tui_win): Add tui-resize-message setting.
2294 * NEWS: Add entry for new commands.
2295
c86d74cc
TT		 22962019-11-11 Tom Tromey <tom@tromey.com>
2297
2298 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2299 functions.
2300
7b7b9424
CB		 23012019-11-11 Christian Biesinger <cbiesinger@google.com>
2302
2303 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2304
086baaf1
AB		 23052019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2306
2307 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2308 function.
2309 * python/python-internal.h (gdbpy_lookup_static_symbols):
2310 Declare new function.
2311 * python/python.c (python_GdbMethods): Add
2312 gdb.lookup_static_symbols method.
2313 * NEWS: Mention gdb.lookup_static_symbols.
2314
09ff83af
AB		 23152019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2316
2317 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2318 static block of current object file first. Also fix typo in
2319 header comment.
2320
eb2dd8df
AB		 23212019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2322
2323 * stack.c (set_last_displayed_sal): Delete.
2324 (last_displayed_sal_valid): Delete.
2325 (last_displayed_pspace): Delete.
2326 (last_displayed_addr): Delete.
2327 (last_displayed_symtab): Delete.
2328 (last_displayed_line): Delete.
2329 (class last_displayed_symtab_info_type): New.
2330 (last_displayed_symtab_info): New static global variable.
2331 (print_frame_info): Call methods on last_displayed_symtab_info.
2332 (clear_last_displayed_sal): Update header comment, and make use of
2333 last_displayed_symtab_info.
2334 (last_displayed_sal_is_valid): Likewise.
2335 (get_last_displayed_pspace): Likewise.
2336 (get_last_displayed_addr): Likewise.
2337 (get_last_displayed_symtab): Likewise.
2338 (get_last_displayed_line): Likewise.
2339 (get_last_displayed_sal): Likewise.
2340 * stack.h (clear_last_displayed_sal): Update header comment.
2341 (last_displayed_sal_is_valid): Likewise.
2342 (get_last_displayed_pspace): Likewise.
2343 (get_last_displayed_addr): Likewise.
2344 (get_last_displayed_symtab): Likewise.
2345 (get_last_displayed_line): Likewise.
2346 (get_last_displayed_sal): Likewise.
2347
62137775
AB		 23482019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2349
2350 * stack.c (frame_show_address): Convert return type to bool.
2351 * stack.h (frame_show_address): Likewise, and update header
2352 comment.
2353
cf57ad6d
AB		 23542019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2355
2356 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2357 * unittests/vec-utils-selftests.c: New file.
2358 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2359
0b026263
TT		 23602019-11-10 Tom Tromey <tom@tromey.com>
2361
2362 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2363 (tui_highlight_win): Likewise.
2364 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2365 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2366 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2367 Don't set can_highlight.
2368
b049ce2d
TT		 23692019-11-10 Tom Tromey <tom@tromey.com>
2370
2371 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2372 Remove unused declaration.
2373
992a7040
TT		 23742019-11-08 Tom Tromey <tromey@adacore.com>
2375
2376 * top.c (read_command_file): Update.
2377 (command_line_input): Make return type const.
2378 * python/py-gdb-readline.c: Update.
2379 * linespec.c (decode_line_2): Update.
2380 * defs.h (command_line_input): Make return type const.
2381 * cli/cli-script.c (read_next_line): Make return type const.
2382 * ada-lang.c (get_selections): Update.
2383
ca3a04f6
CB		 23842019-11-06 Christian Biesinger <cbiesinger@google.com>
2385
2386 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2387 * mi/mi-main.c (output_cores): Likewise.
2388 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2389 (linux_xfer_osdata_modules): Likewise.
2390 * remote.c (register_remote_support_xml): Likewise.
2391 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2392 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2393
e0eac551
TT		 23942019-11-06 Tom Tromey <tom@tromey.com>
2395
2396 * tui/tui-interp.c: Don't include readline.h.
2397 * tui/tui-hooks.c: Don't include readline.h.
2398 * symmisc.c: Include tilde.h, not readline.h.
2399 * symfile.c: Include tilde.h, not readline.h.
2400 * source.c: Include tilde.h, not readline.h.
2401 * solib.c: Include tilde.h, not readline.h.
2402 * psymtab.c: Include tilde.h, not readline.h.
2403 * exec.c: Include tilde.h, not readline.h.
2404 * corelow.c: Include tilde.h, not readline.h.
2405 * cli/cli-dump.c: Include tilde.h, not readline.h.
2406 * cli/cli-cmds.c: Don't include readline.h.
2407
825165c5
TT		 24082019-11-05 Tom Tromey <tom@tromey.com>
2409
2410 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2411 (tui_disassemble): Set addr_size.
2412 (tui_disasm_window::set_contents): Use addr_size.
2413
91ae903f
TT		 24142019-11-05 Tom Tromey <tom@tromey.com>
2415
2416 * rust-lang.c (rust_language_defn): Update.
2417 * python/py-value.c (valpy_string): Call c_get_string.
2418 * p-lang.c (pascal_language_defn): Update.
2419 * opencl-lang.c (opencl_language_defn): Update.
2420 * objc-lang.c (objc_language_defn): Update.
2421 * m2-lang.c (m2_language_defn): Update.
2422 * language.c (unknown_language_defn, auto_language_defn): Update.
2423 (default_get_string): Remove.
2424 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2425 * go-lang.c (go_language_defn): Update.
2426 * f-lang.c (f_language_defn): Update.
2427 * d-lang.c (d_language_defn): Update.
2428 * c-lang.c (c_language_defn, cplus_language_defn)
2429 (asm_language_defn, minimal_language_defn): Update.
2430 * ada-lang.c (ada_language_defn): Update.
2431 * language.h (struct language_defn) <la_get_string>: Remove.
2432 (LA_GET_STRING): Remove.
2433 (default_get_string): Don't declare.
2434
1df2f9ef
TT		 24352019-11-05 Tom Tromey <tom@tromey.com>
2436
2437 * tui/tui-source.h (struct tui_source_window): Inline
2438 constructor. Remove destructor.
2439 <style_changed, m_observable>: Move to superclass.
2440 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2441 (struct tui_source_window_base): Move private members to end.
2442 <style_changed, m_observable>: Move from tui_source_window.
2443 * tui/tui-winsource.c (tui_copy_source_line): Move from
2444 tui-source.c. Rename from copy_source_line. Add special handling
2445 for negative line number.
2446 (tui_source_window_base::style_changed): Move from
2447 tui_source_window.
2448 (tui_source_window_base): Register observer.
2449 (~tui_source_window_base): New.
2450 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2451 rename.
2452 (tui_source_window::set_contents): Use tui_copy_source_line.
2453 (tui_source_window::tui_source_window): Move to tui-source.h.
2454 (tui_source_window::~tui_source_window): Remove.
2455 (tui_source_window::style_changed): Move to superclass.
2456 * tui/tui-disasm.c (tui_disassemble): Create string file with
2457 styling, when possible. Add "addr_size" parameter.
2458 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2459 Don't compute maximum size.
2460 (len_without_escapes): New function
2461
5d051055
TT		 24622019-11-05 Tom Tromey <tom@tromey.com>
2463
2464 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2465 std::string.
2466 * tui/tui-winsource.c (tui_show_source_line): Update.
2467 * tui/tui-source.c (tui_source_window::set_contents): Update.
2468 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2469
ade7beea
CB		 24702019-11-05 Christian Biesinger <cbiesinger@google.com>
2471
2472 * symtab.h (gdb_static_assert): Put && operator at the beginning
2473 of the line instead of the end.
2474
3573abe1
CB		 24752019-11-04 Christian Biesinger <cbiesinger@google.com>
2476
2477 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2478 and sizeof (symbol).
2479 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2480
dae8b3eb
RO		 24812019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2482
2483 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2484 * configure.host: Mark *-*-solaris2.10* obsolete.
2485 * configure.tgt: Mark Solaris < 11 obsolete.
2486 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2487 Update target triplet.
2488
5df96a4e
TT		 24892019-11-01 Tom Tromey <tromey@adacore.com>
2490
2491 * utils.c (print_sys_errmsg): Simplify.
2492
b7481649
TT		 24932019-11-01 Tom Tromey <tromey@adacore.com>
2494
2495 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2496
e48f6033
CB		 24972019-11-01 Christian Biesinger <cbiesinger@google.com>
2498
2499 * configure: Regenerate.
2500 * configure.ac: Remove check for strerror_r.
2501 * gdbsupport/common.m4: Check for strerror_r.
2502
bd5766ec
LM		 25032019-11-01 Luis Machado <luis.machado@linaro.org>
2504
2505 PR gdb/25124
2506
2507 * arm-tdep.c (arm_per_objfile): Rename to ...
2508 (arm_per_bfd): ... this.
2509 (arm_objfile_data_key): Rename to ...
2510 (arm_bfd_data_key): ... this.
2511 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2512 data.
2513 (arm_record_special_symbol): Likewise.
2514
e1709896
AB		 25152019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2516
2517 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2518 end.
2519 * c-typeprint.c (c_print_typedef): Likewise.
2520 * f-typeprint.c (f_print_typedef): Likewise.
2521 * m2-typeprint.c (m2_print_typedef): Likewise.
2522 * p-typeprint.c (pascal_print_typedef): Likewise.
2523 * rust-lang.c (rust_print_typedef): Likewise.
2524 * symtab.c (print_symbol_info): Print a newline after calling
2525 typedef_print.
2526
165f8965
AB		 25272019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2528
2529 * symtab.c (info_module_cmdlist): New variable.
2530 (info_module_command): New function.
2531 (search_module_symbols): New function.
2532 (info_module_subcommand): New function.
2533 (struct info_modules_var_func_options): New struct.
2534 (info_modules_var_func_options_defs): New variable.
2535 (make_info_modules_var_func_options_def_group): New function.
2536 (info_module_functions_command): New function.
2537 (info_module_variables_command): New function.
2538 (info_module_var_func_command_completer): New function.
2539 (_initialize_symtab): Register new 'info module functions' and
2540 'info module variables' commands.
2541 * symtab.h (typedef symbol_search_in_module): New typedef.
2542 (search_module_symbols): Declare new function.
2543 * NEWS: Mention new commands.
2544
59c35742
AB		 25452019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2546
2547 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2548 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2549 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2550 MODULES_DOMAIN.
2551 (scan_partial_symbols): Only create partial module symbols for non
2552 declarations.
2553 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2554 and MODULES_DOMAIN.
2555 * symtab.c (search_domain_name): Likewise.
2556 (search_symbols): Likewise.
2557 (print_symbol_info): Likewise.
2558 (symtab_symbol_info): Likewise.
2559 (info_modules_command): New function.
2560 (_initialize_symtab): Register 'info modules' command.
2561 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2562 * NEWS: Mention new 'info modules' command.
2563
aed61d02
PW		 25642019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2565
2566 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2567 and $_gdb_maint_setting_str.
2568
9ad9b77d
PW		 25692019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2570
2571 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2572 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2573 (str_value_from_setting, gdb_setting_str_internal_fn)
2574 (gdb_maint_setting_str_internal_fn): New functions.
2575 (_initialize_cli_cmds): Define the new convenience functions.
2576 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2577 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2578
8d6efaa2
CB		 25792019-10-31 Christian Biesinger <cbiesinger@google.com>
2580
2581 * agent.c (set_can_use_agent): When the setting is turned on,
2582 look up agent symbols if we don't have them yet.
2583 (agent_new_objfile): Don't look up agent symbols when the agent
2584 setting is off.
2585
33cb1647
CB		 25862019-10-31 Christian Biesinger <cbiesinger@google.com>
2587
2588 * config.in: Regenerate.
2589
b231e86a
CB		 25902019-10-31 Christian Biesinger <cbiesinger@google.com>
2591
2592 * configure: Regenerate.
2593 * configure.ac: Check for strerror_r.
2594 * gdbsupport/common-utils.h (safe_strerror): Change return value
2595 to const char * and document that this function is now threadsafe.
2596 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2597 thread_local and call strerror_r, if available.
2598 * utils.c (perror_string): Update.
2599 (print_sys_errmsg): Update.
2600
a2726d4f
LM		 26012019-10-31 Luis Machado <luis.machado@linaro.org>
2602
2603 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2604 objfile_key.
2605 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2606 objfile to fetch per-bfd data.
2607 (arm_find_exidx_entry): Likewise.
2608
75cafaa6
CB		 26092019-10-31 Christian Biesinger <cbiesinger@google.com>
2610
2611 * gdbsupport/agent.c (debug_agent): Change type to bool.
2612 (use_agent): Likewise.
2613 (all_agent_symbols_look_up): Likewise.
2614 (agent_loaded_p): Change return value to bool.
2615 (agent_look_up_symbols): Update.
2616 (agent_capability_check): Change return value to bool.
2617 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2618 (debug_agent): Change type to bool.
2619 (use_agent): Likewise.
2620 (agent_capability_check): Change return value to bool.
2621
808590ec
CB		 26222019-10-30 Christian Biesinger <cbiesinger@google.com>
2623
2624 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2625 (build_minimal_symbol_hash_tables): Code to clear the table moved
2626 to clear_minimal_symbol_hash_tables.
2627 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2628 when needed.
2629
f18ad8a1
SM		 26302019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2631
2632 * infcmd.c: Remove includes.
2633 * infrun.c: Remove includes.
2634
de93309a
SM		 26352019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2636
2637 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2638 (grow_vect): Remove declaration.
2639 (ada_type_of_array): Remove declaration.
2640 (ada_update_initial_language): Remove declaration.
2641 (ada_fold_name): Remove declaration.
2642 (ada_fill_in_ada_prototype): Remove declaration.
2643 (user_select_syms): Remove declaration.
2644 (get_selections): Remove declaration.
2645 (ada_tag_type): Remove declaration.
2646 (ada_value_tag): Remove declaration.
2647 (ada_is_others_clause): Remove declaration.
2648 (ada_in_variant): Remove declaration.
2649 (ada_value_struct_elt): Remove declaration.
2650 (ada_attribute_name): Remove declaration.
2651 (ada_system_address_type): Remove declaration.
2652 * ada-lang.c (ada_watch_location_expression): Make static.
2653 (GROW_VECT): Move here from ada-lang.h.
2654 (grow_vect): Make static.
2655 (ada_update_initial_language): Make static.
2656 (ada_fold_name): Make static.
2657 (ada_type_of_array): Make static.
2658 (encoded_ordered_before): Move up.
2659 (sort_choices): Move up.
2660 (print_signatures): Move up.
2661 (ada_print_symbol_signature): Move up.
2662 (get_selections): Move up and make static.
2663 (user_select_syms): Move up and make static.
2664 (ada_value_struct_elt): Move up and make static.
2665 (ada_tag_type): Make static.
2666 (ada_value_tag): Make static.
2667 (ada_is_others_clause): Make static.
2668 (ada_in_variant): Make static.
2669 (ada_attribute_name): Make static.
2670
cdc46a9f
SM		 26712019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2672
2673 * ada-lang.c: Remove includes.
2674 * ada-typeprint.c: Remove includes.
2675 * ada-valprint.c: Remove includes.
2676
90421c56
SM		 26772019-10-29 Simon Marchi <simon.marchi@efficios.com>
2678
2679 * addrmap.c: Add static assertions of type size, moved from
2680 _initialize_addrmap.
2681 (_initialize_addrmap): Remove.
2682
31edb802
CB		 26832019-10-29 Christian Biesinger <cbiesinger@google.com>
2684
2685 * coffread.c (record_minimal_symbol): Update.
2686 (process_coff_symbol): Update.
2687 * dbxread.c (read_dbx_symtab): Update.
2688 * dwarf2read.c (add_partial_symbol): Update.
2689 (fixup_go_packaging): Update.
2690 (load_partial_dies): Update.
2691 (new_symbol): Update.
2692 * elfread.c (record_minimal_symbol): Change signature to use
2693 gdb::string_view instead of name+len.
2694 (elf_symtab_read): Update.
2695 (elf_rel_plt_read): Update.
2696 * mdebugread.c (parse_partial_symbols): Update.
2697 (handle_psymbol_enumerators): Update.
2698 (new_symbol): Update.
2699 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2700 to use gdb::string_view instead of name+len.
2701 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2702 * psympriv.h (add_psymbol_to_list): Likewise.
2703 * psymtab.c (add_psymbol_to_bcache): Likewise.
2704 (add_psymbol_to_list): Likewise.
2705 * stabsread.c (define_symbol): Update.
2706 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2707 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2708 (symbol_set_names): Likewise.
2709 * xcoffread.c (scan_xcoff_symtab): Update.
2710
0c921b21
CB		 27112019-10-29 Christian Biesinger <cbiesinger@google.com>
2712
2713 * symtab.h (symbol_set_names): Document that copy_name must be
2714 set to true for non-nullterminated strings.
2715 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2716 linkage_name if the entry was not found and we need to demangle.
2717
35e65c49
CB		 27182019-10-29 Christian Biesinger <cbiesinger@google.com>
2719
2720 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2721 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2722 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2723 * gdbsupport/gdb_binary_search.h: New file.
2724
ed2a2229
CB		 27252019-10-29 Christian Biesinger <cbiesinger@google.com>
2726
2727 * NEWS: Mention new --with-system-gdbinit-dir option.
2728 * config.in: Regenerate.
2729 * configure: Regenerate.
2730 * configure.ac: Add new option --with-system-gdbinit-dir.
2731 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2732 for a ".gdb" suffix.
2733 * main.c (get_init_files): Change system_gdbinit argument to
2734 a vector and return the files in SYSTEM_GDBINIT_DIR in
2735 addition to SYSTEM_GDBINIT.
2736 (captured_main_1): Update.
2737 (print_gdb_help): Update.
2738 * top.c (print_gdb_configuration): Also print the value of
2739 SYSTEM_GDBINIT_DIR.
2740
87f34879
CB		 27412019-10-28 Christian Biesinger <cbiesinger@google.com>
2742
2743 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2744 that takes gdb::string_view arguments.
2745
30baf67b
TV		 27462019-10-26 Tom de Vries <tdevries@suse.de>
2747
2748 * aarch64-linux-tdep.c: Fix typos in comments.
2749 * aarch64-tdep.c: Same.
2750 * ada-lang.c: Same.
2751 * amd64-nat.c: Same.
2752 * arc-tdep.c: Same.
2753 * arch/aarch64-insn.c: Same.
2754 * block.c: Same.
2755 * breakpoint.h: Same.
2756 * btrace.h: Same.
2757 * c-varobj.c: Same.
2758 * cli/cli-decode.c: Same.
2759 * cli/cli-script.c: Same.
2760 * cli/cli-utils.h: Same.
2761 * coff-pe-read.c: Same.
2762 * coffread.c: Same.
2763 * compile/compile-cplus-symbols.c: Same.
2764 * compile/compile-object-run.c: Same.
2765 * completer.c: Same.
2766 * corelow.c: Same.
2767 * cp-support.c: Same.
2768 * demangle.c: Same.
2769 * dwarf-index-write.c: Same.
2770 * dwarf2-frame.c: Same.
2771 * dwarf2-frame.h: Same.
2772 * eval.c: Same.
2773 * frame-base.h: Same.
2774 * frame.h: Same.
2775 * gdbcmd.h: Same.
2776 * gdbtypes.h: Same.
2777 * gnu-nat.c: Same.
2778 * guile/scm-objfile.c: Same.
2779 * i386-tdep.c: Same.
2780 * i386-tdep.h: Same.
2781 * infcall.c: Same.
2782 * infcall.h: Same.
2783 * linux-nat.c: Same.
2784 * m68k-tdep.c: Same.
2785 * macroexp.c: Same.
2786 * memattr.c: Same.
2787 * mi/mi-cmd-disas.c: Same.
2788 * mi/mi-getopt.h: Same.
2789 * mi/mi-main.c: Same.
2790 * minsyms.c: Same.
2791 * nat/aarch64-sve-linux-sigcontext.h: Same.
2792 * objfiles.h: Same.
2793 * ppc-linux-nat.c: Same.
2794 * ppc-linux-tdep.c: Same.
2795 * ppc-tdep.h: Same.
2796 * progspace.h: Same.
2797 * prologue-value.h: Same.
2798 * python/py-evtregistry.c: Same.
2799 * python/py-instruction.h: Same.
2800 * record-btrace.c: Same.
2801 * record-full.c: Same.
2802 * remote.c: Same.
2803 * rs6000-tdep.c: Same.
2804 * ser-tcp.c: Same.
2805 * sol-thread.c: Same.
2806 * sparc-sol2-tdep.c: Same.
2807 * sparc64-tdep.c: Same.
2808 * stabsread.c: Same.
2809 * symfile.c: Same.
2810 * symtab.h: Same.
2811 * target.c: Same.
2812 * tracepoint.c: Same.
2813 * tui/tui-data.h: Same.
2814 * tui/tui-io.c: Same.
2815 * tui/tui-win.c: Same.
2816 * tui/tui.c: Same.
2817 * unittests/rsp-low-selftests.c: Same.
2818 * user-regs.h: Same.
2819 * utils.c: Same.
2820 * utils.h: Same.
2821 * valarith.c: Same.
2822 * valops.c: Same.
2823 * valprint.c: Same.
2824 * valprint.h: Same.
2825 * value.c: Same.
2826 * value.h: Same.
2827 * varobj.c: Same.
2828 * x86-nat.h: Same.
2829 * xtensa-tdep.c: Same.
2830
1834d45f
AT		 28312019-10-25 Ali Tamur <tamur@google.com>
2832
2833 * charset.c (find_charset_names): Reflect API change.
2834
5396ae17
CB		 28352019-10-25 Christian Biesinger <cbiesinger@google.com>
2836
2837 * symtab.c (struct demangled_name_entry): Change demangled name
2838 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2839 part of the struct anymore.
2840 (symbol_set_names): No longer obstack allocate + copy the demangled
2841 name, just store the allocated name from bfd.
2842
93878f47
TT		 28432019-10-25 Tom Tromey <tromey@adacore.com>
2844
2845 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2846 (bsearch_cie_cmp, add_cie): Remove.
2847 (find_cie): Reimplement.
2848 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2849 (dwarf2_build_frame_info): Update.
2850
7b71fc97
L		 28512019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2852
2853 PR gdb/25126
2854 * symfile.c (reread_symbols): Call forget_cached_source_info to
2855 clear the stale source cache.
2856
cbb5a2ea
CB		 28572019-10-24 Christian Biesinger <cbiesinger@google.com>
2858
2859 * configure: Regenerate.
2860 * configure.ac: Remove code that sets python_has_threads.
2861
71737c43
CB		 28622019-10-24 Christian Biesinger <cbiesinger@google.com>
2863
2864 * config.in: Regenerate.
2865 * configure: Regenerate.
2866 * configure.ac: Remove the code that uses sed to get the python
2867 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2868
33d569b7
AB		 28692019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2870
2871 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2872 error paths.
2873
f16f7b7c
TT		 28742019-10-23 Tom Tromey <tom@tromey.com>
2875
2876 * arc-tdep.c: Remove ".." from include.
2877 * frv-tdep.c: Remove ".." from include.
2878 * lm32-tdep.c: Remove ".." from include.
2879 * microblaze-tdep.c: Remove ".." from include.
2880 * or1k-tdep.h: Remove ".." from include.
2881 * s12z-tdep.c: Remove ".." from include.
2882 * Makefile.in (OPCODES_CFLAGS): Add comment.
2883 (TOP_CFLAGS): New variable.
2884 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2885
6999161a
TT		 28862019-10-23 Tom Tromey <tom@tromey.com>
2887
2888 * Makefile.in (READLINE_DIR): Update.
2889
12e7c35e
TBA		 28902019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2891
2892 * infcall.c (call_function_by_hand_dummy): Fix the function
2893 comment. And extract out a code section into...
2894 (reserve_stack_space): ...this new function.
2895
37055cad
TBA		 28962019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2897
2898 * infcall.c (value_arg_coerce): Remove an unused parameter.
2899 (call_function_by_hand_dummy): Update the call to
2900 'value_arg_coerce'.
2901
39bcc47c
TBA		 29022019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2903
2904 * infcall.c (call_function_by_hand_dummy): Refactor.
2905
bd888c0f
TBA		 29062019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2907
2908 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2909
c12d372d
TT		 29102019-10-23 Tom Tromey <tom@tromey.com>
2911
2912 * configure: Rebuild.
2913 * configure.ac: Don't check for sigprocmask.
2914 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2915
4d0b984b
TT		 29162019-10-23 Tom Tromey <tom@tromey.com>
2917
2918 * configure: Rebuild.
2919 * acinclude.m4: Use m4_include, not sinclude.
2920
7e785608
TV		 29212019-10-23 Tom de Vries <tdevries@suse.de>
2922
2923 PR breakpoints/24687
2924 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2925
403772ef
CB		 29262019-10-22 Christian Biesinger <cbiesinger@google.com>
2927
2928 * symtab.c (struct demangled_name_entry) <language>: Change from
2929 bitfield to regular variable.
2930
3a494279
CB		 29312019-10-22 Christian Biesinger <cbiesinger@google.com>
2932
2933 * symtab.c (struct demangled_name_entry): Add a constructor.
2934 (free_demangled_name_entry): New function to call the destructor
2935 for demangled_name_entry.
2936 (create_demangled_names_hash): Pass free_demangled_name_entry to
2937 htab_create_alloc.
2938 (symbol_set_names): Call placement new for demangled_name_entry.
2939 * utils.c: No longer include xxhash.h here, now that fast_hash
2940 is inlined in the header.
2941 * utils.h: Instead, include it here.
2942
ccb1ba62
CB		 29432019-10-22 Christian Biesinger <cbiesinger@google.com>
2944
2945 * Makefile.in: Link with libxxhash.
2946 * config.in: Regenerate.
2947 * configure: Regenerate.
2948 * configure.ac: Search for libxxhash.
2949 * utils.c (fast_hash): Use xxhash if present.
2950
1a6ff1a9
CB		 29512019-10-22 Christian Biesinger <cbiesinger@google.com>
2952
2953 * utils.h (fast_hash): New function.
2954 * symtab.c (hash_demangled_name_entry): Call new function
2955 fast_hash.
2956
7bb43059
CB		 29572019-10-22 Christian Biesinger <cbiesinger@google.com>
2958
2959 * symtab.c (struct demangled_name_entry): Change type of mangled
2960 to gdb::string_view. Also adds a constructor that takes the
2961 mangled name.
2962 (hash_demangled_name_entry): Update.
2963 (eq_demangled_name_entry): Update.
2964 (free_demangled_name_entry): New function to call the destructor
2965 now that this is not a POD anymore.
2966 (create_demangled_names_hash): Pass free_demangled_name_entry to
2967 htab_create_alloc.
2968 (symbol_set_names): Update.
2969
7ba99d21
AT		 29702019-10-21 Ali Tamur <tamu@google.com>
2971
2972 * dwarf2read.c (dir_index): Change type.
2973 (file_name_index): Likewise.
2974 (line_header::include_dir_at): Change comment and implementation on
2975 whether it is DWARF 5.
2976 (line_header::is_valid_file_index): New function.
2977 (line_header::file_name_at): Change comment and implementation on
2978 whether it is DWARF 5.
2979 (line_header::file_names): Change to private field renamed as
2980 m_file_names and introduce a new accessor method.
2981 (line_header::file_names_size): New method.
2982 (line_header::include_dirs): Change to private field and rename as
2983 m_include_dirs.
2984 (dw2_get_file_names_reader): Define local var at a smaller scope and
2985 reflect API change.
2986 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2987 (process_structure_scope): Likewise.
2988 (line_header::add_include_dir): Change message and reflect renaming.
2989 (line_header::add_file_name): Likewise.
2990 (read_formatted_entries): Handle DW_FORM_data16.
2991 (dwarf_decode_line_header): Fix line header length calculation.
2992 (psymtab_include_file_name): Change comment and API.
2993 (lnp_state_machine::m_file): Update comment and reflect type change.
2994 (lnp_state_machine::record_line): Reflect type change.
2995 (dwarf_decode_lines): Reflect API change.
2996 (file_file_name): Likewise.
2997 (file_full_name): Likewise.
2998
45f47c3a
AB		 29992019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3000
3001 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3002
e5f3c0e3
TT		 30032019-10-21 Tom Tromey <tom@tromey.com>
3004
3005 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3006
a0a461e5
TT		 30072019-10-21 Tom Tromey <tom@tromey.com>
3008
3009 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3010 NM_H. Use AC_CONFIG_LINKS.
3011 * configure: Rebuild.
3012 * Makefile.in (NM_H): New variable.
3013 (generated_files): Add NM_H. Remove gcore.
3014 (nm.h, stamp-nmh): New targets.
3015
54d83b8d
TT		 30162019-10-20 Tom Tromey <tom@tromey.com>
3017
3018 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3019 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3020 obsolete comment.
3021 (put_objfile_before): Now static.
3022
23771117
SM		 30232019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3024
3025 * gdbsupport/common-utils.h (startswith): Change return type to
3026 bool.
3027
39ef2f62
CB		 30282019-10-19 Christian Biesinger <cbiesinger@google.com>
3029
3030 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3031 * breakpoint.c (bp_locations_compare): Rename to...
3032 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3033 (update_global_location_list): Use std::sort instead of qsort.
3034 * buildsym.c (compare_line_numbers): Rename to...
3035 (lte_is_less_than): ...this, and change to std::sort semantics.
3036 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3037 instead of qsort.
3038 * disasm.c (compare_lines): Rename to...
3039 (line_is_less_than): ...this, and change to std::sort semantics.
3040 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3041 of qsort.
3042 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3043 (fde_is_less_than): ...this, and change to std::sort semantics.
3044 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3045 * mdebugread.c (compare_blocks):
3046 (block_is_less_than): ...this, and change to std::sort semantics.
3047 (sort_blocks): Call std::sort instead of qsort.
3048 * objfiles.c (qsort_cmp): Rename to...
3049 (sort_cmp): ...this, and change to std::sort semantics.
3050 (update_section_map): Call std::sort instead of qsort.
3051 * remote.c (compare_pnums): Remove.
3052 (map_regcache_remote_table): Call std::sort instead of qsort.
3053 * utils.c (compare_positive_ints): Remove.
3054 * utils.h (compare_positive_ints): Remove.
3055 * xcoffread.c (compare_lte): Remove.
3056 (arrange_linetable): Call std::sort instead of qsort.
3057
f71433ee
SDJ		 30582019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3059
3060 * symfile.c (init_entry_point_info): Fix typo.
3061 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3062
85102364
TV		 30632019-10-18 Tom de Vries <tdevries@suse.de>
3064
3065 * aarch64-tdep.c: Fix typos in comments.
3066 * ada-lang.c: Same.
3067 * ada-tasks.c: Same.
3068 * alpha-tdep.c: Same.
3069 * alpha-tdep.h: Same.
3070 * amd64-nat.c: Same.
3071 * amd64-windows-tdep.c: Same.
3072 * arc-tdep.c: Same.
3073 * arc-tdep.h: Same.
3074 * arch-utils.c: Same.
3075 * arm-nbsd-tdep.c: Same.
3076 * arm-tdep.c: Same.
3077 * ax-gdb.c: Same.
3078 * blockframe.c: Same.
3079 * btrace.c: Same.
3080 * c-varobj.c: Same.
3081 * coff-pe-read.c: Same.
3082 * coffread.c: Same.
3083 * cris-tdep.c: Same.
3084 * darwin-nat.c: Same.
3085 * dbxread.c: Same.
3086 * dcache.c: Same.
3087 * disasm.c: Same.
3088 * dtrace-probe.c: Same.
3089 * dwarf-index-write.c: Same.
3090 * dwarf2-frame-tailcall.c: Same.
3091 * dwarf2-frame.c: Same.
3092 * dwarf2read.c: Same.
3093 * eval.c: Same.
3094 * exceptions.c: Same.
3095 * fbsd-tdep.c: Same.
3096 * findvar.c: Same.
3097 * frame.c: Same.
3098 * frv-tdep.c: Same.
3099 * gnu-v3-abi.c: Same.
3100 * go32-nat.c: Same.
3101 * h8300-tdep.c: Same.
3102 * hppa-tdep.c: Same.
3103 * i386-linux-tdep.c: Same.
3104 * i386-tdep.c: Same.
3105 * ia64-libunwind-tdep.c: Same.
3106 * ia64-tdep.c: Same.
3107 * infcmd.c: Same.
3108 * infrun.c: Same.
3109 * linespec.c: Same.
3110 * linux-nat.c: Same.
3111 * linux-thread-db.c: Same.
3112 * machoread.c: Same.
3113 * mdebugread.c: Same.
3114 * mep-tdep.c: Same.
3115 * mn10300-tdep.c: Same.
3116 * namespace.c: Same.
3117 * objfiles.c: Same.
3118 * opencl-lang.c: Same.
3119 * or1k-tdep.c: Same.
3120 * osabi.c: Same.
3121 * ppc-linux-nat.c: Same.
3122 * ppc-linux-tdep.c: Same.
3123 * ppc-sysv-tdep.c: Same.
3124 * printcmd.c: Same.
3125 * procfs.c: Same.
3126 * record-btrace.c: Same.
3127 * record-full.c: Same.
3128 * remote-fileio.c: Same.
3129 * remote.c: Same.
3130 * rs6000-tdep.c: Same.
3131 * s12z-tdep.c: Same.
3132 * score-tdep.c: Same.
3133 * ser-base.c: Same.
3134 * ser-go32.c: Same.
3135 * skip.c: Same.
3136 * sol-thread.c: Same.
3137 * solib-svr4.c: Same.
3138 * solib.c: Same.
3139 * source.c: Same.
3140 * sparc-nat.c: Same.
3141 * sparc-sol2-tdep.c: Same.
3142 * sparc-tdep.c: Same.
3143 * sparc64-tdep.c: Same.
3144 * stabsread.c: Same.
3145 * stack.c: Same.
3146 * symfile.c: Same.
3147 * symtab.c: Same.
3148 * target-descriptions.c: Same.
3149 * target-float.c: Same.
3150 * thread.c: Same.
3151 * utils.c: Same.
3152 * valops.c: Same.
3153 * valprint.c: Same.
3154 * value.c: Same.
3155 * varobj.c: Same.
3156 * windows-nat.c: Same.
3157 * xcoffread.c: Same.
3158 * xstormy16-tdep.c: Same.
3159 * xtensa-tdep.c: Same.
3160
c5adaa19
TT		 31612019-10-17 Tom Tromey <tromey@adacore.com>
3162
3163 * configure: Rebuild.
3164 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3165 in AC_CONFIG_FILES invocation.
3166 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3167 new-style config.status invocation.
3168
405feb71
TV		 31692019-10-17 Tom de Vries <tdevries@suse.de>
3170
3171 * arm-nbsd-nat.c: Fix typos in comments.
3172 * arm-tdep.c: Same.
3173 * darwin-nat-info.c: Same.
3174 * dwarf2read.c: Same.
3175 * elfread.c: Same.
3176 * event-top.c: Same.
3177 * findvar.c: Same.
3178 * gdbtypes.c: Same.
3179 * hppa-tdep.c: Same.
3180 * i386-tdep.c: Same.
3181 * jit.c: Same.
3182 * main.c: Same.
3183 * mdebugread.c: Same.
3184 * moxie-tdep.c: Same.
3185 * nto-procfs.c: Same.
3186 * osabi.c: Same.
3187 * ppc-linux-tdep.c: Same.
3188 * remote.c: Same.
3189 * riscv-tdep.c: Same.
3190 * s390-tdep.c: Same.
3191 * sh-tdep.c: Same.
3192 * sparc-linux-tdep.c: Same.
3193 * sparc-nat.c: Same.
3194 * stack.c: Same.
3195 * target-descriptions.c: Same.
3196 * top.c: Same.
3197 * varobj.c: Same.
3198
befcd486
TT		 31992019-10-16 Tom Tromey <tom@tromey.com>
3200
3201 * objfiles.h (struct objfile) <original_name>: Now const.
3202
17bfe554
CB		 32032019-10-16 Christian Biesinger <cbiesinger@google.com>
3204
3205 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3206 pass on to sigsetjmp's second argument.
3207 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3208
950b7495
KS		 32092019-10-16 Keith Seitz <keiths@redhat.com>
3210
3211 PR gdb/23567
3212 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3213 sections whose size is greater than the file size.
3214
ff371ec9
JW		 32152019-10-16 Jim Wilson <jimw@sifive.com>
3216
3217 * riscv-tdep.c (riscv_gcc_target_options): New.
3218 (riscv_gnu_triplet_regexp): New.
3219 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3220 set_gdbarch_gnu_triplet_regexp.
3221
fec4e896
CB		 32222019-10-16 Christian Biesinger <cbiesinger@google.com>
3223
3224 * Makefile.in: Add xml-builtin.h.
3225 * features/feature_to_c.sh: Add an include for xml-builtin.h
3226 to ensure that the compiler checks that the types match.
3227 * xml-builtin.h: New file.
3228 * xml-support.c (fetch_xml_builtin): Add missing const.
3229 * xml-support.h: Remove declaration of xml_builtins.
3230
d10eccaa
TV		 32312019-10-16 Tom de Vries <tdevries@suse.de>
3232
3233 PR tdep/25096
3234 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3235 (amd64_classify_aggregate): ... here.
3236 (amd64_classify_aggregate_field): Handled fiels of nested structs
3237 recursively.
3238
745ff14e
TV		 32392019-10-16 Tom de Vries <tdevries@suse.de>
3240
3241 PR tdep/24104
3242 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3243 that handles 'theclass'.
3244
791b7405
AB		 32452019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3246
3247 * linespec.c (decode_digits_ordinary): Update comment.
3248 * make-target-delegates: No longer need to handle VEC case.
3249 * memrange.c (normalize_mem_ranges): Update comment.
3250 * namespace.c (add_using_directive): Update comment.
3251 * objc-lang.c (uniquify_strings): Update comment.
3252 * ppc-linux-nat.c (struct thread_points): Update comment.
3253 * probe.h (find_probes_in_objfile): Update comment.
3254 * target.h (enum flash_preserve_mode): Update comment.
3255 * varobj.c (varobj_restrict_range): Update comment.
3256 * varobj.h (varobj_list_children): Update comment.
3257
0dc32745
AB		 32582019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3259
3260 * Makefile.in: Remove references to vec.h and vec.c.
3261 * aarch64-tdep.c: No longer include vec.h.
3262 * ada-lang.c: Likewise.
3263 * ada-lang.h: Likewise.
3264 * arm-tdep.c: Likewise.
3265 * ax.h: Likewise.
3266 * breakpoint.h: Likewise.
3267 * charset.c: Likewise.
3268 * cp-support.h: Likewise.
3269 * dtrace-probe.c: Likewise.
3270 * dwarf2read.c: Likewise.
3271 * extension.h: Likewise.
3272 * gdb_bfd.c: Likewise.
3273 * gdbsupport/gdb_vecs.h: Likewise.
3274 * gdbsupport/vec.c: Remove.
3275 * gdbsupport/vec.h: Remove.
3276 * gdbthread.h: Likewise.
3277 * guile/scm-type.c: Likewise.
3278 * inline-frame.c: Likewise.
3279 * machoread.c: Likewise.
3280 * memattr.c: Likewise.
3281 * memrange.h: Likewise.
3282 * namespace.h: Likewise.
3283 * nat/linux-btrace.h: Likewise.
3284 * osdata.c: Likewise.
3285 * parser-defs.h: Likewise.
3286 * progspace.h: Likewise.
3287 * python/py-type.c: Likewise.
3288 * record-btrace.c: Likewise.
3289 * rust-exp.y: Likewise.
3290 * solib-target.c: Likewise.
3291 * stap-probe.c: Likewise.
3292 * target-descriptions.c: Likewise.
3293 * target-memory.c: Likewise.
3294 * target.h: Likewise.
3295 * varobj.c: Likewise.
3296 * varobj.h: Likewise.
3297 * xml-support.h: Likewise.
3298
ae640021
AB		 32992019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3300
3301 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3302 Update for new std::vector based implementation.
3303 (process_psymtab_comp_unit_reader): Likewise.
3304 (scan_partial_symbols): Likewise.
3305 (recursively_compute_inclusions): Likewise.
3306 (compute_compunit_symtab_includes): Likewise.
3307 (process_imported_unit_die): Likewise.
3308 (queue_and_load_dwo_tu): Likewise.
3309 (follow_die_sig_1): Likewise.
3310 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3311 (typedef dwarf2_per_cu_ptr): Remove.
3312 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3313 function.
3314 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3315 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3316 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3317 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3318 std::vector.
3319
55dfc88f
TT		 33202019-10-15 Tom Tromey <tromey@adacore.com>
3321
3322 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3323 TID.
3324
96b49c5e
TT		 33252019-10-15 Tom Tromey <tromey@adacore.com>
3326
3327 * windows-nat.c (windows_nat_target::fetch_registers)
3328 (windows_nat_target::store_registers): Rename "pid" to "tid".
3329
953cff56
TT		 33302019-10-15 Tom Tromey <tromey@adacore.com>
3331
3332 * gdbarch.h, gdbarch.c: Rebuild.
3333 * gdbarch.sh (gcc_target_options): Change return type to
3334 std::string.
3335 * compile/compile.c (get_args): Update.
3336 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3337 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3338 std::string.
3339 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3340 std::string.
3341 * arch-utils.c (default_gcc_target_options): Return std::string.
3342 * arch-utils.h (default_gcc_target_options): Return std::string.
3343 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3344
81e6b8eb
CB		 33452019-10-15 Christian Biesinger <cbiesinger@google.com>
3346
3347 * breakpoint.c (breakpoint_chain): Make static.
3348 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3349 of accessing breakpoint_chain.
3350
95da600f
CB		 33512019-10-15 Christian Biesinger <cbiesinger@google.com>
3352
3353 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3354 to a gdb::function_view and return value to bool.
3355 * breakpoint.h (iterate_over_breakpoints): Likewise.
3356 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3357 (pop_dummy_frame): Update.
3358 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3359 (gdbscm_breakpoints): Update.
3360 * python/py-breakpoint.c (build_bp_list): Update.
3361 (gdbpy_breakpoints): Update.
3362 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3363 Update.
3364 (bpfinishpy_handle_stop): Update.
3365 (bpfinishpy_handle_exit): Update.
3366 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3367 (svr4_update_solib_event_breakpoints): Update.
3368
ba18312d
AA		 33692019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3370
3371 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3372 when unwrapping single-field structs.
3373
6acc1a0b
SM		 33742019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3375
3376 * dwarf2read.c: Remove includes.
3377
284782de
SM		 33782019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3379
3380 * ui-out.c (ui_out::call_do_message): Silence
3381 -Wformat-nonliteral warning.
3382
073bbbb0
SM		 33832019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3384
3385 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3386 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3387 include: readline/tilde.h.
3388
7b9a15e1
CB		 33892019-10-12 Christian Biesinger <cbiesinger@google.com>
3390
3391 * remote.c (remote_target::get_trace_status): Remove declaration of
3392 trace_regblock_size.
3393
cc8dee1f
CB		 33942019-10-12 Christian Biesinger <cbiesinger@google.com>
3395
3396 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3397 (show_user): Remove declaration of cmdlist.
3398 * cli/cli-cmds.h (max_user_call_depth): Declare.
3399 * cli/cli-script.c (execute_user_command): Remove declaration
3400 of max_user_call_depth.
3401
a83d4ef6
JW		 34022019-10-11 Jim Wilson <jimw@sifive.com>
3403
5f93c5a6
JW		 3404 * gdbsupport/print-utils.h (pulongest): Fix comment.
3405 (plongest): Likewise.
3406 (phex): Add missing comment, mention leading zeros.
3407 (phex_nz): Add mention of no leading zeros to comment.
3408
a83d4ef6
JW		 3409 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3410 plongest instead of unsigned long long cast.
3411
26344e0c
CB		 34122019-10-10 Christian Biesinger <cbiesinger@google.com>
3413
3414 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3415 for external_editor_command and gdbtk_test.
3416
c2c440a9
CB		 34172019-10-10 Christian Biesinger <cbiesinger@google.com>
3418
3419 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3420 * varobj.c (varobjdebug): Move comment to...
3421 * varobj.h (varobjdebug): ...here, and declare.
3422
a31bff9d
TT		 34232019-10-09 Tom Tromey <tom@tromey.com>
3424
3425 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3426 erase_data_content.
3427
7523da63
TT		 34282019-10-09 Tom Tromey <tom@tromey.com>
3429
3430 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3431 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3432 * tui/tui-command.c (tui_cmd_window::resize)
3433 (tui_refresh_cmd_win): Update.
3434 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3435 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3436 * tui/tui-data.c (~tui_gen_win_info): Remove.
3437 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3438 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3439 (tui_redisplay_readline, tui_mld_flush)
3440 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3441 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3442 (tui_data_window::erase_data_content)
3443 (tui_data_item_window::rerender)
3444 (tui_data_item_window::refresh_window): Update.
3445 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3446 (box_win, tui_gen_win_info::make_window)
3447 (tui_gen_win_info::make_visible): Update.
3448 (tui_delete_win): Remove.
3449 * tui/tui-winsource.c
3450 (tui_source_window_base::do_erase_source_content): Update.
3451 (tui_show_source_line, tui_source_window_base::update_tab_width)
3452 (tui_source_window_base::update_exec_info): Update.
3453 * tui/tui-data.h (struct curses_deleter): New.
3454 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3455 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3456
a7798e7f
TT		 34572019-10-09 Tom Tromey <tom@tromey.com>
3458
3459 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3460
5c45899e
TT		 34612019-10-09 Tom Tromey <tom@tromey.com>
3462
3463 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3464 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3465
6d7fd9aa
TT		 34662019-10-09 Tom Tromey <tom@tromey.com>
3467
3468 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3469 window height directly.
3470 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3471 declare.
3472 * tui/tui-layout.c (tui_default_win_height): Remove.
3473 (tui_default_win_viewport_height): Remove.
3474
d2dd1084
TT		 34752019-10-09 Tom Tromey <tom@tromey.com>
3476
3477 * tui/tui.h: Remove comments.
3478
cff32449
TV		 34792019-10-09 Tom de Vries <tdevries@suse.de>
3480
3481 * python/lib/gdb/printer/bound_registers.py: Use
3482 '^builtin_type_bound128' as regexp argument for
3483 add_builtin_pretty_printer.
3484
6a25e8a2
CB		 34852019-10-09 Christian Biesinger <cbiesinger@google.com>
3486
3487 * guile/guile.c (guile_extension_script_ops): Remove forward
3488 declaration and mark as static.
3489 (guile_script_ops): Likewise.
3490 (extension_language_guile): Move further down in the file so
3491 it can reference the definitions for guile_{extension_,}script_ops.
3492
6d9d6da4
AA		 34932019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3494
3495 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3496 except SORTL, DFLTCC, and KDSA.
3497
3abea05d
TT		 34982019-10-08 Tom Tromey <tromey@adacore.com>
3499
3500 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3501 (struct safe_symbol_file_add_args): Remove.
3502
dde996e2
TT		 35032019-10-08 Tom Tromey <tromey@adacore.com>
3504
3505 * windows-nat.c: Don't include buildsym-legacy.h.
3506
cd6fdaa1
TT		 35072019-10-08 Tom Tromey <tromey@adacore.com>
3508
3509 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3510
79bb1944
CB		 35112019-10-08 Christian Biesinger <cbiesinger@google.com>
3512
3513 * gdbtypes.c (overload_debug): Move comment to header.
3514 * gdbtypes.h (overload_debug): Declare.
3515 * valops.c: Remove declaration of overload_debug, instead
3516 include gdbtypes.h.
3517
34916edc
CB		 35182019-10-08 Christian Biesinger <cbiesinger@google.com>
3519
3520 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3521 through _().
3522 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3523 move comment...
3524 * language.h (lang_frame_mismatch_warn): ... here. Also add
3525 declaration.
3526 * top.c (lang_frame_mismatch_warn): Remove declaration.
3527 (check_frame_language_change): Pass lang_frame_mismatch_warn
3528 through _().
3529
bad5c026
CB		 35302019-10-07 Christian Biesinger <cbiesinger@google.com>
3531
3532 * c-lang.h (vtbl_ptr_name): Declare.
3533 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3534 it from the header.
3535 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3536
51f1fdc3
CB		 35372019-10-07 Christian Biesinger <cbiesinger@google.com>
3538
3539 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3540 gdb_static_assert.
3541
30d1f018
WP		 35422019-10-07 Weimin Pan <weimin.pan@oracle.com>
3543
606813d5
WP		 3544 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3545 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3546 * ctfread.c: New file.
3547 * ctfread.h: New file.
3548 * elfread.c: Include ctfread.h.
3549 (struct elfinfo text_p): New member ctfsect.
3550 (elf_locate_sections): Mark CTF section.
3551 (elf_symfile_read): Call elfctf_build_psymtabs.
3552 * Makefile.in (LIBCTF): Add.
3553 (CLIBS): Use it.
3554 (CDEPS): Likewise.
3555 (DIST): Add ctfread.c.
606813d5
WP		 3556
35572019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3558
3559 * ctfread.c (struct nextfield): Renamed to ...
3560 (struct ctf_nextfield): ... this.
3561 (struct field_info): Renamed to ...
3562 (strut ctf_field_info): ... this.
3563 (attach_fields_to_type): Update for renamed structures.
3564 (ctf_add_member_cb): Likewise.
3565 (ctf_add_enum_member_cb): Likewise.
3566 (process_struct_members): Likewise.
3567 (process_enum_type): Likewise.
30d1f018 3568
518fe38c
WP		 35692019-10-07 Weimin Pan <weimin.pan@oracle.com>
3570
3571 * tracectf.h: Rename, was ctf.h.
3572 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3573 * tracefile.c: Likewise.
3574 * tracepoint.c: Remove unused include ctf.h.
3575 * mi/mi-main.c: Likewise.
3576 * Makefile.in Replace ctf.c with tracectf.c.
3577
225f296a
JB		 35782019-10-06 Joel Brobecker <brobecker@adacore.com>
3579
3580 * version.in: Change version number to "9.0.50.DATE-git".
3581
77c2dba3
TT		 35822019-10-03 Tom Tromey <tom@tromey.com>
3583
3584 PR rust/24976:
3585 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3586
179aed7f
AB		 35872019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3588
3589 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3590 cp_search_name_hash.
3591 * NEWS: Add entry about nested function support.
3592
0a4b0913
AB		 35932019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3594 Andrew Burgess <andrew.burgess@embecosm.com>
3595
3596 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3597 for nested static variables when searchin VAR_DOMAIN.
3598 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3599 global scope, update comment.
3600 (add_partial_subprogram): Call add_partial_subprogram recursively
3601 for nested subroutines when processinng Fortran.
3602 (load_partial_dies): Process the child entities of a subprogram
3603 when processing Fortran.
3604 (partial_die_parent_scope): Handle building scope
3605 for Fortran nested functions.
3606 (process_die): Record that nested functions have a scope.
3607 (new_symbol): Always record Fortran subprograms on the global
3608 symbol list.
3609 (determine_prefix): How to build the prefix for Fortran
3610 subprograms.
3611
d8c06f22
AB		 36122019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3613
3614 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3615 have just sent the thread a SIGSTOP and are waiting for it to
3616 arrive.
3617
a8b3b8e9
AB		 36182019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3619
3620 * btrace.c (btrace_add_pc): Remove whitespace before the template
3621 parameter in 'std::vector <...>'.
3622 (parse_xml_btrace_block): Likewise.
3623 (btrace_maint_decode_pt): Likewise.
3624 (btrace_maint_update_packets): Likewise.
3625 (btrace_maint_print_packets): Likewise.
3626 * btrace.h (struct btrace_maint_info): Likewise.
3627 * dwarf2read.c (struct type_unit_group): Likewise.
3628 (build_type_psymtabs_reader): Likewise.
3629 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3630 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3631 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3632
4d825eab
TV		 36332019-10-03 Tom de Vries <tdevries@suse.de>
3634
3635 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3636 the first line of the help text for set/show style metadata.
3637
80fd2826
TT		 36382019-10-02 Tom Tromey <tromey@adacore.com>
3639
3640 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3641 * gdbsupport/common-inferior.c: New file.
3642 * infcmd.c (startup_with_shell): Don't define.
3643 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3644 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3645 * inferior.h (startup_with_shell): Don't declare.
3646
70054538
CB		 36472019-10-02 Christian Biesinger <cbiesinger@google.com>
3648
3649 * gdbsupport/gdb_assert.h: Include errors.h.
3650 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3651
37f6a7f4
TT		 36522019-10-02 Tom Tromey <tromey@adacore.com>
3653
3654 * NEWS: Add $_ada_exception entry.
3655 * ada-lang.c (struct ada_catchpoint): Add constructor.
3656 <m_kind>: New member.
3657 (allocate_location_exception, re_set_exception): Remove
3658 "ex" parameter.
3659 (should_stop_exception): Compute $_ada_exception.
3660 (check_status_exception, print_it_exception)
3661 (print_one_exception, print_mention_exception): Remove
3662 "ex" parameter.
3663 (allocate_location_catch_exception, re_set_catch_exception)
3664 (check_status_exception, print_it_catch_exception)
3665 (print_one_catch_exception, print_mention_catch_exception)
3666 (print_recreate_catch_exception)
3667 (allocate_location_catch_exception_unhandled)
3668 (re_set_catch_exception_unhandled)
3669 (check_status_exception, print_it_catch_exception_unhandled)
3670 (print_one_catch_exception_unhandled)
3671 (print_mention_catch_exception_unhandled)
3672 (print_recreate_catch_exception_unhandled)
3673 (allocate_location_catch_assert, re_set_catch_assert)
3674 (check_status_assert, print_it_catch_assert)
3675 (print_one_catch_assert, print_mention_catch_assert)
3676 (print_recreate_catch_assert)
3677 (allocate_location_catch_handlers, re_set_catch_handlers)
3678 (check_status_handlers, print_it_catch_handlers)
3679 (print_one_catch_handlers, print_mention_catch_handlers)
3680 (print_recreate_catch_handlers): Remove.
3681 (create_ada_exception_catchpoint): Update.
3682 (initialize_ada_catchpoint_ops): Update.
3683
fccf9de1
TT		 36842019-10-02 Tom Tromey <tromey@adacore.com>
3685
3686 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3687 (create_excep_cond_exprs): Simplify exception string computation.
3688 (ada_exception_catchpoint_cond_string): Likewise.
3689
4b610737
TT		 36902019-10-02 Tom Tromey <tromey@adacore.com>
3691
3692 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3693 * ada-lang.c (lesseq_defined_than): Handle
3694 LOC_STATIC.
3695 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3696 parameter.
3697 (dwarf2_has_info): Likewise.
3698 (new_symbol): Set maybe_copied on symbol when
3699 appropriate.
3700 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3701 parameter.
3702 <can_copy>: New member.
3703 * elfread.c (record_minimal_symbol): Set maybe_copied
3704 on symbol when appropriate.
3705 (elf_symfile_read): Update call to dwarf2_has_info.
3706 * minsyms.c (lookup_minimal_symbol_linkage): New
3707 function.
3708 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3709 * symtab.c (get_symbol_address, get_msymbol_address):
3710 New functions.
3711 * symtab.h (get_symbol_address, get_msymbol_address):
3712 Declare.
3713 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3714 maybe_copied.
3715 (struct symbol, struct minimal_symbol) <maybe_copied>:
3716 New member.
3717
1dd58850
TT		 37182019-10-02 Tom Tromey <tromey@adacore.com>
3719
3720 * source.c (struct current_source_location): New.
3721 (current_source_key): New global.
3722 (current_source_symtab, current_source_line)
3723 (current_source_pspace): Remove.
3724 (get_source_location): New function.
3725 (get_current_source_symtab_and_line)
3726 (set_default_source_symtab_and_line)
3727 (set_current_source_symtab_and_line)
3728 (clear_current_source_symtab_and_line, select_source_symtab)
3729 (info_source_command, print_source_lines_base)
3730 (info_line_command, search_command_helper, _initialize_source):
3731 Update.
3732
5c281dbb
TT		 37332019-10-02 Tom Tromey <tromey@adacore.com>
3734
3735 * source.c (select_source_symtab): Don't call
3736 decode_line_with_current_source.
3737
d3d32391
AB		 37382019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3739
3740 * symtab.c (lookup_global_symbol): Search global block.
3741
38583298
TT		 37422019-10-02 Tom Tromey <tromey@adacore.com>
3743
3744 * coffread.c (process_coff_symbol): Update.
3745 * dwarf2read.c (var_decode_location, new_symbol): Update.
3746 * mdebugread.c (parse_symbol): Update.
3747 * objfiles.c (relocate_one_symbol): Update.
3748 * stabsread.c (define_symbol, fix_common_block)
3749 (scan_file_globals): Update.
3750 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3751 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3752 * xcoffread.c (process_xcoff_symbol): Update.
3753
9344c18f
AA		 37542019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3755
3756 * MAINTAINERS: Update my email address.
3757
df07e2c7
AB		 37582019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3759
3760 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3761 std::vector.
3762 (build_type_psymtabs_reader): Update for std::vector.
3763 (build_type_psymtab_dependencies): Likewise.
3764 * dwarf2read.h: Remove use of DEF_VEC_P.
3765 (typedef sig_type_ptr): Delete.
3766
554ac434
AB		 37672019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3768
3769 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3770 to std::vector.
3771 (btrace_maint_decode_pt): Likewise, and move allocation of the
3772 vector outside of the loop.
3773 (btrace_maint_update_packets): Update to handle change from VEC to
3774 std::vector.
3775 (btrace_maint_print_packets): Likewise.
3776 (maint_info_btrace_cmd): Likewise.
3777 * btrace.h: Remove use of DEF_VEC_O.
3778 (typedef btrace_pt_packet_s): Delete.
3779 (struct btrace_maint_info) <packets>: Change fromm VEC to
3780 std::vector.
3781 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3782
46f29a9a
AB		 37832019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3784
3785 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3786 make accesses into the vector constant references.
3787 (btrace_add_pc): Update for std::vector.
3788 (btrace_stitch_bts): Likewise.
3789 (parse_xml_btrace_block): Likewise.
3790 (btrace_maint_update_packets): Likewise.
3791 (btrace_maint_print_packets): Likewise.
3792 (maint_info_btrace_cmd): Likewise.
3793 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3794 std::vector.
3795 (btrace_data::empty): Likewise.
3796 (btrace_data_append): Likewise.
3797 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3798 (typedef btrace_block_s): Delete.
3799 (struct btrace_block): Add constructor.
3800 (struct btrace_data_bts) <blocks>: Change to std::vector.
3801 * nat/linux-btrace.c (perf_event_read_bts): Update for
3802 std::vector.
3803 (linux_read_bts): Likewise.
3804
d770d56f
TT		 38052019-10-01 Tom Tromey <tom@tromey.com>
3806
3807 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3808
9d636d67
TT		 38092019-10-01 Tom Tromey <tom@tromey.com>
3810
3811 * stack.c (print_frame, info_frame_command_core): Use
3812 styled_string.
3813 * linux-thread-db.c (try_thread_db_load_1)
3814 (try_thread_db_load_from_pdir_1): Use styled_string.
3815 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3816 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3817 (maybe_print_unsupported_script_warning)
3818 (maybe_print_script_not_found_warning): Use styled_string.
3819 * ada-lang.c (user_select_syms): Use styled_string.
3820
7f6aba03
TT		 38212019-10-01 Tom Tromey <tom@tromey.com>
3822
3823 * p-lang.c (pascal_printstr): Use metadata style.
3824 * value.c (show_convenience): Use metadata style.
3825 * valprint.c (valprint_check_validity, val_print_optimized_out)
3826 (val_print_not_saved, val_print_unavailable)
3827 (val_print_invalid_address, generic_val_print, val_print)
3828 (value_check_printable, val_print_array_elements): Use metadata
3829 style.
3830 * ui-out.h (class ui_out) <field_fmt>: New overload.
3831 <do_field_fmt>: Add style parameter.
3832 * ui-out.c (ui_out::field_fmt): New overload.
3833 * typeprint.c (type_print_unknown_return_type)
3834 (val_print_not_allocated, val_print_not_associated): Use metadata
3835 style.
3836 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3837 parameter.
3838 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3839 * tracepoint.c (tvariables_info_1): Use metadata style.
3840 * stack.c (print_frame_arg, print_frame_info, print_frame)
3841 (info_frame_command_core): Use metadata style.
3842 * skip.c (info_skip_command): Use metadata style.
3843 * rust-lang.c (rust_print_enum): Use metadata style.
3844 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3845 metadata style.
3846 * python/py-framefilter.c (py_print_single_arg): Use metadata
3847 style.
3848 * printcmd.c (do_one_display, print_variable_and_value): Use
3849 metadata style.
3850 * p-valprint.c (pascal_val_print)
3851 (pascal_object_print_value_fields): Use metadata style.
3852 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3853 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3854 parameter.
3855 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3856 * m2-valprint.c (m2_print_long_set): Use metadata style.
3857 * m2-typeprint.c (m2_print_type): Use metadata style.
3858 * infcmd.c (print_return_value_1): Use metadata style.
3859 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3860 * f-valprint.c (info_common_command_for_block): Use metadata
3861 style.
3862 * f-typeprint.c (f_type_print_base): Use metadata style.
3863 * expprint.c (print_subexp_standard): Use metadata style.
3864 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3865 * cli/cli-style.h (class cli_style_option): Add constructor.
3866 (metadata_style): Declare.
3867 * cli/cli-style.c (metadata_style): New global.
3868 (_initialize_cli_style): Register metadata style.
3869 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3870 parameter.
3871 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3872 * c-typeprint.c (c_type_print_base_struct_union)
3873 (c_type_print_base_1): Use metadata style.
3874 * breakpoint.c (watchpoint_value_print)
3875 (print_one_breakpoint_location): Use metadata style.
3876 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3877 style.
3878 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3879 style.
3880 * ada-valprint.c (val_print_packed_array_elements, printstr)
3881 (print_field_values, ada_val_print_ref, ada_val_print): Use
3882 metadata style.
3883 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3884 style.
3885 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3886 style.
3887 * ada-lang.c (user_select_syms): Use metadata style.
3888
14309bb6
TT		 38892019-10-01 Tom Tromey <tom@tromey.com>
3890
3891 * cli/cli-cmds.c (pwd_command): Style output.
3892
6a831f06
PA		 38932019-10-01 Pedro Alves <palves@redhat.com>
3894 Tom Tromey <tom@tromey.com>
3895
3896 * symtab.c (print_symbol_info): Use %ps.
3897 (print_msymbol_info): Use %ps.
3898 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3899 * printcmd.c (print_variable_and_value): Use %ps.
3900 * macrocmd.c (show_pp_source_pos): Use %ps.
3901 * infrun.c (print_exited_reason): Use ui_out::message.
3902 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3903 (describe_other_breakpoints): Use ui_out::message and new
3904 formats.
3905 (say_where): Use new formats.
3906 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3907 and new formats.
3908
2a3c1174
PA		 39092019-10-01 Pedro Alves <palves@redhat.com>
3910 Tom Tromey <tom@tromey.com>
3911
3912 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3913 (test_gdb_formats): New function.
3914 (run_tests): Call it.
3915 (test_format_specifier): Update.
3916 * utils.h (fputs_filtered): Update comment.
3917 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3918 (fputs_styled_unfiltered): Declare.
3919 * utils.c (fputs_styled_unfiltered): New function.
3920 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3921 (vfprintf_filtered): Update.
3922 (vfprintf_unfiltered, vprintf_filtered): Update.
3923 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3924 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3925 disallow_ui_out_field>: New constants.
3926 (enum class field_kind): New.
3927 (struct base_field_s, struct signed_field_s): New.
3928 (signed_field): New function.
3929 (struct string_field_s): New.
3930 (string_field): New function.
3931 (struct styled_string_s): New.
3932 (styled_string): New function.
3933 (class ui_out) <message>: Add comment.
3934 <vmessage, call_do_message>: New methods.
3935 <do_message>: Add style parameter.
3936 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3937 methods.
3938 (ui_out::message): Rewrite.
3939 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3940 parameter.
3941 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3942 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3943 gdb_extensions parameter.
3944 (class format_piece): Add parameter to constructor.
3945 (n_int_args): New field.
3946 * gdbsupport/format.c (format_pieces::format_pieces): Add
3947 gdb_extensions parameter. Handle '*'.
3948 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3949 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3950 vfprintf_styled_no_gdbfmt.
3951 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3952 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3953 unfiltered output.
3954 * ui-style.h (struct ui_file_style) <ptr>: New method.
3955
0dfe5bfb
TT		 39562019-10-01 Tom Tromey <tom@tromey.com>
3957
3958 * unittests/format_pieces-selftests.c: Update. Add final format.
3959 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3960 empty literal pieces.
3961
e43b10e1
TT		 39622019-10-01 Tom Tromey <tom@tromey.com>
3963
3964 * ui-out.h (enum class ui_out_style_kind): Remove.
3965 (class ui_out) <field_string, field_stsream, do_field_string>:
3966 Change type of "style".
3967 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3968 (ui_out::field_string): Update.
3969 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3970 of "style".
3971 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3972 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3973 * stack.c (print_frame_arg, print_frame_info, print_frame):
3974 Update.
3975 * source.c (print_source_lines_base): Update.
3976 * solib.c (info_sharedlibrary_command): Update.
3977 * skip.c (info_skip_command): Update.
3978 * record-btrace.c (btrace_call_history_src_line)
3979 (btrace_call_history): Update.
3980 * python/py-framefilter.c (py_print_frame): Update.
3981 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3982 "style".
3983 * mi/mi-out.c (mi_ui_out::do_table_header)
3984 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3985 (mi_ui_out::do_field_string): Update.
3986 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3987 Update.
3988 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3989 "style".
3990 * cli-out.c (cli_ui_out::do_table_header)
3991 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3992 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3993 (cli_ui_out::do_field_fmt): Update.
3994 * breakpoint.c (print_breakpoint_location): Update.
3995 (update_static_tracepoint): Update.
3996
cd7c32c3
PW		 39972019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3998
3999 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4000 conversion of gdb_datadir.
4001 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4002 remove not needed c_str ().
4003
8fe0f950
AT		 40042019-09-30 Ali Tamur <tamur@google.com>
4005
4006 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4007 (dwarf2_string_attr): Likewise.
4008
5f48f8f3
AT		 40092019-09-30 Ali Tamur <tamur@google.com>
4010
4011 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4012 (process_full_type_unit): Likewise.
4013 (dump_die_shallow): Likewise.
4014 (cu_debug_loc_section): Likewise.
4015
6fb08628
CB		 40162019-09-28 Christian Biesinger <cbiesinger@google.com>
4017
4018 * minsyms.c (compare_minimal_symbols): Rename to...
4019 (minimal_symbol_is_less_than): ...this, and adjust to STL
4020 conventions (return bool, take arguments as references)
4021 (minimal_symbol_reader::install): Call std::sort instead
4022 of qsort.
4023
c7ee338a
CB		 40242019-09-29 Christian Biesinger <cbiesinger@google.com>
4025
4026 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4027 hash and why.
4028 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4029 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4030
703a86c2
SM		 40312019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4032
4033 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4034 * psympriv.h (add_psymbol_to_list): Move comment here and update
4035 it.
4036
0df0352a
TV		 40372019-09-29 Tom de Vries <tdevries@suse.de>
4038
4039 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4040 Use $tmpdir/$(basename "$output_file").dwz instead of
4041 "${output_file}.dwz".
4042
ad75efa6
SM		 40432019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4044
4045 PR gdb/25045
4046 * hppa-linux-nat.c: Include gdbarch.h.
4047
ececd218
CB		 40482019-09-26 Christian Biesinger <cbiesinger@google.com>
4049
4050 * blockframe.c (find_pc_partial_function): Change return type to bool.
4051 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4052 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4053 (stub_gnu_ifunc_resolve_name): Likewise.
4054 * symtab.c (compare_filenames_for_search): Likewise.
4055 (compare_glob_filenames_for_search): Likewise.
4056 (matching_obj_sections): Likewise.
4057 (symbol_matches_domain): Likewise.
4058 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4059 (find_line_pc): Change return type to bool.
4060 (find_line_pc_range): Likewise.
4061 (producer_is_realview): Likewise.
4062 * symtab.h (symbol_matches_domain): Likewise.
4063 (find_pc_partial_function): Likewise.
4064 (find_pc_line_pc_range): Likewise.
4065 (in_gnu_ifunc_stub): Likewise.
4066 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4067 (find_line_pc): Likewise.
4068 (find_line_pc_range): Likewise.
4069 (matching_obj_sections): Likewise.
4070 (find_line_symtab): Change out parameter to bool.
4071 (producer_is_realview): Change return type to bool.
4072 (compare_filenames_for_search): Likewise.
4073 (compare_glob_filenames_for_search): Likewise.
4074
27a900b8
TT		 40752019-09-26 Tom Tromey <tom@tromey.com>
4076
4077 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4078 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4079 * gdb_usleep.h: Remove.
4080 * gdb_usleep.c: Remove.
4081 * utils.c: Don't include gdb_usleep.h.
4082
5d63b30a
TT		 40832019-09-26 Tom Tromey <tromey@adacore.com>
4084
4085 * python/py-type.c (type_to_type_object): Call check_typedef
4086 for stub types.
4087
12904d37
TT		 40882019-09-26 Tom Tromey <tom@tromey.com>
4089
4090 * utils.h (initialize_utils): Don't declare.
4091 * top.c (gdb_init): Don't call initialize_utils.
4092 * utils.c (initialize_utils): Remove. Move contents...
4093 (_initialize_utils): ... here.
4094
858f25f0
TT		 40952019-09-25 Tom Tromey <tom@tromey.com>
4096
4097 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4098 * utils.h (make_hex_string): Don't declare.
4099 * utils.c (make_hex_string): Remove.
4100
3d435220
TV		 41012019-09-24 Tom de Vries <tdevries@suse.de>
4102
4103 PR gdb/23815
4104 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4105 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4106
ddd44b70
DD		 41072019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4108
4109 * NEWS: Mention new simulator port for PRU.
4110
f945dedf
CB		 41112019-09-23 Christian Biesinger <cbiesinger@google.com>
4112
4113 * ada-exp.y (write_object_remaining): Update.
4114 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4115 and eliminate the static buffer.
4116 (ada_decode_symbol): Update.
4117 (ada_la_decode): Update.
4118 (ada_sniff_from_mangled_name): Update.
4119 (is_valid_name_for_wild_match): Update.
4120 (ada_lookup_name_info::matches): Update and simplify.
4121 (name_matches_regex): Update.
4122 (ada_add_global_exceptions): Update.
4123 * ada-lang.h (ada_decode): Update signature.
4124 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4125 * dwarf-index-write.c (debug_names::insert): Update.
4126
7ab78ccb
SM		 41272019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4128
4129 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4130 formatting.
4131
9252448b
SM		 41322019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4133
4134 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4135 Change "nonzero" to "true" in documentation.
4136
626ca2c0
CB		 41372019-09-20 Christian Biesinger <cbiesinger@google.com>
4138
4139 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4140 (_initialize_darwin_solib): Don't set
4141 darwin_so_ops.lookup_lib_global_symbol.
4142 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4143 set_gdbarch_iterate_over_objfiles_in_search_order.
4144 (elf_lookup_lib_symbol): Rename to...
4145 (svr4_iterate_over_objfiles_in_search_order): this, and update
4146 to iterate semantics.
4147 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4148 * solib.c (solib_global_lookup): Remove.
4149 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4150 (solib_global_lookup): Remove.
4151 * symtab.c (lookup_global_or_static_symbol): Remove call to
4152 solib_global_lookup.
4153
5a3a0d63
JB		 41542019-09-20 Joel Brobecker <brobecker@adacore.com>
4155
4156 * NEWS: Move entries about default MI version now being
4157 version 3, and about the GDB/MI fix for multi-location
4158 breakpoints to the "since GDB 8.3" section.
4159
ffea1427
JB		 41602019-09-20 Joel Brobecker <brobecker@adacore.com>
4161
4162 GDB 8.3.1 released.
4163
abf516c6
UW		 41642019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4165
4166 * NEWS: Mention that Cell/B.E. debugging support was removed.
4167 * MAINTAINERS: Remove spu target.
4168
4169 * config/djgpp/fnchange.lst: Remove entries for removed files.
4170
4171 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4172 spu-multiarch.o, and spu-tdep.o.
4173 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4174 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4175 spu-multiarch.c, and spu-tdep.c.
4176 * spu-linux-nat.c: Remove file.
4177 * spu-multiarch.c: Remove file.
4178 * spu-tdep.c: Remove file.
4179 * spu-tdep.h: Remove file.
4180 * solib-spu.c: Remove file.
4181 * solib-spu.h: Remove file.
4182
4183 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4184 * configure.nat (spu-linux): Remove.
4185 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4186 solib-multiarch.o from gdb_target_obs.
4187 (spu*-*-*): Remove.
4188
4189 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4190 feature flag.
4191 (ppc_linux_no_features): Update.
4192 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4193 Cell/B.E. support.
4194 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4195 (tdesc_powerpc_cell64l): Likewise.
4196 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4197 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4198 Cell/B.E. support.
4199 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4200 Do not include "features/rs6000/powerpc-cell32l.c" or
4201 "features/rs6000/powerpc-cell64l.c".
4202 (ppc_linux_spu_section): Remove.
4203 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4204 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4205 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4206 (ppc_linux_spe_context_lookup): Remove.
4207 (ppc_linux_spe_context_inferior_created): Remove.
4208 (ppc_linux_spe_context_solib_loaded): Remove.
4209 (ppc_linux_spe_context_solib_unloaded): Remove.
4210 (ppc_linux_spe_context): Remove.
4211 (struct ppu2spu_cache): Remove.
4212 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4213 (struct ppu2spu_data): Remove.
4214 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4215 ppu2spu_unwind): Remove.
4216 (ppc_linux_init_abi): Remove Cell/B.E. support.
4217 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4218
4219 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4220 (rs6000/powerpc-cell64l-expedite): Likewise
4221 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4222 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4223 rs6000/powerpc-cell64l.xml.
4224 * features/rs6000/powerpc-cell32l.xml: Remove.
4225 * features/rs6000/powerpc-cell64l.xml: Likewise.
4226 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4227 * features/rs6000/powerpc-cell64l.c: Likewise.
4228 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4229 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4230 * regformats/reg-spu.dat: Remove.
4231
4232 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4233 * corelow.c (struct spuid_list): Remove.
4234 (add_to_spuid_list): Remove.
4235 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4236 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4237 (remote_protocol_features): Remove associated entries.
4238 (_initialize_remote): No longer initialize them.
4239 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4240 * linux-nat.c (SPUFS_MAGIC): Remove.
4241 (linux_proc_xfer_spu): Remove.
4242 (spu_enumerate_spu_ids): Remove.
4243 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4244 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4245 (linux_make_corefile_notes): No longer call it.
4246
4247 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4248 (cooked_write_test): Likewise.
4249
78e8cb91
TT		 42502019-09-20 Tom Tromey <tom@tromey.com>
4251
4252 * NEWS: Mention case-sensitivity of TUI commands.
4253 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4254 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4255 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4256
f074b67e
TT		 42572019-09-20 Tom Tromey <tom@tromey.com>
4258
4259 * tui/tui-source.c (tui_source_window::set_contents): Use
4260 make_unique_xstrdup.
4261 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4262 make_unique_xstrdup.
4263
63c4bf19
TT		 42642019-09-20 Tom Tromey <tom@tromey.com>
4265
4266 * tui/tui-data.c: Remove separator comments.
4267 * tui/tui-layout.c: Remove separator comments.
4268 * tui/tui-win.c: Remove separator comments.
4269 * tui/tui-wingeneral.c: Remove separator comments.
4270
43df9b2f
TT		 42712019-09-20 Tom Tromey <tom@tromey.com>
4272
4273 * tui/tui.h (strcat_to_buf): Don't declare.
4274 * tui/tui.c (strcat_to_buf): Remove.
4275
7226433c
TT		 42762019-09-20 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4279 from "fullname".
4280 * tui/tui-source.c (tui_source_window::set_contents)
4281 (tui_source_window::location_matches_p)
4282 (tui_source_window::maybe_update): Update.
4283
80df3337
TT		 42842019-09-20 Tom Tromey <tom@tromey.com>
4285
4286 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4287 Update.
4288 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4289 prefix.
4290 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4291 (tui_data_window::line_from_reg_element_no)
4292 (tui_data_window::first_reg_element_no_inline)
4293 (tui_data_window::show_registers)
4294 (tui_data_window::show_register_group)
4295 (tui_data_window::display_registers_from)
4296 (tui_data_window::display_registers_from_line)
4297 (tui_data_window::first_data_item_displayed)
4298 (tui_data_window::delete_data_content_windows)
4299 (tui_data_window::erase_data_content)
4300 (tui_data_window::do_scroll_vertical)
4301 (tui_data_window::refresh_window)
4302 (tui_data_window::check_register_values): Update.
4303
9923f347
TT		 43042019-09-20 Tom Tromey <tom@tromey.com>
4305
4306 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4307 (struct tui_locator_window) <full_name, proc_name>: Now
4308 std::string.
4309 * tui/tui-stack.c (tui_locator_window::make_status_line)
4310 (tui_locator_window::set_locator_fullname)
4311 (tui_locator_window::set_locator_info): Update.
4312 * tui/tui-source.c (tui_source_window::set_contents)
4313 (tui_source_window::showing_source_p): Update.
4314
b76251ab
TT		 43152019-09-20 Tom Tromey <tom@tromey.com>
4316
4317 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4318 Don't call tui_locator_win_info_ptr.
4319
0891be08
TT		 43202019-09-20 Tom Tromey <tom@tromey.com>
4321
4322 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4323
1b935acf
TT		 43242019-09-20 Tom Tromey <tom@tromey.com>
4325
4326 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4327 height for locator.
4328 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4329 * tui/tui-layout.c (show_source_disasm_command, show_data)
4330 (show_source_or_disasm_and_command): Use 1 as height for locator.
4331
9abd8a65
TT		 43322019-09-20 Tom Tromey <tom@tromey.com>
4333
4334 * tui/tui.c (tui_enable): Update.
4335 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4336 Update.
4337 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4338 Update.
4339 * tui/tui-data.c (win_resized): Now bool.
4340 (tui_win_resized): Return bool.
4341 (tui_set_win_resized_to): Accept a bool.
4342
b5457826
TT		 43432019-09-20 Tom Tromey <tom@tromey.com>
4344
4345 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4346 Change type of "refresh_values_only".
4347 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4348 type of "refresh_values_only".
4349
6b915f7d
TT		 43502019-09-20 Tom Tromey <tom@tromey.com>
4351
4352 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4353 std::string.
4354 (tui_disassemble): Add "pos" parameter.
4355 (tui_disasm_window::set_contents): Simplify.
4356
2ad52f6f
TT		 43572019-09-20 Tom Tromey <tom@tromey.com>
4358
4359 * tui/tui-winsource.h (struct tui_source_window_base)
4360 <show_source_content>: Now private.
4361 * tui/tui-winsource.c
4362 (tui_source_window_base::show_source_content): Don't handle empty
4363 content case.
4364
b3b1bde6
TT		 43652019-09-20 Tom Tromey <tom@tromey.com>
4366
4367 * tui/tui-layout.c (show_source_disasm_command)
4368 (show_source_or_disasm_and_command): Don't call
4369 show_source_content.
4370
71a25ed2
TT		 43712019-09-20 Tom Tromey <tom@tromey.com>
4372
4373 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4374 Declare.
4375 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4376 from tui_make_status_line.
4377 (tui_locator_window::rerender): Update.
4378
f8532154
TT		 43792019-09-20 Tom Tromey <tom@tromey.com>
4380
4381 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4382 (tui_locator_window::rerender): Update.
4383
2d81b349
TT		 43842019-09-20 Tom Tromey <tom@tromey.com>
4385
4386 * tui/tui-winsource.h (struct tui_source_window_base)
4387 <~tui_source_window_base>: Don't declare.
4388 <fullname>: Remove.
4389 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4390 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4391 member.
4392 * tui/tui-source.c (tui_source_window::set_contents): Update.
4393 (tui_source_window::location_matches_p)
4394 (tui_source_window::maybe_update): Update.
4395
f14bec58
TT		 43962019-09-20 Tom Tromey <tom@tromey.com>
4397
4398 * tui/tui-winsource.h (~tui_source_element): Remove.
4399 (tui_source_element): Update.
4400 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4401 * tui/tui-winsource.c (tui_show_source_line): Update.
4402 * tui/tui-source.c (tui_source_window::set_contents): Update.
4403 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4404
78d5933a
TT		 44052019-09-20 Tom Tromey <tom@tromey.com>
4406
4407 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4408 declare.
4409 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4410 tui_clear_source_windows_detail.
4411 * tui/tui-winsource.h (struct tui_source_window_base)
4412 <clear_detail>: Don't declare.
4413 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4414 Remove.
4415 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4416
d4207696
TT		 44172019-09-20 Tom Tromey <tromey@adacore.com>
4418
4419 PR ada/24919:
4420 * block.c (contained_in): Fix final return value.
4421
00f93c44
AM		 44222019-09-20 Alan Modra <amodra@gmail.com>
4423
4424 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4425 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4426 (read_indirect_string_from_dwz): Use bfd accessor.
4427 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4428 * machoread.c (macho_symfile_read_all_oso): Likewise.
4429 * solib.c (solib_bfd_open): Likewise.
4430
e4153ae6
CB		 44312019-09-19 Christian Biesinger <cbiesinger@google.com>
4432
4433 * eval.c: Move declaration of overload_resolution to...
4434 * value.h: ...here.
4435
c7ae7675
CB		 44362019-09-19 Christian Biesinger <cbiesinger@google.com>
4437
4438 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4439 * arm-linux-tdep.c: Likewise.
4440 * arm-nbsd-nat.c: Likewise.
4441 * arm-tdep.h: Declare arm_apcs_32.
4442 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4443
e86f08d2
CB		 44442019-09-19 Christian Biesinger <cbiesinger@google.com>
4445
4446 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4447 * dwarf2read.h: Declare dwarf_always_disassemble.
4448
f64e2f40
TV		 44492019-09-19 Tom de Vries <tdevries@suse.de>
4450
4451 PR gdb/25009
4452 * source-cache.c (source_cache::ensure): Catch exception thrown during
4453 construction of the highlighter.
4454
fd361982
AM		 44552019-09-18 Alan Modra <amodra@gmail.com>
4456
4457 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4458 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4459 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4460 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4461 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4462 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4463 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4464 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4465 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4466 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4467 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4468 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4469 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4470 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4471 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4472 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4473 * mi/mi-interp.c: Update throughout for bfd section macro and
4474 function changes.
4475 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4476 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4477
11061048
TT		 44782019-09-18 Tom Tromey <tom@tromey.com>
4479
4480 * NEWS: Add entry.
4481 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4482 call rl_initialize.
4483 (tui_enable): Do not call rl_initialize.
4484
7a27b85f
CG		 44852019-09-18 Christian Groessler <chris@groessler.org>
4486
4487 * alpha-linux-nat.c: Include gdbarch.h.
4488
f64eea3a
SM		 44892019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4490
4491 * ui-file.c: Include cli/cli-style.h.
4492 (term_cli_styling): Remove cli_styling declaration.
4493
e6f7f6d1
AM		 44942019-09-18 Alan Modra <amodra@gmail.com>
4495
4496 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4497 to bfd_asymbol_section.
4498
1d38e9d1
AM		 44992019-09-18 Alan Modra <amodra@gmail.com>
4500
4501 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4502 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4503 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4504
90d92a63
AM		 45052019-09-18 Alan Modra <amodra@gmail.com>
4506
4507 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4508 * spu-linux-nat.c (spu_bfd_open): Likewise.
4509
a3d181d2
CB		 45102019-09-18 Christian Biesinger <cbiesinger@google.com>
4511
4512 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4513 to bool to match definition in dwarf2read.c.
4514
491144b5
CB		 45152019-09-17 Christian Biesinger <cbiesinger@google.com>
4516
4517 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4518 (print_signatures): Likewise.
4519 (trust_pad_over_xvs): Likewise.
4520 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4521 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4522 * arm-linux-nat.c (arm_apcs_32): Likewise.
4523 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4524 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4525 * arm-tdep.c (arm_debug): Likewise.
4526 (arm_apcs_32): Likewise.
4527 * auto-load.c (debug_auto_load): Likewise.
4528 (auto_load_gdb_scripts): Likewise.
4529 (global_auto_load): Likewise.
4530 (auto_load_local_gdbinit): Likewise.
4531 (auto_load_local_gdbinit_loaded): Likewise.
4532 * auto-load.h (global_auto_load): Likewise.
4533 (auto_load_local_gdbinit): Likewise.
4534 (auto_load_local_gdbinit_loaded): Likewise.
4535 * breakpoint.c (disconnected_dprintf): Likewise.
4536 (breakpoint_proceeded): Likewise.
4537 (automatic_hardware_breakpoints): Likewise.
4538 (always_inserted_mode): Likewise.
4539 (target_exact_watchpoints): Likewise.
4540 (_initialize_breakpoint): Update.
4541 * breakpoint.h (target_exact_watchpoints): Change to bool.
4542 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4543 * cli/cli-cmds.c (trace_commands): Likewise.
4544 * cli/cli-cmds.h (trace_commands): Likewise.
4545 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4546 to bool*.
4547 * cli/cli-logging.c (logging_overwrite): Change to bool.
4548 (logging_redirect): Likewise.
4549 (debug_redirect): Likewise.
4550 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4551 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4552 to bool.
4553 <boolean_option_def>: Update.
4554 (struct flag_option_def): Change default type of Context to bool
4555 from int.
4556 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4557 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4558 (get_setshow_command_value_string): Likewise.
4559 * cli/cli-style.c (cli_styling): Change to bool.
4560 (source_styling): Likewise.
4561 * cli/cli-style.h (source_styling): Likewise.
4562 (cli_styling): Likewise.
4563 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4564 to bool.
4565 * command.h (var_types): Update comment.
4566 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4567 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4568 bool.
4569 (debug_compile_cplus_scopes): Likewise.
4570 * compile/compile-internal.h (compile_debug): Likewise.
4571 * compile/compile.c (compile_debug): Likewise.
4572 (struct compile_options) <raw>: Likewise.
4573 * cp-support.c (catch_demangler_crashes): Likewise.
4574 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4575 (usr_cmd_cris_dwarf2_cfi): Likewise.
4576 * csky-tdep.c (csky_debug): Likewise.
4577 * darwin-nat.c (enable_mach_exceptions): Likewise.
4578 * dcache.c (dcache_enabled_p): Likewise.
4579 * defs.h (info_verbose): Likewise.
4580 * demangle.c (demangle): Likewise.
4581 (asm_demangle): Likewise.
4582 * dwarf-index-cache.c (debug_index_cache): Likewise.
4583 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4584 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4585 * dwarf2read.c (check_physname): Likewise.
4586 (use_deprecated_index_sections): Likewise.
4587 (dwarf_always_disassemble): Likewise.
4588 * eval.c (overload_resolution): Likewise.
4589 * event-top.c (set_editing_cmd_var): Likewise.
4590 (exec_done_display_p): Likewise.
4591 * event-top.h (set_editing_cmd_var): Likewise.
4592 (exec_done_display_p): Likewise.
4593 * exec.c (write_files): Likewise.
4594 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4595 (debug_fbsd_nat): Likewise.
4596 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4597 Likewise.
4598 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4599 <backtrace_past_entry> Likewise.
4600 * gdb-demangle.h (demangle): Likewise.
4601 (asm_demangle): Likewise.
4602 * gdb_bfd.c (bfd_sharing): Likewise.
4603 * gdbcore.h (write_files): Likewise.
4604 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4605 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4606 * gdbthread.h (print_thread_events): Likewise.
4607 * gdbtypes.c (opaque_type_resolution): Likewise.
4608 (strict_type_checking): Likewise.
4609 * gnu-nat.c (gnu_debug_flag): Likewise.
4610 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4611 * guile/scm-param.c (pascm_variable): Add boolval.
4612 (add_setshow_generic): Update.
4613 (pascm_param_value): Update.
4614 (pascm_set_param_value_x): Update.
4615 * hppa-tdep.c (hppa_debug): Change to bool..
4616 * infcall.c (may_call_functions_p): Likewise.
4617 (coerce_float_to_double_p): Likewise.
4618 (unwind_on_signal_p): Likewise.
4619 (unwind_on_terminating_exception_p): Likewise.
4620 * infcmd.c (startup_with_shell): Likewise.
4621 * inferior.c (print_inferior_events): Likewise.
4622 * inferior.h (startup_with_shell): Likewise.
4623 (print_inferior_events): Likewise.
4624 * infrun.c (step_stop_if_no_debug): Likewise.
4625 (detach_fork): Likewise.
4626 (debug_displaced): Likewise.
4627 (disable_randomization): Likewise.
4628 (non_stop): Likewise.
4629 (non_stop_1): Likewise.
4630 (observer_mode): Likewise.
4631 (observer_mode_1): Likewise.
4632 (set_observer_mode): Update.
4633 (sched_multi): Change to bool.
4634 * infrun.h (debug_displaced): Likewise.
4635 (sched_multi): Likewise.
4636 (step_stop_if_no_debug): Likewise.
4637 (non_stop): Likewise.
4638 (disable_randomization): Likewise.
4639 * linux-tdep.c (use_coredump_filter): Likewise.
4640 (dump_excluded_mappings): Likewise.
4641 * linux-thread-db.c (auto_load_thread_db): Likewise.
4642 (check_thread_db_on_load): Likewise.
4643 * main.c (captured_main_1): Update.
4644 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4645 xx2_opt, boolean_opt>: Change to bool.
4646 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4647 * maint.c (maintenance_profile_p): Likewise.
4648 (per_command_time): Likewise.
4649 (per_command_space): Likewise.
4650 (per_command_symtab): Likewise.
4651 * memattr.c (inaccessible_by_default): Likewise.
4652 * mi/mi-main.c (mi_async): Likewise.
4653 (mi_async_1): Likewise.
4654 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4655 * nat/fork-inferior.h (startup_with_shell): Likewise.
4656 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4657 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4658 * nios2-tdep.c (nios2_debug): Likewise.
4659 * or1k-tdep.c (or1k_debug): Likewise.
4660 * parse.c (parser_debug): Likewise.
4661 * parser-defs.h (parser_debug): Likewise.
4662 * printcmd.c (print_symbol_filename): Likewise.
4663 * proc-api.c (procfs_trace): Likewise.
4664 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4665 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4666 (set_parameter_value): Update.
4667 (add_setshow_generic): Update.
4668 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4669 to bool*.
4670 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4671 int*.
4672 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4673 * record-btrace.c (record_btrace_target::store_registers): Update.
4674 * record-full.c (record_full_memory_query): Change to bool.
4675 (record_full_stop_at_limit): Likewise.
4676 * record-full.h (record_full_memory_query): Likewise.
4677 * remote-notif.c (notif_debug): Likewise.
4678 * remote-notif.h (notif_debug): Likewise.
4679 * remote.c (use_range_stepping): Likewise.
4680 (interrupt_on_connect): Likewise.
4681 (remote_break): Likewise.
4682 * ser-tcp.c (tcp_auto_retry): Likewise.
4683 * ser-unix.c (serial_hwflow): Likewise.
4684 * skip.c (debug_skip): Likewise.
4685 * solib-aix.c (solib_aix_debug): Likewise.
4686 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4687 (spu_auto_flush_cache_p): Likewise.
4688 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4689 Likewise.
4690 (struct info_print_options) <quiet>: Likewise.
4691 * symfile-debug.c (debug_symfile): Likewise.
4692 * symfile.c (auto_solib_add): Likewise.
4693 (separate_debug_file_debug): Likewise.
4694 * symfile.h (auto_solib_add): Likewise.
4695 (separate_debug_file_debug): Likewise.
4696 * symtab.c (basenames_may_differ): Likewise.
4697 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4698 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4699 (struct info_types_options) <quiet>: Likewise.
4700 * symtab.h (demangle): Likewise.
4701 (basenames_may_differ): Likewise.
4702 * target-dcache.c (stack_cache_enabled_1): Likewise.
4703 (code_cache_enabled_1): Likewise.
4704 * target.c (trust_readonly): Likewise.
4705 (may_write_registers): Likewise.
4706 (may_write_memory): Likewise.
4707 (may_insert_breakpoints): Likewise.
4708 (may_insert_tracepoints): Likewise.
4709 (may_insert_fast_tracepoints): Likewise.
4710 (may_stop): Likewise.
4711 (auto_connect_native_target): Likewise.
4712 (target_stop_and_wait): Update.
4713 (target_async_permitted): Change to bool.
4714 (target_async_permitted_1): Likewise.
4715 (may_write_registers_1): Likewise.
4716 (may_write_memory_1): Likewise.
4717 (may_insert_breakpoints_1): Likewise.
4718 (may_insert_tracepoints_1): Likewise.
4719 (may_insert_fast_tracepoints_1): Likewise.
4720 (may_stop_1): Likewise.
4721 * target.h (target_async_permitted): Likewise.
4722 (may_write_registers): Likewise.
4723 (may_write_memory): Likewise.
4724 (may_insert_breakpoints): Likewise.
4725 (may_insert_tracepoints): Likewise.
4726 (may_insert_fast_tracepoints): Likewise.
4727 (may_stop): Likewise.
4728 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4729 (make_thread_apply_all_options_def_group): Change argument from int*
4730 to bool*.
4731 (thread_apply_all_command): Update.
4732 (print_thread_events): Change to bool.
4733 * top.c (confirm): Likewise.
4734 (command_editing_p): Likewise.
4735 (history_expansion_p): Likewise.
4736 (write_history_p): Likewise.
4737 (info_verbose): Likewise.
4738 * top.h (confirm): Likewise.
4739 (history_expansion_p): Likewise.
4740 * tracepoint.c (disconnected_tracing): Likewise.
4741 (circular_trace_buffer): Likewise.
4742 * typeprint.c (print_methods): Likewise.
4743 (print_typedefs): Likewise.
4744 * utils.c (debug_timestamp): Likewise.
4745 (sevenbit_strings): Likewise.
4746 (pagination_enabled): Likewise.
4747 * utils.h (sevenbit_strings): Likewise.
4748 (pagination_enabled): Likewise.
4749 * valops.c (overload_resolution): Likewise.
4750 * valprint.h (struct value_print_options) <prettyformat_arrays,
4751 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4752 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4753 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4754 Likewise.
4755 * windows-nat.c (new_console): Likewise.
4756 (cygwin_exceptions): Likewise.
4757 (new_group): Likewise.
4758 (debug_exec): Likewise.
4759 (debug_events): Likewise.
4760 (debug_memory): Likewise.
4761 (debug_exceptions): Likewise.
4762 (useshell): Likewise.
4763 * windows-tdep.c (maint_display_all_tib): Likewise.
4764 * xml-support.c (debug_xml): Likewise.
4765
f1b620e9
MG		 47662019-09-17 Mike Gulick <mgulick@mathworks.com>
4767
4768 * source.c (prepare_path_for_appending): New function.
4769 (openp): Make use of new function.
4770 (find_and_open_source): Search for the compilation directory and
4771 source file as a relative path beneath the directory search path.
4772
67f3ed6a
AB		 47732019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4774
4775 * source-cache.c (source_cache::get_line_charpos): Catch
4776 exceptions and return false, this matches the behaviour documented
4777 in the header file.
4778
74332189
JB		 47792019-09-17 Joel Brobecker <brobecker@adacore.com>
4780
4781 * ada-tasks.c (info_task): Remove quoting of the task's name.
4782
f2f24aa9
CB		 47832019-09-16 Christian Biesinger <cbiesinger@google.com>
4784
4785 * symfile.c (auto_solib_add): Replace comment with a reference
4786 to the header file.
4787
6a062a93
CB		 47882019-09-14 Christian Biesinger <cbiesinger@google.com>
4789
4790 * NEWS: Mention that gdb can now be compiled with Python 3
4791 on Windows.
4792
ec6c8338
AB		 47932019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4794
4795 * maint.c (maint_print_section_data::maint_print_section_data):
4796 Force use of 'float log10 (float)' by casting the argument to
4797 float.
4798
aa17805f
AB		 47992019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4800
4801 * maint.c: Add 'cmath' include.
4802 (struct maint_print_section_data): New structure.
4803 (print_section_index): New function.
4804 (print_bfd_section_info): Add header comment, small whitespace
4805 cleanup, and update to call new print_section_index function.
4806 (print_objfile_section_info): Likewise.
4807 (maint_obj_section_from_bfd_section): New function.
4808 (print_bfd_section_info_maybe_relocated): New function.
4809 (maintenance_info_sections): Add header comment, always use
4810 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4811
3dd9bb46
AB		 48122019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4813
4814 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4815 inner scope, add check that the objfile has psymtabs before
4816 checking psymtabs_addrmap.
4817 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4818
4993045d
PW		 48192019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4820
4821 * NEWS: Announce that Ada task names are now shown at more places,
4822 and between quotes (except in info task output).
4823 * gdb/ada-tasks.c (task_to_str): New function.
4824 (display_current_task_id): Call task_to_str.
4825 (task_command_1): Likewise.
4826 (print_ada_task_info): In non-mi mode, Properly align headers and data
4827 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4828
7a289707
RO		 48292019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4830
4831 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4832 prstatus.pr_lwp.pr_info instead of making it up.
4833
f2aec7f6
CB		 48342019-09-11 Christian Biesinger <cbiesinger@google.com>
4835
4836 * auto-load.c (auto_load_expand_dir_vars): Update.
4837 * defs.h (gdb_datadir): Change to std::string.
4838 (python_libdir): Likewise.
4839 (relocate_gdb_directory): Change return type to std::string.
4840 * guile/guile.c (gdbscm_data_directory): Update.
4841 (initialize_scheme_side): Update.
4842 * jit.c (jit_reader_dir): Change to std::string.
4843 (jit_reader_load_command): Update.
4844 * main.c (gdb_datadir): Change to std::string.
4845 (python_libdir): Likewise.
4846 (set_gdb_data_directory): Update.
4847 (relocate_path): Change to return std::string.
4848 (relocate_gdb_directory): Change to return std::string.
4849 (relocate_gdbinit_path_maybe_in_datadir): Update.
4850 (captured_main_1): Update.
4851 * python/python.c (do_start_initialization): Update.
4852 * top.c (show_gdb_datadir): Update.
4853 * xml-syscall.c (xml_init_syscalls_info): Update.
4854 (init_syscalls_info): Update.
4855
9224a013
CB		 48562019-09-11 Christian Biesinger <cbiesinger@google.com>
4857
4858 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4859 out of get_init_files.
4860 (get_init_files): Update.
4861
f48cd836
CB		 48622019-09-11 Christian Biesinger <cbiesinger@google.com>
4863
4864 * main.c (get_init_files): Change to use std::string.
4865 (captured_main_1): Update.
4866 (print_gdb_help): Update.
4867
9cab7ecd
AT		 48682019-09-11 Ali Tamur <tamur@google.com>
4869
4870 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4871 implementation.
4872
67547d89
CB		 48732019-09-11 Christian Biesinger <cbiesinger@google.com>
4874
4875 * dbxread.c (read_dbx_symtab): Update.
4876 * dwarf2read.c (load_partial_dies): Update.
4877 * mdebugread.c (parse_partial_symbols): Update.
4878 (handle_psymbol_enumerators): Update.
4879 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4880 * psymtab.c (add_psymbol_to_bcache): Likewise.
4881 (add_psymbol_to_list): Likewise.
4882 * symtab.c (symbol_set_names): Likewise.
4883 * symtab.h (symbol_set_names): Likewise.
4884 * xcoffread.c (scan_xcoff_symtab): Update.
4885
64b2d4a0
TT		 48862019-09-11 Tom Tromey <tom@tromey.com>
4887
4888 * symfile-mem.c (symbol_file_add_from_memory): Use
4889 bfd_set_filename.
4890 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4891 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4892
3b00ef10
TT		 48932019-09-10 Tom Tromey <tromey@adacore.com>
4894
4895 * dwarf-index-write.c (write_psymbols): Extend error message.
4896 (debug_names::insert): Add Ada code.
4897 (debug_names::write_psymbols): Remove Ada check.
4898 (debug_names) <m_string_obstack>: New member.
4899 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4900 (gdb_index_symbol_name_matcher::matches): Remove.
4901 (mapped_index_base::find_name_components_bounds): Add "lang"
4902 parameter.
4903 (mapped_index_base::build_name_components): Also split names
4904 according to Ada syntax.
4905 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4906 type of "match_callback".
4907 (check_match, check_find_bounds_finds)
4908 (dw2_expand_symtabs_matching): Update.
4909 (dw2_debug_names_iterator): Add new constructor.
4910 (dw2_debug_names_map_matching_symbols): New function.
4911 (dw2_debug_names_expand_symtabs_matching): Update.
4912 (dwarf2_debug_names_functions): Use
4913 dw2_debug_names_map_matching_symbols.
4914
aa391654
TT		 49152019-09-10 Tom Tromey <tromey@adacore.com>
4916
4917 * dwarf2read.c (dw2_get_file_names_reader): Add the
4918 CU's file name to the results.
4919
b054970d
TT		 49202019-09-10 Tom Tromey <tromey@adacore.com>
4921
4922 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4923 map_matching_symbols. Update.
4924 * dwarf2read.c (dw2_map_matching_symbols): Update.
4925 * psymtab.c (match_partial_symbol): Change type; update.
4926 (psym_map_matching_symbols): Likewise.
4927 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4928 type; update.
4929 * symfile.h (struct quick_symbol_functions)
4930 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4931 Remove "match".
4932
6a3dbf1b
TT		 49332019-09-10 Tom Tromey <tromey@adacore.com>
4934
4935 * psymtab.c (map_block): Remove.
4936 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4937 * symtab.c (iterate_over_symbols_terminated): New function.
4938 * symtab.c (iterate_over_symbols_terminated): Declare.
4939
6969f124
TT		 49402019-09-10 Tom Tromey <tromey@adacore.com>
4941
4942 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4943 * language.h (struct language_defn) <la_iterate_over_symbols>:
4944 Return bool.
4945 * symtab.c (iterate_over_symbols): Return bool.
4946 * symtab.h (iterate_over_symbols): Return bool.
4947
199b4314
TT		 49482019-09-10 Tom Tromey <tromey@adacore.com>
4949
4950 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4951 (add_nonlocal_symbols): Update.
4952 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4953 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4954 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4955 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4956 Change type of "callback". Remove "data".
4957
a084a2a6
AT		 4958
49592019-09-09 Ali Tamur <tamur@google.com>
4960
4961 * dwarf2read.c (comp_unit_head): Update comment.
4962 (dwarf2_dwo_name): New function declaration.
4963 (dwarf_unit_type_name): New function declaration.
4964 (read_comp_unit_head): Add support for new compilation units,
4965 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4966 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4967 (currently named as "signature") in their header. Also clarify error
4968 messages.
4969 (lookup_dwo_id): New function. Returns the dwo id of the given
4970 compile unit.
4971 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4972 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4973 functions.
4974 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4975 (dwarf2_dwo_name): Get the dwo name if present.
4976 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4977 purposes.
4978
25a2915e
TT		 49792019-09-09 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4982
e4df0874
PW		 49832019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4984
4985 * python/python.c (do_start_initialization): Make progname_copy static,
4986 to avoid a leak report.
4987
8634b462
TT		 49882019-09-08 Tom Tromey <tom@tromey.com>
4989
4990 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4991
c7f839cb
SM		 49922019-09-07 Simon Marchi <simon.marchi@efficios.com>
4993
4994 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4995 Change type to gdb::optional<block_enum>.
4996 (dw2_symtab_iter_init): Change block_index parameter type
4997 to gdb::optional<block_enum>.
4998 (dw2_lookup_symbol): Change block_index parameter
4999 type to block_enum.c
5000 (dw2_debug_names_lookup_symbol): Likewise.
5001 * psymtab.c (psym_lookup_symbol): Likewise.
5002 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5003 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5004 Likewise.
5005
ead0e69a
CB		 50062019-09-06 Christian Biesinger <cbiesinger@google.com>
5007
5008 * defs.h (relocate_gdb_directory): Change int to bool in
5009 signature and rename flag to relocatable.
5010 * main.c (relocate_path): Likewise.
5011 (relocate_gdb_directory): Likewise.
5012
b16c44de
AM		 50132019-09-06 Alan Modra <amodra@gmail.com>
5014
5015 * coffread.c (coff_symfile_read): Constify filename variable.
5016 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5017 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5018 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5019 * solib.c (reload_shared_libraries_1): Likewise.
5020 * symfile.c (reread_symbols): Likewise.
5021 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5022 * solib-darwin.c (darwin_bfd_open): Likewise.
5023 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5024
06ff036e
AB		 50252019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5026
5027 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5028 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5029
4e962e74
TT		 50302019-09-03 Tom Tromey <tromey@adacore.com>
5031
5032 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5033 types.
5034 (has_negatives): Unbias a range type bound.
5035 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5036 * gdbtypes.c (operator==): Handle new field.
5037 (create_range_type): Add "bias" parameter.
5038 (create_static_range_type, resolve_dynamic_range): Update.
5039 * gdbtypes.h (struct range_bounds) <bias>: New member.
5040 (create_range_type): Add bias parameter.
5041 * printcmd.c (print_scalar_formatted): Unbias range types.
5042 * value.c (unpack_long): Unbias range types.
5043 (pack_long): Bias range types.
5044
d90b8f26
AH		 50452019-09-02 Alan Hayward <alan.hayward@arm.com>
5046
5047 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5048 probe arguments.
5049
fe01123e
AH		 50502019-09-02 Alan Hayward <alan.hayward@arm.com>
5051
5052 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5053 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5054 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5055 (compile_probe_arg): Likewise.
5056 * probe.h (get_argument_count): Likewise.
5057 * solib-svr4.c (solib_event_probe_action): Likewise.
5058 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5059
e661ef01
AH		 50602019-09-02 Alan Hayward <alan.hayward@arm.com>
5061
5062 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5063 code to here...
5064 (svr4_create_solib_event_breakpoints): ...from here.
5065
47a536d9
SDJ		 50662019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5067
5068 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5069 suffix from warning message.
5070
d6a00eba
TT		 50712019-08-30 Tom Tromey <tom@tromey.com>
5072
5073 * tui/tui-winsource.h (struct tui_source_window_base)
5074 <refresh_all>: Don't declare.
5075 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5076 Remove.
5077 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5078 tui_show_locator_content.
5079 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5080 declare.
5081 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5082 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5083 declare.
5084
55b2657b
TT		 50852019-08-30 Tom Tromey <tom@tromey.com>
5086
5087 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5088
12a8555a
TT		 50892019-08-30 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5092 Remove unnecessary forward declarations.
5093
900ac242
TT		 50942019-08-30 Tom Tromey <tom@tromey.com>
5095
5096 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5097 rerender.
5098 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5099 tui_show_locator_content.
5100
99ab33fb
TT		 51012019-08-30 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5104 (tui_locator_window::rerender): Rewrite using body of previous
5105 tui_show_locator_content.
5106
e594a5d1
TT		 51072019-08-30 Tom Tromey <tom@tromey.com>
5108
5109 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5110 set_locator_fullname>: New methods.
5111 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5112 Rename from tui_set_locator_fullname.
5113 (tui_locator_window::set_locator_info): Rename from
5114 tui_set_locator_info. Return bool.
5115 (tui_update_locator_fullname, tui_show_frame_info): Update.
5116
715bb467
TT		 51172019-08-30 Tom Tromey <tom@tromey.com>
5118
5119 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5120
772f3f03
TT		 51212019-08-30 Tom Tromey <tom@tromey.com>
5122
5123 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5124 call touchwin.
5125
108e13ab
TT		 51262019-08-30 Tom Tromey <tom@tromey.com>
5127
5128 * tui/tui-wingeneral.c (box_win): Assume win_info and
5129 win_info->handle cannot be NULL.
5130
cdaa6eb4
TT		 51312019-08-30 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5134 refresh_window>: Declare.
5135 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5136 resize.
5137 (tui_data_item_window::rerender): Rename from
5138 tui_display_register.
5139 (tui_data_item_window::refresh_window): New method.
5140 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5141 no-op.
5142
89df7f90
TT		 51432019-08-30 Tom Tromey <tom@tromey.com>
5144
5145 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5146 regs_column_count, current_group>: Move later. Now private.
5147 <get_current_group>: New method.
5148 * tui/tui-regs.c (tui_reg_command): Update.
5149 * tui/tui-layout.c (tui_set_layout): Update.
5150
1bf2866a
TT		 51512019-08-30 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5154 (tui_data_window::rerender): Don't call
5155 check_and_display_highlight_if_needed.
5156 (tui_data_window::refresh_all): Remove call to
5157 erase_data_content.
5158
0670413d
TT		 51592019-08-30 Tom Tromey <tom@tromey.com>
5160
5161 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5162 (tui_data_window::display_registers_from)
5163 (tui_data_window::display_reg_element_at_line)
5164 (tui_data_window::display_registers_from_line): Remove checks of
5165 "empty".
5166
18bb55c7
TT		 51672019-08-30 Tom Tromey <tom@tromey.com>
5168
5169 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5170 Don't declare.
5171 * tui/tui-regs.c (tui_data_window::show_registers): Call
5172 rerender.
5173 (tui_data_window::rerender): Rename from display_all_data.
5174 (tui_data_window::rerender): Remove old implementation.
5175
1f6d2f10
TT		 51762019-08-30 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5179 text.
5180 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5181
16d01f9c
BW		 51822019-08-29 Bernhard Wodok <barto@gmx.net>
5183 Sergio Durigan Junior <sergiodj@redhat.com>
5184
5185 PR win32/24284
5186 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5187
d8f27c60
AB		 51882019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5189
5190 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5191 when searching for types.
5192
1f20c35e
AB		 51932019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5194
5195 * f-lang.c (f_language_defn): Use f_print_typedef.
5196 * f-lang.h (f_print_typedef): Declare.
5197 * f-typeprint.c (f_print_typedef): Define.
5198
550105b7
CB		 51992019-08-27 Christian Biesinger <cbiesinger@google.com>
5200
5201 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5202
4acfdd20
AB		 52032019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5204
5205 * cli/cli-utils.c (info_print_options_defs): Delete.
5206 (make_info_print_options_def_group): Delete.
5207 (extract_info_print_options): Delete.
5208 (info_print_command_completer): Delete.
5209 (info_print_args_help): Add extra parameter, and optionally
5210 include text about -n flag.
5211 * cli/cli-utils.h (struct info_print_options): Delete.
5212 (extract_info_print_options): Delete declaration.
5213 (info_print_command_completer): Delete declaration.
5214 (info_print_args_help): Add extra parameter, extend header
5215 comment.
5216 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5217 search_symbols.
5218 * stack.c (struct info_print_options): New type.
5219 (info_print_options_defs): New file scoped variable.
5220 (make_info_print_options_def_group): New static function.
5221 (info_print_command_completer): New static function.
5222 (info_locals_command): Update to use new local functions.
5223 (info_args_command): Likewise.
5224 (_initialize_stack): Add extra parameter to calls to
5225 info_print_args_help.
5226 * symtab.c (search_symbols): Add extra parameter, use this to
5227 possibly excluse non-debug symbols.
5228 (symtab_symbol_info): Add extra parameter, which is passed on to
5229 search_symbols.
5230 (struct info_print_options): New type.
5231 (info_print_options_defs): New file scoped variable.
5232 (make_info_print_options_def_group): New static function.
5233 (info_print_command_completer): New static function.
5234 (info_variables_command): Update to use local functions, and pass
5235 extra parameter through to symtab_symbol_info.
5236 (info_functions_command): Likewise.
5237 (info_types_command): Pass additional argument through to
5238 symtab_symbol_info.
5239 (rbreak_command): Pass extra argument to search_symbols.
5240 (_initialize_symtab): Add extra arguments for calls to
5241 info_print_args_help, and update help text for 'info variables',
5242 'whereis', and 'info functions' commands.
5243 * symtab.h (search_symbols): Add extra argument to declaration.
5244 * NEWS: Mention new flags.
5245
9aa55206
CB		 52462019-08-26 Christian Biesinger <cbiesinger@google.com>
5247
5248 * symtab.c (lookup_static_symbol): Call the new function (and move
5249 it down to be next to lookup_global_symbol).
5250 (struct global_sym_lookup_data): Add block_enum member and rename to...
5251 (struct global_or_static_sym_lookup_data): ...this.
5252 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5253 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5254 (lookup_symbol_global_or_static_iterator_cb): ...this.
5255 (lookup_global_or_static_symbol): New function.
5256 (lookup_global_symbol): Call new function.
5257
5c31b358
TV		 52582019-08-26 Tom de Vries <tdevries@suse.de>
5259
5260 PR c++/24852
5261 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5262 when pc_probe.prob == NULL.
5263
23c13d42
SM		 52642019-08-25 Simon Marchi <simon.marchi@efficios.com>
5265
5266 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5267 variable symbol_linkage to symbol_linkage_.
5268
beadd3e8
SM		 52692019-08-25 Simon Marchi <simon.marchi@efficios.com>
5270
5271 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5272 represent whether the symbol is static, dynamic, or we don't
5273 know.
5274
e3ec872f
YS		 52752019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5276
5277 * gdb/rx-tdep.c (rx_register_names): New.
5278 (rx_register_name): Delete.
5279 (rx_psw_type): Delete.
5280 (rx_fpsw_type): Delete.
5281 (rx_register_type): Delete.
5282 (rx_gdbarch_init): Convert target-descriptions.
5283 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5284 * gdb/features/Makefile: Add rx.xml.
5285 * gdb/features/rx.xml: New.
5286 * gdb/features/rx.c: Generated.
5287 * gdb/NEWS: Mention target description support.
5288
d0509ba4
CB		 52892019-08-22 Christian Biesinger <cbiesinger@google.com>
5290
5291 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5292 *slot_ptr.
5293
2d41fa11
SDJ		 52942019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5295
5296 * configure.ac: Don't check for 'dlfcn.h' (moved to
5297 gdbsupport/common.m4).
5298 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5299 'gdbsupport/'.
5300 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5301 * compile/compile-c-support.c: Include
5302 'gdbsupport/gdb-dlfcn.h'.
5303 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5304 * gdb-dlfcn.c: Move to...
5305 * gdbsupport/gdb-dlfcn.c: ... here.
5306 * gdb-dlfcn.h: Move to...
5307 * gdbsupport/gdb-dlfcn.h: ... here.
5308
de8af808
SL		 53092019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5310
5311 * nios2-tdep.c (struct reg_value): Improve comments. Make
5312 the offset field signed.
5313
27204489
CB		 53142019-08-22 Christian Biesinger <cbiesinger@google.com>
5315
5316 * python/lib/gdb/__init__.py (_execute_file): New function.
5317 * python/python.c (python_run_simple_file): Call gdb._execute_file
5318 on Windows.
5319
43771869
AB		 53202019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5321
5322 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5323 all uses as this was never set to anything but a zero value.
5324
26c957f1
PA		 53252019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5326
5327 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5328
c07aae6e
CB		 53292019-08-21 Christian Biesinger <cbiesinger@google.com>
5330
5331 * tui/tui-data.h (tui_gen_win_info): Add an =default
5332 move constructor, required by some GCC versions.
5333
3960cb7a
JF		 53342019-08-21 Jinke Fan <fanjinke51@yeah.net>
5335
5336 * go32-nat.c (go32_sysinfo): Add hygon_p.
5337
04c72a68
TT		 53382019-08-20 Tom Tromey <tom@tromey.com>
5339
5340 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5341 line_from_reg_element_no, first_reg_element_no_inline,
5342 display_all_data, delete_data_content_windows,
5343 erase_data_content>: Now private.
5344
072272ce
TT		 53452019-08-20 Tom Tromey <tom@tromey.com>
5346
5347 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5348 (tui_unhighlight_win, tui_highlight_win)
5349 (tui_win_info::make_window): Update.
5350 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5351
973961bd
TT		 53522019-08-20 Tom Tromey <tom@tromey.com>
5353
5354 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5355 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5356 (MAX_PID_WIDTH): Move to tui-stack.c.
5357 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5358 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5359 (MAX_PID_WIDTH): Move from tui-data.h.
5360
ab0e1f1a
TT		 53612019-08-20 Tom Tromey <tom@tromey.com>
5362
5363 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5364 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5365 (box_win): Update.
5366 (tui_gen_win_info::make_window): Rename from tui_make_window.
5367 (tui_win_info::make_window): New method.
5368 (tui_gen_win_info::make_visible): Update.
5369 * tui/tui-source.c (tui_source_window::set_contents): Update.
5370 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5371 (tui_data_window::display_registers_from): Update.
5372 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5373 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5374 Declare.
5375 <can_box>: Remove.
5376 <title>: Remove.
5377 (struct tui_win_info) <make_window>: Declare.
5378 <can_box>: Now virtual.
5379 <title>: New member.
5380 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5381 * tui/tui-command.c (tui_cmd_window::resize): Update.
5382
100c2bf3
TT		 53832019-08-20 Tom Tromey <tom@tromey.com>
5384
5385 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5386 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5387 (tui_data_window::check_register_values): Update.
5388
fa4dc567
TT		 53892019-08-20 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-regs.h (struct tui_data_window): Use
5392 DISABLE_COPY_AND_ASSIGN.
5393 <regs_content>: Change type, removing unique_ptr.
5394 <tui_data_window>: Add move constructor.
5395 * tui/tui-regs.c (tui_data_window::show_registers)
5396 (tui_data_window::show_register_group)
5397 (tui_data_window::display_registers_from)
5398 (tui_data_window::display_registers_from)
5399 (tui_data_window::first_data_item_displayed)
5400 (tui_data_window::delete_data_content_windows)
5401 (tui_data_window::rerender, tui_data_window::refresh_window)
5402 (tui_data_window::check_register_values): Update.
5403
ca02d7c8
TT		 54042019-08-20 Tom Tromey <tom@tromey.com>
5405
5406 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5407 show_register_group>: Declare.
5408 (tui_show_register_group): Don't declare.
5409 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5410 tui_show_registers.
5411 (tui_data_window::show_register_group): Rename from
5412 tui_show_register_group.
5413 (tui_data_window::check_register_values, tui_reg_command):
5414 Update.
5415 * tui/tui-layout.c (tui_set_layout): Update.
5416
63356bfd
TT		 54172019-08-20 Tom Tromey <tom@tromey.com>
5418
5419 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5420 Declare.
5421 (tui_check_register_values): Don't declare.
5422 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5423 from tui_check_register_values.
5424 * tui/tui-hooks.c (tui_register_changed): Update.
5425
42cc14a7
TT		 54262019-08-20 Tom Tromey <tom@tromey.com>
5427
5428 * tui/tui-regs.c (tui_reg_layout): Move later.
5429 (tui_show_registers): Don't enable TUI mode or change layout.
5430
b9ad3686
TT		 54312019-08-20 Tom Tromey <tom@tromey.com>
5432
5433 * tui/tui-regs.h (struct tui_data_item_window)
5434 <~tui_data_item_window>: Remove.
5435 <content>: Now a unique_xmalloc_ptr.
5436 * tui/tui-regs.c (tui_register_format): Return a
5437 unique_xmalloc_ptr.
5438 (tui_get_register): Update.
5439 (~tui_data_item_window): Remove.
5440 (tui_data_window::display_registers_from, tui_display_register):
5441 Update.
5442 * tui/tui-io.h (tui_expand_tabs): Update.
5443 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5444 Remove "col" parameter.
5445
8e114aab
TT		 54462019-08-20 Tom Tromey <tom@tromey.com>
5447
5448 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5449 field.
5450 * tui/tui-regs.c (~tui_data_item_window): Update.
5451
1a4f81dd
TT		 54522019-08-20 Tom Tromey <tom@tromey.com>
5453
5454 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5455 earlier.
5456
0f8d8876
TT		 54572019-08-20 Tom Tromey <tom@tromey.com>
5458
5459 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5460
605dc2c2
TT		 54612019-08-20 Tom Tromey <tom@tromey.com>
5462
5463 * tui/tui-source.h (struct tui_source_window): Update.
5464 * tui/tui-regs.c (tui_show_registers): Update.
5465 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5466 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5467 (NO_REGS_STRING): Remove defines.
5468
aedbe3bb
CM		 54692019-08-20 Conrad Meyer <cem@FreeBSD.org>
5470
5471 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5472 unnecessary thread walk if remote doesn't support the packet.
5473
7ce8f214
TT		 54742019-08-19 Tom Tromey <tromey@adacore.com>
5475
5476 * python/py-value.c (value_has_field): Fix indentation.
5477
f21c2bd7
TT		 54782019-08-19 Tom Tromey <tromey@adacore.com>
5479
5480 * printcmd.c (do_one_display, info_display_command): Update.
5481 * block.h (contained_in): Return bool. Add allow_nested
5482 parameter.
5483 * block.c (contained_in): Return bool. Add allow_nested
5484 parameter.
5485
d806ea2d
TT		 54862019-08-19 Tom Tromey <tom@tromey.com>
5487
5488 * configure: Rebuild.
5489 * configure.ac: Disallow the combination of -static-libstdc++ and
5490 source highlight.
5491 * source-cache.c (get_language_name): Handle rust.
5492 (source_cache::get_source_lines): Ignore highlighting exceptions.
5493
398fdd60
TT		 54942019-08-16 Tom Tromey <tom@tromey.com>
5495
5496 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5497 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5498 (struct tui_source_window_base) <make_visible, refresh_window,
5499 resize>: Remove methods.
5500 <execution_info>: Remove field.
5501 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5502 (tui_show_source_line, tui_source_window_base)
5503 (~tui_source_window_base): Update.
5504 (tui_source_window_base::resize)
5505 (tui_source_window_base::make_visible)
5506 (tui_source_window_base::refresh_window): Remove.
5507 (tui_source_window_base::update_exec_info): Update.
5508 * tui/tui-source.c (tui_source_window::set_contents): Update.
5509 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5510
e699d331
TT		 55112019-08-16 Tom Tromey <tom@tromey.com>
5512
5513 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5514 deprecated_query_hook.
5515
bb01dbfc
TT		 55162019-08-16 Tom Tromey <tom@tromey.com>
5517
5518 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5519 (tui_update_source_windows_with_line): Update.
5520 * tui/tui-source.h (struct tui_source_window)
5521 <show_symtab_source>: Declare.
5522 (tui_show_symtab_source): Don't declare.
5523 * tui/tui-source.c (tui_show_symtab_source): Rename from
5524 tui_show_symtab_source.
5525
81c82c4b
TT		 55262019-08-16 Tom Tromey <tom@tromey.com>
5527
5528 * tui/tui-winsource.h (struct tui_source_window_base)
5529 <set_contents>: Declare.
5530 * tui/tui-winsource.c
5531 (tui_source_window_base::update_source_window_as_is): Update.
5532 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5533 Declare.
5534 (tui_set_source_content): Don't declare.
5535 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5536 tui_set_source_content.
5537 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5538 Declare.
5539 (tui_set_disassem_content): Don't declare.
5540 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5541 tui_set_disassem_content.
5542
2ddaf614
TT		 55432019-08-16 Tom Tromey <tom@tromey.com>
5544
5545 * tui/tui-winsource.h (struct tui_source_window_base)
5546 <update_breakpoint_info>: Declare.
5547 (tui_update_breakpoint_info): Don't declare.
5548 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5549 (tui_update_all_breakpoint_info): Update.
5550 (tui_source_window_base::update_breakpoint_info): Rename from
5551 tui_update_breakpoint_info.
5552 (tui_source_window_base::update_exec_info): Update.
5553
017f9828
TT		 55542019-08-16 Tom Tromey <tom@tromey.com>
5555
5556 * tui/tui-winsource.h (struct tui_source_window_base)
5557 <update_source_window>: Declare.
5558 (tui_update_source_window): Don't declare.
5559 * tui/tui-winsource.c
5560 (tui_source_window_base::update_source_window): Rename from
5561 tui_update_source_window.
5562 (tui_source_window_base::rerender): Update.
5563 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5564 * tui/tui-disasm.c (tui_show_disassem)
5565 (tui_show_disassem_and_update_source)
5566 (tui_disasm_window::maybe_update): Update.
5567
ed8358e9
TT		 55682019-08-16 Tom Tromey <tom@tromey.com>
5569
5570 * tui/tui-winsource.h (struct tui_source_window_base)
5571 <update_source_window_as_is>: Declare.
5572 (tui_update_source_window_as_is): Don't declare.
5573 * tui/tui-winsource.c (tui_update_source_window): Update
5574 (tui_source_window_base::update_source_window_as_is): Rename from
5575 tui_update_source_window_as_is.
5576 (tui_source_window_base::refill): Update.
5577 * tui/tui-source.c (tui_show_symtab_source): Update.
5578 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5579 Update.
5580
20149b6b
TT		 55812019-08-16 Tom Tromey <tom@tromey.com>
5582
5583 * tui/tui-winsource.h (tui_update_source_window)
5584 (tui_update_source_window_as_is): Remove "noerror" parameter.
5585 * tui/tui-winsource.c (tui_update_source_window)
5586 (tui_update_source_window_as_is): Remove "noerror" parameter.
5587 (tui_update_source_windows_with_addr)
5588 (tui_update_source_windows_with_line)
5589 (tui_source_window_base::rerender)
5590 (tui_source_window_base::refill): Update.
5591 * tui/tui-source.h (tui_set_source_content)
5592 (tui_show_symtab_source): Remove "noerror" parameter.
5593 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5594 parameter.
5595 (tui_show_symtab_source): Likewise.
5596 (tui_source_window::maybe_update): Update.
5597 * tui/tui-disasm.c (tui_show_disassem)
5598 (tui_show_disassem_and_update_source)
5599 (tui_disasm_window::do_scroll_vertical)
5600 (tui_disasm_window::maybe_update): Update.
5601
2d83e710
TT		 56022019-08-16 Tom Tromey <tom@tromey.com>
5603
5604 * tui/tui.c (tui_is_window_visible): Update.
5605 * tui/tui-wingeneral.c (tui_make_window)
5606 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5607 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5608 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5609 (tui_set_win_height_command, parse_scrolling_args): Update.
5610 * tui/tui-source.c (tui_source_window::style_changed): Update.
5611 * tui/tui-regs.c (tui_show_registers)
5612 (tui_data_window::first_data_item_displayed)
5613 (tui_data_window::delete_data_content_windows)
5614 (tui_check_register_values, tui_reg_command): Update.
5615 * tui/tui-disasm.c (tui_show_disassem): Update.
5616 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5617 method.
5618 <is_visible>: Remove field.
5619 * tui/tui-data.c (tui_next_win, tui_prev_win)
5620 (tui_delete_invisible_windows): Update.
5621
d4ab829a
TT		 56222019-08-16 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-winsource.h (struct tui_source_window_base)
5625 <m_has_locator>: Remove.
5626 * tui/tui-layout.c (show_source_disasm_command, show_data)
5627 (show_source_or_disasm_and_command): Update.
5628
aa7ca1bb
AH		 56292019-08-16 Alan Hayward <alan.hayward@arm.com>
5630
5631 * NEWS (Other MI changes): New subsection.
5632 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5633 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5634 * arch-utils.c (default_get_pc_address_flags): New function.
5635 * arch-utils.h (default_get_pc_address_flags): New declaration.
5636 * gdbarch.sh: Add get_pc_address_flags.
5637 * gdbarch.c: Regenerate.
5638 * gdbarch.h: Likewise.
5639 * stack.c (print_pc): New function.
5640 (print_frame_info) (print_frame): Call print_pc.
5641
6eac171f
TV		 56422019-08-16 Tom de Vries <tdevries@suse.de>
5643
5644 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5645 print_objfile_section_info.
5646
3df505f6
TT		 56472019-08-15 Tom Tromey <tom@tromey.com>
5648
5649 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5650 calling update_cmdwin_start_line.
5651 * tui/tui-winsource.h (struct tui_source_window_base)
5652 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5653 <rerender>: Declare.
5654 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5655 Call rerender.
5656 (tui_source_window_base::set_new_height): Remove.
5657 (tui_source_window_base::rerender): Rename from
5658 do_make_visible_with_new_height.
5659 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5660 resize method.
5661 (tui_win_info::make_invisible_and_set_new_height)
5662 (tui_win_info::make_visible_with_new_height): Remove.
5663 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5664 Declare.
5665 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5666 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5667 do_make_visible_with_new_height>: Don't declare.
5668 <rerender>: Declare.
5669 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5670 set_new_height.
5671 (tui_data_window::do_make_visible_with_new_height): Remove.
5672 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5673 call tui_show_locator_content.
5674 (tui_gen_win_info::resize): Call rerender.
5675 (show_source_or_disasm_and_command): Don't call
5676 tui_show_locator_content.
5677 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5678 method.
5679 (struct tui_win_info) <rerender>: Declare.
5680 <set_new_height, make_invisible_and_set_new_height,
5681 make_visible_with_new_height>: Don't declare.
5682 * tui/tui-data.c (tui_win_list::rerender): New method.
5683 * tui/tui-command.h (struct tui_cmd_window)
5684 <do_make_visible_with_new_height>: Don't declare.
5685 * tui/tui-command.c
5686 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5687
272560b5
TT		 56882019-08-15 Tom Tromey <tromey@adacore.com>
5689
5690 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5691 * ada-lang.c (ada_enum_name): Likewise.
5692
08235187
CB		 56932019-08-15 Christian Biesinger <cbiesinger@google.com>
5694
5695 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5696 leading underscore.
5697 (GdbOutputErrorFile): Likewise.
5698 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5699 accordingly.
5700 (execute_unwinders): Rename to have a leading underscore.
5701 (auto_load_packages): Likewise.
5702 (global scope): Adjust call to auto_load_packages accordingly.
5703 (GdbSetPythonDirectory): Likewise.
5704 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5705 instead of execute_unwinders.
5706
db502012
TT		 57072019-08-15 Tom Tromey <tom@tromey.com>
5708
5709 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5710 (show_data): Don't change window visibility.
5711 (tui_gen_win_info::resize): Remove special case for command
5712 window. Use wresize, when available.
5713 (show_source_or_disasm_and_command): Don't change window
5714 visibility.
5715 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5716 <make_visible>: New method.
5717 * tui/tui-command.c (tui_cmd_window::resize): New method.
5718
3891b65e
TT		 57192019-08-15 Tom Tromey <tom@tromey.com>
5720
5721 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5722 (struct tui_source_windows): New.
5723 * tui/tui-winsource.c (tui_display_main): Update.
5724 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5725 (new_height_ok, parse_scrolling_args): Update.
5726 * tui/tui-layout.c (show_layout, show_data): Update.
5727 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5728 (tui_add_to_source_windows): Don't declare.
5729 * tui/tui-data.c (source_windows, tui_source_windows)
5730 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5731
ee556432
TT		 57322019-08-15 Tom Tromey <tom@tromey.com>
5733
5734 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5735 Rename from reset.
5736 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5737 * tui/tui-layout.c (show_source_disasm_command, show_data):
5738 Update.
5739 (tui_gen_win_info::resize): Rename.
5740 (show_source_or_disasm_and_command): Update.
5741 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5742 reset.
5743
46f438e3
TT		 57442019-08-15 Tom Tromey <tom@tromey.com>
5745
5746 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5747 * tui/tui-interp.c (tui_interp::init): Don't call
5748 tui_initialize_static_data.
5749 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5750
f4ce562c
TT		 57512019-08-15 Tom Tromey <tom@tromey.com>
5752
5753 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5754 examine tui_win_list.
5755
c398c3d0
TT		 57562019-08-15 Tom Tromey <tom@tromey.com>
5757
5758 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5759 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5760 tui_clear_source_content.
5761 (tui_clear_source_content): Remove.
5762 (tui_source_window_base::do_erase_source_content): Hoist call to
5763 content.clear().
5764 * tui/tui-stack.c (tui_show_frame_info): Don't call
5765 tui_clear_source_content.
5766
e25d2004
TT		 57672019-08-15 Tom Tromey <tom@tromey.com>
5768
5769 * tui/tui-winsource.h (struct tui_source_window_base)
5770 <do_erase_source_content>: New method.
5771 <erase_source_content>: New method.
5772 (tui_erase_source_content): Don't declare.
5773 * tui/tui-winsource.c (tui_clear_source_content): Update.
5774 (tui_source_window_base::do_erase_source_content): Rename from
5775 tui_erase_source_content.
5776 (tui_source_window_base::show_source_content): Update.
5777 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5778 * tui/tui-source.h (struct tui_source_window)
5779 <erase_source_content>: New method.
5780 * tui/tui-disasm.h (struct tui_disasm_window)
5781 <erase_source_content>: New method.
5782
002f15c2
TT		 57832019-08-15 Tom Tromey <tom@tromey.com>
5784
5785 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5786 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5787 constructor.
5788 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5789 * tui/tui-source.c (tui_set_source_content): Update.
5790 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5791
c9033fe8
TT		 57922019-08-15 Tom Tromey <tom@tromey.com>
5793
5794 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5795 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5796 tui-source.c.
5797 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5798 Declare.
5799 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5800 method.
5801 (tui_source_window::maybe_update): Update.
5802
088f37dd
TT		 58032019-08-15 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5806 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5807 tui-disasm.c.
5808 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5809 Declare.
5810 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5811 method.
5812 (tui_disasm_window::maybe_update): Update.
5813
a54700c6
TT		 58142019-08-15 Tom Tromey <tom@tromey.com>
5815
5816 * tui/tui-winsource.h (struct tui_source_window_base)
5817 <maybe_update>: Declare.
5818 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5819 method.
5820 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5821 Declare.
5822 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5823 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5824 Declare.
5825 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5826
e2a678a5
TT		 58272019-08-15 Tom Tromey <tom@tromey.com>
5828
5829 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5830
f2dda477
TT		 58312019-08-15 Tom Tromey <tom@tromey.com>
5832
5833 * tui/tui-wingeneral.c: Include tui-stack.h.
5834 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5835 (struct tui_locator_window): Move from tui-data.h.
5836 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5837 (tui_initialize_static_data): Move from tui-data.c.
5838 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5839 (struct tui_locator_window): Move to tui-stack.c.
5840 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5841 (tui_initialize_static_data): Move to tui-stack.c.
5842
ed4a1084
TT		 58432019-08-15 Tom Tromey <tom@tromey.com>
5844
5845 * tui/tui-layout.c (show_source_disasm_command)
5846 (show_source_or_disasm_and_command): Use make_visible method, not
5847 tui_make_window.
5848 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5849 Remove.
5850
65962b20
TT		 58512019-08-15 Tom Tromey <tom@tromey.com>
5852
5853 * tui/tui-wingeneral.h (tui_make_window): Update.
5854 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5855 parameter.
5856 (tui_gen_win_info::make_visible): Update.
5857 * tui/tui-regs.c (tui_data_window::display_registers_from):
5858 Update.
5859 * tui/tui-layout.c (show_source_disasm_command)
5860 (show_source_or_disasm_and_command): Update.
5861 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5862 (enum tui_box): Remove.
5863 (struct tui_win_info) <can_box>: New method.
5864 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5865 method.
5866
2208ee91
TV		 58672019-08-15 Tom de Vries <tdevries@suse.de>
5868
5869 * linux-nat-trad.c: Include gdbarch.h.
5870
75faf5c4
AH		 58712019-08-14 Alan Hayward <alan.hayward@arm.com>
5872
5873 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5874 register sizes.
5875
b1c896b3
TT		 58762019-08-14 Tom Tromey <tromey@adacore.com>
5877
5878 * darwin-nat.c: Include gdbarch.h.
5879 * darwin-nat-info.c: Include gdbarch.h.
5880
6405cd73
TT		 58812019-08-13 Tom Tromey <tom@tromey.com>
5882
5883 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5884 Remove.
5885 * tui/tui-data.c (tui_initialize_static_data): Update.
5886
5216580d
TT		 58872019-08-13 Tom Tromey <tom@tromey.com>
5888
5889 * tui/tui-winsource.h (struct tui_exec_info_window)
5890 <~tui_exec_info_window, maybe_allocate_content, get_content,
5891 m_content>: Remove.
5892 (struct tui_source_window_base) <set_exec_info_content,
5893 show_exec_info_content>: Don't declare.
5894 * tui/tui-winsource.c
5895 (tui_exec_info_window::maybe_allocate_content): Remove.
5896 (tui_source_window_base::update_exec_info): Rename from
5897 set_exec_info_content.
5898 (tui_source_window_base::show_exec_info_content)
5899 (tui_source_window_base::update_exec_info): Remove.
5900
93858ad3
TT		 59012019-08-13 Tom Tromey <tom@tromey.com>
5902
5903 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5904 declare.
5905 * tui/tui-winsource.c (tui_update_source_window_as_is)
5906 (tui_update_source_windows_with_addr, tui_erase_source_content):
5907 Update.
5908 (tui_clear_exec_info_content): Remove.
5909
e321e7ce
TT		 59102019-08-13 Tom Tromey <tom@tromey.com>
5911
5912 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5913 declare.
5914 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5915 call tui_erase_exec_info_content.
5916 (tui_clear_exec_info_content): Rename from
5917 tui_erase_exec_info_content.
5918 (tui_clear_exec_info_content): Delete.
5919
8270ac62
TT		 59202019-08-13 Tom Tromey <tom@tromey.com>
5921
5922 * tui/tui-winsource.h (struct tui_source_window_base)
5923 <show_exec_info_content>: Declare.
5924 (tui_show_exec_info_content): Don't declare.
5925 * tui/tui-winsource.c
5926 (tui_source_window_base::show_exec_info_content): Rename from
5927 tui_show_exec_info_content.
5928 (tui_source_window_base::update_exec_info): Update.
5929
7b56485d
TT		 59302019-08-13 Tom Tromey <tom@tromey.com>
5931
5932 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5933 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5934 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5935 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5936 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5937 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5938 ... here.
5939
7ba913dc
TT		 59402019-08-13 Tom Tromey <tom@tromey.com>
5941
5942 * tui/tui-winsource.h (struct tui_source_window_base)
5943 <update_exec_info>: Declare.
5944 (tui_update_exec_info): Don't declare.
5945 * tui/tui-winsource.c (tui_update_source_window_as_is)
5946 (tui_source_window_base::refresh_all)
5947 (tui_update_all_breakpoint_info): Update.
5948 (tui_source_window_base::update_exec_info): Rename from
5949 tui_update_exec_info.
5950 * tui/tui-stack.c (tui_show_frame_info): Update.
5951
37a4a131
TT		 59522019-08-13 Tom Tromey <tom@tromey.com>
5953
5954 * tui/tui-winsource.h (struct tui_source_window_base)
5955 <set_exec_info_content>: Declare.
5956 (tui_set_exec_info_content): Don't declare.
5957 * tui/tui-winsource.c
5958 (tui_source_window_base::set_exec_info_content): Rename from
5959 tui_set_exec_info_content.
5960 (tui_update_exec_info): Update.
5961
0bd27e07
TT		 59622019-08-13 Tom Tromey <tom@tromey.com>
5963
5964 * tui/tui-winsource.h (struct tui_source_window_base)
5965 <show_source_content>: Declare.
5966 (tui_show_source_content): Don't declare.
5967 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5968 (tui_source_window_base::show_source_content): Rename from
5969 tui_show_source_content.
5970 (tui_source_window_base::refresh_all): Update.
5971 * tui/tui-layout.c (show_source_disasm_command)
5972 (show_source_or_disasm_and_command): Update.
5973
b4ef5aeb
TT		 59742019-08-13 Tom Tromey <tom@tromey.com>
5975
5976 * tui/tui-winsource.c (tui_erase_source_content)
5977 (tui_show_source_content, tui_source_window_base::refresh_all):
5978 Update.
5979 * tui/tui-wingeneral.h
5980 (tui_check_and_display_highlight_if_needed): Don't declare.
5981 * tui/tui-wingeneral.c
5982 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5983 check_and_display_highlight_if_needed.
5984 * tui/tui-win.c (tui_rehighlight_all)
5985 (tui_win_info::make_visible_with_new_height): Update.
5986 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5987 (tui_data_window::erase_data_content)
5988 (tui_data_window::display_all_data): Update.
5989 * tui/tui-data.h (struct tui_win_info)
5990 <check_and_display_highlight_if_needed>: Declare.
5991
fede5273
TT		 59922019-08-13 Tom Tromey <tom@tromey.com>
5993
5994 * tui/tui-win.c (tui_resize_all): Call
5995 tui_delete_invisible_windows.
5996 * tui/tui-layout.c (show_layout): Call
5997 tui_delete_invisible_windows.
5998 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5999 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6000
22c3f490
TT		 60012019-08-13 Tom Tromey <tom@tromey.com>
6002
6003 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6004 tui_add_win_to_layout.
6005
16cb7910
TT		 60062019-08-13 Tom Tromey <tom@tromey.com>
6007
6008 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6009 * tui/tui-layout.c (tui_default_win_height): Now static.
6010
cc0c3ffb
TT		 60112019-08-13 Tom Tromey <tom@tromey.com>
6012
6013 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6014 single switch.
6015 (show_source_disasm_command, show_source_or_disasm_and_command):
6016 Don't check current layout.
6017
3f3ffe54
TT		 60182019-08-13 Tom Tromey <tom@tromey.com>
6019
6020 * tui/tui-wingeneral.c (make_all_visible): Remove.
6021 (tui_make_all_invisible): Simplify.
6022 * tui/tui-layout.c (tui_make_all_invisible): Move from
6023 tui-wingeneral.c; simplify.
6024 (show_layout): Hoist call to tui_make_all_invisible.
6025 (show_data): Don't call tui_make_all_invisible.
6026
69258091
TT		 60272019-08-13 Tom Tromey <tom@tromey.com>
6028
6029 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6030 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6031
62cf57fe
TT		 60322019-08-13 Tom Tromey <tom@tromey.com>
6033
6034 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6035 tui-data.c.
6036 (show_source_disasm_command, show_data)
6037 (show_source_or_disasm_and_command): Don't use
6038 tui_set_current_layout_to.
6039 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6040 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6041 tui-layout.c.
6042 (tui_set_current_layout_to): Remove.
6043
2afade5d
TT		 60442019-08-13 Tom Tromey <tom@tromey.com>
6045
6046 * tui/tui-layout.c (tui_set_layout): Update.
6047 * tui/tui-data.h (struct tui_layout_def): Remove.
6048 (tui_layout_def): Don't declare.
6049 * tui/tui-data.c (layout_def): Remove.
6050 (tui_layout_def): Remove.
6051
a3504e96
TT		 60522019-08-13 Tom Tromey <tom@tromey.com>
6053
6054 * tui/tui-winsource.h (struct tui_source_window_base)
6055 <clear_detail>: No longer "override".
6056 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6057 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6058 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6059 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6060 Remove.
6061 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6062
29c92911
TT		 60632019-08-13 Tom Tromey <tromey@adacore.com>
6064
6065 * tracepoint.c: Don't include readline.h or history.h.
6066
86c6b807
TT		 60672019-08-12 Tom Tromey <tom@tromey.com>
6068
6069 * configure: Rebuild.
6070 * configure.ac: Check for readline 7.
6071 * NEWS: Mention readline 7 requirement.
6072 * README: Update.
6073
5db2718c
TT		 60742019-08-12 Tom Tromey <tom@tromey.com>
6075
6076 * mingw-hdep.c (gdb_select): Remove readline hack.
6077
dac36daf
PFC		 60782019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6079
6080 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6081 when the function fails.
6082
1022c627
AA		 60832019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6084
6085 * s390-tdep.c (s390_type_align): New function.
6086 (s390_gdbarch_init): Set it as type_align gdbarch method.
6087
eba4caf2
TV		 60882019-08-09 Tom de Vries <tdevries@suse.de>
6089
6090 PR gdb/24591
6091 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6092 pc_low with relocation offset.
6093
123cd851
TT		 60942019-08-07 Tom Tromey <tromey@adacore.com>
6095
6096 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6097 (print_frame_args): Update.
6098 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6099 Update.
6100 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6101 * frame.h (struct frame_arg): Add initializers.
6102 <error>: Now a unique_xmalloc_ptr.
6103
3d31bc39
AH		 61042019-08-07 Alan Hayward <alan.hayward@arm.com>
6105
6106 * NEWS: Expand the Pointer Authentication entry.
6107 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6108 (aarch64_frame_unmask_lr): ... to this.
6109 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6110 Call aarch64_frame_unmask_lr.
6111 * frame.c (struct frame_info): Add "masked" variable.
6112 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6113 (fprint_frame): Check for masked pc.
6114 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6115 declarations.
6116 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6117 * stack.c (print_frame): Check for masked pc.
6118
0cf9feb9
TT		 61192019-08-06 Tom Tromey <tom@tromey.com>
6120
6121 * stabsread.c (patch_block_stabs, read_one_struct_field)
6122 (read_enum_type): Use obstack_strndup.
6123 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6124 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6125 * dwarf2read.c (guess_full_die_structure_name)
6126 (anonymous_struct_prefix): Use obstack_strndup.
6127 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6128 * c-exp.y (yylex): Use obstack_strndup.
6129 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6130 (write_var_or_type): Use obstack_strndup.
6131
efba19b0
TT		 61322019-08-06 Tom Tromey <tom@tromey.com>
6133
6134 * symfile.c (reread_symbols): Use obstack_strdup.
6135 * stabsread.c (read_type): Use obstack_strdup.
6136 * gdb_obstack.h (obstack_strdup): New overload.
6137 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6138 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6139 (dwarf2_canonicalize_name): Use obstack_strdup.
6140 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6141 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6142 Use obstack_strdup.
6143
f25102f7
TT		 61442019-08-06 Tom Tromey <tom@tromey.com>
6145
6146 * gdb_obstack.h (obstack_strdup): Define.
6147 * gdb_obstack.c (obstack_strdup): Don't define.
6148
021887d8
TT		 61492019-08-06 Tom Tromey <tom@tromey.com>
6150
6151 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6152 obstack_strdup.
6153 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6154 obstack_strdup.
6155 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6156 * stabsread.c (common_block_start): Use obstack_strdup.
6157 * objfiles.c (set_objfile_main_name, objfile): Use
6158 obstack_strdup.
6159 * namespace.c (add_using_directive): Use obstack_strdup.
6160 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6161 * jit.c (finalize_symtab): Use obstack_strdup.
6162 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6163 (guess_partial_die_structure_name, partial_die_info::fixup)
6164 (dwarf2_name): Use obstack_strdup.
6165 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6166 obstack_strdup.
6167 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6168 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6169 obstack_strdup.
6170 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6171
d2834edc
PW		 61722019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6173
6174 * unittests/help-doc-selftests.c: New file.
6175 * Makefile.in: Add the new file.
6176
590042fc
PW		 61772019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6178
6179 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6180 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6181 the full first line, except when FOR_VALUE_PREFIX. In this case,
6182 the trailing '.' is not output, and the first character is uppercased.
6183 (print_help_for_command): Update call to print_doc_line.
6184 (print_doc_of_command): Likewise.
6185 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6186 * cli/cli-option.c (append_indented_doc): Do not append newline.
6187 (build_help_option): Append newline after first appended_indented_doc
6188 only if a second call is done.
6189 (build_help): Append 2 new lines before each option, except the first
6190 one.
6191 * compile/compile.c (_initialize_compile): Add new lines after
6192 %OPTIONS%, when not at the end of the help.
6193 Change help doc or code
6194 producing the help doc to respect the invariants.
6195 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6196 Also removed the new line after 'Options:', as all other commands
6197 do not put an empty line between 'Options:' and the first option.
6198 * printcmd.c (_initialize_printcmd): Likewise.
6199 * stack.c (_initialize_stack): Likewise.
6200 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6201 incorrectly telling COMMAND is optional.
6202 * ada-lang.c (_initialize_ada_language): Change help doc or code
6203 producing the help doc to respect the invariants.
6204 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6205 * breakpoint.c (_initialize_breakpoint): Likewise.
6206 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6207 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6208 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6209 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6210 _initialize_cli_style): Likewise.
6211 * corelow.c (core_target_info): Likewise.
6212 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6213 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6214 * filesystem.c (_initialize_filesystem): Likewise.
6215 * frame.c (_initialize_frame): Likewise.
6216 * gnu-nat.c (add_task_commands): Likewise.
6217 * infcall.c (_initialize_infcall): Likewise.
6218 * infcmd.c (_initialize_infcmd): Likewise.
6219 * interps.c (_initialize_interpreter): Likewise.
6220 * language.c (_initialize_language): Likewise.
6221 * linux-fork.c (_initialize_linux_fork): Likewise.
6222 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6223 * maint.c (_initialize_maint_cmds): Likewise.
6224 * memattr.c (_initialize_mem): Likewise.
6225 * printcmd.c (_initialize_printcmd): Likewise.
6226 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6227 _RegEx): Likewise.
6228 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6229 * record-btrace.c (_initialize_record_btrace): Likewise.
6230 * record-full.c (_initialize_record_full): Likewise.
6231 * record.c (_initialize_record): Likewise.
6232 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6233 * regcache.c (_initialize_regcache): Likewise.
6234 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6235 _initialize_remote): Likewise.
6236 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6237 * serial.c (_initialize_serial): Likewise.
6238 * skip.c (_initialize_step_skip): Likewise.
6239 * source.c (_initialize_source): Likewise.
6240 * stack.c (_initialize_stack): Likewise.
6241 * symfile.c (_initialize_symfile): Likewise.
6242 * symtab.c (_initialize_symtab): Likewise.
6243 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6244 * top.c (init_main): Likewise.
6245 * tracefile-tfile.c (tfile_target_info): Likewise.
6246 * tracepoint.c (_initialize_tracepoint): Likewise.
6247 * tui/tui-win.c (_initialize_tui_win): Likewise.
6248 * utils.c (add_internal_problem_command): Likewise.
6249 * valprint.c (value_print_option_defs): Likewise.
6250
404f2902
FCE		 62512019-08-06 Frank Ch. Eigler <fche@redhat.com>
6252
6253 PR build/24886
6254 * configure.ac: Drop enable-libmcheck support.
6255 * configure, config.in: Rebuild.
6256 * libmcheck.m4: Remove.
6257 * acinclude.m4: Don't include it.
6258 * Makefile.in: Don't distribute it.
6259 * top.c (print_gdb_configuration): Don't mention it.
6260
046bebe1
TT		 62612019-08-06 Tom Tromey <tom@tromey.com>
6262
6263 * utils.c (set_output_style): Sometimes pass stream to
6264 emit_style_escape.
6265 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6266 * record-btrace.c (btrace_insn_history): Update.
6267 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6268 method.
6269 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6270 Update initializers.
6271 <m_uiout>: New field.
6272 <m_di>: Move lower.
6273 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6274 Remove "uiout" parameter.
6275 (dump_insns): Update.
6276 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6277 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6278
ddbcedf5
CB		 62792019-08-06 Christian Biesinger <cbiesinger@google.com>
6280
6281 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6282 (error_in_psymtab_expansion): Likewise.
6283 (lookup_symbol_via_quick_fns): Likewise.
6284 (basic_lookup_transparent_type_quick): Likewise.
6285 (basic_lookup_transparent_type_1): Likewise.
6286
b08b16c8
TT		 62872019-08-06 Tom Tromey <tromey@adacore.com>
6288
6289 * source.c (last_source_error): Now bool.
6290 (print_source_lines_base): Make "noprint" bool. Only open
6291 source file when last_source_visited changes.
6292
cb44333d
TT		 62932019-08-06 Tom Tromey <tromey@adacore.com>
6294
6295 * annotate.c (annotate_source_line): Use g_source_cache.
6296 * source-cache.c (source_cache::get_plain_source_lines): Change
6297 parameters. Populate m_offset_cache.
6298 (source_cache::ensure): New method.
6299 (source_cache::get_line_charpos): New method.
6300 (extract_lines): Move lower. Change parameters.
6301 (source_cache::get_source_lines): Move lower.
6302 * source-cache.h (class source_cache): Update comment.
6303 <get_line_charpos>: New method.
6304 <get_source_lines>: Update comment.
6305 <clear>: Clear m_offset_cache.
6306 <get_plain_source_lines>: Change parameters.
6307 <ensure>: New method
6308 <m_offset_cache>: New member.
6309 * source.c (forget_cached_source_info_for_objfile): Update.
6310 (info_source_command): Use g_source_cache.
6311 (find_source_lines, open_source_file_with_line_charpos): Remove.
6312 (print_source_lines_base, search_command_helper): Use g_source_cache.
6313 * source.h (open_source_file_with_line_charpos): Don't declare.
6314 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6315 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6316 Use g_source_cache.
6317
872dceaa
TT		 63182019-08-06 Tom Tromey <tromey@adacore.com>
6319
6320 * source-cache.c (source_cache::get_plain_source_lines):
6321 Remove "first_line" and "last_line" parameters.
6322 (source_cache::get_source_lines): Cache plain text.
6323 * source-cache.h (class source_cache)
6324 <get_plain_source_lines>: Update.
6325
269249d9
TT		 63262019-08-06 Tom Tromey <tromey@adacore.com>
6327
6328 * source-cache.c (extract_lines): No longer a method.
6329 Changed type of parameter. Include final newline.
6330 (selftests::extract_lines_test): New function.
6331 (_initialize_source_cache): Likewise.
6332 * source-cache.h (class source_cache)
6333 <extract_lines>: Don't declare.
6334
c0e8dcd8
TT		 63352019-08-06 Tom Tromey <tromey@adacore.com>
6336
6337 * breakpoint.c (init_breakpoint_sal): Update.
6338 (breakpoint): Update.
6339 * breakpoint.h (struct breakpoint) <filter>: Now a
6340 unique_xmalloc_ptr.
6341
0b27c27d
CB		 63422019-08-05 Christian Biesinger <cbiesinger@google.com>
6343
6344 * NEWS: Mention dictionary access on blocks.
6345 * python/py-block.c (blpy_getitem): New function.
6346 (block_object_as_mapping): New struct.
6347 (block_object_type): Use new struct for tp_as_mapping field.
6348
4ee94178
CB		 63492019-08-05 Christian Biesinger <cbiesinger@google.com>
6350
6351 * objfiles.h (objfile): Add a comment describing partial symbols.
6352
8abfcabc
TT		 63532019-08-05 Tom Tromey <tromey@adacore.com>
6354
6355 * compile/compile.c (_initialize_compile): Use _(), not N_().
6356 * thread.c (_initialize_thread): Use _(), not N_().
6357 * stack.c (_initialize_stack): Use _(), not N_().
6358 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6359
2b79f376
SM		 63602019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6361
6362 * dwarf2read.c (struct dw2_symtab_iterator):
6363 <want_specific_block>: Remove.
6364 <block_index>: Change type to gdb::optional.
6365 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6366 change type of BLOCK_INDEX parameter to gdb::optional.
6367 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6368 (dw2_lookup_symbol): Don't pass argument for
6369 WANT_SPECIFIC_BLOCK.
6370 (dw2_expand_symtabs_for_function): Don't pass argument for
6371 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6372 (class dw2_debug_names_iterator)
6373 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6374 parameter, change BLOCK_INDEX type to gdb::optional.
6375 <m_want_specific_block>: Remove.
6376 <m_block_index>: Change type to gdb::optional.
6377 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6378 gdb::optional. Re-write in function of gdb::optional.
6379 (dw2_debug_names_lookup_symbol): Don't pass argument for
6380 WANT_SPECIFIC_BLOCK.
6381 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6382 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6383 BLOCK_INDEX.
6384
ae60f04e
PW		 63852019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6386
6387 * NEWS: Mention changes to "info sources" command.
6388
28cd9371
PW		 63892019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6390
6391 * symtab.c (filename_partial_match_opts): New struct type.
6392 (struct output_source_filename_data): New members
6393 regexp, c_regexp, partial_match.
6394 (output_source_filename): Use new members to decide to print file.
6395 (info_sources_option_defs): New variable.
6396 (make_info_sources_options_def_group, print_info_sources_header,
6397 info_sources_command_completer):
6398 New functions.
6399 (info_sources_command): Read new optional arguments.
6400 (_initialize_symtab): Update info sources help.
6401
ca683e3a
AO		 64022019-08-02 Alexandre Oliva <oliva@adacore.com>
6403
6404 * ada-lang.c (exception_support_info_v0): Renamed from...
6405 (default_exception_support_info): ... this. Create new
6406 definition for v1.
6407 (ada_has_this_exception_support): Look up catch_handlers_sym.
6408 (ada_exception_support_info_sniffer): Try v0 after default.
6409
f1264162
TT		 64102019-08-01 Tom Tromey <tromey@adacore.com>
6411
6412 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6413 gdbarch.h.
6414
0a7b2485
CB		 64152019-08-01 Christian Biesinger <cbiesinger@google.com>
6416
6417 * s12z-tdep.c: Fix include path for s12z-opc.h.
6418
c6bdbeb7
AH		 64192019-08-01 Alan Hayward <alan.hayward@arm.com>
6420
6421 * NEWS: Require GNU make 3.82.
6422
a2bd7b82
TT		 64232019-07-16 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6426 declare.
6427
aa3b6533
TT		 64282019-07-30 Tom Tromey <tromey@adacore.com>
6429
6430 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6431
a1530dc7
KB		 64322019-07-30 Kevin Buettner <kevinb@redhat.com>
6433
6434 * printcmd.c (print_address_symbolic): Print negative offsets.
6435 (build_address_symbolic): Force signed arithmetic when computing
6436 offset.
6437
2906593f
CB		 64382019-07-30 Christian Biesinger <cbiesinger@google.com>
6439
6440 PR/24474: Add a function to lookup static variables.
6441 * NEWS: Mention this new function.
6442 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6443 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6444 * python/python.c (python_GdbMethods): Add new function.
6445
c620ed88
CB		 64462019-07-29 Christian Biesinger <cbiesinger@google.com>
6447
6448 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6449 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6450 (objfpy_lookup_static_symbol): New function.
6451 (objfile_object_methods): Add new functions.
6452
bc4268a5
PW		 64532019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6454
6455 * NEWS: Mention 'set|show print frame-info'. Mention new
6456 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6457 backtrace argument. Mention that python frame filtering code
6458 is now consistent with what 'backtrace' command prints.
6459
4b5e8d19
PW		 64602019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6461
6462 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6463 comments.
6464 (print_frame_info_auto, print_frame_info_source_line,
6465 print_frame_info_location, print_frame_info_source_and_location,
6466 print_frame_info_location_and_address, print_frame_info_short_location):
6467 New declarations.
6468 (struct frame_print_options): New member print_frame_info.
6469 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6470 * stack.h (get_user_print_what_frame_info): New declaration.
6471 (frame_show_address): New declaration.
6472 * stack.c (print_frame_arguments_choices): New value 'presence'.
6473 (print_frame_info_auto, print_frame_info_source_line,
6474 print_frame_info_location, print_frame_info_source_and_location,
6475 print_frame_info_location_and_address, print_frame_info_short_location,
6476 print_frame_info_choices, print_frame_info_print_what): New definitions.
6477 (print_frame_args): Only print dots for args if print frame-arguments
6478 is 'presence'.
6479 (frame_print_option_defs): New element for "frame-info".
6480 (get_user_print_what_frame_info): New function.
6481 (frame_show_address): Make non static. Move comment to stack.h.
6482 (print_frame_info_to_print_what): New function.
6483 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6484 to decide what to print.
6485 (backtrace_command_1): Handle the new print_frame_arguments_presence
6486 value.
6487 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6488 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6489 (py_print_frame): In non-mi mode, use LOCATION as default for
6490 print_what, similarly to frame information printed directly by
6491 backtrace command. Handle frame-info user option in non MI mode.
6492
6bdfee81
KB		 64932019-07-27 Kevin Buettner <kevinb@redhat.com>
6494
6495 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6496 Add case for debugging 32-bit target on 64-bit host. Revise
6497 comment.
6498
98a617f8
KB		 64992019-07-27 Kevin Buettner <kevinb@redhat.com>
6500
6501 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6502 instead of find_function_entry_range_from_pc.
6503
567238c9
KB		 65042019-07-27 Kevin Buettner <kevinb@redhat.com>
6505
6506 * stack.c (find_frame_funname): Remove code which preferred
6507 minsym over symtab sym in "certain pathological cases".
6508
2dc80cf8
KB		 6509 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6510 parameter. Change type of "do_demangle" to bool.
6511 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6512 Pass suitable "prefer_sym_over_minsym" flag to
6513 build_address_symbolic(). Don't output "+" for negative offsets.
6514 * printcmd.c (print_address_symbolic): Update invocation of
6515 build_address_symbolic to include a "prefer_sym_over_minsym"
6516 flag.
6517 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6518 Restrict cases in which use of minimal symbol is preferred to that
6519 of a found symbol. Update comments.
6520
1aff7173
KB		 6521 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6522 for entry pc when entry pc is out of range for that FDE.
6523
89b085ac
BC		 65242019-07-26 Brian Callahan <bcallah@openbsd.org>
6525
6526 PR gdb/24839:
6527 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6528 type.
6529
f32feb4a
CB		 65302019-07-25 Christian Biesinger <cbiesinger@google.com>
6531
6532 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6533 this function's Python signature.
6534
6535
65362019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6537
6538 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6539 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6540 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6541 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6542 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6543
6544
c54e4253
YS		 65452019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6546
6547 * h8300-tdep.c (h8300_register_name_common): New.
6548 h8300_register_name): Use h8300_register_name_common.
6549 (h8300s_register_name): Likewise.
6550 (h8300sx_register_name): Likewise.
6551 (h8300h_register_nam): New.
6552 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6553
6554
40eadf04
SP		 65552019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6556
6557 * arm-tdep.c (arm_skip_cmse_entry): New function.
6558 (arm_is_sgstubs_section): New function.
6559 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6560
bfa2a36d
TT		 65612019-07-22 Tom Tromey <tom@tromey.com>
6562
6563 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6564 Don't self-assign.
6565
a8e9d247
AB		 65662019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6567
6568 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6569 type_print.
6570
eb86c5e2
AB		 65712019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6572
6573 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6574 so that GDB doesn't match any msymbols when searching in the
6575 TYPES_DOMAIN.
6576 (print_symbol_info): Print using typedef_print or type_print based
6577 on the type of the symbol. Add updated FIXME comment moved from...
6578 (_initialize_symtab): ... move and update FIXME comment to above.
6579
a8eab7c6
AB		 65802019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6581
6582 * NEWS: Mention adding -q option to "info types".
6583 * symtab.c (struct info_types_options): New struct.
6584 (info_types_options_defs): New variable.
6585 (make_info_types_options_def_group): New function.
6586 (info_types_command): Use gdb::option framework to parse options.
6587 (info_types_command_completer): New function.
6588 (_initialize_symtab): Extend the help text on "info types" and
6589 register command completer.
6590
b4603c34
CB		 65912019-07-21 Christian Biesinger <cbiesinger@google.com>
6592
6593 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6594 (lookup_symbol_in_objfile): Change int to block_enum and add a
6595 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6596
c8cdc1e0
CB		 65972019-07-20 Christian Biesinger <cbiesinger@google.com>
6598
6599 * MAINTAINERS (Write After Approval): Add self.
6600
01e175fe
AB		 66012019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6602
6603 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6604 instruction to the dummy code region.
6605
56f79b63
TT		 66062019-07-19 Tom Tromey <tromey@adacore.com>
6607
6608 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6609 (ARGSUSED, PARAMS, __func__): Remove rules.
6610
4c5aa8e0
AH		 66112019-07-19 Alan Hayward <alan.hayward@arm.com>
6612
6613 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6614 * features/arm/arm-with-iwmmxt.c: Remove.
6615 * features/arm/arm-with-iwmmxt.xml: Remove.
6616 * features/arm/arm-with-m-fpa-layout.c: Remove.
6617 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6618 * features/arm/arm-with-m-vfp-d16.c: Remove.
6619 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6620 * features/arm/arm-with-m.c: Remove.
6621 * features/arm/arm-with-m.xml: Remove.
6622 * features/arm/arm-with-neon.c: Remove.
6623 * features/arm/arm-with-neon.xml: Remove.
6624 * features/arm/arm-with-vfpv2.c: Remove.
6625 * features/arm/arm-with-vfpv2.xml: Remove.
6626 * features/arm/arm-with-vfpv3.c: Remove.
6627 * features/arm/arm-with-vfpv3.xml: Remove.
6628
f42b2617
AH		 66292019-07-19 Alan Hayward <alan.hayward@arm.com>
6630
6631 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6632
f29ec966
AH		 66332019-07-19 Alan Hayward <alan.hayward@arm.com>
6634
6635 * arch/aarch32.c (aarch32_create_target_description): Create
6636 target descriptions using features.
6637 * arch/arm.c (arm_create_target_description)
6638 (arm_create_mprofile_target_description): Likewise.
6639 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6640
d105cce5
AH		 66412019-07-19 Alan Hayward <alan.hayward@arm.com>
6642
6643 * Makefile.in: Add new files.
6644 * aarch32-tdep.c: New file.
6645 * aarch32-tdep.h: New file.
6646 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6647 Call aarch32_read_description.
6648 * arch/aarch32.c: New file.
6649 * arch/aarch32.h: New file.
6650 * arch/arm.c (arm_create_target_description)
6651 (arm_create_mprofile_target_description): New function.
6652 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6653 (arm_create_target_description)
6654 (arm_create_mprofile_target_description): New declaration.
6655 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6656 read_description functions.
6657 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6658 Likewise.
6659 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6660 * arm-tdep.c (tdesc_arm_list): New variable.
6661 (arm_register_g_packet_guesses): Call create description functions.
6662 (arm_read_description) (arm_read_mprofile_description): New
6663 function.
6664 * arm-tdep.h (arm_read_description)
6665 (arm_read_mprofile_description): Add declaration.
6666 * configure.tgt: Add new files.
6667
afe09f0b
GL		 66682019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6669
6670 * top.c (new_ui_command): Open specified terminal just once.
6671
cd215b2e
TT		 66722019-07-18 Tom Tromey <tromey@adacore.com>
6673
6674 * symtab.c (main_name): Constify return type.
6675 * symfile.c (set_initial_language): Update.
6676 * symtab.h (main_name): Constify return type.
6677
d8f68fcb
TT		 66782019-07-17 Tom Tromey <tom@tromey.com>
6679
6680 * tui/tui-winsource.c (tui_update_source_window)
6681 (tui_update_source_window_as_is)
6682 (tui_update_source_windows_with_line): Remove return.
6683 * tui/tui-disasm.c (tui_show_disassem)
6684 (tui_show_disassem_and_update_source): Remove return.
6685 * tui/tui.c (tui_reset): Remove return.
6686 * tui/tui-wingeneral.c
6687 (tui_check_and_display_highlight_if_needed): Remove return.
6688
ca5af91e
TT		 66892019-07-17 Tom Tromey <tom@tromey.com>
6690
6691 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6692
5104fe36
TT		 66932019-07-17 Tom Tromey <tom@tromey.com>
6694
6695 * tui/tui-winsource.h (struct tui_exec_info_window)
6696 (struct tui_source_window_base): Move from tui-data.h.
6697 * tui/tui-winsource.c: Move many method definitions from
6698 elsewhere. Remove "structuring" comments.
6699 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6700 (tui_source_window_base::refresh_window): Move to
6701 tui-winsource.c.
6702 * tui/tui-win.c (tui_source_window_base::refresh_all)
6703 (tui_source_window_base::update_tab_width)
6704 (tui_source_window_base::set_new_height)
6705 (tui_source_window_base::do_make_visible_with_new_height): Move to
6706 tui-winsource.c.
6707 * tui/tui-source.h: Update.
6708 * tui/tui-source.c (tui_source_window_base::reset): Move to
6709 tui-winsource.c.
6710 * tui/tui-disasm.h: Update.
6711 * tui/tui-data.h (struct tui_exec_info_window): Move to
6712 tui-winsource.h.
6713 (struct tui_source_window_base): Likewise.
6714 * tui/tui-data.c (tui_source_window_base::clear_detail)
6715 (tui_source_window_base, ~tui_source_window_base): Move to
6716 tui-winsource.c.
6717
daa15dde
TT		 67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-win.c (tui_resize_all)
6721 (tui_source_window_base::update_tab_width)
6722 (tui_adjust_win_heights): Update.
6723 (tui_win_info::make_invisible_and_set_new_height): Rename from
6724 make_invisible_and_set_new_height.
6725 * tui/tui-data.h (struct tui_win_info)
6726 <make_invisible_and_set_new_height>: New method.
6727
bfad4537
TT		 67282019-07-17 Tom Tromey <tom@tromey.com>
6729
6730 * tui/tui.c: Update.
6731 * tui/tui-source.h (struct tui_source_window): Move from
6732 tui-data.h.
6733 * tui/tui-layout.c: Update.
6734 * tui/tui-disasm.c: Update.
6735 * tui/tui-data.h (struct tui_source_window): Move to
6736 tui-source.h.
6737
88f7e873
TT		 67382019-07-17 Tom Tromey <tom@tromey.com>
6739
6740 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6741 tui-data.h.
6742 * tui/tui-data.h (struct tui_disasm_window): Move to
6743 tui-disasm.h.
6744
96bd6233
TT		 67452019-07-17 Tom Tromey <tom@tromey.com>
6746
6747 * tui/tui-regs.h (struct tui_data_item_window): Move from
6748 tui-data.h.
6749 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6750 * tui/tui-data.h (struct tui_data_item_window): Move to
6751 tui-regs.h.
6752 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6753
ce38393b
TT		 67542019-07-17 Tom Tromey <tom@tromey.com>
6755
6756 * tui/tui.c: Update.
6757 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6758 (tui_cmd_window::max_height): Move to tui-command.c.
6759 * tui/tui-layout.c: Update.
6760 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6761 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6762 tui-command.c.
6763 * tui/tui-command.h (struct tui_cmd_window): Move from
6764 tui-data.h.
6765 * tui/tui-command.c: Remove "structuring" comments.
6766 (tui_cmd_window::clear_detail)
6767 (tui_cmd_window::do_make_visible_with_new_height)
6768 (tui_cmd_window::max_height): Move from elsewhere.
6769
2d8b51cb
TT		 67702019-07-17 Tom Tromey <tom@tromey.com>
6771
6772 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6773 Now static.
6774 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6775 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6776
18ab23af
TT		 67772019-07-17 Tom Tromey <tom@tromey.com>
6778
6779 * tui/tui.c: Update.
6780 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6781 tui-regs.c.
6782 * tui/tui-windata.h: Remove file.
6783 * tui/tui-windata.c: Remove file.
6784 * tui/tui-win.c (tui_data_window::set_new_height)
6785 (tui_data_window::do_make_visible_with_new_height): Move to
6786 tui-regs.c.
6787 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6788 * tui/tui-regs.c: Remove "structuring" comments.
6789 (tui_data_window::first_data_item_displayed)
6790 (tui_data_window::delete_data_content_windows)
6791 (tui_data_window::erase_data_content)
6792 (tui_data_window::display_all_data)
6793 (tui_data_window::refresh_all)
6794 (tui_data_window::do_scroll_vertical)
6795 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6796 (tui_data_window::do_make_visible_with_new_height)
6797 (tui_data_window::refresh_window): Move from elsewhere.
6798 (_initialize_tui_regs): Move to end of file.
6799 * tui/tui-layout.c: Update.
6800 * tui/tui-hooks.c: Update.
6801 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6802 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6803 tui-regs.c.
6804 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6805
88b7e7cc
TT		 68062019-07-17 Tom Tromey <tom@tromey.com>
6807
6808 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6809 seen.
6810
0fcd3711
TT		 68112019-07-17 Tom Tromey <tom@tromey.com>
6812
6813 * tui/tui-win.c (tui_source_window_base::set_new_height)
6814 (tui_source_window_base::do_make_visible_with_new_height): Use
6815 m_has_locator field directly.
6816 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6817 method.
6818 (struct tui_source_window_base) <has_locator>: Likewise.
6819
4a38112d
TT		 68202019-07-17 Tom Tromey <tom@tromey.com>
6821
6822 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6823 Don't declare.
6824 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6825 Remove.
6826 * tui/tui-win.c (tui_source_window_base::set_new_height)
6827 (tui_source_window_base::set_new_height)
6828 (make_invisible_and_set_new_height)
6829 (tui_source_window_base::do_make_visible_with_new_height)
6830 (tui_source_window_base::do_make_visible_with_new_height):
6831 Update.
6832 * tui/tui-layout.c (show_source_disasm_command, show_data)
6833 (show_source_or_disasm_and_command): Update.
6834 * tui/tui-layout.c (show_layout): Update.
6835
09129226
TT		 68362019-07-17 Tom Tromey <tom@tromey.com>
6837
6838 * tui/tui-layout.c (make_data_window): Remove.
6839 (show_data): Unify creation and re-initialization cases.
6840
4a8a5e84
TT		 68412019-07-17 Tom Tromey <tom@tromey.com>
6842
6843 * tui/tui-layout.c (make_source_window, make_disasm_window):
6844 Remove.
6845 (show_data): Unify creation and re-initialization cases.
6846
76d2be8e
TT		 68472019-07-17 Tom Tromey <tom@tromey.com>
6848
6849 * tui/tui-layout.c (make_command_window): Remove.
6850 (show_source_disasm_command, show_source_or_disasm_and_command):
6851 Unify creation and re-initialization cases.
6852
890b8bde
TT		 68532019-07-17 Tom Tromey <tom@tromey.com>
6854
6855 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6856 creation and re-initialization cases.
6857
2cdfa113
TT		 68582019-07-17 Tom Tromey <tom@tromey.com>
6859
6860 * tui/tui-regs.c (tui_get_register): Return void.
6861
8e3cfd09
TT		 68622019-07-17 Tom Tromey <tom@tromey.com>
6863
6864 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6865 Simplify.
6866
f4e04977
TT		 68672019-07-17 Tom Tromey <tom@tromey.com>
6868
6869 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6870 resetting.
6871
0379b883
TT		 68722019-07-17 Tom Tromey <tom@tromey.com>
6873
6874 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6875 * tui/tui-regs.c (tui_reg_layout): New function.
6876 (tui_show_registers, tui_reg_command): Use it.
6877 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6878 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6879 parameters.
6880 (tui_layout_command): Remove.
6881
b7fbad91
TT		 68822019-07-17 Tom Tromey <tom@tromey.com>
6883
6884 * tui/tui-layout.h (tui/tui-layout): Return void.
6885 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6886
4e1e56b9
TT		 68872019-07-17 Tom Tromey <tom@tromey.com>
6888
6889 * tui/tui-layout.c (show_source_disasm_command, show_data):
6890 Update.
6891 (reset_locator): Remove.
6892 (show_source_or_disasm_and_command): Update.
6893
1e0c09ba
TT		 68942019-07-17 Tom Tromey <tom@tromey.com>
6895
6896 * tui/tui-source.c (tui_source_window_base::reset): Remove
6897 win_type parameter.
6898 * tui/tui-layout.c (make_command_window, make_source_window)
6899 (make_disasm_window, make_data_window)
6900 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6901 (reset_locator, show_source_or_disasm_and_command): Update.
6902 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6903 win_type parameter.
6904 (struct tui_source_window_base) <reset>: Likewise.
6905
1bf605de
TT		 69062019-07-17 Tom Tromey <tom@tromey.com>
6907
6908 * tui/tui-layout.c (show_source_disasm_command): Use
6909 reset_locator.
6910 (reset_locator): New function.
6911 (init_and_make_win): Remove.
6912 (show_source_or_disasm_and_command): Use reset_locator.
6913
098f9ed4
TT		 69142019-07-17 Tom Tromey <tom@tromey.com>
6915
6916 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6917 condition.
6918 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6919 Remove condition.
6920 * tui/tui-source.c (tui_source_window_base::reset): New method.
6921 * tui/tui-layout.c (make_command_window): Don't call
6922 init_and_make_win.
6923 (make_source_window, make_disasm_window): Don't call
6924 make_source_or_disasm_window.
6925 (make_data_window): Don't call init_and_make_win. Change calling
6926 convention.
6927 (show_source_disasm_command, show_data): Simplify.
6928 (make_source_or_disasm_window): Remove.
6929 (show_source_or_disasm_and_command): Simplify.
6930 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6931 (struct tui_source_window_base) <reset>: Likewise.
6932 <execution_info>: Remove initializer.
6933 * tui/tui-data.c (tui_source_window_base): Initialize
6934 execution_info.
6935
80110957
TT		 69362019-07-17 Tom Tromey <tom@tromey.com>
6937
6938 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6939 variable.
6940
cf82af05
TT		 69412019-07-17 Tom Tromey <tom@tromey.com>
6942
6943 * tui/tui.c (tui_rl_other_window): Update.
6944 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6945 superclass method first. Always iterate over regs_content.
6946 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6947 method.
6948 * tui/tui-win.c (tui_set_focus_command): Update.
6949
01aeb396
TT		 69502019-07-17 Tom Tromey <tom@tromey.com>
6951
6952 * tui/tui-win.c (tui_set_focus_command): Rename from
6953 tui_set_focus. Call tui_enable.
6954 (tui_set_focus_command): Remove.
6955
fd6c75ee
TT		 69562019-07-17 Tom Tromey <tom@tromey.com>
6957
6958 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6959 refresh_window.
6960 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6961 touchwin.
6962 (tui_data_window::refresh_window): Call refresh_window on data
6963 items. Always call superclass refresh_window.
6964 (tui_win_info::refresh): Remove.
6965 (tui_source_window_base::refresh_window): Update.
6966 (tui_refresh_all): Update.
6967 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6968 refresh_window.
6969 (show_source_or_disasm_and_command): Likewise.
6970 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6971 (struct tui_source_window_base) <refresh>: Likewise.
6972
f6cc34a9
TT		 69732019-07-17 Tom Tromey <tom@tromey.com>
6974
6975 * tui/tui-winsource.c (tui_clear_source_content)
6976 (tui_show_source_content): Update.
6977 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6978 whether content is empty.
6979 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6980 Remove.
6981
f31ec9af
TT		 69822019-07-17 Tom Tromey <tom@tromey.com>
6983
6984 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6985 window's contents.
6986 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6987 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6988
d1b6f1e5
TT		 69892019-07-17 Tom Tromey <tom@tromey.com>
6990
6991 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6992 (struct tui_data_item_window): Update.
6993
d9743a13
TT		 69942019-07-17 Tom Tromey <tom@tromey.com>
6995
6996 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6997 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6998 defines.
6999
caf0bc4e
TT		 70002019-07-17 Tom Tromey <tom@tromey.com>
7001
7002 * tui/tui-winsource.h (tui_erase_source_content)
7003 (tui_clear_source_content): Remove "display_prompt" parameter.
7004 * tui/tui-winsource.c (tui_update_source_window_as_is)
7005 (tui_update_source_windows_with_addr): Update.
7006 (tui_clear_source_content): Remove "display_prompt" parameter.
7007 (tui_erase_source_content): Likewise. Simplify.
7008 (tui_show_source_content): Update.
7009 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7010 * tui/tui-stack.c (tui_show_frame_info): Update.
7011 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7012 Remove defines.
7013
9d391078
TT		 70142019-07-17 Tom Tromey <tom@tromey.com>
7015
7016 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7017 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7018 parameter.
7019 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7020 parameter.
7021
a38da35d
TT		 70222019-07-17 Tom Tromey <tom@tromey.com>
7023
7024 * tui/tui-winsource.c (tui_clear_source_content)
7025 (tui_show_source_content, tui_show_exec_info_content)
7026 (tui_clear_exec_info_content): Update.
7027 * tui/tui-stack.c (tui_show_locator_content): Update.
7028 (tui_show_frame_info): Update.
7029 * tui/tui-source.h (tui_source_window): Don't declare.
7030 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7031 from tui_source_is_displayed.
7032 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7033 Remove field.
7034 (struct tui_source_window_base) <content_in_use>: New field. Now
7035 bool.
7036 (struct tui_source_window) <showing_source_p>: New method.
7037 (TUI_SRC_WIN): Change cast.
7038 * tui/tui-data.c (tui_initialize_static_data): Update.
7039
c2cd8994
TT		 70402019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7043 location_matches_p.
7044 * tui/tui-source.c (tui_source_window::location_matches_p): New
7045 method.
7046 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7047 method.
7048 * tui/tui-data.h (struct tui_source_window_base)
7049 <location_matches_p>: New method.
7050 (struct tui_source_window, struct tui_disasm_window)
7051 <location_matches_p>: Likewise.
7052
4dde7b34
TT		 70532019-07-17 Tom Tromey <tom@tromey.com>
7054
7055 * tui/tui-win.c (tui_set_win_height_command): Rename from
7056 tui_set_win_height.
7057 (tui_set_win_height_command): Remove.
7058
b73dd877
TT		 70592019-07-17 Tom Tromey <tom@tromey.com>
7060
7061 * tui/tui-source.c (tui_source_window): New constructor. Add
7062 observer.
7063 (~tui_source_window): New destructor.
7064 (tui_source_window::style_changed): New method.
7065 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7066 (tui_attach_detach_observers): Update.
7067 * tui/tui-data.h (struct tui_source_window): Make constructor not
7068 inline. Add destructor.
7069 (struct tui_source_window) <style_changed>: New method.
7070 <m_observable>: New member.
7071
ae2b5380
TT		 70722019-07-17 Tom Tromey <tom@tromey.com>
7073
7074 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7075 * tui/tui-win.c (tui_resize_all): Fix typo.
7076
1ce3e844
TT		 70772019-07-17 Tom Tromey <tom@tromey.com>
7078
7079 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7080 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7081 (tui_refresh_all): Remove "list" parameter. Use foreach.
7082 * tui/tui-win.c (window_name_completer): Use foreach.
7083 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7084 (update_tab_width): Likewise.
7085 * tui/tui-layout.c (show_layout): Update.
7086 * tui/tui-data.h (class tui_window_iterator): New.
7087 (struct all_tui_windows): New.
7088 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7089
fe3eaf1c
TT		 70902019-07-17 Tom Tromey <tom@tromey.com>
7091
7092 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7093 parameter. Don't reference globals.
7094 (tui_reg_command): Update.
7095
368c1354
TT		 70962019-07-17 Tom Tromey <tom@tromey.com>
7097
7098 * tui/tui-regs.c (tui_show_registers): Simplify.
7099
e80cd204
TT		 71002019-07-17 Tom Tromey <tom@tromey.com>
7101
7102 * tui/tui-regs.c (tui_show_registers): Update.
7103 (tui_show_register_group): Add win_info parameter.
7104
aca2dd16
TT		 71052019-07-17 Tom Tromey <tom@tromey.com>
7106
7107 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7108 Rename from tui_display_reg_element_at_line.
7109 (tui_data_window::display_registers_from_line): Update.
7110 * tui/tui-data.h (struct tui_data_window)
7111 <display_reg_element_at_line>: New method.
7112
517e9505
TT		 71132019-07-17 Tom Tromey <tom@tromey.com>
7114
7115 * tui/tui-regs.h (tui_display_registers_from)
7116 (tui_display_registers_from_line): Don't declare.
7117 * tui/tui-windata.c (tui_data_window::display_all_data)
7118 (tui_data_window::refresh_all)
7119 (tui_data_window::do_scroll_vertical): Update.
7120 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7121 from tui_display_registers_from.
7122 (tui_display_reg_element_at_line): Update.
7123 (tui_data_window::display_registers_from_line): Rename from
7124 tui_display_registers_from_line.
7125 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7126 display_registers_from_line>: New methods.
7127
f76d8b19
TT		 71282019-07-17 Tom Tromey <tom@tromey.com>
7129
7130 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7131 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7132 from tui_erase_data_content.
7133 (tui_data_window::display_all_data)
7134 (tui_data_window::refresh_all)
7135 (tui_data_window::do_scroll_vertical): Update.
7136 * tui/tui-regs.c (tui_show_registers): Update.
7137 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7138 New method.
7139
b4094625
TT		 71402019-07-17 Tom Tromey <tom@tromey.com>
7141
7142 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7143 declare.
7144 * tui/tui-windata.c
7145 (tui_data_window::delete_data_content_windows): Rename from
7146 tui_delete_data_content_windows.
7147 (tui_data_window::display_all_data)
7148 (tui_data_window::do_scroll_vertical): Update.
7149 * tui/tui-data.h (struct tui_data_window)
7150 <delete_data_content_windows>: New method.
7151
c223a729
TT		 71522019-07-17 Tom Tromey <tom@tromey.com>
7153
7154 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7155 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7156
50daf268
TT		 71572019-07-17 Tom Tromey <tom@tromey.com>
7158
7159 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7160 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7161 from tui_display_all_data.
7162 * tui/tui-win.c
7163 (tui_data_window::do_make_visible_with_new_height): Update.
7164 * tui/tui-regs.c (tui_show_registers): Update.
7165 * tui/tui-layout.c (tui_set_layout): Update.
7166 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7167 method.
7168
df5f8cab
TT		 71692019-07-17 Tom Tromey <tom@tromey.com>
7170
7171 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7172 * tui/tui-windata.c (tui_display_data_from): Remove.
7173 (tui_data_window::refresh_all): Update.
7174
80cb6c27
TT		 71752019-07-17 Tom Tromey <tom@tromey.com>
7176
7177 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7178 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7179 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7180 tui_display_registers_from_line.
7181 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7182 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7183 "force_display" parameter.
7184
baff0c28
TT		 71852019-07-17 Tom Tromey <tom@tromey.com>
7186
7187 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7188 declare.
7189 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7190 Rename from tui_first_reg_element_no_inline.
7191 (tui_display_reg_element_at_line)
7192 (tui_display_registers_from_line): Update.
7193 * tui/tui-data.h (struct tui_data_window)
7194 <first_reg_element_no_inline>: New method.
7195
3b23c5f2
TT		 71962019-07-17 Tom Tromey <tom@tromey.com>
7197
7198 * tui/tui-windata.c (tui_display_data_from)
7199 (tui_data_window::do_scroll_vertical): Update.
7200 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7201 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7202 Rename from tui_line_from_reg_element_no.
7203 (tui_display_registers_from_line): Update.
7204 * tui/tui-data.h (struct tui_data_window)
7205 <line_from_reg_element_no>: New method.
7206
0b5ec218
TT		 72072019-07-17 Tom Tromey <tom@tromey.com>
7208
7209 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7210 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7211 tui_last_regs_line_no.
7212 (tui_display_reg_element_at_line)
7213 (tui_display_registers_from_line): Update.
7214 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7215 method.
7216
0807ab7b
TT		 72172019-07-17 Tom Tromey <tom@tromey.com>
7218
7219 PR tui/24722:
7220 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7221 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7222 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7223 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7224 (tui_update_breakpoint_info): Likewise.
7225 * tui/tui-hooks.c (tui_event_create_breakpoint)
7226 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7227 Update.
7228
9ad7fdef
TT		 72292019-07-17 Tom Tromey <tom@tromey.com>
7230
7231 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7232
5813316f
TT		 72332019-07-17 Tom Tromey <tom@tromey.com>
7234
7235 * tui/tui-winsource.c (tui_update_source_window_as_is)
7236 (tui_update_source_windows_with_addr): Update.
7237 * tui/tui-source.h (tui_set_source_content)
7238 (tui_show_symtab_source): Add "win_info" parameter.
7239 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7240 parameter.
7241 (tui_show_symtab_source): Likewise.
7242
00e264e7
TT		 72432019-07-17 Tom Tromey <tom@tromey.com>
7244
7245 * tui/tui-wingeneral.c
7246 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7247
06210ce4
TT		 72482019-07-17 Tom Tromey <tom@tromey.com>
7249
7250 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7251 (struct tui_cmd_window) <can_scroll>: New method.
7252 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7253 method.
7254
381befee
TT		 72552019-07-17 Tom Tromey <tromey@adacore.com>
7256
7257 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7258 do_field_signed>: Rename. Change type of "value".
7259 * ui-out.c (ui_out::field_signed): Rename from field_int.
7260 Change type of "value".
7261 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7262 type of "value".
7263 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7264 do_field_int. Change type of "value".
7265 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7266 do_field_int. Change type of "value".
7267 * tracepoint.c (trace_status_mi, tfind_1)
7268 (print_one_static_tracepoint_marker): Update.
7269 * thread.c (print_thread_info_1, print_selected_thread_frame):
7270 Update.
7271 * stack.c (print_frame, print_frame_info): Update.
7272 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7273 Update.
7274 * source.c (print_source_lines_base): Update.
7275 * skip.c (info_skip_command): Update.
7276 * record-btrace.c (btrace_ui_out_decode_error)
7277 (btrace_call_history_src_line): Update.
7278 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7279 Update.
7280 * progspace.c (print_program_space): Update.
7281 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7282 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7283 do_field_int. Change type of "value".
7284 * mi/mi-out.c (mi_ui_out::do_table_begin)
7285 (mi_ui_out::do_table_header): Update.
7286 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7287 type of "value".
7288 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7289 (mi_cmd_data_list_changed_registers, output_register)
7290 (mi_cmd_data_read_memory, mi_load_progress)
7291 (mi_cmd_trace_frame_collected): Update.
7292 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7293 Update.
7294 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7295 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7296 (mi_cmd_var_list_children, varobj_update_one): Update.
7297 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7298 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7299 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7300 * inferior.c (print_inferior): Update.
7301 * gdb_bfd.c (print_one_bfd): Update.
7302 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7303 Update.
7304 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7305 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7306 do_field_int. Change type of "value".
7307 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7308 do_field_int. Change type of "value".
7309 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7310 (print_one_breakpoint_location, print_it_catch_fork)
7311 (print_one_catch_fork, print_it_catch_vfork)
7312 (print_one_catch_vfork, print_it_catch_solib)
7313 (print_it_catch_exec, print_it_ranged_breakpoint)
7314 (print_mention_watchpoint, print_mention_masked_watchpoint)
7315 (bkpt_print_it, update_static_tracepoint): Update.
7316 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7317 * break-catch-syscall.c (print_it_catch_syscall): Update.
7318 * ada-tasks.c (print_ada_task_info): Update.
7319 * ada-lang.c (print_it_exception, print_mention_exception):
7320 Update.
7321
6b78c3f8
AB		 73222019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7323
7324 PR breakpoints/24541
7325 * gdbarch.c: Regenerate.
7326 * gdbarch.h: Regenerate.
7327 * gdbarch.sh: Adjust return type and parameter types for
7328 'stap_adjust_register'.
7329 (i386_stap_adjust_register): Adjust signature and return new
7330 register name.
7331 * stap-probe.c (stap_parse_register_operand): Adjust use of
7332 'gdbarch_stap_adjust_register'.
7333
d72a9b85
TT		 73342019-07-17 Tom Tromey <tromey@adacore.com>
7335
7336 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7337 declare VEC.
7338 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7339 std::vector.
7340 (struct s390_process_info): Add initializers.
7341 (s390_add_process): Use new.
7342 (s390_linux_nat_target::low_forget_process): Use delete.
7343 (s390_linux_nat_target::low_new_fork)
7344 (s390_linux_nat_target::stopped_by_watchpoint)
7345 (s390_linux_nat_target::low_prepare_to_resume)
7346 (s390_linux_nat_target::insert_watchpoint)
7347 (s390_linux_nat_target::insert_hw_breakpoint)
7348 (s390_linux_nat_target::remove_watchpoint)
7349 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7350
206e6c58
JB		 73512019-07-16 John Baldwin <jhb@FreeBSD.org>
7352
7353 * aarch64-fbsd-nat.c: Include regcache.h.
7354 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7355 argument.
7356 (aarch64_fbsd_nat_target::fetch_registers)
7357 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7358 variable.
7359 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7360
cbde90f2
JB		 73612019-07-16 John Baldwin <jhb@FreeBSD.org>
7362
7363 * fbsd-nat.c: Include gdbarch.h.
7364
07128006
TT		 73652019-07-15 Tom Tromey <tromey@adacore.com>
7366
7367 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7368
1f77b012
TT		 73692019-07-15 Tom Tromey <tromey@adacore.com>
7370
7371 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7372 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7373 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7374 * cli-out.c (cli_ui_out::do_field_int): New method.
7375 * ui-out.c (ui_out::field_unsigned): New method.
7376 * symfile.c (generic_load): Use field_unsigned.
7377 (print_transfer_performance): Likewise.
7378 * record-btrace.c (ui_out_field_uint): Remove.
7379 (btrace_call_history_insn_range, btrace_call_history): Use
7380 field_unsigned.
7381 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7382 field_unsigned.
7383 * ui-out.h (class ui_out) <field_unsigned>: New method.
7384 <do_field_unsigned>: Likewise.
7385
33eca680
TT		 73862019-07-15 Tom Tromey <tromey@adacore.com>
7387
7388 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7389 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7390 * target.c (flash_erase_command): Use field_string.
7391 * infrun.c (print_signal_received_reason): Use field_string.
7392 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7393 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7394 field_string.
7395 * ada-tasks.c (print_ada_task_info): Use field_string.
7396
ca8d69be
TT		 73972019-07-15 Tom Tromey <tromey@adacore.com>
7398
7399 * target.c (flash_erase_command): Use field_core_addr.
7400 * symfile.c (generic_load): Use field_core_addr.
7401 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7402 Use field_core_addr.
7403 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7404 field_core_addr.
7405
0d4e84ed
AB		 74062019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7407
7408 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7409 value if its desired type is smaller than a CORE_ADDR and signed.
7410
9a49df9d
AB		 74112019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7412
7413 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7414 of changes to field names, and use new is_reference field to
7415 decide if a property is a reference or not.
7416 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7417 field.
7418 (struct dwarf2_property_baton): Update header comment, rename
7419 'referenced_type' to 'property_type' and update comments.
7420 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7421 default property type, store in property baton, update to take
7422 accound of renamed field.
7423 (read_func_scope): Update call to attr_to_dynamic_prop.
7424 (read_array_type): Likewise.
7425 (dwarf2_per_cu_addr_sized_int_type): New function.
7426 (read_subrange_index_type): Move type finding code to
7427 dwarf2_per_cu_addr_sized_int_type.
7428 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7429 (dwarf2_per_cu_addr_type): New function.
7430 (set_die_type): Update calls to attr_to_dynamic_prop.
7431
b86352cf
AB		 74322019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7433
7434 * dwarf2read.c (read_subrange_index_type): New function.
7435 (read_subrange_type): Move code into new function and call it.
7436 * gdbtypes.c (create_range_type): Add some asserts.
7437
603490bf
AB		 74382019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7439
7440 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7441 update return statements.
7442 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7443 declaration, and update comment to match.
7444 * gdbtypes.c (resolve_dynamic_array): Update call to
7445 dwarf2_evaluate_property to match new return type.
7446
592f9d27
AB		 74472019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7448
7449 * valarith.c (value_subscripted_rvalue): Change lowerbound
7450 parameter type from int to LONGEST.
7451 * value.h (value_subscripted_rvalue): Likewise in declaration.
7452
60cfcb20
AB		 74532019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7454
7455 * cli/cli-utils.c (info_print_command_completer): New function.
7456 * cli/cli-utils.h: Add 'completer.h' include, and forward
7457 declaration for 'struct cmd_list_element'.
7458 (info_print_command_completer): Declare.
7459 * stack.c (_initialize_stack): Add completer for 'info locals' and
7460 'info args'.
7461 * symtab.c (_initialize_symtab): Add completer for 'info
7462 variables' and 'info functions'.
7463 * NEWS: Mention completion for additional info commands.
7464
b16507e0
AB		 74652019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7466
7467 * cli/cli-utils.c (extract_info_print_args): Delete.
7468 (extract_arg_maybe_quoted): Delete.
7469 (info_print_options_defs): New variable.
7470 (make_info_print_options_def_group): New function.
7471 (extract_info_print_options): Define new function.
7472 * cli/cli-utils.h (extract_info_print_args): Delete.
7473 (struct info_print_options): New structure.
7474 (extract_info_print_options): Declare new function.
7475 * stack.c (info_locals_command): Update to use new
7476 extract_info_print_options, also add a header comment.
7477 (info_args_command): Likewise.
7478 * symtab.c (info_variables_command): Likewise.
7479 (info_functions_command): Likewise.
7480
021d8588
AB		 74812019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7482
7483 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7484 to extract string arguments.
7485 * common/common-utils.c (extract_string_maybe_quoted): New function.
7486 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7487
b777eb6d
TT		 74882019-07-11 Tom Tromey <tromey@adacore.com>
7489
7490 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7491 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7492 * top.h (gdbinit): Don't declare.
7493 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7494 into...
7495 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7496 * top.c (gdb_init): Don't call init_cli_cmds.
7497 (gdbinit): Remove.
7498 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7499
72ee03ff
TT		 75002019-07-11 Tom Tromey <tromey@adacore.com>
7501
7502 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7503 after it has been moved.
7504
00db9531
SM		 75052019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7506
7507 * valops.c (value_must_coerce_to_target): Change return type to
7508 bool.
7509 * value.h (value_must_coerce_to_target): Likewise.
7510
f2478a7e
SM		 75112019-07-10 Simon Marchi <simon.marchi@efficios.com>
7512
7513 * breakpoint.c (is_hardware_watchpoint): Remove
7514 forward-declaration.
7515 (is_masked_watchpoint): Change return type to bool.
7516 (is_tracepoint): Likewise.
7517 (is_breakpoint): Likewise.
7518 (is_hardware_watchpoint): Likewise.
7519 (is_watchpoint): Likewise.
7520 (is_no_memory_software_watchpoint): Likewise.
7521 (is_catchpoint): Likewise.
7522 (breakpoint_1): Make FILTER parameter's return type bool.
7523 is_masked_watchpoint): Change return type to bool.
7524 (save_breakpoints): Make FILTER parameter's return type bool.
7525 * breakpoint.h (is_breakpoint): Change return type to bool.
7526 (is_watchpoint): Likewise.
7527 (is_catchpoint): Likewise.
7528 (is_tracepoint): Likewise.
7529
0d12e84c
TT		 75302019-07-10 Tom Tromey <tom@tromey.com>
7531
7532 * defs.h: Don't include gdbarch.h.
7533 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7534 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7535 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7536 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7537 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7538 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7539 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7540 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7541 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7542 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7543 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7544 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7545 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7546 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7547 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7548 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7549 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7550 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7551 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7552 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7553 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7554 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7555 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7556 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7557 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7558 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7559 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7560
f06f1252
TT		 75612019-07-10 Tom Tromey <tromey@adacore.com>
7562
7563 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7564 * breakpoint.c (init_ada_exception_breakpoint): Register as
7565 bp_catchpoint.
7566 (print_one_breakpoint_location, print_one_breakpoint): Use
7567 is_ada_exception_catchpoint.
7568 * ada-lang.c (class ada_catchpoint_location): Pass
7569 bp_loc_software_breakpoint to bp_location constructor.
7570 (is_ada_exception_catchpoint): New function.
7571
7a5d944b
TT		 75722019-07-10 Tom Tromey <tromey@adacore.com>
7573
7574 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7575 VEC.
7576 (struct arm_exidx_entry): New method operator<.
7577 (struct arm_exidx_data) <section_maps>: Change type.
7578 (arm_exidx_data_free): Remove.
7579 (arm_exidx_data_key): Change type. Move lower.
7580 (arm_exidx_new_objfile): Update.
7581 (arm_compare_exidx_entries): Remove.
7582 (arm_find_exidx_entry, _initialize_arm_tdep)
7583
48c66e1d
TT		 75842019-07-10 Tom Tromey <tromey@adacore.com>
7585
7586 * solib-spu.c (ocl_program_data_key): Change type.
7587 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7588 Update.
7589
a269fbf1
TT		 75902019-07-10 Tom Tromey <tromey@adacore.com>
7591
7592 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7593 (struct solib_aix_inferior_data) <library_list>: Change type.
7594 (solib_aix_inferior_data_handle): Change type.
7595 (get_solib_aix_inferior_data): Update.
7596 (solib_aix_free_library_list): Remove.
7597 (library_list_start_library): Update.
7598 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7599 return type.
7600 (solib_aix_get_library_list)
7601 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7602 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7603
c294730c
TT		 76042019-07-10 Tom Tromey <tromey@adacore.com>
7605
7606 * solib-dsbt.c (struct dsbt_info): Add initializers.
7607 (solib_dsbt_pspace_data): Change type.
7608 (dsbt_pspace_data_cleanup): Remove.
7609 (get_dsbt_info, _initialize_dsbt_solib): Update.
7610
9d52077d
TT		 76112019-07-10 Tom Tromey <tromey@adacore.com>
7612
7613 * spu-tdep.c (spu_overlay_data): Change type.
7614 (spu_get_overlay_table, spu_overlay_new_objfile)
7615 (_initialize_spu_tdep): Update.
7616
22a20dca
TT		 76172019-07-10 Tom Tromey <tromey@adacore.com>
7618
7619 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7620 destructor.
7621 (dbx_objfile_data_key): Change type and declare later.
7622 (DBX_SYMFILE_INFO): Rewrite.
7623 * dbxread.c (dbx_objfile_data_key): Change type.
7624 (dbx_symfile_init): Update.
7625 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7626 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7627 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7628
cb60f420
TT		 76292019-07-10 Tom Tromey <tromey@adacore.com>
7630
7631 * jit.c (jit_program_space_key): Change type. Move lower.
7632 (get_jit_program_space_data): Update.
7633 (jit_program_space_data_cleanup): Remove.
7634 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7635 Update.
7636 (struct jit_program_space_data): Add initializers.
7637
51df2ae3
TT		 76382019-07-10 Tom Tromey <tromey@adacore.com>
7639
7640 * solib-darwin.c (struct darwin_info): Add initializers.
7641 (solib_darwin_pspace_data): Change type.
7642 (darwin_pspace_data_cleanup): Remove.
7643 (get_darwin_info, _initialize_darwin_solib): Update.
7644
18101a35
TT		 76452019-07-10 Tom Tromey <tromey@adacore.com>
7646
7647 * remote-sim.c (struct sim_inferior_data): Add initializers,
7648 constructor, and destructor.
7649 (sim_inferior_data_key): Change type. Move lower.
7650 (check_for_duplicate_sim_descriptor): Update.
7651 (get_sim_inferior_data): Use new. Update.
7652 (~sim_inferior_data_cleanup): Rename from
7653 sim_inferior_data_cleanup. Simplify.
7654 (gdbsim_close_inferior, simulator_command)
7655 (sim_command_completer, _initialize_remote_sim): Update.
7656 (next_pid, INITIAL_PID): Move earlier.
7657
05b08ac1
TT		 76582019-07-10 Tom Tromey <tromey@adacore.com>
7659
7660 * python/python-internal.h (create_thread_object): Return
7661 gdbpy_ref.
7662 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7663 * python/py-inferior.c (struct threadlist_entry): Add
7664 constructor.
7665 <thread_obj>: Now a gdbpy_ref.
7666 (thread_to_thread_object): Update.
7667 (add_thread_object): Use new.
7668 (delete_thread_object): Use delete.
7669 (infpy_threads): Update.
7670 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7671 GIL.
7672
32372d80
TT		 76732019-07-10 Tom Tromey <tromey@adacore.com>
7674
7675 * valops.c (value_cast): Specialize error message for Ada.
7676
5c458ae8
SM		 76772019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7678
7679 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7680
4c462cb0
SM		 76812019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7682
7683 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7684 bpstat_should_step): Return bool, adjust comments.
7685 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7686 bpstat_should_step): Likewise.
7687
89abbcc2
AH		 76882019-07-10 Alan Hayward <alan.hayward@arm.com>
7689
7690 * features/Makefile: Use feature target descriptions for Arm.
7691 * features/arm/arm-core.c: Generate new file.
7692 * features/arm/arm-fpa.c: Likewise.
7693 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7694 * features/arm/arm-m-profile.c: Likewise.
7695 * features/arm/arm-vfpv2.c: Likewise.
7696 * features/arm/arm-vfpv3.c: Likewise.
7697 * features/arm/xscale-iwmmxt.c: Likewise.
7698 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7699
166a82be
AH		 77002019-07-10 Alan Hayward <alan.hayward@arm.com>
7701
7702 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7703 ptrace earlier.
7704
9fb4c7e9
AH		 77052019-07-10 Alan Hayward <alan.hayward@arm.com>
7706
7707 * features/aarch64-pauth.c: Regenerate.
7708
e2d0f980
SM		 77092019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7710
7711 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7712 bool.
7713 (bpstat_what): Use false instead of 0.
7714
a38118e5
PA		 77152019-07-09 Pedro Alves <palves@redhat.com>
7716
7717 * break-catch-throw.c (is_exception_catchpoint): New.
7718 * breakpoint.c (print_one_breakpoint_location): New parameter
7719 'raw_loc'. Handle it. Use
7720 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7721 looking at the breakpoint's type.
7722 (print_one_breakpoint): If handling "maint info breakpoints", also
7723 print locations of exception catchpoints.
7724 * breakpoint.h (is_exception_catchpoint): Declare.
7725
cb1e4e32
PA		 77262019-07-09 Pedro Alves <palves@redhat.com>
7727
7728 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7729 "addr" field.
7730 (allocate_location_exception_catchpoint): New.
7731 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7732 (initialize_throw_catchpoint_ops): Install
7733 allocate_location_exception_catchpoint as allocate_location
7734 method.
7735 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7736 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7737 bp_loc_other.
7738 (breakpoint_address_is_meaningful): Delete.
7739 (bl_address_is_meaningful): New.
7740 (breakpoint_locations_match): Adjust comment.
7741 (bp_location_from_bp_type): New, factored out of...
7742 (bp_location::bp_location(breakpoint *)): ... this.
7743 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7744 factored out of...
7745 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7746 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7747 breakpoint_address_is_meaningful.
7748 (bp_locations_compare): Adjust comment.
7749 (update_global_location_list): Use bl_address_is_meaningful
7750 instead of breakpoint_address_is_meaningful.
7751 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7752 explicit.
7753 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7754 * python/py-breakpoint.c (bppy_get_location): No longer check
7755 whether location is null.
7756
b58a68fe
PA		 77572019-07-09 Pedro Alves <palves@redhat.com>
7758
7759 PR c++/15468
7760 * breakpoint.c (print_one_breakpoint_location): Remove
7761 single-location assert.
7762
268a13a5
TT		 77632019-07-09 Tom Tromey <tom@tromey.com>
7764
7765 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7766 * configure: Rebuild.
7767 * configure.ac: Change common to gdbsupport.
7768 * gdbsupport: Rename from common.
7769 * acinclude.m4: Change common to gdbsupport.
7770 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7771 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7772 gdbsupport.
7773 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7774 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7775 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7776 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7777 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7778 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7779 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7780 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7781 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7782 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7783 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7784 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7785 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7786 coff-pe-read.c, command.h, compile/compile-c-support.c,
7787 compile/compile-c.h, compile/compile-cplus-symbols.c,
7788 compile/compile-cplus-types.c, compile/compile-cplus.h,
7789 compile/compile-loc2c.c, compile/compile.c, completer.c,
7790 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7791 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7792 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7793 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7794 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7795 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7796 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7797 features/aarch64-core.c, features/aarch64-fpu.c,
7798 features/aarch64-pauth.c, features/aarch64-sve.c,
7799 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7800 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7801 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7802 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7803 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7804 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7805 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7806 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7807 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7808 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7809 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7810 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7811 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7812 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7813 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7814 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7815 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7816 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7817 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7818 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7819 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7820 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7821 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7822 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7823 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7824 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7825 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7826 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7827 minsyms.c, mips-linux-tdep.c, namespace.h,
7828 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7829 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7830 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7831 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7832 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7833 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7834 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7835 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7836 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7837 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7838 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7839 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7840 procfs.c, producer.c, progspace.h, psymtab.h,
7841 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7842 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7843 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7844 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7845 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7846 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7847 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7848 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7849 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7850 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7851 target-memory.c, target.c, target.h, target/waitstatus.c,
7852 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7853 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7854 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7855 unittests/array-view-selftests.c,
7856 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7857 unittests/common-utils-selftests.c,
7858 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7859 unittests/format_pieces-selftests.c,
7860 unittests/function-view-selftests.c,
7861 unittests/lookup_name_info-selftests.c,
7862 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7863 unittests/mkdir-recursive-selftests.c,
7864 unittests/observable-selftests.c,
7865 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7866 unittests/parse-connection-spec-selftests.c,
7867 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7868 unittests/scoped_fd-selftests.c,
7869 unittests/scoped_mmap-selftests.c,
7870 unittests/scoped_restore-selftests.c,
7871 unittests/string_view-selftests.c, unittests/style-selftests.c,
7872 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7873 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7874 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7875 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7876 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7877 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7878
5b0e2db4
AB		 78792019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7880
7881 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7882 bool value.
7883 (decode_digits_ordinary): Set explicit_line field in sal.
7884 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7885 symtab_and_line that was set on an explicit line number in
7886 assembler code. Do always update the recorded symtab and line if
7887 we do skip the prologue.
7888
0ba852ab
AB		 78892019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7890
7891 * breakpoint.c (set_breakpoint_location_function): Remove
7892 explicit_loc parameter.
7893 (momentary_breakpoint_from_master): Update call to
7894 set_breakpoint_location_function.
7895 (add_location_to_breakpoint): Likewise.
7896
b3a7d171
AB		 78972019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7898
7899 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7900 required features based on default bfd type when no specific bfd
7901 is present.
7902
1f6f6e21
PW		 79032019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7904
7905 * NEWS: Mention that GDB printf and eval commands can now print
7906 C-style and Ada-style convenience var strings without
7907 calling the inferior.
7908 * printcmd.c (printf_c_string): Locally print GDB internal var
7909 instead of transiting via the inferior.
7910 (printf_wide_c_string): Likewise.
7911
79122019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7913
5862c886 7914 PR breakpoints/25011
ea142fbf
AH		 7915 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7916
0598af48
TT		 79172019-07-04 Tom Tromey <tom@tromey.com>
7918
7919 PR tui/24724:
7920 * tui/tui-winsource.c (tui_clear_source_content): Update.
7921 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7922 (tui_update_breakpoint_info): Update.
7923 (tui_set_exec_info_content): Update.
7924 * tui/tui-source.c (tui_set_source_content_nil): Update.
7925 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7926 has_break.
7927 * tui/tui-data.h (enum tui_bp_flag): New.
7928 (tui_bp_flags): New enum flags type.
7929 (struct tui_source_element) <break_mode>: Change type. Rename
7930 from has_break.
7931 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7932 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7933 constants.
7934 * tui/tui-winsource.h: Fix comment.
7935
350fab54
AH		 79362019-07-04 Alan Hayward <alan.hayward@arm.com>
7937
7938 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7939 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7940 (store_fpregs_to_thread)
7941 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7942 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7943 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7944 (IWMMXT_REGS_SIZE): Add define.
7945 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7946 (fetch_vfp_regs, store_vfp_regs)
7947 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7948 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7949
f0452268
AH		 79502019-07-04 Alan Hayward <alan.hayward@arm.com>
7951
7952 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7953 defines.
7954 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7955 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7956 (ARM_INT_REGISTER_SIZE): ...to this.
7957 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7958 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7959 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7960 (arm_linux_collect_gregset, supply_nwfpe_register)
7961 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7962 defines.
7963 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7964 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7965 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7966 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7967 (arm_return_in_memory, arm_store_return_value)
7968 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7969 (arm_record_ld_st_multiple): Likewise.
7970 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7971 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7972
e935475c
AH		 79732019-07-04 Alan Hayward <alan.hayward@arm.com>
7974
7975 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7976 AARCH64_DISPLACED_MODIFIED_INSNS.
7977 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7978 (aarch64_displaced_step_copy_insn): Likewise.
7979 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7980 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7981 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7982 ARM_DISPLACED_MODIFIED_INSNS.
7983 * arm-tdep.c (arm_gdbarch_init): Likewise.
7984 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7985 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7986 (struct arm_displaced_step_closure): Use
7987 ARM_DISPLACED_MODIFIED_INSNS.
7988
df0bb381
AH		 79892019-07-04 Alan Hayward <alan.hayward@arm.com>
7990
7991 * features/Makefile: Remove unused xml files.
7992 * features/aarch64.xml: Remove.
7993 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7994 * features/i386/amd64-avx-avx512.xml: Remove.
7995 * features/i386/amd64-avx-linux.xml: Remove.
7996 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7997 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7998 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7999 * features/i386/amd64-avx-mpx.xml: Remove.
8000 * features/i386/amd64-avx.xml: Remove.
8001 * features/i386/amd64-linux.xml: Remove.
8002 * features/i386/amd64-mpx-linux.xml: Remove.
8003 * features/i386/amd64-mpx.xml: Remove.
8004 * features/i386/amd64.xml: Remove.
8005 * features/i386/i386-avx-avx512-linux.xml: Remove.
8006 * features/i386/i386-avx-avx512.xml: Remove.
8007 * features/i386/i386-avx-linux.xml: Remove.
8008 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8009 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8010 * features/i386/i386-avx-mpx-linux.xml: Remove.
8011 * features/i386/i386-avx-mpx.xml: Remove.
8012 * features/i386/i386-avx.xml: Remove.
8013 * features/i386/i386-linux.xml: Remove.
8014 * features/i386/i386-mmx-linux.xml: Remove.
8015 * features/i386/i386-mmx.xml: Remove.
8016 * features/i386/i386-mpx-linux.xml: Remove.
8017 * features/i386/i386-mpx.xml: Remove.
8018 * features/i386/i386.xml: Remove.
8019 * features/i386/x32-avx-avx512-linux.xml: Remove.
8020 * features/i386/x32-avx-linux.xml: Remove.
8021 * features/i386/x32-linux.xml: Remove.
8022
edd6266a
AH		 80232019-07-04 Alan Hayward <alan.hayward@arm.com>
8024
8025 * regformats/aarch64.dat: Remove.
8026 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8027 * regformats/i386/amd64-avx-linux.dat: Remove.
8028 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8029 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8030 * regformats/i386/amd64-linux.dat: Remove.
8031 * regformats/i386/amd64-mpx-linux.dat: Remove.
8032 * regformats/i386/amd64.dat: Remove.
8033 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8034 * regformats/i386/i386-avx-linux.dat: Remove.
8035 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8036 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8037 * regformats/i386/i386-linux.dat: Remove.
8038 * regformats/i386/i386-mmx-linux.dat: Remove.
8039 * regformats/i386/i386-mpx-linux.dat: Remove.
8040 * regformats/i386/i386.dat: Remove.
8041 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8042 * regformats/i386/x32-avx-linux.dat: Remove.
8043 * regformats/i386/x32-linux.dat: Remove.
8044
2b40fda7
AH		 80452019-07-04 Alan Hayward <alan.hayward@arm.com>
8046
8047 * aarch64-tdep.c: Remove xml self tests.
8048 * amd64-linux-tdep.c: Likewise.
8049 * amd64-tdep.c: Likewise.
8050 * i386-linux-tdep.c: Likewise.
8051 * i386-tdep.c: Likewise.
8052
5f4ba3e7
PA		 80532019-07-03 Pedro Alves <palves@redhat.com>
8054
8055 PR cli/24732
8056 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8057 (pipe_cmd_option_defs): New.
8058 (make_pipe_cmd_options_def_group): New.
8059 (pipe_command): Use gdb::option::process_options.
8060 (pipe_command_completer): New function.
8061 (_initialize_cli_cmds): Install completer for "pipe" command.
8062
3d9be6f5
PA		 80632019-07-03 Pedro Alves <palves@redhat.com>
8064
8065 * cli/cli-option.c (union option_value) <string>: New field.
8066 (struct option_def_and_value): Add ctor, move ctor, dtor and
8067 use DISABLE_COPY_AND_ASSIGN.
8068 (option_def_and_value::clear_value): New.
8069 (parse_option, save_option_value_in_ctx, get_val_type_str)
8070 (add_setshow_cmds_for_options): Handle var_string.
8071 * cli-option.h (union option_def::var_address) <string>: New
8072 field.
8073 (struct string_option_def): New.
8074 * maint-test-options.c (struct test_options_opts): Add default
8075 ctor and use DISABLE_COPY_AND_ASSIGN.
8076 <string_opt>: New field.
8077 (test_options_opts::~test_options_opts): New.
8078 (test_options_opts::dump): Also dump "-string".
8079 (test_options_option_defs): Install "string.
8080
41fc454c
PA		 80812019-07-03 Pedro Alves <palves@redhat.com>
8082
8083 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8084 option_value with a null enumeration.
8085 (complete_options): Save the option values in the context.
8086 (save_option_value_in_ctx): New, factored out from ...
8087 (process_options): ... here.
8088 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8089 of the function.
8090 * maint-test-options.c (test_options_opts::dump): New, factored
8091 out from ...
8092 (maintenance_test_options_command_mode): ... here.
8093 (maintenance_test_options_command_completion_result): Delete.
8094 (maintenance_test_options_command_completion_text): Update
8095 comment.
8096 (maintenance_show_test_options_completion_result): Change
8097 prototype. Just print
8098 maintenance_test_options_command_completion_text.
8099 (save_completion_result): New.
8100 (maintenance_test_options_completer_mode): Pass options context to
8101 complete_options, and then save a dump.
8102 (_initialize_maint_test_options): Use add_cmd to install "maint
8103 show test-options-completion-result".
8104
fdbc9870
PA		 81052019-07-03 Pedro Alves <palves@redhat.com>
8106
8107 * NEWS (New commands): Mention "with" and "maint with".
8108 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8109 (with_command, with_command_completer): New.
8110 (pipe_command): Adjust to new repeat_previous
8111 interface.
8112 (_initialize_cli_cmds): Install the "with" command and its "w"
8113 alias.
8114 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8115 declarations.
8116 * cli/cli-setshow.c (parse_cli_var_uinteger)
8117 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8118 argument strings for all var_types.
8119 (get_setshow_command_value_string): New, factored out from ...
8120 (do_show_command): ... this.
8121 * cli/cli-setshow.h: Include <string>.
8122 (get_setshow_command_value_string): Declare.
8123 * command.h (repeat_previous): Now returns const char *. Adjust
8124 comment.
8125 * maint.c: Include "cli/cli-cmds.h".
8126 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8127 (_initialize_maint_cmds): Register the "maintenance with" command.
8128 * top.c (repeat_previous): Move bits from pipe_command here:
8129 Return the saved command line, if any; error out if there's no
8130 command to relaunch.
8131
c6ac8931
PA		 81322019-07-03 Pedro Alves <palves@redhat.com>
8133
8134 * NEWS (New commands): Mention "maint set/show test-settings"
8135 instead of "maint test-settings".
8136 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8137 (maintenance_test_settings_set_list): Rename to ...
8138 (maintenance_set_test_settings_list): ... this.
8139 (maintenance_test_settings_show_list): Rename to ...
8140 (maintenance_show_test_settings_list): ... this.
8141 (maintenance_test_settings_cmd): Delete.
8142 (maintenance_test_settings_set_cmd): ...
8143 (maintenance_set_test_settings_cmd): ... this.
8144 (maintenance_test_settings_show_cmd): ...
8145 (maintenance_show_test_settings_cmd): ... this.
8146 (maintenance_test_settings_show_value_cmd):
8147 (maintenance_show_test_settings_value_cmd): ... this.
8148 (_initialize_maint_test_settings): No longer install the "maint
8149 test-settings" prefix command. Rename "maint test-settings set"
8150 to "maint set test-settings", and "maint test-settings show" to
8151 "maint show test-settings". Adjust all subcommands.
8152
d1fcf2fd
PA		 81532019-07-03 Pedro Alves <palves@redhat.com>
8154
8155 * maint-test-settings.c: Fix file's intro comment. Replace all
8156 references to "test-options" with references to "test-settings",
8157 in comments.
8158
970f9d09
PA		 81592019-07-03 Pedro Alves <palves@redhat.com>
8160
8161 * maint-test-settings.c (maintenance_test_settings_xxx)
8162 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8163 New.
8164 (maintenance_test_settings_enums): Use them.
8165 (maintenance_test_settings_enum): Default to
8166 maintenance_test_settings_xxx.
8167 (_initialize_maint_test_settings): Initialize
8168 MAINTENANCE_TEST_SETTINGS_FILENAME.
8169
f3869b1a
SM		 81702019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8171
8172 * breakpoint.h (remove_breakpoints_inf): Change return type to
8173 void, move function documentation here.
8174 * breakpoint.c (remove_breakpoints_inf): Change return type to
8175 void, move function documentation to header.
8176
54d66006
PA		 81772019-07-02 Pedro Alves <palves@redhat.com>
8178
8179 * NEWS (Completion improvements): Mention "info threads".
8180 * thread.c (struct info_threads_opts, info_threads_option_defs)
8181 (make_info_threads_options_def_group): New.
8182 (info_threads_command): Use gdb::option::process_options.
8183 (info_threads_command_completer): New.
8184 (_initialize_thread): Use gdb::option::build_help to build the
8185 help text for "info threads".
8186
854f6088
SM		 81872019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8188
8189 * defs.h (generic_load): Move from here...
8190 * symfile.h (generic_load): ... to here. Rename name parameter
8191 to args.
8192 * symfile.c (generic_load): Add comment.
8193
54ee4252
TT		 81942019-07-01 Tom Tromey <tromey@adacore.com>
8195
8196 * dwarf2read.c
8197 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8198 declaration of without_params. Fix formatting.
8199
65392b3e
TT		 82002019-07-01 Tom Tromey <tromey@adacore.com>
8201
8202 * ada-exp.y (find_primitive_type): Update.
8203 * ada-lang.h (ada_lookup_symbol): Update.
8204 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8205 parameter.
8206 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8207
7d7571f0
SDJ		 82082019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8209
8210 PR breakpoints/24541
8211 * gdbarch.c: Regenerate.
8212 * gdbarch.h: Regenerate.
8213 * gdbarch.sh: Add 'stap_adjust_register'.
8214 * i386-tdep.c: Include '<unordered_set>'.
8215 (i386_stap_adjust_register): New function.
8216 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8217 * stap-probe.c (stap_parse_register_operand): Call
8218 'gdbarch_stap_adjust_register'.
8219
5af5392a
SDJ		 82202019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8221
8222 PR python/24742
8223 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8224 * python/python.c (do_start_initialization): Use 'xmalloc'
8225 instead of 'PyMem_Malloc'.
8226
10d06d82
TT		 82272019-06-28 Tom Tromey <tromey@adacore.com>
8228
8229 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8230 for Ada.
8231
1b7f24cd
TT		 82322019-06-27 Tom Tromey <tromey@adacore.com>
8233
8234 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8235 objfile_key.
8236 (arm_find_mapping_symbol, arm_record_special_symbol)
8237 (_initialize_arm_tdep): Update.
8238 (arm_objfile_data_free): Remove.
8239
3d507ff2
TT		 82402019-06-27 Tom Tromey <tromey@adacore.com>
8241
8242 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8243 to cp_print_static_field.
8244
762c164d
TT		 82452019-06-26 Tom Tromey <tromey@adacore.com>
8246
8247 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8248 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8249 declare.
8250
aa2f9bcf
AH		 82512019-06-26 Alan Hayward <alan.hayward@arm.com>
8252
8253 * features/aarch64-core.c (create_feature_aarch64_core):
8254 Regenerate.
8255 * features/aarch64-core.xml: Add cpsr flags.
8256
3426ae57
AH		 82572019-06-26 Alan Hayward <alan.hayward@arm.com>
8258
8259 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8260 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8261
4838e44c
SM		 82622019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8263
8264 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8265 field.
8266 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8267 use.
8268 (arm_record_special_symbol): Don't insert new symbol in sorted
8269 position, push it at the end.
8270
54cc7474
SM		 82712019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8272
8273 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8274 (arm_mapping_symbol_s): Remove.
8275 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8276 (arm_mapping_symbol_vec): New typedef.
8277 (struct arm_per_objfile): Add constructor.
8278 <section_maps>: Change type to
8279 std::unique_ptr<arm_mapping_symbol_vec[]>.
8280 (arm_compare_mapping_symbols): Remove.
8281 (arm_find_mapping_symbol): Adjust to section_maps type change.
8282 (arm_objfile_data_free): Call delete on arm_per_objfile.
8283 (arm_record_special_symbol): Adjust to section_maps type change.
8284 Allocate arm_per_objfile with new.
8285
b65b566c
PW		 82862019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8287
8288 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8289 with the command prefix.
8290
c2fc64f5
TT		 82912019-06-25 Tom Tromey <tom@tromey.com>
8292
8293 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8294 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8295
fb54fa76
TT		 82962019-06-25 Tom Tromey <tom@tromey.com>
8297
8298 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8299 type.
8300 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8301 protected.
8302
f7952c57
TT		 83032019-06-25 Tom Tromey <tom@tromey.com>
8304
8305 * tui/tui-winsource.c
8306 (tui_source_window_base::set_is_exec_point_at): Add check against
8307 LOA_ADDRESS.
8308
17568d78
TT		 83092019-06-25 Tom Tromey <tom@tromey.com>
8310
8311 * tui/tui-source.c (tui_set_source_content): Don't check before
8312 xfree.
8313 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8314
53e7cdba
TT		 83152019-06-25 Tom Tromey <tom@tromey.com>
8316
8317 * tui/tui-winsource.h (tui_update_source_window_as_is)
8318 (tui_alloc_source_buffer, tui_line_is_displayed)
8319 (tui_addr_is_displayed): Change type of win_info.
8320 * tui/tui-winsource.c (tui_update_source_window_as_is)
8321 (tui_clear_source_content, tui_show_source_line)
8322 (tui_show_source_content, tui_source_window_base::refill)
8323 (tui_source_window_base::set_is_exec_point_at)
8324 (tui_source_window_base::set_is_exec_point_at)
8325 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8326 (tui_alloc_source_buffer, tui_line_is_displayed)
8327 (tui_addr_is_displayed): Change type of win_info. Update.
8328 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8329 (tui_source_window_base::do_make_visible_with_new_height):
8330 Update.
8331 * tui/tui-source.c (tui_set_source_content)
8332 (tui_set_source_content_nil)
8333 (tui_source_window::do_scroll_vertical): Update.
8334 * tui/tui-layout.c (show_layout): Update.
8335 * tui/tui-disasm.c (tui_set_disassem_content)
8336 (tui_disasm_window::do_scroll_vertical): Update.
8337 * tui/tui-data.h (tui_win_content): Remove.
8338 (struct tui_gen_win_info) <content, content_size>: Remove.
8339 (struct tui_source_element): Add initializers and destructor.
8340 (union tui_which_element, struct tui_win_element): Remove.
8341 (struct tui_source_window_base) <content>: New field.
8342 (struct tui_data_window): Remove destructor.
8343 (tui_alloc_content, tui_free_win_content)
8344 (tui_free_all_source_wins_content): Don't declare.
8345 * tui/tui-data.c (tui_initialize_static_data): Update.
8346 (init_content_element, tui_alloc_content): Remove.
8347 (~tui_gen_win_info): Update.
8348 (~tui_data_window, tui_free_all_source_wins_content)
8349 (tui_free_win_content, free_content, free_content_elements):
8350 Remove.
8351
7908abbf
TT		 83522019-06-25 Tom Tromey <tom@tromey.com>
8353
8354 * tui/tui-winsource.h (tui_clear_source_content)
8355 (tui_erase_source_content, tui_show_source_content): Change type
8356 of win_info.
8357 * tui/tui-winsource.c (tui_clear_source_content)
8358 (tui_erase_source_content, tui_show_source_content): Change type
8359 of win_info.
8360 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8361 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8362 win_info.
8363 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8364 win_info.
8365 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8366
02c28df0
TT		 83672019-06-25 Tom Tromey <tom@tromey.com>
8368
8369 * tui/tui-winsource.c (tui_clear_source_content)
8370 (tui_source_window_base::set_is_exec_point_at): Update.
8371 * tui/tui-source.c (tui_set_source_content_nil): Update.
8372 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8373 a bool.
8374 * tui/tui-data.c (init_content_element): Update.
8375
6658b1bf
TT		 83762019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8379 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8380 * tui/tui-layout.c (init_and_make_win): Update.
8381 * tui/tui.h (enum tui_win_type): Update.
8382 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8383 tui_win_is_auxillary.
8384 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8385 tui_win_is_auxillary.
8386
21e1c91e
TT		 83872019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8390 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8391 (tui_delete_data_content_windows, tui_display_all_data)
8392 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8393 Update.
8394 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8395 * tui/tui-regs.c (tui_last_regs_line_no)
8396 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8397 (tui_show_registers): Update.
8398 (tui_show_register_group): Return void. Update.
8399 (tui_display_registers_from, tui_display_reg_element_at_line)
8400 (tui_display_registers_from_line, tui_check_register_values):
8401 Update.
8402 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8403 member.
8404 (struct tui_data_window) <regs_content>: Now a std::vector.
8405 <regs_content_count>: Remove.
8406 (tui_add_content_elements, tui_free_data_content): Don't declare.
8407 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8408 (init_content_element): Remove DATA_WIN case. Add assert.
8409 (tui_add_content_elements): Remove.
8410 (tui_data_window): Update.
8411 (tui_free_data_content): Remove.
8412 (free_content_elements): Remove DATA_WIN case.
8413
115ac53b
TT		 84142019-06-25 Tom Tromey <tom@tromey.com>
8415
8416 * tui/tui-data.c (tui_data_item_window): Update.
8417 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8418 * tui/tui-windata.c (tui_display_all_data)
8419 (tui_display_data_from_line): Update.
8420 (tui_check_data_values): Remove.
8421 * tui/tui-regs.c (tui_show_register_group)
8422 (tui_display_reg_element_at_line): Update.
8423 * tui/tui-hooks.c (tui_register_changed)
8424 (tui_refresh_frame_and_register_information): Call
8425 tui_check_register_values.
8426 * tui/tui-data.h (struct tui_data_window) <data_content,
8427 data_content_count, data_type>: Remove.
8428 (enum tui_data_type): Remove.
8429
8430 * tui/tui-data.c (tui_data_window::clear_detail)
8431 (~tui_data_window): Update.
8432
eaf9738b
TT		 84332019-06-25 Tom Tromey <tom@tromey.com>
8434
8435 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8436 declare.
8437 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8438 Rename from tui_first_data_item_displayed. Update.
8439 (tui_data_window::refresh_all)
8440 (tui_data_window::do_scroll_vertical): Update.
8441 * tui/tui-data.h (struct tui_data_window)
8442 <first_data_item_displayed>: Declare new method.
8443
31ca4723
TT		 84442019-06-25 Tom Tromey <tom@tromey.com>
8445
8446 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8447 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8448 contents...
8449 (tui_initialize_static_data): ...here.
8450
41bcff7f
TT		 84512019-06-25 Tom Tromey <tom@tromey.com>
8452
8453 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8454 (tui_display_registers_from, tui_check_register_values): Update.
8455 (tui_display_register): Remove win_info parameter; update.
8456 (tui_get_register): Change type of parameters.
8457 * tui/tui-data.h (struct tui_data_element): Remove.
8458 (union tui_which_element) <data>: Remove.
8459 <data_window>: Change type.
8460 (struct tui_data_item_window): New.
8461 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8462 case. Add assert.
8463 (~tui_data_item_window): New destructor.
8464 (free_content_elements): Remove DATA_ITEM_WIN case.
8465
d2802c33
TT		 84662019-06-25 Tom Tromey <tom@tromey.com>
8467
8468 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8469 Remove.
8470
dd835f8b
TT		 84712019-06-25 Tom Tromey <tom@tromey.com>
8472
8473 * tui/tui-data.h (struct tui_command_element): Remove.
8474 (union tui_which_element) <command>: Remove.
8475 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8476 assert.
8477 (free_content_elements): Remove CMD_WIN case.
8478
bd7db367
TT		 84792019-06-25 Tom Tromey <tom@tromey.com>
8480
8481 * tui/tui-layout.c (tui_set_layout): Update.
8482 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8483 * tui/tui-data.c (layout_def): Update.
8484
3add462f
TT		 84852019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8488 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8489 (tui_source_window_base::set_new_height): Update.
8490 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8491 Update.
8492 (tui_set_locator_fullname, tui_set_locator_info)
8493 (tui_show_frame_info): Update.
8494 * tui/tui-source.c (tui_set_source_content)
8495 (tui_source_is_displayed): Update.
8496 * tui/tui-layout.c (show_source_disasm_command, show_data)
8497 (show_source_or_disasm_and_command): Update.
8498 * tui/tui-disasm.c (tui_set_disassem_content)
8499 (tui_get_begin_asm_address): Update.
8500 * tui/tui-data.h (struct tui_locator_element): Remove.
8501 (union tui_which_element) <locator>: Remove.
8502 (struct tui_locator_window): New.
8503 (tui_locator_win_info_ptr): Change return type.
8504 * tui/tui-data.c (_locator): Change type.
8505 (tui_locator_win_info_ptr): Change return type.
8506 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8507 (tui_alloc_content): Add assert.
8508
489e9d8b
TT		 85092019-06-25 Tom Tromey <tom@tromey.com>
8510
8511 * tui/tui-winsource.c
8512 (tui_exec_info_window::maybe_allocate_content): New method.
8513 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8514 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8515 (make_source_or_disasm_window): Add cast.
8516 * tui/tui-data.h (union tui_which_element) <simple_string>:
8517 Remove.
8518 (struct tui_source_info): New.
8519 (struct tui_source_window_base) <execution_info>: Change type.
8520 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8521 case, and add assert.
8522 (tui_alloc_content): Add assert.
8523
c3fabb7d
TT		 85242019-06-25 Tom Tromey <tom@tromey.com>
8525
8526 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8527 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8528 * tui/tui-data.c (tui_alloc_win_info): Remove.
8529
bbc228ee
TT		 85302019-06-25 Tom Tromey <tom@tromey.com>
8531
8532 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8533 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8534 can_highlight.
8535
5fcee43a
TT		 85362019-06-25 Tom Tromey <tom@tromey.com>
8537
8538 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8539 make_visible_with_new_height method.
8540 (tui_win_info::make_visible_with_new_height): New method.
8541 (tui_source_window_base::do_make_visible_with_new_height)
8542 (tui_data_window::do_make_visible_with_new_height)
8543 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8544 (make_visible_with_new_height): Remove.
8545 (tui_resize_all, tui_adjust_win_heights): Use
8546 make_visible_with_new_height method.
8547 * tui/tui-data.h (struct tui_win_info)
8548 <do_make_visible_with_new_height, make_visible_with_new_height>:
8549 New methods.
8550 (struct tui_source_window_base, struct tui_data_window)
8551 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8552 methods.
8553
d83f1fe6
TT		 85542019-06-25 Tom Tromey <tom@tromey.com>
8555
8556 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8557 method.
8558 (update_tab_width): Call update_tab_width method.
8559 * tui/tui-data.h (struct tui_win_info)
8560 (struct tui_source_window_base) <update_tab_width>: New methods.
8561
17374de4
TT		 85622019-06-25 Tom Tromey <tom@tromey.com>
8563
8564 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8565 parameter.
8566 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8567 parameter.
8568 (tui_gen_win_info::make_visible): Update.
8569 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8570 parameter.
8571 * tui/tui-data.h (enum tui_box): New enum.
8572 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8573
f936bca2
TT		 85742019-06-25 Tom Tromey <tom@tromey.com>
8575
8576 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8577 init_and_make_win for EXEC_INFO_WIN.
8578 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8579 longer inline.
8580 (struct tui_win_info) <~tui_win_info>: Inline.
8581 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8582 Don't declare.
8583 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8584 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8585 Remove.
8586 (tui_initialize_static_data): Update.
8587 (~tui_gen_win_info): Handle more cleanup here.
8588 (~tui_source_window_base): Delete "execution_info".
8589 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8590
d6ba6a11
TT		 85912019-06-25 Tom Tromey <tom@tromey.com>
8592
8593 * tui/tui-layout.c (make_command_window): Don't set
8594 can_highlight.
8595 (show_source_disasm_command): Call the reset method.
8596 (show_data): Don't set can_highlight. Call the reset method.
8597 (tui_gen_win_info::reset): Rename from init_gen_win_info
8598 (init_and_make_win): Simplify. Return tui_gen_win_info.
8599 (show_source_or_disasm_and_command): Call the reset method.
8600 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8601 (struct tui_cmd_window): Set can_highlight.
8602
48a3bd16
TT		 86032019-06-25 Tom Tromey <tom@tromey.com>
8604
8605 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8606 from make_visible.
8607 (tui_make_visible, tui_make_invisible): Rewrite.
8608 (tui_win_info::make_visible): Remove.
8609 (tui_source_window_base::make_visible): Update.
8610 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8611 method. Moved from...
8612 (struct tui_win_info) <make_visible>: ...here.
8613
c3bd716f
TT		 86142019-06-25 Tom Tromey <tom@tromey.com>
8615
8616 * tui/tui-winsource.c
8617 (tui_source_window_base::do_scroll_horizontal): Remove direction
8618 parameter.
8619 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8620 direction parameter.
8621 * tui/tui-win.c (tui_win_info::forward_scroll)
8622 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8623 (tui_win_info::right_scroll): Update.
8624 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8625 direction parameter.
8626 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8627 direction parameter.
8628 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8629 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8630 Remove direction parameter.
8631 (struct tui_source_window_base, struct tui_source_window)
8632 (struct tui_disasm_window, struct tui_data_window)
8633 (struct tui_cmd_window): Update.
8634
21c32dca
TT		 86352019-06-25 Tom Tromey <tom@tromey.com>
8636
8637 * tui/tui-winsource.h (tui_set_exec_info_content)
8638 (tui_show_exec_info_content, tui_erase_exec_info_content)
8639 (tui_clear_exec_info_content, tui_update_exec_info): Change
8640 argument to tui_source_window_base.
8641 * tui/tui-winsource.c (tui_set_exec_info_content)
8642 (tui_show_exec_info_content, tui_erase_exec_info_content)
8643 (tui_clear_exec_info_content, tui_update_exec_info): Change
8644 argument to tui_source_window_base.
8645
73fbdc65
TT		 86462019-06-25 Tom Tromey <tom@tromey.com>
8647
8648 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8649 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8650
33325343
TT		 86512019-06-25 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8654 check.
8655
29d2c474
TT		 86562019-06-25 Tom Tromey <tom@tromey.com>
8657
8658 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8659 type to void.
8660 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8661 type to void.
8662 * tui/tui-source.c (tui_set_source_content): Update.
8663 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8664
152f3f4b
TT		 86652019-06-25 Tom Tromey <tom@tromey.com>
8666
8667 * tui/tui-win.c (window_name_completer, tui_set_focus)
8668 (tui_all_windows_info): Use name method.
8669 * tui/tui-data.h (struct tui_gen_win_info)
8670 (struct tui_source_window, struct tui_disasm_window)
8671 (struct tui_data_window, struct tui_cmd_window) <name>: New
8672 method.
8673 (tui_win_name): Don't declare.
8674 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8675 (tui_win_name): Remove.
8676
be4da588
TT		 86772019-06-25 Tom Tromey <tom@tromey.com>
8678
8679 * tui/tui-winsource.h (tui_update_source_window)
8680 (tui_update_source_window_as_is): Change parameter type.
8681 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8682 to be a tui_source_window_base.
8683 (tui_update_source_window_as_is): Likewise.
8684 * tui/tui-win.c (make_visible_with_new_height): Update.
8685
5b81daba
TT		 86862019-06-25 Tom Tromey <tom@tromey.com>
8687
8688 * tui/tui-winsource.c (tui_erase_source_content)
8689 (tui_show_source_content, tui_show_exec_info_content)
8690 (tui_erase_exec_info_content): Use refresh_window method.
8691 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8692 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8693 from tui_refresh_win.
8694 (tui_data_window::refresh_window): New method.
8695 (tui_win_info::refresh, tui_source_window_base::refresh)
8696 (tui_refresh_all): Use refresh_window method.
8697 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8698 method.
8699 * tui/tui-regs.c (tui_display_register): Call refresh_window
8700 method.
8701 * tui/tui-layout.c (show_source_disasm_command)
8702 (show_source_or_disasm_and_command): Call refresh_window method.
8703 * tui/tui-data.h (struct tui_gen_win_info)
8704 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8705 New method.
8706
cb2ce893
TT		 87072019-06-25 Tom Tromey <tom@tromey.com>
8708
8709 * tui/tui.c (tui_rl_other_window, tui_enable)
8710 (tui_is_window_visible, tui_get_command_dimension): Update.
8711 * tui/tui-winsource.c (tui_update_source_window_as_is)
8712 (tui_clear_source_content, tui_erase_source_content)
8713 (tui_show_source_line, tui_source_window_base::refill)
8714 (tui_source_window_base::do_scroll_horizontal)
8715 (tui_source_window_base::set_is_exec_point_at)
8716 (tui_update_breakpoint_info, tui_set_exec_info_content)
8717 (tui_alloc_source_buffer, tui_line_is_displayed)
8718 (tui_addr_is_displayed): Update.
8719 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8720 (tui_check_and_display_highlight_if_needed)
8721 (tui_win_info::make_visible, tui_win_info::refresh)
8722 (tui_refresh_all): Update.
8723 * tui/tui-windata.c (tui_first_data_item_displayed)
8724 (tui_delete_data_content_windows, tui_erase_data_content)
8725 (tui_display_all_data, tui_data_window::refresh_all)
8726 (tui_check_data_values): Update.
8727 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8728 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8729 (tui_win_info::backward_scroll, tui_refresh_all_win)
8730 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8731 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8732 (tui_source_window_base::set_new_height)
8733 (tui_data_window::set_new_height)
8734 (make_invisible_and_set_new_height)
8735 (make_visible_with_new_height, new_height_ok)
8736 (parse_scrolling_args): Update.
8737 * tui/tui-stack.c (tui_show_frame_info): Update.
8738 * tui/tui-source.c (tui_set_source_content)
8739 (tui_set_source_content_nil, tui_source_is_displayed)
8740 (tui_source_window::do_scroll_vertical): Update.
8741 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8742 (tui_display_registers_from, tui_display_reg_element_at_line)
8743 (tui_check_register_values, tui_reg_command): Update.
8744 * tui/tui-layout.c (tui_default_win_height)
8745 (show_source_disasm_command, show_data, init_and_make_win)
8746 (show_source_or_disasm_and_command): Update.
8747 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8748 (tui_redisplay_readline, tui_mld_flush)
8749 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8750 (tui_getc): Update.
8751 * tui/tui-disasm.c (tui_set_disassem_content)
8752 (tui_disasm_window::do_scroll_vertical): Update.
8753 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8754 Now virtual.
8755 (struct tui_win_info): Derive from tui_gen_win_info.
8756 <~tui_win_info>: Mark as override.
8757 <generic>: Remove member.
8758 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8759 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8760 (~tui_data_window, ~tui_win_info)
8761 (tui_free_all_source_wins_content): Update.
8762 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8763
ab313b35
TT		 87642019-06-25 Tom Tromey <tom@tromey.com>
8765
8766 * tui/tui-layout.c (init_and_make_win): Use new.
8767 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8768 destructor, initializers.
8769 (tui_alloc_generic_win_info): Don't declare.
8770 * tui/tui-data.c (_locator): Add argument to constructor.
8771 (source_win, disasm_win): New globals.
8772 (exec_info): Remove.
8773 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8774 Update.
8775 (tui_alloc_generic_win_info): Remove.
8776 (init_content_element): Use new.
8777 (tui_win_info::tui_win_info): Update.
8778 (free_content_elements) <case DATA_WIN>: Use delete.
8779
dc2c33e4
TT		 87802019-06-25 Tom Tromey <tom@tromey.com>
8781
8782 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8783 * tui/tui-windata.c (tui_first_data_item_displayed)
8784 (tui_delete_data_content_windows): Update.
8785 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8786 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8787 (tui_display_registers_from, tui_check_register_values): Update.
8788 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8789 pointer.
8790 * tui/tui-data.c (init_content_element): Update. Allocate the new
8791 window.
8792 (tui_free_data_content): Update.
8793 (free_content_elements) <case DATA_WIN>: Free the window.
8794
214a5cbe
TT		 87952019-06-25 Tom Tromey <tom@tromey.com>
8796
8797 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8798 Update.
8799 * tui/tui-layout.c (make_command_window)
8800 (show_source_disasm_command, show_data, init_and_make_win)
8801 (show_source_or_disasm_and_command): Update.
8802 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8803 method.
8804 <can_highight, is_highlighted>: Now bool.
8805 (tui_set_win_highlight): Don't declare.
8806 * tui/tui-data.c (tui_set_win_highlight): Remove.
8807
8e2daf15
TT		 88082019-06-25 Tom Tromey <tom@tromey.com>
8809
8810 * tui/tui-wingeneral.c (make_visible): Remove check of window
8811 type.
8812
8903bd8a
TT		 88132019-06-25 Tom Tromey <tom@tromey.com>
8814
8815 * tui/tui-win.c (tui_win_info::max_height)
8816 (tui_cmd_window::max_height): New methods.
8817 (new_height_ok): Call max_height.
8818 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8819 <max_height>: New method.
8820
3f02ce1e
TT		 88212019-06-25 Tom Tromey <tom@tromey.com>
8822
8823 * tui/tui-win.c (tui_source_window_base::set_new_height)
8824 (tui_data_window::set_new_height): New methods.
8825 (make_invisible_and_set_new_height): Call set_new_height method.
8826 * tui/tui-data.h (struct tui_win_info)
8827 (struct tui_source_window_base, struct tui_data_window)
8828 <set_new_height>: New method.
8829
1825f487
TT		 88302019-06-25 Tom Tromey <tom@tromey.com>
8831
8832 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8833 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8834 tui_refresh_data_win.
8835 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8836 method.
8837 (tui_refresh_all_win): Call the refresh_all method.
8838 (tui_set_focus): Likewise.
8839 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8840 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8841 Likewise.
8842
ad54d15b
TT		 88432019-06-25 Tom Tromey <tom@tromey.com>
8844
8845 * tui/tui-winsource.h (tui_refill_source_window)
8846 (tui_set_is_exec_point_at): Don't declare.
8847 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8848 (tui_source_window_base::refill): Rename from
8849 tui_refill_source_window.
8850 (tui_source_window_base::do_scroll_horizontal): Update.
8851 (tui_source_window_base::set_is_exec_point_at): Rename from
8852 tui_set_is_exec_point_at.
8853 (tui_update_all_breakpoint_info): Update.
8854 * tui/tui-stack.c (tui_show_frame_info): Update.
8855 * tui/tui-layout.c (show_data): Add cast.
8856 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8857 * tui/tui-data.h (struct tui_source_window_base) <refill,
8858 set_is_exec_point_at>: New methods.
8859 (tui_source_windows, tui_add_to_source_windows): Update types.
8860 (tui_add_to_source_windows): Remove redundant declaration.
8861 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8862 (tui_source_windows): Change return type.
8863 (tui_clear_source_windows_detail): Update.
8864 (tui_add_to_source_windows): Change type of parameter.
8865 (tui_free_all_source_wins_content): Update.
8866
2042b506
TT		 88672019-06-25 Tom Tromey <tom@tromey.com>
8868
8869 * tui/tui-wingeneral.c (tui_win_info::refresh)
8870 (tui_source_window_base::refresh): New methods.
8871 (tui_refresh_all): Call the refresh method.
8872 * tui/tui-data.h (struct tui_win_info)
8873 (struct tui_source_window_base) <refresh>: New method.
8874
56122977
TT		 88752019-06-25 Tom Tromey <tom@tromey.com>
8876
8877 * tui/tui.h (tui_is_window_visible): Return bool.
8878 * tui/tui.c (tui_is_window_visible): Return bool.
8879 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8880 (tui_make_visible, tui_make_invisible)
8881 (tui_win_info::make_visible)
8882 (tui_source_window_base::make_visible, make_all_visible)
8883 (tui_make_all_visible, tui_make_all_invisible): Update.
8884 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8885 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8886 bool.
8887 (struct tui_win_info, struct tui_source_window_base)
8888 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8889 * tui/tui-data.c (tui_init_generic_part): Update.
8890
cda37efb
TT		 88912019-06-25 Tom Tromey <tom@tromey.com>
8892
8893 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8894 (tui_source_window_base::make_visible): New methods.
8895 (make_all_visible): Make method call.
8896 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8897 (struct tui_source_window_base, struct tui_cmd_window): Override
8898 make_visible.
8899 (tui_win_is_source_type): Don't declare.
8900 * tui/tui-data.c (tui_win_is_source_type): Remove.
8901
6a0ee02c
TT		 89022019-06-25 Tom Tromey <tom@tromey.com>
8903
8904 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8905 NULL check.
8906
63901aec
TT		 89072019-06-25 Tom Tromey <tom@tromey.com>
8908
8909 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8910 Inline constructor. Add initializers for members.
8911 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8912 constructors; now inline in class.
8913
ceb13a13
TT		 89142019-06-25 Tom Tromey <tom@tromey.com>
8915
8916 * tui/tui-regs.c (tui_show_registers): Update.
8917 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8918 bool.
8919 * tui/tui-data.c (tui_data_window::clear_detail)
8920 (tui_data_window): Update.
8921
238eb706
TT		 89222019-06-25 Tom Tromey <tom@tromey.com>
8923
8924 * tui/tui-windata.c (tui_display_all_data)
8925 (tui_display_data_from_line, tui_display_data_from)
8926 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8927 Update.
8928 * tui/tui-regs.c (tui_last_regs_line_no)
8929 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8930 (tui_show_registers, tui_show_register_group)
8931 (tui_display_registers_from, tui_display_reg_element_at_line)
8932 (tui_display_registers_from_line, tui_check_register_values)
8933 (tui_reg_next, tui_reg_prev): Update.
8934 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8935 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8936 tui_data_window.
8937 (struct tui_win_info) <detail>: Remove. Add new fields from
8938 tui_data_info.
8939 (TUI_DATA_WIN): Add cast.
8940 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8941 (~tui_data_window): Simplify.
8942
81491aa0
TT		 89432019-06-25 Tom Tromey <tom@tromey.com>
8944
8945 * tui/tui-layout.c (show_source_disasm_command)
8946 (show_source_or_disasm_and_command): Update.
8947 * tui/tui-io.c (update_cmdwin_start_line)
8948 (tui_redisplay_readline): Update.
8949 * tui/tui-data.h (struct tui_command_info): Remove.
8950 (struct tui_win_info) <detail>: Remove command_info member.
8951 (struct tui_data_window) <start_line>: New member, from
8952 tui_command_info.
8953 (TUI_CMD_WIN): Add casts.
8954
e6e41501
TT		 89552019-06-25 Tom Tromey <tom@tromey.com>
8956
8957 * tui/tui-winsource.c (tui_update_source_window)
8958 (tui_refill_source_window)
8959 (tui_source_window_base::do_scroll_horizontal)
8960 (tui_update_breakpoint_info, tui_set_exec_info_content)
8961 (tui_show_exec_info_content, tui_erase_exec_info_content)
8962 (tui_clear_exec_info_content): Update.
8963 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8964 Update.
8965 * tui/tui-win.c (make_invisible_and_set_new_height)
8966 (make_visible_with_new_height): Update.
8967 * tui/tui-source.c (tui_set_source_content)
8968 (tui_show_symtab_source): Update.
8969 * tui/tui-layout.c (extract_display_start_addr)
8970 (show_source_disasm_command, show_data)
8971 (make_source_or_disasm_window)
8972 (show_source_or_disasm_and_command): Update.
8973 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8974 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8975 "gdbarch".
8976 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8977 to tui_source_window_base.
8978 (struct tui_win_info) <detail>: Remove source_info member.
8979 (struct tui_source_window_base) <has_locator>: Inline.
8980 Move contents from tui_source_info; rename has_locator member to
8981 m_has_locator.
8982 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8983 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8984 header file.
8985 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8986 Simplify.
8987 (tui_free_all_source_wins_content): Cast to
8988 tui_source_window_base.
8989
44f0e208
TT		 89902019-06-25 Tom Tromey <tom@tromey.com>
8991
8992 * tui/tui-win.c (make_invisible_and_set_new_height)
8993 (make_visible_with_new_height): Call has_locator method.
8994 * tui/tui-layout.c (show_source_disasm_command, show_data)
8995 (show_source_or_disasm_and_command): Update for bool change.
8996 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8997 (tui_win_info) <has_locator>: New method.
8998 (struct tui_source_window_base) <has_locator>: New method.
8999 (tui_win_has_locator): Don't declare.
9000 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9001 from tui_win_has_locator.
9002 (tui_source_window_base): Use false, not FALSE.
9003
7778b912
TT		 90042019-06-25 Tom Tromey <tom@tromey.com>
9005
9006 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9007 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9008 clear_detail method directly.
9009 (tui_clear_win_detail): Remove.
9010
f83d391c
TT		 90112019-06-25 Tom Tromey <tom@tromey.com>
9012
9013 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9014 "this", not TUI_DISASM_WIN.
9015
13446e05
TT		 90162019-06-25 Tom Tromey <tom@tromey.com>
9017
9018 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9019 declare.
9020 * tui/tui-winsource.c
9021 (tui_source_window_base::do_scroll_horizontal): Rename from
9022 tui_horizontal_source_scroll.
9023 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9024 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9025 from tui_vertical_data_scroll.
9026 * tui/tui-win.h (tui_scroll): Don't declare.
9027 * tui/tui-win.c (tui_win_info::forward_scroll)
9028 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9029 (tui_win_info::right_scroll): Rename and update.
9030 (tui_scroll_forward_command, tui_scroll_backward_command)
9031 (tui_scroll_left_command, tui_scroll_right_command): Update.
9032 (tui_scroll): Remove.
9033 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9034 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9035 from tui_vertical_source_scroll.
9036 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9037 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9038 from tui_vertical_disassem_scroll.
9039 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9040 do_scroll_horizontal>: New methods.
9041 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9042 Likewise.
9043 (struct tui_source_window_base): Add do_scroll_horizontal.
9044 (struct tui_source_window, struct tui_disasm_window): Add
9045 do_scroll_vertical.
9046 (struct tui_data_window, struct tui_cmd_window): Add
9047 do_scroll_horizontal and do_scroll_vertical.
9048 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9049
5cf82909
TT		 90502019-06-25 Tom Tromey <tom@tromey.com>
9051
9052 * tui/tui-data.h (struct tui_source_window_base): New struct.
9053 (struct tui_source_window): Derive from tui_source_window_base.
9054 (struct tui_disasm_window): New struct.
9055 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9056 from tui_source_window::clear_detail.
9057 (tui_source_window_base): Rename from tui_source_window.
9058 (~tui_source_window_base): Rename from ~tui_source_window.
9059 (tui_alloc_win_info): Create a tui_disasm_window.
9060
ee1d42d6
TT		 90612019-06-25 Tom Tromey <tom@tromey.com>
9062
9063 * tui/tui-data.h (struct tui_source_window)
9064 (struct tui_data_window): Declare destructors.
9065 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9066 destructors.
9067 (tui_win_info): Simplify.
9068
b4eb2452
TT		 90692019-06-25 Tom Tromey <tom@tromey.com>
9070
9071 * tui/tui-winsource.c (tui_display_main)
9072 (tui_update_source_windows_with_addr)
9073 (tui_update_all_breakpoint_info): Update.
9074 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9075 (new_height_ok, parse_scrolling_args): Update.
9076 * tui/tui-stack.c (tui_show_frame_info): Update.
9077 * tui/tui-data.h (struct tui_list): Remove.
9078 (tui_source_windows): Return a reference to a std::vector.
9079 * tui/tui-data.c (source_windows): Now a std::vector.
9080 (tui_source_windows): Change return type.
9081 (tui_clear_source_windows): Rewrite.
9082 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9083 (tui_free_all_source_wins_content): Rewrite.
9084
8761a91b
TT		 90852019-06-25 Tom Tromey <tom@tromey.com>
9086
9087 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9088 (struct tui_data_window, struct tui_cmd_window): Declare
9089 clear_detail method.
9090 * tui/tui-data.c (tui_source_window::clear_detail)
9091 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9092 methods.
9093 (tui_clear_win_detail): Simplify.
9094
0ed69eda
TT		 90952019-06-25 Tom Tromey <tom@tromey.com>
9096
9097 * tui/tui-layout.c (make_source_window, make_disasm_window)
9098 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9099 Return the new window.
9100 (show_source_disasm_command, show_data)
9101 (show_source_or_disasm_and_command): Update.
9102
82432e10
TT		 91032019-06-25 Tom Tromey <tom@tromey.com>
9104
9105 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9106 parameter. Return the new window.
9107 (show_source_disasm_command): Update and remove NULL check.
9108 (show_source_or_disasm_and_command): Update.
9109
ec328aa5
TT		 91102019-06-25 Tom Tromey <tom@tromey.com>
9111
9112 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9113
33b906ab
TT		 91142019-06-25 Tom Tromey <tom@tromey.com>
9115
9116 * tui/tui-data.h (struct tui_win_info): Make constructor
9117 protected. Make destructor virtual. Add initializers.
9118 (tui_source_window, tui_data_window, tui_cmd_window): New
9119 classes.
9120 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9121 constructor. Add "type" parameter.
9122 (tui_source_window, tui_data_window, tui_cmd_window): New
9123 constructors.
9124 (tui_alloc_win_info): Instantiate the appropriate subclass.
9125
e7e11af4
TT		 91262019-06-25 Tom Tromey <tom@tromey.com>
9127
9128 * tui/tui-win.c (tui_resize_all): Use delete.
9129 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9130 destructor.
9131 (tui_free_window): Don't declare.
9132 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9133 Update.
9134
6792b55e
TT		 91352019-06-25 Tom Tromey <tom@tromey.com>
9136
9137 * tui/tui-data.h (struct tui_win_info): Add constructor.
9138 * tui/tui-data.c (tui_alloc_win_info): Use new.
9139 (tui_free_window): Use delete.
9140
f95675e1
TT		 91412019-06-22 Tom Tromey <tom@tromey.com>
9142
9143 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9144 declare.
9145 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9146
5bff081c
TT		 91472019-06-22 Tom Tromey <tom@tromey.com>
9148
9149 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9150 declare.
9151 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9152
47e3f474
TV		 91532019-06-22 Tom de Vries <tdevries@suse.de>
9154
9155 * dwarf2read.c (create_addrmap_from_aranges)
9156 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9157 instead of '%zu'.
9158
fd5866f6
SM		 91592019-06-21 Simon Marchi <simon.marchi@efficios.com>
9160
9161 * dwarf2read.h (dwarf2_section_info_def): Remove.
9162 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9163 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9164 std::vector<dwarf2_section_info>.
9165 (struct dwo_file) <~dwo_file>: Remove.
9166 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9167 types field.
9168 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9169 (dwarf2_read_debug_names): Likewise.
9170 (create_debug_types_hash_table): Change parameter type to
9171 array_view, adjust code accordingly.
9172 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9173 (partial_die_info::fixup): Likewise.
9174 (determine_prefix): Likewise.
9175 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9176
fb1eb2f9
SM		 91772019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9178
9179 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9180 gdb_bfd_ref_ptr.
9181 <~dwo_file>: Remove call to gdb_bfd_unref.
9182 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9183 gdb_bfd_ref_ptr::get.
9184
51ac9db5
SM		 91852019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9186
9187 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9188 type to htab_up.
9189 * dwarf2read.c (struct dwo_file): Initialize fields.
9190 <~dwo_file>: New.
9191 (free_dwo_file): Remove, move content to ~dwo_file.
9192 (struct dwo_file_deleter): Remove.
9193 (dwo_file_up>: Remove custom deleter.
9194 (free_dwo_files): Remove.
9195 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9196 dwo_files.
9197 (process_skeletonless_type_units): Call unique_ptr::get.
9198 (allocate_dwo_file_hash_table): Add deleter to created hash
9199 table. Change return type to htab_up.
9200 (lookup_dwo_file_slot): Don't memset dwo_file, call
9201 unique_ptr::get.
9202 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9203 (create_dwo_unit_in_dwp_v2): Likewise.
9204 (open_and_init_dwo_file): Likewise.
9205 (free_dwo_file_from_slot): Remove.
9206
dc4ccb6f
SM		 92072019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9208
9209 * dwarf2read.h (struct dwarf2_section_info) <readin,
9210 is_virtual>: Change type to bool.
9211 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9212 true instead of 1.
9213
e6a1c5cb
TT		 92142019-06-19 Tom Tromey <tom@tromey.com>
9215
9216 * tui/tui-data.h (tui_init_content_element): Don't declare.
9217
6f6ffbeb
TT		 92182019-06-19 Tom Tromey <tom@tromey.com>
9219
9220 * tui/tui-data.h (tui_init_win_info): Don't declare.
9221
f23f598e
TV		 92222019-06-19 Tom de Vries <tdevries@suse.de>
9223
9224 * dwarf2read.h (abstract_to_concrete): Change type to
9225 std::unordered_map<sect_offset, std::vector<sect_offset>,
9226 gdb::hash_enum<sect_offset>>.
9227
680e1bee
TT		 92282019-06-19 Tom Tromey <tromey@adacore.com>
9229
9230 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9231 EVAL_AVOID_SIDE_EFFECTS specially.
9232
dcf37923
TT		 92332019-06-19 Tom Tromey <tromey@adacore.com>
9234
9235 * source-cache.c (highlighter): New global.
9236 (source_cache::get_source_lines): Create a highlighter on demand.
9237
494986d5
AB		 92382019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9239
9240 * defs.h (deprecated_interactive_hook): Delete declaration.
9241 * interps.c (clear_interpreter_hooks): Remove use of
9242 deprecated_interactive_hook.
9243 * top.c (deprecated_interactive_hook): Delete definition.
9244 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9245
3360b6e7
TV		 92462019-06-18 Tom de Vries <tdevries@suse.de>
9247
9248 PR gdb/24515
9249 * dwarf2read.h (abstract_to_concrete): Change type from
9250 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9251 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9252 * dwarf2read.c (read_variable): Update.
9253 (dwarf2_fetch_die_loc_sect_off): Update.
9254
310b3441
TV		 92552019-06-17 Tom de Vries <tdevries@suse.de>
9256
9257 PR gdb/24617
9258 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9259 accessing parent[parent_len - 1].
9260
ba9777be
PP		 92612019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9262
9263 PR gdb/24364
9264 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9265 call dtrace_process_dof with NULL dof.
9266
2b9f6e89
TV		 92672019-06-16 Tom de Vries <tdevries@suse.de>
9268
9269 PR gdb/24445
9270 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9271
431b3ead
TT		 92722019-06-16 Tom Tromey <tom@tromey.com>
9273
9274 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9275 (make_all_visible): Use address of member.
9276
d04b44a1
TT		 92772019-06-16 Tom Tromey <tom@tromey.com>
9278
9279 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9280 (tui_free_window, free_content, free_content_elements): Remove
9281 unnecessary cast.
9282 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9283 cast.
9284 * tui/tui-regs.c (tui_show_register_group)
9285 (tui_display_registers_from, tui_display_reg_element_at_line):
9286 Remove unnecessary cast.
9287
bf5142e7
AB		 92882019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9289
9290 * linux-nat.c (normal_mask): Delete.
9291 (_initialize_linux_nat): Don't initialise normal_mask.
9292
c4973306
SM		 92932019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9294
9295 PR gdb/24445
9296 * dwarf-index-write.h (write_psymtabs_to_index): Add
9297 dwz_basename parameter.
9298 * dwarf-index-write.c (write_gdbindex): Move file writing to
9299 write_gdbindex_1. Change return type void.
9300 (assert_file_size): Move up, remove filename parameter.
9301 (write_gdbindex_1): New function.
9302 (write_debug_names): Change return type to void, call
9303 assert_file_size.
9304 (struct index_wip_file): New struct.
9305 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9306 file logic to index_wip_file. Write index for dwz file if
9307 needed.
9308 (save_gdb_index_command): Pass basename of dwz file, if present.
9309 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9310 build-id of dwz file, if present.
9311 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9312 (dwarf2_get_dwz_file): Likewise.
9313 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9314 (dwarf2_get_dwz_file): Likewise.
9315
395f9c91
TT		 93162019-06-16 Tom Tromey <tom@tromey.com>
9317
9318 * coffread.c (process_coff_symbol): Use xstrdup.
9319 * value.c (create_internalvar): Use xstrdup.
9320
cafb3438
TT		 93212019-06-16 Tom Tromey <tom@tromey.com>
9322
9323 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9324 * breakpoint.c (stopin_command, stopat_command)
9325 (until_break_command, decode_location_default): Remove unnecessary
9326 cast.
9327 * utils.c (subset_compare): Remove unnecessary cast.
9328 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9329 cast.
9330 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9331 cast.
9332 * infcmd.c (path_command): Remove unnecessary cast.
9333 * coffread.c (decode_type): Remove unnecessary cast.
9334 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9335 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9336 * tui/tui-stack.c (tui_show_locator_content)
9337 (tui_show_frame_info): Remove unnecessary cast.
9338 * tui/tui-win.c (tui_scroll_forward_command)
9339 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9340 (parse_scrolling_args): Remove unnecessary cast.
9341 * tui/tui-data.c (init_win_info, tui_del_window)
9342 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9343 (free_content_elements): Remove unnecessary cast.
9344 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9345 unnecessary cast.
9346 * tui/tui-source.c (tui_set_source_content)
9347 (tui_vertical_source_scroll): Remove unnecessary cast.
9348 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9349 cast.
9350 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9351 * tui/tui-regs.c (tui_display_registers_from)
9352 (tui_display_register): Remove unnecessary cast.
9353 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9354 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9355 (make_visible): Remove unnecessary cast.
9356 * tui/tui-winsource.c (tui_erase_source_content)
9357 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9358 unnecessary cast.
9359 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9360 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9361 * stabsread.c (read_type, read_array_type, read_range_type):
9362 Remove unnecessary cast.
9363 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9364 (parse_symbol, parse_type, upgrade_type, parse_external)
9365 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9366 unnecessary cast.
9367 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9368
730ead81
TT		 93692019-06-16 Tom Tromey <tom@tromey.com>
9370
9371 * tui/tui-data.c (tui_alloc_generic_win_info)
9372 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9373 checks.
9374
584a927c
AB		 93752019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9376 Andrew Burgess <andrew.burgess@embecosm.com>
9377
9378 * f-typeprint.c (f_print_type): Don't return early for not
9379 associated or not allocated types.
9380 (f_type_print_varspec_suffix): Add print_rank parameter and print
9381 ranks of array types in case they dangling.
9382 (f_type_print_base): Add print_rank parameter.
9383
30056ea0
AB		 93842019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9385
9386 * NEWS: Mention new MI commands.
9387 * break-catch-throw.c (enum exception_event_kind): Move to
9388 breakpoint.h.
9389 (print_mention_exception_catchpoint): Output text as a single
9390 message.
9391 (catch_exception_command_1): Rename to...
9392 (catch_exception_event): ...this, make non-static, update header
9393 command, and change some parameter types.
9394 (catch_catch_command): Update for changes to
9395 catch_exception_command_1.
9396 (catch_throw_command): Likewise.
9397 (catch_rethrow_command): Likewise.
9398 * breakpoint.c (enum exception_event_kind): Delete.
9399 * breakpoint.h (enum exception_event_kind): Moved here from
9400 break-catch-throw.c.
9401 (catch_exception_event): Declare.
9402 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9403 (mi_cmd_catch_throw): New function.
9404 (mi_cmd_catch_rethrow): New function.
9405 (mi_cmd_catch_catch): New function.
9406 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9407 'catch-catch' entries.
9408 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9409 (mi_cmd_catch_rethrow): Declare.
9410 (mi_cmd_catch_catch): Declare.
9411
ec8e2b6d
AB		 94122019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9413
9414 * annotate.c (annotate_source_line): Change return type to void,
9415 update implementation to match.
9416 * annotate.h (annotate_source_line): Change return type to void,
9417 update header comment.
9418 * stack.c (print_frame_info): Don't change what frame information
9419 is printed based on whether annotations are on or not.
9420
0d3abd8c
AB		 94212019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9422
9423 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9424 (annotate_source): Make static.
9425 (annotate_source_line): Moved from source.c and renamed from
9426 identify_source_line. Update the return type.
9427 * annotate.h (annotate_source): Delete declaration.
9428 (annotate_source_line): Declaration moved from source.h, and
9429 renamed from identify_source_line. Return type updated.
9430 * source.c (identify_source_line): Moved to annotate.c and renamed
9431 to annotate_source_line.
9432 (info_line_command): Remove check of annotation_level.
9433 * source.h (identify_source_line): Move declaration to annotate.h
9434 and rename to annotate_source_line.
9435 * stack.c: Add 'annotate.h' include.
9436 (print_frame_info): Remove check of annotation_level before
9437 calling annotate_source_line.
9438
00df30ae
AB		 94392019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9440
9441 * source-cache.c (source_cache::get_plain_source_lines): Use
9442 open_source_file_with_line_charpos instead of just
9443 open_source_file, remove call to find_source_lines.
9444 (source_cache::get_source_lines): Likewise.
9445 * source.c (find_source_lines): Make static.
9446 (get_filename_and_charpos): Renamed into...
9447 (open_source_file_with_line_charpos): ..this along with changes to
9448 return a scoped_fd, and some other minor clean ups.
9449 (identify_source_line): Use open_source_file_with_line_charpos.
9450 (search_command_helper): Use open_source_file_with_line_charpos
9451 instead of just open_source_file, remove call to
9452 find_source_lines.
9453 * source.h (open_source_file_with_line_charpos): Declare new
9454 function.
9455 (find_source_lines): Delete declaration.
9456
afda45a2
AB		 94572019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9458
9459 * source.c (get_filename_and_charpos): Remove fullname
9460 parameter.
9461 (identify_source_line): Update call to get_filename_and_charpos.
9462
0735b091
TT		 94632019-06-14 Tom Tromey <tromey@adacore.com>
9464
9465 PR gdb/24502:
9466 * ui-style.h (skip_ansi_escape): Update comment.
9467 * ui-file.h (class no_terminal_escape_file): New class.
9468 * ui-file.c (no_terminal_escape_file::write)
9469 (no_terminal_escape_file::puts): New methods.
9470 * cli/cli-logging.c (handle_redirections): Use
9471 no_terminal_escape_file.
9472
52ce35e2
TT		 94732019-06-14 Tom Tromey <tromey@adacore.com>
9474
9475 * NEWS: Move convenience variable news above Python news.
9476
73cc7272
TT		 94772019-06-14 Tom Tromey <tom@tromey.com>
9478
9479 * gnulib: Move directory to top-level.
9480 * configure.ac: Don't configure gnulib.
9481 * configure: Rebuild.
9482 * common/common-defs.h: Use new path to gnulib.
9483 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9484 (GNULIB_H): Remove.
9485 (INCGNU): Look in new gnulib location.
9486 (HFILES_NO_SRCDIR): Remove gnulib files.
9487 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9488 (generated_files): Remove GNULIB_H.
9489 ($(LIBGNU), all-lib): Remove targets.
9490 (distclean): Don't mention GNULIB_BUILDDIR.
9491 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9492
f5686554
TT		 94932019-06-14 Tom Tromey <tromey@adacore.com>
9494
9495 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9496 Warn if symbol file does not provide any symbols.
9497
a0c1ffed
TT		 94982019-06-14 Tom Tromey <tromey@adacore.com>
9499
9500 * source.c (find_and_open_source): Respect basenames_may_differ.
9501
7c39e397
AB		 95022019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9503
9504 * annotate.c (annotate_breakpoints_invalid): Make use of
9505 scoped_restore_terminal_state.
9506 (annotate_frames_invalid): Likewise.
9507
f411722c
TT		 95082019-06-14 Tom Tromey <tromey@adacore.com>
9509
9510 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9511 allow assignment to an internalvar.
9512
4268ec18
TT		 95132019-06-14 Tom Tromey <tromey@adacore.com>
9514
9515 * ada-lex.l: Allow "_" in attribute names.
9516
abdb711e
TT		 95172019-06-14 Tom Tromey <tromey@adacore.com>
9518
9519 PR gdb/24653:
9520 * regcache.c (registers_changed): Don't call alloca.
9521 * top.c (execute_command): Don't call alloca.
9522
4c048731
PA		 95232019-06-13 Pedro Alves <palves@redhat.com>
9524
9525 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9526 'expression'. When parsing an expression, error out if there's
9527 junk after "unlimited".
9528 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9529 (do_set_command): Adjust calls to is_unlimited_literal.
9530
66eb1ed3
PA		 95312019-06-13 Pedro Alves <palves@redhat.com>
9532
9533 * compile/compile.c (make_compile_options_def_group): Add braces
9534 around array_view initializer.
9535 * thread.c (make_thread_apply_all_options_def_group)
9536 (make_thread_apply_all_options_def_group): Likewise.
9537
3345721a
PA		 95382019-06-13 Pedro Alves <palves@redhat.com>
9539
9540 * NEWS (New commands): Mention "maint test-options
9541 require-delimiter", "maint test-options unknown-is-error", "maint
9542 test-options unknown-is-operand" and "maint show
9543 test-options-completion-result".
9544 (New command options, command completion): New section.
9545 (Completion improvements): New section.
9546 Mention that you can abbreviate "unlimited".
9547
6206060d
PA		 95482019-06-13 Pedro Alves <palves@redhat.com>
9549
9550 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9551 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9552 * unittests/cli-utils-selftests.c (test_parse_flags)
9553 (test_parse_flags_qcs): Delete.
9554 (test_cli_utils): Don't call deleted functions.
9555
6665660a
PA		 95562019-06-13 Pedro Alves <palves@redhat.com>
9557
9558 * thread.c: Include "cli/cli-option.h".
9559 (tp_array_compar_ascending): Global.
9560 (tp_array_compar): Delete function.
9561 (tp_array_compar_ascending, tp_array_compar_descending): New
9562 functions.
9563 (ascending_option_def, qcs_flag_option_def)
9564 (thr_qcs_flags_option_defs)
9565 (make_thread_apply_all_options_def_group)
9566 (make_thread_apply_options_def_group): New.
9567 (thread_apply_all_command): Use gdb::option::process_options.
9568 (thread_apply_command_completer)
9569 (thread_apply_all_command_completer): New.
9570 (thread_apply_command): Use gdb::option::process_options.
9571 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9572 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9573 to generate help text of "thread apply". Adjust "taas"'s help.
9574 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9575 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9576
f7e13587
PA		 95772019-06-13 Pedro Alves <palves@redhat.com>
9578
9579 * thread.c (thread_apply_command): Check for invalid TID with
9580 isdigit instead of !isalpha.
9581
5d707134
PA		 95822019-06-13 Pedro Alves <palves@redhat.com>
9583
9584 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9585 (validate_flags_qcs): New.
9586 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9587 (validate_flags_qcs): Declare.
9588 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9589 (make_frame_apply_options_def_group): New.
9590 (frame_apply_command_count): Process options with
9591 gdb::option::process_options.
9592 (frame_apply_completer): New.
9593 (frame_apply_level_completer, frame_apply_all_completer)
9594 (frame_apply_completer): New.
9595 (_initialize_stack): Update help of "frame apply", "frame apply
9596 level", "frame apply all" and "faas" to mention supported options
9597 and install command completers.
9598 * stack.h (frame_apply_all_completer): Declare.
9599 * thread.c: Include "stack.h".
9600 (tfaas_command): Add "--".
9601 (_initialize_thread): Update help "tfaas" to mention supported
9602 options and install command completer.
9603
272d4594
PA		 96042019-06-13 Pedro Alves <palves@redhat.com>
9605
9606 * completer.c (complete_nested_command_line): New.
9607 (gdb_completion_word_break_characters_throw): Add assertion.
9608 * completer.h (complete_nested_command_line): Declare.
9609
90a1ef87
PA		 96102019-06-13 Pedro Alves <palves@redhat.com>
9611
9612 * stack.c (parse_backtrace_qualifiers): New.
9613 (backtrace_command): Use it.
9614 (backtrace_command_completer): Complete on qualifiers.
9615
d4c16835
PA		 96162019-06-13 Pedro Alves <palves@redhat.com>
9617
9618 * frame.c: Include "cli/cli-option.h.
9619 (user_set_backtrace_options): New.
9620 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9621 Delete.
9622 (get_prev_frame): Adjust.
9623 (boolean_option_def, uinteger_option_def)
9624 (set_backtrace_option_defs): New.
9625 (_initialize_frame): Adjust and use
9626 gdb::option::add_setshow_cmds_for_options to install "set
9627 backtrace past-main" and "set backtrace past-entry".
9628 * frame.h: Include "cli/cli-option.h".
9629 (struct frame_print_options): Forward declare.
9630 (print_frame_arguments_all, print_frame_arguments_scalars)
9631 (print_frame_arguments_none): Declare.
9632 (print_entry_values): Delete declaration.
9633 (struct frame_print_options, user_frame_print_options): New.
9634 (struct set_backtrace_options): New.
9635 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9636 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9637 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9638 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9639 (list_args_or_locals): Add frame_print_options parameter.
9640 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9641 * python/py-framefilter.c (enumerate_args): Pass down
9642 USER_FRAME_PRINT_OPTIONS.
9643 * stack.c: Include "cli/cli-option.h".
9644 (print_frame_arguments_all, print_frame_arguments_scalars)
9645 (print_frame_arguments_none): Declare.
9646 (print_raw_frame_arguments, print_entry_values): Delete.
9647 (user_frame_print_options): New.
9648 (boolean_option_def, enum_option_def, frame_print_option_defs):
9649 New.
9650 (struct backtrace_cmd_options): New.
9651 (bt_flag_option_def): New.
9652 (backtrace_command_option_defs): New.
9653 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9654 (print_frame_arg, read_frame_arg, print_frame_args)
9655 (print_frame_info, print_frame): Add frame_print_options parameter
9656 and use it.
9657 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9658 (backtrace_command_1): Add frame_print_options and
9659 backtrace_cmd_options parameters and use them.
9660 (make_backtrace_options_def_group): New.
9661 (backtrace_command): Process command options with
9662 gdb::option::process_options.
9663 (backtrace_command_completer): New.
9664 (_initialize_stack): Extend "backtrace"'s help to mention
9665 supported options. Install completer for "backtrace".
9666 Install some settings commands with add_setshow_cmds_for_options.
9667
2daf894e
PA		 96682019-06-13 Pedro Alves <palves@redhat.com>
9669
9670 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9671 and that "set/show print raw frame-arguments" are now deprecated.
9672
9673 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9674 command.
9675 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9676 * stack.c (_initialize_stack): Install "set/show print
9677 raw-frame-arguments", and deprecate "set/show print raw
9678 frame-arguments".
9679 * valprint.c (_initialize_valprint): Deprecate "set/show print
9680 raw".
9681
e6ed716c
PA		 96822019-06-13 Pedro Alves <palves@redhat.com>
9683
9684 * compile/compile.c (struct compile_options): New.
9685 (compile_flag_option_def, compile_command_option_defs)
9686 (make_compile_options_def_group): New.
9687 (compile_file_command): Handle options with
9688 gdb::option::process_options.
9689 (compile_file_command_completer): New function.
9690 (compile_code_command): Handle options with
9691 gdb::option::process_options.
9692 (compile_code_command_completer): New function.
9693 (_initialize_compiler): Install completers for "compile code" and
9694 "compile file". Mention available options in "compile code" and
9695 "compile code"'s help.
9696 * completer.c (advance_to_completion_word): New, factored out from
9697 ...
9698 (advance_to_expression_complete_word_point): ... this.
9699 (advance_to_filename_complete_word_point): New.
9700 * completer.h (advance_to_filename_complete_word_point): New
9701 declaration.
9702
7d8062de
PA		 97032019-06-13 Pedro Alves <palves@redhat.com>
9704
9705 * compile/compile.c: Include "cli/cli-option.h".
9706 (compile_print_value): Scope data pointer is now a
9707 value_print_options pointer; adjust.
9708 (compile_print_command): Process options. Scope data pointer is
9709 now a value_print_options pointer; adjust.
9710 (_initialize_compile): Update "compile print"'s help to include
9711 supported options. Install a completer for "compile print".
9712 * cp-valprint.c (show_vtblprint, show_objectprint)
9713 (show_static_field_print): Delete.
9714 (_initialize_cp_valprint): Don't install "set print
9715 static-members", "set print vtbl", "set print object" here.
9716 * printcmd.c: Include "cli/cli-option.h" and
9717 "common/gdb_optional.h".
9718 (print_command_parse_format): Rework to fill in a
9719 value_print_options instead of a format_data.
9720 (print_value): Change parameter type from format_data pointer to
9721 value_print_options reference. Adjust.
9722 (print_command_1): Process options. Adjust to pass down a
9723 value_print_options.
9724 (print_command_completer): New.
9725 (_initialize_printcmd): Install print_command_completer as
9726 handle_brkchars completer for the "print" command. Update
9727 "print"'s help to include supported options.
9728 * valprint.c: Include "cli/cli-option.h".
9729 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9730 here from cp-valprint.c.
9731 (boolean_option_def, uinteger_option_def)
9732 (value_print_option_defs, make_value_print_options_def_group):
9733 New. Use gdb::option::add_setshow_cmds_for_options to install
9734 "set print elements", "set print null-stop", "set print repeats",
9735 "set print pretty", "set print union", "set print array", "set
9736 print address", "set print symbol", "set print array-indexes".
9737 * valprint.h: Include <string> and "cli/cli-option.h".
9738 (make_value_print_options_def_group): Declare.
9739 (print_value): Change parameter type from format_data pointer to
9740 value_print_options reference.
9741 (print_command_completer): Declare.
9742
9d0faba9
PA		 97432019-06-13 Pedro Alves <palves@redhat.com>
9744
9745 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9746 (COMMON_SFILES): Add maint-test-settings.c.
9747 * cli/cli-decode.c (boolean_enums): New global, factored out from
9748 ...
9749 (add_setshow_boolean_cmd): ... here.
9750 * cli/cli-decode.h (boolean_enums): Declare.
9751 * cli/cli-option.c: New file.
9752 * cli/cli-option.h: New file.
9753 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9754 factored out from ...
9755 (parse_cli_boolean_value(const char *)): ... this.
9756 (is_unlimited_literal): Change parameter type to pointer to
9757 pointer. Adjust and advance ARG pointer.
9758 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9759 (parse_cli_var_enum): New, factored out from ...
9760 (do_set_command): ... this. Adjust.
9761 * cli/cli-setshow.h (parse_cli_boolean_value)
9762 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9763 (parse_cli_var_enum): Declare.
9764 * cli/cli-utils.c: Include "cli/cli-option.h".
9765 (get_ulongest): New.
9766 * cli/cli-utils.h (get_ulongest): Declare.
9767 (check_for_argument): New overloads.
9768 * maint-test-options.c: New file.
9769
2c722807
PA		 97702019-06-13 Pedro Alves <palves@redhat.com>
9771
9772 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9773 parse a range if "-" is at the end of the string.
9774
dee7b4c8
PA		 97752019-06-13 Pedro Alves <palves@redhat.com>
9776
9777 * cli/cli-setshow.c (parse_auto_binary_operation)
9778 (parse_cli_boolean_value): Don't allow "o".
9779
dca0f6c0
PA		 97802019-06-13 Pedro Alves <palves@redhat.com>
9781
9782 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9783 * NEWS: Mention maint test-settings KIND.
9784 * maint-test-settings.c: New file.
9785
597bf39d
PA		 97862019-06-13 Pedro Alves <palves@redhat.com>
9787
9788 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9789 completer.
9790 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9791 "set" completers.
9792
48c410fb
PA		 97932019-06-13 Pedro Alves <palves@redhat.com>
9794
9795 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9796 after item.
9797
93bcb043
PA		 97982019-06-13 Pedro Alves <palves@redhat.com>
9799
9800 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9801
cbba3ecd
PA		 98022019-06-13 Pedro Alves <palves@redhat.com>
9803
9804 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9805 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9806 call.
9807 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9808 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9809 calls.
9810 (check_for_argument): Skip spaces after argument.
9811
b9a3f842
PA		 98122019-06-13 Pedro Alves <palves@redhat.com>
9813
9814 * thread.c (thread_apply_command): Adjust TID parsing.
9815 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9816 detected before end of string.
9817 (tid_is_in_list): Error out if LIST is invalid.
9818
3844e605
PA		 98192019-06-13 Pedro Alves <palves@redhat.com>
9820
9821 * completer.c (complete_line_internal_1): Rewind completion word
9822 point.
9823 (completion_tracker::advance_custom_word_point_by): Change
9824 parameter type to int.
9825 * completer.h (completion_tracker::advance_custom_word_point_by):
9826 Likewise.
9827
00b56dbe
PA		 98282019-06-13 Pedro Alves <palves@redhat.com>
9829
9830 * completer.c (advance_to_completion_word): Handle delimiters.
9831
d106773e
PA		 98322019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9833
9834 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9835
08f10e02
TT		 98362019-06-11 Tom Tromey <tom@tromey.com>
9837
9838 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9839 (xmalloc_failed): Move to alloc.c.
9840 * alloc.c: New file.
9841 * Makefile.in (COMMON_SFILES): Add alloc.c.
9842
1c7fe951
TT		 98432019-06-11 Tom Tromey <tom@tromey.com>
9844
9845 * nat/linux-waitpid.c: Don't include server.h.
9846 (linux_debug): Remove.
9847 (my_waitpid): Update.
9848
89549d7f
TT		 98492019-06-11 Tom Tromey <tromey@adacore.com>
9850
9851 * infcall.c (_initialize_infcall): Remove trailing newline from
9852 help.
9853 * user-regs.c (_initialize_user_regs): Remove trailing newline
9854 from help.
9855 * typeprint.c (_initialize_typeprint): Remove trailing newline
9856 from help.
9857 * reverse.c (_initialize_reverse): Remove trailing newlines from
9858 help.
9859 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9860 from help.
9861 * language.c (add_set_language_command): Remove trailing newline
9862 from help.
9863 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9864 help.
9865 * disasm.c (_initialize_disasm): Remove trailing newline from
9866 help.
9867 * top.c (init_main): Remove trailing newline from help.
9868 * interps.c (_initialize_interpreter): Remove trailing newline
9869 from help.
9870 * btrace.c (_initialize_btrace): Remove trailing newlines from
9871 help.
9872 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9873 from help.
9874 * python/python.c (_initialize_python): Remove trailing newline
9875 from help.
9876 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9877 help.
9878 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9879 from help. Reformat some text.
9880 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9881 from help.
9882 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9883 newline from help.
9884
86108c13
TT		 98852019-06-11 Tom Tromey <tromey@adacore.com>
9886
9887 * darwin-nat.c (darwin_decode_exception_message)
9888 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9889
a7067863
AB		 98902019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9891
9892 * valops.c (value_slice): Check for not allocated or not
9893 associated values.
9894
9ab08412
TV		 98952019-06-10 Tom de Vries <tdevries@suse.de>
9896
9897 PR gdb/24618
9898 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9899 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9900 invalid.
9901
f19e22e9
TV		 99022019-06-10 Tom de Vries <tdevries@suse.de>
9903
9904 PR gdb/24611
9905 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9906 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9907
e99f9db0
TV		 99082019-06-10 Tom de Vries <tdevries@suse.de>
9909
9910 PR symtab/24545
9911 * symtab.c (struct demangled_name_entry): Add language field.
9912 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9913 static minimal symbol". Set and use language field.
9914
9bf7038b
TT		 99152019-06-10 Tom Tromey <tromey@adacore.com>
9916
9917 * ada-lang.c (_initialize_ada_language): Update help text.
9918
422186a9
TT		 99192019-06-10 Tom Tromey <tromey@adacore.com>
9920
9921 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9922 with a newline.
9923 * guile/guile.c (handle_boot_error): Don't end warning with a
9924 newline.
9925 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9926 warning with a newline.
9927 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9928 newline.
9929 (s12z_frame_cache): Likewise.
9930 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9931 a newline.
9932 * solib-svr4.c (disable_probes_interface): Don't end warning with
9933 a newline.
9934 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9935 newline.
9936 * python/python.c (do_finish_initialization): Don't end warning
9937 with a newline.
9938
25ce02ee
TT		 99392019-06-10 Tom Tromey <tom@tromey.com>
9940
9941 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9942 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9943 gdbpy_enter.
9944
caa429d8
TT		 99452019-06-10 Tom Tromey <tromey@adacore.com>
9946
9947 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9948 data.
9949 (elf_new_init): Don't call stabsread_new_init.
9950 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9951 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9952 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9953
81873cc8
TV		 99542019-06-10 Tom de Vries <tdevries@suse.de>
9955
9956 PR symtab/16264
9957 PR symtab/24517
9958 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9959
4fa0265e
РИ		 99602019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9961
9962 * source.c (find_and_open_source): Also rewrite relative file
9963 names.
9964
1a3da2cd
AB		 99652019-04-26 Amos Bird <amosbird@gmail.com>
9966
9967 * annotate.c (annotate_thread_exited): Add "thread-exited"
9968 annotation.
9969
3847a7bf
TT		 99702019-06-06 Tom Tromey <tromey@adacore.com>
9971
9972 * maint.h (class scoped_command_stats): Use
9973 DISABLE_COPY_AND_ASSIGN.
9974 <print_time>: New method.
9975 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9976 print_time.
9977 (scoped_command_stats::print_time): New method.
9978
312617a3
AB		 99792019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9980
9981 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9982 instructions of lengths 6 or 8 bytes.
9983
b02f78f9
PA		 99842019-06-04 Pedro Alves <palves@redhat.com>
9985
9986 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9987
9988 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9989 * breakpoint.c (condition_completer): Likewise.
9990 * cli/cli-dump.c (scan_expression): Likewise.
9991 * common/filestuff.c (mkdir_recursive): Likewise.
9992 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9993 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9994 (gdb_abspath): Likewise.
9995 * compile/compile-cplus-types.c
9996 (compile_cplus_instance::decl_name): Likewise.
9997 * completer.c (complete_explicit_location):
9998 (signal_completer, reg_or_group_completer_1): Likewise.
9999 * cp-support.c (cp_remove_params_if_any): Likewise.
10000 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10001 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10002 * infcmd.c (strip_bg_char): Likewise.
10003 * linespec.c (copy_token_string): Likewise.
10004 * mi/mi-main.c (output_cores): Likewise.
10005 * psymtab.c (psymtab_search_name):
10006 * symfile.c (test_set_ext_lang_command): Likewise.
10007 * target.c (target_fileio_read_stralloc): Likewise.
10008 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10009 * value.c (complete_internalvar): Likewise.
10010
e1f2e1a2
CB		 100112019-06-04 Christian Biesinger <cbiesinger@google.com>
10012
10013 Add objfile property to gdb.Type.
d3238f7d
PA		 10014 * NEWS: Mention Python API addition.
10015 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10016
e664d728
PW		 100172019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10018
10019 * NEWS: Mention the new set|show style [title|highlight].
10020 Mention changes to "show style", "help" and "apropos".
10021
66d8c862
PW		 100222019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10023
10024 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10025 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10026 instead of print_help_for_command.
10027 (print_doc_of_command): New function.
10028 (help_list): Add 'apropos -v word' suggestion.
10029 (print_help_for_command): Style the command name using title style.
10030 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10031 (_initialize_cli_cmds): Describe -v in apropos_command help.
10032
9303eb2f
PW		 100332019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10034
10035 * cli/cli-style.h (cli_style_option): Add name in constructor,
10036 add m_name class member, add constructor with intensity,
10037 add name class function.
10038 (cli_style_option::add_setshow_commands): Remove name argument.
10039 (highlight_style, title_style): New styles.
10040 * cli/cli-style.c (do_show): New function that shows a style
10041 characteristic styling the style name with itself.
10042 (set_style_name): New function.
10043 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10044 Update all callers according to the changes in cli/cli-style.h.
10045 * utils.h (fputs_highlighted): New function.
10046 * utils.c (fputs_highlighted): Likewise.
10047
e2c52041
PW		 100482019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10049
10050 * NEWS: Mention new pipe command and new convenience variables.
10051
947d3946
PW		 100522019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10053
10054 * cli/cli-cmds.c (pipe_command): New function.
10055 (_initialize_cli_cmds): Call add_com for pipe_command.
10056 Define | as an alias for pipe.
10057 (exit_status_set_internal_vars): New function.
10058 (shell_escape): Call exit_status_set_internal_vars.
10059 cli/cli-decode.c (find_command_name_length): Recognize | as
10060 a single character command.
10061
b8fd0918
PW		 100622019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10063
10064 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10065 top.c (execute_command_to_ui_file): New function, mostly a copy
10066 of execute_command_to_string.
10067 (execute_command_to_string): Implement by calling
10068 execute_command_to_ui_file.
10069
68bb5386
PW		 100702019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10071
10072 * top.h (saved_command_line): Remove declaration.
10073 * top.c (previous_saved_command_line, previous_repeat_arguments):
10074 New variables.
10075 (saved_command_line): Make static, define together with other
10076 'repeat variables'.
10077 (dont_repeat): Clear repeat_arguments.
10078 (repeat_previous, get_saved_command_line, save_command_line):
10079 New functions.
10080 (gdb_init): Initialize saved_command_line
10081 and previous_saved_command_line.
10082 * main.c (captured_main_1): Remove saved_command_line initialization.
10083 * event-top.c (handle_line_of_input): Update to use
10084 the new 'repeat' related functions instead of direct access to
10085 saved_command_line.
10086 * command.h (repeat_previous, get_saved_command_line,
10087 save_command_line): New declarations.
10088 (dont_repeat): Add comment.
10089
bfcdb852
TT		 100902019-05-30 Tom Tromey <tromey@adacore.com>
10091
10092 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10093 Fix comment.
10094 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10095
0ef209f2
JV		 100962019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10097
10098 PR cli/24587
10099 * completer.c (complete): Initialize variable word.
10100
955b06fa
SDJ		 101012019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10102
10103 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10104 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10105 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10106 'body' is NULL to the outter 'if', protecting the '!is_define'
10107 situation as well.
10108
fa9c3fa0
TT		 101092019-05-29 Tom Tromey <tromey@adacore.com>
10110
10111 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10112 (dwarf_unknown): New function.
10113 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10114 (dwarf_type_encoding_name): Use dwarf_unknown.
10115
4330d61d
TT		 101162019-05-29 Tom Tromey <tromey@adacore.com>
10117
10118 PR c++/20020:
10119 * cp-valprint.c (cp_print_value_fields): Call
10120 cp_print_static_field inside "try".
10121
33a6bc35
TT		 101222019-05-29 Tom Tromey <tromey@adacore.com>
10123
10124 * inflow.c (struct terminal_info): Add default operator=.
10125 * configure: Rebuild.
10126 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10127 -Wdeprecated-copy-dtor, -Wredundant-move.
10128
000439d5
TT		 101292019-05-29 Tom Tromey <tromey@adacore.com>
10130
10131 * NEWS: Add entry.
10132 * infcmd.c (print_return_value_1): Handle finish_print
10133 option.
10134 (show_print_finish): New function.
10135 (_initialize_infcmd): Add "set/show print finish" commands.
10136 * valprint.c (user_print_options): Initialize new member.
10137 * valprint.h (struct value_print_options) <finish_print>: New
10138 member.
10139
c0e70c62
TT		 101402019-05-28 Tom Tromey <tromey@adacore.com>
10141
10142 * ada-lang.c (ada_remove_Xbn_suffix)
10143 (find_old_style_renaming_symbol)
10144 (parse_old_style_renaming): Remove.
10145 (ada_find_renaming_symbol): Don't call
10146 find_old_style_renaming_symbol.
10147 (ada_is_renaming_symbol): Rename from
10148 ada_find_renaming_symbol. Remove "block" parameter. Return
10149 bool. Now static.
10150 (ada_read_var_value): Update and simplify.
10151 * ada-exp.y (write_var_or_type): Remove old code.
10152
766f8836
AH		 101532019-05-28 Alan Hayward <alan.hayward@arm.com>
10154
68255adc 10155 PR gdb/25010
766f8836
AH		 10156 * event-top.c: Remove include comment.
10157 * inflow.c (class scoped_ignore_sigttou): Move from here...
10158 * inflow.h (class scoped_ignore_sigttou): ...to here.
10159 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10160 * top.c: Remove include comment.
10161
eb41253a
TT		 101622019-05-27 Tom Tromey <tom@tromey.com>
10163
10164 * NEWS: Fix typo.
10165
4ca51187
TT		 101662019-05-22 Tom Tromey <tromey@adacore.com>
10167
10168 * target.c (target_follow_exec): Constify parameter.
10169 * target-delegates.c: Rebuild.
10170 * remote.c (remote_target::follow_exec): Constify parameter.
10171 * infrun.c (follow_exec): Constify parameter.
10172 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10173 (target_follow_exec): Likewise.
10174
8fca4da0
AH		 101752019-05-22 Alan Hayward <alan.hayward@arm.com>
10176
10177 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10178 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10179
b7060614
AH		 101802019-05-22 Alan Hayward <alan.hayward@arm.com>
10181
10182 * NEWS: Add debugredirect and testsuite sections.
10183
0a5954bd
SC		 101842019-05-22 Simon Cook <simon.cook@embecosm.com>
10185
10186 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10187 target descriptions using exclusively floating point register name
10188 aliases.
10189
dc42e902
AB		 101902019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10191
10192 PR gdb/18644:
10193 * f-lang.c (build_fortran_types): Handle the case where
10194 gdbarch_floatformat_for_type returns a nullptr.
10195
fb7806c7
TV		 101962019-05-21 Tom de Vries <tdevries@suse.de>
10197
10198 PR cli/24587
10199 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10200
34d11c68
AB		 102012019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10202
10203 PR gdb/18644:
10204 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10205 16-byte floats.
10206 * i386-tdep.c (i386_floatformat_for_type): Use
10207 floatformats_ia64_quad for the 16-byte floating point component
10208 within a fortran 32-byte complex number.
10209
122cf0f2
AB		 102102019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10211
10212 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10213 delete default constructor.
10214 (find_partial_die): Update to return const struct.
10215 (partial_die_parent_scope): Move variable declaration into scope
10216 of its use and change its type to auto.
10217 (guess_partial_die_structure_name): Likewise.
10218 (partial_die_info::fixup): Likewise.
10219
33d0e35a
TT		 102202019-05-17 Tom Tromey <tromey@adacore.com>
10221
10222 * source.c (find_and_open_source): Remove cast.
10223
a45575b0
TT		 102242019-05-17 Tom Tromey <tromey@adacore.com>
10225
10226 * annotate.c (annotate_source): Make "filename" const.
10227 * annotate.h (annotate_source): Use const.
10228
81f47ac2
AH		 102292019-05-17 Alan Hayward <alan.hayward@arm.com>
10230
10231 * disasm.c (set_disassembler_options): Send errors to stderr.
10232
ca1285d1
AH		 102332019-05-17 Alan Hayward <alan.hayward@arm.com>
10234
10235 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10236 (cli_interp_base::set_logging): Check debug_redirect.
10237 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10238 * cli/cli-logging.c (debug_redirect): Add static variable.
10239 (pop_output_files): Add default param.
10240 (handle_redirections): Print debug setting.
10241 (show_logging_command): Likewise.
10242 (_initialize_cli_logging): Add debugredirect command.
10243 * interps.c (current_interp_set_logging): Add debug_redirect
10244 parameter.
10245 * interps.h (set_logging): Add debug_redirect parameter.
10246 (current_interp_set_logging): Likewise.
10247 * mi/mi-common.h: Likewise.
10248 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10249
102502019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 10251 Tom Tromey <tromey@adacore.com>
10252
10253 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10254 directly.
10255 * cli/cli-interp.h (make_logging_output): Remove declaration.
10256 * cli/cli-logging.c (make_logging_output): Remove function.
10257 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10258 directly.
10259 * ui-file.c (tee_file::tee_file): Remove bools.
10260 (tee_file::~tee_file): Remove deletes.
10261 * ui-file.h (tee_file): Remove bools.
10262
26648588
JV		 102632019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10264
10265 * mi/mi-cmds.h (mi_cmd_complete): New function.
10266 * mi/mi-main.c (mi_cmd_complete): Likewise.
10267 * mi/mi-cmds.c: Define new MI command -complete.
10268 * NEWS: Mention new -complete command.
10269
6e035501
JV		 102702019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10271
10272 * completer.h (complete): New function.
10273 * completer.c (complete): Likewise.
10274 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10275 function defined in completer.h.
10276
7d0e2ece
JV		 102772019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10278
e79be6e5 10279 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10280
fb816e8b
TV		 102812019-05-17 Tom de Vries <tdevries@suse.de>
10282
10283 PR gdb/24094
10284 * dwarf2read.c (struct cu_partial_die_info): New struct.
10285 (find_partial_die): Return cu_partial_die_info.
10286 (partial_die_parent_scope, guess_partial_die_structure_name)
10287 (partial_die_info::fixup): Handle new return type of find_partial_die.
10288
677052f2
SDJ		 102892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10290
a1726c38 10291 PR breakpoints/24541
677052f2
SDJ		 10292 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10293 "std::string", simplifying the algorithm.
10294
f3da9116
SDJ		 102952019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10296
10297 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10298 (stap_static_probe_ops::get_probes): Likewise.
10299
f1bb75ab
SDJ		 103002019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10301
10302 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10303 '-')" and "else if".
10304 (stap_parse_single_operand): Join checks for
10305 "gdbarch_stap_parse_special_token_p" and
10306 "gdbarch_stap_parse_special_token" in the same "if" statement.
10307 Invert check when verifying for operation on register
10308 displacement.
10309
3ca58cde
SDJ		 103102019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10311
10312 * stap-probe.c (stap_get_opcode): Update comment.
10313 (stap_get_expected_argument_type): Likewise.
10314 (handle_stap_probe): Likewise.
10315
af2d9bee
SDJ		 103162019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10317
10318 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10319 return type to 'bool'. Adjust comment. Use 'bool' when
10320 appropriate.
10321 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10322 * stap-probe.c (stap_parse_argument_1): Likewise.
10323 (stap_is_operator): Likewise.
10324 (stap_is_generic_prefix): Likewise.
10325 (stap_is_register_prefix): Likewise.
10326 (stap_is_register_indirection_prefix): Likewise.
10327 (stap_is_integer_prefix): Likewise.
10328 (stap_generic_check_suffix): Likewise.
10329 (stap_check_integer_suffix): Likewise.
10330 (stap_check_register_suffix): Likewise.
10331 (stap_check_register_indirection_suffix): Likewise.
10332 (stap_parse_register_operand): Likewise.
10333 (stap_parse_single_operand): Likewise.
10334 (stap_parse_argument_1): Likewise.
10335 (stap_probe::get_argument_count): Likewise.
10336 (stap_is_operator): Likewise.
10337
61c9c421
TT		 103382019-05-16 Tom Tromey <tromey@adacore.com>
10339
10340 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10341 keyword to foreach.
10342
9ddc1af1
SM		 103432019-05-15 Simon Marchi <simon.marchi@efficios.com>
10344
10345 * linux-thread-db.c (try_thread_db_load_1): Change return type
10346 to bool.
10347 (try_thread_db_load): Likewise.
10348 (try_thread_db_load_from_pdir_1): Likewise.
10349 (try_thread_db_load_from_pdir): Likewise.
10350 (try_thread_db_load_from_sdir): Likewise.
10351 (try_thread_db_load_from_dir): Likewise.
10352 (thread_db_load_search): Likewise.
10353 (has_libpthread): Likewise.
10354 (thread_db_load): Likewise.
10355
7bede828
SDJ		 103562019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10357
10358 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10359 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10360 NULL, and complain/return if that's the case.
10361
c5358db4
JD		 103622019-05-15 John Darrington <john@darrington.wattle.id.au>
10363
10364 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10365 (advance, posn, abstract_read_memory): New functions.
10366 [struct mem_read_abstraction]: New struct.
10367 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10368
c408a94f
TT		 103692019-05-14 Tom Tromey <tromey@adacore.com>
10370
10371 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10372 value is not lval_memory.
10373
e7bd7fba
TT		 103742019-05-14 Tom Tromey <tromey@adacore.com>
10375
10376 * solib.c (info_sharedlibrary_command): Style the file name.
10377
a6d0f249
AH		 103782019-05-14 Alan Hayward <alan.hayward@arm.com>
10379
10380 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10381 (aarch64_vnv_type): Likewise.
10382 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10383 * common/tdesc.c: Likewise.
10384 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10385 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10386 * features/aarch64-fpu.xml: Add ieee half view.
10387 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10388 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10389 * gdbtypes.h (struct builtin_type): Likewise.
10390 (struct objfile_type): Likewise.
10391
66b8bb74
SM		 103922019-05-12 Paul Naert <paul.naert@polymtl.ca>
10393
10394 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10395 typo.
10396 * location.h (string_to_event_location): Likewise.
10397
21c219fd
JB		 103982019-05-11 Joel Brobecker <brobecker@adacore.com>
10399
10400 GDB 8.3 released.
10401
13674803
SM		 104022019-05-10 Simon Marchi <simon.marchi@efficios.com>
10403
10404 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10405 New variable declaration.
10406 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10407 New variable.
10408 (print_one_breakpoint): Use ui_out::test_flags and new global
10409 variable to compute use_fixed_output.
10410 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10411 Remove.
10412 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10413 (mi_multi_location_breakpoint_output_fixed): Remove.
10414 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10415 new variable.
10416 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10417 fix_multi_location_breakpoint_output flag if version >= 3.
10418 * ui-out.h (enum ui_out_flag)
10419 <fix_multi_location_breakpoint_output>: New enumerator.
10420
a9eac7f9
SM		 104212019-05-10 Simon Marchi <simon.marchi@efficios.com>
10422
10423 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10424
71bed2db
TT		 104252019-05-10 Tom Tromey <tromey@adacore.com>
10426
10427 * ada-lang.c (catch_ada_completer): New function.
10428 (_initialize_ada_language): Use it.
10429
24c54127
TT		 104302019-05-10 Tom Tromey <tromey@adacore.com>
10431
10432 * thread.c (print_thread_info): Make "requested_threads" const.
10433 * gdbthread.h (print_thread_info): Make "requested_threads"
10434 const.
10435 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10436 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10437
7a102139
TT		 104382019-05-08 Tom Tromey <tom@tromey.com>
10439
10440 * gdbtypes.c (objfile_type_data): Change type.
10441 (objfile_type, _initialize_gdbtypes): Update.
10442
924d79e2
TT		 104432019-05-08 Tom Tromey <tom@tromey.com>
10444
10445 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10446 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10447 (_initialize_dwarf2_frame): Update.
10448
4c58e337
TT		 104492019-05-08 Tom Tromey <tom@tromey.com>
10450
10451 * objc-lang.c (objc_objfile_data): Change type.
10452 (find_methods): Update.
10453 (_initialize_objc_lang): Remove.
10454
d772d2ab
TT		 104552019-05-08 Tom Tromey <tom@tromey.com>
10456
10457 * stabsread.c (rs6000_builtin_type_data): Change type.
10458 (rs6000_builtin_type, _initialize_stabsread): Update.
10459
d11d83f4
TT		 104602019-05-08 Tom Tromey <tom@tromey.com>
10461
10462 * mips-tdep.c (mips_pdr_data): Remove.
10463 (_initialize_mips_tdep): Update.
10464
9a73f0ad
TT		 104652019-05-08 Tom Tromey <tom@tromey.com>
10466
10467 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10468 (hppa_init_objfile_priv_data, read_unwind_info)
10469 (find_unwind_entry, _initialize_hppa_tdep): Update.
10470
8127a2fa
TT		 104712019-05-08 Tom Tromey <tom@tromey.com>
10472
10473 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10474 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10475 on obstack.
10476 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10477
91d3055d
TT		 104782019-05-08 Tom Tromey <tom@tromey.com>
10479
10480 * mdebugread.c (basic_type_data): Change type.
10481 (basic_type, _initialize_mdebugread): Update.
10482
31930bd3
TT		 104832019-05-08 Tom Tromey <tom@tromey.com>
10484
10485 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10486
bdb3ed9e
TT		 104872019-05-08 Tom Tromey <tom@tromey.com>
10488
10489 * nto-tdep.c (nto_inferior_data_reg): Change type.
10490 (nto_inferior_data): Update.
10491 (nto_inferior_data_cleanup, nto_new_inferior_data)
10492 (_initialize_nto_tdep): Remove.
10493 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10494
f37b313d
TT		 104952019-05-08 Tom Tromey <tom@tromey.com>
10496
10497 * ada-lang.c (struct ada_inferior_data): Add initializers.
10498 (ada_inferior_data): Change type.
10499 (ada_inferior_data_cleanup): Remove.
10500 (get_ada_inferior_data, ada_inferior_exit)
10501 (struct ada_pspace_data): Add initializers, destructor.
10502 (ada_pspace_data_handle): Change type.
10503 (get_ada_pspace_data): Update.
10504 (ada_pspace_data_cleanup): Remove.
10505
24699405
TT		 105062019-05-08 Tom Tromey <tom@tromey.com>
10507
10508 * coffread.c (struct coff_symfile_info): Add initializers.
10509 (coff_objfile_data_key): Move lower. Change type.
10510 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10511 Update.
10512 (coff_free_info): Remove.
10513
d4e05d2f
TT		 105142019-05-08 Tom Tromey <tom@tromey.com>
10515
10516 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10517 (fbsd_pspace_data_handle): Move lower. Change type.
10518 (get_fbsd_pspace_data): Update.
10519 (fbsd_pspace_data_cleanup): Remove.
10520 (_initialize_fbsd_tdep): Update.
10521
14ef6690
TT		 105222019-05-08 Tom Tromey <tom@tromey.com>
10523
10524 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10525 (get_ada_tasks_pspace_data): Update.
10526 (ada_tasks_pspace_data_cleanup): Remove.
10527 (_initialize_tasks): Update.
10528 (ada_tasks_inferior_data_handle): Change type.
10529 (get_ada_tasks_inferior_data): Update.
10530 (ada_tasks_inferior_data_cleanup): Remove.
10531 (struct ada_tasks_pspace_data): Add initializers.
10532
814cf43a
TT		 105332019-05-08 Tom Tromey <tom@tromey.com>
10534
10535 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10536 * symfile-debug.c (debug_sym_get_probes): Change type.
10537 * stap-probe.c (handle_stap_probe):
10538 (stap_static_probe_ops::get_probes): Change type.
10539 * probe.h (class static_probe_ops) <get_probes>: Change type.
10540 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10541 (parse_probes_in_pspace): Update.
10542 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10543 Update.
10544 (any_static_probe_ops::get_probes): Change type.
10545 * elfread.c (elfread_data): New typedef.
10546 (probe_key): Change type.
10547 (elf_get_probes): Likewise. Update.
10548 (probe_key_free): Remove.
10549 (_initialize_elfread): Update.
10550 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10551 Change type.
10552 (dtrace_process_dof_probe, dtrace_process_dof)
10553 (dtrace_static_probe_ops::get_probe): Change type.
10554
02dc647e
TT		 105552019-05-08 Tom Tromey <tom@tromey.com>
10556
10557 * xcoffread.c (struct xcoff_symfile_info): Rename from
10558 coff_symfile_info. Add initializers.
10559 (xcoff_objfile_data_key): Move lower. Change type.
10560 (XCOFF_DATA): Rewrite.
10561 (xcoff_free_info): Remove.
10562 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10563 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10564 (xcoff_initial_scan): Update.
10565
09232438
TT		 105662019-05-08 Tom Tromey <tom@tromey.com>
10567
10568 * solib-svr4.c (struct svr4_info): Add initializers and
10569 destructor.
10570 <probes_table>: Now an htab_up.
10571 (solib_svr4_pspace_data): Change type.
10572 (free_probes_table): Simplify.
10573 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10574 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10575 (probes_table_remove_objfile_probes, register_solib_event_probe)
10576 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10577 (_initialize_svr4_solib): Update.
10578
7b4a314f
TT		 105792019-05-08 Tom Tromey <tom@tromey.com>
10580
10581 * remote.c (remote_pspace_data): Change type.
10582 (remote_pspace_data_cleanup): Remove.
10583 (get_remote_exec_file, set_pspace_remote_exec_file)
10584 (_initialize_remote): Update.
10585
51d3063a
TT		 105862019-05-08 Tom Tromey <tom@tromey.com>
10587
10588 * breakpoint.c (breakpoint_objfile_key): Change type.
10589 (get_breakpoint_objfile_data): Update.
10590 (free_breakpoint_objfile_data): Remove.
10591 (_initialize_breakpoint): Update.
10592
89fb8848
TT		 105932019-05-08 Tom Tromey <tom@tromey.com>
10594
10595 * linux-tdep.c (struct linux_info): Add initializers.
10596 (linux_inferior_data): Move. Change type.
10597 (invalidate_linux_cache_inf): Update.
10598 (linux_inferior_data_cleanup): Remove.
10599 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10600
e9b89e2d
TT		 106012019-05-08 Tom Tromey <tom@tromey.com>
10602
10603 * auxv.c (auxv_inferior_data): Move. Change type.
10604 (auxv_inferior_data_cleanup): Remove.
10605 (invalidate_auxv_cache_inf): Rewrite.
10606 (get_auxv_inferior_data, _initialize_auxv): Update.
10607
8c42777c
TT		 106082019-05-08 Tom Tromey <tom@tromey.com>
10609
10610 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10611 (symfile_debug_objfile_data_key): Change type.
10612 (symfile_debug_installed, debug_qf_has_symbols)
10613 (debug_qf_find_last_source_symtab)
10614 (debug_qf_forget_cached_source_info)
10615 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10616 (debug_qf_print_stats, debug_qf_dump)
10617 (debug_qf_expand_symtabs_for_function)
10618 (debug_qf_expand_all_symtabs)
10619 (debug_qf_expand_symtabs_with_fullname)
10620 (debug_qf_map_matching_symbols)
10621 (debug_qf_expand_symtabs_matching)
10622 (debug_qf_find_pc_sect_compunit_symtab)
10623 (debug_qf_map_symbol_filenames)
10624 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10625 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10626 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10627 (debug_sym_read_linetable, debug_sym_relocate): Update.
10628 (symfile_debug_free_objfile): Remove.
10629 (install_symfile_debug_logging, _initialize_symfile_debug):
10630 Update.
10631
5bfd760d
TT		 106322019-05-08 Tom Tromey <tom@tromey.com>
10633
10634 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10635 allocate_on_obstack.
10636 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10637 (get_dwarf2_per_objfile): Update.
10638 (set_dwarf2_per_objfile): Remove.
10639 (dwarf2_has_info, dwarf2_get_section_info): Update.
10640 (dwarf2_free_objfile): Remove.
10641 (_initialize_dwarf2_read): Update.
10642
e85e19b4
TT		 106432019-05-08 Tom Tromey <tom@tromey.com>
10644
10645 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10646 initializers.
10647 <unsupported_script_warning_printed,
10648 script_not_found_warning_printed>: Now bool.
10649 (auto_load_pspace_data): Change type.
10650 (~auto_load_pspace_info): Rename from
10651 auto_load_pspace_data_cleanup.
10652 (get_auto_load_pspace_data, init_loaded_scripts_info)
10653 (clear_section_scripts, maybe_print_unsupported_script_warning)
10654 (maybe_print_script_not_found_warning, _initialize_auto_load):
10655 Update.
10656
f6aa7436
TT		 106572019-05-08 Tom Tromey <tom@tromey.com>
10658
10659 * objfiles.c (objfile_pspace_info): Add destructor and
10660 initializers.
10661 (objfiles_pspace_data): Change type.
10662 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10663 (get_objfile_pspace_data): Update.
10664 (objfiles_bfd_data): Change type.
10665 (get_objfile_bfd_data): Update.
10666 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10667
6ae614f6
TT		 106682019-05-08 Tom Tromey <tom@tromey.com>
10669
10670 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10671 Change type.
10672 (get_catch_syscall_inferior_data): Update.
10673 (catch_syscall_inferior_data_cleanup): Remove.
10674 (_initialize_break_catch_syscall): Update.
10675
6509b8eb
TT		 106762019-05-08 Tom Tromey <tom@tromey.com>
10677
10678 * inflow.c (struct terminal_info): Add destructor and
10679 initializers.
10680 (inflow_inferior_data): Change type.
10681 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10682 (get_inflow_inferior_data, inflow_inferior_exit)
10683 (swap_terminal_info, _initialize_inflow): Update.
10684
35632941
TT		 106852019-05-08 Tom Tromey <tom@tromey.com>
10686
10687 * target-dcache.c (target_dcache_cleanup): Remove.
10688 (target_dcache_aspace_key): Change type.
10689 (target_dcache_init_p, target_dcache_invalidate)
10690 (target_dcache_get, target_dcache_get_or_init)
10691 (_initialize_target_dcache): Update.
10692 * dcache.h (struct dcache_deleter): New.
10693
3017b94d
TT		 106942019-05-08 Tom Tromey <tom@tromey.com>
10695
10696 * symtab.c (struct symbol_cache): Add destructor and
10697 initializers.
10698 (symbol_cache_key): Move. Change type.
10699 (make_symbol_cache, free_symbol_cache): Remove.
10700 (get_symbol_cache): Update.
10701 (symbol_cache_cleanup): Remove.
10702 (ALL_PSPACES, symbol_cache_flush)
10703 (maintenance_print_symbol_cache)
10704 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10705 Update.
10706
a32ad8c5
TT		 107072019-05-08 Tom Tromey <tom@tromey.com>
10708
10709 * symtab.c (struct main_info): Add destructor and initializers.
10710 (main_progspace_key): Move. Change type.
10711 (get_main_info): Update.
10712 (main_info_cleanup): Remove.
10713 (_initialize_symtab): Update.
10714
5f6e90a0
TT		 107152019-05-08 Tom Tromey <tom@tromey.com>
10716
10717 * registry.h (DECLARE_REGISTRY): Define the _key class.
10718
1bd0c6e4
AB		 107192019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10720
10721 * NEWS: Merge two 'New commands' sections.
10722
2228ef77
XR		 107232019-05-08 Joel Brobecker <brobecker@adacore.com>
10724
10725 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10726 parameter and use Ada language definition instead.
10727 (ada_val_print_ptr): Remove unused language parameter.
10728 (ada_val_print_num): Remove language parameter and use Ada language
10729 definition instead.
10730 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10731 parameter.
10732 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10733 parameter and use Ada language definition instead.
10734 (ada_val_print_1): Update all ada_val_print_xxx calls.
10735 Remove language parameter.
10736 (ada_val_print): Update ada_val_print_1 call.
10737
60fcc1c3
TT		 107382019-05-08 Tom Tromey <tromey@adacore.com>
10739
10740 * remote.c (remote_hw_watchpoint_limit)
10741 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10742 Now static.
10743
ed2b7c17
TT		 107442019-05-08 Tom Tromey <tromey@adacore.com>
10745
10746 * maint.c (_initialize_maint_cmds): Move initialization code to
10747 remote.c.
10748 (watchdog, show_watchdog): Move to remote.c.
10749 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10750 "watchdog" static.
10751 (_initialize_remote): Move initialization code from maint.c.
10752 * defs.h (watchdog): Don't declare.
10753
b0be6c91
TT		 107542019-05-08 Tom Tromey <tromey@adacore.com>
10755
10756 * tui/tui-interp.c: Include main.h.
10757 * interps.c: Include main.h.
10758 * main.h (interpreter_p): Declare.
10759 * defs.h (interpreter_p): Don't declare.
10760
587ee17b
TT		 107612019-05-08 Tom Tromey <tromey@adacore.com>
10762
10763 * dwarf2loc.c: Include dwarf2read.h.
10764 * defs.h (read_unsigned_leb128): Don't declare.
10765 * dwarf2read.h (read_unsigned_leb128): Declare.
10766
ca1df239
TT		 107672019-05-08 Tom Tromey <tromey@adacore.com>
10768
10769 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10770 method.
10771
99f20f08
TT		 107722019-05-08 Tom Tromey <tromey@adacore.com>
10773
10774 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10775 when no wrap column is set.
10776
80e55b13
TT		 107772019-05-08 Tom Tromey <tromey@adacore.com>
10778
10779 * c-lang.c (c_get_string): Handle non-C-style arrays.
10780
9d3421af
TT		 107812019-05-08 Tom Tromey <tromey@adacore.com>
10782
10783 * typeprint.c (print_offset_data::update): Print the bit offset,
10784 not the number of bits remaining.
10785
844333e2
TT		 107862019-05-08 Tom Tromey <tromey@adacore.com>
10787
10788 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10789 padding at end of comment.
10790
988915ee
TT		 107912019-05-08 Tom Tromey <tromey@adacore.com>
10792
10793 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10794 Compare main types.
10795
26bfd823
TT		 107962019-05-06 Tom Tromey <tom@tromey.com>
10797
10798 * common/scoped_mmap.c: Include common-defs.h.
10799 * common/scoped_mmap.h: Don't include config.h.
10800
89055eaa
TT		 108012019-05-04 Tom Tromey <tom@tromey.com>
10802
10803 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10804 (struct aarch64_call_info): Add initializers.
10805 <si>: Now a std::vector.
10806 (pass_on_stack, aarch64_push_dummy_call): Update.
10807
5da01df5
TT		 108082019-05-04 Simon Marchi <simon.marchi@efficios.com>
10809 Tom Tromey <tom@tromey.com>
10810
10811 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10812 (ppc_threads): Now a std::vector. Now static.
10813 (hwdebug_find_thread_points_by_tid)
10814 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10815 Update.
10816
fbdf05a1
TT		 108172019-05-04 Tom Tromey <tom@tromey.com>
10818
10819 * arc-tdep.c (arc_tdesc_init): Return bool.
10820
06d16ec9
TT		 108212019-05-04 Tom Tromey <tom@tromey.com>
10822
10823 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10824 Use gdb_assert_not_reached.
10825
9c056022
TT		 108262019-05-04 Tom Tromey <tom@tromey.com>
10827
10828 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10829 "false".
10830
fa9c2a59
TT		 108312019-05-04 Tom Tromey <tom@tromey.com>
10832
10833 * arc-tdep.c (arc_tdesc_init): Use bool.
10834
e2eb806a
TT		 108352019-05-04 Tom Tromey <tom@tromey.com>
10836
10837 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10838
6fe87677
TT		 108392019-05-04 Tom Tromey <tom@tromey.com>
10840
10841 * cli/cli-cmds.c (valid_command_p): Return bool.
10842
7f008c9e
TT		 108432019-05-04 Tom Tromey <tom@tromey.com>
10844
10845 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10846 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10847
b6484282
RT		 108482019-05-04 Raul Tambre <raul@tambre.ee>
10849
10850 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10851 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10852 operator for comparison.
10853
af97b416
TT		 108542019-05-04 Tom Tromey <tom@tromey.com>
10855
10856 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10857 (lookup_partial_symbol, print_partial_symbols)
10858 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10859 (psymbol_compare): Update.
10860 (add_psymbol_to_bcache): Clear the entire psymbol.
10861 (maintenance_check_psymtabs): Update.
10862 * psympriv.h (struct partial_symbol): Don't derive from
10863 general_symbol_info.
10864 <obj_section, unrelocated_address, address,
10865 set_unrelocated_address>: Update.
10866 <ginfo>: New member.
10867 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10868 (debug_names::write_psymbols): Update.
10869
9d6d4be8
TV		 108702019-05-04 Tom de Vries <tdevries@suse.de>
10871
10872 * contrib/cc-with-tweaks.sh: Support -n arg.
10873
66452beb
PW		 108742019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10875
10876 * corelow.c (core_target::detach): Ensure frame cache and
10877 register caches are cleared.
10878 inferior.c (exit_inferior_1): Likewise.
10879
bde09ab7
TT		 108802019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10881 Tom Tromey <tom@tromey.com>
10882
10883 * dictionary.c (collate_pending_symbols_by_language): Remove
10884 "struct" from foreach.
10885 * symtab.c (lookup_global_symbol_from_objfile)
10886 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10887 foreach.
10888 * ser-tcp.c (net_open): Remove "struct" from foreach.
10889 * objfiles.c (objfile_relocate, objfile_rebase)
10890 (objfile_has_symbols): Remove "struct" from foreach.
10891 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10892 from foreach.
10893 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10894 foreach.
10895 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10896 "struct" from foreach.
10897 * ada-lang.c (create_excep_cond_exprs)
10898 (ada_exception_catchpoint_cond_string): Remove "struct" from
10899 foreach.
10900
222a8d25
TT		 109012019-05-03 Tom Tromey <tromey@adacore.com>
10902
10903 * ada-exp.y (convert_char_literal): Check suffix of each
10904 enumerator.
10905
fcd60b84
DP		 109062019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10907
10908 PR ada/21406:
10909 * ada-exp.y (yywrap): Don't define.
10910 * ada-lex.l (%option): Add noyywrap
10911 (yywrap): Remove.
10912
5f2459c2
EZ		 109132019-05-03 Eli Zaretskii <eliz@gnu.org>
10914
353ea2d1
EZ		 10915 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10916 _WIN32_WINNT to the XP level, unless already defined to a higher
10917 level.
10918
10919 * unittests/parse-connection-spec-selftests.c:
10920 * ser-tcp.c:
10921 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10922 override.
10923
5f2459c2
EZ		 10924 * symfile.c (find_separate_debug_file): Remove colon from the
10925 drive spec of DOS/Windows file names of the target, so that the
10926 file name produced from DEBUGDIR and the target's directory will
10927 be valid on DOS/Windows systems.
10928
80062eb9
AB		 109292019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10930
10931 * rust-lang.c (val_print_struct): Handle printing structures
10932 containing strings.
10933
b8c05e85
TT		 109342019-05-02 Tom Tromey <tromey@adacore.com>
10935
10936 * valarith.c (_initialize_valarith): Remove.
10937
4504bbde
TT		 109382019-05-01 Tom Tromey <tromey@adacore.com>
10939
10940 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10941 bitfields.
10942
d48e62f4
TT		 109432019-05-01 Tom Tromey <tromey@adacore.com>
10944
10945 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10946 for big-endian copies.
10947
15f18d14
AT		 109482019-04-30 Ali Tamur <tamur@google.com>
10949 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10950 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10951 (read_3_bytes): New function.
10952
ab4ee614
JB		 109532019-04-30 Joel Brobecker <brobecker@adacore.com>
10954
10955 * windows-nat.c (main_thread_id): Delete.
10956 (handle_output_debug_string): Replace main_thread_id by
10957 current_event.dwThreadId.
10958 (fake_create_process): Likewise.
10959 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10960 Do not set main_thread_id.
10961 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10962 current_event.dwThreadId.
10963 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10964
8ed5b76e
JB		 109652019-04-30 Joel Brobecker <brobecker@adacore.com>
10966
10967 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10968 Use current_event.dwThreadId instead of main_thread_id.
10969
2ff0a947
TT		 109702019-04-30 Tom Tromey <tromey@adacore.com>
10971
10972 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10973 (create_excep_cond_exprs): Iterate over program spaces.
10974 (ada_exception_catchpoint_cond_string): Examine all minimal
10975 symbols for exception types.
10976
a776957c
TT		 109772019-04-30 Tom Tromey <tromey@adacore.com>
10978
10979 PR c++/24470:
10980 * dwarf2read.c (process_structure_scope): Handle case where type
10981 has template parameters but no symbol was created.
10982
bc68014d
AB		 109832019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10984 Chris January <chris.january@arm.com>
10985
10986 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10987 qualifier.
10988 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10989
f1fdc960
AB		 109902019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10991
10992 * f-typeprint.c (f_print_type): Update rules for printing
10993 whitespace.
10994 (f_type_print_varspec_suffix): Likewise.
10995
bf7a4de1
AB		 109962019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10997 Chris January <chris.january@arm.com>
10998
10999 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11000 function arguments.
11001
bbe75b9d
AB		 110022019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11003
11004 * f-lang.c (build_fortran_types): Change name of void type to
11005 lower case.
11006 * f-typeprint.c (f_type_print_base): Print the name of the void
11007 type, rather than a fixed string.
11008 * f-valprint.c (f_decorations): Use lower case void string.
11009
1db455a7
AB		 110102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11011 Chris January <chris.january@arm.com>
11012
11013 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11014 types for Fortran.
11015
b6d03bb2
AB		 110162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11017 Chris January <chris.january@arm.com>
11018 David Lecomber <david.lecomber@arm.com>
11019
11020 * f-exp.y (BINOP_INTRINSIC): New token.
11021 (exp): New parser rule handling BINOP_INTRINSIC.
11022 (f77_keywords): Add new builtin procedures.
11023 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11024 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11025 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11026 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11027 (print_unop_subexp_f): New function.
11028 (print_binop_subexp_f): New function.
11029 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11030 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11031 (dump_subexp_body_f): Likewise.
11032 (operator_check_f): Likewise.
11033 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11034 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11035
83228e93
AB		 110362019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11037
11038 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11039 UNOP_KIND.
11040 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11041 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11042 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11043 (operator_length_f): New fuction.
11044 (print_subexp_f): New function.
11045 (op_name_f): New function.
11046 (dump_subexp_body_f): New function.
11047 (operator_check_f): New function.
11048 (exp_descriptor_f): Replace standard expression handling functions
11049 with new functions.
11050 * gdb/fortran-operator.def: New file.
11051 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11052 * gdb/std-operator.def: Remove UNOP_KIND.
11053
6fdcd7cc
AB		 110542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11055
11056 * std-operator.def: Remove unbalanced, stray double quote
11057 character.
11058
2e62ab40
AB		 110592019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11060 Chris January <chris.january@arm.com>
11061 Daniel Everett <daniel.everett@arm.com>
11062 Nick Forrington <nick.forrington@arm.com>
11063 Richard Bunt <richard.bunt@arm.com>
11064
11065 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11066 of depth when printing anonymous structs or unions.
11067 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11068 Don't print either the top-level value, or the children if the
11069 max-depth is exceeded.
11070 (ppscm_print_children): When printing the key of a map, allow one
11071 extra level of depth.
11072 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11073 print either the top-level value, or the children if the max-depth
11074 is exceeded.
11075 (print_children): When printing the key of a map, allow one extra
11076 level of depth.
11077 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11078 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11079 (user_print_options): Initialise max_depth field.
11080 (val_print_scalar_or_string_type_p): New function.
11081 (val_print): Check to see if the max depth has been reached.
11082 (val_print_check_max_depth): Define new function.
11083 (show_print_max_depth): New function.
11084 (_initialize_valprint): Add 'print max-depth' option.
11085 * valprint.h (struct value_print_options) <max_depth>: New field.
11086 (val_print_check_max_depth): Declare new function.
11087 * NEWS: Document new feature.
11088
4be290b2
AB		 110892019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11090
11091 * ada-lang.c (ada_language_defn): Initialise new field.
11092 * c-lang.c (c_is_string_type_p): New function.
11093 (c_language_defn): Initialise new field.
11094 (cplus_language_defn): Initialise new field.
11095 (asm_language_defn): Initialise new field.
11096 (minimal_language_defn): Initialise new field.
11097 * c-lang.h (c_is_string_type_p): Declare new function.
11098 * d-lang.c (d_language_defn): Initialise new field.
11099 * f-lang.c (f_is_string_type_p): New function.
11100 (f_language_defn): Initialise new field.
11101 * go-lang.c (go_is_string_type_p): New function.
11102 (go_language_defn): Initialise new field.
11103 * language.c (default_is_string_type_p): New function.
11104 (unknown_language_defn): Initialise new field.
11105 (auto_language_defn): Initialise new field.
11106 * language.h (struct language_defn) <la_is_string_type_p>: New
11107 member variable.
11108 (default_is_string_type_p): Declare new function.
11109 * m2-lang.c (m2_language_defn): Initialise new field.
11110 * objc-lang.c (objc_language_defn): Initialise new field.
11111 * opencl-lang.c (opencl_language_defn): Initialise new field.
11112 * p-lang.c (pascal_is_string_type_p): New function.
11113 (pascal_language_defn): Initialise new field.
11114 * rust-lang.c (rust_is_string_type_p): New function.
11115 (rust_language_defn): Initialise new field.
11116
721b08c6
AB		 111172019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11118
11119 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11120 New field.
11121 * ada-lang.c (ada_language_defn): Initialise new field.
11122 * c-lang.c (c_language_defn): Likewise.
11123 (cplus_language_defn): Likewise.
11124 (asm_language_defn): Likewise.
11125 (minimal_language_defn): Likewise.
11126 * d-lang.c (d_language_defn): Likewise.
11127 * f-lang.c (f_language_defn): Likewise.
11128 * go-lang.c (go_language_defn): Likewise.
11129 * language.c (unknown_language_defn): Likewise.
11130 (auto_language_defn): Likewise.
11131 * m2-lang.c (m2_language_defn): Likewise.
11132 * objc-lang.c (objc_language_defn): Likewise.
11133 * opencl-lang.c (opencl_language_defn): Likewise.
11134 * p-lang.c (pascal_language_defn): Likewise.
11135 * rust-lang.c (rust_language_defn): Likewise.
11136
fc913e53
AB		 111372019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11138
11139 * ada-lang.c (ada_is_character_type): Change return type to bool.
11140 (ada_is_string_type): Likewise.
11141 * ada-lang.h (ada_is_character_type): Update declaration
11142 (ada_is_string_type): Likewise.
11143
fa731fa0
PW		 111442019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11145
11146 Support style in 'frame|thread apply'
11147
11148 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11149 * record.c (record_start, record_stop): Update callers of
11150 execute_command_to_string with false.
11151 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11152 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11153 methods.
11154 (class string_file): New constructor with term_out parameter.
11155 Override methods term_out and can_emit_style_escape. New member
11156 term_out.
11157 (class stdio_file): Override can_emit_style_escape.
11158 (class tee_file): Override term_out and can_emit_style_escape.
11159 * utils.h (can_emit_style_escape): Remove.
11160 * utils.c (can_emit_style_escape): Likewise.
11161 Update all callers of can_emit_style_escape (SOMESTREAM) to
11162 SOMESTREAM->can_emit_style_escape.
11163 * source-cache.c (source_cache::get_source_lines): Likewise.
11164 * stack.c (frame_apply_command_count): Call execute_command_to_string
11165 passing the term_out characteristic of the current gdb_stdout.
11166 * thread.c (thr_try_catch_cmd): Likewise.
11167 * top.c (execute_command_to_string): pass term_out parameter
11168 to construct the string_file for the command output.
11169 * ui-file.c (term_cli_styling): New function (most code moved
11170 from utils.c can_emit_style_escape).
11171 (string_file::string_file, string_file::can_emit_style_escape,
11172 stdio_file::can_emit_style_escape, tee_file::term_out,
11173 tee_file::can_emit_style_escape): New functions.
11174
136afab8
PW		 111752019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11176
11177 * NEWS: Mention the new set|show may-call-functions.
11178 * infcall.c (may_call_functions_p): New variable.
11179 (show_may_call_functions_p): New function.
11180 (call_function_by_hand_dummy): Throws an error if not
11181 may-call-functions.
11182 (_initialize_infcall): Call add_setshow_boolean_cmd for
11183 may-call-functions.
11184
725cbb63
KS		 111852019-04-25 Keith Seitz <keiths@redhat.com>
11186
11187 PR c++/24367
11188 * cp-support.c (inspect_type): Don't attempt substitutions
11189 of symbol with the same name.
11190
3d1cbb78
TT		 111912019-04-25 Tom Tromey <tromey@adacore.com>
11192
11193 PR gdb/24475:
11194 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11195 static.
11196
94aeb44b
TT		 111972019-04-25 Tom Tromey <tromey@adacore.com>
11198
11199 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11200 rvalue reference.
11201 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11202 (gdb_xml_parser::parse): Use std::move.
11203 * python/python-internal.h (gdbpy_convert_exception): Take a const
11204 reference.
11205 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11206 std::move.
11207 * python/py-utils.c (gdbpy_convert_exception): Take a const
11208 reference.
11209 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11210 Use std::move.
11211 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11212 Use std::move.
11213 * mi/mi-main.c (mi_print_exception): Take a const reference.
11214 * main.c (handle_command_errors): Take a const reference.
11215 * linespec.c (parse_linespec): Use std::move.
11216 * infcall.c (run_inferior_call): Use std::move.
11217 (call_function_by_hand_dummy): Use std::move.
11218 * exec.c (try_open_exec_file): Use std::move.
11219 * exceptions.h (exception_print, exception_fprintf)
11220 (exception_print_same): Update.
11221 * exceptions.c (print_exception, exception_print)
11222 (exception_fprintf, exception_print_same): Change parameters to
11223 const reference.
11224 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11225 * common/new-op.c: Use std::move.
11226 * common/common-exceptions.h (struct gdb_exception): Add move
11227 constructor.
11228 (struct gdb_exception_error, struct gdb_exception_quit, struct
11229 gdb_quit_bad_alloc): Change constructor to move constructor.
11230 (throw_exception): Change parameter to rvalue reference.
11231 * common/common-exceptions.c (throw_exception): Take rvalue
11232 reference.
11233 * cli/cli-interp.c (safe_execute_command): Use std::move.
11234 * breakpoint.c (insert_bp_location, location_to_sals): Use
11235 std::move.
11236
680d7fd5
TT		 112372019-04-25 Tom Tromey <tromey@adacore.com>
11238
11239 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11240 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11241 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11242 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11243 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11244 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11245 guile/scm-value.c: Use unpack.
11246 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11247 gdbscm_gdb_exception.
11248 (gdbscm_throw_gdb_exception): Likewise.
11249 (struct gdbscm_gdb_exception): New.
11250 (unpack): New function.
11251 (gdbscm_wrap): Use unpack.
11252
c6fdd8b2
TT		 112532019-04-25 Tom Tromey <tromey@adacore.com>
11254
11255 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11256 (gdb_rl_callback_handler): Use std::move.
11257 * common/common-exceptions.h (struct gdb_exception): Add move
11258 assignment operator.
11259 (throw_exception_sjlj): Change "exception" to const reference.
11260 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11261 (throw_exception_sjlj): Change "exception" to const reference.
11262
cc06b668
TT		 112632019-04-25 Tom Tromey <tromey@adacore.com>
11264
11265 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11266 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11267 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11268 Update.
11269 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11270 Update.
11271 * mi/mi-interp.c (mi_interp::exec): Update.
11272 * linespec.c (parse_linespec): Update.
11273 * infcall.c (run_inferior_call): Update.
11274 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11275 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11276 (gdbscm_lookup_global_symbol): Update.
11277 * guile/scm-param.c (gdbscm_parameter_value): Update.
11278 * guile/scm-frame.c (gdbscm_frame_read_register)
11279 (gdbscm_frame_read_var): Update.
11280 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11281 * exec.c (try_open_exec_file): Update.
11282 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11283 (gdb_rl_callback_handler): Update.
11284 * common/common-exceptions.h (exception_none): Don't declare.
11285 * common/common-exceptions.c (exception_none): Don't define.
11286 (struct catcher) <exception>: Update.
11287 * cli/cli-interp.c (safe_execute_command): Update.
11288 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11289
cf532bd1
AT		 112902019-04-25 Ali Tamur <tamur@google.com>
11291
11292 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11293 (read_attribute_value): Likewise.
11294 (dwarf2_read_addr_index): Update comment.
11295 (read_str_index): Add DW_FORM_strx.
11296 (dwarf2_string_attr): Likewise.
11297 (dwarf2_const_value_attr): Likewise.
11298 (dump_die_shallow): Likewise.
11299 (dwarf2_fetch_constant_bytes): Likewise.
11300 (skip_form_bytes): Likewise.
11301 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11302
82433e3e
SDJ		 113032019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11304
11305 PR corefiles/11608
11306 PR corefiles/18187
11307 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11308 OFFSET. Verify if current mapping contains an ELF header.
11309 (linux_find_memory_regions_full): Adjust call to
11310 dump_mapping_p.
11311
723adb65
SL		 113122019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11313 Kang Li <kanglictf@gmail.com>
11314
11315 PR gdb/21600
11316
11317 * dwarf2-frame.c (read_initial_length): Be consistent about using
11318 unsigned representation of length.
11319 (decode_frame_entry_1): Likewise. Check for wraparound of
11320 end pointer as well as buffer overflow.
11321
596179f7
SDJ		 113222019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11323
11324 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11325 "vq".
11326
a59240a4
TT		 113272019-04-24 Tom Tromey <tromey@adacore.com>
11328
11329 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11330
f872fdbb
AB		 113312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11332
11333 * s12z-tdep.c (s12z_unwind_pc): Delete.
11334 (s12z_unwind_sp): Delete.
11335 (s12z_gdbarch_init): Don't register deleted functions with
11336 gdbarch.
11337
b614e6f3
AB		 113382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11339
11340 * rl78-tdep.c (rl78_unwind_sp): Delete.
11341 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11342
14faed38
AB		 113432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11344
11345 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11346 (xstormy16_unwind_pc): Delete.
11347 (xstormy16_dummy_id): Delete.
11348 (xstormy16_gdbarch_init): Don't register deleted functions with
11349 gdbarch.
11350
541aad8a
AB		 113512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11352
11353 * vax-tdep.c (vax_unwind_pc): Delete.
11354 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11355
29222070
AB		 113562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11357
11358 * v850-tdep.c (v850_unwind_sp): Delete.
11359 (v850_unwind_pc): Delete.
11360 (v850_dummy_id): Delete.
11361 (v850_gdbarch_init): Don't register deleted functions with
11362 gdbarch.
11363
0f534d76
AB		 113642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11365
11366 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11367 (tilegx_unwind_pc): Delete.
11368 (tilegx_unwind_dummy_id): Delete.
11369 (tilegx_gdbarch_init): Don't register deleted functions with
11370 gdbarch.
11371
1ba7b7f9
AB		 113722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11373
11374 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11375 (tic6x_dummy_id): Delete.
11376 (tic6x_gdbarch_init): Don't register deleted functions with
11377 gdbarch.
11378
d31f262c
AB		 113792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11380
11381 * sparc-tdep.c (sparc_unwind_pc): Delete.
11382 (sparc32_gdbarch_init): Don't register deleted function with
11383 gdbarch.
11384
6d14d64d
AB		 113852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11386
11387 * sh-tdep.c (sh_unwind_sp): Delete.
11388 (sh_unwind_pc): Delete.
11389 (sh_dummy_id): Delete.
11390 (sh_gdbarch_init): Don't register deleted functions with
11391 gdbarch.
11392
a40dde9d
AB		 113932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11394
11395 * score-tdep.c (score_unwind_sp): Delete.
11396 (score_unwind_pc): Delete.
11397 (score_dummy_id): Delete.
11398 (score_gdbarch_init): Don't register deleted functions with
11399 gdbarch.
11400
47c47d69
AB		 114012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11402
11403 * rx-tdep.c (rx_unwind_pc): Delete.
11404 (rx_unwind_sp): Delete.
11405 (rx_dummy_id): Delete.
11406 (rx_gdbarch_init): Don't register deleted functions with
11407 gdbarch. Update comment.
11408
833a4480
AB		 114092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11410
11411 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11412 (rs6000_dummy_id): Delete.
11413 (rs6000_gdbarch_init): Don't register deleted functions with
11414 gdbarch.
11415
3f2cef49
AB		 114162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11417
11418 * or1k-tdep.c (or1k_dummy_id): Delete.
11419 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11420
96acf884
AB		 114212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11422
11423 * nios2-tdep.c (nios2_dummy_id): Delete.
11424 (nios2_unwind_sp): Delete.
11425 (nios2_gdbarch_init): Don't register deleted functions with
11426 gdbarch.
11427
ca0ab0aa
AB		 114282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11429
11430 * nds32-tdep.c (nds32_dummy_id): Delete.
11431 (nds32_unwind_pc): Delete.
11432 (nds32_unwind_sp): Delete.
11433 (nds32_gdbarch_init): Don't register deleted functions with
11434 gdbarch.
11435
c8259044
AB		 114362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11437
11438 * msp430-tdep.c (msp430_unwind_pc): Delete.
11439 (msp430_unwind_sp): Delete.
11440 (msp430_dummy_id): Delete.
11441 (msp430_gdbarch_init): Don't register deleted functions with
11442 gdbarch.
11443
27f113c8
AB		 114442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11445
11446 * moxie-tdep.c (moxie_unwind_sp): Delete.
11447 (moxie_unwind_pc): Delete.
11448 (moxie_dummy_id): Delete.
11449 (moxie_gdbarch_init): Don't register deleted functions with
11450 gdbarch.
11451
aee6c3cd
AB		 114522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11453
11454 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11455 (mn10300_unwind_pc): Delete.
11456 (mn10300_unwind_sp): Delete.
11457 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11458 mn10300_unwind_sp.
11459 (mn10300_frame_unwind_init): Don't register deleted functions with
11460 gdbarch.
11461
8e2b5aea
AB		 114622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11463
11464 * mep-tdep.c (mep_unwind_pc): Delete.
11465 (mep_unwind_sp): Delete.
11466 (mep_dummy_id): Delete.
11467 (mep_gdbarch_init): Don't register deleted functions with
11468 gdbarch.
11469
43cf3ede
AB		 114702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11471
11472 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11473 (m68hc11_unwind_sp): Delete.
11474 (m68hc11_gdbarch_init): Don't register deleted functions with
11475 gdbarch.
11476
5e79b7bb
AB		 114772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11478
11479 * m32r-tdep.c (m32r_unwind_sp): Delete.
11480 (m32r_unwind_pc): Delete.
11481 (m32r_dummy_id): Delete.
11482 (m32r_gdbarch_init): Don't register deleted functions with
11483 gdbarch.
11484
89b268d8
AB		 114852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11486
11487 * m32c-tdep.c (m32c_unwind_pc): Delete.
11488 (m32c_unwind_sp): Delete.
11489 (m32c_dummy_id): Delete.
11490 (m32c_gdbarch_init): Don't register deleted functions with
11491 gdbarch.
11492
946c28d2
AB		 114932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11494
11495 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11496 (lm32_unwind_pc): Delete.
11497 (lm32_dummy_id): Delete.
11498 (lm32_gdbarch_init): Don't register deleted functions with
11499 gdbarch.
11500
bf12844a
AB		 115012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11502
11503 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11504 (iq2000_unwind_pc): Delete.
11505 (iq2000_dummy_id): Delete.
11506 (iq2000_gdbarch_init): Don't register deleted functions with
11507 gdbarch.
11508
ecbc06d2
AB		 115092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11510
11511 * nds32-tdep.c (nds32_type_align): Delete.
11512 (nds32_push_dummy_call): Use type_align instead.
11513
030197b4
AB		 115142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11515
11516 * arm-tdep.c (arm_type_align): Only handle vector override case.
11517 (arm_push_dummy_call): Use type_align.
11518 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11519
b907456c
AB		 115202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11521
11522 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11523 case.
11524 (pass_on_stack): Use type_align.
11525 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11526 function.
11527
9e97ba43
TT		 115282019-04-23 Tom Tromey <tromey@adacore.com>
11529
11530 * dwarf2read.c (line_header::file_name_at): Remove unused
11531 overload.
11532
6892f601
TV		 115332019-04-23 Tom de Vries <tdevries@suse.de>
11534
11535 PR gdb/24438
11536 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11537 invocation.
11538
336d760d
AT		 11539
115402019-03-27 Ali Tamur <tamur@google.com>
11541
11542 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11543 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11544 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11545 (dwarf_expr_context::get_addr_index): Likewise
11546 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11547 (symbol_needs_eval_context::get_addr_index): Likewise
11548 (disassemble_dwarf_expression): Add DW_OP_addrx
11549 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11550 (read_cutu_die_from_dwo): Update comment
11551 (skip_one_die): Add DW_FORM_addrx
11552 (read_attribute_value): Likewise
11553 (var_decode_location): Add DW_OP_addrx
11554 (dwarf2_const_value_attr): Add DW_FORM_addrx
11555 (dump_die_shallow): Likewise
11556 (dwarf2_fetch_constant_bytes): Likewise
11557 (decode_locdesc): Add DW_OP_addrx
11558 (skip_form_bytes): Add DW_FORM_addrx
11559
ad9d13f8
AT		 115602019-04-22 Ali Tamur <tamur@google.com>
11561
11562 * MAINTAINERS (Write After Approval): Add self.
11563
d70cc3ba
SM		 115642019-04-22 Simon Marchi <simon.marchi@efficios.com>
11565
11566 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11567 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11568 (open_symbol_file_object): Likewise.
11569 (svr4_default_sos): Add info parameter.
11570 (svr4_read_so_list): Likewise.
11571 (svr4_current_sos_direct): Adjust functions calls to pass down
11572 info.
11573 (svr4_current_sos_1): Add info parameter.
11574 (svr4_current_sos): Call get_svr4_info, pass info down to
11575 svr4_current_sos_1.
11576 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11577 get_svr4_info.
11578 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11579 get_svr4_info.
11580 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11581 to get_svr4_info.
11582 (probes_table_remove_objfile_probes): Likewise.
11583 (register_solib_event_probe): Add info parameter.
11584 (solist_update_incremental): Pass info parameter down to
11585 svr4_read_so_list.
11586 (disable_probes_interface): Add info parameter.
11587 (svr4_handle_solib_event): Pass current_program_space to
11588 get_svr4_info. Adjust disable_probes_interface cleanup.
11589 (svr4_create_probe_breakpoints): Add info parameter, pass it
11590 down to register_solib_event_probe.
11591 (svr4_create_solib_event_breakpoints): Add info parameter,
11592 pass it down to svr4_create_probe_breakpoints.
11593 (enable_break): Pass info down to
11594 svr4_create_solib_event_breakpoints.
11595 (svr4_solib_create_inferior_hook): Pass current_program_space to
11596 get_svr4_info.
11597 (svr4_clear_solib): Likewise.
11598
7905fc35
PA		 115992019-04-22 Pedro Alves <palves@redhat.com>
11600
11601 * solib-svr4.c (svr4_free_objfile_observer): New.
11602 (probe_and_action::objfile): New field.
11603 (probes_table_htab_remove_objfile_probes)
11604 (probes_table_remove_objfile_probes): New functions.
11605 (register_solib_event_probe): Add 'objfile' parameter. Store it
11606 in the new probe_and_action. Don't store the probe in 'lookup'.
11607 (svr4_create_probe_breakpoints): Pass objfile to
11608 register_solib_event_probe.
11609 (_initialize_svr4_solib): Register a free_objfile observer.
11610
fb881986
TT		 116112019-04-19 Tom Tromey <tom@tromey.com>
11612
11613 * common/queue.h: Remove.
11614
8732db6c
TT		 116152019-04-19 Tom Tromey <tom@tromey.com>
11616
11617 * event-loop.c: Don't include "common/queue.h".
11618
97dfbadd
TT		 116192019-04-19 Tom Tromey <tom@tromey.com>
11620
11621 * remote.c (remote_target): Use delete.
11622 * remote-notif.h: Include <list>, not "common/queue.h".
11623 (notif_client_p): Remove typedef.
11624 (remote_notif_state): Add constructor, destructor, initializer.
11625 <notif_queue>: Now a std::list.
11626 (remote_notif_state_xfree): Don't declare.
11627 * remote-notif.c (remote_notif_process, handle_notification)
11628 (remote_notif_state_allocate): Update.
11629 (~remote_notif_state): Rename from remote_notif_state_xfree.
11630
cf250e36
TT		 116312019-04-19 Tom Tromey <tom@tromey.com>
11632
11633 * symfile.c (reread_symbols): Update.
11634 * objfiles.c (objfile_register_static_link)
11635 (objfile_lookup_static_link): Update
11636 (~objfile) Don't delete static_links.
11637 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11638
61f4b350
TT		 116392019-04-19 Tom Tromey <tom@tromey.com>
11640
11641 * type-stack.h (struct type_stack) <insert>: Constify string.
11642 * type-stack.c (type_stack::insert): Constify string.
11643 * gdbtypes.h (lookup_template_type): Update.
11644 (address_space_name_to_int): Update.
11645 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11646 const.
11647 (lookup_template_type): Make name const.
11648 * c-exp.y: Update rules.
11649 (lex_one_token, classify_name, classify_inner_name)
11650 (c_print_token): Update.
11651 * p-exp.y: Update rules.
11652 (yylex): Update.
11653 * f-exp.y: Update rules.
11654 (yylex): Update.
11655 * d-exp.y: Update rules.
11656 (lex_one_token, classify_name, classify_inner_name): Update.
11657 * parse.c (write_dollar_variable, copy_name): Return std::string.
11658 * parser-defs.h (copy_name): Change return type.
11659 * m2-exp.y: Update rules.
11660 (yylex): Update.
11661 * go-exp.y (lex_one_token): Update.
11662 Update rules.
11663 (classify_unsafe_function, classify_packaged_name)
11664 (classify_name, yylex): Update.
11665
189b8c2e
ST		 116662019-04-19 Sergei Trofimovich <siarheit@google.com>
11667
11668 * configure.ac: add --enable-source-highlight switch.
11669 * configure: Regenerate.
11670 * top.c (print_gdb_version): plumb --enable-source-highlight
11671 status to "show configuration".
11672
8ecb59f8
TT		 116732019-04-19 Tom Tromey <tromey@adacore.com>
11674
11675 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11676 Check ADA_TYPE_P.
11677 (empty_record, ada_template_to_fixed_record_type_1)
11678 (template_to_static_fixed_type)
11679 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11680 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11681 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11682 macros.
11683
62160ec9
TT		 116842019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11685
11686 PR symtab/24423:
11687 * source.c (print_source_lines_base): Advance "iter" when a
11688 control character is seen.
11689
f2ae8bc8
PW		 116902019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11691
11692 * inferior.h (struct infcall_suspend_state_deleter):
11693 Catch exception in destructor to avoid crash.
11694
d563b953
PW		 116952019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11696
11697 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11698 close to the add_com "shell".
11699
dc34c897
TT		 117002019-04-18 Tom Tromey <tromey@adacore.com>
11701
11702 * process-stratum-target.h (class process_stratum_target)
11703 <stratum>: Add "final".
11704
a12e5744
TT		 117052019-04-17 Tom Tromey <tromey@adacore.com>
11706
11707 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11708 against nullptr before use.
11709
a7e559cc
AH		 117102019-04-17 Alan Hayward <alan.hayward@arm.com>
11711
11712 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11713
c01660c6
AB		 117142019-04-17 Jim Wilson <jimw@sifive.com>
11715 Andrew Burgess <andrew.burgess@embecosm.com>
11716
11717 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11718 code read might fail, assume 4-byte breakpoint in that case.
11719
4aa866af
LS		 117202019-04-15 Leszek Swirski <leszeks@google.com>
11721
11722 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11723 rather than a hand-rolled POD check when checking for forced MEMORY
11724 classification.
11725
48574d91
AH		 117262019-04-15 Alan Hayward <alan.hayward@arm.com>
11727
11728 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11729 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11730 function.
11731 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11732 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11733 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11734 declaration.
11735
4da037ef
AH		 117362019-04-15 Alan Hayward <alan.hayward@arm.com>
11737
11738 * aarch64-linux-nat.c
11739 (aarch64_linux_nat_target::thread_architecture): Add override.
11740 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11741 each VQ.
11742
ccb8d7e8
AH		 117432019-04-15 Alan Hayward <alan.hayward@arm.com>
11744
11745 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11746
35add35e
AB		 117472019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11748
11749 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11750 target types of size 96-bits, add some additional comments, and
11751 check that the builtin type we found was the correct size.
11752
51196bbc
EZ		 117532019-04-12 Eli Zaretskii <eliz@gnu.org>
11754
11755 * utils.c (prompt_for_continue): Don't restore the styling at the
11756 end, as applied_style has the wrong value. This fixes styling in
11757 long lists of file names that are interrupted by the "Continue?"
11758 prompt.
11759
62253a61
AB		 117602019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11761
11762 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11763 * c-lang.c (c_language_defn): Likewise.
11764 (cplus_language_defn): Likewise.
11765 (asm_language_defn): Likewise.
11766 (minimal_language_defn): Likewise.
11767 * d-lang.c (d_language_defn): Likewise.
11768 * f-lang.c (f_language_defn): Likewise.
11769 * go-lang.c (go_language_defn): Likewise.
11770 * language.c (unknown_language_defn): Likewise.
11771 (auto_language_defn): Likewise.
11772 * language.h (struct language_defn): Remove la_magic field.
11773 (LANG_MAGIC): Delete.
11774 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11775 * objc-lang.c (objc_language_defn): Likewise.
11776 * opencl-lang.c (opencl_language_defn): Likewise.
11777 * p-lang.c (pascal_language_defn): Likewise.
11778 * rust-lang.c (rust_language_defn): Likewise.
11779
a9158a86
AB		 117802019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11781
11782 * riscv-tdep.c (riscv_type_align): New function.
11783 (riscv_type_alignment): Delete.
11784 (riscv_arg_location): Use 'type_align'.
11785 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11786
41077b66
AB		 117872019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11788
11789 * gdbtypes.c (type_align): A struct with no non-static fields also
11790 has alignment of 1.
11791
9f0272f8
AB		 117922019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11793
11794 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11795 component to 0.
11796 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11797 member.
11798 (riscv_struct_info::analyse): New implementation using new
11799 analyse_inner member function.
11800 (riscv_struct_info::field_offset): New member function.
11801 (riscv_struct_info::m_offsets): New member variable.
11802 (riscv_struct_info::analyse_inner): New private member function,
11803 takes the old implementation of riscv_struct_info::analyse but
11804 extended to track field offsets.
11805 (riscv_call_arg_struct): Update the struct folding special cases
11806 to handle cases where empty C++ structs, which are non-zero
11807 length, are found.
11808 (riscv_arg_location): Initialise the length of each location, a
11809 non-zero length now indicates the location is in use.
11810 (riscv_push_dummy_call): Allow for the first location having a
11811 non-zero offset when setting up arguments.
11812 (riscv_return_value): Likewise, but for return values.
11813
02cf60c7
TT		 118142019-04-11 Tom Tromey <tromey@adacore.com>
11815
11816 * utils.c (internal_vproblem): Make "msg" const.
11817
68811f8f
AH		 118182019-04-11 Alan Hayward <alan.hayward@arm.com>
11819
11820 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11821 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11822 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11823 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11824
3f52fdbc
KB		 118252019-04-10 Kevin Buettner <kevinb@redhat.com>
11826
11827 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11828 function.
11829 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11830 of amd64_collect_native_gregset.
11831 (amd64_linux_nat_target::store_registers): Likewise.
11832
e9ad22ee
TT		 118332019-04-10 Tom Tromey <tom@tromey.com>
11834
11835 * symtab.c (lookup_global_symbol_from_objfile)
11836 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11837 * objfiles.h (class separate_debug_iterator): New.
11838 (class separate_debug_range): New.
11839 (struct objfile) <separate_debug_objfiles>: New method.
11840 (objfile_separate_debug_iterate): Don't declare.
11841 * objfiles.c (separate_debug_iterator::operator++): Rename from
11842 objfile_separate_debug_iterate.
11843 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11844 iterator.
11845 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11846 iterator.
11847
ee371134
TT		 118482019-04-10 Tom Tromey <tom@tromey.com>
11849
11850 * symfile.c (reread_symbols): Remove old comment.
11851 * objfiles.c (free_all_objfiles): Fix a typo.
11852
bf227d61
TT		 118532019-04-10 Tom Tromey <tom@tromey.com>
11854
11855 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11856 * minsyms.c (lookup_minimal_symbol): Use foreach.
11857 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11858 (lookup_minimal_symbol_solib_trampoline): Likewise.
11859 * symfile.c (reread_symbols): Use foreach.
11860
8dc433a0
TT		 118612019-04-09 Ivan Begert <ivanbegert@gmail.com>
11862 Tom Tromey <tromey@adacore.com>
11863
11864 PR rust/24414:
11865 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11866 (rust_lex_int_test): Change "value" to be LONGEST.
11867 (rust_lex_tests): Add test for long integer literal.
11868
9ab8741a
TT		 118692019-04-09 Tom Tromey <tromey@adacore.com>
11870
11871 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11872 to bool.
11873 (extended_remote_target::attach): Update.
11874 (remote_target::remote_notice_new_inferior): Update.
11875 (remote_target::add_current_inferior_and_thread): Update.
11876 * inferior.c (exit_inferior_1): Use "false".
11877 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11878
e242fd12
SM		 118792019-04-09 Simon Marchi <simon.marchi@efficios.com>
11880
9ca1957f 11881 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11882 the "start" command.
11883
2b0c8b01
KB		 118842019-04-08 Kevin Buettner <kevinb@redhat.com>
11885
11886 * python/py-inferior.c (infpy_thread_from_thread_handle):
11887 Adjust comments to reflect renaming of thread_from_thread_handle
11888 to thread_from_handle. Adjust keywords. Fix type error message.
11889 (inferior_object_methods): Add thread_from_handle. Retain
11890 thread_from_thread_handle, but mark it as deprecated.
11891
50a82723
KB		 118922019-04-08 Kevin Buettner <kevinb@redhat.com>
11893
11894 * gdbthread.h (find_thread_by_handle): Revise declaration.
11895 * thread.c (find_thread_by_handle): Likewise. Adjust
11896 implementation too.
11897 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11898 support for buffer objects as handles.
11899
cf63b016
KB		 119002019-04-08 Kevin Buettner <kevinb@redhat.com>
11901
11902 * python/py-infthread.c (thpy_thread_handle): New function.
11903 (thread_object_methods): Register thpy_thread_handle.
11904
3d6c6204
KB		 119052019-04-08 Kevin Buettner <kevinb@redhat.com>
11906
11907 * gdbthread.h (thread_to_thread_handle): Declare.
11908 * thread.c (gdbtypes.h): Include.
11909 (thread_to_thread_handle): New function.
11910
11911 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11912 (target_thread_info_to_thread_handle): Declare.
11913 * target.c (target_thread_info_to_thread_handle): New function.
11914 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11915 * target-delegates.c: Regenerate.
11916
11917 * linux-thread-db.c (class thread_db_target): Add method
11918 thread_info_to_thread_handle.
11919 (thread_db_target::thread_info_to_thread_handle): Define.
11920 * remote.c (class remote_target): Add new method
11921 thread_info_to_thread_handle.
11922 (remote_target::thread_info_to_thread_handle): Define.
11923
56be6ea8
PA		 119242019-04-08 Pedro Alves <palves@redhat.com>
11925
11926 * common/common-exceptions.c (throw_exception): Don't create
11927 named object to throw; throw directly.
11928 (throw_it): Likewise. Don't initialize gdb_exception::message
11929 here, with new; pass FMT and AP to the ctor instead.
11930 * common/common-exceptions.h: Include <string>.
11931 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11932 const char *, va_list)): New ctor. Use std::make_shared.
11933 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11934 errors)): Delete.
11935 (gdb_exception_error::gdb_exception_error(enum errors, const char
11936 *, va_list)): New.
11937 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11938 Add assertion.
11939 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11940 errors)): Delete.
11941 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11942 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11943 Add assertion.
11944
eedc3f4f
TT		 119452019-04-08 Tom Tromey <tom@tromey.com>
11946
11947 * valops.c (value_rtti_indirect_type): Replace throw_exception
11948 with throw.
11949 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11950 with throw.
11951 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11952 throw.
11953 * target.c (target_translate_tls_address): Replace throw_exception
11954 with throw.
11955 * stack.c (frame_apply_command_count): Replace throw_exception
11956 with throw.
11957 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11958 throw.
11959 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11960 with throw.
11961 * rs6000-tdep.c (rs6000_frame_cache)
11962 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11963 * remote.c: Replace throw_exception with throw.
11964 * record-full.c (record_full_message, record_full_wait_1)
11965 (record_full_restore): Replace throw_exception with throw.
11966 * record-btrace.c:
11967 (get_thread_current_frame_id, record_btrace_start_replaying)
11968 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11969 (cmd_record_btrace_start): Replace throw_exception with throw.
11970 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11971 throw.
11972 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11973 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11974 * linespec.c:
11975 (find_linespec_symbols): Replace throw_exception with throw.
11976 * infrun.c (displaced_step_prepare, resume): Replace
11977 throw_exception with throw.
11978 * infcmd.c (post_create_inferior): Replace throw_exception with
11979 throw.
11980 * inf-loop.c (inferior_event_handler): Replace throw_exception
11981 with throw.
11982 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11983 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11984 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11985 (get_prev_frame_always, get_frame_pc_if_available)
11986 (get_frame_address_in_block_if_available, get_frame_language):
11987 Replace throw_exception with throw.
11988 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11989 throw_exception with throw.
11990 * eval.c (fetch_subexp_value, evaluate_var_value)
11991 (evaluate_funcall, evaluate_subexp_standard): Replace
11992 throw_exception with throw.
11993 * dwarf2loc.c (call_site_find_chain)
11994 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11995 Replace throw_exception with throw.
11996 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11997 with throw.
11998 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11999 throw.
12000 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12001 * completer.c (complete_line_internal): Replace throw_exception
12002 with throw.
12003 * compile/compile-object-run.c (compile_object_run): Replace
12004 throw_exception with throw.
12005 * cli/cli-script.c (process_next_line): Replace throw_exception
12006 with throw.
12007 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12008 (btrace_enable, btrace_maint_update_pt_packets): Replace
12009 throw_exception with throw.
12010 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12011 throw_exception with throw.
12012 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12013 throw_exception with throw.
12014 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12015 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12016 * aarch64-tdep.c (aarch64_make_prologue_cache)
12017 (aarch64_make_stub_cache): Replace throw_exception with throw.
12018
26003a20
TT		 120192019-04-08 Tom Tromey <tom@tromey.com>
12020
12021 * common/common-exceptions.c (throw_exception): Rename from
12022 throw_exception_cxx. Remove old copy. Make argument const.
12023 (throw_it): Create and throw exception objects directly.
12024 * common/common-exceptions.h (throw_exception): Make argument
12025 const.
12026 (struct gdb_exception_error): Add constructor.
12027 (struct gdb_exception_quit): Add constructor.
12028
d272eb37
TT		 120292019-04-08 Tom Tromey <tom@tromey.com>
12030
12031 * common/common-exceptions.h (exception_rethrow): Don't declare.
12032 (TRY_SJLJ): Update comment.
12033 (TRY, CATCH, END_CATCH): Remove.
12034 * common/common-exceptions.c (exception_rethrow): Remove.
12035
230d2906
TT		 120362019-04-08 Tom Tromey <tom@tromey.com>
12037
12038 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12039 Remove.
12040 (gdb_exception_error): Rename from
12041 gdb_exception_RETURN_MASK_ERROR.
12042 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12043 (gdb_quit_bad_alloc): Update.
12044 * aarch64-tdep.c: Update.
12045 * ada-lang.c: Update.
12046 * ada-typeprint.c: Update.
12047 * ada-valprint.c: Update.
12048 * amd64-tdep.c: Update.
12049 * arch-utils.c: Update.
12050 * break-catch-throw.c: Update.
12051 * breakpoint.c: Update.
12052 * btrace.c: Update.
12053 * c-varobj.c: Update.
12054 * cli/cli-cmds.c: Update.
12055 * cli/cli-interp.c: Update.
12056 * cli/cli-script.c: Update.
12057 * common/common-exceptions.c: Update.
12058 * common/new-op.c: Update.
12059 * common/selftest.c: Update.
12060 * compile/compile-c-symbols.c: Update.
12061 * compile/compile-cplus-symbols.c: Update.
12062 * compile/compile-object-load.c: Update.
12063 * compile/compile-object-run.c: Update.
12064 * completer.c: Update.
12065 * corelow.c: Update.
12066 * cp-abi.c: Update.
12067 * cp-support.c: Update.
12068 * cp-valprint.c: Update.
12069 * darwin-nat.c: Update.
12070 * disasm-selftests.c: Update.
12071 * dtrace-probe.c: Update.
12072 * dwarf-index-cache.c: Update.
12073 * dwarf-index-write.c: Update.
12074 * dwarf2-frame-tailcall.c: Update.
12075 * dwarf2-frame.c: Update.
12076 * dwarf2loc.c: Update.
12077 * dwarf2read.c: Update.
12078 * eval.c: Update.
12079 * event-loop.c: Update.
12080 * event-top.c: Update.
12081 * exec.c: Update.
12082 * f-valprint.c: Update.
12083 * fbsd-tdep.c: Update.
12084 * frame-unwind.c: Update.
12085 * frame.c: Update.
12086 * gdbtypes.c: Update.
12087 * gnu-v3-abi.c: Update.
12088 * guile/guile-internal.h: Update.
12089 * guile/scm-block.c: Update.
12090 * guile/scm-breakpoint.c: Update.
12091 * guile/scm-cmd.c: Update.
12092 * guile/scm-disasm.c: Update.
12093 * guile/scm-frame.c: Update.
12094 * guile/scm-lazy-string.c: Update.
12095 * guile/scm-math.c: Update.
12096 * guile/scm-param.c: Update.
12097 * guile/scm-ports.c: Update.
12098 * guile/scm-pretty-print.c: Update.
12099 * guile/scm-symbol.c: Update.
12100 * guile/scm-symtab.c: Update.
12101 * guile/scm-type.c: Update.
12102 * guile/scm-value.c: Update.
12103 * i386-linux-tdep.c: Update.
12104 * i386-tdep.c: Update.
12105 * inf-loop.c: Update.
12106 * infcall.c: Update.
12107 * infcmd.c: Update.
12108 * infrun.c: Update.
12109 * jit.c: Update.
12110 * language.c: Update.
12111 * linespec.c: Update.
12112 * linux-fork.c: Update.
12113 * linux-nat.c: Update.
12114 * linux-tdep.c: Update.
12115 * linux-thread-db.c: Update.
12116 * main.c: Update.
12117 * mi/mi-cmd-break.c: Update.
12118 * mi/mi-cmd-stack.c: Update.
12119 * mi/mi-interp.c: Update.
12120 * mi/mi-main.c: Update.
12121 * objc-lang.c: Update.
12122 * p-valprint.c: Update.
12123 * parse.c: Update.
12124 * ppc-linux-tdep.c: Update.
12125 * printcmd.c: Update.
12126 * python/py-arch.c: Update.
12127 * python/py-breakpoint.c: Update.
12128 * python/py-cmd.c: Update.
12129 * python/py-finishbreakpoint.c: Update.
12130 * python/py-frame.c: Update.
12131 * python/py-framefilter.c: Update.
12132 * python/py-gdb-readline.c: Update.
12133 * python/py-inferior.c: Update.
12134 * python/py-infthread.c: Update.
12135 * python/py-lazy-string.c: Update.
12136 * python/py-linetable.c: Update.
12137 * python/py-objfile.c: Update.
12138 * python/py-param.c: Update.
12139 * python/py-prettyprint.c: Update.
12140 * python/py-progspace.c: Update.
12141 * python/py-record-btrace.c: Update.
12142 * python/py-record.c: Update.
12143 * python/py-symbol.c: Update.
12144 * python/py-type.c: Update.
12145 * python/py-unwind.c: Update.
12146 * python/py-utils.c: Update.
12147 * python/py-value.c: Update.
12148 * python/python.c: Update.
12149 * record-btrace.c: Update.
12150 * record-full.c: Update.
12151 * remote-fileio.c: Update.
12152 * remote.c: Update.
12153 * riscv-tdep.c: Update.
12154 * rs6000-aix-tdep.c: Update.
12155 * rs6000-tdep.c: Update.
12156 * rust-exp.y: Update.
12157 * rust-lang.c: Update.
12158 * s390-tdep.c: Update.
12159 * selftest-arch.c: Update.
12160 * solib-dsbt.c: Update.
12161 * solib-frv.c: Update.
12162 * solib-spu.c: Update.
12163 * solib-svr4.c: Update.
12164 * solib.c: Update.
12165 * sparc64-linux-tdep.c: Update.
12166 * stack.c: Update.
12167 * symfile-mem.c: Update.
12168 * symmisc.c: Update.
12169 * target.c: Update.
12170 * thread.c: Update.
12171 * top.c: Update.
12172 * tracefile-tfile.c: Update.
12173 * tui/tui.c: Update.
12174 * typeprint.c: Update.
12175 * unittests/cli-utils-selftests.c: Update.
12176 * unittests/parse-connection-spec-selftests.c: Update.
12177 * valops.c: Update.
12178 * valprint.c: Update.
12179 * value.c: Update.
12180 * varobj.c: Update.
12181 * windows-nat.c: Update.
12182 * x86-linux-nat.c: Update.
12183 * xml-support.c: Update.
12184
a70b8144
TT		 121852019-04-08 Tom Tromey <tom@tromey.com>
12186
12187 * xml-support.c: Use C++ exception handling.
12188 * x86-linux-nat.c: Use C++ exception handling.
12189 * windows-nat.c: Use C++ exception handling.
12190 * varobj.c: Use C++ exception handling.
12191 * value.c: Use C++ exception handling.
12192 * valprint.c: Use C++ exception handling.
12193 * valops.c: Use C++ exception handling.
12194 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12195 handling.
12196 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12197 * typeprint.c: Use C++ exception handling.
12198 * tui/tui.c: Use C++ exception handling.
12199 * tracefile-tfile.c: Use C++ exception handling.
12200 * top.c: Use C++ exception handling.
12201 * thread.c: Use C++ exception handling.
12202 * target.c: Use C++ exception handling.
12203 * symmisc.c: Use C++ exception handling.
12204 * symfile-mem.c: Use C++ exception handling.
12205 * stack.c: Use C++ exception handling.
12206 * sparc64-linux-tdep.c: Use C++ exception handling.
12207 * solib.c: Use C++ exception handling.
12208 * solib-svr4.c: Use C++ exception handling.
12209 * solib-spu.c: Use C++ exception handling.
12210 * solib-frv.c: Use C++ exception handling.
12211 * solib-dsbt.c: Use C++ exception handling.
12212 * selftest-arch.c: Use C++ exception handling.
12213 * s390-tdep.c: Use C++ exception handling.
12214 * rust-lang.c: Use C++ exception handling.
12215 * rust-exp.y: Use C++ exception handling.
12216 * rs6000-tdep.c: Use C++ exception handling.
12217 * rs6000-aix-tdep.c: Use C++ exception handling.
12218 * riscv-tdep.c: Use C++ exception handling.
12219 * remote.c: Use C++ exception handling.
12220 * remote-fileio.c: Use C++ exception handling.
12221 * record-full.c: Use C++ exception handling.
12222 * record-btrace.c: Use C++ exception handling.
12223 * python/python.c: Use C++ exception handling.
12224 * python/py-value.c: Use C++ exception handling.
12225 * python/py-utils.c: Use C++ exception handling.
12226 * python/py-unwind.c: Use C++ exception handling.
12227 * python/py-type.c: Use C++ exception handling.
12228 * python/py-symbol.c: Use C++ exception handling.
12229 * python/py-record.c: Use C++ exception handling.
12230 * python/py-record-btrace.c: Use C++ exception handling.
12231 * python/py-progspace.c: Use C++ exception handling.
12232 * python/py-prettyprint.c: Use C++ exception handling.
12233 * python/py-param.c: Use C++ exception handling.
12234 * python/py-objfile.c: Use C++ exception handling.
12235 * python/py-linetable.c: Use C++ exception handling.
12236 * python/py-lazy-string.c: Use C++ exception handling.
12237 * python/py-infthread.c: Use C++ exception handling.
12238 * python/py-inferior.c: Use C++ exception handling.
12239 * python/py-gdb-readline.c: Use C++ exception handling.
12240 * python/py-framefilter.c: Use C++ exception handling.
12241 * python/py-frame.c: Use C++ exception handling.
12242 * python/py-finishbreakpoint.c: Use C++ exception handling.
12243 * python/py-cmd.c: Use C++ exception handling.
12244 * python/py-breakpoint.c: Use C++ exception handling.
12245 * python/py-arch.c: Use C++ exception handling.
12246 * printcmd.c: Use C++ exception handling.
12247 * ppc-linux-tdep.c: Use C++ exception handling.
12248 * parse.c: Use C++ exception handling.
12249 * p-valprint.c: Use C++ exception handling.
12250 * objc-lang.c: Use C++ exception handling.
12251 * mi/mi-main.c: Use C++ exception handling.
12252 * mi/mi-interp.c: Use C++ exception handling.
12253 * mi/mi-cmd-stack.c: Use C++ exception handling.
12254 * mi/mi-cmd-break.c: Use C++ exception handling.
12255 * main.c: Use C++ exception handling.
12256 * linux-thread-db.c: Use C++ exception handling.
12257 * linux-tdep.c: Use C++ exception handling.
12258 * linux-nat.c: Use C++ exception handling.
12259 * linux-fork.c: Use C++ exception handling.
12260 * linespec.c: Use C++ exception handling.
12261 * language.c: Use C++ exception handling.
12262 * jit.c: Use C++ exception handling.
12263 * infrun.c: Use C++ exception handling.
12264 * infcmd.c: Use C++ exception handling.
12265 * infcall.c: Use C++ exception handling.
12266 * inf-loop.c: Use C++ exception handling.
12267 * i386-tdep.c: Use C++ exception handling.
12268 * i386-linux-tdep.c: Use C++ exception handling.
12269 * guile/scm-value.c: Use C++ exception handling.
12270 * guile/scm-type.c: Use C++ exception handling.
12271 * guile/scm-symtab.c: Use C++ exception handling.
12272 * guile/scm-symbol.c: Use C++ exception handling.
12273 * guile/scm-pretty-print.c: Use C++ exception handling.
12274 * guile/scm-ports.c: Use C++ exception handling.
12275 * guile/scm-param.c: Use C++ exception handling.
12276 * guile/scm-math.c: Use C++ exception handling.
12277 * guile/scm-lazy-string.c: Use C++ exception handling.
12278 * guile/scm-frame.c: Use C++ exception handling.
12279 * guile/scm-disasm.c: Use C++ exception handling.
12280 * guile/scm-cmd.c: Use C++ exception handling.
12281 * guile/scm-breakpoint.c: Use C++ exception handling.
12282 * guile/scm-block.c: Use C++ exception handling.
12283 * guile/guile-internal.h: Use C++ exception handling.
12284 * gnu-v3-abi.c: Use C++ exception handling.
12285 * gdbtypes.c: Use C++ exception handling.
12286 * frame.c: Use C++ exception handling.
12287 * frame-unwind.c: Use C++ exception handling.
12288 * fbsd-tdep.c: Use C++ exception handling.
12289 * f-valprint.c: Use C++ exception handling.
12290 * exec.c: Use C++ exception handling.
12291 * event-top.c: Use C++ exception handling.
12292 * event-loop.c: Use C++ exception handling.
12293 * eval.c: Use C++ exception handling.
12294 * dwarf2read.c: Use C++ exception handling.
12295 * dwarf2loc.c: Use C++ exception handling.
12296 * dwarf2-frame.c: Use C++ exception handling.
12297 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12298 * dwarf-index-write.c: Use C++ exception handling.
12299 * dwarf-index-cache.c: Use C++ exception handling.
12300 * dtrace-probe.c: Use C++ exception handling.
12301 * disasm-selftests.c: Use C++ exception handling.
12302 * darwin-nat.c: Use C++ exception handling.
12303 * cp-valprint.c: Use C++ exception handling.
12304 * cp-support.c: Use C++ exception handling.
12305 * cp-abi.c: Use C++ exception handling.
12306 * corelow.c: Use C++ exception handling.
12307 * completer.c: Use C++ exception handling.
12308 * compile/compile-object-run.c: Use C++ exception handling.
12309 * compile/compile-object-load.c: Use C++ exception handling.
12310 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12311 * compile/compile-c-symbols.c: Use C++ exception handling.
12312 * common/selftest.c: Use C++ exception handling.
12313 * common/new-op.c: Use C++ exception handling.
12314 * cli/cli-script.c: Use C++ exception handling.
12315 * cli/cli-interp.c: Use C++ exception handling.
12316 * cli/cli-cmds.c: Use C++ exception handling.
12317 * c-varobj.c: Use C++ exception handling.
12318 * btrace.c: Use C++ exception handling.
12319 * breakpoint.c: Use C++ exception handling.
12320 * break-catch-throw.c: Use C++ exception handling.
12321 * arch-utils.c: Use C++ exception handling.
12322 * amd64-tdep.c: Use C++ exception handling.
12323 * ada-valprint.c: Use C++ exception handling.
12324 * ada-typeprint.c: Use C++ exception handling.
12325 * ada-lang.c: Use C++ exception handling.
12326 * aarch64-tdep.c: Use C++ exception handling.
12327
3d6e9d23
TT		 123282019-04-08 Tom Tromey <tom@tromey.com>
12329
12330 * xml-support.c (gdb_xml_parser::parse): Update.
12331 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12332 * value.c (show_convenience): Update.
12333 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12334 (test_parse_flags_qcs): Update.
12335 * thread.c (thr_try_catch_cmd): Update.
12336 * target.c (target_translate_tls_address): Update.
12337 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12338 (info_frame_command_core, frame_apply_command_count): Update.
12339 * rust-exp.y (rust_lex_exception_test): Update.
12340 * riscv-tdep.c (riscv_print_one_register_info): Update.
12341 * remote.c (remote_target::enable_btrace): Update.
12342 * record-btrace.c (record_btrace_enable_warn): Update.
12343 * python/py-utils.c (gdbpy_convert_exception): Update.
12344 * printcmd.c (do_one_display, print_variable_and_value): Update.
12345 * mi/mi-main.c (mi_print_exception): Update.
12346 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12347 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12348 * linux-nat.c (linux_nat_target::attach): Update.
12349 * linux-fork.c (class scoped_switch_fork_info): Update.
12350 * infrun.c (displaced_step_prepare): Update.
12351 * infcall.c (call_function_by_hand_dummy): Update.
12352 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12353 * gnu-v3-abi.c (print_one_vtable): Update.
12354 * frame.c (get_prev_frame_always): Update.
12355 * f-valprint.c (info_common_command_for_block): Update.
12356 * exec.c (try_open_exec_file): Update.
12357 * exceptions.c (print_exception, exception_print)
12358 (exception_fprintf, exception_print_same): Update.
12359 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12360 * dwarf-index-cache.c (index_cache::store)
12361 (index_cache::lookup_gdb_index): Update.
12362 * darwin-nat.c (maybe_cache_shell): Update.
12363 * cp-valprint.c (cp_print_value_fields): Update.
12364 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12365 (gcc_cplus_symbol_address): Update.
12366 * compile/compile-c-symbols.c (gcc_convert_symbol)
12367 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12368 * common/selftest.c: Update.
12369 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12370 a std::string.
12371 (exception_try_scope_entry, exception_try_scope_exit): Don't
12372 declare.
12373 (struct exception_try_scope): Remove.
12374 (TRY): Don't use exception_try_scope.
12375 (struct gdb_exception): Add constructor, operator=.
12376 <what>: New method.
12377 (struct gdb_exception_RETURN_MASK_ALL)
12378 (struct gdb_exception_RETURN_MASK_ERROR)
12379 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12380 (struct gdb_quit_bad_alloc): Update.
12381 * common/common-exceptions.c (exception_none): Change
12382 initializer.
12383 (struct catcher) <state, exception>: Initialize inline.
12384 <prev>: Remove member.
12385 (current_catcher): Remove.
12386 (catchers): New global.
12387 (exceptions_state_mc_init): Simplify.
12388 (catcher_pop): Remove.
12389 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12390 (try_scope_depth, exception_try_scope_entry)
12391 (exception_try_scope_exit): Remove.
12392 (throw_exception_sjlj): Update.
12393 (exception_messages, exception_messages_size): Remove.
12394 (throw_it): Simplify.
12395 (gdb_exception_sliced_copy): Remove.
12396 (throw_exception_cxx): Update.
12397 * cli/cli-script.c (script_from_file): Update.
12398 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12399 Update.
12400 * ada-valprint.c (ada_val_print): Update.
12401 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12402 (create_excep_cond_exprs): Update.
12403
c5c10118
TT		 124042019-04-08 Tom Tromey <tom@tromey.com>
12405
12406 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12407 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12408 (TRY, CATCH, END_CATCH): Remove some definitions.
12409 * common/common-exceptions.c: Don't use GDB_XCPT.
12410 (catcher_list_size): Remove.
12411 (throw_exception, throw_it): Simplify.
12412
4de283e4
TT		 124132019-04-05 Tom Tromey <tom@tromey.com>
12414
12415 Revert the header-sorting patch.
12416 * ft32-tdep.c: Revert.
12417 * frv-tdep.c: Revert.
12418 * frv-linux-tdep.c: Revert.
12419 * frame.c: Revert.
12420 * frame-unwind.c: Revert.
12421 * frame-base.c: Revert.
12422 * fork-child.c: Revert.
12423 * findvar.c: Revert.
12424 * findcmd.c: Revert.
12425 * filesystem.c: Revert.
12426 * filename-seen-cache.h: Revert.
12427 * filename-seen-cache.c: Revert.
12428 * fbsd-tdep.c: Revert.
12429 * fbsd-nat.h: Revert.
12430 * fbsd-nat.c: Revert.
12431 * f-valprint.c: Revert.
12432 * f-typeprint.c: Revert.
12433 * f-lang.c: Revert.
12434 * extension.h: Revert.
12435 * extension.c: Revert.
12436 * extension-priv.h: Revert.
12437 * expprint.c: Revert.
12438 * exec.h: Revert.
12439 * exec.c: Revert.
12440 * exceptions.c: Revert.
12441 * event-top.c: Revert.
12442 * event-loop.c: Revert.
12443 * eval.c: Revert.
12444 * elfread.c: Revert.
12445 * dwarf2read.h: Revert.
12446 * dwarf2read.c: Revert.
12447 * dwarf2loc.c: Revert.
12448 * dwarf2expr.h: Revert.
12449 * dwarf2expr.c: Revert.
12450 * dwarf2-frame.c: Revert.
12451 * dwarf2-frame-tailcall.c: Revert.
12452 * dwarf-index-write.h: Revert.
12453 * dwarf-index-write.c: Revert.
12454 * dwarf-index-common.c: Revert.
12455 * dwarf-index-cache.h: Revert.
12456 * dwarf-index-cache.c: Revert.
12457 * dummy-frame.c: Revert.
12458 * dtrace-probe.c: Revert.
12459 * disasm.h: Revert.
12460 * disasm.c: Revert.
12461 * disasm-selftests.c: Revert.
12462 * dictionary.c: Revert.
12463 * dicos-tdep.c: Revert.
12464 * demangle.c: Revert.
12465 * dcache.h: Revert.
12466 * dcache.c: Revert.
12467 * darwin-nat.h: Revert.
12468 * darwin-nat.c: Revert.
12469 * darwin-nat-info.c: Revert.
12470 * d-valprint.c: Revert.
12471 * d-namespace.c: Revert.
12472 * d-lang.c: Revert.
12473 * ctf.c: Revert.
12474 * csky-tdep.c: Revert.
12475 * csky-linux-tdep.c: Revert.
12476 * cris-tdep.c: Revert.
12477 * cris-linux-tdep.c: Revert.
12478 * cp-valprint.c: Revert.
12479 * cp-support.c: Revert.
12480 * cp-namespace.c: Revert.
12481 * cp-abi.c: Revert.
12482 * corelow.c: Revert.
12483 * corefile.c: Revert.
12484 * continuations.c: Revert.
12485 * completer.h: Revert.
12486 * completer.c: Revert.
12487 * complaints.c: Revert.
12488 * coffread.c: Revert.
12489 * coff-pe-read.c: Revert.
12490 * cli-out.h: Revert.
12491 * cli-out.c: Revert.
12492 * charset.c: Revert.
12493 * c-varobj.c: Revert.
12494 * c-valprint.c: Revert.
12495 * c-typeprint.c: Revert.
12496 * c-lang.c: Revert.
12497 * buildsym.c: Revert.
12498 * buildsym-legacy.c: Revert.
12499 * build-id.h: Revert.
12500 * build-id.c: Revert.
12501 * btrace.c: Revert.
12502 * bsd-uthread.c: Revert.
12503 * breakpoint.h: Revert.
12504 * breakpoint.c: Revert.
12505 * break-catch-throw.c: Revert.
12506 * break-catch-syscall.c: Revert.
12507 * break-catch-sig.c: Revert.
12508 * blockframe.c: Revert.
12509 * block.c: Revert.
12510 * bfin-tdep.c: Revert.
12511 * bfin-linux-tdep.c: Revert.
12512 * bfd-target.c: Revert.
12513 * bcache.c: Revert.
12514 * ax-general.c: Revert.
12515 * ax-gdb.h: Revert.
12516 * ax-gdb.c: Revert.
12517 * avr-tdep.c: Revert.
12518 * auxv.c: Revert.
12519 * auto-load.c: Revert.
12520 * arm-wince-tdep.c: Revert.
12521 * arm-tdep.c: Revert.
12522 * arm-symbian-tdep.c: Revert.
12523 * arm-pikeos-tdep.c: Revert.
12524 * arm-obsd-tdep.c: Revert.
12525 * arm-nbsd-tdep.c: Revert.
12526 * arm-nbsd-nat.c: Revert.
12527 * arm-linux-tdep.c: Revert.
12528 * arm-linux-nat.c: Revert.
12529 * arm-fbsd-tdep.c: Revert.
12530 * arm-fbsd-nat.c: Revert.
12531 * arm-bsd-tdep.c: Revert.
12532 * arch-utils.c: Revert.
12533 * arc-tdep.c: Revert.
12534 * arc-newlib-tdep.c: Revert.
12535 * annotate.h: Revert.
12536 * annotate.c: Revert.
12537 * amd64-windows-tdep.c: Revert.
12538 * amd64-windows-nat.c: Revert.
12539 * amd64-tdep.c: Revert.
12540 * amd64-sol2-tdep.c: Revert.
12541 * amd64-obsd-tdep.c: Revert.
12542 * amd64-obsd-nat.c: Revert.
12543 * amd64-nbsd-tdep.c: Revert.
12544 * amd64-nbsd-nat.c: Revert.
12545 * amd64-nat.c: Revert.
12546 * amd64-linux-tdep.c: Revert.
12547 * amd64-linux-nat.c: Revert.
12548 * amd64-fbsd-tdep.c: Revert.
12549 * amd64-fbsd-nat.c: Revert.
12550 * amd64-dicos-tdep.c: Revert.
12551 * amd64-darwin-tdep.c: Revert.
12552 * amd64-bsd-nat.c: Revert.
12553 * alpha-tdep.c: Revert.
12554 * alpha-obsd-tdep.c: Revert.
12555 * alpha-nbsd-tdep.c: Revert.
12556 * alpha-mdebug-tdep.c: Revert.
12557 * alpha-linux-tdep.c: Revert.
12558 * alpha-linux-nat.c: Revert.
12559 * alpha-bsd-tdep.c: Revert.
12560 * alpha-bsd-nat.c: Revert.
12561 * aix-thread.c: Revert.
12562 * agent.c: Revert.
12563 * addrmap.c: Revert.
12564 * ada-varobj.c: Revert.
12565 * ada-valprint.c: Revert.
12566 * ada-typeprint.c: Revert.
12567 * ada-tasks.c: Revert.
12568 * ada-lang.c: Revert.
12569 * aarch64-tdep.c: Revert.
12570 * aarch64-ravenscar-thread.c: Revert.
12571 * aarch64-newlib-tdep.c: Revert.
12572 * aarch64-linux-tdep.c: Revert.
12573 * aarch64-linux-nat.c: Revert.
12574 * aarch64-fbsd-tdep.c: Revert.
12575 * aarch64-fbsd-nat.c: Revert.
12576 * aarch32-linux-nat.c: Revert.
12577
d55e5aa6
TT		 125782019-04-05 Tom Tromey <tom@tromey.com>
12579
12580 * ft32-tdep.c: Sort headers.
12581 * frv-tdep.c: Sort headers.
12582 * frv-linux-tdep.c: Sort headers.
12583 * frame.c: Sort headers.
12584 * frame-unwind.c: Sort headers.
12585 * frame-base.c: Sort headers.
12586 * fork-child.c: Sort headers.
12587 * findvar.c: Sort headers.
12588 * findcmd.c: Sort headers.
12589 * filesystem.c: Sort headers.
12590 * filename-seen-cache.h: Sort headers.
12591 * filename-seen-cache.c: Sort headers.
12592 * fbsd-tdep.c: Sort headers.
12593 * fbsd-nat.h: Sort headers.
12594 * fbsd-nat.c: Sort headers.
12595 * f-valprint.c: Sort headers.
12596 * f-typeprint.c: Sort headers.
12597 * f-lang.c: Sort headers.
12598 * extension.h: Sort headers.
12599 * extension.c: Sort headers.
12600 * extension-priv.h: Sort headers.
12601 * expprint.c: Sort headers.
12602 * exec.h: Sort headers.
12603 * exec.c: Sort headers.
12604 * exceptions.c: Sort headers.
12605 * event-top.c: Sort headers.
12606 * event-loop.c: Sort headers.
12607 * eval.c: Sort headers.
12608 * elfread.c: Sort headers.
12609 * dwarf2read.h: Sort headers.
12610 * dwarf2read.c: Sort headers.
12611 * dwarf2loc.c: Sort headers.
12612 * dwarf2expr.h: Sort headers.
12613 * dwarf2expr.c: Sort headers.
12614 * dwarf2-frame.c: Sort headers.
12615 * dwarf2-frame-tailcall.c: Sort headers.
12616 * dwarf-index-write.h: Sort headers.
12617 * dwarf-index-write.c: Sort headers.
12618 * dwarf-index-common.c: Sort headers.
12619 * dwarf-index-cache.h: Sort headers.
12620 * dwarf-index-cache.c: Sort headers.
12621 * dummy-frame.c: Sort headers.
12622 * dtrace-probe.c: Sort headers.
12623 * disasm.h: Sort headers.
12624 * disasm.c: Sort headers.
12625 * disasm-selftests.c: Sort headers.
12626 * dictionary.c: Sort headers.
12627 * dicos-tdep.c: Sort headers.
12628 * demangle.c: Sort headers.
12629 * dcache.h: Sort headers.
12630 * dcache.c: Sort headers.
12631 * darwin-nat.h: Sort headers.
12632 * darwin-nat.c: Sort headers.
12633 * darwin-nat-info.c: Sort headers.
12634 * d-valprint.c: Sort headers.
12635 * d-namespace.c: Sort headers.
12636 * d-lang.c: Sort headers.
12637 * ctf.c: Sort headers.
12638 * csky-tdep.c: Sort headers.
12639 * csky-linux-tdep.c: Sort headers.
12640 * cris-tdep.c: Sort headers.
12641 * cris-linux-tdep.c: Sort headers.
12642 * cp-valprint.c: Sort headers.
12643 * cp-support.c: Sort headers.
12644 * cp-namespace.c: Sort headers.
12645 * cp-abi.c: Sort headers.
12646 * corelow.c: Sort headers.
12647 * corefile.c: Sort headers.
12648 * continuations.c: Sort headers.
12649 * completer.h: Sort headers.
12650 * completer.c: Sort headers.
12651 * complaints.c: Sort headers.
12652 * coffread.c: Sort headers.
12653 * coff-pe-read.c: Sort headers.
12654 * cli-out.h: Sort headers.
12655 * cli-out.c: Sort headers.
12656 * charset.c: Sort headers.
12657 * c-varobj.c: Sort headers.
12658 * c-valprint.c: Sort headers.
12659 * c-typeprint.c: Sort headers.
12660 * c-lang.c: Sort headers.
12661 * buildsym.c: Sort headers.
12662 * buildsym-legacy.c: Sort headers.
12663 * build-id.h: Sort headers.
12664 * build-id.c: Sort headers.
12665 * btrace.c: Sort headers.
12666 * bsd-uthread.c: Sort headers.
12667 * breakpoint.h: Sort headers.
12668 * breakpoint.c: Sort headers.
12669 * break-catch-throw.c: Sort headers.
12670 * break-catch-syscall.c: Sort headers.
12671 * break-catch-sig.c: Sort headers.
12672 * blockframe.c: Sort headers.
12673 * block.c: Sort headers.
12674 * bfin-tdep.c: Sort headers.
12675 * bfin-linux-tdep.c: Sort headers.
12676 * bfd-target.c: Sort headers.
12677 * bcache.c: Sort headers.
12678 * ax-general.c: Sort headers.
12679 * ax-gdb.h: Sort headers.
12680 * ax-gdb.c: Sort headers.
12681 * avr-tdep.c: Sort headers.
12682 * auxv.c: Sort headers.
12683 * auto-load.c: Sort headers.
12684 * arm-wince-tdep.c: Sort headers.
12685 * arm-tdep.c: Sort headers.
12686 * arm-symbian-tdep.c: Sort headers.
12687 * arm-pikeos-tdep.c: Sort headers.
12688 * arm-obsd-tdep.c: Sort headers.
12689 * arm-nbsd-tdep.c: Sort headers.
12690 * arm-nbsd-nat.c: Sort headers.
12691 * arm-linux-tdep.c: Sort headers.
12692 * arm-linux-nat.c: Sort headers.
12693 * arm-fbsd-tdep.c: Sort headers.
12694 * arm-fbsd-nat.c: Sort headers.
12695 * arm-bsd-tdep.c: Sort headers.
12696 * arch-utils.c: Sort headers.
12697 * arc-tdep.c: Sort headers.
12698 * arc-newlib-tdep.c: Sort headers.
12699 * annotate.h: Sort headers.
12700 * annotate.c: Sort headers.
12701 * amd64-windows-tdep.c: Sort headers.
12702 * amd64-windows-nat.c: Sort headers.
12703 * amd64-tdep.c: Sort headers.
12704 * amd64-sol2-tdep.c: Sort headers.
12705 * amd64-obsd-tdep.c: Sort headers.
12706 * amd64-obsd-nat.c: Sort headers.
12707 * amd64-nbsd-tdep.c: Sort headers.
12708 * amd64-nbsd-nat.c: Sort headers.
12709 * amd64-nat.c: Sort headers.
12710 * amd64-linux-tdep.c: Sort headers.
12711 * amd64-linux-nat.c: Sort headers.
12712 * amd64-fbsd-tdep.c: Sort headers.
12713 * amd64-fbsd-nat.c: Sort headers.
12714 * amd64-dicos-tdep.c: Sort headers.
12715 * amd64-darwin-tdep.c: Sort headers.
12716 * amd64-bsd-nat.c: Sort headers.
12717 * alpha-tdep.c: Sort headers.
12718 * alpha-obsd-tdep.c: Sort headers.
12719 * alpha-nbsd-tdep.c: Sort headers.
12720 * alpha-mdebug-tdep.c: Sort headers.
12721 * alpha-linux-tdep.c: Sort headers.
12722 * alpha-linux-nat.c: Sort headers.
12723 * alpha-bsd-tdep.c: Sort headers.
12724 * alpha-bsd-nat.c: Sort headers.
12725 * aix-thread.c: Sort headers.
12726 * agent.c: Sort headers.
12727 * addrmap.c: Sort headers.
12728 * ada-varobj.c: Sort headers.
12729 * ada-valprint.c: Sort headers.
12730 * ada-typeprint.c: Sort headers.
12731 * ada-tasks.c: Sort headers.
12732 * ada-lang.c: Sort headers.
12733 * aarch64-tdep.c: Sort headers.
12734 * aarch64-ravenscar-thread.c: Sort headers.
12735 * aarch64-newlib-tdep.c: Sort headers.
12736 * aarch64-linux-tdep.c: Sort headers.
12737 * aarch64-linux-nat.c: Sort headers.
12738 * aarch64-fbsd-tdep.c: Sort headers.
12739 * aarch64-fbsd-nat.c: Sort headers.
12740 * aarch32-linux-nat.c: Sort headers.
12741
699bd4cf
TT		 127422019-04-04 Tom Tromey <tom@tromey.com>
12743
12744 * varobj.c (varobj_create): Update.
12745 * rust-exp.y (struct rust_parser) <update_innermost_block,
12746 lookup_symbol>: New methods.
12747 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12748 Rename.
12749 (rust_parser::rust_lookup_type)
12750 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12751 * printcmd.c (display_command, do_one_display): Update.
12752 * parser-defs.h (struct parser_state) <parser_state>: Add
12753 "tracker" parameter.
12754 (block_tracker): New member.
12755 (class innermost_block_tracker) <innermost_block_tracker>: Add
12756 "types" parameter.
12757 <reset>: Remove method.
12758 (innermost_block): Don't declare.
12759 (null_post_parser): Update.
12760 * parse.c (innermost_block): Remove global.
12761 (write_dollar_variable): Update.
12762 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12763 Remove "tracker_types" parameter.
12764 (parse_expression): Add "tracker" parameter.
12765 (parse_expression_for_completion): Update.
12766 (null_post_parser): Add "tracker" parameter.
12767 * p-exp.y: Update rules.
12768 * m2-exp.y: Update rules.
12769 * language.h (struct language_defn) <la_post_parser>: Add
12770 "tracker" parameter.
12771 * go-exp.y: Update rules.
12772 * f-exp.y: Update rules.
12773 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12774 parameter.
12775 * d-exp.y: Update rules.
12776 * c-exp.y: Update rules.
12777 * breakpoint.c (set_breakpoint_condition): Create an
12778 innermost_block_tracker.
12779 (watch_command_1): Likewise.
12780 * ada-lang.c (resolve): Add "tracker" parameter.
12781 (resolve_subexp): Likewise.
12782 * ada-exp.y (write_var_from_sym): Update.
12783
dac43e32
TT		 127842019-04-04 Tom Tromey <tom@tromey.com>
12785
12786 * type-stack.h: New file.
12787 * type-stack.c: New file.
12788 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12789 type-stack.h.
12790 (insert_into_type_stack, insert_type, push_type, push_type_int)
12791 (insert_type_address_space, pop_type, pop_type_int)
12792 (pop_typelist, pop_type_stack, append_type_stack)
12793 (push_type_stack, get_type_stack, push_typelist)
12794 (follow_type_instance_flags, follow_types): Don't declare.
12795 * parse.c (type_stack): Remove global.
12796 (parse_exp_in_context): Update.
12797 (insert_into_type_stack, insert_type, push_type, push_type_int)
12798 (insert_type_address_space, pop_type, pop_type_int)
12799 (pop_typelist, pop_type_stack, append_type_stack)
12800 (push_type_stack, get_type_stack, push_typelist)
12801 (follow_type_instance_flags, follow_types): Remove (moved to
12802 type-stack.c).
12803 * f-exp.y (type_stack): New global.
12804 Update rules.
12805 (push_kind_type, f_parse): Update.
12806 * d-exp.y (type_stack): New global.
12807 Update rules.
12808 (d_parse): Update.
12809 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12810 Update rules.
12811 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12812 (HFILES_NO_SRCDIR): Add type-stack.h.
12813
2a612529
TT		 128142019-04-04 Tom Tromey <tom@tromey.com>
12815
12816 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12817 (rust_parser::convert_ast_to_expression, rust_parse)
12818 (rust_lex_test_completion, rust_lex_tests): Update.
12819 * parser-defs.h (struct expr_completion_state): New.
12820 (struct parser_state) <parser_state>: Add completion parameter.
12821 <mark_struct_expression, mark_completion_tag>: New methods.
12822 <parse_completion, m_completion_state>: New members.
12823 (prefixify_expression, null_post_parser): Update.
12824 (mark_struct_expression, mark_completion_tag): Don't declare.
12825 * parse.c (parse_completion, expout_last_struct)
12826 (expout_tag_completion_type, expout_completion_name): Remove
12827 globals.
12828 (parser_state::mark_struct_expression)
12829 (parser_state::mark_completion_tag): Now methods.
12830 (prefixify_expression): Add last_struct parameter.
12831 (prefixify_subexp): Likewise.
12832 (parse_exp_1): Update.
12833 (parse_exp_in_context): Add cstate parameter. Update.
12834 (parse_expression_for_completion): Create an
12835 expr_completion_state.
12836 (null_post_parser): Add "completion" parameter.
12837 * p-exp.y: Update rules.
12838 (yylex): Update.
12839 * language.h (struct language_defn) <la_post_parser>: Add
12840 "completing" parameter.
12841 * go-exp.y: Update rules.
12842 (lex_one_token): Update.
12843 * expression.h (parse_completion): Don't declare.
12844 * d-exp.y: Update rules.
12845 (lex_one_token): Update rules.
12846 * c-exp.y: Update rules.
12847 (lex_one_token): Update.
12848 * ada-lang.c (resolve): Add "parse_completion" parameter.
12849 (resolve_subexp): Likewise.
12850 (ada_resolve_function): Likewise.
12851
43476f0b
TT		 128522019-04-04 Tom Tromey <tom@tromey.com>
12853
12854 * parser-defs.h (struct parser_state) <start_arglist,
12855 end_arglist>: New methods.
12856 <arglist_len, m_funcall_chain>: New members.
12857 (arglist_len, start_arglist, end_arglist): Don't declare.
12858 * parse.c (arglist_len, funcall_chain): Remove global.
12859 (start_arglist, end_arglist): Remove functions.
12860 (parse_exp_in_context): Update.
12861 * p-exp.y: Update rules.
12862 * m2-exp.y: Update rules.
12863 * go-exp.y: Update rules.
12864 * f-exp.y: Update rules.
12865 * d-exp.y: Update rules.
12866 * c-exp.y: Update rules.
12867
5776fca3
TT		 128682019-04-04 Tom Tromey <tom@tromey.com>
12869
12870 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12871 lex_operator, push_back>: New methods.
12872 Update all rules.
12873 (rust_parser::lex_hex, lex_escape): Rename and update.
12874 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12875 (rust_parser::lex_operator): Rename and update.
12876 (rust_parser::lex_number, rustyylex, rustyyerror)
12877 (rust_lex_test_init, rust_lex_test_sequence)
12878 (rust_lex_test_push_back, rust_lex_tests): Update.
12879 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12880 parameter.
12881 <lexptr, prev_lexptr>: New members.
12882 (lexptr, prev_lexptr): Don't declare.
12883 * parse.c (lexptr, prev_lexptr): Remove globals.
12884 (parse_exp_in_context): Update.
12885 * p-exp.y (yylex, yyerror): Update.
12886 * m2-exp.y (parse_number, yylex, yyerror): Update.
12887 * go-exp.y (lex_one_token, yyerror): Update.
12888 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12889 * d-exp.y (lex_one_token, yyerror): Update.
12890 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12891 (lex_one_token, yyerror): Update.
12892 * ada-lex.l (YY_INPUT): Update.
12893 (rewind_to_char): Update.
12894 * ada-exp.y (yyerror): Update.
12895
8621b685
TT		 128962019-04-04 Tom Tromey <tom@tromey.com>
12897
12898 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12899 * parser-defs.h (struct parser_state) <parser_state>: Add new
12900 parameter.
12901 <comma_terminates>: New member.
12902 (comma_terminates): Don't declare global.
12903 * parse.c (comma_terminates): Remove global.
12904 (parse_exp_in_context): Update.
12905 * p-exp.y (yylex): Update.
12906 * m2-exp.y (yylex): Update.
12907 * go-exp.y (lex_one_token): Update.
12908 * f-exp.y (yylex): Update.
12909 * d-exp.y (lex_one_token): Update.
12910 * c-exp.y (lex_one_token): Update.
12911 * ada-lex.l: Update.
12912
28aaf3fd
TT		 129132019-04-04 Tom Tromey <tom@tromey.com>
12914
12915 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12916 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12917 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12918 * parser-defs.h (paren_depth): Don't declare.
12919 * parse.c (paren_depth): Remove global.
12920 (parse_exp_in_context): Update.
12921 * p-exp.y (paren_depth): New global.
12922 (pascal_parse): Initialize it.
12923 * m2-exp.y (paren_depth): New global.
12924 (m2_parse): Initialize it.
12925 * go-exp.y (paren_depth): New global.
12926 (go_parse): Initialize it.
12927 * f-exp.y (paren_depth): New global.
12928 (f_parse): Initialize it.
12929 * d-exp.y (paren_depth): New global.
12930 (d_parse): Initialize it.
12931 * c-exp.y (paren_depth): New global.
12932 (c_parse): Initialize it.
12933 * ada-lex.l (paren_depth): New global.
12934 (lexer_init): Initialize it.
12935
1e58a4a4
TT		 129362019-04-04 Tom Tromey <tom@tromey.com>
12937
12938 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12939 (rust_parser::convert_ast_to_type)
12940 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12941 * parser-defs.h (struct parser_state) <parser_state>: Add
12942 parameters. Initialize new members.
12943 <expression_context_block, expression_context_pc>: New members.
12944 * parse.c (expression_context_block, expression_context_pc):
12945 Remove globals.
12946 (parse_exp_in_context): Update.
12947 * p-exp.y: Update all rules.
12948 (yylex): Update.
12949 * m2-exp.y: Update all rules.
12950 (yylex): Update.
12951 * go-exp.y (yylex): Update.
12952 * f-exp.y (yylex): Update.
12953 * d-exp.y: Update all rules.
12954 (yylex): Update.
12955 * c-exp.y: Update all rules.
12956 (lex_one_token, classify_name, yylex, c_parse): Update.
12957 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12958
37eedb39
TT		 129592019-04-04 Tom Tromey <tom@tromey.com>
12960
12961 * gdbarch.h, gdbarch.c: Rebuild.
12962 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12963 * stap-probe.h:
12964 (struct stap_parse_info): Replace "parser_state" with
12965 "expr_builder".
12966 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12967 (parser_state): New class.
12968 * parse.c (expr_builder): Rename.
12969 (expr_builder::release): Rename.
12970 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12971 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12972 (write_exp_elt_longcst, write_exp_elt_floatcst)
12973 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12974 (write_exp_string_vector, write_exp_bitstring)
12975 (write_exp_msymbol, mark_struct_expression)
12976 (write_dollar_variable)
12977 (insert_type_address_space, increase_expout_size): Replace
12978 "parser_state" with "expr_builder".
12979 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12980 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12981 "parser_state" with "expr_builder".
12982
73923d7e
TT		 129832019-04-04 Tom Tromey <tom@tromey.com>
12984
12985 * rust-exp.y: Replace "parse_language" with method call.
12986 * p-exp.y:
12987 (yylex): Replace "parse_language" with method call.
12988 * m2-exp.y:
12989 (yylex): Replace "parse_language" with method call.
12990 * go-exp.y (classify_name): Replace "parse_language" with method
12991 call.
12992 * f-exp.y (yylex): Replace "parse_language" with method call.
12993 * d-exp.y (lex_one_token): Replace "parse_language" with method
12994 call.
12995 * c-exp.y:
12996 (lex_one_token, classify_name, yylex): Replace "parse_language"
12997 with method call.
12998 * ada-exp.y (find_primitive_type, type_char)
12999 (type_system_address): Replace "parse_language" with method call.
13000
fa9f5be6
TT		 130012019-04-04 Tom Tromey <tom@tromey.com>
13002
13003 * rust-exp.y: Replace "parse_gdbarch" with method call.
13004 * parse.c (write_dollar_variable, insert_type_address_space):
13005 Replace "parse_gdbarch" with method call.
13006 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13007 call.
13008 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13009 call.
13010 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13011 "parse_gdbarch" with method call.
13012 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13013 with method call.
13014 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13015 "parse_gdbarch" with method call.
13016 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13017 "parse_gdbarch" with method call.
13018 * c-exp.y (parse_type, parse_number, classify_name): Replace
13019 "parse_gdbarch" with method call.
13020 * ada-lex.l: Replace "parse_gdbarch" with method call.
13021 * ada-exp.y (parse_type, find_primitive_type, type_char)
13022 (type_system_address): Replace "parse_gdbarch" with method call.
13023
1201a264
TT		 130242019-04-04 Tom Tromey <tom@tromey.com>
13025
13026 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13027 * stap-probe.c (stap_parse_argument): Update.
13028 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13029 initial_size parameter.
13030 * rust-exp.y (rust_lex_tests): Update.
13031 * parse.c (parser_state): Update.
13032 (parse_exp_in_context): Update.
13033 * parser-defs.h (struct parser_state) <parser_state>: Remove
13034 "initial_size" parameter.
13035
e3980ce2
TT		 130362019-04-04 Tom Tromey <tom@tromey.com>
13037
13038 * parser-defs.h (increase_expout_size): Don't declare.
13039 * parse.c (increase_expout_size): Now static.
13040
e9f8e3f1
TS		 130412019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13042
13043 * gnu-nat.c (gnu_nat_target::wait): Fix
13044 target_waitstatus_to_string call.
13045
d7df6549
AB		 130462019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13047
13048 * eval.c (evaluate_subexp_standard): Handle internal functions
13049 during Fortran function call handling.
13050
8bdc1658
AB		 130512019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13052
13053 * NEWS: Mention new internal functions.
13054 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13055 (read_base_type): Use dwarf2_init_complex_target_type.
13056 * value.c (creal_internal_fn): New function.
13057 (cimag_internal_fn): New function.
13058 (_initialize_values): Register new internal functions.
13059
c29705b7
PW		 130602019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13061
13062 * infrun.c (stop_all_threads): If debug_infrun, always
13063 trace the wait status after wait_one, using
13064 target_waitstatus_to_string and target_pid_to_str.
13065 (handle_inferior_event): Replace various trace of
13066 wait status kind by a single trace.
13067 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13068 wait status kind image by target_waitstatus_to_string.
13069 * target/waitstatus.c (target_waitstatus_to_string): Fix
13070 obsolete comment.
13071
05caa1d2
TT		 130722019-04-01 Tom Tromey <tromey@adacore.com>
13073
13074 PR symtab/23331:
13075 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13076
9d1447e0
SDJ		 130772019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13078 Pedro Alves <palves@redhat.com>
13079
13080 * top.c (quit_force): Call 'finalize_values'.
13081 * value.c (finalize_values): New function.
13082 * value.h (finalize_values): Declare.
13083
7734102d
EZ		 130842019-03-30 Eli Zaretskii <eliz@gnu.org>
13085
13086 * NEWS: Announce $_gdb_major and $_gdb_minor.
13087
13088 * top.c (init_gdb_version_vars): New function.
13089 (gdb_init): Call init_gdb_version_vars.
13090
188e1fa9
TT		 130912019-03-29 Tom Tromey <tromey@adacore.com>
13092
13093 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13094 help text. Remove dead code.
13095
2880242d
KS		 130962019-03-29 Keith Seitz <keiths@redhat.com>
13097
13098 From Siddhesh Poyarekar:
13099 * f-lang.h (f77_get_upperbound): Return LONGEST.
13100 (f77_get_lowerbound): Likewise.
13101 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13102 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13103 print them.
13104 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13105 plongest to format print it.
13106 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13107 (f77_get_upperbound): Likewise.
13108 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13109 LOWER_BOUND to LONGEST.
13110 (f77_create_arrayprint_offset_tbl): Likewise.
13111
cc1defb1
KS		 131122019-03-29 Keith Seitz <keiths@redhat.com>
13113
13114 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13115 %s/pulongest for TYPE_LENGTH instead of %d in format
13116 strings.
13117 * ada-typerint.c (ada_print_type): Likewise.
13118 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13119 * compile/compile-c-support.c (generate_register_struct): Likewise.
13120 * gdbtypes.c (recursive_dump_type): Likewise.
13121 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13122 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13123 instead of %d in format strings.
13124 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13125 to std::min to ULONGEST.
13126 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13127 instead of %d in format strings.
13128 * tracepoint.c (info_scope_command): Likewise.
13129 * typeprint.c (print_offset_data::update)
13130 (print_offset_data::finish): Likewise.
13131 * xtensa-tdep.c (xtensa_store_return_value)
13132 (xtensa_push_dummy_call): Likewise.
13133
e432ccf1
JT		 131342019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13135
13136 * windows-nat.c (display_selector): Fixed format specifications
13137 for 64-bit Cygwin.
13138
65d2b333
PW		 131392019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13140
13141 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13142
f489207e
SL		 131432019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13144
13145 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13146 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13147 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13148 (nios2_linux_init_abi): Install it.
13149
bffa1015
AH		 131502019-03-28 Alan Hayward <alan.hayward@arm.com>
13151
13152 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13153
fc96163a
AH		 131542019-03-28 Alan Hayward <alan.hayward@arm.com>
13155
13156 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13157
20dc7e9b
PW		 131582019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13159 Tom Tromey <tromey@adacore.com>
13160
13161 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13162
7f5331a8
JB		 131632019-03-26 Joel Brobecker <brobecker@adacore.com>
13164
13165 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13166 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13167 method to compute the bounds of range types. Also print "[evaluated]"
13168 if the bounds' values come from a dynamic evaluation.
13169
18c77628
AB		 131702019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13171
13172 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13173 whitespace when pretty printing is on.
13174
53c973f2
AH		 131752019-03-26 Alan Hayward <alan.hayward@arm.com>
13176
e79be6e5 13177 * ppc-linux-nat.c: Add include.
53c973f2 13178
d851aa71
AH		 131792019-03-26 Alan Hayward <alan.hayward@arm.com>
13180
e79be6e5 13181 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13182
2fe7bab7
AH		 131832019-03-26 Alan Hayward <alan.hayward@arm.com>
13184
e79be6e5 13185 * arm-linux-nat.c: Add include.
2fe7bab7 13186
068ef30e
SM		 131872019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13188
13189 * source-cache.c (source_cache::get_source_lines): Re-read
13190 fullname after calling open_source_file.
13191
81a24d04
JB		 131922019-03-25 John Baldwin <jhb@FreeBSD.org>
13193
13194 * NEWS: Mention TLS support for FreeBSD.
13195
79e7ae11
TT		 131962019-03-25 Tom Tromey <tromey@adacore.com>
13197
13198 * minsyms.c (BUNCH_SIZE): Update comment.
13199 (~minimal_symbol_reader): Remove old comment.
13200 (compact_minimal_symbols): Update comment.
13201 (minimal_symbol_reader::install): Remove old comment. Update
13202 other comments.
13203
d45963c2
AH		 132042019-03-25 Alan Hayward <alan.hayward@arm.com>
13205
13206 * s390-linux-nat.c: Add include.
13207
0f83012e
AH		 132082019-03-25 Alan Hayward <alan.hayward@arm.com>
13209
13210 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13211 Call linux_get_hwcap.
13212 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13213 Likewise.
13214 (aarch64_linux_get_hwcap): Remove function.
13215 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13216 declaration.
13217 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13218 linux_get_hwcap.
13219 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13220 * linux-tdep.c (linux_get_hwcap): Add function.
13221 (linux_get_hwcap2): Likewise.
13222 * linux-tdep.h (linux_get_hwcap): Add declaration.
13223 (linux_get_hwcap2): Likewise.
13224 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13225 (ppc_linux_get_hwcap2): Likewise.
13226 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13227 linux_get_hwcap.
13228 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13229 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13230 (ppc_linux_nat_target::read_description): Likewise.
13231 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13232 * s390-linux-nat.c: Likewise.
13233 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13234
6640a367
TT		 132352019-03-24 Tom Tromey <tom@tromey.com>
13236
13237 * ada-lang.c (standard_lookup): Simplify initialization.
13238 (ada_lookup_symbol_nonlocal): Simplify return.
13239 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13240 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13241 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13242 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13243 initialization.
13244 * solib.c (solib_global_lookup): Simplify.
13245 * symtab.c (null_block_symbol): Remove.
13246 (symbol_cache_lookup): Simplify returns.
13247 (lookup_language_this): Simplify returns.
13248 (lookup_symbol_aux): Simplify return.
13249 (lookup_local_symbol): Simplify returns.
13250 (lookup_global_symbol_from_objfile): Simplify return.
13251 (lookup_symbol_in_objfile_symtabs)
13252 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13253 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13254 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13255 * cp-namespace.c (cp_lookup_bare_symbol)
13256 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13257 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13258 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13259 (cp_lookup_symbol_via_imports): Simplify initialization.
13260 (find_symbol_in_baseclass): Likewise.
13261 * symtab.h (null_block_symbol): Remove.
13262 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13263 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13264 (d_lookup_symbol_module): Likewise.
13265 (find_symbol_in_baseclass): Simplify initialization.
13266
a930ebcd
TT		 132672019-03-24 Tom Tromey <tom@tromey.com>
13268
13269 * expression.h: Don't include symtab.h.
13270 (struct block): Forward declare.
13271
582942f4
TT		 132722019-03-24 Tom Tromey <tom@tromey.com>
13273
13274 * c-exp.y (typebase): Remove casts.
13275 * gdbtypes.c (lookup_unsigned_typename, )
13276 (lookup_signed_typename): Remove cast.
13277 * eval.c (parse_to_comma_and_eval): Remove cast.
13278 * parse.c (write_dollar_variable): Remove cast.
13279 * block.h (struct block) <superblock>: Now const.
13280 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13281 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13282 (map_block): Make "block" const.
13283 * symfile.h (struct quick_symbol_functions)
13284 <map_matching_symbols>: Constify block argument to "callback".
13285 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13286 const.
13287 (find_pc_sect_compunit_symtab): Make "b" const.
13288 (find_symbol_at_address): Likewise.
13289 (search_symbols): Likewise.
13290 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13291 (dw2_debug_names_lookup_symbol): Likewise.
13292 (dw2_map_matching_symbols): Update.
13293 * p-valprint.c (pascal_val_print): Remove "block".
13294 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13295 (aux_add_nonlocal_symbols): Make "block" const.
13296 (resolve_subexp): Remove cast.
13297 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13298 const.
13299 (iterate_over_file_blocks): Likewise.
13300 * f-exp.y (%union) <bval>: Remove.
13301 * coffread.c (patch_opaque_types): Make "b" const.
13302 * spu-tdep.c (spu_catch_start): Make "block" const.
13303 * c-valprint.c (print_unpacked_pointer): Remove "block".
13304 * symmisc.c (dump_symtab_1): Make "b" const.
13305 (block_depth): Make "block" const.
13306 * d-exp.y (%union) <bval>: Remove.
13307 * cp-support.h (cp_lookup_rtti_type): Update.
13308 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13309 * psymtab.c (psym_lookup_symbol): Make "block" const.
13310 (maintenance_check_psymtabs): Make "b" const.
13311 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13312 (enumerate_locals, enumerate_args): Update.
13313 * python/py-symtab.c (stpy_global_block): Make "block" const.
13314 (stpy_static_block): Likewise.
13315 * inline-frame.c (block_starting_point_at): Make "new_block"
13316 const.
13317 * block.c (find_block_in_blockvector): Make return type const.
13318 (blockvector_for_pc_sect): Make "b" const.
13319 (find_block_in_blockvector): Make "b" const.
13320
7ad417dd
TT		 133212019-03-23 Tom Tromey <tom@tromey.com>
13322
13323 * varobj.c (varobj_create): Update.
13324 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13325 * printcmd.c (display_command, do_one_display): Don't reset
13326 innermost_block.
13327 * parser-defs.h (enum innermost_block_tracker_type): Move to
13328 expression.h.
13329 (innermost_block): Update comment.
13330 * parse.c (parse_exp_1): Add tracker_types parameter.
13331 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13332 tracker_types parameter. Reset innermost_block.
13333 (parse_exp_in_context): Remove.
13334 (parse_expression_for_completion): Update.
13335 * objfiles.c (~objfile): Don't reset expression_context_block or
13336 innermost_block.
13337 * expression.h (enum innermost_block_tracker_type): Move from
13338 parser-defs.h.
13339 (parse_exp_1): Add tracker_types parameter.
13340 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13341 reset innermost_block.
13342
b366c208
TT		 133432019-03-23 Tom Tromey <tom@tromey.com>
13344
13345 * objfiles.h: Include bcache.h.
13346
9bb9b2f9
TT		 133472019-03-23 Tom Tromey <tom@tromey.com>
13348
13349 * linespec.c (get_current_search_block): Use
13350 scoped_restore_current_language.
13351 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13352
59c28372
AH		 133532019-03-22 Alan Hayward <alan.hayward@arm.com>
13354 Jiong Wang <jiong.wang@arm.com>
13355
13356 * aarch64-linux-tdep.c
13357 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13358 section.
13359 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13360
17e116a7
AH		 133612019-03-22 Alan Hayward <alan.hayward@arm.com>
13362 Jiong Wang <jiong.wang@arm.com>
13363
13364 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13365 instructions.
13366 (aarch64_analyze_prologue_test): Add PACIASP test.
13367 (aarch64_prologue_prev_register): Unmask PC value.
13368
11e1b75f
AH		 133692019-03-22 Alan Hayward <alan.hayward@arm.com>
13370 Jiong Wang <jiong.wang@arm.com>
13371
13372 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13373 (aarch64_dwarf2_prev_register): Unmask PC value.
13374 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13375 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13376 DW_CFA_AARCH64_negate_ra_state.
13377 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13378
34dcc7cf
AH		 133792019-03-22 Alan Hayward <alan.hayward@arm.com>
13380 Jiong Wang <jiong.wang@arm.com>
13381
13382 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13383 registers.
13384 (aarch64_pseudo_register_name): Likewise.
13385 (aarch64_pseudo_register_type): Likewise.
13386 (aarch64_pseudo_register_reggroup_p): Likewise.
13387 (aarch64_gdbarch_init): Add pauth registers.
13388 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13389 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13390 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13391 (struct gdbarch_tdep): Add regnum for ra_state.
13392
1ef53e6b
AH		 133932019-03-22 Alan Hayward <alan.hayward@arm.com>
13394 Jiong Wang <jiong.wang@arm.com>
13395
13396 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13397
76bed0fd
AH		 133982019-03-22 Alan Hayward <alan.hayward@arm.com>
13399 Jiong Wang <jiong.wang@arm.com>
13400
13401 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13402 function.
13403 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13404 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13405 (aarch64_gdbarch_init): Add puth registers.
13406 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13407 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13408 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13409
ee4fbcfa
AH		 134102019-03-22 Alan Hayward <alan.hayward@arm.com>
13411 Jiong Wang <jiong.wang@arm.com>
13412
13413 * aarch64-linux-nat.c
13414 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13415 * aarch64-linux-tdep.c
13416 (aarch64_linux_core_read_description): Likewise.
13417 (aarch64_linux_get_hwcap): New function.
13418 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13419 (aarch64_linux_get_hwcap): New declaration.
13420
6dc0ebde
AH		 134212019-03-22 Alan Hayward <alan.hayward@arm.com>
13422 Jiong Wang <jiong.wang@arm.com>
13423
13424 * aarch64-linux-nat.c
13425 (aarch64_linux_nat_target::read_description): Add pauth param.
13426 * aarch64-linux-tdep.c
13427 (aarch64_linux_core_read_description): Likewise.
13428 * aarch64-tdep.c (struct target_desc): Add in pauth.
13429 (aarch64_read_description): Add pauth param.
13430 (aarch64_gdbarch_init): Likewise.
13431 * aarch64-tdep.h (aarch64_read_description): Likewise.
13432 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13433 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13434 * features/Makefile: Add new files.
13435 * features/aarch64-pauth.c: New file.
13436 * features/aarch64-pauth.xml: New file.
13437
595915c1
TT		 134382019-03-20 Tom Tromey <tromey@adacore.com>
13439
13440 * infrun.c (handle_inferior_event): Rename from
13441 handle_inferior_event_1. Create a scoped_value_mark.
13442 (handle_inferior_event): Remove.
13443
4c7d57e7
TT		 134442019-03-19 Tom Tromey <tromey@adacore.com>
13445
13446 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13447 * infrun.h (print_stop_event): Add "displays" parameter.
13448 * infrun.c (print_stop_event): Add "displays" parameter.
13449
cb246234
PA		 134502019-03-19 Pedro Alves <palves@redhat.com>
13451
13452 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13453 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13454 to -1. Fix TABs vs spaces.
13455 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13456 * tui/tui-out.h (tui_ui_out) Add intro comments.
13457 <m_line, m_start_of_line>: In-class initialize, and add describing
13458 comment.
13459
3a0e45b2
AH		 134602019-03-18 Alan Hayward <alan.hayward@arm.com>
13461
13462 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13463 variable names.
13464 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13465
5371b850
PA		 134662019-03-18 Pedro Alves <palves@redhat.com>
13467 Eli Zaretskii <eliz@gnu.org>
13468
13469 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13470 m_line and m_start_of_line.
13471
b17c4cd0
EZ		 134722019-03-18 Eli Zaretskii <eliz@gnu.org>
13473
13474 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13475 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13476 it returns a newline. This fixes a regression in TU mode, whereby
13477 the next line is output on the same screen line as the user input.
13478
4bd56d18
TT		 134792019-03-18 Tom Tromey <tromey@adacore.com>
13480
13481 * minsyms.c (minimal_symbol_reader::install): Remove call to
13482 obstack_blank.
13483
55c10aca
PA		 134842019-03-18 Pedro Alves <palves@redhat.com>
13485
13486 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13487 New globals.
13488 (apply_style): New, factored out from ...
13489 (apply_ansi_escape): ... this. Handle reverse video mode.
13490 (tui_set_reverse_mode): New function.
13491 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13492 * tui/tui-winsource.c (tui_show_source_line): Use
13493 tui_set_reverse_mode instead of setting A_STANDOUT.
13494 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13495 New setter methods.
13496
647bb750
HD		 134972019-03-18 Hannes Domani <ssbssa@yahoo.de>
13498
13499 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13500 Handle tabs.
13501
bff8c71f
TT		 135022019-03-18 Tom Tromey <tromey@adacore.com>
13503
13504 * ada-lang.c (empty_array): Add "high" parameter.
13505 (ada_evaluate_subexp): Update.
13506
58785d98
ST		 135072019-03-17 Sergei Trofimovich <siarheit@google.com>
13508
13509 * unittests/string_view-selftests.c: Define
13510 _initialize_string_view_selftests unconditionally.
13511
d4cbef22
ВМ		 135122019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13513
13514 PR gdb/24350
13515 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13516
fce4c071
ВМ		 135172019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13518
13519 PR gdb/24351
13520 * windows-nat.c (display_selector): Fix format specifiers.
13521
f7f0a123
EZ		 135222019-03-17 Eli Zaretskii <eliz@gnu.org>
13523
13524 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13525 tui_refill_source_window instead of tui_refresh_win, to update the
13526 current execution line. This fixes redisplay of the current line
13527 when stepping through the code with "next" or "step".
13528
ab42892f
EZ		 135292019-03-16 Eli Zaretskii <eliz@gnu.org>
13530
13531 * source-cache.c (source_cache::get_source_lines): Call
13532 find_source_lines to initialize s->nlines. This fixes vertical
13533 scrolling of TUI source window when the DOWN arrow is pressed.
13534
8d8c087f
PW		 135352019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13536
13537 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13538 linux-thread-db.c (_initialize_thread_db): Likewise.
13539
798e1c30
EZ		 135402019-03-16 Eli Zaretskii <eliz@gnu.org>
13541
13542 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13543 wclrtoeol in tui_show_source_line". This reverts changes made in
13544 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13545
eefba3da
TT		 135462019-03-15 Tom Tromey <tom@tromey.com>
13547
13548 * symtab.h (struct minimal_symbol): Derive from
13549 general_symbol_info.
13550 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13551 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13552 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13553 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13554 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13555 (MSYMBOL_SEARCH_NAME): Update.
13556 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13557 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13558 * minsyms.c (minimal_symbol_reader::record_full): Update.
13559
0de2420c
TT		 135602019-03-15 Tom Tromey <tom@tromey.com>
13561
13562 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13563
042d75e4
TT		 135642019-03-15 Tom Tromey <tom@tromey.com>
13565
13566 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13567 unique_xmalloc_ptr.
13568 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13569 Update.
13570 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13571 (build_minimal_symbol_hash_tables)
13572 (minimal_symbol_reader::install): Update.
13573
db92718b
TT		 135742019-03-15 Tom Tromey <tom@tromey.com>
13575
13576 * symtab.c (create_demangled_names_hash): Update.
13577 (symbol_set_names): Update.
13578 * objfiles.h (struct objfile_per_bfd_storage)
13579 <demangled_names_hash>: Now an htab_up.
13580 * objfiles.c (objfile_per_bfd_storage): Simplify.
13581
d6797f46
TT		 135822019-03-15 Tom Tromey <tom@tromey.com>
13583
13584 * objfiles.h (struct objfile_per_bfd_storage): Declare
13585 destructor.
13586 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13587 New.
13588 (get_objfile_bfd_data): Use new. Don't initialize
13589 language_of_main.
13590 (free_objfile_per_bfd_storage): Remove.
13591 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13592
741d7538
TT		 135932019-03-15 Tom Tromey <tom@tromey.com>
13594
13595 * symfile.c (reread_symbols): Update.
13596 * objfiles.c (objfile::objfile): Update.
13597 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13598 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13599 comment.
13600 (minimal_symbol_reader::install): Update.
13601 (terminate_minimal_symbol_table): Remove.
13602 * jit.c (jit_object_close_impl): Update.
13603
788c80d1
TT		 136042019-03-15 Tom Tromey <tom@tromey.com>
13605
13606 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13607 initializations.
13608
1b7a07cb
TT		 136092019-03-15 Tom Tromey <tom@tromey.com>
13610
13611 * objfiles.h (struct objfile_per_bfd_storage)
13612 <demangled_hash_languages>: Now a bitset.
13613 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13614 (lookup_minimal_symbol): Update.
13615
3db066bc
TT		 136162019-03-15 Tom Tromey <tom@tromey.com>
13617
13618 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13619 Don't return the symbol.
13620 * coffread.c (record_minimal_symbol): Use record_full.
13621
3fff2c37
EZ		 136222019-03-14 Eli Zaretskii <eliz@gnu.org>
13623
13624 The MS-Windows port of ncurses fails to switch to a color pair if
13625 one or both of the colors are the implicit default colors. This
13626 change records the default colors when TUI is initialized, and
13627 then specifies them explicitly when a color pair uses the default
13628 colors. This allows color styling in TUI mode on MS-Windows.
13629
13630 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13631 ncurses_norm_attr.
13632 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13633 colors in ncurses_norm_attr.
13634 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13635 "none", replace it with the default color recorded in
13636 ncurses_norm_attr.
13637
3b336828
TT		 136382019-03-14 Tom Tromey <tromey@adacore.com>
13639
13640 * source-cache.h (class source_cache) <get_source_lines>: Return
13641 std::string.
13642 * source-cache.c (source_cache::extract_lines): Handle case where
13643 first_pos==npos. Return std::string.
13644 (source_cache::get_source_lines): Update.
13645
d085f989
TT		 136462019-03-14 Tom Tromey <tromey@adacore.com>
13647
13648 * NEWS: Add item for "style sources" commands.
13649 * source-cache.c (source_cache::get_source_lines): Check
13650 source_styling.
13651 * cli/cli-style.c (source_styling): New global.
13652 (_initialize_cli_style): Add "style sources" commands.
13653 (show_style_sources): New function.
13654 * cli/cli-style.h (source_styling): Declare.
13655
6f11e682
TT		 136562019-03-14 Pedro Alves <palves@redhat.com>
13657 Tom Tromey <tromey@adacore.com>
13658
13659 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13660 * tui/tui-winsource.c (tui_refill_source_window): New function,
13661 from...
13662 (tui_horizontal_source_scroll): ... here. Move some logic.
13663 * cli/cli-style.c (set_style_enabled): Notify new observable.
13664 * tui/tui-hooks.c (tui_redisplay_source): New function.
13665 (tui_attach_detach_observers): Attach or detach
13666 tui_redisplay_source.
13667 * observable.h (source_styling_changed): New observable.
13668 * observable.c: Define source_styling_changed observable.
13669
a068643d
TT		 136702019-03-13 Tom Tromey <tromey@adacore.com>
13671
13672 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13673 (i386_gnu_nat_target::store_registers): Update.
13674 * target-debug.h (target_debug_print_std_string): New macro.
13675 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13676 * windows-tdep.c (display_one_tib): Update.
13677 * tui/tui-stack.c (tui_make_status_line): Update.
13678 * top.c (print_inferior_quit_action): Update.
13679 * thread.c (thr_try_catch_cmd): Update.
13680 (add_thread_with_info): Update.
13681 (thread_target_id_str): Update.
13682 (thr_try_catch_cmd): Update.
13683 (thread_command): Update.
13684 (thread_find_command): Update.
13685 * record-btrace.c (record_btrace_target::info_record)
13686 (record_btrace_resume_thread, record_btrace_target::resume)
13687 (record_btrace_cancel_resume, record_btrace_step_thread)
13688 (record_btrace_target::wait, record_btrace_target::wait)
13689 (record_btrace_target::wait, record_btrace_target::stop): Update.
13690 * progspace.c (print_program_space): Update.
13691 * process-stratum-target.c
13692 (process_stratum_target::thread_address_space): Update.
13693 * linux-fork.c (linux_fork_mourn_inferior)
13694 (detach_checkpoint_command, info_checkpoints_command)
13695 (linux_fork_context): Update.
13696 (linux_fork_detach): Update.
13697 (class scoped_switch_fork_info): Update.
13698 (delete_checkpoint_command): Update.
13699 * infrun.c (follow_fork_inferior): Update.
13700 (follow_fork_inferior): Update.
13701 (proceed_after_vfork_done): Update.
13702 (handle_vfork_child_exec_or_exit): Update.
13703 (follow_exec): Update.
13704 (displaced_step_prepare_throw): Update.
13705 (displaced_step_restore): Update.
13706 (start_step_over): Update.
13707 (resume_1): Update.
13708 (clear_proceed_status_thread): Update.
13709 (proceed): Update.
13710 (print_target_wait_results): Update.
13711 (do_target_wait): Update.
13712 (context_switch): Update.
13713 (stop_all_threads): Update.
13714 (restart_threads): Update.
13715 (finish_step_over): Update.
13716 (handle_signal_stop): Update.
13717 (switch_back_to_stepped_thread): Update.
13718 (keep_going_pass_signal): Update.
13719 (print_exited_reason): Update.
13720 (normal_stop): Update.
13721 * inferior.c (inferior_pid_to_str): Change return type.
13722 (print_selected_inferior): Update.
13723 (add_inferior): Update.
13724 (detach_inferior): Update.
13725 * dummy-frame.c (fprint_dummy_frames): Update.
13726 * dcache.c (dcache_info_1): Update.
13727 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13728 (btrace_fetch, btrace_clear): Update.
13729 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13730 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13731 type.
13732 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13733 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13734 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13735 * gdbarch.c, gdbarch.h: Rebuild.
13736 * gdbarch.sh (core_pid_to_str): Change return type.
13737 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13738 return type.
13739 (windows_nat_target::pid_to_str): Change return type.
13740 (windows_delete_thread): Update.
13741 (windows_nat_target::attach): Update.
13742 (windows_nat_target::files_info): Update.
13743 * target-delegates.c: Rebuild.
13744 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13745 return type.
13746 (sol_thread_target::pid_to_str): Change return type.
13747 * remote.c (class remote_target) <pid_to_str>: Change return
13748 type.
13749 (remote_target::pid_to_str): Change return type.
13750 (extended_remote_target::attach, remote_target::remote_stop_ns)
13751 (remote_target::remote_notif_remove_queued_reply)
13752 (remote_target::push_stop_reply, remote_target::disable_btrace):
13753 Update.
13754 (extended_remote_target::attach): Update.
13755 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13756 type.
13757 (gdbsim_target::pid_to_str): Change return type.
13758 * ravenscar-thread.c (struct ravenscar_thread_target)
13759 <pid_to_str>: Change return type.
13760 (ravenscar_thread_target::pid_to_str): Change return type.
13761 * procfs.c (class procfs_target) <pid_to_str>: Change return
13762 type.
13763 (procfs_target::pid_to_str): Change return type.
13764 (procfs_target::attach): Update.
13765 (procfs_target::detach): Update.
13766 (procfs_target::fetch_registers): Update.
13767 (procfs_target::store_registers): Update.
13768 (procfs_target::wait): Update.
13769 (procfs_target::files_info): Update.
13770 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13771 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13772 return type.
13773 (nto_procfs_target::pid_to_str): Change return type.
13774 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13775 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13776 return type.
13777 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13778 (exit_lwp): Update.
13779 (attach_proc_task_lwp_callback, get_detach_signal)
13780 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13781 (linux_nat_target::resume, wait_lwp, stop_callback)
13782 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13783 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13784 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13785 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13786 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13787 type.
13788 (inf_ptrace_target::attach): Update.
13789 (inf_ptrace_target::files_info): Update.
13790 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13791 type.
13792 (go32_nat_target::pid_to_str): Change return type.
13793 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13794 (gnu_nat_target::wait): Update.
13795 (gnu_nat_target::wait): Update.
13796 (gnu_nat_target::resume): Update.
13797 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13798 (fbsd_nat_target::wait): Update.
13799 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13800 type.
13801 (darwin_nat_target::attach): Update.
13802 * corelow.c (class core_target) <pid_to_str>: Change return type.
13803 (core_target::pid_to_str): Change return type.
13804 * target.c (normal_pid_to_str): Change return type.
13805 (default_pid_to_str): Likewise.
13806 (target_pid_to_str): Change return type.
13807 (target_translate_tls_address): Update.
13808 (target_announce_detach): Update.
13809 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13810 return type.
13811 (bsd_uthread_target::pid_to_str): Change return type.
13812 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13813 type.
13814 (bsd_kvm_target::pid_to_str): Change return type.
13815 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13816 return type.
13817 (aix_thread_target::pid_to_str): Change return type.
13818 * target.h (struct target_ops) <pid_to_str>: Change return type.
13819 (target_pid_to_str, normal_pid_to_str): Likewise.
13820 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13821 type.
13822 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13823 type.
13824 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13825 return type.
13826 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13827 type.
13828 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13829 type.
13830 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13831 return type.
13832
b4be1b06
SM		 138332019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13834
13835 * NEWS: Mention that the new default MI version is 3. Mention
13836 changes to the output of commands and events that deal with
13837 multi-location breakpoints.
13838 * breakpoint.c: Include "mi/mi-out.h".
13839 (print_one_breakpoint): Change output syntax if using MI version
13840 >= 3.
13841 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13842 New.
13843 (mi_multi_location_breakpoint_output_fixed): New.
13844 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13845 (mi_cmd_fix_multi_location_breakpoint_output): New.
13846 (mi_multi_location_breakpoint_output_fixed): New.
13847 * mi/mi-cmds.c (mi_cmds): Register command
13848 -fix-multi-location-breakpoint-output.
13849 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13850 interpreter "mi".
13851
8e5e5494
SM		 138522019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13853
13854 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13855 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13856 instantiate mi_ui_out based on interpreter name.
13857 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13858 * mi/mi-main.c (mi_load_progress): Likewise.
13859
197df35e
JB		 138602019-03-12 John Baldwin <jhb@FreeBSD.org>
13861
13862 * NEWS: Combine separate "New targets" sections for 8.3.
13863
8399425f
JB		 138642019-03-12 John Baldwin <jhb@FreeBSD.org>
13865
13866 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13867 (ppcfbsd_init_abi): Install gdbarch
13868 "fetch_tls_load_module_address" and "get_thread_local_address"
13869 methods.
13870
b0f87ed0
JB		 138712019-03-12 John Baldwin <jhb@FreeBSD.org>
13872
13873 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13874 (riscv_fbsd_init_abi): Install gdbarch
13875 "fetch_tls_load_module_address" and "get_thread_local_address"
13876 methods.
13877
ce25aa57
JB		 138782019-03-12 John Baldwin <jhb@FreeBSD.org>
13879
13880 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13881 (i386fbsd_init_abi): Install gdbarch
13882 "fetch_tls_load_module_address" and "get_thread_local_address"
13883 methods.
13884
f5424cfa
JB		 138852019-03-12 John Baldwin <jhb@FreeBSD.org>
13886
13887 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13888 (amd64fbsd_init_abi): Install gdbarch
13889 "fetch_tls_load_module_address" and "get_thread_local_address"
13890 methods.
13891
945f3901
JB		 138922019-03-12 John Baldwin <jhb@FreeBSD.org>
13893
13894 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13895 (struct fbsd_pspace_data): New type.
13896 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13897 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13898 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13899 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13900 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13901
ef0bd204
JB		 139022019-03-12 John Baldwin <jhb@FreeBSD.org>
13903
13904 * gdbtypes.c (lookup_struct_elt): New function.
13905 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13906 * gdbtypes.h (struct struct_elt): New type.
13907 (lookup_struct_elt): New prototype.
13908
36c53a02
JB		 139092019-03-12 John Baldwin <jhb@FreeBSD.org>
13910
13911 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13912 remove disabled code block.
13913
6e056c81
JB		 139142019-03-12 John Baldwin <jhb@FreeBSD.org>
13915
13916 * gdbarch.sh (get_thread_local_address): New method.
13917 * gdbarch.h, gdbarch.c: Regenerate.
13918 * target.c (target_translate_tls_address): Use
13919 gdbarch_get_thread_local_address if present instead of
13920 target::get_thread_local_address.
13921
cd250a18
JB		 139222019-03-12 John Baldwin <jhb@FreeBSD.org>
13923
13924 * target.h (target::get_thread_local_address): Update comment.
13925
df22c1e5
JB		 139262019-03-12 John Baldwin <jhb@FreeBSD.org>
13927
13928 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13929 objfile->separate_debug_objfile_backlink if not NULL.
13930
dd6876c9
JB		 139312019-03-12 John Baldwin <jhb@FreeBSD.org>
13932
13933 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13934 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13935 (amd64bsd_store_inferior_registers): Likewise.
13936 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13937 Enable segment base registers.
13938 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13939 PT_GETFSBASE and PT_GETGSBASE.
13940 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13941 PT_SETGSBASE.
13942 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13943 segment base registers.
13944 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13945
1163a4b7
JB		 139462019-03-12 John Baldwin <jhb@FreeBSD.org>
13947
13948 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13949 Update calls to i386_target_description to add 'segments'
13950 parameter.
13951 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13952 add segment base registers.
13953 * arch/i386.c (i386_create_target_description): Add 'segments'
13954 parameter to enable segment base registers.
13955 * arch/i386.h (i386_create_target_description): Likewise.
13956 * features/i386/32bit-segments.xml: New file.
13957 * features/i386/32bit-segments.c: Generate.
13958 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13959 call to i386_target_description to add 'segments' parameter.
13960 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13961 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13962 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13963 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13964 if feature is present.
13965 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13966 Add 'segments' parameter to call to i386_target_description.
13967 (i386_target_description): Add 'segments' parameter to enable
13968 segment base registers.
13969 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13970 to call to i386_target_description.
13971 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13972 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13973 Define I386_NUM_REGS.
13974 (i386_target_description): Add 'segments' parameter to enable
13975 segment base registers.
13976
3a350822
EZ		 139772019-03-12 Eli Zaretskii <eliz@gnu.org>
13978
13979 PR/24325
13980 * source-cache.c: #undef open and close, to avoid unresolved
13981 externals during linking.
13982
ffdd69cf
TT		 139832019-03-12 Tom Tromey <tromey@adacore.com>
13984
13985 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13986 const. Add initializers.
13987 (_initialize_remote): Don't initialize ptid globals.
13988
ec148c57
PA		 139892019-03-12 Pedro Alves <palves@redhat.com>
13990
13991 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13992
32764270
PA		 139932019-03-12 Pedro Alves <palves@redhat.com>
13994
13995 * cp-name-parser.y (main): Remove unused 'len' variable.
13996
17547186
TT		 139972019-03-12 Tom Tromey <tromey@adacore.com>
13998
13999 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14000 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14001
d3a70e03
TT		 140022019-03-12 Tom Tromey <tromey@adacore.com>
14003
14004 * linux-nat.c (iterate_over_lwps): Update.
14005 (stop_callback): Remove parameter.
14006 (stop_wait_callback, detach_callback, resume_set_callback)
14007 (select_singlestep_lwp_callback, set_ignore_sigint)
14008 (status_callback, resumed_callback, resume_clear_callback)
14009 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14010 data parameter.
14011 (linux_nat_target::detach, linux_nat_target::resume)
14012 (linux_stop_and_wait_all_lwps, select_event_lwp)
14013 (linux_nat_filter_event, linux_nat_wait_1)
14014 (linux_nat_target::kill, linux_nat_target::stop)
14015 (linux_nat_target::stop): Update.
14016 (linux_nat_resume_callback): Change type.
14017 (resume_stopped_resumed_lwps, count_events_callback)
14018 (select_event_lwp_callback): Likewise.
14019 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14020 * arm-linux-nat.c (struct update_registers_data): Remove.
14021 (update_registers_callback): Change type.
14022 (arm_linux_insert_hw_breakpoint1): Update.
14023 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14024 parameter.
14025 (x86_linux_dr_set_addr): Update.
14026 (x86_linux_dr_set_control): Update.
14027 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14028 (iterate_over_lwps): Use gdb::function_view.
14029 * nat/aarch64-linux-hw-point.c (struct
14030 aarch64_dr_update_callback_param): Remove.
14031 (debug_reg_change_callback): Change type.
14032 (aarch64_notify_debug_reg_change): Update.
14033 * s390-linux-nat.c (s390_refresh_per_info): Update.
14034
82cb27ff
TT		 140352019-03-11 Tom Tromey <tromey@adacore.com>
14036
14037 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14038 redundant assignment to "this_cu".
14039
568c0683
SM		 140402019-03-08 Simon Marchi <simon.marchi@efficios.com>
14041
14042 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14043
f09ce22d
SM		 140442019-03-08 Simon Marchi <simon.marchi@efficios.com>
14045
14046 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14047 from...
14048 (rank_one_type): ... this.
14049
595f96a9
SM		 140502019-03-08 Simon Marchi <simon.marchi@efficios.com>
14051
14052 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14053 from...
14054 (rank_one_type): ... this.
14055
2598a94b
SM		 140562019-03-08 Simon Marchi <simon.marchi@efficios.com>
14057
14058 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14059 from...
14060 (rank_one_type): ... this.
14061
7f17b20d
SM		 140622019-03-08 Simon Marchi <simon.marchi@efficios.com>
14063
14064 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14065 from...
14066 (rank_one_type): ... this.
14067
2c509035
SM		 140682019-03-08 Simon Marchi <simon.marchi@efficios.com>
14069
14070 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14071 from...
14072 (rank_one_type): ... this.
14073
0dd322dc
SM		 140742019-03-08 Simon Marchi <simon.marchi@efficios.com>
14075
14076 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14077 from...
14078 (rank_one_type): ... this.
14079
41ea4728
SM		 140802019-03-08 Simon Marchi <simon.marchi@efficios.com>
14081
14082 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14083 from...
14084 (rank_one_type): ... this.
14085
793cd1d2
SM		 140862019-03-08 Simon Marchi <simon.marchi@efficios.com>
14087
14088 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14089 from...
14090 (rank_one_type): ... this.
14091
34910087
SM		 140922019-03-08 Simon Marchi <simon.marchi@efficios.com>
14093
14094 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14095 from...
14096 (rank_one_type): ... this.
14097
f1f832d6
SM		 140982019-03-08 Simon Marchi <simon.marchi@efficios.com>
14099
14100 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14101 from...
14102 (rank_one_type): ... this.
14103
b9f4512f
SM		 141042019-03-08 Simon Marchi <simon.marchi@efficios.com>
14105
14106 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14107 from...
14108 (rank_one_type): ... this.
14109
9293fc63
SM		 141102019-03-08 Simon Marchi <simon.marchi@efficios.com>
14111
14112 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14113 from...
14114 (rank_one_type): ... this.
14115
e3abbe7e
PW		 141162019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14117
14118 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14119 inferior-events' shows the example events.
14120
e4adb939
EZ		 141212019-03-08 Eli Zaretskii <eliz@gnu.org>
14122
14123 Support styling on native MS-Windows console
14124
14125 PR/24315
14126 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14127 on MS-Windows if $TERM is not defined.
14128
14129 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14130
14131 * posix-hdep.c (gdb_console_fputs):
14132 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14133 functions.
14134 * ui-file.h (gdb_console_fputs): Add prototype.
14135
14136 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14137 back to fputs only if the former returns zero.
14138
25629dfd
TT		 141392019-03-07 Tom Tromey <tom@tromey.com>
14140
14141 * symmisc.c (print_symbol_bcache_statistics): Update.
14142 (print_objfile_statistics): Update.
14143 * symfile.c (allocate_symtab): Update.
14144 * stabsread.c: Don't include bcache.h.
14145 * psymtab.h (struct psymbol_bcache): Don't declare.
14146 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14147 (psymbol_bcache_init, psymbol_bcache_free)
14148 (psymbol_bcache_get_bcache): Don't declare.
14149 * psymtab.c (struct psymbol_bcache): Remove.
14150 (psymtab_storage::psymtab_storage): Update.
14151 (psymtab_storage::~psymtab_storage): Update.
14152 (psymbol_bcache_init, psymbol_bcache_free)
14153 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14154 (add_psymbol_to_bcache): Update.
14155 (allocate_psymtab): Update.
14156 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14157 macro_cache>: No longer pointers.
14158 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14159 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14160 * macrotab.c (macro_bcache): Update.
14161 * macroexp.c: Don't include bcache.h.
14162 * gdbtypes.c (check_types_worklist): Update.
14163 (types_deeply_equal): Remove TRY/CATCH. Update.
14164 * elfread.c (elf_symtab_read): Update.
14165 * dwarf2read.c: Don't include bcache.h.
14166 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14167 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14168 (print_bcache_statistics, bcache_memory_used): Don't declare.
14169 (struct bcache): Move from bcache.c. Add constructor, destructor,
14170 methods. Rename all data members.
14171 * bcache.c (struct bcache): Move to bcache.h.
14172 (bcache::expand_hash_table): Rename from expand_hash_table.
14173 (bcache): Remove.
14174 (bcache::insert): Rename from bcache_full.
14175 (bcache::compare): Rename from bcache_compare.
14176 (bcache_xmalloc): Remove.
14177 (bcache::~bcache): Rename from bcache_xfree.
14178 (bcache::print_statistics): Rename from print_bcache_statistics.
14179 (bcache::memory_used): Rename from bcache_memory_used.
14180
fe726667
PA		 141812019-03-07 Pedro Alves <palves@redhat.com>
14182
14183 * infrun.c (normal_stop): Also check for
14184 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14185
7584bb30
AB		 141862019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14187
14188 * f-lang.c (value_from_host_double): Moved to...
14189 * value.c (value_from_host_double): ...here.
14190 * value.h (value_from_host_double): Declare.
14191 * guile/scm-math.c (vlscm_convert_typed_number): Use
14192 value_from_host_double.
14193 (vlscm_convert_number): Likewise.
14194 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14195 * python/py-value.c (convert_value_from_python): Likewise.
14196
a7b1986e
TT		 141972019-03-06 Tom Tromey <tom@tromey.com>
14198
14199 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14200
0ccf4211
TT		 142012019-03-06 Tom Tromey <tom@tromey.com>
14202
14203 * utils.h (free_current_contents): Don't declare.
14204 * utils.c (free_current_contents): Remove.
14205
fe7b42e5
TT		 142062019-03-06 Tom Tromey <tom@tromey.com>
14207
14208 * top.c (quit_force): Update.
14209 * main.c (captured_command_loop): Update.
14210 * common/new-op.c (operator new): Update.
14211 * common/common-exceptions.c (struct catcher)
14212 <save_cleanup_chain>: Remove member.
14213 (exceptions_state_mc_init): Update.
14214 (exception_try_scope_entry): Return nullptr.
14215 (exception_try_scope_exit, exception_rethrow)
14216 (throw_exception_sjlj, throw_exception_cxx): Update.
14217 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14218 (all_cleanups, do_cleanups, discard_cleanups)
14219 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14220 (restore_cleanups, restore_final_cleanups): Don't declare.
14221 (do_final_cleanups): Remove parameter.
14222 * common/cleanups.c (cleanup_chain, make_cleanup)
14223 (make_cleanup_dtor, all_cleanups, do_cleanups)
14224 (discard_my_cleanups, discard_cleanups)
14225 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14226 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14227 (null_cleanup): Remove.
14228 (do_final_cleanups): Remove parameter.
14229
c6321f19
TT		 142302019-03-06 Tom Tromey <tom@tromey.com>
14231
14232 * remote.c (remote_target::remote_parse_stop_reply): Use
14233 unique_xmalloc_ptr.
14234
61b30099
TT		 142352019-03-06 Tom Tromey <tom@tromey.com>
14236
14237 * stabsread.c (struct stabs_field_info): Rename from field_info.
14238 <list, fnlist>: Add initializers.
14239 <obstack>: New member.
14240 (read_member_functions, read_struct_fields, read_baseclasses):
14241 Allocate on obstack. Don't use cleanups.
14242 (read_one_struct_field, read_member_functions, read_struct_fields)
14243 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14244 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14245 (read_struct_type): Update.
14246
6cceac94
TT		 142472019-03-06 Tom Tromey <tom@tromey.com>
14248
14249 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14250 * common/filestuff.h (make_cleanup_close): Don't declare.
14251 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14252 Remove.
14253
72412762
TT		 142542019-03-06 Tom Tromey <tom@tromey.com>
14255
14256 * solib-aix.c: Use make_scope_exit.
14257
2b6ff1c0
TT		 142582019-03-06 Tom Tromey <tom@tromey.com>
14259
14260 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14261 Use make_scope_exit.
14262
d01c5877
TT		 142632019-03-06 Tom Tromey <tom@tromey.com>
14264
14265 * solib-svr4.c (disable_probes_interface): Remove parameter.
14266 (svr4_handle_solib_event): Use make_scope_exit.
14267
32603266
TT		 142682019-03-06 Tom Tromey <tom@tromey.com>
14269
14270 * remote.c (struct stop_reply_deleter): Remove.
14271 (stop_reply_up): Update.
14272 (struct stop_reply): Derive from notif_event. Don't typedef.
14273 <regcache>: Now a std::vector.
14274 (stop_reply_xfree): Remove.
14275 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14276 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14277 (remote_target::discard_pending_stop_replies): Use delete.
14278 (remote_target::remote_parse_stop_reply): Update.
14279 (remote_target::process_stop_reply): Update.
14280 * remote-notif.h (struct notif_event): Add virtual destructor.
14281 Remove "dtr" member.
14282 (struct notif_client) <alloc_event>: Return a unique_ptr.
14283 (notif_event_xfree): Don't declare.
14284 (notif_event_up): New typedef.
14285 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14286 (notif_event_xfree, do_notif_event_xfree): Remove.
14287 (remote_notif_state_xfree): Update.
14288
9799571e
TT		 142892019-03-06 Tom Tromey <tom@tromey.com>
14290
14291 * infrun.c (displaced_step_clear_cleanup): Now a
14292 forward_scope_exit type.
14293 (displaced_step_prepare_throw): Update.
14294 (displaced_step_fixup): Update.
14295
09e3c4ca
TT		 142962019-03-06 Tom Tromey <tom@tromey.com>
14297
14298 * inferior.h (class inferior): Update comment.
14299 * gdbthread.h (class thread_info): Update comment.
14300
e2a03548
TT		 143012019-03-06 Joel Brobecker <brobecker@adacore.com>
14302 Tom Tromey <tom@tromey.com>
14303
14304 * stabsread.h (struct stab_section_list): Remove.
14305 (coffstab_build_psymtabs): Update.
14306 * dbxread.c (symbuf_sections): Now a std::vector.
14307 (sect_idx): New global.
14308 (fill_symbuf): Update.
14309 (coffstab_build_psymtabs): Change type of stabsects parameter.
14310 Update.
14311 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14312 std::vector.
14313 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14314 (coff_locate_sections): Update.
14315 (coff_symfile_read): Remove cleanups. Update.
14316 (init_stringtab): Add storage parameter.
14317 (free_stringtab, free_stringtab_cleanup): Remove.
14318 (init_lineno): Add storage parameter.
14319 (free_linetab, free_linetab_cleanup): Remove.
14320
b7e60d85
PA		 143212019-03-06 Pedro Alves <palves@redhat.com>
14322
14323 * linux-fork.c (fork_info::clobber_regs): Delete.
14324 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14325 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14326 comment. Adjust.
14327 (scoped_switch_fork_info::scoped_switch_fork_info)
14328 (checkpoint_command, linux_fork_context): Adjust
14329 fork_save_infrun_state calls.
14330
e52c971f
PA		 143312019-03-06 Pedro Alves <palves@redhat.com>
14332
14333 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14334 (inf_has_multiple_threads): Return 'bool' and rewrite using
14335 inferior_info::threads().
14336
06974e6c
PA		 143372019-03-06 Pedro Alves <palves@redhat.com>
14338
14339 * linux-fork.c: Include <list>.
14340 (fork_list): Now a std::list instance.
14341 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14342 (forks_exist_p, find_last_fork): Adjust.
14343 (new_fork): Delete.
14344 (one_fork_p): New.
14345 (add_fork): Adjust.
14346 (free_fork): Delete, folded into fork_info::~fork_info().
14347 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14348 Adjust.
14349 (init_fork_list): Delete.
14350 (linux_fork_killall, linux_fork_mourn_inferior)
14351 (linux_fork_detach, info_checkpoints_command): Adjust.
14352 (_initialize_linux_fork): No longer call init_fork_list.
14353
72f31aea
PA		 143542019-03-06 Pedro Alves <palves@redhat.com>
14355
14356 * linux-fork.c (new_fork): New, split out of ...
14357 (add_fork): ... this. Return void. Move "first fork" special
14358 case from here, to ...
14359 (checkpoint_command): ... here.
14360 * linux-linux.h (add_fork): Return void.
14361
efbecbc1
AB		 143622019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14363
14364 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14365
0841c79a
AB		 143662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14367 Chris January <chris.january@arm.com>
14368 David Lecomber <david.lecomber@arm.com>
14369
14370 * f-exp.y: New token, UNOP_INTRINSIC.
14371 (exp): New pattern using UNOP_INTRINSIC token.
14372 (f77_keywords): Add 'abs' keyword.
14373 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14374 (value_from_host_double): New function.
14375 (evaluate_subexp_f): Support UNOP_ABS.
14376
4a270568
AB		 143772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14378
14379 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14380 types.
14381
067630bd
AB		 143822019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14383
14384 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14385 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14386 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14387
3be47f7a
AB		 143882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14389
14390 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14391
4d00f5d8
AB		 143922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14393 Chris January <chris.january@arm.com>
14394
14395 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14396 * f-exp.y: Define 'KIND' token.
14397 (exp): New pattern for KIND expressions.
14398 (ptype): Handle types with a kind extension.
14399 (direct_abs_decl): Extend to spot kind extensions.
14400 (f77_keywords): Add 'kind' to the list.
14401 (push_kind_type): New function.
14402 (convert_to_kind_type): New function.
14403 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14404 * parse.c (operator_length_standard): Likewise.
14405 * parser-defs.h (enum type_pieces): Add tp_kind.
14406 * std-operator.def: Add UNOP_KIND.
14407
e454224f
AB		 144082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14409
14410 * f-exp.y (f_parse): Set yydebug.
14411
9dad4a58
AB		 144122019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14413
14414 * f-lang.c (evaluate_subexp_f): New function.
14415 (exp_descriptor_f): New global.
14416 (f_language_defn): Use exp_descriptor_f instead of
14417 exp_descriptor_standard.
14418
c8f91604
AB		 144192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14420
14421 * f-exp.y (struct token): Add comments.
14422 (dot_ops): Remove uppercase versions and the end marker.
14423 (f77_keywords): Likewise.
14424 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14425 entries in the dot_ops array are case insensitive, and use
14426 strncasecmp to compare strings. Also some whitespace cleanup in
14427 this area. Similar for the f77_keywords array, except entries in
14428 this list might be case sensitive.
14429
dd9f2c76
AB		 144302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14431
14432 * f-exp.y (struct f77_boolean_val): Add comments.
14433 (boolean_values): Remove uppercase versions, and end marker.
14434 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14435 and use strncasecmp to achieve case insensitivity. Additionally,
14436 perform whitespace cleanup around this code.
14437
67a3048c
TT		 144382019-03-06 Tom Tromey <tromey@adacore.com>
14439
14440 * remote-sim.c (gdbsim_target_open): Use result of
14441 gdb_argv::release.
14442
aa3cfbda
RB		 144432019-03-06 Richard Bunt <richard.bunt@arm.com>
14444 Dirk Schubert <dirk.schubert@arm.com>
14445 Chris January <chris.january@arm.com>
14446
14447 * eval.c (evaluate_subexp_standard): Call Fortran argument
14448 wrapping logic.
14449 * f-lang.c (struct value): A value which can be passed into a
14450 Fortran function call.
14451 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14452 where appropriate.
14453 (struct type): Value ready for a Fortran function call.
14454 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14455 is needed.
14456 * f-lang.h (fortran_argument_convert): Declaration.
14457 (fortran_preserve_arg_pointer): Declaration.
14458 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14459
ea38e5df
TT		 144602019-03-05 Tom Tromey <tromey@adacore.com>
14461
14462 * python/py-prettyprint.c (print_string_repr): Remove #if.
14463 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14464
06b5b831
TT		 144652019-03-05 Tom Tromey <tromey@adacore.com>
14466
14467 * target.c (the_dummy_target): Move later. Change type to
14468 "dummy_target".
14469 (initialize_targets): Don't initialize the_dummy_target.
14470
edbd9e45
TT		 144712019-03-05 Tom Tromey <tromey@adacore.com>
14472
14473 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14474 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14475
c119e040
TT		 144762019-03-05 Tom Tromey <tromey@adacore.com>
14477
14478 * windows-nat.c (windows_nat_target::attach)
14479 (windows_nat_target::detach): Don't call gdb_flush.
14480 * valprint.c (generic_val_print, val_print, val_print_string):
14481 Don't call gdb_flush.
14482 * utils.c (defaulted_query): Don't call gdb_flush.
14483 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14484 * target.c (target_announce_detach): Don't call gdb_flush.
14485 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14486 * remote.c (extended_remote_target::attach): Don't call
14487 gdb_flush.
14488 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14489 * printcmd.c (do_examine): Don't call gdb_flush.
14490 (info_display_command): Don't call gdb_flush.
14491 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14492 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14493 * memattr.c (info_mem_command): Don't call gdb_flush.
14494 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14495 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14496 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14497 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14498 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14499 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14500 (gnu_nat_target::detach): Don't call gdb_flush.
14501 * f-valprint.c (f_val_print): Don't call gdb_flush.
14502 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14503 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14504 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14505 gdb_flush.
14506 * c-valprint.c (c_val_print): Don't call gdb_flush.
14507 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14508
895dafa6
TT		 145092019-03-05 Tom Tromey <tromey@adacore.com>
14510
14511 * varobj.c (update_dynamic_varobj_children): Update.
14512 (install_default_visualizer): Use reset, not release.
14513 * value.c (set_internalvar): Update.
14514 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14515 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14516 ATTRIBUTE_UNUSED_RESULT.
14517
88a774b9
TT		 145182019-03-05 Tom Tromey <tromey@adacore.com>
14519
14520 * remote.c (class scoped_remote_fd) <release>: Add
14521 ATTRIBUTE_UNUSED_RESULT.
14522
4e4a8b93
TT		 145232019-03-05 Tom Tromey <tromey@adacore.com>
14524
14525 * macroexp.c (struct macro_buffer) <release>: Add
14526 ATTRIBUTE_UNUSED_RESULT.
14527
083eef1f
TT		 145282019-03-05 Tom Tromey <tromey@adacore.com>
14529
14530 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14531 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14532 ATTRIBUTE_UNUSED_RESULT.
14533
3cabd438
TT		 145342019-03-05 Tom Tromey <tromey@adacore.com>
14535
14536 * common/scoped_fd.h (class scoped_fd) <release>: Add
14537 ATTRIBUTE_UNUSED_RESULT.
14538
41e3300a
TT		 145392019-03-05 Tom Tromey <tromey@adacore.com>
14540
14541 * parser-defs.h (struct parser_state) <release>: Add
14542 ATTRIBUTE_UNUSED_RESULT.
14543
18cb7c9f
TT		 145442019-03-05 Tom Tromey <tromey@adacore.com>
14545
14546 * utils.h (class gdb_argv) <release>: Add
14547 ATTRIBUTE_UNUSED_RESULT.
14548 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14549
41fa577f
EZ		 145502019-03-02 Eli Zaretskii <eliz@gnu.org>
14551
a6a4b2c6
EZ		 14552 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14553 for-loop range, to avoid compiler warnings.
14554
14555 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14556 avoid compiler warnings about unused variables.
14557
742a7df5
EZ		 14558 * NEWS: Mention end of support for native debugging on MS-Windows
14559 before XP.
14560
41fa577f
EZ		 14561 PR gdb/24292
14562 * common/netstuff.c:
14563 * gdbserver/gdbreplay.c
14564 * gdbserver/remote-utils.c:
14565 * ser-tcp.c:
14566 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14567 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14568 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14569 'getaddrinfo' and 'freeaddrinfo' were not available before
14570 Windows XP, and mingw.org's MinGW headers by default define
14571 _WIN32_WINNT to 0x500.
14572
827f438f
GB		 145732019-03-01 Gary Benson <gbenson@redhat.com>
14574
14575 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14576
92137da0
RO		 145772019-02-28 Brian Vandenberg <phantall@gmail.com>
14578 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14579
14580 PR gdb/8527
14581 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14582 set_sigint_trap, clear_sigint_trap.
14583
799efbe8
PW		 145842019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14585
14586 * target.c (target_detach): Clear the regcache and the
14587 frame cache.
14588
8ed25214
PA		 145892019-02-27 Pedro Alves <palves@redhat.com>
14590
14591 * utils.c (set_screen_size): When we cap the height/width sizes,
14592 tweak the corresponding command variable to show "unlimited":
14593
23031e31
SJ		 145942019-02-27 Saagar Jha <saagar@saagarjha.com>
14595 Pedro Alves <palves@redhat.com>
14596
14597 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14598 before calling rl_set_screen_size.
14599
6c28e44a
TT		 146002019-02-27 Tom Tromey <tromey@adacore.com>
14601
14602 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14603 define.
14604 * python/py-value.c: Remove Python 2.4 workaround.
14605 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14606 workaround.
14607 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14608 Python 2.4 workaround.
14609 * python/python-internal.h: Remove Python 2.4 comment.
14610 (Py_ssize_t): Don't define.
14611 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14612 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14613 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14614 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14615 * python/python.c (do_start_initialization): Remove Python 2.4
14616 workaround.
14617 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14618 (print_children): Remove Python 2.4 workaround.
14619 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14620 workaround.
14621 (CHARBUFFERPROC_NAME): Remove.
14622 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14623 Python 2.4 workaround.
14624
2c3fc25d 146252019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14626
2c3fc25d
KB		 14627 * NEWS: Note minimum Python version.
14628
6ca62222
KB		 146292019-02-27 Kevin Buettner <kevinb@redhat.com>
14630
14631 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14632 code from these functions. Remove corresponding ifdefs. Use
14633 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14634 Remove gotos and target of gotos.
14635 (infpy_search_memory): Likewise.
14636
f4bc7d2c
AB		 146372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14638
14639 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14640 (hppa_gdbarch_init): Don't register deleted functions with
14641 gdbarch.
14642
9734a586
AB		 146432019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14644
14645 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14646 (h8300_unwind_sp): Delete.
14647 (h8300_dummy_id): Delete.
14648 (h8300_gdbarch_init): Don't register deleted functions with
14649 gdbarch.
14650
68b867f3
AB		 146512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14652
14653 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14654 (ft32_unwind_pc): Delete.
14655 (ft32_unwind_sp): Delete.
14656 (ft32_gdbarch_init): Don't register deleted functions with
14657 gdbarch.
14658
2fbe7ad0
AB		 146592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14660
14661 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14662 (frv_unwind_pc): Delete.
14663 (frv_unwind_sp): Delete.
14664 (frv_gdbarch_init): Don't register deleted functions with
14665 gdbarch.
14666
76055cbe
AB		 146672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14668
14669 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14670 (riscv_unwind_pc): Delete.
14671 (riscv_unwind_sp): Delete.
14672 (riscv_gdbarch_init): Don't register deleted functions with
14673 gdbarch.
14674
4133e5a1
AB		 146752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14676
14677 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14678 (csky_unwind_pc): Delete.
14679 (csky_unwind_sp): Delete.
14680 (csky_gdbarch_init): Don't register deleted functions with
14681 gdbarch.
14682
8010f576
AB		 146832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14684
14685 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14686 (cris_unwind_pc): Delete.
14687 (cris_unwind_sp): Delete.
14688 (cris_gdbarch_init): Don't register deleted functions with
14689 gdbarch.
14690
b56bf084
AB		 146912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14692
14693 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14694 (bfin_unwind_pc): Delete.
14695 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14696
a19a650f
AB		 146972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14698
14699 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14700 (arm_unwind_pc): Delete.
14701 (arm_unwind_sp): Delete.
14702 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14703
f8278c3c
AB		 147042019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14705
14706 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14707 (arc_unwind_pc): Delete.
14708 (arc_unwind_sp): Delete.
14709 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14710
480e46cf
AB		 147112019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14712
14713 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14714 (alpha_unwind_pc): Delete.
14715 (alpha_gdbarch_init): Don't register deleted functions with
14716 gdbarch.
14717
7a995095
AB		 147182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14719
14720 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14721 (aarch64_unwind_pc): Delete.
14722 (aarch64_unwind_sp): Delete.
14723 (aarch64_gdbarch_init): Don't register deleted functions with
14724 gdbarch.
14725
bf9a735e
AB		 147262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14727
14728 * gdbtypes.c (type_align): Don't consider static members when
14729 computing structure alignment.
14730
5561fc30
AB		 147312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14732
14733 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14734 return 0 for other types.
14735 * arch-utils.c (default_type_align): Always return 0.
14736 * gdbarch.h: Regenerate.
14737 * gdbarch.sh (type_align): Extend comment.
14738 * gdbtypes.c (type_align): Add additional comments, always call
14739 gdbarch_type_align before applying the default rules.
14740 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14741 generic code will then apply a suitable default.
14742 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14743 types, return 0 for other types.
14744
9335e75a
JB		 147452019-02-27 Joel Brobecker <brobecker@adacore.com>
14746
14747 * NEWS: Create a new section for the next release branch.
14748 Rename the section of the current branch, now that it has
14749 been cut.
14750
3d34d8de
JB		 147512019-02-27 Joel Brobecker <brobecker@adacore.com>
14752
14753 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14754 * version.in: Bump version to 8.3.50.DATE-git.
14755
143420fb
SM		 147562019-02-26 Simon Marchi <simon.marchi@efficios.com>
14757
14758 * aix-thread.c (ptid_cmp): Remove unused variable.
14759 (get_signaled_thread): Likewise.
14760 (store_regs_user_thread): Likewise.
14761 (store_regs_kernel_thread): Likewise.
14762 (fetch_regs_kernel_thread): Remove shadowed variable.
14763
172fb711
AB		 147642019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14765
14766 * features/riscv/32bit-cpu.xml: Add register numbers.
14767 * features/riscv/32bit-fpu.c: Regenerate.
14768 * features/riscv/32bit-fpu.xml: Add register numbers.
14769 * features/riscv/64bit-cpu.xml: Add register numbers.
14770 * features/riscv/64bit-fpu.c: Regenerate.
14771 * features/riscv/64bit-fpu.xml: Add register numbers.
14772
26c89782
KB		 147732019-02-26 Kevin Buettner <kevinb@redhat.com>
14774
af54ade9 14775 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14776 * python/py-value.c (convert_buffer_and_type_to_value): New
14777 function.
14778 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14779 Add support for handling an optional second argument. Call
14780 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14781 * python/python-internal.h (Py_buffer_deleter): New struct.
14782 (Py_buffer_up): New typedef.
14783
0f58c9e8
JB		 147842019-02-25 John Baldwin <jhb@FreeBSD.org>
14785
14786 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14787 instead of releasing ownership.
14788
0a0f4c01
JR		 147892019-02-25 Jordan Rupprecht <rupprecht@google.com>
14790
14791 * dwarf2read.c (open_and_init_dwp_file): Call
14792 elf_numsections instead of bfd_count_sections to initialize
14793 dwp_file->num_sections.
14794
cd5a152c
TT		 147952019-02-25 Tom Tromey <tromey@adacore.com>
14796
14797 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14798
8a6a8513
SDJ		 147992019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14800
14801 * gcore.in: Add '--readnever' option when invoking GDB.
14802
04dcda9c
SM		 148032019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14804
14805 * MAINTAINERS: Update my email address.
14806
07bc701d
SM		 148072019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14808
14809 * build-id.c (build_id_to_debug_bfd_1): New function.
14810 (build_id_to_debug_bfd): Look for separate debug file in
14811 sysroot.
14812
c6f4a5d0
AB		 148132019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14814
14815 * gdbarch.sh: Update the copyright year range that is placed into
14816 generated files.
14817
9600246d
KS		 148182019-02-22 Keith Seitz <keiths@redhat.com>
14819
14820 PR symtab/23853
14821 * linespec.c (create_sals_line_offset): Search for the default
14822 symtab's filename instead of its fullname.
14823
7557a514
AH		 148242019-02-21 Alan Hayward <alan.hayward@arm.com>
14825
14826 * NEWS: Update style defaults.
14827
ee2bcb0c
AH		 148282019-02-21 Alan Hayward <alan.hayward@arm.com>
14829
14830 * main.c (captured_main_1): Disable styling in batch mode.
14831
0c95f9ed
TT		 148322019-02-20 Tom Tromey <tom@tromey.com>
14833
14834 * symtab.c (symtab_symbol_info): Fix typos.
14835
c763b894
TT		 148362019-02-20 Tom Tromey <tromey@adacore.com>
14837
14838 * findcmd.c (_initialize_mem_search): Use upper case for
14839 metasyntactic variables.
14840
0ef8a082
AH		 148412019-02-20 Alan Hayward <alan.hayward@arm.com>
14842
14843 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14844 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14845
6caa91b6
SM		 148462019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14847
14848 * top.h (source_file_name): Change to std::string.
14849 * top.c (source_file_name): Likewise.
14850 (command_line_input): Adjust.
14851 * cli/cli-script.c (script_from_file): Adjust.
14852
98814c6c
TT		 148532019-02-19 Tom Tromey <tromey@adacore.com>
14854
14855 * ravenscar-thread.c
14856 (ravenscar_thread_target::update_thread_list): Don't call
14857 ada_build_task_list.
14858 * ada-lang.h (ada_build_task_list): Don't declare.
14859 * ada-tasks.c (struct ada_tasks_inferior_data)
14860 <task_list_valid_p>: Now bool.
14861 (read_known_tasks, ada_task_list_changed)
14862 (ada_tasks_invalidate_inferior_data): Update.
14863 (read_known_tasks_array): Return bool.
14864 (read_known_tasks_list): Likewise.
14865 (read_known_tasks): Return void.
14866 (ada_build_task_list): Now static.
14867
70cd633e
AB		 148682019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14869
14870 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14871 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14872
040b3e95
PW		 148732019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14874
14875 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14876 variant for ada_tasks_pspace_data_handle and
14877 ada_tasks_inferior_data_handle.
14878 (ada_tasks_pspace_data_cleanup): New function.
14879 (ada_tasks_inferior_data_cleanup): New function.
14880
9409233b
TT		 148812019-02-17 Tom Tromey <tom@tromey.com>
14882
14883 * macrotab.h (macro_source_fullname): Return a std::string.
14884 * macrotab.c (macro_include, check_for_redefinition)
14885 (macro_undef, macro_lookup_definition, foreach_macro)
14886 (foreach_macro_in_scope): Update.
14887 (macro_source_fullname): Return a std::string.
14888 * macrocmd.c (show_pp_source_pos): Update.
14889
6506371f
TT		 148902019-02-17 Tom Tromey <tom@tromey.com>
14891
14892 * macrocmd.c (show_pp_source_pos): Style the file names.
14893
0c820d67
TT		 148942019-02-17 Tom Tromey <tom@tromey.com>
14895
14896 PR tui/24197:
14897 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14898
a0087920
TT		 148992019-02-17 Tom Tromey <tom@tromey.com>
14900
14901 * ada-lang.c (user_select_syms): Use filtered printing.
14902 * utils.c (wrap_style): New global.
14903 (desired_style): Remove.
14904 (emit_style_escape): Add stream parameter.
14905 (set_output_style, reset_terminal_style, prompt_for_continue):
14906 Update.
14907 (flush_wrap_buffer): Only flush gdb_stdout.
14908 (wrap_here): Set wrap_style.
14909 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14910 treat escape sequences as a character. Change when wrap buffer is
14911 flushed.
14912 (fputs_styled): Do not set the output style when the default is
14913 requested.
14914 * ui-style.h (struct ui_file_style) <is_default>: New method.
14915 * source.c (print_source_lines_base): Emit escape sequences in one
14916 piece.
14917
75ba10dc
JB		 149182019-02-17 Joel Brobecker <brobecker@adacore.com>
14919
14920 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14921 integers and enumeration types.
14922
a2cd4f14
JB		 149232019-02-17 Joel Brobecker <brobecker@adacore.com>
14924
14925 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14926 instead of lookup_symbol_in_language
14927 (do_exact_match): New function.
14928 (ada_get_symbol_name_matcher): Return do_exact_match when
14929 doing a verbatim match.
14930
485b851b
TT		 149312019-02-15 Tom Tromey <tromey@adacore.com>
14932
14933 * ravenscar-thread.c (ravenscar_thread_target::resume)
14934 (ravenscar_thread_target::wait): Special case wildcard requests.
14935
0b790b1e
TT		 149362019-02-15 Tom Tromey <tromey@adacore.com>
14937
14938 * ravenscar-thread.c (base_ptid): Remove.
14939 (struct ravenscar_thread_target) <close>: New method.
14940 <m_base_ptid>: New member.
14941 <update_inferior_ptid, active_task, task_is_currently_active,
14942 runtime_initialized>: Declare methods.
14943 <ravenscar_thread_target>: Add constructor.
14944 (ravenscar_thread_target::task_is_currently_active)
14945 (ravenscar_thread_target::update_inferior_ptid)
14946 (ravenscar_runtime_initialized): Rename. Now methods.
14947 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14948 (ravenscar_thread_target::update_thread_list): Update.
14949 (ravenscar_thread_target::active_task): Now method.
14950 (ravenscar_thread_target::store_registers)
14951 (ravenscar_thread_target::prepare_to_store)
14952 (ravenscar_thread_target::prepare_to_store)
14953 (ravenscar_thread_target::mourn_inferior): Update.
14954 (ravenscar_inferior_created): Use "new" to create target.
14955 (ravenscar_thread_target::get_ada_task_ptid): Update.
14956 (_initialize_ravenscar): Don't initialize base_ptid.
14957 (ravenscar_ops): Remove global.
14958
dea57a62
TT		 149592019-02-15 Tom Tromey <tromey@adacore.com>
14960
14961 * target.h (push_target): Declare new overload.
14962 * target.c (push_target): New overload, taking an rvalue reference.
14963 * remote.c (remote_target::open_1): Use push_target overload.
14964 * corelow.c (core_target_open): Use push_target overload.
14965
989f3c58
TT		 149662019-02-15 Tom Tromey <tromey@adacore.com>
14967
14968 * ravenscar-thread.c (is_ravenscar_task)
14969 (ravenscar_task_is_currently_active): Return bool.
14970 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14971 (_initialize_ravenscar): Remove "(void)".
14972 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14973 Return bool.
14974
6cbcc006
TT		 149752019-02-15 Tom Tromey <tromey@adacore.com>
14976
14977 * ravenscar-thread.c (ravenscar_runtime_initializer)
14978 (has_ravenscar_runtime, get_running_thread_id)
14979 (ravenscar_thread_target::resume): Fix indentation.
14980
7657f14d
TT		 149812019-02-15 Tom Tromey <tromey@adacore.com>
14982
14983 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14984 from ravenscar_arch_ops.
14985 (sparc_ravenscar_ops::fetch_registers)
14986 (sparc_ravenscar_ops::store_registers): Now methods.
14987 (sparc_ravenscar_prepare_to_store): Remove.
14988 (sparc_ravenscar_ops): Redefine.
14989 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14990 methods and destructor. Remove members.
14991 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14992 (ravenscar_thread_target::store_registers)
14993 (ravenscar_thread_target::prepare_to_store): Update.
14994 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14995 Remove.
14996 (struct ppc_ravenscar_powerpc_ops): Derive from
14997 ravenscar_arch_ops.
14998 (ppc_ravenscar_powerpc_ops::fetch_registers)
14999 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15000 (ppc_ravenscar_powerpc_ops): Redefine.
15001 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15002 (ppc_ravenscar_e500_ops::fetch_registers)
15003 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15004 (ppc_ravenscar_e500_ops): Redefine.
15005 * aarch64-ravenscar-thread.c
15006 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15007 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15008 (aarch64_ravenscar_fetch_registers)
15009 (aarch64_ravenscar_store_registers): Now methods.
15010 (aarch64_ravenscar_ops): Redefine.
15011
5b6ea500
TT		 150122019-02-15 Tom Tromey <tromey@adacore.com>
15013
15014 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15015 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15016 (ravenscar_thread_target::stopped_by_watchpoint)
15017 (ravenscar_thread_target::stopped_data_address)
15018 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15019
e397fd39
TT		 150202019-02-15 Tom Tromey <tromey@adacore.com>
15021
15022 * ravenscar-thread.c: Fix some typos.
15023
cc12f4a8
TT		 150242019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15025 Tom Tromey <tromey@adacore.com>
15026
15027 * ada-lang.c (ada_exception_sal): Change addr_string to a
15028 std::string.
15029 (create_ada_exception_catchpoint): Update.
15030
5f486660
TT		 150312019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15032 Tom Tromey <tromey@adacore.com>
15033
15034 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15035 (bp_location_ops): Remove.
15036 (base_breakpoint_allocate_location): Update.
15037 (free_bp_location): Update.
15038 * ada-lang.c (class ada_catchpoint_location)
15039 <ada_catchpoint_location>: Remove ops parameter.
15040 (ada_catchpoint_location_dtor): Remove.
15041 (ada_catchpoint_location_ops): Remove.
15042 (allocate_location_exception): Update.
15043 * breakpoint.h (struct bp_location_ops): Remove.
15044 (class bp_location) <bp_location>: Remove bp_location_ops
15045 parameter.
15046 <~bp_location>: Add destructor.
15047 <ops>: Remove.
15048
b671c7fb
TS		 150492019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15050 Pedro Alves <palves@redhat.com>
15051
15052 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15053 'PATH_MAX'.
15054
8071c5ce
DM		 150552019-02-14 David Michael <fedora.dm0@gmail.com>
15056 Samuel Thibault <samuel.thibault@gnu.org>
15057 Thomas Schwinge <thomas@codesourcery.com>
15058
15059 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15060 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15061
b1041ae0
TS		 150622019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15063
924514e1
TS		 15064 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15065 (check_empty): Use "const char *".
15066
c29ee8d4
TS		 15067 * gnu-nat.c (gnu_nat_target::detach): Instead of
15068 'detach_inferior (pid)' call
15069 'detach_inferior (find_inferior_pid (pid))'.
15070
6c6ef69f
TS		 15071 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15072 'nat/fork-inferior.o'.
15073 * gnu-nat.c: #include "nat/fork-inferior.h".
15074
2d0a338c
TS		 15075 * gnu-nat.c (gnu_nat_target::detach): Instead of
15076 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15077 * gnu-nat.h: #include "inf-child.h".
15078 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15079 'i386_gnu_nat_target::fetch_registers'.
15080 (gnu_store_registers): Rename/move to
15081 'i386_gnu_nat_target::store_registers'.
15082
cabb5f06
TS		 15083 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15084 * gnu-nat.h (mach_thread_info): New function.
15085 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15086
b1041ae0
TS		 15087 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15088
2988d01e
KF		 150892019-02-14 Frederic Konrad <konrad@adacore.com>
15090
15091 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15092
c559d709
JB		 150932019-02-14 Joel Brobecker <brobecker@adacore.com>
15094
15095 * windows-nat.c (windows_add_thread): Add new parameter
15096 "main_thread_p" with default value set to false. Update
15097 function documentation as well as all callers.
15098 (windows_delete_thread): Likewise.
15099 (fake_create_process): Update call to windows_add_thread.
15100 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15101 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15102 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15103 call to windows_delete_thread.
15104
007024cc
SM		 151052019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15106
15107 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15108
f62318e9
JB		 151092019-02-12 John Baldwin <jhb@FreeBSD.org>
15110
15111 * symfile.c (find_separate_debug_file): Use canonical path of
15112 sysroot with child_path instead of gdb_sysroot if it is valid.
15113
cd4b7848
JB		 151142019-02-12 John Baldwin <jhb@FreeBSD.org>
15115
15116 * symfile.c (find_separate_debug_file): Use child_path to
15117 determine if an object file is under a sysroot.
15118
efac4bfe
JB		 151192019-02-12 John Baldwin <jhb@FreeBSD.org>
15120
15121 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15122 unittests/child-path-selftests.c.
15123 * common/pathstuff.c (child_path): New function.
15124 * common/pathstuff.h (child_path): New prototype.
15125 * unittests/child-path-selftests.c: New file.
15126
402d2bfe
JB		 151272019-02-12 John Baldwin <jhb@FreeBSD.org>
15128
15129 * symfile.c (find_separate_debug_file): Look for separate debug
15130 files in debug directories under the sysroot.
15131
1ed9f74e
PW		 151322019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15133
15134 * symtab.h (struct minimal_symbol data_p): New const method.
15135 (struct minimal_symbol text_p): Likewise.
15136 * symtab.c (output_source_filename): Use file name style
15137 to print file name.
15138 (print_symbol_info): Likewise.
15139 (print_msymbol_info): Use address style to print addresses.
15140 Use function name style to print executable text symbols.
15141 (expand_symtab_containing_pc): Use data_p.
15142 (find_pc_sect_compunit_symtab): Likewise.
15143
2636d81d
PW		 151442019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15145
15146 * breakpoint.c (describe_other_breakpoints): Use address style
15147 to print addresses.
15148 (say_where): Likewise.
15149
ac8c53cc
PW		 151502019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15151
15152 * ada-typeprint.c (print_func_type): Print function name
15153 style to print function name.
15154 * c-typeprint.c (c_print_type_1): Likewise.
15155
ea638c43
AH		 151562019-02-11 Alan Hayward <alan.hayward@arm.com>
15157
15158 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15159 for execve.
15160
ab759ca8
PW		 151612019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15162
15163 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15164 type_stack.
15165
aff29d1c
JB		 151662019-02-10 Joel Brobecker <brobecker@adacore.com>
15167
15168 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15169 TYPE_CODE_REF types.
15170
617126bc
JW		 151712019-02-08 Jim Wilson <jimw@sifive.com>
15172
15173 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15174 (riscv_linux_fregset): New.
15175 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15176
46e3ed7f
TT		 151772019-02-07 Tom Tromey <tom@tromey.com>
15178
15179 * thread.c (thread_cancel_execution_command): Update.
15180 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15181 methods.
15182 (struct thread_fsm_ops): Remove.
15183 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15184 (thread_fsm_should_stop, thread_fsm_return_value)
15185 (thread_fsm_set_finished, thread_fsm_finished_p)
15186 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15187 Don't declare.
15188 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15189 * infrun.c (clear_proceed_status_thread)
15190 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15191 (print_stop_event): Update.
15192 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15193 Add constructor.
15194 (step_command_fsm_ops): Remove.
15195 (new_step_command_fsm): Remove.
15196 (step_1): Update.
15197 (step_command_fsm::should_stop): Rename from
15198 step_command_fsm_should_stop.
15199 (step_command_fsm::clean_up): Rename from
15200 step_command_fsm_clean_up.
15201 (step_command_fsm::do_async_reply_reason): Rename from
15202 step_command_fsm_async_reply_reason.
15203 (struct until_next_fsm): Inherit from thread_fsm. Add
15204 constructor.
15205 (until_next_fsm_ops): Remove.
15206 (new_until_next_fsm): Remove.
15207 (until_next_fsm::should_stop): Rename from
15208 until_next_fsm_should_stop.
15209 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15210 (until_next_fsm::do_async_reply_reason): Rename from
15211 until_next_fsm_async_reply_reason.
15212 (struct finish_command_fsm): Inherit from thread_fsm. Add
15213 constructor. Change type of breakpoint.
15214 (finish_command_fsm_ops): Remove.
15215 (new_finish_command_fsm): Remove.
15216 (finish_command_fsm::should_stop): Rename from
15217 finish_command_fsm_should_stop.
15218 (finish_command_fsm::clean_up): Rename from
15219 finish_command_fsm_clean_up.
15220 (finish_command_fsm::return_value): Rename from
15221 finish_command_fsm_return_value.
15222 (finish_command_fsm::do_async_reply_reason): Rename from
15223 finish_command_fsm_async_reply_reason.
15224 (finish_command): Update.
15225 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15226 Add constructor.
15227 (call_thread_fsm_ops): Remove.
15228 (call_thread_fsm::call_thread_fsm): Rename from
15229 new_call_thread_fsm.
15230 (call_thread_fsm::should_stop): Rename from
15231 call_thread_fsm_should_stop.
15232 (call_thread_fsm::should_notify_stop): Rename from
15233 call_thread_fsm_should_notify_stop.
15234 (run_inferior_call, call_function_by_hand_dummy): Update.
15235 * cli/cli-interp.c (should_print_stop_to_console): Update.
15236 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15237 Add constructor. Change type of location_breakpoint,
15238 caller_breakpoint.
15239 (until_break_fsm_ops): Remove.
15240 (new_until_break_fsm): Remove.
15241 (until_break_fsm::should_stop): Rename from
15242 until_break_fsm_should_stop.
15243 (until_break_fsm::clean_up): Rename from
15244 until_break_fsm_clean_up.
15245 (until_break_fsm::do_async_reply_reason): Rename from
15246 until_break_fsm_async_reply_reason.
15247 (until_break_command): Update.
15248 * thread-fsm.c: Remove.
15249 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15250
1a5c2598
TT		 152512019-02-07 Tom Tromey <tom@tromey.com>
15252
15253 * yy-remap.h: Add include guard.
15254 * xtensa-tdep.h: Add include guard.
15255 * xcoffread.h: Rename include guard.
15256 * varobj-iter.h: Add include guard.
15257 * tui/tui.h: Rename include guard.
15258 * tui/tui-winsource.h: Rename include guard.
15259 * tui/tui-wingeneral.h: Rename include guard.
15260 * tui/tui-windata.h: Rename include guard.
15261 * tui/tui-win.h: Rename include guard.
15262 * tui/tui-stack.h: Rename include guard.
15263 * tui/tui-source.h: Rename include guard.
15264 * tui/tui-regs.h: Rename include guard.
15265 * tui/tui-out.h: Rename include guard.
15266 * tui/tui-layout.h: Rename include guard.
15267 * tui/tui-io.h: Rename include guard.
15268 * tui/tui-hooks.h: Rename include guard.
15269 * tui/tui-file.h: Rename include guard.
15270 * tui/tui-disasm.h: Rename include guard.
15271 * tui/tui-data.h: Rename include guard.
15272 * tui/tui-command.h: Rename include guard.
15273 * tic6x-tdep.h: Add include guard.
15274 * target/waitstatus.h: Rename include guard.
15275 * target/wait.h: Rename include guard.
15276 * target/target.h: Rename include guard.
15277 * target/resume.h: Rename include guard.
15278 * target-float.h: Rename include guard.
15279 * stabsread.h: Add include guard.
15280 * rs6000-tdep.h: Add include guard.
15281 * riscv-fbsd-tdep.h: Add include guard.
15282 * regformats/regdef.h: Rename include guard.
15283 * record.h: Rename include guard.
15284 * python/python.h: Rename include guard.
15285 * python/python-internal.h: Rename include guard.
15286 * python/py-stopevent.h: Rename include guard.
15287 * python/py-ref.h: Rename include guard.
15288 * python/py-record.h: Rename include guard.
15289 * python/py-record-full.h: Rename include guard.
15290 * python/py-record-btrace.h: Rename include guard.
15291 * python/py-instruction.h: Rename include guard.
15292 * python/py-events.h: Rename include guard.
15293 * python/py-event.h: Rename include guard.
15294 * procfs.h: Add include guard.
15295 * proc-utils.h: Add include guard.
15296 * p-lang.h: Add include guard.
15297 * or1k-tdep.h: Rename include guard.
15298 * observable.h: Rename include guard.
15299 * nto-tdep.h: Rename include guard.
15300 * nat/x86-linux.h: Rename include guard.
15301 * nat/x86-linux-dregs.h: Rename include guard.
15302 * nat/x86-gcc-cpuid.h: Add include guard.
15303 * nat/x86-dregs.h: Rename include guard.
15304 * nat/x86-cpuid.h: Rename include guard.
15305 * nat/ppc-linux.h: Rename include guard.
15306 * nat/mips-linux-watch.h: Rename include guard.
15307 * nat/linux-waitpid.h: Rename include guard.
15308 * nat/linux-ptrace.h: Rename include guard.
15309 * nat/linux-procfs.h: Rename include guard.
15310 * nat/linux-osdata.h: Rename include guard.
15311 * nat/linux-nat.h: Rename include guard.
15312 * nat/linux-namespaces.h: Rename include guard.
15313 * nat/linux-btrace.h: Rename include guard.
15314 * nat/glibc_thread_db.h: Rename include guard.
15315 * nat/gdb_thread_db.h: Rename include guard.
15316 * nat/gdb_ptrace.h: Rename include guard.
15317 * nat/fork-inferior.h: Rename include guard.
15318 * nat/amd64-linux-siginfo.h: Rename include guard.
15319 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15320 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15321 * nat/aarch64-linux.h: Rename include guard.
15322 * nat/aarch64-linux-hw-point.h: Rename include guard.
15323 * mn10300-tdep.h: Add include guard.
15324 * mips-linux-tdep.h: Add include guard.
15325 * mi/mi-parse.h: Rename include guard.
15326 * mi/mi-out.h: Rename include guard.
15327 * mi/mi-main.h: Rename include guard.
15328 * mi/mi-interp.h: Rename include guard.
15329 * mi/mi-getopt.h: Rename include guard.
15330 * mi/mi-console.h: Rename include guard.
15331 * mi/mi-common.h: Rename include guard.
15332 * mi/mi-cmds.h: Rename include guard.
15333 * mi/mi-cmd-break.h: Rename include guard.
15334 * m2-lang.h: Add include guard.
15335 * location.h: Rename include guard.
15336 * linux-record.h: Rename include guard.
15337 * linux-nat.h: Add include guard.
15338 * linux-fork.h: Add include guard.
15339 * i386-darwin-tdep.h: Rename include guard.
15340 * hppa-linux-offsets.h: Add include guard.
15341 * guile/guile.h: Rename include guard.
15342 * guile/guile-internal.h: Rename include guard.
15343 * gnu-nat.h: Rename include guard.
15344 * gdb-stabs.h: Rename include guard.
15345 * frv-tdep.h: Add include guard.
15346 * f-lang.h: Add include guard.
15347 * event-loop.h: Add include guard.
15348 * darwin-nat.h: Rename include guard.
15349 * cp-abi.h: Rename include guard.
15350 * config/sparc/nm-sol2.h: Rename include guard.
15351 * config/nm-nto.h: Rename include guard.
15352 * config/nm-linux.h: Add include guard.
15353 * config/i386/nm-i386gnu.h: Rename include guard.
15354 * config/djgpp/nl_types.h: Rename include guard.
15355 * config/djgpp/langinfo.h: Rename include guard.
15356 * compile/gcc-cp-plugin.h: Add include guard.
15357 * compile/gcc-c-plugin.h: Add include guard.
15358 * compile/compile.h: Rename include guard.
15359 * compile/compile-object-run.h: Rename include guard.
15360 * compile/compile-object-load.h: Rename include guard.
15361 * compile/compile-internal.h: Rename include guard.
15362 * compile/compile-cplus.h: Rename include guard.
15363 * compile/compile-c.h: Rename include guard.
15364 * common/xml-utils.h: Rename include guard.
15365 * common/x86-xstate.h: Rename include guard.
15366 * common/version.h: Rename include guard.
15367 * common/vec.h: Rename include guard.
15368 * common/tdesc.h: Rename include guard.
15369 * common/selftest.h: Rename include guard.
15370 * common/scoped_restore.h: Rename include guard.
15371 * common/scoped_mmap.h: Rename include guard.
15372 * common/scoped_fd.h: Rename include guard.
15373 * common/safe-iterator.h: Rename include guard.
15374 * common/run-time-clock.h: Rename include guard.
15375 * common/refcounted-object.h: Rename include guard.
15376 * common/queue.h: Rename include guard.
15377 * common/ptid.h: Rename include guard.
15378 * common/print-utils.h: Rename include guard.
15379 * common/preprocessor.h: Rename include guard.
15380 * common/pathstuff.h: Rename include guard.
15381 * common/observable.h: Rename include guard.
15382 * common/netstuff.h: Rename include guard.
15383 * common/job-control.h: Rename include guard.
15384 * common/host-defs.h: Rename include guard.
15385 * common/gdb_wait.h: Rename include guard.
15386 * common/gdb_vecs.h: Rename include guard.
15387 * common/gdb_unlinker.h: Rename include guard.
15388 * common/gdb_unique_ptr.h: Rename include guard.
15389 * common/gdb_tilde_expand.h: Rename include guard.
15390 * common/gdb_sys_time.h: Rename include guard.
15391 * common/gdb_string_view.h: Rename include guard.
15392 * common/gdb_splay_tree.h: Rename include guard.
15393 * common/gdb_setjmp.h: Rename include guard.
15394 * common/gdb_ref_ptr.h: Rename include guard.
15395 * common/gdb_optional.h: Rename include guard.
15396 * common/gdb_locale.h: Rename include guard.
15397 * common/gdb_assert.h: Rename include guard.
15398 * common/filtered-iterator.h: Rename include guard.
15399 * common/filestuff.h: Rename include guard.
15400 * common/fileio.h: Rename include guard.
15401 * common/environ.h: Rename include guard.
15402 * common/common-utils.h: Rename include guard.
15403 * common/common-types.h: Rename include guard.
15404 * common/common-regcache.h: Rename include guard.
15405 * common/common-inferior.h: Rename include guard.
15406 * common/common-gdbthread.h: Rename include guard.
15407 * common/common-exceptions.h: Rename include guard.
15408 * common/common-defs.h: Rename include guard.
15409 * common/common-debug.h: Rename include guard.
15410 * common/cleanups.h: Rename include guard.
15411 * common/buffer.h: Rename include guard.
15412 * common/btrace-common.h: Rename include guard.
15413 * common/break-common.h: Rename include guard.
15414 * cli/cli-utils.h: Rename include guard.
15415 * cli/cli-style.h: Rename include guard.
15416 * cli/cli-setshow.h: Rename include guard.
15417 * cli/cli-script.h: Rename include guard.
15418 * cli/cli-interp.h: Rename include guard.
15419 * cli/cli-decode.h: Rename include guard.
15420 * cli/cli-cmds.h: Rename include guard.
15421 * charset-list.h: Add include guard.
15422 * buildsym-legacy.h: Rename include guard.
15423 * bfin-tdep.h: Add include guard.
15424 * ax.h: Rename include guard.
15425 * arm-linux-tdep.h: Add include guard.
15426 * arm-fbsd-tdep.h: Add include guard.
15427 * arch/xtensa.h: Rename include guard.
15428 * arch/tic6x.h: Add include guard.
15429 * arch/i386.h: Add include guard.
15430 * arch/arm.h: Rename include guard.
15431 * arch/arm-linux.h: Rename include guard.
15432 * arch/arm-get-next-pcs.h: Rename include guard.
15433 * arch/amd64.h: Add include guard.
15434 * arch/aarch64-insn.h: Rename include guard.
15435 * arch-utils.h: Rename include guard.
15436 * annotate.h: Add include guard.
15437 * amd64-darwin-tdep.h: Rename include guard.
15438 * aarch64-linux-tdep.h: Add include guard.
15439 * aarch64-fbsd-tdep.h: Add include guard.
15440 * aarch32-linux-nat.h: Add include guard.
15441
ab9268d2
PW		 154422019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15443
15444 * macrotab.c (macro_define_internal): New function that
15445 factorizes macro_define_object_internal and macro_define_function
15446 code.
15447 (macro_define_object_internal): Use macro_define_internal.
15448 (macro_define_function): Likewise.
15449
bb0da2b4
PW		 154502019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15451
15452 * macrocmd.c (extract_identifier): Return
15453 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15454 callers.
15455
424eb552
JB		 154562019-02-06 John Baldwin <jhb@FreeBSD.org>
15457
15458 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15459
1688cb29
TT		 154602019-02-05 Tom Tromey <tom@tromey.com>
15461
15462 * target.c (target_stack::unpush): Move assertion earlier.
15463
b5eba2d8
TT		 154642019-01-30 Tom Tromey <tom@tromey.com>
15465
15466 PR python/23615:
15467 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15468 (gdbpy_parse_and_eval): Likewise.
15469 * python/python-internal.h (gdbpy_allow_threads): New class.
15470
7054e2ff
JB		 154712019-01-28 John Baldwin <jhb@FreeBSD.org>
15472
15473 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15474 (aarch64_fbsd_fpregmap): Move earlier.
15475 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15476 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15477 instead of individual calls to trad_frame_set_reg_addr.
15478 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15479 earlier.
15480 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15481 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15482 instead of individual calls to trad_frame_set_reg_addr.
15483
36c25ffa
AH		 154842019-01-28 Alan Hayward <alan.hayward@arm.com>
15485
15486 * CONTRIBUTE: Replace contribution list with wiki link.
15487
a0707f3c
TT		 154882019-01-25 Tom Tromey <tom@tromey.com>
15489
15490 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15491
0747795c
TT		 154922019-01-25 Tom Tromey <tom@tromey.com>
15493
15494 * xtensa-linux-nat.c: Fix common/ includes.
15495 * xml-support.h: Fix common/ includes.
15496 * xml-support.c: Fix common/ includes.
15497 * x86-linux-nat.c: Fix common/ includes.
15498 * windows-nat.c: Fix common/ includes.
15499 * varobj.h: Fix common/ includes.
15500 * varobj.c: Fix common/ includes.
15501 * value.c: Fix common/ includes.
15502 * valops.c: Fix common/ includes.
15503 * utils.c: Fix common/ includes.
15504 * unittests/xml-utils-selftests.c: Fix common/ includes.
15505 * unittests/utils-selftests.c: Fix common/ includes.
15506 * unittests/unpack-selftests.c: Fix common/ includes.
15507 * unittests/tracepoint-selftests.c: Fix common/ includes.
15508 * unittests/style-selftests.c: Fix common/ includes.
15509 * unittests/string_view-selftests.c: Fix common/ includes.
15510 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15511 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15512 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15513 * unittests/rsp-low-selftests.c: Fix common/ includes.
15514 * unittests/parse-connection-spec-selftests.c: Fix common/
15515 includes.
15516 * unittests/optional-selftests.c: Fix common/ includes.
15517 * unittests/offset-type-selftests.c: Fix common/ includes.
15518 * unittests/observable-selftests.c: Fix common/ includes.
15519 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15520 * unittests/memrange-selftests.c: Fix common/ includes.
15521 * unittests/memory-map-selftests.c: Fix common/ includes.
15522 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15523 * unittests/function-view-selftests.c: Fix common/ includes.
15524 * unittests/environ-selftests.c: Fix common/ includes.
15525 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15526 * unittests/common-utils-selftests.c: Fix common/ includes.
15527 * unittests/cli-utils-selftests.c: Fix common/ includes.
15528 * unittests/array-view-selftests.c: Fix common/ includes.
15529 * ui-file.c: Fix common/ includes.
15530 * tui/tui-io.c: Fix common/ includes.
15531 * tracepoint.h: Fix common/ includes.
15532 * tracepoint.c: Fix common/ includes.
15533 * tracefile-tfile.c: Fix common/ includes.
15534 * top.h: Fix common/ includes.
15535 * top.c: Fix common/ includes.
15536 * thread.c: Fix common/ includes.
15537 * target/waitstatus.h: Fix common/ includes.
15538 * target/waitstatus.c: Fix common/ includes.
15539 * target.h: Fix common/ includes.
15540 * target.c: Fix common/ includes.
15541 * target-memory.c: Fix common/ includes.
15542 * target-descriptions.c: Fix common/ includes.
15543 * symtab.h: Fix common/ includes.
15544 * symfile.c: Fix common/ includes.
15545 * stap-probe.c: Fix common/ includes.
15546 * spu-linux-nat.c: Fix common/ includes.
15547 * sparc-nat.c: Fix common/ includes.
15548 * source.c: Fix common/ includes.
15549 * solib.c: Fix common/ includes.
15550 * solib-target.c: Fix common/ includes.
15551 * ser-unix.c: Fix common/ includes.
15552 * ser-tcp.c: Fix common/ includes.
15553 * ser-pipe.c: Fix common/ includes.
15554 * ser-base.c: Fix common/ includes.
15555 * selftest-arch.c: Fix common/ includes.
15556 * s12z-tdep.c: Fix common/ includes.
15557 * rust-exp.y: Fix common/ includes.
15558 * rs6000-aix-tdep.c: Fix common/ includes.
15559 * riscv-tdep.c: Fix common/ includes.
15560 * remote.c: Fix common/ includes.
15561 * remote-notif.h: Fix common/ includes.
15562 * remote-fileio.h: Fix common/ includes.
15563 * remote-fileio.c: Fix common/ includes.
15564 * regcache.h: Fix common/ includes.
15565 * regcache.c: Fix common/ includes.
15566 * record-btrace.c: Fix common/ includes.
15567 * python/python.c: Fix common/ includes.
15568 * python/py-type.c: Fix common/ includes.
15569 * python/py-inferior.c: Fix common/ includes.
15570 * progspace.h: Fix common/ includes.
15571 * producer.c: Fix common/ includes.
15572 * procfs.c: Fix common/ includes.
15573 * proc-api.c: Fix common/ includes.
15574 * printcmd.c: Fix common/ includes.
15575 * ppc-linux-nat.c: Fix common/ includes.
15576 * parser-defs.h: Fix common/ includes.
15577 * osdata.c: Fix common/ includes.
15578 * obsd-nat.c: Fix common/ includes.
15579 * nat/x86-linux.c: Fix common/ includes.
15580 * nat/x86-linux-dregs.c: Fix common/ includes.
15581 * nat/x86-dregs.h: Fix common/ includes.
15582 * nat/x86-dregs.c: Fix common/ includes.
15583 * nat/ppc-linux.c: Fix common/ includes.
15584 * nat/mips-linux-watch.h: Fix common/ includes.
15585 * nat/mips-linux-watch.c: Fix common/ includes.
15586 * nat/linux-waitpid.c: Fix common/ includes.
15587 * nat/linux-ptrace.h: Fix common/ includes.
15588 * nat/linux-ptrace.c: Fix common/ includes.
15589 * nat/linux-procfs.c: Fix common/ includes.
15590 * nat/linux-personality.c: Fix common/ includes.
15591 * nat/linux-osdata.c: Fix common/ includes.
15592 * nat/linux-namespaces.c: Fix common/ includes.
15593 * nat/linux-btrace.h: Fix common/ includes.
15594 * nat/linux-btrace.c: Fix common/ includes.
15595 * nat/fork-inferior.c: Fix common/ includes.
15596 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15597 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15598 * nat/aarch64-linux.c: Fix common/ includes.
15599 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15600 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15601 * namespace.h: Fix common/ includes.
15602 * mips-linux-tdep.c: Fix common/ includes.
15603 * minsyms.c: Fix common/ includes.
15604 * mi/mi-parse.h: Fix common/ includes.
15605 * mi/mi-main.c: Fix common/ includes.
15606 * mi/mi-cmd-env.c: Fix common/ includes.
15607 * memrange.h: Fix common/ includes.
15608 * memattr.c: Fix common/ includes.
15609 * maint.h: Fix common/ includes.
15610 * maint.c: Fix common/ includes.
15611 * main.c: Fix common/ includes.
15612 * machoread.c: Fix common/ includes.
15613 * location.c: Fix common/ includes.
15614 * linux-thread-db.c: Fix common/ includes.
15615 * linux-nat.c: Fix common/ includes.
15616 * linux-fork.c: Fix common/ includes.
15617 * inline-frame.c: Fix common/ includes.
15618 * infrun.c: Fix common/ includes.
15619 * inflow.c: Fix common/ includes.
15620 * inferior.h: Fix common/ includes.
15621 * inferior.c: Fix common/ includes.
15622 * infcmd.c: Fix common/ includes.
15623 * inf-ptrace.c: Fix common/ includes.
15624 * inf-child.c: Fix common/ includes.
15625 * ia64-linux-nat.c: Fix common/ includes.
15626 * i387-tdep.c: Fix common/ includes.
15627 * i386-tdep.c: Fix common/ includes.
15628 * i386-linux-tdep.c: Fix common/ includes.
15629 * i386-linux-nat.c: Fix common/ includes.
15630 * i386-go32-tdep.c: Fix common/ includes.
15631 * i386-fbsd-tdep.c: Fix common/ includes.
15632 * i386-fbsd-nat.c: Fix common/ includes.
15633 * guile/scm-type.c: Fix common/ includes.
15634 * guile/guile.c: Fix common/ includes.
15635 * go32-nat.c: Fix common/ includes.
15636 * gnu-nat.c: Fix common/ includes.
15637 * gdbthread.h: Fix common/ includes.
15638 * gdbarch-selftests.c: Fix common/ includes.
15639 * gdb_usleep.c: Fix common/ includes.
15640 * gdb_select.h: Fix common/ includes.
15641 * gdb_bfd.c: Fix common/ includes.
15642 * gcore.c: Fix common/ includes.
15643 * fork-child.c: Fix common/ includes.
15644 * findvar.c: Fix common/ includes.
15645 * fbsd-nat.c: Fix common/ includes.
15646 * event-top.c: Fix common/ includes.
15647 * event-loop.c: Fix common/ includes.
15648 * dwarf2read.c: Fix common/ includes.
15649 * dwarf2loc.c: Fix common/ includes.
15650 * dwarf2-frame.c: Fix common/ includes.
15651 * dwarf-index-cache.c: Fix common/ includes.
15652 * dtrace-probe.c: Fix common/ includes.
15653 * disasm-selftests.c: Fix common/ includes.
15654 * defs.h: Fix common/ includes.
15655 * csky-tdep.c: Fix common/ includes.
15656 * cp-valprint.c: Fix common/ includes.
15657 * cp-support.h: Fix common/ includes.
15658 * cp-support.c: Fix common/ includes.
15659 * corelow.c: Fix common/ includes.
15660 * completer.h: Fix common/ includes.
15661 * completer.c: Fix common/ includes.
15662 * compile/compile.c: Fix common/ includes.
15663 * compile/compile-loc2c.c: Fix common/ includes.
15664 * compile/compile-cplus-types.c: Fix common/ includes.
15665 * compile/compile-cplus-symbols.c: Fix common/ includes.
15666 * command.h: Fix common/ includes.
15667 * cli/cli-dump.c: Fix common/ includes.
15668 * cli/cli-cmds.c: Fix common/ includes.
15669 * charset.c: Fix common/ includes.
15670 * build-id.c: Fix common/ includes.
15671 * btrace.h: Fix common/ includes.
15672 * btrace.c: Fix common/ includes.
15673 * breakpoint.h: Fix common/ includes.
15674 * breakpoint.c: Fix common/ includes.
15675 * ax.h:
15676 (enum agent_op): Fix common/ includes.
15677 * ax-general.c (struct aop_map): Fix common/ includes.
15678 * ax-gdb.c: Fix common/ includes.
15679 * auxv.c: Fix common/ includes.
15680 * auto-load.c: Fix common/ includes.
15681 * arm-tdep.c: Fix common/ includes.
15682 * arch/riscv.c: Fix common/ includes.
15683 * arch/ppc-linux-common.c: Fix common/ includes.
15684 * arch/i386.c: Fix common/ includes.
15685 * arch/arm.c: Fix common/ includes.
15686 * arch/arm-linux.c: Fix common/ includes.
15687 * arch/arm-get-next-pcs.c: Fix common/ includes.
15688 * arch/amd64.c: Fix common/ includes.
15689 * arch/aarch64.c: Fix common/ includes.
15690 * arch/aarch64-insn.c: Fix common/ includes.
15691 * arch-utils.c: Fix common/ includes.
15692 * amd64-windows-tdep.c: Fix common/ includes.
15693 * amd64-tdep.c: Fix common/ includes.
15694 * amd64-sol2-tdep.c: Fix common/ includes.
15695 * amd64-obsd-tdep.c: Fix common/ includes.
15696 * amd64-nbsd-tdep.c: Fix common/ includes.
15697 * amd64-linux-tdep.c: Fix common/ includes.
15698 * amd64-linux-nat.c: Fix common/ includes.
15699 * amd64-fbsd-tdep.c: Fix common/ includes.
15700 * amd64-fbsd-nat.c: Fix common/ includes.
15701 * amd64-dicos-tdep.c: Fix common/ includes.
15702 * amd64-darwin-tdep.c: Fix common/ includes.
15703 * agent.c: Fix common/ includes.
15704 * ada-lang.h: Fix common/ includes.
15705 * ada-lang.c: Fix common/ includes.
15706 * aarch64-tdep.c: Fix common/ includes.
15707
2f5c153e
TT		 157082019-01-25 Tom Tromey <tom@tromey.com>
15709
15710 * common/create-version.sh: Use common/version.h.
15711
adc6a863
PA		 157122019-01-24 Pedro Alves <palves@redhat.com>
15713
15714 * infrun.c (signal_stop, signal_print, signal_program)
15715 (signal_catch, signal_pass): Now arrays instead of pointers.
15716 (update_signals_program_target, do_target_resume)
15717 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15718 * linux-nat.c (linux_nat_target::pass_signals)
15719 (linux_nat_target::create_inferior, linux_nat_target::attach):
15720 Adjust.
15721 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15722 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15723 * procfs.c (procfs_target::pass_signals): Adjust.
15724 * record-full.c (record_full_target::resume): Adjust.
15725 * remote.c (remote_target::pass_signals)
15726 (remote_target::program_signals): Adjust.
15727 * target-debug.h (target_debug_print_signals): Now takes a
15728 gdb::array_view as parameter. Adjust.
15729 * target.h (target_ops) <pass_signals, program_signals>: Replace
15730 pointer and length parameters with gdb::array_view.
15731 (target_pass_signals, target_program_signals): Likewise.
15732 * target-delegates.c: Regenerate.
15733
3046d67a
PA		 157342019-01-24 Pedro Alves <palves@redhat.com>
15735
15736 * common/forward-scope-exit.h
15737 (forward_scope_exit::forward_scope_exit): Pass arguments to
15738 m_bind_function directly, instead of creating a std::bind and
15739 copying that.
15740
353229bf
AH		 157412019-01-24 Alan Hayward <alan.hayward@arm.com>
15742
15743 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15744 for static members.
15745 (pass_in_v_vfp_candidate): Likewise.
15746
311dc83a
TT		 157472019-01-23 Tom Tromey <tom@tromey.com>
15748 Pedro Alves <palves@redhat.com>
15749
15750 * regcache.c (class regcache_invalidator): Remove.
15751 (regcache::raw_write): Use make_scope_exit.
15752
296bd123
TT		 157532019-01-23 Tom Tromey <tom@tromey.com>
15754
15755 * ui-out.h (class ui_out_emit_type): Update comment.
15756
979a0d13
TT		 157572019-01-23 Tom Tromey <tom@tromey.com>
15758
15759 * infrun.c (fetch_inferior_event): Update comment.
15760
d238133d
TT		 157612019-01-23 Tom Tromey <tom@tromey.com>
15762 Pedro Alves <palves@redhat.com>
15763
15764 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15765 parameter.
15766 (fetch_inferior_event): Use SCOPE_EXIT.
15767
15768
9885e6bb
TT		 157692019-01-23 Tom Tromey <tom@tromey.com>
15770 Pedro Alves <palves@redhat.com>
15771
15772 * infrun.c (disable_thread_events): Delete.
15773 (stop_all_threads): Use SCOPE_EXIT.
15774
286526c1
TT		 157752019-01-23 Tom Tromey <tom@tromey.com>
15776 Pedro Alves <palves@redhat.com>
15777
15778 * symfile.c: Include forward-scope-exit.h.
15779 (clear_symtab_users_cleanup): Replace forward declaration with
15780 a FORWARD_SCOPE_EXIT.
15781 (syms_from_objfile_1): Use the forward_scope_exit and
15782 gdb::optional instead of cleanup_function.
15783 (reread_symbols): Use the forward_scope_exit instead of
15784 cleanup_function.
15785 (clear_symtab_users_cleanup): Remove function.
15786
1db93f14
TT		 157872019-01-23 Tom Tromey <tom@tromey.com>
15788 Pedro Alves <palves@redhat.com>
15789
15790 * linux-nat.c: Include scope-exit.h.
15791 (cleanup_target_stop): Remove.
15792 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15793 SCOPE_EXIT.
15794
2cc83d1e
TT		 157952019-01-23 Tom Tromey <tom@tromey.com>
15796 Pedro Alves <palves@redhat.com>
15797
15798 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15799 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15800
694c6bf5
TT		 158012019-01-23 Tom Tromey <tom@tromey.com>
15802 Andrew Burgess <andrew.burgess@embecosm.com>
15803 Pedro Alves <palves@redhat.com>
15804
15805 * infrun.c (fetch_inferior_event): Use scope_exit.
15806 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15807 * top.c (execute_command): Use scope_exit.
15808 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15809 * utils.c (do_bpstat_clear_actions_cleanup)
15810 (make_bpstat_clear_actions_cleanup): Remove.
15811
4c41382a
TT		 158122019-01-23 Tom Tromey <tom@tromey.com>
15813 Pedro Alves <palves@redhat.com>
15814
15815 * infrun.c: Include "common/scope-exit.h"
15816 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15817 (wait_for_inferior): Use SCOPE_EXIT.
15818 (fetch_inferior_event): Use scope_exit.
15819
89f8fb50
TT		 158202019-01-23 Tom Tromey <tom@tromey.com>
15821 Pedro Alves <palves@redhat.com>
15822
15823 * breakpoint.c (create_breakpoint): Remove cleanup.
15824
5419bdae
TT		 158252019-01-23 Tom Tromey <tom@tromey.com>
15826 Andrew Burgess <andrew.burgess@embecosm.com>
15827 Pedro Alves <palves@redhat.com>
15828
e587ef42
PA		 158292019-01-23 Pedro Alves <palves@redhat.com>
15830
15831 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15832
77f0e74c
PA		 158332019-01-23 Pedro Alves <palves@redhat.com>
15834 Andrew Burgess <andrew.burgess@embecosm.com>
15835
15836 * gdbthread.h: Include "common/forward-scope-exit.h".
15837 (scoped_finish_thread_state): Redefine custom class in terms of
15838 forward_scope_exit.
15839
5b9b3e53
PA		 158402019-01-23 Pedro Alves <palves@redhat.com>
15841 Andrew Burgess <andrew.burgess@embecosm.com>
15842
15843 * common/forward-scope-exit.h: New file.
15844
54b65c9b
PA		 158452019-01-23 Pedro Alves <palves@redhat.com>
15846 Andrew Burgess <andrew.burgess@embecosm.com>
15847 Tom Tromey <tom@tromey.com>
15848
15849 * common/scope-exit.h: New file.
15850
cf08fb29
PA		 158512019-01-23 Pedro Alves <palves@redhat.com>
15852
15853 * common/preprocessor.h (ESC): Rename to ...
15854 (ESC_PARENS): ... this.
15855 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15856 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15857
ae73e2e2
TT		 158582019-01-23 Tom Tromey <tom@tromey.com>
15859
15860 * language.h (class scoped_switch_to_sym_language_if_auto):
15861 Initialize m_lang in both cases.
15862
6594e122
AH		 158632019-01-23 Alan Hayward <alan.hayward@arm.com>
15864
15865 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15866 with XCNEW.
15867
a7c9855d
TT		 158682019-01-22 Tom Tromey <tom@tromey.com>
15869
15870 * corelow.c: Do not include sys/file.h.
15871
93cc1d53
TT		 158722019-01-22 Tom Tromey <tom@tromey.com>
15873
15874 * tui/tui-wingeneral.h: Include gdb_curses.h.
15875
38561778
TT		 158762019-01-22 Tom Tromey <tom@tromey.com>
15877
15878 * source-cache.h (class source_cache) <get_source_lines,
15879 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15880
37b3ab5b
TT		 158812019-01-22 Tom Tromey <tom@tromey.com>
15882
15883 * remote-fileio.h (struct remote_target): Declare.
15884
3fabc016
TT		 158852019-01-22 Tom Tromey <tom@tromey.com>
15886
15887 * python/py-arch.c: Do not include py-ref.h.
15888 * python/py-bpevent.c: Do not include py-ref.h.
15889 * python/py-cmd.c: Do not include py-ref.h.
15890 * python/py-continueevent.c: Do not include py-ref.h.
15891 * python/py-event.h: Do not include py-ref.h.
15892 * python/py-evtregistry.c: Do not include py-ref.h.
15893 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15894 * python/py-frame.c: Do not include py-ref.h.
15895 * python/py-framefilter.c: Do not include py-ref.h.
15896 * python/py-function.c: Do not include py-ref.h.
15897 * python/py-infevents.c: Do not include py-ref.h.
15898 * python/py-linetable.c: Do not include py-ref.h.
15899 * python/py-objfile.c: Do not include py-ref.h.
15900 * python/py-param.c: Do not include py-ref.h.
15901 * python/py-prettyprint.c: Do not include py-ref.h.
15902 * python/py-progspace.c: Do not include py-ref.h.
15903 * python/py-symbol.c: Do not include py-ref.h.
15904 * python/py-symtab.c: Do not include py-ref.h.
15905 * python/py-type.c: Do not include py-ref.h.
15906 * python/py-unwind.c: Do not include py-ref.h.
15907 * python/py-utils.c: Do not include py-ref.h.
15908 * python/py-value.c: Do not include py-ref.h.
15909 * python/py-varobj.c: Do not include py-ref.h.
15910 * python/py-xmethods.c: Do not include py-ref.h.
15911 * python/python.c: Do not include py-ref.h.
15912 * varobj.c: Do not include py-ref.h.
15913
6b4d7774
TT		 159142019-01-22 Tom Tromey <tom@tromey.com>
15915
15916 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15917 keyword for bcache.
15918
7af7e9b5
TT		 159192019-01-22 Tom Tromey <tom@tromey.com>
15920
15921 * compile/compile-cplus-types.c: Remove a comment by #include.
15922
951d1049
TT		 159232019-01-22 Tom Tromey <tom@tromey.com>
15924
15925 * compile/gcc-c-plugin.h: Include compile-internal.h.
15926
d65d5705
TT		 159272019-01-22 Tom Tromey <tom@tromey.com>
15928
15929 * stabsread.c (EXTERN): Do not define.
15930 (symnum, next_symbol_text_func, processing_gcc_compilation)
15931 (within_function, global_sym_chain, global_stabs)
15932 (previous_stab_code, this_object_header_files)
15933 (n_this_object_header_files)
15934 (n_allocated_this_object_header_files): Define.
15935 * stabsread.h (EXTERN): Never define. Use "extern".
15936
b6fb1ee5
PW		 159372019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15938
15939 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15940 history_value.
15941
be6d4f74
TT		 159422019-01-21 Tom Tromey <tom@tromey.com>
15943
15944 * ui-out.c: Fix includes.
15945 * tui/tui-source.c: Fix includes.
15946 * target.c: Fix includes.
15947 * remote.c: Fix includes.
15948 * regcache.c: Fix includes.
15949 * python/py-block.c: Fix includes.
15950 * printcmd.c: Fix includes.
15951 * or1k-tdep.c: Fix includes.
15952 * mi/mi-main.c: Fix includes.
15953 * m32r-tdep.c: Fix includes.
15954 * csky-tdep.c: Fix includes.
15955 * compile/compile-cplus-types.c: Fix includes.
15956 * cli/cli-interp.c: Fix includes.
15957
73021deb
AH		 159582019-01-21 Alan Hayward <alan.hayward@arm.com>
15959
15960 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15961 for padding.
15962
7932255d
TT		 159632019-01-16 Tom Tromey <tom@tromey.com>
15964
15965 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15966 earlier.
15967 (struct objfile) <msymbols_range>: Move from top level.
15968 <msymbols>: New method.
15969 (class objfile_msymbols): Remove.
15970 * symtab.c (default_collect_symbol_completion_matches_break_on):
15971 Update.
15972 * symmisc.c (dump_msymbols): Update.
15973 * stabsread.c (scan_file_globals): Update.
15974 * objc-lang.c (info_selectors_command, info_classes_command)
15975 (find_methods): Update.
15976 * minsyms.c (find_solib_trampoline_target): Update.
15977 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15978 * coffread.c (coff_symfile_read): Update.
15979 * ada-lang.c (ada_lookup_simple_minsym)
15980 (ada_collect_symbol_completion_matches): Update.
15981
604b1bfb
TT		 159822019-01-16 Tom Tromey <tom@tromey.com>
15983
15984 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15985 type. Remove no-argument constructor.
15986 <iterator::operator++>: Simplify.
15987 <begin>: Update.
15988 <end>: Use minimal_symbol_count.
15989
f252c6d5
TT		 159902019-01-16 Tom Tromey <tom@tromey.com>
15991
15992 * objfiles.h (struct objfile) <psymtabs>: New method.
15993 (class objfile_psymtabs): Remove.
15994 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15995 typedef.
15996 <range>: New method.
15997 (require_partial_symbols): Change return type.
15998 * psymtab.c (require_partial_symbols)
15999 (psym_expand_symtabs_matching): Update.
16000 * mdebugread.c (parse_partial_symbols): Update.
16001 * dbxread.c (dbx_end_psymtab): Update.
16002
b669c953
TT		 160032019-01-15 Tom Tromey <tom@tromey.com>
16004
16005 * symtab.c (lookup_objfile_from_block)
16006 (lookup_symbol_in_objfile_symtabs)
16007 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16008 (find_line_symtab, info_sources_command)
16009 (default_collect_symbol_completion_matches_break_on)
16010 (make_source_files_completion_list): Update.
16011 * symmisc.c (print_objfile_statistics, dump_objfile)
16012 (maintenance_print_symbols, maintenance_info_symtabs)
16013 (maintenance_check_symtabs, maintenance_info_line_tables):
16014 Update.
16015 * source.c (select_source_symtab)
16016 (forget_cached_source_info_for_objfile): Update.
16017 * objfiles.h (class objfile_compunits): Remove.
16018 (struct objfile) <compunits_range>: New typedef.
16019 (compunits): New method.
16020 * objfiles.c (objfile_relocate1): Update.
16021 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16022 * maint.c (count_symtabs_and_blocks): Update.
16023 * linespec.c (iterate_over_all_matching_symtabs): Update.
16024 * cp-support.c (add_symbol_overload_list_qualified): Update.
16025 * coffread.c (coff_symtab_read): Update.
16026 * ada-lang.c (add_nonlocal_symbols)
16027 (ada_collect_symbol_completion_matches)
16028 (ada_add_global_exceptions): Update.
16029
7e955d83
TT		 160302019-01-15 Tom Tromey <tom@tromey.com>
16031
16032 * progspace.h (program_space) <objfiles_safe_range>: New
16033 typedef.
16034 <objfiles_safe>: New method.
16035 * objfiles.h (class all_objfiles_safe): Remove.
16036 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16037 * jit.c (jit_inferior_exit_hook): Update.
16038
2030c079
TT		 160392019-01-17 Tom Tromey <tom@tromey.com>
16040
16041 * progspace.h (program_space) <objfiles_range>: New typedef.
16042 <objfiles>: New method.
16043 <objfiles_head>: Rename from objfiles.
16044 (object_files): Update.
16045 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16046 * guile/scm-pretty-print.c
16047 (ppscm_find_pretty_printer_from_objfiles): Update.
16048 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16049 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16050 Update.
16051 * python/py-progspace.c (pspy_get_objfiles): Update.
16052 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16053 Update.
16054 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16055 (objfpy_lookup_objfile_by_build_id): Update.
16056 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16057 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16058 Update.
16059 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16060 (expand_symtab_containing_pc, lookup_objfile_from_block)
16061 (lookup_static_symbol, basic_lookup_transparent_type)
16062 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16063 (find_line_symtab, info_sources_command)
16064 (default_collect_symbol_completion_matches_break_on)
16065 (make_source_files_completion_list, find_main_name): Update.
16066 * symmisc.c (print_symbol_bcache_statistics)
16067 (print_objfile_statistics, maintenance_print_symbols)
16068 (maintenance_print_msymbols, maintenance_print_objfiles)
16069 (maintenance_info_symtabs, maintenance_check_symtabs)
16070 (maintenance_expand_symtabs, maintenance_info_line_tables):
16071 Update.
16072 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16073 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16074 (map_overlay_command, unmap_overlay_command)
16075 (simple_overlay_update, expand_symtabs_matching)
16076 (map_symbol_filenames): Update.
16077 * symfile-debug.c (set_debug_symfile): Update.
16078 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16079 Update.
16080 * source.c (select_source_symtab, forget_cached_source_info):
16081 Update.
16082 * solib.c (solib_read_symbols): Update.
16083 * solib-spu.c (append_ocl_sos): Update.
16084 * psymtab.c (maintenance_print_psymbols)
16085 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16086 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16087 * printcmd.c (info_symbol_command): Update.
16088 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16089 Update.
16090 * objfiles.h (class all_objfiles): Remove.
16091 * objfiles.c (have_partial_symbols, have_full_symbols)
16092 (have_minimal_symbols, qsort_cmp, update_section_map)
16093 (shared_objfile_contains_address_p)
16094 (default_iterate_over_objfiles_in_search_order): Update.
16095 * objc-lang.c (info_selectors_command, info_classes_command)
16096 (find_methods): Update.
16097 * minsyms.c (find_solib_trampoline_target): Update.
16098 * maint.c (maintenance_info_sections)
16099 (maintenance_translate_address, count_symtabs_and_blocks):
16100 Update.
16101 * main.c (captured_main_1): Update.
16102 * linux-thread-db.c (try_thread_db_load_from_pdir)
16103 (has_libpthread): Update.
16104 * linespec.c (iterate_over_all_matching_symtabs)
16105 (search_minsyms_for_name): Update.
16106 * jit.c (jit_find_objf_with_entry_addr): Update.
16107 * hppa-tdep.c (find_unwind_entry)
16108 (hppa_lookup_stub_minimal_symbol): Update.
16109 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16110 Update.
16111 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16112 (elf_gnu_ifunc_resolve_by_got): Update.
16113 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16114 * dwarf-index-write.c (save_gdb_index_command): Update.
16115 * cp-support.c (add_symbol_overload_list_qualified): Update.
16116 * breakpoint.c (create_overlay_event_breakpoint)
16117 (create_longjmp_master_breakpoint)
16118 (create_std_terminate_master_breakpoint)
16119 (create_exception_master_breakpoint): Update.
16120 * blockframe.c (find_pc_partial_function): Update.
16121 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16122 (ada_collect_symbol_completion_matches)
16123 (ada_add_global_exceptions): Update.
16124
776489e0
TT		 161252019-01-17 Tom Tromey <tom@tromey.com>
16126
16127 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16128 declare VEC.
16129 (solib_target_parse_libraries): Change return type.
16130 (library_list_start_segment, library_list_start_section)
16131 (library_list_end_library, library_list_start_library); Update.
16132 (solib_target_free_library_list): Remove.
16133 (solib_target_parse_libraries): Remove cleanup. Change return
16134 type.
16135 (solib_target_current_sos): Update.
16136
6471e7d2
TT		 161372019-01-17 Tom Tromey <tromey@bapiya>
16138
16139 * valprint.c: Replace "the the" with "the".
16140 * symtab.c: Replace "the the" with "the".
16141 * solib.c: Replace "the the" with "the".
16142 * solib-dsbt.c: Replace "the the" with "the".
16143 * linespec.c: Replace "the the" with "the".
16144 * dwarf2loc.h: Replace "the the" with "the".
16145 * amd64-windows-tdep.c: Replace "the the" with "the".
16146 * aarch64-tdep.c: Replace "the the" with "the".
16147
c24bdb02
KS		 161482019-01-16 Keith Seitz <keiths@redhat.com>
16149
16150 PR gdb/23773
16151 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16152 <builder>: Rename to ..
16153 <m_builder>: ... this and make private.
16154 (dwarf2_cu::get_builder): New method. Change all users of
16155 `builder' to use this method.
16156 (dwarf2_start_symtab): Move to ...
16157 (dwarf2_cu::start_symtab): ... here. Update all callers
16158 (setup_type_unit_groups): Move to ...
16159 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16160 callers.
16161 (dwarf2_cu::reset_builder): New method.
16162 (process_full_compunit, process_full_type_unit): Use
16163 dwarf2_cu::reset_builder.
16164 (follow_die_offset): Record the ancestor CU if it is different
16165 from the followed DIE's CU.
16166 (follow_die_sig_1): Likewise.
16167
8d64371b
TT		 161682019-01-15 Tom Tromey <tom@tromey.com>
16169
16170 * remote.c (class remote_state) <buf>: Now a char_vector.
16171 <buf_size>: Remove.
16172 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16173 parameter.
16174 (remote_target::getpkt_or_notif_sane_1)
16175 (remote_target::getpkt_sane)
16176 (remote_target::getpkt_or_notif_sane): Likewise.
16177 (class remote_target) <putpkt>: New overload.
16178 (remote_target::read_frame): Change type of "buf_p". Remove
16179 sizeof_p parameter.
16180 (packet_ok): New overload.
16181 (packet_check_result): New overload.
16182 Update all uses.
16183
bb277751
TT		 161842019-01-14 Tom Tromey <tom@tromey.com>
16185
16186 * remote-notif.c (handle_notification, remote_notif_ack)
16187 (remote_notif_parse): Make "buf" const.
16188 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16189 const.
16190 (remote_notif_parse, remote_notif_ack, handle_notification):
16191 Likewise.
16192 * remote.c (remote_notif_stop_parse): Make "buf" const.
16193 (remote_target::remote_parse_stop_reply): Make "buf" const.
16194 (remote_notif_stop_ack): Make "buf" const.
16195
05be00a8
TT		 161962019-01-14 Tom Tromey <tom@tromey.com>
16197
16198 * remote.c (remote_console_output): Make parameter const.
16199
491adeca
TT		 162002019-01-14 Tom Tromey <tom@tromey.com>
16201
16202 * target-debug.h (target_debug_print_signals): Constify.
16203 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16204 * procfs.c (procfs_target::pass_signals): Update.
16205 * linux-nat.c (linux_nat_target::pass_signals): Update.
16206 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16207 * target-delegates.c: Rebuild.
16208 * remote.c (remote_target::program_signals): Update.
16209 (remote_target::pass_signals): Update.
16210 * target.c (target_pass_signals): Constify argument.
16211 (target_program_signals): Likewise.
16212 * target.h (struct target_ops) <pass_signals, program_signals>:
16213 Constify argument.
16214 (target_pass_signals, target_program_signals): Constify argument.
16215
bbd94648
TT		 162162019-01-14 Tom Tromey <tom@tromey.com>
16217
16218 PR tui/28819:
16219 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16220
6f072a10
PFC		 162212019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16222
16223 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16224 field.
16225 * rs6000-tdep.c: Include reggroups.h.
16226 (IS_V_ALIAS_PSEUDOREG): Define.
16227 (rs6000_register_name): Return names for the "vX" aliases.
16228 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16229 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16230 aliases. Call default_register_reggroup_p for all other
16231 pseudo-registers.
16232 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16233 New functions.
16234 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16235 Handle "vX" aliases.
16236 (v_alias_pseudo_register_collect): New function.
16237 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16238 (rs6000_gdbarch_init): Initialize "vX" aliases as
16239 pseudo-registers. Restore registration of
16240 rs6000_pseudo_register_reggroup_p with
16241 set_tdesc_pseudo_register_reggroup_p.
16242
1a782351
MF		 162432019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16244
16245 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16246 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16247 set_gdbarch_num_pseudo_regs.
16248
d73cff18
PW		 162492019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16250
16251 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16252 Remove arg prefixname, add do_set and do_show.
16253 Add member functions set_list and show_list.
16254 * cli/cli-style.c (class cli_style_option): Update accordingly.
16255 (style_set_list): Move to file scope.
16256 (style_show_list): Likewise.
16257 (set_style): Call help_list.
16258 (show_style): Call cmd_show_list.
16259 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16260 Update to use the new macro.
16261
60a90376
JB		 162622019-10-12 Joel Brobecker <brobecker@adacore.com>
16263
16264 * ada-lang.c (_initialize_ada_language): Expand the help text
16265 for the "catch exception" command.
16266
9d7c67bf
PW		 162672019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16268
16269 * symtab.c (matching_obj_sections): Initialize obj,
16270 declare it closer to its usage.
16271
7cf47dc4
TT		 162722019-01-10 Tom Tromey <tom@tromey.com>
16273
16274 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16275 (basic_inf_threads_range): Remove.
16276 (inf_threads_range, inf_non_exited_threads_range)
16277 (safe_inf_threads_range): Use next_adapter.
16278
d3cb6808
KS		 162792019-01-10 Keith Seitz <keiths@redhat.com>
16280
16281 PR gdb/23712
16282 PR symtab/23010
16283 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16284 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16285
63a20375
KS		 162862019-01-10 Keith Seitz <keiths@redhat.com>
16287
16288 PR gdb/23712
16289 PR symtab/23010
16290 * dictionary.c (pending_to_vector): Remove.
16291 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16292 Remove _1 suffix, replacing functions of the same name. Update
16293 all callers.
16294 (dict_create_hashed, dict_create_hashed_expandable)
16295 (dict_create_linear, dict_create_linear_expandable, dict_free)
16296 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16297 Make functions static.
16298
b026f593
KS		 162992019-01-10 Keith Seitz <keiths@redhat.com>
16300
16301 PR gdb/23712
16302 PR symtab/23010
16303 * dictionary.h (struct dictionary): Replace declaration with
16304 multidictionary.
16305 (dict_create_hashed, dict_create_hashed_expandable)
16306 (dict_create_linear, dict_create_linear_expandable)
16307 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16308 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16309 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16310 taking multidictionary argument.
16311 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16312 * block.h (struct block) <dict>: Change to multidictionary
16313 and rename `multidict'.
16314 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16315 symmisc.c: Update all dictionary references to multidictionary.
16316
c7748ee9
KS		 163172019-01-10 Keith Seitz <keiths@redhat.com>
16318
16319 PR gdb/23712
16320 PR symtab/23010
16321 * dictionary.c: Include unordered_map.
16322 (pending_to_vector): New function.
16323 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16324 Rewrite the non-"_1" functions to take vector instead
16325 of linked list.
16326 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16327 "new" _1 versions of the same name.
16328 (multidictionary): Define.
16329 (std::hash<enum language): New definition.
16330 (collate_pending_symbols_by_language, mdict_create_hashed)
16331 (mdict_create_hashed_expandable, mdict_create_linear)
16332 (mdict_create_linear_expandable, mdict_free)
16333 (find_language_dictionary, create_new_language_dictionary)
16334 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16335 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16336 (mdict_size, mdict_empty): New functions.
16337 * dictionary.h (mdict_iterator): Define.
16338
67aa1f3c
PA		 163392019-01-10 Pedro Alves <palves@redhat.com>
16340
16341 * breakpoint.c (read_uploaded_action)
16342 (create_tracepoint_from_upload): Adjust to use
16343 gdb::unique_xmalloc_ptr.
16344 * ctf.c (ctf_write_uploaded_tp):
16345 (SET_ARRAY_FIELD): Use emplace_back.
16346 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16347 * tracefile-tfile.c (tfile_write_uploaded_tp):
16348 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16349 gdb::unique_xmalloc_ptr.
16350 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16351 at_string, cond_string, cmd_strings>: Replace char pointers
16352 with gdb::unique_xmalloc_ptr.
16353
2f667667
PA		 163542019-01-10 Pedro Alves <palves@redhat.com>
16355
16356 * solib-target.c (library_list_start_library): Don't xstrdup name.
16357
36cb7237
PA		 163582019-01-10 Pedro Alves <palves@redhat.com>
16359
16360 * mdebugread.c (parse_partial_symbols): Use
16361 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16362
da584958
AB		 163632019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16364
16365 * linux-fork.c (scoped_switch_fork_info)
16366 <~scoped_switch_fork_info>: Fix incorrect variable name.
16367
1ef8573c
AB		 163682019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16369
16370 * linux-fork.c (scoped_switch_fork_info)
16371 <scoped_switch_fork_info>: Make explicit.
16372 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16373
8d7bcccb
TT		 163742019-01-10 Tom Tromey <tom@tromey.com>
16375
16376 * objfiles.h (objfile::reset_psymtabs): Update.
16377 * objfiles.c (objfile::objfile): Update.
16378 * psymtab.h (psymtab_storage::obstack): Update.
16379 (psymtab_storage::m_obstack): Use gdb::optional.
16380 (class psymtab_storage): Update comment. Remove objfile
16381 parameter.
16382 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16383
b596a3c7
TT		 163842019-01-10 Tom Tromey <tom@tromey.com>
16385
16386 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16387 <free_psymtabs>: Now private.
16388 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16389 (allocate_psymtab): Use new method.
16390
a9342b62
TT		 163912019-01-10 Tom Tromey <tom@tromey.com>
16392
16393 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16394 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16395 * mdebugread.c (parse_partial_symbols): Use
16396 allocate_dependencies.
16397 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16398 allocate_dependencies.
16399 (process_psymtab_comp_unit_reader)
16400 (build_type_psymtab_dependencies): Likewise.
16401 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16402
5af70966
TT		 164032019-01-10 Tom Tromey <tom@tromey.com>
16404
16405 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16406 PSYMBOL_SET_LANGUAGE.
16407 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16408
5923a04c
TT		 164092019-01-10 Tom Tromey <tom@tromey.com>
16410
16411 * psymtab.h (psymtab_storage::obstack): New method.
16412 <m_obstack>: Rename from obstack; now private.
16413 * psymtab.c (psymtab_storage): Update.
16414 * dwarf2read.c (create_addrmap_from_index)
16415 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16416 Update.
16417
6d6a12bf
TT		 164182019-01-10 Tom Tromey <tom@tromey.com>
16419
16420 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16421 * objfiles.h (objfile::reset_psymtabs): New method.
16422
d320c2b5
TT		 164232019-01-10 Tom Tromey <tom@tromey.com>
16424
16425 * symmisc.c (print_symbol_bcache_statistics): Update.
16426 (print_objfile_statistics): Update.
16427 * symfile.c (reread_symbols): Update.
16428 * psymtab.h (class psymtab_storage): New.
16429 * psymtab.c (psymtab_storage): New constructor.
16430 (~psymtab_storage): New destructor.
16431 (require_partial_symbols): Update.
16432 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16433 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16434 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16435 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16436 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16437 (start_psymtab_common, end_psymtab_common)
16438 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16439 (allocate_psymtab): Update.
16440 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16441 Update.
16442 (dump_psymtab_addrmap, maintenance_print_psymbols)
16443 (maintenance_check_psymtabs): Update.
16444 (class objfile_psymtabs): Move to objfiles.h.
16445 * psympriv.h (discard_psymtab): Now inline.
16446 (psymtab_discarder::psymtab_discarder): Update.
16447 (psymtab_discarder::~psymtab_discarder): Update.
16448 (ALL_OBJFILE_PSYMTABS): Rewrite.
16449 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16450 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16451 Remove fields.
16452 <partial_symtabs>: New field.
16453 (class objfile_psymtabs): Move from psymtab.h. Update.
16454 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16455 psymbol_cache.
16456 (objfile::~objfile): Don't destroy psymbol_cache.
16457 * mdebugread.c (parse_partial_symbols): Update.
16458 * dwarf2read.c (create_addrmap_from_index)
16459 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16460 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16461 (add_partial_subprogram, dwarf2_ranges_read): Update.
16462 * dwarf-index-write.c (write_address_map)
16463 (write_one_signatured_type, recursively_write_psymbols)
16464 (class debug_names, class debug_names, write_psymtabs_to_index):
16465 Update.
16466
1d94a5a3
TT		 164672019-01-10 Tom Tromey <tom@tromey.com>
16468
16469 * symtab.h (SYMBOL_SET_NAMES): Update.
16470 (symbol_set_names): Update.
16471 (MSYMBOL_SET_NAMES): Update.
16472 * symtab.c (symbol_set_names): Change argument to be an
16473 objfile_per_bfd_storage.
16474 * psymtab.c (add_psymbol_to_bcache): Update.
16475 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16476
0f14768a
TT		 164772019-01-10 Tom Tromey <tom@tromey.com>
16478
16479 * symtab.c (create_demangled_names_hash): Change argument to be an
16480 objfile_per_bfd_storage.
16481 (symbol_set_names): Update.
16482
6eee24ce
TT		 164832019-01-10 Tom Tromey <tom@tromey.com>
16484
16485 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16486 init_psymbol_list.
16487 * psymtab.c (init_psymbol_list): Do nothing if already called.
16488 * psympriv.h (init_psymbol_list): Add comment.
16489 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16490 init_psymbol_list.
16491 * dbxread.c (dbx_symfile_read): Unconditionally call
16492 init_psymbol_list.
16493
75aedd27
TT		 164942019-01-10 Tom Tromey <tom@tromey.com>
16495
16496 * xcoffread.c (scan_xcoff_symtab): Update.
16497 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16498 "where".
16499 * mdebugread.c (parse_partial_symbols)
16500 (handle_psymbol_enumerators): Update.
16501 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16502 * dbxread.c (read_dbx_symtab): Update.
16503 * psympriv.h (psymbol_placement): New enum.
16504 (add_psymbol_to_list): Update.
16505
939652a5
TT		 165062019-01-10 Tom Tromey <tom@tromey.com>
16507
16508 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16509 static_psymbols parameters.
16510 (scan_xcoff_symtab): Update.
16511 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16512 static_psymbols parameters.
16513 * psympriv.h (start_psymtab_common): Update.
16514 * mdebugread.c (parse_partial_symbols): Update.
16515 * dwarf2read.c (create_partial_symtab): Update.
16516 * dbxread.c (read_dbx_symtab): Update.
16517 (start_psymtab): Remove global_psymbols and static_psymbols
16518 parameters.
16519
baa62830
TT		 165202019-01-10 Tom Tromey <tom@tromey.com>
16521
16522 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16523 * psymtab.c (allocate_psymtab): Add comment.
16524 * psympriv.h (allocate_psymtab): Add comment.
16525 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16526 initializations.
16527 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16528
0e8f53ba
TT		 165292019-01-10 Tom Tromey <tom@tromey.com>
16530
16531 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16532 Don't declare.
16533 * mipsread.c: Include mdebugread.h.
16534 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16535 Declare.
16536 * elfread.c: Include mdebugread.h.
16537
b22a7c6a
TT		 165382019-01-09 Tom Tromey <tom@tromey.com>
16539
16540 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16541 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16542 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16543 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16544 (psym_lookup_symbol, psym_find_last_source_symtab)
16545 (psym_forget_cached_source_info, psym_print_stats)
16546 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16547 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16548 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16549 (psym_find_compunit_symtab_by_address)
16550 (maintenance_print_psymbols, maintenance_info_psymtabs)
16551 (maintenance_check_psymtabs): Use ranged for.
16552 * psymtab.h (class objfile_psymtabs): New.
16553 (require_partial_symbols): Return objfile_psymtabs.
16554 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16555
3b9d3ac2
TT		 165562019-01-09 Tom Tromey <tom@tromey.com>
16557
16558 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16559 (find_pc_mapped_section, list_overlays_command)
16560 (map_overlay_command, unmap_overlay_command)
16561 (simple_overlay_update): Use all_objfiles.
16562 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16563 * printcmd.c (info_symbol_command): Use all_objfiles.
16564 * objfiles.h (ALL_OBJSECTIONS): Remove.
16565 * maint.c (maintenance_translate_address): Use all_objfiles.
16566 * gcore.c (gcore_create_callback): Use all_objfiles.
16567 (objfile_find_memory_regions): Likewise.
16568
8b31193a
TT		 165692019-01-09 Tom Tromey <tom@tromey.com>
16570
16571 * symtab.c (find_line_symtab, info_sources_command)
16572 (make_source_files_completion_list): Use objfile_compunits.
16573 * source.c (select_source_symtab): Use objfile_compunits.
16574 * objfiles.h (struct objfile): Update comment.
16575 (ALL_OBJFILES): Remove.
16576 (ALL_FILETABS): Remove.
16577 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16578 objfile_compunits.
16579
d5da8b3c
TT		 165802019-01-09 Tom Tromey <tom@tromey.com>
16581
16582 * symmisc.c (print_objfile_statistics, dump_objfile)
16583 (maintenance_print_symbols): Use compunit_filetabs.
16584 * source.c (forget_cached_source_info_for_objfile): Use
16585 compunit_filetabs.
16586 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16587 (ALL_FILETABS): Use compunit_filetabs.
16588 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16589 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16590
5accd1a0
TT		 165912019-01-09 Tom Tromey <tom@tromey.com>
16592
16593 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16594 (compunit_filetabs): New.
16595 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16596 compunit_filetabs.
16597 (info_sources_command, make_source_files_completion_list): Remove
16598 declaration.
16599 * symmisc.c (print_objfile_statistics, dump_objfile)
16600 (maintenance_print_symbols): Remove declaration.
16601 (maintenance_info_symtabs): Use compunit_filetabs.
16602 (maintenance_info_line_tables): Likewise.
16603 * source.c (select_source_symtab): Change local variable name.
16604 (forget_cached_source_info_for_objfile): Remove declaration.
16605 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16606 * objfiles.c (objfile_relocate1): Remove declaration.
16607 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16608 declaration.
16609 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16610 * coffread.c (coff_symtab_read): Remove declaration.
16611 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16612 compunit_filetabs.
16613
d8aeb77f
TT		 166142019-01-09 Tom Tromey <tom@tromey.com>
16615
16616 * symtab.c (lookup_objfile_from_block)
16617 (find_pc_sect_compunit_symtab, search_symbols)
16618 (default_collect_symbol_completion_matches_break_on): Use
16619 objfile_compunits.
16620 * objfiles.h (ALL_COMPUNITS): Remove.
16621 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16622 * cp-support.c (add_symbol_overload_list_qualified): Use
16623 objfile_compunits.
16624 * ada-lang.c (ada_collect_symbol_completion_matches)
16625 (ada_add_global_exceptions): Use objfile_compunits.
16626
592553c4
TT		 166272019-01-09 Tom Tromey <tom@tromey.com>
16628
16629 * source.c (select_source_symtab)
16630 (forget_cached_source_info_for_objfile): Remove declaration.
16631 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16632 declaration.
16633 * maint.c (count_symtabs_and_blocks): Remove declaration.
16634 * cp-support.c (add_symbol_overload_list_qualified): Remove
16635 declaration.
16636 * coffread.c (coff_symtab_read): Remove declaration.
16637 * symtab.c (lookup_symbol_in_objfile_symtabs)
16638 (basic_lookup_transparent_type_1): Use objfile_compunits.
16639 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16640 (info_sources_command, search_symbols)
16641 (default_collect_symbol_completion_matches_break_on)
16642 (make_source_files_completion_list): Remove declaration.
16643 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16644 (ada_collect_symbol_completion_matches)
16645 (ada_add_global_exceptions): Remove declaration.
16646 * linespec.c (iterate_over_all_matching_symtabs): Use
16647 objfile_compunits.
16648 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16649 (class objfile_compunits): New.
16650 (ALL_COMPUNITS): Use objfile_compunits.
16651 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16652 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16653 objfile_compunits.
16654 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16655
5325b9bf
TT		 166562019-01-09 Tom Tromey <tom@tromey.com>
16657
16658 * symtab.c (search_symbols)
16659 (default_collect_symbol_completion_matches_break_on): Use
16660 objfile_msymbols.
16661 * ada-lang.c (ada_lookup_simple_minsym)
16662 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16663 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16664 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16665 objfile_msymbols.
16666 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16667 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16668 * objc-lang.c (find_methods): Use objfile_msymbols.
16669 (info_selectors_command, info_classes_command): Likewise.
16670 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16671 * objfiles.h (class objfile_msymbols): New.
16672 (ALL_OBJFILE_MSYMBOLS): Remove.
16673 (ALL_MSYMBOLS): Remove.
16674
cac85af2
TT		 166752019-01-09 Tom Tromey <tom@tromey.com>
16676
16677 * common/next-iterator.h (next_adapter): Add Iterator template
16678 parameter.
16679 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16680 (class all_objfiles_safe): New.
16681 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16682 * objfiles.c (put_objfile_before): Update comment.
16683 (add_separate_debug_objfile): Likewise.
16684 (free_all_objfiles): Use all_objfiles_safe.
16685 (objfile_purge_solibs): Likewise.
16686
aed57c53
TT		 166872019-01-09 Tom Tromey <tom@tromey.com>
16688
16689 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16690 (expand_symtab_containing_pc, lookup_static_symbol)
16691 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16692 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16693 all_objfiles.
16694 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16695 * breakpoint.c (create_overlay_event_breakpoint)
16696 (create_longjmp_master_breakpoint)
16697 (create_std_terminate_master_breakpoint)
16698 (create_exception_master_breakpoint): Use all_objfiles.
16699 * linux-thread-db.c (try_thread_db_load_from_pdir)
16700 (has_libpthread): Use all_objfiles.
16701 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16702 * linespec.c (iterate_over_all_matching_symtabs)
16703 (search_minsyms_for_name): Use all_objfiles.
16704 * maint.c (maintenance_info_sections): Use all_objfiles.
16705 * main.c (captured_main_1): Use all_objfiles.
16706 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16707 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16708 * guile/scm-pretty-print.c
16709 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16710 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16711 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16712 (maintenance_print_msymbols): Use all_objfiles.
16713 * source.c (select_source_symtab): Use all_objfiles.
16714 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16715 * symfile.c (remove_symbol_file_command)
16716 (expand_symtabs_matching, map_symbol_filenames): Use
16717 all_objfiles.
16718 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16719 all_objfiles.
16720 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16721 * objc-lang.c (find_methods): Use all_objfiles.
16722 * objfiles.c (have_partial_symbols, have_full_symbols)
16723 (have_minimal_symbols, qsort_cmp)
16724 (default_iterate_over_objfiles_in_search_order): Use
16725 all_objfiles.
16726 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16727 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16728 (maintenance_check_psymtabs): Use all_objfiles.
16729 (ALL_PSYMTABS): Remove.
16730 * compile/compile-object-run.c (do_module_cleanup): Use
16731 all_objfiles.
16732 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16733 * cp-support.c (add_symbol_overload_list_qualified): Use
16734 all_objfiles.
16735 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16736 Use all_objfiles.
16737 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16738 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16739 all_objfiles.
16740 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16741 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16742 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16743 Uses all_objfiles.
16744 * solib.c (solib_read_symbols): Use all_objfiles
16745
99d89cde
TT		 167462019-01-09 Tom Tromey <tom@tromey.com>
16747
16748 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16749 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16750 all_objfiles.
16751 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16752 * symmisc.c (print_symbol_bcache_statistics)
16753 (print_objfile_statistics, maintenance_print_objfiles)
16754 (maintenance_info_symtabs, maintenance_check_symtabs)
16755 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16756 all_objfiles.
16757 * source.c (forget_cached_source_info): Use all_objfiles.
16758 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16759 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16760 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16761 * objfiles.c (update_section_map): Use all_objfiles.
16762 (shared_objfile_contains_address_p): Likewise.
16763 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16764 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16765
21708325
TT		 167662019-01-09 Tom Tromey <tom@tromey.com>
16767
16768 * common/next-iterator.h: New file.
16769 * objfiles.h (class all_objfiles): New.
16770 (struct objfile_iterator): New.
16771
669e09f6
PW		 167722019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16773
16774 * NEWS: Move the description of the changed "frame", "select-frame",
16775 and "info frame" commands to the Changed commands section.
16776
041be526
SM		 167772019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16778
16779 * gdbtypes.c (check_stub_method_group): Remove handling of old
16780 mangling schemes.
16781 * linespec.c (find_methods): Likewise.
16782 * stabsread.c (read_member_functions): Likewise.
16783 * valops.c (search_struct_method): Likewise.
16784 (value_struct_elt_for_reference): Likewise.
16785 * NEWS: Mention this change.
16786
0e2a2133
AB		 167872019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16788
16789 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16790 print_source_lines.
16791 * source.c (print_source_lines_base): Update line number check.
16792 (print_source_lines): New function.
16793 (source_lines_range::source_lines_range): New function.
16794 * source.h (class source_lines_range): New class.
16795 (print_source_lines): New declaration.
16796
1055a3b4
PW		 167972019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16798
16799 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16800
cfeadda5
TT		 168012019-01-08 Tom Tromey <tom@tromey.com>
16802 Simon Marchi <simon.marchi@ericsson.com>
16803
16804 PR gdb/24060
16805 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16806 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16807 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16808 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16809 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16810 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16811
583068ca
AB		 168122019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16813
16814 * source.c (select_source_symtab): Move header comment to
16815 declaration in source.h.
16816 (forget_cached_source_info_for_objfile): Likewise.
16817 (forget_cached_source_info): Likewise.
16818 (identify_source_line): Likewise.
16819 * source.h (identify_source_line): Move declaration from symtab.h
16820 and add comment from source.c
16821 (print_source_lines): Likewise.
16822 (forget_cached_source_info_for_objfile): Likewise.
16823 (forget_cached_source_info): Likewise.
16824 (select_source_symtab): Likewise.
16825 (enum print_source_lines_flag): Move definition from symtab.h.
16826 * symtab.h (identify_source_line): Move declaration to source.h.
16827 (print_source_lines): Likewise.
16828 (forget_cached_source_info_for_objfile): Likewise.
16829 (forget_cached_source_info): Likewise.
16830 (select_source_symtab): Likewise.
16831 (enum print_source_lines_flag): Move definition to source.h.
16832 * tui/tui-hooks.c: Add 'source.h' include.
16833
ec98a4ad
AB		 168342019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16835
16836 * source.c (print_source_lines_base): Handle requests to print
16837 reverse line number sequences, and guard against empty lines
16838 string.
16839
62ea19c1
AB		 168402019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16841
16842 * source.c (print_source_lines_base): Fix skip of '\r' if next
16843 character is '\n'.
16844
9d30e1fd
TT		 168452019-01-06 Tom Tromey <tom@tromey.com>
16846
16847 * c-exp.y (struct c_parse_state) <macro_original_text,
16848 expansion_obstack>: New member.
16849 (macro_original_text, expansion_obstack): Remove globals.
16850 (scan_macro_expansion, scanning_macro_expansion)
16851 (finished_macro_expansion): Update.
16852 (scan_macro_cleanup): Remove.
16853 (yylex, c_parse): Update.
16854
c65bac38
TT		 168552019-01-06 Tom Tromey <tom@tromey.com>
16856
16857 * c-exp.y (struct c_parse_state) <strings>: New member.
16858 (operator_stoken): Update.
16859
02e12e38
TT		 168602019-01-06 Tom Tromey <tom@tromey.com>
16861
16862 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16863 (union type_stack_elt) <typelist_val>: Now a pointer to
16864 std::vector.
16865 (type_stack_cleanup): Don't declare.
16866 (push_typelist): Update.
16867 * parse.c (pop_typelist): Return a std::vector.
16868 (push_typelist): Take a std::vector.
16869 (follow_types): Update. Do not free args.
16870 (type_stack_cleanup): Remove.
16871 * c-exp.y (struct c_parse_state): New.
16872 (cpstate): New global.
16873 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16874 (nonempty_typelist): Update.
16875 (func_mod): Create a new vector.
16876 (c_parse): Create a c_parse_state.
16877 (check_parameter_typelist): Do not delete params.
16878 (function_method): Update. Do not delete type_list.
16879
f097f5ad
TT		 168802019-01-06 Tom Tromey <tom@tromey.com>
16881
16882 PR gdb/28155:
16883 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16884 check_typedef.
16885 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16886 (print_return_value): Likewise.
16887
d2adf9f1
TT		 168882019-01-05 Tom Tromey <tom@tromey.com>
16889
16890 * contrib/cleanup_check.py: Remove.
16891 * contrib/gcc-with-excheck: Remove.
16892 * contrib/exsummary.py: Remove.
16893 * contrib/excheck.py: Remove.
16894
2eab46b1
JB		 168952019-01-05 Joel Brobecker <brobecker@adacore.com>
16896
16897 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16898 NULL. Initialize tpprev to NULL instead of assigning it
16899 to NULL on the next statement.
16900 * windows-nat.c (windows_delete_thread): Remove check for
16901 main_thread_id before printing thread exit notifications.
16902 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16903 Remove thread ID check against main_thread_id.
16904 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16905 windows_delete_thread.
16906 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16907
48c5e7e2
TT		 169082019-01-04 Tom Tromey <tom@tromey.com>
16909
16910 * compile/compile.c (_initialize_compile): Use upper case for
16911 metasyntactic variables.
16912 * symmisc.c (_initialize_symmisc): Use upper case for
16913 metasyntactic variables.
16914 * psymtab.c (_initialize_psymtab): Use upper case for
16915 metasyntactic variables.
16916 * demangle.c (demangle_command): Use upper case for metasyntactic
16917 variables.
16918 (_initialize_demangler): Likewise.
16919 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16920 variables.
16921
986041cd
TT		 169222019-01-03 Tom Tromey <tom@tromey.com>
16923
16924 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16925
7c711119
TT		 169262019-01-03 Tom Tromey <tom@tromey.com>
16927
16928 * python/py-symtab.c (salpy_str): Update.
16929 (struct salpy_sal_object) <symtab>: Now a PyObject.
16930 (salpy_dealloc): Update.
16931 (del_objfile_sal): Use gdbpy_ref.
16932
1b20edf0
TT		 169332019-01-03 Tom Tromey <tom@tromey.com>
16934
16935 * python/py-type.c (convert_field): Use new_reference. Return
16936 gdbpy_ref.
16937 (make_fielditem): Return gdbpy_ref.
16938 (typy_fields): Update.
16939 (typy_getitem): Update.
16940 (field_name): Return gdbpy_ref. Use new_reference.
16941 (typy_iterator_iternext): Update.
16942
ea41325b
TT		 169432019-01-03 Tom Tromey <tom@tromey.com>
16944
16945 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16946
2a3c71d6
TT		 169472019-01-03 Tom Tromey <tom@tromey.com>
16948
16949 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16950 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16951 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16952 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16953 (pspy_set_type_printers): Likewise.
16954 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16955 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16956 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16957 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16958 (objfpy_set_type_printers): Likewise.
16959
5c329e6a
TT		 169602019-01-03 Tom Tromey <tom@tromey.com>
16961
16962 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16963 (gdbpy_print_stack): Use gdbpy_err_fetch.
16964 * python/python-internal.h (class gdbpy_err_fetch): New class.
16965 (class gdbpy_enter) <m_error_type, m_error_value,
16966 m_error_traceback>: Remove.
16967 <m_error>: New member.
16968 (gdbpy_exception_to_string): Don't declare.
16969 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16970 * python/py-value.c (convert_value_from_python): Use
16971 gdbpy_err_fetch.
16972 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16973 gdbpy_exception_to_string.
16974 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16975 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16976 gdbpy_err_fetch.
16977
169bb27b
AB		 169782019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16979
16980 * linux-nat.c (delete_lwp_cleanup): Delete.
16981 (struct lwp_deleter): New struct.
16982 (lwp_info_up): New typedef.
16983 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16984 lwp_info_up.
16985
a07c8880
AB		 169862019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16987
16988 * linux-fork.c (class scoped_switch_fork_info): New class.
16989 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16990
26089c49
AB		 169912019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16992
16993 * valops.c (find_overload_match): Remove use of null_cleanup, and
16994 calls to do_cleanups.
16995
06d3e5b0
AB		 169962019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16997
16998 * compile/compile-cplus-types.c
16999 (compile_cplus_instance::decl_name): Handle changes to
17000 cp_func_name.
17001 * cp-support.c (cp_func_name): Update header comment, update
17002 return type.
17003 * cp-support.h (cp_func_name): Update return type in declaration.
17004 * valops.c (find_overload_match): Move temp_func local to top
17005 level of function and change its type. Use temp_func to hold and
17006 delete temporary string obtained from cp_func_name.
17007
66644cd3
AB		 170082019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17009
17010 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17011 gdb::char_vector, remove cleanup, and update uses of `msg`.
17012
592d8c0a
JW		 170132019-01-03 Jim Wilson <jimw@sifive.com>
17014
17015 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17016
c55d06ec
TT		 170172019-01-02 Tom Tromey <tom@tromey.com>
17018
17019 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17020 (tdesc_parse_xml): Remove cleanups.
17021 * target-descriptions.h (make_cleanup_free_target_description):
17022 Don't declare.
17023 (target_desc_deleter): New struct.
17024 (target_desc_up): New typedef.
17025 * target-descriptions.c (target_desc_deleter::operator()): Rename
17026 from free_target_description.
17027 (make_cleanup_free_target_description): Remove.
17028
3a6ae42d
TT		 170292019-01-02 Tom Tromey <tom@tromey.com>
17030
17031 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17032 constructor, destructor.
17033 (linespec_parser): Remove typedef.
17034 (~linespec_parser): Rename from linespec_parser_delete.
17035 (linespec_lex_to_end, linespec_complete_label)
17036 (linespec_complete): Update.
17037 (decode_line_full): Remove cleanups.
17038 (decode_line_1): Update.
17039
61fd3e73
TT		 170402019-01-02 Tom Tromey <tom@tromey.com>
17041
17042 * python/python-internal.h (inferior_to_inferior_object): Change
17043 return type.
17044 * python/py-exitedevent.c (create_exited_event_object): Update.
17045 * python/py-inferior.c (inferior_to_inferior_object): Return
17046 gdbpy_ref.
17047 (python_new_inferior, python_inferior_deleted)
17048 (thread_to_thread_object, delete_thread_object)
17049 (build_inferior_list, gdbpy_selected_inferior): Update.
17050 * python/py-infthread.c (create_thread_object): Update. Also fail
17051 if inferior_to_inferior_object fails.
17052
d20172fc
SM		 170532019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17054
17055 * inferior.h (class inferior) <displaced_step_state>: New field.
17056 * infrun.h (struct displaced_step_state): Move here from
17057 infrun.c. Initialize fields, add constructor.
17058 <inf>: Remove field.
17059 <reset>: New method.
17060 * infrun.c (struct displaced_step_inferior_state): Move to
17061 infrun.h.
17062 (displaced_step_inferior_states): Remove.
17063 (get_displaced_stepping_state): Adust.
17064 (displaced_step_in_progress_any_inferior): Adjust.
17065 (displaced_step_in_progress_thread): Adjust.
17066 (displaced_step_in_progress): Adjust.
17067 (add_displaced_stepping_state): Remove.
17068 (get_displaced_step_closure_by_addr): Adjust.
17069 (remove_displaced_stepping_state): Remove.
17070 (infrun_inferior_exit): Call displaced_step_state.reset.
17071 (use_displaced_stepping): Don't check for NULL.
17072 (displaced_step_prepare_throw): Call
17073 get_displaced_stepping_state.
17074 (displaced_step_fixup): Don't check for NULL.
17075 (prepare_for_detach): Don't check for NULL.
17076
e3319240
PW		 170772019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17078
17079 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17080 in case of call that did not complete.
17081
5d36dfb9
AU		 170822019-01-02 Andrey Utkin <autkin@undo.io>
17083
17084 * symfile.c (find_separate_debug_file): Fix search of debug files for
17085 remote debuggee.
17086
8833fbf0
TT		 170872019-01-02 Tom Tromey <tom@tromey.com>
17088
17089 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17090 indentation.
17091 * python/py-frame.c (frapy_older): Remove cast.
17092 (frapy_newer): Likewise.
17093 * python/py-breakpoint.c (local_setattro): Remove cast.
17094 * python/py-arch.c (archpy_name): Remove local variable.
17095 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17096
4ada3dfd
JB		 170972019-01-02 Joel Brobecker <brobecker@adacore.com>
17098
17099 * unittests/basic_string_view/element_access/char/empty.cc:
17100 Fix year range in copyright header.
17101
113b7b81
AB		 171022019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17103
17104 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17105 Delete.
17106 <operator==>: Update with for removed field.
17107 <hash>: Likewise.
17108 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17109 <isa_features>: ...this.
17110 <abi_features>: New field.
17111 (riscv_isa_flen): Update comment.
17112 (riscv_abi_xlen): New declaration.
17113 (riscv_abi_flen): New declaration.
17114 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17115 isa_features.
17116 (riscv_abi_xlen): New function.
17117 (riscv_isa_flen): Update to get answer from isa_features.
17118 (riscv_abi_flen): New function.
17119 (riscv_has_fp_abi): Update to get answer from abi_features.
17120 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17121 xlen and flen.
17122 (riscv_call_info) <xlen, flen>: Update comment.
17123 (riscv_call_arg_struct): Remove invalid assertions
17124 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17125 is removed.
17126 (riscv_gdbarch_init): Gather isa features and abi features
17127 separately, ensure both match on the gdbarch when reusing an old
17128 gdbarch. Relax an error check to allow 32-bit abi float to run on
17129 a target with 64-bit float hardware.
17130
b18ca514
PW		 171312019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17132
17133 * source.c (search_command_helper): Stop reverse search
17134 when line 1 has been searched.
17135
ec70d8db
PW		 171362019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17137
17138 * record-full.c (record_full_base_target::close): Rewrite
17139 record_full_core_buf_list free logic.
17140
5b38f9c1
PW		 171412019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17142
17143 * break-catch-syscall.c (print_one_catch_syscall): xfree
17144 the last text.
17145
66d91b39
JB		 171462019-01-01 Joel Brobecker <brobecker@adacore.com>
17147
17148 * top.c (print_gdb_version): Update Copyright year in version
17149 message.
17150
42a4f53d
JB		 171512019-01-01 Joel Brobecker <brobecker@adacore.com>
17152
17153 Update copyright year range in all GDB files.
17154
7e955d83 171552019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17156
5bbd631d 17157 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17158
5bbd631d 17159For older changes see ChangeLog-2018.
c906108c
SS		 17160\f
17161Local Variables:
17162mode: change-log
17163left-margin: 8
17164fill-column: 74
17165version-control: never
57da7796 17166coding: utf-8
c906108c 17167End:
5bbd631d 17168
GDB Binutils - Deliverables
This page took 3.105252 seconds and 4 git commands to generate.