projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Reimplement tui_get_begin_asm_address
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
52469d76
TT		 12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
4 get_current_source_symtab_and_line, and main_name.
5
5d49bf1b
TT		 62019-12-20 Tom Tromey <tom@tromey.com>
7
8 * tui/tui.c (tui_show_source): Update.
9 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
10 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
11 a symtab_symbol_info, not a separate symtab and line. Simplify.
12
88180c08
TT		 132019-12-20 Tom Tromey <tom@tromey.com>
14
15 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
16 Simplify.
17
9f7540a5
TT		 182019-12-20 Tom Tromey <tom@tromey.com>
19
20 * tui/tui-winsource.h (struct tui_source_window_base)
21 <set_contents, update_source_window_as_is, update_source_window>:
22 Take a sal, not a separate symtab and tui_line_or_address.
23 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
24 (tui_source_window_base::update_source_window_as_is): Take a sal,
25 not a separate symtab and tui_line_or_address.
26 (tui_update_source_windows_with_addr)
27 (tui_update_source_windows_with_line)
28 (tui_source_window_base::rerender)
29 (tui_source_window_base::refill): Update.
30 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
31 a sal, not a separate symtab and tui_line_or_address.
32 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
33 not a separate symtab and tui_line_or_address.
34 (tui_source_window::maybe_update): Update.
35 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
36 a sal, not a separate symtab and tui_line_or_address.
37 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
38 not a separate symtab and tui_line_or_address.
39 (tui_disasm_window::do_scroll_vertical)
40 (tui_disasm_window::maybe_update): Update.
41
57e4b379
TT		 422019-12-20 Tom Tromey <tom@tromey.com>
43
44 * tui/tui-winsource.c (tui_source_window_base::refill): Use
45 start_line_or_addr.
46 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
47 start_line_or_addr.
48 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
49 start_line_or_addr.
50
61c33f10
TT		 512019-12-20 Tom Tromey <tom@tromey.com>
52
53 * tui/tui-winsource.h (struct tui_source_window_base)
54 <set_contents>: Return bool.
55 * tui/tui-winsource.c
56 (tui_source_window_base::update_source_window_as_is): Update.
57 * tui/tui-source.h (struct tui_source_window) <set_contents>:
58 Return bool.
59 * tui/tui-source.c (tui_source_window::set_contents): Return
60 bool. Simplify.
61 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
62 Return bool.
63 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
64 bool.
65
469b0731
TT		 662019-12-20 Tom Tromey <tom@tromey.com>
67
68 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
69 (tui_update_source_windows_with_line): Call update_source_window.
70 * tui/tui-source.h (struct tui_source_window)
71 <show_symtab_source>: Don't declare.
72 * tui/tui-source.c (tui_source_window::show_symtab_source):
73 Remove.
74
855f89b3
TT		 752019-12-20 Tom Tromey <tom@tromey.com>
76
77 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
78 update_source_window directly.
79 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
80 * tui/tui-disasm.c (tui_show_disassem): Remove.
81
d4669c0f
TT		 822019-12-20 Tom Tromey <tom@tromey.com>
83
84 * tui/tui-winsource.c
85 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
86 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
87
1ae58f0c
TT		 882019-12-20 Tom Tromey <tom@tromey.com>
89
90 * tui/tui-winsource.h (struct tui_source_window_base)
91 <maybe_update>: Remove line_no and addr parameters.
92 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
93 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
94 Update.
95 * tui/tui-source.c (tui_source_window::maybe_update): Remove
96 line_no and addr parameters.
97 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
98 Update.
99 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
100 line_no and addr parameters.
101
039298ec
TT		 1022019-12-20 Tom Tromey <tom@tromey.com>
103
104 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
105 (tui_source_window_base::update_breakpoint_info): Remove asserts.
106
8acfefcc
TT		 1072019-12-20 Tom Tromey <tom@tromey.com>
108
109 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
110 tui_show_disassem.
111 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
112 declare.
113 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
114
5ebd5402
TT		 1152019-12-20 Tom Tromey <tom@tromey.com>
116
117 * tui/tui.h (tui_show_source): Remove parameters.
118 * tui/tui.c (tui_show_source): Remove parameters.
119 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
120
c1b167d7
TT		 1212019-12-20 Tom Tromey <tom@tromey.com>
122
123 * tui/tui.c (tui_show_source): Update.
124 * tui/tui-winsource.c (tui_display_main): Update.
125 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
126 to symtab.
127 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
128 to symtab.
129 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
130
364d7104
TT		 1312019-12-20 Tom Tromey <tom@tromey.com>
132
133 PR tui/23619:
134 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
135 (tui_redisplay_readline): Use rl_display_prompt.
136 (tui_prep_terminal): Update.
137
0ad6b8ee
CB		 1382019-12-19 Christian Biesinger <cbiesinger@google.com>
139
140 * configure: Regenerate.
141 * configure.ac: Quote variable arguments of test.
142 * gdbsupport/common.m4: Likewise.
143
d411762c
CB		 1442019-12-19 Christian Biesinger <cbiesinger@google.com>
145
146 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
147 2 to pow ().
148
1cd4a20a
CB		 1492019-12-19 Christian Biesinger <cbiesinger@google.com>
150
151 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
152 log10 to double to fix Solaris 11 with gcc 5.5.
153
aa989b27
CB		 1542019-12-19 Christian Biesinger <cbiesinger@google.com>
155
156 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
157 "sun" to "saddr_un".
158
2032eb7e
TT		 1592019-12-19 Tom Tromey <tromey@adacore.com>
160
161 * ui-out.h (enum class field_kind): Fix comment.
162
f69656d0
TT		 1632019-12-11 Tom Tromey <tromey@adacore.com>
164
165 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
166
27e4fac7
TT		 1672019-12-18 Tom Tromey <tromey@adacore.com>
168
169 PR build/25268:
170 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
171 type on macOS. Add comment.
172
e623f035
SM		 1732019-12-18 Simon Marchi <simon.marchi@efficios.com>
174
175 * c-lang.c (c_get_string, asm_language_defn): Remove space
176 before tab.
177
28ce7b07
TT		 1782019-12-18 Tom Tromey <tromey@adacore.com>
179
180 PR build/25250:
181 * ui-out.c (ui_out::vmessage): Update.
182 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
183 Rename.
184 (string_field): Update.
185 (signed_field): Update.
186
bbde7025
SM		 1872019-12-18 Simon Marchi <simon.marchi@efficios.com>
188
189 * top.c (print_gdb_configuration): Adjust indentation.
190
e3169fe0
CB		 1912019-12-17 Christian Biesinger <cbiesinger@google.com>
192
193 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
194
9b30da15
SM		 1952019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
196
197 * tui/tui-layout.h (class tui_layout_base): Add virtual
198 destructor.
199
4a4c04f1
BE		 2002019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
201
202 * infcmd.c (prepare_one_step): Step over skipped inline functions.
203 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
204 (process_event_stop_test): Keep stepping over skipped inline functions.
205
0394eed1
SM		 2062019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
207
208 * jit.c (struct gdb_block) <next>: Remove field.
209 (struct gdb_symtab) <~gdb_symtab>: Remove.
210 <blocks>: Change type to std::forward_list<gdb_block>.
211 (compare_block): Remove.
212 (jit_block_open_impl): Adjust to std::forward_list. Place the new
213 block at the beginning, don't mind about sorting.
214 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
215 before using it.
216
b6112117
SM		 2172019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
218
219 * jit.c (struct gdb_block): Add constructor, initialize
220 real_block and next fields.
221 <name>: Change type to gdb::unique_xmalloc_ptr.
222 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
223 (jit_block_open_impl): Allocate gdb_block with new.
224 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
225
1b61f46d
SM		 2262019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
227
228 * jit.c: Include forward_list.
229 (struct gdb_symtab) <next>: Remove field.
230 (struct gdb_object) <symtabs>: Change type to
231 std::forward_list<gdb_symtab>.
232 (jit_object_open_impl): Allocate gdb_object with new.
233 (jit_symtab_open_impl): Adjust to std::forward_list.
234 (finalize_symtab): Don't delete symtab.
235 (jit_object_close_impl): Adjust to std::forward_list. Free
236 gdb_object with delete.
237
89867184
SM		 2382019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
239
240 * jit.c (struct gdb_symtab): Add constructor, destructor,
241 initialize fields.
242 <linetable>: Change type to unique_xmalloc_ptr.
243 <file_name>: Change type to std::string.
244 (jit_symtab_open_impl): Allocate gdb_symtab with new.
245 (jit_symtab_line_mapping_add_impl): Adjust.
246 (finalize_symtab): Adjust, call delete on stab.
247
d043f8c8
SM		 2482019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
249
250 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
251
d9fa87f4
TT		 2522019-12-16 Tom Tromey <tromey@adacore.com>
253
254 * windows-nat.c (windows_nat_target::attach): Update.
255 * remote.c (extended_remote_target::attach): Update.
256 * procfs.c (procfs_target::attach): Update.
257 * nto-procfs.c (nto_procfs_target::attach): Update.
258 (nto_procfs_target::create_inferior): Update.
259 * inf-ptrace.c (inf_ptrace_target::attach): Update.
260 * gnu-nat.c (gnu_nat_target::attach): Update.
261 (gnu_nat_target::detach): Update.
262 * darwin-nat.c (darwin_nat_target::attach): Update.
263 * corefile.c (get_exec_file): Constify result. Remove extraneous
264 return.
265 * bsd-kvm.c (bsd_kvm_target_open): Update.
266 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
267
c0c3707f
CB		 2682019-12-16 Christian Biesinger <cbiesinger@google.com>
269
270 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
271 (we no longer need to include time.h before pathmax.h)
272
d3ecddab
CB		 2732019-12-15 Christian Biesinger <cbiesinger@google.com>
274
275 * ada-exp.y (write_ambiguous_var): Update.
276 * coffread.c (process_coff_symbol): Update.
277 * ctfread.c (ctf_add_enum_member_cb): Update.
278 (new_symbol): Update.
279 * dwarf2read.c (fixup_go_packaging): Update.
280 (new_symbol): Update.
281 * language.c (language_alloc_type_symbol): Update.
282 * mdebugread.c (new_symbol): Update.
283 * minsyms.c (minimal_symbol_reader::record_full): Update.
284 * psymtab.c (add_psymbol_to_bcache): Update.
285 * stabsread.c (define_symbol): Update.
286 (read_enum_type): Update.
287 * symtab.c (symbol_set_language): Make this a member function...
288 (general_symbol_info::set_language): ... here.
289 * symtab.h (struct general_symbol_info) <set_language>: New function.
290 (SYMBOL_SET_LANGUAGE): Remove.
291 (symbol_set_language): Remove.
292
c1b5c1eb
CB		 2932019-12-15 Christian Biesinger <cbiesinger@google.com>
294
295 * ada-lang.c (ada_add_block_symbols): Update.
296 (ada_collect_symbol_completion_matches): Update.
297 * ax-gdb.c (gen_expr): Update.
298 * block.c (block_lookup_symbol): Update.
299 (block_lookup_symbol_primary): Update.
300 (block_find_symbol): Update.
301 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
302 * dbxread.c (process_one_symbol): Update.
303 * dictionary.c (insert_symbol_hashed): Update.
304 (collate_pending_symbols_by_language): Update.
305 (mdict_add_symbol): Update.
306 * dwarf-index-write.c (write_psymbols): Update.
307 * dwarf2read.c (fixup_go_packaging): Update.
308 * findvar.c (read_var_value): Update.
309 * ft32-tdep.c (ft32_skip_prologue): Update.
310 * go-lang.c (go_symbol_package_name): Update.
311 * language.h (scoped_switch_to_sym_language_if_auto::
312 scoped_switch_to_sym_language_if_auto): Update.
313 * linespec.c (find_method): Update.
314 (find_label_symbols_in_block): Update.
315 * mdebugread.c (parse_symbol): Update.
316 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
317 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
318 (minimal_symbol_reader::install): Update.
319 * moxie-tdep.c (moxie_skip_prologue): Update.
320 * parse.c (parse_exp_in_context): Update.
321 * psymtab.c (psymbol_name_matches): Update.
322 (match_partial_symbol): Update.
323 (lookup_partial_symbol): Update.
324 (psymbol_hash): Update.
325 (psymbol_compare): Update.
326 * python/py-framefilter.c (extract_sym): Update.
327 (py_print_single_arg): Update.
328 * stabsread.c (define_symbol): Update.
329 * stack.c (print_frame_arg): Update.
330 (find_frame_funname): Update.
331 (info_frame_command_core): Update.
332 * symfile.c (set_initial_language): Update.
333 * symtab.c (symbol_set_demangled_name): Update.
334 (symbol_get_demangled_name): Update.
335 (symbol_set_language): Update.
336 (symbol_find_demangled_name): Update.
337 (symbol_set_names): Update.
338 (general_symbol_info::natural_name): Update.
339 (general_symbol_info::demangled_name): Update.
340 (general_symbol_info::search_name): Update.
341 (symbol_matches_search_name): Update.
342 (eq_symbol_entry): Update.
343 (iterate_over_symbols): Update.
344 (completion_list_add_symbol): Update.
345 (completion_list_add_msymbol): Update.
346 (completion_list_add_fields): Update.
347 * symtab.h (struct general_symbol_info) <language>: New function.
348 <language>: Rename to...
349 <m_language>: ...this.
350 (SYMBOL_LANGUAGE): Remove.
351 (MSYMBOL_LANGUAGE): Remove.
352 (struct symbol) <ctor>: Update.
353 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
354
747cfc8c
CB		 3552019-12-15 Christian Biesinger <cbiesinger@google.com>
356
357 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
358 set the language of sym.
359 * language.c (language_alloc_type_symbol): Likewise.
360
ff8577f6
SDJ		 3612019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
362
363 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
364 PR gdb/23613
365 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
366 * corelow.c: Include 'gdbsupport/pathstuff.h'.
367 (core_target_open): Use 'gdb_abspath'.
368 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
369 'current_directory == NULL' case.
370 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
371 explain what happens when 'current_directory' is NULL.
372 * go32-nat.c (go32_nat_target::wait): Check if
373 'current_directory' is NULL before call to 'chdir'.
374 * source.c (add_path): Use 'gdb_abspath'.
375 * top.c: Include 'gdbsupport/pathstuff.h'.
376 (init_history): Use 'gdb_abspath'.
377 (set_history_filename): Likewise.
378 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
379 (tfile_target_open): Use 'gdb_abspath'.
380
234c3068
TT		 3812019-12-13 Tom Tromey <tromey@adacore.com>
382
383 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
384 warning or error.
385
93537683
TT		 3862019-12-13 Tom Tromey <tromey@adacore.com>
387
388 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
389
63456183
TT		 3902019-12-13 Tom Tromey <tromey@adacore.com>
391
392 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
393
98f9338a
TT		 3942019-12-13 Tom Tromey <tromey@adacore.com>
395
396 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
397
3cb5a3a1
TT		 3982019-12-13 Tom Tromey <tromey@adacore.com>
399
400 * gdbsupport/common-utils.c (string_printf, string_vprintf)
401 (string_vappendf): Add ARI comment.
402
c6cbf900
TT		 4032019-12-13 Tom Tromey <tromey@adacore.com>
404
405 * contrib/ari/gdb_ari.sh: Remove "fix" call for
406 floatformat_to_double.
407 * target-float.c (host_float_ops<T>::from_target): Add ARI
408 comment.
409
036003a6
TT		 4102019-12-13 Tom Tromey <tromey@adacore.com>
411
412 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
413 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
414 ARI marker to abort.
415 * event-top.c (handle_sigsegv): Add ARI marker to abort.
416
8aaaf757
TT		 4172019-12-13 Tom Tromey <tromey@adacore.com>
418
419 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
420
fe56157f
TT		 4212019-12-13 Tom Tromey <tromey@adacore.com>
422
423 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
424
a15a95ed
TT		 4252019-12-13 Tom Tromey <tromey@adacore.com>
426
427 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
428 checks.
429
a5513db2
TT		 4302019-12-13 Tom Tromey <tromey@adacore.com>
431
432 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
433 end>: No longer "const".
434
3a90f266
SM		 4352019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
436
437 * jit.c: Fix indentation, replace spaces with tabs where
438 applicable.
439
b3f4b80f
JL		 4402019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
441
442 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
443
e671856c
TT		 4442019-12-12 Tom Tromey <tom@tromey.com>
445
446 * objfiles.h (struct objfile) <partial_symtabs>: Now a
447 unique_ptr.
448
7d7167ce
TT		 4492019-12-12 Tom Tromey <tom@tromey.com>
450
451 * progspace.h (objfile_list): New typedef.
452 (class unwrapping_objfile_iterator)
453 (struct unwrapping_objfile_range): Newl
454 (struct program_space) <objfiles_range>: Change type.
455 <objfiles>: Change return type.
456 <add_objfile>: Change type of "objfile" parameter.
457 <objfiles_list>: Now a list of shared_ptr.
458 * progspace.c (program_space::add_objfile): Change type of
459 "objfile". Update.
460 (program_space::remove_objfile): Update.
461 * objfiles.h (struct objfile) <~objfile>: Make public.
462 * objfiles.c (objfile::make): Update.
463 (objfile::unlink): Don't call delete.
464
343cc952
TT		 4652019-12-12 Tom Tromey <tom@tromey.com>
466
467 * symfile.c (symbol_file_clear): Update.
468 * progspace.h (struct program_space) <free_all_objfiles>: Declare
469 method.
470 * progspace.c (program_space::free_all_objfiles): New method.
471 * objfiles.h (free_all_objfiles): Don't declare.
472 * objfiles.c (free_all_objfiles): Move to program_space.
473
d0801dd8
TT		 4742019-12-12 Tom Tromey <tom@tromey.com>
475
476 * progspace.c (program_space::add_objfile)
477 (program_space::remove_objfile): Update.
478 (program_space::multi_objfile_p): Remove.
479 * objfiles.h (struct objfile) <next>: Remove.
480 * objfiles.c (objfile::objfile): Update.
481 (put_objfile_before): Update.
482 (unlink_objfile): Update.
483 * progspace.h (object_files): Remove.
484 (struct program_space) <objfiles_head>: Remove.
485 <objfiles_list>: New member.
486 <objfiles_range, objfiles_safe_range>: Change type.
487 (objfiles): Change return type.
488 (objfiles_safe): Update.
489 (multi_objfile_p): Rewrite and inline.
490 (object_files): Remove macro.
491
13bff726
TT		 4922019-12-12 Tom Tromey <tom@tromey.com>
493
494 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
495 second constructor.
496 (basic_safe_range): New class.
497
deeafabb
TT		 4982019-12-12 Tom Tromey <tom@tromey.com>
499
500 * progspace.c (program_space::multi_objfile_p): New method.
501 * printcmd.c (info_symbol_command): Update.
502 * maint.c (maintenance_translate_address): Update.
503 * objfiles.h (MULTI_OBJFILE_P): Remove.
504 * progspace.h (struct program_space) <multi_objfile_p>: New
505 method.
506
23452926
TT		 5072019-12-12 Tom Tromey <tom@tromey.com>
508
509 * progspace.h (struct program_space) <remove_objfile>: Declare.
510 * progspace.c (program_space::remove_objfile): New method.
511 * objfiles.c (unlink_objfile): Remove.
512 (objfile::unlink): Call remove_objfile.
513 (objfile): Don't call unlink_objfile.
514
7cac64af
TT		 5152019-12-12 Tom Tromey <tom@tromey.com>
516
517 * progspace.h (struct program_space) <add_objfile>: Declare
518 method.
519 * progspace.c (program_space::add_objfile): New method.
520 * objfiles.c (~objfile): Don't unlink objfile.
521 (put_objfile_before): Remove.
522 (add_separate_debug_objfile): Don't call put_objfile_before.
523 (objfile::make): Call add_objfile. Set new_objfiles_available on
524 the per-program-space data.
525
268e4f09
TT		 5262019-12-12 Tom Tromey <tom@tromey.com>
527
528 * symfile.c (syms_from_objfile_1): Use objfile_up.
529 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
530 method.
531 (reread_symbols): Use objfile_up.
532 * solib.c (update_solib_list, reload_shared_libraries_1): Call
533 unlink method.
534 * objfiles.h (struct objfile) <~objfile>: Now private.
535 <unlink>: New method.
536 (struct objfile_deleter): New.
537 (objfile_up): New typedef.
538 * objfiles.c (objfile::unlink): New method.
539 (free_objfile_separate_debug, free_all_objfiles)
540 (objfile_purge_solibs): Use it.
541 * jit.c (jit_unregister_code): Remove.
542 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
543 objfile.
544 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
545 objfile.
546 * compile/compile-object-load.c (compile_object_load): Use
547 objfile_up.
548
f65fe570
TT		 5492019-12-12 Tom Tromey <tom@tromey.com>
550
551 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
552 objfile::make.
553 * objfiles.h (struct objjfile) <make>: No longer inline.
554 (add_separate_debug_objfile): Don't declare.
555 * objfiles.c (add_separate_debug_objfile): Now static.
556 (objfile::make): Move from objfiles.h. Call
557 add_separate_debug_objfile. Add "parent" parameter.
558
bda13cdc
TT		 5592019-12-12 Tom Tromey <tom@tromey.com>
560
561 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
562 * objfiles.h (struct objfile): Make constructor private.
563 <make>: New static method.
564 * jit.c (jit_object_close_impl): Update.
565
7190276c
SM		 5662019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
567
568 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
569 gdb::byte_vector.
570
d61df897
TT		 5712019-12-12 Tom Tromey <tromey@adacore.com>
572
573 * xml-support.c (xml_fetch_content_from_file): Don't call
574 malloc_failure.
575 * utils.h (class gdb_argv): Remove malloc_failure comment.
576 * utils.c (gdb_argv::reset): Don't call malloc_failure.
577
db3ad2f0
TT		 5782019-12-12 Tom Tromey <tromey@adacore.com>
579
580 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
581 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
582 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
583 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
584 * riscv-ravenscar-thread.c: New file.
585 * riscv-ravenscar-thread.h: New file.
586 * riscv-tdep.c (riscv_gdbarch_init): Call
587 register_riscv_ravenscar_ops.
588
2ffe5b9c
TT		 5892019-12-12 Tom Tromey <tromey@adacore.com>
590
591 * gdbsupport/thread-pool.c (set_thread_name): Use
592 ATTRIBUTE_UNUSED.
593
39f34d7b
LM		 5942019-12-12 Luis Machado <luis.machado@linaro.org>
595
596 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
597 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
598 macros.
599
d4eeccfe
TT		 6002019-12-11 Tom Tromey <tom@tromey.com>
601
602 * tui/tui-win.c (tui_set_win_height_command): Call
603 tui_adjust_window_height.
604 (tui_adjust_win_heights, new_height_ok): Remove.
605 * tui/tui-layout.h (tui_adjust_window_height): Declare.
606 * tui/tui-layout.c (tui_adjust_window_height): New function.
607
3d979945
TT		 6082019-12-11 Tom Tromey <tom@tromey.com>
609
610 * tui/tui-win.c (tui_resize_all): Remove code, call
611 tui_apply_current_layout.
612
2192a9d3
TT		 6132019-12-11 Tom Tromey <tom@tromey.com>
614
615 * tui/tui-layout.h (tui_apply_current_layout): Declare.
616 * tui/tui-layout.c (standard_layouts, applied_layout): New
617 globals.
618 (tui_apply_current_layout): New function.
619 (show_layout): Set applied_layout. Call
620 tui_apply_current_layout.
621 (show_source_command, show_disasm_command)
622 (show_source_disasm_command, show_data)
623 (show_source_or_disasm_and_command): Remove.
624 (initialize_layouts): New function.
625 (_initialize_tui_layout): Call initialize_layouts.
626
389e7ddb
TT		 6272019-12-11 Tom Tromey <tom@tromey.com>
628
629 * tui/tui-layout.h (class tui_layout_base)
630 (class tui_layout_window, class tui_layout_split): New.
631 * tui/tui-layout.c (tui_get_window_by_name)
632 (tui_layout_window::clone, tui_layout_window::apply)
633 (tui_layout_window::get_sizes, tui_layout_window::add_split)
634 (tui_layout_split::add_window, tui_layout_split::clone)
635 (tui_layout_split::get_sizes)
636 (tui_layout_split::set_weights_from_heights)
637 (tui_layout_split::adjust_size, tui_layout_split::apply): New
638 functions.
639 (tui_layout_split::add_split, tui_layout_split::add_split)
640 (tui_layout_split::set_weights_from_heights)
641 (tui_layout_split::set_weights_from_heights): New functions.
642
fb3184d8
TT		 6432019-12-11 Tom Tromey <tom@tromey.com>
644
645 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
646 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
647 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
648 * tui/tui-data.h (struct tui_point): Remove.
649 (struct tui_gen_win_info) <origin>: Remove.
650 <x, y>: New fields.
651 * tui/tui-command.c (tui_cmd_window::resize): Update.
652
dc7ff8a6
TT		 6532019-12-11 Tom Tromey <tom@tromey.com>
654
655 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
656 Implement.
657 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
658 Implement.
659 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
660 method.
661 (struct tui_win_info) <min_height>: Implement.
662
1431937b
TT		 6632019-12-11 Tom Tromey <tom@tromey.com>
664
665 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
666 (struct tui_win_info) <can_box>: Update.
667
c8ec2f43
TT		 6682019-12-11 Tom Tromey <tom@tromey.com>
669
670 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
671 method.
672 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
673 method.
674 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
675 method.
676 (struct tui_win_info) <max_height>: Now override.
677
4decd62b
JB		 6782019-12-11 Joel Brobecker <brobecker@adacore.com>
679
680 * NEWS: Create a new section for the next release branch.
681 Rename the section of the current branch, now that it has
682 been cut.
683
d746744e
JB		 6842019-12-11 Joel Brobecker <brobecker@adacore.com>
685
686 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
687 * version.in: Bump version to 10.0.50.DATE-git.
688
2e744276
TT		 6892019-12-11 Tom Tromey <tromey@adacore.com>
690
691 PR build/25268:
692 * gdbsupport/thread-pool.c (set_thread_name): New function.
693 (thread_pool::set_thread_count): Don't call pthread_setname_np.
694 (thread_pool::thread_function): Call set_thread_name.
695
aac4760f
TT		 6962019-12-11 Tom Tromey <tromey@adacore.com>
697
698 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
699 bfd_get_signed_8.
700
d8edc8b7
PW		 7012019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
702
703 * NEWS: Document -raw-values option and the related setting commands.
704 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
705 only set it on when /r is given.
706 * valprint.c (value_print_option_defs): New element raw-values.
707 * Makefile.in: Add the new file.
708
cb511130
CB		 7092019-12-10 Christian Biesinger <cbiesinger@google.com>
710
711 * gdbsupport/safe-strerror.c: Supress the unused function warning
712 for select_strerror_r.
713
ab7d13f0
CB		 7142019-12-10 Christian Biesinger <cbiesinger@google.com>
715
716 * config.in: Regenerate.
717 * configure: Regenerate.
718 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
719 safe_strerror instead of strerror.
720 * gdbsupport/common.m4: Don't check for strerror.
721 * gdbsupport/safe-strerror.c: Support both the glibc version
722 of strerror_r and the XSI version.
723
6c71eb7d
TT		 7242019-12-10 Tom Tromey <tromey@adacore.com>
725
726 * ada-typeprint.c (print_choices): Use a single "?".
727 (print_variant_part): Print "?" if the discriminant name
728 is not known.
729
bac7c5cf
GB		 7302019-12-10 George Barrett <bob@bob131.so>
731
732 Fix scripted probe breakpoints.
733 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
734 declaration forward.
735 (breakpoint_ops_for_event_location_type)
736 (breakpoint_ops_for_event_location): Add function definitions.
737 (break_command_1, trace_command): Use
738 breakpoint_ops_for_event_location.
739 * breakpoint.h (breakpoint_ops_for_event_location): Add function
740 declarations.
741 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
742 breakpoint_ops_for_event_location.
743 * python/py-breakpoint.c (bppy_init): Use
744 breakpoint_ops_for_event_location.
745
330f1d38
TBA		 7462019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
747
748 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
749 when ranking an lvalue argument for an rvalue parameter.
750
b1f0c0b9
WA		 7512019-12-08 Wataru Ashihara <wataash@wataash.com>
752
753 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
754 template argument for scoped_restore_tmpl from bool to int.
755
aa2d5a42
KS		 7562019-12-07 Keith Seitz <keiths@redhat.com>
757
758 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
759 (build_id_to_debug_bfd): Make static, rewriting to use
760 build_id_to_bfd_suffix.
761 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
762 adding `suffix' parameter. Append SUFFIX to file names
763 when searching for matching files.
764 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
765 (build_id_to_exec_bfd): Likewise.
766 * build-id.h (build_id_to_debug_bfd): Clarify that function
767 searches for BFD of debug info file.
768 (build_id_to_exec_bfd): Declare.
769 * corelow.c: Include build-id.h.
770 (locate_exec_from_corefile_build_id): New function.
771 (core_target_open): If no executable BFD is found,
772 search for a core file BFD using build-id.
773
dfb65191
CB		 7742019-12-06 Christian Biesinger <cbiesinger@google.com>
775
776 * bcache.c: Put in namespace gdb.
777 * bcache.h: Likewise.
778 * gdbtypes.c (check_types_worklist): Update.
779 (types_deeply_equal): Update.
780 * macrotab.c (struct macro_table) <bcache>: Update.
781 (new_macro_table): Update.
782 * macrotab.h (struct bcache): Put this forward declaration
783 inside namespace gdb.
784 (new_macro_table): Update.
785 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
786 Update.
787 <macro_cache>: Update.
788 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
789
93e55f0a
TV		 7902019-12-06 Tom de Vries <tdevries@suse.de>
791
792 PR symtab/24971
793 * block.c (best_symbol, better_symbol): New function.
794 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
795 decl.
796
06acc08f
TBA		 7972019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
798
799 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
800 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
801 for ranking see-through reference cases.
802
e0fad1ea
PW		 8032019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
804 * stack.c (faas_command): Check a command is provided.
805 * thread.c (taas_command, tfaas_command): Likewise.
806
908641f5
PW		 8072019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
808 * inferior.c (prune_inferiors): Only call delete_inferior,
809 Do not modify the inferior list.
810
b858499d
SM		 8112019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
812
813 * c-exp.y: Update calls to lookup_typename,
814 lookup_signed_typename and lookup_unsigned_typename.
815 * c-lang.c (evaluate_subexp_c): Likewise.
816 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
817 Likewise.
818 * eval.c (binop_promote): Likewise.
819 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
820 (lookup_unsigned_typename): Likewise.
821 (lookup_signed_typename): Likewise.
822 * gdbtypes.h (lookup_unsigned_typename): Likewise.
823 (lookup_signed_typename): Likewise.
824 (lookup_typename): Likewise.
825 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
826 lookup_typename, lookup_signed_typename,
827 lookup_unsigned_typename.
828 * m2-exp.y: Likewise.
829 * printcmd.c (printf_wide_c_string): Likewise.
830 (ui_printf): Likewise.
831 * python/py-type.c (typy_lookup_typename): Likewise.
832 * python/py-xmethods.c (python_xmethod_worker::invoke):
833 Likewise.
834 * rust-exp.y: Likewise.
835
3a8fa228
CB		 8362019-12-04 Christian Biesinger <cbiesinger@google.com>
837
838 * configure.nat (obsd64): Add missing files x86-nat.o and
839 nat/x86-dregs.o.
840
2dbc041e
TT		 8412019-12-04 Tom Tromey <tom@tromey.com>
842
843 * valprint.c (val_print_string): Use metadata_style.
844 * go-valprint.c (print_go_string): Use metadata style.
845 * p-valprint.c (pascal_object_print_static_field): Use metadata
846 style.
847 * cp-valprint.c (cp_print_static_field): Use metadata style.
848
36c8fb93
AB		 8492019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
850 Chris January <chris.january@arm.com>
851
852 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
853 tokens.
854 (typebase): New patterns for complex, single/double precision, and
855 single/double complex.
856 (f77_keywords): Change token for complex keyword, and add single,
857 double, and precision keywords.
858
c6170c2c
SM		 8592019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
860
861 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
862 "info io_registers".
863
894ecaf4
SM		 8642019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
865
866 * regcache.c (cooked_read_test): Initialize thread list of
867 mock_inferior.
868
be155ebb
SM		 8692019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
870
871 * aarch64-linux-tdep.c: Remove includes.
872
c577cdd7
SM		 8732019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
874
875 * aarch64-tdep.c: Remove includes.
876
610cfd61
SM		 8772019-12-04 Simon Marchi <simon.marchi@efficios.com>
878
879 * filtered-iterator.h (filtered_iterator) <operator==,
880 operator!=>: Compare wrapped iterators, not wrapped pointers.
881 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
882 unittests/filtered_iterator-selftests.c.
883 * unittests/filtered_iterator-selftests.c: New file.
884
a05cf17a
TT		 8852019-12-04 Tom Tromey <tromey@adacore.com>
886
887 * gdbtypes.c (create_range_type): Inherit endianity
888 from base type.
889
d5a22e77
TT		 8902019-12-04 Tom Tromey <tromey@adacore.com>
891
892 * ada-lang.c (decode_constrained_packed_array)
893 (ada_value_assign, value_assign_to_component): Update.
894 * dwarf2loc.c (rw_pieced_value, access_memory)
895 (dwarf2_compile_expr_to_ax): Update.
896 * dwarf2read.c (dwarf2_add_field): Update.
897 * eval.c (evaluate_subexp_standard): Update.
898 * gdbarch.c, gdbarch.h: Rebuild.
899 * gdbarch.sh (bits_big_endian): Remove.
900 * gdbtypes.h (union field_location): Update comment.
901 * target-descriptions.c (make_gdb_type): Update.
902 * valarith.c (value_bit_index): Update.
903 * value.c (struct value) <bitpos>: Update comment.
904 (unpack_bits_as_long, modify_field): Update.
905 * value.h (value_bitpos): Update comment.
906
7ab4a236
TT		 9072019-12-04 Tom Tromey <tromey@adacore.com>
908
909 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
910 endian-ness.
911
103a685e
TT		 9122019-12-04 Tom Tromey <tromey@adacore.com>
913
914 * dwarf2read.c (dwarf2_init_float_type)
915 (dwarf2_init_complex_target_type): Add byte_order parameter.
916 (read_base_type): Compute byte order earlier.
917 * gdbtypes.c (init_float_type): Add byte_order parameter.
918 * gdbtypes.h (init_float_type): Add byte_order parameter.
919
7a9e9f9f
TT		 9202019-12-04 Tom Tromey <tromey@adacore.com>
921
922 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
923
feee869b
TT		 9242019-12-04 Tom Tromey <tromey@adacore.com>
925
926 * dwarf2read.c (process_structure_scope): Initialize
927 "discr_offset".
928
c2512106
AB		 9292019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
930
931 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
932 add it into the search spec.
933 (parse_max_results_option): New function.
934 (mi_info_functions_or_variables): Parse -max-results flag and pass
935 it to mi_symbol_info.
936 (mi_cmd_symbol_info_modules): Likewise.
937 (mi_cmd_symbol_info_types): Likewise.
938 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
939 return type to bool, change result container into a set, and don't
940 add new results if we have enough already.
941 (global_symbol_searcher::add_matching_msymbols): Change return
942 type to bool, and don't add new results if we have enough already.
943 (sort_search_symbols_remove_dups): Delete.
944 (global_symbol_searcher::search): Early exit from search loop when
945 we have enough results. Use a std::set to collect the results
946 from calling add_matching_symbols.
947 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
948 member function.
949 (global_symbol_searcher) <m_max_search_results>: New member
950 variable.
951 (global_symbol_searcher) <add_matching_symbols>: Update header
952 comment and change return type to bool.
953 (global_symbol_searcher) <add_matching_msymbols>: Update header
954 comment and change return type to bool.
955
f97a63c5
AB		 9562019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
957
958 * symtab.c (symbol_search::compare_search_syms): Update header
959 comment.
960 (global_symbol_searcher::is_suitable_msymbol): New function.
961 (global_symbol_searcher::expand_symtabs): New function.
962 (global_symbol_searcher::add_matching_symbols): New function.
963 (global_symbol_searcher::add_matching_msymbols): New function.
964 (global_symbol_searcher::search): Move most of the content
965 into the new functions above, and call them as needed.
966 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
967 function.
968 (global_symbol_searcher) <add_matching_symbols>: New member
969 function.
970 (global_symbol_searcher) <add_matching_msymbols>: New member
971 function.
972 (global_symbol_searcher) <is_suitable_msymbol>: New member
973 function.
974
293b38d6
AB		 9752019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
976
977 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
978 -symbol-info-module-variables entries.
979 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
980 (mi_cmd_symbol_info_module_variables): Declare.
981 * mi/mi-symbol-cmds.c
982 (module_symbol_search_iterator): New typedef.
983 (output_module_symbols_in_single_module_and_file): New function.
984 (output_module_symbols_in_single_module): New function.
985 (mi_info_module_functions_or_variables): New function.
986 (mi_cmd_symbol_info_module_functions): New function.
987 (mi_cmd_symbol_info_module_variables): New function.
988 * NEWS: Mention new MI command.
989
4cbd39b2
CB		 9902019-12-03 Christian Biesinger <cbiesinger@google.com>
991
992 * bcache.c (hash): Remove.
993 (hash_continue): Remove.
994 * bcache.h (hash): Remove.
995 (hash_continue): Remove.
996 (struct bcache) <ctor>: Update.
997 * psymtab.c (psymbol_hash): Update.
998 * stabsread.c (hashname): Update.
999 * utils.h (fast_hash): Add an argument for a start value,
1000 defaulting to zero.
1001
82f910ea
PW		 10022019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1003 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1004 (destroy_block_symbol_cache): New function.
1005 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1006 (resize_symbol_cache): Likewise.
1007
de2396d0
TT		 10082019-12-02 Tom Tromey <tom@tromey.com>
1009
1010 * unittests/tui-selftests.c (run_tests): Make conditional.
1011 (_initialize_tui_selftest): Make conditional.
1012
638d85bc
CB		 10132019-12-02 Christian Biesinger <cbiesinger@google.com>
1014
1015 * aix-thread.c (debug_aix_thread): Change type to bool.
1016
7532a164
LM		 10172019-12-02 Luis Machado <luis.machado@linaro.org>
1018
1019 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1020
216a7e6b
AB		 10212019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1022
1023 * dwarf2read.c (read_tag_string_type): Read the fields required to
1024 make a dynamic string, and possibly create a dynamic range for the
1025 string.
1026 (attr_to_dynamic_prop): Setup is_reference based on the type of
1027 attribute being processed.
1028 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1029 (resolve_dynamic_array): Rename to...
1030 (resolve_dynamic_array_or_string): ...this, update header comment,
1031 and accept TYPE_CODE_STRING.
1032 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1033
11a8b164
AB		 10342019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1035
1036 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1037 of its implementation from...
1038 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1039 the new function.
1040
5bbd8269
AB		 10412019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1042
1043 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1044 create a range with stride where appropriate.
1045 * f-valprint.c: Include 'gdbarch.h'.
1046 (f77_print_array_1): Take the stride into account when walking the
1047 array. Also convert the stride into addressable units.
1048 * gdbtypes.c (create_range_type): Initialise the stride to
1049 constant zero.
1050 (create_range_type_with_stride): New function, initialise the
1051 range as normal, and then setup the stride.
1052 (has_static_range): Include the stride here. Also change the
1053 return type to bool.
1054 (create_array_type_with_stride): Consider the range stride if the
1055 array isn't given its own stride.
1056 (resolve_dynamic_range): Resolve the stride if needed.
1057 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1058 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1059 (TYPE_BIT_STRIDE): Define.
1060 (TYPE_ARRAY_BIT_STRIDE): Define.
1061 (create_range_type_with_stride): Declare.
1062 * valarith.c (value_subscripted_rvalue): Take range stride into
1063 account when walking the array.
1064
82e3b564
TT		 10652019-12-01 Tom Tromey <tom@tromey.com>
1066
1067 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1068 specially.
1069
517d261d
TT		 10702019-12-01 Tom Tromey <tom@tromey.com>
1071
1072 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1073 \0.
1074 * unittests/tui-selftests.c: New file.
1075 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1076
484c9b64
TT		 10772019-12-01 Tom Tromey <tom@tromey.com>
1078
1079 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1080
a2a7af0c
TT		 10812019-12-01 Tom Tromey <tom@tromey.com>
1082
1083 * NEWS: Document new settings.
1084 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1085 * tui/tui-win.c (_initialize_tui_win): Add border style
1086 observers.
1087 * tui/tui-io.h (tui_apply_style): Declare.
1088 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1089 longer static.
1090 (apply_ansi_escape, tui_set_reverse_mode): Update.
1091 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1092 Add "skip_intensity" parameter.
1093 <changed>: New member.
1094 <do_set_value>: Declare.
1095 (tui_border_style, tui_active_border_style): Declare.
1096 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1097 globals.
1098 (cli_style_option): Initialize "changed".
1099 (cli_style_option::do_set_value): New function.
1100 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1101 parameter. Update.
1102 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1103 (_initialize_cli_style): Update. Create TUI border style
1104 commands.
1105
d1da6b01
TT		 11062019-12-01 Tom Tromey <tom@tromey.com>
1107
1108 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1109 parameter.
1110 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1111 parameter.
1112 * tui/tui-win.h (compact_source): Declare.
1113 * tui/tui-win.c (compact_source): New global.
1114 (tui_set_compact_source, tui_show_compact_source): New functions.
1115 (_initialize_tui_win): Add "compact-source" setting.
1116 * tui/tui-source.c (tui_source_window::set_contents): Handle
1117 compact_source setting.
1118 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1119 * NEWS: Document new setting.
1120
489dbda6
TT		 11212019-11-30 Tom Tromey <tom@tromey.com>
1122
1123 * dwarf2read.c (dwarf2_add_field): Include field offset when
1124 computing variant part length.
1125
bf498525
PW		 11262019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1127 * NEWS: Mention define-prefix. Tell that command names can now
1128 contain a . character.
1129
be09caf1
PW		 11302019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1131
1132 * command.h (valid_cmd_char_p): Declare.
1133 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1134 the check of valid command char.
1135 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1136 valid_cmd_char_p.
1137 * cli/cli-script.c (validate_comname): Likewise.
1138 * completer.c (gdb_completer_command_word_break_characters):
1139 Do not remove . from the word break char, update comments.
1140 (complete_line_internal_1): Use valid_cmd_char_p.
1141 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1142 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1143
c6ac7fc9
PW		 11442019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1145
1146 * cli/cli-script.c (do_define_command): Ensure a redefined
1147 prefix command is kept as a prefix command.
1148 (define_prefix_command): New function.
1149 (show_user_1): Report user defined prefixes.
1150 (_initialize_cli_script): Create the new 'define-prefix' command.
1151 Add completers for 'define' and 'document'.
1152 * top.c (execute_command): If command is a user-defined prefix only
1153 command, report the list of commands for this prefix command.
1154
a992a3b0
TBA		 11552019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1156
1157 * valops.c (find_oload_champ): Improve debug output.
1158
e9194a1a
TBA		 11592019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1160
1161 * valops.c (find_oload_champ): Print part of debug messages
1162 before the badness vector is std::move'd.
1163
53a008a6
TT		 11642019-11-28 Tom Tromey <tom@tromey.com>
1165
1166 * value.c (creal_internal_fn): Fix comment.
1167
bab05c83
TT		 11682019-11-28 Tom Tromey <tom@tromey.com>
1169
1170 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1171 flag_bound_evaluated>: Now unsigned.
1172
2522f049
TT		 11732019-11-28 Tom Tromey <tom@tromey.com>
1174
1175 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1176 declare.
1177
38b49e22
MS		 11782019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1179
1180 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1181 debug output.
1182 * jit.c (jit_unregister_code): Add debug print to match
1183 `jit_register_code`.
1184
35125921
CB		 11852019-11-27 Christian Biesinger <cbiesinger@google.com>
1186
1187 * NEWS: Mention the new multithreaded symbol loading.
1188
62e77f56
CB		 11892019-11-27 Christian Biesinger <cbiesinger@google.com>
1190
1191 * maint.c (n_worker_threads): Default to 0.
1192 (worker_threads_disabled): New function.
1193 * maint.h (worker_threads_disabled): New function.
1194 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1195 here if worker_threads_disabled () is true.
1196 (minimal_symbol_reader::install): Skip all threading if
1197 worker_threads_disabled () is true.
1198
f29d7f6b
CB		 11992019-11-27 Christian Biesinger <cbiesinger@google.com>
1200
1201 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1202 hash code if possible.
1203 (add_minsym_to_demangled_hash_table): Likewise.
1204 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1205 on the background thread.
1206 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1207 Add these fields.
1208
e76b2246
CB		 12092019-11-27 Christian Biesinger <cbiesinger@google.com>
1210
1211 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1212 of the mangled name on the background thread.
1213 * symtab.c (symbol_set_names): Allow passing in the hash of the
1214 linkage_name.
1215 * symtab.h (symbol_set_names): Likewise.
1216
8d9a2568
KB		 12172019-11-27 Kevin Buettner <kevinb@redhat.com>
1218
1219 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1220 physnames are computed for inherited DIEs.
1221
fad03f6e
TT		 12222019-11-27 Tom Tromey <tromey@adacore.com>
1223
1224 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1225 backslashes.
1226 * cp-support.c: Remove unnecessary backslashes.
1227
43678b0a
CB		 12282019-11-27 Christian Biesinger <cbiesinger@google.com>
1229
1230 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1231 with sym->set_linkage_name.
1232 * coffread.c (coff_read_enum_type): Likewise.
1233 * mdebugread.c (parse_symbol): Likewise.
1234 * stabsread.c (patch_block_stabs): Likewise.
1235 (define_symbol): Likewise.
1236 (read_enum_type): Likewise.
1237 (common_block_end): Likewise.
1238 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1239 function.
1240 (SYMBOL_SET_LINKAGE_NAME): Remove.
1241 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1242 with sym->set_linkage_name.
1243
db5960b4
AB		 12442019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1245
1246 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1247 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1248 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1249 * NEWS: Mention new MI command.
1250
7dc42066
AB		 12512019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1252
1253 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1254 '-symbol-info-types', and '-symbol-info-variables'.
1255 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1256 (mi_cmd_symbol_info_types): Declare.
1257 (mi_cmd_symbol_info_variables): Declare.
1258 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1259 (output_debug_symbol): New function.
1260 (output_nondebug_symbol): New function.
1261 (mi_symbol_info): New function.
1262 (mi_info_functions_or_variables): New function.
1263 (mi_cmd_symbol_info_functions): New function.
1264 (mi_cmd_symbol_info_types): New function.
1265 (mi_cmd_symbol_info_variables): New function.
1266 * NEWS: Mention new commands.
1267
5f512a7d
AB		 12682019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1269
1270 * symtab.c (symbol_to_info_string): New function, most content
1271 moved from print_symbol_info, but updated to return a std::string.
1272 (print_symbol_info): Update to use symbol_to_info_string and print
1273 returned string.
1274 * symtab.h (symbol_to_info_string): Declare new function.
1275
470c0b1c
AB		 12762019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1277
1278 * python/python.c (gdbpy_rbreak): Convert to using
1279 global_symbol_searcher.
1280 * symtab.c (file_matches): Convert return type to bool, change
1281 file list to std::vector, update header comment.
1282 (search_symbols): Rename to...
1283 (global_symbol_searcher::search): ...this and update now its
1284 a member function of global_symbol_searcher. Take account of the
1285 changes to file_matches.
1286 (symtab_symbol_info): Convert to using global_symbol_searcher.
1287 (rbreak_command): Likewise.
1288 (search_module_symbols): Likewise.
1289 * symtab.h (enum symbol_search): Update comment.
1290 (search_symbols): Remove declaration.
1291 (class global_symbol_searcher): New class.
1292
57357d9d
TT		 12932019-11-26 Tom Tromey <tromey@adacore.com>
1294
1295 * cp-support.c (_initialize_cp_support): Conditionally initialize
1296 gdb_demangle_attempt_core_dump.
1297
3ea16160
TT		 12982019-11-26 Tom Tromey <tom@tromey.com>
1299
1300 * python/py-function.c (fnpy_init): Update.
1301 * value.h (add_internal_function): Adjust declaration.
1302 * value.c (function_destroyer): Remove.
1303 (do_add_internal_function): Don't set destroyer or copy name.
1304 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1305 Set name_allocated.
1306 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1307 (cmdpy_init): Set name_allocated.
1308 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1309 member.
1310 (~cmd_list_element): Free "name" if needed.
1311
1a6d41c6
TT		 13122019-11-26 Tom Tromey <tom@tromey.com>
1313
1314 * value.h (add_internal_function): Add new overload. Move
1315 documentation from value.h.
1316 * value.c (do_add_internal_function): New function.
1317 (add_internal_function): Use it. Add new overload.
1318 (function_destroyer): Don't free doc.
1319 * python/py-function.c (fnpy_init): Update.
1320
8318f3c3
TT		 13212019-11-26 Tom Tromey <tom@tromey.com>
1322
1323 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1324 (cmdpy_init): Set "doc_allocated".
1325
4da8c3a8
TT		 13262019-11-26 Tom Tromey <tom@tromey.com>
1327
1328 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1329 name of worker thread.
1330 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1331 pthread_setname_np.
1332 * configure, config.in: Rebuild.
1333
971db5e2
TT		 13342019-11-26 Tom Tromey <tom@tromey.com>
1335
1336 * python/python.c (class gdbpy_gil): New.
1337 (struct gdbpy_event): Add constructor, destructor, operator().
1338 (gdbpy_post_event): Use run_on_main_thread.
1339 (gdbpy_initialize_events): Remove.
1340 (do_start_initialization): Update.
1341
22138db6
TT		 13422019-11-26 Tom Tromey <tom@tromey.com>
1343
1344 * NEWS: Add entry.
1345 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1346 commands. Call update_thread_pool_size.
1347 (update_thread_pool_size, maintenance_set_worker_threads): New
1348 functions.
1349 (n_worker_threads): New global.
1350
d55c9a68
TT		 13512019-11-26 Christian Biesinger <cbiesinger@google.com>
1352 Tom Tromey <tom@tromey.com>
1353
1354 * minsyms.c (minimal_symbol_reader::install): Use
1355 parallel_for_each.
1356 * gdbsupport/parallel-for.h: New file.
1357 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1358
a0b57563
CB		 13592019-11-26 Christian Biesinger <cbiesinger@google.com>
1360 Tom Tromey <tom@tromey.com>
1361
1362 * gdbsupport/thread-pool.h: New file.
1363 * gdbsupport/thread-pool.c: New file.
1364 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1365 (HFILES_NO_SRCDIR): Add thread-pool.h.
1366
3b3978bc
TT		 13672019-11-26 Tom Tromey <tom@tromey.com>
1368
1369 * event-top.h (thread_local_segv_handler): Declare.
1370 * event-top.c (thread_local_segv_handler): New global.
1371 (install_handle_sigsegv, handle_sigsegv): New functions.
1372 (async_init_signals): Install SIGSEGV handler.
1373 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1374 thread-local.
1375 (report_failed_demangle): New function.
1376 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1377 handler-setting code, instead use segv_handler. Run warning code
1378 on main thread.
1379
9411c49e
TT		 13802019-11-26 Tom Tromey <tom@tromey.com>
1381
1382 * run-on-main-thread.c: New file.
1383 * run-on-main-thread.h: New file.
1384 * unittests/main-thread-selftests.c: New file.
1385 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1386 main-thread-selftests.c.
1387 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1388 (COMMON_SFILES): Add run-on-main-thread.c.
1389
c3efb965
TT		 13902019-11-26 Tom Tromey <tom@tromey.com>
1391
1392 * main.c (setup_alternate_signal_stack): Remove.
1393 (captured_main_1): Use gdb::alternate_signal_stack.
1394 * gdbsupport/alt-stack.h: New file.
1395
21987b9c
TT		 13962019-11-26 Tom Tromey <tom@tromey.com>
1397
1398 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1399 Remove comment.
1400 (save_original_signals_state, restore_original_signals_state): Use
1401 gdb_sigmask.
1402 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1403 (_initialize_linux_nat): Use gdb_sigmask.
1404 * guile/guile.c (_initialize_guile): Use block_signals.
1405 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1406 * gdbsupport/gdb-sigmask.h: New file.
1407 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1408 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1409 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1410 pthread_sigmask.
1411 * configure, config.in: Rebuild.
1412 * gdbsupport/block-signals.h: New file.
1413
5e030278
TT		 14142019-11-26 Tom Tromey <tom@tromey.com>
1415
1416 * acinclude.m4: Include ax_pthread.m4.
1417 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1418 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1419 (CLIBS): Use PTHREAD_LIBS.
1420 (aclocal_m4_deps): Add ax_pthread.m4.
1421 * config.in, configure: Rebuild.
1422 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1423
5a79c107
TT		 14242019-11-26 Tom Tromey <tom@tromey.com>
1425
1426 * symtab.h (struct minimal_symbol) <name_set>: New member.
1427 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1428 Don't call symbol_set_names.
1429 (minimal_symbol_reader::install): Call symbol_set_names.
1430
aa369509
PW		 14312019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1432
1433 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1434 restore_active_ext_lang, as GIL is needed for (indirectly)
1435 called PyOS_InterruptOccurred.
1436
cadc9cb8
SM		 14372019-11-26 Simon Marchi <simon.marchi@efficios.com>
1438
1439 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1440 definition.
1441
d04afd58
SM		 14422019-11-26 Simon Marchi <simon.marchi@efficios.com>
1443
1444 * remote-sim.c (simulator_command): Make static, remove
1445 declaration.
1446
dd694d77
SM		 14472019-11-26 Simon Marchi <simon.marchi@efficios.com>
1448
1449 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1450 static.
1451 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1452 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1453 (main): Likewise.
1454 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1455 (main): Likewise.
1456 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1457 (main): Likewise.
1458 * unittests/basic_string_view/element_access/char/1.cc (test01):
1459 Likewise.
1460 (main): Likewise.
1461 * unittests/basic_string_view/element_access/char/empty.cc (main):
1462 Likewise.
1463 * unittests/basic_string_view/element_access/char/front_back.cc
1464 (test01): Likewise.
1465 (main): Likewise.
1466 * unittests/basic_string_view/inserters/char/2.cc (test05):
1467 Likewise.
1468 (main): Likewise.
1469 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1470 (test01): Likewise.
1471 (main): Likewise.
1472 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1473 (test01): Likewise.
1474 (main): Likewise.
1475 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1476 Likewise.
1477 * unittests/basic_string_view/operations/compare/char/1.cc
1478 (test01): Likewise.
1479 (main): Likewise.
1480 * unittests/basic_string_view/operations/compare/char/13650.cc
1481 (test01): Likewise.
1482 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1483 Likewise.
1484 (main): Likewise.
1485 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1486 Likewise.
1487 (main): Likewise.
1488 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1489 Likewise.
1490 (main): Likewise.
1491 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1492 Likewise.
1493 (main): Likewise.
1494 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1495 Likewise.
1496 (main): Likewise.
1497 * unittests/basic_string_view/operations/find/char/4.cc (main):
1498 Likewise.
1499 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1500 Likewise.
1501 (main): Likewise.
1502 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1503 Likewise.
1504 (main): Likewise.
1505 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1506 Likewise.
1507 (main): Likewise.
1508 * unittests/basic_string_view/operations/substr/char/1.cc
1509 (test01): Likewise.
1510 (main): Likewise.
1511 * unittests/basic_string_view/operators/char/2.cc (main):
1512 Likewise.
1513 * unittests/optional/assignment/1.cc (test): Likewise.
1514 * unittests/optional/assignment/2.cc (test): Likewise.
1515 * unittests/optional/assignment/3.cc (test): Likewise.
1516 * unittests/optional/assignment/4.cc (test): Likewise.
1517 * unittests/optional/assignment/5.cc (test): Likewise.
1518 * unittests/optional/assignment/6.cc (test): Likewise.
1519 * unittests/optional/assignment/7.cc (test): Likewise.
1520 * unittests/optional/cons/copy.cc (test): Likewise.
1521 * unittests/optional/cons/default.cc (test): Likewise.
1522 * unittests/optional/cons/move.cc (test): Likewise.
1523 * unittests/optional/cons/value.cc (test): Likewise.
1524 * unittests/optional/in_place.cc (test): Likewise.
1525 * unittests/optional/observers/1.cc (test): Likewise.
1526 * unittests/optional/observers/2.cc (test): Likewise.
1527
3b5c1d49
SM		 15282019-11-26 Simon Marchi <simon.marchi@efficios.com>
1529
1530 * tui-win.h (tui_set_var_cmd): Remove.
1531 * tui-win.c (tui_set_var_cmd): Make static.
1532
adce99fe
SM		 15332019-11-26 Simon Marchi <simon.marchi@efficios.com>
1534
1535 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1536 rbreak_command_wrapper): Remove.
1537 * symtab.c (rbreak_command_wrapper): Remove.
1538
fe3adccf
SM		 15392019-11-26 Simon Marchi <simon.marchi@efficios.com>
1540
1541 * inferior.h (info_terminal_command): Remove declaration.
1542 * inflow.c (info_terminal_command): Make static.
1543
b926335f
SM		 15442019-11-26 Simon Marchi <simon.marchi@efficios.com>
1545
1546 * inferior.c (exit_inferior_silent): Remove.
1547
b62f6f54
SM		 15482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1549
1550 * dictionary.c (dict_empty, mdict_empty): Remove.
1551 * dictionary.c (mdict_empty): Remove.
1552
cb8c24b6
SM		 15532019-11-26 Simon Marchi <simon.marchi@efficios.com>
1554
1555 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1556 (arc_insn_get_memory_offset): Likewise.
1557 (arc_insn_dump): Likewise.
1558 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1559 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1560 * dictionary.c (dict_iterator_next): Likewise.
1561 (dict_iter_match_first): Likewise.
1562 (dict_iter_match_next): Likewise.
1563 * f-lang.c (evaluate_subexp_f): Likewise.
1564 * hppa-tdep.c (hppa_read_pc): Likewise.
1565 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1566 * parse.c (write_exp_elt_msym): Likewise.
1567 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1568 * remote.c (remote_packet_size): Likewise.
1569 (remote_notif_stop_parse): Likewise.
1570 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1571 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1572 * source.c (prepare_path_for_appending): Likewise.
1573 * sparc64-linux-tdep.c
1574 (sparc64_linux_handle_segmentation_fault); Likewise.
1575 * stack.c (frame_selection_by_function_completer): Likewise.
1576
781597ff
SM		 15772019-11-26 Simon Marchi <simon.marchi@efficios.com>
1578
1579 * completer.c (set_gdb_completion_word_break_characters):
1580 Remove.
1581
23baa4cc
SM		 15822019-11-26 Simon Marchi <simon.marchi@efficios.com>
1583
1584 * dwarf-index-write.c: Include dwarf-index-write.h.
1585 * mi/mi-interp.c: Include mi/mi-interp.h.
1586
23767560
SM		 15872019-11-26 Simon Marchi <simon.marchi@efficios.com>
1588
1589 * aarch32-tdep.c: Include aarch32-tdep.h.
1590 * aarch32-tdep.h: Forward-declare struct target_desc.
1591
6d91ce9a
CB		 15922019-11-26 Christian Biesinger <cbiesinger@google.com>
1593
1594 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1595 strerror.
1596 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1597 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1598
3cf2f237
TV		 15992019-11-25 Tom de Vries <tdevries@suse.de>
1600
1601 * contrib/words.sh: Add -c option.
1602
5b89c67a
CB		 16032019-11-25 Christian Biesinger <cbiesinger@google.com>
1604
1605 * solib.c (solib_find_1): Change int to bool.
1606 (exec_file_find): Change int to bool.
1607 (solib_find): Change int to bool.
1608 (solib_read_symbols): Change int to bool.
1609 (solib_used): Change int to bool.
1610 (solib_add): Change int to bool.
1611 (info_sharedlibrary_command): Change int to bool.
1612 (solib_contains_address_p): Change int to bool.
1613 (solib_keep_data_in_core): Change int to bool.
1614 (in_solib_dynsym_resolve_code): Change int to bool.
1615 (reload_shared_libraries_1): Change int to bool.
1616 (gdb_sysroot_changed): Change int to bool.
1617 * solib.h (solib_read_symbols): Change int to bool.
1618 (solib_contains_address_p): Change int to bool.
1619 (solib_keep_data_in_core): Change int to bool.
1620 (in_solib_dynsym_resolve_code): Change int to bool.
1621 (libpthread_name_p): Change int to bool.
1622
6cc8564b
LM		 16232019-11-25 Luis Machado <luis.machado@linaro.org>
1624
1625 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1626 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1627 (remote_packet_max_chars): New static global.
1628 (show_remote_packet_max_chars): New function.
1629 (remote_target::putpkt_binary): Adjust to use new
1630 remote_packet_max_chars option.
1631 (remote_target::getpkt_or_notif_sane_1): Likewise.
1632 (_initialize_remote): Register new remote-packet-max-chars option.
1633
a7cdaa91
SM		 16342019-11-24 Simon Marchi <simon.marchi@efficios.com>
1635
1636 * m68k-linux-nat.c: Include gdbarch.h.
1637
26abc753
TT		 16382019-11-24 Tom Tromey <tom@tromey.com>
1639
1640 * symfile.c (read_symbols): Update.
1641 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1642 bool.
1643 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1644 (psym_lookup_symbol, psym_find_last_source_symtab)
1645 (psym_forget_cached_source_info, psym_print_stats)
1646 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1647 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1648 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1649 (psym_find_compunit_symtab_by_address)
1650 (maintenance_print_psymbols, maintenance_info_psymtabs)
1651 (maintenance_check_psymtabs): Update.
1652 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1653 bool.
1654
012fc909
TT		 16552019-11-22 Tom Tromey <tom@tromey.com>
1656
1657 * observable.h: Update comments.
1658
c83d8d32
TT		 16592019-11-22 Tom Tromey <tromey@adacore.com>
1660
1661 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1662 (print_ada_task_info): Don't try to fetch thread id if task is not
1663 alive.
1664
987012b8
CB		 16652019-11-22 Christian Biesinger <cbiesinger@google.com>
1666
1667 * ada-exp.y: Update.
1668 * ada-lang.c (sort_choices): Update.
1669 (ada_print_symbol_signature): Update.
1670 (resolve_subexp): Update.
1671 (ada_parse_renaming): Update.
1672 (ada_read_renaming_var_value): Update.
1673 (lesseq_defined_than): Update.
1674 (remove_extra_symbols): Update.
1675 (remove_irrelevant_renamings): Update.
1676 (ada_add_block_symbols): Update.
1677 (ada_collect_symbol_completion_matches): Update.
1678 (ada_is_renaming_symbol): Update.
1679 (aggregate_assign_from_choices): Update.
1680 (ada_evaluate_subexp): Update.
1681 (ada_has_this_exception_support): Update.
1682 (ada_is_non_standard_exception_sym): Update.
1683 (ada_add_exceptions_from_frame): Update.
1684 (ada_add_global_exceptions): Update.
1685 (ada_print_subexp): Update.
1686 * ax-gdb.c (gen_var_ref): Update.
1687 (gen_maybe_namespace_elt): Update.
1688 (gen_expr_for_cast): Update.
1689 (gen_expr): Update.
1690 * block.h: Update.
1691 * blockframe.c (find_pc_partial_function): Update.
1692 * breakpoint.c (print_breakpoint_location): Update.
1693 (update_static_tracepoint): Update.
1694 * btrace.c (ftrace_print_function_name): Update.
1695 (ftrace_function_switched): Update.
1696 * buildsym.c (find_symbol_in_list): Update.
1697 * c-exp.y: Update.
1698 * c-typeprint.c (c_print_typedef): Update.
1699 (c_type_print_template_args): Update.
1700 * cli/cli-cmds.c (edit_command): Update.
1701 (list_command): Update.
1702 (print_sal_location): Update.
1703 * coffread.c (patch_opaque_types): Update.
1704 (process_coff_symbol): Update.
1705 (coff_read_enum_type): Update.
1706 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1707 (convert_one_symbol): Update.
1708 (hash_symname): Update.
1709 (eq_symname): Update.
1710 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1711 * compile/compile-cplus-types.c (debug_print_scope): Update.
1712 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1713 * compile/compile-object-load.c (get_out_value_type): Update.
1714 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1715 (search_symbol_list): Update.
1716 (cp_lookup_symbol_imports_or_template): Update.
1717 * cp-support.c (overload_list_add_symbol): Update.
1718 * ctfread.c (psymtab_to_symtab): Update.
1719 * dbxread.c (cp_set_block_scope): Update.
1720 * dictionary.c (iter_match_first_hashed): Update.
1721 (iter_match_next_hashed): Update.
1722 (insert_symbol_hashed): Update.
1723 (iter_match_next_linear): Update.
1724 * dictionary.h: Update.
1725 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1726 (locexpr_describe_location_piece): Update.
1727 (locexpr_describe_location_1): Update.
1728 (locexpr_generate_c_location): Update.
1729 (loclist_describe_location): Update.
1730 (loclist_generate_c_location): Update.
1731 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1732 (read_func_scope): Update.
1733 (process_enumeration_scope): Update.
1734 (new_symbol): Update.
1735 (dwarf2_const_value): Update.
1736 (dwarf2_symbol_mark_computed): Update.
1737 * eval.c (evaluate_funcall): Update.
1738 (evaluate_subexp_standard): Update.
1739 * expprint.c (print_subexp_standard): Update.
1740 (dump_subexp_body_standard): Update.
1741 * f-valprint.c (info_common_command_for_block): Update.
1742 * findvar.c (get_hosting_frame): Update.
1743 (default_read_var_value): Update.
1744 * go-lang.c (go_symbol_package_name): Update.
1745 * guile/scm-block.c (bkscm_print_block_smob): Update.
1746 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1747 (gdbscm_symbol_name): Update.
1748 (gdbscm_symbol_linkage_name): Update.
1749 (gdbscm_symbol_print_name): Update.
1750 * infcall.c (get_function_name): Update.
1751 * infcmd.c (jump_command): Update.
1752 (finish_command): Update.
1753 * infrun.c (insert_exception_resume_breakpoint): Update.
1754 * linespec.c (canonicalize_linespec): Update.
1755 (create_sals_line_offset): Update.
1756 (convert_linespec_to_sals): Update.
1757 (complete_label): Update.
1758 (find_label_symbols_in_block): Update.
1759 * m2-typeprint.c (m2_print_typedef): Update.
1760 * mdebugread.c (mdebug_reg_to_regnum): Update.
1761 (parse_symbol): Update.
1762 (mylookup_symbol): Update.
1763 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1764 (list_args_or_locals): Update.
1765 * objc-lang.c (compare_selectors): Update.
1766 (info_selectors_command): Update.
1767 (compare_classes): Update.
1768 (info_classes_command): Update.
1769 (find_imps): Update.
1770 * p-typeprint.c (pascal_print_typedef): Update.
1771 * printcmd.c (build_address_symbolic): Update.
1772 (info_address_command): Update.
1773 (print_variable_and_value): Update.
1774 * python/py-framefilter.c (extract_sym): Update.
1775 (py_print_single_arg): Update.
1776 * python/py-symbol.c (sympy_str): Update.
1777 (sympy_get_name): Update.
1778 (sympy_get_linkage_name): Update.
1779 * python/python.c (gdbpy_rbreak): Update.
1780 * record-btrace.c (btrace_get_bfun_name): Update.
1781 (btrace_call_history): Update.
1782 * rust-lang.c (rust_print_typedef): Update.
1783 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1784 * stabsread.c (stab_reg_to_regnum): Update.
1785 (define_symbol): Update.
1786 (read_enum_type): Update.
1787 (common_block_end): Update.
1788 (cleanup_undefined_types_1): Update.
1789 (scan_file_globals): Update.
1790 * stack.c (print_frame_arg): Update.
1791 (print_frame_args): Update.
1792 (find_frame_funname): Update.
1793 (info_frame_command_core): Update.
1794 (iterate_over_block_locals): Update.
1795 (print_block_frame_labels): Update.
1796 (do_print_variable_and_value): Update.
1797 (iterate_over_block_arg_vars): Update.
1798 (return_command): Update.
1799 * symmisc.c (dump_symtab_1): Update.
1800 (print_symbol): Update.
1801 * symtab.c (eq_symbol_entry): Update.
1802 (symbol_cache_dump): Update.
1803 (lookup_language_this): Update.
1804 (find_pc_sect_line): Update.
1805 (skip_prologue_sal): Update.
1806 (symbol_search::compare_search_syms): Update.
1807 (treg_matches_sym_type_name): Update.
1808 (search_symbols): Update.
1809 (print_symbol_info): Update.
1810 (rbreak_command): Update.
1811 (completion_list_add_symbol): Update.
1812 (find_gnu_ifunc): Update.
1813 (get_symbol_address): Update.
1814 (search_module_symbols): Update.
1815 (info_module_subcommand): Update.
1816 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1817 (SYMBOL_LINKAGE_NAME): Remove.
1818 (SYMBOL_DEMANGLED_NAME): Remove.
1819 (SYMBOL_PRINT_NAME): Remove.
1820 (SYMBOL_SEARCH_NAME): Remove.
1821 * tracepoint.c (set_traceframe_context): Update.
1822 (validate_actionline): Update.
1823 (collection_list::collect_symbol): Update.
1824 (encode_actions_1): Update.
1825 (info_scope_command): Update.
1826 (print_one_static_tracepoint_marker): Update.
1827 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1828 * valops.c (address_of_variable): Update.
1829 (find_overload_match): Update.
1830 (find_oload_champ): Update.
1831
c9d95fa3
CB		 18322019-11-22 Christian Biesinger <cbiesinger@google.com>
1833
1834 * ada-lang.c (ada_lookup_simple_minsym): Update.
1835 (ada_collect_symbol_completion_matches): Update.
1836 * ada-tasks.c (read_atcb): Update.
1837 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1838 (amd64_windows_skip_trampoline_code): Update.
1839 * arm-tdep.c (skip_prologue_function): Update.
1840 (arm_skip_stack_protector): Update.
1841 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1842 (arm_wince_skip_main_prologue): Update.
1843 * ax-gdb.c (gen_expr): Update.
1844 * block.c (call_site_for_pc): Update.
1845 * blockframe.c (find_pc_partial_function): Update.
1846 * breakpoint.c (set_breakpoint_location_function): Update.
1847 * btrace.c (ftrace_print_function_name): Update.
1848 (ftrace_function_switched): Update.
1849 * c-valprint.c (print_unpacked_pointer): Update.
1850 * coffread.c (coff_symfile_read): Update.
1851 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1852 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1853 * dwarf-index-write.c (write_psymbols): Update.
1854 * dwarf2loc.c (call_site_to_target_addr): Update.
1855 (func_verify_no_selftailcall): Update.
1856 (tailcall_dump): Update.
1857 (call_site_find_chain_1): Update.
1858 (dwarf_expr_reg_to_entry_parameter): Update.
1859 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1860 * eval.c (evaluate_funcall): Update.
1861 (evaluate_subexp_standard): Update.
1862 (evaluate_subexp_for_sizeof): Update.
1863 * expprint.c (print_subexp_standard): Update.
1864 (dump_subexp_body_standard): Update.
1865 * frame.c (get_prev_frame_always_1): Update.
1866 * frv-tdep.c (frv_skip_main_prologue): Update.
1867 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1868 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1869 (gnuv3_get_typename_from_type_info): Update.
1870 (gnuv3_skip_trampoline): Update.
1871 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1872 * i386-tdep.c (i386_skip_main_prologue): Update.
1873 (i386_pe_skip_trampoline_code): Update.
1874 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1875 * infcall.c (get_function_name): Update.
1876 * linespec.c (minsym_found): Update.
1877 * linux-fork.c (info_checkpoints_command): Update.
1878 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1879 (m32c_m16c_pointer_to_address): Update.
1880 * maint.c (maintenance_translate_address): Update.
1881 * minsyms.c (add_minsym_to_hash_table): Update.
1882 (add_minsym_to_demangled_hash_table): Update.
1883 (lookup_minimal_symbol_mangled): Update.
1884 (lookup_minimal_symbol_demangled): Update.
1885 (lookup_minimal_symbol_linkage): Update.
1886 (lookup_minimal_symbol_text): Update.
1887 (lookup_minimal_symbol_by_pc_name): Update.
1888 (minimal_symbol_is_less_than): Update.
1889 (compact_minimal_symbols): Update.
1890 (build_minimal_symbol_hash_tables): Update.
1891 (find_solib_trampoline_target): Update.
1892 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1893 (mips_skip_pic_trampoline_code): Update.
1894 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1895 * objc-lang.c (info_selectors_command): Update.
1896 (info_classes_command): Update.
1897 (find_methods): Update.
1898 (find_imps): Update.
1899 * p-valprint.c (pascal_val_print): Update.
1900 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1901 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1902 * printcmd.c (build_address_symbolic): Update.
1903 (info_symbol_command): Update.
1904 * psymtab.c (psymbol_name_matches): Update.
1905 (match_partial_symbol): Update.
1906 (lookup_partial_symbol): Update.
1907 (print_partial_symbols): Update.
1908 (sort_pst_symbols): Update.
1909 (maintenance_check_psymtabs): Update.
1910 * python/py-framefilter.c (py_print_frame): Update.
1911 * python/python.c (gdbpy_rbreak): Update.
1912 * record-btrace.c (btrace_get_bfun_name): Update.
1913 (btrace_call_history): Update.
1914 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1915 (rs6000_skip_trampoline_code): Update.
1916 * sol-thread.c (info_cb): Update.
1917 * stabsread.c (scan_file_globals): Update.
1918 * stack.c (find_frame_funname): Update.
1919 (info_frame_command_core): Update.
1920 * symmisc.c (dump_msymbols): Update.
1921 * symtab.c (symbol_natural_name): Rename to..,
1922 (general_symbol_info::natural_name): ...this.
1923 (symbol_demangled_name): Rename to...
1924 (general_symbol_info::demangled_name): ...this.
1925 (symbol_search_name): Rename to...
1926 (general_symbol_info::search_name): ...this.
1927 (symbol_matches_search_name): Update.
1928 (find_pc_sect_line): Update.
1929 (skip_prologue_sal): Update.
1930 (search_symbols): Update.
1931 (print_msymbol_info): Update.
1932 (rbreak_command): Update.
1933 (completion_list_add_msymbol): Update.
1934 (completion_list_objc_symbol): Update.
1935 (get_msymbol_address): Update.
1936 * symtab.h (struct general_symbol_info): Add member functions
1937 natural_name (), linkage_name (), print_name (), demangled_name (),
1938 and search_name ().
1939 (SYMBOL_NATURAL_NAME): Update.
1940 (symbol_natural_name): Move to a member function on general_symbol_info.
1941 (SYMBOL_DEMANGLED_NAME): Update.
1942 (symbol_demangled_name): Move to a member function on
1943 general_symbol_info.
1944 (SYMBOL_SEARCH_NAME): Update.
1945 (symbol_search_name): Move to a member function on general_symbol_info.
1946 (MSYMBOL_NATURAL_NAME): Remove.
1947 (MSYMBOL_LINKAGE_NAME): Remove.
1948 (MSYMBOL_PRINT_NAME): Remove.
1949 (MSYMBOL_DEMANGLED_NAME): Remove.
1950 (MSYMBOL_SEARCH_NAME): Remove.
1951 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1952
f8bab2d6
CB		 19532019-11-22 Christian Biesinger <cbiesinger@google.com>
1954
1955 * symtab.c (create_demangled_names_hash): Use per_bfd->
1956 minimal_symbol_count for computing the initial size, if greater
1957 than our default size.
1958
85e7588d
TV		 19592019-11-22 Tom de Vries <tdevries@suse.de>
1960
1961 * contrib/words.sh: Improve words extraction.
1962
f6180073
TV		 19632019-11-22 Tom de Vries <tdevries@suse.de>
1964
1965 * contrib/words.sh: Combine sed invocations.
1966
f10ffa41
CB		 19672019-11-21 Christian Biesinger <cbiesinger@google.com>
1968
1969 * Makefile.in: Update.
1970 * demangle.c: Rename to...
1971 * gdb-demangle.c: ..this.
1972 (is_cplus_marker): Change return type to bool.
1973 (_initialize_demangler): Rename to...
1974 (_initialize_gdb_demangle): ...this.
1975 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1976 * symtab.h (demangle): Remove declaration; instead include
1977 gdb-demangle.h.
1978
6ba18521
TT		 19792019-11-21 Tom Tromey <tromey@adacore.com>
1980
1981 * gdbsupport/format.c (format_pieces): Parse %I64d.
1982 * unittests/format_pieces-selftests.c (test_windows_formats): New
1983 function.
1984 (run_tests): Call it.
1985
34877895
PJ		 19862019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1987
1988 Byte reverse display of variables with DW_END_big, DW_END_little
1989 (DW_AT_endianity) dwarf attributes if different than the native
1990 byte order.
1991 * ada-lang.c (ada_value_binop):
1992 Use type_byte_order instead of gdbarch_byte_order.
1993 * ada-valprint.c (printstr):
1994 (ada_val_print_string):
1995 * ada-lang.c (value_pointer):
1996 (ada_value_binop):
1997 Use type_byte_order instead of gdbarch_byte_order.
1998 * c-lang.c (c_get_string):
1999 Use type_byte_order instead of gdbarch_byte_order.
2000 * c-valprint.c (c_val_print_array):
2001 Use type_byte_order instead of gdbarch_byte_order.
2002 * cp-valprint.c (cp_print_class_member):
2003 Use type_byte_order instead of gdbarch_byte_order.
2004 * dwarf2loc.c (rw_pieced_value):
2005 Use type_byte_order instead of gdbarch_byte_order.
2006 * dwarf2read.c (read_base_type): Handle DW_END_big,
2007 DW_END_little
2008 * f-lang.c (f_get_encoding):
2009 Use type_byte_order instead of gdbarch_byte_order.
2010 * findvar.c (default_read_var_value):
2011 Use type_byte_order instead of gdbarch_byte_order.
2012 * gdbtypes.c (check_types_equal):
2013 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2014 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2015 and TYPE_ENDIANITY_LITTLE if set.
2016 (type_byte_order): new function.
2017 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2018 (struct main_type) <flag_endianity_not_default>:
2019 New field.
2020 (type_byte_order): New function.
2021 * infcmd.c (default_print_one_register_info):
2022 Use type_byte_order instead of gdbarch_byte_order.
2023 * p-lang.c (pascal_printstr):
2024 Use type_byte_order instead of gdbarch_byte_order.
2025 * p-valprint.c (pascal_val_print):
2026 Use type_byte_order instead of gdbarch_byte_order.
2027 * printcmd.c (print_scalar_formatted):
2028 Use type_byte_order instead of gdbarch_byte_order.
2029 * solib-darwin.c (darwin_current_sos):
2030 Use type_byte_order instead of gdbarch_byte_order.
2031 * solib-svr4.c (solib_svr4_r_ldsomap):
2032 Use type_byte_order instead of gdbarch_byte_order.
2033 * stap-probe.c (stap_modify_semaphore):
2034 Use type_byte_order instead of gdbarch_byte_order.
2035 * target-float.c (target_float_same_format_p):
2036 Use type_byte_order instead of gdbarch_byte_order.
2037 * valarith.c (scalar_binop):
2038 (value_bit_index):
2039 Use type_byte_order instead of gdbarch_byte_order.
2040 * valops.c (value_cast):
2041 Use type_byte_order instead of gdbarch_byte_order.
2042 * valprint.c (generic_emit_char):
2043 (generic_printstr):
2044 (val_print_string):
2045 Use type_byte_order instead of gdbarch_byte_order.
2046 * value.c (unpack_long):
2047 (unpack_bits_as_long):
2048 (unpack_value_bitfield):
2049 (modify_field):
2050 (pack_long):
2051 (pack_unsigned_long):
2052 Use type_byte_order instead of gdbarch_byte_order.
2053 * findvar.c (unsigned_pointer_to_address):
2054 (signed_pointer_to_address):
2055 (unsigned_address_to_pointer):
2056 (address_to_signed_pointer):
2057 (default_read_var_value):
2058 (default_value_from_register):
2059 Use type_byte_order instead of gdbarch_byte_order.
2060 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2061 Use type_byte_order instead of gdbarch_byte_order.
2062 * riscv-tdep.c (riscv_print_one_register_info):
2063 Use type_byte_order instead of gdbarch_byte_order.
2064
87fb00ea
SM		 20652019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2066
2067 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2068 (current_ui_gdb_stdin_ptr): Likewise.
2069 (current_ui_gdb_stderr_ptr): Likewise.
2070 (current_ui_gdb_stdlog_ptr): Likewise.
2071 (current_ui_current_uiout_ptr): Likewise.
2072 (gen_ret_current_ui_field_ptr): Remove.
2073
65d1cd5f
TV		 20742019-11-21 Tom de Vries <tdevries@suse.de>
2075
2076 PR gdb/24956
2077 * cli/cli-script.c (execute_control_command): Only switch to
2078 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2079
9f6ad286
TT		 20802019-11-19 Tom Tromey <tom@tromey.com>
2081
2082 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2083 Now static. Change type of "name".
2084 (tui_set_win_height_command): Don't copy "arg".
2085 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2086 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2087
435d3d88
AT		 20882019-11-19 Ali Tamur <tamur@google.com>
2089
2090 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2091 "if (attr != nullptr)".
2092 (dwarf2_find_base_address): Likewise.
2093 (dwarf2_build_include_psymtabs): Likewise.
2094 (read_cutu_die_from_dwo): Likewise.
2095 (read_func_scope): Likewise.
2096 (read_call_site_scope): Likewise.
2097 (dwarf2_get_pc_bounds): Likewise.
2098 (dwarf2_record_block_ranges): Likewise.
2099 (dwarf2_add_field): Likewise.
2100 (dwarf2_add_member_fn): Likewise.
2101 (read_structure_type): Likewise.
2102 (read_enumeration_type): Likewise.
2103 (read_array_type): Likewise.
2104 (read_array_order): Likewise.
2105 (read_set_type): Likewise.
2106 (read_common_block): Likewise.
2107 (read_tag_reference_type): Likewise.
2108 (read_tag_string_type): Likewise.
2109 (read_subroutine_type): Likewise.
2110 (read_base_type): Likewise.
2111 (read_subrange_type): Likewise.
2112 (new_symbol): Likewise.
2113 (prepare_one_comp_unit): Likewise.
2114
c9739b6a
TT		 21152019-11-19 Tom Tromey <tromey@adacore.com>
2116
2117 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2118 result in error when DebugActiveProcess fails.
2119
494409bb
SDJ		 21202019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2121 Pedro Alves <palves@redhat.com>
2122
2123 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2124 * target.c (target_stack::push): Call 'unpush' if there's a
2125 target on top of the stack.
2126
2e953aca
PW		 21272019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2128
2129 * python/py-block.c (blpy_dealloc): Call tp_free.
2130 (blpy_block_syms_dealloc): Likewise.
2131 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2132 * python/py-inferior.c (infpy_dealloc): Likewise.
2133 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2134 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2135 * python/py-symbol.c (sympy_dealloc): Likewise.
2136 * python/py-symtab.c (stpy_dealloc): Likewise.
2137 * python/py-type.c (typy_iterator_dealloc): Likewise.
2138
6edc43ec
CB		 21392019-11-18 Christian Biesinger <cbiesinger@google.com>
2140
2141 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2142 constructor instead of using a class initializer.
2143
cd850b40
CB		 21442019-11-15 Christian Biesinger <cbiesinger@google.com>
2145
2146 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2147 * configure: Regenerate.
2148 * configure.ac: Don't source common.host.
2149 * gdbsupport/common.host: Remove.
2150 * gdbsupport/mingw-strerror.c: Remove.
2151 * gdbsupport/posix-strerror.c: Rename to...
2152 * gdbsupport/safe-strerror.c: ...this.
2153
53fea9c7
CB		 21542019-11-15 Christian Biesinger <cbiesinger@google.com>
2155
2156 * maint.c (scoped_command_stats::print_time): Use localtime_r
2157 instead of localtime (provided through gnulib if necessary).
2158 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2159 of ctime.
2160
f8e27d88
CB		 21612019-11-15 Christian Biesinger <cbiesinger@google.com>
2162
2163 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2164 avoid compile errors.
2165
5abebf3c
CB		 21662019-11-15 Christian Biesinger <cbiesinger@google.com>
2167
2168 * config.in: Regenerate.
2169 * configure: Regenerate.
2170 * gdbsupport/common.m4: No longer check for strerror_r.
2171 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2172 POSIX version of strerror_r, now that gnulib provides it if
2173 necessary.
2174
9a351667
CB		 21752019-11-14 Christian Biesinger <cbiesinger@google.com>
2176
2177 * README (`configure' options): Update.
2178
55708e99
TT		 21792019-11-14 Tom Tromey <tromey@adacore.com>
2180
2181 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2182 expected type for the RHS if the LHS is a convenience variable.
2183
4b09bb2e
SM		 21842019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2185
2186 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2187 Provide explicit default and copy constructor.
2188
bd454f8b
PW		 21892019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2190
2191 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2192 only call Py_INCREF (newbp) in the bppy_pending_object case.
2193
d1aa3cf0
TT		 21942019-11-13 Tom Tromey <tromey@adacore.com>
2195
2196 PR build/25182:
2197 * psympriv.h (partial_symbol): Remove static assert.
2198 * symtab.h (general_symbol_info, symbol): Remove static assert.
2199
e06f3d6e
AB		 22002019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2201
2202 * gdbsupport/format.c (format_pieces::format_pieces): Support
2203 printf 'z' size modifier.
2204 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2205 * printcmd.c (ui_printf): Handle size_t_arg.
2206 * ui-out.c (ui_out::vmessage): Likewise.
2207 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2208 function.
2209 (run_tests): Call test_format_int_sizes.
2210
468c0cbb
CB		 22112019-11-12 Christian Biesinger <cbiesinger@google.com>
2212
2213 * ada-exp.y (write_ambiguous_var): Update.
2214 * buildsym.c (add_symbol_to_list): Update.
2215 * dwarf2read.c (read_variable): Update.
2216 (new_symbol): Update.
2217 * jit.c (finalize_symtab): Update.
2218 * language.c (language_alloc_type_symbol): Update.
2219 * symtab.c (fixup_symbol_section): Update.
2220 (initialize_objfile_symbol_1): Move code to...
2221 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2222 (allocate_symbol): Update.
2223 (allocate_template_symbol): Update.
2224 (get_symbol_address): Update.
2225 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2226 of having as a field, and add a constructor.
2227 (SYMBOL_VALUE): Update.
2228 (SYMBOL_VALUE_ADDRESS): Update.
2229 (SET_SYMBOL_VALUE_ADDRESS): Update.
2230 (SYMBOL_VALUE_BYTES): Update.
2231 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2232 (SYMBOL_BLOCK_VALUE): Update.
2233 (SYMBOL_VALUE_CHAIN): Update.
2234 (SYMBOL_LANGUAGE): Update.
2235 (SYMBOL_SECTION): Update.
2236 (SYMBOL_OBJ_SECTION): Update.
2237 (SYMBOL_SET_LANGUAGE): Update.
2238 (SYMBOL_SET_LINKAGE_NAME): Update.
2239 (SYMBOL_SET_NAMES): Update.
2240 (SYMBOL_NATURAL_NAME): Update.
2241 (SYMBOL_LINKAGE_NAME): Update.
2242 (SYMBOL_DEMANGLED_NAME): Update.
2243 (SYMBOL_SEARCH_NAME): Update.
2244 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2245 (struct symbol): Update.
2246 (struct template_symbol): Update.
2247 (struct rust_vtable_symbol): Update.
2248 * xcoffread.c (SYMBOL_DUP): Update.
2249
ed2c82c3
TT		 22502019-11-12 Tom Tromey <tom@tromey.com>
2251
2252 * tui/tui-layout.c (show_layout): Set current_layout.
2253 (show_source_disasm_command, show_data)
2254 (show_source_or_disasm_and_command): Don't set current_layout.
2255
d9fcefd5
TT		 22562019-11-12 Tom Tromey <tom@tromey.com>
2257
2258 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2259
45e42163
TT		 22602019-11-12 Tom Tromey <tom@tromey.com>
2261
2262 * tui/tui-win.c (resize_message): New global.
2263 (show_tui_resize_message): New function.
2264 (tui_async_resize_screen): Print message if requested.
2265 (_initialize_tui_win): Add tui-resize-message setting.
2266 * NEWS: Add entry for new commands.
2267
c86d74cc
TT		 22682019-11-11 Tom Tromey <tom@tromey.com>
2269
2270 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2271 functions.
2272
7b7b9424
CB		 22732019-11-11 Christian Biesinger <cbiesinger@google.com>
2274
2275 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2276
086baaf1
AB		 22772019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2278
2279 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2280 function.
2281 * python/python-internal.h (gdbpy_lookup_static_symbols):
2282 Declare new function.
2283 * python/python.c (python_GdbMethods): Add
2284 gdb.lookup_static_symbols method.
2285 * NEWS: Mention gdb.lookup_static_symbols.
2286
09ff83af
AB		 22872019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2288
2289 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2290 static block of current object file first. Also fix typo in
2291 header comment.
2292
eb2dd8df
AB		 22932019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2294
2295 * stack.c (set_last_displayed_sal): Delete.
2296 (last_displayed_sal_valid): Delete.
2297 (last_displayed_pspace): Delete.
2298 (last_displayed_addr): Delete.
2299 (last_displayed_symtab): Delete.
2300 (last_displayed_line): Delete.
2301 (class last_displayed_symtab_info_type): New.
2302 (last_displayed_symtab_info): New static global variable.
2303 (print_frame_info): Call methods on last_displayed_symtab_info.
2304 (clear_last_displayed_sal): Update header comment, and make use of
2305 last_displayed_symtab_info.
2306 (last_displayed_sal_is_valid): Likewise.
2307 (get_last_displayed_pspace): Likewise.
2308 (get_last_displayed_addr): Likewise.
2309 (get_last_displayed_symtab): Likewise.
2310 (get_last_displayed_line): Likewise.
2311 (get_last_displayed_sal): Likewise.
2312 * stack.h (clear_last_displayed_sal): Update header comment.
2313 (last_displayed_sal_is_valid): Likewise.
2314 (get_last_displayed_pspace): Likewise.
2315 (get_last_displayed_addr): Likewise.
2316 (get_last_displayed_symtab): Likewise.
2317 (get_last_displayed_line): Likewise.
2318 (get_last_displayed_sal): Likewise.
2319
62137775
AB		 23202019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2321
2322 * stack.c (frame_show_address): Convert return type to bool.
2323 * stack.h (frame_show_address): Likewise, and update header
2324 comment.
2325
cf57ad6d
AB		 23262019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2327
2328 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2329 * unittests/vec-utils-selftests.c: New file.
2330 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2331
0b026263
TT		 23322019-11-10 Tom Tromey <tom@tromey.com>
2333
2334 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2335 (tui_highlight_win): Likewise.
2336 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2337 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2338 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2339 Don't set can_highlight.
2340
b049ce2d
TT		 23412019-11-10 Tom Tromey <tom@tromey.com>
2342
2343 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2344 Remove unused declaration.
2345
992a7040
TT		 23462019-11-08 Tom Tromey <tromey@adacore.com>
2347
2348 * top.c (read_command_file): Update.
2349 (command_line_input): Make return type const.
2350 * python/py-gdb-readline.c: Update.
2351 * linespec.c (decode_line_2): Update.
2352 * defs.h (command_line_input): Make return type const.
2353 * cli/cli-script.c (read_next_line): Make return type const.
2354 * ada-lang.c (get_selections): Update.
2355
ca3a04f6
CB		 23562019-11-06 Christian Biesinger <cbiesinger@google.com>
2357
2358 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2359 * mi/mi-main.c (output_cores): Likewise.
2360 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2361 (linux_xfer_osdata_modules): Likewise.
2362 * remote.c (register_remote_support_xml): Likewise.
2363 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2364 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2365
e0eac551
TT		 23662019-11-06 Tom Tromey <tom@tromey.com>
2367
2368 * tui/tui-interp.c: Don't include readline.h.
2369 * tui/tui-hooks.c: Don't include readline.h.
2370 * symmisc.c: Include tilde.h, not readline.h.
2371 * symfile.c: Include tilde.h, not readline.h.
2372 * source.c: Include tilde.h, not readline.h.
2373 * solib.c: Include tilde.h, not readline.h.
2374 * psymtab.c: Include tilde.h, not readline.h.
2375 * exec.c: Include tilde.h, not readline.h.
2376 * corelow.c: Include tilde.h, not readline.h.
2377 * cli/cli-dump.c: Include tilde.h, not readline.h.
2378 * cli/cli-cmds.c: Don't include readline.h.
2379
825165c5
TT		 23802019-11-05 Tom Tromey <tom@tromey.com>
2381
2382 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2383 (tui_disassemble): Set addr_size.
2384 (tui_disasm_window::set_contents): Use addr_size.
2385
91ae903f
TT		 23862019-11-05 Tom Tromey <tom@tromey.com>
2387
2388 * rust-lang.c (rust_language_defn): Update.
2389 * python/py-value.c (valpy_string): Call c_get_string.
2390 * p-lang.c (pascal_language_defn): Update.
2391 * opencl-lang.c (opencl_language_defn): Update.
2392 * objc-lang.c (objc_language_defn): Update.
2393 * m2-lang.c (m2_language_defn): Update.
2394 * language.c (unknown_language_defn, auto_language_defn): Update.
2395 (default_get_string): Remove.
2396 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2397 * go-lang.c (go_language_defn): Update.
2398 * f-lang.c (f_language_defn): Update.
2399 * d-lang.c (d_language_defn): Update.
2400 * c-lang.c (c_language_defn, cplus_language_defn)
2401 (asm_language_defn, minimal_language_defn): Update.
2402 * ada-lang.c (ada_language_defn): Update.
2403 * language.h (struct language_defn) <la_get_string>: Remove.
2404 (LA_GET_STRING): Remove.
2405 (default_get_string): Don't declare.
2406
1df2f9ef
TT		 24072019-11-05 Tom Tromey <tom@tromey.com>
2408
2409 * tui/tui-source.h (struct tui_source_window): Inline
2410 constructor. Remove destructor.
2411 <style_changed, m_observable>: Move to superclass.
2412 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2413 (struct tui_source_window_base): Move private members to end.
2414 <style_changed, m_observable>: Move from tui_source_window.
2415 * tui/tui-winsource.c (tui_copy_source_line): Move from
2416 tui-source.c. Rename from copy_source_line. Add special handling
2417 for negative line number.
2418 (tui_source_window_base::style_changed): Move from
2419 tui_source_window.
2420 (tui_source_window_base): Register observer.
2421 (~tui_source_window_base): New.
2422 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2423 rename.
2424 (tui_source_window::set_contents): Use tui_copy_source_line.
2425 (tui_source_window::tui_source_window): Move to tui-source.h.
2426 (tui_source_window::~tui_source_window): Remove.
2427 (tui_source_window::style_changed): Move to superclass.
2428 * tui/tui-disasm.c (tui_disassemble): Create string file with
2429 styling, when possible. Add "addr_size" parameter.
2430 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2431 Don't compute maximum size.
2432 (len_without_escapes): New function
2433
5d051055
TT		 24342019-11-05 Tom Tromey <tom@tromey.com>
2435
2436 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2437 std::string.
2438 * tui/tui-winsource.c (tui_show_source_line): Update.
2439 * tui/tui-source.c (tui_source_window::set_contents): Update.
2440 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2441
ade7beea
CB		 24422019-11-05 Christian Biesinger <cbiesinger@google.com>
2443
2444 * symtab.h (gdb_static_assert): Put && operator at the beginning
2445 of the line instead of the end.
2446
3573abe1
CB		 24472019-11-04 Christian Biesinger <cbiesinger@google.com>
2448
2449 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2450 and sizeof (symbol).
2451 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2452
dae8b3eb
RO		 24532019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2454
2455 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2456 * configure.host: Mark *-*-solaris2.10* obsolete.
2457 * configure.tgt: Mark Solaris < 11 obsolete.
2458 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2459 Update target triplet.
2460
5df96a4e
TT		 24612019-11-01 Tom Tromey <tromey@adacore.com>
2462
2463 * utils.c (print_sys_errmsg): Simplify.
2464
b7481649
TT		 24652019-11-01 Tom Tromey <tromey@adacore.com>
2466
2467 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2468
e48f6033
CB		 24692019-11-01 Christian Biesinger <cbiesinger@google.com>
2470
2471 * configure: Regenerate.
2472 * configure.ac: Remove check for strerror_r.
2473 * gdbsupport/common.m4: Check for strerror_r.
2474
bd5766ec
LM		 24752019-11-01 Luis Machado <luis.machado@linaro.org>
2476
2477 PR gdb/25124
2478
2479 * arm-tdep.c (arm_per_objfile): Rename to ...
2480 (arm_per_bfd): ... this.
2481 (arm_objfile_data_key): Rename to ...
2482 (arm_bfd_data_key): ... this.
2483 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2484 data.
2485 (arm_record_special_symbol): Likewise.
2486
e1709896
AB		 24872019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2488
2489 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2490 end.
2491 * c-typeprint.c (c_print_typedef): Likewise.
2492 * f-typeprint.c (f_print_typedef): Likewise.
2493 * m2-typeprint.c (m2_print_typedef): Likewise.
2494 * p-typeprint.c (pascal_print_typedef): Likewise.
2495 * rust-lang.c (rust_print_typedef): Likewise.
2496 * symtab.c (print_symbol_info): Print a newline after calling
2497 typedef_print.
2498
165f8965
AB		 24992019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2500
2501 * symtab.c (info_module_cmdlist): New variable.
2502 (info_module_command): New function.
2503 (search_module_symbols): New function.
2504 (info_module_subcommand): New function.
2505 (struct info_modules_var_func_options): New struct.
2506 (info_modules_var_func_options_defs): New variable.
2507 (make_info_modules_var_func_options_def_group): New function.
2508 (info_module_functions_command): New function.
2509 (info_module_variables_command): New function.
2510 (info_module_var_func_command_completer): New function.
2511 (_initialize_symtab): Register new 'info module functions' and
2512 'info module variables' commands.
2513 * symtab.h (typedef symbol_search_in_module): New typedef.
2514 (search_module_symbols): Declare new function.
2515 * NEWS: Mention new commands.
2516
59c35742
AB		 25172019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2518
2519 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2520 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2521 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2522 MODULES_DOMAIN.
2523 (scan_partial_symbols): Only create partial module symbols for non
2524 declarations.
2525 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2526 and MODULES_DOMAIN.
2527 * symtab.c (search_domain_name): Likewise.
2528 (search_symbols): Likewise.
2529 (print_symbol_info): Likewise.
2530 (symtab_symbol_info): Likewise.
2531 (info_modules_command): New function.
2532 (_initialize_symtab): Register 'info modules' command.
2533 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2534 * NEWS: Mention new 'info modules' command.
2535
aed61d02
PW		 25362019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2537
2538 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2539 and $_gdb_maint_setting_str.
2540
9ad9b77d
PW		 25412019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2542
2543 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2544 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2545 (str_value_from_setting, gdb_setting_str_internal_fn)
2546 (gdb_maint_setting_str_internal_fn): New functions.
2547 (_initialize_cli_cmds): Define the new convenience functions.
2548 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2549 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2550
8d6efaa2
CB		 25512019-10-31 Christian Biesinger <cbiesinger@google.com>
2552
2553 * agent.c (set_can_use_agent): When the setting is turned on,
2554 look up agent symbols if we don't have them yet.
2555 (agent_new_objfile): Don't look up agent symbols when the agent
2556 setting is off.
2557
33cb1647
CB		 25582019-10-31 Christian Biesinger <cbiesinger@google.com>
2559
2560 * config.in: Regenerate.
2561
b231e86a
CB		 25622019-10-31 Christian Biesinger <cbiesinger@google.com>
2563
2564 * configure: Regenerate.
2565 * configure.ac: Check for strerror_r.
2566 * gdbsupport/common-utils.h (safe_strerror): Change return value
2567 to const char * and document that this function is now threadsafe.
2568 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2569 thread_local and call strerror_r, if available.
2570 * utils.c (perror_string): Update.
2571 (print_sys_errmsg): Update.
2572
a2726d4f
LM		 25732019-10-31 Luis Machado <luis.machado@linaro.org>
2574
2575 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2576 objfile_key.
2577 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2578 objfile to fetch per-bfd data.
2579 (arm_find_exidx_entry): Likewise.
2580
75cafaa6
CB		 25812019-10-31 Christian Biesinger <cbiesinger@google.com>
2582
2583 * gdbsupport/agent.c (debug_agent): Change type to bool.
2584 (use_agent): Likewise.
2585 (all_agent_symbols_look_up): Likewise.
2586 (agent_loaded_p): Change return value to bool.
2587 (agent_look_up_symbols): Update.
2588 (agent_capability_check): Change return value to bool.
2589 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2590 (debug_agent): Change type to bool.
2591 (use_agent): Likewise.
2592 (agent_capability_check): Change return value to bool.
2593
808590ec
CB		 25942019-10-30 Christian Biesinger <cbiesinger@google.com>
2595
2596 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2597 (build_minimal_symbol_hash_tables): Code to clear the table moved
2598 to clear_minimal_symbol_hash_tables.
2599 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2600 when needed.
2601
f18ad8a1
SM		 26022019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2603
2604 * infcmd.c: Remove includes.
2605 * infrun.c: Remove includes.
2606
de93309a
SM		 26072019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2608
2609 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2610 (grow_vect): Remove declaration.
2611 (ada_type_of_array): Remove declaration.
2612 (ada_update_initial_language): Remove declaration.
2613 (ada_fold_name): Remove declaration.
2614 (ada_fill_in_ada_prototype): Remove declaration.
2615 (user_select_syms): Remove declaration.
2616 (get_selections): Remove declaration.
2617 (ada_tag_type): Remove declaration.
2618 (ada_value_tag): Remove declaration.
2619 (ada_is_others_clause): Remove declaration.
2620 (ada_in_variant): Remove declaration.
2621 (ada_value_struct_elt): Remove declaration.
2622 (ada_attribute_name): Remove declaration.
2623 (ada_system_address_type): Remove declaration.
2624 * ada-lang.c (ada_watch_location_expression): Make static.
2625 (GROW_VECT): Move here from ada-lang.h.
2626 (grow_vect): Make static.
2627 (ada_update_initial_language): Make static.
2628 (ada_fold_name): Make static.
2629 (ada_type_of_array): Make static.
2630 (encoded_ordered_before): Move up.
2631 (sort_choices): Move up.
2632 (print_signatures): Move up.
2633 (ada_print_symbol_signature): Move up.
2634 (get_selections): Move up and make static.
2635 (user_select_syms): Move up and make static.
2636 (ada_value_struct_elt): Move up and make static.
2637 (ada_tag_type): Make static.
2638 (ada_value_tag): Make static.
2639 (ada_is_others_clause): Make static.
2640 (ada_in_variant): Make static.
2641 (ada_attribute_name): Make static.
2642
cdc46a9f
SM		 26432019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2644
2645 * ada-lang.c: Remove includes.
2646 * ada-typeprint.c: Remove includes.
2647 * ada-valprint.c: Remove includes.
2648
90421c56
SM		 26492019-10-29 Simon Marchi <simon.marchi@efficios.com>
2650
2651 * addrmap.c: Add static assertions of type size, moved from
2652 _initialize_addrmap.
2653 (_initialize_addrmap): Remove.
2654
31edb802
CB		 26552019-10-29 Christian Biesinger <cbiesinger@google.com>
2656
2657 * coffread.c (record_minimal_symbol): Update.
2658 (process_coff_symbol): Update.
2659 * dbxread.c (read_dbx_symtab): Update.
2660 * dwarf2read.c (add_partial_symbol): Update.
2661 (fixup_go_packaging): Update.
2662 (load_partial_dies): Update.
2663 (new_symbol): Update.
2664 * elfread.c (record_minimal_symbol): Change signature to use
2665 gdb::string_view instead of name+len.
2666 (elf_symtab_read): Update.
2667 (elf_rel_plt_read): Update.
2668 * mdebugread.c (parse_partial_symbols): Update.
2669 (handle_psymbol_enumerators): Update.
2670 (new_symbol): Update.
2671 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2672 to use gdb::string_view instead of name+len.
2673 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2674 * psympriv.h (add_psymbol_to_list): Likewise.
2675 * psymtab.c (add_psymbol_to_bcache): Likewise.
2676 (add_psymbol_to_list): Likewise.
2677 * stabsread.c (define_symbol): Update.
2678 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2679 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2680 (symbol_set_names): Likewise.
2681 * xcoffread.c (scan_xcoff_symtab): Update.
2682
0c921b21
CB		 26832019-10-29 Christian Biesinger <cbiesinger@google.com>
2684
2685 * symtab.h (symbol_set_names): Document that copy_name must be
2686 set to true for non-nullterminated strings.
2687 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2688 linkage_name if the entry was not found and we need to demangle.
2689
35e65c49
CB		 26902019-10-29 Christian Biesinger <cbiesinger@google.com>
2691
2692 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2693 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2694 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2695 * gdbsupport/gdb_binary_search.h: New file.
2696
ed2a2229
CB		 26972019-10-29 Christian Biesinger <cbiesinger@google.com>
2698
2699 * NEWS: Mention new --with-system-gdbinit-dir option.
2700 * config.in: Regenerate.
2701 * configure: Regenerate.
2702 * configure.ac: Add new option --with-system-gdbinit-dir.
2703 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2704 for a ".gdb" suffix.
2705 * main.c (get_init_files): Change system_gdbinit argument to
2706 a vector and return the files in SYSTEM_GDBINIT_DIR in
2707 addition to SYSTEM_GDBINIT.
2708 (captured_main_1): Update.
2709 (print_gdb_help): Update.
2710 * top.c (print_gdb_configuration): Also print the value of
2711 SYSTEM_GDBINIT_DIR.
2712
87f34879
CB		 27132019-10-28 Christian Biesinger <cbiesinger@google.com>
2714
2715 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2716 that takes gdb::string_view arguments.
2717
30baf67b
TV		 27182019-10-26 Tom de Vries <tdevries@suse.de>
2719
2720 * aarch64-linux-tdep.c: Fix typos in comments.
2721 * aarch64-tdep.c: Same.
2722 * ada-lang.c: Same.
2723 * amd64-nat.c: Same.
2724 * arc-tdep.c: Same.
2725 * arch/aarch64-insn.c: Same.
2726 * block.c: Same.
2727 * breakpoint.h: Same.
2728 * btrace.h: Same.
2729 * c-varobj.c: Same.
2730 * cli/cli-decode.c: Same.
2731 * cli/cli-script.c: Same.
2732 * cli/cli-utils.h: Same.
2733 * coff-pe-read.c: Same.
2734 * coffread.c: Same.
2735 * compile/compile-cplus-symbols.c: Same.
2736 * compile/compile-object-run.c: Same.
2737 * completer.c: Same.
2738 * corelow.c: Same.
2739 * cp-support.c: Same.
2740 * demangle.c: Same.
2741 * dwarf-index-write.c: Same.
2742 * dwarf2-frame.c: Same.
2743 * dwarf2-frame.h: Same.
2744 * eval.c: Same.
2745 * frame-base.h: Same.
2746 * frame.h: Same.
2747 * gdbcmd.h: Same.
2748 * gdbtypes.h: Same.
2749 * gnu-nat.c: Same.
2750 * guile/scm-objfile.c: Same.
2751 * i386-tdep.c: Same.
2752 * i386-tdep.h: Same.
2753 * infcall.c: Same.
2754 * infcall.h: Same.
2755 * linux-nat.c: Same.
2756 * m68k-tdep.c: Same.
2757 * macroexp.c: Same.
2758 * memattr.c: Same.
2759 * mi/mi-cmd-disas.c: Same.
2760 * mi/mi-getopt.h: Same.
2761 * mi/mi-main.c: Same.
2762 * minsyms.c: Same.
2763 * nat/aarch64-sve-linux-sigcontext.h: Same.
2764 * objfiles.h: Same.
2765 * ppc-linux-nat.c: Same.
2766 * ppc-linux-tdep.c: Same.
2767 * ppc-tdep.h: Same.
2768 * progspace.h: Same.
2769 * prologue-value.h: Same.
2770 * python/py-evtregistry.c: Same.
2771 * python/py-instruction.h: Same.
2772 * record-btrace.c: Same.
2773 * record-full.c: Same.
2774 * remote.c: Same.
2775 * rs6000-tdep.c: Same.
2776 * ser-tcp.c: Same.
2777 * sol-thread.c: Same.
2778 * sparc-sol2-tdep.c: Same.
2779 * sparc64-tdep.c: Same.
2780 * stabsread.c: Same.
2781 * symfile.c: Same.
2782 * symtab.h: Same.
2783 * target.c: Same.
2784 * tracepoint.c: Same.
2785 * tui/tui-data.h: Same.
2786 * tui/tui-io.c: Same.
2787 * tui/tui-win.c: Same.
2788 * tui/tui.c: Same.
2789 * unittests/rsp-low-selftests.c: Same.
2790 * user-regs.h: Same.
2791 * utils.c: Same.
2792 * utils.h: Same.
2793 * valarith.c: Same.
2794 * valops.c: Same.
2795 * valprint.c: Same.
2796 * valprint.h: Same.
2797 * value.c: Same.
2798 * value.h: Same.
2799 * varobj.c: Same.
2800 * x86-nat.h: Same.
2801 * xtensa-tdep.c: Same.
2802
1834d45f
AT		 28032019-10-25 Ali Tamur <tamur@google.com>
2804
2805 * charset.c (find_charset_names): Reflect API change.
2806
5396ae17
CB		 28072019-10-25 Christian Biesinger <cbiesinger@google.com>
2808
2809 * symtab.c (struct demangled_name_entry): Change demangled name
2810 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2811 part of the struct anymore.
2812 (symbol_set_names): No longer obstack allocate + copy the demangled
2813 name, just store the allocated name from bfd.
2814
93878f47
TT		 28152019-10-25 Tom Tromey <tromey@adacore.com>
2816
2817 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2818 (bsearch_cie_cmp, add_cie): Remove.
2819 (find_cie): Reimplement.
2820 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2821 (dwarf2_build_frame_info): Update.
2822
7b71fc97
L		 28232019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2824
2825 PR gdb/25126
2826 * symfile.c (reread_symbols): Call forget_cached_source_info to
2827 clear the stale source cache.
2828
cbb5a2ea
CB		 28292019-10-24 Christian Biesinger <cbiesinger@google.com>
2830
2831 * configure: Regenerate.
2832 * configure.ac: Remove code that sets python_has_threads.
2833
71737c43
CB		 28342019-10-24 Christian Biesinger <cbiesinger@google.com>
2835
2836 * config.in: Regenerate.
2837 * configure: Regenerate.
2838 * configure.ac: Remove the code that uses sed to get the python
2839 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2840
33d569b7
AB		 28412019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2842
2843 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2844 error paths.
2845
f16f7b7c
TT		 28462019-10-23 Tom Tromey <tom@tromey.com>
2847
2848 * arc-tdep.c: Remove ".." from include.
2849 * frv-tdep.c: Remove ".." from include.
2850 * lm32-tdep.c: Remove ".." from include.
2851 * microblaze-tdep.c: Remove ".." from include.
2852 * or1k-tdep.h: Remove ".." from include.
2853 * s12z-tdep.c: Remove ".." from include.
2854 * Makefile.in (OPCODES_CFLAGS): Add comment.
2855 (TOP_CFLAGS): New variable.
2856 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2857
6999161a
TT		 28582019-10-23 Tom Tromey <tom@tromey.com>
2859
2860 * Makefile.in (READLINE_DIR): Update.
2861
12e7c35e
TBA		 28622019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2863
2864 * infcall.c (call_function_by_hand_dummy): Fix the function
2865 comment. And extract out a code section into...
2866 (reserve_stack_space): ...this new function.
2867
37055cad
TBA		 28682019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2869
2870 * infcall.c (value_arg_coerce): Remove an unused parameter.
2871 (call_function_by_hand_dummy): Update the call to
2872 'value_arg_coerce'.
2873
39bcc47c
TBA		 28742019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2875
2876 * infcall.c (call_function_by_hand_dummy): Refactor.
2877
bd888c0f
TBA		 28782019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2879
2880 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2881
c12d372d
TT		 28822019-10-23 Tom Tromey <tom@tromey.com>
2883
2884 * configure: Rebuild.
2885 * configure.ac: Don't check for sigprocmask.
2886 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2887
4d0b984b
TT		 28882019-10-23 Tom Tromey <tom@tromey.com>
2889
2890 * configure: Rebuild.
2891 * acinclude.m4: Use m4_include, not sinclude.
2892
7e785608
TV		 28932019-10-23 Tom de Vries <tdevries@suse.de>
2894
2895 PR breakpoints/24687
2896 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2897
403772ef
CB		 28982019-10-22 Christian Biesinger <cbiesinger@google.com>
2899
2900 * symtab.c (struct demangled_name_entry) <language>: Change from
2901 bitfield to regular variable.
2902
3a494279
CB		 29032019-10-22 Christian Biesinger <cbiesinger@google.com>
2904
2905 * symtab.c (struct demangled_name_entry): Add a constructor.
2906 (free_demangled_name_entry): New function to call the destructor
2907 for demangled_name_entry.
2908 (create_demangled_names_hash): Pass free_demangled_name_entry to
2909 htab_create_alloc.
2910 (symbol_set_names): Call placement new for demangled_name_entry.
2911 * utils.c: No longer include xxhash.h here, now that fast_hash
2912 is inlined in the header.
2913 * utils.h: Instead, include it here.
2914
ccb1ba62
CB		 29152019-10-22 Christian Biesinger <cbiesinger@google.com>
2916
2917 * Makefile.in: Link with libxxhash.
2918 * config.in: Regenerate.
2919 * configure: Regenerate.
2920 * configure.ac: Search for libxxhash.
2921 * utils.c (fast_hash): Use xxhash if present.
2922
1a6ff1a9
CB		 29232019-10-22 Christian Biesinger <cbiesinger@google.com>
2924
2925 * utils.h (fast_hash): New function.
2926 * symtab.c (hash_demangled_name_entry): Call new function
2927 fast_hash.
2928
7bb43059
CB		 29292019-10-22 Christian Biesinger <cbiesinger@google.com>
2930
2931 * symtab.c (struct demangled_name_entry): Change type of mangled
2932 to gdb::string_view. Also adds a constructor that takes the
2933 mangled name.
2934 (hash_demangled_name_entry): Update.
2935 (eq_demangled_name_entry): Update.
2936 (free_demangled_name_entry): New function to call the destructor
2937 now that this is not a POD anymore.
2938 (create_demangled_names_hash): Pass free_demangled_name_entry to
2939 htab_create_alloc.
2940 (symbol_set_names): Update.
2941
7ba99d21
AT		 29422019-10-21 Ali Tamur <tamu@google.com>
2943
2944 * dwarf2read.c (dir_index): Change type.
2945 (file_name_index): Likewise.
2946 (line_header::include_dir_at): Change comment and implementation on
2947 whether it is DWARF 5.
2948 (line_header::is_valid_file_index): New function.
2949 (line_header::file_name_at): Change comment and implementation on
2950 whether it is DWARF 5.
2951 (line_header::file_names): Change to private field renamed as
2952 m_file_names and introduce a new accessor method.
2953 (line_header::file_names_size): New method.
2954 (line_header::include_dirs): Change to private field and rename as
2955 m_include_dirs.
2956 (dw2_get_file_names_reader): Define local var at a smaller scope and
2957 reflect API change.
2958 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2959 (process_structure_scope): Likewise.
2960 (line_header::add_include_dir): Change message and reflect renaming.
2961 (line_header::add_file_name): Likewise.
2962 (read_formatted_entries): Handle DW_FORM_data16.
2963 (dwarf_decode_line_header): Fix line header length calculation.
2964 (psymtab_include_file_name): Change comment and API.
2965 (lnp_state_machine::m_file): Update comment and reflect type change.
2966 (lnp_state_machine::record_line): Reflect type change.
2967 (dwarf_decode_lines): Reflect API change.
2968 (file_file_name): Likewise.
2969 (file_full_name): Likewise.
2970
45f47c3a
AB		 29712019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2972
2973 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2974
e5f3c0e3
TT		 29752019-10-21 Tom Tromey <tom@tromey.com>
2976
2977 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2978
a0a461e5
TT		 29792019-10-21 Tom Tromey <tom@tromey.com>
2980
2981 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2982 NM_H. Use AC_CONFIG_LINKS.
2983 * configure: Rebuild.
2984 * Makefile.in (NM_H): New variable.
2985 (generated_files): Add NM_H. Remove gcore.
2986 (nm.h, stamp-nmh): New targets.
2987
54d83b8d
TT		 29882019-10-20 Tom Tromey <tom@tromey.com>
2989
2990 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2991 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2992 obsolete comment.
2993 (put_objfile_before): Now static.
2994
23771117
SM		 29952019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2996
2997 * gdbsupport/common-utils.h (startswith): Change return type to
2998 bool.
2999
39ef2f62
CB		 30002019-10-19 Christian Biesinger <cbiesinger@google.com>
3001
3002 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3003 * breakpoint.c (bp_locations_compare): Rename to...
3004 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3005 (update_global_location_list): Use std::sort instead of qsort.
3006 * buildsym.c (compare_line_numbers): Rename to...
3007 (lte_is_less_than): ...this, and change to std::sort semantics.
3008 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3009 instead of qsort.
3010 * disasm.c (compare_lines): Rename to...
3011 (line_is_less_than): ...this, and change to std::sort semantics.
3012 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3013 of qsort.
3014 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3015 (fde_is_less_than): ...this, and change to std::sort semantics.
3016 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3017 * mdebugread.c (compare_blocks):
3018 (block_is_less_than): ...this, and change to std::sort semantics.
3019 (sort_blocks): Call std::sort instead of qsort.
3020 * objfiles.c (qsort_cmp): Rename to...
3021 (sort_cmp): ...this, and change to std::sort semantics.
3022 (update_section_map): Call std::sort instead of qsort.
3023 * remote.c (compare_pnums): Remove.
3024 (map_regcache_remote_table): Call std::sort instead of qsort.
3025 * utils.c (compare_positive_ints): Remove.
3026 * utils.h (compare_positive_ints): Remove.
3027 * xcoffread.c (compare_lte): Remove.
3028 (arrange_linetable): Call std::sort instead of qsort.
3029
f71433ee
SDJ		 30302019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3031
3032 * symfile.c (init_entry_point_info): Fix typo.
3033 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3034
85102364
TV		 30352019-10-18 Tom de Vries <tdevries@suse.de>
3036
3037 * aarch64-tdep.c: Fix typos in comments.
3038 * ada-lang.c: Same.
3039 * ada-tasks.c: Same.
3040 * alpha-tdep.c: Same.
3041 * alpha-tdep.h: Same.
3042 * amd64-nat.c: Same.
3043 * amd64-windows-tdep.c: Same.
3044 * arc-tdep.c: Same.
3045 * arc-tdep.h: Same.
3046 * arch-utils.c: Same.
3047 * arm-nbsd-tdep.c: Same.
3048 * arm-tdep.c: Same.
3049 * ax-gdb.c: Same.
3050 * blockframe.c: Same.
3051 * btrace.c: Same.
3052 * c-varobj.c: Same.
3053 * coff-pe-read.c: Same.
3054 * coffread.c: Same.
3055 * cris-tdep.c: Same.
3056 * darwin-nat.c: Same.
3057 * dbxread.c: Same.
3058 * dcache.c: Same.
3059 * disasm.c: Same.
3060 * dtrace-probe.c: Same.
3061 * dwarf-index-write.c: Same.
3062 * dwarf2-frame-tailcall.c: Same.
3063 * dwarf2-frame.c: Same.
3064 * dwarf2read.c: Same.
3065 * eval.c: Same.
3066 * exceptions.c: Same.
3067 * fbsd-tdep.c: Same.
3068 * findvar.c: Same.
3069 * frame.c: Same.
3070 * frv-tdep.c: Same.
3071 * gnu-v3-abi.c: Same.
3072 * go32-nat.c: Same.
3073 * h8300-tdep.c: Same.
3074 * hppa-tdep.c: Same.
3075 * i386-linux-tdep.c: Same.
3076 * i386-tdep.c: Same.
3077 * ia64-libunwind-tdep.c: Same.
3078 * ia64-tdep.c: Same.
3079 * infcmd.c: Same.
3080 * infrun.c: Same.
3081 * linespec.c: Same.
3082 * linux-nat.c: Same.
3083 * linux-thread-db.c: Same.
3084 * machoread.c: Same.
3085 * mdebugread.c: Same.
3086 * mep-tdep.c: Same.
3087 * mn10300-tdep.c: Same.
3088 * namespace.c: Same.
3089 * objfiles.c: Same.
3090 * opencl-lang.c: Same.
3091 * or1k-tdep.c: Same.
3092 * osabi.c: Same.
3093 * ppc-linux-nat.c: Same.
3094 * ppc-linux-tdep.c: Same.
3095 * ppc-sysv-tdep.c: Same.
3096 * printcmd.c: Same.
3097 * procfs.c: Same.
3098 * record-btrace.c: Same.
3099 * record-full.c: Same.
3100 * remote-fileio.c: Same.
3101 * remote.c: Same.
3102 * rs6000-tdep.c: Same.
3103 * s12z-tdep.c: Same.
3104 * score-tdep.c: Same.
3105 * ser-base.c: Same.
3106 * ser-go32.c: Same.
3107 * skip.c: Same.
3108 * sol-thread.c: Same.
3109 * solib-svr4.c: Same.
3110 * solib.c: Same.
3111 * source.c: Same.
3112 * sparc-nat.c: Same.
3113 * sparc-sol2-tdep.c: Same.
3114 * sparc-tdep.c: Same.
3115 * sparc64-tdep.c: Same.
3116 * stabsread.c: Same.
3117 * stack.c: Same.
3118 * symfile.c: Same.
3119 * symtab.c: Same.
3120 * target-descriptions.c: Same.
3121 * target-float.c: Same.
3122 * thread.c: Same.
3123 * utils.c: Same.
3124 * valops.c: Same.
3125 * valprint.c: Same.
3126 * value.c: Same.
3127 * varobj.c: Same.
3128 * windows-nat.c: Same.
3129 * xcoffread.c: Same.
3130 * xstormy16-tdep.c: Same.
3131 * xtensa-tdep.c: Same.
3132
c5adaa19
TT		 31332019-10-17 Tom Tromey <tromey@adacore.com>
3134
3135 * configure: Rebuild.
3136 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3137 in AC_CONFIG_FILES invocation.
3138 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3139 new-style config.status invocation.
3140
405feb71
TV		 31412019-10-17 Tom de Vries <tdevries@suse.de>
3142
3143 * arm-nbsd-nat.c: Fix typos in comments.
3144 * arm-tdep.c: Same.
3145 * darwin-nat-info.c: Same.
3146 * dwarf2read.c: Same.
3147 * elfread.c: Same.
3148 * event-top.c: Same.
3149 * findvar.c: Same.
3150 * gdbtypes.c: Same.
3151 * hppa-tdep.c: Same.
3152 * i386-tdep.c: Same.
3153 * jit.c: Same.
3154 * main.c: Same.
3155 * mdebugread.c: Same.
3156 * moxie-tdep.c: Same.
3157 * nto-procfs.c: Same.
3158 * osabi.c: Same.
3159 * ppc-linux-tdep.c: Same.
3160 * remote.c: Same.
3161 * riscv-tdep.c: Same.
3162 * s390-tdep.c: Same.
3163 * sh-tdep.c: Same.
3164 * sparc-linux-tdep.c: Same.
3165 * sparc-nat.c: Same.
3166 * stack.c: Same.
3167 * target-descriptions.c: Same.
3168 * top.c: Same.
3169 * varobj.c: Same.
3170
befcd486
TT		 31712019-10-16 Tom Tromey <tom@tromey.com>
3172
3173 * objfiles.h (struct objfile) <original_name>: Now const.
3174
17bfe554
CB		 31752019-10-16 Christian Biesinger <cbiesinger@google.com>
3176
3177 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3178 pass on to sigsetjmp's second argument.
3179 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3180
950b7495
KS		 31812019-10-16 Keith Seitz <keiths@redhat.com>
3182
3183 PR gdb/23567
3184 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3185 sections whose size is greater than the file size.
3186
ff371ec9
JW		 31872019-10-16 Jim Wilson <jimw@sifive.com>
3188
3189 * riscv-tdep.c (riscv_gcc_target_options): New.
3190 (riscv_gnu_triplet_regexp): New.
3191 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3192 set_gdbarch_gnu_triplet_regexp.
3193
fec4e896
CB		 31942019-10-16 Christian Biesinger <cbiesinger@google.com>
3195
3196 * Makefile.in: Add xml-builtin.h.
3197 * features/feature_to_c.sh: Add an include for xml-builtin.h
3198 to ensure that the compiler checks that the types match.
3199 * xml-builtin.h: New file.
3200 * xml-support.c (fetch_xml_builtin): Add missing const.
3201 * xml-support.h: Remove declaration of xml_builtins.
3202
d10eccaa
TV		 32032019-10-16 Tom de Vries <tdevries@suse.de>
3204
3205 PR tdep/25096
3206 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3207 (amd64_classify_aggregate): ... here.
3208 (amd64_classify_aggregate_field): Handled fiels of nested structs
3209 recursively.
3210
745ff14e
TV		 32112019-10-16 Tom de Vries <tdevries@suse.de>
3212
3213 PR tdep/24104
3214 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3215 that handles 'theclass'.
3216
791b7405
AB		 32172019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3218
3219 * linespec.c (decode_digits_ordinary): Update comment.
3220 * make-target-delegates: No longer need to handle VEC case.
3221 * memrange.c (normalize_mem_ranges): Update comment.
3222 * namespace.c (add_using_directive): Update comment.
3223 * objc-lang.c (uniquify_strings): Update comment.
3224 * ppc-linux-nat.c (struct thread_points): Update comment.
3225 * probe.h (find_probes_in_objfile): Update comment.
3226 * target.h (enum flash_preserve_mode): Update comment.
3227 * varobj.c (varobj_restrict_range): Update comment.
3228 * varobj.h (varobj_list_children): Update comment.
3229
0dc32745
AB		 32302019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3231
3232 * Makefile.in: Remove references to vec.h and vec.c.
3233 * aarch64-tdep.c: No longer include vec.h.
3234 * ada-lang.c: Likewise.
3235 * ada-lang.h: Likewise.
3236 * arm-tdep.c: Likewise.
3237 * ax.h: Likewise.
3238 * breakpoint.h: Likewise.
3239 * charset.c: Likewise.
3240 * cp-support.h: Likewise.
3241 * dtrace-probe.c: Likewise.
3242 * dwarf2read.c: Likewise.
3243 * extension.h: Likewise.
3244 * gdb_bfd.c: Likewise.
3245 * gdbsupport/gdb_vecs.h: Likewise.
3246 * gdbsupport/vec.c: Remove.
3247 * gdbsupport/vec.h: Remove.
3248 * gdbthread.h: Likewise.
3249 * guile/scm-type.c: Likewise.
3250 * inline-frame.c: Likewise.
3251 * machoread.c: Likewise.
3252 * memattr.c: Likewise.
3253 * memrange.h: Likewise.
3254 * namespace.h: Likewise.
3255 * nat/linux-btrace.h: Likewise.
3256 * osdata.c: Likewise.
3257 * parser-defs.h: Likewise.
3258 * progspace.h: Likewise.
3259 * python/py-type.c: Likewise.
3260 * record-btrace.c: Likewise.
3261 * rust-exp.y: Likewise.
3262 * solib-target.c: Likewise.
3263 * stap-probe.c: Likewise.
3264 * target-descriptions.c: Likewise.
3265 * target-memory.c: Likewise.
3266 * target.h: Likewise.
3267 * varobj.c: Likewise.
3268 * varobj.h: Likewise.
3269 * xml-support.h: Likewise.
3270
ae640021
AB		 32712019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3272
3273 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3274 Update for new std::vector based implementation.
3275 (process_psymtab_comp_unit_reader): Likewise.
3276 (scan_partial_symbols): Likewise.
3277 (recursively_compute_inclusions): Likewise.
3278 (compute_compunit_symtab_includes): Likewise.
3279 (process_imported_unit_die): Likewise.
3280 (queue_and_load_dwo_tu): Likewise.
3281 (follow_die_sig_1): Likewise.
3282 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3283 (typedef dwarf2_per_cu_ptr): Remove.
3284 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3285 function.
3286 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3287 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3288 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3289 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3290 std::vector.
3291
55dfc88f
TT		 32922019-10-15 Tom Tromey <tromey@adacore.com>
3293
3294 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3295 TID.
3296
96b49c5e
TT		 32972019-10-15 Tom Tromey <tromey@adacore.com>
3298
3299 * windows-nat.c (windows_nat_target::fetch_registers)
3300 (windows_nat_target::store_registers): Rename "pid" to "tid".
3301
953cff56
TT		 33022019-10-15 Tom Tromey <tromey@adacore.com>
3303
3304 * gdbarch.h, gdbarch.c: Rebuild.
3305 * gdbarch.sh (gcc_target_options): Change return type to
3306 std::string.
3307 * compile/compile.c (get_args): Update.
3308 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3309 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3310 std::string.
3311 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3312 std::string.
3313 * arch-utils.c (default_gcc_target_options): Return std::string.
3314 * arch-utils.h (default_gcc_target_options): Return std::string.
3315 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3316
81e6b8eb
CB		 33172019-10-15 Christian Biesinger <cbiesinger@google.com>
3318
3319 * breakpoint.c (breakpoint_chain): Make static.
3320 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3321 of accessing breakpoint_chain.
3322
95da600f
CB		 33232019-10-15 Christian Biesinger <cbiesinger@google.com>
3324
3325 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3326 to a gdb::function_view and return value to bool.
3327 * breakpoint.h (iterate_over_breakpoints): Likewise.
3328 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3329 (pop_dummy_frame): Update.
3330 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3331 (gdbscm_breakpoints): Update.
3332 * python/py-breakpoint.c (build_bp_list): Update.
3333 (gdbpy_breakpoints): Update.
3334 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3335 Update.
3336 (bpfinishpy_handle_stop): Update.
3337 (bpfinishpy_handle_exit): Update.
3338 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3339 (svr4_update_solib_event_breakpoints): Update.
3340
ba18312d
AA		 33412019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3342
3343 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3344 when unwrapping single-field structs.
3345
6acc1a0b
SM		 33462019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3347
3348 * dwarf2read.c: Remove includes.
3349
284782de
SM		 33502019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3351
3352 * ui-out.c (ui_out::call_do_message): Silence
3353 -Wformat-nonliteral warning.
3354
073bbbb0
SM		 33552019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3356
3357 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3358 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3359 include: readline/tilde.h.
3360
7b9a15e1
CB		 33612019-10-12 Christian Biesinger <cbiesinger@google.com>
3362
3363 * remote.c (remote_target::get_trace_status): Remove declaration of
3364 trace_regblock_size.
3365
cc8dee1f
CB		 33662019-10-12 Christian Biesinger <cbiesinger@google.com>
3367
3368 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3369 (show_user): Remove declaration of cmdlist.
3370 * cli/cli-cmds.h (max_user_call_depth): Declare.
3371 * cli/cli-script.c (execute_user_command): Remove declaration
3372 of max_user_call_depth.
3373
a83d4ef6
JW		 33742019-10-11 Jim Wilson <jimw@sifive.com>
3375
5f93c5a6
JW		 3376 * gdbsupport/print-utils.h (pulongest): Fix comment.
3377 (plongest): Likewise.
3378 (phex): Add missing comment, mention leading zeros.
3379 (phex_nz): Add mention of no leading zeros to comment.
3380
a83d4ef6
JW		 3381 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3382 plongest instead of unsigned long long cast.
3383
26344e0c
CB		 33842019-10-10 Christian Biesinger <cbiesinger@google.com>
3385
3386 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3387 for external_editor_command and gdbtk_test.
3388
c2c440a9
CB		 33892019-10-10 Christian Biesinger <cbiesinger@google.com>
3390
3391 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3392 * varobj.c (varobjdebug): Move comment to...
3393 * varobj.h (varobjdebug): ...here, and declare.
3394
a31bff9d
TT		 33952019-10-09 Tom Tromey <tom@tromey.com>
3396
3397 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3398 erase_data_content.
3399
7523da63
TT		 34002019-10-09 Tom Tromey <tom@tromey.com>
3401
3402 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3403 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3404 * tui/tui-command.c (tui_cmd_window::resize)
3405 (tui_refresh_cmd_win): Update.
3406 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3407 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3408 * tui/tui-data.c (~tui_gen_win_info): Remove.
3409 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3410 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3411 (tui_redisplay_readline, tui_mld_flush)
3412 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3413 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3414 (tui_data_window::erase_data_content)
3415 (tui_data_item_window::rerender)
3416 (tui_data_item_window::refresh_window): Update.
3417 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3418 (box_win, tui_gen_win_info::make_window)
3419 (tui_gen_win_info::make_visible): Update.
3420 (tui_delete_win): Remove.
3421 * tui/tui-winsource.c
3422 (tui_source_window_base::do_erase_source_content): Update.
3423 (tui_show_source_line, tui_source_window_base::update_tab_width)
3424 (tui_source_window_base::update_exec_info): Update.
3425 * tui/tui-data.h (struct curses_deleter): New.
3426 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3427 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3428
a7798e7f
TT		 34292019-10-09 Tom Tromey <tom@tromey.com>
3430
3431 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3432
5c45899e
TT		 34332019-10-09 Tom Tromey <tom@tromey.com>
3434
3435 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3436 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3437
6d7fd9aa
TT		 34382019-10-09 Tom Tromey <tom@tromey.com>
3439
3440 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3441 window height directly.
3442 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3443 declare.
3444 * tui/tui-layout.c (tui_default_win_height): Remove.
3445 (tui_default_win_viewport_height): Remove.
3446
d2dd1084
TT		 34472019-10-09 Tom Tromey <tom@tromey.com>
3448
3449 * tui/tui.h: Remove comments.
3450
cff32449
TV		 34512019-10-09 Tom de Vries <tdevries@suse.de>
3452
3453 * python/lib/gdb/printer/bound_registers.py: Use
3454 '^builtin_type_bound128' as regexp argument for
3455 add_builtin_pretty_printer.
3456
6a25e8a2
CB		 34572019-10-09 Christian Biesinger <cbiesinger@google.com>
3458
3459 * guile/guile.c (guile_extension_script_ops): Remove forward
3460 declaration and mark as static.
3461 (guile_script_ops): Likewise.
3462 (extension_language_guile): Move further down in the file so
3463 it can reference the definitions for guile_{extension_,}script_ops.
3464
6d9d6da4
AA		 34652019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3466
3467 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3468 except SORTL, DFLTCC, and KDSA.
3469
3abea05d
TT		 34702019-10-08 Tom Tromey <tromey@adacore.com>
3471
3472 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3473 (struct safe_symbol_file_add_args): Remove.
3474
dde996e2
TT		 34752019-10-08 Tom Tromey <tromey@adacore.com>
3476
3477 * windows-nat.c: Don't include buildsym-legacy.h.
3478
cd6fdaa1
TT		 34792019-10-08 Tom Tromey <tromey@adacore.com>
3480
3481 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3482
79bb1944
CB		 34832019-10-08 Christian Biesinger <cbiesinger@google.com>
3484
3485 * gdbtypes.c (overload_debug): Move comment to header.
3486 * gdbtypes.h (overload_debug): Declare.
3487 * valops.c: Remove declaration of overload_debug, instead
3488 include gdbtypes.h.
3489
34916edc
CB		 34902019-10-08 Christian Biesinger <cbiesinger@google.com>
3491
3492 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3493 through _().
3494 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3495 move comment...
3496 * language.h (lang_frame_mismatch_warn): ... here. Also add
3497 declaration.
3498 * top.c (lang_frame_mismatch_warn): Remove declaration.
3499 (check_frame_language_change): Pass lang_frame_mismatch_warn
3500 through _().
3501
bad5c026
CB		 35022019-10-07 Christian Biesinger <cbiesinger@google.com>
3503
3504 * c-lang.h (vtbl_ptr_name): Declare.
3505 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3506 it from the header.
3507 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3508
51f1fdc3
CB		 35092019-10-07 Christian Biesinger <cbiesinger@google.com>
3510
3511 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3512 gdb_static_assert.
3513
30d1f018
WP		 35142019-10-07 Weimin Pan <weimin.pan@oracle.com>
3515
606813d5
WP		 3516 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3517 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3518 * ctfread.c: New file.
3519 * ctfread.h: New file.
3520 * elfread.c: Include ctfread.h.
3521 (struct elfinfo text_p): New member ctfsect.
3522 (elf_locate_sections): Mark CTF section.
3523 (elf_symfile_read): Call elfctf_build_psymtabs.
3524 * Makefile.in (LIBCTF): Add.
3525 (CLIBS): Use it.
3526 (CDEPS): Likewise.
3527 (DIST): Add ctfread.c.
606813d5
WP		 3528
35292019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3530
3531 * ctfread.c (struct nextfield): Renamed to ...
3532 (struct ctf_nextfield): ... this.
3533 (struct field_info): Renamed to ...
3534 (strut ctf_field_info): ... this.
3535 (attach_fields_to_type): Update for renamed structures.
3536 (ctf_add_member_cb): Likewise.
3537 (ctf_add_enum_member_cb): Likewise.
3538 (process_struct_members): Likewise.
3539 (process_enum_type): Likewise.
30d1f018 3540
518fe38c
WP		 35412019-10-07 Weimin Pan <weimin.pan@oracle.com>
3542
3543 * tracectf.h: Rename, was ctf.h.
3544 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3545 * tracefile.c: Likewise.
3546 * tracepoint.c: Remove unused include ctf.h.
3547 * mi/mi-main.c: Likewise.
3548 * Makefile.in Replace ctf.c with tracectf.c.
3549
225f296a
JB		 35502019-10-06 Joel Brobecker <brobecker@adacore.com>
3551
3552 * version.in: Change version number to "9.0.50.DATE-git".
3553
77c2dba3
TT		 35542019-10-03 Tom Tromey <tom@tromey.com>
3555
3556 PR rust/24976:
3557 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3558
179aed7f
AB		 35592019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3560
3561 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3562 cp_search_name_hash.
3563 * NEWS: Add entry about nested function support.
3564
0a4b0913
AB		 35652019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3566 Andrew Burgess <andrew.burgess@embecosm.com>
3567
3568 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3569 for nested static variables when searchin VAR_DOMAIN.
3570 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3571 global scope, update comment.
3572 (add_partial_subprogram): Call add_partial_subprogram recursively
3573 for nested subroutines when processinng Fortran.
3574 (load_partial_dies): Process the child entities of a subprogram
3575 when processing Fortran.
3576 (partial_die_parent_scope): Handle building scope
3577 for Fortran nested functions.
3578 (process_die): Record that nested functions have a scope.
3579 (new_symbol): Always record Fortran subprograms on the global
3580 symbol list.
3581 (determine_prefix): How to build the prefix for Fortran
3582 subprograms.
3583
d8c06f22
AB		 35842019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3585
3586 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3587 have just sent the thread a SIGSTOP and are waiting for it to
3588 arrive.
3589
a8b3b8e9
AB		 35902019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3591
3592 * btrace.c (btrace_add_pc): Remove whitespace before the template
3593 parameter in 'std::vector <...>'.
3594 (parse_xml_btrace_block): Likewise.
3595 (btrace_maint_decode_pt): Likewise.
3596 (btrace_maint_update_packets): Likewise.
3597 (btrace_maint_print_packets): Likewise.
3598 * btrace.h (struct btrace_maint_info): Likewise.
3599 * dwarf2read.c (struct type_unit_group): Likewise.
3600 (build_type_psymtabs_reader): Likewise.
3601 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3602 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3603 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3604
4d825eab
TV		 36052019-10-03 Tom de Vries <tdevries@suse.de>
3606
3607 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3608 the first line of the help text for set/show style metadata.
3609
80fd2826
TT		 36102019-10-02 Tom Tromey <tromey@adacore.com>
3611
3612 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3613 * gdbsupport/common-inferior.c: New file.
3614 * infcmd.c (startup_with_shell): Don't define.
3615 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3616 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3617 * inferior.h (startup_with_shell): Don't declare.
3618
70054538
CB		 36192019-10-02 Christian Biesinger <cbiesinger@google.com>
3620
3621 * gdbsupport/gdb_assert.h: Include errors.h.
3622 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3623
37f6a7f4
TT		 36242019-10-02 Tom Tromey <tromey@adacore.com>
3625
3626 * NEWS: Add $_ada_exception entry.
3627 * ada-lang.c (struct ada_catchpoint): Add constructor.
3628 <m_kind>: New member.
3629 (allocate_location_exception, re_set_exception): Remove
3630 "ex" parameter.
3631 (should_stop_exception): Compute $_ada_exception.
3632 (check_status_exception, print_it_exception)
3633 (print_one_exception, print_mention_exception): Remove
3634 "ex" parameter.
3635 (allocate_location_catch_exception, re_set_catch_exception)
3636 (check_status_exception, print_it_catch_exception)
3637 (print_one_catch_exception, print_mention_catch_exception)
3638 (print_recreate_catch_exception)
3639 (allocate_location_catch_exception_unhandled)
3640 (re_set_catch_exception_unhandled)
3641 (check_status_exception, print_it_catch_exception_unhandled)
3642 (print_one_catch_exception_unhandled)
3643 (print_mention_catch_exception_unhandled)
3644 (print_recreate_catch_exception_unhandled)
3645 (allocate_location_catch_assert, re_set_catch_assert)
3646 (check_status_assert, print_it_catch_assert)
3647 (print_one_catch_assert, print_mention_catch_assert)
3648 (print_recreate_catch_assert)
3649 (allocate_location_catch_handlers, re_set_catch_handlers)
3650 (check_status_handlers, print_it_catch_handlers)
3651 (print_one_catch_handlers, print_mention_catch_handlers)
3652 (print_recreate_catch_handlers): Remove.
3653 (create_ada_exception_catchpoint): Update.
3654 (initialize_ada_catchpoint_ops): Update.
3655
fccf9de1
TT		 36562019-10-02 Tom Tromey <tromey@adacore.com>
3657
3658 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3659 (create_excep_cond_exprs): Simplify exception string computation.
3660 (ada_exception_catchpoint_cond_string): Likewise.
3661
4b610737
TT		 36622019-10-02 Tom Tromey <tromey@adacore.com>
3663
3664 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3665 * ada-lang.c (lesseq_defined_than): Handle
3666 LOC_STATIC.
3667 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3668 parameter.
3669 (dwarf2_has_info): Likewise.
3670 (new_symbol): Set maybe_copied on symbol when
3671 appropriate.
3672 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3673 parameter.
3674 <can_copy>: New member.
3675 * elfread.c (record_minimal_symbol): Set maybe_copied
3676 on symbol when appropriate.
3677 (elf_symfile_read): Update call to dwarf2_has_info.
3678 * minsyms.c (lookup_minimal_symbol_linkage): New
3679 function.
3680 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3681 * symtab.c (get_symbol_address, get_msymbol_address):
3682 New functions.
3683 * symtab.h (get_symbol_address, get_msymbol_address):
3684 Declare.
3685 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3686 maybe_copied.
3687 (struct symbol, struct minimal_symbol) <maybe_copied>:
3688 New member.
3689
1dd58850
TT		 36902019-10-02 Tom Tromey <tromey@adacore.com>
3691
3692 * source.c (struct current_source_location): New.
3693 (current_source_key): New global.
3694 (current_source_symtab, current_source_line)
3695 (current_source_pspace): Remove.
3696 (get_source_location): New function.
3697 (get_current_source_symtab_and_line)
3698 (set_default_source_symtab_and_line)
3699 (set_current_source_symtab_and_line)
3700 (clear_current_source_symtab_and_line, select_source_symtab)
3701 (info_source_command, print_source_lines_base)
3702 (info_line_command, search_command_helper, _initialize_source):
3703 Update.
3704
5c281dbb
TT		 37052019-10-02 Tom Tromey <tromey@adacore.com>
3706
3707 * source.c (select_source_symtab): Don't call
3708 decode_line_with_current_source.
3709
d3d32391
AB		 37102019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3711
3712 * symtab.c (lookup_global_symbol): Search global block.
3713
38583298
TT		 37142019-10-02 Tom Tromey <tromey@adacore.com>
3715
3716 * coffread.c (process_coff_symbol): Update.
3717 * dwarf2read.c (var_decode_location, new_symbol): Update.
3718 * mdebugread.c (parse_symbol): Update.
3719 * objfiles.c (relocate_one_symbol): Update.
3720 * stabsread.c (define_symbol, fix_common_block)
3721 (scan_file_globals): Update.
3722 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3723 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3724 * xcoffread.c (process_xcoff_symbol): Update.
3725
9344c18f
AA		 37262019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3727
3728 * MAINTAINERS: Update my email address.
3729
df07e2c7
AB		 37302019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3731
3732 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3733 std::vector.
3734 (build_type_psymtabs_reader): Update for std::vector.
3735 (build_type_psymtab_dependencies): Likewise.
3736 * dwarf2read.h: Remove use of DEF_VEC_P.
3737 (typedef sig_type_ptr): Delete.
3738
554ac434
AB		 37392019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3740
3741 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3742 to std::vector.
3743 (btrace_maint_decode_pt): Likewise, and move allocation of the
3744 vector outside of the loop.
3745 (btrace_maint_update_packets): Update to handle change from VEC to
3746 std::vector.
3747 (btrace_maint_print_packets): Likewise.
3748 (maint_info_btrace_cmd): Likewise.
3749 * btrace.h: Remove use of DEF_VEC_O.
3750 (typedef btrace_pt_packet_s): Delete.
3751 (struct btrace_maint_info) <packets>: Change fromm VEC to
3752 std::vector.
3753 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3754
46f29a9a
AB		 37552019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3756
3757 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3758 make accesses into the vector constant references.
3759 (btrace_add_pc): Update for std::vector.
3760 (btrace_stitch_bts): Likewise.
3761 (parse_xml_btrace_block): Likewise.
3762 (btrace_maint_update_packets): Likewise.
3763 (btrace_maint_print_packets): Likewise.
3764 (maint_info_btrace_cmd): Likewise.
3765 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3766 std::vector.
3767 (btrace_data::empty): Likewise.
3768 (btrace_data_append): Likewise.
3769 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3770 (typedef btrace_block_s): Delete.
3771 (struct btrace_block): Add constructor.
3772 (struct btrace_data_bts) <blocks>: Change to std::vector.
3773 * nat/linux-btrace.c (perf_event_read_bts): Update for
3774 std::vector.
3775 (linux_read_bts): Likewise.
3776
d770d56f
TT		 37772019-10-01 Tom Tromey <tom@tromey.com>
3778
3779 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3780
9d636d67
TT		 37812019-10-01 Tom Tromey <tom@tromey.com>
3782
3783 * stack.c (print_frame, info_frame_command_core): Use
3784 styled_string.
3785 * linux-thread-db.c (try_thread_db_load_1)
3786 (try_thread_db_load_from_pdir_1): Use styled_string.
3787 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3788 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3789 (maybe_print_unsupported_script_warning)
3790 (maybe_print_script_not_found_warning): Use styled_string.
3791 * ada-lang.c (user_select_syms): Use styled_string.
3792
7f6aba03
TT		 37932019-10-01 Tom Tromey <tom@tromey.com>
3794
3795 * p-lang.c (pascal_printstr): Use metadata style.
3796 * value.c (show_convenience): Use metadata style.
3797 * valprint.c (valprint_check_validity, val_print_optimized_out)
3798 (val_print_not_saved, val_print_unavailable)
3799 (val_print_invalid_address, generic_val_print, val_print)
3800 (value_check_printable, val_print_array_elements): Use metadata
3801 style.
3802 * ui-out.h (class ui_out) <field_fmt>: New overload.
3803 <do_field_fmt>: Add style parameter.
3804 * ui-out.c (ui_out::field_fmt): New overload.
3805 * typeprint.c (type_print_unknown_return_type)
3806 (val_print_not_allocated, val_print_not_associated): Use metadata
3807 style.
3808 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3809 parameter.
3810 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3811 * tracepoint.c (tvariables_info_1): Use metadata style.
3812 * stack.c (print_frame_arg, print_frame_info, print_frame)
3813 (info_frame_command_core): Use metadata style.
3814 * skip.c (info_skip_command): Use metadata style.
3815 * rust-lang.c (rust_print_enum): Use metadata style.
3816 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3817 metadata style.
3818 * python/py-framefilter.c (py_print_single_arg): Use metadata
3819 style.
3820 * printcmd.c (do_one_display, print_variable_and_value): Use
3821 metadata style.
3822 * p-valprint.c (pascal_val_print)
3823 (pascal_object_print_value_fields): Use metadata style.
3824 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3825 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3826 parameter.
3827 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3828 * m2-valprint.c (m2_print_long_set): Use metadata style.
3829 * m2-typeprint.c (m2_print_type): Use metadata style.
3830 * infcmd.c (print_return_value_1): Use metadata style.
3831 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3832 * f-valprint.c (info_common_command_for_block): Use metadata
3833 style.
3834 * f-typeprint.c (f_type_print_base): Use metadata style.
3835 * expprint.c (print_subexp_standard): Use metadata style.
3836 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3837 * cli/cli-style.h (class cli_style_option): Add constructor.
3838 (metadata_style): Declare.
3839 * cli/cli-style.c (metadata_style): New global.
3840 (_initialize_cli_style): Register metadata style.
3841 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3842 parameter.
3843 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3844 * c-typeprint.c (c_type_print_base_struct_union)
3845 (c_type_print_base_1): Use metadata style.
3846 * breakpoint.c (watchpoint_value_print)
3847 (print_one_breakpoint_location): Use metadata style.
3848 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3849 style.
3850 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3851 style.
3852 * ada-valprint.c (val_print_packed_array_elements, printstr)
3853 (print_field_values, ada_val_print_ref, ada_val_print): Use
3854 metadata style.
3855 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3856 style.
3857 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3858 style.
3859 * ada-lang.c (user_select_syms): Use metadata style.
3860
14309bb6
TT		 38612019-10-01 Tom Tromey <tom@tromey.com>
3862
3863 * cli/cli-cmds.c (pwd_command): Style output.
3864
6a831f06
PA		 38652019-10-01 Pedro Alves <palves@redhat.com>
3866 Tom Tromey <tom@tromey.com>
3867
3868 * symtab.c (print_symbol_info): Use %ps.
3869 (print_msymbol_info): Use %ps.
3870 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3871 * printcmd.c (print_variable_and_value): Use %ps.
3872 * macrocmd.c (show_pp_source_pos): Use %ps.
3873 * infrun.c (print_exited_reason): Use ui_out::message.
3874 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3875 (describe_other_breakpoints): Use ui_out::message and new
3876 formats.
3877 (say_where): Use new formats.
3878 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3879 and new formats.
3880
2a3c1174
PA		 38812019-10-01 Pedro Alves <palves@redhat.com>
3882 Tom Tromey <tom@tromey.com>
3883
3884 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3885 (test_gdb_formats): New function.
3886 (run_tests): Call it.
3887 (test_format_specifier): Update.
3888 * utils.h (fputs_filtered): Update comment.
3889 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3890 (fputs_styled_unfiltered): Declare.
3891 * utils.c (fputs_styled_unfiltered): New function.
3892 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3893 (vfprintf_filtered): Update.
3894 (vfprintf_unfiltered, vprintf_filtered): Update.
3895 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3896 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3897 disallow_ui_out_field>: New constants.
3898 (enum class field_kind): New.
3899 (struct base_field_s, struct signed_field_s): New.
3900 (signed_field): New function.
3901 (struct string_field_s): New.
3902 (string_field): New function.
3903 (struct styled_string_s): New.
3904 (styled_string): New function.
3905 (class ui_out) <message>: Add comment.
3906 <vmessage, call_do_message>: New methods.
3907 <do_message>: Add style parameter.
3908 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3909 methods.
3910 (ui_out::message): Rewrite.
3911 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3912 parameter.
3913 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3914 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3915 gdb_extensions parameter.
3916 (class format_piece): Add parameter to constructor.
3917 (n_int_args): New field.
3918 * gdbsupport/format.c (format_pieces::format_pieces): Add
3919 gdb_extensions parameter. Handle '*'.
3920 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3921 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3922 vfprintf_styled_no_gdbfmt.
3923 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3924 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3925 unfiltered output.
3926 * ui-style.h (struct ui_file_style) <ptr>: New method.
3927
0dfe5bfb
TT		 39282019-10-01 Tom Tromey <tom@tromey.com>
3929
3930 * unittests/format_pieces-selftests.c: Update. Add final format.
3931 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3932 empty literal pieces.
3933
e43b10e1
TT		 39342019-10-01 Tom Tromey <tom@tromey.com>
3935
3936 * ui-out.h (enum class ui_out_style_kind): Remove.
3937 (class ui_out) <field_string, field_stsream, do_field_string>:
3938 Change type of "style".
3939 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3940 (ui_out::field_string): Update.
3941 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3942 of "style".
3943 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3944 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3945 * stack.c (print_frame_arg, print_frame_info, print_frame):
3946 Update.
3947 * source.c (print_source_lines_base): Update.
3948 * solib.c (info_sharedlibrary_command): Update.
3949 * skip.c (info_skip_command): Update.
3950 * record-btrace.c (btrace_call_history_src_line)
3951 (btrace_call_history): Update.
3952 * python/py-framefilter.c (py_print_frame): Update.
3953 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3954 "style".
3955 * mi/mi-out.c (mi_ui_out::do_table_header)
3956 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3957 (mi_ui_out::do_field_string): Update.
3958 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3959 Update.
3960 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3961 "style".
3962 * cli-out.c (cli_ui_out::do_table_header)
3963 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3964 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3965 (cli_ui_out::do_field_fmt): Update.
3966 * breakpoint.c (print_breakpoint_location): Update.
3967 (update_static_tracepoint): Update.
3968
cd7c32c3
PW		 39692019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3970
3971 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3972 conversion of gdb_datadir.
3973 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3974 remove not needed c_str ().
3975
8fe0f950
AT		 39762019-09-30 Ali Tamur <tamur@google.com>
3977
3978 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3979 (dwarf2_string_attr): Likewise.
3980
5f48f8f3
AT		 39812019-09-30 Ali Tamur <tamur@google.com>
3982
3983 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3984 (process_full_type_unit): Likewise.
3985 (dump_die_shallow): Likewise.
3986 (cu_debug_loc_section): Likewise.
3987
6fb08628
CB		 39882019-09-28 Christian Biesinger <cbiesinger@google.com>
3989
3990 * minsyms.c (compare_minimal_symbols): Rename to...
3991 (minimal_symbol_is_less_than): ...this, and adjust to STL
3992 conventions (return bool, take arguments as references)
3993 (minimal_symbol_reader::install): Call std::sort instead
3994 of qsort.
3995
c7ee338a
CB		 39962019-09-29 Christian Biesinger <cbiesinger@google.com>
3997
3998 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3999 hash and why.
4000 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4001 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4002
703a86c2
SM		 40032019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4004
4005 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4006 * psympriv.h (add_psymbol_to_list): Move comment here and update
4007 it.
4008
0df0352a
TV		 40092019-09-29 Tom de Vries <tdevries@suse.de>
4010
4011 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4012 Use $tmpdir/$(basename "$output_file").dwz instead of
4013 "${output_file}.dwz".
4014
ad75efa6
SM		 40152019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4016
4017 PR gdb/25045
4018 * hppa-linux-nat.c: Include gdbarch.h.
4019
ececd218
CB		 40202019-09-26 Christian Biesinger <cbiesinger@google.com>
4021
4022 * blockframe.c (find_pc_partial_function): Change return type to bool.
4023 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4024 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4025 (stub_gnu_ifunc_resolve_name): Likewise.
4026 * symtab.c (compare_filenames_for_search): Likewise.
4027 (compare_glob_filenames_for_search): Likewise.
4028 (matching_obj_sections): Likewise.
4029 (symbol_matches_domain): Likewise.
4030 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4031 (find_line_pc): Change return type to bool.
4032 (find_line_pc_range): Likewise.
4033 (producer_is_realview): Likewise.
4034 * symtab.h (symbol_matches_domain): Likewise.
4035 (find_pc_partial_function): Likewise.
4036 (find_pc_line_pc_range): Likewise.
4037 (in_gnu_ifunc_stub): Likewise.
4038 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4039 (find_line_pc): Likewise.
4040 (find_line_pc_range): Likewise.
4041 (matching_obj_sections): Likewise.
4042 (find_line_symtab): Change out parameter to bool.
4043 (producer_is_realview): Change return type to bool.
4044 (compare_filenames_for_search): Likewise.
4045 (compare_glob_filenames_for_search): Likewise.
4046
27a900b8
TT		 40472019-09-26 Tom Tromey <tom@tromey.com>
4048
4049 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4050 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4051 * gdb_usleep.h: Remove.
4052 * gdb_usleep.c: Remove.
4053 * utils.c: Don't include gdb_usleep.h.
4054
5d63b30a
TT		 40552019-09-26 Tom Tromey <tromey@adacore.com>
4056
4057 * python/py-type.c (type_to_type_object): Call check_typedef
4058 for stub types.
4059
12904d37
TT		 40602019-09-26 Tom Tromey <tom@tromey.com>
4061
4062 * utils.h (initialize_utils): Don't declare.
4063 * top.c (gdb_init): Don't call initialize_utils.
4064 * utils.c (initialize_utils): Remove. Move contents...
4065 (_initialize_utils): ... here.
4066
858f25f0
TT		 40672019-09-25 Tom Tromey <tom@tromey.com>
4068
4069 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4070 * utils.h (make_hex_string): Don't declare.
4071 * utils.c (make_hex_string): Remove.
4072
3d435220
TV		 40732019-09-24 Tom de Vries <tdevries@suse.de>
4074
4075 PR gdb/23815
4076 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4077 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4078
ddd44b70
DD		 40792019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4080
4081 * NEWS: Mention new simulator port for PRU.
4082
f945dedf
CB		 40832019-09-23 Christian Biesinger <cbiesinger@google.com>
4084
4085 * ada-exp.y (write_object_remaining): Update.
4086 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4087 and eliminate the static buffer.
4088 (ada_decode_symbol): Update.
4089 (ada_la_decode): Update.
4090 (ada_sniff_from_mangled_name): Update.
4091 (is_valid_name_for_wild_match): Update.
4092 (ada_lookup_name_info::matches): Update and simplify.
4093 (name_matches_regex): Update.
4094 (ada_add_global_exceptions): Update.
4095 * ada-lang.h (ada_decode): Update signature.
4096 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4097 * dwarf-index-write.c (debug_names::insert): Update.
4098
7ab78ccb
SM		 40992019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4100
4101 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4102 formatting.
4103
9252448b
SM		 41042019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4105
4106 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4107 Change "nonzero" to "true" in documentation.
4108
626ca2c0
CB		 41092019-09-20 Christian Biesinger <cbiesinger@google.com>
4110
4111 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4112 (_initialize_darwin_solib): Don't set
4113 darwin_so_ops.lookup_lib_global_symbol.
4114 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4115 set_gdbarch_iterate_over_objfiles_in_search_order.
4116 (elf_lookup_lib_symbol): Rename to...
4117 (svr4_iterate_over_objfiles_in_search_order): this, and update
4118 to iterate semantics.
4119 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4120 * solib.c (solib_global_lookup): Remove.
4121 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4122 (solib_global_lookup): Remove.
4123 * symtab.c (lookup_global_or_static_symbol): Remove call to
4124 solib_global_lookup.
4125
5a3a0d63
JB		 41262019-09-20 Joel Brobecker <brobecker@adacore.com>
4127
4128 * NEWS: Move entries about default MI version now being
4129 version 3, and about the GDB/MI fix for multi-location
4130 breakpoints to the "since GDB 8.3" section.
4131
ffea1427
JB		 41322019-09-20 Joel Brobecker <brobecker@adacore.com>
4133
4134 GDB 8.3.1 released.
4135
abf516c6
UW		 41362019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4137
4138 * NEWS: Mention that Cell/B.E. debugging support was removed.
4139 * MAINTAINERS: Remove spu target.
4140
4141 * config/djgpp/fnchange.lst: Remove entries for removed files.
4142
4143 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4144 spu-multiarch.o, and spu-tdep.o.
4145 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4146 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4147 spu-multiarch.c, and spu-tdep.c.
4148 * spu-linux-nat.c: Remove file.
4149 * spu-multiarch.c: Remove file.
4150 * spu-tdep.c: Remove file.
4151 * spu-tdep.h: Remove file.
4152 * solib-spu.c: Remove file.
4153 * solib-spu.h: Remove file.
4154
4155 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4156 * configure.nat (spu-linux): Remove.
4157 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4158 solib-multiarch.o from gdb_target_obs.
4159 (spu*-*-*): Remove.
4160
4161 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4162 feature flag.
4163 (ppc_linux_no_features): Update.
4164 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4165 Cell/B.E. support.
4166 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4167 (tdesc_powerpc_cell64l): Likewise.
4168 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4169 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4170 Cell/B.E. support.
4171 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4172 Do not include "features/rs6000/powerpc-cell32l.c" or
4173 "features/rs6000/powerpc-cell64l.c".
4174 (ppc_linux_spu_section): Remove.
4175 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4176 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4177 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4178 (ppc_linux_spe_context_lookup): Remove.
4179 (ppc_linux_spe_context_inferior_created): Remove.
4180 (ppc_linux_spe_context_solib_loaded): Remove.
4181 (ppc_linux_spe_context_solib_unloaded): Remove.
4182 (ppc_linux_spe_context): Remove.
4183 (struct ppu2spu_cache): Remove.
4184 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4185 (struct ppu2spu_data): Remove.
4186 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4187 ppu2spu_unwind): Remove.
4188 (ppc_linux_init_abi): Remove Cell/B.E. support.
4189 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4190
4191 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4192 (rs6000/powerpc-cell64l-expedite): Likewise
4193 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4194 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4195 rs6000/powerpc-cell64l.xml.
4196 * features/rs6000/powerpc-cell32l.xml: Remove.
4197 * features/rs6000/powerpc-cell64l.xml: Likewise.
4198 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4199 * features/rs6000/powerpc-cell64l.c: Likewise.
4200 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4201 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4202 * regformats/reg-spu.dat: Remove.
4203
4204 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4205 * corelow.c (struct spuid_list): Remove.
4206 (add_to_spuid_list): Remove.
4207 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4208 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4209 (remote_protocol_features): Remove associated entries.
4210 (_initialize_remote): No longer initialize them.
4211 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4212 * linux-nat.c (SPUFS_MAGIC): Remove.
4213 (linux_proc_xfer_spu): Remove.
4214 (spu_enumerate_spu_ids): Remove.
4215 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4216 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4217 (linux_make_corefile_notes): No longer call it.
4218
4219 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4220 (cooked_write_test): Likewise.
4221
78e8cb91
TT		 42222019-09-20 Tom Tromey <tom@tromey.com>
4223
4224 * NEWS: Mention case-sensitivity of TUI commands.
4225 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4226 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4227 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4228
f074b67e
TT		 42292019-09-20 Tom Tromey <tom@tromey.com>
4230
4231 * tui/tui-source.c (tui_source_window::set_contents): Use
4232 make_unique_xstrdup.
4233 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4234 make_unique_xstrdup.
4235
63c4bf19
TT		 42362019-09-20 Tom Tromey <tom@tromey.com>
4237
4238 * tui/tui-data.c: Remove separator comments.
4239 * tui/tui-layout.c: Remove separator comments.
4240 * tui/tui-win.c: Remove separator comments.
4241 * tui/tui-wingeneral.c: Remove separator comments.
4242
43df9b2f
TT		 42432019-09-20 Tom Tromey <tom@tromey.com>
4244
4245 * tui/tui.h (strcat_to_buf): Don't declare.
4246 * tui/tui.c (strcat_to_buf): Remove.
4247
7226433c
TT		 42482019-09-20 Tom Tromey <tom@tromey.com>
4249
4250 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4251 from "fullname".
4252 * tui/tui-source.c (tui_source_window::set_contents)
4253 (tui_source_window::location_matches_p)
4254 (tui_source_window::maybe_update): Update.
4255
80df3337
TT		 42562019-09-20 Tom Tromey <tom@tromey.com>
4257
4258 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4259 Update.
4260 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4261 prefix.
4262 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4263 (tui_data_window::line_from_reg_element_no)
4264 (tui_data_window::first_reg_element_no_inline)
4265 (tui_data_window::show_registers)
4266 (tui_data_window::show_register_group)
4267 (tui_data_window::display_registers_from)
4268 (tui_data_window::display_registers_from_line)
4269 (tui_data_window::first_data_item_displayed)
4270 (tui_data_window::delete_data_content_windows)
4271 (tui_data_window::erase_data_content)
4272 (tui_data_window::do_scroll_vertical)
4273 (tui_data_window::refresh_window)
4274 (tui_data_window::check_register_values): Update.
4275
9923f347
TT		 42762019-09-20 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4279 (struct tui_locator_window) <full_name, proc_name>: Now
4280 std::string.
4281 * tui/tui-stack.c (tui_locator_window::make_status_line)
4282 (tui_locator_window::set_locator_fullname)
4283 (tui_locator_window::set_locator_info): Update.
4284 * tui/tui-source.c (tui_source_window::set_contents)
4285 (tui_source_window::showing_source_p): Update.
4286
b76251ab
TT		 42872019-09-20 Tom Tromey <tom@tromey.com>
4288
4289 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4290 Don't call tui_locator_win_info_ptr.
4291
0891be08
TT		 42922019-09-20 Tom Tromey <tom@tromey.com>
4293
4294 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4295
1b935acf
TT		 42962019-09-20 Tom Tromey <tom@tromey.com>
4297
4298 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4299 height for locator.
4300 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4301 * tui/tui-layout.c (show_source_disasm_command, show_data)
4302 (show_source_or_disasm_and_command): Use 1 as height for locator.
4303
9abd8a65
TT		 43042019-09-20 Tom Tromey <tom@tromey.com>
4305
4306 * tui/tui.c (tui_enable): Update.
4307 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4308 Update.
4309 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4310 Update.
4311 * tui/tui-data.c (win_resized): Now bool.
4312 (tui_win_resized): Return bool.
4313 (tui_set_win_resized_to): Accept a bool.
4314
b5457826
TT		 43152019-09-20 Tom Tromey <tom@tromey.com>
4316
4317 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4318 Change type of "refresh_values_only".
4319 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4320 type of "refresh_values_only".
4321
6b915f7d
TT		 43222019-09-20 Tom Tromey <tom@tromey.com>
4323
4324 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4325 std::string.
4326 (tui_disassemble): Add "pos" parameter.
4327 (tui_disasm_window::set_contents): Simplify.
4328
2ad52f6f
TT		 43292019-09-20 Tom Tromey <tom@tromey.com>
4330
4331 * tui/tui-winsource.h (struct tui_source_window_base)
4332 <show_source_content>: Now private.
4333 * tui/tui-winsource.c
4334 (tui_source_window_base::show_source_content): Don't handle empty
4335 content case.
4336
b3b1bde6
TT		 43372019-09-20 Tom Tromey <tom@tromey.com>
4338
4339 * tui/tui-layout.c (show_source_disasm_command)
4340 (show_source_or_disasm_and_command): Don't call
4341 show_source_content.
4342
71a25ed2
TT		 43432019-09-20 Tom Tromey <tom@tromey.com>
4344
4345 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4346 Declare.
4347 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4348 from tui_make_status_line.
4349 (tui_locator_window::rerender): Update.
4350
f8532154
TT		 43512019-09-20 Tom Tromey <tom@tromey.com>
4352
4353 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4354 (tui_locator_window::rerender): Update.
4355
2d81b349
TT		 43562019-09-20 Tom Tromey <tom@tromey.com>
4357
4358 * tui/tui-winsource.h (struct tui_source_window_base)
4359 <~tui_source_window_base>: Don't declare.
4360 <fullname>: Remove.
4361 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4362 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4363 member.
4364 * tui/tui-source.c (tui_source_window::set_contents): Update.
4365 (tui_source_window::location_matches_p)
4366 (tui_source_window::maybe_update): Update.
4367
f14bec58
TT		 43682019-09-20 Tom Tromey <tom@tromey.com>
4369
4370 * tui/tui-winsource.h (~tui_source_element): Remove.
4371 (tui_source_element): Update.
4372 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4373 * tui/tui-winsource.c (tui_show_source_line): Update.
4374 * tui/tui-source.c (tui_source_window::set_contents): Update.
4375 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4376
78d5933a
TT		 43772019-09-20 Tom Tromey <tom@tromey.com>
4378
4379 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4380 declare.
4381 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4382 tui_clear_source_windows_detail.
4383 * tui/tui-winsource.h (struct tui_source_window_base)
4384 <clear_detail>: Don't declare.
4385 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4386 Remove.
4387 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4388
d4207696
TT		 43892019-09-20 Tom Tromey <tromey@adacore.com>
4390
4391 PR ada/24919:
4392 * block.c (contained_in): Fix final return value.
4393
00f93c44
AM		 43942019-09-20 Alan Modra <amodra@gmail.com>
4395
4396 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4397 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4398 (read_indirect_string_from_dwz): Use bfd accessor.
4399 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4400 * machoread.c (macho_symfile_read_all_oso): Likewise.
4401 * solib.c (solib_bfd_open): Likewise.
4402
e4153ae6
CB		 44032019-09-19 Christian Biesinger <cbiesinger@google.com>
4404
4405 * eval.c: Move declaration of overload_resolution to...
4406 * value.h: ...here.
4407
c7ae7675
CB		 44082019-09-19 Christian Biesinger <cbiesinger@google.com>
4409
4410 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4411 * arm-linux-tdep.c: Likewise.
4412 * arm-nbsd-nat.c: Likewise.
4413 * arm-tdep.h: Declare arm_apcs_32.
4414 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4415
e86f08d2
CB		 44162019-09-19 Christian Biesinger <cbiesinger@google.com>
4417
4418 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4419 * dwarf2read.h: Declare dwarf_always_disassemble.
4420
f64e2f40
TV		 44212019-09-19 Tom de Vries <tdevries@suse.de>
4422
4423 PR gdb/25009
4424 * source-cache.c (source_cache::ensure): Catch exception thrown during
4425 construction of the highlighter.
4426
fd361982
AM		 44272019-09-18 Alan Modra <amodra@gmail.com>
4428
4429 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4430 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4431 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4432 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4433 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4434 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4435 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4436 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4437 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4438 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4439 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4440 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4441 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4442 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4443 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4444 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4445 * mi/mi-interp.c: Update throughout for bfd section macro and
4446 function changes.
4447 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4448 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4449
11061048
TT		 44502019-09-18 Tom Tromey <tom@tromey.com>
4451
4452 * NEWS: Add entry.
4453 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4454 call rl_initialize.
4455 (tui_enable): Do not call rl_initialize.
4456
7a27b85f
CG		 44572019-09-18 Christian Groessler <chris@groessler.org>
4458
4459 * alpha-linux-nat.c: Include gdbarch.h.
4460
f64eea3a
SM		 44612019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4462
4463 * ui-file.c: Include cli/cli-style.h.
4464 (term_cli_styling): Remove cli_styling declaration.
4465
e6f7f6d1
AM		 44662019-09-18 Alan Modra <amodra@gmail.com>
4467
4468 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4469 to bfd_asymbol_section.
4470
1d38e9d1
AM		 44712019-09-18 Alan Modra <amodra@gmail.com>
4472
4473 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4474 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4475 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4476
90d92a63
AM		 44772019-09-18 Alan Modra <amodra@gmail.com>
4478
4479 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4480 * spu-linux-nat.c (spu_bfd_open): Likewise.
4481
a3d181d2
CB		 44822019-09-18 Christian Biesinger <cbiesinger@google.com>
4483
4484 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4485 to bool to match definition in dwarf2read.c.
4486
491144b5
CB		 44872019-09-17 Christian Biesinger <cbiesinger@google.com>
4488
4489 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4490 (print_signatures): Likewise.
4491 (trust_pad_over_xvs): Likewise.
4492 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4493 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4494 * arm-linux-nat.c (arm_apcs_32): Likewise.
4495 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4496 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4497 * arm-tdep.c (arm_debug): Likewise.
4498 (arm_apcs_32): Likewise.
4499 * auto-load.c (debug_auto_load): Likewise.
4500 (auto_load_gdb_scripts): Likewise.
4501 (global_auto_load): Likewise.
4502 (auto_load_local_gdbinit): Likewise.
4503 (auto_load_local_gdbinit_loaded): Likewise.
4504 * auto-load.h (global_auto_load): Likewise.
4505 (auto_load_local_gdbinit): Likewise.
4506 (auto_load_local_gdbinit_loaded): Likewise.
4507 * breakpoint.c (disconnected_dprintf): Likewise.
4508 (breakpoint_proceeded): Likewise.
4509 (automatic_hardware_breakpoints): Likewise.
4510 (always_inserted_mode): Likewise.
4511 (target_exact_watchpoints): Likewise.
4512 (_initialize_breakpoint): Update.
4513 * breakpoint.h (target_exact_watchpoints): Change to bool.
4514 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4515 * cli/cli-cmds.c (trace_commands): Likewise.
4516 * cli/cli-cmds.h (trace_commands): Likewise.
4517 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4518 to bool*.
4519 * cli/cli-logging.c (logging_overwrite): Change to bool.
4520 (logging_redirect): Likewise.
4521 (debug_redirect): Likewise.
4522 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4523 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4524 to bool.
4525 <boolean_option_def>: Update.
4526 (struct flag_option_def): Change default type of Context to bool
4527 from int.
4528 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4529 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4530 (get_setshow_command_value_string): Likewise.
4531 * cli/cli-style.c (cli_styling): Change to bool.
4532 (source_styling): Likewise.
4533 * cli/cli-style.h (source_styling): Likewise.
4534 (cli_styling): Likewise.
4535 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4536 to bool.
4537 * command.h (var_types): Update comment.
4538 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4539 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4540 bool.
4541 (debug_compile_cplus_scopes): Likewise.
4542 * compile/compile-internal.h (compile_debug): Likewise.
4543 * compile/compile.c (compile_debug): Likewise.
4544 (struct compile_options) <raw>: Likewise.
4545 * cp-support.c (catch_demangler_crashes): Likewise.
4546 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4547 (usr_cmd_cris_dwarf2_cfi): Likewise.
4548 * csky-tdep.c (csky_debug): Likewise.
4549 * darwin-nat.c (enable_mach_exceptions): Likewise.
4550 * dcache.c (dcache_enabled_p): Likewise.
4551 * defs.h (info_verbose): Likewise.
4552 * demangle.c (demangle): Likewise.
4553 (asm_demangle): Likewise.
4554 * dwarf-index-cache.c (debug_index_cache): Likewise.
4555 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4556 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4557 * dwarf2read.c (check_physname): Likewise.
4558 (use_deprecated_index_sections): Likewise.
4559 (dwarf_always_disassemble): Likewise.
4560 * eval.c (overload_resolution): Likewise.
4561 * event-top.c (set_editing_cmd_var): Likewise.
4562 (exec_done_display_p): Likewise.
4563 * event-top.h (set_editing_cmd_var): Likewise.
4564 (exec_done_display_p): Likewise.
4565 * exec.c (write_files): Likewise.
4566 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4567 (debug_fbsd_nat): Likewise.
4568 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4569 Likewise.
4570 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4571 <backtrace_past_entry> Likewise.
4572 * gdb-demangle.h (demangle): Likewise.
4573 (asm_demangle): Likewise.
4574 * gdb_bfd.c (bfd_sharing): Likewise.
4575 * gdbcore.h (write_files): Likewise.
4576 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4577 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4578 * gdbthread.h (print_thread_events): Likewise.
4579 * gdbtypes.c (opaque_type_resolution): Likewise.
4580 (strict_type_checking): Likewise.
4581 * gnu-nat.c (gnu_debug_flag): Likewise.
4582 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4583 * guile/scm-param.c (pascm_variable): Add boolval.
4584 (add_setshow_generic): Update.
4585 (pascm_param_value): Update.
4586 (pascm_set_param_value_x): Update.
4587 * hppa-tdep.c (hppa_debug): Change to bool..
4588 * infcall.c (may_call_functions_p): Likewise.
4589 (coerce_float_to_double_p): Likewise.
4590 (unwind_on_signal_p): Likewise.
4591 (unwind_on_terminating_exception_p): Likewise.
4592 * infcmd.c (startup_with_shell): Likewise.
4593 * inferior.c (print_inferior_events): Likewise.
4594 * inferior.h (startup_with_shell): Likewise.
4595 (print_inferior_events): Likewise.
4596 * infrun.c (step_stop_if_no_debug): Likewise.
4597 (detach_fork): Likewise.
4598 (debug_displaced): Likewise.
4599 (disable_randomization): Likewise.
4600 (non_stop): Likewise.
4601 (non_stop_1): Likewise.
4602 (observer_mode): Likewise.
4603 (observer_mode_1): Likewise.
4604 (set_observer_mode): Update.
4605 (sched_multi): Change to bool.
4606 * infrun.h (debug_displaced): Likewise.
4607 (sched_multi): Likewise.
4608 (step_stop_if_no_debug): Likewise.
4609 (non_stop): Likewise.
4610 (disable_randomization): Likewise.
4611 * linux-tdep.c (use_coredump_filter): Likewise.
4612 (dump_excluded_mappings): Likewise.
4613 * linux-thread-db.c (auto_load_thread_db): Likewise.
4614 (check_thread_db_on_load): Likewise.
4615 * main.c (captured_main_1): Update.
4616 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4617 xx2_opt, boolean_opt>: Change to bool.
4618 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4619 * maint.c (maintenance_profile_p): Likewise.
4620 (per_command_time): Likewise.
4621 (per_command_space): Likewise.
4622 (per_command_symtab): Likewise.
4623 * memattr.c (inaccessible_by_default): Likewise.
4624 * mi/mi-main.c (mi_async): Likewise.
4625 (mi_async_1): Likewise.
4626 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4627 * nat/fork-inferior.h (startup_with_shell): Likewise.
4628 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4629 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4630 * nios2-tdep.c (nios2_debug): Likewise.
4631 * or1k-tdep.c (or1k_debug): Likewise.
4632 * parse.c (parser_debug): Likewise.
4633 * parser-defs.h (parser_debug): Likewise.
4634 * printcmd.c (print_symbol_filename): Likewise.
4635 * proc-api.c (procfs_trace): Likewise.
4636 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4637 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4638 (set_parameter_value): Update.
4639 (add_setshow_generic): Update.
4640 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4641 to bool*.
4642 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4643 int*.
4644 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4645 * record-btrace.c (record_btrace_target::store_registers): Update.
4646 * record-full.c (record_full_memory_query): Change to bool.
4647 (record_full_stop_at_limit): Likewise.
4648 * record-full.h (record_full_memory_query): Likewise.
4649 * remote-notif.c (notif_debug): Likewise.
4650 * remote-notif.h (notif_debug): Likewise.
4651 * remote.c (use_range_stepping): Likewise.
4652 (interrupt_on_connect): Likewise.
4653 (remote_break): Likewise.
4654 * ser-tcp.c (tcp_auto_retry): Likewise.
4655 * ser-unix.c (serial_hwflow): Likewise.
4656 * skip.c (debug_skip): Likewise.
4657 * solib-aix.c (solib_aix_debug): Likewise.
4658 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4659 (spu_auto_flush_cache_p): Likewise.
4660 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4661 Likewise.
4662 (struct info_print_options) <quiet>: Likewise.
4663 * symfile-debug.c (debug_symfile): Likewise.
4664 * symfile.c (auto_solib_add): Likewise.
4665 (separate_debug_file_debug): Likewise.
4666 * symfile.h (auto_solib_add): Likewise.
4667 (separate_debug_file_debug): Likewise.
4668 * symtab.c (basenames_may_differ): Likewise.
4669 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4670 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4671 (struct info_types_options) <quiet>: Likewise.
4672 * symtab.h (demangle): Likewise.
4673 (basenames_may_differ): Likewise.
4674 * target-dcache.c (stack_cache_enabled_1): Likewise.
4675 (code_cache_enabled_1): Likewise.
4676 * target.c (trust_readonly): Likewise.
4677 (may_write_registers): Likewise.
4678 (may_write_memory): Likewise.
4679 (may_insert_breakpoints): Likewise.
4680 (may_insert_tracepoints): Likewise.
4681 (may_insert_fast_tracepoints): Likewise.
4682 (may_stop): Likewise.
4683 (auto_connect_native_target): Likewise.
4684 (target_stop_and_wait): Update.
4685 (target_async_permitted): Change to bool.
4686 (target_async_permitted_1): Likewise.
4687 (may_write_registers_1): Likewise.
4688 (may_write_memory_1): Likewise.
4689 (may_insert_breakpoints_1): Likewise.
4690 (may_insert_tracepoints_1): Likewise.
4691 (may_insert_fast_tracepoints_1): Likewise.
4692 (may_stop_1): Likewise.
4693 * target.h (target_async_permitted): Likewise.
4694 (may_write_registers): Likewise.
4695 (may_write_memory): Likewise.
4696 (may_insert_breakpoints): Likewise.
4697 (may_insert_tracepoints): Likewise.
4698 (may_insert_fast_tracepoints): Likewise.
4699 (may_stop): Likewise.
4700 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4701 (make_thread_apply_all_options_def_group): Change argument from int*
4702 to bool*.
4703 (thread_apply_all_command): Update.
4704 (print_thread_events): Change to bool.
4705 * top.c (confirm): Likewise.
4706 (command_editing_p): Likewise.
4707 (history_expansion_p): Likewise.
4708 (write_history_p): Likewise.
4709 (info_verbose): Likewise.
4710 * top.h (confirm): Likewise.
4711 (history_expansion_p): Likewise.
4712 * tracepoint.c (disconnected_tracing): Likewise.
4713 (circular_trace_buffer): Likewise.
4714 * typeprint.c (print_methods): Likewise.
4715 (print_typedefs): Likewise.
4716 * utils.c (debug_timestamp): Likewise.
4717 (sevenbit_strings): Likewise.
4718 (pagination_enabled): Likewise.
4719 * utils.h (sevenbit_strings): Likewise.
4720 (pagination_enabled): Likewise.
4721 * valops.c (overload_resolution): Likewise.
4722 * valprint.h (struct value_print_options) <prettyformat_arrays,
4723 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4724 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4725 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4726 Likewise.
4727 * windows-nat.c (new_console): Likewise.
4728 (cygwin_exceptions): Likewise.
4729 (new_group): Likewise.
4730 (debug_exec): Likewise.
4731 (debug_events): Likewise.
4732 (debug_memory): Likewise.
4733 (debug_exceptions): Likewise.
4734 (useshell): Likewise.
4735 * windows-tdep.c (maint_display_all_tib): Likewise.
4736 * xml-support.c (debug_xml): Likewise.
4737
f1b620e9
MG		 47382019-09-17 Mike Gulick <mgulick@mathworks.com>
4739
4740 * source.c (prepare_path_for_appending): New function.
4741 (openp): Make use of new function.
4742 (find_and_open_source): Search for the compilation directory and
4743 source file as a relative path beneath the directory search path.
4744
67f3ed6a
AB		 47452019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4746
4747 * source-cache.c (source_cache::get_line_charpos): Catch
4748 exceptions and return false, this matches the behaviour documented
4749 in the header file.
4750
74332189
JB		 47512019-09-17 Joel Brobecker <brobecker@adacore.com>
4752
4753 * ada-tasks.c (info_task): Remove quoting of the task's name.
4754
f2f24aa9
CB		 47552019-09-16 Christian Biesinger <cbiesinger@google.com>
4756
4757 * symfile.c (auto_solib_add): Replace comment with a reference
4758 to the header file.
4759
6a062a93
CB		 47602019-09-14 Christian Biesinger <cbiesinger@google.com>
4761
4762 * NEWS: Mention that gdb can now be compiled with Python 3
4763 on Windows.
4764
ec6c8338
AB		 47652019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4766
4767 * maint.c (maint_print_section_data::maint_print_section_data):
4768 Force use of 'float log10 (float)' by casting the argument to
4769 float.
4770
aa17805f
AB		 47712019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4772
4773 * maint.c: Add 'cmath' include.
4774 (struct maint_print_section_data): New structure.
4775 (print_section_index): New function.
4776 (print_bfd_section_info): Add header comment, small whitespace
4777 cleanup, and update to call new print_section_index function.
4778 (print_objfile_section_info): Likewise.
4779 (maint_obj_section_from_bfd_section): New function.
4780 (print_bfd_section_info_maybe_relocated): New function.
4781 (maintenance_info_sections): Add header comment, always use
4782 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4783
3dd9bb46
AB		 47842019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4785
4786 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4787 inner scope, add check that the objfile has psymtabs before
4788 checking psymtabs_addrmap.
4789 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4790
4993045d
PW		 47912019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4792
4793 * NEWS: Announce that Ada task names are now shown at more places,
4794 and between quotes (except in info task output).
4795 * gdb/ada-tasks.c (task_to_str): New function.
4796 (display_current_task_id): Call task_to_str.
4797 (task_command_1): Likewise.
4798 (print_ada_task_info): In non-mi mode, Properly align headers and data
4799 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4800
7a289707
RO		 48012019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4802
4803 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4804 prstatus.pr_lwp.pr_info instead of making it up.
4805
f2aec7f6
CB		 48062019-09-11 Christian Biesinger <cbiesinger@google.com>
4807
4808 * auto-load.c (auto_load_expand_dir_vars): Update.
4809 * defs.h (gdb_datadir): Change to std::string.
4810 (python_libdir): Likewise.
4811 (relocate_gdb_directory): Change return type to std::string.
4812 * guile/guile.c (gdbscm_data_directory): Update.
4813 (initialize_scheme_side): Update.
4814 * jit.c (jit_reader_dir): Change to std::string.
4815 (jit_reader_load_command): Update.
4816 * main.c (gdb_datadir): Change to std::string.
4817 (python_libdir): Likewise.
4818 (set_gdb_data_directory): Update.
4819 (relocate_path): Change to return std::string.
4820 (relocate_gdb_directory): Change to return std::string.
4821 (relocate_gdbinit_path_maybe_in_datadir): Update.
4822 (captured_main_1): Update.
4823 * python/python.c (do_start_initialization): Update.
4824 * top.c (show_gdb_datadir): Update.
4825 * xml-syscall.c (xml_init_syscalls_info): Update.
4826 (init_syscalls_info): Update.
4827
9224a013
CB		 48282019-09-11 Christian Biesinger <cbiesinger@google.com>
4829
4830 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4831 out of get_init_files.
4832 (get_init_files): Update.
4833
f48cd836
CB		 48342019-09-11 Christian Biesinger <cbiesinger@google.com>
4835
4836 * main.c (get_init_files): Change to use std::string.
4837 (captured_main_1): Update.
4838 (print_gdb_help): Update.
4839
9cab7ecd
AT		 48402019-09-11 Ali Tamur <tamur@google.com>
4841
4842 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4843 implementation.
4844
67547d89
CB		 48452019-09-11 Christian Biesinger <cbiesinger@google.com>
4846
4847 * dbxread.c (read_dbx_symtab): Update.
4848 * dwarf2read.c (load_partial_dies): Update.
4849 * mdebugread.c (parse_partial_symbols): Update.
4850 (handle_psymbol_enumerators): Update.
4851 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4852 * psymtab.c (add_psymbol_to_bcache): Likewise.
4853 (add_psymbol_to_list): Likewise.
4854 * symtab.c (symbol_set_names): Likewise.
4855 * symtab.h (symbol_set_names): Likewise.
4856 * xcoffread.c (scan_xcoff_symtab): Update.
4857
64b2d4a0
TT		 48582019-09-11 Tom Tromey <tom@tromey.com>
4859
4860 * symfile-mem.c (symbol_file_add_from_memory): Use
4861 bfd_set_filename.
4862 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4863 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4864
3b00ef10
TT		 48652019-09-10 Tom Tromey <tromey@adacore.com>
4866
4867 * dwarf-index-write.c (write_psymbols): Extend error message.
4868 (debug_names::insert): Add Ada code.
4869 (debug_names::write_psymbols): Remove Ada check.
4870 (debug_names) <m_string_obstack>: New member.
4871 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4872 (gdb_index_symbol_name_matcher::matches): Remove.
4873 (mapped_index_base::find_name_components_bounds): Add "lang"
4874 parameter.
4875 (mapped_index_base::build_name_components): Also split names
4876 according to Ada syntax.
4877 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4878 type of "match_callback".
4879 (check_match, check_find_bounds_finds)
4880 (dw2_expand_symtabs_matching): Update.
4881 (dw2_debug_names_iterator): Add new constructor.
4882 (dw2_debug_names_map_matching_symbols): New function.
4883 (dw2_debug_names_expand_symtabs_matching): Update.
4884 (dwarf2_debug_names_functions): Use
4885 dw2_debug_names_map_matching_symbols.
4886
aa391654
TT		 48872019-09-10 Tom Tromey <tromey@adacore.com>
4888
4889 * dwarf2read.c (dw2_get_file_names_reader): Add the
4890 CU's file name to the results.
4891
b054970d
TT		 48922019-09-10 Tom Tromey <tromey@adacore.com>
4893
4894 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4895 map_matching_symbols. Update.
4896 * dwarf2read.c (dw2_map_matching_symbols): Update.
4897 * psymtab.c (match_partial_symbol): Change type; update.
4898 (psym_map_matching_symbols): Likewise.
4899 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4900 type; update.
4901 * symfile.h (struct quick_symbol_functions)
4902 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4903 Remove "match".
4904
6a3dbf1b
TT		 49052019-09-10 Tom Tromey <tromey@adacore.com>
4906
4907 * psymtab.c (map_block): Remove.
4908 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4909 * symtab.c (iterate_over_symbols_terminated): New function.
4910 * symtab.c (iterate_over_symbols_terminated): Declare.
4911
6969f124
TT		 49122019-09-10 Tom Tromey <tromey@adacore.com>
4913
4914 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4915 * language.h (struct language_defn) <la_iterate_over_symbols>:
4916 Return bool.
4917 * symtab.c (iterate_over_symbols): Return bool.
4918 * symtab.h (iterate_over_symbols): Return bool.
4919
199b4314
TT		 49202019-09-10 Tom Tromey <tromey@adacore.com>
4921
4922 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4923 (add_nonlocal_symbols): Update.
4924 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4925 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4926 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4927 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4928 Change type of "callback". Remove "data".
4929
a084a2a6
AT		 4930
49312019-09-09 Ali Tamur <tamur@google.com>
4932
4933 * dwarf2read.c (comp_unit_head): Update comment.
4934 (dwarf2_dwo_name): New function declaration.
4935 (dwarf_unit_type_name): New function declaration.
4936 (read_comp_unit_head): Add support for new compilation units,
4937 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4938 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4939 (currently named as "signature") in their header. Also clarify error
4940 messages.
4941 (lookup_dwo_id): New function. Returns the dwo id of the given
4942 compile unit.
4943 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4944 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4945 functions.
4946 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4947 (dwarf2_dwo_name): Get the dwo name if present.
4948 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4949 purposes.
4950
25a2915e
TT		 49512019-09-09 Tom Tromey <tom@tromey.com>
4952
4953 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4954
e4df0874
PW		 49552019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4956
4957 * python/python.c (do_start_initialization): Make progname_copy static,
4958 to avoid a leak report.
4959
8634b462
TT		 49602019-09-08 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4963
c7f839cb
SM		 49642019-09-07 Simon Marchi <simon.marchi@efficios.com>
4965
4966 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4967 Change type to gdb::optional<block_enum>.
4968 (dw2_symtab_iter_init): Change block_index parameter type
4969 to gdb::optional<block_enum>.
4970 (dw2_lookup_symbol): Change block_index parameter
4971 type to block_enum.c
4972 (dw2_debug_names_lookup_symbol): Likewise.
4973 * psymtab.c (psym_lookup_symbol): Likewise.
4974 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4975 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4976 Likewise.
4977
ead0e69a
CB		 49782019-09-06 Christian Biesinger <cbiesinger@google.com>
4979
4980 * defs.h (relocate_gdb_directory): Change int to bool in
4981 signature and rename flag to relocatable.
4982 * main.c (relocate_path): Likewise.
4983 (relocate_gdb_directory): Likewise.
4984
b16c44de
AM		 49852019-09-06 Alan Modra <amodra@gmail.com>
4986
4987 * coffread.c (coff_symfile_read): Constify filename variable.
4988 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4989 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4990 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4991 * solib.c (reload_shared_libraries_1): Likewise.
4992 * symfile.c (reread_symbols): Likewise.
4993 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4994 * solib-darwin.c (darwin_bfd_open): Likewise.
4995 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4996
06ff036e
AB		 49972019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4998
4999 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5000 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5001
4e962e74
TT		 50022019-09-03 Tom Tromey <tromey@adacore.com>
5003
5004 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5005 types.
5006 (has_negatives): Unbias a range type bound.
5007 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5008 * gdbtypes.c (operator==): Handle new field.
5009 (create_range_type): Add "bias" parameter.
5010 (create_static_range_type, resolve_dynamic_range): Update.
5011 * gdbtypes.h (struct range_bounds) <bias>: New member.
5012 (create_range_type): Add bias parameter.
5013 * printcmd.c (print_scalar_formatted): Unbias range types.
5014 * value.c (unpack_long): Unbias range types.
5015 (pack_long): Bias range types.
5016
d90b8f26
AH		 50172019-09-02 Alan Hayward <alan.hayward@arm.com>
5018
5019 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5020 probe arguments.
5021
fe01123e
AH		 50222019-09-02 Alan Hayward <alan.hayward@arm.com>
5023
5024 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5025 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5026 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5027 (compile_probe_arg): Likewise.
5028 * probe.h (get_argument_count): Likewise.
5029 * solib-svr4.c (solib_event_probe_action): Likewise.
5030 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5031
e661ef01
AH		 50322019-09-02 Alan Hayward <alan.hayward@arm.com>
5033
5034 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5035 code to here...
5036 (svr4_create_solib_event_breakpoints): ...from here.
5037
47a536d9
SDJ		 50382019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5039
5040 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5041 suffix from warning message.
5042
d6a00eba
TT		 50432019-08-30 Tom Tromey <tom@tromey.com>
5044
5045 * tui/tui-winsource.h (struct tui_source_window_base)
5046 <refresh_all>: Don't declare.
5047 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5048 Remove.
5049 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5050 tui_show_locator_content.
5051 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5052 declare.
5053 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5054 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5055 declare.
5056
55b2657b
TT		 50572019-08-30 Tom Tromey <tom@tromey.com>
5058
5059 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5060
12a8555a
TT		 50612019-08-30 Tom Tromey <tom@tromey.com>
5062
5063 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5064 Remove unnecessary forward declarations.
5065
900ac242
TT		 50662019-08-30 Tom Tromey <tom@tromey.com>
5067
5068 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5069 rerender.
5070 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5071 tui_show_locator_content.
5072
99ab33fb
TT		 50732019-08-30 Tom Tromey <tom@tromey.com>
5074
5075 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5076 (tui_locator_window::rerender): Rewrite using body of previous
5077 tui_show_locator_content.
5078
e594a5d1
TT		 50792019-08-30 Tom Tromey <tom@tromey.com>
5080
5081 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5082 set_locator_fullname>: New methods.
5083 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5084 Rename from tui_set_locator_fullname.
5085 (tui_locator_window::set_locator_info): Rename from
5086 tui_set_locator_info. Return bool.
5087 (tui_update_locator_fullname, tui_show_frame_info): Update.
5088
715bb467
TT		 50892019-08-30 Tom Tromey <tom@tromey.com>
5090
5091 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5092
772f3f03
TT		 50932019-08-30 Tom Tromey <tom@tromey.com>
5094
5095 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5096 call touchwin.
5097
108e13ab
TT		 50982019-08-30 Tom Tromey <tom@tromey.com>
5099
5100 * tui/tui-wingeneral.c (box_win): Assume win_info and
5101 win_info->handle cannot be NULL.
5102
cdaa6eb4
TT		 51032019-08-30 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5106 refresh_window>: Declare.
5107 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5108 resize.
5109 (tui_data_item_window::rerender): Rename from
5110 tui_display_register.
5111 (tui_data_item_window::refresh_window): New method.
5112 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5113 no-op.
5114
89df7f90
TT		 51152019-08-30 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5118 regs_column_count, current_group>: Move later. Now private.
5119 <get_current_group>: New method.
5120 * tui/tui-regs.c (tui_reg_command): Update.
5121 * tui/tui-layout.c (tui_set_layout): Update.
5122
1bf2866a
TT		 51232019-08-30 Tom Tromey <tom@tromey.com>
5124
5125 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5126 (tui_data_window::rerender): Don't call
5127 check_and_display_highlight_if_needed.
5128 (tui_data_window::refresh_all): Remove call to
5129 erase_data_content.
5130
0670413d
TT		 51312019-08-30 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5134 (tui_data_window::display_registers_from)
5135 (tui_data_window::display_reg_element_at_line)
5136 (tui_data_window::display_registers_from_line): Remove checks of
5137 "empty".
5138
18bb55c7
TT		 51392019-08-30 Tom Tromey <tom@tromey.com>
5140
5141 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5142 Don't declare.
5143 * tui/tui-regs.c (tui_data_window::show_registers): Call
5144 rerender.
5145 (tui_data_window::rerender): Rename from display_all_data.
5146 (tui_data_window::rerender): Remove old implementation.
5147
1f6d2f10
TT		 51482019-08-30 Tom Tromey <tom@tromey.com>
5149
5150 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5151 text.
5152 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5153
16d01f9c
BW		 51542019-08-29 Bernhard Wodok <barto@gmx.net>
5155 Sergio Durigan Junior <sergiodj@redhat.com>
5156
5157 PR win32/24284
5158 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5159
d8f27c60
AB		 51602019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5161
5162 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5163 when searching for types.
5164
1f20c35e
AB		 51652019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5166
5167 * f-lang.c (f_language_defn): Use f_print_typedef.
5168 * f-lang.h (f_print_typedef): Declare.
5169 * f-typeprint.c (f_print_typedef): Define.
5170
550105b7
CB		 51712019-08-27 Christian Biesinger <cbiesinger@google.com>
5172
5173 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5174
4acfdd20
AB		 51752019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5176
5177 * cli/cli-utils.c (info_print_options_defs): Delete.
5178 (make_info_print_options_def_group): Delete.
5179 (extract_info_print_options): Delete.
5180 (info_print_command_completer): Delete.
5181 (info_print_args_help): Add extra parameter, and optionally
5182 include text about -n flag.
5183 * cli/cli-utils.h (struct info_print_options): Delete.
5184 (extract_info_print_options): Delete declaration.
5185 (info_print_command_completer): Delete declaration.
5186 (info_print_args_help): Add extra parameter, extend header
5187 comment.
5188 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5189 search_symbols.
5190 * stack.c (struct info_print_options): New type.
5191 (info_print_options_defs): New file scoped variable.
5192 (make_info_print_options_def_group): New static function.
5193 (info_print_command_completer): New static function.
5194 (info_locals_command): Update to use new local functions.
5195 (info_args_command): Likewise.
5196 (_initialize_stack): Add extra parameter to calls to
5197 info_print_args_help.
5198 * symtab.c (search_symbols): Add extra parameter, use this to
5199 possibly excluse non-debug symbols.
5200 (symtab_symbol_info): Add extra parameter, which is passed on to
5201 search_symbols.
5202 (struct info_print_options): New type.
5203 (info_print_options_defs): New file scoped variable.
5204 (make_info_print_options_def_group): New static function.
5205 (info_print_command_completer): New static function.
5206 (info_variables_command): Update to use local functions, and pass
5207 extra parameter through to symtab_symbol_info.
5208 (info_functions_command): Likewise.
5209 (info_types_command): Pass additional argument through to
5210 symtab_symbol_info.
5211 (rbreak_command): Pass extra argument to search_symbols.
5212 (_initialize_symtab): Add extra arguments for calls to
5213 info_print_args_help, and update help text for 'info variables',
5214 'whereis', and 'info functions' commands.
5215 * symtab.h (search_symbols): Add extra argument to declaration.
5216 * NEWS: Mention new flags.
5217
9aa55206
CB		 52182019-08-26 Christian Biesinger <cbiesinger@google.com>
5219
5220 * symtab.c (lookup_static_symbol): Call the new function (and move
5221 it down to be next to lookup_global_symbol).
5222 (struct global_sym_lookup_data): Add block_enum member and rename to...
5223 (struct global_or_static_sym_lookup_data): ...this.
5224 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5225 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5226 (lookup_symbol_global_or_static_iterator_cb): ...this.
5227 (lookup_global_or_static_symbol): New function.
5228 (lookup_global_symbol): Call new function.
5229
5c31b358
TV		 52302019-08-26 Tom de Vries <tdevries@suse.de>
5231
5232 PR c++/24852
5233 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5234 when pc_probe.prob == NULL.
5235
23c13d42
SM		 52362019-08-25 Simon Marchi <simon.marchi@efficios.com>
5237
5238 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5239 variable symbol_linkage to symbol_linkage_.
5240
beadd3e8
SM		 52412019-08-25 Simon Marchi <simon.marchi@efficios.com>
5242
5243 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5244 represent whether the symbol is static, dynamic, or we don't
5245 know.
5246
e3ec872f
YS		 52472019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5248
5249 * gdb/rx-tdep.c (rx_register_names): New.
5250 (rx_register_name): Delete.
5251 (rx_psw_type): Delete.
5252 (rx_fpsw_type): Delete.
5253 (rx_register_type): Delete.
5254 (rx_gdbarch_init): Convert target-descriptions.
5255 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5256 * gdb/features/Makefile: Add rx.xml.
5257 * gdb/features/rx.xml: New.
5258 * gdb/features/rx.c: Generated.
5259 * gdb/NEWS: Mention target description support.
5260
d0509ba4
CB		 52612019-08-22 Christian Biesinger <cbiesinger@google.com>
5262
5263 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5264 *slot_ptr.
5265
2d41fa11
SDJ		 52662019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5267
5268 * configure.ac: Don't check for 'dlfcn.h' (moved to
5269 gdbsupport/common.m4).
5270 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5271 'gdbsupport/'.
5272 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5273 * compile/compile-c-support.c: Include
5274 'gdbsupport/gdb-dlfcn.h'.
5275 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5276 * gdb-dlfcn.c: Move to...
5277 * gdbsupport/gdb-dlfcn.c: ... here.
5278 * gdb-dlfcn.h: Move to...
5279 * gdbsupport/gdb-dlfcn.h: ... here.
5280
de8af808
SL		 52812019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5282
5283 * nios2-tdep.c (struct reg_value): Improve comments. Make
5284 the offset field signed.
5285
27204489
CB		 52862019-08-22 Christian Biesinger <cbiesinger@google.com>
5287
5288 * python/lib/gdb/__init__.py (_execute_file): New function.
5289 * python/python.c (python_run_simple_file): Call gdb._execute_file
5290 on Windows.
5291
43771869
AB		 52922019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5293
5294 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5295 all uses as this was never set to anything but a zero value.
5296
26c957f1
PA		 52972019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5298
5299 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5300
c07aae6e
CB		 53012019-08-21 Christian Biesinger <cbiesinger@google.com>
5302
5303 * tui/tui-data.h (tui_gen_win_info): Add an =default
5304 move constructor, required by some GCC versions.
5305
3960cb7a
JF		 53062019-08-21 Jinke Fan <fanjinke51@yeah.net>
5307
5308 * go32-nat.c (go32_sysinfo): Add hygon_p.
5309
04c72a68
TT		 53102019-08-20 Tom Tromey <tom@tromey.com>
5311
5312 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5313 line_from_reg_element_no, first_reg_element_no_inline,
5314 display_all_data, delete_data_content_windows,
5315 erase_data_content>: Now private.
5316
072272ce
TT		 53172019-08-20 Tom Tromey <tom@tromey.com>
5318
5319 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5320 (tui_unhighlight_win, tui_highlight_win)
5321 (tui_win_info::make_window): Update.
5322 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5323
973961bd
TT		 53242019-08-20 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5327 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5328 (MAX_PID_WIDTH): Move to tui-stack.c.
5329 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5330 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5331 (MAX_PID_WIDTH): Move from tui-data.h.
5332
ab0e1f1a
TT		 53332019-08-20 Tom Tromey <tom@tromey.com>
5334
5335 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5336 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5337 (box_win): Update.
5338 (tui_gen_win_info::make_window): Rename from tui_make_window.
5339 (tui_win_info::make_window): New method.
5340 (tui_gen_win_info::make_visible): Update.
5341 * tui/tui-source.c (tui_source_window::set_contents): Update.
5342 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5343 (tui_data_window::display_registers_from): Update.
5344 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5345 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5346 Declare.
5347 <can_box>: Remove.
5348 <title>: Remove.
5349 (struct tui_win_info) <make_window>: Declare.
5350 <can_box>: Now virtual.
5351 <title>: New member.
5352 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5353 * tui/tui-command.c (tui_cmd_window::resize): Update.
5354
100c2bf3
TT		 53552019-08-20 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5358 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5359 (tui_data_window::check_register_values): Update.
5360
fa4dc567
TT		 53612019-08-20 Tom Tromey <tom@tromey.com>
5362
5363 * tui/tui-regs.h (struct tui_data_window): Use
5364 DISABLE_COPY_AND_ASSIGN.
5365 <regs_content>: Change type, removing unique_ptr.
5366 <tui_data_window>: Add move constructor.
5367 * tui/tui-regs.c (tui_data_window::show_registers)
5368 (tui_data_window::show_register_group)
5369 (tui_data_window::display_registers_from)
5370 (tui_data_window::display_registers_from)
5371 (tui_data_window::first_data_item_displayed)
5372 (tui_data_window::delete_data_content_windows)
5373 (tui_data_window::rerender, tui_data_window::refresh_window)
5374 (tui_data_window::check_register_values): Update.
5375
ca02d7c8
TT		 53762019-08-20 Tom Tromey <tom@tromey.com>
5377
5378 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5379 show_register_group>: Declare.
5380 (tui_show_register_group): Don't declare.
5381 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5382 tui_show_registers.
5383 (tui_data_window::show_register_group): Rename from
5384 tui_show_register_group.
5385 (tui_data_window::check_register_values, tui_reg_command):
5386 Update.
5387 * tui/tui-layout.c (tui_set_layout): Update.
5388
63356bfd
TT		 53892019-08-20 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5392 Declare.
5393 (tui_check_register_values): Don't declare.
5394 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5395 from tui_check_register_values.
5396 * tui/tui-hooks.c (tui_register_changed): Update.
5397
42cc14a7
TT		 53982019-08-20 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-regs.c (tui_reg_layout): Move later.
5401 (tui_show_registers): Don't enable TUI mode or change layout.
5402
b9ad3686
TT		 54032019-08-20 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-regs.h (struct tui_data_item_window)
5406 <~tui_data_item_window>: Remove.
5407 <content>: Now a unique_xmalloc_ptr.
5408 * tui/tui-regs.c (tui_register_format): Return a
5409 unique_xmalloc_ptr.
5410 (tui_get_register): Update.
5411 (~tui_data_item_window): Remove.
5412 (tui_data_window::display_registers_from, tui_display_register):
5413 Update.
5414 * tui/tui-io.h (tui_expand_tabs): Update.
5415 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5416 Remove "col" parameter.
5417
8e114aab
TT		 54182019-08-20 Tom Tromey <tom@tromey.com>
5419
5420 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5421 field.
5422 * tui/tui-regs.c (~tui_data_item_window): Update.
5423
1a4f81dd
TT		 54242019-08-20 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5427 earlier.
5428
0f8d8876
TT		 54292019-08-20 Tom Tromey <tom@tromey.com>
5430
5431 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5432
605dc2c2
TT		 54332019-08-20 Tom Tromey <tom@tromey.com>
5434
5435 * tui/tui-source.h (struct tui_source_window): Update.
5436 * tui/tui-regs.c (tui_show_registers): Update.
5437 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5438 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5439 (NO_REGS_STRING): Remove defines.
5440
aedbe3bb
CM		 54412019-08-20 Conrad Meyer <cem@FreeBSD.org>
5442
5443 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5444 unnecessary thread walk if remote doesn't support the packet.
5445
7ce8f214
TT		 54462019-08-19 Tom Tromey <tromey@adacore.com>
5447
5448 * python/py-value.c (value_has_field): Fix indentation.
5449
f21c2bd7
TT		 54502019-08-19 Tom Tromey <tromey@adacore.com>
5451
5452 * printcmd.c (do_one_display, info_display_command): Update.
5453 * block.h (contained_in): Return bool. Add allow_nested
5454 parameter.
5455 * block.c (contained_in): Return bool. Add allow_nested
5456 parameter.
5457
d806ea2d
TT		 54582019-08-19 Tom Tromey <tom@tromey.com>
5459
5460 * configure: Rebuild.
5461 * configure.ac: Disallow the combination of -static-libstdc++ and
5462 source highlight.
5463 * source-cache.c (get_language_name): Handle rust.
5464 (source_cache::get_source_lines): Ignore highlighting exceptions.
5465
398fdd60
TT		 54662019-08-16 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5469 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5470 (struct tui_source_window_base) <make_visible, refresh_window,
5471 resize>: Remove methods.
5472 <execution_info>: Remove field.
5473 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5474 (tui_show_source_line, tui_source_window_base)
5475 (~tui_source_window_base): Update.
5476 (tui_source_window_base::resize)
5477 (tui_source_window_base::make_visible)
5478 (tui_source_window_base::refresh_window): Remove.
5479 (tui_source_window_base::update_exec_info): Update.
5480 * tui/tui-source.c (tui_source_window::set_contents): Update.
5481 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5482
e699d331
TT		 54832019-08-16 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5486 deprecated_query_hook.
5487
bb01dbfc
TT		 54882019-08-16 Tom Tromey <tom@tromey.com>
5489
5490 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5491 (tui_update_source_windows_with_line): Update.
5492 * tui/tui-source.h (struct tui_source_window)
5493 <show_symtab_source>: Declare.
5494 (tui_show_symtab_source): Don't declare.
5495 * tui/tui-source.c (tui_show_symtab_source): Rename from
5496 tui_show_symtab_source.
5497
81c82c4b
TT		 54982019-08-16 Tom Tromey <tom@tromey.com>
5499
5500 * tui/tui-winsource.h (struct tui_source_window_base)
5501 <set_contents>: Declare.
5502 * tui/tui-winsource.c
5503 (tui_source_window_base::update_source_window_as_is): Update.
5504 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5505 Declare.
5506 (tui_set_source_content): Don't declare.
5507 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5508 tui_set_source_content.
5509 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5510 Declare.
5511 (tui_set_disassem_content): Don't declare.
5512 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5513 tui_set_disassem_content.
5514
2ddaf614
TT		 55152019-08-16 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-winsource.h (struct tui_source_window_base)
5518 <update_breakpoint_info>: Declare.
5519 (tui_update_breakpoint_info): Don't declare.
5520 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5521 (tui_update_all_breakpoint_info): Update.
5522 (tui_source_window_base::update_breakpoint_info): Rename from
5523 tui_update_breakpoint_info.
5524 (tui_source_window_base::update_exec_info): Update.
5525
017f9828
TT		 55262019-08-16 Tom Tromey <tom@tromey.com>
5527
5528 * tui/tui-winsource.h (struct tui_source_window_base)
5529 <update_source_window>: Declare.
5530 (tui_update_source_window): Don't declare.
5531 * tui/tui-winsource.c
5532 (tui_source_window_base::update_source_window): Rename from
5533 tui_update_source_window.
5534 (tui_source_window_base::rerender): Update.
5535 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5536 * tui/tui-disasm.c (tui_show_disassem)
5537 (tui_show_disassem_and_update_source)
5538 (tui_disasm_window::maybe_update): Update.
5539
ed8358e9
TT		 55402019-08-16 Tom Tromey <tom@tromey.com>
5541
5542 * tui/tui-winsource.h (struct tui_source_window_base)
5543 <update_source_window_as_is>: Declare.
5544 (tui_update_source_window_as_is): Don't declare.
5545 * tui/tui-winsource.c (tui_update_source_window): Update
5546 (tui_source_window_base::update_source_window_as_is): Rename from
5547 tui_update_source_window_as_is.
5548 (tui_source_window_base::refill): Update.
5549 * tui/tui-source.c (tui_show_symtab_source): Update.
5550 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5551 Update.
5552
20149b6b
TT		 55532019-08-16 Tom Tromey <tom@tromey.com>
5554
5555 * tui/tui-winsource.h (tui_update_source_window)
5556 (tui_update_source_window_as_is): Remove "noerror" parameter.
5557 * tui/tui-winsource.c (tui_update_source_window)
5558 (tui_update_source_window_as_is): Remove "noerror" parameter.
5559 (tui_update_source_windows_with_addr)
5560 (tui_update_source_windows_with_line)
5561 (tui_source_window_base::rerender)
5562 (tui_source_window_base::refill): Update.
5563 * tui/tui-source.h (tui_set_source_content)
5564 (tui_show_symtab_source): Remove "noerror" parameter.
5565 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5566 parameter.
5567 (tui_show_symtab_source): Likewise.
5568 (tui_source_window::maybe_update): Update.
5569 * tui/tui-disasm.c (tui_show_disassem)
5570 (tui_show_disassem_and_update_source)
5571 (tui_disasm_window::do_scroll_vertical)
5572 (tui_disasm_window::maybe_update): Update.
5573
2d83e710
TT		 55742019-08-16 Tom Tromey <tom@tromey.com>
5575
5576 * tui/tui.c (tui_is_window_visible): Update.
5577 * tui/tui-wingeneral.c (tui_make_window)
5578 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5579 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5580 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5581 (tui_set_win_height_command, parse_scrolling_args): Update.
5582 * tui/tui-source.c (tui_source_window::style_changed): Update.
5583 * tui/tui-regs.c (tui_show_registers)
5584 (tui_data_window::first_data_item_displayed)
5585 (tui_data_window::delete_data_content_windows)
5586 (tui_check_register_values, tui_reg_command): Update.
5587 * tui/tui-disasm.c (tui_show_disassem): Update.
5588 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5589 method.
5590 <is_visible>: Remove field.
5591 * tui/tui-data.c (tui_next_win, tui_prev_win)
5592 (tui_delete_invisible_windows): Update.
5593
d4ab829a
TT		 55942019-08-16 Tom Tromey <tom@tromey.com>
5595
5596 * tui/tui-winsource.h (struct tui_source_window_base)
5597 <m_has_locator>: Remove.
5598 * tui/tui-layout.c (show_source_disasm_command, show_data)
5599 (show_source_or_disasm_and_command): Update.
5600
aa7ca1bb
AH		 56012019-08-16 Alan Hayward <alan.hayward@arm.com>
5602
5603 * NEWS (Other MI changes): New subsection.
5604 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5605 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5606 * arch-utils.c (default_get_pc_address_flags): New function.
5607 * arch-utils.h (default_get_pc_address_flags): New declaration.
5608 * gdbarch.sh: Add get_pc_address_flags.
5609 * gdbarch.c: Regenerate.
5610 * gdbarch.h: Likewise.
5611 * stack.c (print_pc): New function.
5612 (print_frame_info) (print_frame): Call print_pc.
5613
6eac171f
TV		 56142019-08-16 Tom de Vries <tdevries@suse.de>
5615
5616 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5617 print_objfile_section_info.
5618
3df505f6
TT		 56192019-08-15 Tom Tromey <tom@tromey.com>
5620
5621 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5622 calling update_cmdwin_start_line.
5623 * tui/tui-winsource.h (struct tui_source_window_base)
5624 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5625 <rerender>: Declare.
5626 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5627 Call rerender.
5628 (tui_source_window_base::set_new_height): Remove.
5629 (tui_source_window_base::rerender): Rename from
5630 do_make_visible_with_new_height.
5631 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5632 resize method.
5633 (tui_win_info::make_invisible_and_set_new_height)
5634 (tui_win_info::make_visible_with_new_height): Remove.
5635 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5636 Declare.
5637 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5638 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5639 do_make_visible_with_new_height>: Don't declare.
5640 <rerender>: Declare.
5641 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5642 set_new_height.
5643 (tui_data_window::do_make_visible_with_new_height): Remove.
5644 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5645 call tui_show_locator_content.
5646 (tui_gen_win_info::resize): Call rerender.
5647 (show_source_or_disasm_and_command): Don't call
5648 tui_show_locator_content.
5649 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5650 method.
5651 (struct tui_win_info) <rerender>: Declare.
5652 <set_new_height, make_invisible_and_set_new_height,
5653 make_visible_with_new_height>: Don't declare.
5654 * tui/tui-data.c (tui_win_list::rerender): New method.
5655 * tui/tui-command.h (struct tui_cmd_window)
5656 <do_make_visible_with_new_height>: Don't declare.
5657 * tui/tui-command.c
5658 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5659
272560b5
TT		 56602019-08-15 Tom Tromey <tromey@adacore.com>
5661
5662 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5663 * ada-lang.c (ada_enum_name): Likewise.
5664
08235187
CB		 56652019-08-15 Christian Biesinger <cbiesinger@google.com>
5666
5667 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5668 leading underscore.
5669 (GdbOutputErrorFile): Likewise.
5670 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5671 accordingly.
5672 (execute_unwinders): Rename to have a leading underscore.
5673 (auto_load_packages): Likewise.
5674 (global scope): Adjust call to auto_load_packages accordingly.
5675 (GdbSetPythonDirectory): Likewise.
5676 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5677 instead of execute_unwinders.
5678
db502012
TT		 56792019-08-15 Tom Tromey <tom@tromey.com>
5680
5681 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5682 (show_data): Don't change window visibility.
5683 (tui_gen_win_info::resize): Remove special case for command
5684 window. Use wresize, when available.
5685 (show_source_or_disasm_and_command): Don't change window
5686 visibility.
5687 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5688 <make_visible>: New method.
5689 * tui/tui-command.c (tui_cmd_window::resize): New method.
5690
3891b65e
TT		 56912019-08-15 Tom Tromey <tom@tromey.com>
5692
5693 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5694 (struct tui_source_windows): New.
5695 * tui/tui-winsource.c (tui_display_main): Update.
5696 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5697 (new_height_ok, parse_scrolling_args): Update.
5698 * tui/tui-layout.c (show_layout, show_data): Update.
5699 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5700 (tui_add_to_source_windows): Don't declare.
5701 * tui/tui-data.c (source_windows, tui_source_windows)
5702 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5703
ee556432
TT		 57042019-08-15 Tom Tromey <tom@tromey.com>
5705
5706 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5707 Rename from reset.
5708 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5709 * tui/tui-layout.c (show_source_disasm_command, show_data):
5710 Update.
5711 (tui_gen_win_info::resize): Rename.
5712 (show_source_or_disasm_and_command): Update.
5713 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5714 reset.
5715
46f438e3
TT		 57162019-08-15 Tom Tromey <tom@tromey.com>
5717
5718 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5719 * tui/tui-interp.c (tui_interp::init): Don't call
5720 tui_initialize_static_data.
5721 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5722
f4ce562c
TT		 57232019-08-15 Tom Tromey <tom@tromey.com>
5724
5725 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5726 examine tui_win_list.
5727
c398c3d0
TT		 57282019-08-15 Tom Tromey <tom@tromey.com>
5729
5730 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5731 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5732 tui_clear_source_content.
5733 (tui_clear_source_content): Remove.
5734 (tui_source_window_base::do_erase_source_content): Hoist call to
5735 content.clear().
5736 * tui/tui-stack.c (tui_show_frame_info): Don't call
5737 tui_clear_source_content.
5738
e25d2004
TT		 57392019-08-15 Tom Tromey <tom@tromey.com>
5740
5741 * tui/tui-winsource.h (struct tui_source_window_base)
5742 <do_erase_source_content>: New method.
5743 <erase_source_content>: New method.
5744 (tui_erase_source_content): Don't declare.
5745 * tui/tui-winsource.c (tui_clear_source_content): Update.
5746 (tui_source_window_base::do_erase_source_content): Rename from
5747 tui_erase_source_content.
5748 (tui_source_window_base::show_source_content): Update.
5749 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5750 * tui/tui-source.h (struct tui_source_window)
5751 <erase_source_content>: New method.
5752 * tui/tui-disasm.h (struct tui_disasm_window)
5753 <erase_source_content>: New method.
5754
002f15c2
TT		 57552019-08-15 Tom Tromey <tom@tromey.com>
5756
5757 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5758 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5759 constructor.
5760 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5761 * tui/tui-source.c (tui_set_source_content): Update.
5762 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5763
c9033fe8
TT		 57642019-08-15 Tom Tromey <tom@tromey.com>
5765
5766 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5767 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5768 tui-source.c.
5769 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5770 Declare.
5771 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5772 method.
5773 (tui_source_window::maybe_update): Update.
5774
088f37dd
TT		 57752019-08-15 Tom Tromey <tom@tromey.com>
5776
5777 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5778 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5779 tui-disasm.c.
5780 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5781 Declare.
5782 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5783 method.
5784 (tui_disasm_window::maybe_update): Update.
5785
a54700c6
TT		 57862019-08-15 Tom Tromey <tom@tromey.com>
5787
5788 * tui/tui-winsource.h (struct tui_source_window_base)
5789 <maybe_update>: Declare.
5790 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5791 method.
5792 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5793 Declare.
5794 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5795 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5796 Declare.
5797 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5798
e2a678a5
TT		 57992019-08-15 Tom Tromey <tom@tromey.com>
5800
5801 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5802
f2dda477
TT		 58032019-08-15 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui-wingeneral.c: Include tui-stack.h.
5806 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5807 (struct tui_locator_window): Move from tui-data.h.
5808 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5809 (tui_initialize_static_data): Move from tui-data.c.
5810 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5811 (struct tui_locator_window): Move to tui-stack.c.
5812 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5813 (tui_initialize_static_data): Move to tui-stack.c.
5814
ed4a1084
TT		 58152019-08-15 Tom Tromey <tom@tromey.com>
5816
5817 * tui/tui-layout.c (show_source_disasm_command)
5818 (show_source_or_disasm_and_command): Use make_visible method, not
5819 tui_make_window.
5820 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5821 Remove.
5822
65962b20
TT		 58232019-08-15 Tom Tromey <tom@tromey.com>
5824
5825 * tui/tui-wingeneral.h (tui_make_window): Update.
5826 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5827 parameter.
5828 (tui_gen_win_info::make_visible): Update.
5829 * tui/tui-regs.c (tui_data_window::display_registers_from):
5830 Update.
5831 * tui/tui-layout.c (show_source_disasm_command)
5832 (show_source_or_disasm_and_command): Update.
5833 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5834 (enum tui_box): Remove.
5835 (struct tui_win_info) <can_box>: New method.
5836 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5837 method.
5838
2208ee91
TV		 58392019-08-15 Tom de Vries <tdevries@suse.de>
5840
5841 * linux-nat-trad.c: Include gdbarch.h.
5842
75faf5c4
AH		 58432019-08-14 Alan Hayward <alan.hayward@arm.com>
5844
5845 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5846 register sizes.
5847
b1c896b3
TT		 58482019-08-14 Tom Tromey <tromey@adacore.com>
5849
5850 * darwin-nat.c: Include gdbarch.h.
5851 * darwin-nat-info.c: Include gdbarch.h.
5852
6405cd73
TT		 58532019-08-13 Tom Tromey <tom@tromey.com>
5854
5855 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5856 Remove.
5857 * tui/tui-data.c (tui_initialize_static_data): Update.
5858
5216580d
TT		 58592019-08-13 Tom Tromey <tom@tromey.com>
5860
5861 * tui/tui-winsource.h (struct tui_exec_info_window)
5862 <~tui_exec_info_window, maybe_allocate_content, get_content,
5863 m_content>: Remove.
5864 (struct tui_source_window_base) <set_exec_info_content,
5865 show_exec_info_content>: Don't declare.
5866 * tui/tui-winsource.c
5867 (tui_exec_info_window::maybe_allocate_content): Remove.
5868 (tui_source_window_base::update_exec_info): Rename from
5869 set_exec_info_content.
5870 (tui_source_window_base::show_exec_info_content)
5871 (tui_source_window_base::update_exec_info): Remove.
5872
93858ad3
TT		 58732019-08-13 Tom Tromey <tom@tromey.com>
5874
5875 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5876 declare.
5877 * tui/tui-winsource.c (tui_update_source_window_as_is)
5878 (tui_update_source_windows_with_addr, tui_erase_source_content):
5879 Update.
5880 (tui_clear_exec_info_content): Remove.
5881
e321e7ce
TT		 58822019-08-13 Tom Tromey <tom@tromey.com>
5883
5884 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5885 declare.
5886 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5887 call tui_erase_exec_info_content.
5888 (tui_clear_exec_info_content): Rename from
5889 tui_erase_exec_info_content.
5890 (tui_clear_exec_info_content): Delete.
5891
8270ac62
TT		 58922019-08-13 Tom Tromey <tom@tromey.com>
5893
5894 * tui/tui-winsource.h (struct tui_source_window_base)
5895 <show_exec_info_content>: Declare.
5896 (tui_show_exec_info_content): Don't declare.
5897 * tui/tui-winsource.c
5898 (tui_source_window_base::show_exec_info_content): Rename from
5899 tui_show_exec_info_content.
5900 (tui_source_window_base::update_exec_info): Update.
5901
7b56485d
TT		 59022019-08-13 Tom Tromey <tom@tromey.com>
5903
5904 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5905 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5906 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5907 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5908 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5909 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5910 ... here.
5911
7ba913dc
TT		 59122019-08-13 Tom Tromey <tom@tromey.com>
5913
5914 * tui/tui-winsource.h (struct tui_source_window_base)
5915 <update_exec_info>: Declare.
5916 (tui_update_exec_info): Don't declare.
5917 * tui/tui-winsource.c (tui_update_source_window_as_is)
5918 (tui_source_window_base::refresh_all)
5919 (tui_update_all_breakpoint_info): Update.
5920 (tui_source_window_base::update_exec_info): Rename from
5921 tui_update_exec_info.
5922 * tui/tui-stack.c (tui_show_frame_info): Update.
5923
37a4a131
TT		 59242019-08-13 Tom Tromey <tom@tromey.com>
5925
5926 * tui/tui-winsource.h (struct tui_source_window_base)
5927 <set_exec_info_content>: Declare.
5928 (tui_set_exec_info_content): Don't declare.
5929 * tui/tui-winsource.c
5930 (tui_source_window_base::set_exec_info_content): Rename from
5931 tui_set_exec_info_content.
5932 (tui_update_exec_info): Update.
5933
0bd27e07
TT		 59342019-08-13 Tom Tromey <tom@tromey.com>
5935
5936 * tui/tui-winsource.h (struct tui_source_window_base)
5937 <show_source_content>: Declare.
5938 (tui_show_source_content): Don't declare.
5939 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5940 (tui_source_window_base::show_source_content): Rename from
5941 tui_show_source_content.
5942 (tui_source_window_base::refresh_all): Update.
5943 * tui/tui-layout.c (show_source_disasm_command)
5944 (show_source_or_disasm_and_command): Update.
5945
b4ef5aeb
TT		 59462019-08-13 Tom Tromey <tom@tromey.com>
5947
5948 * tui/tui-winsource.c (tui_erase_source_content)
5949 (tui_show_source_content, tui_source_window_base::refresh_all):
5950 Update.
5951 * tui/tui-wingeneral.h
5952 (tui_check_and_display_highlight_if_needed): Don't declare.
5953 * tui/tui-wingeneral.c
5954 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5955 check_and_display_highlight_if_needed.
5956 * tui/tui-win.c (tui_rehighlight_all)
5957 (tui_win_info::make_visible_with_new_height): Update.
5958 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5959 (tui_data_window::erase_data_content)
5960 (tui_data_window::display_all_data): Update.
5961 * tui/tui-data.h (struct tui_win_info)
5962 <check_and_display_highlight_if_needed>: Declare.
5963
fede5273
TT		 59642019-08-13 Tom Tromey <tom@tromey.com>
5965
5966 * tui/tui-win.c (tui_resize_all): Call
5967 tui_delete_invisible_windows.
5968 * tui/tui-layout.c (show_layout): Call
5969 tui_delete_invisible_windows.
5970 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5971 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5972
22c3f490
TT		 59732019-08-13 Tom Tromey <tom@tromey.com>
5974
5975 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5976 tui_add_win_to_layout.
5977
16cb7910
TT		 59782019-08-13 Tom Tromey <tom@tromey.com>
5979
5980 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5981 * tui/tui-layout.c (tui_default_win_height): Now static.
5982
cc0c3ffb
TT		 59832019-08-13 Tom Tromey <tom@tromey.com>
5984
5985 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5986 single switch.
5987 (show_source_disasm_command, show_source_or_disasm_and_command):
5988 Don't check current layout.
5989
3f3ffe54
TT		 59902019-08-13 Tom Tromey <tom@tromey.com>
5991
5992 * tui/tui-wingeneral.c (make_all_visible): Remove.
5993 (tui_make_all_invisible): Simplify.
5994 * tui/tui-layout.c (tui_make_all_invisible): Move from
5995 tui-wingeneral.c; simplify.
5996 (show_layout): Hoist call to tui_make_all_invisible.
5997 (show_data): Don't call tui_make_all_invisible.
5998
69258091
TT		 59992019-08-13 Tom Tromey <tom@tromey.com>
6000
6001 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6002 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6003
62cf57fe
TT		 60042019-08-13 Tom Tromey <tom@tromey.com>
6005
6006 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6007 tui-data.c.
6008 (show_source_disasm_command, show_data)
6009 (show_source_or_disasm_and_command): Don't use
6010 tui_set_current_layout_to.
6011 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6012 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6013 tui-layout.c.
6014 (tui_set_current_layout_to): Remove.
6015
2afade5d
TT		 60162019-08-13 Tom Tromey <tom@tromey.com>
6017
6018 * tui/tui-layout.c (tui_set_layout): Update.
6019 * tui/tui-data.h (struct tui_layout_def): Remove.
6020 (tui_layout_def): Don't declare.
6021 * tui/tui-data.c (layout_def): Remove.
6022 (tui_layout_def): Remove.
6023
a3504e96
TT		 60242019-08-13 Tom Tromey <tom@tromey.com>
6025
6026 * tui/tui-winsource.h (struct tui_source_window_base)
6027 <clear_detail>: No longer "override".
6028 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6029 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6030 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6031 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6032 Remove.
6033 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6034
29c92911
TT		 60352019-08-13 Tom Tromey <tromey@adacore.com>
6036
6037 * tracepoint.c: Don't include readline.h or history.h.
6038
86c6b807
TT		 60392019-08-12 Tom Tromey <tom@tromey.com>
6040
6041 * configure: Rebuild.
6042 * configure.ac: Check for readline 7.
6043 * NEWS: Mention readline 7 requirement.
6044 * README: Update.
6045
5db2718c
TT		 60462019-08-12 Tom Tromey <tom@tromey.com>
6047
6048 * mingw-hdep.c (gdb_select): Remove readline hack.
6049
dac36daf
PFC		 60502019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6051
6052 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6053 when the function fails.
6054
1022c627
AA		 60552019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6056
6057 * s390-tdep.c (s390_type_align): New function.
6058 (s390_gdbarch_init): Set it as type_align gdbarch method.
6059
eba4caf2
TV		 60602019-08-09 Tom de Vries <tdevries@suse.de>
6061
6062 PR gdb/24591
6063 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6064 pc_low with relocation offset.
6065
123cd851
TT		 60662019-08-07 Tom Tromey <tromey@adacore.com>
6067
6068 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6069 (print_frame_args): Update.
6070 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6071 Update.
6072 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6073 * frame.h (struct frame_arg): Add initializers.
6074 <error>: Now a unique_xmalloc_ptr.
6075
3d31bc39
AH		 60762019-08-07 Alan Hayward <alan.hayward@arm.com>
6077
6078 * NEWS: Expand the Pointer Authentication entry.
6079 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6080 (aarch64_frame_unmask_lr): ... to this.
6081 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6082 Call aarch64_frame_unmask_lr.
6083 * frame.c (struct frame_info): Add "masked" variable.
6084 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6085 (fprint_frame): Check for masked pc.
6086 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6087 declarations.
6088 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6089 * stack.c (print_frame): Check for masked pc.
6090
0cf9feb9
TT		 60912019-08-06 Tom Tromey <tom@tromey.com>
6092
6093 * stabsread.c (patch_block_stabs, read_one_struct_field)
6094 (read_enum_type): Use obstack_strndup.
6095 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6096 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6097 * dwarf2read.c (guess_full_die_structure_name)
6098 (anonymous_struct_prefix): Use obstack_strndup.
6099 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6100 * c-exp.y (yylex): Use obstack_strndup.
6101 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6102 (write_var_or_type): Use obstack_strndup.
6103
efba19b0
TT		 61042019-08-06 Tom Tromey <tom@tromey.com>
6105
6106 * symfile.c (reread_symbols): Use obstack_strdup.
6107 * stabsread.c (read_type): Use obstack_strdup.
6108 * gdb_obstack.h (obstack_strdup): New overload.
6109 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6110 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6111 (dwarf2_canonicalize_name): Use obstack_strdup.
6112 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6113 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6114 Use obstack_strdup.
6115
f25102f7
TT		 61162019-08-06 Tom Tromey <tom@tromey.com>
6117
6118 * gdb_obstack.h (obstack_strdup): Define.
6119 * gdb_obstack.c (obstack_strdup): Don't define.
6120
021887d8
TT		 61212019-08-06 Tom Tromey <tom@tromey.com>
6122
6123 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6124 obstack_strdup.
6125 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6126 obstack_strdup.
6127 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6128 * stabsread.c (common_block_start): Use obstack_strdup.
6129 * objfiles.c (set_objfile_main_name, objfile): Use
6130 obstack_strdup.
6131 * namespace.c (add_using_directive): Use obstack_strdup.
6132 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6133 * jit.c (finalize_symtab): Use obstack_strdup.
6134 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6135 (guess_partial_die_structure_name, partial_die_info::fixup)
6136 (dwarf2_name): Use obstack_strdup.
6137 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6138 obstack_strdup.
6139 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6140 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6141 obstack_strdup.
6142 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6143
d2834edc
PW		 61442019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6145
6146 * unittests/help-doc-selftests.c: New file.
6147 * Makefile.in: Add the new file.
6148
590042fc
PW		 61492019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6150
6151 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6152 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6153 the full first line, except when FOR_VALUE_PREFIX. In this case,
6154 the trailing '.' is not output, and the first character is uppercased.
6155 (print_help_for_command): Update call to print_doc_line.
6156 (print_doc_of_command): Likewise.
6157 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6158 * cli/cli-option.c (append_indented_doc): Do not append newline.
6159 (build_help_option): Append newline after first appended_indented_doc
6160 only if a second call is done.
6161 (build_help): Append 2 new lines before each option, except the first
6162 one.
6163 * compile/compile.c (_initialize_compile): Add new lines after
6164 %OPTIONS%, when not at the end of the help.
6165 Change help doc or code
6166 producing the help doc to respect the invariants.
6167 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6168 Also removed the new line after 'Options:', as all other commands
6169 do not put an empty line between 'Options:' and the first option.
6170 * printcmd.c (_initialize_printcmd): Likewise.
6171 * stack.c (_initialize_stack): Likewise.
6172 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6173 incorrectly telling COMMAND is optional.
6174 * ada-lang.c (_initialize_ada_language): Change help doc or code
6175 producing the help doc to respect the invariants.
6176 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6177 * breakpoint.c (_initialize_breakpoint): Likewise.
6178 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6179 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6180 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6181 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6182 _initialize_cli_style): Likewise.
6183 * corelow.c (core_target_info): Likewise.
6184 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6185 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6186 * filesystem.c (_initialize_filesystem): Likewise.
6187 * frame.c (_initialize_frame): Likewise.
6188 * gnu-nat.c (add_task_commands): Likewise.
6189 * infcall.c (_initialize_infcall): Likewise.
6190 * infcmd.c (_initialize_infcmd): Likewise.
6191 * interps.c (_initialize_interpreter): Likewise.
6192 * language.c (_initialize_language): Likewise.
6193 * linux-fork.c (_initialize_linux_fork): Likewise.
6194 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6195 * maint.c (_initialize_maint_cmds): Likewise.
6196 * memattr.c (_initialize_mem): Likewise.
6197 * printcmd.c (_initialize_printcmd): Likewise.
6198 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6199 _RegEx): Likewise.
6200 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6201 * record-btrace.c (_initialize_record_btrace): Likewise.
6202 * record-full.c (_initialize_record_full): Likewise.
6203 * record.c (_initialize_record): Likewise.
6204 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6205 * regcache.c (_initialize_regcache): Likewise.
6206 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6207 _initialize_remote): Likewise.
6208 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6209 * serial.c (_initialize_serial): Likewise.
6210 * skip.c (_initialize_step_skip): Likewise.
6211 * source.c (_initialize_source): Likewise.
6212 * stack.c (_initialize_stack): Likewise.
6213 * symfile.c (_initialize_symfile): Likewise.
6214 * symtab.c (_initialize_symtab): Likewise.
6215 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6216 * top.c (init_main): Likewise.
6217 * tracefile-tfile.c (tfile_target_info): Likewise.
6218 * tracepoint.c (_initialize_tracepoint): Likewise.
6219 * tui/tui-win.c (_initialize_tui_win): Likewise.
6220 * utils.c (add_internal_problem_command): Likewise.
6221 * valprint.c (value_print_option_defs): Likewise.
6222
404f2902
FCE		 62232019-08-06 Frank Ch. Eigler <fche@redhat.com>
6224
6225 PR build/24886
6226 * configure.ac: Drop enable-libmcheck support.
6227 * configure, config.in: Rebuild.
6228 * libmcheck.m4: Remove.
6229 * acinclude.m4: Don't include it.
6230 * Makefile.in: Don't distribute it.
6231 * top.c (print_gdb_configuration): Don't mention it.
6232
046bebe1
TT		 62332019-08-06 Tom Tromey <tom@tromey.com>
6234
6235 * utils.c (set_output_style): Sometimes pass stream to
6236 emit_style_escape.
6237 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6238 * record-btrace.c (btrace_insn_history): Update.
6239 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6240 method.
6241 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6242 Update initializers.
6243 <m_uiout>: New field.
6244 <m_di>: Move lower.
6245 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6246 Remove "uiout" parameter.
6247 (dump_insns): Update.
6248 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6249 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6250
ddbcedf5
CB		 62512019-08-06 Christian Biesinger <cbiesinger@google.com>
6252
6253 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6254 (error_in_psymtab_expansion): Likewise.
6255 (lookup_symbol_via_quick_fns): Likewise.
6256 (basic_lookup_transparent_type_quick): Likewise.
6257 (basic_lookup_transparent_type_1): Likewise.
6258
b08b16c8
TT		 62592019-08-06 Tom Tromey <tromey@adacore.com>
6260
6261 * source.c (last_source_error): Now bool.
6262 (print_source_lines_base): Make "noprint" bool. Only open
6263 source file when last_source_visited changes.
6264
cb44333d
TT		 62652019-08-06 Tom Tromey <tromey@adacore.com>
6266
6267 * annotate.c (annotate_source_line): Use g_source_cache.
6268 * source-cache.c (source_cache::get_plain_source_lines): Change
6269 parameters. Populate m_offset_cache.
6270 (source_cache::ensure): New method.
6271 (source_cache::get_line_charpos): New method.
6272 (extract_lines): Move lower. Change parameters.
6273 (source_cache::get_source_lines): Move lower.
6274 * source-cache.h (class source_cache): Update comment.
6275 <get_line_charpos>: New method.
6276 <get_source_lines>: Update comment.
6277 <clear>: Clear m_offset_cache.
6278 <get_plain_source_lines>: Change parameters.
6279 <ensure>: New method
6280 <m_offset_cache>: New member.
6281 * source.c (forget_cached_source_info_for_objfile): Update.
6282 (info_source_command): Use g_source_cache.
6283 (find_source_lines, open_source_file_with_line_charpos): Remove.
6284 (print_source_lines_base, search_command_helper): Use g_source_cache.
6285 * source.h (open_source_file_with_line_charpos): Don't declare.
6286 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6287 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6288 Use g_source_cache.
6289
872dceaa
TT		 62902019-08-06 Tom Tromey <tromey@adacore.com>
6291
6292 * source-cache.c (source_cache::get_plain_source_lines):
6293 Remove "first_line" and "last_line" parameters.
6294 (source_cache::get_source_lines): Cache plain text.
6295 * source-cache.h (class source_cache)
6296 <get_plain_source_lines>: Update.
6297
269249d9
TT		 62982019-08-06 Tom Tromey <tromey@adacore.com>
6299
6300 * source-cache.c (extract_lines): No longer a method.
6301 Changed type of parameter. Include final newline.
6302 (selftests::extract_lines_test): New function.
6303 (_initialize_source_cache): Likewise.
6304 * source-cache.h (class source_cache)
6305 <extract_lines>: Don't declare.
6306
c0e8dcd8
TT		 63072019-08-06 Tom Tromey <tromey@adacore.com>
6308
6309 * breakpoint.c (init_breakpoint_sal): Update.
6310 (breakpoint): Update.
6311 * breakpoint.h (struct breakpoint) <filter>: Now a
6312 unique_xmalloc_ptr.
6313
0b27c27d
CB		 63142019-08-05 Christian Biesinger <cbiesinger@google.com>
6315
6316 * NEWS: Mention dictionary access on blocks.
6317 * python/py-block.c (blpy_getitem): New function.
6318 (block_object_as_mapping): New struct.
6319 (block_object_type): Use new struct for tp_as_mapping field.
6320
4ee94178
CB		 63212019-08-05 Christian Biesinger <cbiesinger@google.com>
6322
6323 * objfiles.h (objfile): Add a comment describing partial symbols.
6324
8abfcabc
TT		 63252019-08-05 Tom Tromey <tromey@adacore.com>
6326
6327 * compile/compile.c (_initialize_compile): Use _(), not N_().
6328 * thread.c (_initialize_thread): Use _(), not N_().
6329 * stack.c (_initialize_stack): Use _(), not N_().
6330 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6331
2b79f376
SM		 63322019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6333
6334 * dwarf2read.c (struct dw2_symtab_iterator):
6335 <want_specific_block>: Remove.
6336 <block_index>: Change type to gdb::optional.
6337 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6338 change type of BLOCK_INDEX parameter to gdb::optional.
6339 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6340 (dw2_lookup_symbol): Don't pass argument for
6341 WANT_SPECIFIC_BLOCK.
6342 (dw2_expand_symtabs_for_function): Don't pass argument for
6343 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6344 (class dw2_debug_names_iterator)
6345 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6346 parameter, change BLOCK_INDEX type to gdb::optional.
6347 <m_want_specific_block>: Remove.
6348 <m_block_index>: Change type to gdb::optional.
6349 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6350 gdb::optional. Re-write in function of gdb::optional.
6351 (dw2_debug_names_lookup_symbol): Don't pass argument for
6352 WANT_SPECIFIC_BLOCK.
6353 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6354 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6355 BLOCK_INDEX.
6356
ae60f04e
PW		 63572019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6358
6359 * NEWS: Mention changes to "info sources" command.
6360
28cd9371
PW		 63612019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6362
6363 * symtab.c (filename_partial_match_opts): New struct type.
6364 (struct output_source_filename_data): New members
6365 regexp, c_regexp, partial_match.
6366 (output_source_filename): Use new members to decide to print file.
6367 (info_sources_option_defs): New variable.
6368 (make_info_sources_options_def_group, print_info_sources_header,
6369 info_sources_command_completer):
6370 New functions.
6371 (info_sources_command): Read new optional arguments.
6372 (_initialize_symtab): Update info sources help.
6373
ca683e3a
AO		 63742019-08-02 Alexandre Oliva <oliva@adacore.com>
6375
6376 * ada-lang.c (exception_support_info_v0): Renamed from...
6377 (default_exception_support_info): ... this. Create new
6378 definition for v1.
6379 (ada_has_this_exception_support): Look up catch_handlers_sym.
6380 (ada_exception_support_info_sniffer): Try v0 after default.
6381
f1264162
TT		 63822019-08-01 Tom Tromey <tromey@adacore.com>
6383
6384 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6385 gdbarch.h.
6386
0a7b2485
CB		 63872019-08-01 Christian Biesinger <cbiesinger@google.com>
6388
6389 * s12z-tdep.c: Fix include path for s12z-opc.h.
6390
c6bdbeb7
AH		 63912019-08-01 Alan Hayward <alan.hayward@arm.com>
6392
6393 * NEWS: Require GNU make 3.82.
6394
a2bd7b82
TT		 63952019-07-16 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6398 declare.
6399
aa3b6533
TT		 64002019-07-30 Tom Tromey <tromey@adacore.com>
6401
6402 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6403
a1530dc7
KB		 64042019-07-30 Kevin Buettner <kevinb@redhat.com>
6405
6406 * printcmd.c (print_address_symbolic): Print negative offsets.
6407 (build_address_symbolic): Force signed arithmetic when computing
6408 offset.
6409
2906593f
CB		 64102019-07-30 Christian Biesinger <cbiesinger@google.com>
6411
6412 PR/24474: Add a function to lookup static variables.
6413 * NEWS: Mention this new function.
6414 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6415 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6416 * python/python.c (python_GdbMethods): Add new function.
6417
c620ed88
CB		 64182019-07-29 Christian Biesinger <cbiesinger@google.com>
6419
6420 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6421 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6422 (objfpy_lookup_static_symbol): New function.
6423 (objfile_object_methods): Add new functions.
6424
bc4268a5
PW		 64252019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6426
6427 * NEWS: Mention 'set|show print frame-info'. Mention new
6428 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6429 backtrace argument. Mention that python frame filtering code
6430 is now consistent with what 'backtrace' command prints.
6431
4b5e8d19
PW		 64322019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6433
6434 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6435 comments.
6436 (print_frame_info_auto, print_frame_info_source_line,
6437 print_frame_info_location, print_frame_info_source_and_location,
6438 print_frame_info_location_and_address, print_frame_info_short_location):
6439 New declarations.
6440 (struct frame_print_options): New member print_frame_info.
6441 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6442 * stack.h (get_user_print_what_frame_info): New declaration.
6443 (frame_show_address): New declaration.
6444 * stack.c (print_frame_arguments_choices): New value 'presence'.
6445 (print_frame_info_auto, print_frame_info_source_line,
6446 print_frame_info_location, print_frame_info_source_and_location,
6447 print_frame_info_location_and_address, print_frame_info_short_location,
6448 print_frame_info_choices, print_frame_info_print_what): New definitions.
6449 (print_frame_args): Only print dots for args if print frame-arguments
6450 is 'presence'.
6451 (frame_print_option_defs): New element for "frame-info".
6452 (get_user_print_what_frame_info): New function.
6453 (frame_show_address): Make non static. Move comment to stack.h.
6454 (print_frame_info_to_print_what): New function.
6455 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6456 to decide what to print.
6457 (backtrace_command_1): Handle the new print_frame_arguments_presence
6458 value.
6459 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6460 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6461 (py_print_frame): In non-mi mode, use LOCATION as default for
6462 print_what, similarly to frame information printed directly by
6463 backtrace command. Handle frame-info user option in non MI mode.
6464
6bdfee81
KB		 64652019-07-27 Kevin Buettner <kevinb@redhat.com>
6466
6467 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6468 Add case for debugging 32-bit target on 64-bit host. Revise
6469 comment.
6470
98a617f8
KB		 64712019-07-27 Kevin Buettner <kevinb@redhat.com>
6472
6473 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6474 instead of find_function_entry_range_from_pc.
6475
567238c9
KB		 64762019-07-27 Kevin Buettner <kevinb@redhat.com>
6477
6478 * stack.c (find_frame_funname): Remove code which preferred
6479 minsym over symtab sym in "certain pathological cases".
6480
2dc80cf8
KB		 6481 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6482 parameter. Change type of "do_demangle" to bool.
6483 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6484 Pass suitable "prefer_sym_over_minsym" flag to
6485 build_address_symbolic(). Don't output "+" for negative offsets.
6486 * printcmd.c (print_address_symbolic): Update invocation of
6487 build_address_symbolic to include a "prefer_sym_over_minsym"
6488 flag.
6489 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6490 Restrict cases in which use of minimal symbol is preferred to that
6491 of a found symbol. Update comments.
6492
1aff7173
KB		 6493 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6494 for entry pc when entry pc is out of range for that FDE.
6495
89b085ac
BC		 64962019-07-26 Brian Callahan <bcallah@openbsd.org>
6497
6498 PR gdb/24839:
6499 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6500 type.
6501
f32feb4a
CB		 65022019-07-25 Christian Biesinger <cbiesinger@google.com>
6503
6504 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6505 this function's Python signature.
6506
6507
65082019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6509
6510 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6511 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6512 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6513 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6514 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6515
6516
c54e4253
YS		 65172019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6518
6519 * h8300-tdep.c (h8300_register_name_common): New.
6520 h8300_register_name): Use h8300_register_name_common.
6521 (h8300s_register_name): Likewise.
6522 (h8300sx_register_name): Likewise.
6523 (h8300h_register_nam): New.
6524 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6525
6526
40eadf04
SP		 65272019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6528
6529 * arm-tdep.c (arm_skip_cmse_entry): New function.
6530 (arm_is_sgstubs_section): New function.
6531 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6532
bfa2a36d
TT		 65332019-07-22 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6536 Don't self-assign.
6537
a8e9d247
AB		 65382019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6539
6540 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6541 type_print.
6542
eb86c5e2
AB		 65432019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6544
6545 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6546 so that GDB doesn't match any msymbols when searching in the
6547 TYPES_DOMAIN.
6548 (print_symbol_info): Print using typedef_print or type_print based
6549 on the type of the symbol. Add updated FIXME comment moved from...
6550 (_initialize_symtab): ... move and update FIXME comment to above.
6551
a8eab7c6
AB		 65522019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6553
6554 * NEWS: Mention adding -q option to "info types".
6555 * symtab.c (struct info_types_options): New struct.
6556 (info_types_options_defs): New variable.
6557 (make_info_types_options_def_group): New function.
6558 (info_types_command): Use gdb::option framework to parse options.
6559 (info_types_command_completer): New function.
6560 (_initialize_symtab): Extend the help text on "info types" and
6561 register command completer.
6562
b4603c34
CB		 65632019-07-21 Christian Biesinger <cbiesinger@google.com>
6564
6565 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6566 (lookup_symbol_in_objfile): Change int to block_enum and add a
6567 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6568
c8cdc1e0
CB		 65692019-07-20 Christian Biesinger <cbiesinger@google.com>
6570
6571 * MAINTAINERS (Write After Approval): Add self.
6572
01e175fe
AB		 65732019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6574
6575 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6576 instruction to the dummy code region.
6577
56f79b63
TT		 65782019-07-19 Tom Tromey <tromey@adacore.com>
6579
6580 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6581 (ARGSUSED, PARAMS, __func__): Remove rules.
6582
4c5aa8e0
AH		 65832019-07-19 Alan Hayward <alan.hayward@arm.com>
6584
6585 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6586 * features/arm/arm-with-iwmmxt.c: Remove.
6587 * features/arm/arm-with-iwmmxt.xml: Remove.
6588 * features/arm/arm-with-m-fpa-layout.c: Remove.
6589 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6590 * features/arm/arm-with-m-vfp-d16.c: Remove.
6591 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6592 * features/arm/arm-with-m.c: Remove.
6593 * features/arm/arm-with-m.xml: Remove.
6594 * features/arm/arm-with-neon.c: Remove.
6595 * features/arm/arm-with-neon.xml: Remove.
6596 * features/arm/arm-with-vfpv2.c: Remove.
6597 * features/arm/arm-with-vfpv2.xml: Remove.
6598 * features/arm/arm-with-vfpv3.c: Remove.
6599 * features/arm/arm-with-vfpv3.xml: Remove.
6600
f42b2617
AH		 66012019-07-19 Alan Hayward <alan.hayward@arm.com>
6602
6603 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6604
f29ec966
AH		 66052019-07-19 Alan Hayward <alan.hayward@arm.com>
6606
6607 * arch/aarch32.c (aarch32_create_target_description): Create
6608 target descriptions using features.
6609 * arch/arm.c (arm_create_target_description)
6610 (arm_create_mprofile_target_description): Likewise.
6611 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6612
d105cce5
AH		 66132019-07-19 Alan Hayward <alan.hayward@arm.com>
6614
6615 * Makefile.in: Add new files.
6616 * aarch32-tdep.c: New file.
6617 * aarch32-tdep.h: New file.
6618 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6619 Call aarch32_read_description.
6620 * arch/aarch32.c: New file.
6621 * arch/aarch32.h: New file.
6622 * arch/arm.c (arm_create_target_description)
6623 (arm_create_mprofile_target_description): New function.
6624 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6625 (arm_create_target_description)
6626 (arm_create_mprofile_target_description): New declaration.
6627 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6628 read_description functions.
6629 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6630 Likewise.
6631 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6632 * arm-tdep.c (tdesc_arm_list): New variable.
6633 (arm_register_g_packet_guesses): Call create description functions.
6634 (arm_read_description) (arm_read_mprofile_description): New
6635 function.
6636 * arm-tdep.h (arm_read_description)
6637 (arm_read_mprofile_description): Add declaration.
6638 * configure.tgt: Add new files.
6639
afe09f0b
GL		 66402019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6641
6642 * top.c (new_ui_command): Open specified terminal just once.
6643
cd215b2e
TT		 66442019-07-18 Tom Tromey <tromey@adacore.com>
6645
6646 * symtab.c (main_name): Constify return type.
6647 * symfile.c (set_initial_language): Update.
6648 * symtab.h (main_name): Constify return type.
6649
d8f68fcb
TT		 66502019-07-17 Tom Tromey <tom@tromey.com>
6651
6652 * tui/tui-winsource.c (tui_update_source_window)
6653 (tui_update_source_window_as_is)
6654 (tui_update_source_windows_with_line): Remove return.
6655 * tui/tui-disasm.c (tui_show_disassem)
6656 (tui_show_disassem_and_update_source): Remove return.
6657 * tui/tui.c (tui_reset): Remove return.
6658 * tui/tui-wingeneral.c
6659 (tui_check_and_display_highlight_if_needed): Remove return.
6660
ca5af91e
TT		 66612019-07-17 Tom Tromey <tom@tromey.com>
6662
6663 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6664
5104fe36
TT		 66652019-07-17 Tom Tromey <tom@tromey.com>
6666
6667 * tui/tui-winsource.h (struct tui_exec_info_window)
6668 (struct tui_source_window_base): Move from tui-data.h.
6669 * tui/tui-winsource.c: Move many method definitions from
6670 elsewhere. Remove "structuring" comments.
6671 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6672 (tui_source_window_base::refresh_window): Move to
6673 tui-winsource.c.
6674 * tui/tui-win.c (tui_source_window_base::refresh_all)
6675 (tui_source_window_base::update_tab_width)
6676 (tui_source_window_base::set_new_height)
6677 (tui_source_window_base::do_make_visible_with_new_height): Move to
6678 tui-winsource.c.
6679 * tui/tui-source.h: Update.
6680 * tui/tui-source.c (tui_source_window_base::reset): Move to
6681 tui-winsource.c.
6682 * tui/tui-disasm.h: Update.
6683 * tui/tui-data.h (struct tui_exec_info_window): Move to
6684 tui-winsource.h.
6685 (struct tui_source_window_base): Likewise.
6686 * tui/tui-data.c (tui_source_window_base::clear_detail)
6687 (tui_source_window_base, ~tui_source_window_base): Move to
6688 tui-winsource.c.
6689
daa15dde
TT		 66902019-07-17 Tom Tromey <tom@tromey.com>
6691
6692 * tui/tui-win.c (tui_resize_all)
6693 (tui_source_window_base::update_tab_width)
6694 (tui_adjust_win_heights): Update.
6695 (tui_win_info::make_invisible_and_set_new_height): Rename from
6696 make_invisible_and_set_new_height.
6697 * tui/tui-data.h (struct tui_win_info)
6698 <make_invisible_and_set_new_height>: New method.
6699
bfad4537
TT		 67002019-07-17 Tom Tromey <tom@tromey.com>
6701
6702 * tui/tui.c: Update.
6703 * tui/tui-source.h (struct tui_source_window): Move from
6704 tui-data.h.
6705 * tui/tui-layout.c: Update.
6706 * tui/tui-disasm.c: Update.
6707 * tui/tui-data.h (struct tui_source_window): Move to
6708 tui-source.h.
6709
88f7e873
TT		 67102019-07-17 Tom Tromey <tom@tromey.com>
6711
6712 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6713 tui-data.h.
6714 * tui/tui-data.h (struct tui_disasm_window): Move to
6715 tui-disasm.h.
6716
96bd6233
TT		 67172019-07-17 Tom Tromey <tom@tromey.com>
6718
6719 * tui/tui-regs.h (struct tui_data_item_window): Move from
6720 tui-data.h.
6721 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6722 * tui/tui-data.h (struct tui_data_item_window): Move to
6723 tui-regs.h.
6724 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6725
ce38393b
TT		 67262019-07-17 Tom Tromey <tom@tromey.com>
6727
6728 * tui/tui.c: Update.
6729 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6730 (tui_cmd_window::max_height): Move to tui-command.c.
6731 * tui/tui-layout.c: Update.
6732 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6733 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6734 tui-command.c.
6735 * tui/tui-command.h (struct tui_cmd_window): Move from
6736 tui-data.h.
6737 * tui/tui-command.c: Remove "structuring" comments.
6738 (tui_cmd_window::clear_detail)
6739 (tui_cmd_window::do_make_visible_with_new_height)
6740 (tui_cmd_window::max_height): Move from elsewhere.
6741
2d8b51cb
TT		 67422019-07-17 Tom Tromey <tom@tromey.com>
6743
6744 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6745 Now static.
6746 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6747 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6748
18ab23af
TT		 67492019-07-17 Tom Tromey <tom@tromey.com>
6750
6751 * tui/tui.c: Update.
6752 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6753 tui-regs.c.
6754 * tui/tui-windata.h: Remove file.
6755 * tui/tui-windata.c: Remove file.
6756 * tui/tui-win.c (tui_data_window::set_new_height)
6757 (tui_data_window::do_make_visible_with_new_height): Move to
6758 tui-regs.c.
6759 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6760 * tui/tui-regs.c: Remove "structuring" comments.
6761 (tui_data_window::first_data_item_displayed)
6762 (tui_data_window::delete_data_content_windows)
6763 (tui_data_window::erase_data_content)
6764 (tui_data_window::display_all_data)
6765 (tui_data_window::refresh_all)
6766 (tui_data_window::do_scroll_vertical)
6767 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6768 (tui_data_window::do_make_visible_with_new_height)
6769 (tui_data_window::refresh_window): Move from elsewhere.
6770 (_initialize_tui_regs): Move to end of file.
6771 * tui/tui-layout.c: Update.
6772 * tui/tui-hooks.c: Update.
6773 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6774 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6775 tui-regs.c.
6776 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6777
88b7e7cc
TT		 67782019-07-17 Tom Tromey <tom@tromey.com>
6779
6780 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6781 seen.
6782
0fcd3711
TT		 67832019-07-17 Tom Tromey <tom@tromey.com>
6784
6785 * tui/tui-win.c (tui_source_window_base::set_new_height)
6786 (tui_source_window_base::do_make_visible_with_new_height): Use
6787 m_has_locator field directly.
6788 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6789 method.
6790 (struct tui_source_window_base) <has_locator>: Likewise.
6791
4a38112d
TT		 67922019-07-17 Tom Tromey <tom@tromey.com>
6793
6794 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6795 Don't declare.
6796 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6797 Remove.
6798 * tui/tui-win.c (tui_source_window_base::set_new_height)
6799 (tui_source_window_base::set_new_height)
6800 (make_invisible_and_set_new_height)
6801 (tui_source_window_base::do_make_visible_with_new_height)
6802 (tui_source_window_base::do_make_visible_with_new_height):
6803 Update.
6804 * tui/tui-layout.c (show_source_disasm_command, show_data)
6805 (show_source_or_disasm_and_command): Update.
6806 * tui/tui-layout.c (show_layout): Update.
6807
09129226
TT		 68082019-07-17 Tom Tromey <tom@tromey.com>
6809
6810 * tui/tui-layout.c (make_data_window): Remove.
6811 (show_data): Unify creation and re-initialization cases.
6812
4a8a5e84
TT		 68132019-07-17 Tom Tromey <tom@tromey.com>
6814
6815 * tui/tui-layout.c (make_source_window, make_disasm_window):
6816 Remove.
6817 (show_data): Unify creation and re-initialization cases.
6818
76d2be8e
TT		 68192019-07-17 Tom Tromey <tom@tromey.com>
6820
6821 * tui/tui-layout.c (make_command_window): Remove.
6822 (show_source_disasm_command, show_source_or_disasm_and_command):
6823 Unify creation and re-initialization cases.
6824
890b8bde
TT		 68252019-07-17 Tom Tromey <tom@tromey.com>
6826
6827 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6828 creation and re-initialization cases.
6829
2cdfa113
TT		 68302019-07-17 Tom Tromey <tom@tromey.com>
6831
6832 * tui/tui-regs.c (tui_get_register): Return void.
6833
8e3cfd09
TT		 68342019-07-17 Tom Tromey <tom@tromey.com>
6835
6836 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6837 Simplify.
6838
f4e04977
TT		 68392019-07-17 Tom Tromey <tom@tromey.com>
6840
6841 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6842 resetting.
6843
0379b883
TT		 68442019-07-17 Tom Tromey <tom@tromey.com>
6845
6846 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6847 * tui/tui-regs.c (tui_reg_layout): New function.
6848 (tui_show_registers, tui_reg_command): Use it.
6849 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6850 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6851 parameters.
6852 (tui_layout_command): Remove.
6853
b7fbad91
TT		 68542019-07-17 Tom Tromey <tom@tromey.com>
6855
6856 * tui/tui-layout.h (tui/tui-layout): Return void.
6857 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6858
4e1e56b9
TT		 68592019-07-17 Tom Tromey <tom@tromey.com>
6860
6861 * tui/tui-layout.c (show_source_disasm_command, show_data):
6862 Update.
6863 (reset_locator): Remove.
6864 (show_source_or_disasm_and_command): Update.
6865
1e0c09ba
TT		 68662019-07-17 Tom Tromey <tom@tromey.com>
6867
6868 * tui/tui-source.c (tui_source_window_base::reset): Remove
6869 win_type parameter.
6870 * tui/tui-layout.c (make_command_window, make_source_window)
6871 (make_disasm_window, make_data_window)
6872 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6873 (reset_locator, show_source_or_disasm_and_command): Update.
6874 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6875 win_type parameter.
6876 (struct tui_source_window_base) <reset>: Likewise.
6877
1bf605de
TT		 68782019-07-17 Tom Tromey <tom@tromey.com>
6879
6880 * tui/tui-layout.c (show_source_disasm_command): Use
6881 reset_locator.
6882 (reset_locator): New function.
6883 (init_and_make_win): Remove.
6884 (show_source_or_disasm_and_command): Use reset_locator.
6885
098f9ed4
TT		 68862019-07-17 Tom Tromey <tom@tromey.com>
6887
6888 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6889 condition.
6890 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6891 Remove condition.
6892 * tui/tui-source.c (tui_source_window_base::reset): New method.
6893 * tui/tui-layout.c (make_command_window): Don't call
6894 init_and_make_win.
6895 (make_source_window, make_disasm_window): Don't call
6896 make_source_or_disasm_window.
6897 (make_data_window): Don't call init_and_make_win. Change calling
6898 convention.
6899 (show_source_disasm_command, show_data): Simplify.
6900 (make_source_or_disasm_window): Remove.
6901 (show_source_or_disasm_and_command): Simplify.
6902 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6903 (struct tui_source_window_base) <reset>: Likewise.
6904 <execution_info>: Remove initializer.
6905 * tui/tui-data.c (tui_source_window_base): Initialize
6906 execution_info.
6907
80110957
TT		 69082019-07-17 Tom Tromey <tom@tromey.com>
6909
6910 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6911 variable.
6912
cf82af05
TT		 69132019-07-17 Tom Tromey <tom@tromey.com>
6914
6915 * tui/tui.c (tui_rl_other_window): Update.
6916 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6917 superclass method first. Always iterate over regs_content.
6918 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6919 method.
6920 * tui/tui-win.c (tui_set_focus_command): Update.
6921
01aeb396
TT		 69222019-07-17 Tom Tromey <tom@tromey.com>
6923
6924 * tui/tui-win.c (tui_set_focus_command): Rename from
6925 tui_set_focus. Call tui_enable.
6926 (tui_set_focus_command): Remove.
6927
fd6c75ee
TT		 69282019-07-17 Tom Tromey <tom@tromey.com>
6929
6930 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6931 refresh_window.
6932 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6933 touchwin.
6934 (tui_data_window::refresh_window): Call refresh_window on data
6935 items. Always call superclass refresh_window.
6936 (tui_win_info::refresh): Remove.
6937 (tui_source_window_base::refresh_window): Update.
6938 (tui_refresh_all): Update.
6939 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6940 refresh_window.
6941 (show_source_or_disasm_and_command): Likewise.
6942 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6943 (struct tui_source_window_base) <refresh>: Likewise.
6944
f6cc34a9
TT		 69452019-07-17 Tom Tromey <tom@tromey.com>
6946
6947 * tui/tui-winsource.c (tui_clear_source_content)
6948 (tui_show_source_content): Update.
6949 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6950 whether content is empty.
6951 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6952 Remove.
6953
f31ec9af
TT		 69542019-07-17 Tom Tromey <tom@tromey.com>
6955
6956 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6957 window's contents.
6958 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6959 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6960
d1b6f1e5
TT		 69612019-07-17 Tom Tromey <tom@tromey.com>
6962
6963 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6964 (struct tui_data_item_window): Update.
6965
d9743a13
TT		 69662019-07-17 Tom Tromey <tom@tromey.com>
6967
6968 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6969 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6970 defines.
6971
caf0bc4e
TT		 69722019-07-17 Tom Tromey <tom@tromey.com>
6973
6974 * tui/tui-winsource.h (tui_erase_source_content)
6975 (tui_clear_source_content): Remove "display_prompt" parameter.
6976 * tui/tui-winsource.c (tui_update_source_window_as_is)
6977 (tui_update_source_windows_with_addr): Update.
6978 (tui_clear_source_content): Remove "display_prompt" parameter.
6979 (tui_erase_source_content): Likewise. Simplify.
6980 (tui_show_source_content): Update.
6981 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6982 * tui/tui-stack.c (tui_show_frame_info): Update.
6983 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6984 Remove defines.
6985
9d391078
TT		 69862019-07-17 Tom Tromey <tom@tromey.com>
6987
6988 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6989 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6990 parameter.
6991 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6992 parameter.
6993
a38da35d
TT		 69942019-07-17 Tom Tromey <tom@tromey.com>
6995
6996 * tui/tui-winsource.c (tui_clear_source_content)
6997 (tui_show_source_content, tui_show_exec_info_content)
6998 (tui_clear_exec_info_content): Update.
6999 * tui/tui-stack.c (tui_show_locator_content): Update.
7000 (tui_show_frame_info): Update.
7001 * tui/tui-source.h (tui_source_window): Don't declare.
7002 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7003 from tui_source_is_displayed.
7004 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7005 Remove field.
7006 (struct tui_source_window_base) <content_in_use>: New field. Now
7007 bool.
7008 (struct tui_source_window) <showing_source_p>: New method.
7009 (TUI_SRC_WIN): Change cast.
7010 * tui/tui-data.c (tui_initialize_static_data): Update.
7011
c2cd8994
TT		 70122019-07-17 Tom Tromey <tom@tromey.com>
7013
7014 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7015 location_matches_p.
7016 * tui/tui-source.c (tui_source_window::location_matches_p): New
7017 method.
7018 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7019 method.
7020 * tui/tui-data.h (struct tui_source_window_base)
7021 <location_matches_p>: New method.
7022 (struct tui_source_window, struct tui_disasm_window)
7023 <location_matches_p>: Likewise.
7024
4dde7b34
TT		 70252019-07-17 Tom Tromey <tom@tromey.com>
7026
7027 * tui/tui-win.c (tui_set_win_height_command): Rename from
7028 tui_set_win_height.
7029 (tui_set_win_height_command): Remove.
7030
b73dd877
TT		 70312019-07-17 Tom Tromey <tom@tromey.com>
7032
7033 * tui/tui-source.c (tui_source_window): New constructor. Add
7034 observer.
7035 (~tui_source_window): New destructor.
7036 (tui_source_window::style_changed): New method.
7037 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7038 (tui_attach_detach_observers): Update.
7039 * tui/tui-data.h (struct tui_source_window): Make constructor not
7040 inline. Add destructor.
7041 (struct tui_source_window) <style_changed>: New method.
7042 <m_observable>: New member.
7043
ae2b5380
TT		 70442019-07-17 Tom Tromey <tom@tromey.com>
7045
7046 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7047 * tui/tui-win.c (tui_resize_all): Fix typo.
7048
1ce3e844
TT		 70492019-07-17 Tom Tromey <tom@tromey.com>
7050
7051 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7052 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7053 (tui_refresh_all): Remove "list" parameter. Use foreach.
7054 * tui/tui-win.c (window_name_completer): Use foreach.
7055 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7056 (update_tab_width): Likewise.
7057 * tui/tui-layout.c (show_layout): Update.
7058 * tui/tui-data.h (class tui_window_iterator): New.
7059 (struct all_tui_windows): New.
7060 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7061
fe3eaf1c
TT		 70622019-07-17 Tom Tromey <tom@tromey.com>
7063
7064 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7065 parameter. Don't reference globals.
7066 (tui_reg_command): Update.
7067
368c1354
TT		 70682019-07-17 Tom Tromey <tom@tromey.com>
7069
7070 * tui/tui-regs.c (tui_show_registers): Simplify.
7071
e80cd204
TT		 70722019-07-17 Tom Tromey <tom@tromey.com>
7073
7074 * tui/tui-regs.c (tui_show_registers): Update.
7075 (tui_show_register_group): Add win_info parameter.
7076
aca2dd16
TT		 70772019-07-17 Tom Tromey <tom@tromey.com>
7078
7079 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7080 Rename from tui_display_reg_element_at_line.
7081 (tui_data_window::display_registers_from_line): Update.
7082 * tui/tui-data.h (struct tui_data_window)
7083 <display_reg_element_at_line>: New method.
7084
517e9505
TT		 70852019-07-17 Tom Tromey <tom@tromey.com>
7086
7087 * tui/tui-regs.h (tui_display_registers_from)
7088 (tui_display_registers_from_line): Don't declare.
7089 * tui/tui-windata.c (tui_data_window::display_all_data)
7090 (tui_data_window::refresh_all)
7091 (tui_data_window::do_scroll_vertical): Update.
7092 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7093 from tui_display_registers_from.
7094 (tui_display_reg_element_at_line): Update.
7095 (tui_data_window::display_registers_from_line): Rename from
7096 tui_display_registers_from_line.
7097 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7098 display_registers_from_line>: New methods.
7099
f76d8b19
TT		 71002019-07-17 Tom Tromey <tom@tromey.com>
7101
7102 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7103 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7104 from tui_erase_data_content.
7105 (tui_data_window::display_all_data)
7106 (tui_data_window::refresh_all)
7107 (tui_data_window::do_scroll_vertical): Update.
7108 * tui/tui-regs.c (tui_show_registers): Update.
7109 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7110 New method.
7111
b4094625
TT		 71122019-07-17 Tom Tromey <tom@tromey.com>
7113
7114 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7115 declare.
7116 * tui/tui-windata.c
7117 (tui_data_window::delete_data_content_windows): Rename from
7118 tui_delete_data_content_windows.
7119 (tui_data_window::display_all_data)
7120 (tui_data_window::do_scroll_vertical): Update.
7121 * tui/tui-data.h (struct tui_data_window)
7122 <delete_data_content_windows>: New method.
7123
c223a729
TT		 71242019-07-17 Tom Tromey <tom@tromey.com>
7125
7126 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7127 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7128
50daf268
TT		 71292019-07-17 Tom Tromey <tom@tromey.com>
7130
7131 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7132 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7133 from tui_display_all_data.
7134 * tui/tui-win.c
7135 (tui_data_window::do_make_visible_with_new_height): Update.
7136 * tui/tui-regs.c (tui_show_registers): Update.
7137 * tui/tui-layout.c (tui_set_layout): Update.
7138 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7139 method.
7140
df5f8cab
TT		 71412019-07-17 Tom Tromey <tom@tromey.com>
7142
7143 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7144 * tui/tui-windata.c (tui_display_data_from): Remove.
7145 (tui_data_window::refresh_all): Update.
7146
80cb6c27
TT		 71472019-07-17 Tom Tromey <tom@tromey.com>
7148
7149 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7150 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7151 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7152 tui_display_registers_from_line.
7153 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7154 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7155 "force_display" parameter.
7156
baff0c28
TT		 71572019-07-17 Tom Tromey <tom@tromey.com>
7158
7159 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7160 declare.
7161 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7162 Rename from tui_first_reg_element_no_inline.
7163 (tui_display_reg_element_at_line)
7164 (tui_display_registers_from_line): Update.
7165 * tui/tui-data.h (struct tui_data_window)
7166 <first_reg_element_no_inline>: New method.
7167
3b23c5f2
TT		 71682019-07-17 Tom Tromey <tom@tromey.com>
7169
7170 * tui/tui-windata.c (tui_display_data_from)
7171 (tui_data_window::do_scroll_vertical): Update.
7172 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7173 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7174 Rename from tui_line_from_reg_element_no.
7175 (tui_display_registers_from_line): Update.
7176 * tui/tui-data.h (struct tui_data_window)
7177 <line_from_reg_element_no>: New method.
7178
0b5ec218
TT		 71792019-07-17 Tom Tromey <tom@tromey.com>
7180
7181 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7182 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7183 tui_last_regs_line_no.
7184 (tui_display_reg_element_at_line)
7185 (tui_display_registers_from_line): Update.
7186 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7187 method.
7188
0807ab7b
TT		 71892019-07-17 Tom Tromey <tom@tromey.com>
7190
7191 PR tui/24722:
7192 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7193 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7194 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7195 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7196 (tui_update_breakpoint_info): Likewise.
7197 * tui/tui-hooks.c (tui_event_create_breakpoint)
7198 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7199 Update.
7200
9ad7fdef
TT		 72012019-07-17 Tom Tromey <tom@tromey.com>
7202
7203 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7204
5813316f
TT		 72052019-07-17 Tom Tromey <tom@tromey.com>
7206
7207 * tui/tui-winsource.c (tui_update_source_window_as_is)
7208 (tui_update_source_windows_with_addr): Update.
7209 * tui/tui-source.h (tui_set_source_content)
7210 (tui_show_symtab_source): Add "win_info" parameter.
7211 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7212 parameter.
7213 (tui_show_symtab_source): Likewise.
7214
00e264e7
TT		 72152019-07-17 Tom Tromey <tom@tromey.com>
7216
7217 * tui/tui-wingeneral.c
7218 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7219
06210ce4
TT		 72202019-07-17 Tom Tromey <tom@tromey.com>
7221
7222 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7223 (struct tui_cmd_window) <can_scroll>: New method.
7224 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7225 method.
7226
381befee
TT		 72272019-07-17 Tom Tromey <tromey@adacore.com>
7228
7229 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7230 do_field_signed>: Rename. Change type of "value".
7231 * ui-out.c (ui_out::field_signed): Rename from field_int.
7232 Change type of "value".
7233 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7234 type of "value".
7235 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7236 do_field_int. Change type of "value".
7237 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7238 do_field_int. Change type of "value".
7239 * tracepoint.c (trace_status_mi, tfind_1)
7240 (print_one_static_tracepoint_marker): Update.
7241 * thread.c (print_thread_info_1, print_selected_thread_frame):
7242 Update.
7243 * stack.c (print_frame, print_frame_info): Update.
7244 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7245 Update.
7246 * source.c (print_source_lines_base): Update.
7247 * skip.c (info_skip_command): Update.
7248 * record-btrace.c (btrace_ui_out_decode_error)
7249 (btrace_call_history_src_line): Update.
7250 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7251 Update.
7252 * progspace.c (print_program_space): Update.
7253 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7254 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7255 do_field_int. Change type of "value".
7256 * mi/mi-out.c (mi_ui_out::do_table_begin)
7257 (mi_ui_out::do_table_header): Update.
7258 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7259 type of "value".
7260 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7261 (mi_cmd_data_list_changed_registers, output_register)
7262 (mi_cmd_data_read_memory, mi_load_progress)
7263 (mi_cmd_trace_frame_collected): Update.
7264 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7265 Update.
7266 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7267 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7268 (mi_cmd_var_list_children, varobj_update_one): Update.
7269 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7270 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7271 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7272 * inferior.c (print_inferior): Update.
7273 * gdb_bfd.c (print_one_bfd): Update.
7274 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7275 Update.
7276 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7277 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7278 do_field_int. Change type of "value".
7279 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7280 do_field_int. Change type of "value".
7281 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7282 (print_one_breakpoint_location, print_it_catch_fork)
7283 (print_one_catch_fork, print_it_catch_vfork)
7284 (print_one_catch_vfork, print_it_catch_solib)
7285 (print_it_catch_exec, print_it_ranged_breakpoint)
7286 (print_mention_watchpoint, print_mention_masked_watchpoint)
7287 (bkpt_print_it, update_static_tracepoint): Update.
7288 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7289 * break-catch-syscall.c (print_it_catch_syscall): Update.
7290 * ada-tasks.c (print_ada_task_info): Update.
7291 * ada-lang.c (print_it_exception, print_mention_exception):
7292 Update.
7293
6b78c3f8
AB		 72942019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7295
7296 PR breakpoints/24541
7297 * gdbarch.c: Regenerate.
7298 * gdbarch.h: Regenerate.
7299 * gdbarch.sh: Adjust return type and parameter types for
7300 'stap_adjust_register'.
7301 (i386_stap_adjust_register): Adjust signature and return new
7302 register name.
7303 * stap-probe.c (stap_parse_register_operand): Adjust use of
7304 'gdbarch_stap_adjust_register'.
7305
d72a9b85
TT		 73062019-07-17 Tom Tromey <tromey@adacore.com>
7307
7308 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7309 declare VEC.
7310 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7311 std::vector.
7312 (struct s390_process_info): Add initializers.
7313 (s390_add_process): Use new.
7314 (s390_linux_nat_target::low_forget_process): Use delete.
7315 (s390_linux_nat_target::low_new_fork)
7316 (s390_linux_nat_target::stopped_by_watchpoint)
7317 (s390_linux_nat_target::low_prepare_to_resume)
7318 (s390_linux_nat_target::insert_watchpoint)
7319 (s390_linux_nat_target::insert_hw_breakpoint)
7320 (s390_linux_nat_target::remove_watchpoint)
7321 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7322
206e6c58
JB		 73232019-07-16 John Baldwin <jhb@FreeBSD.org>
7324
7325 * aarch64-fbsd-nat.c: Include regcache.h.
7326 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7327 argument.
7328 (aarch64_fbsd_nat_target::fetch_registers)
7329 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7330 variable.
7331 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7332
cbde90f2
JB		 73332019-07-16 John Baldwin <jhb@FreeBSD.org>
7334
7335 * fbsd-nat.c: Include gdbarch.h.
7336
07128006
TT		 73372019-07-15 Tom Tromey <tromey@adacore.com>
7338
7339 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7340
1f77b012
TT		 73412019-07-15 Tom Tromey <tromey@adacore.com>
7342
7343 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7344 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7345 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7346 * cli-out.c (cli_ui_out::do_field_int): New method.
7347 * ui-out.c (ui_out::field_unsigned): New method.
7348 * symfile.c (generic_load): Use field_unsigned.
7349 (print_transfer_performance): Likewise.
7350 * record-btrace.c (ui_out_field_uint): Remove.
7351 (btrace_call_history_insn_range, btrace_call_history): Use
7352 field_unsigned.
7353 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7354 field_unsigned.
7355 * ui-out.h (class ui_out) <field_unsigned>: New method.
7356 <do_field_unsigned>: Likewise.
7357
33eca680
TT		 73582019-07-15 Tom Tromey <tromey@adacore.com>
7359
7360 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7361 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7362 * target.c (flash_erase_command): Use field_string.
7363 * infrun.c (print_signal_received_reason): Use field_string.
7364 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7365 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7366 field_string.
7367 * ada-tasks.c (print_ada_task_info): Use field_string.
7368
ca8d69be
TT		 73692019-07-15 Tom Tromey <tromey@adacore.com>
7370
7371 * target.c (flash_erase_command): Use field_core_addr.
7372 * symfile.c (generic_load): Use field_core_addr.
7373 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7374 Use field_core_addr.
7375 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7376 field_core_addr.
7377
0d4e84ed
AB		 73782019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7379
7380 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7381 value if its desired type is smaller than a CORE_ADDR and signed.
7382
9a49df9d
AB		 73832019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7384
7385 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7386 of changes to field names, and use new is_reference field to
7387 decide if a property is a reference or not.
7388 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7389 field.
7390 (struct dwarf2_property_baton): Update header comment, rename
7391 'referenced_type' to 'property_type' and update comments.
7392 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7393 default property type, store in property baton, update to take
7394 accound of renamed field.
7395 (read_func_scope): Update call to attr_to_dynamic_prop.
7396 (read_array_type): Likewise.
7397 (dwarf2_per_cu_addr_sized_int_type): New function.
7398 (read_subrange_index_type): Move type finding code to
7399 dwarf2_per_cu_addr_sized_int_type.
7400 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7401 (dwarf2_per_cu_addr_type): New function.
7402 (set_die_type): Update calls to attr_to_dynamic_prop.
7403
b86352cf
AB		 74042019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7405
7406 * dwarf2read.c (read_subrange_index_type): New function.
7407 (read_subrange_type): Move code into new function and call it.
7408 * gdbtypes.c (create_range_type): Add some asserts.
7409
603490bf
AB		 74102019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7411
7412 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7413 update return statements.
7414 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7415 declaration, and update comment to match.
7416 * gdbtypes.c (resolve_dynamic_array): Update call to
7417 dwarf2_evaluate_property to match new return type.
7418
592f9d27
AB		 74192019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7420
7421 * valarith.c (value_subscripted_rvalue): Change lowerbound
7422 parameter type from int to LONGEST.
7423 * value.h (value_subscripted_rvalue): Likewise in declaration.
7424
60cfcb20
AB		 74252019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7426
7427 * cli/cli-utils.c (info_print_command_completer): New function.
7428 * cli/cli-utils.h: Add 'completer.h' include, and forward
7429 declaration for 'struct cmd_list_element'.
7430 (info_print_command_completer): Declare.
7431 * stack.c (_initialize_stack): Add completer for 'info locals' and
7432 'info args'.
7433 * symtab.c (_initialize_symtab): Add completer for 'info
7434 variables' and 'info functions'.
7435 * NEWS: Mention completion for additional info commands.
7436
b16507e0
AB		 74372019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7438
7439 * cli/cli-utils.c (extract_info_print_args): Delete.
7440 (extract_arg_maybe_quoted): Delete.
7441 (info_print_options_defs): New variable.
7442 (make_info_print_options_def_group): New function.
7443 (extract_info_print_options): Define new function.
7444 * cli/cli-utils.h (extract_info_print_args): Delete.
7445 (struct info_print_options): New structure.
7446 (extract_info_print_options): Declare new function.
7447 * stack.c (info_locals_command): Update to use new
7448 extract_info_print_options, also add a header comment.
7449 (info_args_command): Likewise.
7450 * symtab.c (info_variables_command): Likewise.
7451 (info_functions_command): Likewise.
7452
021d8588
AB		 74532019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7454
7455 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7456 to extract string arguments.
7457 * common/common-utils.c (extract_string_maybe_quoted): New function.
7458 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7459
b777eb6d
TT		 74602019-07-11 Tom Tromey <tromey@adacore.com>
7461
7462 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7463 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7464 * top.h (gdbinit): Don't declare.
7465 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7466 into...
7467 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7468 * top.c (gdb_init): Don't call init_cli_cmds.
7469 (gdbinit): Remove.
7470 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7471
72ee03ff
TT		 74722019-07-11 Tom Tromey <tromey@adacore.com>
7473
7474 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7475 after it has been moved.
7476
00db9531
SM		 74772019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7478
7479 * valops.c (value_must_coerce_to_target): Change return type to
7480 bool.
7481 * value.h (value_must_coerce_to_target): Likewise.
7482
f2478a7e
SM		 74832019-07-10 Simon Marchi <simon.marchi@efficios.com>
7484
7485 * breakpoint.c (is_hardware_watchpoint): Remove
7486 forward-declaration.
7487 (is_masked_watchpoint): Change return type to bool.
7488 (is_tracepoint): Likewise.
7489 (is_breakpoint): Likewise.
7490 (is_hardware_watchpoint): Likewise.
7491 (is_watchpoint): Likewise.
7492 (is_no_memory_software_watchpoint): Likewise.
7493 (is_catchpoint): Likewise.
7494 (breakpoint_1): Make FILTER parameter's return type bool.
7495 is_masked_watchpoint): Change return type to bool.
7496 (save_breakpoints): Make FILTER parameter's return type bool.
7497 * breakpoint.h (is_breakpoint): Change return type to bool.
7498 (is_watchpoint): Likewise.
7499 (is_catchpoint): Likewise.
7500 (is_tracepoint): Likewise.
7501
0d12e84c
TT		 75022019-07-10 Tom Tromey <tom@tromey.com>
7503
7504 * defs.h: Don't include gdbarch.h.
7505 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7506 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7507 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7508 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7509 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7510 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7511 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7512 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7513 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7514 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7515 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7516 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7517 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7518 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7519 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7520 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7521 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7522 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7523 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7524 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7525 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7526 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7527 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7528 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7529 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7530 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7531 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7532
f06f1252
TT		 75332019-07-10 Tom Tromey <tromey@adacore.com>
7534
7535 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7536 * breakpoint.c (init_ada_exception_breakpoint): Register as
7537 bp_catchpoint.
7538 (print_one_breakpoint_location, print_one_breakpoint): Use
7539 is_ada_exception_catchpoint.
7540 * ada-lang.c (class ada_catchpoint_location): Pass
7541 bp_loc_software_breakpoint to bp_location constructor.
7542 (is_ada_exception_catchpoint): New function.
7543
7a5d944b
TT		 75442019-07-10 Tom Tromey <tromey@adacore.com>
7545
7546 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7547 VEC.
7548 (struct arm_exidx_entry): New method operator<.
7549 (struct arm_exidx_data) <section_maps>: Change type.
7550 (arm_exidx_data_free): Remove.
7551 (arm_exidx_data_key): Change type. Move lower.
7552 (arm_exidx_new_objfile): Update.
7553 (arm_compare_exidx_entries): Remove.
7554 (arm_find_exidx_entry, _initialize_arm_tdep)
7555
48c66e1d
TT		 75562019-07-10 Tom Tromey <tromey@adacore.com>
7557
7558 * solib-spu.c (ocl_program_data_key): Change type.
7559 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7560 Update.
7561
a269fbf1
TT		 75622019-07-10 Tom Tromey <tromey@adacore.com>
7563
7564 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7565 (struct solib_aix_inferior_data) <library_list>: Change type.
7566 (solib_aix_inferior_data_handle): Change type.
7567 (get_solib_aix_inferior_data): Update.
7568 (solib_aix_free_library_list): Remove.
7569 (library_list_start_library): Update.
7570 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7571 return type.
7572 (solib_aix_get_library_list)
7573 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7574 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7575
c294730c
TT		 75762019-07-10 Tom Tromey <tromey@adacore.com>
7577
7578 * solib-dsbt.c (struct dsbt_info): Add initializers.
7579 (solib_dsbt_pspace_data): Change type.
7580 (dsbt_pspace_data_cleanup): Remove.
7581 (get_dsbt_info, _initialize_dsbt_solib): Update.
7582
9d52077d
TT		 75832019-07-10 Tom Tromey <tromey@adacore.com>
7584
7585 * spu-tdep.c (spu_overlay_data): Change type.
7586 (spu_get_overlay_table, spu_overlay_new_objfile)
7587 (_initialize_spu_tdep): Update.
7588
22a20dca
TT		 75892019-07-10 Tom Tromey <tromey@adacore.com>
7590
7591 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7592 destructor.
7593 (dbx_objfile_data_key): Change type and declare later.
7594 (DBX_SYMFILE_INFO): Rewrite.
7595 * dbxread.c (dbx_objfile_data_key): Change type.
7596 (dbx_symfile_init): Update.
7597 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7598 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7599 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7600
cb60f420
TT		 76012019-07-10 Tom Tromey <tromey@adacore.com>
7602
7603 * jit.c (jit_program_space_key): Change type. Move lower.
7604 (get_jit_program_space_data): Update.
7605 (jit_program_space_data_cleanup): Remove.
7606 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7607 Update.
7608 (struct jit_program_space_data): Add initializers.
7609
51df2ae3
TT		 76102019-07-10 Tom Tromey <tromey@adacore.com>
7611
7612 * solib-darwin.c (struct darwin_info): Add initializers.
7613 (solib_darwin_pspace_data): Change type.
7614 (darwin_pspace_data_cleanup): Remove.
7615 (get_darwin_info, _initialize_darwin_solib): Update.
7616
18101a35
TT		 76172019-07-10 Tom Tromey <tromey@adacore.com>
7618
7619 * remote-sim.c (struct sim_inferior_data): Add initializers,
7620 constructor, and destructor.
7621 (sim_inferior_data_key): Change type. Move lower.
7622 (check_for_duplicate_sim_descriptor): Update.
7623 (get_sim_inferior_data): Use new. Update.
7624 (~sim_inferior_data_cleanup): Rename from
7625 sim_inferior_data_cleanup. Simplify.
7626 (gdbsim_close_inferior, simulator_command)
7627 (sim_command_completer, _initialize_remote_sim): Update.
7628 (next_pid, INITIAL_PID): Move earlier.
7629
05b08ac1
TT		 76302019-07-10 Tom Tromey <tromey@adacore.com>
7631
7632 * python/python-internal.h (create_thread_object): Return
7633 gdbpy_ref.
7634 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7635 * python/py-inferior.c (struct threadlist_entry): Add
7636 constructor.
7637 <thread_obj>: Now a gdbpy_ref.
7638 (thread_to_thread_object): Update.
7639 (add_thread_object): Use new.
7640 (delete_thread_object): Use delete.
7641 (infpy_threads): Update.
7642 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7643 GIL.
7644
32372d80
TT		 76452019-07-10 Tom Tromey <tromey@adacore.com>
7646
7647 * valops.c (value_cast): Specialize error message for Ada.
7648
5c458ae8
SM		 76492019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7650
7651 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7652
4c462cb0
SM		 76532019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7654
7655 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7656 bpstat_should_step): Return bool, adjust comments.
7657 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7658 bpstat_should_step): Likewise.
7659
89abbcc2
AH		 76602019-07-10 Alan Hayward <alan.hayward@arm.com>
7661
7662 * features/Makefile: Use feature target descriptions for Arm.
7663 * features/arm/arm-core.c: Generate new file.
7664 * features/arm/arm-fpa.c: Likewise.
7665 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7666 * features/arm/arm-m-profile.c: Likewise.
7667 * features/arm/arm-vfpv2.c: Likewise.
7668 * features/arm/arm-vfpv3.c: Likewise.
7669 * features/arm/xscale-iwmmxt.c: Likewise.
7670 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7671
166a82be
AH		 76722019-07-10 Alan Hayward <alan.hayward@arm.com>
7673
7674 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7675 ptrace earlier.
7676
9fb4c7e9
AH		 76772019-07-10 Alan Hayward <alan.hayward@arm.com>
7678
7679 * features/aarch64-pauth.c: Regenerate.
7680
e2d0f980
SM		 76812019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7682
7683 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7684 bool.
7685 (bpstat_what): Use false instead of 0.
7686
a38118e5
PA		 76872019-07-09 Pedro Alves <palves@redhat.com>
7688
7689 * break-catch-throw.c (is_exception_catchpoint): New.
7690 * breakpoint.c (print_one_breakpoint_location): New parameter
7691 'raw_loc'. Handle it. Use
7692 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7693 looking at the breakpoint's type.
7694 (print_one_breakpoint): If handling "maint info breakpoints", also
7695 print locations of exception catchpoints.
7696 * breakpoint.h (is_exception_catchpoint): Declare.
7697
cb1e4e32
PA		 76982019-07-09 Pedro Alves <palves@redhat.com>
7699
7700 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7701 "addr" field.
7702 (allocate_location_exception_catchpoint): New.
7703 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7704 (initialize_throw_catchpoint_ops): Install
7705 allocate_location_exception_catchpoint as allocate_location
7706 method.
7707 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7708 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7709 bp_loc_other.
7710 (breakpoint_address_is_meaningful): Delete.
7711 (bl_address_is_meaningful): New.
7712 (breakpoint_locations_match): Adjust comment.
7713 (bp_location_from_bp_type): New, factored out of...
7714 (bp_location::bp_location(breakpoint *)): ... this.
7715 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7716 factored out of...
7717 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7718 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7719 breakpoint_address_is_meaningful.
7720 (bp_locations_compare): Adjust comment.
7721 (update_global_location_list): Use bl_address_is_meaningful
7722 instead of breakpoint_address_is_meaningful.
7723 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7724 explicit.
7725 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7726 * python/py-breakpoint.c (bppy_get_location): No longer check
7727 whether location is null.
7728
b58a68fe
PA		 77292019-07-09 Pedro Alves <palves@redhat.com>
7730
7731 PR c++/15468
7732 * breakpoint.c (print_one_breakpoint_location): Remove
7733 single-location assert.
7734
268a13a5
TT		 77352019-07-09 Tom Tromey <tom@tromey.com>
7736
7737 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7738 * configure: Rebuild.
7739 * configure.ac: Change common to gdbsupport.
7740 * gdbsupport: Rename from common.
7741 * acinclude.m4: Change common to gdbsupport.
7742 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7743 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7744 gdbsupport.
7745 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7746 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7747 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7748 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7749 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7750 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7751 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7752 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7753 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7754 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7755 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7756 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7757 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7758 coff-pe-read.c, command.h, compile/compile-c-support.c,
7759 compile/compile-c.h, compile/compile-cplus-symbols.c,
7760 compile/compile-cplus-types.c, compile/compile-cplus.h,
7761 compile/compile-loc2c.c, compile/compile.c, completer.c,
7762 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7763 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7764 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7765 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7766 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7767 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7768 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7769 features/aarch64-core.c, features/aarch64-fpu.c,
7770 features/aarch64-pauth.c, features/aarch64-sve.c,
7771 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7772 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7773 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7774 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7775 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7776 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7777 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7778 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7779 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7780 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7781 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7782 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7783 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7784 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7785 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7786 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7787 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7788 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7789 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7790 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7791 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7792 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7793 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7794 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7795 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7796 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7797 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7798 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7799 minsyms.c, mips-linux-tdep.c, namespace.h,
7800 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7801 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7802 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7803 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7804 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7805 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7806 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7807 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7808 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7809 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7810 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7811 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7812 procfs.c, producer.c, progspace.h, psymtab.h,
7813 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7814 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7815 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7816 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7817 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7818 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7819 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7820 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7821 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7822 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7823 target-memory.c, target.c, target.h, target/waitstatus.c,
7824 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7825 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7826 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7827 unittests/array-view-selftests.c,
7828 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7829 unittests/common-utils-selftests.c,
7830 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7831 unittests/format_pieces-selftests.c,
7832 unittests/function-view-selftests.c,
7833 unittests/lookup_name_info-selftests.c,
7834 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7835 unittests/mkdir-recursive-selftests.c,
7836 unittests/observable-selftests.c,
7837 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7838 unittests/parse-connection-spec-selftests.c,
7839 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7840 unittests/scoped_fd-selftests.c,
7841 unittests/scoped_mmap-selftests.c,
7842 unittests/scoped_restore-selftests.c,
7843 unittests/string_view-selftests.c, unittests/style-selftests.c,
7844 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7845 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7846 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7847 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7848 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7849 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7850
5b0e2db4
AB		 78512019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7852
7853 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7854 bool value.
7855 (decode_digits_ordinary): Set explicit_line field in sal.
7856 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7857 symtab_and_line that was set on an explicit line number in
7858 assembler code. Do always update the recorded symtab and line if
7859 we do skip the prologue.
7860
0ba852ab
AB		 78612019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7862
7863 * breakpoint.c (set_breakpoint_location_function): Remove
7864 explicit_loc parameter.
7865 (momentary_breakpoint_from_master): Update call to
7866 set_breakpoint_location_function.
7867 (add_location_to_breakpoint): Likewise.
7868
b3a7d171
AB		 78692019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7870
7871 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7872 required features based on default bfd type when no specific bfd
7873 is present.
7874
1f6f6e21
PW		 78752019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7876
7877 * NEWS: Mention that GDB printf and eval commands can now print
7878 C-style and Ada-style convenience var strings without
7879 calling the inferior.
7880 * printcmd.c (printf_c_string): Locally print GDB internal var
7881 instead of transiting via the inferior.
7882 (printf_wide_c_string): Likewise.
7883
78842019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7885
5862c886 7886 PR breakpoints/25011
ea142fbf
AH		 7887 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7888
0598af48
TT		 78892019-07-04 Tom Tromey <tom@tromey.com>
7890
7891 PR tui/24724:
7892 * tui/tui-winsource.c (tui_clear_source_content): Update.
7893 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7894 (tui_update_breakpoint_info): Update.
7895 (tui_set_exec_info_content): Update.
7896 * tui/tui-source.c (tui_set_source_content_nil): Update.
7897 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7898 has_break.
7899 * tui/tui-data.h (enum tui_bp_flag): New.
7900 (tui_bp_flags): New enum flags type.
7901 (struct tui_source_element) <break_mode>: Change type. Rename
7902 from has_break.
7903 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7904 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7905 constants.
7906 * tui/tui-winsource.h: Fix comment.
7907
350fab54
AH		 79082019-07-04 Alan Hayward <alan.hayward@arm.com>
7909
7910 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7911 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7912 (store_fpregs_to_thread)
7913 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7914 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7915 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7916 (IWMMXT_REGS_SIZE): Add define.
7917 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7918 (fetch_vfp_regs, store_vfp_regs)
7919 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7920 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7921
f0452268
AH		 79222019-07-04 Alan Hayward <alan.hayward@arm.com>
7923
7924 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7925 defines.
7926 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7927 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7928 (ARM_INT_REGISTER_SIZE): ...to this.
7929 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7930 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7931 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7932 (arm_linux_collect_gregset, supply_nwfpe_register)
7933 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7934 defines.
7935 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7936 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7937 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7938 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7939 (arm_return_in_memory, arm_store_return_value)
7940 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7941 (arm_record_ld_st_multiple): Likewise.
7942 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7943 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7944
e935475c
AH		 79452019-07-04 Alan Hayward <alan.hayward@arm.com>
7946
7947 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7948 AARCH64_DISPLACED_MODIFIED_INSNS.
7949 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7950 (aarch64_displaced_step_copy_insn): Likewise.
7951 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7952 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7953 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7954 ARM_DISPLACED_MODIFIED_INSNS.
7955 * arm-tdep.c (arm_gdbarch_init): Likewise.
7956 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7957 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7958 (struct arm_displaced_step_closure): Use
7959 ARM_DISPLACED_MODIFIED_INSNS.
7960
df0bb381
AH		 79612019-07-04 Alan Hayward <alan.hayward@arm.com>
7962
7963 * features/Makefile: Remove unused xml files.
7964 * features/aarch64.xml: Remove.
7965 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7966 * features/i386/amd64-avx-avx512.xml: Remove.
7967 * features/i386/amd64-avx-linux.xml: Remove.
7968 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7969 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7970 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7971 * features/i386/amd64-avx-mpx.xml: Remove.
7972 * features/i386/amd64-avx.xml: Remove.
7973 * features/i386/amd64-linux.xml: Remove.
7974 * features/i386/amd64-mpx-linux.xml: Remove.
7975 * features/i386/amd64-mpx.xml: Remove.
7976 * features/i386/amd64.xml: Remove.
7977 * features/i386/i386-avx-avx512-linux.xml: Remove.
7978 * features/i386/i386-avx-avx512.xml: Remove.
7979 * features/i386/i386-avx-linux.xml: Remove.
7980 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7981 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7982 * features/i386/i386-avx-mpx-linux.xml: Remove.
7983 * features/i386/i386-avx-mpx.xml: Remove.
7984 * features/i386/i386-avx.xml: Remove.
7985 * features/i386/i386-linux.xml: Remove.
7986 * features/i386/i386-mmx-linux.xml: Remove.
7987 * features/i386/i386-mmx.xml: Remove.
7988 * features/i386/i386-mpx-linux.xml: Remove.
7989 * features/i386/i386-mpx.xml: Remove.
7990 * features/i386/i386.xml: Remove.
7991 * features/i386/x32-avx-avx512-linux.xml: Remove.
7992 * features/i386/x32-avx-linux.xml: Remove.
7993 * features/i386/x32-linux.xml: Remove.
7994
edd6266a
AH		 79952019-07-04 Alan Hayward <alan.hayward@arm.com>
7996
7997 * regformats/aarch64.dat: Remove.
7998 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7999 * regformats/i386/amd64-avx-linux.dat: Remove.
8000 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8001 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8002 * regformats/i386/amd64-linux.dat: Remove.
8003 * regformats/i386/amd64-mpx-linux.dat: Remove.
8004 * regformats/i386/amd64.dat: Remove.
8005 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8006 * regformats/i386/i386-avx-linux.dat: Remove.
8007 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8008 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8009 * regformats/i386/i386-linux.dat: Remove.
8010 * regformats/i386/i386-mmx-linux.dat: Remove.
8011 * regformats/i386/i386-mpx-linux.dat: Remove.
8012 * regformats/i386/i386.dat: Remove.
8013 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8014 * regformats/i386/x32-avx-linux.dat: Remove.
8015 * regformats/i386/x32-linux.dat: Remove.
8016
2b40fda7
AH		 80172019-07-04 Alan Hayward <alan.hayward@arm.com>
8018
8019 * aarch64-tdep.c: Remove xml self tests.
8020 * amd64-linux-tdep.c: Likewise.
8021 * amd64-tdep.c: Likewise.
8022 * i386-linux-tdep.c: Likewise.
8023 * i386-tdep.c: Likewise.
8024
5f4ba3e7
PA		 80252019-07-03 Pedro Alves <palves@redhat.com>
8026
8027 PR cli/24732
8028 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8029 (pipe_cmd_option_defs): New.
8030 (make_pipe_cmd_options_def_group): New.
8031 (pipe_command): Use gdb::option::process_options.
8032 (pipe_command_completer): New function.
8033 (_initialize_cli_cmds): Install completer for "pipe" command.
8034
3d9be6f5
PA		 80352019-07-03 Pedro Alves <palves@redhat.com>
8036
8037 * cli/cli-option.c (union option_value) <string>: New field.
8038 (struct option_def_and_value): Add ctor, move ctor, dtor and
8039 use DISABLE_COPY_AND_ASSIGN.
8040 (option_def_and_value::clear_value): New.
8041 (parse_option, save_option_value_in_ctx, get_val_type_str)
8042 (add_setshow_cmds_for_options): Handle var_string.
8043 * cli-option.h (union option_def::var_address) <string>: New
8044 field.
8045 (struct string_option_def): New.
8046 * maint-test-options.c (struct test_options_opts): Add default
8047 ctor and use DISABLE_COPY_AND_ASSIGN.
8048 <string_opt>: New field.
8049 (test_options_opts::~test_options_opts): New.
8050 (test_options_opts::dump): Also dump "-string".
8051 (test_options_option_defs): Install "string.
8052
41fc454c
PA		 80532019-07-03 Pedro Alves <palves@redhat.com>
8054
8055 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8056 option_value with a null enumeration.
8057 (complete_options): Save the option values in the context.
8058 (save_option_value_in_ctx): New, factored out from ...
8059 (process_options): ... here.
8060 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8061 of the function.
8062 * maint-test-options.c (test_options_opts::dump): New, factored
8063 out from ...
8064 (maintenance_test_options_command_mode): ... here.
8065 (maintenance_test_options_command_completion_result): Delete.
8066 (maintenance_test_options_command_completion_text): Update
8067 comment.
8068 (maintenance_show_test_options_completion_result): Change
8069 prototype. Just print
8070 maintenance_test_options_command_completion_text.
8071 (save_completion_result): New.
8072 (maintenance_test_options_completer_mode): Pass options context to
8073 complete_options, and then save a dump.
8074 (_initialize_maint_test_options): Use add_cmd to install "maint
8075 show test-options-completion-result".
8076
fdbc9870
PA		 80772019-07-03 Pedro Alves <palves@redhat.com>
8078
8079 * NEWS (New commands): Mention "with" and "maint with".
8080 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8081 (with_command, with_command_completer): New.
8082 (pipe_command): Adjust to new repeat_previous
8083 interface.
8084 (_initialize_cli_cmds): Install the "with" command and its "w"
8085 alias.
8086 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8087 declarations.
8088 * cli/cli-setshow.c (parse_cli_var_uinteger)
8089 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8090 argument strings for all var_types.
8091 (get_setshow_command_value_string): New, factored out from ...
8092 (do_show_command): ... this.
8093 * cli/cli-setshow.h: Include <string>.
8094 (get_setshow_command_value_string): Declare.
8095 * command.h (repeat_previous): Now returns const char *. Adjust
8096 comment.
8097 * maint.c: Include "cli/cli-cmds.h".
8098 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8099 (_initialize_maint_cmds): Register the "maintenance with" command.
8100 * top.c (repeat_previous): Move bits from pipe_command here:
8101 Return the saved command line, if any; error out if there's no
8102 command to relaunch.
8103
c6ac8931
PA		 81042019-07-03 Pedro Alves <palves@redhat.com>
8105
8106 * NEWS (New commands): Mention "maint set/show test-settings"
8107 instead of "maint test-settings".
8108 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8109 (maintenance_test_settings_set_list): Rename to ...
8110 (maintenance_set_test_settings_list): ... this.
8111 (maintenance_test_settings_show_list): Rename to ...
8112 (maintenance_show_test_settings_list): ... this.
8113 (maintenance_test_settings_cmd): Delete.
8114 (maintenance_test_settings_set_cmd): ...
8115 (maintenance_set_test_settings_cmd): ... this.
8116 (maintenance_test_settings_show_cmd): ...
8117 (maintenance_show_test_settings_cmd): ... this.
8118 (maintenance_test_settings_show_value_cmd):
8119 (maintenance_show_test_settings_value_cmd): ... this.
8120 (_initialize_maint_test_settings): No longer install the "maint
8121 test-settings" prefix command. Rename "maint test-settings set"
8122 to "maint set test-settings", and "maint test-settings show" to
8123 "maint show test-settings". Adjust all subcommands.
8124
d1fcf2fd
PA		 81252019-07-03 Pedro Alves <palves@redhat.com>
8126
8127 * maint-test-settings.c: Fix file's intro comment. Replace all
8128 references to "test-options" with references to "test-settings",
8129 in comments.
8130
970f9d09
PA		 81312019-07-03 Pedro Alves <palves@redhat.com>
8132
8133 * maint-test-settings.c (maintenance_test_settings_xxx)
8134 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8135 New.
8136 (maintenance_test_settings_enums): Use them.
8137 (maintenance_test_settings_enum): Default to
8138 maintenance_test_settings_xxx.
8139 (_initialize_maint_test_settings): Initialize
8140 MAINTENANCE_TEST_SETTINGS_FILENAME.
8141
f3869b1a
SM		 81422019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8143
8144 * breakpoint.h (remove_breakpoints_inf): Change return type to
8145 void, move function documentation here.
8146 * breakpoint.c (remove_breakpoints_inf): Change return type to
8147 void, move function documentation to header.
8148
54d66006
PA		 81492019-07-02 Pedro Alves <palves@redhat.com>
8150
8151 * NEWS (Completion improvements): Mention "info threads".
8152 * thread.c (struct info_threads_opts, info_threads_option_defs)
8153 (make_info_threads_options_def_group): New.
8154 (info_threads_command): Use gdb::option::process_options.
8155 (info_threads_command_completer): New.
8156 (_initialize_thread): Use gdb::option::build_help to build the
8157 help text for "info threads".
8158
854f6088
SM		 81592019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8160
8161 * defs.h (generic_load): Move from here...
8162 * symfile.h (generic_load): ... to here. Rename name parameter
8163 to args.
8164 * symfile.c (generic_load): Add comment.
8165
54ee4252
TT		 81662019-07-01 Tom Tromey <tromey@adacore.com>
8167
8168 * dwarf2read.c
8169 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8170 declaration of without_params. Fix formatting.
8171
65392b3e
TT		 81722019-07-01 Tom Tromey <tromey@adacore.com>
8173
8174 * ada-exp.y (find_primitive_type): Update.
8175 * ada-lang.h (ada_lookup_symbol): Update.
8176 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8177 parameter.
8178 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8179
7d7571f0
SDJ		 81802019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8181
8182 PR breakpoints/24541
8183 * gdbarch.c: Regenerate.
8184 * gdbarch.h: Regenerate.
8185 * gdbarch.sh: Add 'stap_adjust_register'.
8186 * i386-tdep.c: Include '<unordered_set>'.
8187 (i386_stap_adjust_register): New function.
8188 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8189 * stap-probe.c (stap_parse_register_operand): Call
8190 'gdbarch_stap_adjust_register'.
8191
5af5392a
SDJ		 81922019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8193
8194 PR python/24742
8195 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8196 * python/python.c (do_start_initialization): Use 'xmalloc'
8197 instead of 'PyMem_Malloc'.
8198
10d06d82
TT		 81992019-06-28 Tom Tromey <tromey@adacore.com>
8200
8201 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8202 for Ada.
8203
1b7f24cd
TT		 82042019-06-27 Tom Tromey <tromey@adacore.com>
8205
8206 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8207 objfile_key.
8208 (arm_find_mapping_symbol, arm_record_special_symbol)
8209 (_initialize_arm_tdep): Update.
8210 (arm_objfile_data_free): Remove.
8211
3d507ff2
TT		 82122019-06-27 Tom Tromey <tromey@adacore.com>
8213
8214 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8215 to cp_print_static_field.
8216
762c164d
TT		 82172019-06-26 Tom Tromey <tromey@adacore.com>
8218
8219 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8220 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8221 declare.
8222
aa2f9bcf
AH		 82232019-06-26 Alan Hayward <alan.hayward@arm.com>
8224
8225 * features/aarch64-core.c (create_feature_aarch64_core):
8226 Regenerate.
8227 * features/aarch64-core.xml: Add cpsr flags.
8228
3426ae57
AH		 82292019-06-26 Alan Hayward <alan.hayward@arm.com>
8230
8231 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8232 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8233
4838e44c
SM		 82342019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8235
8236 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8237 field.
8238 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8239 use.
8240 (arm_record_special_symbol): Don't insert new symbol in sorted
8241 position, push it at the end.
8242
54cc7474
SM		 82432019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8244
8245 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8246 (arm_mapping_symbol_s): Remove.
8247 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8248 (arm_mapping_symbol_vec): New typedef.
8249 (struct arm_per_objfile): Add constructor.
8250 <section_maps>: Change type to
8251 std::unique_ptr<arm_mapping_symbol_vec[]>.
8252 (arm_compare_mapping_symbols): Remove.
8253 (arm_find_mapping_symbol): Adjust to section_maps type change.
8254 (arm_objfile_data_free): Call delete on arm_per_objfile.
8255 (arm_record_special_symbol): Adjust to section_maps type change.
8256 Allocate arm_per_objfile with new.
8257
b65b566c
PW		 82582019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8259
8260 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8261 with the command prefix.
8262
c2fc64f5
TT		 82632019-06-25 Tom Tromey <tom@tromey.com>
8264
8265 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8266 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8267
fb54fa76
TT		 82682019-06-25 Tom Tromey <tom@tromey.com>
8269
8270 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8271 type.
8272 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8273 protected.
8274
f7952c57
TT		 82752019-06-25 Tom Tromey <tom@tromey.com>
8276
8277 * tui/tui-winsource.c
8278 (tui_source_window_base::set_is_exec_point_at): Add check against
8279 LOA_ADDRESS.
8280
17568d78
TT		 82812019-06-25 Tom Tromey <tom@tromey.com>
8282
8283 * tui/tui-source.c (tui_set_source_content): Don't check before
8284 xfree.
8285 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8286
53e7cdba
TT		 82872019-06-25 Tom Tromey <tom@tromey.com>
8288
8289 * tui/tui-winsource.h (tui_update_source_window_as_is)
8290 (tui_alloc_source_buffer, tui_line_is_displayed)
8291 (tui_addr_is_displayed): Change type of win_info.
8292 * tui/tui-winsource.c (tui_update_source_window_as_is)
8293 (tui_clear_source_content, tui_show_source_line)
8294 (tui_show_source_content, tui_source_window_base::refill)
8295 (tui_source_window_base::set_is_exec_point_at)
8296 (tui_source_window_base::set_is_exec_point_at)
8297 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8298 (tui_alloc_source_buffer, tui_line_is_displayed)
8299 (tui_addr_is_displayed): Change type of win_info. Update.
8300 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8301 (tui_source_window_base::do_make_visible_with_new_height):
8302 Update.
8303 * tui/tui-source.c (tui_set_source_content)
8304 (tui_set_source_content_nil)
8305 (tui_source_window::do_scroll_vertical): Update.
8306 * tui/tui-layout.c (show_layout): Update.
8307 * tui/tui-disasm.c (tui_set_disassem_content)
8308 (tui_disasm_window::do_scroll_vertical): Update.
8309 * tui/tui-data.h (tui_win_content): Remove.
8310 (struct tui_gen_win_info) <content, content_size>: Remove.
8311 (struct tui_source_element): Add initializers and destructor.
8312 (union tui_which_element, struct tui_win_element): Remove.
8313 (struct tui_source_window_base) <content>: New field.
8314 (struct tui_data_window): Remove destructor.
8315 (tui_alloc_content, tui_free_win_content)
8316 (tui_free_all_source_wins_content): Don't declare.
8317 * tui/tui-data.c (tui_initialize_static_data): Update.
8318 (init_content_element, tui_alloc_content): Remove.
8319 (~tui_gen_win_info): Update.
8320 (~tui_data_window, tui_free_all_source_wins_content)
8321 (tui_free_win_content, free_content, free_content_elements):
8322 Remove.
8323
7908abbf
TT		 83242019-06-25 Tom Tromey <tom@tromey.com>
8325
8326 * tui/tui-winsource.h (tui_clear_source_content)
8327 (tui_erase_source_content, tui_show_source_content): Change type
8328 of win_info.
8329 * tui/tui-winsource.c (tui_clear_source_content)
8330 (tui_erase_source_content, tui_show_source_content): Change type
8331 of win_info.
8332 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8333 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8334 win_info.
8335 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8336 win_info.
8337 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8338
02c28df0
TT		 83392019-06-25 Tom Tromey <tom@tromey.com>
8340
8341 * tui/tui-winsource.c (tui_clear_source_content)
8342 (tui_source_window_base::set_is_exec_point_at): Update.
8343 * tui/tui-source.c (tui_set_source_content_nil): Update.
8344 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8345 a bool.
8346 * tui/tui-data.c (init_content_element): Update.
8347
6658b1bf
TT		 83482019-06-25 Tom Tromey <tom@tromey.com>
8349
8350 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8351 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8352 * tui/tui-layout.c (init_and_make_win): Update.
8353 * tui/tui.h (enum tui_win_type): Update.
8354 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8355 tui_win_is_auxillary.
8356 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8357 tui_win_is_auxillary.
8358
21e1c91e
TT		 83592019-06-25 Tom Tromey <tom@tromey.com>
8360
8361 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8362 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8363 (tui_delete_data_content_windows, tui_display_all_data)
8364 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8365 Update.
8366 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8367 * tui/tui-regs.c (tui_last_regs_line_no)
8368 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8369 (tui_show_registers): Update.
8370 (tui_show_register_group): Return void. Update.
8371 (tui_display_registers_from, tui_display_reg_element_at_line)
8372 (tui_display_registers_from_line, tui_check_register_values):
8373 Update.
8374 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8375 member.
8376 (struct tui_data_window) <regs_content>: Now a std::vector.
8377 <regs_content_count>: Remove.
8378 (tui_add_content_elements, tui_free_data_content): Don't declare.
8379 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8380 (init_content_element): Remove DATA_WIN case. Add assert.
8381 (tui_add_content_elements): Remove.
8382 (tui_data_window): Update.
8383 (tui_free_data_content): Remove.
8384 (free_content_elements): Remove DATA_WIN case.
8385
115ac53b
TT		 83862019-06-25 Tom Tromey <tom@tromey.com>
8387
8388 * tui/tui-data.c (tui_data_item_window): Update.
8389 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8390 * tui/tui-windata.c (tui_display_all_data)
8391 (tui_display_data_from_line): Update.
8392 (tui_check_data_values): Remove.
8393 * tui/tui-regs.c (tui_show_register_group)
8394 (tui_display_reg_element_at_line): Update.
8395 * tui/tui-hooks.c (tui_register_changed)
8396 (tui_refresh_frame_and_register_information): Call
8397 tui_check_register_values.
8398 * tui/tui-data.h (struct tui_data_window) <data_content,
8399 data_content_count, data_type>: Remove.
8400 (enum tui_data_type): Remove.
8401
8402 * tui/tui-data.c (tui_data_window::clear_detail)
8403 (~tui_data_window): Update.
8404
eaf9738b
TT		 84052019-06-25 Tom Tromey <tom@tromey.com>
8406
8407 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8408 declare.
8409 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8410 Rename from tui_first_data_item_displayed. Update.
8411 (tui_data_window::refresh_all)
8412 (tui_data_window::do_scroll_vertical): Update.
8413 * tui/tui-data.h (struct tui_data_window)
8414 <first_data_item_displayed>: Declare new method.
8415
31ca4723
TT		 84162019-06-25 Tom Tromey <tom@tromey.com>
8417
8418 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8419 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8420 contents...
8421 (tui_initialize_static_data): ...here.
8422
41bcff7f
TT		 84232019-06-25 Tom Tromey <tom@tromey.com>
8424
8425 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8426 (tui_display_registers_from, tui_check_register_values): Update.
8427 (tui_display_register): Remove win_info parameter; update.
8428 (tui_get_register): Change type of parameters.
8429 * tui/tui-data.h (struct tui_data_element): Remove.
8430 (union tui_which_element) <data>: Remove.
8431 <data_window>: Change type.
8432 (struct tui_data_item_window): New.
8433 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8434 case. Add assert.
8435 (~tui_data_item_window): New destructor.
8436 (free_content_elements): Remove DATA_ITEM_WIN case.
8437
d2802c33
TT		 84382019-06-25 Tom Tromey <tom@tromey.com>
8439
8440 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8441 Remove.
8442
dd835f8b
TT		 84432019-06-25 Tom Tromey <tom@tromey.com>
8444
8445 * tui/tui-data.h (struct tui_command_element): Remove.
8446 (union tui_which_element) <command>: Remove.
8447 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8448 assert.
8449 (free_content_elements): Remove CMD_WIN case.
8450
bd7db367
TT		 84512019-06-25 Tom Tromey <tom@tromey.com>
8452
8453 * tui/tui-layout.c (tui_set_layout): Update.
8454 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8455 * tui/tui-data.c (layout_def): Update.
8456
3add462f
TT		 84572019-06-25 Tom Tromey <tom@tromey.com>
8458
8459 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8460 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8461 (tui_source_window_base::set_new_height): Update.
8462 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8463 Update.
8464 (tui_set_locator_fullname, tui_set_locator_info)
8465 (tui_show_frame_info): Update.
8466 * tui/tui-source.c (tui_set_source_content)
8467 (tui_source_is_displayed): Update.
8468 * tui/tui-layout.c (show_source_disasm_command, show_data)
8469 (show_source_or_disasm_and_command): Update.
8470 * tui/tui-disasm.c (tui_set_disassem_content)
8471 (tui_get_begin_asm_address): Update.
8472 * tui/tui-data.h (struct tui_locator_element): Remove.
8473 (union tui_which_element) <locator>: Remove.
8474 (struct tui_locator_window): New.
8475 (tui_locator_win_info_ptr): Change return type.
8476 * tui/tui-data.c (_locator): Change type.
8477 (tui_locator_win_info_ptr): Change return type.
8478 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8479 (tui_alloc_content): Add assert.
8480
489e9d8b
TT		 84812019-06-25 Tom Tromey <tom@tromey.com>
8482
8483 * tui/tui-winsource.c
8484 (tui_exec_info_window::maybe_allocate_content): New method.
8485 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8486 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8487 (make_source_or_disasm_window): Add cast.
8488 * tui/tui-data.h (union tui_which_element) <simple_string>:
8489 Remove.
8490 (struct tui_source_info): New.
8491 (struct tui_source_window_base) <execution_info>: Change type.
8492 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8493 case, and add assert.
8494 (tui_alloc_content): Add assert.
8495
c3fabb7d
TT		 84962019-06-25 Tom Tromey <tom@tromey.com>
8497
8498 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8499 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8500 * tui/tui-data.c (tui_alloc_win_info): Remove.
8501
bbc228ee
TT		 85022019-06-25 Tom Tromey <tom@tromey.com>
8503
8504 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8505 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8506 can_highlight.
8507
5fcee43a
TT		 85082019-06-25 Tom Tromey <tom@tromey.com>
8509
8510 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8511 make_visible_with_new_height method.
8512 (tui_win_info::make_visible_with_new_height): New method.
8513 (tui_source_window_base::do_make_visible_with_new_height)
8514 (tui_data_window::do_make_visible_with_new_height)
8515 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8516 (make_visible_with_new_height): Remove.
8517 (tui_resize_all, tui_adjust_win_heights): Use
8518 make_visible_with_new_height method.
8519 * tui/tui-data.h (struct tui_win_info)
8520 <do_make_visible_with_new_height, make_visible_with_new_height>:
8521 New methods.
8522 (struct tui_source_window_base, struct tui_data_window)
8523 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8524 methods.
8525
d83f1fe6
TT		 85262019-06-25 Tom Tromey <tom@tromey.com>
8527
8528 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8529 method.
8530 (update_tab_width): Call update_tab_width method.
8531 * tui/tui-data.h (struct tui_win_info)
8532 (struct tui_source_window_base) <update_tab_width>: New methods.
8533
17374de4
TT		 85342019-06-25 Tom Tromey <tom@tromey.com>
8535
8536 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8537 parameter.
8538 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8539 parameter.
8540 (tui_gen_win_info::make_visible): Update.
8541 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8542 parameter.
8543 * tui/tui-data.h (enum tui_box): New enum.
8544 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8545
f936bca2
TT		 85462019-06-25 Tom Tromey <tom@tromey.com>
8547
8548 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8549 init_and_make_win for EXEC_INFO_WIN.
8550 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8551 longer inline.
8552 (struct tui_win_info) <~tui_win_info>: Inline.
8553 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8554 Don't declare.
8555 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8556 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8557 Remove.
8558 (tui_initialize_static_data): Update.
8559 (~tui_gen_win_info): Handle more cleanup here.
8560 (~tui_source_window_base): Delete "execution_info".
8561 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8562
d6ba6a11
TT		 85632019-06-25 Tom Tromey <tom@tromey.com>
8564
8565 * tui/tui-layout.c (make_command_window): Don't set
8566 can_highlight.
8567 (show_source_disasm_command): Call the reset method.
8568 (show_data): Don't set can_highlight. Call the reset method.
8569 (tui_gen_win_info::reset): Rename from init_gen_win_info
8570 (init_and_make_win): Simplify. Return tui_gen_win_info.
8571 (show_source_or_disasm_and_command): Call the reset method.
8572 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8573 (struct tui_cmd_window): Set can_highlight.
8574
48a3bd16
TT		 85752019-06-25 Tom Tromey <tom@tromey.com>
8576
8577 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8578 from make_visible.
8579 (tui_make_visible, tui_make_invisible): Rewrite.
8580 (tui_win_info::make_visible): Remove.
8581 (tui_source_window_base::make_visible): Update.
8582 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8583 method. Moved from...
8584 (struct tui_win_info) <make_visible>: ...here.
8585
c3bd716f
TT		 85862019-06-25 Tom Tromey <tom@tromey.com>
8587
8588 * tui/tui-winsource.c
8589 (tui_source_window_base::do_scroll_horizontal): Remove direction
8590 parameter.
8591 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8592 direction parameter.
8593 * tui/tui-win.c (tui_win_info::forward_scroll)
8594 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8595 (tui_win_info::right_scroll): Update.
8596 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8597 direction parameter.
8598 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8599 direction parameter.
8600 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8601 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8602 Remove direction parameter.
8603 (struct tui_source_window_base, struct tui_source_window)
8604 (struct tui_disasm_window, struct tui_data_window)
8605 (struct tui_cmd_window): Update.
8606
21c32dca
TT		 86072019-06-25 Tom Tromey <tom@tromey.com>
8608
8609 * tui/tui-winsource.h (tui_set_exec_info_content)
8610 (tui_show_exec_info_content, tui_erase_exec_info_content)
8611 (tui_clear_exec_info_content, tui_update_exec_info): Change
8612 argument to tui_source_window_base.
8613 * tui/tui-winsource.c (tui_set_exec_info_content)
8614 (tui_show_exec_info_content, tui_erase_exec_info_content)
8615 (tui_clear_exec_info_content, tui_update_exec_info): Change
8616 argument to tui_source_window_base.
8617
73fbdc65
TT		 86182019-06-25 Tom Tromey <tom@tromey.com>
8619
8620 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8621 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8622
33325343
TT		 86232019-06-25 Tom Tromey <tom@tromey.com>
8624
8625 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8626 check.
8627
29d2c474
TT		 86282019-06-25 Tom Tromey <tom@tromey.com>
8629
8630 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8631 type to void.
8632 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8633 type to void.
8634 * tui/tui-source.c (tui_set_source_content): Update.
8635 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8636
152f3f4b
TT		 86372019-06-25 Tom Tromey <tom@tromey.com>
8638
8639 * tui/tui-win.c (window_name_completer, tui_set_focus)
8640 (tui_all_windows_info): Use name method.
8641 * tui/tui-data.h (struct tui_gen_win_info)
8642 (struct tui_source_window, struct tui_disasm_window)
8643 (struct tui_data_window, struct tui_cmd_window) <name>: New
8644 method.
8645 (tui_win_name): Don't declare.
8646 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8647 (tui_win_name): Remove.
8648
be4da588
TT		 86492019-06-25 Tom Tromey <tom@tromey.com>
8650
8651 * tui/tui-winsource.h (tui_update_source_window)
8652 (tui_update_source_window_as_is): Change parameter type.
8653 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8654 to be a tui_source_window_base.
8655 (tui_update_source_window_as_is): Likewise.
8656 * tui/tui-win.c (make_visible_with_new_height): Update.
8657
5b81daba
TT		 86582019-06-25 Tom Tromey <tom@tromey.com>
8659
8660 * tui/tui-winsource.c (tui_erase_source_content)
8661 (tui_show_source_content, tui_show_exec_info_content)
8662 (tui_erase_exec_info_content): Use refresh_window method.
8663 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8664 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8665 from tui_refresh_win.
8666 (tui_data_window::refresh_window): New method.
8667 (tui_win_info::refresh, tui_source_window_base::refresh)
8668 (tui_refresh_all): Use refresh_window method.
8669 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8670 method.
8671 * tui/tui-regs.c (tui_display_register): Call refresh_window
8672 method.
8673 * tui/tui-layout.c (show_source_disasm_command)
8674 (show_source_or_disasm_and_command): Call refresh_window method.
8675 * tui/tui-data.h (struct tui_gen_win_info)
8676 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8677 New method.
8678
cb2ce893
TT		 86792019-06-25 Tom Tromey <tom@tromey.com>
8680
8681 * tui/tui.c (tui_rl_other_window, tui_enable)
8682 (tui_is_window_visible, tui_get_command_dimension): Update.
8683 * tui/tui-winsource.c (tui_update_source_window_as_is)
8684 (tui_clear_source_content, tui_erase_source_content)
8685 (tui_show_source_line, tui_source_window_base::refill)
8686 (tui_source_window_base::do_scroll_horizontal)
8687 (tui_source_window_base::set_is_exec_point_at)
8688 (tui_update_breakpoint_info, tui_set_exec_info_content)
8689 (tui_alloc_source_buffer, tui_line_is_displayed)
8690 (tui_addr_is_displayed): Update.
8691 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8692 (tui_check_and_display_highlight_if_needed)
8693 (tui_win_info::make_visible, tui_win_info::refresh)
8694 (tui_refresh_all): Update.
8695 * tui/tui-windata.c (tui_first_data_item_displayed)
8696 (tui_delete_data_content_windows, tui_erase_data_content)
8697 (tui_display_all_data, tui_data_window::refresh_all)
8698 (tui_check_data_values): Update.
8699 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8700 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8701 (tui_win_info::backward_scroll, tui_refresh_all_win)
8702 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8703 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8704 (tui_source_window_base::set_new_height)
8705 (tui_data_window::set_new_height)
8706 (make_invisible_and_set_new_height)
8707 (make_visible_with_new_height, new_height_ok)
8708 (parse_scrolling_args): Update.
8709 * tui/tui-stack.c (tui_show_frame_info): Update.
8710 * tui/tui-source.c (tui_set_source_content)
8711 (tui_set_source_content_nil, tui_source_is_displayed)
8712 (tui_source_window::do_scroll_vertical): Update.
8713 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8714 (tui_display_registers_from, tui_display_reg_element_at_line)
8715 (tui_check_register_values, tui_reg_command): Update.
8716 * tui/tui-layout.c (tui_default_win_height)
8717 (show_source_disasm_command, show_data, init_and_make_win)
8718 (show_source_or_disasm_and_command): Update.
8719 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8720 (tui_redisplay_readline, tui_mld_flush)
8721 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8722 (tui_getc): Update.
8723 * tui/tui-disasm.c (tui_set_disassem_content)
8724 (tui_disasm_window::do_scroll_vertical): Update.
8725 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8726 Now virtual.
8727 (struct tui_win_info): Derive from tui_gen_win_info.
8728 <~tui_win_info>: Mark as override.
8729 <generic>: Remove member.
8730 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8731 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8732 (~tui_data_window, ~tui_win_info)
8733 (tui_free_all_source_wins_content): Update.
8734 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8735
ab313b35
TT		 87362019-06-25 Tom Tromey <tom@tromey.com>
8737
8738 * tui/tui-layout.c (init_and_make_win): Use new.
8739 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8740 destructor, initializers.
8741 (tui_alloc_generic_win_info): Don't declare.
8742 * tui/tui-data.c (_locator): Add argument to constructor.
8743 (source_win, disasm_win): New globals.
8744 (exec_info): Remove.
8745 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8746 Update.
8747 (tui_alloc_generic_win_info): Remove.
8748 (init_content_element): Use new.
8749 (tui_win_info::tui_win_info): Update.
8750 (free_content_elements) <case DATA_WIN>: Use delete.
8751
dc2c33e4
TT		 87522019-06-25 Tom Tromey <tom@tromey.com>
8753
8754 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8755 * tui/tui-windata.c (tui_first_data_item_displayed)
8756 (tui_delete_data_content_windows): Update.
8757 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8758 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8759 (tui_display_registers_from, tui_check_register_values): Update.
8760 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8761 pointer.
8762 * tui/tui-data.c (init_content_element): Update. Allocate the new
8763 window.
8764 (tui_free_data_content): Update.
8765 (free_content_elements) <case DATA_WIN>: Free the window.
8766
214a5cbe
TT		 87672019-06-25 Tom Tromey <tom@tromey.com>
8768
8769 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8770 Update.
8771 * tui/tui-layout.c (make_command_window)
8772 (show_source_disasm_command, show_data, init_and_make_win)
8773 (show_source_or_disasm_and_command): Update.
8774 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8775 method.
8776 <can_highight, is_highlighted>: Now bool.
8777 (tui_set_win_highlight): Don't declare.
8778 * tui/tui-data.c (tui_set_win_highlight): Remove.
8779
8e2daf15
TT		 87802019-06-25 Tom Tromey <tom@tromey.com>
8781
8782 * tui/tui-wingeneral.c (make_visible): Remove check of window
8783 type.
8784
8903bd8a
TT		 87852019-06-25 Tom Tromey <tom@tromey.com>
8786
8787 * tui/tui-win.c (tui_win_info::max_height)
8788 (tui_cmd_window::max_height): New methods.
8789 (new_height_ok): Call max_height.
8790 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8791 <max_height>: New method.
8792
3f02ce1e
TT		 87932019-06-25 Tom Tromey <tom@tromey.com>
8794
8795 * tui/tui-win.c (tui_source_window_base::set_new_height)
8796 (tui_data_window::set_new_height): New methods.
8797 (make_invisible_and_set_new_height): Call set_new_height method.
8798 * tui/tui-data.h (struct tui_win_info)
8799 (struct tui_source_window_base, struct tui_data_window)
8800 <set_new_height>: New method.
8801
1825f487
TT		 88022019-06-25 Tom Tromey <tom@tromey.com>
8803
8804 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8805 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8806 tui_refresh_data_win.
8807 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8808 method.
8809 (tui_refresh_all_win): Call the refresh_all method.
8810 (tui_set_focus): Likewise.
8811 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8812 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8813 Likewise.
8814
ad54d15b
TT		 88152019-06-25 Tom Tromey <tom@tromey.com>
8816
8817 * tui/tui-winsource.h (tui_refill_source_window)
8818 (tui_set_is_exec_point_at): Don't declare.
8819 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8820 (tui_source_window_base::refill): Rename from
8821 tui_refill_source_window.
8822 (tui_source_window_base::do_scroll_horizontal): Update.
8823 (tui_source_window_base::set_is_exec_point_at): Rename from
8824 tui_set_is_exec_point_at.
8825 (tui_update_all_breakpoint_info): Update.
8826 * tui/tui-stack.c (tui_show_frame_info): Update.
8827 * tui/tui-layout.c (show_data): Add cast.
8828 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8829 * tui/tui-data.h (struct tui_source_window_base) <refill,
8830 set_is_exec_point_at>: New methods.
8831 (tui_source_windows, tui_add_to_source_windows): Update types.
8832 (tui_add_to_source_windows): Remove redundant declaration.
8833 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8834 (tui_source_windows): Change return type.
8835 (tui_clear_source_windows_detail): Update.
8836 (tui_add_to_source_windows): Change type of parameter.
8837 (tui_free_all_source_wins_content): Update.
8838
2042b506
TT		 88392019-06-25 Tom Tromey <tom@tromey.com>
8840
8841 * tui/tui-wingeneral.c (tui_win_info::refresh)
8842 (tui_source_window_base::refresh): New methods.
8843 (tui_refresh_all): Call the refresh method.
8844 * tui/tui-data.h (struct tui_win_info)
8845 (struct tui_source_window_base) <refresh>: New method.
8846
56122977
TT		 88472019-06-25 Tom Tromey <tom@tromey.com>
8848
8849 * tui/tui.h (tui_is_window_visible): Return bool.
8850 * tui/tui.c (tui_is_window_visible): Return bool.
8851 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8852 (tui_make_visible, tui_make_invisible)
8853 (tui_win_info::make_visible)
8854 (tui_source_window_base::make_visible, make_all_visible)
8855 (tui_make_all_visible, tui_make_all_invisible): Update.
8856 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8857 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8858 bool.
8859 (struct tui_win_info, struct tui_source_window_base)
8860 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8861 * tui/tui-data.c (tui_init_generic_part): Update.
8862
cda37efb
TT		 88632019-06-25 Tom Tromey <tom@tromey.com>
8864
8865 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8866 (tui_source_window_base::make_visible): New methods.
8867 (make_all_visible): Make method call.
8868 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8869 (struct tui_source_window_base, struct tui_cmd_window): Override
8870 make_visible.
8871 (tui_win_is_source_type): Don't declare.
8872 * tui/tui-data.c (tui_win_is_source_type): Remove.
8873
6a0ee02c
TT		 88742019-06-25 Tom Tromey <tom@tromey.com>
8875
8876 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8877 NULL check.
8878
63901aec
TT		 88792019-06-25 Tom Tromey <tom@tromey.com>
8880
8881 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8882 Inline constructor. Add initializers for members.
8883 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8884 constructors; now inline in class.
8885
ceb13a13
TT		 88862019-06-25 Tom Tromey <tom@tromey.com>
8887
8888 * tui/tui-regs.c (tui_show_registers): Update.
8889 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8890 bool.
8891 * tui/tui-data.c (tui_data_window::clear_detail)
8892 (tui_data_window): Update.
8893
238eb706
TT		 88942019-06-25 Tom Tromey <tom@tromey.com>
8895
8896 * tui/tui-windata.c (tui_display_all_data)
8897 (tui_display_data_from_line, tui_display_data_from)
8898 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8899 Update.
8900 * tui/tui-regs.c (tui_last_regs_line_no)
8901 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8902 (tui_show_registers, tui_show_register_group)
8903 (tui_display_registers_from, tui_display_reg_element_at_line)
8904 (tui_display_registers_from_line, tui_check_register_values)
8905 (tui_reg_next, tui_reg_prev): Update.
8906 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8907 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8908 tui_data_window.
8909 (struct tui_win_info) <detail>: Remove. Add new fields from
8910 tui_data_info.
8911 (TUI_DATA_WIN): Add cast.
8912 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8913 (~tui_data_window): Simplify.
8914
81491aa0
TT		 89152019-06-25 Tom Tromey <tom@tromey.com>
8916
8917 * tui/tui-layout.c (show_source_disasm_command)
8918 (show_source_or_disasm_and_command): Update.
8919 * tui/tui-io.c (update_cmdwin_start_line)
8920 (tui_redisplay_readline): Update.
8921 * tui/tui-data.h (struct tui_command_info): Remove.
8922 (struct tui_win_info) <detail>: Remove command_info member.
8923 (struct tui_data_window) <start_line>: New member, from
8924 tui_command_info.
8925 (TUI_CMD_WIN): Add casts.
8926
e6e41501
TT		 89272019-06-25 Tom Tromey <tom@tromey.com>
8928
8929 * tui/tui-winsource.c (tui_update_source_window)
8930 (tui_refill_source_window)
8931 (tui_source_window_base::do_scroll_horizontal)
8932 (tui_update_breakpoint_info, tui_set_exec_info_content)
8933 (tui_show_exec_info_content, tui_erase_exec_info_content)
8934 (tui_clear_exec_info_content): Update.
8935 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8936 Update.
8937 * tui/tui-win.c (make_invisible_and_set_new_height)
8938 (make_visible_with_new_height): Update.
8939 * tui/tui-source.c (tui_set_source_content)
8940 (tui_show_symtab_source): Update.
8941 * tui/tui-layout.c (extract_display_start_addr)
8942 (show_source_disasm_command, show_data)
8943 (make_source_or_disasm_window)
8944 (show_source_or_disasm_and_command): Update.
8945 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8946 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8947 "gdbarch".
8948 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8949 to tui_source_window_base.
8950 (struct tui_win_info) <detail>: Remove source_info member.
8951 (struct tui_source_window_base) <has_locator>: Inline.
8952 Move contents from tui_source_info; rename has_locator member to
8953 m_has_locator.
8954 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8955 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8956 header file.
8957 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8958 Simplify.
8959 (tui_free_all_source_wins_content): Cast to
8960 tui_source_window_base.
8961
44f0e208
TT		 89622019-06-25 Tom Tromey <tom@tromey.com>
8963
8964 * tui/tui-win.c (make_invisible_and_set_new_height)
8965 (make_visible_with_new_height): Call has_locator method.
8966 * tui/tui-layout.c (show_source_disasm_command, show_data)
8967 (show_source_or_disasm_and_command): Update for bool change.
8968 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8969 (tui_win_info) <has_locator>: New method.
8970 (struct tui_source_window_base) <has_locator>: New method.
8971 (tui_win_has_locator): Don't declare.
8972 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8973 from tui_win_has_locator.
8974 (tui_source_window_base): Use false, not FALSE.
8975
7778b912
TT		 89762019-06-25 Tom Tromey <tom@tromey.com>
8977
8978 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8979 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8980 clear_detail method directly.
8981 (tui_clear_win_detail): Remove.
8982
f83d391c
TT		 89832019-06-25 Tom Tromey <tom@tromey.com>
8984
8985 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8986 "this", not TUI_DISASM_WIN.
8987
13446e05
TT		 89882019-06-25 Tom Tromey <tom@tromey.com>
8989
8990 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8991 declare.
8992 * tui/tui-winsource.c
8993 (tui_source_window_base::do_scroll_horizontal): Rename from
8994 tui_horizontal_source_scroll.
8995 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8996 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8997 from tui_vertical_data_scroll.
8998 * tui/tui-win.h (tui_scroll): Don't declare.
8999 * tui/tui-win.c (tui_win_info::forward_scroll)
9000 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9001 (tui_win_info::right_scroll): Rename and update.
9002 (tui_scroll_forward_command, tui_scroll_backward_command)
9003 (tui_scroll_left_command, tui_scroll_right_command): Update.
9004 (tui_scroll): Remove.
9005 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9006 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9007 from tui_vertical_source_scroll.
9008 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9009 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9010 from tui_vertical_disassem_scroll.
9011 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9012 do_scroll_horizontal>: New methods.
9013 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9014 Likewise.
9015 (struct tui_source_window_base): Add do_scroll_horizontal.
9016 (struct tui_source_window, struct tui_disasm_window): Add
9017 do_scroll_vertical.
9018 (struct tui_data_window, struct tui_cmd_window): Add
9019 do_scroll_horizontal and do_scroll_vertical.
9020 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9021
5cf82909
TT		 90222019-06-25 Tom Tromey <tom@tromey.com>
9023
9024 * tui/tui-data.h (struct tui_source_window_base): New struct.
9025 (struct tui_source_window): Derive from tui_source_window_base.
9026 (struct tui_disasm_window): New struct.
9027 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9028 from tui_source_window::clear_detail.
9029 (tui_source_window_base): Rename from tui_source_window.
9030 (~tui_source_window_base): Rename from ~tui_source_window.
9031 (tui_alloc_win_info): Create a tui_disasm_window.
9032
ee1d42d6
TT		 90332019-06-25 Tom Tromey <tom@tromey.com>
9034
9035 * tui/tui-data.h (struct tui_source_window)
9036 (struct tui_data_window): Declare destructors.
9037 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9038 destructors.
9039 (tui_win_info): Simplify.
9040
b4eb2452
TT		 90412019-06-25 Tom Tromey <tom@tromey.com>
9042
9043 * tui/tui-winsource.c (tui_display_main)
9044 (tui_update_source_windows_with_addr)
9045 (tui_update_all_breakpoint_info): Update.
9046 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9047 (new_height_ok, parse_scrolling_args): Update.
9048 * tui/tui-stack.c (tui_show_frame_info): Update.
9049 * tui/tui-data.h (struct tui_list): Remove.
9050 (tui_source_windows): Return a reference to a std::vector.
9051 * tui/tui-data.c (source_windows): Now a std::vector.
9052 (tui_source_windows): Change return type.
9053 (tui_clear_source_windows): Rewrite.
9054 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9055 (tui_free_all_source_wins_content): Rewrite.
9056
8761a91b
TT		 90572019-06-25 Tom Tromey <tom@tromey.com>
9058
9059 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9060 (struct tui_data_window, struct tui_cmd_window): Declare
9061 clear_detail method.
9062 * tui/tui-data.c (tui_source_window::clear_detail)
9063 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9064 methods.
9065 (tui_clear_win_detail): Simplify.
9066
0ed69eda
TT		 90672019-06-25 Tom Tromey <tom@tromey.com>
9068
9069 * tui/tui-layout.c (make_source_window, make_disasm_window)
9070 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9071 Return the new window.
9072 (show_source_disasm_command, show_data)
9073 (show_source_or_disasm_and_command): Update.
9074
82432e10
TT		 90752019-06-25 Tom Tromey <tom@tromey.com>
9076
9077 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9078 parameter. Return the new window.
9079 (show_source_disasm_command): Update and remove NULL check.
9080 (show_source_or_disasm_and_command): Update.
9081
ec328aa5
TT		 90822019-06-25 Tom Tromey <tom@tromey.com>
9083
9084 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9085
33b906ab
TT		 90862019-06-25 Tom Tromey <tom@tromey.com>
9087
9088 * tui/tui-data.h (struct tui_win_info): Make constructor
9089 protected. Make destructor virtual. Add initializers.
9090 (tui_source_window, tui_data_window, tui_cmd_window): New
9091 classes.
9092 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9093 constructor. Add "type" parameter.
9094 (tui_source_window, tui_data_window, tui_cmd_window): New
9095 constructors.
9096 (tui_alloc_win_info): Instantiate the appropriate subclass.
9097
e7e11af4
TT		 90982019-06-25 Tom Tromey <tom@tromey.com>
9099
9100 * tui/tui-win.c (tui_resize_all): Use delete.
9101 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9102 destructor.
9103 (tui_free_window): Don't declare.
9104 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9105 Update.
9106
6792b55e
TT		 91072019-06-25 Tom Tromey <tom@tromey.com>
9108
9109 * tui/tui-data.h (struct tui_win_info): Add constructor.
9110 * tui/tui-data.c (tui_alloc_win_info): Use new.
9111 (tui_free_window): Use delete.
9112
f95675e1
TT		 91132019-06-22 Tom Tromey <tom@tromey.com>
9114
9115 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9116 declare.
9117 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9118
5bff081c
TT		 91192019-06-22 Tom Tromey <tom@tromey.com>
9120
9121 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9122 declare.
9123 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9124
47e3f474
TV		 91252019-06-22 Tom de Vries <tdevries@suse.de>
9126
9127 * dwarf2read.c (create_addrmap_from_aranges)
9128 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9129 instead of '%zu'.
9130
fd5866f6
SM		 91312019-06-21 Simon Marchi <simon.marchi@efficios.com>
9132
9133 * dwarf2read.h (dwarf2_section_info_def): Remove.
9134 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9135 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9136 std::vector<dwarf2_section_info>.
9137 (struct dwo_file) <~dwo_file>: Remove.
9138 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9139 types field.
9140 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9141 (dwarf2_read_debug_names): Likewise.
9142 (create_debug_types_hash_table): Change parameter type to
9143 array_view, adjust code accordingly.
9144 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9145 (partial_die_info::fixup): Likewise.
9146 (determine_prefix): Likewise.
9147 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9148
fb1eb2f9
SM		 91492019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9150
9151 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9152 gdb_bfd_ref_ptr.
9153 <~dwo_file>: Remove call to gdb_bfd_unref.
9154 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9155 gdb_bfd_ref_ptr::get.
9156
51ac9db5
SM		 91572019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9158
9159 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9160 type to htab_up.
9161 * dwarf2read.c (struct dwo_file): Initialize fields.
9162 <~dwo_file>: New.
9163 (free_dwo_file): Remove, move content to ~dwo_file.
9164 (struct dwo_file_deleter): Remove.
9165 (dwo_file_up>: Remove custom deleter.
9166 (free_dwo_files): Remove.
9167 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9168 dwo_files.
9169 (process_skeletonless_type_units): Call unique_ptr::get.
9170 (allocate_dwo_file_hash_table): Add deleter to created hash
9171 table. Change return type to htab_up.
9172 (lookup_dwo_file_slot): Don't memset dwo_file, call
9173 unique_ptr::get.
9174 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9175 (create_dwo_unit_in_dwp_v2): Likewise.
9176 (open_and_init_dwo_file): Likewise.
9177 (free_dwo_file_from_slot): Remove.
9178
dc4ccb6f
SM		 91792019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9180
9181 * dwarf2read.h (struct dwarf2_section_info) <readin,
9182 is_virtual>: Change type to bool.
9183 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9184 true instead of 1.
9185
e6a1c5cb
TT		 91862019-06-19 Tom Tromey <tom@tromey.com>
9187
9188 * tui/tui-data.h (tui_init_content_element): Don't declare.
9189
6f6ffbeb
TT		 91902019-06-19 Tom Tromey <tom@tromey.com>
9191
9192 * tui/tui-data.h (tui_init_win_info): Don't declare.
9193
f23f598e
TV		 91942019-06-19 Tom de Vries <tdevries@suse.de>
9195
9196 * dwarf2read.h (abstract_to_concrete): Change type to
9197 std::unordered_map<sect_offset, std::vector<sect_offset>,
9198 gdb::hash_enum<sect_offset>>.
9199
680e1bee
TT		 92002019-06-19 Tom Tromey <tromey@adacore.com>
9201
9202 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9203 EVAL_AVOID_SIDE_EFFECTS specially.
9204
dcf37923
TT		 92052019-06-19 Tom Tromey <tromey@adacore.com>
9206
9207 * source-cache.c (highlighter): New global.
9208 (source_cache::get_source_lines): Create a highlighter on demand.
9209
494986d5
AB		 92102019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9211
9212 * defs.h (deprecated_interactive_hook): Delete declaration.
9213 * interps.c (clear_interpreter_hooks): Remove use of
9214 deprecated_interactive_hook.
9215 * top.c (deprecated_interactive_hook): Delete definition.
9216 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9217
3360b6e7
TV		 92182019-06-18 Tom de Vries <tdevries@suse.de>
9219
9220 PR gdb/24515
9221 * dwarf2read.h (abstract_to_concrete): Change type from
9222 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9223 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9224 * dwarf2read.c (read_variable): Update.
9225 (dwarf2_fetch_die_loc_sect_off): Update.
9226
310b3441
TV		 92272019-06-17 Tom de Vries <tdevries@suse.de>
9228
9229 PR gdb/24617
9230 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9231 accessing parent[parent_len - 1].
9232
ba9777be
PP		 92332019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9234
9235 PR gdb/24364
9236 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9237 call dtrace_process_dof with NULL dof.
9238
2b9f6e89
TV		 92392019-06-16 Tom de Vries <tdevries@suse.de>
9240
9241 PR gdb/24445
9242 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9243
431b3ead
TT		 92442019-06-16 Tom Tromey <tom@tromey.com>
9245
9246 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9247 (make_all_visible): Use address of member.
9248
d04b44a1
TT		 92492019-06-16 Tom Tromey <tom@tromey.com>
9250
9251 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9252 (tui_free_window, free_content, free_content_elements): Remove
9253 unnecessary cast.
9254 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9255 cast.
9256 * tui/tui-regs.c (tui_show_register_group)
9257 (tui_display_registers_from, tui_display_reg_element_at_line):
9258 Remove unnecessary cast.
9259
bf5142e7
AB		 92602019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9261
9262 * linux-nat.c (normal_mask): Delete.
9263 (_initialize_linux_nat): Don't initialise normal_mask.
9264
c4973306
SM		 92652019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9266
9267 PR gdb/24445
9268 * dwarf-index-write.h (write_psymtabs_to_index): Add
9269 dwz_basename parameter.
9270 * dwarf-index-write.c (write_gdbindex): Move file writing to
9271 write_gdbindex_1. Change return type void.
9272 (assert_file_size): Move up, remove filename parameter.
9273 (write_gdbindex_1): New function.
9274 (write_debug_names): Change return type to void, call
9275 assert_file_size.
9276 (struct index_wip_file): New struct.
9277 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9278 file logic to index_wip_file. Write index for dwz file if
9279 needed.
9280 (save_gdb_index_command): Pass basename of dwz file, if present.
9281 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9282 build-id of dwz file, if present.
9283 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9284 (dwarf2_get_dwz_file): Likewise.
9285 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9286 (dwarf2_get_dwz_file): Likewise.
9287
395f9c91
TT		 92882019-06-16 Tom Tromey <tom@tromey.com>
9289
9290 * coffread.c (process_coff_symbol): Use xstrdup.
9291 * value.c (create_internalvar): Use xstrdup.
9292
cafb3438
TT		 92932019-06-16 Tom Tromey <tom@tromey.com>
9294
9295 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9296 * breakpoint.c (stopin_command, stopat_command)
9297 (until_break_command, decode_location_default): Remove unnecessary
9298 cast.
9299 * utils.c (subset_compare): Remove unnecessary cast.
9300 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9301 cast.
9302 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9303 cast.
9304 * infcmd.c (path_command): Remove unnecessary cast.
9305 * coffread.c (decode_type): Remove unnecessary cast.
9306 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9307 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9308 * tui/tui-stack.c (tui_show_locator_content)
9309 (tui_show_frame_info): Remove unnecessary cast.
9310 * tui/tui-win.c (tui_scroll_forward_command)
9311 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9312 (parse_scrolling_args): Remove unnecessary cast.
9313 * tui/tui-data.c (init_win_info, tui_del_window)
9314 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9315 (free_content_elements): Remove unnecessary cast.
9316 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9317 unnecessary cast.
9318 * tui/tui-source.c (tui_set_source_content)
9319 (tui_vertical_source_scroll): Remove unnecessary cast.
9320 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9321 cast.
9322 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9323 * tui/tui-regs.c (tui_display_registers_from)
9324 (tui_display_register): Remove unnecessary cast.
9325 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9326 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9327 (make_visible): Remove unnecessary cast.
9328 * tui/tui-winsource.c (tui_erase_source_content)
9329 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9330 unnecessary cast.
9331 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9332 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9333 * stabsread.c (read_type, read_array_type, read_range_type):
9334 Remove unnecessary cast.
9335 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9336 (parse_symbol, parse_type, upgrade_type, parse_external)
9337 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9338 unnecessary cast.
9339 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9340
730ead81
TT		 93412019-06-16 Tom Tromey <tom@tromey.com>
9342
9343 * tui/tui-data.c (tui_alloc_generic_win_info)
9344 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9345 checks.
9346
584a927c
AB		 93472019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9348 Andrew Burgess <andrew.burgess@embecosm.com>
9349
9350 * f-typeprint.c (f_print_type): Don't return early for not
9351 associated or not allocated types.
9352 (f_type_print_varspec_suffix): Add print_rank parameter and print
9353 ranks of array types in case they dangling.
9354 (f_type_print_base): Add print_rank parameter.
9355
30056ea0
AB		 93562019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9357
9358 * NEWS: Mention new MI commands.
9359 * break-catch-throw.c (enum exception_event_kind): Move to
9360 breakpoint.h.
9361 (print_mention_exception_catchpoint): Output text as a single
9362 message.
9363 (catch_exception_command_1): Rename to...
9364 (catch_exception_event): ...this, make non-static, update header
9365 command, and change some parameter types.
9366 (catch_catch_command): Update for changes to
9367 catch_exception_command_1.
9368 (catch_throw_command): Likewise.
9369 (catch_rethrow_command): Likewise.
9370 * breakpoint.c (enum exception_event_kind): Delete.
9371 * breakpoint.h (enum exception_event_kind): Moved here from
9372 break-catch-throw.c.
9373 (catch_exception_event): Declare.
9374 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9375 (mi_cmd_catch_throw): New function.
9376 (mi_cmd_catch_rethrow): New function.
9377 (mi_cmd_catch_catch): New function.
9378 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9379 'catch-catch' entries.
9380 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9381 (mi_cmd_catch_rethrow): Declare.
9382 (mi_cmd_catch_catch): Declare.
9383
ec8e2b6d
AB		 93842019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9385
9386 * annotate.c (annotate_source_line): Change return type to void,
9387 update implementation to match.
9388 * annotate.h (annotate_source_line): Change return type to void,
9389 update header comment.
9390 * stack.c (print_frame_info): Don't change what frame information
9391 is printed based on whether annotations are on or not.
9392
0d3abd8c
AB		 93932019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9394
9395 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9396 (annotate_source): Make static.
9397 (annotate_source_line): Moved from source.c and renamed from
9398 identify_source_line. Update the return type.
9399 * annotate.h (annotate_source): Delete declaration.
9400 (annotate_source_line): Declaration moved from source.h, and
9401 renamed from identify_source_line. Return type updated.
9402 * source.c (identify_source_line): Moved to annotate.c and renamed
9403 to annotate_source_line.
9404 (info_line_command): Remove check of annotation_level.
9405 * source.h (identify_source_line): Move declaration to annotate.h
9406 and rename to annotate_source_line.
9407 * stack.c: Add 'annotate.h' include.
9408 (print_frame_info): Remove check of annotation_level before
9409 calling annotate_source_line.
9410
00df30ae
AB		 94112019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9412
9413 * source-cache.c (source_cache::get_plain_source_lines): Use
9414 open_source_file_with_line_charpos instead of just
9415 open_source_file, remove call to find_source_lines.
9416 (source_cache::get_source_lines): Likewise.
9417 * source.c (find_source_lines): Make static.
9418 (get_filename_and_charpos): Renamed into...
9419 (open_source_file_with_line_charpos): ..this along with changes to
9420 return a scoped_fd, and some other minor clean ups.
9421 (identify_source_line): Use open_source_file_with_line_charpos.
9422 (search_command_helper): Use open_source_file_with_line_charpos
9423 instead of just open_source_file, remove call to
9424 find_source_lines.
9425 * source.h (open_source_file_with_line_charpos): Declare new
9426 function.
9427 (find_source_lines): Delete declaration.
9428
afda45a2
AB		 94292019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9430
9431 * source.c (get_filename_and_charpos): Remove fullname
9432 parameter.
9433 (identify_source_line): Update call to get_filename_and_charpos.
9434
0735b091
TT		 94352019-06-14 Tom Tromey <tromey@adacore.com>
9436
9437 PR gdb/24502:
9438 * ui-style.h (skip_ansi_escape): Update comment.
9439 * ui-file.h (class no_terminal_escape_file): New class.
9440 * ui-file.c (no_terminal_escape_file::write)
9441 (no_terminal_escape_file::puts): New methods.
9442 * cli/cli-logging.c (handle_redirections): Use
9443 no_terminal_escape_file.
9444
52ce35e2
TT		 94452019-06-14 Tom Tromey <tromey@adacore.com>
9446
9447 * NEWS: Move convenience variable news above Python news.
9448
73cc7272
TT		 94492019-06-14 Tom Tromey <tom@tromey.com>
9450
9451 * gnulib: Move directory to top-level.
9452 * configure.ac: Don't configure gnulib.
9453 * configure: Rebuild.
9454 * common/common-defs.h: Use new path to gnulib.
9455 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9456 (GNULIB_H): Remove.
9457 (INCGNU): Look in new gnulib location.
9458 (HFILES_NO_SRCDIR): Remove gnulib files.
9459 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9460 (generated_files): Remove GNULIB_H.
9461 ($(LIBGNU), all-lib): Remove targets.
9462 (distclean): Don't mention GNULIB_BUILDDIR.
9463 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9464
f5686554
TT		 94652019-06-14 Tom Tromey <tromey@adacore.com>
9466
9467 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9468 Warn if symbol file does not provide any symbols.
9469
a0c1ffed
TT		 94702019-06-14 Tom Tromey <tromey@adacore.com>
9471
9472 * source.c (find_and_open_source): Respect basenames_may_differ.
9473
7c39e397
AB		 94742019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9475
9476 * annotate.c (annotate_breakpoints_invalid): Make use of
9477 scoped_restore_terminal_state.
9478 (annotate_frames_invalid): Likewise.
9479
f411722c
TT		 94802019-06-14 Tom Tromey <tromey@adacore.com>
9481
9482 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9483 allow assignment to an internalvar.
9484
4268ec18
TT		 94852019-06-14 Tom Tromey <tromey@adacore.com>
9486
9487 * ada-lex.l: Allow "_" in attribute names.
9488
abdb711e
TT		 94892019-06-14 Tom Tromey <tromey@adacore.com>
9490
9491 PR gdb/24653:
9492 * regcache.c (registers_changed): Don't call alloca.
9493 * top.c (execute_command): Don't call alloca.
9494
4c048731
PA		 94952019-06-13 Pedro Alves <palves@redhat.com>
9496
9497 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9498 'expression'. When parsing an expression, error out if there's
9499 junk after "unlimited".
9500 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9501 (do_set_command): Adjust calls to is_unlimited_literal.
9502
66eb1ed3
PA		 95032019-06-13 Pedro Alves <palves@redhat.com>
9504
9505 * compile/compile.c (make_compile_options_def_group): Add braces
9506 around array_view initializer.
9507 * thread.c (make_thread_apply_all_options_def_group)
9508 (make_thread_apply_all_options_def_group): Likewise.
9509
3345721a
PA		 95102019-06-13 Pedro Alves <palves@redhat.com>
9511
9512 * NEWS (New commands): Mention "maint test-options
9513 require-delimiter", "maint test-options unknown-is-error", "maint
9514 test-options unknown-is-operand" and "maint show
9515 test-options-completion-result".
9516 (New command options, command completion): New section.
9517 (Completion improvements): New section.
9518 Mention that you can abbreviate "unlimited".
9519
6206060d
PA		 95202019-06-13 Pedro Alves <palves@redhat.com>
9521
9522 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9523 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9524 * unittests/cli-utils-selftests.c (test_parse_flags)
9525 (test_parse_flags_qcs): Delete.
9526 (test_cli_utils): Don't call deleted functions.
9527
6665660a
PA		 95282019-06-13 Pedro Alves <palves@redhat.com>
9529
9530 * thread.c: Include "cli/cli-option.h".
9531 (tp_array_compar_ascending): Global.
9532 (tp_array_compar): Delete function.
9533 (tp_array_compar_ascending, tp_array_compar_descending): New
9534 functions.
9535 (ascending_option_def, qcs_flag_option_def)
9536 (thr_qcs_flags_option_defs)
9537 (make_thread_apply_all_options_def_group)
9538 (make_thread_apply_options_def_group): New.
9539 (thread_apply_all_command): Use gdb::option::process_options.
9540 (thread_apply_command_completer)
9541 (thread_apply_all_command_completer): New.
9542 (thread_apply_command): Use gdb::option::process_options.
9543 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9544 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9545 to generate help text of "thread apply". Adjust "taas"'s help.
9546 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9547 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9548
f7e13587
PA		 95492019-06-13 Pedro Alves <palves@redhat.com>
9550
9551 * thread.c (thread_apply_command): Check for invalid TID with
9552 isdigit instead of !isalpha.
9553
5d707134
PA		 95542019-06-13 Pedro Alves <palves@redhat.com>
9555
9556 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9557 (validate_flags_qcs): New.
9558 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9559 (validate_flags_qcs): Declare.
9560 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9561 (make_frame_apply_options_def_group): New.
9562 (frame_apply_command_count): Process options with
9563 gdb::option::process_options.
9564 (frame_apply_completer): New.
9565 (frame_apply_level_completer, frame_apply_all_completer)
9566 (frame_apply_completer): New.
9567 (_initialize_stack): Update help of "frame apply", "frame apply
9568 level", "frame apply all" and "faas" to mention supported options
9569 and install command completers.
9570 * stack.h (frame_apply_all_completer): Declare.
9571 * thread.c: Include "stack.h".
9572 (tfaas_command): Add "--".
9573 (_initialize_thread): Update help "tfaas" to mention supported
9574 options and install command completer.
9575
272d4594
PA		 95762019-06-13 Pedro Alves <palves@redhat.com>
9577
9578 * completer.c (complete_nested_command_line): New.
9579 (gdb_completion_word_break_characters_throw): Add assertion.
9580 * completer.h (complete_nested_command_line): Declare.
9581
90a1ef87
PA		 95822019-06-13 Pedro Alves <palves@redhat.com>
9583
9584 * stack.c (parse_backtrace_qualifiers): New.
9585 (backtrace_command): Use it.
9586 (backtrace_command_completer): Complete on qualifiers.
9587
d4c16835
PA		 95882019-06-13 Pedro Alves <palves@redhat.com>
9589
9590 * frame.c: Include "cli/cli-option.h.
9591 (user_set_backtrace_options): New.
9592 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9593 Delete.
9594 (get_prev_frame): Adjust.
9595 (boolean_option_def, uinteger_option_def)
9596 (set_backtrace_option_defs): New.
9597 (_initialize_frame): Adjust and use
9598 gdb::option::add_setshow_cmds_for_options to install "set
9599 backtrace past-main" and "set backtrace past-entry".
9600 * frame.h: Include "cli/cli-option.h".
9601 (struct frame_print_options): Forward declare.
9602 (print_frame_arguments_all, print_frame_arguments_scalars)
9603 (print_frame_arguments_none): Declare.
9604 (print_entry_values): Delete declaration.
9605 (struct frame_print_options, user_frame_print_options): New.
9606 (struct set_backtrace_options): New.
9607 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9608 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9609 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9610 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9611 (list_args_or_locals): Add frame_print_options parameter.
9612 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9613 * python/py-framefilter.c (enumerate_args): Pass down
9614 USER_FRAME_PRINT_OPTIONS.
9615 * stack.c: Include "cli/cli-option.h".
9616 (print_frame_arguments_all, print_frame_arguments_scalars)
9617 (print_frame_arguments_none): Declare.
9618 (print_raw_frame_arguments, print_entry_values): Delete.
9619 (user_frame_print_options): New.
9620 (boolean_option_def, enum_option_def, frame_print_option_defs):
9621 New.
9622 (struct backtrace_cmd_options): New.
9623 (bt_flag_option_def): New.
9624 (backtrace_command_option_defs): New.
9625 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9626 (print_frame_arg, read_frame_arg, print_frame_args)
9627 (print_frame_info, print_frame): Add frame_print_options parameter
9628 and use it.
9629 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9630 (backtrace_command_1): Add frame_print_options and
9631 backtrace_cmd_options parameters and use them.
9632 (make_backtrace_options_def_group): New.
9633 (backtrace_command): Process command options with
9634 gdb::option::process_options.
9635 (backtrace_command_completer): New.
9636 (_initialize_stack): Extend "backtrace"'s help to mention
9637 supported options. Install completer for "backtrace".
9638 Install some settings commands with add_setshow_cmds_for_options.
9639
2daf894e
PA		 96402019-06-13 Pedro Alves <palves@redhat.com>
9641
9642 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9643 and that "set/show print raw frame-arguments" are now deprecated.
9644
9645 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9646 command.
9647 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9648 * stack.c (_initialize_stack): Install "set/show print
9649 raw-frame-arguments", and deprecate "set/show print raw
9650 frame-arguments".
9651 * valprint.c (_initialize_valprint): Deprecate "set/show print
9652 raw".
9653
e6ed716c
PA		 96542019-06-13 Pedro Alves <palves@redhat.com>
9655
9656 * compile/compile.c (struct compile_options): New.
9657 (compile_flag_option_def, compile_command_option_defs)
9658 (make_compile_options_def_group): New.
9659 (compile_file_command): Handle options with
9660 gdb::option::process_options.
9661 (compile_file_command_completer): New function.
9662 (compile_code_command): Handle options with
9663 gdb::option::process_options.
9664 (compile_code_command_completer): New function.
9665 (_initialize_compiler): Install completers for "compile code" and
9666 "compile file". Mention available options in "compile code" and
9667 "compile code"'s help.
9668 * completer.c (advance_to_completion_word): New, factored out from
9669 ...
9670 (advance_to_expression_complete_word_point): ... this.
9671 (advance_to_filename_complete_word_point): New.
9672 * completer.h (advance_to_filename_complete_word_point): New
9673 declaration.
9674
7d8062de
PA		 96752019-06-13 Pedro Alves <palves@redhat.com>
9676
9677 * compile/compile.c: Include "cli/cli-option.h".
9678 (compile_print_value): Scope data pointer is now a
9679 value_print_options pointer; adjust.
9680 (compile_print_command): Process options. Scope data pointer is
9681 now a value_print_options pointer; adjust.
9682 (_initialize_compile): Update "compile print"'s help to include
9683 supported options. Install a completer for "compile print".
9684 * cp-valprint.c (show_vtblprint, show_objectprint)
9685 (show_static_field_print): Delete.
9686 (_initialize_cp_valprint): Don't install "set print
9687 static-members", "set print vtbl", "set print object" here.
9688 * printcmd.c: Include "cli/cli-option.h" and
9689 "common/gdb_optional.h".
9690 (print_command_parse_format): Rework to fill in a
9691 value_print_options instead of a format_data.
9692 (print_value): Change parameter type from format_data pointer to
9693 value_print_options reference. Adjust.
9694 (print_command_1): Process options. Adjust to pass down a
9695 value_print_options.
9696 (print_command_completer): New.
9697 (_initialize_printcmd): Install print_command_completer as
9698 handle_brkchars completer for the "print" command. Update
9699 "print"'s help to include supported options.
9700 * valprint.c: Include "cli/cli-option.h".
9701 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9702 here from cp-valprint.c.
9703 (boolean_option_def, uinteger_option_def)
9704 (value_print_option_defs, make_value_print_options_def_group):
9705 New. Use gdb::option::add_setshow_cmds_for_options to install
9706 "set print elements", "set print null-stop", "set print repeats",
9707 "set print pretty", "set print union", "set print array", "set
9708 print address", "set print symbol", "set print array-indexes".
9709 * valprint.h: Include <string> and "cli/cli-option.h".
9710 (make_value_print_options_def_group): Declare.
9711 (print_value): Change parameter type from format_data pointer to
9712 value_print_options reference.
9713 (print_command_completer): Declare.
9714
9d0faba9
PA		 97152019-06-13 Pedro Alves <palves@redhat.com>
9716
9717 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9718 (COMMON_SFILES): Add maint-test-settings.c.
9719 * cli/cli-decode.c (boolean_enums): New global, factored out from
9720 ...
9721 (add_setshow_boolean_cmd): ... here.
9722 * cli/cli-decode.h (boolean_enums): Declare.
9723 * cli/cli-option.c: New file.
9724 * cli/cli-option.h: New file.
9725 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9726 factored out from ...
9727 (parse_cli_boolean_value(const char *)): ... this.
9728 (is_unlimited_literal): Change parameter type to pointer to
9729 pointer. Adjust and advance ARG pointer.
9730 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9731 (parse_cli_var_enum): New, factored out from ...
9732 (do_set_command): ... this. Adjust.
9733 * cli/cli-setshow.h (parse_cli_boolean_value)
9734 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9735 (parse_cli_var_enum): Declare.
9736 * cli/cli-utils.c: Include "cli/cli-option.h".
9737 (get_ulongest): New.
9738 * cli/cli-utils.h (get_ulongest): Declare.
9739 (check_for_argument): New overloads.
9740 * maint-test-options.c: New file.
9741
2c722807
PA		 97422019-06-13 Pedro Alves <palves@redhat.com>
9743
9744 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9745 parse a range if "-" is at the end of the string.
9746
dee7b4c8
PA		 97472019-06-13 Pedro Alves <palves@redhat.com>
9748
9749 * cli/cli-setshow.c (parse_auto_binary_operation)
9750 (parse_cli_boolean_value): Don't allow "o".
9751
dca0f6c0
PA		 97522019-06-13 Pedro Alves <palves@redhat.com>
9753
9754 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9755 * NEWS: Mention maint test-settings KIND.
9756 * maint-test-settings.c: New file.
9757
597bf39d
PA		 97582019-06-13 Pedro Alves <palves@redhat.com>
9759
9760 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9761 completer.
9762 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9763 "set" completers.
9764
48c410fb
PA		 97652019-06-13 Pedro Alves <palves@redhat.com>
9766
9767 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9768 after item.
9769
93bcb043
PA		 97702019-06-13 Pedro Alves <palves@redhat.com>
9771
9772 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9773
cbba3ecd
PA		 97742019-06-13 Pedro Alves <palves@redhat.com>
9775
9776 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9777 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9778 call.
9779 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9780 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9781 calls.
9782 (check_for_argument): Skip spaces after argument.
9783
b9a3f842
PA		 97842019-06-13 Pedro Alves <palves@redhat.com>
9785
9786 * thread.c (thread_apply_command): Adjust TID parsing.
9787 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9788 detected before end of string.
9789 (tid_is_in_list): Error out if LIST is invalid.
9790
3844e605
PA		 97912019-06-13 Pedro Alves <palves@redhat.com>
9792
9793 * completer.c (complete_line_internal_1): Rewind completion word
9794 point.
9795 (completion_tracker::advance_custom_word_point_by): Change
9796 parameter type to int.
9797 * completer.h (completion_tracker::advance_custom_word_point_by):
9798 Likewise.
9799
00b56dbe
PA		 98002019-06-13 Pedro Alves <palves@redhat.com>
9801
9802 * completer.c (advance_to_completion_word): Handle delimiters.
9803
d106773e
PA		 98042019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9805
9806 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9807
08f10e02
TT		 98082019-06-11 Tom Tromey <tom@tromey.com>
9809
9810 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9811 (xmalloc_failed): Move to alloc.c.
9812 * alloc.c: New file.
9813 * Makefile.in (COMMON_SFILES): Add alloc.c.
9814
1c7fe951
TT		 98152019-06-11 Tom Tromey <tom@tromey.com>
9816
9817 * nat/linux-waitpid.c: Don't include server.h.
9818 (linux_debug): Remove.
9819 (my_waitpid): Update.
9820
89549d7f
TT		 98212019-06-11 Tom Tromey <tromey@adacore.com>
9822
9823 * infcall.c (_initialize_infcall): Remove trailing newline from
9824 help.
9825 * user-regs.c (_initialize_user_regs): Remove trailing newline
9826 from help.
9827 * typeprint.c (_initialize_typeprint): Remove trailing newline
9828 from help.
9829 * reverse.c (_initialize_reverse): Remove trailing newlines from
9830 help.
9831 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9832 from help.
9833 * language.c (add_set_language_command): Remove trailing newline
9834 from help.
9835 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9836 help.
9837 * disasm.c (_initialize_disasm): Remove trailing newline from
9838 help.
9839 * top.c (init_main): Remove trailing newline from help.
9840 * interps.c (_initialize_interpreter): Remove trailing newline
9841 from help.
9842 * btrace.c (_initialize_btrace): Remove trailing newlines from
9843 help.
9844 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9845 from help.
9846 * python/python.c (_initialize_python): Remove trailing newline
9847 from help.
9848 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9849 help.
9850 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9851 from help. Reformat some text.
9852 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9853 from help.
9854 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9855 newline from help.
9856
86108c13
TT		 98572019-06-11 Tom Tromey <tromey@adacore.com>
9858
9859 * darwin-nat.c (darwin_decode_exception_message)
9860 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9861
a7067863
AB		 98622019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9863
9864 * valops.c (value_slice): Check for not allocated or not
9865 associated values.
9866
9ab08412
TV		 98672019-06-10 Tom de Vries <tdevries@suse.de>
9868
9869 PR gdb/24618
9870 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9871 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9872 invalid.
9873
f19e22e9
TV		 98742019-06-10 Tom de Vries <tdevries@suse.de>
9875
9876 PR gdb/24611
9877 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9878 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9879
e99f9db0
TV		 98802019-06-10 Tom de Vries <tdevries@suse.de>
9881
9882 PR symtab/24545
9883 * symtab.c (struct demangled_name_entry): Add language field.
9884 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9885 static minimal symbol". Set and use language field.
9886
9bf7038b
TT		 98872019-06-10 Tom Tromey <tromey@adacore.com>
9888
9889 * ada-lang.c (_initialize_ada_language): Update help text.
9890
422186a9
TT		 98912019-06-10 Tom Tromey <tromey@adacore.com>
9892
9893 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9894 with a newline.
9895 * guile/guile.c (handle_boot_error): Don't end warning with a
9896 newline.
9897 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9898 warning with a newline.
9899 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9900 newline.
9901 (s12z_frame_cache): Likewise.
9902 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9903 a newline.
9904 * solib-svr4.c (disable_probes_interface): Don't end warning with
9905 a newline.
9906 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9907 newline.
9908 * python/python.c (do_finish_initialization): Don't end warning
9909 with a newline.
9910
25ce02ee
TT		 99112019-06-10 Tom Tromey <tom@tromey.com>
9912
9913 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9914 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9915 gdbpy_enter.
9916
caa429d8
TT		 99172019-06-10 Tom Tromey <tromey@adacore.com>
9918
9919 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9920 data.
9921 (elf_new_init): Don't call stabsread_new_init.
9922 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9923 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9924 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9925
81873cc8
TV		 99262019-06-10 Tom de Vries <tdevries@suse.de>
9927
9928 PR symtab/16264
9929 PR symtab/24517
9930 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9931
4fa0265e
РИ		 99322019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9933
9934 * source.c (find_and_open_source): Also rewrite relative file
9935 names.
9936
1a3da2cd
AB		 99372019-04-26 Amos Bird <amosbird@gmail.com>
9938
9939 * annotate.c (annotate_thread_exited): Add "thread-exited"
9940 annotation.
9941
3847a7bf
TT		 99422019-06-06 Tom Tromey <tromey@adacore.com>
9943
9944 * maint.h (class scoped_command_stats): Use
9945 DISABLE_COPY_AND_ASSIGN.
9946 <print_time>: New method.
9947 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9948 print_time.
9949 (scoped_command_stats::print_time): New method.
9950
312617a3
AB		 99512019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9952
9953 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9954 instructions of lengths 6 or 8 bytes.
9955
b02f78f9
PA		 99562019-06-04 Pedro Alves <palves@redhat.com>
9957
9958 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9959
9960 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9961 * breakpoint.c (condition_completer): Likewise.
9962 * cli/cli-dump.c (scan_expression): Likewise.
9963 * common/filestuff.c (mkdir_recursive): Likewise.
9964 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9965 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9966 (gdb_abspath): Likewise.
9967 * compile/compile-cplus-types.c
9968 (compile_cplus_instance::decl_name): Likewise.
9969 * completer.c (complete_explicit_location):
9970 (signal_completer, reg_or_group_completer_1): Likewise.
9971 * cp-support.c (cp_remove_params_if_any): Likewise.
9972 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9973 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9974 * infcmd.c (strip_bg_char): Likewise.
9975 * linespec.c (copy_token_string): Likewise.
9976 * mi/mi-main.c (output_cores): Likewise.
9977 * psymtab.c (psymtab_search_name):
9978 * symfile.c (test_set_ext_lang_command): Likewise.
9979 * target.c (target_fileio_read_stralloc): Likewise.
9980 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9981 * value.c (complete_internalvar): Likewise.
9982
e1f2e1a2
CB		 99832019-06-04 Christian Biesinger <cbiesinger@google.com>
9984
9985 Add objfile property to gdb.Type.
d3238f7d
PA		 9986 * NEWS: Mention Python API addition.
9987 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9988
e664d728
PW		 99892019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9990
9991 * NEWS: Mention the new set|show style [title|highlight].
9992 Mention changes to "show style", "help" and "apropos".
9993
66d8c862
PW		 99942019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9995
9996 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9997 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9998 instead of print_help_for_command.
9999 (print_doc_of_command): New function.
10000 (help_list): Add 'apropos -v word' suggestion.
10001 (print_help_for_command): Style the command name using title style.
10002 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10003 (_initialize_cli_cmds): Describe -v in apropos_command help.
10004
9303eb2f
PW		 100052019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10006
10007 * cli/cli-style.h (cli_style_option): Add name in constructor,
10008 add m_name class member, add constructor with intensity,
10009 add name class function.
10010 (cli_style_option::add_setshow_commands): Remove name argument.
10011 (highlight_style, title_style): New styles.
10012 * cli/cli-style.c (do_show): New function that shows a style
10013 characteristic styling the style name with itself.
10014 (set_style_name): New function.
10015 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10016 Update all callers according to the changes in cli/cli-style.h.
10017 * utils.h (fputs_highlighted): New function.
10018 * utils.c (fputs_highlighted): Likewise.
10019
e2c52041
PW		 100202019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10021
10022 * NEWS: Mention new pipe command and new convenience variables.
10023
947d3946
PW		 100242019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10025
10026 * cli/cli-cmds.c (pipe_command): New function.
10027 (_initialize_cli_cmds): Call add_com for pipe_command.
10028 Define | as an alias for pipe.
10029 (exit_status_set_internal_vars): New function.
10030 (shell_escape): Call exit_status_set_internal_vars.
10031 cli/cli-decode.c (find_command_name_length): Recognize | as
10032 a single character command.
10033
b8fd0918
PW		 100342019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10035
10036 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10037 top.c (execute_command_to_ui_file): New function, mostly a copy
10038 of execute_command_to_string.
10039 (execute_command_to_string): Implement by calling
10040 execute_command_to_ui_file.
10041
68bb5386
PW		 100422019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10043
10044 * top.h (saved_command_line): Remove declaration.
10045 * top.c (previous_saved_command_line, previous_repeat_arguments):
10046 New variables.
10047 (saved_command_line): Make static, define together with other
10048 'repeat variables'.
10049 (dont_repeat): Clear repeat_arguments.
10050 (repeat_previous, get_saved_command_line, save_command_line):
10051 New functions.
10052 (gdb_init): Initialize saved_command_line
10053 and previous_saved_command_line.
10054 * main.c (captured_main_1): Remove saved_command_line initialization.
10055 * event-top.c (handle_line_of_input): Update to use
10056 the new 'repeat' related functions instead of direct access to
10057 saved_command_line.
10058 * command.h (repeat_previous, get_saved_command_line,
10059 save_command_line): New declarations.
10060 (dont_repeat): Add comment.
10061
bfcdb852
TT		 100622019-05-30 Tom Tromey <tromey@adacore.com>
10063
10064 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10065 Fix comment.
10066 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10067
0ef209f2
JV		 100682019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10069
10070 PR cli/24587
10071 * completer.c (complete): Initialize variable word.
10072
955b06fa
SDJ		 100732019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10074
10075 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10076 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10077 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10078 'body' is NULL to the outter 'if', protecting the '!is_define'
10079 situation as well.
10080
fa9c3fa0
TT		 100812019-05-29 Tom Tromey <tromey@adacore.com>
10082
10083 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10084 (dwarf_unknown): New function.
10085 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10086 (dwarf_type_encoding_name): Use dwarf_unknown.
10087
4330d61d
TT		 100882019-05-29 Tom Tromey <tromey@adacore.com>
10089
10090 PR c++/20020:
10091 * cp-valprint.c (cp_print_value_fields): Call
10092 cp_print_static_field inside "try".
10093
33a6bc35
TT		 100942019-05-29 Tom Tromey <tromey@adacore.com>
10095
10096 * inflow.c (struct terminal_info): Add default operator=.
10097 * configure: Rebuild.
10098 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10099 -Wdeprecated-copy-dtor, -Wredundant-move.
10100
000439d5
TT		 101012019-05-29 Tom Tromey <tromey@adacore.com>
10102
10103 * NEWS: Add entry.
10104 * infcmd.c (print_return_value_1): Handle finish_print
10105 option.
10106 (show_print_finish): New function.
10107 (_initialize_infcmd): Add "set/show print finish" commands.
10108 * valprint.c (user_print_options): Initialize new member.
10109 * valprint.h (struct value_print_options) <finish_print>: New
10110 member.
10111
c0e70c62
TT		 101122019-05-28 Tom Tromey <tromey@adacore.com>
10113
10114 * ada-lang.c (ada_remove_Xbn_suffix)
10115 (find_old_style_renaming_symbol)
10116 (parse_old_style_renaming): Remove.
10117 (ada_find_renaming_symbol): Don't call
10118 find_old_style_renaming_symbol.
10119 (ada_is_renaming_symbol): Rename from
10120 ada_find_renaming_symbol. Remove "block" parameter. Return
10121 bool. Now static.
10122 (ada_read_var_value): Update and simplify.
10123 * ada-exp.y (write_var_or_type): Remove old code.
10124
766f8836
AH		 101252019-05-28 Alan Hayward <alan.hayward@arm.com>
10126
68255adc 10127 PR gdb/25010
766f8836
AH		 10128 * event-top.c: Remove include comment.
10129 * inflow.c (class scoped_ignore_sigttou): Move from here...
10130 * inflow.h (class scoped_ignore_sigttou): ...to here.
10131 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10132 * top.c: Remove include comment.
10133
eb41253a
TT		 101342019-05-27 Tom Tromey <tom@tromey.com>
10135
10136 * NEWS: Fix typo.
10137
4ca51187
TT		 101382019-05-22 Tom Tromey <tromey@adacore.com>
10139
10140 * target.c (target_follow_exec): Constify parameter.
10141 * target-delegates.c: Rebuild.
10142 * remote.c (remote_target::follow_exec): Constify parameter.
10143 * infrun.c (follow_exec): Constify parameter.
10144 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10145 (target_follow_exec): Likewise.
10146
8fca4da0
AH		 101472019-05-22 Alan Hayward <alan.hayward@arm.com>
10148
10149 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10150 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10151
b7060614
AH		 101522019-05-22 Alan Hayward <alan.hayward@arm.com>
10153
10154 * NEWS: Add debugredirect and testsuite sections.
10155
0a5954bd
SC		 101562019-05-22 Simon Cook <simon.cook@embecosm.com>
10157
10158 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10159 target descriptions using exclusively floating point register name
10160 aliases.
10161
dc42e902
AB		 101622019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10163
10164 PR gdb/18644:
10165 * f-lang.c (build_fortran_types): Handle the case where
10166 gdbarch_floatformat_for_type returns a nullptr.
10167
fb7806c7
TV		 101682019-05-21 Tom de Vries <tdevries@suse.de>
10169
10170 PR cli/24587
10171 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10172
34d11c68
AB		 101732019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10174
10175 PR gdb/18644:
10176 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10177 16-byte floats.
10178 * i386-tdep.c (i386_floatformat_for_type): Use
10179 floatformats_ia64_quad for the 16-byte floating point component
10180 within a fortran 32-byte complex number.
10181
122cf0f2
AB		 101822019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10183
10184 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10185 delete default constructor.
10186 (find_partial_die): Update to return const struct.
10187 (partial_die_parent_scope): Move variable declaration into scope
10188 of its use and change its type to auto.
10189 (guess_partial_die_structure_name): Likewise.
10190 (partial_die_info::fixup): Likewise.
10191
33d0e35a
TT		 101922019-05-17 Tom Tromey <tromey@adacore.com>
10193
10194 * source.c (find_and_open_source): Remove cast.
10195
a45575b0
TT		 101962019-05-17 Tom Tromey <tromey@adacore.com>
10197
10198 * annotate.c (annotate_source): Make "filename" const.
10199 * annotate.h (annotate_source): Use const.
10200
81f47ac2
AH		 102012019-05-17 Alan Hayward <alan.hayward@arm.com>
10202
10203 * disasm.c (set_disassembler_options): Send errors to stderr.
10204
ca1285d1
AH		 102052019-05-17 Alan Hayward <alan.hayward@arm.com>
10206
10207 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10208 (cli_interp_base::set_logging): Check debug_redirect.
10209 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10210 * cli/cli-logging.c (debug_redirect): Add static variable.
10211 (pop_output_files): Add default param.
10212 (handle_redirections): Print debug setting.
10213 (show_logging_command): Likewise.
10214 (_initialize_cli_logging): Add debugredirect command.
10215 * interps.c (current_interp_set_logging): Add debug_redirect
10216 parameter.
10217 * interps.h (set_logging): Add debug_redirect parameter.
10218 (current_interp_set_logging): Likewise.
10219 * mi/mi-common.h: Likewise.
10220 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10221
102222019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 10223 Tom Tromey <tromey@adacore.com>
10224
10225 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10226 directly.
10227 * cli/cli-interp.h (make_logging_output): Remove declaration.
10228 * cli/cli-logging.c (make_logging_output): Remove function.
10229 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10230 directly.
10231 * ui-file.c (tee_file::tee_file): Remove bools.
10232 (tee_file::~tee_file): Remove deletes.
10233 * ui-file.h (tee_file): Remove bools.
10234
26648588
JV		 102352019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10236
10237 * mi/mi-cmds.h (mi_cmd_complete): New function.
10238 * mi/mi-main.c (mi_cmd_complete): Likewise.
10239 * mi/mi-cmds.c: Define new MI command -complete.
10240 * NEWS: Mention new -complete command.
10241
6e035501
JV		 102422019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10243
10244 * completer.h (complete): New function.
10245 * completer.c (complete): Likewise.
10246 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10247 function defined in completer.h.
10248
7d0e2ece
JV		 102492019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10250
e79be6e5 10251 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10252
fb816e8b
TV		 102532019-05-17 Tom de Vries <tdevries@suse.de>
10254
10255 PR gdb/24094
10256 * dwarf2read.c (struct cu_partial_die_info): New struct.
10257 (find_partial_die): Return cu_partial_die_info.
10258 (partial_die_parent_scope, guess_partial_die_structure_name)
10259 (partial_die_info::fixup): Handle new return type of find_partial_die.
10260
677052f2
SDJ		 102612019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10262
a1726c38 10263 PR breakpoints/24541
677052f2
SDJ		 10264 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10265 "std::string", simplifying the algorithm.
10266
f3da9116
SDJ		 102672019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10268
10269 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10270 (stap_static_probe_ops::get_probes): Likewise.
10271
f1bb75ab
SDJ		 102722019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10273
10274 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10275 '-')" and "else if".
10276 (stap_parse_single_operand): Join checks for
10277 "gdbarch_stap_parse_special_token_p" and
10278 "gdbarch_stap_parse_special_token" in the same "if" statement.
10279 Invert check when verifying for operation on register
10280 displacement.
10281
3ca58cde
SDJ		 102822019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10283
10284 * stap-probe.c (stap_get_opcode): Update comment.
10285 (stap_get_expected_argument_type): Likewise.
10286 (handle_stap_probe): Likewise.
10287
af2d9bee
SDJ		 102882019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10289
10290 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10291 return type to 'bool'. Adjust comment. Use 'bool' when
10292 appropriate.
10293 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10294 * stap-probe.c (stap_parse_argument_1): Likewise.
10295 (stap_is_operator): Likewise.
10296 (stap_is_generic_prefix): Likewise.
10297 (stap_is_register_prefix): Likewise.
10298 (stap_is_register_indirection_prefix): Likewise.
10299 (stap_is_integer_prefix): Likewise.
10300 (stap_generic_check_suffix): Likewise.
10301 (stap_check_integer_suffix): Likewise.
10302 (stap_check_register_suffix): Likewise.
10303 (stap_check_register_indirection_suffix): Likewise.
10304 (stap_parse_register_operand): Likewise.
10305 (stap_parse_single_operand): Likewise.
10306 (stap_parse_argument_1): Likewise.
10307 (stap_probe::get_argument_count): Likewise.
10308 (stap_is_operator): Likewise.
10309
61c9c421
TT		 103102019-05-16 Tom Tromey <tromey@adacore.com>
10311
10312 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10313 keyword to foreach.
10314
9ddc1af1
SM		 103152019-05-15 Simon Marchi <simon.marchi@efficios.com>
10316
10317 * linux-thread-db.c (try_thread_db_load_1): Change return type
10318 to bool.
10319 (try_thread_db_load): Likewise.
10320 (try_thread_db_load_from_pdir_1): Likewise.
10321 (try_thread_db_load_from_pdir): Likewise.
10322 (try_thread_db_load_from_sdir): Likewise.
10323 (try_thread_db_load_from_dir): Likewise.
10324 (thread_db_load_search): Likewise.
10325 (has_libpthread): Likewise.
10326 (thread_db_load): Likewise.
10327
7bede828
SDJ		 103282019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10329
10330 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10331 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10332 NULL, and complain/return if that's the case.
10333
c5358db4
JD		 103342019-05-15 John Darrington <john@darrington.wattle.id.au>
10335
10336 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10337 (advance, posn, abstract_read_memory): New functions.
10338 [struct mem_read_abstraction]: New struct.
10339 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10340
c408a94f
TT		 103412019-05-14 Tom Tromey <tromey@adacore.com>
10342
10343 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10344 value is not lval_memory.
10345
e7bd7fba
TT		 103462019-05-14 Tom Tromey <tromey@adacore.com>
10347
10348 * solib.c (info_sharedlibrary_command): Style the file name.
10349
a6d0f249
AH		 103502019-05-14 Alan Hayward <alan.hayward@arm.com>
10351
10352 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10353 (aarch64_vnv_type): Likewise.
10354 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10355 * common/tdesc.c: Likewise.
10356 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10357 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10358 * features/aarch64-fpu.xml: Add ieee half view.
10359 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10360 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10361 * gdbtypes.h (struct builtin_type): Likewise.
10362 (struct objfile_type): Likewise.
10363
66b8bb74
SM		 103642019-05-12 Paul Naert <paul.naert@polymtl.ca>
10365
10366 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10367 typo.
10368 * location.h (string_to_event_location): Likewise.
10369
21c219fd
JB		 103702019-05-11 Joel Brobecker <brobecker@adacore.com>
10371
10372 GDB 8.3 released.
10373
13674803
SM		 103742019-05-10 Simon Marchi <simon.marchi@efficios.com>
10375
10376 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10377 New variable declaration.
10378 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10379 New variable.
10380 (print_one_breakpoint): Use ui_out::test_flags and new global
10381 variable to compute use_fixed_output.
10382 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10383 Remove.
10384 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10385 (mi_multi_location_breakpoint_output_fixed): Remove.
10386 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10387 new variable.
10388 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10389 fix_multi_location_breakpoint_output flag if version >= 3.
10390 * ui-out.h (enum ui_out_flag)
10391 <fix_multi_location_breakpoint_output>: New enumerator.
10392
a9eac7f9
SM		 103932019-05-10 Simon Marchi <simon.marchi@efficios.com>
10394
10395 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10396
71bed2db
TT		 103972019-05-10 Tom Tromey <tromey@adacore.com>
10398
10399 * ada-lang.c (catch_ada_completer): New function.
10400 (_initialize_ada_language): Use it.
10401
24c54127
TT		 104022019-05-10 Tom Tromey <tromey@adacore.com>
10403
10404 * thread.c (print_thread_info): Make "requested_threads" const.
10405 * gdbthread.h (print_thread_info): Make "requested_threads"
10406 const.
10407 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10408 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10409
7a102139
TT		 104102019-05-08 Tom Tromey <tom@tromey.com>
10411
10412 * gdbtypes.c (objfile_type_data): Change type.
10413 (objfile_type, _initialize_gdbtypes): Update.
10414
924d79e2
TT		 104152019-05-08 Tom Tromey <tom@tromey.com>
10416
10417 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10418 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10419 (_initialize_dwarf2_frame): Update.
10420
4c58e337
TT		 104212019-05-08 Tom Tromey <tom@tromey.com>
10422
10423 * objc-lang.c (objc_objfile_data): Change type.
10424 (find_methods): Update.
10425 (_initialize_objc_lang): Remove.
10426
d772d2ab
TT		 104272019-05-08 Tom Tromey <tom@tromey.com>
10428
10429 * stabsread.c (rs6000_builtin_type_data): Change type.
10430 (rs6000_builtin_type, _initialize_stabsread): Update.
10431
d11d83f4
TT		 104322019-05-08 Tom Tromey <tom@tromey.com>
10433
10434 * mips-tdep.c (mips_pdr_data): Remove.
10435 (_initialize_mips_tdep): Update.
10436
9a73f0ad
TT		 104372019-05-08 Tom Tromey <tom@tromey.com>
10438
10439 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10440 (hppa_init_objfile_priv_data, read_unwind_info)
10441 (find_unwind_entry, _initialize_hppa_tdep): Update.
10442
8127a2fa
TT		 104432019-05-08 Tom Tromey <tom@tromey.com>
10444
10445 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10446 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10447 on obstack.
10448 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10449
91d3055d
TT		 104502019-05-08 Tom Tromey <tom@tromey.com>
10451
10452 * mdebugread.c (basic_type_data): Change type.
10453 (basic_type, _initialize_mdebugread): Update.
10454
31930bd3
TT		 104552019-05-08 Tom Tromey <tom@tromey.com>
10456
10457 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10458
bdb3ed9e
TT		 104592019-05-08 Tom Tromey <tom@tromey.com>
10460
10461 * nto-tdep.c (nto_inferior_data_reg): Change type.
10462 (nto_inferior_data): Update.
10463 (nto_inferior_data_cleanup, nto_new_inferior_data)
10464 (_initialize_nto_tdep): Remove.
10465 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10466
f37b313d
TT		 104672019-05-08 Tom Tromey <tom@tromey.com>
10468
10469 * ada-lang.c (struct ada_inferior_data): Add initializers.
10470 (ada_inferior_data): Change type.
10471 (ada_inferior_data_cleanup): Remove.
10472 (get_ada_inferior_data, ada_inferior_exit)
10473 (struct ada_pspace_data): Add initializers, destructor.
10474 (ada_pspace_data_handle): Change type.
10475 (get_ada_pspace_data): Update.
10476 (ada_pspace_data_cleanup): Remove.
10477
24699405
TT		 104782019-05-08 Tom Tromey <tom@tromey.com>
10479
10480 * coffread.c (struct coff_symfile_info): Add initializers.
10481 (coff_objfile_data_key): Move lower. Change type.
10482 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10483 Update.
10484 (coff_free_info): Remove.
10485
d4e05d2f
TT		 104862019-05-08 Tom Tromey <tom@tromey.com>
10487
10488 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10489 (fbsd_pspace_data_handle): Move lower. Change type.
10490 (get_fbsd_pspace_data): Update.
10491 (fbsd_pspace_data_cleanup): Remove.
10492 (_initialize_fbsd_tdep): Update.
10493
14ef6690
TT		 104942019-05-08 Tom Tromey <tom@tromey.com>
10495
10496 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10497 (get_ada_tasks_pspace_data): Update.
10498 (ada_tasks_pspace_data_cleanup): Remove.
10499 (_initialize_tasks): Update.
10500 (ada_tasks_inferior_data_handle): Change type.
10501 (get_ada_tasks_inferior_data): Update.
10502 (ada_tasks_inferior_data_cleanup): Remove.
10503 (struct ada_tasks_pspace_data): Add initializers.
10504
814cf43a
TT		 105052019-05-08 Tom Tromey <tom@tromey.com>
10506
10507 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10508 * symfile-debug.c (debug_sym_get_probes): Change type.
10509 * stap-probe.c (handle_stap_probe):
10510 (stap_static_probe_ops::get_probes): Change type.
10511 * probe.h (class static_probe_ops) <get_probes>: Change type.
10512 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10513 (parse_probes_in_pspace): Update.
10514 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10515 Update.
10516 (any_static_probe_ops::get_probes): Change type.
10517 * elfread.c (elfread_data): New typedef.
10518 (probe_key): Change type.
10519 (elf_get_probes): Likewise. Update.
10520 (probe_key_free): Remove.
10521 (_initialize_elfread): Update.
10522 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10523 Change type.
10524 (dtrace_process_dof_probe, dtrace_process_dof)
10525 (dtrace_static_probe_ops::get_probe): Change type.
10526
02dc647e
TT		 105272019-05-08 Tom Tromey <tom@tromey.com>
10528
10529 * xcoffread.c (struct xcoff_symfile_info): Rename from
10530 coff_symfile_info. Add initializers.
10531 (xcoff_objfile_data_key): Move lower. Change type.
10532 (XCOFF_DATA): Rewrite.
10533 (xcoff_free_info): Remove.
10534 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10535 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10536 (xcoff_initial_scan): Update.
10537
09232438
TT		 105382019-05-08 Tom Tromey <tom@tromey.com>
10539
10540 * solib-svr4.c (struct svr4_info): Add initializers and
10541 destructor.
10542 <probes_table>: Now an htab_up.
10543 (solib_svr4_pspace_data): Change type.
10544 (free_probes_table): Simplify.
10545 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10546 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10547 (probes_table_remove_objfile_probes, register_solib_event_probe)
10548 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10549 (_initialize_svr4_solib): Update.
10550
7b4a314f
TT		 105512019-05-08 Tom Tromey <tom@tromey.com>
10552
10553 * remote.c (remote_pspace_data): Change type.
10554 (remote_pspace_data_cleanup): Remove.
10555 (get_remote_exec_file, set_pspace_remote_exec_file)
10556 (_initialize_remote): Update.
10557
51d3063a
TT		 105582019-05-08 Tom Tromey <tom@tromey.com>
10559
10560 * breakpoint.c (breakpoint_objfile_key): Change type.
10561 (get_breakpoint_objfile_data): Update.
10562 (free_breakpoint_objfile_data): Remove.
10563 (_initialize_breakpoint): Update.
10564
89fb8848
TT		 105652019-05-08 Tom Tromey <tom@tromey.com>
10566
10567 * linux-tdep.c (struct linux_info): Add initializers.
10568 (linux_inferior_data): Move. Change type.
10569 (invalidate_linux_cache_inf): Update.
10570 (linux_inferior_data_cleanup): Remove.
10571 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10572
e9b89e2d
TT		 105732019-05-08 Tom Tromey <tom@tromey.com>
10574
10575 * auxv.c (auxv_inferior_data): Move. Change type.
10576 (auxv_inferior_data_cleanup): Remove.
10577 (invalidate_auxv_cache_inf): Rewrite.
10578 (get_auxv_inferior_data, _initialize_auxv): Update.
10579
8c42777c
TT		 105802019-05-08 Tom Tromey <tom@tromey.com>
10581
10582 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10583 (symfile_debug_objfile_data_key): Change type.
10584 (symfile_debug_installed, debug_qf_has_symbols)
10585 (debug_qf_find_last_source_symtab)
10586 (debug_qf_forget_cached_source_info)
10587 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10588 (debug_qf_print_stats, debug_qf_dump)
10589 (debug_qf_expand_symtabs_for_function)
10590 (debug_qf_expand_all_symtabs)
10591 (debug_qf_expand_symtabs_with_fullname)
10592 (debug_qf_map_matching_symbols)
10593 (debug_qf_expand_symtabs_matching)
10594 (debug_qf_find_pc_sect_compunit_symtab)
10595 (debug_qf_map_symbol_filenames)
10596 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10597 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10598 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10599 (debug_sym_read_linetable, debug_sym_relocate): Update.
10600 (symfile_debug_free_objfile): Remove.
10601 (install_symfile_debug_logging, _initialize_symfile_debug):
10602 Update.
10603
5bfd760d
TT		 106042019-05-08 Tom Tromey <tom@tromey.com>
10605
10606 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10607 allocate_on_obstack.
10608 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10609 (get_dwarf2_per_objfile): Update.
10610 (set_dwarf2_per_objfile): Remove.
10611 (dwarf2_has_info, dwarf2_get_section_info): Update.
10612 (dwarf2_free_objfile): Remove.
10613 (_initialize_dwarf2_read): Update.
10614
e85e19b4
TT		 106152019-05-08 Tom Tromey <tom@tromey.com>
10616
10617 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10618 initializers.
10619 <unsupported_script_warning_printed,
10620 script_not_found_warning_printed>: Now bool.
10621 (auto_load_pspace_data): Change type.
10622 (~auto_load_pspace_info): Rename from
10623 auto_load_pspace_data_cleanup.
10624 (get_auto_load_pspace_data, init_loaded_scripts_info)
10625 (clear_section_scripts, maybe_print_unsupported_script_warning)
10626 (maybe_print_script_not_found_warning, _initialize_auto_load):
10627 Update.
10628
f6aa7436
TT		 106292019-05-08 Tom Tromey <tom@tromey.com>
10630
10631 * objfiles.c (objfile_pspace_info): Add destructor and
10632 initializers.
10633 (objfiles_pspace_data): Change type.
10634 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10635 (get_objfile_pspace_data): Update.
10636 (objfiles_bfd_data): Change type.
10637 (get_objfile_bfd_data): Update.
10638 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10639
6ae614f6
TT		 106402019-05-08 Tom Tromey <tom@tromey.com>
10641
10642 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10643 Change type.
10644 (get_catch_syscall_inferior_data): Update.
10645 (catch_syscall_inferior_data_cleanup): Remove.
10646 (_initialize_break_catch_syscall): Update.
10647
6509b8eb
TT		 106482019-05-08 Tom Tromey <tom@tromey.com>
10649
10650 * inflow.c (struct terminal_info): Add destructor and
10651 initializers.
10652 (inflow_inferior_data): Change type.
10653 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10654 (get_inflow_inferior_data, inflow_inferior_exit)
10655 (swap_terminal_info, _initialize_inflow): Update.
10656
35632941
TT		 106572019-05-08 Tom Tromey <tom@tromey.com>
10658
10659 * target-dcache.c (target_dcache_cleanup): Remove.
10660 (target_dcache_aspace_key): Change type.
10661 (target_dcache_init_p, target_dcache_invalidate)
10662 (target_dcache_get, target_dcache_get_or_init)
10663 (_initialize_target_dcache): Update.
10664 * dcache.h (struct dcache_deleter): New.
10665
3017b94d
TT		 106662019-05-08 Tom Tromey <tom@tromey.com>
10667
10668 * symtab.c (struct symbol_cache): Add destructor and
10669 initializers.
10670 (symbol_cache_key): Move. Change type.
10671 (make_symbol_cache, free_symbol_cache): Remove.
10672 (get_symbol_cache): Update.
10673 (symbol_cache_cleanup): Remove.
10674 (ALL_PSPACES, symbol_cache_flush)
10675 (maintenance_print_symbol_cache)
10676 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10677 Update.
10678
a32ad8c5
TT		 106792019-05-08 Tom Tromey <tom@tromey.com>
10680
10681 * symtab.c (struct main_info): Add destructor and initializers.
10682 (main_progspace_key): Move. Change type.
10683 (get_main_info): Update.
10684 (main_info_cleanup): Remove.
10685 (_initialize_symtab): Update.
10686
5f6e90a0
TT		 106872019-05-08 Tom Tromey <tom@tromey.com>
10688
10689 * registry.h (DECLARE_REGISTRY): Define the _key class.
10690
1bd0c6e4
AB		 106912019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10692
10693 * NEWS: Merge two 'New commands' sections.
10694
2228ef77
XR		 106952019-05-08 Joel Brobecker <brobecker@adacore.com>
10696
10697 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10698 parameter and use Ada language definition instead.
10699 (ada_val_print_ptr): Remove unused language parameter.
10700 (ada_val_print_num): Remove language parameter and use Ada language
10701 definition instead.
10702 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10703 parameter.
10704 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10705 parameter and use Ada language definition instead.
10706 (ada_val_print_1): Update all ada_val_print_xxx calls.
10707 Remove language parameter.
10708 (ada_val_print): Update ada_val_print_1 call.
10709
60fcc1c3
TT		 107102019-05-08 Tom Tromey <tromey@adacore.com>
10711
10712 * remote.c (remote_hw_watchpoint_limit)
10713 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10714 Now static.
10715
ed2b7c17
TT		 107162019-05-08 Tom Tromey <tromey@adacore.com>
10717
10718 * maint.c (_initialize_maint_cmds): Move initialization code to
10719 remote.c.
10720 (watchdog, show_watchdog): Move to remote.c.
10721 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10722 "watchdog" static.
10723 (_initialize_remote): Move initialization code from maint.c.
10724 * defs.h (watchdog): Don't declare.
10725
b0be6c91
TT		 107262019-05-08 Tom Tromey <tromey@adacore.com>
10727
10728 * tui/tui-interp.c: Include main.h.
10729 * interps.c: Include main.h.
10730 * main.h (interpreter_p): Declare.
10731 * defs.h (interpreter_p): Don't declare.
10732
587ee17b
TT		 107332019-05-08 Tom Tromey <tromey@adacore.com>
10734
10735 * dwarf2loc.c: Include dwarf2read.h.
10736 * defs.h (read_unsigned_leb128): Don't declare.
10737 * dwarf2read.h (read_unsigned_leb128): Declare.
10738
ca1df239
TT		 107392019-05-08 Tom Tromey <tromey@adacore.com>
10740
10741 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10742 method.
10743
99f20f08
TT		 107442019-05-08 Tom Tromey <tromey@adacore.com>
10745
10746 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10747 when no wrap column is set.
10748
80e55b13
TT		 107492019-05-08 Tom Tromey <tromey@adacore.com>
10750
10751 * c-lang.c (c_get_string): Handle non-C-style arrays.
10752
9d3421af
TT		 107532019-05-08 Tom Tromey <tromey@adacore.com>
10754
10755 * typeprint.c (print_offset_data::update): Print the bit offset,
10756 not the number of bits remaining.
10757
844333e2
TT		 107582019-05-08 Tom Tromey <tromey@adacore.com>
10759
10760 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10761 padding at end of comment.
10762
988915ee
TT		 107632019-05-08 Tom Tromey <tromey@adacore.com>
10764
10765 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10766 Compare main types.
10767
26bfd823
TT		 107682019-05-06 Tom Tromey <tom@tromey.com>
10769
10770 * common/scoped_mmap.c: Include common-defs.h.
10771 * common/scoped_mmap.h: Don't include config.h.
10772
89055eaa
TT		 107732019-05-04 Tom Tromey <tom@tromey.com>
10774
10775 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10776 (struct aarch64_call_info): Add initializers.
10777 <si>: Now a std::vector.
10778 (pass_on_stack, aarch64_push_dummy_call): Update.
10779
5da01df5
TT		 107802019-05-04 Simon Marchi <simon.marchi@efficios.com>
10781 Tom Tromey <tom@tromey.com>
10782
10783 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10784 (ppc_threads): Now a std::vector. Now static.
10785 (hwdebug_find_thread_points_by_tid)
10786 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10787 Update.
10788
fbdf05a1
TT		 107892019-05-04 Tom Tromey <tom@tromey.com>
10790
10791 * arc-tdep.c (arc_tdesc_init): Return bool.
10792
06d16ec9
TT		 107932019-05-04 Tom Tromey <tom@tromey.com>
10794
10795 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10796 Use gdb_assert_not_reached.
10797
9c056022
TT		 107982019-05-04 Tom Tromey <tom@tromey.com>
10799
10800 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10801 "false".
10802
fa9c2a59
TT		 108032019-05-04 Tom Tromey <tom@tromey.com>
10804
10805 * arc-tdep.c (arc_tdesc_init): Use bool.
10806
e2eb806a
TT		 108072019-05-04 Tom Tromey <tom@tromey.com>
10808
10809 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10810
6fe87677
TT		 108112019-05-04 Tom Tromey <tom@tromey.com>
10812
10813 * cli/cli-cmds.c (valid_command_p): Return bool.
10814
7f008c9e
TT		 108152019-05-04 Tom Tromey <tom@tromey.com>
10816
10817 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10818 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10819
b6484282
RT		 108202019-05-04 Raul Tambre <raul@tambre.ee>
10821
10822 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10823 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10824 operator for comparison.
10825
af97b416
TT		 108262019-05-04 Tom Tromey <tom@tromey.com>
10827
10828 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10829 (lookup_partial_symbol, print_partial_symbols)
10830 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10831 (psymbol_compare): Update.
10832 (add_psymbol_to_bcache): Clear the entire psymbol.
10833 (maintenance_check_psymtabs): Update.
10834 * psympriv.h (struct partial_symbol): Don't derive from
10835 general_symbol_info.
10836 <obj_section, unrelocated_address, address,
10837 set_unrelocated_address>: Update.
10838 <ginfo>: New member.
10839 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10840 (debug_names::write_psymbols): Update.
10841
9d6d4be8
TV		 108422019-05-04 Tom de Vries <tdevries@suse.de>
10843
10844 * contrib/cc-with-tweaks.sh: Support -n arg.
10845
66452beb
PW		 108462019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10847
10848 * corelow.c (core_target::detach): Ensure frame cache and
10849 register caches are cleared.
10850 inferior.c (exit_inferior_1): Likewise.
10851
bde09ab7
TT		 108522019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10853 Tom Tromey <tom@tromey.com>
10854
10855 * dictionary.c (collate_pending_symbols_by_language): Remove
10856 "struct" from foreach.
10857 * symtab.c (lookup_global_symbol_from_objfile)
10858 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10859 foreach.
10860 * ser-tcp.c (net_open): Remove "struct" from foreach.
10861 * objfiles.c (objfile_relocate, objfile_rebase)
10862 (objfile_has_symbols): Remove "struct" from foreach.
10863 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10864 from foreach.
10865 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10866 foreach.
10867 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10868 "struct" from foreach.
10869 * ada-lang.c (create_excep_cond_exprs)
10870 (ada_exception_catchpoint_cond_string): Remove "struct" from
10871 foreach.
10872
222a8d25
TT		 108732019-05-03 Tom Tromey <tromey@adacore.com>
10874
10875 * ada-exp.y (convert_char_literal): Check suffix of each
10876 enumerator.
10877
fcd60b84
DP		 108782019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10879
10880 PR ada/21406:
10881 * ada-exp.y (yywrap): Don't define.
10882 * ada-lex.l (%option): Add noyywrap
10883 (yywrap): Remove.
10884
5f2459c2
EZ		 108852019-05-03 Eli Zaretskii <eliz@gnu.org>
10886
353ea2d1
EZ		 10887 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10888 _WIN32_WINNT to the XP level, unless already defined to a higher
10889 level.
10890
10891 * unittests/parse-connection-spec-selftests.c:
10892 * ser-tcp.c:
10893 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10894 override.
10895
5f2459c2
EZ		 10896 * symfile.c (find_separate_debug_file): Remove colon from the
10897 drive spec of DOS/Windows file names of the target, so that the
10898 file name produced from DEBUGDIR and the target's directory will
10899 be valid on DOS/Windows systems.
10900
80062eb9
AB		 109012019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * rust-lang.c (val_print_struct): Handle printing structures
10904 containing strings.
10905
b8c05e85
TT		 109062019-05-02 Tom Tromey <tromey@adacore.com>
10907
10908 * valarith.c (_initialize_valarith): Remove.
10909
4504bbde
TT		 109102019-05-01 Tom Tromey <tromey@adacore.com>
10911
10912 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10913 bitfields.
10914
d48e62f4
TT		 109152019-05-01 Tom Tromey <tromey@adacore.com>
10916
10917 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10918 for big-endian copies.
10919
15f18d14
AT		 109202019-04-30 Ali Tamur <tamur@google.com>
10921 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10922 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10923 (read_3_bytes): New function.
10924
ab4ee614
JB		 109252019-04-30 Joel Brobecker <brobecker@adacore.com>
10926
10927 * windows-nat.c (main_thread_id): Delete.
10928 (handle_output_debug_string): Replace main_thread_id by
10929 current_event.dwThreadId.
10930 (fake_create_process): Likewise.
10931 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10932 Do not set main_thread_id.
10933 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10934 current_event.dwThreadId.
10935 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10936
8ed5b76e
JB		 109372019-04-30 Joel Brobecker <brobecker@adacore.com>
10938
10939 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10940 Use current_event.dwThreadId instead of main_thread_id.
10941
2ff0a947
TT		 109422019-04-30 Tom Tromey <tromey@adacore.com>
10943
10944 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10945 (create_excep_cond_exprs): Iterate over program spaces.
10946 (ada_exception_catchpoint_cond_string): Examine all minimal
10947 symbols for exception types.
10948
a776957c
TT		 109492019-04-30 Tom Tromey <tromey@adacore.com>
10950
10951 PR c++/24470:
10952 * dwarf2read.c (process_structure_scope): Handle case where type
10953 has template parameters but no symbol was created.
10954
bc68014d
AB		 109552019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10956 Chris January <chris.january@arm.com>
10957
10958 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10959 qualifier.
10960 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10961
f1fdc960
AB		 109622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10963
10964 * f-typeprint.c (f_print_type): Update rules for printing
10965 whitespace.
10966 (f_type_print_varspec_suffix): Likewise.
10967
bf7a4de1
AB		 109682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10969 Chris January <chris.january@arm.com>
10970
10971 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10972 function arguments.
10973
bbe75b9d
AB		 109742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10975
10976 * f-lang.c (build_fortran_types): Change name of void type to
10977 lower case.
10978 * f-typeprint.c (f_type_print_base): Print the name of the void
10979 type, rather than a fixed string.
10980 * f-valprint.c (f_decorations): Use lower case void string.
10981
1db455a7
AB		 109822019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10983 Chris January <chris.january@arm.com>
10984
10985 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10986 types for Fortran.
10987
b6d03bb2
AB		 109882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10989 Chris January <chris.january@arm.com>
10990 David Lecomber <david.lecomber@arm.com>
10991
10992 * f-exp.y (BINOP_INTRINSIC): New token.
10993 (exp): New parser rule handling BINOP_INTRINSIC.
10994 (f77_keywords): Add new builtin procedures.
10995 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10996 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10997 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10998 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10999 (print_unop_subexp_f): New function.
11000 (print_binop_subexp_f): New function.
11001 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11002 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11003 (dump_subexp_body_f): Likewise.
11004 (operator_check_f): Likewise.
11005 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11006 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11007
83228e93
AB		 110082019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11009
11010 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11011 UNOP_KIND.
11012 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11013 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11014 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11015 (operator_length_f): New fuction.
11016 (print_subexp_f): New function.
11017 (op_name_f): New function.
11018 (dump_subexp_body_f): New function.
11019 (operator_check_f): New function.
11020 (exp_descriptor_f): Replace standard expression handling functions
11021 with new functions.
11022 * gdb/fortran-operator.def: New file.
11023 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11024 * gdb/std-operator.def: Remove UNOP_KIND.
11025
6fdcd7cc
AB		 110262019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11027
11028 * std-operator.def: Remove unbalanced, stray double quote
11029 character.
11030
2e62ab40
AB		 110312019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11032 Chris January <chris.january@arm.com>
11033 Daniel Everett <daniel.everett@arm.com>
11034 Nick Forrington <nick.forrington@arm.com>
11035 Richard Bunt <richard.bunt@arm.com>
11036
11037 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11038 of depth when printing anonymous structs or unions.
11039 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11040 Don't print either the top-level value, or the children if the
11041 max-depth is exceeded.
11042 (ppscm_print_children): When printing the key of a map, allow one
11043 extra level of depth.
11044 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11045 print either the top-level value, or the children if the max-depth
11046 is exceeded.
11047 (print_children): When printing the key of a map, allow one extra
11048 level of depth.
11049 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11050 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11051 (user_print_options): Initialise max_depth field.
11052 (val_print_scalar_or_string_type_p): New function.
11053 (val_print): Check to see if the max depth has been reached.
11054 (val_print_check_max_depth): Define new function.
11055 (show_print_max_depth): New function.
11056 (_initialize_valprint): Add 'print max-depth' option.
11057 * valprint.h (struct value_print_options) <max_depth>: New field.
11058 (val_print_check_max_depth): Declare new function.
11059 * NEWS: Document new feature.
11060
4be290b2
AB		 110612019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11062
11063 * ada-lang.c (ada_language_defn): Initialise new field.
11064 * c-lang.c (c_is_string_type_p): New function.
11065 (c_language_defn): Initialise new field.
11066 (cplus_language_defn): Initialise new field.
11067 (asm_language_defn): Initialise new field.
11068 (minimal_language_defn): Initialise new field.
11069 * c-lang.h (c_is_string_type_p): Declare new function.
11070 * d-lang.c (d_language_defn): Initialise new field.
11071 * f-lang.c (f_is_string_type_p): New function.
11072 (f_language_defn): Initialise new field.
11073 * go-lang.c (go_is_string_type_p): New function.
11074 (go_language_defn): Initialise new field.
11075 * language.c (default_is_string_type_p): New function.
11076 (unknown_language_defn): Initialise new field.
11077 (auto_language_defn): Initialise new field.
11078 * language.h (struct language_defn) <la_is_string_type_p>: New
11079 member variable.
11080 (default_is_string_type_p): Declare new function.
11081 * m2-lang.c (m2_language_defn): Initialise new field.
11082 * objc-lang.c (objc_language_defn): Initialise new field.
11083 * opencl-lang.c (opencl_language_defn): Initialise new field.
11084 * p-lang.c (pascal_is_string_type_p): New function.
11085 (pascal_language_defn): Initialise new field.
11086 * rust-lang.c (rust_is_string_type_p): New function.
11087 (rust_language_defn): Initialise new field.
11088
721b08c6
AB		 110892019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11090
11091 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11092 New field.
11093 * ada-lang.c (ada_language_defn): Initialise new field.
11094 * c-lang.c (c_language_defn): Likewise.
11095 (cplus_language_defn): Likewise.
11096 (asm_language_defn): Likewise.
11097 (minimal_language_defn): Likewise.
11098 * d-lang.c (d_language_defn): Likewise.
11099 * f-lang.c (f_language_defn): Likewise.
11100 * go-lang.c (go_language_defn): Likewise.
11101 * language.c (unknown_language_defn): Likewise.
11102 (auto_language_defn): Likewise.
11103 * m2-lang.c (m2_language_defn): Likewise.
11104 * objc-lang.c (objc_language_defn): Likewise.
11105 * opencl-lang.c (opencl_language_defn): Likewise.
11106 * p-lang.c (pascal_language_defn): Likewise.
11107 * rust-lang.c (rust_language_defn): Likewise.
11108
fc913e53
AB		 111092019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11110
11111 * ada-lang.c (ada_is_character_type): Change return type to bool.
11112 (ada_is_string_type): Likewise.
11113 * ada-lang.h (ada_is_character_type): Update declaration
11114 (ada_is_string_type): Likewise.
11115
fa731fa0
PW		 111162019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11117
11118 Support style in 'frame|thread apply'
11119
11120 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11121 * record.c (record_start, record_stop): Update callers of
11122 execute_command_to_string with false.
11123 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11124 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11125 methods.
11126 (class string_file): New constructor with term_out parameter.
11127 Override methods term_out and can_emit_style_escape. New member
11128 term_out.
11129 (class stdio_file): Override can_emit_style_escape.
11130 (class tee_file): Override term_out and can_emit_style_escape.
11131 * utils.h (can_emit_style_escape): Remove.
11132 * utils.c (can_emit_style_escape): Likewise.
11133 Update all callers of can_emit_style_escape (SOMESTREAM) to
11134 SOMESTREAM->can_emit_style_escape.
11135 * source-cache.c (source_cache::get_source_lines): Likewise.
11136 * stack.c (frame_apply_command_count): Call execute_command_to_string
11137 passing the term_out characteristic of the current gdb_stdout.
11138 * thread.c (thr_try_catch_cmd): Likewise.
11139 * top.c (execute_command_to_string): pass term_out parameter
11140 to construct the string_file for the command output.
11141 * ui-file.c (term_cli_styling): New function (most code moved
11142 from utils.c can_emit_style_escape).
11143 (string_file::string_file, string_file::can_emit_style_escape,
11144 stdio_file::can_emit_style_escape, tee_file::term_out,
11145 tee_file::can_emit_style_escape): New functions.
11146
136afab8
PW		 111472019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11148
11149 * NEWS: Mention the new set|show may-call-functions.
11150 * infcall.c (may_call_functions_p): New variable.
11151 (show_may_call_functions_p): New function.
11152 (call_function_by_hand_dummy): Throws an error if not
11153 may-call-functions.
11154 (_initialize_infcall): Call add_setshow_boolean_cmd for
11155 may-call-functions.
11156
725cbb63
KS		 111572019-04-25 Keith Seitz <keiths@redhat.com>
11158
11159 PR c++/24367
11160 * cp-support.c (inspect_type): Don't attempt substitutions
11161 of symbol with the same name.
11162
3d1cbb78
TT		 111632019-04-25 Tom Tromey <tromey@adacore.com>
11164
11165 PR gdb/24475:
11166 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11167 static.
11168
94aeb44b
TT		 111692019-04-25 Tom Tromey <tromey@adacore.com>
11170
11171 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11172 rvalue reference.
11173 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11174 (gdb_xml_parser::parse): Use std::move.
11175 * python/python-internal.h (gdbpy_convert_exception): Take a const
11176 reference.
11177 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11178 std::move.
11179 * python/py-utils.c (gdbpy_convert_exception): Take a const
11180 reference.
11181 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11182 Use std::move.
11183 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11184 Use std::move.
11185 * mi/mi-main.c (mi_print_exception): Take a const reference.
11186 * main.c (handle_command_errors): Take a const reference.
11187 * linespec.c (parse_linespec): Use std::move.
11188 * infcall.c (run_inferior_call): Use std::move.
11189 (call_function_by_hand_dummy): Use std::move.
11190 * exec.c (try_open_exec_file): Use std::move.
11191 * exceptions.h (exception_print, exception_fprintf)
11192 (exception_print_same): Update.
11193 * exceptions.c (print_exception, exception_print)
11194 (exception_fprintf, exception_print_same): Change parameters to
11195 const reference.
11196 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11197 * common/new-op.c: Use std::move.
11198 * common/common-exceptions.h (struct gdb_exception): Add move
11199 constructor.
11200 (struct gdb_exception_error, struct gdb_exception_quit, struct
11201 gdb_quit_bad_alloc): Change constructor to move constructor.
11202 (throw_exception): Change parameter to rvalue reference.
11203 * common/common-exceptions.c (throw_exception): Take rvalue
11204 reference.
11205 * cli/cli-interp.c (safe_execute_command): Use std::move.
11206 * breakpoint.c (insert_bp_location, location_to_sals): Use
11207 std::move.
11208
680d7fd5
TT		 112092019-04-25 Tom Tromey <tromey@adacore.com>
11210
11211 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11212 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11213 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11214 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11215 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11216 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11217 guile/scm-value.c: Use unpack.
11218 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11219 gdbscm_gdb_exception.
11220 (gdbscm_throw_gdb_exception): Likewise.
11221 (struct gdbscm_gdb_exception): New.
11222 (unpack): New function.
11223 (gdbscm_wrap): Use unpack.
11224
c6fdd8b2
TT		 112252019-04-25 Tom Tromey <tromey@adacore.com>
11226
11227 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11228 (gdb_rl_callback_handler): Use std::move.
11229 * common/common-exceptions.h (struct gdb_exception): Add move
11230 assignment operator.
11231 (throw_exception_sjlj): Change "exception" to const reference.
11232 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11233 (throw_exception_sjlj): Change "exception" to const reference.
11234
cc06b668
TT		 112352019-04-25 Tom Tromey <tromey@adacore.com>
11236
11237 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11238 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11239 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11240 Update.
11241 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11242 Update.
11243 * mi/mi-interp.c (mi_interp::exec): Update.
11244 * linespec.c (parse_linespec): Update.
11245 * infcall.c (run_inferior_call): Update.
11246 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11247 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11248 (gdbscm_lookup_global_symbol): Update.
11249 * guile/scm-param.c (gdbscm_parameter_value): Update.
11250 * guile/scm-frame.c (gdbscm_frame_read_register)
11251 (gdbscm_frame_read_var): Update.
11252 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11253 * exec.c (try_open_exec_file): Update.
11254 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11255 (gdb_rl_callback_handler): Update.
11256 * common/common-exceptions.h (exception_none): Don't declare.
11257 * common/common-exceptions.c (exception_none): Don't define.
11258 (struct catcher) <exception>: Update.
11259 * cli/cli-interp.c (safe_execute_command): Update.
11260 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11261
cf532bd1
AT		 112622019-04-25 Ali Tamur <tamur@google.com>
11263
11264 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11265 (read_attribute_value): Likewise.
11266 (dwarf2_read_addr_index): Update comment.
11267 (read_str_index): Add DW_FORM_strx.
11268 (dwarf2_string_attr): Likewise.
11269 (dwarf2_const_value_attr): Likewise.
11270 (dump_die_shallow): Likewise.
11271 (dwarf2_fetch_constant_bytes): Likewise.
11272 (skip_form_bytes): Likewise.
11273 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11274
82433e3e
SDJ		 112752019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11276
11277 PR corefiles/11608
11278 PR corefiles/18187
11279 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11280 OFFSET. Verify if current mapping contains an ELF header.
11281 (linux_find_memory_regions_full): Adjust call to
11282 dump_mapping_p.
11283
723adb65
SL		 112842019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11285 Kang Li <kanglictf@gmail.com>
11286
11287 PR gdb/21600
11288
11289 * dwarf2-frame.c (read_initial_length): Be consistent about using
11290 unsigned representation of length.
11291 (decode_frame_entry_1): Likewise. Check for wraparound of
11292 end pointer as well as buffer overflow.
11293
596179f7
SDJ		 112942019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11295
11296 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11297 "vq".
11298
a59240a4
TT		 112992019-04-24 Tom Tromey <tromey@adacore.com>
11300
11301 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11302
f872fdbb
AB		 113032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11304
11305 * s12z-tdep.c (s12z_unwind_pc): Delete.
11306 (s12z_unwind_sp): Delete.
11307 (s12z_gdbarch_init): Don't register deleted functions with
11308 gdbarch.
11309
b614e6f3
AB		 113102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11311
11312 * rl78-tdep.c (rl78_unwind_sp): Delete.
11313 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11314
14faed38
AB		 113152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11316
11317 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11318 (xstormy16_unwind_pc): Delete.
11319 (xstormy16_dummy_id): Delete.
11320 (xstormy16_gdbarch_init): Don't register deleted functions with
11321 gdbarch.
11322
541aad8a
AB		 113232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11324
11325 * vax-tdep.c (vax_unwind_pc): Delete.
11326 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11327
29222070
AB		 113282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11329
11330 * v850-tdep.c (v850_unwind_sp): Delete.
11331 (v850_unwind_pc): Delete.
11332 (v850_dummy_id): Delete.
11333 (v850_gdbarch_init): Don't register deleted functions with
11334 gdbarch.
11335
0f534d76
AB		 113362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11337
11338 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11339 (tilegx_unwind_pc): Delete.
11340 (tilegx_unwind_dummy_id): Delete.
11341 (tilegx_gdbarch_init): Don't register deleted functions with
11342 gdbarch.
11343
1ba7b7f9
AB		 113442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11345
11346 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11347 (tic6x_dummy_id): Delete.
11348 (tic6x_gdbarch_init): Don't register deleted functions with
11349 gdbarch.
11350
d31f262c
AB		 113512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11352
11353 * sparc-tdep.c (sparc_unwind_pc): Delete.
11354 (sparc32_gdbarch_init): Don't register deleted function with
11355 gdbarch.
11356
6d14d64d
AB		 113572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11358
11359 * sh-tdep.c (sh_unwind_sp): Delete.
11360 (sh_unwind_pc): Delete.
11361 (sh_dummy_id): Delete.
11362 (sh_gdbarch_init): Don't register deleted functions with
11363 gdbarch.
11364
a40dde9d
AB		 113652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11366
11367 * score-tdep.c (score_unwind_sp): Delete.
11368 (score_unwind_pc): Delete.
11369 (score_dummy_id): Delete.
11370 (score_gdbarch_init): Don't register deleted functions with
11371 gdbarch.
11372
47c47d69
AB		 113732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11374
11375 * rx-tdep.c (rx_unwind_pc): Delete.
11376 (rx_unwind_sp): Delete.
11377 (rx_dummy_id): Delete.
11378 (rx_gdbarch_init): Don't register deleted functions with
11379 gdbarch. Update comment.
11380
833a4480
AB		 113812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11382
11383 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11384 (rs6000_dummy_id): Delete.
11385 (rs6000_gdbarch_init): Don't register deleted functions with
11386 gdbarch.
11387
3f2cef49
AB		 113882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11389
11390 * or1k-tdep.c (or1k_dummy_id): Delete.
11391 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11392
96acf884
AB		 113932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11394
11395 * nios2-tdep.c (nios2_dummy_id): Delete.
11396 (nios2_unwind_sp): Delete.
11397 (nios2_gdbarch_init): Don't register deleted functions with
11398 gdbarch.
11399
ca0ab0aa
AB		 114002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11401
11402 * nds32-tdep.c (nds32_dummy_id): Delete.
11403 (nds32_unwind_pc): Delete.
11404 (nds32_unwind_sp): Delete.
11405 (nds32_gdbarch_init): Don't register deleted functions with
11406 gdbarch.
11407
c8259044
AB		 114082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11409
11410 * msp430-tdep.c (msp430_unwind_pc): Delete.
11411 (msp430_unwind_sp): Delete.
11412 (msp430_dummy_id): Delete.
11413 (msp430_gdbarch_init): Don't register deleted functions with
11414 gdbarch.
11415
27f113c8
AB		 114162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11417
11418 * moxie-tdep.c (moxie_unwind_sp): Delete.
11419 (moxie_unwind_pc): Delete.
11420 (moxie_dummy_id): Delete.
11421 (moxie_gdbarch_init): Don't register deleted functions with
11422 gdbarch.
11423
aee6c3cd
AB		 114242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11425
11426 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11427 (mn10300_unwind_pc): Delete.
11428 (mn10300_unwind_sp): Delete.
11429 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11430 mn10300_unwind_sp.
11431 (mn10300_frame_unwind_init): Don't register deleted functions with
11432 gdbarch.
11433
8e2b5aea
AB		 114342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11435
11436 * mep-tdep.c (mep_unwind_pc): Delete.
11437 (mep_unwind_sp): Delete.
11438 (mep_dummy_id): Delete.
11439 (mep_gdbarch_init): Don't register deleted functions with
11440 gdbarch.
11441
43cf3ede
AB		 114422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11443
11444 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11445 (m68hc11_unwind_sp): Delete.
11446 (m68hc11_gdbarch_init): Don't register deleted functions with
11447 gdbarch.
11448
5e79b7bb
AB		 114492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11450
11451 * m32r-tdep.c (m32r_unwind_sp): Delete.
11452 (m32r_unwind_pc): Delete.
11453 (m32r_dummy_id): Delete.
11454 (m32r_gdbarch_init): Don't register deleted functions with
11455 gdbarch.
11456
89b268d8
AB		 114572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11458
11459 * m32c-tdep.c (m32c_unwind_pc): Delete.
11460 (m32c_unwind_sp): Delete.
11461 (m32c_dummy_id): Delete.
11462 (m32c_gdbarch_init): Don't register deleted functions with
11463 gdbarch.
11464
946c28d2
AB		 114652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11466
11467 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11468 (lm32_unwind_pc): Delete.
11469 (lm32_dummy_id): Delete.
11470 (lm32_gdbarch_init): Don't register deleted functions with
11471 gdbarch.
11472
bf12844a
AB		 114732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11474
11475 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11476 (iq2000_unwind_pc): Delete.
11477 (iq2000_dummy_id): Delete.
11478 (iq2000_gdbarch_init): Don't register deleted functions with
11479 gdbarch.
11480
ecbc06d2
AB		 114812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11482
11483 * nds32-tdep.c (nds32_type_align): Delete.
11484 (nds32_push_dummy_call): Use type_align instead.
11485
030197b4
AB		 114862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11487
11488 * arm-tdep.c (arm_type_align): Only handle vector override case.
11489 (arm_push_dummy_call): Use type_align.
11490 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11491
b907456c
AB		 114922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11493
11494 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11495 case.
11496 (pass_on_stack): Use type_align.
11497 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11498 function.
11499
9e97ba43
TT		 115002019-04-23 Tom Tromey <tromey@adacore.com>
11501
11502 * dwarf2read.c (line_header::file_name_at): Remove unused
11503 overload.
11504
6892f601
TV		 115052019-04-23 Tom de Vries <tdevries@suse.de>
11506
11507 PR gdb/24438
11508 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11509 invocation.
11510
336d760d
AT		 11511
115122019-03-27 Ali Tamur <tamur@google.com>
11513
11514 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11515 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11516 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11517 (dwarf_expr_context::get_addr_index): Likewise
11518 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11519 (symbol_needs_eval_context::get_addr_index): Likewise
11520 (disassemble_dwarf_expression): Add DW_OP_addrx
11521 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11522 (read_cutu_die_from_dwo): Update comment
11523 (skip_one_die): Add DW_FORM_addrx
11524 (read_attribute_value): Likewise
11525 (var_decode_location): Add DW_OP_addrx
11526 (dwarf2_const_value_attr): Add DW_FORM_addrx
11527 (dump_die_shallow): Likewise
11528 (dwarf2_fetch_constant_bytes): Likewise
11529 (decode_locdesc): Add DW_OP_addrx
11530 (skip_form_bytes): Add DW_FORM_addrx
11531
ad9d13f8
AT		 115322019-04-22 Ali Tamur <tamur@google.com>
11533
11534 * MAINTAINERS (Write After Approval): Add self.
11535
d70cc3ba
SM		 115362019-04-22 Simon Marchi <simon.marchi@efficios.com>
11537
11538 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11539 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11540 (open_symbol_file_object): Likewise.
11541 (svr4_default_sos): Add info parameter.
11542 (svr4_read_so_list): Likewise.
11543 (svr4_current_sos_direct): Adjust functions calls to pass down
11544 info.
11545 (svr4_current_sos_1): Add info parameter.
11546 (svr4_current_sos): Call get_svr4_info, pass info down to
11547 svr4_current_sos_1.
11548 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11549 get_svr4_info.
11550 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11551 get_svr4_info.
11552 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11553 to get_svr4_info.
11554 (probes_table_remove_objfile_probes): Likewise.
11555 (register_solib_event_probe): Add info parameter.
11556 (solist_update_incremental): Pass info parameter down to
11557 svr4_read_so_list.
11558 (disable_probes_interface): Add info parameter.
11559 (svr4_handle_solib_event): Pass current_program_space to
11560 get_svr4_info. Adjust disable_probes_interface cleanup.
11561 (svr4_create_probe_breakpoints): Add info parameter, pass it
11562 down to register_solib_event_probe.
11563 (svr4_create_solib_event_breakpoints): Add info parameter,
11564 pass it down to svr4_create_probe_breakpoints.
11565 (enable_break): Pass info down to
11566 svr4_create_solib_event_breakpoints.
11567 (svr4_solib_create_inferior_hook): Pass current_program_space to
11568 get_svr4_info.
11569 (svr4_clear_solib): Likewise.
11570
7905fc35
PA		 115712019-04-22 Pedro Alves <palves@redhat.com>
11572
11573 * solib-svr4.c (svr4_free_objfile_observer): New.
11574 (probe_and_action::objfile): New field.
11575 (probes_table_htab_remove_objfile_probes)
11576 (probes_table_remove_objfile_probes): New functions.
11577 (register_solib_event_probe): Add 'objfile' parameter. Store it
11578 in the new probe_and_action. Don't store the probe in 'lookup'.
11579 (svr4_create_probe_breakpoints): Pass objfile to
11580 register_solib_event_probe.
11581 (_initialize_svr4_solib): Register a free_objfile observer.
11582
fb881986
TT		 115832019-04-19 Tom Tromey <tom@tromey.com>
11584
11585 * common/queue.h: Remove.
11586
8732db6c
TT		 115872019-04-19 Tom Tromey <tom@tromey.com>
11588
11589 * event-loop.c: Don't include "common/queue.h".
11590
97dfbadd
TT		 115912019-04-19 Tom Tromey <tom@tromey.com>
11592
11593 * remote.c (remote_target): Use delete.
11594 * remote-notif.h: Include <list>, not "common/queue.h".
11595 (notif_client_p): Remove typedef.
11596 (remote_notif_state): Add constructor, destructor, initializer.
11597 <notif_queue>: Now a std::list.
11598 (remote_notif_state_xfree): Don't declare.
11599 * remote-notif.c (remote_notif_process, handle_notification)
11600 (remote_notif_state_allocate): Update.
11601 (~remote_notif_state): Rename from remote_notif_state_xfree.
11602
cf250e36
TT		 116032019-04-19 Tom Tromey <tom@tromey.com>
11604
11605 * symfile.c (reread_symbols): Update.
11606 * objfiles.c (objfile_register_static_link)
11607 (objfile_lookup_static_link): Update
11608 (~objfile) Don't delete static_links.
11609 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11610
61f4b350
TT		 116112019-04-19 Tom Tromey <tom@tromey.com>
11612
11613 * type-stack.h (struct type_stack) <insert>: Constify string.
11614 * type-stack.c (type_stack::insert): Constify string.
11615 * gdbtypes.h (lookup_template_type): Update.
11616 (address_space_name_to_int): Update.
11617 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11618 const.
11619 (lookup_template_type): Make name const.
11620 * c-exp.y: Update rules.
11621 (lex_one_token, classify_name, classify_inner_name)
11622 (c_print_token): Update.
11623 * p-exp.y: Update rules.
11624 (yylex): Update.
11625 * f-exp.y: Update rules.
11626 (yylex): Update.
11627 * d-exp.y: Update rules.
11628 (lex_one_token, classify_name, classify_inner_name): Update.
11629 * parse.c (write_dollar_variable, copy_name): Return std::string.
11630 * parser-defs.h (copy_name): Change return type.
11631 * m2-exp.y: Update rules.
11632 (yylex): Update.
11633 * go-exp.y (lex_one_token): Update.
11634 Update rules.
11635 (classify_unsafe_function, classify_packaged_name)
11636 (classify_name, yylex): Update.
11637
189b8c2e
ST		 116382019-04-19 Sergei Trofimovich <siarheit@google.com>
11639
11640 * configure.ac: add --enable-source-highlight switch.
11641 * configure: Regenerate.
11642 * top.c (print_gdb_version): plumb --enable-source-highlight
11643 status to "show configuration".
11644
8ecb59f8
TT		 116452019-04-19 Tom Tromey <tromey@adacore.com>
11646
11647 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11648 Check ADA_TYPE_P.
11649 (empty_record, ada_template_to_fixed_record_type_1)
11650 (template_to_static_fixed_type)
11651 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11652 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11653 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11654 macros.
11655
62160ec9
TT		 116562019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11657
11658 PR symtab/24423:
11659 * source.c (print_source_lines_base): Advance "iter" when a
11660 control character is seen.
11661
f2ae8bc8
PW		 116622019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11663
11664 * inferior.h (struct infcall_suspend_state_deleter):
11665 Catch exception in destructor to avoid crash.
11666
d563b953
PW		 116672019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11668
11669 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11670 close to the add_com "shell".
11671
dc34c897
TT		 116722019-04-18 Tom Tromey <tromey@adacore.com>
11673
11674 * process-stratum-target.h (class process_stratum_target)
11675 <stratum>: Add "final".
11676
a12e5744
TT		 116772019-04-17 Tom Tromey <tromey@adacore.com>
11678
11679 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11680 against nullptr before use.
11681
a7e559cc
AH		 116822019-04-17 Alan Hayward <alan.hayward@arm.com>
11683
11684 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11685
c01660c6
AB		 116862019-04-17 Jim Wilson <jimw@sifive.com>
11687 Andrew Burgess <andrew.burgess@embecosm.com>
11688
11689 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11690 code read might fail, assume 4-byte breakpoint in that case.
11691
4aa866af
LS		 116922019-04-15 Leszek Swirski <leszeks@google.com>
11693
11694 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11695 rather than a hand-rolled POD check when checking for forced MEMORY
11696 classification.
11697
48574d91
AH		 116982019-04-15 Alan Hayward <alan.hayward@arm.com>
11699
11700 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11701 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11702 function.
11703 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11704 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11705 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11706 declaration.
11707
4da037ef
AH		 117082019-04-15 Alan Hayward <alan.hayward@arm.com>
11709
11710 * aarch64-linux-nat.c
11711 (aarch64_linux_nat_target::thread_architecture): Add override.
11712 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11713 each VQ.
11714
ccb8d7e8
AH		 117152019-04-15 Alan Hayward <alan.hayward@arm.com>
11716
11717 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11718
35add35e
AB		 117192019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11720
11721 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11722 target types of size 96-bits, add some additional comments, and
11723 check that the builtin type we found was the correct size.
11724
51196bbc
EZ		 117252019-04-12 Eli Zaretskii <eliz@gnu.org>
11726
11727 * utils.c (prompt_for_continue): Don't restore the styling at the
11728 end, as applied_style has the wrong value. This fixes styling in
11729 long lists of file names that are interrupted by the "Continue?"
11730 prompt.
11731
62253a61
AB		 117322019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11733
11734 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11735 * c-lang.c (c_language_defn): Likewise.
11736 (cplus_language_defn): Likewise.
11737 (asm_language_defn): Likewise.
11738 (minimal_language_defn): Likewise.
11739 * d-lang.c (d_language_defn): Likewise.
11740 * f-lang.c (f_language_defn): Likewise.
11741 * go-lang.c (go_language_defn): Likewise.
11742 * language.c (unknown_language_defn): Likewise.
11743 (auto_language_defn): Likewise.
11744 * language.h (struct language_defn): Remove la_magic field.
11745 (LANG_MAGIC): Delete.
11746 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11747 * objc-lang.c (objc_language_defn): Likewise.
11748 * opencl-lang.c (opencl_language_defn): Likewise.
11749 * p-lang.c (pascal_language_defn): Likewise.
11750 * rust-lang.c (rust_language_defn): Likewise.
11751
a9158a86
AB		 117522019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11753
11754 * riscv-tdep.c (riscv_type_align): New function.
11755 (riscv_type_alignment): Delete.
11756 (riscv_arg_location): Use 'type_align'.
11757 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11758
41077b66
AB		 117592019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11760
11761 * gdbtypes.c (type_align): A struct with no non-static fields also
11762 has alignment of 1.
11763
9f0272f8
AB		 117642019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11765
11766 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11767 component to 0.
11768 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11769 member.
11770 (riscv_struct_info::analyse): New implementation using new
11771 analyse_inner member function.
11772 (riscv_struct_info::field_offset): New member function.
11773 (riscv_struct_info::m_offsets): New member variable.
11774 (riscv_struct_info::analyse_inner): New private member function,
11775 takes the old implementation of riscv_struct_info::analyse but
11776 extended to track field offsets.
11777 (riscv_call_arg_struct): Update the struct folding special cases
11778 to handle cases where empty C++ structs, which are non-zero
11779 length, are found.
11780 (riscv_arg_location): Initialise the length of each location, a
11781 non-zero length now indicates the location is in use.
11782 (riscv_push_dummy_call): Allow for the first location having a
11783 non-zero offset when setting up arguments.
11784 (riscv_return_value): Likewise, but for return values.
11785
02cf60c7
TT		 117862019-04-11 Tom Tromey <tromey@adacore.com>
11787
11788 * utils.c (internal_vproblem): Make "msg" const.
11789
68811f8f
AH		 117902019-04-11 Alan Hayward <alan.hayward@arm.com>
11791
11792 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11793 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11794 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11795 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11796
3f52fdbc
KB		 117972019-04-10 Kevin Buettner <kevinb@redhat.com>
11798
11799 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11800 function.
11801 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11802 of amd64_collect_native_gregset.
11803 (amd64_linux_nat_target::store_registers): Likewise.
11804
e9ad22ee
TT		 118052019-04-10 Tom Tromey <tom@tromey.com>
11806
11807 * symtab.c (lookup_global_symbol_from_objfile)
11808 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11809 * objfiles.h (class separate_debug_iterator): New.
11810 (class separate_debug_range): New.
11811 (struct objfile) <separate_debug_objfiles>: New method.
11812 (objfile_separate_debug_iterate): Don't declare.
11813 * objfiles.c (separate_debug_iterator::operator++): Rename from
11814 objfile_separate_debug_iterate.
11815 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11816 iterator.
11817 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11818 iterator.
11819
ee371134
TT		 118202019-04-10 Tom Tromey <tom@tromey.com>
11821
11822 * symfile.c (reread_symbols): Remove old comment.
11823 * objfiles.c (free_all_objfiles): Fix a typo.
11824
bf227d61
TT		 118252019-04-10 Tom Tromey <tom@tromey.com>
11826
11827 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11828 * minsyms.c (lookup_minimal_symbol): Use foreach.
11829 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11830 (lookup_minimal_symbol_solib_trampoline): Likewise.
11831 * symfile.c (reread_symbols): Use foreach.
11832
8dc433a0
TT		 118332019-04-09 Ivan Begert <ivanbegert@gmail.com>
11834 Tom Tromey <tromey@adacore.com>
11835
11836 PR rust/24414:
11837 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11838 (rust_lex_int_test): Change "value" to be LONGEST.
11839 (rust_lex_tests): Add test for long integer literal.
11840
9ab8741a
TT		 118412019-04-09 Tom Tromey <tromey@adacore.com>
11842
11843 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11844 to bool.
11845 (extended_remote_target::attach): Update.
11846 (remote_target::remote_notice_new_inferior): Update.
11847 (remote_target::add_current_inferior_and_thread): Update.
11848 * inferior.c (exit_inferior_1): Use "false".
11849 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11850
e242fd12
SM		 118512019-04-09 Simon Marchi <simon.marchi@efficios.com>
11852
9ca1957f 11853 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11854 the "start" command.
11855
2b0c8b01
KB		 118562019-04-08 Kevin Buettner <kevinb@redhat.com>
11857
11858 * python/py-inferior.c (infpy_thread_from_thread_handle):
11859 Adjust comments to reflect renaming of thread_from_thread_handle
11860 to thread_from_handle. Adjust keywords. Fix type error message.
11861 (inferior_object_methods): Add thread_from_handle. Retain
11862 thread_from_thread_handle, but mark it as deprecated.
11863
50a82723
KB		 118642019-04-08 Kevin Buettner <kevinb@redhat.com>
11865
11866 * gdbthread.h (find_thread_by_handle): Revise declaration.
11867 * thread.c (find_thread_by_handle): Likewise. Adjust
11868 implementation too.
11869 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11870 support for buffer objects as handles.
11871
cf63b016
KB		 118722019-04-08 Kevin Buettner <kevinb@redhat.com>
11873
11874 * python/py-infthread.c (thpy_thread_handle): New function.
11875 (thread_object_methods): Register thpy_thread_handle.
11876
3d6c6204
KB		 118772019-04-08 Kevin Buettner <kevinb@redhat.com>
11878
11879 * gdbthread.h (thread_to_thread_handle): Declare.
11880 * thread.c (gdbtypes.h): Include.
11881 (thread_to_thread_handle): New function.
11882
11883 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11884 (target_thread_info_to_thread_handle): Declare.
11885 * target.c (target_thread_info_to_thread_handle): New function.
11886 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11887 * target-delegates.c: Regenerate.
11888
11889 * linux-thread-db.c (class thread_db_target): Add method
11890 thread_info_to_thread_handle.
11891 (thread_db_target::thread_info_to_thread_handle): Define.
11892 * remote.c (class remote_target): Add new method
11893 thread_info_to_thread_handle.
11894 (remote_target::thread_info_to_thread_handle): Define.
11895
56be6ea8
PA		 118962019-04-08 Pedro Alves <palves@redhat.com>
11897
11898 * common/common-exceptions.c (throw_exception): Don't create
11899 named object to throw; throw directly.
11900 (throw_it): Likewise. Don't initialize gdb_exception::message
11901 here, with new; pass FMT and AP to the ctor instead.
11902 * common/common-exceptions.h: Include <string>.
11903 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11904 const char *, va_list)): New ctor. Use std::make_shared.
11905 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11906 errors)): Delete.
11907 (gdb_exception_error::gdb_exception_error(enum errors, const char
11908 *, va_list)): New.
11909 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11910 Add assertion.
11911 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11912 errors)): Delete.
11913 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11914 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11915 Add assertion.
11916
eedc3f4f
TT		 119172019-04-08 Tom Tromey <tom@tromey.com>
11918
11919 * valops.c (value_rtti_indirect_type): Replace throw_exception
11920 with throw.
11921 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11922 with throw.
11923 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11924 throw.
11925 * target.c (target_translate_tls_address): Replace throw_exception
11926 with throw.
11927 * stack.c (frame_apply_command_count): Replace throw_exception
11928 with throw.
11929 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11930 throw.
11931 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11932 with throw.
11933 * rs6000-tdep.c (rs6000_frame_cache)
11934 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11935 * remote.c: Replace throw_exception with throw.
11936 * record-full.c (record_full_message, record_full_wait_1)
11937 (record_full_restore): Replace throw_exception with throw.
11938 * record-btrace.c:
11939 (get_thread_current_frame_id, record_btrace_start_replaying)
11940 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11941 (cmd_record_btrace_start): Replace throw_exception with throw.
11942 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11943 throw.
11944 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11945 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11946 * linespec.c:
11947 (find_linespec_symbols): Replace throw_exception with throw.
11948 * infrun.c (displaced_step_prepare, resume): Replace
11949 throw_exception with throw.
11950 * infcmd.c (post_create_inferior): Replace throw_exception with
11951 throw.
11952 * inf-loop.c (inferior_event_handler): Replace throw_exception
11953 with throw.
11954 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11955 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11956 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11957 (get_prev_frame_always, get_frame_pc_if_available)
11958 (get_frame_address_in_block_if_available, get_frame_language):
11959 Replace throw_exception with throw.
11960 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11961 throw_exception with throw.
11962 * eval.c (fetch_subexp_value, evaluate_var_value)
11963 (evaluate_funcall, evaluate_subexp_standard): Replace
11964 throw_exception with throw.
11965 * dwarf2loc.c (call_site_find_chain)
11966 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11967 Replace throw_exception with throw.
11968 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11969 with throw.
11970 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11971 throw.
11972 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11973 * completer.c (complete_line_internal): Replace throw_exception
11974 with throw.
11975 * compile/compile-object-run.c (compile_object_run): Replace
11976 throw_exception with throw.
11977 * cli/cli-script.c (process_next_line): Replace throw_exception
11978 with throw.
11979 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11980 (btrace_enable, btrace_maint_update_pt_packets): Replace
11981 throw_exception with throw.
11982 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11983 throw_exception with throw.
11984 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11985 throw_exception with throw.
11986 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11987 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11988 * aarch64-tdep.c (aarch64_make_prologue_cache)
11989 (aarch64_make_stub_cache): Replace throw_exception with throw.
11990
26003a20
TT		 119912019-04-08 Tom Tromey <tom@tromey.com>
11992
11993 * common/common-exceptions.c (throw_exception): Rename from
11994 throw_exception_cxx. Remove old copy. Make argument const.
11995 (throw_it): Create and throw exception objects directly.
11996 * common/common-exceptions.h (throw_exception): Make argument
11997 const.
11998 (struct gdb_exception_error): Add constructor.
11999 (struct gdb_exception_quit): Add constructor.
12000
d272eb37
TT		 120012019-04-08 Tom Tromey <tom@tromey.com>
12002
12003 * common/common-exceptions.h (exception_rethrow): Don't declare.
12004 (TRY_SJLJ): Update comment.
12005 (TRY, CATCH, END_CATCH): Remove.
12006 * common/common-exceptions.c (exception_rethrow): Remove.
12007
230d2906
TT		 120082019-04-08 Tom Tromey <tom@tromey.com>
12009
12010 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12011 Remove.
12012 (gdb_exception_error): Rename from
12013 gdb_exception_RETURN_MASK_ERROR.
12014 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12015 (gdb_quit_bad_alloc): Update.
12016 * aarch64-tdep.c: Update.
12017 * ada-lang.c: Update.
12018 * ada-typeprint.c: Update.
12019 * ada-valprint.c: Update.
12020 * amd64-tdep.c: Update.
12021 * arch-utils.c: Update.
12022 * break-catch-throw.c: Update.
12023 * breakpoint.c: Update.
12024 * btrace.c: Update.
12025 * c-varobj.c: Update.
12026 * cli/cli-cmds.c: Update.
12027 * cli/cli-interp.c: Update.
12028 * cli/cli-script.c: Update.
12029 * common/common-exceptions.c: Update.
12030 * common/new-op.c: Update.
12031 * common/selftest.c: Update.
12032 * compile/compile-c-symbols.c: Update.
12033 * compile/compile-cplus-symbols.c: Update.
12034 * compile/compile-object-load.c: Update.
12035 * compile/compile-object-run.c: Update.
12036 * completer.c: Update.
12037 * corelow.c: Update.
12038 * cp-abi.c: Update.
12039 * cp-support.c: Update.
12040 * cp-valprint.c: Update.
12041 * darwin-nat.c: Update.
12042 * disasm-selftests.c: Update.
12043 * dtrace-probe.c: Update.
12044 * dwarf-index-cache.c: Update.
12045 * dwarf-index-write.c: Update.
12046 * dwarf2-frame-tailcall.c: Update.
12047 * dwarf2-frame.c: Update.
12048 * dwarf2loc.c: Update.
12049 * dwarf2read.c: Update.
12050 * eval.c: Update.
12051 * event-loop.c: Update.
12052 * event-top.c: Update.
12053 * exec.c: Update.
12054 * f-valprint.c: Update.
12055 * fbsd-tdep.c: Update.
12056 * frame-unwind.c: Update.
12057 * frame.c: Update.
12058 * gdbtypes.c: Update.
12059 * gnu-v3-abi.c: Update.
12060 * guile/guile-internal.h: Update.
12061 * guile/scm-block.c: Update.
12062 * guile/scm-breakpoint.c: Update.
12063 * guile/scm-cmd.c: Update.
12064 * guile/scm-disasm.c: Update.
12065 * guile/scm-frame.c: Update.
12066 * guile/scm-lazy-string.c: Update.
12067 * guile/scm-math.c: Update.
12068 * guile/scm-param.c: Update.
12069 * guile/scm-ports.c: Update.
12070 * guile/scm-pretty-print.c: Update.
12071 * guile/scm-symbol.c: Update.
12072 * guile/scm-symtab.c: Update.
12073 * guile/scm-type.c: Update.
12074 * guile/scm-value.c: Update.
12075 * i386-linux-tdep.c: Update.
12076 * i386-tdep.c: Update.
12077 * inf-loop.c: Update.
12078 * infcall.c: Update.
12079 * infcmd.c: Update.
12080 * infrun.c: Update.
12081 * jit.c: Update.
12082 * language.c: Update.
12083 * linespec.c: Update.
12084 * linux-fork.c: Update.
12085 * linux-nat.c: Update.
12086 * linux-tdep.c: Update.
12087 * linux-thread-db.c: Update.
12088 * main.c: Update.
12089 * mi/mi-cmd-break.c: Update.
12090 * mi/mi-cmd-stack.c: Update.
12091 * mi/mi-interp.c: Update.
12092 * mi/mi-main.c: Update.
12093 * objc-lang.c: Update.
12094 * p-valprint.c: Update.
12095 * parse.c: Update.
12096 * ppc-linux-tdep.c: Update.
12097 * printcmd.c: Update.
12098 * python/py-arch.c: Update.
12099 * python/py-breakpoint.c: Update.
12100 * python/py-cmd.c: Update.
12101 * python/py-finishbreakpoint.c: Update.
12102 * python/py-frame.c: Update.
12103 * python/py-framefilter.c: Update.
12104 * python/py-gdb-readline.c: Update.
12105 * python/py-inferior.c: Update.
12106 * python/py-infthread.c: Update.
12107 * python/py-lazy-string.c: Update.
12108 * python/py-linetable.c: Update.
12109 * python/py-objfile.c: Update.
12110 * python/py-param.c: Update.
12111 * python/py-prettyprint.c: Update.
12112 * python/py-progspace.c: Update.
12113 * python/py-record-btrace.c: Update.
12114 * python/py-record.c: Update.
12115 * python/py-symbol.c: Update.
12116 * python/py-type.c: Update.
12117 * python/py-unwind.c: Update.
12118 * python/py-utils.c: Update.
12119 * python/py-value.c: Update.
12120 * python/python.c: Update.
12121 * record-btrace.c: Update.
12122 * record-full.c: Update.
12123 * remote-fileio.c: Update.
12124 * remote.c: Update.
12125 * riscv-tdep.c: Update.
12126 * rs6000-aix-tdep.c: Update.
12127 * rs6000-tdep.c: Update.
12128 * rust-exp.y: Update.
12129 * rust-lang.c: Update.
12130 * s390-tdep.c: Update.
12131 * selftest-arch.c: Update.
12132 * solib-dsbt.c: Update.
12133 * solib-frv.c: Update.
12134 * solib-spu.c: Update.
12135 * solib-svr4.c: Update.
12136 * solib.c: Update.
12137 * sparc64-linux-tdep.c: Update.
12138 * stack.c: Update.
12139 * symfile-mem.c: Update.
12140 * symmisc.c: Update.
12141 * target.c: Update.
12142 * thread.c: Update.
12143 * top.c: Update.
12144 * tracefile-tfile.c: Update.
12145 * tui/tui.c: Update.
12146 * typeprint.c: Update.
12147 * unittests/cli-utils-selftests.c: Update.
12148 * unittests/parse-connection-spec-selftests.c: Update.
12149 * valops.c: Update.
12150 * valprint.c: Update.
12151 * value.c: Update.
12152 * varobj.c: Update.
12153 * windows-nat.c: Update.
12154 * x86-linux-nat.c: Update.
12155 * xml-support.c: Update.
12156
a70b8144
TT		 121572019-04-08 Tom Tromey <tom@tromey.com>
12158
12159 * xml-support.c: Use C++ exception handling.
12160 * x86-linux-nat.c: Use C++ exception handling.
12161 * windows-nat.c: Use C++ exception handling.
12162 * varobj.c: Use C++ exception handling.
12163 * value.c: Use C++ exception handling.
12164 * valprint.c: Use C++ exception handling.
12165 * valops.c: Use C++ exception handling.
12166 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12167 handling.
12168 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12169 * typeprint.c: Use C++ exception handling.
12170 * tui/tui.c: Use C++ exception handling.
12171 * tracefile-tfile.c: Use C++ exception handling.
12172 * top.c: Use C++ exception handling.
12173 * thread.c: Use C++ exception handling.
12174 * target.c: Use C++ exception handling.
12175 * symmisc.c: Use C++ exception handling.
12176 * symfile-mem.c: Use C++ exception handling.
12177 * stack.c: Use C++ exception handling.
12178 * sparc64-linux-tdep.c: Use C++ exception handling.
12179 * solib.c: Use C++ exception handling.
12180 * solib-svr4.c: Use C++ exception handling.
12181 * solib-spu.c: Use C++ exception handling.
12182 * solib-frv.c: Use C++ exception handling.
12183 * solib-dsbt.c: Use C++ exception handling.
12184 * selftest-arch.c: Use C++ exception handling.
12185 * s390-tdep.c: Use C++ exception handling.
12186 * rust-lang.c: Use C++ exception handling.
12187 * rust-exp.y: Use C++ exception handling.
12188 * rs6000-tdep.c: Use C++ exception handling.
12189 * rs6000-aix-tdep.c: Use C++ exception handling.
12190 * riscv-tdep.c: Use C++ exception handling.
12191 * remote.c: Use C++ exception handling.
12192 * remote-fileio.c: Use C++ exception handling.
12193 * record-full.c: Use C++ exception handling.
12194 * record-btrace.c: Use C++ exception handling.
12195 * python/python.c: Use C++ exception handling.
12196 * python/py-value.c: Use C++ exception handling.
12197 * python/py-utils.c: Use C++ exception handling.
12198 * python/py-unwind.c: Use C++ exception handling.
12199 * python/py-type.c: Use C++ exception handling.
12200 * python/py-symbol.c: Use C++ exception handling.
12201 * python/py-record.c: Use C++ exception handling.
12202 * python/py-record-btrace.c: Use C++ exception handling.
12203 * python/py-progspace.c: Use C++ exception handling.
12204 * python/py-prettyprint.c: Use C++ exception handling.
12205 * python/py-param.c: Use C++ exception handling.
12206 * python/py-objfile.c: Use C++ exception handling.
12207 * python/py-linetable.c: Use C++ exception handling.
12208 * python/py-lazy-string.c: Use C++ exception handling.
12209 * python/py-infthread.c: Use C++ exception handling.
12210 * python/py-inferior.c: Use C++ exception handling.
12211 * python/py-gdb-readline.c: Use C++ exception handling.
12212 * python/py-framefilter.c: Use C++ exception handling.
12213 * python/py-frame.c: Use C++ exception handling.
12214 * python/py-finishbreakpoint.c: Use C++ exception handling.
12215 * python/py-cmd.c: Use C++ exception handling.
12216 * python/py-breakpoint.c: Use C++ exception handling.
12217 * python/py-arch.c: Use C++ exception handling.
12218 * printcmd.c: Use C++ exception handling.
12219 * ppc-linux-tdep.c: Use C++ exception handling.
12220 * parse.c: Use C++ exception handling.
12221 * p-valprint.c: Use C++ exception handling.
12222 * objc-lang.c: Use C++ exception handling.
12223 * mi/mi-main.c: Use C++ exception handling.
12224 * mi/mi-interp.c: Use C++ exception handling.
12225 * mi/mi-cmd-stack.c: Use C++ exception handling.
12226 * mi/mi-cmd-break.c: Use C++ exception handling.
12227 * main.c: Use C++ exception handling.
12228 * linux-thread-db.c: Use C++ exception handling.
12229 * linux-tdep.c: Use C++ exception handling.
12230 * linux-nat.c: Use C++ exception handling.
12231 * linux-fork.c: Use C++ exception handling.
12232 * linespec.c: Use C++ exception handling.
12233 * language.c: Use C++ exception handling.
12234 * jit.c: Use C++ exception handling.
12235 * infrun.c: Use C++ exception handling.
12236 * infcmd.c: Use C++ exception handling.
12237 * infcall.c: Use C++ exception handling.
12238 * inf-loop.c: Use C++ exception handling.
12239 * i386-tdep.c: Use C++ exception handling.
12240 * i386-linux-tdep.c: Use C++ exception handling.
12241 * guile/scm-value.c: Use C++ exception handling.
12242 * guile/scm-type.c: Use C++ exception handling.
12243 * guile/scm-symtab.c: Use C++ exception handling.
12244 * guile/scm-symbol.c: Use C++ exception handling.
12245 * guile/scm-pretty-print.c: Use C++ exception handling.
12246 * guile/scm-ports.c: Use C++ exception handling.
12247 * guile/scm-param.c: Use C++ exception handling.
12248 * guile/scm-math.c: Use C++ exception handling.
12249 * guile/scm-lazy-string.c: Use C++ exception handling.
12250 * guile/scm-frame.c: Use C++ exception handling.
12251 * guile/scm-disasm.c: Use C++ exception handling.
12252 * guile/scm-cmd.c: Use C++ exception handling.
12253 * guile/scm-breakpoint.c: Use C++ exception handling.
12254 * guile/scm-block.c: Use C++ exception handling.
12255 * guile/guile-internal.h: Use C++ exception handling.
12256 * gnu-v3-abi.c: Use C++ exception handling.
12257 * gdbtypes.c: Use C++ exception handling.
12258 * frame.c: Use C++ exception handling.
12259 * frame-unwind.c: Use C++ exception handling.
12260 * fbsd-tdep.c: Use C++ exception handling.
12261 * f-valprint.c: Use C++ exception handling.
12262 * exec.c: Use C++ exception handling.
12263 * event-top.c: Use C++ exception handling.
12264 * event-loop.c: Use C++ exception handling.
12265 * eval.c: Use C++ exception handling.
12266 * dwarf2read.c: Use C++ exception handling.
12267 * dwarf2loc.c: Use C++ exception handling.
12268 * dwarf2-frame.c: Use C++ exception handling.
12269 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12270 * dwarf-index-write.c: Use C++ exception handling.
12271 * dwarf-index-cache.c: Use C++ exception handling.
12272 * dtrace-probe.c: Use C++ exception handling.
12273 * disasm-selftests.c: Use C++ exception handling.
12274 * darwin-nat.c: Use C++ exception handling.
12275 * cp-valprint.c: Use C++ exception handling.
12276 * cp-support.c: Use C++ exception handling.
12277 * cp-abi.c: Use C++ exception handling.
12278 * corelow.c: Use C++ exception handling.
12279 * completer.c: Use C++ exception handling.
12280 * compile/compile-object-run.c: Use C++ exception handling.
12281 * compile/compile-object-load.c: Use C++ exception handling.
12282 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12283 * compile/compile-c-symbols.c: Use C++ exception handling.
12284 * common/selftest.c: Use C++ exception handling.
12285 * common/new-op.c: Use C++ exception handling.
12286 * cli/cli-script.c: Use C++ exception handling.
12287 * cli/cli-interp.c: Use C++ exception handling.
12288 * cli/cli-cmds.c: Use C++ exception handling.
12289 * c-varobj.c: Use C++ exception handling.
12290 * btrace.c: Use C++ exception handling.
12291 * breakpoint.c: Use C++ exception handling.
12292 * break-catch-throw.c: Use C++ exception handling.
12293 * arch-utils.c: Use C++ exception handling.
12294 * amd64-tdep.c: Use C++ exception handling.
12295 * ada-valprint.c: Use C++ exception handling.
12296 * ada-typeprint.c: Use C++ exception handling.
12297 * ada-lang.c: Use C++ exception handling.
12298 * aarch64-tdep.c: Use C++ exception handling.
12299
3d6e9d23
TT		 123002019-04-08 Tom Tromey <tom@tromey.com>
12301
12302 * xml-support.c (gdb_xml_parser::parse): Update.
12303 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12304 * value.c (show_convenience): Update.
12305 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12306 (test_parse_flags_qcs): Update.
12307 * thread.c (thr_try_catch_cmd): Update.
12308 * target.c (target_translate_tls_address): Update.
12309 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12310 (info_frame_command_core, frame_apply_command_count): Update.
12311 * rust-exp.y (rust_lex_exception_test): Update.
12312 * riscv-tdep.c (riscv_print_one_register_info): Update.
12313 * remote.c (remote_target::enable_btrace): Update.
12314 * record-btrace.c (record_btrace_enable_warn): Update.
12315 * python/py-utils.c (gdbpy_convert_exception): Update.
12316 * printcmd.c (do_one_display, print_variable_and_value): Update.
12317 * mi/mi-main.c (mi_print_exception): Update.
12318 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12319 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12320 * linux-nat.c (linux_nat_target::attach): Update.
12321 * linux-fork.c (class scoped_switch_fork_info): Update.
12322 * infrun.c (displaced_step_prepare): Update.
12323 * infcall.c (call_function_by_hand_dummy): Update.
12324 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12325 * gnu-v3-abi.c (print_one_vtable): Update.
12326 * frame.c (get_prev_frame_always): Update.
12327 * f-valprint.c (info_common_command_for_block): Update.
12328 * exec.c (try_open_exec_file): Update.
12329 * exceptions.c (print_exception, exception_print)
12330 (exception_fprintf, exception_print_same): Update.
12331 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12332 * dwarf-index-cache.c (index_cache::store)
12333 (index_cache::lookup_gdb_index): Update.
12334 * darwin-nat.c (maybe_cache_shell): Update.
12335 * cp-valprint.c (cp_print_value_fields): Update.
12336 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12337 (gcc_cplus_symbol_address): Update.
12338 * compile/compile-c-symbols.c (gcc_convert_symbol)
12339 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12340 * common/selftest.c: Update.
12341 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12342 a std::string.
12343 (exception_try_scope_entry, exception_try_scope_exit): Don't
12344 declare.
12345 (struct exception_try_scope): Remove.
12346 (TRY): Don't use exception_try_scope.
12347 (struct gdb_exception): Add constructor, operator=.
12348 <what>: New method.
12349 (struct gdb_exception_RETURN_MASK_ALL)
12350 (struct gdb_exception_RETURN_MASK_ERROR)
12351 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12352 (struct gdb_quit_bad_alloc): Update.
12353 * common/common-exceptions.c (exception_none): Change
12354 initializer.
12355 (struct catcher) <state, exception>: Initialize inline.
12356 <prev>: Remove member.
12357 (current_catcher): Remove.
12358 (catchers): New global.
12359 (exceptions_state_mc_init): Simplify.
12360 (catcher_pop): Remove.
12361 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12362 (try_scope_depth, exception_try_scope_entry)
12363 (exception_try_scope_exit): Remove.
12364 (throw_exception_sjlj): Update.
12365 (exception_messages, exception_messages_size): Remove.
12366 (throw_it): Simplify.
12367 (gdb_exception_sliced_copy): Remove.
12368 (throw_exception_cxx): Update.
12369 * cli/cli-script.c (script_from_file): Update.
12370 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12371 Update.
12372 * ada-valprint.c (ada_val_print): Update.
12373 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12374 (create_excep_cond_exprs): Update.
12375
c5c10118
TT		 123762019-04-08 Tom Tromey <tom@tromey.com>
12377
12378 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12379 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12380 (TRY, CATCH, END_CATCH): Remove some definitions.
12381 * common/common-exceptions.c: Don't use GDB_XCPT.
12382 (catcher_list_size): Remove.
12383 (throw_exception, throw_it): Simplify.
12384
4de283e4
TT		 123852019-04-05 Tom Tromey <tom@tromey.com>
12386
12387 Revert the header-sorting patch.
12388 * ft32-tdep.c: Revert.
12389 * frv-tdep.c: Revert.
12390 * frv-linux-tdep.c: Revert.
12391 * frame.c: Revert.
12392 * frame-unwind.c: Revert.
12393 * frame-base.c: Revert.
12394 * fork-child.c: Revert.
12395 * findvar.c: Revert.
12396 * findcmd.c: Revert.
12397 * filesystem.c: Revert.
12398 * filename-seen-cache.h: Revert.
12399 * filename-seen-cache.c: Revert.
12400 * fbsd-tdep.c: Revert.
12401 * fbsd-nat.h: Revert.
12402 * fbsd-nat.c: Revert.
12403 * f-valprint.c: Revert.
12404 * f-typeprint.c: Revert.
12405 * f-lang.c: Revert.
12406 * extension.h: Revert.
12407 * extension.c: Revert.
12408 * extension-priv.h: Revert.
12409 * expprint.c: Revert.
12410 * exec.h: Revert.
12411 * exec.c: Revert.
12412 * exceptions.c: Revert.
12413 * event-top.c: Revert.
12414 * event-loop.c: Revert.
12415 * eval.c: Revert.
12416 * elfread.c: Revert.
12417 * dwarf2read.h: Revert.
12418 * dwarf2read.c: Revert.
12419 * dwarf2loc.c: Revert.
12420 * dwarf2expr.h: Revert.
12421 * dwarf2expr.c: Revert.
12422 * dwarf2-frame.c: Revert.
12423 * dwarf2-frame-tailcall.c: Revert.
12424 * dwarf-index-write.h: Revert.
12425 * dwarf-index-write.c: Revert.
12426 * dwarf-index-common.c: Revert.
12427 * dwarf-index-cache.h: Revert.
12428 * dwarf-index-cache.c: Revert.
12429 * dummy-frame.c: Revert.
12430 * dtrace-probe.c: Revert.
12431 * disasm.h: Revert.
12432 * disasm.c: Revert.
12433 * disasm-selftests.c: Revert.
12434 * dictionary.c: Revert.
12435 * dicos-tdep.c: Revert.
12436 * demangle.c: Revert.
12437 * dcache.h: Revert.
12438 * dcache.c: Revert.
12439 * darwin-nat.h: Revert.
12440 * darwin-nat.c: Revert.
12441 * darwin-nat-info.c: Revert.
12442 * d-valprint.c: Revert.
12443 * d-namespace.c: Revert.
12444 * d-lang.c: Revert.
12445 * ctf.c: Revert.
12446 * csky-tdep.c: Revert.
12447 * csky-linux-tdep.c: Revert.
12448 * cris-tdep.c: Revert.
12449 * cris-linux-tdep.c: Revert.
12450 * cp-valprint.c: Revert.
12451 * cp-support.c: Revert.
12452 * cp-namespace.c: Revert.
12453 * cp-abi.c: Revert.
12454 * corelow.c: Revert.
12455 * corefile.c: Revert.
12456 * continuations.c: Revert.
12457 * completer.h: Revert.
12458 * completer.c: Revert.
12459 * complaints.c: Revert.
12460 * coffread.c: Revert.
12461 * coff-pe-read.c: Revert.
12462 * cli-out.h: Revert.
12463 * cli-out.c: Revert.
12464 * charset.c: Revert.
12465 * c-varobj.c: Revert.
12466 * c-valprint.c: Revert.
12467 * c-typeprint.c: Revert.
12468 * c-lang.c: Revert.
12469 * buildsym.c: Revert.
12470 * buildsym-legacy.c: Revert.
12471 * build-id.h: Revert.
12472 * build-id.c: Revert.
12473 * btrace.c: Revert.
12474 * bsd-uthread.c: Revert.
12475 * breakpoint.h: Revert.
12476 * breakpoint.c: Revert.
12477 * break-catch-throw.c: Revert.
12478 * break-catch-syscall.c: Revert.
12479 * break-catch-sig.c: Revert.
12480 * blockframe.c: Revert.
12481 * block.c: Revert.
12482 * bfin-tdep.c: Revert.
12483 * bfin-linux-tdep.c: Revert.
12484 * bfd-target.c: Revert.
12485 * bcache.c: Revert.
12486 * ax-general.c: Revert.
12487 * ax-gdb.h: Revert.
12488 * ax-gdb.c: Revert.
12489 * avr-tdep.c: Revert.
12490 * auxv.c: Revert.
12491 * auto-load.c: Revert.
12492 * arm-wince-tdep.c: Revert.
12493 * arm-tdep.c: Revert.
12494 * arm-symbian-tdep.c: Revert.
12495 * arm-pikeos-tdep.c: Revert.
12496 * arm-obsd-tdep.c: Revert.
12497 * arm-nbsd-tdep.c: Revert.
12498 * arm-nbsd-nat.c: Revert.
12499 * arm-linux-tdep.c: Revert.
12500 * arm-linux-nat.c: Revert.
12501 * arm-fbsd-tdep.c: Revert.
12502 * arm-fbsd-nat.c: Revert.
12503 * arm-bsd-tdep.c: Revert.
12504 * arch-utils.c: Revert.
12505 * arc-tdep.c: Revert.
12506 * arc-newlib-tdep.c: Revert.
12507 * annotate.h: Revert.
12508 * annotate.c: Revert.
12509 * amd64-windows-tdep.c: Revert.
12510 * amd64-windows-nat.c: Revert.
12511 * amd64-tdep.c: Revert.
12512 * amd64-sol2-tdep.c: Revert.
12513 * amd64-obsd-tdep.c: Revert.
12514 * amd64-obsd-nat.c: Revert.
12515 * amd64-nbsd-tdep.c: Revert.
12516 * amd64-nbsd-nat.c: Revert.
12517 * amd64-nat.c: Revert.
12518 * amd64-linux-tdep.c: Revert.
12519 * amd64-linux-nat.c: Revert.
12520 * amd64-fbsd-tdep.c: Revert.
12521 * amd64-fbsd-nat.c: Revert.
12522 * amd64-dicos-tdep.c: Revert.
12523 * amd64-darwin-tdep.c: Revert.
12524 * amd64-bsd-nat.c: Revert.
12525 * alpha-tdep.c: Revert.
12526 * alpha-obsd-tdep.c: Revert.
12527 * alpha-nbsd-tdep.c: Revert.
12528 * alpha-mdebug-tdep.c: Revert.
12529 * alpha-linux-tdep.c: Revert.
12530 * alpha-linux-nat.c: Revert.
12531 * alpha-bsd-tdep.c: Revert.
12532 * alpha-bsd-nat.c: Revert.
12533 * aix-thread.c: Revert.
12534 * agent.c: Revert.
12535 * addrmap.c: Revert.
12536 * ada-varobj.c: Revert.
12537 * ada-valprint.c: Revert.
12538 * ada-typeprint.c: Revert.
12539 * ada-tasks.c: Revert.
12540 * ada-lang.c: Revert.
12541 * aarch64-tdep.c: Revert.
12542 * aarch64-ravenscar-thread.c: Revert.
12543 * aarch64-newlib-tdep.c: Revert.
12544 * aarch64-linux-tdep.c: Revert.
12545 * aarch64-linux-nat.c: Revert.
12546 * aarch64-fbsd-tdep.c: Revert.
12547 * aarch64-fbsd-nat.c: Revert.
12548 * aarch32-linux-nat.c: Revert.
12549
d55e5aa6
TT		 125502019-04-05 Tom Tromey <tom@tromey.com>
12551
12552 * ft32-tdep.c: Sort headers.
12553 * frv-tdep.c: Sort headers.
12554 * frv-linux-tdep.c: Sort headers.
12555 * frame.c: Sort headers.
12556 * frame-unwind.c: Sort headers.
12557 * frame-base.c: Sort headers.
12558 * fork-child.c: Sort headers.
12559 * findvar.c: Sort headers.
12560 * findcmd.c: Sort headers.
12561 * filesystem.c: Sort headers.
12562 * filename-seen-cache.h: Sort headers.
12563 * filename-seen-cache.c: Sort headers.
12564 * fbsd-tdep.c: Sort headers.
12565 * fbsd-nat.h: Sort headers.
12566 * fbsd-nat.c: Sort headers.
12567 * f-valprint.c: Sort headers.
12568 * f-typeprint.c: Sort headers.
12569 * f-lang.c: Sort headers.
12570 * extension.h: Sort headers.
12571 * extension.c: Sort headers.
12572 * extension-priv.h: Sort headers.
12573 * expprint.c: Sort headers.
12574 * exec.h: Sort headers.
12575 * exec.c: Sort headers.
12576 * exceptions.c: Sort headers.
12577 * event-top.c: Sort headers.
12578 * event-loop.c: Sort headers.
12579 * eval.c: Sort headers.
12580 * elfread.c: Sort headers.
12581 * dwarf2read.h: Sort headers.
12582 * dwarf2read.c: Sort headers.
12583 * dwarf2loc.c: Sort headers.
12584 * dwarf2expr.h: Sort headers.
12585 * dwarf2expr.c: Sort headers.
12586 * dwarf2-frame.c: Sort headers.
12587 * dwarf2-frame-tailcall.c: Sort headers.
12588 * dwarf-index-write.h: Sort headers.
12589 * dwarf-index-write.c: Sort headers.
12590 * dwarf-index-common.c: Sort headers.
12591 * dwarf-index-cache.h: Sort headers.
12592 * dwarf-index-cache.c: Sort headers.
12593 * dummy-frame.c: Sort headers.
12594 * dtrace-probe.c: Sort headers.
12595 * disasm.h: Sort headers.
12596 * disasm.c: Sort headers.
12597 * disasm-selftests.c: Sort headers.
12598 * dictionary.c: Sort headers.
12599 * dicos-tdep.c: Sort headers.
12600 * demangle.c: Sort headers.
12601 * dcache.h: Sort headers.
12602 * dcache.c: Sort headers.
12603 * darwin-nat.h: Sort headers.
12604 * darwin-nat.c: Sort headers.
12605 * darwin-nat-info.c: Sort headers.
12606 * d-valprint.c: Sort headers.
12607 * d-namespace.c: Sort headers.
12608 * d-lang.c: Sort headers.
12609 * ctf.c: Sort headers.
12610 * csky-tdep.c: Sort headers.
12611 * csky-linux-tdep.c: Sort headers.
12612 * cris-tdep.c: Sort headers.
12613 * cris-linux-tdep.c: Sort headers.
12614 * cp-valprint.c: Sort headers.
12615 * cp-support.c: Sort headers.
12616 * cp-namespace.c: Sort headers.
12617 * cp-abi.c: Sort headers.
12618 * corelow.c: Sort headers.
12619 * corefile.c: Sort headers.
12620 * continuations.c: Sort headers.
12621 * completer.h: Sort headers.
12622 * completer.c: Sort headers.
12623 * complaints.c: Sort headers.
12624 * coffread.c: Sort headers.
12625 * coff-pe-read.c: Sort headers.
12626 * cli-out.h: Sort headers.
12627 * cli-out.c: Sort headers.
12628 * charset.c: Sort headers.
12629 * c-varobj.c: Sort headers.
12630 * c-valprint.c: Sort headers.
12631 * c-typeprint.c: Sort headers.
12632 * c-lang.c: Sort headers.
12633 * buildsym.c: Sort headers.
12634 * buildsym-legacy.c: Sort headers.
12635 * build-id.h: Sort headers.
12636 * build-id.c: Sort headers.
12637 * btrace.c: Sort headers.
12638 * bsd-uthread.c: Sort headers.
12639 * breakpoint.h: Sort headers.
12640 * breakpoint.c: Sort headers.
12641 * break-catch-throw.c: Sort headers.
12642 * break-catch-syscall.c: Sort headers.
12643 * break-catch-sig.c: Sort headers.
12644 * blockframe.c: Sort headers.
12645 * block.c: Sort headers.
12646 * bfin-tdep.c: Sort headers.
12647 * bfin-linux-tdep.c: Sort headers.
12648 * bfd-target.c: Sort headers.
12649 * bcache.c: Sort headers.
12650 * ax-general.c: Sort headers.
12651 * ax-gdb.h: Sort headers.
12652 * ax-gdb.c: Sort headers.
12653 * avr-tdep.c: Sort headers.
12654 * auxv.c: Sort headers.
12655 * auto-load.c: Sort headers.
12656 * arm-wince-tdep.c: Sort headers.
12657 * arm-tdep.c: Sort headers.
12658 * arm-symbian-tdep.c: Sort headers.
12659 * arm-pikeos-tdep.c: Sort headers.
12660 * arm-obsd-tdep.c: Sort headers.
12661 * arm-nbsd-tdep.c: Sort headers.
12662 * arm-nbsd-nat.c: Sort headers.
12663 * arm-linux-tdep.c: Sort headers.
12664 * arm-linux-nat.c: Sort headers.
12665 * arm-fbsd-tdep.c: Sort headers.
12666 * arm-fbsd-nat.c: Sort headers.
12667 * arm-bsd-tdep.c: Sort headers.
12668 * arch-utils.c: Sort headers.
12669 * arc-tdep.c: Sort headers.
12670 * arc-newlib-tdep.c: Sort headers.
12671 * annotate.h: Sort headers.
12672 * annotate.c: Sort headers.
12673 * amd64-windows-tdep.c: Sort headers.
12674 * amd64-windows-nat.c: Sort headers.
12675 * amd64-tdep.c: Sort headers.
12676 * amd64-sol2-tdep.c: Sort headers.
12677 * amd64-obsd-tdep.c: Sort headers.
12678 * amd64-obsd-nat.c: Sort headers.
12679 * amd64-nbsd-tdep.c: Sort headers.
12680 * amd64-nbsd-nat.c: Sort headers.
12681 * amd64-nat.c: Sort headers.
12682 * amd64-linux-tdep.c: Sort headers.
12683 * amd64-linux-nat.c: Sort headers.
12684 * amd64-fbsd-tdep.c: Sort headers.
12685 * amd64-fbsd-nat.c: Sort headers.
12686 * amd64-dicos-tdep.c: Sort headers.
12687 * amd64-darwin-tdep.c: Sort headers.
12688 * amd64-bsd-nat.c: Sort headers.
12689 * alpha-tdep.c: Sort headers.
12690 * alpha-obsd-tdep.c: Sort headers.
12691 * alpha-nbsd-tdep.c: Sort headers.
12692 * alpha-mdebug-tdep.c: Sort headers.
12693 * alpha-linux-tdep.c: Sort headers.
12694 * alpha-linux-nat.c: Sort headers.
12695 * alpha-bsd-tdep.c: Sort headers.
12696 * alpha-bsd-nat.c: Sort headers.
12697 * aix-thread.c: Sort headers.
12698 * agent.c: Sort headers.
12699 * addrmap.c: Sort headers.
12700 * ada-varobj.c: Sort headers.
12701 * ada-valprint.c: Sort headers.
12702 * ada-typeprint.c: Sort headers.
12703 * ada-tasks.c: Sort headers.
12704 * ada-lang.c: Sort headers.
12705 * aarch64-tdep.c: Sort headers.
12706 * aarch64-ravenscar-thread.c: Sort headers.
12707 * aarch64-newlib-tdep.c: Sort headers.
12708 * aarch64-linux-tdep.c: Sort headers.
12709 * aarch64-linux-nat.c: Sort headers.
12710 * aarch64-fbsd-tdep.c: Sort headers.
12711 * aarch64-fbsd-nat.c: Sort headers.
12712 * aarch32-linux-nat.c: Sort headers.
12713
699bd4cf
TT		 127142019-04-04 Tom Tromey <tom@tromey.com>
12715
12716 * varobj.c (varobj_create): Update.
12717 * rust-exp.y (struct rust_parser) <update_innermost_block,
12718 lookup_symbol>: New methods.
12719 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12720 Rename.
12721 (rust_parser::rust_lookup_type)
12722 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12723 * printcmd.c (display_command, do_one_display): Update.
12724 * parser-defs.h (struct parser_state) <parser_state>: Add
12725 "tracker" parameter.
12726 (block_tracker): New member.
12727 (class innermost_block_tracker) <innermost_block_tracker>: Add
12728 "types" parameter.
12729 <reset>: Remove method.
12730 (innermost_block): Don't declare.
12731 (null_post_parser): Update.
12732 * parse.c (innermost_block): Remove global.
12733 (write_dollar_variable): Update.
12734 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12735 Remove "tracker_types" parameter.
12736 (parse_expression): Add "tracker" parameter.
12737 (parse_expression_for_completion): Update.
12738 (null_post_parser): Add "tracker" parameter.
12739 * p-exp.y: Update rules.
12740 * m2-exp.y: Update rules.
12741 * language.h (struct language_defn) <la_post_parser>: Add
12742 "tracker" parameter.
12743 * go-exp.y: Update rules.
12744 * f-exp.y: Update rules.
12745 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12746 parameter.
12747 * d-exp.y: Update rules.
12748 * c-exp.y: Update rules.
12749 * breakpoint.c (set_breakpoint_condition): Create an
12750 innermost_block_tracker.
12751 (watch_command_1): Likewise.
12752 * ada-lang.c (resolve): Add "tracker" parameter.
12753 (resolve_subexp): Likewise.
12754 * ada-exp.y (write_var_from_sym): Update.
12755
dac43e32
TT		 127562019-04-04 Tom Tromey <tom@tromey.com>
12757
12758 * type-stack.h: New file.
12759 * type-stack.c: New file.
12760 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12761 type-stack.h.
12762 (insert_into_type_stack, insert_type, push_type, push_type_int)
12763 (insert_type_address_space, pop_type, pop_type_int)
12764 (pop_typelist, pop_type_stack, append_type_stack)
12765 (push_type_stack, get_type_stack, push_typelist)
12766 (follow_type_instance_flags, follow_types): Don't declare.
12767 * parse.c (type_stack): Remove global.
12768 (parse_exp_in_context): Update.
12769 (insert_into_type_stack, insert_type, push_type, push_type_int)
12770 (insert_type_address_space, pop_type, pop_type_int)
12771 (pop_typelist, pop_type_stack, append_type_stack)
12772 (push_type_stack, get_type_stack, push_typelist)
12773 (follow_type_instance_flags, follow_types): Remove (moved to
12774 type-stack.c).
12775 * f-exp.y (type_stack): New global.
12776 Update rules.
12777 (push_kind_type, f_parse): Update.
12778 * d-exp.y (type_stack): New global.
12779 Update rules.
12780 (d_parse): Update.
12781 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12782 Update rules.
12783 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12784 (HFILES_NO_SRCDIR): Add type-stack.h.
12785
2a612529
TT		 127862019-04-04 Tom Tromey <tom@tromey.com>
12787
12788 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12789 (rust_parser::convert_ast_to_expression, rust_parse)
12790 (rust_lex_test_completion, rust_lex_tests): Update.
12791 * parser-defs.h (struct expr_completion_state): New.
12792 (struct parser_state) <parser_state>: Add completion parameter.
12793 <mark_struct_expression, mark_completion_tag>: New methods.
12794 <parse_completion, m_completion_state>: New members.
12795 (prefixify_expression, null_post_parser): Update.
12796 (mark_struct_expression, mark_completion_tag): Don't declare.
12797 * parse.c (parse_completion, expout_last_struct)
12798 (expout_tag_completion_type, expout_completion_name): Remove
12799 globals.
12800 (parser_state::mark_struct_expression)
12801 (parser_state::mark_completion_tag): Now methods.
12802 (prefixify_expression): Add last_struct parameter.
12803 (prefixify_subexp): Likewise.
12804 (parse_exp_1): Update.
12805 (parse_exp_in_context): Add cstate parameter. Update.
12806 (parse_expression_for_completion): Create an
12807 expr_completion_state.
12808 (null_post_parser): Add "completion" parameter.
12809 * p-exp.y: Update rules.
12810 (yylex): Update.
12811 * language.h (struct language_defn) <la_post_parser>: Add
12812 "completing" parameter.
12813 * go-exp.y: Update rules.
12814 (lex_one_token): Update.
12815 * expression.h (parse_completion): Don't declare.
12816 * d-exp.y: Update rules.
12817 (lex_one_token): Update rules.
12818 * c-exp.y: Update rules.
12819 (lex_one_token): Update.
12820 * ada-lang.c (resolve): Add "parse_completion" parameter.
12821 (resolve_subexp): Likewise.
12822 (ada_resolve_function): Likewise.
12823
43476f0b
TT		 128242019-04-04 Tom Tromey <tom@tromey.com>
12825
12826 * parser-defs.h (struct parser_state) <start_arglist,
12827 end_arglist>: New methods.
12828 <arglist_len, m_funcall_chain>: New members.
12829 (arglist_len, start_arglist, end_arglist): Don't declare.
12830 * parse.c (arglist_len, funcall_chain): Remove global.
12831 (start_arglist, end_arglist): Remove functions.
12832 (parse_exp_in_context): Update.
12833 * p-exp.y: Update rules.
12834 * m2-exp.y: Update rules.
12835 * go-exp.y: Update rules.
12836 * f-exp.y: Update rules.
12837 * d-exp.y: Update rules.
12838 * c-exp.y: Update rules.
12839
5776fca3
TT		 128402019-04-04 Tom Tromey <tom@tromey.com>
12841
12842 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12843 lex_operator, push_back>: New methods.
12844 Update all rules.
12845 (rust_parser::lex_hex, lex_escape): Rename and update.
12846 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12847 (rust_parser::lex_operator): Rename and update.
12848 (rust_parser::lex_number, rustyylex, rustyyerror)
12849 (rust_lex_test_init, rust_lex_test_sequence)
12850 (rust_lex_test_push_back, rust_lex_tests): Update.
12851 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12852 parameter.
12853 <lexptr, prev_lexptr>: New members.
12854 (lexptr, prev_lexptr): Don't declare.
12855 * parse.c (lexptr, prev_lexptr): Remove globals.
12856 (parse_exp_in_context): Update.
12857 * p-exp.y (yylex, yyerror): Update.
12858 * m2-exp.y (parse_number, yylex, yyerror): Update.
12859 * go-exp.y (lex_one_token, yyerror): Update.
12860 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12861 * d-exp.y (lex_one_token, yyerror): Update.
12862 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12863 (lex_one_token, yyerror): Update.
12864 * ada-lex.l (YY_INPUT): Update.
12865 (rewind_to_char): Update.
12866 * ada-exp.y (yyerror): Update.
12867
8621b685
TT		 128682019-04-04 Tom Tromey <tom@tromey.com>
12869
12870 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12871 * parser-defs.h (struct parser_state) <parser_state>: Add new
12872 parameter.
12873 <comma_terminates>: New member.
12874 (comma_terminates): Don't declare global.
12875 * parse.c (comma_terminates): Remove global.
12876 (parse_exp_in_context): Update.
12877 * p-exp.y (yylex): Update.
12878 * m2-exp.y (yylex): Update.
12879 * go-exp.y (lex_one_token): Update.
12880 * f-exp.y (yylex): Update.
12881 * d-exp.y (lex_one_token): Update.
12882 * c-exp.y (lex_one_token): Update.
12883 * ada-lex.l: Update.
12884
28aaf3fd
TT		 128852019-04-04 Tom Tromey <tom@tromey.com>
12886
12887 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12888 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12889 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12890 * parser-defs.h (paren_depth): Don't declare.
12891 * parse.c (paren_depth): Remove global.
12892 (parse_exp_in_context): Update.
12893 * p-exp.y (paren_depth): New global.
12894 (pascal_parse): Initialize it.
12895 * m2-exp.y (paren_depth): New global.
12896 (m2_parse): Initialize it.
12897 * go-exp.y (paren_depth): New global.
12898 (go_parse): Initialize it.
12899 * f-exp.y (paren_depth): New global.
12900 (f_parse): Initialize it.
12901 * d-exp.y (paren_depth): New global.
12902 (d_parse): Initialize it.
12903 * c-exp.y (paren_depth): New global.
12904 (c_parse): Initialize it.
12905 * ada-lex.l (paren_depth): New global.
12906 (lexer_init): Initialize it.
12907
1e58a4a4
TT		 129082019-04-04 Tom Tromey <tom@tromey.com>
12909
12910 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12911 (rust_parser::convert_ast_to_type)
12912 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12913 * parser-defs.h (struct parser_state) <parser_state>: Add
12914 parameters. Initialize new members.
12915 <expression_context_block, expression_context_pc>: New members.
12916 * parse.c (expression_context_block, expression_context_pc):
12917 Remove globals.
12918 (parse_exp_in_context): Update.
12919 * p-exp.y: Update all rules.
12920 (yylex): Update.
12921 * m2-exp.y: Update all rules.
12922 (yylex): Update.
12923 * go-exp.y (yylex): Update.
12924 * f-exp.y (yylex): Update.
12925 * d-exp.y: Update all rules.
12926 (yylex): Update.
12927 * c-exp.y: Update all rules.
12928 (lex_one_token, classify_name, yylex, c_parse): Update.
12929 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12930
37eedb39
TT		 129312019-04-04 Tom Tromey <tom@tromey.com>
12932
12933 * gdbarch.h, gdbarch.c: Rebuild.
12934 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12935 * stap-probe.h:
12936 (struct stap_parse_info): Replace "parser_state" with
12937 "expr_builder".
12938 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12939 (parser_state): New class.
12940 * parse.c (expr_builder): Rename.
12941 (expr_builder::release): Rename.
12942 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12943 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12944 (write_exp_elt_longcst, write_exp_elt_floatcst)
12945 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12946 (write_exp_string_vector, write_exp_bitstring)
12947 (write_exp_msymbol, mark_struct_expression)
12948 (write_dollar_variable)
12949 (insert_type_address_space, increase_expout_size): Replace
12950 "parser_state" with "expr_builder".
12951 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12952 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12953 "parser_state" with "expr_builder".
12954
73923d7e
TT		 129552019-04-04 Tom Tromey <tom@tromey.com>
12956
12957 * rust-exp.y: Replace "parse_language" with method call.
12958 * p-exp.y:
12959 (yylex): Replace "parse_language" with method call.
12960 * m2-exp.y:
12961 (yylex): Replace "parse_language" with method call.
12962 * go-exp.y (classify_name): Replace "parse_language" with method
12963 call.
12964 * f-exp.y (yylex): Replace "parse_language" with method call.
12965 * d-exp.y (lex_one_token): Replace "parse_language" with method
12966 call.
12967 * c-exp.y:
12968 (lex_one_token, classify_name, yylex): Replace "parse_language"
12969 with method call.
12970 * ada-exp.y (find_primitive_type, type_char)
12971 (type_system_address): Replace "parse_language" with method call.
12972
fa9f5be6
TT		 129732019-04-04 Tom Tromey <tom@tromey.com>
12974
12975 * rust-exp.y: Replace "parse_gdbarch" with method call.
12976 * parse.c (write_dollar_variable, insert_type_address_space):
12977 Replace "parse_gdbarch" with method call.
12978 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12979 call.
12980 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12981 call.
12982 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12983 "parse_gdbarch" with method call.
12984 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12985 with method call.
12986 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12987 "parse_gdbarch" with method call.
12988 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12989 "parse_gdbarch" with method call.
12990 * c-exp.y (parse_type, parse_number, classify_name): Replace
12991 "parse_gdbarch" with method call.
12992 * ada-lex.l: Replace "parse_gdbarch" with method call.
12993 * ada-exp.y (parse_type, find_primitive_type, type_char)
12994 (type_system_address): Replace "parse_gdbarch" with method call.
12995
1201a264
TT		 129962019-04-04 Tom Tromey <tom@tromey.com>
12997
12998 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12999 * stap-probe.c (stap_parse_argument): Update.
13000 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13001 initial_size parameter.
13002 * rust-exp.y (rust_lex_tests): Update.
13003 * parse.c (parser_state): Update.
13004 (parse_exp_in_context): Update.
13005 * parser-defs.h (struct parser_state) <parser_state>: Remove
13006 "initial_size" parameter.
13007
e3980ce2
TT		 130082019-04-04 Tom Tromey <tom@tromey.com>
13009
13010 * parser-defs.h (increase_expout_size): Don't declare.
13011 * parse.c (increase_expout_size): Now static.
13012
e9f8e3f1
TS		 130132019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13014
13015 * gnu-nat.c (gnu_nat_target::wait): Fix
13016 target_waitstatus_to_string call.
13017
d7df6549
AB		 130182019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13019
13020 * eval.c (evaluate_subexp_standard): Handle internal functions
13021 during Fortran function call handling.
13022
8bdc1658
AB		 130232019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13024
13025 * NEWS: Mention new internal functions.
13026 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13027 (read_base_type): Use dwarf2_init_complex_target_type.
13028 * value.c (creal_internal_fn): New function.
13029 (cimag_internal_fn): New function.
13030 (_initialize_values): Register new internal functions.
13031
c29705b7
PW		 130322019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13033
13034 * infrun.c (stop_all_threads): If debug_infrun, always
13035 trace the wait status after wait_one, using
13036 target_waitstatus_to_string and target_pid_to_str.
13037 (handle_inferior_event): Replace various trace of
13038 wait status kind by a single trace.
13039 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13040 wait status kind image by target_waitstatus_to_string.
13041 * target/waitstatus.c (target_waitstatus_to_string): Fix
13042 obsolete comment.
13043
05caa1d2
TT		 130442019-04-01 Tom Tromey <tromey@adacore.com>
13045
13046 PR symtab/23331:
13047 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13048
9d1447e0
SDJ		 130492019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13050 Pedro Alves <palves@redhat.com>
13051
13052 * top.c (quit_force): Call 'finalize_values'.
13053 * value.c (finalize_values): New function.
13054 * value.h (finalize_values): Declare.
13055
7734102d
EZ		 130562019-03-30 Eli Zaretskii <eliz@gnu.org>
13057
13058 * NEWS: Announce $_gdb_major and $_gdb_minor.
13059
13060 * top.c (init_gdb_version_vars): New function.
13061 (gdb_init): Call init_gdb_version_vars.
13062
188e1fa9
TT		 130632019-03-29 Tom Tromey <tromey@adacore.com>
13064
13065 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13066 help text. Remove dead code.
13067
2880242d
KS		 130682019-03-29 Keith Seitz <keiths@redhat.com>
13069
13070 From Siddhesh Poyarekar:
13071 * f-lang.h (f77_get_upperbound): Return LONGEST.
13072 (f77_get_lowerbound): Likewise.
13073 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13074 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13075 print them.
13076 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13077 plongest to format print it.
13078 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13079 (f77_get_upperbound): Likewise.
13080 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13081 LOWER_BOUND to LONGEST.
13082 (f77_create_arrayprint_offset_tbl): Likewise.
13083
cc1defb1
KS		 130842019-03-29 Keith Seitz <keiths@redhat.com>
13085
13086 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13087 %s/pulongest for TYPE_LENGTH instead of %d in format
13088 strings.
13089 * ada-typerint.c (ada_print_type): Likewise.
13090 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13091 * compile/compile-c-support.c (generate_register_struct): Likewise.
13092 * gdbtypes.c (recursive_dump_type): Likewise.
13093 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13094 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13095 instead of %d in format strings.
13096 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13097 to std::min to ULONGEST.
13098 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13099 instead of %d in format strings.
13100 * tracepoint.c (info_scope_command): Likewise.
13101 * typeprint.c (print_offset_data::update)
13102 (print_offset_data::finish): Likewise.
13103 * xtensa-tdep.c (xtensa_store_return_value)
13104 (xtensa_push_dummy_call): Likewise.
13105
e432ccf1
JT		 131062019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13107
13108 * windows-nat.c (display_selector): Fixed format specifications
13109 for 64-bit Cygwin.
13110
65d2b333
PW		 131112019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13112
13113 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13114
f489207e
SL		 131152019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13116
13117 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13118 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13119 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13120 (nios2_linux_init_abi): Install it.
13121
bffa1015
AH		 131222019-03-28 Alan Hayward <alan.hayward@arm.com>
13123
13124 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13125
fc96163a
AH		 131262019-03-28 Alan Hayward <alan.hayward@arm.com>
13127
13128 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13129
20dc7e9b
PW		 131302019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13131 Tom Tromey <tromey@adacore.com>
13132
13133 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13134
7f5331a8
JB		 131352019-03-26 Joel Brobecker <brobecker@adacore.com>
13136
13137 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13138 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13139 method to compute the bounds of range types. Also print "[evaluated]"
13140 if the bounds' values come from a dynamic evaluation.
13141
18c77628
AB		 131422019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13143
13144 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13145 whitespace when pretty printing is on.
13146
53c973f2
AH		 131472019-03-26 Alan Hayward <alan.hayward@arm.com>
13148
e79be6e5 13149 * ppc-linux-nat.c: Add include.
53c973f2 13150
d851aa71
AH		 131512019-03-26 Alan Hayward <alan.hayward@arm.com>
13152
e79be6e5 13153 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13154
2fe7bab7
AH		 131552019-03-26 Alan Hayward <alan.hayward@arm.com>
13156
e79be6e5 13157 * arm-linux-nat.c: Add include.
2fe7bab7 13158
068ef30e
SM		 131592019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13160
13161 * source-cache.c (source_cache::get_source_lines): Re-read
13162 fullname after calling open_source_file.
13163
81a24d04
JB		 131642019-03-25 John Baldwin <jhb@FreeBSD.org>
13165
13166 * NEWS: Mention TLS support for FreeBSD.
13167
79e7ae11
TT		 131682019-03-25 Tom Tromey <tromey@adacore.com>
13169
13170 * minsyms.c (BUNCH_SIZE): Update comment.
13171 (~minimal_symbol_reader): Remove old comment.
13172 (compact_minimal_symbols): Update comment.
13173 (minimal_symbol_reader::install): Remove old comment. Update
13174 other comments.
13175
d45963c2
AH		 131762019-03-25 Alan Hayward <alan.hayward@arm.com>
13177
13178 * s390-linux-nat.c: Add include.
13179
0f83012e
AH		 131802019-03-25 Alan Hayward <alan.hayward@arm.com>
13181
13182 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13183 Call linux_get_hwcap.
13184 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13185 Likewise.
13186 (aarch64_linux_get_hwcap): Remove function.
13187 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13188 declaration.
13189 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13190 linux_get_hwcap.
13191 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13192 * linux-tdep.c (linux_get_hwcap): Add function.
13193 (linux_get_hwcap2): Likewise.
13194 * linux-tdep.h (linux_get_hwcap): Add declaration.
13195 (linux_get_hwcap2): Likewise.
13196 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13197 (ppc_linux_get_hwcap2): Likewise.
13198 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13199 linux_get_hwcap.
13200 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13201 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13202 (ppc_linux_nat_target::read_description): Likewise.
13203 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13204 * s390-linux-nat.c: Likewise.
13205 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13206
6640a367
TT		 132072019-03-24 Tom Tromey <tom@tromey.com>
13208
13209 * ada-lang.c (standard_lookup): Simplify initialization.
13210 (ada_lookup_symbol_nonlocal): Simplify return.
13211 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13212 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13213 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13214 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13215 initialization.
13216 * solib.c (solib_global_lookup): Simplify.
13217 * symtab.c (null_block_symbol): Remove.
13218 (symbol_cache_lookup): Simplify returns.
13219 (lookup_language_this): Simplify returns.
13220 (lookup_symbol_aux): Simplify return.
13221 (lookup_local_symbol): Simplify returns.
13222 (lookup_global_symbol_from_objfile): Simplify return.
13223 (lookup_symbol_in_objfile_symtabs)
13224 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13225 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13226 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13227 * cp-namespace.c (cp_lookup_bare_symbol)
13228 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13229 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13230 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13231 (cp_lookup_symbol_via_imports): Simplify initialization.
13232 (find_symbol_in_baseclass): Likewise.
13233 * symtab.h (null_block_symbol): Remove.
13234 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13235 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13236 (d_lookup_symbol_module): Likewise.
13237 (find_symbol_in_baseclass): Simplify initialization.
13238
a930ebcd
TT		 132392019-03-24 Tom Tromey <tom@tromey.com>
13240
13241 * expression.h: Don't include symtab.h.
13242 (struct block): Forward declare.
13243
582942f4
TT		 132442019-03-24 Tom Tromey <tom@tromey.com>
13245
13246 * c-exp.y (typebase): Remove casts.
13247 * gdbtypes.c (lookup_unsigned_typename, )
13248 (lookup_signed_typename): Remove cast.
13249 * eval.c (parse_to_comma_and_eval): Remove cast.
13250 * parse.c (write_dollar_variable): Remove cast.
13251 * block.h (struct block) <superblock>: Now const.
13252 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13253 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13254 (map_block): Make "block" const.
13255 * symfile.h (struct quick_symbol_functions)
13256 <map_matching_symbols>: Constify block argument to "callback".
13257 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13258 const.
13259 (find_pc_sect_compunit_symtab): Make "b" const.
13260 (find_symbol_at_address): Likewise.
13261 (search_symbols): Likewise.
13262 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13263 (dw2_debug_names_lookup_symbol): Likewise.
13264 (dw2_map_matching_symbols): Update.
13265 * p-valprint.c (pascal_val_print): Remove "block".
13266 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13267 (aux_add_nonlocal_symbols): Make "block" const.
13268 (resolve_subexp): Remove cast.
13269 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13270 const.
13271 (iterate_over_file_blocks): Likewise.
13272 * f-exp.y (%union) <bval>: Remove.
13273 * coffread.c (patch_opaque_types): Make "b" const.
13274 * spu-tdep.c (spu_catch_start): Make "block" const.
13275 * c-valprint.c (print_unpacked_pointer): Remove "block".
13276 * symmisc.c (dump_symtab_1): Make "b" const.
13277 (block_depth): Make "block" const.
13278 * d-exp.y (%union) <bval>: Remove.
13279 * cp-support.h (cp_lookup_rtti_type): Update.
13280 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13281 * psymtab.c (psym_lookup_symbol): Make "block" const.
13282 (maintenance_check_psymtabs): Make "b" const.
13283 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13284 (enumerate_locals, enumerate_args): Update.
13285 * python/py-symtab.c (stpy_global_block): Make "block" const.
13286 (stpy_static_block): Likewise.
13287 * inline-frame.c (block_starting_point_at): Make "new_block"
13288 const.
13289 * block.c (find_block_in_blockvector): Make return type const.
13290 (blockvector_for_pc_sect): Make "b" const.
13291 (find_block_in_blockvector): Make "b" const.
13292
7ad417dd
TT		 132932019-03-23 Tom Tromey <tom@tromey.com>
13294
13295 * varobj.c (varobj_create): Update.
13296 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13297 * printcmd.c (display_command, do_one_display): Don't reset
13298 innermost_block.
13299 * parser-defs.h (enum innermost_block_tracker_type): Move to
13300 expression.h.
13301 (innermost_block): Update comment.
13302 * parse.c (parse_exp_1): Add tracker_types parameter.
13303 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13304 tracker_types parameter. Reset innermost_block.
13305 (parse_exp_in_context): Remove.
13306 (parse_expression_for_completion): Update.
13307 * objfiles.c (~objfile): Don't reset expression_context_block or
13308 innermost_block.
13309 * expression.h (enum innermost_block_tracker_type): Move from
13310 parser-defs.h.
13311 (parse_exp_1): Add tracker_types parameter.
13312 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13313 reset innermost_block.
13314
b366c208
TT		 133152019-03-23 Tom Tromey <tom@tromey.com>
13316
13317 * objfiles.h: Include bcache.h.
13318
9bb9b2f9
TT		 133192019-03-23 Tom Tromey <tom@tromey.com>
13320
13321 * linespec.c (get_current_search_block): Use
13322 scoped_restore_current_language.
13323 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13324
59c28372
AH		 133252019-03-22 Alan Hayward <alan.hayward@arm.com>
13326 Jiong Wang <jiong.wang@arm.com>
13327
13328 * aarch64-linux-tdep.c
13329 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13330 section.
13331 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13332
17e116a7
AH		 133332019-03-22 Alan Hayward <alan.hayward@arm.com>
13334 Jiong Wang <jiong.wang@arm.com>
13335
13336 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13337 instructions.
13338 (aarch64_analyze_prologue_test): Add PACIASP test.
13339 (aarch64_prologue_prev_register): Unmask PC value.
13340
11e1b75f
AH		 133412019-03-22 Alan Hayward <alan.hayward@arm.com>
13342 Jiong Wang <jiong.wang@arm.com>
13343
13344 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13345 (aarch64_dwarf2_prev_register): Unmask PC value.
13346 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13347 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13348 DW_CFA_AARCH64_negate_ra_state.
13349 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13350
34dcc7cf
AH		 133512019-03-22 Alan Hayward <alan.hayward@arm.com>
13352 Jiong Wang <jiong.wang@arm.com>
13353
13354 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13355 registers.
13356 (aarch64_pseudo_register_name): Likewise.
13357 (aarch64_pseudo_register_type): Likewise.
13358 (aarch64_pseudo_register_reggroup_p): Likewise.
13359 (aarch64_gdbarch_init): Add pauth registers.
13360 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13361 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13362 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13363 (struct gdbarch_tdep): Add regnum for ra_state.
13364
1ef53e6b
AH		 133652019-03-22 Alan Hayward <alan.hayward@arm.com>
13366 Jiong Wang <jiong.wang@arm.com>
13367
13368 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13369
76bed0fd
AH		 133702019-03-22 Alan Hayward <alan.hayward@arm.com>
13371 Jiong Wang <jiong.wang@arm.com>
13372
13373 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13374 function.
13375 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13376 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13377 (aarch64_gdbarch_init): Add puth registers.
13378 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13379 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13380 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13381
ee4fbcfa
AH		 133822019-03-22 Alan Hayward <alan.hayward@arm.com>
13383 Jiong Wang <jiong.wang@arm.com>
13384
13385 * aarch64-linux-nat.c
13386 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13387 * aarch64-linux-tdep.c
13388 (aarch64_linux_core_read_description): Likewise.
13389 (aarch64_linux_get_hwcap): New function.
13390 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13391 (aarch64_linux_get_hwcap): New declaration.
13392
6dc0ebde
AH		 133932019-03-22 Alan Hayward <alan.hayward@arm.com>
13394 Jiong Wang <jiong.wang@arm.com>
13395
13396 * aarch64-linux-nat.c
13397 (aarch64_linux_nat_target::read_description): Add pauth param.
13398 * aarch64-linux-tdep.c
13399 (aarch64_linux_core_read_description): Likewise.
13400 * aarch64-tdep.c (struct target_desc): Add in pauth.
13401 (aarch64_read_description): Add pauth param.
13402 (aarch64_gdbarch_init): Likewise.
13403 * aarch64-tdep.h (aarch64_read_description): Likewise.
13404 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13405 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13406 * features/Makefile: Add new files.
13407 * features/aarch64-pauth.c: New file.
13408 * features/aarch64-pauth.xml: New file.
13409
595915c1
TT		 134102019-03-20 Tom Tromey <tromey@adacore.com>
13411
13412 * infrun.c (handle_inferior_event): Rename from
13413 handle_inferior_event_1. Create a scoped_value_mark.
13414 (handle_inferior_event): Remove.
13415
4c7d57e7
TT		 134162019-03-19 Tom Tromey <tromey@adacore.com>
13417
13418 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13419 * infrun.h (print_stop_event): Add "displays" parameter.
13420 * infrun.c (print_stop_event): Add "displays" parameter.
13421
cb246234
PA		 134222019-03-19 Pedro Alves <palves@redhat.com>
13423
13424 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13425 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13426 to -1. Fix TABs vs spaces.
13427 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13428 * tui/tui-out.h (tui_ui_out) Add intro comments.
13429 <m_line, m_start_of_line>: In-class initialize, and add describing
13430 comment.
13431
3a0e45b2
AH		 134322019-03-18 Alan Hayward <alan.hayward@arm.com>
13433
13434 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13435 variable names.
13436 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13437
5371b850
PA		 134382019-03-18 Pedro Alves <palves@redhat.com>
13439 Eli Zaretskii <eliz@gnu.org>
13440
13441 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13442 m_line and m_start_of_line.
13443
b17c4cd0
EZ		 134442019-03-18 Eli Zaretskii <eliz@gnu.org>
13445
13446 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13447 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13448 it returns a newline. This fixes a regression in TU mode, whereby
13449 the next line is output on the same screen line as the user input.
13450
4bd56d18
TT		 134512019-03-18 Tom Tromey <tromey@adacore.com>
13452
13453 * minsyms.c (minimal_symbol_reader::install): Remove call to
13454 obstack_blank.
13455
55c10aca
PA		 134562019-03-18 Pedro Alves <palves@redhat.com>
13457
13458 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13459 New globals.
13460 (apply_style): New, factored out from ...
13461 (apply_ansi_escape): ... this. Handle reverse video mode.
13462 (tui_set_reverse_mode): New function.
13463 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13464 * tui/tui-winsource.c (tui_show_source_line): Use
13465 tui_set_reverse_mode instead of setting A_STANDOUT.
13466 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13467 New setter methods.
13468
647bb750
HD		 134692019-03-18 Hannes Domani <ssbssa@yahoo.de>
13470
13471 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13472 Handle tabs.
13473
bff8c71f
TT		 134742019-03-18 Tom Tromey <tromey@adacore.com>
13475
13476 * ada-lang.c (empty_array): Add "high" parameter.
13477 (ada_evaluate_subexp): Update.
13478
58785d98
ST		 134792019-03-17 Sergei Trofimovich <siarheit@google.com>
13480
13481 * unittests/string_view-selftests.c: Define
13482 _initialize_string_view_selftests unconditionally.
13483
d4cbef22
ВМ		 134842019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13485
13486 PR gdb/24350
13487 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13488
fce4c071
ВМ		 134892019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13490
13491 PR gdb/24351
13492 * windows-nat.c (display_selector): Fix format specifiers.
13493
f7f0a123
EZ		 134942019-03-17 Eli Zaretskii <eliz@gnu.org>
13495
13496 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13497 tui_refill_source_window instead of tui_refresh_win, to update the
13498 current execution line. This fixes redisplay of the current line
13499 when stepping through the code with "next" or "step".
13500
ab42892f
EZ		 135012019-03-16 Eli Zaretskii <eliz@gnu.org>
13502
13503 * source-cache.c (source_cache::get_source_lines): Call
13504 find_source_lines to initialize s->nlines. This fixes vertical
13505 scrolling of TUI source window when the DOWN arrow is pressed.
13506
8d8c087f
PW		 135072019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13508
13509 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13510 linux-thread-db.c (_initialize_thread_db): Likewise.
13511
798e1c30
EZ		 135122019-03-16 Eli Zaretskii <eliz@gnu.org>
13513
13514 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13515 wclrtoeol in tui_show_source_line". This reverts changes made in
13516 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13517
eefba3da
TT		 135182019-03-15 Tom Tromey <tom@tromey.com>
13519
13520 * symtab.h (struct minimal_symbol): Derive from
13521 general_symbol_info.
13522 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13523 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13524 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13525 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13526 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13527 (MSYMBOL_SEARCH_NAME): Update.
13528 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13529 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13530 * minsyms.c (minimal_symbol_reader::record_full): Update.
13531
0de2420c
TT		 135322019-03-15 Tom Tromey <tom@tromey.com>
13533
13534 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13535
042d75e4
TT		 135362019-03-15 Tom Tromey <tom@tromey.com>
13537
13538 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13539 unique_xmalloc_ptr.
13540 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13541 Update.
13542 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13543 (build_minimal_symbol_hash_tables)
13544 (minimal_symbol_reader::install): Update.
13545
db92718b
TT		 135462019-03-15 Tom Tromey <tom@tromey.com>
13547
13548 * symtab.c (create_demangled_names_hash): Update.
13549 (symbol_set_names): Update.
13550 * objfiles.h (struct objfile_per_bfd_storage)
13551 <demangled_names_hash>: Now an htab_up.
13552 * objfiles.c (objfile_per_bfd_storage): Simplify.
13553
d6797f46
TT		 135542019-03-15 Tom Tromey <tom@tromey.com>
13555
13556 * objfiles.h (struct objfile_per_bfd_storage): Declare
13557 destructor.
13558 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13559 New.
13560 (get_objfile_bfd_data): Use new. Don't initialize
13561 language_of_main.
13562 (free_objfile_per_bfd_storage): Remove.
13563 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13564
741d7538
TT		 135652019-03-15 Tom Tromey <tom@tromey.com>
13566
13567 * symfile.c (reread_symbols): Update.
13568 * objfiles.c (objfile::objfile): Update.
13569 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13570 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13571 comment.
13572 (minimal_symbol_reader::install): Update.
13573 (terminate_minimal_symbol_table): Remove.
13574 * jit.c (jit_object_close_impl): Update.
13575
788c80d1
TT		 135762019-03-15 Tom Tromey <tom@tromey.com>
13577
13578 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13579 initializations.
13580
1b7a07cb
TT		 135812019-03-15 Tom Tromey <tom@tromey.com>
13582
13583 * objfiles.h (struct objfile_per_bfd_storage)
13584 <demangled_hash_languages>: Now a bitset.
13585 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13586 (lookup_minimal_symbol): Update.
13587
3db066bc
TT		 135882019-03-15 Tom Tromey <tom@tromey.com>
13589
13590 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13591 Don't return the symbol.
13592 * coffread.c (record_minimal_symbol): Use record_full.
13593
3fff2c37
EZ		 135942019-03-14 Eli Zaretskii <eliz@gnu.org>
13595
13596 The MS-Windows port of ncurses fails to switch to a color pair if
13597 one or both of the colors are the implicit default colors. This
13598 change records the default colors when TUI is initialized, and
13599 then specifies them explicitly when a color pair uses the default
13600 colors. This allows color styling in TUI mode on MS-Windows.
13601
13602 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13603 ncurses_norm_attr.
13604 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13605 colors in ncurses_norm_attr.
13606 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13607 "none", replace it with the default color recorded in
13608 ncurses_norm_attr.
13609
3b336828
TT		 136102019-03-14 Tom Tromey <tromey@adacore.com>
13611
13612 * source-cache.h (class source_cache) <get_source_lines>: Return
13613 std::string.
13614 * source-cache.c (source_cache::extract_lines): Handle case where
13615 first_pos==npos. Return std::string.
13616 (source_cache::get_source_lines): Update.
13617
d085f989
TT		 136182019-03-14 Tom Tromey <tromey@adacore.com>
13619
13620 * NEWS: Add item for "style sources" commands.
13621 * source-cache.c (source_cache::get_source_lines): Check
13622 source_styling.
13623 * cli/cli-style.c (source_styling): New global.
13624 (_initialize_cli_style): Add "style sources" commands.
13625 (show_style_sources): New function.
13626 * cli/cli-style.h (source_styling): Declare.
13627
6f11e682
TT		 136282019-03-14 Pedro Alves <palves@redhat.com>
13629 Tom Tromey <tromey@adacore.com>
13630
13631 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13632 * tui/tui-winsource.c (tui_refill_source_window): New function,
13633 from...
13634 (tui_horizontal_source_scroll): ... here. Move some logic.
13635 * cli/cli-style.c (set_style_enabled): Notify new observable.
13636 * tui/tui-hooks.c (tui_redisplay_source): New function.
13637 (tui_attach_detach_observers): Attach or detach
13638 tui_redisplay_source.
13639 * observable.h (source_styling_changed): New observable.
13640 * observable.c: Define source_styling_changed observable.
13641
a068643d
TT		 136422019-03-13 Tom Tromey <tromey@adacore.com>
13643
13644 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13645 (i386_gnu_nat_target::store_registers): Update.
13646 * target-debug.h (target_debug_print_std_string): New macro.
13647 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13648 * windows-tdep.c (display_one_tib): Update.
13649 * tui/tui-stack.c (tui_make_status_line): Update.
13650 * top.c (print_inferior_quit_action): Update.
13651 * thread.c (thr_try_catch_cmd): Update.
13652 (add_thread_with_info): Update.
13653 (thread_target_id_str): Update.
13654 (thr_try_catch_cmd): Update.
13655 (thread_command): Update.
13656 (thread_find_command): Update.
13657 * record-btrace.c (record_btrace_target::info_record)
13658 (record_btrace_resume_thread, record_btrace_target::resume)
13659 (record_btrace_cancel_resume, record_btrace_step_thread)
13660 (record_btrace_target::wait, record_btrace_target::wait)
13661 (record_btrace_target::wait, record_btrace_target::stop): Update.
13662 * progspace.c (print_program_space): Update.
13663 * process-stratum-target.c
13664 (process_stratum_target::thread_address_space): Update.
13665 * linux-fork.c (linux_fork_mourn_inferior)
13666 (detach_checkpoint_command, info_checkpoints_command)
13667 (linux_fork_context): Update.
13668 (linux_fork_detach): Update.
13669 (class scoped_switch_fork_info): Update.
13670 (delete_checkpoint_command): Update.
13671 * infrun.c (follow_fork_inferior): Update.
13672 (follow_fork_inferior): Update.
13673 (proceed_after_vfork_done): Update.
13674 (handle_vfork_child_exec_or_exit): Update.
13675 (follow_exec): Update.
13676 (displaced_step_prepare_throw): Update.
13677 (displaced_step_restore): Update.
13678 (start_step_over): Update.
13679 (resume_1): Update.
13680 (clear_proceed_status_thread): Update.
13681 (proceed): Update.
13682 (print_target_wait_results): Update.
13683 (do_target_wait): Update.
13684 (context_switch): Update.
13685 (stop_all_threads): Update.
13686 (restart_threads): Update.
13687 (finish_step_over): Update.
13688 (handle_signal_stop): Update.
13689 (switch_back_to_stepped_thread): Update.
13690 (keep_going_pass_signal): Update.
13691 (print_exited_reason): Update.
13692 (normal_stop): Update.
13693 * inferior.c (inferior_pid_to_str): Change return type.
13694 (print_selected_inferior): Update.
13695 (add_inferior): Update.
13696 (detach_inferior): Update.
13697 * dummy-frame.c (fprint_dummy_frames): Update.
13698 * dcache.c (dcache_info_1): Update.
13699 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13700 (btrace_fetch, btrace_clear): Update.
13701 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13702 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13703 type.
13704 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13705 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13706 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13707 * gdbarch.c, gdbarch.h: Rebuild.
13708 * gdbarch.sh (core_pid_to_str): Change return type.
13709 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13710 return type.
13711 (windows_nat_target::pid_to_str): Change return type.
13712 (windows_delete_thread): Update.
13713 (windows_nat_target::attach): Update.
13714 (windows_nat_target::files_info): Update.
13715 * target-delegates.c: Rebuild.
13716 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13717 return type.
13718 (sol_thread_target::pid_to_str): Change return type.
13719 * remote.c (class remote_target) <pid_to_str>: Change return
13720 type.
13721 (remote_target::pid_to_str): Change return type.
13722 (extended_remote_target::attach, remote_target::remote_stop_ns)
13723 (remote_target::remote_notif_remove_queued_reply)
13724 (remote_target::push_stop_reply, remote_target::disable_btrace):
13725 Update.
13726 (extended_remote_target::attach): Update.
13727 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13728 type.
13729 (gdbsim_target::pid_to_str): Change return type.
13730 * ravenscar-thread.c (struct ravenscar_thread_target)
13731 <pid_to_str>: Change return type.
13732 (ravenscar_thread_target::pid_to_str): Change return type.
13733 * procfs.c (class procfs_target) <pid_to_str>: Change return
13734 type.
13735 (procfs_target::pid_to_str): Change return type.
13736 (procfs_target::attach): Update.
13737 (procfs_target::detach): Update.
13738 (procfs_target::fetch_registers): Update.
13739 (procfs_target::store_registers): Update.
13740 (procfs_target::wait): Update.
13741 (procfs_target::files_info): Update.
13742 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13743 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13744 return type.
13745 (nto_procfs_target::pid_to_str): Change return type.
13746 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13747 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13748 return type.
13749 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13750 (exit_lwp): Update.
13751 (attach_proc_task_lwp_callback, get_detach_signal)
13752 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13753 (linux_nat_target::resume, wait_lwp, stop_callback)
13754 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13755 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13756 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13757 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13758 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13759 type.
13760 (inf_ptrace_target::attach): Update.
13761 (inf_ptrace_target::files_info): Update.
13762 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13763 type.
13764 (go32_nat_target::pid_to_str): Change return type.
13765 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13766 (gnu_nat_target::wait): Update.
13767 (gnu_nat_target::wait): Update.
13768 (gnu_nat_target::resume): Update.
13769 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13770 (fbsd_nat_target::wait): Update.
13771 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13772 type.
13773 (darwin_nat_target::attach): Update.
13774 * corelow.c (class core_target) <pid_to_str>: Change return type.
13775 (core_target::pid_to_str): Change return type.
13776 * target.c (normal_pid_to_str): Change return type.
13777 (default_pid_to_str): Likewise.
13778 (target_pid_to_str): Change return type.
13779 (target_translate_tls_address): Update.
13780 (target_announce_detach): Update.
13781 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13782 return type.
13783 (bsd_uthread_target::pid_to_str): Change return type.
13784 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13785 type.
13786 (bsd_kvm_target::pid_to_str): Change return type.
13787 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13788 return type.
13789 (aix_thread_target::pid_to_str): Change return type.
13790 * target.h (struct target_ops) <pid_to_str>: Change return type.
13791 (target_pid_to_str, normal_pid_to_str): Likewise.
13792 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13793 type.
13794 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13795 type.
13796 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13797 return type.
13798 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13799 type.
13800 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13801 type.
13802 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13803 return type.
13804
b4be1b06
SM		 138052019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13806
13807 * NEWS: Mention that the new default MI version is 3. Mention
13808 changes to the output of commands and events that deal with
13809 multi-location breakpoints.
13810 * breakpoint.c: Include "mi/mi-out.h".
13811 (print_one_breakpoint): Change output syntax if using MI version
13812 >= 3.
13813 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13814 New.
13815 (mi_multi_location_breakpoint_output_fixed): New.
13816 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13817 (mi_cmd_fix_multi_location_breakpoint_output): New.
13818 (mi_multi_location_breakpoint_output_fixed): New.
13819 * mi/mi-cmds.c (mi_cmds): Register command
13820 -fix-multi-location-breakpoint-output.
13821 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13822 interpreter "mi".
13823
8e5e5494
SM		 138242019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13825
13826 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13827 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13828 instantiate mi_ui_out based on interpreter name.
13829 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13830 * mi/mi-main.c (mi_load_progress): Likewise.
13831
197df35e
JB		 138322019-03-12 John Baldwin <jhb@FreeBSD.org>
13833
13834 * NEWS: Combine separate "New targets" sections for 8.3.
13835
8399425f
JB		 138362019-03-12 John Baldwin <jhb@FreeBSD.org>
13837
13838 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13839 (ppcfbsd_init_abi): Install gdbarch
13840 "fetch_tls_load_module_address" and "get_thread_local_address"
13841 methods.
13842
b0f87ed0
JB		 138432019-03-12 John Baldwin <jhb@FreeBSD.org>
13844
13845 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13846 (riscv_fbsd_init_abi): Install gdbarch
13847 "fetch_tls_load_module_address" and "get_thread_local_address"
13848 methods.
13849
ce25aa57
JB		 138502019-03-12 John Baldwin <jhb@FreeBSD.org>
13851
13852 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13853 (i386fbsd_init_abi): Install gdbarch
13854 "fetch_tls_load_module_address" and "get_thread_local_address"
13855 methods.
13856
f5424cfa
JB		 138572019-03-12 John Baldwin <jhb@FreeBSD.org>
13858
13859 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13860 (amd64fbsd_init_abi): Install gdbarch
13861 "fetch_tls_load_module_address" and "get_thread_local_address"
13862 methods.
13863
945f3901
JB		 138642019-03-12 John Baldwin <jhb@FreeBSD.org>
13865
13866 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13867 (struct fbsd_pspace_data): New type.
13868 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13869 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13870 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13871 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13872 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13873
ef0bd204
JB		 138742019-03-12 John Baldwin <jhb@FreeBSD.org>
13875
13876 * gdbtypes.c (lookup_struct_elt): New function.
13877 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13878 * gdbtypes.h (struct struct_elt): New type.
13879 (lookup_struct_elt): New prototype.
13880
36c53a02
JB		 138812019-03-12 John Baldwin <jhb@FreeBSD.org>
13882
13883 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13884 remove disabled code block.
13885
6e056c81
JB		 138862019-03-12 John Baldwin <jhb@FreeBSD.org>
13887
13888 * gdbarch.sh (get_thread_local_address): New method.
13889 * gdbarch.h, gdbarch.c: Regenerate.
13890 * target.c (target_translate_tls_address): Use
13891 gdbarch_get_thread_local_address if present instead of
13892 target::get_thread_local_address.
13893
cd250a18
JB		 138942019-03-12 John Baldwin <jhb@FreeBSD.org>
13895
13896 * target.h (target::get_thread_local_address): Update comment.
13897
df22c1e5
JB		 138982019-03-12 John Baldwin <jhb@FreeBSD.org>
13899
13900 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13901 objfile->separate_debug_objfile_backlink if not NULL.
13902
dd6876c9
JB		 139032019-03-12 John Baldwin <jhb@FreeBSD.org>
13904
13905 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13906 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13907 (amd64bsd_store_inferior_registers): Likewise.
13908 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13909 Enable segment base registers.
13910 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13911 PT_GETFSBASE and PT_GETGSBASE.
13912 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13913 PT_SETGSBASE.
13914 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13915 segment base registers.
13916 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13917
1163a4b7
JB		 139182019-03-12 John Baldwin <jhb@FreeBSD.org>
13919
13920 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13921 Update calls to i386_target_description to add 'segments'
13922 parameter.
13923 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13924 add segment base registers.
13925 * arch/i386.c (i386_create_target_description): Add 'segments'
13926 parameter to enable segment base registers.
13927 * arch/i386.h (i386_create_target_description): Likewise.
13928 * features/i386/32bit-segments.xml: New file.
13929 * features/i386/32bit-segments.c: Generate.
13930 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13931 call to i386_target_description to add 'segments' parameter.
13932 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13933 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13934 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13935 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13936 if feature is present.
13937 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13938 Add 'segments' parameter to call to i386_target_description.
13939 (i386_target_description): Add 'segments' parameter to enable
13940 segment base registers.
13941 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13942 to call to i386_target_description.
13943 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13944 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13945 Define I386_NUM_REGS.
13946 (i386_target_description): Add 'segments' parameter to enable
13947 segment base registers.
13948
3a350822
EZ		 139492019-03-12 Eli Zaretskii <eliz@gnu.org>
13950
13951 PR/24325
13952 * source-cache.c: #undef open and close, to avoid unresolved
13953 externals during linking.
13954
ffdd69cf
TT		 139552019-03-12 Tom Tromey <tromey@adacore.com>
13956
13957 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13958 const. Add initializers.
13959 (_initialize_remote): Don't initialize ptid globals.
13960
ec148c57
PA		 139612019-03-12 Pedro Alves <palves@redhat.com>
13962
13963 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13964
32764270
PA		 139652019-03-12 Pedro Alves <palves@redhat.com>
13966
13967 * cp-name-parser.y (main): Remove unused 'len' variable.
13968
17547186
TT		 139692019-03-12 Tom Tromey <tromey@adacore.com>
13970
13971 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13972 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13973
d3a70e03
TT		 139742019-03-12 Tom Tromey <tromey@adacore.com>
13975
13976 * linux-nat.c (iterate_over_lwps): Update.
13977 (stop_callback): Remove parameter.
13978 (stop_wait_callback, detach_callback, resume_set_callback)
13979 (select_singlestep_lwp_callback, set_ignore_sigint)
13980 (status_callback, resumed_callback, resume_clear_callback)
13981 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13982 data parameter.
13983 (linux_nat_target::detach, linux_nat_target::resume)
13984 (linux_stop_and_wait_all_lwps, select_event_lwp)
13985 (linux_nat_filter_event, linux_nat_wait_1)
13986 (linux_nat_target::kill, linux_nat_target::stop)
13987 (linux_nat_target::stop): Update.
13988 (linux_nat_resume_callback): Change type.
13989 (resume_stopped_resumed_lwps, count_events_callback)
13990 (select_event_lwp_callback): Likewise.
13991 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13992 * arm-linux-nat.c (struct update_registers_data): Remove.
13993 (update_registers_callback): Change type.
13994 (arm_linux_insert_hw_breakpoint1): Update.
13995 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13996 parameter.
13997 (x86_linux_dr_set_addr): Update.
13998 (x86_linux_dr_set_control): Update.
13999 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14000 (iterate_over_lwps): Use gdb::function_view.
14001 * nat/aarch64-linux-hw-point.c (struct
14002 aarch64_dr_update_callback_param): Remove.
14003 (debug_reg_change_callback): Change type.
14004 (aarch64_notify_debug_reg_change): Update.
14005 * s390-linux-nat.c (s390_refresh_per_info): Update.
14006
82cb27ff
TT		 140072019-03-11 Tom Tromey <tromey@adacore.com>
14008
14009 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14010 redundant assignment to "this_cu".
14011
568c0683
SM		 140122019-03-08 Simon Marchi <simon.marchi@efficios.com>
14013
14014 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14015
f09ce22d
SM		 140162019-03-08 Simon Marchi <simon.marchi@efficios.com>
14017
14018 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14019 from...
14020 (rank_one_type): ... this.
14021
595f96a9
SM		 140222019-03-08 Simon Marchi <simon.marchi@efficios.com>
14023
14024 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14025 from...
14026 (rank_one_type): ... this.
14027
2598a94b
SM		 140282019-03-08 Simon Marchi <simon.marchi@efficios.com>
14029
14030 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14031 from...
14032 (rank_one_type): ... this.
14033
7f17b20d
SM		 140342019-03-08 Simon Marchi <simon.marchi@efficios.com>
14035
14036 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14037 from...
14038 (rank_one_type): ... this.
14039
2c509035
SM		 140402019-03-08 Simon Marchi <simon.marchi@efficios.com>
14041
14042 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14043 from...
14044 (rank_one_type): ... this.
14045
0dd322dc
SM		 140462019-03-08 Simon Marchi <simon.marchi@efficios.com>
14047
14048 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14049 from...
14050 (rank_one_type): ... this.
14051
41ea4728
SM		 140522019-03-08 Simon Marchi <simon.marchi@efficios.com>
14053
14054 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14055 from...
14056 (rank_one_type): ... this.
14057
793cd1d2
SM		 140582019-03-08 Simon Marchi <simon.marchi@efficios.com>
14059
14060 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14061 from...
14062 (rank_one_type): ... this.
14063
34910087
SM		 140642019-03-08 Simon Marchi <simon.marchi@efficios.com>
14065
14066 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14067 from...
14068 (rank_one_type): ... this.
14069
f1f832d6
SM		 140702019-03-08 Simon Marchi <simon.marchi@efficios.com>
14071
14072 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14073 from...
14074 (rank_one_type): ... this.
14075
b9f4512f
SM		 140762019-03-08 Simon Marchi <simon.marchi@efficios.com>
14077
14078 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14079 from...
14080 (rank_one_type): ... this.
14081
9293fc63
SM		 140822019-03-08 Simon Marchi <simon.marchi@efficios.com>
14083
14084 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14085 from...
14086 (rank_one_type): ... this.
14087
e3abbe7e
PW		 140882019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14089
14090 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14091 inferior-events' shows the example events.
14092
e4adb939
EZ		 140932019-03-08 Eli Zaretskii <eliz@gnu.org>
14094
14095 Support styling on native MS-Windows console
14096
14097 PR/24315
14098 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14099 on MS-Windows if $TERM is not defined.
14100
14101 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14102
14103 * posix-hdep.c (gdb_console_fputs):
14104 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14105 functions.
14106 * ui-file.h (gdb_console_fputs): Add prototype.
14107
14108 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14109 back to fputs only if the former returns zero.
14110
25629dfd
TT		 141112019-03-07 Tom Tromey <tom@tromey.com>
14112
14113 * symmisc.c (print_symbol_bcache_statistics): Update.
14114 (print_objfile_statistics): Update.
14115 * symfile.c (allocate_symtab): Update.
14116 * stabsread.c: Don't include bcache.h.
14117 * psymtab.h (struct psymbol_bcache): Don't declare.
14118 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14119 (psymbol_bcache_init, psymbol_bcache_free)
14120 (psymbol_bcache_get_bcache): Don't declare.
14121 * psymtab.c (struct psymbol_bcache): Remove.
14122 (psymtab_storage::psymtab_storage): Update.
14123 (psymtab_storage::~psymtab_storage): Update.
14124 (psymbol_bcache_init, psymbol_bcache_free)
14125 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14126 (add_psymbol_to_bcache): Update.
14127 (allocate_psymtab): Update.
14128 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14129 macro_cache>: No longer pointers.
14130 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14131 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14132 * macrotab.c (macro_bcache): Update.
14133 * macroexp.c: Don't include bcache.h.
14134 * gdbtypes.c (check_types_worklist): Update.
14135 (types_deeply_equal): Remove TRY/CATCH. Update.
14136 * elfread.c (elf_symtab_read): Update.
14137 * dwarf2read.c: Don't include bcache.h.
14138 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14139 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14140 (print_bcache_statistics, bcache_memory_used): Don't declare.
14141 (struct bcache): Move from bcache.c. Add constructor, destructor,
14142 methods. Rename all data members.
14143 * bcache.c (struct bcache): Move to bcache.h.
14144 (bcache::expand_hash_table): Rename from expand_hash_table.
14145 (bcache): Remove.
14146 (bcache::insert): Rename from bcache_full.
14147 (bcache::compare): Rename from bcache_compare.
14148 (bcache_xmalloc): Remove.
14149 (bcache::~bcache): Rename from bcache_xfree.
14150 (bcache::print_statistics): Rename from print_bcache_statistics.
14151 (bcache::memory_used): Rename from bcache_memory_used.
14152
fe726667
PA		 141532019-03-07 Pedro Alves <palves@redhat.com>
14154
14155 * infrun.c (normal_stop): Also check for
14156 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14157
7584bb30
AB		 141582019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14159
14160 * f-lang.c (value_from_host_double): Moved to...
14161 * value.c (value_from_host_double): ...here.
14162 * value.h (value_from_host_double): Declare.
14163 * guile/scm-math.c (vlscm_convert_typed_number): Use
14164 value_from_host_double.
14165 (vlscm_convert_number): Likewise.
14166 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14167 * python/py-value.c (convert_value_from_python): Likewise.
14168
a7b1986e
TT		 141692019-03-06 Tom Tromey <tom@tromey.com>
14170
14171 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14172
0ccf4211
TT		 141732019-03-06 Tom Tromey <tom@tromey.com>
14174
14175 * utils.h (free_current_contents): Don't declare.
14176 * utils.c (free_current_contents): Remove.
14177
fe7b42e5
TT		 141782019-03-06 Tom Tromey <tom@tromey.com>
14179
14180 * top.c (quit_force): Update.
14181 * main.c (captured_command_loop): Update.
14182 * common/new-op.c (operator new): Update.
14183 * common/common-exceptions.c (struct catcher)
14184 <save_cleanup_chain>: Remove member.
14185 (exceptions_state_mc_init): Update.
14186 (exception_try_scope_entry): Return nullptr.
14187 (exception_try_scope_exit, exception_rethrow)
14188 (throw_exception_sjlj, throw_exception_cxx): Update.
14189 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14190 (all_cleanups, do_cleanups, discard_cleanups)
14191 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14192 (restore_cleanups, restore_final_cleanups): Don't declare.
14193 (do_final_cleanups): Remove parameter.
14194 * common/cleanups.c (cleanup_chain, make_cleanup)
14195 (make_cleanup_dtor, all_cleanups, do_cleanups)
14196 (discard_my_cleanups, discard_cleanups)
14197 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14198 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14199 (null_cleanup): Remove.
14200 (do_final_cleanups): Remove parameter.
14201
c6321f19
TT		 142022019-03-06 Tom Tromey <tom@tromey.com>
14203
14204 * remote.c (remote_target::remote_parse_stop_reply): Use
14205 unique_xmalloc_ptr.
14206
61b30099
TT		 142072019-03-06 Tom Tromey <tom@tromey.com>
14208
14209 * stabsread.c (struct stabs_field_info): Rename from field_info.
14210 <list, fnlist>: Add initializers.
14211 <obstack>: New member.
14212 (read_member_functions, read_struct_fields, read_baseclasses):
14213 Allocate on obstack. Don't use cleanups.
14214 (read_one_struct_field, read_member_functions, read_struct_fields)
14215 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14216 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14217 (read_struct_type): Update.
14218
6cceac94
TT		 142192019-03-06 Tom Tromey <tom@tromey.com>
14220
14221 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14222 * common/filestuff.h (make_cleanup_close): Don't declare.
14223 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14224 Remove.
14225
72412762
TT		 142262019-03-06 Tom Tromey <tom@tromey.com>
14227
14228 * solib-aix.c: Use make_scope_exit.
14229
2b6ff1c0
TT		 142302019-03-06 Tom Tromey <tom@tromey.com>
14231
14232 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14233 Use make_scope_exit.
14234
d01c5877
TT		 142352019-03-06 Tom Tromey <tom@tromey.com>
14236
14237 * solib-svr4.c (disable_probes_interface): Remove parameter.
14238 (svr4_handle_solib_event): Use make_scope_exit.
14239
32603266
TT		 142402019-03-06 Tom Tromey <tom@tromey.com>
14241
14242 * remote.c (struct stop_reply_deleter): Remove.
14243 (stop_reply_up): Update.
14244 (struct stop_reply): Derive from notif_event. Don't typedef.
14245 <regcache>: Now a std::vector.
14246 (stop_reply_xfree): Remove.
14247 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14248 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14249 (remote_target::discard_pending_stop_replies): Use delete.
14250 (remote_target::remote_parse_stop_reply): Update.
14251 (remote_target::process_stop_reply): Update.
14252 * remote-notif.h (struct notif_event): Add virtual destructor.
14253 Remove "dtr" member.
14254 (struct notif_client) <alloc_event>: Return a unique_ptr.
14255 (notif_event_xfree): Don't declare.
14256 (notif_event_up): New typedef.
14257 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14258 (notif_event_xfree, do_notif_event_xfree): Remove.
14259 (remote_notif_state_xfree): Update.
14260
9799571e
TT		 142612019-03-06 Tom Tromey <tom@tromey.com>
14262
14263 * infrun.c (displaced_step_clear_cleanup): Now a
14264 forward_scope_exit type.
14265 (displaced_step_prepare_throw): Update.
14266 (displaced_step_fixup): Update.
14267
09e3c4ca
TT		 142682019-03-06 Tom Tromey <tom@tromey.com>
14269
14270 * inferior.h (class inferior): Update comment.
14271 * gdbthread.h (class thread_info): Update comment.
14272
e2a03548
TT		 142732019-03-06 Joel Brobecker <brobecker@adacore.com>
14274 Tom Tromey <tom@tromey.com>
14275
14276 * stabsread.h (struct stab_section_list): Remove.
14277 (coffstab_build_psymtabs): Update.
14278 * dbxread.c (symbuf_sections): Now a std::vector.
14279 (sect_idx): New global.
14280 (fill_symbuf): Update.
14281 (coffstab_build_psymtabs): Change type of stabsects parameter.
14282 Update.
14283 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14284 std::vector.
14285 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14286 (coff_locate_sections): Update.
14287 (coff_symfile_read): Remove cleanups. Update.
14288 (init_stringtab): Add storage parameter.
14289 (free_stringtab, free_stringtab_cleanup): Remove.
14290 (init_lineno): Add storage parameter.
14291 (free_linetab, free_linetab_cleanup): Remove.
14292
b7e60d85
PA		 142932019-03-06 Pedro Alves <palves@redhat.com>
14294
14295 * linux-fork.c (fork_info::clobber_regs): Delete.
14296 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14297 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14298 comment. Adjust.
14299 (scoped_switch_fork_info::scoped_switch_fork_info)
14300 (checkpoint_command, linux_fork_context): Adjust
14301 fork_save_infrun_state calls.
14302
e52c971f
PA		 143032019-03-06 Pedro Alves <palves@redhat.com>
14304
14305 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14306 (inf_has_multiple_threads): Return 'bool' and rewrite using
14307 inferior_info::threads().
14308
06974e6c
PA		 143092019-03-06 Pedro Alves <palves@redhat.com>
14310
14311 * linux-fork.c: Include <list>.
14312 (fork_list): Now a std::list instance.
14313 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14314 (forks_exist_p, find_last_fork): Adjust.
14315 (new_fork): Delete.
14316 (one_fork_p): New.
14317 (add_fork): Adjust.
14318 (free_fork): Delete, folded into fork_info::~fork_info().
14319 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14320 Adjust.
14321 (init_fork_list): Delete.
14322 (linux_fork_killall, linux_fork_mourn_inferior)
14323 (linux_fork_detach, info_checkpoints_command): Adjust.
14324 (_initialize_linux_fork): No longer call init_fork_list.
14325
72f31aea
PA		 143262019-03-06 Pedro Alves <palves@redhat.com>
14327
14328 * linux-fork.c (new_fork): New, split out of ...
14329 (add_fork): ... this. Return void. Move "first fork" special
14330 case from here, to ...
14331 (checkpoint_command): ... here.
14332 * linux-linux.h (add_fork): Return void.
14333
efbecbc1
AB		 143342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14335
14336 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14337
0841c79a
AB		 143382019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14339 Chris January <chris.january@arm.com>
14340 David Lecomber <david.lecomber@arm.com>
14341
14342 * f-exp.y: New token, UNOP_INTRINSIC.
14343 (exp): New pattern using UNOP_INTRINSIC token.
14344 (f77_keywords): Add 'abs' keyword.
14345 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14346 (value_from_host_double): New function.
14347 (evaluate_subexp_f): Support UNOP_ABS.
14348
4a270568
AB		 143492019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14350
14351 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14352 types.
14353
067630bd
AB		 143542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14355
14356 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14357 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14358 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14359
3be47f7a
AB		 143602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14361
14362 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14363
4d00f5d8
AB		 143642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14365 Chris January <chris.january@arm.com>
14366
14367 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14368 * f-exp.y: Define 'KIND' token.
14369 (exp): New pattern for KIND expressions.
14370 (ptype): Handle types with a kind extension.
14371 (direct_abs_decl): Extend to spot kind extensions.
14372 (f77_keywords): Add 'kind' to the list.
14373 (push_kind_type): New function.
14374 (convert_to_kind_type): New function.
14375 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14376 * parse.c (operator_length_standard): Likewise.
14377 * parser-defs.h (enum type_pieces): Add tp_kind.
14378 * std-operator.def: Add UNOP_KIND.
14379
e454224f
AB		 143802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14381
14382 * f-exp.y (f_parse): Set yydebug.
14383
9dad4a58
AB		 143842019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14385
14386 * f-lang.c (evaluate_subexp_f): New function.
14387 (exp_descriptor_f): New global.
14388 (f_language_defn): Use exp_descriptor_f instead of
14389 exp_descriptor_standard.
14390
c8f91604
AB		 143912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14392
14393 * f-exp.y (struct token): Add comments.
14394 (dot_ops): Remove uppercase versions and the end marker.
14395 (f77_keywords): Likewise.
14396 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14397 entries in the dot_ops array are case insensitive, and use
14398 strncasecmp to compare strings. Also some whitespace cleanup in
14399 this area. Similar for the f77_keywords array, except entries in
14400 this list might be case sensitive.
14401
dd9f2c76
AB		 144022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14403
14404 * f-exp.y (struct f77_boolean_val): Add comments.
14405 (boolean_values): Remove uppercase versions, and end marker.
14406 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14407 and use strncasecmp to achieve case insensitivity. Additionally,
14408 perform whitespace cleanup around this code.
14409
67a3048c
TT		 144102019-03-06 Tom Tromey <tromey@adacore.com>
14411
14412 * remote-sim.c (gdbsim_target_open): Use result of
14413 gdb_argv::release.
14414
aa3cfbda
RB		 144152019-03-06 Richard Bunt <richard.bunt@arm.com>
14416 Dirk Schubert <dirk.schubert@arm.com>
14417 Chris January <chris.january@arm.com>
14418
14419 * eval.c (evaluate_subexp_standard): Call Fortran argument
14420 wrapping logic.
14421 * f-lang.c (struct value): A value which can be passed into a
14422 Fortran function call.
14423 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14424 where appropriate.
14425 (struct type): Value ready for a Fortran function call.
14426 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14427 is needed.
14428 * f-lang.h (fortran_argument_convert): Declaration.
14429 (fortran_preserve_arg_pointer): Declaration.
14430 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14431
ea38e5df
TT		 144322019-03-05 Tom Tromey <tromey@adacore.com>
14433
14434 * python/py-prettyprint.c (print_string_repr): Remove #if.
14435 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14436
06b5b831
TT		 144372019-03-05 Tom Tromey <tromey@adacore.com>
14438
14439 * target.c (the_dummy_target): Move later. Change type to
14440 "dummy_target".
14441 (initialize_targets): Don't initialize the_dummy_target.
14442
edbd9e45
TT		 144432019-03-05 Tom Tromey <tromey@adacore.com>
14444
14445 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14446 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14447
c119e040
TT		 144482019-03-05 Tom Tromey <tromey@adacore.com>
14449
14450 * windows-nat.c (windows_nat_target::attach)
14451 (windows_nat_target::detach): Don't call gdb_flush.
14452 * valprint.c (generic_val_print, val_print, val_print_string):
14453 Don't call gdb_flush.
14454 * utils.c (defaulted_query): Don't call gdb_flush.
14455 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14456 * target.c (target_announce_detach): Don't call gdb_flush.
14457 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14458 * remote.c (extended_remote_target::attach): Don't call
14459 gdb_flush.
14460 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14461 * printcmd.c (do_examine): Don't call gdb_flush.
14462 (info_display_command): Don't call gdb_flush.
14463 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14464 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14465 * memattr.c (info_mem_command): Don't call gdb_flush.
14466 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14467 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14468 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14469 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14470 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14471 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14472 (gnu_nat_target::detach): Don't call gdb_flush.
14473 * f-valprint.c (f_val_print): Don't call gdb_flush.
14474 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14475 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14476 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14477 gdb_flush.
14478 * c-valprint.c (c_val_print): Don't call gdb_flush.
14479 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14480
895dafa6
TT		 144812019-03-05 Tom Tromey <tromey@adacore.com>
14482
14483 * varobj.c (update_dynamic_varobj_children): Update.
14484 (install_default_visualizer): Use reset, not release.
14485 * value.c (set_internalvar): Update.
14486 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14487 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14488 ATTRIBUTE_UNUSED_RESULT.
14489
88a774b9
TT		 144902019-03-05 Tom Tromey <tromey@adacore.com>
14491
14492 * remote.c (class scoped_remote_fd) <release>: Add
14493 ATTRIBUTE_UNUSED_RESULT.
14494
4e4a8b93
TT		 144952019-03-05 Tom Tromey <tromey@adacore.com>
14496
14497 * macroexp.c (struct macro_buffer) <release>: Add
14498 ATTRIBUTE_UNUSED_RESULT.
14499
083eef1f
TT		 145002019-03-05 Tom Tromey <tromey@adacore.com>
14501
14502 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14503 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14504 ATTRIBUTE_UNUSED_RESULT.
14505
3cabd438
TT		 145062019-03-05 Tom Tromey <tromey@adacore.com>
14507
14508 * common/scoped_fd.h (class scoped_fd) <release>: Add
14509 ATTRIBUTE_UNUSED_RESULT.
14510
41e3300a
TT		 145112019-03-05 Tom Tromey <tromey@adacore.com>
14512
14513 * parser-defs.h (struct parser_state) <release>: Add
14514 ATTRIBUTE_UNUSED_RESULT.
14515
18cb7c9f
TT		 145162019-03-05 Tom Tromey <tromey@adacore.com>
14517
14518 * utils.h (class gdb_argv) <release>: Add
14519 ATTRIBUTE_UNUSED_RESULT.
14520 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14521
41fa577f
EZ		 145222019-03-02 Eli Zaretskii <eliz@gnu.org>
14523
a6a4b2c6
EZ		 14524 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14525 for-loop range, to avoid compiler warnings.
14526
14527 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14528 avoid compiler warnings about unused variables.
14529
742a7df5
EZ		 14530 * NEWS: Mention end of support for native debugging on MS-Windows
14531 before XP.
14532
41fa577f
EZ		 14533 PR gdb/24292
14534 * common/netstuff.c:
14535 * gdbserver/gdbreplay.c
14536 * gdbserver/remote-utils.c:
14537 * ser-tcp.c:
14538 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14539 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14540 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14541 'getaddrinfo' and 'freeaddrinfo' were not available before
14542 Windows XP, and mingw.org's MinGW headers by default define
14543 _WIN32_WINNT to 0x500.
14544
827f438f
GB		 145452019-03-01 Gary Benson <gbenson@redhat.com>
14546
14547 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14548
92137da0
RO		 145492019-02-28 Brian Vandenberg <phantall@gmail.com>
14550 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14551
14552 PR gdb/8527
14553 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14554 set_sigint_trap, clear_sigint_trap.
14555
799efbe8
PW		 145562019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14557
14558 * target.c (target_detach): Clear the regcache and the
14559 frame cache.
14560
8ed25214
PA		 145612019-02-27 Pedro Alves <palves@redhat.com>
14562
14563 * utils.c (set_screen_size): When we cap the height/width sizes,
14564 tweak the corresponding command variable to show "unlimited":
14565
23031e31
SJ		 145662019-02-27 Saagar Jha <saagar@saagarjha.com>
14567 Pedro Alves <palves@redhat.com>
14568
14569 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14570 before calling rl_set_screen_size.
14571
6c28e44a
TT		 145722019-02-27 Tom Tromey <tromey@adacore.com>
14573
14574 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14575 define.
14576 * python/py-value.c: Remove Python 2.4 workaround.
14577 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14578 workaround.
14579 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14580 Python 2.4 workaround.
14581 * python/python-internal.h: Remove Python 2.4 comment.
14582 (Py_ssize_t): Don't define.
14583 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14584 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14585 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14586 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14587 * python/python.c (do_start_initialization): Remove Python 2.4
14588 workaround.
14589 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14590 (print_children): Remove Python 2.4 workaround.
14591 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14592 workaround.
14593 (CHARBUFFERPROC_NAME): Remove.
14594 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14595 Python 2.4 workaround.
14596
2c3fc25d 145972019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14598
2c3fc25d
KB		 14599 * NEWS: Note minimum Python version.
14600
6ca62222
KB		 146012019-02-27 Kevin Buettner <kevinb@redhat.com>
14602
14603 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14604 code from these functions. Remove corresponding ifdefs. Use
14605 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14606 Remove gotos and target of gotos.
14607 (infpy_search_memory): Likewise.
14608
f4bc7d2c
AB		 146092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14610
14611 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14612 (hppa_gdbarch_init): Don't register deleted functions with
14613 gdbarch.
14614
9734a586
AB		 146152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14616
14617 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14618 (h8300_unwind_sp): Delete.
14619 (h8300_dummy_id): Delete.
14620 (h8300_gdbarch_init): Don't register deleted functions with
14621 gdbarch.
14622
68b867f3
AB		 146232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14624
14625 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14626 (ft32_unwind_pc): Delete.
14627 (ft32_unwind_sp): Delete.
14628 (ft32_gdbarch_init): Don't register deleted functions with
14629 gdbarch.
14630
2fbe7ad0
AB		 146312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14632
14633 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14634 (frv_unwind_pc): Delete.
14635 (frv_unwind_sp): Delete.
14636 (frv_gdbarch_init): Don't register deleted functions with
14637 gdbarch.
14638
76055cbe
AB		 146392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14640
14641 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14642 (riscv_unwind_pc): Delete.
14643 (riscv_unwind_sp): Delete.
14644 (riscv_gdbarch_init): Don't register deleted functions with
14645 gdbarch.
14646
4133e5a1
AB		 146472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14648
14649 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14650 (csky_unwind_pc): Delete.
14651 (csky_unwind_sp): Delete.
14652 (csky_gdbarch_init): Don't register deleted functions with
14653 gdbarch.
14654
8010f576
AB		 146552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14656
14657 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14658 (cris_unwind_pc): Delete.
14659 (cris_unwind_sp): Delete.
14660 (cris_gdbarch_init): Don't register deleted functions with
14661 gdbarch.
14662
b56bf084
AB		 146632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14664
14665 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14666 (bfin_unwind_pc): Delete.
14667 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14668
a19a650f
AB		 146692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14670
14671 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14672 (arm_unwind_pc): Delete.
14673 (arm_unwind_sp): Delete.
14674 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14675
f8278c3c
AB		 146762019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14677
14678 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14679 (arc_unwind_pc): Delete.
14680 (arc_unwind_sp): Delete.
14681 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14682
480e46cf
AB		 146832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14684
14685 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14686 (alpha_unwind_pc): Delete.
14687 (alpha_gdbarch_init): Don't register deleted functions with
14688 gdbarch.
14689
7a995095
AB		 146902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14691
14692 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14693 (aarch64_unwind_pc): Delete.
14694 (aarch64_unwind_sp): Delete.
14695 (aarch64_gdbarch_init): Don't register deleted functions with
14696 gdbarch.
14697
bf9a735e
AB		 146982019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14699
14700 * gdbtypes.c (type_align): Don't consider static members when
14701 computing structure alignment.
14702
5561fc30
AB		 147032019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14704
14705 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14706 return 0 for other types.
14707 * arch-utils.c (default_type_align): Always return 0.
14708 * gdbarch.h: Regenerate.
14709 * gdbarch.sh (type_align): Extend comment.
14710 * gdbtypes.c (type_align): Add additional comments, always call
14711 gdbarch_type_align before applying the default rules.
14712 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14713 generic code will then apply a suitable default.
14714 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14715 types, return 0 for other types.
14716
9335e75a
JB		 147172019-02-27 Joel Brobecker <brobecker@adacore.com>
14718
14719 * NEWS: Create a new section for the next release branch.
14720 Rename the section of the current branch, now that it has
14721 been cut.
14722
3d34d8de
JB		 147232019-02-27 Joel Brobecker <brobecker@adacore.com>
14724
14725 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14726 * version.in: Bump version to 8.3.50.DATE-git.
14727
143420fb
SM		 147282019-02-26 Simon Marchi <simon.marchi@efficios.com>
14729
14730 * aix-thread.c (ptid_cmp): Remove unused variable.
14731 (get_signaled_thread): Likewise.
14732 (store_regs_user_thread): Likewise.
14733 (store_regs_kernel_thread): Likewise.
14734 (fetch_regs_kernel_thread): Remove shadowed variable.
14735
172fb711
AB		 147362019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14737
14738 * features/riscv/32bit-cpu.xml: Add register numbers.
14739 * features/riscv/32bit-fpu.c: Regenerate.
14740 * features/riscv/32bit-fpu.xml: Add register numbers.
14741 * features/riscv/64bit-cpu.xml: Add register numbers.
14742 * features/riscv/64bit-fpu.c: Regenerate.
14743 * features/riscv/64bit-fpu.xml: Add register numbers.
14744
26c89782
KB		 147452019-02-26 Kevin Buettner <kevinb@redhat.com>
14746
af54ade9 14747 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14748 * python/py-value.c (convert_buffer_and_type_to_value): New
14749 function.
14750 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14751 Add support for handling an optional second argument. Call
14752 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14753 * python/python-internal.h (Py_buffer_deleter): New struct.
14754 (Py_buffer_up): New typedef.
14755
0f58c9e8
JB		 147562019-02-25 John Baldwin <jhb@FreeBSD.org>
14757
14758 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14759 instead of releasing ownership.
14760
0a0f4c01
JR		 147612019-02-25 Jordan Rupprecht <rupprecht@google.com>
14762
14763 * dwarf2read.c (open_and_init_dwp_file): Call
14764 elf_numsections instead of bfd_count_sections to initialize
14765 dwp_file->num_sections.
14766
cd5a152c
TT		 147672019-02-25 Tom Tromey <tromey@adacore.com>
14768
14769 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14770
8a6a8513
SDJ		 147712019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14772
14773 * gcore.in: Add '--readnever' option when invoking GDB.
14774
04dcda9c
SM		 147752019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14776
14777 * MAINTAINERS: Update my email address.
14778
07bc701d
SM		 147792019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14780
14781 * build-id.c (build_id_to_debug_bfd_1): New function.
14782 (build_id_to_debug_bfd): Look for separate debug file in
14783 sysroot.
14784
c6f4a5d0
AB		 147852019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14786
14787 * gdbarch.sh: Update the copyright year range that is placed into
14788 generated files.
14789
9600246d
KS		 147902019-02-22 Keith Seitz <keiths@redhat.com>
14791
14792 PR symtab/23853
14793 * linespec.c (create_sals_line_offset): Search for the default
14794 symtab's filename instead of its fullname.
14795
7557a514
AH		 147962019-02-21 Alan Hayward <alan.hayward@arm.com>
14797
14798 * NEWS: Update style defaults.
14799
ee2bcb0c
AH		 148002019-02-21 Alan Hayward <alan.hayward@arm.com>
14801
14802 * main.c (captured_main_1): Disable styling in batch mode.
14803
0c95f9ed
TT		 148042019-02-20 Tom Tromey <tom@tromey.com>
14805
14806 * symtab.c (symtab_symbol_info): Fix typos.
14807
c763b894
TT		 148082019-02-20 Tom Tromey <tromey@adacore.com>
14809
14810 * findcmd.c (_initialize_mem_search): Use upper case for
14811 metasyntactic variables.
14812
0ef8a082
AH		 148132019-02-20 Alan Hayward <alan.hayward@arm.com>
14814
14815 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14816 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14817
6caa91b6
SM		 148182019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14819
14820 * top.h (source_file_name): Change to std::string.
14821 * top.c (source_file_name): Likewise.
14822 (command_line_input): Adjust.
14823 * cli/cli-script.c (script_from_file): Adjust.
14824
98814c6c
TT		 148252019-02-19 Tom Tromey <tromey@adacore.com>
14826
14827 * ravenscar-thread.c
14828 (ravenscar_thread_target::update_thread_list): Don't call
14829 ada_build_task_list.
14830 * ada-lang.h (ada_build_task_list): Don't declare.
14831 * ada-tasks.c (struct ada_tasks_inferior_data)
14832 <task_list_valid_p>: Now bool.
14833 (read_known_tasks, ada_task_list_changed)
14834 (ada_tasks_invalidate_inferior_data): Update.
14835 (read_known_tasks_array): Return bool.
14836 (read_known_tasks_list): Likewise.
14837 (read_known_tasks): Return void.
14838 (ada_build_task_list): Now static.
14839
70cd633e
AB		 148402019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14841
14842 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14843 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14844
040b3e95
PW		 148452019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14846
14847 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14848 variant for ada_tasks_pspace_data_handle and
14849 ada_tasks_inferior_data_handle.
14850 (ada_tasks_pspace_data_cleanup): New function.
14851 (ada_tasks_inferior_data_cleanup): New function.
14852
9409233b
TT		 148532019-02-17 Tom Tromey <tom@tromey.com>
14854
14855 * macrotab.h (macro_source_fullname): Return a std::string.
14856 * macrotab.c (macro_include, check_for_redefinition)
14857 (macro_undef, macro_lookup_definition, foreach_macro)
14858 (foreach_macro_in_scope): Update.
14859 (macro_source_fullname): Return a std::string.
14860 * macrocmd.c (show_pp_source_pos): Update.
14861
6506371f
TT		 148622019-02-17 Tom Tromey <tom@tromey.com>
14863
14864 * macrocmd.c (show_pp_source_pos): Style the file names.
14865
0c820d67
TT		 148662019-02-17 Tom Tromey <tom@tromey.com>
14867
14868 PR tui/24197:
14869 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14870
a0087920
TT		 148712019-02-17 Tom Tromey <tom@tromey.com>
14872
14873 * ada-lang.c (user_select_syms): Use filtered printing.
14874 * utils.c (wrap_style): New global.
14875 (desired_style): Remove.
14876 (emit_style_escape): Add stream parameter.
14877 (set_output_style, reset_terminal_style, prompt_for_continue):
14878 Update.
14879 (flush_wrap_buffer): Only flush gdb_stdout.
14880 (wrap_here): Set wrap_style.
14881 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14882 treat escape sequences as a character. Change when wrap buffer is
14883 flushed.
14884 (fputs_styled): Do not set the output style when the default is
14885 requested.
14886 * ui-style.h (struct ui_file_style) <is_default>: New method.
14887 * source.c (print_source_lines_base): Emit escape sequences in one
14888 piece.
14889
75ba10dc
JB		 148902019-02-17 Joel Brobecker <brobecker@adacore.com>
14891
14892 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14893 integers and enumeration types.
14894
a2cd4f14
JB		 148952019-02-17 Joel Brobecker <brobecker@adacore.com>
14896
14897 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14898 instead of lookup_symbol_in_language
14899 (do_exact_match): New function.
14900 (ada_get_symbol_name_matcher): Return do_exact_match when
14901 doing a verbatim match.
14902
485b851b
TT		 149032019-02-15 Tom Tromey <tromey@adacore.com>
14904
14905 * ravenscar-thread.c (ravenscar_thread_target::resume)
14906 (ravenscar_thread_target::wait): Special case wildcard requests.
14907
0b790b1e
TT		 149082019-02-15 Tom Tromey <tromey@adacore.com>
14909
14910 * ravenscar-thread.c (base_ptid): Remove.
14911 (struct ravenscar_thread_target) <close>: New method.
14912 <m_base_ptid>: New member.
14913 <update_inferior_ptid, active_task, task_is_currently_active,
14914 runtime_initialized>: Declare methods.
14915 <ravenscar_thread_target>: Add constructor.
14916 (ravenscar_thread_target::task_is_currently_active)
14917 (ravenscar_thread_target::update_inferior_ptid)
14918 (ravenscar_runtime_initialized): Rename. Now methods.
14919 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14920 (ravenscar_thread_target::update_thread_list): Update.
14921 (ravenscar_thread_target::active_task): Now method.
14922 (ravenscar_thread_target::store_registers)
14923 (ravenscar_thread_target::prepare_to_store)
14924 (ravenscar_thread_target::prepare_to_store)
14925 (ravenscar_thread_target::mourn_inferior): Update.
14926 (ravenscar_inferior_created): Use "new" to create target.
14927 (ravenscar_thread_target::get_ada_task_ptid): Update.
14928 (_initialize_ravenscar): Don't initialize base_ptid.
14929 (ravenscar_ops): Remove global.
14930
dea57a62
TT		 149312019-02-15 Tom Tromey <tromey@adacore.com>
14932
14933 * target.h (push_target): Declare new overload.
14934 * target.c (push_target): New overload, taking an rvalue reference.
14935 * remote.c (remote_target::open_1): Use push_target overload.
14936 * corelow.c (core_target_open): Use push_target overload.
14937
989f3c58
TT		 149382019-02-15 Tom Tromey <tromey@adacore.com>
14939
14940 * ravenscar-thread.c (is_ravenscar_task)
14941 (ravenscar_task_is_currently_active): Return bool.
14942 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14943 (_initialize_ravenscar): Remove "(void)".
14944 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14945 Return bool.
14946
6cbcc006
TT		 149472019-02-15 Tom Tromey <tromey@adacore.com>
14948
14949 * ravenscar-thread.c (ravenscar_runtime_initializer)
14950 (has_ravenscar_runtime, get_running_thread_id)
14951 (ravenscar_thread_target::resume): Fix indentation.
14952
7657f14d
TT		 149532019-02-15 Tom Tromey <tromey@adacore.com>
14954
14955 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14956 from ravenscar_arch_ops.
14957 (sparc_ravenscar_ops::fetch_registers)
14958 (sparc_ravenscar_ops::store_registers): Now methods.
14959 (sparc_ravenscar_prepare_to_store): Remove.
14960 (sparc_ravenscar_ops): Redefine.
14961 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14962 methods and destructor. Remove members.
14963 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14964 (ravenscar_thread_target::store_registers)
14965 (ravenscar_thread_target::prepare_to_store): Update.
14966 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14967 Remove.
14968 (struct ppc_ravenscar_powerpc_ops): Derive from
14969 ravenscar_arch_ops.
14970 (ppc_ravenscar_powerpc_ops::fetch_registers)
14971 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14972 (ppc_ravenscar_powerpc_ops): Redefine.
14973 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14974 (ppc_ravenscar_e500_ops::fetch_registers)
14975 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14976 (ppc_ravenscar_e500_ops): Redefine.
14977 * aarch64-ravenscar-thread.c
14978 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14979 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14980 (aarch64_ravenscar_fetch_registers)
14981 (aarch64_ravenscar_store_registers): Now methods.
14982 (aarch64_ravenscar_ops): Redefine.
14983
5b6ea500
TT		 149842019-02-15 Tom Tromey <tromey@adacore.com>
14985
14986 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14987 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14988 (ravenscar_thread_target::stopped_by_watchpoint)
14989 (ravenscar_thread_target::stopped_data_address)
14990 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14991
e397fd39
TT		 149922019-02-15 Tom Tromey <tromey@adacore.com>
14993
14994 * ravenscar-thread.c: Fix some typos.
14995
cc12f4a8
TT		 149962019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14997 Tom Tromey <tromey@adacore.com>
14998
14999 * ada-lang.c (ada_exception_sal): Change addr_string to a
15000 std::string.
15001 (create_ada_exception_catchpoint): Update.
15002
5f486660
TT		 150032019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15004 Tom Tromey <tromey@adacore.com>
15005
15006 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15007 (bp_location_ops): Remove.
15008 (base_breakpoint_allocate_location): Update.
15009 (free_bp_location): Update.
15010 * ada-lang.c (class ada_catchpoint_location)
15011 <ada_catchpoint_location>: Remove ops parameter.
15012 (ada_catchpoint_location_dtor): Remove.
15013 (ada_catchpoint_location_ops): Remove.
15014 (allocate_location_exception): Update.
15015 * breakpoint.h (struct bp_location_ops): Remove.
15016 (class bp_location) <bp_location>: Remove bp_location_ops
15017 parameter.
15018 <~bp_location>: Add destructor.
15019 <ops>: Remove.
15020
b671c7fb
TS		 150212019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15022 Pedro Alves <palves@redhat.com>
15023
15024 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15025 'PATH_MAX'.
15026
8071c5ce
DM		 150272019-02-14 David Michael <fedora.dm0@gmail.com>
15028 Samuel Thibault <samuel.thibault@gnu.org>
15029 Thomas Schwinge <thomas@codesourcery.com>
15030
15031 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15032 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15033
b1041ae0
TS		 150342019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15035
924514e1
TS		 15036 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15037 (check_empty): Use "const char *".
15038
c29ee8d4
TS		 15039 * gnu-nat.c (gnu_nat_target::detach): Instead of
15040 'detach_inferior (pid)' call
15041 'detach_inferior (find_inferior_pid (pid))'.
15042
6c6ef69f
TS		 15043 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15044 'nat/fork-inferior.o'.
15045 * gnu-nat.c: #include "nat/fork-inferior.h".
15046
2d0a338c
TS		 15047 * gnu-nat.c (gnu_nat_target::detach): Instead of
15048 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15049 * gnu-nat.h: #include "inf-child.h".
15050 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15051 'i386_gnu_nat_target::fetch_registers'.
15052 (gnu_store_registers): Rename/move to
15053 'i386_gnu_nat_target::store_registers'.
15054
cabb5f06
TS		 15055 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15056 * gnu-nat.h (mach_thread_info): New function.
15057 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15058
b1041ae0
TS		 15059 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15060
2988d01e
KF		 150612019-02-14 Frederic Konrad <konrad@adacore.com>
15062
15063 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15064
c559d709
JB		 150652019-02-14 Joel Brobecker <brobecker@adacore.com>
15066
15067 * windows-nat.c (windows_add_thread): Add new parameter
15068 "main_thread_p" with default value set to false. Update
15069 function documentation as well as all callers.
15070 (windows_delete_thread): Likewise.
15071 (fake_create_process): Update call to windows_add_thread.
15072 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15073 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15074 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15075 call to windows_delete_thread.
15076
007024cc
SM		 150772019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15078
15079 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15080
f62318e9
JB		 150812019-02-12 John Baldwin <jhb@FreeBSD.org>
15082
15083 * symfile.c (find_separate_debug_file): Use canonical path of
15084 sysroot with child_path instead of gdb_sysroot if it is valid.
15085
cd4b7848
JB		 150862019-02-12 John Baldwin <jhb@FreeBSD.org>
15087
15088 * symfile.c (find_separate_debug_file): Use child_path to
15089 determine if an object file is under a sysroot.
15090
efac4bfe
JB		 150912019-02-12 John Baldwin <jhb@FreeBSD.org>
15092
15093 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15094 unittests/child-path-selftests.c.
15095 * common/pathstuff.c (child_path): New function.
15096 * common/pathstuff.h (child_path): New prototype.
15097 * unittests/child-path-selftests.c: New file.
15098
402d2bfe
JB		 150992019-02-12 John Baldwin <jhb@FreeBSD.org>
15100
15101 * symfile.c (find_separate_debug_file): Look for separate debug
15102 files in debug directories under the sysroot.
15103
1ed9f74e
PW		 151042019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15105
15106 * symtab.h (struct minimal_symbol data_p): New const method.
15107 (struct minimal_symbol text_p): Likewise.
15108 * symtab.c (output_source_filename): Use file name style
15109 to print file name.
15110 (print_symbol_info): Likewise.
15111 (print_msymbol_info): Use address style to print addresses.
15112 Use function name style to print executable text symbols.
15113 (expand_symtab_containing_pc): Use data_p.
15114 (find_pc_sect_compunit_symtab): Likewise.
15115
2636d81d
PW		 151162019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15117
15118 * breakpoint.c (describe_other_breakpoints): Use address style
15119 to print addresses.
15120 (say_where): Likewise.
15121
ac8c53cc
PW		 151222019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15123
15124 * ada-typeprint.c (print_func_type): Print function name
15125 style to print function name.
15126 * c-typeprint.c (c_print_type_1): Likewise.
15127
ea638c43
AH		 151282019-02-11 Alan Hayward <alan.hayward@arm.com>
15129
15130 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15131 for execve.
15132
ab759ca8
PW		 151332019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15134
15135 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15136 type_stack.
15137
aff29d1c
JB		 151382019-02-10 Joel Brobecker <brobecker@adacore.com>
15139
15140 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15141 TYPE_CODE_REF types.
15142
617126bc
JW		 151432019-02-08 Jim Wilson <jimw@sifive.com>
15144
15145 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15146 (riscv_linux_fregset): New.
15147 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15148
46e3ed7f
TT		 151492019-02-07 Tom Tromey <tom@tromey.com>
15150
15151 * thread.c (thread_cancel_execution_command): Update.
15152 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15153 methods.
15154 (struct thread_fsm_ops): Remove.
15155 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15156 (thread_fsm_should_stop, thread_fsm_return_value)
15157 (thread_fsm_set_finished, thread_fsm_finished_p)
15158 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15159 Don't declare.
15160 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15161 * infrun.c (clear_proceed_status_thread)
15162 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15163 (print_stop_event): Update.
15164 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15165 Add constructor.
15166 (step_command_fsm_ops): Remove.
15167 (new_step_command_fsm): Remove.
15168 (step_1): Update.
15169 (step_command_fsm::should_stop): Rename from
15170 step_command_fsm_should_stop.
15171 (step_command_fsm::clean_up): Rename from
15172 step_command_fsm_clean_up.
15173 (step_command_fsm::do_async_reply_reason): Rename from
15174 step_command_fsm_async_reply_reason.
15175 (struct until_next_fsm): Inherit from thread_fsm. Add
15176 constructor.
15177 (until_next_fsm_ops): Remove.
15178 (new_until_next_fsm): Remove.
15179 (until_next_fsm::should_stop): Rename from
15180 until_next_fsm_should_stop.
15181 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15182 (until_next_fsm::do_async_reply_reason): Rename from
15183 until_next_fsm_async_reply_reason.
15184 (struct finish_command_fsm): Inherit from thread_fsm. Add
15185 constructor. Change type of breakpoint.
15186 (finish_command_fsm_ops): Remove.
15187 (new_finish_command_fsm): Remove.
15188 (finish_command_fsm::should_stop): Rename from
15189 finish_command_fsm_should_stop.
15190 (finish_command_fsm::clean_up): Rename from
15191 finish_command_fsm_clean_up.
15192 (finish_command_fsm::return_value): Rename from
15193 finish_command_fsm_return_value.
15194 (finish_command_fsm::do_async_reply_reason): Rename from
15195 finish_command_fsm_async_reply_reason.
15196 (finish_command): Update.
15197 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15198 Add constructor.
15199 (call_thread_fsm_ops): Remove.
15200 (call_thread_fsm::call_thread_fsm): Rename from
15201 new_call_thread_fsm.
15202 (call_thread_fsm::should_stop): Rename from
15203 call_thread_fsm_should_stop.
15204 (call_thread_fsm::should_notify_stop): Rename from
15205 call_thread_fsm_should_notify_stop.
15206 (run_inferior_call, call_function_by_hand_dummy): Update.
15207 * cli/cli-interp.c (should_print_stop_to_console): Update.
15208 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15209 Add constructor. Change type of location_breakpoint,
15210 caller_breakpoint.
15211 (until_break_fsm_ops): Remove.
15212 (new_until_break_fsm): Remove.
15213 (until_break_fsm::should_stop): Rename from
15214 until_break_fsm_should_stop.
15215 (until_break_fsm::clean_up): Rename from
15216 until_break_fsm_clean_up.
15217 (until_break_fsm::do_async_reply_reason): Rename from
15218 until_break_fsm_async_reply_reason.
15219 (until_break_command): Update.
15220 * thread-fsm.c: Remove.
15221 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15222
1a5c2598
TT		 152232019-02-07 Tom Tromey <tom@tromey.com>
15224
15225 * yy-remap.h: Add include guard.
15226 * xtensa-tdep.h: Add include guard.
15227 * xcoffread.h: Rename include guard.
15228 * varobj-iter.h: Add include guard.
15229 * tui/tui.h: Rename include guard.
15230 * tui/tui-winsource.h: Rename include guard.
15231 * tui/tui-wingeneral.h: Rename include guard.
15232 * tui/tui-windata.h: Rename include guard.
15233 * tui/tui-win.h: Rename include guard.
15234 * tui/tui-stack.h: Rename include guard.
15235 * tui/tui-source.h: Rename include guard.
15236 * tui/tui-regs.h: Rename include guard.
15237 * tui/tui-out.h: Rename include guard.
15238 * tui/tui-layout.h: Rename include guard.
15239 * tui/tui-io.h: Rename include guard.
15240 * tui/tui-hooks.h: Rename include guard.
15241 * tui/tui-file.h: Rename include guard.
15242 * tui/tui-disasm.h: Rename include guard.
15243 * tui/tui-data.h: Rename include guard.
15244 * tui/tui-command.h: Rename include guard.
15245 * tic6x-tdep.h: Add include guard.
15246 * target/waitstatus.h: Rename include guard.
15247 * target/wait.h: Rename include guard.
15248 * target/target.h: Rename include guard.
15249 * target/resume.h: Rename include guard.
15250 * target-float.h: Rename include guard.
15251 * stabsread.h: Add include guard.
15252 * rs6000-tdep.h: Add include guard.
15253 * riscv-fbsd-tdep.h: Add include guard.
15254 * regformats/regdef.h: Rename include guard.
15255 * record.h: Rename include guard.
15256 * python/python.h: Rename include guard.
15257 * python/python-internal.h: Rename include guard.
15258 * python/py-stopevent.h: Rename include guard.
15259 * python/py-ref.h: Rename include guard.
15260 * python/py-record.h: Rename include guard.
15261 * python/py-record-full.h: Rename include guard.
15262 * python/py-record-btrace.h: Rename include guard.
15263 * python/py-instruction.h: Rename include guard.
15264 * python/py-events.h: Rename include guard.
15265 * python/py-event.h: Rename include guard.
15266 * procfs.h: Add include guard.
15267 * proc-utils.h: Add include guard.
15268 * p-lang.h: Add include guard.
15269 * or1k-tdep.h: Rename include guard.
15270 * observable.h: Rename include guard.
15271 * nto-tdep.h: Rename include guard.
15272 * nat/x86-linux.h: Rename include guard.
15273 * nat/x86-linux-dregs.h: Rename include guard.
15274 * nat/x86-gcc-cpuid.h: Add include guard.
15275 * nat/x86-dregs.h: Rename include guard.
15276 * nat/x86-cpuid.h: Rename include guard.
15277 * nat/ppc-linux.h: Rename include guard.
15278 * nat/mips-linux-watch.h: Rename include guard.
15279 * nat/linux-waitpid.h: Rename include guard.
15280 * nat/linux-ptrace.h: Rename include guard.
15281 * nat/linux-procfs.h: Rename include guard.
15282 * nat/linux-osdata.h: Rename include guard.
15283 * nat/linux-nat.h: Rename include guard.
15284 * nat/linux-namespaces.h: Rename include guard.
15285 * nat/linux-btrace.h: Rename include guard.
15286 * nat/glibc_thread_db.h: Rename include guard.
15287 * nat/gdb_thread_db.h: Rename include guard.
15288 * nat/gdb_ptrace.h: Rename include guard.
15289 * nat/fork-inferior.h: Rename include guard.
15290 * nat/amd64-linux-siginfo.h: Rename include guard.
15291 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15292 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15293 * nat/aarch64-linux.h: Rename include guard.
15294 * nat/aarch64-linux-hw-point.h: Rename include guard.
15295 * mn10300-tdep.h: Add include guard.
15296 * mips-linux-tdep.h: Add include guard.
15297 * mi/mi-parse.h: Rename include guard.
15298 * mi/mi-out.h: Rename include guard.
15299 * mi/mi-main.h: Rename include guard.
15300 * mi/mi-interp.h: Rename include guard.
15301 * mi/mi-getopt.h: Rename include guard.
15302 * mi/mi-console.h: Rename include guard.
15303 * mi/mi-common.h: Rename include guard.
15304 * mi/mi-cmds.h: Rename include guard.
15305 * mi/mi-cmd-break.h: Rename include guard.
15306 * m2-lang.h: Add include guard.
15307 * location.h: Rename include guard.
15308 * linux-record.h: Rename include guard.
15309 * linux-nat.h: Add include guard.
15310 * linux-fork.h: Add include guard.
15311 * i386-darwin-tdep.h: Rename include guard.
15312 * hppa-linux-offsets.h: Add include guard.
15313 * guile/guile.h: Rename include guard.
15314 * guile/guile-internal.h: Rename include guard.
15315 * gnu-nat.h: Rename include guard.
15316 * gdb-stabs.h: Rename include guard.
15317 * frv-tdep.h: Add include guard.
15318 * f-lang.h: Add include guard.
15319 * event-loop.h: Add include guard.
15320 * darwin-nat.h: Rename include guard.
15321 * cp-abi.h: Rename include guard.
15322 * config/sparc/nm-sol2.h: Rename include guard.
15323 * config/nm-nto.h: Rename include guard.
15324 * config/nm-linux.h: Add include guard.
15325 * config/i386/nm-i386gnu.h: Rename include guard.
15326 * config/djgpp/nl_types.h: Rename include guard.
15327 * config/djgpp/langinfo.h: Rename include guard.
15328 * compile/gcc-cp-plugin.h: Add include guard.
15329 * compile/gcc-c-plugin.h: Add include guard.
15330 * compile/compile.h: Rename include guard.
15331 * compile/compile-object-run.h: Rename include guard.
15332 * compile/compile-object-load.h: Rename include guard.
15333 * compile/compile-internal.h: Rename include guard.
15334 * compile/compile-cplus.h: Rename include guard.
15335 * compile/compile-c.h: Rename include guard.
15336 * common/xml-utils.h: Rename include guard.
15337 * common/x86-xstate.h: Rename include guard.
15338 * common/version.h: Rename include guard.
15339 * common/vec.h: Rename include guard.
15340 * common/tdesc.h: Rename include guard.
15341 * common/selftest.h: Rename include guard.
15342 * common/scoped_restore.h: Rename include guard.
15343 * common/scoped_mmap.h: Rename include guard.
15344 * common/scoped_fd.h: Rename include guard.
15345 * common/safe-iterator.h: Rename include guard.
15346 * common/run-time-clock.h: Rename include guard.
15347 * common/refcounted-object.h: Rename include guard.
15348 * common/queue.h: Rename include guard.
15349 * common/ptid.h: Rename include guard.
15350 * common/print-utils.h: Rename include guard.
15351 * common/preprocessor.h: Rename include guard.
15352 * common/pathstuff.h: Rename include guard.
15353 * common/observable.h: Rename include guard.
15354 * common/netstuff.h: Rename include guard.
15355 * common/job-control.h: Rename include guard.
15356 * common/host-defs.h: Rename include guard.
15357 * common/gdb_wait.h: Rename include guard.
15358 * common/gdb_vecs.h: Rename include guard.
15359 * common/gdb_unlinker.h: Rename include guard.
15360 * common/gdb_unique_ptr.h: Rename include guard.
15361 * common/gdb_tilde_expand.h: Rename include guard.
15362 * common/gdb_sys_time.h: Rename include guard.
15363 * common/gdb_string_view.h: Rename include guard.
15364 * common/gdb_splay_tree.h: Rename include guard.
15365 * common/gdb_setjmp.h: Rename include guard.
15366 * common/gdb_ref_ptr.h: Rename include guard.
15367 * common/gdb_optional.h: Rename include guard.
15368 * common/gdb_locale.h: Rename include guard.
15369 * common/gdb_assert.h: Rename include guard.
15370 * common/filtered-iterator.h: Rename include guard.
15371 * common/filestuff.h: Rename include guard.
15372 * common/fileio.h: Rename include guard.
15373 * common/environ.h: Rename include guard.
15374 * common/common-utils.h: Rename include guard.
15375 * common/common-types.h: Rename include guard.
15376 * common/common-regcache.h: Rename include guard.
15377 * common/common-inferior.h: Rename include guard.
15378 * common/common-gdbthread.h: Rename include guard.
15379 * common/common-exceptions.h: Rename include guard.
15380 * common/common-defs.h: Rename include guard.
15381 * common/common-debug.h: Rename include guard.
15382 * common/cleanups.h: Rename include guard.
15383 * common/buffer.h: Rename include guard.
15384 * common/btrace-common.h: Rename include guard.
15385 * common/break-common.h: Rename include guard.
15386 * cli/cli-utils.h: Rename include guard.
15387 * cli/cli-style.h: Rename include guard.
15388 * cli/cli-setshow.h: Rename include guard.
15389 * cli/cli-script.h: Rename include guard.
15390 * cli/cli-interp.h: Rename include guard.
15391 * cli/cli-decode.h: Rename include guard.
15392 * cli/cli-cmds.h: Rename include guard.
15393 * charset-list.h: Add include guard.
15394 * buildsym-legacy.h: Rename include guard.
15395 * bfin-tdep.h: Add include guard.
15396 * ax.h: Rename include guard.
15397 * arm-linux-tdep.h: Add include guard.
15398 * arm-fbsd-tdep.h: Add include guard.
15399 * arch/xtensa.h: Rename include guard.
15400 * arch/tic6x.h: Add include guard.
15401 * arch/i386.h: Add include guard.
15402 * arch/arm.h: Rename include guard.
15403 * arch/arm-linux.h: Rename include guard.
15404 * arch/arm-get-next-pcs.h: Rename include guard.
15405 * arch/amd64.h: Add include guard.
15406 * arch/aarch64-insn.h: Rename include guard.
15407 * arch-utils.h: Rename include guard.
15408 * annotate.h: Add include guard.
15409 * amd64-darwin-tdep.h: Rename include guard.
15410 * aarch64-linux-tdep.h: Add include guard.
15411 * aarch64-fbsd-tdep.h: Add include guard.
15412 * aarch32-linux-nat.h: Add include guard.
15413
ab9268d2
PW		 154142019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15415
15416 * macrotab.c (macro_define_internal): New function that
15417 factorizes macro_define_object_internal and macro_define_function
15418 code.
15419 (macro_define_object_internal): Use macro_define_internal.
15420 (macro_define_function): Likewise.
15421
bb0da2b4
PW		 154222019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15423
15424 * macrocmd.c (extract_identifier): Return
15425 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15426 callers.
15427
424eb552
JB		 154282019-02-06 John Baldwin <jhb@FreeBSD.org>
15429
15430 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15431
1688cb29
TT		 154322019-02-05 Tom Tromey <tom@tromey.com>
15433
15434 * target.c (target_stack::unpush): Move assertion earlier.
15435
b5eba2d8
TT		 154362019-01-30 Tom Tromey <tom@tromey.com>
15437
15438 PR python/23615:
15439 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15440 (gdbpy_parse_and_eval): Likewise.
15441 * python/python-internal.h (gdbpy_allow_threads): New class.
15442
7054e2ff
JB		 154432019-01-28 John Baldwin <jhb@FreeBSD.org>
15444
15445 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15446 (aarch64_fbsd_fpregmap): Move earlier.
15447 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15448 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15449 instead of individual calls to trad_frame_set_reg_addr.
15450 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15451 earlier.
15452 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15453 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15454 instead of individual calls to trad_frame_set_reg_addr.
15455
36c25ffa
AH		 154562019-01-28 Alan Hayward <alan.hayward@arm.com>
15457
15458 * CONTRIBUTE: Replace contribution list with wiki link.
15459
a0707f3c
TT		 154602019-01-25 Tom Tromey <tom@tromey.com>
15461
15462 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15463
0747795c
TT		 154642019-01-25 Tom Tromey <tom@tromey.com>
15465
15466 * xtensa-linux-nat.c: Fix common/ includes.
15467 * xml-support.h: Fix common/ includes.
15468 * xml-support.c: Fix common/ includes.
15469 * x86-linux-nat.c: Fix common/ includes.
15470 * windows-nat.c: Fix common/ includes.
15471 * varobj.h: Fix common/ includes.
15472 * varobj.c: Fix common/ includes.
15473 * value.c: Fix common/ includes.
15474 * valops.c: Fix common/ includes.
15475 * utils.c: Fix common/ includes.
15476 * unittests/xml-utils-selftests.c: Fix common/ includes.
15477 * unittests/utils-selftests.c: Fix common/ includes.
15478 * unittests/unpack-selftests.c: Fix common/ includes.
15479 * unittests/tracepoint-selftests.c: Fix common/ includes.
15480 * unittests/style-selftests.c: Fix common/ includes.
15481 * unittests/string_view-selftests.c: Fix common/ includes.
15482 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15483 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15484 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15485 * unittests/rsp-low-selftests.c: Fix common/ includes.
15486 * unittests/parse-connection-spec-selftests.c: Fix common/
15487 includes.
15488 * unittests/optional-selftests.c: Fix common/ includes.
15489 * unittests/offset-type-selftests.c: Fix common/ includes.
15490 * unittests/observable-selftests.c: Fix common/ includes.
15491 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15492 * unittests/memrange-selftests.c: Fix common/ includes.
15493 * unittests/memory-map-selftests.c: Fix common/ includes.
15494 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15495 * unittests/function-view-selftests.c: Fix common/ includes.
15496 * unittests/environ-selftests.c: Fix common/ includes.
15497 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15498 * unittests/common-utils-selftests.c: Fix common/ includes.
15499 * unittests/cli-utils-selftests.c: Fix common/ includes.
15500 * unittests/array-view-selftests.c: Fix common/ includes.
15501 * ui-file.c: Fix common/ includes.
15502 * tui/tui-io.c: Fix common/ includes.
15503 * tracepoint.h: Fix common/ includes.
15504 * tracepoint.c: Fix common/ includes.
15505 * tracefile-tfile.c: Fix common/ includes.
15506 * top.h: Fix common/ includes.
15507 * top.c: Fix common/ includes.
15508 * thread.c: Fix common/ includes.
15509 * target/waitstatus.h: Fix common/ includes.
15510 * target/waitstatus.c: Fix common/ includes.
15511 * target.h: Fix common/ includes.
15512 * target.c: Fix common/ includes.
15513 * target-memory.c: Fix common/ includes.
15514 * target-descriptions.c: Fix common/ includes.
15515 * symtab.h: Fix common/ includes.
15516 * symfile.c: Fix common/ includes.
15517 * stap-probe.c: Fix common/ includes.
15518 * spu-linux-nat.c: Fix common/ includes.
15519 * sparc-nat.c: Fix common/ includes.
15520 * source.c: Fix common/ includes.
15521 * solib.c: Fix common/ includes.
15522 * solib-target.c: Fix common/ includes.
15523 * ser-unix.c: Fix common/ includes.
15524 * ser-tcp.c: Fix common/ includes.
15525 * ser-pipe.c: Fix common/ includes.
15526 * ser-base.c: Fix common/ includes.
15527 * selftest-arch.c: Fix common/ includes.
15528 * s12z-tdep.c: Fix common/ includes.
15529 * rust-exp.y: Fix common/ includes.
15530 * rs6000-aix-tdep.c: Fix common/ includes.
15531 * riscv-tdep.c: Fix common/ includes.
15532 * remote.c: Fix common/ includes.
15533 * remote-notif.h: Fix common/ includes.
15534 * remote-fileio.h: Fix common/ includes.
15535 * remote-fileio.c: Fix common/ includes.
15536 * regcache.h: Fix common/ includes.
15537 * regcache.c: Fix common/ includes.
15538 * record-btrace.c: Fix common/ includes.
15539 * python/python.c: Fix common/ includes.
15540 * python/py-type.c: Fix common/ includes.
15541 * python/py-inferior.c: Fix common/ includes.
15542 * progspace.h: Fix common/ includes.
15543 * producer.c: Fix common/ includes.
15544 * procfs.c: Fix common/ includes.
15545 * proc-api.c: Fix common/ includes.
15546 * printcmd.c: Fix common/ includes.
15547 * ppc-linux-nat.c: Fix common/ includes.
15548 * parser-defs.h: Fix common/ includes.
15549 * osdata.c: Fix common/ includes.
15550 * obsd-nat.c: Fix common/ includes.
15551 * nat/x86-linux.c: Fix common/ includes.
15552 * nat/x86-linux-dregs.c: Fix common/ includes.
15553 * nat/x86-dregs.h: Fix common/ includes.
15554 * nat/x86-dregs.c: Fix common/ includes.
15555 * nat/ppc-linux.c: Fix common/ includes.
15556 * nat/mips-linux-watch.h: Fix common/ includes.
15557 * nat/mips-linux-watch.c: Fix common/ includes.
15558 * nat/linux-waitpid.c: Fix common/ includes.
15559 * nat/linux-ptrace.h: Fix common/ includes.
15560 * nat/linux-ptrace.c: Fix common/ includes.
15561 * nat/linux-procfs.c: Fix common/ includes.
15562 * nat/linux-personality.c: Fix common/ includes.
15563 * nat/linux-osdata.c: Fix common/ includes.
15564 * nat/linux-namespaces.c: Fix common/ includes.
15565 * nat/linux-btrace.h: Fix common/ includes.
15566 * nat/linux-btrace.c: Fix common/ includes.
15567 * nat/fork-inferior.c: Fix common/ includes.
15568 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15569 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15570 * nat/aarch64-linux.c: Fix common/ includes.
15571 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15572 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15573 * namespace.h: Fix common/ includes.
15574 * mips-linux-tdep.c: Fix common/ includes.
15575 * minsyms.c: Fix common/ includes.
15576 * mi/mi-parse.h: Fix common/ includes.
15577 * mi/mi-main.c: Fix common/ includes.
15578 * mi/mi-cmd-env.c: Fix common/ includes.
15579 * memrange.h: Fix common/ includes.
15580 * memattr.c: Fix common/ includes.
15581 * maint.h: Fix common/ includes.
15582 * maint.c: Fix common/ includes.
15583 * main.c: Fix common/ includes.
15584 * machoread.c: Fix common/ includes.
15585 * location.c: Fix common/ includes.
15586 * linux-thread-db.c: Fix common/ includes.
15587 * linux-nat.c: Fix common/ includes.
15588 * linux-fork.c: Fix common/ includes.
15589 * inline-frame.c: Fix common/ includes.
15590 * infrun.c: Fix common/ includes.
15591 * inflow.c: Fix common/ includes.
15592 * inferior.h: Fix common/ includes.
15593 * inferior.c: Fix common/ includes.
15594 * infcmd.c: Fix common/ includes.
15595 * inf-ptrace.c: Fix common/ includes.
15596 * inf-child.c: Fix common/ includes.
15597 * ia64-linux-nat.c: Fix common/ includes.
15598 * i387-tdep.c: Fix common/ includes.
15599 * i386-tdep.c: Fix common/ includes.
15600 * i386-linux-tdep.c: Fix common/ includes.
15601 * i386-linux-nat.c: Fix common/ includes.
15602 * i386-go32-tdep.c: Fix common/ includes.
15603 * i386-fbsd-tdep.c: Fix common/ includes.
15604 * i386-fbsd-nat.c: Fix common/ includes.
15605 * guile/scm-type.c: Fix common/ includes.
15606 * guile/guile.c: Fix common/ includes.
15607 * go32-nat.c: Fix common/ includes.
15608 * gnu-nat.c: Fix common/ includes.
15609 * gdbthread.h: Fix common/ includes.
15610 * gdbarch-selftests.c: Fix common/ includes.
15611 * gdb_usleep.c: Fix common/ includes.
15612 * gdb_select.h: Fix common/ includes.
15613 * gdb_bfd.c: Fix common/ includes.
15614 * gcore.c: Fix common/ includes.
15615 * fork-child.c: Fix common/ includes.
15616 * findvar.c: Fix common/ includes.
15617 * fbsd-nat.c: Fix common/ includes.
15618 * event-top.c: Fix common/ includes.
15619 * event-loop.c: Fix common/ includes.
15620 * dwarf2read.c: Fix common/ includes.
15621 * dwarf2loc.c: Fix common/ includes.
15622 * dwarf2-frame.c: Fix common/ includes.
15623 * dwarf-index-cache.c: Fix common/ includes.
15624 * dtrace-probe.c: Fix common/ includes.
15625 * disasm-selftests.c: Fix common/ includes.
15626 * defs.h: Fix common/ includes.
15627 * csky-tdep.c: Fix common/ includes.
15628 * cp-valprint.c: Fix common/ includes.
15629 * cp-support.h: Fix common/ includes.
15630 * cp-support.c: Fix common/ includes.
15631 * corelow.c: Fix common/ includes.
15632 * completer.h: Fix common/ includes.
15633 * completer.c: Fix common/ includes.
15634 * compile/compile.c: Fix common/ includes.
15635 * compile/compile-loc2c.c: Fix common/ includes.
15636 * compile/compile-cplus-types.c: Fix common/ includes.
15637 * compile/compile-cplus-symbols.c: Fix common/ includes.
15638 * command.h: Fix common/ includes.
15639 * cli/cli-dump.c: Fix common/ includes.
15640 * cli/cli-cmds.c: Fix common/ includes.
15641 * charset.c: Fix common/ includes.
15642 * build-id.c: Fix common/ includes.
15643 * btrace.h: Fix common/ includes.
15644 * btrace.c: Fix common/ includes.
15645 * breakpoint.h: Fix common/ includes.
15646 * breakpoint.c: Fix common/ includes.
15647 * ax.h:
15648 (enum agent_op): Fix common/ includes.
15649 * ax-general.c (struct aop_map): Fix common/ includes.
15650 * ax-gdb.c: Fix common/ includes.
15651 * auxv.c: Fix common/ includes.
15652 * auto-load.c: Fix common/ includes.
15653 * arm-tdep.c: Fix common/ includes.
15654 * arch/riscv.c: Fix common/ includes.
15655 * arch/ppc-linux-common.c: Fix common/ includes.
15656 * arch/i386.c: Fix common/ includes.
15657 * arch/arm.c: Fix common/ includes.
15658 * arch/arm-linux.c: Fix common/ includes.
15659 * arch/arm-get-next-pcs.c: Fix common/ includes.
15660 * arch/amd64.c: Fix common/ includes.
15661 * arch/aarch64.c: Fix common/ includes.
15662 * arch/aarch64-insn.c: Fix common/ includes.
15663 * arch-utils.c: Fix common/ includes.
15664 * amd64-windows-tdep.c: Fix common/ includes.
15665 * amd64-tdep.c: Fix common/ includes.
15666 * amd64-sol2-tdep.c: Fix common/ includes.
15667 * amd64-obsd-tdep.c: Fix common/ includes.
15668 * amd64-nbsd-tdep.c: Fix common/ includes.
15669 * amd64-linux-tdep.c: Fix common/ includes.
15670 * amd64-linux-nat.c: Fix common/ includes.
15671 * amd64-fbsd-tdep.c: Fix common/ includes.
15672 * amd64-fbsd-nat.c: Fix common/ includes.
15673 * amd64-dicos-tdep.c: Fix common/ includes.
15674 * amd64-darwin-tdep.c: Fix common/ includes.
15675 * agent.c: Fix common/ includes.
15676 * ada-lang.h: Fix common/ includes.
15677 * ada-lang.c: Fix common/ includes.
15678 * aarch64-tdep.c: Fix common/ includes.
15679
2f5c153e
TT		 156802019-01-25 Tom Tromey <tom@tromey.com>
15681
15682 * common/create-version.sh: Use common/version.h.
15683
adc6a863
PA		 156842019-01-24 Pedro Alves <palves@redhat.com>
15685
15686 * infrun.c (signal_stop, signal_print, signal_program)
15687 (signal_catch, signal_pass): Now arrays instead of pointers.
15688 (update_signals_program_target, do_target_resume)
15689 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15690 * linux-nat.c (linux_nat_target::pass_signals)
15691 (linux_nat_target::create_inferior, linux_nat_target::attach):
15692 Adjust.
15693 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15694 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15695 * procfs.c (procfs_target::pass_signals): Adjust.
15696 * record-full.c (record_full_target::resume): Adjust.
15697 * remote.c (remote_target::pass_signals)
15698 (remote_target::program_signals): Adjust.
15699 * target-debug.h (target_debug_print_signals): Now takes a
15700 gdb::array_view as parameter. Adjust.
15701 * target.h (target_ops) <pass_signals, program_signals>: Replace
15702 pointer and length parameters with gdb::array_view.
15703 (target_pass_signals, target_program_signals): Likewise.
15704 * target-delegates.c: Regenerate.
15705
3046d67a
PA		 157062019-01-24 Pedro Alves <palves@redhat.com>
15707
15708 * common/forward-scope-exit.h
15709 (forward_scope_exit::forward_scope_exit): Pass arguments to
15710 m_bind_function directly, instead of creating a std::bind and
15711 copying that.
15712
353229bf
AH		 157132019-01-24 Alan Hayward <alan.hayward@arm.com>
15714
15715 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15716 for static members.
15717 (pass_in_v_vfp_candidate): Likewise.
15718
311dc83a
TT		 157192019-01-23 Tom Tromey <tom@tromey.com>
15720 Pedro Alves <palves@redhat.com>
15721
15722 * regcache.c (class regcache_invalidator): Remove.
15723 (regcache::raw_write): Use make_scope_exit.
15724
296bd123
TT		 157252019-01-23 Tom Tromey <tom@tromey.com>
15726
15727 * ui-out.h (class ui_out_emit_type): Update comment.
15728
979a0d13
TT		 157292019-01-23 Tom Tromey <tom@tromey.com>
15730
15731 * infrun.c (fetch_inferior_event): Update comment.
15732
d238133d
TT		 157332019-01-23 Tom Tromey <tom@tromey.com>
15734 Pedro Alves <palves@redhat.com>
15735
15736 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15737 parameter.
15738 (fetch_inferior_event): Use SCOPE_EXIT.
15739
15740
9885e6bb
TT		 157412019-01-23 Tom Tromey <tom@tromey.com>
15742 Pedro Alves <palves@redhat.com>
15743
15744 * infrun.c (disable_thread_events): Delete.
15745 (stop_all_threads): Use SCOPE_EXIT.
15746
286526c1
TT		 157472019-01-23 Tom Tromey <tom@tromey.com>
15748 Pedro Alves <palves@redhat.com>
15749
15750 * symfile.c: Include forward-scope-exit.h.
15751 (clear_symtab_users_cleanup): Replace forward declaration with
15752 a FORWARD_SCOPE_EXIT.
15753 (syms_from_objfile_1): Use the forward_scope_exit and
15754 gdb::optional instead of cleanup_function.
15755 (reread_symbols): Use the forward_scope_exit instead of
15756 cleanup_function.
15757 (clear_symtab_users_cleanup): Remove function.
15758
1db93f14
TT		 157592019-01-23 Tom Tromey <tom@tromey.com>
15760 Pedro Alves <palves@redhat.com>
15761
15762 * linux-nat.c: Include scope-exit.h.
15763 (cleanup_target_stop): Remove.
15764 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15765 SCOPE_EXIT.
15766
2cc83d1e
TT		 157672019-01-23 Tom Tromey <tom@tromey.com>
15768 Pedro Alves <palves@redhat.com>
15769
15770 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15771 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15772
694c6bf5
TT		 157732019-01-23 Tom Tromey <tom@tromey.com>
15774 Andrew Burgess <andrew.burgess@embecosm.com>
15775 Pedro Alves <palves@redhat.com>
15776
15777 * infrun.c (fetch_inferior_event): Use scope_exit.
15778 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15779 * top.c (execute_command): Use scope_exit.
15780 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15781 * utils.c (do_bpstat_clear_actions_cleanup)
15782 (make_bpstat_clear_actions_cleanup): Remove.
15783
4c41382a
TT		 157842019-01-23 Tom Tromey <tom@tromey.com>
15785 Pedro Alves <palves@redhat.com>
15786
15787 * infrun.c: Include "common/scope-exit.h"
15788 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15789 (wait_for_inferior): Use SCOPE_EXIT.
15790 (fetch_inferior_event): Use scope_exit.
15791
89f8fb50
TT		 157922019-01-23 Tom Tromey <tom@tromey.com>
15793 Pedro Alves <palves@redhat.com>
15794
15795 * breakpoint.c (create_breakpoint): Remove cleanup.
15796
5419bdae
TT		 157972019-01-23 Tom Tromey <tom@tromey.com>
15798 Andrew Burgess <andrew.burgess@embecosm.com>
15799 Pedro Alves <palves@redhat.com>
15800
e587ef42
PA		 158012019-01-23 Pedro Alves <palves@redhat.com>
15802
15803 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15804
77f0e74c
PA		 158052019-01-23 Pedro Alves <palves@redhat.com>
15806 Andrew Burgess <andrew.burgess@embecosm.com>
15807
15808 * gdbthread.h: Include "common/forward-scope-exit.h".
15809 (scoped_finish_thread_state): Redefine custom class in terms of
15810 forward_scope_exit.
15811
5b9b3e53
PA		 158122019-01-23 Pedro Alves <palves@redhat.com>
15813 Andrew Burgess <andrew.burgess@embecosm.com>
15814
15815 * common/forward-scope-exit.h: New file.
15816
54b65c9b
PA		 158172019-01-23 Pedro Alves <palves@redhat.com>
15818 Andrew Burgess <andrew.burgess@embecosm.com>
15819 Tom Tromey <tom@tromey.com>
15820
15821 * common/scope-exit.h: New file.
15822
cf08fb29
PA		 158232019-01-23 Pedro Alves <palves@redhat.com>
15824
15825 * common/preprocessor.h (ESC): Rename to ...
15826 (ESC_PARENS): ... this.
15827 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15828 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15829
ae73e2e2
TT		 158302019-01-23 Tom Tromey <tom@tromey.com>
15831
15832 * language.h (class scoped_switch_to_sym_language_if_auto):
15833 Initialize m_lang in both cases.
15834
6594e122
AH		 158352019-01-23 Alan Hayward <alan.hayward@arm.com>
15836
15837 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15838 with XCNEW.
15839
a7c9855d
TT		 158402019-01-22 Tom Tromey <tom@tromey.com>
15841
15842 * corelow.c: Do not include sys/file.h.
15843
93cc1d53
TT		 158442019-01-22 Tom Tromey <tom@tromey.com>
15845
15846 * tui/tui-wingeneral.h: Include gdb_curses.h.
15847
38561778
TT		 158482019-01-22 Tom Tromey <tom@tromey.com>
15849
15850 * source-cache.h (class source_cache) <get_source_lines,
15851 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15852
37b3ab5b
TT		 158532019-01-22 Tom Tromey <tom@tromey.com>
15854
15855 * remote-fileio.h (struct remote_target): Declare.
15856
3fabc016
TT		 158572019-01-22 Tom Tromey <tom@tromey.com>
15858
15859 * python/py-arch.c: Do not include py-ref.h.
15860 * python/py-bpevent.c: Do not include py-ref.h.
15861 * python/py-cmd.c: Do not include py-ref.h.
15862 * python/py-continueevent.c: Do not include py-ref.h.
15863 * python/py-event.h: Do not include py-ref.h.
15864 * python/py-evtregistry.c: Do not include py-ref.h.
15865 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15866 * python/py-frame.c: Do not include py-ref.h.
15867 * python/py-framefilter.c: Do not include py-ref.h.
15868 * python/py-function.c: Do not include py-ref.h.
15869 * python/py-infevents.c: Do not include py-ref.h.
15870 * python/py-linetable.c: Do not include py-ref.h.
15871 * python/py-objfile.c: Do not include py-ref.h.
15872 * python/py-param.c: Do not include py-ref.h.
15873 * python/py-prettyprint.c: Do not include py-ref.h.
15874 * python/py-progspace.c: Do not include py-ref.h.
15875 * python/py-symbol.c: Do not include py-ref.h.
15876 * python/py-symtab.c: Do not include py-ref.h.
15877 * python/py-type.c: Do not include py-ref.h.
15878 * python/py-unwind.c: Do not include py-ref.h.
15879 * python/py-utils.c: Do not include py-ref.h.
15880 * python/py-value.c: Do not include py-ref.h.
15881 * python/py-varobj.c: Do not include py-ref.h.
15882 * python/py-xmethods.c: Do not include py-ref.h.
15883 * python/python.c: Do not include py-ref.h.
15884 * varobj.c: Do not include py-ref.h.
15885
6b4d7774
TT		 158862019-01-22 Tom Tromey <tom@tromey.com>
15887
15888 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15889 keyword for bcache.
15890
7af7e9b5
TT		 158912019-01-22 Tom Tromey <tom@tromey.com>
15892
15893 * compile/compile-cplus-types.c: Remove a comment by #include.
15894
951d1049
TT		 158952019-01-22 Tom Tromey <tom@tromey.com>
15896
15897 * compile/gcc-c-plugin.h: Include compile-internal.h.
15898
d65d5705
TT		 158992019-01-22 Tom Tromey <tom@tromey.com>
15900
15901 * stabsread.c (EXTERN): Do not define.
15902 (symnum, next_symbol_text_func, processing_gcc_compilation)
15903 (within_function, global_sym_chain, global_stabs)
15904 (previous_stab_code, this_object_header_files)
15905 (n_this_object_header_files)
15906 (n_allocated_this_object_header_files): Define.
15907 * stabsread.h (EXTERN): Never define. Use "extern".
15908
b6fb1ee5
PW		 159092019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15910
15911 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15912 history_value.
15913
be6d4f74
TT		 159142019-01-21 Tom Tromey <tom@tromey.com>
15915
15916 * ui-out.c: Fix includes.
15917 * tui/tui-source.c: Fix includes.
15918 * target.c: Fix includes.
15919 * remote.c: Fix includes.
15920 * regcache.c: Fix includes.
15921 * python/py-block.c: Fix includes.
15922 * printcmd.c: Fix includes.
15923 * or1k-tdep.c: Fix includes.
15924 * mi/mi-main.c: Fix includes.
15925 * m32r-tdep.c: Fix includes.
15926 * csky-tdep.c: Fix includes.
15927 * compile/compile-cplus-types.c: Fix includes.
15928 * cli/cli-interp.c: Fix includes.
15929
73021deb
AH		 159302019-01-21 Alan Hayward <alan.hayward@arm.com>
15931
15932 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15933 for padding.
15934
7932255d
TT		 159352019-01-16 Tom Tromey <tom@tromey.com>
15936
15937 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15938 earlier.
15939 (struct objfile) <msymbols_range>: Move from top level.
15940 <msymbols>: New method.
15941 (class objfile_msymbols): Remove.
15942 * symtab.c (default_collect_symbol_completion_matches_break_on):
15943 Update.
15944 * symmisc.c (dump_msymbols): Update.
15945 * stabsread.c (scan_file_globals): Update.
15946 * objc-lang.c (info_selectors_command, info_classes_command)
15947 (find_methods): Update.
15948 * minsyms.c (find_solib_trampoline_target): Update.
15949 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15950 * coffread.c (coff_symfile_read): Update.
15951 * ada-lang.c (ada_lookup_simple_minsym)
15952 (ada_collect_symbol_completion_matches): Update.
15953
604b1bfb
TT		 159542019-01-16 Tom Tromey <tom@tromey.com>
15955
15956 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15957 type. Remove no-argument constructor.
15958 <iterator::operator++>: Simplify.
15959 <begin>: Update.
15960 <end>: Use minimal_symbol_count.
15961
f252c6d5
TT		 159622019-01-16 Tom Tromey <tom@tromey.com>
15963
15964 * objfiles.h (struct objfile) <psymtabs>: New method.
15965 (class objfile_psymtabs): Remove.
15966 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15967 typedef.
15968 <range>: New method.
15969 (require_partial_symbols): Change return type.
15970 * psymtab.c (require_partial_symbols)
15971 (psym_expand_symtabs_matching): Update.
15972 * mdebugread.c (parse_partial_symbols): Update.
15973 * dbxread.c (dbx_end_psymtab): Update.
15974
b669c953
TT		 159752019-01-15 Tom Tromey <tom@tromey.com>
15976
15977 * symtab.c (lookup_objfile_from_block)
15978 (lookup_symbol_in_objfile_symtabs)
15979 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15980 (find_line_symtab, info_sources_command)
15981 (default_collect_symbol_completion_matches_break_on)
15982 (make_source_files_completion_list): Update.
15983 * symmisc.c (print_objfile_statistics, dump_objfile)
15984 (maintenance_print_symbols, maintenance_info_symtabs)
15985 (maintenance_check_symtabs, maintenance_info_line_tables):
15986 Update.
15987 * source.c (select_source_symtab)
15988 (forget_cached_source_info_for_objfile): Update.
15989 * objfiles.h (class objfile_compunits): Remove.
15990 (struct objfile) <compunits_range>: New typedef.
15991 (compunits): New method.
15992 * objfiles.c (objfile_relocate1): Update.
15993 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15994 * maint.c (count_symtabs_and_blocks): Update.
15995 * linespec.c (iterate_over_all_matching_symtabs): Update.
15996 * cp-support.c (add_symbol_overload_list_qualified): Update.
15997 * coffread.c (coff_symtab_read): Update.
15998 * ada-lang.c (add_nonlocal_symbols)
15999 (ada_collect_symbol_completion_matches)
16000 (ada_add_global_exceptions): Update.
16001
7e955d83
TT		 160022019-01-15 Tom Tromey <tom@tromey.com>
16003
16004 * progspace.h (program_space) <objfiles_safe_range>: New
16005 typedef.
16006 <objfiles_safe>: New method.
16007 * objfiles.h (class all_objfiles_safe): Remove.
16008 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16009 * jit.c (jit_inferior_exit_hook): Update.
16010
2030c079
TT		 160112019-01-17 Tom Tromey <tom@tromey.com>
16012
16013 * progspace.h (program_space) <objfiles_range>: New typedef.
16014 <objfiles>: New method.
16015 <objfiles_head>: Rename from objfiles.
16016 (object_files): Update.
16017 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16018 * guile/scm-pretty-print.c
16019 (ppscm_find_pretty_printer_from_objfiles): Update.
16020 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16021 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16022 Update.
16023 * python/py-progspace.c (pspy_get_objfiles): Update.
16024 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16025 Update.
16026 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16027 (objfpy_lookup_objfile_by_build_id): Update.
16028 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16029 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16030 Update.
16031 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16032 (expand_symtab_containing_pc, lookup_objfile_from_block)
16033 (lookup_static_symbol, basic_lookup_transparent_type)
16034 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16035 (find_line_symtab, info_sources_command)
16036 (default_collect_symbol_completion_matches_break_on)
16037 (make_source_files_completion_list, find_main_name): Update.
16038 * symmisc.c (print_symbol_bcache_statistics)
16039 (print_objfile_statistics, maintenance_print_symbols)
16040 (maintenance_print_msymbols, maintenance_print_objfiles)
16041 (maintenance_info_symtabs, maintenance_check_symtabs)
16042 (maintenance_expand_symtabs, maintenance_info_line_tables):
16043 Update.
16044 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16045 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16046 (map_overlay_command, unmap_overlay_command)
16047 (simple_overlay_update, expand_symtabs_matching)
16048 (map_symbol_filenames): Update.
16049 * symfile-debug.c (set_debug_symfile): Update.
16050 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16051 Update.
16052 * source.c (select_source_symtab, forget_cached_source_info):
16053 Update.
16054 * solib.c (solib_read_symbols): Update.
16055 * solib-spu.c (append_ocl_sos): Update.
16056 * psymtab.c (maintenance_print_psymbols)
16057 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16058 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16059 * printcmd.c (info_symbol_command): Update.
16060 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16061 Update.
16062 * objfiles.h (class all_objfiles): Remove.
16063 * objfiles.c (have_partial_symbols, have_full_symbols)
16064 (have_minimal_symbols, qsort_cmp, update_section_map)
16065 (shared_objfile_contains_address_p)
16066 (default_iterate_over_objfiles_in_search_order): Update.
16067 * objc-lang.c (info_selectors_command, info_classes_command)
16068 (find_methods): Update.
16069 * minsyms.c (find_solib_trampoline_target): Update.
16070 * maint.c (maintenance_info_sections)
16071 (maintenance_translate_address, count_symtabs_and_blocks):
16072 Update.
16073 * main.c (captured_main_1): Update.
16074 * linux-thread-db.c (try_thread_db_load_from_pdir)
16075 (has_libpthread): Update.
16076 * linespec.c (iterate_over_all_matching_symtabs)
16077 (search_minsyms_for_name): Update.
16078 * jit.c (jit_find_objf_with_entry_addr): Update.
16079 * hppa-tdep.c (find_unwind_entry)
16080 (hppa_lookup_stub_minimal_symbol): Update.
16081 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16082 Update.
16083 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16084 (elf_gnu_ifunc_resolve_by_got): Update.
16085 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16086 * dwarf-index-write.c (save_gdb_index_command): Update.
16087 * cp-support.c (add_symbol_overload_list_qualified): Update.
16088 * breakpoint.c (create_overlay_event_breakpoint)
16089 (create_longjmp_master_breakpoint)
16090 (create_std_terminate_master_breakpoint)
16091 (create_exception_master_breakpoint): Update.
16092 * blockframe.c (find_pc_partial_function): Update.
16093 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16094 (ada_collect_symbol_completion_matches)
16095 (ada_add_global_exceptions): Update.
16096
776489e0
TT		 160972019-01-17 Tom Tromey <tom@tromey.com>
16098
16099 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16100 declare VEC.
16101 (solib_target_parse_libraries): Change return type.
16102 (library_list_start_segment, library_list_start_section)
16103 (library_list_end_library, library_list_start_library); Update.
16104 (solib_target_free_library_list): Remove.
16105 (solib_target_parse_libraries): Remove cleanup. Change return
16106 type.
16107 (solib_target_current_sos): Update.
16108
6471e7d2
TT		 161092019-01-17 Tom Tromey <tromey@bapiya>
16110
16111 * valprint.c: Replace "the the" with "the".
16112 * symtab.c: Replace "the the" with "the".
16113 * solib.c: Replace "the the" with "the".
16114 * solib-dsbt.c: Replace "the the" with "the".
16115 * linespec.c: Replace "the the" with "the".
16116 * dwarf2loc.h: Replace "the the" with "the".
16117 * amd64-windows-tdep.c: Replace "the the" with "the".
16118 * aarch64-tdep.c: Replace "the the" with "the".
16119
c24bdb02
KS		 161202019-01-16 Keith Seitz <keiths@redhat.com>
16121
16122 PR gdb/23773
16123 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16124 <builder>: Rename to ..
16125 <m_builder>: ... this and make private.
16126 (dwarf2_cu::get_builder): New method. Change all users of
16127 `builder' to use this method.
16128 (dwarf2_start_symtab): Move to ...
16129 (dwarf2_cu::start_symtab): ... here. Update all callers
16130 (setup_type_unit_groups): Move to ...
16131 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16132 callers.
16133 (dwarf2_cu::reset_builder): New method.
16134 (process_full_compunit, process_full_type_unit): Use
16135 dwarf2_cu::reset_builder.
16136 (follow_die_offset): Record the ancestor CU if it is different
16137 from the followed DIE's CU.
16138 (follow_die_sig_1): Likewise.
16139
8d64371b
TT		 161402019-01-15 Tom Tromey <tom@tromey.com>
16141
16142 * remote.c (class remote_state) <buf>: Now a char_vector.
16143 <buf_size>: Remove.
16144 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16145 parameter.
16146 (remote_target::getpkt_or_notif_sane_1)
16147 (remote_target::getpkt_sane)
16148 (remote_target::getpkt_or_notif_sane): Likewise.
16149 (class remote_target) <putpkt>: New overload.
16150 (remote_target::read_frame): Change type of "buf_p". Remove
16151 sizeof_p parameter.
16152 (packet_ok): New overload.
16153 (packet_check_result): New overload.
16154 Update all uses.
16155
bb277751
TT		 161562019-01-14 Tom Tromey <tom@tromey.com>
16157
16158 * remote-notif.c (handle_notification, remote_notif_ack)
16159 (remote_notif_parse): Make "buf" const.
16160 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16161 const.
16162 (remote_notif_parse, remote_notif_ack, handle_notification):
16163 Likewise.
16164 * remote.c (remote_notif_stop_parse): Make "buf" const.
16165 (remote_target::remote_parse_stop_reply): Make "buf" const.
16166 (remote_notif_stop_ack): Make "buf" const.
16167
05be00a8
TT		 161682019-01-14 Tom Tromey <tom@tromey.com>
16169
16170 * remote.c (remote_console_output): Make parameter const.
16171
491adeca
TT		 161722019-01-14 Tom Tromey <tom@tromey.com>
16173
16174 * target-debug.h (target_debug_print_signals): Constify.
16175 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16176 * procfs.c (procfs_target::pass_signals): Update.
16177 * linux-nat.c (linux_nat_target::pass_signals): Update.
16178 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16179 * target-delegates.c: Rebuild.
16180 * remote.c (remote_target::program_signals): Update.
16181 (remote_target::pass_signals): Update.
16182 * target.c (target_pass_signals): Constify argument.
16183 (target_program_signals): Likewise.
16184 * target.h (struct target_ops) <pass_signals, program_signals>:
16185 Constify argument.
16186 (target_pass_signals, target_program_signals): Constify argument.
16187
bbd94648
TT		 161882019-01-14 Tom Tromey <tom@tromey.com>
16189
16190 PR tui/28819:
16191 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16192
6f072a10
PFC		 161932019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16194
16195 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16196 field.
16197 * rs6000-tdep.c: Include reggroups.h.
16198 (IS_V_ALIAS_PSEUDOREG): Define.
16199 (rs6000_register_name): Return names for the "vX" aliases.
16200 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16201 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16202 aliases. Call default_register_reggroup_p for all other
16203 pseudo-registers.
16204 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16205 New functions.
16206 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16207 Handle "vX" aliases.
16208 (v_alias_pseudo_register_collect): New function.
16209 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16210 (rs6000_gdbarch_init): Initialize "vX" aliases as
16211 pseudo-registers. Restore registration of
16212 rs6000_pseudo_register_reggroup_p with
16213 set_tdesc_pseudo_register_reggroup_p.
16214
1a782351
MF		 162152019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16216
16217 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16218 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16219 set_gdbarch_num_pseudo_regs.
16220
d73cff18
PW		 162212019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16222
16223 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16224 Remove arg prefixname, add do_set and do_show.
16225 Add member functions set_list and show_list.
16226 * cli/cli-style.c (class cli_style_option): Update accordingly.
16227 (style_set_list): Move to file scope.
16228 (style_show_list): Likewise.
16229 (set_style): Call help_list.
16230 (show_style): Call cmd_show_list.
16231 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16232 Update to use the new macro.
16233
60a90376
JB		 162342019-10-12 Joel Brobecker <brobecker@adacore.com>
16235
16236 * ada-lang.c (_initialize_ada_language): Expand the help text
16237 for the "catch exception" command.
16238
9d7c67bf
PW		 162392019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16240
16241 * symtab.c (matching_obj_sections): Initialize obj,
16242 declare it closer to its usage.
16243
7cf47dc4
TT		 162442019-01-10 Tom Tromey <tom@tromey.com>
16245
16246 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16247 (basic_inf_threads_range): Remove.
16248 (inf_threads_range, inf_non_exited_threads_range)
16249 (safe_inf_threads_range): Use next_adapter.
16250
d3cb6808
KS		 162512019-01-10 Keith Seitz <keiths@redhat.com>
16252
16253 PR gdb/23712
16254 PR symtab/23010
16255 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16256 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16257
63a20375
KS		 162582019-01-10 Keith Seitz <keiths@redhat.com>
16259
16260 PR gdb/23712
16261 PR symtab/23010
16262 * dictionary.c (pending_to_vector): Remove.
16263 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16264 Remove _1 suffix, replacing functions of the same name. Update
16265 all callers.
16266 (dict_create_hashed, dict_create_hashed_expandable)
16267 (dict_create_linear, dict_create_linear_expandable, dict_free)
16268 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16269 Make functions static.
16270
b026f593
KS		 162712019-01-10 Keith Seitz <keiths@redhat.com>
16272
16273 PR gdb/23712
16274 PR symtab/23010
16275 * dictionary.h (struct dictionary): Replace declaration with
16276 multidictionary.
16277 (dict_create_hashed, dict_create_hashed_expandable)
16278 (dict_create_linear, dict_create_linear_expandable)
16279 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16280 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16281 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16282 taking multidictionary argument.
16283 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16284 * block.h (struct block) <dict>: Change to multidictionary
16285 and rename `multidict'.
16286 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16287 symmisc.c: Update all dictionary references to multidictionary.
16288
c7748ee9
KS		 162892019-01-10 Keith Seitz <keiths@redhat.com>
16290
16291 PR gdb/23712
16292 PR symtab/23010
16293 * dictionary.c: Include unordered_map.
16294 (pending_to_vector): New function.
16295 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16296 Rewrite the non-"_1" functions to take vector instead
16297 of linked list.
16298 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16299 "new" _1 versions of the same name.
16300 (multidictionary): Define.
16301 (std::hash<enum language): New definition.
16302 (collate_pending_symbols_by_language, mdict_create_hashed)
16303 (mdict_create_hashed_expandable, mdict_create_linear)
16304 (mdict_create_linear_expandable, mdict_free)
16305 (find_language_dictionary, create_new_language_dictionary)
16306 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16307 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16308 (mdict_size, mdict_empty): New functions.
16309 * dictionary.h (mdict_iterator): Define.
16310
67aa1f3c
PA		 163112019-01-10 Pedro Alves <palves@redhat.com>
16312
16313 * breakpoint.c (read_uploaded_action)
16314 (create_tracepoint_from_upload): Adjust to use
16315 gdb::unique_xmalloc_ptr.
16316 * ctf.c (ctf_write_uploaded_tp):
16317 (SET_ARRAY_FIELD): Use emplace_back.
16318 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16319 * tracefile-tfile.c (tfile_write_uploaded_tp):
16320 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16321 gdb::unique_xmalloc_ptr.
16322 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16323 at_string, cond_string, cmd_strings>: Replace char pointers
16324 with gdb::unique_xmalloc_ptr.
16325
2f667667
PA		 163262019-01-10 Pedro Alves <palves@redhat.com>
16327
16328 * solib-target.c (library_list_start_library): Don't xstrdup name.
16329
36cb7237
PA		 163302019-01-10 Pedro Alves <palves@redhat.com>
16331
16332 * mdebugread.c (parse_partial_symbols): Use
16333 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16334
da584958
AB		 163352019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16336
16337 * linux-fork.c (scoped_switch_fork_info)
16338 <~scoped_switch_fork_info>: Fix incorrect variable name.
16339
1ef8573c
AB		 163402019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16341
16342 * linux-fork.c (scoped_switch_fork_info)
16343 <scoped_switch_fork_info>: Make explicit.
16344 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16345
8d7bcccb
TT		 163462019-01-10 Tom Tromey <tom@tromey.com>
16347
16348 * objfiles.h (objfile::reset_psymtabs): Update.
16349 * objfiles.c (objfile::objfile): Update.
16350 * psymtab.h (psymtab_storage::obstack): Update.
16351 (psymtab_storage::m_obstack): Use gdb::optional.
16352 (class psymtab_storage): Update comment. Remove objfile
16353 parameter.
16354 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16355
b596a3c7
TT		 163562019-01-10 Tom Tromey <tom@tromey.com>
16357
16358 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16359 <free_psymtabs>: Now private.
16360 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16361 (allocate_psymtab): Use new method.
16362
a9342b62
TT		 163632019-01-10 Tom Tromey <tom@tromey.com>
16364
16365 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16366 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16367 * mdebugread.c (parse_partial_symbols): Use
16368 allocate_dependencies.
16369 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16370 allocate_dependencies.
16371 (process_psymtab_comp_unit_reader)
16372 (build_type_psymtab_dependencies): Likewise.
16373 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16374
5af70966
TT		 163752019-01-10 Tom Tromey <tom@tromey.com>
16376
16377 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16378 PSYMBOL_SET_LANGUAGE.
16379 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16380
5923a04c
TT		 163812019-01-10 Tom Tromey <tom@tromey.com>
16382
16383 * psymtab.h (psymtab_storage::obstack): New method.
16384 <m_obstack>: Rename from obstack; now private.
16385 * psymtab.c (psymtab_storage): Update.
16386 * dwarf2read.c (create_addrmap_from_index)
16387 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16388 Update.
16389
6d6a12bf
TT		 163902019-01-10 Tom Tromey <tom@tromey.com>
16391
16392 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16393 * objfiles.h (objfile::reset_psymtabs): New method.
16394
d320c2b5
TT		 163952019-01-10 Tom Tromey <tom@tromey.com>
16396
16397 * symmisc.c (print_symbol_bcache_statistics): Update.
16398 (print_objfile_statistics): Update.
16399 * symfile.c (reread_symbols): Update.
16400 * psymtab.h (class psymtab_storage): New.
16401 * psymtab.c (psymtab_storage): New constructor.
16402 (~psymtab_storage): New destructor.
16403 (require_partial_symbols): Update.
16404 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16405 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16406 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16407 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16408 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16409 (start_psymtab_common, end_psymtab_common)
16410 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16411 (allocate_psymtab): Update.
16412 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16413 Update.
16414 (dump_psymtab_addrmap, maintenance_print_psymbols)
16415 (maintenance_check_psymtabs): Update.
16416 (class objfile_psymtabs): Move to objfiles.h.
16417 * psympriv.h (discard_psymtab): Now inline.
16418 (psymtab_discarder::psymtab_discarder): Update.
16419 (psymtab_discarder::~psymtab_discarder): Update.
16420 (ALL_OBJFILE_PSYMTABS): Rewrite.
16421 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16422 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16423 Remove fields.
16424 <partial_symtabs>: New field.
16425 (class objfile_psymtabs): Move from psymtab.h. Update.
16426 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16427 psymbol_cache.
16428 (objfile::~objfile): Don't destroy psymbol_cache.
16429 * mdebugread.c (parse_partial_symbols): Update.
16430 * dwarf2read.c (create_addrmap_from_index)
16431 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16432 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16433 (add_partial_subprogram, dwarf2_ranges_read): Update.
16434 * dwarf-index-write.c (write_address_map)
16435 (write_one_signatured_type, recursively_write_psymbols)
16436 (class debug_names, class debug_names, write_psymtabs_to_index):
16437 Update.
16438
1d94a5a3
TT		 164392019-01-10 Tom Tromey <tom@tromey.com>
16440
16441 * symtab.h (SYMBOL_SET_NAMES): Update.
16442 (symbol_set_names): Update.
16443 (MSYMBOL_SET_NAMES): Update.
16444 * symtab.c (symbol_set_names): Change argument to be an
16445 objfile_per_bfd_storage.
16446 * psymtab.c (add_psymbol_to_bcache): Update.
16447 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16448
0f14768a
TT		 164492019-01-10 Tom Tromey <tom@tromey.com>
16450
16451 * symtab.c (create_demangled_names_hash): Change argument to be an
16452 objfile_per_bfd_storage.
16453 (symbol_set_names): Update.
16454
6eee24ce
TT		 164552019-01-10 Tom Tromey <tom@tromey.com>
16456
16457 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16458 init_psymbol_list.
16459 * psymtab.c (init_psymbol_list): Do nothing if already called.
16460 * psympriv.h (init_psymbol_list): Add comment.
16461 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16462 init_psymbol_list.
16463 * dbxread.c (dbx_symfile_read): Unconditionally call
16464 init_psymbol_list.
16465
75aedd27
TT		 164662019-01-10 Tom Tromey <tom@tromey.com>
16467
16468 * xcoffread.c (scan_xcoff_symtab): Update.
16469 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16470 "where".
16471 * mdebugread.c (parse_partial_symbols)
16472 (handle_psymbol_enumerators): Update.
16473 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16474 * dbxread.c (read_dbx_symtab): Update.
16475 * psympriv.h (psymbol_placement): New enum.
16476 (add_psymbol_to_list): Update.
16477
939652a5
TT		 164782019-01-10 Tom Tromey <tom@tromey.com>
16479
16480 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16481 static_psymbols parameters.
16482 (scan_xcoff_symtab): Update.
16483 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16484 static_psymbols parameters.
16485 * psympriv.h (start_psymtab_common): Update.
16486 * mdebugread.c (parse_partial_symbols): Update.
16487 * dwarf2read.c (create_partial_symtab): Update.
16488 * dbxread.c (read_dbx_symtab): Update.
16489 (start_psymtab): Remove global_psymbols and static_psymbols
16490 parameters.
16491
baa62830
TT		 164922019-01-10 Tom Tromey <tom@tromey.com>
16493
16494 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16495 * psymtab.c (allocate_psymtab): Add comment.
16496 * psympriv.h (allocate_psymtab): Add comment.
16497 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16498 initializations.
16499 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16500
0e8f53ba
TT		 165012019-01-10 Tom Tromey <tom@tromey.com>
16502
16503 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16504 Don't declare.
16505 * mipsread.c: Include mdebugread.h.
16506 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16507 Declare.
16508 * elfread.c: Include mdebugread.h.
16509
b22a7c6a
TT		 165102019-01-09 Tom Tromey <tom@tromey.com>
16511
16512 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16513 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16514 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16515 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16516 (psym_lookup_symbol, psym_find_last_source_symtab)
16517 (psym_forget_cached_source_info, psym_print_stats)
16518 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16519 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16520 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16521 (psym_find_compunit_symtab_by_address)
16522 (maintenance_print_psymbols, maintenance_info_psymtabs)
16523 (maintenance_check_psymtabs): Use ranged for.
16524 * psymtab.h (class objfile_psymtabs): New.
16525 (require_partial_symbols): Return objfile_psymtabs.
16526 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16527
3b9d3ac2
TT		 165282019-01-09 Tom Tromey <tom@tromey.com>
16529
16530 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16531 (find_pc_mapped_section, list_overlays_command)
16532 (map_overlay_command, unmap_overlay_command)
16533 (simple_overlay_update): Use all_objfiles.
16534 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16535 * printcmd.c (info_symbol_command): Use all_objfiles.
16536 * objfiles.h (ALL_OBJSECTIONS): Remove.
16537 * maint.c (maintenance_translate_address): Use all_objfiles.
16538 * gcore.c (gcore_create_callback): Use all_objfiles.
16539 (objfile_find_memory_regions): Likewise.
16540
8b31193a
TT		 165412019-01-09 Tom Tromey <tom@tromey.com>
16542
16543 * symtab.c (find_line_symtab, info_sources_command)
16544 (make_source_files_completion_list): Use objfile_compunits.
16545 * source.c (select_source_symtab): Use objfile_compunits.
16546 * objfiles.h (struct objfile): Update comment.
16547 (ALL_OBJFILES): Remove.
16548 (ALL_FILETABS): Remove.
16549 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16550 objfile_compunits.
16551
d5da8b3c
TT		 165522019-01-09 Tom Tromey <tom@tromey.com>
16553
16554 * symmisc.c (print_objfile_statistics, dump_objfile)
16555 (maintenance_print_symbols): Use compunit_filetabs.
16556 * source.c (forget_cached_source_info_for_objfile): Use
16557 compunit_filetabs.
16558 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16559 (ALL_FILETABS): Use compunit_filetabs.
16560 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16561 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16562
5accd1a0
TT		 165632019-01-09 Tom Tromey <tom@tromey.com>
16564
16565 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16566 (compunit_filetabs): New.
16567 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16568 compunit_filetabs.
16569 (info_sources_command, make_source_files_completion_list): Remove
16570 declaration.
16571 * symmisc.c (print_objfile_statistics, dump_objfile)
16572 (maintenance_print_symbols): Remove declaration.
16573 (maintenance_info_symtabs): Use compunit_filetabs.
16574 (maintenance_info_line_tables): Likewise.
16575 * source.c (select_source_symtab): Change local variable name.
16576 (forget_cached_source_info_for_objfile): Remove declaration.
16577 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16578 * objfiles.c (objfile_relocate1): Remove declaration.
16579 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16580 declaration.
16581 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16582 * coffread.c (coff_symtab_read): Remove declaration.
16583 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16584 compunit_filetabs.
16585
d8aeb77f
TT		 165862019-01-09 Tom Tromey <tom@tromey.com>
16587
16588 * symtab.c (lookup_objfile_from_block)
16589 (find_pc_sect_compunit_symtab, search_symbols)
16590 (default_collect_symbol_completion_matches_break_on): Use
16591 objfile_compunits.
16592 * objfiles.h (ALL_COMPUNITS): Remove.
16593 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16594 * cp-support.c (add_symbol_overload_list_qualified): Use
16595 objfile_compunits.
16596 * ada-lang.c (ada_collect_symbol_completion_matches)
16597 (ada_add_global_exceptions): Use objfile_compunits.
16598
592553c4
TT		 165992019-01-09 Tom Tromey <tom@tromey.com>
16600
16601 * source.c (select_source_symtab)
16602 (forget_cached_source_info_for_objfile): Remove declaration.
16603 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16604 declaration.
16605 * maint.c (count_symtabs_and_blocks): Remove declaration.
16606 * cp-support.c (add_symbol_overload_list_qualified): Remove
16607 declaration.
16608 * coffread.c (coff_symtab_read): Remove declaration.
16609 * symtab.c (lookup_symbol_in_objfile_symtabs)
16610 (basic_lookup_transparent_type_1): Use objfile_compunits.
16611 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16612 (info_sources_command, search_symbols)
16613 (default_collect_symbol_completion_matches_break_on)
16614 (make_source_files_completion_list): Remove declaration.
16615 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16616 (ada_collect_symbol_completion_matches)
16617 (ada_add_global_exceptions): Remove declaration.
16618 * linespec.c (iterate_over_all_matching_symtabs): Use
16619 objfile_compunits.
16620 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16621 (class objfile_compunits): New.
16622 (ALL_COMPUNITS): Use objfile_compunits.
16623 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16624 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16625 objfile_compunits.
16626 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16627
5325b9bf
TT		 166282019-01-09 Tom Tromey <tom@tromey.com>
16629
16630 * symtab.c (search_symbols)
16631 (default_collect_symbol_completion_matches_break_on): Use
16632 objfile_msymbols.
16633 * ada-lang.c (ada_lookup_simple_minsym)
16634 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16635 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16636 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16637 objfile_msymbols.
16638 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16639 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16640 * objc-lang.c (find_methods): Use objfile_msymbols.
16641 (info_selectors_command, info_classes_command): Likewise.
16642 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16643 * objfiles.h (class objfile_msymbols): New.
16644 (ALL_OBJFILE_MSYMBOLS): Remove.
16645 (ALL_MSYMBOLS): Remove.
16646
cac85af2
TT		 166472019-01-09 Tom Tromey <tom@tromey.com>
16648
16649 * common/next-iterator.h (next_adapter): Add Iterator template
16650 parameter.
16651 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16652 (class all_objfiles_safe): New.
16653 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16654 * objfiles.c (put_objfile_before): Update comment.
16655 (add_separate_debug_objfile): Likewise.
16656 (free_all_objfiles): Use all_objfiles_safe.
16657 (objfile_purge_solibs): Likewise.
16658
aed57c53
TT		 166592019-01-09 Tom Tromey <tom@tromey.com>
16660
16661 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16662 (expand_symtab_containing_pc, lookup_static_symbol)
16663 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16664 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16665 all_objfiles.
16666 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16667 * breakpoint.c (create_overlay_event_breakpoint)
16668 (create_longjmp_master_breakpoint)
16669 (create_std_terminate_master_breakpoint)
16670 (create_exception_master_breakpoint): Use all_objfiles.
16671 * linux-thread-db.c (try_thread_db_load_from_pdir)
16672 (has_libpthread): Use all_objfiles.
16673 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16674 * linespec.c (iterate_over_all_matching_symtabs)
16675 (search_minsyms_for_name): Use all_objfiles.
16676 * maint.c (maintenance_info_sections): Use all_objfiles.
16677 * main.c (captured_main_1): Use all_objfiles.
16678 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16679 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16680 * guile/scm-pretty-print.c
16681 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16682 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16683 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16684 (maintenance_print_msymbols): Use all_objfiles.
16685 * source.c (select_source_symtab): Use all_objfiles.
16686 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16687 * symfile.c (remove_symbol_file_command)
16688 (expand_symtabs_matching, map_symbol_filenames): Use
16689 all_objfiles.
16690 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16691 all_objfiles.
16692 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16693 * objc-lang.c (find_methods): Use all_objfiles.
16694 * objfiles.c (have_partial_symbols, have_full_symbols)
16695 (have_minimal_symbols, qsort_cmp)
16696 (default_iterate_over_objfiles_in_search_order): Use
16697 all_objfiles.
16698 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16699 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16700 (maintenance_check_psymtabs): Use all_objfiles.
16701 (ALL_PSYMTABS): Remove.
16702 * compile/compile-object-run.c (do_module_cleanup): Use
16703 all_objfiles.
16704 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16705 * cp-support.c (add_symbol_overload_list_qualified): Use
16706 all_objfiles.
16707 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16708 Use all_objfiles.
16709 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16710 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16711 all_objfiles.
16712 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16713 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16714 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16715 Uses all_objfiles.
16716 * solib.c (solib_read_symbols): Use all_objfiles
16717
99d89cde
TT		 167182019-01-09 Tom Tromey <tom@tromey.com>
16719
16720 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16721 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16722 all_objfiles.
16723 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16724 * symmisc.c (print_symbol_bcache_statistics)
16725 (print_objfile_statistics, maintenance_print_objfiles)
16726 (maintenance_info_symtabs, maintenance_check_symtabs)
16727 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16728 all_objfiles.
16729 * source.c (forget_cached_source_info): Use all_objfiles.
16730 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16731 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16732 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16733 * objfiles.c (update_section_map): Use all_objfiles.
16734 (shared_objfile_contains_address_p): Likewise.
16735 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16736 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16737
21708325
TT		 167382019-01-09 Tom Tromey <tom@tromey.com>
16739
16740 * common/next-iterator.h: New file.
16741 * objfiles.h (class all_objfiles): New.
16742 (struct objfile_iterator): New.
16743
669e09f6
PW		 167442019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16745
16746 * NEWS: Move the description of the changed "frame", "select-frame",
16747 and "info frame" commands to the Changed commands section.
16748
041be526
SM		 167492019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16750
16751 * gdbtypes.c (check_stub_method_group): Remove handling of old
16752 mangling schemes.
16753 * linespec.c (find_methods): Likewise.
16754 * stabsread.c (read_member_functions): Likewise.
16755 * valops.c (search_struct_method): Likewise.
16756 (value_struct_elt_for_reference): Likewise.
16757 * NEWS: Mention this change.
16758
0e2a2133
AB		 167592019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16760
16761 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16762 print_source_lines.
16763 * source.c (print_source_lines_base): Update line number check.
16764 (print_source_lines): New function.
16765 (source_lines_range::source_lines_range): New function.
16766 * source.h (class source_lines_range): New class.
16767 (print_source_lines): New declaration.
16768
1055a3b4
PW		 167692019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16770
16771 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16772
cfeadda5
TT		 167732019-01-08 Tom Tromey <tom@tromey.com>
16774 Simon Marchi <simon.marchi@ericsson.com>
16775
16776 PR gdb/24060
16777 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16778 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16779 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16780 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16781 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16782 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16783
583068ca
AB		 167842019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16785
16786 * source.c (select_source_symtab): Move header comment to
16787 declaration in source.h.
16788 (forget_cached_source_info_for_objfile): Likewise.
16789 (forget_cached_source_info): Likewise.
16790 (identify_source_line): Likewise.
16791 * source.h (identify_source_line): Move declaration from symtab.h
16792 and add comment from source.c
16793 (print_source_lines): Likewise.
16794 (forget_cached_source_info_for_objfile): Likewise.
16795 (forget_cached_source_info): Likewise.
16796 (select_source_symtab): Likewise.
16797 (enum print_source_lines_flag): Move definition from symtab.h.
16798 * symtab.h (identify_source_line): Move declaration to source.h.
16799 (print_source_lines): Likewise.
16800 (forget_cached_source_info_for_objfile): Likewise.
16801 (forget_cached_source_info): Likewise.
16802 (select_source_symtab): Likewise.
16803 (enum print_source_lines_flag): Move definition to source.h.
16804 * tui/tui-hooks.c: Add 'source.h' include.
16805
ec98a4ad
AB		 168062019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16807
16808 * source.c (print_source_lines_base): Handle requests to print
16809 reverse line number sequences, and guard against empty lines
16810 string.
16811
62ea19c1
AB		 168122019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16813
16814 * source.c (print_source_lines_base): Fix skip of '\r' if next
16815 character is '\n'.
16816
9d30e1fd
TT		 168172019-01-06 Tom Tromey <tom@tromey.com>
16818
16819 * c-exp.y (struct c_parse_state) <macro_original_text,
16820 expansion_obstack>: New member.
16821 (macro_original_text, expansion_obstack): Remove globals.
16822 (scan_macro_expansion, scanning_macro_expansion)
16823 (finished_macro_expansion): Update.
16824 (scan_macro_cleanup): Remove.
16825 (yylex, c_parse): Update.
16826
c65bac38
TT		 168272019-01-06 Tom Tromey <tom@tromey.com>
16828
16829 * c-exp.y (struct c_parse_state) <strings>: New member.
16830 (operator_stoken): Update.
16831
02e12e38
TT		 168322019-01-06 Tom Tromey <tom@tromey.com>
16833
16834 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16835 (union type_stack_elt) <typelist_val>: Now a pointer to
16836 std::vector.
16837 (type_stack_cleanup): Don't declare.
16838 (push_typelist): Update.
16839 * parse.c (pop_typelist): Return a std::vector.
16840 (push_typelist): Take a std::vector.
16841 (follow_types): Update. Do not free args.
16842 (type_stack_cleanup): Remove.
16843 * c-exp.y (struct c_parse_state): New.
16844 (cpstate): New global.
16845 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16846 (nonempty_typelist): Update.
16847 (func_mod): Create a new vector.
16848 (c_parse): Create a c_parse_state.
16849 (check_parameter_typelist): Do not delete params.
16850 (function_method): Update. Do not delete type_list.
16851
f097f5ad
TT		 168522019-01-06 Tom Tromey <tom@tromey.com>
16853
16854 PR gdb/28155:
16855 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16856 check_typedef.
16857 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16858 (print_return_value): Likewise.
16859
d2adf9f1
TT		 168602019-01-05 Tom Tromey <tom@tromey.com>
16861
16862 * contrib/cleanup_check.py: Remove.
16863 * contrib/gcc-with-excheck: Remove.
16864 * contrib/exsummary.py: Remove.
16865 * contrib/excheck.py: Remove.
16866
2eab46b1
JB		 168672019-01-05 Joel Brobecker <brobecker@adacore.com>
16868
16869 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16870 NULL. Initialize tpprev to NULL instead of assigning it
16871 to NULL on the next statement.
16872 * windows-nat.c (windows_delete_thread): Remove check for
16873 main_thread_id before printing thread exit notifications.
16874 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16875 Remove thread ID check against main_thread_id.
16876 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16877 windows_delete_thread.
16878 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16879
48c5e7e2
TT		 168802019-01-04 Tom Tromey <tom@tromey.com>
16881
16882 * compile/compile.c (_initialize_compile): Use upper case for
16883 metasyntactic variables.
16884 * symmisc.c (_initialize_symmisc): Use upper case for
16885 metasyntactic variables.
16886 * psymtab.c (_initialize_psymtab): Use upper case for
16887 metasyntactic variables.
16888 * demangle.c (demangle_command): Use upper case for metasyntactic
16889 variables.
16890 (_initialize_demangler): Likewise.
16891 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16892 variables.
16893
986041cd
TT		 168942019-01-03 Tom Tromey <tom@tromey.com>
16895
16896 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16897
7c711119
TT		 168982019-01-03 Tom Tromey <tom@tromey.com>
16899
16900 * python/py-symtab.c (salpy_str): Update.
16901 (struct salpy_sal_object) <symtab>: Now a PyObject.
16902 (salpy_dealloc): Update.
16903 (del_objfile_sal): Use gdbpy_ref.
16904
1b20edf0
TT		 169052019-01-03 Tom Tromey <tom@tromey.com>
16906
16907 * python/py-type.c (convert_field): Use new_reference. Return
16908 gdbpy_ref.
16909 (make_fielditem): Return gdbpy_ref.
16910 (typy_fields): Update.
16911 (typy_getitem): Update.
16912 (field_name): Return gdbpy_ref. Use new_reference.
16913 (typy_iterator_iternext): Update.
16914
ea41325b
TT		 169152019-01-03 Tom Tromey <tom@tromey.com>
16916
16917 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16918
2a3c71d6
TT		 169192019-01-03 Tom Tromey <tom@tromey.com>
16920
16921 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16922 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16923 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16924 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16925 (pspy_set_type_printers): Likewise.
16926 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16927 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16928 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16929 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16930 (objfpy_set_type_printers): Likewise.
16931
5c329e6a
TT		 169322019-01-03 Tom Tromey <tom@tromey.com>
16933
16934 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16935 (gdbpy_print_stack): Use gdbpy_err_fetch.
16936 * python/python-internal.h (class gdbpy_err_fetch): New class.
16937 (class gdbpy_enter) <m_error_type, m_error_value,
16938 m_error_traceback>: Remove.
16939 <m_error>: New member.
16940 (gdbpy_exception_to_string): Don't declare.
16941 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16942 * python/py-value.c (convert_value_from_python): Use
16943 gdbpy_err_fetch.
16944 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16945 gdbpy_exception_to_string.
16946 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16947 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16948 gdbpy_err_fetch.
16949
169bb27b
AB		 169502019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16951
16952 * linux-nat.c (delete_lwp_cleanup): Delete.
16953 (struct lwp_deleter): New struct.
16954 (lwp_info_up): New typedef.
16955 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16956 lwp_info_up.
16957
a07c8880
AB		 169582019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16959
16960 * linux-fork.c (class scoped_switch_fork_info): New class.
16961 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16962
26089c49
AB		 169632019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16964
16965 * valops.c (find_overload_match): Remove use of null_cleanup, and
16966 calls to do_cleanups.
16967
06d3e5b0
AB		 169682019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16969
16970 * compile/compile-cplus-types.c
16971 (compile_cplus_instance::decl_name): Handle changes to
16972 cp_func_name.
16973 * cp-support.c (cp_func_name): Update header comment, update
16974 return type.
16975 * cp-support.h (cp_func_name): Update return type in declaration.
16976 * valops.c (find_overload_match): Move temp_func local to top
16977 level of function and change its type. Use temp_func to hold and
16978 delete temporary string obtained from cp_func_name.
16979
66644cd3
AB		 169802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16981
16982 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16983 gdb::char_vector, remove cleanup, and update uses of `msg`.
16984
592d8c0a
JW		 169852019-01-03 Jim Wilson <jimw@sifive.com>
16986
16987 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16988
c55d06ec
TT		 169892019-01-02 Tom Tromey <tom@tromey.com>
16990
16991 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16992 (tdesc_parse_xml): Remove cleanups.
16993 * target-descriptions.h (make_cleanup_free_target_description):
16994 Don't declare.
16995 (target_desc_deleter): New struct.
16996 (target_desc_up): New typedef.
16997 * target-descriptions.c (target_desc_deleter::operator()): Rename
16998 from free_target_description.
16999 (make_cleanup_free_target_description): Remove.
17000
3a6ae42d
TT		 170012019-01-02 Tom Tromey <tom@tromey.com>
17002
17003 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17004 constructor, destructor.
17005 (linespec_parser): Remove typedef.
17006 (~linespec_parser): Rename from linespec_parser_delete.
17007 (linespec_lex_to_end, linespec_complete_label)
17008 (linespec_complete): Update.
17009 (decode_line_full): Remove cleanups.
17010 (decode_line_1): Update.
17011
61fd3e73
TT		 170122019-01-02 Tom Tromey <tom@tromey.com>
17013
17014 * python/python-internal.h (inferior_to_inferior_object): Change
17015 return type.
17016 * python/py-exitedevent.c (create_exited_event_object): Update.
17017 * python/py-inferior.c (inferior_to_inferior_object): Return
17018 gdbpy_ref.
17019 (python_new_inferior, python_inferior_deleted)
17020 (thread_to_thread_object, delete_thread_object)
17021 (build_inferior_list, gdbpy_selected_inferior): Update.
17022 * python/py-infthread.c (create_thread_object): Update. Also fail
17023 if inferior_to_inferior_object fails.
17024
d20172fc
SM		 170252019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17026
17027 * inferior.h (class inferior) <displaced_step_state>: New field.
17028 * infrun.h (struct displaced_step_state): Move here from
17029 infrun.c. Initialize fields, add constructor.
17030 <inf>: Remove field.
17031 <reset>: New method.
17032 * infrun.c (struct displaced_step_inferior_state): Move to
17033 infrun.h.
17034 (displaced_step_inferior_states): Remove.
17035 (get_displaced_stepping_state): Adust.
17036 (displaced_step_in_progress_any_inferior): Adjust.
17037 (displaced_step_in_progress_thread): Adjust.
17038 (displaced_step_in_progress): Adjust.
17039 (add_displaced_stepping_state): Remove.
17040 (get_displaced_step_closure_by_addr): Adjust.
17041 (remove_displaced_stepping_state): Remove.
17042 (infrun_inferior_exit): Call displaced_step_state.reset.
17043 (use_displaced_stepping): Don't check for NULL.
17044 (displaced_step_prepare_throw): Call
17045 get_displaced_stepping_state.
17046 (displaced_step_fixup): Don't check for NULL.
17047 (prepare_for_detach): Don't check for NULL.
17048
e3319240
PW		 170492019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17050
17051 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17052 in case of call that did not complete.
17053
5d36dfb9
AU		 170542019-01-02 Andrey Utkin <autkin@undo.io>
17055
17056 * symfile.c (find_separate_debug_file): Fix search of debug files for
17057 remote debuggee.
17058
8833fbf0
TT		 170592019-01-02 Tom Tromey <tom@tromey.com>
17060
17061 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17062 indentation.
17063 * python/py-frame.c (frapy_older): Remove cast.
17064 (frapy_newer): Likewise.
17065 * python/py-breakpoint.c (local_setattro): Remove cast.
17066 * python/py-arch.c (archpy_name): Remove local variable.
17067 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17068
4ada3dfd
JB		 170692019-01-02 Joel Brobecker <brobecker@adacore.com>
17070
17071 * unittests/basic_string_view/element_access/char/empty.cc:
17072 Fix year range in copyright header.
17073
113b7b81
AB		 170742019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17075
17076 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17077 Delete.
17078 <operator==>: Update with for removed field.
17079 <hash>: Likewise.
17080 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17081 <isa_features>: ...this.
17082 <abi_features>: New field.
17083 (riscv_isa_flen): Update comment.
17084 (riscv_abi_xlen): New declaration.
17085 (riscv_abi_flen): New declaration.
17086 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17087 isa_features.
17088 (riscv_abi_xlen): New function.
17089 (riscv_isa_flen): Update to get answer from isa_features.
17090 (riscv_abi_flen): New function.
17091 (riscv_has_fp_abi): Update to get answer from abi_features.
17092 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17093 xlen and flen.
17094 (riscv_call_info) <xlen, flen>: Update comment.
17095 (riscv_call_arg_struct): Remove invalid assertions
17096 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17097 is removed.
17098 (riscv_gdbarch_init): Gather isa features and abi features
17099 separately, ensure both match on the gdbarch when reusing an old
17100 gdbarch. Relax an error check to allow 32-bit abi float to run on
17101 a target with 64-bit float hardware.
17102
b18ca514
PW		 171032019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17104
17105 * source.c (search_command_helper): Stop reverse search
17106 when line 1 has been searched.
17107
ec70d8db
PW		 171082019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17109
17110 * record-full.c (record_full_base_target::close): Rewrite
17111 record_full_core_buf_list free logic.
17112
5b38f9c1
PW		 171132019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17114
17115 * break-catch-syscall.c (print_one_catch_syscall): xfree
17116 the last text.
17117
66d91b39
JB		 171182019-01-01 Joel Brobecker <brobecker@adacore.com>
17119
17120 * top.c (print_gdb_version): Update Copyright year in version
17121 message.
17122
42a4f53d
JB		 171232019-01-01 Joel Brobecker <brobecker@adacore.com>
17124
17125 Update copyright year range in all GDB files.
17126
7e955d83 171272019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17128
5bbd631d 17129 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17130
5bbd631d 17131For older changes see ChangeLog-2018.
c906108c
SS		 17132\f
17133Local Variables:
17134mode: change-log
17135left-margin: 8
17136fill-column: 74
17137version-control: never
57da7796 17138coding: utf-8
c906108c 17139End:
5bbd631d 17140
GDB Binutils - Deliverables
This page took 3.850941 seconds and 4 git commands to generate.