Remove tui_show_disassem
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
855f89b3
TT
12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
4 update_source_window directly.
5 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
6 * tui/tui-disasm.c (tui_show_disassem): Remove.
7
d4669c0f
TT
82019-12-20 Tom Tromey <tom@tromey.com>
9
10 * tui/tui-winsource.c
11 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
12 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
13
1ae58f0c
TT
142019-12-20 Tom Tromey <tom@tromey.com>
15
16 * tui/tui-winsource.h (struct tui_source_window_base)
17 <maybe_update>: Remove line_no and addr parameters.
18 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
19 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
20 Update.
21 * tui/tui-source.c (tui_source_window::maybe_update): Remove
22 line_no and addr parameters.
23 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
24 Update.
25 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
26 line_no and addr parameters.
27
039298ec
TT
282019-12-20 Tom Tromey <tom@tromey.com>
29
30 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
31 (tui_source_window_base::update_breakpoint_info): Remove asserts.
32
8acfefcc
TT
332019-12-20 Tom Tromey <tom@tromey.com>
34
35 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
36 tui_show_disassem.
37 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
38 declare.
39 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
40
5ebd5402
TT
412019-12-20 Tom Tromey <tom@tromey.com>
42
43 * tui/tui.h (tui_show_source): Remove parameters.
44 * tui/tui.c (tui_show_source): Remove parameters.
45 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
46
c1b167d7
TT
472019-12-20 Tom Tromey <tom@tromey.com>
48
49 * tui/tui.c (tui_show_source): Update.
50 * tui/tui-winsource.c (tui_display_main): Update.
51 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
52 to symtab.
53 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
54 to symtab.
55 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
56
364d7104
TT
572019-12-20 Tom Tromey <tom@tromey.com>
58
59 PR tui/23619:
60 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
61 (tui_redisplay_readline): Use rl_display_prompt.
62 (tui_prep_terminal): Update.
63
0ad6b8ee
CB
642019-12-19 Christian Biesinger <cbiesinger@google.com>
65
66 * configure: Regenerate.
67 * configure.ac: Quote variable arguments of test.
68 * gdbsupport/common.m4: Likewise.
69
d411762c
CB
702019-12-19 Christian Biesinger <cbiesinger@google.com>
71
72 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
73 2 to pow ().
74
1cd4a20a
CB
752019-12-19 Christian Biesinger <cbiesinger@google.com>
76
77 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
78 log10 to double to fix Solaris 11 with gcc 5.5.
79
aa989b27
CB
802019-12-19 Christian Biesinger <cbiesinger@google.com>
81
82 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
83 "sun" to "saddr_un".
84
2032eb7e
TT
852019-12-19 Tom Tromey <tromey@adacore.com>
86
87 * ui-out.h (enum class field_kind): Fix comment.
88
f69656d0
TT
892019-12-11 Tom Tromey <tromey@adacore.com>
90
91 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
92
27e4fac7
TT
932019-12-18 Tom Tromey <tromey@adacore.com>
94
95 PR build/25268:
96 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
97 type on macOS. Add comment.
98
e623f035
SM
992019-12-18 Simon Marchi <simon.marchi@efficios.com>
100
101 * c-lang.c (c_get_string, asm_language_defn): Remove space
102 before tab.
103
28ce7b07
TT
1042019-12-18 Tom Tromey <tromey@adacore.com>
105
106 PR build/25250:
107 * ui-out.c (ui_out::vmessage): Update.
108 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
109 Rename.
110 (string_field): Update.
111 (signed_field): Update.
112
bbde7025
SM
1132019-12-18 Simon Marchi <simon.marchi@efficios.com>
114
115 * top.c (print_gdb_configuration): Adjust indentation.
116
e3169fe0
CB
1172019-12-17 Christian Biesinger <cbiesinger@google.com>
118
119 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
120
9b30da15
SM
1212019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
122
123 * tui/tui-layout.h (class tui_layout_base): Add virtual
124 destructor.
125
4a4c04f1
BE
1262019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
127
128 * infcmd.c (prepare_one_step): Step over skipped inline functions.
129 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
130 (process_event_stop_test): Keep stepping over skipped inline functions.
131
0394eed1
SM
1322019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
133
134 * jit.c (struct gdb_block) <next>: Remove field.
135 (struct gdb_symtab) <~gdb_symtab>: Remove.
136 <blocks>: Change type to std::forward_list<gdb_block>.
137 (compare_block): Remove.
138 (jit_block_open_impl): Adjust to std::forward_list. Place the new
139 block at the beginning, don't mind about sorting.
140 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
141 before using it.
142
b6112117
SM
1432019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
144
145 * jit.c (struct gdb_block): Add constructor, initialize
146 real_block and next fields.
147 <name>: Change type to gdb::unique_xmalloc_ptr.
148 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
149 (jit_block_open_impl): Allocate gdb_block with new.
150 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
151
1b61f46d
SM
1522019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
153
154 * jit.c: Include forward_list.
155 (struct gdb_symtab) <next>: Remove field.
156 (struct gdb_object) <symtabs>: Change type to
157 std::forward_list<gdb_symtab>.
158 (jit_object_open_impl): Allocate gdb_object with new.
159 (jit_symtab_open_impl): Adjust to std::forward_list.
160 (finalize_symtab): Don't delete symtab.
161 (jit_object_close_impl): Adjust to std::forward_list. Free
162 gdb_object with delete.
163
89867184
SM
1642019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
165
166 * jit.c (struct gdb_symtab): Add constructor, destructor,
167 initialize fields.
168 <linetable>: Change type to unique_xmalloc_ptr.
169 <file_name>: Change type to std::string.
170 (jit_symtab_open_impl): Allocate gdb_symtab with new.
171 (jit_symtab_line_mapping_add_impl): Adjust.
172 (finalize_symtab): Adjust, call delete on stab.
173
d043f8c8
SM
1742019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
175
176 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
177
d9fa87f4
TT
1782019-12-16 Tom Tromey <tromey@adacore.com>
179
180 * windows-nat.c (windows_nat_target::attach): Update.
181 * remote.c (extended_remote_target::attach): Update.
182 * procfs.c (procfs_target::attach): Update.
183 * nto-procfs.c (nto_procfs_target::attach): Update.
184 (nto_procfs_target::create_inferior): Update.
185 * inf-ptrace.c (inf_ptrace_target::attach): Update.
186 * gnu-nat.c (gnu_nat_target::attach): Update.
187 (gnu_nat_target::detach): Update.
188 * darwin-nat.c (darwin_nat_target::attach): Update.
189 * corefile.c (get_exec_file): Constify result. Remove extraneous
190 return.
191 * bsd-kvm.c (bsd_kvm_target_open): Update.
192 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
193
c0c3707f
CB
1942019-12-16 Christian Biesinger <cbiesinger@google.com>
195
196 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
197 (we no longer need to include time.h before pathmax.h)
198
d3ecddab
CB
1992019-12-15 Christian Biesinger <cbiesinger@google.com>
200
201 * ada-exp.y (write_ambiguous_var): Update.
202 * coffread.c (process_coff_symbol): Update.
203 * ctfread.c (ctf_add_enum_member_cb): Update.
204 (new_symbol): Update.
205 * dwarf2read.c (fixup_go_packaging): Update.
206 (new_symbol): Update.
207 * language.c (language_alloc_type_symbol): Update.
208 * mdebugread.c (new_symbol): Update.
209 * minsyms.c (minimal_symbol_reader::record_full): Update.
210 * psymtab.c (add_psymbol_to_bcache): Update.
211 * stabsread.c (define_symbol): Update.
212 (read_enum_type): Update.
213 * symtab.c (symbol_set_language): Make this a member function...
214 (general_symbol_info::set_language): ... here.
215 * symtab.h (struct general_symbol_info) <set_language>: New function.
216 (SYMBOL_SET_LANGUAGE): Remove.
217 (symbol_set_language): Remove.
218
c1b5c1eb
CB
2192019-12-15 Christian Biesinger <cbiesinger@google.com>
220
221 * ada-lang.c (ada_add_block_symbols): Update.
222 (ada_collect_symbol_completion_matches): Update.
223 * ax-gdb.c (gen_expr): Update.
224 * block.c (block_lookup_symbol): Update.
225 (block_lookup_symbol_primary): Update.
226 (block_find_symbol): Update.
227 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
228 * dbxread.c (process_one_symbol): Update.
229 * dictionary.c (insert_symbol_hashed): Update.
230 (collate_pending_symbols_by_language): Update.
231 (mdict_add_symbol): Update.
232 * dwarf-index-write.c (write_psymbols): Update.
233 * dwarf2read.c (fixup_go_packaging): Update.
234 * findvar.c (read_var_value): Update.
235 * ft32-tdep.c (ft32_skip_prologue): Update.
236 * go-lang.c (go_symbol_package_name): Update.
237 * language.h (scoped_switch_to_sym_language_if_auto::
238 scoped_switch_to_sym_language_if_auto): Update.
239 * linespec.c (find_method): Update.
240 (find_label_symbols_in_block): Update.
241 * mdebugread.c (parse_symbol): Update.
242 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
243 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
244 (minimal_symbol_reader::install): Update.
245 * moxie-tdep.c (moxie_skip_prologue): Update.
246 * parse.c (parse_exp_in_context): Update.
247 * psymtab.c (psymbol_name_matches): Update.
248 (match_partial_symbol): Update.
249 (lookup_partial_symbol): Update.
250 (psymbol_hash): Update.
251 (psymbol_compare): Update.
252 * python/py-framefilter.c (extract_sym): Update.
253 (py_print_single_arg): Update.
254 * stabsread.c (define_symbol): Update.
255 * stack.c (print_frame_arg): Update.
256 (find_frame_funname): Update.
257 (info_frame_command_core): Update.
258 * symfile.c (set_initial_language): Update.
259 * symtab.c (symbol_set_demangled_name): Update.
260 (symbol_get_demangled_name): Update.
261 (symbol_set_language): Update.
262 (symbol_find_demangled_name): Update.
263 (symbol_set_names): Update.
264 (general_symbol_info::natural_name): Update.
265 (general_symbol_info::demangled_name): Update.
266 (general_symbol_info::search_name): Update.
267 (symbol_matches_search_name): Update.
268 (eq_symbol_entry): Update.
269 (iterate_over_symbols): Update.
270 (completion_list_add_symbol): Update.
271 (completion_list_add_msymbol): Update.
272 (completion_list_add_fields): Update.
273 * symtab.h (struct general_symbol_info) <language>: New function.
274 <language>: Rename to...
275 <m_language>: ...this.
276 (SYMBOL_LANGUAGE): Remove.
277 (MSYMBOL_LANGUAGE): Remove.
278 (struct symbol) <ctor>: Update.
279 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
280
747cfc8c
CB
2812019-12-15 Christian Biesinger <cbiesinger@google.com>
282
283 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
284 set the language of sym.
285 * language.c (language_alloc_type_symbol): Likewise.
286
ff8577f6
SDJ
2872019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
288
289 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
290 PR gdb/23613
291 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
292 * corelow.c: Include 'gdbsupport/pathstuff.h'.
293 (core_target_open): Use 'gdb_abspath'.
294 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
295 'current_directory == NULL' case.
296 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
297 explain what happens when 'current_directory' is NULL.
298 * go32-nat.c (go32_nat_target::wait): Check if
299 'current_directory' is NULL before call to 'chdir'.
300 * source.c (add_path): Use 'gdb_abspath'.
301 * top.c: Include 'gdbsupport/pathstuff.h'.
302 (init_history): Use 'gdb_abspath'.
303 (set_history_filename): Likewise.
304 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
305 (tfile_target_open): Use 'gdb_abspath'.
306
234c3068
TT
3072019-12-13 Tom Tromey <tromey@adacore.com>
308
309 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
310 warning or error.
311
93537683
TT
3122019-12-13 Tom Tromey <tromey@adacore.com>
313
314 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
315
63456183
TT
3162019-12-13 Tom Tromey <tromey@adacore.com>
317
318 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
319
98f9338a
TT
3202019-12-13 Tom Tromey <tromey@adacore.com>
321
322 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
323
3cb5a3a1
TT
3242019-12-13 Tom Tromey <tromey@adacore.com>
325
326 * gdbsupport/common-utils.c (string_printf, string_vprintf)
327 (string_vappendf): Add ARI comment.
328
c6cbf900
TT
3292019-12-13 Tom Tromey <tromey@adacore.com>
330
331 * contrib/ari/gdb_ari.sh: Remove "fix" call for
332 floatformat_to_double.
333 * target-float.c (host_float_ops<T>::from_target): Add ARI
334 comment.
335
036003a6
TT
3362019-12-13 Tom Tromey <tromey@adacore.com>
337
338 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
339 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
340 ARI marker to abort.
341 * event-top.c (handle_sigsegv): Add ARI marker to abort.
342
8aaaf757
TT
3432019-12-13 Tom Tromey <tromey@adacore.com>
344
345 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
346
fe56157f
TT
3472019-12-13 Tom Tromey <tromey@adacore.com>
348
349 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
350
a15a95ed
TT
3512019-12-13 Tom Tromey <tromey@adacore.com>
352
353 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
354 checks.
355
a5513db2
TT
3562019-12-13 Tom Tromey <tromey@adacore.com>
357
358 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
359 end>: No longer "const".
360
3a90f266
SM
3612019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
362
363 * jit.c: Fix indentation, replace spaces with tabs where
364 applicable.
365
b3f4b80f
JL
3662019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
367
368 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
369
e671856c
TT
3702019-12-12 Tom Tromey <tom@tromey.com>
371
372 * objfiles.h (struct objfile) <partial_symtabs>: Now a
373 unique_ptr.
374
7d7167ce
TT
3752019-12-12 Tom Tromey <tom@tromey.com>
376
377 * progspace.h (objfile_list): New typedef.
378 (class unwrapping_objfile_iterator)
379 (struct unwrapping_objfile_range): Newl
380 (struct program_space) <objfiles_range>: Change type.
381 <objfiles>: Change return type.
382 <add_objfile>: Change type of "objfile" parameter.
383 <objfiles_list>: Now a list of shared_ptr.
384 * progspace.c (program_space::add_objfile): Change type of
385 "objfile". Update.
386 (program_space::remove_objfile): Update.
387 * objfiles.h (struct objfile) <~objfile>: Make public.
388 * objfiles.c (objfile::make): Update.
389 (objfile::unlink): Don't call delete.
390
343cc952
TT
3912019-12-12 Tom Tromey <tom@tromey.com>
392
393 * symfile.c (symbol_file_clear): Update.
394 * progspace.h (struct program_space) <free_all_objfiles>: Declare
395 method.
396 * progspace.c (program_space::free_all_objfiles): New method.
397 * objfiles.h (free_all_objfiles): Don't declare.
398 * objfiles.c (free_all_objfiles): Move to program_space.
399
d0801dd8
TT
4002019-12-12 Tom Tromey <tom@tromey.com>
401
402 * progspace.c (program_space::add_objfile)
403 (program_space::remove_objfile): Update.
404 (program_space::multi_objfile_p): Remove.
405 * objfiles.h (struct objfile) <next>: Remove.
406 * objfiles.c (objfile::objfile): Update.
407 (put_objfile_before): Update.
408 (unlink_objfile): Update.
409 * progspace.h (object_files): Remove.
410 (struct program_space) <objfiles_head>: Remove.
411 <objfiles_list>: New member.
412 <objfiles_range, objfiles_safe_range>: Change type.
413 (objfiles): Change return type.
414 (objfiles_safe): Update.
415 (multi_objfile_p): Rewrite and inline.
416 (object_files): Remove macro.
417
13bff726
TT
4182019-12-12 Tom Tromey <tom@tromey.com>
419
420 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
421 second constructor.
422 (basic_safe_range): New class.
423
deeafabb
TT
4242019-12-12 Tom Tromey <tom@tromey.com>
425
426 * progspace.c (program_space::multi_objfile_p): New method.
427 * printcmd.c (info_symbol_command): Update.
428 * maint.c (maintenance_translate_address): Update.
429 * objfiles.h (MULTI_OBJFILE_P): Remove.
430 * progspace.h (struct program_space) <multi_objfile_p>: New
431 method.
432
23452926
TT
4332019-12-12 Tom Tromey <tom@tromey.com>
434
435 * progspace.h (struct program_space) <remove_objfile>: Declare.
436 * progspace.c (program_space::remove_objfile): New method.
437 * objfiles.c (unlink_objfile): Remove.
438 (objfile::unlink): Call remove_objfile.
439 (objfile): Don't call unlink_objfile.
440
7cac64af
TT
4412019-12-12 Tom Tromey <tom@tromey.com>
442
443 * progspace.h (struct program_space) <add_objfile>: Declare
444 method.
445 * progspace.c (program_space::add_objfile): New method.
446 * objfiles.c (~objfile): Don't unlink objfile.
447 (put_objfile_before): Remove.
448 (add_separate_debug_objfile): Don't call put_objfile_before.
449 (objfile::make): Call add_objfile. Set new_objfiles_available on
450 the per-program-space data.
451
268e4f09
TT
4522019-12-12 Tom Tromey <tom@tromey.com>
453
454 * symfile.c (syms_from_objfile_1): Use objfile_up.
455 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
456 method.
457 (reread_symbols): Use objfile_up.
458 * solib.c (update_solib_list, reload_shared_libraries_1): Call
459 unlink method.
460 * objfiles.h (struct objfile) <~objfile>: Now private.
461 <unlink>: New method.
462 (struct objfile_deleter): New.
463 (objfile_up): New typedef.
464 * objfiles.c (objfile::unlink): New method.
465 (free_objfile_separate_debug, free_all_objfiles)
466 (objfile_purge_solibs): Use it.
467 * jit.c (jit_unregister_code): Remove.
468 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
469 objfile.
470 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
471 objfile.
472 * compile/compile-object-load.c (compile_object_load): Use
473 objfile_up.
474
f65fe570
TT
4752019-12-12 Tom Tromey <tom@tromey.com>
476
477 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
478 objfile::make.
479 * objfiles.h (struct objjfile) <make>: No longer inline.
480 (add_separate_debug_objfile): Don't declare.
481 * objfiles.c (add_separate_debug_objfile): Now static.
482 (objfile::make): Move from objfiles.h. Call
483 add_separate_debug_objfile. Add "parent" parameter.
484
bda13cdc
TT
4852019-12-12 Tom Tromey <tom@tromey.com>
486
487 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
488 * objfiles.h (struct objfile): Make constructor private.
489 <make>: New static method.
490 * jit.c (jit_object_close_impl): Update.
491
7190276c
SM
4922019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
493
494 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
495 gdb::byte_vector.
496
d61df897
TT
4972019-12-12 Tom Tromey <tromey@adacore.com>
498
499 * xml-support.c (xml_fetch_content_from_file): Don't call
500 malloc_failure.
501 * utils.h (class gdb_argv): Remove malloc_failure comment.
502 * utils.c (gdb_argv::reset): Don't call malloc_failure.
503
db3ad2f0
TT
5042019-12-12 Tom Tromey <tromey@adacore.com>
505
506 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
507 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
508 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
509 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
510 * riscv-ravenscar-thread.c: New file.
511 * riscv-ravenscar-thread.h: New file.
512 * riscv-tdep.c (riscv_gdbarch_init): Call
513 register_riscv_ravenscar_ops.
514
2ffe5b9c
TT
5152019-12-12 Tom Tromey <tromey@adacore.com>
516
517 * gdbsupport/thread-pool.c (set_thread_name): Use
518 ATTRIBUTE_UNUSED.
519
39f34d7b
LM
5202019-12-12 Luis Machado <luis.machado@linaro.org>
521
522 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
523 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
524 macros.
525
d4eeccfe
TT
5262019-12-11 Tom Tromey <tom@tromey.com>
527
528 * tui/tui-win.c (tui_set_win_height_command): Call
529 tui_adjust_window_height.
530 (tui_adjust_win_heights, new_height_ok): Remove.
531 * tui/tui-layout.h (tui_adjust_window_height): Declare.
532 * tui/tui-layout.c (tui_adjust_window_height): New function.
533
3d979945
TT
5342019-12-11 Tom Tromey <tom@tromey.com>
535
536 * tui/tui-win.c (tui_resize_all): Remove code, call
537 tui_apply_current_layout.
538
2192a9d3
TT
5392019-12-11 Tom Tromey <tom@tromey.com>
540
541 * tui/tui-layout.h (tui_apply_current_layout): Declare.
542 * tui/tui-layout.c (standard_layouts, applied_layout): New
543 globals.
544 (tui_apply_current_layout): New function.
545 (show_layout): Set applied_layout. Call
546 tui_apply_current_layout.
547 (show_source_command, show_disasm_command)
548 (show_source_disasm_command, show_data)
549 (show_source_or_disasm_and_command): Remove.
550 (initialize_layouts): New function.
551 (_initialize_tui_layout): Call initialize_layouts.
552
389e7ddb
TT
5532019-12-11 Tom Tromey <tom@tromey.com>
554
555 * tui/tui-layout.h (class tui_layout_base)
556 (class tui_layout_window, class tui_layout_split): New.
557 * tui/tui-layout.c (tui_get_window_by_name)
558 (tui_layout_window::clone, tui_layout_window::apply)
559 (tui_layout_window::get_sizes, tui_layout_window::add_split)
560 (tui_layout_split::add_window, tui_layout_split::clone)
561 (tui_layout_split::get_sizes)
562 (tui_layout_split::set_weights_from_heights)
563 (tui_layout_split::adjust_size, tui_layout_split::apply): New
564 functions.
565 (tui_layout_split::add_split, tui_layout_split::add_split)
566 (tui_layout_split::set_weights_from_heights)
567 (tui_layout_split::set_weights_from_heights): New functions.
568
fb3184d8
TT
5692019-12-11 Tom Tromey <tom@tromey.com>
570
571 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
572 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
573 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
574 * tui/tui-data.h (struct tui_point): Remove.
575 (struct tui_gen_win_info) <origin>: Remove.
576 <x, y>: New fields.
577 * tui/tui-command.c (tui_cmd_window::resize): Update.
578
dc7ff8a6
TT
5792019-12-11 Tom Tromey <tom@tromey.com>
580
581 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
582 Implement.
583 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
584 Implement.
585 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
586 method.
587 (struct tui_win_info) <min_height>: Implement.
588
1431937b
TT
5892019-12-11 Tom Tromey <tom@tromey.com>
590
591 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
592 (struct tui_win_info) <can_box>: Update.
593
c8ec2f43
TT
5942019-12-11 Tom Tromey <tom@tromey.com>
595
596 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
597 method.
598 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
599 method.
600 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
601 method.
602 (struct tui_win_info) <max_height>: Now override.
603
4decd62b
JB
6042019-12-11 Joel Brobecker <brobecker@adacore.com>
605
606 * NEWS: Create a new section for the next release branch.
607 Rename the section of the current branch, now that it has
608 been cut.
609
d746744e
JB
6102019-12-11 Joel Brobecker <brobecker@adacore.com>
611
612 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
613 * version.in: Bump version to 10.0.50.DATE-git.
614
2e744276
TT
6152019-12-11 Tom Tromey <tromey@adacore.com>
616
617 PR build/25268:
618 * gdbsupport/thread-pool.c (set_thread_name): New function.
619 (thread_pool::set_thread_count): Don't call pthread_setname_np.
620 (thread_pool::thread_function): Call set_thread_name.
621
aac4760f
TT
6222019-12-11 Tom Tromey <tromey@adacore.com>
623
624 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
625 bfd_get_signed_8.
626
d8edc8b7
PW
6272019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
628
629 * NEWS: Document -raw-values option and the related setting commands.
630 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
631 only set it on when /r is given.
632 * valprint.c (value_print_option_defs): New element raw-values.
633 * Makefile.in: Add the new file.
634
cb511130
CB
6352019-12-10 Christian Biesinger <cbiesinger@google.com>
636
637 * gdbsupport/safe-strerror.c: Supress the unused function warning
638 for select_strerror_r.
639
ab7d13f0
CB
6402019-12-10 Christian Biesinger <cbiesinger@google.com>
641
642 * config.in: Regenerate.
643 * configure: Regenerate.
644 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
645 safe_strerror instead of strerror.
646 * gdbsupport/common.m4: Don't check for strerror.
647 * gdbsupport/safe-strerror.c: Support both the glibc version
648 of strerror_r and the XSI version.
649
6c71eb7d
TT
6502019-12-10 Tom Tromey <tromey@adacore.com>
651
652 * ada-typeprint.c (print_choices): Use a single "?".
653 (print_variant_part): Print "?" if the discriminant name
654 is not known.
655
bac7c5cf
GB
6562019-12-10 George Barrett <bob@bob131.so>
657
658 Fix scripted probe breakpoints.
659 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
660 declaration forward.
661 (breakpoint_ops_for_event_location_type)
662 (breakpoint_ops_for_event_location): Add function definitions.
663 (break_command_1, trace_command): Use
664 breakpoint_ops_for_event_location.
665 * breakpoint.h (breakpoint_ops_for_event_location): Add function
666 declarations.
667 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
668 breakpoint_ops_for_event_location.
669 * python/py-breakpoint.c (bppy_init): Use
670 breakpoint_ops_for_event_location.
671
330f1d38
TBA
6722019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
673
674 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
675 when ranking an lvalue argument for an rvalue parameter.
676
b1f0c0b9
WA
6772019-12-08 Wataru Ashihara <wataash@wataash.com>
678
679 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
680 template argument for scoped_restore_tmpl from bool to int.
681
aa2d5a42
KS
6822019-12-07 Keith Seitz <keiths@redhat.com>
683
684 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
685 (build_id_to_debug_bfd): Make static, rewriting to use
686 build_id_to_bfd_suffix.
687 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
688 adding `suffix' parameter. Append SUFFIX to file names
689 when searching for matching files.
690 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
691 (build_id_to_exec_bfd): Likewise.
692 * build-id.h (build_id_to_debug_bfd): Clarify that function
693 searches for BFD of debug info file.
694 (build_id_to_exec_bfd): Declare.
695 * corelow.c: Include build-id.h.
696 (locate_exec_from_corefile_build_id): New function.
697 (core_target_open): If no executable BFD is found,
698 search for a core file BFD using build-id.
699
dfb65191
CB
7002019-12-06 Christian Biesinger <cbiesinger@google.com>
701
702 * bcache.c: Put in namespace gdb.
703 * bcache.h: Likewise.
704 * gdbtypes.c (check_types_worklist): Update.
705 (types_deeply_equal): Update.
706 * macrotab.c (struct macro_table) <bcache>: Update.
707 (new_macro_table): Update.
708 * macrotab.h (struct bcache): Put this forward declaration
709 inside namespace gdb.
710 (new_macro_table): Update.
711 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
712 Update.
713 <macro_cache>: Update.
714 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
715
93e55f0a
TV
7162019-12-06 Tom de Vries <tdevries@suse.de>
717
718 PR symtab/24971
719 * block.c (best_symbol, better_symbol): New function.
720 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
721 decl.
722
06acc08f
TBA
7232019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
724
725 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
726 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
727 for ranking see-through reference cases.
728
e0fad1ea
PW
7292019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
730 * stack.c (faas_command): Check a command is provided.
731 * thread.c (taas_command, tfaas_command): Likewise.
732
908641f5
PW
7332019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
734 * inferior.c (prune_inferiors): Only call delete_inferior,
735 Do not modify the inferior list.
736
b858499d
SM
7372019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
738
739 * c-exp.y: Update calls to lookup_typename,
740 lookup_signed_typename and lookup_unsigned_typename.
741 * c-lang.c (evaluate_subexp_c): Likewise.
742 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
743 Likewise.
744 * eval.c (binop_promote): Likewise.
745 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
746 (lookup_unsigned_typename): Likewise.
747 (lookup_signed_typename): Likewise.
748 * gdbtypes.h (lookup_unsigned_typename): Likewise.
749 (lookup_signed_typename): Likewise.
750 (lookup_typename): Likewise.
751 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
752 lookup_typename, lookup_signed_typename,
753 lookup_unsigned_typename.
754 * m2-exp.y: Likewise.
755 * printcmd.c (printf_wide_c_string): Likewise.
756 (ui_printf): Likewise.
757 * python/py-type.c (typy_lookup_typename): Likewise.
758 * python/py-xmethods.c (python_xmethod_worker::invoke):
759 Likewise.
760 * rust-exp.y: Likewise.
761
3a8fa228
CB
7622019-12-04 Christian Biesinger <cbiesinger@google.com>
763
764 * configure.nat (obsd64): Add missing files x86-nat.o and
765 nat/x86-dregs.o.
766
2dbc041e
TT
7672019-12-04 Tom Tromey <tom@tromey.com>
768
769 * valprint.c (val_print_string): Use metadata_style.
770 * go-valprint.c (print_go_string): Use metadata style.
771 * p-valprint.c (pascal_object_print_static_field): Use metadata
772 style.
773 * cp-valprint.c (cp_print_static_field): Use metadata style.
774
36c8fb93
AB
7752019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
776 Chris January <chris.january@arm.com>
777
778 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
779 tokens.
780 (typebase): New patterns for complex, single/double precision, and
781 single/double complex.
782 (f77_keywords): Change token for complex keyword, and add single,
783 double, and precision keywords.
784
c6170c2c
SM
7852019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
786
787 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
788 "info io_registers".
789
894ecaf4
SM
7902019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
791
792 * regcache.c (cooked_read_test): Initialize thread list of
793 mock_inferior.
794
be155ebb
SM
7952019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
796
797 * aarch64-linux-tdep.c: Remove includes.
798
c577cdd7
SM
7992019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
800
801 * aarch64-tdep.c: Remove includes.
802
610cfd61
SM
8032019-12-04 Simon Marchi <simon.marchi@efficios.com>
804
805 * filtered-iterator.h (filtered_iterator) <operator==,
806 operator!=>: Compare wrapped iterators, not wrapped pointers.
807 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
808 unittests/filtered_iterator-selftests.c.
809 * unittests/filtered_iterator-selftests.c: New file.
810
a05cf17a
TT
8112019-12-04 Tom Tromey <tromey@adacore.com>
812
813 * gdbtypes.c (create_range_type): Inherit endianity
814 from base type.
815
d5a22e77
TT
8162019-12-04 Tom Tromey <tromey@adacore.com>
817
818 * ada-lang.c (decode_constrained_packed_array)
819 (ada_value_assign, value_assign_to_component): Update.
820 * dwarf2loc.c (rw_pieced_value, access_memory)
821 (dwarf2_compile_expr_to_ax): Update.
822 * dwarf2read.c (dwarf2_add_field): Update.
823 * eval.c (evaluate_subexp_standard): Update.
824 * gdbarch.c, gdbarch.h: Rebuild.
825 * gdbarch.sh (bits_big_endian): Remove.
826 * gdbtypes.h (union field_location): Update comment.
827 * target-descriptions.c (make_gdb_type): Update.
828 * valarith.c (value_bit_index): Update.
829 * value.c (struct value) <bitpos>: Update comment.
830 (unpack_bits_as_long, modify_field): Update.
831 * value.h (value_bitpos): Update comment.
832
7ab4a236
TT
8332019-12-04 Tom Tromey <tromey@adacore.com>
834
835 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
836 endian-ness.
837
103a685e
TT
8382019-12-04 Tom Tromey <tromey@adacore.com>
839
840 * dwarf2read.c (dwarf2_init_float_type)
841 (dwarf2_init_complex_target_type): Add byte_order parameter.
842 (read_base_type): Compute byte order earlier.
843 * gdbtypes.c (init_float_type): Add byte_order parameter.
844 * gdbtypes.h (init_float_type): Add byte_order parameter.
845
7a9e9f9f
TT
8462019-12-04 Tom Tromey <tromey@adacore.com>
847
848 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
849
feee869b
TT
8502019-12-04 Tom Tromey <tromey@adacore.com>
851
852 * dwarf2read.c (process_structure_scope): Initialize
853 "discr_offset".
854
c2512106
AB
8552019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
856
857 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
858 add it into the search spec.
859 (parse_max_results_option): New function.
860 (mi_info_functions_or_variables): Parse -max-results flag and pass
861 it to mi_symbol_info.
862 (mi_cmd_symbol_info_modules): Likewise.
863 (mi_cmd_symbol_info_types): Likewise.
864 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
865 return type to bool, change result container into a set, and don't
866 add new results if we have enough already.
867 (global_symbol_searcher::add_matching_msymbols): Change return
868 type to bool, and don't add new results if we have enough already.
869 (sort_search_symbols_remove_dups): Delete.
870 (global_symbol_searcher::search): Early exit from search loop when
871 we have enough results. Use a std::set to collect the results
872 from calling add_matching_symbols.
873 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
874 member function.
875 (global_symbol_searcher) <m_max_search_results>: New member
876 variable.
877 (global_symbol_searcher) <add_matching_symbols>: Update header
878 comment and change return type to bool.
879 (global_symbol_searcher) <add_matching_msymbols>: Update header
880 comment and change return type to bool.
881
f97a63c5
AB
8822019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
883
884 * symtab.c (symbol_search::compare_search_syms): Update header
885 comment.
886 (global_symbol_searcher::is_suitable_msymbol): New function.
887 (global_symbol_searcher::expand_symtabs): New function.
888 (global_symbol_searcher::add_matching_symbols): New function.
889 (global_symbol_searcher::add_matching_msymbols): New function.
890 (global_symbol_searcher::search): Move most of the content
891 into the new functions above, and call them as needed.
892 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
893 function.
894 (global_symbol_searcher) <add_matching_symbols>: New member
895 function.
896 (global_symbol_searcher) <add_matching_msymbols>: New member
897 function.
898 (global_symbol_searcher) <is_suitable_msymbol>: New member
899 function.
900
293b38d6
AB
9012019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
902
903 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
904 -symbol-info-module-variables entries.
905 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
906 (mi_cmd_symbol_info_module_variables): Declare.
907 * mi/mi-symbol-cmds.c
908 (module_symbol_search_iterator): New typedef.
909 (output_module_symbols_in_single_module_and_file): New function.
910 (output_module_symbols_in_single_module): New function.
911 (mi_info_module_functions_or_variables): New function.
912 (mi_cmd_symbol_info_module_functions): New function.
913 (mi_cmd_symbol_info_module_variables): New function.
914 * NEWS: Mention new MI command.
915
4cbd39b2
CB
9162019-12-03 Christian Biesinger <cbiesinger@google.com>
917
918 * bcache.c (hash): Remove.
919 (hash_continue): Remove.
920 * bcache.h (hash): Remove.
921 (hash_continue): Remove.
922 (struct bcache) <ctor>: Update.
923 * psymtab.c (psymbol_hash): Update.
924 * stabsread.c (hashname): Update.
925 * utils.h (fast_hash): Add an argument for a start value,
926 defaulting to zero.
927
82f910ea
PW
9282019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
929 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
930 (destroy_block_symbol_cache): New function.
931 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
932 (resize_symbol_cache): Likewise.
933
de2396d0
TT
9342019-12-02 Tom Tromey <tom@tromey.com>
935
936 * unittests/tui-selftests.c (run_tests): Make conditional.
937 (_initialize_tui_selftest): Make conditional.
938
638d85bc
CB
9392019-12-02 Christian Biesinger <cbiesinger@google.com>
940
941 * aix-thread.c (debug_aix_thread): Change type to bool.
942
7532a164
LM
9432019-12-02 Luis Machado <luis.machado@linaro.org>
944
945 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
946
216a7e6b
AB
9472019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
948
949 * dwarf2read.c (read_tag_string_type): Read the fields required to
950 make a dynamic string, and possibly create a dynamic range for the
951 string.
952 (attr_to_dynamic_prop): Setup is_reference based on the type of
953 attribute being processed.
954 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
955 (resolve_dynamic_array): Rename to...
956 (resolve_dynamic_array_or_string): ...this, update header comment,
957 and accept TYPE_CODE_STRING.
958 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
959
11a8b164
AB
9602019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
961
962 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
963 of its implementation from...
964 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
965 the new function.
966
5bbd8269
AB
9672019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
968
969 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
970 create a range with stride where appropriate.
971 * f-valprint.c: Include 'gdbarch.h'.
972 (f77_print_array_1): Take the stride into account when walking the
973 array. Also convert the stride into addressable units.
974 * gdbtypes.c (create_range_type): Initialise the stride to
975 constant zero.
976 (create_range_type_with_stride): New function, initialise the
977 range as normal, and then setup the stride.
978 (has_static_range): Include the stride here. Also change the
979 return type to bool.
980 (create_array_type_with_stride): Consider the range stride if the
981 array isn't given its own stride.
982 (resolve_dynamic_range): Resolve the stride if needed.
983 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
984 (struct range_bounds) <flag_is_byte_stride>: New member variable.
985 (TYPE_BIT_STRIDE): Define.
986 (TYPE_ARRAY_BIT_STRIDE): Define.
987 (create_range_type_with_stride): Declare.
988 * valarith.c (value_subscripted_rvalue): Take range stride into
989 account when walking the array.
990
82e3b564
TT
9912019-12-01 Tom Tromey <tom@tromey.com>
992
993 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
994 specially.
995
517d261d
TT
9962019-12-01 Tom Tromey <tom@tromey.com>
997
998 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
999 \0.
1000 * unittests/tui-selftests.c: New file.
1001 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1002
484c9b64
TT
10032019-12-01 Tom Tromey <tom@tromey.com>
1004
1005 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1006
a2a7af0c
TT
10072019-12-01 Tom Tromey <tom@tromey.com>
1008
1009 * NEWS: Document new settings.
1010 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1011 * tui/tui-win.c (_initialize_tui_win): Add border style
1012 observers.
1013 * tui/tui-io.h (tui_apply_style): Declare.
1014 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1015 longer static.
1016 (apply_ansi_escape, tui_set_reverse_mode): Update.
1017 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1018 Add "skip_intensity" parameter.
1019 <changed>: New member.
1020 <do_set_value>: Declare.
1021 (tui_border_style, tui_active_border_style): Declare.
1022 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1023 globals.
1024 (cli_style_option): Initialize "changed".
1025 (cli_style_option::do_set_value): New function.
1026 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1027 parameter. Update.
1028 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1029 (_initialize_cli_style): Update. Create TUI border style
1030 commands.
1031
d1da6b01
TT
10322019-12-01 Tom Tromey <tom@tromey.com>
1033
1034 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1035 parameter.
1036 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1037 parameter.
1038 * tui/tui-win.h (compact_source): Declare.
1039 * tui/tui-win.c (compact_source): New global.
1040 (tui_set_compact_source, tui_show_compact_source): New functions.
1041 (_initialize_tui_win): Add "compact-source" setting.
1042 * tui/tui-source.c (tui_source_window::set_contents): Handle
1043 compact_source setting.
1044 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1045 * NEWS: Document new setting.
1046
489dbda6
TT
10472019-11-30 Tom Tromey <tom@tromey.com>
1048
1049 * dwarf2read.c (dwarf2_add_field): Include field offset when
1050 computing variant part length.
1051
bf498525
PW
10522019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1053 * NEWS: Mention define-prefix. Tell that command names can now
1054 contain a . character.
1055
be09caf1
PW
10562019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1057
1058 * command.h (valid_cmd_char_p): Declare.
1059 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1060 the check of valid command char.
1061 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1062 valid_cmd_char_p.
1063 * cli/cli-script.c (validate_comname): Likewise.
1064 * completer.c (gdb_completer_command_word_break_characters):
1065 Do not remove . from the word break char, update comments.
1066 (complete_line_internal_1): Use valid_cmd_char_p.
1067 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1068 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1069
c6ac7fc9
PW
10702019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1071
1072 * cli/cli-script.c (do_define_command): Ensure a redefined
1073 prefix command is kept as a prefix command.
1074 (define_prefix_command): New function.
1075 (show_user_1): Report user defined prefixes.
1076 (_initialize_cli_script): Create the new 'define-prefix' command.
1077 Add completers for 'define' and 'document'.
1078 * top.c (execute_command): If command is a user-defined prefix only
1079 command, report the list of commands for this prefix command.
1080
a992a3b0
TBA
10812019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1082
1083 * valops.c (find_oload_champ): Improve debug output.
1084
e9194a1a
TBA
10852019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1086
1087 * valops.c (find_oload_champ): Print part of debug messages
1088 before the badness vector is std::move'd.
1089
53a008a6
TT
10902019-11-28 Tom Tromey <tom@tromey.com>
1091
1092 * value.c (creal_internal_fn): Fix comment.
1093
bab05c83
TT
10942019-11-28 Tom Tromey <tom@tromey.com>
1095
1096 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1097 flag_bound_evaluated>: Now unsigned.
1098
2522f049
TT
10992019-11-28 Tom Tromey <tom@tromey.com>
1100
1101 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1102 declare.
1103
38b49e22
MS
11042019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1105
1106 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1107 debug output.
1108 * jit.c (jit_unregister_code): Add debug print to match
1109 `jit_register_code`.
1110
35125921
CB
11112019-11-27 Christian Biesinger <cbiesinger@google.com>
1112
1113 * NEWS: Mention the new multithreaded symbol loading.
1114
62e77f56
CB
11152019-11-27 Christian Biesinger <cbiesinger@google.com>
1116
1117 * maint.c (n_worker_threads): Default to 0.
1118 (worker_threads_disabled): New function.
1119 * maint.h (worker_threads_disabled): New function.
1120 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1121 here if worker_threads_disabled () is true.
1122 (minimal_symbol_reader::install): Skip all threading if
1123 worker_threads_disabled () is true.
1124
f29d7f6b
CB
11252019-11-27 Christian Biesinger <cbiesinger@google.com>
1126
1127 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1128 hash code if possible.
1129 (add_minsym_to_demangled_hash_table): Likewise.
1130 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1131 on the background thread.
1132 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1133 Add these fields.
1134
e76b2246
CB
11352019-11-27 Christian Biesinger <cbiesinger@google.com>
1136
1137 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1138 of the mangled name on the background thread.
1139 * symtab.c (symbol_set_names): Allow passing in the hash of the
1140 linkage_name.
1141 * symtab.h (symbol_set_names): Likewise.
1142
8d9a2568
KB
11432019-11-27 Kevin Buettner <kevinb@redhat.com>
1144
1145 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1146 physnames are computed for inherited DIEs.
1147
fad03f6e
TT
11482019-11-27 Tom Tromey <tromey@adacore.com>
1149
1150 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1151 backslashes.
1152 * cp-support.c: Remove unnecessary backslashes.
1153
43678b0a
CB
11542019-11-27 Christian Biesinger <cbiesinger@google.com>
1155
1156 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1157 with sym->set_linkage_name.
1158 * coffread.c (coff_read_enum_type): Likewise.
1159 * mdebugread.c (parse_symbol): Likewise.
1160 * stabsread.c (patch_block_stabs): Likewise.
1161 (define_symbol): Likewise.
1162 (read_enum_type): Likewise.
1163 (common_block_end): Likewise.
1164 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1165 function.
1166 (SYMBOL_SET_LINKAGE_NAME): Remove.
1167 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1168 with sym->set_linkage_name.
1169
db5960b4
AB
11702019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1171
1172 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1173 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1174 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1175 * NEWS: Mention new MI command.
1176
7dc42066
AB
11772019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1178
1179 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1180 '-symbol-info-types', and '-symbol-info-variables'.
1181 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1182 (mi_cmd_symbol_info_types): Declare.
1183 (mi_cmd_symbol_info_variables): Declare.
1184 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1185 (output_debug_symbol): New function.
1186 (output_nondebug_symbol): New function.
1187 (mi_symbol_info): New function.
1188 (mi_info_functions_or_variables): New function.
1189 (mi_cmd_symbol_info_functions): New function.
1190 (mi_cmd_symbol_info_types): New function.
1191 (mi_cmd_symbol_info_variables): New function.
1192 * NEWS: Mention new commands.
1193
5f512a7d
AB
11942019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1195
1196 * symtab.c (symbol_to_info_string): New function, most content
1197 moved from print_symbol_info, but updated to return a std::string.
1198 (print_symbol_info): Update to use symbol_to_info_string and print
1199 returned string.
1200 * symtab.h (symbol_to_info_string): Declare new function.
1201
470c0b1c
AB
12022019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1203
1204 * python/python.c (gdbpy_rbreak): Convert to using
1205 global_symbol_searcher.
1206 * symtab.c (file_matches): Convert return type to bool, change
1207 file list to std::vector, update header comment.
1208 (search_symbols): Rename to...
1209 (global_symbol_searcher::search): ...this and update now its
1210 a member function of global_symbol_searcher. Take account of the
1211 changes to file_matches.
1212 (symtab_symbol_info): Convert to using global_symbol_searcher.
1213 (rbreak_command): Likewise.
1214 (search_module_symbols): Likewise.
1215 * symtab.h (enum symbol_search): Update comment.
1216 (search_symbols): Remove declaration.
1217 (class global_symbol_searcher): New class.
1218
57357d9d
TT
12192019-11-26 Tom Tromey <tromey@adacore.com>
1220
1221 * cp-support.c (_initialize_cp_support): Conditionally initialize
1222 gdb_demangle_attempt_core_dump.
1223
3ea16160
TT
12242019-11-26 Tom Tromey <tom@tromey.com>
1225
1226 * python/py-function.c (fnpy_init): Update.
1227 * value.h (add_internal_function): Adjust declaration.
1228 * value.c (function_destroyer): Remove.
1229 (do_add_internal_function): Don't set destroyer or copy name.
1230 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1231 Set name_allocated.
1232 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1233 (cmdpy_init): Set name_allocated.
1234 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1235 member.
1236 (~cmd_list_element): Free "name" if needed.
1237
1a6d41c6
TT
12382019-11-26 Tom Tromey <tom@tromey.com>
1239
1240 * value.h (add_internal_function): Add new overload. Move
1241 documentation from value.h.
1242 * value.c (do_add_internal_function): New function.
1243 (add_internal_function): Use it. Add new overload.
1244 (function_destroyer): Don't free doc.
1245 * python/py-function.c (fnpy_init): Update.
1246
8318f3c3
TT
12472019-11-26 Tom Tromey <tom@tromey.com>
1248
1249 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1250 (cmdpy_init): Set "doc_allocated".
1251
4da8c3a8
TT
12522019-11-26 Tom Tromey <tom@tromey.com>
1253
1254 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1255 name of worker thread.
1256 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1257 pthread_setname_np.
1258 * configure, config.in: Rebuild.
1259
971db5e2
TT
12602019-11-26 Tom Tromey <tom@tromey.com>
1261
1262 * python/python.c (class gdbpy_gil): New.
1263 (struct gdbpy_event): Add constructor, destructor, operator().
1264 (gdbpy_post_event): Use run_on_main_thread.
1265 (gdbpy_initialize_events): Remove.
1266 (do_start_initialization): Update.
1267
22138db6
TT
12682019-11-26 Tom Tromey <tom@tromey.com>
1269
1270 * NEWS: Add entry.
1271 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1272 commands. Call update_thread_pool_size.
1273 (update_thread_pool_size, maintenance_set_worker_threads): New
1274 functions.
1275 (n_worker_threads): New global.
1276
d55c9a68
TT
12772019-11-26 Christian Biesinger <cbiesinger@google.com>
1278 Tom Tromey <tom@tromey.com>
1279
1280 * minsyms.c (minimal_symbol_reader::install): Use
1281 parallel_for_each.
1282 * gdbsupport/parallel-for.h: New file.
1283 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1284
a0b57563
CB
12852019-11-26 Christian Biesinger <cbiesinger@google.com>
1286 Tom Tromey <tom@tromey.com>
1287
1288 * gdbsupport/thread-pool.h: New file.
1289 * gdbsupport/thread-pool.c: New file.
1290 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1291 (HFILES_NO_SRCDIR): Add thread-pool.h.
1292
3b3978bc
TT
12932019-11-26 Tom Tromey <tom@tromey.com>
1294
1295 * event-top.h (thread_local_segv_handler): Declare.
1296 * event-top.c (thread_local_segv_handler): New global.
1297 (install_handle_sigsegv, handle_sigsegv): New functions.
1298 (async_init_signals): Install SIGSEGV handler.
1299 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1300 thread-local.
1301 (report_failed_demangle): New function.
1302 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1303 handler-setting code, instead use segv_handler. Run warning code
1304 on main thread.
1305
9411c49e
TT
13062019-11-26 Tom Tromey <tom@tromey.com>
1307
1308 * run-on-main-thread.c: New file.
1309 * run-on-main-thread.h: New file.
1310 * unittests/main-thread-selftests.c: New file.
1311 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1312 main-thread-selftests.c.
1313 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1314 (COMMON_SFILES): Add run-on-main-thread.c.
1315
c3efb965
TT
13162019-11-26 Tom Tromey <tom@tromey.com>
1317
1318 * main.c (setup_alternate_signal_stack): Remove.
1319 (captured_main_1): Use gdb::alternate_signal_stack.
1320 * gdbsupport/alt-stack.h: New file.
1321
21987b9c
TT
13222019-11-26 Tom Tromey <tom@tromey.com>
1323
1324 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1325 Remove comment.
1326 (save_original_signals_state, restore_original_signals_state): Use
1327 gdb_sigmask.
1328 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1329 (_initialize_linux_nat): Use gdb_sigmask.
1330 * guile/guile.c (_initialize_guile): Use block_signals.
1331 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1332 * gdbsupport/gdb-sigmask.h: New file.
1333 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1334 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1335 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1336 pthread_sigmask.
1337 * configure, config.in: Rebuild.
1338 * gdbsupport/block-signals.h: New file.
1339
5e030278
TT
13402019-11-26 Tom Tromey <tom@tromey.com>
1341
1342 * acinclude.m4: Include ax_pthread.m4.
1343 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1344 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1345 (CLIBS): Use PTHREAD_LIBS.
1346 (aclocal_m4_deps): Add ax_pthread.m4.
1347 * config.in, configure: Rebuild.
1348 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1349
5a79c107
TT
13502019-11-26 Tom Tromey <tom@tromey.com>
1351
1352 * symtab.h (struct minimal_symbol) <name_set>: New member.
1353 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1354 Don't call symbol_set_names.
1355 (minimal_symbol_reader::install): Call symbol_set_names.
1356
aa369509
PW
13572019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1358
1359 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1360 restore_active_ext_lang, as GIL is needed for (indirectly)
1361 called PyOS_InterruptOccurred.
1362
cadc9cb8
SM
13632019-11-26 Simon Marchi <simon.marchi@efficios.com>
1364
1365 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1366 definition.
1367
d04afd58
SM
13682019-11-26 Simon Marchi <simon.marchi@efficios.com>
1369
1370 * remote-sim.c (simulator_command): Make static, remove
1371 declaration.
1372
dd694d77
SM
13732019-11-26 Simon Marchi <simon.marchi@efficios.com>
1374
1375 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1376 static.
1377 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1378 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1379 (main): Likewise.
1380 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1381 (main): Likewise.
1382 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1383 (main): Likewise.
1384 * unittests/basic_string_view/element_access/char/1.cc (test01):
1385 Likewise.
1386 (main): Likewise.
1387 * unittests/basic_string_view/element_access/char/empty.cc (main):
1388 Likewise.
1389 * unittests/basic_string_view/element_access/char/front_back.cc
1390 (test01): Likewise.
1391 (main): Likewise.
1392 * unittests/basic_string_view/inserters/char/2.cc (test05):
1393 Likewise.
1394 (main): Likewise.
1395 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1396 (test01): Likewise.
1397 (main): Likewise.
1398 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1399 (test01): Likewise.
1400 (main): Likewise.
1401 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1402 Likewise.
1403 * unittests/basic_string_view/operations/compare/char/1.cc
1404 (test01): Likewise.
1405 (main): Likewise.
1406 * unittests/basic_string_view/operations/compare/char/13650.cc
1407 (test01): Likewise.
1408 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1409 Likewise.
1410 (main): Likewise.
1411 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1412 Likewise.
1413 (main): Likewise.
1414 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1415 Likewise.
1416 (main): Likewise.
1417 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1418 Likewise.
1419 (main): Likewise.
1420 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1421 Likewise.
1422 (main): Likewise.
1423 * unittests/basic_string_view/operations/find/char/4.cc (main):
1424 Likewise.
1425 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1426 Likewise.
1427 (main): Likewise.
1428 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1429 Likewise.
1430 (main): Likewise.
1431 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1432 Likewise.
1433 (main): Likewise.
1434 * unittests/basic_string_view/operations/substr/char/1.cc
1435 (test01): Likewise.
1436 (main): Likewise.
1437 * unittests/basic_string_view/operators/char/2.cc (main):
1438 Likewise.
1439 * unittests/optional/assignment/1.cc (test): Likewise.
1440 * unittests/optional/assignment/2.cc (test): Likewise.
1441 * unittests/optional/assignment/3.cc (test): Likewise.
1442 * unittests/optional/assignment/4.cc (test): Likewise.
1443 * unittests/optional/assignment/5.cc (test): Likewise.
1444 * unittests/optional/assignment/6.cc (test): Likewise.
1445 * unittests/optional/assignment/7.cc (test): Likewise.
1446 * unittests/optional/cons/copy.cc (test): Likewise.
1447 * unittests/optional/cons/default.cc (test): Likewise.
1448 * unittests/optional/cons/move.cc (test): Likewise.
1449 * unittests/optional/cons/value.cc (test): Likewise.
1450 * unittests/optional/in_place.cc (test): Likewise.
1451 * unittests/optional/observers/1.cc (test): Likewise.
1452 * unittests/optional/observers/2.cc (test): Likewise.
1453
3b5c1d49
SM
14542019-11-26 Simon Marchi <simon.marchi@efficios.com>
1455
1456 * tui-win.h (tui_set_var_cmd): Remove.
1457 * tui-win.c (tui_set_var_cmd): Make static.
1458
adce99fe
SM
14592019-11-26 Simon Marchi <simon.marchi@efficios.com>
1460
1461 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1462 rbreak_command_wrapper): Remove.
1463 * symtab.c (rbreak_command_wrapper): Remove.
1464
fe3adccf
SM
14652019-11-26 Simon Marchi <simon.marchi@efficios.com>
1466
1467 * inferior.h (info_terminal_command): Remove declaration.
1468 * inflow.c (info_terminal_command): Make static.
1469
b926335f
SM
14702019-11-26 Simon Marchi <simon.marchi@efficios.com>
1471
1472 * inferior.c (exit_inferior_silent): Remove.
1473
b62f6f54
SM
14742019-11-26 Simon Marchi <simon.marchi@efficios.com>
1475
1476 * dictionary.c (dict_empty, mdict_empty): Remove.
1477 * dictionary.c (mdict_empty): Remove.
1478
cb8c24b6
SM
14792019-11-26 Simon Marchi <simon.marchi@efficios.com>
1480
1481 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1482 (arc_insn_get_memory_offset): Likewise.
1483 (arc_insn_dump): Likewise.
1484 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1485 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1486 * dictionary.c (dict_iterator_next): Likewise.
1487 (dict_iter_match_first): Likewise.
1488 (dict_iter_match_next): Likewise.
1489 * f-lang.c (evaluate_subexp_f): Likewise.
1490 * hppa-tdep.c (hppa_read_pc): Likewise.
1491 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1492 * parse.c (write_exp_elt_msym): Likewise.
1493 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1494 * remote.c (remote_packet_size): Likewise.
1495 (remote_notif_stop_parse): Likewise.
1496 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1497 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1498 * source.c (prepare_path_for_appending): Likewise.
1499 * sparc64-linux-tdep.c
1500 (sparc64_linux_handle_segmentation_fault); Likewise.
1501 * stack.c (frame_selection_by_function_completer): Likewise.
1502
781597ff
SM
15032019-11-26 Simon Marchi <simon.marchi@efficios.com>
1504
1505 * completer.c (set_gdb_completion_word_break_characters):
1506 Remove.
1507
23baa4cc
SM
15082019-11-26 Simon Marchi <simon.marchi@efficios.com>
1509
1510 * dwarf-index-write.c: Include dwarf-index-write.h.
1511 * mi/mi-interp.c: Include mi/mi-interp.h.
1512
23767560
SM
15132019-11-26 Simon Marchi <simon.marchi@efficios.com>
1514
1515 * aarch32-tdep.c: Include aarch32-tdep.h.
1516 * aarch32-tdep.h: Forward-declare struct target_desc.
1517
6d91ce9a
CB
15182019-11-26 Christian Biesinger <cbiesinger@google.com>
1519
1520 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1521 strerror.
1522 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1523 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1524
3cf2f237
TV
15252019-11-25 Tom de Vries <tdevries@suse.de>
1526
1527 * contrib/words.sh: Add -c option.
1528
5b89c67a
CB
15292019-11-25 Christian Biesinger <cbiesinger@google.com>
1530
1531 * solib.c (solib_find_1): Change int to bool.
1532 (exec_file_find): Change int to bool.
1533 (solib_find): Change int to bool.
1534 (solib_read_symbols): Change int to bool.
1535 (solib_used): Change int to bool.
1536 (solib_add): Change int to bool.
1537 (info_sharedlibrary_command): Change int to bool.
1538 (solib_contains_address_p): Change int to bool.
1539 (solib_keep_data_in_core): Change int to bool.
1540 (in_solib_dynsym_resolve_code): Change int to bool.
1541 (reload_shared_libraries_1): Change int to bool.
1542 (gdb_sysroot_changed): Change int to bool.
1543 * solib.h (solib_read_symbols): Change int to bool.
1544 (solib_contains_address_p): Change int to bool.
1545 (solib_keep_data_in_core): Change int to bool.
1546 (in_solib_dynsym_resolve_code): Change int to bool.
1547 (libpthread_name_p): Change int to bool.
1548
6cc8564b
LM
15492019-11-25 Luis Machado <luis.machado@linaro.org>
1550
1551 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1552 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1553 (remote_packet_max_chars): New static global.
1554 (show_remote_packet_max_chars): New function.
1555 (remote_target::putpkt_binary): Adjust to use new
1556 remote_packet_max_chars option.
1557 (remote_target::getpkt_or_notif_sane_1): Likewise.
1558 (_initialize_remote): Register new remote-packet-max-chars option.
1559
a7cdaa91
SM
15602019-11-24 Simon Marchi <simon.marchi@efficios.com>
1561
1562 * m68k-linux-nat.c: Include gdbarch.h.
1563
26abc753
TT
15642019-11-24 Tom Tromey <tom@tromey.com>
1565
1566 * symfile.c (read_symbols): Update.
1567 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1568 bool.
1569 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1570 (psym_lookup_symbol, psym_find_last_source_symtab)
1571 (psym_forget_cached_source_info, psym_print_stats)
1572 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1573 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1574 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1575 (psym_find_compunit_symtab_by_address)
1576 (maintenance_print_psymbols, maintenance_info_psymtabs)
1577 (maintenance_check_psymtabs): Update.
1578 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1579 bool.
1580
012fc909
TT
15812019-11-22 Tom Tromey <tom@tromey.com>
1582
1583 * observable.h: Update comments.
1584
c83d8d32
TT
15852019-11-22 Tom Tromey <tromey@adacore.com>
1586
1587 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1588 (print_ada_task_info): Don't try to fetch thread id if task is not
1589 alive.
1590
987012b8
CB
15912019-11-22 Christian Biesinger <cbiesinger@google.com>
1592
1593 * ada-exp.y: Update.
1594 * ada-lang.c (sort_choices): Update.
1595 (ada_print_symbol_signature): Update.
1596 (resolve_subexp): Update.
1597 (ada_parse_renaming): Update.
1598 (ada_read_renaming_var_value): Update.
1599 (lesseq_defined_than): Update.
1600 (remove_extra_symbols): Update.
1601 (remove_irrelevant_renamings): Update.
1602 (ada_add_block_symbols): Update.
1603 (ada_collect_symbol_completion_matches): Update.
1604 (ada_is_renaming_symbol): Update.
1605 (aggregate_assign_from_choices): Update.
1606 (ada_evaluate_subexp): Update.
1607 (ada_has_this_exception_support): Update.
1608 (ada_is_non_standard_exception_sym): Update.
1609 (ada_add_exceptions_from_frame): Update.
1610 (ada_add_global_exceptions): Update.
1611 (ada_print_subexp): Update.
1612 * ax-gdb.c (gen_var_ref): Update.
1613 (gen_maybe_namespace_elt): Update.
1614 (gen_expr_for_cast): Update.
1615 (gen_expr): Update.
1616 * block.h: Update.
1617 * blockframe.c (find_pc_partial_function): Update.
1618 * breakpoint.c (print_breakpoint_location): Update.
1619 (update_static_tracepoint): Update.
1620 * btrace.c (ftrace_print_function_name): Update.
1621 (ftrace_function_switched): Update.
1622 * buildsym.c (find_symbol_in_list): Update.
1623 * c-exp.y: Update.
1624 * c-typeprint.c (c_print_typedef): Update.
1625 (c_type_print_template_args): Update.
1626 * cli/cli-cmds.c (edit_command): Update.
1627 (list_command): Update.
1628 (print_sal_location): Update.
1629 * coffread.c (patch_opaque_types): Update.
1630 (process_coff_symbol): Update.
1631 (coff_read_enum_type): Update.
1632 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1633 (convert_one_symbol): Update.
1634 (hash_symname): Update.
1635 (eq_symname): Update.
1636 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1637 * compile/compile-cplus-types.c (debug_print_scope): Update.
1638 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1639 * compile/compile-object-load.c (get_out_value_type): Update.
1640 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1641 (search_symbol_list): Update.
1642 (cp_lookup_symbol_imports_or_template): Update.
1643 * cp-support.c (overload_list_add_symbol): Update.
1644 * ctfread.c (psymtab_to_symtab): Update.
1645 * dbxread.c (cp_set_block_scope): Update.
1646 * dictionary.c (iter_match_first_hashed): Update.
1647 (iter_match_next_hashed): Update.
1648 (insert_symbol_hashed): Update.
1649 (iter_match_next_linear): Update.
1650 * dictionary.h: Update.
1651 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1652 (locexpr_describe_location_piece): Update.
1653 (locexpr_describe_location_1): Update.
1654 (locexpr_generate_c_location): Update.
1655 (loclist_describe_location): Update.
1656 (loclist_generate_c_location): Update.
1657 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1658 (read_func_scope): Update.
1659 (process_enumeration_scope): Update.
1660 (new_symbol): Update.
1661 (dwarf2_const_value): Update.
1662 (dwarf2_symbol_mark_computed): Update.
1663 * eval.c (evaluate_funcall): Update.
1664 (evaluate_subexp_standard): Update.
1665 * expprint.c (print_subexp_standard): Update.
1666 (dump_subexp_body_standard): Update.
1667 * f-valprint.c (info_common_command_for_block): Update.
1668 * findvar.c (get_hosting_frame): Update.
1669 (default_read_var_value): Update.
1670 * go-lang.c (go_symbol_package_name): Update.
1671 * guile/scm-block.c (bkscm_print_block_smob): Update.
1672 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1673 (gdbscm_symbol_name): Update.
1674 (gdbscm_symbol_linkage_name): Update.
1675 (gdbscm_symbol_print_name): Update.
1676 * infcall.c (get_function_name): Update.
1677 * infcmd.c (jump_command): Update.
1678 (finish_command): Update.
1679 * infrun.c (insert_exception_resume_breakpoint): Update.
1680 * linespec.c (canonicalize_linespec): Update.
1681 (create_sals_line_offset): Update.
1682 (convert_linespec_to_sals): Update.
1683 (complete_label): Update.
1684 (find_label_symbols_in_block): Update.
1685 * m2-typeprint.c (m2_print_typedef): Update.
1686 * mdebugread.c (mdebug_reg_to_regnum): Update.
1687 (parse_symbol): Update.
1688 (mylookup_symbol): Update.
1689 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1690 (list_args_or_locals): Update.
1691 * objc-lang.c (compare_selectors): Update.
1692 (info_selectors_command): Update.
1693 (compare_classes): Update.
1694 (info_classes_command): Update.
1695 (find_imps): Update.
1696 * p-typeprint.c (pascal_print_typedef): Update.
1697 * printcmd.c (build_address_symbolic): Update.
1698 (info_address_command): Update.
1699 (print_variable_and_value): Update.
1700 * python/py-framefilter.c (extract_sym): Update.
1701 (py_print_single_arg): Update.
1702 * python/py-symbol.c (sympy_str): Update.
1703 (sympy_get_name): Update.
1704 (sympy_get_linkage_name): Update.
1705 * python/python.c (gdbpy_rbreak): Update.
1706 * record-btrace.c (btrace_get_bfun_name): Update.
1707 (btrace_call_history): Update.
1708 * rust-lang.c (rust_print_typedef): Update.
1709 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1710 * stabsread.c (stab_reg_to_regnum): Update.
1711 (define_symbol): Update.
1712 (read_enum_type): Update.
1713 (common_block_end): Update.
1714 (cleanup_undefined_types_1): Update.
1715 (scan_file_globals): Update.
1716 * stack.c (print_frame_arg): Update.
1717 (print_frame_args): Update.
1718 (find_frame_funname): Update.
1719 (info_frame_command_core): Update.
1720 (iterate_over_block_locals): Update.
1721 (print_block_frame_labels): Update.
1722 (do_print_variable_and_value): Update.
1723 (iterate_over_block_arg_vars): Update.
1724 (return_command): Update.
1725 * symmisc.c (dump_symtab_1): Update.
1726 (print_symbol): Update.
1727 * symtab.c (eq_symbol_entry): Update.
1728 (symbol_cache_dump): Update.
1729 (lookup_language_this): Update.
1730 (find_pc_sect_line): Update.
1731 (skip_prologue_sal): Update.
1732 (symbol_search::compare_search_syms): Update.
1733 (treg_matches_sym_type_name): Update.
1734 (search_symbols): Update.
1735 (print_symbol_info): Update.
1736 (rbreak_command): Update.
1737 (completion_list_add_symbol): Update.
1738 (find_gnu_ifunc): Update.
1739 (get_symbol_address): Update.
1740 (search_module_symbols): Update.
1741 (info_module_subcommand): Update.
1742 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1743 (SYMBOL_LINKAGE_NAME): Remove.
1744 (SYMBOL_DEMANGLED_NAME): Remove.
1745 (SYMBOL_PRINT_NAME): Remove.
1746 (SYMBOL_SEARCH_NAME): Remove.
1747 * tracepoint.c (set_traceframe_context): Update.
1748 (validate_actionline): Update.
1749 (collection_list::collect_symbol): Update.
1750 (encode_actions_1): Update.
1751 (info_scope_command): Update.
1752 (print_one_static_tracepoint_marker): Update.
1753 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1754 * valops.c (address_of_variable): Update.
1755 (find_overload_match): Update.
1756 (find_oload_champ): Update.
1757
c9d95fa3
CB
17582019-11-22 Christian Biesinger <cbiesinger@google.com>
1759
1760 * ada-lang.c (ada_lookup_simple_minsym): Update.
1761 (ada_collect_symbol_completion_matches): Update.
1762 * ada-tasks.c (read_atcb): Update.
1763 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1764 (amd64_windows_skip_trampoline_code): Update.
1765 * arm-tdep.c (skip_prologue_function): Update.
1766 (arm_skip_stack_protector): Update.
1767 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1768 (arm_wince_skip_main_prologue): Update.
1769 * ax-gdb.c (gen_expr): Update.
1770 * block.c (call_site_for_pc): Update.
1771 * blockframe.c (find_pc_partial_function): Update.
1772 * breakpoint.c (set_breakpoint_location_function): Update.
1773 * btrace.c (ftrace_print_function_name): Update.
1774 (ftrace_function_switched): Update.
1775 * c-valprint.c (print_unpacked_pointer): Update.
1776 * coffread.c (coff_symfile_read): Update.
1777 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1778 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1779 * dwarf-index-write.c (write_psymbols): Update.
1780 * dwarf2loc.c (call_site_to_target_addr): Update.
1781 (func_verify_no_selftailcall): Update.
1782 (tailcall_dump): Update.
1783 (call_site_find_chain_1): Update.
1784 (dwarf_expr_reg_to_entry_parameter): Update.
1785 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1786 * eval.c (evaluate_funcall): Update.
1787 (evaluate_subexp_standard): Update.
1788 (evaluate_subexp_for_sizeof): Update.
1789 * expprint.c (print_subexp_standard): Update.
1790 (dump_subexp_body_standard): Update.
1791 * frame.c (get_prev_frame_always_1): Update.
1792 * frv-tdep.c (frv_skip_main_prologue): Update.
1793 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1794 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1795 (gnuv3_get_typename_from_type_info): Update.
1796 (gnuv3_skip_trampoline): Update.
1797 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1798 * i386-tdep.c (i386_skip_main_prologue): Update.
1799 (i386_pe_skip_trampoline_code): Update.
1800 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1801 * infcall.c (get_function_name): Update.
1802 * linespec.c (minsym_found): Update.
1803 * linux-fork.c (info_checkpoints_command): Update.
1804 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1805 (m32c_m16c_pointer_to_address): Update.
1806 * maint.c (maintenance_translate_address): Update.
1807 * minsyms.c (add_minsym_to_hash_table): Update.
1808 (add_minsym_to_demangled_hash_table): Update.
1809 (lookup_minimal_symbol_mangled): Update.
1810 (lookup_minimal_symbol_demangled): Update.
1811 (lookup_minimal_symbol_linkage): Update.
1812 (lookup_minimal_symbol_text): Update.
1813 (lookup_minimal_symbol_by_pc_name): Update.
1814 (minimal_symbol_is_less_than): Update.
1815 (compact_minimal_symbols): Update.
1816 (build_minimal_symbol_hash_tables): Update.
1817 (find_solib_trampoline_target): Update.
1818 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1819 (mips_skip_pic_trampoline_code): Update.
1820 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1821 * objc-lang.c (info_selectors_command): Update.
1822 (info_classes_command): Update.
1823 (find_methods): Update.
1824 (find_imps): Update.
1825 * p-valprint.c (pascal_val_print): Update.
1826 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1827 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1828 * printcmd.c (build_address_symbolic): Update.
1829 (info_symbol_command): Update.
1830 * psymtab.c (psymbol_name_matches): Update.
1831 (match_partial_symbol): Update.
1832 (lookup_partial_symbol): Update.
1833 (print_partial_symbols): Update.
1834 (sort_pst_symbols): Update.
1835 (maintenance_check_psymtabs): Update.
1836 * python/py-framefilter.c (py_print_frame): Update.
1837 * python/python.c (gdbpy_rbreak): Update.
1838 * record-btrace.c (btrace_get_bfun_name): Update.
1839 (btrace_call_history): Update.
1840 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1841 (rs6000_skip_trampoline_code): Update.
1842 * sol-thread.c (info_cb): Update.
1843 * stabsread.c (scan_file_globals): Update.
1844 * stack.c (find_frame_funname): Update.
1845 (info_frame_command_core): Update.
1846 * symmisc.c (dump_msymbols): Update.
1847 * symtab.c (symbol_natural_name): Rename to..,
1848 (general_symbol_info::natural_name): ...this.
1849 (symbol_demangled_name): Rename to...
1850 (general_symbol_info::demangled_name): ...this.
1851 (symbol_search_name): Rename to...
1852 (general_symbol_info::search_name): ...this.
1853 (symbol_matches_search_name): Update.
1854 (find_pc_sect_line): Update.
1855 (skip_prologue_sal): Update.
1856 (search_symbols): Update.
1857 (print_msymbol_info): Update.
1858 (rbreak_command): Update.
1859 (completion_list_add_msymbol): Update.
1860 (completion_list_objc_symbol): Update.
1861 (get_msymbol_address): Update.
1862 * symtab.h (struct general_symbol_info): Add member functions
1863 natural_name (), linkage_name (), print_name (), demangled_name (),
1864 and search_name ().
1865 (SYMBOL_NATURAL_NAME): Update.
1866 (symbol_natural_name): Move to a member function on general_symbol_info.
1867 (SYMBOL_DEMANGLED_NAME): Update.
1868 (symbol_demangled_name): Move to a member function on
1869 general_symbol_info.
1870 (SYMBOL_SEARCH_NAME): Update.
1871 (symbol_search_name): Move to a member function on general_symbol_info.
1872 (MSYMBOL_NATURAL_NAME): Remove.
1873 (MSYMBOL_LINKAGE_NAME): Remove.
1874 (MSYMBOL_PRINT_NAME): Remove.
1875 (MSYMBOL_DEMANGLED_NAME): Remove.
1876 (MSYMBOL_SEARCH_NAME): Remove.
1877 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1878
f8bab2d6
CB
18792019-11-22 Christian Biesinger <cbiesinger@google.com>
1880
1881 * symtab.c (create_demangled_names_hash): Use per_bfd->
1882 minimal_symbol_count for computing the initial size, if greater
1883 than our default size.
1884
85e7588d
TV
18852019-11-22 Tom de Vries <tdevries@suse.de>
1886
1887 * contrib/words.sh: Improve words extraction.
1888
f6180073
TV
18892019-11-22 Tom de Vries <tdevries@suse.de>
1890
1891 * contrib/words.sh: Combine sed invocations.
1892
f10ffa41
CB
18932019-11-21 Christian Biesinger <cbiesinger@google.com>
1894
1895 * Makefile.in: Update.
1896 * demangle.c: Rename to...
1897 * gdb-demangle.c: ..this.
1898 (is_cplus_marker): Change return type to bool.
1899 (_initialize_demangler): Rename to...
1900 (_initialize_gdb_demangle): ...this.
1901 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1902 * symtab.h (demangle): Remove declaration; instead include
1903 gdb-demangle.h.
1904
6ba18521
TT
19052019-11-21 Tom Tromey <tromey@adacore.com>
1906
1907 * gdbsupport/format.c (format_pieces): Parse %I64d.
1908 * unittests/format_pieces-selftests.c (test_windows_formats): New
1909 function.
1910 (run_tests): Call it.
1911
34877895
PJ
19122019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1913
1914 Byte reverse display of variables with DW_END_big, DW_END_little
1915 (DW_AT_endianity) dwarf attributes if different than the native
1916 byte order.
1917 * ada-lang.c (ada_value_binop):
1918 Use type_byte_order instead of gdbarch_byte_order.
1919 * ada-valprint.c (printstr):
1920 (ada_val_print_string):
1921 * ada-lang.c (value_pointer):
1922 (ada_value_binop):
1923 Use type_byte_order instead of gdbarch_byte_order.
1924 * c-lang.c (c_get_string):
1925 Use type_byte_order instead of gdbarch_byte_order.
1926 * c-valprint.c (c_val_print_array):
1927 Use type_byte_order instead of gdbarch_byte_order.
1928 * cp-valprint.c (cp_print_class_member):
1929 Use type_byte_order instead of gdbarch_byte_order.
1930 * dwarf2loc.c (rw_pieced_value):
1931 Use type_byte_order instead of gdbarch_byte_order.
1932 * dwarf2read.c (read_base_type): Handle DW_END_big,
1933 DW_END_little
1934 * f-lang.c (f_get_encoding):
1935 Use type_byte_order instead of gdbarch_byte_order.
1936 * findvar.c (default_read_var_value):
1937 Use type_byte_order instead of gdbarch_byte_order.
1938 * gdbtypes.c (check_types_equal):
1939 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1940 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1941 and TYPE_ENDIANITY_LITTLE if set.
1942 (type_byte_order): new function.
1943 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1944 (struct main_type) <flag_endianity_not_default>:
1945 New field.
1946 (type_byte_order): New function.
1947 * infcmd.c (default_print_one_register_info):
1948 Use type_byte_order instead of gdbarch_byte_order.
1949 * p-lang.c (pascal_printstr):
1950 Use type_byte_order instead of gdbarch_byte_order.
1951 * p-valprint.c (pascal_val_print):
1952 Use type_byte_order instead of gdbarch_byte_order.
1953 * printcmd.c (print_scalar_formatted):
1954 Use type_byte_order instead of gdbarch_byte_order.
1955 * solib-darwin.c (darwin_current_sos):
1956 Use type_byte_order instead of gdbarch_byte_order.
1957 * solib-svr4.c (solib_svr4_r_ldsomap):
1958 Use type_byte_order instead of gdbarch_byte_order.
1959 * stap-probe.c (stap_modify_semaphore):
1960 Use type_byte_order instead of gdbarch_byte_order.
1961 * target-float.c (target_float_same_format_p):
1962 Use type_byte_order instead of gdbarch_byte_order.
1963 * valarith.c (scalar_binop):
1964 (value_bit_index):
1965 Use type_byte_order instead of gdbarch_byte_order.
1966 * valops.c (value_cast):
1967 Use type_byte_order instead of gdbarch_byte_order.
1968 * valprint.c (generic_emit_char):
1969 (generic_printstr):
1970 (val_print_string):
1971 Use type_byte_order instead of gdbarch_byte_order.
1972 * value.c (unpack_long):
1973 (unpack_bits_as_long):
1974 (unpack_value_bitfield):
1975 (modify_field):
1976 (pack_long):
1977 (pack_unsigned_long):
1978 Use type_byte_order instead of gdbarch_byte_order.
1979 * findvar.c (unsigned_pointer_to_address):
1980 (signed_pointer_to_address):
1981 (unsigned_address_to_pointer):
1982 (address_to_signed_pointer):
1983 (default_read_var_value):
1984 (default_value_from_register):
1985 Use type_byte_order instead of gdbarch_byte_order.
1986 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1987 Use type_byte_order instead of gdbarch_byte_order.
1988 * riscv-tdep.c (riscv_print_one_register_info):
1989 Use type_byte_order instead of gdbarch_byte_order.
1990
87fb00ea
SM
19912019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1992
1993 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1994 (current_ui_gdb_stdin_ptr): Likewise.
1995 (current_ui_gdb_stderr_ptr): Likewise.
1996 (current_ui_gdb_stdlog_ptr): Likewise.
1997 (current_ui_current_uiout_ptr): Likewise.
1998 (gen_ret_current_ui_field_ptr): Remove.
1999
65d1cd5f
TV
20002019-11-21 Tom de Vries <tdevries@suse.de>
2001
2002 PR gdb/24956
2003 * cli/cli-script.c (execute_control_command): Only switch to
2004 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2005
9f6ad286
TT
20062019-11-19 Tom Tromey <tom@tromey.com>
2007
2008 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2009 Now static. Change type of "name".
2010 (tui_set_win_height_command): Don't copy "arg".
2011 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2012 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2013
435d3d88
AT
20142019-11-19 Ali Tamur <tamur@google.com>
2015
2016 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2017 "if (attr != nullptr)".
2018 (dwarf2_find_base_address): Likewise.
2019 (dwarf2_build_include_psymtabs): Likewise.
2020 (read_cutu_die_from_dwo): Likewise.
2021 (read_func_scope): Likewise.
2022 (read_call_site_scope): Likewise.
2023 (dwarf2_get_pc_bounds): Likewise.
2024 (dwarf2_record_block_ranges): Likewise.
2025 (dwarf2_add_field): Likewise.
2026 (dwarf2_add_member_fn): Likewise.
2027 (read_structure_type): Likewise.
2028 (read_enumeration_type): Likewise.
2029 (read_array_type): Likewise.
2030 (read_array_order): Likewise.
2031 (read_set_type): Likewise.
2032 (read_common_block): Likewise.
2033 (read_tag_reference_type): Likewise.
2034 (read_tag_string_type): Likewise.
2035 (read_subroutine_type): Likewise.
2036 (read_base_type): Likewise.
2037 (read_subrange_type): Likewise.
2038 (new_symbol): Likewise.
2039 (prepare_one_comp_unit): Likewise.
2040
c9739b6a
TT
20412019-11-19 Tom Tromey <tromey@adacore.com>
2042
2043 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2044 result in error when DebugActiveProcess fails.
2045
494409bb
SDJ
20462019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2047 Pedro Alves <palves@redhat.com>
2048
2049 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2050 * target.c (target_stack::push): Call 'unpush' if there's a
2051 target on top of the stack.
2052
2e953aca
PW
20532019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2054
2055 * python/py-block.c (blpy_dealloc): Call tp_free.
2056 (blpy_block_syms_dealloc): Likewise.
2057 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2058 * python/py-inferior.c (infpy_dealloc): Likewise.
2059 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2060 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2061 * python/py-symbol.c (sympy_dealloc): Likewise.
2062 * python/py-symtab.c (stpy_dealloc): Likewise.
2063 * python/py-type.c (typy_iterator_dealloc): Likewise.
2064
6edc43ec
CB
20652019-11-18 Christian Biesinger <cbiesinger@google.com>
2066
2067 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2068 constructor instead of using a class initializer.
2069
cd850b40
CB
20702019-11-15 Christian Biesinger <cbiesinger@google.com>
2071
2072 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2073 * configure: Regenerate.
2074 * configure.ac: Don't source common.host.
2075 * gdbsupport/common.host: Remove.
2076 * gdbsupport/mingw-strerror.c: Remove.
2077 * gdbsupport/posix-strerror.c: Rename to...
2078 * gdbsupport/safe-strerror.c: ...this.
2079
53fea9c7
CB
20802019-11-15 Christian Biesinger <cbiesinger@google.com>
2081
2082 * maint.c (scoped_command_stats::print_time): Use localtime_r
2083 instead of localtime (provided through gnulib if necessary).
2084 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2085 of ctime.
2086
f8e27d88
CB
20872019-11-15 Christian Biesinger <cbiesinger@google.com>
2088
2089 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2090 avoid compile errors.
2091
5abebf3c
CB
20922019-11-15 Christian Biesinger <cbiesinger@google.com>
2093
2094 * config.in: Regenerate.
2095 * configure: Regenerate.
2096 * gdbsupport/common.m4: No longer check for strerror_r.
2097 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2098 POSIX version of strerror_r, now that gnulib provides it if
2099 necessary.
2100
9a351667
CB
21012019-11-14 Christian Biesinger <cbiesinger@google.com>
2102
2103 * README (`configure' options): Update.
2104
55708e99
TT
21052019-11-14 Tom Tromey <tromey@adacore.com>
2106
2107 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2108 expected type for the RHS if the LHS is a convenience variable.
2109
4b09bb2e
SM
21102019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2111
2112 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2113 Provide explicit default and copy constructor.
2114
bd454f8b
PW
21152019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2116
2117 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2118 only call Py_INCREF (newbp) in the bppy_pending_object case.
2119
d1aa3cf0
TT
21202019-11-13 Tom Tromey <tromey@adacore.com>
2121
2122 PR build/25182:
2123 * psympriv.h (partial_symbol): Remove static assert.
2124 * symtab.h (general_symbol_info, symbol): Remove static assert.
2125
e06f3d6e
AB
21262019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2127
2128 * gdbsupport/format.c (format_pieces::format_pieces): Support
2129 printf 'z' size modifier.
2130 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2131 * printcmd.c (ui_printf): Handle size_t_arg.
2132 * ui-out.c (ui_out::vmessage): Likewise.
2133 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2134 function.
2135 (run_tests): Call test_format_int_sizes.
2136
468c0cbb
CB
21372019-11-12 Christian Biesinger <cbiesinger@google.com>
2138
2139 * ada-exp.y (write_ambiguous_var): Update.
2140 * buildsym.c (add_symbol_to_list): Update.
2141 * dwarf2read.c (read_variable): Update.
2142 (new_symbol): Update.
2143 * jit.c (finalize_symtab): Update.
2144 * language.c (language_alloc_type_symbol): Update.
2145 * symtab.c (fixup_symbol_section): Update.
2146 (initialize_objfile_symbol_1): Move code to...
2147 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2148 (allocate_symbol): Update.
2149 (allocate_template_symbol): Update.
2150 (get_symbol_address): Update.
2151 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2152 of having as a field, and add a constructor.
2153 (SYMBOL_VALUE): Update.
2154 (SYMBOL_VALUE_ADDRESS): Update.
2155 (SET_SYMBOL_VALUE_ADDRESS): Update.
2156 (SYMBOL_VALUE_BYTES): Update.
2157 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2158 (SYMBOL_BLOCK_VALUE): Update.
2159 (SYMBOL_VALUE_CHAIN): Update.
2160 (SYMBOL_LANGUAGE): Update.
2161 (SYMBOL_SECTION): Update.
2162 (SYMBOL_OBJ_SECTION): Update.
2163 (SYMBOL_SET_LANGUAGE): Update.
2164 (SYMBOL_SET_LINKAGE_NAME): Update.
2165 (SYMBOL_SET_NAMES): Update.
2166 (SYMBOL_NATURAL_NAME): Update.
2167 (SYMBOL_LINKAGE_NAME): Update.
2168 (SYMBOL_DEMANGLED_NAME): Update.
2169 (SYMBOL_SEARCH_NAME): Update.
2170 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2171 (struct symbol): Update.
2172 (struct template_symbol): Update.
2173 (struct rust_vtable_symbol): Update.
2174 * xcoffread.c (SYMBOL_DUP): Update.
2175
ed2c82c3
TT
21762019-11-12 Tom Tromey <tom@tromey.com>
2177
2178 * tui/tui-layout.c (show_layout): Set current_layout.
2179 (show_source_disasm_command, show_data)
2180 (show_source_or_disasm_and_command): Don't set current_layout.
2181
d9fcefd5
TT
21822019-11-12 Tom Tromey <tom@tromey.com>
2183
2184 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2185
45e42163
TT
21862019-11-12 Tom Tromey <tom@tromey.com>
2187
2188 * tui/tui-win.c (resize_message): New global.
2189 (show_tui_resize_message): New function.
2190 (tui_async_resize_screen): Print message if requested.
2191 (_initialize_tui_win): Add tui-resize-message setting.
2192 * NEWS: Add entry for new commands.
2193
c86d74cc
TT
21942019-11-11 Tom Tromey <tom@tromey.com>
2195
2196 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2197 functions.
2198
7b7b9424
CB
21992019-11-11 Christian Biesinger <cbiesinger@google.com>
2200
2201 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2202
086baaf1
AB
22032019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2204
2205 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2206 function.
2207 * python/python-internal.h (gdbpy_lookup_static_symbols):
2208 Declare new function.
2209 * python/python.c (python_GdbMethods): Add
2210 gdb.lookup_static_symbols method.
2211 * NEWS: Mention gdb.lookup_static_symbols.
2212
09ff83af
AB
22132019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2214
2215 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2216 static block of current object file first. Also fix typo in
2217 header comment.
2218
eb2dd8df
AB
22192019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2220
2221 * stack.c (set_last_displayed_sal): Delete.
2222 (last_displayed_sal_valid): Delete.
2223 (last_displayed_pspace): Delete.
2224 (last_displayed_addr): Delete.
2225 (last_displayed_symtab): Delete.
2226 (last_displayed_line): Delete.
2227 (class last_displayed_symtab_info_type): New.
2228 (last_displayed_symtab_info): New static global variable.
2229 (print_frame_info): Call methods on last_displayed_symtab_info.
2230 (clear_last_displayed_sal): Update header comment, and make use of
2231 last_displayed_symtab_info.
2232 (last_displayed_sal_is_valid): Likewise.
2233 (get_last_displayed_pspace): Likewise.
2234 (get_last_displayed_addr): Likewise.
2235 (get_last_displayed_symtab): Likewise.
2236 (get_last_displayed_line): Likewise.
2237 (get_last_displayed_sal): Likewise.
2238 * stack.h (clear_last_displayed_sal): Update header comment.
2239 (last_displayed_sal_is_valid): Likewise.
2240 (get_last_displayed_pspace): Likewise.
2241 (get_last_displayed_addr): Likewise.
2242 (get_last_displayed_symtab): Likewise.
2243 (get_last_displayed_line): Likewise.
2244 (get_last_displayed_sal): Likewise.
2245
62137775
AB
22462019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2247
2248 * stack.c (frame_show_address): Convert return type to bool.
2249 * stack.h (frame_show_address): Likewise, and update header
2250 comment.
2251
cf57ad6d
AB
22522019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2253
2254 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2255 * unittests/vec-utils-selftests.c: New file.
2256 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2257
0b026263
TT
22582019-11-10 Tom Tromey <tom@tromey.com>
2259
2260 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2261 (tui_highlight_win): Likewise.
2262 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2263 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2264 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2265 Don't set can_highlight.
2266
b049ce2d
TT
22672019-11-10 Tom Tromey <tom@tromey.com>
2268
2269 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2270 Remove unused declaration.
2271
992a7040
TT
22722019-11-08 Tom Tromey <tromey@adacore.com>
2273
2274 * top.c (read_command_file): Update.
2275 (command_line_input): Make return type const.
2276 * python/py-gdb-readline.c: Update.
2277 * linespec.c (decode_line_2): Update.
2278 * defs.h (command_line_input): Make return type const.
2279 * cli/cli-script.c (read_next_line): Make return type const.
2280 * ada-lang.c (get_selections): Update.
2281
ca3a04f6
CB
22822019-11-06 Christian Biesinger <cbiesinger@google.com>
2283
2284 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2285 * mi/mi-main.c (output_cores): Likewise.
2286 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2287 (linux_xfer_osdata_modules): Likewise.
2288 * remote.c (register_remote_support_xml): Likewise.
2289 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2290 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2291
e0eac551
TT
22922019-11-06 Tom Tromey <tom@tromey.com>
2293
2294 * tui/tui-interp.c: Don't include readline.h.
2295 * tui/tui-hooks.c: Don't include readline.h.
2296 * symmisc.c: Include tilde.h, not readline.h.
2297 * symfile.c: Include tilde.h, not readline.h.
2298 * source.c: Include tilde.h, not readline.h.
2299 * solib.c: Include tilde.h, not readline.h.
2300 * psymtab.c: Include tilde.h, not readline.h.
2301 * exec.c: Include tilde.h, not readline.h.
2302 * corelow.c: Include tilde.h, not readline.h.
2303 * cli/cli-dump.c: Include tilde.h, not readline.h.
2304 * cli/cli-cmds.c: Don't include readline.h.
2305
825165c5
TT
23062019-11-05 Tom Tromey <tom@tromey.com>
2307
2308 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2309 (tui_disassemble): Set addr_size.
2310 (tui_disasm_window::set_contents): Use addr_size.
2311
91ae903f
TT
23122019-11-05 Tom Tromey <tom@tromey.com>
2313
2314 * rust-lang.c (rust_language_defn): Update.
2315 * python/py-value.c (valpy_string): Call c_get_string.
2316 * p-lang.c (pascal_language_defn): Update.
2317 * opencl-lang.c (opencl_language_defn): Update.
2318 * objc-lang.c (objc_language_defn): Update.
2319 * m2-lang.c (m2_language_defn): Update.
2320 * language.c (unknown_language_defn, auto_language_defn): Update.
2321 (default_get_string): Remove.
2322 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2323 * go-lang.c (go_language_defn): Update.
2324 * f-lang.c (f_language_defn): Update.
2325 * d-lang.c (d_language_defn): Update.
2326 * c-lang.c (c_language_defn, cplus_language_defn)
2327 (asm_language_defn, minimal_language_defn): Update.
2328 * ada-lang.c (ada_language_defn): Update.
2329 * language.h (struct language_defn) <la_get_string>: Remove.
2330 (LA_GET_STRING): Remove.
2331 (default_get_string): Don't declare.
2332
1df2f9ef
TT
23332019-11-05 Tom Tromey <tom@tromey.com>
2334
2335 * tui/tui-source.h (struct tui_source_window): Inline
2336 constructor. Remove destructor.
2337 <style_changed, m_observable>: Move to superclass.
2338 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2339 (struct tui_source_window_base): Move private members to end.
2340 <style_changed, m_observable>: Move from tui_source_window.
2341 * tui/tui-winsource.c (tui_copy_source_line): Move from
2342 tui-source.c. Rename from copy_source_line. Add special handling
2343 for negative line number.
2344 (tui_source_window_base::style_changed): Move from
2345 tui_source_window.
2346 (tui_source_window_base): Register observer.
2347 (~tui_source_window_base): New.
2348 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2349 rename.
2350 (tui_source_window::set_contents): Use tui_copy_source_line.
2351 (tui_source_window::tui_source_window): Move to tui-source.h.
2352 (tui_source_window::~tui_source_window): Remove.
2353 (tui_source_window::style_changed): Move to superclass.
2354 * tui/tui-disasm.c (tui_disassemble): Create string file with
2355 styling, when possible. Add "addr_size" parameter.
2356 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2357 Don't compute maximum size.
2358 (len_without_escapes): New function
2359
5d051055
TT
23602019-11-05 Tom Tromey <tom@tromey.com>
2361
2362 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2363 std::string.
2364 * tui/tui-winsource.c (tui_show_source_line): Update.
2365 * tui/tui-source.c (tui_source_window::set_contents): Update.
2366 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2367
ade7beea
CB
23682019-11-05 Christian Biesinger <cbiesinger@google.com>
2369
2370 * symtab.h (gdb_static_assert): Put && operator at the beginning
2371 of the line instead of the end.
2372
3573abe1
CB
23732019-11-04 Christian Biesinger <cbiesinger@google.com>
2374
2375 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2376 and sizeof (symbol).
2377 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2378
dae8b3eb
RO
23792019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2380
2381 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2382 * configure.host: Mark *-*-solaris2.10* obsolete.
2383 * configure.tgt: Mark Solaris < 11 obsolete.
2384 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2385 Update target triplet.
2386
5df96a4e
TT
23872019-11-01 Tom Tromey <tromey@adacore.com>
2388
2389 * utils.c (print_sys_errmsg): Simplify.
2390
b7481649
TT
23912019-11-01 Tom Tromey <tromey@adacore.com>
2392
2393 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2394
e48f6033
CB
23952019-11-01 Christian Biesinger <cbiesinger@google.com>
2396
2397 * configure: Regenerate.
2398 * configure.ac: Remove check for strerror_r.
2399 * gdbsupport/common.m4: Check for strerror_r.
2400
bd5766ec
LM
24012019-11-01 Luis Machado <luis.machado@linaro.org>
2402
2403 PR gdb/25124
2404
2405 * arm-tdep.c (arm_per_objfile): Rename to ...
2406 (arm_per_bfd): ... this.
2407 (arm_objfile_data_key): Rename to ...
2408 (arm_bfd_data_key): ... this.
2409 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2410 data.
2411 (arm_record_special_symbol): Likewise.
2412
e1709896
AB
24132019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2414
2415 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2416 end.
2417 * c-typeprint.c (c_print_typedef): Likewise.
2418 * f-typeprint.c (f_print_typedef): Likewise.
2419 * m2-typeprint.c (m2_print_typedef): Likewise.
2420 * p-typeprint.c (pascal_print_typedef): Likewise.
2421 * rust-lang.c (rust_print_typedef): Likewise.
2422 * symtab.c (print_symbol_info): Print a newline after calling
2423 typedef_print.
2424
165f8965
AB
24252019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2426
2427 * symtab.c (info_module_cmdlist): New variable.
2428 (info_module_command): New function.
2429 (search_module_symbols): New function.
2430 (info_module_subcommand): New function.
2431 (struct info_modules_var_func_options): New struct.
2432 (info_modules_var_func_options_defs): New variable.
2433 (make_info_modules_var_func_options_def_group): New function.
2434 (info_module_functions_command): New function.
2435 (info_module_variables_command): New function.
2436 (info_module_var_func_command_completer): New function.
2437 (_initialize_symtab): Register new 'info module functions' and
2438 'info module variables' commands.
2439 * symtab.h (typedef symbol_search_in_module): New typedef.
2440 (search_module_symbols): Declare new function.
2441 * NEWS: Mention new commands.
2442
59c35742
AB
24432019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2444
2445 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2446 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2447 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2448 MODULES_DOMAIN.
2449 (scan_partial_symbols): Only create partial module symbols for non
2450 declarations.
2451 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2452 and MODULES_DOMAIN.
2453 * symtab.c (search_domain_name): Likewise.
2454 (search_symbols): Likewise.
2455 (print_symbol_info): Likewise.
2456 (symtab_symbol_info): Likewise.
2457 (info_modules_command): New function.
2458 (_initialize_symtab): Register 'info modules' command.
2459 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2460 * NEWS: Mention new 'info modules' command.
2461
aed61d02
PW
24622019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2463
2464 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2465 and $_gdb_maint_setting_str.
2466
9ad9b77d
PW
24672019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2468
2469 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2470 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2471 (str_value_from_setting, gdb_setting_str_internal_fn)
2472 (gdb_maint_setting_str_internal_fn): New functions.
2473 (_initialize_cli_cmds): Define the new convenience functions.
2474 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2475 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2476
8d6efaa2
CB
24772019-10-31 Christian Biesinger <cbiesinger@google.com>
2478
2479 * agent.c (set_can_use_agent): When the setting is turned on,
2480 look up agent symbols if we don't have them yet.
2481 (agent_new_objfile): Don't look up agent symbols when the agent
2482 setting is off.
2483
33cb1647
CB
24842019-10-31 Christian Biesinger <cbiesinger@google.com>
2485
2486 * config.in: Regenerate.
2487
b231e86a
CB
24882019-10-31 Christian Biesinger <cbiesinger@google.com>
2489
2490 * configure: Regenerate.
2491 * configure.ac: Check for strerror_r.
2492 * gdbsupport/common-utils.h (safe_strerror): Change return value
2493 to const char * and document that this function is now threadsafe.
2494 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2495 thread_local and call strerror_r, if available.
2496 * utils.c (perror_string): Update.
2497 (print_sys_errmsg): Update.
2498
a2726d4f
LM
24992019-10-31 Luis Machado <luis.machado@linaro.org>
2500
2501 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2502 objfile_key.
2503 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2504 objfile to fetch per-bfd data.
2505 (arm_find_exidx_entry): Likewise.
2506
75cafaa6
CB
25072019-10-31 Christian Biesinger <cbiesinger@google.com>
2508
2509 * gdbsupport/agent.c (debug_agent): Change type to bool.
2510 (use_agent): Likewise.
2511 (all_agent_symbols_look_up): Likewise.
2512 (agent_loaded_p): Change return value to bool.
2513 (agent_look_up_symbols): Update.
2514 (agent_capability_check): Change return value to bool.
2515 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2516 (debug_agent): Change type to bool.
2517 (use_agent): Likewise.
2518 (agent_capability_check): Change return value to bool.
2519
808590ec
CB
25202019-10-30 Christian Biesinger <cbiesinger@google.com>
2521
2522 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2523 (build_minimal_symbol_hash_tables): Code to clear the table moved
2524 to clear_minimal_symbol_hash_tables.
2525 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2526 when needed.
2527
f18ad8a1
SM
25282019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2529
2530 * infcmd.c: Remove includes.
2531 * infrun.c: Remove includes.
2532
de93309a
SM
25332019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2534
2535 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2536 (grow_vect): Remove declaration.
2537 (ada_type_of_array): Remove declaration.
2538 (ada_update_initial_language): Remove declaration.
2539 (ada_fold_name): Remove declaration.
2540 (ada_fill_in_ada_prototype): Remove declaration.
2541 (user_select_syms): Remove declaration.
2542 (get_selections): Remove declaration.
2543 (ada_tag_type): Remove declaration.
2544 (ada_value_tag): Remove declaration.
2545 (ada_is_others_clause): Remove declaration.
2546 (ada_in_variant): Remove declaration.
2547 (ada_value_struct_elt): Remove declaration.
2548 (ada_attribute_name): Remove declaration.
2549 (ada_system_address_type): Remove declaration.
2550 * ada-lang.c (ada_watch_location_expression): Make static.
2551 (GROW_VECT): Move here from ada-lang.h.
2552 (grow_vect): Make static.
2553 (ada_update_initial_language): Make static.
2554 (ada_fold_name): Make static.
2555 (ada_type_of_array): Make static.
2556 (encoded_ordered_before): Move up.
2557 (sort_choices): Move up.
2558 (print_signatures): Move up.
2559 (ada_print_symbol_signature): Move up.
2560 (get_selections): Move up and make static.
2561 (user_select_syms): Move up and make static.
2562 (ada_value_struct_elt): Move up and make static.
2563 (ada_tag_type): Make static.
2564 (ada_value_tag): Make static.
2565 (ada_is_others_clause): Make static.
2566 (ada_in_variant): Make static.
2567 (ada_attribute_name): Make static.
2568
cdc46a9f
SM
25692019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2570
2571 * ada-lang.c: Remove includes.
2572 * ada-typeprint.c: Remove includes.
2573 * ada-valprint.c: Remove includes.
2574
90421c56
SM
25752019-10-29 Simon Marchi <simon.marchi@efficios.com>
2576
2577 * addrmap.c: Add static assertions of type size, moved from
2578 _initialize_addrmap.
2579 (_initialize_addrmap): Remove.
2580
31edb802
CB
25812019-10-29 Christian Biesinger <cbiesinger@google.com>
2582
2583 * coffread.c (record_minimal_symbol): Update.
2584 (process_coff_symbol): Update.
2585 * dbxread.c (read_dbx_symtab): Update.
2586 * dwarf2read.c (add_partial_symbol): Update.
2587 (fixup_go_packaging): Update.
2588 (load_partial_dies): Update.
2589 (new_symbol): Update.
2590 * elfread.c (record_minimal_symbol): Change signature to use
2591 gdb::string_view instead of name+len.
2592 (elf_symtab_read): Update.
2593 (elf_rel_plt_read): Update.
2594 * mdebugread.c (parse_partial_symbols): Update.
2595 (handle_psymbol_enumerators): Update.
2596 (new_symbol): Update.
2597 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2598 to use gdb::string_view instead of name+len.
2599 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2600 * psympriv.h (add_psymbol_to_list): Likewise.
2601 * psymtab.c (add_psymbol_to_bcache): Likewise.
2602 (add_psymbol_to_list): Likewise.
2603 * stabsread.c (define_symbol): Update.
2604 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2605 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2606 (symbol_set_names): Likewise.
2607 * xcoffread.c (scan_xcoff_symtab): Update.
2608
0c921b21
CB
26092019-10-29 Christian Biesinger <cbiesinger@google.com>
2610
2611 * symtab.h (symbol_set_names): Document that copy_name must be
2612 set to true for non-nullterminated strings.
2613 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2614 linkage_name if the entry was not found and we need to demangle.
2615
35e65c49
CB
26162019-10-29 Christian Biesinger <cbiesinger@google.com>
2617
2618 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2619 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2620 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2621 * gdbsupport/gdb_binary_search.h: New file.
2622
ed2a2229
CB
26232019-10-29 Christian Biesinger <cbiesinger@google.com>
2624
2625 * NEWS: Mention new --with-system-gdbinit-dir option.
2626 * config.in: Regenerate.
2627 * configure: Regenerate.
2628 * configure.ac: Add new option --with-system-gdbinit-dir.
2629 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2630 for a ".gdb" suffix.
2631 * main.c (get_init_files): Change system_gdbinit argument to
2632 a vector and return the files in SYSTEM_GDBINIT_DIR in
2633 addition to SYSTEM_GDBINIT.
2634 (captured_main_1): Update.
2635 (print_gdb_help): Update.
2636 * top.c (print_gdb_configuration): Also print the value of
2637 SYSTEM_GDBINIT_DIR.
2638
87f34879
CB
26392019-10-28 Christian Biesinger <cbiesinger@google.com>
2640
2641 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2642 that takes gdb::string_view arguments.
2643
30baf67b
TV
26442019-10-26 Tom de Vries <tdevries@suse.de>
2645
2646 * aarch64-linux-tdep.c: Fix typos in comments.
2647 * aarch64-tdep.c: Same.
2648 * ada-lang.c: Same.
2649 * amd64-nat.c: Same.
2650 * arc-tdep.c: Same.
2651 * arch/aarch64-insn.c: Same.
2652 * block.c: Same.
2653 * breakpoint.h: Same.
2654 * btrace.h: Same.
2655 * c-varobj.c: Same.
2656 * cli/cli-decode.c: Same.
2657 * cli/cli-script.c: Same.
2658 * cli/cli-utils.h: Same.
2659 * coff-pe-read.c: Same.
2660 * coffread.c: Same.
2661 * compile/compile-cplus-symbols.c: Same.
2662 * compile/compile-object-run.c: Same.
2663 * completer.c: Same.
2664 * corelow.c: Same.
2665 * cp-support.c: Same.
2666 * demangle.c: Same.
2667 * dwarf-index-write.c: Same.
2668 * dwarf2-frame.c: Same.
2669 * dwarf2-frame.h: Same.
2670 * eval.c: Same.
2671 * frame-base.h: Same.
2672 * frame.h: Same.
2673 * gdbcmd.h: Same.
2674 * gdbtypes.h: Same.
2675 * gnu-nat.c: Same.
2676 * guile/scm-objfile.c: Same.
2677 * i386-tdep.c: Same.
2678 * i386-tdep.h: Same.
2679 * infcall.c: Same.
2680 * infcall.h: Same.
2681 * linux-nat.c: Same.
2682 * m68k-tdep.c: Same.
2683 * macroexp.c: Same.
2684 * memattr.c: Same.
2685 * mi/mi-cmd-disas.c: Same.
2686 * mi/mi-getopt.h: Same.
2687 * mi/mi-main.c: Same.
2688 * minsyms.c: Same.
2689 * nat/aarch64-sve-linux-sigcontext.h: Same.
2690 * objfiles.h: Same.
2691 * ppc-linux-nat.c: Same.
2692 * ppc-linux-tdep.c: Same.
2693 * ppc-tdep.h: Same.
2694 * progspace.h: Same.
2695 * prologue-value.h: Same.
2696 * python/py-evtregistry.c: Same.
2697 * python/py-instruction.h: Same.
2698 * record-btrace.c: Same.
2699 * record-full.c: Same.
2700 * remote.c: Same.
2701 * rs6000-tdep.c: Same.
2702 * ser-tcp.c: Same.
2703 * sol-thread.c: Same.
2704 * sparc-sol2-tdep.c: Same.
2705 * sparc64-tdep.c: Same.
2706 * stabsread.c: Same.
2707 * symfile.c: Same.
2708 * symtab.h: Same.
2709 * target.c: Same.
2710 * tracepoint.c: Same.
2711 * tui/tui-data.h: Same.
2712 * tui/tui-io.c: Same.
2713 * tui/tui-win.c: Same.
2714 * tui/tui.c: Same.
2715 * unittests/rsp-low-selftests.c: Same.
2716 * user-regs.h: Same.
2717 * utils.c: Same.
2718 * utils.h: Same.
2719 * valarith.c: Same.
2720 * valops.c: Same.
2721 * valprint.c: Same.
2722 * valprint.h: Same.
2723 * value.c: Same.
2724 * value.h: Same.
2725 * varobj.c: Same.
2726 * x86-nat.h: Same.
2727 * xtensa-tdep.c: Same.
2728
1834d45f
AT
27292019-10-25 Ali Tamur <tamur@google.com>
2730
2731 * charset.c (find_charset_names): Reflect API change.
2732
5396ae17
CB
27332019-10-25 Christian Biesinger <cbiesinger@google.com>
2734
2735 * symtab.c (struct demangled_name_entry): Change demangled name
2736 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2737 part of the struct anymore.
2738 (symbol_set_names): No longer obstack allocate + copy the demangled
2739 name, just store the allocated name from bfd.
2740
93878f47
TT
27412019-10-25 Tom Tromey <tromey@adacore.com>
2742
2743 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2744 (bsearch_cie_cmp, add_cie): Remove.
2745 (find_cie): Reimplement.
2746 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2747 (dwarf2_build_frame_info): Update.
2748
7b71fc97
L
27492019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2750
2751 PR gdb/25126
2752 * symfile.c (reread_symbols): Call forget_cached_source_info to
2753 clear the stale source cache.
2754
cbb5a2ea
CB
27552019-10-24 Christian Biesinger <cbiesinger@google.com>
2756
2757 * configure: Regenerate.
2758 * configure.ac: Remove code that sets python_has_threads.
2759
71737c43
CB
27602019-10-24 Christian Biesinger <cbiesinger@google.com>
2761
2762 * config.in: Regenerate.
2763 * configure: Regenerate.
2764 * configure.ac: Remove the code that uses sed to get the python
2765 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2766
33d569b7
AB
27672019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2768
2769 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2770 error paths.
2771
f16f7b7c
TT
27722019-10-23 Tom Tromey <tom@tromey.com>
2773
2774 * arc-tdep.c: Remove ".." from include.
2775 * frv-tdep.c: Remove ".." from include.
2776 * lm32-tdep.c: Remove ".." from include.
2777 * microblaze-tdep.c: Remove ".." from include.
2778 * or1k-tdep.h: Remove ".." from include.
2779 * s12z-tdep.c: Remove ".." from include.
2780 * Makefile.in (OPCODES_CFLAGS): Add comment.
2781 (TOP_CFLAGS): New variable.
2782 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2783
6999161a
TT
27842019-10-23 Tom Tromey <tom@tromey.com>
2785
2786 * Makefile.in (READLINE_DIR): Update.
2787
12e7c35e
TBA
27882019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2789
2790 * infcall.c (call_function_by_hand_dummy): Fix the function
2791 comment. And extract out a code section into...
2792 (reserve_stack_space): ...this new function.
2793
37055cad
TBA
27942019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2795
2796 * infcall.c (value_arg_coerce): Remove an unused parameter.
2797 (call_function_by_hand_dummy): Update the call to
2798 'value_arg_coerce'.
2799
39bcc47c
TBA
28002019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2801
2802 * infcall.c (call_function_by_hand_dummy): Refactor.
2803
bd888c0f
TBA
28042019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2805
2806 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2807
c12d372d
TT
28082019-10-23 Tom Tromey <tom@tromey.com>
2809
2810 * configure: Rebuild.
2811 * configure.ac: Don't check for sigprocmask.
2812 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2813
4d0b984b
TT
28142019-10-23 Tom Tromey <tom@tromey.com>
2815
2816 * configure: Rebuild.
2817 * acinclude.m4: Use m4_include, not sinclude.
2818
7e785608
TV
28192019-10-23 Tom de Vries <tdevries@suse.de>
2820
2821 PR breakpoints/24687
2822 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2823
403772ef
CB
28242019-10-22 Christian Biesinger <cbiesinger@google.com>
2825
2826 * symtab.c (struct demangled_name_entry) <language>: Change from
2827 bitfield to regular variable.
2828
3a494279
CB
28292019-10-22 Christian Biesinger <cbiesinger@google.com>
2830
2831 * symtab.c (struct demangled_name_entry): Add a constructor.
2832 (free_demangled_name_entry): New function to call the destructor
2833 for demangled_name_entry.
2834 (create_demangled_names_hash): Pass free_demangled_name_entry to
2835 htab_create_alloc.
2836 (symbol_set_names): Call placement new for demangled_name_entry.
2837 * utils.c: No longer include xxhash.h here, now that fast_hash
2838 is inlined in the header.
2839 * utils.h: Instead, include it here.
2840
ccb1ba62
CB
28412019-10-22 Christian Biesinger <cbiesinger@google.com>
2842
2843 * Makefile.in: Link with libxxhash.
2844 * config.in: Regenerate.
2845 * configure: Regenerate.
2846 * configure.ac: Search for libxxhash.
2847 * utils.c (fast_hash): Use xxhash if present.
2848
1a6ff1a9
CB
28492019-10-22 Christian Biesinger <cbiesinger@google.com>
2850
2851 * utils.h (fast_hash): New function.
2852 * symtab.c (hash_demangled_name_entry): Call new function
2853 fast_hash.
2854
7bb43059
CB
28552019-10-22 Christian Biesinger <cbiesinger@google.com>
2856
2857 * symtab.c (struct demangled_name_entry): Change type of mangled
2858 to gdb::string_view. Also adds a constructor that takes the
2859 mangled name.
2860 (hash_demangled_name_entry): Update.
2861 (eq_demangled_name_entry): Update.
2862 (free_demangled_name_entry): New function to call the destructor
2863 now that this is not a POD anymore.
2864 (create_demangled_names_hash): Pass free_demangled_name_entry to
2865 htab_create_alloc.
2866 (symbol_set_names): Update.
2867
7ba99d21
AT
28682019-10-21 Ali Tamur <tamu@google.com>
2869
2870 * dwarf2read.c (dir_index): Change type.
2871 (file_name_index): Likewise.
2872 (line_header::include_dir_at): Change comment and implementation on
2873 whether it is DWARF 5.
2874 (line_header::is_valid_file_index): New function.
2875 (line_header::file_name_at): Change comment and implementation on
2876 whether it is DWARF 5.
2877 (line_header::file_names): Change to private field renamed as
2878 m_file_names and introduce a new accessor method.
2879 (line_header::file_names_size): New method.
2880 (line_header::include_dirs): Change to private field and rename as
2881 m_include_dirs.
2882 (dw2_get_file_names_reader): Define local var at a smaller scope and
2883 reflect API change.
2884 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2885 (process_structure_scope): Likewise.
2886 (line_header::add_include_dir): Change message and reflect renaming.
2887 (line_header::add_file_name): Likewise.
2888 (read_formatted_entries): Handle DW_FORM_data16.
2889 (dwarf_decode_line_header): Fix line header length calculation.
2890 (psymtab_include_file_name): Change comment and API.
2891 (lnp_state_machine::m_file): Update comment and reflect type change.
2892 (lnp_state_machine::record_line): Reflect type change.
2893 (dwarf_decode_lines): Reflect API change.
2894 (file_file_name): Likewise.
2895 (file_full_name): Likewise.
2896
45f47c3a
AB
28972019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2898
2899 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2900
e5f3c0e3
TT
29012019-10-21 Tom Tromey <tom@tromey.com>
2902
2903 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2904
a0a461e5
TT
29052019-10-21 Tom Tromey <tom@tromey.com>
2906
2907 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2908 NM_H. Use AC_CONFIG_LINKS.
2909 * configure: Rebuild.
2910 * Makefile.in (NM_H): New variable.
2911 (generated_files): Add NM_H. Remove gcore.
2912 (nm.h, stamp-nmh): New targets.
2913
54d83b8d
TT
29142019-10-20 Tom Tromey <tom@tromey.com>
2915
2916 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2917 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2918 obsolete comment.
2919 (put_objfile_before): Now static.
2920
23771117
SM
29212019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2922
2923 * gdbsupport/common-utils.h (startswith): Change return type to
2924 bool.
2925
39ef2f62
CB
29262019-10-19 Christian Biesinger <cbiesinger@google.com>
2927
2928 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2929 * breakpoint.c (bp_locations_compare): Rename to...
2930 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2931 (update_global_location_list): Use std::sort instead of qsort.
2932 * buildsym.c (compare_line_numbers): Rename to...
2933 (lte_is_less_than): ...this, and change to std::sort semantics.
2934 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2935 instead of qsort.
2936 * disasm.c (compare_lines): Rename to...
2937 (line_is_less_than): ...this, and change to std::sort semantics.
2938 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2939 of qsort.
2940 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2941 (fde_is_less_than): ...this, and change to std::sort semantics.
2942 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2943 * mdebugread.c (compare_blocks):
2944 (block_is_less_than): ...this, and change to std::sort semantics.
2945 (sort_blocks): Call std::sort instead of qsort.
2946 * objfiles.c (qsort_cmp): Rename to...
2947 (sort_cmp): ...this, and change to std::sort semantics.
2948 (update_section_map): Call std::sort instead of qsort.
2949 * remote.c (compare_pnums): Remove.
2950 (map_regcache_remote_table): Call std::sort instead of qsort.
2951 * utils.c (compare_positive_ints): Remove.
2952 * utils.h (compare_positive_ints): Remove.
2953 * xcoffread.c (compare_lte): Remove.
2954 (arrange_linetable): Call std::sort instead of qsort.
2955
f71433ee
SDJ
29562019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2957
2958 * symfile.c (init_entry_point_info): Fix typo.
2959 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2960
85102364
TV
29612019-10-18 Tom de Vries <tdevries@suse.de>
2962
2963 * aarch64-tdep.c: Fix typos in comments.
2964 * ada-lang.c: Same.
2965 * ada-tasks.c: Same.
2966 * alpha-tdep.c: Same.
2967 * alpha-tdep.h: Same.
2968 * amd64-nat.c: Same.
2969 * amd64-windows-tdep.c: Same.
2970 * arc-tdep.c: Same.
2971 * arc-tdep.h: Same.
2972 * arch-utils.c: Same.
2973 * arm-nbsd-tdep.c: Same.
2974 * arm-tdep.c: Same.
2975 * ax-gdb.c: Same.
2976 * blockframe.c: Same.
2977 * btrace.c: Same.
2978 * c-varobj.c: Same.
2979 * coff-pe-read.c: Same.
2980 * coffread.c: Same.
2981 * cris-tdep.c: Same.
2982 * darwin-nat.c: Same.
2983 * dbxread.c: Same.
2984 * dcache.c: Same.
2985 * disasm.c: Same.
2986 * dtrace-probe.c: Same.
2987 * dwarf-index-write.c: Same.
2988 * dwarf2-frame-tailcall.c: Same.
2989 * dwarf2-frame.c: Same.
2990 * dwarf2read.c: Same.
2991 * eval.c: Same.
2992 * exceptions.c: Same.
2993 * fbsd-tdep.c: Same.
2994 * findvar.c: Same.
2995 * frame.c: Same.
2996 * frv-tdep.c: Same.
2997 * gnu-v3-abi.c: Same.
2998 * go32-nat.c: Same.
2999 * h8300-tdep.c: Same.
3000 * hppa-tdep.c: Same.
3001 * i386-linux-tdep.c: Same.
3002 * i386-tdep.c: Same.
3003 * ia64-libunwind-tdep.c: Same.
3004 * ia64-tdep.c: Same.
3005 * infcmd.c: Same.
3006 * infrun.c: Same.
3007 * linespec.c: Same.
3008 * linux-nat.c: Same.
3009 * linux-thread-db.c: Same.
3010 * machoread.c: Same.
3011 * mdebugread.c: Same.
3012 * mep-tdep.c: Same.
3013 * mn10300-tdep.c: Same.
3014 * namespace.c: Same.
3015 * objfiles.c: Same.
3016 * opencl-lang.c: Same.
3017 * or1k-tdep.c: Same.
3018 * osabi.c: Same.
3019 * ppc-linux-nat.c: Same.
3020 * ppc-linux-tdep.c: Same.
3021 * ppc-sysv-tdep.c: Same.
3022 * printcmd.c: Same.
3023 * procfs.c: Same.
3024 * record-btrace.c: Same.
3025 * record-full.c: Same.
3026 * remote-fileio.c: Same.
3027 * remote.c: Same.
3028 * rs6000-tdep.c: Same.
3029 * s12z-tdep.c: Same.
3030 * score-tdep.c: Same.
3031 * ser-base.c: Same.
3032 * ser-go32.c: Same.
3033 * skip.c: Same.
3034 * sol-thread.c: Same.
3035 * solib-svr4.c: Same.
3036 * solib.c: Same.
3037 * source.c: Same.
3038 * sparc-nat.c: Same.
3039 * sparc-sol2-tdep.c: Same.
3040 * sparc-tdep.c: Same.
3041 * sparc64-tdep.c: Same.
3042 * stabsread.c: Same.
3043 * stack.c: Same.
3044 * symfile.c: Same.
3045 * symtab.c: Same.
3046 * target-descriptions.c: Same.
3047 * target-float.c: Same.
3048 * thread.c: Same.
3049 * utils.c: Same.
3050 * valops.c: Same.
3051 * valprint.c: Same.
3052 * value.c: Same.
3053 * varobj.c: Same.
3054 * windows-nat.c: Same.
3055 * xcoffread.c: Same.
3056 * xstormy16-tdep.c: Same.
3057 * xtensa-tdep.c: Same.
3058
c5adaa19
TT
30592019-10-17 Tom Tromey <tromey@adacore.com>
3060
3061 * configure: Rebuild.
3062 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3063 in AC_CONFIG_FILES invocation.
3064 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3065 new-style config.status invocation.
3066
405feb71
TV
30672019-10-17 Tom de Vries <tdevries@suse.de>
3068
3069 * arm-nbsd-nat.c: Fix typos in comments.
3070 * arm-tdep.c: Same.
3071 * darwin-nat-info.c: Same.
3072 * dwarf2read.c: Same.
3073 * elfread.c: Same.
3074 * event-top.c: Same.
3075 * findvar.c: Same.
3076 * gdbtypes.c: Same.
3077 * hppa-tdep.c: Same.
3078 * i386-tdep.c: Same.
3079 * jit.c: Same.
3080 * main.c: Same.
3081 * mdebugread.c: Same.
3082 * moxie-tdep.c: Same.
3083 * nto-procfs.c: Same.
3084 * osabi.c: Same.
3085 * ppc-linux-tdep.c: Same.
3086 * remote.c: Same.
3087 * riscv-tdep.c: Same.
3088 * s390-tdep.c: Same.
3089 * sh-tdep.c: Same.
3090 * sparc-linux-tdep.c: Same.
3091 * sparc-nat.c: Same.
3092 * stack.c: Same.
3093 * target-descriptions.c: Same.
3094 * top.c: Same.
3095 * varobj.c: Same.
3096
befcd486
TT
30972019-10-16 Tom Tromey <tom@tromey.com>
3098
3099 * objfiles.h (struct objfile) <original_name>: Now const.
3100
17bfe554
CB
31012019-10-16 Christian Biesinger <cbiesinger@google.com>
3102
3103 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3104 pass on to sigsetjmp's second argument.
3105 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3106
950b7495
KS
31072019-10-16 Keith Seitz <keiths@redhat.com>
3108
3109 PR gdb/23567
3110 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3111 sections whose size is greater than the file size.
3112
ff371ec9
JW
31132019-10-16 Jim Wilson <jimw@sifive.com>
3114
3115 * riscv-tdep.c (riscv_gcc_target_options): New.
3116 (riscv_gnu_triplet_regexp): New.
3117 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3118 set_gdbarch_gnu_triplet_regexp.
3119
fec4e896
CB
31202019-10-16 Christian Biesinger <cbiesinger@google.com>
3121
3122 * Makefile.in: Add xml-builtin.h.
3123 * features/feature_to_c.sh: Add an include for xml-builtin.h
3124 to ensure that the compiler checks that the types match.
3125 * xml-builtin.h: New file.
3126 * xml-support.c (fetch_xml_builtin): Add missing const.
3127 * xml-support.h: Remove declaration of xml_builtins.
3128
d10eccaa
TV
31292019-10-16 Tom de Vries <tdevries@suse.de>
3130
3131 PR tdep/25096
3132 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3133 (amd64_classify_aggregate): ... here.
3134 (amd64_classify_aggregate_field): Handled fiels of nested structs
3135 recursively.
3136
745ff14e
TV
31372019-10-16 Tom de Vries <tdevries@suse.de>
3138
3139 PR tdep/24104
3140 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3141 that handles 'theclass'.
3142
791b7405
AB
31432019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3144
3145 * linespec.c (decode_digits_ordinary): Update comment.
3146 * make-target-delegates: No longer need to handle VEC case.
3147 * memrange.c (normalize_mem_ranges): Update comment.
3148 * namespace.c (add_using_directive): Update comment.
3149 * objc-lang.c (uniquify_strings): Update comment.
3150 * ppc-linux-nat.c (struct thread_points): Update comment.
3151 * probe.h (find_probes_in_objfile): Update comment.
3152 * target.h (enum flash_preserve_mode): Update comment.
3153 * varobj.c (varobj_restrict_range): Update comment.
3154 * varobj.h (varobj_list_children): Update comment.
3155
0dc32745
AB
31562019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3157
3158 * Makefile.in: Remove references to vec.h and vec.c.
3159 * aarch64-tdep.c: No longer include vec.h.
3160 * ada-lang.c: Likewise.
3161 * ada-lang.h: Likewise.
3162 * arm-tdep.c: Likewise.
3163 * ax.h: Likewise.
3164 * breakpoint.h: Likewise.
3165 * charset.c: Likewise.
3166 * cp-support.h: Likewise.
3167 * dtrace-probe.c: Likewise.
3168 * dwarf2read.c: Likewise.
3169 * extension.h: Likewise.
3170 * gdb_bfd.c: Likewise.
3171 * gdbsupport/gdb_vecs.h: Likewise.
3172 * gdbsupport/vec.c: Remove.
3173 * gdbsupport/vec.h: Remove.
3174 * gdbthread.h: Likewise.
3175 * guile/scm-type.c: Likewise.
3176 * inline-frame.c: Likewise.
3177 * machoread.c: Likewise.
3178 * memattr.c: Likewise.
3179 * memrange.h: Likewise.
3180 * namespace.h: Likewise.
3181 * nat/linux-btrace.h: Likewise.
3182 * osdata.c: Likewise.
3183 * parser-defs.h: Likewise.
3184 * progspace.h: Likewise.
3185 * python/py-type.c: Likewise.
3186 * record-btrace.c: Likewise.
3187 * rust-exp.y: Likewise.
3188 * solib-target.c: Likewise.
3189 * stap-probe.c: Likewise.
3190 * target-descriptions.c: Likewise.
3191 * target-memory.c: Likewise.
3192 * target.h: Likewise.
3193 * varobj.c: Likewise.
3194 * varobj.h: Likewise.
3195 * xml-support.h: Likewise.
3196
ae640021
AB
31972019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3198
3199 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3200 Update for new std::vector based implementation.
3201 (process_psymtab_comp_unit_reader): Likewise.
3202 (scan_partial_symbols): Likewise.
3203 (recursively_compute_inclusions): Likewise.
3204 (compute_compunit_symtab_includes): Likewise.
3205 (process_imported_unit_die): Likewise.
3206 (queue_and_load_dwo_tu): Likewise.
3207 (follow_die_sig_1): Likewise.
3208 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3209 (typedef dwarf2_per_cu_ptr): Remove.
3210 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3211 function.
3212 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3213 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3214 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3215 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3216 std::vector.
3217
55dfc88f
TT
32182019-10-15 Tom Tromey <tromey@adacore.com>
3219
3220 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3221 TID.
3222
96b49c5e
TT
32232019-10-15 Tom Tromey <tromey@adacore.com>
3224
3225 * windows-nat.c (windows_nat_target::fetch_registers)
3226 (windows_nat_target::store_registers): Rename "pid" to "tid".
3227
953cff56
TT
32282019-10-15 Tom Tromey <tromey@adacore.com>
3229
3230 * gdbarch.h, gdbarch.c: Rebuild.
3231 * gdbarch.sh (gcc_target_options): Change return type to
3232 std::string.
3233 * compile/compile.c (get_args): Update.
3234 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3235 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3236 std::string.
3237 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3238 std::string.
3239 * arch-utils.c (default_gcc_target_options): Return std::string.
3240 * arch-utils.h (default_gcc_target_options): Return std::string.
3241 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3242
81e6b8eb
CB
32432019-10-15 Christian Biesinger <cbiesinger@google.com>
3244
3245 * breakpoint.c (breakpoint_chain): Make static.
3246 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3247 of accessing breakpoint_chain.
3248
95da600f
CB
32492019-10-15 Christian Biesinger <cbiesinger@google.com>
3250
3251 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3252 to a gdb::function_view and return value to bool.
3253 * breakpoint.h (iterate_over_breakpoints): Likewise.
3254 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3255 (pop_dummy_frame): Update.
3256 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3257 (gdbscm_breakpoints): Update.
3258 * python/py-breakpoint.c (build_bp_list): Update.
3259 (gdbpy_breakpoints): Update.
3260 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3261 Update.
3262 (bpfinishpy_handle_stop): Update.
3263 (bpfinishpy_handle_exit): Update.
3264 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3265 (svr4_update_solib_event_breakpoints): Update.
3266
ba18312d
AA
32672019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3268
3269 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3270 when unwrapping single-field structs.
3271
6acc1a0b
SM
32722019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3273
3274 * dwarf2read.c: Remove includes.
3275
284782de
SM
32762019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3277
3278 * ui-out.c (ui_out::call_do_message): Silence
3279 -Wformat-nonliteral warning.
3280
073bbbb0
SM
32812019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3282
3283 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3284 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3285 include: readline/tilde.h.
3286
7b9a15e1
CB
32872019-10-12 Christian Biesinger <cbiesinger@google.com>
3288
3289 * remote.c (remote_target::get_trace_status): Remove declaration of
3290 trace_regblock_size.
3291
cc8dee1f
CB
32922019-10-12 Christian Biesinger <cbiesinger@google.com>
3293
3294 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3295 (show_user): Remove declaration of cmdlist.
3296 * cli/cli-cmds.h (max_user_call_depth): Declare.
3297 * cli/cli-script.c (execute_user_command): Remove declaration
3298 of max_user_call_depth.
3299
a83d4ef6
JW
33002019-10-11 Jim Wilson <jimw@sifive.com>
3301
5f93c5a6
JW
3302 * gdbsupport/print-utils.h (pulongest): Fix comment.
3303 (plongest): Likewise.
3304 (phex): Add missing comment, mention leading zeros.
3305 (phex_nz): Add mention of no leading zeros to comment.
3306
a83d4ef6
JW
3307 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3308 plongest instead of unsigned long long cast.
3309
26344e0c
CB
33102019-10-10 Christian Biesinger <cbiesinger@google.com>
3311
3312 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3313 for external_editor_command and gdbtk_test.
3314
c2c440a9
CB
33152019-10-10 Christian Biesinger <cbiesinger@google.com>
3316
3317 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3318 * varobj.c (varobjdebug): Move comment to...
3319 * varobj.h (varobjdebug): ...here, and declare.
3320
a31bff9d
TT
33212019-10-09 Tom Tromey <tom@tromey.com>
3322
3323 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3324 erase_data_content.
3325
7523da63
TT
33262019-10-09 Tom Tromey <tom@tromey.com>
3327
3328 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3329 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3330 * tui/tui-command.c (tui_cmd_window::resize)
3331 (tui_refresh_cmd_win): Update.
3332 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3333 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3334 * tui/tui-data.c (~tui_gen_win_info): Remove.
3335 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3336 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3337 (tui_redisplay_readline, tui_mld_flush)
3338 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3339 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3340 (tui_data_window::erase_data_content)
3341 (tui_data_item_window::rerender)
3342 (tui_data_item_window::refresh_window): Update.
3343 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3344 (box_win, tui_gen_win_info::make_window)
3345 (tui_gen_win_info::make_visible): Update.
3346 (tui_delete_win): Remove.
3347 * tui/tui-winsource.c
3348 (tui_source_window_base::do_erase_source_content): Update.
3349 (tui_show_source_line, tui_source_window_base::update_tab_width)
3350 (tui_source_window_base::update_exec_info): Update.
3351 * tui/tui-data.h (struct curses_deleter): New.
3352 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3353 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3354
a7798e7f
TT
33552019-10-09 Tom Tromey <tom@tromey.com>
3356
3357 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3358
5c45899e
TT
33592019-10-09 Tom Tromey <tom@tromey.com>
3360
3361 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3362 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3363
6d7fd9aa
TT
33642019-10-09 Tom Tromey <tom@tromey.com>
3365
3366 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3367 window height directly.
3368 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3369 declare.
3370 * tui/tui-layout.c (tui_default_win_height): Remove.
3371 (tui_default_win_viewport_height): Remove.
3372
d2dd1084
TT
33732019-10-09 Tom Tromey <tom@tromey.com>
3374
3375 * tui/tui.h: Remove comments.
3376
cff32449
TV
33772019-10-09 Tom de Vries <tdevries@suse.de>
3378
3379 * python/lib/gdb/printer/bound_registers.py: Use
3380 '^builtin_type_bound128' as regexp argument for
3381 add_builtin_pretty_printer.
3382
6a25e8a2
CB
33832019-10-09 Christian Biesinger <cbiesinger@google.com>
3384
3385 * guile/guile.c (guile_extension_script_ops): Remove forward
3386 declaration and mark as static.
3387 (guile_script_ops): Likewise.
3388 (extension_language_guile): Move further down in the file so
3389 it can reference the definitions for guile_{extension_,}script_ops.
3390
6d9d6da4
AA
33912019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3392
3393 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3394 except SORTL, DFLTCC, and KDSA.
3395
3abea05d
TT
33962019-10-08 Tom Tromey <tromey@adacore.com>
3397
3398 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3399 (struct safe_symbol_file_add_args): Remove.
3400
dde996e2
TT
34012019-10-08 Tom Tromey <tromey@adacore.com>
3402
3403 * windows-nat.c: Don't include buildsym-legacy.h.
3404
cd6fdaa1
TT
34052019-10-08 Tom Tromey <tromey@adacore.com>
3406
3407 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3408
79bb1944
CB
34092019-10-08 Christian Biesinger <cbiesinger@google.com>
3410
3411 * gdbtypes.c (overload_debug): Move comment to header.
3412 * gdbtypes.h (overload_debug): Declare.
3413 * valops.c: Remove declaration of overload_debug, instead
3414 include gdbtypes.h.
3415
34916edc
CB
34162019-10-08 Christian Biesinger <cbiesinger@google.com>
3417
3418 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3419 through _().
3420 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3421 move comment...
3422 * language.h (lang_frame_mismatch_warn): ... here. Also add
3423 declaration.
3424 * top.c (lang_frame_mismatch_warn): Remove declaration.
3425 (check_frame_language_change): Pass lang_frame_mismatch_warn
3426 through _().
3427
bad5c026
CB
34282019-10-07 Christian Biesinger <cbiesinger@google.com>
3429
3430 * c-lang.h (vtbl_ptr_name): Declare.
3431 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3432 it from the header.
3433 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3434
51f1fdc3
CB
34352019-10-07 Christian Biesinger <cbiesinger@google.com>
3436
3437 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3438 gdb_static_assert.
3439
30d1f018
WP
34402019-10-07 Weimin Pan <weimin.pan@oracle.com>
3441
606813d5
WP
3442 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3443 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3444 * ctfread.c: New file.
3445 * ctfread.h: New file.
3446 * elfread.c: Include ctfread.h.
3447 (struct elfinfo text_p): New member ctfsect.
3448 (elf_locate_sections): Mark CTF section.
3449 (elf_symfile_read): Call elfctf_build_psymtabs.
3450 * Makefile.in (LIBCTF): Add.
3451 (CLIBS): Use it.
3452 (CDEPS): Likewise.
3453 (DIST): Add ctfread.c.
606813d5
WP
3454
34552019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3456
3457 * ctfread.c (struct nextfield): Renamed to ...
3458 (struct ctf_nextfield): ... this.
3459 (struct field_info): Renamed to ...
3460 (strut ctf_field_info): ... this.
3461 (attach_fields_to_type): Update for renamed structures.
3462 (ctf_add_member_cb): Likewise.
3463 (ctf_add_enum_member_cb): Likewise.
3464 (process_struct_members): Likewise.
3465 (process_enum_type): Likewise.
30d1f018 3466
518fe38c
WP
34672019-10-07 Weimin Pan <weimin.pan@oracle.com>
3468
3469 * tracectf.h: Rename, was ctf.h.
3470 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3471 * tracefile.c: Likewise.
3472 * tracepoint.c: Remove unused include ctf.h.
3473 * mi/mi-main.c: Likewise.
3474 * Makefile.in Replace ctf.c with tracectf.c.
3475
225f296a
JB
34762019-10-06 Joel Brobecker <brobecker@adacore.com>
3477
3478 * version.in: Change version number to "9.0.50.DATE-git".
3479
77c2dba3
TT
34802019-10-03 Tom Tromey <tom@tromey.com>
3481
3482 PR rust/24976:
3483 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3484
179aed7f
AB
34852019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3486
3487 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3488 cp_search_name_hash.
3489 * NEWS: Add entry about nested function support.
3490
0a4b0913
AB
34912019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3492 Andrew Burgess <andrew.burgess@embecosm.com>
3493
3494 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3495 for nested static variables when searchin VAR_DOMAIN.
3496 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3497 global scope, update comment.
3498 (add_partial_subprogram): Call add_partial_subprogram recursively
3499 for nested subroutines when processinng Fortran.
3500 (load_partial_dies): Process the child entities of a subprogram
3501 when processing Fortran.
3502 (partial_die_parent_scope): Handle building scope
3503 for Fortran nested functions.
3504 (process_die): Record that nested functions have a scope.
3505 (new_symbol): Always record Fortran subprograms on the global
3506 symbol list.
3507 (determine_prefix): How to build the prefix for Fortran
3508 subprograms.
3509
d8c06f22
AB
35102019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3511
3512 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3513 have just sent the thread a SIGSTOP and are waiting for it to
3514 arrive.
3515
a8b3b8e9
AB
35162019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3517
3518 * btrace.c (btrace_add_pc): Remove whitespace before the template
3519 parameter in 'std::vector <...>'.
3520 (parse_xml_btrace_block): Likewise.
3521 (btrace_maint_decode_pt): Likewise.
3522 (btrace_maint_update_packets): Likewise.
3523 (btrace_maint_print_packets): Likewise.
3524 * btrace.h (struct btrace_maint_info): Likewise.
3525 * dwarf2read.c (struct type_unit_group): Likewise.
3526 (build_type_psymtabs_reader): Likewise.
3527 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3528 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3529 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3530
4d825eab
TV
35312019-10-03 Tom de Vries <tdevries@suse.de>
3532
3533 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3534 the first line of the help text for set/show style metadata.
3535
80fd2826
TT
35362019-10-02 Tom Tromey <tromey@adacore.com>
3537
3538 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3539 * gdbsupport/common-inferior.c: New file.
3540 * infcmd.c (startup_with_shell): Don't define.
3541 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3542 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3543 * inferior.h (startup_with_shell): Don't declare.
3544
70054538
CB
35452019-10-02 Christian Biesinger <cbiesinger@google.com>
3546
3547 * gdbsupport/gdb_assert.h: Include errors.h.
3548 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3549
37f6a7f4
TT
35502019-10-02 Tom Tromey <tromey@adacore.com>
3551
3552 * NEWS: Add $_ada_exception entry.
3553 * ada-lang.c (struct ada_catchpoint): Add constructor.
3554 <m_kind>: New member.
3555 (allocate_location_exception, re_set_exception): Remove
3556 "ex" parameter.
3557 (should_stop_exception): Compute $_ada_exception.
3558 (check_status_exception, print_it_exception)
3559 (print_one_exception, print_mention_exception): Remove
3560 "ex" parameter.
3561 (allocate_location_catch_exception, re_set_catch_exception)
3562 (check_status_exception, print_it_catch_exception)
3563 (print_one_catch_exception, print_mention_catch_exception)
3564 (print_recreate_catch_exception)
3565 (allocate_location_catch_exception_unhandled)
3566 (re_set_catch_exception_unhandled)
3567 (check_status_exception, print_it_catch_exception_unhandled)
3568 (print_one_catch_exception_unhandled)
3569 (print_mention_catch_exception_unhandled)
3570 (print_recreate_catch_exception_unhandled)
3571 (allocate_location_catch_assert, re_set_catch_assert)
3572 (check_status_assert, print_it_catch_assert)
3573 (print_one_catch_assert, print_mention_catch_assert)
3574 (print_recreate_catch_assert)
3575 (allocate_location_catch_handlers, re_set_catch_handlers)
3576 (check_status_handlers, print_it_catch_handlers)
3577 (print_one_catch_handlers, print_mention_catch_handlers)
3578 (print_recreate_catch_handlers): Remove.
3579 (create_ada_exception_catchpoint): Update.
3580 (initialize_ada_catchpoint_ops): Update.
3581
fccf9de1
TT
35822019-10-02 Tom Tromey <tromey@adacore.com>
3583
3584 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3585 (create_excep_cond_exprs): Simplify exception string computation.
3586 (ada_exception_catchpoint_cond_string): Likewise.
3587
4b610737
TT
35882019-10-02 Tom Tromey <tromey@adacore.com>
3589
3590 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3591 * ada-lang.c (lesseq_defined_than): Handle
3592 LOC_STATIC.
3593 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3594 parameter.
3595 (dwarf2_has_info): Likewise.
3596 (new_symbol): Set maybe_copied on symbol when
3597 appropriate.
3598 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3599 parameter.
3600 <can_copy>: New member.
3601 * elfread.c (record_minimal_symbol): Set maybe_copied
3602 on symbol when appropriate.
3603 (elf_symfile_read): Update call to dwarf2_has_info.
3604 * minsyms.c (lookup_minimal_symbol_linkage): New
3605 function.
3606 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3607 * symtab.c (get_symbol_address, get_msymbol_address):
3608 New functions.
3609 * symtab.h (get_symbol_address, get_msymbol_address):
3610 Declare.
3611 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3612 maybe_copied.
3613 (struct symbol, struct minimal_symbol) <maybe_copied>:
3614 New member.
3615
1dd58850
TT
36162019-10-02 Tom Tromey <tromey@adacore.com>
3617
3618 * source.c (struct current_source_location): New.
3619 (current_source_key): New global.
3620 (current_source_symtab, current_source_line)
3621 (current_source_pspace): Remove.
3622 (get_source_location): New function.
3623 (get_current_source_symtab_and_line)
3624 (set_default_source_symtab_and_line)
3625 (set_current_source_symtab_and_line)
3626 (clear_current_source_symtab_and_line, select_source_symtab)
3627 (info_source_command, print_source_lines_base)
3628 (info_line_command, search_command_helper, _initialize_source):
3629 Update.
3630
5c281dbb
TT
36312019-10-02 Tom Tromey <tromey@adacore.com>
3632
3633 * source.c (select_source_symtab): Don't call
3634 decode_line_with_current_source.
3635
d3d32391
AB
36362019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3637
3638 * symtab.c (lookup_global_symbol): Search global block.
3639
38583298
TT
36402019-10-02 Tom Tromey <tromey@adacore.com>
3641
3642 * coffread.c (process_coff_symbol): Update.
3643 * dwarf2read.c (var_decode_location, new_symbol): Update.
3644 * mdebugread.c (parse_symbol): Update.
3645 * objfiles.c (relocate_one_symbol): Update.
3646 * stabsread.c (define_symbol, fix_common_block)
3647 (scan_file_globals): Update.
3648 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3649 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3650 * xcoffread.c (process_xcoff_symbol): Update.
3651
9344c18f
AA
36522019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3653
3654 * MAINTAINERS: Update my email address.
3655
df07e2c7
AB
36562019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3657
3658 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3659 std::vector.
3660 (build_type_psymtabs_reader): Update for std::vector.
3661 (build_type_psymtab_dependencies): Likewise.
3662 * dwarf2read.h: Remove use of DEF_VEC_P.
3663 (typedef sig_type_ptr): Delete.
3664
554ac434
AB
36652019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3666
3667 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3668 to std::vector.
3669 (btrace_maint_decode_pt): Likewise, and move allocation of the
3670 vector outside of the loop.
3671 (btrace_maint_update_packets): Update to handle change from VEC to
3672 std::vector.
3673 (btrace_maint_print_packets): Likewise.
3674 (maint_info_btrace_cmd): Likewise.
3675 * btrace.h: Remove use of DEF_VEC_O.
3676 (typedef btrace_pt_packet_s): Delete.
3677 (struct btrace_maint_info) <packets>: Change fromm VEC to
3678 std::vector.
3679 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3680
46f29a9a
AB
36812019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3682
3683 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3684 make accesses into the vector constant references.
3685 (btrace_add_pc): Update for std::vector.
3686 (btrace_stitch_bts): Likewise.
3687 (parse_xml_btrace_block): Likewise.
3688 (btrace_maint_update_packets): Likewise.
3689 (btrace_maint_print_packets): Likewise.
3690 (maint_info_btrace_cmd): Likewise.
3691 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3692 std::vector.
3693 (btrace_data::empty): Likewise.
3694 (btrace_data_append): Likewise.
3695 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3696 (typedef btrace_block_s): Delete.
3697 (struct btrace_block): Add constructor.
3698 (struct btrace_data_bts) <blocks>: Change to std::vector.
3699 * nat/linux-btrace.c (perf_event_read_bts): Update for
3700 std::vector.
3701 (linux_read_bts): Likewise.
3702
d770d56f
TT
37032019-10-01 Tom Tromey <tom@tromey.com>
3704
3705 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3706
9d636d67
TT
37072019-10-01 Tom Tromey <tom@tromey.com>
3708
3709 * stack.c (print_frame, info_frame_command_core): Use
3710 styled_string.
3711 * linux-thread-db.c (try_thread_db_load_1)
3712 (try_thread_db_load_from_pdir_1): Use styled_string.
3713 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3714 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3715 (maybe_print_unsupported_script_warning)
3716 (maybe_print_script_not_found_warning): Use styled_string.
3717 * ada-lang.c (user_select_syms): Use styled_string.
3718
7f6aba03
TT
37192019-10-01 Tom Tromey <tom@tromey.com>
3720
3721 * p-lang.c (pascal_printstr): Use metadata style.
3722 * value.c (show_convenience): Use metadata style.
3723 * valprint.c (valprint_check_validity, val_print_optimized_out)
3724 (val_print_not_saved, val_print_unavailable)
3725 (val_print_invalid_address, generic_val_print, val_print)
3726 (value_check_printable, val_print_array_elements): Use metadata
3727 style.
3728 * ui-out.h (class ui_out) <field_fmt>: New overload.
3729 <do_field_fmt>: Add style parameter.
3730 * ui-out.c (ui_out::field_fmt): New overload.
3731 * typeprint.c (type_print_unknown_return_type)
3732 (val_print_not_allocated, val_print_not_associated): Use metadata
3733 style.
3734 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3735 parameter.
3736 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3737 * tracepoint.c (tvariables_info_1): Use metadata style.
3738 * stack.c (print_frame_arg, print_frame_info, print_frame)
3739 (info_frame_command_core): Use metadata style.
3740 * skip.c (info_skip_command): Use metadata style.
3741 * rust-lang.c (rust_print_enum): Use metadata style.
3742 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3743 metadata style.
3744 * python/py-framefilter.c (py_print_single_arg): Use metadata
3745 style.
3746 * printcmd.c (do_one_display, print_variable_and_value): Use
3747 metadata style.
3748 * p-valprint.c (pascal_val_print)
3749 (pascal_object_print_value_fields): Use metadata style.
3750 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3751 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3752 parameter.
3753 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3754 * m2-valprint.c (m2_print_long_set): Use metadata style.
3755 * m2-typeprint.c (m2_print_type): Use metadata style.
3756 * infcmd.c (print_return_value_1): Use metadata style.
3757 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3758 * f-valprint.c (info_common_command_for_block): Use metadata
3759 style.
3760 * f-typeprint.c (f_type_print_base): Use metadata style.
3761 * expprint.c (print_subexp_standard): Use metadata style.
3762 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3763 * cli/cli-style.h (class cli_style_option): Add constructor.
3764 (metadata_style): Declare.
3765 * cli/cli-style.c (metadata_style): New global.
3766 (_initialize_cli_style): Register metadata style.
3767 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3768 parameter.
3769 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3770 * c-typeprint.c (c_type_print_base_struct_union)
3771 (c_type_print_base_1): Use metadata style.
3772 * breakpoint.c (watchpoint_value_print)
3773 (print_one_breakpoint_location): Use metadata style.
3774 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3775 style.
3776 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3777 style.
3778 * ada-valprint.c (val_print_packed_array_elements, printstr)
3779 (print_field_values, ada_val_print_ref, ada_val_print): Use
3780 metadata style.
3781 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3782 style.
3783 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3784 style.
3785 * ada-lang.c (user_select_syms): Use metadata style.
3786
14309bb6
TT
37872019-10-01 Tom Tromey <tom@tromey.com>
3788
3789 * cli/cli-cmds.c (pwd_command): Style output.
3790
6a831f06
PA
37912019-10-01 Pedro Alves <palves@redhat.com>
3792 Tom Tromey <tom@tromey.com>
3793
3794 * symtab.c (print_symbol_info): Use %ps.
3795 (print_msymbol_info): Use %ps.
3796 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3797 * printcmd.c (print_variable_and_value): Use %ps.
3798 * macrocmd.c (show_pp_source_pos): Use %ps.
3799 * infrun.c (print_exited_reason): Use ui_out::message.
3800 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3801 (describe_other_breakpoints): Use ui_out::message and new
3802 formats.
3803 (say_where): Use new formats.
3804 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3805 and new formats.
3806
2a3c1174
PA
38072019-10-01 Pedro Alves <palves@redhat.com>
3808 Tom Tromey <tom@tromey.com>
3809
3810 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3811 (test_gdb_formats): New function.
3812 (run_tests): Call it.
3813 (test_format_specifier): Update.
3814 * utils.h (fputs_filtered): Update comment.
3815 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3816 (fputs_styled_unfiltered): Declare.
3817 * utils.c (fputs_styled_unfiltered): New function.
3818 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3819 (vfprintf_filtered): Update.
3820 (vfprintf_unfiltered, vprintf_filtered): Update.
3821 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3822 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3823 disallow_ui_out_field>: New constants.
3824 (enum class field_kind): New.
3825 (struct base_field_s, struct signed_field_s): New.
3826 (signed_field): New function.
3827 (struct string_field_s): New.
3828 (string_field): New function.
3829 (struct styled_string_s): New.
3830 (styled_string): New function.
3831 (class ui_out) <message>: Add comment.
3832 <vmessage, call_do_message>: New methods.
3833 <do_message>: Add style parameter.
3834 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3835 methods.
3836 (ui_out::message): Rewrite.
3837 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3838 parameter.
3839 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3840 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3841 gdb_extensions parameter.
3842 (class format_piece): Add parameter to constructor.
3843 (n_int_args): New field.
3844 * gdbsupport/format.c (format_pieces::format_pieces): Add
3845 gdb_extensions parameter. Handle '*'.
3846 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3847 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3848 vfprintf_styled_no_gdbfmt.
3849 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3850 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3851 unfiltered output.
3852 * ui-style.h (struct ui_file_style) <ptr>: New method.
3853
0dfe5bfb
TT
38542019-10-01 Tom Tromey <tom@tromey.com>
3855
3856 * unittests/format_pieces-selftests.c: Update. Add final format.
3857 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3858 empty literal pieces.
3859
e43b10e1
TT
38602019-10-01 Tom Tromey <tom@tromey.com>
3861
3862 * ui-out.h (enum class ui_out_style_kind): Remove.
3863 (class ui_out) <field_string, field_stsream, do_field_string>:
3864 Change type of "style".
3865 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3866 (ui_out::field_string): Update.
3867 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3868 of "style".
3869 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3870 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3871 * stack.c (print_frame_arg, print_frame_info, print_frame):
3872 Update.
3873 * source.c (print_source_lines_base): Update.
3874 * solib.c (info_sharedlibrary_command): Update.
3875 * skip.c (info_skip_command): Update.
3876 * record-btrace.c (btrace_call_history_src_line)
3877 (btrace_call_history): Update.
3878 * python/py-framefilter.c (py_print_frame): Update.
3879 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3880 "style".
3881 * mi/mi-out.c (mi_ui_out::do_table_header)
3882 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3883 (mi_ui_out::do_field_string): Update.
3884 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3885 Update.
3886 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3887 "style".
3888 * cli-out.c (cli_ui_out::do_table_header)
3889 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3890 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3891 (cli_ui_out::do_field_fmt): Update.
3892 * breakpoint.c (print_breakpoint_location): Update.
3893 (update_static_tracepoint): Update.
3894
cd7c32c3
PW
38952019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3896
3897 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3898 conversion of gdb_datadir.
3899 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3900 remove not needed c_str ().
3901
8fe0f950
AT
39022019-09-30 Ali Tamur <tamur@google.com>
3903
3904 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3905 (dwarf2_string_attr): Likewise.
3906
5f48f8f3
AT
39072019-09-30 Ali Tamur <tamur@google.com>
3908
3909 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3910 (process_full_type_unit): Likewise.
3911 (dump_die_shallow): Likewise.
3912 (cu_debug_loc_section): Likewise.
3913
6fb08628
CB
39142019-09-28 Christian Biesinger <cbiesinger@google.com>
3915
3916 * minsyms.c (compare_minimal_symbols): Rename to...
3917 (minimal_symbol_is_less_than): ...this, and adjust to STL
3918 conventions (return bool, take arguments as references)
3919 (minimal_symbol_reader::install): Call std::sort instead
3920 of qsort.
3921
c7ee338a
CB
39222019-09-29 Christian Biesinger <cbiesinger@google.com>
3923
3924 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3925 hash and why.
3926 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3927 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3928
703a86c2
SM
39292019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3930
3931 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3932 * psympriv.h (add_psymbol_to_list): Move comment here and update
3933 it.
3934
0df0352a
TV
39352019-09-29 Tom de Vries <tdevries@suse.de>
3936
3937 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3938 Use $tmpdir/$(basename "$output_file").dwz instead of
3939 "${output_file}.dwz".
3940
ad75efa6
SM
39412019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3942
3943 PR gdb/25045
3944 * hppa-linux-nat.c: Include gdbarch.h.
3945
ececd218
CB
39462019-09-26 Christian Biesinger <cbiesinger@google.com>
3947
3948 * blockframe.c (find_pc_partial_function): Change return type to bool.
3949 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3950 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3951 (stub_gnu_ifunc_resolve_name): Likewise.
3952 * symtab.c (compare_filenames_for_search): Likewise.
3953 (compare_glob_filenames_for_search): Likewise.
3954 (matching_obj_sections): Likewise.
3955 (symbol_matches_domain): Likewise.
3956 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3957 (find_line_pc): Change return type to bool.
3958 (find_line_pc_range): Likewise.
3959 (producer_is_realview): Likewise.
3960 * symtab.h (symbol_matches_domain): Likewise.
3961 (find_pc_partial_function): Likewise.
3962 (find_pc_line_pc_range): Likewise.
3963 (in_gnu_ifunc_stub): Likewise.
3964 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3965 (find_line_pc): Likewise.
3966 (find_line_pc_range): Likewise.
3967 (matching_obj_sections): Likewise.
3968 (find_line_symtab): Change out parameter to bool.
3969 (producer_is_realview): Change return type to bool.
3970 (compare_filenames_for_search): Likewise.
3971 (compare_glob_filenames_for_search): Likewise.
3972
27a900b8
TT
39732019-09-26 Tom Tromey <tom@tromey.com>
3974
3975 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3976 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3977 * gdb_usleep.h: Remove.
3978 * gdb_usleep.c: Remove.
3979 * utils.c: Don't include gdb_usleep.h.
3980
5d63b30a
TT
39812019-09-26 Tom Tromey <tromey@adacore.com>
3982
3983 * python/py-type.c (type_to_type_object): Call check_typedef
3984 for stub types.
3985
12904d37
TT
39862019-09-26 Tom Tromey <tom@tromey.com>
3987
3988 * utils.h (initialize_utils): Don't declare.
3989 * top.c (gdb_init): Don't call initialize_utils.
3990 * utils.c (initialize_utils): Remove. Move contents...
3991 (_initialize_utils): ... here.
3992
858f25f0
TT
39932019-09-25 Tom Tromey <tom@tromey.com>
3994
3995 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3996 * utils.h (make_hex_string): Don't declare.
3997 * utils.c (make_hex_string): Remove.
3998
3d435220
TV
39992019-09-24 Tom de Vries <tdevries@suse.de>
4000
4001 PR gdb/23815
4002 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4003 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4004
ddd44b70
DD
40052019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4006
4007 * NEWS: Mention new simulator port for PRU.
4008
f945dedf
CB
40092019-09-23 Christian Biesinger <cbiesinger@google.com>
4010
4011 * ada-exp.y (write_object_remaining): Update.
4012 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4013 and eliminate the static buffer.
4014 (ada_decode_symbol): Update.
4015 (ada_la_decode): Update.
4016 (ada_sniff_from_mangled_name): Update.
4017 (is_valid_name_for_wild_match): Update.
4018 (ada_lookup_name_info::matches): Update and simplify.
4019 (name_matches_regex): Update.
4020 (ada_add_global_exceptions): Update.
4021 * ada-lang.h (ada_decode): Update signature.
4022 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4023 * dwarf-index-write.c (debug_names::insert): Update.
4024
7ab78ccb
SM
40252019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4026
4027 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4028 formatting.
4029
9252448b
SM
40302019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4031
4032 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4033 Change "nonzero" to "true" in documentation.
4034
626ca2c0
CB
40352019-09-20 Christian Biesinger <cbiesinger@google.com>
4036
4037 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4038 (_initialize_darwin_solib): Don't set
4039 darwin_so_ops.lookup_lib_global_symbol.
4040 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4041 set_gdbarch_iterate_over_objfiles_in_search_order.
4042 (elf_lookup_lib_symbol): Rename to...
4043 (svr4_iterate_over_objfiles_in_search_order): this, and update
4044 to iterate semantics.
4045 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4046 * solib.c (solib_global_lookup): Remove.
4047 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4048 (solib_global_lookup): Remove.
4049 * symtab.c (lookup_global_or_static_symbol): Remove call to
4050 solib_global_lookup.
4051
5a3a0d63
JB
40522019-09-20 Joel Brobecker <brobecker@adacore.com>
4053
4054 * NEWS: Move entries about default MI version now being
4055 version 3, and about the GDB/MI fix for multi-location
4056 breakpoints to the "since GDB 8.3" section.
4057
ffea1427
JB
40582019-09-20 Joel Brobecker <brobecker@adacore.com>
4059
4060 GDB 8.3.1 released.
4061
abf516c6
UW
40622019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4063
4064 * NEWS: Mention that Cell/B.E. debugging support was removed.
4065 * MAINTAINERS: Remove spu target.
4066
4067 * config/djgpp/fnchange.lst: Remove entries for removed files.
4068
4069 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4070 spu-multiarch.o, and spu-tdep.o.
4071 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4072 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4073 spu-multiarch.c, and spu-tdep.c.
4074 * spu-linux-nat.c: Remove file.
4075 * spu-multiarch.c: Remove file.
4076 * spu-tdep.c: Remove file.
4077 * spu-tdep.h: Remove file.
4078 * solib-spu.c: Remove file.
4079 * solib-spu.h: Remove file.
4080
4081 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4082 * configure.nat (spu-linux): Remove.
4083 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4084 solib-multiarch.o from gdb_target_obs.
4085 (spu*-*-*): Remove.
4086
4087 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4088 feature flag.
4089 (ppc_linux_no_features): Update.
4090 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4091 Cell/B.E. support.
4092 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4093 (tdesc_powerpc_cell64l): Likewise.
4094 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4095 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4096 Cell/B.E. support.
4097 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4098 Do not include "features/rs6000/powerpc-cell32l.c" or
4099 "features/rs6000/powerpc-cell64l.c".
4100 (ppc_linux_spu_section): Remove.
4101 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4102 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4103 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4104 (ppc_linux_spe_context_lookup): Remove.
4105 (ppc_linux_spe_context_inferior_created): Remove.
4106 (ppc_linux_spe_context_solib_loaded): Remove.
4107 (ppc_linux_spe_context_solib_unloaded): Remove.
4108 (ppc_linux_spe_context): Remove.
4109 (struct ppu2spu_cache): Remove.
4110 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4111 (struct ppu2spu_data): Remove.
4112 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4113 ppu2spu_unwind): Remove.
4114 (ppc_linux_init_abi): Remove Cell/B.E. support.
4115 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4116
4117 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4118 (rs6000/powerpc-cell64l-expedite): Likewise
4119 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4120 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4121 rs6000/powerpc-cell64l.xml.
4122 * features/rs6000/powerpc-cell32l.xml: Remove.
4123 * features/rs6000/powerpc-cell64l.xml: Likewise.
4124 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4125 * features/rs6000/powerpc-cell64l.c: Likewise.
4126 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4127 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4128 * regformats/reg-spu.dat: Remove.
4129
4130 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4131 * corelow.c (struct spuid_list): Remove.
4132 (add_to_spuid_list): Remove.
4133 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4134 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4135 (remote_protocol_features): Remove associated entries.
4136 (_initialize_remote): No longer initialize them.
4137 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4138 * linux-nat.c (SPUFS_MAGIC): Remove.
4139 (linux_proc_xfer_spu): Remove.
4140 (spu_enumerate_spu_ids): Remove.
4141 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4142 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4143 (linux_make_corefile_notes): No longer call it.
4144
4145 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4146 (cooked_write_test): Likewise.
4147
78e8cb91
TT
41482019-09-20 Tom Tromey <tom@tromey.com>
4149
4150 * NEWS: Mention case-sensitivity of TUI commands.
4151 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4152 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4153 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4154
f074b67e
TT
41552019-09-20 Tom Tromey <tom@tromey.com>
4156
4157 * tui/tui-source.c (tui_source_window::set_contents): Use
4158 make_unique_xstrdup.
4159 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4160 make_unique_xstrdup.
4161
63c4bf19
TT
41622019-09-20 Tom Tromey <tom@tromey.com>
4163
4164 * tui/tui-data.c: Remove separator comments.
4165 * tui/tui-layout.c: Remove separator comments.
4166 * tui/tui-win.c: Remove separator comments.
4167 * tui/tui-wingeneral.c: Remove separator comments.
4168
43df9b2f
TT
41692019-09-20 Tom Tromey <tom@tromey.com>
4170
4171 * tui/tui.h (strcat_to_buf): Don't declare.
4172 * tui/tui.c (strcat_to_buf): Remove.
4173
7226433c
TT
41742019-09-20 Tom Tromey <tom@tromey.com>
4175
4176 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4177 from "fullname".
4178 * tui/tui-source.c (tui_source_window::set_contents)
4179 (tui_source_window::location_matches_p)
4180 (tui_source_window::maybe_update): Update.
4181
80df3337
TT
41822019-09-20 Tom Tromey <tom@tromey.com>
4183
4184 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4185 Update.
4186 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4187 prefix.
4188 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4189 (tui_data_window::line_from_reg_element_no)
4190 (tui_data_window::first_reg_element_no_inline)
4191 (tui_data_window::show_registers)
4192 (tui_data_window::show_register_group)
4193 (tui_data_window::display_registers_from)
4194 (tui_data_window::display_registers_from_line)
4195 (tui_data_window::first_data_item_displayed)
4196 (tui_data_window::delete_data_content_windows)
4197 (tui_data_window::erase_data_content)
4198 (tui_data_window::do_scroll_vertical)
4199 (tui_data_window::refresh_window)
4200 (tui_data_window::check_register_values): Update.
4201
9923f347
TT
42022019-09-20 Tom Tromey <tom@tromey.com>
4203
4204 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4205 (struct tui_locator_window) <full_name, proc_name>: Now
4206 std::string.
4207 * tui/tui-stack.c (tui_locator_window::make_status_line)
4208 (tui_locator_window::set_locator_fullname)
4209 (tui_locator_window::set_locator_info): Update.
4210 * tui/tui-source.c (tui_source_window::set_contents)
4211 (tui_source_window::showing_source_p): Update.
4212
b76251ab
TT
42132019-09-20 Tom Tromey <tom@tromey.com>
4214
4215 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4216 Don't call tui_locator_win_info_ptr.
4217
0891be08
TT
42182019-09-20 Tom Tromey <tom@tromey.com>
4219
4220 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4221
1b935acf
TT
42222019-09-20 Tom Tromey <tom@tromey.com>
4223
4224 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4225 height for locator.
4226 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4227 * tui/tui-layout.c (show_source_disasm_command, show_data)
4228 (show_source_or_disasm_and_command): Use 1 as height for locator.
4229
9abd8a65
TT
42302019-09-20 Tom Tromey <tom@tromey.com>
4231
4232 * tui/tui.c (tui_enable): Update.
4233 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4234 Update.
4235 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4236 Update.
4237 * tui/tui-data.c (win_resized): Now bool.
4238 (tui_win_resized): Return bool.
4239 (tui_set_win_resized_to): Accept a bool.
4240
b5457826
TT
42412019-09-20 Tom Tromey <tom@tromey.com>
4242
4243 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4244 Change type of "refresh_values_only".
4245 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4246 type of "refresh_values_only".
4247
6b915f7d
TT
42482019-09-20 Tom Tromey <tom@tromey.com>
4249
4250 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4251 std::string.
4252 (tui_disassemble): Add "pos" parameter.
4253 (tui_disasm_window::set_contents): Simplify.
4254
2ad52f6f
TT
42552019-09-20 Tom Tromey <tom@tromey.com>
4256
4257 * tui/tui-winsource.h (struct tui_source_window_base)
4258 <show_source_content>: Now private.
4259 * tui/tui-winsource.c
4260 (tui_source_window_base::show_source_content): Don't handle empty
4261 content case.
4262
b3b1bde6
TT
42632019-09-20 Tom Tromey <tom@tromey.com>
4264
4265 * tui/tui-layout.c (show_source_disasm_command)
4266 (show_source_or_disasm_and_command): Don't call
4267 show_source_content.
4268
71a25ed2
TT
42692019-09-20 Tom Tromey <tom@tromey.com>
4270
4271 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4272 Declare.
4273 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4274 from tui_make_status_line.
4275 (tui_locator_window::rerender): Update.
4276
f8532154
TT
42772019-09-20 Tom Tromey <tom@tromey.com>
4278
4279 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4280 (tui_locator_window::rerender): Update.
4281
2d81b349
TT
42822019-09-20 Tom Tromey <tom@tromey.com>
4283
4284 * tui/tui-winsource.h (struct tui_source_window_base)
4285 <~tui_source_window_base>: Don't declare.
4286 <fullname>: Remove.
4287 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4288 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4289 member.
4290 * tui/tui-source.c (tui_source_window::set_contents): Update.
4291 (tui_source_window::location_matches_p)
4292 (tui_source_window::maybe_update): Update.
4293
f14bec58
TT
42942019-09-20 Tom Tromey <tom@tromey.com>
4295
4296 * tui/tui-winsource.h (~tui_source_element): Remove.
4297 (tui_source_element): Update.
4298 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4299 * tui/tui-winsource.c (tui_show_source_line): Update.
4300 * tui/tui-source.c (tui_source_window::set_contents): Update.
4301 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4302
78d5933a
TT
43032019-09-20 Tom Tromey <tom@tromey.com>
4304
4305 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4306 declare.
4307 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4308 tui_clear_source_windows_detail.
4309 * tui/tui-winsource.h (struct tui_source_window_base)
4310 <clear_detail>: Don't declare.
4311 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4312 Remove.
4313 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4314
d4207696
TT
43152019-09-20 Tom Tromey <tromey@adacore.com>
4316
4317 PR ada/24919:
4318 * block.c (contained_in): Fix final return value.
4319
00f93c44
AM
43202019-09-20 Alan Modra <amodra@gmail.com>
4321
4322 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4323 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4324 (read_indirect_string_from_dwz): Use bfd accessor.
4325 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4326 * machoread.c (macho_symfile_read_all_oso): Likewise.
4327 * solib.c (solib_bfd_open): Likewise.
4328
e4153ae6
CB
43292019-09-19 Christian Biesinger <cbiesinger@google.com>
4330
4331 * eval.c: Move declaration of overload_resolution to...
4332 * value.h: ...here.
4333
c7ae7675
CB
43342019-09-19 Christian Biesinger <cbiesinger@google.com>
4335
4336 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4337 * arm-linux-tdep.c: Likewise.
4338 * arm-nbsd-nat.c: Likewise.
4339 * arm-tdep.h: Declare arm_apcs_32.
4340 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4341
e86f08d2
CB
43422019-09-19 Christian Biesinger <cbiesinger@google.com>
4343
4344 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4345 * dwarf2read.h: Declare dwarf_always_disassemble.
4346
f64e2f40
TV
43472019-09-19 Tom de Vries <tdevries@suse.de>
4348
4349 PR gdb/25009
4350 * source-cache.c (source_cache::ensure): Catch exception thrown during
4351 construction of the highlighter.
4352
fd361982
AM
43532019-09-18 Alan Modra <amodra@gmail.com>
4354
4355 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4356 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4357 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4358 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4359 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4360 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4361 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4362 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4363 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4364 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4365 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4366 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4367 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4368 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4369 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4370 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4371 * mi/mi-interp.c: Update throughout for bfd section macro and
4372 function changes.
4373 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4374 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4375
11061048
TT
43762019-09-18 Tom Tromey <tom@tromey.com>
4377
4378 * NEWS: Add entry.
4379 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4380 call rl_initialize.
4381 (tui_enable): Do not call rl_initialize.
4382
7a27b85f
CG
43832019-09-18 Christian Groessler <chris@groessler.org>
4384
4385 * alpha-linux-nat.c: Include gdbarch.h.
4386
f64eea3a
SM
43872019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4388
4389 * ui-file.c: Include cli/cli-style.h.
4390 (term_cli_styling): Remove cli_styling declaration.
4391
e6f7f6d1
AM
43922019-09-18 Alan Modra <amodra@gmail.com>
4393
4394 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4395 to bfd_asymbol_section.
4396
1d38e9d1
AM
43972019-09-18 Alan Modra <amodra@gmail.com>
4398
4399 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4400 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4401 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4402
90d92a63
AM
44032019-09-18 Alan Modra <amodra@gmail.com>
4404
4405 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4406 * spu-linux-nat.c (spu_bfd_open): Likewise.
4407
a3d181d2
CB
44082019-09-18 Christian Biesinger <cbiesinger@google.com>
4409
4410 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4411 to bool to match definition in dwarf2read.c.
4412
491144b5
CB
44132019-09-17 Christian Biesinger <cbiesinger@google.com>
4414
4415 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4416 (print_signatures): Likewise.
4417 (trust_pad_over_xvs): Likewise.
4418 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4419 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4420 * arm-linux-nat.c (arm_apcs_32): Likewise.
4421 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4422 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4423 * arm-tdep.c (arm_debug): Likewise.
4424 (arm_apcs_32): Likewise.
4425 * auto-load.c (debug_auto_load): Likewise.
4426 (auto_load_gdb_scripts): Likewise.
4427 (global_auto_load): Likewise.
4428 (auto_load_local_gdbinit): Likewise.
4429 (auto_load_local_gdbinit_loaded): Likewise.
4430 * auto-load.h (global_auto_load): Likewise.
4431 (auto_load_local_gdbinit): Likewise.
4432 (auto_load_local_gdbinit_loaded): Likewise.
4433 * breakpoint.c (disconnected_dprintf): Likewise.
4434 (breakpoint_proceeded): Likewise.
4435 (automatic_hardware_breakpoints): Likewise.
4436 (always_inserted_mode): Likewise.
4437 (target_exact_watchpoints): Likewise.
4438 (_initialize_breakpoint): Update.
4439 * breakpoint.h (target_exact_watchpoints): Change to bool.
4440 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4441 * cli/cli-cmds.c (trace_commands): Likewise.
4442 * cli/cli-cmds.h (trace_commands): Likewise.
4443 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4444 to bool*.
4445 * cli/cli-logging.c (logging_overwrite): Change to bool.
4446 (logging_redirect): Likewise.
4447 (debug_redirect): Likewise.
4448 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4449 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4450 to bool.
4451 <boolean_option_def>: Update.
4452 (struct flag_option_def): Change default type of Context to bool
4453 from int.
4454 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4455 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4456 (get_setshow_command_value_string): Likewise.
4457 * cli/cli-style.c (cli_styling): Change to bool.
4458 (source_styling): Likewise.
4459 * cli/cli-style.h (source_styling): Likewise.
4460 (cli_styling): Likewise.
4461 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4462 to bool.
4463 * command.h (var_types): Update comment.
4464 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4465 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4466 bool.
4467 (debug_compile_cplus_scopes): Likewise.
4468 * compile/compile-internal.h (compile_debug): Likewise.
4469 * compile/compile.c (compile_debug): Likewise.
4470 (struct compile_options) <raw>: Likewise.
4471 * cp-support.c (catch_demangler_crashes): Likewise.
4472 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4473 (usr_cmd_cris_dwarf2_cfi): Likewise.
4474 * csky-tdep.c (csky_debug): Likewise.
4475 * darwin-nat.c (enable_mach_exceptions): Likewise.
4476 * dcache.c (dcache_enabled_p): Likewise.
4477 * defs.h (info_verbose): Likewise.
4478 * demangle.c (demangle): Likewise.
4479 (asm_demangle): Likewise.
4480 * dwarf-index-cache.c (debug_index_cache): Likewise.
4481 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4482 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4483 * dwarf2read.c (check_physname): Likewise.
4484 (use_deprecated_index_sections): Likewise.
4485 (dwarf_always_disassemble): Likewise.
4486 * eval.c (overload_resolution): Likewise.
4487 * event-top.c (set_editing_cmd_var): Likewise.
4488 (exec_done_display_p): Likewise.
4489 * event-top.h (set_editing_cmd_var): Likewise.
4490 (exec_done_display_p): Likewise.
4491 * exec.c (write_files): Likewise.
4492 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4493 (debug_fbsd_nat): Likewise.
4494 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4495 Likewise.
4496 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4497 <backtrace_past_entry> Likewise.
4498 * gdb-demangle.h (demangle): Likewise.
4499 (asm_demangle): Likewise.
4500 * gdb_bfd.c (bfd_sharing): Likewise.
4501 * gdbcore.h (write_files): Likewise.
4502 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4503 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4504 * gdbthread.h (print_thread_events): Likewise.
4505 * gdbtypes.c (opaque_type_resolution): Likewise.
4506 (strict_type_checking): Likewise.
4507 * gnu-nat.c (gnu_debug_flag): Likewise.
4508 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4509 * guile/scm-param.c (pascm_variable): Add boolval.
4510 (add_setshow_generic): Update.
4511 (pascm_param_value): Update.
4512 (pascm_set_param_value_x): Update.
4513 * hppa-tdep.c (hppa_debug): Change to bool..
4514 * infcall.c (may_call_functions_p): Likewise.
4515 (coerce_float_to_double_p): Likewise.
4516 (unwind_on_signal_p): Likewise.
4517 (unwind_on_terminating_exception_p): Likewise.
4518 * infcmd.c (startup_with_shell): Likewise.
4519 * inferior.c (print_inferior_events): Likewise.
4520 * inferior.h (startup_with_shell): Likewise.
4521 (print_inferior_events): Likewise.
4522 * infrun.c (step_stop_if_no_debug): Likewise.
4523 (detach_fork): Likewise.
4524 (debug_displaced): Likewise.
4525 (disable_randomization): Likewise.
4526 (non_stop): Likewise.
4527 (non_stop_1): Likewise.
4528 (observer_mode): Likewise.
4529 (observer_mode_1): Likewise.
4530 (set_observer_mode): Update.
4531 (sched_multi): Change to bool.
4532 * infrun.h (debug_displaced): Likewise.
4533 (sched_multi): Likewise.
4534 (step_stop_if_no_debug): Likewise.
4535 (non_stop): Likewise.
4536 (disable_randomization): Likewise.
4537 * linux-tdep.c (use_coredump_filter): Likewise.
4538 (dump_excluded_mappings): Likewise.
4539 * linux-thread-db.c (auto_load_thread_db): Likewise.
4540 (check_thread_db_on_load): Likewise.
4541 * main.c (captured_main_1): Update.
4542 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4543 xx2_opt, boolean_opt>: Change to bool.
4544 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4545 * maint.c (maintenance_profile_p): Likewise.
4546 (per_command_time): Likewise.
4547 (per_command_space): Likewise.
4548 (per_command_symtab): Likewise.
4549 * memattr.c (inaccessible_by_default): Likewise.
4550 * mi/mi-main.c (mi_async): Likewise.
4551 (mi_async_1): Likewise.
4552 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4553 * nat/fork-inferior.h (startup_with_shell): Likewise.
4554 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4555 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4556 * nios2-tdep.c (nios2_debug): Likewise.
4557 * or1k-tdep.c (or1k_debug): Likewise.
4558 * parse.c (parser_debug): Likewise.
4559 * parser-defs.h (parser_debug): Likewise.
4560 * printcmd.c (print_symbol_filename): Likewise.
4561 * proc-api.c (procfs_trace): Likewise.
4562 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4563 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4564 (set_parameter_value): Update.
4565 (add_setshow_generic): Update.
4566 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4567 to bool*.
4568 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4569 int*.
4570 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4571 * record-btrace.c (record_btrace_target::store_registers): Update.
4572 * record-full.c (record_full_memory_query): Change to bool.
4573 (record_full_stop_at_limit): Likewise.
4574 * record-full.h (record_full_memory_query): Likewise.
4575 * remote-notif.c (notif_debug): Likewise.
4576 * remote-notif.h (notif_debug): Likewise.
4577 * remote.c (use_range_stepping): Likewise.
4578 (interrupt_on_connect): Likewise.
4579 (remote_break): Likewise.
4580 * ser-tcp.c (tcp_auto_retry): Likewise.
4581 * ser-unix.c (serial_hwflow): Likewise.
4582 * skip.c (debug_skip): Likewise.
4583 * solib-aix.c (solib_aix_debug): Likewise.
4584 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4585 (spu_auto_flush_cache_p): Likewise.
4586 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4587 Likewise.
4588 (struct info_print_options) <quiet>: Likewise.
4589 * symfile-debug.c (debug_symfile): Likewise.
4590 * symfile.c (auto_solib_add): Likewise.
4591 (separate_debug_file_debug): Likewise.
4592 * symfile.h (auto_solib_add): Likewise.
4593 (separate_debug_file_debug): Likewise.
4594 * symtab.c (basenames_may_differ): Likewise.
4595 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4596 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4597 (struct info_types_options) <quiet>: Likewise.
4598 * symtab.h (demangle): Likewise.
4599 (basenames_may_differ): Likewise.
4600 * target-dcache.c (stack_cache_enabled_1): Likewise.
4601 (code_cache_enabled_1): Likewise.
4602 * target.c (trust_readonly): Likewise.
4603 (may_write_registers): Likewise.
4604 (may_write_memory): Likewise.
4605 (may_insert_breakpoints): Likewise.
4606 (may_insert_tracepoints): Likewise.
4607 (may_insert_fast_tracepoints): Likewise.
4608 (may_stop): Likewise.
4609 (auto_connect_native_target): Likewise.
4610 (target_stop_and_wait): Update.
4611 (target_async_permitted): Change to bool.
4612 (target_async_permitted_1): Likewise.
4613 (may_write_registers_1): Likewise.
4614 (may_write_memory_1): Likewise.
4615 (may_insert_breakpoints_1): Likewise.
4616 (may_insert_tracepoints_1): Likewise.
4617 (may_insert_fast_tracepoints_1): Likewise.
4618 (may_stop_1): Likewise.
4619 * target.h (target_async_permitted): Likewise.
4620 (may_write_registers): Likewise.
4621 (may_write_memory): Likewise.
4622 (may_insert_breakpoints): Likewise.
4623 (may_insert_tracepoints): Likewise.
4624 (may_insert_fast_tracepoints): Likewise.
4625 (may_stop): Likewise.
4626 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4627 (make_thread_apply_all_options_def_group): Change argument from int*
4628 to bool*.
4629 (thread_apply_all_command): Update.
4630 (print_thread_events): Change to bool.
4631 * top.c (confirm): Likewise.
4632 (command_editing_p): Likewise.
4633 (history_expansion_p): Likewise.
4634 (write_history_p): Likewise.
4635 (info_verbose): Likewise.
4636 * top.h (confirm): Likewise.
4637 (history_expansion_p): Likewise.
4638 * tracepoint.c (disconnected_tracing): Likewise.
4639 (circular_trace_buffer): Likewise.
4640 * typeprint.c (print_methods): Likewise.
4641 (print_typedefs): Likewise.
4642 * utils.c (debug_timestamp): Likewise.
4643 (sevenbit_strings): Likewise.
4644 (pagination_enabled): Likewise.
4645 * utils.h (sevenbit_strings): Likewise.
4646 (pagination_enabled): Likewise.
4647 * valops.c (overload_resolution): Likewise.
4648 * valprint.h (struct value_print_options) <prettyformat_arrays,
4649 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4650 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4651 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4652 Likewise.
4653 * windows-nat.c (new_console): Likewise.
4654 (cygwin_exceptions): Likewise.
4655 (new_group): Likewise.
4656 (debug_exec): Likewise.
4657 (debug_events): Likewise.
4658 (debug_memory): Likewise.
4659 (debug_exceptions): Likewise.
4660 (useshell): Likewise.
4661 * windows-tdep.c (maint_display_all_tib): Likewise.
4662 * xml-support.c (debug_xml): Likewise.
4663
f1b620e9
MG
46642019-09-17 Mike Gulick <mgulick@mathworks.com>
4665
4666 * source.c (prepare_path_for_appending): New function.
4667 (openp): Make use of new function.
4668 (find_and_open_source): Search for the compilation directory and
4669 source file as a relative path beneath the directory search path.
4670
67f3ed6a
AB
46712019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4672
4673 * source-cache.c (source_cache::get_line_charpos): Catch
4674 exceptions and return false, this matches the behaviour documented
4675 in the header file.
4676
74332189
JB
46772019-09-17 Joel Brobecker <brobecker@adacore.com>
4678
4679 * ada-tasks.c (info_task): Remove quoting of the task's name.
4680
f2f24aa9
CB
46812019-09-16 Christian Biesinger <cbiesinger@google.com>
4682
4683 * symfile.c (auto_solib_add): Replace comment with a reference
4684 to the header file.
4685
6a062a93
CB
46862019-09-14 Christian Biesinger <cbiesinger@google.com>
4687
4688 * NEWS: Mention that gdb can now be compiled with Python 3
4689 on Windows.
4690
ec6c8338
AB
46912019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4692
4693 * maint.c (maint_print_section_data::maint_print_section_data):
4694 Force use of 'float log10 (float)' by casting the argument to
4695 float.
4696
aa17805f
AB
46972019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4698
4699 * maint.c: Add 'cmath' include.
4700 (struct maint_print_section_data): New structure.
4701 (print_section_index): New function.
4702 (print_bfd_section_info): Add header comment, small whitespace
4703 cleanup, and update to call new print_section_index function.
4704 (print_objfile_section_info): Likewise.
4705 (maint_obj_section_from_bfd_section): New function.
4706 (print_bfd_section_info_maybe_relocated): New function.
4707 (maintenance_info_sections): Add header comment, always use
4708 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4709
3dd9bb46
AB
47102019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4711
4712 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4713 inner scope, add check that the objfile has psymtabs before
4714 checking psymtabs_addrmap.
4715 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4716
4993045d
PW
47172019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4718
4719 * NEWS: Announce that Ada task names are now shown at more places,
4720 and between quotes (except in info task output).
4721 * gdb/ada-tasks.c (task_to_str): New function.
4722 (display_current_task_id): Call task_to_str.
4723 (task_command_1): Likewise.
4724 (print_ada_task_info): In non-mi mode, Properly align headers and data
4725 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4726
7a289707
RO
47272019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4728
4729 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4730 prstatus.pr_lwp.pr_info instead of making it up.
4731
f2aec7f6
CB
47322019-09-11 Christian Biesinger <cbiesinger@google.com>
4733
4734 * auto-load.c (auto_load_expand_dir_vars): Update.
4735 * defs.h (gdb_datadir): Change to std::string.
4736 (python_libdir): Likewise.
4737 (relocate_gdb_directory): Change return type to std::string.
4738 * guile/guile.c (gdbscm_data_directory): Update.
4739 (initialize_scheme_side): Update.
4740 * jit.c (jit_reader_dir): Change to std::string.
4741 (jit_reader_load_command): Update.
4742 * main.c (gdb_datadir): Change to std::string.
4743 (python_libdir): Likewise.
4744 (set_gdb_data_directory): Update.
4745 (relocate_path): Change to return std::string.
4746 (relocate_gdb_directory): Change to return std::string.
4747 (relocate_gdbinit_path_maybe_in_datadir): Update.
4748 (captured_main_1): Update.
4749 * python/python.c (do_start_initialization): Update.
4750 * top.c (show_gdb_datadir): Update.
4751 * xml-syscall.c (xml_init_syscalls_info): Update.
4752 (init_syscalls_info): Update.
4753
9224a013
CB
47542019-09-11 Christian Biesinger <cbiesinger@google.com>
4755
4756 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4757 out of get_init_files.
4758 (get_init_files): Update.
4759
f48cd836
CB
47602019-09-11 Christian Biesinger <cbiesinger@google.com>
4761
4762 * main.c (get_init_files): Change to use std::string.
4763 (captured_main_1): Update.
4764 (print_gdb_help): Update.
4765
9cab7ecd
AT
47662019-09-11 Ali Tamur <tamur@google.com>
4767
4768 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4769 implementation.
4770
67547d89
CB
47712019-09-11 Christian Biesinger <cbiesinger@google.com>
4772
4773 * dbxread.c (read_dbx_symtab): Update.
4774 * dwarf2read.c (load_partial_dies): Update.
4775 * mdebugread.c (parse_partial_symbols): Update.
4776 (handle_psymbol_enumerators): Update.
4777 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4778 * psymtab.c (add_psymbol_to_bcache): Likewise.
4779 (add_psymbol_to_list): Likewise.
4780 * symtab.c (symbol_set_names): Likewise.
4781 * symtab.h (symbol_set_names): Likewise.
4782 * xcoffread.c (scan_xcoff_symtab): Update.
4783
64b2d4a0
TT
47842019-09-11 Tom Tromey <tom@tromey.com>
4785
4786 * symfile-mem.c (symbol_file_add_from_memory): Use
4787 bfd_set_filename.
4788 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4789 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4790
3b00ef10
TT
47912019-09-10 Tom Tromey <tromey@adacore.com>
4792
4793 * dwarf-index-write.c (write_psymbols): Extend error message.
4794 (debug_names::insert): Add Ada code.
4795 (debug_names::write_psymbols): Remove Ada check.
4796 (debug_names) <m_string_obstack>: New member.
4797 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4798 (gdb_index_symbol_name_matcher::matches): Remove.
4799 (mapped_index_base::find_name_components_bounds): Add "lang"
4800 parameter.
4801 (mapped_index_base::build_name_components): Also split names
4802 according to Ada syntax.
4803 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4804 type of "match_callback".
4805 (check_match, check_find_bounds_finds)
4806 (dw2_expand_symtabs_matching): Update.
4807 (dw2_debug_names_iterator): Add new constructor.
4808 (dw2_debug_names_map_matching_symbols): New function.
4809 (dw2_debug_names_expand_symtabs_matching): Update.
4810 (dwarf2_debug_names_functions): Use
4811 dw2_debug_names_map_matching_symbols.
4812
aa391654
TT
48132019-09-10 Tom Tromey <tromey@adacore.com>
4814
4815 * dwarf2read.c (dw2_get_file_names_reader): Add the
4816 CU's file name to the results.
4817
b054970d
TT
48182019-09-10 Tom Tromey <tromey@adacore.com>
4819
4820 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4821 map_matching_symbols. Update.
4822 * dwarf2read.c (dw2_map_matching_symbols): Update.
4823 * psymtab.c (match_partial_symbol): Change type; update.
4824 (psym_map_matching_symbols): Likewise.
4825 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4826 type; update.
4827 * symfile.h (struct quick_symbol_functions)
4828 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4829 Remove "match".
4830
6a3dbf1b
TT
48312019-09-10 Tom Tromey <tromey@adacore.com>
4832
4833 * psymtab.c (map_block): Remove.
4834 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4835 * symtab.c (iterate_over_symbols_terminated): New function.
4836 * symtab.c (iterate_over_symbols_terminated): Declare.
4837
6969f124
TT
48382019-09-10 Tom Tromey <tromey@adacore.com>
4839
4840 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4841 * language.h (struct language_defn) <la_iterate_over_symbols>:
4842 Return bool.
4843 * symtab.c (iterate_over_symbols): Return bool.
4844 * symtab.h (iterate_over_symbols): Return bool.
4845
199b4314
TT
48462019-09-10 Tom Tromey <tromey@adacore.com>
4847
4848 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4849 (add_nonlocal_symbols): Update.
4850 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4851 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4852 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4853 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4854 Change type of "callback". Remove "data".
4855
a084a2a6
AT
4856
48572019-09-09 Ali Tamur <tamur@google.com>
4858
4859 * dwarf2read.c (comp_unit_head): Update comment.
4860 (dwarf2_dwo_name): New function declaration.
4861 (dwarf_unit_type_name): New function declaration.
4862 (read_comp_unit_head): Add support for new compilation units,
4863 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4864 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4865 (currently named as "signature") in their header. Also clarify error
4866 messages.
4867 (lookup_dwo_id): New function. Returns the dwo id of the given
4868 compile unit.
4869 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4870 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4871 functions.
4872 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4873 (dwarf2_dwo_name): Get the dwo name if present.
4874 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4875 purposes.
4876
25a2915e
TT
48772019-09-09 Tom Tromey <tom@tromey.com>
4878
4879 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4880
e4df0874
PW
48812019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4882
4883 * python/python.c (do_start_initialization): Make progname_copy static,
4884 to avoid a leak report.
4885
8634b462
TT
48862019-09-08 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4889
c7f839cb
SM
48902019-09-07 Simon Marchi <simon.marchi@efficios.com>
4891
4892 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4893 Change type to gdb::optional<block_enum>.
4894 (dw2_symtab_iter_init): Change block_index parameter type
4895 to gdb::optional<block_enum>.
4896 (dw2_lookup_symbol): Change block_index parameter
4897 type to block_enum.c
4898 (dw2_debug_names_lookup_symbol): Likewise.
4899 * psymtab.c (psym_lookup_symbol): Likewise.
4900 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4901 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4902 Likewise.
4903
ead0e69a
CB
49042019-09-06 Christian Biesinger <cbiesinger@google.com>
4905
4906 * defs.h (relocate_gdb_directory): Change int to bool in
4907 signature and rename flag to relocatable.
4908 * main.c (relocate_path): Likewise.
4909 (relocate_gdb_directory): Likewise.
4910
b16c44de
AM
49112019-09-06 Alan Modra <amodra@gmail.com>
4912
4913 * coffread.c (coff_symfile_read): Constify filename variable.
4914 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4915 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4916 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4917 * solib.c (reload_shared_libraries_1): Likewise.
4918 * symfile.c (reread_symbols): Likewise.
4919 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4920 * solib-darwin.c (darwin_bfd_open): Likewise.
4921 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4922
06ff036e
AB
49232019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4924
4925 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4926 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4927
4e962e74
TT
49282019-09-03 Tom Tromey <tromey@adacore.com>
4929
4930 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4931 types.
4932 (has_negatives): Unbias a range type bound.
4933 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4934 * gdbtypes.c (operator==): Handle new field.
4935 (create_range_type): Add "bias" parameter.
4936 (create_static_range_type, resolve_dynamic_range): Update.
4937 * gdbtypes.h (struct range_bounds) <bias>: New member.
4938 (create_range_type): Add bias parameter.
4939 * printcmd.c (print_scalar_formatted): Unbias range types.
4940 * value.c (unpack_long): Unbias range types.
4941 (pack_long): Bias range types.
4942
d90b8f26
AH
49432019-09-02 Alan Hayward <alan.hayward@arm.com>
4944
4945 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4946 probe arguments.
4947
fe01123e
AH
49482019-09-02 Alan Hayward <alan.hayward@arm.com>
4949
4950 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4951 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4952 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4953 (compile_probe_arg): Likewise.
4954 * probe.h (get_argument_count): Likewise.
4955 * solib-svr4.c (solib_event_probe_action): Likewise.
4956 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4957
e661ef01
AH
49582019-09-02 Alan Hayward <alan.hayward@arm.com>
4959
4960 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4961 code to here...
4962 (svr4_create_solib_event_breakpoints): ...from here.
4963
47a536d9
SDJ
49642019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4965
4966 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4967 suffix from warning message.
4968
d6a00eba
TT
49692019-08-30 Tom Tromey <tom@tromey.com>
4970
4971 * tui/tui-winsource.h (struct tui_source_window_base)
4972 <refresh_all>: Don't declare.
4973 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4974 Remove.
4975 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4976 tui_show_locator_content.
4977 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4978 declare.
4979 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4980 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4981 declare.
4982
55b2657b
TT
49832019-08-30 Tom Tromey <tom@tromey.com>
4984
4985 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4986
12a8555a
TT
49872019-08-30 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4990 Remove unnecessary forward declarations.
4991
900ac242
TT
49922019-08-30 Tom Tromey <tom@tromey.com>
4993
4994 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4995 rerender.
4996 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4997 tui_show_locator_content.
4998
99ab33fb
TT
49992019-08-30 Tom Tromey <tom@tromey.com>
5000
5001 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5002 (tui_locator_window::rerender): Rewrite using body of previous
5003 tui_show_locator_content.
5004
e594a5d1
TT
50052019-08-30 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5008 set_locator_fullname>: New methods.
5009 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5010 Rename from tui_set_locator_fullname.
5011 (tui_locator_window::set_locator_info): Rename from
5012 tui_set_locator_info. Return bool.
5013 (tui_update_locator_fullname, tui_show_frame_info): Update.
5014
715bb467
TT
50152019-08-30 Tom Tromey <tom@tromey.com>
5016
5017 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5018
772f3f03
TT
50192019-08-30 Tom Tromey <tom@tromey.com>
5020
5021 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5022 call touchwin.
5023
108e13ab
TT
50242019-08-30 Tom Tromey <tom@tromey.com>
5025
5026 * tui/tui-wingeneral.c (box_win): Assume win_info and
5027 win_info->handle cannot be NULL.
5028
cdaa6eb4
TT
50292019-08-30 Tom Tromey <tom@tromey.com>
5030
5031 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5032 refresh_window>: Declare.
5033 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5034 resize.
5035 (tui_data_item_window::rerender): Rename from
5036 tui_display_register.
5037 (tui_data_item_window::refresh_window): New method.
5038 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5039 no-op.
5040
89df7f90
TT
50412019-08-30 Tom Tromey <tom@tromey.com>
5042
5043 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5044 regs_column_count, current_group>: Move later. Now private.
5045 <get_current_group>: New method.
5046 * tui/tui-regs.c (tui_reg_command): Update.
5047 * tui/tui-layout.c (tui_set_layout): Update.
5048
1bf2866a
TT
50492019-08-30 Tom Tromey <tom@tromey.com>
5050
5051 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5052 (tui_data_window::rerender): Don't call
5053 check_and_display_highlight_if_needed.
5054 (tui_data_window::refresh_all): Remove call to
5055 erase_data_content.
5056
0670413d
TT
50572019-08-30 Tom Tromey <tom@tromey.com>
5058
5059 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5060 (tui_data_window::display_registers_from)
5061 (tui_data_window::display_reg_element_at_line)
5062 (tui_data_window::display_registers_from_line): Remove checks of
5063 "empty".
5064
18bb55c7
TT
50652019-08-30 Tom Tromey <tom@tromey.com>
5066
5067 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5068 Don't declare.
5069 * tui/tui-regs.c (tui_data_window::show_registers): Call
5070 rerender.
5071 (tui_data_window::rerender): Rename from display_all_data.
5072 (tui_data_window::rerender): Remove old implementation.
5073
1f6d2f10
TT
50742019-08-30 Tom Tromey <tom@tromey.com>
5075
5076 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5077 text.
5078 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5079
16d01f9c
BW
50802019-08-29 Bernhard Wodok <barto@gmx.net>
5081 Sergio Durigan Junior <sergiodj@redhat.com>
5082
5083 PR win32/24284
5084 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5085
d8f27c60
AB
50862019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5087
5088 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5089 when searching for types.
5090
1f20c35e
AB
50912019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5092
5093 * f-lang.c (f_language_defn): Use f_print_typedef.
5094 * f-lang.h (f_print_typedef): Declare.
5095 * f-typeprint.c (f_print_typedef): Define.
5096
550105b7
CB
50972019-08-27 Christian Biesinger <cbiesinger@google.com>
5098
5099 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5100
4acfdd20
AB
51012019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5102
5103 * cli/cli-utils.c (info_print_options_defs): Delete.
5104 (make_info_print_options_def_group): Delete.
5105 (extract_info_print_options): Delete.
5106 (info_print_command_completer): Delete.
5107 (info_print_args_help): Add extra parameter, and optionally
5108 include text about -n flag.
5109 * cli/cli-utils.h (struct info_print_options): Delete.
5110 (extract_info_print_options): Delete declaration.
5111 (info_print_command_completer): Delete declaration.
5112 (info_print_args_help): Add extra parameter, extend header
5113 comment.
5114 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5115 search_symbols.
5116 * stack.c (struct info_print_options): New type.
5117 (info_print_options_defs): New file scoped variable.
5118 (make_info_print_options_def_group): New static function.
5119 (info_print_command_completer): New static function.
5120 (info_locals_command): Update to use new local functions.
5121 (info_args_command): Likewise.
5122 (_initialize_stack): Add extra parameter to calls to
5123 info_print_args_help.
5124 * symtab.c (search_symbols): Add extra parameter, use this to
5125 possibly excluse non-debug symbols.
5126 (symtab_symbol_info): Add extra parameter, which is passed on to
5127 search_symbols.
5128 (struct info_print_options): New type.
5129 (info_print_options_defs): New file scoped variable.
5130 (make_info_print_options_def_group): New static function.
5131 (info_print_command_completer): New static function.
5132 (info_variables_command): Update to use local functions, and pass
5133 extra parameter through to symtab_symbol_info.
5134 (info_functions_command): Likewise.
5135 (info_types_command): Pass additional argument through to
5136 symtab_symbol_info.
5137 (rbreak_command): Pass extra argument to search_symbols.
5138 (_initialize_symtab): Add extra arguments for calls to
5139 info_print_args_help, and update help text for 'info variables',
5140 'whereis', and 'info functions' commands.
5141 * symtab.h (search_symbols): Add extra argument to declaration.
5142 * NEWS: Mention new flags.
5143
9aa55206
CB
51442019-08-26 Christian Biesinger <cbiesinger@google.com>
5145
5146 * symtab.c (lookup_static_symbol): Call the new function (and move
5147 it down to be next to lookup_global_symbol).
5148 (struct global_sym_lookup_data): Add block_enum member and rename to...
5149 (struct global_or_static_sym_lookup_data): ...this.
5150 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5151 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5152 (lookup_symbol_global_or_static_iterator_cb): ...this.
5153 (lookup_global_or_static_symbol): New function.
5154 (lookup_global_symbol): Call new function.
5155
5c31b358
TV
51562019-08-26 Tom de Vries <tdevries@suse.de>
5157
5158 PR c++/24852
5159 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5160 when pc_probe.prob == NULL.
5161
23c13d42
SM
51622019-08-25 Simon Marchi <simon.marchi@efficios.com>
5163
5164 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5165 variable symbol_linkage to symbol_linkage_.
5166
beadd3e8
SM
51672019-08-25 Simon Marchi <simon.marchi@efficios.com>
5168
5169 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5170 represent whether the symbol is static, dynamic, or we don't
5171 know.
5172
e3ec872f
YS
51732019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5174
5175 * gdb/rx-tdep.c (rx_register_names): New.
5176 (rx_register_name): Delete.
5177 (rx_psw_type): Delete.
5178 (rx_fpsw_type): Delete.
5179 (rx_register_type): Delete.
5180 (rx_gdbarch_init): Convert target-descriptions.
5181 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5182 * gdb/features/Makefile: Add rx.xml.
5183 * gdb/features/rx.xml: New.
5184 * gdb/features/rx.c: Generated.
5185 * gdb/NEWS: Mention target description support.
5186
d0509ba4
CB
51872019-08-22 Christian Biesinger <cbiesinger@google.com>
5188
5189 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5190 *slot_ptr.
5191
2d41fa11
SDJ
51922019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5193
5194 * configure.ac: Don't check for 'dlfcn.h' (moved to
5195 gdbsupport/common.m4).
5196 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5197 'gdbsupport/'.
5198 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5199 * compile/compile-c-support.c: Include
5200 'gdbsupport/gdb-dlfcn.h'.
5201 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5202 * gdb-dlfcn.c: Move to...
5203 * gdbsupport/gdb-dlfcn.c: ... here.
5204 * gdb-dlfcn.h: Move to...
5205 * gdbsupport/gdb-dlfcn.h: ... here.
5206
de8af808
SL
52072019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5208
5209 * nios2-tdep.c (struct reg_value): Improve comments. Make
5210 the offset field signed.
5211
27204489
CB
52122019-08-22 Christian Biesinger <cbiesinger@google.com>
5213
5214 * python/lib/gdb/__init__.py (_execute_file): New function.
5215 * python/python.c (python_run_simple_file): Call gdb._execute_file
5216 on Windows.
5217
43771869
AB
52182019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5219
5220 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5221 all uses as this was never set to anything but a zero value.
5222
26c957f1
PA
52232019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5224
5225 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5226
c07aae6e
CB
52272019-08-21 Christian Biesinger <cbiesinger@google.com>
5228
5229 * tui/tui-data.h (tui_gen_win_info): Add an =default
5230 move constructor, required by some GCC versions.
5231
3960cb7a
JF
52322019-08-21 Jinke Fan <fanjinke51@yeah.net>
5233
5234 * go32-nat.c (go32_sysinfo): Add hygon_p.
5235
04c72a68
TT
52362019-08-20 Tom Tromey <tom@tromey.com>
5237
5238 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5239 line_from_reg_element_no, first_reg_element_no_inline,
5240 display_all_data, delete_data_content_windows,
5241 erase_data_content>: Now private.
5242
072272ce
TT
52432019-08-20 Tom Tromey <tom@tromey.com>
5244
5245 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5246 (tui_unhighlight_win, tui_highlight_win)
5247 (tui_win_info::make_window): Update.
5248 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5249
973961bd
TT
52502019-08-20 Tom Tromey <tom@tromey.com>
5251
5252 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5253 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5254 (MAX_PID_WIDTH): Move to tui-stack.c.
5255 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5256 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5257 (MAX_PID_WIDTH): Move from tui-data.h.
5258
ab0e1f1a
TT
52592019-08-20 Tom Tromey <tom@tromey.com>
5260
5261 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5262 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5263 (box_win): Update.
5264 (tui_gen_win_info::make_window): Rename from tui_make_window.
5265 (tui_win_info::make_window): New method.
5266 (tui_gen_win_info::make_visible): Update.
5267 * tui/tui-source.c (tui_source_window::set_contents): Update.
5268 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5269 (tui_data_window::display_registers_from): Update.
5270 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5271 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5272 Declare.
5273 <can_box>: Remove.
5274 <title>: Remove.
5275 (struct tui_win_info) <make_window>: Declare.
5276 <can_box>: Now virtual.
5277 <title>: New member.
5278 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5279 * tui/tui-command.c (tui_cmd_window::resize): Update.
5280
100c2bf3
TT
52812019-08-20 Tom Tromey <tom@tromey.com>
5282
5283 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5284 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5285 (tui_data_window::check_register_values): Update.
5286
fa4dc567
TT
52872019-08-20 Tom Tromey <tom@tromey.com>
5288
5289 * tui/tui-regs.h (struct tui_data_window): Use
5290 DISABLE_COPY_AND_ASSIGN.
5291 <regs_content>: Change type, removing unique_ptr.
5292 <tui_data_window>: Add move constructor.
5293 * tui/tui-regs.c (tui_data_window::show_registers)
5294 (tui_data_window::show_register_group)
5295 (tui_data_window::display_registers_from)
5296 (tui_data_window::display_registers_from)
5297 (tui_data_window::first_data_item_displayed)
5298 (tui_data_window::delete_data_content_windows)
5299 (tui_data_window::rerender, tui_data_window::refresh_window)
5300 (tui_data_window::check_register_values): Update.
5301
ca02d7c8
TT
53022019-08-20 Tom Tromey <tom@tromey.com>
5303
5304 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5305 show_register_group>: Declare.
5306 (tui_show_register_group): Don't declare.
5307 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5308 tui_show_registers.
5309 (tui_data_window::show_register_group): Rename from
5310 tui_show_register_group.
5311 (tui_data_window::check_register_values, tui_reg_command):
5312 Update.
5313 * tui/tui-layout.c (tui_set_layout): Update.
5314
63356bfd
TT
53152019-08-20 Tom Tromey <tom@tromey.com>
5316
5317 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5318 Declare.
5319 (tui_check_register_values): Don't declare.
5320 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5321 from tui_check_register_values.
5322 * tui/tui-hooks.c (tui_register_changed): Update.
5323
42cc14a7
TT
53242019-08-20 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-regs.c (tui_reg_layout): Move later.
5327 (tui_show_registers): Don't enable TUI mode or change layout.
5328
b9ad3686
TT
53292019-08-20 Tom Tromey <tom@tromey.com>
5330
5331 * tui/tui-regs.h (struct tui_data_item_window)
5332 <~tui_data_item_window>: Remove.
5333 <content>: Now a unique_xmalloc_ptr.
5334 * tui/tui-regs.c (tui_register_format): Return a
5335 unique_xmalloc_ptr.
5336 (tui_get_register): Update.
5337 (~tui_data_item_window): Remove.
5338 (tui_data_window::display_registers_from, tui_display_register):
5339 Update.
5340 * tui/tui-io.h (tui_expand_tabs): Update.
5341 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5342 Remove "col" parameter.
5343
8e114aab
TT
53442019-08-20 Tom Tromey <tom@tromey.com>
5345
5346 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5347 field.
5348 * tui/tui-regs.c (~tui_data_item_window): Update.
5349
1a4f81dd
TT
53502019-08-20 Tom Tromey <tom@tromey.com>
5351
5352 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5353 earlier.
5354
0f8d8876
TT
53552019-08-20 Tom Tromey <tom@tromey.com>
5356
5357 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5358
605dc2c2
TT
53592019-08-20 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-source.h (struct tui_source_window): Update.
5362 * tui/tui-regs.c (tui_show_registers): Update.
5363 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5364 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5365 (NO_REGS_STRING): Remove defines.
5366
aedbe3bb
CM
53672019-08-20 Conrad Meyer <cem@FreeBSD.org>
5368
5369 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5370 unnecessary thread walk if remote doesn't support the packet.
5371
7ce8f214
TT
53722019-08-19 Tom Tromey <tromey@adacore.com>
5373
5374 * python/py-value.c (value_has_field): Fix indentation.
5375
f21c2bd7
TT
53762019-08-19 Tom Tromey <tromey@adacore.com>
5377
5378 * printcmd.c (do_one_display, info_display_command): Update.
5379 * block.h (contained_in): Return bool. Add allow_nested
5380 parameter.
5381 * block.c (contained_in): Return bool. Add allow_nested
5382 parameter.
5383
d806ea2d
TT
53842019-08-19 Tom Tromey <tom@tromey.com>
5385
5386 * configure: Rebuild.
5387 * configure.ac: Disallow the combination of -static-libstdc++ and
5388 source highlight.
5389 * source-cache.c (get_language_name): Handle rust.
5390 (source_cache::get_source_lines): Ignore highlighting exceptions.
5391
398fdd60
TT
53922019-08-16 Tom Tromey <tom@tromey.com>
5393
5394 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5395 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5396 (struct tui_source_window_base) <make_visible, refresh_window,
5397 resize>: Remove methods.
5398 <execution_info>: Remove field.
5399 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5400 (tui_show_source_line, tui_source_window_base)
5401 (~tui_source_window_base): Update.
5402 (tui_source_window_base::resize)
5403 (tui_source_window_base::make_visible)
5404 (tui_source_window_base::refresh_window): Remove.
5405 (tui_source_window_base::update_exec_info): Update.
5406 * tui/tui-source.c (tui_source_window::set_contents): Update.
5407 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5408
e699d331
TT
54092019-08-16 Tom Tromey <tom@tromey.com>
5410
5411 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5412 deprecated_query_hook.
5413
bb01dbfc
TT
54142019-08-16 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5417 (tui_update_source_windows_with_line): Update.
5418 * tui/tui-source.h (struct tui_source_window)
5419 <show_symtab_source>: Declare.
5420 (tui_show_symtab_source): Don't declare.
5421 * tui/tui-source.c (tui_show_symtab_source): Rename from
5422 tui_show_symtab_source.
5423
81c82c4b
TT
54242019-08-16 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-winsource.h (struct tui_source_window_base)
5427 <set_contents>: Declare.
5428 * tui/tui-winsource.c
5429 (tui_source_window_base::update_source_window_as_is): Update.
5430 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5431 Declare.
5432 (tui_set_source_content): Don't declare.
5433 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5434 tui_set_source_content.
5435 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5436 Declare.
5437 (tui_set_disassem_content): Don't declare.
5438 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5439 tui_set_disassem_content.
5440
2ddaf614
TT
54412019-08-16 Tom Tromey <tom@tromey.com>
5442
5443 * tui/tui-winsource.h (struct tui_source_window_base)
5444 <update_breakpoint_info>: Declare.
5445 (tui_update_breakpoint_info): Don't declare.
5446 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5447 (tui_update_all_breakpoint_info): Update.
5448 (tui_source_window_base::update_breakpoint_info): Rename from
5449 tui_update_breakpoint_info.
5450 (tui_source_window_base::update_exec_info): Update.
5451
017f9828
TT
54522019-08-16 Tom Tromey <tom@tromey.com>
5453
5454 * tui/tui-winsource.h (struct tui_source_window_base)
5455 <update_source_window>: Declare.
5456 (tui_update_source_window): Don't declare.
5457 * tui/tui-winsource.c
5458 (tui_source_window_base::update_source_window): Rename from
5459 tui_update_source_window.
5460 (tui_source_window_base::rerender): Update.
5461 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5462 * tui/tui-disasm.c (tui_show_disassem)
5463 (tui_show_disassem_and_update_source)
5464 (tui_disasm_window::maybe_update): Update.
5465
ed8358e9
TT
54662019-08-16 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-winsource.h (struct tui_source_window_base)
5469 <update_source_window_as_is>: Declare.
5470 (tui_update_source_window_as_is): Don't declare.
5471 * tui/tui-winsource.c (tui_update_source_window): Update
5472 (tui_source_window_base::update_source_window_as_is): Rename from
5473 tui_update_source_window_as_is.
5474 (tui_source_window_base::refill): Update.
5475 * tui/tui-source.c (tui_show_symtab_source): Update.
5476 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5477 Update.
5478
20149b6b
TT
54792019-08-16 Tom Tromey <tom@tromey.com>
5480
5481 * tui/tui-winsource.h (tui_update_source_window)
5482 (tui_update_source_window_as_is): Remove "noerror" parameter.
5483 * tui/tui-winsource.c (tui_update_source_window)
5484 (tui_update_source_window_as_is): Remove "noerror" parameter.
5485 (tui_update_source_windows_with_addr)
5486 (tui_update_source_windows_with_line)
5487 (tui_source_window_base::rerender)
5488 (tui_source_window_base::refill): Update.
5489 * tui/tui-source.h (tui_set_source_content)
5490 (tui_show_symtab_source): Remove "noerror" parameter.
5491 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5492 parameter.
5493 (tui_show_symtab_source): Likewise.
5494 (tui_source_window::maybe_update): Update.
5495 * tui/tui-disasm.c (tui_show_disassem)
5496 (tui_show_disassem_and_update_source)
5497 (tui_disasm_window::do_scroll_vertical)
5498 (tui_disasm_window::maybe_update): Update.
5499
2d83e710
TT
55002019-08-16 Tom Tromey <tom@tromey.com>
5501
5502 * tui/tui.c (tui_is_window_visible): Update.
5503 * tui/tui-wingeneral.c (tui_make_window)
5504 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5505 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5506 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5507 (tui_set_win_height_command, parse_scrolling_args): Update.
5508 * tui/tui-source.c (tui_source_window::style_changed): Update.
5509 * tui/tui-regs.c (tui_show_registers)
5510 (tui_data_window::first_data_item_displayed)
5511 (tui_data_window::delete_data_content_windows)
5512 (tui_check_register_values, tui_reg_command): Update.
5513 * tui/tui-disasm.c (tui_show_disassem): Update.
5514 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5515 method.
5516 <is_visible>: Remove field.
5517 * tui/tui-data.c (tui_next_win, tui_prev_win)
5518 (tui_delete_invisible_windows): Update.
5519
d4ab829a
TT
55202019-08-16 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui-winsource.h (struct tui_source_window_base)
5523 <m_has_locator>: Remove.
5524 * tui/tui-layout.c (show_source_disasm_command, show_data)
5525 (show_source_or_disasm_and_command): Update.
5526
aa7ca1bb
AH
55272019-08-16 Alan Hayward <alan.hayward@arm.com>
5528
5529 * NEWS (Other MI changes): New subsection.
5530 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5531 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5532 * arch-utils.c (default_get_pc_address_flags): New function.
5533 * arch-utils.h (default_get_pc_address_flags): New declaration.
5534 * gdbarch.sh: Add get_pc_address_flags.
5535 * gdbarch.c: Regenerate.
5536 * gdbarch.h: Likewise.
5537 * stack.c (print_pc): New function.
5538 (print_frame_info) (print_frame): Call print_pc.
5539
6eac171f
TV
55402019-08-16 Tom de Vries <tdevries@suse.de>
5541
5542 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5543 print_objfile_section_info.
5544
3df505f6
TT
55452019-08-15 Tom Tromey <tom@tromey.com>
5546
5547 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5548 calling update_cmdwin_start_line.
5549 * tui/tui-winsource.h (struct tui_source_window_base)
5550 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5551 <rerender>: Declare.
5552 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5553 Call rerender.
5554 (tui_source_window_base::set_new_height): Remove.
5555 (tui_source_window_base::rerender): Rename from
5556 do_make_visible_with_new_height.
5557 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5558 resize method.
5559 (tui_win_info::make_invisible_and_set_new_height)
5560 (tui_win_info::make_visible_with_new_height): Remove.
5561 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5562 Declare.
5563 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5564 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5565 do_make_visible_with_new_height>: Don't declare.
5566 <rerender>: Declare.
5567 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5568 set_new_height.
5569 (tui_data_window::do_make_visible_with_new_height): Remove.
5570 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5571 call tui_show_locator_content.
5572 (tui_gen_win_info::resize): Call rerender.
5573 (show_source_or_disasm_and_command): Don't call
5574 tui_show_locator_content.
5575 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5576 method.
5577 (struct tui_win_info) <rerender>: Declare.
5578 <set_new_height, make_invisible_and_set_new_height,
5579 make_visible_with_new_height>: Don't declare.
5580 * tui/tui-data.c (tui_win_list::rerender): New method.
5581 * tui/tui-command.h (struct tui_cmd_window)
5582 <do_make_visible_with_new_height>: Don't declare.
5583 * tui/tui-command.c
5584 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5585
272560b5
TT
55862019-08-15 Tom Tromey <tromey@adacore.com>
5587
5588 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5589 * ada-lang.c (ada_enum_name): Likewise.
5590
08235187
CB
55912019-08-15 Christian Biesinger <cbiesinger@google.com>
5592
5593 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5594 leading underscore.
5595 (GdbOutputErrorFile): Likewise.
5596 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5597 accordingly.
5598 (execute_unwinders): Rename to have a leading underscore.
5599 (auto_load_packages): Likewise.
5600 (global scope): Adjust call to auto_load_packages accordingly.
5601 (GdbSetPythonDirectory): Likewise.
5602 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5603 instead of execute_unwinders.
5604
db502012
TT
56052019-08-15 Tom Tromey <tom@tromey.com>
5606
5607 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5608 (show_data): Don't change window visibility.
5609 (tui_gen_win_info::resize): Remove special case for command
5610 window. Use wresize, when available.
5611 (show_source_or_disasm_and_command): Don't change window
5612 visibility.
5613 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5614 <make_visible>: New method.
5615 * tui/tui-command.c (tui_cmd_window::resize): New method.
5616
3891b65e
TT
56172019-08-15 Tom Tromey <tom@tromey.com>
5618
5619 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5620 (struct tui_source_windows): New.
5621 * tui/tui-winsource.c (tui_display_main): Update.
5622 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5623 (new_height_ok, parse_scrolling_args): Update.
5624 * tui/tui-layout.c (show_layout, show_data): Update.
5625 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5626 (tui_add_to_source_windows): Don't declare.
5627 * tui/tui-data.c (source_windows, tui_source_windows)
5628 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5629
ee556432
TT
56302019-08-15 Tom Tromey <tom@tromey.com>
5631
5632 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5633 Rename from reset.
5634 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5635 * tui/tui-layout.c (show_source_disasm_command, show_data):
5636 Update.
5637 (tui_gen_win_info::resize): Rename.
5638 (show_source_or_disasm_and_command): Update.
5639 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5640 reset.
5641
46f438e3
TT
56422019-08-15 Tom Tromey <tom@tromey.com>
5643
5644 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5645 * tui/tui-interp.c (tui_interp::init): Don't call
5646 tui_initialize_static_data.
5647 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5648
f4ce562c
TT
56492019-08-15 Tom Tromey <tom@tromey.com>
5650
5651 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5652 examine tui_win_list.
5653
c398c3d0
TT
56542019-08-15 Tom Tromey <tom@tromey.com>
5655
5656 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5657 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5658 tui_clear_source_content.
5659 (tui_clear_source_content): Remove.
5660 (tui_source_window_base::do_erase_source_content): Hoist call to
5661 content.clear().
5662 * tui/tui-stack.c (tui_show_frame_info): Don't call
5663 tui_clear_source_content.
5664
e25d2004
TT
56652019-08-15 Tom Tromey <tom@tromey.com>
5666
5667 * tui/tui-winsource.h (struct tui_source_window_base)
5668 <do_erase_source_content>: New method.
5669 <erase_source_content>: New method.
5670 (tui_erase_source_content): Don't declare.
5671 * tui/tui-winsource.c (tui_clear_source_content): Update.
5672 (tui_source_window_base::do_erase_source_content): Rename from
5673 tui_erase_source_content.
5674 (tui_source_window_base::show_source_content): Update.
5675 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5676 * tui/tui-source.h (struct tui_source_window)
5677 <erase_source_content>: New method.
5678 * tui/tui-disasm.h (struct tui_disasm_window)
5679 <erase_source_content>: New method.
5680
002f15c2
TT
56812019-08-15 Tom Tromey <tom@tromey.com>
5682
5683 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5684 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5685 constructor.
5686 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5687 * tui/tui-source.c (tui_set_source_content): Update.
5688 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5689
c9033fe8
TT
56902019-08-15 Tom Tromey <tom@tromey.com>
5691
5692 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5693 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5694 tui-source.c.
5695 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5696 Declare.
5697 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5698 method.
5699 (tui_source_window::maybe_update): Update.
5700
088f37dd
TT
57012019-08-15 Tom Tromey <tom@tromey.com>
5702
5703 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5704 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5705 tui-disasm.c.
5706 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5707 Declare.
5708 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5709 method.
5710 (tui_disasm_window::maybe_update): Update.
5711
a54700c6
TT
57122019-08-15 Tom Tromey <tom@tromey.com>
5713
5714 * tui/tui-winsource.h (struct tui_source_window_base)
5715 <maybe_update>: Declare.
5716 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5717 method.
5718 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5719 Declare.
5720 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5721 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5722 Declare.
5723 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5724
e2a678a5
TT
57252019-08-15 Tom Tromey <tom@tromey.com>
5726
5727 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5728
f2dda477
TT
57292019-08-15 Tom Tromey <tom@tromey.com>
5730
5731 * tui/tui-wingeneral.c: Include tui-stack.h.
5732 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5733 (struct tui_locator_window): Move from tui-data.h.
5734 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5735 (tui_initialize_static_data): Move from tui-data.c.
5736 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5737 (struct tui_locator_window): Move to tui-stack.c.
5738 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5739 (tui_initialize_static_data): Move to tui-stack.c.
5740
ed4a1084
TT
57412019-08-15 Tom Tromey <tom@tromey.com>
5742
5743 * tui/tui-layout.c (show_source_disasm_command)
5744 (show_source_or_disasm_and_command): Use make_visible method, not
5745 tui_make_window.
5746 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5747 Remove.
5748
65962b20
TT
57492019-08-15 Tom Tromey <tom@tromey.com>
5750
5751 * tui/tui-wingeneral.h (tui_make_window): Update.
5752 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5753 parameter.
5754 (tui_gen_win_info::make_visible): Update.
5755 * tui/tui-regs.c (tui_data_window::display_registers_from):
5756 Update.
5757 * tui/tui-layout.c (show_source_disasm_command)
5758 (show_source_or_disasm_and_command): Update.
5759 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5760 (enum tui_box): Remove.
5761 (struct tui_win_info) <can_box>: New method.
5762 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5763 method.
5764
2208ee91
TV
57652019-08-15 Tom de Vries <tdevries@suse.de>
5766
5767 * linux-nat-trad.c: Include gdbarch.h.
5768
75faf5c4
AH
57692019-08-14 Alan Hayward <alan.hayward@arm.com>
5770
5771 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5772 register sizes.
5773
b1c896b3
TT
57742019-08-14 Tom Tromey <tromey@adacore.com>
5775
5776 * darwin-nat.c: Include gdbarch.h.
5777 * darwin-nat-info.c: Include gdbarch.h.
5778
6405cd73
TT
57792019-08-13 Tom Tromey <tom@tromey.com>
5780
5781 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5782 Remove.
5783 * tui/tui-data.c (tui_initialize_static_data): Update.
5784
5216580d
TT
57852019-08-13 Tom Tromey <tom@tromey.com>
5786
5787 * tui/tui-winsource.h (struct tui_exec_info_window)
5788 <~tui_exec_info_window, maybe_allocate_content, get_content,
5789 m_content>: Remove.
5790 (struct tui_source_window_base) <set_exec_info_content,
5791 show_exec_info_content>: Don't declare.
5792 * tui/tui-winsource.c
5793 (tui_exec_info_window::maybe_allocate_content): Remove.
5794 (tui_source_window_base::update_exec_info): Rename from
5795 set_exec_info_content.
5796 (tui_source_window_base::show_exec_info_content)
5797 (tui_source_window_base::update_exec_info): Remove.
5798
93858ad3
TT
57992019-08-13 Tom Tromey <tom@tromey.com>
5800
5801 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5802 declare.
5803 * tui/tui-winsource.c (tui_update_source_window_as_is)
5804 (tui_update_source_windows_with_addr, tui_erase_source_content):
5805 Update.
5806 (tui_clear_exec_info_content): Remove.
5807
e321e7ce
TT
58082019-08-13 Tom Tromey <tom@tromey.com>
5809
5810 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5811 declare.
5812 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5813 call tui_erase_exec_info_content.
5814 (tui_clear_exec_info_content): Rename from
5815 tui_erase_exec_info_content.
5816 (tui_clear_exec_info_content): Delete.
5817
8270ac62
TT
58182019-08-13 Tom Tromey <tom@tromey.com>
5819
5820 * tui/tui-winsource.h (struct tui_source_window_base)
5821 <show_exec_info_content>: Declare.
5822 (tui_show_exec_info_content): Don't declare.
5823 * tui/tui-winsource.c
5824 (tui_source_window_base::show_exec_info_content): Rename from
5825 tui_show_exec_info_content.
5826 (tui_source_window_base::update_exec_info): Update.
5827
7b56485d
TT
58282019-08-13 Tom Tromey <tom@tromey.com>
5829
5830 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5831 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5832 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5833 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5834 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5835 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5836 ... here.
5837
7ba913dc
TT
58382019-08-13 Tom Tromey <tom@tromey.com>
5839
5840 * tui/tui-winsource.h (struct tui_source_window_base)
5841 <update_exec_info>: Declare.
5842 (tui_update_exec_info): Don't declare.
5843 * tui/tui-winsource.c (tui_update_source_window_as_is)
5844 (tui_source_window_base::refresh_all)
5845 (tui_update_all_breakpoint_info): Update.
5846 (tui_source_window_base::update_exec_info): Rename from
5847 tui_update_exec_info.
5848 * tui/tui-stack.c (tui_show_frame_info): Update.
5849
37a4a131
TT
58502019-08-13 Tom Tromey <tom@tromey.com>
5851
5852 * tui/tui-winsource.h (struct tui_source_window_base)
5853 <set_exec_info_content>: Declare.
5854 (tui_set_exec_info_content): Don't declare.
5855 * tui/tui-winsource.c
5856 (tui_source_window_base::set_exec_info_content): Rename from
5857 tui_set_exec_info_content.
5858 (tui_update_exec_info): Update.
5859
0bd27e07
TT
58602019-08-13 Tom Tromey <tom@tromey.com>
5861
5862 * tui/tui-winsource.h (struct tui_source_window_base)
5863 <show_source_content>: Declare.
5864 (tui_show_source_content): Don't declare.
5865 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5866 (tui_source_window_base::show_source_content): Rename from
5867 tui_show_source_content.
5868 (tui_source_window_base::refresh_all): Update.
5869 * tui/tui-layout.c (show_source_disasm_command)
5870 (show_source_or_disasm_and_command): Update.
5871
b4ef5aeb
TT
58722019-08-13 Tom Tromey <tom@tromey.com>
5873
5874 * tui/tui-winsource.c (tui_erase_source_content)
5875 (tui_show_source_content, tui_source_window_base::refresh_all):
5876 Update.
5877 * tui/tui-wingeneral.h
5878 (tui_check_and_display_highlight_if_needed): Don't declare.
5879 * tui/tui-wingeneral.c
5880 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5881 check_and_display_highlight_if_needed.
5882 * tui/tui-win.c (tui_rehighlight_all)
5883 (tui_win_info::make_visible_with_new_height): Update.
5884 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5885 (tui_data_window::erase_data_content)
5886 (tui_data_window::display_all_data): Update.
5887 * tui/tui-data.h (struct tui_win_info)
5888 <check_and_display_highlight_if_needed>: Declare.
5889
fede5273
TT
58902019-08-13 Tom Tromey <tom@tromey.com>
5891
5892 * tui/tui-win.c (tui_resize_all): Call
5893 tui_delete_invisible_windows.
5894 * tui/tui-layout.c (show_layout): Call
5895 tui_delete_invisible_windows.
5896 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5897 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5898
22c3f490
TT
58992019-08-13 Tom Tromey <tom@tromey.com>
5900
5901 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5902 tui_add_win_to_layout.
5903
16cb7910
TT
59042019-08-13 Tom Tromey <tom@tromey.com>
5905
5906 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5907 * tui/tui-layout.c (tui_default_win_height): Now static.
5908
cc0c3ffb
TT
59092019-08-13 Tom Tromey <tom@tromey.com>
5910
5911 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5912 single switch.
5913 (show_source_disasm_command, show_source_or_disasm_and_command):
5914 Don't check current layout.
5915
3f3ffe54
TT
59162019-08-13 Tom Tromey <tom@tromey.com>
5917
5918 * tui/tui-wingeneral.c (make_all_visible): Remove.
5919 (tui_make_all_invisible): Simplify.
5920 * tui/tui-layout.c (tui_make_all_invisible): Move from
5921 tui-wingeneral.c; simplify.
5922 (show_layout): Hoist call to tui_make_all_invisible.
5923 (show_data): Don't call tui_make_all_invisible.
5924
69258091
TT
59252019-08-13 Tom Tromey <tom@tromey.com>
5926
5927 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5928 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5929
62cf57fe
TT
59302019-08-13 Tom Tromey <tom@tromey.com>
5931
5932 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5933 tui-data.c.
5934 (show_source_disasm_command, show_data)
5935 (show_source_or_disasm_and_command): Don't use
5936 tui_set_current_layout_to.
5937 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5938 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5939 tui-layout.c.
5940 (tui_set_current_layout_to): Remove.
5941
2afade5d
TT
59422019-08-13 Tom Tromey <tom@tromey.com>
5943
5944 * tui/tui-layout.c (tui_set_layout): Update.
5945 * tui/tui-data.h (struct tui_layout_def): Remove.
5946 (tui_layout_def): Don't declare.
5947 * tui/tui-data.c (layout_def): Remove.
5948 (tui_layout_def): Remove.
5949
a3504e96
TT
59502019-08-13 Tom Tromey <tom@tromey.com>
5951
5952 * tui/tui-winsource.h (struct tui_source_window_base)
5953 <clear_detail>: No longer "override".
5954 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5955 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5956 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5957 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5958 Remove.
5959 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5960
29c92911
TT
59612019-08-13 Tom Tromey <tromey@adacore.com>
5962
5963 * tracepoint.c: Don't include readline.h or history.h.
5964
86c6b807
TT
59652019-08-12 Tom Tromey <tom@tromey.com>
5966
5967 * configure: Rebuild.
5968 * configure.ac: Check for readline 7.
5969 * NEWS: Mention readline 7 requirement.
5970 * README: Update.
5971
5db2718c
TT
59722019-08-12 Tom Tromey <tom@tromey.com>
5973
5974 * mingw-hdep.c (gdb_select): Remove readline hack.
5975
dac36daf
PFC
59762019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5977
5978 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5979 when the function fails.
5980
1022c627
AA
59812019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5982
5983 * s390-tdep.c (s390_type_align): New function.
5984 (s390_gdbarch_init): Set it as type_align gdbarch method.
5985
eba4caf2
TV
59862019-08-09 Tom de Vries <tdevries@suse.de>
5987
5988 PR gdb/24591
5989 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5990 pc_low with relocation offset.
5991
123cd851
TT
59922019-08-07 Tom Tromey <tromey@adacore.com>
5993
5994 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5995 (print_frame_args): Update.
5996 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5997 Update.
5998 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5999 * frame.h (struct frame_arg): Add initializers.
6000 <error>: Now a unique_xmalloc_ptr.
6001
3d31bc39
AH
60022019-08-07 Alan Hayward <alan.hayward@arm.com>
6003
6004 * NEWS: Expand the Pointer Authentication entry.
6005 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6006 (aarch64_frame_unmask_lr): ... to this.
6007 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6008 Call aarch64_frame_unmask_lr.
6009 * frame.c (struct frame_info): Add "masked" variable.
6010 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6011 (fprint_frame): Check for masked pc.
6012 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6013 declarations.
6014 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6015 * stack.c (print_frame): Check for masked pc.
6016
0cf9feb9
TT
60172019-08-06 Tom Tromey <tom@tromey.com>
6018
6019 * stabsread.c (patch_block_stabs, read_one_struct_field)
6020 (read_enum_type): Use obstack_strndup.
6021 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6022 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6023 * dwarf2read.c (guess_full_die_structure_name)
6024 (anonymous_struct_prefix): Use obstack_strndup.
6025 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6026 * c-exp.y (yylex): Use obstack_strndup.
6027 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6028 (write_var_or_type): Use obstack_strndup.
6029
efba19b0
TT
60302019-08-06 Tom Tromey <tom@tromey.com>
6031
6032 * symfile.c (reread_symbols): Use obstack_strdup.
6033 * stabsread.c (read_type): Use obstack_strdup.
6034 * gdb_obstack.h (obstack_strdup): New overload.
6035 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6036 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6037 (dwarf2_canonicalize_name): Use obstack_strdup.
6038 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6039 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6040 Use obstack_strdup.
6041
f25102f7
TT
60422019-08-06 Tom Tromey <tom@tromey.com>
6043
6044 * gdb_obstack.h (obstack_strdup): Define.
6045 * gdb_obstack.c (obstack_strdup): Don't define.
6046
021887d8
TT
60472019-08-06 Tom Tromey <tom@tromey.com>
6048
6049 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6050 obstack_strdup.
6051 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6052 obstack_strdup.
6053 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6054 * stabsread.c (common_block_start): Use obstack_strdup.
6055 * objfiles.c (set_objfile_main_name, objfile): Use
6056 obstack_strdup.
6057 * namespace.c (add_using_directive): Use obstack_strdup.
6058 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6059 * jit.c (finalize_symtab): Use obstack_strdup.
6060 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6061 (guess_partial_die_structure_name, partial_die_info::fixup)
6062 (dwarf2_name): Use obstack_strdup.
6063 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6064 obstack_strdup.
6065 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6066 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6067 obstack_strdup.
6068 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6069
d2834edc
PW
60702019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6071
6072 * unittests/help-doc-selftests.c: New file.
6073 * Makefile.in: Add the new file.
6074
590042fc
PW
60752019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6076
6077 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6078 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6079 the full first line, except when FOR_VALUE_PREFIX. In this case,
6080 the trailing '.' is not output, and the first character is uppercased.
6081 (print_help_for_command): Update call to print_doc_line.
6082 (print_doc_of_command): Likewise.
6083 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6084 * cli/cli-option.c (append_indented_doc): Do not append newline.
6085 (build_help_option): Append newline after first appended_indented_doc
6086 only if a second call is done.
6087 (build_help): Append 2 new lines before each option, except the first
6088 one.
6089 * compile/compile.c (_initialize_compile): Add new lines after
6090 %OPTIONS%, when not at the end of the help.
6091 Change help doc or code
6092 producing the help doc to respect the invariants.
6093 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6094 Also removed the new line after 'Options:', as all other commands
6095 do not put an empty line between 'Options:' and the first option.
6096 * printcmd.c (_initialize_printcmd): Likewise.
6097 * stack.c (_initialize_stack): Likewise.
6098 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6099 incorrectly telling COMMAND is optional.
6100 * ada-lang.c (_initialize_ada_language): Change help doc or code
6101 producing the help doc to respect the invariants.
6102 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6103 * breakpoint.c (_initialize_breakpoint): Likewise.
6104 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6105 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6106 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6107 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6108 _initialize_cli_style): Likewise.
6109 * corelow.c (core_target_info): Likewise.
6110 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6111 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6112 * filesystem.c (_initialize_filesystem): Likewise.
6113 * frame.c (_initialize_frame): Likewise.
6114 * gnu-nat.c (add_task_commands): Likewise.
6115 * infcall.c (_initialize_infcall): Likewise.
6116 * infcmd.c (_initialize_infcmd): Likewise.
6117 * interps.c (_initialize_interpreter): Likewise.
6118 * language.c (_initialize_language): Likewise.
6119 * linux-fork.c (_initialize_linux_fork): Likewise.
6120 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6121 * maint.c (_initialize_maint_cmds): Likewise.
6122 * memattr.c (_initialize_mem): Likewise.
6123 * printcmd.c (_initialize_printcmd): Likewise.
6124 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6125 _RegEx): Likewise.
6126 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6127 * record-btrace.c (_initialize_record_btrace): Likewise.
6128 * record-full.c (_initialize_record_full): Likewise.
6129 * record.c (_initialize_record): Likewise.
6130 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6131 * regcache.c (_initialize_regcache): Likewise.
6132 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6133 _initialize_remote): Likewise.
6134 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6135 * serial.c (_initialize_serial): Likewise.
6136 * skip.c (_initialize_step_skip): Likewise.
6137 * source.c (_initialize_source): Likewise.
6138 * stack.c (_initialize_stack): Likewise.
6139 * symfile.c (_initialize_symfile): Likewise.
6140 * symtab.c (_initialize_symtab): Likewise.
6141 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6142 * top.c (init_main): Likewise.
6143 * tracefile-tfile.c (tfile_target_info): Likewise.
6144 * tracepoint.c (_initialize_tracepoint): Likewise.
6145 * tui/tui-win.c (_initialize_tui_win): Likewise.
6146 * utils.c (add_internal_problem_command): Likewise.
6147 * valprint.c (value_print_option_defs): Likewise.
6148
404f2902
FCE
61492019-08-06 Frank Ch. Eigler <fche@redhat.com>
6150
6151 PR build/24886
6152 * configure.ac: Drop enable-libmcheck support.
6153 * configure, config.in: Rebuild.
6154 * libmcheck.m4: Remove.
6155 * acinclude.m4: Don't include it.
6156 * Makefile.in: Don't distribute it.
6157 * top.c (print_gdb_configuration): Don't mention it.
6158
046bebe1
TT
61592019-08-06 Tom Tromey <tom@tromey.com>
6160
6161 * utils.c (set_output_style): Sometimes pass stream to
6162 emit_style_escape.
6163 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6164 * record-btrace.c (btrace_insn_history): Update.
6165 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6166 method.
6167 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6168 Update initializers.
6169 <m_uiout>: New field.
6170 <m_di>: Move lower.
6171 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6172 Remove "uiout" parameter.
6173 (dump_insns): Update.
6174 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6175 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6176
ddbcedf5
CB
61772019-08-06 Christian Biesinger <cbiesinger@google.com>
6178
6179 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6180 (error_in_psymtab_expansion): Likewise.
6181 (lookup_symbol_via_quick_fns): Likewise.
6182 (basic_lookup_transparent_type_quick): Likewise.
6183 (basic_lookup_transparent_type_1): Likewise.
6184
b08b16c8
TT
61852019-08-06 Tom Tromey <tromey@adacore.com>
6186
6187 * source.c (last_source_error): Now bool.
6188 (print_source_lines_base): Make "noprint" bool. Only open
6189 source file when last_source_visited changes.
6190
cb44333d
TT
61912019-08-06 Tom Tromey <tromey@adacore.com>
6192
6193 * annotate.c (annotate_source_line): Use g_source_cache.
6194 * source-cache.c (source_cache::get_plain_source_lines): Change
6195 parameters. Populate m_offset_cache.
6196 (source_cache::ensure): New method.
6197 (source_cache::get_line_charpos): New method.
6198 (extract_lines): Move lower. Change parameters.
6199 (source_cache::get_source_lines): Move lower.
6200 * source-cache.h (class source_cache): Update comment.
6201 <get_line_charpos>: New method.
6202 <get_source_lines>: Update comment.
6203 <clear>: Clear m_offset_cache.
6204 <get_plain_source_lines>: Change parameters.
6205 <ensure>: New method
6206 <m_offset_cache>: New member.
6207 * source.c (forget_cached_source_info_for_objfile): Update.
6208 (info_source_command): Use g_source_cache.
6209 (find_source_lines, open_source_file_with_line_charpos): Remove.
6210 (print_source_lines_base, search_command_helper): Use g_source_cache.
6211 * source.h (open_source_file_with_line_charpos): Don't declare.
6212 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6213 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6214 Use g_source_cache.
6215
872dceaa
TT
62162019-08-06 Tom Tromey <tromey@adacore.com>
6217
6218 * source-cache.c (source_cache::get_plain_source_lines):
6219 Remove "first_line" and "last_line" parameters.
6220 (source_cache::get_source_lines): Cache plain text.
6221 * source-cache.h (class source_cache)
6222 <get_plain_source_lines>: Update.
6223
269249d9
TT
62242019-08-06 Tom Tromey <tromey@adacore.com>
6225
6226 * source-cache.c (extract_lines): No longer a method.
6227 Changed type of parameter. Include final newline.
6228 (selftests::extract_lines_test): New function.
6229 (_initialize_source_cache): Likewise.
6230 * source-cache.h (class source_cache)
6231 <extract_lines>: Don't declare.
6232
c0e8dcd8
TT
62332019-08-06 Tom Tromey <tromey@adacore.com>
6234
6235 * breakpoint.c (init_breakpoint_sal): Update.
6236 (breakpoint): Update.
6237 * breakpoint.h (struct breakpoint) <filter>: Now a
6238 unique_xmalloc_ptr.
6239
0b27c27d
CB
62402019-08-05 Christian Biesinger <cbiesinger@google.com>
6241
6242 * NEWS: Mention dictionary access on blocks.
6243 * python/py-block.c (blpy_getitem): New function.
6244 (block_object_as_mapping): New struct.
6245 (block_object_type): Use new struct for tp_as_mapping field.
6246
4ee94178
CB
62472019-08-05 Christian Biesinger <cbiesinger@google.com>
6248
6249 * objfiles.h (objfile): Add a comment describing partial symbols.
6250
8abfcabc
TT
62512019-08-05 Tom Tromey <tromey@adacore.com>
6252
6253 * compile/compile.c (_initialize_compile): Use _(), not N_().
6254 * thread.c (_initialize_thread): Use _(), not N_().
6255 * stack.c (_initialize_stack): Use _(), not N_().
6256 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6257
2b79f376
SM
62582019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6259
6260 * dwarf2read.c (struct dw2_symtab_iterator):
6261 <want_specific_block>: Remove.
6262 <block_index>: Change type to gdb::optional.
6263 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6264 change type of BLOCK_INDEX parameter to gdb::optional.
6265 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6266 (dw2_lookup_symbol): Don't pass argument for
6267 WANT_SPECIFIC_BLOCK.
6268 (dw2_expand_symtabs_for_function): Don't pass argument for
6269 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6270 (class dw2_debug_names_iterator)
6271 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6272 parameter, change BLOCK_INDEX type to gdb::optional.
6273 <m_want_specific_block>: Remove.
6274 <m_block_index>: Change type to gdb::optional.
6275 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6276 gdb::optional. Re-write in function of gdb::optional.
6277 (dw2_debug_names_lookup_symbol): Don't pass argument for
6278 WANT_SPECIFIC_BLOCK.
6279 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6280 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6281 BLOCK_INDEX.
6282
ae60f04e
PW
62832019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6284
6285 * NEWS: Mention changes to "info sources" command.
6286
28cd9371
PW
62872019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6288
6289 * symtab.c (filename_partial_match_opts): New struct type.
6290 (struct output_source_filename_data): New members
6291 regexp, c_regexp, partial_match.
6292 (output_source_filename): Use new members to decide to print file.
6293 (info_sources_option_defs): New variable.
6294 (make_info_sources_options_def_group, print_info_sources_header,
6295 info_sources_command_completer):
6296 New functions.
6297 (info_sources_command): Read new optional arguments.
6298 (_initialize_symtab): Update info sources help.
6299
ca683e3a
AO
63002019-08-02 Alexandre Oliva <oliva@adacore.com>
6301
6302 * ada-lang.c (exception_support_info_v0): Renamed from...
6303 (default_exception_support_info): ... this. Create new
6304 definition for v1.
6305 (ada_has_this_exception_support): Look up catch_handlers_sym.
6306 (ada_exception_support_info_sniffer): Try v0 after default.
6307
f1264162
TT
63082019-08-01 Tom Tromey <tromey@adacore.com>
6309
6310 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6311 gdbarch.h.
6312
0a7b2485
CB
63132019-08-01 Christian Biesinger <cbiesinger@google.com>
6314
6315 * s12z-tdep.c: Fix include path for s12z-opc.h.
6316
c6bdbeb7
AH
63172019-08-01 Alan Hayward <alan.hayward@arm.com>
6318
6319 * NEWS: Require GNU make 3.82.
6320
a2bd7b82
TT
63212019-07-16 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6324 declare.
6325
aa3b6533
TT
63262019-07-30 Tom Tromey <tromey@adacore.com>
6327
6328 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6329
a1530dc7
KB
63302019-07-30 Kevin Buettner <kevinb@redhat.com>
6331
6332 * printcmd.c (print_address_symbolic): Print negative offsets.
6333 (build_address_symbolic): Force signed arithmetic when computing
6334 offset.
6335
2906593f
CB
63362019-07-30 Christian Biesinger <cbiesinger@google.com>
6337
6338 PR/24474: Add a function to lookup static variables.
6339 * NEWS: Mention this new function.
6340 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6341 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6342 * python/python.c (python_GdbMethods): Add new function.
6343
c620ed88
CB
63442019-07-29 Christian Biesinger <cbiesinger@google.com>
6345
6346 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6347 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6348 (objfpy_lookup_static_symbol): New function.
6349 (objfile_object_methods): Add new functions.
6350
bc4268a5
PW
63512019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6352
6353 * NEWS: Mention 'set|show print frame-info'. Mention new
6354 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6355 backtrace argument. Mention that python frame filtering code
6356 is now consistent with what 'backtrace' command prints.
6357
4b5e8d19
PW
63582019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6359
6360 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6361 comments.
6362 (print_frame_info_auto, print_frame_info_source_line,
6363 print_frame_info_location, print_frame_info_source_and_location,
6364 print_frame_info_location_and_address, print_frame_info_short_location):
6365 New declarations.
6366 (struct frame_print_options): New member print_frame_info.
6367 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6368 * stack.h (get_user_print_what_frame_info): New declaration.
6369 (frame_show_address): New declaration.
6370 * stack.c (print_frame_arguments_choices): New value 'presence'.
6371 (print_frame_info_auto, print_frame_info_source_line,
6372 print_frame_info_location, print_frame_info_source_and_location,
6373 print_frame_info_location_and_address, print_frame_info_short_location,
6374 print_frame_info_choices, print_frame_info_print_what): New definitions.
6375 (print_frame_args): Only print dots for args if print frame-arguments
6376 is 'presence'.
6377 (frame_print_option_defs): New element for "frame-info".
6378 (get_user_print_what_frame_info): New function.
6379 (frame_show_address): Make non static. Move comment to stack.h.
6380 (print_frame_info_to_print_what): New function.
6381 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6382 to decide what to print.
6383 (backtrace_command_1): Handle the new print_frame_arguments_presence
6384 value.
6385 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6386 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6387 (py_print_frame): In non-mi mode, use LOCATION as default for
6388 print_what, similarly to frame information printed directly by
6389 backtrace command. Handle frame-info user option in non MI mode.
6390
6bdfee81
KB
63912019-07-27 Kevin Buettner <kevinb@redhat.com>
6392
6393 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6394 Add case for debugging 32-bit target on 64-bit host. Revise
6395 comment.
6396
98a617f8
KB
63972019-07-27 Kevin Buettner <kevinb@redhat.com>
6398
6399 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6400 instead of find_function_entry_range_from_pc.
6401
567238c9
KB
64022019-07-27 Kevin Buettner <kevinb@redhat.com>
6403
6404 * stack.c (find_frame_funname): Remove code which preferred
6405 minsym over symtab sym in "certain pathological cases".
6406
2dc80cf8
KB
6407 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6408 parameter. Change type of "do_demangle" to bool.
6409 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6410 Pass suitable "prefer_sym_over_minsym" flag to
6411 build_address_symbolic(). Don't output "+" for negative offsets.
6412 * printcmd.c (print_address_symbolic): Update invocation of
6413 build_address_symbolic to include a "prefer_sym_over_minsym"
6414 flag.
6415 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6416 Restrict cases in which use of minimal symbol is preferred to that
6417 of a found symbol. Update comments.
6418
1aff7173
KB
6419 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6420 for entry pc when entry pc is out of range for that FDE.
6421
89b085ac
BC
64222019-07-26 Brian Callahan <bcallah@openbsd.org>
6423
6424 PR gdb/24839:
6425 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6426 type.
6427
f32feb4a
CB
64282019-07-25 Christian Biesinger <cbiesinger@google.com>
6429
6430 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6431 this function's Python signature.
6432
6433
64342019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6435
6436 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6437 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6438 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6439 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6440 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6441
6442
c54e4253
YS
64432019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6444
6445 * h8300-tdep.c (h8300_register_name_common): New.
6446 h8300_register_name): Use h8300_register_name_common.
6447 (h8300s_register_name): Likewise.
6448 (h8300sx_register_name): Likewise.
6449 (h8300h_register_nam): New.
6450 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6451
6452
40eadf04
SP
64532019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6454
6455 * arm-tdep.c (arm_skip_cmse_entry): New function.
6456 (arm_is_sgstubs_section): New function.
6457 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6458
bfa2a36d
TT
64592019-07-22 Tom Tromey <tom@tromey.com>
6460
6461 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6462 Don't self-assign.
6463
a8e9d247
AB
64642019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6465
6466 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6467 type_print.
6468
eb86c5e2
AB
64692019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6470
6471 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6472 so that GDB doesn't match any msymbols when searching in the
6473 TYPES_DOMAIN.
6474 (print_symbol_info): Print using typedef_print or type_print based
6475 on the type of the symbol. Add updated FIXME comment moved from...
6476 (_initialize_symtab): ... move and update FIXME comment to above.
6477
a8eab7c6
AB
64782019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6479
6480 * NEWS: Mention adding -q option to "info types".
6481 * symtab.c (struct info_types_options): New struct.
6482 (info_types_options_defs): New variable.
6483 (make_info_types_options_def_group): New function.
6484 (info_types_command): Use gdb::option framework to parse options.
6485 (info_types_command_completer): New function.
6486 (_initialize_symtab): Extend the help text on "info types" and
6487 register command completer.
6488
b4603c34
CB
64892019-07-21 Christian Biesinger <cbiesinger@google.com>
6490
6491 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6492 (lookup_symbol_in_objfile): Change int to block_enum and add a
6493 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6494
c8cdc1e0
CB
64952019-07-20 Christian Biesinger <cbiesinger@google.com>
6496
6497 * MAINTAINERS (Write After Approval): Add self.
6498
01e175fe
AB
64992019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6500
6501 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6502 instruction to the dummy code region.
6503
56f79b63
TT
65042019-07-19 Tom Tromey <tromey@adacore.com>
6505
6506 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6507 (ARGSUSED, PARAMS, __func__): Remove rules.
6508
4c5aa8e0
AH
65092019-07-19 Alan Hayward <alan.hayward@arm.com>
6510
6511 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6512 * features/arm/arm-with-iwmmxt.c: Remove.
6513 * features/arm/arm-with-iwmmxt.xml: Remove.
6514 * features/arm/arm-with-m-fpa-layout.c: Remove.
6515 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6516 * features/arm/arm-with-m-vfp-d16.c: Remove.
6517 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6518 * features/arm/arm-with-m.c: Remove.
6519 * features/arm/arm-with-m.xml: Remove.
6520 * features/arm/arm-with-neon.c: Remove.
6521 * features/arm/arm-with-neon.xml: Remove.
6522 * features/arm/arm-with-vfpv2.c: Remove.
6523 * features/arm/arm-with-vfpv2.xml: Remove.
6524 * features/arm/arm-with-vfpv3.c: Remove.
6525 * features/arm/arm-with-vfpv3.xml: Remove.
6526
f42b2617
AH
65272019-07-19 Alan Hayward <alan.hayward@arm.com>
6528
6529 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6530
f29ec966
AH
65312019-07-19 Alan Hayward <alan.hayward@arm.com>
6532
6533 * arch/aarch32.c (aarch32_create_target_description): Create
6534 target descriptions using features.
6535 * arch/arm.c (arm_create_target_description)
6536 (arm_create_mprofile_target_description): Likewise.
6537 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6538
d105cce5
AH
65392019-07-19 Alan Hayward <alan.hayward@arm.com>
6540
6541 * Makefile.in: Add new files.
6542 * aarch32-tdep.c: New file.
6543 * aarch32-tdep.h: New file.
6544 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6545 Call aarch32_read_description.
6546 * arch/aarch32.c: New file.
6547 * arch/aarch32.h: New file.
6548 * arch/arm.c (arm_create_target_description)
6549 (arm_create_mprofile_target_description): New function.
6550 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6551 (arm_create_target_description)
6552 (arm_create_mprofile_target_description): New declaration.
6553 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6554 read_description functions.
6555 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6556 Likewise.
6557 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6558 * arm-tdep.c (tdesc_arm_list): New variable.
6559 (arm_register_g_packet_guesses): Call create description functions.
6560 (arm_read_description) (arm_read_mprofile_description): New
6561 function.
6562 * arm-tdep.h (arm_read_description)
6563 (arm_read_mprofile_description): Add declaration.
6564 * configure.tgt: Add new files.
6565
afe09f0b
GL
65662019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6567
6568 * top.c (new_ui_command): Open specified terminal just once.
6569
cd215b2e
TT
65702019-07-18 Tom Tromey <tromey@adacore.com>
6571
6572 * symtab.c (main_name): Constify return type.
6573 * symfile.c (set_initial_language): Update.
6574 * symtab.h (main_name): Constify return type.
6575
d8f68fcb
TT
65762019-07-17 Tom Tromey <tom@tromey.com>
6577
6578 * tui/tui-winsource.c (tui_update_source_window)
6579 (tui_update_source_window_as_is)
6580 (tui_update_source_windows_with_line): Remove return.
6581 * tui/tui-disasm.c (tui_show_disassem)
6582 (tui_show_disassem_and_update_source): Remove return.
6583 * tui/tui.c (tui_reset): Remove return.
6584 * tui/tui-wingeneral.c
6585 (tui_check_and_display_highlight_if_needed): Remove return.
6586
ca5af91e
TT
65872019-07-17 Tom Tromey <tom@tromey.com>
6588
6589 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6590
5104fe36
TT
65912019-07-17 Tom Tromey <tom@tromey.com>
6592
6593 * tui/tui-winsource.h (struct tui_exec_info_window)
6594 (struct tui_source_window_base): Move from tui-data.h.
6595 * tui/tui-winsource.c: Move many method definitions from
6596 elsewhere. Remove "structuring" comments.
6597 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6598 (tui_source_window_base::refresh_window): Move to
6599 tui-winsource.c.
6600 * tui/tui-win.c (tui_source_window_base::refresh_all)
6601 (tui_source_window_base::update_tab_width)
6602 (tui_source_window_base::set_new_height)
6603 (tui_source_window_base::do_make_visible_with_new_height): Move to
6604 tui-winsource.c.
6605 * tui/tui-source.h: Update.
6606 * tui/tui-source.c (tui_source_window_base::reset): Move to
6607 tui-winsource.c.
6608 * tui/tui-disasm.h: Update.
6609 * tui/tui-data.h (struct tui_exec_info_window): Move to
6610 tui-winsource.h.
6611 (struct tui_source_window_base): Likewise.
6612 * tui/tui-data.c (tui_source_window_base::clear_detail)
6613 (tui_source_window_base, ~tui_source_window_base): Move to
6614 tui-winsource.c.
6615
daa15dde
TT
66162019-07-17 Tom Tromey <tom@tromey.com>
6617
6618 * tui/tui-win.c (tui_resize_all)
6619 (tui_source_window_base::update_tab_width)
6620 (tui_adjust_win_heights): Update.
6621 (tui_win_info::make_invisible_and_set_new_height): Rename from
6622 make_invisible_and_set_new_height.
6623 * tui/tui-data.h (struct tui_win_info)
6624 <make_invisible_and_set_new_height>: New method.
6625
bfad4537
TT
66262019-07-17 Tom Tromey <tom@tromey.com>
6627
6628 * tui/tui.c: Update.
6629 * tui/tui-source.h (struct tui_source_window): Move from
6630 tui-data.h.
6631 * tui/tui-layout.c: Update.
6632 * tui/tui-disasm.c: Update.
6633 * tui/tui-data.h (struct tui_source_window): Move to
6634 tui-source.h.
6635
88f7e873
TT
66362019-07-17 Tom Tromey <tom@tromey.com>
6637
6638 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6639 tui-data.h.
6640 * tui/tui-data.h (struct tui_disasm_window): Move to
6641 tui-disasm.h.
6642
96bd6233
TT
66432019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui-regs.h (struct tui_data_item_window): Move from
6646 tui-data.h.
6647 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6648 * tui/tui-data.h (struct tui_data_item_window): Move to
6649 tui-regs.h.
6650 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6651
ce38393b
TT
66522019-07-17 Tom Tromey <tom@tromey.com>
6653
6654 * tui/tui.c: Update.
6655 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6656 (tui_cmd_window::max_height): Move to tui-command.c.
6657 * tui/tui-layout.c: Update.
6658 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6659 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6660 tui-command.c.
6661 * tui/tui-command.h (struct tui_cmd_window): Move from
6662 tui-data.h.
6663 * tui/tui-command.c: Remove "structuring" comments.
6664 (tui_cmd_window::clear_detail)
6665 (tui_cmd_window::do_make_visible_with_new_height)
6666 (tui_cmd_window::max_height): Move from elsewhere.
6667
2d8b51cb
TT
66682019-07-17 Tom Tromey <tom@tromey.com>
6669
6670 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6671 Now static.
6672 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6673 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6674
18ab23af
TT
66752019-07-17 Tom Tromey <tom@tromey.com>
6676
6677 * tui/tui.c: Update.
6678 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6679 tui-regs.c.
6680 * tui/tui-windata.h: Remove file.
6681 * tui/tui-windata.c: Remove file.
6682 * tui/tui-win.c (tui_data_window::set_new_height)
6683 (tui_data_window::do_make_visible_with_new_height): Move to
6684 tui-regs.c.
6685 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6686 * tui/tui-regs.c: Remove "structuring" comments.
6687 (tui_data_window::first_data_item_displayed)
6688 (tui_data_window::delete_data_content_windows)
6689 (tui_data_window::erase_data_content)
6690 (tui_data_window::display_all_data)
6691 (tui_data_window::refresh_all)
6692 (tui_data_window::do_scroll_vertical)
6693 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6694 (tui_data_window::do_make_visible_with_new_height)
6695 (tui_data_window::refresh_window): Move from elsewhere.
6696 (_initialize_tui_regs): Move to end of file.
6697 * tui/tui-layout.c: Update.
6698 * tui/tui-hooks.c: Update.
6699 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6700 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6701 tui-regs.c.
6702 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6703
88b7e7cc
TT
67042019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6707 seen.
6708
0fcd3711
TT
67092019-07-17 Tom Tromey <tom@tromey.com>
6710
6711 * tui/tui-win.c (tui_source_window_base::set_new_height)
6712 (tui_source_window_base::do_make_visible_with_new_height): Use
6713 m_has_locator field directly.
6714 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6715 method.
6716 (struct tui_source_window_base) <has_locator>: Likewise.
6717
4a38112d
TT
67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6721 Don't declare.
6722 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6723 Remove.
6724 * tui/tui-win.c (tui_source_window_base::set_new_height)
6725 (tui_source_window_base::set_new_height)
6726 (make_invisible_and_set_new_height)
6727 (tui_source_window_base::do_make_visible_with_new_height)
6728 (tui_source_window_base::do_make_visible_with_new_height):
6729 Update.
6730 * tui/tui-layout.c (show_source_disasm_command, show_data)
6731 (show_source_or_disasm_and_command): Update.
6732 * tui/tui-layout.c (show_layout): Update.
6733
09129226
TT
67342019-07-17 Tom Tromey <tom@tromey.com>
6735
6736 * tui/tui-layout.c (make_data_window): Remove.
6737 (show_data): Unify creation and re-initialization cases.
6738
4a8a5e84
TT
67392019-07-17 Tom Tromey <tom@tromey.com>
6740
6741 * tui/tui-layout.c (make_source_window, make_disasm_window):
6742 Remove.
6743 (show_data): Unify creation and re-initialization cases.
6744
76d2be8e
TT
67452019-07-17 Tom Tromey <tom@tromey.com>
6746
6747 * tui/tui-layout.c (make_command_window): Remove.
6748 (show_source_disasm_command, show_source_or_disasm_and_command):
6749 Unify creation and re-initialization cases.
6750
890b8bde
TT
67512019-07-17 Tom Tromey <tom@tromey.com>
6752
6753 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6754 creation and re-initialization cases.
6755
2cdfa113
TT
67562019-07-17 Tom Tromey <tom@tromey.com>
6757
6758 * tui/tui-regs.c (tui_get_register): Return void.
6759
8e3cfd09
TT
67602019-07-17 Tom Tromey <tom@tromey.com>
6761
6762 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6763 Simplify.
6764
f4e04977
TT
67652019-07-17 Tom Tromey <tom@tromey.com>
6766
6767 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6768 resetting.
6769
0379b883
TT
67702019-07-17 Tom Tromey <tom@tromey.com>
6771
6772 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6773 * tui/tui-regs.c (tui_reg_layout): New function.
6774 (tui_show_registers, tui_reg_command): Use it.
6775 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6776 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6777 parameters.
6778 (tui_layout_command): Remove.
6779
b7fbad91
TT
67802019-07-17 Tom Tromey <tom@tromey.com>
6781
6782 * tui/tui-layout.h (tui/tui-layout): Return void.
6783 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6784
4e1e56b9
TT
67852019-07-17 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-layout.c (show_source_disasm_command, show_data):
6788 Update.
6789 (reset_locator): Remove.
6790 (show_source_or_disasm_and_command): Update.
6791
1e0c09ba
TT
67922019-07-17 Tom Tromey <tom@tromey.com>
6793
6794 * tui/tui-source.c (tui_source_window_base::reset): Remove
6795 win_type parameter.
6796 * tui/tui-layout.c (make_command_window, make_source_window)
6797 (make_disasm_window, make_data_window)
6798 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6799 (reset_locator, show_source_or_disasm_and_command): Update.
6800 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6801 win_type parameter.
6802 (struct tui_source_window_base) <reset>: Likewise.
6803
1bf605de
TT
68042019-07-17 Tom Tromey <tom@tromey.com>
6805
6806 * tui/tui-layout.c (show_source_disasm_command): Use
6807 reset_locator.
6808 (reset_locator): New function.
6809 (init_and_make_win): Remove.
6810 (show_source_or_disasm_and_command): Use reset_locator.
6811
098f9ed4
TT
68122019-07-17 Tom Tromey <tom@tromey.com>
6813
6814 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6815 condition.
6816 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6817 Remove condition.
6818 * tui/tui-source.c (tui_source_window_base::reset): New method.
6819 * tui/tui-layout.c (make_command_window): Don't call
6820 init_and_make_win.
6821 (make_source_window, make_disasm_window): Don't call
6822 make_source_or_disasm_window.
6823 (make_data_window): Don't call init_and_make_win. Change calling
6824 convention.
6825 (show_source_disasm_command, show_data): Simplify.
6826 (make_source_or_disasm_window): Remove.
6827 (show_source_or_disasm_and_command): Simplify.
6828 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6829 (struct tui_source_window_base) <reset>: Likewise.
6830 <execution_info>: Remove initializer.
6831 * tui/tui-data.c (tui_source_window_base): Initialize
6832 execution_info.
6833
80110957
TT
68342019-07-17 Tom Tromey <tom@tromey.com>
6835
6836 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6837 variable.
6838
cf82af05
TT
68392019-07-17 Tom Tromey <tom@tromey.com>
6840
6841 * tui/tui.c (tui_rl_other_window): Update.
6842 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6843 superclass method first. Always iterate over regs_content.
6844 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6845 method.
6846 * tui/tui-win.c (tui_set_focus_command): Update.
6847
01aeb396
TT
68482019-07-17 Tom Tromey <tom@tromey.com>
6849
6850 * tui/tui-win.c (tui_set_focus_command): Rename from
6851 tui_set_focus. Call tui_enable.
6852 (tui_set_focus_command): Remove.
6853
fd6c75ee
TT
68542019-07-17 Tom Tromey <tom@tromey.com>
6855
6856 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6857 refresh_window.
6858 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6859 touchwin.
6860 (tui_data_window::refresh_window): Call refresh_window on data
6861 items. Always call superclass refresh_window.
6862 (tui_win_info::refresh): Remove.
6863 (tui_source_window_base::refresh_window): Update.
6864 (tui_refresh_all): Update.
6865 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6866 refresh_window.
6867 (show_source_or_disasm_and_command): Likewise.
6868 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6869 (struct tui_source_window_base) <refresh>: Likewise.
6870
f6cc34a9
TT
68712019-07-17 Tom Tromey <tom@tromey.com>
6872
6873 * tui/tui-winsource.c (tui_clear_source_content)
6874 (tui_show_source_content): Update.
6875 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6876 whether content is empty.
6877 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6878 Remove.
6879
f31ec9af
TT
68802019-07-17 Tom Tromey <tom@tromey.com>
6881
6882 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6883 window's contents.
6884 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6885 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6886
d1b6f1e5
TT
68872019-07-17 Tom Tromey <tom@tromey.com>
6888
6889 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6890 (struct tui_data_item_window): Update.
6891
d9743a13
TT
68922019-07-17 Tom Tromey <tom@tromey.com>
6893
6894 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6895 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6896 defines.
6897
caf0bc4e
TT
68982019-07-17 Tom Tromey <tom@tromey.com>
6899
6900 * tui/tui-winsource.h (tui_erase_source_content)
6901 (tui_clear_source_content): Remove "display_prompt" parameter.
6902 * tui/tui-winsource.c (tui_update_source_window_as_is)
6903 (tui_update_source_windows_with_addr): Update.
6904 (tui_clear_source_content): Remove "display_prompt" parameter.
6905 (tui_erase_source_content): Likewise. Simplify.
6906 (tui_show_source_content): Update.
6907 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6908 * tui/tui-stack.c (tui_show_frame_info): Update.
6909 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6910 Remove defines.
6911
9d391078
TT
69122019-07-17 Tom Tromey <tom@tromey.com>
6913
6914 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6915 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6916 parameter.
6917 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6918 parameter.
6919
a38da35d
TT
69202019-07-17 Tom Tromey <tom@tromey.com>
6921
6922 * tui/tui-winsource.c (tui_clear_source_content)
6923 (tui_show_source_content, tui_show_exec_info_content)
6924 (tui_clear_exec_info_content): Update.
6925 * tui/tui-stack.c (tui_show_locator_content): Update.
6926 (tui_show_frame_info): Update.
6927 * tui/tui-source.h (tui_source_window): Don't declare.
6928 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6929 from tui_source_is_displayed.
6930 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6931 Remove field.
6932 (struct tui_source_window_base) <content_in_use>: New field. Now
6933 bool.
6934 (struct tui_source_window) <showing_source_p>: New method.
6935 (TUI_SRC_WIN): Change cast.
6936 * tui/tui-data.c (tui_initialize_static_data): Update.
6937
c2cd8994
TT
69382019-07-17 Tom Tromey <tom@tromey.com>
6939
6940 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6941 location_matches_p.
6942 * tui/tui-source.c (tui_source_window::location_matches_p): New
6943 method.
6944 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6945 method.
6946 * tui/tui-data.h (struct tui_source_window_base)
6947 <location_matches_p>: New method.
6948 (struct tui_source_window, struct tui_disasm_window)
6949 <location_matches_p>: Likewise.
6950
4dde7b34
TT
69512019-07-17 Tom Tromey <tom@tromey.com>
6952
6953 * tui/tui-win.c (tui_set_win_height_command): Rename from
6954 tui_set_win_height.
6955 (tui_set_win_height_command): Remove.
6956
b73dd877
TT
69572019-07-17 Tom Tromey <tom@tromey.com>
6958
6959 * tui/tui-source.c (tui_source_window): New constructor. Add
6960 observer.
6961 (~tui_source_window): New destructor.
6962 (tui_source_window::style_changed): New method.
6963 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6964 (tui_attach_detach_observers): Update.
6965 * tui/tui-data.h (struct tui_source_window): Make constructor not
6966 inline. Add destructor.
6967 (struct tui_source_window) <style_changed>: New method.
6968 <m_observable>: New member.
6969
ae2b5380
TT
69702019-07-17 Tom Tromey <tom@tromey.com>
6971
6972 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6973 * tui/tui-win.c (tui_resize_all): Fix typo.
6974
1ce3e844
TT
69752019-07-17 Tom Tromey <tom@tromey.com>
6976
6977 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6978 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6979 (tui_refresh_all): Remove "list" parameter. Use foreach.
6980 * tui/tui-win.c (window_name_completer): Use foreach.
6981 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6982 (update_tab_width): Likewise.
6983 * tui/tui-layout.c (show_layout): Update.
6984 * tui/tui-data.h (class tui_window_iterator): New.
6985 (struct all_tui_windows): New.
6986 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6987
fe3eaf1c
TT
69882019-07-17 Tom Tromey <tom@tromey.com>
6989
6990 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6991 parameter. Don't reference globals.
6992 (tui_reg_command): Update.
6993
368c1354
TT
69942019-07-17 Tom Tromey <tom@tromey.com>
6995
6996 * tui/tui-regs.c (tui_show_registers): Simplify.
6997
e80cd204
TT
69982019-07-17 Tom Tromey <tom@tromey.com>
6999
7000 * tui/tui-regs.c (tui_show_registers): Update.
7001 (tui_show_register_group): Add win_info parameter.
7002
aca2dd16
TT
70032019-07-17 Tom Tromey <tom@tromey.com>
7004
7005 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7006 Rename from tui_display_reg_element_at_line.
7007 (tui_data_window::display_registers_from_line): Update.
7008 * tui/tui-data.h (struct tui_data_window)
7009 <display_reg_element_at_line>: New method.
7010
517e9505
TT
70112019-07-17 Tom Tromey <tom@tromey.com>
7012
7013 * tui/tui-regs.h (tui_display_registers_from)
7014 (tui_display_registers_from_line): Don't declare.
7015 * tui/tui-windata.c (tui_data_window::display_all_data)
7016 (tui_data_window::refresh_all)
7017 (tui_data_window::do_scroll_vertical): Update.
7018 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7019 from tui_display_registers_from.
7020 (tui_display_reg_element_at_line): Update.
7021 (tui_data_window::display_registers_from_line): Rename from
7022 tui_display_registers_from_line.
7023 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7024 display_registers_from_line>: New methods.
7025
f76d8b19
TT
70262019-07-17 Tom Tromey <tom@tromey.com>
7027
7028 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7029 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7030 from tui_erase_data_content.
7031 (tui_data_window::display_all_data)
7032 (tui_data_window::refresh_all)
7033 (tui_data_window::do_scroll_vertical): Update.
7034 * tui/tui-regs.c (tui_show_registers): Update.
7035 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7036 New method.
7037
b4094625
TT
70382019-07-17 Tom Tromey <tom@tromey.com>
7039
7040 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7041 declare.
7042 * tui/tui-windata.c
7043 (tui_data_window::delete_data_content_windows): Rename from
7044 tui_delete_data_content_windows.
7045 (tui_data_window::display_all_data)
7046 (tui_data_window::do_scroll_vertical): Update.
7047 * tui/tui-data.h (struct tui_data_window)
7048 <delete_data_content_windows>: New method.
7049
c223a729
TT
70502019-07-17 Tom Tromey <tom@tromey.com>
7051
7052 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7053 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7054
50daf268
TT
70552019-07-17 Tom Tromey <tom@tromey.com>
7056
7057 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7058 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7059 from tui_display_all_data.
7060 * tui/tui-win.c
7061 (tui_data_window::do_make_visible_with_new_height): Update.
7062 * tui/tui-regs.c (tui_show_registers): Update.
7063 * tui/tui-layout.c (tui_set_layout): Update.
7064 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7065 method.
7066
df5f8cab
TT
70672019-07-17 Tom Tromey <tom@tromey.com>
7068
7069 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7070 * tui/tui-windata.c (tui_display_data_from): Remove.
7071 (tui_data_window::refresh_all): Update.
7072
80cb6c27
TT
70732019-07-17 Tom Tromey <tom@tromey.com>
7074
7075 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7076 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7077 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7078 tui_display_registers_from_line.
7079 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7080 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7081 "force_display" parameter.
7082
baff0c28
TT
70832019-07-17 Tom Tromey <tom@tromey.com>
7084
7085 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7086 declare.
7087 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7088 Rename from tui_first_reg_element_no_inline.
7089 (tui_display_reg_element_at_line)
7090 (tui_display_registers_from_line): Update.
7091 * tui/tui-data.h (struct tui_data_window)
7092 <first_reg_element_no_inline>: New method.
7093
3b23c5f2
TT
70942019-07-17 Tom Tromey <tom@tromey.com>
7095
7096 * tui/tui-windata.c (tui_display_data_from)
7097 (tui_data_window::do_scroll_vertical): Update.
7098 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7099 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7100 Rename from tui_line_from_reg_element_no.
7101 (tui_display_registers_from_line): Update.
7102 * tui/tui-data.h (struct tui_data_window)
7103 <line_from_reg_element_no>: New method.
7104
0b5ec218
TT
71052019-07-17 Tom Tromey <tom@tromey.com>
7106
7107 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7108 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7109 tui_last_regs_line_no.
7110 (tui_display_reg_element_at_line)
7111 (tui_display_registers_from_line): Update.
7112 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7113 method.
7114
0807ab7b
TT
71152019-07-17 Tom Tromey <tom@tromey.com>
7116
7117 PR tui/24722:
7118 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7119 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7120 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7121 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7122 (tui_update_breakpoint_info): Likewise.
7123 * tui/tui-hooks.c (tui_event_create_breakpoint)
7124 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7125 Update.
7126
9ad7fdef
TT
71272019-07-17 Tom Tromey <tom@tromey.com>
7128
7129 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7130
5813316f
TT
71312019-07-17 Tom Tromey <tom@tromey.com>
7132
7133 * tui/tui-winsource.c (tui_update_source_window_as_is)
7134 (tui_update_source_windows_with_addr): Update.
7135 * tui/tui-source.h (tui_set_source_content)
7136 (tui_show_symtab_source): Add "win_info" parameter.
7137 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7138 parameter.
7139 (tui_show_symtab_source): Likewise.
7140
00e264e7
TT
71412019-07-17 Tom Tromey <tom@tromey.com>
7142
7143 * tui/tui-wingeneral.c
7144 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7145
06210ce4
TT
71462019-07-17 Tom Tromey <tom@tromey.com>
7147
7148 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7149 (struct tui_cmd_window) <can_scroll>: New method.
7150 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7151 method.
7152
381befee
TT
71532019-07-17 Tom Tromey <tromey@adacore.com>
7154
7155 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7156 do_field_signed>: Rename. Change type of "value".
7157 * ui-out.c (ui_out::field_signed): Rename from field_int.
7158 Change type of "value".
7159 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7160 type of "value".
7161 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7162 do_field_int. Change type of "value".
7163 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7164 do_field_int. Change type of "value".
7165 * tracepoint.c (trace_status_mi, tfind_1)
7166 (print_one_static_tracepoint_marker): Update.
7167 * thread.c (print_thread_info_1, print_selected_thread_frame):
7168 Update.
7169 * stack.c (print_frame, print_frame_info): Update.
7170 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7171 Update.
7172 * source.c (print_source_lines_base): Update.
7173 * skip.c (info_skip_command): Update.
7174 * record-btrace.c (btrace_ui_out_decode_error)
7175 (btrace_call_history_src_line): Update.
7176 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7177 Update.
7178 * progspace.c (print_program_space): Update.
7179 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7180 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7181 do_field_int. Change type of "value".
7182 * mi/mi-out.c (mi_ui_out::do_table_begin)
7183 (mi_ui_out::do_table_header): Update.
7184 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7185 type of "value".
7186 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7187 (mi_cmd_data_list_changed_registers, output_register)
7188 (mi_cmd_data_read_memory, mi_load_progress)
7189 (mi_cmd_trace_frame_collected): Update.
7190 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7191 Update.
7192 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7193 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7194 (mi_cmd_var_list_children, varobj_update_one): Update.
7195 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7196 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7197 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7198 * inferior.c (print_inferior): Update.
7199 * gdb_bfd.c (print_one_bfd): Update.
7200 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7201 Update.
7202 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7203 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7204 do_field_int. Change type of "value".
7205 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7206 do_field_int. Change type of "value".
7207 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7208 (print_one_breakpoint_location, print_it_catch_fork)
7209 (print_one_catch_fork, print_it_catch_vfork)
7210 (print_one_catch_vfork, print_it_catch_solib)
7211 (print_it_catch_exec, print_it_ranged_breakpoint)
7212 (print_mention_watchpoint, print_mention_masked_watchpoint)
7213 (bkpt_print_it, update_static_tracepoint): Update.
7214 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7215 * break-catch-syscall.c (print_it_catch_syscall): Update.
7216 * ada-tasks.c (print_ada_task_info): Update.
7217 * ada-lang.c (print_it_exception, print_mention_exception):
7218 Update.
7219
6b78c3f8
AB
72202019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7221
7222 PR breakpoints/24541
7223 * gdbarch.c: Regenerate.
7224 * gdbarch.h: Regenerate.
7225 * gdbarch.sh: Adjust return type and parameter types for
7226 'stap_adjust_register'.
7227 (i386_stap_adjust_register): Adjust signature and return new
7228 register name.
7229 * stap-probe.c (stap_parse_register_operand): Adjust use of
7230 'gdbarch_stap_adjust_register'.
7231
d72a9b85
TT
72322019-07-17 Tom Tromey <tromey@adacore.com>
7233
7234 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7235 declare VEC.
7236 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7237 std::vector.
7238 (struct s390_process_info): Add initializers.
7239 (s390_add_process): Use new.
7240 (s390_linux_nat_target::low_forget_process): Use delete.
7241 (s390_linux_nat_target::low_new_fork)
7242 (s390_linux_nat_target::stopped_by_watchpoint)
7243 (s390_linux_nat_target::low_prepare_to_resume)
7244 (s390_linux_nat_target::insert_watchpoint)
7245 (s390_linux_nat_target::insert_hw_breakpoint)
7246 (s390_linux_nat_target::remove_watchpoint)
7247 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7248
206e6c58
JB
72492019-07-16 John Baldwin <jhb@FreeBSD.org>
7250
7251 * aarch64-fbsd-nat.c: Include regcache.h.
7252 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7253 argument.
7254 (aarch64_fbsd_nat_target::fetch_registers)
7255 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7256 variable.
7257 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7258
cbde90f2
JB
72592019-07-16 John Baldwin <jhb@FreeBSD.org>
7260
7261 * fbsd-nat.c: Include gdbarch.h.
7262
07128006
TT
72632019-07-15 Tom Tromey <tromey@adacore.com>
7264
7265 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7266
1f77b012
TT
72672019-07-15 Tom Tromey <tromey@adacore.com>
7268
7269 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7270 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7271 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7272 * cli-out.c (cli_ui_out::do_field_int): New method.
7273 * ui-out.c (ui_out::field_unsigned): New method.
7274 * symfile.c (generic_load): Use field_unsigned.
7275 (print_transfer_performance): Likewise.
7276 * record-btrace.c (ui_out_field_uint): Remove.
7277 (btrace_call_history_insn_range, btrace_call_history): Use
7278 field_unsigned.
7279 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7280 field_unsigned.
7281 * ui-out.h (class ui_out) <field_unsigned>: New method.
7282 <do_field_unsigned>: Likewise.
7283
33eca680
TT
72842019-07-15 Tom Tromey <tromey@adacore.com>
7285
7286 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7287 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7288 * target.c (flash_erase_command): Use field_string.
7289 * infrun.c (print_signal_received_reason): Use field_string.
7290 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7291 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7292 field_string.
7293 * ada-tasks.c (print_ada_task_info): Use field_string.
7294
ca8d69be
TT
72952019-07-15 Tom Tromey <tromey@adacore.com>
7296
7297 * target.c (flash_erase_command): Use field_core_addr.
7298 * symfile.c (generic_load): Use field_core_addr.
7299 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7300 Use field_core_addr.
7301 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7302 field_core_addr.
7303
0d4e84ed
AB
73042019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7305
7306 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7307 value if its desired type is smaller than a CORE_ADDR and signed.
7308
9a49df9d
AB
73092019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7310
7311 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7312 of changes to field names, and use new is_reference field to
7313 decide if a property is a reference or not.
7314 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7315 field.
7316 (struct dwarf2_property_baton): Update header comment, rename
7317 'referenced_type' to 'property_type' and update comments.
7318 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7319 default property type, store in property baton, update to take
7320 accound of renamed field.
7321 (read_func_scope): Update call to attr_to_dynamic_prop.
7322 (read_array_type): Likewise.
7323 (dwarf2_per_cu_addr_sized_int_type): New function.
7324 (read_subrange_index_type): Move type finding code to
7325 dwarf2_per_cu_addr_sized_int_type.
7326 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7327 (dwarf2_per_cu_addr_type): New function.
7328 (set_die_type): Update calls to attr_to_dynamic_prop.
7329
b86352cf
AB
73302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7331
7332 * dwarf2read.c (read_subrange_index_type): New function.
7333 (read_subrange_type): Move code into new function and call it.
7334 * gdbtypes.c (create_range_type): Add some asserts.
7335
603490bf
AB
73362019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7337
7338 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7339 update return statements.
7340 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7341 declaration, and update comment to match.
7342 * gdbtypes.c (resolve_dynamic_array): Update call to
7343 dwarf2_evaluate_property to match new return type.
7344
592f9d27
AB
73452019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7346
7347 * valarith.c (value_subscripted_rvalue): Change lowerbound
7348 parameter type from int to LONGEST.
7349 * value.h (value_subscripted_rvalue): Likewise in declaration.
7350
60cfcb20
AB
73512019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7352
7353 * cli/cli-utils.c (info_print_command_completer): New function.
7354 * cli/cli-utils.h: Add 'completer.h' include, and forward
7355 declaration for 'struct cmd_list_element'.
7356 (info_print_command_completer): Declare.
7357 * stack.c (_initialize_stack): Add completer for 'info locals' and
7358 'info args'.
7359 * symtab.c (_initialize_symtab): Add completer for 'info
7360 variables' and 'info functions'.
7361 * NEWS: Mention completion for additional info commands.
7362
b16507e0
AB
73632019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7364
7365 * cli/cli-utils.c (extract_info_print_args): Delete.
7366 (extract_arg_maybe_quoted): Delete.
7367 (info_print_options_defs): New variable.
7368 (make_info_print_options_def_group): New function.
7369 (extract_info_print_options): Define new function.
7370 * cli/cli-utils.h (extract_info_print_args): Delete.
7371 (struct info_print_options): New structure.
7372 (extract_info_print_options): Declare new function.
7373 * stack.c (info_locals_command): Update to use new
7374 extract_info_print_options, also add a header comment.
7375 (info_args_command): Likewise.
7376 * symtab.c (info_variables_command): Likewise.
7377 (info_functions_command): Likewise.
7378
021d8588
AB
73792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7380
7381 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7382 to extract string arguments.
7383 * common/common-utils.c (extract_string_maybe_quoted): New function.
7384 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7385
b777eb6d
TT
73862019-07-11 Tom Tromey <tromey@adacore.com>
7387
7388 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7389 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7390 * top.h (gdbinit): Don't declare.
7391 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7392 into...
7393 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7394 * top.c (gdb_init): Don't call init_cli_cmds.
7395 (gdbinit): Remove.
7396 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7397
72ee03ff
TT
73982019-07-11 Tom Tromey <tromey@adacore.com>
7399
7400 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7401 after it has been moved.
7402
00db9531
SM
74032019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7404
7405 * valops.c (value_must_coerce_to_target): Change return type to
7406 bool.
7407 * value.h (value_must_coerce_to_target): Likewise.
7408
f2478a7e
SM
74092019-07-10 Simon Marchi <simon.marchi@efficios.com>
7410
7411 * breakpoint.c (is_hardware_watchpoint): Remove
7412 forward-declaration.
7413 (is_masked_watchpoint): Change return type to bool.
7414 (is_tracepoint): Likewise.
7415 (is_breakpoint): Likewise.
7416 (is_hardware_watchpoint): Likewise.
7417 (is_watchpoint): Likewise.
7418 (is_no_memory_software_watchpoint): Likewise.
7419 (is_catchpoint): Likewise.
7420 (breakpoint_1): Make FILTER parameter's return type bool.
7421 is_masked_watchpoint): Change return type to bool.
7422 (save_breakpoints): Make FILTER parameter's return type bool.
7423 * breakpoint.h (is_breakpoint): Change return type to bool.
7424 (is_watchpoint): Likewise.
7425 (is_catchpoint): Likewise.
7426 (is_tracepoint): Likewise.
7427
0d12e84c
TT
74282019-07-10 Tom Tromey <tom@tromey.com>
7429
7430 * defs.h: Don't include gdbarch.h.
7431 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7432 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7433 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7434 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7435 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7436 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7437 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7438 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7439 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7440 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7441 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7442 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7443 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7444 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7445 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7446 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7447 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7448 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7449 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7450 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7451 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7452 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7453 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7454 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7455 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7456 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7457 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7458
f06f1252
TT
74592019-07-10 Tom Tromey <tromey@adacore.com>
7460
7461 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7462 * breakpoint.c (init_ada_exception_breakpoint): Register as
7463 bp_catchpoint.
7464 (print_one_breakpoint_location, print_one_breakpoint): Use
7465 is_ada_exception_catchpoint.
7466 * ada-lang.c (class ada_catchpoint_location): Pass
7467 bp_loc_software_breakpoint to bp_location constructor.
7468 (is_ada_exception_catchpoint): New function.
7469
7a5d944b
TT
74702019-07-10 Tom Tromey <tromey@adacore.com>
7471
7472 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7473 VEC.
7474 (struct arm_exidx_entry): New method operator<.
7475 (struct arm_exidx_data) <section_maps>: Change type.
7476 (arm_exidx_data_free): Remove.
7477 (arm_exidx_data_key): Change type. Move lower.
7478 (arm_exidx_new_objfile): Update.
7479 (arm_compare_exidx_entries): Remove.
7480 (arm_find_exidx_entry, _initialize_arm_tdep)
7481
48c66e1d
TT
74822019-07-10 Tom Tromey <tromey@adacore.com>
7483
7484 * solib-spu.c (ocl_program_data_key): Change type.
7485 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7486 Update.
7487
a269fbf1
TT
74882019-07-10 Tom Tromey <tromey@adacore.com>
7489
7490 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7491 (struct solib_aix_inferior_data) <library_list>: Change type.
7492 (solib_aix_inferior_data_handle): Change type.
7493 (get_solib_aix_inferior_data): Update.
7494 (solib_aix_free_library_list): Remove.
7495 (library_list_start_library): Update.
7496 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7497 return type.
7498 (solib_aix_get_library_list)
7499 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7500 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7501
c294730c
TT
75022019-07-10 Tom Tromey <tromey@adacore.com>
7503
7504 * solib-dsbt.c (struct dsbt_info): Add initializers.
7505 (solib_dsbt_pspace_data): Change type.
7506 (dsbt_pspace_data_cleanup): Remove.
7507 (get_dsbt_info, _initialize_dsbt_solib): Update.
7508
9d52077d
TT
75092019-07-10 Tom Tromey <tromey@adacore.com>
7510
7511 * spu-tdep.c (spu_overlay_data): Change type.
7512 (spu_get_overlay_table, spu_overlay_new_objfile)
7513 (_initialize_spu_tdep): Update.
7514
22a20dca
TT
75152019-07-10 Tom Tromey <tromey@adacore.com>
7516
7517 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7518 destructor.
7519 (dbx_objfile_data_key): Change type and declare later.
7520 (DBX_SYMFILE_INFO): Rewrite.
7521 * dbxread.c (dbx_objfile_data_key): Change type.
7522 (dbx_symfile_init): Update.
7523 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7524 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7525 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7526
cb60f420
TT
75272019-07-10 Tom Tromey <tromey@adacore.com>
7528
7529 * jit.c (jit_program_space_key): Change type. Move lower.
7530 (get_jit_program_space_data): Update.
7531 (jit_program_space_data_cleanup): Remove.
7532 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7533 Update.
7534 (struct jit_program_space_data): Add initializers.
7535
51df2ae3
TT
75362019-07-10 Tom Tromey <tromey@adacore.com>
7537
7538 * solib-darwin.c (struct darwin_info): Add initializers.
7539 (solib_darwin_pspace_data): Change type.
7540 (darwin_pspace_data_cleanup): Remove.
7541 (get_darwin_info, _initialize_darwin_solib): Update.
7542
18101a35
TT
75432019-07-10 Tom Tromey <tromey@adacore.com>
7544
7545 * remote-sim.c (struct sim_inferior_data): Add initializers,
7546 constructor, and destructor.
7547 (sim_inferior_data_key): Change type. Move lower.
7548 (check_for_duplicate_sim_descriptor): Update.
7549 (get_sim_inferior_data): Use new. Update.
7550 (~sim_inferior_data_cleanup): Rename from
7551 sim_inferior_data_cleanup. Simplify.
7552 (gdbsim_close_inferior, simulator_command)
7553 (sim_command_completer, _initialize_remote_sim): Update.
7554 (next_pid, INITIAL_PID): Move earlier.
7555
05b08ac1
TT
75562019-07-10 Tom Tromey <tromey@adacore.com>
7557
7558 * python/python-internal.h (create_thread_object): Return
7559 gdbpy_ref.
7560 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7561 * python/py-inferior.c (struct threadlist_entry): Add
7562 constructor.
7563 <thread_obj>: Now a gdbpy_ref.
7564 (thread_to_thread_object): Update.
7565 (add_thread_object): Use new.
7566 (delete_thread_object): Use delete.
7567 (infpy_threads): Update.
7568 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7569 GIL.
7570
32372d80
TT
75712019-07-10 Tom Tromey <tromey@adacore.com>
7572
7573 * valops.c (value_cast): Specialize error message for Ada.
7574
5c458ae8
SM
75752019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7576
7577 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7578
4c462cb0
SM
75792019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7580
7581 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7582 bpstat_should_step): Return bool, adjust comments.
7583 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7584 bpstat_should_step): Likewise.
7585
89abbcc2
AH
75862019-07-10 Alan Hayward <alan.hayward@arm.com>
7587
7588 * features/Makefile: Use feature target descriptions for Arm.
7589 * features/arm/arm-core.c: Generate new file.
7590 * features/arm/arm-fpa.c: Likewise.
7591 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7592 * features/arm/arm-m-profile.c: Likewise.
7593 * features/arm/arm-vfpv2.c: Likewise.
7594 * features/arm/arm-vfpv3.c: Likewise.
7595 * features/arm/xscale-iwmmxt.c: Likewise.
7596 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7597
166a82be
AH
75982019-07-10 Alan Hayward <alan.hayward@arm.com>
7599
7600 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7601 ptrace earlier.
7602
9fb4c7e9
AH
76032019-07-10 Alan Hayward <alan.hayward@arm.com>
7604
7605 * features/aarch64-pauth.c: Regenerate.
7606
e2d0f980
SM
76072019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7608
7609 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7610 bool.
7611 (bpstat_what): Use false instead of 0.
7612
a38118e5
PA
76132019-07-09 Pedro Alves <palves@redhat.com>
7614
7615 * break-catch-throw.c (is_exception_catchpoint): New.
7616 * breakpoint.c (print_one_breakpoint_location): New parameter
7617 'raw_loc'. Handle it. Use
7618 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7619 looking at the breakpoint's type.
7620 (print_one_breakpoint): If handling "maint info breakpoints", also
7621 print locations of exception catchpoints.
7622 * breakpoint.h (is_exception_catchpoint): Declare.
7623
cb1e4e32
PA
76242019-07-09 Pedro Alves <palves@redhat.com>
7625
7626 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7627 "addr" field.
7628 (allocate_location_exception_catchpoint): New.
7629 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7630 (initialize_throw_catchpoint_ops): Install
7631 allocate_location_exception_catchpoint as allocate_location
7632 method.
7633 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7634 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7635 bp_loc_other.
7636 (breakpoint_address_is_meaningful): Delete.
7637 (bl_address_is_meaningful): New.
7638 (breakpoint_locations_match): Adjust comment.
7639 (bp_location_from_bp_type): New, factored out of...
7640 (bp_location::bp_location(breakpoint *)): ... this.
7641 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7642 factored out of...
7643 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7644 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7645 breakpoint_address_is_meaningful.
7646 (bp_locations_compare): Adjust comment.
7647 (update_global_location_list): Use bl_address_is_meaningful
7648 instead of breakpoint_address_is_meaningful.
7649 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7650 explicit.
7651 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7652 * python/py-breakpoint.c (bppy_get_location): No longer check
7653 whether location is null.
7654
b58a68fe
PA
76552019-07-09 Pedro Alves <palves@redhat.com>
7656
7657 PR c++/15468
7658 * breakpoint.c (print_one_breakpoint_location): Remove
7659 single-location assert.
7660
268a13a5
TT
76612019-07-09 Tom Tromey <tom@tromey.com>
7662
7663 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7664 * configure: Rebuild.
7665 * configure.ac: Change common to gdbsupport.
7666 * gdbsupport: Rename from common.
7667 * acinclude.m4: Change common to gdbsupport.
7668 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7669 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7670 gdbsupport.
7671 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7672 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7673 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7674 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7675 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7676 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7677 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7678 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7679 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7680 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7681 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7682 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7683 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7684 coff-pe-read.c, command.h, compile/compile-c-support.c,
7685 compile/compile-c.h, compile/compile-cplus-symbols.c,
7686 compile/compile-cplus-types.c, compile/compile-cplus.h,
7687 compile/compile-loc2c.c, compile/compile.c, completer.c,
7688 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7689 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7690 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7691 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7692 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7693 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7694 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7695 features/aarch64-core.c, features/aarch64-fpu.c,
7696 features/aarch64-pauth.c, features/aarch64-sve.c,
7697 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7698 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7699 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7700 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7701 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7702 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7703 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7704 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7705 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7706 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7707 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7708 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7709 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7710 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7711 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7712 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7713 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7714 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7715 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7716 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7717 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7718 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7719 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7720 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7721 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7722 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7723 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7724 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7725 minsyms.c, mips-linux-tdep.c, namespace.h,
7726 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7727 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7728 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7729 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7730 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7731 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7732 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7733 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7734 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7735 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7736 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7737 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7738 procfs.c, producer.c, progspace.h, psymtab.h,
7739 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7740 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7741 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7742 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7743 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7744 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7745 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7746 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7747 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7748 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7749 target-memory.c, target.c, target.h, target/waitstatus.c,
7750 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7751 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7752 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7753 unittests/array-view-selftests.c,
7754 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7755 unittests/common-utils-selftests.c,
7756 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7757 unittests/format_pieces-selftests.c,
7758 unittests/function-view-selftests.c,
7759 unittests/lookup_name_info-selftests.c,
7760 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7761 unittests/mkdir-recursive-selftests.c,
7762 unittests/observable-selftests.c,
7763 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7764 unittests/parse-connection-spec-selftests.c,
7765 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7766 unittests/scoped_fd-selftests.c,
7767 unittests/scoped_mmap-selftests.c,
7768 unittests/scoped_restore-selftests.c,
7769 unittests/string_view-selftests.c, unittests/style-selftests.c,
7770 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7771 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7772 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7773 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7774 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7775 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7776
5b0e2db4
AB
77772019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7778
7779 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7780 bool value.
7781 (decode_digits_ordinary): Set explicit_line field in sal.
7782 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7783 symtab_and_line that was set on an explicit line number in
7784 assembler code. Do always update the recorded symtab and line if
7785 we do skip the prologue.
7786
0ba852ab
AB
77872019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7788
7789 * breakpoint.c (set_breakpoint_location_function): Remove
7790 explicit_loc parameter.
7791 (momentary_breakpoint_from_master): Update call to
7792 set_breakpoint_location_function.
7793 (add_location_to_breakpoint): Likewise.
7794
b3a7d171
AB
77952019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7796
7797 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7798 required features based on default bfd type when no specific bfd
7799 is present.
7800
1f6f6e21
PW
78012019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7802
7803 * NEWS: Mention that GDB printf and eval commands can now print
7804 C-style and Ada-style convenience var strings without
7805 calling the inferior.
7806 * printcmd.c (printf_c_string): Locally print GDB internal var
7807 instead of transiting via the inferior.
7808 (printf_wide_c_string): Likewise.
7809
78102019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7811
5862c886 7812 PR breakpoints/25011
ea142fbf
AH
7813 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7814
0598af48
TT
78152019-07-04 Tom Tromey <tom@tromey.com>
7816
7817 PR tui/24724:
7818 * tui/tui-winsource.c (tui_clear_source_content): Update.
7819 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7820 (tui_update_breakpoint_info): Update.
7821 (tui_set_exec_info_content): Update.
7822 * tui/tui-source.c (tui_set_source_content_nil): Update.
7823 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7824 has_break.
7825 * tui/tui-data.h (enum tui_bp_flag): New.
7826 (tui_bp_flags): New enum flags type.
7827 (struct tui_source_element) <break_mode>: Change type. Rename
7828 from has_break.
7829 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7830 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7831 constants.
7832 * tui/tui-winsource.h: Fix comment.
7833
350fab54
AH
78342019-07-04 Alan Hayward <alan.hayward@arm.com>
7835
7836 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7837 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7838 (store_fpregs_to_thread)
7839 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7840 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7841 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7842 (IWMMXT_REGS_SIZE): Add define.
7843 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7844 (fetch_vfp_regs, store_vfp_regs)
7845 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7846 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7847
f0452268
AH
78482019-07-04 Alan Hayward <alan.hayward@arm.com>
7849
7850 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7851 defines.
7852 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7853 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7854 (ARM_INT_REGISTER_SIZE): ...to this.
7855 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7856 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7857 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7858 (arm_linux_collect_gregset, supply_nwfpe_register)
7859 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7860 defines.
7861 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7862 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7863 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7864 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7865 (arm_return_in_memory, arm_store_return_value)
7866 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7867 (arm_record_ld_st_multiple): Likewise.
7868 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7869 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7870
e935475c
AH
78712019-07-04 Alan Hayward <alan.hayward@arm.com>
7872
7873 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7874 AARCH64_DISPLACED_MODIFIED_INSNS.
7875 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7876 (aarch64_displaced_step_copy_insn): Likewise.
7877 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7878 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7879 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7880 ARM_DISPLACED_MODIFIED_INSNS.
7881 * arm-tdep.c (arm_gdbarch_init): Likewise.
7882 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7883 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7884 (struct arm_displaced_step_closure): Use
7885 ARM_DISPLACED_MODIFIED_INSNS.
7886
df0bb381
AH
78872019-07-04 Alan Hayward <alan.hayward@arm.com>
7888
7889 * features/Makefile: Remove unused xml files.
7890 * features/aarch64.xml: Remove.
7891 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7892 * features/i386/amd64-avx-avx512.xml: Remove.
7893 * features/i386/amd64-avx-linux.xml: Remove.
7894 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7895 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7896 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7897 * features/i386/amd64-avx-mpx.xml: Remove.
7898 * features/i386/amd64-avx.xml: Remove.
7899 * features/i386/amd64-linux.xml: Remove.
7900 * features/i386/amd64-mpx-linux.xml: Remove.
7901 * features/i386/amd64-mpx.xml: Remove.
7902 * features/i386/amd64.xml: Remove.
7903 * features/i386/i386-avx-avx512-linux.xml: Remove.
7904 * features/i386/i386-avx-avx512.xml: Remove.
7905 * features/i386/i386-avx-linux.xml: Remove.
7906 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7907 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7908 * features/i386/i386-avx-mpx-linux.xml: Remove.
7909 * features/i386/i386-avx-mpx.xml: Remove.
7910 * features/i386/i386-avx.xml: Remove.
7911 * features/i386/i386-linux.xml: Remove.
7912 * features/i386/i386-mmx-linux.xml: Remove.
7913 * features/i386/i386-mmx.xml: Remove.
7914 * features/i386/i386-mpx-linux.xml: Remove.
7915 * features/i386/i386-mpx.xml: Remove.
7916 * features/i386/i386.xml: Remove.
7917 * features/i386/x32-avx-avx512-linux.xml: Remove.
7918 * features/i386/x32-avx-linux.xml: Remove.
7919 * features/i386/x32-linux.xml: Remove.
7920
edd6266a
AH
79212019-07-04 Alan Hayward <alan.hayward@arm.com>
7922
7923 * regformats/aarch64.dat: Remove.
7924 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7925 * regformats/i386/amd64-avx-linux.dat: Remove.
7926 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7927 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7928 * regformats/i386/amd64-linux.dat: Remove.
7929 * regformats/i386/amd64-mpx-linux.dat: Remove.
7930 * regformats/i386/amd64.dat: Remove.
7931 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7932 * regformats/i386/i386-avx-linux.dat: Remove.
7933 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7934 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7935 * regformats/i386/i386-linux.dat: Remove.
7936 * regformats/i386/i386-mmx-linux.dat: Remove.
7937 * regformats/i386/i386-mpx-linux.dat: Remove.
7938 * regformats/i386/i386.dat: Remove.
7939 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7940 * regformats/i386/x32-avx-linux.dat: Remove.
7941 * regformats/i386/x32-linux.dat: Remove.
7942
2b40fda7
AH
79432019-07-04 Alan Hayward <alan.hayward@arm.com>
7944
7945 * aarch64-tdep.c: Remove xml self tests.
7946 * amd64-linux-tdep.c: Likewise.
7947 * amd64-tdep.c: Likewise.
7948 * i386-linux-tdep.c: Likewise.
7949 * i386-tdep.c: Likewise.
7950
5f4ba3e7
PA
79512019-07-03 Pedro Alves <palves@redhat.com>
7952
7953 PR cli/24732
7954 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7955 (pipe_cmd_option_defs): New.
7956 (make_pipe_cmd_options_def_group): New.
7957 (pipe_command): Use gdb::option::process_options.
7958 (pipe_command_completer): New function.
7959 (_initialize_cli_cmds): Install completer for "pipe" command.
7960
3d9be6f5
PA
79612019-07-03 Pedro Alves <palves@redhat.com>
7962
7963 * cli/cli-option.c (union option_value) <string>: New field.
7964 (struct option_def_and_value): Add ctor, move ctor, dtor and
7965 use DISABLE_COPY_AND_ASSIGN.
7966 (option_def_and_value::clear_value): New.
7967 (parse_option, save_option_value_in_ctx, get_val_type_str)
7968 (add_setshow_cmds_for_options): Handle var_string.
7969 * cli-option.h (union option_def::var_address) <string>: New
7970 field.
7971 (struct string_option_def): New.
7972 * maint-test-options.c (struct test_options_opts): Add default
7973 ctor and use DISABLE_COPY_AND_ASSIGN.
7974 <string_opt>: New field.
7975 (test_options_opts::~test_options_opts): New.
7976 (test_options_opts::dump): Also dump "-string".
7977 (test_options_option_defs): Install "string.
7978
41fc454c
PA
79792019-07-03 Pedro Alves <palves@redhat.com>
7980
7981 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7982 option_value with a null enumeration.
7983 (complete_options): Save the option values in the context.
7984 (save_option_value_in_ctx): New, factored out from ...
7985 (process_options): ... here.
7986 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7987 of the function.
7988 * maint-test-options.c (test_options_opts::dump): New, factored
7989 out from ...
7990 (maintenance_test_options_command_mode): ... here.
7991 (maintenance_test_options_command_completion_result): Delete.
7992 (maintenance_test_options_command_completion_text): Update
7993 comment.
7994 (maintenance_show_test_options_completion_result): Change
7995 prototype. Just print
7996 maintenance_test_options_command_completion_text.
7997 (save_completion_result): New.
7998 (maintenance_test_options_completer_mode): Pass options context to
7999 complete_options, and then save a dump.
8000 (_initialize_maint_test_options): Use add_cmd to install "maint
8001 show test-options-completion-result".
8002
fdbc9870
PA
80032019-07-03 Pedro Alves <palves@redhat.com>
8004
8005 * NEWS (New commands): Mention "with" and "maint with".
8006 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8007 (with_command, with_command_completer): New.
8008 (pipe_command): Adjust to new repeat_previous
8009 interface.
8010 (_initialize_cli_cmds): Install the "with" command and its "w"
8011 alias.
8012 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8013 declarations.
8014 * cli/cli-setshow.c (parse_cli_var_uinteger)
8015 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8016 argument strings for all var_types.
8017 (get_setshow_command_value_string): New, factored out from ...
8018 (do_show_command): ... this.
8019 * cli/cli-setshow.h: Include <string>.
8020 (get_setshow_command_value_string): Declare.
8021 * command.h (repeat_previous): Now returns const char *. Adjust
8022 comment.
8023 * maint.c: Include "cli/cli-cmds.h".
8024 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8025 (_initialize_maint_cmds): Register the "maintenance with" command.
8026 * top.c (repeat_previous): Move bits from pipe_command here:
8027 Return the saved command line, if any; error out if there's no
8028 command to relaunch.
8029
c6ac8931
PA
80302019-07-03 Pedro Alves <palves@redhat.com>
8031
8032 * NEWS (New commands): Mention "maint set/show test-settings"
8033 instead of "maint test-settings".
8034 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8035 (maintenance_test_settings_set_list): Rename to ...
8036 (maintenance_set_test_settings_list): ... this.
8037 (maintenance_test_settings_show_list): Rename to ...
8038 (maintenance_show_test_settings_list): ... this.
8039 (maintenance_test_settings_cmd): Delete.
8040 (maintenance_test_settings_set_cmd): ...
8041 (maintenance_set_test_settings_cmd): ... this.
8042 (maintenance_test_settings_show_cmd): ...
8043 (maintenance_show_test_settings_cmd): ... this.
8044 (maintenance_test_settings_show_value_cmd):
8045 (maintenance_show_test_settings_value_cmd): ... this.
8046 (_initialize_maint_test_settings): No longer install the "maint
8047 test-settings" prefix command. Rename "maint test-settings set"
8048 to "maint set test-settings", and "maint test-settings show" to
8049 "maint show test-settings". Adjust all subcommands.
8050
d1fcf2fd
PA
80512019-07-03 Pedro Alves <palves@redhat.com>
8052
8053 * maint-test-settings.c: Fix file's intro comment. Replace all
8054 references to "test-options" with references to "test-settings",
8055 in comments.
8056
970f9d09
PA
80572019-07-03 Pedro Alves <palves@redhat.com>
8058
8059 * maint-test-settings.c (maintenance_test_settings_xxx)
8060 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8061 New.
8062 (maintenance_test_settings_enums): Use them.
8063 (maintenance_test_settings_enum): Default to
8064 maintenance_test_settings_xxx.
8065 (_initialize_maint_test_settings): Initialize
8066 MAINTENANCE_TEST_SETTINGS_FILENAME.
8067
f3869b1a
SM
80682019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8069
8070 * breakpoint.h (remove_breakpoints_inf): Change return type to
8071 void, move function documentation here.
8072 * breakpoint.c (remove_breakpoints_inf): Change return type to
8073 void, move function documentation to header.
8074
54d66006
PA
80752019-07-02 Pedro Alves <palves@redhat.com>
8076
8077 * NEWS (Completion improvements): Mention "info threads".
8078 * thread.c (struct info_threads_opts, info_threads_option_defs)
8079 (make_info_threads_options_def_group): New.
8080 (info_threads_command): Use gdb::option::process_options.
8081 (info_threads_command_completer): New.
8082 (_initialize_thread): Use gdb::option::build_help to build the
8083 help text for "info threads".
8084
854f6088
SM
80852019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8086
8087 * defs.h (generic_load): Move from here...
8088 * symfile.h (generic_load): ... to here. Rename name parameter
8089 to args.
8090 * symfile.c (generic_load): Add comment.
8091
54ee4252
TT
80922019-07-01 Tom Tromey <tromey@adacore.com>
8093
8094 * dwarf2read.c
8095 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8096 declaration of without_params. Fix formatting.
8097
65392b3e
TT
80982019-07-01 Tom Tromey <tromey@adacore.com>
8099
8100 * ada-exp.y (find_primitive_type): Update.
8101 * ada-lang.h (ada_lookup_symbol): Update.
8102 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8103 parameter.
8104 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8105
7d7571f0
SDJ
81062019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8107
8108 PR breakpoints/24541
8109 * gdbarch.c: Regenerate.
8110 * gdbarch.h: Regenerate.
8111 * gdbarch.sh: Add 'stap_adjust_register'.
8112 * i386-tdep.c: Include '<unordered_set>'.
8113 (i386_stap_adjust_register): New function.
8114 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8115 * stap-probe.c (stap_parse_register_operand): Call
8116 'gdbarch_stap_adjust_register'.
8117
5af5392a
SDJ
81182019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8119
8120 PR python/24742
8121 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8122 * python/python.c (do_start_initialization): Use 'xmalloc'
8123 instead of 'PyMem_Malloc'.
8124
10d06d82
TT
81252019-06-28 Tom Tromey <tromey@adacore.com>
8126
8127 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8128 for Ada.
8129
1b7f24cd
TT
81302019-06-27 Tom Tromey <tromey@adacore.com>
8131
8132 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8133 objfile_key.
8134 (arm_find_mapping_symbol, arm_record_special_symbol)
8135 (_initialize_arm_tdep): Update.
8136 (arm_objfile_data_free): Remove.
8137
3d507ff2
TT
81382019-06-27 Tom Tromey <tromey@adacore.com>
8139
8140 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8141 to cp_print_static_field.
8142
762c164d
TT
81432019-06-26 Tom Tromey <tromey@adacore.com>
8144
8145 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8146 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8147 declare.
8148
aa2f9bcf
AH
81492019-06-26 Alan Hayward <alan.hayward@arm.com>
8150
8151 * features/aarch64-core.c (create_feature_aarch64_core):
8152 Regenerate.
8153 * features/aarch64-core.xml: Add cpsr flags.
8154
3426ae57
AH
81552019-06-26 Alan Hayward <alan.hayward@arm.com>
8156
8157 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8158 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8159
4838e44c
SM
81602019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8161
8162 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8163 field.
8164 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8165 use.
8166 (arm_record_special_symbol): Don't insert new symbol in sorted
8167 position, push it at the end.
8168
54cc7474
SM
81692019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8170
8171 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8172 (arm_mapping_symbol_s): Remove.
8173 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8174 (arm_mapping_symbol_vec): New typedef.
8175 (struct arm_per_objfile): Add constructor.
8176 <section_maps>: Change type to
8177 std::unique_ptr<arm_mapping_symbol_vec[]>.
8178 (arm_compare_mapping_symbols): Remove.
8179 (arm_find_mapping_symbol): Adjust to section_maps type change.
8180 (arm_objfile_data_free): Call delete on arm_per_objfile.
8181 (arm_record_special_symbol): Adjust to section_maps type change.
8182 Allocate arm_per_objfile with new.
8183
b65b566c
PW
81842019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8185
8186 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8187 with the command prefix.
8188
c2fc64f5
TT
81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8192 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8193
fb54fa76
TT
81942019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8197 type.
8198 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8199 protected.
8200
f7952c57
TT
82012019-06-25 Tom Tromey <tom@tromey.com>
8202
8203 * tui/tui-winsource.c
8204 (tui_source_window_base::set_is_exec_point_at): Add check against
8205 LOA_ADDRESS.
8206
17568d78
TT
82072019-06-25 Tom Tromey <tom@tromey.com>
8208
8209 * tui/tui-source.c (tui_set_source_content): Don't check before
8210 xfree.
8211 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8212
53e7cdba
TT
82132019-06-25 Tom Tromey <tom@tromey.com>
8214
8215 * tui/tui-winsource.h (tui_update_source_window_as_is)
8216 (tui_alloc_source_buffer, tui_line_is_displayed)
8217 (tui_addr_is_displayed): Change type of win_info.
8218 * tui/tui-winsource.c (tui_update_source_window_as_is)
8219 (tui_clear_source_content, tui_show_source_line)
8220 (tui_show_source_content, tui_source_window_base::refill)
8221 (tui_source_window_base::set_is_exec_point_at)
8222 (tui_source_window_base::set_is_exec_point_at)
8223 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8224 (tui_alloc_source_buffer, tui_line_is_displayed)
8225 (tui_addr_is_displayed): Change type of win_info. Update.
8226 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8227 (tui_source_window_base::do_make_visible_with_new_height):
8228 Update.
8229 * tui/tui-source.c (tui_set_source_content)
8230 (tui_set_source_content_nil)
8231 (tui_source_window::do_scroll_vertical): Update.
8232 * tui/tui-layout.c (show_layout): Update.
8233 * tui/tui-disasm.c (tui_set_disassem_content)
8234 (tui_disasm_window::do_scroll_vertical): Update.
8235 * tui/tui-data.h (tui_win_content): Remove.
8236 (struct tui_gen_win_info) <content, content_size>: Remove.
8237 (struct tui_source_element): Add initializers and destructor.
8238 (union tui_which_element, struct tui_win_element): Remove.
8239 (struct tui_source_window_base) <content>: New field.
8240 (struct tui_data_window): Remove destructor.
8241 (tui_alloc_content, tui_free_win_content)
8242 (tui_free_all_source_wins_content): Don't declare.
8243 * tui/tui-data.c (tui_initialize_static_data): Update.
8244 (init_content_element, tui_alloc_content): Remove.
8245 (~tui_gen_win_info): Update.
8246 (~tui_data_window, tui_free_all_source_wins_content)
8247 (tui_free_win_content, free_content, free_content_elements):
8248 Remove.
8249
7908abbf
TT
82502019-06-25 Tom Tromey <tom@tromey.com>
8251
8252 * tui/tui-winsource.h (tui_clear_source_content)
8253 (tui_erase_source_content, tui_show_source_content): Change type
8254 of win_info.
8255 * tui/tui-winsource.c (tui_clear_source_content)
8256 (tui_erase_source_content, tui_show_source_content): Change type
8257 of win_info.
8258 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8259 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8260 win_info.
8261 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8262 win_info.
8263 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8264
02c28df0
TT
82652019-06-25 Tom Tromey <tom@tromey.com>
8266
8267 * tui/tui-winsource.c (tui_clear_source_content)
8268 (tui_source_window_base::set_is_exec_point_at): Update.
8269 * tui/tui-source.c (tui_set_source_content_nil): Update.
8270 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8271 a bool.
8272 * tui/tui-data.c (init_content_element): Update.
8273
6658b1bf
TT
82742019-06-25 Tom Tromey <tom@tromey.com>
8275
8276 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8277 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8278 * tui/tui-layout.c (init_and_make_win): Update.
8279 * tui/tui.h (enum tui_win_type): Update.
8280 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8281 tui_win_is_auxillary.
8282 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8283 tui_win_is_auxillary.
8284
21e1c91e
TT
82852019-06-25 Tom Tromey <tom@tromey.com>
8286
8287 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8288 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8289 (tui_delete_data_content_windows, tui_display_all_data)
8290 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8291 Update.
8292 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8293 * tui/tui-regs.c (tui_last_regs_line_no)
8294 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8295 (tui_show_registers): Update.
8296 (tui_show_register_group): Return void. Update.
8297 (tui_display_registers_from, tui_display_reg_element_at_line)
8298 (tui_display_registers_from_line, tui_check_register_values):
8299 Update.
8300 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8301 member.
8302 (struct tui_data_window) <regs_content>: Now a std::vector.
8303 <regs_content_count>: Remove.
8304 (tui_add_content_elements, tui_free_data_content): Don't declare.
8305 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8306 (init_content_element): Remove DATA_WIN case. Add assert.
8307 (tui_add_content_elements): Remove.
8308 (tui_data_window): Update.
8309 (tui_free_data_content): Remove.
8310 (free_content_elements): Remove DATA_WIN case.
8311
115ac53b
TT
83122019-06-25 Tom Tromey <tom@tromey.com>
8313
8314 * tui/tui-data.c (tui_data_item_window): Update.
8315 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8316 * tui/tui-windata.c (tui_display_all_data)
8317 (tui_display_data_from_line): Update.
8318 (tui_check_data_values): Remove.
8319 * tui/tui-regs.c (tui_show_register_group)
8320 (tui_display_reg_element_at_line): Update.
8321 * tui/tui-hooks.c (tui_register_changed)
8322 (tui_refresh_frame_and_register_information): Call
8323 tui_check_register_values.
8324 * tui/tui-data.h (struct tui_data_window) <data_content,
8325 data_content_count, data_type>: Remove.
8326 (enum tui_data_type): Remove.
8327
8328 * tui/tui-data.c (tui_data_window::clear_detail)
8329 (~tui_data_window): Update.
8330
eaf9738b
TT
83312019-06-25 Tom Tromey <tom@tromey.com>
8332
8333 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8334 declare.
8335 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8336 Rename from tui_first_data_item_displayed. Update.
8337 (tui_data_window::refresh_all)
8338 (tui_data_window::do_scroll_vertical): Update.
8339 * tui/tui-data.h (struct tui_data_window)
8340 <first_data_item_displayed>: Declare new method.
8341
31ca4723
TT
83422019-06-25 Tom Tromey <tom@tromey.com>
8343
8344 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8345 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8346 contents...
8347 (tui_initialize_static_data): ...here.
8348
41bcff7f
TT
83492019-06-25 Tom Tromey <tom@tromey.com>
8350
8351 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8352 (tui_display_registers_from, tui_check_register_values): Update.
8353 (tui_display_register): Remove win_info parameter; update.
8354 (tui_get_register): Change type of parameters.
8355 * tui/tui-data.h (struct tui_data_element): Remove.
8356 (union tui_which_element) <data>: Remove.
8357 <data_window>: Change type.
8358 (struct tui_data_item_window): New.
8359 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8360 case. Add assert.
8361 (~tui_data_item_window): New destructor.
8362 (free_content_elements): Remove DATA_ITEM_WIN case.
8363
d2802c33
TT
83642019-06-25 Tom Tromey <tom@tromey.com>
8365
8366 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8367 Remove.
8368
dd835f8b
TT
83692019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-data.h (struct tui_command_element): Remove.
8372 (union tui_which_element) <command>: Remove.
8373 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8374 assert.
8375 (free_content_elements): Remove CMD_WIN case.
8376
bd7db367
TT
83772019-06-25 Tom Tromey <tom@tromey.com>
8378
8379 * tui/tui-layout.c (tui_set_layout): Update.
8380 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8381 * tui/tui-data.c (layout_def): Update.
8382
3add462f
TT
83832019-06-25 Tom Tromey <tom@tromey.com>
8384
8385 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8386 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8387 (tui_source_window_base::set_new_height): Update.
8388 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8389 Update.
8390 (tui_set_locator_fullname, tui_set_locator_info)
8391 (tui_show_frame_info): Update.
8392 * tui/tui-source.c (tui_set_source_content)
8393 (tui_source_is_displayed): Update.
8394 * tui/tui-layout.c (show_source_disasm_command, show_data)
8395 (show_source_or_disasm_and_command): Update.
8396 * tui/tui-disasm.c (tui_set_disassem_content)
8397 (tui_get_begin_asm_address): Update.
8398 * tui/tui-data.h (struct tui_locator_element): Remove.
8399 (union tui_which_element) <locator>: Remove.
8400 (struct tui_locator_window): New.
8401 (tui_locator_win_info_ptr): Change return type.
8402 * tui/tui-data.c (_locator): Change type.
8403 (tui_locator_win_info_ptr): Change return type.
8404 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8405 (tui_alloc_content): Add assert.
8406
489e9d8b
TT
84072019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-winsource.c
8410 (tui_exec_info_window::maybe_allocate_content): New method.
8411 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8412 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8413 (make_source_or_disasm_window): Add cast.
8414 * tui/tui-data.h (union tui_which_element) <simple_string>:
8415 Remove.
8416 (struct tui_source_info): New.
8417 (struct tui_source_window_base) <execution_info>: Change type.
8418 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8419 case, and add assert.
8420 (tui_alloc_content): Add assert.
8421
c3fabb7d
TT
84222019-06-25 Tom Tromey <tom@tromey.com>
8423
8424 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8425 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8426 * tui/tui-data.c (tui_alloc_win_info): Remove.
8427
bbc228ee
TT
84282019-06-25 Tom Tromey <tom@tromey.com>
8429
8430 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8431 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8432 can_highlight.
8433
5fcee43a
TT
84342019-06-25 Tom Tromey <tom@tromey.com>
8435
8436 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8437 make_visible_with_new_height method.
8438 (tui_win_info::make_visible_with_new_height): New method.
8439 (tui_source_window_base::do_make_visible_with_new_height)
8440 (tui_data_window::do_make_visible_with_new_height)
8441 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8442 (make_visible_with_new_height): Remove.
8443 (tui_resize_all, tui_adjust_win_heights): Use
8444 make_visible_with_new_height method.
8445 * tui/tui-data.h (struct tui_win_info)
8446 <do_make_visible_with_new_height, make_visible_with_new_height>:
8447 New methods.
8448 (struct tui_source_window_base, struct tui_data_window)
8449 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8450 methods.
8451
d83f1fe6
TT
84522019-06-25 Tom Tromey <tom@tromey.com>
8453
8454 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8455 method.
8456 (update_tab_width): Call update_tab_width method.
8457 * tui/tui-data.h (struct tui_win_info)
8458 (struct tui_source_window_base) <update_tab_width>: New methods.
8459
17374de4
TT
84602019-06-25 Tom Tromey <tom@tromey.com>
8461
8462 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8463 parameter.
8464 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8465 parameter.
8466 (tui_gen_win_info::make_visible): Update.
8467 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8468 parameter.
8469 * tui/tui-data.h (enum tui_box): New enum.
8470 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8471
f936bca2
TT
84722019-06-25 Tom Tromey <tom@tromey.com>
8473
8474 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8475 init_and_make_win for EXEC_INFO_WIN.
8476 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8477 longer inline.
8478 (struct tui_win_info) <~tui_win_info>: Inline.
8479 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8480 Don't declare.
8481 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8482 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8483 Remove.
8484 (tui_initialize_static_data): Update.
8485 (~tui_gen_win_info): Handle more cleanup here.
8486 (~tui_source_window_base): Delete "execution_info".
8487 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8488
d6ba6a11
TT
84892019-06-25 Tom Tromey <tom@tromey.com>
8490
8491 * tui/tui-layout.c (make_command_window): Don't set
8492 can_highlight.
8493 (show_source_disasm_command): Call the reset method.
8494 (show_data): Don't set can_highlight. Call the reset method.
8495 (tui_gen_win_info::reset): Rename from init_gen_win_info
8496 (init_and_make_win): Simplify. Return tui_gen_win_info.
8497 (show_source_or_disasm_and_command): Call the reset method.
8498 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8499 (struct tui_cmd_window): Set can_highlight.
8500
48a3bd16
TT
85012019-06-25 Tom Tromey <tom@tromey.com>
8502
8503 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8504 from make_visible.
8505 (tui_make_visible, tui_make_invisible): Rewrite.
8506 (tui_win_info::make_visible): Remove.
8507 (tui_source_window_base::make_visible): Update.
8508 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8509 method. Moved from...
8510 (struct tui_win_info) <make_visible>: ...here.
8511
c3bd716f
TT
85122019-06-25 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-winsource.c
8515 (tui_source_window_base::do_scroll_horizontal): Remove direction
8516 parameter.
8517 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8518 direction parameter.
8519 * tui/tui-win.c (tui_win_info::forward_scroll)
8520 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8521 (tui_win_info::right_scroll): Update.
8522 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8523 direction parameter.
8524 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8525 direction parameter.
8526 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8527 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8528 Remove direction parameter.
8529 (struct tui_source_window_base, struct tui_source_window)
8530 (struct tui_disasm_window, struct tui_data_window)
8531 (struct tui_cmd_window): Update.
8532
21c32dca
TT
85332019-06-25 Tom Tromey <tom@tromey.com>
8534
8535 * tui/tui-winsource.h (tui_set_exec_info_content)
8536 (tui_show_exec_info_content, tui_erase_exec_info_content)
8537 (tui_clear_exec_info_content, tui_update_exec_info): Change
8538 argument to tui_source_window_base.
8539 * tui/tui-winsource.c (tui_set_exec_info_content)
8540 (tui_show_exec_info_content, tui_erase_exec_info_content)
8541 (tui_clear_exec_info_content, tui_update_exec_info): Change
8542 argument to tui_source_window_base.
8543
73fbdc65
TT
85442019-06-25 Tom Tromey <tom@tromey.com>
8545
8546 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8547 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8548
33325343
TT
85492019-06-25 Tom Tromey <tom@tromey.com>
8550
8551 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8552 check.
8553
29d2c474
TT
85542019-06-25 Tom Tromey <tom@tromey.com>
8555
8556 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8557 type to void.
8558 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8559 type to void.
8560 * tui/tui-source.c (tui_set_source_content): Update.
8561 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8562
152f3f4b
TT
85632019-06-25 Tom Tromey <tom@tromey.com>
8564
8565 * tui/tui-win.c (window_name_completer, tui_set_focus)
8566 (tui_all_windows_info): Use name method.
8567 * tui/tui-data.h (struct tui_gen_win_info)
8568 (struct tui_source_window, struct tui_disasm_window)
8569 (struct tui_data_window, struct tui_cmd_window) <name>: New
8570 method.
8571 (tui_win_name): Don't declare.
8572 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8573 (tui_win_name): Remove.
8574
be4da588
TT
85752019-06-25 Tom Tromey <tom@tromey.com>
8576
8577 * tui/tui-winsource.h (tui_update_source_window)
8578 (tui_update_source_window_as_is): Change parameter type.
8579 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8580 to be a tui_source_window_base.
8581 (tui_update_source_window_as_is): Likewise.
8582 * tui/tui-win.c (make_visible_with_new_height): Update.
8583
5b81daba
TT
85842019-06-25 Tom Tromey <tom@tromey.com>
8585
8586 * tui/tui-winsource.c (tui_erase_source_content)
8587 (tui_show_source_content, tui_show_exec_info_content)
8588 (tui_erase_exec_info_content): Use refresh_window method.
8589 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8590 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8591 from tui_refresh_win.
8592 (tui_data_window::refresh_window): New method.
8593 (tui_win_info::refresh, tui_source_window_base::refresh)
8594 (tui_refresh_all): Use refresh_window method.
8595 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8596 method.
8597 * tui/tui-regs.c (tui_display_register): Call refresh_window
8598 method.
8599 * tui/tui-layout.c (show_source_disasm_command)
8600 (show_source_or_disasm_and_command): Call refresh_window method.
8601 * tui/tui-data.h (struct tui_gen_win_info)
8602 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8603 New method.
8604
cb2ce893
TT
86052019-06-25 Tom Tromey <tom@tromey.com>
8606
8607 * tui/tui.c (tui_rl_other_window, tui_enable)
8608 (tui_is_window_visible, tui_get_command_dimension): Update.
8609 * tui/tui-winsource.c (tui_update_source_window_as_is)
8610 (tui_clear_source_content, tui_erase_source_content)
8611 (tui_show_source_line, tui_source_window_base::refill)
8612 (tui_source_window_base::do_scroll_horizontal)
8613 (tui_source_window_base::set_is_exec_point_at)
8614 (tui_update_breakpoint_info, tui_set_exec_info_content)
8615 (tui_alloc_source_buffer, tui_line_is_displayed)
8616 (tui_addr_is_displayed): Update.
8617 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8618 (tui_check_and_display_highlight_if_needed)
8619 (tui_win_info::make_visible, tui_win_info::refresh)
8620 (tui_refresh_all): Update.
8621 * tui/tui-windata.c (tui_first_data_item_displayed)
8622 (tui_delete_data_content_windows, tui_erase_data_content)
8623 (tui_display_all_data, tui_data_window::refresh_all)
8624 (tui_check_data_values): Update.
8625 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8626 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8627 (tui_win_info::backward_scroll, tui_refresh_all_win)
8628 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8629 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8630 (tui_source_window_base::set_new_height)
8631 (tui_data_window::set_new_height)
8632 (make_invisible_and_set_new_height)
8633 (make_visible_with_new_height, new_height_ok)
8634 (parse_scrolling_args): Update.
8635 * tui/tui-stack.c (tui_show_frame_info): Update.
8636 * tui/tui-source.c (tui_set_source_content)
8637 (tui_set_source_content_nil, tui_source_is_displayed)
8638 (tui_source_window::do_scroll_vertical): Update.
8639 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8640 (tui_display_registers_from, tui_display_reg_element_at_line)
8641 (tui_check_register_values, tui_reg_command): Update.
8642 * tui/tui-layout.c (tui_default_win_height)
8643 (show_source_disasm_command, show_data, init_and_make_win)
8644 (show_source_or_disasm_and_command): Update.
8645 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8646 (tui_redisplay_readline, tui_mld_flush)
8647 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8648 (tui_getc): Update.
8649 * tui/tui-disasm.c (tui_set_disassem_content)
8650 (tui_disasm_window::do_scroll_vertical): Update.
8651 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8652 Now virtual.
8653 (struct tui_win_info): Derive from tui_gen_win_info.
8654 <~tui_win_info>: Mark as override.
8655 <generic>: Remove member.
8656 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8657 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8658 (~tui_data_window, ~tui_win_info)
8659 (tui_free_all_source_wins_content): Update.
8660 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8661
ab313b35
TT
86622019-06-25 Tom Tromey <tom@tromey.com>
8663
8664 * tui/tui-layout.c (init_and_make_win): Use new.
8665 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8666 destructor, initializers.
8667 (tui_alloc_generic_win_info): Don't declare.
8668 * tui/tui-data.c (_locator): Add argument to constructor.
8669 (source_win, disasm_win): New globals.
8670 (exec_info): Remove.
8671 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8672 Update.
8673 (tui_alloc_generic_win_info): Remove.
8674 (init_content_element): Use new.
8675 (tui_win_info::tui_win_info): Update.
8676 (free_content_elements) <case DATA_WIN>: Use delete.
8677
dc2c33e4
TT
86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8681 * tui/tui-windata.c (tui_first_data_item_displayed)
8682 (tui_delete_data_content_windows): Update.
8683 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8684 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8685 (tui_display_registers_from, tui_check_register_values): Update.
8686 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8687 pointer.
8688 * tui/tui-data.c (init_content_element): Update. Allocate the new
8689 window.
8690 (tui_free_data_content): Update.
8691 (free_content_elements) <case DATA_WIN>: Free the window.
8692
214a5cbe
TT
86932019-06-25 Tom Tromey <tom@tromey.com>
8694
8695 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8696 Update.
8697 * tui/tui-layout.c (make_command_window)
8698 (show_source_disasm_command, show_data, init_and_make_win)
8699 (show_source_or_disasm_and_command): Update.
8700 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8701 method.
8702 <can_highight, is_highlighted>: Now bool.
8703 (tui_set_win_highlight): Don't declare.
8704 * tui/tui-data.c (tui_set_win_highlight): Remove.
8705
8e2daf15
TT
87062019-06-25 Tom Tromey <tom@tromey.com>
8707
8708 * tui/tui-wingeneral.c (make_visible): Remove check of window
8709 type.
8710
8903bd8a
TT
87112019-06-25 Tom Tromey <tom@tromey.com>
8712
8713 * tui/tui-win.c (tui_win_info::max_height)
8714 (tui_cmd_window::max_height): New methods.
8715 (new_height_ok): Call max_height.
8716 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8717 <max_height>: New method.
8718
3f02ce1e
TT
87192019-06-25 Tom Tromey <tom@tromey.com>
8720
8721 * tui/tui-win.c (tui_source_window_base::set_new_height)
8722 (tui_data_window::set_new_height): New methods.
8723 (make_invisible_and_set_new_height): Call set_new_height method.
8724 * tui/tui-data.h (struct tui_win_info)
8725 (struct tui_source_window_base, struct tui_data_window)
8726 <set_new_height>: New method.
8727
1825f487
TT
87282019-06-25 Tom Tromey <tom@tromey.com>
8729
8730 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8731 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8732 tui_refresh_data_win.
8733 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8734 method.
8735 (tui_refresh_all_win): Call the refresh_all method.
8736 (tui_set_focus): Likewise.
8737 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8738 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8739 Likewise.
8740
ad54d15b
TT
87412019-06-25 Tom Tromey <tom@tromey.com>
8742
8743 * tui/tui-winsource.h (tui_refill_source_window)
8744 (tui_set_is_exec_point_at): Don't declare.
8745 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8746 (tui_source_window_base::refill): Rename from
8747 tui_refill_source_window.
8748 (tui_source_window_base::do_scroll_horizontal): Update.
8749 (tui_source_window_base::set_is_exec_point_at): Rename from
8750 tui_set_is_exec_point_at.
8751 (tui_update_all_breakpoint_info): Update.
8752 * tui/tui-stack.c (tui_show_frame_info): Update.
8753 * tui/tui-layout.c (show_data): Add cast.
8754 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8755 * tui/tui-data.h (struct tui_source_window_base) <refill,
8756 set_is_exec_point_at>: New methods.
8757 (tui_source_windows, tui_add_to_source_windows): Update types.
8758 (tui_add_to_source_windows): Remove redundant declaration.
8759 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8760 (tui_source_windows): Change return type.
8761 (tui_clear_source_windows_detail): Update.
8762 (tui_add_to_source_windows): Change type of parameter.
8763 (tui_free_all_source_wins_content): Update.
8764
2042b506
TT
87652019-06-25 Tom Tromey <tom@tromey.com>
8766
8767 * tui/tui-wingeneral.c (tui_win_info::refresh)
8768 (tui_source_window_base::refresh): New methods.
8769 (tui_refresh_all): Call the refresh method.
8770 * tui/tui-data.h (struct tui_win_info)
8771 (struct tui_source_window_base) <refresh>: New method.
8772
56122977
TT
87732019-06-25 Tom Tromey <tom@tromey.com>
8774
8775 * tui/tui.h (tui_is_window_visible): Return bool.
8776 * tui/tui.c (tui_is_window_visible): Return bool.
8777 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8778 (tui_make_visible, tui_make_invisible)
8779 (tui_win_info::make_visible)
8780 (tui_source_window_base::make_visible, make_all_visible)
8781 (tui_make_all_visible, tui_make_all_invisible): Update.
8782 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8783 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8784 bool.
8785 (struct tui_win_info, struct tui_source_window_base)
8786 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8787 * tui/tui-data.c (tui_init_generic_part): Update.
8788
cda37efb
TT
87892019-06-25 Tom Tromey <tom@tromey.com>
8790
8791 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8792 (tui_source_window_base::make_visible): New methods.
8793 (make_all_visible): Make method call.
8794 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8795 (struct tui_source_window_base, struct tui_cmd_window): Override
8796 make_visible.
8797 (tui_win_is_source_type): Don't declare.
8798 * tui/tui-data.c (tui_win_is_source_type): Remove.
8799
6a0ee02c
TT
88002019-06-25 Tom Tromey <tom@tromey.com>
8801
8802 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8803 NULL check.
8804
63901aec
TT
88052019-06-25 Tom Tromey <tom@tromey.com>
8806
8807 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8808 Inline constructor. Add initializers for members.
8809 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8810 constructors; now inline in class.
8811
ceb13a13
TT
88122019-06-25 Tom Tromey <tom@tromey.com>
8813
8814 * tui/tui-regs.c (tui_show_registers): Update.
8815 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8816 bool.
8817 * tui/tui-data.c (tui_data_window::clear_detail)
8818 (tui_data_window): Update.
8819
238eb706
TT
88202019-06-25 Tom Tromey <tom@tromey.com>
8821
8822 * tui/tui-windata.c (tui_display_all_data)
8823 (tui_display_data_from_line, tui_display_data_from)
8824 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8825 Update.
8826 * tui/tui-regs.c (tui_last_regs_line_no)
8827 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8828 (tui_show_registers, tui_show_register_group)
8829 (tui_display_registers_from, tui_display_reg_element_at_line)
8830 (tui_display_registers_from_line, tui_check_register_values)
8831 (tui_reg_next, tui_reg_prev): Update.
8832 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8833 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8834 tui_data_window.
8835 (struct tui_win_info) <detail>: Remove. Add new fields from
8836 tui_data_info.
8837 (TUI_DATA_WIN): Add cast.
8838 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8839 (~tui_data_window): Simplify.
8840
81491aa0
TT
88412019-06-25 Tom Tromey <tom@tromey.com>
8842
8843 * tui/tui-layout.c (show_source_disasm_command)
8844 (show_source_or_disasm_and_command): Update.
8845 * tui/tui-io.c (update_cmdwin_start_line)
8846 (tui_redisplay_readline): Update.
8847 * tui/tui-data.h (struct tui_command_info): Remove.
8848 (struct tui_win_info) <detail>: Remove command_info member.
8849 (struct tui_data_window) <start_line>: New member, from
8850 tui_command_info.
8851 (TUI_CMD_WIN): Add casts.
8852
e6e41501
TT
88532019-06-25 Tom Tromey <tom@tromey.com>
8854
8855 * tui/tui-winsource.c (tui_update_source_window)
8856 (tui_refill_source_window)
8857 (tui_source_window_base::do_scroll_horizontal)
8858 (tui_update_breakpoint_info, tui_set_exec_info_content)
8859 (tui_show_exec_info_content, tui_erase_exec_info_content)
8860 (tui_clear_exec_info_content): Update.
8861 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8862 Update.
8863 * tui/tui-win.c (make_invisible_and_set_new_height)
8864 (make_visible_with_new_height): Update.
8865 * tui/tui-source.c (tui_set_source_content)
8866 (tui_show_symtab_source): Update.
8867 * tui/tui-layout.c (extract_display_start_addr)
8868 (show_source_disasm_command, show_data)
8869 (make_source_or_disasm_window)
8870 (show_source_or_disasm_and_command): Update.
8871 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8872 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8873 "gdbarch".
8874 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8875 to tui_source_window_base.
8876 (struct tui_win_info) <detail>: Remove source_info member.
8877 (struct tui_source_window_base) <has_locator>: Inline.
8878 Move contents from tui_source_info; rename has_locator member to
8879 m_has_locator.
8880 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8881 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8882 header file.
8883 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8884 Simplify.
8885 (tui_free_all_source_wins_content): Cast to
8886 tui_source_window_base.
8887
44f0e208
TT
88882019-06-25 Tom Tromey <tom@tromey.com>
8889
8890 * tui/tui-win.c (make_invisible_and_set_new_height)
8891 (make_visible_with_new_height): Call has_locator method.
8892 * tui/tui-layout.c (show_source_disasm_command, show_data)
8893 (show_source_or_disasm_and_command): Update for bool change.
8894 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8895 (tui_win_info) <has_locator>: New method.
8896 (struct tui_source_window_base) <has_locator>: New method.
8897 (tui_win_has_locator): Don't declare.
8898 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8899 from tui_win_has_locator.
8900 (tui_source_window_base): Use false, not FALSE.
8901
7778b912
TT
89022019-06-25 Tom Tromey <tom@tromey.com>
8903
8904 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8905 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8906 clear_detail method directly.
8907 (tui_clear_win_detail): Remove.
8908
f83d391c
TT
89092019-06-25 Tom Tromey <tom@tromey.com>
8910
8911 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8912 "this", not TUI_DISASM_WIN.
8913
13446e05
TT
89142019-06-25 Tom Tromey <tom@tromey.com>
8915
8916 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8917 declare.
8918 * tui/tui-winsource.c
8919 (tui_source_window_base::do_scroll_horizontal): Rename from
8920 tui_horizontal_source_scroll.
8921 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8922 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8923 from tui_vertical_data_scroll.
8924 * tui/tui-win.h (tui_scroll): Don't declare.
8925 * tui/tui-win.c (tui_win_info::forward_scroll)
8926 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8927 (tui_win_info::right_scroll): Rename and update.
8928 (tui_scroll_forward_command, tui_scroll_backward_command)
8929 (tui_scroll_left_command, tui_scroll_right_command): Update.
8930 (tui_scroll): Remove.
8931 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8932 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8933 from tui_vertical_source_scroll.
8934 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8935 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8936 from tui_vertical_disassem_scroll.
8937 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8938 do_scroll_horizontal>: New methods.
8939 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8940 Likewise.
8941 (struct tui_source_window_base): Add do_scroll_horizontal.
8942 (struct tui_source_window, struct tui_disasm_window): Add
8943 do_scroll_vertical.
8944 (struct tui_data_window, struct tui_cmd_window): Add
8945 do_scroll_horizontal and do_scroll_vertical.
8946 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8947
5cf82909
TT
89482019-06-25 Tom Tromey <tom@tromey.com>
8949
8950 * tui/tui-data.h (struct tui_source_window_base): New struct.
8951 (struct tui_source_window): Derive from tui_source_window_base.
8952 (struct tui_disasm_window): New struct.
8953 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8954 from tui_source_window::clear_detail.
8955 (tui_source_window_base): Rename from tui_source_window.
8956 (~tui_source_window_base): Rename from ~tui_source_window.
8957 (tui_alloc_win_info): Create a tui_disasm_window.
8958
ee1d42d6
TT
89592019-06-25 Tom Tromey <tom@tromey.com>
8960
8961 * tui/tui-data.h (struct tui_source_window)
8962 (struct tui_data_window): Declare destructors.
8963 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8964 destructors.
8965 (tui_win_info): Simplify.
8966
b4eb2452
TT
89672019-06-25 Tom Tromey <tom@tromey.com>
8968
8969 * tui/tui-winsource.c (tui_display_main)
8970 (tui_update_source_windows_with_addr)
8971 (tui_update_all_breakpoint_info): Update.
8972 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8973 (new_height_ok, parse_scrolling_args): Update.
8974 * tui/tui-stack.c (tui_show_frame_info): Update.
8975 * tui/tui-data.h (struct tui_list): Remove.
8976 (tui_source_windows): Return a reference to a std::vector.
8977 * tui/tui-data.c (source_windows): Now a std::vector.
8978 (tui_source_windows): Change return type.
8979 (tui_clear_source_windows): Rewrite.
8980 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8981 (tui_free_all_source_wins_content): Rewrite.
8982
8761a91b
TT
89832019-06-25 Tom Tromey <tom@tromey.com>
8984
8985 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8986 (struct tui_data_window, struct tui_cmd_window): Declare
8987 clear_detail method.
8988 * tui/tui-data.c (tui_source_window::clear_detail)
8989 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8990 methods.
8991 (tui_clear_win_detail): Simplify.
8992
0ed69eda
TT
89932019-06-25 Tom Tromey <tom@tromey.com>
8994
8995 * tui/tui-layout.c (make_source_window, make_disasm_window)
8996 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8997 Return the new window.
8998 (show_source_disasm_command, show_data)
8999 (show_source_or_disasm_and_command): Update.
9000
82432e10
TT
90012019-06-25 Tom Tromey <tom@tromey.com>
9002
9003 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9004 parameter. Return the new window.
9005 (show_source_disasm_command): Update and remove NULL check.
9006 (show_source_or_disasm_and_command): Update.
9007
ec328aa5
TT
90082019-06-25 Tom Tromey <tom@tromey.com>
9009
9010 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9011
33b906ab
TT
90122019-06-25 Tom Tromey <tom@tromey.com>
9013
9014 * tui/tui-data.h (struct tui_win_info): Make constructor
9015 protected. Make destructor virtual. Add initializers.
9016 (tui_source_window, tui_data_window, tui_cmd_window): New
9017 classes.
9018 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9019 constructor. Add "type" parameter.
9020 (tui_source_window, tui_data_window, tui_cmd_window): New
9021 constructors.
9022 (tui_alloc_win_info): Instantiate the appropriate subclass.
9023
e7e11af4
TT
90242019-06-25 Tom Tromey <tom@tromey.com>
9025
9026 * tui/tui-win.c (tui_resize_all): Use delete.
9027 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9028 destructor.
9029 (tui_free_window): Don't declare.
9030 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9031 Update.
9032
6792b55e
TT
90332019-06-25 Tom Tromey <tom@tromey.com>
9034
9035 * tui/tui-data.h (struct tui_win_info): Add constructor.
9036 * tui/tui-data.c (tui_alloc_win_info): Use new.
9037 (tui_free_window): Use delete.
9038
f95675e1
TT
90392019-06-22 Tom Tromey <tom@tromey.com>
9040
9041 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9042 declare.
9043 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9044
5bff081c
TT
90452019-06-22 Tom Tromey <tom@tromey.com>
9046
9047 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9048 declare.
9049 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9050
47e3f474
TV
90512019-06-22 Tom de Vries <tdevries@suse.de>
9052
9053 * dwarf2read.c (create_addrmap_from_aranges)
9054 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9055 instead of '%zu'.
9056
fd5866f6
SM
90572019-06-21 Simon Marchi <simon.marchi@efficios.com>
9058
9059 * dwarf2read.h (dwarf2_section_info_def): Remove.
9060 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9061 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9062 std::vector<dwarf2_section_info>.
9063 (struct dwo_file) <~dwo_file>: Remove.
9064 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9065 types field.
9066 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9067 (dwarf2_read_debug_names): Likewise.
9068 (create_debug_types_hash_table): Change parameter type to
9069 array_view, adjust code accordingly.
9070 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9071 (partial_die_info::fixup): Likewise.
9072 (determine_prefix): Likewise.
9073 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9074
fb1eb2f9
SM
90752019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9076
9077 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9078 gdb_bfd_ref_ptr.
9079 <~dwo_file>: Remove call to gdb_bfd_unref.
9080 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9081 gdb_bfd_ref_ptr::get.
9082
51ac9db5
SM
90832019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9084
9085 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9086 type to htab_up.
9087 * dwarf2read.c (struct dwo_file): Initialize fields.
9088 <~dwo_file>: New.
9089 (free_dwo_file): Remove, move content to ~dwo_file.
9090 (struct dwo_file_deleter): Remove.
9091 (dwo_file_up>: Remove custom deleter.
9092 (free_dwo_files): Remove.
9093 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9094 dwo_files.
9095 (process_skeletonless_type_units): Call unique_ptr::get.
9096 (allocate_dwo_file_hash_table): Add deleter to created hash
9097 table. Change return type to htab_up.
9098 (lookup_dwo_file_slot): Don't memset dwo_file, call
9099 unique_ptr::get.
9100 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9101 (create_dwo_unit_in_dwp_v2): Likewise.
9102 (open_and_init_dwo_file): Likewise.
9103 (free_dwo_file_from_slot): Remove.
9104
dc4ccb6f
SM
91052019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9106
9107 * dwarf2read.h (struct dwarf2_section_info) <readin,
9108 is_virtual>: Change type to bool.
9109 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9110 true instead of 1.
9111
e6a1c5cb
TT
91122019-06-19 Tom Tromey <tom@tromey.com>
9113
9114 * tui/tui-data.h (tui_init_content_element): Don't declare.
9115
6f6ffbeb
TT
91162019-06-19 Tom Tromey <tom@tromey.com>
9117
9118 * tui/tui-data.h (tui_init_win_info): Don't declare.
9119
f23f598e
TV
91202019-06-19 Tom de Vries <tdevries@suse.de>
9121
9122 * dwarf2read.h (abstract_to_concrete): Change type to
9123 std::unordered_map<sect_offset, std::vector<sect_offset>,
9124 gdb::hash_enum<sect_offset>>.
9125
680e1bee
TT
91262019-06-19 Tom Tromey <tromey@adacore.com>
9127
9128 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9129 EVAL_AVOID_SIDE_EFFECTS specially.
9130
dcf37923
TT
91312019-06-19 Tom Tromey <tromey@adacore.com>
9132
9133 * source-cache.c (highlighter): New global.
9134 (source_cache::get_source_lines): Create a highlighter on demand.
9135
494986d5
AB
91362019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9137
9138 * defs.h (deprecated_interactive_hook): Delete declaration.
9139 * interps.c (clear_interpreter_hooks): Remove use of
9140 deprecated_interactive_hook.
9141 * top.c (deprecated_interactive_hook): Delete definition.
9142 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9143
3360b6e7
TV
91442019-06-18 Tom de Vries <tdevries@suse.de>
9145
9146 PR gdb/24515
9147 * dwarf2read.h (abstract_to_concrete): Change type from
9148 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9149 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9150 * dwarf2read.c (read_variable): Update.
9151 (dwarf2_fetch_die_loc_sect_off): Update.
9152
310b3441
TV
91532019-06-17 Tom de Vries <tdevries@suse.de>
9154
9155 PR gdb/24617
9156 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9157 accessing parent[parent_len - 1].
9158
ba9777be
PP
91592019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9160
9161 PR gdb/24364
9162 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9163 call dtrace_process_dof with NULL dof.
9164
2b9f6e89
TV
91652019-06-16 Tom de Vries <tdevries@suse.de>
9166
9167 PR gdb/24445
9168 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9169
431b3ead
TT
91702019-06-16 Tom Tromey <tom@tromey.com>
9171
9172 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9173 (make_all_visible): Use address of member.
9174
d04b44a1
TT
91752019-06-16 Tom Tromey <tom@tromey.com>
9176
9177 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9178 (tui_free_window, free_content, free_content_elements): Remove
9179 unnecessary cast.
9180 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9181 cast.
9182 * tui/tui-regs.c (tui_show_register_group)
9183 (tui_display_registers_from, tui_display_reg_element_at_line):
9184 Remove unnecessary cast.
9185
bf5142e7
AB
91862019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9187
9188 * linux-nat.c (normal_mask): Delete.
9189 (_initialize_linux_nat): Don't initialise normal_mask.
9190
c4973306
SM
91912019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9192
9193 PR gdb/24445
9194 * dwarf-index-write.h (write_psymtabs_to_index): Add
9195 dwz_basename parameter.
9196 * dwarf-index-write.c (write_gdbindex): Move file writing to
9197 write_gdbindex_1. Change return type void.
9198 (assert_file_size): Move up, remove filename parameter.
9199 (write_gdbindex_1): New function.
9200 (write_debug_names): Change return type to void, call
9201 assert_file_size.
9202 (struct index_wip_file): New struct.
9203 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9204 file logic to index_wip_file. Write index for dwz file if
9205 needed.
9206 (save_gdb_index_command): Pass basename of dwz file, if present.
9207 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9208 build-id of dwz file, if present.
9209 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9210 (dwarf2_get_dwz_file): Likewise.
9211 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9212 (dwarf2_get_dwz_file): Likewise.
9213
395f9c91
TT
92142019-06-16 Tom Tromey <tom@tromey.com>
9215
9216 * coffread.c (process_coff_symbol): Use xstrdup.
9217 * value.c (create_internalvar): Use xstrdup.
9218
cafb3438
TT
92192019-06-16 Tom Tromey <tom@tromey.com>
9220
9221 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9222 * breakpoint.c (stopin_command, stopat_command)
9223 (until_break_command, decode_location_default): Remove unnecessary
9224 cast.
9225 * utils.c (subset_compare): Remove unnecessary cast.
9226 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9227 cast.
9228 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9229 cast.
9230 * infcmd.c (path_command): Remove unnecessary cast.
9231 * coffread.c (decode_type): Remove unnecessary cast.
9232 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9233 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9234 * tui/tui-stack.c (tui_show_locator_content)
9235 (tui_show_frame_info): Remove unnecessary cast.
9236 * tui/tui-win.c (tui_scroll_forward_command)
9237 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9238 (parse_scrolling_args): Remove unnecessary cast.
9239 * tui/tui-data.c (init_win_info, tui_del_window)
9240 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9241 (free_content_elements): Remove unnecessary cast.
9242 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9243 unnecessary cast.
9244 * tui/tui-source.c (tui_set_source_content)
9245 (tui_vertical_source_scroll): Remove unnecessary cast.
9246 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9247 cast.
9248 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9249 * tui/tui-regs.c (tui_display_registers_from)
9250 (tui_display_register): Remove unnecessary cast.
9251 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9252 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9253 (make_visible): Remove unnecessary cast.
9254 * tui/tui-winsource.c (tui_erase_source_content)
9255 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9256 unnecessary cast.
9257 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9258 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9259 * stabsread.c (read_type, read_array_type, read_range_type):
9260 Remove unnecessary cast.
9261 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9262 (parse_symbol, parse_type, upgrade_type, parse_external)
9263 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9264 unnecessary cast.
9265 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9266
730ead81
TT
92672019-06-16 Tom Tromey <tom@tromey.com>
9268
9269 * tui/tui-data.c (tui_alloc_generic_win_info)
9270 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9271 checks.
9272
584a927c
AB
92732019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9274 Andrew Burgess <andrew.burgess@embecosm.com>
9275
9276 * f-typeprint.c (f_print_type): Don't return early for not
9277 associated or not allocated types.
9278 (f_type_print_varspec_suffix): Add print_rank parameter and print
9279 ranks of array types in case they dangling.
9280 (f_type_print_base): Add print_rank parameter.
9281
30056ea0
AB
92822019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9283
9284 * NEWS: Mention new MI commands.
9285 * break-catch-throw.c (enum exception_event_kind): Move to
9286 breakpoint.h.
9287 (print_mention_exception_catchpoint): Output text as a single
9288 message.
9289 (catch_exception_command_1): Rename to...
9290 (catch_exception_event): ...this, make non-static, update header
9291 command, and change some parameter types.
9292 (catch_catch_command): Update for changes to
9293 catch_exception_command_1.
9294 (catch_throw_command): Likewise.
9295 (catch_rethrow_command): Likewise.
9296 * breakpoint.c (enum exception_event_kind): Delete.
9297 * breakpoint.h (enum exception_event_kind): Moved here from
9298 break-catch-throw.c.
9299 (catch_exception_event): Declare.
9300 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9301 (mi_cmd_catch_throw): New function.
9302 (mi_cmd_catch_rethrow): New function.
9303 (mi_cmd_catch_catch): New function.
9304 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9305 'catch-catch' entries.
9306 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9307 (mi_cmd_catch_rethrow): Declare.
9308 (mi_cmd_catch_catch): Declare.
9309
ec8e2b6d
AB
93102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9311
9312 * annotate.c (annotate_source_line): Change return type to void,
9313 update implementation to match.
9314 * annotate.h (annotate_source_line): Change return type to void,
9315 update header comment.
9316 * stack.c (print_frame_info): Don't change what frame information
9317 is printed based on whether annotations are on or not.
9318
0d3abd8c
AB
93192019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9320
9321 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9322 (annotate_source): Make static.
9323 (annotate_source_line): Moved from source.c and renamed from
9324 identify_source_line. Update the return type.
9325 * annotate.h (annotate_source): Delete declaration.
9326 (annotate_source_line): Declaration moved from source.h, and
9327 renamed from identify_source_line. Return type updated.
9328 * source.c (identify_source_line): Moved to annotate.c and renamed
9329 to annotate_source_line.
9330 (info_line_command): Remove check of annotation_level.
9331 * source.h (identify_source_line): Move declaration to annotate.h
9332 and rename to annotate_source_line.
9333 * stack.c: Add 'annotate.h' include.
9334 (print_frame_info): Remove check of annotation_level before
9335 calling annotate_source_line.
9336
00df30ae
AB
93372019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9338
9339 * source-cache.c (source_cache::get_plain_source_lines): Use
9340 open_source_file_with_line_charpos instead of just
9341 open_source_file, remove call to find_source_lines.
9342 (source_cache::get_source_lines): Likewise.
9343 * source.c (find_source_lines): Make static.
9344 (get_filename_and_charpos): Renamed into...
9345 (open_source_file_with_line_charpos): ..this along with changes to
9346 return a scoped_fd, and some other minor clean ups.
9347 (identify_source_line): Use open_source_file_with_line_charpos.
9348 (search_command_helper): Use open_source_file_with_line_charpos
9349 instead of just open_source_file, remove call to
9350 find_source_lines.
9351 * source.h (open_source_file_with_line_charpos): Declare new
9352 function.
9353 (find_source_lines): Delete declaration.
9354
afda45a2
AB
93552019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9356
9357 * source.c (get_filename_and_charpos): Remove fullname
9358 parameter.
9359 (identify_source_line): Update call to get_filename_and_charpos.
9360
0735b091
TT
93612019-06-14 Tom Tromey <tromey@adacore.com>
9362
9363 PR gdb/24502:
9364 * ui-style.h (skip_ansi_escape): Update comment.
9365 * ui-file.h (class no_terminal_escape_file): New class.
9366 * ui-file.c (no_terminal_escape_file::write)
9367 (no_terminal_escape_file::puts): New methods.
9368 * cli/cli-logging.c (handle_redirections): Use
9369 no_terminal_escape_file.
9370
52ce35e2
TT
93712019-06-14 Tom Tromey <tromey@adacore.com>
9372
9373 * NEWS: Move convenience variable news above Python news.
9374
73cc7272
TT
93752019-06-14 Tom Tromey <tom@tromey.com>
9376
9377 * gnulib: Move directory to top-level.
9378 * configure.ac: Don't configure gnulib.
9379 * configure: Rebuild.
9380 * common/common-defs.h: Use new path to gnulib.
9381 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9382 (GNULIB_H): Remove.
9383 (INCGNU): Look in new gnulib location.
9384 (HFILES_NO_SRCDIR): Remove gnulib files.
9385 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9386 (generated_files): Remove GNULIB_H.
9387 ($(LIBGNU), all-lib): Remove targets.
9388 (distclean): Don't mention GNULIB_BUILDDIR.
9389 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9390
f5686554
TT
93912019-06-14 Tom Tromey <tromey@adacore.com>
9392
9393 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9394 Warn if symbol file does not provide any symbols.
9395
a0c1ffed
TT
93962019-06-14 Tom Tromey <tromey@adacore.com>
9397
9398 * source.c (find_and_open_source): Respect basenames_may_differ.
9399
7c39e397
AB
94002019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9401
9402 * annotate.c (annotate_breakpoints_invalid): Make use of
9403 scoped_restore_terminal_state.
9404 (annotate_frames_invalid): Likewise.
9405
f411722c
TT
94062019-06-14 Tom Tromey <tromey@adacore.com>
9407
9408 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9409 allow assignment to an internalvar.
9410
4268ec18
TT
94112019-06-14 Tom Tromey <tromey@adacore.com>
9412
9413 * ada-lex.l: Allow "_" in attribute names.
9414
abdb711e
TT
94152019-06-14 Tom Tromey <tromey@adacore.com>
9416
9417 PR gdb/24653:
9418 * regcache.c (registers_changed): Don't call alloca.
9419 * top.c (execute_command): Don't call alloca.
9420
4c048731
PA
94212019-06-13 Pedro Alves <palves@redhat.com>
9422
9423 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9424 'expression'. When parsing an expression, error out if there's
9425 junk after "unlimited".
9426 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9427 (do_set_command): Adjust calls to is_unlimited_literal.
9428
66eb1ed3
PA
94292019-06-13 Pedro Alves <palves@redhat.com>
9430
9431 * compile/compile.c (make_compile_options_def_group): Add braces
9432 around array_view initializer.
9433 * thread.c (make_thread_apply_all_options_def_group)
9434 (make_thread_apply_all_options_def_group): Likewise.
9435
3345721a
PA
94362019-06-13 Pedro Alves <palves@redhat.com>
9437
9438 * NEWS (New commands): Mention "maint test-options
9439 require-delimiter", "maint test-options unknown-is-error", "maint
9440 test-options unknown-is-operand" and "maint show
9441 test-options-completion-result".
9442 (New command options, command completion): New section.
9443 (Completion improvements): New section.
9444 Mention that you can abbreviate "unlimited".
9445
6206060d
PA
94462019-06-13 Pedro Alves <palves@redhat.com>
9447
9448 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9449 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9450 * unittests/cli-utils-selftests.c (test_parse_flags)
9451 (test_parse_flags_qcs): Delete.
9452 (test_cli_utils): Don't call deleted functions.
9453
6665660a
PA
94542019-06-13 Pedro Alves <palves@redhat.com>
9455
9456 * thread.c: Include "cli/cli-option.h".
9457 (tp_array_compar_ascending): Global.
9458 (tp_array_compar): Delete function.
9459 (tp_array_compar_ascending, tp_array_compar_descending): New
9460 functions.
9461 (ascending_option_def, qcs_flag_option_def)
9462 (thr_qcs_flags_option_defs)
9463 (make_thread_apply_all_options_def_group)
9464 (make_thread_apply_options_def_group): New.
9465 (thread_apply_all_command): Use gdb::option::process_options.
9466 (thread_apply_command_completer)
9467 (thread_apply_all_command_completer): New.
9468 (thread_apply_command): Use gdb::option::process_options.
9469 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9470 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9471 to generate help text of "thread apply". Adjust "taas"'s help.
9472 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9473 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9474
f7e13587
PA
94752019-06-13 Pedro Alves <palves@redhat.com>
9476
9477 * thread.c (thread_apply_command): Check for invalid TID with
9478 isdigit instead of !isalpha.
9479
5d707134
PA
94802019-06-13 Pedro Alves <palves@redhat.com>
9481
9482 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9483 (validate_flags_qcs): New.
9484 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9485 (validate_flags_qcs): Declare.
9486 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9487 (make_frame_apply_options_def_group): New.
9488 (frame_apply_command_count): Process options with
9489 gdb::option::process_options.
9490 (frame_apply_completer): New.
9491 (frame_apply_level_completer, frame_apply_all_completer)
9492 (frame_apply_completer): New.
9493 (_initialize_stack): Update help of "frame apply", "frame apply
9494 level", "frame apply all" and "faas" to mention supported options
9495 and install command completers.
9496 * stack.h (frame_apply_all_completer): Declare.
9497 * thread.c: Include "stack.h".
9498 (tfaas_command): Add "--".
9499 (_initialize_thread): Update help "tfaas" to mention supported
9500 options and install command completer.
9501
272d4594
PA
95022019-06-13 Pedro Alves <palves@redhat.com>
9503
9504 * completer.c (complete_nested_command_line): New.
9505 (gdb_completion_word_break_characters_throw): Add assertion.
9506 * completer.h (complete_nested_command_line): Declare.
9507
90a1ef87
PA
95082019-06-13 Pedro Alves <palves@redhat.com>
9509
9510 * stack.c (parse_backtrace_qualifiers): New.
9511 (backtrace_command): Use it.
9512 (backtrace_command_completer): Complete on qualifiers.
9513
d4c16835
PA
95142019-06-13 Pedro Alves <palves@redhat.com>
9515
9516 * frame.c: Include "cli/cli-option.h.
9517 (user_set_backtrace_options): New.
9518 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9519 Delete.
9520 (get_prev_frame): Adjust.
9521 (boolean_option_def, uinteger_option_def)
9522 (set_backtrace_option_defs): New.
9523 (_initialize_frame): Adjust and use
9524 gdb::option::add_setshow_cmds_for_options to install "set
9525 backtrace past-main" and "set backtrace past-entry".
9526 * frame.h: Include "cli/cli-option.h".
9527 (struct frame_print_options): Forward declare.
9528 (print_frame_arguments_all, print_frame_arguments_scalars)
9529 (print_frame_arguments_none): Declare.
9530 (print_entry_values): Delete declaration.
9531 (struct frame_print_options, user_frame_print_options): New.
9532 (struct set_backtrace_options): New.
9533 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9534 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9535 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9536 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9537 (list_args_or_locals): Add frame_print_options parameter.
9538 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9539 * python/py-framefilter.c (enumerate_args): Pass down
9540 USER_FRAME_PRINT_OPTIONS.
9541 * stack.c: Include "cli/cli-option.h".
9542 (print_frame_arguments_all, print_frame_arguments_scalars)
9543 (print_frame_arguments_none): Declare.
9544 (print_raw_frame_arguments, print_entry_values): Delete.
9545 (user_frame_print_options): New.
9546 (boolean_option_def, enum_option_def, frame_print_option_defs):
9547 New.
9548 (struct backtrace_cmd_options): New.
9549 (bt_flag_option_def): New.
9550 (backtrace_command_option_defs): New.
9551 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9552 (print_frame_arg, read_frame_arg, print_frame_args)
9553 (print_frame_info, print_frame): Add frame_print_options parameter
9554 and use it.
9555 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9556 (backtrace_command_1): Add frame_print_options and
9557 backtrace_cmd_options parameters and use them.
9558 (make_backtrace_options_def_group): New.
9559 (backtrace_command): Process command options with
9560 gdb::option::process_options.
9561 (backtrace_command_completer): New.
9562 (_initialize_stack): Extend "backtrace"'s help to mention
9563 supported options. Install completer for "backtrace".
9564 Install some settings commands with add_setshow_cmds_for_options.
9565
2daf894e
PA
95662019-06-13 Pedro Alves <palves@redhat.com>
9567
9568 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9569 and that "set/show print raw frame-arguments" are now deprecated.
9570
9571 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9572 command.
9573 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9574 * stack.c (_initialize_stack): Install "set/show print
9575 raw-frame-arguments", and deprecate "set/show print raw
9576 frame-arguments".
9577 * valprint.c (_initialize_valprint): Deprecate "set/show print
9578 raw".
9579
e6ed716c
PA
95802019-06-13 Pedro Alves <palves@redhat.com>
9581
9582 * compile/compile.c (struct compile_options): New.
9583 (compile_flag_option_def, compile_command_option_defs)
9584 (make_compile_options_def_group): New.
9585 (compile_file_command): Handle options with
9586 gdb::option::process_options.
9587 (compile_file_command_completer): New function.
9588 (compile_code_command): Handle options with
9589 gdb::option::process_options.
9590 (compile_code_command_completer): New function.
9591 (_initialize_compiler): Install completers for "compile code" and
9592 "compile file". Mention available options in "compile code" and
9593 "compile code"'s help.
9594 * completer.c (advance_to_completion_word): New, factored out from
9595 ...
9596 (advance_to_expression_complete_word_point): ... this.
9597 (advance_to_filename_complete_word_point): New.
9598 * completer.h (advance_to_filename_complete_word_point): New
9599 declaration.
9600
7d8062de
PA
96012019-06-13 Pedro Alves <palves@redhat.com>
9602
9603 * compile/compile.c: Include "cli/cli-option.h".
9604 (compile_print_value): Scope data pointer is now a
9605 value_print_options pointer; adjust.
9606 (compile_print_command): Process options. Scope data pointer is
9607 now a value_print_options pointer; adjust.
9608 (_initialize_compile): Update "compile print"'s help to include
9609 supported options. Install a completer for "compile print".
9610 * cp-valprint.c (show_vtblprint, show_objectprint)
9611 (show_static_field_print): Delete.
9612 (_initialize_cp_valprint): Don't install "set print
9613 static-members", "set print vtbl", "set print object" here.
9614 * printcmd.c: Include "cli/cli-option.h" and
9615 "common/gdb_optional.h".
9616 (print_command_parse_format): Rework to fill in a
9617 value_print_options instead of a format_data.
9618 (print_value): Change parameter type from format_data pointer to
9619 value_print_options reference. Adjust.
9620 (print_command_1): Process options. Adjust to pass down a
9621 value_print_options.
9622 (print_command_completer): New.
9623 (_initialize_printcmd): Install print_command_completer as
9624 handle_brkchars completer for the "print" command. Update
9625 "print"'s help to include supported options.
9626 * valprint.c: Include "cli/cli-option.h".
9627 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9628 here from cp-valprint.c.
9629 (boolean_option_def, uinteger_option_def)
9630 (value_print_option_defs, make_value_print_options_def_group):
9631 New. Use gdb::option::add_setshow_cmds_for_options to install
9632 "set print elements", "set print null-stop", "set print repeats",
9633 "set print pretty", "set print union", "set print array", "set
9634 print address", "set print symbol", "set print array-indexes".
9635 * valprint.h: Include <string> and "cli/cli-option.h".
9636 (make_value_print_options_def_group): Declare.
9637 (print_value): Change parameter type from format_data pointer to
9638 value_print_options reference.
9639 (print_command_completer): Declare.
9640
9d0faba9
PA
96412019-06-13 Pedro Alves <palves@redhat.com>
9642
9643 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9644 (COMMON_SFILES): Add maint-test-settings.c.
9645 * cli/cli-decode.c (boolean_enums): New global, factored out from
9646 ...
9647 (add_setshow_boolean_cmd): ... here.
9648 * cli/cli-decode.h (boolean_enums): Declare.
9649 * cli/cli-option.c: New file.
9650 * cli/cli-option.h: New file.
9651 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9652 factored out from ...
9653 (parse_cli_boolean_value(const char *)): ... this.
9654 (is_unlimited_literal): Change parameter type to pointer to
9655 pointer. Adjust and advance ARG pointer.
9656 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9657 (parse_cli_var_enum): New, factored out from ...
9658 (do_set_command): ... this. Adjust.
9659 * cli/cli-setshow.h (parse_cli_boolean_value)
9660 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9661 (parse_cli_var_enum): Declare.
9662 * cli/cli-utils.c: Include "cli/cli-option.h".
9663 (get_ulongest): New.
9664 * cli/cli-utils.h (get_ulongest): Declare.
9665 (check_for_argument): New overloads.
9666 * maint-test-options.c: New file.
9667
2c722807
PA
96682019-06-13 Pedro Alves <palves@redhat.com>
9669
9670 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9671 parse a range if "-" is at the end of the string.
9672
dee7b4c8
PA
96732019-06-13 Pedro Alves <palves@redhat.com>
9674
9675 * cli/cli-setshow.c (parse_auto_binary_operation)
9676 (parse_cli_boolean_value): Don't allow "o".
9677
dca0f6c0
PA
96782019-06-13 Pedro Alves <palves@redhat.com>
9679
9680 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9681 * NEWS: Mention maint test-settings KIND.
9682 * maint-test-settings.c: New file.
9683
597bf39d
PA
96842019-06-13 Pedro Alves <palves@redhat.com>
9685
9686 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9687 completer.
9688 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9689 "set" completers.
9690
48c410fb
PA
96912019-06-13 Pedro Alves <palves@redhat.com>
9692
9693 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9694 after item.
9695
93bcb043
PA
96962019-06-13 Pedro Alves <palves@redhat.com>
9697
9698 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9699
cbba3ecd
PA
97002019-06-13 Pedro Alves <palves@redhat.com>
9701
9702 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9703 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9704 call.
9705 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9706 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9707 calls.
9708 (check_for_argument): Skip spaces after argument.
9709
b9a3f842
PA
97102019-06-13 Pedro Alves <palves@redhat.com>
9711
9712 * thread.c (thread_apply_command): Adjust TID parsing.
9713 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9714 detected before end of string.
9715 (tid_is_in_list): Error out if LIST is invalid.
9716
3844e605
PA
97172019-06-13 Pedro Alves <palves@redhat.com>
9718
9719 * completer.c (complete_line_internal_1): Rewind completion word
9720 point.
9721 (completion_tracker::advance_custom_word_point_by): Change
9722 parameter type to int.
9723 * completer.h (completion_tracker::advance_custom_word_point_by):
9724 Likewise.
9725
00b56dbe
PA
97262019-06-13 Pedro Alves <palves@redhat.com>
9727
9728 * completer.c (advance_to_completion_word): Handle delimiters.
9729
d106773e
PA
97302019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9731
9732 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9733
08f10e02
TT
97342019-06-11 Tom Tromey <tom@tromey.com>
9735
9736 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9737 (xmalloc_failed): Move to alloc.c.
9738 * alloc.c: New file.
9739 * Makefile.in (COMMON_SFILES): Add alloc.c.
9740
1c7fe951
TT
97412019-06-11 Tom Tromey <tom@tromey.com>
9742
9743 * nat/linux-waitpid.c: Don't include server.h.
9744 (linux_debug): Remove.
9745 (my_waitpid): Update.
9746
89549d7f
TT
97472019-06-11 Tom Tromey <tromey@adacore.com>
9748
9749 * infcall.c (_initialize_infcall): Remove trailing newline from
9750 help.
9751 * user-regs.c (_initialize_user_regs): Remove trailing newline
9752 from help.
9753 * typeprint.c (_initialize_typeprint): Remove trailing newline
9754 from help.
9755 * reverse.c (_initialize_reverse): Remove trailing newlines from
9756 help.
9757 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9758 from help.
9759 * language.c (add_set_language_command): Remove trailing newline
9760 from help.
9761 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9762 help.
9763 * disasm.c (_initialize_disasm): Remove trailing newline from
9764 help.
9765 * top.c (init_main): Remove trailing newline from help.
9766 * interps.c (_initialize_interpreter): Remove trailing newline
9767 from help.
9768 * btrace.c (_initialize_btrace): Remove trailing newlines from
9769 help.
9770 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9771 from help.
9772 * python/python.c (_initialize_python): Remove trailing newline
9773 from help.
9774 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9775 help.
9776 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9777 from help. Reformat some text.
9778 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9779 from help.
9780 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9781 newline from help.
9782
86108c13
TT
97832019-06-11 Tom Tromey <tromey@adacore.com>
9784
9785 * darwin-nat.c (darwin_decode_exception_message)
9786 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9787
a7067863
AB
97882019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9789
9790 * valops.c (value_slice): Check for not allocated or not
9791 associated values.
9792
9ab08412
TV
97932019-06-10 Tom de Vries <tdevries@suse.de>
9794
9795 PR gdb/24618
9796 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9797 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9798 invalid.
9799
f19e22e9
TV
98002019-06-10 Tom de Vries <tdevries@suse.de>
9801
9802 PR gdb/24611
9803 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9804 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9805
e99f9db0
TV
98062019-06-10 Tom de Vries <tdevries@suse.de>
9807
9808 PR symtab/24545
9809 * symtab.c (struct demangled_name_entry): Add language field.
9810 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9811 static minimal symbol". Set and use language field.
9812
9bf7038b
TT
98132019-06-10 Tom Tromey <tromey@adacore.com>
9814
9815 * ada-lang.c (_initialize_ada_language): Update help text.
9816
422186a9
TT
98172019-06-10 Tom Tromey <tromey@adacore.com>
9818
9819 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9820 with a newline.
9821 * guile/guile.c (handle_boot_error): Don't end warning with a
9822 newline.
9823 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9824 warning with a newline.
9825 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9826 newline.
9827 (s12z_frame_cache): Likewise.
9828 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9829 a newline.
9830 * solib-svr4.c (disable_probes_interface): Don't end warning with
9831 a newline.
9832 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9833 newline.
9834 * python/python.c (do_finish_initialization): Don't end warning
9835 with a newline.
9836
25ce02ee
TT
98372019-06-10 Tom Tromey <tom@tromey.com>
9838
9839 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9840 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9841 gdbpy_enter.
9842
caa429d8
TT
98432019-06-10 Tom Tromey <tromey@adacore.com>
9844
9845 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9846 data.
9847 (elf_new_init): Don't call stabsread_new_init.
9848 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9849 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9850 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9851
81873cc8
TV
98522019-06-10 Tom de Vries <tdevries@suse.de>
9853
9854 PR symtab/16264
9855 PR symtab/24517
9856 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9857
4fa0265e
РИ
98582019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9859
9860 * source.c (find_and_open_source): Also rewrite relative file
9861 names.
9862
1a3da2cd
AB
98632019-04-26 Amos Bird <amosbird@gmail.com>
9864
9865 * annotate.c (annotate_thread_exited): Add "thread-exited"
9866 annotation.
9867
3847a7bf
TT
98682019-06-06 Tom Tromey <tromey@adacore.com>
9869
9870 * maint.h (class scoped_command_stats): Use
9871 DISABLE_COPY_AND_ASSIGN.
9872 <print_time>: New method.
9873 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9874 print_time.
9875 (scoped_command_stats::print_time): New method.
9876
312617a3
AB
98772019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9878
9879 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9880 instructions of lengths 6 or 8 bytes.
9881
b02f78f9
PA
98822019-06-04 Pedro Alves <palves@redhat.com>
9883
9884 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9885
9886 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9887 * breakpoint.c (condition_completer): Likewise.
9888 * cli/cli-dump.c (scan_expression): Likewise.
9889 * common/filestuff.c (mkdir_recursive): Likewise.
9890 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9891 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9892 (gdb_abspath): Likewise.
9893 * compile/compile-cplus-types.c
9894 (compile_cplus_instance::decl_name): Likewise.
9895 * completer.c (complete_explicit_location):
9896 (signal_completer, reg_or_group_completer_1): Likewise.
9897 * cp-support.c (cp_remove_params_if_any): Likewise.
9898 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9899 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9900 * infcmd.c (strip_bg_char): Likewise.
9901 * linespec.c (copy_token_string): Likewise.
9902 * mi/mi-main.c (output_cores): Likewise.
9903 * psymtab.c (psymtab_search_name):
9904 * symfile.c (test_set_ext_lang_command): Likewise.
9905 * target.c (target_fileio_read_stralloc): Likewise.
9906 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9907 * value.c (complete_internalvar): Likewise.
9908
e1f2e1a2
CB
99092019-06-04 Christian Biesinger <cbiesinger@google.com>
9910
9911 Add objfile property to gdb.Type.
d3238f7d
PA
9912 * NEWS: Mention Python API addition.
9913 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9914
e664d728
PW
99152019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9916
9917 * NEWS: Mention the new set|show style [title|highlight].
9918 Mention changes to "show style", "help" and "apropos".
9919
66d8c862
PW
99202019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9921
9922 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9923 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9924 instead of print_help_for_command.
9925 (print_doc_of_command): New function.
9926 (help_list): Add 'apropos -v word' suggestion.
9927 (print_help_for_command): Style the command name using title style.
9928 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9929 (_initialize_cli_cmds): Describe -v in apropos_command help.
9930
9303eb2f
PW
99312019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9932
9933 * cli/cli-style.h (cli_style_option): Add name in constructor,
9934 add m_name class member, add constructor with intensity,
9935 add name class function.
9936 (cli_style_option::add_setshow_commands): Remove name argument.
9937 (highlight_style, title_style): New styles.
9938 * cli/cli-style.c (do_show): New function that shows a style
9939 characteristic styling the style name with itself.
9940 (set_style_name): New function.
9941 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9942 Update all callers according to the changes in cli/cli-style.h.
9943 * utils.h (fputs_highlighted): New function.
9944 * utils.c (fputs_highlighted): Likewise.
9945
e2c52041
PW
99462019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9947
9948 * NEWS: Mention new pipe command and new convenience variables.
9949
947d3946
PW
99502019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9951
9952 * cli/cli-cmds.c (pipe_command): New function.
9953 (_initialize_cli_cmds): Call add_com for pipe_command.
9954 Define | as an alias for pipe.
9955 (exit_status_set_internal_vars): New function.
9956 (shell_escape): Call exit_status_set_internal_vars.
9957 cli/cli-decode.c (find_command_name_length): Recognize | as
9958 a single character command.
9959
b8fd0918
PW
99602019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9961
9962 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9963 top.c (execute_command_to_ui_file): New function, mostly a copy
9964 of execute_command_to_string.
9965 (execute_command_to_string): Implement by calling
9966 execute_command_to_ui_file.
9967
68bb5386
PW
99682019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9969
9970 * top.h (saved_command_line): Remove declaration.
9971 * top.c (previous_saved_command_line, previous_repeat_arguments):
9972 New variables.
9973 (saved_command_line): Make static, define together with other
9974 'repeat variables'.
9975 (dont_repeat): Clear repeat_arguments.
9976 (repeat_previous, get_saved_command_line, save_command_line):
9977 New functions.
9978 (gdb_init): Initialize saved_command_line
9979 and previous_saved_command_line.
9980 * main.c (captured_main_1): Remove saved_command_line initialization.
9981 * event-top.c (handle_line_of_input): Update to use
9982 the new 'repeat' related functions instead of direct access to
9983 saved_command_line.
9984 * command.h (repeat_previous, get_saved_command_line,
9985 save_command_line): New declarations.
9986 (dont_repeat): Add comment.
9987
bfcdb852
TT
99882019-05-30 Tom Tromey <tromey@adacore.com>
9989
9990 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9991 Fix comment.
9992 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9993
0ef209f2
JV
99942019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9995
9996 PR cli/24587
9997 * completer.c (complete): Initialize variable word.
9998
955b06fa
SDJ
99992019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10000
10001 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10002 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10003 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10004 'body' is NULL to the outter 'if', protecting the '!is_define'
10005 situation as well.
10006
fa9c3fa0
TT
100072019-05-29 Tom Tromey <tromey@adacore.com>
10008
10009 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10010 (dwarf_unknown): New function.
10011 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10012 (dwarf_type_encoding_name): Use dwarf_unknown.
10013
4330d61d
TT
100142019-05-29 Tom Tromey <tromey@adacore.com>
10015
10016 PR c++/20020:
10017 * cp-valprint.c (cp_print_value_fields): Call
10018 cp_print_static_field inside "try".
10019
33a6bc35
TT
100202019-05-29 Tom Tromey <tromey@adacore.com>
10021
10022 * inflow.c (struct terminal_info): Add default operator=.
10023 * configure: Rebuild.
10024 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10025 -Wdeprecated-copy-dtor, -Wredundant-move.
10026
000439d5
TT
100272019-05-29 Tom Tromey <tromey@adacore.com>
10028
10029 * NEWS: Add entry.
10030 * infcmd.c (print_return_value_1): Handle finish_print
10031 option.
10032 (show_print_finish): New function.
10033 (_initialize_infcmd): Add "set/show print finish" commands.
10034 * valprint.c (user_print_options): Initialize new member.
10035 * valprint.h (struct value_print_options) <finish_print>: New
10036 member.
10037
c0e70c62
TT
100382019-05-28 Tom Tromey <tromey@adacore.com>
10039
10040 * ada-lang.c (ada_remove_Xbn_suffix)
10041 (find_old_style_renaming_symbol)
10042 (parse_old_style_renaming): Remove.
10043 (ada_find_renaming_symbol): Don't call
10044 find_old_style_renaming_symbol.
10045 (ada_is_renaming_symbol): Rename from
10046 ada_find_renaming_symbol. Remove "block" parameter. Return
10047 bool. Now static.
10048 (ada_read_var_value): Update and simplify.
10049 * ada-exp.y (write_var_or_type): Remove old code.
10050
766f8836
AH
100512019-05-28 Alan Hayward <alan.hayward@arm.com>
10052
68255adc 10053 PR gdb/25010
766f8836
AH
10054 * event-top.c: Remove include comment.
10055 * inflow.c (class scoped_ignore_sigttou): Move from here...
10056 * inflow.h (class scoped_ignore_sigttou): ...to here.
10057 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10058 * top.c: Remove include comment.
10059
eb41253a
TT
100602019-05-27 Tom Tromey <tom@tromey.com>
10061
10062 * NEWS: Fix typo.
10063
4ca51187
TT
100642019-05-22 Tom Tromey <tromey@adacore.com>
10065
10066 * target.c (target_follow_exec): Constify parameter.
10067 * target-delegates.c: Rebuild.
10068 * remote.c (remote_target::follow_exec): Constify parameter.
10069 * infrun.c (follow_exec): Constify parameter.
10070 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10071 (target_follow_exec): Likewise.
10072
8fca4da0
AH
100732019-05-22 Alan Hayward <alan.hayward@arm.com>
10074
10075 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10076 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10077
b7060614
AH
100782019-05-22 Alan Hayward <alan.hayward@arm.com>
10079
10080 * NEWS: Add debugredirect and testsuite sections.
10081
0a5954bd
SC
100822019-05-22 Simon Cook <simon.cook@embecosm.com>
10083
10084 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10085 target descriptions using exclusively floating point register name
10086 aliases.
10087
dc42e902
AB
100882019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10089
10090 PR gdb/18644:
10091 * f-lang.c (build_fortran_types): Handle the case where
10092 gdbarch_floatformat_for_type returns a nullptr.
10093
fb7806c7
TV
100942019-05-21 Tom de Vries <tdevries@suse.de>
10095
10096 PR cli/24587
10097 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10098
34d11c68
AB
100992019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10100
10101 PR gdb/18644:
10102 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10103 16-byte floats.
10104 * i386-tdep.c (i386_floatformat_for_type): Use
10105 floatformats_ia64_quad for the 16-byte floating point component
10106 within a fortran 32-byte complex number.
10107
122cf0f2
AB
101082019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10109
10110 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10111 delete default constructor.
10112 (find_partial_die): Update to return const struct.
10113 (partial_die_parent_scope): Move variable declaration into scope
10114 of its use and change its type to auto.
10115 (guess_partial_die_structure_name): Likewise.
10116 (partial_die_info::fixup): Likewise.
10117
33d0e35a
TT
101182019-05-17 Tom Tromey <tromey@adacore.com>
10119
10120 * source.c (find_and_open_source): Remove cast.
10121
a45575b0
TT
101222019-05-17 Tom Tromey <tromey@adacore.com>
10123
10124 * annotate.c (annotate_source): Make "filename" const.
10125 * annotate.h (annotate_source): Use const.
10126
81f47ac2
AH
101272019-05-17 Alan Hayward <alan.hayward@arm.com>
10128
10129 * disasm.c (set_disassembler_options): Send errors to stderr.
10130
ca1285d1
AH
101312019-05-17 Alan Hayward <alan.hayward@arm.com>
10132
10133 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10134 (cli_interp_base::set_logging): Check debug_redirect.
10135 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10136 * cli/cli-logging.c (debug_redirect): Add static variable.
10137 (pop_output_files): Add default param.
10138 (handle_redirections): Print debug setting.
10139 (show_logging_command): Likewise.
10140 (_initialize_cli_logging): Add debugredirect command.
10141 * interps.c (current_interp_set_logging): Add debug_redirect
10142 parameter.
10143 * interps.h (set_logging): Add debug_redirect parameter.
10144 (current_interp_set_logging): Likewise.
10145 * mi/mi-common.h: Likewise.
10146 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10147
101482019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10149 Tom Tromey <tromey@adacore.com>
10150
10151 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10152 directly.
10153 * cli/cli-interp.h (make_logging_output): Remove declaration.
10154 * cli/cli-logging.c (make_logging_output): Remove function.
10155 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10156 directly.
10157 * ui-file.c (tee_file::tee_file): Remove bools.
10158 (tee_file::~tee_file): Remove deletes.
10159 * ui-file.h (tee_file): Remove bools.
10160
26648588
JV
101612019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10162
10163 * mi/mi-cmds.h (mi_cmd_complete): New function.
10164 * mi/mi-main.c (mi_cmd_complete): Likewise.
10165 * mi/mi-cmds.c: Define new MI command -complete.
10166 * NEWS: Mention new -complete command.
10167
6e035501
JV
101682019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10169
10170 * completer.h (complete): New function.
10171 * completer.c (complete): Likewise.
10172 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10173 function defined in completer.h.
10174
7d0e2ece
JV
101752019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10176
e79be6e5 10177 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10178
fb816e8b
TV
101792019-05-17 Tom de Vries <tdevries@suse.de>
10180
10181 PR gdb/24094
10182 * dwarf2read.c (struct cu_partial_die_info): New struct.
10183 (find_partial_die): Return cu_partial_die_info.
10184 (partial_die_parent_scope, guess_partial_die_structure_name)
10185 (partial_die_info::fixup): Handle new return type of find_partial_die.
10186
677052f2
SDJ
101872019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10188
a1726c38 10189 PR breakpoints/24541
677052f2
SDJ
10190 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10191 "std::string", simplifying the algorithm.
10192
f3da9116
SDJ
101932019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10194
10195 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10196 (stap_static_probe_ops::get_probes): Likewise.
10197
f1bb75ab
SDJ
101982019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10199
10200 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10201 '-')" and "else if".
10202 (stap_parse_single_operand): Join checks for
10203 "gdbarch_stap_parse_special_token_p" and
10204 "gdbarch_stap_parse_special_token" in the same "if" statement.
10205 Invert check when verifying for operation on register
10206 displacement.
10207
3ca58cde
SDJ
102082019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10209
10210 * stap-probe.c (stap_get_opcode): Update comment.
10211 (stap_get_expected_argument_type): Likewise.
10212 (handle_stap_probe): Likewise.
10213
af2d9bee
SDJ
102142019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10215
10216 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10217 return type to 'bool'. Adjust comment. Use 'bool' when
10218 appropriate.
10219 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10220 * stap-probe.c (stap_parse_argument_1): Likewise.
10221 (stap_is_operator): Likewise.
10222 (stap_is_generic_prefix): Likewise.
10223 (stap_is_register_prefix): Likewise.
10224 (stap_is_register_indirection_prefix): Likewise.
10225 (stap_is_integer_prefix): Likewise.
10226 (stap_generic_check_suffix): Likewise.
10227 (stap_check_integer_suffix): Likewise.
10228 (stap_check_register_suffix): Likewise.
10229 (stap_check_register_indirection_suffix): Likewise.
10230 (stap_parse_register_operand): Likewise.
10231 (stap_parse_single_operand): Likewise.
10232 (stap_parse_argument_1): Likewise.
10233 (stap_probe::get_argument_count): Likewise.
10234 (stap_is_operator): Likewise.
10235
61c9c421
TT
102362019-05-16 Tom Tromey <tromey@adacore.com>
10237
10238 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10239 keyword to foreach.
10240
9ddc1af1
SM
102412019-05-15 Simon Marchi <simon.marchi@efficios.com>
10242
10243 * linux-thread-db.c (try_thread_db_load_1): Change return type
10244 to bool.
10245 (try_thread_db_load): Likewise.
10246 (try_thread_db_load_from_pdir_1): Likewise.
10247 (try_thread_db_load_from_pdir): Likewise.
10248 (try_thread_db_load_from_sdir): Likewise.
10249 (try_thread_db_load_from_dir): Likewise.
10250 (thread_db_load_search): Likewise.
10251 (has_libpthread): Likewise.
10252 (thread_db_load): Likewise.
10253
7bede828
SDJ
102542019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10255
10256 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10257 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10258 NULL, and complain/return if that's the case.
10259
c5358db4
JD
102602019-05-15 John Darrington <john@darrington.wattle.id.au>
10261
10262 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10263 (advance, posn, abstract_read_memory): New functions.
10264 [struct mem_read_abstraction]: New struct.
10265 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10266
c408a94f
TT
102672019-05-14 Tom Tromey <tromey@adacore.com>
10268
10269 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10270 value is not lval_memory.
10271
e7bd7fba
TT
102722019-05-14 Tom Tromey <tromey@adacore.com>
10273
10274 * solib.c (info_sharedlibrary_command): Style the file name.
10275
a6d0f249
AH
102762019-05-14 Alan Hayward <alan.hayward@arm.com>
10277
10278 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10279 (aarch64_vnv_type): Likewise.
10280 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10281 * common/tdesc.c: Likewise.
10282 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10283 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10284 * features/aarch64-fpu.xml: Add ieee half view.
10285 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10286 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10287 * gdbtypes.h (struct builtin_type): Likewise.
10288 (struct objfile_type): Likewise.
10289
66b8bb74
SM
102902019-05-12 Paul Naert <paul.naert@polymtl.ca>
10291
10292 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10293 typo.
10294 * location.h (string_to_event_location): Likewise.
10295
21c219fd
JB
102962019-05-11 Joel Brobecker <brobecker@adacore.com>
10297
10298 GDB 8.3 released.
10299
13674803
SM
103002019-05-10 Simon Marchi <simon.marchi@efficios.com>
10301
10302 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10303 New variable declaration.
10304 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10305 New variable.
10306 (print_one_breakpoint): Use ui_out::test_flags and new global
10307 variable to compute use_fixed_output.
10308 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10309 Remove.
10310 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10311 (mi_multi_location_breakpoint_output_fixed): Remove.
10312 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10313 new variable.
10314 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10315 fix_multi_location_breakpoint_output flag if version >= 3.
10316 * ui-out.h (enum ui_out_flag)
10317 <fix_multi_location_breakpoint_output>: New enumerator.
10318
a9eac7f9
SM
103192019-05-10 Simon Marchi <simon.marchi@efficios.com>
10320
10321 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10322
71bed2db
TT
103232019-05-10 Tom Tromey <tromey@adacore.com>
10324
10325 * ada-lang.c (catch_ada_completer): New function.
10326 (_initialize_ada_language): Use it.
10327
24c54127
TT
103282019-05-10 Tom Tromey <tromey@adacore.com>
10329
10330 * thread.c (print_thread_info): Make "requested_threads" const.
10331 * gdbthread.h (print_thread_info): Make "requested_threads"
10332 const.
10333 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10334 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10335
7a102139
TT
103362019-05-08 Tom Tromey <tom@tromey.com>
10337
10338 * gdbtypes.c (objfile_type_data): Change type.
10339 (objfile_type, _initialize_gdbtypes): Update.
10340
924d79e2
TT
103412019-05-08 Tom Tromey <tom@tromey.com>
10342
10343 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10344 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10345 (_initialize_dwarf2_frame): Update.
10346
4c58e337
TT
103472019-05-08 Tom Tromey <tom@tromey.com>
10348
10349 * objc-lang.c (objc_objfile_data): Change type.
10350 (find_methods): Update.
10351 (_initialize_objc_lang): Remove.
10352
d772d2ab
TT
103532019-05-08 Tom Tromey <tom@tromey.com>
10354
10355 * stabsread.c (rs6000_builtin_type_data): Change type.
10356 (rs6000_builtin_type, _initialize_stabsread): Update.
10357
d11d83f4
TT
103582019-05-08 Tom Tromey <tom@tromey.com>
10359
10360 * mips-tdep.c (mips_pdr_data): Remove.
10361 (_initialize_mips_tdep): Update.
10362
9a73f0ad
TT
103632019-05-08 Tom Tromey <tom@tromey.com>
10364
10365 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10366 (hppa_init_objfile_priv_data, read_unwind_info)
10367 (find_unwind_entry, _initialize_hppa_tdep): Update.
10368
8127a2fa
TT
103692019-05-08 Tom Tromey <tom@tromey.com>
10370
10371 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10372 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10373 on obstack.
10374 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10375
91d3055d
TT
103762019-05-08 Tom Tromey <tom@tromey.com>
10377
10378 * mdebugread.c (basic_type_data): Change type.
10379 (basic_type, _initialize_mdebugread): Update.
10380
31930bd3
TT
103812019-05-08 Tom Tromey <tom@tromey.com>
10382
10383 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10384
bdb3ed9e
TT
103852019-05-08 Tom Tromey <tom@tromey.com>
10386
10387 * nto-tdep.c (nto_inferior_data_reg): Change type.
10388 (nto_inferior_data): Update.
10389 (nto_inferior_data_cleanup, nto_new_inferior_data)
10390 (_initialize_nto_tdep): Remove.
10391 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10392
f37b313d
TT
103932019-05-08 Tom Tromey <tom@tromey.com>
10394
10395 * ada-lang.c (struct ada_inferior_data): Add initializers.
10396 (ada_inferior_data): Change type.
10397 (ada_inferior_data_cleanup): Remove.
10398 (get_ada_inferior_data, ada_inferior_exit)
10399 (struct ada_pspace_data): Add initializers, destructor.
10400 (ada_pspace_data_handle): Change type.
10401 (get_ada_pspace_data): Update.
10402 (ada_pspace_data_cleanup): Remove.
10403
24699405
TT
104042019-05-08 Tom Tromey <tom@tromey.com>
10405
10406 * coffread.c (struct coff_symfile_info): Add initializers.
10407 (coff_objfile_data_key): Move lower. Change type.
10408 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10409 Update.
10410 (coff_free_info): Remove.
10411
d4e05d2f
TT
104122019-05-08 Tom Tromey <tom@tromey.com>
10413
10414 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10415 (fbsd_pspace_data_handle): Move lower. Change type.
10416 (get_fbsd_pspace_data): Update.
10417 (fbsd_pspace_data_cleanup): Remove.
10418 (_initialize_fbsd_tdep): Update.
10419
14ef6690
TT
104202019-05-08 Tom Tromey <tom@tromey.com>
10421
10422 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10423 (get_ada_tasks_pspace_data): Update.
10424 (ada_tasks_pspace_data_cleanup): Remove.
10425 (_initialize_tasks): Update.
10426 (ada_tasks_inferior_data_handle): Change type.
10427 (get_ada_tasks_inferior_data): Update.
10428 (ada_tasks_inferior_data_cleanup): Remove.
10429 (struct ada_tasks_pspace_data): Add initializers.
10430
814cf43a
TT
104312019-05-08 Tom Tromey <tom@tromey.com>
10432
10433 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10434 * symfile-debug.c (debug_sym_get_probes): Change type.
10435 * stap-probe.c (handle_stap_probe):
10436 (stap_static_probe_ops::get_probes): Change type.
10437 * probe.h (class static_probe_ops) <get_probes>: Change type.
10438 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10439 (parse_probes_in_pspace): Update.
10440 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10441 Update.
10442 (any_static_probe_ops::get_probes): Change type.
10443 * elfread.c (elfread_data): New typedef.
10444 (probe_key): Change type.
10445 (elf_get_probes): Likewise. Update.
10446 (probe_key_free): Remove.
10447 (_initialize_elfread): Update.
10448 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10449 Change type.
10450 (dtrace_process_dof_probe, dtrace_process_dof)
10451 (dtrace_static_probe_ops::get_probe): Change type.
10452
02dc647e
TT
104532019-05-08 Tom Tromey <tom@tromey.com>
10454
10455 * xcoffread.c (struct xcoff_symfile_info): Rename from
10456 coff_symfile_info. Add initializers.
10457 (xcoff_objfile_data_key): Move lower. Change type.
10458 (XCOFF_DATA): Rewrite.
10459 (xcoff_free_info): Remove.
10460 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10461 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10462 (xcoff_initial_scan): Update.
10463
09232438
TT
104642019-05-08 Tom Tromey <tom@tromey.com>
10465
10466 * solib-svr4.c (struct svr4_info): Add initializers and
10467 destructor.
10468 <probes_table>: Now an htab_up.
10469 (solib_svr4_pspace_data): Change type.
10470 (free_probes_table): Simplify.
10471 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10472 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10473 (probes_table_remove_objfile_probes, register_solib_event_probe)
10474 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10475 (_initialize_svr4_solib): Update.
10476
7b4a314f
TT
104772019-05-08 Tom Tromey <tom@tromey.com>
10478
10479 * remote.c (remote_pspace_data): Change type.
10480 (remote_pspace_data_cleanup): Remove.
10481 (get_remote_exec_file, set_pspace_remote_exec_file)
10482 (_initialize_remote): Update.
10483
51d3063a
TT
104842019-05-08 Tom Tromey <tom@tromey.com>
10485
10486 * breakpoint.c (breakpoint_objfile_key): Change type.
10487 (get_breakpoint_objfile_data): Update.
10488 (free_breakpoint_objfile_data): Remove.
10489 (_initialize_breakpoint): Update.
10490
89fb8848
TT
104912019-05-08 Tom Tromey <tom@tromey.com>
10492
10493 * linux-tdep.c (struct linux_info): Add initializers.
10494 (linux_inferior_data): Move. Change type.
10495 (invalidate_linux_cache_inf): Update.
10496 (linux_inferior_data_cleanup): Remove.
10497 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10498
e9b89e2d
TT
104992019-05-08 Tom Tromey <tom@tromey.com>
10500
10501 * auxv.c (auxv_inferior_data): Move. Change type.
10502 (auxv_inferior_data_cleanup): Remove.
10503 (invalidate_auxv_cache_inf): Rewrite.
10504 (get_auxv_inferior_data, _initialize_auxv): Update.
10505
8c42777c
TT
105062019-05-08 Tom Tromey <tom@tromey.com>
10507
10508 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10509 (symfile_debug_objfile_data_key): Change type.
10510 (symfile_debug_installed, debug_qf_has_symbols)
10511 (debug_qf_find_last_source_symtab)
10512 (debug_qf_forget_cached_source_info)
10513 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10514 (debug_qf_print_stats, debug_qf_dump)
10515 (debug_qf_expand_symtabs_for_function)
10516 (debug_qf_expand_all_symtabs)
10517 (debug_qf_expand_symtabs_with_fullname)
10518 (debug_qf_map_matching_symbols)
10519 (debug_qf_expand_symtabs_matching)
10520 (debug_qf_find_pc_sect_compunit_symtab)
10521 (debug_qf_map_symbol_filenames)
10522 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10523 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10524 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10525 (debug_sym_read_linetable, debug_sym_relocate): Update.
10526 (symfile_debug_free_objfile): Remove.
10527 (install_symfile_debug_logging, _initialize_symfile_debug):
10528 Update.
10529
5bfd760d
TT
105302019-05-08 Tom Tromey <tom@tromey.com>
10531
10532 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10533 allocate_on_obstack.
10534 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10535 (get_dwarf2_per_objfile): Update.
10536 (set_dwarf2_per_objfile): Remove.
10537 (dwarf2_has_info, dwarf2_get_section_info): Update.
10538 (dwarf2_free_objfile): Remove.
10539 (_initialize_dwarf2_read): Update.
10540
e85e19b4
TT
105412019-05-08 Tom Tromey <tom@tromey.com>
10542
10543 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10544 initializers.
10545 <unsupported_script_warning_printed,
10546 script_not_found_warning_printed>: Now bool.
10547 (auto_load_pspace_data): Change type.
10548 (~auto_load_pspace_info): Rename from
10549 auto_load_pspace_data_cleanup.
10550 (get_auto_load_pspace_data, init_loaded_scripts_info)
10551 (clear_section_scripts, maybe_print_unsupported_script_warning)
10552 (maybe_print_script_not_found_warning, _initialize_auto_load):
10553 Update.
10554
f6aa7436
TT
105552019-05-08 Tom Tromey <tom@tromey.com>
10556
10557 * objfiles.c (objfile_pspace_info): Add destructor and
10558 initializers.
10559 (objfiles_pspace_data): Change type.
10560 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10561 (get_objfile_pspace_data): Update.
10562 (objfiles_bfd_data): Change type.
10563 (get_objfile_bfd_data): Update.
10564 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10565
6ae614f6
TT
105662019-05-08 Tom Tromey <tom@tromey.com>
10567
10568 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10569 Change type.
10570 (get_catch_syscall_inferior_data): Update.
10571 (catch_syscall_inferior_data_cleanup): Remove.
10572 (_initialize_break_catch_syscall): Update.
10573
6509b8eb
TT
105742019-05-08 Tom Tromey <tom@tromey.com>
10575
10576 * inflow.c (struct terminal_info): Add destructor and
10577 initializers.
10578 (inflow_inferior_data): Change type.
10579 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10580 (get_inflow_inferior_data, inflow_inferior_exit)
10581 (swap_terminal_info, _initialize_inflow): Update.
10582
35632941
TT
105832019-05-08 Tom Tromey <tom@tromey.com>
10584
10585 * target-dcache.c (target_dcache_cleanup): Remove.
10586 (target_dcache_aspace_key): Change type.
10587 (target_dcache_init_p, target_dcache_invalidate)
10588 (target_dcache_get, target_dcache_get_or_init)
10589 (_initialize_target_dcache): Update.
10590 * dcache.h (struct dcache_deleter): New.
10591
3017b94d
TT
105922019-05-08 Tom Tromey <tom@tromey.com>
10593
10594 * symtab.c (struct symbol_cache): Add destructor and
10595 initializers.
10596 (symbol_cache_key): Move. Change type.
10597 (make_symbol_cache, free_symbol_cache): Remove.
10598 (get_symbol_cache): Update.
10599 (symbol_cache_cleanup): Remove.
10600 (ALL_PSPACES, symbol_cache_flush)
10601 (maintenance_print_symbol_cache)
10602 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10603 Update.
10604
a32ad8c5
TT
106052019-05-08 Tom Tromey <tom@tromey.com>
10606
10607 * symtab.c (struct main_info): Add destructor and initializers.
10608 (main_progspace_key): Move. Change type.
10609 (get_main_info): Update.
10610 (main_info_cleanup): Remove.
10611 (_initialize_symtab): Update.
10612
5f6e90a0
TT
106132019-05-08 Tom Tromey <tom@tromey.com>
10614
10615 * registry.h (DECLARE_REGISTRY): Define the _key class.
10616
1bd0c6e4
AB
106172019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10618
10619 * NEWS: Merge two 'New commands' sections.
10620
2228ef77
XR
106212019-05-08 Joel Brobecker <brobecker@adacore.com>
10622
10623 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10624 parameter and use Ada language definition instead.
10625 (ada_val_print_ptr): Remove unused language parameter.
10626 (ada_val_print_num): Remove language parameter and use Ada language
10627 definition instead.
10628 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10629 parameter.
10630 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10631 parameter and use Ada language definition instead.
10632 (ada_val_print_1): Update all ada_val_print_xxx calls.
10633 Remove language parameter.
10634 (ada_val_print): Update ada_val_print_1 call.
10635
60fcc1c3
TT
106362019-05-08 Tom Tromey <tromey@adacore.com>
10637
10638 * remote.c (remote_hw_watchpoint_limit)
10639 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10640 Now static.
10641
ed2b7c17
TT
106422019-05-08 Tom Tromey <tromey@adacore.com>
10643
10644 * maint.c (_initialize_maint_cmds): Move initialization code to
10645 remote.c.
10646 (watchdog, show_watchdog): Move to remote.c.
10647 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10648 "watchdog" static.
10649 (_initialize_remote): Move initialization code from maint.c.
10650 * defs.h (watchdog): Don't declare.
10651
b0be6c91
TT
106522019-05-08 Tom Tromey <tromey@adacore.com>
10653
10654 * tui/tui-interp.c: Include main.h.
10655 * interps.c: Include main.h.
10656 * main.h (interpreter_p): Declare.
10657 * defs.h (interpreter_p): Don't declare.
10658
587ee17b
TT
106592019-05-08 Tom Tromey <tromey@adacore.com>
10660
10661 * dwarf2loc.c: Include dwarf2read.h.
10662 * defs.h (read_unsigned_leb128): Don't declare.
10663 * dwarf2read.h (read_unsigned_leb128): Declare.
10664
ca1df239
TT
106652019-05-08 Tom Tromey <tromey@adacore.com>
10666
10667 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10668 method.
10669
99f20f08
TT
106702019-05-08 Tom Tromey <tromey@adacore.com>
10671
10672 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10673 when no wrap column is set.
10674
80e55b13
TT
106752019-05-08 Tom Tromey <tromey@adacore.com>
10676
10677 * c-lang.c (c_get_string): Handle non-C-style arrays.
10678
9d3421af
TT
106792019-05-08 Tom Tromey <tromey@adacore.com>
10680
10681 * typeprint.c (print_offset_data::update): Print the bit offset,
10682 not the number of bits remaining.
10683
844333e2
TT
106842019-05-08 Tom Tromey <tromey@adacore.com>
10685
10686 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10687 padding at end of comment.
10688
988915ee
TT
106892019-05-08 Tom Tromey <tromey@adacore.com>
10690
10691 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10692 Compare main types.
10693
26bfd823
TT
106942019-05-06 Tom Tromey <tom@tromey.com>
10695
10696 * common/scoped_mmap.c: Include common-defs.h.
10697 * common/scoped_mmap.h: Don't include config.h.
10698
89055eaa
TT
106992019-05-04 Tom Tromey <tom@tromey.com>
10700
10701 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10702 (struct aarch64_call_info): Add initializers.
10703 <si>: Now a std::vector.
10704 (pass_on_stack, aarch64_push_dummy_call): Update.
10705
5da01df5
TT
107062019-05-04 Simon Marchi <simon.marchi@efficios.com>
10707 Tom Tromey <tom@tromey.com>
10708
10709 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10710 (ppc_threads): Now a std::vector. Now static.
10711 (hwdebug_find_thread_points_by_tid)
10712 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10713 Update.
10714
fbdf05a1
TT
107152019-05-04 Tom Tromey <tom@tromey.com>
10716
10717 * arc-tdep.c (arc_tdesc_init): Return bool.
10718
06d16ec9
TT
107192019-05-04 Tom Tromey <tom@tromey.com>
10720
10721 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10722 Use gdb_assert_not_reached.
10723
9c056022
TT
107242019-05-04 Tom Tromey <tom@tromey.com>
10725
10726 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10727 "false".
10728
fa9c2a59
TT
107292019-05-04 Tom Tromey <tom@tromey.com>
10730
10731 * arc-tdep.c (arc_tdesc_init): Use bool.
10732
e2eb806a
TT
107332019-05-04 Tom Tromey <tom@tromey.com>
10734
10735 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10736
6fe87677
TT
107372019-05-04 Tom Tromey <tom@tromey.com>
10738
10739 * cli/cli-cmds.c (valid_command_p): Return bool.
10740
7f008c9e
TT
107412019-05-04 Tom Tromey <tom@tromey.com>
10742
10743 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10744 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10745
b6484282
RT
107462019-05-04 Raul Tambre <raul@tambre.ee>
10747
10748 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10749 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10750 operator for comparison.
10751
af97b416
TT
107522019-05-04 Tom Tromey <tom@tromey.com>
10753
10754 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10755 (lookup_partial_symbol, print_partial_symbols)
10756 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10757 (psymbol_compare): Update.
10758 (add_psymbol_to_bcache): Clear the entire psymbol.
10759 (maintenance_check_psymtabs): Update.
10760 * psympriv.h (struct partial_symbol): Don't derive from
10761 general_symbol_info.
10762 <obj_section, unrelocated_address, address,
10763 set_unrelocated_address>: Update.
10764 <ginfo>: New member.
10765 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10766 (debug_names::write_psymbols): Update.
10767
9d6d4be8
TV
107682019-05-04 Tom de Vries <tdevries@suse.de>
10769
10770 * contrib/cc-with-tweaks.sh: Support -n arg.
10771
66452beb
PW
107722019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10773
10774 * corelow.c (core_target::detach): Ensure frame cache and
10775 register caches are cleared.
10776 inferior.c (exit_inferior_1): Likewise.
10777
bde09ab7
TT
107782019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10779 Tom Tromey <tom@tromey.com>
10780
10781 * dictionary.c (collate_pending_symbols_by_language): Remove
10782 "struct" from foreach.
10783 * symtab.c (lookup_global_symbol_from_objfile)
10784 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10785 foreach.
10786 * ser-tcp.c (net_open): Remove "struct" from foreach.
10787 * objfiles.c (objfile_relocate, objfile_rebase)
10788 (objfile_has_symbols): Remove "struct" from foreach.
10789 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10790 from foreach.
10791 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10792 foreach.
10793 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10794 "struct" from foreach.
10795 * ada-lang.c (create_excep_cond_exprs)
10796 (ada_exception_catchpoint_cond_string): Remove "struct" from
10797 foreach.
10798
222a8d25
TT
107992019-05-03 Tom Tromey <tromey@adacore.com>
10800
10801 * ada-exp.y (convert_char_literal): Check suffix of each
10802 enumerator.
10803
fcd60b84
DP
108042019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10805
10806 PR ada/21406:
10807 * ada-exp.y (yywrap): Don't define.
10808 * ada-lex.l (%option): Add noyywrap
10809 (yywrap): Remove.
10810
5f2459c2
EZ
108112019-05-03 Eli Zaretskii <eliz@gnu.org>
10812
353ea2d1
EZ
10813 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10814 _WIN32_WINNT to the XP level, unless already defined to a higher
10815 level.
10816
10817 * unittests/parse-connection-spec-selftests.c:
10818 * ser-tcp.c:
10819 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10820 override.
10821
5f2459c2
EZ
10822 * symfile.c (find_separate_debug_file): Remove colon from the
10823 drive spec of DOS/Windows file names of the target, so that the
10824 file name produced from DEBUGDIR and the target's directory will
10825 be valid on DOS/Windows systems.
10826
80062eb9
AB
108272019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10828
10829 * rust-lang.c (val_print_struct): Handle printing structures
10830 containing strings.
10831
b8c05e85
TT
108322019-05-02 Tom Tromey <tromey@adacore.com>
10833
10834 * valarith.c (_initialize_valarith): Remove.
10835
4504bbde
TT
108362019-05-01 Tom Tromey <tromey@adacore.com>
10837
10838 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10839 bitfields.
10840
d48e62f4
TT
108412019-05-01 Tom Tromey <tromey@adacore.com>
10842
10843 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10844 for big-endian copies.
10845
15f18d14
AT
108462019-04-30 Ali Tamur <tamur@google.com>
10847 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10848 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10849 (read_3_bytes): New function.
10850
ab4ee614
JB
108512019-04-30 Joel Brobecker <brobecker@adacore.com>
10852
10853 * windows-nat.c (main_thread_id): Delete.
10854 (handle_output_debug_string): Replace main_thread_id by
10855 current_event.dwThreadId.
10856 (fake_create_process): Likewise.
10857 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10858 Do not set main_thread_id.
10859 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10860 current_event.dwThreadId.
10861 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10862
8ed5b76e
JB
108632019-04-30 Joel Brobecker <brobecker@adacore.com>
10864
10865 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10866 Use current_event.dwThreadId instead of main_thread_id.
10867
2ff0a947
TT
108682019-04-30 Tom Tromey <tromey@adacore.com>
10869
10870 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10871 (create_excep_cond_exprs): Iterate over program spaces.
10872 (ada_exception_catchpoint_cond_string): Examine all minimal
10873 symbols for exception types.
10874
a776957c
TT
108752019-04-30 Tom Tromey <tromey@adacore.com>
10876
10877 PR c++/24470:
10878 * dwarf2read.c (process_structure_scope): Handle case where type
10879 has template parameters but no symbol was created.
10880
bc68014d
AB
108812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10882 Chris January <chris.january@arm.com>
10883
10884 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10885 qualifier.
10886 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10887
f1fdc960
AB
108882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10889
10890 * f-typeprint.c (f_print_type): Update rules for printing
10891 whitespace.
10892 (f_type_print_varspec_suffix): Likewise.
10893
bf7a4de1
AB
108942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10895 Chris January <chris.january@arm.com>
10896
10897 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10898 function arguments.
10899
bbe75b9d
AB
109002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10901
10902 * f-lang.c (build_fortran_types): Change name of void type to
10903 lower case.
10904 * f-typeprint.c (f_type_print_base): Print the name of the void
10905 type, rather than a fixed string.
10906 * f-valprint.c (f_decorations): Use lower case void string.
10907
1db455a7
AB
109082019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10909 Chris January <chris.january@arm.com>
10910
10911 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10912 types for Fortran.
10913
b6d03bb2
AB
109142019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10915 Chris January <chris.january@arm.com>
10916 David Lecomber <david.lecomber@arm.com>
10917
10918 * f-exp.y (BINOP_INTRINSIC): New token.
10919 (exp): New parser rule handling BINOP_INTRINSIC.
10920 (f77_keywords): Add new builtin procedures.
10921 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10922 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10923 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10924 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10925 (print_unop_subexp_f): New function.
10926 (print_binop_subexp_f): New function.
10927 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10928 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10929 (dump_subexp_body_f): Likewise.
10930 (operator_check_f): Likewise.
10931 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10932 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10933
83228e93
AB
109342019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10935
10936 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10937 UNOP_KIND.
10938 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10939 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10940 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10941 (operator_length_f): New fuction.
10942 (print_subexp_f): New function.
10943 (op_name_f): New function.
10944 (dump_subexp_body_f): New function.
10945 (operator_check_f): New function.
10946 (exp_descriptor_f): Replace standard expression handling functions
10947 with new functions.
10948 * gdb/fortran-operator.def: New file.
10949 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10950 * gdb/std-operator.def: Remove UNOP_KIND.
10951
6fdcd7cc
AB
109522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10953
10954 * std-operator.def: Remove unbalanced, stray double quote
10955 character.
10956
2e62ab40
AB
109572019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10958 Chris January <chris.january@arm.com>
10959 Daniel Everett <daniel.everett@arm.com>
10960 Nick Forrington <nick.forrington@arm.com>
10961 Richard Bunt <richard.bunt@arm.com>
10962
10963 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10964 of depth when printing anonymous structs or unions.
10965 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10966 Don't print either the top-level value, or the children if the
10967 max-depth is exceeded.
10968 (ppscm_print_children): When printing the key of a map, allow one
10969 extra level of depth.
10970 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10971 print either the top-level value, or the children if the max-depth
10972 is exceeded.
10973 (print_children): When printing the key of a map, allow one extra
10974 level of depth.
10975 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10976 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10977 (user_print_options): Initialise max_depth field.
10978 (val_print_scalar_or_string_type_p): New function.
10979 (val_print): Check to see if the max depth has been reached.
10980 (val_print_check_max_depth): Define new function.
10981 (show_print_max_depth): New function.
10982 (_initialize_valprint): Add 'print max-depth' option.
10983 * valprint.h (struct value_print_options) <max_depth>: New field.
10984 (val_print_check_max_depth): Declare new function.
10985 * NEWS: Document new feature.
10986
4be290b2
AB
109872019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10988
10989 * ada-lang.c (ada_language_defn): Initialise new field.
10990 * c-lang.c (c_is_string_type_p): New function.
10991 (c_language_defn): Initialise new field.
10992 (cplus_language_defn): Initialise new field.
10993 (asm_language_defn): Initialise new field.
10994 (minimal_language_defn): Initialise new field.
10995 * c-lang.h (c_is_string_type_p): Declare new function.
10996 * d-lang.c (d_language_defn): Initialise new field.
10997 * f-lang.c (f_is_string_type_p): New function.
10998 (f_language_defn): Initialise new field.
10999 * go-lang.c (go_is_string_type_p): New function.
11000 (go_language_defn): Initialise new field.
11001 * language.c (default_is_string_type_p): New function.
11002 (unknown_language_defn): Initialise new field.
11003 (auto_language_defn): Initialise new field.
11004 * language.h (struct language_defn) <la_is_string_type_p>: New
11005 member variable.
11006 (default_is_string_type_p): Declare new function.
11007 * m2-lang.c (m2_language_defn): Initialise new field.
11008 * objc-lang.c (objc_language_defn): Initialise new field.
11009 * opencl-lang.c (opencl_language_defn): Initialise new field.
11010 * p-lang.c (pascal_is_string_type_p): New function.
11011 (pascal_language_defn): Initialise new field.
11012 * rust-lang.c (rust_is_string_type_p): New function.
11013 (rust_language_defn): Initialise new field.
11014
721b08c6
AB
110152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11016
11017 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11018 New field.
11019 * ada-lang.c (ada_language_defn): Initialise new field.
11020 * c-lang.c (c_language_defn): Likewise.
11021 (cplus_language_defn): Likewise.
11022 (asm_language_defn): Likewise.
11023 (minimal_language_defn): Likewise.
11024 * d-lang.c (d_language_defn): Likewise.
11025 * f-lang.c (f_language_defn): Likewise.
11026 * go-lang.c (go_language_defn): Likewise.
11027 * language.c (unknown_language_defn): Likewise.
11028 (auto_language_defn): Likewise.
11029 * m2-lang.c (m2_language_defn): Likewise.
11030 * objc-lang.c (objc_language_defn): Likewise.
11031 * opencl-lang.c (opencl_language_defn): Likewise.
11032 * p-lang.c (pascal_language_defn): Likewise.
11033 * rust-lang.c (rust_language_defn): Likewise.
11034
fc913e53
AB
110352019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11036
11037 * ada-lang.c (ada_is_character_type): Change return type to bool.
11038 (ada_is_string_type): Likewise.
11039 * ada-lang.h (ada_is_character_type): Update declaration
11040 (ada_is_string_type): Likewise.
11041
fa731fa0
PW
110422019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11043
11044 Support style in 'frame|thread apply'
11045
11046 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11047 * record.c (record_start, record_stop): Update callers of
11048 execute_command_to_string with false.
11049 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11050 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11051 methods.
11052 (class string_file): New constructor with term_out parameter.
11053 Override methods term_out and can_emit_style_escape. New member
11054 term_out.
11055 (class stdio_file): Override can_emit_style_escape.
11056 (class tee_file): Override term_out and can_emit_style_escape.
11057 * utils.h (can_emit_style_escape): Remove.
11058 * utils.c (can_emit_style_escape): Likewise.
11059 Update all callers of can_emit_style_escape (SOMESTREAM) to
11060 SOMESTREAM->can_emit_style_escape.
11061 * source-cache.c (source_cache::get_source_lines): Likewise.
11062 * stack.c (frame_apply_command_count): Call execute_command_to_string
11063 passing the term_out characteristic of the current gdb_stdout.
11064 * thread.c (thr_try_catch_cmd): Likewise.
11065 * top.c (execute_command_to_string): pass term_out parameter
11066 to construct the string_file for the command output.
11067 * ui-file.c (term_cli_styling): New function (most code moved
11068 from utils.c can_emit_style_escape).
11069 (string_file::string_file, string_file::can_emit_style_escape,
11070 stdio_file::can_emit_style_escape, tee_file::term_out,
11071 tee_file::can_emit_style_escape): New functions.
11072
136afab8
PW
110732019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11074
11075 * NEWS: Mention the new set|show may-call-functions.
11076 * infcall.c (may_call_functions_p): New variable.
11077 (show_may_call_functions_p): New function.
11078 (call_function_by_hand_dummy): Throws an error if not
11079 may-call-functions.
11080 (_initialize_infcall): Call add_setshow_boolean_cmd for
11081 may-call-functions.
11082
725cbb63
KS
110832019-04-25 Keith Seitz <keiths@redhat.com>
11084
11085 PR c++/24367
11086 * cp-support.c (inspect_type): Don't attempt substitutions
11087 of symbol with the same name.
11088
3d1cbb78
TT
110892019-04-25 Tom Tromey <tromey@adacore.com>
11090
11091 PR gdb/24475:
11092 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11093 static.
11094
94aeb44b
TT
110952019-04-25 Tom Tromey <tromey@adacore.com>
11096
11097 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11098 rvalue reference.
11099 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11100 (gdb_xml_parser::parse): Use std::move.
11101 * python/python-internal.h (gdbpy_convert_exception): Take a const
11102 reference.
11103 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11104 std::move.
11105 * python/py-utils.c (gdbpy_convert_exception): Take a const
11106 reference.
11107 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11108 Use std::move.
11109 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11110 Use std::move.
11111 * mi/mi-main.c (mi_print_exception): Take a const reference.
11112 * main.c (handle_command_errors): Take a const reference.
11113 * linespec.c (parse_linespec): Use std::move.
11114 * infcall.c (run_inferior_call): Use std::move.
11115 (call_function_by_hand_dummy): Use std::move.
11116 * exec.c (try_open_exec_file): Use std::move.
11117 * exceptions.h (exception_print, exception_fprintf)
11118 (exception_print_same): Update.
11119 * exceptions.c (print_exception, exception_print)
11120 (exception_fprintf, exception_print_same): Change parameters to
11121 const reference.
11122 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11123 * common/new-op.c: Use std::move.
11124 * common/common-exceptions.h (struct gdb_exception): Add move
11125 constructor.
11126 (struct gdb_exception_error, struct gdb_exception_quit, struct
11127 gdb_quit_bad_alloc): Change constructor to move constructor.
11128 (throw_exception): Change parameter to rvalue reference.
11129 * common/common-exceptions.c (throw_exception): Take rvalue
11130 reference.
11131 * cli/cli-interp.c (safe_execute_command): Use std::move.
11132 * breakpoint.c (insert_bp_location, location_to_sals): Use
11133 std::move.
11134
680d7fd5
TT
111352019-04-25 Tom Tromey <tromey@adacore.com>
11136
11137 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11138 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11139 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11140 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11141 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11142 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11143 guile/scm-value.c: Use unpack.
11144 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11145 gdbscm_gdb_exception.
11146 (gdbscm_throw_gdb_exception): Likewise.
11147 (struct gdbscm_gdb_exception): New.
11148 (unpack): New function.
11149 (gdbscm_wrap): Use unpack.
11150
c6fdd8b2
TT
111512019-04-25 Tom Tromey <tromey@adacore.com>
11152
11153 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11154 (gdb_rl_callback_handler): Use std::move.
11155 * common/common-exceptions.h (struct gdb_exception): Add move
11156 assignment operator.
11157 (throw_exception_sjlj): Change "exception" to const reference.
11158 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11159 (throw_exception_sjlj): Change "exception" to const reference.
11160
cc06b668
TT
111612019-04-25 Tom Tromey <tromey@adacore.com>
11162
11163 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11164 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11165 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11166 Update.
11167 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11168 Update.
11169 * mi/mi-interp.c (mi_interp::exec): Update.
11170 * linespec.c (parse_linespec): Update.
11171 * infcall.c (run_inferior_call): Update.
11172 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11173 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11174 (gdbscm_lookup_global_symbol): Update.
11175 * guile/scm-param.c (gdbscm_parameter_value): Update.
11176 * guile/scm-frame.c (gdbscm_frame_read_register)
11177 (gdbscm_frame_read_var): Update.
11178 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11179 * exec.c (try_open_exec_file): Update.
11180 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11181 (gdb_rl_callback_handler): Update.
11182 * common/common-exceptions.h (exception_none): Don't declare.
11183 * common/common-exceptions.c (exception_none): Don't define.
11184 (struct catcher) <exception>: Update.
11185 * cli/cli-interp.c (safe_execute_command): Update.
11186 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11187
cf532bd1
AT
111882019-04-25 Ali Tamur <tamur@google.com>
11189
11190 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11191 (read_attribute_value): Likewise.
11192 (dwarf2_read_addr_index): Update comment.
11193 (read_str_index): Add DW_FORM_strx.
11194 (dwarf2_string_attr): Likewise.
11195 (dwarf2_const_value_attr): Likewise.
11196 (dump_die_shallow): Likewise.
11197 (dwarf2_fetch_constant_bytes): Likewise.
11198 (skip_form_bytes): Likewise.
11199 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11200
82433e3e
SDJ
112012019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11202
11203 PR corefiles/11608
11204 PR corefiles/18187
11205 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11206 OFFSET. Verify if current mapping contains an ELF header.
11207 (linux_find_memory_regions_full): Adjust call to
11208 dump_mapping_p.
11209
723adb65
SL
112102019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11211 Kang Li <kanglictf@gmail.com>
11212
11213 PR gdb/21600
11214
11215 * dwarf2-frame.c (read_initial_length): Be consistent about using
11216 unsigned representation of length.
11217 (decode_frame_entry_1): Likewise. Check for wraparound of
11218 end pointer as well as buffer overflow.
11219
596179f7
SDJ
112202019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11221
11222 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11223 "vq".
11224
a59240a4
TT
112252019-04-24 Tom Tromey <tromey@adacore.com>
11226
11227 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11228
f872fdbb
AB
112292019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11230
11231 * s12z-tdep.c (s12z_unwind_pc): Delete.
11232 (s12z_unwind_sp): Delete.
11233 (s12z_gdbarch_init): Don't register deleted functions with
11234 gdbarch.
11235
b614e6f3
AB
112362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11237
11238 * rl78-tdep.c (rl78_unwind_sp): Delete.
11239 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11240
14faed38
AB
112412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11242
11243 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11244 (xstormy16_unwind_pc): Delete.
11245 (xstormy16_dummy_id): Delete.
11246 (xstormy16_gdbarch_init): Don't register deleted functions with
11247 gdbarch.
11248
541aad8a
AB
112492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11250
11251 * vax-tdep.c (vax_unwind_pc): Delete.
11252 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11253
29222070
AB
112542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11255
11256 * v850-tdep.c (v850_unwind_sp): Delete.
11257 (v850_unwind_pc): Delete.
11258 (v850_dummy_id): Delete.
11259 (v850_gdbarch_init): Don't register deleted functions with
11260 gdbarch.
11261
0f534d76
AB
112622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11263
11264 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11265 (tilegx_unwind_pc): Delete.
11266 (tilegx_unwind_dummy_id): Delete.
11267 (tilegx_gdbarch_init): Don't register deleted functions with
11268 gdbarch.
11269
1ba7b7f9
AB
112702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11271
11272 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11273 (tic6x_dummy_id): Delete.
11274 (tic6x_gdbarch_init): Don't register deleted functions with
11275 gdbarch.
11276
d31f262c
AB
112772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11278
11279 * sparc-tdep.c (sparc_unwind_pc): Delete.
11280 (sparc32_gdbarch_init): Don't register deleted function with
11281 gdbarch.
11282
6d14d64d
AB
112832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11284
11285 * sh-tdep.c (sh_unwind_sp): Delete.
11286 (sh_unwind_pc): Delete.
11287 (sh_dummy_id): Delete.
11288 (sh_gdbarch_init): Don't register deleted functions with
11289 gdbarch.
11290
a40dde9d
AB
112912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11292
11293 * score-tdep.c (score_unwind_sp): Delete.
11294 (score_unwind_pc): Delete.
11295 (score_dummy_id): Delete.
11296 (score_gdbarch_init): Don't register deleted functions with
11297 gdbarch.
11298
47c47d69
AB
112992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11300
11301 * rx-tdep.c (rx_unwind_pc): Delete.
11302 (rx_unwind_sp): Delete.
11303 (rx_dummy_id): Delete.
11304 (rx_gdbarch_init): Don't register deleted functions with
11305 gdbarch. Update comment.
11306
833a4480
AB
113072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11310 (rs6000_dummy_id): Delete.
11311 (rs6000_gdbarch_init): Don't register deleted functions with
11312 gdbarch.
11313
3f2cef49
AB
113142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11315
11316 * or1k-tdep.c (or1k_dummy_id): Delete.
11317 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11318
96acf884
AB
113192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11320
11321 * nios2-tdep.c (nios2_dummy_id): Delete.
11322 (nios2_unwind_sp): Delete.
11323 (nios2_gdbarch_init): Don't register deleted functions with
11324 gdbarch.
11325
ca0ab0aa
AB
113262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11327
11328 * nds32-tdep.c (nds32_dummy_id): Delete.
11329 (nds32_unwind_pc): Delete.
11330 (nds32_unwind_sp): Delete.
11331 (nds32_gdbarch_init): Don't register deleted functions with
11332 gdbarch.
11333
c8259044
AB
113342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11335
11336 * msp430-tdep.c (msp430_unwind_pc): Delete.
11337 (msp430_unwind_sp): Delete.
11338 (msp430_dummy_id): Delete.
11339 (msp430_gdbarch_init): Don't register deleted functions with
11340 gdbarch.
11341
27f113c8
AB
113422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11343
11344 * moxie-tdep.c (moxie_unwind_sp): Delete.
11345 (moxie_unwind_pc): Delete.
11346 (moxie_dummy_id): Delete.
11347 (moxie_gdbarch_init): Don't register deleted functions with
11348 gdbarch.
11349
aee6c3cd
AB
113502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11351
11352 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11353 (mn10300_unwind_pc): Delete.
11354 (mn10300_unwind_sp): Delete.
11355 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11356 mn10300_unwind_sp.
11357 (mn10300_frame_unwind_init): Don't register deleted functions with
11358 gdbarch.
11359
8e2b5aea
AB
113602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11361
11362 * mep-tdep.c (mep_unwind_pc): Delete.
11363 (mep_unwind_sp): Delete.
11364 (mep_dummy_id): Delete.
11365 (mep_gdbarch_init): Don't register deleted functions with
11366 gdbarch.
11367
43cf3ede
AB
113682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11369
11370 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11371 (m68hc11_unwind_sp): Delete.
11372 (m68hc11_gdbarch_init): Don't register deleted functions with
11373 gdbarch.
11374
5e79b7bb
AB
113752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11376
11377 * m32r-tdep.c (m32r_unwind_sp): Delete.
11378 (m32r_unwind_pc): Delete.
11379 (m32r_dummy_id): Delete.
11380 (m32r_gdbarch_init): Don't register deleted functions with
11381 gdbarch.
11382
89b268d8
AB
113832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11384
11385 * m32c-tdep.c (m32c_unwind_pc): Delete.
11386 (m32c_unwind_sp): Delete.
11387 (m32c_dummy_id): Delete.
11388 (m32c_gdbarch_init): Don't register deleted functions with
11389 gdbarch.
11390
946c28d2
AB
113912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11392
11393 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11394 (lm32_unwind_pc): Delete.
11395 (lm32_dummy_id): Delete.
11396 (lm32_gdbarch_init): Don't register deleted functions with
11397 gdbarch.
11398
bf12844a
AB
113992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11400
11401 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11402 (iq2000_unwind_pc): Delete.
11403 (iq2000_dummy_id): Delete.
11404 (iq2000_gdbarch_init): Don't register deleted functions with
11405 gdbarch.
11406
ecbc06d2
AB
114072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11408
11409 * nds32-tdep.c (nds32_type_align): Delete.
11410 (nds32_push_dummy_call): Use type_align instead.
11411
030197b4
AB
114122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11413
11414 * arm-tdep.c (arm_type_align): Only handle vector override case.
11415 (arm_push_dummy_call): Use type_align.
11416 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11417
b907456c
AB
114182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11419
11420 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11421 case.
11422 (pass_on_stack): Use type_align.
11423 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11424 function.
11425
9e97ba43
TT
114262019-04-23 Tom Tromey <tromey@adacore.com>
11427
11428 * dwarf2read.c (line_header::file_name_at): Remove unused
11429 overload.
11430
6892f601
TV
114312019-04-23 Tom de Vries <tdevries@suse.de>
11432
11433 PR gdb/24438
11434 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11435 invocation.
11436
336d760d
AT
11437
114382019-03-27 Ali Tamur <tamur@google.com>
11439
11440 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11441 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11442 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11443 (dwarf_expr_context::get_addr_index): Likewise
11444 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11445 (symbol_needs_eval_context::get_addr_index): Likewise
11446 (disassemble_dwarf_expression): Add DW_OP_addrx
11447 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11448 (read_cutu_die_from_dwo): Update comment
11449 (skip_one_die): Add DW_FORM_addrx
11450 (read_attribute_value): Likewise
11451 (var_decode_location): Add DW_OP_addrx
11452 (dwarf2_const_value_attr): Add DW_FORM_addrx
11453 (dump_die_shallow): Likewise
11454 (dwarf2_fetch_constant_bytes): Likewise
11455 (decode_locdesc): Add DW_OP_addrx
11456 (skip_form_bytes): Add DW_FORM_addrx
11457
ad9d13f8
AT
114582019-04-22 Ali Tamur <tamur@google.com>
11459
11460 * MAINTAINERS (Write After Approval): Add self.
11461
d70cc3ba
SM
114622019-04-22 Simon Marchi <simon.marchi@efficios.com>
11463
11464 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11465 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11466 (open_symbol_file_object): Likewise.
11467 (svr4_default_sos): Add info parameter.
11468 (svr4_read_so_list): Likewise.
11469 (svr4_current_sos_direct): Adjust functions calls to pass down
11470 info.
11471 (svr4_current_sos_1): Add info parameter.
11472 (svr4_current_sos): Call get_svr4_info, pass info down to
11473 svr4_current_sos_1.
11474 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11475 get_svr4_info.
11476 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11477 get_svr4_info.
11478 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11479 to get_svr4_info.
11480 (probes_table_remove_objfile_probes): Likewise.
11481 (register_solib_event_probe): Add info parameter.
11482 (solist_update_incremental): Pass info parameter down to
11483 svr4_read_so_list.
11484 (disable_probes_interface): Add info parameter.
11485 (svr4_handle_solib_event): Pass current_program_space to
11486 get_svr4_info. Adjust disable_probes_interface cleanup.
11487 (svr4_create_probe_breakpoints): Add info parameter, pass it
11488 down to register_solib_event_probe.
11489 (svr4_create_solib_event_breakpoints): Add info parameter,
11490 pass it down to svr4_create_probe_breakpoints.
11491 (enable_break): Pass info down to
11492 svr4_create_solib_event_breakpoints.
11493 (svr4_solib_create_inferior_hook): Pass current_program_space to
11494 get_svr4_info.
11495 (svr4_clear_solib): Likewise.
11496
7905fc35
PA
114972019-04-22 Pedro Alves <palves@redhat.com>
11498
11499 * solib-svr4.c (svr4_free_objfile_observer): New.
11500 (probe_and_action::objfile): New field.
11501 (probes_table_htab_remove_objfile_probes)
11502 (probes_table_remove_objfile_probes): New functions.
11503 (register_solib_event_probe): Add 'objfile' parameter. Store it
11504 in the new probe_and_action. Don't store the probe in 'lookup'.
11505 (svr4_create_probe_breakpoints): Pass objfile to
11506 register_solib_event_probe.
11507 (_initialize_svr4_solib): Register a free_objfile observer.
11508
fb881986
TT
115092019-04-19 Tom Tromey <tom@tromey.com>
11510
11511 * common/queue.h: Remove.
11512
8732db6c
TT
115132019-04-19 Tom Tromey <tom@tromey.com>
11514
11515 * event-loop.c: Don't include "common/queue.h".
11516
97dfbadd
TT
115172019-04-19 Tom Tromey <tom@tromey.com>
11518
11519 * remote.c (remote_target): Use delete.
11520 * remote-notif.h: Include <list>, not "common/queue.h".
11521 (notif_client_p): Remove typedef.
11522 (remote_notif_state): Add constructor, destructor, initializer.
11523 <notif_queue>: Now a std::list.
11524 (remote_notif_state_xfree): Don't declare.
11525 * remote-notif.c (remote_notif_process, handle_notification)
11526 (remote_notif_state_allocate): Update.
11527 (~remote_notif_state): Rename from remote_notif_state_xfree.
11528
cf250e36
TT
115292019-04-19 Tom Tromey <tom@tromey.com>
11530
11531 * symfile.c (reread_symbols): Update.
11532 * objfiles.c (objfile_register_static_link)
11533 (objfile_lookup_static_link): Update
11534 (~objfile) Don't delete static_links.
11535 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11536
61f4b350
TT
115372019-04-19 Tom Tromey <tom@tromey.com>
11538
11539 * type-stack.h (struct type_stack) <insert>: Constify string.
11540 * type-stack.c (type_stack::insert): Constify string.
11541 * gdbtypes.h (lookup_template_type): Update.
11542 (address_space_name_to_int): Update.
11543 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11544 const.
11545 (lookup_template_type): Make name const.
11546 * c-exp.y: Update rules.
11547 (lex_one_token, classify_name, classify_inner_name)
11548 (c_print_token): Update.
11549 * p-exp.y: Update rules.
11550 (yylex): Update.
11551 * f-exp.y: Update rules.
11552 (yylex): Update.
11553 * d-exp.y: Update rules.
11554 (lex_one_token, classify_name, classify_inner_name): Update.
11555 * parse.c (write_dollar_variable, copy_name): Return std::string.
11556 * parser-defs.h (copy_name): Change return type.
11557 * m2-exp.y: Update rules.
11558 (yylex): Update.
11559 * go-exp.y (lex_one_token): Update.
11560 Update rules.
11561 (classify_unsafe_function, classify_packaged_name)
11562 (classify_name, yylex): Update.
11563
189b8c2e
ST
115642019-04-19 Sergei Trofimovich <siarheit@google.com>
11565
11566 * configure.ac: add --enable-source-highlight switch.
11567 * configure: Regenerate.
11568 * top.c (print_gdb_version): plumb --enable-source-highlight
11569 status to "show configuration".
11570
8ecb59f8
TT
115712019-04-19 Tom Tromey <tromey@adacore.com>
11572
11573 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11574 Check ADA_TYPE_P.
11575 (empty_record, ada_template_to_fixed_record_type_1)
11576 (template_to_static_fixed_type)
11577 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11578 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11579 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11580 macros.
11581
62160ec9
TT
115822019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11583
11584 PR symtab/24423:
11585 * source.c (print_source_lines_base): Advance "iter" when a
11586 control character is seen.
11587
f2ae8bc8
PW
115882019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11589
11590 * inferior.h (struct infcall_suspend_state_deleter):
11591 Catch exception in destructor to avoid crash.
11592
d563b953
PW
115932019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11594
11595 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11596 close to the add_com "shell".
11597
dc34c897
TT
115982019-04-18 Tom Tromey <tromey@adacore.com>
11599
11600 * process-stratum-target.h (class process_stratum_target)
11601 <stratum>: Add "final".
11602
a12e5744
TT
116032019-04-17 Tom Tromey <tromey@adacore.com>
11604
11605 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11606 against nullptr before use.
11607
a7e559cc
AH
116082019-04-17 Alan Hayward <alan.hayward@arm.com>
11609
11610 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11611
c01660c6
AB
116122019-04-17 Jim Wilson <jimw@sifive.com>
11613 Andrew Burgess <andrew.burgess@embecosm.com>
11614
11615 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11616 code read might fail, assume 4-byte breakpoint in that case.
11617
4aa866af
LS
116182019-04-15 Leszek Swirski <leszeks@google.com>
11619
11620 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11621 rather than a hand-rolled POD check when checking for forced MEMORY
11622 classification.
11623
48574d91
AH
116242019-04-15 Alan Hayward <alan.hayward@arm.com>
11625
11626 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11627 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11628 function.
11629 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11630 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11631 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11632 declaration.
11633
4da037ef
AH
116342019-04-15 Alan Hayward <alan.hayward@arm.com>
11635
11636 * aarch64-linux-nat.c
11637 (aarch64_linux_nat_target::thread_architecture): Add override.
11638 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11639 each VQ.
11640
ccb8d7e8
AH
116412019-04-15 Alan Hayward <alan.hayward@arm.com>
11642
11643 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11644
35add35e
AB
116452019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11646
11647 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11648 target types of size 96-bits, add some additional comments, and
11649 check that the builtin type we found was the correct size.
11650
51196bbc
EZ
116512019-04-12 Eli Zaretskii <eliz@gnu.org>
11652
11653 * utils.c (prompt_for_continue): Don't restore the styling at the
11654 end, as applied_style has the wrong value. This fixes styling in
11655 long lists of file names that are interrupted by the "Continue?"
11656 prompt.
11657
62253a61
AB
116582019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11659
11660 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11661 * c-lang.c (c_language_defn): Likewise.
11662 (cplus_language_defn): Likewise.
11663 (asm_language_defn): Likewise.
11664 (minimal_language_defn): Likewise.
11665 * d-lang.c (d_language_defn): Likewise.
11666 * f-lang.c (f_language_defn): Likewise.
11667 * go-lang.c (go_language_defn): Likewise.
11668 * language.c (unknown_language_defn): Likewise.
11669 (auto_language_defn): Likewise.
11670 * language.h (struct language_defn): Remove la_magic field.
11671 (LANG_MAGIC): Delete.
11672 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11673 * objc-lang.c (objc_language_defn): Likewise.
11674 * opencl-lang.c (opencl_language_defn): Likewise.
11675 * p-lang.c (pascal_language_defn): Likewise.
11676 * rust-lang.c (rust_language_defn): Likewise.
11677
a9158a86
AB
116782019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11679
11680 * riscv-tdep.c (riscv_type_align): New function.
11681 (riscv_type_alignment): Delete.
11682 (riscv_arg_location): Use 'type_align'.
11683 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11684
41077b66
AB
116852019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11686
11687 * gdbtypes.c (type_align): A struct with no non-static fields also
11688 has alignment of 1.
11689
9f0272f8
AB
116902019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11691
11692 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11693 component to 0.
11694 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11695 member.
11696 (riscv_struct_info::analyse): New implementation using new
11697 analyse_inner member function.
11698 (riscv_struct_info::field_offset): New member function.
11699 (riscv_struct_info::m_offsets): New member variable.
11700 (riscv_struct_info::analyse_inner): New private member function,
11701 takes the old implementation of riscv_struct_info::analyse but
11702 extended to track field offsets.
11703 (riscv_call_arg_struct): Update the struct folding special cases
11704 to handle cases where empty C++ structs, which are non-zero
11705 length, are found.
11706 (riscv_arg_location): Initialise the length of each location, a
11707 non-zero length now indicates the location is in use.
11708 (riscv_push_dummy_call): Allow for the first location having a
11709 non-zero offset when setting up arguments.
11710 (riscv_return_value): Likewise, but for return values.
11711
02cf60c7
TT
117122019-04-11 Tom Tromey <tromey@adacore.com>
11713
11714 * utils.c (internal_vproblem): Make "msg" const.
11715
68811f8f
AH
117162019-04-11 Alan Hayward <alan.hayward@arm.com>
11717
11718 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11719 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11720 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11721 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11722
3f52fdbc
KB
117232019-04-10 Kevin Buettner <kevinb@redhat.com>
11724
11725 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11726 function.
11727 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11728 of amd64_collect_native_gregset.
11729 (amd64_linux_nat_target::store_registers): Likewise.
11730
e9ad22ee
TT
117312019-04-10 Tom Tromey <tom@tromey.com>
11732
11733 * symtab.c (lookup_global_symbol_from_objfile)
11734 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11735 * objfiles.h (class separate_debug_iterator): New.
11736 (class separate_debug_range): New.
11737 (struct objfile) <separate_debug_objfiles>: New method.
11738 (objfile_separate_debug_iterate): Don't declare.
11739 * objfiles.c (separate_debug_iterator::operator++): Rename from
11740 objfile_separate_debug_iterate.
11741 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11742 iterator.
11743 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11744 iterator.
11745
ee371134
TT
117462019-04-10 Tom Tromey <tom@tromey.com>
11747
11748 * symfile.c (reread_symbols): Remove old comment.
11749 * objfiles.c (free_all_objfiles): Fix a typo.
11750
bf227d61
TT
117512019-04-10 Tom Tromey <tom@tromey.com>
11752
11753 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11754 * minsyms.c (lookup_minimal_symbol): Use foreach.
11755 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11756 (lookup_minimal_symbol_solib_trampoline): Likewise.
11757 * symfile.c (reread_symbols): Use foreach.
11758
8dc433a0
TT
117592019-04-09 Ivan Begert <ivanbegert@gmail.com>
11760 Tom Tromey <tromey@adacore.com>
11761
11762 PR rust/24414:
11763 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11764 (rust_lex_int_test): Change "value" to be LONGEST.
11765 (rust_lex_tests): Add test for long integer literal.
11766
9ab8741a
TT
117672019-04-09 Tom Tromey <tromey@adacore.com>
11768
11769 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11770 to bool.
11771 (extended_remote_target::attach): Update.
11772 (remote_target::remote_notice_new_inferior): Update.
11773 (remote_target::add_current_inferior_and_thread): Update.
11774 * inferior.c (exit_inferior_1): Use "false".
11775 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11776
e242fd12
SM
117772019-04-09 Simon Marchi <simon.marchi@efficios.com>
11778
9ca1957f 11779 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11780 the "start" command.
11781
2b0c8b01
KB
117822019-04-08 Kevin Buettner <kevinb@redhat.com>
11783
11784 * python/py-inferior.c (infpy_thread_from_thread_handle):
11785 Adjust comments to reflect renaming of thread_from_thread_handle
11786 to thread_from_handle. Adjust keywords. Fix type error message.
11787 (inferior_object_methods): Add thread_from_handle. Retain
11788 thread_from_thread_handle, but mark it as deprecated.
11789
50a82723
KB
117902019-04-08 Kevin Buettner <kevinb@redhat.com>
11791
11792 * gdbthread.h (find_thread_by_handle): Revise declaration.
11793 * thread.c (find_thread_by_handle): Likewise. Adjust
11794 implementation too.
11795 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11796 support for buffer objects as handles.
11797
cf63b016
KB
117982019-04-08 Kevin Buettner <kevinb@redhat.com>
11799
11800 * python/py-infthread.c (thpy_thread_handle): New function.
11801 (thread_object_methods): Register thpy_thread_handle.
11802
3d6c6204
KB
118032019-04-08 Kevin Buettner <kevinb@redhat.com>
11804
11805 * gdbthread.h (thread_to_thread_handle): Declare.
11806 * thread.c (gdbtypes.h): Include.
11807 (thread_to_thread_handle): New function.
11808
11809 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11810 (target_thread_info_to_thread_handle): Declare.
11811 * target.c (target_thread_info_to_thread_handle): New function.
11812 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11813 * target-delegates.c: Regenerate.
11814
11815 * linux-thread-db.c (class thread_db_target): Add method
11816 thread_info_to_thread_handle.
11817 (thread_db_target::thread_info_to_thread_handle): Define.
11818 * remote.c (class remote_target): Add new method
11819 thread_info_to_thread_handle.
11820 (remote_target::thread_info_to_thread_handle): Define.
11821
56be6ea8
PA
118222019-04-08 Pedro Alves <palves@redhat.com>
11823
11824 * common/common-exceptions.c (throw_exception): Don't create
11825 named object to throw; throw directly.
11826 (throw_it): Likewise. Don't initialize gdb_exception::message
11827 here, with new; pass FMT and AP to the ctor instead.
11828 * common/common-exceptions.h: Include <string>.
11829 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11830 const char *, va_list)): New ctor. Use std::make_shared.
11831 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11832 errors)): Delete.
11833 (gdb_exception_error::gdb_exception_error(enum errors, const char
11834 *, va_list)): New.
11835 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11836 Add assertion.
11837 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11838 errors)): Delete.
11839 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11840 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11841 Add assertion.
11842
eedc3f4f
TT
118432019-04-08 Tom Tromey <tom@tromey.com>
11844
11845 * valops.c (value_rtti_indirect_type): Replace throw_exception
11846 with throw.
11847 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11848 with throw.
11849 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11850 throw.
11851 * target.c (target_translate_tls_address): Replace throw_exception
11852 with throw.
11853 * stack.c (frame_apply_command_count): Replace throw_exception
11854 with throw.
11855 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11856 throw.
11857 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11858 with throw.
11859 * rs6000-tdep.c (rs6000_frame_cache)
11860 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11861 * remote.c: Replace throw_exception with throw.
11862 * record-full.c (record_full_message, record_full_wait_1)
11863 (record_full_restore): Replace throw_exception with throw.
11864 * record-btrace.c:
11865 (get_thread_current_frame_id, record_btrace_start_replaying)
11866 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11867 (cmd_record_btrace_start): Replace throw_exception with throw.
11868 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11869 throw.
11870 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11871 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11872 * linespec.c:
11873 (find_linespec_symbols): Replace throw_exception with throw.
11874 * infrun.c (displaced_step_prepare, resume): Replace
11875 throw_exception with throw.
11876 * infcmd.c (post_create_inferior): Replace throw_exception with
11877 throw.
11878 * inf-loop.c (inferior_event_handler): Replace throw_exception
11879 with throw.
11880 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11881 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11882 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11883 (get_prev_frame_always, get_frame_pc_if_available)
11884 (get_frame_address_in_block_if_available, get_frame_language):
11885 Replace throw_exception with throw.
11886 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11887 throw_exception with throw.
11888 * eval.c (fetch_subexp_value, evaluate_var_value)
11889 (evaluate_funcall, evaluate_subexp_standard): Replace
11890 throw_exception with throw.
11891 * dwarf2loc.c (call_site_find_chain)
11892 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11893 Replace throw_exception with throw.
11894 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11895 with throw.
11896 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11897 throw.
11898 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11899 * completer.c (complete_line_internal): Replace throw_exception
11900 with throw.
11901 * compile/compile-object-run.c (compile_object_run): Replace
11902 throw_exception with throw.
11903 * cli/cli-script.c (process_next_line): Replace throw_exception
11904 with throw.
11905 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11906 (btrace_enable, btrace_maint_update_pt_packets): Replace
11907 throw_exception with throw.
11908 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11909 throw_exception with throw.
11910 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11911 throw_exception with throw.
11912 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11913 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11914 * aarch64-tdep.c (aarch64_make_prologue_cache)
11915 (aarch64_make_stub_cache): Replace throw_exception with throw.
11916
26003a20
TT
119172019-04-08 Tom Tromey <tom@tromey.com>
11918
11919 * common/common-exceptions.c (throw_exception): Rename from
11920 throw_exception_cxx. Remove old copy. Make argument const.
11921 (throw_it): Create and throw exception objects directly.
11922 * common/common-exceptions.h (throw_exception): Make argument
11923 const.
11924 (struct gdb_exception_error): Add constructor.
11925 (struct gdb_exception_quit): Add constructor.
11926
d272eb37
TT
119272019-04-08 Tom Tromey <tom@tromey.com>
11928
11929 * common/common-exceptions.h (exception_rethrow): Don't declare.
11930 (TRY_SJLJ): Update comment.
11931 (TRY, CATCH, END_CATCH): Remove.
11932 * common/common-exceptions.c (exception_rethrow): Remove.
11933
230d2906
TT
119342019-04-08 Tom Tromey <tom@tromey.com>
11935
11936 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11937 Remove.
11938 (gdb_exception_error): Rename from
11939 gdb_exception_RETURN_MASK_ERROR.
11940 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11941 (gdb_quit_bad_alloc): Update.
11942 * aarch64-tdep.c: Update.
11943 * ada-lang.c: Update.
11944 * ada-typeprint.c: Update.
11945 * ada-valprint.c: Update.
11946 * amd64-tdep.c: Update.
11947 * arch-utils.c: Update.
11948 * break-catch-throw.c: Update.
11949 * breakpoint.c: Update.
11950 * btrace.c: Update.
11951 * c-varobj.c: Update.
11952 * cli/cli-cmds.c: Update.
11953 * cli/cli-interp.c: Update.
11954 * cli/cli-script.c: Update.
11955 * common/common-exceptions.c: Update.
11956 * common/new-op.c: Update.
11957 * common/selftest.c: Update.
11958 * compile/compile-c-symbols.c: Update.
11959 * compile/compile-cplus-symbols.c: Update.
11960 * compile/compile-object-load.c: Update.
11961 * compile/compile-object-run.c: Update.
11962 * completer.c: Update.
11963 * corelow.c: Update.
11964 * cp-abi.c: Update.
11965 * cp-support.c: Update.
11966 * cp-valprint.c: Update.
11967 * darwin-nat.c: Update.
11968 * disasm-selftests.c: Update.
11969 * dtrace-probe.c: Update.
11970 * dwarf-index-cache.c: Update.
11971 * dwarf-index-write.c: Update.
11972 * dwarf2-frame-tailcall.c: Update.
11973 * dwarf2-frame.c: Update.
11974 * dwarf2loc.c: Update.
11975 * dwarf2read.c: Update.
11976 * eval.c: Update.
11977 * event-loop.c: Update.
11978 * event-top.c: Update.
11979 * exec.c: Update.
11980 * f-valprint.c: Update.
11981 * fbsd-tdep.c: Update.
11982 * frame-unwind.c: Update.
11983 * frame.c: Update.
11984 * gdbtypes.c: Update.
11985 * gnu-v3-abi.c: Update.
11986 * guile/guile-internal.h: Update.
11987 * guile/scm-block.c: Update.
11988 * guile/scm-breakpoint.c: Update.
11989 * guile/scm-cmd.c: Update.
11990 * guile/scm-disasm.c: Update.
11991 * guile/scm-frame.c: Update.
11992 * guile/scm-lazy-string.c: Update.
11993 * guile/scm-math.c: Update.
11994 * guile/scm-param.c: Update.
11995 * guile/scm-ports.c: Update.
11996 * guile/scm-pretty-print.c: Update.
11997 * guile/scm-symbol.c: Update.
11998 * guile/scm-symtab.c: Update.
11999 * guile/scm-type.c: Update.
12000 * guile/scm-value.c: Update.
12001 * i386-linux-tdep.c: Update.
12002 * i386-tdep.c: Update.
12003 * inf-loop.c: Update.
12004 * infcall.c: Update.
12005 * infcmd.c: Update.
12006 * infrun.c: Update.
12007 * jit.c: Update.
12008 * language.c: Update.
12009 * linespec.c: Update.
12010 * linux-fork.c: Update.
12011 * linux-nat.c: Update.
12012 * linux-tdep.c: Update.
12013 * linux-thread-db.c: Update.
12014 * main.c: Update.
12015 * mi/mi-cmd-break.c: Update.
12016 * mi/mi-cmd-stack.c: Update.
12017 * mi/mi-interp.c: Update.
12018 * mi/mi-main.c: Update.
12019 * objc-lang.c: Update.
12020 * p-valprint.c: Update.
12021 * parse.c: Update.
12022 * ppc-linux-tdep.c: Update.
12023 * printcmd.c: Update.
12024 * python/py-arch.c: Update.
12025 * python/py-breakpoint.c: Update.
12026 * python/py-cmd.c: Update.
12027 * python/py-finishbreakpoint.c: Update.
12028 * python/py-frame.c: Update.
12029 * python/py-framefilter.c: Update.
12030 * python/py-gdb-readline.c: Update.
12031 * python/py-inferior.c: Update.
12032 * python/py-infthread.c: Update.
12033 * python/py-lazy-string.c: Update.
12034 * python/py-linetable.c: Update.
12035 * python/py-objfile.c: Update.
12036 * python/py-param.c: Update.
12037 * python/py-prettyprint.c: Update.
12038 * python/py-progspace.c: Update.
12039 * python/py-record-btrace.c: Update.
12040 * python/py-record.c: Update.
12041 * python/py-symbol.c: Update.
12042 * python/py-type.c: Update.
12043 * python/py-unwind.c: Update.
12044 * python/py-utils.c: Update.
12045 * python/py-value.c: Update.
12046 * python/python.c: Update.
12047 * record-btrace.c: Update.
12048 * record-full.c: Update.
12049 * remote-fileio.c: Update.
12050 * remote.c: Update.
12051 * riscv-tdep.c: Update.
12052 * rs6000-aix-tdep.c: Update.
12053 * rs6000-tdep.c: Update.
12054 * rust-exp.y: Update.
12055 * rust-lang.c: Update.
12056 * s390-tdep.c: Update.
12057 * selftest-arch.c: Update.
12058 * solib-dsbt.c: Update.
12059 * solib-frv.c: Update.
12060 * solib-spu.c: Update.
12061 * solib-svr4.c: Update.
12062 * solib.c: Update.
12063 * sparc64-linux-tdep.c: Update.
12064 * stack.c: Update.
12065 * symfile-mem.c: Update.
12066 * symmisc.c: Update.
12067 * target.c: Update.
12068 * thread.c: Update.
12069 * top.c: Update.
12070 * tracefile-tfile.c: Update.
12071 * tui/tui.c: Update.
12072 * typeprint.c: Update.
12073 * unittests/cli-utils-selftests.c: Update.
12074 * unittests/parse-connection-spec-selftests.c: Update.
12075 * valops.c: Update.
12076 * valprint.c: Update.
12077 * value.c: Update.
12078 * varobj.c: Update.
12079 * windows-nat.c: Update.
12080 * x86-linux-nat.c: Update.
12081 * xml-support.c: Update.
12082
a70b8144
TT
120832019-04-08 Tom Tromey <tom@tromey.com>
12084
12085 * xml-support.c: Use C++ exception handling.
12086 * x86-linux-nat.c: Use C++ exception handling.
12087 * windows-nat.c: Use C++ exception handling.
12088 * varobj.c: Use C++ exception handling.
12089 * value.c: Use C++ exception handling.
12090 * valprint.c: Use C++ exception handling.
12091 * valops.c: Use C++ exception handling.
12092 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12093 handling.
12094 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12095 * typeprint.c: Use C++ exception handling.
12096 * tui/tui.c: Use C++ exception handling.
12097 * tracefile-tfile.c: Use C++ exception handling.
12098 * top.c: Use C++ exception handling.
12099 * thread.c: Use C++ exception handling.
12100 * target.c: Use C++ exception handling.
12101 * symmisc.c: Use C++ exception handling.
12102 * symfile-mem.c: Use C++ exception handling.
12103 * stack.c: Use C++ exception handling.
12104 * sparc64-linux-tdep.c: Use C++ exception handling.
12105 * solib.c: Use C++ exception handling.
12106 * solib-svr4.c: Use C++ exception handling.
12107 * solib-spu.c: Use C++ exception handling.
12108 * solib-frv.c: Use C++ exception handling.
12109 * solib-dsbt.c: Use C++ exception handling.
12110 * selftest-arch.c: Use C++ exception handling.
12111 * s390-tdep.c: Use C++ exception handling.
12112 * rust-lang.c: Use C++ exception handling.
12113 * rust-exp.y: Use C++ exception handling.
12114 * rs6000-tdep.c: Use C++ exception handling.
12115 * rs6000-aix-tdep.c: Use C++ exception handling.
12116 * riscv-tdep.c: Use C++ exception handling.
12117 * remote.c: Use C++ exception handling.
12118 * remote-fileio.c: Use C++ exception handling.
12119 * record-full.c: Use C++ exception handling.
12120 * record-btrace.c: Use C++ exception handling.
12121 * python/python.c: Use C++ exception handling.
12122 * python/py-value.c: Use C++ exception handling.
12123 * python/py-utils.c: Use C++ exception handling.
12124 * python/py-unwind.c: Use C++ exception handling.
12125 * python/py-type.c: Use C++ exception handling.
12126 * python/py-symbol.c: Use C++ exception handling.
12127 * python/py-record.c: Use C++ exception handling.
12128 * python/py-record-btrace.c: Use C++ exception handling.
12129 * python/py-progspace.c: Use C++ exception handling.
12130 * python/py-prettyprint.c: Use C++ exception handling.
12131 * python/py-param.c: Use C++ exception handling.
12132 * python/py-objfile.c: Use C++ exception handling.
12133 * python/py-linetable.c: Use C++ exception handling.
12134 * python/py-lazy-string.c: Use C++ exception handling.
12135 * python/py-infthread.c: Use C++ exception handling.
12136 * python/py-inferior.c: Use C++ exception handling.
12137 * python/py-gdb-readline.c: Use C++ exception handling.
12138 * python/py-framefilter.c: Use C++ exception handling.
12139 * python/py-frame.c: Use C++ exception handling.
12140 * python/py-finishbreakpoint.c: Use C++ exception handling.
12141 * python/py-cmd.c: Use C++ exception handling.
12142 * python/py-breakpoint.c: Use C++ exception handling.
12143 * python/py-arch.c: Use C++ exception handling.
12144 * printcmd.c: Use C++ exception handling.
12145 * ppc-linux-tdep.c: Use C++ exception handling.
12146 * parse.c: Use C++ exception handling.
12147 * p-valprint.c: Use C++ exception handling.
12148 * objc-lang.c: Use C++ exception handling.
12149 * mi/mi-main.c: Use C++ exception handling.
12150 * mi/mi-interp.c: Use C++ exception handling.
12151 * mi/mi-cmd-stack.c: Use C++ exception handling.
12152 * mi/mi-cmd-break.c: Use C++ exception handling.
12153 * main.c: Use C++ exception handling.
12154 * linux-thread-db.c: Use C++ exception handling.
12155 * linux-tdep.c: Use C++ exception handling.
12156 * linux-nat.c: Use C++ exception handling.
12157 * linux-fork.c: Use C++ exception handling.
12158 * linespec.c: Use C++ exception handling.
12159 * language.c: Use C++ exception handling.
12160 * jit.c: Use C++ exception handling.
12161 * infrun.c: Use C++ exception handling.
12162 * infcmd.c: Use C++ exception handling.
12163 * infcall.c: Use C++ exception handling.
12164 * inf-loop.c: Use C++ exception handling.
12165 * i386-tdep.c: Use C++ exception handling.
12166 * i386-linux-tdep.c: Use C++ exception handling.
12167 * guile/scm-value.c: Use C++ exception handling.
12168 * guile/scm-type.c: Use C++ exception handling.
12169 * guile/scm-symtab.c: Use C++ exception handling.
12170 * guile/scm-symbol.c: Use C++ exception handling.
12171 * guile/scm-pretty-print.c: Use C++ exception handling.
12172 * guile/scm-ports.c: Use C++ exception handling.
12173 * guile/scm-param.c: Use C++ exception handling.
12174 * guile/scm-math.c: Use C++ exception handling.
12175 * guile/scm-lazy-string.c: Use C++ exception handling.
12176 * guile/scm-frame.c: Use C++ exception handling.
12177 * guile/scm-disasm.c: Use C++ exception handling.
12178 * guile/scm-cmd.c: Use C++ exception handling.
12179 * guile/scm-breakpoint.c: Use C++ exception handling.
12180 * guile/scm-block.c: Use C++ exception handling.
12181 * guile/guile-internal.h: Use C++ exception handling.
12182 * gnu-v3-abi.c: Use C++ exception handling.
12183 * gdbtypes.c: Use C++ exception handling.
12184 * frame.c: Use C++ exception handling.
12185 * frame-unwind.c: Use C++ exception handling.
12186 * fbsd-tdep.c: Use C++ exception handling.
12187 * f-valprint.c: Use C++ exception handling.
12188 * exec.c: Use C++ exception handling.
12189 * event-top.c: Use C++ exception handling.
12190 * event-loop.c: Use C++ exception handling.
12191 * eval.c: Use C++ exception handling.
12192 * dwarf2read.c: Use C++ exception handling.
12193 * dwarf2loc.c: Use C++ exception handling.
12194 * dwarf2-frame.c: Use C++ exception handling.
12195 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12196 * dwarf-index-write.c: Use C++ exception handling.
12197 * dwarf-index-cache.c: Use C++ exception handling.
12198 * dtrace-probe.c: Use C++ exception handling.
12199 * disasm-selftests.c: Use C++ exception handling.
12200 * darwin-nat.c: Use C++ exception handling.
12201 * cp-valprint.c: Use C++ exception handling.
12202 * cp-support.c: Use C++ exception handling.
12203 * cp-abi.c: Use C++ exception handling.
12204 * corelow.c: Use C++ exception handling.
12205 * completer.c: Use C++ exception handling.
12206 * compile/compile-object-run.c: Use C++ exception handling.
12207 * compile/compile-object-load.c: Use C++ exception handling.
12208 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12209 * compile/compile-c-symbols.c: Use C++ exception handling.
12210 * common/selftest.c: Use C++ exception handling.
12211 * common/new-op.c: Use C++ exception handling.
12212 * cli/cli-script.c: Use C++ exception handling.
12213 * cli/cli-interp.c: Use C++ exception handling.
12214 * cli/cli-cmds.c: Use C++ exception handling.
12215 * c-varobj.c: Use C++ exception handling.
12216 * btrace.c: Use C++ exception handling.
12217 * breakpoint.c: Use C++ exception handling.
12218 * break-catch-throw.c: Use C++ exception handling.
12219 * arch-utils.c: Use C++ exception handling.
12220 * amd64-tdep.c: Use C++ exception handling.
12221 * ada-valprint.c: Use C++ exception handling.
12222 * ada-typeprint.c: Use C++ exception handling.
12223 * ada-lang.c: Use C++ exception handling.
12224 * aarch64-tdep.c: Use C++ exception handling.
12225
3d6e9d23
TT
122262019-04-08 Tom Tromey <tom@tromey.com>
12227
12228 * xml-support.c (gdb_xml_parser::parse): Update.
12229 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12230 * value.c (show_convenience): Update.
12231 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12232 (test_parse_flags_qcs): Update.
12233 * thread.c (thr_try_catch_cmd): Update.
12234 * target.c (target_translate_tls_address): Update.
12235 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12236 (info_frame_command_core, frame_apply_command_count): Update.
12237 * rust-exp.y (rust_lex_exception_test): Update.
12238 * riscv-tdep.c (riscv_print_one_register_info): Update.
12239 * remote.c (remote_target::enable_btrace): Update.
12240 * record-btrace.c (record_btrace_enable_warn): Update.
12241 * python/py-utils.c (gdbpy_convert_exception): Update.
12242 * printcmd.c (do_one_display, print_variable_and_value): Update.
12243 * mi/mi-main.c (mi_print_exception): Update.
12244 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12245 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12246 * linux-nat.c (linux_nat_target::attach): Update.
12247 * linux-fork.c (class scoped_switch_fork_info): Update.
12248 * infrun.c (displaced_step_prepare): Update.
12249 * infcall.c (call_function_by_hand_dummy): Update.
12250 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12251 * gnu-v3-abi.c (print_one_vtable): Update.
12252 * frame.c (get_prev_frame_always): Update.
12253 * f-valprint.c (info_common_command_for_block): Update.
12254 * exec.c (try_open_exec_file): Update.
12255 * exceptions.c (print_exception, exception_print)
12256 (exception_fprintf, exception_print_same): Update.
12257 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12258 * dwarf-index-cache.c (index_cache::store)
12259 (index_cache::lookup_gdb_index): Update.
12260 * darwin-nat.c (maybe_cache_shell): Update.
12261 * cp-valprint.c (cp_print_value_fields): Update.
12262 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12263 (gcc_cplus_symbol_address): Update.
12264 * compile/compile-c-symbols.c (gcc_convert_symbol)
12265 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12266 * common/selftest.c: Update.
12267 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12268 a std::string.
12269 (exception_try_scope_entry, exception_try_scope_exit): Don't
12270 declare.
12271 (struct exception_try_scope): Remove.
12272 (TRY): Don't use exception_try_scope.
12273 (struct gdb_exception): Add constructor, operator=.
12274 <what>: New method.
12275 (struct gdb_exception_RETURN_MASK_ALL)
12276 (struct gdb_exception_RETURN_MASK_ERROR)
12277 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12278 (struct gdb_quit_bad_alloc): Update.
12279 * common/common-exceptions.c (exception_none): Change
12280 initializer.
12281 (struct catcher) <state, exception>: Initialize inline.
12282 <prev>: Remove member.
12283 (current_catcher): Remove.
12284 (catchers): New global.
12285 (exceptions_state_mc_init): Simplify.
12286 (catcher_pop): Remove.
12287 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12288 (try_scope_depth, exception_try_scope_entry)
12289 (exception_try_scope_exit): Remove.
12290 (throw_exception_sjlj): Update.
12291 (exception_messages, exception_messages_size): Remove.
12292 (throw_it): Simplify.
12293 (gdb_exception_sliced_copy): Remove.
12294 (throw_exception_cxx): Update.
12295 * cli/cli-script.c (script_from_file): Update.
12296 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12297 Update.
12298 * ada-valprint.c (ada_val_print): Update.
12299 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12300 (create_excep_cond_exprs): Update.
12301
c5c10118
TT
123022019-04-08 Tom Tromey <tom@tromey.com>
12303
12304 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12305 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12306 (TRY, CATCH, END_CATCH): Remove some definitions.
12307 * common/common-exceptions.c: Don't use GDB_XCPT.
12308 (catcher_list_size): Remove.
12309 (throw_exception, throw_it): Simplify.
12310
4de283e4
TT
123112019-04-05 Tom Tromey <tom@tromey.com>
12312
12313 Revert the header-sorting patch.
12314 * ft32-tdep.c: Revert.
12315 * frv-tdep.c: Revert.
12316 * frv-linux-tdep.c: Revert.
12317 * frame.c: Revert.
12318 * frame-unwind.c: Revert.
12319 * frame-base.c: Revert.
12320 * fork-child.c: Revert.
12321 * findvar.c: Revert.
12322 * findcmd.c: Revert.
12323 * filesystem.c: Revert.
12324 * filename-seen-cache.h: Revert.
12325 * filename-seen-cache.c: Revert.
12326 * fbsd-tdep.c: Revert.
12327 * fbsd-nat.h: Revert.
12328 * fbsd-nat.c: Revert.
12329 * f-valprint.c: Revert.
12330 * f-typeprint.c: Revert.
12331 * f-lang.c: Revert.
12332 * extension.h: Revert.
12333 * extension.c: Revert.
12334 * extension-priv.h: Revert.
12335 * expprint.c: Revert.
12336 * exec.h: Revert.
12337 * exec.c: Revert.
12338 * exceptions.c: Revert.
12339 * event-top.c: Revert.
12340 * event-loop.c: Revert.
12341 * eval.c: Revert.
12342 * elfread.c: Revert.
12343 * dwarf2read.h: Revert.
12344 * dwarf2read.c: Revert.
12345 * dwarf2loc.c: Revert.
12346 * dwarf2expr.h: Revert.
12347 * dwarf2expr.c: Revert.
12348 * dwarf2-frame.c: Revert.
12349 * dwarf2-frame-tailcall.c: Revert.
12350 * dwarf-index-write.h: Revert.
12351 * dwarf-index-write.c: Revert.
12352 * dwarf-index-common.c: Revert.
12353 * dwarf-index-cache.h: Revert.
12354 * dwarf-index-cache.c: Revert.
12355 * dummy-frame.c: Revert.
12356 * dtrace-probe.c: Revert.
12357 * disasm.h: Revert.
12358 * disasm.c: Revert.
12359 * disasm-selftests.c: Revert.
12360 * dictionary.c: Revert.
12361 * dicos-tdep.c: Revert.
12362 * demangle.c: Revert.
12363 * dcache.h: Revert.
12364 * dcache.c: Revert.
12365 * darwin-nat.h: Revert.
12366 * darwin-nat.c: Revert.
12367 * darwin-nat-info.c: Revert.
12368 * d-valprint.c: Revert.
12369 * d-namespace.c: Revert.
12370 * d-lang.c: Revert.
12371 * ctf.c: Revert.
12372 * csky-tdep.c: Revert.
12373 * csky-linux-tdep.c: Revert.
12374 * cris-tdep.c: Revert.
12375 * cris-linux-tdep.c: Revert.
12376 * cp-valprint.c: Revert.
12377 * cp-support.c: Revert.
12378 * cp-namespace.c: Revert.
12379 * cp-abi.c: Revert.
12380 * corelow.c: Revert.
12381 * corefile.c: Revert.
12382 * continuations.c: Revert.
12383 * completer.h: Revert.
12384 * completer.c: Revert.
12385 * complaints.c: Revert.
12386 * coffread.c: Revert.
12387 * coff-pe-read.c: Revert.
12388 * cli-out.h: Revert.
12389 * cli-out.c: Revert.
12390 * charset.c: Revert.
12391 * c-varobj.c: Revert.
12392 * c-valprint.c: Revert.
12393 * c-typeprint.c: Revert.
12394 * c-lang.c: Revert.
12395 * buildsym.c: Revert.
12396 * buildsym-legacy.c: Revert.
12397 * build-id.h: Revert.
12398 * build-id.c: Revert.
12399 * btrace.c: Revert.
12400 * bsd-uthread.c: Revert.
12401 * breakpoint.h: Revert.
12402 * breakpoint.c: Revert.
12403 * break-catch-throw.c: Revert.
12404 * break-catch-syscall.c: Revert.
12405 * break-catch-sig.c: Revert.
12406 * blockframe.c: Revert.
12407 * block.c: Revert.
12408 * bfin-tdep.c: Revert.
12409 * bfin-linux-tdep.c: Revert.
12410 * bfd-target.c: Revert.
12411 * bcache.c: Revert.
12412 * ax-general.c: Revert.
12413 * ax-gdb.h: Revert.
12414 * ax-gdb.c: Revert.
12415 * avr-tdep.c: Revert.
12416 * auxv.c: Revert.
12417 * auto-load.c: Revert.
12418 * arm-wince-tdep.c: Revert.
12419 * arm-tdep.c: Revert.
12420 * arm-symbian-tdep.c: Revert.
12421 * arm-pikeos-tdep.c: Revert.
12422 * arm-obsd-tdep.c: Revert.
12423 * arm-nbsd-tdep.c: Revert.
12424 * arm-nbsd-nat.c: Revert.
12425 * arm-linux-tdep.c: Revert.
12426 * arm-linux-nat.c: Revert.
12427 * arm-fbsd-tdep.c: Revert.
12428 * arm-fbsd-nat.c: Revert.
12429 * arm-bsd-tdep.c: Revert.
12430 * arch-utils.c: Revert.
12431 * arc-tdep.c: Revert.
12432 * arc-newlib-tdep.c: Revert.
12433 * annotate.h: Revert.
12434 * annotate.c: Revert.
12435 * amd64-windows-tdep.c: Revert.
12436 * amd64-windows-nat.c: Revert.
12437 * amd64-tdep.c: Revert.
12438 * amd64-sol2-tdep.c: Revert.
12439 * amd64-obsd-tdep.c: Revert.
12440 * amd64-obsd-nat.c: Revert.
12441 * amd64-nbsd-tdep.c: Revert.
12442 * amd64-nbsd-nat.c: Revert.
12443 * amd64-nat.c: Revert.
12444 * amd64-linux-tdep.c: Revert.
12445 * amd64-linux-nat.c: Revert.
12446 * amd64-fbsd-tdep.c: Revert.
12447 * amd64-fbsd-nat.c: Revert.
12448 * amd64-dicos-tdep.c: Revert.
12449 * amd64-darwin-tdep.c: Revert.
12450 * amd64-bsd-nat.c: Revert.
12451 * alpha-tdep.c: Revert.
12452 * alpha-obsd-tdep.c: Revert.
12453 * alpha-nbsd-tdep.c: Revert.
12454 * alpha-mdebug-tdep.c: Revert.
12455 * alpha-linux-tdep.c: Revert.
12456 * alpha-linux-nat.c: Revert.
12457 * alpha-bsd-tdep.c: Revert.
12458 * alpha-bsd-nat.c: Revert.
12459 * aix-thread.c: Revert.
12460 * agent.c: Revert.
12461 * addrmap.c: Revert.
12462 * ada-varobj.c: Revert.
12463 * ada-valprint.c: Revert.
12464 * ada-typeprint.c: Revert.
12465 * ada-tasks.c: Revert.
12466 * ada-lang.c: Revert.
12467 * aarch64-tdep.c: Revert.
12468 * aarch64-ravenscar-thread.c: Revert.
12469 * aarch64-newlib-tdep.c: Revert.
12470 * aarch64-linux-tdep.c: Revert.
12471 * aarch64-linux-nat.c: Revert.
12472 * aarch64-fbsd-tdep.c: Revert.
12473 * aarch64-fbsd-nat.c: Revert.
12474 * aarch32-linux-nat.c: Revert.
12475
d55e5aa6
TT
124762019-04-05 Tom Tromey <tom@tromey.com>
12477
12478 * ft32-tdep.c: Sort headers.
12479 * frv-tdep.c: Sort headers.
12480 * frv-linux-tdep.c: Sort headers.
12481 * frame.c: Sort headers.
12482 * frame-unwind.c: Sort headers.
12483 * frame-base.c: Sort headers.
12484 * fork-child.c: Sort headers.
12485 * findvar.c: Sort headers.
12486 * findcmd.c: Sort headers.
12487 * filesystem.c: Sort headers.
12488 * filename-seen-cache.h: Sort headers.
12489 * filename-seen-cache.c: Sort headers.
12490 * fbsd-tdep.c: Sort headers.
12491 * fbsd-nat.h: Sort headers.
12492 * fbsd-nat.c: Sort headers.
12493 * f-valprint.c: Sort headers.
12494 * f-typeprint.c: Sort headers.
12495 * f-lang.c: Sort headers.
12496 * extension.h: Sort headers.
12497 * extension.c: Sort headers.
12498 * extension-priv.h: Sort headers.
12499 * expprint.c: Sort headers.
12500 * exec.h: Sort headers.
12501 * exec.c: Sort headers.
12502 * exceptions.c: Sort headers.
12503 * event-top.c: Sort headers.
12504 * event-loop.c: Sort headers.
12505 * eval.c: Sort headers.
12506 * elfread.c: Sort headers.
12507 * dwarf2read.h: Sort headers.
12508 * dwarf2read.c: Sort headers.
12509 * dwarf2loc.c: Sort headers.
12510 * dwarf2expr.h: Sort headers.
12511 * dwarf2expr.c: Sort headers.
12512 * dwarf2-frame.c: Sort headers.
12513 * dwarf2-frame-tailcall.c: Sort headers.
12514 * dwarf-index-write.h: Sort headers.
12515 * dwarf-index-write.c: Sort headers.
12516 * dwarf-index-common.c: Sort headers.
12517 * dwarf-index-cache.h: Sort headers.
12518 * dwarf-index-cache.c: Sort headers.
12519 * dummy-frame.c: Sort headers.
12520 * dtrace-probe.c: Sort headers.
12521 * disasm.h: Sort headers.
12522 * disasm.c: Sort headers.
12523 * disasm-selftests.c: Sort headers.
12524 * dictionary.c: Sort headers.
12525 * dicos-tdep.c: Sort headers.
12526 * demangle.c: Sort headers.
12527 * dcache.h: Sort headers.
12528 * dcache.c: Sort headers.
12529 * darwin-nat.h: Sort headers.
12530 * darwin-nat.c: Sort headers.
12531 * darwin-nat-info.c: Sort headers.
12532 * d-valprint.c: Sort headers.
12533 * d-namespace.c: Sort headers.
12534 * d-lang.c: Sort headers.
12535 * ctf.c: Sort headers.
12536 * csky-tdep.c: Sort headers.
12537 * csky-linux-tdep.c: Sort headers.
12538 * cris-tdep.c: Sort headers.
12539 * cris-linux-tdep.c: Sort headers.
12540 * cp-valprint.c: Sort headers.
12541 * cp-support.c: Sort headers.
12542 * cp-namespace.c: Sort headers.
12543 * cp-abi.c: Sort headers.
12544 * corelow.c: Sort headers.
12545 * corefile.c: Sort headers.
12546 * continuations.c: Sort headers.
12547 * completer.h: Sort headers.
12548 * completer.c: Sort headers.
12549 * complaints.c: Sort headers.
12550 * coffread.c: Sort headers.
12551 * coff-pe-read.c: Sort headers.
12552 * cli-out.h: Sort headers.
12553 * cli-out.c: Sort headers.
12554 * charset.c: Sort headers.
12555 * c-varobj.c: Sort headers.
12556 * c-valprint.c: Sort headers.
12557 * c-typeprint.c: Sort headers.
12558 * c-lang.c: Sort headers.
12559 * buildsym.c: Sort headers.
12560 * buildsym-legacy.c: Sort headers.
12561 * build-id.h: Sort headers.
12562 * build-id.c: Sort headers.
12563 * btrace.c: Sort headers.
12564 * bsd-uthread.c: Sort headers.
12565 * breakpoint.h: Sort headers.
12566 * breakpoint.c: Sort headers.
12567 * break-catch-throw.c: Sort headers.
12568 * break-catch-syscall.c: Sort headers.
12569 * break-catch-sig.c: Sort headers.
12570 * blockframe.c: Sort headers.
12571 * block.c: Sort headers.
12572 * bfin-tdep.c: Sort headers.
12573 * bfin-linux-tdep.c: Sort headers.
12574 * bfd-target.c: Sort headers.
12575 * bcache.c: Sort headers.
12576 * ax-general.c: Sort headers.
12577 * ax-gdb.h: Sort headers.
12578 * ax-gdb.c: Sort headers.
12579 * avr-tdep.c: Sort headers.
12580 * auxv.c: Sort headers.
12581 * auto-load.c: Sort headers.
12582 * arm-wince-tdep.c: Sort headers.
12583 * arm-tdep.c: Sort headers.
12584 * arm-symbian-tdep.c: Sort headers.
12585 * arm-pikeos-tdep.c: Sort headers.
12586 * arm-obsd-tdep.c: Sort headers.
12587 * arm-nbsd-tdep.c: Sort headers.
12588 * arm-nbsd-nat.c: Sort headers.
12589 * arm-linux-tdep.c: Sort headers.
12590 * arm-linux-nat.c: Sort headers.
12591 * arm-fbsd-tdep.c: Sort headers.
12592 * arm-fbsd-nat.c: Sort headers.
12593 * arm-bsd-tdep.c: Sort headers.
12594 * arch-utils.c: Sort headers.
12595 * arc-tdep.c: Sort headers.
12596 * arc-newlib-tdep.c: Sort headers.
12597 * annotate.h: Sort headers.
12598 * annotate.c: Sort headers.
12599 * amd64-windows-tdep.c: Sort headers.
12600 * amd64-windows-nat.c: Sort headers.
12601 * amd64-tdep.c: Sort headers.
12602 * amd64-sol2-tdep.c: Sort headers.
12603 * amd64-obsd-tdep.c: Sort headers.
12604 * amd64-obsd-nat.c: Sort headers.
12605 * amd64-nbsd-tdep.c: Sort headers.
12606 * amd64-nbsd-nat.c: Sort headers.
12607 * amd64-nat.c: Sort headers.
12608 * amd64-linux-tdep.c: Sort headers.
12609 * amd64-linux-nat.c: Sort headers.
12610 * amd64-fbsd-tdep.c: Sort headers.
12611 * amd64-fbsd-nat.c: Sort headers.
12612 * amd64-dicos-tdep.c: Sort headers.
12613 * amd64-darwin-tdep.c: Sort headers.
12614 * amd64-bsd-nat.c: Sort headers.
12615 * alpha-tdep.c: Sort headers.
12616 * alpha-obsd-tdep.c: Sort headers.
12617 * alpha-nbsd-tdep.c: Sort headers.
12618 * alpha-mdebug-tdep.c: Sort headers.
12619 * alpha-linux-tdep.c: Sort headers.
12620 * alpha-linux-nat.c: Sort headers.
12621 * alpha-bsd-tdep.c: Sort headers.
12622 * alpha-bsd-nat.c: Sort headers.
12623 * aix-thread.c: Sort headers.
12624 * agent.c: Sort headers.
12625 * addrmap.c: Sort headers.
12626 * ada-varobj.c: Sort headers.
12627 * ada-valprint.c: Sort headers.
12628 * ada-typeprint.c: Sort headers.
12629 * ada-tasks.c: Sort headers.
12630 * ada-lang.c: Sort headers.
12631 * aarch64-tdep.c: Sort headers.
12632 * aarch64-ravenscar-thread.c: Sort headers.
12633 * aarch64-newlib-tdep.c: Sort headers.
12634 * aarch64-linux-tdep.c: Sort headers.
12635 * aarch64-linux-nat.c: Sort headers.
12636 * aarch64-fbsd-tdep.c: Sort headers.
12637 * aarch64-fbsd-nat.c: Sort headers.
12638 * aarch32-linux-nat.c: Sort headers.
12639
699bd4cf
TT
126402019-04-04 Tom Tromey <tom@tromey.com>
12641
12642 * varobj.c (varobj_create): Update.
12643 * rust-exp.y (struct rust_parser) <update_innermost_block,
12644 lookup_symbol>: New methods.
12645 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12646 Rename.
12647 (rust_parser::rust_lookup_type)
12648 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12649 * printcmd.c (display_command, do_one_display): Update.
12650 * parser-defs.h (struct parser_state) <parser_state>: Add
12651 "tracker" parameter.
12652 (block_tracker): New member.
12653 (class innermost_block_tracker) <innermost_block_tracker>: Add
12654 "types" parameter.
12655 <reset>: Remove method.
12656 (innermost_block): Don't declare.
12657 (null_post_parser): Update.
12658 * parse.c (innermost_block): Remove global.
12659 (write_dollar_variable): Update.
12660 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12661 Remove "tracker_types" parameter.
12662 (parse_expression): Add "tracker" parameter.
12663 (parse_expression_for_completion): Update.
12664 (null_post_parser): Add "tracker" parameter.
12665 * p-exp.y: Update rules.
12666 * m2-exp.y: Update rules.
12667 * language.h (struct language_defn) <la_post_parser>: Add
12668 "tracker" parameter.
12669 * go-exp.y: Update rules.
12670 * f-exp.y: Update rules.
12671 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12672 parameter.
12673 * d-exp.y: Update rules.
12674 * c-exp.y: Update rules.
12675 * breakpoint.c (set_breakpoint_condition): Create an
12676 innermost_block_tracker.
12677 (watch_command_1): Likewise.
12678 * ada-lang.c (resolve): Add "tracker" parameter.
12679 (resolve_subexp): Likewise.
12680 * ada-exp.y (write_var_from_sym): Update.
12681
dac43e32
TT
126822019-04-04 Tom Tromey <tom@tromey.com>
12683
12684 * type-stack.h: New file.
12685 * type-stack.c: New file.
12686 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12687 type-stack.h.
12688 (insert_into_type_stack, insert_type, push_type, push_type_int)
12689 (insert_type_address_space, pop_type, pop_type_int)
12690 (pop_typelist, pop_type_stack, append_type_stack)
12691 (push_type_stack, get_type_stack, push_typelist)
12692 (follow_type_instance_flags, follow_types): Don't declare.
12693 * parse.c (type_stack): Remove global.
12694 (parse_exp_in_context): Update.
12695 (insert_into_type_stack, insert_type, push_type, push_type_int)
12696 (insert_type_address_space, pop_type, pop_type_int)
12697 (pop_typelist, pop_type_stack, append_type_stack)
12698 (push_type_stack, get_type_stack, push_typelist)
12699 (follow_type_instance_flags, follow_types): Remove (moved to
12700 type-stack.c).
12701 * f-exp.y (type_stack): New global.
12702 Update rules.
12703 (push_kind_type, f_parse): Update.
12704 * d-exp.y (type_stack): New global.
12705 Update rules.
12706 (d_parse): Update.
12707 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12708 Update rules.
12709 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12710 (HFILES_NO_SRCDIR): Add type-stack.h.
12711
2a612529
TT
127122019-04-04 Tom Tromey <tom@tromey.com>
12713
12714 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12715 (rust_parser::convert_ast_to_expression, rust_parse)
12716 (rust_lex_test_completion, rust_lex_tests): Update.
12717 * parser-defs.h (struct expr_completion_state): New.
12718 (struct parser_state) <parser_state>: Add completion parameter.
12719 <mark_struct_expression, mark_completion_tag>: New methods.
12720 <parse_completion, m_completion_state>: New members.
12721 (prefixify_expression, null_post_parser): Update.
12722 (mark_struct_expression, mark_completion_tag): Don't declare.
12723 * parse.c (parse_completion, expout_last_struct)
12724 (expout_tag_completion_type, expout_completion_name): Remove
12725 globals.
12726 (parser_state::mark_struct_expression)
12727 (parser_state::mark_completion_tag): Now methods.
12728 (prefixify_expression): Add last_struct parameter.
12729 (prefixify_subexp): Likewise.
12730 (parse_exp_1): Update.
12731 (parse_exp_in_context): Add cstate parameter. Update.
12732 (parse_expression_for_completion): Create an
12733 expr_completion_state.
12734 (null_post_parser): Add "completion" parameter.
12735 * p-exp.y: Update rules.
12736 (yylex): Update.
12737 * language.h (struct language_defn) <la_post_parser>: Add
12738 "completing" parameter.
12739 * go-exp.y: Update rules.
12740 (lex_one_token): Update.
12741 * expression.h (parse_completion): Don't declare.
12742 * d-exp.y: Update rules.
12743 (lex_one_token): Update rules.
12744 * c-exp.y: Update rules.
12745 (lex_one_token): Update.
12746 * ada-lang.c (resolve): Add "parse_completion" parameter.
12747 (resolve_subexp): Likewise.
12748 (ada_resolve_function): Likewise.
12749
43476f0b
TT
127502019-04-04 Tom Tromey <tom@tromey.com>
12751
12752 * parser-defs.h (struct parser_state) <start_arglist,
12753 end_arglist>: New methods.
12754 <arglist_len, m_funcall_chain>: New members.
12755 (arglist_len, start_arglist, end_arglist): Don't declare.
12756 * parse.c (arglist_len, funcall_chain): Remove global.
12757 (start_arglist, end_arglist): Remove functions.
12758 (parse_exp_in_context): Update.
12759 * p-exp.y: Update rules.
12760 * m2-exp.y: Update rules.
12761 * go-exp.y: Update rules.
12762 * f-exp.y: Update rules.
12763 * d-exp.y: Update rules.
12764 * c-exp.y: Update rules.
12765
5776fca3
TT
127662019-04-04 Tom Tromey <tom@tromey.com>
12767
12768 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12769 lex_operator, push_back>: New methods.
12770 Update all rules.
12771 (rust_parser::lex_hex, lex_escape): Rename and update.
12772 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12773 (rust_parser::lex_operator): Rename and update.
12774 (rust_parser::lex_number, rustyylex, rustyyerror)
12775 (rust_lex_test_init, rust_lex_test_sequence)
12776 (rust_lex_test_push_back, rust_lex_tests): Update.
12777 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12778 parameter.
12779 <lexptr, prev_lexptr>: New members.
12780 (lexptr, prev_lexptr): Don't declare.
12781 * parse.c (lexptr, prev_lexptr): Remove globals.
12782 (parse_exp_in_context): Update.
12783 * p-exp.y (yylex, yyerror): Update.
12784 * m2-exp.y (parse_number, yylex, yyerror): Update.
12785 * go-exp.y (lex_one_token, yyerror): Update.
12786 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12787 * d-exp.y (lex_one_token, yyerror): Update.
12788 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12789 (lex_one_token, yyerror): Update.
12790 * ada-lex.l (YY_INPUT): Update.
12791 (rewind_to_char): Update.
12792 * ada-exp.y (yyerror): Update.
12793
8621b685
TT
127942019-04-04 Tom Tromey <tom@tromey.com>
12795
12796 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12797 * parser-defs.h (struct parser_state) <parser_state>: Add new
12798 parameter.
12799 <comma_terminates>: New member.
12800 (comma_terminates): Don't declare global.
12801 * parse.c (comma_terminates): Remove global.
12802 (parse_exp_in_context): Update.
12803 * p-exp.y (yylex): Update.
12804 * m2-exp.y (yylex): Update.
12805 * go-exp.y (lex_one_token): Update.
12806 * f-exp.y (yylex): Update.
12807 * d-exp.y (lex_one_token): Update.
12808 * c-exp.y (lex_one_token): Update.
12809 * ada-lex.l: Update.
12810
28aaf3fd
TT
128112019-04-04 Tom Tromey <tom@tromey.com>
12812
12813 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12814 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12815 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12816 * parser-defs.h (paren_depth): Don't declare.
12817 * parse.c (paren_depth): Remove global.
12818 (parse_exp_in_context): Update.
12819 * p-exp.y (paren_depth): New global.
12820 (pascal_parse): Initialize it.
12821 * m2-exp.y (paren_depth): New global.
12822 (m2_parse): Initialize it.
12823 * go-exp.y (paren_depth): New global.
12824 (go_parse): Initialize it.
12825 * f-exp.y (paren_depth): New global.
12826 (f_parse): Initialize it.
12827 * d-exp.y (paren_depth): New global.
12828 (d_parse): Initialize it.
12829 * c-exp.y (paren_depth): New global.
12830 (c_parse): Initialize it.
12831 * ada-lex.l (paren_depth): New global.
12832 (lexer_init): Initialize it.
12833
1e58a4a4
TT
128342019-04-04 Tom Tromey <tom@tromey.com>
12835
12836 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12837 (rust_parser::convert_ast_to_type)
12838 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12839 * parser-defs.h (struct parser_state) <parser_state>: Add
12840 parameters. Initialize new members.
12841 <expression_context_block, expression_context_pc>: New members.
12842 * parse.c (expression_context_block, expression_context_pc):
12843 Remove globals.
12844 (parse_exp_in_context): Update.
12845 * p-exp.y: Update all rules.
12846 (yylex): Update.
12847 * m2-exp.y: Update all rules.
12848 (yylex): Update.
12849 * go-exp.y (yylex): Update.
12850 * f-exp.y (yylex): Update.
12851 * d-exp.y: Update all rules.
12852 (yylex): Update.
12853 * c-exp.y: Update all rules.
12854 (lex_one_token, classify_name, yylex, c_parse): Update.
12855 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12856
37eedb39
TT
128572019-04-04 Tom Tromey <tom@tromey.com>
12858
12859 * gdbarch.h, gdbarch.c: Rebuild.
12860 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12861 * stap-probe.h:
12862 (struct stap_parse_info): Replace "parser_state" with
12863 "expr_builder".
12864 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12865 (parser_state): New class.
12866 * parse.c (expr_builder): Rename.
12867 (expr_builder::release): Rename.
12868 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12869 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12870 (write_exp_elt_longcst, write_exp_elt_floatcst)
12871 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12872 (write_exp_string_vector, write_exp_bitstring)
12873 (write_exp_msymbol, mark_struct_expression)
12874 (write_dollar_variable)
12875 (insert_type_address_space, increase_expout_size): Replace
12876 "parser_state" with "expr_builder".
12877 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12878 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12879 "parser_state" with "expr_builder".
12880
73923d7e
TT
128812019-04-04 Tom Tromey <tom@tromey.com>
12882
12883 * rust-exp.y: Replace "parse_language" with method call.
12884 * p-exp.y:
12885 (yylex): Replace "parse_language" with method call.
12886 * m2-exp.y:
12887 (yylex): Replace "parse_language" with method call.
12888 * go-exp.y (classify_name): Replace "parse_language" with method
12889 call.
12890 * f-exp.y (yylex): Replace "parse_language" with method call.
12891 * d-exp.y (lex_one_token): Replace "parse_language" with method
12892 call.
12893 * c-exp.y:
12894 (lex_one_token, classify_name, yylex): Replace "parse_language"
12895 with method call.
12896 * ada-exp.y (find_primitive_type, type_char)
12897 (type_system_address): Replace "parse_language" with method call.
12898
fa9f5be6
TT
128992019-04-04 Tom Tromey <tom@tromey.com>
12900
12901 * rust-exp.y: Replace "parse_gdbarch" with method call.
12902 * parse.c (write_dollar_variable, insert_type_address_space):
12903 Replace "parse_gdbarch" with method call.
12904 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12905 call.
12906 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12907 call.
12908 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12909 "parse_gdbarch" with method call.
12910 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12911 with method call.
12912 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12913 "parse_gdbarch" with method call.
12914 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12915 "parse_gdbarch" with method call.
12916 * c-exp.y (parse_type, parse_number, classify_name): Replace
12917 "parse_gdbarch" with method call.
12918 * ada-lex.l: Replace "parse_gdbarch" with method call.
12919 * ada-exp.y (parse_type, find_primitive_type, type_char)
12920 (type_system_address): Replace "parse_gdbarch" with method call.
12921
1201a264
TT
129222019-04-04 Tom Tromey <tom@tromey.com>
12923
12924 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12925 * stap-probe.c (stap_parse_argument): Update.
12926 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12927 initial_size parameter.
12928 * rust-exp.y (rust_lex_tests): Update.
12929 * parse.c (parser_state): Update.
12930 (parse_exp_in_context): Update.
12931 * parser-defs.h (struct parser_state) <parser_state>: Remove
12932 "initial_size" parameter.
12933
e3980ce2
TT
129342019-04-04 Tom Tromey <tom@tromey.com>
12935
12936 * parser-defs.h (increase_expout_size): Don't declare.
12937 * parse.c (increase_expout_size): Now static.
12938
e9f8e3f1
TS
129392019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12940
12941 * gnu-nat.c (gnu_nat_target::wait): Fix
12942 target_waitstatus_to_string call.
12943
d7df6549
AB
129442019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12945
12946 * eval.c (evaluate_subexp_standard): Handle internal functions
12947 during Fortran function call handling.
12948
8bdc1658
AB
129492019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12950
12951 * NEWS: Mention new internal functions.
12952 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12953 (read_base_type): Use dwarf2_init_complex_target_type.
12954 * value.c (creal_internal_fn): New function.
12955 (cimag_internal_fn): New function.
12956 (_initialize_values): Register new internal functions.
12957
c29705b7
PW
129582019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12959
12960 * infrun.c (stop_all_threads): If debug_infrun, always
12961 trace the wait status after wait_one, using
12962 target_waitstatus_to_string and target_pid_to_str.
12963 (handle_inferior_event): Replace various trace of
12964 wait status kind by a single trace.
12965 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12966 wait status kind image by target_waitstatus_to_string.
12967 * target/waitstatus.c (target_waitstatus_to_string): Fix
12968 obsolete comment.
12969
05caa1d2
TT
129702019-04-01 Tom Tromey <tromey@adacore.com>
12971
12972 PR symtab/23331:
12973 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12974
9d1447e0
SDJ
129752019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12976 Pedro Alves <palves@redhat.com>
12977
12978 * top.c (quit_force): Call 'finalize_values'.
12979 * value.c (finalize_values): New function.
12980 * value.h (finalize_values): Declare.
12981
7734102d
EZ
129822019-03-30 Eli Zaretskii <eliz@gnu.org>
12983
12984 * NEWS: Announce $_gdb_major and $_gdb_minor.
12985
12986 * top.c (init_gdb_version_vars): New function.
12987 (gdb_init): Call init_gdb_version_vars.
12988
188e1fa9
TT
129892019-03-29 Tom Tromey <tromey@adacore.com>
12990
12991 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12992 help text. Remove dead code.
12993
2880242d
KS
129942019-03-29 Keith Seitz <keiths@redhat.com>
12995
12996 From Siddhesh Poyarekar:
12997 * f-lang.h (f77_get_upperbound): Return LONGEST.
12998 (f77_get_lowerbound): Likewise.
12999 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13000 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13001 print them.
13002 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13003 plongest to format print it.
13004 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13005 (f77_get_upperbound): Likewise.
13006 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13007 LOWER_BOUND to LONGEST.
13008 (f77_create_arrayprint_offset_tbl): Likewise.
13009
cc1defb1
KS
130102019-03-29 Keith Seitz <keiths@redhat.com>
13011
13012 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13013 %s/pulongest for TYPE_LENGTH instead of %d in format
13014 strings.
13015 * ada-typerint.c (ada_print_type): Likewise.
13016 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13017 * compile/compile-c-support.c (generate_register_struct): Likewise.
13018 * gdbtypes.c (recursive_dump_type): Likewise.
13019 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13020 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13021 instead of %d in format strings.
13022 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13023 to std::min to ULONGEST.
13024 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13025 instead of %d in format strings.
13026 * tracepoint.c (info_scope_command): Likewise.
13027 * typeprint.c (print_offset_data::update)
13028 (print_offset_data::finish): Likewise.
13029 * xtensa-tdep.c (xtensa_store_return_value)
13030 (xtensa_push_dummy_call): Likewise.
13031
e432ccf1
JT
130322019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13033
13034 * windows-nat.c (display_selector): Fixed format specifications
13035 for 64-bit Cygwin.
13036
65d2b333
PW
130372019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13038
13039 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13040
f489207e
SL
130412019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13042
13043 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13044 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13045 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13046 (nios2_linux_init_abi): Install it.
13047
bffa1015
AH
130482019-03-28 Alan Hayward <alan.hayward@arm.com>
13049
13050 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13051
fc96163a
AH
130522019-03-28 Alan Hayward <alan.hayward@arm.com>
13053
13054 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13055
20dc7e9b
PW
130562019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13057 Tom Tromey <tromey@adacore.com>
13058
13059 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13060
7f5331a8
JB
130612019-03-26 Joel Brobecker <brobecker@adacore.com>
13062
13063 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13064 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13065 method to compute the bounds of range types. Also print "[evaluated]"
13066 if the bounds' values come from a dynamic evaluation.
13067
18c77628
AB
130682019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13069
13070 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13071 whitespace when pretty printing is on.
13072
53c973f2
AH
130732019-03-26 Alan Hayward <alan.hayward@arm.com>
13074
e79be6e5 13075 * ppc-linux-nat.c: Add include.
53c973f2 13076
d851aa71
AH
130772019-03-26 Alan Hayward <alan.hayward@arm.com>
13078
e79be6e5 13079 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13080
2fe7bab7
AH
130812019-03-26 Alan Hayward <alan.hayward@arm.com>
13082
e79be6e5 13083 * arm-linux-nat.c: Add include.
2fe7bab7 13084
068ef30e
SM
130852019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13086
13087 * source-cache.c (source_cache::get_source_lines): Re-read
13088 fullname after calling open_source_file.
13089
81a24d04
JB
130902019-03-25 John Baldwin <jhb@FreeBSD.org>
13091
13092 * NEWS: Mention TLS support for FreeBSD.
13093
79e7ae11
TT
130942019-03-25 Tom Tromey <tromey@adacore.com>
13095
13096 * minsyms.c (BUNCH_SIZE): Update comment.
13097 (~minimal_symbol_reader): Remove old comment.
13098 (compact_minimal_symbols): Update comment.
13099 (minimal_symbol_reader::install): Remove old comment. Update
13100 other comments.
13101
d45963c2
AH
131022019-03-25 Alan Hayward <alan.hayward@arm.com>
13103
13104 * s390-linux-nat.c: Add include.
13105
0f83012e
AH
131062019-03-25 Alan Hayward <alan.hayward@arm.com>
13107
13108 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13109 Call linux_get_hwcap.
13110 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13111 Likewise.
13112 (aarch64_linux_get_hwcap): Remove function.
13113 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13114 declaration.
13115 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13116 linux_get_hwcap.
13117 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13118 * linux-tdep.c (linux_get_hwcap): Add function.
13119 (linux_get_hwcap2): Likewise.
13120 * linux-tdep.h (linux_get_hwcap): Add declaration.
13121 (linux_get_hwcap2): Likewise.
13122 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13123 (ppc_linux_get_hwcap2): Likewise.
13124 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13125 linux_get_hwcap.
13126 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13127 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13128 (ppc_linux_nat_target::read_description): Likewise.
13129 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13130 * s390-linux-nat.c: Likewise.
13131 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13132
6640a367
TT
131332019-03-24 Tom Tromey <tom@tromey.com>
13134
13135 * ada-lang.c (standard_lookup): Simplify initialization.
13136 (ada_lookup_symbol_nonlocal): Simplify return.
13137 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13138 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13139 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13140 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13141 initialization.
13142 * solib.c (solib_global_lookup): Simplify.
13143 * symtab.c (null_block_symbol): Remove.
13144 (symbol_cache_lookup): Simplify returns.
13145 (lookup_language_this): Simplify returns.
13146 (lookup_symbol_aux): Simplify return.
13147 (lookup_local_symbol): Simplify returns.
13148 (lookup_global_symbol_from_objfile): Simplify return.
13149 (lookup_symbol_in_objfile_symtabs)
13150 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13151 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13152 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13153 * cp-namespace.c (cp_lookup_bare_symbol)
13154 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13155 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13156 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13157 (cp_lookup_symbol_via_imports): Simplify initialization.
13158 (find_symbol_in_baseclass): Likewise.
13159 * symtab.h (null_block_symbol): Remove.
13160 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13161 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13162 (d_lookup_symbol_module): Likewise.
13163 (find_symbol_in_baseclass): Simplify initialization.
13164
a930ebcd
TT
131652019-03-24 Tom Tromey <tom@tromey.com>
13166
13167 * expression.h: Don't include symtab.h.
13168 (struct block): Forward declare.
13169
582942f4
TT
131702019-03-24 Tom Tromey <tom@tromey.com>
13171
13172 * c-exp.y (typebase): Remove casts.
13173 * gdbtypes.c (lookup_unsigned_typename, )
13174 (lookup_signed_typename): Remove cast.
13175 * eval.c (parse_to_comma_and_eval): Remove cast.
13176 * parse.c (write_dollar_variable): Remove cast.
13177 * block.h (struct block) <superblock>: Now const.
13178 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13179 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13180 (map_block): Make "block" const.
13181 * symfile.h (struct quick_symbol_functions)
13182 <map_matching_symbols>: Constify block argument to "callback".
13183 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13184 const.
13185 (find_pc_sect_compunit_symtab): Make "b" const.
13186 (find_symbol_at_address): Likewise.
13187 (search_symbols): Likewise.
13188 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13189 (dw2_debug_names_lookup_symbol): Likewise.
13190 (dw2_map_matching_symbols): Update.
13191 * p-valprint.c (pascal_val_print): Remove "block".
13192 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13193 (aux_add_nonlocal_symbols): Make "block" const.
13194 (resolve_subexp): Remove cast.
13195 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13196 const.
13197 (iterate_over_file_blocks): Likewise.
13198 * f-exp.y (%union) <bval>: Remove.
13199 * coffread.c (patch_opaque_types): Make "b" const.
13200 * spu-tdep.c (spu_catch_start): Make "block" const.
13201 * c-valprint.c (print_unpacked_pointer): Remove "block".
13202 * symmisc.c (dump_symtab_1): Make "b" const.
13203 (block_depth): Make "block" const.
13204 * d-exp.y (%union) <bval>: Remove.
13205 * cp-support.h (cp_lookup_rtti_type): Update.
13206 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13207 * psymtab.c (psym_lookup_symbol): Make "block" const.
13208 (maintenance_check_psymtabs): Make "b" const.
13209 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13210 (enumerate_locals, enumerate_args): Update.
13211 * python/py-symtab.c (stpy_global_block): Make "block" const.
13212 (stpy_static_block): Likewise.
13213 * inline-frame.c (block_starting_point_at): Make "new_block"
13214 const.
13215 * block.c (find_block_in_blockvector): Make return type const.
13216 (blockvector_for_pc_sect): Make "b" const.
13217 (find_block_in_blockvector): Make "b" const.
13218
7ad417dd
TT
132192019-03-23 Tom Tromey <tom@tromey.com>
13220
13221 * varobj.c (varobj_create): Update.
13222 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13223 * printcmd.c (display_command, do_one_display): Don't reset
13224 innermost_block.
13225 * parser-defs.h (enum innermost_block_tracker_type): Move to
13226 expression.h.
13227 (innermost_block): Update comment.
13228 * parse.c (parse_exp_1): Add tracker_types parameter.
13229 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13230 tracker_types parameter. Reset innermost_block.
13231 (parse_exp_in_context): Remove.
13232 (parse_expression_for_completion): Update.
13233 * objfiles.c (~objfile): Don't reset expression_context_block or
13234 innermost_block.
13235 * expression.h (enum innermost_block_tracker_type): Move from
13236 parser-defs.h.
13237 (parse_exp_1): Add tracker_types parameter.
13238 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13239 reset innermost_block.
13240
b366c208
TT
132412019-03-23 Tom Tromey <tom@tromey.com>
13242
13243 * objfiles.h: Include bcache.h.
13244
9bb9b2f9
TT
132452019-03-23 Tom Tromey <tom@tromey.com>
13246
13247 * linespec.c (get_current_search_block): Use
13248 scoped_restore_current_language.
13249 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13250
59c28372
AH
132512019-03-22 Alan Hayward <alan.hayward@arm.com>
13252 Jiong Wang <jiong.wang@arm.com>
13253
13254 * aarch64-linux-tdep.c
13255 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13256 section.
13257 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13258
17e116a7
AH
132592019-03-22 Alan Hayward <alan.hayward@arm.com>
13260 Jiong Wang <jiong.wang@arm.com>
13261
13262 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13263 instructions.
13264 (aarch64_analyze_prologue_test): Add PACIASP test.
13265 (aarch64_prologue_prev_register): Unmask PC value.
13266
11e1b75f
AH
132672019-03-22 Alan Hayward <alan.hayward@arm.com>
13268 Jiong Wang <jiong.wang@arm.com>
13269
13270 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13271 (aarch64_dwarf2_prev_register): Unmask PC value.
13272 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13273 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13274 DW_CFA_AARCH64_negate_ra_state.
13275 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13276
34dcc7cf
AH
132772019-03-22 Alan Hayward <alan.hayward@arm.com>
13278 Jiong Wang <jiong.wang@arm.com>
13279
13280 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13281 registers.
13282 (aarch64_pseudo_register_name): Likewise.
13283 (aarch64_pseudo_register_type): Likewise.
13284 (aarch64_pseudo_register_reggroup_p): Likewise.
13285 (aarch64_gdbarch_init): Add pauth registers.
13286 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13287 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13288 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13289 (struct gdbarch_tdep): Add regnum for ra_state.
13290
1ef53e6b
AH
132912019-03-22 Alan Hayward <alan.hayward@arm.com>
13292 Jiong Wang <jiong.wang@arm.com>
13293
13294 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13295
76bed0fd
AH
132962019-03-22 Alan Hayward <alan.hayward@arm.com>
13297 Jiong Wang <jiong.wang@arm.com>
13298
13299 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13300 function.
13301 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13302 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13303 (aarch64_gdbarch_init): Add puth registers.
13304 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13305 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13306 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13307
ee4fbcfa
AH
133082019-03-22 Alan Hayward <alan.hayward@arm.com>
13309 Jiong Wang <jiong.wang@arm.com>
13310
13311 * aarch64-linux-nat.c
13312 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13313 * aarch64-linux-tdep.c
13314 (aarch64_linux_core_read_description): Likewise.
13315 (aarch64_linux_get_hwcap): New function.
13316 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13317 (aarch64_linux_get_hwcap): New declaration.
13318
6dc0ebde
AH
133192019-03-22 Alan Hayward <alan.hayward@arm.com>
13320 Jiong Wang <jiong.wang@arm.com>
13321
13322 * aarch64-linux-nat.c
13323 (aarch64_linux_nat_target::read_description): Add pauth param.
13324 * aarch64-linux-tdep.c
13325 (aarch64_linux_core_read_description): Likewise.
13326 * aarch64-tdep.c (struct target_desc): Add in pauth.
13327 (aarch64_read_description): Add pauth param.
13328 (aarch64_gdbarch_init): Likewise.
13329 * aarch64-tdep.h (aarch64_read_description): Likewise.
13330 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13331 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13332 * features/Makefile: Add new files.
13333 * features/aarch64-pauth.c: New file.
13334 * features/aarch64-pauth.xml: New file.
13335
595915c1
TT
133362019-03-20 Tom Tromey <tromey@adacore.com>
13337
13338 * infrun.c (handle_inferior_event): Rename from
13339 handle_inferior_event_1. Create a scoped_value_mark.
13340 (handle_inferior_event): Remove.
13341
4c7d57e7
TT
133422019-03-19 Tom Tromey <tromey@adacore.com>
13343
13344 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13345 * infrun.h (print_stop_event): Add "displays" parameter.
13346 * infrun.c (print_stop_event): Add "displays" parameter.
13347
cb246234
PA
133482019-03-19 Pedro Alves <palves@redhat.com>
13349
13350 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13351 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13352 to -1. Fix TABs vs spaces.
13353 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13354 * tui/tui-out.h (tui_ui_out) Add intro comments.
13355 <m_line, m_start_of_line>: In-class initialize, and add describing
13356 comment.
13357
3a0e45b2
AH
133582019-03-18 Alan Hayward <alan.hayward@arm.com>
13359
13360 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13361 variable names.
13362 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13363
5371b850
PA
133642019-03-18 Pedro Alves <palves@redhat.com>
13365 Eli Zaretskii <eliz@gnu.org>
13366
13367 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13368 m_line and m_start_of_line.
13369
b17c4cd0
EZ
133702019-03-18 Eli Zaretskii <eliz@gnu.org>
13371
13372 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13373 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13374 it returns a newline. This fixes a regression in TU mode, whereby
13375 the next line is output on the same screen line as the user input.
13376
4bd56d18
TT
133772019-03-18 Tom Tromey <tromey@adacore.com>
13378
13379 * minsyms.c (minimal_symbol_reader::install): Remove call to
13380 obstack_blank.
13381
55c10aca
PA
133822019-03-18 Pedro Alves <palves@redhat.com>
13383
13384 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13385 New globals.
13386 (apply_style): New, factored out from ...
13387 (apply_ansi_escape): ... this. Handle reverse video mode.
13388 (tui_set_reverse_mode): New function.
13389 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13390 * tui/tui-winsource.c (tui_show_source_line): Use
13391 tui_set_reverse_mode instead of setting A_STANDOUT.
13392 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13393 New setter methods.
13394
647bb750
HD
133952019-03-18 Hannes Domani <ssbssa@yahoo.de>
13396
13397 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13398 Handle tabs.
13399
bff8c71f
TT
134002019-03-18 Tom Tromey <tromey@adacore.com>
13401
13402 * ada-lang.c (empty_array): Add "high" parameter.
13403 (ada_evaluate_subexp): Update.
13404
58785d98
ST
134052019-03-17 Sergei Trofimovich <siarheit@google.com>
13406
13407 * unittests/string_view-selftests.c: Define
13408 _initialize_string_view_selftests unconditionally.
13409
d4cbef22
ВМ
134102019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13411
13412 PR gdb/24350
13413 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13414
fce4c071
ВМ
134152019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13416
13417 PR gdb/24351
13418 * windows-nat.c (display_selector): Fix format specifiers.
13419
f7f0a123
EZ
134202019-03-17 Eli Zaretskii <eliz@gnu.org>
13421
13422 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13423 tui_refill_source_window instead of tui_refresh_win, to update the
13424 current execution line. This fixes redisplay of the current line
13425 when stepping through the code with "next" or "step".
13426
ab42892f
EZ
134272019-03-16 Eli Zaretskii <eliz@gnu.org>
13428
13429 * source-cache.c (source_cache::get_source_lines): Call
13430 find_source_lines to initialize s->nlines. This fixes vertical
13431 scrolling of TUI source window when the DOWN arrow is pressed.
13432
8d8c087f
PW
134332019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13434
13435 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13436 linux-thread-db.c (_initialize_thread_db): Likewise.
13437
798e1c30
EZ
134382019-03-16 Eli Zaretskii <eliz@gnu.org>
13439
13440 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13441 wclrtoeol in tui_show_source_line". This reverts changes made in
13442 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13443
eefba3da
TT
134442019-03-15 Tom Tromey <tom@tromey.com>
13445
13446 * symtab.h (struct minimal_symbol): Derive from
13447 general_symbol_info.
13448 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13449 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13450 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13451 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13452 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13453 (MSYMBOL_SEARCH_NAME): Update.
13454 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13455 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13456 * minsyms.c (minimal_symbol_reader::record_full): Update.
13457
0de2420c
TT
134582019-03-15 Tom Tromey <tom@tromey.com>
13459
13460 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13461
042d75e4
TT
134622019-03-15 Tom Tromey <tom@tromey.com>
13463
13464 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13465 unique_xmalloc_ptr.
13466 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13467 Update.
13468 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13469 (build_minimal_symbol_hash_tables)
13470 (minimal_symbol_reader::install): Update.
13471
db92718b
TT
134722019-03-15 Tom Tromey <tom@tromey.com>
13473
13474 * symtab.c (create_demangled_names_hash): Update.
13475 (symbol_set_names): Update.
13476 * objfiles.h (struct objfile_per_bfd_storage)
13477 <demangled_names_hash>: Now an htab_up.
13478 * objfiles.c (objfile_per_bfd_storage): Simplify.
13479
d6797f46
TT
134802019-03-15 Tom Tromey <tom@tromey.com>
13481
13482 * objfiles.h (struct objfile_per_bfd_storage): Declare
13483 destructor.
13484 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13485 New.
13486 (get_objfile_bfd_data): Use new. Don't initialize
13487 language_of_main.
13488 (free_objfile_per_bfd_storage): Remove.
13489 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13490
741d7538
TT
134912019-03-15 Tom Tromey <tom@tromey.com>
13492
13493 * symfile.c (reread_symbols): Update.
13494 * objfiles.c (objfile::objfile): Update.
13495 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13496 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13497 comment.
13498 (minimal_symbol_reader::install): Update.
13499 (terminate_minimal_symbol_table): Remove.
13500 * jit.c (jit_object_close_impl): Update.
13501
788c80d1
TT
135022019-03-15 Tom Tromey <tom@tromey.com>
13503
13504 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13505 initializations.
13506
1b7a07cb
TT
135072019-03-15 Tom Tromey <tom@tromey.com>
13508
13509 * objfiles.h (struct objfile_per_bfd_storage)
13510 <demangled_hash_languages>: Now a bitset.
13511 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13512 (lookup_minimal_symbol): Update.
13513
3db066bc
TT
135142019-03-15 Tom Tromey <tom@tromey.com>
13515
13516 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13517 Don't return the symbol.
13518 * coffread.c (record_minimal_symbol): Use record_full.
13519
3fff2c37
EZ
135202019-03-14 Eli Zaretskii <eliz@gnu.org>
13521
13522 The MS-Windows port of ncurses fails to switch to a color pair if
13523 one or both of the colors are the implicit default colors. This
13524 change records the default colors when TUI is initialized, and
13525 then specifies them explicitly when a color pair uses the default
13526 colors. This allows color styling in TUI mode on MS-Windows.
13527
13528 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13529 ncurses_norm_attr.
13530 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13531 colors in ncurses_norm_attr.
13532 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13533 "none", replace it with the default color recorded in
13534 ncurses_norm_attr.
13535
3b336828
TT
135362019-03-14 Tom Tromey <tromey@adacore.com>
13537
13538 * source-cache.h (class source_cache) <get_source_lines>: Return
13539 std::string.
13540 * source-cache.c (source_cache::extract_lines): Handle case where
13541 first_pos==npos. Return std::string.
13542 (source_cache::get_source_lines): Update.
13543
d085f989
TT
135442019-03-14 Tom Tromey <tromey@adacore.com>
13545
13546 * NEWS: Add item for "style sources" commands.
13547 * source-cache.c (source_cache::get_source_lines): Check
13548 source_styling.
13549 * cli/cli-style.c (source_styling): New global.
13550 (_initialize_cli_style): Add "style sources" commands.
13551 (show_style_sources): New function.
13552 * cli/cli-style.h (source_styling): Declare.
13553
6f11e682
TT
135542019-03-14 Pedro Alves <palves@redhat.com>
13555 Tom Tromey <tromey@adacore.com>
13556
13557 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13558 * tui/tui-winsource.c (tui_refill_source_window): New function,
13559 from...
13560 (tui_horizontal_source_scroll): ... here. Move some logic.
13561 * cli/cli-style.c (set_style_enabled): Notify new observable.
13562 * tui/tui-hooks.c (tui_redisplay_source): New function.
13563 (tui_attach_detach_observers): Attach or detach
13564 tui_redisplay_source.
13565 * observable.h (source_styling_changed): New observable.
13566 * observable.c: Define source_styling_changed observable.
13567
a068643d
TT
135682019-03-13 Tom Tromey <tromey@adacore.com>
13569
13570 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13571 (i386_gnu_nat_target::store_registers): Update.
13572 * target-debug.h (target_debug_print_std_string): New macro.
13573 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13574 * windows-tdep.c (display_one_tib): Update.
13575 * tui/tui-stack.c (tui_make_status_line): Update.
13576 * top.c (print_inferior_quit_action): Update.
13577 * thread.c (thr_try_catch_cmd): Update.
13578 (add_thread_with_info): Update.
13579 (thread_target_id_str): Update.
13580 (thr_try_catch_cmd): Update.
13581 (thread_command): Update.
13582 (thread_find_command): Update.
13583 * record-btrace.c (record_btrace_target::info_record)
13584 (record_btrace_resume_thread, record_btrace_target::resume)
13585 (record_btrace_cancel_resume, record_btrace_step_thread)
13586 (record_btrace_target::wait, record_btrace_target::wait)
13587 (record_btrace_target::wait, record_btrace_target::stop): Update.
13588 * progspace.c (print_program_space): Update.
13589 * process-stratum-target.c
13590 (process_stratum_target::thread_address_space): Update.
13591 * linux-fork.c (linux_fork_mourn_inferior)
13592 (detach_checkpoint_command, info_checkpoints_command)
13593 (linux_fork_context): Update.
13594 (linux_fork_detach): Update.
13595 (class scoped_switch_fork_info): Update.
13596 (delete_checkpoint_command): Update.
13597 * infrun.c (follow_fork_inferior): Update.
13598 (follow_fork_inferior): Update.
13599 (proceed_after_vfork_done): Update.
13600 (handle_vfork_child_exec_or_exit): Update.
13601 (follow_exec): Update.
13602 (displaced_step_prepare_throw): Update.
13603 (displaced_step_restore): Update.
13604 (start_step_over): Update.
13605 (resume_1): Update.
13606 (clear_proceed_status_thread): Update.
13607 (proceed): Update.
13608 (print_target_wait_results): Update.
13609 (do_target_wait): Update.
13610 (context_switch): Update.
13611 (stop_all_threads): Update.
13612 (restart_threads): Update.
13613 (finish_step_over): Update.
13614 (handle_signal_stop): Update.
13615 (switch_back_to_stepped_thread): Update.
13616 (keep_going_pass_signal): Update.
13617 (print_exited_reason): Update.
13618 (normal_stop): Update.
13619 * inferior.c (inferior_pid_to_str): Change return type.
13620 (print_selected_inferior): Update.
13621 (add_inferior): Update.
13622 (detach_inferior): Update.
13623 * dummy-frame.c (fprint_dummy_frames): Update.
13624 * dcache.c (dcache_info_1): Update.
13625 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13626 (btrace_fetch, btrace_clear): Update.
13627 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13628 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13629 type.
13630 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13631 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13632 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13633 * gdbarch.c, gdbarch.h: Rebuild.
13634 * gdbarch.sh (core_pid_to_str): Change return type.
13635 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13636 return type.
13637 (windows_nat_target::pid_to_str): Change return type.
13638 (windows_delete_thread): Update.
13639 (windows_nat_target::attach): Update.
13640 (windows_nat_target::files_info): Update.
13641 * target-delegates.c: Rebuild.
13642 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13643 return type.
13644 (sol_thread_target::pid_to_str): Change return type.
13645 * remote.c (class remote_target) <pid_to_str>: Change return
13646 type.
13647 (remote_target::pid_to_str): Change return type.
13648 (extended_remote_target::attach, remote_target::remote_stop_ns)
13649 (remote_target::remote_notif_remove_queued_reply)
13650 (remote_target::push_stop_reply, remote_target::disable_btrace):
13651 Update.
13652 (extended_remote_target::attach): Update.
13653 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13654 type.
13655 (gdbsim_target::pid_to_str): Change return type.
13656 * ravenscar-thread.c (struct ravenscar_thread_target)
13657 <pid_to_str>: Change return type.
13658 (ravenscar_thread_target::pid_to_str): Change return type.
13659 * procfs.c (class procfs_target) <pid_to_str>: Change return
13660 type.
13661 (procfs_target::pid_to_str): Change return type.
13662 (procfs_target::attach): Update.
13663 (procfs_target::detach): Update.
13664 (procfs_target::fetch_registers): Update.
13665 (procfs_target::store_registers): Update.
13666 (procfs_target::wait): Update.
13667 (procfs_target::files_info): Update.
13668 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13669 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13670 return type.
13671 (nto_procfs_target::pid_to_str): Change return type.
13672 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13673 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13674 return type.
13675 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13676 (exit_lwp): Update.
13677 (attach_proc_task_lwp_callback, get_detach_signal)
13678 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13679 (linux_nat_target::resume, wait_lwp, stop_callback)
13680 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13681 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13682 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13683 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13684 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13685 type.
13686 (inf_ptrace_target::attach): Update.
13687 (inf_ptrace_target::files_info): Update.
13688 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13689 type.
13690 (go32_nat_target::pid_to_str): Change return type.
13691 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13692 (gnu_nat_target::wait): Update.
13693 (gnu_nat_target::wait): Update.
13694 (gnu_nat_target::resume): Update.
13695 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13696 (fbsd_nat_target::wait): Update.
13697 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13698 type.
13699 (darwin_nat_target::attach): Update.
13700 * corelow.c (class core_target) <pid_to_str>: Change return type.
13701 (core_target::pid_to_str): Change return type.
13702 * target.c (normal_pid_to_str): Change return type.
13703 (default_pid_to_str): Likewise.
13704 (target_pid_to_str): Change return type.
13705 (target_translate_tls_address): Update.
13706 (target_announce_detach): Update.
13707 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13708 return type.
13709 (bsd_uthread_target::pid_to_str): Change return type.
13710 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13711 type.
13712 (bsd_kvm_target::pid_to_str): Change return type.
13713 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13714 return type.
13715 (aix_thread_target::pid_to_str): Change return type.
13716 * target.h (struct target_ops) <pid_to_str>: Change return type.
13717 (target_pid_to_str, normal_pid_to_str): Likewise.
13718 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13719 type.
13720 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13721 type.
13722 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13723 return type.
13724 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13725 type.
13726 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13727 type.
13728 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13729 return type.
13730
b4be1b06
SM
137312019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13732
13733 * NEWS: Mention that the new default MI version is 3. Mention
13734 changes to the output of commands and events that deal with
13735 multi-location breakpoints.
13736 * breakpoint.c: Include "mi/mi-out.h".
13737 (print_one_breakpoint): Change output syntax if using MI version
13738 >= 3.
13739 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13740 New.
13741 (mi_multi_location_breakpoint_output_fixed): New.
13742 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13743 (mi_cmd_fix_multi_location_breakpoint_output): New.
13744 (mi_multi_location_breakpoint_output_fixed): New.
13745 * mi/mi-cmds.c (mi_cmds): Register command
13746 -fix-multi-location-breakpoint-output.
13747 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13748 interpreter "mi".
13749
8e5e5494
SM
137502019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13751
13752 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13753 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13754 instantiate mi_ui_out based on interpreter name.
13755 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13756 * mi/mi-main.c (mi_load_progress): Likewise.
13757
197df35e
JB
137582019-03-12 John Baldwin <jhb@FreeBSD.org>
13759
13760 * NEWS: Combine separate "New targets" sections for 8.3.
13761
8399425f
JB
137622019-03-12 John Baldwin <jhb@FreeBSD.org>
13763
13764 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13765 (ppcfbsd_init_abi): Install gdbarch
13766 "fetch_tls_load_module_address" and "get_thread_local_address"
13767 methods.
13768
b0f87ed0
JB
137692019-03-12 John Baldwin <jhb@FreeBSD.org>
13770
13771 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13772 (riscv_fbsd_init_abi): Install gdbarch
13773 "fetch_tls_load_module_address" and "get_thread_local_address"
13774 methods.
13775
ce25aa57
JB
137762019-03-12 John Baldwin <jhb@FreeBSD.org>
13777
13778 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13779 (i386fbsd_init_abi): Install gdbarch
13780 "fetch_tls_load_module_address" and "get_thread_local_address"
13781 methods.
13782
f5424cfa
JB
137832019-03-12 John Baldwin <jhb@FreeBSD.org>
13784
13785 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13786 (amd64fbsd_init_abi): Install gdbarch
13787 "fetch_tls_load_module_address" and "get_thread_local_address"
13788 methods.
13789
945f3901
JB
137902019-03-12 John Baldwin <jhb@FreeBSD.org>
13791
13792 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13793 (struct fbsd_pspace_data): New type.
13794 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13795 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13796 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13797 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13798 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13799
ef0bd204
JB
138002019-03-12 John Baldwin <jhb@FreeBSD.org>
13801
13802 * gdbtypes.c (lookup_struct_elt): New function.
13803 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13804 * gdbtypes.h (struct struct_elt): New type.
13805 (lookup_struct_elt): New prototype.
13806
36c53a02
JB
138072019-03-12 John Baldwin <jhb@FreeBSD.org>
13808
13809 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13810 remove disabled code block.
13811
6e056c81
JB
138122019-03-12 John Baldwin <jhb@FreeBSD.org>
13813
13814 * gdbarch.sh (get_thread_local_address): New method.
13815 * gdbarch.h, gdbarch.c: Regenerate.
13816 * target.c (target_translate_tls_address): Use
13817 gdbarch_get_thread_local_address if present instead of
13818 target::get_thread_local_address.
13819
cd250a18
JB
138202019-03-12 John Baldwin <jhb@FreeBSD.org>
13821
13822 * target.h (target::get_thread_local_address): Update comment.
13823
df22c1e5
JB
138242019-03-12 John Baldwin <jhb@FreeBSD.org>
13825
13826 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13827 objfile->separate_debug_objfile_backlink if not NULL.
13828
dd6876c9
JB
138292019-03-12 John Baldwin <jhb@FreeBSD.org>
13830
13831 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13832 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13833 (amd64bsd_store_inferior_registers): Likewise.
13834 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13835 Enable segment base registers.
13836 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13837 PT_GETFSBASE and PT_GETGSBASE.
13838 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13839 PT_SETGSBASE.
13840 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13841 segment base registers.
13842 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13843
1163a4b7
JB
138442019-03-12 John Baldwin <jhb@FreeBSD.org>
13845
13846 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13847 Update calls to i386_target_description to add 'segments'
13848 parameter.
13849 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13850 add segment base registers.
13851 * arch/i386.c (i386_create_target_description): Add 'segments'
13852 parameter to enable segment base registers.
13853 * arch/i386.h (i386_create_target_description): Likewise.
13854 * features/i386/32bit-segments.xml: New file.
13855 * features/i386/32bit-segments.c: Generate.
13856 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13857 call to i386_target_description to add 'segments' parameter.
13858 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13859 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13860 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13861 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13862 if feature is present.
13863 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13864 Add 'segments' parameter to call to i386_target_description.
13865 (i386_target_description): Add 'segments' parameter to enable
13866 segment base registers.
13867 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13868 to call to i386_target_description.
13869 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13870 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13871 Define I386_NUM_REGS.
13872 (i386_target_description): Add 'segments' parameter to enable
13873 segment base registers.
13874
3a350822
EZ
138752019-03-12 Eli Zaretskii <eliz@gnu.org>
13876
13877 PR/24325
13878 * source-cache.c: #undef open and close, to avoid unresolved
13879 externals during linking.
13880
ffdd69cf
TT
138812019-03-12 Tom Tromey <tromey@adacore.com>
13882
13883 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13884 const. Add initializers.
13885 (_initialize_remote): Don't initialize ptid globals.
13886
ec148c57
PA
138872019-03-12 Pedro Alves <palves@redhat.com>
13888
13889 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13890
32764270
PA
138912019-03-12 Pedro Alves <palves@redhat.com>
13892
13893 * cp-name-parser.y (main): Remove unused 'len' variable.
13894
17547186
TT
138952019-03-12 Tom Tromey <tromey@adacore.com>
13896
13897 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13898 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13899
d3a70e03
TT
139002019-03-12 Tom Tromey <tromey@adacore.com>
13901
13902 * linux-nat.c (iterate_over_lwps): Update.
13903 (stop_callback): Remove parameter.
13904 (stop_wait_callback, detach_callback, resume_set_callback)
13905 (select_singlestep_lwp_callback, set_ignore_sigint)
13906 (status_callback, resumed_callback, resume_clear_callback)
13907 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13908 data parameter.
13909 (linux_nat_target::detach, linux_nat_target::resume)
13910 (linux_stop_and_wait_all_lwps, select_event_lwp)
13911 (linux_nat_filter_event, linux_nat_wait_1)
13912 (linux_nat_target::kill, linux_nat_target::stop)
13913 (linux_nat_target::stop): Update.
13914 (linux_nat_resume_callback): Change type.
13915 (resume_stopped_resumed_lwps, count_events_callback)
13916 (select_event_lwp_callback): Likewise.
13917 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13918 * arm-linux-nat.c (struct update_registers_data): Remove.
13919 (update_registers_callback): Change type.
13920 (arm_linux_insert_hw_breakpoint1): Update.
13921 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13922 parameter.
13923 (x86_linux_dr_set_addr): Update.
13924 (x86_linux_dr_set_control): Update.
13925 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13926 (iterate_over_lwps): Use gdb::function_view.
13927 * nat/aarch64-linux-hw-point.c (struct
13928 aarch64_dr_update_callback_param): Remove.
13929 (debug_reg_change_callback): Change type.
13930 (aarch64_notify_debug_reg_change): Update.
13931 * s390-linux-nat.c (s390_refresh_per_info): Update.
13932
82cb27ff
TT
139332019-03-11 Tom Tromey <tromey@adacore.com>
13934
13935 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13936 redundant assignment to "this_cu".
13937
568c0683
SM
139382019-03-08 Simon Marchi <simon.marchi@efficios.com>
13939
13940 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13941
f09ce22d
SM
139422019-03-08 Simon Marchi <simon.marchi@efficios.com>
13943
13944 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13945 from...
13946 (rank_one_type): ... this.
13947
595f96a9
SM
139482019-03-08 Simon Marchi <simon.marchi@efficios.com>
13949
13950 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13951 from...
13952 (rank_one_type): ... this.
13953
2598a94b
SM
139542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13955
13956 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13957 from...
13958 (rank_one_type): ... this.
13959
7f17b20d
SM
139602019-03-08 Simon Marchi <simon.marchi@efficios.com>
13961
13962 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13963 from...
13964 (rank_one_type): ... this.
13965
2c509035
SM
139662019-03-08 Simon Marchi <simon.marchi@efficios.com>
13967
13968 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13969 from...
13970 (rank_one_type): ... this.
13971
0dd322dc
SM
139722019-03-08 Simon Marchi <simon.marchi@efficios.com>
13973
13974 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13975 from...
13976 (rank_one_type): ... this.
13977
41ea4728
SM
139782019-03-08 Simon Marchi <simon.marchi@efficios.com>
13979
13980 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13981 from...
13982 (rank_one_type): ... this.
13983
793cd1d2
SM
139842019-03-08 Simon Marchi <simon.marchi@efficios.com>
13985
13986 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13987 from...
13988 (rank_one_type): ... this.
13989
34910087
SM
139902019-03-08 Simon Marchi <simon.marchi@efficios.com>
13991
13992 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13993 from...
13994 (rank_one_type): ... this.
13995
f1f832d6
SM
139962019-03-08 Simon Marchi <simon.marchi@efficios.com>
13997
13998 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13999 from...
14000 (rank_one_type): ... this.
14001
b9f4512f
SM
140022019-03-08 Simon Marchi <simon.marchi@efficios.com>
14003
14004 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14005 from...
14006 (rank_one_type): ... this.
14007
9293fc63
SM
140082019-03-08 Simon Marchi <simon.marchi@efficios.com>
14009
14010 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14011 from...
14012 (rank_one_type): ... this.
14013
e3abbe7e
PW
140142019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14015
14016 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14017 inferior-events' shows the example events.
14018
e4adb939
EZ
140192019-03-08 Eli Zaretskii <eliz@gnu.org>
14020
14021 Support styling on native MS-Windows console
14022
14023 PR/24315
14024 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14025 on MS-Windows if $TERM is not defined.
14026
14027 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14028
14029 * posix-hdep.c (gdb_console_fputs):
14030 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14031 functions.
14032 * ui-file.h (gdb_console_fputs): Add prototype.
14033
14034 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14035 back to fputs only if the former returns zero.
14036
25629dfd
TT
140372019-03-07 Tom Tromey <tom@tromey.com>
14038
14039 * symmisc.c (print_symbol_bcache_statistics): Update.
14040 (print_objfile_statistics): Update.
14041 * symfile.c (allocate_symtab): Update.
14042 * stabsread.c: Don't include bcache.h.
14043 * psymtab.h (struct psymbol_bcache): Don't declare.
14044 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14045 (psymbol_bcache_init, psymbol_bcache_free)
14046 (psymbol_bcache_get_bcache): Don't declare.
14047 * psymtab.c (struct psymbol_bcache): Remove.
14048 (psymtab_storage::psymtab_storage): Update.
14049 (psymtab_storage::~psymtab_storage): Update.
14050 (psymbol_bcache_init, psymbol_bcache_free)
14051 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14052 (add_psymbol_to_bcache): Update.
14053 (allocate_psymtab): Update.
14054 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14055 macro_cache>: No longer pointers.
14056 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14057 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14058 * macrotab.c (macro_bcache): Update.
14059 * macroexp.c: Don't include bcache.h.
14060 * gdbtypes.c (check_types_worklist): Update.
14061 (types_deeply_equal): Remove TRY/CATCH. Update.
14062 * elfread.c (elf_symtab_read): Update.
14063 * dwarf2read.c: Don't include bcache.h.
14064 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14065 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14066 (print_bcache_statistics, bcache_memory_used): Don't declare.
14067 (struct bcache): Move from bcache.c. Add constructor, destructor,
14068 methods. Rename all data members.
14069 * bcache.c (struct bcache): Move to bcache.h.
14070 (bcache::expand_hash_table): Rename from expand_hash_table.
14071 (bcache): Remove.
14072 (bcache::insert): Rename from bcache_full.
14073 (bcache::compare): Rename from bcache_compare.
14074 (bcache_xmalloc): Remove.
14075 (bcache::~bcache): Rename from bcache_xfree.
14076 (bcache::print_statistics): Rename from print_bcache_statistics.
14077 (bcache::memory_used): Rename from bcache_memory_used.
14078
fe726667
PA
140792019-03-07 Pedro Alves <palves@redhat.com>
14080
14081 * infrun.c (normal_stop): Also check for
14082 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14083
7584bb30
AB
140842019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14085
14086 * f-lang.c (value_from_host_double): Moved to...
14087 * value.c (value_from_host_double): ...here.
14088 * value.h (value_from_host_double): Declare.
14089 * guile/scm-math.c (vlscm_convert_typed_number): Use
14090 value_from_host_double.
14091 (vlscm_convert_number): Likewise.
14092 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14093 * python/py-value.c (convert_value_from_python): Likewise.
14094
a7b1986e
TT
140952019-03-06 Tom Tromey <tom@tromey.com>
14096
14097 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14098
0ccf4211
TT
140992019-03-06 Tom Tromey <tom@tromey.com>
14100
14101 * utils.h (free_current_contents): Don't declare.
14102 * utils.c (free_current_contents): Remove.
14103
fe7b42e5
TT
141042019-03-06 Tom Tromey <tom@tromey.com>
14105
14106 * top.c (quit_force): Update.
14107 * main.c (captured_command_loop): Update.
14108 * common/new-op.c (operator new): Update.
14109 * common/common-exceptions.c (struct catcher)
14110 <save_cleanup_chain>: Remove member.
14111 (exceptions_state_mc_init): Update.
14112 (exception_try_scope_entry): Return nullptr.
14113 (exception_try_scope_exit, exception_rethrow)
14114 (throw_exception_sjlj, throw_exception_cxx): Update.
14115 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14116 (all_cleanups, do_cleanups, discard_cleanups)
14117 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14118 (restore_cleanups, restore_final_cleanups): Don't declare.
14119 (do_final_cleanups): Remove parameter.
14120 * common/cleanups.c (cleanup_chain, make_cleanup)
14121 (make_cleanup_dtor, all_cleanups, do_cleanups)
14122 (discard_my_cleanups, discard_cleanups)
14123 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14124 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14125 (null_cleanup): Remove.
14126 (do_final_cleanups): Remove parameter.
14127
c6321f19
TT
141282019-03-06 Tom Tromey <tom@tromey.com>
14129
14130 * remote.c (remote_target::remote_parse_stop_reply): Use
14131 unique_xmalloc_ptr.
14132
61b30099
TT
141332019-03-06 Tom Tromey <tom@tromey.com>
14134
14135 * stabsread.c (struct stabs_field_info): Rename from field_info.
14136 <list, fnlist>: Add initializers.
14137 <obstack>: New member.
14138 (read_member_functions, read_struct_fields, read_baseclasses):
14139 Allocate on obstack. Don't use cleanups.
14140 (read_one_struct_field, read_member_functions, read_struct_fields)
14141 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14142 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14143 (read_struct_type): Update.
14144
6cceac94
TT
141452019-03-06 Tom Tromey <tom@tromey.com>
14146
14147 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14148 * common/filestuff.h (make_cleanup_close): Don't declare.
14149 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14150 Remove.
14151
72412762
TT
141522019-03-06 Tom Tromey <tom@tromey.com>
14153
14154 * solib-aix.c: Use make_scope_exit.
14155
2b6ff1c0
TT
141562019-03-06 Tom Tromey <tom@tromey.com>
14157
14158 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14159 Use make_scope_exit.
14160
d01c5877
TT
141612019-03-06 Tom Tromey <tom@tromey.com>
14162
14163 * solib-svr4.c (disable_probes_interface): Remove parameter.
14164 (svr4_handle_solib_event): Use make_scope_exit.
14165
32603266
TT
141662019-03-06 Tom Tromey <tom@tromey.com>
14167
14168 * remote.c (struct stop_reply_deleter): Remove.
14169 (stop_reply_up): Update.
14170 (struct stop_reply): Derive from notif_event. Don't typedef.
14171 <regcache>: Now a std::vector.
14172 (stop_reply_xfree): Remove.
14173 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14174 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14175 (remote_target::discard_pending_stop_replies): Use delete.
14176 (remote_target::remote_parse_stop_reply): Update.
14177 (remote_target::process_stop_reply): Update.
14178 * remote-notif.h (struct notif_event): Add virtual destructor.
14179 Remove "dtr" member.
14180 (struct notif_client) <alloc_event>: Return a unique_ptr.
14181 (notif_event_xfree): Don't declare.
14182 (notif_event_up): New typedef.
14183 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14184 (notif_event_xfree, do_notif_event_xfree): Remove.
14185 (remote_notif_state_xfree): Update.
14186
9799571e
TT
141872019-03-06 Tom Tromey <tom@tromey.com>
14188
14189 * infrun.c (displaced_step_clear_cleanup): Now a
14190 forward_scope_exit type.
14191 (displaced_step_prepare_throw): Update.
14192 (displaced_step_fixup): Update.
14193
09e3c4ca
TT
141942019-03-06 Tom Tromey <tom@tromey.com>
14195
14196 * inferior.h (class inferior): Update comment.
14197 * gdbthread.h (class thread_info): Update comment.
14198
e2a03548
TT
141992019-03-06 Joel Brobecker <brobecker@adacore.com>
14200 Tom Tromey <tom@tromey.com>
14201
14202 * stabsread.h (struct stab_section_list): Remove.
14203 (coffstab_build_psymtabs): Update.
14204 * dbxread.c (symbuf_sections): Now a std::vector.
14205 (sect_idx): New global.
14206 (fill_symbuf): Update.
14207 (coffstab_build_psymtabs): Change type of stabsects parameter.
14208 Update.
14209 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14210 std::vector.
14211 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14212 (coff_locate_sections): Update.
14213 (coff_symfile_read): Remove cleanups. Update.
14214 (init_stringtab): Add storage parameter.
14215 (free_stringtab, free_stringtab_cleanup): Remove.
14216 (init_lineno): Add storage parameter.
14217 (free_linetab, free_linetab_cleanup): Remove.
14218
b7e60d85
PA
142192019-03-06 Pedro Alves <palves@redhat.com>
14220
14221 * linux-fork.c (fork_info::clobber_regs): Delete.
14222 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14223 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14224 comment. Adjust.
14225 (scoped_switch_fork_info::scoped_switch_fork_info)
14226 (checkpoint_command, linux_fork_context): Adjust
14227 fork_save_infrun_state calls.
14228
e52c971f
PA
142292019-03-06 Pedro Alves <palves@redhat.com>
14230
14231 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14232 (inf_has_multiple_threads): Return 'bool' and rewrite using
14233 inferior_info::threads().
14234
06974e6c
PA
142352019-03-06 Pedro Alves <palves@redhat.com>
14236
14237 * linux-fork.c: Include <list>.
14238 (fork_list): Now a std::list instance.
14239 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14240 (forks_exist_p, find_last_fork): Adjust.
14241 (new_fork): Delete.
14242 (one_fork_p): New.
14243 (add_fork): Adjust.
14244 (free_fork): Delete, folded into fork_info::~fork_info().
14245 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14246 Adjust.
14247 (init_fork_list): Delete.
14248 (linux_fork_killall, linux_fork_mourn_inferior)
14249 (linux_fork_detach, info_checkpoints_command): Adjust.
14250 (_initialize_linux_fork): No longer call init_fork_list.
14251
72f31aea
PA
142522019-03-06 Pedro Alves <palves@redhat.com>
14253
14254 * linux-fork.c (new_fork): New, split out of ...
14255 (add_fork): ... this. Return void. Move "first fork" special
14256 case from here, to ...
14257 (checkpoint_command): ... here.
14258 * linux-linux.h (add_fork): Return void.
14259
efbecbc1
AB
142602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14261
14262 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14263
0841c79a
AB
142642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14265 Chris January <chris.january@arm.com>
14266 David Lecomber <david.lecomber@arm.com>
14267
14268 * f-exp.y: New token, UNOP_INTRINSIC.
14269 (exp): New pattern using UNOP_INTRINSIC token.
14270 (f77_keywords): Add 'abs' keyword.
14271 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14272 (value_from_host_double): New function.
14273 (evaluate_subexp_f): Support UNOP_ABS.
14274
4a270568
AB
142752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14276
14277 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14278 types.
14279
067630bd
AB
142802019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14281
14282 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14283 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14284 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14285
3be47f7a
AB
142862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14287
14288 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14289
4d00f5d8
AB
142902019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14291 Chris January <chris.january@arm.com>
14292
14293 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14294 * f-exp.y: Define 'KIND' token.
14295 (exp): New pattern for KIND expressions.
14296 (ptype): Handle types with a kind extension.
14297 (direct_abs_decl): Extend to spot kind extensions.
14298 (f77_keywords): Add 'kind' to the list.
14299 (push_kind_type): New function.
14300 (convert_to_kind_type): New function.
14301 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14302 * parse.c (operator_length_standard): Likewise.
14303 * parser-defs.h (enum type_pieces): Add tp_kind.
14304 * std-operator.def: Add UNOP_KIND.
14305
e454224f
AB
143062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14307
14308 * f-exp.y (f_parse): Set yydebug.
14309
9dad4a58
AB
143102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14311
14312 * f-lang.c (evaluate_subexp_f): New function.
14313 (exp_descriptor_f): New global.
14314 (f_language_defn): Use exp_descriptor_f instead of
14315 exp_descriptor_standard.
14316
c8f91604
AB
143172019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14318
14319 * f-exp.y (struct token): Add comments.
14320 (dot_ops): Remove uppercase versions and the end marker.
14321 (f77_keywords): Likewise.
14322 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14323 entries in the dot_ops array are case insensitive, and use
14324 strncasecmp to compare strings. Also some whitespace cleanup in
14325 this area. Similar for the f77_keywords array, except entries in
14326 this list might be case sensitive.
14327
dd9f2c76
AB
143282019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14329
14330 * f-exp.y (struct f77_boolean_val): Add comments.
14331 (boolean_values): Remove uppercase versions, and end marker.
14332 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14333 and use strncasecmp to achieve case insensitivity. Additionally,
14334 perform whitespace cleanup around this code.
14335
67a3048c
TT
143362019-03-06 Tom Tromey <tromey@adacore.com>
14337
14338 * remote-sim.c (gdbsim_target_open): Use result of
14339 gdb_argv::release.
14340
aa3cfbda
RB
143412019-03-06 Richard Bunt <richard.bunt@arm.com>
14342 Dirk Schubert <dirk.schubert@arm.com>
14343 Chris January <chris.january@arm.com>
14344
14345 * eval.c (evaluate_subexp_standard): Call Fortran argument
14346 wrapping logic.
14347 * f-lang.c (struct value): A value which can be passed into a
14348 Fortran function call.
14349 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14350 where appropriate.
14351 (struct type): Value ready for a Fortran function call.
14352 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14353 is needed.
14354 * f-lang.h (fortran_argument_convert): Declaration.
14355 (fortran_preserve_arg_pointer): Declaration.
14356 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14357
ea38e5df
TT
143582019-03-05 Tom Tromey <tromey@adacore.com>
14359
14360 * python/py-prettyprint.c (print_string_repr): Remove #if.
14361 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14362
06b5b831
TT
143632019-03-05 Tom Tromey <tromey@adacore.com>
14364
14365 * target.c (the_dummy_target): Move later. Change type to
14366 "dummy_target".
14367 (initialize_targets): Don't initialize the_dummy_target.
14368
edbd9e45
TT
143692019-03-05 Tom Tromey <tromey@adacore.com>
14370
14371 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14372 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14373
c119e040
TT
143742019-03-05 Tom Tromey <tromey@adacore.com>
14375
14376 * windows-nat.c (windows_nat_target::attach)
14377 (windows_nat_target::detach): Don't call gdb_flush.
14378 * valprint.c (generic_val_print, val_print, val_print_string):
14379 Don't call gdb_flush.
14380 * utils.c (defaulted_query): Don't call gdb_flush.
14381 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14382 * target.c (target_announce_detach): Don't call gdb_flush.
14383 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14384 * remote.c (extended_remote_target::attach): Don't call
14385 gdb_flush.
14386 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14387 * printcmd.c (do_examine): Don't call gdb_flush.
14388 (info_display_command): Don't call gdb_flush.
14389 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14390 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14391 * memattr.c (info_mem_command): Don't call gdb_flush.
14392 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14393 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14394 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14395 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14396 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14397 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14398 (gnu_nat_target::detach): Don't call gdb_flush.
14399 * f-valprint.c (f_val_print): Don't call gdb_flush.
14400 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14401 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14402 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14403 gdb_flush.
14404 * c-valprint.c (c_val_print): Don't call gdb_flush.
14405 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14406
895dafa6
TT
144072019-03-05 Tom Tromey <tromey@adacore.com>
14408
14409 * varobj.c (update_dynamic_varobj_children): Update.
14410 (install_default_visualizer): Use reset, not release.
14411 * value.c (set_internalvar): Update.
14412 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14413 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14414 ATTRIBUTE_UNUSED_RESULT.
14415
88a774b9
TT
144162019-03-05 Tom Tromey <tromey@adacore.com>
14417
14418 * remote.c (class scoped_remote_fd) <release>: Add
14419 ATTRIBUTE_UNUSED_RESULT.
14420
4e4a8b93
TT
144212019-03-05 Tom Tromey <tromey@adacore.com>
14422
14423 * macroexp.c (struct macro_buffer) <release>: Add
14424 ATTRIBUTE_UNUSED_RESULT.
14425
083eef1f
TT
144262019-03-05 Tom Tromey <tromey@adacore.com>
14427
14428 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14429 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14430 ATTRIBUTE_UNUSED_RESULT.
14431
3cabd438
TT
144322019-03-05 Tom Tromey <tromey@adacore.com>
14433
14434 * common/scoped_fd.h (class scoped_fd) <release>: Add
14435 ATTRIBUTE_UNUSED_RESULT.
14436
41e3300a
TT
144372019-03-05 Tom Tromey <tromey@adacore.com>
14438
14439 * parser-defs.h (struct parser_state) <release>: Add
14440 ATTRIBUTE_UNUSED_RESULT.
14441
18cb7c9f
TT
144422019-03-05 Tom Tromey <tromey@adacore.com>
14443
14444 * utils.h (class gdb_argv) <release>: Add
14445 ATTRIBUTE_UNUSED_RESULT.
14446 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14447
41fa577f
EZ
144482019-03-02 Eli Zaretskii <eliz@gnu.org>
14449
a6a4b2c6
EZ
14450 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14451 for-loop range, to avoid compiler warnings.
14452
14453 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14454 avoid compiler warnings about unused variables.
14455
742a7df5
EZ
14456 * NEWS: Mention end of support for native debugging on MS-Windows
14457 before XP.
14458
41fa577f
EZ
14459 PR gdb/24292
14460 * common/netstuff.c:
14461 * gdbserver/gdbreplay.c
14462 * gdbserver/remote-utils.c:
14463 * ser-tcp.c:
14464 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14465 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14466 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14467 'getaddrinfo' and 'freeaddrinfo' were not available before
14468 Windows XP, and mingw.org's MinGW headers by default define
14469 _WIN32_WINNT to 0x500.
14470
827f438f
GB
144712019-03-01 Gary Benson <gbenson@redhat.com>
14472
14473 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14474
92137da0
RO
144752019-02-28 Brian Vandenberg <phantall@gmail.com>
14476 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14477
14478 PR gdb/8527
14479 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14480 set_sigint_trap, clear_sigint_trap.
14481
799efbe8
PW
144822019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14483
14484 * target.c (target_detach): Clear the regcache and the
14485 frame cache.
14486
8ed25214
PA
144872019-02-27 Pedro Alves <palves@redhat.com>
14488
14489 * utils.c (set_screen_size): When we cap the height/width sizes,
14490 tweak the corresponding command variable to show "unlimited":
14491
23031e31
SJ
144922019-02-27 Saagar Jha <saagar@saagarjha.com>
14493 Pedro Alves <palves@redhat.com>
14494
14495 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14496 before calling rl_set_screen_size.
14497
6c28e44a
TT
144982019-02-27 Tom Tromey <tromey@adacore.com>
14499
14500 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14501 define.
14502 * python/py-value.c: Remove Python 2.4 workaround.
14503 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14504 workaround.
14505 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14506 Python 2.4 workaround.
14507 * python/python-internal.h: Remove Python 2.4 comment.
14508 (Py_ssize_t): Don't define.
14509 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14510 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14511 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14512 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14513 * python/python.c (do_start_initialization): Remove Python 2.4
14514 workaround.
14515 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14516 (print_children): Remove Python 2.4 workaround.
14517 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14518 workaround.
14519 (CHARBUFFERPROC_NAME): Remove.
14520 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14521 Python 2.4 workaround.
14522
2c3fc25d 145232019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14524
2c3fc25d
KB
14525 * NEWS: Note minimum Python version.
14526
6ca62222
KB
145272019-02-27 Kevin Buettner <kevinb@redhat.com>
14528
14529 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14530 code from these functions. Remove corresponding ifdefs. Use
14531 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14532 Remove gotos and target of gotos.
14533 (infpy_search_memory): Likewise.
14534
f4bc7d2c
AB
145352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14536
14537 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14538 (hppa_gdbarch_init): Don't register deleted functions with
14539 gdbarch.
14540
9734a586
AB
145412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14542
14543 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14544 (h8300_unwind_sp): Delete.
14545 (h8300_dummy_id): Delete.
14546 (h8300_gdbarch_init): Don't register deleted functions with
14547 gdbarch.
14548
68b867f3
AB
145492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14550
14551 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14552 (ft32_unwind_pc): Delete.
14553 (ft32_unwind_sp): Delete.
14554 (ft32_gdbarch_init): Don't register deleted functions with
14555 gdbarch.
14556
2fbe7ad0
AB
145572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14558
14559 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14560 (frv_unwind_pc): Delete.
14561 (frv_unwind_sp): Delete.
14562 (frv_gdbarch_init): Don't register deleted functions with
14563 gdbarch.
14564
76055cbe
AB
145652019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14566
14567 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14568 (riscv_unwind_pc): Delete.
14569 (riscv_unwind_sp): Delete.
14570 (riscv_gdbarch_init): Don't register deleted functions with
14571 gdbarch.
14572
4133e5a1
AB
145732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14574
14575 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14576 (csky_unwind_pc): Delete.
14577 (csky_unwind_sp): Delete.
14578 (csky_gdbarch_init): Don't register deleted functions with
14579 gdbarch.
14580
8010f576
AB
145812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14582
14583 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14584 (cris_unwind_pc): Delete.
14585 (cris_unwind_sp): Delete.
14586 (cris_gdbarch_init): Don't register deleted functions with
14587 gdbarch.
14588
b56bf084
AB
145892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14590
14591 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14592 (bfin_unwind_pc): Delete.
14593 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14594
a19a650f
AB
145952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14596
14597 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14598 (arm_unwind_pc): Delete.
14599 (arm_unwind_sp): Delete.
14600 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14601
f8278c3c
AB
146022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14603
14604 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14605 (arc_unwind_pc): Delete.
14606 (arc_unwind_sp): Delete.
14607 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14608
480e46cf
AB
146092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14610
14611 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14612 (alpha_unwind_pc): Delete.
14613 (alpha_gdbarch_init): Don't register deleted functions with
14614 gdbarch.
14615
7a995095
AB
146162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14617
14618 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14619 (aarch64_unwind_pc): Delete.
14620 (aarch64_unwind_sp): Delete.
14621 (aarch64_gdbarch_init): Don't register deleted functions with
14622 gdbarch.
14623
bf9a735e
AB
146242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14625
14626 * gdbtypes.c (type_align): Don't consider static members when
14627 computing structure alignment.
14628
5561fc30
AB
146292019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14630
14631 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14632 return 0 for other types.
14633 * arch-utils.c (default_type_align): Always return 0.
14634 * gdbarch.h: Regenerate.
14635 * gdbarch.sh (type_align): Extend comment.
14636 * gdbtypes.c (type_align): Add additional comments, always call
14637 gdbarch_type_align before applying the default rules.
14638 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14639 generic code will then apply a suitable default.
14640 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14641 types, return 0 for other types.
14642
9335e75a
JB
146432019-02-27 Joel Brobecker <brobecker@adacore.com>
14644
14645 * NEWS: Create a new section for the next release branch.
14646 Rename the section of the current branch, now that it has
14647 been cut.
14648
3d34d8de
JB
146492019-02-27 Joel Brobecker <brobecker@adacore.com>
14650
14651 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14652 * version.in: Bump version to 8.3.50.DATE-git.
14653
143420fb
SM
146542019-02-26 Simon Marchi <simon.marchi@efficios.com>
14655
14656 * aix-thread.c (ptid_cmp): Remove unused variable.
14657 (get_signaled_thread): Likewise.
14658 (store_regs_user_thread): Likewise.
14659 (store_regs_kernel_thread): Likewise.
14660 (fetch_regs_kernel_thread): Remove shadowed variable.
14661
172fb711
AB
146622019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14663
14664 * features/riscv/32bit-cpu.xml: Add register numbers.
14665 * features/riscv/32bit-fpu.c: Regenerate.
14666 * features/riscv/32bit-fpu.xml: Add register numbers.
14667 * features/riscv/64bit-cpu.xml: Add register numbers.
14668 * features/riscv/64bit-fpu.c: Regenerate.
14669 * features/riscv/64bit-fpu.xml: Add register numbers.
14670
26c89782
KB
146712019-02-26 Kevin Buettner <kevinb@redhat.com>
14672
af54ade9 14673 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14674 * python/py-value.c (convert_buffer_and_type_to_value): New
14675 function.
14676 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14677 Add support for handling an optional second argument. Call
14678 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14679 * python/python-internal.h (Py_buffer_deleter): New struct.
14680 (Py_buffer_up): New typedef.
14681
0f58c9e8
JB
146822019-02-25 John Baldwin <jhb@FreeBSD.org>
14683
14684 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14685 instead of releasing ownership.
14686
0a0f4c01
JR
146872019-02-25 Jordan Rupprecht <rupprecht@google.com>
14688
14689 * dwarf2read.c (open_and_init_dwp_file): Call
14690 elf_numsections instead of bfd_count_sections to initialize
14691 dwp_file->num_sections.
14692
cd5a152c
TT
146932019-02-25 Tom Tromey <tromey@adacore.com>
14694
14695 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14696
8a6a8513
SDJ
146972019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14698
14699 * gcore.in: Add '--readnever' option when invoking GDB.
14700
04dcda9c
SM
147012019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14702
14703 * MAINTAINERS: Update my email address.
14704
07bc701d
SM
147052019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14706
14707 * build-id.c (build_id_to_debug_bfd_1): New function.
14708 (build_id_to_debug_bfd): Look for separate debug file in
14709 sysroot.
14710
c6f4a5d0
AB
147112019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14712
14713 * gdbarch.sh: Update the copyright year range that is placed into
14714 generated files.
14715
9600246d
KS
147162019-02-22 Keith Seitz <keiths@redhat.com>
14717
14718 PR symtab/23853
14719 * linespec.c (create_sals_line_offset): Search for the default
14720 symtab's filename instead of its fullname.
14721
7557a514
AH
147222019-02-21 Alan Hayward <alan.hayward@arm.com>
14723
14724 * NEWS: Update style defaults.
14725
ee2bcb0c
AH
147262019-02-21 Alan Hayward <alan.hayward@arm.com>
14727
14728 * main.c (captured_main_1): Disable styling in batch mode.
14729
0c95f9ed
TT
147302019-02-20 Tom Tromey <tom@tromey.com>
14731
14732 * symtab.c (symtab_symbol_info): Fix typos.
14733
c763b894
TT
147342019-02-20 Tom Tromey <tromey@adacore.com>
14735
14736 * findcmd.c (_initialize_mem_search): Use upper case for
14737 metasyntactic variables.
14738
0ef8a082
AH
147392019-02-20 Alan Hayward <alan.hayward@arm.com>
14740
14741 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14742 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14743
6caa91b6
SM
147442019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14745
14746 * top.h (source_file_name): Change to std::string.
14747 * top.c (source_file_name): Likewise.
14748 (command_line_input): Adjust.
14749 * cli/cli-script.c (script_from_file): Adjust.
14750
98814c6c
TT
147512019-02-19 Tom Tromey <tromey@adacore.com>
14752
14753 * ravenscar-thread.c
14754 (ravenscar_thread_target::update_thread_list): Don't call
14755 ada_build_task_list.
14756 * ada-lang.h (ada_build_task_list): Don't declare.
14757 * ada-tasks.c (struct ada_tasks_inferior_data)
14758 <task_list_valid_p>: Now bool.
14759 (read_known_tasks, ada_task_list_changed)
14760 (ada_tasks_invalidate_inferior_data): Update.
14761 (read_known_tasks_array): Return bool.
14762 (read_known_tasks_list): Likewise.
14763 (read_known_tasks): Return void.
14764 (ada_build_task_list): Now static.
14765
70cd633e
AB
147662019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14767
14768 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14769 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14770
040b3e95
PW
147712019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14772
14773 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14774 variant for ada_tasks_pspace_data_handle and
14775 ada_tasks_inferior_data_handle.
14776 (ada_tasks_pspace_data_cleanup): New function.
14777 (ada_tasks_inferior_data_cleanup): New function.
14778
9409233b
TT
147792019-02-17 Tom Tromey <tom@tromey.com>
14780
14781 * macrotab.h (macro_source_fullname): Return a std::string.
14782 * macrotab.c (macro_include, check_for_redefinition)
14783 (macro_undef, macro_lookup_definition, foreach_macro)
14784 (foreach_macro_in_scope): Update.
14785 (macro_source_fullname): Return a std::string.
14786 * macrocmd.c (show_pp_source_pos): Update.
14787
6506371f
TT
147882019-02-17 Tom Tromey <tom@tromey.com>
14789
14790 * macrocmd.c (show_pp_source_pos): Style the file names.
14791
0c820d67
TT
147922019-02-17 Tom Tromey <tom@tromey.com>
14793
14794 PR tui/24197:
14795 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14796
a0087920
TT
147972019-02-17 Tom Tromey <tom@tromey.com>
14798
14799 * ada-lang.c (user_select_syms): Use filtered printing.
14800 * utils.c (wrap_style): New global.
14801 (desired_style): Remove.
14802 (emit_style_escape): Add stream parameter.
14803 (set_output_style, reset_terminal_style, prompt_for_continue):
14804 Update.
14805 (flush_wrap_buffer): Only flush gdb_stdout.
14806 (wrap_here): Set wrap_style.
14807 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14808 treat escape sequences as a character. Change when wrap buffer is
14809 flushed.
14810 (fputs_styled): Do not set the output style when the default is
14811 requested.
14812 * ui-style.h (struct ui_file_style) <is_default>: New method.
14813 * source.c (print_source_lines_base): Emit escape sequences in one
14814 piece.
14815
75ba10dc
JB
148162019-02-17 Joel Brobecker <brobecker@adacore.com>
14817
14818 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14819 integers and enumeration types.
14820
a2cd4f14
JB
148212019-02-17 Joel Brobecker <brobecker@adacore.com>
14822
14823 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14824 instead of lookup_symbol_in_language
14825 (do_exact_match): New function.
14826 (ada_get_symbol_name_matcher): Return do_exact_match when
14827 doing a verbatim match.
14828
485b851b
TT
148292019-02-15 Tom Tromey <tromey@adacore.com>
14830
14831 * ravenscar-thread.c (ravenscar_thread_target::resume)
14832 (ravenscar_thread_target::wait): Special case wildcard requests.
14833
0b790b1e
TT
148342019-02-15 Tom Tromey <tromey@adacore.com>
14835
14836 * ravenscar-thread.c (base_ptid): Remove.
14837 (struct ravenscar_thread_target) <close>: New method.
14838 <m_base_ptid>: New member.
14839 <update_inferior_ptid, active_task, task_is_currently_active,
14840 runtime_initialized>: Declare methods.
14841 <ravenscar_thread_target>: Add constructor.
14842 (ravenscar_thread_target::task_is_currently_active)
14843 (ravenscar_thread_target::update_inferior_ptid)
14844 (ravenscar_runtime_initialized): Rename. Now methods.
14845 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14846 (ravenscar_thread_target::update_thread_list): Update.
14847 (ravenscar_thread_target::active_task): Now method.
14848 (ravenscar_thread_target::store_registers)
14849 (ravenscar_thread_target::prepare_to_store)
14850 (ravenscar_thread_target::prepare_to_store)
14851 (ravenscar_thread_target::mourn_inferior): Update.
14852 (ravenscar_inferior_created): Use "new" to create target.
14853 (ravenscar_thread_target::get_ada_task_ptid): Update.
14854 (_initialize_ravenscar): Don't initialize base_ptid.
14855 (ravenscar_ops): Remove global.
14856
dea57a62
TT
148572019-02-15 Tom Tromey <tromey@adacore.com>
14858
14859 * target.h (push_target): Declare new overload.
14860 * target.c (push_target): New overload, taking an rvalue reference.
14861 * remote.c (remote_target::open_1): Use push_target overload.
14862 * corelow.c (core_target_open): Use push_target overload.
14863
989f3c58
TT
148642019-02-15 Tom Tromey <tromey@adacore.com>
14865
14866 * ravenscar-thread.c (is_ravenscar_task)
14867 (ravenscar_task_is_currently_active): Return bool.
14868 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14869 (_initialize_ravenscar): Remove "(void)".
14870 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14871 Return bool.
14872
6cbcc006
TT
148732019-02-15 Tom Tromey <tromey@adacore.com>
14874
14875 * ravenscar-thread.c (ravenscar_runtime_initializer)
14876 (has_ravenscar_runtime, get_running_thread_id)
14877 (ravenscar_thread_target::resume): Fix indentation.
14878
7657f14d
TT
148792019-02-15 Tom Tromey <tromey@adacore.com>
14880
14881 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14882 from ravenscar_arch_ops.
14883 (sparc_ravenscar_ops::fetch_registers)
14884 (sparc_ravenscar_ops::store_registers): Now methods.
14885 (sparc_ravenscar_prepare_to_store): Remove.
14886 (sparc_ravenscar_ops): Redefine.
14887 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14888 methods and destructor. Remove members.
14889 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14890 (ravenscar_thread_target::store_registers)
14891 (ravenscar_thread_target::prepare_to_store): Update.
14892 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14893 Remove.
14894 (struct ppc_ravenscar_powerpc_ops): Derive from
14895 ravenscar_arch_ops.
14896 (ppc_ravenscar_powerpc_ops::fetch_registers)
14897 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14898 (ppc_ravenscar_powerpc_ops): Redefine.
14899 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14900 (ppc_ravenscar_e500_ops::fetch_registers)
14901 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14902 (ppc_ravenscar_e500_ops): Redefine.
14903 * aarch64-ravenscar-thread.c
14904 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14905 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14906 (aarch64_ravenscar_fetch_registers)
14907 (aarch64_ravenscar_store_registers): Now methods.
14908 (aarch64_ravenscar_ops): Redefine.
14909
5b6ea500
TT
149102019-02-15 Tom Tromey <tromey@adacore.com>
14911
14912 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14913 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14914 (ravenscar_thread_target::stopped_by_watchpoint)
14915 (ravenscar_thread_target::stopped_data_address)
14916 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14917
e397fd39
TT
149182019-02-15 Tom Tromey <tromey@adacore.com>
14919
14920 * ravenscar-thread.c: Fix some typos.
14921
cc12f4a8
TT
149222019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14923 Tom Tromey <tromey@adacore.com>
14924
14925 * ada-lang.c (ada_exception_sal): Change addr_string to a
14926 std::string.
14927 (create_ada_exception_catchpoint): Update.
14928
5f486660
TT
149292019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14930 Tom Tromey <tromey@adacore.com>
14931
14932 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14933 (bp_location_ops): Remove.
14934 (base_breakpoint_allocate_location): Update.
14935 (free_bp_location): Update.
14936 * ada-lang.c (class ada_catchpoint_location)
14937 <ada_catchpoint_location>: Remove ops parameter.
14938 (ada_catchpoint_location_dtor): Remove.
14939 (ada_catchpoint_location_ops): Remove.
14940 (allocate_location_exception): Update.
14941 * breakpoint.h (struct bp_location_ops): Remove.
14942 (class bp_location) <bp_location>: Remove bp_location_ops
14943 parameter.
14944 <~bp_location>: Add destructor.
14945 <ops>: Remove.
14946
b671c7fb
TS
149472019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14948 Pedro Alves <palves@redhat.com>
14949
14950 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14951 'PATH_MAX'.
14952
8071c5ce
DM
149532019-02-14 David Michael <fedora.dm0@gmail.com>
14954 Samuel Thibault <samuel.thibault@gnu.org>
14955 Thomas Schwinge <thomas@codesourcery.com>
14956
14957 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14958 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14959
b1041ae0
TS
149602019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14961
924514e1
TS
14962 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14963 (check_empty): Use "const char *".
14964
c29ee8d4
TS
14965 * gnu-nat.c (gnu_nat_target::detach): Instead of
14966 'detach_inferior (pid)' call
14967 'detach_inferior (find_inferior_pid (pid))'.
14968
6c6ef69f
TS
14969 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14970 'nat/fork-inferior.o'.
14971 * gnu-nat.c: #include "nat/fork-inferior.h".
14972
2d0a338c
TS
14973 * gnu-nat.c (gnu_nat_target::detach): Instead of
14974 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14975 * gnu-nat.h: #include "inf-child.h".
14976 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14977 'i386_gnu_nat_target::fetch_registers'.
14978 (gnu_store_registers): Rename/move to
14979 'i386_gnu_nat_target::store_registers'.
14980
cabb5f06
TS
14981 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14982 * gnu-nat.h (mach_thread_info): New function.
14983 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14984
b1041ae0
TS
14985 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14986
2988d01e
KF
149872019-02-14 Frederic Konrad <konrad@adacore.com>
14988
14989 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14990
c559d709
JB
149912019-02-14 Joel Brobecker <brobecker@adacore.com>
14992
14993 * windows-nat.c (windows_add_thread): Add new parameter
14994 "main_thread_p" with default value set to false. Update
14995 function documentation as well as all callers.
14996 (windows_delete_thread): Likewise.
14997 (fake_create_process): Update call to windows_add_thread.
14998 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14999 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15000 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15001 call to windows_delete_thread.
15002
007024cc
SM
150032019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15004
15005 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15006
f62318e9
JB
150072019-02-12 John Baldwin <jhb@FreeBSD.org>
15008
15009 * symfile.c (find_separate_debug_file): Use canonical path of
15010 sysroot with child_path instead of gdb_sysroot if it is valid.
15011
cd4b7848
JB
150122019-02-12 John Baldwin <jhb@FreeBSD.org>
15013
15014 * symfile.c (find_separate_debug_file): Use child_path to
15015 determine if an object file is under a sysroot.
15016
efac4bfe
JB
150172019-02-12 John Baldwin <jhb@FreeBSD.org>
15018
15019 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15020 unittests/child-path-selftests.c.
15021 * common/pathstuff.c (child_path): New function.
15022 * common/pathstuff.h (child_path): New prototype.
15023 * unittests/child-path-selftests.c: New file.
15024
402d2bfe
JB
150252019-02-12 John Baldwin <jhb@FreeBSD.org>
15026
15027 * symfile.c (find_separate_debug_file): Look for separate debug
15028 files in debug directories under the sysroot.
15029
1ed9f74e
PW
150302019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15031
15032 * symtab.h (struct minimal_symbol data_p): New const method.
15033 (struct minimal_symbol text_p): Likewise.
15034 * symtab.c (output_source_filename): Use file name style
15035 to print file name.
15036 (print_symbol_info): Likewise.
15037 (print_msymbol_info): Use address style to print addresses.
15038 Use function name style to print executable text symbols.
15039 (expand_symtab_containing_pc): Use data_p.
15040 (find_pc_sect_compunit_symtab): Likewise.
15041
2636d81d
PW
150422019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15043
15044 * breakpoint.c (describe_other_breakpoints): Use address style
15045 to print addresses.
15046 (say_where): Likewise.
15047
ac8c53cc
PW
150482019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15049
15050 * ada-typeprint.c (print_func_type): Print function name
15051 style to print function name.
15052 * c-typeprint.c (c_print_type_1): Likewise.
15053
ea638c43
AH
150542019-02-11 Alan Hayward <alan.hayward@arm.com>
15055
15056 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15057 for execve.
15058
ab759ca8
PW
150592019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15060
15061 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15062 type_stack.
15063
aff29d1c
JB
150642019-02-10 Joel Brobecker <brobecker@adacore.com>
15065
15066 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15067 TYPE_CODE_REF types.
15068
617126bc
JW
150692019-02-08 Jim Wilson <jimw@sifive.com>
15070
15071 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15072 (riscv_linux_fregset): New.
15073 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15074
46e3ed7f
TT
150752019-02-07 Tom Tromey <tom@tromey.com>
15076
15077 * thread.c (thread_cancel_execution_command): Update.
15078 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15079 methods.
15080 (struct thread_fsm_ops): Remove.
15081 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15082 (thread_fsm_should_stop, thread_fsm_return_value)
15083 (thread_fsm_set_finished, thread_fsm_finished_p)
15084 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15085 Don't declare.
15086 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15087 * infrun.c (clear_proceed_status_thread)
15088 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15089 (print_stop_event): Update.
15090 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15091 Add constructor.
15092 (step_command_fsm_ops): Remove.
15093 (new_step_command_fsm): Remove.
15094 (step_1): Update.
15095 (step_command_fsm::should_stop): Rename from
15096 step_command_fsm_should_stop.
15097 (step_command_fsm::clean_up): Rename from
15098 step_command_fsm_clean_up.
15099 (step_command_fsm::do_async_reply_reason): Rename from
15100 step_command_fsm_async_reply_reason.
15101 (struct until_next_fsm): Inherit from thread_fsm. Add
15102 constructor.
15103 (until_next_fsm_ops): Remove.
15104 (new_until_next_fsm): Remove.
15105 (until_next_fsm::should_stop): Rename from
15106 until_next_fsm_should_stop.
15107 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15108 (until_next_fsm::do_async_reply_reason): Rename from
15109 until_next_fsm_async_reply_reason.
15110 (struct finish_command_fsm): Inherit from thread_fsm. Add
15111 constructor. Change type of breakpoint.
15112 (finish_command_fsm_ops): Remove.
15113 (new_finish_command_fsm): Remove.
15114 (finish_command_fsm::should_stop): Rename from
15115 finish_command_fsm_should_stop.
15116 (finish_command_fsm::clean_up): Rename from
15117 finish_command_fsm_clean_up.
15118 (finish_command_fsm::return_value): Rename from
15119 finish_command_fsm_return_value.
15120 (finish_command_fsm::do_async_reply_reason): Rename from
15121 finish_command_fsm_async_reply_reason.
15122 (finish_command): Update.
15123 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15124 Add constructor.
15125 (call_thread_fsm_ops): Remove.
15126 (call_thread_fsm::call_thread_fsm): Rename from
15127 new_call_thread_fsm.
15128 (call_thread_fsm::should_stop): Rename from
15129 call_thread_fsm_should_stop.
15130 (call_thread_fsm::should_notify_stop): Rename from
15131 call_thread_fsm_should_notify_stop.
15132 (run_inferior_call, call_function_by_hand_dummy): Update.
15133 * cli/cli-interp.c (should_print_stop_to_console): Update.
15134 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15135 Add constructor. Change type of location_breakpoint,
15136 caller_breakpoint.
15137 (until_break_fsm_ops): Remove.
15138 (new_until_break_fsm): Remove.
15139 (until_break_fsm::should_stop): Rename from
15140 until_break_fsm_should_stop.
15141 (until_break_fsm::clean_up): Rename from
15142 until_break_fsm_clean_up.
15143 (until_break_fsm::do_async_reply_reason): Rename from
15144 until_break_fsm_async_reply_reason.
15145 (until_break_command): Update.
15146 * thread-fsm.c: Remove.
15147 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15148
1a5c2598
TT
151492019-02-07 Tom Tromey <tom@tromey.com>
15150
15151 * yy-remap.h: Add include guard.
15152 * xtensa-tdep.h: Add include guard.
15153 * xcoffread.h: Rename include guard.
15154 * varobj-iter.h: Add include guard.
15155 * tui/tui.h: Rename include guard.
15156 * tui/tui-winsource.h: Rename include guard.
15157 * tui/tui-wingeneral.h: Rename include guard.
15158 * tui/tui-windata.h: Rename include guard.
15159 * tui/tui-win.h: Rename include guard.
15160 * tui/tui-stack.h: Rename include guard.
15161 * tui/tui-source.h: Rename include guard.
15162 * tui/tui-regs.h: Rename include guard.
15163 * tui/tui-out.h: Rename include guard.
15164 * tui/tui-layout.h: Rename include guard.
15165 * tui/tui-io.h: Rename include guard.
15166 * tui/tui-hooks.h: Rename include guard.
15167 * tui/tui-file.h: Rename include guard.
15168 * tui/tui-disasm.h: Rename include guard.
15169 * tui/tui-data.h: Rename include guard.
15170 * tui/tui-command.h: Rename include guard.
15171 * tic6x-tdep.h: Add include guard.
15172 * target/waitstatus.h: Rename include guard.
15173 * target/wait.h: Rename include guard.
15174 * target/target.h: Rename include guard.
15175 * target/resume.h: Rename include guard.
15176 * target-float.h: Rename include guard.
15177 * stabsread.h: Add include guard.
15178 * rs6000-tdep.h: Add include guard.
15179 * riscv-fbsd-tdep.h: Add include guard.
15180 * regformats/regdef.h: Rename include guard.
15181 * record.h: Rename include guard.
15182 * python/python.h: Rename include guard.
15183 * python/python-internal.h: Rename include guard.
15184 * python/py-stopevent.h: Rename include guard.
15185 * python/py-ref.h: Rename include guard.
15186 * python/py-record.h: Rename include guard.
15187 * python/py-record-full.h: Rename include guard.
15188 * python/py-record-btrace.h: Rename include guard.
15189 * python/py-instruction.h: Rename include guard.
15190 * python/py-events.h: Rename include guard.
15191 * python/py-event.h: Rename include guard.
15192 * procfs.h: Add include guard.
15193 * proc-utils.h: Add include guard.
15194 * p-lang.h: Add include guard.
15195 * or1k-tdep.h: Rename include guard.
15196 * observable.h: Rename include guard.
15197 * nto-tdep.h: Rename include guard.
15198 * nat/x86-linux.h: Rename include guard.
15199 * nat/x86-linux-dregs.h: Rename include guard.
15200 * nat/x86-gcc-cpuid.h: Add include guard.
15201 * nat/x86-dregs.h: Rename include guard.
15202 * nat/x86-cpuid.h: Rename include guard.
15203 * nat/ppc-linux.h: Rename include guard.
15204 * nat/mips-linux-watch.h: Rename include guard.
15205 * nat/linux-waitpid.h: Rename include guard.
15206 * nat/linux-ptrace.h: Rename include guard.
15207 * nat/linux-procfs.h: Rename include guard.
15208 * nat/linux-osdata.h: Rename include guard.
15209 * nat/linux-nat.h: Rename include guard.
15210 * nat/linux-namespaces.h: Rename include guard.
15211 * nat/linux-btrace.h: Rename include guard.
15212 * nat/glibc_thread_db.h: Rename include guard.
15213 * nat/gdb_thread_db.h: Rename include guard.
15214 * nat/gdb_ptrace.h: Rename include guard.
15215 * nat/fork-inferior.h: Rename include guard.
15216 * nat/amd64-linux-siginfo.h: Rename include guard.
15217 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15218 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15219 * nat/aarch64-linux.h: Rename include guard.
15220 * nat/aarch64-linux-hw-point.h: Rename include guard.
15221 * mn10300-tdep.h: Add include guard.
15222 * mips-linux-tdep.h: Add include guard.
15223 * mi/mi-parse.h: Rename include guard.
15224 * mi/mi-out.h: Rename include guard.
15225 * mi/mi-main.h: Rename include guard.
15226 * mi/mi-interp.h: Rename include guard.
15227 * mi/mi-getopt.h: Rename include guard.
15228 * mi/mi-console.h: Rename include guard.
15229 * mi/mi-common.h: Rename include guard.
15230 * mi/mi-cmds.h: Rename include guard.
15231 * mi/mi-cmd-break.h: Rename include guard.
15232 * m2-lang.h: Add include guard.
15233 * location.h: Rename include guard.
15234 * linux-record.h: Rename include guard.
15235 * linux-nat.h: Add include guard.
15236 * linux-fork.h: Add include guard.
15237 * i386-darwin-tdep.h: Rename include guard.
15238 * hppa-linux-offsets.h: Add include guard.
15239 * guile/guile.h: Rename include guard.
15240 * guile/guile-internal.h: Rename include guard.
15241 * gnu-nat.h: Rename include guard.
15242 * gdb-stabs.h: Rename include guard.
15243 * frv-tdep.h: Add include guard.
15244 * f-lang.h: Add include guard.
15245 * event-loop.h: Add include guard.
15246 * darwin-nat.h: Rename include guard.
15247 * cp-abi.h: Rename include guard.
15248 * config/sparc/nm-sol2.h: Rename include guard.
15249 * config/nm-nto.h: Rename include guard.
15250 * config/nm-linux.h: Add include guard.
15251 * config/i386/nm-i386gnu.h: Rename include guard.
15252 * config/djgpp/nl_types.h: Rename include guard.
15253 * config/djgpp/langinfo.h: Rename include guard.
15254 * compile/gcc-cp-plugin.h: Add include guard.
15255 * compile/gcc-c-plugin.h: Add include guard.
15256 * compile/compile.h: Rename include guard.
15257 * compile/compile-object-run.h: Rename include guard.
15258 * compile/compile-object-load.h: Rename include guard.
15259 * compile/compile-internal.h: Rename include guard.
15260 * compile/compile-cplus.h: Rename include guard.
15261 * compile/compile-c.h: Rename include guard.
15262 * common/xml-utils.h: Rename include guard.
15263 * common/x86-xstate.h: Rename include guard.
15264 * common/version.h: Rename include guard.
15265 * common/vec.h: Rename include guard.
15266 * common/tdesc.h: Rename include guard.
15267 * common/selftest.h: Rename include guard.
15268 * common/scoped_restore.h: Rename include guard.
15269 * common/scoped_mmap.h: Rename include guard.
15270 * common/scoped_fd.h: Rename include guard.
15271 * common/safe-iterator.h: Rename include guard.
15272 * common/run-time-clock.h: Rename include guard.
15273 * common/refcounted-object.h: Rename include guard.
15274 * common/queue.h: Rename include guard.
15275 * common/ptid.h: Rename include guard.
15276 * common/print-utils.h: Rename include guard.
15277 * common/preprocessor.h: Rename include guard.
15278 * common/pathstuff.h: Rename include guard.
15279 * common/observable.h: Rename include guard.
15280 * common/netstuff.h: Rename include guard.
15281 * common/job-control.h: Rename include guard.
15282 * common/host-defs.h: Rename include guard.
15283 * common/gdb_wait.h: Rename include guard.
15284 * common/gdb_vecs.h: Rename include guard.
15285 * common/gdb_unlinker.h: Rename include guard.
15286 * common/gdb_unique_ptr.h: Rename include guard.
15287 * common/gdb_tilde_expand.h: Rename include guard.
15288 * common/gdb_sys_time.h: Rename include guard.
15289 * common/gdb_string_view.h: Rename include guard.
15290 * common/gdb_splay_tree.h: Rename include guard.
15291 * common/gdb_setjmp.h: Rename include guard.
15292 * common/gdb_ref_ptr.h: Rename include guard.
15293 * common/gdb_optional.h: Rename include guard.
15294 * common/gdb_locale.h: Rename include guard.
15295 * common/gdb_assert.h: Rename include guard.
15296 * common/filtered-iterator.h: Rename include guard.
15297 * common/filestuff.h: Rename include guard.
15298 * common/fileio.h: Rename include guard.
15299 * common/environ.h: Rename include guard.
15300 * common/common-utils.h: Rename include guard.
15301 * common/common-types.h: Rename include guard.
15302 * common/common-regcache.h: Rename include guard.
15303 * common/common-inferior.h: Rename include guard.
15304 * common/common-gdbthread.h: Rename include guard.
15305 * common/common-exceptions.h: Rename include guard.
15306 * common/common-defs.h: Rename include guard.
15307 * common/common-debug.h: Rename include guard.
15308 * common/cleanups.h: Rename include guard.
15309 * common/buffer.h: Rename include guard.
15310 * common/btrace-common.h: Rename include guard.
15311 * common/break-common.h: Rename include guard.
15312 * cli/cli-utils.h: Rename include guard.
15313 * cli/cli-style.h: Rename include guard.
15314 * cli/cli-setshow.h: Rename include guard.
15315 * cli/cli-script.h: Rename include guard.
15316 * cli/cli-interp.h: Rename include guard.
15317 * cli/cli-decode.h: Rename include guard.
15318 * cli/cli-cmds.h: Rename include guard.
15319 * charset-list.h: Add include guard.
15320 * buildsym-legacy.h: Rename include guard.
15321 * bfin-tdep.h: Add include guard.
15322 * ax.h: Rename include guard.
15323 * arm-linux-tdep.h: Add include guard.
15324 * arm-fbsd-tdep.h: Add include guard.
15325 * arch/xtensa.h: Rename include guard.
15326 * arch/tic6x.h: Add include guard.
15327 * arch/i386.h: Add include guard.
15328 * arch/arm.h: Rename include guard.
15329 * arch/arm-linux.h: Rename include guard.
15330 * arch/arm-get-next-pcs.h: Rename include guard.
15331 * arch/amd64.h: Add include guard.
15332 * arch/aarch64-insn.h: Rename include guard.
15333 * arch-utils.h: Rename include guard.
15334 * annotate.h: Add include guard.
15335 * amd64-darwin-tdep.h: Rename include guard.
15336 * aarch64-linux-tdep.h: Add include guard.
15337 * aarch64-fbsd-tdep.h: Add include guard.
15338 * aarch32-linux-nat.h: Add include guard.
15339
ab9268d2
PW
153402019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15341
15342 * macrotab.c (macro_define_internal): New function that
15343 factorizes macro_define_object_internal and macro_define_function
15344 code.
15345 (macro_define_object_internal): Use macro_define_internal.
15346 (macro_define_function): Likewise.
15347
bb0da2b4
PW
153482019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15349
15350 * macrocmd.c (extract_identifier): Return
15351 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15352 callers.
15353
424eb552
JB
153542019-02-06 John Baldwin <jhb@FreeBSD.org>
15355
15356 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15357
1688cb29
TT
153582019-02-05 Tom Tromey <tom@tromey.com>
15359
15360 * target.c (target_stack::unpush): Move assertion earlier.
15361
b5eba2d8
TT
153622019-01-30 Tom Tromey <tom@tromey.com>
15363
15364 PR python/23615:
15365 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15366 (gdbpy_parse_and_eval): Likewise.
15367 * python/python-internal.h (gdbpy_allow_threads): New class.
15368
7054e2ff
JB
153692019-01-28 John Baldwin <jhb@FreeBSD.org>
15370
15371 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15372 (aarch64_fbsd_fpregmap): Move earlier.
15373 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15374 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15375 instead of individual calls to trad_frame_set_reg_addr.
15376 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15377 earlier.
15378 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15379 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15380 instead of individual calls to trad_frame_set_reg_addr.
15381
36c25ffa
AH
153822019-01-28 Alan Hayward <alan.hayward@arm.com>
15383
15384 * CONTRIBUTE: Replace contribution list with wiki link.
15385
a0707f3c
TT
153862019-01-25 Tom Tromey <tom@tromey.com>
15387
15388 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15389
0747795c
TT
153902019-01-25 Tom Tromey <tom@tromey.com>
15391
15392 * xtensa-linux-nat.c: Fix common/ includes.
15393 * xml-support.h: Fix common/ includes.
15394 * xml-support.c: Fix common/ includes.
15395 * x86-linux-nat.c: Fix common/ includes.
15396 * windows-nat.c: Fix common/ includes.
15397 * varobj.h: Fix common/ includes.
15398 * varobj.c: Fix common/ includes.
15399 * value.c: Fix common/ includes.
15400 * valops.c: Fix common/ includes.
15401 * utils.c: Fix common/ includes.
15402 * unittests/xml-utils-selftests.c: Fix common/ includes.
15403 * unittests/utils-selftests.c: Fix common/ includes.
15404 * unittests/unpack-selftests.c: Fix common/ includes.
15405 * unittests/tracepoint-selftests.c: Fix common/ includes.
15406 * unittests/style-selftests.c: Fix common/ includes.
15407 * unittests/string_view-selftests.c: Fix common/ includes.
15408 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15409 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15410 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15411 * unittests/rsp-low-selftests.c: Fix common/ includes.
15412 * unittests/parse-connection-spec-selftests.c: Fix common/
15413 includes.
15414 * unittests/optional-selftests.c: Fix common/ includes.
15415 * unittests/offset-type-selftests.c: Fix common/ includes.
15416 * unittests/observable-selftests.c: Fix common/ includes.
15417 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15418 * unittests/memrange-selftests.c: Fix common/ includes.
15419 * unittests/memory-map-selftests.c: Fix common/ includes.
15420 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15421 * unittests/function-view-selftests.c: Fix common/ includes.
15422 * unittests/environ-selftests.c: Fix common/ includes.
15423 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15424 * unittests/common-utils-selftests.c: Fix common/ includes.
15425 * unittests/cli-utils-selftests.c: Fix common/ includes.
15426 * unittests/array-view-selftests.c: Fix common/ includes.
15427 * ui-file.c: Fix common/ includes.
15428 * tui/tui-io.c: Fix common/ includes.
15429 * tracepoint.h: Fix common/ includes.
15430 * tracepoint.c: Fix common/ includes.
15431 * tracefile-tfile.c: Fix common/ includes.
15432 * top.h: Fix common/ includes.
15433 * top.c: Fix common/ includes.
15434 * thread.c: Fix common/ includes.
15435 * target/waitstatus.h: Fix common/ includes.
15436 * target/waitstatus.c: Fix common/ includes.
15437 * target.h: Fix common/ includes.
15438 * target.c: Fix common/ includes.
15439 * target-memory.c: Fix common/ includes.
15440 * target-descriptions.c: Fix common/ includes.
15441 * symtab.h: Fix common/ includes.
15442 * symfile.c: Fix common/ includes.
15443 * stap-probe.c: Fix common/ includes.
15444 * spu-linux-nat.c: Fix common/ includes.
15445 * sparc-nat.c: Fix common/ includes.
15446 * source.c: Fix common/ includes.
15447 * solib.c: Fix common/ includes.
15448 * solib-target.c: Fix common/ includes.
15449 * ser-unix.c: Fix common/ includes.
15450 * ser-tcp.c: Fix common/ includes.
15451 * ser-pipe.c: Fix common/ includes.
15452 * ser-base.c: Fix common/ includes.
15453 * selftest-arch.c: Fix common/ includes.
15454 * s12z-tdep.c: Fix common/ includes.
15455 * rust-exp.y: Fix common/ includes.
15456 * rs6000-aix-tdep.c: Fix common/ includes.
15457 * riscv-tdep.c: Fix common/ includes.
15458 * remote.c: Fix common/ includes.
15459 * remote-notif.h: Fix common/ includes.
15460 * remote-fileio.h: Fix common/ includes.
15461 * remote-fileio.c: Fix common/ includes.
15462 * regcache.h: Fix common/ includes.
15463 * regcache.c: Fix common/ includes.
15464 * record-btrace.c: Fix common/ includes.
15465 * python/python.c: Fix common/ includes.
15466 * python/py-type.c: Fix common/ includes.
15467 * python/py-inferior.c: Fix common/ includes.
15468 * progspace.h: Fix common/ includes.
15469 * producer.c: Fix common/ includes.
15470 * procfs.c: Fix common/ includes.
15471 * proc-api.c: Fix common/ includes.
15472 * printcmd.c: Fix common/ includes.
15473 * ppc-linux-nat.c: Fix common/ includes.
15474 * parser-defs.h: Fix common/ includes.
15475 * osdata.c: Fix common/ includes.
15476 * obsd-nat.c: Fix common/ includes.
15477 * nat/x86-linux.c: Fix common/ includes.
15478 * nat/x86-linux-dregs.c: Fix common/ includes.
15479 * nat/x86-dregs.h: Fix common/ includes.
15480 * nat/x86-dregs.c: Fix common/ includes.
15481 * nat/ppc-linux.c: Fix common/ includes.
15482 * nat/mips-linux-watch.h: Fix common/ includes.
15483 * nat/mips-linux-watch.c: Fix common/ includes.
15484 * nat/linux-waitpid.c: Fix common/ includes.
15485 * nat/linux-ptrace.h: Fix common/ includes.
15486 * nat/linux-ptrace.c: Fix common/ includes.
15487 * nat/linux-procfs.c: Fix common/ includes.
15488 * nat/linux-personality.c: Fix common/ includes.
15489 * nat/linux-osdata.c: Fix common/ includes.
15490 * nat/linux-namespaces.c: Fix common/ includes.
15491 * nat/linux-btrace.h: Fix common/ includes.
15492 * nat/linux-btrace.c: Fix common/ includes.
15493 * nat/fork-inferior.c: Fix common/ includes.
15494 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15495 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15496 * nat/aarch64-linux.c: Fix common/ includes.
15497 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15498 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15499 * namespace.h: Fix common/ includes.
15500 * mips-linux-tdep.c: Fix common/ includes.
15501 * minsyms.c: Fix common/ includes.
15502 * mi/mi-parse.h: Fix common/ includes.
15503 * mi/mi-main.c: Fix common/ includes.
15504 * mi/mi-cmd-env.c: Fix common/ includes.
15505 * memrange.h: Fix common/ includes.
15506 * memattr.c: Fix common/ includes.
15507 * maint.h: Fix common/ includes.
15508 * maint.c: Fix common/ includes.
15509 * main.c: Fix common/ includes.
15510 * machoread.c: Fix common/ includes.
15511 * location.c: Fix common/ includes.
15512 * linux-thread-db.c: Fix common/ includes.
15513 * linux-nat.c: Fix common/ includes.
15514 * linux-fork.c: Fix common/ includes.
15515 * inline-frame.c: Fix common/ includes.
15516 * infrun.c: Fix common/ includes.
15517 * inflow.c: Fix common/ includes.
15518 * inferior.h: Fix common/ includes.
15519 * inferior.c: Fix common/ includes.
15520 * infcmd.c: Fix common/ includes.
15521 * inf-ptrace.c: Fix common/ includes.
15522 * inf-child.c: Fix common/ includes.
15523 * ia64-linux-nat.c: Fix common/ includes.
15524 * i387-tdep.c: Fix common/ includes.
15525 * i386-tdep.c: Fix common/ includes.
15526 * i386-linux-tdep.c: Fix common/ includes.
15527 * i386-linux-nat.c: Fix common/ includes.
15528 * i386-go32-tdep.c: Fix common/ includes.
15529 * i386-fbsd-tdep.c: Fix common/ includes.
15530 * i386-fbsd-nat.c: Fix common/ includes.
15531 * guile/scm-type.c: Fix common/ includes.
15532 * guile/guile.c: Fix common/ includes.
15533 * go32-nat.c: Fix common/ includes.
15534 * gnu-nat.c: Fix common/ includes.
15535 * gdbthread.h: Fix common/ includes.
15536 * gdbarch-selftests.c: Fix common/ includes.
15537 * gdb_usleep.c: Fix common/ includes.
15538 * gdb_select.h: Fix common/ includes.
15539 * gdb_bfd.c: Fix common/ includes.
15540 * gcore.c: Fix common/ includes.
15541 * fork-child.c: Fix common/ includes.
15542 * findvar.c: Fix common/ includes.
15543 * fbsd-nat.c: Fix common/ includes.
15544 * event-top.c: Fix common/ includes.
15545 * event-loop.c: Fix common/ includes.
15546 * dwarf2read.c: Fix common/ includes.
15547 * dwarf2loc.c: Fix common/ includes.
15548 * dwarf2-frame.c: Fix common/ includes.
15549 * dwarf-index-cache.c: Fix common/ includes.
15550 * dtrace-probe.c: Fix common/ includes.
15551 * disasm-selftests.c: Fix common/ includes.
15552 * defs.h: Fix common/ includes.
15553 * csky-tdep.c: Fix common/ includes.
15554 * cp-valprint.c: Fix common/ includes.
15555 * cp-support.h: Fix common/ includes.
15556 * cp-support.c: Fix common/ includes.
15557 * corelow.c: Fix common/ includes.
15558 * completer.h: Fix common/ includes.
15559 * completer.c: Fix common/ includes.
15560 * compile/compile.c: Fix common/ includes.
15561 * compile/compile-loc2c.c: Fix common/ includes.
15562 * compile/compile-cplus-types.c: Fix common/ includes.
15563 * compile/compile-cplus-symbols.c: Fix common/ includes.
15564 * command.h: Fix common/ includes.
15565 * cli/cli-dump.c: Fix common/ includes.
15566 * cli/cli-cmds.c: Fix common/ includes.
15567 * charset.c: Fix common/ includes.
15568 * build-id.c: Fix common/ includes.
15569 * btrace.h: Fix common/ includes.
15570 * btrace.c: Fix common/ includes.
15571 * breakpoint.h: Fix common/ includes.
15572 * breakpoint.c: Fix common/ includes.
15573 * ax.h:
15574 (enum agent_op): Fix common/ includes.
15575 * ax-general.c (struct aop_map): Fix common/ includes.
15576 * ax-gdb.c: Fix common/ includes.
15577 * auxv.c: Fix common/ includes.
15578 * auto-load.c: Fix common/ includes.
15579 * arm-tdep.c: Fix common/ includes.
15580 * arch/riscv.c: Fix common/ includes.
15581 * arch/ppc-linux-common.c: Fix common/ includes.
15582 * arch/i386.c: Fix common/ includes.
15583 * arch/arm.c: Fix common/ includes.
15584 * arch/arm-linux.c: Fix common/ includes.
15585 * arch/arm-get-next-pcs.c: Fix common/ includes.
15586 * arch/amd64.c: Fix common/ includes.
15587 * arch/aarch64.c: Fix common/ includes.
15588 * arch/aarch64-insn.c: Fix common/ includes.
15589 * arch-utils.c: Fix common/ includes.
15590 * amd64-windows-tdep.c: Fix common/ includes.
15591 * amd64-tdep.c: Fix common/ includes.
15592 * amd64-sol2-tdep.c: Fix common/ includes.
15593 * amd64-obsd-tdep.c: Fix common/ includes.
15594 * amd64-nbsd-tdep.c: Fix common/ includes.
15595 * amd64-linux-tdep.c: Fix common/ includes.
15596 * amd64-linux-nat.c: Fix common/ includes.
15597 * amd64-fbsd-tdep.c: Fix common/ includes.
15598 * amd64-fbsd-nat.c: Fix common/ includes.
15599 * amd64-dicos-tdep.c: Fix common/ includes.
15600 * amd64-darwin-tdep.c: Fix common/ includes.
15601 * agent.c: Fix common/ includes.
15602 * ada-lang.h: Fix common/ includes.
15603 * ada-lang.c: Fix common/ includes.
15604 * aarch64-tdep.c: Fix common/ includes.
15605
2f5c153e
TT
156062019-01-25 Tom Tromey <tom@tromey.com>
15607
15608 * common/create-version.sh: Use common/version.h.
15609
adc6a863
PA
156102019-01-24 Pedro Alves <palves@redhat.com>
15611
15612 * infrun.c (signal_stop, signal_print, signal_program)
15613 (signal_catch, signal_pass): Now arrays instead of pointers.
15614 (update_signals_program_target, do_target_resume)
15615 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15616 * linux-nat.c (linux_nat_target::pass_signals)
15617 (linux_nat_target::create_inferior, linux_nat_target::attach):
15618 Adjust.
15619 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15620 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15621 * procfs.c (procfs_target::pass_signals): Adjust.
15622 * record-full.c (record_full_target::resume): Adjust.
15623 * remote.c (remote_target::pass_signals)
15624 (remote_target::program_signals): Adjust.
15625 * target-debug.h (target_debug_print_signals): Now takes a
15626 gdb::array_view as parameter. Adjust.
15627 * target.h (target_ops) <pass_signals, program_signals>: Replace
15628 pointer and length parameters with gdb::array_view.
15629 (target_pass_signals, target_program_signals): Likewise.
15630 * target-delegates.c: Regenerate.
15631
3046d67a
PA
156322019-01-24 Pedro Alves <palves@redhat.com>
15633
15634 * common/forward-scope-exit.h
15635 (forward_scope_exit::forward_scope_exit): Pass arguments to
15636 m_bind_function directly, instead of creating a std::bind and
15637 copying that.
15638
353229bf
AH
156392019-01-24 Alan Hayward <alan.hayward@arm.com>
15640
15641 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15642 for static members.
15643 (pass_in_v_vfp_candidate): Likewise.
15644
311dc83a
TT
156452019-01-23 Tom Tromey <tom@tromey.com>
15646 Pedro Alves <palves@redhat.com>
15647
15648 * regcache.c (class regcache_invalidator): Remove.
15649 (regcache::raw_write): Use make_scope_exit.
15650
296bd123
TT
156512019-01-23 Tom Tromey <tom@tromey.com>
15652
15653 * ui-out.h (class ui_out_emit_type): Update comment.
15654
979a0d13
TT
156552019-01-23 Tom Tromey <tom@tromey.com>
15656
15657 * infrun.c (fetch_inferior_event): Update comment.
15658
d238133d
TT
156592019-01-23 Tom Tromey <tom@tromey.com>
15660 Pedro Alves <palves@redhat.com>
15661
15662 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15663 parameter.
15664 (fetch_inferior_event): Use SCOPE_EXIT.
15665
15666
9885e6bb
TT
156672019-01-23 Tom Tromey <tom@tromey.com>
15668 Pedro Alves <palves@redhat.com>
15669
15670 * infrun.c (disable_thread_events): Delete.
15671 (stop_all_threads): Use SCOPE_EXIT.
15672
286526c1
TT
156732019-01-23 Tom Tromey <tom@tromey.com>
15674 Pedro Alves <palves@redhat.com>
15675
15676 * symfile.c: Include forward-scope-exit.h.
15677 (clear_symtab_users_cleanup): Replace forward declaration with
15678 a FORWARD_SCOPE_EXIT.
15679 (syms_from_objfile_1): Use the forward_scope_exit and
15680 gdb::optional instead of cleanup_function.
15681 (reread_symbols): Use the forward_scope_exit instead of
15682 cleanup_function.
15683 (clear_symtab_users_cleanup): Remove function.
15684
1db93f14
TT
156852019-01-23 Tom Tromey <tom@tromey.com>
15686 Pedro Alves <palves@redhat.com>
15687
15688 * linux-nat.c: Include scope-exit.h.
15689 (cleanup_target_stop): Remove.
15690 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15691 SCOPE_EXIT.
15692
2cc83d1e
TT
156932019-01-23 Tom Tromey <tom@tromey.com>
15694 Pedro Alves <palves@redhat.com>
15695
15696 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15697 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15698
694c6bf5
TT
156992019-01-23 Tom Tromey <tom@tromey.com>
15700 Andrew Burgess <andrew.burgess@embecosm.com>
15701 Pedro Alves <palves@redhat.com>
15702
15703 * infrun.c (fetch_inferior_event): Use scope_exit.
15704 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15705 * top.c (execute_command): Use scope_exit.
15706 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15707 * utils.c (do_bpstat_clear_actions_cleanup)
15708 (make_bpstat_clear_actions_cleanup): Remove.
15709
4c41382a
TT
157102019-01-23 Tom Tromey <tom@tromey.com>
15711 Pedro Alves <palves@redhat.com>
15712
15713 * infrun.c: Include "common/scope-exit.h"
15714 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15715 (wait_for_inferior): Use SCOPE_EXIT.
15716 (fetch_inferior_event): Use scope_exit.
15717
89f8fb50
TT
157182019-01-23 Tom Tromey <tom@tromey.com>
15719 Pedro Alves <palves@redhat.com>
15720
15721 * breakpoint.c (create_breakpoint): Remove cleanup.
15722
5419bdae
TT
157232019-01-23 Tom Tromey <tom@tromey.com>
15724 Andrew Burgess <andrew.burgess@embecosm.com>
15725 Pedro Alves <palves@redhat.com>
15726
e587ef42
PA
157272019-01-23 Pedro Alves <palves@redhat.com>
15728
15729 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15730
77f0e74c
PA
157312019-01-23 Pedro Alves <palves@redhat.com>
15732 Andrew Burgess <andrew.burgess@embecosm.com>
15733
15734 * gdbthread.h: Include "common/forward-scope-exit.h".
15735 (scoped_finish_thread_state): Redefine custom class in terms of
15736 forward_scope_exit.
15737
5b9b3e53
PA
157382019-01-23 Pedro Alves <palves@redhat.com>
15739 Andrew Burgess <andrew.burgess@embecosm.com>
15740
15741 * common/forward-scope-exit.h: New file.
15742
54b65c9b
PA
157432019-01-23 Pedro Alves <palves@redhat.com>
15744 Andrew Burgess <andrew.burgess@embecosm.com>
15745 Tom Tromey <tom@tromey.com>
15746
15747 * common/scope-exit.h: New file.
15748
cf08fb29
PA
157492019-01-23 Pedro Alves <palves@redhat.com>
15750
15751 * common/preprocessor.h (ESC): Rename to ...
15752 (ESC_PARENS): ... this.
15753 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15754 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15755
ae73e2e2
TT
157562019-01-23 Tom Tromey <tom@tromey.com>
15757
15758 * language.h (class scoped_switch_to_sym_language_if_auto):
15759 Initialize m_lang in both cases.
15760
6594e122
AH
157612019-01-23 Alan Hayward <alan.hayward@arm.com>
15762
15763 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15764 with XCNEW.
15765
a7c9855d
TT
157662019-01-22 Tom Tromey <tom@tromey.com>
15767
15768 * corelow.c: Do not include sys/file.h.
15769
93cc1d53
TT
157702019-01-22 Tom Tromey <tom@tromey.com>
15771
15772 * tui/tui-wingeneral.h: Include gdb_curses.h.
15773
38561778
TT
157742019-01-22 Tom Tromey <tom@tromey.com>
15775
15776 * source-cache.h (class source_cache) <get_source_lines,
15777 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15778
37b3ab5b
TT
157792019-01-22 Tom Tromey <tom@tromey.com>
15780
15781 * remote-fileio.h (struct remote_target): Declare.
15782
3fabc016
TT
157832019-01-22 Tom Tromey <tom@tromey.com>
15784
15785 * python/py-arch.c: Do not include py-ref.h.
15786 * python/py-bpevent.c: Do not include py-ref.h.
15787 * python/py-cmd.c: Do not include py-ref.h.
15788 * python/py-continueevent.c: Do not include py-ref.h.
15789 * python/py-event.h: Do not include py-ref.h.
15790 * python/py-evtregistry.c: Do not include py-ref.h.
15791 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15792 * python/py-frame.c: Do not include py-ref.h.
15793 * python/py-framefilter.c: Do not include py-ref.h.
15794 * python/py-function.c: Do not include py-ref.h.
15795 * python/py-infevents.c: Do not include py-ref.h.
15796 * python/py-linetable.c: Do not include py-ref.h.
15797 * python/py-objfile.c: Do not include py-ref.h.
15798 * python/py-param.c: Do not include py-ref.h.
15799 * python/py-prettyprint.c: Do not include py-ref.h.
15800 * python/py-progspace.c: Do not include py-ref.h.
15801 * python/py-symbol.c: Do not include py-ref.h.
15802 * python/py-symtab.c: Do not include py-ref.h.
15803 * python/py-type.c: Do not include py-ref.h.
15804 * python/py-unwind.c: Do not include py-ref.h.
15805 * python/py-utils.c: Do not include py-ref.h.
15806 * python/py-value.c: Do not include py-ref.h.
15807 * python/py-varobj.c: Do not include py-ref.h.
15808 * python/py-xmethods.c: Do not include py-ref.h.
15809 * python/python.c: Do not include py-ref.h.
15810 * varobj.c: Do not include py-ref.h.
15811
6b4d7774
TT
158122019-01-22 Tom Tromey <tom@tromey.com>
15813
15814 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15815 keyword for bcache.
15816
7af7e9b5
TT
158172019-01-22 Tom Tromey <tom@tromey.com>
15818
15819 * compile/compile-cplus-types.c: Remove a comment by #include.
15820
951d1049
TT
158212019-01-22 Tom Tromey <tom@tromey.com>
15822
15823 * compile/gcc-c-plugin.h: Include compile-internal.h.
15824
d65d5705
TT
158252019-01-22 Tom Tromey <tom@tromey.com>
15826
15827 * stabsread.c (EXTERN): Do not define.
15828 (symnum, next_symbol_text_func, processing_gcc_compilation)
15829 (within_function, global_sym_chain, global_stabs)
15830 (previous_stab_code, this_object_header_files)
15831 (n_this_object_header_files)
15832 (n_allocated_this_object_header_files): Define.
15833 * stabsread.h (EXTERN): Never define. Use "extern".
15834
b6fb1ee5
PW
158352019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15836
15837 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15838 history_value.
15839
be6d4f74
TT
158402019-01-21 Tom Tromey <tom@tromey.com>
15841
15842 * ui-out.c: Fix includes.
15843 * tui/tui-source.c: Fix includes.
15844 * target.c: Fix includes.
15845 * remote.c: Fix includes.
15846 * regcache.c: Fix includes.
15847 * python/py-block.c: Fix includes.
15848 * printcmd.c: Fix includes.
15849 * or1k-tdep.c: Fix includes.
15850 * mi/mi-main.c: Fix includes.
15851 * m32r-tdep.c: Fix includes.
15852 * csky-tdep.c: Fix includes.
15853 * compile/compile-cplus-types.c: Fix includes.
15854 * cli/cli-interp.c: Fix includes.
15855
73021deb
AH
158562019-01-21 Alan Hayward <alan.hayward@arm.com>
15857
15858 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15859 for padding.
15860
7932255d
TT
158612019-01-16 Tom Tromey <tom@tromey.com>
15862
15863 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15864 earlier.
15865 (struct objfile) <msymbols_range>: Move from top level.
15866 <msymbols>: New method.
15867 (class objfile_msymbols): Remove.
15868 * symtab.c (default_collect_symbol_completion_matches_break_on):
15869 Update.
15870 * symmisc.c (dump_msymbols): Update.
15871 * stabsread.c (scan_file_globals): Update.
15872 * objc-lang.c (info_selectors_command, info_classes_command)
15873 (find_methods): Update.
15874 * minsyms.c (find_solib_trampoline_target): Update.
15875 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15876 * coffread.c (coff_symfile_read): Update.
15877 * ada-lang.c (ada_lookup_simple_minsym)
15878 (ada_collect_symbol_completion_matches): Update.
15879
604b1bfb
TT
158802019-01-16 Tom Tromey <tom@tromey.com>
15881
15882 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15883 type. Remove no-argument constructor.
15884 <iterator::operator++>: Simplify.
15885 <begin>: Update.
15886 <end>: Use minimal_symbol_count.
15887
f252c6d5
TT
158882019-01-16 Tom Tromey <tom@tromey.com>
15889
15890 * objfiles.h (struct objfile) <psymtabs>: New method.
15891 (class objfile_psymtabs): Remove.
15892 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15893 typedef.
15894 <range>: New method.
15895 (require_partial_symbols): Change return type.
15896 * psymtab.c (require_partial_symbols)
15897 (psym_expand_symtabs_matching): Update.
15898 * mdebugread.c (parse_partial_symbols): Update.
15899 * dbxread.c (dbx_end_psymtab): Update.
15900
b669c953
TT
159012019-01-15 Tom Tromey <tom@tromey.com>
15902
15903 * symtab.c (lookup_objfile_from_block)
15904 (lookup_symbol_in_objfile_symtabs)
15905 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15906 (find_line_symtab, info_sources_command)
15907 (default_collect_symbol_completion_matches_break_on)
15908 (make_source_files_completion_list): Update.
15909 * symmisc.c (print_objfile_statistics, dump_objfile)
15910 (maintenance_print_symbols, maintenance_info_symtabs)
15911 (maintenance_check_symtabs, maintenance_info_line_tables):
15912 Update.
15913 * source.c (select_source_symtab)
15914 (forget_cached_source_info_for_objfile): Update.
15915 * objfiles.h (class objfile_compunits): Remove.
15916 (struct objfile) <compunits_range>: New typedef.
15917 (compunits): New method.
15918 * objfiles.c (objfile_relocate1): Update.
15919 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15920 * maint.c (count_symtabs_and_blocks): Update.
15921 * linespec.c (iterate_over_all_matching_symtabs): Update.
15922 * cp-support.c (add_symbol_overload_list_qualified): Update.
15923 * coffread.c (coff_symtab_read): Update.
15924 * ada-lang.c (add_nonlocal_symbols)
15925 (ada_collect_symbol_completion_matches)
15926 (ada_add_global_exceptions): Update.
15927
7e955d83
TT
159282019-01-15 Tom Tromey <tom@tromey.com>
15929
15930 * progspace.h (program_space) <objfiles_safe_range>: New
15931 typedef.
15932 <objfiles_safe>: New method.
15933 * objfiles.h (class all_objfiles_safe): Remove.
15934 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15935 * jit.c (jit_inferior_exit_hook): Update.
15936
2030c079
TT
159372019-01-17 Tom Tromey <tom@tromey.com>
15938
15939 * progspace.h (program_space) <objfiles_range>: New typedef.
15940 <objfiles>: New method.
15941 <objfiles_head>: Rename from objfiles.
15942 (object_files): Update.
15943 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15944 * guile/scm-pretty-print.c
15945 (ppscm_find_pretty_printer_from_objfiles): Update.
15946 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15947 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15948 Update.
15949 * python/py-progspace.c (pspy_get_objfiles): Update.
15950 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15951 Update.
15952 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15953 (objfpy_lookup_objfile_by_build_id): Update.
15954 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15955 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15956 Update.
15957 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15958 (expand_symtab_containing_pc, lookup_objfile_from_block)
15959 (lookup_static_symbol, basic_lookup_transparent_type)
15960 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15961 (find_line_symtab, info_sources_command)
15962 (default_collect_symbol_completion_matches_break_on)
15963 (make_source_files_completion_list, find_main_name): Update.
15964 * symmisc.c (print_symbol_bcache_statistics)
15965 (print_objfile_statistics, maintenance_print_symbols)
15966 (maintenance_print_msymbols, maintenance_print_objfiles)
15967 (maintenance_info_symtabs, maintenance_check_symtabs)
15968 (maintenance_expand_symtabs, maintenance_info_line_tables):
15969 Update.
15970 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15971 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15972 (map_overlay_command, unmap_overlay_command)
15973 (simple_overlay_update, expand_symtabs_matching)
15974 (map_symbol_filenames): Update.
15975 * symfile-debug.c (set_debug_symfile): Update.
15976 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15977 Update.
15978 * source.c (select_source_symtab, forget_cached_source_info):
15979 Update.
15980 * solib.c (solib_read_symbols): Update.
15981 * solib-spu.c (append_ocl_sos): Update.
15982 * psymtab.c (maintenance_print_psymbols)
15983 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15984 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15985 * printcmd.c (info_symbol_command): Update.
15986 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15987 Update.
15988 * objfiles.h (class all_objfiles): Remove.
15989 * objfiles.c (have_partial_symbols, have_full_symbols)
15990 (have_minimal_symbols, qsort_cmp, update_section_map)
15991 (shared_objfile_contains_address_p)
15992 (default_iterate_over_objfiles_in_search_order): Update.
15993 * objc-lang.c (info_selectors_command, info_classes_command)
15994 (find_methods): Update.
15995 * minsyms.c (find_solib_trampoline_target): Update.
15996 * maint.c (maintenance_info_sections)
15997 (maintenance_translate_address, count_symtabs_and_blocks):
15998 Update.
15999 * main.c (captured_main_1): Update.
16000 * linux-thread-db.c (try_thread_db_load_from_pdir)
16001 (has_libpthread): Update.
16002 * linespec.c (iterate_over_all_matching_symtabs)
16003 (search_minsyms_for_name): Update.
16004 * jit.c (jit_find_objf_with_entry_addr): Update.
16005 * hppa-tdep.c (find_unwind_entry)
16006 (hppa_lookup_stub_minimal_symbol): Update.
16007 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16008 Update.
16009 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16010 (elf_gnu_ifunc_resolve_by_got): Update.
16011 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16012 * dwarf-index-write.c (save_gdb_index_command): Update.
16013 * cp-support.c (add_symbol_overload_list_qualified): Update.
16014 * breakpoint.c (create_overlay_event_breakpoint)
16015 (create_longjmp_master_breakpoint)
16016 (create_std_terminate_master_breakpoint)
16017 (create_exception_master_breakpoint): Update.
16018 * blockframe.c (find_pc_partial_function): Update.
16019 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16020 (ada_collect_symbol_completion_matches)
16021 (ada_add_global_exceptions): Update.
16022
776489e0
TT
160232019-01-17 Tom Tromey <tom@tromey.com>
16024
16025 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16026 declare VEC.
16027 (solib_target_parse_libraries): Change return type.
16028 (library_list_start_segment, library_list_start_section)
16029 (library_list_end_library, library_list_start_library); Update.
16030 (solib_target_free_library_list): Remove.
16031 (solib_target_parse_libraries): Remove cleanup. Change return
16032 type.
16033 (solib_target_current_sos): Update.
16034
6471e7d2
TT
160352019-01-17 Tom Tromey <tromey@bapiya>
16036
16037 * valprint.c: Replace "the the" with "the".
16038 * symtab.c: Replace "the the" with "the".
16039 * solib.c: Replace "the the" with "the".
16040 * solib-dsbt.c: Replace "the the" with "the".
16041 * linespec.c: Replace "the the" with "the".
16042 * dwarf2loc.h: Replace "the the" with "the".
16043 * amd64-windows-tdep.c: Replace "the the" with "the".
16044 * aarch64-tdep.c: Replace "the the" with "the".
16045
c24bdb02
KS
160462019-01-16 Keith Seitz <keiths@redhat.com>
16047
16048 PR gdb/23773
16049 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16050 <builder>: Rename to ..
16051 <m_builder>: ... this and make private.
16052 (dwarf2_cu::get_builder): New method. Change all users of
16053 `builder' to use this method.
16054 (dwarf2_start_symtab): Move to ...
16055 (dwarf2_cu::start_symtab): ... here. Update all callers
16056 (setup_type_unit_groups): Move to ...
16057 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16058 callers.
16059 (dwarf2_cu::reset_builder): New method.
16060 (process_full_compunit, process_full_type_unit): Use
16061 dwarf2_cu::reset_builder.
16062 (follow_die_offset): Record the ancestor CU if it is different
16063 from the followed DIE's CU.
16064 (follow_die_sig_1): Likewise.
16065
8d64371b
TT
160662019-01-15 Tom Tromey <tom@tromey.com>
16067
16068 * remote.c (class remote_state) <buf>: Now a char_vector.
16069 <buf_size>: Remove.
16070 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16071 parameter.
16072 (remote_target::getpkt_or_notif_sane_1)
16073 (remote_target::getpkt_sane)
16074 (remote_target::getpkt_or_notif_sane): Likewise.
16075 (class remote_target) <putpkt>: New overload.
16076 (remote_target::read_frame): Change type of "buf_p". Remove
16077 sizeof_p parameter.
16078 (packet_ok): New overload.
16079 (packet_check_result): New overload.
16080 Update all uses.
16081
bb277751
TT
160822019-01-14 Tom Tromey <tom@tromey.com>
16083
16084 * remote-notif.c (handle_notification, remote_notif_ack)
16085 (remote_notif_parse): Make "buf" const.
16086 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16087 const.
16088 (remote_notif_parse, remote_notif_ack, handle_notification):
16089 Likewise.
16090 * remote.c (remote_notif_stop_parse): Make "buf" const.
16091 (remote_target::remote_parse_stop_reply): Make "buf" const.
16092 (remote_notif_stop_ack): Make "buf" const.
16093
05be00a8
TT
160942019-01-14 Tom Tromey <tom@tromey.com>
16095
16096 * remote.c (remote_console_output): Make parameter const.
16097
491adeca
TT
160982019-01-14 Tom Tromey <tom@tromey.com>
16099
16100 * target-debug.h (target_debug_print_signals): Constify.
16101 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16102 * procfs.c (procfs_target::pass_signals): Update.
16103 * linux-nat.c (linux_nat_target::pass_signals): Update.
16104 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16105 * target-delegates.c: Rebuild.
16106 * remote.c (remote_target::program_signals): Update.
16107 (remote_target::pass_signals): Update.
16108 * target.c (target_pass_signals): Constify argument.
16109 (target_program_signals): Likewise.
16110 * target.h (struct target_ops) <pass_signals, program_signals>:
16111 Constify argument.
16112 (target_pass_signals, target_program_signals): Constify argument.
16113
bbd94648
TT
161142019-01-14 Tom Tromey <tom@tromey.com>
16115
16116 PR tui/28819:
16117 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16118
6f072a10
PFC
161192019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16120
16121 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16122 field.
16123 * rs6000-tdep.c: Include reggroups.h.
16124 (IS_V_ALIAS_PSEUDOREG): Define.
16125 (rs6000_register_name): Return names for the "vX" aliases.
16126 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16127 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16128 aliases. Call default_register_reggroup_p for all other
16129 pseudo-registers.
16130 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16131 New functions.
16132 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16133 Handle "vX" aliases.
16134 (v_alias_pseudo_register_collect): New function.
16135 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16136 (rs6000_gdbarch_init): Initialize "vX" aliases as
16137 pseudo-registers. Restore registration of
16138 rs6000_pseudo_register_reggroup_p with
16139 set_tdesc_pseudo_register_reggroup_p.
16140
1a782351
MF
161412019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16142
16143 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16144 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16145 set_gdbarch_num_pseudo_regs.
16146
d73cff18
PW
161472019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16148
16149 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16150 Remove arg prefixname, add do_set and do_show.
16151 Add member functions set_list and show_list.
16152 * cli/cli-style.c (class cli_style_option): Update accordingly.
16153 (style_set_list): Move to file scope.
16154 (style_show_list): Likewise.
16155 (set_style): Call help_list.
16156 (show_style): Call cmd_show_list.
16157 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16158 Update to use the new macro.
16159
60a90376
JB
161602019-10-12 Joel Brobecker <brobecker@adacore.com>
16161
16162 * ada-lang.c (_initialize_ada_language): Expand the help text
16163 for the "catch exception" command.
16164
9d7c67bf
PW
161652019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16166
16167 * symtab.c (matching_obj_sections): Initialize obj,
16168 declare it closer to its usage.
16169
7cf47dc4
TT
161702019-01-10 Tom Tromey <tom@tromey.com>
16171
16172 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16173 (basic_inf_threads_range): Remove.
16174 (inf_threads_range, inf_non_exited_threads_range)
16175 (safe_inf_threads_range): Use next_adapter.
16176
d3cb6808
KS
161772019-01-10 Keith Seitz <keiths@redhat.com>
16178
16179 PR gdb/23712
16180 PR symtab/23010
16181 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16182 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16183
63a20375
KS
161842019-01-10 Keith Seitz <keiths@redhat.com>
16185
16186 PR gdb/23712
16187 PR symtab/23010
16188 * dictionary.c (pending_to_vector): Remove.
16189 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16190 Remove _1 suffix, replacing functions of the same name. Update
16191 all callers.
16192 (dict_create_hashed, dict_create_hashed_expandable)
16193 (dict_create_linear, dict_create_linear_expandable, dict_free)
16194 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16195 Make functions static.
16196
b026f593
KS
161972019-01-10 Keith Seitz <keiths@redhat.com>
16198
16199 PR gdb/23712
16200 PR symtab/23010
16201 * dictionary.h (struct dictionary): Replace declaration with
16202 multidictionary.
16203 (dict_create_hashed, dict_create_hashed_expandable)
16204 (dict_create_linear, dict_create_linear_expandable)
16205 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16206 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16207 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16208 taking multidictionary argument.
16209 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16210 * block.h (struct block) <dict>: Change to multidictionary
16211 and rename `multidict'.
16212 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16213 symmisc.c: Update all dictionary references to multidictionary.
16214
c7748ee9
KS
162152019-01-10 Keith Seitz <keiths@redhat.com>
16216
16217 PR gdb/23712
16218 PR symtab/23010
16219 * dictionary.c: Include unordered_map.
16220 (pending_to_vector): New function.
16221 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16222 Rewrite the non-"_1" functions to take vector instead
16223 of linked list.
16224 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16225 "new" _1 versions of the same name.
16226 (multidictionary): Define.
16227 (std::hash<enum language): New definition.
16228 (collate_pending_symbols_by_language, mdict_create_hashed)
16229 (mdict_create_hashed_expandable, mdict_create_linear)
16230 (mdict_create_linear_expandable, mdict_free)
16231 (find_language_dictionary, create_new_language_dictionary)
16232 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16233 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16234 (mdict_size, mdict_empty): New functions.
16235 * dictionary.h (mdict_iterator): Define.
16236
67aa1f3c
PA
162372019-01-10 Pedro Alves <palves@redhat.com>
16238
16239 * breakpoint.c (read_uploaded_action)
16240 (create_tracepoint_from_upload): Adjust to use
16241 gdb::unique_xmalloc_ptr.
16242 * ctf.c (ctf_write_uploaded_tp):
16243 (SET_ARRAY_FIELD): Use emplace_back.
16244 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16245 * tracefile-tfile.c (tfile_write_uploaded_tp):
16246 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16247 gdb::unique_xmalloc_ptr.
16248 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16249 at_string, cond_string, cmd_strings>: Replace char pointers
16250 with gdb::unique_xmalloc_ptr.
16251
2f667667
PA
162522019-01-10 Pedro Alves <palves@redhat.com>
16253
16254 * solib-target.c (library_list_start_library): Don't xstrdup name.
16255
36cb7237
PA
162562019-01-10 Pedro Alves <palves@redhat.com>
16257
16258 * mdebugread.c (parse_partial_symbols): Use
16259 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16260
da584958
AB
162612019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16262
16263 * linux-fork.c (scoped_switch_fork_info)
16264 <~scoped_switch_fork_info>: Fix incorrect variable name.
16265
1ef8573c
AB
162662019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16267
16268 * linux-fork.c (scoped_switch_fork_info)
16269 <scoped_switch_fork_info>: Make explicit.
16270 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16271
8d7bcccb
TT
162722019-01-10 Tom Tromey <tom@tromey.com>
16273
16274 * objfiles.h (objfile::reset_psymtabs): Update.
16275 * objfiles.c (objfile::objfile): Update.
16276 * psymtab.h (psymtab_storage::obstack): Update.
16277 (psymtab_storage::m_obstack): Use gdb::optional.
16278 (class psymtab_storage): Update comment. Remove objfile
16279 parameter.
16280 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16281
b596a3c7
TT
162822019-01-10 Tom Tromey <tom@tromey.com>
16283
16284 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16285 <free_psymtabs>: Now private.
16286 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16287 (allocate_psymtab): Use new method.
16288
a9342b62
TT
162892019-01-10 Tom Tromey <tom@tromey.com>
16290
16291 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16292 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16293 * mdebugread.c (parse_partial_symbols): Use
16294 allocate_dependencies.
16295 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16296 allocate_dependencies.
16297 (process_psymtab_comp_unit_reader)
16298 (build_type_psymtab_dependencies): Likewise.
16299 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16300
5af70966
TT
163012019-01-10 Tom Tromey <tom@tromey.com>
16302
16303 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16304 PSYMBOL_SET_LANGUAGE.
16305 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16306
5923a04c
TT
163072019-01-10 Tom Tromey <tom@tromey.com>
16308
16309 * psymtab.h (psymtab_storage::obstack): New method.
16310 <m_obstack>: Rename from obstack; now private.
16311 * psymtab.c (psymtab_storage): Update.
16312 * dwarf2read.c (create_addrmap_from_index)
16313 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16314 Update.
16315
6d6a12bf
TT
163162019-01-10 Tom Tromey <tom@tromey.com>
16317
16318 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16319 * objfiles.h (objfile::reset_psymtabs): New method.
16320
d320c2b5
TT
163212019-01-10 Tom Tromey <tom@tromey.com>
16322
16323 * symmisc.c (print_symbol_bcache_statistics): Update.
16324 (print_objfile_statistics): Update.
16325 * symfile.c (reread_symbols): Update.
16326 * psymtab.h (class psymtab_storage): New.
16327 * psymtab.c (psymtab_storage): New constructor.
16328 (~psymtab_storage): New destructor.
16329 (require_partial_symbols): Update.
16330 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16331 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16332 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16333 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16334 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16335 (start_psymtab_common, end_psymtab_common)
16336 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16337 (allocate_psymtab): Update.
16338 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16339 Update.
16340 (dump_psymtab_addrmap, maintenance_print_psymbols)
16341 (maintenance_check_psymtabs): Update.
16342 (class objfile_psymtabs): Move to objfiles.h.
16343 * psympriv.h (discard_psymtab): Now inline.
16344 (psymtab_discarder::psymtab_discarder): Update.
16345 (psymtab_discarder::~psymtab_discarder): Update.
16346 (ALL_OBJFILE_PSYMTABS): Rewrite.
16347 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16348 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16349 Remove fields.
16350 <partial_symtabs>: New field.
16351 (class objfile_psymtabs): Move from psymtab.h. Update.
16352 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16353 psymbol_cache.
16354 (objfile::~objfile): Don't destroy psymbol_cache.
16355 * mdebugread.c (parse_partial_symbols): Update.
16356 * dwarf2read.c (create_addrmap_from_index)
16357 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16358 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16359 (add_partial_subprogram, dwarf2_ranges_read): Update.
16360 * dwarf-index-write.c (write_address_map)
16361 (write_one_signatured_type, recursively_write_psymbols)
16362 (class debug_names, class debug_names, write_psymtabs_to_index):
16363 Update.
16364
1d94a5a3
TT
163652019-01-10 Tom Tromey <tom@tromey.com>
16366
16367 * symtab.h (SYMBOL_SET_NAMES): Update.
16368 (symbol_set_names): Update.
16369 (MSYMBOL_SET_NAMES): Update.
16370 * symtab.c (symbol_set_names): Change argument to be an
16371 objfile_per_bfd_storage.
16372 * psymtab.c (add_psymbol_to_bcache): Update.
16373 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16374
0f14768a
TT
163752019-01-10 Tom Tromey <tom@tromey.com>
16376
16377 * symtab.c (create_demangled_names_hash): Change argument to be an
16378 objfile_per_bfd_storage.
16379 (symbol_set_names): Update.
16380
6eee24ce
TT
163812019-01-10 Tom Tromey <tom@tromey.com>
16382
16383 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16384 init_psymbol_list.
16385 * psymtab.c (init_psymbol_list): Do nothing if already called.
16386 * psympriv.h (init_psymbol_list): Add comment.
16387 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16388 init_psymbol_list.
16389 * dbxread.c (dbx_symfile_read): Unconditionally call
16390 init_psymbol_list.
16391
75aedd27
TT
163922019-01-10 Tom Tromey <tom@tromey.com>
16393
16394 * xcoffread.c (scan_xcoff_symtab): Update.
16395 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16396 "where".
16397 * mdebugread.c (parse_partial_symbols)
16398 (handle_psymbol_enumerators): Update.
16399 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16400 * dbxread.c (read_dbx_symtab): Update.
16401 * psympriv.h (psymbol_placement): New enum.
16402 (add_psymbol_to_list): Update.
16403
939652a5
TT
164042019-01-10 Tom Tromey <tom@tromey.com>
16405
16406 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16407 static_psymbols parameters.
16408 (scan_xcoff_symtab): Update.
16409 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16410 static_psymbols parameters.
16411 * psympriv.h (start_psymtab_common): Update.
16412 * mdebugread.c (parse_partial_symbols): Update.
16413 * dwarf2read.c (create_partial_symtab): Update.
16414 * dbxread.c (read_dbx_symtab): Update.
16415 (start_psymtab): Remove global_psymbols and static_psymbols
16416 parameters.
16417
baa62830
TT
164182019-01-10 Tom Tromey <tom@tromey.com>
16419
16420 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16421 * psymtab.c (allocate_psymtab): Add comment.
16422 * psympriv.h (allocate_psymtab): Add comment.
16423 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16424 initializations.
16425 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16426
0e8f53ba
TT
164272019-01-10 Tom Tromey <tom@tromey.com>
16428
16429 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16430 Don't declare.
16431 * mipsread.c: Include mdebugread.h.
16432 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16433 Declare.
16434 * elfread.c: Include mdebugread.h.
16435
b22a7c6a
TT
164362019-01-09 Tom Tromey <tom@tromey.com>
16437
16438 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16439 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16440 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16441 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16442 (psym_lookup_symbol, psym_find_last_source_symtab)
16443 (psym_forget_cached_source_info, psym_print_stats)
16444 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16445 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16446 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16447 (psym_find_compunit_symtab_by_address)
16448 (maintenance_print_psymbols, maintenance_info_psymtabs)
16449 (maintenance_check_psymtabs): Use ranged for.
16450 * psymtab.h (class objfile_psymtabs): New.
16451 (require_partial_symbols): Return objfile_psymtabs.
16452 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16453
3b9d3ac2
TT
164542019-01-09 Tom Tromey <tom@tromey.com>
16455
16456 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16457 (find_pc_mapped_section, list_overlays_command)
16458 (map_overlay_command, unmap_overlay_command)
16459 (simple_overlay_update): Use all_objfiles.
16460 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16461 * printcmd.c (info_symbol_command): Use all_objfiles.
16462 * objfiles.h (ALL_OBJSECTIONS): Remove.
16463 * maint.c (maintenance_translate_address): Use all_objfiles.
16464 * gcore.c (gcore_create_callback): Use all_objfiles.
16465 (objfile_find_memory_regions): Likewise.
16466
8b31193a
TT
164672019-01-09 Tom Tromey <tom@tromey.com>
16468
16469 * symtab.c (find_line_symtab, info_sources_command)
16470 (make_source_files_completion_list): Use objfile_compunits.
16471 * source.c (select_source_symtab): Use objfile_compunits.
16472 * objfiles.h (struct objfile): Update comment.
16473 (ALL_OBJFILES): Remove.
16474 (ALL_FILETABS): Remove.
16475 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16476 objfile_compunits.
16477
d5da8b3c
TT
164782019-01-09 Tom Tromey <tom@tromey.com>
16479
16480 * symmisc.c (print_objfile_statistics, dump_objfile)
16481 (maintenance_print_symbols): Use compunit_filetabs.
16482 * source.c (forget_cached_source_info_for_objfile): Use
16483 compunit_filetabs.
16484 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16485 (ALL_FILETABS): Use compunit_filetabs.
16486 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16487 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16488
5accd1a0
TT
164892019-01-09 Tom Tromey <tom@tromey.com>
16490
16491 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16492 (compunit_filetabs): New.
16493 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16494 compunit_filetabs.
16495 (info_sources_command, make_source_files_completion_list): Remove
16496 declaration.
16497 * symmisc.c (print_objfile_statistics, dump_objfile)
16498 (maintenance_print_symbols): Remove declaration.
16499 (maintenance_info_symtabs): Use compunit_filetabs.
16500 (maintenance_info_line_tables): Likewise.
16501 * source.c (select_source_symtab): Change local variable name.
16502 (forget_cached_source_info_for_objfile): Remove declaration.
16503 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16504 * objfiles.c (objfile_relocate1): Remove declaration.
16505 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16506 declaration.
16507 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16508 * coffread.c (coff_symtab_read): Remove declaration.
16509 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16510 compunit_filetabs.
16511
d8aeb77f
TT
165122019-01-09 Tom Tromey <tom@tromey.com>
16513
16514 * symtab.c (lookup_objfile_from_block)
16515 (find_pc_sect_compunit_symtab, search_symbols)
16516 (default_collect_symbol_completion_matches_break_on): Use
16517 objfile_compunits.
16518 * objfiles.h (ALL_COMPUNITS): Remove.
16519 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16520 * cp-support.c (add_symbol_overload_list_qualified): Use
16521 objfile_compunits.
16522 * ada-lang.c (ada_collect_symbol_completion_matches)
16523 (ada_add_global_exceptions): Use objfile_compunits.
16524
592553c4
TT
165252019-01-09 Tom Tromey <tom@tromey.com>
16526
16527 * source.c (select_source_symtab)
16528 (forget_cached_source_info_for_objfile): Remove declaration.
16529 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16530 declaration.
16531 * maint.c (count_symtabs_and_blocks): Remove declaration.
16532 * cp-support.c (add_symbol_overload_list_qualified): Remove
16533 declaration.
16534 * coffread.c (coff_symtab_read): Remove declaration.
16535 * symtab.c (lookup_symbol_in_objfile_symtabs)
16536 (basic_lookup_transparent_type_1): Use objfile_compunits.
16537 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16538 (info_sources_command, search_symbols)
16539 (default_collect_symbol_completion_matches_break_on)
16540 (make_source_files_completion_list): Remove declaration.
16541 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16542 (ada_collect_symbol_completion_matches)
16543 (ada_add_global_exceptions): Remove declaration.
16544 * linespec.c (iterate_over_all_matching_symtabs): Use
16545 objfile_compunits.
16546 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16547 (class objfile_compunits): New.
16548 (ALL_COMPUNITS): Use objfile_compunits.
16549 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16550 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16551 objfile_compunits.
16552 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16553
5325b9bf
TT
165542019-01-09 Tom Tromey <tom@tromey.com>
16555
16556 * symtab.c (search_symbols)
16557 (default_collect_symbol_completion_matches_break_on): Use
16558 objfile_msymbols.
16559 * ada-lang.c (ada_lookup_simple_minsym)
16560 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16561 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16562 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16563 objfile_msymbols.
16564 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16565 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16566 * objc-lang.c (find_methods): Use objfile_msymbols.
16567 (info_selectors_command, info_classes_command): Likewise.
16568 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16569 * objfiles.h (class objfile_msymbols): New.
16570 (ALL_OBJFILE_MSYMBOLS): Remove.
16571 (ALL_MSYMBOLS): Remove.
16572
cac85af2
TT
165732019-01-09 Tom Tromey <tom@tromey.com>
16574
16575 * common/next-iterator.h (next_adapter): Add Iterator template
16576 parameter.
16577 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16578 (class all_objfiles_safe): New.
16579 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16580 * objfiles.c (put_objfile_before): Update comment.
16581 (add_separate_debug_objfile): Likewise.
16582 (free_all_objfiles): Use all_objfiles_safe.
16583 (objfile_purge_solibs): Likewise.
16584
aed57c53
TT
165852019-01-09 Tom Tromey <tom@tromey.com>
16586
16587 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16588 (expand_symtab_containing_pc, lookup_static_symbol)
16589 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16590 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16591 all_objfiles.
16592 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16593 * breakpoint.c (create_overlay_event_breakpoint)
16594 (create_longjmp_master_breakpoint)
16595 (create_std_terminate_master_breakpoint)
16596 (create_exception_master_breakpoint): Use all_objfiles.
16597 * linux-thread-db.c (try_thread_db_load_from_pdir)
16598 (has_libpthread): Use all_objfiles.
16599 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16600 * linespec.c (iterate_over_all_matching_symtabs)
16601 (search_minsyms_for_name): Use all_objfiles.
16602 * maint.c (maintenance_info_sections): Use all_objfiles.
16603 * main.c (captured_main_1): Use all_objfiles.
16604 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16605 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16606 * guile/scm-pretty-print.c
16607 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16608 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16609 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16610 (maintenance_print_msymbols): Use all_objfiles.
16611 * source.c (select_source_symtab): Use all_objfiles.
16612 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16613 * symfile.c (remove_symbol_file_command)
16614 (expand_symtabs_matching, map_symbol_filenames): Use
16615 all_objfiles.
16616 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16617 all_objfiles.
16618 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16619 * objc-lang.c (find_methods): Use all_objfiles.
16620 * objfiles.c (have_partial_symbols, have_full_symbols)
16621 (have_minimal_symbols, qsort_cmp)
16622 (default_iterate_over_objfiles_in_search_order): Use
16623 all_objfiles.
16624 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16625 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16626 (maintenance_check_psymtabs): Use all_objfiles.
16627 (ALL_PSYMTABS): Remove.
16628 * compile/compile-object-run.c (do_module_cleanup): Use
16629 all_objfiles.
16630 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16631 * cp-support.c (add_symbol_overload_list_qualified): Use
16632 all_objfiles.
16633 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16634 Use all_objfiles.
16635 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16636 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16637 all_objfiles.
16638 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16639 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16640 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16641 Uses all_objfiles.
16642 * solib.c (solib_read_symbols): Use all_objfiles
16643
99d89cde
TT
166442019-01-09 Tom Tromey <tom@tromey.com>
16645
16646 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16647 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16648 all_objfiles.
16649 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16650 * symmisc.c (print_symbol_bcache_statistics)
16651 (print_objfile_statistics, maintenance_print_objfiles)
16652 (maintenance_info_symtabs, maintenance_check_symtabs)
16653 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16654 all_objfiles.
16655 * source.c (forget_cached_source_info): Use all_objfiles.
16656 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16657 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16658 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16659 * objfiles.c (update_section_map): Use all_objfiles.
16660 (shared_objfile_contains_address_p): Likewise.
16661 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16662 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16663
21708325
TT
166642019-01-09 Tom Tromey <tom@tromey.com>
16665
16666 * common/next-iterator.h: New file.
16667 * objfiles.h (class all_objfiles): New.
16668 (struct objfile_iterator): New.
16669
669e09f6
PW
166702019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16671
16672 * NEWS: Move the description of the changed "frame", "select-frame",
16673 and "info frame" commands to the Changed commands section.
16674
041be526
SM
166752019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16676
16677 * gdbtypes.c (check_stub_method_group): Remove handling of old
16678 mangling schemes.
16679 * linespec.c (find_methods): Likewise.
16680 * stabsread.c (read_member_functions): Likewise.
16681 * valops.c (search_struct_method): Likewise.
16682 (value_struct_elt_for_reference): Likewise.
16683 * NEWS: Mention this change.
16684
0e2a2133
AB
166852019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16686
16687 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16688 print_source_lines.
16689 * source.c (print_source_lines_base): Update line number check.
16690 (print_source_lines): New function.
16691 (source_lines_range::source_lines_range): New function.
16692 * source.h (class source_lines_range): New class.
16693 (print_source_lines): New declaration.
16694
1055a3b4
PW
166952019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16696
16697 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16698
cfeadda5
TT
166992019-01-08 Tom Tromey <tom@tromey.com>
16700 Simon Marchi <simon.marchi@ericsson.com>
16701
16702 PR gdb/24060
16703 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16704 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16705 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16706 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16707 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16708 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16709
583068ca
AB
167102019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16711
16712 * source.c (select_source_symtab): Move header comment to
16713 declaration in source.h.
16714 (forget_cached_source_info_for_objfile): Likewise.
16715 (forget_cached_source_info): Likewise.
16716 (identify_source_line): Likewise.
16717 * source.h (identify_source_line): Move declaration from symtab.h
16718 and add comment from source.c
16719 (print_source_lines): Likewise.
16720 (forget_cached_source_info_for_objfile): Likewise.
16721 (forget_cached_source_info): Likewise.
16722 (select_source_symtab): Likewise.
16723 (enum print_source_lines_flag): Move definition from symtab.h.
16724 * symtab.h (identify_source_line): Move declaration to source.h.
16725 (print_source_lines): Likewise.
16726 (forget_cached_source_info_for_objfile): Likewise.
16727 (forget_cached_source_info): Likewise.
16728 (select_source_symtab): Likewise.
16729 (enum print_source_lines_flag): Move definition to source.h.
16730 * tui/tui-hooks.c: Add 'source.h' include.
16731
ec98a4ad
AB
167322019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16733
16734 * source.c (print_source_lines_base): Handle requests to print
16735 reverse line number sequences, and guard against empty lines
16736 string.
16737
62ea19c1
AB
167382019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16739
16740 * source.c (print_source_lines_base): Fix skip of '\r' if next
16741 character is '\n'.
16742
9d30e1fd
TT
167432019-01-06 Tom Tromey <tom@tromey.com>
16744
16745 * c-exp.y (struct c_parse_state) <macro_original_text,
16746 expansion_obstack>: New member.
16747 (macro_original_text, expansion_obstack): Remove globals.
16748 (scan_macro_expansion, scanning_macro_expansion)
16749 (finished_macro_expansion): Update.
16750 (scan_macro_cleanup): Remove.
16751 (yylex, c_parse): Update.
16752
c65bac38
TT
167532019-01-06 Tom Tromey <tom@tromey.com>
16754
16755 * c-exp.y (struct c_parse_state) <strings>: New member.
16756 (operator_stoken): Update.
16757
02e12e38
TT
167582019-01-06 Tom Tromey <tom@tromey.com>
16759
16760 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16761 (union type_stack_elt) <typelist_val>: Now a pointer to
16762 std::vector.
16763 (type_stack_cleanup): Don't declare.
16764 (push_typelist): Update.
16765 * parse.c (pop_typelist): Return a std::vector.
16766 (push_typelist): Take a std::vector.
16767 (follow_types): Update. Do not free args.
16768 (type_stack_cleanup): Remove.
16769 * c-exp.y (struct c_parse_state): New.
16770 (cpstate): New global.
16771 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16772 (nonempty_typelist): Update.
16773 (func_mod): Create a new vector.
16774 (c_parse): Create a c_parse_state.
16775 (check_parameter_typelist): Do not delete params.
16776 (function_method): Update. Do not delete type_list.
16777
f097f5ad
TT
167782019-01-06 Tom Tromey <tom@tromey.com>
16779
16780 PR gdb/28155:
16781 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16782 check_typedef.
16783 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16784 (print_return_value): Likewise.
16785
d2adf9f1
TT
167862019-01-05 Tom Tromey <tom@tromey.com>
16787
16788 * contrib/cleanup_check.py: Remove.
16789 * contrib/gcc-with-excheck: Remove.
16790 * contrib/exsummary.py: Remove.
16791 * contrib/excheck.py: Remove.
16792
2eab46b1
JB
167932019-01-05 Joel Brobecker <brobecker@adacore.com>
16794
16795 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16796 NULL. Initialize tpprev to NULL instead of assigning it
16797 to NULL on the next statement.
16798 * windows-nat.c (windows_delete_thread): Remove check for
16799 main_thread_id before printing thread exit notifications.
16800 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16801 Remove thread ID check against main_thread_id.
16802 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16803 windows_delete_thread.
16804 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16805
48c5e7e2
TT
168062019-01-04 Tom Tromey <tom@tromey.com>
16807
16808 * compile/compile.c (_initialize_compile): Use upper case for
16809 metasyntactic variables.
16810 * symmisc.c (_initialize_symmisc): Use upper case for
16811 metasyntactic variables.
16812 * psymtab.c (_initialize_psymtab): Use upper case for
16813 metasyntactic variables.
16814 * demangle.c (demangle_command): Use upper case for metasyntactic
16815 variables.
16816 (_initialize_demangler): Likewise.
16817 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16818 variables.
16819
986041cd
TT
168202019-01-03 Tom Tromey <tom@tromey.com>
16821
16822 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16823
7c711119
TT
168242019-01-03 Tom Tromey <tom@tromey.com>
16825
16826 * python/py-symtab.c (salpy_str): Update.
16827 (struct salpy_sal_object) <symtab>: Now a PyObject.
16828 (salpy_dealloc): Update.
16829 (del_objfile_sal): Use gdbpy_ref.
16830
1b20edf0
TT
168312019-01-03 Tom Tromey <tom@tromey.com>
16832
16833 * python/py-type.c (convert_field): Use new_reference. Return
16834 gdbpy_ref.
16835 (make_fielditem): Return gdbpy_ref.
16836 (typy_fields): Update.
16837 (typy_getitem): Update.
16838 (field_name): Return gdbpy_ref. Use new_reference.
16839 (typy_iterator_iternext): Update.
16840
ea41325b
TT
168412019-01-03 Tom Tromey <tom@tromey.com>
16842
16843 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16844
2a3c71d6
TT
168452019-01-03 Tom Tromey <tom@tromey.com>
16846
16847 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16848 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16849 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16850 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16851 (pspy_set_type_printers): Likewise.
16852 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16853 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16854 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16855 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16856 (objfpy_set_type_printers): Likewise.
16857
5c329e6a
TT
168582019-01-03 Tom Tromey <tom@tromey.com>
16859
16860 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16861 (gdbpy_print_stack): Use gdbpy_err_fetch.
16862 * python/python-internal.h (class gdbpy_err_fetch): New class.
16863 (class gdbpy_enter) <m_error_type, m_error_value,
16864 m_error_traceback>: Remove.
16865 <m_error>: New member.
16866 (gdbpy_exception_to_string): Don't declare.
16867 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16868 * python/py-value.c (convert_value_from_python): Use
16869 gdbpy_err_fetch.
16870 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16871 gdbpy_exception_to_string.
16872 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16873 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16874 gdbpy_err_fetch.
16875
169bb27b
AB
168762019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16877
16878 * linux-nat.c (delete_lwp_cleanup): Delete.
16879 (struct lwp_deleter): New struct.
16880 (lwp_info_up): New typedef.
16881 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16882 lwp_info_up.
16883
a07c8880
AB
168842019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16885
16886 * linux-fork.c (class scoped_switch_fork_info): New class.
16887 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16888
26089c49
AB
168892019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16890
16891 * valops.c (find_overload_match): Remove use of null_cleanup, and
16892 calls to do_cleanups.
16893
06d3e5b0
AB
168942019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16895
16896 * compile/compile-cplus-types.c
16897 (compile_cplus_instance::decl_name): Handle changes to
16898 cp_func_name.
16899 * cp-support.c (cp_func_name): Update header comment, update
16900 return type.
16901 * cp-support.h (cp_func_name): Update return type in declaration.
16902 * valops.c (find_overload_match): Move temp_func local to top
16903 level of function and change its type. Use temp_func to hold and
16904 delete temporary string obtained from cp_func_name.
16905
66644cd3
AB
169062019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16907
16908 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16909 gdb::char_vector, remove cleanup, and update uses of `msg`.
16910
592d8c0a
JW
169112019-01-03 Jim Wilson <jimw@sifive.com>
16912
16913 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16914
c55d06ec
TT
169152019-01-02 Tom Tromey <tom@tromey.com>
16916
16917 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16918 (tdesc_parse_xml): Remove cleanups.
16919 * target-descriptions.h (make_cleanup_free_target_description):
16920 Don't declare.
16921 (target_desc_deleter): New struct.
16922 (target_desc_up): New typedef.
16923 * target-descriptions.c (target_desc_deleter::operator()): Rename
16924 from free_target_description.
16925 (make_cleanup_free_target_description): Remove.
16926
3a6ae42d
TT
169272019-01-02 Tom Tromey <tom@tromey.com>
16928
16929 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16930 constructor, destructor.
16931 (linespec_parser): Remove typedef.
16932 (~linespec_parser): Rename from linespec_parser_delete.
16933 (linespec_lex_to_end, linespec_complete_label)
16934 (linespec_complete): Update.
16935 (decode_line_full): Remove cleanups.
16936 (decode_line_1): Update.
16937
61fd3e73
TT
169382019-01-02 Tom Tromey <tom@tromey.com>
16939
16940 * python/python-internal.h (inferior_to_inferior_object): Change
16941 return type.
16942 * python/py-exitedevent.c (create_exited_event_object): Update.
16943 * python/py-inferior.c (inferior_to_inferior_object): Return
16944 gdbpy_ref.
16945 (python_new_inferior, python_inferior_deleted)
16946 (thread_to_thread_object, delete_thread_object)
16947 (build_inferior_list, gdbpy_selected_inferior): Update.
16948 * python/py-infthread.c (create_thread_object): Update. Also fail
16949 if inferior_to_inferior_object fails.
16950
d20172fc
SM
169512019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16952
16953 * inferior.h (class inferior) <displaced_step_state>: New field.
16954 * infrun.h (struct displaced_step_state): Move here from
16955 infrun.c. Initialize fields, add constructor.
16956 <inf>: Remove field.
16957 <reset>: New method.
16958 * infrun.c (struct displaced_step_inferior_state): Move to
16959 infrun.h.
16960 (displaced_step_inferior_states): Remove.
16961 (get_displaced_stepping_state): Adust.
16962 (displaced_step_in_progress_any_inferior): Adjust.
16963 (displaced_step_in_progress_thread): Adjust.
16964 (displaced_step_in_progress): Adjust.
16965 (add_displaced_stepping_state): Remove.
16966 (get_displaced_step_closure_by_addr): Adjust.
16967 (remove_displaced_stepping_state): Remove.
16968 (infrun_inferior_exit): Call displaced_step_state.reset.
16969 (use_displaced_stepping): Don't check for NULL.
16970 (displaced_step_prepare_throw): Call
16971 get_displaced_stepping_state.
16972 (displaced_step_fixup): Don't check for NULL.
16973 (prepare_for_detach): Don't check for NULL.
16974
e3319240
PW
169752019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16976
16977 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16978 in case of call that did not complete.
16979
5d36dfb9
AU
169802019-01-02 Andrey Utkin <autkin@undo.io>
16981
16982 * symfile.c (find_separate_debug_file): Fix search of debug files for
16983 remote debuggee.
16984
8833fbf0
TT
169852019-01-02 Tom Tromey <tom@tromey.com>
16986
16987 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16988 indentation.
16989 * python/py-frame.c (frapy_older): Remove cast.
16990 (frapy_newer): Likewise.
16991 * python/py-breakpoint.c (local_setattro): Remove cast.
16992 * python/py-arch.c (archpy_name): Remove local variable.
16993 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16994
4ada3dfd
JB
169952019-01-02 Joel Brobecker <brobecker@adacore.com>
16996
16997 * unittests/basic_string_view/element_access/char/empty.cc:
16998 Fix year range in copyright header.
16999
113b7b81
AB
170002019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17001
17002 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17003 Delete.
17004 <operator==>: Update with for removed field.
17005 <hash>: Likewise.
17006 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17007 <isa_features>: ...this.
17008 <abi_features>: New field.
17009 (riscv_isa_flen): Update comment.
17010 (riscv_abi_xlen): New declaration.
17011 (riscv_abi_flen): New declaration.
17012 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17013 isa_features.
17014 (riscv_abi_xlen): New function.
17015 (riscv_isa_flen): Update to get answer from isa_features.
17016 (riscv_abi_flen): New function.
17017 (riscv_has_fp_abi): Update to get answer from abi_features.
17018 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17019 xlen and flen.
17020 (riscv_call_info) <xlen, flen>: Update comment.
17021 (riscv_call_arg_struct): Remove invalid assertions
17022 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17023 is removed.
17024 (riscv_gdbarch_init): Gather isa features and abi features
17025 separately, ensure both match on the gdbarch when reusing an old
17026 gdbarch. Relax an error check to allow 32-bit abi float to run on
17027 a target with 64-bit float hardware.
17028
b18ca514
PW
170292019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17030
17031 * source.c (search_command_helper): Stop reverse search
17032 when line 1 has been searched.
17033
ec70d8db
PW
170342019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17035
17036 * record-full.c (record_full_base_target::close): Rewrite
17037 record_full_core_buf_list free logic.
17038
5b38f9c1
PW
170392019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17040
17041 * break-catch-syscall.c (print_one_catch_syscall): xfree
17042 the last text.
17043
66d91b39
JB
170442019-01-01 Joel Brobecker <brobecker@adacore.com>
17045
17046 * top.c (print_gdb_version): Update Copyright year in version
17047 message.
17048
42a4f53d
JB
170492019-01-01 Joel Brobecker <brobecker@adacore.com>
17050
17051 Update copyright year range in all GDB files.
17052
7e955d83 170532019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17054
5bbd631d 17055 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17056
5bbd631d 17057For older changes see ChangeLog-2018.
c906108c
SS
17058\f
17059Local Variables:
17060mode: change-log
17061left-margin: 8
17062fill-column: 74
17063version-control: never
57da7796 17064coding: utf-8
c906108c 17065End:
5bbd631d 17066
This page took 3.58399 seconds and 4 git commands to generate.