projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Remove tui_show_disassem_and_update_source
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
8acfefcc
TT		 12019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
4 tui_show_disassem.
5 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
6 declare.
7 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
8
5ebd5402
TT		 92019-12-20 Tom Tromey <tom@tromey.com>
10
11 * tui/tui.h (tui_show_source): Remove parameters.
12 * tui/tui.c (tui_show_source): Remove parameters.
13 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
14
c1b167d7
TT		 152019-12-20 Tom Tromey <tom@tromey.com>
16
17 * tui/tui.c (tui_show_source): Update.
18 * tui/tui-winsource.c (tui_display_main): Update.
19 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
20 to symtab.
21 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
22 to symtab.
23 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
24
364d7104
TT		 252019-12-20 Tom Tromey <tom@tromey.com>
26
27 PR tui/23619:
28 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
29 (tui_redisplay_readline): Use rl_display_prompt.
30 (tui_prep_terminal): Update.
31
0ad6b8ee
CB		 322019-12-19 Christian Biesinger <cbiesinger@google.com>
33
34 * configure: Regenerate.
35 * configure.ac: Quote variable arguments of test.
36 * gdbsupport/common.m4: Likewise.
37
d411762c
CB		 382019-12-19 Christian Biesinger <cbiesinger@google.com>
39
40 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
41 2 to pow ().
42
1cd4a20a
CB		 432019-12-19 Christian Biesinger <cbiesinger@google.com>
44
45 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
46 log10 to double to fix Solaris 11 with gcc 5.5.
47
aa989b27
CB		 482019-12-19 Christian Biesinger <cbiesinger@google.com>
49
50 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
51 "sun" to "saddr_un".
52
2032eb7e
TT		 532019-12-19 Tom Tromey <tromey@adacore.com>
54
55 * ui-out.h (enum class field_kind): Fix comment.
56
f69656d0
TT		 572019-12-11 Tom Tromey <tromey@adacore.com>
58
59 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
60
27e4fac7
TT		 612019-12-18 Tom Tromey <tromey@adacore.com>
62
63 PR build/25268:
64 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
65 type on macOS. Add comment.
66
e623f035
SM		 672019-12-18 Simon Marchi <simon.marchi@efficios.com>
68
69 * c-lang.c (c_get_string, asm_language_defn): Remove space
70 before tab.
71
28ce7b07
TT		 722019-12-18 Tom Tromey <tromey@adacore.com>
73
74 PR build/25250:
75 * ui-out.c (ui_out::vmessage): Update.
76 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
77 Rename.
78 (string_field): Update.
79 (signed_field): Update.
80
bbde7025
SM		 812019-12-18 Simon Marchi <simon.marchi@efficios.com>
82
83 * top.c (print_gdb_configuration): Adjust indentation.
84
e3169fe0
CB		 852019-12-17 Christian Biesinger <cbiesinger@google.com>
86
87 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
88
9b30da15
SM		 892019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
90
91 * tui/tui-layout.h (class tui_layout_base): Add virtual
92 destructor.
93
4a4c04f1
BE		 942019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
95
96 * infcmd.c (prepare_one_step): Step over skipped inline functions.
97 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
98 (process_event_stop_test): Keep stepping over skipped inline functions.
99
0394eed1
SM		 1002019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
101
102 * jit.c (struct gdb_block) <next>: Remove field.
103 (struct gdb_symtab) <~gdb_symtab>: Remove.
104 <blocks>: Change type to std::forward_list<gdb_block>.
105 (compare_block): Remove.
106 (jit_block_open_impl): Adjust to std::forward_list. Place the new
107 block at the beginning, don't mind about sorting.
108 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
109 before using it.
110
b6112117
SM		 1112019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
112
113 * jit.c (struct gdb_block): Add constructor, initialize
114 real_block and next fields.
115 <name>: Change type to gdb::unique_xmalloc_ptr.
116 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
117 (jit_block_open_impl): Allocate gdb_block with new.
118 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
119
1b61f46d
SM		 1202019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
121
122 * jit.c: Include forward_list.
123 (struct gdb_symtab) <next>: Remove field.
124 (struct gdb_object) <symtabs>: Change type to
125 std::forward_list<gdb_symtab>.
126 (jit_object_open_impl): Allocate gdb_object with new.
127 (jit_symtab_open_impl): Adjust to std::forward_list.
128 (finalize_symtab): Don't delete symtab.
129 (jit_object_close_impl): Adjust to std::forward_list. Free
130 gdb_object with delete.
131
89867184
SM		 1322019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
133
134 * jit.c (struct gdb_symtab): Add constructor, destructor,
135 initialize fields.
136 <linetable>: Change type to unique_xmalloc_ptr.
137 <file_name>: Change type to std::string.
138 (jit_symtab_open_impl): Allocate gdb_symtab with new.
139 (jit_symtab_line_mapping_add_impl): Adjust.
140 (finalize_symtab): Adjust, call delete on stab.
141
d043f8c8
SM		 1422019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
143
144 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
145
d9fa87f4
TT		 1462019-12-16 Tom Tromey <tromey@adacore.com>
147
148 * windows-nat.c (windows_nat_target::attach): Update.
149 * remote.c (extended_remote_target::attach): Update.
150 * procfs.c (procfs_target::attach): Update.
151 * nto-procfs.c (nto_procfs_target::attach): Update.
152 (nto_procfs_target::create_inferior): Update.
153 * inf-ptrace.c (inf_ptrace_target::attach): Update.
154 * gnu-nat.c (gnu_nat_target::attach): Update.
155 (gnu_nat_target::detach): Update.
156 * darwin-nat.c (darwin_nat_target::attach): Update.
157 * corefile.c (get_exec_file): Constify result. Remove extraneous
158 return.
159 * bsd-kvm.c (bsd_kvm_target_open): Update.
160 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
161
c0c3707f
CB		 1622019-12-16 Christian Biesinger <cbiesinger@google.com>
163
164 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
165 (we no longer need to include time.h before pathmax.h)
166
d3ecddab
CB		 1672019-12-15 Christian Biesinger <cbiesinger@google.com>
168
169 * ada-exp.y (write_ambiguous_var): Update.
170 * coffread.c (process_coff_symbol): Update.
171 * ctfread.c (ctf_add_enum_member_cb): Update.
172 (new_symbol): Update.
173 * dwarf2read.c (fixup_go_packaging): Update.
174 (new_symbol): Update.
175 * language.c (language_alloc_type_symbol): Update.
176 * mdebugread.c (new_symbol): Update.
177 * minsyms.c (minimal_symbol_reader::record_full): Update.
178 * psymtab.c (add_psymbol_to_bcache): Update.
179 * stabsread.c (define_symbol): Update.
180 (read_enum_type): Update.
181 * symtab.c (symbol_set_language): Make this a member function...
182 (general_symbol_info::set_language): ... here.
183 * symtab.h (struct general_symbol_info) <set_language>: New function.
184 (SYMBOL_SET_LANGUAGE): Remove.
185 (symbol_set_language): Remove.
186
c1b5c1eb
CB		 1872019-12-15 Christian Biesinger <cbiesinger@google.com>
188
189 * ada-lang.c (ada_add_block_symbols): Update.
190 (ada_collect_symbol_completion_matches): Update.
191 * ax-gdb.c (gen_expr): Update.
192 * block.c (block_lookup_symbol): Update.
193 (block_lookup_symbol_primary): Update.
194 (block_find_symbol): Update.
195 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
196 * dbxread.c (process_one_symbol): Update.
197 * dictionary.c (insert_symbol_hashed): Update.
198 (collate_pending_symbols_by_language): Update.
199 (mdict_add_symbol): Update.
200 * dwarf-index-write.c (write_psymbols): Update.
201 * dwarf2read.c (fixup_go_packaging): Update.
202 * findvar.c (read_var_value): Update.
203 * ft32-tdep.c (ft32_skip_prologue): Update.
204 * go-lang.c (go_symbol_package_name): Update.
205 * language.h (scoped_switch_to_sym_language_if_auto::
206 scoped_switch_to_sym_language_if_auto): Update.
207 * linespec.c (find_method): Update.
208 (find_label_symbols_in_block): Update.
209 * mdebugread.c (parse_symbol): Update.
210 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
211 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
212 (minimal_symbol_reader::install): Update.
213 * moxie-tdep.c (moxie_skip_prologue): Update.
214 * parse.c (parse_exp_in_context): Update.
215 * psymtab.c (psymbol_name_matches): Update.
216 (match_partial_symbol): Update.
217 (lookup_partial_symbol): Update.
218 (psymbol_hash): Update.
219 (psymbol_compare): Update.
220 * python/py-framefilter.c (extract_sym): Update.
221 (py_print_single_arg): Update.
222 * stabsread.c (define_symbol): Update.
223 * stack.c (print_frame_arg): Update.
224 (find_frame_funname): Update.
225 (info_frame_command_core): Update.
226 * symfile.c (set_initial_language): Update.
227 * symtab.c (symbol_set_demangled_name): Update.
228 (symbol_get_demangled_name): Update.
229 (symbol_set_language): Update.
230 (symbol_find_demangled_name): Update.
231 (symbol_set_names): Update.
232 (general_symbol_info::natural_name): Update.
233 (general_symbol_info::demangled_name): Update.
234 (general_symbol_info::search_name): Update.
235 (symbol_matches_search_name): Update.
236 (eq_symbol_entry): Update.
237 (iterate_over_symbols): Update.
238 (completion_list_add_symbol): Update.
239 (completion_list_add_msymbol): Update.
240 (completion_list_add_fields): Update.
241 * symtab.h (struct general_symbol_info) <language>: New function.
242 <language>: Rename to...
243 <m_language>: ...this.
244 (SYMBOL_LANGUAGE): Remove.
245 (MSYMBOL_LANGUAGE): Remove.
246 (struct symbol) <ctor>: Update.
247 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
248
747cfc8c
CB		 2492019-12-15 Christian Biesinger <cbiesinger@google.com>
250
251 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
252 set the language of sym.
253 * language.c (language_alloc_type_symbol): Likewise.
254
ff8577f6
SDJ		 2552019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
256
257 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
258 PR gdb/23613
259 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
260 * corelow.c: Include 'gdbsupport/pathstuff.h'.
261 (core_target_open): Use 'gdb_abspath'.
262 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
263 'current_directory == NULL' case.
264 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
265 explain what happens when 'current_directory' is NULL.
266 * go32-nat.c (go32_nat_target::wait): Check if
267 'current_directory' is NULL before call to 'chdir'.
268 * source.c (add_path): Use 'gdb_abspath'.
269 * top.c: Include 'gdbsupport/pathstuff.h'.
270 (init_history): Use 'gdb_abspath'.
271 (set_history_filename): Likewise.
272 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
273 (tfile_target_open): Use 'gdb_abspath'.
274
234c3068
TT		 2752019-12-13 Tom Tromey <tromey@adacore.com>
276
277 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
278 warning or error.
279
93537683
TT		 2802019-12-13 Tom Tromey <tromey@adacore.com>
281
282 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
283
63456183
TT		 2842019-12-13 Tom Tromey <tromey@adacore.com>
285
286 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
287
98f9338a
TT		 2882019-12-13 Tom Tromey <tromey@adacore.com>
289
290 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
291
3cb5a3a1
TT		 2922019-12-13 Tom Tromey <tromey@adacore.com>
293
294 * gdbsupport/common-utils.c (string_printf, string_vprintf)
295 (string_vappendf): Add ARI comment.
296
c6cbf900
TT		 2972019-12-13 Tom Tromey <tromey@adacore.com>
298
299 * contrib/ari/gdb_ari.sh: Remove "fix" call for
300 floatformat_to_double.
301 * target-float.c (host_float_ops<T>::from_target): Add ARI
302 comment.
303
036003a6
TT		 3042019-12-13 Tom Tromey <tromey@adacore.com>
305
306 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
307 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
308 ARI marker to abort.
309 * event-top.c (handle_sigsegv): Add ARI marker to abort.
310
8aaaf757
TT		 3112019-12-13 Tom Tromey <tromey@adacore.com>
312
313 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
314
fe56157f
TT		 3152019-12-13 Tom Tromey <tromey@adacore.com>
316
317 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
318
a15a95ed
TT		 3192019-12-13 Tom Tromey <tromey@adacore.com>
320
321 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
322 checks.
323
a5513db2
TT		 3242019-12-13 Tom Tromey <tromey@adacore.com>
325
326 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
327 end>: No longer "const".
328
3a90f266
SM		 3292019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
330
331 * jit.c: Fix indentation, replace spaces with tabs where
332 applicable.
333
b3f4b80f
JL		 3342019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
335
336 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
337
e671856c
TT		 3382019-12-12 Tom Tromey <tom@tromey.com>
339
340 * objfiles.h (struct objfile) <partial_symtabs>: Now a
341 unique_ptr.
342
7d7167ce
TT		 3432019-12-12 Tom Tromey <tom@tromey.com>
344
345 * progspace.h (objfile_list): New typedef.
346 (class unwrapping_objfile_iterator)
347 (struct unwrapping_objfile_range): Newl
348 (struct program_space) <objfiles_range>: Change type.
349 <objfiles>: Change return type.
350 <add_objfile>: Change type of "objfile" parameter.
351 <objfiles_list>: Now a list of shared_ptr.
352 * progspace.c (program_space::add_objfile): Change type of
353 "objfile". Update.
354 (program_space::remove_objfile): Update.
355 * objfiles.h (struct objfile) <~objfile>: Make public.
356 * objfiles.c (objfile::make): Update.
357 (objfile::unlink): Don't call delete.
358
343cc952
TT		 3592019-12-12 Tom Tromey <tom@tromey.com>
360
361 * symfile.c (symbol_file_clear): Update.
362 * progspace.h (struct program_space) <free_all_objfiles>: Declare
363 method.
364 * progspace.c (program_space::free_all_objfiles): New method.
365 * objfiles.h (free_all_objfiles): Don't declare.
366 * objfiles.c (free_all_objfiles): Move to program_space.
367
d0801dd8
TT		 3682019-12-12 Tom Tromey <tom@tromey.com>
369
370 * progspace.c (program_space::add_objfile)
371 (program_space::remove_objfile): Update.
372 (program_space::multi_objfile_p): Remove.
373 * objfiles.h (struct objfile) <next>: Remove.
374 * objfiles.c (objfile::objfile): Update.
375 (put_objfile_before): Update.
376 (unlink_objfile): Update.
377 * progspace.h (object_files): Remove.
378 (struct program_space) <objfiles_head>: Remove.
379 <objfiles_list>: New member.
380 <objfiles_range, objfiles_safe_range>: Change type.
381 (objfiles): Change return type.
382 (objfiles_safe): Update.
383 (multi_objfile_p): Rewrite and inline.
384 (object_files): Remove macro.
385
13bff726
TT		 3862019-12-12 Tom Tromey <tom@tromey.com>
387
388 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
389 second constructor.
390 (basic_safe_range): New class.
391
deeafabb
TT		 3922019-12-12 Tom Tromey <tom@tromey.com>
393
394 * progspace.c (program_space::multi_objfile_p): New method.
395 * printcmd.c (info_symbol_command): Update.
396 * maint.c (maintenance_translate_address): Update.
397 * objfiles.h (MULTI_OBJFILE_P): Remove.
398 * progspace.h (struct program_space) <multi_objfile_p>: New
399 method.
400
23452926
TT		 4012019-12-12 Tom Tromey <tom@tromey.com>
402
403 * progspace.h (struct program_space) <remove_objfile>: Declare.
404 * progspace.c (program_space::remove_objfile): New method.
405 * objfiles.c (unlink_objfile): Remove.
406 (objfile::unlink): Call remove_objfile.
407 (objfile): Don't call unlink_objfile.
408
7cac64af
TT		 4092019-12-12 Tom Tromey <tom@tromey.com>
410
411 * progspace.h (struct program_space) <add_objfile>: Declare
412 method.
413 * progspace.c (program_space::add_objfile): New method.
414 * objfiles.c (~objfile): Don't unlink objfile.
415 (put_objfile_before): Remove.
416 (add_separate_debug_objfile): Don't call put_objfile_before.
417 (objfile::make): Call add_objfile. Set new_objfiles_available on
418 the per-program-space data.
419
268e4f09
TT		 4202019-12-12 Tom Tromey <tom@tromey.com>
421
422 * symfile.c (syms_from_objfile_1): Use objfile_up.
423 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
424 method.
425 (reread_symbols): Use objfile_up.
426 * solib.c (update_solib_list, reload_shared_libraries_1): Call
427 unlink method.
428 * objfiles.h (struct objfile) <~objfile>: Now private.
429 <unlink>: New method.
430 (struct objfile_deleter): New.
431 (objfile_up): New typedef.
432 * objfiles.c (objfile::unlink): New method.
433 (free_objfile_separate_debug, free_all_objfiles)
434 (objfile_purge_solibs): Use it.
435 * jit.c (jit_unregister_code): Remove.
436 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
437 objfile.
438 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
439 objfile.
440 * compile/compile-object-load.c (compile_object_load): Use
441 objfile_up.
442
f65fe570
TT		 4432019-12-12 Tom Tromey <tom@tromey.com>
444
445 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
446 objfile::make.
447 * objfiles.h (struct objjfile) <make>: No longer inline.
448 (add_separate_debug_objfile): Don't declare.
449 * objfiles.c (add_separate_debug_objfile): Now static.
450 (objfile::make): Move from objfiles.h. Call
451 add_separate_debug_objfile. Add "parent" parameter.
452
bda13cdc
TT		 4532019-12-12 Tom Tromey <tom@tromey.com>
454
455 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
456 * objfiles.h (struct objfile): Make constructor private.
457 <make>: New static method.
458 * jit.c (jit_object_close_impl): Update.
459
7190276c
SM		 4602019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
461
462 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
463 gdb::byte_vector.
464
d61df897
TT		 4652019-12-12 Tom Tromey <tromey@adacore.com>
466
467 * xml-support.c (xml_fetch_content_from_file): Don't call
468 malloc_failure.
469 * utils.h (class gdb_argv): Remove malloc_failure comment.
470 * utils.c (gdb_argv::reset): Don't call malloc_failure.
471
db3ad2f0
TT		 4722019-12-12 Tom Tromey <tromey@adacore.com>
473
474 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
475 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
476 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
477 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
478 * riscv-ravenscar-thread.c: New file.
479 * riscv-ravenscar-thread.h: New file.
480 * riscv-tdep.c (riscv_gdbarch_init): Call
481 register_riscv_ravenscar_ops.
482
2ffe5b9c
TT		 4832019-12-12 Tom Tromey <tromey@adacore.com>
484
485 * gdbsupport/thread-pool.c (set_thread_name): Use
486 ATTRIBUTE_UNUSED.
487
39f34d7b
LM		 4882019-12-12 Luis Machado <luis.machado@linaro.org>
489
490 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
491 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
492 macros.
493
d4eeccfe
TT		 4942019-12-11 Tom Tromey <tom@tromey.com>
495
496 * tui/tui-win.c (tui_set_win_height_command): Call
497 tui_adjust_window_height.
498 (tui_adjust_win_heights, new_height_ok): Remove.
499 * tui/tui-layout.h (tui_adjust_window_height): Declare.
500 * tui/tui-layout.c (tui_adjust_window_height): New function.
501
3d979945
TT		 5022019-12-11 Tom Tromey <tom@tromey.com>
503
504 * tui/tui-win.c (tui_resize_all): Remove code, call
505 tui_apply_current_layout.
506
2192a9d3
TT		 5072019-12-11 Tom Tromey <tom@tromey.com>
508
509 * tui/tui-layout.h (tui_apply_current_layout): Declare.
510 * tui/tui-layout.c (standard_layouts, applied_layout): New
511 globals.
512 (tui_apply_current_layout): New function.
513 (show_layout): Set applied_layout. Call
514 tui_apply_current_layout.
515 (show_source_command, show_disasm_command)
516 (show_source_disasm_command, show_data)
517 (show_source_or_disasm_and_command): Remove.
518 (initialize_layouts): New function.
519 (_initialize_tui_layout): Call initialize_layouts.
520
389e7ddb
TT		 5212019-12-11 Tom Tromey <tom@tromey.com>
522
523 * tui/tui-layout.h (class tui_layout_base)
524 (class tui_layout_window, class tui_layout_split): New.
525 * tui/tui-layout.c (tui_get_window_by_name)
526 (tui_layout_window::clone, tui_layout_window::apply)
527 (tui_layout_window::get_sizes, tui_layout_window::add_split)
528 (tui_layout_split::add_window, tui_layout_split::clone)
529 (tui_layout_split::get_sizes)
530 (tui_layout_split::set_weights_from_heights)
531 (tui_layout_split::adjust_size, tui_layout_split::apply): New
532 functions.
533 (tui_layout_split::add_split, tui_layout_split::add_split)
534 (tui_layout_split::set_weights_from_heights)
535 (tui_layout_split::set_weights_from_heights): New functions.
536
fb3184d8
TT		 5372019-12-11 Tom Tromey <tom@tromey.com>
538
539 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
540 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
541 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
542 * tui/tui-data.h (struct tui_point): Remove.
543 (struct tui_gen_win_info) <origin>: Remove.
544 <x, y>: New fields.
545 * tui/tui-command.c (tui_cmd_window::resize): Update.
546
dc7ff8a6
TT		 5472019-12-11 Tom Tromey <tom@tromey.com>
548
549 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
550 Implement.
551 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
552 Implement.
553 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
554 method.
555 (struct tui_win_info) <min_height>: Implement.
556
1431937b
TT		 5572019-12-11 Tom Tromey <tom@tromey.com>
558
559 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
560 (struct tui_win_info) <can_box>: Update.
561
c8ec2f43
TT		 5622019-12-11 Tom Tromey <tom@tromey.com>
563
564 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
565 method.
566 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
567 method.
568 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
569 method.
570 (struct tui_win_info) <max_height>: Now override.
571
4decd62b
JB		 5722019-12-11 Joel Brobecker <brobecker@adacore.com>
573
574 * NEWS: Create a new section for the next release branch.
575 Rename the section of the current branch, now that it has
576 been cut.
577
d746744e
JB		 5782019-12-11 Joel Brobecker <brobecker@adacore.com>
579
580 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
581 * version.in: Bump version to 10.0.50.DATE-git.
582
2e744276
TT		 5832019-12-11 Tom Tromey <tromey@adacore.com>
584
585 PR build/25268:
586 * gdbsupport/thread-pool.c (set_thread_name): New function.
587 (thread_pool::set_thread_count): Don't call pthread_setname_np.
588 (thread_pool::thread_function): Call set_thread_name.
589
aac4760f
TT		 5902019-12-11 Tom Tromey <tromey@adacore.com>
591
592 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
593 bfd_get_signed_8.
594
d8edc8b7
PW		 5952019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
596
597 * NEWS: Document -raw-values option and the related setting commands.
598 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
599 only set it on when /r is given.
600 * valprint.c (value_print_option_defs): New element raw-values.
601 * Makefile.in: Add the new file.
602
cb511130
CB		 6032019-12-10 Christian Biesinger <cbiesinger@google.com>
604
605 * gdbsupport/safe-strerror.c: Supress the unused function warning
606 for select_strerror_r.
607
ab7d13f0
CB		 6082019-12-10 Christian Biesinger <cbiesinger@google.com>
609
610 * config.in: Regenerate.
611 * configure: Regenerate.
612 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
613 safe_strerror instead of strerror.
614 * gdbsupport/common.m4: Don't check for strerror.
615 * gdbsupport/safe-strerror.c: Support both the glibc version
616 of strerror_r and the XSI version.
617
6c71eb7d
TT		 6182019-12-10 Tom Tromey <tromey@adacore.com>
619
620 * ada-typeprint.c (print_choices): Use a single "?".
621 (print_variant_part): Print "?" if the discriminant name
622 is not known.
623
bac7c5cf
GB		 6242019-12-10 George Barrett <bob@bob131.so>
625
626 Fix scripted probe breakpoints.
627 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
628 declaration forward.
629 (breakpoint_ops_for_event_location_type)
630 (breakpoint_ops_for_event_location): Add function definitions.
631 (break_command_1, trace_command): Use
632 breakpoint_ops_for_event_location.
633 * breakpoint.h (breakpoint_ops_for_event_location): Add function
634 declarations.
635 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
636 breakpoint_ops_for_event_location.
637 * python/py-breakpoint.c (bppy_init): Use
638 breakpoint_ops_for_event_location.
639
330f1d38
TBA		 6402019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
641
642 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
643 when ranking an lvalue argument for an rvalue parameter.
644
b1f0c0b9
WA		 6452019-12-08 Wataru Ashihara <wataash@wataash.com>
646
647 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
648 template argument for scoped_restore_tmpl from bool to int.
649
aa2d5a42
KS		 6502019-12-07 Keith Seitz <keiths@redhat.com>
651
652 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
653 (build_id_to_debug_bfd): Make static, rewriting to use
654 build_id_to_bfd_suffix.
655 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
656 adding `suffix' parameter. Append SUFFIX to file names
657 when searching for matching files.
658 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
659 (build_id_to_exec_bfd): Likewise.
660 * build-id.h (build_id_to_debug_bfd): Clarify that function
661 searches for BFD of debug info file.
662 (build_id_to_exec_bfd): Declare.
663 * corelow.c: Include build-id.h.
664 (locate_exec_from_corefile_build_id): New function.
665 (core_target_open): If no executable BFD is found,
666 search for a core file BFD using build-id.
667
dfb65191
CB		 6682019-12-06 Christian Biesinger <cbiesinger@google.com>
669
670 * bcache.c: Put in namespace gdb.
671 * bcache.h: Likewise.
672 * gdbtypes.c (check_types_worklist): Update.
673 (types_deeply_equal): Update.
674 * macrotab.c (struct macro_table) <bcache>: Update.
675 (new_macro_table): Update.
676 * macrotab.h (struct bcache): Put this forward declaration
677 inside namespace gdb.
678 (new_macro_table): Update.
679 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
680 Update.
681 <macro_cache>: Update.
682 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
683
93e55f0a
TV		 6842019-12-06 Tom de Vries <tdevries@suse.de>
685
686 PR symtab/24971
687 * block.c (best_symbol, better_symbol): New function.
688 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
689 decl.
690
06acc08f
TBA		 6912019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
692
693 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
694 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
695 for ranking see-through reference cases.
696
e0fad1ea
PW		 6972019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
698 * stack.c (faas_command): Check a command is provided.
699 * thread.c (taas_command, tfaas_command): Likewise.
700
908641f5
PW		 7012019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
702 * inferior.c (prune_inferiors): Only call delete_inferior,
703 Do not modify the inferior list.
704
b858499d
SM		 7052019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
706
707 * c-exp.y: Update calls to lookup_typename,
708 lookup_signed_typename and lookup_unsigned_typename.
709 * c-lang.c (evaluate_subexp_c): Likewise.
710 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
711 Likewise.
712 * eval.c (binop_promote): Likewise.
713 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
714 (lookup_unsigned_typename): Likewise.
715 (lookup_signed_typename): Likewise.
716 * gdbtypes.h (lookup_unsigned_typename): Likewise.
717 (lookup_signed_typename): Likewise.
718 (lookup_typename): Likewise.
719 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
720 lookup_typename, lookup_signed_typename,
721 lookup_unsigned_typename.
722 * m2-exp.y: Likewise.
723 * printcmd.c (printf_wide_c_string): Likewise.
724 (ui_printf): Likewise.
725 * python/py-type.c (typy_lookup_typename): Likewise.
726 * python/py-xmethods.c (python_xmethod_worker::invoke):
727 Likewise.
728 * rust-exp.y: Likewise.
729
3a8fa228
CB		 7302019-12-04 Christian Biesinger <cbiesinger@google.com>
731
732 * configure.nat (obsd64): Add missing files x86-nat.o and
733 nat/x86-dregs.o.
734
2dbc041e
TT		 7352019-12-04 Tom Tromey <tom@tromey.com>
736
737 * valprint.c (val_print_string): Use metadata_style.
738 * go-valprint.c (print_go_string): Use metadata style.
739 * p-valprint.c (pascal_object_print_static_field): Use metadata
740 style.
741 * cp-valprint.c (cp_print_static_field): Use metadata style.
742
36c8fb93
AB		 7432019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
744 Chris January <chris.january@arm.com>
745
746 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
747 tokens.
748 (typebase): New patterns for complex, single/double precision, and
749 single/double complex.
750 (f77_keywords): Change token for complex keyword, and add single,
751 double, and precision keywords.
752
c6170c2c
SM		 7532019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
754
755 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
756 "info io_registers".
757
894ecaf4
SM		 7582019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
759
760 * regcache.c (cooked_read_test): Initialize thread list of
761 mock_inferior.
762
be155ebb
SM		 7632019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
764
765 * aarch64-linux-tdep.c: Remove includes.
766
c577cdd7
SM		 7672019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
768
769 * aarch64-tdep.c: Remove includes.
770
610cfd61
SM		 7712019-12-04 Simon Marchi <simon.marchi@efficios.com>
772
773 * filtered-iterator.h (filtered_iterator) <operator==,
774 operator!=>: Compare wrapped iterators, not wrapped pointers.
775 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
776 unittests/filtered_iterator-selftests.c.
777 * unittests/filtered_iterator-selftests.c: New file.
778
a05cf17a
TT		 7792019-12-04 Tom Tromey <tromey@adacore.com>
780
781 * gdbtypes.c (create_range_type): Inherit endianity
782 from base type.
783
d5a22e77
TT		 7842019-12-04 Tom Tromey <tromey@adacore.com>
785
786 * ada-lang.c (decode_constrained_packed_array)
787 (ada_value_assign, value_assign_to_component): Update.
788 * dwarf2loc.c (rw_pieced_value, access_memory)
789 (dwarf2_compile_expr_to_ax): Update.
790 * dwarf2read.c (dwarf2_add_field): Update.
791 * eval.c (evaluate_subexp_standard): Update.
792 * gdbarch.c, gdbarch.h: Rebuild.
793 * gdbarch.sh (bits_big_endian): Remove.
794 * gdbtypes.h (union field_location): Update comment.
795 * target-descriptions.c (make_gdb_type): Update.
796 * valarith.c (value_bit_index): Update.
797 * value.c (struct value) <bitpos>: Update comment.
798 (unpack_bits_as_long, modify_field): Update.
799 * value.h (value_bitpos): Update comment.
800
7ab4a236
TT		 8012019-12-04 Tom Tromey <tromey@adacore.com>
802
803 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
804 endian-ness.
805
103a685e
TT		 8062019-12-04 Tom Tromey <tromey@adacore.com>
807
808 * dwarf2read.c (dwarf2_init_float_type)
809 (dwarf2_init_complex_target_type): Add byte_order parameter.
810 (read_base_type): Compute byte order earlier.
811 * gdbtypes.c (init_float_type): Add byte_order parameter.
812 * gdbtypes.h (init_float_type): Add byte_order parameter.
813
7a9e9f9f
TT		 8142019-12-04 Tom Tromey <tromey@adacore.com>
815
816 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
817
feee869b
TT		 8182019-12-04 Tom Tromey <tromey@adacore.com>
819
820 * dwarf2read.c (process_structure_scope): Initialize
821 "discr_offset".
822
c2512106
AB		 8232019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
824
825 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
826 add it into the search spec.
827 (parse_max_results_option): New function.
828 (mi_info_functions_or_variables): Parse -max-results flag and pass
829 it to mi_symbol_info.
830 (mi_cmd_symbol_info_modules): Likewise.
831 (mi_cmd_symbol_info_types): Likewise.
832 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
833 return type to bool, change result container into a set, and don't
834 add new results if we have enough already.
835 (global_symbol_searcher::add_matching_msymbols): Change return
836 type to bool, and don't add new results if we have enough already.
837 (sort_search_symbols_remove_dups): Delete.
838 (global_symbol_searcher::search): Early exit from search loop when
839 we have enough results. Use a std::set to collect the results
840 from calling add_matching_symbols.
841 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
842 member function.
843 (global_symbol_searcher) <m_max_search_results>: New member
844 variable.
845 (global_symbol_searcher) <add_matching_symbols>: Update header
846 comment and change return type to bool.
847 (global_symbol_searcher) <add_matching_msymbols>: Update header
848 comment and change return type to bool.
849
f97a63c5
AB		 8502019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
851
852 * symtab.c (symbol_search::compare_search_syms): Update header
853 comment.
854 (global_symbol_searcher::is_suitable_msymbol): New function.
855 (global_symbol_searcher::expand_symtabs): New function.
856 (global_symbol_searcher::add_matching_symbols): New function.
857 (global_symbol_searcher::add_matching_msymbols): New function.
858 (global_symbol_searcher::search): Move most of the content
859 into the new functions above, and call them as needed.
860 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
861 function.
862 (global_symbol_searcher) <add_matching_symbols>: New member
863 function.
864 (global_symbol_searcher) <add_matching_msymbols>: New member
865 function.
866 (global_symbol_searcher) <is_suitable_msymbol>: New member
867 function.
868
293b38d6
AB		 8692019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
870
871 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
872 -symbol-info-module-variables entries.
873 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
874 (mi_cmd_symbol_info_module_variables): Declare.
875 * mi/mi-symbol-cmds.c
876 (module_symbol_search_iterator): New typedef.
877 (output_module_symbols_in_single_module_and_file): New function.
878 (output_module_symbols_in_single_module): New function.
879 (mi_info_module_functions_or_variables): New function.
880 (mi_cmd_symbol_info_module_functions): New function.
881 (mi_cmd_symbol_info_module_variables): New function.
882 * NEWS: Mention new MI command.
883
4cbd39b2
CB		 8842019-12-03 Christian Biesinger <cbiesinger@google.com>
885
886 * bcache.c (hash): Remove.
887 (hash_continue): Remove.
888 * bcache.h (hash): Remove.
889 (hash_continue): Remove.
890 (struct bcache) <ctor>: Update.
891 * psymtab.c (psymbol_hash): Update.
892 * stabsread.c (hashname): Update.
893 * utils.h (fast_hash): Add an argument for a start value,
894 defaulting to zero.
895
82f910ea
PW		 8962019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
897 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
898 (destroy_block_symbol_cache): New function.
899 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
900 (resize_symbol_cache): Likewise.
901
de2396d0
TT		 9022019-12-02 Tom Tromey <tom@tromey.com>
903
904 * unittests/tui-selftests.c (run_tests): Make conditional.
905 (_initialize_tui_selftest): Make conditional.
906
638d85bc
CB		 9072019-12-02 Christian Biesinger <cbiesinger@google.com>
908
909 * aix-thread.c (debug_aix_thread): Change type to bool.
910
7532a164
LM		 9112019-12-02 Luis Machado <luis.machado@linaro.org>
912
913 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
914
216a7e6b
AB		 9152019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
916
917 * dwarf2read.c (read_tag_string_type): Read the fields required to
918 make a dynamic string, and possibly create a dynamic range for the
919 string.
920 (attr_to_dynamic_prop): Setup is_reference based on the type of
921 attribute being processed.
922 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
923 (resolve_dynamic_array): Rename to...
924 (resolve_dynamic_array_or_string): ...this, update header comment,
925 and accept TYPE_CODE_STRING.
926 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
927
11a8b164
AB		 9282019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
929
930 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
931 of its implementation from...
932 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
933 the new function.
934
5bbd8269
AB		 9352019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
936
937 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
938 create a range with stride where appropriate.
939 * f-valprint.c: Include 'gdbarch.h'.
940 (f77_print_array_1): Take the stride into account when walking the
941 array. Also convert the stride into addressable units.
942 * gdbtypes.c (create_range_type): Initialise the stride to
943 constant zero.
944 (create_range_type_with_stride): New function, initialise the
945 range as normal, and then setup the stride.
946 (has_static_range): Include the stride here. Also change the
947 return type to bool.
948 (create_array_type_with_stride): Consider the range stride if the
949 array isn't given its own stride.
950 (resolve_dynamic_range): Resolve the stride if needed.
951 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
952 (struct range_bounds) <flag_is_byte_stride>: New member variable.
953 (TYPE_BIT_STRIDE): Define.
954 (TYPE_ARRAY_BIT_STRIDE): Define.
955 (create_range_type_with_stride): Declare.
956 * valarith.c (value_subscripted_rvalue): Take range stride into
957 account when walking the array.
958
82e3b564
TT		 9592019-12-01 Tom Tromey <tom@tromey.com>
960
961 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
962 specially.
963
517d261d
TT		 9642019-12-01 Tom Tromey <tom@tromey.com>
965
966 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
967 \0.
968 * unittests/tui-selftests.c: New file.
969 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
970
484c9b64
TT		 9712019-12-01 Tom Tromey <tom@tromey.com>
972
973 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
974
a2a7af0c
TT		 9752019-12-01 Tom Tromey <tom@tromey.com>
976
977 * NEWS: Document new settings.
978 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
979 * tui/tui-win.c (_initialize_tui_win): Add border style
980 observers.
981 * tui/tui-io.h (tui_apply_style): Declare.
982 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
983 longer static.
984 (apply_ansi_escape, tui_set_reverse_mode): Update.
985 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
986 Add "skip_intensity" parameter.
987 <changed>: New member.
988 <do_set_value>: Declare.
989 (tui_border_style, tui_active_border_style): Declare.
990 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
991 globals.
992 (cli_style_option): Initialize "changed".
993 (cli_style_option::do_set_value): New function.
994 (cli_style_option::add_setshow_commands): Add "skip_intensity"
995 parameter. Update.
996 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
997 (_initialize_cli_style): Update. Create TUI border style
998 commands.
999
d1da6b01
TT		 10002019-12-01 Tom Tromey <tom@tromey.com>
1001
1002 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1003 parameter.
1004 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1005 parameter.
1006 * tui/tui-win.h (compact_source): Declare.
1007 * tui/tui-win.c (compact_source): New global.
1008 (tui_set_compact_source, tui_show_compact_source): New functions.
1009 (_initialize_tui_win): Add "compact-source" setting.
1010 * tui/tui-source.c (tui_source_window::set_contents): Handle
1011 compact_source setting.
1012 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1013 * NEWS: Document new setting.
1014
489dbda6
TT		 10152019-11-30 Tom Tromey <tom@tromey.com>
1016
1017 * dwarf2read.c (dwarf2_add_field): Include field offset when
1018 computing variant part length.
1019
bf498525
PW		 10202019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1021 * NEWS: Mention define-prefix. Tell that command names can now
1022 contain a . character.
1023
be09caf1
PW		 10242019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1025
1026 * command.h (valid_cmd_char_p): Declare.
1027 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1028 the check of valid command char.
1029 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1030 valid_cmd_char_p.
1031 * cli/cli-script.c (validate_comname): Likewise.
1032 * completer.c (gdb_completer_command_word_break_characters):
1033 Do not remove . from the word break char, update comments.
1034 (complete_line_internal_1): Use valid_cmd_char_p.
1035 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1036 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1037
c6ac7fc9
PW		 10382019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1039
1040 * cli/cli-script.c (do_define_command): Ensure a redefined
1041 prefix command is kept as a prefix command.
1042 (define_prefix_command): New function.
1043 (show_user_1): Report user defined prefixes.
1044 (_initialize_cli_script): Create the new 'define-prefix' command.
1045 Add completers for 'define' and 'document'.
1046 * top.c (execute_command): If command is a user-defined prefix only
1047 command, report the list of commands for this prefix command.
1048
a992a3b0
TBA		 10492019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1050
1051 * valops.c (find_oload_champ): Improve debug output.
1052
e9194a1a
TBA		 10532019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1054
1055 * valops.c (find_oload_champ): Print part of debug messages
1056 before the badness vector is std::move'd.
1057
53a008a6
TT		 10582019-11-28 Tom Tromey <tom@tromey.com>
1059
1060 * value.c (creal_internal_fn): Fix comment.
1061
bab05c83
TT		 10622019-11-28 Tom Tromey <tom@tromey.com>
1063
1064 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1065 flag_bound_evaluated>: Now unsigned.
1066
2522f049
TT		 10672019-11-28 Tom Tromey <tom@tromey.com>
1068
1069 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1070 declare.
1071
38b49e22
MS		 10722019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1073
1074 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1075 debug output.
1076 * jit.c (jit_unregister_code): Add debug print to match
1077 `jit_register_code`.
1078
35125921
CB		 10792019-11-27 Christian Biesinger <cbiesinger@google.com>
1080
1081 * NEWS: Mention the new multithreaded symbol loading.
1082
62e77f56
CB		 10832019-11-27 Christian Biesinger <cbiesinger@google.com>
1084
1085 * maint.c (n_worker_threads): Default to 0.
1086 (worker_threads_disabled): New function.
1087 * maint.h (worker_threads_disabled): New function.
1088 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1089 here if worker_threads_disabled () is true.
1090 (minimal_symbol_reader::install): Skip all threading if
1091 worker_threads_disabled () is true.
1092
f29d7f6b
CB		 10932019-11-27 Christian Biesinger <cbiesinger@google.com>
1094
1095 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1096 hash code if possible.
1097 (add_minsym_to_demangled_hash_table): Likewise.
1098 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1099 on the background thread.
1100 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1101 Add these fields.
1102
e76b2246
CB		 11032019-11-27 Christian Biesinger <cbiesinger@google.com>
1104
1105 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1106 of the mangled name on the background thread.
1107 * symtab.c (symbol_set_names): Allow passing in the hash of the
1108 linkage_name.
1109 * symtab.h (symbol_set_names): Likewise.
1110
8d9a2568
KB		 11112019-11-27 Kevin Buettner <kevinb@redhat.com>
1112
1113 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1114 physnames are computed for inherited DIEs.
1115
fad03f6e
TT		 11162019-11-27 Tom Tromey <tromey@adacore.com>
1117
1118 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1119 backslashes.
1120 * cp-support.c: Remove unnecessary backslashes.
1121
43678b0a
CB		 11222019-11-27 Christian Biesinger <cbiesinger@google.com>
1123
1124 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1125 with sym->set_linkage_name.
1126 * coffread.c (coff_read_enum_type): Likewise.
1127 * mdebugread.c (parse_symbol): Likewise.
1128 * stabsread.c (patch_block_stabs): Likewise.
1129 (define_symbol): Likewise.
1130 (read_enum_type): Likewise.
1131 (common_block_end): Likewise.
1132 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1133 function.
1134 (SYMBOL_SET_LINKAGE_NAME): Remove.
1135 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1136 with sym->set_linkage_name.
1137
db5960b4
AB		 11382019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1139
1140 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1141 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1142 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1143 * NEWS: Mention new MI command.
1144
7dc42066
AB		 11452019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1146
1147 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1148 '-symbol-info-types', and '-symbol-info-variables'.
1149 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1150 (mi_cmd_symbol_info_types): Declare.
1151 (mi_cmd_symbol_info_variables): Declare.
1152 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1153 (output_debug_symbol): New function.
1154 (output_nondebug_symbol): New function.
1155 (mi_symbol_info): New function.
1156 (mi_info_functions_or_variables): New function.
1157 (mi_cmd_symbol_info_functions): New function.
1158 (mi_cmd_symbol_info_types): New function.
1159 (mi_cmd_symbol_info_variables): New function.
1160 * NEWS: Mention new commands.
1161
5f512a7d
AB		 11622019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1163
1164 * symtab.c (symbol_to_info_string): New function, most content
1165 moved from print_symbol_info, but updated to return a std::string.
1166 (print_symbol_info): Update to use symbol_to_info_string and print
1167 returned string.
1168 * symtab.h (symbol_to_info_string): Declare new function.
1169
470c0b1c
AB		 11702019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1171
1172 * python/python.c (gdbpy_rbreak): Convert to using
1173 global_symbol_searcher.
1174 * symtab.c (file_matches): Convert return type to bool, change
1175 file list to std::vector, update header comment.
1176 (search_symbols): Rename to...
1177 (global_symbol_searcher::search): ...this and update now its
1178 a member function of global_symbol_searcher. Take account of the
1179 changes to file_matches.
1180 (symtab_symbol_info): Convert to using global_symbol_searcher.
1181 (rbreak_command): Likewise.
1182 (search_module_symbols): Likewise.
1183 * symtab.h (enum symbol_search): Update comment.
1184 (search_symbols): Remove declaration.
1185 (class global_symbol_searcher): New class.
1186
57357d9d
TT		 11872019-11-26 Tom Tromey <tromey@adacore.com>
1188
1189 * cp-support.c (_initialize_cp_support): Conditionally initialize
1190 gdb_demangle_attempt_core_dump.
1191
3ea16160
TT		 11922019-11-26 Tom Tromey <tom@tromey.com>
1193
1194 * python/py-function.c (fnpy_init): Update.
1195 * value.h (add_internal_function): Adjust declaration.
1196 * value.c (function_destroyer): Remove.
1197 (do_add_internal_function): Don't set destroyer or copy name.
1198 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1199 Set name_allocated.
1200 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1201 (cmdpy_init): Set name_allocated.
1202 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1203 member.
1204 (~cmd_list_element): Free "name" if needed.
1205
1a6d41c6
TT		 12062019-11-26 Tom Tromey <tom@tromey.com>
1207
1208 * value.h (add_internal_function): Add new overload. Move
1209 documentation from value.h.
1210 * value.c (do_add_internal_function): New function.
1211 (add_internal_function): Use it. Add new overload.
1212 (function_destroyer): Don't free doc.
1213 * python/py-function.c (fnpy_init): Update.
1214
8318f3c3
TT		 12152019-11-26 Tom Tromey <tom@tromey.com>
1216
1217 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1218 (cmdpy_init): Set "doc_allocated".
1219
4da8c3a8
TT		 12202019-11-26 Tom Tromey <tom@tromey.com>
1221
1222 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1223 name of worker thread.
1224 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1225 pthread_setname_np.
1226 * configure, config.in: Rebuild.
1227
971db5e2
TT		 12282019-11-26 Tom Tromey <tom@tromey.com>
1229
1230 * python/python.c (class gdbpy_gil): New.
1231 (struct gdbpy_event): Add constructor, destructor, operator().
1232 (gdbpy_post_event): Use run_on_main_thread.
1233 (gdbpy_initialize_events): Remove.
1234 (do_start_initialization): Update.
1235
22138db6
TT		 12362019-11-26 Tom Tromey <tom@tromey.com>
1237
1238 * NEWS: Add entry.
1239 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1240 commands. Call update_thread_pool_size.
1241 (update_thread_pool_size, maintenance_set_worker_threads): New
1242 functions.
1243 (n_worker_threads): New global.
1244
d55c9a68
TT		 12452019-11-26 Christian Biesinger <cbiesinger@google.com>
1246 Tom Tromey <tom@tromey.com>
1247
1248 * minsyms.c (minimal_symbol_reader::install): Use
1249 parallel_for_each.
1250 * gdbsupport/parallel-for.h: New file.
1251 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1252
a0b57563
CB		 12532019-11-26 Christian Biesinger <cbiesinger@google.com>
1254 Tom Tromey <tom@tromey.com>
1255
1256 * gdbsupport/thread-pool.h: New file.
1257 * gdbsupport/thread-pool.c: New file.
1258 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1259 (HFILES_NO_SRCDIR): Add thread-pool.h.
1260
3b3978bc
TT		 12612019-11-26 Tom Tromey <tom@tromey.com>
1262
1263 * event-top.h (thread_local_segv_handler): Declare.
1264 * event-top.c (thread_local_segv_handler): New global.
1265 (install_handle_sigsegv, handle_sigsegv): New functions.
1266 (async_init_signals): Install SIGSEGV handler.
1267 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1268 thread-local.
1269 (report_failed_demangle): New function.
1270 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1271 handler-setting code, instead use segv_handler. Run warning code
1272 on main thread.
1273
9411c49e
TT		 12742019-11-26 Tom Tromey <tom@tromey.com>
1275
1276 * run-on-main-thread.c: New file.
1277 * run-on-main-thread.h: New file.
1278 * unittests/main-thread-selftests.c: New file.
1279 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1280 main-thread-selftests.c.
1281 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1282 (COMMON_SFILES): Add run-on-main-thread.c.
1283
c3efb965
TT		 12842019-11-26 Tom Tromey <tom@tromey.com>
1285
1286 * main.c (setup_alternate_signal_stack): Remove.
1287 (captured_main_1): Use gdb::alternate_signal_stack.
1288 * gdbsupport/alt-stack.h: New file.
1289
21987b9c
TT		 12902019-11-26 Tom Tromey <tom@tromey.com>
1291
1292 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1293 Remove comment.
1294 (save_original_signals_state, restore_original_signals_state): Use
1295 gdb_sigmask.
1296 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1297 (_initialize_linux_nat): Use gdb_sigmask.
1298 * guile/guile.c (_initialize_guile): Use block_signals.
1299 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1300 * gdbsupport/gdb-sigmask.h: New file.
1301 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1302 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1303 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1304 pthread_sigmask.
1305 * configure, config.in: Rebuild.
1306 * gdbsupport/block-signals.h: New file.
1307
5e030278
TT		 13082019-11-26 Tom Tromey <tom@tromey.com>
1309
1310 * acinclude.m4: Include ax_pthread.m4.
1311 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1312 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1313 (CLIBS): Use PTHREAD_LIBS.
1314 (aclocal_m4_deps): Add ax_pthread.m4.
1315 * config.in, configure: Rebuild.
1316 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1317
5a79c107
TT		 13182019-11-26 Tom Tromey <tom@tromey.com>
1319
1320 * symtab.h (struct minimal_symbol) <name_set>: New member.
1321 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1322 Don't call symbol_set_names.
1323 (minimal_symbol_reader::install): Call symbol_set_names.
1324
aa369509
PW		 13252019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1326
1327 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1328 restore_active_ext_lang, as GIL is needed for (indirectly)
1329 called PyOS_InterruptOccurred.
1330
cadc9cb8
SM		 13312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1332
1333 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1334 definition.
1335
d04afd58
SM		 13362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1337
1338 * remote-sim.c (simulator_command): Make static, remove
1339 declaration.
1340
dd694d77
SM		 13412019-11-26 Simon Marchi <simon.marchi@efficios.com>
1342
1343 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1344 static.
1345 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1346 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1347 (main): Likewise.
1348 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1349 (main): Likewise.
1350 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1351 (main): Likewise.
1352 * unittests/basic_string_view/element_access/char/1.cc (test01):
1353 Likewise.
1354 (main): Likewise.
1355 * unittests/basic_string_view/element_access/char/empty.cc (main):
1356 Likewise.
1357 * unittests/basic_string_view/element_access/char/front_back.cc
1358 (test01): Likewise.
1359 (main): Likewise.
1360 * unittests/basic_string_view/inserters/char/2.cc (test05):
1361 Likewise.
1362 (main): Likewise.
1363 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1364 (test01): Likewise.
1365 (main): Likewise.
1366 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1367 (test01): Likewise.
1368 (main): Likewise.
1369 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1370 Likewise.
1371 * unittests/basic_string_view/operations/compare/char/1.cc
1372 (test01): Likewise.
1373 (main): Likewise.
1374 * unittests/basic_string_view/operations/compare/char/13650.cc
1375 (test01): Likewise.
1376 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1377 Likewise.
1378 (main): Likewise.
1379 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1380 Likewise.
1381 (main): Likewise.
1382 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1383 Likewise.
1384 (main): Likewise.
1385 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1386 Likewise.
1387 (main): Likewise.
1388 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1389 Likewise.
1390 (main): Likewise.
1391 * unittests/basic_string_view/operations/find/char/4.cc (main):
1392 Likewise.
1393 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1394 Likewise.
1395 (main): Likewise.
1396 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1397 Likewise.
1398 (main): Likewise.
1399 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1400 Likewise.
1401 (main): Likewise.
1402 * unittests/basic_string_view/operations/substr/char/1.cc
1403 (test01): Likewise.
1404 (main): Likewise.
1405 * unittests/basic_string_view/operators/char/2.cc (main):
1406 Likewise.
1407 * unittests/optional/assignment/1.cc (test): Likewise.
1408 * unittests/optional/assignment/2.cc (test): Likewise.
1409 * unittests/optional/assignment/3.cc (test): Likewise.
1410 * unittests/optional/assignment/4.cc (test): Likewise.
1411 * unittests/optional/assignment/5.cc (test): Likewise.
1412 * unittests/optional/assignment/6.cc (test): Likewise.
1413 * unittests/optional/assignment/7.cc (test): Likewise.
1414 * unittests/optional/cons/copy.cc (test): Likewise.
1415 * unittests/optional/cons/default.cc (test): Likewise.
1416 * unittests/optional/cons/move.cc (test): Likewise.
1417 * unittests/optional/cons/value.cc (test): Likewise.
1418 * unittests/optional/in_place.cc (test): Likewise.
1419 * unittests/optional/observers/1.cc (test): Likewise.
1420 * unittests/optional/observers/2.cc (test): Likewise.
1421
3b5c1d49
SM		 14222019-11-26 Simon Marchi <simon.marchi@efficios.com>
1423
1424 * tui-win.h (tui_set_var_cmd): Remove.
1425 * tui-win.c (tui_set_var_cmd): Make static.
1426
adce99fe
SM		 14272019-11-26 Simon Marchi <simon.marchi@efficios.com>
1428
1429 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1430 rbreak_command_wrapper): Remove.
1431 * symtab.c (rbreak_command_wrapper): Remove.
1432
fe3adccf
SM		 14332019-11-26 Simon Marchi <simon.marchi@efficios.com>
1434
1435 * inferior.h (info_terminal_command): Remove declaration.
1436 * inflow.c (info_terminal_command): Make static.
1437
b926335f
SM		 14382019-11-26 Simon Marchi <simon.marchi@efficios.com>
1439
1440 * inferior.c (exit_inferior_silent): Remove.
1441
b62f6f54
SM		 14422019-11-26 Simon Marchi <simon.marchi@efficios.com>
1443
1444 * dictionary.c (dict_empty, mdict_empty): Remove.
1445 * dictionary.c (mdict_empty): Remove.
1446
cb8c24b6
SM		 14472019-11-26 Simon Marchi <simon.marchi@efficios.com>
1448
1449 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1450 (arc_insn_get_memory_offset): Likewise.
1451 (arc_insn_dump): Likewise.
1452 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1453 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1454 * dictionary.c (dict_iterator_next): Likewise.
1455 (dict_iter_match_first): Likewise.
1456 (dict_iter_match_next): Likewise.
1457 * f-lang.c (evaluate_subexp_f): Likewise.
1458 * hppa-tdep.c (hppa_read_pc): Likewise.
1459 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1460 * parse.c (write_exp_elt_msym): Likewise.
1461 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1462 * remote.c (remote_packet_size): Likewise.
1463 (remote_notif_stop_parse): Likewise.
1464 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1465 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1466 * source.c (prepare_path_for_appending): Likewise.
1467 * sparc64-linux-tdep.c
1468 (sparc64_linux_handle_segmentation_fault); Likewise.
1469 * stack.c (frame_selection_by_function_completer): Likewise.
1470
781597ff
SM		 14712019-11-26 Simon Marchi <simon.marchi@efficios.com>
1472
1473 * completer.c (set_gdb_completion_word_break_characters):
1474 Remove.
1475
23baa4cc
SM		 14762019-11-26 Simon Marchi <simon.marchi@efficios.com>
1477
1478 * dwarf-index-write.c: Include dwarf-index-write.h.
1479 * mi/mi-interp.c: Include mi/mi-interp.h.
1480
23767560
SM		 14812019-11-26 Simon Marchi <simon.marchi@efficios.com>
1482
1483 * aarch32-tdep.c: Include aarch32-tdep.h.
1484 * aarch32-tdep.h: Forward-declare struct target_desc.
1485
6d91ce9a
CB		 14862019-11-26 Christian Biesinger <cbiesinger@google.com>
1487
1488 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1489 strerror.
1490 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1491 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1492
3cf2f237
TV		 14932019-11-25 Tom de Vries <tdevries@suse.de>
1494
1495 * contrib/words.sh: Add -c option.
1496
5b89c67a
CB		 14972019-11-25 Christian Biesinger <cbiesinger@google.com>
1498
1499 * solib.c (solib_find_1): Change int to bool.
1500 (exec_file_find): Change int to bool.
1501 (solib_find): Change int to bool.
1502 (solib_read_symbols): Change int to bool.
1503 (solib_used): Change int to bool.
1504 (solib_add): Change int to bool.
1505 (info_sharedlibrary_command): Change int to bool.
1506 (solib_contains_address_p): Change int to bool.
1507 (solib_keep_data_in_core): Change int to bool.
1508 (in_solib_dynsym_resolve_code): Change int to bool.
1509 (reload_shared_libraries_1): Change int to bool.
1510 (gdb_sysroot_changed): Change int to bool.
1511 * solib.h (solib_read_symbols): Change int to bool.
1512 (solib_contains_address_p): Change int to bool.
1513 (solib_keep_data_in_core): Change int to bool.
1514 (in_solib_dynsym_resolve_code): Change int to bool.
1515 (libpthread_name_p): Change int to bool.
1516
6cc8564b
LM		 15172019-11-25 Luis Machado <luis.machado@linaro.org>
1518
1519 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1520 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1521 (remote_packet_max_chars): New static global.
1522 (show_remote_packet_max_chars): New function.
1523 (remote_target::putpkt_binary): Adjust to use new
1524 remote_packet_max_chars option.
1525 (remote_target::getpkt_or_notif_sane_1): Likewise.
1526 (_initialize_remote): Register new remote-packet-max-chars option.
1527
a7cdaa91
SM		 15282019-11-24 Simon Marchi <simon.marchi@efficios.com>
1529
1530 * m68k-linux-nat.c: Include gdbarch.h.
1531
26abc753
TT		 15322019-11-24 Tom Tromey <tom@tromey.com>
1533
1534 * symfile.c (read_symbols): Update.
1535 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1536 bool.
1537 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1538 (psym_lookup_symbol, psym_find_last_source_symtab)
1539 (psym_forget_cached_source_info, psym_print_stats)
1540 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1541 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1542 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1543 (psym_find_compunit_symtab_by_address)
1544 (maintenance_print_psymbols, maintenance_info_psymtabs)
1545 (maintenance_check_psymtabs): Update.
1546 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1547 bool.
1548
012fc909
TT		 15492019-11-22 Tom Tromey <tom@tromey.com>
1550
1551 * observable.h: Update comments.
1552
c83d8d32
TT		 15532019-11-22 Tom Tromey <tromey@adacore.com>
1554
1555 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1556 (print_ada_task_info): Don't try to fetch thread id if task is not
1557 alive.
1558
987012b8
CB		 15592019-11-22 Christian Biesinger <cbiesinger@google.com>
1560
1561 * ada-exp.y: Update.
1562 * ada-lang.c (sort_choices): Update.
1563 (ada_print_symbol_signature): Update.
1564 (resolve_subexp): Update.
1565 (ada_parse_renaming): Update.
1566 (ada_read_renaming_var_value): Update.
1567 (lesseq_defined_than): Update.
1568 (remove_extra_symbols): Update.
1569 (remove_irrelevant_renamings): Update.
1570 (ada_add_block_symbols): Update.
1571 (ada_collect_symbol_completion_matches): Update.
1572 (ada_is_renaming_symbol): Update.
1573 (aggregate_assign_from_choices): Update.
1574 (ada_evaluate_subexp): Update.
1575 (ada_has_this_exception_support): Update.
1576 (ada_is_non_standard_exception_sym): Update.
1577 (ada_add_exceptions_from_frame): Update.
1578 (ada_add_global_exceptions): Update.
1579 (ada_print_subexp): Update.
1580 * ax-gdb.c (gen_var_ref): Update.
1581 (gen_maybe_namespace_elt): Update.
1582 (gen_expr_for_cast): Update.
1583 (gen_expr): Update.
1584 * block.h: Update.
1585 * blockframe.c (find_pc_partial_function): Update.
1586 * breakpoint.c (print_breakpoint_location): Update.
1587 (update_static_tracepoint): Update.
1588 * btrace.c (ftrace_print_function_name): Update.
1589 (ftrace_function_switched): Update.
1590 * buildsym.c (find_symbol_in_list): Update.
1591 * c-exp.y: Update.
1592 * c-typeprint.c (c_print_typedef): Update.
1593 (c_type_print_template_args): Update.
1594 * cli/cli-cmds.c (edit_command): Update.
1595 (list_command): Update.
1596 (print_sal_location): Update.
1597 * coffread.c (patch_opaque_types): Update.
1598 (process_coff_symbol): Update.
1599 (coff_read_enum_type): Update.
1600 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1601 (convert_one_symbol): Update.
1602 (hash_symname): Update.
1603 (eq_symname): Update.
1604 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1605 * compile/compile-cplus-types.c (debug_print_scope): Update.
1606 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1607 * compile/compile-object-load.c (get_out_value_type): Update.
1608 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1609 (search_symbol_list): Update.
1610 (cp_lookup_symbol_imports_or_template): Update.
1611 * cp-support.c (overload_list_add_symbol): Update.
1612 * ctfread.c (psymtab_to_symtab): Update.
1613 * dbxread.c (cp_set_block_scope): Update.
1614 * dictionary.c (iter_match_first_hashed): Update.
1615 (iter_match_next_hashed): Update.
1616 (insert_symbol_hashed): Update.
1617 (iter_match_next_linear): Update.
1618 * dictionary.h: Update.
1619 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1620 (locexpr_describe_location_piece): Update.
1621 (locexpr_describe_location_1): Update.
1622 (locexpr_generate_c_location): Update.
1623 (loclist_describe_location): Update.
1624 (loclist_generate_c_location): Update.
1625 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1626 (read_func_scope): Update.
1627 (process_enumeration_scope): Update.
1628 (new_symbol): Update.
1629 (dwarf2_const_value): Update.
1630 (dwarf2_symbol_mark_computed): Update.
1631 * eval.c (evaluate_funcall): Update.
1632 (evaluate_subexp_standard): Update.
1633 * expprint.c (print_subexp_standard): Update.
1634 (dump_subexp_body_standard): Update.
1635 * f-valprint.c (info_common_command_for_block): Update.
1636 * findvar.c (get_hosting_frame): Update.
1637 (default_read_var_value): Update.
1638 * go-lang.c (go_symbol_package_name): Update.
1639 * guile/scm-block.c (bkscm_print_block_smob): Update.
1640 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1641 (gdbscm_symbol_name): Update.
1642 (gdbscm_symbol_linkage_name): Update.
1643 (gdbscm_symbol_print_name): Update.
1644 * infcall.c (get_function_name): Update.
1645 * infcmd.c (jump_command): Update.
1646 (finish_command): Update.
1647 * infrun.c (insert_exception_resume_breakpoint): Update.
1648 * linespec.c (canonicalize_linespec): Update.
1649 (create_sals_line_offset): Update.
1650 (convert_linespec_to_sals): Update.
1651 (complete_label): Update.
1652 (find_label_symbols_in_block): Update.
1653 * m2-typeprint.c (m2_print_typedef): Update.
1654 * mdebugread.c (mdebug_reg_to_regnum): Update.
1655 (parse_symbol): Update.
1656 (mylookup_symbol): Update.
1657 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1658 (list_args_or_locals): Update.
1659 * objc-lang.c (compare_selectors): Update.
1660 (info_selectors_command): Update.
1661 (compare_classes): Update.
1662 (info_classes_command): Update.
1663 (find_imps): Update.
1664 * p-typeprint.c (pascal_print_typedef): Update.
1665 * printcmd.c (build_address_symbolic): Update.
1666 (info_address_command): Update.
1667 (print_variable_and_value): Update.
1668 * python/py-framefilter.c (extract_sym): Update.
1669 (py_print_single_arg): Update.
1670 * python/py-symbol.c (sympy_str): Update.
1671 (sympy_get_name): Update.
1672 (sympy_get_linkage_name): Update.
1673 * python/python.c (gdbpy_rbreak): Update.
1674 * record-btrace.c (btrace_get_bfun_name): Update.
1675 (btrace_call_history): Update.
1676 * rust-lang.c (rust_print_typedef): Update.
1677 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1678 * stabsread.c (stab_reg_to_regnum): Update.
1679 (define_symbol): Update.
1680 (read_enum_type): Update.
1681 (common_block_end): Update.
1682 (cleanup_undefined_types_1): Update.
1683 (scan_file_globals): Update.
1684 * stack.c (print_frame_arg): Update.
1685 (print_frame_args): Update.
1686 (find_frame_funname): Update.
1687 (info_frame_command_core): Update.
1688 (iterate_over_block_locals): Update.
1689 (print_block_frame_labels): Update.
1690 (do_print_variable_and_value): Update.
1691 (iterate_over_block_arg_vars): Update.
1692 (return_command): Update.
1693 * symmisc.c (dump_symtab_1): Update.
1694 (print_symbol): Update.
1695 * symtab.c (eq_symbol_entry): Update.
1696 (symbol_cache_dump): Update.
1697 (lookup_language_this): Update.
1698 (find_pc_sect_line): Update.
1699 (skip_prologue_sal): Update.
1700 (symbol_search::compare_search_syms): Update.
1701 (treg_matches_sym_type_name): Update.
1702 (search_symbols): Update.
1703 (print_symbol_info): Update.
1704 (rbreak_command): Update.
1705 (completion_list_add_symbol): Update.
1706 (find_gnu_ifunc): Update.
1707 (get_symbol_address): Update.
1708 (search_module_symbols): Update.
1709 (info_module_subcommand): Update.
1710 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1711 (SYMBOL_LINKAGE_NAME): Remove.
1712 (SYMBOL_DEMANGLED_NAME): Remove.
1713 (SYMBOL_PRINT_NAME): Remove.
1714 (SYMBOL_SEARCH_NAME): Remove.
1715 * tracepoint.c (set_traceframe_context): Update.
1716 (validate_actionline): Update.
1717 (collection_list::collect_symbol): Update.
1718 (encode_actions_1): Update.
1719 (info_scope_command): Update.
1720 (print_one_static_tracepoint_marker): Update.
1721 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1722 * valops.c (address_of_variable): Update.
1723 (find_overload_match): Update.
1724 (find_oload_champ): Update.
1725
c9d95fa3
CB		 17262019-11-22 Christian Biesinger <cbiesinger@google.com>
1727
1728 * ada-lang.c (ada_lookup_simple_minsym): Update.
1729 (ada_collect_symbol_completion_matches): Update.
1730 * ada-tasks.c (read_atcb): Update.
1731 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1732 (amd64_windows_skip_trampoline_code): Update.
1733 * arm-tdep.c (skip_prologue_function): Update.
1734 (arm_skip_stack_protector): Update.
1735 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1736 (arm_wince_skip_main_prologue): Update.
1737 * ax-gdb.c (gen_expr): Update.
1738 * block.c (call_site_for_pc): Update.
1739 * blockframe.c (find_pc_partial_function): Update.
1740 * breakpoint.c (set_breakpoint_location_function): Update.
1741 * btrace.c (ftrace_print_function_name): Update.
1742 (ftrace_function_switched): Update.
1743 * c-valprint.c (print_unpacked_pointer): Update.
1744 * coffread.c (coff_symfile_read): Update.
1745 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1746 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1747 * dwarf-index-write.c (write_psymbols): Update.
1748 * dwarf2loc.c (call_site_to_target_addr): Update.
1749 (func_verify_no_selftailcall): Update.
1750 (tailcall_dump): Update.
1751 (call_site_find_chain_1): Update.
1752 (dwarf_expr_reg_to_entry_parameter): Update.
1753 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1754 * eval.c (evaluate_funcall): Update.
1755 (evaluate_subexp_standard): Update.
1756 (evaluate_subexp_for_sizeof): Update.
1757 * expprint.c (print_subexp_standard): Update.
1758 (dump_subexp_body_standard): Update.
1759 * frame.c (get_prev_frame_always_1): Update.
1760 * frv-tdep.c (frv_skip_main_prologue): Update.
1761 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1762 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1763 (gnuv3_get_typename_from_type_info): Update.
1764 (gnuv3_skip_trampoline): Update.
1765 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1766 * i386-tdep.c (i386_skip_main_prologue): Update.
1767 (i386_pe_skip_trampoline_code): Update.
1768 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1769 * infcall.c (get_function_name): Update.
1770 * linespec.c (minsym_found): Update.
1771 * linux-fork.c (info_checkpoints_command): Update.
1772 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1773 (m32c_m16c_pointer_to_address): Update.
1774 * maint.c (maintenance_translate_address): Update.
1775 * minsyms.c (add_minsym_to_hash_table): Update.
1776 (add_minsym_to_demangled_hash_table): Update.
1777 (lookup_minimal_symbol_mangled): Update.
1778 (lookup_minimal_symbol_demangled): Update.
1779 (lookup_minimal_symbol_linkage): Update.
1780 (lookup_minimal_symbol_text): Update.
1781 (lookup_minimal_symbol_by_pc_name): Update.
1782 (minimal_symbol_is_less_than): Update.
1783 (compact_minimal_symbols): Update.
1784 (build_minimal_symbol_hash_tables): Update.
1785 (find_solib_trampoline_target): Update.
1786 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1787 (mips_skip_pic_trampoline_code): Update.
1788 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1789 * objc-lang.c (info_selectors_command): Update.
1790 (info_classes_command): Update.
1791 (find_methods): Update.
1792 (find_imps): Update.
1793 * p-valprint.c (pascal_val_print): Update.
1794 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1795 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1796 * printcmd.c (build_address_symbolic): Update.
1797 (info_symbol_command): Update.
1798 * psymtab.c (psymbol_name_matches): Update.
1799 (match_partial_symbol): Update.
1800 (lookup_partial_symbol): Update.
1801 (print_partial_symbols): Update.
1802 (sort_pst_symbols): Update.
1803 (maintenance_check_psymtabs): Update.
1804 * python/py-framefilter.c (py_print_frame): Update.
1805 * python/python.c (gdbpy_rbreak): Update.
1806 * record-btrace.c (btrace_get_bfun_name): Update.
1807 (btrace_call_history): Update.
1808 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1809 (rs6000_skip_trampoline_code): Update.
1810 * sol-thread.c (info_cb): Update.
1811 * stabsread.c (scan_file_globals): Update.
1812 * stack.c (find_frame_funname): Update.
1813 (info_frame_command_core): Update.
1814 * symmisc.c (dump_msymbols): Update.
1815 * symtab.c (symbol_natural_name): Rename to..,
1816 (general_symbol_info::natural_name): ...this.
1817 (symbol_demangled_name): Rename to...
1818 (general_symbol_info::demangled_name): ...this.
1819 (symbol_search_name): Rename to...
1820 (general_symbol_info::search_name): ...this.
1821 (symbol_matches_search_name): Update.
1822 (find_pc_sect_line): Update.
1823 (skip_prologue_sal): Update.
1824 (search_symbols): Update.
1825 (print_msymbol_info): Update.
1826 (rbreak_command): Update.
1827 (completion_list_add_msymbol): Update.
1828 (completion_list_objc_symbol): Update.
1829 (get_msymbol_address): Update.
1830 * symtab.h (struct general_symbol_info): Add member functions
1831 natural_name (), linkage_name (), print_name (), demangled_name (),
1832 and search_name ().
1833 (SYMBOL_NATURAL_NAME): Update.
1834 (symbol_natural_name): Move to a member function on general_symbol_info.
1835 (SYMBOL_DEMANGLED_NAME): Update.
1836 (symbol_demangled_name): Move to a member function on
1837 general_symbol_info.
1838 (SYMBOL_SEARCH_NAME): Update.
1839 (symbol_search_name): Move to a member function on general_symbol_info.
1840 (MSYMBOL_NATURAL_NAME): Remove.
1841 (MSYMBOL_LINKAGE_NAME): Remove.
1842 (MSYMBOL_PRINT_NAME): Remove.
1843 (MSYMBOL_DEMANGLED_NAME): Remove.
1844 (MSYMBOL_SEARCH_NAME): Remove.
1845 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1846
f8bab2d6
CB		 18472019-11-22 Christian Biesinger <cbiesinger@google.com>
1848
1849 * symtab.c (create_demangled_names_hash): Use per_bfd->
1850 minimal_symbol_count for computing the initial size, if greater
1851 than our default size.
1852
85e7588d
TV		 18532019-11-22 Tom de Vries <tdevries@suse.de>
1854
1855 * contrib/words.sh: Improve words extraction.
1856
f6180073
TV		 18572019-11-22 Tom de Vries <tdevries@suse.de>
1858
1859 * contrib/words.sh: Combine sed invocations.
1860
f10ffa41
CB		 18612019-11-21 Christian Biesinger <cbiesinger@google.com>
1862
1863 * Makefile.in: Update.
1864 * demangle.c: Rename to...
1865 * gdb-demangle.c: ..this.
1866 (is_cplus_marker): Change return type to bool.
1867 (_initialize_demangler): Rename to...
1868 (_initialize_gdb_demangle): ...this.
1869 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1870 * symtab.h (demangle): Remove declaration; instead include
1871 gdb-demangle.h.
1872
6ba18521
TT		 18732019-11-21 Tom Tromey <tromey@adacore.com>
1874
1875 * gdbsupport/format.c (format_pieces): Parse %I64d.
1876 * unittests/format_pieces-selftests.c (test_windows_formats): New
1877 function.
1878 (run_tests): Call it.
1879
34877895
PJ		 18802019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1881
1882 Byte reverse display of variables with DW_END_big, DW_END_little
1883 (DW_AT_endianity) dwarf attributes if different than the native
1884 byte order.
1885 * ada-lang.c (ada_value_binop):
1886 Use type_byte_order instead of gdbarch_byte_order.
1887 * ada-valprint.c (printstr):
1888 (ada_val_print_string):
1889 * ada-lang.c (value_pointer):
1890 (ada_value_binop):
1891 Use type_byte_order instead of gdbarch_byte_order.
1892 * c-lang.c (c_get_string):
1893 Use type_byte_order instead of gdbarch_byte_order.
1894 * c-valprint.c (c_val_print_array):
1895 Use type_byte_order instead of gdbarch_byte_order.
1896 * cp-valprint.c (cp_print_class_member):
1897 Use type_byte_order instead of gdbarch_byte_order.
1898 * dwarf2loc.c (rw_pieced_value):
1899 Use type_byte_order instead of gdbarch_byte_order.
1900 * dwarf2read.c (read_base_type): Handle DW_END_big,
1901 DW_END_little
1902 * f-lang.c (f_get_encoding):
1903 Use type_byte_order instead of gdbarch_byte_order.
1904 * findvar.c (default_read_var_value):
1905 Use type_byte_order instead of gdbarch_byte_order.
1906 * gdbtypes.c (check_types_equal):
1907 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1908 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1909 and TYPE_ENDIANITY_LITTLE if set.
1910 (type_byte_order): new function.
1911 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1912 (struct main_type) <flag_endianity_not_default>:
1913 New field.
1914 (type_byte_order): New function.
1915 * infcmd.c (default_print_one_register_info):
1916 Use type_byte_order instead of gdbarch_byte_order.
1917 * p-lang.c (pascal_printstr):
1918 Use type_byte_order instead of gdbarch_byte_order.
1919 * p-valprint.c (pascal_val_print):
1920 Use type_byte_order instead of gdbarch_byte_order.
1921 * printcmd.c (print_scalar_formatted):
1922 Use type_byte_order instead of gdbarch_byte_order.
1923 * solib-darwin.c (darwin_current_sos):
1924 Use type_byte_order instead of gdbarch_byte_order.
1925 * solib-svr4.c (solib_svr4_r_ldsomap):
1926 Use type_byte_order instead of gdbarch_byte_order.
1927 * stap-probe.c (stap_modify_semaphore):
1928 Use type_byte_order instead of gdbarch_byte_order.
1929 * target-float.c (target_float_same_format_p):
1930 Use type_byte_order instead of gdbarch_byte_order.
1931 * valarith.c (scalar_binop):
1932 (value_bit_index):
1933 Use type_byte_order instead of gdbarch_byte_order.
1934 * valops.c (value_cast):
1935 Use type_byte_order instead of gdbarch_byte_order.
1936 * valprint.c (generic_emit_char):
1937 (generic_printstr):
1938 (val_print_string):
1939 Use type_byte_order instead of gdbarch_byte_order.
1940 * value.c (unpack_long):
1941 (unpack_bits_as_long):
1942 (unpack_value_bitfield):
1943 (modify_field):
1944 (pack_long):
1945 (pack_unsigned_long):
1946 Use type_byte_order instead of gdbarch_byte_order.
1947 * findvar.c (unsigned_pointer_to_address):
1948 (signed_pointer_to_address):
1949 (unsigned_address_to_pointer):
1950 (address_to_signed_pointer):
1951 (default_read_var_value):
1952 (default_value_from_register):
1953 Use type_byte_order instead of gdbarch_byte_order.
1954 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1955 Use type_byte_order instead of gdbarch_byte_order.
1956 * riscv-tdep.c (riscv_print_one_register_info):
1957 Use type_byte_order instead of gdbarch_byte_order.
1958
87fb00ea
SM		 19592019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1960
1961 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1962 (current_ui_gdb_stdin_ptr): Likewise.
1963 (current_ui_gdb_stderr_ptr): Likewise.
1964 (current_ui_gdb_stdlog_ptr): Likewise.
1965 (current_ui_current_uiout_ptr): Likewise.
1966 (gen_ret_current_ui_field_ptr): Remove.
1967
65d1cd5f
TV		 19682019-11-21 Tom de Vries <tdevries@suse.de>
1969
1970 PR gdb/24956
1971 * cli/cli-script.c (execute_control_command): Only switch to
1972 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1973
9f6ad286
TT		 19742019-11-19 Tom Tromey <tom@tromey.com>
1975
1976 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1977 Now static. Change type of "name".
1978 (tui_set_win_height_command): Don't copy "arg".
1979 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1980 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1981
435d3d88
AT		 19822019-11-19 Ali Tamur <tamur@google.com>
1983
1984 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1985 "if (attr != nullptr)".
1986 (dwarf2_find_base_address): Likewise.
1987 (dwarf2_build_include_psymtabs): Likewise.
1988 (read_cutu_die_from_dwo): Likewise.
1989 (read_func_scope): Likewise.
1990 (read_call_site_scope): Likewise.
1991 (dwarf2_get_pc_bounds): Likewise.
1992 (dwarf2_record_block_ranges): Likewise.
1993 (dwarf2_add_field): Likewise.
1994 (dwarf2_add_member_fn): Likewise.
1995 (read_structure_type): Likewise.
1996 (read_enumeration_type): Likewise.
1997 (read_array_type): Likewise.
1998 (read_array_order): Likewise.
1999 (read_set_type): Likewise.
2000 (read_common_block): Likewise.
2001 (read_tag_reference_type): Likewise.
2002 (read_tag_string_type): Likewise.
2003 (read_subroutine_type): Likewise.
2004 (read_base_type): Likewise.
2005 (read_subrange_type): Likewise.
2006 (new_symbol): Likewise.
2007 (prepare_one_comp_unit): Likewise.
2008
c9739b6a
TT		 20092019-11-19 Tom Tromey <tromey@adacore.com>
2010
2011 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2012 result in error when DebugActiveProcess fails.
2013
494409bb
SDJ		 20142019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2015 Pedro Alves <palves@redhat.com>
2016
2017 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2018 * target.c (target_stack::push): Call 'unpush' if there's a
2019 target on top of the stack.
2020
2e953aca
PW		 20212019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2022
2023 * python/py-block.c (blpy_dealloc): Call tp_free.
2024 (blpy_block_syms_dealloc): Likewise.
2025 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2026 * python/py-inferior.c (infpy_dealloc): Likewise.
2027 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2028 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2029 * python/py-symbol.c (sympy_dealloc): Likewise.
2030 * python/py-symtab.c (stpy_dealloc): Likewise.
2031 * python/py-type.c (typy_iterator_dealloc): Likewise.
2032
6edc43ec
CB		 20332019-11-18 Christian Biesinger <cbiesinger@google.com>
2034
2035 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2036 constructor instead of using a class initializer.
2037
cd850b40
CB		 20382019-11-15 Christian Biesinger <cbiesinger@google.com>
2039
2040 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2041 * configure: Regenerate.
2042 * configure.ac: Don't source common.host.
2043 * gdbsupport/common.host: Remove.
2044 * gdbsupport/mingw-strerror.c: Remove.
2045 * gdbsupport/posix-strerror.c: Rename to...
2046 * gdbsupport/safe-strerror.c: ...this.
2047
53fea9c7
CB		 20482019-11-15 Christian Biesinger <cbiesinger@google.com>
2049
2050 * maint.c (scoped_command_stats::print_time): Use localtime_r
2051 instead of localtime (provided through gnulib if necessary).
2052 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2053 of ctime.
2054
f8e27d88
CB		 20552019-11-15 Christian Biesinger <cbiesinger@google.com>
2056
2057 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2058 avoid compile errors.
2059
5abebf3c
CB		 20602019-11-15 Christian Biesinger <cbiesinger@google.com>
2061
2062 * config.in: Regenerate.
2063 * configure: Regenerate.
2064 * gdbsupport/common.m4: No longer check for strerror_r.
2065 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2066 POSIX version of strerror_r, now that gnulib provides it if
2067 necessary.
2068
9a351667
CB		 20692019-11-14 Christian Biesinger <cbiesinger@google.com>
2070
2071 * README (`configure' options): Update.
2072
55708e99
TT		 20732019-11-14 Tom Tromey <tromey@adacore.com>
2074
2075 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2076 expected type for the RHS if the LHS is a convenience variable.
2077
4b09bb2e
SM		 20782019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2079
2080 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2081 Provide explicit default and copy constructor.
2082
bd454f8b
PW		 20832019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2084
2085 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2086 only call Py_INCREF (newbp) in the bppy_pending_object case.
2087
d1aa3cf0
TT		 20882019-11-13 Tom Tromey <tromey@adacore.com>
2089
2090 PR build/25182:
2091 * psympriv.h (partial_symbol): Remove static assert.
2092 * symtab.h (general_symbol_info, symbol): Remove static assert.
2093
e06f3d6e
AB		 20942019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2095
2096 * gdbsupport/format.c (format_pieces::format_pieces): Support
2097 printf 'z' size modifier.
2098 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2099 * printcmd.c (ui_printf): Handle size_t_arg.
2100 * ui-out.c (ui_out::vmessage): Likewise.
2101 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2102 function.
2103 (run_tests): Call test_format_int_sizes.
2104
468c0cbb
CB		 21052019-11-12 Christian Biesinger <cbiesinger@google.com>
2106
2107 * ada-exp.y (write_ambiguous_var): Update.
2108 * buildsym.c (add_symbol_to_list): Update.
2109 * dwarf2read.c (read_variable): Update.
2110 (new_symbol): Update.
2111 * jit.c (finalize_symtab): Update.
2112 * language.c (language_alloc_type_symbol): Update.
2113 * symtab.c (fixup_symbol_section): Update.
2114 (initialize_objfile_symbol_1): Move code to...
2115 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2116 (allocate_symbol): Update.
2117 (allocate_template_symbol): Update.
2118 (get_symbol_address): Update.
2119 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2120 of having as a field, and add a constructor.
2121 (SYMBOL_VALUE): Update.
2122 (SYMBOL_VALUE_ADDRESS): Update.
2123 (SET_SYMBOL_VALUE_ADDRESS): Update.
2124 (SYMBOL_VALUE_BYTES): Update.
2125 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2126 (SYMBOL_BLOCK_VALUE): Update.
2127 (SYMBOL_VALUE_CHAIN): Update.
2128 (SYMBOL_LANGUAGE): Update.
2129 (SYMBOL_SECTION): Update.
2130 (SYMBOL_OBJ_SECTION): Update.
2131 (SYMBOL_SET_LANGUAGE): Update.
2132 (SYMBOL_SET_LINKAGE_NAME): Update.
2133 (SYMBOL_SET_NAMES): Update.
2134 (SYMBOL_NATURAL_NAME): Update.
2135 (SYMBOL_LINKAGE_NAME): Update.
2136 (SYMBOL_DEMANGLED_NAME): Update.
2137 (SYMBOL_SEARCH_NAME): Update.
2138 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2139 (struct symbol): Update.
2140 (struct template_symbol): Update.
2141 (struct rust_vtable_symbol): Update.
2142 * xcoffread.c (SYMBOL_DUP): Update.
2143
ed2c82c3
TT		 21442019-11-12 Tom Tromey <tom@tromey.com>
2145
2146 * tui/tui-layout.c (show_layout): Set current_layout.
2147 (show_source_disasm_command, show_data)
2148 (show_source_or_disasm_and_command): Don't set current_layout.
2149
d9fcefd5
TT		 21502019-11-12 Tom Tromey <tom@tromey.com>
2151
2152 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2153
45e42163
TT		 21542019-11-12 Tom Tromey <tom@tromey.com>
2155
2156 * tui/tui-win.c (resize_message): New global.
2157 (show_tui_resize_message): New function.
2158 (tui_async_resize_screen): Print message if requested.
2159 (_initialize_tui_win): Add tui-resize-message setting.
2160 * NEWS: Add entry for new commands.
2161
c86d74cc
TT		 21622019-11-11 Tom Tromey <tom@tromey.com>
2163
2164 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2165 functions.
2166
7b7b9424
CB		 21672019-11-11 Christian Biesinger <cbiesinger@google.com>
2168
2169 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2170
086baaf1
AB		 21712019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2172
2173 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2174 function.
2175 * python/python-internal.h (gdbpy_lookup_static_symbols):
2176 Declare new function.
2177 * python/python.c (python_GdbMethods): Add
2178 gdb.lookup_static_symbols method.
2179 * NEWS: Mention gdb.lookup_static_symbols.
2180
09ff83af
AB		 21812019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2182
2183 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2184 static block of current object file first. Also fix typo in
2185 header comment.
2186
eb2dd8df
AB		 21872019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2188
2189 * stack.c (set_last_displayed_sal): Delete.
2190 (last_displayed_sal_valid): Delete.
2191 (last_displayed_pspace): Delete.
2192 (last_displayed_addr): Delete.
2193 (last_displayed_symtab): Delete.
2194 (last_displayed_line): Delete.
2195 (class last_displayed_symtab_info_type): New.
2196 (last_displayed_symtab_info): New static global variable.
2197 (print_frame_info): Call methods on last_displayed_symtab_info.
2198 (clear_last_displayed_sal): Update header comment, and make use of
2199 last_displayed_symtab_info.
2200 (last_displayed_sal_is_valid): Likewise.
2201 (get_last_displayed_pspace): Likewise.
2202 (get_last_displayed_addr): Likewise.
2203 (get_last_displayed_symtab): Likewise.
2204 (get_last_displayed_line): Likewise.
2205 (get_last_displayed_sal): Likewise.
2206 * stack.h (clear_last_displayed_sal): Update header comment.
2207 (last_displayed_sal_is_valid): Likewise.
2208 (get_last_displayed_pspace): Likewise.
2209 (get_last_displayed_addr): Likewise.
2210 (get_last_displayed_symtab): Likewise.
2211 (get_last_displayed_line): Likewise.
2212 (get_last_displayed_sal): Likewise.
2213
62137775
AB		 22142019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2215
2216 * stack.c (frame_show_address): Convert return type to bool.
2217 * stack.h (frame_show_address): Likewise, and update header
2218 comment.
2219
cf57ad6d
AB		 22202019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2221
2222 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2223 * unittests/vec-utils-selftests.c: New file.
2224 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2225
0b026263
TT		 22262019-11-10 Tom Tromey <tom@tromey.com>
2227
2228 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2229 (tui_highlight_win): Likewise.
2230 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2231 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2232 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2233 Don't set can_highlight.
2234
b049ce2d
TT		 22352019-11-10 Tom Tromey <tom@tromey.com>
2236
2237 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2238 Remove unused declaration.
2239
992a7040
TT		 22402019-11-08 Tom Tromey <tromey@adacore.com>
2241
2242 * top.c (read_command_file): Update.
2243 (command_line_input): Make return type const.
2244 * python/py-gdb-readline.c: Update.
2245 * linespec.c (decode_line_2): Update.
2246 * defs.h (command_line_input): Make return type const.
2247 * cli/cli-script.c (read_next_line): Make return type const.
2248 * ada-lang.c (get_selections): Update.
2249
ca3a04f6
CB		 22502019-11-06 Christian Biesinger <cbiesinger@google.com>
2251
2252 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2253 * mi/mi-main.c (output_cores): Likewise.
2254 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2255 (linux_xfer_osdata_modules): Likewise.
2256 * remote.c (register_remote_support_xml): Likewise.
2257 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2258 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2259
e0eac551
TT		 22602019-11-06 Tom Tromey <tom@tromey.com>
2261
2262 * tui/tui-interp.c: Don't include readline.h.
2263 * tui/tui-hooks.c: Don't include readline.h.
2264 * symmisc.c: Include tilde.h, not readline.h.
2265 * symfile.c: Include tilde.h, not readline.h.
2266 * source.c: Include tilde.h, not readline.h.
2267 * solib.c: Include tilde.h, not readline.h.
2268 * psymtab.c: Include tilde.h, not readline.h.
2269 * exec.c: Include tilde.h, not readline.h.
2270 * corelow.c: Include tilde.h, not readline.h.
2271 * cli/cli-dump.c: Include tilde.h, not readline.h.
2272 * cli/cli-cmds.c: Don't include readline.h.
2273
825165c5
TT		 22742019-11-05 Tom Tromey <tom@tromey.com>
2275
2276 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2277 (tui_disassemble): Set addr_size.
2278 (tui_disasm_window::set_contents): Use addr_size.
2279
91ae903f
TT		 22802019-11-05 Tom Tromey <tom@tromey.com>
2281
2282 * rust-lang.c (rust_language_defn): Update.
2283 * python/py-value.c (valpy_string): Call c_get_string.
2284 * p-lang.c (pascal_language_defn): Update.
2285 * opencl-lang.c (opencl_language_defn): Update.
2286 * objc-lang.c (objc_language_defn): Update.
2287 * m2-lang.c (m2_language_defn): Update.
2288 * language.c (unknown_language_defn, auto_language_defn): Update.
2289 (default_get_string): Remove.
2290 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2291 * go-lang.c (go_language_defn): Update.
2292 * f-lang.c (f_language_defn): Update.
2293 * d-lang.c (d_language_defn): Update.
2294 * c-lang.c (c_language_defn, cplus_language_defn)
2295 (asm_language_defn, minimal_language_defn): Update.
2296 * ada-lang.c (ada_language_defn): Update.
2297 * language.h (struct language_defn) <la_get_string>: Remove.
2298 (LA_GET_STRING): Remove.
2299 (default_get_string): Don't declare.
2300
1df2f9ef
TT		 23012019-11-05 Tom Tromey <tom@tromey.com>
2302
2303 * tui/tui-source.h (struct tui_source_window): Inline
2304 constructor. Remove destructor.
2305 <style_changed, m_observable>: Move to superclass.
2306 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2307 (struct tui_source_window_base): Move private members to end.
2308 <style_changed, m_observable>: Move from tui_source_window.
2309 * tui/tui-winsource.c (tui_copy_source_line): Move from
2310 tui-source.c. Rename from copy_source_line. Add special handling
2311 for negative line number.
2312 (tui_source_window_base::style_changed): Move from
2313 tui_source_window.
2314 (tui_source_window_base): Register observer.
2315 (~tui_source_window_base): New.
2316 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2317 rename.
2318 (tui_source_window::set_contents): Use tui_copy_source_line.
2319 (tui_source_window::tui_source_window): Move to tui-source.h.
2320 (tui_source_window::~tui_source_window): Remove.
2321 (tui_source_window::style_changed): Move to superclass.
2322 * tui/tui-disasm.c (tui_disassemble): Create string file with
2323 styling, when possible. Add "addr_size" parameter.
2324 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2325 Don't compute maximum size.
2326 (len_without_escapes): New function
2327
5d051055
TT		 23282019-11-05 Tom Tromey <tom@tromey.com>
2329
2330 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2331 std::string.
2332 * tui/tui-winsource.c (tui_show_source_line): Update.
2333 * tui/tui-source.c (tui_source_window::set_contents): Update.
2334 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2335
ade7beea
CB		 23362019-11-05 Christian Biesinger <cbiesinger@google.com>
2337
2338 * symtab.h (gdb_static_assert): Put && operator at the beginning
2339 of the line instead of the end.
2340
3573abe1
CB		 23412019-11-04 Christian Biesinger <cbiesinger@google.com>
2342
2343 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2344 and sizeof (symbol).
2345 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2346
dae8b3eb
RO		 23472019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2348
2349 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2350 * configure.host: Mark *-*-solaris2.10* obsolete.
2351 * configure.tgt: Mark Solaris < 11 obsolete.
2352 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2353 Update target triplet.
2354
5df96a4e
TT		 23552019-11-01 Tom Tromey <tromey@adacore.com>
2356
2357 * utils.c (print_sys_errmsg): Simplify.
2358
b7481649
TT		 23592019-11-01 Tom Tromey <tromey@adacore.com>
2360
2361 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2362
e48f6033
CB		 23632019-11-01 Christian Biesinger <cbiesinger@google.com>
2364
2365 * configure: Regenerate.
2366 * configure.ac: Remove check for strerror_r.
2367 * gdbsupport/common.m4: Check for strerror_r.
2368
bd5766ec
LM		 23692019-11-01 Luis Machado <luis.machado@linaro.org>
2370
2371 PR gdb/25124
2372
2373 * arm-tdep.c (arm_per_objfile): Rename to ...
2374 (arm_per_bfd): ... this.
2375 (arm_objfile_data_key): Rename to ...
2376 (arm_bfd_data_key): ... this.
2377 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2378 data.
2379 (arm_record_special_symbol): Likewise.
2380
e1709896
AB		 23812019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2382
2383 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2384 end.
2385 * c-typeprint.c (c_print_typedef): Likewise.
2386 * f-typeprint.c (f_print_typedef): Likewise.
2387 * m2-typeprint.c (m2_print_typedef): Likewise.
2388 * p-typeprint.c (pascal_print_typedef): Likewise.
2389 * rust-lang.c (rust_print_typedef): Likewise.
2390 * symtab.c (print_symbol_info): Print a newline after calling
2391 typedef_print.
2392
165f8965
AB		 23932019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2394
2395 * symtab.c (info_module_cmdlist): New variable.
2396 (info_module_command): New function.
2397 (search_module_symbols): New function.
2398 (info_module_subcommand): New function.
2399 (struct info_modules_var_func_options): New struct.
2400 (info_modules_var_func_options_defs): New variable.
2401 (make_info_modules_var_func_options_def_group): New function.
2402 (info_module_functions_command): New function.
2403 (info_module_variables_command): New function.
2404 (info_module_var_func_command_completer): New function.
2405 (_initialize_symtab): Register new 'info module functions' and
2406 'info module variables' commands.
2407 * symtab.h (typedef symbol_search_in_module): New typedef.
2408 (search_module_symbols): Declare new function.
2409 * NEWS: Mention new commands.
2410
59c35742
AB		 24112019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2412
2413 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2414 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2415 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2416 MODULES_DOMAIN.
2417 (scan_partial_symbols): Only create partial module symbols for non
2418 declarations.
2419 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2420 and MODULES_DOMAIN.
2421 * symtab.c (search_domain_name): Likewise.
2422 (search_symbols): Likewise.
2423 (print_symbol_info): Likewise.
2424 (symtab_symbol_info): Likewise.
2425 (info_modules_command): New function.
2426 (_initialize_symtab): Register 'info modules' command.
2427 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2428 * NEWS: Mention new 'info modules' command.
2429
aed61d02
PW		 24302019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2431
2432 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2433 and $_gdb_maint_setting_str.
2434
9ad9b77d
PW		 24352019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2436
2437 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2438 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2439 (str_value_from_setting, gdb_setting_str_internal_fn)
2440 (gdb_maint_setting_str_internal_fn): New functions.
2441 (_initialize_cli_cmds): Define the new convenience functions.
2442 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2443 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2444
8d6efaa2
CB		 24452019-10-31 Christian Biesinger <cbiesinger@google.com>
2446
2447 * agent.c (set_can_use_agent): When the setting is turned on,
2448 look up agent symbols if we don't have them yet.
2449 (agent_new_objfile): Don't look up agent symbols when the agent
2450 setting is off.
2451
33cb1647
CB		 24522019-10-31 Christian Biesinger <cbiesinger@google.com>
2453
2454 * config.in: Regenerate.
2455
b231e86a
CB		 24562019-10-31 Christian Biesinger <cbiesinger@google.com>
2457
2458 * configure: Regenerate.
2459 * configure.ac: Check for strerror_r.
2460 * gdbsupport/common-utils.h (safe_strerror): Change return value
2461 to const char * and document that this function is now threadsafe.
2462 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2463 thread_local and call strerror_r, if available.
2464 * utils.c (perror_string): Update.
2465 (print_sys_errmsg): Update.
2466
a2726d4f
LM		 24672019-10-31 Luis Machado <luis.machado@linaro.org>
2468
2469 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2470 objfile_key.
2471 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2472 objfile to fetch per-bfd data.
2473 (arm_find_exidx_entry): Likewise.
2474
75cafaa6
CB		 24752019-10-31 Christian Biesinger <cbiesinger@google.com>
2476
2477 * gdbsupport/agent.c (debug_agent): Change type to bool.
2478 (use_agent): Likewise.
2479 (all_agent_symbols_look_up): Likewise.
2480 (agent_loaded_p): Change return value to bool.
2481 (agent_look_up_symbols): Update.
2482 (agent_capability_check): Change return value to bool.
2483 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2484 (debug_agent): Change type to bool.
2485 (use_agent): Likewise.
2486 (agent_capability_check): Change return value to bool.
2487
808590ec
CB		 24882019-10-30 Christian Biesinger <cbiesinger@google.com>
2489
2490 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2491 (build_minimal_symbol_hash_tables): Code to clear the table moved
2492 to clear_minimal_symbol_hash_tables.
2493 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2494 when needed.
2495
f18ad8a1
SM		 24962019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2497
2498 * infcmd.c: Remove includes.
2499 * infrun.c: Remove includes.
2500
de93309a
SM		 25012019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2502
2503 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2504 (grow_vect): Remove declaration.
2505 (ada_type_of_array): Remove declaration.
2506 (ada_update_initial_language): Remove declaration.
2507 (ada_fold_name): Remove declaration.
2508 (ada_fill_in_ada_prototype): Remove declaration.
2509 (user_select_syms): Remove declaration.
2510 (get_selections): Remove declaration.
2511 (ada_tag_type): Remove declaration.
2512 (ada_value_tag): Remove declaration.
2513 (ada_is_others_clause): Remove declaration.
2514 (ada_in_variant): Remove declaration.
2515 (ada_value_struct_elt): Remove declaration.
2516 (ada_attribute_name): Remove declaration.
2517 (ada_system_address_type): Remove declaration.
2518 * ada-lang.c (ada_watch_location_expression): Make static.
2519 (GROW_VECT): Move here from ada-lang.h.
2520 (grow_vect): Make static.
2521 (ada_update_initial_language): Make static.
2522 (ada_fold_name): Make static.
2523 (ada_type_of_array): Make static.
2524 (encoded_ordered_before): Move up.
2525 (sort_choices): Move up.
2526 (print_signatures): Move up.
2527 (ada_print_symbol_signature): Move up.
2528 (get_selections): Move up and make static.
2529 (user_select_syms): Move up and make static.
2530 (ada_value_struct_elt): Move up and make static.
2531 (ada_tag_type): Make static.
2532 (ada_value_tag): Make static.
2533 (ada_is_others_clause): Make static.
2534 (ada_in_variant): Make static.
2535 (ada_attribute_name): Make static.
2536
cdc46a9f
SM		 25372019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2538
2539 * ada-lang.c: Remove includes.
2540 * ada-typeprint.c: Remove includes.
2541 * ada-valprint.c: Remove includes.
2542
90421c56
SM		 25432019-10-29 Simon Marchi <simon.marchi@efficios.com>
2544
2545 * addrmap.c: Add static assertions of type size, moved from
2546 _initialize_addrmap.
2547 (_initialize_addrmap): Remove.
2548
31edb802
CB		 25492019-10-29 Christian Biesinger <cbiesinger@google.com>
2550
2551 * coffread.c (record_minimal_symbol): Update.
2552 (process_coff_symbol): Update.
2553 * dbxread.c (read_dbx_symtab): Update.
2554 * dwarf2read.c (add_partial_symbol): Update.
2555 (fixup_go_packaging): Update.
2556 (load_partial_dies): Update.
2557 (new_symbol): Update.
2558 * elfread.c (record_minimal_symbol): Change signature to use
2559 gdb::string_view instead of name+len.
2560 (elf_symtab_read): Update.
2561 (elf_rel_plt_read): Update.
2562 * mdebugread.c (parse_partial_symbols): Update.
2563 (handle_psymbol_enumerators): Update.
2564 (new_symbol): Update.
2565 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2566 to use gdb::string_view instead of name+len.
2567 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2568 * psympriv.h (add_psymbol_to_list): Likewise.
2569 * psymtab.c (add_psymbol_to_bcache): Likewise.
2570 (add_psymbol_to_list): Likewise.
2571 * stabsread.c (define_symbol): Update.
2572 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2573 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2574 (symbol_set_names): Likewise.
2575 * xcoffread.c (scan_xcoff_symtab): Update.
2576
0c921b21
CB		 25772019-10-29 Christian Biesinger <cbiesinger@google.com>
2578
2579 * symtab.h (symbol_set_names): Document that copy_name must be
2580 set to true for non-nullterminated strings.
2581 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2582 linkage_name if the entry was not found and we need to demangle.
2583
35e65c49
CB		 25842019-10-29 Christian Biesinger <cbiesinger@google.com>
2585
2586 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2587 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2588 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2589 * gdbsupport/gdb_binary_search.h: New file.
2590
ed2a2229
CB		 25912019-10-29 Christian Biesinger <cbiesinger@google.com>
2592
2593 * NEWS: Mention new --with-system-gdbinit-dir option.
2594 * config.in: Regenerate.
2595 * configure: Regenerate.
2596 * configure.ac: Add new option --with-system-gdbinit-dir.
2597 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2598 for a ".gdb" suffix.
2599 * main.c (get_init_files): Change system_gdbinit argument to
2600 a vector and return the files in SYSTEM_GDBINIT_DIR in
2601 addition to SYSTEM_GDBINIT.
2602 (captured_main_1): Update.
2603 (print_gdb_help): Update.
2604 * top.c (print_gdb_configuration): Also print the value of
2605 SYSTEM_GDBINIT_DIR.
2606
87f34879
CB		 26072019-10-28 Christian Biesinger <cbiesinger@google.com>
2608
2609 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2610 that takes gdb::string_view arguments.
2611
30baf67b
TV		 26122019-10-26 Tom de Vries <tdevries@suse.de>
2613
2614 * aarch64-linux-tdep.c: Fix typos in comments.
2615 * aarch64-tdep.c: Same.
2616 * ada-lang.c: Same.
2617 * amd64-nat.c: Same.
2618 * arc-tdep.c: Same.
2619 * arch/aarch64-insn.c: Same.
2620 * block.c: Same.
2621 * breakpoint.h: Same.
2622 * btrace.h: Same.
2623 * c-varobj.c: Same.
2624 * cli/cli-decode.c: Same.
2625 * cli/cli-script.c: Same.
2626 * cli/cli-utils.h: Same.
2627 * coff-pe-read.c: Same.
2628 * coffread.c: Same.
2629 * compile/compile-cplus-symbols.c: Same.
2630 * compile/compile-object-run.c: Same.
2631 * completer.c: Same.
2632 * corelow.c: Same.
2633 * cp-support.c: Same.
2634 * demangle.c: Same.
2635 * dwarf-index-write.c: Same.
2636 * dwarf2-frame.c: Same.
2637 * dwarf2-frame.h: Same.
2638 * eval.c: Same.
2639 * frame-base.h: Same.
2640 * frame.h: Same.
2641 * gdbcmd.h: Same.
2642 * gdbtypes.h: Same.
2643 * gnu-nat.c: Same.
2644 * guile/scm-objfile.c: Same.
2645 * i386-tdep.c: Same.
2646 * i386-tdep.h: Same.
2647 * infcall.c: Same.
2648 * infcall.h: Same.
2649 * linux-nat.c: Same.
2650 * m68k-tdep.c: Same.
2651 * macroexp.c: Same.
2652 * memattr.c: Same.
2653 * mi/mi-cmd-disas.c: Same.
2654 * mi/mi-getopt.h: Same.
2655 * mi/mi-main.c: Same.
2656 * minsyms.c: Same.
2657 * nat/aarch64-sve-linux-sigcontext.h: Same.
2658 * objfiles.h: Same.
2659 * ppc-linux-nat.c: Same.
2660 * ppc-linux-tdep.c: Same.
2661 * ppc-tdep.h: Same.
2662 * progspace.h: Same.
2663 * prologue-value.h: Same.
2664 * python/py-evtregistry.c: Same.
2665 * python/py-instruction.h: Same.
2666 * record-btrace.c: Same.
2667 * record-full.c: Same.
2668 * remote.c: Same.
2669 * rs6000-tdep.c: Same.
2670 * ser-tcp.c: Same.
2671 * sol-thread.c: Same.
2672 * sparc-sol2-tdep.c: Same.
2673 * sparc64-tdep.c: Same.
2674 * stabsread.c: Same.
2675 * symfile.c: Same.
2676 * symtab.h: Same.
2677 * target.c: Same.
2678 * tracepoint.c: Same.
2679 * tui/tui-data.h: Same.
2680 * tui/tui-io.c: Same.
2681 * tui/tui-win.c: Same.
2682 * tui/tui.c: Same.
2683 * unittests/rsp-low-selftests.c: Same.
2684 * user-regs.h: Same.
2685 * utils.c: Same.
2686 * utils.h: Same.
2687 * valarith.c: Same.
2688 * valops.c: Same.
2689 * valprint.c: Same.
2690 * valprint.h: Same.
2691 * value.c: Same.
2692 * value.h: Same.
2693 * varobj.c: Same.
2694 * x86-nat.h: Same.
2695 * xtensa-tdep.c: Same.
2696
1834d45f
AT		 26972019-10-25 Ali Tamur <tamur@google.com>
2698
2699 * charset.c (find_charset_names): Reflect API change.
2700
5396ae17
CB		 27012019-10-25 Christian Biesinger <cbiesinger@google.com>
2702
2703 * symtab.c (struct demangled_name_entry): Change demangled name
2704 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2705 part of the struct anymore.
2706 (symbol_set_names): No longer obstack allocate + copy the demangled
2707 name, just store the allocated name from bfd.
2708
93878f47
TT		 27092019-10-25 Tom Tromey <tromey@adacore.com>
2710
2711 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2712 (bsearch_cie_cmp, add_cie): Remove.
2713 (find_cie): Reimplement.
2714 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2715 (dwarf2_build_frame_info): Update.
2716
7b71fc97
L		 27172019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2718
2719 PR gdb/25126
2720 * symfile.c (reread_symbols): Call forget_cached_source_info to
2721 clear the stale source cache.
2722
cbb5a2ea
CB		 27232019-10-24 Christian Biesinger <cbiesinger@google.com>
2724
2725 * configure: Regenerate.
2726 * configure.ac: Remove code that sets python_has_threads.
2727
71737c43
CB		 27282019-10-24 Christian Biesinger <cbiesinger@google.com>
2729
2730 * config.in: Regenerate.
2731 * configure: Regenerate.
2732 * configure.ac: Remove the code that uses sed to get the python
2733 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2734
33d569b7
AB		 27352019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2736
2737 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2738 error paths.
2739
f16f7b7c
TT		 27402019-10-23 Tom Tromey <tom@tromey.com>
2741
2742 * arc-tdep.c: Remove ".." from include.
2743 * frv-tdep.c: Remove ".." from include.
2744 * lm32-tdep.c: Remove ".." from include.
2745 * microblaze-tdep.c: Remove ".." from include.
2746 * or1k-tdep.h: Remove ".." from include.
2747 * s12z-tdep.c: Remove ".." from include.
2748 * Makefile.in (OPCODES_CFLAGS): Add comment.
2749 (TOP_CFLAGS): New variable.
2750 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2751
6999161a
TT		 27522019-10-23 Tom Tromey <tom@tromey.com>
2753
2754 * Makefile.in (READLINE_DIR): Update.
2755
12e7c35e
TBA		 27562019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2757
2758 * infcall.c (call_function_by_hand_dummy): Fix the function
2759 comment. And extract out a code section into...
2760 (reserve_stack_space): ...this new function.
2761
37055cad
TBA		 27622019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2763
2764 * infcall.c (value_arg_coerce): Remove an unused parameter.
2765 (call_function_by_hand_dummy): Update the call to
2766 'value_arg_coerce'.
2767
39bcc47c
TBA		 27682019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2769
2770 * infcall.c (call_function_by_hand_dummy): Refactor.
2771
bd888c0f
TBA		 27722019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2773
2774 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2775
c12d372d
TT		 27762019-10-23 Tom Tromey <tom@tromey.com>
2777
2778 * configure: Rebuild.
2779 * configure.ac: Don't check for sigprocmask.
2780 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2781
4d0b984b
TT		 27822019-10-23 Tom Tromey <tom@tromey.com>
2783
2784 * configure: Rebuild.
2785 * acinclude.m4: Use m4_include, not sinclude.
2786
7e785608
TV		 27872019-10-23 Tom de Vries <tdevries@suse.de>
2788
2789 PR breakpoints/24687
2790 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2791
403772ef
CB		 27922019-10-22 Christian Biesinger <cbiesinger@google.com>
2793
2794 * symtab.c (struct demangled_name_entry) <language>: Change from
2795 bitfield to regular variable.
2796
3a494279
CB		 27972019-10-22 Christian Biesinger <cbiesinger@google.com>
2798
2799 * symtab.c (struct demangled_name_entry): Add a constructor.
2800 (free_demangled_name_entry): New function to call the destructor
2801 for demangled_name_entry.
2802 (create_demangled_names_hash): Pass free_demangled_name_entry to
2803 htab_create_alloc.
2804 (symbol_set_names): Call placement new for demangled_name_entry.
2805 * utils.c: No longer include xxhash.h here, now that fast_hash
2806 is inlined in the header.
2807 * utils.h: Instead, include it here.
2808
ccb1ba62
CB		 28092019-10-22 Christian Biesinger <cbiesinger@google.com>
2810
2811 * Makefile.in: Link with libxxhash.
2812 * config.in: Regenerate.
2813 * configure: Regenerate.
2814 * configure.ac: Search for libxxhash.
2815 * utils.c (fast_hash): Use xxhash if present.
2816
1a6ff1a9
CB		 28172019-10-22 Christian Biesinger <cbiesinger@google.com>
2818
2819 * utils.h (fast_hash): New function.
2820 * symtab.c (hash_demangled_name_entry): Call new function
2821 fast_hash.
2822
7bb43059
CB		 28232019-10-22 Christian Biesinger <cbiesinger@google.com>
2824
2825 * symtab.c (struct demangled_name_entry): Change type of mangled
2826 to gdb::string_view. Also adds a constructor that takes the
2827 mangled name.
2828 (hash_demangled_name_entry): Update.
2829 (eq_demangled_name_entry): Update.
2830 (free_demangled_name_entry): New function to call the destructor
2831 now that this is not a POD anymore.
2832 (create_demangled_names_hash): Pass free_demangled_name_entry to
2833 htab_create_alloc.
2834 (symbol_set_names): Update.
2835
7ba99d21
AT		 28362019-10-21 Ali Tamur <tamu@google.com>
2837
2838 * dwarf2read.c (dir_index): Change type.
2839 (file_name_index): Likewise.
2840 (line_header::include_dir_at): Change comment and implementation on
2841 whether it is DWARF 5.
2842 (line_header::is_valid_file_index): New function.
2843 (line_header::file_name_at): Change comment and implementation on
2844 whether it is DWARF 5.
2845 (line_header::file_names): Change to private field renamed as
2846 m_file_names and introduce a new accessor method.
2847 (line_header::file_names_size): New method.
2848 (line_header::include_dirs): Change to private field and rename as
2849 m_include_dirs.
2850 (dw2_get_file_names_reader): Define local var at a smaller scope and
2851 reflect API change.
2852 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2853 (process_structure_scope): Likewise.
2854 (line_header::add_include_dir): Change message and reflect renaming.
2855 (line_header::add_file_name): Likewise.
2856 (read_formatted_entries): Handle DW_FORM_data16.
2857 (dwarf_decode_line_header): Fix line header length calculation.
2858 (psymtab_include_file_name): Change comment and API.
2859 (lnp_state_machine::m_file): Update comment and reflect type change.
2860 (lnp_state_machine::record_line): Reflect type change.
2861 (dwarf_decode_lines): Reflect API change.
2862 (file_file_name): Likewise.
2863 (file_full_name): Likewise.
2864
45f47c3a
AB		 28652019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2866
2867 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2868
e5f3c0e3
TT		 28692019-10-21 Tom Tromey <tom@tromey.com>
2870
2871 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2872
a0a461e5
TT		 28732019-10-21 Tom Tromey <tom@tromey.com>
2874
2875 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2876 NM_H. Use AC_CONFIG_LINKS.
2877 * configure: Rebuild.
2878 * Makefile.in (NM_H): New variable.
2879 (generated_files): Add NM_H. Remove gcore.
2880 (nm.h, stamp-nmh): New targets.
2881
54d83b8d
TT		 28822019-10-20 Tom Tromey <tom@tromey.com>
2883
2884 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2885 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2886 obsolete comment.
2887 (put_objfile_before): Now static.
2888
23771117
SM		 28892019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2890
2891 * gdbsupport/common-utils.h (startswith): Change return type to
2892 bool.
2893
39ef2f62
CB		 28942019-10-19 Christian Biesinger <cbiesinger@google.com>
2895
2896 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2897 * breakpoint.c (bp_locations_compare): Rename to...
2898 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2899 (update_global_location_list): Use std::sort instead of qsort.
2900 * buildsym.c (compare_line_numbers): Rename to...
2901 (lte_is_less_than): ...this, and change to std::sort semantics.
2902 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2903 instead of qsort.
2904 * disasm.c (compare_lines): Rename to...
2905 (line_is_less_than): ...this, and change to std::sort semantics.
2906 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2907 of qsort.
2908 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2909 (fde_is_less_than): ...this, and change to std::sort semantics.
2910 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2911 * mdebugread.c (compare_blocks):
2912 (block_is_less_than): ...this, and change to std::sort semantics.
2913 (sort_blocks): Call std::sort instead of qsort.
2914 * objfiles.c (qsort_cmp): Rename to...
2915 (sort_cmp): ...this, and change to std::sort semantics.
2916 (update_section_map): Call std::sort instead of qsort.
2917 * remote.c (compare_pnums): Remove.
2918 (map_regcache_remote_table): Call std::sort instead of qsort.
2919 * utils.c (compare_positive_ints): Remove.
2920 * utils.h (compare_positive_ints): Remove.
2921 * xcoffread.c (compare_lte): Remove.
2922 (arrange_linetable): Call std::sort instead of qsort.
2923
f71433ee
SDJ		 29242019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2925
2926 * symfile.c (init_entry_point_info): Fix typo.
2927 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2928
85102364
TV		 29292019-10-18 Tom de Vries <tdevries@suse.de>
2930
2931 * aarch64-tdep.c: Fix typos in comments.
2932 * ada-lang.c: Same.
2933 * ada-tasks.c: Same.
2934 * alpha-tdep.c: Same.
2935 * alpha-tdep.h: Same.
2936 * amd64-nat.c: Same.
2937 * amd64-windows-tdep.c: Same.
2938 * arc-tdep.c: Same.
2939 * arc-tdep.h: Same.
2940 * arch-utils.c: Same.
2941 * arm-nbsd-tdep.c: Same.
2942 * arm-tdep.c: Same.
2943 * ax-gdb.c: Same.
2944 * blockframe.c: Same.
2945 * btrace.c: Same.
2946 * c-varobj.c: Same.
2947 * coff-pe-read.c: Same.
2948 * coffread.c: Same.
2949 * cris-tdep.c: Same.
2950 * darwin-nat.c: Same.
2951 * dbxread.c: Same.
2952 * dcache.c: Same.
2953 * disasm.c: Same.
2954 * dtrace-probe.c: Same.
2955 * dwarf-index-write.c: Same.
2956 * dwarf2-frame-tailcall.c: Same.
2957 * dwarf2-frame.c: Same.
2958 * dwarf2read.c: Same.
2959 * eval.c: Same.
2960 * exceptions.c: Same.
2961 * fbsd-tdep.c: Same.
2962 * findvar.c: Same.
2963 * frame.c: Same.
2964 * frv-tdep.c: Same.
2965 * gnu-v3-abi.c: Same.
2966 * go32-nat.c: Same.
2967 * h8300-tdep.c: Same.
2968 * hppa-tdep.c: Same.
2969 * i386-linux-tdep.c: Same.
2970 * i386-tdep.c: Same.
2971 * ia64-libunwind-tdep.c: Same.
2972 * ia64-tdep.c: Same.
2973 * infcmd.c: Same.
2974 * infrun.c: Same.
2975 * linespec.c: Same.
2976 * linux-nat.c: Same.
2977 * linux-thread-db.c: Same.
2978 * machoread.c: Same.
2979 * mdebugread.c: Same.
2980 * mep-tdep.c: Same.
2981 * mn10300-tdep.c: Same.
2982 * namespace.c: Same.
2983 * objfiles.c: Same.
2984 * opencl-lang.c: Same.
2985 * or1k-tdep.c: Same.
2986 * osabi.c: Same.
2987 * ppc-linux-nat.c: Same.
2988 * ppc-linux-tdep.c: Same.
2989 * ppc-sysv-tdep.c: Same.
2990 * printcmd.c: Same.
2991 * procfs.c: Same.
2992 * record-btrace.c: Same.
2993 * record-full.c: Same.
2994 * remote-fileio.c: Same.
2995 * remote.c: Same.
2996 * rs6000-tdep.c: Same.
2997 * s12z-tdep.c: Same.
2998 * score-tdep.c: Same.
2999 * ser-base.c: Same.
3000 * ser-go32.c: Same.
3001 * skip.c: Same.
3002 * sol-thread.c: Same.
3003 * solib-svr4.c: Same.
3004 * solib.c: Same.
3005 * source.c: Same.
3006 * sparc-nat.c: Same.
3007 * sparc-sol2-tdep.c: Same.
3008 * sparc-tdep.c: Same.
3009 * sparc64-tdep.c: Same.
3010 * stabsread.c: Same.
3011 * stack.c: Same.
3012 * symfile.c: Same.
3013 * symtab.c: Same.
3014 * target-descriptions.c: Same.
3015 * target-float.c: Same.
3016 * thread.c: Same.
3017 * utils.c: Same.
3018 * valops.c: Same.
3019 * valprint.c: Same.
3020 * value.c: Same.
3021 * varobj.c: Same.
3022 * windows-nat.c: Same.
3023 * xcoffread.c: Same.
3024 * xstormy16-tdep.c: Same.
3025 * xtensa-tdep.c: Same.
3026
c5adaa19
TT		 30272019-10-17 Tom Tromey <tromey@adacore.com>
3028
3029 * configure: Rebuild.
3030 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3031 in AC_CONFIG_FILES invocation.
3032 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3033 new-style config.status invocation.
3034
405feb71
TV		 30352019-10-17 Tom de Vries <tdevries@suse.de>
3036
3037 * arm-nbsd-nat.c: Fix typos in comments.
3038 * arm-tdep.c: Same.
3039 * darwin-nat-info.c: Same.
3040 * dwarf2read.c: Same.
3041 * elfread.c: Same.
3042 * event-top.c: Same.
3043 * findvar.c: Same.
3044 * gdbtypes.c: Same.
3045 * hppa-tdep.c: Same.
3046 * i386-tdep.c: Same.
3047 * jit.c: Same.
3048 * main.c: Same.
3049 * mdebugread.c: Same.
3050 * moxie-tdep.c: Same.
3051 * nto-procfs.c: Same.
3052 * osabi.c: Same.
3053 * ppc-linux-tdep.c: Same.
3054 * remote.c: Same.
3055 * riscv-tdep.c: Same.
3056 * s390-tdep.c: Same.
3057 * sh-tdep.c: Same.
3058 * sparc-linux-tdep.c: Same.
3059 * sparc-nat.c: Same.
3060 * stack.c: Same.
3061 * target-descriptions.c: Same.
3062 * top.c: Same.
3063 * varobj.c: Same.
3064
befcd486
TT		 30652019-10-16 Tom Tromey <tom@tromey.com>
3066
3067 * objfiles.h (struct objfile) <original_name>: Now const.
3068
17bfe554
CB		 30692019-10-16 Christian Biesinger <cbiesinger@google.com>
3070
3071 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3072 pass on to sigsetjmp's second argument.
3073 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3074
950b7495
KS		 30752019-10-16 Keith Seitz <keiths@redhat.com>
3076
3077 PR gdb/23567
3078 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3079 sections whose size is greater than the file size.
3080
ff371ec9
JW		 30812019-10-16 Jim Wilson <jimw@sifive.com>
3082
3083 * riscv-tdep.c (riscv_gcc_target_options): New.
3084 (riscv_gnu_triplet_regexp): New.
3085 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3086 set_gdbarch_gnu_triplet_regexp.
3087
fec4e896
CB		 30882019-10-16 Christian Biesinger <cbiesinger@google.com>
3089
3090 * Makefile.in: Add xml-builtin.h.
3091 * features/feature_to_c.sh: Add an include for xml-builtin.h
3092 to ensure that the compiler checks that the types match.
3093 * xml-builtin.h: New file.
3094 * xml-support.c (fetch_xml_builtin): Add missing const.
3095 * xml-support.h: Remove declaration of xml_builtins.
3096
d10eccaa
TV		 30972019-10-16 Tom de Vries <tdevries@suse.de>
3098
3099 PR tdep/25096
3100 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3101 (amd64_classify_aggregate): ... here.
3102 (amd64_classify_aggregate_field): Handled fiels of nested structs
3103 recursively.
3104
745ff14e
TV		 31052019-10-16 Tom de Vries <tdevries@suse.de>
3106
3107 PR tdep/24104
3108 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3109 that handles 'theclass'.
3110
791b7405
AB		 31112019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3112
3113 * linespec.c (decode_digits_ordinary): Update comment.
3114 * make-target-delegates: No longer need to handle VEC case.
3115 * memrange.c (normalize_mem_ranges): Update comment.
3116 * namespace.c (add_using_directive): Update comment.
3117 * objc-lang.c (uniquify_strings): Update comment.
3118 * ppc-linux-nat.c (struct thread_points): Update comment.
3119 * probe.h (find_probes_in_objfile): Update comment.
3120 * target.h (enum flash_preserve_mode): Update comment.
3121 * varobj.c (varobj_restrict_range): Update comment.
3122 * varobj.h (varobj_list_children): Update comment.
3123
0dc32745
AB		 31242019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3125
3126 * Makefile.in: Remove references to vec.h and vec.c.
3127 * aarch64-tdep.c: No longer include vec.h.
3128 * ada-lang.c: Likewise.
3129 * ada-lang.h: Likewise.
3130 * arm-tdep.c: Likewise.
3131 * ax.h: Likewise.
3132 * breakpoint.h: Likewise.
3133 * charset.c: Likewise.
3134 * cp-support.h: Likewise.
3135 * dtrace-probe.c: Likewise.
3136 * dwarf2read.c: Likewise.
3137 * extension.h: Likewise.
3138 * gdb_bfd.c: Likewise.
3139 * gdbsupport/gdb_vecs.h: Likewise.
3140 * gdbsupport/vec.c: Remove.
3141 * gdbsupport/vec.h: Remove.
3142 * gdbthread.h: Likewise.
3143 * guile/scm-type.c: Likewise.
3144 * inline-frame.c: Likewise.
3145 * machoread.c: Likewise.
3146 * memattr.c: Likewise.
3147 * memrange.h: Likewise.
3148 * namespace.h: Likewise.
3149 * nat/linux-btrace.h: Likewise.
3150 * osdata.c: Likewise.
3151 * parser-defs.h: Likewise.
3152 * progspace.h: Likewise.
3153 * python/py-type.c: Likewise.
3154 * record-btrace.c: Likewise.
3155 * rust-exp.y: Likewise.
3156 * solib-target.c: Likewise.
3157 * stap-probe.c: Likewise.
3158 * target-descriptions.c: Likewise.
3159 * target-memory.c: Likewise.
3160 * target.h: Likewise.
3161 * varobj.c: Likewise.
3162 * varobj.h: Likewise.
3163 * xml-support.h: Likewise.
3164
ae640021
AB		 31652019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3166
3167 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3168 Update for new std::vector based implementation.
3169 (process_psymtab_comp_unit_reader): Likewise.
3170 (scan_partial_symbols): Likewise.
3171 (recursively_compute_inclusions): Likewise.
3172 (compute_compunit_symtab_includes): Likewise.
3173 (process_imported_unit_die): Likewise.
3174 (queue_and_load_dwo_tu): Likewise.
3175 (follow_die_sig_1): Likewise.
3176 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3177 (typedef dwarf2_per_cu_ptr): Remove.
3178 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3179 function.
3180 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3181 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3182 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3183 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3184 std::vector.
3185
55dfc88f
TT		 31862019-10-15 Tom Tromey <tromey@adacore.com>
3187
3188 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3189 TID.
3190
96b49c5e
TT		 31912019-10-15 Tom Tromey <tromey@adacore.com>
3192
3193 * windows-nat.c (windows_nat_target::fetch_registers)
3194 (windows_nat_target::store_registers): Rename "pid" to "tid".
3195
953cff56
TT		 31962019-10-15 Tom Tromey <tromey@adacore.com>
3197
3198 * gdbarch.h, gdbarch.c: Rebuild.
3199 * gdbarch.sh (gcc_target_options): Change return type to
3200 std::string.
3201 * compile/compile.c (get_args): Update.
3202 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3203 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3204 std::string.
3205 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3206 std::string.
3207 * arch-utils.c (default_gcc_target_options): Return std::string.
3208 * arch-utils.h (default_gcc_target_options): Return std::string.
3209 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3210
81e6b8eb
CB		 32112019-10-15 Christian Biesinger <cbiesinger@google.com>
3212
3213 * breakpoint.c (breakpoint_chain): Make static.
3214 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3215 of accessing breakpoint_chain.
3216
95da600f
CB		 32172019-10-15 Christian Biesinger <cbiesinger@google.com>
3218
3219 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3220 to a gdb::function_view and return value to bool.
3221 * breakpoint.h (iterate_over_breakpoints): Likewise.
3222 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3223 (pop_dummy_frame): Update.
3224 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3225 (gdbscm_breakpoints): Update.
3226 * python/py-breakpoint.c (build_bp_list): Update.
3227 (gdbpy_breakpoints): Update.
3228 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3229 Update.
3230 (bpfinishpy_handle_stop): Update.
3231 (bpfinishpy_handle_exit): Update.
3232 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3233 (svr4_update_solib_event_breakpoints): Update.
3234
ba18312d
AA		 32352019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3236
3237 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3238 when unwrapping single-field structs.
3239
6acc1a0b
SM		 32402019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3241
3242 * dwarf2read.c: Remove includes.
3243
284782de
SM		 32442019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3245
3246 * ui-out.c (ui_out::call_do_message): Silence
3247 -Wformat-nonliteral warning.
3248
073bbbb0
SM		 32492019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3250
3251 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3252 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3253 include: readline/tilde.h.
3254
7b9a15e1
CB		 32552019-10-12 Christian Biesinger <cbiesinger@google.com>
3256
3257 * remote.c (remote_target::get_trace_status): Remove declaration of
3258 trace_regblock_size.
3259
cc8dee1f
CB		 32602019-10-12 Christian Biesinger <cbiesinger@google.com>
3261
3262 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3263 (show_user): Remove declaration of cmdlist.
3264 * cli/cli-cmds.h (max_user_call_depth): Declare.
3265 * cli/cli-script.c (execute_user_command): Remove declaration
3266 of max_user_call_depth.
3267
a83d4ef6
JW		 32682019-10-11 Jim Wilson <jimw@sifive.com>
3269
5f93c5a6
JW		 3270 * gdbsupport/print-utils.h (pulongest): Fix comment.
3271 (plongest): Likewise.
3272 (phex): Add missing comment, mention leading zeros.
3273 (phex_nz): Add mention of no leading zeros to comment.
3274
a83d4ef6
JW		 3275 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3276 plongest instead of unsigned long long cast.
3277
26344e0c
CB		 32782019-10-10 Christian Biesinger <cbiesinger@google.com>
3279
3280 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3281 for external_editor_command and gdbtk_test.
3282
c2c440a9
CB		 32832019-10-10 Christian Biesinger <cbiesinger@google.com>
3284
3285 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3286 * varobj.c (varobjdebug): Move comment to...
3287 * varobj.h (varobjdebug): ...here, and declare.
3288
a31bff9d
TT		 32892019-10-09 Tom Tromey <tom@tromey.com>
3290
3291 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3292 erase_data_content.
3293
7523da63
TT		 32942019-10-09 Tom Tromey <tom@tromey.com>
3295
3296 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3297 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3298 * tui/tui-command.c (tui_cmd_window::resize)
3299 (tui_refresh_cmd_win): Update.
3300 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3301 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3302 * tui/tui-data.c (~tui_gen_win_info): Remove.
3303 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3304 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3305 (tui_redisplay_readline, tui_mld_flush)
3306 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3307 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3308 (tui_data_window::erase_data_content)
3309 (tui_data_item_window::rerender)
3310 (tui_data_item_window::refresh_window): Update.
3311 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3312 (box_win, tui_gen_win_info::make_window)
3313 (tui_gen_win_info::make_visible): Update.
3314 (tui_delete_win): Remove.
3315 * tui/tui-winsource.c
3316 (tui_source_window_base::do_erase_source_content): Update.
3317 (tui_show_source_line, tui_source_window_base::update_tab_width)
3318 (tui_source_window_base::update_exec_info): Update.
3319 * tui/tui-data.h (struct curses_deleter): New.
3320 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3321 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3322
a7798e7f
TT		 33232019-10-09 Tom Tromey <tom@tromey.com>
3324
3325 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3326
5c45899e
TT		 33272019-10-09 Tom Tromey <tom@tromey.com>
3328
3329 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3330 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3331
6d7fd9aa
TT		 33322019-10-09 Tom Tromey <tom@tromey.com>
3333
3334 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3335 window height directly.
3336 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3337 declare.
3338 * tui/tui-layout.c (tui_default_win_height): Remove.
3339 (tui_default_win_viewport_height): Remove.
3340
d2dd1084
TT		 33412019-10-09 Tom Tromey <tom@tromey.com>
3342
3343 * tui/tui.h: Remove comments.
3344
cff32449
TV		 33452019-10-09 Tom de Vries <tdevries@suse.de>
3346
3347 * python/lib/gdb/printer/bound_registers.py: Use
3348 '^builtin_type_bound128' as regexp argument for
3349 add_builtin_pretty_printer.
3350
6a25e8a2
CB		 33512019-10-09 Christian Biesinger <cbiesinger@google.com>
3352
3353 * guile/guile.c (guile_extension_script_ops): Remove forward
3354 declaration and mark as static.
3355 (guile_script_ops): Likewise.
3356 (extension_language_guile): Move further down in the file so
3357 it can reference the definitions for guile_{extension_,}script_ops.
3358
6d9d6da4
AA		 33592019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3360
3361 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3362 except SORTL, DFLTCC, and KDSA.
3363
3abea05d
TT		 33642019-10-08 Tom Tromey <tromey@adacore.com>
3365
3366 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3367 (struct safe_symbol_file_add_args): Remove.
3368
dde996e2
TT		 33692019-10-08 Tom Tromey <tromey@adacore.com>
3370
3371 * windows-nat.c: Don't include buildsym-legacy.h.
3372
cd6fdaa1
TT		 33732019-10-08 Tom Tromey <tromey@adacore.com>
3374
3375 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3376
79bb1944
CB		 33772019-10-08 Christian Biesinger <cbiesinger@google.com>
3378
3379 * gdbtypes.c (overload_debug): Move comment to header.
3380 * gdbtypes.h (overload_debug): Declare.
3381 * valops.c: Remove declaration of overload_debug, instead
3382 include gdbtypes.h.
3383
34916edc
CB		 33842019-10-08 Christian Biesinger <cbiesinger@google.com>
3385
3386 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3387 through _().
3388 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3389 move comment...
3390 * language.h (lang_frame_mismatch_warn): ... here. Also add
3391 declaration.
3392 * top.c (lang_frame_mismatch_warn): Remove declaration.
3393 (check_frame_language_change): Pass lang_frame_mismatch_warn
3394 through _().
3395
bad5c026
CB		 33962019-10-07 Christian Biesinger <cbiesinger@google.com>
3397
3398 * c-lang.h (vtbl_ptr_name): Declare.
3399 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3400 it from the header.
3401 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3402
51f1fdc3
CB		 34032019-10-07 Christian Biesinger <cbiesinger@google.com>
3404
3405 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3406 gdb_static_assert.
3407
30d1f018
WP		 34082019-10-07 Weimin Pan <weimin.pan@oracle.com>
3409
606813d5
WP		 3410 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3411 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 3412 * ctfread.c: New file.
3413 * ctfread.h: New file.
3414 * elfread.c: Include ctfread.h.
3415 (struct elfinfo text_p): New member ctfsect.
3416 (elf_locate_sections): Mark CTF section.
3417 (elf_symfile_read): Call elfctf_build_psymtabs.
3418 * Makefile.in (LIBCTF): Add.
3419 (CLIBS): Use it.
3420 (CDEPS): Likewise.
3421 (DIST): Add ctfread.c.
606813d5
WP		 3422
34232019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3424
3425 * ctfread.c (struct nextfield): Renamed to ...
3426 (struct ctf_nextfield): ... this.
3427 (struct field_info): Renamed to ...
3428 (strut ctf_field_info): ... this.
3429 (attach_fields_to_type): Update for renamed structures.
3430 (ctf_add_member_cb): Likewise.
3431 (ctf_add_enum_member_cb): Likewise.
3432 (process_struct_members): Likewise.
3433 (process_enum_type): Likewise.
30d1f018 3434
518fe38c
WP		 34352019-10-07 Weimin Pan <weimin.pan@oracle.com>
3436
3437 * tracectf.h: Rename, was ctf.h.
3438 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3439 * tracefile.c: Likewise.
3440 * tracepoint.c: Remove unused include ctf.h.
3441 * mi/mi-main.c: Likewise.
3442 * Makefile.in Replace ctf.c with tracectf.c.
3443
225f296a
JB		 34442019-10-06 Joel Brobecker <brobecker@adacore.com>
3445
3446 * version.in: Change version number to "9.0.50.DATE-git".
3447
77c2dba3
TT		 34482019-10-03 Tom Tromey <tom@tromey.com>
3449
3450 PR rust/24976:
3451 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3452
179aed7f
AB		 34532019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3454
3455 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3456 cp_search_name_hash.
3457 * NEWS: Add entry about nested function support.
3458
0a4b0913
AB		 34592019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3460 Andrew Burgess <andrew.burgess@embecosm.com>
3461
3462 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3463 for nested static variables when searchin VAR_DOMAIN.
3464 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3465 global scope, update comment.
3466 (add_partial_subprogram): Call add_partial_subprogram recursively
3467 for nested subroutines when processinng Fortran.
3468 (load_partial_dies): Process the child entities of a subprogram
3469 when processing Fortran.
3470 (partial_die_parent_scope): Handle building scope
3471 for Fortran nested functions.
3472 (process_die): Record that nested functions have a scope.
3473 (new_symbol): Always record Fortran subprograms on the global
3474 symbol list.
3475 (determine_prefix): How to build the prefix for Fortran
3476 subprograms.
3477
d8c06f22
AB		 34782019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3479
3480 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3481 have just sent the thread a SIGSTOP and are waiting for it to
3482 arrive.
3483
a8b3b8e9
AB		 34842019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3485
3486 * btrace.c (btrace_add_pc): Remove whitespace before the template
3487 parameter in 'std::vector <...>'.
3488 (parse_xml_btrace_block): Likewise.
3489 (btrace_maint_decode_pt): Likewise.
3490 (btrace_maint_update_packets): Likewise.
3491 (btrace_maint_print_packets): Likewise.
3492 * btrace.h (struct btrace_maint_info): Likewise.
3493 * dwarf2read.c (struct type_unit_group): Likewise.
3494 (build_type_psymtabs_reader): Likewise.
3495 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3496 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3497 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3498
4d825eab
TV		 34992019-10-03 Tom de Vries <tdevries@suse.de>
3500
3501 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3502 the first line of the help text for set/show style metadata.
3503
80fd2826
TT		 35042019-10-02 Tom Tromey <tromey@adacore.com>
3505
3506 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3507 * gdbsupport/common-inferior.c: New file.
3508 * infcmd.c (startup_with_shell): Don't define.
3509 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3510 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3511 * inferior.h (startup_with_shell): Don't declare.
3512
70054538
CB		 35132019-10-02 Christian Biesinger <cbiesinger@google.com>
3514
3515 * gdbsupport/gdb_assert.h: Include errors.h.
3516 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3517
37f6a7f4
TT		 35182019-10-02 Tom Tromey <tromey@adacore.com>
3519
3520 * NEWS: Add $_ada_exception entry.
3521 * ada-lang.c (struct ada_catchpoint): Add constructor.
3522 <m_kind>: New member.
3523 (allocate_location_exception, re_set_exception): Remove
3524 "ex" parameter.
3525 (should_stop_exception): Compute $_ada_exception.
3526 (check_status_exception, print_it_exception)
3527 (print_one_exception, print_mention_exception): Remove
3528 "ex" parameter.
3529 (allocate_location_catch_exception, re_set_catch_exception)
3530 (check_status_exception, print_it_catch_exception)
3531 (print_one_catch_exception, print_mention_catch_exception)
3532 (print_recreate_catch_exception)
3533 (allocate_location_catch_exception_unhandled)
3534 (re_set_catch_exception_unhandled)
3535 (check_status_exception, print_it_catch_exception_unhandled)
3536 (print_one_catch_exception_unhandled)
3537 (print_mention_catch_exception_unhandled)
3538 (print_recreate_catch_exception_unhandled)
3539 (allocate_location_catch_assert, re_set_catch_assert)
3540 (check_status_assert, print_it_catch_assert)
3541 (print_one_catch_assert, print_mention_catch_assert)
3542 (print_recreate_catch_assert)
3543 (allocate_location_catch_handlers, re_set_catch_handlers)
3544 (check_status_handlers, print_it_catch_handlers)
3545 (print_one_catch_handlers, print_mention_catch_handlers)
3546 (print_recreate_catch_handlers): Remove.
3547 (create_ada_exception_catchpoint): Update.
3548 (initialize_ada_catchpoint_ops): Update.
3549
fccf9de1
TT		 35502019-10-02 Tom Tromey <tromey@adacore.com>
3551
3552 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3553 (create_excep_cond_exprs): Simplify exception string computation.
3554 (ada_exception_catchpoint_cond_string): Likewise.
3555
4b610737
TT		 35562019-10-02 Tom Tromey <tromey@adacore.com>
3557
3558 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3559 * ada-lang.c (lesseq_defined_than): Handle
3560 LOC_STATIC.
3561 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3562 parameter.
3563 (dwarf2_has_info): Likewise.
3564 (new_symbol): Set maybe_copied on symbol when
3565 appropriate.
3566 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3567 parameter.
3568 <can_copy>: New member.
3569 * elfread.c (record_minimal_symbol): Set maybe_copied
3570 on symbol when appropriate.
3571 (elf_symfile_read): Update call to dwarf2_has_info.
3572 * minsyms.c (lookup_minimal_symbol_linkage): New
3573 function.
3574 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3575 * symtab.c (get_symbol_address, get_msymbol_address):
3576 New functions.
3577 * symtab.h (get_symbol_address, get_msymbol_address):
3578 Declare.
3579 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3580 maybe_copied.
3581 (struct symbol, struct minimal_symbol) <maybe_copied>:
3582 New member.
3583
1dd58850
TT		 35842019-10-02 Tom Tromey <tromey@adacore.com>
3585
3586 * source.c (struct current_source_location): New.
3587 (current_source_key): New global.
3588 (current_source_symtab, current_source_line)
3589 (current_source_pspace): Remove.
3590 (get_source_location): New function.
3591 (get_current_source_symtab_and_line)
3592 (set_default_source_symtab_and_line)
3593 (set_current_source_symtab_and_line)
3594 (clear_current_source_symtab_and_line, select_source_symtab)
3595 (info_source_command, print_source_lines_base)
3596 (info_line_command, search_command_helper, _initialize_source):
3597 Update.
3598
5c281dbb
TT		 35992019-10-02 Tom Tromey <tromey@adacore.com>
3600
3601 * source.c (select_source_symtab): Don't call
3602 decode_line_with_current_source.
3603
d3d32391
AB		 36042019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3605
3606 * symtab.c (lookup_global_symbol): Search global block.
3607
38583298
TT		 36082019-10-02 Tom Tromey <tromey@adacore.com>
3609
3610 * coffread.c (process_coff_symbol): Update.
3611 * dwarf2read.c (var_decode_location, new_symbol): Update.
3612 * mdebugread.c (parse_symbol): Update.
3613 * objfiles.c (relocate_one_symbol): Update.
3614 * stabsread.c (define_symbol, fix_common_block)
3615 (scan_file_globals): Update.
3616 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3617 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3618 * xcoffread.c (process_xcoff_symbol): Update.
3619
9344c18f
AA		 36202019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3621
3622 * MAINTAINERS: Update my email address.
3623
df07e2c7
AB		 36242019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3625
3626 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3627 std::vector.
3628 (build_type_psymtabs_reader): Update for std::vector.
3629 (build_type_psymtab_dependencies): Likewise.
3630 * dwarf2read.h: Remove use of DEF_VEC_P.
3631 (typedef sig_type_ptr): Delete.
3632
554ac434
AB		 36332019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3634
3635 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3636 to std::vector.
3637 (btrace_maint_decode_pt): Likewise, and move allocation of the
3638 vector outside of the loop.
3639 (btrace_maint_update_packets): Update to handle change from VEC to
3640 std::vector.
3641 (btrace_maint_print_packets): Likewise.
3642 (maint_info_btrace_cmd): Likewise.
3643 * btrace.h: Remove use of DEF_VEC_O.
3644 (typedef btrace_pt_packet_s): Delete.
3645 (struct btrace_maint_info) <packets>: Change fromm VEC to
3646 std::vector.
3647 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3648
46f29a9a
AB		 36492019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3650
3651 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3652 make accesses into the vector constant references.
3653 (btrace_add_pc): Update for std::vector.
3654 (btrace_stitch_bts): Likewise.
3655 (parse_xml_btrace_block): Likewise.
3656 (btrace_maint_update_packets): Likewise.
3657 (btrace_maint_print_packets): Likewise.
3658 (maint_info_btrace_cmd): Likewise.
3659 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3660 std::vector.
3661 (btrace_data::empty): Likewise.
3662 (btrace_data_append): Likewise.
3663 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3664 (typedef btrace_block_s): Delete.
3665 (struct btrace_block): Add constructor.
3666 (struct btrace_data_bts) <blocks>: Change to std::vector.
3667 * nat/linux-btrace.c (perf_event_read_bts): Update for
3668 std::vector.
3669 (linux_read_bts): Likewise.
3670
d770d56f
TT		 36712019-10-01 Tom Tromey <tom@tromey.com>
3672
3673 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3674
9d636d67
TT		 36752019-10-01 Tom Tromey <tom@tromey.com>
3676
3677 * stack.c (print_frame, info_frame_command_core): Use
3678 styled_string.
3679 * linux-thread-db.c (try_thread_db_load_1)
3680 (try_thread_db_load_from_pdir_1): Use styled_string.
3681 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3682 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3683 (maybe_print_unsupported_script_warning)
3684 (maybe_print_script_not_found_warning): Use styled_string.
3685 * ada-lang.c (user_select_syms): Use styled_string.
3686
7f6aba03
TT		 36872019-10-01 Tom Tromey <tom@tromey.com>
3688
3689 * p-lang.c (pascal_printstr): Use metadata style.
3690 * value.c (show_convenience): Use metadata style.
3691 * valprint.c (valprint_check_validity, val_print_optimized_out)
3692 (val_print_not_saved, val_print_unavailable)
3693 (val_print_invalid_address, generic_val_print, val_print)
3694 (value_check_printable, val_print_array_elements): Use metadata
3695 style.
3696 * ui-out.h (class ui_out) <field_fmt>: New overload.
3697 <do_field_fmt>: Add style parameter.
3698 * ui-out.c (ui_out::field_fmt): New overload.
3699 * typeprint.c (type_print_unknown_return_type)
3700 (val_print_not_allocated, val_print_not_associated): Use metadata
3701 style.
3702 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3703 parameter.
3704 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3705 * tracepoint.c (tvariables_info_1): Use metadata style.
3706 * stack.c (print_frame_arg, print_frame_info, print_frame)
3707 (info_frame_command_core): Use metadata style.
3708 * skip.c (info_skip_command): Use metadata style.
3709 * rust-lang.c (rust_print_enum): Use metadata style.
3710 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3711 metadata style.
3712 * python/py-framefilter.c (py_print_single_arg): Use metadata
3713 style.
3714 * printcmd.c (do_one_display, print_variable_and_value): Use
3715 metadata style.
3716 * p-valprint.c (pascal_val_print)
3717 (pascal_object_print_value_fields): Use metadata style.
3718 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3719 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3720 parameter.
3721 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3722 * m2-valprint.c (m2_print_long_set): Use metadata style.
3723 * m2-typeprint.c (m2_print_type): Use metadata style.
3724 * infcmd.c (print_return_value_1): Use metadata style.
3725 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3726 * f-valprint.c (info_common_command_for_block): Use metadata
3727 style.
3728 * f-typeprint.c (f_type_print_base): Use metadata style.
3729 * expprint.c (print_subexp_standard): Use metadata style.
3730 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3731 * cli/cli-style.h (class cli_style_option): Add constructor.
3732 (metadata_style): Declare.
3733 * cli/cli-style.c (metadata_style): New global.
3734 (_initialize_cli_style): Register metadata style.
3735 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3736 parameter.
3737 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3738 * c-typeprint.c (c_type_print_base_struct_union)
3739 (c_type_print_base_1): Use metadata style.
3740 * breakpoint.c (watchpoint_value_print)
3741 (print_one_breakpoint_location): Use metadata style.
3742 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3743 style.
3744 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3745 style.
3746 * ada-valprint.c (val_print_packed_array_elements, printstr)
3747 (print_field_values, ada_val_print_ref, ada_val_print): Use
3748 metadata style.
3749 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3750 style.
3751 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3752 style.
3753 * ada-lang.c (user_select_syms): Use metadata style.
3754
14309bb6
TT		 37552019-10-01 Tom Tromey <tom@tromey.com>
3756
3757 * cli/cli-cmds.c (pwd_command): Style output.
3758
6a831f06
PA		 37592019-10-01 Pedro Alves <palves@redhat.com>
3760 Tom Tromey <tom@tromey.com>
3761
3762 * symtab.c (print_symbol_info): Use %ps.
3763 (print_msymbol_info): Use %ps.
3764 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3765 * printcmd.c (print_variable_and_value): Use %ps.
3766 * macrocmd.c (show_pp_source_pos): Use %ps.
3767 * infrun.c (print_exited_reason): Use ui_out::message.
3768 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3769 (describe_other_breakpoints): Use ui_out::message and new
3770 formats.
3771 (say_where): Use new formats.
3772 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3773 and new formats.
3774
2a3c1174
PA		 37752019-10-01 Pedro Alves <palves@redhat.com>
3776 Tom Tromey <tom@tromey.com>
3777
3778 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3779 (test_gdb_formats): New function.
3780 (run_tests): Call it.
3781 (test_format_specifier): Update.
3782 * utils.h (fputs_filtered): Update comment.
3783 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3784 (fputs_styled_unfiltered): Declare.
3785 * utils.c (fputs_styled_unfiltered): New function.
3786 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3787 (vfprintf_filtered): Update.
3788 (vfprintf_unfiltered, vprintf_filtered): Update.
3789 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3790 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3791 disallow_ui_out_field>: New constants.
3792 (enum class field_kind): New.
3793 (struct base_field_s, struct signed_field_s): New.
3794 (signed_field): New function.
3795 (struct string_field_s): New.
3796 (string_field): New function.
3797 (struct styled_string_s): New.
3798 (styled_string): New function.
3799 (class ui_out) <message>: Add comment.
3800 <vmessage, call_do_message>: New methods.
3801 <do_message>: Add style parameter.
3802 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3803 methods.
3804 (ui_out::message): Rewrite.
3805 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3806 parameter.
3807 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3808 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3809 gdb_extensions parameter.
3810 (class format_piece): Add parameter to constructor.
3811 (n_int_args): New field.
3812 * gdbsupport/format.c (format_pieces::format_pieces): Add
3813 gdb_extensions parameter. Handle '*'.
3814 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3815 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3816 vfprintf_styled_no_gdbfmt.
3817 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3818 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3819 unfiltered output.
3820 * ui-style.h (struct ui_file_style) <ptr>: New method.
3821
0dfe5bfb
TT		 38222019-10-01 Tom Tromey <tom@tromey.com>
3823
3824 * unittests/format_pieces-selftests.c: Update. Add final format.
3825 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3826 empty literal pieces.
3827
e43b10e1
TT		 38282019-10-01 Tom Tromey <tom@tromey.com>
3829
3830 * ui-out.h (enum class ui_out_style_kind): Remove.
3831 (class ui_out) <field_string, field_stsream, do_field_string>:
3832 Change type of "style".
3833 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3834 (ui_out::field_string): Update.
3835 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3836 of "style".
3837 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3838 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3839 * stack.c (print_frame_arg, print_frame_info, print_frame):
3840 Update.
3841 * source.c (print_source_lines_base): Update.
3842 * solib.c (info_sharedlibrary_command): Update.
3843 * skip.c (info_skip_command): Update.
3844 * record-btrace.c (btrace_call_history_src_line)
3845 (btrace_call_history): Update.
3846 * python/py-framefilter.c (py_print_frame): Update.
3847 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3848 "style".
3849 * mi/mi-out.c (mi_ui_out::do_table_header)
3850 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3851 (mi_ui_out::do_field_string): Update.
3852 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3853 Update.
3854 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3855 "style".
3856 * cli-out.c (cli_ui_out::do_table_header)
3857 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3858 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3859 (cli_ui_out::do_field_fmt): Update.
3860 * breakpoint.c (print_breakpoint_location): Update.
3861 (update_static_tracepoint): Update.
3862
cd7c32c3
PW		 38632019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3864
3865 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3866 conversion of gdb_datadir.
3867 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3868 remove not needed c_str ().
3869
8fe0f950
AT		 38702019-09-30 Ali Tamur <tamur@google.com>
3871
3872 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3873 (dwarf2_string_attr): Likewise.
3874
5f48f8f3
AT		 38752019-09-30 Ali Tamur <tamur@google.com>
3876
3877 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3878 (process_full_type_unit): Likewise.
3879 (dump_die_shallow): Likewise.
3880 (cu_debug_loc_section): Likewise.
3881
6fb08628
CB		 38822019-09-28 Christian Biesinger <cbiesinger@google.com>
3883
3884 * minsyms.c (compare_minimal_symbols): Rename to...
3885 (minimal_symbol_is_less_than): ...this, and adjust to STL
3886 conventions (return bool, take arguments as references)
3887 (minimal_symbol_reader::install): Call std::sort instead
3888 of qsort.
3889
c7ee338a
CB		 38902019-09-29 Christian Biesinger <cbiesinger@google.com>
3891
3892 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3893 hash and why.
3894 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3895 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3896
703a86c2
SM		 38972019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3898
3899 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3900 * psympriv.h (add_psymbol_to_list): Move comment here and update
3901 it.
3902
0df0352a
TV		 39032019-09-29 Tom de Vries <tdevries@suse.de>
3904
3905 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3906 Use $tmpdir/$(basename "$output_file").dwz instead of
3907 "${output_file}.dwz".
3908
ad75efa6
SM		 39092019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3910
3911 PR gdb/25045
3912 * hppa-linux-nat.c: Include gdbarch.h.
3913
ececd218
CB		 39142019-09-26 Christian Biesinger <cbiesinger@google.com>
3915
3916 * blockframe.c (find_pc_partial_function): Change return type to bool.
3917 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3918 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3919 (stub_gnu_ifunc_resolve_name): Likewise.
3920 * symtab.c (compare_filenames_for_search): Likewise.
3921 (compare_glob_filenames_for_search): Likewise.
3922 (matching_obj_sections): Likewise.
3923 (symbol_matches_domain): Likewise.
3924 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3925 (find_line_pc): Change return type to bool.
3926 (find_line_pc_range): Likewise.
3927 (producer_is_realview): Likewise.
3928 * symtab.h (symbol_matches_domain): Likewise.
3929 (find_pc_partial_function): Likewise.
3930 (find_pc_line_pc_range): Likewise.
3931 (in_gnu_ifunc_stub): Likewise.
3932 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3933 (find_line_pc): Likewise.
3934 (find_line_pc_range): Likewise.
3935 (matching_obj_sections): Likewise.
3936 (find_line_symtab): Change out parameter to bool.
3937 (producer_is_realview): Change return type to bool.
3938 (compare_filenames_for_search): Likewise.
3939 (compare_glob_filenames_for_search): Likewise.
3940
27a900b8
TT		 39412019-09-26 Tom Tromey <tom@tromey.com>
3942
3943 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3944 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3945 * gdb_usleep.h: Remove.
3946 * gdb_usleep.c: Remove.
3947 * utils.c: Don't include gdb_usleep.h.
3948
5d63b30a
TT		 39492019-09-26 Tom Tromey <tromey@adacore.com>
3950
3951 * python/py-type.c (type_to_type_object): Call check_typedef
3952 for stub types.
3953
12904d37
TT		 39542019-09-26 Tom Tromey <tom@tromey.com>
3955
3956 * utils.h (initialize_utils): Don't declare.
3957 * top.c (gdb_init): Don't call initialize_utils.
3958 * utils.c (initialize_utils): Remove. Move contents...
3959 (_initialize_utils): ... here.
3960
858f25f0
TT		 39612019-09-25 Tom Tromey <tom@tromey.com>
3962
3963 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3964 * utils.h (make_hex_string): Don't declare.
3965 * utils.c (make_hex_string): Remove.
3966
3d435220
TV		 39672019-09-24 Tom de Vries <tdevries@suse.de>
3968
3969 PR gdb/23815
3970 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3971 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3972
ddd44b70
DD		 39732019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3974
3975 * NEWS: Mention new simulator port for PRU.
3976
f945dedf
CB		 39772019-09-23 Christian Biesinger <cbiesinger@google.com>
3978
3979 * ada-exp.y (write_object_remaining): Update.
3980 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3981 and eliminate the static buffer.
3982 (ada_decode_symbol): Update.
3983 (ada_la_decode): Update.
3984 (ada_sniff_from_mangled_name): Update.
3985 (is_valid_name_for_wild_match): Update.
3986 (ada_lookup_name_info::matches): Update and simplify.
3987 (name_matches_regex): Update.
3988 (ada_add_global_exceptions): Update.
3989 * ada-lang.h (ada_decode): Update signature.
3990 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3991 * dwarf-index-write.c (debug_names::insert): Update.
3992
7ab78ccb
SM		 39932019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3994
3995 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3996 formatting.
3997
9252448b
SM		 39982019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3999
4000 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4001 Change "nonzero" to "true" in documentation.
4002
626ca2c0
CB		 40032019-09-20 Christian Biesinger <cbiesinger@google.com>
4004
4005 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4006 (_initialize_darwin_solib): Don't set
4007 darwin_so_ops.lookup_lib_global_symbol.
4008 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4009 set_gdbarch_iterate_over_objfiles_in_search_order.
4010 (elf_lookup_lib_symbol): Rename to...
4011 (svr4_iterate_over_objfiles_in_search_order): this, and update
4012 to iterate semantics.
4013 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4014 * solib.c (solib_global_lookup): Remove.
4015 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4016 (solib_global_lookup): Remove.
4017 * symtab.c (lookup_global_or_static_symbol): Remove call to
4018 solib_global_lookup.
4019
5a3a0d63
JB		 40202019-09-20 Joel Brobecker <brobecker@adacore.com>
4021
4022 * NEWS: Move entries about default MI version now being
4023 version 3, and about the GDB/MI fix for multi-location
4024 breakpoints to the "since GDB 8.3" section.
4025
ffea1427
JB		 40262019-09-20 Joel Brobecker <brobecker@adacore.com>
4027
4028 GDB 8.3.1 released.
4029
abf516c6
UW		 40302019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4031
4032 * NEWS: Mention that Cell/B.E. debugging support was removed.
4033 * MAINTAINERS: Remove spu target.
4034
4035 * config/djgpp/fnchange.lst: Remove entries for removed files.
4036
4037 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4038 spu-multiarch.o, and spu-tdep.o.
4039 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4040 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4041 spu-multiarch.c, and spu-tdep.c.
4042 * spu-linux-nat.c: Remove file.
4043 * spu-multiarch.c: Remove file.
4044 * spu-tdep.c: Remove file.
4045 * spu-tdep.h: Remove file.
4046 * solib-spu.c: Remove file.
4047 * solib-spu.h: Remove file.
4048
4049 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4050 * configure.nat (spu-linux): Remove.
4051 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4052 solib-multiarch.o from gdb_target_obs.
4053 (spu*-*-*): Remove.
4054
4055 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4056 feature flag.
4057 (ppc_linux_no_features): Update.
4058 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4059 Cell/B.E. support.
4060 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4061 (tdesc_powerpc_cell64l): Likewise.
4062 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4063 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4064 Cell/B.E. support.
4065 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4066 Do not include "features/rs6000/powerpc-cell32l.c" or
4067 "features/rs6000/powerpc-cell64l.c".
4068 (ppc_linux_spu_section): Remove.
4069 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4070 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4071 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4072 (ppc_linux_spe_context_lookup): Remove.
4073 (ppc_linux_spe_context_inferior_created): Remove.
4074 (ppc_linux_spe_context_solib_loaded): Remove.
4075 (ppc_linux_spe_context_solib_unloaded): Remove.
4076 (ppc_linux_spe_context): Remove.
4077 (struct ppu2spu_cache): Remove.
4078 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4079 (struct ppu2spu_data): Remove.
4080 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4081 ppu2spu_unwind): Remove.
4082 (ppc_linux_init_abi): Remove Cell/B.E. support.
4083 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4084
4085 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4086 (rs6000/powerpc-cell64l-expedite): Likewise
4087 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4088 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4089 rs6000/powerpc-cell64l.xml.
4090 * features/rs6000/powerpc-cell32l.xml: Remove.
4091 * features/rs6000/powerpc-cell64l.xml: Likewise.
4092 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4093 * features/rs6000/powerpc-cell64l.c: Likewise.
4094 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4095 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4096 * regformats/reg-spu.dat: Remove.
4097
4098 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4099 * corelow.c (struct spuid_list): Remove.
4100 (add_to_spuid_list): Remove.
4101 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4102 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4103 (remote_protocol_features): Remove associated entries.
4104 (_initialize_remote): No longer initialize them.
4105 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4106 * linux-nat.c (SPUFS_MAGIC): Remove.
4107 (linux_proc_xfer_spu): Remove.
4108 (spu_enumerate_spu_ids): Remove.
4109 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4110 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4111 (linux_make_corefile_notes): No longer call it.
4112
4113 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4114 (cooked_write_test): Likewise.
4115
78e8cb91
TT		 41162019-09-20 Tom Tromey <tom@tromey.com>
4117
4118 * NEWS: Mention case-sensitivity of TUI commands.
4119 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4120 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4121 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4122
f074b67e
TT		 41232019-09-20 Tom Tromey <tom@tromey.com>
4124
4125 * tui/tui-source.c (tui_source_window::set_contents): Use
4126 make_unique_xstrdup.
4127 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4128 make_unique_xstrdup.
4129
63c4bf19
TT		 41302019-09-20 Tom Tromey <tom@tromey.com>
4131
4132 * tui/tui-data.c: Remove separator comments.
4133 * tui/tui-layout.c: Remove separator comments.
4134 * tui/tui-win.c: Remove separator comments.
4135 * tui/tui-wingeneral.c: Remove separator comments.
4136
43df9b2f
TT		 41372019-09-20 Tom Tromey <tom@tromey.com>
4138
4139 * tui/tui.h (strcat_to_buf): Don't declare.
4140 * tui/tui.c (strcat_to_buf): Remove.
4141
7226433c
TT		 41422019-09-20 Tom Tromey <tom@tromey.com>
4143
4144 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4145 from "fullname".
4146 * tui/tui-source.c (tui_source_window::set_contents)
4147 (tui_source_window::location_matches_p)
4148 (tui_source_window::maybe_update): Update.
4149
80df3337
TT		 41502019-09-20 Tom Tromey <tom@tromey.com>
4151
4152 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4153 Update.
4154 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4155 prefix.
4156 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4157 (tui_data_window::line_from_reg_element_no)
4158 (tui_data_window::first_reg_element_no_inline)
4159 (tui_data_window::show_registers)
4160 (tui_data_window::show_register_group)
4161 (tui_data_window::display_registers_from)
4162 (tui_data_window::display_registers_from_line)
4163 (tui_data_window::first_data_item_displayed)
4164 (tui_data_window::delete_data_content_windows)
4165 (tui_data_window::erase_data_content)
4166 (tui_data_window::do_scroll_vertical)
4167 (tui_data_window::refresh_window)
4168 (tui_data_window::check_register_values): Update.
4169
9923f347
TT		 41702019-09-20 Tom Tromey <tom@tromey.com>
4171
4172 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4173 (struct tui_locator_window) <full_name, proc_name>: Now
4174 std::string.
4175 * tui/tui-stack.c (tui_locator_window::make_status_line)
4176 (tui_locator_window::set_locator_fullname)
4177 (tui_locator_window::set_locator_info): Update.
4178 * tui/tui-source.c (tui_source_window::set_contents)
4179 (tui_source_window::showing_source_p): Update.
4180
b76251ab
TT		 41812019-09-20 Tom Tromey <tom@tromey.com>
4182
4183 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4184 Don't call tui_locator_win_info_ptr.
4185
0891be08
TT		 41862019-09-20 Tom Tromey <tom@tromey.com>
4187
4188 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4189
1b935acf
TT		 41902019-09-20 Tom Tromey <tom@tromey.com>
4191
4192 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4193 height for locator.
4194 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4195 * tui/tui-layout.c (show_source_disasm_command, show_data)
4196 (show_source_or_disasm_and_command): Use 1 as height for locator.
4197
9abd8a65
TT		 41982019-09-20 Tom Tromey <tom@tromey.com>
4199
4200 * tui/tui.c (tui_enable): Update.
4201 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4202 Update.
4203 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4204 Update.
4205 * tui/tui-data.c (win_resized): Now bool.
4206 (tui_win_resized): Return bool.
4207 (tui_set_win_resized_to): Accept a bool.
4208
b5457826
TT		 42092019-09-20 Tom Tromey <tom@tromey.com>
4210
4211 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4212 Change type of "refresh_values_only".
4213 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4214 type of "refresh_values_only".
4215
6b915f7d
TT		 42162019-09-20 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4219 std::string.
4220 (tui_disassemble): Add "pos" parameter.
4221 (tui_disasm_window::set_contents): Simplify.
4222
2ad52f6f
TT		 42232019-09-20 Tom Tromey <tom@tromey.com>
4224
4225 * tui/tui-winsource.h (struct tui_source_window_base)
4226 <show_source_content>: Now private.
4227 * tui/tui-winsource.c
4228 (tui_source_window_base::show_source_content): Don't handle empty
4229 content case.
4230
b3b1bde6
TT		 42312019-09-20 Tom Tromey <tom@tromey.com>
4232
4233 * tui/tui-layout.c (show_source_disasm_command)
4234 (show_source_or_disasm_and_command): Don't call
4235 show_source_content.
4236
71a25ed2
TT		 42372019-09-20 Tom Tromey <tom@tromey.com>
4238
4239 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4240 Declare.
4241 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4242 from tui_make_status_line.
4243 (tui_locator_window::rerender): Update.
4244
f8532154
TT		 42452019-09-20 Tom Tromey <tom@tromey.com>
4246
4247 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4248 (tui_locator_window::rerender): Update.
4249
2d81b349
TT		 42502019-09-20 Tom Tromey <tom@tromey.com>
4251
4252 * tui/tui-winsource.h (struct tui_source_window_base)
4253 <~tui_source_window_base>: Don't declare.
4254 <fullname>: Remove.
4255 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4256 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4257 member.
4258 * tui/tui-source.c (tui_source_window::set_contents): Update.
4259 (tui_source_window::location_matches_p)
4260 (tui_source_window::maybe_update): Update.
4261
f14bec58
TT		 42622019-09-20 Tom Tromey <tom@tromey.com>
4263
4264 * tui/tui-winsource.h (~tui_source_element): Remove.
4265 (tui_source_element): Update.
4266 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4267 * tui/tui-winsource.c (tui_show_source_line): Update.
4268 * tui/tui-source.c (tui_source_window::set_contents): Update.
4269 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4270
78d5933a
TT		 42712019-09-20 Tom Tromey <tom@tromey.com>
4272
4273 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4274 declare.
4275 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4276 tui_clear_source_windows_detail.
4277 * tui/tui-winsource.h (struct tui_source_window_base)
4278 <clear_detail>: Don't declare.
4279 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4280 Remove.
4281 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4282
d4207696
TT		 42832019-09-20 Tom Tromey <tromey@adacore.com>
4284
4285 PR ada/24919:
4286 * block.c (contained_in): Fix final return value.
4287
00f93c44
AM		 42882019-09-20 Alan Modra <amodra@gmail.com>
4289
4290 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4291 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4292 (read_indirect_string_from_dwz): Use bfd accessor.
4293 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4294 * machoread.c (macho_symfile_read_all_oso): Likewise.
4295 * solib.c (solib_bfd_open): Likewise.
4296
e4153ae6
CB		 42972019-09-19 Christian Biesinger <cbiesinger@google.com>
4298
4299 * eval.c: Move declaration of overload_resolution to...
4300 * value.h: ...here.
4301
c7ae7675
CB		 43022019-09-19 Christian Biesinger <cbiesinger@google.com>
4303
4304 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4305 * arm-linux-tdep.c: Likewise.
4306 * arm-nbsd-nat.c: Likewise.
4307 * arm-tdep.h: Declare arm_apcs_32.
4308 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4309
e86f08d2
CB		 43102019-09-19 Christian Biesinger <cbiesinger@google.com>
4311
4312 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4313 * dwarf2read.h: Declare dwarf_always_disassemble.
4314
f64e2f40
TV		 43152019-09-19 Tom de Vries <tdevries@suse.de>
4316
4317 PR gdb/25009
4318 * source-cache.c (source_cache::ensure): Catch exception thrown during
4319 construction of the highlighter.
4320
fd361982
AM		 43212019-09-18 Alan Modra <amodra@gmail.com>
4322
4323 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4324 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4325 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4326 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4327 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4328 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4329 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4330 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4331 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4332 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4333 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4334 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4335 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4336 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4337 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4338 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4339 * mi/mi-interp.c: Update throughout for bfd section macro and
4340 function changes.
4341 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4342 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4343
11061048
TT		 43442019-09-18 Tom Tromey <tom@tromey.com>
4345
4346 * NEWS: Add entry.
4347 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4348 call rl_initialize.
4349 (tui_enable): Do not call rl_initialize.
4350
7a27b85f
CG		 43512019-09-18 Christian Groessler <chris@groessler.org>
4352
4353 * alpha-linux-nat.c: Include gdbarch.h.
4354
f64eea3a
SM		 43552019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4356
4357 * ui-file.c: Include cli/cli-style.h.
4358 (term_cli_styling): Remove cli_styling declaration.
4359
e6f7f6d1
AM		 43602019-09-18 Alan Modra <amodra@gmail.com>
4361
4362 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4363 to bfd_asymbol_section.
4364
1d38e9d1
AM		 43652019-09-18 Alan Modra <amodra@gmail.com>
4366
4367 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4368 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4369 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4370
90d92a63
AM		 43712019-09-18 Alan Modra <amodra@gmail.com>
4372
4373 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4374 * spu-linux-nat.c (spu_bfd_open): Likewise.
4375
a3d181d2
CB		 43762019-09-18 Christian Biesinger <cbiesinger@google.com>
4377
4378 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4379 to bool to match definition in dwarf2read.c.
4380
491144b5
CB		 43812019-09-17 Christian Biesinger <cbiesinger@google.com>
4382
4383 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4384 (print_signatures): Likewise.
4385 (trust_pad_over_xvs): Likewise.
4386 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4387 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4388 * arm-linux-nat.c (arm_apcs_32): Likewise.
4389 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4390 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4391 * arm-tdep.c (arm_debug): Likewise.
4392 (arm_apcs_32): Likewise.
4393 * auto-load.c (debug_auto_load): Likewise.
4394 (auto_load_gdb_scripts): Likewise.
4395 (global_auto_load): Likewise.
4396 (auto_load_local_gdbinit): Likewise.
4397 (auto_load_local_gdbinit_loaded): Likewise.
4398 * auto-load.h (global_auto_load): Likewise.
4399 (auto_load_local_gdbinit): Likewise.
4400 (auto_load_local_gdbinit_loaded): Likewise.
4401 * breakpoint.c (disconnected_dprintf): Likewise.
4402 (breakpoint_proceeded): Likewise.
4403 (automatic_hardware_breakpoints): Likewise.
4404 (always_inserted_mode): Likewise.
4405 (target_exact_watchpoints): Likewise.
4406 (_initialize_breakpoint): Update.
4407 * breakpoint.h (target_exact_watchpoints): Change to bool.
4408 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4409 * cli/cli-cmds.c (trace_commands): Likewise.
4410 * cli/cli-cmds.h (trace_commands): Likewise.
4411 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4412 to bool*.
4413 * cli/cli-logging.c (logging_overwrite): Change to bool.
4414 (logging_redirect): Likewise.
4415 (debug_redirect): Likewise.
4416 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4417 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4418 to bool.
4419 <boolean_option_def>: Update.
4420 (struct flag_option_def): Change default type of Context to bool
4421 from int.
4422 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4423 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4424 (get_setshow_command_value_string): Likewise.
4425 * cli/cli-style.c (cli_styling): Change to bool.
4426 (source_styling): Likewise.
4427 * cli/cli-style.h (source_styling): Likewise.
4428 (cli_styling): Likewise.
4429 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4430 to bool.
4431 * command.h (var_types): Update comment.
4432 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4433 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4434 bool.
4435 (debug_compile_cplus_scopes): Likewise.
4436 * compile/compile-internal.h (compile_debug): Likewise.
4437 * compile/compile.c (compile_debug): Likewise.
4438 (struct compile_options) <raw>: Likewise.
4439 * cp-support.c (catch_demangler_crashes): Likewise.
4440 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4441 (usr_cmd_cris_dwarf2_cfi): Likewise.
4442 * csky-tdep.c (csky_debug): Likewise.
4443 * darwin-nat.c (enable_mach_exceptions): Likewise.
4444 * dcache.c (dcache_enabled_p): Likewise.
4445 * defs.h (info_verbose): Likewise.
4446 * demangle.c (demangle): Likewise.
4447 (asm_demangle): Likewise.
4448 * dwarf-index-cache.c (debug_index_cache): Likewise.
4449 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4450 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4451 * dwarf2read.c (check_physname): Likewise.
4452 (use_deprecated_index_sections): Likewise.
4453 (dwarf_always_disassemble): Likewise.
4454 * eval.c (overload_resolution): Likewise.
4455 * event-top.c (set_editing_cmd_var): Likewise.
4456 (exec_done_display_p): Likewise.
4457 * event-top.h (set_editing_cmd_var): Likewise.
4458 (exec_done_display_p): Likewise.
4459 * exec.c (write_files): Likewise.
4460 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4461 (debug_fbsd_nat): Likewise.
4462 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4463 Likewise.
4464 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4465 <backtrace_past_entry> Likewise.
4466 * gdb-demangle.h (demangle): Likewise.
4467 (asm_demangle): Likewise.
4468 * gdb_bfd.c (bfd_sharing): Likewise.
4469 * gdbcore.h (write_files): Likewise.
4470 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4471 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4472 * gdbthread.h (print_thread_events): Likewise.
4473 * gdbtypes.c (opaque_type_resolution): Likewise.
4474 (strict_type_checking): Likewise.
4475 * gnu-nat.c (gnu_debug_flag): Likewise.
4476 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4477 * guile/scm-param.c (pascm_variable): Add boolval.
4478 (add_setshow_generic): Update.
4479 (pascm_param_value): Update.
4480 (pascm_set_param_value_x): Update.
4481 * hppa-tdep.c (hppa_debug): Change to bool..
4482 * infcall.c (may_call_functions_p): Likewise.
4483 (coerce_float_to_double_p): Likewise.
4484 (unwind_on_signal_p): Likewise.
4485 (unwind_on_terminating_exception_p): Likewise.
4486 * infcmd.c (startup_with_shell): Likewise.
4487 * inferior.c (print_inferior_events): Likewise.
4488 * inferior.h (startup_with_shell): Likewise.
4489 (print_inferior_events): Likewise.
4490 * infrun.c (step_stop_if_no_debug): Likewise.
4491 (detach_fork): Likewise.
4492 (debug_displaced): Likewise.
4493 (disable_randomization): Likewise.
4494 (non_stop): Likewise.
4495 (non_stop_1): Likewise.
4496 (observer_mode): Likewise.
4497 (observer_mode_1): Likewise.
4498 (set_observer_mode): Update.
4499 (sched_multi): Change to bool.
4500 * infrun.h (debug_displaced): Likewise.
4501 (sched_multi): Likewise.
4502 (step_stop_if_no_debug): Likewise.
4503 (non_stop): Likewise.
4504 (disable_randomization): Likewise.
4505 * linux-tdep.c (use_coredump_filter): Likewise.
4506 (dump_excluded_mappings): Likewise.
4507 * linux-thread-db.c (auto_load_thread_db): Likewise.
4508 (check_thread_db_on_load): Likewise.
4509 * main.c (captured_main_1): Update.
4510 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4511 xx2_opt, boolean_opt>: Change to bool.
4512 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4513 * maint.c (maintenance_profile_p): Likewise.
4514 (per_command_time): Likewise.
4515 (per_command_space): Likewise.
4516 (per_command_symtab): Likewise.
4517 * memattr.c (inaccessible_by_default): Likewise.
4518 * mi/mi-main.c (mi_async): Likewise.
4519 (mi_async_1): Likewise.
4520 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4521 * nat/fork-inferior.h (startup_with_shell): Likewise.
4522 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4523 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4524 * nios2-tdep.c (nios2_debug): Likewise.
4525 * or1k-tdep.c (or1k_debug): Likewise.
4526 * parse.c (parser_debug): Likewise.
4527 * parser-defs.h (parser_debug): Likewise.
4528 * printcmd.c (print_symbol_filename): Likewise.
4529 * proc-api.c (procfs_trace): Likewise.
4530 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4531 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4532 (set_parameter_value): Update.
4533 (add_setshow_generic): Update.
4534 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4535 to bool*.
4536 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4537 int*.
4538 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4539 * record-btrace.c (record_btrace_target::store_registers): Update.
4540 * record-full.c (record_full_memory_query): Change to bool.
4541 (record_full_stop_at_limit): Likewise.
4542 * record-full.h (record_full_memory_query): Likewise.
4543 * remote-notif.c (notif_debug): Likewise.
4544 * remote-notif.h (notif_debug): Likewise.
4545 * remote.c (use_range_stepping): Likewise.
4546 (interrupt_on_connect): Likewise.
4547 (remote_break): Likewise.
4548 * ser-tcp.c (tcp_auto_retry): Likewise.
4549 * ser-unix.c (serial_hwflow): Likewise.
4550 * skip.c (debug_skip): Likewise.
4551 * solib-aix.c (solib_aix_debug): Likewise.
4552 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4553 (spu_auto_flush_cache_p): Likewise.
4554 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4555 Likewise.
4556 (struct info_print_options) <quiet>: Likewise.
4557 * symfile-debug.c (debug_symfile): Likewise.
4558 * symfile.c (auto_solib_add): Likewise.
4559 (separate_debug_file_debug): Likewise.
4560 * symfile.h (auto_solib_add): Likewise.
4561 (separate_debug_file_debug): Likewise.
4562 * symtab.c (basenames_may_differ): Likewise.
4563 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4564 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4565 (struct info_types_options) <quiet>: Likewise.
4566 * symtab.h (demangle): Likewise.
4567 (basenames_may_differ): Likewise.
4568 * target-dcache.c (stack_cache_enabled_1): Likewise.
4569 (code_cache_enabled_1): Likewise.
4570 * target.c (trust_readonly): Likewise.
4571 (may_write_registers): Likewise.
4572 (may_write_memory): Likewise.
4573 (may_insert_breakpoints): Likewise.
4574 (may_insert_tracepoints): Likewise.
4575 (may_insert_fast_tracepoints): Likewise.
4576 (may_stop): Likewise.
4577 (auto_connect_native_target): Likewise.
4578 (target_stop_and_wait): Update.
4579 (target_async_permitted): Change to bool.
4580 (target_async_permitted_1): Likewise.
4581 (may_write_registers_1): Likewise.
4582 (may_write_memory_1): Likewise.
4583 (may_insert_breakpoints_1): Likewise.
4584 (may_insert_tracepoints_1): Likewise.
4585 (may_insert_fast_tracepoints_1): Likewise.
4586 (may_stop_1): Likewise.
4587 * target.h (target_async_permitted): Likewise.
4588 (may_write_registers): Likewise.
4589 (may_write_memory): Likewise.
4590 (may_insert_breakpoints): Likewise.
4591 (may_insert_tracepoints): Likewise.
4592 (may_insert_fast_tracepoints): Likewise.
4593 (may_stop): Likewise.
4594 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4595 (make_thread_apply_all_options_def_group): Change argument from int*
4596 to bool*.
4597 (thread_apply_all_command): Update.
4598 (print_thread_events): Change to bool.
4599 * top.c (confirm): Likewise.
4600 (command_editing_p): Likewise.
4601 (history_expansion_p): Likewise.
4602 (write_history_p): Likewise.
4603 (info_verbose): Likewise.
4604 * top.h (confirm): Likewise.
4605 (history_expansion_p): Likewise.
4606 * tracepoint.c (disconnected_tracing): Likewise.
4607 (circular_trace_buffer): Likewise.
4608 * typeprint.c (print_methods): Likewise.
4609 (print_typedefs): Likewise.
4610 * utils.c (debug_timestamp): Likewise.
4611 (sevenbit_strings): Likewise.
4612 (pagination_enabled): Likewise.
4613 * utils.h (sevenbit_strings): Likewise.
4614 (pagination_enabled): Likewise.
4615 * valops.c (overload_resolution): Likewise.
4616 * valprint.h (struct value_print_options) <prettyformat_arrays,
4617 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4618 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4619 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4620 Likewise.
4621 * windows-nat.c (new_console): Likewise.
4622 (cygwin_exceptions): Likewise.
4623 (new_group): Likewise.
4624 (debug_exec): Likewise.
4625 (debug_events): Likewise.
4626 (debug_memory): Likewise.
4627 (debug_exceptions): Likewise.
4628 (useshell): Likewise.
4629 * windows-tdep.c (maint_display_all_tib): Likewise.
4630 * xml-support.c (debug_xml): Likewise.
4631
f1b620e9
MG		 46322019-09-17 Mike Gulick <mgulick@mathworks.com>
4633
4634 * source.c (prepare_path_for_appending): New function.
4635 (openp): Make use of new function.
4636 (find_and_open_source): Search for the compilation directory and
4637 source file as a relative path beneath the directory search path.
4638
67f3ed6a
AB		 46392019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4640
4641 * source-cache.c (source_cache::get_line_charpos): Catch
4642 exceptions and return false, this matches the behaviour documented
4643 in the header file.
4644
74332189
JB		 46452019-09-17 Joel Brobecker <brobecker@adacore.com>
4646
4647 * ada-tasks.c (info_task): Remove quoting of the task's name.
4648
f2f24aa9
CB		 46492019-09-16 Christian Biesinger <cbiesinger@google.com>
4650
4651 * symfile.c (auto_solib_add): Replace comment with a reference
4652 to the header file.
4653
6a062a93
CB		 46542019-09-14 Christian Biesinger <cbiesinger@google.com>
4655
4656 * NEWS: Mention that gdb can now be compiled with Python 3
4657 on Windows.
4658
ec6c8338
AB		 46592019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4660
4661 * maint.c (maint_print_section_data::maint_print_section_data):
4662 Force use of 'float log10 (float)' by casting the argument to
4663 float.
4664
aa17805f
AB		 46652019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4666
4667 * maint.c: Add 'cmath' include.
4668 (struct maint_print_section_data): New structure.
4669 (print_section_index): New function.
4670 (print_bfd_section_info): Add header comment, small whitespace
4671 cleanup, and update to call new print_section_index function.
4672 (print_objfile_section_info): Likewise.
4673 (maint_obj_section_from_bfd_section): New function.
4674 (print_bfd_section_info_maybe_relocated): New function.
4675 (maintenance_info_sections): Add header comment, always use
4676 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4677
3dd9bb46
AB		 46782019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4679
4680 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4681 inner scope, add check that the objfile has psymtabs before
4682 checking psymtabs_addrmap.
4683 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4684
4993045d
PW		 46852019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4686
4687 * NEWS: Announce that Ada task names are now shown at more places,
4688 and between quotes (except in info task output).
4689 * gdb/ada-tasks.c (task_to_str): New function.
4690 (display_current_task_id): Call task_to_str.
4691 (task_command_1): Likewise.
4692 (print_ada_task_info): In non-mi mode, Properly align headers and data
4693 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4694
7a289707
RO		 46952019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4696
4697 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4698 prstatus.pr_lwp.pr_info instead of making it up.
4699
f2aec7f6
CB		 47002019-09-11 Christian Biesinger <cbiesinger@google.com>
4701
4702 * auto-load.c (auto_load_expand_dir_vars): Update.
4703 * defs.h (gdb_datadir): Change to std::string.
4704 (python_libdir): Likewise.
4705 (relocate_gdb_directory): Change return type to std::string.
4706 * guile/guile.c (gdbscm_data_directory): Update.
4707 (initialize_scheme_side): Update.
4708 * jit.c (jit_reader_dir): Change to std::string.
4709 (jit_reader_load_command): Update.
4710 * main.c (gdb_datadir): Change to std::string.
4711 (python_libdir): Likewise.
4712 (set_gdb_data_directory): Update.
4713 (relocate_path): Change to return std::string.
4714 (relocate_gdb_directory): Change to return std::string.
4715 (relocate_gdbinit_path_maybe_in_datadir): Update.
4716 (captured_main_1): Update.
4717 * python/python.c (do_start_initialization): Update.
4718 * top.c (show_gdb_datadir): Update.
4719 * xml-syscall.c (xml_init_syscalls_info): Update.
4720 (init_syscalls_info): Update.
4721
9224a013
CB		 47222019-09-11 Christian Biesinger <cbiesinger@google.com>
4723
4724 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4725 out of get_init_files.
4726 (get_init_files): Update.
4727
f48cd836
CB		 47282019-09-11 Christian Biesinger <cbiesinger@google.com>
4729
4730 * main.c (get_init_files): Change to use std::string.
4731 (captured_main_1): Update.
4732 (print_gdb_help): Update.
4733
9cab7ecd
AT		 47342019-09-11 Ali Tamur <tamur@google.com>
4735
4736 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4737 implementation.
4738
67547d89
CB		 47392019-09-11 Christian Biesinger <cbiesinger@google.com>
4740
4741 * dbxread.c (read_dbx_symtab): Update.
4742 * dwarf2read.c (load_partial_dies): Update.
4743 * mdebugread.c (parse_partial_symbols): Update.
4744 (handle_psymbol_enumerators): Update.
4745 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4746 * psymtab.c (add_psymbol_to_bcache): Likewise.
4747 (add_psymbol_to_list): Likewise.
4748 * symtab.c (symbol_set_names): Likewise.
4749 * symtab.h (symbol_set_names): Likewise.
4750 * xcoffread.c (scan_xcoff_symtab): Update.
4751
64b2d4a0
TT		 47522019-09-11 Tom Tromey <tom@tromey.com>
4753
4754 * symfile-mem.c (symbol_file_add_from_memory): Use
4755 bfd_set_filename.
4756 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4757 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4758
3b00ef10
TT		 47592019-09-10 Tom Tromey <tromey@adacore.com>
4760
4761 * dwarf-index-write.c (write_psymbols): Extend error message.
4762 (debug_names::insert): Add Ada code.
4763 (debug_names::write_psymbols): Remove Ada check.
4764 (debug_names) <m_string_obstack>: New member.
4765 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4766 (gdb_index_symbol_name_matcher::matches): Remove.
4767 (mapped_index_base::find_name_components_bounds): Add "lang"
4768 parameter.
4769 (mapped_index_base::build_name_components): Also split names
4770 according to Ada syntax.
4771 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4772 type of "match_callback".
4773 (check_match, check_find_bounds_finds)
4774 (dw2_expand_symtabs_matching): Update.
4775 (dw2_debug_names_iterator): Add new constructor.
4776 (dw2_debug_names_map_matching_symbols): New function.
4777 (dw2_debug_names_expand_symtabs_matching): Update.
4778 (dwarf2_debug_names_functions): Use
4779 dw2_debug_names_map_matching_symbols.
4780
aa391654
TT		 47812019-09-10 Tom Tromey <tromey@adacore.com>
4782
4783 * dwarf2read.c (dw2_get_file_names_reader): Add the
4784 CU's file name to the results.
4785
b054970d
TT		 47862019-09-10 Tom Tromey <tromey@adacore.com>
4787
4788 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4789 map_matching_symbols. Update.
4790 * dwarf2read.c (dw2_map_matching_symbols): Update.
4791 * psymtab.c (match_partial_symbol): Change type; update.
4792 (psym_map_matching_symbols): Likewise.
4793 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4794 type; update.
4795 * symfile.h (struct quick_symbol_functions)
4796 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4797 Remove "match".
4798
6a3dbf1b
TT		 47992019-09-10 Tom Tromey <tromey@adacore.com>
4800
4801 * psymtab.c (map_block): Remove.
4802 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4803 * symtab.c (iterate_over_symbols_terminated): New function.
4804 * symtab.c (iterate_over_symbols_terminated): Declare.
4805
6969f124
TT		 48062019-09-10 Tom Tromey <tromey@adacore.com>
4807
4808 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4809 * language.h (struct language_defn) <la_iterate_over_symbols>:
4810 Return bool.
4811 * symtab.c (iterate_over_symbols): Return bool.
4812 * symtab.h (iterate_over_symbols): Return bool.
4813
199b4314
TT		 48142019-09-10 Tom Tromey <tromey@adacore.com>
4815
4816 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4817 (add_nonlocal_symbols): Update.
4818 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4819 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4820 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4821 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4822 Change type of "callback". Remove "data".
4823
a084a2a6
AT		 4824
48252019-09-09 Ali Tamur <tamur@google.com>
4826
4827 * dwarf2read.c (comp_unit_head): Update comment.
4828 (dwarf2_dwo_name): New function declaration.
4829 (dwarf_unit_type_name): New function declaration.
4830 (read_comp_unit_head): Add support for new compilation units,
4831 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4832 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4833 (currently named as "signature") in their header. Also clarify error
4834 messages.
4835 (lookup_dwo_id): New function. Returns the dwo id of the given
4836 compile unit.
4837 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4838 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4839 functions.
4840 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4841 (dwarf2_dwo_name): Get the dwo name if present.
4842 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4843 purposes.
4844
25a2915e
TT		 48452019-09-09 Tom Tromey <tom@tromey.com>
4846
4847 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4848
e4df0874
PW		 48492019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4850
4851 * python/python.c (do_start_initialization): Make progname_copy static,
4852 to avoid a leak report.
4853
8634b462
TT		 48542019-09-08 Tom Tromey <tom@tromey.com>
4855
4856 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4857
c7f839cb
SM		 48582019-09-07 Simon Marchi <simon.marchi@efficios.com>
4859
4860 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4861 Change type to gdb::optional<block_enum>.
4862 (dw2_symtab_iter_init): Change block_index parameter type
4863 to gdb::optional<block_enum>.
4864 (dw2_lookup_symbol): Change block_index parameter
4865 type to block_enum.c
4866 (dw2_debug_names_lookup_symbol): Likewise.
4867 * psymtab.c (psym_lookup_symbol): Likewise.
4868 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4869 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4870 Likewise.
4871
ead0e69a
CB		 48722019-09-06 Christian Biesinger <cbiesinger@google.com>
4873
4874 * defs.h (relocate_gdb_directory): Change int to bool in
4875 signature and rename flag to relocatable.
4876 * main.c (relocate_path): Likewise.
4877 (relocate_gdb_directory): Likewise.
4878
b16c44de
AM		 48792019-09-06 Alan Modra <amodra@gmail.com>
4880
4881 * coffread.c (coff_symfile_read): Constify filename variable.
4882 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4883 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4884 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4885 * solib.c (reload_shared_libraries_1): Likewise.
4886 * symfile.c (reread_symbols): Likewise.
4887 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4888 * solib-darwin.c (darwin_bfd_open): Likewise.
4889 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4890
06ff036e
AB		 48912019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4892
4893 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4894 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4895
4e962e74
TT		 48962019-09-03 Tom Tromey <tromey@adacore.com>
4897
4898 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4899 types.
4900 (has_negatives): Unbias a range type bound.
4901 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4902 * gdbtypes.c (operator==): Handle new field.
4903 (create_range_type): Add "bias" parameter.
4904 (create_static_range_type, resolve_dynamic_range): Update.
4905 * gdbtypes.h (struct range_bounds) <bias>: New member.
4906 (create_range_type): Add bias parameter.
4907 * printcmd.c (print_scalar_formatted): Unbias range types.
4908 * value.c (unpack_long): Unbias range types.
4909 (pack_long): Bias range types.
4910
d90b8f26
AH		 49112019-09-02 Alan Hayward <alan.hayward@arm.com>
4912
4913 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4914 probe arguments.
4915
fe01123e
AH		 49162019-09-02 Alan Hayward <alan.hayward@arm.com>
4917
4918 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4919 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4920 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4921 (compile_probe_arg): Likewise.
4922 * probe.h (get_argument_count): Likewise.
4923 * solib-svr4.c (solib_event_probe_action): Likewise.
4924 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4925
e661ef01
AH		 49262019-09-02 Alan Hayward <alan.hayward@arm.com>
4927
4928 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4929 code to here...
4930 (svr4_create_solib_event_breakpoints): ...from here.
4931
47a536d9
SDJ		 49322019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4933
4934 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4935 suffix from warning message.
4936
d6a00eba
TT		 49372019-08-30 Tom Tromey <tom@tromey.com>
4938
4939 * tui/tui-winsource.h (struct tui_source_window_base)
4940 <refresh_all>: Don't declare.
4941 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4942 Remove.
4943 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4944 tui_show_locator_content.
4945 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4946 declare.
4947 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4948 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4949 declare.
4950
55b2657b
TT		 49512019-08-30 Tom Tromey <tom@tromey.com>
4952
4953 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4954
12a8555a
TT		 49552019-08-30 Tom Tromey <tom@tromey.com>
4956
4957 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4958 Remove unnecessary forward declarations.
4959
900ac242
TT		 49602019-08-30 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4963 rerender.
4964 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4965 tui_show_locator_content.
4966
99ab33fb
TT		 49672019-08-30 Tom Tromey <tom@tromey.com>
4968
4969 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4970 (tui_locator_window::rerender): Rewrite using body of previous
4971 tui_show_locator_content.
4972
e594a5d1
TT		 49732019-08-30 Tom Tromey <tom@tromey.com>
4974
4975 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4976 set_locator_fullname>: New methods.
4977 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4978 Rename from tui_set_locator_fullname.
4979 (tui_locator_window::set_locator_info): Rename from
4980 tui_set_locator_info. Return bool.
4981 (tui_update_locator_fullname, tui_show_frame_info): Update.
4982
715bb467
TT		 49832019-08-30 Tom Tromey <tom@tromey.com>
4984
4985 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4986
772f3f03
TT		 49872019-08-30 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4990 call touchwin.
4991
108e13ab
TT		 49922019-08-30 Tom Tromey <tom@tromey.com>
4993
4994 * tui/tui-wingeneral.c (box_win): Assume win_info and
4995 win_info->handle cannot be NULL.
4996
cdaa6eb4
TT		 49972019-08-30 Tom Tromey <tom@tromey.com>
4998
4999 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5000 refresh_window>: Declare.
5001 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5002 resize.
5003 (tui_data_item_window::rerender): Rename from
5004 tui_display_register.
5005 (tui_data_item_window::refresh_window): New method.
5006 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5007 no-op.
5008
89df7f90
TT		 50092019-08-30 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5012 regs_column_count, current_group>: Move later. Now private.
5013 <get_current_group>: New method.
5014 * tui/tui-regs.c (tui_reg_command): Update.
5015 * tui/tui-layout.c (tui_set_layout): Update.
5016
1bf2866a
TT		 50172019-08-30 Tom Tromey <tom@tromey.com>
5018
5019 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5020 (tui_data_window::rerender): Don't call
5021 check_and_display_highlight_if_needed.
5022 (tui_data_window::refresh_all): Remove call to
5023 erase_data_content.
5024
0670413d
TT		 50252019-08-30 Tom Tromey <tom@tromey.com>
5026
5027 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5028 (tui_data_window::display_registers_from)
5029 (tui_data_window::display_reg_element_at_line)
5030 (tui_data_window::display_registers_from_line): Remove checks of
5031 "empty".
5032
18bb55c7
TT		 50332019-08-30 Tom Tromey <tom@tromey.com>
5034
5035 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5036 Don't declare.
5037 * tui/tui-regs.c (tui_data_window::show_registers): Call
5038 rerender.
5039 (tui_data_window::rerender): Rename from display_all_data.
5040 (tui_data_window::rerender): Remove old implementation.
5041
1f6d2f10
TT		 50422019-08-30 Tom Tromey <tom@tromey.com>
5043
5044 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5045 text.
5046 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5047
16d01f9c
BW		 50482019-08-29 Bernhard Wodok <barto@gmx.net>
5049 Sergio Durigan Junior <sergiodj@redhat.com>
5050
5051 PR win32/24284
5052 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5053
d8f27c60
AB		 50542019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5055
5056 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5057 when searching for types.
5058
1f20c35e
AB		 50592019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5060
5061 * f-lang.c (f_language_defn): Use f_print_typedef.
5062 * f-lang.h (f_print_typedef): Declare.
5063 * f-typeprint.c (f_print_typedef): Define.
5064
550105b7
CB		 50652019-08-27 Christian Biesinger <cbiesinger@google.com>
5066
5067 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5068
4acfdd20
AB		 50692019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5070
5071 * cli/cli-utils.c (info_print_options_defs): Delete.
5072 (make_info_print_options_def_group): Delete.
5073 (extract_info_print_options): Delete.
5074 (info_print_command_completer): Delete.
5075 (info_print_args_help): Add extra parameter, and optionally
5076 include text about -n flag.
5077 * cli/cli-utils.h (struct info_print_options): Delete.
5078 (extract_info_print_options): Delete declaration.
5079 (info_print_command_completer): Delete declaration.
5080 (info_print_args_help): Add extra parameter, extend header
5081 comment.
5082 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5083 search_symbols.
5084 * stack.c (struct info_print_options): New type.
5085 (info_print_options_defs): New file scoped variable.
5086 (make_info_print_options_def_group): New static function.
5087 (info_print_command_completer): New static function.
5088 (info_locals_command): Update to use new local functions.
5089 (info_args_command): Likewise.
5090 (_initialize_stack): Add extra parameter to calls to
5091 info_print_args_help.
5092 * symtab.c (search_symbols): Add extra parameter, use this to
5093 possibly excluse non-debug symbols.
5094 (symtab_symbol_info): Add extra parameter, which is passed on to
5095 search_symbols.
5096 (struct info_print_options): New type.
5097 (info_print_options_defs): New file scoped variable.
5098 (make_info_print_options_def_group): New static function.
5099 (info_print_command_completer): New static function.
5100 (info_variables_command): Update to use local functions, and pass
5101 extra parameter through to symtab_symbol_info.
5102 (info_functions_command): Likewise.
5103 (info_types_command): Pass additional argument through to
5104 symtab_symbol_info.
5105 (rbreak_command): Pass extra argument to search_symbols.
5106 (_initialize_symtab): Add extra arguments for calls to
5107 info_print_args_help, and update help text for 'info variables',
5108 'whereis', and 'info functions' commands.
5109 * symtab.h (search_symbols): Add extra argument to declaration.
5110 * NEWS: Mention new flags.
5111
9aa55206
CB		 51122019-08-26 Christian Biesinger <cbiesinger@google.com>
5113
5114 * symtab.c (lookup_static_symbol): Call the new function (and move
5115 it down to be next to lookup_global_symbol).
5116 (struct global_sym_lookup_data): Add block_enum member and rename to...
5117 (struct global_or_static_sym_lookup_data): ...this.
5118 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5119 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5120 (lookup_symbol_global_or_static_iterator_cb): ...this.
5121 (lookup_global_or_static_symbol): New function.
5122 (lookup_global_symbol): Call new function.
5123
5c31b358
TV		 51242019-08-26 Tom de Vries <tdevries@suse.de>
5125
5126 PR c++/24852
5127 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5128 when pc_probe.prob == NULL.
5129
23c13d42
SM		 51302019-08-25 Simon Marchi <simon.marchi@efficios.com>
5131
5132 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5133 variable symbol_linkage to symbol_linkage_.
5134
beadd3e8
SM		 51352019-08-25 Simon Marchi <simon.marchi@efficios.com>
5136
5137 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5138 represent whether the symbol is static, dynamic, or we don't
5139 know.
5140
e3ec872f
YS		 51412019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5142
5143 * gdb/rx-tdep.c (rx_register_names): New.
5144 (rx_register_name): Delete.
5145 (rx_psw_type): Delete.
5146 (rx_fpsw_type): Delete.
5147 (rx_register_type): Delete.
5148 (rx_gdbarch_init): Convert target-descriptions.
5149 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5150 * gdb/features/Makefile: Add rx.xml.
5151 * gdb/features/rx.xml: New.
5152 * gdb/features/rx.c: Generated.
5153 * gdb/NEWS: Mention target description support.
5154
d0509ba4
CB		 51552019-08-22 Christian Biesinger <cbiesinger@google.com>
5156
5157 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5158 *slot_ptr.
5159
2d41fa11
SDJ		 51602019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5161
5162 * configure.ac: Don't check for 'dlfcn.h' (moved to
5163 gdbsupport/common.m4).
5164 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5165 'gdbsupport/'.
5166 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5167 * compile/compile-c-support.c: Include
5168 'gdbsupport/gdb-dlfcn.h'.
5169 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5170 * gdb-dlfcn.c: Move to...
5171 * gdbsupport/gdb-dlfcn.c: ... here.
5172 * gdb-dlfcn.h: Move to...
5173 * gdbsupport/gdb-dlfcn.h: ... here.
5174
de8af808
SL		 51752019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5176
5177 * nios2-tdep.c (struct reg_value): Improve comments. Make
5178 the offset field signed.
5179
27204489
CB		 51802019-08-22 Christian Biesinger <cbiesinger@google.com>
5181
5182 * python/lib/gdb/__init__.py (_execute_file): New function.
5183 * python/python.c (python_run_simple_file): Call gdb._execute_file
5184 on Windows.
5185
43771869
AB		 51862019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5187
5188 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5189 all uses as this was never set to anything but a zero value.
5190
26c957f1
PA		 51912019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5192
5193 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5194
c07aae6e
CB		 51952019-08-21 Christian Biesinger <cbiesinger@google.com>
5196
5197 * tui/tui-data.h (tui_gen_win_info): Add an =default
5198 move constructor, required by some GCC versions.
5199
3960cb7a
JF		 52002019-08-21 Jinke Fan <fanjinke51@yeah.net>
5201
5202 * go32-nat.c (go32_sysinfo): Add hygon_p.
5203
04c72a68
TT		 52042019-08-20 Tom Tromey <tom@tromey.com>
5205
5206 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5207 line_from_reg_element_no, first_reg_element_no_inline,
5208 display_all_data, delete_data_content_windows,
5209 erase_data_content>: Now private.
5210
072272ce
TT		 52112019-08-20 Tom Tromey <tom@tromey.com>
5212
5213 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5214 (tui_unhighlight_win, tui_highlight_win)
5215 (tui_win_info::make_window): Update.
5216 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5217
973961bd
TT		 52182019-08-20 Tom Tromey <tom@tromey.com>
5219
5220 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5221 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5222 (MAX_PID_WIDTH): Move to tui-stack.c.
5223 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5224 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5225 (MAX_PID_WIDTH): Move from tui-data.h.
5226
ab0e1f1a
TT		 52272019-08-20 Tom Tromey <tom@tromey.com>
5228
5229 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5230 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5231 (box_win): Update.
5232 (tui_gen_win_info::make_window): Rename from tui_make_window.
5233 (tui_win_info::make_window): New method.
5234 (tui_gen_win_info::make_visible): Update.
5235 * tui/tui-source.c (tui_source_window::set_contents): Update.
5236 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5237 (tui_data_window::display_registers_from): Update.
5238 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5239 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5240 Declare.
5241 <can_box>: Remove.
5242 <title>: Remove.
5243 (struct tui_win_info) <make_window>: Declare.
5244 <can_box>: Now virtual.
5245 <title>: New member.
5246 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5247 * tui/tui-command.c (tui_cmd_window::resize): Update.
5248
100c2bf3
TT		 52492019-08-20 Tom Tromey <tom@tromey.com>
5250
5251 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5252 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5253 (tui_data_window::check_register_values): Update.
5254
fa4dc567
TT		 52552019-08-20 Tom Tromey <tom@tromey.com>
5256
5257 * tui/tui-regs.h (struct tui_data_window): Use
5258 DISABLE_COPY_AND_ASSIGN.
5259 <regs_content>: Change type, removing unique_ptr.
5260 <tui_data_window>: Add move constructor.
5261 * tui/tui-regs.c (tui_data_window::show_registers)
5262 (tui_data_window::show_register_group)
5263 (tui_data_window::display_registers_from)
5264 (tui_data_window::display_registers_from)
5265 (tui_data_window::first_data_item_displayed)
5266 (tui_data_window::delete_data_content_windows)
5267 (tui_data_window::rerender, tui_data_window::refresh_window)
5268 (tui_data_window::check_register_values): Update.
5269
ca02d7c8
TT		 52702019-08-20 Tom Tromey <tom@tromey.com>
5271
5272 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5273 show_register_group>: Declare.
5274 (tui_show_register_group): Don't declare.
5275 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5276 tui_show_registers.
5277 (tui_data_window::show_register_group): Rename from
5278 tui_show_register_group.
5279 (tui_data_window::check_register_values, tui_reg_command):
5280 Update.
5281 * tui/tui-layout.c (tui_set_layout): Update.
5282
63356bfd
TT		 52832019-08-20 Tom Tromey <tom@tromey.com>
5284
5285 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5286 Declare.
5287 (tui_check_register_values): Don't declare.
5288 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5289 from tui_check_register_values.
5290 * tui/tui-hooks.c (tui_register_changed): Update.
5291
42cc14a7
TT		 52922019-08-20 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-regs.c (tui_reg_layout): Move later.
5295 (tui_show_registers): Don't enable TUI mode or change layout.
5296
b9ad3686
TT		 52972019-08-20 Tom Tromey <tom@tromey.com>
5298
5299 * tui/tui-regs.h (struct tui_data_item_window)
5300 <~tui_data_item_window>: Remove.
5301 <content>: Now a unique_xmalloc_ptr.
5302 * tui/tui-regs.c (tui_register_format): Return a
5303 unique_xmalloc_ptr.
5304 (tui_get_register): Update.
5305 (~tui_data_item_window): Remove.
5306 (tui_data_window::display_registers_from, tui_display_register):
5307 Update.
5308 * tui/tui-io.h (tui_expand_tabs): Update.
5309 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5310 Remove "col" parameter.
5311
8e114aab
TT		 53122019-08-20 Tom Tromey <tom@tromey.com>
5313
5314 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5315 field.
5316 * tui/tui-regs.c (~tui_data_item_window): Update.
5317
1a4f81dd
TT		 53182019-08-20 Tom Tromey <tom@tromey.com>
5319
5320 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5321 earlier.
5322
0f8d8876
TT		 53232019-08-20 Tom Tromey <tom@tromey.com>
5324
5325 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5326
605dc2c2
TT		 53272019-08-20 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-source.h (struct tui_source_window): Update.
5330 * tui/tui-regs.c (tui_show_registers): Update.
5331 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5332 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5333 (NO_REGS_STRING): Remove defines.
5334
aedbe3bb
CM		 53352019-08-20 Conrad Meyer <cem@FreeBSD.org>
5336
5337 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5338 unnecessary thread walk if remote doesn't support the packet.
5339
7ce8f214
TT		 53402019-08-19 Tom Tromey <tromey@adacore.com>
5341
5342 * python/py-value.c (value_has_field): Fix indentation.
5343
f21c2bd7
TT		 53442019-08-19 Tom Tromey <tromey@adacore.com>
5345
5346 * printcmd.c (do_one_display, info_display_command): Update.
5347 * block.h (contained_in): Return bool. Add allow_nested
5348 parameter.
5349 * block.c (contained_in): Return bool. Add allow_nested
5350 parameter.
5351
d806ea2d
TT		 53522019-08-19 Tom Tromey <tom@tromey.com>
5353
5354 * configure: Rebuild.
5355 * configure.ac: Disallow the combination of -static-libstdc++ and
5356 source highlight.
5357 * source-cache.c (get_language_name): Handle rust.
5358 (source_cache::get_source_lines): Ignore highlighting exceptions.
5359
398fdd60
TT		 53602019-08-16 Tom Tromey <tom@tromey.com>
5361
5362 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5363 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5364 (struct tui_source_window_base) <make_visible, refresh_window,
5365 resize>: Remove methods.
5366 <execution_info>: Remove field.
5367 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5368 (tui_show_source_line, tui_source_window_base)
5369 (~tui_source_window_base): Update.
5370 (tui_source_window_base::resize)
5371 (tui_source_window_base::make_visible)
5372 (tui_source_window_base::refresh_window): Remove.
5373 (tui_source_window_base::update_exec_info): Update.
5374 * tui/tui-source.c (tui_source_window::set_contents): Update.
5375 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5376
e699d331
TT		 53772019-08-16 Tom Tromey <tom@tromey.com>
5378
5379 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5380 deprecated_query_hook.
5381
bb01dbfc
TT		 53822019-08-16 Tom Tromey <tom@tromey.com>
5383
5384 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5385 (tui_update_source_windows_with_line): Update.
5386 * tui/tui-source.h (struct tui_source_window)
5387 <show_symtab_source>: Declare.
5388 (tui_show_symtab_source): Don't declare.
5389 * tui/tui-source.c (tui_show_symtab_source): Rename from
5390 tui_show_symtab_source.
5391
81c82c4b
TT		 53922019-08-16 Tom Tromey <tom@tromey.com>
5393
5394 * tui/tui-winsource.h (struct tui_source_window_base)
5395 <set_contents>: Declare.
5396 * tui/tui-winsource.c
5397 (tui_source_window_base::update_source_window_as_is): Update.
5398 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5399 Declare.
5400 (tui_set_source_content): Don't declare.
5401 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5402 tui_set_source_content.
5403 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5404 Declare.
5405 (tui_set_disassem_content): Don't declare.
5406 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5407 tui_set_disassem_content.
5408
2ddaf614
TT		 54092019-08-16 Tom Tromey <tom@tromey.com>
5410
5411 * tui/tui-winsource.h (struct tui_source_window_base)
5412 <update_breakpoint_info>: Declare.
5413 (tui_update_breakpoint_info): Don't declare.
5414 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5415 (tui_update_all_breakpoint_info): Update.
5416 (tui_source_window_base::update_breakpoint_info): Rename from
5417 tui_update_breakpoint_info.
5418 (tui_source_window_base::update_exec_info): Update.
5419
017f9828
TT		 54202019-08-16 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-winsource.h (struct tui_source_window_base)
5423 <update_source_window>: Declare.
5424 (tui_update_source_window): Don't declare.
5425 * tui/tui-winsource.c
5426 (tui_source_window_base::update_source_window): Rename from
5427 tui_update_source_window.
5428 (tui_source_window_base::rerender): Update.
5429 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5430 * tui/tui-disasm.c (tui_show_disassem)
5431 (tui_show_disassem_and_update_source)
5432 (tui_disasm_window::maybe_update): Update.
5433
ed8358e9
TT		 54342019-08-16 Tom Tromey <tom@tromey.com>
5435
5436 * tui/tui-winsource.h (struct tui_source_window_base)
5437 <update_source_window_as_is>: Declare.
5438 (tui_update_source_window_as_is): Don't declare.
5439 * tui/tui-winsource.c (tui_update_source_window): Update
5440 (tui_source_window_base::update_source_window_as_is): Rename from
5441 tui_update_source_window_as_is.
5442 (tui_source_window_base::refill): Update.
5443 * tui/tui-source.c (tui_show_symtab_source): Update.
5444 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5445 Update.
5446
20149b6b
TT		 54472019-08-16 Tom Tromey <tom@tromey.com>
5448
5449 * tui/tui-winsource.h (tui_update_source_window)
5450 (tui_update_source_window_as_is): Remove "noerror" parameter.
5451 * tui/tui-winsource.c (tui_update_source_window)
5452 (tui_update_source_window_as_is): Remove "noerror" parameter.
5453 (tui_update_source_windows_with_addr)
5454 (tui_update_source_windows_with_line)
5455 (tui_source_window_base::rerender)
5456 (tui_source_window_base::refill): Update.
5457 * tui/tui-source.h (tui_set_source_content)
5458 (tui_show_symtab_source): Remove "noerror" parameter.
5459 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5460 parameter.
5461 (tui_show_symtab_source): Likewise.
5462 (tui_source_window::maybe_update): Update.
5463 * tui/tui-disasm.c (tui_show_disassem)
5464 (tui_show_disassem_and_update_source)
5465 (tui_disasm_window::do_scroll_vertical)
5466 (tui_disasm_window::maybe_update): Update.
5467
2d83e710
TT		 54682019-08-16 Tom Tromey <tom@tromey.com>
5469
5470 * tui/tui.c (tui_is_window_visible): Update.
5471 * tui/tui-wingeneral.c (tui_make_window)
5472 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5473 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5474 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5475 (tui_set_win_height_command, parse_scrolling_args): Update.
5476 * tui/tui-source.c (tui_source_window::style_changed): Update.
5477 * tui/tui-regs.c (tui_show_registers)
5478 (tui_data_window::first_data_item_displayed)
5479 (tui_data_window::delete_data_content_windows)
5480 (tui_check_register_values, tui_reg_command): Update.
5481 * tui/tui-disasm.c (tui_show_disassem): Update.
5482 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5483 method.
5484 <is_visible>: Remove field.
5485 * tui/tui-data.c (tui_next_win, tui_prev_win)
5486 (tui_delete_invisible_windows): Update.
5487
d4ab829a
TT		 54882019-08-16 Tom Tromey <tom@tromey.com>
5489
5490 * tui/tui-winsource.h (struct tui_source_window_base)
5491 <m_has_locator>: Remove.
5492 * tui/tui-layout.c (show_source_disasm_command, show_data)
5493 (show_source_or_disasm_and_command): Update.
5494
aa7ca1bb
AH		 54952019-08-16 Alan Hayward <alan.hayward@arm.com>
5496
5497 * NEWS (Other MI changes): New subsection.
5498 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5499 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5500 * arch-utils.c (default_get_pc_address_flags): New function.
5501 * arch-utils.h (default_get_pc_address_flags): New declaration.
5502 * gdbarch.sh: Add get_pc_address_flags.
5503 * gdbarch.c: Regenerate.
5504 * gdbarch.h: Likewise.
5505 * stack.c (print_pc): New function.
5506 (print_frame_info) (print_frame): Call print_pc.
5507
6eac171f
TV		 55082019-08-16 Tom de Vries <tdevries@suse.de>
5509
5510 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5511 print_objfile_section_info.
5512
3df505f6
TT		 55132019-08-15 Tom Tromey <tom@tromey.com>
5514
5515 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5516 calling update_cmdwin_start_line.
5517 * tui/tui-winsource.h (struct tui_source_window_base)
5518 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5519 <rerender>: Declare.
5520 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5521 Call rerender.
5522 (tui_source_window_base::set_new_height): Remove.
5523 (tui_source_window_base::rerender): Rename from
5524 do_make_visible_with_new_height.
5525 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5526 resize method.
5527 (tui_win_info::make_invisible_and_set_new_height)
5528 (tui_win_info::make_visible_with_new_height): Remove.
5529 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5530 Declare.
5531 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5532 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5533 do_make_visible_with_new_height>: Don't declare.
5534 <rerender>: Declare.
5535 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5536 set_new_height.
5537 (tui_data_window::do_make_visible_with_new_height): Remove.
5538 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5539 call tui_show_locator_content.
5540 (tui_gen_win_info::resize): Call rerender.
5541 (show_source_or_disasm_and_command): Don't call
5542 tui_show_locator_content.
5543 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5544 method.
5545 (struct tui_win_info) <rerender>: Declare.
5546 <set_new_height, make_invisible_and_set_new_height,
5547 make_visible_with_new_height>: Don't declare.
5548 * tui/tui-data.c (tui_win_list::rerender): New method.
5549 * tui/tui-command.h (struct tui_cmd_window)
5550 <do_make_visible_with_new_height>: Don't declare.
5551 * tui/tui-command.c
5552 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5553
272560b5
TT		 55542019-08-15 Tom Tromey <tromey@adacore.com>
5555
5556 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5557 * ada-lang.c (ada_enum_name): Likewise.
5558
08235187
CB		 55592019-08-15 Christian Biesinger <cbiesinger@google.com>
5560
5561 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5562 leading underscore.
5563 (GdbOutputErrorFile): Likewise.
5564 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5565 accordingly.
5566 (execute_unwinders): Rename to have a leading underscore.
5567 (auto_load_packages): Likewise.
5568 (global scope): Adjust call to auto_load_packages accordingly.
5569 (GdbSetPythonDirectory): Likewise.
5570 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5571 instead of execute_unwinders.
5572
db502012
TT		 55732019-08-15 Tom Tromey <tom@tromey.com>
5574
5575 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5576 (show_data): Don't change window visibility.
5577 (tui_gen_win_info::resize): Remove special case for command
5578 window. Use wresize, when available.
5579 (show_source_or_disasm_and_command): Don't change window
5580 visibility.
5581 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5582 <make_visible>: New method.
5583 * tui/tui-command.c (tui_cmd_window::resize): New method.
5584
3891b65e
TT		 55852019-08-15 Tom Tromey <tom@tromey.com>
5586
5587 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5588 (struct tui_source_windows): New.
5589 * tui/tui-winsource.c (tui_display_main): Update.
5590 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5591 (new_height_ok, parse_scrolling_args): Update.
5592 * tui/tui-layout.c (show_layout, show_data): Update.
5593 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5594 (tui_add_to_source_windows): Don't declare.
5595 * tui/tui-data.c (source_windows, tui_source_windows)
5596 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5597
ee556432
TT		 55982019-08-15 Tom Tromey <tom@tromey.com>
5599
5600 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5601 Rename from reset.
5602 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5603 * tui/tui-layout.c (show_source_disasm_command, show_data):
5604 Update.
5605 (tui_gen_win_info::resize): Rename.
5606 (show_source_or_disasm_and_command): Update.
5607 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5608 reset.
5609
46f438e3
TT		 56102019-08-15 Tom Tromey <tom@tromey.com>
5611
5612 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5613 * tui/tui-interp.c (tui_interp::init): Don't call
5614 tui_initialize_static_data.
5615 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5616
f4ce562c
TT		 56172019-08-15 Tom Tromey <tom@tromey.com>
5618
5619 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5620 examine tui_win_list.
5621
c398c3d0
TT		 56222019-08-15 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5625 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5626 tui_clear_source_content.
5627 (tui_clear_source_content): Remove.
5628 (tui_source_window_base::do_erase_source_content): Hoist call to
5629 content.clear().
5630 * tui/tui-stack.c (tui_show_frame_info): Don't call
5631 tui_clear_source_content.
5632
e25d2004
TT		 56332019-08-15 Tom Tromey <tom@tromey.com>
5634
5635 * tui/tui-winsource.h (struct tui_source_window_base)
5636 <do_erase_source_content>: New method.
5637 <erase_source_content>: New method.
5638 (tui_erase_source_content): Don't declare.
5639 * tui/tui-winsource.c (tui_clear_source_content): Update.
5640 (tui_source_window_base::do_erase_source_content): Rename from
5641 tui_erase_source_content.
5642 (tui_source_window_base::show_source_content): Update.
5643 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5644 * tui/tui-source.h (struct tui_source_window)
5645 <erase_source_content>: New method.
5646 * tui/tui-disasm.h (struct tui_disasm_window)
5647 <erase_source_content>: New method.
5648
002f15c2
TT		 56492019-08-15 Tom Tromey <tom@tromey.com>
5650
5651 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5652 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5653 constructor.
5654 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5655 * tui/tui-source.c (tui_set_source_content): Update.
5656 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5657
c9033fe8
TT		 56582019-08-15 Tom Tromey <tom@tromey.com>
5659
5660 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5661 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5662 tui-source.c.
5663 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5664 Declare.
5665 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5666 method.
5667 (tui_source_window::maybe_update): Update.
5668
088f37dd
TT		 56692019-08-15 Tom Tromey <tom@tromey.com>
5670
5671 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5672 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5673 tui-disasm.c.
5674 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5675 Declare.
5676 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5677 method.
5678 (tui_disasm_window::maybe_update): Update.
5679
a54700c6
TT		 56802019-08-15 Tom Tromey <tom@tromey.com>
5681
5682 * tui/tui-winsource.h (struct tui_source_window_base)
5683 <maybe_update>: Declare.
5684 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5685 method.
5686 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5687 Declare.
5688 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5689 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5690 Declare.
5691 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5692
e2a678a5
TT		 56932019-08-15 Tom Tromey <tom@tromey.com>
5694
5695 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5696
f2dda477
TT		 56972019-08-15 Tom Tromey <tom@tromey.com>
5698
5699 * tui/tui-wingeneral.c: Include tui-stack.h.
5700 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5701 (struct tui_locator_window): Move from tui-data.h.
5702 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5703 (tui_initialize_static_data): Move from tui-data.c.
5704 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5705 (struct tui_locator_window): Move to tui-stack.c.
5706 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5707 (tui_initialize_static_data): Move to tui-stack.c.
5708
ed4a1084
TT		 57092019-08-15 Tom Tromey <tom@tromey.com>
5710
5711 * tui/tui-layout.c (show_source_disasm_command)
5712 (show_source_or_disasm_and_command): Use make_visible method, not
5713 tui_make_window.
5714 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5715 Remove.
5716
65962b20
TT		 57172019-08-15 Tom Tromey <tom@tromey.com>
5718
5719 * tui/tui-wingeneral.h (tui_make_window): Update.
5720 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5721 parameter.
5722 (tui_gen_win_info::make_visible): Update.
5723 * tui/tui-regs.c (tui_data_window::display_registers_from):
5724 Update.
5725 * tui/tui-layout.c (show_source_disasm_command)
5726 (show_source_or_disasm_and_command): Update.
5727 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5728 (enum tui_box): Remove.
5729 (struct tui_win_info) <can_box>: New method.
5730 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5731 method.
5732
2208ee91
TV		 57332019-08-15 Tom de Vries <tdevries@suse.de>
5734
5735 * linux-nat-trad.c: Include gdbarch.h.
5736
75faf5c4
AH		 57372019-08-14 Alan Hayward <alan.hayward@arm.com>
5738
5739 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5740 register sizes.
5741
b1c896b3
TT		 57422019-08-14 Tom Tromey <tromey@adacore.com>
5743
5744 * darwin-nat.c: Include gdbarch.h.
5745 * darwin-nat-info.c: Include gdbarch.h.
5746
6405cd73
TT		 57472019-08-13 Tom Tromey <tom@tromey.com>
5748
5749 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5750 Remove.
5751 * tui/tui-data.c (tui_initialize_static_data): Update.
5752
5216580d
TT		 57532019-08-13 Tom Tromey <tom@tromey.com>
5754
5755 * tui/tui-winsource.h (struct tui_exec_info_window)
5756 <~tui_exec_info_window, maybe_allocate_content, get_content,
5757 m_content>: Remove.
5758 (struct tui_source_window_base) <set_exec_info_content,
5759 show_exec_info_content>: Don't declare.
5760 * tui/tui-winsource.c
5761 (tui_exec_info_window::maybe_allocate_content): Remove.
5762 (tui_source_window_base::update_exec_info): Rename from
5763 set_exec_info_content.
5764 (tui_source_window_base::show_exec_info_content)
5765 (tui_source_window_base::update_exec_info): Remove.
5766
93858ad3
TT		 57672019-08-13 Tom Tromey <tom@tromey.com>
5768
5769 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5770 declare.
5771 * tui/tui-winsource.c (tui_update_source_window_as_is)
5772 (tui_update_source_windows_with_addr, tui_erase_source_content):
5773 Update.
5774 (tui_clear_exec_info_content): Remove.
5775
e321e7ce
TT		 57762019-08-13 Tom Tromey <tom@tromey.com>
5777
5778 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5779 declare.
5780 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5781 call tui_erase_exec_info_content.
5782 (tui_clear_exec_info_content): Rename from
5783 tui_erase_exec_info_content.
5784 (tui_clear_exec_info_content): Delete.
5785
8270ac62
TT		 57862019-08-13 Tom Tromey <tom@tromey.com>
5787
5788 * tui/tui-winsource.h (struct tui_source_window_base)
5789 <show_exec_info_content>: Declare.
5790 (tui_show_exec_info_content): Don't declare.
5791 * tui/tui-winsource.c
5792 (tui_source_window_base::show_exec_info_content): Rename from
5793 tui_show_exec_info_content.
5794 (tui_source_window_base::update_exec_info): Update.
5795
7b56485d
TT		 57962019-08-13 Tom Tromey <tom@tromey.com>
5797
5798 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5799 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5800 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5801 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5802 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5803 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5804 ... here.
5805
7ba913dc
TT		 58062019-08-13 Tom Tromey <tom@tromey.com>
5807
5808 * tui/tui-winsource.h (struct tui_source_window_base)
5809 <update_exec_info>: Declare.
5810 (tui_update_exec_info): Don't declare.
5811 * tui/tui-winsource.c (tui_update_source_window_as_is)
5812 (tui_source_window_base::refresh_all)
5813 (tui_update_all_breakpoint_info): Update.
5814 (tui_source_window_base::update_exec_info): Rename from
5815 tui_update_exec_info.
5816 * tui/tui-stack.c (tui_show_frame_info): Update.
5817
37a4a131
TT		 58182019-08-13 Tom Tromey <tom@tromey.com>
5819
5820 * tui/tui-winsource.h (struct tui_source_window_base)
5821 <set_exec_info_content>: Declare.
5822 (tui_set_exec_info_content): Don't declare.
5823 * tui/tui-winsource.c
5824 (tui_source_window_base::set_exec_info_content): Rename from
5825 tui_set_exec_info_content.
5826 (tui_update_exec_info): Update.
5827
0bd27e07
TT		 58282019-08-13 Tom Tromey <tom@tromey.com>
5829
5830 * tui/tui-winsource.h (struct tui_source_window_base)
5831 <show_source_content>: Declare.
5832 (tui_show_source_content): Don't declare.
5833 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5834 (tui_source_window_base::show_source_content): Rename from
5835 tui_show_source_content.
5836 (tui_source_window_base::refresh_all): Update.
5837 * tui/tui-layout.c (show_source_disasm_command)
5838 (show_source_or_disasm_and_command): Update.
5839
b4ef5aeb
TT		 58402019-08-13 Tom Tromey <tom@tromey.com>
5841
5842 * tui/tui-winsource.c (tui_erase_source_content)
5843 (tui_show_source_content, tui_source_window_base::refresh_all):
5844 Update.
5845 * tui/tui-wingeneral.h
5846 (tui_check_and_display_highlight_if_needed): Don't declare.
5847 * tui/tui-wingeneral.c
5848 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5849 check_and_display_highlight_if_needed.
5850 * tui/tui-win.c (tui_rehighlight_all)
5851 (tui_win_info::make_visible_with_new_height): Update.
5852 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5853 (tui_data_window::erase_data_content)
5854 (tui_data_window::display_all_data): Update.
5855 * tui/tui-data.h (struct tui_win_info)
5856 <check_and_display_highlight_if_needed>: Declare.
5857
fede5273
TT		 58582019-08-13 Tom Tromey <tom@tromey.com>
5859
5860 * tui/tui-win.c (tui_resize_all): Call
5861 tui_delete_invisible_windows.
5862 * tui/tui-layout.c (show_layout): Call
5863 tui_delete_invisible_windows.
5864 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5865 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5866
22c3f490
TT		 58672019-08-13 Tom Tromey <tom@tromey.com>
5868
5869 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5870 tui_add_win_to_layout.
5871
16cb7910
TT		 58722019-08-13 Tom Tromey <tom@tromey.com>
5873
5874 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5875 * tui/tui-layout.c (tui_default_win_height): Now static.
5876
cc0c3ffb
TT		 58772019-08-13 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5880 single switch.
5881 (show_source_disasm_command, show_source_or_disasm_and_command):
5882 Don't check current layout.
5883
3f3ffe54
TT		 58842019-08-13 Tom Tromey <tom@tromey.com>
5885
5886 * tui/tui-wingeneral.c (make_all_visible): Remove.
5887 (tui_make_all_invisible): Simplify.
5888 * tui/tui-layout.c (tui_make_all_invisible): Move from
5889 tui-wingeneral.c; simplify.
5890 (show_layout): Hoist call to tui_make_all_invisible.
5891 (show_data): Don't call tui_make_all_invisible.
5892
69258091
TT		 58932019-08-13 Tom Tromey <tom@tromey.com>
5894
5895 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5896 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5897
62cf57fe
TT		 58982019-08-13 Tom Tromey <tom@tromey.com>
5899
5900 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5901 tui-data.c.
5902 (show_source_disasm_command, show_data)
5903 (show_source_or_disasm_and_command): Don't use
5904 tui_set_current_layout_to.
5905 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5906 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5907 tui-layout.c.
5908 (tui_set_current_layout_to): Remove.
5909
2afade5d
TT		 59102019-08-13 Tom Tromey <tom@tromey.com>
5911
5912 * tui/tui-layout.c (tui_set_layout): Update.
5913 * tui/tui-data.h (struct tui_layout_def): Remove.
5914 (tui_layout_def): Don't declare.
5915 * tui/tui-data.c (layout_def): Remove.
5916 (tui_layout_def): Remove.
5917
a3504e96
TT		 59182019-08-13 Tom Tromey <tom@tromey.com>
5919
5920 * tui/tui-winsource.h (struct tui_source_window_base)
5921 <clear_detail>: No longer "override".
5922 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5923 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5924 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5925 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5926 Remove.
5927 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5928
29c92911
TT		 59292019-08-13 Tom Tromey <tromey@adacore.com>
5930
5931 * tracepoint.c: Don't include readline.h or history.h.
5932
86c6b807
TT		 59332019-08-12 Tom Tromey <tom@tromey.com>
5934
5935 * configure: Rebuild.
5936 * configure.ac: Check for readline 7.
5937 * NEWS: Mention readline 7 requirement.
5938 * README: Update.
5939
5db2718c
TT		 59402019-08-12 Tom Tromey <tom@tromey.com>
5941
5942 * mingw-hdep.c (gdb_select): Remove readline hack.
5943
dac36daf
PFC		 59442019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5945
5946 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5947 when the function fails.
5948
1022c627
AA		 59492019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5950
5951 * s390-tdep.c (s390_type_align): New function.
5952 (s390_gdbarch_init): Set it as type_align gdbarch method.
5953
eba4caf2
TV		 59542019-08-09 Tom de Vries <tdevries@suse.de>
5955
5956 PR gdb/24591
5957 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5958 pc_low with relocation offset.
5959
123cd851
TT		 59602019-08-07 Tom Tromey <tromey@adacore.com>
5961
5962 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5963 (print_frame_args): Update.
5964 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5965 Update.
5966 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5967 * frame.h (struct frame_arg): Add initializers.
5968 <error>: Now a unique_xmalloc_ptr.
5969
3d31bc39
AH		 59702019-08-07 Alan Hayward <alan.hayward@arm.com>
5971
5972 * NEWS: Expand the Pointer Authentication entry.
5973 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5974 (aarch64_frame_unmask_lr): ... to this.
5975 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5976 Call aarch64_frame_unmask_lr.
5977 * frame.c (struct frame_info): Add "masked" variable.
5978 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5979 (fprint_frame): Check for masked pc.
5980 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5981 declarations.
5982 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5983 * stack.c (print_frame): Check for masked pc.
5984
0cf9feb9
TT		 59852019-08-06 Tom Tromey <tom@tromey.com>
5986
5987 * stabsread.c (patch_block_stabs, read_one_struct_field)
5988 (read_enum_type): Use obstack_strndup.
5989 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5990 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5991 * dwarf2read.c (guess_full_die_structure_name)
5992 (anonymous_struct_prefix): Use obstack_strndup.
5993 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5994 * c-exp.y (yylex): Use obstack_strndup.
5995 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5996 (write_var_or_type): Use obstack_strndup.
5997
efba19b0
TT		 59982019-08-06 Tom Tromey <tom@tromey.com>
5999
6000 * symfile.c (reread_symbols): Use obstack_strdup.
6001 * stabsread.c (read_type): Use obstack_strdup.
6002 * gdb_obstack.h (obstack_strdup): New overload.
6003 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6004 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6005 (dwarf2_canonicalize_name): Use obstack_strdup.
6006 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6007 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6008 Use obstack_strdup.
6009
f25102f7
TT		 60102019-08-06 Tom Tromey <tom@tromey.com>
6011
6012 * gdb_obstack.h (obstack_strdup): Define.
6013 * gdb_obstack.c (obstack_strdup): Don't define.
6014
021887d8
TT		 60152019-08-06 Tom Tromey <tom@tromey.com>
6016
6017 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6018 obstack_strdup.
6019 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6020 obstack_strdup.
6021 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6022 * stabsread.c (common_block_start): Use obstack_strdup.
6023 * objfiles.c (set_objfile_main_name, objfile): Use
6024 obstack_strdup.
6025 * namespace.c (add_using_directive): Use obstack_strdup.
6026 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6027 * jit.c (finalize_symtab): Use obstack_strdup.
6028 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6029 (guess_partial_die_structure_name, partial_die_info::fixup)
6030 (dwarf2_name): Use obstack_strdup.
6031 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6032 obstack_strdup.
6033 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6034 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6035 obstack_strdup.
6036 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6037
d2834edc
PW		 60382019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6039
6040 * unittests/help-doc-selftests.c: New file.
6041 * Makefile.in: Add the new file.
6042
590042fc
PW		 60432019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6044
6045 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6046 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6047 the full first line, except when FOR_VALUE_PREFIX. In this case,
6048 the trailing '.' is not output, and the first character is uppercased.
6049 (print_help_for_command): Update call to print_doc_line.
6050 (print_doc_of_command): Likewise.
6051 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6052 * cli/cli-option.c (append_indented_doc): Do not append newline.
6053 (build_help_option): Append newline after first appended_indented_doc
6054 only if a second call is done.
6055 (build_help): Append 2 new lines before each option, except the first
6056 one.
6057 * compile/compile.c (_initialize_compile): Add new lines after
6058 %OPTIONS%, when not at the end of the help.
6059 Change help doc or code
6060 producing the help doc to respect the invariants.
6061 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6062 Also removed the new line after 'Options:', as all other commands
6063 do not put an empty line between 'Options:' and the first option.
6064 * printcmd.c (_initialize_printcmd): Likewise.
6065 * stack.c (_initialize_stack): Likewise.
6066 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6067 incorrectly telling COMMAND is optional.
6068 * ada-lang.c (_initialize_ada_language): Change help doc or code
6069 producing the help doc to respect the invariants.
6070 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6071 * breakpoint.c (_initialize_breakpoint): Likewise.
6072 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6073 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6074 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6075 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6076 _initialize_cli_style): Likewise.
6077 * corelow.c (core_target_info): Likewise.
6078 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6079 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6080 * filesystem.c (_initialize_filesystem): Likewise.
6081 * frame.c (_initialize_frame): Likewise.
6082 * gnu-nat.c (add_task_commands): Likewise.
6083 * infcall.c (_initialize_infcall): Likewise.
6084 * infcmd.c (_initialize_infcmd): Likewise.
6085 * interps.c (_initialize_interpreter): Likewise.
6086 * language.c (_initialize_language): Likewise.
6087 * linux-fork.c (_initialize_linux_fork): Likewise.
6088 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6089 * maint.c (_initialize_maint_cmds): Likewise.
6090 * memattr.c (_initialize_mem): Likewise.
6091 * printcmd.c (_initialize_printcmd): Likewise.
6092 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6093 _RegEx): Likewise.
6094 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6095 * record-btrace.c (_initialize_record_btrace): Likewise.
6096 * record-full.c (_initialize_record_full): Likewise.
6097 * record.c (_initialize_record): Likewise.
6098 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6099 * regcache.c (_initialize_regcache): Likewise.
6100 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6101 _initialize_remote): Likewise.
6102 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6103 * serial.c (_initialize_serial): Likewise.
6104 * skip.c (_initialize_step_skip): Likewise.
6105 * source.c (_initialize_source): Likewise.
6106 * stack.c (_initialize_stack): Likewise.
6107 * symfile.c (_initialize_symfile): Likewise.
6108 * symtab.c (_initialize_symtab): Likewise.
6109 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6110 * top.c (init_main): Likewise.
6111 * tracefile-tfile.c (tfile_target_info): Likewise.
6112 * tracepoint.c (_initialize_tracepoint): Likewise.
6113 * tui/tui-win.c (_initialize_tui_win): Likewise.
6114 * utils.c (add_internal_problem_command): Likewise.
6115 * valprint.c (value_print_option_defs): Likewise.
6116
404f2902
FCE		 61172019-08-06 Frank Ch. Eigler <fche@redhat.com>
6118
6119 PR build/24886
6120 * configure.ac: Drop enable-libmcheck support.
6121 * configure, config.in: Rebuild.
6122 * libmcheck.m4: Remove.
6123 * acinclude.m4: Don't include it.
6124 * Makefile.in: Don't distribute it.
6125 * top.c (print_gdb_configuration): Don't mention it.
6126
046bebe1
TT		 61272019-08-06 Tom Tromey <tom@tromey.com>
6128
6129 * utils.c (set_output_style): Sometimes pass stream to
6130 emit_style_escape.
6131 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6132 * record-btrace.c (btrace_insn_history): Update.
6133 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6134 method.
6135 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6136 Update initializers.
6137 <m_uiout>: New field.
6138 <m_di>: Move lower.
6139 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6140 Remove "uiout" parameter.
6141 (dump_insns): Update.
6142 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6143 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6144
ddbcedf5
CB		 61452019-08-06 Christian Biesinger <cbiesinger@google.com>
6146
6147 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6148 (error_in_psymtab_expansion): Likewise.
6149 (lookup_symbol_via_quick_fns): Likewise.
6150 (basic_lookup_transparent_type_quick): Likewise.
6151 (basic_lookup_transparent_type_1): Likewise.
6152
b08b16c8
TT		 61532019-08-06 Tom Tromey <tromey@adacore.com>
6154
6155 * source.c (last_source_error): Now bool.
6156 (print_source_lines_base): Make "noprint" bool. Only open
6157 source file when last_source_visited changes.
6158
cb44333d
TT		 61592019-08-06 Tom Tromey <tromey@adacore.com>
6160
6161 * annotate.c (annotate_source_line): Use g_source_cache.
6162 * source-cache.c (source_cache::get_plain_source_lines): Change
6163 parameters. Populate m_offset_cache.
6164 (source_cache::ensure): New method.
6165 (source_cache::get_line_charpos): New method.
6166 (extract_lines): Move lower. Change parameters.
6167 (source_cache::get_source_lines): Move lower.
6168 * source-cache.h (class source_cache): Update comment.
6169 <get_line_charpos>: New method.
6170 <get_source_lines>: Update comment.
6171 <clear>: Clear m_offset_cache.
6172 <get_plain_source_lines>: Change parameters.
6173 <ensure>: New method
6174 <m_offset_cache>: New member.
6175 * source.c (forget_cached_source_info_for_objfile): Update.
6176 (info_source_command): Use g_source_cache.
6177 (find_source_lines, open_source_file_with_line_charpos): Remove.
6178 (print_source_lines_base, search_command_helper): Use g_source_cache.
6179 * source.h (open_source_file_with_line_charpos): Don't declare.
6180 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6181 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6182 Use g_source_cache.
6183
872dceaa
TT		 61842019-08-06 Tom Tromey <tromey@adacore.com>
6185
6186 * source-cache.c (source_cache::get_plain_source_lines):
6187 Remove "first_line" and "last_line" parameters.
6188 (source_cache::get_source_lines): Cache plain text.
6189 * source-cache.h (class source_cache)
6190 <get_plain_source_lines>: Update.
6191
269249d9
TT		 61922019-08-06 Tom Tromey <tromey@adacore.com>
6193
6194 * source-cache.c (extract_lines): No longer a method.
6195 Changed type of parameter. Include final newline.
6196 (selftests::extract_lines_test): New function.
6197 (_initialize_source_cache): Likewise.
6198 * source-cache.h (class source_cache)
6199 <extract_lines>: Don't declare.
6200
c0e8dcd8
TT		 62012019-08-06 Tom Tromey <tromey@adacore.com>
6202
6203 * breakpoint.c (init_breakpoint_sal): Update.
6204 (breakpoint): Update.
6205 * breakpoint.h (struct breakpoint) <filter>: Now a
6206 unique_xmalloc_ptr.
6207
0b27c27d
CB		 62082019-08-05 Christian Biesinger <cbiesinger@google.com>
6209
6210 * NEWS: Mention dictionary access on blocks.
6211 * python/py-block.c (blpy_getitem): New function.
6212 (block_object_as_mapping): New struct.
6213 (block_object_type): Use new struct for tp_as_mapping field.
6214
4ee94178
CB		 62152019-08-05 Christian Biesinger <cbiesinger@google.com>
6216
6217 * objfiles.h (objfile): Add a comment describing partial symbols.
6218
8abfcabc
TT		 62192019-08-05 Tom Tromey <tromey@adacore.com>
6220
6221 * compile/compile.c (_initialize_compile): Use _(), not N_().
6222 * thread.c (_initialize_thread): Use _(), not N_().
6223 * stack.c (_initialize_stack): Use _(), not N_().
6224 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6225
2b79f376
SM		 62262019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6227
6228 * dwarf2read.c (struct dw2_symtab_iterator):
6229 <want_specific_block>: Remove.
6230 <block_index>: Change type to gdb::optional.
6231 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6232 change type of BLOCK_INDEX parameter to gdb::optional.
6233 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6234 (dw2_lookup_symbol): Don't pass argument for
6235 WANT_SPECIFIC_BLOCK.
6236 (dw2_expand_symtabs_for_function): Don't pass argument for
6237 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6238 (class dw2_debug_names_iterator)
6239 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6240 parameter, change BLOCK_INDEX type to gdb::optional.
6241 <m_want_specific_block>: Remove.
6242 <m_block_index>: Change type to gdb::optional.
6243 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6244 gdb::optional. Re-write in function of gdb::optional.
6245 (dw2_debug_names_lookup_symbol): Don't pass argument for
6246 WANT_SPECIFIC_BLOCK.
6247 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6248 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6249 BLOCK_INDEX.
6250
ae60f04e
PW		 62512019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6252
6253 * NEWS: Mention changes to "info sources" command.
6254
28cd9371
PW		 62552019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6256
6257 * symtab.c (filename_partial_match_opts): New struct type.
6258 (struct output_source_filename_data): New members
6259 regexp, c_regexp, partial_match.
6260 (output_source_filename): Use new members to decide to print file.
6261 (info_sources_option_defs): New variable.
6262 (make_info_sources_options_def_group, print_info_sources_header,
6263 info_sources_command_completer):
6264 New functions.
6265 (info_sources_command): Read new optional arguments.
6266 (_initialize_symtab): Update info sources help.
6267
ca683e3a
AO		 62682019-08-02 Alexandre Oliva <oliva@adacore.com>
6269
6270 * ada-lang.c (exception_support_info_v0): Renamed from...
6271 (default_exception_support_info): ... this. Create new
6272 definition for v1.
6273 (ada_has_this_exception_support): Look up catch_handlers_sym.
6274 (ada_exception_support_info_sniffer): Try v0 after default.
6275
f1264162
TT		 62762019-08-01 Tom Tromey <tromey@adacore.com>
6277
6278 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6279 gdbarch.h.
6280
0a7b2485
CB		 62812019-08-01 Christian Biesinger <cbiesinger@google.com>
6282
6283 * s12z-tdep.c: Fix include path for s12z-opc.h.
6284
c6bdbeb7
AH		 62852019-08-01 Alan Hayward <alan.hayward@arm.com>
6286
6287 * NEWS: Require GNU make 3.82.
6288
a2bd7b82
TT		 62892019-07-16 Tom Tromey <tom@tromey.com>
6290
6291 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6292 declare.
6293
aa3b6533
TT		 62942019-07-30 Tom Tromey <tromey@adacore.com>
6295
6296 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6297
a1530dc7
KB		 62982019-07-30 Kevin Buettner <kevinb@redhat.com>
6299
6300 * printcmd.c (print_address_symbolic): Print negative offsets.
6301 (build_address_symbolic): Force signed arithmetic when computing
6302 offset.
6303
2906593f
CB		 63042019-07-30 Christian Biesinger <cbiesinger@google.com>
6305
6306 PR/24474: Add a function to lookup static variables.
6307 * NEWS: Mention this new function.
6308 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6309 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6310 * python/python.c (python_GdbMethods): Add new function.
6311
c620ed88
CB		 63122019-07-29 Christian Biesinger <cbiesinger@google.com>
6313
6314 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6315 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6316 (objfpy_lookup_static_symbol): New function.
6317 (objfile_object_methods): Add new functions.
6318
bc4268a5
PW		 63192019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6320
6321 * NEWS: Mention 'set|show print frame-info'. Mention new
6322 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6323 backtrace argument. Mention that python frame filtering code
6324 is now consistent with what 'backtrace' command prints.
6325
4b5e8d19
PW		 63262019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6327
6328 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6329 comments.
6330 (print_frame_info_auto, print_frame_info_source_line,
6331 print_frame_info_location, print_frame_info_source_and_location,
6332 print_frame_info_location_and_address, print_frame_info_short_location):
6333 New declarations.
6334 (struct frame_print_options): New member print_frame_info.
6335 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6336 * stack.h (get_user_print_what_frame_info): New declaration.
6337 (frame_show_address): New declaration.
6338 * stack.c (print_frame_arguments_choices): New value 'presence'.
6339 (print_frame_info_auto, print_frame_info_source_line,
6340 print_frame_info_location, print_frame_info_source_and_location,
6341 print_frame_info_location_and_address, print_frame_info_short_location,
6342 print_frame_info_choices, print_frame_info_print_what): New definitions.
6343 (print_frame_args): Only print dots for args if print frame-arguments
6344 is 'presence'.
6345 (frame_print_option_defs): New element for "frame-info".
6346 (get_user_print_what_frame_info): New function.
6347 (frame_show_address): Make non static. Move comment to stack.h.
6348 (print_frame_info_to_print_what): New function.
6349 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6350 to decide what to print.
6351 (backtrace_command_1): Handle the new print_frame_arguments_presence
6352 value.
6353 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6354 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6355 (py_print_frame): In non-mi mode, use LOCATION as default for
6356 print_what, similarly to frame information printed directly by
6357 backtrace command. Handle frame-info user option in non MI mode.
6358
6bdfee81
KB		 63592019-07-27 Kevin Buettner <kevinb@redhat.com>
6360
6361 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6362 Add case for debugging 32-bit target on 64-bit host. Revise
6363 comment.
6364
98a617f8
KB		 63652019-07-27 Kevin Buettner <kevinb@redhat.com>
6366
6367 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6368 instead of find_function_entry_range_from_pc.
6369
567238c9
KB		 63702019-07-27 Kevin Buettner <kevinb@redhat.com>
6371
6372 * stack.c (find_frame_funname): Remove code which preferred
6373 minsym over symtab sym in "certain pathological cases".
6374
2dc80cf8
KB		 6375 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6376 parameter. Change type of "do_demangle" to bool.
6377 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6378 Pass suitable "prefer_sym_over_minsym" flag to
6379 build_address_symbolic(). Don't output "+" for negative offsets.
6380 * printcmd.c (print_address_symbolic): Update invocation of
6381 build_address_symbolic to include a "prefer_sym_over_minsym"
6382 flag.
6383 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6384 Restrict cases in which use of minimal symbol is preferred to that
6385 of a found symbol. Update comments.
6386
1aff7173
KB		 6387 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6388 for entry pc when entry pc is out of range for that FDE.
6389
89b085ac
BC		 63902019-07-26 Brian Callahan <bcallah@openbsd.org>
6391
6392 PR gdb/24839:
6393 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6394 type.
6395
f32feb4a
CB		 63962019-07-25 Christian Biesinger <cbiesinger@google.com>
6397
6398 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6399 this function's Python signature.
6400
6401
64022019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 6403
6404 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6405 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6406 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6407 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6408 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6409
6410
c54e4253
YS		 64112019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6412
6413 * h8300-tdep.c (h8300_register_name_common): New.
6414 h8300_register_name): Use h8300_register_name_common.
6415 (h8300s_register_name): Likewise.
6416 (h8300sx_register_name): Likewise.
6417 (h8300h_register_nam): New.
6418 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6419
6420
40eadf04
SP		 64212019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6422
6423 * arm-tdep.c (arm_skip_cmse_entry): New function.
6424 (arm_is_sgstubs_section): New function.
6425 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6426
bfa2a36d
TT		 64272019-07-22 Tom Tromey <tom@tromey.com>
6428
6429 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6430 Don't self-assign.
6431
a8e9d247
AB		 64322019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6433
6434 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6435 type_print.
6436
eb86c5e2
AB		 64372019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6438
6439 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6440 so that GDB doesn't match any msymbols when searching in the
6441 TYPES_DOMAIN.
6442 (print_symbol_info): Print using typedef_print or type_print based
6443 on the type of the symbol. Add updated FIXME comment moved from...
6444 (_initialize_symtab): ... move and update FIXME comment to above.
6445
a8eab7c6
AB		 64462019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6447
6448 * NEWS: Mention adding -q option to "info types".
6449 * symtab.c (struct info_types_options): New struct.
6450 (info_types_options_defs): New variable.
6451 (make_info_types_options_def_group): New function.
6452 (info_types_command): Use gdb::option framework to parse options.
6453 (info_types_command_completer): New function.
6454 (_initialize_symtab): Extend the help text on "info types" and
6455 register command completer.
6456
b4603c34
CB		 64572019-07-21 Christian Biesinger <cbiesinger@google.com>
6458
6459 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6460 (lookup_symbol_in_objfile): Change int to block_enum and add a
6461 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6462
c8cdc1e0
CB		 64632019-07-20 Christian Biesinger <cbiesinger@google.com>
6464
6465 * MAINTAINERS (Write After Approval): Add self.
6466
01e175fe
AB		 64672019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6468
6469 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6470 instruction to the dummy code region.
6471
56f79b63
TT		 64722019-07-19 Tom Tromey <tromey@adacore.com>
6473
6474 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6475 (ARGSUSED, PARAMS, __func__): Remove rules.
6476
4c5aa8e0
AH		 64772019-07-19 Alan Hayward <alan.hayward@arm.com>
6478
6479 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6480 * features/arm/arm-with-iwmmxt.c: Remove.
6481 * features/arm/arm-with-iwmmxt.xml: Remove.
6482 * features/arm/arm-with-m-fpa-layout.c: Remove.
6483 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6484 * features/arm/arm-with-m-vfp-d16.c: Remove.
6485 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6486 * features/arm/arm-with-m.c: Remove.
6487 * features/arm/arm-with-m.xml: Remove.
6488 * features/arm/arm-with-neon.c: Remove.
6489 * features/arm/arm-with-neon.xml: Remove.
6490 * features/arm/arm-with-vfpv2.c: Remove.
6491 * features/arm/arm-with-vfpv2.xml: Remove.
6492 * features/arm/arm-with-vfpv3.c: Remove.
6493 * features/arm/arm-with-vfpv3.xml: Remove.
6494
f42b2617
AH		 64952019-07-19 Alan Hayward <alan.hayward@arm.com>
6496
6497 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6498
f29ec966
AH		 64992019-07-19 Alan Hayward <alan.hayward@arm.com>
6500
6501 * arch/aarch32.c (aarch32_create_target_description): Create
6502 target descriptions using features.
6503 * arch/arm.c (arm_create_target_description)
6504 (arm_create_mprofile_target_description): Likewise.
6505 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6506
d105cce5
AH		 65072019-07-19 Alan Hayward <alan.hayward@arm.com>
6508
6509 * Makefile.in: Add new files.
6510 * aarch32-tdep.c: New file.
6511 * aarch32-tdep.h: New file.
6512 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6513 Call aarch32_read_description.
6514 * arch/aarch32.c: New file.
6515 * arch/aarch32.h: New file.
6516 * arch/arm.c (arm_create_target_description)
6517 (arm_create_mprofile_target_description): New function.
6518 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6519 (arm_create_target_description)
6520 (arm_create_mprofile_target_description): New declaration.
6521 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6522 read_description functions.
6523 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6524 Likewise.
6525 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6526 * arm-tdep.c (tdesc_arm_list): New variable.
6527 (arm_register_g_packet_guesses): Call create description functions.
6528 (arm_read_description) (arm_read_mprofile_description): New
6529 function.
6530 * arm-tdep.h (arm_read_description)
6531 (arm_read_mprofile_description): Add declaration.
6532 * configure.tgt: Add new files.
6533
afe09f0b
GL		 65342019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6535
6536 * top.c (new_ui_command): Open specified terminal just once.
6537
cd215b2e
TT		 65382019-07-18 Tom Tromey <tromey@adacore.com>
6539
6540 * symtab.c (main_name): Constify return type.
6541 * symfile.c (set_initial_language): Update.
6542 * symtab.h (main_name): Constify return type.
6543
d8f68fcb
TT		 65442019-07-17 Tom Tromey <tom@tromey.com>
6545
6546 * tui/tui-winsource.c (tui_update_source_window)
6547 (tui_update_source_window_as_is)
6548 (tui_update_source_windows_with_line): Remove return.
6549 * tui/tui-disasm.c (tui_show_disassem)
6550 (tui_show_disassem_and_update_source): Remove return.
6551 * tui/tui.c (tui_reset): Remove return.
6552 * tui/tui-wingeneral.c
6553 (tui_check_and_display_highlight_if_needed): Remove return.
6554
ca5af91e
TT		 65552019-07-17 Tom Tromey <tom@tromey.com>
6556
6557 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6558
5104fe36
TT		 65592019-07-17 Tom Tromey <tom@tromey.com>
6560
6561 * tui/tui-winsource.h (struct tui_exec_info_window)
6562 (struct tui_source_window_base): Move from tui-data.h.
6563 * tui/tui-winsource.c: Move many method definitions from
6564 elsewhere. Remove "structuring" comments.
6565 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6566 (tui_source_window_base::refresh_window): Move to
6567 tui-winsource.c.
6568 * tui/tui-win.c (tui_source_window_base::refresh_all)
6569 (tui_source_window_base::update_tab_width)
6570 (tui_source_window_base::set_new_height)
6571 (tui_source_window_base::do_make_visible_with_new_height): Move to
6572 tui-winsource.c.
6573 * tui/tui-source.h: Update.
6574 * tui/tui-source.c (tui_source_window_base::reset): Move to
6575 tui-winsource.c.
6576 * tui/tui-disasm.h: Update.
6577 * tui/tui-data.h (struct tui_exec_info_window): Move to
6578 tui-winsource.h.
6579 (struct tui_source_window_base): Likewise.
6580 * tui/tui-data.c (tui_source_window_base::clear_detail)
6581 (tui_source_window_base, ~tui_source_window_base): Move to
6582 tui-winsource.c.
6583
daa15dde
TT		 65842019-07-17 Tom Tromey <tom@tromey.com>
6585
6586 * tui/tui-win.c (tui_resize_all)
6587 (tui_source_window_base::update_tab_width)
6588 (tui_adjust_win_heights): Update.
6589 (tui_win_info::make_invisible_and_set_new_height): Rename from
6590 make_invisible_and_set_new_height.
6591 * tui/tui-data.h (struct tui_win_info)
6592 <make_invisible_and_set_new_height>: New method.
6593
bfad4537
TT		 65942019-07-17 Tom Tromey <tom@tromey.com>
6595
6596 * tui/tui.c: Update.
6597 * tui/tui-source.h (struct tui_source_window): Move from
6598 tui-data.h.
6599 * tui/tui-layout.c: Update.
6600 * tui/tui-disasm.c: Update.
6601 * tui/tui-data.h (struct tui_source_window): Move to
6602 tui-source.h.
6603
88f7e873
TT		 66042019-07-17 Tom Tromey <tom@tromey.com>
6605
6606 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6607 tui-data.h.
6608 * tui/tui-data.h (struct tui_disasm_window): Move to
6609 tui-disasm.h.
6610
96bd6233
TT		 66112019-07-17 Tom Tromey <tom@tromey.com>
6612
6613 * tui/tui-regs.h (struct tui_data_item_window): Move from
6614 tui-data.h.
6615 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6616 * tui/tui-data.h (struct tui_data_item_window): Move to
6617 tui-regs.h.
6618 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6619
ce38393b
TT		 66202019-07-17 Tom Tromey <tom@tromey.com>
6621
6622 * tui/tui.c: Update.
6623 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6624 (tui_cmd_window::max_height): Move to tui-command.c.
6625 * tui/tui-layout.c: Update.
6626 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6627 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6628 tui-command.c.
6629 * tui/tui-command.h (struct tui_cmd_window): Move from
6630 tui-data.h.
6631 * tui/tui-command.c: Remove "structuring" comments.
6632 (tui_cmd_window::clear_detail)
6633 (tui_cmd_window::do_make_visible_with_new_height)
6634 (tui_cmd_window::max_height): Move from elsewhere.
6635
2d8b51cb
TT		 66362019-07-17 Tom Tromey <tom@tromey.com>
6637
6638 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6639 Now static.
6640 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6641 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6642
18ab23af
TT		 66432019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui.c: Update.
6646 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6647 tui-regs.c.
6648 * tui/tui-windata.h: Remove file.
6649 * tui/tui-windata.c: Remove file.
6650 * tui/tui-win.c (tui_data_window::set_new_height)
6651 (tui_data_window::do_make_visible_with_new_height): Move to
6652 tui-regs.c.
6653 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6654 * tui/tui-regs.c: Remove "structuring" comments.
6655 (tui_data_window::first_data_item_displayed)
6656 (tui_data_window::delete_data_content_windows)
6657 (tui_data_window::erase_data_content)
6658 (tui_data_window::display_all_data)
6659 (tui_data_window::refresh_all)
6660 (tui_data_window::do_scroll_vertical)
6661 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6662 (tui_data_window::do_make_visible_with_new_height)
6663 (tui_data_window::refresh_window): Move from elsewhere.
6664 (_initialize_tui_regs): Move to end of file.
6665 * tui/tui-layout.c: Update.
6666 * tui/tui-hooks.c: Update.
6667 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6668 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6669 tui-regs.c.
6670 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6671
88b7e7cc
TT		 66722019-07-17 Tom Tromey <tom@tromey.com>
6673
6674 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6675 seen.
6676
0fcd3711
TT		 66772019-07-17 Tom Tromey <tom@tromey.com>
6678
6679 * tui/tui-win.c (tui_source_window_base::set_new_height)
6680 (tui_source_window_base::do_make_visible_with_new_height): Use
6681 m_has_locator field directly.
6682 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6683 method.
6684 (struct tui_source_window_base) <has_locator>: Likewise.
6685
4a38112d
TT		 66862019-07-17 Tom Tromey <tom@tromey.com>
6687
6688 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6689 Don't declare.
6690 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6691 Remove.
6692 * tui/tui-win.c (tui_source_window_base::set_new_height)
6693 (tui_source_window_base::set_new_height)
6694 (make_invisible_and_set_new_height)
6695 (tui_source_window_base::do_make_visible_with_new_height)
6696 (tui_source_window_base::do_make_visible_with_new_height):
6697 Update.
6698 * tui/tui-layout.c (show_source_disasm_command, show_data)
6699 (show_source_or_disasm_and_command): Update.
6700 * tui/tui-layout.c (show_layout): Update.
6701
09129226
TT		 67022019-07-17 Tom Tromey <tom@tromey.com>
6703
6704 * tui/tui-layout.c (make_data_window): Remove.
6705 (show_data): Unify creation and re-initialization cases.
6706
4a8a5e84
TT		 67072019-07-17 Tom Tromey <tom@tromey.com>
6708
6709 * tui/tui-layout.c (make_source_window, make_disasm_window):
6710 Remove.
6711 (show_data): Unify creation and re-initialization cases.
6712
76d2be8e
TT		 67132019-07-17 Tom Tromey <tom@tromey.com>
6714
6715 * tui/tui-layout.c (make_command_window): Remove.
6716 (show_source_disasm_command, show_source_or_disasm_and_command):
6717 Unify creation and re-initialization cases.
6718
890b8bde
TT		 67192019-07-17 Tom Tromey <tom@tromey.com>
6720
6721 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6722 creation and re-initialization cases.
6723
2cdfa113
TT		 67242019-07-17 Tom Tromey <tom@tromey.com>
6725
6726 * tui/tui-regs.c (tui_get_register): Return void.
6727
8e3cfd09
TT		 67282019-07-17 Tom Tromey <tom@tromey.com>
6729
6730 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6731 Simplify.
6732
f4e04977
TT		 67332019-07-17 Tom Tromey <tom@tromey.com>
6734
6735 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6736 resetting.
6737
0379b883
TT		 67382019-07-17 Tom Tromey <tom@tromey.com>
6739
6740 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6741 * tui/tui-regs.c (tui_reg_layout): New function.
6742 (tui_show_registers, tui_reg_command): Use it.
6743 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6744 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6745 parameters.
6746 (tui_layout_command): Remove.
6747
b7fbad91
TT		 67482019-07-17 Tom Tromey <tom@tromey.com>
6749
6750 * tui/tui-layout.h (tui/tui-layout): Return void.
6751 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6752
4e1e56b9
TT		 67532019-07-17 Tom Tromey <tom@tromey.com>
6754
6755 * tui/tui-layout.c (show_source_disasm_command, show_data):
6756 Update.
6757 (reset_locator): Remove.
6758 (show_source_or_disasm_and_command): Update.
6759
1e0c09ba
TT		 67602019-07-17 Tom Tromey <tom@tromey.com>
6761
6762 * tui/tui-source.c (tui_source_window_base::reset): Remove
6763 win_type parameter.
6764 * tui/tui-layout.c (make_command_window, make_source_window)
6765 (make_disasm_window, make_data_window)
6766 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6767 (reset_locator, show_source_or_disasm_and_command): Update.
6768 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6769 win_type parameter.
6770 (struct tui_source_window_base) <reset>: Likewise.
6771
1bf605de
TT		 67722019-07-17 Tom Tromey <tom@tromey.com>
6773
6774 * tui/tui-layout.c (show_source_disasm_command): Use
6775 reset_locator.
6776 (reset_locator): New function.
6777 (init_and_make_win): Remove.
6778 (show_source_or_disasm_and_command): Use reset_locator.
6779
098f9ed4
TT		 67802019-07-17 Tom Tromey <tom@tromey.com>
6781
6782 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6783 condition.
6784 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6785 Remove condition.
6786 * tui/tui-source.c (tui_source_window_base::reset): New method.
6787 * tui/tui-layout.c (make_command_window): Don't call
6788 init_and_make_win.
6789 (make_source_window, make_disasm_window): Don't call
6790 make_source_or_disasm_window.
6791 (make_data_window): Don't call init_and_make_win. Change calling
6792 convention.
6793 (show_source_disasm_command, show_data): Simplify.
6794 (make_source_or_disasm_window): Remove.
6795 (show_source_or_disasm_and_command): Simplify.
6796 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6797 (struct tui_source_window_base) <reset>: Likewise.
6798 <execution_info>: Remove initializer.
6799 * tui/tui-data.c (tui_source_window_base): Initialize
6800 execution_info.
6801
80110957
TT		 68022019-07-17 Tom Tromey <tom@tromey.com>
6803
6804 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6805 variable.
6806
cf82af05
TT		 68072019-07-17 Tom Tromey <tom@tromey.com>
6808
6809 * tui/tui.c (tui_rl_other_window): Update.
6810 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6811 superclass method first. Always iterate over regs_content.
6812 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6813 method.
6814 * tui/tui-win.c (tui_set_focus_command): Update.
6815
01aeb396
TT		 68162019-07-17 Tom Tromey <tom@tromey.com>
6817
6818 * tui/tui-win.c (tui_set_focus_command): Rename from
6819 tui_set_focus. Call tui_enable.
6820 (tui_set_focus_command): Remove.
6821
fd6c75ee
TT		 68222019-07-17 Tom Tromey <tom@tromey.com>
6823
6824 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6825 refresh_window.
6826 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6827 touchwin.
6828 (tui_data_window::refresh_window): Call refresh_window on data
6829 items. Always call superclass refresh_window.
6830 (tui_win_info::refresh): Remove.
6831 (tui_source_window_base::refresh_window): Update.
6832 (tui_refresh_all): Update.
6833 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6834 refresh_window.
6835 (show_source_or_disasm_and_command): Likewise.
6836 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6837 (struct tui_source_window_base) <refresh>: Likewise.
6838
f6cc34a9
TT		 68392019-07-17 Tom Tromey <tom@tromey.com>
6840
6841 * tui/tui-winsource.c (tui_clear_source_content)
6842 (tui_show_source_content): Update.
6843 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6844 whether content is empty.
6845 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6846 Remove.
6847
f31ec9af
TT		 68482019-07-17 Tom Tromey <tom@tromey.com>
6849
6850 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6851 window's contents.
6852 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6853 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6854
d1b6f1e5
TT		 68552019-07-17 Tom Tromey <tom@tromey.com>
6856
6857 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6858 (struct tui_data_item_window): Update.
6859
d9743a13
TT		 68602019-07-17 Tom Tromey <tom@tromey.com>
6861
6862 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6863 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6864 defines.
6865
caf0bc4e
TT		 68662019-07-17 Tom Tromey <tom@tromey.com>
6867
6868 * tui/tui-winsource.h (tui_erase_source_content)
6869 (tui_clear_source_content): Remove "display_prompt" parameter.
6870 * tui/tui-winsource.c (tui_update_source_window_as_is)
6871 (tui_update_source_windows_with_addr): Update.
6872 (tui_clear_source_content): Remove "display_prompt" parameter.
6873 (tui_erase_source_content): Likewise. Simplify.
6874 (tui_show_source_content): Update.
6875 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6876 * tui/tui-stack.c (tui_show_frame_info): Update.
6877 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6878 Remove defines.
6879
9d391078
TT		 68802019-07-17 Tom Tromey <tom@tromey.com>
6881
6882 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6883 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6884 parameter.
6885 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6886 parameter.
6887
a38da35d
TT		 68882019-07-17 Tom Tromey <tom@tromey.com>
6889
6890 * tui/tui-winsource.c (tui_clear_source_content)
6891 (tui_show_source_content, tui_show_exec_info_content)
6892 (tui_clear_exec_info_content): Update.
6893 * tui/tui-stack.c (tui_show_locator_content): Update.
6894 (tui_show_frame_info): Update.
6895 * tui/tui-source.h (tui_source_window): Don't declare.
6896 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6897 from tui_source_is_displayed.
6898 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6899 Remove field.
6900 (struct tui_source_window_base) <content_in_use>: New field. Now
6901 bool.
6902 (struct tui_source_window) <showing_source_p>: New method.
6903 (TUI_SRC_WIN): Change cast.
6904 * tui/tui-data.c (tui_initialize_static_data): Update.
6905
c2cd8994
TT		 69062019-07-17 Tom Tromey <tom@tromey.com>
6907
6908 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6909 location_matches_p.
6910 * tui/tui-source.c (tui_source_window::location_matches_p): New
6911 method.
6912 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6913 method.
6914 * tui/tui-data.h (struct tui_source_window_base)
6915 <location_matches_p>: New method.
6916 (struct tui_source_window, struct tui_disasm_window)
6917 <location_matches_p>: Likewise.
6918
4dde7b34
TT		 69192019-07-17 Tom Tromey <tom@tromey.com>
6920
6921 * tui/tui-win.c (tui_set_win_height_command): Rename from
6922 tui_set_win_height.
6923 (tui_set_win_height_command): Remove.
6924
b73dd877
TT		 69252019-07-17 Tom Tromey <tom@tromey.com>
6926
6927 * tui/tui-source.c (tui_source_window): New constructor. Add
6928 observer.
6929 (~tui_source_window): New destructor.
6930 (tui_source_window::style_changed): New method.
6931 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6932 (tui_attach_detach_observers): Update.
6933 * tui/tui-data.h (struct tui_source_window): Make constructor not
6934 inline. Add destructor.
6935 (struct tui_source_window) <style_changed>: New method.
6936 <m_observable>: New member.
6937
ae2b5380
TT		 69382019-07-17 Tom Tromey <tom@tromey.com>
6939
6940 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6941 * tui/tui-win.c (tui_resize_all): Fix typo.
6942
1ce3e844
TT		 69432019-07-17 Tom Tromey <tom@tromey.com>
6944
6945 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6946 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6947 (tui_refresh_all): Remove "list" parameter. Use foreach.
6948 * tui/tui-win.c (window_name_completer): Use foreach.
6949 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6950 (update_tab_width): Likewise.
6951 * tui/tui-layout.c (show_layout): Update.
6952 * tui/tui-data.h (class tui_window_iterator): New.
6953 (struct all_tui_windows): New.
6954 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6955
fe3eaf1c
TT		 69562019-07-17 Tom Tromey <tom@tromey.com>
6957
6958 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6959 parameter. Don't reference globals.
6960 (tui_reg_command): Update.
6961
368c1354
TT		 69622019-07-17 Tom Tromey <tom@tromey.com>
6963
6964 * tui/tui-regs.c (tui_show_registers): Simplify.
6965
e80cd204
TT		 69662019-07-17 Tom Tromey <tom@tromey.com>
6967
6968 * tui/tui-regs.c (tui_show_registers): Update.
6969 (tui_show_register_group): Add win_info parameter.
6970
aca2dd16
TT		 69712019-07-17 Tom Tromey <tom@tromey.com>
6972
6973 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6974 Rename from tui_display_reg_element_at_line.
6975 (tui_data_window::display_registers_from_line): Update.
6976 * tui/tui-data.h (struct tui_data_window)
6977 <display_reg_element_at_line>: New method.
6978
517e9505
TT		 69792019-07-17 Tom Tromey <tom@tromey.com>
6980
6981 * tui/tui-regs.h (tui_display_registers_from)
6982 (tui_display_registers_from_line): Don't declare.
6983 * tui/tui-windata.c (tui_data_window::display_all_data)
6984 (tui_data_window::refresh_all)
6985 (tui_data_window::do_scroll_vertical): Update.
6986 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6987 from tui_display_registers_from.
6988 (tui_display_reg_element_at_line): Update.
6989 (tui_data_window::display_registers_from_line): Rename from
6990 tui_display_registers_from_line.
6991 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6992 display_registers_from_line>: New methods.
6993
f76d8b19
TT		 69942019-07-17 Tom Tromey <tom@tromey.com>
6995
6996 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6997 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6998 from tui_erase_data_content.
6999 (tui_data_window::display_all_data)
7000 (tui_data_window::refresh_all)
7001 (tui_data_window::do_scroll_vertical): Update.
7002 * tui/tui-regs.c (tui_show_registers): Update.
7003 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7004 New method.
7005
b4094625
TT		 70062019-07-17 Tom Tromey <tom@tromey.com>
7007
7008 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7009 declare.
7010 * tui/tui-windata.c
7011 (tui_data_window::delete_data_content_windows): Rename from
7012 tui_delete_data_content_windows.
7013 (tui_data_window::display_all_data)
7014 (tui_data_window::do_scroll_vertical): Update.
7015 * tui/tui-data.h (struct tui_data_window)
7016 <delete_data_content_windows>: New method.
7017
c223a729
TT		 70182019-07-17 Tom Tromey <tom@tromey.com>
7019
7020 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7021 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7022
50daf268
TT		 70232019-07-17 Tom Tromey <tom@tromey.com>
7024
7025 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7026 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7027 from tui_display_all_data.
7028 * tui/tui-win.c
7029 (tui_data_window::do_make_visible_with_new_height): Update.
7030 * tui/tui-regs.c (tui_show_registers): Update.
7031 * tui/tui-layout.c (tui_set_layout): Update.
7032 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7033 method.
7034
df5f8cab
TT		 70352019-07-17 Tom Tromey <tom@tromey.com>
7036
7037 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7038 * tui/tui-windata.c (tui_display_data_from): Remove.
7039 (tui_data_window::refresh_all): Update.
7040
80cb6c27
TT		 70412019-07-17 Tom Tromey <tom@tromey.com>
7042
7043 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7044 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7045 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7046 tui_display_registers_from_line.
7047 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7048 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7049 "force_display" parameter.
7050
baff0c28
TT		 70512019-07-17 Tom Tromey <tom@tromey.com>
7052
7053 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7054 declare.
7055 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7056 Rename from tui_first_reg_element_no_inline.
7057 (tui_display_reg_element_at_line)
7058 (tui_display_registers_from_line): Update.
7059 * tui/tui-data.h (struct tui_data_window)
7060 <first_reg_element_no_inline>: New method.
7061
3b23c5f2
TT		 70622019-07-17 Tom Tromey <tom@tromey.com>
7063
7064 * tui/tui-windata.c (tui_display_data_from)
7065 (tui_data_window::do_scroll_vertical): Update.
7066 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7067 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7068 Rename from tui_line_from_reg_element_no.
7069 (tui_display_registers_from_line): Update.
7070 * tui/tui-data.h (struct tui_data_window)
7071 <line_from_reg_element_no>: New method.
7072
0b5ec218
TT		 70732019-07-17 Tom Tromey <tom@tromey.com>
7074
7075 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7076 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7077 tui_last_regs_line_no.
7078 (tui_display_reg_element_at_line)
7079 (tui_display_registers_from_line): Update.
7080 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7081 method.
7082
0807ab7b
TT		 70832019-07-17 Tom Tromey <tom@tromey.com>
7084
7085 PR tui/24722:
7086 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7087 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7088 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7089 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7090 (tui_update_breakpoint_info): Likewise.
7091 * tui/tui-hooks.c (tui_event_create_breakpoint)
7092 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7093 Update.
7094
9ad7fdef
TT		 70952019-07-17 Tom Tromey <tom@tromey.com>
7096
7097 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7098
5813316f
TT		 70992019-07-17 Tom Tromey <tom@tromey.com>
7100
7101 * tui/tui-winsource.c (tui_update_source_window_as_is)
7102 (tui_update_source_windows_with_addr): Update.
7103 * tui/tui-source.h (tui_set_source_content)
7104 (tui_show_symtab_source): Add "win_info" parameter.
7105 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7106 parameter.
7107 (tui_show_symtab_source): Likewise.
7108
00e264e7
TT		 71092019-07-17 Tom Tromey <tom@tromey.com>
7110
7111 * tui/tui-wingeneral.c
7112 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7113
06210ce4
TT		 71142019-07-17 Tom Tromey <tom@tromey.com>
7115
7116 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7117 (struct tui_cmd_window) <can_scroll>: New method.
7118 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7119 method.
7120
381befee
TT		 71212019-07-17 Tom Tromey <tromey@adacore.com>
7122
7123 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7124 do_field_signed>: Rename. Change type of "value".
7125 * ui-out.c (ui_out::field_signed): Rename from field_int.
7126 Change type of "value".
7127 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7128 type of "value".
7129 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7130 do_field_int. Change type of "value".
7131 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7132 do_field_int. Change type of "value".
7133 * tracepoint.c (trace_status_mi, tfind_1)
7134 (print_one_static_tracepoint_marker): Update.
7135 * thread.c (print_thread_info_1, print_selected_thread_frame):
7136 Update.
7137 * stack.c (print_frame, print_frame_info): Update.
7138 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7139 Update.
7140 * source.c (print_source_lines_base): Update.
7141 * skip.c (info_skip_command): Update.
7142 * record-btrace.c (btrace_ui_out_decode_error)
7143 (btrace_call_history_src_line): Update.
7144 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7145 Update.
7146 * progspace.c (print_program_space): Update.
7147 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7148 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7149 do_field_int. Change type of "value".
7150 * mi/mi-out.c (mi_ui_out::do_table_begin)
7151 (mi_ui_out::do_table_header): Update.
7152 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7153 type of "value".
7154 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7155 (mi_cmd_data_list_changed_registers, output_register)
7156 (mi_cmd_data_read_memory, mi_load_progress)
7157 (mi_cmd_trace_frame_collected): Update.
7158 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7159 Update.
7160 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7161 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7162 (mi_cmd_var_list_children, varobj_update_one): Update.
7163 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7164 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7165 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7166 * inferior.c (print_inferior): Update.
7167 * gdb_bfd.c (print_one_bfd): Update.
7168 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7169 Update.
7170 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7171 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7172 do_field_int. Change type of "value".
7173 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7174 do_field_int. Change type of "value".
7175 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7176 (print_one_breakpoint_location, print_it_catch_fork)
7177 (print_one_catch_fork, print_it_catch_vfork)
7178 (print_one_catch_vfork, print_it_catch_solib)
7179 (print_it_catch_exec, print_it_ranged_breakpoint)
7180 (print_mention_watchpoint, print_mention_masked_watchpoint)
7181 (bkpt_print_it, update_static_tracepoint): Update.
7182 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7183 * break-catch-syscall.c (print_it_catch_syscall): Update.
7184 * ada-tasks.c (print_ada_task_info): Update.
7185 * ada-lang.c (print_it_exception, print_mention_exception):
7186 Update.
7187
6b78c3f8
AB		 71882019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7189
7190 PR breakpoints/24541
7191 * gdbarch.c: Regenerate.
7192 * gdbarch.h: Regenerate.
7193 * gdbarch.sh: Adjust return type and parameter types for
7194 'stap_adjust_register'.
7195 (i386_stap_adjust_register): Adjust signature and return new
7196 register name.
7197 * stap-probe.c (stap_parse_register_operand): Adjust use of
7198 'gdbarch_stap_adjust_register'.
7199
d72a9b85
TT		 72002019-07-17 Tom Tromey <tromey@adacore.com>
7201
7202 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7203 declare VEC.
7204 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7205 std::vector.
7206 (struct s390_process_info): Add initializers.
7207 (s390_add_process): Use new.
7208 (s390_linux_nat_target::low_forget_process): Use delete.
7209 (s390_linux_nat_target::low_new_fork)
7210 (s390_linux_nat_target::stopped_by_watchpoint)
7211 (s390_linux_nat_target::low_prepare_to_resume)
7212 (s390_linux_nat_target::insert_watchpoint)
7213 (s390_linux_nat_target::insert_hw_breakpoint)
7214 (s390_linux_nat_target::remove_watchpoint)
7215 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7216
206e6c58
JB		 72172019-07-16 John Baldwin <jhb@FreeBSD.org>
7218
7219 * aarch64-fbsd-nat.c: Include regcache.h.
7220 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7221 argument.
7222 (aarch64_fbsd_nat_target::fetch_registers)
7223 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7224 variable.
7225 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7226
cbde90f2
JB		 72272019-07-16 John Baldwin <jhb@FreeBSD.org>
7228
7229 * fbsd-nat.c: Include gdbarch.h.
7230
07128006
TT		 72312019-07-15 Tom Tromey <tromey@adacore.com>
7232
7233 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7234
1f77b012
TT		 72352019-07-15 Tom Tromey <tromey@adacore.com>
7236
7237 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7238 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7239 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7240 * cli-out.c (cli_ui_out::do_field_int): New method.
7241 * ui-out.c (ui_out::field_unsigned): New method.
7242 * symfile.c (generic_load): Use field_unsigned.
7243 (print_transfer_performance): Likewise.
7244 * record-btrace.c (ui_out_field_uint): Remove.
7245 (btrace_call_history_insn_range, btrace_call_history): Use
7246 field_unsigned.
7247 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7248 field_unsigned.
7249 * ui-out.h (class ui_out) <field_unsigned>: New method.
7250 <do_field_unsigned>: Likewise.
7251
33eca680
TT		 72522019-07-15 Tom Tromey <tromey@adacore.com>
7253
7254 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7255 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7256 * target.c (flash_erase_command): Use field_string.
7257 * infrun.c (print_signal_received_reason): Use field_string.
7258 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7259 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7260 field_string.
7261 * ada-tasks.c (print_ada_task_info): Use field_string.
7262
ca8d69be
TT		 72632019-07-15 Tom Tromey <tromey@adacore.com>
7264
7265 * target.c (flash_erase_command): Use field_core_addr.
7266 * symfile.c (generic_load): Use field_core_addr.
7267 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7268 Use field_core_addr.
7269 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7270 field_core_addr.
7271
0d4e84ed
AB		 72722019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7273
7274 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7275 value if its desired type is smaller than a CORE_ADDR and signed.
7276
9a49df9d
AB		 72772019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7278
7279 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7280 of changes to field names, and use new is_reference field to
7281 decide if a property is a reference or not.
7282 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7283 field.
7284 (struct dwarf2_property_baton): Update header comment, rename
7285 'referenced_type' to 'property_type' and update comments.
7286 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7287 default property type, store in property baton, update to take
7288 accound of renamed field.
7289 (read_func_scope): Update call to attr_to_dynamic_prop.
7290 (read_array_type): Likewise.
7291 (dwarf2_per_cu_addr_sized_int_type): New function.
7292 (read_subrange_index_type): Move type finding code to
7293 dwarf2_per_cu_addr_sized_int_type.
7294 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7295 (dwarf2_per_cu_addr_type): New function.
7296 (set_die_type): Update calls to attr_to_dynamic_prop.
7297
b86352cf
AB		 72982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7299
7300 * dwarf2read.c (read_subrange_index_type): New function.
7301 (read_subrange_type): Move code into new function and call it.
7302 * gdbtypes.c (create_range_type): Add some asserts.
7303
603490bf
AB		 73042019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7305
7306 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7307 update return statements.
7308 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7309 declaration, and update comment to match.
7310 * gdbtypes.c (resolve_dynamic_array): Update call to
7311 dwarf2_evaluate_property to match new return type.
7312
592f9d27
AB		 73132019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7314
7315 * valarith.c (value_subscripted_rvalue): Change lowerbound
7316 parameter type from int to LONGEST.
7317 * value.h (value_subscripted_rvalue): Likewise in declaration.
7318
60cfcb20
AB		 73192019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7320
7321 * cli/cli-utils.c (info_print_command_completer): New function.
7322 * cli/cli-utils.h: Add 'completer.h' include, and forward
7323 declaration for 'struct cmd_list_element'.
7324 (info_print_command_completer): Declare.
7325 * stack.c (_initialize_stack): Add completer for 'info locals' and
7326 'info args'.
7327 * symtab.c (_initialize_symtab): Add completer for 'info
7328 variables' and 'info functions'.
7329 * NEWS: Mention completion for additional info commands.
7330
b16507e0
AB		 73312019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7332
7333 * cli/cli-utils.c (extract_info_print_args): Delete.
7334 (extract_arg_maybe_quoted): Delete.
7335 (info_print_options_defs): New variable.
7336 (make_info_print_options_def_group): New function.
7337 (extract_info_print_options): Define new function.
7338 * cli/cli-utils.h (extract_info_print_args): Delete.
7339 (struct info_print_options): New structure.
7340 (extract_info_print_options): Declare new function.
7341 * stack.c (info_locals_command): Update to use new
7342 extract_info_print_options, also add a header comment.
7343 (info_args_command): Likewise.
7344 * symtab.c (info_variables_command): Likewise.
7345 (info_functions_command): Likewise.
7346
021d8588
AB		 73472019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7348
7349 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7350 to extract string arguments.
7351 * common/common-utils.c (extract_string_maybe_quoted): New function.
7352 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7353
b777eb6d
TT		 73542019-07-11 Tom Tromey <tromey@adacore.com>
7355
7356 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7357 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7358 * top.h (gdbinit): Don't declare.
7359 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7360 into...
7361 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7362 * top.c (gdb_init): Don't call init_cli_cmds.
7363 (gdbinit): Remove.
7364 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7365
72ee03ff
TT		 73662019-07-11 Tom Tromey <tromey@adacore.com>
7367
7368 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7369 after it has been moved.
7370
00db9531
SM		 73712019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7372
7373 * valops.c (value_must_coerce_to_target): Change return type to
7374 bool.
7375 * value.h (value_must_coerce_to_target): Likewise.
7376
f2478a7e
SM		 73772019-07-10 Simon Marchi <simon.marchi@efficios.com>
7378
7379 * breakpoint.c (is_hardware_watchpoint): Remove
7380 forward-declaration.
7381 (is_masked_watchpoint): Change return type to bool.
7382 (is_tracepoint): Likewise.
7383 (is_breakpoint): Likewise.
7384 (is_hardware_watchpoint): Likewise.
7385 (is_watchpoint): Likewise.
7386 (is_no_memory_software_watchpoint): Likewise.
7387 (is_catchpoint): Likewise.
7388 (breakpoint_1): Make FILTER parameter's return type bool.
7389 is_masked_watchpoint): Change return type to bool.
7390 (save_breakpoints): Make FILTER parameter's return type bool.
7391 * breakpoint.h (is_breakpoint): Change return type to bool.
7392 (is_watchpoint): Likewise.
7393 (is_catchpoint): Likewise.
7394 (is_tracepoint): Likewise.
7395
0d12e84c
TT		 73962019-07-10 Tom Tromey <tom@tromey.com>
7397
7398 * defs.h: Don't include gdbarch.h.
7399 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7400 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7401 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7402 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7403 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7404 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7405 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7406 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7407 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7408 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7409 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7410 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7411 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7412 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7413 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7414 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7415 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7416 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7417 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7418 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7419 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7420 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7421 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7422 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7423 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7424 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7425 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7426
f06f1252
TT		 74272019-07-10 Tom Tromey <tromey@adacore.com>
7428
7429 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7430 * breakpoint.c (init_ada_exception_breakpoint): Register as
7431 bp_catchpoint.
7432 (print_one_breakpoint_location, print_one_breakpoint): Use
7433 is_ada_exception_catchpoint.
7434 * ada-lang.c (class ada_catchpoint_location): Pass
7435 bp_loc_software_breakpoint to bp_location constructor.
7436 (is_ada_exception_catchpoint): New function.
7437
7a5d944b
TT		 74382019-07-10 Tom Tromey <tromey@adacore.com>
7439
7440 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7441 VEC.
7442 (struct arm_exidx_entry): New method operator<.
7443 (struct arm_exidx_data) <section_maps>: Change type.
7444 (arm_exidx_data_free): Remove.
7445 (arm_exidx_data_key): Change type. Move lower.
7446 (arm_exidx_new_objfile): Update.
7447 (arm_compare_exidx_entries): Remove.
7448 (arm_find_exidx_entry, _initialize_arm_tdep)
7449
48c66e1d
TT		 74502019-07-10 Tom Tromey <tromey@adacore.com>
7451
7452 * solib-spu.c (ocl_program_data_key): Change type.
7453 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7454 Update.
7455
a269fbf1
TT		 74562019-07-10 Tom Tromey <tromey@adacore.com>
7457
7458 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7459 (struct solib_aix_inferior_data) <library_list>: Change type.
7460 (solib_aix_inferior_data_handle): Change type.
7461 (get_solib_aix_inferior_data): Update.
7462 (solib_aix_free_library_list): Remove.
7463 (library_list_start_library): Update.
7464 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7465 return type.
7466 (solib_aix_get_library_list)
7467 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7468 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7469
c294730c
TT		 74702019-07-10 Tom Tromey <tromey@adacore.com>
7471
7472 * solib-dsbt.c (struct dsbt_info): Add initializers.
7473 (solib_dsbt_pspace_data): Change type.
7474 (dsbt_pspace_data_cleanup): Remove.
7475 (get_dsbt_info, _initialize_dsbt_solib): Update.
7476
9d52077d
TT		 74772019-07-10 Tom Tromey <tromey@adacore.com>
7478
7479 * spu-tdep.c (spu_overlay_data): Change type.
7480 (spu_get_overlay_table, spu_overlay_new_objfile)
7481 (_initialize_spu_tdep): Update.
7482
22a20dca
TT		 74832019-07-10 Tom Tromey <tromey@adacore.com>
7484
7485 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7486 destructor.
7487 (dbx_objfile_data_key): Change type and declare later.
7488 (DBX_SYMFILE_INFO): Rewrite.
7489 * dbxread.c (dbx_objfile_data_key): Change type.
7490 (dbx_symfile_init): Update.
7491 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7492 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7493 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7494
cb60f420
TT		 74952019-07-10 Tom Tromey <tromey@adacore.com>
7496
7497 * jit.c (jit_program_space_key): Change type. Move lower.
7498 (get_jit_program_space_data): Update.
7499 (jit_program_space_data_cleanup): Remove.
7500 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7501 Update.
7502 (struct jit_program_space_data): Add initializers.
7503
51df2ae3
TT		 75042019-07-10 Tom Tromey <tromey@adacore.com>
7505
7506 * solib-darwin.c (struct darwin_info): Add initializers.
7507 (solib_darwin_pspace_data): Change type.
7508 (darwin_pspace_data_cleanup): Remove.
7509 (get_darwin_info, _initialize_darwin_solib): Update.
7510
18101a35
TT		 75112019-07-10 Tom Tromey <tromey@adacore.com>
7512
7513 * remote-sim.c (struct sim_inferior_data): Add initializers,
7514 constructor, and destructor.
7515 (sim_inferior_data_key): Change type. Move lower.
7516 (check_for_duplicate_sim_descriptor): Update.
7517 (get_sim_inferior_data): Use new. Update.
7518 (~sim_inferior_data_cleanup): Rename from
7519 sim_inferior_data_cleanup. Simplify.
7520 (gdbsim_close_inferior, simulator_command)
7521 (sim_command_completer, _initialize_remote_sim): Update.
7522 (next_pid, INITIAL_PID): Move earlier.
7523
05b08ac1
TT		 75242019-07-10 Tom Tromey <tromey@adacore.com>
7525
7526 * python/python-internal.h (create_thread_object): Return
7527 gdbpy_ref.
7528 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7529 * python/py-inferior.c (struct threadlist_entry): Add
7530 constructor.
7531 <thread_obj>: Now a gdbpy_ref.
7532 (thread_to_thread_object): Update.
7533 (add_thread_object): Use new.
7534 (delete_thread_object): Use delete.
7535 (infpy_threads): Update.
7536 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7537 GIL.
7538
32372d80
TT		 75392019-07-10 Tom Tromey <tromey@adacore.com>
7540
7541 * valops.c (value_cast): Specialize error message for Ada.
7542
5c458ae8
SM		 75432019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7544
7545 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7546
4c462cb0
SM		 75472019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7548
7549 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7550 bpstat_should_step): Return bool, adjust comments.
7551 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7552 bpstat_should_step): Likewise.
7553
89abbcc2
AH		 75542019-07-10 Alan Hayward <alan.hayward@arm.com>
7555
7556 * features/Makefile: Use feature target descriptions for Arm.
7557 * features/arm/arm-core.c: Generate new file.
7558 * features/arm/arm-fpa.c: Likewise.
7559 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7560 * features/arm/arm-m-profile.c: Likewise.
7561 * features/arm/arm-vfpv2.c: Likewise.
7562 * features/arm/arm-vfpv3.c: Likewise.
7563 * features/arm/xscale-iwmmxt.c: Likewise.
7564 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7565
166a82be
AH		 75662019-07-10 Alan Hayward <alan.hayward@arm.com>
7567
7568 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7569 ptrace earlier.
7570
9fb4c7e9
AH		 75712019-07-10 Alan Hayward <alan.hayward@arm.com>
7572
7573 * features/aarch64-pauth.c: Regenerate.
7574
e2d0f980
SM		 75752019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7576
7577 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7578 bool.
7579 (bpstat_what): Use false instead of 0.
7580
a38118e5
PA		 75812019-07-09 Pedro Alves <palves@redhat.com>
7582
7583 * break-catch-throw.c (is_exception_catchpoint): New.
7584 * breakpoint.c (print_one_breakpoint_location): New parameter
7585 'raw_loc'. Handle it. Use
7586 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7587 looking at the breakpoint's type.
7588 (print_one_breakpoint): If handling "maint info breakpoints", also
7589 print locations of exception catchpoints.
7590 * breakpoint.h (is_exception_catchpoint): Declare.
7591
cb1e4e32
PA		 75922019-07-09 Pedro Alves <palves@redhat.com>
7593
7594 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7595 "addr" field.
7596 (allocate_location_exception_catchpoint): New.
7597 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7598 (initialize_throw_catchpoint_ops): Install
7599 allocate_location_exception_catchpoint as allocate_location
7600 method.
7601 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7602 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7603 bp_loc_other.
7604 (breakpoint_address_is_meaningful): Delete.
7605 (bl_address_is_meaningful): New.
7606 (breakpoint_locations_match): Adjust comment.
7607 (bp_location_from_bp_type): New, factored out of...
7608 (bp_location::bp_location(breakpoint *)): ... this.
7609 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7610 factored out of...
7611 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7612 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7613 breakpoint_address_is_meaningful.
7614 (bp_locations_compare): Adjust comment.
7615 (update_global_location_list): Use bl_address_is_meaningful
7616 instead of breakpoint_address_is_meaningful.
7617 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7618 explicit.
7619 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7620 * python/py-breakpoint.c (bppy_get_location): No longer check
7621 whether location is null.
7622
b58a68fe
PA		 76232019-07-09 Pedro Alves <palves@redhat.com>
7624
7625 PR c++/15468
7626 * breakpoint.c (print_one_breakpoint_location): Remove
7627 single-location assert.
7628
268a13a5
TT		 76292019-07-09 Tom Tromey <tom@tromey.com>
7630
7631 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7632 * configure: Rebuild.
7633 * configure.ac: Change common to gdbsupport.
7634 * gdbsupport: Rename from common.
7635 * acinclude.m4: Change common to gdbsupport.
7636 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7637 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7638 gdbsupport.
7639 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7640 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7641 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7642 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7643 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7644 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7645 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7646 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7647 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7648 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7649 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7650 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7651 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7652 coff-pe-read.c, command.h, compile/compile-c-support.c,
7653 compile/compile-c.h, compile/compile-cplus-symbols.c,
7654 compile/compile-cplus-types.c, compile/compile-cplus.h,
7655 compile/compile-loc2c.c, compile/compile.c, completer.c,
7656 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7657 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7658 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7659 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7660 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7661 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7662 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7663 features/aarch64-core.c, features/aarch64-fpu.c,
7664 features/aarch64-pauth.c, features/aarch64-sve.c,
7665 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7666 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7667 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7668 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7669 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7670 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7671 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7672 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7673 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7674 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7675 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7676 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7677 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7678 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7679 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7680 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7681 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7682 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7683 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7684 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7685 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7686 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7687 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7688 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7689 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7690 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7691 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7692 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7693 minsyms.c, mips-linux-tdep.c, namespace.h,
7694 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7695 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7696 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7697 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7698 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7699 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7700 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7701 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7702 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7703 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7704 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7705 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7706 procfs.c, producer.c, progspace.h, psymtab.h,
7707 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7708 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7709 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7710 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7711 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7712 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7713 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7714 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7715 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7716 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7717 target-memory.c, target.c, target.h, target/waitstatus.c,
7718 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7719 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7720 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7721 unittests/array-view-selftests.c,
7722 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7723 unittests/common-utils-selftests.c,
7724 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7725 unittests/format_pieces-selftests.c,
7726 unittests/function-view-selftests.c,
7727 unittests/lookup_name_info-selftests.c,
7728 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7729 unittests/mkdir-recursive-selftests.c,
7730 unittests/observable-selftests.c,
7731 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7732 unittests/parse-connection-spec-selftests.c,
7733 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7734 unittests/scoped_fd-selftests.c,
7735 unittests/scoped_mmap-selftests.c,
7736 unittests/scoped_restore-selftests.c,
7737 unittests/string_view-selftests.c, unittests/style-selftests.c,
7738 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7739 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7740 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7741 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7742 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7743 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7744
5b0e2db4
AB		 77452019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7746
7747 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7748 bool value.
7749 (decode_digits_ordinary): Set explicit_line field in sal.
7750 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7751 symtab_and_line that was set on an explicit line number in
7752 assembler code. Do always update the recorded symtab and line if
7753 we do skip the prologue.
7754
0ba852ab
AB		 77552019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7756
7757 * breakpoint.c (set_breakpoint_location_function): Remove
7758 explicit_loc parameter.
7759 (momentary_breakpoint_from_master): Update call to
7760 set_breakpoint_location_function.
7761 (add_location_to_breakpoint): Likewise.
7762
b3a7d171
AB		 77632019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7764
7765 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7766 required features based on default bfd type when no specific bfd
7767 is present.
7768
1f6f6e21
PW		 77692019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7770
7771 * NEWS: Mention that GDB printf and eval commands can now print
7772 C-style and Ada-style convenience var strings without
7773 calling the inferior.
7774 * printcmd.c (printf_c_string): Locally print GDB internal var
7775 instead of transiting via the inferior.
7776 (printf_wide_c_string): Likewise.
7777
77782019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7779
5862c886 7780 PR breakpoints/25011
ea142fbf
AH		 7781 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7782
0598af48
TT		 77832019-07-04 Tom Tromey <tom@tromey.com>
7784
7785 PR tui/24724:
7786 * tui/tui-winsource.c (tui_clear_source_content): Update.
7787 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7788 (tui_update_breakpoint_info): Update.
7789 (tui_set_exec_info_content): Update.
7790 * tui/tui-source.c (tui_set_source_content_nil): Update.
7791 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7792 has_break.
7793 * tui/tui-data.h (enum tui_bp_flag): New.
7794 (tui_bp_flags): New enum flags type.
7795 (struct tui_source_element) <break_mode>: Change type. Rename
7796 from has_break.
7797 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7798 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7799 constants.
7800 * tui/tui-winsource.h: Fix comment.
7801
350fab54
AH		 78022019-07-04 Alan Hayward <alan.hayward@arm.com>
7803
7804 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7805 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7806 (store_fpregs_to_thread)
7807 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7808 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7809 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7810 (IWMMXT_REGS_SIZE): Add define.
7811 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7812 (fetch_vfp_regs, store_vfp_regs)
7813 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7814 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7815
f0452268
AH		 78162019-07-04 Alan Hayward <alan.hayward@arm.com>
7817
7818 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7819 defines.
7820 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7821 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7822 (ARM_INT_REGISTER_SIZE): ...to this.
7823 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7824 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7825 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7826 (arm_linux_collect_gregset, supply_nwfpe_register)
7827 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7828 defines.
7829 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7830 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7831 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7832 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7833 (arm_return_in_memory, arm_store_return_value)
7834 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7835 (arm_record_ld_st_multiple): Likewise.
7836 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7837 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7838
e935475c
AH		 78392019-07-04 Alan Hayward <alan.hayward@arm.com>
7840
7841 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7842 AARCH64_DISPLACED_MODIFIED_INSNS.
7843 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7844 (aarch64_displaced_step_copy_insn): Likewise.
7845 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7846 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7847 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7848 ARM_DISPLACED_MODIFIED_INSNS.
7849 * arm-tdep.c (arm_gdbarch_init): Likewise.
7850 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7851 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7852 (struct arm_displaced_step_closure): Use
7853 ARM_DISPLACED_MODIFIED_INSNS.
7854
df0bb381
AH		 78552019-07-04 Alan Hayward <alan.hayward@arm.com>
7856
7857 * features/Makefile: Remove unused xml files.
7858 * features/aarch64.xml: Remove.
7859 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7860 * features/i386/amd64-avx-avx512.xml: Remove.
7861 * features/i386/amd64-avx-linux.xml: Remove.
7862 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7863 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7864 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7865 * features/i386/amd64-avx-mpx.xml: Remove.
7866 * features/i386/amd64-avx.xml: Remove.
7867 * features/i386/amd64-linux.xml: Remove.
7868 * features/i386/amd64-mpx-linux.xml: Remove.
7869 * features/i386/amd64-mpx.xml: Remove.
7870 * features/i386/amd64.xml: Remove.
7871 * features/i386/i386-avx-avx512-linux.xml: Remove.
7872 * features/i386/i386-avx-avx512.xml: Remove.
7873 * features/i386/i386-avx-linux.xml: Remove.
7874 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7875 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7876 * features/i386/i386-avx-mpx-linux.xml: Remove.
7877 * features/i386/i386-avx-mpx.xml: Remove.
7878 * features/i386/i386-avx.xml: Remove.
7879 * features/i386/i386-linux.xml: Remove.
7880 * features/i386/i386-mmx-linux.xml: Remove.
7881 * features/i386/i386-mmx.xml: Remove.
7882 * features/i386/i386-mpx-linux.xml: Remove.
7883 * features/i386/i386-mpx.xml: Remove.
7884 * features/i386/i386.xml: Remove.
7885 * features/i386/x32-avx-avx512-linux.xml: Remove.
7886 * features/i386/x32-avx-linux.xml: Remove.
7887 * features/i386/x32-linux.xml: Remove.
7888
edd6266a
AH		 78892019-07-04 Alan Hayward <alan.hayward@arm.com>
7890
7891 * regformats/aarch64.dat: Remove.
7892 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7893 * regformats/i386/amd64-avx-linux.dat: Remove.
7894 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7895 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7896 * regformats/i386/amd64-linux.dat: Remove.
7897 * regformats/i386/amd64-mpx-linux.dat: Remove.
7898 * regformats/i386/amd64.dat: Remove.
7899 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7900 * regformats/i386/i386-avx-linux.dat: Remove.
7901 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7902 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7903 * regformats/i386/i386-linux.dat: Remove.
7904 * regformats/i386/i386-mmx-linux.dat: Remove.
7905 * regformats/i386/i386-mpx-linux.dat: Remove.
7906 * regformats/i386/i386.dat: Remove.
7907 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7908 * regformats/i386/x32-avx-linux.dat: Remove.
7909 * regformats/i386/x32-linux.dat: Remove.
7910
2b40fda7
AH		 79112019-07-04 Alan Hayward <alan.hayward@arm.com>
7912
7913 * aarch64-tdep.c: Remove xml self tests.
7914 * amd64-linux-tdep.c: Likewise.
7915 * amd64-tdep.c: Likewise.
7916 * i386-linux-tdep.c: Likewise.
7917 * i386-tdep.c: Likewise.
7918
5f4ba3e7
PA		 79192019-07-03 Pedro Alves <palves@redhat.com>
7920
7921 PR cli/24732
7922 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7923 (pipe_cmd_option_defs): New.
7924 (make_pipe_cmd_options_def_group): New.
7925 (pipe_command): Use gdb::option::process_options.
7926 (pipe_command_completer): New function.
7927 (_initialize_cli_cmds): Install completer for "pipe" command.
7928
3d9be6f5
PA		 79292019-07-03 Pedro Alves <palves@redhat.com>
7930
7931 * cli/cli-option.c (union option_value) <string>: New field.
7932 (struct option_def_and_value): Add ctor, move ctor, dtor and
7933 use DISABLE_COPY_AND_ASSIGN.
7934 (option_def_and_value::clear_value): New.
7935 (parse_option, save_option_value_in_ctx, get_val_type_str)
7936 (add_setshow_cmds_for_options): Handle var_string.
7937 * cli-option.h (union option_def::var_address) <string>: New
7938 field.
7939 (struct string_option_def): New.
7940 * maint-test-options.c (struct test_options_opts): Add default
7941 ctor and use DISABLE_COPY_AND_ASSIGN.
7942 <string_opt>: New field.
7943 (test_options_opts::~test_options_opts): New.
7944 (test_options_opts::dump): Also dump "-string".
7945 (test_options_option_defs): Install "string.
7946
41fc454c
PA		 79472019-07-03 Pedro Alves <palves@redhat.com>
7948
7949 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7950 option_value with a null enumeration.
7951 (complete_options): Save the option values in the context.
7952 (save_option_value_in_ctx): New, factored out from ...
7953 (process_options): ... here.
7954 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7955 of the function.
7956 * maint-test-options.c (test_options_opts::dump): New, factored
7957 out from ...
7958 (maintenance_test_options_command_mode): ... here.
7959 (maintenance_test_options_command_completion_result): Delete.
7960 (maintenance_test_options_command_completion_text): Update
7961 comment.
7962 (maintenance_show_test_options_completion_result): Change
7963 prototype. Just print
7964 maintenance_test_options_command_completion_text.
7965 (save_completion_result): New.
7966 (maintenance_test_options_completer_mode): Pass options context to
7967 complete_options, and then save a dump.
7968 (_initialize_maint_test_options): Use add_cmd to install "maint
7969 show test-options-completion-result".
7970
fdbc9870
PA		 79712019-07-03 Pedro Alves <palves@redhat.com>
7972
7973 * NEWS (New commands): Mention "with" and "maint with".
7974 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7975 (with_command, with_command_completer): New.
7976 (pipe_command): Adjust to new repeat_previous
7977 interface.
7978 (_initialize_cli_cmds): Install the "with" command and its "w"
7979 alias.
7980 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7981 declarations.
7982 * cli/cli-setshow.c (parse_cli_var_uinteger)
7983 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7984 argument strings for all var_types.
7985 (get_setshow_command_value_string): New, factored out from ...
7986 (do_show_command): ... this.
7987 * cli/cli-setshow.h: Include <string>.
7988 (get_setshow_command_value_string): Declare.
7989 * command.h (repeat_previous): Now returns const char *. Adjust
7990 comment.
7991 * maint.c: Include "cli/cli-cmds.h".
7992 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7993 (_initialize_maint_cmds): Register the "maintenance with" command.
7994 * top.c (repeat_previous): Move bits from pipe_command here:
7995 Return the saved command line, if any; error out if there's no
7996 command to relaunch.
7997
c6ac8931
PA		 79982019-07-03 Pedro Alves <palves@redhat.com>
7999
8000 * NEWS (New commands): Mention "maint set/show test-settings"
8001 instead of "maint test-settings".
8002 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8003 (maintenance_test_settings_set_list): Rename to ...
8004 (maintenance_set_test_settings_list): ... this.
8005 (maintenance_test_settings_show_list): Rename to ...
8006 (maintenance_show_test_settings_list): ... this.
8007 (maintenance_test_settings_cmd): Delete.
8008 (maintenance_test_settings_set_cmd): ...
8009 (maintenance_set_test_settings_cmd): ... this.
8010 (maintenance_test_settings_show_cmd): ...
8011 (maintenance_show_test_settings_cmd): ... this.
8012 (maintenance_test_settings_show_value_cmd):
8013 (maintenance_show_test_settings_value_cmd): ... this.
8014 (_initialize_maint_test_settings): No longer install the "maint
8015 test-settings" prefix command. Rename "maint test-settings set"
8016 to "maint set test-settings", and "maint test-settings show" to
8017 "maint show test-settings". Adjust all subcommands.
8018
d1fcf2fd
PA		 80192019-07-03 Pedro Alves <palves@redhat.com>
8020
8021 * maint-test-settings.c: Fix file's intro comment. Replace all
8022 references to "test-options" with references to "test-settings",
8023 in comments.
8024
970f9d09
PA		 80252019-07-03 Pedro Alves <palves@redhat.com>
8026
8027 * maint-test-settings.c (maintenance_test_settings_xxx)
8028 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8029 New.
8030 (maintenance_test_settings_enums): Use them.
8031 (maintenance_test_settings_enum): Default to
8032 maintenance_test_settings_xxx.
8033 (_initialize_maint_test_settings): Initialize
8034 MAINTENANCE_TEST_SETTINGS_FILENAME.
8035
f3869b1a
SM		 80362019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8037
8038 * breakpoint.h (remove_breakpoints_inf): Change return type to
8039 void, move function documentation here.
8040 * breakpoint.c (remove_breakpoints_inf): Change return type to
8041 void, move function documentation to header.
8042
54d66006
PA		 80432019-07-02 Pedro Alves <palves@redhat.com>
8044
8045 * NEWS (Completion improvements): Mention "info threads".
8046 * thread.c (struct info_threads_opts, info_threads_option_defs)
8047 (make_info_threads_options_def_group): New.
8048 (info_threads_command): Use gdb::option::process_options.
8049 (info_threads_command_completer): New.
8050 (_initialize_thread): Use gdb::option::build_help to build the
8051 help text for "info threads".
8052
854f6088
SM		 80532019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8054
8055 * defs.h (generic_load): Move from here...
8056 * symfile.h (generic_load): ... to here. Rename name parameter
8057 to args.
8058 * symfile.c (generic_load): Add comment.
8059
54ee4252
TT		 80602019-07-01 Tom Tromey <tromey@adacore.com>
8061
8062 * dwarf2read.c
8063 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8064 declaration of without_params. Fix formatting.
8065
65392b3e
TT		 80662019-07-01 Tom Tromey <tromey@adacore.com>
8067
8068 * ada-exp.y (find_primitive_type): Update.
8069 * ada-lang.h (ada_lookup_symbol): Update.
8070 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8071 parameter.
8072 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8073
7d7571f0
SDJ		 80742019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8075
8076 PR breakpoints/24541
8077 * gdbarch.c: Regenerate.
8078 * gdbarch.h: Regenerate.
8079 * gdbarch.sh: Add 'stap_adjust_register'.
8080 * i386-tdep.c: Include '<unordered_set>'.
8081 (i386_stap_adjust_register): New function.
8082 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8083 * stap-probe.c (stap_parse_register_operand): Call
8084 'gdbarch_stap_adjust_register'.
8085
5af5392a
SDJ		 80862019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8087
8088 PR python/24742
8089 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8090 * python/python.c (do_start_initialization): Use 'xmalloc'
8091 instead of 'PyMem_Malloc'.
8092
10d06d82
TT		 80932019-06-28 Tom Tromey <tromey@adacore.com>
8094
8095 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8096 for Ada.
8097
1b7f24cd
TT		 80982019-06-27 Tom Tromey <tromey@adacore.com>
8099
8100 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8101 objfile_key.
8102 (arm_find_mapping_symbol, arm_record_special_symbol)
8103 (_initialize_arm_tdep): Update.
8104 (arm_objfile_data_free): Remove.
8105
3d507ff2
TT		 81062019-06-27 Tom Tromey <tromey@adacore.com>
8107
8108 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8109 to cp_print_static_field.
8110
762c164d
TT		 81112019-06-26 Tom Tromey <tromey@adacore.com>
8112
8113 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8114 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8115 declare.
8116
aa2f9bcf
AH		 81172019-06-26 Alan Hayward <alan.hayward@arm.com>
8118
8119 * features/aarch64-core.c (create_feature_aarch64_core):
8120 Regenerate.
8121 * features/aarch64-core.xml: Add cpsr flags.
8122
3426ae57
AH		 81232019-06-26 Alan Hayward <alan.hayward@arm.com>
8124
8125 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8126 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8127
4838e44c
SM		 81282019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8129
8130 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8131 field.
8132 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8133 use.
8134 (arm_record_special_symbol): Don't insert new symbol in sorted
8135 position, push it at the end.
8136
54cc7474
SM		 81372019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8138
8139 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8140 (arm_mapping_symbol_s): Remove.
8141 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8142 (arm_mapping_symbol_vec): New typedef.
8143 (struct arm_per_objfile): Add constructor.
8144 <section_maps>: Change type to
8145 std::unique_ptr<arm_mapping_symbol_vec[]>.
8146 (arm_compare_mapping_symbols): Remove.
8147 (arm_find_mapping_symbol): Adjust to section_maps type change.
8148 (arm_objfile_data_free): Call delete on arm_per_objfile.
8149 (arm_record_special_symbol): Adjust to section_maps type change.
8150 Allocate arm_per_objfile with new.
8151
b65b566c
PW		 81522019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8153
8154 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8155 with the command prefix.
8156
c2fc64f5
TT		 81572019-06-25 Tom Tromey <tom@tromey.com>
8158
8159 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8160 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8161
fb54fa76
TT		 81622019-06-25 Tom Tromey <tom@tromey.com>
8163
8164 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8165 type.
8166 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8167 protected.
8168
f7952c57
TT		 81692019-06-25 Tom Tromey <tom@tromey.com>
8170
8171 * tui/tui-winsource.c
8172 (tui_source_window_base::set_is_exec_point_at): Add check against
8173 LOA_ADDRESS.
8174
17568d78
TT		 81752019-06-25 Tom Tromey <tom@tromey.com>
8176
8177 * tui/tui-source.c (tui_set_source_content): Don't check before
8178 xfree.
8179 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8180
53e7cdba
TT		 81812019-06-25 Tom Tromey <tom@tromey.com>
8182
8183 * tui/tui-winsource.h (tui_update_source_window_as_is)
8184 (tui_alloc_source_buffer, tui_line_is_displayed)
8185 (tui_addr_is_displayed): Change type of win_info.
8186 * tui/tui-winsource.c (tui_update_source_window_as_is)
8187 (tui_clear_source_content, tui_show_source_line)
8188 (tui_show_source_content, tui_source_window_base::refill)
8189 (tui_source_window_base::set_is_exec_point_at)
8190 (tui_source_window_base::set_is_exec_point_at)
8191 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8192 (tui_alloc_source_buffer, tui_line_is_displayed)
8193 (tui_addr_is_displayed): Change type of win_info. Update.
8194 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8195 (tui_source_window_base::do_make_visible_with_new_height):
8196 Update.
8197 * tui/tui-source.c (tui_set_source_content)
8198 (tui_set_source_content_nil)
8199 (tui_source_window::do_scroll_vertical): Update.
8200 * tui/tui-layout.c (show_layout): Update.
8201 * tui/tui-disasm.c (tui_set_disassem_content)
8202 (tui_disasm_window::do_scroll_vertical): Update.
8203 * tui/tui-data.h (tui_win_content): Remove.
8204 (struct tui_gen_win_info) <content, content_size>: Remove.
8205 (struct tui_source_element): Add initializers and destructor.
8206 (union tui_which_element, struct tui_win_element): Remove.
8207 (struct tui_source_window_base) <content>: New field.
8208 (struct tui_data_window): Remove destructor.
8209 (tui_alloc_content, tui_free_win_content)
8210 (tui_free_all_source_wins_content): Don't declare.
8211 * tui/tui-data.c (tui_initialize_static_data): Update.
8212 (init_content_element, tui_alloc_content): Remove.
8213 (~tui_gen_win_info): Update.
8214 (~tui_data_window, tui_free_all_source_wins_content)
8215 (tui_free_win_content, free_content, free_content_elements):
8216 Remove.
8217
7908abbf
TT		 82182019-06-25 Tom Tromey <tom@tromey.com>
8219
8220 * tui/tui-winsource.h (tui_clear_source_content)
8221 (tui_erase_source_content, tui_show_source_content): Change type
8222 of win_info.
8223 * tui/tui-winsource.c (tui_clear_source_content)
8224 (tui_erase_source_content, tui_show_source_content): Change type
8225 of win_info.
8226 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8227 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8228 win_info.
8229 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8230 win_info.
8231 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8232
02c28df0
TT		 82332019-06-25 Tom Tromey <tom@tromey.com>
8234
8235 * tui/tui-winsource.c (tui_clear_source_content)
8236 (tui_source_window_base::set_is_exec_point_at): Update.
8237 * tui/tui-source.c (tui_set_source_content_nil): Update.
8238 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8239 a bool.
8240 * tui/tui-data.c (init_content_element): Update.
8241
6658b1bf
TT		 82422019-06-25 Tom Tromey <tom@tromey.com>
8243
8244 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8245 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8246 * tui/tui-layout.c (init_and_make_win): Update.
8247 * tui/tui.h (enum tui_win_type): Update.
8248 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8249 tui_win_is_auxillary.
8250 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8251 tui_win_is_auxillary.
8252
21e1c91e
TT		 82532019-06-25 Tom Tromey <tom@tromey.com>
8254
8255 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8256 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8257 (tui_delete_data_content_windows, tui_display_all_data)
8258 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8259 Update.
8260 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8261 * tui/tui-regs.c (tui_last_regs_line_no)
8262 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8263 (tui_show_registers): Update.
8264 (tui_show_register_group): Return void. Update.
8265 (tui_display_registers_from, tui_display_reg_element_at_line)
8266 (tui_display_registers_from_line, tui_check_register_values):
8267 Update.
8268 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8269 member.
8270 (struct tui_data_window) <regs_content>: Now a std::vector.
8271 <regs_content_count>: Remove.
8272 (tui_add_content_elements, tui_free_data_content): Don't declare.
8273 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8274 (init_content_element): Remove DATA_WIN case. Add assert.
8275 (tui_add_content_elements): Remove.
8276 (tui_data_window): Update.
8277 (tui_free_data_content): Remove.
8278 (free_content_elements): Remove DATA_WIN case.
8279
115ac53b
TT		 82802019-06-25 Tom Tromey <tom@tromey.com>
8281
8282 * tui/tui-data.c (tui_data_item_window): Update.
8283 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8284 * tui/tui-windata.c (tui_display_all_data)
8285 (tui_display_data_from_line): Update.
8286 (tui_check_data_values): Remove.
8287 * tui/tui-regs.c (tui_show_register_group)
8288 (tui_display_reg_element_at_line): Update.
8289 * tui/tui-hooks.c (tui_register_changed)
8290 (tui_refresh_frame_and_register_information): Call
8291 tui_check_register_values.
8292 * tui/tui-data.h (struct tui_data_window) <data_content,
8293 data_content_count, data_type>: Remove.
8294 (enum tui_data_type): Remove.
8295
8296 * tui/tui-data.c (tui_data_window::clear_detail)
8297 (~tui_data_window): Update.
8298
eaf9738b
TT		 82992019-06-25 Tom Tromey <tom@tromey.com>
8300
8301 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8302 declare.
8303 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8304 Rename from tui_first_data_item_displayed. Update.
8305 (tui_data_window::refresh_all)
8306 (tui_data_window::do_scroll_vertical): Update.
8307 * tui/tui-data.h (struct tui_data_window)
8308 <first_data_item_displayed>: Declare new method.
8309
31ca4723
TT		 83102019-06-25 Tom Tromey <tom@tromey.com>
8311
8312 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8313 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8314 contents...
8315 (tui_initialize_static_data): ...here.
8316
41bcff7f
TT		 83172019-06-25 Tom Tromey <tom@tromey.com>
8318
8319 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8320 (tui_display_registers_from, tui_check_register_values): Update.
8321 (tui_display_register): Remove win_info parameter; update.
8322 (tui_get_register): Change type of parameters.
8323 * tui/tui-data.h (struct tui_data_element): Remove.
8324 (union tui_which_element) <data>: Remove.
8325 <data_window>: Change type.
8326 (struct tui_data_item_window): New.
8327 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8328 case. Add assert.
8329 (~tui_data_item_window): New destructor.
8330 (free_content_elements): Remove DATA_ITEM_WIN case.
8331
d2802c33
TT		 83322019-06-25 Tom Tromey <tom@tromey.com>
8333
8334 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8335 Remove.
8336
dd835f8b
TT		 83372019-06-25 Tom Tromey <tom@tromey.com>
8338
8339 * tui/tui-data.h (struct tui_command_element): Remove.
8340 (union tui_which_element) <command>: Remove.
8341 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8342 assert.
8343 (free_content_elements): Remove CMD_WIN case.
8344
bd7db367
TT		 83452019-06-25 Tom Tromey <tom@tromey.com>
8346
8347 * tui/tui-layout.c (tui_set_layout): Update.
8348 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8349 * tui/tui-data.c (layout_def): Update.
8350
3add462f
TT		 83512019-06-25 Tom Tromey <tom@tromey.com>
8352
8353 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8354 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8355 (tui_source_window_base::set_new_height): Update.
8356 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8357 Update.
8358 (tui_set_locator_fullname, tui_set_locator_info)
8359 (tui_show_frame_info): Update.
8360 * tui/tui-source.c (tui_set_source_content)
8361 (tui_source_is_displayed): Update.
8362 * tui/tui-layout.c (show_source_disasm_command, show_data)
8363 (show_source_or_disasm_and_command): Update.
8364 * tui/tui-disasm.c (tui_set_disassem_content)
8365 (tui_get_begin_asm_address): Update.
8366 * tui/tui-data.h (struct tui_locator_element): Remove.
8367 (union tui_which_element) <locator>: Remove.
8368 (struct tui_locator_window): New.
8369 (tui_locator_win_info_ptr): Change return type.
8370 * tui/tui-data.c (_locator): Change type.
8371 (tui_locator_win_info_ptr): Change return type.
8372 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8373 (tui_alloc_content): Add assert.
8374
489e9d8b
TT		 83752019-06-25 Tom Tromey <tom@tromey.com>
8376
8377 * tui/tui-winsource.c
8378 (tui_exec_info_window::maybe_allocate_content): New method.
8379 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8380 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8381 (make_source_or_disasm_window): Add cast.
8382 * tui/tui-data.h (union tui_which_element) <simple_string>:
8383 Remove.
8384 (struct tui_source_info): New.
8385 (struct tui_source_window_base) <execution_info>: Change type.
8386 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8387 case, and add assert.
8388 (tui_alloc_content): Add assert.
8389
c3fabb7d
TT		 83902019-06-25 Tom Tromey <tom@tromey.com>
8391
8392 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8393 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8394 * tui/tui-data.c (tui_alloc_win_info): Remove.
8395
bbc228ee
TT		 83962019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8399 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8400 can_highlight.
8401
5fcee43a
TT		 84022019-06-25 Tom Tromey <tom@tromey.com>
8403
8404 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8405 make_visible_with_new_height method.
8406 (tui_win_info::make_visible_with_new_height): New method.
8407 (tui_source_window_base::do_make_visible_with_new_height)
8408 (tui_data_window::do_make_visible_with_new_height)
8409 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8410 (make_visible_with_new_height): Remove.
8411 (tui_resize_all, tui_adjust_win_heights): Use
8412 make_visible_with_new_height method.
8413 * tui/tui-data.h (struct tui_win_info)
8414 <do_make_visible_with_new_height, make_visible_with_new_height>:
8415 New methods.
8416 (struct tui_source_window_base, struct tui_data_window)
8417 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8418 methods.
8419
d83f1fe6
TT		 84202019-06-25 Tom Tromey <tom@tromey.com>
8421
8422 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8423 method.
8424 (update_tab_width): Call update_tab_width method.
8425 * tui/tui-data.h (struct tui_win_info)
8426 (struct tui_source_window_base) <update_tab_width>: New methods.
8427
17374de4
TT		 84282019-06-25 Tom Tromey <tom@tromey.com>
8429
8430 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8431 parameter.
8432 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8433 parameter.
8434 (tui_gen_win_info::make_visible): Update.
8435 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8436 parameter.
8437 * tui/tui-data.h (enum tui_box): New enum.
8438 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8439
f936bca2
TT		 84402019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8443 init_and_make_win for EXEC_INFO_WIN.
8444 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8445 longer inline.
8446 (struct tui_win_info) <~tui_win_info>: Inline.
8447 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8448 Don't declare.
8449 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8450 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8451 Remove.
8452 (tui_initialize_static_data): Update.
8453 (~tui_gen_win_info): Handle more cleanup here.
8454 (~tui_source_window_base): Delete "execution_info".
8455 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8456
d6ba6a11
TT		 84572019-06-25 Tom Tromey <tom@tromey.com>
8458
8459 * tui/tui-layout.c (make_command_window): Don't set
8460 can_highlight.
8461 (show_source_disasm_command): Call the reset method.
8462 (show_data): Don't set can_highlight. Call the reset method.
8463 (tui_gen_win_info::reset): Rename from init_gen_win_info
8464 (init_and_make_win): Simplify. Return tui_gen_win_info.
8465 (show_source_or_disasm_and_command): Call the reset method.
8466 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8467 (struct tui_cmd_window): Set can_highlight.
8468
48a3bd16
TT		 84692019-06-25 Tom Tromey <tom@tromey.com>
8470
8471 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8472 from make_visible.
8473 (tui_make_visible, tui_make_invisible): Rewrite.
8474 (tui_win_info::make_visible): Remove.
8475 (tui_source_window_base::make_visible): Update.
8476 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8477 method. Moved from...
8478 (struct tui_win_info) <make_visible>: ...here.
8479
c3bd716f
TT		 84802019-06-25 Tom Tromey <tom@tromey.com>
8481
8482 * tui/tui-winsource.c
8483 (tui_source_window_base::do_scroll_horizontal): Remove direction
8484 parameter.
8485 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8486 direction parameter.
8487 * tui/tui-win.c (tui_win_info::forward_scroll)
8488 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8489 (tui_win_info::right_scroll): Update.
8490 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8491 direction parameter.
8492 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8493 direction parameter.
8494 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8495 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8496 Remove direction parameter.
8497 (struct tui_source_window_base, struct tui_source_window)
8498 (struct tui_disasm_window, struct tui_data_window)
8499 (struct tui_cmd_window): Update.
8500
21c32dca
TT		 85012019-06-25 Tom Tromey <tom@tromey.com>
8502
8503 * tui/tui-winsource.h (tui_set_exec_info_content)
8504 (tui_show_exec_info_content, tui_erase_exec_info_content)
8505 (tui_clear_exec_info_content, tui_update_exec_info): Change
8506 argument to tui_source_window_base.
8507 * tui/tui-winsource.c (tui_set_exec_info_content)
8508 (tui_show_exec_info_content, tui_erase_exec_info_content)
8509 (tui_clear_exec_info_content, tui_update_exec_info): Change
8510 argument to tui_source_window_base.
8511
73fbdc65
TT		 85122019-06-25 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8515 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8516
33325343
TT		 85172019-06-25 Tom Tromey <tom@tromey.com>
8518
8519 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8520 check.
8521
29d2c474
TT		 85222019-06-25 Tom Tromey <tom@tromey.com>
8523
8524 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8525 type to void.
8526 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8527 type to void.
8528 * tui/tui-source.c (tui_set_source_content): Update.
8529 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8530
152f3f4b
TT		 85312019-06-25 Tom Tromey <tom@tromey.com>
8532
8533 * tui/tui-win.c (window_name_completer, tui_set_focus)
8534 (tui_all_windows_info): Use name method.
8535 * tui/tui-data.h (struct tui_gen_win_info)
8536 (struct tui_source_window, struct tui_disasm_window)
8537 (struct tui_data_window, struct tui_cmd_window) <name>: New
8538 method.
8539 (tui_win_name): Don't declare.
8540 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8541 (tui_win_name): Remove.
8542
be4da588
TT		 85432019-06-25 Tom Tromey <tom@tromey.com>
8544
8545 * tui/tui-winsource.h (tui_update_source_window)
8546 (tui_update_source_window_as_is): Change parameter type.
8547 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8548 to be a tui_source_window_base.
8549 (tui_update_source_window_as_is): Likewise.
8550 * tui/tui-win.c (make_visible_with_new_height): Update.
8551
5b81daba
TT		 85522019-06-25 Tom Tromey <tom@tromey.com>
8553
8554 * tui/tui-winsource.c (tui_erase_source_content)
8555 (tui_show_source_content, tui_show_exec_info_content)
8556 (tui_erase_exec_info_content): Use refresh_window method.
8557 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8558 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8559 from tui_refresh_win.
8560 (tui_data_window::refresh_window): New method.
8561 (tui_win_info::refresh, tui_source_window_base::refresh)
8562 (tui_refresh_all): Use refresh_window method.
8563 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8564 method.
8565 * tui/tui-regs.c (tui_display_register): Call refresh_window
8566 method.
8567 * tui/tui-layout.c (show_source_disasm_command)
8568 (show_source_or_disasm_and_command): Call refresh_window method.
8569 * tui/tui-data.h (struct tui_gen_win_info)
8570 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8571 New method.
8572
cb2ce893
TT		 85732019-06-25 Tom Tromey <tom@tromey.com>
8574
8575 * tui/tui.c (tui_rl_other_window, tui_enable)
8576 (tui_is_window_visible, tui_get_command_dimension): Update.
8577 * tui/tui-winsource.c (tui_update_source_window_as_is)
8578 (tui_clear_source_content, tui_erase_source_content)
8579 (tui_show_source_line, tui_source_window_base::refill)
8580 (tui_source_window_base::do_scroll_horizontal)
8581 (tui_source_window_base::set_is_exec_point_at)
8582 (tui_update_breakpoint_info, tui_set_exec_info_content)
8583 (tui_alloc_source_buffer, tui_line_is_displayed)
8584 (tui_addr_is_displayed): Update.
8585 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8586 (tui_check_and_display_highlight_if_needed)
8587 (tui_win_info::make_visible, tui_win_info::refresh)
8588 (tui_refresh_all): Update.
8589 * tui/tui-windata.c (tui_first_data_item_displayed)
8590 (tui_delete_data_content_windows, tui_erase_data_content)
8591 (tui_display_all_data, tui_data_window::refresh_all)
8592 (tui_check_data_values): Update.
8593 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8594 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8595 (tui_win_info::backward_scroll, tui_refresh_all_win)
8596 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8597 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8598 (tui_source_window_base::set_new_height)
8599 (tui_data_window::set_new_height)
8600 (make_invisible_and_set_new_height)
8601 (make_visible_with_new_height, new_height_ok)
8602 (parse_scrolling_args): Update.
8603 * tui/tui-stack.c (tui_show_frame_info): Update.
8604 * tui/tui-source.c (tui_set_source_content)
8605 (tui_set_source_content_nil, tui_source_is_displayed)
8606 (tui_source_window::do_scroll_vertical): Update.
8607 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8608 (tui_display_registers_from, tui_display_reg_element_at_line)
8609 (tui_check_register_values, tui_reg_command): Update.
8610 * tui/tui-layout.c (tui_default_win_height)
8611 (show_source_disasm_command, show_data, init_and_make_win)
8612 (show_source_or_disasm_and_command): Update.
8613 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8614 (tui_redisplay_readline, tui_mld_flush)
8615 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8616 (tui_getc): Update.
8617 * tui/tui-disasm.c (tui_set_disassem_content)
8618 (tui_disasm_window::do_scroll_vertical): Update.
8619 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8620 Now virtual.
8621 (struct tui_win_info): Derive from tui_gen_win_info.
8622 <~tui_win_info>: Mark as override.
8623 <generic>: Remove member.
8624 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8625 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8626 (~tui_data_window, ~tui_win_info)
8627 (tui_free_all_source_wins_content): Update.
8628 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8629
ab313b35
TT		 86302019-06-25 Tom Tromey <tom@tromey.com>
8631
8632 * tui/tui-layout.c (init_and_make_win): Use new.
8633 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8634 destructor, initializers.
8635 (tui_alloc_generic_win_info): Don't declare.
8636 * tui/tui-data.c (_locator): Add argument to constructor.
8637 (source_win, disasm_win): New globals.
8638 (exec_info): Remove.
8639 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8640 Update.
8641 (tui_alloc_generic_win_info): Remove.
8642 (init_content_element): Use new.
8643 (tui_win_info::tui_win_info): Update.
8644 (free_content_elements) <case DATA_WIN>: Use delete.
8645
dc2c33e4
TT		 86462019-06-25 Tom Tromey <tom@tromey.com>
8647
8648 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8649 * tui/tui-windata.c (tui_first_data_item_displayed)
8650 (tui_delete_data_content_windows): Update.
8651 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8652 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8653 (tui_display_registers_from, tui_check_register_values): Update.
8654 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8655 pointer.
8656 * tui/tui-data.c (init_content_element): Update. Allocate the new
8657 window.
8658 (tui_free_data_content): Update.
8659 (free_content_elements) <case DATA_WIN>: Free the window.
8660
214a5cbe
TT		 86612019-06-25 Tom Tromey <tom@tromey.com>
8662
8663 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8664 Update.
8665 * tui/tui-layout.c (make_command_window)
8666 (show_source_disasm_command, show_data, init_and_make_win)
8667 (show_source_or_disasm_and_command): Update.
8668 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8669 method.
8670 <can_highight, is_highlighted>: Now bool.
8671 (tui_set_win_highlight): Don't declare.
8672 * tui/tui-data.c (tui_set_win_highlight): Remove.
8673
8e2daf15
TT		 86742019-06-25 Tom Tromey <tom@tromey.com>
8675
8676 * tui/tui-wingeneral.c (make_visible): Remove check of window
8677 type.
8678
8903bd8a
TT		 86792019-06-25 Tom Tromey <tom@tromey.com>
8680
8681 * tui/tui-win.c (tui_win_info::max_height)
8682 (tui_cmd_window::max_height): New methods.
8683 (new_height_ok): Call max_height.
8684 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8685 <max_height>: New method.
8686
3f02ce1e
TT		 86872019-06-25 Tom Tromey <tom@tromey.com>
8688
8689 * tui/tui-win.c (tui_source_window_base::set_new_height)
8690 (tui_data_window::set_new_height): New methods.
8691 (make_invisible_and_set_new_height): Call set_new_height method.
8692 * tui/tui-data.h (struct tui_win_info)
8693 (struct tui_source_window_base, struct tui_data_window)
8694 <set_new_height>: New method.
8695
1825f487
TT		 86962019-06-25 Tom Tromey <tom@tromey.com>
8697
8698 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8699 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8700 tui_refresh_data_win.
8701 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8702 method.
8703 (tui_refresh_all_win): Call the refresh_all method.
8704 (tui_set_focus): Likewise.
8705 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8706 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8707 Likewise.
8708
ad54d15b
TT		 87092019-06-25 Tom Tromey <tom@tromey.com>
8710
8711 * tui/tui-winsource.h (tui_refill_source_window)
8712 (tui_set_is_exec_point_at): Don't declare.
8713 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8714 (tui_source_window_base::refill): Rename from
8715 tui_refill_source_window.
8716 (tui_source_window_base::do_scroll_horizontal): Update.
8717 (tui_source_window_base::set_is_exec_point_at): Rename from
8718 tui_set_is_exec_point_at.
8719 (tui_update_all_breakpoint_info): Update.
8720 * tui/tui-stack.c (tui_show_frame_info): Update.
8721 * tui/tui-layout.c (show_data): Add cast.
8722 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8723 * tui/tui-data.h (struct tui_source_window_base) <refill,
8724 set_is_exec_point_at>: New methods.
8725 (tui_source_windows, tui_add_to_source_windows): Update types.
8726 (tui_add_to_source_windows): Remove redundant declaration.
8727 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8728 (tui_source_windows): Change return type.
8729 (tui_clear_source_windows_detail): Update.
8730 (tui_add_to_source_windows): Change type of parameter.
8731 (tui_free_all_source_wins_content): Update.
8732
2042b506
TT		 87332019-06-25 Tom Tromey <tom@tromey.com>
8734
8735 * tui/tui-wingeneral.c (tui_win_info::refresh)
8736 (tui_source_window_base::refresh): New methods.
8737 (tui_refresh_all): Call the refresh method.
8738 * tui/tui-data.h (struct tui_win_info)
8739 (struct tui_source_window_base) <refresh>: New method.
8740
56122977
TT		 87412019-06-25 Tom Tromey <tom@tromey.com>
8742
8743 * tui/tui.h (tui_is_window_visible): Return bool.
8744 * tui/tui.c (tui_is_window_visible): Return bool.
8745 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8746 (tui_make_visible, tui_make_invisible)
8747 (tui_win_info::make_visible)
8748 (tui_source_window_base::make_visible, make_all_visible)
8749 (tui_make_all_visible, tui_make_all_invisible): Update.
8750 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8751 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8752 bool.
8753 (struct tui_win_info, struct tui_source_window_base)
8754 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8755 * tui/tui-data.c (tui_init_generic_part): Update.
8756
cda37efb
TT		 87572019-06-25 Tom Tromey <tom@tromey.com>
8758
8759 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8760 (tui_source_window_base::make_visible): New methods.
8761 (make_all_visible): Make method call.
8762 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8763 (struct tui_source_window_base, struct tui_cmd_window): Override
8764 make_visible.
8765 (tui_win_is_source_type): Don't declare.
8766 * tui/tui-data.c (tui_win_is_source_type): Remove.
8767
6a0ee02c
TT		 87682019-06-25 Tom Tromey <tom@tromey.com>
8769
8770 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8771 NULL check.
8772
63901aec
TT		 87732019-06-25 Tom Tromey <tom@tromey.com>
8774
8775 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8776 Inline constructor. Add initializers for members.
8777 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8778 constructors; now inline in class.
8779
ceb13a13
TT		 87802019-06-25 Tom Tromey <tom@tromey.com>
8781
8782 * tui/tui-regs.c (tui_show_registers): Update.
8783 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8784 bool.
8785 * tui/tui-data.c (tui_data_window::clear_detail)
8786 (tui_data_window): Update.
8787
238eb706
TT		 87882019-06-25 Tom Tromey <tom@tromey.com>
8789
8790 * tui/tui-windata.c (tui_display_all_data)
8791 (tui_display_data_from_line, tui_display_data_from)
8792 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8793 Update.
8794 * tui/tui-regs.c (tui_last_regs_line_no)
8795 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8796 (tui_show_registers, tui_show_register_group)
8797 (tui_display_registers_from, tui_display_reg_element_at_line)
8798 (tui_display_registers_from_line, tui_check_register_values)
8799 (tui_reg_next, tui_reg_prev): Update.
8800 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8801 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8802 tui_data_window.
8803 (struct tui_win_info) <detail>: Remove. Add new fields from
8804 tui_data_info.
8805 (TUI_DATA_WIN): Add cast.
8806 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8807 (~tui_data_window): Simplify.
8808
81491aa0
TT		 88092019-06-25 Tom Tromey <tom@tromey.com>
8810
8811 * tui/tui-layout.c (show_source_disasm_command)
8812 (show_source_or_disasm_and_command): Update.
8813 * tui/tui-io.c (update_cmdwin_start_line)
8814 (tui_redisplay_readline): Update.
8815 * tui/tui-data.h (struct tui_command_info): Remove.
8816 (struct tui_win_info) <detail>: Remove command_info member.
8817 (struct tui_data_window) <start_line>: New member, from
8818 tui_command_info.
8819 (TUI_CMD_WIN): Add casts.
8820
e6e41501
TT		 88212019-06-25 Tom Tromey <tom@tromey.com>
8822
8823 * tui/tui-winsource.c (tui_update_source_window)
8824 (tui_refill_source_window)
8825 (tui_source_window_base::do_scroll_horizontal)
8826 (tui_update_breakpoint_info, tui_set_exec_info_content)
8827 (tui_show_exec_info_content, tui_erase_exec_info_content)
8828 (tui_clear_exec_info_content): Update.
8829 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8830 Update.
8831 * tui/tui-win.c (make_invisible_and_set_new_height)
8832 (make_visible_with_new_height): Update.
8833 * tui/tui-source.c (tui_set_source_content)
8834 (tui_show_symtab_source): Update.
8835 * tui/tui-layout.c (extract_display_start_addr)
8836 (show_source_disasm_command, show_data)
8837 (make_source_or_disasm_window)
8838 (show_source_or_disasm_and_command): Update.
8839 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8840 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8841 "gdbarch".
8842 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8843 to tui_source_window_base.
8844 (struct tui_win_info) <detail>: Remove source_info member.
8845 (struct tui_source_window_base) <has_locator>: Inline.
8846 Move contents from tui_source_info; rename has_locator member to
8847 m_has_locator.
8848 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8849 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8850 header file.
8851 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8852 Simplify.
8853 (tui_free_all_source_wins_content): Cast to
8854 tui_source_window_base.
8855
44f0e208
TT		 88562019-06-25 Tom Tromey <tom@tromey.com>
8857
8858 * tui/tui-win.c (make_invisible_and_set_new_height)
8859 (make_visible_with_new_height): Call has_locator method.
8860 * tui/tui-layout.c (show_source_disasm_command, show_data)
8861 (show_source_or_disasm_and_command): Update for bool change.
8862 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8863 (tui_win_info) <has_locator>: New method.
8864 (struct tui_source_window_base) <has_locator>: New method.
8865 (tui_win_has_locator): Don't declare.
8866 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8867 from tui_win_has_locator.
8868 (tui_source_window_base): Use false, not FALSE.
8869
7778b912
TT		 88702019-06-25 Tom Tromey <tom@tromey.com>
8871
8872 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8873 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8874 clear_detail method directly.
8875 (tui_clear_win_detail): Remove.
8876
f83d391c
TT		 88772019-06-25 Tom Tromey <tom@tromey.com>
8878
8879 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8880 "this", not TUI_DISASM_WIN.
8881
13446e05
TT		 88822019-06-25 Tom Tromey <tom@tromey.com>
8883
8884 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8885 declare.
8886 * tui/tui-winsource.c
8887 (tui_source_window_base::do_scroll_horizontal): Rename from
8888 tui_horizontal_source_scroll.
8889 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8890 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8891 from tui_vertical_data_scroll.
8892 * tui/tui-win.h (tui_scroll): Don't declare.
8893 * tui/tui-win.c (tui_win_info::forward_scroll)
8894 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8895 (tui_win_info::right_scroll): Rename and update.
8896 (tui_scroll_forward_command, tui_scroll_backward_command)
8897 (tui_scroll_left_command, tui_scroll_right_command): Update.
8898 (tui_scroll): Remove.
8899 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8900 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8901 from tui_vertical_source_scroll.
8902 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8903 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8904 from tui_vertical_disassem_scroll.
8905 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8906 do_scroll_horizontal>: New methods.
8907 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8908 Likewise.
8909 (struct tui_source_window_base): Add do_scroll_horizontal.
8910 (struct tui_source_window, struct tui_disasm_window): Add
8911 do_scroll_vertical.
8912 (struct tui_data_window, struct tui_cmd_window): Add
8913 do_scroll_horizontal and do_scroll_vertical.
8914 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8915
5cf82909
TT		 89162019-06-25 Tom Tromey <tom@tromey.com>
8917
8918 * tui/tui-data.h (struct tui_source_window_base): New struct.
8919 (struct tui_source_window): Derive from tui_source_window_base.
8920 (struct tui_disasm_window): New struct.
8921 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8922 from tui_source_window::clear_detail.
8923 (tui_source_window_base): Rename from tui_source_window.
8924 (~tui_source_window_base): Rename from ~tui_source_window.
8925 (tui_alloc_win_info): Create a tui_disasm_window.
8926
ee1d42d6
TT		 89272019-06-25 Tom Tromey <tom@tromey.com>
8928
8929 * tui/tui-data.h (struct tui_source_window)
8930 (struct tui_data_window): Declare destructors.
8931 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8932 destructors.
8933 (tui_win_info): Simplify.
8934
b4eb2452
TT		 89352019-06-25 Tom Tromey <tom@tromey.com>
8936
8937 * tui/tui-winsource.c (tui_display_main)
8938 (tui_update_source_windows_with_addr)
8939 (tui_update_all_breakpoint_info): Update.
8940 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8941 (new_height_ok, parse_scrolling_args): Update.
8942 * tui/tui-stack.c (tui_show_frame_info): Update.
8943 * tui/tui-data.h (struct tui_list): Remove.
8944 (tui_source_windows): Return a reference to a std::vector.
8945 * tui/tui-data.c (source_windows): Now a std::vector.
8946 (tui_source_windows): Change return type.
8947 (tui_clear_source_windows): Rewrite.
8948 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8949 (tui_free_all_source_wins_content): Rewrite.
8950
8761a91b
TT		 89512019-06-25 Tom Tromey <tom@tromey.com>
8952
8953 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8954 (struct tui_data_window, struct tui_cmd_window): Declare
8955 clear_detail method.
8956 * tui/tui-data.c (tui_source_window::clear_detail)
8957 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8958 methods.
8959 (tui_clear_win_detail): Simplify.
8960
0ed69eda
TT		 89612019-06-25 Tom Tromey <tom@tromey.com>
8962
8963 * tui/tui-layout.c (make_source_window, make_disasm_window)
8964 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8965 Return the new window.
8966 (show_source_disasm_command, show_data)
8967 (show_source_or_disasm_and_command): Update.
8968
82432e10
TT		 89692019-06-25 Tom Tromey <tom@tromey.com>
8970
8971 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8972 parameter. Return the new window.
8973 (show_source_disasm_command): Update and remove NULL check.
8974 (show_source_or_disasm_and_command): Update.
8975
ec328aa5
TT		 89762019-06-25 Tom Tromey <tom@tromey.com>
8977
8978 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8979
33b906ab
TT		 89802019-06-25 Tom Tromey <tom@tromey.com>
8981
8982 * tui/tui-data.h (struct tui_win_info): Make constructor
8983 protected. Make destructor virtual. Add initializers.
8984 (tui_source_window, tui_data_window, tui_cmd_window): New
8985 classes.
8986 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8987 constructor. Add "type" parameter.
8988 (tui_source_window, tui_data_window, tui_cmd_window): New
8989 constructors.
8990 (tui_alloc_win_info): Instantiate the appropriate subclass.
8991
e7e11af4
TT		 89922019-06-25 Tom Tromey <tom@tromey.com>
8993
8994 * tui/tui-win.c (tui_resize_all): Use delete.
8995 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8996 destructor.
8997 (tui_free_window): Don't declare.
8998 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8999 Update.
9000
6792b55e
TT		 90012019-06-25 Tom Tromey <tom@tromey.com>
9002
9003 * tui/tui-data.h (struct tui_win_info): Add constructor.
9004 * tui/tui-data.c (tui_alloc_win_info): Use new.
9005 (tui_free_window): Use delete.
9006
f95675e1
TT		 90072019-06-22 Tom Tromey <tom@tromey.com>
9008
9009 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9010 declare.
9011 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9012
5bff081c
TT		 90132019-06-22 Tom Tromey <tom@tromey.com>
9014
9015 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9016 declare.
9017 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9018
47e3f474
TV		 90192019-06-22 Tom de Vries <tdevries@suse.de>
9020
9021 * dwarf2read.c (create_addrmap_from_aranges)
9022 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9023 instead of '%zu'.
9024
fd5866f6
SM		 90252019-06-21 Simon Marchi <simon.marchi@efficios.com>
9026
9027 * dwarf2read.h (dwarf2_section_info_def): Remove.
9028 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9029 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9030 std::vector<dwarf2_section_info>.
9031 (struct dwo_file) <~dwo_file>: Remove.
9032 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9033 types field.
9034 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9035 (dwarf2_read_debug_names): Likewise.
9036 (create_debug_types_hash_table): Change parameter type to
9037 array_view, adjust code accordingly.
9038 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9039 (partial_die_info::fixup): Likewise.
9040 (determine_prefix): Likewise.
9041 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9042
fb1eb2f9
SM		 90432019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9044
9045 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9046 gdb_bfd_ref_ptr.
9047 <~dwo_file>: Remove call to gdb_bfd_unref.
9048 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9049 gdb_bfd_ref_ptr::get.
9050
51ac9db5
SM		 90512019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9052
9053 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9054 type to htab_up.
9055 * dwarf2read.c (struct dwo_file): Initialize fields.
9056 <~dwo_file>: New.
9057 (free_dwo_file): Remove, move content to ~dwo_file.
9058 (struct dwo_file_deleter): Remove.
9059 (dwo_file_up>: Remove custom deleter.
9060 (free_dwo_files): Remove.
9061 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9062 dwo_files.
9063 (process_skeletonless_type_units): Call unique_ptr::get.
9064 (allocate_dwo_file_hash_table): Add deleter to created hash
9065 table. Change return type to htab_up.
9066 (lookup_dwo_file_slot): Don't memset dwo_file, call
9067 unique_ptr::get.
9068 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9069 (create_dwo_unit_in_dwp_v2): Likewise.
9070 (open_and_init_dwo_file): Likewise.
9071 (free_dwo_file_from_slot): Remove.
9072
dc4ccb6f
SM		 90732019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9074
9075 * dwarf2read.h (struct dwarf2_section_info) <readin,
9076 is_virtual>: Change type to bool.
9077 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9078 true instead of 1.
9079
e6a1c5cb
TT		 90802019-06-19 Tom Tromey <tom@tromey.com>
9081
9082 * tui/tui-data.h (tui_init_content_element): Don't declare.
9083
6f6ffbeb
TT		 90842019-06-19 Tom Tromey <tom@tromey.com>
9085
9086 * tui/tui-data.h (tui_init_win_info): Don't declare.
9087
f23f598e
TV		 90882019-06-19 Tom de Vries <tdevries@suse.de>
9089
9090 * dwarf2read.h (abstract_to_concrete): Change type to
9091 std::unordered_map<sect_offset, std::vector<sect_offset>,
9092 gdb::hash_enum<sect_offset>>.
9093
680e1bee
TT		 90942019-06-19 Tom Tromey <tromey@adacore.com>
9095
9096 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9097 EVAL_AVOID_SIDE_EFFECTS specially.
9098
dcf37923
TT		 90992019-06-19 Tom Tromey <tromey@adacore.com>
9100
9101 * source-cache.c (highlighter): New global.
9102 (source_cache::get_source_lines): Create a highlighter on demand.
9103
494986d5
AB		 91042019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9105
9106 * defs.h (deprecated_interactive_hook): Delete declaration.
9107 * interps.c (clear_interpreter_hooks): Remove use of
9108 deprecated_interactive_hook.
9109 * top.c (deprecated_interactive_hook): Delete definition.
9110 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9111
3360b6e7
TV		 91122019-06-18 Tom de Vries <tdevries@suse.de>
9113
9114 PR gdb/24515
9115 * dwarf2read.h (abstract_to_concrete): Change type from
9116 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9117 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9118 * dwarf2read.c (read_variable): Update.
9119 (dwarf2_fetch_die_loc_sect_off): Update.
9120
310b3441
TV		 91212019-06-17 Tom de Vries <tdevries@suse.de>
9122
9123 PR gdb/24617
9124 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9125 accessing parent[parent_len - 1].
9126
ba9777be
PP		 91272019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9128
9129 PR gdb/24364
9130 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9131 call dtrace_process_dof with NULL dof.
9132
2b9f6e89
TV		 91332019-06-16 Tom de Vries <tdevries@suse.de>
9134
9135 PR gdb/24445
9136 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9137
431b3ead
TT		 91382019-06-16 Tom Tromey <tom@tromey.com>
9139
9140 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9141 (make_all_visible): Use address of member.
9142
d04b44a1
TT		 91432019-06-16 Tom Tromey <tom@tromey.com>
9144
9145 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9146 (tui_free_window, free_content, free_content_elements): Remove
9147 unnecessary cast.
9148 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9149 cast.
9150 * tui/tui-regs.c (tui_show_register_group)
9151 (tui_display_registers_from, tui_display_reg_element_at_line):
9152 Remove unnecessary cast.
9153
bf5142e7
AB		 91542019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9155
9156 * linux-nat.c (normal_mask): Delete.
9157 (_initialize_linux_nat): Don't initialise normal_mask.
9158
c4973306
SM		 91592019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9160
9161 PR gdb/24445
9162 * dwarf-index-write.h (write_psymtabs_to_index): Add
9163 dwz_basename parameter.
9164 * dwarf-index-write.c (write_gdbindex): Move file writing to
9165 write_gdbindex_1. Change return type void.
9166 (assert_file_size): Move up, remove filename parameter.
9167 (write_gdbindex_1): New function.
9168 (write_debug_names): Change return type to void, call
9169 assert_file_size.
9170 (struct index_wip_file): New struct.
9171 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9172 file logic to index_wip_file. Write index for dwz file if
9173 needed.
9174 (save_gdb_index_command): Pass basename of dwz file, if present.
9175 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9176 build-id of dwz file, if present.
9177 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9178 (dwarf2_get_dwz_file): Likewise.
9179 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9180 (dwarf2_get_dwz_file): Likewise.
9181
395f9c91
TT		 91822019-06-16 Tom Tromey <tom@tromey.com>
9183
9184 * coffread.c (process_coff_symbol): Use xstrdup.
9185 * value.c (create_internalvar): Use xstrdup.
9186
cafb3438
TT		 91872019-06-16 Tom Tromey <tom@tromey.com>
9188
9189 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9190 * breakpoint.c (stopin_command, stopat_command)
9191 (until_break_command, decode_location_default): Remove unnecessary
9192 cast.
9193 * utils.c (subset_compare): Remove unnecessary cast.
9194 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9195 cast.
9196 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9197 cast.
9198 * infcmd.c (path_command): Remove unnecessary cast.
9199 * coffread.c (decode_type): Remove unnecessary cast.
9200 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9201 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9202 * tui/tui-stack.c (tui_show_locator_content)
9203 (tui_show_frame_info): Remove unnecessary cast.
9204 * tui/tui-win.c (tui_scroll_forward_command)
9205 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9206 (parse_scrolling_args): Remove unnecessary cast.
9207 * tui/tui-data.c (init_win_info, tui_del_window)
9208 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9209 (free_content_elements): Remove unnecessary cast.
9210 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9211 unnecessary cast.
9212 * tui/tui-source.c (tui_set_source_content)
9213 (tui_vertical_source_scroll): Remove unnecessary cast.
9214 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9215 cast.
9216 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9217 * tui/tui-regs.c (tui_display_registers_from)
9218 (tui_display_register): Remove unnecessary cast.
9219 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9220 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9221 (make_visible): Remove unnecessary cast.
9222 * tui/tui-winsource.c (tui_erase_source_content)
9223 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9224 unnecessary cast.
9225 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9226 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9227 * stabsread.c (read_type, read_array_type, read_range_type):
9228 Remove unnecessary cast.
9229 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9230 (parse_symbol, parse_type, upgrade_type, parse_external)
9231 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9232 unnecessary cast.
9233 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9234
730ead81
TT		 92352019-06-16 Tom Tromey <tom@tromey.com>
9236
9237 * tui/tui-data.c (tui_alloc_generic_win_info)
9238 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9239 checks.
9240
584a927c
AB		 92412019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9242 Andrew Burgess <andrew.burgess@embecosm.com>
9243
9244 * f-typeprint.c (f_print_type): Don't return early for not
9245 associated or not allocated types.
9246 (f_type_print_varspec_suffix): Add print_rank parameter and print
9247 ranks of array types in case they dangling.
9248 (f_type_print_base): Add print_rank parameter.
9249
30056ea0
AB		 92502019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9251
9252 * NEWS: Mention new MI commands.
9253 * break-catch-throw.c (enum exception_event_kind): Move to
9254 breakpoint.h.
9255 (print_mention_exception_catchpoint): Output text as a single
9256 message.
9257 (catch_exception_command_1): Rename to...
9258 (catch_exception_event): ...this, make non-static, update header
9259 command, and change some parameter types.
9260 (catch_catch_command): Update for changes to
9261 catch_exception_command_1.
9262 (catch_throw_command): Likewise.
9263 (catch_rethrow_command): Likewise.
9264 * breakpoint.c (enum exception_event_kind): Delete.
9265 * breakpoint.h (enum exception_event_kind): Moved here from
9266 break-catch-throw.c.
9267 (catch_exception_event): Declare.
9268 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9269 (mi_cmd_catch_throw): New function.
9270 (mi_cmd_catch_rethrow): New function.
9271 (mi_cmd_catch_catch): New function.
9272 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9273 'catch-catch' entries.
9274 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9275 (mi_cmd_catch_rethrow): Declare.
9276 (mi_cmd_catch_catch): Declare.
9277
ec8e2b6d
AB		 92782019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9279
9280 * annotate.c (annotate_source_line): Change return type to void,
9281 update implementation to match.
9282 * annotate.h (annotate_source_line): Change return type to void,
9283 update header comment.
9284 * stack.c (print_frame_info): Don't change what frame information
9285 is printed based on whether annotations are on or not.
9286
0d3abd8c
AB		 92872019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9288
9289 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9290 (annotate_source): Make static.
9291 (annotate_source_line): Moved from source.c and renamed from
9292 identify_source_line. Update the return type.
9293 * annotate.h (annotate_source): Delete declaration.
9294 (annotate_source_line): Declaration moved from source.h, and
9295 renamed from identify_source_line. Return type updated.
9296 * source.c (identify_source_line): Moved to annotate.c and renamed
9297 to annotate_source_line.
9298 (info_line_command): Remove check of annotation_level.
9299 * source.h (identify_source_line): Move declaration to annotate.h
9300 and rename to annotate_source_line.
9301 * stack.c: Add 'annotate.h' include.
9302 (print_frame_info): Remove check of annotation_level before
9303 calling annotate_source_line.
9304
00df30ae
AB		 93052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9306
9307 * source-cache.c (source_cache::get_plain_source_lines): Use
9308 open_source_file_with_line_charpos instead of just
9309 open_source_file, remove call to find_source_lines.
9310 (source_cache::get_source_lines): Likewise.
9311 * source.c (find_source_lines): Make static.
9312 (get_filename_and_charpos): Renamed into...
9313 (open_source_file_with_line_charpos): ..this along with changes to
9314 return a scoped_fd, and some other minor clean ups.
9315 (identify_source_line): Use open_source_file_with_line_charpos.
9316 (search_command_helper): Use open_source_file_with_line_charpos
9317 instead of just open_source_file, remove call to
9318 find_source_lines.
9319 * source.h (open_source_file_with_line_charpos): Declare new
9320 function.
9321 (find_source_lines): Delete declaration.
9322
afda45a2
AB		 93232019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9324
9325 * source.c (get_filename_and_charpos): Remove fullname
9326 parameter.
9327 (identify_source_line): Update call to get_filename_and_charpos.
9328
0735b091
TT		 93292019-06-14 Tom Tromey <tromey@adacore.com>
9330
9331 PR gdb/24502:
9332 * ui-style.h (skip_ansi_escape): Update comment.
9333 * ui-file.h (class no_terminal_escape_file): New class.
9334 * ui-file.c (no_terminal_escape_file::write)
9335 (no_terminal_escape_file::puts): New methods.
9336 * cli/cli-logging.c (handle_redirections): Use
9337 no_terminal_escape_file.
9338
52ce35e2
TT		 93392019-06-14 Tom Tromey <tromey@adacore.com>
9340
9341 * NEWS: Move convenience variable news above Python news.
9342
73cc7272
TT		 93432019-06-14 Tom Tromey <tom@tromey.com>
9344
9345 * gnulib: Move directory to top-level.
9346 * configure.ac: Don't configure gnulib.
9347 * configure: Rebuild.
9348 * common/common-defs.h: Use new path to gnulib.
9349 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9350 (GNULIB_H): Remove.
9351 (INCGNU): Look in new gnulib location.
9352 (HFILES_NO_SRCDIR): Remove gnulib files.
9353 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9354 (generated_files): Remove GNULIB_H.
9355 ($(LIBGNU), all-lib): Remove targets.
9356 (distclean): Don't mention GNULIB_BUILDDIR.
9357 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9358
f5686554
TT		 93592019-06-14 Tom Tromey <tromey@adacore.com>
9360
9361 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9362 Warn if symbol file does not provide any symbols.
9363
a0c1ffed
TT		 93642019-06-14 Tom Tromey <tromey@adacore.com>
9365
9366 * source.c (find_and_open_source): Respect basenames_may_differ.
9367
7c39e397
AB		 93682019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9369
9370 * annotate.c (annotate_breakpoints_invalid): Make use of
9371 scoped_restore_terminal_state.
9372 (annotate_frames_invalid): Likewise.
9373
f411722c
TT		 93742019-06-14 Tom Tromey <tromey@adacore.com>
9375
9376 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9377 allow assignment to an internalvar.
9378
4268ec18
TT		 93792019-06-14 Tom Tromey <tromey@adacore.com>
9380
9381 * ada-lex.l: Allow "_" in attribute names.
9382
abdb711e
TT		 93832019-06-14 Tom Tromey <tromey@adacore.com>
9384
9385 PR gdb/24653:
9386 * regcache.c (registers_changed): Don't call alloca.
9387 * top.c (execute_command): Don't call alloca.
9388
4c048731
PA		 93892019-06-13 Pedro Alves <palves@redhat.com>
9390
9391 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9392 'expression'. When parsing an expression, error out if there's
9393 junk after "unlimited".
9394 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9395 (do_set_command): Adjust calls to is_unlimited_literal.
9396
66eb1ed3
PA		 93972019-06-13 Pedro Alves <palves@redhat.com>
9398
9399 * compile/compile.c (make_compile_options_def_group): Add braces
9400 around array_view initializer.
9401 * thread.c (make_thread_apply_all_options_def_group)
9402 (make_thread_apply_all_options_def_group): Likewise.
9403
3345721a
PA		 94042019-06-13 Pedro Alves <palves@redhat.com>
9405
9406 * NEWS (New commands): Mention "maint test-options
9407 require-delimiter", "maint test-options unknown-is-error", "maint
9408 test-options unknown-is-operand" and "maint show
9409 test-options-completion-result".
9410 (New command options, command completion): New section.
9411 (Completion improvements): New section.
9412 Mention that you can abbreviate "unlimited".
9413
6206060d
PA		 94142019-06-13 Pedro Alves <palves@redhat.com>
9415
9416 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9417 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9418 * unittests/cli-utils-selftests.c (test_parse_flags)
9419 (test_parse_flags_qcs): Delete.
9420 (test_cli_utils): Don't call deleted functions.
9421
6665660a
PA		 94222019-06-13 Pedro Alves <palves@redhat.com>
9423
9424 * thread.c: Include "cli/cli-option.h".
9425 (tp_array_compar_ascending): Global.
9426 (tp_array_compar): Delete function.
9427 (tp_array_compar_ascending, tp_array_compar_descending): New
9428 functions.
9429 (ascending_option_def, qcs_flag_option_def)
9430 (thr_qcs_flags_option_defs)
9431 (make_thread_apply_all_options_def_group)
9432 (make_thread_apply_options_def_group): New.
9433 (thread_apply_all_command): Use gdb::option::process_options.
9434 (thread_apply_command_completer)
9435 (thread_apply_all_command_completer): New.
9436 (thread_apply_command): Use gdb::option::process_options.
9437 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9438 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9439 to generate help text of "thread apply". Adjust "taas"'s help.
9440 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9441 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9442
f7e13587
PA		 94432019-06-13 Pedro Alves <palves@redhat.com>
9444
9445 * thread.c (thread_apply_command): Check for invalid TID with
9446 isdigit instead of !isalpha.
9447
5d707134
PA		 94482019-06-13 Pedro Alves <palves@redhat.com>
9449
9450 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9451 (validate_flags_qcs): New.
9452 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9453 (validate_flags_qcs): Declare.
9454 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9455 (make_frame_apply_options_def_group): New.
9456 (frame_apply_command_count): Process options with
9457 gdb::option::process_options.
9458 (frame_apply_completer): New.
9459 (frame_apply_level_completer, frame_apply_all_completer)
9460 (frame_apply_completer): New.
9461 (_initialize_stack): Update help of "frame apply", "frame apply
9462 level", "frame apply all" and "faas" to mention supported options
9463 and install command completers.
9464 * stack.h (frame_apply_all_completer): Declare.
9465 * thread.c: Include "stack.h".
9466 (tfaas_command): Add "--".
9467 (_initialize_thread): Update help "tfaas" to mention supported
9468 options and install command completer.
9469
272d4594
PA		 94702019-06-13 Pedro Alves <palves@redhat.com>
9471
9472 * completer.c (complete_nested_command_line): New.
9473 (gdb_completion_word_break_characters_throw): Add assertion.
9474 * completer.h (complete_nested_command_line): Declare.
9475
90a1ef87
PA		 94762019-06-13 Pedro Alves <palves@redhat.com>
9477
9478 * stack.c (parse_backtrace_qualifiers): New.
9479 (backtrace_command): Use it.
9480 (backtrace_command_completer): Complete on qualifiers.
9481
d4c16835
PA		 94822019-06-13 Pedro Alves <palves@redhat.com>
9483
9484 * frame.c: Include "cli/cli-option.h.
9485 (user_set_backtrace_options): New.
9486 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9487 Delete.
9488 (get_prev_frame): Adjust.
9489 (boolean_option_def, uinteger_option_def)
9490 (set_backtrace_option_defs): New.
9491 (_initialize_frame): Adjust and use
9492 gdb::option::add_setshow_cmds_for_options to install "set
9493 backtrace past-main" and "set backtrace past-entry".
9494 * frame.h: Include "cli/cli-option.h".
9495 (struct frame_print_options): Forward declare.
9496 (print_frame_arguments_all, print_frame_arguments_scalars)
9497 (print_frame_arguments_none): Declare.
9498 (print_entry_values): Delete declaration.
9499 (struct frame_print_options, user_frame_print_options): New.
9500 (struct set_backtrace_options): New.
9501 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9502 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9503 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9504 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9505 (list_args_or_locals): Add frame_print_options parameter.
9506 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9507 * python/py-framefilter.c (enumerate_args): Pass down
9508 USER_FRAME_PRINT_OPTIONS.
9509 * stack.c: Include "cli/cli-option.h".
9510 (print_frame_arguments_all, print_frame_arguments_scalars)
9511 (print_frame_arguments_none): Declare.
9512 (print_raw_frame_arguments, print_entry_values): Delete.
9513 (user_frame_print_options): New.
9514 (boolean_option_def, enum_option_def, frame_print_option_defs):
9515 New.
9516 (struct backtrace_cmd_options): New.
9517 (bt_flag_option_def): New.
9518 (backtrace_command_option_defs): New.
9519 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9520 (print_frame_arg, read_frame_arg, print_frame_args)
9521 (print_frame_info, print_frame): Add frame_print_options parameter
9522 and use it.
9523 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9524 (backtrace_command_1): Add frame_print_options and
9525 backtrace_cmd_options parameters and use them.
9526 (make_backtrace_options_def_group): New.
9527 (backtrace_command): Process command options with
9528 gdb::option::process_options.
9529 (backtrace_command_completer): New.
9530 (_initialize_stack): Extend "backtrace"'s help to mention
9531 supported options. Install completer for "backtrace".
9532 Install some settings commands with add_setshow_cmds_for_options.
9533
2daf894e
PA		 95342019-06-13 Pedro Alves <palves@redhat.com>
9535
9536 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9537 and that "set/show print raw frame-arguments" are now deprecated.
9538
9539 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9540 command.
9541 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9542 * stack.c (_initialize_stack): Install "set/show print
9543 raw-frame-arguments", and deprecate "set/show print raw
9544 frame-arguments".
9545 * valprint.c (_initialize_valprint): Deprecate "set/show print
9546 raw".
9547
e6ed716c
PA		 95482019-06-13 Pedro Alves <palves@redhat.com>
9549
9550 * compile/compile.c (struct compile_options): New.
9551 (compile_flag_option_def, compile_command_option_defs)
9552 (make_compile_options_def_group): New.
9553 (compile_file_command): Handle options with
9554 gdb::option::process_options.
9555 (compile_file_command_completer): New function.
9556 (compile_code_command): Handle options with
9557 gdb::option::process_options.
9558 (compile_code_command_completer): New function.
9559 (_initialize_compiler): Install completers for "compile code" and
9560 "compile file". Mention available options in "compile code" and
9561 "compile code"'s help.
9562 * completer.c (advance_to_completion_word): New, factored out from
9563 ...
9564 (advance_to_expression_complete_word_point): ... this.
9565 (advance_to_filename_complete_word_point): New.
9566 * completer.h (advance_to_filename_complete_word_point): New
9567 declaration.
9568
7d8062de
PA		 95692019-06-13 Pedro Alves <palves@redhat.com>
9570
9571 * compile/compile.c: Include "cli/cli-option.h".
9572 (compile_print_value): Scope data pointer is now a
9573 value_print_options pointer; adjust.
9574 (compile_print_command): Process options. Scope data pointer is
9575 now a value_print_options pointer; adjust.
9576 (_initialize_compile): Update "compile print"'s help to include
9577 supported options. Install a completer for "compile print".
9578 * cp-valprint.c (show_vtblprint, show_objectprint)
9579 (show_static_field_print): Delete.
9580 (_initialize_cp_valprint): Don't install "set print
9581 static-members", "set print vtbl", "set print object" here.
9582 * printcmd.c: Include "cli/cli-option.h" and
9583 "common/gdb_optional.h".
9584 (print_command_parse_format): Rework to fill in a
9585 value_print_options instead of a format_data.
9586 (print_value): Change parameter type from format_data pointer to
9587 value_print_options reference. Adjust.
9588 (print_command_1): Process options. Adjust to pass down a
9589 value_print_options.
9590 (print_command_completer): New.
9591 (_initialize_printcmd): Install print_command_completer as
9592 handle_brkchars completer for the "print" command. Update
9593 "print"'s help to include supported options.
9594 * valprint.c: Include "cli/cli-option.h".
9595 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9596 here from cp-valprint.c.
9597 (boolean_option_def, uinteger_option_def)
9598 (value_print_option_defs, make_value_print_options_def_group):
9599 New. Use gdb::option::add_setshow_cmds_for_options to install
9600 "set print elements", "set print null-stop", "set print repeats",
9601 "set print pretty", "set print union", "set print array", "set
9602 print address", "set print symbol", "set print array-indexes".
9603 * valprint.h: Include <string> and "cli/cli-option.h".
9604 (make_value_print_options_def_group): Declare.
9605 (print_value): Change parameter type from format_data pointer to
9606 value_print_options reference.
9607 (print_command_completer): Declare.
9608
9d0faba9
PA		 96092019-06-13 Pedro Alves <palves@redhat.com>
9610
9611 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9612 (COMMON_SFILES): Add maint-test-settings.c.
9613 * cli/cli-decode.c (boolean_enums): New global, factored out from
9614 ...
9615 (add_setshow_boolean_cmd): ... here.
9616 * cli/cli-decode.h (boolean_enums): Declare.
9617 * cli/cli-option.c: New file.
9618 * cli/cli-option.h: New file.
9619 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9620 factored out from ...
9621 (parse_cli_boolean_value(const char *)): ... this.
9622 (is_unlimited_literal): Change parameter type to pointer to
9623 pointer. Adjust and advance ARG pointer.
9624 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9625 (parse_cli_var_enum): New, factored out from ...
9626 (do_set_command): ... this. Adjust.
9627 * cli/cli-setshow.h (parse_cli_boolean_value)
9628 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9629 (parse_cli_var_enum): Declare.
9630 * cli/cli-utils.c: Include "cli/cli-option.h".
9631 (get_ulongest): New.
9632 * cli/cli-utils.h (get_ulongest): Declare.
9633 (check_for_argument): New overloads.
9634 * maint-test-options.c: New file.
9635
2c722807
PA		 96362019-06-13 Pedro Alves <palves@redhat.com>
9637
9638 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9639 parse a range if "-" is at the end of the string.
9640
dee7b4c8
PA		 96412019-06-13 Pedro Alves <palves@redhat.com>
9642
9643 * cli/cli-setshow.c (parse_auto_binary_operation)
9644 (parse_cli_boolean_value): Don't allow "o".
9645
dca0f6c0
PA		 96462019-06-13 Pedro Alves <palves@redhat.com>
9647
9648 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9649 * NEWS: Mention maint test-settings KIND.
9650 * maint-test-settings.c: New file.
9651
597bf39d
PA		 96522019-06-13 Pedro Alves <palves@redhat.com>
9653
9654 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9655 completer.
9656 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9657 "set" completers.
9658
48c410fb
PA		 96592019-06-13 Pedro Alves <palves@redhat.com>
9660
9661 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9662 after item.
9663
93bcb043
PA		 96642019-06-13 Pedro Alves <palves@redhat.com>
9665
9666 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9667
cbba3ecd
PA		 96682019-06-13 Pedro Alves <palves@redhat.com>
9669
9670 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9671 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9672 call.
9673 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9674 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9675 calls.
9676 (check_for_argument): Skip spaces after argument.
9677
b9a3f842
PA		 96782019-06-13 Pedro Alves <palves@redhat.com>
9679
9680 * thread.c (thread_apply_command): Adjust TID parsing.
9681 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9682 detected before end of string.
9683 (tid_is_in_list): Error out if LIST is invalid.
9684
3844e605
PA		 96852019-06-13 Pedro Alves <palves@redhat.com>
9686
9687 * completer.c (complete_line_internal_1): Rewind completion word
9688 point.
9689 (completion_tracker::advance_custom_word_point_by): Change
9690 parameter type to int.
9691 * completer.h (completion_tracker::advance_custom_word_point_by):
9692 Likewise.
9693
00b56dbe
PA		 96942019-06-13 Pedro Alves <palves@redhat.com>
9695
9696 * completer.c (advance_to_completion_word): Handle delimiters.
9697
d106773e
PA		 96982019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9699
9700 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9701
08f10e02
TT		 97022019-06-11 Tom Tromey <tom@tromey.com>
9703
9704 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9705 (xmalloc_failed): Move to alloc.c.
9706 * alloc.c: New file.
9707 * Makefile.in (COMMON_SFILES): Add alloc.c.
9708
1c7fe951
TT		 97092019-06-11 Tom Tromey <tom@tromey.com>
9710
9711 * nat/linux-waitpid.c: Don't include server.h.
9712 (linux_debug): Remove.
9713 (my_waitpid): Update.
9714
89549d7f
TT		 97152019-06-11 Tom Tromey <tromey@adacore.com>
9716
9717 * infcall.c (_initialize_infcall): Remove trailing newline from
9718 help.
9719 * user-regs.c (_initialize_user_regs): Remove trailing newline
9720 from help.
9721 * typeprint.c (_initialize_typeprint): Remove trailing newline
9722 from help.
9723 * reverse.c (_initialize_reverse): Remove trailing newlines from
9724 help.
9725 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9726 from help.
9727 * language.c (add_set_language_command): Remove trailing newline
9728 from help.
9729 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9730 help.
9731 * disasm.c (_initialize_disasm): Remove trailing newline from
9732 help.
9733 * top.c (init_main): Remove trailing newline from help.
9734 * interps.c (_initialize_interpreter): Remove trailing newline
9735 from help.
9736 * btrace.c (_initialize_btrace): Remove trailing newlines from
9737 help.
9738 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9739 from help.
9740 * python/python.c (_initialize_python): Remove trailing newline
9741 from help.
9742 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9743 help.
9744 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9745 from help. Reformat some text.
9746 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9747 from help.
9748 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9749 newline from help.
9750
86108c13
TT		 97512019-06-11 Tom Tromey <tromey@adacore.com>
9752
9753 * darwin-nat.c (darwin_decode_exception_message)
9754 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9755
a7067863
AB		 97562019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9757
9758 * valops.c (value_slice): Check for not allocated or not
9759 associated values.
9760
9ab08412
TV		 97612019-06-10 Tom de Vries <tdevries@suse.de>
9762
9763 PR gdb/24618
9764 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9765 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9766 invalid.
9767
f19e22e9
TV		 97682019-06-10 Tom de Vries <tdevries@suse.de>
9769
9770 PR gdb/24611
9771 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9772 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9773
e99f9db0
TV		 97742019-06-10 Tom de Vries <tdevries@suse.de>
9775
9776 PR symtab/24545
9777 * symtab.c (struct demangled_name_entry): Add language field.
9778 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9779 static minimal symbol". Set and use language field.
9780
9bf7038b
TT		 97812019-06-10 Tom Tromey <tromey@adacore.com>
9782
9783 * ada-lang.c (_initialize_ada_language): Update help text.
9784
422186a9
TT		 97852019-06-10 Tom Tromey <tromey@adacore.com>
9786
9787 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9788 with a newline.
9789 * guile/guile.c (handle_boot_error): Don't end warning with a
9790 newline.
9791 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9792 warning with a newline.
9793 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9794 newline.
9795 (s12z_frame_cache): Likewise.
9796 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9797 a newline.
9798 * solib-svr4.c (disable_probes_interface): Don't end warning with
9799 a newline.
9800 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9801 newline.
9802 * python/python.c (do_finish_initialization): Don't end warning
9803 with a newline.
9804
25ce02ee
TT		 98052019-06-10 Tom Tromey <tom@tromey.com>
9806
9807 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9808 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9809 gdbpy_enter.
9810
caa429d8
TT		 98112019-06-10 Tom Tromey <tromey@adacore.com>
9812
9813 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9814 data.
9815 (elf_new_init): Don't call stabsread_new_init.
9816 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9817 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9818 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9819
81873cc8
TV		 98202019-06-10 Tom de Vries <tdevries@suse.de>
9821
9822 PR symtab/16264
9823 PR symtab/24517
9824 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9825
4fa0265e
РИ		 98262019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9827
9828 * source.c (find_and_open_source): Also rewrite relative file
9829 names.
9830
1a3da2cd
AB		 98312019-04-26 Amos Bird <amosbird@gmail.com>
9832
9833 * annotate.c (annotate_thread_exited): Add "thread-exited"
9834 annotation.
9835
3847a7bf
TT		 98362019-06-06 Tom Tromey <tromey@adacore.com>
9837
9838 * maint.h (class scoped_command_stats): Use
9839 DISABLE_COPY_AND_ASSIGN.
9840 <print_time>: New method.
9841 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9842 print_time.
9843 (scoped_command_stats::print_time): New method.
9844
312617a3
AB		 98452019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9846
9847 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9848 instructions of lengths 6 or 8 bytes.
9849
b02f78f9
PA		 98502019-06-04 Pedro Alves <palves@redhat.com>
9851
9852 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9853
9854 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9855 * breakpoint.c (condition_completer): Likewise.
9856 * cli/cli-dump.c (scan_expression): Likewise.
9857 * common/filestuff.c (mkdir_recursive): Likewise.
9858 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9859 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9860 (gdb_abspath): Likewise.
9861 * compile/compile-cplus-types.c
9862 (compile_cplus_instance::decl_name): Likewise.
9863 * completer.c (complete_explicit_location):
9864 (signal_completer, reg_or_group_completer_1): Likewise.
9865 * cp-support.c (cp_remove_params_if_any): Likewise.
9866 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9867 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9868 * infcmd.c (strip_bg_char): Likewise.
9869 * linespec.c (copy_token_string): Likewise.
9870 * mi/mi-main.c (output_cores): Likewise.
9871 * psymtab.c (psymtab_search_name):
9872 * symfile.c (test_set_ext_lang_command): Likewise.
9873 * target.c (target_fileio_read_stralloc): Likewise.
9874 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9875 * value.c (complete_internalvar): Likewise.
9876
e1f2e1a2
CB		 98772019-06-04 Christian Biesinger <cbiesinger@google.com>
9878
9879 Add objfile property to gdb.Type.
d3238f7d
PA		 9880 * NEWS: Mention Python API addition.
9881 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9882
e664d728
PW		 98832019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9884
9885 * NEWS: Mention the new set|show style [title|highlight].
9886 Mention changes to "show style", "help" and "apropos".
9887
66d8c862
PW		 98882019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9889
9890 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9891 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9892 instead of print_help_for_command.
9893 (print_doc_of_command): New function.
9894 (help_list): Add 'apropos -v word' suggestion.
9895 (print_help_for_command): Style the command name using title style.
9896 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9897 (_initialize_cli_cmds): Describe -v in apropos_command help.
9898
9303eb2f
PW		 98992019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9900
9901 * cli/cli-style.h (cli_style_option): Add name in constructor,
9902 add m_name class member, add constructor with intensity,
9903 add name class function.
9904 (cli_style_option::add_setshow_commands): Remove name argument.
9905 (highlight_style, title_style): New styles.
9906 * cli/cli-style.c (do_show): New function that shows a style
9907 characteristic styling the style name with itself.
9908 (set_style_name): New function.
9909 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9910 Update all callers according to the changes in cli/cli-style.h.
9911 * utils.h (fputs_highlighted): New function.
9912 * utils.c (fputs_highlighted): Likewise.
9913
e2c52041
PW		 99142019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9915
9916 * NEWS: Mention new pipe command and new convenience variables.
9917
947d3946
PW		 99182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9919
9920 * cli/cli-cmds.c (pipe_command): New function.
9921 (_initialize_cli_cmds): Call add_com for pipe_command.
9922 Define | as an alias for pipe.
9923 (exit_status_set_internal_vars): New function.
9924 (shell_escape): Call exit_status_set_internal_vars.
9925 cli/cli-decode.c (find_command_name_length): Recognize | as
9926 a single character command.
9927
b8fd0918
PW		 99282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9929
9930 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9931 top.c (execute_command_to_ui_file): New function, mostly a copy
9932 of execute_command_to_string.
9933 (execute_command_to_string): Implement by calling
9934 execute_command_to_ui_file.
9935
68bb5386
PW		 99362019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9937
9938 * top.h (saved_command_line): Remove declaration.
9939 * top.c (previous_saved_command_line, previous_repeat_arguments):
9940 New variables.
9941 (saved_command_line): Make static, define together with other
9942 'repeat variables'.
9943 (dont_repeat): Clear repeat_arguments.
9944 (repeat_previous, get_saved_command_line, save_command_line):
9945 New functions.
9946 (gdb_init): Initialize saved_command_line
9947 and previous_saved_command_line.
9948 * main.c (captured_main_1): Remove saved_command_line initialization.
9949 * event-top.c (handle_line_of_input): Update to use
9950 the new 'repeat' related functions instead of direct access to
9951 saved_command_line.
9952 * command.h (repeat_previous, get_saved_command_line,
9953 save_command_line): New declarations.
9954 (dont_repeat): Add comment.
9955
bfcdb852
TT		 99562019-05-30 Tom Tromey <tromey@adacore.com>
9957
9958 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9959 Fix comment.
9960 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9961
0ef209f2
JV		 99622019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9963
9964 PR cli/24587
9965 * completer.c (complete): Initialize variable word.
9966
955b06fa
SDJ		 99672019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9968
9969 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9970 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9971 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9972 'body' is NULL to the outter 'if', protecting the '!is_define'
9973 situation as well.
9974
fa9c3fa0
TT		 99752019-05-29 Tom Tromey <tromey@adacore.com>
9976
9977 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9978 (dwarf_unknown): New function.
9979 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9980 (dwarf_type_encoding_name): Use dwarf_unknown.
9981
4330d61d
TT		 99822019-05-29 Tom Tromey <tromey@adacore.com>
9983
9984 PR c++/20020:
9985 * cp-valprint.c (cp_print_value_fields): Call
9986 cp_print_static_field inside "try".
9987
33a6bc35
TT		 99882019-05-29 Tom Tromey <tromey@adacore.com>
9989
9990 * inflow.c (struct terminal_info): Add default operator=.
9991 * configure: Rebuild.
9992 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9993 -Wdeprecated-copy-dtor, -Wredundant-move.
9994
000439d5
TT		 99952019-05-29 Tom Tromey <tromey@adacore.com>
9996
9997 * NEWS: Add entry.
9998 * infcmd.c (print_return_value_1): Handle finish_print
9999 option.
10000 (show_print_finish): New function.
10001 (_initialize_infcmd): Add "set/show print finish" commands.
10002 * valprint.c (user_print_options): Initialize new member.
10003 * valprint.h (struct value_print_options) <finish_print>: New
10004 member.
10005
c0e70c62
TT		 100062019-05-28 Tom Tromey <tromey@adacore.com>
10007
10008 * ada-lang.c (ada_remove_Xbn_suffix)
10009 (find_old_style_renaming_symbol)
10010 (parse_old_style_renaming): Remove.
10011 (ada_find_renaming_symbol): Don't call
10012 find_old_style_renaming_symbol.
10013 (ada_is_renaming_symbol): Rename from
10014 ada_find_renaming_symbol. Remove "block" parameter. Return
10015 bool. Now static.
10016 (ada_read_var_value): Update and simplify.
10017 * ada-exp.y (write_var_or_type): Remove old code.
10018
766f8836
AH		 100192019-05-28 Alan Hayward <alan.hayward@arm.com>
10020
68255adc 10021 PR gdb/25010
766f8836
AH		 10022 * event-top.c: Remove include comment.
10023 * inflow.c (class scoped_ignore_sigttou): Move from here...
10024 * inflow.h (class scoped_ignore_sigttou): ...to here.
10025 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10026 * top.c: Remove include comment.
10027
eb41253a
TT		 100282019-05-27 Tom Tromey <tom@tromey.com>
10029
10030 * NEWS: Fix typo.
10031
4ca51187
TT		 100322019-05-22 Tom Tromey <tromey@adacore.com>
10033
10034 * target.c (target_follow_exec): Constify parameter.
10035 * target-delegates.c: Rebuild.
10036 * remote.c (remote_target::follow_exec): Constify parameter.
10037 * infrun.c (follow_exec): Constify parameter.
10038 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10039 (target_follow_exec): Likewise.
10040
8fca4da0
AH		 100412019-05-22 Alan Hayward <alan.hayward@arm.com>
10042
10043 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10044 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10045
b7060614
AH		 100462019-05-22 Alan Hayward <alan.hayward@arm.com>
10047
10048 * NEWS: Add debugredirect and testsuite sections.
10049
0a5954bd
SC		 100502019-05-22 Simon Cook <simon.cook@embecosm.com>
10051
10052 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10053 target descriptions using exclusively floating point register name
10054 aliases.
10055
dc42e902
AB		 100562019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10057
10058 PR gdb/18644:
10059 * f-lang.c (build_fortran_types): Handle the case where
10060 gdbarch_floatformat_for_type returns a nullptr.
10061
fb7806c7
TV		 100622019-05-21 Tom de Vries <tdevries@suse.de>
10063
10064 PR cli/24587
10065 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10066
34d11c68
AB		 100672019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10068
10069 PR gdb/18644:
10070 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10071 16-byte floats.
10072 * i386-tdep.c (i386_floatformat_for_type): Use
10073 floatformats_ia64_quad for the 16-byte floating point component
10074 within a fortran 32-byte complex number.
10075
122cf0f2
AB		 100762019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10077
10078 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10079 delete default constructor.
10080 (find_partial_die): Update to return const struct.
10081 (partial_die_parent_scope): Move variable declaration into scope
10082 of its use and change its type to auto.
10083 (guess_partial_die_structure_name): Likewise.
10084 (partial_die_info::fixup): Likewise.
10085
33d0e35a
TT		 100862019-05-17 Tom Tromey <tromey@adacore.com>
10087
10088 * source.c (find_and_open_source): Remove cast.
10089
a45575b0
TT		 100902019-05-17 Tom Tromey <tromey@adacore.com>
10091
10092 * annotate.c (annotate_source): Make "filename" const.
10093 * annotate.h (annotate_source): Use const.
10094
81f47ac2
AH		 100952019-05-17 Alan Hayward <alan.hayward@arm.com>
10096
10097 * disasm.c (set_disassembler_options): Send errors to stderr.
10098
ca1285d1
AH		 100992019-05-17 Alan Hayward <alan.hayward@arm.com>
10100
10101 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10102 (cli_interp_base::set_logging): Check debug_redirect.
10103 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10104 * cli/cli-logging.c (debug_redirect): Add static variable.
10105 (pop_output_files): Add default param.
10106 (handle_redirections): Print debug setting.
10107 (show_logging_command): Likewise.
10108 (_initialize_cli_logging): Add debugredirect command.
10109 * interps.c (current_interp_set_logging): Add debug_redirect
10110 parameter.
10111 * interps.h (set_logging): Add debug_redirect parameter.
10112 (current_interp_set_logging): Likewise.
10113 * mi/mi-common.h: Likewise.
10114 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10115
101162019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 10117 Tom Tromey <tromey@adacore.com>
10118
10119 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10120 directly.
10121 * cli/cli-interp.h (make_logging_output): Remove declaration.
10122 * cli/cli-logging.c (make_logging_output): Remove function.
10123 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10124 directly.
10125 * ui-file.c (tee_file::tee_file): Remove bools.
10126 (tee_file::~tee_file): Remove deletes.
10127 * ui-file.h (tee_file): Remove bools.
10128
26648588
JV		 101292019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10130
10131 * mi/mi-cmds.h (mi_cmd_complete): New function.
10132 * mi/mi-main.c (mi_cmd_complete): Likewise.
10133 * mi/mi-cmds.c: Define new MI command -complete.
10134 * NEWS: Mention new -complete command.
10135
6e035501
JV		 101362019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10137
10138 * completer.h (complete): New function.
10139 * completer.c (complete): Likewise.
10140 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10141 function defined in completer.h.
10142
7d0e2ece
JV		 101432019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10144
e79be6e5 10145 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10146
fb816e8b
TV		 101472019-05-17 Tom de Vries <tdevries@suse.de>
10148
10149 PR gdb/24094
10150 * dwarf2read.c (struct cu_partial_die_info): New struct.
10151 (find_partial_die): Return cu_partial_die_info.
10152 (partial_die_parent_scope, guess_partial_die_structure_name)
10153 (partial_die_info::fixup): Handle new return type of find_partial_die.
10154
677052f2
SDJ		 101552019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10156
a1726c38 10157 PR breakpoints/24541
677052f2
SDJ		 10158 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10159 "std::string", simplifying the algorithm.
10160
f3da9116
SDJ		 101612019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10162
10163 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10164 (stap_static_probe_ops::get_probes): Likewise.
10165
f1bb75ab
SDJ		 101662019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10167
10168 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10169 '-')" and "else if".
10170 (stap_parse_single_operand): Join checks for
10171 "gdbarch_stap_parse_special_token_p" and
10172 "gdbarch_stap_parse_special_token" in the same "if" statement.
10173 Invert check when verifying for operation on register
10174 displacement.
10175
3ca58cde
SDJ		 101762019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10177
10178 * stap-probe.c (stap_get_opcode): Update comment.
10179 (stap_get_expected_argument_type): Likewise.
10180 (handle_stap_probe): Likewise.
10181
af2d9bee
SDJ		 101822019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10183
10184 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10185 return type to 'bool'. Adjust comment. Use 'bool' when
10186 appropriate.
10187 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10188 * stap-probe.c (stap_parse_argument_1): Likewise.
10189 (stap_is_operator): Likewise.
10190 (stap_is_generic_prefix): Likewise.
10191 (stap_is_register_prefix): Likewise.
10192 (stap_is_register_indirection_prefix): Likewise.
10193 (stap_is_integer_prefix): Likewise.
10194 (stap_generic_check_suffix): Likewise.
10195 (stap_check_integer_suffix): Likewise.
10196 (stap_check_register_suffix): Likewise.
10197 (stap_check_register_indirection_suffix): Likewise.
10198 (stap_parse_register_operand): Likewise.
10199 (stap_parse_single_operand): Likewise.
10200 (stap_parse_argument_1): Likewise.
10201 (stap_probe::get_argument_count): Likewise.
10202 (stap_is_operator): Likewise.
10203
61c9c421
TT		 102042019-05-16 Tom Tromey <tromey@adacore.com>
10205
10206 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10207 keyword to foreach.
10208
9ddc1af1
SM		 102092019-05-15 Simon Marchi <simon.marchi@efficios.com>
10210
10211 * linux-thread-db.c (try_thread_db_load_1): Change return type
10212 to bool.
10213 (try_thread_db_load): Likewise.
10214 (try_thread_db_load_from_pdir_1): Likewise.
10215 (try_thread_db_load_from_pdir): Likewise.
10216 (try_thread_db_load_from_sdir): Likewise.
10217 (try_thread_db_load_from_dir): Likewise.
10218 (thread_db_load_search): Likewise.
10219 (has_libpthread): Likewise.
10220 (thread_db_load): Likewise.
10221
7bede828
SDJ		 102222019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10223
10224 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10225 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10226 NULL, and complain/return if that's the case.
10227
c5358db4
JD		 102282019-05-15 John Darrington <john@darrington.wattle.id.au>
10229
10230 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10231 (advance, posn, abstract_read_memory): New functions.
10232 [struct mem_read_abstraction]: New struct.
10233 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10234
c408a94f
TT		 102352019-05-14 Tom Tromey <tromey@adacore.com>
10236
10237 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10238 value is not lval_memory.
10239
e7bd7fba
TT		 102402019-05-14 Tom Tromey <tromey@adacore.com>
10241
10242 * solib.c (info_sharedlibrary_command): Style the file name.
10243
a6d0f249
AH		 102442019-05-14 Alan Hayward <alan.hayward@arm.com>
10245
10246 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10247 (aarch64_vnv_type): Likewise.
10248 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10249 * common/tdesc.c: Likewise.
10250 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10251 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10252 * features/aarch64-fpu.xml: Add ieee half view.
10253 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10254 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10255 * gdbtypes.h (struct builtin_type): Likewise.
10256 (struct objfile_type): Likewise.
10257
66b8bb74
SM		 102582019-05-12 Paul Naert <paul.naert@polymtl.ca>
10259
10260 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10261 typo.
10262 * location.h (string_to_event_location): Likewise.
10263
21c219fd
JB		 102642019-05-11 Joel Brobecker <brobecker@adacore.com>
10265
10266 GDB 8.3 released.
10267
13674803
SM		 102682019-05-10 Simon Marchi <simon.marchi@efficios.com>
10269
10270 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10271 New variable declaration.
10272 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10273 New variable.
10274 (print_one_breakpoint): Use ui_out::test_flags and new global
10275 variable to compute use_fixed_output.
10276 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10277 Remove.
10278 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10279 (mi_multi_location_breakpoint_output_fixed): Remove.
10280 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10281 new variable.
10282 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10283 fix_multi_location_breakpoint_output flag if version >= 3.
10284 * ui-out.h (enum ui_out_flag)
10285 <fix_multi_location_breakpoint_output>: New enumerator.
10286
a9eac7f9
SM		 102872019-05-10 Simon Marchi <simon.marchi@efficios.com>
10288
10289 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10290
71bed2db
TT		 102912019-05-10 Tom Tromey <tromey@adacore.com>
10292
10293 * ada-lang.c (catch_ada_completer): New function.
10294 (_initialize_ada_language): Use it.
10295
24c54127
TT		 102962019-05-10 Tom Tromey <tromey@adacore.com>
10297
10298 * thread.c (print_thread_info): Make "requested_threads" const.
10299 * gdbthread.h (print_thread_info): Make "requested_threads"
10300 const.
10301 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10302 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10303
7a102139
TT		 103042019-05-08 Tom Tromey <tom@tromey.com>
10305
10306 * gdbtypes.c (objfile_type_data): Change type.
10307 (objfile_type, _initialize_gdbtypes): Update.
10308
924d79e2
TT		 103092019-05-08 Tom Tromey <tom@tromey.com>
10310
10311 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10312 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10313 (_initialize_dwarf2_frame): Update.
10314
4c58e337
TT		 103152019-05-08 Tom Tromey <tom@tromey.com>
10316
10317 * objc-lang.c (objc_objfile_data): Change type.
10318 (find_methods): Update.
10319 (_initialize_objc_lang): Remove.
10320
d772d2ab
TT		 103212019-05-08 Tom Tromey <tom@tromey.com>
10322
10323 * stabsread.c (rs6000_builtin_type_data): Change type.
10324 (rs6000_builtin_type, _initialize_stabsread): Update.
10325
d11d83f4
TT		 103262019-05-08 Tom Tromey <tom@tromey.com>
10327
10328 * mips-tdep.c (mips_pdr_data): Remove.
10329 (_initialize_mips_tdep): Update.
10330
9a73f0ad
TT		 103312019-05-08 Tom Tromey <tom@tromey.com>
10332
10333 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10334 (hppa_init_objfile_priv_data, read_unwind_info)
10335 (find_unwind_entry, _initialize_hppa_tdep): Update.
10336
8127a2fa
TT		 103372019-05-08 Tom Tromey <tom@tromey.com>
10338
10339 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10340 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10341 on obstack.
10342 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10343
91d3055d
TT		 103442019-05-08 Tom Tromey <tom@tromey.com>
10345
10346 * mdebugread.c (basic_type_data): Change type.
10347 (basic_type, _initialize_mdebugread): Update.
10348
31930bd3
TT		 103492019-05-08 Tom Tromey <tom@tromey.com>
10350
10351 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10352
bdb3ed9e
TT		 103532019-05-08 Tom Tromey <tom@tromey.com>
10354
10355 * nto-tdep.c (nto_inferior_data_reg): Change type.
10356 (nto_inferior_data): Update.
10357 (nto_inferior_data_cleanup, nto_new_inferior_data)
10358 (_initialize_nto_tdep): Remove.
10359 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10360
f37b313d
TT		 103612019-05-08 Tom Tromey <tom@tromey.com>
10362
10363 * ada-lang.c (struct ada_inferior_data): Add initializers.
10364 (ada_inferior_data): Change type.
10365 (ada_inferior_data_cleanup): Remove.
10366 (get_ada_inferior_data, ada_inferior_exit)
10367 (struct ada_pspace_data): Add initializers, destructor.
10368 (ada_pspace_data_handle): Change type.
10369 (get_ada_pspace_data): Update.
10370 (ada_pspace_data_cleanup): Remove.
10371
24699405
TT		 103722019-05-08 Tom Tromey <tom@tromey.com>
10373
10374 * coffread.c (struct coff_symfile_info): Add initializers.
10375 (coff_objfile_data_key): Move lower. Change type.
10376 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10377 Update.
10378 (coff_free_info): Remove.
10379
d4e05d2f
TT		 103802019-05-08 Tom Tromey <tom@tromey.com>
10381
10382 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10383 (fbsd_pspace_data_handle): Move lower. Change type.
10384 (get_fbsd_pspace_data): Update.
10385 (fbsd_pspace_data_cleanup): Remove.
10386 (_initialize_fbsd_tdep): Update.
10387
14ef6690
TT		 103882019-05-08 Tom Tromey <tom@tromey.com>
10389
10390 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10391 (get_ada_tasks_pspace_data): Update.
10392 (ada_tasks_pspace_data_cleanup): Remove.
10393 (_initialize_tasks): Update.
10394 (ada_tasks_inferior_data_handle): Change type.
10395 (get_ada_tasks_inferior_data): Update.
10396 (ada_tasks_inferior_data_cleanup): Remove.
10397 (struct ada_tasks_pspace_data): Add initializers.
10398
814cf43a
TT		 103992019-05-08 Tom Tromey <tom@tromey.com>
10400
10401 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10402 * symfile-debug.c (debug_sym_get_probes): Change type.
10403 * stap-probe.c (handle_stap_probe):
10404 (stap_static_probe_ops::get_probes): Change type.
10405 * probe.h (class static_probe_ops) <get_probes>: Change type.
10406 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10407 (parse_probes_in_pspace): Update.
10408 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10409 Update.
10410 (any_static_probe_ops::get_probes): Change type.
10411 * elfread.c (elfread_data): New typedef.
10412 (probe_key): Change type.
10413 (elf_get_probes): Likewise. Update.
10414 (probe_key_free): Remove.
10415 (_initialize_elfread): Update.
10416 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10417 Change type.
10418 (dtrace_process_dof_probe, dtrace_process_dof)
10419 (dtrace_static_probe_ops::get_probe): Change type.
10420
02dc647e
TT		 104212019-05-08 Tom Tromey <tom@tromey.com>
10422
10423 * xcoffread.c (struct xcoff_symfile_info): Rename from
10424 coff_symfile_info. Add initializers.
10425 (xcoff_objfile_data_key): Move lower. Change type.
10426 (XCOFF_DATA): Rewrite.
10427 (xcoff_free_info): Remove.
10428 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10429 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10430 (xcoff_initial_scan): Update.
10431
09232438
TT		 104322019-05-08 Tom Tromey <tom@tromey.com>
10433
10434 * solib-svr4.c (struct svr4_info): Add initializers and
10435 destructor.
10436 <probes_table>: Now an htab_up.
10437 (solib_svr4_pspace_data): Change type.
10438 (free_probes_table): Simplify.
10439 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10440 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10441 (probes_table_remove_objfile_probes, register_solib_event_probe)
10442 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10443 (_initialize_svr4_solib): Update.
10444
7b4a314f
TT		 104452019-05-08 Tom Tromey <tom@tromey.com>
10446
10447 * remote.c (remote_pspace_data): Change type.
10448 (remote_pspace_data_cleanup): Remove.
10449 (get_remote_exec_file, set_pspace_remote_exec_file)
10450 (_initialize_remote): Update.
10451
51d3063a
TT		 104522019-05-08 Tom Tromey <tom@tromey.com>
10453
10454 * breakpoint.c (breakpoint_objfile_key): Change type.
10455 (get_breakpoint_objfile_data): Update.
10456 (free_breakpoint_objfile_data): Remove.
10457 (_initialize_breakpoint): Update.
10458
89fb8848
TT		 104592019-05-08 Tom Tromey <tom@tromey.com>
10460
10461 * linux-tdep.c (struct linux_info): Add initializers.
10462 (linux_inferior_data): Move. Change type.
10463 (invalidate_linux_cache_inf): Update.
10464 (linux_inferior_data_cleanup): Remove.
10465 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10466
e9b89e2d
TT		 104672019-05-08 Tom Tromey <tom@tromey.com>
10468
10469 * auxv.c (auxv_inferior_data): Move. Change type.
10470 (auxv_inferior_data_cleanup): Remove.
10471 (invalidate_auxv_cache_inf): Rewrite.
10472 (get_auxv_inferior_data, _initialize_auxv): Update.
10473
8c42777c
TT		 104742019-05-08 Tom Tromey <tom@tromey.com>
10475
10476 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10477 (symfile_debug_objfile_data_key): Change type.
10478 (symfile_debug_installed, debug_qf_has_symbols)
10479 (debug_qf_find_last_source_symtab)
10480 (debug_qf_forget_cached_source_info)
10481 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10482 (debug_qf_print_stats, debug_qf_dump)
10483 (debug_qf_expand_symtabs_for_function)
10484 (debug_qf_expand_all_symtabs)
10485 (debug_qf_expand_symtabs_with_fullname)
10486 (debug_qf_map_matching_symbols)
10487 (debug_qf_expand_symtabs_matching)
10488 (debug_qf_find_pc_sect_compunit_symtab)
10489 (debug_qf_map_symbol_filenames)
10490 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10491 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10492 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10493 (debug_sym_read_linetable, debug_sym_relocate): Update.
10494 (symfile_debug_free_objfile): Remove.
10495 (install_symfile_debug_logging, _initialize_symfile_debug):
10496 Update.
10497
5bfd760d
TT		 104982019-05-08 Tom Tromey <tom@tromey.com>
10499
10500 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10501 allocate_on_obstack.
10502 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10503 (get_dwarf2_per_objfile): Update.
10504 (set_dwarf2_per_objfile): Remove.
10505 (dwarf2_has_info, dwarf2_get_section_info): Update.
10506 (dwarf2_free_objfile): Remove.
10507 (_initialize_dwarf2_read): Update.
10508
e85e19b4
TT		 105092019-05-08 Tom Tromey <tom@tromey.com>
10510
10511 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10512 initializers.
10513 <unsupported_script_warning_printed,
10514 script_not_found_warning_printed>: Now bool.
10515 (auto_load_pspace_data): Change type.
10516 (~auto_load_pspace_info): Rename from
10517 auto_load_pspace_data_cleanup.
10518 (get_auto_load_pspace_data, init_loaded_scripts_info)
10519 (clear_section_scripts, maybe_print_unsupported_script_warning)
10520 (maybe_print_script_not_found_warning, _initialize_auto_load):
10521 Update.
10522
f6aa7436
TT		 105232019-05-08 Tom Tromey <tom@tromey.com>
10524
10525 * objfiles.c (objfile_pspace_info): Add destructor and
10526 initializers.
10527 (objfiles_pspace_data): Change type.
10528 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10529 (get_objfile_pspace_data): Update.
10530 (objfiles_bfd_data): Change type.
10531 (get_objfile_bfd_data): Update.
10532 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10533
6ae614f6
TT		 105342019-05-08 Tom Tromey <tom@tromey.com>
10535
10536 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10537 Change type.
10538 (get_catch_syscall_inferior_data): Update.
10539 (catch_syscall_inferior_data_cleanup): Remove.
10540 (_initialize_break_catch_syscall): Update.
10541
6509b8eb
TT		 105422019-05-08 Tom Tromey <tom@tromey.com>
10543
10544 * inflow.c (struct terminal_info): Add destructor and
10545 initializers.
10546 (inflow_inferior_data): Change type.
10547 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10548 (get_inflow_inferior_data, inflow_inferior_exit)
10549 (swap_terminal_info, _initialize_inflow): Update.
10550
35632941
TT		 105512019-05-08 Tom Tromey <tom@tromey.com>
10552
10553 * target-dcache.c (target_dcache_cleanup): Remove.
10554 (target_dcache_aspace_key): Change type.
10555 (target_dcache_init_p, target_dcache_invalidate)
10556 (target_dcache_get, target_dcache_get_or_init)
10557 (_initialize_target_dcache): Update.
10558 * dcache.h (struct dcache_deleter): New.
10559
3017b94d
TT		 105602019-05-08 Tom Tromey <tom@tromey.com>
10561
10562 * symtab.c (struct symbol_cache): Add destructor and
10563 initializers.
10564 (symbol_cache_key): Move. Change type.
10565 (make_symbol_cache, free_symbol_cache): Remove.
10566 (get_symbol_cache): Update.
10567 (symbol_cache_cleanup): Remove.
10568 (ALL_PSPACES, symbol_cache_flush)
10569 (maintenance_print_symbol_cache)
10570 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10571 Update.
10572
a32ad8c5
TT		 105732019-05-08 Tom Tromey <tom@tromey.com>
10574
10575 * symtab.c (struct main_info): Add destructor and initializers.
10576 (main_progspace_key): Move. Change type.
10577 (get_main_info): Update.
10578 (main_info_cleanup): Remove.
10579 (_initialize_symtab): Update.
10580
5f6e90a0
TT		 105812019-05-08 Tom Tromey <tom@tromey.com>
10582
10583 * registry.h (DECLARE_REGISTRY): Define the _key class.
10584
1bd0c6e4
AB		 105852019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10586
10587 * NEWS: Merge two 'New commands' sections.
10588
2228ef77
XR		 105892019-05-08 Joel Brobecker <brobecker@adacore.com>
10590
10591 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10592 parameter and use Ada language definition instead.
10593 (ada_val_print_ptr): Remove unused language parameter.
10594 (ada_val_print_num): Remove language parameter and use Ada language
10595 definition instead.
10596 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10597 parameter.
10598 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10599 parameter and use Ada language definition instead.
10600 (ada_val_print_1): Update all ada_val_print_xxx calls.
10601 Remove language parameter.
10602 (ada_val_print): Update ada_val_print_1 call.
10603
60fcc1c3
TT		 106042019-05-08 Tom Tromey <tromey@adacore.com>
10605
10606 * remote.c (remote_hw_watchpoint_limit)
10607 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10608 Now static.
10609
ed2b7c17
TT		 106102019-05-08 Tom Tromey <tromey@adacore.com>
10611
10612 * maint.c (_initialize_maint_cmds): Move initialization code to
10613 remote.c.
10614 (watchdog, show_watchdog): Move to remote.c.
10615 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10616 "watchdog" static.
10617 (_initialize_remote): Move initialization code from maint.c.
10618 * defs.h (watchdog): Don't declare.
10619
b0be6c91
TT		 106202019-05-08 Tom Tromey <tromey@adacore.com>
10621
10622 * tui/tui-interp.c: Include main.h.
10623 * interps.c: Include main.h.
10624 * main.h (interpreter_p): Declare.
10625 * defs.h (interpreter_p): Don't declare.
10626
587ee17b
TT		 106272019-05-08 Tom Tromey <tromey@adacore.com>
10628
10629 * dwarf2loc.c: Include dwarf2read.h.
10630 * defs.h (read_unsigned_leb128): Don't declare.
10631 * dwarf2read.h (read_unsigned_leb128): Declare.
10632
ca1df239
TT		 106332019-05-08 Tom Tromey <tromey@adacore.com>
10634
10635 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10636 method.
10637
99f20f08
TT		 106382019-05-08 Tom Tromey <tromey@adacore.com>
10639
10640 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10641 when no wrap column is set.
10642
80e55b13
TT		 106432019-05-08 Tom Tromey <tromey@adacore.com>
10644
10645 * c-lang.c (c_get_string): Handle non-C-style arrays.
10646
9d3421af
TT		 106472019-05-08 Tom Tromey <tromey@adacore.com>
10648
10649 * typeprint.c (print_offset_data::update): Print the bit offset,
10650 not the number of bits remaining.
10651
844333e2
TT		 106522019-05-08 Tom Tromey <tromey@adacore.com>
10653
10654 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10655 padding at end of comment.
10656
988915ee
TT		 106572019-05-08 Tom Tromey <tromey@adacore.com>
10658
10659 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10660 Compare main types.
10661
26bfd823
TT		 106622019-05-06 Tom Tromey <tom@tromey.com>
10663
10664 * common/scoped_mmap.c: Include common-defs.h.
10665 * common/scoped_mmap.h: Don't include config.h.
10666
89055eaa
TT		 106672019-05-04 Tom Tromey <tom@tromey.com>
10668
10669 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10670 (struct aarch64_call_info): Add initializers.
10671 <si>: Now a std::vector.
10672 (pass_on_stack, aarch64_push_dummy_call): Update.
10673
5da01df5
TT		 106742019-05-04 Simon Marchi <simon.marchi@efficios.com>
10675 Tom Tromey <tom@tromey.com>
10676
10677 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10678 (ppc_threads): Now a std::vector. Now static.
10679 (hwdebug_find_thread_points_by_tid)
10680 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10681 Update.
10682
fbdf05a1
TT		 106832019-05-04 Tom Tromey <tom@tromey.com>
10684
10685 * arc-tdep.c (arc_tdesc_init): Return bool.
10686
06d16ec9
TT		 106872019-05-04 Tom Tromey <tom@tromey.com>
10688
10689 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10690 Use gdb_assert_not_reached.
10691
9c056022
TT		 106922019-05-04 Tom Tromey <tom@tromey.com>
10693
10694 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10695 "false".
10696
fa9c2a59
TT		 106972019-05-04 Tom Tromey <tom@tromey.com>
10698
10699 * arc-tdep.c (arc_tdesc_init): Use bool.
10700
e2eb806a
TT		 107012019-05-04 Tom Tromey <tom@tromey.com>
10702
10703 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10704
6fe87677
TT		 107052019-05-04 Tom Tromey <tom@tromey.com>
10706
10707 * cli/cli-cmds.c (valid_command_p): Return bool.
10708
7f008c9e
TT		 107092019-05-04 Tom Tromey <tom@tromey.com>
10710
10711 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10712 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10713
b6484282
RT		 107142019-05-04 Raul Tambre <raul@tambre.ee>
10715
10716 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10717 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10718 operator for comparison.
10719
af97b416
TT		 107202019-05-04 Tom Tromey <tom@tromey.com>
10721
10722 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10723 (lookup_partial_symbol, print_partial_symbols)
10724 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10725 (psymbol_compare): Update.
10726 (add_psymbol_to_bcache): Clear the entire psymbol.
10727 (maintenance_check_psymtabs): Update.
10728 * psympriv.h (struct partial_symbol): Don't derive from
10729 general_symbol_info.
10730 <obj_section, unrelocated_address, address,
10731 set_unrelocated_address>: Update.
10732 <ginfo>: New member.
10733 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10734 (debug_names::write_psymbols): Update.
10735
9d6d4be8
TV		 107362019-05-04 Tom de Vries <tdevries@suse.de>
10737
10738 * contrib/cc-with-tweaks.sh: Support -n arg.
10739
66452beb
PW		 107402019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10741
10742 * corelow.c (core_target::detach): Ensure frame cache and
10743 register caches are cleared.
10744 inferior.c (exit_inferior_1): Likewise.
10745
bde09ab7
TT		 107462019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10747 Tom Tromey <tom@tromey.com>
10748
10749 * dictionary.c (collate_pending_symbols_by_language): Remove
10750 "struct" from foreach.
10751 * symtab.c (lookup_global_symbol_from_objfile)
10752 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10753 foreach.
10754 * ser-tcp.c (net_open): Remove "struct" from foreach.
10755 * objfiles.c (objfile_relocate, objfile_rebase)
10756 (objfile_has_symbols): Remove "struct" from foreach.
10757 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10758 from foreach.
10759 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10760 foreach.
10761 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10762 "struct" from foreach.
10763 * ada-lang.c (create_excep_cond_exprs)
10764 (ada_exception_catchpoint_cond_string): Remove "struct" from
10765 foreach.
10766
222a8d25
TT		 107672019-05-03 Tom Tromey <tromey@adacore.com>
10768
10769 * ada-exp.y (convert_char_literal): Check suffix of each
10770 enumerator.
10771
fcd60b84
DP		 107722019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10773
10774 PR ada/21406:
10775 * ada-exp.y (yywrap): Don't define.
10776 * ada-lex.l (%option): Add noyywrap
10777 (yywrap): Remove.
10778
5f2459c2
EZ		 107792019-05-03 Eli Zaretskii <eliz@gnu.org>
10780
353ea2d1
EZ		 10781 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10782 _WIN32_WINNT to the XP level, unless already defined to a higher
10783 level.
10784
10785 * unittests/parse-connection-spec-selftests.c:
10786 * ser-tcp.c:
10787 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10788 override.
10789
5f2459c2
EZ		 10790 * symfile.c (find_separate_debug_file): Remove colon from the
10791 drive spec of DOS/Windows file names of the target, so that the
10792 file name produced from DEBUGDIR and the target's directory will
10793 be valid on DOS/Windows systems.
10794
80062eb9
AB		 107952019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10796
10797 * rust-lang.c (val_print_struct): Handle printing structures
10798 containing strings.
10799
b8c05e85
TT		 108002019-05-02 Tom Tromey <tromey@adacore.com>
10801
10802 * valarith.c (_initialize_valarith): Remove.
10803
4504bbde
TT		 108042019-05-01 Tom Tromey <tromey@adacore.com>
10805
10806 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10807 bitfields.
10808
d48e62f4
TT		 108092019-05-01 Tom Tromey <tromey@adacore.com>
10810
10811 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10812 for big-endian copies.
10813
15f18d14
AT		 108142019-04-30 Ali Tamur <tamur@google.com>
10815 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10816 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10817 (read_3_bytes): New function.
10818
ab4ee614
JB		 108192019-04-30 Joel Brobecker <brobecker@adacore.com>
10820
10821 * windows-nat.c (main_thread_id): Delete.
10822 (handle_output_debug_string): Replace main_thread_id by
10823 current_event.dwThreadId.
10824 (fake_create_process): Likewise.
10825 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10826 Do not set main_thread_id.
10827 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10828 current_event.dwThreadId.
10829 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10830
8ed5b76e
JB		 108312019-04-30 Joel Brobecker <brobecker@adacore.com>
10832
10833 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10834 Use current_event.dwThreadId instead of main_thread_id.
10835
2ff0a947
TT		 108362019-04-30 Tom Tromey <tromey@adacore.com>
10837
10838 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10839 (create_excep_cond_exprs): Iterate over program spaces.
10840 (ada_exception_catchpoint_cond_string): Examine all minimal
10841 symbols for exception types.
10842
a776957c
TT		 108432019-04-30 Tom Tromey <tromey@adacore.com>
10844
10845 PR c++/24470:
10846 * dwarf2read.c (process_structure_scope): Handle case where type
10847 has template parameters but no symbol was created.
10848
bc68014d
AB		 108492019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10850 Chris January <chris.january@arm.com>
10851
10852 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10853 qualifier.
10854 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10855
f1fdc960
AB		 108562019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10857
10858 * f-typeprint.c (f_print_type): Update rules for printing
10859 whitespace.
10860 (f_type_print_varspec_suffix): Likewise.
10861
bf7a4de1
AB		 108622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10863 Chris January <chris.january@arm.com>
10864
10865 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10866 function arguments.
10867
bbe75b9d
AB		 108682019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10869
10870 * f-lang.c (build_fortran_types): Change name of void type to
10871 lower case.
10872 * f-typeprint.c (f_type_print_base): Print the name of the void
10873 type, rather than a fixed string.
10874 * f-valprint.c (f_decorations): Use lower case void string.
10875
1db455a7
AB		 108762019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10877 Chris January <chris.january@arm.com>
10878
10879 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10880 types for Fortran.
10881
b6d03bb2
AB		 108822019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10883 Chris January <chris.january@arm.com>
10884 David Lecomber <david.lecomber@arm.com>
10885
10886 * f-exp.y (BINOP_INTRINSIC): New token.
10887 (exp): New parser rule handling BINOP_INTRINSIC.
10888 (f77_keywords): Add new builtin procedures.
10889 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10890 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10891 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10892 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10893 (print_unop_subexp_f): New function.
10894 (print_binop_subexp_f): New function.
10895 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10896 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10897 (dump_subexp_body_f): Likewise.
10898 (operator_check_f): Likewise.
10899 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10900 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10901
83228e93
AB		 109022019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10903
10904 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10905 UNOP_KIND.
10906 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10907 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10908 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10909 (operator_length_f): New fuction.
10910 (print_subexp_f): New function.
10911 (op_name_f): New function.
10912 (dump_subexp_body_f): New function.
10913 (operator_check_f): New function.
10914 (exp_descriptor_f): Replace standard expression handling functions
10915 with new functions.
10916 * gdb/fortran-operator.def: New file.
10917 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10918 * gdb/std-operator.def: Remove UNOP_KIND.
10919
6fdcd7cc
AB		 109202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10921
10922 * std-operator.def: Remove unbalanced, stray double quote
10923 character.
10924
2e62ab40
AB		 109252019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10926 Chris January <chris.january@arm.com>
10927 Daniel Everett <daniel.everett@arm.com>
10928 Nick Forrington <nick.forrington@arm.com>
10929 Richard Bunt <richard.bunt@arm.com>
10930
10931 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10932 of depth when printing anonymous structs or unions.
10933 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10934 Don't print either the top-level value, or the children if the
10935 max-depth is exceeded.
10936 (ppscm_print_children): When printing the key of a map, allow one
10937 extra level of depth.
10938 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10939 print either the top-level value, or the children if the max-depth
10940 is exceeded.
10941 (print_children): When printing the key of a map, allow one extra
10942 level of depth.
10943 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10944 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10945 (user_print_options): Initialise max_depth field.
10946 (val_print_scalar_or_string_type_p): New function.
10947 (val_print): Check to see if the max depth has been reached.
10948 (val_print_check_max_depth): Define new function.
10949 (show_print_max_depth): New function.
10950 (_initialize_valprint): Add 'print max-depth' option.
10951 * valprint.h (struct value_print_options) <max_depth>: New field.
10952 (val_print_check_max_depth): Declare new function.
10953 * NEWS: Document new feature.
10954
4be290b2
AB		 109552019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10956
10957 * ada-lang.c (ada_language_defn): Initialise new field.
10958 * c-lang.c (c_is_string_type_p): New function.
10959 (c_language_defn): Initialise new field.
10960 (cplus_language_defn): Initialise new field.
10961 (asm_language_defn): Initialise new field.
10962 (minimal_language_defn): Initialise new field.
10963 * c-lang.h (c_is_string_type_p): Declare new function.
10964 * d-lang.c (d_language_defn): Initialise new field.
10965 * f-lang.c (f_is_string_type_p): New function.
10966 (f_language_defn): Initialise new field.
10967 * go-lang.c (go_is_string_type_p): New function.
10968 (go_language_defn): Initialise new field.
10969 * language.c (default_is_string_type_p): New function.
10970 (unknown_language_defn): Initialise new field.
10971 (auto_language_defn): Initialise new field.
10972 * language.h (struct language_defn) <la_is_string_type_p>: New
10973 member variable.
10974 (default_is_string_type_p): Declare new function.
10975 * m2-lang.c (m2_language_defn): Initialise new field.
10976 * objc-lang.c (objc_language_defn): Initialise new field.
10977 * opencl-lang.c (opencl_language_defn): Initialise new field.
10978 * p-lang.c (pascal_is_string_type_p): New function.
10979 (pascal_language_defn): Initialise new field.
10980 * rust-lang.c (rust_is_string_type_p): New function.
10981 (rust_language_defn): Initialise new field.
10982
721b08c6
AB		 109832019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10984
10985 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10986 New field.
10987 * ada-lang.c (ada_language_defn): Initialise new field.
10988 * c-lang.c (c_language_defn): Likewise.
10989 (cplus_language_defn): Likewise.
10990 (asm_language_defn): Likewise.
10991 (minimal_language_defn): Likewise.
10992 * d-lang.c (d_language_defn): Likewise.
10993 * f-lang.c (f_language_defn): Likewise.
10994 * go-lang.c (go_language_defn): Likewise.
10995 * language.c (unknown_language_defn): Likewise.
10996 (auto_language_defn): Likewise.
10997 * m2-lang.c (m2_language_defn): Likewise.
10998 * objc-lang.c (objc_language_defn): Likewise.
10999 * opencl-lang.c (opencl_language_defn): Likewise.
11000 * p-lang.c (pascal_language_defn): Likewise.
11001 * rust-lang.c (rust_language_defn): Likewise.
11002
fc913e53
AB		 110032019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11004
11005 * ada-lang.c (ada_is_character_type): Change return type to bool.
11006 (ada_is_string_type): Likewise.
11007 * ada-lang.h (ada_is_character_type): Update declaration
11008 (ada_is_string_type): Likewise.
11009
fa731fa0
PW		 110102019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11011
11012 Support style in 'frame|thread apply'
11013
11014 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11015 * record.c (record_start, record_stop): Update callers of
11016 execute_command_to_string with false.
11017 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11018 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11019 methods.
11020 (class string_file): New constructor with term_out parameter.
11021 Override methods term_out and can_emit_style_escape. New member
11022 term_out.
11023 (class stdio_file): Override can_emit_style_escape.
11024 (class tee_file): Override term_out and can_emit_style_escape.
11025 * utils.h (can_emit_style_escape): Remove.
11026 * utils.c (can_emit_style_escape): Likewise.
11027 Update all callers of can_emit_style_escape (SOMESTREAM) to
11028 SOMESTREAM->can_emit_style_escape.
11029 * source-cache.c (source_cache::get_source_lines): Likewise.
11030 * stack.c (frame_apply_command_count): Call execute_command_to_string
11031 passing the term_out characteristic of the current gdb_stdout.
11032 * thread.c (thr_try_catch_cmd): Likewise.
11033 * top.c (execute_command_to_string): pass term_out parameter
11034 to construct the string_file for the command output.
11035 * ui-file.c (term_cli_styling): New function (most code moved
11036 from utils.c can_emit_style_escape).
11037 (string_file::string_file, string_file::can_emit_style_escape,
11038 stdio_file::can_emit_style_escape, tee_file::term_out,
11039 tee_file::can_emit_style_escape): New functions.
11040
136afab8
PW		 110412019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11042
11043 * NEWS: Mention the new set|show may-call-functions.
11044 * infcall.c (may_call_functions_p): New variable.
11045 (show_may_call_functions_p): New function.
11046 (call_function_by_hand_dummy): Throws an error if not
11047 may-call-functions.
11048 (_initialize_infcall): Call add_setshow_boolean_cmd for
11049 may-call-functions.
11050
725cbb63
KS		 110512019-04-25 Keith Seitz <keiths@redhat.com>
11052
11053 PR c++/24367
11054 * cp-support.c (inspect_type): Don't attempt substitutions
11055 of symbol with the same name.
11056
3d1cbb78
TT		 110572019-04-25 Tom Tromey <tromey@adacore.com>
11058
11059 PR gdb/24475:
11060 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11061 static.
11062
94aeb44b
TT		 110632019-04-25 Tom Tromey <tromey@adacore.com>
11064
11065 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11066 rvalue reference.
11067 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11068 (gdb_xml_parser::parse): Use std::move.
11069 * python/python-internal.h (gdbpy_convert_exception): Take a const
11070 reference.
11071 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11072 std::move.
11073 * python/py-utils.c (gdbpy_convert_exception): Take a const
11074 reference.
11075 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11076 Use std::move.
11077 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11078 Use std::move.
11079 * mi/mi-main.c (mi_print_exception): Take a const reference.
11080 * main.c (handle_command_errors): Take a const reference.
11081 * linespec.c (parse_linespec): Use std::move.
11082 * infcall.c (run_inferior_call): Use std::move.
11083 (call_function_by_hand_dummy): Use std::move.
11084 * exec.c (try_open_exec_file): Use std::move.
11085 * exceptions.h (exception_print, exception_fprintf)
11086 (exception_print_same): Update.
11087 * exceptions.c (print_exception, exception_print)
11088 (exception_fprintf, exception_print_same): Change parameters to
11089 const reference.
11090 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11091 * common/new-op.c: Use std::move.
11092 * common/common-exceptions.h (struct gdb_exception): Add move
11093 constructor.
11094 (struct gdb_exception_error, struct gdb_exception_quit, struct
11095 gdb_quit_bad_alloc): Change constructor to move constructor.
11096 (throw_exception): Change parameter to rvalue reference.
11097 * common/common-exceptions.c (throw_exception): Take rvalue
11098 reference.
11099 * cli/cli-interp.c (safe_execute_command): Use std::move.
11100 * breakpoint.c (insert_bp_location, location_to_sals): Use
11101 std::move.
11102
680d7fd5
TT		 111032019-04-25 Tom Tromey <tromey@adacore.com>
11104
11105 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11106 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11107 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11108 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11109 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11110 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11111 guile/scm-value.c: Use unpack.
11112 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11113 gdbscm_gdb_exception.
11114 (gdbscm_throw_gdb_exception): Likewise.
11115 (struct gdbscm_gdb_exception): New.
11116 (unpack): New function.
11117 (gdbscm_wrap): Use unpack.
11118
c6fdd8b2
TT		 111192019-04-25 Tom Tromey <tromey@adacore.com>
11120
11121 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11122 (gdb_rl_callback_handler): Use std::move.
11123 * common/common-exceptions.h (struct gdb_exception): Add move
11124 assignment operator.
11125 (throw_exception_sjlj): Change "exception" to const reference.
11126 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11127 (throw_exception_sjlj): Change "exception" to const reference.
11128
cc06b668
TT		 111292019-04-25 Tom Tromey <tromey@adacore.com>
11130
11131 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11132 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11133 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11134 Update.
11135 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11136 Update.
11137 * mi/mi-interp.c (mi_interp::exec): Update.
11138 * linespec.c (parse_linespec): Update.
11139 * infcall.c (run_inferior_call): Update.
11140 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11141 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11142 (gdbscm_lookup_global_symbol): Update.
11143 * guile/scm-param.c (gdbscm_parameter_value): Update.
11144 * guile/scm-frame.c (gdbscm_frame_read_register)
11145 (gdbscm_frame_read_var): Update.
11146 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11147 * exec.c (try_open_exec_file): Update.
11148 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11149 (gdb_rl_callback_handler): Update.
11150 * common/common-exceptions.h (exception_none): Don't declare.
11151 * common/common-exceptions.c (exception_none): Don't define.
11152 (struct catcher) <exception>: Update.
11153 * cli/cli-interp.c (safe_execute_command): Update.
11154 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11155
cf532bd1
AT		 111562019-04-25 Ali Tamur <tamur@google.com>
11157
11158 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11159 (read_attribute_value): Likewise.
11160 (dwarf2_read_addr_index): Update comment.
11161 (read_str_index): Add DW_FORM_strx.
11162 (dwarf2_string_attr): Likewise.
11163 (dwarf2_const_value_attr): Likewise.
11164 (dump_die_shallow): Likewise.
11165 (dwarf2_fetch_constant_bytes): Likewise.
11166 (skip_form_bytes): Likewise.
11167 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11168
82433e3e
SDJ		 111692019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11170
11171 PR corefiles/11608
11172 PR corefiles/18187
11173 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11174 OFFSET. Verify if current mapping contains an ELF header.
11175 (linux_find_memory_regions_full): Adjust call to
11176 dump_mapping_p.
11177
723adb65
SL		 111782019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11179 Kang Li <kanglictf@gmail.com>
11180
11181 PR gdb/21600
11182
11183 * dwarf2-frame.c (read_initial_length): Be consistent about using
11184 unsigned representation of length.
11185 (decode_frame_entry_1): Likewise. Check for wraparound of
11186 end pointer as well as buffer overflow.
11187
596179f7
SDJ		 111882019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11189
11190 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11191 "vq".
11192
a59240a4
TT		 111932019-04-24 Tom Tromey <tromey@adacore.com>
11194
11195 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11196
f872fdbb
AB		 111972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11198
11199 * s12z-tdep.c (s12z_unwind_pc): Delete.
11200 (s12z_unwind_sp): Delete.
11201 (s12z_gdbarch_init): Don't register deleted functions with
11202 gdbarch.
11203
b614e6f3
AB		 112042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11205
11206 * rl78-tdep.c (rl78_unwind_sp): Delete.
11207 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11208
14faed38
AB		 112092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11210
11211 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11212 (xstormy16_unwind_pc): Delete.
11213 (xstormy16_dummy_id): Delete.
11214 (xstormy16_gdbarch_init): Don't register deleted functions with
11215 gdbarch.
11216
541aad8a
AB		 112172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11218
11219 * vax-tdep.c (vax_unwind_pc): Delete.
11220 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11221
29222070
AB		 112222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11223
11224 * v850-tdep.c (v850_unwind_sp): Delete.
11225 (v850_unwind_pc): Delete.
11226 (v850_dummy_id): Delete.
11227 (v850_gdbarch_init): Don't register deleted functions with
11228 gdbarch.
11229
0f534d76
AB		 112302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11231
11232 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11233 (tilegx_unwind_pc): Delete.
11234 (tilegx_unwind_dummy_id): Delete.
11235 (tilegx_gdbarch_init): Don't register deleted functions with
11236 gdbarch.
11237
1ba7b7f9
AB		 112382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11239
11240 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11241 (tic6x_dummy_id): Delete.
11242 (tic6x_gdbarch_init): Don't register deleted functions with
11243 gdbarch.
11244
d31f262c
AB		 112452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11246
11247 * sparc-tdep.c (sparc_unwind_pc): Delete.
11248 (sparc32_gdbarch_init): Don't register deleted function with
11249 gdbarch.
11250
6d14d64d
AB		 112512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11252
11253 * sh-tdep.c (sh_unwind_sp): Delete.
11254 (sh_unwind_pc): Delete.
11255 (sh_dummy_id): Delete.
11256 (sh_gdbarch_init): Don't register deleted functions with
11257 gdbarch.
11258
a40dde9d
AB		 112592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11260
11261 * score-tdep.c (score_unwind_sp): Delete.
11262 (score_unwind_pc): Delete.
11263 (score_dummy_id): Delete.
11264 (score_gdbarch_init): Don't register deleted functions with
11265 gdbarch.
11266
47c47d69
AB		 112672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11268
11269 * rx-tdep.c (rx_unwind_pc): Delete.
11270 (rx_unwind_sp): Delete.
11271 (rx_dummy_id): Delete.
11272 (rx_gdbarch_init): Don't register deleted functions with
11273 gdbarch. Update comment.
11274
833a4480
AB		 112752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11276
11277 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11278 (rs6000_dummy_id): Delete.
11279 (rs6000_gdbarch_init): Don't register deleted functions with
11280 gdbarch.
11281
3f2cef49
AB		 112822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11283
11284 * or1k-tdep.c (or1k_dummy_id): Delete.
11285 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11286
96acf884
AB		 112872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11288
11289 * nios2-tdep.c (nios2_dummy_id): Delete.
11290 (nios2_unwind_sp): Delete.
11291 (nios2_gdbarch_init): Don't register deleted functions with
11292 gdbarch.
11293
ca0ab0aa
AB		 112942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11295
11296 * nds32-tdep.c (nds32_dummy_id): Delete.
11297 (nds32_unwind_pc): Delete.
11298 (nds32_unwind_sp): Delete.
11299 (nds32_gdbarch_init): Don't register deleted functions with
11300 gdbarch.
11301
c8259044
AB		 113022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * msp430-tdep.c (msp430_unwind_pc): Delete.
11305 (msp430_unwind_sp): Delete.
11306 (msp430_dummy_id): Delete.
11307 (msp430_gdbarch_init): Don't register deleted functions with
11308 gdbarch.
11309
27f113c8
AB		 113102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11311
11312 * moxie-tdep.c (moxie_unwind_sp): Delete.
11313 (moxie_unwind_pc): Delete.
11314 (moxie_dummy_id): Delete.
11315 (moxie_gdbarch_init): Don't register deleted functions with
11316 gdbarch.
11317
aee6c3cd
AB		 113182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11319
11320 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11321 (mn10300_unwind_pc): Delete.
11322 (mn10300_unwind_sp): Delete.
11323 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11324 mn10300_unwind_sp.
11325 (mn10300_frame_unwind_init): Don't register deleted functions with
11326 gdbarch.
11327
8e2b5aea
AB		 113282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11329
11330 * mep-tdep.c (mep_unwind_pc): Delete.
11331 (mep_unwind_sp): Delete.
11332 (mep_dummy_id): Delete.
11333 (mep_gdbarch_init): Don't register deleted functions with
11334 gdbarch.
11335
43cf3ede
AB		 113362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11337
11338 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11339 (m68hc11_unwind_sp): Delete.
11340 (m68hc11_gdbarch_init): Don't register deleted functions with
11341 gdbarch.
11342
5e79b7bb
AB		 113432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11344
11345 * m32r-tdep.c (m32r_unwind_sp): Delete.
11346 (m32r_unwind_pc): Delete.
11347 (m32r_dummy_id): Delete.
11348 (m32r_gdbarch_init): Don't register deleted functions with
11349 gdbarch.
11350
89b268d8
AB		 113512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11352
11353 * m32c-tdep.c (m32c_unwind_pc): Delete.
11354 (m32c_unwind_sp): Delete.
11355 (m32c_dummy_id): Delete.
11356 (m32c_gdbarch_init): Don't register deleted functions with
11357 gdbarch.
11358
946c28d2
AB		 113592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11360
11361 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11362 (lm32_unwind_pc): Delete.
11363 (lm32_dummy_id): Delete.
11364 (lm32_gdbarch_init): Don't register deleted functions with
11365 gdbarch.
11366
bf12844a
AB		 113672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11368
11369 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11370 (iq2000_unwind_pc): Delete.
11371 (iq2000_dummy_id): Delete.
11372 (iq2000_gdbarch_init): Don't register deleted functions with
11373 gdbarch.
11374
ecbc06d2
AB		 113752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11376
11377 * nds32-tdep.c (nds32_type_align): Delete.
11378 (nds32_push_dummy_call): Use type_align instead.
11379
030197b4
AB		 113802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11381
11382 * arm-tdep.c (arm_type_align): Only handle vector override case.
11383 (arm_push_dummy_call): Use type_align.
11384 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11385
b907456c
AB		 113862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11387
11388 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11389 case.
11390 (pass_on_stack): Use type_align.
11391 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11392 function.
11393
9e97ba43
TT		 113942019-04-23 Tom Tromey <tromey@adacore.com>
11395
11396 * dwarf2read.c (line_header::file_name_at): Remove unused
11397 overload.
11398
6892f601
TV		 113992019-04-23 Tom de Vries <tdevries@suse.de>
11400
11401 PR gdb/24438
11402 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11403 invocation.
11404
336d760d
AT		 11405
114062019-03-27 Ali Tamur <tamur@google.com>
11407
11408 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11409 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11410 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11411 (dwarf_expr_context::get_addr_index): Likewise
11412 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11413 (symbol_needs_eval_context::get_addr_index): Likewise
11414 (disassemble_dwarf_expression): Add DW_OP_addrx
11415 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11416 (read_cutu_die_from_dwo): Update comment
11417 (skip_one_die): Add DW_FORM_addrx
11418 (read_attribute_value): Likewise
11419 (var_decode_location): Add DW_OP_addrx
11420 (dwarf2_const_value_attr): Add DW_FORM_addrx
11421 (dump_die_shallow): Likewise
11422 (dwarf2_fetch_constant_bytes): Likewise
11423 (decode_locdesc): Add DW_OP_addrx
11424 (skip_form_bytes): Add DW_FORM_addrx
11425
ad9d13f8
AT		 114262019-04-22 Ali Tamur <tamur@google.com>
11427
11428 * MAINTAINERS (Write After Approval): Add self.
11429
d70cc3ba
SM		 114302019-04-22 Simon Marchi <simon.marchi@efficios.com>
11431
11432 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11433 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11434 (open_symbol_file_object): Likewise.
11435 (svr4_default_sos): Add info parameter.
11436 (svr4_read_so_list): Likewise.
11437 (svr4_current_sos_direct): Adjust functions calls to pass down
11438 info.
11439 (svr4_current_sos_1): Add info parameter.
11440 (svr4_current_sos): Call get_svr4_info, pass info down to
11441 svr4_current_sos_1.
11442 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11443 get_svr4_info.
11444 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11445 get_svr4_info.
11446 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11447 to get_svr4_info.
11448 (probes_table_remove_objfile_probes): Likewise.
11449 (register_solib_event_probe): Add info parameter.
11450 (solist_update_incremental): Pass info parameter down to
11451 svr4_read_so_list.
11452 (disable_probes_interface): Add info parameter.
11453 (svr4_handle_solib_event): Pass current_program_space to
11454 get_svr4_info. Adjust disable_probes_interface cleanup.
11455 (svr4_create_probe_breakpoints): Add info parameter, pass it
11456 down to register_solib_event_probe.
11457 (svr4_create_solib_event_breakpoints): Add info parameter,
11458 pass it down to svr4_create_probe_breakpoints.
11459 (enable_break): Pass info down to
11460 svr4_create_solib_event_breakpoints.
11461 (svr4_solib_create_inferior_hook): Pass current_program_space to
11462 get_svr4_info.
11463 (svr4_clear_solib): Likewise.
11464
7905fc35
PA		 114652019-04-22 Pedro Alves <palves@redhat.com>
11466
11467 * solib-svr4.c (svr4_free_objfile_observer): New.
11468 (probe_and_action::objfile): New field.
11469 (probes_table_htab_remove_objfile_probes)
11470 (probes_table_remove_objfile_probes): New functions.
11471 (register_solib_event_probe): Add 'objfile' parameter. Store it
11472 in the new probe_and_action. Don't store the probe in 'lookup'.
11473 (svr4_create_probe_breakpoints): Pass objfile to
11474 register_solib_event_probe.
11475 (_initialize_svr4_solib): Register a free_objfile observer.
11476
fb881986
TT		 114772019-04-19 Tom Tromey <tom@tromey.com>
11478
11479 * common/queue.h: Remove.
11480
8732db6c
TT		 114812019-04-19 Tom Tromey <tom@tromey.com>
11482
11483 * event-loop.c: Don't include "common/queue.h".
11484
97dfbadd
TT		 114852019-04-19 Tom Tromey <tom@tromey.com>
11486
11487 * remote.c (remote_target): Use delete.
11488 * remote-notif.h: Include <list>, not "common/queue.h".
11489 (notif_client_p): Remove typedef.
11490 (remote_notif_state): Add constructor, destructor, initializer.
11491 <notif_queue>: Now a std::list.
11492 (remote_notif_state_xfree): Don't declare.
11493 * remote-notif.c (remote_notif_process, handle_notification)
11494 (remote_notif_state_allocate): Update.
11495 (~remote_notif_state): Rename from remote_notif_state_xfree.
11496
cf250e36
TT		 114972019-04-19 Tom Tromey <tom@tromey.com>
11498
11499 * symfile.c (reread_symbols): Update.
11500 * objfiles.c (objfile_register_static_link)
11501 (objfile_lookup_static_link): Update
11502 (~objfile) Don't delete static_links.
11503 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11504
61f4b350
TT		 115052019-04-19 Tom Tromey <tom@tromey.com>
11506
11507 * type-stack.h (struct type_stack) <insert>: Constify string.
11508 * type-stack.c (type_stack::insert): Constify string.
11509 * gdbtypes.h (lookup_template_type): Update.
11510 (address_space_name_to_int): Update.
11511 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11512 const.
11513 (lookup_template_type): Make name const.
11514 * c-exp.y: Update rules.
11515 (lex_one_token, classify_name, classify_inner_name)
11516 (c_print_token): Update.
11517 * p-exp.y: Update rules.
11518 (yylex): Update.
11519 * f-exp.y: Update rules.
11520 (yylex): Update.
11521 * d-exp.y: Update rules.
11522 (lex_one_token, classify_name, classify_inner_name): Update.
11523 * parse.c (write_dollar_variable, copy_name): Return std::string.
11524 * parser-defs.h (copy_name): Change return type.
11525 * m2-exp.y: Update rules.
11526 (yylex): Update.
11527 * go-exp.y (lex_one_token): Update.
11528 Update rules.
11529 (classify_unsafe_function, classify_packaged_name)
11530 (classify_name, yylex): Update.
11531
189b8c2e
ST		 115322019-04-19 Sergei Trofimovich <siarheit@google.com>
11533
11534 * configure.ac: add --enable-source-highlight switch.
11535 * configure: Regenerate.
11536 * top.c (print_gdb_version): plumb --enable-source-highlight
11537 status to "show configuration".
11538
8ecb59f8
TT		 115392019-04-19 Tom Tromey <tromey@adacore.com>
11540
11541 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11542 Check ADA_TYPE_P.
11543 (empty_record, ada_template_to_fixed_record_type_1)
11544 (template_to_static_fixed_type)
11545 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11546 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11547 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11548 macros.
11549
62160ec9
TT		 115502019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11551
11552 PR symtab/24423:
11553 * source.c (print_source_lines_base): Advance "iter" when a
11554 control character is seen.
11555
f2ae8bc8
PW		 115562019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11557
11558 * inferior.h (struct infcall_suspend_state_deleter):
11559 Catch exception in destructor to avoid crash.
11560
d563b953
PW		 115612019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11562
11563 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11564 close to the add_com "shell".
11565
dc34c897
TT		 115662019-04-18 Tom Tromey <tromey@adacore.com>
11567
11568 * process-stratum-target.h (class process_stratum_target)
11569 <stratum>: Add "final".
11570
a12e5744
TT		 115712019-04-17 Tom Tromey <tromey@adacore.com>
11572
11573 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11574 against nullptr before use.
11575
a7e559cc
AH		 115762019-04-17 Alan Hayward <alan.hayward@arm.com>
11577
11578 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11579
c01660c6
AB		 115802019-04-17 Jim Wilson <jimw@sifive.com>
11581 Andrew Burgess <andrew.burgess@embecosm.com>
11582
11583 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11584 code read might fail, assume 4-byte breakpoint in that case.
11585
4aa866af
LS		 115862019-04-15 Leszek Swirski <leszeks@google.com>
11587
11588 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11589 rather than a hand-rolled POD check when checking for forced MEMORY
11590 classification.
11591
48574d91
AH		 115922019-04-15 Alan Hayward <alan.hayward@arm.com>
11593
11594 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11595 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11596 function.
11597 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11598 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11599 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11600 declaration.
11601
4da037ef
AH		 116022019-04-15 Alan Hayward <alan.hayward@arm.com>
11603
11604 * aarch64-linux-nat.c
11605 (aarch64_linux_nat_target::thread_architecture): Add override.
11606 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11607 each VQ.
11608
ccb8d7e8
AH		 116092019-04-15 Alan Hayward <alan.hayward@arm.com>
11610
11611 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11612
35add35e
AB		 116132019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11614
11615 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11616 target types of size 96-bits, add some additional comments, and
11617 check that the builtin type we found was the correct size.
11618
51196bbc
EZ		 116192019-04-12 Eli Zaretskii <eliz@gnu.org>
11620
11621 * utils.c (prompt_for_continue): Don't restore the styling at the
11622 end, as applied_style has the wrong value. This fixes styling in
11623 long lists of file names that are interrupted by the "Continue?"
11624 prompt.
11625
62253a61
AB		 116262019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11627
11628 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11629 * c-lang.c (c_language_defn): Likewise.
11630 (cplus_language_defn): Likewise.
11631 (asm_language_defn): Likewise.
11632 (minimal_language_defn): Likewise.
11633 * d-lang.c (d_language_defn): Likewise.
11634 * f-lang.c (f_language_defn): Likewise.
11635 * go-lang.c (go_language_defn): Likewise.
11636 * language.c (unknown_language_defn): Likewise.
11637 (auto_language_defn): Likewise.
11638 * language.h (struct language_defn): Remove la_magic field.
11639 (LANG_MAGIC): Delete.
11640 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11641 * objc-lang.c (objc_language_defn): Likewise.
11642 * opencl-lang.c (opencl_language_defn): Likewise.
11643 * p-lang.c (pascal_language_defn): Likewise.
11644 * rust-lang.c (rust_language_defn): Likewise.
11645
a9158a86
AB		 116462019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11647
11648 * riscv-tdep.c (riscv_type_align): New function.
11649 (riscv_type_alignment): Delete.
11650 (riscv_arg_location): Use 'type_align'.
11651 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11652
41077b66
AB		 116532019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11654
11655 * gdbtypes.c (type_align): A struct with no non-static fields also
11656 has alignment of 1.
11657
9f0272f8
AB		 116582019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11659
11660 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11661 component to 0.
11662 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11663 member.
11664 (riscv_struct_info::analyse): New implementation using new
11665 analyse_inner member function.
11666 (riscv_struct_info::field_offset): New member function.
11667 (riscv_struct_info::m_offsets): New member variable.
11668 (riscv_struct_info::analyse_inner): New private member function,
11669 takes the old implementation of riscv_struct_info::analyse but
11670 extended to track field offsets.
11671 (riscv_call_arg_struct): Update the struct folding special cases
11672 to handle cases where empty C++ structs, which are non-zero
11673 length, are found.
11674 (riscv_arg_location): Initialise the length of each location, a
11675 non-zero length now indicates the location is in use.
11676 (riscv_push_dummy_call): Allow for the first location having a
11677 non-zero offset when setting up arguments.
11678 (riscv_return_value): Likewise, but for return values.
11679
02cf60c7
TT		 116802019-04-11 Tom Tromey <tromey@adacore.com>
11681
11682 * utils.c (internal_vproblem): Make "msg" const.
11683
68811f8f
AH		 116842019-04-11 Alan Hayward <alan.hayward@arm.com>
11685
11686 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11687 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11688 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11689 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11690
3f52fdbc
KB		 116912019-04-10 Kevin Buettner <kevinb@redhat.com>
11692
11693 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11694 function.
11695 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11696 of amd64_collect_native_gregset.
11697 (amd64_linux_nat_target::store_registers): Likewise.
11698
e9ad22ee
TT		 116992019-04-10 Tom Tromey <tom@tromey.com>
11700
11701 * symtab.c (lookup_global_symbol_from_objfile)
11702 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11703 * objfiles.h (class separate_debug_iterator): New.
11704 (class separate_debug_range): New.
11705 (struct objfile) <separate_debug_objfiles>: New method.
11706 (objfile_separate_debug_iterate): Don't declare.
11707 * objfiles.c (separate_debug_iterator::operator++): Rename from
11708 objfile_separate_debug_iterate.
11709 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11710 iterator.
11711 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11712 iterator.
11713
ee371134
TT		 117142019-04-10 Tom Tromey <tom@tromey.com>
11715
11716 * symfile.c (reread_symbols): Remove old comment.
11717 * objfiles.c (free_all_objfiles): Fix a typo.
11718
bf227d61
TT		 117192019-04-10 Tom Tromey <tom@tromey.com>
11720
11721 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11722 * minsyms.c (lookup_minimal_symbol): Use foreach.
11723 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11724 (lookup_minimal_symbol_solib_trampoline): Likewise.
11725 * symfile.c (reread_symbols): Use foreach.
11726
8dc433a0
TT		 117272019-04-09 Ivan Begert <ivanbegert@gmail.com>
11728 Tom Tromey <tromey@adacore.com>
11729
11730 PR rust/24414:
11731 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11732 (rust_lex_int_test): Change "value" to be LONGEST.
11733 (rust_lex_tests): Add test for long integer literal.
11734
9ab8741a
TT		 117352019-04-09 Tom Tromey <tromey@adacore.com>
11736
11737 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11738 to bool.
11739 (extended_remote_target::attach): Update.
11740 (remote_target::remote_notice_new_inferior): Update.
11741 (remote_target::add_current_inferior_and_thread): Update.
11742 * inferior.c (exit_inferior_1): Use "false".
11743 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11744
e242fd12
SM		 117452019-04-09 Simon Marchi <simon.marchi@efficios.com>
11746
9ca1957f 11747 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11748 the "start" command.
11749
2b0c8b01
KB		 117502019-04-08 Kevin Buettner <kevinb@redhat.com>
11751
11752 * python/py-inferior.c (infpy_thread_from_thread_handle):
11753 Adjust comments to reflect renaming of thread_from_thread_handle
11754 to thread_from_handle. Adjust keywords. Fix type error message.
11755 (inferior_object_methods): Add thread_from_handle. Retain
11756 thread_from_thread_handle, but mark it as deprecated.
11757
50a82723
KB		 117582019-04-08 Kevin Buettner <kevinb@redhat.com>
11759
11760 * gdbthread.h (find_thread_by_handle): Revise declaration.
11761 * thread.c (find_thread_by_handle): Likewise. Adjust
11762 implementation too.
11763 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11764 support for buffer objects as handles.
11765
cf63b016
KB		 117662019-04-08 Kevin Buettner <kevinb@redhat.com>
11767
11768 * python/py-infthread.c (thpy_thread_handle): New function.
11769 (thread_object_methods): Register thpy_thread_handle.
11770
3d6c6204
KB		 117712019-04-08 Kevin Buettner <kevinb@redhat.com>
11772
11773 * gdbthread.h (thread_to_thread_handle): Declare.
11774 * thread.c (gdbtypes.h): Include.
11775 (thread_to_thread_handle): New function.
11776
11777 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11778 (target_thread_info_to_thread_handle): Declare.
11779 * target.c (target_thread_info_to_thread_handle): New function.
11780 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11781 * target-delegates.c: Regenerate.
11782
11783 * linux-thread-db.c (class thread_db_target): Add method
11784 thread_info_to_thread_handle.
11785 (thread_db_target::thread_info_to_thread_handle): Define.
11786 * remote.c (class remote_target): Add new method
11787 thread_info_to_thread_handle.
11788 (remote_target::thread_info_to_thread_handle): Define.
11789
56be6ea8
PA		 117902019-04-08 Pedro Alves <palves@redhat.com>
11791
11792 * common/common-exceptions.c (throw_exception): Don't create
11793 named object to throw; throw directly.
11794 (throw_it): Likewise. Don't initialize gdb_exception::message
11795 here, with new; pass FMT and AP to the ctor instead.
11796 * common/common-exceptions.h: Include <string>.
11797 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11798 const char *, va_list)): New ctor. Use std::make_shared.
11799 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11800 errors)): Delete.
11801 (gdb_exception_error::gdb_exception_error(enum errors, const char
11802 *, va_list)): New.
11803 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11804 Add assertion.
11805 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11806 errors)): Delete.
11807 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11808 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11809 Add assertion.
11810
eedc3f4f
TT		 118112019-04-08 Tom Tromey <tom@tromey.com>
11812
11813 * valops.c (value_rtti_indirect_type): Replace throw_exception
11814 with throw.
11815 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11816 with throw.
11817 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11818 throw.
11819 * target.c (target_translate_tls_address): Replace throw_exception
11820 with throw.
11821 * stack.c (frame_apply_command_count): Replace throw_exception
11822 with throw.
11823 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11824 throw.
11825 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11826 with throw.
11827 * rs6000-tdep.c (rs6000_frame_cache)
11828 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11829 * remote.c: Replace throw_exception with throw.
11830 * record-full.c (record_full_message, record_full_wait_1)
11831 (record_full_restore): Replace throw_exception with throw.
11832 * record-btrace.c:
11833 (get_thread_current_frame_id, record_btrace_start_replaying)
11834 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11835 (cmd_record_btrace_start): Replace throw_exception with throw.
11836 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11837 throw.
11838 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11839 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11840 * linespec.c:
11841 (find_linespec_symbols): Replace throw_exception with throw.
11842 * infrun.c (displaced_step_prepare, resume): Replace
11843 throw_exception with throw.
11844 * infcmd.c (post_create_inferior): Replace throw_exception with
11845 throw.
11846 * inf-loop.c (inferior_event_handler): Replace throw_exception
11847 with throw.
11848 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11849 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11850 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11851 (get_prev_frame_always, get_frame_pc_if_available)
11852 (get_frame_address_in_block_if_available, get_frame_language):
11853 Replace throw_exception with throw.
11854 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11855 throw_exception with throw.
11856 * eval.c (fetch_subexp_value, evaluate_var_value)
11857 (evaluate_funcall, evaluate_subexp_standard): Replace
11858 throw_exception with throw.
11859 * dwarf2loc.c (call_site_find_chain)
11860 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11861 Replace throw_exception with throw.
11862 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11863 with throw.
11864 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11865 throw.
11866 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11867 * completer.c (complete_line_internal): Replace throw_exception
11868 with throw.
11869 * compile/compile-object-run.c (compile_object_run): Replace
11870 throw_exception with throw.
11871 * cli/cli-script.c (process_next_line): Replace throw_exception
11872 with throw.
11873 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11874 (btrace_enable, btrace_maint_update_pt_packets): Replace
11875 throw_exception with throw.
11876 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11877 throw_exception with throw.
11878 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11879 throw_exception with throw.
11880 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11881 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11882 * aarch64-tdep.c (aarch64_make_prologue_cache)
11883 (aarch64_make_stub_cache): Replace throw_exception with throw.
11884
26003a20
TT		 118852019-04-08 Tom Tromey <tom@tromey.com>
11886
11887 * common/common-exceptions.c (throw_exception): Rename from
11888 throw_exception_cxx. Remove old copy. Make argument const.
11889 (throw_it): Create and throw exception objects directly.
11890 * common/common-exceptions.h (throw_exception): Make argument
11891 const.
11892 (struct gdb_exception_error): Add constructor.
11893 (struct gdb_exception_quit): Add constructor.
11894
d272eb37
TT		 118952019-04-08 Tom Tromey <tom@tromey.com>
11896
11897 * common/common-exceptions.h (exception_rethrow): Don't declare.
11898 (TRY_SJLJ): Update comment.
11899 (TRY, CATCH, END_CATCH): Remove.
11900 * common/common-exceptions.c (exception_rethrow): Remove.
11901
230d2906
TT		 119022019-04-08 Tom Tromey <tom@tromey.com>
11903
11904 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11905 Remove.
11906 (gdb_exception_error): Rename from
11907 gdb_exception_RETURN_MASK_ERROR.
11908 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11909 (gdb_quit_bad_alloc): Update.
11910 * aarch64-tdep.c: Update.
11911 * ada-lang.c: Update.
11912 * ada-typeprint.c: Update.
11913 * ada-valprint.c: Update.
11914 * amd64-tdep.c: Update.
11915 * arch-utils.c: Update.
11916 * break-catch-throw.c: Update.
11917 * breakpoint.c: Update.
11918 * btrace.c: Update.
11919 * c-varobj.c: Update.
11920 * cli/cli-cmds.c: Update.
11921 * cli/cli-interp.c: Update.
11922 * cli/cli-script.c: Update.
11923 * common/common-exceptions.c: Update.
11924 * common/new-op.c: Update.
11925 * common/selftest.c: Update.
11926 * compile/compile-c-symbols.c: Update.
11927 * compile/compile-cplus-symbols.c: Update.
11928 * compile/compile-object-load.c: Update.
11929 * compile/compile-object-run.c: Update.
11930 * completer.c: Update.
11931 * corelow.c: Update.
11932 * cp-abi.c: Update.
11933 * cp-support.c: Update.
11934 * cp-valprint.c: Update.
11935 * darwin-nat.c: Update.
11936 * disasm-selftests.c: Update.
11937 * dtrace-probe.c: Update.
11938 * dwarf-index-cache.c: Update.
11939 * dwarf-index-write.c: Update.
11940 * dwarf2-frame-tailcall.c: Update.
11941 * dwarf2-frame.c: Update.
11942 * dwarf2loc.c: Update.
11943 * dwarf2read.c: Update.
11944 * eval.c: Update.
11945 * event-loop.c: Update.
11946 * event-top.c: Update.
11947 * exec.c: Update.
11948 * f-valprint.c: Update.
11949 * fbsd-tdep.c: Update.
11950 * frame-unwind.c: Update.
11951 * frame.c: Update.
11952 * gdbtypes.c: Update.
11953 * gnu-v3-abi.c: Update.
11954 * guile/guile-internal.h: Update.
11955 * guile/scm-block.c: Update.
11956 * guile/scm-breakpoint.c: Update.
11957 * guile/scm-cmd.c: Update.
11958 * guile/scm-disasm.c: Update.
11959 * guile/scm-frame.c: Update.
11960 * guile/scm-lazy-string.c: Update.
11961 * guile/scm-math.c: Update.
11962 * guile/scm-param.c: Update.
11963 * guile/scm-ports.c: Update.
11964 * guile/scm-pretty-print.c: Update.
11965 * guile/scm-symbol.c: Update.
11966 * guile/scm-symtab.c: Update.
11967 * guile/scm-type.c: Update.
11968 * guile/scm-value.c: Update.
11969 * i386-linux-tdep.c: Update.
11970 * i386-tdep.c: Update.
11971 * inf-loop.c: Update.
11972 * infcall.c: Update.
11973 * infcmd.c: Update.
11974 * infrun.c: Update.
11975 * jit.c: Update.
11976 * language.c: Update.
11977 * linespec.c: Update.
11978 * linux-fork.c: Update.
11979 * linux-nat.c: Update.
11980 * linux-tdep.c: Update.
11981 * linux-thread-db.c: Update.
11982 * main.c: Update.
11983 * mi/mi-cmd-break.c: Update.
11984 * mi/mi-cmd-stack.c: Update.
11985 * mi/mi-interp.c: Update.
11986 * mi/mi-main.c: Update.
11987 * objc-lang.c: Update.
11988 * p-valprint.c: Update.
11989 * parse.c: Update.
11990 * ppc-linux-tdep.c: Update.
11991 * printcmd.c: Update.
11992 * python/py-arch.c: Update.
11993 * python/py-breakpoint.c: Update.
11994 * python/py-cmd.c: Update.
11995 * python/py-finishbreakpoint.c: Update.
11996 * python/py-frame.c: Update.
11997 * python/py-framefilter.c: Update.
11998 * python/py-gdb-readline.c: Update.
11999 * python/py-inferior.c: Update.
12000 * python/py-infthread.c: Update.
12001 * python/py-lazy-string.c: Update.
12002 * python/py-linetable.c: Update.
12003 * python/py-objfile.c: Update.
12004 * python/py-param.c: Update.
12005 * python/py-prettyprint.c: Update.
12006 * python/py-progspace.c: Update.
12007 * python/py-record-btrace.c: Update.
12008 * python/py-record.c: Update.
12009 * python/py-symbol.c: Update.
12010 * python/py-type.c: Update.
12011 * python/py-unwind.c: Update.
12012 * python/py-utils.c: Update.
12013 * python/py-value.c: Update.
12014 * python/python.c: Update.
12015 * record-btrace.c: Update.
12016 * record-full.c: Update.
12017 * remote-fileio.c: Update.
12018 * remote.c: Update.
12019 * riscv-tdep.c: Update.
12020 * rs6000-aix-tdep.c: Update.
12021 * rs6000-tdep.c: Update.
12022 * rust-exp.y: Update.
12023 * rust-lang.c: Update.
12024 * s390-tdep.c: Update.
12025 * selftest-arch.c: Update.
12026 * solib-dsbt.c: Update.
12027 * solib-frv.c: Update.
12028 * solib-spu.c: Update.
12029 * solib-svr4.c: Update.
12030 * solib.c: Update.
12031 * sparc64-linux-tdep.c: Update.
12032 * stack.c: Update.
12033 * symfile-mem.c: Update.
12034 * symmisc.c: Update.
12035 * target.c: Update.
12036 * thread.c: Update.
12037 * top.c: Update.
12038 * tracefile-tfile.c: Update.
12039 * tui/tui.c: Update.
12040 * typeprint.c: Update.
12041 * unittests/cli-utils-selftests.c: Update.
12042 * unittests/parse-connection-spec-selftests.c: Update.
12043 * valops.c: Update.
12044 * valprint.c: Update.
12045 * value.c: Update.
12046 * varobj.c: Update.
12047 * windows-nat.c: Update.
12048 * x86-linux-nat.c: Update.
12049 * xml-support.c: Update.
12050
a70b8144
TT		 120512019-04-08 Tom Tromey <tom@tromey.com>
12052
12053 * xml-support.c: Use C++ exception handling.
12054 * x86-linux-nat.c: Use C++ exception handling.
12055 * windows-nat.c: Use C++ exception handling.
12056 * varobj.c: Use C++ exception handling.
12057 * value.c: Use C++ exception handling.
12058 * valprint.c: Use C++ exception handling.
12059 * valops.c: Use C++ exception handling.
12060 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12061 handling.
12062 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12063 * typeprint.c: Use C++ exception handling.
12064 * tui/tui.c: Use C++ exception handling.
12065 * tracefile-tfile.c: Use C++ exception handling.
12066 * top.c: Use C++ exception handling.
12067 * thread.c: Use C++ exception handling.
12068 * target.c: Use C++ exception handling.
12069 * symmisc.c: Use C++ exception handling.
12070 * symfile-mem.c: Use C++ exception handling.
12071 * stack.c: Use C++ exception handling.
12072 * sparc64-linux-tdep.c: Use C++ exception handling.
12073 * solib.c: Use C++ exception handling.
12074 * solib-svr4.c: Use C++ exception handling.
12075 * solib-spu.c: Use C++ exception handling.
12076 * solib-frv.c: Use C++ exception handling.
12077 * solib-dsbt.c: Use C++ exception handling.
12078 * selftest-arch.c: Use C++ exception handling.
12079 * s390-tdep.c: Use C++ exception handling.
12080 * rust-lang.c: Use C++ exception handling.
12081 * rust-exp.y: Use C++ exception handling.
12082 * rs6000-tdep.c: Use C++ exception handling.
12083 * rs6000-aix-tdep.c: Use C++ exception handling.
12084 * riscv-tdep.c: Use C++ exception handling.
12085 * remote.c: Use C++ exception handling.
12086 * remote-fileio.c: Use C++ exception handling.
12087 * record-full.c: Use C++ exception handling.
12088 * record-btrace.c: Use C++ exception handling.
12089 * python/python.c: Use C++ exception handling.
12090 * python/py-value.c: Use C++ exception handling.
12091 * python/py-utils.c: Use C++ exception handling.
12092 * python/py-unwind.c: Use C++ exception handling.
12093 * python/py-type.c: Use C++ exception handling.
12094 * python/py-symbol.c: Use C++ exception handling.
12095 * python/py-record.c: Use C++ exception handling.
12096 * python/py-record-btrace.c: Use C++ exception handling.
12097 * python/py-progspace.c: Use C++ exception handling.
12098 * python/py-prettyprint.c: Use C++ exception handling.
12099 * python/py-param.c: Use C++ exception handling.
12100 * python/py-objfile.c: Use C++ exception handling.
12101 * python/py-linetable.c: Use C++ exception handling.
12102 * python/py-lazy-string.c: Use C++ exception handling.
12103 * python/py-infthread.c: Use C++ exception handling.
12104 * python/py-inferior.c: Use C++ exception handling.
12105 * python/py-gdb-readline.c: Use C++ exception handling.
12106 * python/py-framefilter.c: Use C++ exception handling.
12107 * python/py-frame.c: Use C++ exception handling.
12108 * python/py-finishbreakpoint.c: Use C++ exception handling.
12109 * python/py-cmd.c: Use C++ exception handling.
12110 * python/py-breakpoint.c: Use C++ exception handling.
12111 * python/py-arch.c: Use C++ exception handling.
12112 * printcmd.c: Use C++ exception handling.
12113 * ppc-linux-tdep.c: Use C++ exception handling.
12114 * parse.c: Use C++ exception handling.
12115 * p-valprint.c: Use C++ exception handling.
12116 * objc-lang.c: Use C++ exception handling.
12117 * mi/mi-main.c: Use C++ exception handling.
12118 * mi/mi-interp.c: Use C++ exception handling.
12119 * mi/mi-cmd-stack.c: Use C++ exception handling.
12120 * mi/mi-cmd-break.c: Use C++ exception handling.
12121 * main.c: Use C++ exception handling.
12122 * linux-thread-db.c: Use C++ exception handling.
12123 * linux-tdep.c: Use C++ exception handling.
12124 * linux-nat.c: Use C++ exception handling.
12125 * linux-fork.c: Use C++ exception handling.
12126 * linespec.c: Use C++ exception handling.
12127 * language.c: Use C++ exception handling.
12128 * jit.c: Use C++ exception handling.
12129 * infrun.c: Use C++ exception handling.
12130 * infcmd.c: Use C++ exception handling.
12131 * infcall.c: Use C++ exception handling.
12132 * inf-loop.c: Use C++ exception handling.
12133 * i386-tdep.c: Use C++ exception handling.
12134 * i386-linux-tdep.c: Use C++ exception handling.
12135 * guile/scm-value.c: Use C++ exception handling.
12136 * guile/scm-type.c: Use C++ exception handling.
12137 * guile/scm-symtab.c: Use C++ exception handling.
12138 * guile/scm-symbol.c: Use C++ exception handling.
12139 * guile/scm-pretty-print.c: Use C++ exception handling.
12140 * guile/scm-ports.c: Use C++ exception handling.
12141 * guile/scm-param.c: Use C++ exception handling.
12142 * guile/scm-math.c: Use C++ exception handling.
12143 * guile/scm-lazy-string.c: Use C++ exception handling.
12144 * guile/scm-frame.c: Use C++ exception handling.
12145 * guile/scm-disasm.c: Use C++ exception handling.
12146 * guile/scm-cmd.c: Use C++ exception handling.
12147 * guile/scm-breakpoint.c: Use C++ exception handling.
12148 * guile/scm-block.c: Use C++ exception handling.
12149 * guile/guile-internal.h: Use C++ exception handling.
12150 * gnu-v3-abi.c: Use C++ exception handling.
12151 * gdbtypes.c: Use C++ exception handling.
12152 * frame.c: Use C++ exception handling.
12153 * frame-unwind.c: Use C++ exception handling.
12154 * fbsd-tdep.c: Use C++ exception handling.
12155 * f-valprint.c: Use C++ exception handling.
12156 * exec.c: Use C++ exception handling.
12157 * event-top.c: Use C++ exception handling.
12158 * event-loop.c: Use C++ exception handling.
12159 * eval.c: Use C++ exception handling.
12160 * dwarf2read.c: Use C++ exception handling.
12161 * dwarf2loc.c: Use C++ exception handling.
12162 * dwarf2-frame.c: Use C++ exception handling.
12163 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12164 * dwarf-index-write.c: Use C++ exception handling.
12165 * dwarf-index-cache.c: Use C++ exception handling.
12166 * dtrace-probe.c: Use C++ exception handling.
12167 * disasm-selftests.c: Use C++ exception handling.
12168 * darwin-nat.c: Use C++ exception handling.
12169 * cp-valprint.c: Use C++ exception handling.
12170 * cp-support.c: Use C++ exception handling.
12171 * cp-abi.c: Use C++ exception handling.
12172 * corelow.c: Use C++ exception handling.
12173 * completer.c: Use C++ exception handling.
12174 * compile/compile-object-run.c: Use C++ exception handling.
12175 * compile/compile-object-load.c: Use C++ exception handling.
12176 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12177 * compile/compile-c-symbols.c: Use C++ exception handling.
12178 * common/selftest.c: Use C++ exception handling.
12179 * common/new-op.c: Use C++ exception handling.
12180 * cli/cli-script.c: Use C++ exception handling.
12181 * cli/cli-interp.c: Use C++ exception handling.
12182 * cli/cli-cmds.c: Use C++ exception handling.
12183 * c-varobj.c: Use C++ exception handling.
12184 * btrace.c: Use C++ exception handling.
12185 * breakpoint.c: Use C++ exception handling.
12186 * break-catch-throw.c: Use C++ exception handling.
12187 * arch-utils.c: Use C++ exception handling.
12188 * amd64-tdep.c: Use C++ exception handling.
12189 * ada-valprint.c: Use C++ exception handling.
12190 * ada-typeprint.c: Use C++ exception handling.
12191 * ada-lang.c: Use C++ exception handling.
12192 * aarch64-tdep.c: Use C++ exception handling.
12193
3d6e9d23
TT		 121942019-04-08 Tom Tromey <tom@tromey.com>
12195
12196 * xml-support.c (gdb_xml_parser::parse): Update.
12197 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12198 * value.c (show_convenience): Update.
12199 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12200 (test_parse_flags_qcs): Update.
12201 * thread.c (thr_try_catch_cmd): Update.
12202 * target.c (target_translate_tls_address): Update.
12203 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12204 (info_frame_command_core, frame_apply_command_count): Update.
12205 * rust-exp.y (rust_lex_exception_test): Update.
12206 * riscv-tdep.c (riscv_print_one_register_info): Update.
12207 * remote.c (remote_target::enable_btrace): Update.
12208 * record-btrace.c (record_btrace_enable_warn): Update.
12209 * python/py-utils.c (gdbpy_convert_exception): Update.
12210 * printcmd.c (do_one_display, print_variable_and_value): Update.
12211 * mi/mi-main.c (mi_print_exception): Update.
12212 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12213 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12214 * linux-nat.c (linux_nat_target::attach): Update.
12215 * linux-fork.c (class scoped_switch_fork_info): Update.
12216 * infrun.c (displaced_step_prepare): Update.
12217 * infcall.c (call_function_by_hand_dummy): Update.
12218 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12219 * gnu-v3-abi.c (print_one_vtable): Update.
12220 * frame.c (get_prev_frame_always): Update.
12221 * f-valprint.c (info_common_command_for_block): Update.
12222 * exec.c (try_open_exec_file): Update.
12223 * exceptions.c (print_exception, exception_print)
12224 (exception_fprintf, exception_print_same): Update.
12225 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12226 * dwarf-index-cache.c (index_cache::store)
12227 (index_cache::lookup_gdb_index): Update.
12228 * darwin-nat.c (maybe_cache_shell): Update.
12229 * cp-valprint.c (cp_print_value_fields): Update.
12230 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12231 (gcc_cplus_symbol_address): Update.
12232 * compile/compile-c-symbols.c (gcc_convert_symbol)
12233 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12234 * common/selftest.c: Update.
12235 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12236 a std::string.
12237 (exception_try_scope_entry, exception_try_scope_exit): Don't
12238 declare.
12239 (struct exception_try_scope): Remove.
12240 (TRY): Don't use exception_try_scope.
12241 (struct gdb_exception): Add constructor, operator=.
12242 <what>: New method.
12243 (struct gdb_exception_RETURN_MASK_ALL)
12244 (struct gdb_exception_RETURN_MASK_ERROR)
12245 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12246 (struct gdb_quit_bad_alloc): Update.
12247 * common/common-exceptions.c (exception_none): Change
12248 initializer.
12249 (struct catcher) <state, exception>: Initialize inline.
12250 <prev>: Remove member.
12251 (current_catcher): Remove.
12252 (catchers): New global.
12253 (exceptions_state_mc_init): Simplify.
12254 (catcher_pop): Remove.
12255 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12256 (try_scope_depth, exception_try_scope_entry)
12257 (exception_try_scope_exit): Remove.
12258 (throw_exception_sjlj): Update.
12259 (exception_messages, exception_messages_size): Remove.
12260 (throw_it): Simplify.
12261 (gdb_exception_sliced_copy): Remove.
12262 (throw_exception_cxx): Update.
12263 * cli/cli-script.c (script_from_file): Update.
12264 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12265 Update.
12266 * ada-valprint.c (ada_val_print): Update.
12267 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12268 (create_excep_cond_exprs): Update.
12269
c5c10118
TT		 122702019-04-08 Tom Tromey <tom@tromey.com>
12271
12272 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12273 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12274 (TRY, CATCH, END_CATCH): Remove some definitions.
12275 * common/common-exceptions.c: Don't use GDB_XCPT.
12276 (catcher_list_size): Remove.
12277 (throw_exception, throw_it): Simplify.
12278
4de283e4
TT		 122792019-04-05 Tom Tromey <tom@tromey.com>
12280
12281 Revert the header-sorting patch.
12282 * ft32-tdep.c: Revert.
12283 * frv-tdep.c: Revert.
12284 * frv-linux-tdep.c: Revert.
12285 * frame.c: Revert.
12286 * frame-unwind.c: Revert.
12287 * frame-base.c: Revert.
12288 * fork-child.c: Revert.
12289 * findvar.c: Revert.
12290 * findcmd.c: Revert.
12291 * filesystem.c: Revert.
12292 * filename-seen-cache.h: Revert.
12293 * filename-seen-cache.c: Revert.
12294 * fbsd-tdep.c: Revert.
12295 * fbsd-nat.h: Revert.
12296 * fbsd-nat.c: Revert.
12297 * f-valprint.c: Revert.
12298 * f-typeprint.c: Revert.
12299 * f-lang.c: Revert.
12300 * extension.h: Revert.
12301 * extension.c: Revert.
12302 * extension-priv.h: Revert.
12303 * expprint.c: Revert.
12304 * exec.h: Revert.
12305 * exec.c: Revert.
12306 * exceptions.c: Revert.
12307 * event-top.c: Revert.
12308 * event-loop.c: Revert.
12309 * eval.c: Revert.
12310 * elfread.c: Revert.
12311 * dwarf2read.h: Revert.
12312 * dwarf2read.c: Revert.
12313 * dwarf2loc.c: Revert.
12314 * dwarf2expr.h: Revert.
12315 * dwarf2expr.c: Revert.
12316 * dwarf2-frame.c: Revert.
12317 * dwarf2-frame-tailcall.c: Revert.
12318 * dwarf-index-write.h: Revert.
12319 * dwarf-index-write.c: Revert.
12320 * dwarf-index-common.c: Revert.
12321 * dwarf-index-cache.h: Revert.
12322 * dwarf-index-cache.c: Revert.
12323 * dummy-frame.c: Revert.
12324 * dtrace-probe.c: Revert.
12325 * disasm.h: Revert.
12326 * disasm.c: Revert.
12327 * disasm-selftests.c: Revert.
12328 * dictionary.c: Revert.
12329 * dicos-tdep.c: Revert.
12330 * demangle.c: Revert.
12331 * dcache.h: Revert.
12332 * dcache.c: Revert.
12333 * darwin-nat.h: Revert.
12334 * darwin-nat.c: Revert.
12335 * darwin-nat-info.c: Revert.
12336 * d-valprint.c: Revert.
12337 * d-namespace.c: Revert.
12338 * d-lang.c: Revert.
12339 * ctf.c: Revert.
12340 * csky-tdep.c: Revert.
12341 * csky-linux-tdep.c: Revert.
12342 * cris-tdep.c: Revert.
12343 * cris-linux-tdep.c: Revert.
12344 * cp-valprint.c: Revert.
12345 * cp-support.c: Revert.
12346 * cp-namespace.c: Revert.
12347 * cp-abi.c: Revert.
12348 * corelow.c: Revert.
12349 * corefile.c: Revert.
12350 * continuations.c: Revert.
12351 * completer.h: Revert.
12352 * completer.c: Revert.
12353 * complaints.c: Revert.
12354 * coffread.c: Revert.
12355 * coff-pe-read.c: Revert.
12356 * cli-out.h: Revert.
12357 * cli-out.c: Revert.
12358 * charset.c: Revert.
12359 * c-varobj.c: Revert.
12360 * c-valprint.c: Revert.
12361 * c-typeprint.c: Revert.
12362 * c-lang.c: Revert.
12363 * buildsym.c: Revert.
12364 * buildsym-legacy.c: Revert.
12365 * build-id.h: Revert.
12366 * build-id.c: Revert.
12367 * btrace.c: Revert.
12368 * bsd-uthread.c: Revert.
12369 * breakpoint.h: Revert.
12370 * breakpoint.c: Revert.
12371 * break-catch-throw.c: Revert.
12372 * break-catch-syscall.c: Revert.
12373 * break-catch-sig.c: Revert.
12374 * blockframe.c: Revert.
12375 * block.c: Revert.
12376 * bfin-tdep.c: Revert.
12377 * bfin-linux-tdep.c: Revert.
12378 * bfd-target.c: Revert.
12379 * bcache.c: Revert.
12380 * ax-general.c: Revert.
12381 * ax-gdb.h: Revert.
12382 * ax-gdb.c: Revert.
12383 * avr-tdep.c: Revert.
12384 * auxv.c: Revert.
12385 * auto-load.c: Revert.
12386 * arm-wince-tdep.c: Revert.
12387 * arm-tdep.c: Revert.
12388 * arm-symbian-tdep.c: Revert.
12389 * arm-pikeos-tdep.c: Revert.
12390 * arm-obsd-tdep.c: Revert.
12391 * arm-nbsd-tdep.c: Revert.
12392 * arm-nbsd-nat.c: Revert.
12393 * arm-linux-tdep.c: Revert.
12394 * arm-linux-nat.c: Revert.
12395 * arm-fbsd-tdep.c: Revert.
12396 * arm-fbsd-nat.c: Revert.
12397 * arm-bsd-tdep.c: Revert.
12398 * arch-utils.c: Revert.
12399 * arc-tdep.c: Revert.
12400 * arc-newlib-tdep.c: Revert.
12401 * annotate.h: Revert.
12402 * annotate.c: Revert.
12403 * amd64-windows-tdep.c: Revert.
12404 * amd64-windows-nat.c: Revert.
12405 * amd64-tdep.c: Revert.
12406 * amd64-sol2-tdep.c: Revert.
12407 * amd64-obsd-tdep.c: Revert.
12408 * amd64-obsd-nat.c: Revert.
12409 * amd64-nbsd-tdep.c: Revert.
12410 * amd64-nbsd-nat.c: Revert.
12411 * amd64-nat.c: Revert.
12412 * amd64-linux-tdep.c: Revert.
12413 * amd64-linux-nat.c: Revert.
12414 * amd64-fbsd-tdep.c: Revert.
12415 * amd64-fbsd-nat.c: Revert.
12416 * amd64-dicos-tdep.c: Revert.
12417 * amd64-darwin-tdep.c: Revert.
12418 * amd64-bsd-nat.c: Revert.
12419 * alpha-tdep.c: Revert.
12420 * alpha-obsd-tdep.c: Revert.
12421 * alpha-nbsd-tdep.c: Revert.
12422 * alpha-mdebug-tdep.c: Revert.
12423 * alpha-linux-tdep.c: Revert.
12424 * alpha-linux-nat.c: Revert.
12425 * alpha-bsd-tdep.c: Revert.
12426 * alpha-bsd-nat.c: Revert.
12427 * aix-thread.c: Revert.
12428 * agent.c: Revert.
12429 * addrmap.c: Revert.
12430 * ada-varobj.c: Revert.
12431 * ada-valprint.c: Revert.
12432 * ada-typeprint.c: Revert.
12433 * ada-tasks.c: Revert.
12434 * ada-lang.c: Revert.
12435 * aarch64-tdep.c: Revert.
12436 * aarch64-ravenscar-thread.c: Revert.
12437 * aarch64-newlib-tdep.c: Revert.
12438 * aarch64-linux-tdep.c: Revert.
12439 * aarch64-linux-nat.c: Revert.
12440 * aarch64-fbsd-tdep.c: Revert.
12441 * aarch64-fbsd-nat.c: Revert.
12442 * aarch32-linux-nat.c: Revert.
12443
d55e5aa6
TT		 124442019-04-05 Tom Tromey <tom@tromey.com>
12445
12446 * ft32-tdep.c: Sort headers.
12447 * frv-tdep.c: Sort headers.
12448 * frv-linux-tdep.c: Sort headers.
12449 * frame.c: Sort headers.
12450 * frame-unwind.c: Sort headers.
12451 * frame-base.c: Sort headers.
12452 * fork-child.c: Sort headers.
12453 * findvar.c: Sort headers.
12454 * findcmd.c: Sort headers.
12455 * filesystem.c: Sort headers.
12456 * filename-seen-cache.h: Sort headers.
12457 * filename-seen-cache.c: Sort headers.
12458 * fbsd-tdep.c: Sort headers.
12459 * fbsd-nat.h: Sort headers.
12460 * fbsd-nat.c: Sort headers.
12461 * f-valprint.c: Sort headers.
12462 * f-typeprint.c: Sort headers.
12463 * f-lang.c: Sort headers.
12464 * extension.h: Sort headers.
12465 * extension.c: Sort headers.
12466 * extension-priv.h: Sort headers.
12467 * expprint.c: Sort headers.
12468 * exec.h: Sort headers.
12469 * exec.c: Sort headers.
12470 * exceptions.c: Sort headers.
12471 * event-top.c: Sort headers.
12472 * event-loop.c: Sort headers.
12473 * eval.c: Sort headers.
12474 * elfread.c: Sort headers.
12475 * dwarf2read.h: Sort headers.
12476 * dwarf2read.c: Sort headers.
12477 * dwarf2loc.c: Sort headers.
12478 * dwarf2expr.h: Sort headers.
12479 * dwarf2expr.c: Sort headers.
12480 * dwarf2-frame.c: Sort headers.
12481 * dwarf2-frame-tailcall.c: Sort headers.
12482 * dwarf-index-write.h: Sort headers.
12483 * dwarf-index-write.c: Sort headers.
12484 * dwarf-index-common.c: Sort headers.
12485 * dwarf-index-cache.h: Sort headers.
12486 * dwarf-index-cache.c: Sort headers.
12487 * dummy-frame.c: Sort headers.
12488 * dtrace-probe.c: Sort headers.
12489 * disasm.h: Sort headers.
12490 * disasm.c: Sort headers.
12491 * disasm-selftests.c: Sort headers.
12492 * dictionary.c: Sort headers.
12493 * dicos-tdep.c: Sort headers.
12494 * demangle.c: Sort headers.
12495 * dcache.h: Sort headers.
12496 * dcache.c: Sort headers.
12497 * darwin-nat.h: Sort headers.
12498 * darwin-nat.c: Sort headers.
12499 * darwin-nat-info.c: Sort headers.
12500 * d-valprint.c: Sort headers.
12501 * d-namespace.c: Sort headers.
12502 * d-lang.c: Sort headers.
12503 * ctf.c: Sort headers.
12504 * csky-tdep.c: Sort headers.
12505 * csky-linux-tdep.c: Sort headers.
12506 * cris-tdep.c: Sort headers.
12507 * cris-linux-tdep.c: Sort headers.
12508 * cp-valprint.c: Sort headers.
12509 * cp-support.c: Sort headers.
12510 * cp-namespace.c: Sort headers.
12511 * cp-abi.c: Sort headers.
12512 * corelow.c: Sort headers.
12513 * corefile.c: Sort headers.
12514 * continuations.c: Sort headers.
12515 * completer.h: Sort headers.
12516 * completer.c: Sort headers.
12517 * complaints.c: Sort headers.
12518 * coffread.c: Sort headers.
12519 * coff-pe-read.c: Sort headers.
12520 * cli-out.h: Sort headers.
12521 * cli-out.c: Sort headers.
12522 * charset.c: Sort headers.
12523 * c-varobj.c: Sort headers.
12524 * c-valprint.c: Sort headers.
12525 * c-typeprint.c: Sort headers.
12526 * c-lang.c: Sort headers.
12527 * buildsym.c: Sort headers.
12528 * buildsym-legacy.c: Sort headers.
12529 * build-id.h: Sort headers.
12530 * build-id.c: Sort headers.
12531 * btrace.c: Sort headers.
12532 * bsd-uthread.c: Sort headers.
12533 * breakpoint.h: Sort headers.
12534 * breakpoint.c: Sort headers.
12535 * break-catch-throw.c: Sort headers.
12536 * break-catch-syscall.c: Sort headers.
12537 * break-catch-sig.c: Sort headers.
12538 * blockframe.c: Sort headers.
12539 * block.c: Sort headers.
12540 * bfin-tdep.c: Sort headers.
12541 * bfin-linux-tdep.c: Sort headers.
12542 * bfd-target.c: Sort headers.
12543 * bcache.c: Sort headers.
12544 * ax-general.c: Sort headers.
12545 * ax-gdb.h: Sort headers.
12546 * ax-gdb.c: Sort headers.
12547 * avr-tdep.c: Sort headers.
12548 * auxv.c: Sort headers.
12549 * auto-load.c: Sort headers.
12550 * arm-wince-tdep.c: Sort headers.
12551 * arm-tdep.c: Sort headers.
12552 * arm-symbian-tdep.c: Sort headers.
12553 * arm-pikeos-tdep.c: Sort headers.
12554 * arm-obsd-tdep.c: Sort headers.
12555 * arm-nbsd-tdep.c: Sort headers.
12556 * arm-nbsd-nat.c: Sort headers.
12557 * arm-linux-tdep.c: Sort headers.
12558 * arm-linux-nat.c: Sort headers.
12559 * arm-fbsd-tdep.c: Sort headers.
12560 * arm-fbsd-nat.c: Sort headers.
12561 * arm-bsd-tdep.c: Sort headers.
12562 * arch-utils.c: Sort headers.
12563 * arc-tdep.c: Sort headers.
12564 * arc-newlib-tdep.c: Sort headers.
12565 * annotate.h: Sort headers.
12566 * annotate.c: Sort headers.
12567 * amd64-windows-tdep.c: Sort headers.
12568 * amd64-windows-nat.c: Sort headers.
12569 * amd64-tdep.c: Sort headers.
12570 * amd64-sol2-tdep.c: Sort headers.
12571 * amd64-obsd-tdep.c: Sort headers.
12572 * amd64-obsd-nat.c: Sort headers.
12573 * amd64-nbsd-tdep.c: Sort headers.
12574 * amd64-nbsd-nat.c: Sort headers.
12575 * amd64-nat.c: Sort headers.
12576 * amd64-linux-tdep.c: Sort headers.
12577 * amd64-linux-nat.c: Sort headers.
12578 * amd64-fbsd-tdep.c: Sort headers.
12579 * amd64-fbsd-nat.c: Sort headers.
12580 * amd64-dicos-tdep.c: Sort headers.
12581 * amd64-darwin-tdep.c: Sort headers.
12582 * amd64-bsd-nat.c: Sort headers.
12583 * alpha-tdep.c: Sort headers.
12584 * alpha-obsd-tdep.c: Sort headers.
12585 * alpha-nbsd-tdep.c: Sort headers.
12586 * alpha-mdebug-tdep.c: Sort headers.
12587 * alpha-linux-tdep.c: Sort headers.
12588 * alpha-linux-nat.c: Sort headers.
12589 * alpha-bsd-tdep.c: Sort headers.
12590 * alpha-bsd-nat.c: Sort headers.
12591 * aix-thread.c: Sort headers.
12592 * agent.c: Sort headers.
12593 * addrmap.c: Sort headers.
12594 * ada-varobj.c: Sort headers.
12595 * ada-valprint.c: Sort headers.
12596 * ada-typeprint.c: Sort headers.
12597 * ada-tasks.c: Sort headers.
12598 * ada-lang.c: Sort headers.
12599 * aarch64-tdep.c: Sort headers.
12600 * aarch64-ravenscar-thread.c: Sort headers.
12601 * aarch64-newlib-tdep.c: Sort headers.
12602 * aarch64-linux-tdep.c: Sort headers.
12603 * aarch64-linux-nat.c: Sort headers.
12604 * aarch64-fbsd-tdep.c: Sort headers.
12605 * aarch64-fbsd-nat.c: Sort headers.
12606 * aarch32-linux-nat.c: Sort headers.
12607
699bd4cf
TT		 126082019-04-04 Tom Tromey <tom@tromey.com>
12609
12610 * varobj.c (varobj_create): Update.
12611 * rust-exp.y (struct rust_parser) <update_innermost_block,
12612 lookup_symbol>: New methods.
12613 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12614 Rename.
12615 (rust_parser::rust_lookup_type)
12616 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12617 * printcmd.c (display_command, do_one_display): Update.
12618 * parser-defs.h (struct parser_state) <parser_state>: Add
12619 "tracker" parameter.
12620 (block_tracker): New member.
12621 (class innermost_block_tracker) <innermost_block_tracker>: Add
12622 "types" parameter.
12623 <reset>: Remove method.
12624 (innermost_block): Don't declare.
12625 (null_post_parser): Update.
12626 * parse.c (innermost_block): Remove global.
12627 (write_dollar_variable): Update.
12628 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12629 Remove "tracker_types" parameter.
12630 (parse_expression): Add "tracker" parameter.
12631 (parse_expression_for_completion): Update.
12632 (null_post_parser): Add "tracker" parameter.
12633 * p-exp.y: Update rules.
12634 * m2-exp.y: Update rules.
12635 * language.h (struct language_defn) <la_post_parser>: Add
12636 "tracker" parameter.
12637 * go-exp.y: Update rules.
12638 * f-exp.y: Update rules.
12639 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12640 parameter.
12641 * d-exp.y: Update rules.
12642 * c-exp.y: Update rules.
12643 * breakpoint.c (set_breakpoint_condition): Create an
12644 innermost_block_tracker.
12645 (watch_command_1): Likewise.
12646 * ada-lang.c (resolve): Add "tracker" parameter.
12647 (resolve_subexp): Likewise.
12648 * ada-exp.y (write_var_from_sym): Update.
12649
dac43e32
TT		 126502019-04-04 Tom Tromey <tom@tromey.com>
12651
12652 * type-stack.h: New file.
12653 * type-stack.c: New file.
12654 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12655 type-stack.h.
12656 (insert_into_type_stack, insert_type, push_type, push_type_int)
12657 (insert_type_address_space, pop_type, pop_type_int)
12658 (pop_typelist, pop_type_stack, append_type_stack)
12659 (push_type_stack, get_type_stack, push_typelist)
12660 (follow_type_instance_flags, follow_types): Don't declare.
12661 * parse.c (type_stack): Remove global.
12662 (parse_exp_in_context): Update.
12663 (insert_into_type_stack, insert_type, push_type, push_type_int)
12664 (insert_type_address_space, pop_type, pop_type_int)
12665 (pop_typelist, pop_type_stack, append_type_stack)
12666 (push_type_stack, get_type_stack, push_typelist)
12667 (follow_type_instance_flags, follow_types): Remove (moved to
12668 type-stack.c).
12669 * f-exp.y (type_stack): New global.
12670 Update rules.
12671 (push_kind_type, f_parse): Update.
12672 * d-exp.y (type_stack): New global.
12673 Update rules.
12674 (d_parse): Update.
12675 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12676 Update rules.
12677 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12678 (HFILES_NO_SRCDIR): Add type-stack.h.
12679
2a612529
TT		 126802019-04-04 Tom Tromey <tom@tromey.com>
12681
12682 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12683 (rust_parser::convert_ast_to_expression, rust_parse)
12684 (rust_lex_test_completion, rust_lex_tests): Update.
12685 * parser-defs.h (struct expr_completion_state): New.
12686 (struct parser_state) <parser_state>: Add completion parameter.
12687 <mark_struct_expression, mark_completion_tag>: New methods.
12688 <parse_completion, m_completion_state>: New members.
12689 (prefixify_expression, null_post_parser): Update.
12690 (mark_struct_expression, mark_completion_tag): Don't declare.
12691 * parse.c (parse_completion, expout_last_struct)
12692 (expout_tag_completion_type, expout_completion_name): Remove
12693 globals.
12694 (parser_state::mark_struct_expression)
12695 (parser_state::mark_completion_tag): Now methods.
12696 (prefixify_expression): Add last_struct parameter.
12697 (prefixify_subexp): Likewise.
12698 (parse_exp_1): Update.
12699 (parse_exp_in_context): Add cstate parameter. Update.
12700 (parse_expression_for_completion): Create an
12701 expr_completion_state.
12702 (null_post_parser): Add "completion" parameter.
12703 * p-exp.y: Update rules.
12704 (yylex): Update.
12705 * language.h (struct language_defn) <la_post_parser>: Add
12706 "completing" parameter.
12707 * go-exp.y: Update rules.
12708 (lex_one_token): Update.
12709 * expression.h (parse_completion): Don't declare.
12710 * d-exp.y: Update rules.
12711 (lex_one_token): Update rules.
12712 * c-exp.y: Update rules.
12713 (lex_one_token): Update.
12714 * ada-lang.c (resolve): Add "parse_completion" parameter.
12715 (resolve_subexp): Likewise.
12716 (ada_resolve_function): Likewise.
12717
43476f0b
TT		 127182019-04-04 Tom Tromey <tom@tromey.com>
12719
12720 * parser-defs.h (struct parser_state) <start_arglist,
12721 end_arglist>: New methods.
12722 <arglist_len, m_funcall_chain>: New members.
12723 (arglist_len, start_arglist, end_arglist): Don't declare.
12724 * parse.c (arglist_len, funcall_chain): Remove global.
12725 (start_arglist, end_arglist): Remove functions.
12726 (parse_exp_in_context): Update.
12727 * p-exp.y: Update rules.
12728 * m2-exp.y: Update rules.
12729 * go-exp.y: Update rules.
12730 * f-exp.y: Update rules.
12731 * d-exp.y: Update rules.
12732 * c-exp.y: Update rules.
12733
5776fca3
TT		 127342019-04-04 Tom Tromey <tom@tromey.com>
12735
12736 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12737 lex_operator, push_back>: New methods.
12738 Update all rules.
12739 (rust_parser::lex_hex, lex_escape): Rename and update.
12740 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12741 (rust_parser::lex_operator): Rename and update.
12742 (rust_parser::lex_number, rustyylex, rustyyerror)
12743 (rust_lex_test_init, rust_lex_test_sequence)
12744 (rust_lex_test_push_back, rust_lex_tests): Update.
12745 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12746 parameter.
12747 <lexptr, prev_lexptr>: New members.
12748 (lexptr, prev_lexptr): Don't declare.
12749 * parse.c (lexptr, prev_lexptr): Remove globals.
12750 (parse_exp_in_context): Update.
12751 * p-exp.y (yylex, yyerror): Update.
12752 * m2-exp.y (parse_number, yylex, yyerror): Update.
12753 * go-exp.y (lex_one_token, yyerror): Update.
12754 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12755 * d-exp.y (lex_one_token, yyerror): Update.
12756 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12757 (lex_one_token, yyerror): Update.
12758 * ada-lex.l (YY_INPUT): Update.
12759 (rewind_to_char): Update.
12760 * ada-exp.y (yyerror): Update.
12761
8621b685
TT		 127622019-04-04 Tom Tromey <tom@tromey.com>
12763
12764 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12765 * parser-defs.h (struct parser_state) <parser_state>: Add new
12766 parameter.
12767 <comma_terminates>: New member.
12768 (comma_terminates): Don't declare global.
12769 * parse.c (comma_terminates): Remove global.
12770 (parse_exp_in_context): Update.
12771 * p-exp.y (yylex): Update.
12772 * m2-exp.y (yylex): Update.
12773 * go-exp.y (lex_one_token): Update.
12774 * f-exp.y (yylex): Update.
12775 * d-exp.y (lex_one_token): Update.
12776 * c-exp.y (lex_one_token): Update.
12777 * ada-lex.l: Update.
12778
28aaf3fd
TT		 127792019-04-04 Tom Tromey <tom@tromey.com>
12780
12781 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12782 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12783 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12784 * parser-defs.h (paren_depth): Don't declare.
12785 * parse.c (paren_depth): Remove global.
12786 (parse_exp_in_context): Update.
12787 * p-exp.y (paren_depth): New global.
12788 (pascal_parse): Initialize it.
12789 * m2-exp.y (paren_depth): New global.
12790 (m2_parse): Initialize it.
12791 * go-exp.y (paren_depth): New global.
12792 (go_parse): Initialize it.
12793 * f-exp.y (paren_depth): New global.
12794 (f_parse): Initialize it.
12795 * d-exp.y (paren_depth): New global.
12796 (d_parse): Initialize it.
12797 * c-exp.y (paren_depth): New global.
12798 (c_parse): Initialize it.
12799 * ada-lex.l (paren_depth): New global.
12800 (lexer_init): Initialize it.
12801
1e58a4a4
TT		 128022019-04-04 Tom Tromey <tom@tromey.com>
12803
12804 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12805 (rust_parser::convert_ast_to_type)
12806 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12807 * parser-defs.h (struct parser_state) <parser_state>: Add
12808 parameters. Initialize new members.
12809 <expression_context_block, expression_context_pc>: New members.
12810 * parse.c (expression_context_block, expression_context_pc):
12811 Remove globals.
12812 (parse_exp_in_context): Update.
12813 * p-exp.y: Update all rules.
12814 (yylex): Update.
12815 * m2-exp.y: Update all rules.
12816 (yylex): Update.
12817 * go-exp.y (yylex): Update.
12818 * f-exp.y (yylex): Update.
12819 * d-exp.y: Update all rules.
12820 (yylex): Update.
12821 * c-exp.y: Update all rules.
12822 (lex_one_token, classify_name, yylex, c_parse): Update.
12823 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12824
37eedb39
TT		 128252019-04-04 Tom Tromey <tom@tromey.com>
12826
12827 * gdbarch.h, gdbarch.c: Rebuild.
12828 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12829 * stap-probe.h:
12830 (struct stap_parse_info): Replace "parser_state" with
12831 "expr_builder".
12832 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12833 (parser_state): New class.
12834 * parse.c (expr_builder): Rename.
12835 (expr_builder::release): Rename.
12836 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12837 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12838 (write_exp_elt_longcst, write_exp_elt_floatcst)
12839 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12840 (write_exp_string_vector, write_exp_bitstring)
12841 (write_exp_msymbol, mark_struct_expression)
12842 (write_dollar_variable)
12843 (insert_type_address_space, increase_expout_size): Replace
12844 "parser_state" with "expr_builder".
12845 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12846 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12847 "parser_state" with "expr_builder".
12848
73923d7e
TT		 128492019-04-04 Tom Tromey <tom@tromey.com>
12850
12851 * rust-exp.y: Replace "parse_language" with method call.
12852 * p-exp.y:
12853 (yylex): Replace "parse_language" with method call.
12854 * m2-exp.y:
12855 (yylex): Replace "parse_language" with method call.
12856 * go-exp.y (classify_name): Replace "parse_language" with method
12857 call.
12858 * f-exp.y (yylex): Replace "parse_language" with method call.
12859 * d-exp.y (lex_one_token): Replace "parse_language" with method
12860 call.
12861 * c-exp.y:
12862 (lex_one_token, classify_name, yylex): Replace "parse_language"
12863 with method call.
12864 * ada-exp.y (find_primitive_type, type_char)
12865 (type_system_address): Replace "parse_language" with method call.
12866
fa9f5be6
TT		 128672019-04-04 Tom Tromey <tom@tromey.com>
12868
12869 * rust-exp.y: Replace "parse_gdbarch" with method call.
12870 * parse.c (write_dollar_variable, insert_type_address_space):
12871 Replace "parse_gdbarch" with method call.
12872 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12873 call.
12874 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12875 call.
12876 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12877 "parse_gdbarch" with method call.
12878 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12879 with method call.
12880 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12881 "parse_gdbarch" with method call.
12882 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12883 "parse_gdbarch" with method call.
12884 * c-exp.y (parse_type, parse_number, classify_name): Replace
12885 "parse_gdbarch" with method call.
12886 * ada-lex.l: Replace "parse_gdbarch" with method call.
12887 * ada-exp.y (parse_type, find_primitive_type, type_char)
12888 (type_system_address): Replace "parse_gdbarch" with method call.
12889
1201a264
TT		 128902019-04-04 Tom Tromey <tom@tromey.com>
12891
12892 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12893 * stap-probe.c (stap_parse_argument): Update.
12894 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12895 initial_size parameter.
12896 * rust-exp.y (rust_lex_tests): Update.
12897 * parse.c (parser_state): Update.
12898 (parse_exp_in_context): Update.
12899 * parser-defs.h (struct parser_state) <parser_state>: Remove
12900 "initial_size" parameter.
12901
e3980ce2
TT		 129022019-04-04 Tom Tromey <tom@tromey.com>
12903
12904 * parser-defs.h (increase_expout_size): Don't declare.
12905 * parse.c (increase_expout_size): Now static.
12906
e9f8e3f1
TS		 129072019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12908
12909 * gnu-nat.c (gnu_nat_target::wait): Fix
12910 target_waitstatus_to_string call.
12911
d7df6549
AB		 129122019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12913
12914 * eval.c (evaluate_subexp_standard): Handle internal functions
12915 during Fortran function call handling.
12916
8bdc1658
AB		 129172019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12918
12919 * NEWS: Mention new internal functions.
12920 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12921 (read_base_type): Use dwarf2_init_complex_target_type.
12922 * value.c (creal_internal_fn): New function.
12923 (cimag_internal_fn): New function.
12924 (_initialize_values): Register new internal functions.
12925
c29705b7
PW		 129262019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12927
12928 * infrun.c (stop_all_threads): If debug_infrun, always
12929 trace the wait status after wait_one, using
12930 target_waitstatus_to_string and target_pid_to_str.
12931 (handle_inferior_event): Replace various trace of
12932 wait status kind by a single trace.
12933 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12934 wait status kind image by target_waitstatus_to_string.
12935 * target/waitstatus.c (target_waitstatus_to_string): Fix
12936 obsolete comment.
12937
05caa1d2
TT		 129382019-04-01 Tom Tromey <tromey@adacore.com>
12939
12940 PR symtab/23331:
12941 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12942
9d1447e0
SDJ		 129432019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12944 Pedro Alves <palves@redhat.com>
12945
12946 * top.c (quit_force): Call 'finalize_values'.
12947 * value.c (finalize_values): New function.
12948 * value.h (finalize_values): Declare.
12949
7734102d
EZ		 129502019-03-30 Eli Zaretskii <eliz@gnu.org>
12951
12952 * NEWS: Announce $_gdb_major and $_gdb_minor.
12953
12954 * top.c (init_gdb_version_vars): New function.
12955 (gdb_init): Call init_gdb_version_vars.
12956
188e1fa9
TT		 129572019-03-29 Tom Tromey <tromey@adacore.com>
12958
12959 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12960 help text. Remove dead code.
12961
2880242d
KS		 129622019-03-29 Keith Seitz <keiths@redhat.com>
12963
12964 From Siddhesh Poyarekar:
12965 * f-lang.h (f77_get_upperbound): Return LONGEST.
12966 (f77_get_lowerbound): Likewise.
12967 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12968 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12969 print them.
12970 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12971 plongest to format print it.
12972 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12973 (f77_get_upperbound): Likewise.
12974 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12975 LOWER_BOUND to LONGEST.
12976 (f77_create_arrayprint_offset_tbl): Likewise.
12977
cc1defb1
KS		 129782019-03-29 Keith Seitz <keiths@redhat.com>
12979
12980 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12981 %s/pulongest for TYPE_LENGTH instead of %d in format
12982 strings.
12983 * ada-typerint.c (ada_print_type): Likewise.
12984 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12985 * compile/compile-c-support.c (generate_register_struct): Likewise.
12986 * gdbtypes.c (recursive_dump_type): Likewise.
12987 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12988 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12989 instead of %d in format strings.
12990 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12991 to std::min to ULONGEST.
12992 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12993 instead of %d in format strings.
12994 * tracepoint.c (info_scope_command): Likewise.
12995 * typeprint.c (print_offset_data::update)
12996 (print_offset_data::finish): Likewise.
12997 * xtensa-tdep.c (xtensa_store_return_value)
12998 (xtensa_push_dummy_call): Likewise.
12999
e432ccf1
JT		 130002019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13001
13002 * windows-nat.c (display_selector): Fixed format specifications
13003 for 64-bit Cygwin.
13004
65d2b333
PW		 130052019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13006
13007 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13008
f489207e
SL		 130092019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13010
13011 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13012 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13013 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13014 (nios2_linux_init_abi): Install it.
13015
bffa1015
AH		 130162019-03-28 Alan Hayward <alan.hayward@arm.com>
13017
13018 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13019
fc96163a
AH		 130202019-03-28 Alan Hayward <alan.hayward@arm.com>
13021
13022 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13023
20dc7e9b
PW		 130242019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13025 Tom Tromey <tromey@adacore.com>
13026
13027 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13028
7f5331a8
JB		 130292019-03-26 Joel Brobecker <brobecker@adacore.com>
13030
13031 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13032 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13033 method to compute the bounds of range types. Also print "[evaluated]"
13034 if the bounds' values come from a dynamic evaluation.
13035
18c77628
AB		 130362019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13037
13038 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13039 whitespace when pretty printing is on.
13040
53c973f2
AH		 130412019-03-26 Alan Hayward <alan.hayward@arm.com>
13042
e79be6e5 13043 * ppc-linux-nat.c: Add include.
53c973f2 13044
d851aa71
AH		 130452019-03-26 Alan Hayward <alan.hayward@arm.com>
13046
e79be6e5 13047 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13048
2fe7bab7
AH		 130492019-03-26 Alan Hayward <alan.hayward@arm.com>
13050
e79be6e5 13051 * arm-linux-nat.c: Add include.
2fe7bab7 13052
068ef30e
SM		 130532019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13054
13055 * source-cache.c (source_cache::get_source_lines): Re-read
13056 fullname after calling open_source_file.
13057
81a24d04
JB		 130582019-03-25 John Baldwin <jhb@FreeBSD.org>
13059
13060 * NEWS: Mention TLS support for FreeBSD.
13061
79e7ae11
TT		 130622019-03-25 Tom Tromey <tromey@adacore.com>
13063
13064 * minsyms.c (BUNCH_SIZE): Update comment.
13065 (~minimal_symbol_reader): Remove old comment.
13066 (compact_minimal_symbols): Update comment.
13067 (minimal_symbol_reader::install): Remove old comment. Update
13068 other comments.
13069
d45963c2
AH		 130702019-03-25 Alan Hayward <alan.hayward@arm.com>
13071
13072 * s390-linux-nat.c: Add include.
13073
0f83012e
AH		 130742019-03-25 Alan Hayward <alan.hayward@arm.com>
13075
13076 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13077 Call linux_get_hwcap.
13078 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13079 Likewise.
13080 (aarch64_linux_get_hwcap): Remove function.
13081 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13082 declaration.
13083 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13084 linux_get_hwcap.
13085 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13086 * linux-tdep.c (linux_get_hwcap): Add function.
13087 (linux_get_hwcap2): Likewise.
13088 * linux-tdep.h (linux_get_hwcap): Add declaration.
13089 (linux_get_hwcap2): Likewise.
13090 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13091 (ppc_linux_get_hwcap2): Likewise.
13092 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13093 linux_get_hwcap.
13094 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13095 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13096 (ppc_linux_nat_target::read_description): Likewise.
13097 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13098 * s390-linux-nat.c: Likewise.
13099 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13100
6640a367
TT		 131012019-03-24 Tom Tromey <tom@tromey.com>
13102
13103 * ada-lang.c (standard_lookup): Simplify initialization.
13104 (ada_lookup_symbol_nonlocal): Simplify return.
13105 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13106 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13107 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13108 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13109 initialization.
13110 * solib.c (solib_global_lookup): Simplify.
13111 * symtab.c (null_block_symbol): Remove.
13112 (symbol_cache_lookup): Simplify returns.
13113 (lookup_language_this): Simplify returns.
13114 (lookup_symbol_aux): Simplify return.
13115 (lookup_local_symbol): Simplify returns.
13116 (lookup_global_symbol_from_objfile): Simplify return.
13117 (lookup_symbol_in_objfile_symtabs)
13118 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13119 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13120 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13121 * cp-namespace.c (cp_lookup_bare_symbol)
13122 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13123 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13124 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13125 (cp_lookup_symbol_via_imports): Simplify initialization.
13126 (find_symbol_in_baseclass): Likewise.
13127 * symtab.h (null_block_symbol): Remove.
13128 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13129 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13130 (d_lookup_symbol_module): Likewise.
13131 (find_symbol_in_baseclass): Simplify initialization.
13132
a930ebcd
TT		 131332019-03-24 Tom Tromey <tom@tromey.com>
13134
13135 * expression.h: Don't include symtab.h.
13136 (struct block): Forward declare.
13137
582942f4
TT		 131382019-03-24 Tom Tromey <tom@tromey.com>
13139
13140 * c-exp.y (typebase): Remove casts.
13141 * gdbtypes.c (lookup_unsigned_typename, )
13142 (lookup_signed_typename): Remove cast.
13143 * eval.c (parse_to_comma_and_eval): Remove cast.
13144 * parse.c (write_dollar_variable): Remove cast.
13145 * block.h (struct block) <superblock>: Now const.
13146 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13147 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13148 (map_block): Make "block" const.
13149 * symfile.h (struct quick_symbol_functions)
13150 <map_matching_symbols>: Constify block argument to "callback".
13151 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13152 const.
13153 (find_pc_sect_compunit_symtab): Make "b" const.
13154 (find_symbol_at_address): Likewise.
13155 (search_symbols): Likewise.
13156 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13157 (dw2_debug_names_lookup_symbol): Likewise.
13158 (dw2_map_matching_symbols): Update.
13159 * p-valprint.c (pascal_val_print): Remove "block".
13160 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13161 (aux_add_nonlocal_symbols): Make "block" const.
13162 (resolve_subexp): Remove cast.
13163 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13164 const.
13165 (iterate_over_file_blocks): Likewise.
13166 * f-exp.y (%union) <bval>: Remove.
13167 * coffread.c (patch_opaque_types): Make "b" const.
13168 * spu-tdep.c (spu_catch_start): Make "block" const.
13169 * c-valprint.c (print_unpacked_pointer): Remove "block".
13170 * symmisc.c (dump_symtab_1): Make "b" const.
13171 (block_depth): Make "block" const.
13172 * d-exp.y (%union) <bval>: Remove.
13173 * cp-support.h (cp_lookup_rtti_type): Update.
13174 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13175 * psymtab.c (psym_lookup_symbol): Make "block" const.
13176 (maintenance_check_psymtabs): Make "b" const.
13177 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13178 (enumerate_locals, enumerate_args): Update.
13179 * python/py-symtab.c (stpy_global_block): Make "block" const.
13180 (stpy_static_block): Likewise.
13181 * inline-frame.c (block_starting_point_at): Make "new_block"
13182 const.
13183 * block.c (find_block_in_blockvector): Make return type const.
13184 (blockvector_for_pc_sect): Make "b" const.
13185 (find_block_in_blockvector): Make "b" const.
13186
7ad417dd
TT		 131872019-03-23 Tom Tromey <tom@tromey.com>
13188
13189 * varobj.c (varobj_create): Update.
13190 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13191 * printcmd.c (display_command, do_one_display): Don't reset
13192 innermost_block.
13193 * parser-defs.h (enum innermost_block_tracker_type): Move to
13194 expression.h.
13195 (innermost_block): Update comment.
13196 * parse.c (parse_exp_1): Add tracker_types parameter.
13197 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13198 tracker_types parameter. Reset innermost_block.
13199 (parse_exp_in_context): Remove.
13200 (parse_expression_for_completion): Update.
13201 * objfiles.c (~objfile): Don't reset expression_context_block or
13202 innermost_block.
13203 * expression.h (enum innermost_block_tracker_type): Move from
13204 parser-defs.h.
13205 (parse_exp_1): Add tracker_types parameter.
13206 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13207 reset innermost_block.
13208
b366c208
TT		 132092019-03-23 Tom Tromey <tom@tromey.com>
13210
13211 * objfiles.h: Include bcache.h.
13212
9bb9b2f9
TT		 132132019-03-23 Tom Tromey <tom@tromey.com>
13214
13215 * linespec.c (get_current_search_block): Use
13216 scoped_restore_current_language.
13217 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13218
59c28372
AH		 132192019-03-22 Alan Hayward <alan.hayward@arm.com>
13220 Jiong Wang <jiong.wang@arm.com>
13221
13222 * aarch64-linux-tdep.c
13223 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13224 section.
13225 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13226
17e116a7
AH		 132272019-03-22 Alan Hayward <alan.hayward@arm.com>
13228 Jiong Wang <jiong.wang@arm.com>
13229
13230 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13231 instructions.
13232 (aarch64_analyze_prologue_test): Add PACIASP test.
13233 (aarch64_prologue_prev_register): Unmask PC value.
13234
11e1b75f
AH		 132352019-03-22 Alan Hayward <alan.hayward@arm.com>
13236 Jiong Wang <jiong.wang@arm.com>
13237
13238 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13239 (aarch64_dwarf2_prev_register): Unmask PC value.
13240 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13241 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13242 DW_CFA_AARCH64_negate_ra_state.
13243 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13244
34dcc7cf
AH		 132452019-03-22 Alan Hayward <alan.hayward@arm.com>
13246 Jiong Wang <jiong.wang@arm.com>
13247
13248 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13249 registers.
13250 (aarch64_pseudo_register_name): Likewise.
13251 (aarch64_pseudo_register_type): Likewise.
13252 (aarch64_pseudo_register_reggroup_p): Likewise.
13253 (aarch64_gdbarch_init): Add pauth registers.
13254 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13255 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13256 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13257 (struct gdbarch_tdep): Add regnum for ra_state.
13258
1ef53e6b
AH		 132592019-03-22 Alan Hayward <alan.hayward@arm.com>
13260 Jiong Wang <jiong.wang@arm.com>
13261
13262 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13263
76bed0fd
AH		 132642019-03-22 Alan Hayward <alan.hayward@arm.com>
13265 Jiong Wang <jiong.wang@arm.com>
13266
13267 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13268 function.
13269 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13270 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13271 (aarch64_gdbarch_init): Add puth registers.
13272 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13273 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13274 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13275
ee4fbcfa
AH		 132762019-03-22 Alan Hayward <alan.hayward@arm.com>
13277 Jiong Wang <jiong.wang@arm.com>
13278
13279 * aarch64-linux-nat.c
13280 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13281 * aarch64-linux-tdep.c
13282 (aarch64_linux_core_read_description): Likewise.
13283 (aarch64_linux_get_hwcap): New function.
13284 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13285 (aarch64_linux_get_hwcap): New declaration.
13286
6dc0ebde
AH		 132872019-03-22 Alan Hayward <alan.hayward@arm.com>
13288 Jiong Wang <jiong.wang@arm.com>
13289
13290 * aarch64-linux-nat.c
13291 (aarch64_linux_nat_target::read_description): Add pauth param.
13292 * aarch64-linux-tdep.c
13293 (aarch64_linux_core_read_description): Likewise.
13294 * aarch64-tdep.c (struct target_desc): Add in pauth.
13295 (aarch64_read_description): Add pauth param.
13296 (aarch64_gdbarch_init): Likewise.
13297 * aarch64-tdep.h (aarch64_read_description): Likewise.
13298 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13299 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13300 * features/Makefile: Add new files.
13301 * features/aarch64-pauth.c: New file.
13302 * features/aarch64-pauth.xml: New file.
13303
595915c1
TT		 133042019-03-20 Tom Tromey <tromey@adacore.com>
13305
13306 * infrun.c (handle_inferior_event): Rename from
13307 handle_inferior_event_1. Create a scoped_value_mark.
13308 (handle_inferior_event): Remove.
13309
4c7d57e7
TT		 133102019-03-19 Tom Tromey <tromey@adacore.com>
13311
13312 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13313 * infrun.h (print_stop_event): Add "displays" parameter.
13314 * infrun.c (print_stop_event): Add "displays" parameter.
13315
cb246234
PA		 133162019-03-19 Pedro Alves <palves@redhat.com>
13317
13318 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13319 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13320 to -1. Fix TABs vs spaces.
13321 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13322 * tui/tui-out.h (tui_ui_out) Add intro comments.
13323 <m_line, m_start_of_line>: In-class initialize, and add describing
13324 comment.
13325
3a0e45b2
AH		 133262019-03-18 Alan Hayward <alan.hayward@arm.com>
13327
13328 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13329 variable names.
13330 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13331
5371b850
PA		 133322019-03-18 Pedro Alves <palves@redhat.com>
13333 Eli Zaretskii <eliz@gnu.org>
13334
13335 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13336 m_line and m_start_of_line.
13337
b17c4cd0
EZ		 133382019-03-18 Eli Zaretskii <eliz@gnu.org>
13339
13340 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13341 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13342 it returns a newline. This fixes a regression in TU mode, whereby
13343 the next line is output on the same screen line as the user input.
13344
4bd56d18
TT		 133452019-03-18 Tom Tromey <tromey@adacore.com>
13346
13347 * minsyms.c (minimal_symbol_reader::install): Remove call to
13348 obstack_blank.
13349
55c10aca
PA		 133502019-03-18 Pedro Alves <palves@redhat.com>
13351
13352 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13353 New globals.
13354 (apply_style): New, factored out from ...
13355 (apply_ansi_escape): ... this. Handle reverse video mode.
13356 (tui_set_reverse_mode): New function.
13357 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13358 * tui/tui-winsource.c (tui_show_source_line): Use
13359 tui_set_reverse_mode instead of setting A_STANDOUT.
13360 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13361 New setter methods.
13362
647bb750
HD		 133632019-03-18 Hannes Domani <ssbssa@yahoo.de>
13364
13365 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13366 Handle tabs.
13367
bff8c71f
TT		 133682019-03-18 Tom Tromey <tromey@adacore.com>
13369
13370 * ada-lang.c (empty_array): Add "high" parameter.
13371 (ada_evaluate_subexp): Update.
13372
58785d98
ST		 133732019-03-17 Sergei Trofimovich <siarheit@google.com>
13374
13375 * unittests/string_view-selftests.c: Define
13376 _initialize_string_view_selftests unconditionally.
13377
d4cbef22
ВМ		 133782019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13379
13380 PR gdb/24350
13381 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13382
fce4c071
ВМ		 133832019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13384
13385 PR gdb/24351
13386 * windows-nat.c (display_selector): Fix format specifiers.
13387
f7f0a123
EZ		 133882019-03-17 Eli Zaretskii <eliz@gnu.org>
13389
13390 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13391 tui_refill_source_window instead of tui_refresh_win, to update the
13392 current execution line. This fixes redisplay of the current line
13393 when stepping through the code with "next" or "step".
13394
ab42892f
EZ		 133952019-03-16 Eli Zaretskii <eliz@gnu.org>
13396
13397 * source-cache.c (source_cache::get_source_lines): Call
13398 find_source_lines to initialize s->nlines. This fixes vertical
13399 scrolling of TUI source window when the DOWN arrow is pressed.
13400
8d8c087f
PW		 134012019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13402
13403 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13404 linux-thread-db.c (_initialize_thread_db): Likewise.
13405
798e1c30
EZ		 134062019-03-16 Eli Zaretskii <eliz@gnu.org>
13407
13408 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13409 wclrtoeol in tui_show_source_line". This reverts changes made in
13410 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13411
eefba3da
TT		 134122019-03-15 Tom Tromey <tom@tromey.com>
13413
13414 * symtab.h (struct minimal_symbol): Derive from
13415 general_symbol_info.
13416 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13417 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13418 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13419 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13420 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13421 (MSYMBOL_SEARCH_NAME): Update.
13422 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13423 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13424 * minsyms.c (minimal_symbol_reader::record_full): Update.
13425
0de2420c
TT		 134262019-03-15 Tom Tromey <tom@tromey.com>
13427
13428 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13429
042d75e4
TT		 134302019-03-15 Tom Tromey <tom@tromey.com>
13431
13432 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13433 unique_xmalloc_ptr.
13434 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13435 Update.
13436 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13437 (build_minimal_symbol_hash_tables)
13438 (minimal_symbol_reader::install): Update.
13439
db92718b
TT		 134402019-03-15 Tom Tromey <tom@tromey.com>
13441
13442 * symtab.c (create_demangled_names_hash): Update.
13443 (symbol_set_names): Update.
13444 * objfiles.h (struct objfile_per_bfd_storage)
13445 <demangled_names_hash>: Now an htab_up.
13446 * objfiles.c (objfile_per_bfd_storage): Simplify.
13447
d6797f46
TT		 134482019-03-15 Tom Tromey <tom@tromey.com>
13449
13450 * objfiles.h (struct objfile_per_bfd_storage): Declare
13451 destructor.
13452 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13453 New.
13454 (get_objfile_bfd_data): Use new. Don't initialize
13455 language_of_main.
13456 (free_objfile_per_bfd_storage): Remove.
13457 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13458
741d7538
TT		 134592019-03-15 Tom Tromey <tom@tromey.com>
13460
13461 * symfile.c (reread_symbols): Update.
13462 * objfiles.c (objfile::objfile): Update.
13463 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13464 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13465 comment.
13466 (minimal_symbol_reader::install): Update.
13467 (terminate_minimal_symbol_table): Remove.
13468 * jit.c (jit_object_close_impl): Update.
13469
788c80d1
TT		 134702019-03-15 Tom Tromey <tom@tromey.com>
13471
13472 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13473 initializations.
13474
1b7a07cb
TT		 134752019-03-15 Tom Tromey <tom@tromey.com>
13476
13477 * objfiles.h (struct objfile_per_bfd_storage)
13478 <demangled_hash_languages>: Now a bitset.
13479 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13480 (lookup_minimal_symbol): Update.
13481
3db066bc
TT		 134822019-03-15 Tom Tromey <tom@tromey.com>
13483
13484 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13485 Don't return the symbol.
13486 * coffread.c (record_minimal_symbol): Use record_full.
13487
3fff2c37
EZ		 134882019-03-14 Eli Zaretskii <eliz@gnu.org>
13489
13490 The MS-Windows port of ncurses fails to switch to a color pair if
13491 one or both of the colors are the implicit default colors. This
13492 change records the default colors when TUI is initialized, and
13493 then specifies them explicitly when a color pair uses the default
13494 colors. This allows color styling in TUI mode on MS-Windows.
13495
13496 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13497 ncurses_norm_attr.
13498 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13499 colors in ncurses_norm_attr.
13500 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13501 "none", replace it with the default color recorded in
13502 ncurses_norm_attr.
13503
3b336828
TT		 135042019-03-14 Tom Tromey <tromey@adacore.com>
13505
13506 * source-cache.h (class source_cache) <get_source_lines>: Return
13507 std::string.
13508 * source-cache.c (source_cache::extract_lines): Handle case where
13509 first_pos==npos. Return std::string.
13510 (source_cache::get_source_lines): Update.
13511
d085f989
TT		 135122019-03-14 Tom Tromey <tromey@adacore.com>
13513
13514 * NEWS: Add item for "style sources" commands.
13515 * source-cache.c (source_cache::get_source_lines): Check
13516 source_styling.
13517 * cli/cli-style.c (source_styling): New global.
13518 (_initialize_cli_style): Add "style sources" commands.
13519 (show_style_sources): New function.
13520 * cli/cli-style.h (source_styling): Declare.
13521
6f11e682
TT		 135222019-03-14 Pedro Alves <palves@redhat.com>
13523 Tom Tromey <tromey@adacore.com>
13524
13525 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13526 * tui/tui-winsource.c (tui_refill_source_window): New function,
13527 from...
13528 (tui_horizontal_source_scroll): ... here. Move some logic.
13529 * cli/cli-style.c (set_style_enabled): Notify new observable.
13530 * tui/tui-hooks.c (tui_redisplay_source): New function.
13531 (tui_attach_detach_observers): Attach or detach
13532 tui_redisplay_source.
13533 * observable.h (source_styling_changed): New observable.
13534 * observable.c: Define source_styling_changed observable.
13535
a068643d
TT		 135362019-03-13 Tom Tromey <tromey@adacore.com>
13537
13538 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13539 (i386_gnu_nat_target::store_registers): Update.
13540 * target-debug.h (target_debug_print_std_string): New macro.
13541 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13542 * windows-tdep.c (display_one_tib): Update.
13543 * tui/tui-stack.c (tui_make_status_line): Update.
13544 * top.c (print_inferior_quit_action): Update.
13545 * thread.c (thr_try_catch_cmd): Update.
13546 (add_thread_with_info): Update.
13547 (thread_target_id_str): Update.
13548 (thr_try_catch_cmd): Update.
13549 (thread_command): Update.
13550 (thread_find_command): Update.
13551 * record-btrace.c (record_btrace_target::info_record)
13552 (record_btrace_resume_thread, record_btrace_target::resume)
13553 (record_btrace_cancel_resume, record_btrace_step_thread)
13554 (record_btrace_target::wait, record_btrace_target::wait)
13555 (record_btrace_target::wait, record_btrace_target::stop): Update.
13556 * progspace.c (print_program_space): Update.
13557 * process-stratum-target.c
13558 (process_stratum_target::thread_address_space): Update.
13559 * linux-fork.c (linux_fork_mourn_inferior)
13560 (detach_checkpoint_command, info_checkpoints_command)
13561 (linux_fork_context): Update.
13562 (linux_fork_detach): Update.
13563 (class scoped_switch_fork_info): Update.
13564 (delete_checkpoint_command): Update.
13565 * infrun.c (follow_fork_inferior): Update.
13566 (follow_fork_inferior): Update.
13567 (proceed_after_vfork_done): Update.
13568 (handle_vfork_child_exec_or_exit): Update.
13569 (follow_exec): Update.
13570 (displaced_step_prepare_throw): Update.
13571 (displaced_step_restore): Update.
13572 (start_step_over): Update.
13573 (resume_1): Update.
13574 (clear_proceed_status_thread): Update.
13575 (proceed): Update.
13576 (print_target_wait_results): Update.
13577 (do_target_wait): Update.
13578 (context_switch): Update.
13579 (stop_all_threads): Update.
13580 (restart_threads): Update.
13581 (finish_step_over): Update.
13582 (handle_signal_stop): Update.
13583 (switch_back_to_stepped_thread): Update.
13584 (keep_going_pass_signal): Update.
13585 (print_exited_reason): Update.
13586 (normal_stop): Update.
13587 * inferior.c (inferior_pid_to_str): Change return type.
13588 (print_selected_inferior): Update.
13589 (add_inferior): Update.
13590 (detach_inferior): Update.
13591 * dummy-frame.c (fprint_dummy_frames): Update.
13592 * dcache.c (dcache_info_1): Update.
13593 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13594 (btrace_fetch, btrace_clear): Update.
13595 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13596 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13597 type.
13598 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13599 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13600 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13601 * gdbarch.c, gdbarch.h: Rebuild.
13602 * gdbarch.sh (core_pid_to_str): Change return type.
13603 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13604 return type.
13605 (windows_nat_target::pid_to_str): Change return type.
13606 (windows_delete_thread): Update.
13607 (windows_nat_target::attach): Update.
13608 (windows_nat_target::files_info): Update.
13609 * target-delegates.c: Rebuild.
13610 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13611 return type.
13612 (sol_thread_target::pid_to_str): Change return type.
13613 * remote.c (class remote_target) <pid_to_str>: Change return
13614 type.
13615 (remote_target::pid_to_str): Change return type.
13616 (extended_remote_target::attach, remote_target::remote_stop_ns)
13617 (remote_target::remote_notif_remove_queued_reply)
13618 (remote_target::push_stop_reply, remote_target::disable_btrace):
13619 Update.
13620 (extended_remote_target::attach): Update.
13621 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13622 type.
13623 (gdbsim_target::pid_to_str): Change return type.
13624 * ravenscar-thread.c (struct ravenscar_thread_target)
13625 <pid_to_str>: Change return type.
13626 (ravenscar_thread_target::pid_to_str): Change return type.
13627 * procfs.c (class procfs_target) <pid_to_str>: Change return
13628 type.
13629 (procfs_target::pid_to_str): Change return type.
13630 (procfs_target::attach): Update.
13631 (procfs_target::detach): Update.
13632 (procfs_target::fetch_registers): Update.
13633 (procfs_target::store_registers): Update.
13634 (procfs_target::wait): Update.
13635 (procfs_target::files_info): Update.
13636 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13637 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13638 return type.
13639 (nto_procfs_target::pid_to_str): Change return type.
13640 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13641 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13642 return type.
13643 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13644 (exit_lwp): Update.
13645 (attach_proc_task_lwp_callback, get_detach_signal)
13646 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13647 (linux_nat_target::resume, wait_lwp, stop_callback)
13648 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13649 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13650 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13651 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13652 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13653 type.
13654 (inf_ptrace_target::attach): Update.
13655 (inf_ptrace_target::files_info): Update.
13656 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13657 type.
13658 (go32_nat_target::pid_to_str): Change return type.
13659 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13660 (gnu_nat_target::wait): Update.
13661 (gnu_nat_target::wait): Update.
13662 (gnu_nat_target::resume): Update.
13663 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13664 (fbsd_nat_target::wait): Update.
13665 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13666 type.
13667 (darwin_nat_target::attach): Update.
13668 * corelow.c (class core_target) <pid_to_str>: Change return type.
13669 (core_target::pid_to_str): Change return type.
13670 * target.c (normal_pid_to_str): Change return type.
13671 (default_pid_to_str): Likewise.
13672 (target_pid_to_str): Change return type.
13673 (target_translate_tls_address): Update.
13674 (target_announce_detach): Update.
13675 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13676 return type.
13677 (bsd_uthread_target::pid_to_str): Change return type.
13678 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13679 type.
13680 (bsd_kvm_target::pid_to_str): Change return type.
13681 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13682 return type.
13683 (aix_thread_target::pid_to_str): Change return type.
13684 * target.h (struct target_ops) <pid_to_str>: Change return type.
13685 (target_pid_to_str, normal_pid_to_str): Likewise.
13686 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13687 type.
13688 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13689 type.
13690 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13691 return type.
13692 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13693 type.
13694 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13695 type.
13696 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13697 return type.
13698
b4be1b06
SM		 136992019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13700
13701 * NEWS: Mention that the new default MI version is 3. Mention
13702 changes to the output of commands and events that deal with
13703 multi-location breakpoints.
13704 * breakpoint.c: Include "mi/mi-out.h".
13705 (print_one_breakpoint): Change output syntax if using MI version
13706 >= 3.
13707 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13708 New.
13709 (mi_multi_location_breakpoint_output_fixed): New.
13710 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13711 (mi_cmd_fix_multi_location_breakpoint_output): New.
13712 (mi_multi_location_breakpoint_output_fixed): New.
13713 * mi/mi-cmds.c (mi_cmds): Register command
13714 -fix-multi-location-breakpoint-output.
13715 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13716 interpreter "mi".
13717
8e5e5494
SM		 137182019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13719
13720 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13721 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13722 instantiate mi_ui_out based on interpreter name.
13723 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13724 * mi/mi-main.c (mi_load_progress): Likewise.
13725
197df35e
JB		 137262019-03-12 John Baldwin <jhb@FreeBSD.org>
13727
13728 * NEWS: Combine separate "New targets" sections for 8.3.
13729
8399425f
JB		 137302019-03-12 John Baldwin <jhb@FreeBSD.org>
13731
13732 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13733 (ppcfbsd_init_abi): Install gdbarch
13734 "fetch_tls_load_module_address" and "get_thread_local_address"
13735 methods.
13736
b0f87ed0
JB		 137372019-03-12 John Baldwin <jhb@FreeBSD.org>
13738
13739 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13740 (riscv_fbsd_init_abi): Install gdbarch
13741 "fetch_tls_load_module_address" and "get_thread_local_address"
13742 methods.
13743
ce25aa57
JB		 137442019-03-12 John Baldwin <jhb@FreeBSD.org>
13745
13746 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13747 (i386fbsd_init_abi): Install gdbarch
13748 "fetch_tls_load_module_address" and "get_thread_local_address"
13749 methods.
13750
f5424cfa
JB		 137512019-03-12 John Baldwin <jhb@FreeBSD.org>
13752
13753 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13754 (amd64fbsd_init_abi): Install gdbarch
13755 "fetch_tls_load_module_address" and "get_thread_local_address"
13756 methods.
13757
945f3901
JB		 137582019-03-12 John Baldwin <jhb@FreeBSD.org>
13759
13760 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13761 (struct fbsd_pspace_data): New type.
13762 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13763 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13764 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13765 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13766 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13767
ef0bd204
JB		 137682019-03-12 John Baldwin <jhb@FreeBSD.org>
13769
13770 * gdbtypes.c (lookup_struct_elt): New function.
13771 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13772 * gdbtypes.h (struct struct_elt): New type.
13773 (lookup_struct_elt): New prototype.
13774
36c53a02
JB		 137752019-03-12 John Baldwin <jhb@FreeBSD.org>
13776
13777 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13778 remove disabled code block.
13779
6e056c81
JB		 137802019-03-12 John Baldwin <jhb@FreeBSD.org>
13781
13782 * gdbarch.sh (get_thread_local_address): New method.
13783 * gdbarch.h, gdbarch.c: Regenerate.
13784 * target.c (target_translate_tls_address): Use
13785 gdbarch_get_thread_local_address if present instead of
13786 target::get_thread_local_address.
13787
cd250a18
JB		 137882019-03-12 John Baldwin <jhb@FreeBSD.org>
13789
13790 * target.h (target::get_thread_local_address): Update comment.
13791
df22c1e5
JB		 137922019-03-12 John Baldwin <jhb@FreeBSD.org>
13793
13794 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13795 objfile->separate_debug_objfile_backlink if not NULL.
13796
dd6876c9
JB		 137972019-03-12 John Baldwin <jhb@FreeBSD.org>
13798
13799 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13800 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13801 (amd64bsd_store_inferior_registers): Likewise.
13802 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13803 Enable segment base registers.
13804 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13805 PT_GETFSBASE and PT_GETGSBASE.
13806 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13807 PT_SETGSBASE.
13808 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13809 segment base registers.
13810 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13811
1163a4b7
JB		 138122019-03-12 John Baldwin <jhb@FreeBSD.org>
13813
13814 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13815 Update calls to i386_target_description to add 'segments'
13816 parameter.
13817 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13818 add segment base registers.
13819 * arch/i386.c (i386_create_target_description): Add 'segments'
13820 parameter to enable segment base registers.
13821 * arch/i386.h (i386_create_target_description): Likewise.
13822 * features/i386/32bit-segments.xml: New file.
13823 * features/i386/32bit-segments.c: Generate.
13824 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13825 call to i386_target_description to add 'segments' parameter.
13826 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13827 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13828 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13829 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13830 if feature is present.
13831 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13832 Add 'segments' parameter to call to i386_target_description.
13833 (i386_target_description): Add 'segments' parameter to enable
13834 segment base registers.
13835 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13836 to call to i386_target_description.
13837 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13838 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13839 Define I386_NUM_REGS.
13840 (i386_target_description): Add 'segments' parameter to enable
13841 segment base registers.
13842
3a350822
EZ		 138432019-03-12 Eli Zaretskii <eliz@gnu.org>
13844
13845 PR/24325
13846 * source-cache.c: #undef open and close, to avoid unresolved
13847 externals during linking.
13848
ffdd69cf
TT		 138492019-03-12 Tom Tromey <tromey@adacore.com>
13850
13851 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13852 const. Add initializers.
13853 (_initialize_remote): Don't initialize ptid globals.
13854
ec148c57
PA		 138552019-03-12 Pedro Alves <palves@redhat.com>
13856
13857 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13858
32764270
PA		 138592019-03-12 Pedro Alves <palves@redhat.com>
13860
13861 * cp-name-parser.y (main): Remove unused 'len' variable.
13862
17547186
TT		 138632019-03-12 Tom Tromey <tromey@adacore.com>
13864
13865 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13866 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13867
d3a70e03
TT		 138682019-03-12 Tom Tromey <tromey@adacore.com>
13869
13870 * linux-nat.c (iterate_over_lwps): Update.
13871 (stop_callback): Remove parameter.
13872 (stop_wait_callback, detach_callback, resume_set_callback)
13873 (select_singlestep_lwp_callback, set_ignore_sigint)
13874 (status_callback, resumed_callback, resume_clear_callback)
13875 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13876 data parameter.
13877 (linux_nat_target::detach, linux_nat_target::resume)
13878 (linux_stop_and_wait_all_lwps, select_event_lwp)
13879 (linux_nat_filter_event, linux_nat_wait_1)
13880 (linux_nat_target::kill, linux_nat_target::stop)
13881 (linux_nat_target::stop): Update.
13882 (linux_nat_resume_callback): Change type.
13883 (resume_stopped_resumed_lwps, count_events_callback)
13884 (select_event_lwp_callback): Likewise.
13885 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13886 * arm-linux-nat.c (struct update_registers_data): Remove.
13887 (update_registers_callback): Change type.
13888 (arm_linux_insert_hw_breakpoint1): Update.
13889 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13890 parameter.
13891 (x86_linux_dr_set_addr): Update.
13892 (x86_linux_dr_set_control): Update.
13893 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13894 (iterate_over_lwps): Use gdb::function_view.
13895 * nat/aarch64-linux-hw-point.c (struct
13896 aarch64_dr_update_callback_param): Remove.
13897 (debug_reg_change_callback): Change type.
13898 (aarch64_notify_debug_reg_change): Update.
13899 * s390-linux-nat.c (s390_refresh_per_info): Update.
13900
82cb27ff
TT		 139012019-03-11 Tom Tromey <tromey@adacore.com>
13902
13903 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13904 redundant assignment to "this_cu".
13905
568c0683
SM		 139062019-03-08 Simon Marchi <simon.marchi@efficios.com>
13907
13908 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13909
f09ce22d
SM		 139102019-03-08 Simon Marchi <simon.marchi@efficios.com>
13911
13912 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13913 from...
13914 (rank_one_type): ... this.
13915
595f96a9
SM		 139162019-03-08 Simon Marchi <simon.marchi@efficios.com>
13917
13918 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13919 from...
13920 (rank_one_type): ... this.
13921
2598a94b
SM		 139222019-03-08 Simon Marchi <simon.marchi@efficios.com>
13923
13924 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13925 from...
13926 (rank_one_type): ... this.
13927
7f17b20d
SM		 139282019-03-08 Simon Marchi <simon.marchi@efficios.com>
13929
13930 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13931 from...
13932 (rank_one_type): ... this.
13933
2c509035
SM		 139342019-03-08 Simon Marchi <simon.marchi@efficios.com>
13935
13936 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13937 from...
13938 (rank_one_type): ... this.
13939
0dd322dc
SM		 139402019-03-08 Simon Marchi <simon.marchi@efficios.com>
13941
13942 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13943 from...
13944 (rank_one_type): ... this.
13945
41ea4728
SM		 139462019-03-08 Simon Marchi <simon.marchi@efficios.com>
13947
13948 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13949 from...
13950 (rank_one_type): ... this.
13951
793cd1d2
SM		 139522019-03-08 Simon Marchi <simon.marchi@efficios.com>
13953
13954 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13955 from...
13956 (rank_one_type): ... this.
13957
34910087
SM		 139582019-03-08 Simon Marchi <simon.marchi@efficios.com>
13959
13960 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13961 from...
13962 (rank_one_type): ... this.
13963
f1f832d6
SM		 139642019-03-08 Simon Marchi <simon.marchi@efficios.com>
13965
13966 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13967 from...
13968 (rank_one_type): ... this.
13969
b9f4512f
SM		 139702019-03-08 Simon Marchi <simon.marchi@efficios.com>
13971
13972 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13973 from...
13974 (rank_one_type): ... this.
13975
9293fc63
SM		 139762019-03-08 Simon Marchi <simon.marchi@efficios.com>
13977
13978 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13979 from...
13980 (rank_one_type): ... this.
13981
e3abbe7e
PW		 139822019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13983
13984 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13985 inferior-events' shows the example events.
13986
e4adb939
EZ		 139872019-03-08 Eli Zaretskii <eliz@gnu.org>
13988
13989 Support styling on native MS-Windows console
13990
13991 PR/24315
13992 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13993 on MS-Windows if $TERM is not defined.
13994
13995 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13996
13997 * posix-hdep.c (gdb_console_fputs):
13998 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13999 functions.
14000 * ui-file.h (gdb_console_fputs): Add prototype.
14001
14002 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14003 back to fputs only if the former returns zero.
14004
25629dfd
TT		 140052019-03-07 Tom Tromey <tom@tromey.com>
14006
14007 * symmisc.c (print_symbol_bcache_statistics): Update.
14008 (print_objfile_statistics): Update.
14009 * symfile.c (allocate_symtab): Update.
14010 * stabsread.c: Don't include bcache.h.
14011 * psymtab.h (struct psymbol_bcache): Don't declare.
14012 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14013 (psymbol_bcache_init, psymbol_bcache_free)
14014 (psymbol_bcache_get_bcache): Don't declare.
14015 * psymtab.c (struct psymbol_bcache): Remove.
14016 (psymtab_storage::psymtab_storage): Update.
14017 (psymtab_storage::~psymtab_storage): Update.
14018 (psymbol_bcache_init, psymbol_bcache_free)
14019 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14020 (add_psymbol_to_bcache): Update.
14021 (allocate_psymtab): Update.
14022 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14023 macro_cache>: No longer pointers.
14024 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14025 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14026 * macrotab.c (macro_bcache): Update.
14027 * macroexp.c: Don't include bcache.h.
14028 * gdbtypes.c (check_types_worklist): Update.
14029 (types_deeply_equal): Remove TRY/CATCH. Update.
14030 * elfread.c (elf_symtab_read): Update.
14031 * dwarf2read.c: Don't include bcache.h.
14032 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14033 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14034 (print_bcache_statistics, bcache_memory_used): Don't declare.
14035 (struct bcache): Move from bcache.c. Add constructor, destructor,
14036 methods. Rename all data members.
14037 * bcache.c (struct bcache): Move to bcache.h.
14038 (bcache::expand_hash_table): Rename from expand_hash_table.
14039 (bcache): Remove.
14040 (bcache::insert): Rename from bcache_full.
14041 (bcache::compare): Rename from bcache_compare.
14042 (bcache_xmalloc): Remove.
14043 (bcache::~bcache): Rename from bcache_xfree.
14044 (bcache::print_statistics): Rename from print_bcache_statistics.
14045 (bcache::memory_used): Rename from bcache_memory_used.
14046
fe726667
PA		 140472019-03-07 Pedro Alves <palves@redhat.com>
14048
14049 * infrun.c (normal_stop): Also check for
14050 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14051
7584bb30
AB		 140522019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14053
14054 * f-lang.c (value_from_host_double): Moved to...
14055 * value.c (value_from_host_double): ...here.
14056 * value.h (value_from_host_double): Declare.
14057 * guile/scm-math.c (vlscm_convert_typed_number): Use
14058 value_from_host_double.
14059 (vlscm_convert_number): Likewise.
14060 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14061 * python/py-value.c (convert_value_from_python): Likewise.
14062
a7b1986e
TT		 140632019-03-06 Tom Tromey <tom@tromey.com>
14064
14065 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14066
0ccf4211
TT		 140672019-03-06 Tom Tromey <tom@tromey.com>
14068
14069 * utils.h (free_current_contents): Don't declare.
14070 * utils.c (free_current_contents): Remove.
14071
fe7b42e5
TT		 140722019-03-06 Tom Tromey <tom@tromey.com>
14073
14074 * top.c (quit_force): Update.
14075 * main.c (captured_command_loop): Update.
14076 * common/new-op.c (operator new): Update.
14077 * common/common-exceptions.c (struct catcher)
14078 <save_cleanup_chain>: Remove member.
14079 (exceptions_state_mc_init): Update.
14080 (exception_try_scope_entry): Return nullptr.
14081 (exception_try_scope_exit, exception_rethrow)
14082 (throw_exception_sjlj, throw_exception_cxx): Update.
14083 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14084 (all_cleanups, do_cleanups, discard_cleanups)
14085 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14086 (restore_cleanups, restore_final_cleanups): Don't declare.
14087 (do_final_cleanups): Remove parameter.
14088 * common/cleanups.c (cleanup_chain, make_cleanup)
14089 (make_cleanup_dtor, all_cleanups, do_cleanups)
14090 (discard_my_cleanups, discard_cleanups)
14091 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14092 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14093 (null_cleanup): Remove.
14094 (do_final_cleanups): Remove parameter.
14095
c6321f19
TT		 140962019-03-06 Tom Tromey <tom@tromey.com>
14097
14098 * remote.c (remote_target::remote_parse_stop_reply): Use
14099 unique_xmalloc_ptr.
14100
61b30099
TT		 141012019-03-06 Tom Tromey <tom@tromey.com>
14102
14103 * stabsread.c (struct stabs_field_info): Rename from field_info.
14104 <list, fnlist>: Add initializers.
14105 <obstack>: New member.
14106 (read_member_functions, read_struct_fields, read_baseclasses):
14107 Allocate on obstack. Don't use cleanups.
14108 (read_one_struct_field, read_member_functions, read_struct_fields)
14109 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14110 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14111 (read_struct_type): Update.
14112
6cceac94
TT		 141132019-03-06 Tom Tromey <tom@tromey.com>
14114
14115 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14116 * common/filestuff.h (make_cleanup_close): Don't declare.
14117 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14118 Remove.
14119
72412762
TT		 141202019-03-06 Tom Tromey <tom@tromey.com>
14121
14122 * solib-aix.c: Use make_scope_exit.
14123
2b6ff1c0
TT		 141242019-03-06 Tom Tromey <tom@tromey.com>
14125
14126 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14127 Use make_scope_exit.
14128
d01c5877
TT		 141292019-03-06 Tom Tromey <tom@tromey.com>
14130
14131 * solib-svr4.c (disable_probes_interface): Remove parameter.
14132 (svr4_handle_solib_event): Use make_scope_exit.
14133
32603266
TT		 141342019-03-06 Tom Tromey <tom@tromey.com>
14135
14136 * remote.c (struct stop_reply_deleter): Remove.
14137 (stop_reply_up): Update.
14138 (struct stop_reply): Derive from notif_event. Don't typedef.
14139 <regcache>: Now a std::vector.
14140 (stop_reply_xfree): Remove.
14141 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14142 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14143 (remote_target::discard_pending_stop_replies): Use delete.
14144 (remote_target::remote_parse_stop_reply): Update.
14145 (remote_target::process_stop_reply): Update.
14146 * remote-notif.h (struct notif_event): Add virtual destructor.
14147 Remove "dtr" member.
14148 (struct notif_client) <alloc_event>: Return a unique_ptr.
14149 (notif_event_xfree): Don't declare.
14150 (notif_event_up): New typedef.
14151 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14152 (notif_event_xfree, do_notif_event_xfree): Remove.
14153 (remote_notif_state_xfree): Update.
14154
9799571e
TT		 141552019-03-06 Tom Tromey <tom@tromey.com>
14156
14157 * infrun.c (displaced_step_clear_cleanup): Now a
14158 forward_scope_exit type.
14159 (displaced_step_prepare_throw): Update.
14160 (displaced_step_fixup): Update.
14161
09e3c4ca
TT		 141622019-03-06 Tom Tromey <tom@tromey.com>
14163
14164 * inferior.h (class inferior): Update comment.
14165 * gdbthread.h (class thread_info): Update comment.
14166
e2a03548
TT		 141672019-03-06 Joel Brobecker <brobecker@adacore.com>
14168 Tom Tromey <tom@tromey.com>
14169
14170 * stabsread.h (struct stab_section_list): Remove.
14171 (coffstab_build_psymtabs): Update.
14172 * dbxread.c (symbuf_sections): Now a std::vector.
14173 (sect_idx): New global.
14174 (fill_symbuf): Update.
14175 (coffstab_build_psymtabs): Change type of stabsects parameter.
14176 Update.
14177 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14178 std::vector.
14179 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14180 (coff_locate_sections): Update.
14181 (coff_symfile_read): Remove cleanups. Update.
14182 (init_stringtab): Add storage parameter.
14183 (free_stringtab, free_stringtab_cleanup): Remove.
14184 (init_lineno): Add storage parameter.
14185 (free_linetab, free_linetab_cleanup): Remove.
14186
b7e60d85
PA		 141872019-03-06 Pedro Alves <palves@redhat.com>
14188
14189 * linux-fork.c (fork_info::clobber_regs): Delete.
14190 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14191 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14192 comment. Adjust.
14193 (scoped_switch_fork_info::scoped_switch_fork_info)
14194 (checkpoint_command, linux_fork_context): Adjust
14195 fork_save_infrun_state calls.
14196
e52c971f
PA		 141972019-03-06 Pedro Alves <palves@redhat.com>
14198
14199 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14200 (inf_has_multiple_threads): Return 'bool' and rewrite using
14201 inferior_info::threads().
14202
06974e6c
PA		 142032019-03-06 Pedro Alves <palves@redhat.com>
14204
14205 * linux-fork.c: Include <list>.
14206 (fork_list): Now a std::list instance.
14207 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14208 (forks_exist_p, find_last_fork): Adjust.
14209 (new_fork): Delete.
14210 (one_fork_p): New.
14211 (add_fork): Adjust.
14212 (free_fork): Delete, folded into fork_info::~fork_info().
14213 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14214 Adjust.
14215 (init_fork_list): Delete.
14216 (linux_fork_killall, linux_fork_mourn_inferior)
14217 (linux_fork_detach, info_checkpoints_command): Adjust.
14218 (_initialize_linux_fork): No longer call init_fork_list.
14219
72f31aea
PA		 142202019-03-06 Pedro Alves <palves@redhat.com>
14221
14222 * linux-fork.c (new_fork): New, split out of ...
14223 (add_fork): ... this. Return void. Move "first fork" special
14224 case from here, to ...
14225 (checkpoint_command): ... here.
14226 * linux-linux.h (add_fork): Return void.
14227
efbecbc1
AB		 142282019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14229
14230 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14231
0841c79a
AB		 142322019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14233 Chris January <chris.january@arm.com>
14234 David Lecomber <david.lecomber@arm.com>
14235
14236 * f-exp.y: New token, UNOP_INTRINSIC.
14237 (exp): New pattern using UNOP_INTRINSIC token.
14238 (f77_keywords): Add 'abs' keyword.
14239 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14240 (value_from_host_double): New function.
14241 (evaluate_subexp_f): Support UNOP_ABS.
14242
4a270568
AB		 142432019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14244
14245 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14246 types.
14247
067630bd
AB		 142482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14249
14250 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14251 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14252 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14253
3be47f7a
AB		 142542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14255
14256 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14257
4d00f5d8
AB		 142582019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14259 Chris January <chris.january@arm.com>
14260
14261 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14262 * f-exp.y: Define 'KIND' token.
14263 (exp): New pattern for KIND expressions.
14264 (ptype): Handle types with a kind extension.
14265 (direct_abs_decl): Extend to spot kind extensions.
14266 (f77_keywords): Add 'kind' to the list.
14267 (push_kind_type): New function.
14268 (convert_to_kind_type): New function.
14269 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14270 * parse.c (operator_length_standard): Likewise.
14271 * parser-defs.h (enum type_pieces): Add tp_kind.
14272 * std-operator.def: Add UNOP_KIND.
14273
e454224f
AB		 142742019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14275
14276 * f-exp.y (f_parse): Set yydebug.
14277
9dad4a58
AB		 142782019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14279
14280 * f-lang.c (evaluate_subexp_f): New function.
14281 (exp_descriptor_f): New global.
14282 (f_language_defn): Use exp_descriptor_f instead of
14283 exp_descriptor_standard.
14284
c8f91604
AB		 142852019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14286
14287 * f-exp.y (struct token): Add comments.
14288 (dot_ops): Remove uppercase versions and the end marker.
14289 (f77_keywords): Likewise.
14290 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14291 entries in the dot_ops array are case insensitive, and use
14292 strncasecmp to compare strings. Also some whitespace cleanup in
14293 this area. Similar for the f77_keywords array, except entries in
14294 this list might be case sensitive.
14295
dd9f2c76
AB		 142962019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14297
14298 * f-exp.y (struct f77_boolean_val): Add comments.
14299 (boolean_values): Remove uppercase versions, and end marker.
14300 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14301 and use strncasecmp to achieve case insensitivity. Additionally,
14302 perform whitespace cleanup around this code.
14303
67a3048c
TT		 143042019-03-06 Tom Tromey <tromey@adacore.com>
14305
14306 * remote-sim.c (gdbsim_target_open): Use result of
14307 gdb_argv::release.
14308
aa3cfbda
RB		 143092019-03-06 Richard Bunt <richard.bunt@arm.com>
14310 Dirk Schubert <dirk.schubert@arm.com>
14311 Chris January <chris.january@arm.com>
14312
14313 * eval.c (evaluate_subexp_standard): Call Fortran argument
14314 wrapping logic.
14315 * f-lang.c (struct value): A value which can be passed into a
14316 Fortran function call.
14317 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14318 where appropriate.
14319 (struct type): Value ready for a Fortran function call.
14320 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14321 is needed.
14322 * f-lang.h (fortran_argument_convert): Declaration.
14323 (fortran_preserve_arg_pointer): Declaration.
14324 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14325
ea38e5df
TT		 143262019-03-05 Tom Tromey <tromey@adacore.com>
14327
14328 * python/py-prettyprint.c (print_string_repr): Remove #if.
14329 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14330
06b5b831
TT		 143312019-03-05 Tom Tromey <tromey@adacore.com>
14332
14333 * target.c (the_dummy_target): Move later. Change type to
14334 "dummy_target".
14335 (initialize_targets): Don't initialize the_dummy_target.
14336
edbd9e45
TT		 143372019-03-05 Tom Tromey <tromey@adacore.com>
14338
14339 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14340 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14341
c119e040
TT		 143422019-03-05 Tom Tromey <tromey@adacore.com>
14343
14344 * windows-nat.c (windows_nat_target::attach)
14345 (windows_nat_target::detach): Don't call gdb_flush.
14346 * valprint.c (generic_val_print, val_print, val_print_string):
14347 Don't call gdb_flush.
14348 * utils.c (defaulted_query): Don't call gdb_flush.
14349 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14350 * target.c (target_announce_detach): Don't call gdb_flush.
14351 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14352 * remote.c (extended_remote_target::attach): Don't call
14353 gdb_flush.
14354 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14355 * printcmd.c (do_examine): Don't call gdb_flush.
14356 (info_display_command): Don't call gdb_flush.
14357 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14358 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14359 * memattr.c (info_mem_command): Don't call gdb_flush.
14360 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14361 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14362 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14363 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14364 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14365 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14366 (gnu_nat_target::detach): Don't call gdb_flush.
14367 * f-valprint.c (f_val_print): Don't call gdb_flush.
14368 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14369 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14370 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14371 gdb_flush.
14372 * c-valprint.c (c_val_print): Don't call gdb_flush.
14373 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14374
895dafa6
TT		 143752019-03-05 Tom Tromey <tromey@adacore.com>
14376
14377 * varobj.c (update_dynamic_varobj_children): Update.
14378 (install_default_visualizer): Use reset, not release.
14379 * value.c (set_internalvar): Update.
14380 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14381 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14382 ATTRIBUTE_UNUSED_RESULT.
14383
88a774b9
TT		 143842019-03-05 Tom Tromey <tromey@adacore.com>
14385
14386 * remote.c (class scoped_remote_fd) <release>: Add
14387 ATTRIBUTE_UNUSED_RESULT.
14388
4e4a8b93
TT		 143892019-03-05 Tom Tromey <tromey@adacore.com>
14390
14391 * macroexp.c (struct macro_buffer) <release>: Add
14392 ATTRIBUTE_UNUSED_RESULT.
14393
083eef1f
TT		 143942019-03-05 Tom Tromey <tromey@adacore.com>
14395
14396 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14397 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14398 ATTRIBUTE_UNUSED_RESULT.
14399
3cabd438
TT		 144002019-03-05 Tom Tromey <tromey@adacore.com>
14401
14402 * common/scoped_fd.h (class scoped_fd) <release>: Add
14403 ATTRIBUTE_UNUSED_RESULT.
14404
41e3300a
TT		 144052019-03-05 Tom Tromey <tromey@adacore.com>
14406
14407 * parser-defs.h (struct parser_state) <release>: Add
14408 ATTRIBUTE_UNUSED_RESULT.
14409
18cb7c9f
TT		 144102019-03-05 Tom Tromey <tromey@adacore.com>
14411
14412 * utils.h (class gdb_argv) <release>: Add
14413 ATTRIBUTE_UNUSED_RESULT.
14414 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14415
41fa577f
EZ		 144162019-03-02 Eli Zaretskii <eliz@gnu.org>
14417
a6a4b2c6
EZ		 14418 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14419 for-loop range, to avoid compiler warnings.
14420
14421 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14422 avoid compiler warnings about unused variables.
14423
742a7df5
EZ		 14424 * NEWS: Mention end of support for native debugging on MS-Windows
14425 before XP.
14426
41fa577f
EZ		 14427 PR gdb/24292
14428 * common/netstuff.c:
14429 * gdbserver/gdbreplay.c
14430 * gdbserver/remote-utils.c:
14431 * ser-tcp.c:
14432 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14433 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14434 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14435 'getaddrinfo' and 'freeaddrinfo' were not available before
14436 Windows XP, and mingw.org's MinGW headers by default define
14437 _WIN32_WINNT to 0x500.
14438
827f438f
GB		 144392019-03-01 Gary Benson <gbenson@redhat.com>
14440
14441 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14442
92137da0
RO		 144432019-02-28 Brian Vandenberg <phantall@gmail.com>
14444 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14445
14446 PR gdb/8527
14447 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14448 set_sigint_trap, clear_sigint_trap.
14449
799efbe8
PW		 144502019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14451
14452 * target.c (target_detach): Clear the regcache and the
14453 frame cache.
14454
8ed25214
PA		 144552019-02-27 Pedro Alves <palves@redhat.com>
14456
14457 * utils.c (set_screen_size): When we cap the height/width sizes,
14458 tweak the corresponding command variable to show "unlimited":
14459
23031e31
SJ		 144602019-02-27 Saagar Jha <saagar@saagarjha.com>
14461 Pedro Alves <palves@redhat.com>
14462
14463 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14464 before calling rl_set_screen_size.
14465
6c28e44a
TT		 144662019-02-27 Tom Tromey <tromey@adacore.com>
14467
14468 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14469 define.
14470 * python/py-value.c: Remove Python 2.4 workaround.
14471 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14472 workaround.
14473 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14474 Python 2.4 workaround.
14475 * python/python-internal.h: Remove Python 2.4 comment.
14476 (Py_ssize_t): Don't define.
14477 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14478 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14479 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14480 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14481 * python/python.c (do_start_initialization): Remove Python 2.4
14482 workaround.
14483 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14484 (print_children): Remove Python 2.4 workaround.
14485 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14486 workaround.
14487 (CHARBUFFERPROC_NAME): Remove.
14488 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14489 Python 2.4 workaround.
14490
2c3fc25d 144912019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14492
2c3fc25d
KB		 14493 * NEWS: Note minimum Python version.
14494
6ca62222
KB		 144952019-02-27 Kevin Buettner <kevinb@redhat.com>
14496
14497 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14498 code from these functions. Remove corresponding ifdefs. Use
14499 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14500 Remove gotos and target of gotos.
14501 (infpy_search_memory): Likewise.
14502
f4bc7d2c
AB		 145032019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14504
14505 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14506 (hppa_gdbarch_init): Don't register deleted functions with
14507 gdbarch.
14508
9734a586
AB		 145092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14510
14511 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14512 (h8300_unwind_sp): Delete.
14513 (h8300_dummy_id): Delete.
14514 (h8300_gdbarch_init): Don't register deleted functions with
14515 gdbarch.
14516
68b867f3
AB		 145172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14518
14519 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14520 (ft32_unwind_pc): Delete.
14521 (ft32_unwind_sp): Delete.
14522 (ft32_gdbarch_init): Don't register deleted functions with
14523 gdbarch.
14524
2fbe7ad0
AB		 145252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14526
14527 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14528 (frv_unwind_pc): Delete.
14529 (frv_unwind_sp): Delete.
14530 (frv_gdbarch_init): Don't register deleted functions with
14531 gdbarch.
14532
76055cbe
AB		 145332019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14534
14535 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14536 (riscv_unwind_pc): Delete.
14537 (riscv_unwind_sp): Delete.
14538 (riscv_gdbarch_init): Don't register deleted functions with
14539 gdbarch.
14540
4133e5a1
AB		 145412019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14542
14543 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14544 (csky_unwind_pc): Delete.
14545 (csky_unwind_sp): Delete.
14546 (csky_gdbarch_init): Don't register deleted functions with
14547 gdbarch.
14548
8010f576
AB		 145492019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14550
14551 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14552 (cris_unwind_pc): Delete.
14553 (cris_unwind_sp): Delete.
14554 (cris_gdbarch_init): Don't register deleted functions with
14555 gdbarch.
14556
b56bf084
AB		 145572019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14558
14559 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14560 (bfin_unwind_pc): Delete.
14561 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14562
a19a650f
AB		 145632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14564
14565 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14566 (arm_unwind_pc): Delete.
14567 (arm_unwind_sp): Delete.
14568 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14569
f8278c3c
AB		 145702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14571
14572 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14573 (arc_unwind_pc): Delete.
14574 (arc_unwind_sp): Delete.
14575 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14576
480e46cf
AB		 145772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14578
14579 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14580 (alpha_unwind_pc): Delete.
14581 (alpha_gdbarch_init): Don't register deleted functions with
14582 gdbarch.
14583
7a995095
AB		 145842019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14585
14586 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14587 (aarch64_unwind_pc): Delete.
14588 (aarch64_unwind_sp): Delete.
14589 (aarch64_gdbarch_init): Don't register deleted functions with
14590 gdbarch.
14591
bf9a735e
AB		 145922019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14593
14594 * gdbtypes.c (type_align): Don't consider static members when
14595 computing structure alignment.
14596
5561fc30
AB		 145972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14598
14599 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14600 return 0 for other types.
14601 * arch-utils.c (default_type_align): Always return 0.
14602 * gdbarch.h: Regenerate.
14603 * gdbarch.sh (type_align): Extend comment.
14604 * gdbtypes.c (type_align): Add additional comments, always call
14605 gdbarch_type_align before applying the default rules.
14606 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14607 generic code will then apply a suitable default.
14608 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14609 types, return 0 for other types.
14610
9335e75a
JB		 146112019-02-27 Joel Brobecker <brobecker@adacore.com>
14612
14613 * NEWS: Create a new section for the next release branch.
14614 Rename the section of the current branch, now that it has
14615 been cut.
14616
3d34d8de
JB		 146172019-02-27 Joel Brobecker <brobecker@adacore.com>
14618
14619 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14620 * version.in: Bump version to 8.3.50.DATE-git.
14621
143420fb
SM		 146222019-02-26 Simon Marchi <simon.marchi@efficios.com>
14623
14624 * aix-thread.c (ptid_cmp): Remove unused variable.
14625 (get_signaled_thread): Likewise.
14626 (store_regs_user_thread): Likewise.
14627 (store_regs_kernel_thread): Likewise.
14628 (fetch_regs_kernel_thread): Remove shadowed variable.
14629
172fb711
AB		 146302019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14631
14632 * features/riscv/32bit-cpu.xml: Add register numbers.
14633 * features/riscv/32bit-fpu.c: Regenerate.
14634 * features/riscv/32bit-fpu.xml: Add register numbers.
14635 * features/riscv/64bit-cpu.xml: Add register numbers.
14636 * features/riscv/64bit-fpu.c: Regenerate.
14637 * features/riscv/64bit-fpu.xml: Add register numbers.
14638
26c89782
KB		 146392019-02-26 Kevin Buettner <kevinb@redhat.com>
14640
af54ade9 14641 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14642 * python/py-value.c (convert_buffer_and_type_to_value): New
14643 function.
14644 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14645 Add support for handling an optional second argument. Call
14646 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14647 * python/python-internal.h (Py_buffer_deleter): New struct.
14648 (Py_buffer_up): New typedef.
14649
0f58c9e8
JB		 146502019-02-25 John Baldwin <jhb@FreeBSD.org>
14651
14652 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14653 instead of releasing ownership.
14654
0a0f4c01
JR		 146552019-02-25 Jordan Rupprecht <rupprecht@google.com>
14656
14657 * dwarf2read.c (open_and_init_dwp_file): Call
14658 elf_numsections instead of bfd_count_sections to initialize
14659 dwp_file->num_sections.
14660
cd5a152c
TT		 146612019-02-25 Tom Tromey <tromey@adacore.com>
14662
14663 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14664
8a6a8513
SDJ		 146652019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14666
14667 * gcore.in: Add '--readnever' option when invoking GDB.
14668
04dcda9c
SM		 146692019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14670
14671 * MAINTAINERS: Update my email address.
14672
07bc701d
SM		 146732019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14674
14675 * build-id.c (build_id_to_debug_bfd_1): New function.
14676 (build_id_to_debug_bfd): Look for separate debug file in
14677 sysroot.
14678
c6f4a5d0
AB		 146792019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14680
14681 * gdbarch.sh: Update the copyright year range that is placed into
14682 generated files.
14683
9600246d
KS		 146842019-02-22 Keith Seitz <keiths@redhat.com>
14685
14686 PR symtab/23853
14687 * linespec.c (create_sals_line_offset): Search for the default
14688 symtab's filename instead of its fullname.
14689
7557a514
AH		 146902019-02-21 Alan Hayward <alan.hayward@arm.com>
14691
14692 * NEWS: Update style defaults.
14693
ee2bcb0c
AH		 146942019-02-21 Alan Hayward <alan.hayward@arm.com>
14695
14696 * main.c (captured_main_1): Disable styling in batch mode.
14697
0c95f9ed
TT		 146982019-02-20 Tom Tromey <tom@tromey.com>
14699
14700 * symtab.c (symtab_symbol_info): Fix typos.
14701
c763b894
TT		 147022019-02-20 Tom Tromey <tromey@adacore.com>
14703
14704 * findcmd.c (_initialize_mem_search): Use upper case for
14705 metasyntactic variables.
14706
0ef8a082
AH		 147072019-02-20 Alan Hayward <alan.hayward@arm.com>
14708
14709 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14710 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14711
6caa91b6
SM		 147122019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14713
14714 * top.h (source_file_name): Change to std::string.
14715 * top.c (source_file_name): Likewise.
14716 (command_line_input): Adjust.
14717 * cli/cli-script.c (script_from_file): Adjust.
14718
98814c6c
TT		 147192019-02-19 Tom Tromey <tromey@adacore.com>
14720
14721 * ravenscar-thread.c
14722 (ravenscar_thread_target::update_thread_list): Don't call
14723 ada_build_task_list.
14724 * ada-lang.h (ada_build_task_list): Don't declare.
14725 * ada-tasks.c (struct ada_tasks_inferior_data)
14726 <task_list_valid_p>: Now bool.
14727 (read_known_tasks, ada_task_list_changed)
14728 (ada_tasks_invalidate_inferior_data): Update.
14729 (read_known_tasks_array): Return bool.
14730 (read_known_tasks_list): Likewise.
14731 (read_known_tasks): Return void.
14732 (ada_build_task_list): Now static.
14733
70cd633e
AB		 147342019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14735
14736 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14737 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14738
040b3e95
PW		 147392019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14740
14741 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14742 variant for ada_tasks_pspace_data_handle and
14743 ada_tasks_inferior_data_handle.
14744 (ada_tasks_pspace_data_cleanup): New function.
14745 (ada_tasks_inferior_data_cleanup): New function.
14746
9409233b
TT		 147472019-02-17 Tom Tromey <tom@tromey.com>
14748
14749 * macrotab.h (macro_source_fullname): Return a std::string.
14750 * macrotab.c (macro_include, check_for_redefinition)
14751 (macro_undef, macro_lookup_definition, foreach_macro)
14752 (foreach_macro_in_scope): Update.
14753 (macro_source_fullname): Return a std::string.
14754 * macrocmd.c (show_pp_source_pos): Update.
14755
6506371f
TT		 147562019-02-17 Tom Tromey <tom@tromey.com>
14757
14758 * macrocmd.c (show_pp_source_pos): Style the file names.
14759
0c820d67
TT		 147602019-02-17 Tom Tromey <tom@tromey.com>
14761
14762 PR tui/24197:
14763 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14764
a0087920
TT		 147652019-02-17 Tom Tromey <tom@tromey.com>
14766
14767 * ada-lang.c (user_select_syms): Use filtered printing.
14768 * utils.c (wrap_style): New global.
14769 (desired_style): Remove.
14770 (emit_style_escape): Add stream parameter.
14771 (set_output_style, reset_terminal_style, prompt_for_continue):
14772 Update.
14773 (flush_wrap_buffer): Only flush gdb_stdout.
14774 (wrap_here): Set wrap_style.
14775 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14776 treat escape sequences as a character. Change when wrap buffer is
14777 flushed.
14778 (fputs_styled): Do not set the output style when the default is
14779 requested.
14780 * ui-style.h (struct ui_file_style) <is_default>: New method.
14781 * source.c (print_source_lines_base): Emit escape sequences in one
14782 piece.
14783
75ba10dc
JB		 147842019-02-17 Joel Brobecker <brobecker@adacore.com>
14785
14786 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14787 integers and enumeration types.
14788
a2cd4f14
JB		 147892019-02-17 Joel Brobecker <brobecker@adacore.com>
14790
14791 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14792 instead of lookup_symbol_in_language
14793 (do_exact_match): New function.
14794 (ada_get_symbol_name_matcher): Return do_exact_match when
14795 doing a verbatim match.
14796
485b851b
TT		 147972019-02-15 Tom Tromey <tromey@adacore.com>
14798
14799 * ravenscar-thread.c (ravenscar_thread_target::resume)
14800 (ravenscar_thread_target::wait): Special case wildcard requests.
14801
0b790b1e
TT		 148022019-02-15 Tom Tromey <tromey@adacore.com>
14803
14804 * ravenscar-thread.c (base_ptid): Remove.
14805 (struct ravenscar_thread_target) <close>: New method.
14806 <m_base_ptid>: New member.
14807 <update_inferior_ptid, active_task, task_is_currently_active,
14808 runtime_initialized>: Declare methods.
14809 <ravenscar_thread_target>: Add constructor.
14810 (ravenscar_thread_target::task_is_currently_active)
14811 (ravenscar_thread_target::update_inferior_ptid)
14812 (ravenscar_runtime_initialized): Rename. Now methods.
14813 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14814 (ravenscar_thread_target::update_thread_list): Update.
14815 (ravenscar_thread_target::active_task): Now method.
14816 (ravenscar_thread_target::store_registers)
14817 (ravenscar_thread_target::prepare_to_store)
14818 (ravenscar_thread_target::prepare_to_store)
14819 (ravenscar_thread_target::mourn_inferior): Update.
14820 (ravenscar_inferior_created): Use "new" to create target.
14821 (ravenscar_thread_target::get_ada_task_ptid): Update.
14822 (_initialize_ravenscar): Don't initialize base_ptid.
14823 (ravenscar_ops): Remove global.
14824
dea57a62
TT		 148252019-02-15 Tom Tromey <tromey@adacore.com>
14826
14827 * target.h (push_target): Declare new overload.
14828 * target.c (push_target): New overload, taking an rvalue reference.
14829 * remote.c (remote_target::open_1): Use push_target overload.
14830 * corelow.c (core_target_open): Use push_target overload.
14831
989f3c58
TT		 148322019-02-15 Tom Tromey <tromey@adacore.com>
14833
14834 * ravenscar-thread.c (is_ravenscar_task)
14835 (ravenscar_task_is_currently_active): Return bool.
14836 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14837 (_initialize_ravenscar): Remove "(void)".
14838 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14839 Return bool.
14840
6cbcc006
TT		 148412019-02-15 Tom Tromey <tromey@adacore.com>
14842
14843 * ravenscar-thread.c (ravenscar_runtime_initializer)
14844 (has_ravenscar_runtime, get_running_thread_id)
14845 (ravenscar_thread_target::resume): Fix indentation.
14846
7657f14d
TT		 148472019-02-15 Tom Tromey <tromey@adacore.com>
14848
14849 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14850 from ravenscar_arch_ops.
14851 (sparc_ravenscar_ops::fetch_registers)
14852 (sparc_ravenscar_ops::store_registers): Now methods.
14853 (sparc_ravenscar_prepare_to_store): Remove.
14854 (sparc_ravenscar_ops): Redefine.
14855 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14856 methods and destructor. Remove members.
14857 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14858 (ravenscar_thread_target::store_registers)
14859 (ravenscar_thread_target::prepare_to_store): Update.
14860 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14861 Remove.
14862 (struct ppc_ravenscar_powerpc_ops): Derive from
14863 ravenscar_arch_ops.
14864 (ppc_ravenscar_powerpc_ops::fetch_registers)
14865 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14866 (ppc_ravenscar_powerpc_ops): Redefine.
14867 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14868 (ppc_ravenscar_e500_ops::fetch_registers)
14869 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14870 (ppc_ravenscar_e500_ops): Redefine.
14871 * aarch64-ravenscar-thread.c
14872 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14873 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14874 (aarch64_ravenscar_fetch_registers)
14875 (aarch64_ravenscar_store_registers): Now methods.
14876 (aarch64_ravenscar_ops): Redefine.
14877
5b6ea500
TT		 148782019-02-15 Tom Tromey <tromey@adacore.com>
14879
14880 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14881 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14882 (ravenscar_thread_target::stopped_by_watchpoint)
14883 (ravenscar_thread_target::stopped_data_address)
14884 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14885
e397fd39
TT		 148862019-02-15 Tom Tromey <tromey@adacore.com>
14887
14888 * ravenscar-thread.c: Fix some typos.
14889
cc12f4a8
TT		 148902019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14891 Tom Tromey <tromey@adacore.com>
14892
14893 * ada-lang.c (ada_exception_sal): Change addr_string to a
14894 std::string.
14895 (create_ada_exception_catchpoint): Update.
14896
5f486660
TT		 148972019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14898 Tom Tromey <tromey@adacore.com>
14899
14900 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14901 (bp_location_ops): Remove.
14902 (base_breakpoint_allocate_location): Update.
14903 (free_bp_location): Update.
14904 * ada-lang.c (class ada_catchpoint_location)
14905 <ada_catchpoint_location>: Remove ops parameter.
14906 (ada_catchpoint_location_dtor): Remove.
14907 (ada_catchpoint_location_ops): Remove.
14908 (allocate_location_exception): Update.
14909 * breakpoint.h (struct bp_location_ops): Remove.
14910 (class bp_location) <bp_location>: Remove bp_location_ops
14911 parameter.
14912 <~bp_location>: Add destructor.
14913 <ops>: Remove.
14914
b671c7fb
TS		 149152019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14916 Pedro Alves <palves@redhat.com>
14917
14918 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14919 'PATH_MAX'.
14920
8071c5ce
DM		 149212019-02-14 David Michael <fedora.dm0@gmail.com>
14922 Samuel Thibault <samuel.thibault@gnu.org>
14923 Thomas Schwinge <thomas@codesourcery.com>
14924
14925 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14926 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14927
b1041ae0
TS		 149282019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14929
924514e1
TS		 14930 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14931 (check_empty): Use "const char *".
14932
c29ee8d4
TS		 14933 * gnu-nat.c (gnu_nat_target::detach): Instead of
14934 'detach_inferior (pid)' call
14935 'detach_inferior (find_inferior_pid (pid))'.
14936
6c6ef69f
TS		 14937 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14938 'nat/fork-inferior.o'.
14939 * gnu-nat.c: #include "nat/fork-inferior.h".
14940
2d0a338c
TS		 14941 * gnu-nat.c (gnu_nat_target::detach): Instead of
14942 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14943 * gnu-nat.h: #include "inf-child.h".
14944 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14945 'i386_gnu_nat_target::fetch_registers'.
14946 (gnu_store_registers): Rename/move to
14947 'i386_gnu_nat_target::store_registers'.
14948
cabb5f06
TS		 14949 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14950 * gnu-nat.h (mach_thread_info): New function.
14951 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14952
b1041ae0
TS		 14953 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14954
2988d01e
KF		 149552019-02-14 Frederic Konrad <konrad@adacore.com>
14956
14957 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14958
c559d709
JB		 149592019-02-14 Joel Brobecker <brobecker@adacore.com>
14960
14961 * windows-nat.c (windows_add_thread): Add new parameter
14962 "main_thread_p" with default value set to false. Update
14963 function documentation as well as all callers.
14964 (windows_delete_thread): Likewise.
14965 (fake_create_process): Update call to windows_add_thread.
14966 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14967 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14968 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14969 call to windows_delete_thread.
14970
007024cc
SM		 149712019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14972
14973 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14974
f62318e9
JB		 149752019-02-12 John Baldwin <jhb@FreeBSD.org>
14976
14977 * symfile.c (find_separate_debug_file): Use canonical path of
14978 sysroot with child_path instead of gdb_sysroot if it is valid.
14979
cd4b7848
JB		 149802019-02-12 John Baldwin <jhb@FreeBSD.org>
14981
14982 * symfile.c (find_separate_debug_file): Use child_path to
14983 determine if an object file is under a sysroot.
14984
efac4bfe
JB		 149852019-02-12 John Baldwin <jhb@FreeBSD.org>
14986
14987 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14988 unittests/child-path-selftests.c.
14989 * common/pathstuff.c (child_path): New function.
14990 * common/pathstuff.h (child_path): New prototype.
14991 * unittests/child-path-selftests.c: New file.
14992
402d2bfe
JB		 149932019-02-12 John Baldwin <jhb@FreeBSD.org>
14994
14995 * symfile.c (find_separate_debug_file): Look for separate debug
14996 files in debug directories under the sysroot.
14997
1ed9f74e
PW		 149982019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14999
15000 * symtab.h (struct minimal_symbol data_p): New const method.
15001 (struct minimal_symbol text_p): Likewise.
15002 * symtab.c (output_source_filename): Use file name style
15003 to print file name.
15004 (print_symbol_info): Likewise.
15005 (print_msymbol_info): Use address style to print addresses.
15006 Use function name style to print executable text symbols.
15007 (expand_symtab_containing_pc): Use data_p.
15008 (find_pc_sect_compunit_symtab): Likewise.
15009
2636d81d
PW		 150102019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15011
15012 * breakpoint.c (describe_other_breakpoints): Use address style
15013 to print addresses.
15014 (say_where): Likewise.
15015
ac8c53cc
PW		 150162019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15017
15018 * ada-typeprint.c (print_func_type): Print function name
15019 style to print function name.
15020 * c-typeprint.c (c_print_type_1): Likewise.
15021
ea638c43
AH		 150222019-02-11 Alan Hayward <alan.hayward@arm.com>
15023
15024 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15025 for execve.
15026
ab759ca8
PW		 150272019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15028
15029 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15030 type_stack.
15031
aff29d1c
JB		 150322019-02-10 Joel Brobecker <brobecker@adacore.com>
15033
15034 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15035 TYPE_CODE_REF types.
15036
617126bc
JW		 150372019-02-08 Jim Wilson <jimw@sifive.com>
15038
15039 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15040 (riscv_linux_fregset): New.
15041 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15042
46e3ed7f
TT		 150432019-02-07 Tom Tromey <tom@tromey.com>
15044
15045 * thread.c (thread_cancel_execution_command): Update.
15046 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15047 methods.
15048 (struct thread_fsm_ops): Remove.
15049 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15050 (thread_fsm_should_stop, thread_fsm_return_value)
15051 (thread_fsm_set_finished, thread_fsm_finished_p)
15052 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15053 Don't declare.
15054 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15055 * infrun.c (clear_proceed_status_thread)
15056 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15057 (print_stop_event): Update.
15058 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15059 Add constructor.
15060 (step_command_fsm_ops): Remove.
15061 (new_step_command_fsm): Remove.
15062 (step_1): Update.
15063 (step_command_fsm::should_stop): Rename from
15064 step_command_fsm_should_stop.
15065 (step_command_fsm::clean_up): Rename from
15066 step_command_fsm_clean_up.
15067 (step_command_fsm::do_async_reply_reason): Rename from
15068 step_command_fsm_async_reply_reason.
15069 (struct until_next_fsm): Inherit from thread_fsm. Add
15070 constructor.
15071 (until_next_fsm_ops): Remove.
15072 (new_until_next_fsm): Remove.
15073 (until_next_fsm::should_stop): Rename from
15074 until_next_fsm_should_stop.
15075 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15076 (until_next_fsm::do_async_reply_reason): Rename from
15077 until_next_fsm_async_reply_reason.
15078 (struct finish_command_fsm): Inherit from thread_fsm. Add
15079 constructor. Change type of breakpoint.
15080 (finish_command_fsm_ops): Remove.
15081 (new_finish_command_fsm): Remove.
15082 (finish_command_fsm::should_stop): Rename from
15083 finish_command_fsm_should_stop.
15084 (finish_command_fsm::clean_up): Rename from
15085 finish_command_fsm_clean_up.
15086 (finish_command_fsm::return_value): Rename from
15087 finish_command_fsm_return_value.
15088 (finish_command_fsm::do_async_reply_reason): Rename from
15089 finish_command_fsm_async_reply_reason.
15090 (finish_command): Update.
15091 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15092 Add constructor.
15093 (call_thread_fsm_ops): Remove.
15094 (call_thread_fsm::call_thread_fsm): Rename from
15095 new_call_thread_fsm.
15096 (call_thread_fsm::should_stop): Rename from
15097 call_thread_fsm_should_stop.
15098 (call_thread_fsm::should_notify_stop): Rename from
15099 call_thread_fsm_should_notify_stop.
15100 (run_inferior_call, call_function_by_hand_dummy): Update.
15101 * cli/cli-interp.c (should_print_stop_to_console): Update.
15102 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15103 Add constructor. Change type of location_breakpoint,
15104 caller_breakpoint.
15105 (until_break_fsm_ops): Remove.
15106 (new_until_break_fsm): Remove.
15107 (until_break_fsm::should_stop): Rename from
15108 until_break_fsm_should_stop.
15109 (until_break_fsm::clean_up): Rename from
15110 until_break_fsm_clean_up.
15111 (until_break_fsm::do_async_reply_reason): Rename from
15112 until_break_fsm_async_reply_reason.
15113 (until_break_command): Update.
15114 * thread-fsm.c: Remove.
15115 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15116
1a5c2598
TT		 151172019-02-07 Tom Tromey <tom@tromey.com>
15118
15119 * yy-remap.h: Add include guard.
15120 * xtensa-tdep.h: Add include guard.
15121 * xcoffread.h: Rename include guard.
15122 * varobj-iter.h: Add include guard.
15123 * tui/tui.h: Rename include guard.
15124 * tui/tui-winsource.h: Rename include guard.
15125 * tui/tui-wingeneral.h: Rename include guard.
15126 * tui/tui-windata.h: Rename include guard.
15127 * tui/tui-win.h: Rename include guard.
15128 * tui/tui-stack.h: Rename include guard.
15129 * tui/tui-source.h: Rename include guard.
15130 * tui/tui-regs.h: Rename include guard.
15131 * tui/tui-out.h: Rename include guard.
15132 * tui/tui-layout.h: Rename include guard.
15133 * tui/tui-io.h: Rename include guard.
15134 * tui/tui-hooks.h: Rename include guard.
15135 * tui/tui-file.h: Rename include guard.
15136 * tui/tui-disasm.h: Rename include guard.
15137 * tui/tui-data.h: Rename include guard.
15138 * tui/tui-command.h: Rename include guard.
15139 * tic6x-tdep.h: Add include guard.
15140 * target/waitstatus.h: Rename include guard.
15141 * target/wait.h: Rename include guard.
15142 * target/target.h: Rename include guard.
15143 * target/resume.h: Rename include guard.
15144 * target-float.h: Rename include guard.
15145 * stabsread.h: Add include guard.
15146 * rs6000-tdep.h: Add include guard.
15147 * riscv-fbsd-tdep.h: Add include guard.
15148 * regformats/regdef.h: Rename include guard.
15149 * record.h: Rename include guard.
15150 * python/python.h: Rename include guard.
15151 * python/python-internal.h: Rename include guard.
15152 * python/py-stopevent.h: Rename include guard.
15153 * python/py-ref.h: Rename include guard.
15154 * python/py-record.h: Rename include guard.
15155 * python/py-record-full.h: Rename include guard.
15156 * python/py-record-btrace.h: Rename include guard.
15157 * python/py-instruction.h: Rename include guard.
15158 * python/py-events.h: Rename include guard.
15159 * python/py-event.h: Rename include guard.
15160 * procfs.h: Add include guard.
15161 * proc-utils.h: Add include guard.
15162 * p-lang.h: Add include guard.
15163 * or1k-tdep.h: Rename include guard.
15164 * observable.h: Rename include guard.
15165 * nto-tdep.h: Rename include guard.
15166 * nat/x86-linux.h: Rename include guard.
15167 * nat/x86-linux-dregs.h: Rename include guard.
15168 * nat/x86-gcc-cpuid.h: Add include guard.
15169 * nat/x86-dregs.h: Rename include guard.
15170 * nat/x86-cpuid.h: Rename include guard.
15171 * nat/ppc-linux.h: Rename include guard.
15172 * nat/mips-linux-watch.h: Rename include guard.
15173 * nat/linux-waitpid.h: Rename include guard.
15174 * nat/linux-ptrace.h: Rename include guard.
15175 * nat/linux-procfs.h: Rename include guard.
15176 * nat/linux-osdata.h: Rename include guard.
15177 * nat/linux-nat.h: Rename include guard.
15178 * nat/linux-namespaces.h: Rename include guard.
15179 * nat/linux-btrace.h: Rename include guard.
15180 * nat/glibc_thread_db.h: Rename include guard.
15181 * nat/gdb_thread_db.h: Rename include guard.
15182 * nat/gdb_ptrace.h: Rename include guard.
15183 * nat/fork-inferior.h: Rename include guard.
15184 * nat/amd64-linux-siginfo.h: Rename include guard.
15185 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15186 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15187 * nat/aarch64-linux.h: Rename include guard.
15188 * nat/aarch64-linux-hw-point.h: Rename include guard.
15189 * mn10300-tdep.h: Add include guard.
15190 * mips-linux-tdep.h: Add include guard.
15191 * mi/mi-parse.h: Rename include guard.
15192 * mi/mi-out.h: Rename include guard.
15193 * mi/mi-main.h: Rename include guard.
15194 * mi/mi-interp.h: Rename include guard.
15195 * mi/mi-getopt.h: Rename include guard.
15196 * mi/mi-console.h: Rename include guard.
15197 * mi/mi-common.h: Rename include guard.
15198 * mi/mi-cmds.h: Rename include guard.
15199 * mi/mi-cmd-break.h: Rename include guard.
15200 * m2-lang.h: Add include guard.
15201 * location.h: Rename include guard.
15202 * linux-record.h: Rename include guard.
15203 * linux-nat.h: Add include guard.
15204 * linux-fork.h: Add include guard.
15205 * i386-darwin-tdep.h: Rename include guard.
15206 * hppa-linux-offsets.h: Add include guard.
15207 * guile/guile.h: Rename include guard.
15208 * guile/guile-internal.h: Rename include guard.
15209 * gnu-nat.h: Rename include guard.
15210 * gdb-stabs.h: Rename include guard.
15211 * frv-tdep.h: Add include guard.
15212 * f-lang.h: Add include guard.
15213 * event-loop.h: Add include guard.
15214 * darwin-nat.h: Rename include guard.
15215 * cp-abi.h: Rename include guard.
15216 * config/sparc/nm-sol2.h: Rename include guard.
15217 * config/nm-nto.h: Rename include guard.
15218 * config/nm-linux.h: Add include guard.
15219 * config/i386/nm-i386gnu.h: Rename include guard.
15220 * config/djgpp/nl_types.h: Rename include guard.
15221 * config/djgpp/langinfo.h: Rename include guard.
15222 * compile/gcc-cp-plugin.h: Add include guard.
15223 * compile/gcc-c-plugin.h: Add include guard.
15224 * compile/compile.h: Rename include guard.
15225 * compile/compile-object-run.h: Rename include guard.
15226 * compile/compile-object-load.h: Rename include guard.
15227 * compile/compile-internal.h: Rename include guard.
15228 * compile/compile-cplus.h: Rename include guard.
15229 * compile/compile-c.h: Rename include guard.
15230 * common/xml-utils.h: Rename include guard.
15231 * common/x86-xstate.h: Rename include guard.
15232 * common/version.h: Rename include guard.
15233 * common/vec.h: Rename include guard.
15234 * common/tdesc.h: Rename include guard.
15235 * common/selftest.h: Rename include guard.
15236 * common/scoped_restore.h: Rename include guard.
15237 * common/scoped_mmap.h: Rename include guard.
15238 * common/scoped_fd.h: Rename include guard.
15239 * common/safe-iterator.h: Rename include guard.
15240 * common/run-time-clock.h: Rename include guard.
15241 * common/refcounted-object.h: Rename include guard.
15242 * common/queue.h: Rename include guard.
15243 * common/ptid.h: Rename include guard.
15244 * common/print-utils.h: Rename include guard.
15245 * common/preprocessor.h: Rename include guard.
15246 * common/pathstuff.h: Rename include guard.
15247 * common/observable.h: Rename include guard.
15248 * common/netstuff.h: Rename include guard.
15249 * common/job-control.h: Rename include guard.
15250 * common/host-defs.h: Rename include guard.
15251 * common/gdb_wait.h: Rename include guard.
15252 * common/gdb_vecs.h: Rename include guard.
15253 * common/gdb_unlinker.h: Rename include guard.
15254 * common/gdb_unique_ptr.h: Rename include guard.
15255 * common/gdb_tilde_expand.h: Rename include guard.
15256 * common/gdb_sys_time.h: Rename include guard.
15257 * common/gdb_string_view.h: Rename include guard.
15258 * common/gdb_splay_tree.h: Rename include guard.
15259 * common/gdb_setjmp.h: Rename include guard.
15260 * common/gdb_ref_ptr.h: Rename include guard.
15261 * common/gdb_optional.h: Rename include guard.
15262 * common/gdb_locale.h: Rename include guard.
15263 * common/gdb_assert.h: Rename include guard.
15264 * common/filtered-iterator.h: Rename include guard.
15265 * common/filestuff.h: Rename include guard.
15266 * common/fileio.h: Rename include guard.
15267 * common/environ.h: Rename include guard.
15268 * common/common-utils.h: Rename include guard.
15269 * common/common-types.h: Rename include guard.
15270 * common/common-regcache.h: Rename include guard.
15271 * common/common-inferior.h: Rename include guard.
15272 * common/common-gdbthread.h: Rename include guard.
15273 * common/common-exceptions.h: Rename include guard.
15274 * common/common-defs.h: Rename include guard.
15275 * common/common-debug.h: Rename include guard.
15276 * common/cleanups.h: Rename include guard.
15277 * common/buffer.h: Rename include guard.
15278 * common/btrace-common.h: Rename include guard.
15279 * common/break-common.h: Rename include guard.
15280 * cli/cli-utils.h: Rename include guard.
15281 * cli/cli-style.h: Rename include guard.
15282 * cli/cli-setshow.h: Rename include guard.
15283 * cli/cli-script.h: Rename include guard.
15284 * cli/cli-interp.h: Rename include guard.
15285 * cli/cli-decode.h: Rename include guard.
15286 * cli/cli-cmds.h: Rename include guard.
15287 * charset-list.h: Add include guard.
15288 * buildsym-legacy.h: Rename include guard.
15289 * bfin-tdep.h: Add include guard.
15290 * ax.h: Rename include guard.
15291 * arm-linux-tdep.h: Add include guard.
15292 * arm-fbsd-tdep.h: Add include guard.
15293 * arch/xtensa.h: Rename include guard.
15294 * arch/tic6x.h: Add include guard.
15295 * arch/i386.h: Add include guard.
15296 * arch/arm.h: Rename include guard.
15297 * arch/arm-linux.h: Rename include guard.
15298 * arch/arm-get-next-pcs.h: Rename include guard.
15299 * arch/amd64.h: Add include guard.
15300 * arch/aarch64-insn.h: Rename include guard.
15301 * arch-utils.h: Rename include guard.
15302 * annotate.h: Add include guard.
15303 * amd64-darwin-tdep.h: Rename include guard.
15304 * aarch64-linux-tdep.h: Add include guard.
15305 * aarch64-fbsd-tdep.h: Add include guard.
15306 * aarch32-linux-nat.h: Add include guard.
15307
ab9268d2
PW		 153082019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15309
15310 * macrotab.c (macro_define_internal): New function that
15311 factorizes macro_define_object_internal and macro_define_function
15312 code.
15313 (macro_define_object_internal): Use macro_define_internal.
15314 (macro_define_function): Likewise.
15315
bb0da2b4
PW		 153162019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15317
15318 * macrocmd.c (extract_identifier): Return
15319 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15320 callers.
15321
424eb552
JB		 153222019-02-06 John Baldwin <jhb@FreeBSD.org>
15323
15324 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15325
1688cb29
TT		 153262019-02-05 Tom Tromey <tom@tromey.com>
15327
15328 * target.c (target_stack::unpush): Move assertion earlier.
15329
b5eba2d8
TT		 153302019-01-30 Tom Tromey <tom@tromey.com>
15331
15332 PR python/23615:
15333 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15334 (gdbpy_parse_and_eval): Likewise.
15335 * python/python-internal.h (gdbpy_allow_threads): New class.
15336
7054e2ff
JB		 153372019-01-28 John Baldwin <jhb@FreeBSD.org>
15338
15339 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15340 (aarch64_fbsd_fpregmap): Move earlier.
15341 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15342 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15343 instead of individual calls to trad_frame_set_reg_addr.
15344 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15345 earlier.
15346 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15347 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15348 instead of individual calls to trad_frame_set_reg_addr.
15349
36c25ffa
AH		 153502019-01-28 Alan Hayward <alan.hayward@arm.com>
15351
15352 * CONTRIBUTE: Replace contribution list with wiki link.
15353
a0707f3c
TT		 153542019-01-25 Tom Tromey <tom@tromey.com>
15355
15356 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15357
0747795c
TT		 153582019-01-25 Tom Tromey <tom@tromey.com>
15359
15360 * xtensa-linux-nat.c: Fix common/ includes.
15361 * xml-support.h: Fix common/ includes.
15362 * xml-support.c: Fix common/ includes.
15363 * x86-linux-nat.c: Fix common/ includes.
15364 * windows-nat.c: Fix common/ includes.
15365 * varobj.h: Fix common/ includes.
15366 * varobj.c: Fix common/ includes.
15367 * value.c: Fix common/ includes.
15368 * valops.c: Fix common/ includes.
15369 * utils.c: Fix common/ includes.
15370 * unittests/xml-utils-selftests.c: Fix common/ includes.
15371 * unittests/utils-selftests.c: Fix common/ includes.
15372 * unittests/unpack-selftests.c: Fix common/ includes.
15373 * unittests/tracepoint-selftests.c: Fix common/ includes.
15374 * unittests/style-selftests.c: Fix common/ includes.
15375 * unittests/string_view-selftests.c: Fix common/ includes.
15376 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15377 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15378 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15379 * unittests/rsp-low-selftests.c: Fix common/ includes.
15380 * unittests/parse-connection-spec-selftests.c: Fix common/
15381 includes.
15382 * unittests/optional-selftests.c: Fix common/ includes.
15383 * unittests/offset-type-selftests.c: Fix common/ includes.
15384 * unittests/observable-selftests.c: Fix common/ includes.
15385 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15386 * unittests/memrange-selftests.c: Fix common/ includes.
15387 * unittests/memory-map-selftests.c: Fix common/ includes.
15388 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15389 * unittests/function-view-selftests.c: Fix common/ includes.
15390 * unittests/environ-selftests.c: Fix common/ includes.
15391 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15392 * unittests/common-utils-selftests.c: Fix common/ includes.
15393 * unittests/cli-utils-selftests.c: Fix common/ includes.
15394 * unittests/array-view-selftests.c: Fix common/ includes.
15395 * ui-file.c: Fix common/ includes.
15396 * tui/tui-io.c: Fix common/ includes.
15397 * tracepoint.h: Fix common/ includes.
15398 * tracepoint.c: Fix common/ includes.
15399 * tracefile-tfile.c: Fix common/ includes.
15400 * top.h: Fix common/ includes.
15401 * top.c: Fix common/ includes.
15402 * thread.c: Fix common/ includes.
15403 * target/waitstatus.h: Fix common/ includes.
15404 * target/waitstatus.c: Fix common/ includes.
15405 * target.h: Fix common/ includes.
15406 * target.c: Fix common/ includes.
15407 * target-memory.c: Fix common/ includes.
15408 * target-descriptions.c: Fix common/ includes.
15409 * symtab.h: Fix common/ includes.
15410 * symfile.c: Fix common/ includes.
15411 * stap-probe.c: Fix common/ includes.
15412 * spu-linux-nat.c: Fix common/ includes.
15413 * sparc-nat.c: Fix common/ includes.
15414 * source.c: Fix common/ includes.
15415 * solib.c: Fix common/ includes.
15416 * solib-target.c: Fix common/ includes.
15417 * ser-unix.c: Fix common/ includes.
15418 * ser-tcp.c: Fix common/ includes.
15419 * ser-pipe.c: Fix common/ includes.
15420 * ser-base.c: Fix common/ includes.
15421 * selftest-arch.c: Fix common/ includes.
15422 * s12z-tdep.c: Fix common/ includes.
15423 * rust-exp.y: Fix common/ includes.
15424 * rs6000-aix-tdep.c: Fix common/ includes.
15425 * riscv-tdep.c: Fix common/ includes.
15426 * remote.c: Fix common/ includes.
15427 * remote-notif.h: Fix common/ includes.
15428 * remote-fileio.h: Fix common/ includes.
15429 * remote-fileio.c: Fix common/ includes.
15430 * regcache.h: Fix common/ includes.
15431 * regcache.c: Fix common/ includes.
15432 * record-btrace.c: Fix common/ includes.
15433 * python/python.c: Fix common/ includes.
15434 * python/py-type.c: Fix common/ includes.
15435 * python/py-inferior.c: Fix common/ includes.
15436 * progspace.h: Fix common/ includes.
15437 * producer.c: Fix common/ includes.
15438 * procfs.c: Fix common/ includes.
15439 * proc-api.c: Fix common/ includes.
15440 * printcmd.c: Fix common/ includes.
15441 * ppc-linux-nat.c: Fix common/ includes.
15442 * parser-defs.h: Fix common/ includes.
15443 * osdata.c: Fix common/ includes.
15444 * obsd-nat.c: Fix common/ includes.
15445 * nat/x86-linux.c: Fix common/ includes.
15446 * nat/x86-linux-dregs.c: Fix common/ includes.
15447 * nat/x86-dregs.h: Fix common/ includes.
15448 * nat/x86-dregs.c: Fix common/ includes.
15449 * nat/ppc-linux.c: Fix common/ includes.
15450 * nat/mips-linux-watch.h: Fix common/ includes.
15451 * nat/mips-linux-watch.c: Fix common/ includes.
15452 * nat/linux-waitpid.c: Fix common/ includes.
15453 * nat/linux-ptrace.h: Fix common/ includes.
15454 * nat/linux-ptrace.c: Fix common/ includes.
15455 * nat/linux-procfs.c: Fix common/ includes.
15456 * nat/linux-personality.c: Fix common/ includes.
15457 * nat/linux-osdata.c: Fix common/ includes.
15458 * nat/linux-namespaces.c: Fix common/ includes.
15459 * nat/linux-btrace.h: Fix common/ includes.
15460 * nat/linux-btrace.c: Fix common/ includes.
15461 * nat/fork-inferior.c: Fix common/ includes.
15462 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15463 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15464 * nat/aarch64-linux.c: Fix common/ includes.
15465 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15466 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15467 * namespace.h: Fix common/ includes.
15468 * mips-linux-tdep.c: Fix common/ includes.
15469 * minsyms.c: Fix common/ includes.
15470 * mi/mi-parse.h: Fix common/ includes.
15471 * mi/mi-main.c: Fix common/ includes.
15472 * mi/mi-cmd-env.c: Fix common/ includes.
15473 * memrange.h: Fix common/ includes.
15474 * memattr.c: Fix common/ includes.
15475 * maint.h: Fix common/ includes.
15476 * maint.c: Fix common/ includes.
15477 * main.c: Fix common/ includes.
15478 * machoread.c: Fix common/ includes.
15479 * location.c: Fix common/ includes.
15480 * linux-thread-db.c: Fix common/ includes.
15481 * linux-nat.c: Fix common/ includes.
15482 * linux-fork.c: Fix common/ includes.
15483 * inline-frame.c: Fix common/ includes.
15484 * infrun.c: Fix common/ includes.
15485 * inflow.c: Fix common/ includes.
15486 * inferior.h: Fix common/ includes.
15487 * inferior.c: Fix common/ includes.
15488 * infcmd.c: Fix common/ includes.
15489 * inf-ptrace.c: Fix common/ includes.
15490 * inf-child.c: Fix common/ includes.
15491 * ia64-linux-nat.c: Fix common/ includes.
15492 * i387-tdep.c: Fix common/ includes.
15493 * i386-tdep.c: Fix common/ includes.
15494 * i386-linux-tdep.c: Fix common/ includes.
15495 * i386-linux-nat.c: Fix common/ includes.
15496 * i386-go32-tdep.c: Fix common/ includes.
15497 * i386-fbsd-tdep.c: Fix common/ includes.
15498 * i386-fbsd-nat.c: Fix common/ includes.
15499 * guile/scm-type.c: Fix common/ includes.
15500 * guile/guile.c: Fix common/ includes.
15501 * go32-nat.c: Fix common/ includes.
15502 * gnu-nat.c: Fix common/ includes.
15503 * gdbthread.h: Fix common/ includes.
15504 * gdbarch-selftests.c: Fix common/ includes.
15505 * gdb_usleep.c: Fix common/ includes.
15506 * gdb_select.h: Fix common/ includes.
15507 * gdb_bfd.c: Fix common/ includes.
15508 * gcore.c: Fix common/ includes.
15509 * fork-child.c: Fix common/ includes.
15510 * findvar.c: Fix common/ includes.
15511 * fbsd-nat.c: Fix common/ includes.
15512 * event-top.c: Fix common/ includes.
15513 * event-loop.c: Fix common/ includes.
15514 * dwarf2read.c: Fix common/ includes.
15515 * dwarf2loc.c: Fix common/ includes.
15516 * dwarf2-frame.c: Fix common/ includes.
15517 * dwarf-index-cache.c: Fix common/ includes.
15518 * dtrace-probe.c: Fix common/ includes.
15519 * disasm-selftests.c: Fix common/ includes.
15520 * defs.h: Fix common/ includes.
15521 * csky-tdep.c: Fix common/ includes.
15522 * cp-valprint.c: Fix common/ includes.
15523 * cp-support.h: Fix common/ includes.
15524 * cp-support.c: Fix common/ includes.
15525 * corelow.c: Fix common/ includes.
15526 * completer.h: Fix common/ includes.
15527 * completer.c: Fix common/ includes.
15528 * compile/compile.c: Fix common/ includes.
15529 * compile/compile-loc2c.c: Fix common/ includes.
15530 * compile/compile-cplus-types.c: Fix common/ includes.
15531 * compile/compile-cplus-symbols.c: Fix common/ includes.
15532 * command.h: Fix common/ includes.
15533 * cli/cli-dump.c: Fix common/ includes.
15534 * cli/cli-cmds.c: Fix common/ includes.
15535 * charset.c: Fix common/ includes.
15536 * build-id.c: Fix common/ includes.
15537 * btrace.h: Fix common/ includes.
15538 * btrace.c: Fix common/ includes.
15539 * breakpoint.h: Fix common/ includes.
15540 * breakpoint.c: Fix common/ includes.
15541 * ax.h:
15542 (enum agent_op): Fix common/ includes.
15543 * ax-general.c (struct aop_map): Fix common/ includes.
15544 * ax-gdb.c: Fix common/ includes.
15545 * auxv.c: Fix common/ includes.
15546 * auto-load.c: Fix common/ includes.
15547 * arm-tdep.c: Fix common/ includes.
15548 * arch/riscv.c: Fix common/ includes.
15549 * arch/ppc-linux-common.c: Fix common/ includes.
15550 * arch/i386.c: Fix common/ includes.
15551 * arch/arm.c: Fix common/ includes.
15552 * arch/arm-linux.c: Fix common/ includes.
15553 * arch/arm-get-next-pcs.c: Fix common/ includes.
15554 * arch/amd64.c: Fix common/ includes.
15555 * arch/aarch64.c: Fix common/ includes.
15556 * arch/aarch64-insn.c: Fix common/ includes.
15557 * arch-utils.c: Fix common/ includes.
15558 * amd64-windows-tdep.c: Fix common/ includes.
15559 * amd64-tdep.c: Fix common/ includes.
15560 * amd64-sol2-tdep.c: Fix common/ includes.
15561 * amd64-obsd-tdep.c: Fix common/ includes.
15562 * amd64-nbsd-tdep.c: Fix common/ includes.
15563 * amd64-linux-tdep.c: Fix common/ includes.
15564 * amd64-linux-nat.c: Fix common/ includes.
15565 * amd64-fbsd-tdep.c: Fix common/ includes.
15566 * amd64-fbsd-nat.c: Fix common/ includes.
15567 * amd64-dicos-tdep.c: Fix common/ includes.
15568 * amd64-darwin-tdep.c: Fix common/ includes.
15569 * agent.c: Fix common/ includes.
15570 * ada-lang.h: Fix common/ includes.
15571 * ada-lang.c: Fix common/ includes.
15572 * aarch64-tdep.c: Fix common/ includes.
15573
2f5c153e
TT		 155742019-01-25 Tom Tromey <tom@tromey.com>
15575
15576 * common/create-version.sh: Use common/version.h.
15577
adc6a863
PA		 155782019-01-24 Pedro Alves <palves@redhat.com>
15579
15580 * infrun.c (signal_stop, signal_print, signal_program)
15581 (signal_catch, signal_pass): Now arrays instead of pointers.
15582 (update_signals_program_target, do_target_resume)
15583 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15584 * linux-nat.c (linux_nat_target::pass_signals)
15585 (linux_nat_target::create_inferior, linux_nat_target::attach):
15586 Adjust.
15587 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15588 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15589 * procfs.c (procfs_target::pass_signals): Adjust.
15590 * record-full.c (record_full_target::resume): Adjust.
15591 * remote.c (remote_target::pass_signals)
15592 (remote_target::program_signals): Adjust.
15593 * target-debug.h (target_debug_print_signals): Now takes a
15594 gdb::array_view as parameter. Adjust.
15595 * target.h (target_ops) <pass_signals, program_signals>: Replace
15596 pointer and length parameters with gdb::array_view.
15597 (target_pass_signals, target_program_signals): Likewise.
15598 * target-delegates.c: Regenerate.
15599
3046d67a
PA		 156002019-01-24 Pedro Alves <palves@redhat.com>
15601
15602 * common/forward-scope-exit.h
15603 (forward_scope_exit::forward_scope_exit): Pass arguments to
15604 m_bind_function directly, instead of creating a std::bind and
15605 copying that.
15606
353229bf
AH		 156072019-01-24 Alan Hayward <alan.hayward@arm.com>
15608
15609 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15610 for static members.
15611 (pass_in_v_vfp_candidate): Likewise.
15612
311dc83a
TT		 156132019-01-23 Tom Tromey <tom@tromey.com>
15614 Pedro Alves <palves@redhat.com>
15615
15616 * regcache.c (class regcache_invalidator): Remove.
15617 (regcache::raw_write): Use make_scope_exit.
15618
296bd123
TT		 156192019-01-23 Tom Tromey <tom@tromey.com>
15620
15621 * ui-out.h (class ui_out_emit_type): Update comment.
15622
979a0d13
TT		 156232019-01-23 Tom Tromey <tom@tromey.com>
15624
15625 * infrun.c (fetch_inferior_event): Update comment.
15626
d238133d
TT		 156272019-01-23 Tom Tromey <tom@tromey.com>
15628 Pedro Alves <palves@redhat.com>
15629
15630 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15631 parameter.
15632 (fetch_inferior_event): Use SCOPE_EXIT.
15633
15634
9885e6bb
TT		 156352019-01-23 Tom Tromey <tom@tromey.com>
15636 Pedro Alves <palves@redhat.com>
15637
15638 * infrun.c (disable_thread_events): Delete.
15639 (stop_all_threads): Use SCOPE_EXIT.
15640
286526c1
TT		 156412019-01-23 Tom Tromey <tom@tromey.com>
15642 Pedro Alves <palves@redhat.com>
15643
15644 * symfile.c: Include forward-scope-exit.h.
15645 (clear_symtab_users_cleanup): Replace forward declaration with
15646 a FORWARD_SCOPE_EXIT.
15647 (syms_from_objfile_1): Use the forward_scope_exit and
15648 gdb::optional instead of cleanup_function.
15649 (reread_symbols): Use the forward_scope_exit instead of
15650 cleanup_function.
15651 (clear_symtab_users_cleanup): Remove function.
15652
1db93f14
TT		 156532019-01-23 Tom Tromey <tom@tromey.com>
15654 Pedro Alves <palves@redhat.com>
15655
15656 * linux-nat.c: Include scope-exit.h.
15657 (cleanup_target_stop): Remove.
15658 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15659 SCOPE_EXIT.
15660
2cc83d1e
TT		 156612019-01-23 Tom Tromey <tom@tromey.com>
15662 Pedro Alves <palves@redhat.com>
15663
15664 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15665 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15666
694c6bf5
TT		 156672019-01-23 Tom Tromey <tom@tromey.com>
15668 Andrew Burgess <andrew.burgess@embecosm.com>
15669 Pedro Alves <palves@redhat.com>
15670
15671 * infrun.c (fetch_inferior_event): Use scope_exit.
15672 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15673 * top.c (execute_command): Use scope_exit.
15674 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15675 * utils.c (do_bpstat_clear_actions_cleanup)
15676 (make_bpstat_clear_actions_cleanup): Remove.
15677
4c41382a
TT		 156782019-01-23 Tom Tromey <tom@tromey.com>
15679 Pedro Alves <palves@redhat.com>
15680
15681 * infrun.c: Include "common/scope-exit.h"
15682 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15683 (wait_for_inferior): Use SCOPE_EXIT.
15684 (fetch_inferior_event): Use scope_exit.
15685
89f8fb50
TT		 156862019-01-23 Tom Tromey <tom@tromey.com>
15687 Pedro Alves <palves@redhat.com>
15688
15689 * breakpoint.c (create_breakpoint): Remove cleanup.
15690
5419bdae
TT		 156912019-01-23 Tom Tromey <tom@tromey.com>
15692 Andrew Burgess <andrew.burgess@embecosm.com>
15693 Pedro Alves <palves@redhat.com>
15694
e587ef42
PA		 156952019-01-23 Pedro Alves <palves@redhat.com>
15696
15697 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15698
77f0e74c
PA		 156992019-01-23 Pedro Alves <palves@redhat.com>
15700 Andrew Burgess <andrew.burgess@embecosm.com>
15701
15702 * gdbthread.h: Include "common/forward-scope-exit.h".
15703 (scoped_finish_thread_state): Redefine custom class in terms of
15704 forward_scope_exit.
15705
5b9b3e53
PA		 157062019-01-23 Pedro Alves <palves@redhat.com>
15707 Andrew Burgess <andrew.burgess@embecosm.com>
15708
15709 * common/forward-scope-exit.h: New file.
15710
54b65c9b
PA		 157112019-01-23 Pedro Alves <palves@redhat.com>
15712 Andrew Burgess <andrew.burgess@embecosm.com>
15713 Tom Tromey <tom@tromey.com>
15714
15715 * common/scope-exit.h: New file.
15716
cf08fb29
PA		 157172019-01-23 Pedro Alves <palves@redhat.com>
15718
15719 * common/preprocessor.h (ESC): Rename to ...
15720 (ESC_PARENS): ... this.
15721 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15722 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15723
ae73e2e2
TT		 157242019-01-23 Tom Tromey <tom@tromey.com>
15725
15726 * language.h (class scoped_switch_to_sym_language_if_auto):
15727 Initialize m_lang in both cases.
15728
6594e122
AH		 157292019-01-23 Alan Hayward <alan.hayward@arm.com>
15730
15731 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15732 with XCNEW.
15733
a7c9855d
TT		 157342019-01-22 Tom Tromey <tom@tromey.com>
15735
15736 * corelow.c: Do not include sys/file.h.
15737
93cc1d53
TT		 157382019-01-22 Tom Tromey <tom@tromey.com>
15739
15740 * tui/tui-wingeneral.h: Include gdb_curses.h.
15741
38561778
TT		 157422019-01-22 Tom Tromey <tom@tromey.com>
15743
15744 * source-cache.h (class source_cache) <get_source_lines,
15745 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15746
37b3ab5b
TT		 157472019-01-22 Tom Tromey <tom@tromey.com>
15748
15749 * remote-fileio.h (struct remote_target): Declare.
15750
3fabc016
TT		 157512019-01-22 Tom Tromey <tom@tromey.com>
15752
15753 * python/py-arch.c: Do not include py-ref.h.
15754 * python/py-bpevent.c: Do not include py-ref.h.
15755 * python/py-cmd.c: Do not include py-ref.h.
15756 * python/py-continueevent.c: Do not include py-ref.h.
15757 * python/py-event.h: Do not include py-ref.h.
15758 * python/py-evtregistry.c: Do not include py-ref.h.
15759 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15760 * python/py-frame.c: Do not include py-ref.h.
15761 * python/py-framefilter.c: Do not include py-ref.h.
15762 * python/py-function.c: Do not include py-ref.h.
15763 * python/py-infevents.c: Do not include py-ref.h.
15764 * python/py-linetable.c: Do not include py-ref.h.
15765 * python/py-objfile.c: Do not include py-ref.h.
15766 * python/py-param.c: Do not include py-ref.h.
15767 * python/py-prettyprint.c: Do not include py-ref.h.
15768 * python/py-progspace.c: Do not include py-ref.h.
15769 * python/py-symbol.c: Do not include py-ref.h.
15770 * python/py-symtab.c: Do not include py-ref.h.
15771 * python/py-type.c: Do not include py-ref.h.
15772 * python/py-unwind.c: Do not include py-ref.h.
15773 * python/py-utils.c: Do not include py-ref.h.
15774 * python/py-value.c: Do not include py-ref.h.
15775 * python/py-varobj.c: Do not include py-ref.h.
15776 * python/py-xmethods.c: Do not include py-ref.h.
15777 * python/python.c: Do not include py-ref.h.
15778 * varobj.c: Do not include py-ref.h.
15779
6b4d7774
TT		 157802019-01-22 Tom Tromey <tom@tromey.com>
15781
15782 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15783 keyword for bcache.
15784
7af7e9b5
TT		 157852019-01-22 Tom Tromey <tom@tromey.com>
15786
15787 * compile/compile-cplus-types.c: Remove a comment by #include.
15788
951d1049
TT		 157892019-01-22 Tom Tromey <tom@tromey.com>
15790
15791 * compile/gcc-c-plugin.h: Include compile-internal.h.
15792
d65d5705
TT		 157932019-01-22 Tom Tromey <tom@tromey.com>
15794
15795 * stabsread.c (EXTERN): Do not define.
15796 (symnum, next_symbol_text_func, processing_gcc_compilation)
15797 (within_function, global_sym_chain, global_stabs)
15798 (previous_stab_code, this_object_header_files)
15799 (n_this_object_header_files)
15800 (n_allocated_this_object_header_files): Define.
15801 * stabsread.h (EXTERN): Never define. Use "extern".
15802
b6fb1ee5
PW		 158032019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15804
15805 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15806 history_value.
15807
be6d4f74
TT		 158082019-01-21 Tom Tromey <tom@tromey.com>
15809
15810 * ui-out.c: Fix includes.
15811 * tui/tui-source.c: Fix includes.
15812 * target.c: Fix includes.
15813 * remote.c: Fix includes.
15814 * regcache.c: Fix includes.
15815 * python/py-block.c: Fix includes.
15816 * printcmd.c: Fix includes.
15817 * or1k-tdep.c: Fix includes.
15818 * mi/mi-main.c: Fix includes.
15819 * m32r-tdep.c: Fix includes.
15820 * csky-tdep.c: Fix includes.
15821 * compile/compile-cplus-types.c: Fix includes.
15822 * cli/cli-interp.c: Fix includes.
15823
73021deb
AH		 158242019-01-21 Alan Hayward <alan.hayward@arm.com>
15825
15826 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15827 for padding.
15828
7932255d
TT		 158292019-01-16 Tom Tromey <tom@tromey.com>
15830
15831 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15832 earlier.
15833 (struct objfile) <msymbols_range>: Move from top level.
15834 <msymbols>: New method.
15835 (class objfile_msymbols): Remove.
15836 * symtab.c (default_collect_symbol_completion_matches_break_on):
15837 Update.
15838 * symmisc.c (dump_msymbols): Update.
15839 * stabsread.c (scan_file_globals): Update.
15840 * objc-lang.c (info_selectors_command, info_classes_command)
15841 (find_methods): Update.
15842 * minsyms.c (find_solib_trampoline_target): Update.
15843 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15844 * coffread.c (coff_symfile_read): Update.
15845 * ada-lang.c (ada_lookup_simple_minsym)
15846 (ada_collect_symbol_completion_matches): Update.
15847
604b1bfb
TT		 158482019-01-16 Tom Tromey <tom@tromey.com>
15849
15850 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15851 type. Remove no-argument constructor.
15852 <iterator::operator++>: Simplify.
15853 <begin>: Update.
15854 <end>: Use minimal_symbol_count.
15855
f252c6d5
TT		 158562019-01-16 Tom Tromey <tom@tromey.com>
15857
15858 * objfiles.h (struct objfile) <psymtabs>: New method.
15859 (class objfile_psymtabs): Remove.
15860 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15861 typedef.
15862 <range>: New method.
15863 (require_partial_symbols): Change return type.
15864 * psymtab.c (require_partial_symbols)
15865 (psym_expand_symtabs_matching): Update.
15866 * mdebugread.c (parse_partial_symbols): Update.
15867 * dbxread.c (dbx_end_psymtab): Update.
15868
b669c953
TT		 158692019-01-15 Tom Tromey <tom@tromey.com>
15870
15871 * symtab.c (lookup_objfile_from_block)
15872 (lookup_symbol_in_objfile_symtabs)
15873 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15874 (find_line_symtab, info_sources_command)
15875 (default_collect_symbol_completion_matches_break_on)
15876 (make_source_files_completion_list): Update.
15877 * symmisc.c (print_objfile_statistics, dump_objfile)
15878 (maintenance_print_symbols, maintenance_info_symtabs)
15879 (maintenance_check_symtabs, maintenance_info_line_tables):
15880 Update.
15881 * source.c (select_source_symtab)
15882 (forget_cached_source_info_for_objfile): Update.
15883 * objfiles.h (class objfile_compunits): Remove.
15884 (struct objfile) <compunits_range>: New typedef.
15885 (compunits): New method.
15886 * objfiles.c (objfile_relocate1): Update.
15887 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15888 * maint.c (count_symtabs_and_blocks): Update.
15889 * linespec.c (iterate_over_all_matching_symtabs): Update.
15890 * cp-support.c (add_symbol_overload_list_qualified): Update.
15891 * coffread.c (coff_symtab_read): Update.
15892 * ada-lang.c (add_nonlocal_symbols)
15893 (ada_collect_symbol_completion_matches)
15894 (ada_add_global_exceptions): Update.
15895
7e955d83
TT		 158962019-01-15 Tom Tromey <tom@tromey.com>
15897
15898 * progspace.h (program_space) <objfiles_safe_range>: New
15899 typedef.
15900 <objfiles_safe>: New method.
15901 * objfiles.h (class all_objfiles_safe): Remove.
15902 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15903 * jit.c (jit_inferior_exit_hook): Update.
15904
2030c079
TT		 159052019-01-17 Tom Tromey <tom@tromey.com>
15906
15907 * progspace.h (program_space) <objfiles_range>: New typedef.
15908 <objfiles>: New method.
15909 <objfiles_head>: Rename from objfiles.
15910 (object_files): Update.
15911 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15912 * guile/scm-pretty-print.c
15913 (ppscm_find_pretty_printer_from_objfiles): Update.
15914 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15915 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15916 Update.
15917 * python/py-progspace.c (pspy_get_objfiles): Update.
15918 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15919 Update.
15920 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15921 (objfpy_lookup_objfile_by_build_id): Update.
15922 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15923 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15924 Update.
15925 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15926 (expand_symtab_containing_pc, lookup_objfile_from_block)
15927 (lookup_static_symbol, basic_lookup_transparent_type)
15928 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15929 (find_line_symtab, info_sources_command)
15930 (default_collect_symbol_completion_matches_break_on)
15931 (make_source_files_completion_list, find_main_name): Update.
15932 * symmisc.c (print_symbol_bcache_statistics)
15933 (print_objfile_statistics, maintenance_print_symbols)
15934 (maintenance_print_msymbols, maintenance_print_objfiles)
15935 (maintenance_info_symtabs, maintenance_check_symtabs)
15936 (maintenance_expand_symtabs, maintenance_info_line_tables):
15937 Update.
15938 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15939 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15940 (map_overlay_command, unmap_overlay_command)
15941 (simple_overlay_update, expand_symtabs_matching)
15942 (map_symbol_filenames): Update.
15943 * symfile-debug.c (set_debug_symfile): Update.
15944 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15945 Update.
15946 * source.c (select_source_symtab, forget_cached_source_info):
15947 Update.
15948 * solib.c (solib_read_symbols): Update.
15949 * solib-spu.c (append_ocl_sos): Update.
15950 * psymtab.c (maintenance_print_psymbols)
15951 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15952 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15953 * printcmd.c (info_symbol_command): Update.
15954 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15955 Update.
15956 * objfiles.h (class all_objfiles): Remove.
15957 * objfiles.c (have_partial_symbols, have_full_symbols)
15958 (have_minimal_symbols, qsort_cmp, update_section_map)
15959 (shared_objfile_contains_address_p)
15960 (default_iterate_over_objfiles_in_search_order): Update.
15961 * objc-lang.c (info_selectors_command, info_classes_command)
15962 (find_methods): Update.
15963 * minsyms.c (find_solib_trampoline_target): Update.
15964 * maint.c (maintenance_info_sections)
15965 (maintenance_translate_address, count_symtabs_and_blocks):
15966 Update.
15967 * main.c (captured_main_1): Update.
15968 * linux-thread-db.c (try_thread_db_load_from_pdir)
15969 (has_libpthread): Update.
15970 * linespec.c (iterate_over_all_matching_symtabs)
15971 (search_minsyms_for_name): Update.
15972 * jit.c (jit_find_objf_with_entry_addr): Update.
15973 * hppa-tdep.c (find_unwind_entry)
15974 (hppa_lookup_stub_minimal_symbol): Update.
15975 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15976 Update.
15977 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15978 (elf_gnu_ifunc_resolve_by_got): Update.
15979 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15980 * dwarf-index-write.c (save_gdb_index_command): Update.
15981 * cp-support.c (add_symbol_overload_list_qualified): Update.
15982 * breakpoint.c (create_overlay_event_breakpoint)
15983 (create_longjmp_master_breakpoint)
15984 (create_std_terminate_master_breakpoint)
15985 (create_exception_master_breakpoint): Update.
15986 * blockframe.c (find_pc_partial_function): Update.
15987 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15988 (ada_collect_symbol_completion_matches)
15989 (ada_add_global_exceptions): Update.
15990
776489e0
TT		 159912019-01-17 Tom Tromey <tom@tromey.com>
15992
15993 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15994 declare VEC.
15995 (solib_target_parse_libraries): Change return type.
15996 (library_list_start_segment, library_list_start_section)
15997 (library_list_end_library, library_list_start_library); Update.
15998 (solib_target_free_library_list): Remove.
15999 (solib_target_parse_libraries): Remove cleanup. Change return
16000 type.
16001 (solib_target_current_sos): Update.
16002
6471e7d2
TT		 160032019-01-17 Tom Tromey <tromey@bapiya>
16004
16005 * valprint.c: Replace "the the" with "the".
16006 * symtab.c: Replace "the the" with "the".
16007 * solib.c: Replace "the the" with "the".
16008 * solib-dsbt.c: Replace "the the" with "the".
16009 * linespec.c: Replace "the the" with "the".
16010 * dwarf2loc.h: Replace "the the" with "the".
16011 * amd64-windows-tdep.c: Replace "the the" with "the".
16012 * aarch64-tdep.c: Replace "the the" with "the".
16013
c24bdb02
KS		 160142019-01-16 Keith Seitz <keiths@redhat.com>
16015
16016 PR gdb/23773
16017 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16018 <builder>: Rename to ..
16019 <m_builder>: ... this and make private.
16020 (dwarf2_cu::get_builder): New method. Change all users of
16021 `builder' to use this method.
16022 (dwarf2_start_symtab): Move to ...
16023 (dwarf2_cu::start_symtab): ... here. Update all callers
16024 (setup_type_unit_groups): Move to ...
16025 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16026 callers.
16027 (dwarf2_cu::reset_builder): New method.
16028 (process_full_compunit, process_full_type_unit): Use
16029 dwarf2_cu::reset_builder.
16030 (follow_die_offset): Record the ancestor CU if it is different
16031 from the followed DIE's CU.
16032 (follow_die_sig_1): Likewise.
16033
8d64371b
TT		 160342019-01-15 Tom Tromey <tom@tromey.com>
16035
16036 * remote.c (class remote_state) <buf>: Now a char_vector.
16037 <buf_size>: Remove.
16038 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16039 parameter.
16040 (remote_target::getpkt_or_notif_sane_1)
16041 (remote_target::getpkt_sane)
16042 (remote_target::getpkt_or_notif_sane): Likewise.
16043 (class remote_target) <putpkt>: New overload.
16044 (remote_target::read_frame): Change type of "buf_p". Remove
16045 sizeof_p parameter.
16046 (packet_ok): New overload.
16047 (packet_check_result): New overload.
16048 Update all uses.
16049
bb277751
TT		 160502019-01-14 Tom Tromey <tom@tromey.com>
16051
16052 * remote-notif.c (handle_notification, remote_notif_ack)
16053 (remote_notif_parse): Make "buf" const.
16054 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16055 const.
16056 (remote_notif_parse, remote_notif_ack, handle_notification):
16057 Likewise.
16058 * remote.c (remote_notif_stop_parse): Make "buf" const.
16059 (remote_target::remote_parse_stop_reply): Make "buf" const.
16060 (remote_notif_stop_ack): Make "buf" const.
16061
05be00a8
TT		 160622019-01-14 Tom Tromey <tom@tromey.com>
16063
16064 * remote.c (remote_console_output): Make parameter const.
16065
491adeca
TT		 160662019-01-14 Tom Tromey <tom@tromey.com>
16067
16068 * target-debug.h (target_debug_print_signals): Constify.
16069 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16070 * procfs.c (procfs_target::pass_signals): Update.
16071 * linux-nat.c (linux_nat_target::pass_signals): Update.
16072 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16073 * target-delegates.c: Rebuild.
16074 * remote.c (remote_target::program_signals): Update.
16075 (remote_target::pass_signals): Update.
16076 * target.c (target_pass_signals): Constify argument.
16077 (target_program_signals): Likewise.
16078 * target.h (struct target_ops) <pass_signals, program_signals>:
16079 Constify argument.
16080 (target_pass_signals, target_program_signals): Constify argument.
16081
bbd94648
TT		 160822019-01-14 Tom Tromey <tom@tromey.com>
16083
16084 PR tui/28819:
16085 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16086
6f072a10
PFC		 160872019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16088
16089 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16090 field.
16091 * rs6000-tdep.c: Include reggroups.h.
16092 (IS_V_ALIAS_PSEUDOREG): Define.
16093 (rs6000_register_name): Return names for the "vX" aliases.
16094 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16095 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16096 aliases. Call default_register_reggroup_p for all other
16097 pseudo-registers.
16098 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16099 New functions.
16100 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16101 Handle "vX" aliases.
16102 (v_alias_pseudo_register_collect): New function.
16103 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16104 (rs6000_gdbarch_init): Initialize "vX" aliases as
16105 pseudo-registers. Restore registration of
16106 rs6000_pseudo_register_reggroup_p with
16107 set_tdesc_pseudo_register_reggroup_p.
16108
1a782351
MF		 161092019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16110
16111 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16112 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16113 set_gdbarch_num_pseudo_regs.
16114
d73cff18
PW		 161152019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16116
16117 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16118 Remove arg prefixname, add do_set and do_show.
16119 Add member functions set_list and show_list.
16120 * cli/cli-style.c (class cli_style_option): Update accordingly.
16121 (style_set_list): Move to file scope.
16122 (style_show_list): Likewise.
16123 (set_style): Call help_list.
16124 (show_style): Call cmd_show_list.
16125 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16126 Update to use the new macro.
16127
60a90376
JB		 161282019-10-12 Joel Brobecker <brobecker@adacore.com>
16129
16130 * ada-lang.c (_initialize_ada_language): Expand the help text
16131 for the "catch exception" command.
16132
9d7c67bf
PW		 161332019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16134
16135 * symtab.c (matching_obj_sections): Initialize obj,
16136 declare it closer to its usage.
16137
7cf47dc4
TT		 161382019-01-10 Tom Tromey <tom@tromey.com>
16139
16140 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16141 (basic_inf_threads_range): Remove.
16142 (inf_threads_range, inf_non_exited_threads_range)
16143 (safe_inf_threads_range): Use next_adapter.
16144
d3cb6808
KS		 161452019-01-10 Keith Seitz <keiths@redhat.com>
16146
16147 PR gdb/23712
16148 PR symtab/23010
16149 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16150 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16151
63a20375
KS		 161522019-01-10 Keith Seitz <keiths@redhat.com>
16153
16154 PR gdb/23712
16155 PR symtab/23010
16156 * dictionary.c (pending_to_vector): Remove.
16157 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16158 Remove _1 suffix, replacing functions of the same name. Update
16159 all callers.
16160 (dict_create_hashed, dict_create_hashed_expandable)
16161 (dict_create_linear, dict_create_linear_expandable, dict_free)
16162 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16163 Make functions static.
16164
b026f593
KS		 161652019-01-10 Keith Seitz <keiths@redhat.com>
16166
16167 PR gdb/23712
16168 PR symtab/23010
16169 * dictionary.h (struct dictionary): Replace declaration with
16170 multidictionary.
16171 (dict_create_hashed, dict_create_hashed_expandable)
16172 (dict_create_linear, dict_create_linear_expandable)
16173 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16174 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16175 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16176 taking multidictionary argument.
16177 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16178 * block.h (struct block) <dict>: Change to multidictionary
16179 and rename `multidict'.
16180 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16181 symmisc.c: Update all dictionary references to multidictionary.
16182
c7748ee9
KS		 161832019-01-10 Keith Seitz <keiths@redhat.com>
16184
16185 PR gdb/23712
16186 PR symtab/23010
16187 * dictionary.c: Include unordered_map.
16188 (pending_to_vector): New function.
16189 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16190 Rewrite the non-"_1" functions to take vector instead
16191 of linked list.
16192 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16193 "new" _1 versions of the same name.
16194 (multidictionary): Define.
16195 (std::hash<enum language): New definition.
16196 (collate_pending_symbols_by_language, mdict_create_hashed)
16197 (mdict_create_hashed_expandable, mdict_create_linear)
16198 (mdict_create_linear_expandable, mdict_free)
16199 (find_language_dictionary, create_new_language_dictionary)
16200 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16201 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16202 (mdict_size, mdict_empty): New functions.
16203 * dictionary.h (mdict_iterator): Define.
16204
67aa1f3c
PA		 162052019-01-10 Pedro Alves <palves@redhat.com>
16206
16207 * breakpoint.c (read_uploaded_action)
16208 (create_tracepoint_from_upload): Adjust to use
16209 gdb::unique_xmalloc_ptr.
16210 * ctf.c (ctf_write_uploaded_tp):
16211 (SET_ARRAY_FIELD): Use emplace_back.
16212 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16213 * tracefile-tfile.c (tfile_write_uploaded_tp):
16214 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16215 gdb::unique_xmalloc_ptr.
16216 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16217 at_string, cond_string, cmd_strings>: Replace char pointers
16218 with gdb::unique_xmalloc_ptr.
16219
2f667667
PA		 162202019-01-10 Pedro Alves <palves@redhat.com>
16221
16222 * solib-target.c (library_list_start_library): Don't xstrdup name.
16223
36cb7237
PA		 162242019-01-10 Pedro Alves <palves@redhat.com>
16225
16226 * mdebugread.c (parse_partial_symbols): Use
16227 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16228
da584958
AB		 162292019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16230
16231 * linux-fork.c (scoped_switch_fork_info)
16232 <~scoped_switch_fork_info>: Fix incorrect variable name.
16233
1ef8573c
AB		 162342019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16235
16236 * linux-fork.c (scoped_switch_fork_info)
16237 <scoped_switch_fork_info>: Make explicit.
16238 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16239
8d7bcccb
TT		 162402019-01-10 Tom Tromey <tom@tromey.com>
16241
16242 * objfiles.h (objfile::reset_psymtabs): Update.
16243 * objfiles.c (objfile::objfile): Update.
16244 * psymtab.h (psymtab_storage::obstack): Update.
16245 (psymtab_storage::m_obstack): Use gdb::optional.
16246 (class psymtab_storage): Update comment. Remove objfile
16247 parameter.
16248 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16249
b596a3c7
TT		 162502019-01-10 Tom Tromey <tom@tromey.com>
16251
16252 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16253 <free_psymtabs>: Now private.
16254 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16255 (allocate_psymtab): Use new method.
16256
a9342b62
TT		 162572019-01-10 Tom Tromey <tom@tromey.com>
16258
16259 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16260 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16261 * mdebugread.c (parse_partial_symbols): Use
16262 allocate_dependencies.
16263 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16264 allocate_dependencies.
16265 (process_psymtab_comp_unit_reader)
16266 (build_type_psymtab_dependencies): Likewise.
16267 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16268
5af70966
TT		 162692019-01-10 Tom Tromey <tom@tromey.com>
16270
16271 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16272 PSYMBOL_SET_LANGUAGE.
16273 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16274
5923a04c
TT		 162752019-01-10 Tom Tromey <tom@tromey.com>
16276
16277 * psymtab.h (psymtab_storage::obstack): New method.
16278 <m_obstack>: Rename from obstack; now private.
16279 * psymtab.c (psymtab_storage): Update.
16280 * dwarf2read.c (create_addrmap_from_index)
16281 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16282 Update.
16283
6d6a12bf
TT		 162842019-01-10 Tom Tromey <tom@tromey.com>
16285
16286 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16287 * objfiles.h (objfile::reset_psymtabs): New method.
16288
d320c2b5
TT		 162892019-01-10 Tom Tromey <tom@tromey.com>
16290
16291 * symmisc.c (print_symbol_bcache_statistics): Update.
16292 (print_objfile_statistics): Update.
16293 * symfile.c (reread_symbols): Update.
16294 * psymtab.h (class psymtab_storage): New.
16295 * psymtab.c (psymtab_storage): New constructor.
16296 (~psymtab_storage): New destructor.
16297 (require_partial_symbols): Update.
16298 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16299 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16300 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16301 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16302 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16303 (start_psymtab_common, end_psymtab_common)
16304 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16305 (allocate_psymtab): Update.
16306 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16307 Update.
16308 (dump_psymtab_addrmap, maintenance_print_psymbols)
16309 (maintenance_check_psymtabs): Update.
16310 (class objfile_psymtabs): Move to objfiles.h.
16311 * psympriv.h (discard_psymtab): Now inline.
16312 (psymtab_discarder::psymtab_discarder): Update.
16313 (psymtab_discarder::~psymtab_discarder): Update.
16314 (ALL_OBJFILE_PSYMTABS): Rewrite.
16315 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16316 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16317 Remove fields.
16318 <partial_symtabs>: New field.
16319 (class objfile_psymtabs): Move from psymtab.h. Update.
16320 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16321 psymbol_cache.
16322 (objfile::~objfile): Don't destroy psymbol_cache.
16323 * mdebugread.c (parse_partial_symbols): Update.
16324 * dwarf2read.c (create_addrmap_from_index)
16325 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16326 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16327 (add_partial_subprogram, dwarf2_ranges_read): Update.
16328 * dwarf-index-write.c (write_address_map)
16329 (write_one_signatured_type, recursively_write_psymbols)
16330 (class debug_names, class debug_names, write_psymtabs_to_index):
16331 Update.
16332
1d94a5a3
TT		 163332019-01-10 Tom Tromey <tom@tromey.com>
16334
16335 * symtab.h (SYMBOL_SET_NAMES): Update.
16336 (symbol_set_names): Update.
16337 (MSYMBOL_SET_NAMES): Update.
16338 * symtab.c (symbol_set_names): Change argument to be an
16339 objfile_per_bfd_storage.
16340 * psymtab.c (add_psymbol_to_bcache): Update.
16341 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16342
0f14768a
TT		 163432019-01-10 Tom Tromey <tom@tromey.com>
16344
16345 * symtab.c (create_demangled_names_hash): Change argument to be an
16346 objfile_per_bfd_storage.
16347 (symbol_set_names): Update.
16348
6eee24ce
TT		 163492019-01-10 Tom Tromey <tom@tromey.com>
16350
16351 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16352 init_psymbol_list.
16353 * psymtab.c (init_psymbol_list): Do nothing if already called.
16354 * psympriv.h (init_psymbol_list): Add comment.
16355 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16356 init_psymbol_list.
16357 * dbxread.c (dbx_symfile_read): Unconditionally call
16358 init_psymbol_list.
16359
75aedd27
TT		 163602019-01-10 Tom Tromey <tom@tromey.com>
16361
16362 * xcoffread.c (scan_xcoff_symtab): Update.
16363 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16364 "where".
16365 * mdebugread.c (parse_partial_symbols)
16366 (handle_psymbol_enumerators): Update.
16367 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16368 * dbxread.c (read_dbx_symtab): Update.
16369 * psympriv.h (psymbol_placement): New enum.
16370 (add_psymbol_to_list): Update.
16371
939652a5
TT		 163722019-01-10 Tom Tromey <tom@tromey.com>
16373
16374 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16375 static_psymbols parameters.
16376 (scan_xcoff_symtab): Update.
16377 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16378 static_psymbols parameters.
16379 * psympriv.h (start_psymtab_common): Update.
16380 * mdebugread.c (parse_partial_symbols): Update.
16381 * dwarf2read.c (create_partial_symtab): Update.
16382 * dbxread.c (read_dbx_symtab): Update.
16383 (start_psymtab): Remove global_psymbols and static_psymbols
16384 parameters.
16385
baa62830
TT		 163862019-01-10 Tom Tromey <tom@tromey.com>
16387
16388 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16389 * psymtab.c (allocate_psymtab): Add comment.
16390 * psympriv.h (allocate_psymtab): Add comment.
16391 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16392 initializations.
16393 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16394
0e8f53ba
TT		 163952019-01-10 Tom Tromey <tom@tromey.com>
16396
16397 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16398 Don't declare.
16399 * mipsread.c: Include mdebugread.h.
16400 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16401 Declare.
16402 * elfread.c: Include mdebugread.h.
16403
b22a7c6a
TT		 164042019-01-09 Tom Tromey <tom@tromey.com>
16405
16406 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16407 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16408 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16409 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16410 (psym_lookup_symbol, psym_find_last_source_symtab)
16411 (psym_forget_cached_source_info, psym_print_stats)
16412 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16413 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16414 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16415 (psym_find_compunit_symtab_by_address)
16416 (maintenance_print_psymbols, maintenance_info_psymtabs)
16417 (maintenance_check_psymtabs): Use ranged for.
16418 * psymtab.h (class objfile_psymtabs): New.
16419 (require_partial_symbols): Return objfile_psymtabs.
16420 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16421
3b9d3ac2
TT		 164222019-01-09 Tom Tromey <tom@tromey.com>
16423
16424 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16425 (find_pc_mapped_section, list_overlays_command)
16426 (map_overlay_command, unmap_overlay_command)
16427 (simple_overlay_update): Use all_objfiles.
16428 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16429 * printcmd.c (info_symbol_command): Use all_objfiles.
16430 * objfiles.h (ALL_OBJSECTIONS): Remove.
16431 * maint.c (maintenance_translate_address): Use all_objfiles.
16432 * gcore.c (gcore_create_callback): Use all_objfiles.
16433 (objfile_find_memory_regions): Likewise.
16434
8b31193a
TT		 164352019-01-09 Tom Tromey <tom@tromey.com>
16436
16437 * symtab.c (find_line_symtab, info_sources_command)
16438 (make_source_files_completion_list): Use objfile_compunits.
16439 * source.c (select_source_symtab): Use objfile_compunits.
16440 * objfiles.h (struct objfile): Update comment.
16441 (ALL_OBJFILES): Remove.
16442 (ALL_FILETABS): Remove.
16443 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16444 objfile_compunits.
16445
d5da8b3c
TT		 164462019-01-09 Tom Tromey <tom@tromey.com>
16447
16448 * symmisc.c (print_objfile_statistics, dump_objfile)
16449 (maintenance_print_symbols): Use compunit_filetabs.
16450 * source.c (forget_cached_source_info_for_objfile): Use
16451 compunit_filetabs.
16452 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16453 (ALL_FILETABS): Use compunit_filetabs.
16454 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16455 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16456
5accd1a0
TT		 164572019-01-09 Tom Tromey <tom@tromey.com>
16458
16459 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16460 (compunit_filetabs): New.
16461 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16462 compunit_filetabs.
16463 (info_sources_command, make_source_files_completion_list): Remove
16464 declaration.
16465 * symmisc.c (print_objfile_statistics, dump_objfile)
16466 (maintenance_print_symbols): Remove declaration.
16467 (maintenance_info_symtabs): Use compunit_filetabs.
16468 (maintenance_info_line_tables): Likewise.
16469 * source.c (select_source_symtab): Change local variable name.
16470 (forget_cached_source_info_for_objfile): Remove declaration.
16471 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16472 * objfiles.c (objfile_relocate1): Remove declaration.
16473 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16474 declaration.
16475 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16476 * coffread.c (coff_symtab_read): Remove declaration.
16477 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16478 compunit_filetabs.
16479
d8aeb77f
TT		 164802019-01-09 Tom Tromey <tom@tromey.com>
16481
16482 * symtab.c (lookup_objfile_from_block)
16483 (find_pc_sect_compunit_symtab, search_symbols)
16484 (default_collect_symbol_completion_matches_break_on): Use
16485 objfile_compunits.
16486 * objfiles.h (ALL_COMPUNITS): Remove.
16487 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16488 * cp-support.c (add_symbol_overload_list_qualified): Use
16489 objfile_compunits.
16490 * ada-lang.c (ada_collect_symbol_completion_matches)
16491 (ada_add_global_exceptions): Use objfile_compunits.
16492
592553c4
TT		 164932019-01-09 Tom Tromey <tom@tromey.com>
16494
16495 * source.c (select_source_symtab)
16496 (forget_cached_source_info_for_objfile): Remove declaration.
16497 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16498 declaration.
16499 * maint.c (count_symtabs_and_blocks): Remove declaration.
16500 * cp-support.c (add_symbol_overload_list_qualified): Remove
16501 declaration.
16502 * coffread.c (coff_symtab_read): Remove declaration.
16503 * symtab.c (lookup_symbol_in_objfile_symtabs)
16504 (basic_lookup_transparent_type_1): Use objfile_compunits.
16505 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16506 (info_sources_command, search_symbols)
16507 (default_collect_symbol_completion_matches_break_on)
16508 (make_source_files_completion_list): Remove declaration.
16509 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16510 (ada_collect_symbol_completion_matches)
16511 (ada_add_global_exceptions): Remove declaration.
16512 * linespec.c (iterate_over_all_matching_symtabs): Use
16513 objfile_compunits.
16514 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16515 (class objfile_compunits): New.
16516 (ALL_COMPUNITS): Use objfile_compunits.
16517 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16518 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16519 objfile_compunits.
16520 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16521
5325b9bf
TT		 165222019-01-09 Tom Tromey <tom@tromey.com>
16523
16524 * symtab.c (search_symbols)
16525 (default_collect_symbol_completion_matches_break_on): Use
16526 objfile_msymbols.
16527 * ada-lang.c (ada_lookup_simple_minsym)
16528 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16529 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16530 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16531 objfile_msymbols.
16532 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16533 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16534 * objc-lang.c (find_methods): Use objfile_msymbols.
16535 (info_selectors_command, info_classes_command): Likewise.
16536 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16537 * objfiles.h (class objfile_msymbols): New.
16538 (ALL_OBJFILE_MSYMBOLS): Remove.
16539 (ALL_MSYMBOLS): Remove.
16540
cac85af2
TT		 165412019-01-09 Tom Tromey <tom@tromey.com>
16542
16543 * common/next-iterator.h (next_adapter): Add Iterator template
16544 parameter.
16545 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16546 (class all_objfiles_safe): New.
16547 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16548 * objfiles.c (put_objfile_before): Update comment.
16549 (add_separate_debug_objfile): Likewise.
16550 (free_all_objfiles): Use all_objfiles_safe.
16551 (objfile_purge_solibs): Likewise.
16552
aed57c53
TT		 165532019-01-09 Tom Tromey <tom@tromey.com>
16554
16555 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16556 (expand_symtab_containing_pc, lookup_static_symbol)
16557 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16558 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16559 all_objfiles.
16560 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16561 * breakpoint.c (create_overlay_event_breakpoint)
16562 (create_longjmp_master_breakpoint)
16563 (create_std_terminate_master_breakpoint)
16564 (create_exception_master_breakpoint): Use all_objfiles.
16565 * linux-thread-db.c (try_thread_db_load_from_pdir)
16566 (has_libpthread): Use all_objfiles.
16567 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16568 * linespec.c (iterate_over_all_matching_symtabs)
16569 (search_minsyms_for_name): Use all_objfiles.
16570 * maint.c (maintenance_info_sections): Use all_objfiles.
16571 * main.c (captured_main_1): Use all_objfiles.
16572 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16573 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16574 * guile/scm-pretty-print.c
16575 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16576 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16577 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16578 (maintenance_print_msymbols): Use all_objfiles.
16579 * source.c (select_source_symtab): Use all_objfiles.
16580 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16581 * symfile.c (remove_symbol_file_command)
16582 (expand_symtabs_matching, map_symbol_filenames): Use
16583 all_objfiles.
16584 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16585 all_objfiles.
16586 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16587 * objc-lang.c (find_methods): Use all_objfiles.
16588 * objfiles.c (have_partial_symbols, have_full_symbols)
16589 (have_minimal_symbols, qsort_cmp)
16590 (default_iterate_over_objfiles_in_search_order): Use
16591 all_objfiles.
16592 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16593 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16594 (maintenance_check_psymtabs): Use all_objfiles.
16595 (ALL_PSYMTABS): Remove.
16596 * compile/compile-object-run.c (do_module_cleanup): Use
16597 all_objfiles.
16598 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16599 * cp-support.c (add_symbol_overload_list_qualified): Use
16600 all_objfiles.
16601 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16602 Use all_objfiles.
16603 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16604 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16605 all_objfiles.
16606 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16607 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16608 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16609 Uses all_objfiles.
16610 * solib.c (solib_read_symbols): Use all_objfiles
16611
99d89cde
TT		 166122019-01-09 Tom Tromey <tom@tromey.com>
16613
16614 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16615 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16616 all_objfiles.
16617 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16618 * symmisc.c (print_symbol_bcache_statistics)
16619 (print_objfile_statistics, maintenance_print_objfiles)
16620 (maintenance_info_symtabs, maintenance_check_symtabs)
16621 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16622 all_objfiles.
16623 * source.c (forget_cached_source_info): Use all_objfiles.
16624 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16625 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16626 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16627 * objfiles.c (update_section_map): Use all_objfiles.
16628 (shared_objfile_contains_address_p): Likewise.
16629 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16630 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16631
21708325
TT		 166322019-01-09 Tom Tromey <tom@tromey.com>
16633
16634 * common/next-iterator.h: New file.
16635 * objfiles.h (class all_objfiles): New.
16636 (struct objfile_iterator): New.
16637
669e09f6
PW		 166382019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16639
16640 * NEWS: Move the description of the changed "frame", "select-frame",
16641 and "info frame" commands to the Changed commands section.
16642
041be526
SM		 166432019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16644
16645 * gdbtypes.c (check_stub_method_group): Remove handling of old
16646 mangling schemes.
16647 * linespec.c (find_methods): Likewise.
16648 * stabsread.c (read_member_functions): Likewise.
16649 * valops.c (search_struct_method): Likewise.
16650 (value_struct_elt_for_reference): Likewise.
16651 * NEWS: Mention this change.
16652
0e2a2133
AB		 166532019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16654
16655 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16656 print_source_lines.
16657 * source.c (print_source_lines_base): Update line number check.
16658 (print_source_lines): New function.
16659 (source_lines_range::source_lines_range): New function.
16660 * source.h (class source_lines_range): New class.
16661 (print_source_lines): New declaration.
16662
1055a3b4
PW		 166632019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16664
16665 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16666
cfeadda5
TT		 166672019-01-08 Tom Tromey <tom@tromey.com>
16668 Simon Marchi <simon.marchi@ericsson.com>
16669
16670 PR gdb/24060
16671 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16672 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16673 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16674 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16675 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16676 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16677
583068ca
AB		 166782019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16679
16680 * source.c (select_source_symtab): Move header comment to
16681 declaration in source.h.
16682 (forget_cached_source_info_for_objfile): Likewise.
16683 (forget_cached_source_info): Likewise.
16684 (identify_source_line): Likewise.
16685 * source.h (identify_source_line): Move declaration from symtab.h
16686 and add comment from source.c
16687 (print_source_lines): Likewise.
16688 (forget_cached_source_info_for_objfile): Likewise.
16689 (forget_cached_source_info): Likewise.
16690 (select_source_symtab): Likewise.
16691 (enum print_source_lines_flag): Move definition from symtab.h.
16692 * symtab.h (identify_source_line): Move declaration to source.h.
16693 (print_source_lines): Likewise.
16694 (forget_cached_source_info_for_objfile): Likewise.
16695 (forget_cached_source_info): Likewise.
16696 (select_source_symtab): Likewise.
16697 (enum print_source_lines_flag): Move definition to source.h.
16698 * tui/tui-hooks.c: Add 'source.h' include.
16699
ec98a4ad
AB		 167002019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16701
16702 * source.c (print_source_lines_base): Handle requests to print
16703 reverse line number sequences, and guard against empty lines
16704 string.
16705
62ea19c1
AB		 167062019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16707
16708 * source.c (print_source_lines_base): Fix skip of '\r' if next
16709 character is '\n'.
16710
9d30e1fd
TT		 167112019-01-06 Tom Tromey <tom@tromey.com>
16712
16713 * c-exp.y (struct c_parse_state) <macro_original_text,
16714 expansion_obstack>: New member.
16715 (macro_original_text, expansion_obstack): Remove globals.
16716 (scan_macro_expansion, scanning_macro_expansion)
16717 (finished_macro_expansion): Update.
16718 (scan_macro_cleanup): Remove.
16719 (yylex, c_parse): Update.
16720
c65bac38
TT		 167212019-01-06 Tom Tromey <tom@tromey.com>
16722
16723 * c-exp.y (struct c_parse_state) <strings>: New member.
16724 (operator_stoken): Update.
16725
02e12e38
TT		 167262019-01-06 Tom Tromey <tom@tromey.com>
16727
16728 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16729 (union type_stack_elt) <typelist_val>: Now a pointer to
16730 std::vector.
16731 (type_stack_cleanup): Don't declare.
16732 (push_typelist): Update.
16733 * parse.c (pop_typelist): Return a std::vector.
16734 (push_typelist): Take a std::vector.
16735 (follow_types): Update. Do not free args.
16736 (type_stack_cleanup): Remove.
16737 * c-exp.y (struct c_parse_state): New.
16738 (cpstate): New global.
16739 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16740 (nonempty_typelist): Update.
16741 (func_mod): Create a new vector.
16742 (c_parse): Create a c_parse_state.
16743 (check_parameter_typelist): Do not delete params.
16744 (function_method): Update. Do not delete type_list.
16745
f097f5ad
TT		 167462019-01-06 Tom Tromey <tom@tromey.com>
16747
16748 PR gdb/28155:
16749 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16750 check_typedef.
16751 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16752 (print_return_value): Likewise.
16753
d2adf9f1
TT		 167542019-01-05 Tom Tromey <tom@tromey.com>
16755
16756 * contrib/cleanup_check.py: Remove.
16757 * contrib/gcc-with-excheck: Remove.
16758 * contrib/exsummary.py: Remove.
16759 * contrib/excheck.py: Remove.
16760
2eab46b1
JB		 167612019-01-05 Joel Brobecker <brobecker@adacore.com>
16762
16763 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16764 NULL. Initialize tpprev to NULL instead of assigning it
16765 to NULL on the next statement.
16766 * windows-nat.c (windows_delete_thread): Remove check for
16767 main_thread_id before printing thread exit notifications.
16768 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16769 Remove thread ID check against main_thread_id.
16770 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16771 windows_delete_thread.
16772 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16773
48c5e7e2
TT		 167742019-01-04 Tom Tromey <tom@tromey.com>
16775
16776 * compile/compile.c (_initialize_compile): Use upper case for
16777 metasyntactic variables.
16778 * symmisc.c (_initialize_symmisc): Use upper case for
16779 metasyntactic variables.
16780 * psymtab.c (_initialize_psymtab): Use upper case for
16781 metasyntactic variables.
16782 * demangle.c (demangle_command): Use upper case for metasyntactic
16783 variables.
16784 (_initialize_demangler): Likewise.
16785 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16786 variables.
16787
986041cd
TT		 167882019-01-03 Tom Tromey <tom@tromey.com>
16789
16790 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16791
7c711119
TT		 167922019-01-03 Tom Tromey <tom@tromey.com>
16793
16794 * python/py-symtab.c (salpy_str): Update.
16795 (struct salpy_sal_object) <symtab>: Now a PyObject.
16796 (salpy_dealloc): Update.
16797 (del_objfile_sal): Use gdbpy_ref.
16798
1b20edf0
TT		 167992019-01-03 Tom Tromey <tom@tromey.com>
16800
16801 * python/py-type.c (convert_field): Use new_reference. Return
16802 gdbpy_ref.
16803 (make_fielditem): Return gdbpy_ref.
16804 (typy_fields): Update.
16805 (typy_getitem): Update.
16806 (field_name): Return gdbpy_ref. Use new_reference.
16807 (typy_iterator_iternext): Update.
16808
ea41325b
TT		 168092019-01-03 Tom Tromey <tom@tromey.com>
16810
16811 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16812
2a3c71d6
TT		 168132019-01-03 Tom Tromey <tom@tromey.com>
16814
16815 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16816 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16817 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16818 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16819 (pspy_set_type_printers): Likewise.
16820 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16821 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16822 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16823 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16824 (objfpy_set_type_printers): Likewise.
16825
5c329e6a
TT		 168262019-01-03 Tom Tromey <tom@tromey.com>
16827
16828 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16829 (gdbpy_print_stack): Use gdbpy_err_fetch.
16830 * python/python-internal.h (class gdbpy_err_fetch): New class.
16831 (class gdbpy_enter) <m_error_type, m_error_value,
16832 m_error_traceback>: Remove.
16833 <m_error>: New member.
16834 (gdbpy_exception_to_string): Don't declare.
16835 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16836 * python/py-value.c (convert_value_from_python): Use
16837 gdbpy_err_fetch.
16838 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16839 gdbpy_exception_to_string.
16840 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16841 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16842 gdbpy_err_fetch.
16843
169bb27b
AB		 168442019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16845
16846 * linux-nat.c (delete_lwp_cleanup): Delete.
16847 (struct lwp_deleter): New struct.
16848 (lwp_info_up): New typedef.
16849 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16850 lwp_info_up.
16851
a07c8880
AB		 168522019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16853
16854 * linux-fork.c (class scoped_switch_fork_info): New class.
16855 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16856
26089c49
AB		 168572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16858
16859 * valops.c (find_overload_match): Remove use of null_cleanup, and
16860 calls to do_cleanups.
16861
06d3e5b0
AB		 168622019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16863
16864 * compile/compile-cplus-types.c
16865 (compile_cplus_instance::decl_name): Handle changes to
16866 cp_func_name.
16867 * cp-support.c (cp_func_name): Update header comment, update
16868 return type.
16869 * cp-support.h (cp_func_name): Update return type in declaration.
16870 * valops.c (find_overload_match): Move temp_func local to top
16871 level of function and change its type. Use temp_func to hold and
16872 delete temporary string obtained from cp_func_name.
16873
66644cd3
AB		 168742019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16875
16876 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16877 gdb::char_vector, remove cleanup, and update uses of `msg`.
16878
592d8c0a
JW		 168792019-01-03 Jim Wilson <jimw@sifive.com>
16880
16881 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16882
c55d06ec
TT		 168832019-01-02 Tom Tromey <tom@tromey.com>
16884
16885 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16886 (tdesc_parse_xml): Remove cleanups.
16887 * target-descriptions.h (make_cleanup_free_target_description):
16888 Don't declare.
16889 (target_desc_deleter): New struct.
16890 (target_desc_up): New typedef.
16891 * target-descriptions.c (target_desc_deleter::operator()): Rename
16892 from free_target_description.
16893 (make_cleanup_free_target_description): Remove.
16894
3a6ae42d
TT		 168952019-01-02 Tom Tromey <tom@tromey.com>
16896
16897 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16898 constructor, destructor.
16899 (linespec_parser): Remove typedef.
16900 (~linespec_parser): Rename from linespec_parser_delete.
16901 (linespec_lex_to_end, linespec_complete_label)
16902 (linespec_complete): Update.
16903 (decode_line_full): Remove cleanups.
16904 (decode_line_1): Update.
16905
61fd3e73
TT		 169062019-01-02 Tom Tromey <tom@tromey.com>
16907
16908 * python/python-internal.h (inferior_to_inferior_object): Change
16909 return type.
16910 * python/py-exitedevent.c (create_exited_event_object): Update.
16911 * python/py-inferior.c (inferior_to_inferior_object): Return
16912 gdbpy_ref.
16913 (python_new_inferior, python_inferior_deleted)
16914 (thread_to_thread_object, delete_thread_object)
16915 (build_inferior_list, gdbpy_selected_inferior): Update.
16916 * python/py-infthread.c (create_thread_object): Update. Also fail
16917 if inferior_to_inferior_object fails.
16918
d20172fc
SM		 169192019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16920
16921 * inferior.h (class inferior) <displaced_step_state>: New field.
16922 * infrun.h (struct displaced_step_state): Move here from
16923 infrun.c. Initialize fields, add constructor.
16924 <inf>: Remove field.
16925 <reset>: New method.
16926 * infrun.c (struct displaced_step_inferior_state): Move to
16927 infrun.h.
16928 (displaced_step_inferior_states): Remove.
16929 (get_displaced_stepping_state): Adust.
16930 (displaced_step_in_progress_any_inferior): Adjust.
16931 (displaced_step_in_progress_thread): Adjust.
16932 (displaced_step_in_progress): Adjust.
16933 (add_displaced_stepping_state): Remove.
16934 (get_displaced_step_closure_by_addr): Adjust.
16935 (remove_displaced_stepping_state): Remove.
16936 (infrun_inferior_exit): Call displaced_step_state.reset.
16937 (use_displaced_stepping): Don't check for NULL.
16938 (displaced_step_prepare_throw): Call
16939 get_displaced_stepping_state.
16940 (displaced_step_fixup): Don't check for NULL.
16941 (prepare_for_detach): Don't check for NULL.
16942
e3319240
PW		 169432019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16944
16945 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16946 in case of call that did not complete.
16947
5d36dfb9
AU		 169482019-01-02 Andrey Utkin <autkin@undo.io>
16949
16950 * symfile.c (find_separate_debug_file): Fix search of debug files for
16951 remote debuggee.
16952
8833fbf0
TT		 169532019-01-02 Tom Tromey <tom@tromey.com>
16954
16955 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16956 indentation.
16957 * python/py-frame.c (frapy_older): Remove cast.
16958 (frapy_newer): Likewise.
16959 * python/py-breakpoint.c (local_setattro): Remove cast.
16960 * python/py-arch.c (archpy_name): Remove local variable.
16961 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16962
4ada3dfd
JB		 169632019-01-02 Joel Brobecker <brobecker@adacore.com>
16964
16965 * unittests/basic_string_view/element_access/char/empty.cc:
16966 Fix year range in copyright header.
16967
113b7b81
AB		 169682019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16969
16970 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16971 Delete.
16972 <operator==>: Update with for removed field.
16973 <hash>: Likewise.
16974 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16975 <isa_features>: ...this.
16976 <abi_features>: New field.
16977 (riscv_isa_flen): Update comment.
16978 (riscv_abi_xlen): New declaration.
16979 (riscv_abi_flen): New declaration.
16980 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16981 isa_features.
16982 (riscv_abi_xlen): New function.
16983 (riscv_isa_flen): Update to get answer from isa_features.
16984 (riscv_abi_flen): New function.
16985 (riscv_has_fp_abi): Update to get answer from abi_features.
16986 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16987 xlen and flen.
16988 (riscv_call_info) <xlen, flen>: Update comment.
16989 (riscv_call_arg_struct): Remove invalid assertions
16990 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16991 is removed.
16992 (riscv_gdbarch_init): Gather isa features and abi features
16993 separately, ensure both match on the gdbarch when reusing an old
16994 gdbarch. Relax an error check to allow 32-bit abi float to run on
16995 a target with 64-bit float hardware.
16996
b18ca514
PW		 169972019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16998
16999 * source.c (search_command_helper): Stop reverse search
17000 when line 1 has been searched.
17001
ec70d8db
PW		 170022019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17003
17004 * record-full.c (record_full_base_target::close): Rewrite
17005 record_full_core_buf_list free logic.
17006
5b38f9c1
PW		 170072019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17008
17009 * break-catch-syscall.c (print_one_catch_syscall): xfree
17010 the last text.
17011
66d91b39
JB		 170122019-01-01 Joel Brobecker <brobecker@adacore.com>
17013
17014 * top.c (print_gdb_version): Update Copyright year in version
17015 message.
17016
42a4f53d
JB		 170172019-01-01 Joel Brobecker <brobecker@adacore.com>
17018
17019 Update copyright year range in all GDB files.
17020
7e955d83 170212019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17022
5bbd631d 17023 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17024
5bbd631d 17025For older changes see ChangeLog-2018.
c906108c
SS		 17026\f
17027Local Variables:
17028mode: change-log
17029left-margin: 8
17030fill-column: 74
17031version-control: never
57da7796 17032coding: utf-8
c906108c 17033End:
5bbd631d 17034
GDB Binutils - Deliverables
This page took 3.067355 seconds and 4 git commands to generate.