libctf: create: ctf_add_type should hand back already-added non-SoUs
[deliverable/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
d04a47ac
NA
12020-06-26 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-create.c (ctf_add_type_internal): Hand back existing types
4 unchanged.
5
6bbf9da8
NA
62020-06-26 Nick Alcock <nick.alcock@oracle.com>
7
8 * ctf-create.c (ctf_add_forward): Don't add forwards to
9 types that already exist.
10
fe4c2d55
NA
112020-06-26 Nick Alcock <nick.alcock@oracle.com>
12
13 * ctf-open.c (init_types): Only intern root-visible types.
14 * ctf-create.c (ctf_dtd_insert): Likewise.
15 (ctf_dtd_delete): Only remove root-visible types.
16 (ctf_rollback): Likewise.
17 (ctf_add_generic): Adjust.
18 (ctf_add_struct_sized): Adjust comment.
19 (ctf_add_union_sized): Likewise.
20 (ctf_add_enum): Likewise.
21 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
22
11978942
JB
232020-03-11 John Baldwin <jhb@FreeBSD.org>
24
25 * swap.h (bswap_identity_64): Make static.
26
ae774686
NC
272020-01-18 Nick Clifton <nickc@redhat.com>
28
29 Binutils 2.34 branch created.
30
eb9a7e35 312020-01-05 Joel Brobecker <brobecker@adacore.com>
3a657c60
EZ
32
33 PR binutils/25155:
34 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
35 * configure, config.h.in: Regenerate.
36
b14ce8bf
AM
372020-01-01 Alan Modra <amodra@gmail.com>
38
39 Update year range in copyright notice of all files.
40
cbbbc402
SM
412019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
42
43 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
44
fa56cdcd
NA
452019-09-30 Nick Alcock <nick.alcock@oracle.com>
46
47 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
48 * ctf-types.c (ctf_type_lname): Likewise.
49
ad613f1d
NA
502019-09-23 Nick Alcock <nick.alcock@oracle.com>
51
52 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
53 ctf_import after the first for a given file.
54
9323dd86
NA
552019-09-23 Nick Alcock <nick.alcock@oracle.com>
56
57 * ctf-impl.h (ctf_str_append_noerr): Declare.
58 * ctf-util.c (ctf_str_append_noerr): Define in terms of
59 ctf_str_append.
60 * ctf-dump.c (str_append): New, call it.
61 (ctf_dump_format_type): Use str_append, not ctf_str_append.
62 (ctf_dump_label): Likewise.
63 (ctf_dump_objts): Likewise.
64 (ctf_dump_funcs): Likewise.
65 (ctf_dump_var): Likewise.
66 (ctf_dump_member): Likewise.
67 (ctf_dump_type): Likewise.
68 (ctf_dump): Likewise.
69
de07e349
NA
702019-09-23 Nick Alcock <nick.alcock@oracle.com>
71
72 * ctf-impl.h (ctf_alloc): Remove.
73 (ctf_free): Likewise.
74 (ctf_strdup): Likewise.
75 * ctf-subr.c (ctf_alloc): Remove.
76 (ctf_free): Likewise.
77 * ctf-util.c (ctf_strdup): Remove.
78
79 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
80 ctf_free; strdup, not ctf_strdup.
81 (ctf_dtd_delete): Likewise.
82 (ctf_dvd_delete): Likewise.
83 (ctf_add_generic): Likewise.
84 (ctf_add_function): Likewise.
85 (ctf_add_enumerator): Likewise.
86 (ctf_add_member_offset): Likewise.
87 (ctf_add_variable): Likewise.
88 (membadd): Likewise.
89 (ctf_compress_write): Likewise.
90 (ctf_write_mem): Likewise.
91 * ctf-decl.c (ctf_decl_push): Likewise.
92 (ctf_decl_fini): Likewise.
93 (ctf_decl_sprintf): Likewise. Check for OOM.
94 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
95 ctf_free; strdup, not ctf_strdup.
96 (ctf_dump_free): Likewise.
97 (ctf_dump): Likewise.
98 * ctf-open.c (upgrade_types_v1): Likewise.
99 (init_types): Likewise.
100 (ctf_file_close): Likewise.
101 (ctf_bufopen_internal): Likewise. Check for OOM.
102 (ctf_parent_name_set): Likewise: report the OOM to the caller.
103 (ctf_cuname_set): Likewise.
104 (ctf_import): Likewise.
105 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
106 free, not ctf_free; strdup, not ctf_strdup.
107 (ctf_str_free_atom): Likewise.
108 (ctf_str_create_atoms): Likewise.
109 (ctf_str_add_ref_internal): Likewise.
110 (ctf_str_remove_ref): Likewise.
111 (ctf_str_write_strtab): Likewise.
112
9c1a2295
NA
1132019-08-09 Nick Alcock <nick.alcock@oracle.com>
114
115 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
116 work right for non-int/fps.
117
1a6ab13e
NA
1182019-08-08 Nick Alcock <nick.alcock@oracle.com>
119
120 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
121 null pointer.
122
99dc3ebd
NA
1232019-08-07 Nick Alcock <nick.alcock@oracle.com>
124
125 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
126 * ctf-open.c (ctf_file_close): Free it.
127 * ctf-create.c (ctf_serialize): Adjust.
128 (membcmp): When reporting a conflict due to an error, report the
129 error.
130 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
131 (ctf_add_type_internal): ... this. Hand back types we are already
132 in the middle of adding immediately. Hand back structs/unions with
133 the same number of members immediately. Do not walk the dynamic
134 list. Call ctf_add_type_internal, not ctf_add_type. Handle
135 forwards promoted to other types and the inverse case identically.
136 Add structs to the mapping as soon as we intern them, before they
137 gain any members.
138
676c3ecb
NA
1392019-08-09 Nick Alcock <nick.alcock@oracle.com>
140
141 * ctf-impl.h (ctf_names_t): New.
142 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
143 (ctf_file_t) <ctf_structs>: Likewise.
144 <ctf_unions>: Likewise.
145 <ctf_enums>: Likewise.
146 <ctf_names>: Likewise.
147 <ctf_lookups>: Improve comment.
148 <ctf_ptrtab_len>: New.
149 <ctf_prov_strtab>: New.
150 <ctf_str_prov_offset>: New.
151 <ctf_dtbyname>: Remove, redundant to the names hashes.
152 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
153 (ctf_dtdef_t) <dtd_name>: Remove.
154 <dtd_data>: Note that the ctt_name is now populated.
155 (ctf_str_atom_t) <csa_offset>: This is now the strtab
156 offset for internal strings too.
157 <csa_external_offset>: New, the external strtab offset.
158 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
159 (ctf_name_table): New declaration.
160 (ctf_lookup_by_rawname): Likewise.
161 (ctf_lookup_by_rawhash): Likewise.
162 (ctf_set_ctl_hashes): Likewise.
163 (ctf_serialize): Likewise.
164 (ctf_dtd_insert): Adjust.
165 (ctf_simple_open_internal): Likewise.
166 (ctf_bufopen_internal): Likewise.
167 (ctf_list_empty_p): Likewise.
168 (ctf_str_remove_ref): Likewise.
169 (ctf_str_add): Returns uint32_t now.
170 (ctf_str_add_ref): Likewise.
171 (ctf_str_add_external): Now returns a boolean (int).
172 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
173 for strings in the appropriate range.
174 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
175 when adding the null string to the new strtab.
176 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
177 (ctf_str_add_ref_internal): Add make_provisional argument. If
178 make_provisional, populate the offset and fill in the
179 ctf_prov_strtab accordingly.
180 (ctf_str_add): Return the offset, not the string.
181 (ctf_str_add_ref): Likewise.
182 (ctf_str_add_external): Return a success integer.
183 (ctf_str_remove_ref): New, remove a single ref.
184 (ctf_str_count_strtab): Do not count the initial null string's
185 length or the existence or length of any unreferenced internal
186 atoms.
187 (ctf_str_populate_sorttab): Skip atoms with no refs.
188 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
189 to the cts_len for the null string, since it is no longer done
190 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
191 Populate the csa_offset for both internal and external cases.
192 Flush the ctf_prov_strtab afterwards, and reset the
193 ctf_str_prov_offset.
194 * ctf-create.c (ctf_grow_ptrtab): New.
195 (ctf_create): Call it. Initialize new fields rather than old
196 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
197 Set the ctl hashes and data model.
198 (ctf_update): Rename to...
199 (ctf_serialize): ... this. Leave a compatibility function behind.
200 Tell ctf_simple_open_internal that this is a writable dictionary.
201 Pass the new fields along from the old dictionary. Drop
202 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
203 Do not zero out the DTD's ctt_name.
204 (ctf_prefixed_name): Rename to...
205 (ctf_name_table): ... this. No longer return a prefixed name: return
206 the applicable name table instead.
207 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
208 kind we're adding. Migrate away from dtd_name.
209 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
210 deleted ctt_name.
211 (ctf_dtd_lookup_type_by_name): Remove.
212 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
213 No longer check ctf_dtnextid: check ctf_typemax instead.
214 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
215 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
216 ctf_name_table and the right name table, and migrate away from
217 dtd_name as in ctf_dtd_delete.
218 (ctf_add_generic): Pass in the kind explicitly and pass it to
219 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
220 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
221 Grow the ptrtab if needed.
222 (ctf_add_encoded): Pass in the kind.
223 (ctf_add_slice): Likewise.
224 (ctf_add_array): Likewise.
225 (ctf_add_function): Likewise.
226 (ctf_add_typedef): Likewise.
227 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
228 ctt_name rather than dtd_name.
229 (ctf_add_struct_sized): Pass in the kind. Use
230 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
231 ctf_dtd_lookup_type_by_name.
232 (ctf_add_union_sized): Likewise.
233 (ctf_add_enum): Likewise.
234 (ctf_add_enum_encoded): Likewise.
235 (ctf_add_forward): Likewise.
236 (ctf_add_type): Likewise.
237 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
238 being initialized until after the call.
239 (ctf_write_mem): Likewise.
240 (ctf_write): Likewise.
241 * ctf-archive.c (arc_write_one_ctf): Likewise.
242 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
243 ctf_hash_lookup_type.
244 (ctf_lookup_by_id): No longer check the readonly types if the
245 dictionary is writable.
246 * ctf-open.c (init_types): Assert that this dictionary is not
247 writable. Adjust to use the new name hashes, ctf_name_table,
248 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
249 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
250 if set. Drop out early when dictionary is writable. Split the
251 ctf_lookups initialization into...
252 (ctf_set_cth_hashes): ... this new function.
253 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
254 (ctf_simple_open): Adjust accordingly.
255 (ctf_bufopen): Likewise.
256 (ctf_file_close): Destroy the appropriate name hashes. No longer
257 destroy ctf_dtbyname, which is gone.
258 (ctf_getdatasect): Remove spurious "extern".
259 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
260 specified name table, given a kind.
261 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
262 (ctf_member_iter): Add support for iterating over the
263 dynamic type list.
264 (ctf_enum_iter): Likewise.
265 (ctf_variable_iter): Likewise.
266 (ctf_type_rvisit): Likewise.
267 (ctf_member_info): Add support for types in the dynamic type list.
268 (ctf_enum_name): Likewise.
269 (ctf_enum_value): Likewise.
270 (ctf_func_type_info): Likewise.
271 (ctf_func_type_args): Likewise.
272 * ctf-link.c (ctf_accumulate_archive_names): No longer call
273 ctf_update.
274 (ctf_link_write): Likewise.
275 (ctf_link_intern_extern_string): Adjust for new
276 ctf_str_add_external return value.
277 (ctf_link_add_strtab): Likewise.
278 * ctf-util.c (ctf_list_empty_p): New.
279
791915db
NA
2802019-08-05 Nick Alcock <nick.alcock@oracle.com>
281
282 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
283 type zero.
284 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
285 members and types.
286 (ctf_add_variable): Likewise for variables pointing to them.
287 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
288 type link failure, but do warn for others.
289 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
290 errors to be ENOMEM.
291 (ctf_dump_member): Likewise.
292 (ctf_dump_type): Likewise.
293 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
294 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
295 (ctf_dump_header): Likewise.
296 (ctf_dump_label): likewise.
297 (ctf_dump_objts): likewise.
298 (ctf_dump_funcs): likewise.
299 (ctf_dump_var): likewise.
300 (ctf_dump_str): Likewise.
301
87279e3c
NA
3022019-09-30 Nick Alcock <nick.alcock@oracle.com>
303
304 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
305 (LT_INIT): Likewise.
306 (AM_INSTALL_LIBBFD): Likewise.
307 (dlopen): Note why this is necessary in a comment.
308 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
309 opcodes/.
310 (SHARED_LDFLAGS): Likewise.
311 (BFD_LIBADD): Likewise, for libbfd.
312 (BFD_DEPENDENCIES): Likewise.
313 (VERSION_FLAGS): Initialize, using a version script if ld supports
314 one, or libtool -export-symbols-regex otherwise.
315 (AC_CONFIG_MACRO_DIR): Add ../BFD.
316 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
317 (INCDIR): New.
318 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
319 (noinst_LIBRARIES): Replace with...
320 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
321 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
322 libctf-nobfd.la as well.
323 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
324 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
325 (libctf_a_SOURCES): Rename to...
326 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
327 ctf-open-bfd.c.
328 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
329 with ctf-open-bfd.c added.
330 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
331 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
332 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
333 * Makefile.am [INSTALL_LIBCTF]: Use it.
334 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
335 libtool macros.
336 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
337 the unstable components).
338 * Makefile.in: Regenerated.
339 * config.h.in: Likewise.
340 * configure: Likewise.
341
3422019-07-30 Nick Alcock <nick.alcock@oracle.com>
343
344 * configure.ac (INSTALL_LIBCTF): New, controlled by
345 --enable-install-libctf.
346 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
347 * Makefile.in: Regenerated.
348 * configure: Regenerated.
349
f046147d
NA
3502019-07-30 Nick Alcock <nick.alcock@oracle.com>
351
352 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
353 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
354
edc8bbe9
NA
3552019-07-30 Nick Alcock <nick.alcock@oracle.com>
356
357 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
358
7e97445a
NA
3592019-07-13 Nick Alcock <nick.alcock@oracle.com>
360
361 * ctf-impl.h (includes): Include <sys/param.h> here.
362
5ae6af75
NA
3632019-07-30 Nick Alcock <nick.alcock@oracle.com>
364
365 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
366 (flip_objts): Likewise.
367 (flip_vars): Likewise.
368 (flip_types): Likewise.
369
1820745a
NA
3702019-07-30 Nick Alcock <nick.alcock@oracle.com>
371
372 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
373 freeing functions: if set, free the key and value if the slot
374 already exists. Always reassign the key.
375 (ctf_dynhash_insert): Adjust call appropriately.
376 (ctf_hash_insert_type): Likewise.
377
5de9eada
NA
3782019-08-03 Nick Alcock <nick.alcock@oracle.com>
379
380 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
381 type kind. Allow forwards to unify with pre-existing structs/
382 unions/enums.
383
49ea9b45
NA
3842019-07-30 Nick Alcock <nick.alcock@oracle.com>
385
386 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
387 <ctf_link_memb_name_changer>: Likewise.
388 <ctf_link_memb_name_changer_arg>: Likewise.
389 * ctf-create.c (ctf_update): Update accordingly.
390 * ctf-open.c (ctf_file_close): Likewise.
391 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
392 (ctf_link_add_cu_mapping): New.
393 (ctf_link_set_memb_name_changer): Likewise.
394 (ctf_change_parent_name): New.
395 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
396 allocated by the caller's ctf_link_memb_name_changer.
397 <ndynames>: Likewise.
398 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
399 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
400 ctf_change_parent_name. Free any resulting names.
401
eabb7154
NA
4022019-07-13 Nick Alcock <nick.alcock@oracle.com>
403
404 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
405 (ctf_link_one_type): ... here, with parent-name setting added.
406 (check_variable): New.
407 (ctf_link_one_variable): Likewise.
408 (ctf_link_one_input_archive_member): Call it.
409 * ctf-error.c (_ctf_errlist): Updated with new errors.
410
886453cb
NA
4112019-07-13 Nick Alcock <nick.alcock@oracle.com>
412
413 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
414 (struct ctf_link_type_mapping_key): New.
415 (ctf_hash_type_mapping_key): Likewise.
416 (ctf_hash_eq_type_mapping_key): Likewise.
417 (ctf_add_type_mapping): Likewise.
418 (ctf_type_mapping): Likewise.
419 (ctf_dynhash_empty): Likewise.
420 * ctf-open.c (ctf_file_close): Update accordingly.
421 * ctf-create.c (ctf_update): Likewise.
422 (ctf_add_type): Populate the mapping.
423 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
424 (ctf_hash_eq_type_mapping_key): Check the key for equality.
425 (ctf_dynhash_insert): Fix comment typo.
426 (ctf_dynhash_empty): New.
427 * ctf-link.c (ctf_add_type_mapping): New.
428 (ctf_type_mapping): Likewise.
429 (empty_link_type_mapping): New.
430 (ctf_link_one_input_archive): Call it.
431
72c83edd
NA
4322019-07-13 Nick Alcock <nick.alcock@oracle.com>
433
434 * ctf-link.c: New file, linking of the string and type sections.
435 * Makefile.am (libctf_a_SOURCES): Add it.
436 * Makefile.in: Regenerate.
437
438 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
439 ctf_link_outputs.
440 * ctf-create.c (ctf_update): Update accordingly.
441 * ctf-open.c (ctf_file_close): Likewise.
442 * ctf-error.c (_ctf_errlist): Updated with new errors.
443
d18f9f16
NA
4442019-07-13 Nick Alcock <nick.alcock@oracle.com>
445
446 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
447
b4f0e09c
NA
4482019-07-13 Nick Alcock <nick.alcock@oracle.com>
449
450 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
451 ctf_type_iter.
452 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
453 (ctf_dump_format_type): Add non-root-type { } notation.
454 Add root flag to prototype.
455 (ctf_dump_label): Adjust accordingly.
456 (ctf_dump_objts): Likewise.
457 (ctf_dump_var): Likewise.
458
3dde2c91
NA
4592019-07-13 Nick Alcock <nick.alcock@oracle.com>
460
461 * ctf-create.c (ctf_compress_write): Fix double-free.
462
5537f9b9
NA
4632019-07-13 Nick Alcock <nick.alcock@oracle.com>
464
465 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
466 of...
467 (ctf_arc_write_fd): ... this new function.
468 * ctf-create.c (ctf_write_mem): New.
469
d851ecd3
NA
4702019-07-13 Nick Alcock <nick.alcock@oracle.com>
471
472 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
473 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
474 (ctf_str_add_ref): Name the last arg.
475 (ctf_str_add_external) New.
476 (ctf_str_add_strraw_explicit): Likewise.
477 (ctf_simple_open_internal): Likewise.
478 (ctf_bufopen_internal): Likewise.
479
480 * ctf-string.c (ctf_strraw_explicit): Split from...
481 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
482 (ctf_str_add_ref_internal): Return the atom, not the
483 string.
484 (ctf_str_add): Adjust accordingly.
485 (ctf_str_add_ref): Likewise. Move up in the file.
486 (ctf_str_add_external): New: update the csa_offset.
487 (ctf_str_count_strtab): Only account for strings with no csa_offset
488 in the internal strtab length.
489 (ctf_str_write_strtab): If the csa_offset is set, update the
490 string's refs without writing the string out, and update the
491 ctf_syn_ext_strtab. Make OOM handling less ugly.
492 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
493 (ctf_update): Handle failure to populate the strtab. Pass in the
494 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
495 Call ctf_simple_open_internal, not ctf_simple_open.
496 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
497 strings by hand.
498 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
499 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
500 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
501 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
502 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
503 (ctf_simple_open_internal): ... this new function, which calls
504 ctf_bufopen_internal.
505 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
506 (ctf_bufopen_internal): ... this new function, which sets
507 ctf_syn_ext_strtab.
508
0ac62312
NA
5092019-07-13 Nick Alcock <nick.alcock@oracle.com>
510
511 * ctf_types.c (ctf_type_iter_all): New.
512
2db912ba
NA
5132019-07-13 Nick Alcock <nick.alcock@oracle.com>
514
515 * ctf-open.c (init_symtab): Check for overflow against the right
516 section.
517 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
518 (upgrade_types_v1): Note that these sections are not checked.
519 (flip_header): Endian-swap the header fields.
520 (flip_ctf): Endian-swap the sections.
521 (flip_objts): Update comment.
522 (ctf_bufopen): Check header offsets and alignment for validity.
523
6d5944fc
NA
5242019-07-13 Nick Alcock <nick.alcock@oracle.com>
525
526 * ctf-open-bfd.c: Add <assert.h>.
527 (ctf_bfdopen_ctfsect): Open string and symbol tables using
528 techniques borrowed from bfd_elf_sym_name.
529 (ctf_new_archive_internal): Improve comment.
530 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
531 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
532 no symbol section, but not vice versa.
533
9b32cba4
NA
5342019-07-08 Nick Alcock <nick.alcock@oracle.com>
535
536 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
537 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
538 * ctf-dump.c (dump_header): New function, dump the CTF header.
539 (ctf_dump): Call it.
540 (ctf_dump_header_strfield): New function.
541 (ctf_dump_header_sectfield): Likewise.
542
fd55eae8
NA
5432019-07-06 Nick Alcock <nick.alcock@oracle.com>
544
545 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
546 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
547 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
548 ctf_base: do not assume that it is always sizeof (ctf_header_t).
549 Print out ctf_cuname: only print out ctf_parname if set.
550 (ctf_free_base): Removed, ctf_base is no longer freed: free
551 ctf_dynbase instead.
552 (ctf_set_version): Fix spacing.
553 (upgrade_header): New, in-place header upgrading.
554 (upgrade_types): Rename to...
555 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
556 longer track old and new headers separately. No longer allow for
557 header sizes explicitly: squeeze the headers out on upgrade (they
558 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
559 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
560 (upgrade_types): New, also handle ctf_parmax updating.
561 (flip_header): Flip ctf_cuname.
562 (flip_types): Flip BUF explicitly rather than deriving BUF from
563 BASE.
564 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
565 required alignment of objtoff and funcoff. No longer store it in
566 the ctf_buf unless that buf is derived unmodified from the input.
567 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
568 that duplicate fields in ctf_file: move allocation of ctf_file
569 further up instead. Call upgrade_header as needed. Move
570 version-specific ctf_parmax initialization into upgrade_types. More
571 concise error handling.
572 (ctf_file_close): No longer test for null pointers before freeing.
573 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
574 ctf_free_base.
575 (ctf_cuname): New.
576 (ctf_cuname_set): New.
577 * ctf-create.c (ctf_update): Populate ctf_cuname.
578 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
579 comment.
580 (ctf_write): Likewise.
581 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
582 Fix the compression length: fp->ctf_size never counted the CTF
583 header. Simplify the compress call accordingly.
584
a2230b5e
HPN
5852019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
586
587 * ctf-endian.h: Don't assume htole64 and le64toh are always
588 present if HAVE_ENDIAN_H; also check if htole64 is defined.
589 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
590 not bswap_identity_64.
591
fd361982
AM
5922019-09-18 Alan Modra <amodra@gmail.com>
593
594 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
595
60391a25
PB
5962019-09-09 Phil Blundell <pb@pbcl.net>
597
598 binutils 2.33 branch created.
599
12a0b67d
NA
6002019-07-18 Nick Alcock <nick.alcock@oracle.com>
601
602 * ctf-types.c (ctf_type_aname_raw): New.
603 (ctf_func_type_info): Likewise.
604 (ctf_func_type_args): Likewise.
605 * ctf-error.c (_ctf_errlist): Fix description.
606 * ctf-lookup.c: Fix file description.
607
083114f8 6082019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
609
610 * ctf-create.c (ctf_create): Fix off-by-one error.
611
083114f8 6122019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
613
614 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
615 struct ctf_strs.
616 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
617 (struct ctf_str_atom): New, disambiguated single string.
618 (struct ctf_str_atom_ref): New, points to some other location that
619 references this string's offset.
620 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
621 Remove member ctf_dtvstrlen: we no longer track the total strlen
622 as we add strings.
623 (ctf_str_create_atoms): Declare new function in ctf-string.c.
624 (ctf_str_free_atoms): Likewise.
625 (ctf_str_add): Likewise.
626 (ctf_str_add_ref): Likewise.
627 (ctf_str_rollback): Likewise.
628 (ctf_str_purge_refs): Likewise.
629 (ctf_str_write_strtab): Likewise.
630 (ctf_realloc): Declare new function in ctf-util.c.
631
632 * ctf-open.c (ctf_bufopen): Create the atoms table.
633 (ctf_file_close): Destroy it.
634 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
635 special-case the position of the parname string. Construct the
636 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
637 rest of each buffer element is constructed, not via open-coding:
638 realloc the CTF buffer and append the strtab to it. No longer
639 maintain ctf_dtvstrlen. Sort the variable entry table later, after
640 strtab construction.
641 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
642 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
643 after buffer element construction instead.
644 (ctf_copy_lmembers): Likewise.
645 (ctf_copy_emembers): Likewise.
646 (ctf_create): No longer maintain the ctf_dtvstrlen.
647 (ctf_dtd_delete): Likewise.
648 (ctf_dvd_delete): Likewise.
649 (ctf_add_generic): Likewise.
650 (ctf_add_enumerator): Likewise.
651 (ctf_add_member_offset): Likewise.
652 (ctf_add_variable): Likewise.
653 (membadd): Likewise.
654 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
655 if there are active ctf_str_num_refs.
656 (ctf_strraw): Move to ctf-string.c.
657 (ctf_strptr): Likewise.
658 * ctf-string.c: New file, strtab manipulation.
659
660 * Makefile.am (libctf_a_SOURCES): Add it.
661 * Makefile.in: Regenerate.
662
083114f8 6632019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
664
665 * ctf-impl.h (ctf_hash_iter_f): New.
666 (ctf_dynhash_iter): New declaration.
667 (ctf_dynhash_iter_remove): New declaration.
668 * ctf-hash.c (ctf_dynhash_iter): Define.
669 (ctf_dynhash_iter_remove): Likewise.
670 (ctf_hashtab_traverse): New.
671 (ctf_hashtab_traverse_remove): Likewise.
672 (struct ctf_traverse_cb_arg): Likewise.
673 (struct ctf_traverse_remove_cb_arg): Likewise.
674
083114f8 6752019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
676
677 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
678
083114f8 6792019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
680
681 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
682 (ctf_dump_funcs): Likewise.
683
083114f8 6842019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
685
686 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
687 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
688 little-endian CTF archive magic. Do not check the CTF version:
689 ctf_simple_open does that in endian-safe ways. Do not dereference
690 null pointers on open failure.
691
083114f8 6922019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
693
694 * ctf-open.c (get_vbytes_common): Return the new slice size.
695 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
696 Remember to copy in the CTF data when opening an uncompressed
697 foreign-endian CTF file. Prune useless variable manipulation.
698
083114f8 6992019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
700
701 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
702 seen.
703
083114f8 7042019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
705
706 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
707 output.
708
083114f8 7092019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
710
711 * ctf-subr.c (_PAGESIZE): Remove.
712 (ctf_data_alloc): Likewise.
713 (ctf_data_free): Likewise.
714 (ctf_data_protect): Likewise.
715 * ctf-impl.h: Remove declarations.
716 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
717 ctf_free, not ctf_data_free.
718 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
719 the buffer again on compression error.
720 * ctf-open.c (ctf_set_base): No longer track the size: call
721 ctf_free, not ctf_data_free.
722 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
723 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
724
083114f8 7252019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
726
727 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
728 ctf_dynhash_insert.
729 (ctf_dvd_insert): Likewise.
730 (ctf_add_generic): Likewise.
731 (ctf_add_variable): Likewise.
732 * ctf-impl.h: Adjust declarations.
733
3a3a077c
AM
7342019-06-14 Alan Modra <amodra@gmail.com>
735
736 * configure: Regenerate.
737
942d35f7
NA
7382019-06-06 Nick Alcock <nick.alcock@oracle.com>
739
740 * ctf-decls.h: Include <libiberty.h>.
741 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
742
595a4d43
NA
7432019-06-06 Nick Alcock <nick.alcock@oracle.com>
744
745 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
746 (ctf_dump_objts): Likewise.
747 (ctf_dump_funcs): Likewise.
748 (ctf_dump_member): Likewise.
749 (ctf_dump_str): Likewise.
750
f5e73be1
NA
7512019-06-06 Nick Alcock <nick.alcock@oracle.com>
752
753 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
754 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
755
62d8e3b7
NA
7562019-06-05 Nick Alcock <nick.alcock@oracle.com>
757
758 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
759 (ctf_arc_open_by_offset): Likewise.
760 * ctf-create.c (ctf_add_type): Likewise.
761
76fad999
TT
7622019-06-04 Tom Tromey <tromey@adacore.com>
763
764 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
765 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
766
ad118caa
NA
7672019-06-04 Nick Alcock <nick.alcock@oracle.com>
768
769 * configure.ac: Check for O_CLOEXEC.
770 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
771 * config.h.in: Regenerate.
772 * configure: Likewise.
773
6b22174f
NA
7742019-06-04 Nick Alcock <nick.alcock@oracle.com>
775
776 * qsort_r.c: Rename to...
777 * ctf-qsort_r.c: ... this.
778 (_quicksort): Define to ctf_qsort_r.
779 * ctf-decls.h (qsort_r): Remove.
780 (ctf_qsort_r): Add.
781 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
782 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
783 * Makefile.am (libctf_a_LIBADD): Remove.
784 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
785 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
786 * ctf-create.c (ctf_update): Likewise.
787 * configure.ac: Check for BSD versus GNU qsort_r signature.
788 * Makefile.in: Regenerate.
789 * config.h.in: Likewise.
790 * configure: Likewise.
791
941accce
NA
7922019-06-03 Nick Alcock <nick.alcock@oracle.com>
793
794 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
795
a0486bac
JM
7962019-05-29 Nick Alcock <nick.alcock@oracle.com>
797
798 * Makefile.am (ZLIB): New.
799 (ZLIBINC): Likewise.
800 (AM_CFLAGS): Use them.
801 (libctf_a_LIBADD): New, for LIBOBJS.
802 * configure.ac: Check for zlib, endian.h, and qsort_r.
803 * ctf-endian.h: New, providing htole64 and le64toh.
804 * swap.h: Code style fixes.
805 (bswap_identity_64): New.
806 * qsort_r.c: New, from gnulib (with one added #include).
807 * ctf-decls.h: New, providing a conditional qsort_r declaration,
808 and unconditional definitions of MIN and MAX.
809 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
810 (ctf_set_errno): Now returns unsigned long.
811 * ctf-util.c (ctf_set_errno): Adjust here too.
812 * ctf-archive.c: Use ctf-endian.h.
813 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
814 cts_flags and cts_offset.
815 (ctf_arc_write): Drop debugging dependent on the size of off_t.
816 * ctf-create.c: Provide a definition of roundup if not defined.
817 (ctf_create): Drop cts_type, cts_flags and cts_offset.
818 (ctf_add_reftype): Do not check if type IDs are below zero.
819 (ctf_add_slice): Likewise.
820 (ctf_add_typedef): Likewise.
821 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
822 when known error-free. Drop CTF_ERR usage for functions returning
823 int.
824 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
825 int.
826 (ctf_add_variable): Likewise.
827 (enumcmp): Likewise.
828 (enumadd): Likewise.
829 (membcmp): Likewise.
830 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
831 when known error-free.
832 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
833 returning int: use CTF_ERR for functions returning ctf_type_id.
834 (ctf_dump_label): Likewise.
835 (ctf_dump_objts): Likewise.
836 * ctf-labels.c (ctf_label_topmost): Likewise.
837 (ctf_label_iter): Likewise.
838 (ctf_label_info): Likewise.
839 * ctf-lookup.c (ctf_func_args): Likewise.
840 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
841 (ctf_bufopen): Likewise. Use zlib types as needed.
842 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
843 returning int.
844 (ctf_enum_iter): Likewise.
845 (ctf_type_size): Likewise.
846 (ctf_type_align): Likewise. Cast to size_t where appropriate.
847 (ctf_type_kind_unsliced): Likewise.
848 (ctf_type_kind): Likewise.
849 (ctf_type_encoding): Likewise.
850 (ctf_member_info): Likewise.
851 (ctf_array_info): Likewise.
852 (ctf_enum_value): Likewise.
853 (ctf_type_rvisit): Likewise.
854 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
855 cts_offset.
856 (ctf_simple_open): Likewise.
857 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
858 * Makefile.in: Regenerate.
859 * aclocal.m4: Likewise.
860 * config.h: Likewise.
861 * configure: Likewise.
862
9698cf9b
NA
8632019-05-28 Nick Alcock <nick.alcock@oracle.com>
864
865 * configure.in: Check for bfd_section_from_elf_index.
866 * configure: Regenerate.
867 * config.h.in [HAVE_BFD_ELF]: Likewise.
868 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
869 abfd is potentially unused now.
870
0e65dfba
NA
8712019-05-28 Nick Alcock <nick.alcock@oracle.com>
872
873 * Makefile.am: New.
874 * Makefile.in: Regenerated.
875 * config.h.in: Likewise.
876 * aclocal.m4: Likewise.
877 * configure: Likewise.
878
a30b3e18
NA
8792019-05-28 Nick Alcock <nick.alcock@oracle.com>
880
881 * ctf-dump.c: New.
882
6dbf2b73
NA
8832019-05-28 Nick Alcock <nick.alcock@oracle.com>
884
885 * ctf-labels.c: New.
886
6c33b742
NA
8872019-05-28 Nick Alcock <nick.alcock@oracle.com>
888
889 * ctf-impl.h (_libctf_version): New declaration.
890 * ctf-subr.c (_libctf_version): Define it.
891 (ctf_version): New.
892
c499eb68
NA
8932019-05-28 Nick Alcock <nick.alcock@oracle.com>
894
895 * ctf-create.c (enumcmp): New.
896 (enumadd): Likewise.
897 (membcmp): Likewise.
898 (membadd): Likewise.
899 (ctf_add_type): Likewise.
900
b437bfe0
NA
9012019-05-28 Nick Alcock <nick.alcock@oracle.com>
902
903 * ctf-lookup.c (isqualifier): New.
904 (ctf_lookup_by_name): Likewise.
905 (struct ctf_lookup_var_key): Likewise.
906 (ctf_lookup_var): Likewise.
907 (ctf_lookup_variable): Likewise.
908 (ctf_lookup_symbol_name): Likewise.
909 (ctf_lookup_by_symbol): Likewise.
910 (ctf_func_info): Likewise.
911 (ctf_func_args): Likewise.
912
316afdb1
NA
9132019-05-28 Nick Alcock <nick.alcock@oracle.com>
914
915 * ctf-decl.c: New file.
916 * ctf-types.c: Likewise.
917 * ctf-impl.h: New declarations.
918
143dce84
NA
9192019-05-28 Nick Alcock <nick.alcock@oracle.com>
920
921 * ctf-open-bfd.c: New file.
922 * ctf-open.c (ctf_close): New.
923 * ctf-impl.h: Include bfd.h.
924 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
925 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
926 ctfi_bfd_close.
927 (ctf_bfdopen_ctfsect): New declaration.
928 (_CTF_SECTION): likewise.
929
9402cc59
NA
9302019-05-28 Nick Alcock <nick.alcock@oracle.com>
931
932 * ctf-archive.c: New.
933 * ctf-impl.h (ctf_archive_internal): New type.
934 (ctf_arc_open_internal): New declaration.
935 (ctf_arc_bufopen): Likewise.
936 (ctf_arc_close_internal): Likewise.
937
72f33921
NA
9382019-05-28 Nick Alcock <nick.alcock@oracle.com>
939
940 * ctf-open.c: New file.
941 * swap.h: Likewise.
942
47d546f4
NA
9432019-05-28 Nick Alcock <nick.alcock@oracle.com>
944
945 * ctf-create.c: New file.
946 * ctf-lookup.c: New file.
947
a5be9bbe
NA
9482019-05-28 Nick Alcock <nick.alcock@oracle.com>
949
950 * ctf-impl.h: New definitions and declarations for type creation
951 and lookup.
952
c0754cdd
NA
9532019-05-28 Nick Alcock <nick.alcock@oracle.com>
954
955 * ctf-hash.c: New file.
956 * ctf-impl.h: New declarations.
957
479604f4
NA
9582019-05-28 Nick Alcock <nick.alcock@oracle.com>
959
960 * ctf-error.c: New file.
961
94585e7f
NA
9622019-05-28 Nick Alcock <nick.alcock@oracle.com>
963
964 * ctf-util.c: New file.
965 * elf.h: Likewise.
966 * ctf-impl.h: Include it, and add declarations.
967
60da9d95
NA
9682019-05-28 Nick Alcock <nick.alcock@oracle.com>
969
970 * ctf-impl.h: New file.
971 * ctf-subr.c: New file.
972
973\f
974Local Variables:
975mode: change-log
976left-margin: 8
977fill-column: 76
978version-control: never
979End:
This page took 0.116403 seconds and 4 git commands to generate.