libctf: fix tabdamage
[deliverable/binutils-gdb.git] / libctf / ChangeLog
CommitLineData
fa56cdcd
NA
12019-09-30 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
4 * ctf-types.c (ctf_type_lname): Likewise.
5
ad613f1d
NA
62019-09-23 Nick Alcock <nick.alcock@oracle.com>
7
8 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
9 ctf_import after the first for a given file.
10
9323dd86
NA
112019-09-23 Nick Alcock <nick.alcock@oracle.com>
12
13 * ctf-impl.h (ctf_str_append_noerr): Declare.
14 * ctf-util.c (ctf_str_append_noerr): Define in terms of
15 ctf_str_append.
16 * ctf-dump.c (str_append): New, call it.
17 (ctf_dump_format_type): Use str_append, not ctf_str_append.
18 (ctf_dump_label): Likewise.
19 (ctf_dump_objts): Likewise.
20 (ctf_dump_funcs): Likewise.
21 (ctf_dump_var): Likewise.
22 (ctf_dump_member): Likewise.
23 (ctf_dump_type): Likewise.
24 (ctf_dump): Likewise.
25
de07e349
NA
262019-09-23 Nick Alcock <nick.alcock@oracle.com>
27
28 * ctf-impl.h (ctf_alloc): Remove.
29 (ctf_free): Likewise.
30 (ctf_strdup): Likewise.
31 * ctf-subr.c (ctf_alloc): Remove.
32 (ctf_free): Likewise.
33 * ctf-util.c (ctf_strdup): Remove.
34
35 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
36 ctf_free; strdup, not ctf_strdup.
37 (ctf_dtd_delete): Likewise.
38 (ctf_dvd_delete): Likewise.
39 (ctf_add_generic): Likewise.
40 (ctf_add_function): Likewise.
41 (ctf_add_enumerator): Likewise.
42 (ctf_add_member_offset): Likewise.
43 (ctf_add_variable): Likewise.
44 (membadd): Likewise.
45 (ctf_compress_write): Likewise.
46 (ctf_write_mem): Likewise.
47 * ctf-decl.c (ctf_decl_push): Likewise.
48 (ctf_decl_fini): Likewise.
49 (ctf_decl_sprintf): Likewise. Check for OOM.
50 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
51 ctf_free; strdup, not ctf_strdup.
52 (ctf_dump_free): Likewise.
53 (ctf_dump): Likewise.
54 * ctf-open.c (upgrade_types_v1): Likewise.
55 (init_types): Likewise.
56 (ctf_file_close): Likewise.
57 (ctf_bufopen_internal): Likewise. Check for OOM.
58 (ctf_parent_name_set): Likewise: report the OOM to the caller.
59 (ctf_cuname_set): Likewise.
60 (ctf_import): Likewise.
61 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
62 free, not ctf_free; strdup, not ctf_strdup.
63 (ctf_str_free_atom): Likewise.
64 (ctf_str_create_atoms): Likewise.
65 (ctf_str_add_ref_internal): Likewise.
66 (ctf_str_remove_ref): Likewise.
67 (ctf_str_write_strtab): Likewise.
68
9c1a2295
NA
692019-08-09 Nick Alcock <nick.alcock@oracle.com>
70
71 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
72 work right for non-int/fps.
73
1a6ab13e
NA
742019-08-08 Nick Alcock <nick.alcock@oracle.com>
75
76 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
77 null pointer.
78
99dc3ebd
NA
792019-08-07 Nick Alcock <nick.alcock@oracle.com>
80
81 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
82 * ctf-open.c (ctf_file_close): Free it.
83 * ctf-create.c (ctf_serialize): Adjust.
84 (membcmp): When reporting a conflict due to an error, report the
85 error.
86 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
87 (ctf_add_type_internal): ... this. Hand back types we are already
88 in the middle of adding immediately. Hand back structs/unions with
89 the same number of members immediately. Do not walk the dynamic
90 list. Call ctf_add_type_internal, not ctf_add_type. Handle
91 forwards promoted to other types and the inverse case identically.
92 Add structs to the mapping as soon as we intern them, before they
93 gain any members.
94
676c3ecb
NA
952019-08-09 Nick Alcock <nick.alcock@oracle.com>
96
97 * ctf-impl.h (ctf_names_t): New.
98 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
99 (ctf_file_t) <ctf_structs>: Likewise.
100 <ctf_unions>: Likewise.
101 <ctf_enums>: Likewise.
102 <ctf_names>: Likewise.
103 <ctf_lookups>: Improve comment.
104 <ctf_ptrtab_len>: New.
105 <ctf_prov_strtab>: New.
106 <ctf_str_prov_offset>: New.
107 <ctf_dtbyname>: Remove, redundant to the names hashes.
108 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
109 (ctf_dtdef_t) <dtd_name>: Remove.
110 <dtd_data>: Note that the ctt_name is now populated.
111 (ctf_str_atom_t) <csa_offset>: This is now the strtab
112 offset for internal strings too.
113 <csa_external_offset>: New, the external strtab offset.
114 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
115 (ctf_name_table): New declaration.
116 (ctf_lookup_by_rawname): Likewise.
117 (ctf_lookup_by_rawhash): Likewise.
118 (ctf_set_ctl_hashes): Likewise.
119 (ctf_serialize): Likewise.
120 (ctf_dtd_insert): Adjust.
121 (ctf_simple_open_internal): Likewise.
122 (ctf_bufopen_internal): Likewise.
123 (ctf_list_empty_p): Likewise.
124 (ctf_str_remove_ref): Likewise.
125 (ctf_str_add): Returns uint32_t now.
126 (ctf_str_add_ref): Likewise.
127 (ctf_str_add_external): Now returns a boolean (int).
128 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
129 for strings in the appropriate range.
130 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
131 when adding the null string to the new strtab.
132 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
133 (ctf_str_add_ref_internal): Add make_provisional argument. If
134 make_provisional, populate the offset and fill in the
135 ctf_prov_strtab accordingly.
136 (ctf_str_add): Return the offset, not the string.
137 (ctf_str_add_ref): Likewise.
138 (ctf_str_add_external): Return a success integer.
139 (ctf_str_remove_ref): New, remove a single ref.
140 (ctf_str_count_strtab): Do not count the initial null string's
141 length or the existence or length of any unreferenced internal
142 atoms.
143 (ctf_str_populate_sorttab): Skip atoms with no refs.
144 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
145 to the cts_len for the null string, since it is no longer done
146 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
147 Populate the csa_offset for both internal and external cases.
148 Flush the ctf_prov_strtab afterwards, and reset the
149 ctf_str_prov_offset.
150 * ctf-create.c (ctf_grow_ptrtab): New.
151 (ctf_create): Call it. Initialize new fields rather than old
152 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
153 Set the ctl hashes and data model.
154 (ctf_update): Rename to...
155 (ctf_serialize): ... this. Leave a compatibility function behind.
156 Tell ctf_simple_open_internal that this is a writable dictionary.
157 Pass the new fields along from the old dictionary. Drop
158 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
159 Do not zero out the DTD's ctt_name.
160 (ctf_prefixed_name): Rename to...
161 (ctf_name_table): ... this. No longer return a prefixed name: return
162 the applicable name table instead.
163 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
164 kind we're adding. Migrate away from dtd_name.
165 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
166 deleted ctt_name.
167 (ctf_dtd_lookup_type_by_name): Remove.
168 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
169 No longer check ctf_dtnextid: check ctf_typemax instead.
170 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
171 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
172 ctf_name_table and the right name table, and migrate away from
173 dtd_name as in ctf_dtd_delete.
174 (ctf_add_generic): Pass in the kind explicitly and pass it to
175 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
176 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
177 Grow the ptrtab if needed.
178 (ctf_add_encoded): Pass in the kind.
179 (ctf_add_slice): Likewise.
180 (ctf_add_array): Likewise.
181 (ctf_add_function): Likewise.
182 (ctf_add_typedef): Likewise.
183 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
184 ctt_name rather than dtd_name.
185 (ctf_add_struct_sized): Pass in the kind. Use
186 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
187 ctf_dtd_lookup_type_by_name.
188 (ctf_add_union_sized): Likewise.
189 (ctf_add_enum): Likewise.
190 (ctf_add_enum_encoded): Likewise.
191 (ctf_add_forward): Likewise.
192 (ctf_add_type): Likewise.
193 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
194 being initialized until after the call.
195 (ctf_write_mem): Likewise.
196 (ctf_write): Likewise.
197 * ctf-archive.c (arc_write_one_ctf): Likewise.
198 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
199 ctf_hash_lookup_type.
200 (ctf_lookup_by_id): No longer check the readonly types if the
201 dictionary is writable.
202 * ctf-open.c (init_types): Assert that this dictionary is not
203 writable. Adjust to use the new name hashes, ctf_name_table,
204 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
205 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
206 if set. Drop out early when dictionary is writable. Split the
207 ctf_lookups initialization into...
208 (ctf_set_cth_hashes): ... this new function.
209 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
210 (ctf_simple_open): Adjust accordingly.
211 (ctf_bufopen): Likewise.
212 (ctf_file_close): Destroy the appropriate name hashes. No longer
213 destroy ctf_dtbyname, which is gone.
214 (ctf_getdatasect): Remove spurious "extern".
215 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
216 specified name table, given a kind.
217 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
218 (ctf_member_iter): Add support for iterating over the
219 dynamic type list.
220 (ctf_enum_iter): Likewise.
221 (ctf_variable_iter): Likewise.
222 (ctf_type_rvisit): Likewise.
223 (ctf_member_info): Add support for types in the dynamic type list.
224 (ctf_enum_name): Likewise.
225 (ctf_enum_value): Likewise.
226 (ctf_func_type_info): Likewise.
227 (ctf_func_type_args): Likewise.
228 * ctf-link.c (ctf_accumulate_archive_names): No longer call
229 ctf_update.
230 (ctf_link_write): Likewise.
231 (ctf_link_intern_extern_string): Adjust for new
232 ctf_str_add_external return value.
233 (ctf_link_add_strtab): Likewise.
234 * ctf-util.c (ctf_list_empty_p): New.
235
791915db
NA
2362019-08-05 Nick Alcock <nick.alcock@oracle.com>
237
238 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
239 type zero.
240 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
241 members and types.
242 (ctf_add_variable): Likewise for variables pointing to them.
243 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
244 type link failure, but do warn for others.
245 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
246 errors to be ENOMEM.
247 (ctf_dump_member): Likewise.
248 (ctf_dump_type): Likewise.
249 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
250 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
251 (ctf_dump_header): Likewise.
252 (ctf_dump_label): likewise.
253 (ctf_dump_objts): likewise.
254 (ctf_dump_funcs): likewise.
255 (ctf_dump_var): likewise.
256 (ctf_dump_str): Likewise.
257
87279e3c
NA
2582019-09-30 Nick Alcock <nick.alcock@oracle.com>
259
260 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
261 (LT_INIT): Likewise.
262 (AM_INSTALL_LIBBFD): Likewise.
263 (dlopen): Note why this is necessary in a comment.
264 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
265 opcodes/.
266 (SHARED_LDFLAGS): Likewise.
267 (BFD_LIBADD): Likewise, for libbfd.
268 (BFD_DEPENDENCIES): Likewise.
269 (VERSION_FLAGS): Initialize, using a version script if ld supports
270 one, or libtool -export-symbols-regex otherwise.
271 (AC_CONFIG_MACRO_DIR): Add ../BFD.
272 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
273 (INCDIR): New.
274 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
275 (noinst_LIBRARIES): Replace with...
276 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
277 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
278 libctf-nobfd.la as well.
279 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
280 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
281 (libctf_a_SOURCES): Rename to...
282 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
283 ctf-open-bfd.c.
284 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
285 with ctf-open-bfd.c added.
286 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
287 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
288 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
289 * Makefile.am [INSTALL_LIBCTF]: Use it.
290 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
291 libtool macros.
292 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
293 the unstable components).
294 * Makefile.in: Regenerated.
295 * config.h.in: Likewise.
296 * configure: Likewise.
297
2982019-07-30 Nick Alcock <nick.alcock@oracle.com>
299
300 * configure.ac (INSTALL_LIBCTF): New, controlled by
301 --enable-install-libctf.
302 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
303 * Makefile.in: Regenerated.
304 * configure: Regenerated.
305
f046147d
NA
3062019-07-30 Nick Alcock <nick.alcock@oracle.com>
307
308 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
309 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
310
edc8bbe9
NA
3112019-07-30 Nick Alcock <nick.alcock@oracle.com>
312
313 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
314
7e97445a
NA
3152019-07-13 Nick Alcock <nick.alcock@oracle.com>
316
317 * ctf-impl.h (includes): Include <sys/param.h> here.
318
5ae6af75
NA
3192019-07-30 Nick Alcock <nick.alcock@oracle.com>
320
321 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
322 (flip_objts): Likewise.
323 (flip_vars): Likewise.
324 (flip_types): Likewise.
325
1820745a
NA
3262019-07-30 Nick Alcock <nick.alcock@oracle.com>
327
328 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
329 freeing functions: if set, free the key and value if the slot
330 already exists. Always reassign the key.
331 (ctf_dynhash_insert): Adjust call appropriately.
332 (ctf_hash_insert_type): Likewise.
333
5de9eada
NA
3342019-08-03 Nick Alcock <nick.alcock@oracle.com>
335
336 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
337 type kind. Allow forwards to unify with pre-existing structs/
338 unions/enums.
339
49ea9b45
NA
3402019-07-30 Nick Alcock <nick.alcock@oracle.com>
341
342 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
343 <ctf_link_memb_name_changer>: Likewise.
344 <ctf_link_memb_name_changer_arg>: Likewise.
345 * ctf-create.c (ctf_update): Update accordingly.
346 * ctf-open.c (ctf_file_close): Likewise.
347 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
348 (ctf_link_add_cu_mapping): New.
349 (ctf_link_set_memb_name_changer): Likewise.
350 (ctf_change_parent_name): New.
351 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
352 allocated by the caller's ctf_link_memb_name_changer.
353 <ndynames>: Likewise.
354 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
355 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
356 ctf_change_parent_name. Free any resulting names.
357
eabb7154
NA
3582019-07-13 Nick Alcock <nick.alcock@oracle.com>
359
360 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
361 (ctf_link_one_type): ... here, with parent-name setting added.
362 (check_variable): New.
363 (ctf_link_one_variable): Likewise.
364 (ctf_link_one_input_archive_member): Call it.
365 * ctf-error.c (_ctf_errlist): Updated with new errors.
366
886453cb
NA
3672019-07-13 Nick Alcock <nick.alcock@oracle.com>
368
369 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
370 (struct ctf_link_type_mapping_key): New.
371 (ctf_hash_type_mapping_key): Likewise.
372 (ctf_hash_eq_type_mapping_key): Likewise.
373 (ctf_add_type_mapping): Likewise.
374 (ctf_type_mapping): Likewise.
375 (ctf_dynhash_empty): Likewise.
376 * ctf-open.c (ctf_file_close): Update accordingly.
377 * ctf-create.c (ctf_update): Likewise.
378 (ctf_add_type): Populate the mapping.
379 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
380 (ctf_hash_eq_type_mapping_key): Check the key for equality.
381 (ctf_dynhash_insert): Fix comment typo.
382 (ctf_dynhash_empty): New.
383 * ctf-link.c (ctf_add_type_mapping): New.
384 (ctf_type_mapping): Likewise.
385 (empty_link_type_mapping): New.
386 (ctf_link_one_input_archive): Call it.
387
72c83edd
NA
3882019-07-13 Nick Alcock <nick.alcock@oracle.com>
389
390 * ctf-link.c: New file, linking of the string and type sections.
391 * Makefile.am (libctf_a_SOURCES): Add it.
392 * Makefile.in: Regenerate.
393
394 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
395 ctf_link_outputs.
396 * ctf-create.c (ctf_update): Update accordingly.
397 * ctf-open.c (ctf_file_close): Likewise.
398 * ctf-error.c (_ctf_errlist): Updated with new errors.
399
d18f9f16
NA
4002019-07-13 Nick Alcock <nick.alcock@oracle.com>
401
402 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
403
b4f0e09c
NA
4042019-07-13 Nick Alcock <nick.alcock@oracle.com>
405
406 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
407 ctf_type_iter.
408 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
409 (ctf_dump_format_type): Add non-root-type { } notation.
410 Add root flag to prototype.
411 (ctf_dump_label): Adjust accordingly.
412 (ctf_dump_objts): Likewise.
413 (ctf_dump_var): Likewise.
414
3dde2c91
NA
4152019-07-13 Nick Alcock <nick.alcock@oracle.com>
416
417 * ctf-create.c (ctf_compress_write): Fix double-free.
418
5537f9b9
NA
4192019-07-13 Nick Alcock <nick.alcock@oracle.com>
420
421 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
422 of...
423 (ctf_arc_write_fd): ... this new function.
424 * ctf-create.c (ctf_write_mem): New.
425
d851ecd3
NA
4262019-07-13 Nick Alcock <nick.alcock@oracle.com>
427
428 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
429 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
430 (ctf_str_add_ref): Name the last arg.
431 (ctf_str_add_external) New.
432 (ctf_str_add_strraw_explicit): Likewise.
433 (ctf_simple_open_internal): Likewise.
434 (ctf_bufopen_internal): Likewise.
435
436 * ctf-string.c (ctf_strraw_explicit): Split from...
437 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
438 (ctf_str_add_ref_internal): Return the atom, not the
439 string.
440 (ctf_str_add): Adjust accordingly.
441 (ctf_str_add_ref): Likewise. Move up in the file.
442 (ctf_str_add_external): New: update the csa_offset.
443 (ctf_str_count_strtab): Only account for strings with no csa_offset
444 in the internal strtab length.
445 (ctf_str_write_strtab): If the csa_offset is set, update the
446 string's refs without writing the string out, and update the
447 ctf_syn_ext_strtab. Make OOM handling less ugly.
448 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
449 (ctf_update): Handle failure to populate the strtab. Pass in the
450 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
451 Call ctf_simple_open_internal, not ctf_simple_open.
452 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
453 strings by hand.
454 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
455 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
456 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
457 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
458 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
459 (ctf_simple_open_internal): ... this new function, which calls
460 ctf_bufopen_internal.
461 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
462 (ctf_bufopen_internal): ... this new function, which sets
463 ctf_syn_ext_strtab.
464
0ac62312
NA
4652019-07-13 Nick Alcock <nick.alcock@oracle.com>
466
467 * ctf_types.c (ctf_type_iter_all): New.
468
2db912ba
NA
4692019-07-13 Nick Alcock <nick.alcock@oracle.com>
470
471 * ctf-open.c (init_symtab): Check for overflow against the right
472 section.
473 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
474 (upgrade_types_v1): Note that these sections are not checked.
475 (flip_header): Endian-swap the header fields.
476 (flip_ctf): Endian-swap the sections.
477 (flip_objts): Update comment.
478 (ctf_bufopen): Check header offsets and alignment for validity.
479
6d5944fc
NA
4802019-07-13 Nick Alcock <nick.alcock@oracle.com>
481
482 * ctf-open-bfd.c: Add <assert.h>.
483 (ctf_bfdopen_ctfsect): Open string and symbol tables using
484 techniques borrowed from bfd_elf_sym_name.
485 (ctf_new_archive_internal): Improve comment.
486 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
487 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
488 no symbol section, but not vice versa.
489
9b32cba4
NA
4902019-07-08 Nick Alcock <nick.alcock@oracle.com>
491
492 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
493 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
494 * ctf-dump.c (dump_header): New function, dump the CTF header.
495 (ctf_dump): Call it.
496 (ctf_dump_header_strfield): New function.
497 (ctf_dump_header_sectfield): Likewise.
498
fd55eae8
NA
4992019-07-06 Nick Alcock <nick.alcock@oracle.com>
500
501 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
502 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
503 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
504 ctf_base: do not assume that it is always sizeof (ctf_header_t).
505 Print out ctf_cuname: only print out ctf_parname if set.
506 (ctf_free_base): Removed, ctf_base is no longer freed: free
507 ctf_dynbase instead.
508 (ctf_set_version): Fix spacing.
509 (upgrade_header): New, in-place header upgrading.
510 (upgrade_types): Rename to...
511 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
512 longer track old and new headers separately. No longer allow for
513 header sizes explicitly: squeeze the headers out on upgrade (they
514 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
515 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
516 (upgrade_types): New, also handle ctf_parmax updating.
517 (flip_header): Flip ctf_cuname.
518 (flip_types): Flip BUF explicitly rather than deriving BUF from
519 BASE.
520 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
521 required alignment of objtoff and funcoff. No longer store it in
522 the ctf_buf unless that buf is derived unmodified from the input.
523 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
524 that duplicate fields in ctf_file: move allocation of ctf_file
525 further up instead. Call upgrade_header as needed. Move
526 version-specific ctf_parmax initialization into upgrade_types. More
527 concise error handling.
528 (ctf_file_close): No longer test for null pointers before freeing.
529 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
530 ctf_free_base.
531 (ctf_cuname): New.
532 (ctf_cuname_set): New.
533 * ctf-create.c (ctf_update): Populate ctf_cuname.
534 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
535 comment.
536 (ctf_write): Likewise.
537 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
538 Fix the compression length: fp->ctf_size never counted the CTF
539 header. Simplify the compress call accordingly.
540
a2230b5e
HPN
5412019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
542
543 * ctf-endian.h: Don't assume htole64 and le64toh are always
544 present if HAVE_ENDIAN_H; also check if htole64 is defined.
545 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
546 not bswap_identity_64.
547
fd361982
AM
5482019-09-18 Alan Modra <amodra@gmail.com>
549
550 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
551
60391a25
PB
5522019-09-09 Phil Blundell <pb@pbcl.net>
553
554 binutils 2.33 branch created.
555
12a0b67d
NA
5562019-07-18 Nick Alcock <nick.alcock@oracle.com>
557
558 * ctf-types.c (ctf_type_aname_raw): New.
559 (ctf_func_type_info): Likewise.
560 (ctf_func_type_args): Likewise.
561 * ctf-error.c (_ctf_errlist): Fix description.
562 * ctf-lookup.c: Fix file description.
563
083114f8 5642019-06-28 Nick Alcock <nick.alcock@oracle.com>
f57cf0e3
NA
565
566 * ctf-create.c (ctf_create): Fix off-by-one error.
567
083114f8 5682019-06-28 Nick Alcock <nick.alcock@oracle.com>
f5e9c9bd
NA
569
570 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
571 struct ctf_strs.
572 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
573 (struct ctf_str_atom): New, disambiguated single string.
574 (struct ctf_str_atom_ref): New, points to some other location that
575 references this string's offset.
576 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
577 Remove member ctf_dtvstrlen: we no longer track the total strlen
578 as we add strings.
579 (ctf_str_create_atoms): Declare new function in ctf-string.c.
580 (ctf_str_free_atoms): Likewise.
581 (ctf_str_add): Likewise.
582 (ctf_str_add_ref): Likewise.
583 (ctf_str_rollback): Likewise.
584 (ctf_str_purge_refs): Likewise.
585 (ctf_str_write_strtab): Likewise.
586 (ctf_realloc): Declare new function in ctf-util.c.
587
588 * ctf-open.c (ctf_bufopen): Create the atoms table.
589 (ctf_file_close): Destroy it.
590 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
591 special-case the position of the parname string. Construct the
592 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
593 rest of each buffer element is constructed, not via open-coding:
594 realloc the CTF buffer and append the strtab to it. No longer
595 maintain ctf_dtvstrlen. Sort the variable entry table later, after
596 strtab construction.
597 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
598 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
599 after buffer element construction instead.
600 (ctf_copy_lmembers): Likewise.
601 (ctf_copy_emembers): Likewise.
602 (ctf_create): No longer maintain the ctf_dtvstrlen.
603 (ctf_dtd_delete): Likewise.
604 (ctf_dvd_delete): Likewise.
605 (ctf_add_generic): Likewise.
606 (ctf_add_enumerator): Likewise.
607 (ctf_add_member_offset): Likewise.
608 (ctf_add_variable): Likewise.
609 (membadd): Likewise.
610 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
611 if there are active ctf_str_num_refs.
612 (ctf_strraw): Move to ctf-string.c.
613 (ctf_strptr): Likewise.
614 * ctf-string.c: New file, strtab manipulation.
615
616 * Makefile.am (libctf_a_SOURCES): Add it.
617 * Makefile.in: Regenerate.
618
083114f8 6192019-06-28 Nick Alcock <nick.alcock@oracle.com>
9658dc39
NA
620
621 * ctf-impl.h (ctf_hash_iter_f): New.
622 (ctf_dynhash_iter): New declaration.
623 (ctf_dynhash_iter_remove): New declaration.
624 * ctf-hash.c (ctf_dynhash_iter): Define.
625 (ctf_dynhash_iter_remove): Likewise.
626 (ctf_hashtab_traverse): New.
627 (ctf_hashtab_traverse_remove): Likewise.
628 (struct ctf_traverse_cb_arg): Likewise.
629 (struct ctf_traverse_remove_cb_arg): Likewise.
630
083114f8 6312019-06-28 Nick Alcock <nick.alcock@oracle.com>
3e10cffc
NA
632
633 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
634
083114f8 6352019-06-28 Nick Alcock <nick.alcock@oracle.com>
c550e7ba
NA
636
637 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
638 (ctf_dump_funcs): Likewise.
639
083114f8 6402019-06-19 Nick Alcock <nick.alcock@oracle.com>
cf02c44d
NA
641
642 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
643 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
644 little-endian CTF archive magic. Do not check the CTF version:
645 ctf_simple_open does that in endian-safe ways. Do not dereference
646 null pointers on open failure.
647
083114f8 6482019-06-19 Nick Alcock <nick.alcock@oracle.com>
7cee1826
NA
649
650 * ctf-open.c (get_vbytes_common): Return the new slice size.
651 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
652 Remember to copy in the CTF data when opening an uncompressed
653 foreign-endian CTF file. Prune useless variable manipulation.
654
083114f8 6552019-06-19 Nick Alcock <nick.alcock@oracle.com>
0b4fa56e
NA
656
657 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
658 seen.
659
083114f8 6602019-06-19 Nick Alcock <nick.alcock@oracle.com>
364620bf
NA
661
662 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
663 output.
664
083114f8 6652019-06-19 Nick Alcock <nick.alcock@oracle.com>
65365aa8
NA
666
667 * ctf-subr.c (_PAGESIZE): Remove.
668 (ctf_data_alloc): Likewise.
669 (ctf_data_free): Likewise.
670 (ctf_data_protect): Likewise.
671 * ctf-impl.h: Remove declarations.
672 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
673 ctf_free, not ctf_data_free.
674 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
675 the buffer again on compression error.
676 * ctf-open.c (ctf_set_base): No longer track the size: call
677 ctf_free, not ctf_data_free.
678 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
679 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
680
083114f8 6812019-06-19 Nick Alcock <nick.alcock@oracle.com>
24865428
NA
682
683 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
684 ctf_dynhash_insert.
685 (ctf_dvd_insert): Likewise.
686 (ctf_add_generic): Likewise.
687 (ctf_add_variable): Likewise.
688 * ctf-impl.h: Adjust declarations.
689
3a3a077c
AM
6902019-06-14 Alan Modra <amodra@gmail.com>
691
692 * configure: Regenerate.
693
942d35f7
NA
6942019-06-06 Nick Alcock <nick.alcock@oracle.com>
695
696 * ctf-decls.h: Include <libiberty.h>.
697 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
698
595a4d43
NA
6992019-06-06 Nick Alcock <nick.alcock@oracle.com>
700
701 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
702 (ctf_dump_objts): Likewise.
703 (ctf_dump_funcs): Likewise.
704 (ctf_dump_member): Likewise.
705 (ctf_dump_str): Likewise.
706
f5e73be1
NA
7072019-06-06 Nick Alcock <nick.alcock@oracle.com>
708
709 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
710 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
711
62d8e3b7
NA
7122019-06-05 Nick Alcock <nick.alcock@oracle.com>
713
714 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
715 (ctf_arc_open_by_offset): Likewise.
716 * ctf-create.c (ctf_add_type): Likewise.
717
76fad999
TT
7182019-06-04 Tom Tromey <tromey@adacore.com>
719
720 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
721 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
722
ad118caa
NA
7232019-06-04 Nick Alcock <nick.alcock@oracle.com>
724
725 * configure.ac: Check for O_CLOEXEC.
726 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
727 * config.h.in: Regenerate.
728 * configure: Likewise.
729
6b22174f
NA
7302019-06-04 Nick Alcock <nick.alcock@oracle.com>
731
732 * qsort_r.c: Rename to...
733 * ctf-qsort_r.c: ... this.
734 (_quicksort): Define to ctf_qsort_r.
735 * ctf-decls.h (qsort_r): Remove.
736 (ctf_qsort_r): Add.
737 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
738 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
739 * Makefile.am (libctf_a_LIBADD): Remove.
740 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
741 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
742 * ctf-create.c (ctf_update): Likewise.
743 * configure.ac: Check for BSD versus GNU qsort_r signature.
744 * Makefile.in: Regenerate.
745 * config.h.in: Likewise.
746 * configure: Likewise.
747
941accce
NA
7482019-06-03 Nick Alcock <nick.alcock@oracle.com>
749
750 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
751
a0486bac
JM
7522019-05-29 Nick Alcock <nick.alcock@oracle.com>
753
754 * Makefile.am (ZLIB): New.
755 (ZLIBINC): Likewise.
756 (AM_CFLAGS): Use them.
757 (libctf_a_LIBADD): New, for LIBOBJS.
758 * configure.ac: Check for zlib, endian.h, and qsort_r.
759 * ctf-endian.h: New, providing htole64 and le64toh.
760 * swap.h: Code style fixes.
761 (bswap_identity_64): New.
762 * qsort_r.c: New, from gnulib (with one added #include).
763 * ctf-decls.h: New, providing a conditional qsort_r declaration,
764 and unconditional definitions of MIN and MAX.
765 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
766 (ctf_set_errno): Now returns unsigned long.
767 * ctf-util.c (ctf_set_errno): Adjust here too.
768 * ctf-archive.c: Use ctf-endian.h.
769 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
770 cts_flags and cts_offset.
771 (ctf_arc_write): Drop debugging dependent on the size of off_t.
772 * ctf-create.c: Provide a definition of roundup if not defined.
773 (ctf_create): Drop cts_type, cts_flags and cts_offset.
774 (ctf_add_reftype): Do not check if type IDs are below zero.
775 (ctf_add_slice): Likewise.
776 (ctf_add_typedef): Likewise.
777 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
778 when known error-free. Drop CTF_ERR usage for functions returning
779 int.
780 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
781 int.
782 (ctf_add_variable): Likewise.
783 (enumcmp): Likewise.
784 (enumadd): Likewise.
785 (membcmp): Likewise.
786 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
787 when known error-free.
788 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
789 returning int: use CTF_ERR for functions returning ctf_type_id.
790 (ctf_dump_label): Likewise.
791 (ctf_dump_objts): Likewise.
792 * ctf-labels.c (ctf_label_topmost): Likewise.
793 (ctf_label_iter): Likewise.
794 (ctf_label_info): Likewise.
795 * ctf-lookup.c (ctf_func_args): Likewise.
796 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
797 (ctf_bufopen): Likewise. Use zlib types as needed.
798 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
799 returning int.
800 (ctf_enum_iter): Likewise.
801 (ctf_type_size): Likewise.
802 (ctf_type_align): Likewise. Cast to size_t where appropriate.
803 (ctf_type_kind_unsliced): Likewise.
804 (ctf_type_kind): Likewise.
805 (ctf_type_encoding): Likewise.
806 (ctf_member_info): Likewise.
807 (ctf_array_info): Likewise.
808 (ctf_enum_value): Likewise.
809 (ctf_type_rvisit): Likewise.
810 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
811 cts_offset.
812 (ctf_simple_open): Likewise.
813 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
814 * Makefile.in: Regenerate.
815 * aclocal.m4: Likewise.
816 * config.h: Likewise.
817 * configure: Likewise.
818
9698cf9b
NA
8192019-05-28 Nick Alcock <nick.alcock@oracle.com>
820
821 * configure.in: Check for bfd_section_from_elf_index.
822 * configure: Regenerate.
823 * config.h.in [HAVE_BFD_ELF]: Likewise.
824 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
825 abfd is potentially unused now.
826
0e65dfba
NA
8272019-05-28 Nick Alcock <nick.alcock@oracle.com>
828
829 * Makefile.am: New.
830 * Makefile.in: Regenerated.
831 * config.h.in: Likewise.
832 * aclocal.m4: Likewise.
833 * configure: Likewise.
834
a30b3e18
NA
8352019-05-28 Nick Alcock <nick.alcock@oracle.com>
836
837 * ctf-dump.c: New.
838
6dbf2b73
NA
8392019-05-28 Nick Alcock <nick.alcock@oracle.com>
840
841 * ctf-labels.c: New.
842
6c33b742
NA
8432019-05-28 Nick Alcock <nick.alcock@oracle.com>
844
845 * ctf-impl.h (_libctf_version): New declaration.
846 * ctf-subr.c (_libctf_version): Define it.
847 (ctf_version): New.
848
c499eb68
NA
8492019-05-28 Nick Alcock <nick.alcock@oracle.com>
850
851 * ctf-create.c (enumcmp): New.
852 (enumadd): Likewise.
853 (membcmp): Likewise.
854 (membadd): Likewise.
855 (ctf_add_type): Likewise.
856
b437bfe0
NA
8572019-05-28 Nick Alcock <nick.alcock@oracle.com>
858
859 * ctf-lookup.c (isqualifier): New.
860 (ctf_lookup_by_name): Likewise.
861 (struct ctf_lookup_var_key): Likewise.
862 (ctf_lookup_var): Likewise.
863 (ctf_lookup_variable): Likewise.
864 (ctf_lookup_symbol_name): Likewise.
865 (ctf_lookup_by_symbol): Likewise.
866 (ctf_func_info): Likewise.
867 (ctf_func_args): Likewise.
868
316afdb1
NA
8692019-05-28 Nick Alcock <nick.alcock@oracle.com>
870
871 * ctf-decl.c: New file.
872 * ctf-types.c: Likewise.
873 * ctf-impl.h: New declarations.
874
143dce84
NA
8752019-05-28 Nick Alcock <nick.alcock@oracle.com>
876
877 * ctf-open-bfd.c: New file.
878 * ctf-open.c (ctf_close): New.
879 * ctf-impl.h: Include bfd.h.
880 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
881 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
882 ctfi_bfd_close.
883 (ctf_bfdopen_ctfsect): New declaration.
884 (_CTF_SECTION): likewise.
885
9402cc59
NA
8862019-05-28 Nick Alcock <nick.alcock@oracle.com>
887
888 * ctf-archive.c: New.
889 * ctf-impl.h (ctf_archive_internal): New type.
890 (ctf_arc_open_internal): New declaration.
891 (ctf_arc_bufopen): Likewise.
892 (ctf_arc_close_internal): Likewise.
893
72f33921
NA
8942019-05-28 Nick Alcock <nick.alcock@oracle.com>
895
896 * ctf-open.c: New file.
897 * swap.h: Likewise.
898
47d546f4
NA
8992019-05-28 Nick Alcock <nick.alcock@oracle.com>
900
901 * ctf-create.c: New file.
902 * ctf-lookup.c: New file.
903
a5be9bbe
NA
9042019-05-28 Nick Alcock <nick.alcock@oracle.com>
905
906 * ctf-impl.h: New definitions and declarations for type creation
907 and lookup.
908
c0754cdd
NA
9092019-05-28 Nick Alcock <nick.alcock@oracle.com>
910
911 * ctf-hash.c: New file.
912 * ctf-impl.h: New declarations.
913
479604f4
NA
9142019-05-28 Nick Alcock <nick.alcock@oracle.com>
915
916 * ctf-error.c: New file.
917
94585e7f
NA
9182019-05-28 Nick Alcock <nick.alcock@oracle.com>
919
920 * ctf-util.c: New file.
921 * elf.h: Likewise.
922 * ctf-impl.h: Include it, and add declarations.
923
60da9d95
NA
9242019-05-28 Nick Alcock <nick.alcock@oracle.com>
925
926 * ctf-impl.h: New file.
927 * ctf-subr.c: New file.
928
929\f
930Local Variables:
931mode: change-log
932left-margin: 8
933fill-column: 76
934version-control: never
935End:
This page took 0.079681 seconds and 4 git commands to generate.