[deliverable/linux.git] / net / bridge / br_sysfs_if.c

/*
 *	Sysfs attributes of bridge ports
 *	Linux ethernet bridge
 *
 *	Authors:
 *	Stephen Hemminger		<shemminger@osdl.org>
 *
 *	This program is free software; you can redistribute it and/or
 *	modify it under the terms of the GNU General Public License
 *	as published by the Free Software Foundation; either version
 *	2 of the License, or (at your option) any later version.
 */

#include <linux/capability.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
#include <linux/if_bridge.h>
#include <linux/rtnetlink.h>
#include <linux/spinlock.h>

#include "br_private.h"

struct brport_attribute {
	struct attribute	attr;
	ssize_t (*show)(struct net_bridge_port *, char *);
	int (*store)(struct net_bridge_port *, unsigned long);
};

#define BRPORT_ATTR(_name, _mode, _show, _store)		\
const struct brport_attribute brport_attr_##_name = { 	        \
	.attr = {.name = __stringify(_name), 			\
		 .mode = _mode },				\
	.show	= _show,					\
	.store	= _store,					\
};

#define BRPORT_ATTR_FLAG(_name, _mask)				\
static ssize_t show_##_name(struct net_bridge_port *p, char *buf) \
{								\
	return sprintf(buf, "%d\n", !!(p->flags & _mask));	\
}								\
static int store_##_name(struct net_bridge_port *p, unsigned long v) \
{								\
	return store_flag(p, v, _mask);				\
}								\
static BRPORT_ATTR(_name, S_IRUGO | S_IWUSR,			\
		   show_##_name, store_##_name)

static int store_flag(struct net_bridge_port *p, unsigned long v,
		      unsigned long mask)
{
	unsigned long flags;

	flags = p->flags;

	if (v)
		flags |= mask;
	else
		flags &= ~mask;

	if (flags != p->flags) {
		p->flags = flags;
		br_port_flags_change(p, mask);
	}
	return 0;
}

static ssize_t show_path_cost(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->path_cost);
}

static BRPORT_ATTR(path_cost, S_IRUGO | S_IWUSR,
		   show_path_cost, br_stp_set_path_cost);

static ssize_t show_priority(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->priority);
}

static BRPORT_ATTR(priority, S_IRUGO | S_IWUSR,
			 show_priority, br_stp_set_port_priority);

static ssize_t show_designated_root(struct net_bridge_port *p, char *buf)
{
	return br_show_bridge_id(buf, &p->designated_root);
}
static BRPORT_ATTR(designated_root, S_IRUGO, show_designated_root, NULL);

static ssize_t show_designated_bridge(struct net_bridge_port *p, char *buf)
{
	return br_show_bridge_id(buf, &p->designated_bridge);
}
static BRPORT_ATTR(designated_bridge, S_IRUGO, show_designated_bridge, NULL);

static ssize_t show_designated_port(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->designated_port);
}
static BRPORT_ATTR(designated_port, S_IRUGO, show_designated_port, NULL);

static ssize_t show_designated_cost(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->designated_cost);
}
static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL);

static ssize_t show_port_id(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "0x%x\n", p->port_id);
}
static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL);

static ssize_t show_port_no(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "0x%x\n", p->port_no);
}

static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL);

static ssize_t show_change_ack(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->topology_change_ack);
}
static BRPORT_ATTR(change_ack, S_IRUGO, show_change_ack, NULL);

static ssize_t show_config_pending(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->config_pending);
}
static BRPORT_ATTR(config_pending, S_IRUGO, show_config_pending, NULL);

static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->state);
}
static BRPORT_ATTR(state, S_IRUGO, show_port_state, NULL);

static ssize_t show_message_age_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
}
static BRPORT_ATTR(message_age_timer, S_IRUGO, show_message_age_timer, NULL);

static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
}
static BRPORT_ATTR(forward_delay_timer, S_IRUGO, show_forward_delay_timer, NULL);

static ssize_t show_hold_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
}
static BRPORT_ATTR(hold_timer, S_IRUGO, show_hold_timer, NULL);

static int store_flush(struct net_bridge_port *p, unsigned long v)
{
	br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
	return 0;
}
static BRPORT_ATTR(flush, S_IWUSR, NULL, store_flush);

BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
BRPORT_ATTR_FLAG(learning, BR_LEARNING);
BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);

#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
static ssize_t show_multicast_router(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->multicast_router);
}

static int store_multicast_router(struct net_bridge_port *p,
				      unsigned long v)
{
	return br_multicast_set_port_router(p, v);
}
static BRPORT_ATTR(multicast_router, S_IRUGO | S_IWUSR, show_multicast_router,
		   store_multicast_router);

BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
#endif

static const struct brport_attribute *brport_attrs[] = {
	&brport_attr_path_cost,
	&brport_attr_priority,
	&brport_attr_port_id,
	&brport_attr_port_no,
	&brport_attr_designated_root,
	&brport_attr_designated_bridge,
	&brport_attr_designated_port,
	&brport_attr_designated_cost,
	&brport_attr_state,
	&brport_attr_change_ack,
	&brport_attr_config_pending,
	&brport_attr_message_age_timer,
	&brport_attr_forward_delay_timer,
	&brport_attr_hold_timer,
	&brport_attr_flush,
	&brport_attr_hairpin_mode,
	&brport_attr_bpdu_guard,
	&brport_attr_root_block,
	&brport_attr_learning,
	&brport_attr_unicast_flood,
#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
	&brport_attr_multicast_router,
	&brport_attr_multicast_fast_leave,
#endif
	&brport_attr_proxyarp,
	&brport_attr_proxyarp_wifi,
	NULL
};

#define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
#define to_brport(obj)	container_of(obj, struct net_bridge_port, kobj)

static ssize_t brport_show(struct kobject *kobj,
			   struct attribute *attr, char *buf)
{
	struct brport_attribute *brport_attr = to_brport_attr(attr);
	struct net_bridge_port *p = to_brport(kobj);

	return brport_attr->show(p, buf);
}

static ssize_t brport_store(struct kobject *kobj,
			    struct attribute *attr,
			    const char *buf, size_t count)
{
	struct brport_attribute *brport_attr = to_brport_attr(attr);
	struct net_bridge_port *p = to_brport(kobj);
	ssize_t ret = -EINVAL;
	char *endp;
	unsigned long val;

	if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
		return -EPERM;

	val = simple_strtoul(buf, &endp, 0);
	if (endp != buf) {
		if (!rtnl_trylock())
			return restart_syscall();
		if (p->dev && p->br && brport_attr->store) {
			spin_lock_bh(&p->br->lock);
			ret = brport_attr->store(p, val);
			spin_unlock_bh(&p->br->lock);
			if (!ret) {
				br_ifinfo_notify(RTM_NEWLINK, p);
				ret = count;
			}
		}
		rtnl_unlock();
	}
	return ret;
}

const struct sysfs_ops brport_sysfs_ops = {
	.show = brport_show,
	.store = brport_store,
};

/*
 * Add sysfs entries to ethernet device added to a bridge.
 * Creates a brport subdirectory with bridge attributes.
 * Puts symlink in bridge's brif subdirectory
 */
int br_sysfs_addif(struct net_bridge_port *p)
{
	struct net_bridge *br = p->br;
	const struct brport_attribute **a;
	int err;

	err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
				SYSFS_BRIDGE_PORT_LINK);
	if (err)
		return err;

	for (a = brport_attrs; *a; ++a) {
		err = sysfs_create_file(&p->kobj, &((*a)->attr));
		if (err)
			return err;
	}

	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
}

/* Rename bridge's brif symlink */
int br_sysfs_renameif(struct net_bridge_port *p)
{
	struct net_bridge *br = p->br;
	int err;

	/* If a rename fails, the rollback will cause another
	 * rename call with the existing name.
	 */
	if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
		return 0;

	err = sysfs_rename_link(br->ifobj, &p->kobj,
				p->sysfs_name, p->dev->name);
	if (err)
		netdev_notice(br->dev, "unable to rename link %s to %s",
			      p->sysfs_name, p->dev->name);
	else
		strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);

	return err;
}
Commit	Line	Data
1da177e4 LT	1	/*
	2	* Sysfs attributes of bridge ports
	3	* Linux ethernet bridge
	4	*
	5	* Authors:
	6	* Stephen Hemminger <shemminger@osdl.org>
	7	*
	8	* This program is free software; you can redistribute it and/or
	9	* modify it under the terms of the GNU General Public License
	10	* as published by the Free Software Foundation; either version
	11	* 2 of the License, or (at your option) any later version.
	12	*/
	13
4fc268d2	14	#include <linux/capability.h>
1da177e4 LT	15	#include <linux/kernel.h>
	16	#include <linux/netdevice.h>
	17	#include <linux/if_bridge.h>
	18	#include <linux/rtnetlink.h>
	19	#include <linux/spinlock.h>
	20
	21	#include "br_private.h"
	22
	23	struct brport_attribute {
	24	struct attribute attr;
	25	ssize_t (show)(struct net_bridge_port , char *);
14f98f25	26	int (store)(struct net_bridge_port , unsigned long);
1da177e4 LT	27	};
1da177e4 LT	28
31a5b837	29	#define BRPORT_ATTR(_name, _mode, _show, _store) \
5a0d513b	30	const struct brport_attribute brport_attr_##_name = { \
1da177e4	31	.attr = {.name = __stringify(_name), \
7b595756	32	.mode = _mode }, \
1da177e4 LT	33	.show = _show, \
	34	.store = _store, \
	35	};
	36
cd753732	37	#define BRPORT_ATTR_FLAG(_name, _mask) \
	38	static ssize_t show_##_name(struct net_bridge_port p, char buf) \
	39	{ \
	40	return sprintf(buf, "%d\n", !!(p->flags & _mask)); \
	41	} \
	42	static int store_##_name(struct net_bridge_port *p, unsigned long v) \
	43	{ \
63c3a622	44	return store_flag(p, v, _mask); \
cd753732	45	} \
	46	static BRPORT_ATTR(_name, S_IRUGO \| S_IWUSR, \
	47	show_##_name, store_##_name)
	48
63c3a622 VY	49	static int store_flag(struct net_bridge_port *p, unsigned long v,
	50	unsigned long mask)
	51	{
e028e4b8 VY	52	unsigned long flags;
	53
	54	flags = p->flags;
63c3a622 VY	55
	56	if (v)
	57	flags \|= mask;
	58	else
	59	flags &= ~mask;
	60
	61	if (flags != p->flags) {
	62	p->flags = flags;
e028e4b8	63	br_port_flags_change(p, mask);
63c3a622 VY	64	}
	65	return 0;
	66	}
cd753732	67
1da177e4 LT	68	static ssize_t show_path_cost(struct net_bridge_port p, char buf)
	69	{
	70	return sprintf(buf, "%d\n", p->path_cost);
	71	}
14f98f25	72
1da177e4	73	static BRPORT_ATTR(path_cost, S_IRUGO \| S_IWUSR,
14f98f25	74	show_path_cost, br_stp_set_path_cost);
1da177e4 LT	75
	76	static ssize_t show_priority(struct net_bridge_port p, char buf)
	77	{
	78	return sprintf(buf, "%d\n", p->priority);
	79	}
14f98f25	80
1da177e4	81	static BRPORT_ATTR(priority, S_IRUGO \| S_IWUSR,
14f98f25	82	show_priority, br_stp_set_port_priority);
1da177e4 LT	83
	84	static ssize_t show_designated_root(struct net_bridge_port p, char buf)
	85	{
	86	return br_show_bridge_id(buf, &p->designated_root);
	87	}
	88	static BRPORT_ATTR(designated_root, S_IRUGO, show_designated_root, NULL);
	89
	90	static ssize_t show_designated_bridge(struct net_bridge_port p, char buf)
	91	{
	92	return br_show_bridge_id(buf, &p->designated_bridge);
	93	}
	94	static BRPORT_ATTR(designated_bridge, S_IRUGO, show_designated_bridge, NULL);
	95
	96	static ssize_t show_designated_port(struct net_bridge_port p, char buf)
	97	{
	98	return sprintf(buf, "%d\n", p->designated_port);
	99	}
	100	static BRPORT_ATTR(designated_port, S_IRUGO, show_designated_port, NULL);
	101
	102	static ssize_t show_designated_cost(struct net_bridge_port p, char buf)
	103	{
	104	return sprintf(buf, "%d\n", p->designated_cost);
	105	}
	106	static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL);
	107
	108	static ssize_t show_port_id(struct net_bridge_port p, char buf)
	109	{
	110	return sprintf(buf, "0x%x\n", p->port_id);
	111	}
	112	static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL);
	113
	114	static ssize_t show_port_no(struct net_bridge_port p, char buf)
	115	{
	116	return sprintf(buf, "0x%x\n", p->port_no);
	117	}
	118
	119	static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL);
	120
	121	static ssize_t show_change_ack(struct net_bridge_port p, char buf)
	122	{
	123	return sprintf(buf, "%d\n", p->topology_change_ack);
	124	}
	125	static BRPORT_ATTR(change_ack, S_IRUGO, show_change_ack, NULL);
	126
	127	static ssize_t show_config_pending(struct net_bridge_port p, char buf)
	128	{
	129	return sprintf(buf, "%d\n", p->config_pending);
	130	}
	131	static BRPORT_ATTR(config_pending, S_IRUGO, show_config_pending, NULL);
	132
	133	static ssize_t show_port_state(struct net_bridge_port p, char buf)
	134	{
	135	return sprintf(buf, "%d\n", p->state);
	136	}
	137	static BRPORT_ATTR(state, S_IRUGO, show_port_state, NULL);
	138
	139	static ssize_t show_message_age_timer(struct net_bridge_port *p,
	140	char *buf)
	141	{
	142	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
	143	}
	144	static BRPORT_ATTR(message_age_timer, S_IRUGO, show_message_age_timer, NULL);
	145
	146	static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
147	char *buf)
148	{
149	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
150	}
151	static BRPORT_ATTR(forward_delay_timer, S_IRUGO, show_forward_delay_timer, NULL);
152
153	static ssize_t show_hold_timer(struct net_bridge_port *p,
154	char *buf)
155	{
156	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
157	}
158	static BRPORT_ATTR(hold_timer, S_IRUGO, show_hold_timer, NULL);
159
14f98f25	160	static int store_flush(struct net_bridge_port *p, unsigned long v)
9cf63747	161	{
1ea2d020	162	br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
9cf63747 SH	163	return 0;
	164	}
	165	static BRPORT_ATTR(flush, S_IWUSR, NULL, store_flush);
	166
cd753732	167	BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
a2e01a65	168	BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
1007dd1a	169	BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
9ba18891	170	BRPORT_ATTR_FLAG(learning, BR_LEARNING);
867a5943	171	BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
95850116	172	BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
842a9ae0	173	BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);
3982d3d2	174
0909e117 HX	175	#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
	176	static ssize_t show_multicast_router(struct net_bridge_port p, char buf)
	177	{
	178	return sprintf(buf, "%d\n", p->multicast_router);
	179	}
	180
14f98f25	181	static int store_multicast_router(struct net_bridge_port *p,
0909e117 HX	182	unsigned long v)
	183	{
	184	return br_multicast_set_port_router(p, v);
	185	}
	186	static BRPORT_ATTR(multicast_router, S_IRUGO \| S_IWUSR, show_multicast_router,
	187	store_multicast_router);
50426b59	188
c2d3babf	189	BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
0909e117 HX	190	#endif
0909e117 HX	191
5a0d513b	192	static const struct brport_attribute *brport_attrs[] = {
1da177e4 LT	193	&brport_attr_path_cost,
	194	&brport_attr_priority,
	195	&brport_attr_port_id,
	196	&brport_attr_port_no,
	197	&brport_attr_designated_root,
	198	&brport_attr_designated_bridge,
	199	&brport_attr_designated_port,
	200	&brport_attr_designated_cost,
	201	&brport_attr_state,
	202	&brport_attr_change_ack,
	203	&brport_attr_config_pending,
	204	&brport_attr_message_age_timer,
	205	&brport_attr_forward_delay_timer,
	206	&brport_attr_hold_timer,
9cf63747	207	&brport_attr_flush,
3982d3d2	208	&brport_attr_hairpin_mode,
a2e01a65	209	&brport_attr_bpdu_guard,
1007dd1a	210	&brport_attr_root_block,
9ba18891	211	&brport_attr_learning,
867a5943	212	&brport_attr_unicast_flood,
0909e117 HX	213	#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
0909e117 HX	214	&brport_attr_multicast_router,
50426b59	215	&brport_attr_multicast_fast_leave,
0909e117	216	#endif
95850116	217	&brport_attr_proxyarp,
842a9ae0	218	&brport_attr_proxyarp_wifi,
1da177e4 LT	219	NULL
	220	};
	221
	222	#define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
	223	#define to_brport(obj) container_of(obj, struct net_bridge_port, kobj)
	224
56b148eb	225	static ssize_t brport_show(struct kobject *kobj,
56b148eb	226	struct attribute attr, char buf)
1da177e4	227	{
56b148eb	228	struct brport_attribute *brport_attr = to_brport_attr(attr);
56b148eb	229	struct net_bridge_port *p = to_brport(kobj);
1da177e4 LT	230
	231	return brport_attr->show(p, buf);
	232	}
	233
56b148eb	234	static ssize_t brport_store(struct kobject *kobj,
	235	struct attribute *attr,
	236	const char *buf, size_t count)
1da177e4	237	{
56b148eb	238	struct brport_attribute *brport_attr = to_brport_attr(attr);
56b148eb	239	struct net_bridge_port *p = to_brport(kobj);
1da177e4 LT	240	ssize_t ret = -EINVAL;
	241	char *endp;
	242	unsigned long val;
	243
cb990503	244	if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
1da177e4 LT	245	return -EPERM;
	246
	247	val = simple_strtoul(buf, &endp, 0);
	248	if (endp != buf) {
af38f298 EB	249	if (!rtnl_trylock())
af38f298 EB	250	return restart_syscall();
1da177e4 LT	251	if (p->dev && p->br && brport_attr->store) {
	252	spin_lock_bh(&p->br->lock);
	253	ret = brport_attr->store(p, val);
	254	spin_unlock_bh(&p->br->lock);
bdaf0d5d XL	255	if (!ret) {
bdaf0d5d XL	256	br_ifinfo_notify(RTM_NEWLINK, p);
1da177e4	257	ret = count;
bdaf0d5d	258	}
1da177e4 LT	259	}
	260	rtnl_unlock();
	261	}
	262	return ret;
	263	}
	264
52cf25d0	265	const struct sysfs_ops brport_sysfs_ops = {
1da177e4 LT	266	.show = brport_show,
	267	.store = brport_store,
	268	};
	269
1da177e4 LT	270	/*
	271	* Add sysfs entries to ethernet device added to a bridge.
	272	* Creates a brport subdirectory with bridge attributes.
e0f43752	273	* Puts symlink in bridge's brif subdirectory
1da177e4 LT	274	*/
	275	int br_sysfs_addif(struct net_bridge_port *p)
	276	{
	277	struct net_bridge *br = p->br;
5a0d513b	278	const struct brport_attribute **a;
1da177e4 LT	279	int err;
1da177e4 LT	280
43cb76d9	281	err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
1da177e4 LT	282	SYSFS_BRIDGE_PORT_LINK);
1da177e4 LT	283	if (err)
e0f43752	284	return err;
1da177e4 LT	285
	286	for (a = brport_attrs; *a; ++a) {
	287	err = sysfs_create_file(&p->kobj, &((*a)->attr));
	288	if (err)
e0f43752	289	return err;
1da177e4 LT	290	}
1da177e4 LT	291
e0f43752 SA	292	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	293	return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
	294	}
	295
	296	/* Rename bridge's brif symlink */
	297	int br_sysfs_renameif(struct net_bridge_port *p)
	298	{
	299	struct net_bridge *br = p->br;
	300	int err;
	301
	302	/* If a rename fails, the rollback will cause another
	303	* rename call with the existing name.
	304	*/
	305	if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
	306	return 0;
	307
	308	err = sysfs_rename_link(br->ifobj, &p->kobj,
	309	p->sysfs_name, p->dev->name);
	310	if (err)
	311	netdev_notice(br->dev, "unable to rename link %s to %s",
	312	p->sysfs_name, p->dev->name);
	313	else
	314	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	315
1da177e4 LT	316	return err;
1da177e4 LT	317	}