projects / deliverable / binutils-gdb.git / blame_incremental
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (non-incremental) | history | HEAD
Change TUI source window iteration
[deliverable/binutils-gdb.git] / gdb / ChangeLog
... / ...
CommitLineData
12019-08-15 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4 (struct tui_source_windows): New.
5 * tui/tui-winsource.c (tui_display_main): Update.
6 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7 (new_height_ok, parse_scrolling_args): Update.
8 * tui/tui-layout.c (show_layout, show_data): Update.
9 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
10 (tui_add_to_source_windows): Don't declare.
11 * tui/tui-data.c (source_windows, tui_source_windows)
12 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
13
142019-08-15 Tom Tromey <tom@tromey.com>
15
16 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
17 Rename from reset.
18 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
19 * tui/tui-layout.c (show_source_disasm_command, show_data):
20 Update.
21 (tui_gen_win_info::resize): Rename.
22 (show_source_or_disasm_and_command): Update.
23 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
24 reset.
25
262019-08-15 Tom Tromey <tom@tromey.com>
27
28 * tui/tui-stack.c (tui_initialize_static_data): Remove.
29 * tui/tui-interp.c (tui_interp::init): Don't call
30 tui_initialize_static_data.
31 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
32
332019-08-15 Tom Tromey <tom@tromey.com>
34
35 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
36 examine tui_win_list.
37
382019-08-15 Tom Tromey <tom@tromey.com>
39
40 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
41 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
42 tui_clear_source_content.
43 (tui_clear_source_content): Remove.
44 (tui_source_window_base::do_erase_source_content): Hoist call to
45 content.clear().
46 * tui/tui-stack.c (tui_show_frame_info): Don't call
47 tui_clear_source_content.
48
492019-08-15 Tom Tromey <tom@tromey.com>
50
51 * tui/tui-winsource.h (struct tui_source_window_base)
52 <do_erase_source_content>: New method.
53 <erase_source_content>: New method.
54 (tui_erase_source_content): Don't declare.
55 * tui/tui-winsource.c (tui_clear_source_content): Update.
56 (tui_source_window_base::do_erase_source_content): Rename from
57 tui_erase_source_content.
58 (tui_source_window_base::show_source_content): Update.
59 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
60 * tui/tui-source.h (struct tui_source_window)
61 <erase_source_content>: New method.
62 * tui/tui-disasm.h (struct tui_disasm_window)
63 <erase_source_content>: New method.
64
652019-08-15 Tom Tromey <tom@tromey.com>
66
67 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
68 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
69 constructor.
70 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
71 * tui/tui-source.c (tui_set_source_content): Update.
72 * tui/tui-disasm.c (tui_set_disassem_content): Update.
73
742019-08-15 Tom Tromey <tom@tromey.com>
75
76 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
77 * tui/tui-winsource.c (tui_line_is_displayed): Move to
78 tui-source.c.
79 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
80 Declare.
81 * tui/tui-source.c (tui_source_window::line_is_displayed): New
82 method.
83 (tui_source_window::maybe_update): Update.
84
852019-08-15 Tom Tromey <tom@tromey.com>
86
87 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
88 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
89 tui-disasm.c.
90 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
91 Declare.
92 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
93 method.
94 (tui_disasm_window::maybe_update): Update.
95
962019-08-15 Tom Tromey <tom@tromey.com>
97
98 * tui/tui-winsource.h (struct tui_source_window_base)
99 <maybe_update>: Declare.
100 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
101 method.
102 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
103 Declare.
104 * tui/tui-source.c (tui_source_window::maybe_update): New method.
105 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
106 Declare.
107 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
108
1092019-08-15 Tom Tromey <tom@tromey.com>
110
111 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
112
1132019-08-15 Tom Tromey <tom@tromey.com>
114
115 * tui/tui-wingeneral.c: Include tui-stack.h.
116 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
117 (struct tui_locator_window): Move from tui-data.h.
118 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
119 (tui_initialize_static_data): Move from tui-data.c.
120 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
121 (struct tui_locator_window): Move to tui-stack.c.
122 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
123 (tui_initialize_static_data): Move to tui-stack.c.
124
1252019-08-15 Tom Tromey <tom@tromey.com>
126
127 * tui/tui-layout.c (show_source_disasm_command)
128 (show_source_or_disasm_and_command): Use make_visible method, not
129 tui_make_window.
130 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
131 Remove.
132
1332019-08-15 Tom Tromey <tom@tromey.com>
134
135 * tui/tui-wingeneral.h (tui_make_window): Update.
136 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
137 parameter.
138 (tui_gen_win_info::make_visible): Update.
139 * tui/tui-regs.c (tui_data_window::display_registers_from):
140 Update.
141 * tui/tui-layout.c (show_source_disasm_command)
142 (show_source_or_disasm_and_command): Update.
143 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
144 (enum tui_box): Remove.
145 (struct tui_win_info) <can_box>: New method.
146 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
147 method.
148
1492019-08-15 Tom de Vries <tdevries@suse.de>
150
151 * linux-nat-trad.c: Include gdbarch.h.
152
1532019-08-14 Alan Hayward <alan.hayward@arm.com>
154
155 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
156 register sizes.
157
1582019-08-14 Tom Tromey <tromey@adacore.com>
159
160 * darwin-nat.c: Include gdbarch.h.
161 * darwin-nat-info.c: Include gdbarch.h.
162
1632019-08-13 Tom Tromey <tom@tromey.com>
164
165 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
166 Remove.
167 * tui/tui-data.c (tui_initialize_static_data): Update.
168
1692019-08-13 Tom Tromey <tom@tromey.com>
170
171 * tui/tui-winsource.h (struct tui_exec_info_window)
172 <~tui_exec_info_window, maybe_allocate_content, get_content,
173 m_content>: Remove.
174 (struct tui_source_window_base) <set_exec_info_content,
175 show_exec_info_content>: Don't declare.
176 * tui/tui-winsource.c
177 (tui_exec_info_window::maybe_allocate_content): Remove.
178 (tui_source_window_base::update_exec_info): Rename from
179 set_exec_info_content.
180 (tui_source_window_base::show_exec_info_content)
181 (tui_source_window_base::update_exec_info): Remove.
182
1832019-08-13 Tom Tromey <tom@tromey.com>
184
185 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
186 declare.
187 * tui/tui-winsource.c (tui_update_source_window_as_is)
188 (tui_update_source_windows_with_addr, tui_erase_source_content):
189 Update.
190 (tui_clear_exec_info_content): Remove.
191
1922019-08-13 Tom Tromey <tom@tromey.com>
193
194 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
195 declare.
196 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
197 call tui_erase_exec_info_content.
198 (tui_clear_exec_info_content): Rename from
199 tui_erase_exec_info_content.
200 (tui_clear_exec_info_content): Delete.
201
2022019-08-13 Tom Tromey <tom@tromey.com>
203
204 * tui/tui-winsource.h (struct tui_source_window_base)
205 <show_exec_info_content>: Declare.
206 (tui_show_exec_info_content): Don't declare.
207 * tui/tui-winsource.c
208 (tui_source_window_base::show_exec_info_content): Rename from
209 tui_show_exec_info_content.
210 (tui_source_window_base::update_exec_info): Update.
211
2122019-08-13 Tom Tromey <tom@tromey.com>
213
214 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
215 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
216 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
217 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
218 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
219 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
220 ... here.
221
2222019-08-13 Tom Tromey <tom@tromey.com>
223
224 * tui/tui-winsource.h (struct tui_source_window_base)
225 <update_exec_info>: Declare.
226 (tui_update_exec_info): Don't declare.
227 * tui/tui-winsource.c (tui_update_source_window_as_is)
228 (tui_source_window_base::refresh_all)
229 (tui_update_all_breakpoint_info): Update.
230 (tui_source_window_base::update_exec_info): Rename from
231 tui_update_exec_info.
232 * tui/tui-stack.c (tui_show_frame_info): Update.
233
2342019-08-13 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-winsource.h (struct tui_source_window_base)
237 <set_exec_info_content>: Declare.
238 (tui_set_exec_info_content): Don't declare.
239 * tui/tui-winsource.c
240 (tui_source_window_base::set_exec_info_content): Rename from
241 tui_set_exec_info_content.
242 (tui_update_exec_info): Update.
243
2442019-08-13 Tom Tromey <tom@tromey.com>
245
246 * tui/tui-winsource.h (struct tui_source_window_base)
247 <show_source_content>: Declare.
248 (tui_show_source_content): Don't declare.
249 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
250 (tui_source_window_base::show_source_content): Rename from
251 tui_show_source_content.
252 (tui_source_window_base::refresh_all): Update.
253 * tui/tui-layout.c (show_source_disasm_command)
254 (show_source_or_disasm_and_command): Update.
255
2562019-08-13 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-winsource.c (tui_erase_source_content)
259 (tui_show_source_content, tui_source_window_base::refresh_all):
260 Update.
261 * tui/tui-wingeneral.h
262 (tui_check_and_display_highlight_if_needed): Don't declare.
263 * tui/tui-wingeneral.c
264 (tui_win_info::check_and_display_highlight_if_needed): Rename from
265 check_and_display_highlight_if_needed.
266 * tui/tui-win.c (tui_rehighlight_all)
267 (tui_win_info::make_visible_with_new_height): Update.
268 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
269 (tui_data_window::erase_data_content)
270 (tui_data_window::display_all_data): Update.
271 * tui/tui-data.h (struct tui_win_info)
272 <check_and_display_highlight_if_needed>: Declare.
273
2742019-08-13 Tom Tromey <tom@tromey.com>
275
276 * tui/tui-win.c (tui_resize_all): Call
277 tui_delete_invisible_windows.
278 * tui/tui-layout.c (show_layout): Call
279 tui_delete_invisible_windows.
280 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
281 * tui/tui-data.c (tui_delete_invisible_windows): New function.
282
2832019-08-13 Tom Tromey <tom@tromey.com>
284
285 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
286 tui_add_win_to_layout.
287
2882019-08-13 Tom Tromey <tom@tromey.com>
289
290 * tui/tui-layout.h (tui_default_win_height): Don't declare.
291 * tui/tui-layout.c (tui_default_win_height): Now static.
292
2932019-08-13 Tom Tromey <tom@tromey.com>
294
295 * tui/tui-layout.c (show_layout): Unify all layout cases into a
296 single switch.
297 (show_source_disasm_command, show_source_or_disasm_and_command):
298 Don't check current layout.
299
3002019-08-13 Tom Tromey <tom@tromey.com>
301
302 * tui/tui-wingeneral.c (make_all_visible): Remove.
303 (tui_make_all_invisible): Simplify.
304 * tui/tui-layout.c (tui_make_all_invisible): Move from
305 tui-wingeneral.c; simplify.
306 (show_layout): Hoist call to tui_make_all_invisible.
307 (show_data): Don't call tui_make_all_invisible.
308
3092019-08-13 Tom Tromey <tom@tromey.com>
310
311 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
312 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
313
3142019-08-13 Tom Tromey <tom@tromey.com>
315
316 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
317 tui-data.c.
318 (show_source_disasm_command, show_data)
319 (show_source_or_disasm_and_command): Don't use
320 tui_set_current_layout_to.
321 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
322 * tui/tui-data.c (current_layout, tui_current_layout): Move to
323 tui-layout.c.
324 (tui_set_current_layout_to): Remove.
325
3262019-08-13 Tom Tromey <tom@tromey.com>
327
328 * tui/tui-layout.c (tui_set_layout): Update.
329 * tui/tui-data.h (struct tui_layout_def): Remove.
330 (tui_layout_def): Don't declare.
331 * tui/tui-data.c (layout_def): Remove.
332 (tui_layout_def): Remove.
333
3342019-08-13 Tom Tromey <tom@tromey.com>
335
336 * tui/tui-winsource.h (struct tui_source_window_base)
337 <clear_detail>: No longer "override".
338 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
339 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
340 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
341 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
342 Remove.
343 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
344
3452019-08-13 Tom Tromey <tromey@adacore.com>
346
347 * tracepoint.c: Don't include readline.h or history.h.
348
3492019-08-12 Tom Tromey <tom@tromey.com>
350
351 * configure: Rebuild.
352 * configure.ac: Check for readline 7.
353 * NEWS: Mention readline 7 requirement.
354 * README: Update.
355
3562019-08-12 Tom Tromey <tom@tromey.com>
357
358 * mingw-hdep.c (gdb_select): Remove readline hack.
359
3602019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
361
362 * blockframe.c (find_pc_partial_function): Set *block to nullptr
363 when the function fails.
364
3652019-08-09 Andreas Arnez <arnez@linux.ibm.com>
366
367 * s390-tdep.c (s390_type_align): New function.
368 (s390_gdbarch_init): Set it as type_align gdbarch method.
369
3702019-08-09 Tom de Vries <tdevries@suse.de>
371
372 PR gdb/24591
373 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
374 pc_low with relocation offset.
375
3762019-08-07 Tom Tromey <tromey@adacore.com>
377
378 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
379 (print_frame_args): Update.
380 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
381 Update.
382 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
383 * frame.h (struct frame_arg): Add initializers.
384 <error>: Now a unique_xmalloc_ptr.
385
3862019-08-07 Alan Hayward <alan.hayward@arm.com>
387
388 * NEWS: Expand the Pointer Authentication entry.
389 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
390 (aarch64_frame_unmask_lr): ... to this.
391 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
392 Call aarch64_frame_unmask_lr.
393 * frame.c (struct frame_info): Add "masked" variable.
394 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
395 (fprint_frame): Check for masked pc.
396 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
397 declarations.
398 * python/py-framefilter.c (py_print_frame): Check for masked pc.
399 * stack.c (print_frame): Check for masked pc.
400
4012019-08-06 Tom Tromey <tom@tromey.com>
402
403 * stabsread.c (patch_block_stabs, read_one_struct_field)
404 (read_enum_type): Use obstack_strndup.
405 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
406 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
407 * dwarf2read.c (guess_full_die_structure_name)
408 (anonymous_struct_prefix): Use obstack_strndup.
409 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
410 * c-exp.y (yylex): Use obstack_strndup.
411 * ada-exp.y (write_object_renaming, write_ambiguous_var)
412 (write_var_or_type): Use obstack_strndup.
413
4142019-08-06 Tom Tromey <tom@tromey.com>
415
416 * symfile.c (reread_symbols): Use obstack_strdup.
417 * stabsread.c (read_type): Use obstack_strdup.
418 * gdb_obstack.h (obstack_strdup): New overload.
419 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
420 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
421 (dwarf2_canonicalize_name): Use obstack_strdup.
422 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
423 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
424 Use obstack_strdup.
425
4262019-08-06 Tom Tromey <tom@tromey.com>
427
428 * gdb_obstack.h (obstack_strdup): Define.
429 * gdb_obstack.c (obstack_strdup): Don't define.
430
4312019-08-06 Tom Tromey <tom@tromey.com>
432
433 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
434 obstack_strdup.
435 * typeprint.c (typedef_hash_table::find_global_typedef): Use
436 obstack_strdup.
437 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
438 * stabsread.c (common_block_start): Use obstack_strdup.
439 * objfiles.c (set_objfile_main_name, objfile): Use
440 obstack_strdup.
441 * namespace.c (add_using_directive): Use obstack_strdup.
442 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
443 * jit.c (finalize_symtab): Use obstack_strdup.
444 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
445 (guess_partial_die_structure_name, partial_die_info::fixup)
446 (dwarf2_name): Use obstack_strdup.
447 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
448 obstack_strdup.
449 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
450 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
451 obstack_strdup.
452 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
453
4542019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
455
456 * unittests/help-doc-selftests.c: New file.
457 * Makefile.in: Add the new file.
458
4592019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
460
461 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
462 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
463 the full first line, except when FOR_VALUE_PREFIX. In this case,
464 the trailing '.' is not output, and the first character is uppercased.
465 (print_help_for_command): Update call to print_doc_line.
466 (print_doc_of_command): Likewise.
467 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
468 * cli/cli-option.c (append_indented_doc): Do not append newline.
469 (build_help_option): Append newline after first appended_indented_doc
470 only if a second call is done.
471 (build_help): Append 2 new lines before each option, except the first
472 one.
473 * compile/compile.c (_initialize_compile): Add new lines after
474 %OPTIONS%, when not at the end of the help.
475 Change help doc or code
476 producing the help doc to respect the invariants.
477 * maint-test-options.c (_initialize_maint_test_options): Likewise.
478 Also removed the new line after 'Options:', as all other commands
479 do not put an empty line between 'Options:' and the first option.
480 * printcmd.c (_initialize_printcmd): Likewise.
481 * stack.c (_initialize_stack): Likewise.
482 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
483 incorrectly telling COMMAND is optional.
484 * ada-lang.c (_initialize_ada_language): Change help doc or code
485 producing the help doc to respect the invariants.
486 * ada-tasks.c (_initialize_ada_tasks): Likewise.
487 * breakpoint.c (_initialize_breakpoint): Likewise.
488 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
489 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
490 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
491 * cli/cli-style.c (cli_style_option::add_setshow_commands,
492 _initialize_cli_style): Likewise.
493 * corelow.c (core_target_info): Likewise.
494 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
495 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
496 * filesystem.c (_initialize_filesystem): Likewise.
497 * frame.c (_initialize_frame): Likewise.
498 * gnu-nat.c (add_task_commands): Likewise.
499 * infcall.c (_initialize_infcall): Likewise.
500 * infcmd.c (_initialize_infcmd): Likewise.
501 * interps.c (_initialize_interpreter): Likewise.
502 * language.c (_initialize_language): Likewise.
503 * linux-fork.c (_initialize_linux_fork): Likewise.
504 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
505 * maint.c (_initialize_maint_cmds): Likewise.
506 * memattr.c (_initialize_mem): Likewise.
507 * printcmd.c (_initialize_printcmd): Likewise.
508 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
509 _RegEx): Likewise.
510 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
511 * record-btrace.c (_initialize_record_btrace): Likewise.
512 * record-full.c (_initialize_record_full): Likewise.
513 * record.c (_initialize_record): Likewise.
514 * regcache-dump.c (_initialize_regcache_dump): Likewise.
515 * regcache.c (_initialize_regcache): Likewise.
516 * remote.c (add_packet_config_cmd, init_remote_threadtests,
517 _initialize_remote): Likewise.
518 * ser-tcp.c (_initialize_ser_tcp): Likewise.
519 * serial.c (_initialize_serial): Likewise.
520 * skip.c (_initialize_step_skip): Likewise.
521 * source.c (_initialize_source): Likewise.
522 * stack.c (_initialize_stack): Likewise.
523 * symfile.c (_initialize_symfile): Likewise.
524 * symtab.c (_initialize_symtab): Likewise.
525 * target-descriptions.c (_initialize_target_descriptions): Likewise.
526 * top.c (init_main): Likewise.
527 * tracefile-tfile.c (tfile_target_info): Likewise.
528 * tracepoint.c (_initialize_tracepoint): Likewise.
529 * tui/tui-win.c (_initialize_tui_win): Likewise.
530 * utils.c (add_internal_problem_command): Likewise.
531 * valprint.c (value_print_option_defs): Likewise.
532
5332019-08-06 Frank Ch. Eigler <fche@redhat.com>
534
535 PR build/24886
536 * configure.ac: Drop enable-libmcheck support.
537 * configure, config.in: Rebuild.
538 * libmcheck.m4: Remove.
539 * acinclude.m4: Don't include it.
540 * Makefile.in: Don't distribute it.
541 * top.c (print_gdb_configuration): Don't mention it.
542
5432019-08-06 Tom Tromey <tom@tromey.com>
544
545 * utils.c (set_output_style): Sometimes pass stream to
546 emit_style_escape.
547 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
548 * record-btrace.c (btrace_insn_history): Update.
549 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
550 method.
551 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
552 Update initializers.
553 <m_uiout>: New field.
554 <m_di>: Move lower.
555 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
556 Remove "uiout" parameter.
557 (dump_insns): Update.
558 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
559 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
560
5612019-08-06 Christian Biesinger <cbiesinger@google.com>
562
563 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
564 (error_in_psymtab_expansion): Likewise.
565 (lookup_symbol_via_quick_fns): Likewise.
566 (basic_lookup_transparent_type_quick): Likewise.
567 (basic_lookup_transparent_type_1): Likewise.
568
5692019-08-06 Tom Tromey <tromey@adacore.com>
570
571 * source.c (last_source_error): Now bool.
572 (print_source_lines_base): Make "noprint" bool. Only open
573 source file when last_source_visited changes.
574
5752019-08-06 Tom Tromey <tromey@adacore.com>
576
577 * annotate.c (annotate_source_line): Use g_source_cache.
578 * source-cache.c (source_cache::get_plain_source_lines): Change
579 parameters. Populate m_offset_cache.
580 (source_cache::ensure): New method.
581 (source_cache::get_line_charpos): New method.
582 (extract_lines): Move lower. Change parameters.
583 (source_cache::get_source_lines): Move lower.
584 * source-cache.h (class source_cache): Update comment.
585 <get_line_charpos>: New method.
586 <get_source_lines>: Update comment.
587 <clear>: Clear m_offset_cache.
588 <get_plain_source_lines>: Change parameters.
589 <ensure>: New method
590 <m_offset_cache>: New member.
591 * source.c (forget_cached_source_info_for_objfile): Update.
592 (info_source_command): Use g_source_cache.
593 (find_source_lines, open_source_file_with_line_charpos): Remove.
594 (print_source_lines_base, search_command_helper): Use g_source_cache.
595 * source.h (open_source_file_with_line_charpos): Don't declare.
596 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
597 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
598 Use g_source_cache.
599
6002019-08-06 Tom Tromey <tromey@adacore.com>
601
602 * source-cache.c (source_cache::get_plain_source_lines):
603 Remove "first_line" and "last_line" parameters.
604 (source_cache::get_source_lines): Cache plain text.
605 * source-cache.h (class source_cache)
606 <get_plain_source_lines>: Update.
607
6082019-08-06 Tom Tromey <tromey@adacore.com>
609
610 * source-cache.c (extract_lines): No longer a method.
611 Changed type of parameter. Include final newline.
612 (selftests::extract_lines_test): New function.
613 (_initialize_source_cache): Likewise.
614 * source-cache.h (class source_cache)
615 <extract_lines>: Don't declare.
616
6172019-08-06 Tom Tromey <tromey@adacore.com>
618
619 * breakpoint.c (init_breakpoint_sal): Update.
620 (breakpoint): Update.
621 * breakpoint.h (struct breakpoint) <filter>: Now a
622 unique_xmalloc_ptr.
623
6242019-08-05 Christian Biesinger <cbiesinger@google.com>
625
626 * NEWS: Mention dictionary access on blocks.
627 * python/py-block.c (blpy_getitem): New function.
628 (block_object_as_mapping): New struct.
629 (block_object_type): Use new struct for tp_as_mapping field.
630
6312019-08-05 Christian Biesinger <cbiesinger@google.com>
632
633 * objfiles.h (objfile): Add a comment describing partial symbols.
634
6352019-08-05 Tom Tromey <tromey@adacore.com>
636
637 * compile/compile.c (_initialize_compile): Use _(), not N_().
638 * thread.c (_initialize_thread): Use _(), not N_().
639 * stack.c (_initialize_stack): Use _(), not N_().
640 * printcmd.c (_initialize_printcmd): Use _(), not N_().
641
6422019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
643
644 * dwarf2read.c (struct dw2_symtab_iterator):
645 <want_specific_block>: Remove.
646 <block_index>: Change type to gdb::optional.
647 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
648 change type of BLOCK_INDEX parameter to gdb::optional.
649 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
650 (dw2_lookup_symbol): Don't pass argument for
651 WANT_SPECIFIC_BLOCK.
652 (dw2_expand_symtabs_for_function): Don't pass argument for
653 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
654 (class dw2_debug_names_iterator)
655 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
656 parameter, change BLOCK_INDEX type to gdb::optional.
657 <m_want_specific_block>: Remove.
658 <m_block_index>: Change type to gdb::optional.
659 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
660 gdb::optional. Re-write in function of gdb::optional.
661 (dw2_debug_names_lookup_symbol): Don't pass argument for
662 WANT_SPECIFIC_BLOCK.
663 (dw2_debug_names_expand_symtabs_for_function): Don't pass
664 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
665 BLOCK_INDEX.
666
6672019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
668
669 * NEWS: Mention changes to "info sources" command.
670
6712019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
672
673 * symtab.c (filename_partial_match_opts): New struct type.
674 (struct output_source_filename_data): New members
675 regexp, c_regexp, partial_match.
676 (output_source_filename): Use new members to decide to print file.
677 (info_sources_option_defs): New variable.
678 (make_info_sources_options_def_group, print_info_sources_header,
679 info_sources_command_completer):
680 New functions.
681 (info_sources_command): Read new optional arguments.
682 (_initialize_symtab): Update info sources help.
683
6842019-08-02 Alexandre Oliva <oliva@adacore.com>
685
686 * ada-lang.c (exception_support_info_v0): Renamed from...
687 (default_exception_support_info): ... this. Create new
688 definition for v1.
689 (ada_has_this_exception_support): Look up catch_handlers_sym.
690 (ada_exception_support_info_sniffer): Try v0 after default.
691
6922019-08-01 Tom Tromey <tromey@adacore.com>
693
694 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
695 gdbarch.h.
696
6972019-08-01 Christian Biesinger <cbiesinger@google.com>
698
699 * s12z-tdep.c: Fix include path for s12z-opc.h.
700
7012019-08-01 Alan Hayward <alan.hayward@arm.com>
702
703 * NEWS: Require GNU make 3.82.
704
7052019-07-16 Tom Tromey <tom@tromey.com>
706
707 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
708 declare.
709
7102019-07-30 Tom Tromey <tromey@adacore.com>
711
712 * block.c (contained_in): Remove BLOCK_FUNCTION check.
713
7142019-07-30 Kevin Buettner <kevinb@redhat.com>
715
716 * printcmd.c (print_address_symbolic): Print negative offsets.
717 (build_address_symbolic): Force signed arithmetic when computing
718 offset.
719
7202019-07-30 Christian Biesinger <cbiesinger@google.com>
721
722 PR/24474: Add a function to lookup static variables.
723 * NEWS: Mention this new function.
724 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
725 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
726 * python/python.c (python_GdbMethods): Add new function.
727
7282019-07-29 Christian Biesinger <cbiesinger@google.com>
729
730 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
731 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
732 (objfpy_lookup_static_symbol): New function.
733 (objfile_object_methods): Add new functions.
734
7352019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
736
737 * NEWS: Mention 'set|show print frame-info'. Mention new
738 'presence' value for 'frame-arguments'. Mention new '-frame-info'
739 backtrace argument. Mention that python frame filtering code
740 is now consistent with what 'backtrace' command prints.
741
7422019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
743
744 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
745 comments.
746 (print_frame_info_auto, print_frame_info_source_line,
747 print_frame_info_location, print_frame_info_source_and_location,
748 print_frame_info_location_and_address, print_frame_info_short_location):
749 New declarations.
750 (struct frame_print_options): New member print_frame_info.
751 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
752 * stack.h (get_user_print_what_frame_info): New declaration.
753 (frame_show_address): New declaration.
754 * stack.c (print_frame_arguments_choices): New value 'presence'.
755 (print_frame_info_auto, print_frame_info_source_line,
756 print_frame_info_location, print_frame_info_source_and_location,
757 print_frame_info_location_and_address, print_frame_info_short_location,
758 print_frame_info_choices, print_frame_info_print_what): New definitions.
759 (print_frame_args): Only print dots for args if print frame-arguments
760 is 'presence'.
761 (frame_print_option_defs): New element for "frame-info".
762 (get_user_print_what_frame_info): New function.
763 (frame_show_address): Make non static. Move comment to stack.h.
764 (print_frame_info_to_print_what): New function.
765 (print_frame_info): Update comment. Use fp_opts.print_frame_info
766 to decide what to print.
767 (backtrace_command_1): Handle the new print_frame_arguments_presence
768 value.
769 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
770 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
771 (py_print_frame): In non-mi mode, use LOCATION as default for
772 print_what, similarly to frame information printed directly by
773 backtrace command. Handle frame-info user option in non MI mode.
774
7752019-07-27 Kevin Buettner <kevinb@redhat.com>
776
777 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
778 Add case for debugging 32-bit target on 64-bit host. Revise
779 comment.
780
7812019-07-27 Kevin Buettner <kevinb@redhat.com>
782
783 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
784 instead of find_function_entry_range_from_pc.
785
7862019-07-27 Kevin Buettner <kevinb@redhat.com>
787
788 * stack.c (find_frame_funname): Remove code which preferred
789 minsym over symtab sym in "certain pathological cases".
790
791 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
792 parameter. Change type of "do_demangle" to bool.
793 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
794 Pass suitable "prefer_sym_over_minsym" flag to
795 build_address_symbolic(). Don't output "+" for negative offsets.
796 * printcmd.c (print_address_symbolic): Update invocation of
797 build_address_symbolic to include a "prefer_sym_over_minsym"
798 flag.
799 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
800 Restrict cases in which use of minimal symbol is preferred to that
801 of a found symbol. Update comments.
802
803 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
804 for entry pc when entry pc is out of range for that FDE.
805
8062019-07-26 Brian Callahan <bcallah@openbsd.org>
807
808 PR gdb/24839:
809 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
810 type.
811
8122019-07-25 Christian Biesinger <cbiesinger@google.com>
813
814 * python/py-objfile.c (add_separate_debug_file): Fix comment about
815 this function's Python signature.
816
817
8182019-07-24 Christian Biesinger <cbiesinger@google.com>
819
820 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
821 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
822 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
823 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
824 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
825
826
8272019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
828
829 * h8300-tdep.c (h8300_register_name_common): New.
830 h8300_register_name): Use h8300_register_name_common.
831 (h8300s_register_name): Likewise.
832 (h8300sx_register_name): Likewise.
833 (h8300h_register_nam): New.
834 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
835
836
8372019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
838
839 * arm-tdep.c (arm_skip_cmse_entry): New function.
840 (arm_is_sgstubs_section): New function.
841 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
842
8432019-07-22 Tom Tromey <tom@tromey.com>
844
845 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
846 Don't self-assign.
847
8482019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
849
850 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
851 type_print.
852
8532019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
854
855 * symtab.c (search_symbols): Adjust msymbol matching type arrays
856 so that GDB doesn't match any msymbols when searching in the
857 TYPES_DOMAIN.
858 (print_symbol_info): Print using typedef_print or type_print based
859 on the type of the symbol. Add updated FIXME comment moved from...
860 (_initialize_symtab): ... move and update FIXME comment to above.
861
8622019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
863
864 * NEWS: Mention adding -q option to "info types".
865 * symtab.c (struct info_types_options): New struct.
866 (info_types_options_defs): New variable.
867 (make_info_types_options_def_group): New function.
868 (info_types_command): Use gdb::option framework to parse options.
869 (info_types_command_completer): New function.
870 (_initialize_symtab): Extend the help text on "info types" and
871 register command completer.
872
8732019-07-21 Christian Biesinger <cbiesinger@google.com>
874
875 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
876 (lookup_symbol_in_objfile): Change int to block_enum and add a
877 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
878
8792019-07-20 Christian Biesinger <cbiesinger@google.com>
880
881 * MAINTAINERS (Write After Approval): Add self.
882
8832019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
884
885 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
886 instruction to the dummy code region.
887
8882019-07-19 Tom Tromey <tromey@adacore.com>
889
890 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
891 (ARGSUSED, PARAMS, __func__): Remove rules.
892
8932019-07-19 Alan Hayward <alan.hayward@arm.com>
894
895 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
896 * features/arm/arm-with-iwmmxt.c: Remove.
897 * features/arm/arm-with-iwmmxt.xml: Remove.
898 * features/arm/arm-with-m-fpa-layout.c: Remove.
899 * features/arm/arm-with-m-fpa-layout.xml: Remove.
900 * features/arm/arm-with-m-vfp-d16.c: Remove.
901 * features/arm/arm-with-m-vfp-d16.xml: Remove.
902 * features/arm/arm-with-m.c: Remove.
903 * features/arm/arm-with-m.xml: Remove.
904 * features/arm/arm-with-neon.c: Remove.
905 * features/arm/arm-with-neon.xml: Remove.
906 * features/arm/arm-with-vfpv2.c: Remove.
907 * features/arm/arm-with-vfpv2.xml: Remove.
908 * features/arm/arm-with-vfpv3.c: Remove.
909 * features/arm/arm-with-vfpv3.xml: Remove.
910
9112019-07-19 Alan Hayward <alan.hayward@arm.com>
912
913 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
914
9152019-07-19 Alan Hayward <alan.hayward@arm.com>
916
917 * arch/aarch32.c (aarch32_create_target_description): Create
918 target descriptions using features.
919 * arch/arm.c (arm_create_target_description)
920 (arm_create_mprofile_target_description): Likewise.
921 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
922
9232019-07-19 Alan Hayward <alan.hayward@arm.com>
924
925 * Makefile.in: Add new files.
926 * aarch32-tdep.c: New file.
927 * aarch32-tdep.h: New file.
928 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
929 Call aarch32_read_description.
930 * arch/aarch32.c: New file.
931 * arch/aarch32.h: New file.
932 * arch/arm.c (arm_create_target_description)
933 (arm_create_mprofile_target_description): New function.
934 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
935 (arm_create_target_description)
936 (arm_create_mprofile_target_description): New declaration.
937 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
938 read_description functions.
939 * arm-linux-nat.c (arm_linux_nat_target::read_description):
940 Likewise.
941 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
942 * arm-tdep.c (tdesc_arm_list): New variable.
943 (arm_register_g_packet_guesses): Call create description functions.
944 (arm_read_description) (arm_read_mprofile_description): New
945 function.
946 * arm-tdep.h (arm_read_description)
947 (arm_read_mprofile_description): Add declaration.
948 * configure.tgt: Add new files.
949
9502019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
951
952 * top.c (new_ui_command): Open specified terminal just once.
953
9542019-07-18 Tom Tromey <tromey@adacore.com>
955
956 * symtab.c (main_name): Constify return type.
957 * symfile.c (set_initial_language): Update.
958 * symtab.h (main_name): Constify return type.
959
9602019-07-17 Tom Tromey <tom@tromey.com>
961
962 * tui/tui-winsource.c (tui_update_source_window)
963 (tui_update_source_window_as_is)
964 (tui_update_source_windows_with_line): Remove return.
965 * tui/tui-disasm.c (tui_show_disassem)
966 (tui_show_disassem_and_update_source): Remove return.
967 * tui/tui.c (tui_reset): Remove return.
968 * tui/tui-wingeneral.c
969 (tui_check_and_display_highlight_if_needed): Remove return.
970
9712019-07-17 Tom Tromey <tom@tromey.com>
972
973 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
974
9752019-07-17 Tom Tromey <tom@tromey.com>
976
977 * tui/tui-winsource.h (struct tui_exec_info_window)
978 (struct tui_source_window_base): Move from tui-data.h.
979 * tui/tui-winsource.c: Move many method definitions from
980 elsewhere. Remove "structuring" comments.
981 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
982 (tui_source_window_base::refresh_window): Move to
983 tui-winsource.c.
984 * tui/tui-win.c (tui_source_window_base::refresh_all)
985 (tui_source_window_base::update_tab_width)
986 (tui_source_window_base::set_new_height)
987 (tui_source_window_base::do_make_visible_with_new_height): Move to
988 tui-winsource.c.
989 * tui/tui-source.h: Update.
990 * tui/tui-source.c (tui_source_window_base::reset): Move to
991 tui-winsource.c.
992 * tui/tui-disasm.h: Update.
993 * tui/tui-data.h (struct tui_exec_info_window): Move to
994 tui-winsource.h.
995 (struct tui_source_window_base): Likewise.
996 * tui/tui-data.c (tui_source_window_base::clear_detail)
997 (tui_source_window_base, ~tui_source_window_base): Move to
998 tui-winsource.c.
999
10002019-07-17 Tom Tromey <tom@tromey.com>
1001
1002 * tui/tui-win.c (tui_resize_all)
1003 (tui_source_window_base::update_tab_width)
1004 (tui_adjust_win_heights): Update.
1005 (tui_win_info::make_invisible_and_set_new_height): Rename from
1006 make_invisible_and_set_new_height.
1007 * tui/tui-data.h (struct tui_win_info)
1008 <make_invisible_and_set_new_height>: New method.
1009
10102019-07-17 Tom Tromey <tom@tromey.com>
1011
1012 * tui/tui.c: Update.
1013 * tui/tui-source.h (struct tui_source_window): Move from
1014 tui-data.h.
1015 * tui/tui-layout.c: Update.
1016 * tui/tui-disasm.c: Update.
1017 * tui/tui-data.h (struct tui_source_window): Move to
1018 tui-source.h.
1019
10202019-07-17 Tom Tromey <tom@tromey.com>
1021
1022 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1023 tui-data.h.
1024 * tui/tui-data.h (struct tui_disasm_window): Move to
1025 tui-disasm.h.
1026
10272019-07-17 Tom Tromey <tom@tromey.com>
1028
1029 * tui/tui-regs.h (struct tui_data_item_window): Move from
1030 tui-data.h.
1031 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1032 * tui/tui-data.h (struct tui_data_item_window): Move to
1033 tui-regs.h.
1034 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1035
10362019-07-17 Tom Tromey <tom@tromey.com>
1037
1038 * tui/tui.c: Update.
1039 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1040 (tui_cmd_window::max_height): Move to tui-command.c.
1041 * tui/tui-layout.c: Update.
1042 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1043 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1044 tui-command.c.
1045 * tui/tui-command.h (struct tui_cmd_window): Move from
1046 tui-data.h.
1047 * tui/tui-command.c: Remove "structuring" comments.
1048 (tui_cmd_window::clear_detail)
1049 (tui_cmd_window::do_make_visible_with_new_height)
1050 (tui_cmd_window::max_height): Move from elsewhere.
1051
10522019-07-17 Tom Tromey <tom@tromey.com>
1053
1054 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1055 Now static.
1056 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1057 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1058
10592019-07-17 Tom Tromey <tom@tromey.com>
1060
1061 * tui/tui.c: Update.
1062 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1063 tui-regs.c.
1064 * tui/tui-windata.h: Remove file.
1065 * tui/tui-windata.c: Remove file.
1066 * tui/tui-win.c (tui_data_window::set_new_height)
1067 (tui_data_window::do_make_visible_with_new_height): Move to
1068 tui-regs.c.
1069 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1070 * tui/tui-regs.c: Remove "structuring" comments.
1071 (tui_data_window::first_data_item_displayed)
1072 (tui_data_window::delete_data_content_windows)
1073 (tui_data_window::erase_data_content)
1074 (tui_data_window::display_all_data)
1075 (tui_data_window::refresh_all)
1076 (tui_data_window::do_scroll_vertical)
1077 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1078 (tui_data_window::do_make_visible_with_new_height)
1079 (tui_data_window::refresh_window): Move from elsewhere.
1080 (_initialize_tui_regs): Move to end of file.
1081 * tui/tui-layout.c: Update.
1082 * tui/tui-hooks.c: Update.
1083 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1084 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1085 tui-regs.c.
1086 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1087
10882019-07-17 Tom Tromey <tom@tromey.com>
1089
1090 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1091 seen.
1092
10932019-07-17 Tom Tromey <tom@tromey.com>
1094
1095 * tui/tui-win.c (tui_source_window_base::set_new_height)
1096 (tui_source_window_base::do_make_visible_with_new_height): Use
1097 m_has_locator field directly.
1098 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1099 method.
1100 (struct tui_source_window_base) <has_locator>: Likewise.
1101
11022019-07-17 Tom Tromey <tom@tromey.com>
1103
1104 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1105 Don't declare.
1106 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1107 Remove.
1108 * tui/tui-win.c (tui_source_window_base::set_new_height)
1109 (tui_source_window_base::set_new_height)
1110 (make_invisible_and_set_new_height)
1111 (tui_source_window_base::do_make_visible_with_new_height)
1112 (tui_source_window_base::do_make_visible_with_new_height):
1113 Update.
1114 * tui/tui-layout.c (show_source_disasm_command, show_data)
1115 (show_source_or_disasm_and_command): Update.
1116 * tui/tui-layout.c (show_layout): Update.
1117
11182019-07-17 Tom Tromey <tom@tromey.com>
1119
1120 * tui/tui-layout.c (make_data_window): Remove.
1121 (show_data): Unify creation and re-initialization cases.
1122
11232019-07-17 Tom Tromey <tom@tromey.com>
1124
1125 * tui/tui-layout.c (make_source_window, make_disasm_window):
1126 Remove.
1127 (show_data): Unify creation and re-initialization cases.
1128
11292019-07-17 Tom Tromey <tom@tromey.com>
1130
1131 * tui/tui-layout.c (make_command_window): Remove.
1132 (show_source_disasm_command, show_source_or_disasm_and_command):
1133 Unify creation and re-initialization cases.
1134
11352019-07-17 Tom Tromey <tom@tromey.com>
1136
1137 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1138 creation and re-initialization cases.
1139
11402019-07-17 Tom Tromey <tom@tromey.com>
1141
1142 * tui/tui-regs.c (tui_get_register): Return void.
1143
11442019-07-17 Tom Tromey <tom@tromey.com>
1145
1146 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1147 Simplify.
1148
11492019-07-17 Tom Tromey <tom@tromey.com>
1150
1151 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1152 resetting.
1153
11542019-07-17 Tom Tromey <tom@tromey.com>
1155
1156 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1157 * tui/tui-regs.c (tui_reg_layout): New function.
1158 (tui_show_registers, tui_reg_command): Use it.
1159 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1160 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1161 parameters.
1162 (tui_layout_command): Remove.
1163
11642019-07-17 Tom Tromey <tom@tromey.com>
1165
1166 * tui/tui-layout.h (tui/tui-layout): Return void.
1167 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1168
11692019-07-17 Tom Tromey <tom@tromey.com>
1170
1171 * tui/tui-layout.c (show_source_disasm_command, show_data):
1172 Update.
1173 (reset_locator): Remove.
1174 (show_source_or_disasm_and_command): Update.
1175
11762019-07-17 Tom Tromey <tom@tromey.com>
1177
1178 * tui/tui-source.c (tui_source_window_base::reset): Remove
1179 win_type parameter.
1180 * tui/tui-layout.c (make_command_window, make_source_window)
1181 (make_disasm_window, make_data_window)
1182 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1183 (reset_locator, show_source_or_disasm_and_command): Update.
1184 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1185 win_type parameter.
1186 (struct tui_source_window_base) <reset>: Likewise.
1187
11882019-07-17 Tom Tromey <tom@tromey.com>
1189
1190 * tui/tui-layout.c (show_source_disasm_command): Use
1191 reset_locator.
1192 (reset_locator): New function.
1193 (init_and_make_win): Remove.
1194 (show_source_or_disasm_and_command): Use reset_locator.
1195
11962019-07-17 Tom Tromey <tom@tromey.com>
1197
1198 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1199 condition.
1200 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1201 Remove condition.
1202 * tui/tui-source.c (tui_source_window_base::reset): New method.
1203 * tui/tui-layout.c (make_command_window): Don't call
1204 init_and_make_win.
1205 (make_source_window, make_disasm_window): Don't call
1206 make_source_or_disasm_window.
1207 (make_data_window): Don't call init_and_make_win. Change calling
1208 convention.
1209 (show_source_disasm_command, show_data): Simplify.
1210 (make_source_or_disasm_window): Remove.
1211 (show_source_or_disasm_and_command): Simplify.
1212 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1213 (struct tui_source_window_base) <reset>: Likewise.
1214 <execution_info>: Remove initializer.
1215 * tui/tui-data.c (tui_source_window_base): Initialize
1216 execution_info.
1217
12182019-07-17 Tom Tromey <tom@tromey.com>
1219
1220 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1221 variable.
1222
12232019-07-17 Tom Tromey <tom@tromey.com>
1224
1225 * tui/tui.c (tui_rl_other_window): Update.
1226 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1227 superclass method first. Always iterate over regs_content.
1228 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1229 method.
1230 * tui/tui-win.c (tui_set_focus_command): Update.
1231
12322019-07-17 Tom Tromey <tom@tromey.com>
1233
1234 * tui/tui-win.c (tui_set_focus_command): Rename from
1235 tui_set_focus. Call tui_enable.
1236 (tui_set_focus_command): Remove.
1237
12382019-07-17 Tom Tromey <tom@tromey.com>
1239
1240 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1241 refresh_window.
1242 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1243 touchwin.
1244 (tui_data_window::refresh_window): Call refresh_window on data
1245 items. Always call superclass refresh_window.
1246 (tui_win_info::refresh): Remove.
1247 (tui_source_window_base::refresh_window): Update.
1248 (tui_refresh_all): Update.
1249 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1250 refresh_window.
1251 (show_source_or_disasm_and_command): Likewise.
1252 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1253 (struct tui_source_window_base) <refresh>: Likewise.
1254
12552019-07-17 Tom Tromey <tom@tromey.com>
1256
1257 * tui/tui-winsource.c (tui_clear_source_content)
1258 (tui_show_source_content): Update.
1259 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1260 whether content is empty.
1261 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1262 Remove.
1263
12642019-07-17 Tom Tromey <tom@tromey.com>
1265
1266 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1267 window's contents.
1268 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1269 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1270
12712019-07-17 Tom Tromey <tom@tromey.com>
1272
1273 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1274 (struct tui_data_item_window): Update.
1275
12762019-07-17 Tom Tromey <tom@tromey.com>
1277
1278 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1279 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1280 defines.
1281
12822019-07-17 Tom Tromey <tom@tromey.com>
1283
1284 * tui/tui-winsource.h (tui_erase_source_content)
1285 (tui_clear_source_content): Remove "display_prompt" parameter.
1286 * tui/tui-winsource.c (tui_update_source_window_as_is)
1287 (tui_update_source_windows_with_addr): Update.
1288 (tui_clear_source_content): Remove "display_prompt" parameter.
1289 (tui_erase_source_content): Likewise. Simplify.
1290 (tui_show_source_content): Update.
1291 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1292 * tui/tui-stack.c (tui_show_frame_info): Update.
1293 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1294 Remove defines.
1295
12962019-07-17 Tom Tromey <tom@tromey.com>
1297
1298 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1299 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1300 parameter.
1301 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1302 parameter.
1303
13042019-07-17 Tom Tromey <tom@tromey.com>
1305
1306 * tui/tui-winsource.c (tui_clear_source_content)
1307 (tui_show_source_content, tui_show_exec_info_content)
1308 (tui_clear_exec_info_content): Update.
1309 * tui/tui-stack.c (tui_show_locator_content): Update.
1310 (tui_show_frame_info): Update.
1311 * tui/tui-source.h (tui_source_window): Don't declare.
1312 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1313 from tui_source_is_displayed.
1314 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1315 Remove field.
1316 (struct tui_source_window_base) <content_in_use>: New field. Now
1317 bool.
1318 (struct tui_source_window) <showing_source_p>: New method.
1319 (TUI_SRC_WIN): Change cast.
1320 * tui/tui-data.c (tui_initialize_static_data): Update.
1321
13222019-07-17 Tom Tromey <tom@tromey.com>
1323
1324 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1325 location_matches_p.
1326 * tui/tui-source.c (tui_source_window::location_matches_p): New
1327 method.
1328 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1329 method.
1330 * tui/tui-data.h (struct tui_source_window_base)
1331 <location_matches_p>: New method.
1332 (struct tui_source_window, struct tui_disasm_window)
1333 <location_matches_p>: Likewise.
1334
13352019-07-17 Tom Tromey <tom@tromey.com>
1336
1337 * tui/tui-win.c (tui_set_win_height_command): Rename from
1338 tui_set_win_height.
1339 (tui_set_win_height_command): Remove.
1340
13412019-07-17 Tom Tromey <tom@tromey.com>
1342
1343 * tui/tui-source.c (tui_source_window): New constructor. Add
1344 observer.
1345 (~tui_source_window): New destructor.
1346 (tui_source_window::style_changed): New method.
1347 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1348 (tui_attach_detach_observers): Update.
1349 * tui/tui-data.h (struct tui_source_window): Make constructor not
1350 inline. Add destructor.
1351 (struct tui_source_window) <style_changed>: New method.
1352 <m_observable>: New member.
1353
13542019-07-17 Tom Tromey <tom@tromey.com>
1355
1356 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1357 * tui/tui-win.c (tui_resize_all): Fix typo.
1358
13592019-07-17 Tom Tromey <tom@tromey.com>
1360
1361 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1362 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1363 (tui_refresh_all): Remove "list" parameter. Use foreach.
1364 * tui/tui-win.c (window_name_completer): Use foreach.
1365 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1366 (update_tab_width): Likewise.
1367 * tui/tui-layout.c (show_layout): Update.
1368 * tui/tui-data.h (class tui_window_iterator): New.
1369 (struct all_tui_windows): New.
1370 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1371
13722019-07-17 Tom Tromey <tom@tromey.com>
1373
1374 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1375 parameter. Don't reference globals.
1376 (tui_reg_command): Update.
1377
13782019-07-17 Tom Tromey <tom@tromey.com>
1379
1380 * tui/tui-regs.c (tui_show_registers): Simplify.
1381
13822019-07-17 Tom Tromey <tom@tromey.com>
1383
1384 * tui/tui-regs.c (tui_show_registers): Update.
1385 (tui_show_register_group): Add win_info parameter.
1386
13872019-07-17 Tom Tromey <tom@tromey.com>
1388
1389 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1390 Rename from tui_display_reg_element_at_line.
1391 (tui_data_window::display_registers_from_line): Update.
1392 * tui/tui-data.h (struct tui_data_window)
1393 <display_reg_element_at_line>: New method.
1394
13952019-07-17 Tom Tromey <tom@tromey.com>
1396
1397 * tui/tui-regs.h (tui_display_registers_from)
1398 (tui_display_registers_from_line): Don't declare.
1399 * tui/tui-windata.c (tui_data_window::display_all_data)
1400 (tui_data_window::refresh_all)
1401 (tui_data_window::do_scroll_vertical): Update.
1402 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1403 from tui_display_registers_from.
1404 (tui_display_reg_element_at_line): Update.
1405 (tui_data_window::display_registers_from_line): Rename from
1406 tui_display_registers_from_line.
1407 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1408 display_registers_from_line>: New methods.
1409
14102019-07-17 Tom Tromey <tom@tromey.com>
1411
1412 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1413 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1414 from tui_erase_data_content.
1415 (tui_data_window::display_all_data)
1416 (tui_data_window::refresh_all)
1417 (tui_data_window::do_scroll_vertical): Update.
1418 * tui/tui-regs.c (tui_show_registers): Update.
1419 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1420 New method.
1421
14222019-07-17 Tom Tromey <tom@tromey.com>
1423
1424 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1425 declare.
1426 * tui/tui-windata.c
1427 (tui_data_window::delete_data_content_windows): Rename from
1428 tui_delete_data_content_windows.
1429 (tui_data_window::display_all_data)
1430 (tui_data_window::do_scroll_vertical): Update.
1431 * tui/tui-data.h (struct tui_data_window)
1432 <delete_data_content_windows>: New method.
1433
14342019-07-17 Tom Tromey <tom@tromey.com>
1435
1436 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1437 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1438
14392019-07-17 Tom Tromey <tom@tromey.com>
1440
1441 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1442 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1443 from tui_display_all_data.
1444 * tui/tui-win.c
1445 (tui_data_window::do_make_visible_with_new_height): Update.
1446 * tui/tui-regs.c (tui_show_registers): Update.
1447 * tui/tui-layout.c (tui_set_layout): Update.
1448 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1449 method.
1450
14512019-07-17 Tom Tromey <tom@tromey.com>
1452
1453 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1454 * tui/tui-windata.c (tui_display_data_from): Remove.
1455 (tui_data_window::refresh_all): Update.
1456
14572019-07-17 Tom Tromey <tom@tromey.com>
1458
1459 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1460 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1461 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1462 tui_display_registers_from_line.
1463 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1464 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1465 "force_display" parameter.
1466
14672019-07-17 Tom Tromey <tom@tromey.com>
1468
1469 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1470 declare.
1471 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1472 Rename from tui_first_reg_element_no_inline.
1473 (tui_display_reg_element_at_line)
1474 (tui_display_registers_from_line): Update.
1475 * tui/tui-data.h (struct tui_data_window)
1476 <first_reg_element_no_inline>: New method.
1477
14782019-07-17 Tom Tromey <tom@tromey.com>
1479
1480 * tui/tui-windata.c (tui_display_data_from)
1481 (tui_data_window::do_scroll_vertical): Update.
1482 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1483 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1484 Rename from tui_line_from_reg_element_no.
1485 (tui_display_registers_from_line): Update.
1486 * tui/tui-data.h (struct tui_data_window)
1487 <line_from_reg_element_no>: New method.
1488
14892019-07-17 Tom Tromey <tom@tromey.com>
1490
1491 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1492 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1493 tui_last_regs_line_no.
1494 (tui_display_reg_element_at_line)
1495 (tui_display_registers_from_line): Update.
1496 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1497 method.
1498
14992019-07-17 Tom Tromey <tom@tromey.com>
1500
1501 PR tui/24722:
1502 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1503 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1504 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1505 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1506 (tui_update_breakpoint_info): Likewise.
1507 * tui/tui-hooks.c (tui_event_create_breakpoint)
1508 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1509 Update.
1510
15112019-07-17 Tom Tromey <tom@tromey.com>
1512
1513 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1514
15152019-07-17 Tom Tromey <tom@tromey.com>
1516
1517 * tui/tui-winsource.c (tui_update_source_window_as_is)
1518 (tui_update_source_windows_with_addr): Update.
1519 * tui/tui-source.h (tui_set_source_content)
1520 (tui_show_symtab_source): Add "win_info" parameter.
1521 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1522 parameter.
1523 (tui_show_symtab_source): Likewise.
1524
15252019-07-17 Tom Tromey <tom@tromey.com>
1526
1527 * tui/tui-wingeneral.c
1528 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1529
15302019-07-17 Tom Tromey <tom@tromey.com>
1531
1532 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1533 (struct tui_cmd_window) <can_scroll>: New method.
1534 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1535 method.
1536
15372019-07-17 Tom Tromey <tromey@adacore.com>
1538
1539 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1540 do_field_signed>: Rename. Change type of "value".
1541 * ui-out.c (ui_out::field_signed): Rename from field_int.
1542 Change type of "value".
1543 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1544 type of "value".
1545 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1546 do_field_int. Change type of "value".
1547 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1548 do_field_int. Change type of "value".
1549 * tracepoint.c (trace_status_mi, tfind_1)
1550 (print_one_static_tracepoint_marker): Update.
1551 * thread.c (print_thread_info_1, print_selected_thread_frame):
1552 Update.
1553 * stack.c (print_frame, print_frame_info): Update.
1554 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1555 Update.
1556 * source.c (print_source_lines_base): Update.
1557 * skip.c (info_skip_command): Update.
1558 * record-btrace.c (btrace_ui_out_decode_error)
1559 (btrace_call_history_src_line): Update.
1560 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1561 Update.
1562 * progspace.c (print_program_space): Update.
1563 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1564 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1565 do_field_int. Change type of "value".
1566 * mi/mi-out.c (mi_ui_out::do_table_begin)
1567 (mi_ui_out::do_table_header): Update.
1568 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1569 type of "value".
1570 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1571 (mi_cmd_data_list_changed_registers, output_register)
1572 (mi_cmd_data_read_memory, mi_load_progress)
1573 (mi_cmd_trace_frame_collected): Update.
1574 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1575 Update.
1576 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1577 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1578 (mi_cmd_var_list_children, varobj_update_one): Update.
1579 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1580 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1581 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1582 * inferior.c (print_inferior): Update.
1583 * gdb_bfd.c (print_one_bfd): Update.
1584 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1585 Update.
1586 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1587 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1588 do_field_int. Change type of "value".
1589 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1590 do_field_int. Change type of "value".
1591 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1592 (print_one_breakpoint_location, print_it_catch_fork)
1593 (print_one_catch_fork, print_it_catch_vfork)
1594 (print_one_catch_vfork, print_it_catch_solib)
1595 (print_it_catch_exec, print_it_ranged_breakpoint)
1596 (print_mention_watchpoint, print_mention_masked_watchpoint)
1597 (bkpt_print_it, update_static_tracepoint): Update.
1598 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1599 * break-catch-syscall.c (print_it_catch_syscall): Update.
1600 * ada-tasks.c (print_ada_task_info): Update.
1601 * ada-lang.c (print_it_exception, print_mention_exception):
1602 Update.
1603
16042019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1605
1606 PR breakpoints/24541
1607 * gdbarch.c: Regenerate.
1608 * gdbarch.h: Regenerate.
1609 * gdbarch.sh: Adjust return type and parameter types for
1610 'stap_adjust_register'.
1611 (i386_stap_adjust_register): Adjust signature and return new
1612 register name.
1613 * stap-probe.c (stap_parse_register_operand): Adjust use of
1614 'gdbarch_stap_adjust_register'.
1615
16162019-07-17 Tom Tromey <tromey@adacore.com>
1617
1618 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1619 declare VEC.
1620 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1621 std::vector.
1622 (struct s390_process_info): Add initializers.
1623 (s390_add_process): Use new.
1624 (s390_linux_nat_target::low_forget_process): Use delete.
1625 (s390_linux_nat_target::low_new_fork)
1626 (s390_linux_nat_target::stopped_by_watchpoint)
1627 (s390_linux_nat_target::low_prepare_to_resume)
1628 (s390_linux_nat_target::insert_watchpoint)
1629 (s390_linux_nat_target::insert_hw_breakpoint)
1630 (s390_linux_nat_target::remove_watchpoint)
1631 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1632
16332019-07-16 John Baldwin <jhb@FreeBSD.org>
1634
1635 * aarch64-fbsd-nat.c: Include regcache.h.
1636 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1637 argument.
1638 (aarch64_fbsd_nat_target::fetch_registers)
1639 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1640 variable.
1641 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1642
16432019-07-16 John Baldwin <jhb@FreeBSD.org>
1644
1645 * fbsd-nat.c: Include gdbarch.h.
1646
16472019-07-15 Tom Tromey <tromey@adacore.com>
1648
1649 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1650
16512019-07-15 Tom Tromey <tromey@adacore.com>
1652
1653 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1654 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1655 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1656 * cli-out.c (cli_ui_out::do_field_int): New method.
1657 * ui-out.c (ui_out::field_unsigned): New method.
1658 * symfile.c (generic_load): Use field_unsigned.
1659 (print_transfer_performance): Likewise.
1660 * record-btrace.c (ui_out_field_uint): Remove.
1661 (btrace_call_history_insn_range, btrace_call_history): Use
1662 field_unsigned.
1663 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1664 field_unsigned.
1665 * ui-out.h (class ui_out) <field_unsigned>: New method.
1666 <do_field_unsigned>: Likewise.
1667
16682019-07-15 Tom Tromey <tromey@adacore.com>
1669
1670 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1671 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1672 * target.c (flash_erase_command): Use field_string.
1673 * infrun.c (print_signal_received_reason): Use field_string.
1674 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1675 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1676 field_string.
1677 * ada-tasks.c (print_ada_task_info): Use field_string.
1678
16792019-07-15 Tom Tromey <tromey@adacore.com>
1680
1681 * target.c (flash_erase_command): Use field_core_addr.
1682 * symfile.c (generic_load): Use field_core_addr.
1683 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1684 Use field_core_addr.
1685 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1686 field_core_addr.
1687
16882019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1689
1690 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1691 value if its desired type is smaller than a CORE_ADDR and signed.
1692
16932019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1694
1695 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1696 of changes to field names, and use new is_reference field to
1697 decide if a property is a reference or not.
1698 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1699 field.
1700 (struct dwarf2_property_baton): Update header comment, rename
1701 'referenced_type' to 'property_type' and update comments.
1702 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1703 default property type, store in property baton, update to take
1704 accound of renamed field.
1705 (read_func_scope): Update call to attr_to_dynamic_prop.
1706 (read_array_type): Likewise.
1707 (dwarf2_per_cu_addr_sized_int_type): New function.
1708 (read_subrange_index_type): Move type finding code to
1709 dwarf2_per_cu_addr_sized_int_type.
1710 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1711 (dwarf2_per_cu_addr_type): New function.
1712 (set_die_type): Update calls to attr_to_dynamic_prop.
1713
17142019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1715
1716 * dwarf2read.c (read_subrange_index_type): New function.
1717 (read_subrange_type): Move code into new function and call it.
1718 * gdbtypes.c (create_range_type): Add some asserts.
1719
17202019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1721
1722 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1723 update return statements.
1724 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1725 declaration, and update comment to match.
1726 * gdbtypes.c (resolve_dynamic_array): Update call to
1727 dwarf2_evaluate_property to match new return type.
1728
17292019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1730
1731 * valarith.c (value_subscripted_rvalue): Change lowerbound
1732 parameter type from int to LONGEST.
1733 * value.h (value_subscripted_rvalue): Likewise in declaration.
1734
17352019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1736
1737 * cli/cli-utils.c (info_print_command_completer): New function.
1738 * cli/cli-utils.h: Add 'completer.h' include, and forward
1739 declaration for 'struct cmd_list_element'.
1740 (info_print_command_completer): Declare.
1741 * stack.c (_initialize_stack): Add completer for 'info locals' and
1742 'info args'.
1743 * symtab.c (_initialize_symtab): Add completer for 'info
1744 variables' and 'info functions'.
1745 * NEWS: Mention completion for additional info commands.
1746
17472019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1748
1749 * cli/cli-utils.c (extract_info_print_args): Delete.
1750 (extract_arg_maybe_quoted): Delete.
1751 (info_print_options_defs): New variable.
1752 (make_info_print_options_def_group): New function.
1753 (extract_info_print_options): Define new function.
1754 * cli/cli-utils.h (extract_info_print_args): Delete.
1755 (struct info_print_options): New structure.
1756 (extract_info_print_options): Declare new function.
1757 * stack.c (info_locals_command): Update to use new
1758 extract_info_print_options, also add a header comment.
1759 (info_args_command): Likewise.
1760 * symtab.c (info_variables_command): Likewise.
1761 (info_functions_command): Likewise.
1762
17632019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1764
1765 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1766 to extract string arguments.
1767 * common/common-utils.c (extract_string_maybe_quoted): New function.
1768 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1769
17702019-07-11 Tom Tromey <tromey@adacore.com>
1771
1772 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1773 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1774 * top.h (gdbinit): Don't declare.
1775 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1776 into...
1777 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1778 * top.c (gdb_init): Don't call init_cli_cmds.
1779 (gdbinit): Remove.
1780 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1781
17822019-07-11 Tom Tromey <tromey@adacore.com>
1783
1784 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1785 after it has been moved.
1786
17872019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1788
1789 * valops.c (value_must_coerce_to_target): Change return type to
1790 bool.
1791 * value.h (value_must_coerce_to_target): Likewise.
1792
17932019-07-10 Simon Marchi <simon.marchi@efficios.com>
1794
1795 * breakpoint.c (is_hardware_watchpoint): Remove
1796 forward-declaration.
1797 (is_masked_watchpoint): Change return type to bool.
1798 (is_tracepoint): Likewise.
1799 (is_breakpoint): Likewise.
1800 (is_hardware_watchpoint): Likewise.
1801 (is_watchpoint): Likewise.
1802 (is_no_memory_software_watchpoint): Likewise.
1803 (is_catchpoint): Likewise.
1804 (breakpoint_1): Make FILTER parameter's return type bool.
1805 is_masked_watchpoint): Change return type to bool.
1806 (save_breakpoints): Make FILTER parameter's return type bool.
1807 * breakpoint.h (is_breakpoint): Change return type to bool.
1808 (is_watchpoint): Likewise.
1809 (is_catchpoint): Likewise.
1810 (is_tracepoint): Likewise.
1811
18122019-07-10 Tom Tromey <tom@tromey.com>
1813
1814 * defs.h: Don't include gdbarch.h.
1815 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1816 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1817 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1818 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1819 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1820 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1821 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1822 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1823 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1824 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1825 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1826 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1827 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1828 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1829 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1830 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1831 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1832 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1833 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1834 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1835 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1836 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1837 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1838 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1839 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1840 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1841 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1842
18432019-07-10 Tom Tromey <tromey@adacore.com>
1844
1845 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1846 * breakpoint.c (init_ada_exception_breakpoint): Register as
1847 bp_catchpoint.
1848 (print_one_breakpoint_location, print_one_breakpoint): Use
1849 is_ada_exception_catchpoint.
1850 * ada-lang.c (class ada_catchpoint_location): Pass
1851 bp_loc_software_breakpoint to bp_location constructor.
1852 (is_ada_exception_catchpoint): New function.
1853
18542019-07-10 Tom Tromey <tromey@adacore.com>
1855
1856 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1857 VEC.
1858 (struct arm_exidx_entry): New method operator<.
1859 (struct arm_exidx_data) <section_maps>: Change type.
1860 (arm_exidx_data_free): Remove.
1861 (arm_exidx_data_key): Change type. Move lower.
1862 (arm_exidx_new_objfile): Update.
1863 (arm_compare_exidx_entries): Remove.
1864 (arm_find_exidx_entry, _initialize_arm_tdep)
1865
18662019-07-10 Tom Tromey <tromey@adacore.com>
1867
1868 * solib-spu.c (ocl_program_data_key): Change type.
1869 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1870 Update.
1871
18722019-07-10 Tom Tromey <tromey@adacore.com>
1873
1874 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1875 (struct solib_aix_inferior_data) <library_list>: Change type.
1876 (solib_aix_inferior_data_handle): Change type.
1877 (get_solib_aix_inferior_data): Update.
1878 (solib_aix_free_library_list): Remove.
1879 (library_list_start_library): Update.
1880 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1881 return type.
1882 (solib_aix_get_library_list)
1883 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1884 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1885
18862019-07-10 Tom Tromey <tromey@adacore.com>
1887
1888 * solib-dsbt.c (struct dsbt_info): Add initializers.
1889 (solib_dsbt_pspace_data): Change type.
1890 (dsbt_pspace_data_cleanup): Remove.
1891 (get_dsbt_info, _initialize_dsbt_solib): Update.
1892
18932019-07-10 Tom Tromey <tromey@adacore.com>
1894
1895 * spu-tdep.c (spu_overlay_data): Change type.
1896 (spu_get_overlay_table, spu_overlay_new_objfile)
1897 (_initialize_spu_tdep): Update.
1898
18992019-07-10 Tom Tromey <tromey@adacore.com>
1900
1901 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1902 destructor.
1903 (dbx_objfile_data_key): Change type and declare later.
1904 (DBX_SYMFILE_INFO): Rewrite.
1905 * dbxread.c (dbx_objfile_data_key): Change type.
1906 (dbx_symfile_init): Update.
1907 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1908 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1909 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1910
19112019-07-10 Tom Tromey <tromey@adacore.com>
1912
1913 * jit.c (jit_program_space_key): Change type. Move lower.
1914 (get_jit_program_space_data): Update.
1915 (jit_program_space_data_cleanup): Remove.
1916 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1917 Update.
1918 (struct jit_program_space_data): Add initializers.
1919
19202019-07-10 Tom Tromey <tromey@adacore.com>
1921
1922 * solib-darwin.c (struct darwin_info): Add initializers.
1923 (solib_darwin_pspace_data): Change type.
1924 (darwin_pspace_data_cleanup): Remove.
1925 (get_darwin_info, _initialize_darwin_solib): Update.
1926
19272019-07-10 Tom Tromey <tromey@adacore.com>
1928
1929 * remote-sim.c (struct sim_inferior_data): Add initializers,
1930 constructor, and destructor.
1931 (sim_inferior_data_key): Change type. Move lower.
1932 (check_for_duplicate_sim_descriptor): Update.
1933 (get_sim_inferior_data): Use new. Update.
1934 (~sim_inferior_data_cleanup): Rename from
1935 sim_inferior_data_cleanup. Simplify.
1936 (gdbsim_close_inferior, simulator_command)
1937 (sim_command_completer, _initialize_remote_sim): Update.
1938 (next_pid, INITIAL_PID): Move earlier.
1939
19402019-07-10 Tom Tromey <tromey@adacore.com>
1941
1942 * python/python-internal.h (create_thread_object): Return
1943 gdbpy_ref.
1944 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1945 * python/py-inferior.c (struct threadlist_entry): Add
1946 constructor.
1947 <thread_obj>: Now a gdbpy_ref.
1948 (thread_to_thread_object): Update.
1949 (add_thread_object): Use new.
1950 (delete_thread_object): Use delete.
1951 (infpy_threads): Update.
1952 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1953 GIL.
1954
19552019-07-10 Tom Tromey <tromey@adacore.com>
1956
1957 * valops.c (value_cast): Specialize error message for Ada.
1958
19592019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1960
1961 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1962
19632019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1964
1965 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1966 bpstat_should_step): Return bool, adjust comments.
1967 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1968 bpstat_should_step): Likewise.
1969
19702019-07-10 Alan Hayward <alan.hayward@arm.com>
1971
1972 * features/Makefile: Use feature target descriptions for Arm.
1973 * features/arm/arm-core.c: Generate new file.
1974 * features/arm/arm-fpa.c: Likewise.
1975 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1976 * features/arm/arm-m-profile.c: Likewise.
1977 * features/arm/arm-vfpv2.c: Likewise.
1978 * features/arm/arm-vfpv3.c: Likewise.
1979 * features/arm/xscale-iwmmxt.c: Likewise.
1980 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1981
19822019-07-10 Alan Hayward <alan.hayward@arm.com>
1983
1984 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1985 ptrace earlier.
1986
19872019-07-10 Alan Hayward <alan.hayward@arm.com>
1988
1989 * features/aarch64-pauth.c: Regenerate.
1990
19912019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
1992
1993 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1994 bool.
1995 (bpstat_what): Use false instead of 0.
1996
19972019-07-09 Pedro Alves <palves@redhat.com>
1998
1999 * break-catch-throw.c (is_exception_catchpoint): New.
2000 * breakpoint.c (print_one_breakpoint_location): New parameter
2001 'raw_loc'. Handle it. Use
2002 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2003 looking at the breakpoint's type.
2004 (print_one_breakpoint): If handling "maint info breakpoints", also
2005 print locations of exception catchpoints.
2006 * breakpoint.h (is_exception_catchpoint): Declare.
2007
20082019-07-09 Pedro Alves <palves@redhat.com>
2009
2010 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2011 "addr" field.
2012 (allocate_location_exception_catchpoint): New.
2013 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2014 (initialize_throw_catchpoint_ops): Install
2015 allocate_location_exception_catchpoint as allocate_location
2016 method.
2017 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2018 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2019 bp_loc_other.
2020 (breakpoint_address_is_meaningful): Delete.
2021 (bl_address_is_meaningful): New.
2022 (breakpoint_locations_match): Adjust comment.
2023 (bp_location_from_bp_type): New, factored out of...
2024 (bp_location::bp_location(breakpoint *)): ... this.
2025 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2026 factored out of...
2027 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2028 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2029 breakpoint_address_is_meaningful.
2030 (bp_locations_compare): Adjust comment.
2031 (update_global_location_list): Use bl_address_is_meaningful
2032 instead of breakpoint_address_is_meaningful.
2033 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2034 explicit.
2035 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2036 * python/py-breakpoint.c (bppy_get_location): No longer check
2037 whether location is null.
2038
20392019-07-09 Pedro Alves <palves@redhat.com>
2040
2041 PR c++/15468
2042 * breakpoint.c (print_one_breakpoint_location): Remove
2043 single-location assert.
2044
20452019-07-09 Tom Tromey <tom@tromey.com>
2046
2047 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2048 * configure: Rebuild.
2049 * configure.ac: Change common to gdbsupport.
2050 * gdbsupport: Rename from common.
2051 * acinclude.m4: Change common to gdbsupport.
2052 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2053 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2054 gdbsupport.
2055 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2056 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2057 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2058 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2059 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2060 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2061 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2062 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2063 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2064 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2065 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2066 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2067 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2068 coff-pe-read.c, command.h, compile/compile-c-support.c,
2069 compile/compile-c.h, compile/compile-cplus-symbols.c,
2070 compile/compile-cplus-types.c, compile/compile-cplus.h,
2071 compile/compile-loc2c.c, compile/compile.c, completer.c,
2072 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2073 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2074 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2075 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2076 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2077 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2078 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2079 features/aarch64-core.c, features/aarch64-fpu.c,
2080 features/aarch64-pauth.c, features/aarch64-sve.c,
2081 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2082 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2083 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2084 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2085 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2086 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2087 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2088 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2089 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2090 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2091 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2092 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2093 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2094 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2095 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2096 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2097 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2098 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2099 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2100 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2101 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2102 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2103 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2104 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2105 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2106 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2107 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2108 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2109 minsyms.c, mips-linux-tdep.c, namespace.h,
2110 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2111 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2112 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2113 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2114 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2115 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2116 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2117 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2118 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2119 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2120 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2121 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2122 procfs.c, producer.c, progspace.h, psymtab.h,
2123 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2124 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2125 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2126 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2127 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2128 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2129 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2130 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2131 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2132 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2133 target-memory.c, target.c, target.h, target/waitstatus.c,
2134 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2135 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2136 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2137 unittests/array-view-selftests.c,
2138 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2139 unittests/common-utils-selftests.c,
2140 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2141 unittests/format_pieces-selftests.c,
2142 unittests/function-view-selftests.c,
2143 unittests/lookup_name_info-selftests.c,
2144 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2145 unittests/mkdir-recursive-selftests.c,
2146 unittests/observable-selftests.c,
2147 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2148 unittests/parse-connection-spec-selftests.c,
2149 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2150 unittests/scoped_fd-selftests.c,
2151 unittests/scoped_mmap-selftests.c,
2152 unittests/scoped_restore-selftests.c,
2153 unittests/string_view-selftests.c, unittests/style-selftests.c,
2154 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2155 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2156 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2157 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2158 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2159 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2160
21612019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2162
2163 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2164 bool value.
2165 (decode_digits_ordinary): Set explicit_line field in sal.
2166 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2167 symtab_and_line that was set on an explicit line number in
2168 assembler code. Do always update the recorded symtab and line if
2169 we do skip the prologue.
2170
21712019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2172
2173 * breakpoint.c (set_breakpoint_location_function): Remove
2174 explicit_loc parameter.
2175 (momentary_breakpoint_from_master): Update call to
2176 set_breakpoint_location_function.
2177 (add_location_to_breakpoint): Likewise.
2178
21792019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2180
2181 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2182 required features based on default bfd type when no specific bfd
2183 is present.
2184
21852019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2186
2187 * NEWS: Mention that GDB printf and eval commands can now print
2188 C-style and Ada-style convenience var strings without
2189 calling the inferior.
2190 * printcmd.c (printf_c_string): Locally print GDB internal var
2191 instead of transiting via the inferior.
2192 (printf_wide_c_string): Likewise.
2193
21942019-07-04 Alan Hayward <alan.hayward@arm.com>
2195
2196 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2197
21982019-07-04 Tom Tromey <tom@tromey.com>
2199
2200 PR tui/24724:
2201 * tui/tui-winsource.c (tui_clear_source_content): Update.
2202 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2203 (tui_update_breakpoint_info): Update.
2204 (tui_set_exec_info_content): Update.
2205 * tui/tui-source.c (tui_set_source_content_nil): Update.
2206 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2207 has_break.
2208 * tui/tui-data.h (enum tui_bp_flag): New.
2209 (tui_bp_flags): New enum flags type.
2210 (struct tui_source_element) <break_mode>: Change type. Rename
2211 from has_break.
2212 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2213 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2214 constants.
2215 * tui/tui-winsource.h: Fix comment.
2216
22172019-07-04 Alan Hayward <alan.hayward@arm.com>
2218
2219 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2220 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2221 (store_fpregs_to_thread)
2222 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2223 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2224 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2225 (IWMMXT_REGS_SIZE): Add define.
2226 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2227 (fetch_vfp_regs, store_vfp_regs)
2228 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2229 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2230
22312019-07-04 Alan Hayward <alan.hayward@arm.com>
2232
2233 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2234 defines.
2235 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2236 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2237 (ARM_INT_REGISTER_SIZE): ...to this.
2238 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2239 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2240 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2241 (arm_linux_collect_gregset, supply_nwfpe_register)
2242 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2243 defines.
2244 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2245 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2246 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2247 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2248 (arm_return_in_memory, arm_store_return_value)
2249 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2250 (arm_record_ld_st_multiple): Likewise.
2251 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2252 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2253
22542019-07-04 Alan Hayward <alan.hayward@arm.com>
2255
2256 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2257 AARCH64_DISPLACED_MODIFIED_INSNS.
2258 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2259 (aarch64_displaced_step_copy_insn): Likewise.
2260 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2261 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2262 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2263 ARM_DISPLACED_MODIFIED_INSNS.
2264 * arm-tdep.c (arm_gdbarch_init): Likewise.
2265 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2266 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2267 (struct arm_displaced_step_closure): Use
2268 ARM_DISPLACED_MODIFIED_INSNS.
2269
22702019-07-04 Alan Hayward <alan.hayward@arm.com>
2271
2272 * features/Makefile: Remove unused xml files.
2273 * features/aarch64.xml: Remove.
2274 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2275 * features/i386/amd64-avx-avx512.xml: Remove.
2276 * features/i386/amd64-avx-linux.xml: Remove.
2277 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2278 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2279 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2280 * features/i386/amd64-avx-mpx.xml: Remove.
2281 * features/i386/amd64-avx.xml: Remove.
2282 * features/i386/amd64-linux.xml: Remove.
2283 * features/i386/amd64-mpx-linux.xml: Remove.
2284 * features/i386/amd64-mpx.xml: Remove.
2285 * features/i386/amd64.xml: Remove.
2286 * features/i386/i386-avx-avx512-linux.xml: Remove.
2287 * features/i386/i386-avx-avx512.xml: Remove.
2288 * features/i386/i386-avx-linux.xml: Remove.
2289 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2290 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2291 * features/i386/i386-avx-mpx-linux.xml: Remove.
2292 * features/i386/i386-avx-mpx.xml: Remove.
2293 * features/i386/i386-avx.xml: Remove.
2294 * features/i386/i386-linux.xml: Remove.
2295 * features/i386/i386-mmx-linux.xml: Remove.
2296 * features/i386/i386-mmx.xml: Remove.
2297 * features/i386/i386-mpx-linux.xml: Remove.
2298 * features/i386/i386-mpx.xml: Remove.
2299 * features/i386/i386.xml: Remove.
2300 * features/i386/x32-avx-avx512-linux.xml: Remove.
2301 * features/i386/x32-avx-linux.xml: Remove.
2302 * features/i386/x32-linux.xml: Remove.
2303
23042019-07-04 Alan Hayward <alan.hayward@arm.com>
2305
2306 * regformats/aarch64.dat: Remove.
2307 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2308 * regformats/i386/amd64-avx-linux.dat: Remove.
2309 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2310 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2311 * regformats/i386/amd64-linux.dat: Remove.
2312 * regformats/i386/amd64-mpx-linux.dat: Remove.
2313 * regformats/i386/amd64.dat: Remove.
2314 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2315 * regformats/i386/i386-avx-linux.dat: Remove.
2316 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2317 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2318 * regformats/i386/i386-linux.dat: Remove.
2319 * regformats/i386/i386-mmx-linux.dat: Remove.
2320 * regformats/i386/i386-mpx-linux.dat: Remove.
2321 * regformats/i386/i386.dat: Remove.
2322 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2323 * regformats/i386/x32-avx-linux.dat: Remove.
2324 * regformats/i386/x32-linux.dat: Remove.
2325
23262019-07-04 Alan Hayward <alan.hayward@arm.com>
2327
2328 * aarch64-tdep.c: Remove xml self tests.
2329 * amd64-linux-tdep.c: Likewise.
2330 * amd64-tdep.c: Likewise.
2331 * i386-linux-tdep.c: Likewise.
2332 * i386-tdep.c: Likewise.
2333
23342019-07-03 Pedro Alves <palves@redhat.com>
2335
2336 PR cli/24732
2337 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2338 (pipe_cmd_option_defs): New.
2339 (make_pipe_cmd_options_def_group): New.
2340 (pipe_command): Use gdb::option::process_options.
2341 (pipe_command_completer): New function.
2342 (_initialize_cli_cmds): Install completer for "pipe" command.
2343
23442019-07-03 Pedro Alves <palves@redhat.com>
2345
2346 * cli/cli-option.c (union option_value) <string>: New field.
2347 (struct option_def_and_value): Add ctor, move ctor, dtor and
2348 use DISABLE_COPY_AND_ASSIGN.
2349 (option_def_and_value::clear_value): New.
2350 (parse_option, save_option_value_in_ctx, get_val_type_str)
2351 (add_setshow_cmds_for_options): Handle var_string.
2352 * cli-option.h (union option_def::var_address) <string>: New
2353 field.
2354 (struct string_option_def): New.
2355 * maint-test-options.c (struct test_options_opts): Add default
2356 ctor and use DISABLE_COPY_AND_ASSIGN.
2357 <string_opt>: New field.
2358 (test_options_opts::~test_options_opts): New.
2359 (test_options_opts::dump): Also dump "-string".
2360 (test_options_option_defs): Install "string.
2361
23622019-07-03 Pedro Alves <palves@redhat.com>
2363
2364 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2365 option_value with a null enumeration.
2366 (complete_options): Save the option values in the context.
2367 (save_option_value_in_ctx): New, factored out from ...
2368 (process_options): ... here.
2369 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2370 of the function.
2371 * maint-test-options.c (test_options_opts::dump): New, factored
2372 out from ...
2373 (maintenance_test_options_command_mode): ... here.
2374 (maintenance_test_options_command_completion_result): Delete.
2375 (maintenance_test_options_command_completion_text): Update
2376 comment.
2377 (maintenance_show_test_options_completion_result): Change
2378 prototype. Just print
2379 maintenance_test_options_command_completion_text.
2380 (save_completion_result): New.
2381 (maintenance_test_options_completer_mode): Pass options context to
2382 complete_options, and then save a dump.
2383 (_initialize_maint_test_options): Use add_cmd to install "maint
2384 show test-options-completion-result".
2385
23862019-07-03 Pedro Alves <palves@redhat.com>
2387
2388 * NEWS (New commands): Mention "with" and "maint with".
2389 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2390 (with_command, with_command_completer): New.
2391 (pipe_command): Adjust to new repeat_previous
2392 interface.
2393 (_initialize_cli_cmds): Install the "with" command and its "w"
2394 alias.
2395 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2396 declarations.
2397 * cli/cli-setshow.c (parse_cli_var_uinteger)
2398 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2399 argument strings for all var_types.
2400 (get_setshow_command_value_string): New, factored out from ...
2401 (do_show_command): ... this.
2402 * cli/cli-setshow.h: Include <string>.
2403 (get_setshow_command_value_string): Declare.
2404 * command.h (repeat_previous): Now returns const char *. Adjust
2405 comment.
2406 * maint.c: Include "cli/cli-cmds.h".
2407 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2408 (_initialize_maint_cmds): Register the "maintenance with" command.
2409 * top.c (repeat_previous): Move bits from pipe_command here:
2410 Return the saved command line, if any; error out if there's no
2411 command to relaunch.
2412
24132019-07-03 Pedro Alves <palves@redhat.com>
2414
2415 * NEWS (New commands): Mention "maint set/show test-settings"
2416 instead of "maint test-settings".
2417 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2418 (maintenance_test_settings_set_list): Rename to ...
2419 (maintenance_set_test_settings_list): ... this.
2420 (maintenance_test_settings_show_list): Rename to ...
2421 (maintenance_show_test_settings_list): ... this.
2422 (maintenance_test_settings_cmd): Delete.
2423 (maintenance_test_settings_set_cmd): ...
2424 (maintenance_set_test_settings_cmd): ... this.
2425 (maintenance_test_settings_show_cmd): ...
2426 (maintenance_show_test_settings_cmd): ... this.
2427 (maintenance_test_settings_show_value_cmd):
2428 (maintenance_show_test_settings_value_cmd): ... this.
2429 (_initialize_maint_test_settings): No longer install the "maint
2430 test-settings" prefix command. Rename "maint test-settings set"
2431 to "maint set test-settings", and "maint test-settings show" to
2432 "maint show test-settings". Adjust all subcommands.
2433
24342019-07-03 Pedro Alves <palves@redhat.com>
2435
2436 * maint-test-settings.c: Fix file's intro comment. Replace all
2437 references to "test-options" with references to "test-settings",
2438 in comments.
2439
24402019-07-03 Pedro Alves <palves@redhat.com>
2441
2442 * maint-test-settings.c (maintenance_test_settings_xxx)
2443 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2444 New.
2445 (maintenance_test_settings_enums): Use them.
2446 (maintenance_test_settings_enum): Default to
2447 maintenance_test_settings_xxx.
2448 (_initialize_maint_test_settings): Initialize
2449 MAINTENANCE_TEST_SETTINGS_FILENAME.
2450
24512019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2452
2453 * breakpoint.h (remove_breakpoints_inf): Change return type to
2454 void, move function documentation here.
2455 * breakpoint.c (remove_breakpoints_inf): Change return type to
2456 void, move function documentation to header.
2457
24582019-07-02 Pedro Alves <palves@redhat.com>
2459
2460 * NEWS (Completion improvements): Mention "info threads".
2461 * thread.c (struct info_threads_opts, info_threads_option_defs)
2462 (make_info_threads_options_def_group): New.
2463 (info_threads_command): Use gdb::option::process_options.
2464 (info_threads_command_completer): New.
2465 (_initialize_thread): Use gdb::option::build_help to build the
2466 help text for "info threads".
2467
24682019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2469
2470 * defs.h (generic_load): Move from here...
2471 * symfile.h (generic_load): ... to here. Rename name parameter
2472 to args.
2473 * symfile.c (generic_load): Add comment.
2474
24752019-07-01 Tom Tromey <tromey@adacore.com>
2476
2477 * dwarf2read.c
2478 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2479 declaration of without_params. Fix formatting.
2480
24812019-07-01 Tom Tromey <tromey@adacore.com>
2482
2483 * ada-exp.y (find_primitive_type): Update.
2484 * ada-lang.h (ada_lookup_symbol): Update.
2485 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2486 parameter.
2487 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2488
24892019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2490
2491 PR breakpoints/24541
2492 * gdbarch.c: Regenerate.
2493 * gdbarch.h: Regenerate.
2494 * gdbarch.sh: Add 'stap_adjust_register'.
2495 * i386-tdep.c: Include '<unordered_set>'.
2496 (i386_stap_adjust_register): New function.
2497 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2498 * stap-probe.c (stap_parse_register_operand): Call
2499 'gdbarch_stap_adjust_register'.
2500
25012019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2502
2503 PR python/24742
2504 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2505 * python/python.c (do_start_initialization): Use 'xmalloc'
2506 instead of 'PyMem_Malloc'.
2507
25082019-06-28 Tom Tromey <tromey@adacore.com>
2509
2510 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2511 for Ada.
2512
25132019-06-27 Tom Tromey <tromey@adacore.com>
2514
2515 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2516 objfile_key.
2517 (arm_find_mapping_symbol, arm_record_special_symbol)
2518 (_initialize_arm_tdep): Update.
2519 (arm_objfile_data_free): Remove.
2520
25212019-06-27 Tom Tromey <tromey@adacore.com>
2522
2523 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2524 to cp_print_static_field.
2525
25262019-06-26 Tom Tromey <tromey@adacore.com>
2527
2528 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2529 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2530 declare.
2531
25322019-06-26 Alan Hayward <alan.hayward@arm.com>
2533
2534 * features/aarch64-core.c (create_feature_aarch64_core):
2535 Regenerate.
2536 * features/aarch64-core.xml: Add cpsr flags.
2537
25382019-06-26 Alan Hayward <alan.hayward@arm.com>
2539
2540 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2541 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2542
25432019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2544
2545 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2546 field.
2547 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2548 use.
2549 (arm_record_special_symbol): Don't insert new symbol in sorted
2550 position, push it at the end.
2551
25522019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2553
2554 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2555 (arm_mapping_symbol_s): Remove.
2556 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2557 (arm_mapping_symbol_vec): New typedef.
2558 (struct arm_per_objfile): Add constructor.
2559 <section_maps>: Change type to
2560 std::unique_ptr<arm_mapping_symbol_vec[]>.
2561 (arm_compare_mapping_symbols): Remove.
2562 (arm_find_mapping_symbol): Adjust to section_maps type change.
2563 (arm_objfile_data_free): Call delete on arm_per_objfile.
2564 (arm_record_special_symbol): Adjust to section_maps type change.
2565 Allocate arm_per_objfile with new.
2566
25672019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2568
2569 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2570 with the command prefix.
2571
25722019-06-25 Tom Tromey <tom@tromey.com>
2573
2574 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2575 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2576
25772019-06-25 Tom Tromey <tom@tromey.com>
2578
2579 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2580 type.
2581 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2582 protected.
2583
25842019-06-25 Tom Tromey <tom@tromey.com>
2585
2586 * tui/tui-winsource.c
2587 (tui_source_window_base::set_is_exec_point_at): Add check against
2588 LOA_ADDRESS.
2589
25902019-06-25 Tom Tromey <tom@tromey.com>
2591
2592 * tui/tui-source.c (tui_set_source_content): Don't check before
2593 xfree.
2594 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2595
25962019-06-25 Tom Tromey <tom@tromey.com>
2597
2598 * tui/tui-winsource.h (tui_update_source_window_as_is)
2599 (tui_alloc_source_buffer, tui_line_is_displayed)
2600 (tui_addr_is_displayed): Change type of win_info.
2601 * tui/tui-winsource.c (tui_update_source_window_as_is)
2602 (tui_clear_source_content, tui_show_source_line)
2603 (tui_show_source_content, tui_source_window_base::refill)
2604 (tui_source_window_base::set_is_exec_point_at)
2605 (tui_source_window_base::set_is_exec_point_at)
2606 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2607 (tui_alloc_source_buffer, tui_line_is_displayed)
2608 (tui_addr_is_displayed): Change type of win_info. Update.
2609 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2610 (tui_source_window_base::do_make_visible_with_new_height):
2611 Update.
2612 * tui/tui-source.c (tui_set_source_content)
2613 (tui_set_source_content_nil)
2614 (tui_source_window::do_scroll_vertical): Update.
2615 * tui/tui-layout.c (show_layout): Update.
2616 * tui/tui-disasm.c (tui_set_disassem_content)
2617 (tui_disasm_window::do_scroll_vertical): Update.
2618 * tui/tui-data.h (tui_win_content): Remove.
2619 (struct tui_gen_win_info) <content, content_size>: Remove.
2620 (struct tui_source_element): Add initializers and destructor.
2621 (union tui_which_element, struct tui_win_element): Remove.
2622 (struct tui_source_window_base) <content>: New field.
2623 (struct tui_data_window): Remove destructor.
2624 (tui_alloc_content, tui_free_win_content)
2625 (tui_free_all_source_wins_content): Don't declare.
2626 * tui/tui-data.c (tui_initialize_static_data): Update.
2627 (init_content_element, tui_alloc_content): Remove.
2628 (~tui_gen_win_info): Update.
2629 (~tui_data_window, tui_free_all_source_wins_content)
2630 (tui_free_win_content, free_content, free_content_elements):
2631 Remove.
2632
26332019-06-25 Tom Tromey <tom@tromey.com>
2634
2635 * tui/tui-winsource.h (tui_clear_source_content)
2636 (tui_erase_source_content, tui_show_source_content): Change type
2637 of win_info.
2638 * tui/tui-winsource.c (tui_clear_source_content)
2639 (tui_erase_source_content, tui_show_source_content): Change type
2640 of win_info.
2641 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2642 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2643 win_info.
2644 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2645 win_info.
2646 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2647
26482019-06-25 Tom Tromey <tom@tromey.com>
2649
2650 * tui/tui-winsource.c (tui_clear_source_content)
2651 (tui_source_window_base::set_is_exec_point_at): Update.
2652 * tui/tui-source.c (tui_set_source_content_nil): Update.
2653 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2654 a bool.
2655 * tui/tui-data.c (init_content_element): Update.
2656
26572019-06-25 Tom Tromey <tom@tromey.com>
2658
2659 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2660 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2661 * tui/tui-layout.c (init_and_make_win): Update.
2662 * tui/tui.h (enum tui_win_type): Update.
2663 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2664 tui_win_is_auxillary.
2665 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2666 tui_win_is_auxillary.
2667
26682019-06-25 Tom Tromey <tom@tromey.com>
2669
2670 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2671 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2672 (tui_delete_data_content_windows, tui_display_all_data)
2673 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2674 Update.
2675 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2676 * tui/tui-regs.c (tui_last_regs_line_no)
2677 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2678 (tui_show_registers): Update.
2679 (tui_show_register_group): Return void. Update.
2680 (tui_display_registers_from, tui_display_reg_element_at_line)
2681 (tui_display_registers_from_line, tui_check_register_values):
2682 Update.
2683 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2684 member.
2685 (struct tui_data_window) <regs_content>: Now a std::vector.
2686 <regs_content_count>: Remove.
2687 (tui_add_content_elements, tui_free_data_content): Don't declare.
2688 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2689 (init_content_element): Remove DATA_WIN case. Add assert.
2690 (tui_add_content_elements): Remove.
2691 (tui_data_window): Update.
2692 (tui_free_data_content): Remove.
2693 (free_content_elements): Remove DATA_WIN case.
2694
26952019-06-25 Tom Tromey <tom@tromey.com>
2696
2697 * tui/tui-data.c (tui_data_item_window): Update.
2698 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2699 * tui/tui-windata.c (tui_display_all_data)
2700 (tui_display_data_from_line): Update.
2701 (tui_check_data_values): Remove.
2702 * tui/tui-regs.c (tui_show_register_group)
2703 (tui_display_reg_element_at_line): Update.
2704 * tui/tui-hooks.c (tui_register_changed)
2705 (tui_refresh_frame_and_register_information): Call
2706 tui_check_register_values.
2707 * tui/tui-data.h (struct tui_data_window) <data_content,
2708 data_content_count, data_type>: Remove.
2709 (enum tui_data_type): Remove.
2710
2711 * tui/tui-data.c (tui_data_window::clear_detail)
2712 (~tui_data_window): Update.
2713
27142019-06-25 Tom Tromey <tom@tromey.com>
2715
2716 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2717 declare.
2718 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2719 Rename from tui_first_data_item_displayed. Update.
2720 (tui_data_window::refresh_all)
2721 (tui_data_window::do_scroll_vertical): Update.
2722 * tui/tui-data.h (struct tui_data_window)
2723 <first_data_item_displayed>: Declare new method.
2724
27252019-06-25 Tom Tromey <tom@tromey.com>
2726
2727 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2728 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2729 contents...
2730 (tui_initialize_static_data): ...here.
2731
27322019-06-25 Tom Tromey <tom@tromey.com>
2733
2734 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2735 (tui_display_registers_from, tui_check_register_values): Update.
2736 (tui_display_register): Remove win_info parameter; update.
2737 (tui_get_register): Change type of parameters.
2738 * tui/tui-data.h (struct tui_data_element): Remove.
2739 (union tui_which_element) <data>: Remove.
2740 <data_window>: Change type.
2741 (struct tui_data_item_window): New.
2742 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2743 case. Add assert.
2744 (~tui_data_item_window): New destructor.
2745 (free_content_elements): Remove DATA_ITEM_WIN case.
2746
27472019-06-25 Tom Tromey <tom@tromey.com>
2748
2749 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2750 Remove.
2751
27522019-06-25 Tom Tromey <tom@tromey.com>
2753
2754 * tui/tui-data.h (struct tui_command_element): Remove.
2755 (union tui_which_element) <command>: Remove.
2756 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2757 assert.
2758 (free_content_elements): Remove CMD_WIN case.
2759
27602019-06-25 Tom Tromey <tom@tromey.com>
2761
2762 * tui/tui-layout.c (tui_set_layout): Update.
2763 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2764 * tui/tui-data.c (layout_def): Update.
2765
27662019-06-25 Tom Tromey <tom@tromey.com>
2767
2768 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2769 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2770 (tui_source_window_base::set_new_height): Update.
2771 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2772 Update.
2773 (tui_set_locator_fullname, tui_set_locator_info)
2774 (tui_show_frame_info): Update.
2775 * tui/tui-source.c (tui_set_source_content)
2776 (tui_source_is_displayed): Update.
2777 * tui/tui-layout.c (show_source_disasm_command, show_data)
2778 (show_source_or_disasm_and_command): Update.
2779 * tui/tui-disasm.c (tui_set_disassem_content)
2780 (tui_get_begin_asm_address): Update.
2781 * tui/tui-data.h (struct tui_locator_element): Remove.
2782 (union tui_which_element) <locator>: Remove.
2783 (struct tui_locator_window): New.
2784 (tui_locator_win_info_ptr): Change return type.
2785 * tui/tui-data.c (_locator): Change type.
2786 (tui_locator_win_info_ptr): Change return type.
2787 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2788 (tui_alloc_content): Add assert.
2789
27902019-06-25 Tom Tromey <tom@tromey.com>
2791
2792 * tui/tui-winsource.c
2793 (tui_exec_info_window::maybe_allocate_content): New method.
2794 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2795 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2796 (make_source_or_disasm_window): Add cast.
2797 * tui/tui-data.h (union tui_which_element) <simple_string>:
2798 Remove.
2799 (struct tui_source_info): New.
2800 (struct tui_source_window_base) <execution_info>: Change type.
2801 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2802 case, and add assert.
2803 (tui_alloc_content): Add assert.
2804
28052019-06-25 Tom Tromey <tom@tromey.com>
2806
2807 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2808 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2809 * tui/tui-data.c (tui_alloc_win_info): Remove.
2810
28112019-06-25 Tom Tromey <tom@tromey.com>
2812
2813 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2814 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2815 can_highlight.
2816
28172019-06-25 Tom Tromey <tom@tromey.com>
2818
2819 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2820 make_visible_with_new_height method.
2821 (tui_win_info::make_visible_with_new_height): New method.
2822 (tui_source_window_base::do_make_visible_with_new_height)
2823 (tui_data_window::do_make_visible_with_new_height)
2824 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2825 (make_visible_with_new_height): Remove.
2826 (tui_resize_all, tui_adjust_win_heights): Use
2827 make_visible_with_new_height method.
2828 * tui/tui-data.h (struct tui_win_info)
2829 <do_make_visible_with_new_height, make_visible_with_new_height>:
2830 New methods.
2831 (struct tui_source_window_base, struct tui_data_window)
2832 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2833 methods.
2834
28352019-06-25 Tom Tromey <tom@tromey.com>
2836
2837 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2838 method.
2839 (update_tab_width): Call update_tab_width method.
2840 * tui/tui-data.h (struct tui_win_info)
2841 (struct tui_source_window_base) <update_tab_width>: New methods.
2842
28432019-06-25 Tom Tromey <tom@tromey.com>
2844
2845 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2846 parameter.
2847 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2848 parameter.
2849 (tui_gen_win_info::make_visible): Update.
2850 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2851 parameter.
2852 * tui/tui-data.h (enum tui_box): New enum.
2853 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2854
28552019-06-25 Tom Tromey <tom@tromey.com>
2856
2857 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2858 init_and_make_win for EXEC_INFO_WIN.
2859 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2860 longer inline.
2861 (struct tui_win_info) <~tui_win_info>: Inline.
2862 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2863 Don't declare.
2864 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2865 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2866 Remove.
2867 (tui_initialize_static_data): Update.
2868 (~tui_gen_win_info): Handle more cleanup here.
2869 (~tui_source_window_base): Delete "execution_info".
2870 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2871
28722019-06-25 Tom Tromey <tom@tromey.com>
2873
2874 * tui/tui-layout.c (make_command_window): Don't set
2875 can_highlight.
2876 (show_source_disasm_command): Call the reset method.
2877 (show_data): Don't set can_highlight. Call the reset method.
2878 (tui_gen_win_info::reset): Rename from init_gen_win_info
2879 (init_and_make_win): Simplify. Return tui_gen_win_info.
2880 (show_source_or_disasm_and_command): Call the reset method.
2881 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2882 (struct tui_cmd_window): Set can_highlight.
2883
28842019-06-25 Tom Tromey <tom@tromey.com>
2885
2886 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2887 from make_visible.
2888 (tui_make_visible, tui_make_invisible): Rewrite.
2889 (tui_win_info::make_visible): Remove.
2890 (tui_source_window_base::make_visible): Update.
2891 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2892 method. Moved from...
2893 (struct tui_win_info) <make_visible>: ...here.
2894
28952019-06-25 Tom Tromey <tom@tromey.com>
2896
2897 * tui/tui-winsource.c
2898 (tui_source_window_base::do_scroll_horizontal): Remove direction
2899 parameter.
2900 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2901 direction parameter.
2902 * tui/tui-win.c (tui_win_info::forward_scroll)
2903 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2904 (tui_win_info::right_scroll): Update.
2905 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2906 direction parameter.
2907 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2908 direction parameter.
2909 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2910 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2911 Remove direction parameter.
2912 (struct tui_source_window_base, struct tui_source_window)
2913 (struct tui_disasm_window, struct tui_data_window)
2914 (struct tui_cmd_window): Update.
2915
29162019-06-25 Tom Tromey <tom@tromey.com>
2917
2918 * tui/tui-winsource.h (tui_set_exec_info_content)
2919 (tui_show_exec_info_content, tui_erase_exec_info_content)
2920 (tui_clear_exec_info_content, tui_update_exec_info): Change
2921 argument to tui_source_window_base.
2922 * tui/tui-winsource.c (tui_set_exec_info_content)
2923 (tui_show_exec_info_content, tui_erase_exec_info_content)
2924 (tui_clear_exec_info_content, tui_update_exec_info): Change
2925 argument to tui_source_window_base.
2926
29272019-06-25 Tom Tromey <tom@tromey.com>
2928
2929 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2930 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2931
29322019-06-25 Tom Tromey <tom@tromey.com>
2933
2934 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2935 check.
2936
29372019-06-25 Tom Tromey <tom@tromey.com>
2938
2939 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2940 type to void.
2941 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2942 type to void.
2943 * tui/tui-source.c (tui_set_source_content): Update.
2944 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2945
29462019-06-25 Tom Tromey <tom@tromey.com>
2947
2948 * tui/tui-win.c (window_name_completer, tui_set_focus)
2949 (tui_all_windows_info): Use name method.
2950 * tui/tui-data.h (struct tui_gen_win_info)
2951 (struct tui_source_window, struct tui_disasm_window)
2952 (struct tui_data_window, struct tui_cmd_window) <name>: New
2953 method.
2954 (tui_win_name): Don't declare.
2955 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2956 (tui_win_name): Remove.
2957
29582019-06-25 Tom Tromey <tom@tromey.com>
2959
2960 * tui/tui-winsource.h (tui_update_source_window)
2961 (tui_update_source_window_as_is): Change parameter type.
2962 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2963 to be a tui_source_window_base.
2964 (tui_update_source_window_as_is): Likewise.
2965 * tui/tui-win.c (make_visible_with_new_height): Update.
2966
29672019-06-25 Tom Tromey <tom@tromey.com>
2968
2969 * tui/tui-winsource.c (tui_erase_source_content)
2970 (tui_show_source_content, tui_show_exec_info_content)
2971 (tui_erase_exec_info_content): Use refresh_window method.
2972 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2973 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2974 from tui_refresh_win.
2975 (tui_data_window::refresh_window): New method.
2976 (tui_win_info::refresh, tui_source_window_base::refresh)
2977 (tui_refresh_all): Use refresh_window method.
2978 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2979 method.
2980 * tui/tui-regs.c (tui_display_register): Call refresh_window
2981 method.
2982 * tui/tui-layout.c (show_source_disasm_command)
2983 (show_source_or_disasm_and_command): Call refresh_window method.
2984 * tui/tui-data.h (struct tui_gen_win_info)
2985 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2986 New method.
2987
29882019-06-25 Tom Tromey <tom@tromey.com>
2989
2990 * tui/tui.c (tui_rl_other_window, tui_enable)
2991 (tui_is_window_visible, tui_get_command_dimension): Update.
2992 * tui/tui-winsource.c (tui_update_source_window_as_is)
2993 (tui_clear_source_content, tui_erase_source_content)
2994 (tui_show_source_line, tui_source_window_base::refill)
2995 (tui_source_window_base::do_scroll_horizontal)
2996 (tui_source_window_base::set_is_exec_point_at)
2997 (tui_update_breakpoint_info, tui_set_exec_info_content)
2998 (tui_alloc_source_buffer, tui_line_is_displayed)
2999 (tui_addr_is_displayed): Update.
3000 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3001 (tui_check_and_display_highlight_if_needed)
3002 (tui_win_info::make_visible, tui_win_info::refresh)
3003 (tui_refresh_all): Update.
3004 * tui/tui-windata.c (tui_first_data_item_displayed)
3005 (tui_delete_data_content_windows, tui_erase_data_content)
3006 (tui_display_all_data, tui_data_window::refresh_all)
3007 (tui_check_data_values): Update.
3008 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3009 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3010 (tui_win_info::backward_scroll, tui_refresh_all_win)
3011 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3012 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3013 (tui_source_window_base::set_new_height)
3014 (tui_data_window::set_new_height)
3015 (make_invisible_and_set_new_height)
3016 (make_visible_with_new_height, new_height_ok)
3017 (parse_scrolling_args): Update.
3018 * tui/tui-stack.c (tui_show_frame_info): Update.
3019 * tui/tui-source.c (tui_set_source_content)
3020 (tui_set_source_content_nil, tui_source_is_displayed)
3021 (tui_source_window::do_scroll_vertical): Update.
3022 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3023 (tui_display_registers_from, tui_display_reg_element_at_line)
3024 (tui_check_register_values, tui_reg_command): Update.
3025 * tui/tui-layout.c (tui_default_win_height)
3026 (show_source_disasm_command, show_data, init_and_make_win)
3027 (show_source_or_disasm_and_command): Update.
3028 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3029 (tui_redisplay_readline, tui_mld_flush)
3030 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3031 (tui_getc): Update.
3032 * tui/tui-disasm.c (tui_set_disassem_content)
3033 (tui_disasm_window::do_scroll_vertical): Update.
3034 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3035 Now virtual.
3036 (struct tui_win_info): Derive from tui_gen_win_info.
3037 <~tui_win_info>: Mark as override.
3038 <generic>: Remove member.
3039 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3040 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3041 (~tui_data_window, ~tui_win_info)
3042 (tui_free_all_source_wins_content): Update.
3043 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3044
30452019-06-25 Tom Tromey <tom@tromey.com>
3046
3047 * tui/tui-layout.c (init_and_make_win): Use new.
3048 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3049 destructor, initializers.
3050 (tui_alloc_generic_win_info): Don't declare.
3051 * tui/tui-data.c (_locator): Add argument to constructor.
3052 (source_win, disasm_win): New globals.
3053 (exec_info): Remove.
3054 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3055 Update.
3056 (tui_alloc_generic_win_info): Remove.
3057 (init_content_element): Use new.
3058 (tui_win_info::tui_win_info): Update.
3059 (free_content_elements) <case DATA_WIN>: Use delete.
3060
30612019-06-25 Tom Tromey <tom@tromey.com>
3062
3063 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3064 * tui/tui-windata.c (tui_first_data_item_displayed)
3065 (tui_delete_data_content_windows): Update.
3066 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3067 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3068 (tui_display_registers_from, tui_check_register_values): Update.
3069 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3070 pointer.
3071 * tui/tui-data.c (init_content_element): Update. Allocate the new
3072 window.
3073 (tui_free_data_content): Update.
3074 (free_content_elements) <case DATA_WIN>: Free the window.
3075
30762019-06-25 Tom Tromey <tom@tromey.com>
3077
3078 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3079 Update.
3080 * tui/tui-layout.c (make_command_window)
3081 (show_source_disasm_command, show_data, init_and_make_win)
3082 (show_source_or_disasm_and_command): Update.
3083 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3084 method.
3085 <can_highight, is_highlighted>: Now bool.
3086 (tui_set_win_highlight): Don't declare.
3087 * tui/tui-data.c (tui_set_win_highlight): Remove.
3088
30892019-06-25 Tom Tromey <tom@tromey.com>
3090
3091 * tui/tui-wingeneral.c (make_visible): Remove check of window
3092 type.
3093
30942019-06-25 Tom Tromey <tom@tromey.com>
3095
3096 * tui/tui-win.c (tui_win_info::max_height)
3097 (tui_cmd_window::max_height): New methods.
3098 (new_height_ok): Call max_height.
3099 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3100 <max_height>: New method.
3101
31022019-06-25 Tom Tromey <tom@tromey.com>
3103
3104 * tui/tui-win.c (tui_source_window_base::set_new_height)
3105 (tui_data_window::set_new_height): New methods.
3106 (make_invisible_and_set_new_height): Call set_new_height method.
3107 * tui/tui-data.h (struct tui_win_info)
3108 (struct tui_source_window_base, struct tui_data_window)
3109 <set_new_height>: New method.
3110
31112019-06-25 Tom Tromey <tom@tromey.com>
3112
3113 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3114 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3115 tui_refresh_data_win.
3116 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3117 method.
3118 (tui_refresh_all_win): Call the refresh_all method.
3119 (tui_set_focus): Likewise.
3120 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3121 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3122 Likewise.
3123
31242019-06-25 Tom Tromey <tom@tromey.com>
3125
3126 * tui/tui-winsource.h (tui_refill_source_window)
3127 (tui_set_is_exec_point_at): Don't declare.
3128 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3129 (tui_source_window_base::refill): Rename from
3130 tui_refill_source_window.
3131 (tui_source_window_base::do_scroll_horizontal): Update.
3132 (tui_source_window_base::set_is_exec_point_at): Rename from
3133 tui_set_is_exec_point_at.
3134 (tui_update_all_breakpoint_info): Update.
3135 * tui/tui-stack.c (tui_show_frame_info): Update.
3136 * tui/tui-layout.c (show_data): Add cast.
3137 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3138 * tui/tui-data.h (struct tui_source_window_base) <refill,
3139 set_is_exec_point_at>: New methods.
3140 (tui_source_windows, tui_add_to_source_windows): Update types.
3141 (tui_add_to_source_windows): Remove redundant declaration.
3142 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3143 (tui_source_windows): Change return type.
3144 (tui_clear_source_windows_detail): Update.
3145 (tui_add_to_source_windows): Change type of parameter.
3146 (tui_free_all_source_wins_content): Update.
3147
31482019-06-25 Tom Tromey <tom@tromey.com>
3149
3150 * tui/tui-wingeneral.c (tui_win_info::refresh)
3151 (tui_source_window_base::refresh): New methods.
3152 (tui_refresh_all): Call the refresh method.
3153 * tui/tui-data.h (struct tui_win_info)
3154 (struct tui_source_window_base) <refresh>: New method.
3155
31562019-06-25 Tom Tromey <tom@tromey.com>
3157
3158 * tui/tui.h (tui_is_window_visible): Return bool.
3159 * tui/tui.c (tui_is_window_visible): Return bool.
3160 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3161 (tui_make_visible, tui_make_invisible)
3162 (tui_win_info::make_visible)
3163 (tui_source_window_base::make_visible, make_all_visible)
3164 (tui_make_all_visible, tui_make_all_invisible): Update.
3165 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3166 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3167 bool.
3168 (struct tui_win_info, struct tui_source_window_base)
3169 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3170 * tui/tui-data.c (tui_init_generic_part): Update.
3171
31722019-06-25 Tom Tromey <tom@tromey.com>
3173
3174 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3175 (tui_source_window_base::make_visible): New methods.
3176 (make_all_visible): Make method call.
3177 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3178 (struct tui_source_window_base, struct tui_cmd_window): Override
3179 make_visible.
3180 (tui_win_is_source_type): Don't declare.
3181 * tui/tui-data.c (tui_win_is_source_type): Remove.
3182
31832019-06-25 Tom Tromey <tom@tromey.com>
3184
3185 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3186 NULL check.
3187
31882019-06-25 Tom Tromey <tom@tromey.com>
3189
3190 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3191 Inline constructor. Add initializers for members.
3192 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3193 constructors; now inline in class.
3194
31952019-06-25 Tom Tromey <tom@tromey.com>
3196
3197 * tui/tui-regs.c (tui_show_registers): Update.
3198 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3199 bool.
3200 * tui/tui-data.c (tui_data_window::clear_detail)
3201 (tui_data_window): Update.
3202
32032019-06-25 Tom Tromey <tom@tromey.com>
3204
3205 * tui/tui-windata.c (tui_display_all_data)
3206 (tui_display_data_from_line, tui_display_data_from)
3207 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3208 Update.
3209 * tui/tui-regs.c (tui_last_regs_line_no)
3210 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3211 (tui_show_registers, tui_show_register_group)
3212 (tui_display_registers_from, tui_display_reg_element_at_line)
3213 (tui_display_registers_from_line, tui_check_register_values)
3214 (tui_reg_next, tui_reg_prev): Update.
3215 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3216 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3217 tui_data_window.
3218 (struct tui_win_info) <detail>: Remove. Add new fields from
3219 tui_data_info.
3220 (TUI_DATA_WIN): Add cast.
3221 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3222 (~tui_data_window): Simplify.
3223
32242019-06-25 Tom Tromey <tom@tromey.com>
3225
3226 * tui/tui-layout.c (show_source_disasm_command)
3227 (show_source_or_disasm_and_command): Update.
3228 * tui/tui-io.c (update_cmdwin_start_line)
3229 (tui_redisplay_readline): Update.
3230 * tui/tui-data.h (struct tui_command_info): Remove.
3231 (struct tui_win_info) <detail>: Remove command_info member.
3232 (struct tui_data_window) <start_line>: New member, from
3233 tui_command_info.
3234 (TUI_CMD_WIN): Add casts.
3235
32362019-06-25 Tom Tromey <tom@tromey.com>
3237
3238 * tui/tui-winsource.c (tui_update_source_window)
3239 (tui_refill_source_window)
3240 (tui_source_window_base::do_scroll_horizontal)
3241 (tui_update_breakpoint_info, tui_set_exec_info_content)
3242 (tui_show_exec_info_content, tui_erase_exec_info_content)
3243 (tui_clear_exec_info_content): Update.
3244 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3245 Update.
3246 * tui/tui-win.c (make_invisible_and_set_new_height)
3247 (make_visible_with_new_height): Update.
3248 * tui/tui-source.c (tui_set_source_content)
3249 (tui_show_symtab_source): Update.
3250 * tui/tui-layout.c (extract_display_start_addr)
3251 (show_source_disasm_command, show_data)
3252 (make_source_or_disasm_window)
3253 (show_source_or_disasm_and_command): Update.
3254 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3255 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3256 "gdbarch".
3257 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3258 to tui_source_window_base.
3259 (struct tui_win_info) <detail>: Remove source_info member.
3260 (struct tui_source_window_base) <has_locator>: Inline.
3261 Move contents from tui_source_info; rename has_locator member to
3262 m_has_locator.
3263 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3264 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3265 header file.
3266 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3267 Simplify.
3268 (tui_free_all_source_wins_content): Cast to
3269 tui_source_window_base.
3270
32712019-06-25 Tom Tromey <tom@tromey.com>
3272
3273 * tui/tui-win.c (make_invisible_and_set_new_height)
3274 (make_visible_with_new_height): Call has_locator method.
3275 * tui/tui-layout.c (show_source_disasm_command, show_data)
3276 (show_source_or_disasm_and_command): Update for bool change.
3277 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3278 (tui_win_info) <has_locator>: New method.
3279 (struct tui_source_window_base) <has_locator>: New method.
3280 (tui_win_has_locator): Don't declare.
3281 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3282 from tui_win_has_locator.
3283 (tui_source_window_base): Use false, not FALSE.
3284
32852019-06-25 Tom Tromey <tom@tromey.com>
3286
3287 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3288 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3289 clear_detail method directly.
3290 (tui_clear_win_detail): Remove.
3291
32922019-06-25 Tom Tromey <tom@tromey.com>
3293
3294 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3295 "this", not TUI_DISASM_WIN.
3296
32972019-06-25 Tom Tromey <tom@tromey.com>
3298
3299 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3300 declare.
3301 * tui/tui-winsource.c
3302 (tui_source_window_base::do_scroll_horizontal): Rename from
3303 tui_horizontal_source_scroll.
3304 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3305 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3306 from tui_vertical_data_scroll.
3307 * tui/tui-win.h (tui_scroll): Don't declare.
3308 * tui/tui-win.c (tui_win_info::forward_scroll)
3309 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3310 (tui_win_info::right_scroll): Rename and update.
3311 (tui_scroll_forward_command, tui_scroll_backward_command)
3312 (tui_scroll_left_command, tui_scroll_right_command): Update.
3313 (tui_scroll): Remove.
3314 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3315 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3316 from tui_vertical_source_scroll.
3317 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3318 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3319 from tui_vertical_disassem_scroll.
3320 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3321 do_scroll_horizontal>: New methods.
3322 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3323 Likewise.
3324 (struct tui_source_window_base): Add do_scroll_horizontal.
3325 (struct tui_source_window, struct tui_disasm_window): Add
3326 do_scroll_vertical.
3327 (struct tui_data_window, struct tui_cmd_window): Add
3328 do_scroll_horizontal and do_scroll_vertical.
3329 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3330
33312019-06-25 Tom Tromey <tom@tromey.com>
3332
3333 * tui/tui-data.h (struct tui_source_window_base): New struct.
3334 (struct tui_source_window): Derive from tui_source_window_base.
3335 (struct tui_disasm_window): New struct.
3336 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3337 from tui_source_window::clear_detail.
3338 (tui_source_window_base): Rename from tui_source_window.
3339 (~tui_source_window_base): Rename from ~tui_source_window.
3340 (tui_alloc_win_info): Create a tui_disasm_window.
3341
33422019-06-25 Tom Tromey <tom@tromey.com>
3343
3344 * tui/tui-data.h (struct tui_source_window)
3345 (struct tui_data_window): Declare destructors.
3346 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3347 destructors.
3348 (tui_win_info): Simplify.
3349
33502019-06-25 Tom Tromey <tom@tromey.com>
3351
3352 * tui/tui-winsource.c (tui_display_main)
3353 (tui_update_source_windows_with_addr)
3354 (tui_update_all_breakpoint_info): Update.
3355 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3356 (new_height_ok, parse_scrolling_args): Update.
3357 * tui/tui-stack.c (tui_show_frame_info): Update.
3358 * tui/tui-data.h (struct tui_list): Remove.
3359 (tui_source_windows): Return a reference to a std::vector.
3360 * tui/tui-data.c (source_windows): Now a std::vector.
3361 (tui_source_windows): Change return type.
3362 (tui_clear_source_windows): Rewrite.
3363 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3364 (tui_free_all_source_wins_content): Rewrite.
3365
33662019-06-25 Tom Tromey <tom@tromey.com>
3367
3368 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3369 (struct tui_data_window, struct tui_cmd_window): Declare
3370 clear_detail method.
3371 * tui/tui-data.c (tui_source_window::clear_detail)
3372 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3373 methods.
3374 (tui_clear_win_detail): Simplify.
3375
33762019-06-25 Tom Tromey <tom@tromey.com>
3377
3378 * tui/tui-layout.c (make_source_window, make_disasm_window)
3379 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3380 Return the new window.
3381 (show_source_disasm_command, show_data)
3382 (show_source_or_disasm_and_command): Update.
3383
33842019-06-25 Tom Tromey <tom@tromey.com>
3385
3386 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3387 parameter. Return the new window.
3388 (show_source_disasm_command): Update and remove NULL check.
3389 (show_source_or_disasm_and_command): Update.
3390
33912019-06-25 Tom Tromey <tom@tromey.com>
3392
3393 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3394
33952019-06-25 Tom Tromey <tom@tromey.com>
3396
3397 * tui/tui-data.h (struct tui_win_info): Make constructor
3398 protected. Make destructor virtual. Add initializers.
3399 (tui_source_window, tui_data_window, tui_cmd_window): New
3400 classes.
3401 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3402 constructor. Add "type" parameter.
3403 (tui_source_window, tui_data_window, tui_cmd_window): New
3404 constructors.
3405 (tui_alloc_win_info): Instantiate the appropriate subclass.
3406
34072019-06-25 Tom Tromey <tom@tromey.com>
3408
3409 * tui/tui-win.c (tui_resize_all): Use delete.
3410 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3411 destructor.
3412 (tui_free_window): Don't declare.
3413 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3414 Update.
3415
34162019-06-25 Tom Tromey <tom@tromey.com>
3417
3418 * tui/tui-data.h (struct tui_win_info): Add constructor.
3419 * tui/tui-data.c (tui_alloc_win_info): Use new.
3420 (tui_free_window): Use delete.
3421
34222019-06-22 Tom Tromey <tom@tromey.com>
3423
3424 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3425 declare.
3426 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3427
34282019-06-22 Tom Tromey <tom@tromey.com>
3429
3430 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3431 declare.
3432 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3433
34342019-06-22 Tom de Vries <tdevries@suse.de>
3435
3436 * dwarf2read.c (create_addrmap_from_aranges)
3437 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3438 instead of '%zu'.
3439
34402019-06-21 Simon Marchi <simon.marchi@efficios.com>
3441
3442 * dwarf2read.h (dwarf2_section_info_def): Remove.
3443 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3444 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3445 std::vector<dwarf2_section_info>.
3446 (struct dwo_file) <~dwo_file>: Remove.
3447 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3448 types field.
3449 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3450 (dwarf2_read_debug_names): Likewise.
3451 (create_debug_types_hash_table): Change parameter type to
3452 array_view, adjust code accordingly.
3453 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3454 (partial_die_info::fixup): Likewise.
3455 (determine_prefix): Likewise.
3456 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3457
34582019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3459
3460 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3461 gdb_bfd_ref_ptr.
3462 <~dwo_file>: Remove call to gdb_bfd_unref.
3463 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3464 gdb_bfd_ref_ptr::get.
3465
34662019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3467
3468 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3469 type to htab_up.
3470 * dwarf2read.c (struct dwo_file): Initialize fields.
3471 <~dwo_file>: New.
3472 (free_dwo_file): Remove, move content to ~dwo_file.
3473 (struct dwo_file_deleter): Remove.
3474 (dwo_file_up>: Remove custom deleter.
3475 (free_dwo_files): Remove.
3476 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3477 dwo_files.
3478 (process_skeletonless_type_units): Call unique_ptr::get.
3479 (allocate_dwo_file_hash_table): Add deleter to created hash
3480 table. Change return type to htab_up.
3481 (lookup_dwo_file_slot): Don't memset dwo_file, call
3482 unique_ptr::get.
3483 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3484 (create_dwo_unit_in_dwp_v2): Likewise.
3485 (open_and_init_dwo_file): Likewise.
3486 (free_dwo_file_from_slot): Remove.
3487
34882019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3489
3490 * dwarf2read.h (struct dwarf2_section_info) <readin,
3491 is_virtual>: Change type to bool.
3492 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3493 true instead of 1.
3494
34952019-06-19 Tom Tromey <tom@tromey.com>
3496
3497 * tui/tui-data.h (tui_init_content_element): Don't declare.
3498
34992019-06-19 Tom Tromey <tom@tromey.com>
3500
3501 * tui/tui-data.h (tui_init_win_info): Don't declare.
3502
35032019-06-19 Tom de Vries <tdevries@suse.de>
3504
3505 * dwarf2read.h (abstract_to_concrete): Change type to
3506 std::unordered_map<sect_offset, std::vector<sect_offset>,
3507 gdb::hash_enum<sect_offset>>.
3508
35092019-06-19 Tom Tromey <tromey@adacore.com>
3510
3511 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3512 EVAL_AVOID_SIDE_EFFECTS specially.
3513
35142019-06-19 Tom Tromey <tromey@adacore.com>
3515
3516 * source-cache.c (highlighter): New global.
3517 (source_cache::get_source_lines): Create a highlighter on demand.
3518
35192019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3520
3521 * defs.h (deprecated_interactive_hook): Delete declaration.
3522 * interps.c (clear_interpreter_hooks): Remove use of
3523 deprecated_interactive_hook.
3524 * top.c (deprecated_interactive_hook): Delete definition.
3525 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3526
35272019-06-18 Tom de Vries <tdevries@suse.de>
3528
3529 PR gdb/24515
3530 * dwarf2read.h (abstract_to_concrete): Change type from
3531 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3532 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3533 * dwarf2read.c (read_variable): Update.
3534 (dwarf2_fetch_die_loc_sect_off): Update.
3535
35362019-06-17 Tom de Vries <tdevries@suse.de>
3537
3538 PR gdb/24617
3539 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3540 accessing parent[parent_len - 1].
3541
35422019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3543
3544 PR gdb/24364
3545 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3546 call dtrace_process_dof with NULL dof.
3547
35482019-06-16 Tom de Vries <tdevries@suse.de>
3549
3550 PR gdb/24445
3551 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3552
35532019-06-16 Tom Tromey <tom@tromey.com>
3554
3555 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3556 (make_all_visible): Use address of member.
3557
35582019-06-16 Tom Tromey <tom@tromey.com>
3559
3560 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3561 (tui_free_window, free_content, free_content_elements): Remove
3562 unnecessary cast.
3563 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3564 cast.
3565 * tui/tui-regs.c (tui_show_register_group)
3566 (tui_display_registers_from, tui_display_reg_element_at_line):
3567 Remove unnecessary cast.
3568
35692019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3570
3571 * linux-nat.c (normal_mask): Delete.
3572 (_initialize_linux_nat): Don't initialise normal_mask.
3573
35742019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3575
3576 PR gdb/24445
3577 * dwarf-index-write.h (write_psymtabs_to_index): Add
3578 dwz_basename parameter.
3579 * dwarf-index-write.c (write_gdbindex): Move file writing to
3580 write_gdbindex_1. Change return type void.
3581 (assert_file_size): Move up, remove filename parameter.
3582 (write_gdbindex_1): New function.
3583 (write_debug_names): Change return type to void, call
3584 assert_file_size.
3585 (struct index_wip_file): New struct.
3586 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3587 file logic to index_wip_file. Write index for dwz file if
3588 needed.
3589 (save_gdb_index_command): Pass basename of dwz file, if present.
3590 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3591 build-id of dwz file, if present.
3592 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3593 (dwarf2_get_dwz_file): Likewise.
3594 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3595 (dwarf2_get_dwz_file): Likewise.
3596
35972019-06-16 Tom Tromey <tom@tromey.com>
3598
3599 * coffread.c (process_coff_symbol): Use xstrdup.
3600 * value.c (create_internalvar): Use xstrdup.
3601
36022019-06-16 Tom Tromey <tom@tromey.com>
3603
3604 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3605 * breakpoint.c (stopin_command, stopat_command)
3606 (until_break_command, decode_location_default): Remove unnecessary
3607 cast.
3608 * utils.c (subset_compare): Remove unnecessary cast.
3609 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3610 cast.
3611 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3612 cast.
3613 * infcmd.c (path_command): Remove unnecessary cast.
3614 * coffread.c (decode_type): Remove unnecessary cast.
3615 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3616 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3617 * tui/tui-stack.c (tui_show_locator_content)
3618 (tui_show_frame_info): Remove unnecessary cast.
3619 * tui/tui-win.c (tui_scroll_forward_command)
3620 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3621 (parse_scrolling_args): Remove unnecessary cast.
3622 * tui/tui-data.c (init_win_info, tui_del_window)
3623 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3624 (free_content_elements): Remove unnecessary cast.
3625 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3626 unnecessary cast.
3627 * tui/tui-source.c (tui_set_source_content)
3628 (tui_vertical_source_scroll): Remove unnecessary cast.
3629 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3630 cast.
3631 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3632 * tui/tui-regs.c (tui_display_registers_from)
3633 (tui_display_register): Remove unnecessary cast.
3634 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3635 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3636 (make_visible): Remove unnecessary cast.
3637 * tui/tui-winsource.c (tui_erase_source_content)
3638 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3639 unnecessary cast.
3640 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3641 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3642 * stabsread.c (read_type, read_array_type, read_range_type):
3643 Remove unnecessary cast.
3644 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3645 (parse_symbol, parse_type, upgrade_type, parse_external)
3646 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3647 unnecessary cast.
3648 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3649
36502019-06-16 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui-data.c (tui_alloc_generic_win_info)
3653 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3654 checks.
3655
36562019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3657 Andrew Burgess <andrew.burgess@embecosm.com>
3658
3659 * f-typeprint.c (f_print_type): Don't return early for not
3660 associated or not allocated types.
3661 (f_type_print_varspec_suffix): Add print_rank parameter and print
3662 ranks of array types in case they dangling.
3663 (f_type_print_base): Add print_rank parameter.
3664
36652019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3666
3667 * NEWS: Mention new MI commands.
3668 * break-catch-throw.c (enum exception_event_kind): Move to
3669 breakpoint.h.
3670 (print_mention_exception_catchpoint): Output text as a single
3671 message.
3672 (catch_exception_command_1): Rename to...
3673 (catch_exception_event): ...this, make non-static, update header
3674 command, and change some parameter types.
3675 (catch_catch_command): Update for changes to
3676 catch_exception_command_1.
3677 (catch_throw_command): Likewise.
3678 (catch_rethrow_command): Likewise.
3679 * breakpoint.c (enum exception_event_kind): Delete.
3680 * breakpoint.h (enum exception_event_kind): Moved here from
3681 break-catch-throw.c.
3682 (catch_exception_event): Declare.
3683 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3684 (mi_cmd_catch_throw): New function.
3685 (mi_cmd_catch_rethrow): New function.
3686 (mi_cmd_catch_catch): New function.
3687 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3688 'catch-catch' entries.
3689 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3690 (mi_cmd_catch_rethrow): Declare.
3691 (mi_cmd_catch_catch): Declare.
3692
36932019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3694
3695 * annotate.c (annotate_source_line): Change return type to void,
3696 update implementation to match.
3697 * annotate.h (annotate_source_line): Change return type to void,
3698 update header comment.
3699 * stack.c (print_frame_info): Don't change what frame information
3700 is printed based on whether annotations are on or not.
3701
37022019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3703
3704 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3705 (annotate_source): Make static.
3706 (annotate_source_line): Moved from source.c and renamed from
3707 identify_source_line. Update the return type.
3708 * annotate.h (annotate_source): Delete declaration.
3709 (annotate_source_line): Declaration moved from source.h, and
3710 renamed from identify_source_line. Return type updated.
3711 * source.c (identify_source_line): Moved to annotate.c and renamed
3712 to annotate_source_line.
3713 (info_line_command): Remove check of annotation_level.
3714 * source.h (identify_source_line): Move declaration to annotate.h
3715 and rename to annotate_source_line.
3716 * stack.c: Add 'annotate.h' include.
3717 (print_frame_info): Remove check of annotation_level before
3718 calling annotate_source_line.
3719
37202019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3721
3722 * source-cache.c (source_cache::get_plain_source_lines): Use
3723 open_source_file_with_line_charpos instead of just
3724 open_source_file, remove call to find_source_lines.
3725 (source_cache::get_source_lines): Likewise.
3726 * source.c (find_source_lines): Make static.
3727 (get_filename_and_charpos): Renamed into...
3728 (open_source_file_with_line_charpos): ..this along with changes to
3729 return a scoped_fd, and some other minor clean ups.
3730 (identify_source_line): Use open_source_file_with_line_charpos.
3731 (search_command_helper): Use open_source_file_with_line_charpos
3732 instead of just open_source_file, remove call to
3733 find_source_lines.
3734 * source.h (open_source_file_with_line_charpos): Declare new
3735 function.
3736 (find_source_lines): Delete declaration.
3737
37382019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3739
3740 * source.c (get_filename_and_charpos): Remove fullname
3741 parameter.
3742 (identify_source_line): Update call to get_filename_and_charpos.
3743
37442019-06-14 Tom Tromey <tromey@adacore.com>
3745
3746 PR gdb/24502:
3747 * ui-style.h (skip_ansi_escape): Update comment.
3748 * ui-file.h (class no_terminal_escape_file): New class.
3749 * ui-file.c (no_terminal_escape_file::write)
3750 (no_terminal_escape_file::puts): New methods.
3751 * cli/cli-logging.c (handle_redirections): Use
3752 no_terminal_escape_file.
3753
37542019-06-14 Tom Tromey <tromey@adacore.com>
3755
3756 * NEWS: Move convenience variable news above Python news.
3757
37582019-06-14 Tom Tromey <tom@tromey.com>
3759
3760 * gnulib: Move directory to top-level.
3761 * configure.ac: Don't configure gnulib.
3762 * configure: Rebuild.
3763 * common/common-defs.h: Use new path to gnulib.
3764 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3765 (GNULIB_H): Remove.
3766 (INCGNU): Look in new gnulib location.
3767 (HFILES_NO_SRCDIR): Remove gnulib files.
3768 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3769 (generated_files): Remove GNULIB_H.
3770 ($(LIBGNU), all-lib): Remove targets.
3771 (distclean): Don't mention GNULIB_BUILDDIR.
3772 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3773
37742019-06-14 Tom Tromey <tromey@adacore.com>
3775
3776 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3777 Warn if symbol file does not provide any symbols.
3778
37792019-06-14 Tom Tromey <tromey@adacore.com>
3780
3781 * source.c (find_and_open_source): Respect basenames_may_differ.
3782
37832019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3784
3785 * annotate.c (annotate_breakpoints_invalid): Make use of
3786 scoped_restore_terminal_state.
3787 (annotate_frames_invalid): Likewise.
3788
37892019-06-14 Tom Tromey <tromey@adacore.com>
3790
3791 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3792 allow assignment to an internalvar.
3793
37942019-06-14 Tom Tromey <tromey@adacore.com>
3795
3796 * ada-lex.l: Allow "_" in attribute names.
3797
37982019-06-14 Tom Tromey <tromey@adacore.com>
3799
3800 PR gdb/24653:
3801 * regcache.c (registers_changed): Don't call alloca.
3802 * top.c (execute_command): Don't call alloca.
3803
38042019-06-13 Pedro Alves <palves@redhat.com>
3805
3806 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3807 'expression'. When parsing an expression, error out if there's
3808 junk after "unlimited".
3809 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3810 (do_set_command): Adjust calls to is_unlimited_literal.
3811
38122019-06-13 Pedro Alves <palves@redhat.com>
3813
3814 * compile/compile.c (make_compile_options_def_group): Add braces
3815 around array_view initializer.
3816 * thread.c (make_thread_apply_all_options_def_group)
3817 (make_thread_apply_all_options_def_group): Likewise.
3818
38192019-06-13 Pedro Alves <palves@redhat.com>
3820
3821 * NEWS (New commands): Mention "maint test-options
3822 require-delimiter", "maint test-options unknown-is-error", "maint
3823 test-options unknown-is-operand" and "maint show
3824 test-options-completion-result".
3825 (New command options, command completion): New section.
3826 (Completion improvements): New section.
3827 Mention that you can abbreviate "unlimited".
3828
38292019-06-13 Pedro Alves <palves@redhat.com>
3830
3831 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3832 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3833 * unittests/cli-utils-selftests.c (test_parse_flags)
3834 (test_parse_flags_qcs): Delete.
3835 (test_cli_utils): Don't call deleted functions.
3836
38372019-06-13 Pedro Alves <palves@redhat.com>
3838
3839 * thread.c: Include "cli/cli-option.h".
3840 (tp_array_compar_ascending): Global.
3841 (tp_array_compar): Delete function.
3842 (tp_array_compar_ascending, tp_array_compar_descending): New
3843 functions.
3844 (ascending_option_def, qcs_flag_option_def)
3845 (thr_qcs_flags_option_defs)
3846 (make_thread_apply_all_options_def_group)
3847 (make_thread_apply_options_def_group): New.
3848 (thread_apply_all_command): Use gdb::option::process_options.
3849 (thread_apply_command_completer)
3850 (thread_apply_all_command_completer): New.
3851 (thread_apply_command): Use gdb::option::process_options.
3852 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3853 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3854 to generate help text of "thread apply". Adjust "taas"'s help.
3855 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3856 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3857
38582019-06-13 Pedro Alves <palves@redhat.com>
3859
3860 * thread.c (thread_apply_command): Check for invalid TID with
3861 isdigit instead of !isalpha.
3862
38632019-06-13 Pedro Alves <palves@redhat.com>
3864
3865 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3866 (validate_flags_qcs): New.
3867 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3868 (validate_flags_qcs): Declare.
3869 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3870 (make_frame_apply_options_def_group): New.
3871 (frame_apply_command_count): Process options with
3872 gdb::option::process_options.
3873 (frame_apply_completer): New.
3874 (frame_apply_level_completer, frame_apply_all_completer)
3875 (frame_apply_completer): New.
3876 (_initialize_stack): Update help of "frame apply", "frame apply
3877 level", "frame apply all" and "faas" to mention supported options
3878 and install command completers.
3879 * stack.h (frame_apply_all_completer): Declare.
3880 * thread.c: Include "stack.h".
3881 (tfaas_command): Add "--".
3882 (_initialize_thread): Update help "tfaas" to mention supported
3883 options and install command completer.
3884
38852019-06-13 Pedro Alves <palves@redhat.com>
3886
3887 * completer.c (complete_nested_command_line): New.
3888 (gdb_completion_word_break_characters_throw): Add assertion.
3889 * completer.h (complete_nested_command_line): Declare.
3890
38912019-06-13 Pedro Alves <palves@redhat.com>
3892
3893 * stack.c (parse_backtrace_qualifiers): New.
3894 (backtrace_command): Use it.
3895 (backtrace_command_completer): Complete on qualifiers.
3896
38972019-06-13 Pedro Alves <palves@redhat.com>
3898
3899 * frame.c: Include "cli/cli-option.h.
3900 (user_set_backtrace_options): New.
3901 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3902 Delete.
3903 (get_prev_frame): Adjust.
3904 (boolean_option_def, uinteger_option_def)
3905 (set_backtrace_option_defs): New.
3906 (_initialize_frame): Adjust and use
3907 gdb::option::add_setshow_cmds_for_options to install "set
3908 backtrace past-main" and "set backtrace past-entry".
3909 * frame.h: Include "cli/cli-option.h".
3910 (struct frame_print_options): Forward declare.
3911 (print_frame_arguments_all, print_frame_arguments_scalars)
3912 (print_frame_arguments_none): Declare.
3913 (print_entry_values): Delete declaration.
3914 (struct frame_print_options, user_frame_print_options): New.
3915 (struct set_backtrace_options): New.
3916 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3917 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3918 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3919 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3920 (list_args_or_locals): Add frame_print_options parameter.
3921 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3922 * python/py-framefilter.c (enumerate_args): Pass down
3923 USER_FRAME_PRINT_OPTIONS.
3924 * stack.c: Include "cli/cli-option.h".
3925 (print_frame_arguments_all, print_frame_arguments_scalars)
3926 (print_frame_arguments_none): Declare.
3927 (print_raw_frame_arguments, print_entry_values): Delete.
3928 (user_frame_print_options): New.
3929 (boolean_option_def, enum_option_def, frame_print_option_defs):
3930 New.
3931 (struct backtrace_cmd_options): New.
3932 (bt_flag_option_def): New.
3933 (backtrace_command_option_defs): New.
3934 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3935 (print_frame_arg, read_frame_arg, print_frame_args)
3936 (print_frame_info, print_frame): Add frame_print_options parameter
3937 and use it.
3938 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3939 (backtrace_command_1): Add frame_print_options and
3940 backtrace_cmd_options parameters and use them.
3941 (make_backtrace_options_def_group): New.
3942 (backtrace_command): Process command options with
3943 gdb::option::process_options.
3944 (backtrace_command_completer): New.
3945 (_initialize_stack): Extend "backtrace"'s help to mention
3946 supported options. Install completer for "backtrace".
3947 Install some settings commands with add_setshow_cmds_for_options.
3948
39492019-06-13 Pedro Alves <palves@redhat.com>
3950
3951 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3952 and that "set/show print raw frame-arguments" are now deprecated.
3953
3954 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3955 command.
3956 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3957 * stack.c (_initialize_stack): Install "set/show print
3958 raw-frame-arguments", and deprecate "set/show print raw
3959 frame-arguments".
3960 * valprint.c (_initialize_valprint): Deprecate "set/show print
3961 raw".
3962
39632019-06-13 Pedro Alves <palves@redhat.com>
3964
3965 * compile/compile.c (struct compile_options): New.
3966 (compile_flag_option_def, compile_command_option_defs)
3967 (make_compile_options_def_group): New.
3968 (compile_file_command): Handle options with
3969 gdb::option::process_options.
3970 (compile_file_command_completer): New function.
3971 (compile_code_command): Handle options with
3972 gdb::option::process_options.
3973 (compile_code_command_completer): New function.
3974 (_initialize_compiler): Install completers for "compile code" and
3975 "compile file". Mention available options in "compile code" and
3976 "compile code"'s help.
3977 * completer.c (advance_to_completion_word): New, factored out from
3978 ...
3979 (advance_to_expression_complete_word_point): ... this.
3980 (advance_to_filename_complete_word_point): New.
3981 * completer.h (advance_to_filename_complete_word_point): New
3982 declaration.
3983
39842019-06-13 Pedro Alves <palves@redhat.com>
3985
3986 * compile/compile.c: Include "cli/cli-option.h".
3987 (compile_print_value): Scope data pointer is now a
3988 value_print_options pointer; adjust.
3989 (compile_print_command): Process options. Scope data pointer is
3990 now a value_print_options pointer; adjust.
3991 (_initialize_compile): Update "compile print"'s help to include
3992 supported options. Install a completer for "compile print".
3993 * cp-valprint.c (show_vtblprint, show_objectprint)
3994 (show_static_field_print): Delete.
3995 (_initialize_cp_valprint): Don't install "set print
3996 static-members", "set print vtbl", "set print object" here.
3997 * printcmd.c: Include "cli/cli-option.h" and
3998 "common/gdb_optional.h".
3999 (print_command_parse_format): Rework to fill in a
4000 value_print_options instead of a format_data.
4001 (print_value): Change parameter type from format_data pointer to
4002 value_print_options reference. Adjust.
4003 (print_command_1): Process options. Adjust to pass down a
4004 value_print_options.
4005 (print_command_completer): New.
4006 (_initialize_printcmd): Install print_command_completer as
4007 handle_brkchars completer for the "print" command. Update
4008 "print"'s help to include supported options.
4009 * valprint.c: Include "cli/cli-option.h".
4010 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4011 here from cp-valprint.c.
4012 (boolean_option_def, uinteger_option_def)
4013 (value_print_option_defs, make_value_print_options_def_group):
4014 New. Use gdb::option::add_setshow_cmds_for_options to install
4015 "set print elements", "set print null-stop", "set print repeats",
4016 "set print pretty", "set print union", "set print array", "set
4017 print address", "set print symbol", "set print array-indexes".
4018 * valprint.h: Include <string> and "cli/cli-option.h".
4019 (make_value_print_options_def_group): Declare.
4020 (print_value): Change parameter type from format_data pointer to
4021 value_print_options reference.
4022 (print_command_completer): Declare.
4023
40242019-06-13 Pedro Alves <palves@redhat.com>
4025
4026 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4027 (COMMON_SFILES): Add maint-test-settings.c.
4028 * cli/cli-decode.c (boolean_enums): New global, factored out from
4029 ...
4030 (add_setshow_boolean_cmd): ... here.
4031 * cli/cli-decode.h (boolean_enums): Declare.
4032 * cli/cli-option.c: New file.
4033 * cli/cli-option.h: New file.
4034 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4035 factored out from ...
4036 (parse_cli_boolean_value(const char *)): ... this.
4037 (is_unlimited_literal): Change parameter type to pointer to
4038 pointer. Adjust and advance ARG pointer.
4039 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4040 (parse_cli_var_enum): New, factored out from ...
4041 (do_set_command): ... this. Adjust.
4042 * cli/cli-setshow.h (parse_cli_boolean_value)
4043 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4044 (parse_cli_var_enum): Declare.
4045 * cli/cli-utils.c: Include "cli/cli-option.h".
4046 (get_ulongest): New.
4047 * cli/cli-utils.h (get_ulongest): Declare.
4048 (check_for_argument): New overloads.
4049 * maint-test-options.c: New file.
4050
40512019-06-13 Pedro Alves <palves@redhat.com>
4052
4053 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4054 parse a range if "-" is at the end of the string.
4055
40562019-06-13 Pedro Alves <palves@redhat.com>
4057
4058 * cli/cli-setshow.c (parse_auto_binary_operation)
4059 (parse_cli_boolean_value): Don't allow "o".
4060
40612019-06-13 Pedro Alves <palves@redhat.com>
4062
4063 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4064 * NEWS: Mention maint test-settings KIND.
4065 * maint-test-settings.c: New file.
4066
40672019-06-13 Pedro Alves <palves@redhat.com>
4068
4069 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4070 completer.
4071 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4072 "set" completers.
4073
40742019-06-13 Pedro Alves <palves@redhat.com>
4075
4076 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4077 after item.
4078
40792019-06-13 Pedro Alves <palves@redhat.com>
4080
4081 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4082
40832019-06-13 Pedro Alves <palves@redhat.com>
4084
4085 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4086 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4087 call.
4088 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4089 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4090 calls.
4091 (check_for_argument): Skip spaces after argument.
4092
40932019-06-13 Pedro Alves <palves@redhat.com>
4094
4095 * thread.c (thread_apply_command): Adjust TID parsing.
4096 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4097 detected before end of string.
4098 (tid_is_in_list): Error out if LIST is invalid.
4099
41002019-06-13 Pedro Alves <palves@redhat.com>
4101
4102 * completer.c (complete_line_internal_1): Rewind completion word
4103 point.
4104 (completion_tracker::advance_custom_word_point_by): Change
4105 parameter type to int.
4106 * completer.h (completion_tracker::advance_custom_word_point_by):
4107 Likewise.
4108
41092019-06-13 Pedro Alves <palves@redhat.com>
4110
4111 * completer.c (advance_to_completion_word): Handle delimiters.
4112
41132019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4114
4115 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4116
41172019-06-11 Tom Tromey <tom@tromey.com>
4118
4119 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4120 (xmalloc_failed): Move to alloc.c.
4121 * alloc.c: New file.
4122 * Makefile.in (COMMON_SFILES): Add alloc.c.
4123
41242019-06-11 Tom Tromey <tom@tromey.com>
4125
4126 * nat/linux-waitpid.c: Don't include server.h.
4127 (linux_debug): Remove.
4128 (my_waitpid): Update.
4129
41302019-06-11 Tom Tromey <tromey@adacore.com>
4131
4132 * infcall.c (_initialize_infcall): Remove trailing newline from
4133 help.
4134 * user-regs.c (_initialize_user_regs): Remove trailing newline
4135 from help.
4136 * typeprint.c (_initialize_typeprint): Remove trailing newline
4137 from help.
4138 * reverse.c (_initialize_reverse): Remove trailing newlines from
4139 help.
4140 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4141 from help.
4142 * language.c (add_set_language_command): Remove trailing newline
4143 from help.
4144 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4145 help.
4146 * disasm.c (_initialize_disasm): Remove trailing newline from
4147 help.
4148 * top.c (init_main): Remove trailing newline from help.
4149 * interps.c (_initialize_interpreter): Remove trailing newline
4150 from help.
4151 * btrace.c (_initialize_btrace): Remove trailing newlines from
4152 help.
4153 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4154 from help.
4155 * python/python.c (_initialize_python): Remove trailing newline
4156 from help.
4157 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4158 help.
4159 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4160 from help. Reformat some text.
4161 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4162 from help.
4163 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4164 newline from help.
4165
41662019-06-11 Tom Tromey <tromey@adacore.com>
4167
4168 * darwin-nat.c (darwin_decode_exception_message)
4169 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4170
41712019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4172
4173 * valops.c (value_slice): Check for not allocated or not
4174 associated values.
4175
41762019-06-10 Tom de Vries <tdevries@suse.de>
4177
4178 PR gdb/24618
4179 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4180 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4181 invalid.
4182
41832019-06-10 Tom de Vries <tdevries@suse.de>
4184
4185 PR gdb/24611
4186 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4187 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4188
41892019-06-10 Tom de Vries <tdevries@suse.de>
4190
4191 PR symtab/24545
4192 * symtab.c (struct demangled_name_entry): Add language field.
4193 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4194 static minimal symbol". Set and use language field.
4195
41962019-06-10 Tom Tromey <tromey@adacore.com>
4197
4198 * ada-lang.c (_initialize_ada_language): Update help text.
4199
42002019-06-10 Tom Tromey <tromey@adacore.com>
4201
4202 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4203 with a newline.
4204 * guile/guile.c (handle_boot_error): Don't end warning with a
4205 newline.
4206 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4207 warning with a newline.
4208 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4209 newline.
4210 (s12z_frame_cache): Likewise.
4211 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4212 a newline.
4213 * solib-svr4.c (disable_probes_interface): Don't end warning with
4214 a newline.
4215 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4216 newline.
4217 * python/python.c (do_finish_initialization): Don't end warning
4218 with a newline.
4219
42202019-06-10 Tom Tromey <tom@tromey.com>
4221
4222 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4223 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4224 gdbpy_enter.
4225
42262019-06-10 Tom Tromey <tromey@adacore.com>
4227
4228 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4229 data.
4230 (elf_new_init): Don't call stabsread_new_init.
4231 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4232 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4233 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4234
42352019-06-10 Tom de Vries <tdevries@suse.de>
4236
4237 PR symtab/16264
4238 PR symtab/24517
4239 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4240
42412019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4242
4243 * source.c (find_and_open_source): Also rewrite relative file
4244 names.
4245
42462019-04-26 Amos Bird <amosbird@gmail.com>
4247
4248 * annotate.c (annotate_thread_exited): Add "thread-exited"
4249 annotation.
4250
42512019-06-06 Tom Tromey <tromey@adacore.com>
4252
4253 * maint.h (class scoped_command_stats): Use
4254 DISABLE_COPY_AND_ASSIGN.
4255 <print_time>: New method.
4256 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4257 print_time.
4258 (scoped_command_stats::print_time): New method.
4259
42602019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4261
4262 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4263 instructions of lengths 6 or 8 bytes.
4264
42652019-06-04 Pedro Alves <palves@redhat.com>
4266
4267 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4268
4269 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4270 * breakpoint.c (condition_completer): Likewise.
4271 * cli/cli-dump.c (scan_expression): Likewise.
4272 * common/filestuff.c (mkdir_recursive): Likewise.
4273 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4274 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4275 (gdb_abspath): Likewise.
4276 * compile/compile-cplus-types.c
4277 (compile_cplus_instance::decl_name): Likewise.
4278 * completer.c (complete_explicit_location):
4279 (signal_completer, reg_or_group_completer_1): Likewise.
4280 * cp-support.c (cp_remove_params_if_any): Likewise.
4281 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4282 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4283 * infcmd.c (strip_bg_char): Likewise.
4284 * linespec.c (copy_token_string): Likewise.
4285 * mi/mi-main.c (output_cores): Likewise.
4286 * psymtab.c (psymtab_search_name):
4287 * symfile.c (test_set_ext_lang_command): Likewise.
4288 * target.c (target_fileio_read_stralloc): Likewise.
4289 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4290 * value.c (complete_internalvar): Likewise.
4291
42922019-06-04 Christian Biesinger <cbiesinger@google.com>
4293
4294 Add objfile property to gdb.Type.
4295 * NEWS: Mention Python API addition.
4296 * python/py-type.c (typy_get_objfile): New method.
4297
42982019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4299
4300 * NEWS: Mention the new set|show style [title|highlight].
4301 Mention changes to "show style", "help" and "apropos".
4302
43032019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4304
4305 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4306 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4307 instead of print_help_for_command.
4308 (print_doc_of_command): New function.
4309 (help_list): Add 'apropos -v word' suggestion.
4310 (print_help_for_command): Style the command name using title style.
4311 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4312 (_initialize_cli_cmds): Describe -v in apropos_command help.
4313
43142019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4315
4316 * cli/cli-style.h (cli_style_option): Add name in constructor,
4317 add m_name class member, add constructor with intensity,
4318 add name class function.
4319 (cli_style_option::add_setshow_commands): Remove name argument.
4320 (highlight_style, title_style): New styles.
4321 * cli/cli-style.c (do_show): New function that shows a style
4322 characteristic styling the style name with itself.
4323 (set_style_name): New function.
4324 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4325 Update all callers according to the changes in cli/cli-style.h.
4326 * utils.h (fputs_highlighted): New function.
4327 * utils.c (fputs_highlighted): Likewise.
4328
43292019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4330
4331 * NEWS: Mention new pipe command and new convenience variables.
4332
43332019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4334
4335 * cli/cli-cmds.c (pipe_command): New function.
4336 (_initialize_cli_cmds): Call add_com for pipe_command.
4337 Define | as an alias for pipe.
4338 (exit_status_set_internal_vars): New function.
4339 (shell_escape): Call exit_status_set_internal_vars.
4340 cli/cli-decode.c (find_command_name_length): Recognize | as
4341 a single character command.
4342
43432019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4344
4345 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4346 top.c (execute_command_to_ui_file): New function, mostly a copy
4347 of execute_command_to_string.
4348 (execute_command_to_string): Implement by calling
4349 execute_command_to_ui_file.
4350
43512019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4352
4353 * top.h (saved_command_line): Remove declaration.
4354 * top.c (previous_saved_command_line, previous_repeat_arguments):
4355 New variables.
4356 (saved_command_line): Make static, define together with other
4357 'repeat variables'.
4358 (dont_repeat): Clear repeat_arguments.
4359 (repeat_previous, get_saved_command_line, save_command_line):
4360 New functions.
4361 (gdb_init): Initialize saved_command_line
4362 and previous_saved_command_line.
4363 * main.c (captured_main_1): Remove saved_command_line initialization.
4364 * event-top.c (handle_line_of_input): Update to use
4365 the new 'repeat' related functions instead of direct access to
4366 saved_command_line.
4367 * command.h (repeat_previous, get_saved_command_line,
4368 save_command_line): New declarations.
4369 (dont_repeat): Add comment.
4370
43712019-05-30 Tom Tromey <tromey@adacore.com>
4372
4373 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4374 Fix comment.
4375 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4376
43772019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4378
4379 PR cli/24587
4380 * completer.c (complete): Initialize variable word.
4381
43822019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4383
4384 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4385 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4386 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4387 'body' is NULL to the outter 'if', protecting the '!is_define'
4388 situation as well.
4389
43902019-05-29 Tom Tromey <tromey@adacore.com>
4391
4392 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4393 (dwarf_unknown): New function.
4394 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4395 (dwarf_type_encoding_name): Use dwarf_unknown.
4396
43972019-05-29 Tom Tromey <tromey@adacore.com>
4398
4399 PR c++/20020:
4400 * cp-valprint.c (cp_print_value_fields): Call
4401 cp_print_static_field inside "try".
4402
44032019-05-29 Tom Tromey <tromey@adacore.com>
4404
4405 * inflow.c (struct terminal_info): Add default operator=.
4406 * configure: Rebuild.
4407 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4408 -Wdeprecated-copy-dtor, -Wredundant-move.
4409
44102019-05-29 Tom Tromey <tromey@adacore.com>
4411
4412 * NEWS: Add entry.
4413 * infcmd.c (print_return_value_1): Handle finish_print
4414 option.
4415 (show_print_finish): New function.
4416 (_initialize_infcmd): Add "set/show print finish" commands.
4417 * valprint.c (user_print_options): Initialize new member.
4418 * valprint.h (struct value_print_options) <finish_print>: New
4419 member.
4420
44212019-05-28 Tom Tromey <tromey@adacore.com>
4422
4423 * ada-lang.c (ada_remove_Xbn_suffix)
4424 (find_old_style_renaming_symbol)
4425 (parse_old_style_renaming): Remove.
4426 (ada_find_renaming_symbol): Don't call
4427 find_old_style_renaming_symbol.
4428 (ada_is_renaming_symbol): Rename from
4429 ada_find_renaming_symbol. Remove "block" parameter. Return
4430 bool. Now static.
4431 (ada_read_var_value): Update and simplify.
4432 * ada-exp.y (write_var_or_type): Remove old code.
4433
44342019-05-28 Alan Hayward <alan.hayward@arm.com>
4435
4436 * event-top.c: Remove include comment.
4437 * inflow.c (class scoped_ignore_sigttou): Move from here...
4438 * inflow.h (class scoped_ignore_sigttou): ...to here.
4439 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4440 * top.c: Remove include comment.
4441
44422019-05-27 Tom Tromey <tom@tromey.com>
4443
4444 * NEWS: Fix typo.
4445
44462019-05-22 Tom Tromey <tromey@adacore.com>
4447
4448 * target.c (target_follow_exec): Constify parameter.
4449 * target-delegates.c: Rebuild.
4450 * remote.c (remote_target::follow_exec): Constify parameter.
4451 * infrun.c (follow_exec): Constify parameter.
4452 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4453 (target_follow_exec): Likewise.
4454
44552019-05-22 Alan Hayward <alan.hayward@arm.com>
4456
4457 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4458 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4459
44602019-05-22 Alan Hayward <alan.hayward@arm.com>
4461
4462 * NEWS: Add debugredirect and testsuite sections.
4463
44642019-05-22 Simon Cook <simon.cook@embecosm.com>
4465
4466 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4467 target descriptions using exclusively floating point register name
4468 aliases.
4469
44702019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4471
4472 PR gdb/18644:
4473 * f-lang.c (build_fortran_types): Handle the case where
4474 gdbarch_floatformat_for_type returns a nullptr.
4475
44762019-05-21 Tom de Vries <tdevries@suse.de>
4477
4478 PR cli/24587
4479 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4480
44812019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4482
4483 PR gdb/18644:
4484 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4485 16-byte floats.
4486 * i386-tdep.c (i386_floatformat_for_type): Use
4487 floatformats_ia64_quad for the 16-byte floating point component
4488 within a fortran 32-byte complex number.
4489
44902019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4491
4492 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4493 delete default constructor.
4494 (find_partial_die): Update to return const struct.
4495 (partial_die_parent_scope): Move variable declaration into scope
4496 of its use and change its type to auto.
4497 (guess_partial_die_structure_name): Likewise.
4498 (partial_die_info::fixup): Likewise.
4499
45002019-05-17 Tom Tromey <tromey@adacore.com>
4501
4502 * source.c (find_and_open_source): Remove cast.
4503
45042019-05-17 Tom Tromey <tromey@adacore.com>
4505
4506 * annotate.c (annotate_source): Make "filename" const.
4507 * annotate.h (annotate_source): Use const.
4508
45092019-05-17 Alan Hayward <alan.hayward@arm.com>
4510
4511 * disasm.c (set_disassembler_options): Send errors to stderr.
4512
45132019-05-17 Alan Hayward <alan.hayward@arm.com>
4514
4515 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4516 (cli_interp_base::set_logging): Check debug_redirect.
4517 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4518 * cli/cli-logging.c (debug_redirect): Add static variable.
4519 (pop_output_files): Add default param.
4520 (handle_redirections): Print debug setting.
4521 (show_logging_command): Likewise.
4522 (_initialize_cli_logging): Add debugredirect command.
4523 * interps.c (current_interp_set_logging): Add debug_redirect
4524 parameter.
4525 * interps.h (set_logging): Add debug_redirect parameter.
4526 (current_interp_set_logging): Likewise.
4527 * mi/mi-common.h: Likewise.
4528 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4529
45302019-05-17 Alan Hayward <alan.hayward@arm.com>
4531 Tom Tromey <tromey@adacore.com>
4532
4533 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4534 directly.
4535 * cli/cli-interp.h (make_logging_output): Remove declaration.
4536 * cli/cli-logging.c (make_logging_output): Remove function.
4537 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4538 directly.
4539 * ui-file.c (tee_file::tee_file): Remove bools.
4540 (tee_file::~tee_file): Remove deletes.
4541 * ui-file.h (tee_file): Remove bools.
4542
45432019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4544
4545 * mi/mi-cmds.h (mi_cmd_complete): New function.
4546 * mi/mi-main.c (mi_cmd_complete): Likewise.
4547 * mi/mi-cmds.c: Define new MI command -complete.
4548 * NEWS: Mention new -complete command.
4549
45502019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4551
4552 * completer.h (complete): New function.
4553 * completer.c (complete): Likewise.
4554 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4555 function defined in completer.h.
4556
45572019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4558
4559 * MAINTAINERS (Write After Approval): Add myself.
4560
45612019-05-17 Tom de Vries <tdevries@suse.de>
4562
4563 PR gdb/24094
4564 * dwarf2read.c (struct cu_partial_die_info): New struct.
4565 (find_partial_die): Return cu_partial_die_info.
4566 (partial_die_parent_scope, guess_partial_die_structure_name)
4567 (partial_die_info::fixup): Handle new return type of find_partial_die.
4568
45692019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4570
4571 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4572 "std::string", simplifying the algorithm.
4573
45742019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4575
4576 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4577 (stap_static_probe_ops::get_probes): Likewise.
4578
45792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4580
4581 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4582 '-')" and "else if".
4583 (stap_parse_single_operand): Join checks for
4584 "gdbarch_stap_parse_special_token_p" and
4585 "gdbarch_stap_parse_special_token" in the same "if" statement.
4586 Invert check when verifying for operation on register
4587 displacement.
4588
45892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4590
4591 * stap-probe.c (stap_get_opcode): Update comment.
4592 (stap_get_expected_argument_type): Likewise.
4593 (handle_stap_probe): Likewise.
4594
45952019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4596
4597 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4598 return type to 'bool'. Adjust comment. Use 'bool' when
4599 appropriate.
4600 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4601 * stap-probe.c (stap_parse_argument_1): Likewise.
4602 (stap_is_operator): Likewise.
4603 (stap_is_generic_prefix): Likewise.
4604 (stap_is_register_prefix): Likewise.
4605 (stap_is_register_indirection_prefix): Likewise.
4606 (stap_is_integer_prefix): Likewise.
4607 (stap_generic_check_suffix): Likewise.
4608 (stap_check_integer_suffix): Likewise.
4609 (stap_check_register_suffix): Likewise.
4610 (stap_check_register_indirection_suffix): Likewise.
4611 (stap_parse_register_operand): Likewise.
4612 (stap_parse_single_operand): Likewise.
4613 (stap_parse_argument_1): Likewise.
4614 (stap_probe::get_argument_count): Likewise.
4615 (stap_is_operator): Likewise.
4616
46172019-05-16 Tom Tromey <tromey@adacore.com>
4618
4619 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4620 keyword to foreach.
4621
46222019-05-15 Simon Marchi <simon.marchi@efficios.com>
4623
4624 * linux-thread-db.c (try_thread_db_load_1): Change return type
4625 to bool.
4626 (try_thread_db_load): Likewise.
4627 (try_thread_db_load_from_pdir_1): Likewise.
4628 (try_thread_db_load_from_pdir): Likewise.
4629 (try_thread_db_load_from_sdir): Likewise.
4630 (try_thread_db_load_from_dir): Likewise.
4631 (thread_db_load_search): Likewise.
4632 (has_libpthread): Likewise.
4633 (thread_db_load): Likewise.
4634
46352019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4636
4637 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4638 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4639 NULL, and complain/return if that's the case.
4640
46412019-05-15 John Darrington <john@darrington.wattle.id.au>
4642
4643 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4644 (advance, posn, abstract_read_memory): New functions.
4645 [struct mem_read_abstraction]: New struct.
4646 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4647
46482019-05-14 Tom Tromey <tromey@adacore.com>
4649
4650 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4651 value is not lval_memory.
4652
46532019-05-14 Tom Tromey <tromey@adacore.com>
4654
4655 * solib.c (info_sharedlibrary_command): Style the file name.
4656
46572019-05-14 Alan Hayward <alan.hayward@arm.com>
4658
4659 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4660 (aarch64_vnv_type): Likewise.
4661 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4662 * common/tdesc.c: Likewise.
4663 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4664 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4665 * features/aarch64-fpu.xml: Add ieee half view.
4666 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4667 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4668 * gdbtypes.h (struct builtin_type): Likewise.
4669 (struct objfile_type): Likewise.
4670
46712019-05-12 Paul Naert <paul.naert@polymtl.ca>
4672
4673 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4674 typo.
4675 * location.h (string_to_event_location): Likewise.
4676
46772019-05-11 Joel Brobecker <brobecker@adacore.com>
4678
4679 GDB 8.3 released.
4680
46812019-05-10 Simon Marchi <simon.marchi@efficios.com>
4682
4683 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4684 New variable declaration.
4685 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4686 New variable.
4687 (print_one_breakpoint): Use ui_out::test_flags and new global
4688 variable to compute use_fixed_output.
4689 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4690 Remove.
4691 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4692 (mi_multi_location_breakpoint_output_fixed): Remove.
4693 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4694 new variable.
4695 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4696 fix_multi_location_breakpoint_output flag if version >= 3.
4697 * ui-out.h (enum ui_out_flag)
4698 <fix_multi_location_breakpoint_output>: New enumerator.
4699
47002019-05-10 Simon Marchi <simon.marchi@efficios.com>
4701
4702 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4703
47042019-05-10 Tom Tromey <tromey@adacore.com>
4705
4706 * ada-lang.c (catch_ada_completer): New function.
4707 (_initialize_ada_language): Use it.
4708
47092019-05-10 Tom Tromey <tromey@adacore.com>
4710
4711 * thread.c (print_thread_info): Make "requested_threads" const.
4712 * gdbthread.h (print_thread_info): Make "requested_threads"
4713 const.
4714 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4715 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4716
47172019-05-08 Tom Tromey <tom@tromey.com>
4718
4719 * gdbtypes.c (objfile_type_data): Change type.
4720 (objfile_type, _initialize_gdbtypes): Update.
4721
47222019-05-08 Tom Tromey <tom@tromey.com>
4723
4724 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4725 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4726 (_initialize_dwarf2_frame): Update.
4727
47282019-05-08 Tom Tromey <tom@tromey.com>
4729
4730 * objc-lang.c (objc_objfile_data): Change type.
4731 (find_methods): Update.
4732 (_initialize_objc_lang): Remove.
4733
47342019-05-08 Tom Tromey <tom@tromey.com>
4735
4736 * stabsread.c (rs6000_builtin_type_data): Change type.
4737 (rs6000_builtin_type, _initialize_stabsread): Update.
4738
47392019-05-08 Tom Tromey <tom@tromey.com>
4740
4741 * mips-tdep.c (mips_pdr_data): Remove.
4742 (_initialize_mips_tdep): Update.
4743
47442019-05-08 Tom Tromey <tom@tromey.com>
4745
4746 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4747 (hppa_init_objfile_priv_data, read_unwind_info)
4748 (find_unwind_entry, _initialize_hppa_tdep): Update.
4749
47502019-05-08 Tom Tromey <tom@tromey.com>
4751
4752 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4753 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4754 on obstack.
4755 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4756
47572019-05-08 Tom Tromey <tom@tromey.com>
4758
4759 * mdebugread.c (basic_type_data): Change type.
4760 (basic_type, _initialize_mdebugread): Update.
4761
47622019-05-08 Tom Tromey <tom@tromey.com>
4763
4764 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4765
47662019-05-08 Tom Tromey <tom@tromey.com>
4767
4768 * nto-tdep.c (nto_inferior_data_reg): Change type.
4769 (nto_inferior_data): Update.
4770 (nto_inferior_data_cleanup, nto_new_inferior_data)
4771 (_initialize_nto_tdep): Remove.
4772 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4773
47742019-05-08 Tom Tromey <tom@tromey.com>
4775
4776 * ada-lang.c (struct ada_inferior_data): Add initializers.
4777 (ada_inferior_data): Change type.
4778 (ada_inferior_data_cleanup): Remove.
4779 (get_ada_inferior_data, ada_inferior_exit)
4780 (struct ada_pspace_data): Add initializers, destructor.
4781 (ada_pspace_data_handle): Change type.
4782 (get_ada_pspace_data): Update.
4783 (ada_pspace_data_cleanup): Remove.
4784
47852019-05-08 Tom Tromey <tom@tromey.com>
4786
4787 * coffread.c (struct coff_symfile_info): Add initializers.
4788 (coff_objfile_data_key): Move lower. Change type.
4789 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4790 Update.
4791 (coff_free_info): Remove.
4792
47932019-05-08 Tom Tromey <tom@tromey.com>
4794
4795 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4796 (fbsd_pspace_data_handle): Move lower. Change type.
4797 (get_fbsd_pspace_data): Update.
4798 (fbsd_pspace_data_cleanup): Remove.
4799 (_initialize_fbsd_tdep): Update.
4800
48012019-05-08 Tom Tromey <tom@tromey.com>
4802
4803 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4804 (get_ada_tasks_pspace_data): Update.
4805 (ada_tasks_pspace_data_cleanup): Remove.
4806 (_initialize_tasks): Update.
4807 (ada_tasks_inferior_data_handle): Change type.
4808 (get_ada_tasks_inferior_data): Update.
4809 (ada_tasks_inferior_data_cleanup): Remove.
4810 (struct ada_tasks_pspace_data): Add initializers.
4811
48122019-05-08 Tom Tromey <tom@tromey.com>
4813
4814 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4815 * symfile-debug.c (debug_sym_get_probes): Change type.
4816 * stap-probe.c (handle_stap_probe):
4817 (stap_static_probe_ops::get_probes): Change type.
4818 * probe.h (class static_probe_ops) <get_probes>: Change type.
4819 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4820 (parse_probes_in_pspace): Update.
4821 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4822 Update.
4823 (any_static_probe_ops::get_probes): Change type.
4824 * elfread.c (elfread_data): New typedef.
4825 (probe_key): Change type.
4826 (elf_get_probes): Likewise. Update.
4827 (probe_key_free): Remove.
4828 (_initialize_elfread): Update.
4829 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4830 Change type.
4831 (dtrace_process_dof_probe, dtrace_process_dof)
4832 (dtrace_static_probe_ops::get_probe): Change type.
4833
48342019-05-08 Tom Tromey <tom@tromey.com>
4835
4836 * xcoffread.c (struct xcoff_symfile_info): Rename from
4837 coff_symfile_info. Add initializers.
4838 (xcoff_objfile_data_key): Move lower. Change type.
4839 (XCOFF_DATA): Rewrite.
4840 (xcoff_free_info): Remove.
4841 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4842 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4843 (xcoff_initial_scan): Update.
4844
48452019-05-08 Tom Tromey <tom@tromey.com>
4846
4847 * solib-svr4.c (struct svr4_info): Add initializers and
4848 destructor.
4849 <probes_table>: Now an htab_up.
4850 (solib_svr4_pspace_data): Change type.
4851 (free_probes_table): Simplify.
4852 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4853 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4854 (probes_table_remove_objfile_probes, register_solib_event_probe)
4855 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4856 (_initialize_svr4_solib): Update.
4857
48582019-05-08 Tom Tromey <tom@tromey.com>
4859
4860 * remote.c (remote_pspace_data): Change type.
4861 (remote_pspace_data_cleanup): Remove.
4862 (get_remote_exec_file, set_pspace_remote_exec_file)
4863 (_initialize_remote): Update.
4864
48652019-05-08 Tom Tromey <tom@tromey.com>
4866
4867 * breakpoint.c (breakpoint_objfile_key): Change type.
4868 (get_breakpoint_objfile_data): Update.
4869 (free_breakpoint_objfile_data): Remove.
4870 (_initialize_breakpoint): Update.
4871
48722019-05-08 Tom Tromey <tom@tromey.com>
4873
4874 * linux-tdep.c (struct linux_info): Add initializers.
4875 (linux_inferior_data): Move. Change type.
4876 (invalidate_linux_cache_inf): Update.
4877 (linux_inferior_data_cleanup): Remove.
4878 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4879
48802019-05-08 Tom Tromey <tom@tromey.com>
4881
4882 * auxv.c (auxv_inferior_data): Move. Change type.
4883 (auxv_inferior_data_cleanup): Remove.
4884 (invalidate_auxv_cache_inf): Rewrite.
4885 (get_auxv_inferior_data, _initialize_auxv): Update.
4886
48872019-05-08 Tom Tromey <tom@tromey.com>
4888
4889 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4890 (symfile_debug_objfile_data_key): Change type.
4891 (symfile_debug_installed, debug_qf_has_symbols)
4892 (debug_qf_find_last_source_symtab)
4893 (debug_qf_forget_cached_source_info)
4894 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4895 (debug_qf_print_stats, debug_qf_dump)
4896 (debug_qf_expand_symtabs_for_function)
4897 (debug_qf_expand_all_symtabs)
4898 (debug_qf_expand_symtabs_with_fullname)
4899 (debug_qf_map_matching_symbols)
4900 (debug_qf_expand_symtabs_matching)
4901 (debug_qf_find_pc_sect_compunit_symtab)
4902 (debug_qf_map_symbol_filenames)
4903 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4904 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4905 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4906 (debug_sym_read_linetable, debug_sym_relocate): Update.
4907 (symfile_debug_free_objfile): Remove.
4908 (install_symfile_debug_logging, _initialize_symfile_debug):
4909 Update.
4910
49112019-05-08 Tom Tromey <tom@tromey.com>
4912
4913 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4914 allocate_on_obstack.
4915 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4916 (get_dwarf2_per_objfile): Update.
4917 (set_dwarf2_per_objfile): Remove.
4918 (dwarf2_has_info, dwarf2_get_section_info): Update.
4919 (dwarf2_free_objfile): Remove.
4920 (_initialize_dwarf2_read): Update.
4921
49222019-05-08 Tom Tromey <tom@tromey.com>
4923
4924 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4925 initializers.
4926 <unsupported_script_warning_printed,
4927 script_not_found_warning_printed>: Now bool.
4928 (auto_load_pspace_data): Change type.
4929 (~auto_load_pspace_info): Rename from
4930 auto_load_pspace_data_cleanup.
4931 (get_auto_load_pspace_data, init_loaded_scripts_info)
4932 (clear_section_scripts, maybe_print_unsupported_script_warning)
4933 (maybe_print_script_not_found_warning, _initialize_auto_load):
4934 Update.
4935
49362019-05-08 Tom Tromey <tom@tromey.com>
4937
4938 * objfiles.c (objfile_pspace_info): Add destructor and
4939 initializers.
4940 (objfiles_pspace_data): Change type.
4941 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4942 (get_objfile_pspace_data): Update.
4943 (objfiles_bfd_data): Change type.
4944 (get_objfile_bfd_data): Update.
4945 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4946
49472019-05-08 Tom Tromey <tom@tromey.com>
4948
4949 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4950 Change type.
4951 (get_catch_syscall_inferior_data): Update.
4952 (catch_syscall_inferior_data_cleanup): Remove.
4953 (_initialize_break_catch_syscall): Update.
4954
49552019-05-08 Tom Tromey <tom@tromey.com>
4956
4957 * inflow.c (struct terminal_info): Add destructor and
4958 initializers.
4959 (inflow_inferior_data): Change type.
4960 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4961 (get_inflow_inferior_data, inflow_inferior_exit)
4962 (swap_terminal_info, _initialize_inflow): Update.
4963
49642019-05-08 Tom Tromey <tom@tromey.com>
4965
4966 * target-dcache.c (target_dcache_cleanup): Remove.
4967 (target_dcache_aspace_key): Change type.
4968 (target_dcache_init_p, target_dcache_invalidate)
4969 (target_dcache_get, target_dcache_get_or_init)
4970 (_initialize_target_dcache): Update.
4971 * dcache.h (struct dcache_deleter): New.
4972
49732019-05-08 Tom Tromey <tom@tromey.com>
4974
4975 * symtab.c (struct symbol_cache): Add destructor and
4976 initializers.
4977 (symbol_cache_key): Move. Change type.
4978 (make_symbol_cache, free_symbol_cache): Remove.
4979 (get_symbol_cache): Update.
4980 (symbol_cache_cleanup): Remove.
4981 (ALL_PSPACES, symbol_cache_flush)
4982 (maintenance_print_symbol_cache)
4983 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4984 Update.
4985
49862019-05-08 Tom Tromey <tom@tromey.com>
4987
4988 * symtab.c (struct main_info): Add destructor and initializers.
4989 (main_progspace_key): Move. Change type.
4990 (get_main_info): Update.
4991 (main_info_cleanup): Remove.
4992 (_initialize_symtab): Update.
4993
49942019-05-08 Tom Tromey <tom@tromey.com>
4995
4996 * registry.h (DECLARE_REGISTRY): Define the _key class.
4997
49982019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
4999
5000 * NEWS: Merge two 'New commands' sections.
5001
50022019-05-08 Joel Brobecker <brobecker@adacore.com>
5003
5004 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5005 parameter and use Ada language definition instead.
5006 (ada_val_print_ptr): Remove unused language parameter.
5007 (ada_val_print_num): Remove language parameter and use Ada language
5008 definition instead.
5009 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5010 parameter.
5011 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5012 parameter and use Ada language definition instead.
5013 (ada_val_print_1): Update all ada_val_print_xxx calls.
5014 Remove language parameter.
5015 (ada_val_print): Update ada_val_print_1 call.
5016
50172019-05-08 Tom Tromey <tromey@adacore.com>
5018
5019 * remote.c (remote_hw_watchpoint_limit)
5020 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5021 Now static.
5022
50232019-05-08 Tom Tromey <tromey@adacore.com>
5024
5025 * maint.c (_initialize_maint_cmds): Move initialization code to
5026 remote.c.
5027 (watchdog, show_watchdog): Move to remote.c.
5028 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5029 "watchdog" static.
5030 (_initialize_remote): Move initialization code from maint.c.
5031 * defs.h (watchdog): Don't declare.
5032
50332019-05-08 Tom Tromey <tromey@adacore.com>
5034
5035 * tui/tui-interp.c: Include main.h.
5036 * interps.c: Include main.h.
5037 * main.h (interpreter_p): Declare.
5038 * defs.h (interpreter_p): Don't declare.
5039
50402019-05-08 Tom Tromey <tromey@adacore.com>
5041
5042 * dwarf2loc.c: Include dwarf2read.h.
5043 * defs.h (read_unsigned_leb128): Don't declare.
5044 * dwarf2read.h (read_unsigned_leb128): Declare.
5045
50462019-05-08 Tom Tromey <tromey@adacore.com>
5047
5048 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5049 method.
5050
50512019-05-08 Tom Tromey <tromey@adacore.com>
5052
5053 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5054 when no wrap column is set.
5055
50562019-05-08 Tom Tromey <tromey@adacore.com>
5057
5058 * c-lang.c (c_get_string): Handle non-C-style arrays.
5059
50602019-05-08 Tom Tromey <tromey@adacore.com>
5061
5062 * typeprint.c (print_offset_data::update): Print the bit offset,
5063 not the number of bits remaining.
5064
50652019-05-08 Tom Tromey <tromey@adacore.com>
5066
5067 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5068 padding at end of comment.
5069
50702019-05-08 Tom Tromey <tromey@adacore.com>
5071
5072 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5073 Compare main types.
5074
50752019-05-06 Tom Tromey <tom@tromey.com>
5076
5077 * common/scoped_mmap.c: Include common-defs.h.
5078 * common/scoped_mmap.h: Don't include config.h.
5079
50802019-05-04 Tom Tromey <tom@tromey.com>
5081
5082 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5083 (struct aarch64_call_info): Add initializers.
5084 <si>: Now a std::vector.
5085 (pass_on_stack, aarch64_push_dummy_call): Update.
5086
50872019-05-04 Simon Marchi <simon.marchi@efficios.com>
5088 Tom Tromey <tom@tromey.com>
5089
5090 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5091 (ppc_threads): Now a std::vector. Now static.
5092 (hwdebug_find_thread_points_by_tid)
5093 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5094 Update.
5095
50962019-05-04 Tom Tromey <tom@tromey.com>
5097
5098 * arc-tdep.c (arc_tdesc_init): Return bool.
5099
51002019-05-04 Tom Tromey <tom@tromey.com>
5101
5102 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5103 Use gdb_assert_not_reached.
5104
51052019-05-04 Tom Tromey <tom@tromey.com>
5106
5107 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5108 "false".
5109
51102019-05-04 Tom Tromey <tom@tromey.com>
5111
5112 * arc-tdep.c (arc_tdesc_init): Use bool.
5113
51142019-05-04 Tom Tromey <tom@tromey.com>
5115
5116 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5117
51182019-05-04 Tom Tromey <tom@tromey.com>
5119
5120 * cli/cli-cmds.c (valid_command_p): Return bool.
5121
51222019-05-04 Tom Tromey <tom@tromey.com>
5123
5124 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5125 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5126
51272019-05-04 Raul Tambre <raul@tambre.ee>
5128
5129 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5130 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5131 operator for comparison.
5132
51332019-05-04 Tom Tromey <tom@tromey.com>
5134
5135 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5136 (lookup_partial_symbol, print_partial_symbols)
5137 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5138 (psymbol_compare): Update.
5139 (add_psymbol_to_bcache): Clear the entire psymbol.
5140 (maintenance_check_psymtabs): Update.
5141 * psympriv.h (struct partial_symbol): Don't derive from
5142 general_symbol_info.
5143 <obj_section, unrelocated_address, address,
5144 set_unrelocated_address>: Update.
5145 <ginfo>: New member.
5146 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5147 (debug_names::write_psymbols): Update.
5148
51492019-05-04 Tom de Vries <tdevries@suse.de>
5150
5151 * contrib/cc-with-tweaks.sh: Support -n arg.
5152
51532019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5154
5155 * corelow.c (core_target::detach): Ensure frame cache and
5156 register caches are cleared.
5157 inferior.c (exit_inferior_1): Likewise.
5158
51592019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5160 Tom Tromey <tom@tromey.com>
5161
5162 * dictionary.c (collate_pending_symbols_by_language): Remove
5163 "struct" from foreach.
5164 * symtab.c (lookup_global_symbol_from_objfile)
5165 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5166 foreach.
5167 * ser-tcp.c (net_open): Remove "struct" from foreach.
5168 * objfiles.c (objfile_relocate, objfile_rebase)
5169 (objfile_has_symbols): Remove "struct" from foreach.
5170 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5171 from foreach.
5172 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5173 foreach.
5174 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5175 "struct" from foreach.
5176 * ada-lang.c (create_excep_cond_exprs)
5177 (ada_exception_catchpoint_cond_string): Remove "struct" from
5178 foreach.
5179
51802019-05-03 Tom Tromey <tromey@adacore.com>
5181
5182 * ada-exp.y (convert_char_literal): Check suffix of each
5183 enumerator.
5184
51852019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5186
5187 PR ada/21406:
5188 * ada-exp.y (yywrap): Don't define.
5189 * ada-lex.l (%option): Add noyywrap
5190 (yywrap): Remove.
5191
51922019-05-03 Eli Zaretskii <eliz@gnu.org>
5193
5194 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5195 _WIN32_WINNT to the XP level, unless already defined to a higher
5196 level.
5197
5198 * unittests/parse-connection-spec-selftests.c:
5199 * ser-tcp.c:
5200 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5201 override.
5202
5203 * symfile.c (find_separate_debug_file): Remove colon from the
5204 drive spec of DOS/Windows file names of the target, so that the
5205 file name produced from DEBUGDIR and the target's directory will
5206 be valid on DOS/Windows systems.
5207
52082019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5209
5210 * rust-lang.c (val_print_struct): Handle printing structures
5211 containing strings.
5212
52132019-05-02 Tom Tromey <tromey@adacore.com>
5214
5215 * valarith.c (_initialize_valarith): Remove.
5216
52172019-05-01 Tom Tromey <tromey@adacore.com>
5218
5219 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5220 bitfields.
5221
52222019-05-01 Tom Tromey <tromey@adacore.com>
5223
5224 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5225 for big-endian copies.
5226
52272019-04-30 Ali Tamur <tamur@google.com>
5228 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5229 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5230 (read_3_bytes): New function.
5231
52322019-04-30 Joel Brobecker <brobecker@adacore.com>
5233
5234 * windows-nat.c (main_thread_id): Delete.
5235 (handle_output_debug_string): Replace main_thread_id by
5236 current_event.dwThreadId.
5237 (fake_create_process): Likewise.
5238 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5239 Do not set main_thread_id.
5240 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5241 current_event.dwThreadId.
5242 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5243
52442019-04-30 Joel Brobecker <brobecker@adacore.com>
5245
5246 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5247 Use current_event.dwThreadId instead of main_thread_id.
5248
52492019-04-30 Tom Tromey <tromey@adacore.com>
5250
5251 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5252 (create_excep_cond_exprs): Iterate over program spaces.
5253 (ada_exception_catchpoint_cond_string): Examine all minimal
5254 symbols for exception types.
5255
52562019-04-30 Tom Tromey <tromey@adacore.com>
5257
5258 PR c++/24470:
5259 * dwarf2read.c (process_structure_scope): Handle case where type
5260 has template parameters but no symbol was created.
5261
52622019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5263 Chris January <chris.january@arm.com>
5264
5265 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5266 qualifier.
5267 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5268
52692019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5270
5271 * f-typeprint.c (f_print_type): Update rules for printing
5272 whitespace.
5273 (f_type_print_varspec_suffix): Likewise.
5274
52752019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5276 Chris January <chris.january@arm.com>
5277
5278 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5279 function arguments.
5280
52812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5282
5283 * f-lang.c (build_fortran_types): Change name of void type to
5284 lower case.
5285 * f-typeprint.c (f_type_print_base): Print the name of the void
5286 type, rather than a fixed string.
5287 * f-valprint.c (f_decorations): Use lower case void string.
5288
52892019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5290 Chris January <chris.january@arm.com>
5291
5292 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5293 types for Fortran.
5294
52952019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5296 Chris January <chris.january@arm.com>
5297 David Lecomber <david.lecomber@arm.com>
5298
5299 * f-exp.y (BINOP_INTRINSIC): New token.
5300 (exp): New parser rule handling BINOP_INTRINSIC.
5301 (f77_keywords): Add new builtin procedures.
5302 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5303 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5304 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5305 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5306 (print_unop_subexp_f): New function.
5307 (print_binop_subexp_f): New function.
5308 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5309 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5310 (dump_subexp_body_f): Likewise.
5311 (operator_check_f): Likewise.
5312 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5313 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5314
53152019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5316
5317 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5318 UNOP_KIND.
5319 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5320 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5321 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5322 (operator_length_f): New fuction.
5323 (print_subexp_f): New function.
5324 (op_name_f): New function.
5325 (dump_subexp_body_f): New function.
5326 (operator_check_f): New function.
5327 (exp_descriptor_f): Replace standard expression handling functions
5328 with new functions.
5329 * gdb/fortran-operator.def: New file.
5330 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5331 * gdb/std-operator.def: Remove UNOP_KIND.
5332
53332019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5334
5335 * std-operator.def: Remove unbalanced, stray double quote
5336 character.
5337
53382019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5339 Chris January <chris.january@arm.com>
5340 Daniel Everett <daniel.everett@arm.com>
5341 Nick Forrington <nick.forrington@arm.com>
5342 Richard Bunt <richard.bunt@arm.com>
5343
5344 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5345 of depth when printing anonymous structs or unions.
5346 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5347 Don't print either the top-level value, or the children if the
5348 max-depth is exceeded.
5349 (ppscm_print_children): When printing the key of a map, allow one
5350 extra level of depth.
5351 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5352 print either the top-level value, or the children if the max-depth
5353 is exceeded.
5354 (print_children): When printing the key of a map, allow one extra
5355 level of depth.
5356 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5357 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5358 (user_print_options): Initialise max_depth field.
5359 (val_print_scalar_or_string_type_p): New function.
5360 (val_print): Check to see if the max depth has been reached.
5361 (val_print_check_max_depth): Define new function.
5362 (show_print_max_depth): New function.
5363 (_initialize_valprint): Add 'print max-depth' option.
5364 * valprint.h (struct value_print_options) <max_depth>: New field.
5365 (val_print_check_max_depth): Declare new function.
5366 * NEWS: Document new feature.
5367
53682019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5369
5370 * ada-lang.c (ada_language_defn): Initialise new field.
5371 * c-lang.c (c_is_string_type_p): New function.
5372 (c_language_defn): Initialise new field.
5373 (cplus_language_defn): Initialise new field.
5374 (asm_language_defn): Initialise new field.
5375 (minimal_language_defn): Initialise new field.
5376 * c-lang.h (c_is_string_type_p): Declare new function.
5377 * d-lang.c (d_language_defn): Initialise new field.
5378 * f-lang.c (f_is_string_type_p): New function.
5379 (f_language_defn): Initialise new field.
5380 * go-lang.c (go_is_string_type_p): New function.
5381 (go_language_defn): Initialise new field.
5382 * language.c (default_is_string_type_p): New function.
5383 (unknown_language_defn): Initialise new field.
5384 (auto_language_defn): Initialise new field.
5385 * language.h (struct language_defn) <la_is_string_type_p>: New
5386 member variable.
5387 (default_is_string_type_p): Declare new function.
5388 * m2-lang.c (m2_language_defn): Initialise new field.
5389 * objc-lang.c (objc_language_defn): Initialise new field.
5390 * opencl-lang.c (opencl_language_defn): Initialise new field.
5391 * p-lang.c (pascal_is_string_type_p): New function.
5392 (pascal_language_defn): Initialise new field.
5393 * rust-lang.c (rust_is_string_type_p): New function.
5394 (rust_language_defn): Initialise new field.
5395
53962019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5397
5398 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5399 New field.
5400 * ada-lang.c (ada_language_defn): Initialise new field.
5401 * c-lang.c (c_language_defn): Likewise.
5402 (cplus_language_defn): Likewise.
5403 (asm_language_defn): Likewise.
5404 (minimal_language_defn): Likewise.
5405 * d-lang.c (d_language_defn): Likewise.
5406 * f-lang.c (f_language_defn): Likewise.
5407 * go-lang.c (go_language_defn): Likewise.
5408 * language.c (unknown_language_defn): Likewise.
5409 (auto_language_defn): Likewise.
5410 * m2-lang.c (m2_language_defn): Likewise.
5411 * objc-lang.c (objc_language_defn): Likewise.
5412 * opencl-lang.c (opencl_language_defn): Likewise.
5413 * p-lang.c (pascal_language_defn): Likewise.
5414 * rust-lang.c (rust_language_defn): Likewise.
5415
54162019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5417
5418 * ada-lang.c (ada_is_character_type): Change return type to bool.
5419 (ada_is_string_type): Likewise.
5420 * ada-lang.h (ada_is_character_type): Update declaration
5421 (ada_is_string_type): Likewise.
5422
54232019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5424
5425 Support style in 'frame|thread apply'
5426
5427 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5428 * record.c (record_start, record_stop): Update callers of
5429 execute_command_to_string with false.
5430 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5431 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5432 methods.
5433 (class string_file): New constructor with term_out parameter.
5434 Override methods term_out and can_emit_style_escape. New member
5435 term_out.
5436 (class stdio_file): Override can_emit_style_escape.
5437 (class tee_file): Override term_out and can_emit_style_escape.
5438 * utils.h (can_emit_style_escape): Remove.
5439 * utils.c (can_emit_style_escape): Likewise.
5440 Update all callers of can_emit_style_escape (SOMESTREAM) to
5441 SOMESTREAM->can_emit_style_escape.
5442 * source-cache.c (source_cache::get_source_lines): Likewise.
5443 * stack.c (frame_apply_command_count): Call execute_command_to_string
5444 passing the term_out characteristic of the current gdb_stdout.
5445 * thread.c (thr_try_catch_cmd): Likewise.
5446 * top.c (execute_command_to_string): pass term_out parameter
5447 to construct the string_file for the command output.
5448 * ui-file.c (term_cli_styling): New function (most code moved
5449 from utils.c can_emit_style_escape).
5450 (string_file::string_file, string_file::can_emit_style_escape,
5451 stdio_file::can_emit_style_escape, tee_file::term_out,
5452 tee_file::can_emit_style_escape): New functions.
5453
54542019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5455
5456 * NEWS: Mention the new set|show may-call-functions.
5457 * infcall.c (may_call_functions_p): New variable.
5458 (show_may_call_functions_p): New function.
5459 (call_function_by_hand_dummy): Throws an error if not
5460 may-call-functions.
5461 (_initialize_infcall): Call add_setshow_boolean_cmd for
5462 may-call-functions.
5463
54642019-04-25 Keith Seitz <keiths@redhat.com>
5465
5466 PR c++/24367
5467 * cp-support.c (inspect_type): Don't attempt substitutions
5468 of symbol with the same name.
5469
54702019-04-25 Tom Tromey <tromey@adacore.com>
5471
5472 PR gdb/24475:
5473 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5474 static.
5475
54762019-04-25 Tom Tromey <tromey@adacore.com>
5477
5478 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5479 rvalue reference.
5480 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5481 (gdb_xml_parser::parse): Use std::move.
5482 * python/python-internal.h (gdbpy_convert_exception): Take a const
5483 reference.
5484 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5485 std::move.
5486 * python/py-utils.c (gdbpy_convert_exception): Take a const
5487 reference.
5488 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5489 Use std::move.
5490 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5491 Use std::move.
5492 * mi/mi-main.c (mi_print_exception): Take a const reference.
5493 * main.c (handle_command_errors): Take a const reference.
5494 * linespec.c (parse_linespec): Use std::move.
5495 * infcall.c (run_inferior_call): Use std::move.
5496 (call_function_by_hand_dummy): Use std::move.
5497 * exec.c (try_open_exec_file): Use std::move.
5498 * exceptions.h (exception_print, exception_fprintf)
5499 (exception_print_same): Update.
5500 * exceptions.c (print_exception, exception_print)
5501 (exception_fprintf, exception_print_same): Change parameters to
5502 const reference.
5503 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5504 * common/new-op.c: Use std::move.
5505 * common/common-exceptions.h (struct gdb_exception): Add move
5506 constructor.
5507 (struct gdb_exception_error, struct gdb_exception_quit, struct
5508 gdb_quit_bad_alloc): Change constructor to move constructor.
5509 (throw_exception): Change parameter to rvalue reference.
5510 * common/common-exceptions.c (throw_exception): Take rvalue
5511 reference.
5512 * cli/cli-interp.c (safe_execute_command): Use std::move.
5513 * breakpoint.c (insert_bp_location, location_to_sals): Use
5514 std::move.
5515
55162019-04-25 Tom Tromey <tromey@adacore.com>
5517
5518 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5519 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5520 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5521 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5522 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5523 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5524 guile/scm-value.c: Use unpack.
5525 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5526 gdbscm_gdb_exception.
5527 (gdbscm_throw_gdb_exception): Likewise.
5528 (struct gdbscm_gdb_exception): New.
5529 (unpack): New function.
5530 (gdbscm_wrap): Use unpack.
5531
55322019-04-25 Tom Tromey <tromey@adacore.com>
5533
5534 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5535 (gdb_rl_callback_handler): Use std::move.
5536 * common/common-exceptions.h (struct gdb_exception): Add move
5537 assignment operator.
5538 (throw_exception_sjlj): Change "exception" to const reference.
5539 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5540 (throw_exception_sjlj): Change "exception" to const reference.
5541
55422019-04-25 Tom Tromey <tromey@adacore.com>
5543
5544 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5545 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5546 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5547 Update.
5548 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5549 Update.
5550 * mi/mi-interp.c (mi_interp::exec): Update.
5551 * linespec.c (parse_linespec): Update.
5552 * infcall.c (run_inferior_call): Update.
5553 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5554 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5555 (gdbscm_lookup_global_symbol): Update.
5556 * guile/scm-param.c (gdbscm_parameter_value): Update.
5557 * guile/scm-frame.c (gdbscm_frame_read_register)
5558 (gdbscm_frame_read_var): Update.
5559 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5560 * exec.c (try_open_exec_file): Update.
5561 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5562 (gdb_rl_callback_handler): Update.
5563 * common/common-exceptions.h (exception_none): Don't declare.
5564 * common/common-exceptions.c (exception_none): Don't define.
5565 (struct catcher) <exception>: Update.
5566 * cli/cli-interp.c (safe_execute_command): Update.
5567 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5568
55692019-04-25 Ali Tamur <tamur@google.com>
5570
5571 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5572 (read_attribute_value): Likewise.
5573 (dwarf2_read_addr_index): Update comment.
5574 (read_str_index): Add DW_FORM_strx.
5575 (dwarf2_string_attr): Likewise.
5576 (dwarf2_const_value_attr): Likewise.
5577 (dump_die_shallow): Likewise.
5578 (dwarf2_fetch_constant_bytes): Likewise.
5579 (skip_form_bytes): Likewise.
5580 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5581
55822019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5583
5584 PR corefiles/11608
5585 PR corefiles/18187
5586 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5587 OFFSET. Verify if current mapping contains an ELF header.
5588 (linux_find_memory_regions_full): Adjust call to
5589 dump_mapping_p.
5590
55912019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5592 Kang Li <kanglictf@gmail.com>
5593
5594 PR gdb/21600
5595
5596 * dwarf2-frame.c (read_initial_length): Be consistent about using
5597 unsigned representation of length.
5598 (decode_frame_entry_1): Likewise. Check for wraparound of
5599 end pointer as well as buffer overflow.
5600
56012019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5602
5603 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5604 "vq".
5605
56062019-04-24 Tom Tromey <tromey@adacore.com>
5607
5608 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5609
56102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5611
5612 * s12z-tdep.c (s12z_unwind_pc): Delete.
5613 (s12z_unwind_sp): Delete.
5614 (s12z_gdbarch_init): Don't register deleted functions with
5615 gdbarch.
5616
56172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5618
5619 * rl78-tdep.c (rl78_unwind_sp): Delete.
5620 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5621
56222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5623
5624 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5625 (xstormy16_unwind_pc): Delete.
5626 (xstormy16_dummy_id): Delete.
5627 (xstormy16_gdbarch_init): Don't register deleted functions with
5628 gdbarch.
5629
56302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5631
5632 * vax-tdep.c (vax_unwind_pc): Delete.
5633 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5634
56352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5636
5637 * v850-tdep.c (v850_unwind_sp): Delete.
5638 (v850_unwind_pc): Delete.
5639 (v850_dummy_id): Delete.
5640 (v850_gdbarch_init): Don't register deleted functions with
5641 gdbarch.
5642
56432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5644
5645 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5646 (tilegx_unwind_pc): Delete.
5647 (tilegx_unwind_dummy_id): Delete.
5648 (tilegx_gdbarch_init): Don't register deleted functions with
5649 gdbarch.
5650
56512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5652
5653 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5654 (tic6x_dummy_id): Delete.
5655 (tic6x_gdbarch_init): Don't register deleted functions with
5656 gdbarch.
5657
56582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5659
5660 * sparc-tdep.c (sparc_unwind_pc): Delete.
5661 (sparc32_gdbarch_init): Don't register deleted function with
5662 gdbarch.
5663
56642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5665
5666 * sh-tdep.c (sh_unwind_sp): Delete.
5667 (sh_unwind_pc): Delete.
5668 (sh_dummy_id): Delete.
5669 (sh_gdbarch_init): Don't register deleted functions with
5670 gdbarch.
5671
56722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5673
5674 * score-tdep.c (score_unwind_sp): Delete.
5675 (score_unwind_pc): Delete.
5676 (score_dummy_id): Delete.
5677 (score_gdbarch_init): Don't register deleted functions with
5678 gdbarch.
5679
56802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5681
5682 * rx-tdep.c (rx_unwind_pc): Delete.
5683 (rx_unwind_sp): Delete.
5684 (rx_dummy_id): Delete.
5685 (rx_gdbarch_init): Don't register deleted functions with
5686 gdbarch. Update comment.
5687
56882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5689
5690 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5691 (rs6000_dummy_id): Delete.
5692 (rs6000_gdbarch_init): Don't register deleted functions with
5693 gdbarch.
5694
56952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5696
5697 * or1k-tdep.c (or1k_dummy_id): Delete.
5698 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5699
57002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5701
5702 * nios2-tdep.c (nios2_dummy_id): Delete.
5703 (nios2_unwind_sp): Delete.
5704 (nios2_gdbarch_init): Don't register deleted functions with
5705 gdbarch.
5706
57072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5708
5709 * nds32-tdep.c (nds32_dummy_id): Delete.
5710 (nds32_unwind_pc): Delete.
5711 (nds32_unwind_sp): Delete.
5712 (nds32_gdbarch_init): Don't register deleted functions with
5713 gdbarch.
5714
57152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5716
5717 * msp430-tdep.c (msp430_unwind_pc): Delete.
5718 (msp430_unwind_sp): Delete.
5719 (msp430_dummy_id): Delete.
5720 (msp430_gdbarch_init): Don't register deleted functions with
5721 gdbarch.
5722
57232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5724
5725 * moxie-tdep.c (moxie_unwind_sp): Delete.
5726 (moxie_unwind_pc): Delete.
5727 (moxie_dummy_id): Delete.
5728 (moxie_gdbarch_init): Don't register deleted functions with
5729 gdbarch.
5730
57312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5732
5733 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5734 (mn10300_unwind_pc): Delete.
5735 (mn10300_unwind_sp): Delete.
5736 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5737 mn10300_unwind_sp.
5738 (mn10300_frame_unwind_init): Don't register deleted functions with
5739 gdbarch.
5740
57412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5742
5743 * mep-tdep.c (mep_unwind_pc): Delete.
5744 (mep_unwind_sp): Delete.
5745 (mep_dummy_id): Delete.
5746 (mep_gdbarch_init): Don't register deleted functions with
5747 gdbarch.
5748
57492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5750
5751 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5752 (m68hc11_unwind_sp): Delete.
5753 (m68hc11_gdbarch_init): Don't register deleted functions with
5754 gdbarch.
5755
57562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5757
5758 * m32r-tdep.c (m32r_unwind_sp): Delete.
5759 (m32r_unwind_pc): Delete.
5760 (m32r_dummy_id): Delete.
5761 (m32r_gdbarch_init): Don't register deleted functions with
5762 gdbarch.
5763
57642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5765
5766 * m32c-tdep.c (m32c_unwind_pc): Delete.
5767 (m32c_unwind_sp): Delete.
5768 (m32c_dummy_id): Delete.
5769 (m32c_gdbarch_init): Don't register deleted functions with
5770 gdbarch.
5771
57722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5773
5774 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5775 (lm32_unwind_pc): Delete.
5776 (lm32_dummy_id): Delete.
5777 (lm32_gdbarch_init): Don't register deleted functions with
5778 gdbarch.
5779
57802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5781
5782 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5783 (iq2000_unwind_pc): Delete.
5784 (iq2000_dummy_id): Delete.
5785 (iq2000_gdbarch_init): Don't register deleted functions with
5786 gdbarch.
5787
57882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5789
5790 * nds32-tdep.c (nds32_type_align): Delete.
5791 (nds32_push_dummy_call): Use type_align instead.
5792
57932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5794
5795 * arm-tdep.c (arm_type_align): Only handle vector override case.
5796 (arm_push_dummy_call): Use type_align.
5797 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5798
57992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5800
5801 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5802 case.
5803 (pass_on_stack): Use type_align.
5804 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5805 function.
5806
58072019-04-23 Tom Tromey <tromey@adacore.com>
5808
5809 * dwarf2read.c (line_header::file_name_at): Remove unused
5810 overload.
5811
58122019-04-23 Tom de Vries <tdevries@suse.de>
5813
5814 PR gdb/24438
5815 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5816 invocation.
5817
5818
58192019-03-27 Ali Tamur <tamur@google.com>
5820
5821 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5822 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5823 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5824 (dwarf_expr_context::get_addr_index): Likewise
5825 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5826 (symbol_needs_eval_context::get_addr_index): Likewise
5827 (disassemble_dwarf_expression): Add DW_OP_addrx
5828 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5829 (read_cutu_die_from_dwo): Update comment
5830 (skip_one_die): Add DW_FORM_addrx
5831 (read_attribute_value): Likewise
5832 (var_decode_location): Add DW_OP_addrx
5833 (dwarf2_const_value_attr): Add DW_FORM_addrx
5834 (dump_die_shallow): Likewise
5835 (dwarf2_fetch_constant_bytes): Likewise
5836 (decode_locdesc): Add DW_OP_addrx
5837 (skip_form_bytes): Add DW_FORM_addrx
5838
58392019-04-22 Ali Tamur <tamur@google.com>
5840
5841 * MAINTAINERS (Write After Approval): Add self.
5842
58432019-04-22 Simon Marchi <simon.marchi@efficios.com>
5844
5845 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5846 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5847 (open_symbol_file_object): Likewise.
5848 (svr4_default_sos): Add info parameter.
5849 (svr4_read_so_list): Likewise.
5850 (svr4_current_sos_direct): Adjust functions calls to pass down
5851 info.
5852 (svr4_current_sos_1): Add info parameter.
5853 (svr4_current_sos): Call get_svr4_info, pass info down to
5854 svr4_current_sos_1.
5855 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5856 get_svr4_info.
5857 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5858 get_svr4_info.
5859 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5860 to get_svr4_info.
5861 (probes_table_remove_objfile_probes): Likewise.
5862 (register_solib_event_probe): Add info parameter.
5863 (solist_update_incremental): Pass info parameter down to
5864 svr4_read_so_list.
5865 (disable_probes_interface): Add info parameter.
5866 (svr4_handle_solib_event): Pass current_program_space to
5867 get_svr4_info. Adjust disable_probes_interface cleanup.
5868 (svr4_create_probe_breakpoints): Add info parameter, pass it
5869 down to register_solib_event_probe.
5870 (svr4_create_solib_event_breakpoints): Add info parameter,
5871 pass it down to svr4_create_probe_breakpoints.
5872 (enable_break): Pass info down to
5873 svr4_create_solib_event_breakpoints.
5874 (svr4_solib_create_inferior_hook): Pass current_program_space to
5875 get_svr4_info.
5876 (svr4_clear_solib): Likewise.
5877
58782019-04-22 Pedro Alves <palves@redhat.com>
5879
5880 * solib-svr4.c (svr4_free_objfile_observer): New.
5881 (probe_and_action::objfile): New field.
5882 (probes_table_htab_remove_objfile_probes)
5883 (probes_table_remove_objfile_probes): New functions.
5884 (register_solib_event_probe): Add 'objfile' parameter. Store it
5885 in the new probe_and_action. Don't store the probe in 'lookup'.
5886 (svr4_create_probe_breakpoints): Pass objfile to
5887 register_solib_event_probe.
5888 (_initialize_svr4_solib): Register a free_objfile observer.
5889
58902019-04-19 Tom Tromey <tom@tromey.com>
5891
5892 * common/queue.h: Remove.
5893
58942019-04-19 Tom Tromey <tom@tromey.com>
5895
5896 * event-loop.c: Don't include "common/queue.h".
5897
58982019-04-19 Tom Tromey <tom@tromey.com>
5899
5900 * remote.c (remote_target): Use delete.
5901 * remote-notif.h: Include <list>, not "common/queue.h".
5902 (notif_client_p): Remove typedef.
5903 (remote_notif_state): Add constructor, destructor, initializer.
5904 <notif_queue>: Now a std::list.
5905 (remote_notif_state_xfree): Don't declare.
5906 * remote-notif.c (remote_notif_process, handle_notification)
5907 (remote_notif_state_allocate): Update.
5908 (~remote_notif_state): Rename from remote_notif_state_xfree.
5909
59102019-04-19 Tom Tromey <tom@tromey.com>
5911
5912 * symfile.c (reread_symbols): Update.
5913 * objfiles.c (objfile_register_static_link)
5914 (objfile_lookup_static_link): Update
5915 (~objfile) Don't delete static_links.
5916 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5917
59182019-04-19 Tom Tromey <tom@tromey.com>
5919
5920 * type-stack.h (struct type_stack) <insert>: Constify string.
5921 * type-stack.c (type_stack::insert): Constify string.
5922 * gdbtypes.h (lookup_template_type): Update.
5923 (address_space_name_to_int): Update.
5924 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5925 const.
5926 (lookup_template_type): Make name const.
5927 * c-exp.y: Update rules.
5928 (lex_one_token, classify_name, classify_inner_name)
5929 (c_print_token): Update.
5930 * p-exp.y: Update rules.
5931 (yylex): Update.
5932 * f-exp.y: Update rules.
5933 (yylex): Update.
5934 * d-exp.y: Update rules.
5935 (lex_one_token, classify_name, classify_inner_name): Update.
5936 * parse.c (write_dollar_variable, copy_name): Return std::string.
5937 * parser-defs.h (copy_name): Change return type.
5938 * m2-exp.y: Update rules.
5939 (yylex): Update.
5940 * go-exp.y (lex_one_token): Update.
5941 Update rules.
5942 (classify_unsafe_function, classify_packaged_name)
5943 (classify_name, yylex): Update.
5944
59452019-04-19 Sergei Trofimovich <siarheit@google.com>
5946
5947 * configure.ac: add --enable-source-highlight switch.
5948 * configure: Regenerate.
5949 * top.c (print_gdb_version): plumb --enable-source-highlight
5950 status to "show configuration".
5951
59522019-04-19 Tom Tromey <tromey@adacore.com>
5953
5954 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5955 Check ADA_TYPE_P.
5956 (empty_record, ada_template_to_fixed_record_type_1)
5957 (template_to_static_fixed_type)
5958 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5959 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5960 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5961 macros.
5962
59632019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5964
5965 PR symtab/24423:
5966 * source.c (print_source_lines_base): Advance "iter" when a
5967 control character is seen.
5968
59692019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5970
5971 * inferior.h (struct infcall_suspend_state_deleter):
5972 Catch exception in destructor to avoid crash.
5973
59742019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5975
5976 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5977 close to the add_com "shell".
5978
59792019-04-18 Tom Tromey <tromey@adacore.com>
5980
5981 * process-stratum-target.h (class process_stratum_target)
5982 <stratum>: Add "final".
5983
59842019-04-17 Tom Tromey <tromey@adacore.com>
5985
5986 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5987 against nullptr before use.
5988
59892019-04-17 Alan Hayward <alan.hayward@arm.com>
5990
5991 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5992
59932019-04-17 Jim Wilson <jimw@sifive.com>
5994 Andrew Burgess <andrew.burgess@embecosm.com>
5995
5996 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5997 code read might fail, assume 4-byte breakpoint in that case.
5998
59992019-04-15 Leszek Swirski <leszeks@google.com>
6000
6001 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6002 rather than a hand-rolled POD check when checking for forced MEMORY
6003 classification.
6004
60052019-04-15 Alan Hayward <alan.hayward@arm.com>
6006
6007 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6008 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6009 function.
6010 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6011 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6012 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6013 declaration.
6014
60152019-04-15 Alan Hayward <alan.hayward@arm.com>
6016
6017 * aarch64-linux-nat.c
6018 (aarch64_linux_nat_target::thread_architecture): Add override.
6019 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6020 each VQ.
6021
60222019-04-15 Alan Hayward <alan.hayward@arm.com>
6023
6024 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6025
60262019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6027
6028 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6029 target types of size 96-bits, add some additional comments, and
6030 check that the builtin type we found was the correct size.
6031
60322019-04-12 Eli Zaretskii <eliz@gnu.org>
6033
6034 * utils.c (prompt_for_continue): Don't restore the styling at the
6035 end, as applied_style has the wrong value. This fixes styling in
6036 long lists of file names that are interrupted by the "Continue?"
6037 prompt.
6038
60392019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6040
6041 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6042 * c-lang.c (c_language_defn): Likewise.
6043 (cplus_language_defn): Likewise.
6044 (asm_language_defn): Likewise.
6045 (minimal_language_defn): Likewise.
6046 * d-lang.c (d_language_defn): Likewise.
6047 * f-lang.c (f_language_defn): Likewise.
6048 * go-lang.c (go_language_defn): Likewise.
6049 * language.c (unknown_language_defn): Likewise.
6050 (auto_language_defn): Likewise.
6051 * language.h (struct language_defn): Remove la_magic field.
6052 (LANG_MAGIC): Delete.
6053 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6054 * objc-lang.c (objc_language_defn): Likewise.
6055 * opencl-lang.c (opencl_language_defn): Likewise.
6056 * p-lang.c (pascal_language_defn): Likewise.
6057 * rust-lang.c (rust_language_defn): Likewise.
6058
60592019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6060
6061 * riscv-tdep.c (riscv_type_align): New function.
6062 (riscv_type_alignment): Delete.
6063 (riscv_arg_location): Use 'type_align'.
6064 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6065
60662019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6067
6068 * gdbtypes.c (type_align): A struct with no non-static fields also
6069 has alignment of 1.
6070
60712019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6072
6073 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6074 component to 0.
6075 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6076 member.
6077 (riscv_struct_info::analyse): New implementation using new
6078 analyse_inner member function.
6079 (riscv_struct_info::field_offset): New member function.
6080 (riscv_struct_info::m_offsets): New member variable.
6081 (riscv_struct_info::analyse_inner): New private member function,
6082 takes the old implementation of riscv_struct_info::analyse but
6083 extended to track field offsets.
6084 (riscv_call_arg_struct): Update the struct folding special cases
6085 to handle cases where empty C++ structs, which are non-zero
6086 length, are found.
6087 (riscv_arg_location): Initialise the length of each location, a
6088 non-zero length now indicates the location is in use.
6089 (riscv_push_dummy_call): Allow for the first location having a
6090 non-zero offset when setting up arguments.
6091 (riscv_return_value): Likewise, but for return values.
6092
60932019-04-11 Tom Tromey <tromey@adacore.com>
6094
6095 * utils.c (internal_vproblem): Make "msg" const.
6096
60972019-04-11 Alan Hayward <alan.hayward@arm.com>
6098
6099 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6100 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6101 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6102 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6103
61042019-04-10 Kevin Buettner <kevinb@redhat.com>
6105
6106 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6107 function.
6108 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6109 of amd64_collect_native_gregset.
6110 (amd64_linux_nat_target::store_registers): Likewise.
6111
61122019-04-10 Tom Tromey <tom@tromey.com>
6113
6114 * symtab.c (lookup_global_symbol_from_objfile)
6115 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6116 * objfiles.h (class separate_debug_iterator): New.
6117 (class separate_debug_range): New.
6118 (struct objfile) <separate_debug_objfiles>: New method.
6119 (objfile_separate_debug_iterate): Don't declare.
6120 * objfiles.c (separate_debug_iterator::operator++): Rename from
6121 objfile_separate_debug_iterate.
6122 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6123 iterator.
6124 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6125 iterator.
6126
61272019-04-10 Tom Tromey <tom@tromey.com>
6128
6129 * symfile.c (reread_symbols): Remove old comment.
6130 * objfiles.c (free_all_objfiles): Fix a typo.
6131
61322019-04-10 Tom Tromey <tom@tromey.com>
6133
6134 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6135 * minsyms.c (lookup_minimal_symbol): Use foreach.
6136 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6137 (lookup_minimal_symbol_solib_trampoline): Likewise.
6138 * symfile.c (reread_symbols): Use foreach.
6139
61402019-04-09 Ivan Begert <ivanbegert@gmail.com>
6141 Tom Tromey <tromey@adacore.com>
6142
6143 PR rust/24414:
6144 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6145 (rust_lex_int_test): Change "value" to be LONGEST.
6146 (rust_lex_tests): Add test for long integer literal.
6147
61482019-04-09 Tom Tromey <tromey@adacore.com>
6149
6150 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6151 to bool.
6152 (extended_remote_target::attach): Update.
6153 (remote_target::remote_notice_new_inferior): Update.
6154 (remote_target::add_current_inferior_and_thread): Update.
6155 * inferior.c (exit_inferior_1): Use "false".
6156 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6157
61582019-04-09 Simon Marchi <simon.marchi@efficios.com>
6159
6160 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6161 the "start" command.
6162
61632019-04-08 Kevin Buettner <kevinb@redhat.com>
6164
6165 * python/py-inferior.c (infpy_thread_from_thread_handle):
6166 Adjust comments to reflect renaming of thread_from_thread_handle
6167 to thread_from_handle. Adjust keywords. Fix type error message.
6168 (inferior_object_methods): Add thread_from_handle. Retain
6169 thread_from_thread_handle, but mark it as deprecated.
6170
61712019-04-08 Kevin Buettner <kevinb@redhat.com>
6172
6173 * gdbthread.h (find_thread_by_handle): Revise declaration.
6174 * thread.c (find_thread_by_handle): Likewise. Adjust
6175 implementation too.
6176 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6177 support for buffer objects as handles.
6178
61792019-04-08 Kevin Buettner <kevinb@redhat.com>
6180
6181 * python/py-infthread.c (thpy_thread_handle): New function.
6182 (thread_object_methods): Register thpy_thread_handle.
6183
61842019-04-08 Kevin Buettner <kevinb@redhat.com>
6185
6186 * gdbthread.h (thread_to_thread_handle): Declare.
6187 * thread.c (gdbtypes.h): Include.
6188 (thread_to_thread_handle): New function.
6189
6190 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6191 (target_thread_info_to_thread_handle): Declare.
6192 * target.c (target_thread_info_to_thread_handle): New function.
6193 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6194 * target-delegates.c: Regenerate.
6195
6196 * linux-thread-db.c (class thread_db_target): Add method
6197 thread_info_to_thread_handle.
6198 (thread_db_target::thread_info_to_thread_handle): Define.
6199 * remote.c (class remote_target): Add new method
6200 thread_info_to_thread_handle.
6201 (remote_target::thread_info_to_thread_handle): Define.
6202
62032019-04-08 Pedro Alves <palves@redhat.com>
6204
6205 * common/common-exceptions.c (throw_exception): Don't create
6206 named object to throw; throw directly.
6207 (throw_it): Likewise. Don't initialize gdb_exception::message
6208 here, with new; pass FMT and AP to the ctor instead.
6209 * common/common-exceptions.h: Include <string>.
6210 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6211 const char *, va_list)): New ctor. Use std::make_shared.
6212 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6213 errors)): Delete.
6214 (gdb_exception_error::gdb_exception_error(enum errors, const char
6215 *, va_list)): New.
6216 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6217 Add assertion.
6218 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6219 errors)): Delete.
6220 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6221 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6222 Add assertion.
6223
62242019-04-08 Tom Tromey <tom@tromey.com>
6225
6226 * valops.c (value_rtti_indirect_type): Replace throw_exception
6227 with throw.
6228 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6229 with throw.
6230 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6231 throw.
6232 * target.c (target_translate_tls_address): Replace throw_exception
6233 with throw.
6234 * stack.c (frame_apply_command_count): Replace throw_exception
6235 with throw.
6236 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6237 throw.
6238 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6239 with throw.
6240 * rs6000-tdep.c (rs6000_frame_cache)
6241 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6242 * remote.c: Replace throw_exception with throw.
6243 * record-full.c (record_full_message, record_full_wait_1)
6244 (record_full_restore): Replace throw_exception with throw.
6245 * record-btrace.c:
6246 (get_thread_current_frame_id, record_btrace_start_replaying)
6247 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6248 (cmd_record_btrace_start): Replace throw_exception with throw.
6249 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6250 throw.
6251 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6252 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6253 * linespec.c:
6254 (find_linespec_symbols): Replace throw_exception with throw.
6255 * infrun.c (displaced_step_prepare, resume): Replace
6256 throw_exception with throw.
6257 * infcmd.c (post_create_inferior): Replace throw_exception with
6258 throw.
6259 * inf-loop.c (inferior_event_handler): Replace throw_exception
6260 with throw.
6261 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6262 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6263 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6264 (get_prev_frame_always, get_frame_pc_if_available)
6265 (get_frame_address_in_block_if_available, get_frame_language):
6266 Replace throw_exception with throw.
6267 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6268 throw_exception with throw.
6269 * eval.c (fetch_subexp_value, evaluate_var_value)
6270 (evaluate_funcall, evaluate_subexp_standard): Replace
6271 throw_exception with throw.
6272 * dwarf2loc.c (call_site_find_chain)
6273 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6274 Replace throw_exception with throw.
6275 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6276 with throw.
6277 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6278 throw.
6279 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6280 * completer.c (complete_line_internal): Replace throw_exception
6281 with throw.
6282 * compile/compile-object-run.c (compile_object_run): Replace
6283 throw_exception with throw.
6284 * cli/cli-script.c (process_next_line): Replace throw_exception
6285 with throw.
6286 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6287 (btrace_enable, btrace_maint_update_pt_packets): Replace
6288 throw_exception with throw.
6289 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6290 throw_exception with throw.
6291 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6292 throw_exception with throw.
6293 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6294 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6295 * aarch64-tdep.c (aarch64_make_prologue_cache)
6296 (aarch64_make_stub_cache): Replace throw_exception with throw.
6297
62982019-04-08 Tom Tromey <tom@tromey.com>
6299
6300 * common/common-exceptions.c (throw_exception): Rename from
6301 throw_exception_cxx. Remove old copy. Make argument const.
6302 (throw_it): Create and throw exception objects directly.
6303 * common/common-exceptions.h (throw_exception): Make argument
6304 const.
6305 (struct gdb_exception_error): Add constructor.
6306 (struct gdb_exception_quit): Add constructor.
6307
63082019-04-08 Tom Tromey <tom@tromey.com>
6309
6310 * common/common-exceptions.h (exception_rethrow): Don't declare.
6311 (TRY_SJLJ): Update comment.
6312 (TRY, CATCH, END_CATCH): Remove.
6313 * common/common-exceptions.c (exception_rethrow): Remove.
6314
63152019-04-08 Tom Tromey <tom@tromey.com>
6316
6317 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6318 Remove.
6319 (gdb_exception_error): Rename from
6320 gdb_exception_RETURN_MASK_ERROR.
6321 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6322 (gdb_quit_bad_alloc): Update.
6323 * aarch64-tdep.c: Update.
6324 * ada-lang.c: Update.
6325 * ada-typeprint.c: Update.
6326 * ada-valprint.c: Update.
6327 * amd64-tdep.c: Update.
6328 * arch-utils.c: Update.
6329 * break-catch-throw.c: Update.
6330 * breakpoint.c: Update.
6331 * btrace.c: Update.
6332 * c-varobj.c: Update.
6333 * cli/cli-cmds.c: Update.
6334 * cli/cli-interp.c: Update.
6335 * cli/cli-script.c: Update.
6336 * common/common-exceptions.c: Update.
6337 * common/new-op.c: Update.
6338 * common/selftest.c: Update.
6339 * compile/compile-c-symbols.c: Update.
6340 * compile/compile-cplus-symbols.c: Update.
6341 * compile/compile-object-load.c: Update.
6342 * compile/compile-object-run.c: Update.
6343 * completer.c: Update.
6344 * corelow.c: Update.
6345 * cp-abi.c: Update.
6346 * cp-support.c: Update.
6347 * cp-valprint.c: Update.
6348 * darwin-nat.c: Update.
6349 * disasm-selftests.c: Update.
6350 * dtrace-probe.c: Update.
6351 * dwarf-index-cache.c: Update.
6352 * dwarf-index-write.c: Update.
6353 * dwarf2-frame-tailcall.c: Update.
6354 * dwarf2-frame.c: Update.
6355 * dwarf2loc.c: Update.
6356 * dwarf2read.c: Update.
6357 * eval.c: Update.
6358 * event-loop.c: Update.
6359 * event-top.c: Update.
6360 * exec.c: Update.
6361 * f-valprint.c: Update.
6362 * fbsd-tdep.c: Update.
6363 * frame-unwind.c: Update.
6364 * frame.c: Update.
6365 * gdbtypes.c: Update.
6366 * gnu-v3-abi.c: Update.
6367 * guile/guile-internal.h: Update.
6368 * guile/scm-block.c: Update.
6369 * guile/scm-breakpoint.c: Update.
6370 * guile/scm-cmd.c: Update.
6371 * guile/scm-disasm.c: Update.
6372 * guile/scm-frame.c: Update.
6373 * guile/scm-lazy-string.c: Update.
6374 * guile/scm-math.c: Update.
6375 * guile/scm-param.c: Update.
6376 * guile/scm-ports.c: Update.
6377 * guile/scm-pretty-print.c: Update.
6378 * guile/scm-symbol.c: Update.
6379 * guile/scm-symtab.c: Update.
6380 * guile/scm-type.c: Update.
6381 * guile/scm-value.c: Update.
6382 * i386-linux-tdep.c: Update.
6383 * i386-tdep.c: Update.
6384 * inf-loop.c: Update.
6385 * infcall.c: Update.
6386 * infcmd.c: Update.
6387 * infrun.c: Update.
6388 * jit.c: Update.
6389 * language.c: Update.
6390 * linespec.c: Update.
6391 * linux-fork.c: Update.
6392 * linux-nat.c: Update.
6393 * linux-tdep.c: Update.
6394 * linux-thread-db.c: Update.
6395 * main.c: Update.
6396 * mi/mi-cmd-break.c: Update.
6397 * mi/mi-cmd-stack.c: Update.
6398 * mi/mi-interp.c: Update.
6399 * mi/mi-main.c: Update.
6400 * objc-lang.c: Update.
6401 * p-valprint.c: Update.
6402 * parse.c: Update.
6403 * ppc-linux-tdep.c: Update.
6404 * printcmd.c: Update.
6405 * python/py-arch.c: Update.
6406 * python/py-breakpoint.c: Update.
6407 * python/py-cmd.c: Update.
6408 * python/py-finishbreakpoint.c: Update.
6409 * python/py-frame.c: Update.
6410 * python/py-framefilter.c: Update.
6411 * python/py-gdb-readline.c: Update.
6412 * python/py-inferior.c: Update.
6413 * python/py-infthread.c: Update.
6414 * python/py-lazy-string.c: Update.
6415 * python/py-linetable.c: Update.
6416 * python/py-objfile.c: Update.
6417 * python/py-param.c: Update.
6418 * python/py-prettyprint.c: Update.
6419 * python/py-progspace.c: Update.
6420 * python/py-record-btrace.c: Update.
6421 * python/py-record.c: Update.
6422 * python/py-symbol.c: Update.
6423 * python/py-type.c: Update.
6424 * python/py-unwind.c: Update.
6425 * python/py-utils.c: Update.
6426 * python/py-value.c: Update.
6427 * python/python.c: Update.
6428 * record-btrace.c: Update.
6429 * record-full.c: Update.
6430 * remote-fileio.c: Update.
6431 * remote.c: Update.
6432 * riscv-tdep.c: Update.
6433 * rs6000-aix-tdep.c: Update.
6434 * rs6000-tdep.c: Update.
6435 * rust-exp.y: Update.
6436 * rust-lang.c: Update.
6437 * s390-tdep.c: Update.
6438 * selftest-arch.c: Update.
6439 * solib-dsbt.c: Update.
6440 * solib-frv.c: Update.
6441 * solib-spu.c: Update.
6442 * solib-svr4.c: Update.
6443 * solib.c: Update.
6444 * sparc64-linux-tdep.c: Update.
6445 * stack.c: Update.
6446 * symfile-mem.c: Update.
6447 * symmisc.c: Update.
6448 * target.c: Update.
6449 * thread.c: Update.
6450 * top.c: Update.
6451 * tracefile-tfile.c: Update.
6452 * tui/tui.c: Update.
6453 * typeprint.c: Update.
6454 * unittests/cli-utils-selftests.c: Update.
6455 * unittests/parse-connection-spec-selftests.c: Update.
6456 * valops.c: Update.
6457 * valprint.c: Update.
6458 * value.c: Update.
6459 * varobj.c: Update.
6460 * windows-nat.c: Update.
6461 * x86-linux-nat.c: Update.
6462 * xml-support.c: Update.
6463
64642019-04-08 Tom Tromey <tom@tromey.com>
6465
6466 * xml-support.c: Use C++ exception handling.
6467 * x86-linux-nat.c: Use C++ exception handling.
6468 * windows-nat.c: Use C++ exception handling.
6469 * varobj.c: Use C++ exception handling.
6470 * value.c: Use C++ exception handling.
6471 * valprint.c: Use C++ exception handling.
6472 * valops.c: Use C++ exception handling.
6473 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6474 handling.
6475 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6476 * typeprint.c: Use C++ exception handling.
6477 * tui/tui.c: Use C++ exception handling.
6478 * tracefile-tfile.c: Use C++ exception handling.
6479 * top.c: Use C++ exception handling.
6480 * thread.c: Use C++ exception handling.
6481 * target.c: Use C++ exception handling.
6482 * symmisc.c: Use C++ exception handling.
6483 * symfile-mem.c: Use C++ exception handling.
6484 * stack.c: Use C++ exception handling.
6485 * sparc64-linux-tdep.c: Use C++ exception handling.
6486 * solib.c: Use C++ exception handling.
6487 * solib-svr4.c: Use C++ exception handling.
6488 * solib-spu.c: Use C++ exception handling.
6489 * solib-frv.c: Use C++ exception handling.
6490 * solib-dsbt.c: Use C++ exception handling.
6491 * selftest-arch.c: Use C++ exception handling.
6492 * s390-tdep.c: Use C++ exception handling.
6493 * rust-lang.c: Use C++ exception handling.
6494 * rust-exp.y: Use C++ exception handling.
6495 * rs6000-tdep.c: Use C++ exception handling.
6496 * rs6000-aix-tdep.c: Use C++ exception handling.
6497 * riscv-tdep.c: Use C++ exception handling.
6498 * remote.c: Use C++ exception handling.
6499 * remote-fileio.c: Use C++ exception handling.
6500 * record-full.c: Use C++ exception handling.
6501 * record-btrace.c: Use C++ exception handling.
6502 * python/python.c: Use C++ exception handling.
6503 * python/py-value.c: Use C++ exception handling.
6504 * python/py-utils.c: Use C++ exception handling.
6505 * python/py-unwind.c: Use C++ exception handling.
6506 * python/py-type.c: Use C++ exception handling.
6507 * python/py-symbol.c: Use C++ exception handling.
6508 * python/py-record.c: Use C++ exception handling.
6509 * python/py-record-btrace.c: Use C++ exception handling.
6510 * python/py-progspace.c: Use C++ exception handling.
6511 * python/py-prettyprint.c: Use C++ exception handling.
6512 * python/py-param.c: Use C++ exception handling.
6513 * python/py-objfile.c: Use C++ exception handling.
6514 * python/py-linetable.c: Use C++ exception handling.
6515 * python/py-lazy-string.c: Use C++ exception handling.
6516 * python/py-infthread.c: Use C++ exception handling.
6517 * python/py-inferior.c: Use C++ exception handling.
6518 * python/py-gdb-readline.c: Use C++ exception handling.
6519 * python/py-framefilter.c: Use C++ exception handling.
6520 * python/py-frame.c: Use C++ exception handling.
6521 * python/py-finishbreakpoint.c: Use C++ exception handling.
6522 * python/py-cmd.c: Use C++ exception handling.
6523 * python/py-breakpoint.c: Use C++ exception handling.
6524 * python/py-arch.c: Use C++ exception handling.
6525 * printcmd.c: Use C++ exception handling.
6526 * ppc-linux-tdep.c: Use C++ exception handling.
6527 * parse.c: Use C++ exception handling.
6528 * p-valprint.c: Use C++ exception handling.
6529 * objc-lang.c: Use C++ exception handling.
6530 * mi/mi-main.c: Use C++ exception handling.
6531 * mi/mi-interp.c: Use C++ exception handling.
6532 * mi/mi-cmd-stack.c: Use C++ exception handling.
6533 * mi/mi-cmd-break.c: Use C++ exception handling.
6534 * main.c: Use C++ exception handling.
6535 * linux-thread-db.c: Use C++ exception handling.
6536 * linux-tdep.c: Use C++ exception handling.
6537 * linux-nat.c: Use C++ exception handling.
6538 * linux-fork.c: Use C++ exception handling.
6539 * linespec.c: Use C++ exception handling.
6540 * language.c: Use C++ exception handling.
6541 * jit.c: Use C++ exception handling.
6542 * infrun.c: Use C++ exception handling.
6543 * infcmd.c: Use C++ exception handling.
6544 * infcall.c: Use C++ exception handling.
6545 * inf-loop.c: Use C++ exception handling.
6546 * i386-tdep.c: Use C++ exception handling.
6547 * i386-linux-tdep.c: Use C++ exception handling.
6548 * guile/scm-value.c: Use C++ exception handling.
6549 * guile/scm-type.c: Use C++ exception handling.
6550 * guile/scm-symtab.c: Use C++ exception handling.
6551 * guile/scm-symbol.c: Use C++ exception handling.
6552 * guile/scm-pretty-print.c: Use C++ exception handling.
6553 * guile/scm-ports.c: Use C++ exception handling.
6554 * guile/scm-param.c: Use C++ exception handling.
6555 * guile/scm-math.c: Use C++ exception handling.
6556 * guile/scm-lazy-string.c: Use C++ exception handling.
6557 * guile/scm-frame.c: Use C++ exception handling.
6558 * guile/scm-disasm.c: Use C++ exception handling.
6559 * guile/scm-cmd.c: Use C++ exception handling.
6560 * guile/scm-breakpoint.c: Use C++ exception handling.
6561 * guile/scm-block.c: Use C++ exception handling.
6562 * guile/guile-internal.h: Use C++ exception handling.
6563 * gnu-v3-abi.c: Use C++ exception handling.
6564 * gdbtypes.c: Use C++ exception handling.
6565 * frame.c: Use C++ exception handling.
6566 * frame-unwind.c: Use C++ exception handling.
6567 * fbsd-tdep.c: Use C++ exception handling.
6568 * f-valprint.c: Use C++ exception handling.
6569 * exec.c: Use C++ exception handling.
6570 * event-top.c: Use C++ exception handling.
6571 * event-loop.c: Use C++ exception handling.
6572 * eval.c: Use C++ exception handling.
6573 * dwarf2read.c: Use C++ exception handling.
6574 * dwarf2loc.c: Use C++ exception handling.
6575 * dwarf2-frame.c: Use C++ exception handling.
6576 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6577 * dwarf-index-write.c: Use C++ exception handling.
6578 * dwarf-index-cache.c: Use C++ exception handling.
6579 * dtrace-probe.c: Use C++ exception handling.
6580 * disasm-selftests.c: Use C++ exception handling.
6581 * darwin-nat.c: Use C++ exception handling.
6582 * cp-valprint.c: Use C++ exception handling.
6583 * cp-support.c: Use C++ exception handling.
6584 * cp-abi.c: Use C++ exception handling.
6585 * corelow.c: Use C++ exception handling.
6586 * completer.c: Use C++ exception handling.
6587 * compile/compile-object-run.c: Use C++ exception handling.
6588 * compile/compile-object-load.c: Use C++ exception handling.
6589 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6590 * compile/compile-c-symbols.c: Use C++ exception handling.
6591 * common/selftest.c: Use C++ exception handling.
6592 * common/new-op.c: Use C++ exception handling.
6593 * cli/cli-script.c: Use C++ exception handling.
6594 * cli/cli-interp.c: Use C++ exception handling.
6595 * cli/cli-cmds.c: Use C++ exception handling.
6596 * c-varobj.c: Use C++ exception handling.
6597 * btrace.c: Use C++ exception handling.
6598 * breakpoint.c: Use C++ exception handling.
6599 * break-catch-throw.c: Use C++ exception handling.
6600 * arch-utils.c: Use C++ exception handling.
6601 * amd64-tdep.c: Use C++ exception handling.
6602 * ada-valprint.c: Use C++ exception handling.
6603 * ada-typeprint.c: Use C++ exception handling.
6604 * ada-lang.c: Use C++ exception handling.
6605 * aarch64-tdep.c: Use C++ exception handling.
6606
66072019-04-08 Tom Tromey <tom@tromey.com>
6608
6609 * xml-support.c (gdb_xml_parser::parse): Update.
6610 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6611 * value.c (show_convenience): Update.
6612 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6613 (test_parse_flags_qcs): Update.
6614 * thread.c (thr_try_catch_cmd): Update.
6615 * target.c (target_translate_tls_address): Update.
6616 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6617 (info_frame_command_core, frame_apply_command_count): Update.
6618 * rust-exp.y (rust_lex_exception_test): Update.
6619 * riscv-tdep.c (riscv_print_one_register_info): Update.
6620 * remote.c (remote_target::enable_btrace): Update.
6621 * record-btrace.c (record_btrace_enable_warn): Update.
6622 * python/py-utils.c (gdbpy_convert_exception): Update.
6623 * printcmd.c (do_one_display, print_variable_and_value): Update.
6624 * mi/mi-main.c (mi_print_exception): Update.
6625 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6626 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6627 * linux-nat.c (linux_nat_target::attach): Update.
6628 * linux-fork.c (class scoped_switch_fork_info): Update.
6629 * infrun.c (displaced_step_prepare): Update.
6630 * infcall.c (call_function_by_hand_dummy): Update.
6631 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6632 * gnu-v3-abi.c (print_one_vtable): Update.
6633 * frame.c (get_prev_frame_always): Update.
6634 * f-valprint.c (info_common_command_for_block): Update.
6635 * exec.c (try_open_exec_file): Update.
6636 * exceptions.c (print_exception, exception_print)
6637 (exception_fprintf, exception_print_same): Update.
6638 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6639 * dwarf-index-cache.c (index_cache::store)
6640 (index_cache::lookup_gdb_index): Update.
6641 * darwin-nat.c (maybe_cache_shell): Update.
6642 * cp-valprint.c (cp_print_value_fields): Update.
6643 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6644 (gcc_cplus_symbol_address): Update.
6645 * compile/compile-c-symbols.c (gcc_convert_symbol)
6646 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6647 * common/selftest.c: Update.
6648 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6649 a std::string.
6650 (exception_try_scope_entry, exception_try_scope_exit): Don't
6651 declare.
6652 (struct exception_try_scope): Remove.
6653 (TRY): Don't use exception_try_scope.
6654 (struct gdb_exception): Add constructor, operator=.
6655 <what>: New method.
6656 (struct gdb_exception_RETURN_MASK_ALL)
6657 (struct gdb_exception_RETURN_MASK_ERROR)
6658 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6659 (struct gdb_quit_bad_alloc): Update.
6660 * common/common-exceptions.c (exception_none): Change
6661 initializer.
6662 (struct catcher) <state, exception>: Initialize inline.
6663 <prev>: Remove member.
6664 (current_catcher): Remove.
6665 (catchers): New global.
6666 (exceptions_state_mc_init): Simplify.
6667 (catcher_pop): Remove.
6668 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6669 (try_scope_depth, exception_try_scope_entry)
6670 (exception_try_scope_exit): Remove.
6671 (throw_exception_sjlj): Update.
6672 (exception_messages, exception_messages_size): Remove.
6673 (throw_it): Simplify.
6674 (gdb_exception_sliced_copy): Remove.
6675 (throw_exception_cxx): Update.
6676 * cli/cli-script.c (script_from_file): Update.
6677 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6678 Update.
6679 * ada-valprint.c (ada_val_print): Update.
6680 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6681 (create_excep_cond_exprs): Update.
6682
66832019-04-08 Tom Tromey <tom@tromey.com>
6684
6685 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6686 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6687 (TRY, CATCH, END_CATCH): Remove some definitions.
6688 * common/common-exceptions.c: Don't use GDB_XCPT.
6689 (catcher_list_size): Remove.
6690 (throw_exception, throw_it): Simplify.
6691
66922019-04-05 Tom Tromey <tom@tromey.com>
6693
6694 Revert the header-sorting patch.
6695 * ft32-tdep.c: Revert.
6696 * frv-tdep.c: Revert.
6697 * frv-linux-tdep.c: Revert.
6698 * frame.c: Revert.
6699 * frame-unwind.c: Revert.
6700 * frame-base.c: Revert.
6701 * fork-child.c: Revert.
6702 * findvar.c: Revert.
6703 * findcmd.c: Revert.
6704 * filesystem.c: Revert.
6705 * filename-seen-cache.h: Revert.
6706 * filename-seen-cache.c: Revert.
6707 * fbsd-tdep.c: Revert.
6708 * fbsd-nat.h: Revert.
6709 * fbsd-nat.c: Revert.
6710 * f-valprint.c: Revert.
6711 * f-typeprint.c: Revert.
6712 * f-lang.c: Revert.
6713 * extension.h: Revert.
6714 * extension.c: Revert.
6715 * extension-priv.h: Revert.
6716 * expprint.c: Revert.
6717 * exec.h: Revert.
6718 * exec.c: Revert.
6719 * exceptions.c: Revert.
6720 * event-top.c: Revert.
6721 * event-loop.c: Revert.
6722 * eval.c: Revert.
6723 * elfread.c: Revert.
6724 * dwarf2read.h: Revert.
6725 * dwarf2read.c: Revert.
6726 * dwarf2loc.c: Revert.
6727 * dwarf2expr.h: Revert.
6728 * dwarf2expr.c: Revert.
6729 * dwarf2-frame.c: Revert.
6730 * dwarf2-frame-tailcall.c: Revert.
6731 * dwarf-index-write.h: Revert.
6732 * dwarf-index-write.c: Revert.
6733 * dwarf-index-common.c: Revert.
6734 * dwarf-index-cache.h: Revert.
6735 * dwarf-index-cache.c: Revert.
6736 * dummy-frame.c: Revert.
6737 * dtrace-probe.c: Revert.
6738 * disasm.h: Revert.
6739 * disasm.c: Revert.
6740 * disasm-selftests.c: Revert.
6741 * dictionary.c: Revert.
6742 * dicos-tdep.c: Revert.
6743 * demangle.c: Revert.
6744 * dcache.h: Revert.
6745 * dcache.c: Revert.
6746 * darwin-nat.h: Revert.
6747 * darwin-nat.c: Revert.
6748 * darwin-nat-info.c: Revert.
6749 * d-valprint.c: Revert.
6750 * d-namespace.c: Revert.
6751 * d-lang.c: Revert.
6752 * ctf.c: Revert.
6753 * csky-tdep.c: Revert.
6754 * csky-linux-tdep.c: Revert.
6755 * cris-tdep.c: Revert.
6756 * cris-linux-tdep.c: Revert.
6757 * cp-valprint.c: Revert.
6758 * cp-support.c: Revert.
6759 * cp-namespace.c: Revert.
6760 * cp-abi.c: Revert.
6761 * corelow.c: Revert.
6762 * corefile.c: Revert.
6763 * continuations.c: Revert.
6764 * completer.h: Revert.
6765 * completer.c: Revert.
6766 * complaints.c: Revert.
6767 * coffread.c: Revert.
6768 * coff-pe-read.c: Revert.
6769 * cli-out.h: Revert.
6770 * cli-out.c: Revert.
6771 * charset.c: Revert.
6772 * c-varobj.c: Revert.
6773 * c-valprint.c: Revert.
6774 * c-typeprint.c: Revert.
6775 * c-lang.c: Revert.
6776 * buildsym.c: Revert.
6777 * buildsym-legacy.c: Revert.
6778 * build-id.h: Revert.
6779 * build-id.c: Revert.
6780 * btrace.c: Revert.
6781 * bsd-uthread.c: Revert.
6782 * breakpoint.h: Revert.
6783 * breakpoint.c: Revert.
6784 * break-catch-throw.c: Revert.
6785 * break-catch-syscall.c: Revert.
6786 * break-catch-sig.c: Revert.
6787 * blockframe.c: Revert.
6788 * block.c: Revert.
6789 * bfin-tdep.c: Revert.
6790 * bfin-linux-tdep.c: Revert.
6791 * bfd-target.c: Revert.
6792 * bcache.c: Revert.
6793 * ax-general.c: Revert.
6794 * ax-gdb.h: Revert.
6795 * ax-gdb.c: Revert.
6796 * avr-tdep.c: Revert.
6797 * auxv.c: Revert.
6798 * auto-load.c: Revert.
6799 * arm-wince-tdep.c: Revert.
6800 * arm-tdep.c: Revert.
6801 * arm-symbian-tdep.c: Revert.
6802 * arm-pikeos-tdep.c: Revert.
6803 * arm-obsd-tdep.c: Revert.
6804 * arm-nbsd-tdep.c: Revert.
6805 * arm-nbsd-nat.c: Revert.
6806 * arm-linux-tdep.c: Revert.
6807 * arm-linux-nat.c: Revert.
6808 * arm-fbsd-tdep.c: Revert.
6809 * arm-fbsd-nat.c: Revert.
6810 * arm-bsd-tdep.c: Revert.
6811 * arch-utils.c: Revert.
6812 * arc-tdep.c: Revert.
6813 * arc-newlib-tdep.c: Revert.
6814 * annotate.h: Revert.
6815 * annotate.c: Revert.
6816 * amd64-windows-tdep.c: Revert.
6817 * amd64-windows-nat.c: Revert.
6818 * amd64-tdep.c: Revert.
6819 * amd64-sol2-tdep.c: Revert.
6820 * amd64-obsd-tdep.c: Revert.
6821 * amd64-obsd-nat.c: Revert.
6822 * amd64-nbsd-tdep.c: Revert.
6823 * amd64-nbsd-nat.c: Revert.
6824 * amd64-nat.c: Revert.
6825 * amd64-linux-tdep.c: Revert.
6826 * amd64-linux-nat.c: Revert.
6827 * amd64-fbsd-tdep.c: Revert.
6828 * amd64-fbsd-nat.c: Revert.
6829 * amd64-dicos-tdep.c: Revert.
6830 * amd64-darwin-tdep.c: Revert.
6831 * amd64-bsd-nat.c: Revert.
6832 * alpha-tdep.c: Revert.
6833 * alpha-obsd-tdep.c: Revert.
6834 * alpha-nbsd-tdep.c: Revert.
6835 * alpha-mdebug-tdep.c: Revert.
6836 * alpha-linux-tdep.c: Revert.
6837 * alpha-linux-nat.c: Revert.
6838 * alpha-bsd-tdep.c: Revert.
6839 * alpha-bsd-nat.c: Revert.
6840 * aix-thread.c: Revert.
6841 * agent.c: Revert.
6842 * addrmap.c: Revert.
6843 * ada-varobj.c: Revert.
6844 * ada-valprint.c: Revert.
6845 * ada-typeprint.c: Revert.
6846 * ada-tasks.c: Revert.
6847 * ada-lang.c: Revert.
6848 * aarch64-tdep.c: Revert.
6849 * aarch64-ravenscar-thread.c: Revert.
6850 * aarch64-newlib-tdep.c: Revert.
6851 * aarch64-linux-tdep.c: Revert.
6852 * aarch64-linux-nat.c: Revert.
6853 * aarch64-fbsd-tdep.c: Revert.
6854 * aarch64-fbsd-nat.c: Revert.
6855 * aarch32-linux-nat.c: Revert.
6856
68572019-04-05 Tom Tromey <tom@tromey.com>
6858
6859 * ft32-tdep.c: Sort headers.
6860 * frv-tdep.c: Sort headers.
6861 * frv-linux-tdep.c: Sort headers.
6862 * frame.c: Sort headers.
6863 * frame-unwind.c: Sort headers.
6864 * frame-base.c: Sort headers.
6865 * fork-child.c: Sort headers.
6866 * findvar.c: Sort headers.
6867 * findcmd.c: Sort headers.
6868 * filesystem.c: Sort headers.
6869 * filename-seen-cache.h: Sort headers.
6870 * filename-seen-cache.c: Sort headers.
6871 * fbsd-tdep.c: Sort headers.
6872 * fbsd-nat.h: Sort headers.
6873 * fbsd-nat.c: Sort headers.
6874 * f-valprint.c: Sort headers.
6875 * f-typeprint.c: Sort headers.
6876 * f-lang.c: Sort headers.
6877 * extension.h: Sort headers.
6878 * extension.c: Sort headers.
6879 * extension-priv.h: Sort headers.
6880 * expprint.c: Sort headers.
6881 * exec.h: Sort headers.
6882 * exec.c: Sort headers.
6883 * exceptions.c: Sort headers.
6884 * event-top.c: Sort headers.
6885 * event-loop.c: Sort headers.
6886 * eval.c: Sort headers.
6887 * elfread.c: Sort headers.
6888 * dwarf2read.h: Sort headers.
6889 * dwarf2read.c: Sort headers.
6890 * dwarf2loc.c: Sort headers.
6891 * dwarf2expr.h: Sort headers.
6892 * dwarf2expr.c: Sort headers.
6893 * dwarf2-frame.c: Sort headers.
6894 * dwarf2-frame-tailcall.c: Sort headers.
6895 * dwarf-index-write.h: Sort headers.
6896 * dwarf-index-write.c: Sort headers.
6897 * dwarf-index-common.c: Sort headers.
6898 * dwarf-index-cache.h: Sort headers.
6899 * dwarf-index-cache.c: Sort headers.
6900 * dummy-frame.c: Sort headers.
6901 * dtrace-probe.c: Sort headers.
6902 * disasm.h: Sort headers.
6903 * disasm.c: Sort headers.
6904 * disasm-selftests.c: Sort headers.
6905 * dictionary.c: Sort headers.
6906 * dicos-tdep.c: Sort headers.
6907 * demangle.c: Sort headers.
6908 * dcache.h: Sort headers.
6909 * dcache.c: Sort headers.
6910 * darwin-nat.h: Sort headers.
6911 * darwin-nat.c: Sort headers.
6912 * darwin-nat-info.c: Sort headers.
6913 * d-valprint.c: Sort headers.
6914 * d-namespace.c: Sort headers.
6915 * d-lang.c: Sort headers.
6916 * ctf.c: Sort headers.
6917 * csky-tdep.c: Sort headers.
6918 * csky-linux-tdep.c: Sort headers.
6919 * cris-tdep.c: Sort headers.
6920 * cris-linux-tdep.c: Sort headers.
6921 * cp-valprint.c: Sort headers.
6922 * cp-support.c: Sort headers.
6923 * cp-namespace.c: Sort headers.
6924 * cp-abi.c: Sort headers.
6925 * corelow.c: Sort headers.
6926 * corefile.c: Sort headers.
6927 * continuations.c: Sort headers.
6928 * completer.h: Sort headers.
6929 * completer.c: Sort headers.
6930 * complaints.c: Sort headers.
6931 * coffread.c: Sort headers.
6932 * coff-pe-read.c: Sort headers.
6933 * cli-out.h: Sort headers.
6934 * cli-out.c: Sort headers.
6935 * charset.c: Sort headers.
6936 * c-varobj.c: Sort headers.
6937 * c-valprint.c: Sort headers.
6938 * c-typeprint.c: Sort headers.
6939 * c-lang.c: Sort headers.
6940 * buildsym.c: Sort headers.
6941 * buildsym-legacy.c: Sort headers.
6942 * build-id.h: Sort headers.
6943 * build-id.c: Sort headers.
6944 * btrace.c: Sort headers.
6945 * bsd-uthread.c: Sort headers.
6946 * breakpoint.h: Sort headers.
6947 * breakpoint.c: Sort headers.
6948 * break-catch-throw.c: Sort headers.
6949 * break-catch-syscall.c: Sort headers.
6950 * break-catch-sig.c: Sort headers.
6951 * blockframe.c: Sort headers.
6952 * block.c: Sort headers.
6953 * bfin-tdep.c: Sort headers.
6954 * bfin-linux-tdep.c: Sort headers.
6955 * bfd-target.c: Sort headers.
6956 * bcache.c: Sort headers.
6957 * ax-general.c: Sort headers.
6958 * ax-gdb.h: Sort headers.
6959 * ax-gdb.c: Sort headers.
6960 * avr-tdep.c: Sort headers.
6961 * auxv.c: Sort headers.
6962 * auto-load.c: Sort headers.
6963 * arm-wince-tdep.c: Sort headers.
6964 * arm-tdep.c: Sort headers.
6965 * arm-symbian-tdep.c: Sort headers.
6966 * arm-pikeos-tdep.c: Sort headers.
6967 * arm-obsd-tdep.c: Sort headers.
6968 * arm-nbsd-tdep.c: Sort headers.
6969 * arm-nbsd-nat.c: Sort headers.
6970 * arm-linux-tdep.c: Sort headers.
6971 * arm-linux-nat.c: Sort headers.
6972 * arm-fbsd-tdep.c: Sort headers.
6973 * arm-fbsd-nat.c: Sort headers.
6974 * arm-bsd-tdep.c: Sort headers.
6975 * arch-utils.c: Sort headers.
6976 * arc-tdep.c: Sort headers.
6977 * arc-newlib-tdep.c: Sort headers.
6978 * annotate.h: Sort headers.
6979 * annotate.c: Sort headers.
6980 * amd64-windows-tdep.c: Sort headers.
6981 * amd64-windows-nat.c: Sort headers.
6982 * amd64-tdep.c: Sort headers.
6983 * amd64-sol2-tdep.c: Sort headers.
6984 * amd64-obsd-tdep.c: Sort headers.
6985 * amd64-obsd-nat.c: Sort headers.
6986 * amd64-nbsd-tdep.c: Sort headers.
6987 * amd64-nbsd-nat.c: Sort headers.
6988 * amd64-nat.c: Sort headers.
6989 * amd64-linux-tdep.c: Sort headers.
6990 * amd64-linux-nat.c: Sort headers.
6991 * amd64-fbsd-tdep.c: Sort headers.
6992 * amd64-fbsd-nat.c: Sort headers.
6993 * amd64-dicos-tdep.c: Sort headers.
6994 * amd64-darwin-tdep.c: Sort headers.
6995 * amd64-bsd-nat.c: Sort headers.
6996 * alpha-tdep.c: Sort headers.
6997 * alpha-obsd-tdep.c: Sort headers.
6998 * alpha-nbsd-tdep.c: Sort headers.
6999 * alpha-mdebug-tdep.c: Sort headers.
7000 * alpha-linux-tdep.c: Sort headers.
7001 * alpha-linux-nat.c: Sort headers.
7002 * alpha-bsd-tdep.c: Sort headers.
7003 * alpha-bsd-nat.c: Sort headers.
7004 * aix-thread.c: Sort headers.
7005 * agent.c: Sort headers.
7006 * addrmap.c: Sort headers.
7007 * ada-varobj.c: Sort headers.
7008 * ada-valprint.c: Sort headers.
7009 * ada-typeprint.c: Sort headers.
7010 * ada-tasks.c: Sort headers.
7011 * ada-lang.c: Sort headers.
7012 * aarch64-tdep.c: Sort headers.
7013 * aarch64-ravenscar-thread.c: Sort headers.
7014 * aarch64-newlib-tdep.c: Sort headers.
7015 * aarch64-linux-tdep.c: Sort headers.
7016 * aarch64-linux-nat.c: Sort headers.
7017 * aarch64-fbsd-tdep.c: Sort headers.
7018 * aarch64-fbsd-nat.c: Sort headers.
7019 * aarch32-linux-nat.c: Sort headers.
7020
70212019-04-04 Tom Tromey <tom@tromey.com>
7022
7023 * varobj.c (varobj_create): Update.
7024 * rust-exp.y (struct rust_parser) <update_innermost_block,
7025 lookup_symbol>: New methods.
7026 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7027 Rename.
7028 (rust_parser::rust_lookup_type)
7029 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7030 * printcmd.c (display_command, do_one_display): Update.
7031 * parser-defs.h (struct parser_state) <parser_state>: Add
7032 "tracker" parameter.
7033 (block_tracker): New member.
7034 (class innermost_block_tracker) <innermost_block_tracker>: Add
7035 "types" parameter.
7036 <reset>: Remove method.
7037 (innermost_block): Don't declare.
7038 (null_post_parser): Update.
7039 * parse.c (innermost_block): Remove global.
7040 (write_dollar_variable): Update.
7041 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7042 Remove "tracker_types" parameter.
7043 (parse_expression): Add "tracker" parameter.
7044 (parse_expression_for_completion): Update.
7045 (null_post_parser): Add "tracker" parameter.
7046 * p-exp.y: Update rules.
7047 * m2-exp.y: Update rules.
7048 * language.h (struct language_defn) <la_post_parser>: Add
7049 "tracker" parameter.
7050 * go-exp.y: Update rules.
7051 * f-exp.y: Update rules.
7052 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7053 parameter.
7054 * d-exp.y: Update rules.
7055 * c-exp.y: Update rules.
7056 * breakpoint.c (set_breakpoint_condition): Create an
7057 innermost_block_tracker.
7058 (watch_command_1): Likewise.
7059 * ada-lang.c (resolve): Add "tracker" parameter.
7060 (resolve_subexp): Likewise.
7061 * ada-exp.y (write_var_from_sym): Update.
7062
70632019-04-04 Tom Tromey <tom@tromey.com>
7064
7065 * type-stack.h: New file.
7066 * type-stack.c: New file.
7067 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7068 type-stack.h.
7069 (insert_into_type_stack, insert_type, push_type, push_type_int)
7070 (insert_type_address_space, pop_type, pop_type_int)
7071 (pop_typelist, pop_type_stack, append_type_stack)
7072 (push_type_stack, get_type_stack, push_typelist)
7073 (follow_type_instance_flags, follow_types): Don't declare.
7074 * parse.c (type_stack): Remove global.
7075 (parse_exp_in_context): Update.
7076 (insert_into_type_stack, insert_type, push_type, push_type_int)
7077 (insert_type_address_space, pop_type, pop_type_int)
7078 (pop_typelist, pop_type_stack, append_type_stack)
7079 (push_type_stack, get_type_stack, push_typelist)
7080 (follow_type_instance_flags, follow_types): Remove (moved to
7081 type-stack.c).
7082 * f-exp.y (type_stack): New global.
7083 Update rules.
7084 (push_kind_type, f_parse): Update.
7085 * d-exp.y (type_stack): New global.
7086 Update rules.
7087 (d_parse): Update.
7088 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7089 Update rules.
7090 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7091 (HFILES_NO_SRCDIR): Add type-stack.h.
7092
70932019-04-04 Tom Tromey <tom@tromey.com>
7094
7095 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7096 (rust_parser::convert_ast_to_expression, rust_parse)
7097 (rust_lex_test_completion, rust_lex_tests): Update.
7098 * parser-defs.h (struct expr_completion_state): New.
7099 (struct parser_state) <parser_state>: Add completion parameter.
7100 <mark_struct_expression, mark_completion_tag>: New methods.
7101 <parse_completion, m_completion_state>: New members.
7102 (prefixify_expression, null_post_parser): Update.
7103 (mark_struct_expression, mark_completion_tag): Don't declare.
7104 * parse.c (parse_completion, expout_last_struct)
7105 (expout_tag_completion_type, expout_completion_name): Remove
7106 globals.
7107 (parser_state::mark_struct_expression)
7108 (parser_state::mark_completion_tag): Now methods.
7109 (prefixify_expression): Add last_struct parameter.
7110 (prefixify_subexp): Likewise.
7111 (parse_exp_1): Update.
7112 (parse_exp_in_context): Add cstate parameter. Update.
7113 (parse_expression_for_completion): Create an
7114 expr_completion_state.
7115 (null_post_parser): Add "completion" parameter.
7116 * p-exp.y: Update rules.
7117 (yylex): Update.
7118 * language.h (struct language_defn) <la_post_parser>: Add
7119 "completing" parameter.
7120 * go-exp.y: Update rules.
7121 (lex_one_token): Update.
7122 * expression.h (parse_completion): Don't declare.
7123 * d-exp.y: Update rules.
7124 (lex_one_token): Update rules.
7125 * c-exp.y: Update rules.
7126 (lex_one_token): Update.
7127 * ada-lang.c (resolve): Add "parse_completion" parameter.
7128 (resolve_subexp): Likewise.
7129 (ada_resolve_function): Likewise.
7130
71312019-04-04 Tom Tromey <tom@tromey.com>
7132
7133 * parser-defs.h (struct parser_state) <start_arglist,
7134 end_arglist>: New methods.
7135 <arglist_len, m_funcall_chain>: New members.
7136 (arglist_len, start_arglist, end_arglist): Don't declare.
7137 * parse.c (arglist_len, funcall_chain): Remove global.
7138 (start_arglist, end_arglist): Remove functions.
7139 (parse_exp_in_context): Update.
7140 * p-exp.y: Update rules.
7141 * m2-exp.y: Update rules.
7142 * go-exp.y: Update rules.
7143 * f-exp.y: Update rules.
7144 * d-exp.y: Update rules.
7145 * c-exp.y: Update rules.
7146
71472019-04-04 Tom Tromey <tom@tromey.com>
7148
7149 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7150 lex_operator, push_back>: New methods.
7151 Update all rules.
7152 (rust_parser::lex_hex, lex_escape): Rename and update.
7153 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7154 (rust_parser::lex_operator): Rename and update.
7155 (rust_parser::lex_number, rustyylex, rustyyerror)
7156 (rust_lex_test_init, rust_lex_test_sequence)
7157 (rust_lex_test_push_back, rust_lex_tests): Update.
7158 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7159 parameter.
7160 <lexptr, prev_lexptr>: New members.
7161 (lexptr, prev_lexptr): Don't declare.
7162 * parse.c (lexptr, prev_lexptr): Remove globals.
7163 (parse_exp_in_context): Update.
7164 * p-exp.y (yylex, yyerror): Update.
7165 * m2-exp.y (parse_number, yylex, yyerror): Update.
7166 * go-exp.y (lex_one_token, yyerror): Update.
7167 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7168 * d-exp.y (lex_one_token, yyerror): Update.
7169 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7170 (lex_one_token, yyerror): Update.
7171 * ada-lex.l (YY_INPUT): Update.
7172 (rewind_to_char): Update.
7173 * ada-exp.y (yyerror): Update.
7174
71752019-04-04 Tom Tromey <tom@tromey.com>
7176
7177 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7178 * parser-defs.h (struct parser_state) <parser_state>: Add new
7179 parameter.
7180 <comma_terminates>: New member.
7181 (comma_terminates): Don't declare global.
7182 * parse.c (comma_terminates): Remove global.
7183 (parse_exp_in_context): Update.
7184 * p-exp.y (yylex): Update.
7185 * m2-exp.y (yylex): Update.
7186 * go-exp.y (lex_one_token): Update.
7187 * f-exp.y (yylex): Update.
7188 * d-exp.y (lex_one_token): Update.
7189 * c-exp.y (lex_one_token): Update.
7190 * ada-lex.l: Update.
7191
71922019-04-04 Tom Tromey <tom@tromey.com>
7193
7194 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7195 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7196 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7197 * parser-defs.h (paren_depth): Don't declare.
7198 * parse.c (paren_depth): Remove global.
7199 (parse_exp_in_context): Update.
7200 * p-exp.y (paren_depth): New global.
7201 (pascal_parse): Initialize it.
7202 * m2-exp.y (paren_depth): New global.
7203 (m2_parse): Initialize it.
7204 * go-exp.y (paren_depth): New global.
7205 (go_parse): Initialize it.
7206 * f-exp.y (paren_depth): New global.
7207 (f_parse): Initialize it.
7208 * d-exp.y (paren_depth): New global.
7209 (d_parse): Initialize it.
7210 * c-exp.y (paren_depth): New global.
7211 (c_parse): Initialize it.
7212 * ada-lex.l (paren_depth): New global.
7213 (lexer_init): Initialize it.
7214
72152019-04-04 Tom Tromey <tom@tromey.com>
7216
7217 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7218 (rust_parser::convert_ast_to_type)
7219 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7220 * parser-defs.h (struct parser_state) <parser_state>: Add
7221 parameters. Initialize new members.
7222 <expression_context_block, expression_context_pc>: New members.
7223 * parse.c (expression_context_block, expression_context_pc):
7224 Remove globals.
7225 (parse_exp_in_context): Update.
7226 * p-exp.y: Update all rules.
7227 (yylex): Update.
7228 * m2-exp.y: Update all rules.
7229 (yylex): Update.
7230 * go-exp.y (yylex): Update.
7231 * f-exp.y (yylex): Update.
7232 * d-exp.y: Update all rules.
7233 (yylex): Update.
7234 * c-exp.y: Update all rules.
7235 (lex_one_token, classify_name, yylex, c_parse): Update.
7236 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7237
72382019-04-04 Tom Tromey <tom@tromey.com>
7239
7240 * gdbarch.h, gdbarch.c: Rebuild.
7241 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7242 * stap-probe.h:
7243 (struct stap_parse_info): Replace "parser_state" with
7244 "expr_builder".
7245 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7246 (parser_state): New class.
7247 * parse.c (expr_builder): Rename.
7248 (expr_builder::release): Rename.
7249 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7250 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7251 (write_exp_elt_longcst, write_exp_elt_floatcst)
7252 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7253 (write_exp_string_vector, write_exp_bitstring)
7254 (write_exp_msymbol, mark_struct_expression)
7255 (write_dollar_variable)
7256 (insert_type_address_space, increase_expout_size): Replace
7257 "parser_state" with "expr_builder".
7258 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7259 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7260 "parser_state" with "expr_builder".
7261
72622019-04-04 Tom Tromey <tom@tromey.com>
7263
7264 * rust-exp.y: Replace "parse_language" with method call.
7265 * p-exp.y:
7266 (yylex): Replace "parse_language" with method call.
7267 * m2-exp.y:
7268 (yylex): Replace "parse_language" with method call.
7269 * go-exp.y (classify_name): Replace "parse_language" with method
7270 call.
7271 * f-exp.y (yylex): Replace "parse_language" with method call.
7272 * d-exp.y (lex_one_token): Replace "parse_language" with method
7273 call.
7274 * c-exp.y:
7275 (lex_one_token, classify_name, yylex): Replace "parse_language"
7276 with method call.
7277 * ada-exp.y (find_primitive_type, type_char)
7278 (type_system_address): Replace "parse_language" with method call.
7279
72802019-04-04 Tom Tromey <tom@tromey.com>
7281
7282 * rust-exp.y: Replace "parse_gdbarch" with method call.
7283 * parse.c (write_dollar_variable, insert_type_address_space):
7284 Replace "parse_gdbarch" with method call.
7285 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7286 call.
7287 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7288 call.
7289 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7290 "parse_gdbarch" with method call.
7291 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7292 with method call.
7293 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7294 "parse_gdbarch" with method call.
7295 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7296 "parse_gdbarch" with method call.
7297 * c-exp.y (parse_type, parse_number, classify_name): Replace
7298 "parse_gdbarch" with method call.
7299 * ada-lex.l: Replace "parse_gdbarch" with method call.
7300 * ada-exp.y (parse_type, find_primitive_type, type_char)
7301 (type_system_address): Replace "parse_gdbarch" with method call.
7302
73032019-04-04 Tom Tromey <tom@tromey.com>
7304
7305 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7306 * stap-probe.c (stap_parse_argument): Update.
7307 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7308 initial_size parameter.
7309 * rust-exp.y (rust_lex_tests): Update.
7310 * parse.c (parser_state): Update.
7311 (parse_exp_in_context): Update.
7312 * parser-defs.h (struct parser_state) <parser_state>: Remove
7313 "initial_size" parameter.
7314
73152019-04-04 Tom Tromey <tom@tromey.com>
7316
7317 * parser-defs.h (increase_expout_size): Don't declare.
7318 * parse.c (increase_expout_size): Now static.
7319
73202019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7321
7322 * gnu-nat.c (gnu_nat_target::wait): Fix
7323 target_waitstatus_to_string call.
7324
73252019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7326
7327 * eval.c (evaluate_subexp_standard): Handle internal functions
7328 during Fortran function call handling.
7329
73302019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7331
7332 * NEWS: Mention new internal functions.
7333 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7334 (read_base_type): Use dwarf2_init_complex_target_type.
7335 * value.c (creal_internal_fn): New function.
7336 (cimag_internal_fn): New function.
7337 (_initialize_values): Register new internal functions.
7338
73392019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7340
7341 * infrun.c (stop_all_threads): If debug_infrun, always
7342 trace the wait status after wait_one, using
7343 target_waitstatus_to_string and target_pid_to_str.
7344 (handle_inferior_event): Replace various trace of
7345 wait status kind by a single trace.
7346 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7347 wait status kind image by target_waitstatus_to_string.
7348 * target/waitstatus.c (target_waitstatus_to_string): Fix
7349 obsolete comment.
7350
73512019-04-01 Tom Tromey <tromey@adacore.com>
7352
7353 PR symtab/23331:
7354 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7355
73562019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7357 Pedro Alves <palves@redhat.com>
7358
7359 * top.c (quit_force): Call 'finalize_values'.
7360 * value.c (finalize_values): New function.
7361 * value.h (finalize_values): Declare.
7362
73632019-03-30 Eli Zaretskii <eliz@gnu.org>
7364
7365 * NEWS: Announce $_gdb_major and $_gdb_minor.
7366
7367 * top.c (init_gdb_version_vars): New function.
7368 (gdb_init): Call init_gdb_version_vars.
7369
73702019-03-29 Tom Tromey <tromey@adacore.com>
7371
7372 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7373 help text. Remove dead code.
7374
73752019-03-29 Keith Seitz <keiths@redhat.com>
7376
7377 From Siddhesh Poyarekar:
7378 * f-lang.h (f77_get_upperbound): Return LONGEST.
7379 (f77_get_lowerbound): Likewise.
7380 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7381 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7382 print them.
7383 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7384 plongest to format print it.
7385 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7386 (f77_get_upperbound): Likewise.
7387 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7388 LOWER_BOUND to LONGEST.
7389 (f77_create_arrayprint_offset_tbl): Likewise.
7390
73912019-03-29 Keith Seitz <keiths@redhat.com>
7392
7393 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7394 %s/pulongest for TYPE_LENGTH instead of %d in format
7395 strings.
7396 * ada-typerint.c (ada_print_type): Likewise.
7397 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7398 * compile/compile-c-support.c (generate_register_struct): Likewise.
7399 * gdbtypes.c (recursive_dump_type): Likewise.
7400 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7401 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7402 instead of %d in format strings.
7403 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7404 to std::min to ULONGEST.
7405 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7406 instead of %d in format strings.
7407 * tracepoint.c (info_scope_command): Likewise.
7408 * typeprint.c (print_offset_data::update)
7409 (print_offset_data::finish): Likewise.
7410 * xtensa-tdep.c (xtensa_store_return_value)
7411 (xtensa_push_dummy_call): Likewise.
7412
74132019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7414
7415 * windows-nat.c (display_selector): Fixed format specifications
7416 for 64-bit Cygwin.
7417
74182019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7419
7420 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7421
74222019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7423
7424 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7425 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7426 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7427 (nios2_linux_init_abi): Install it.
7428
74292019-03-28 Alan Hayward <alan.hayward@arm.com>
7430
7431 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7432
74332019-03-28 Alan Hayward <alan.hayward@arm.com>
7434
7435 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7436
74372019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7438 Tom Tromey <tromey@adacore.com>
7439
7440 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7441
74422019-03-26 Joel Brobecker <brobecker@adacore.com>
7443
7444 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7445 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7446 method to compute the bounds of range types. Also print "[evaluated]"
7447 if the bounds' values come from a dynamic evaluation.
7448
74492019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7450
7451 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7452 whitespace when pretty printing is on.
7453
74542019-03-26 Alan Hayward <alan.hayward@arm.com>
7455
7456 * ppc-linux-nat.c: Add include.
7457
74582019-03-26 Alan Hayward <alan.hayward@arm.com>
7459
7460 * NEWS: Mention AArch64 Pointer Authentication.
7461
74622019-03-26 Alan Hayward <alan.hayward@arm.com>
7463
7464 * arm-linux-nat.c: Add include.
7465
74662019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7467
7468 * source-cache.c (source_cache::get_source_lines): Re-read
7469 fullname after calling open_source_file.
7470
74712019-03-25 John Baldwin <jhb@FreeBSD.org>
7472
7473 * NEWS: Mention TLS support for FreeBSD.
7474
74752019-03-25 Tom Tromey <tromey@adacore.com>
7476
7477 * minsyms.c (BUNCH_SIZE): Update comment.
7478 (~minimal_symbol_reader): Remove old comment.
7479 (compact_minimal_symbols): Update comment.
7480 (minimal_symbol_reader::install): Remove old comment. Update
7481 other comments.
7482
74832019-03-25 Alan Hayward <alan.hayward@arm.com>
7484
7485 * s390-linux-nat.c: Add include.
7486
74872019-03-25 Alan Hayward <alan.hayward@arm.com>
7488
7489 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7490 Call linux_get_hwcap.
7491 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7492 Likewise.
7493 (aarch64_linux_get_hwcap): Remove function.
7494 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7495 declaration.
7496 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7497 linux_get_hwcap.
7498 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7499 * linux-tdep.c (linux_get_hwcap): Add function.
7500 (linux_get_hwcap2): Likewise.
7501 * linux-tdep.h (linux_get_hwcap): Add declaration.
7502 (linux_get_hwcap2): Likewise.
7503 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7504 (ppc_linux_get_hwcap2): Likewise.
7505 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7506 linux_get_hwcap.
7507 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7508 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7509 (ppc_linux_nat_target::read_description): Likewise.
7510 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7511 * s390-linux-nat.c: Likewise.
7512 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7513
75142019-03-24 Tom Tromey <tom@tromey.com>
7515
7516 * ada-lang.c (standard_lookup): Simplify initialization.
7517 (ada_lookup_symbol_nonlocal): Simplify return.
7518 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7519 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7520 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7521 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7522 initialization.
7523 * solib.c (solib_global_lookup): Simplify.
7524 * symtab.c (null_block_symbol): Remove.
7525 (symbol_cache_lookup): Simplify returns.
7526 (lookup_language_this): Simplify returns.
7527 (lookup_symbol_aux): Simplify return.
7528 (lookup_local_symbol): Simplify returns.
7529 (lookup_global_symbol_from_objfile): Simplify return.
7530 (lookup_symbol_in_objfile_symtabs)
7531 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7532 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7533 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7534 * cp-namespace.c (cp_lookup_bare_symbol)
7535 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7536 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7537 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7538 (cp_lookup_symbol_via_imports): Simplify initialization.
7539 (find_symbol_in_baseclass): Likewise.
7540 * symtab.h (null_block_symbol): Remove.
7541 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7542 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7543 (d_lookup_symbol_module): Likewise.
7544 (find_symbol_in_baseclass): Simplify initialization.
7545
75462019-03-24 Tom Tromey <tom@tromey.com>
7547
7548 * expression.h: Don't include symtab.h.
7549 (struct block): Forward declare.
7550
75512019-03-24 Tom Tromey <tom@tromey.com>
7552
7553 * c-exp.y (typebase): Remove casts.
7554 * gdbtypes.c (lookup_unsigned_typename, )
7555 (lookup_signed_typename): Remove cast.
7556 * eval.c (parse_to_comma_and_eval): Remove cast.
7557 * parse.c (write_dollar_variable): Remove cast.
7558 * block.h (struct block) <superblock>: Now const.
7559 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7560 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7561 (map_block): Make "block" const.
7562 * symfile.h (struct quick_symbol_functions)
7563 <map_matching_symbols>: Constify block argument to "callback".
7564 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7565 const.
7566 (find_pc_sect_compunit_symtab): Make "b" const.
7567 (find_symbol_at_address): Likewise.
7568 (search_symbols): Likewise.
7569 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7570 (dw2_debug_names_lookup_symbol): Likewise.
7571 (dw2_map_matching_symbols): Update.
7572 * p-valprint.c (pascal_val_print): Remove "block".
7573 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7574 (aux_add_nonlocal_symbols): Make "block" const.
7575 (resolve_subexp): Remove cast.
7576 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7577 const.
7578 (iterate_over_file_blocks): Likewise.
7579 * f-exp.y (%union) <bval>: Remove.
7580 * coffread.c (patch_opaque_types): Make "b" const.
7581 * spu-tdep.c (spu_catch_start): Make "block" const.
7582 * c-valprint.c (print_unpacked_pointer): Remove "block".
7583 * symmisc.c (dump_symtab_1): Make "b" const.
7584 (block_depth): Make "block" const.
7585 * d-exp.y (%union) <bval>: Remove.
7586 * cp-support.h (cp_lookup_rtti_type): Update.
7587 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7588 * psymtab.c (psym_lookup_symbol): Make "block" const.
7589 (maintenance_check_psymtabs): Make "b" const.
7590 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7591 (enumerate_locals, enumerate_args): Update.
7592 * python/py-symtab.c (stpy_global_block): Make "block" const.
7593 (stpy_static_block): Likewise.
7594 * inline-frame.c (block_starting_point_at): Make "new_block"
7595 const.
7596 * block.c (find_block_in_blockvector): Make return type const.
7597 (blockvector_for_pc_sect): Make "b" const.
7598 (find_block_in_blockvector): Make "b" const.
7599
76002019-03-23 Tom Tromey <tom@tromey.com>
7601
7602 * varobj.c (varobj_create): Update.
7603 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7604 * printcmd.c (display_command, do_one_display): Don't reset
7605 innermost_block.
7606 * parser-defs.h (enum innermost_block_tracker_type): Move to
7607 expression.h.
7608 (innermost_block): Update comment.
7609 * parse.c (parse_exp_1): Add tracker_types parameter.
7610 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7611 tracker_types parameter. Reset innermost_block.
7612 (parse_exp_in_context): Remove.
7613 (parse_expression_for_completion): Update.
7614 * objfiles.c (~objfile): Don't reset expression_context_block or
7615 innermost_block.
7616 * expression.h (enum innermost_block_tracker_type): Move from
7617 parser-defs.h.
7618 (parse_exp_1): Add tracker_types parameter.
7619 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7620 reset innermost_block.
7621
76222019-03-23 Tom Tromey <tom@tromey.com>
7623
7624 * objfiles.h: Include bcache.h.
7625
76262019-03-23 Tom Tromey <tom@tromey.com>
7627
7628 * linespec.c (get_current_search_block): Use
7629 scoped_restore_current_language.
7630 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7631
76322019-03-22 Alan Hayward <alan.hayward@arm.com>
7633 Jiong Wang <jiong.wang@arm.com>
7634
7635 * aarch64-linux-tdep.c
7636 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7637 section.
7638 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7639
76402019-03-22 Alan Hayward <alan.hayward@arm.com>
7641 Jiong Wang <jiong.wang@arm.com>
7642
7643 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7644 instructions.
7645 (aarch64_analyze_prologue_test): Add PACIASP test.
7646 (aarch64_prologue_prev_register): Unmask PC value.
7647
76482019-03-22 Alan Hayward <alan.hayward@arm.com>
7649 Jiong Wang <jiong.wang@arm.com>
7650
7651 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7652 (aarch64_dwarf2_prev_register): Unmask PC value.
7653 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7654 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7655 DW_CFA_AARCH64_negate_ra_state.
7656 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7657
76582019-03-22 Alan Hayward <alan.hayward@arm.com>
7659 Jiong Wang <jiong.wang@arm.com>
7660
7661 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7662 registers.
7663 (aarch64_pseudo_register_name): Likewise.
7664 (aarch64_pseudo_register_type): Likewise.
7665 (aarch64_pseudo_register_reggroup_p): Likewise.
7666 (aarch64_gdbarch_init): Add pauth registers.
7667 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7668 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7669 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7670 (struct gdbarch_tdep): Add regnum for ra_state.
7671
76722019-03-22 Alan Hayward <alan.hayward@arm.com>
7673 Jiong Wang <jiong.wang@arm.com>
7674
7675 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7676
76772019-03-22 Alan Hayward <alan.hayward@arm.com>
7678 Jiong Wang <jiong.wang@arm.com>
7679
7680 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7681 function.
7682 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7683 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7684 (aarch64_gdbarch_init): Add puth registers.
7685 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7686 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7687 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7688
76892019-03-22 Alan Hayward <alan.hayward@arm.com>
7690 Jiong Wang <jiong.wang@arm.com>
7691
7692 * aarch64-linux-nat.c
7693 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7694 * aarch64-linux-tdep.c
7695 (aarch64_linux_core_read_description): Likewise.
7696 (aarch64_linux_get_hwcap): New function.
7697 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7698 (aarch64_linux_get_hwcap): New declaration.
7699
77002019-03-22 Alan Hayward <alan.hayward@arm.com>
7701 Jiong Wang <jiong.wang@arm.com>
7702
7703 * aarch64-linux-nat.c
7704 (aarch64_linux_nat_target::read_description): Add pauth param.
7705 * aarch64-linux-tdep.c
7706 (aarch64_linux_core_read_description): Likewise.
7707 * aarch64-tdep.c (struct target_desc): Add in pauth.
7708 (aarch64_read_description): Add pauth param.
7709 (aarch64_gdbarch_init): Likewise.
7710 * aarch64-tdep.h (aarch64_read_description): Likewise.
7711 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7712 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7713 * features/Makefile: Add new files.
7714 * features/aarch64-pauth.c: New file.
7715 * features/aarch64-pauth.xml: New file.
7716
77172019-03-20 Tom Tromey <tromey@adacore.com>
7718
7719 * infrun.c (handle_inferior_event): Rename from
7720 handle_inferior_event_1. Create a scoped_value_mark.
7721 (handle_inferior_event): Remove.
7722
77232019-03-19 Tom Tromey <tromey@adacore.com>
7724
7725 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7726 * infrun.h (print_stop_event): Add "displays" parameter.
7727 * infrun.c (print_stop_event): Add "displays" parameter.
7728
77292019-03-19 Pedro Alves <palves@redhat.com>
7730
7731 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7732 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7733 to -1. Fix TABs vs spaces.
7734 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7735 * tui/tui-out.h (tui_ui_out) Add intro comments.
7736 <m_line, m_start_of_line>: In-class initialize, and add describing
7737 comment.
7738
77392019-03-18 Alan Hayward <alan.hayward@arm.com>
7740
7741 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7742 variable names.
7743 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7744
77452019-03-18 Pedro Alves <palves@redhat.com>
7746 Eli Zaretskii <eliz@gnu.org>
7747
7748 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7749 m_line and m_start_of_line.
7750
77512019-03-18 Eli Zaretskii <eliz@gnu.org>
7752
7753 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7754 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7755 it returns a newline. This fixes a regression in TU mode, whereby
7756 the next line is output on the same screen line as the user input.
7757
77582019-03-18 Tom Tromey <tromey@adacore.com>
7759
7760 * minsyms.c (minimal_symbol_reader::install): Remove call to
7761 obstack_blank.
7762
77632019-03-18 Pedro Alves <palves@redhat.com>
7764
7765 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7766 New globals.
7767 (apply_style): New, factored out from ...
7768 (apply_ansi_escape): ... this. Handle reverse video mode.
7769 (tui_set_reverse_mode): New function.
7770 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7771 * tui/tui-winsource.c (tui_show_source_line): Use
7772 tui_set_reverse_mode instead of setting A_STANDOUT.
7773 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7774 New setter methods.
7775
77762019-03-18 Hannes Domani <ssbssa@yahoo.de>
7777
7778 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7779 Handle tabs.
7780
77812019-03-18 Tom Tromey <tromey@adacore.com>
7782
7783 * ada-lang.c (empty_array): Add "high" parameter.
7784 (ada_evaluate_subexp): Update.
7785
77862019-03-17 Sergei Trofimovich <siarheit@google.com>
7787
7788 * unittests/string_view-selftests.c: Define
7789 _initialize_string_view_selftests unconditionally.
7790
77912019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7792
7793 PR gdb/24350
7794 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7795
77962019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7797
7798 PR gdb/24351
7799 * windows-nat.c (display_selector): Fix format specifiers.
7800
78012019-03-17 Eli Zaretskii <eliz@gnu.org>
7802
7803 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7804 tui_refill_source_window instead of tui_refresh_win, to update the
7805 current execution line. This fixes redisplay of the current line
7806 when stepping through the code with "next" or "step".
7807
78082019-03-16 Eli Zaretskii <eliz@gnu.org>
7809
7810 * source-cache.c (source_cache::get_source_lines): Call
7811 find_source_lines to initialize s->nlines. This fixes vertical
7812 scrolling of TUI source window when the DOWN arrow is pressed.
7813
78142019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7815
7816 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7817 linux-thread-db.c (_initialize_thread_db): Likewise.
7818
78192019-03-16 Eli Zaretskii <eliz@gnu.org>
7820
7821 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7822 wclrtoeol in tui_show_source_line". This reverts changes made in
7823 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7824
78252019-03-15 Tom Tromey <tom@tromey.com>
7826
7827 * symtab.h (struct minimal_symbol): Derive from
7828 general_symbol_info.
7829 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7830 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7831 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7832 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7833 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7834 (MSYMBOL_SEARCH_NAME): Update.
7835 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7836 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7837 * minsyms.c (minimal_symbol_reader::record_full): Update.
7838
78392019-03-15 Tom Tromey <tom@tromey.com>
7840
7841 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7842
78432019-03-15 Tom Tromey <tom@tromey.com>
7844
7845 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7846 unique_xmalloc_ptr.
7847 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7848 Update.
7849 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7850 (build_minimal_symbol_hash_tables)
7851 (minimal_symbol_reader::install): Update.
7852
78532019-03-15 Tom Tromey <tom@tromey.com>
7854
7855 * symtab.c (create_demangled_names_hash): Update.
7856 (symbol_set_names): Update.
7857 * objfiles.h (struct objfile_per_bfd_storage)
7858 <demangled_names_hash>: Now an htab_up.
7859 * objfiles.c (objfile_per_bfd_storage): Simplify.
7860
78612019-03-15 Tom Tromey <tom@tromey.com>
7862
7863 * objfiles.h (struct objfile_per_bfd_storage): Declare
7864 destructor.
7865 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7866 New.
7867 (get_objfile_bfd_data): Use new. Don't initialize
7868 language_of_main.
7869 (free_objfile_per_bfd_storage): Remove.
7870 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7871
78722019-03-15 Tom Tromey <tom@tromey.com>
7873
7874 * symfile.c (reread_symbols): Update.
7875 * objfiles.c (objfile::objfile): Update.
7876 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7877 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7878 comment.
7879 (minimal_symbol_reader::install): Update.
7880 (terminate_minimal_symbol_table): Remove.
7881 * jit.c (jit_object_close_impl): Update.
7882
78832019-03-15 Tom Tromey <tom@tromey.com>
7884
7885 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7886 initializations.
7887
78882019-03-15 Tom Tromey <tom@tromey.com>
7889
7890 * objfiles.h (struct objfile_per_bfd_storage)
7891 <demangled_hash_languages>: Now a bitset.
7892 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7893 (lookup_minimal_symbol): Update.
7894
78952019-03-15 Tom Tromey <tom@tromey.com>
7896
7897 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7898 Don't return the symbol.
7899 * coffread.c (record_minimal_symbol): Use record_full.
7900
79012019-03-14 Eli Zaretskii <eliz@gnu.org>
7902
7903 The MS-Windows port of ncurses fails to switch to a color pair if
7904 one or both of the colors are the implicit default colors. This
7905 change records the default colors when TUI is initialized, and
7906 then specifies them explicitly when a color pair uses the default
7907 colors. This allows color styling in TUI mode on MS-Windows.
7908
7909 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7910 ncurses_norm_attr.
7911 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7912 colors in ncurses_norm_attr.
7913 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7914 "none", replace it with the default color recorded in
7915 ncurses_norm_attr.
7916
79172019-03-14 Tom Tromey <tromey@adacore.com>
7918
7919 * source-cache.h (class source_cache) <get_source_lines>: Return
7920 std::string.
7921 * source-cache.c (source_cache::extract_lines): Handle case where
7922 first_pos==npos. Return std::string.
7923 (source_cache::get_source_lines): Update.
7924
79252019-03-14 Tom Tromey <tromey@adacore.com>
7926
7927 * NEWS: Add item for "style sources" commands.
7928 * source-cache.c (source_cache::get_source_lines): Check
7929 source_styling.
7930 * cli/cli-style.c (source_styling): New global.
7931 (_initialize_cli_style): Add "style sources" commands.
7932 (show_style_sources): New function.
7933 * cli/cli-style.h (source_styling): Declare.
7934
79352019-03-14 Pedro Alves <palves@redhat.com>
7936 Tom Tromey <tromey@adacore.com>
7937
7938 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7939 * tui/tui-winsource.c (tui_refill_source_window): New function,
7940 from...
7941 (tui_horizontal_source_scroll): ... here. Move some logic.
7942 * cli/cli-style.c (set_style_enabled): Notify new observable.
7943 * tui/tui-hooks.c (tui_redisplay_source): New function.
7944 (tui_attach_detach_observers): Attach or detach
7945 tui_redisplay_source.
7946 * observable.h (source_styling_changed): New observable.
7947 * observable.c: Define source_styling_changed observable.
7948
79492019-03-13 Tom Tromey <tromey@adacore.com>
7950
7951 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7952 (i386_gnu_nat_target::store_registers): Update.
7953 * target-debug.h (target_debug_print_std_string): New macro.
7954 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7955 * windows-tdep.c (display_one_tib): Update.
7956 * tui/tui-stack.c (tui_make_status_line): Update.
7957 * top.c (print_inferior_quit_action): Update.
7958 * thread.c (thr_try_catch_cmd): Update.
7959 (add_thread_with_info): Update.
7960 (thread_target_id_str): Update.
7961 (thr_try_catch_cmd): Update.
7962 (thread_command): Update.
7963 (thread_find_command): Update.
7964 * record-btrace.c (record_btrace_target::info_record)
7965 (record_btrace_resume_thread, record_btrace_target::resume)
7966 (record_btrace_cancel_resume, record_btrace_step_thread)
7967 (record_btrace_target::wait, record_btrace_target::wait)
7968 (record_btrace_target::wait, record_btrace_target::stop): Update.
7969 * progspace.c (print_program_space): Update.
7970 * process-stratum-target.c
7971 (process_stratum_target::thread_address_space): Update.
7972 * linux-fork.c (linux_fork_mourn_inferior)
7973 (detach_checkpoint_command, info_checkpoints_command)
7974 (linux_fork_context): Update.
7975 (linux_fork_detach): Update.
7976 (class scoped_switch_fork_info): Update.
7977 (delete_checkpoint_command): Update.
7978 * infrun.c (follow_fork_inferior): Update.
7979 (follow_fork_inferior): Update.
7980 (proceed_after_vfork_done): Update.
7981 (handle_vfork_child_exec_or_exit): Update.
7982 (follow_exec): Update.
7983 (displaced_step_prepare_throw): Update.
7984 (displaced_step_restore): Update.
7985 (start_step_over): Update.
7986 (resume_1): Update.
7987 (clear_proceed_status_thread): Update.
7988 (proceed): Update.
7989 (print_target_wait_results): Update.
7990 (do_target_wait): Update.
7991 (context_switch): Update.
7992 (stop_all_threads): Update.
7993 (restart_threads): Update.
7994 (finish_step_over): Update.
7995 (handle_signal_stop): Update.
7996 (switch_back_to_stepped_thread): Update.
7997 (keep_going_pass_signal): Update.
7998 (print_exited_reason): Update.
7999 (normal_stop): Update.
8000 * inferior.c (inferior_pid_to_str): Change return type.
8001 (print_selected_inferior): Update.
8002 (add_inferior): Update.
8003 (detach_inferior): Update.
8004 * dummy-frame.c (fprint_dummy_frames): Update.
8005 * dcache.c (dcache_info_1): Update.
8006 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8007 (btrace_fetch, btrace_clear): Update.
8008 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8009 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8010 type.
8011 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8012 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8013 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8014 * gdbarch.c, gdbarch.h: Rebuild.
8015 * gdbarch.sh (core_pid_to_str): Change return type.
8016 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8017 return type.
8018 (windows_nat_target::pid_to_str): Change return type.
8019 (windows_delete_thread): Update.
8020 (windows_nat_target::attach): Update.
8021 (windows_nat_target::files_info): Update.
8022 * target-delegates.c: Rebuild.
8023 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8024 return type.
8025 (sol_thread_target::pid_to_str): Change return type.
8026 * remote.c (class remote_target) <pid_to_str>: Change return
8027 type.
8028 (remote_target::pid_to_str): Change return type.
8029 (extended_remote_target::attach, remote_target::remote_stop_ns)
8030 (remote_target::remote_notif_remove_queued_reply)
8031 (remote_target::push_stop_reply, remote_target::disable_btrace):
8032 Update.
8033 (extended_remote_target::attach): Update.
8034 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8035 type.
8036 (gdbsim_target::pid_to_str): Change return type.
8037 * ravenscar-thread.c (struct ravenscar_thread_target)
8038 <pid_to_str>: Change return type.
8039 (ravenscar_thread_target::pid_to_str): Change return type.
8040 * procfs.c (class procfs_target) <pid_to_str>: Change return
8041 type.
8042 (procfs_target::pid_to_str): Change return type.
8043 (procfs_target::attach): Update.
8044 (procfs_target::detach): Update.
8045 (procfs_target::fetch_registers): Update.
8046 (procfs_target::store_registers): Update.
8047 (procfs_target::wait): Update.
8048 (procfs_target::files_info): Update.
8049 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8050 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8051 return type.
8052 (nto_procfs_target::pid_to_str): Change return type.
8053 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8054 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8055 return type.
8056 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8057 (exit_lwp): Update.
8058 (attach_proc_task_lwp_callback, get_detach_signal)
8059 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8060 (linux_nat_target::resume, wait_lwp, stop_callback)
8061 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8062 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8063 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8064 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8065 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8066 type.
8067 (inf_ptrace_target::attach): Update.
8068 (inf_ptrace_target::files_info): Update.
8069 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8070 type.
8071 (go32_nat_target::pid_to_str): Change return type.
8072 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8073 (gnu_nat_target::wait): Update.
8074 (gnu_nat_target::wait): Update.
8075 (gnu_nat_target::resume): Update.
8076 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8077 (fbsd_nat_target::wait): Update.
8078 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8079 type.
8080 (darwin_nat_target::attach): Update.
8081 * corelow.c (class core_target) <pid_to_str>: Change return type.
8082 (core_target::pid_to_str): Change return type.
8083 * target.c (normal_pid_to_str): Change return type.
8084 (default_pid_to_str): Likewise.
8085 (target_pid_to_str): Change return type.
8086 (target_translate_tls_address): Update.
8087 (target_announce_detach): Update.
8088 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8089 return type.
8090 (bsd_uthread_target::pid_to_str): Change return type.
8091 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8092 type.
8093 (bsd_kvm_target::pid_to_str): Change return type.
8094 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8095 return type.
8096 (aix_thread_target::pid_to_str): Change return type.
8097 * target.h (struct target_ops) <pid_to_str>: Change return type.
8098 (target_pid_to_str, normal_pid_to_str): Likewise.
8099 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8100 type.
8101 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8102 type.
8103 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8104 return type.
8105 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8106 type.
8107 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8108 type.
8109 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8110 return type.
8111
81122019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8113
8114 * NEWS: Mention that the new default MI version is 3. Mention
8115 changes to the output of commands and events that deal with
8116 multi-location breakpoints.
8117 * breakpoint.c: Include "mi/mi-out.h".
8118 (print_one_breakpoint): Change output syntax if using MI version
8119 >= 3.
8120 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8121 New.
8122 (mi_multi_location_breakpoint_output_fixed): New.
8123 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8124 (mi_cmd_fix_multi_location_breakpoint_output): New.
8125 (mi_multi_location_breakpoint_output_fixed): New.
8126 * mi/mi-cmds.c (mi_cmds): Register command
8127 -fix-multi-location-breakpoint-output.
8128 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8129 interpreter "mi".
8130
81312019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8132
8133 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8134 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8135 instantiate mi_ui_out based on interpreter name.
8136 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8137 * mi/mi-main.c (mi_load_progress): Likewise.
8138
81392019-03-12 John Baldwin <jhb@FreeBSD.org>
8140
8141 * NEWS: Combine separate "New targets" sections for 8.3.
8142
81432019-03-12 John Baldwin <jhb@FreeBSD.org>
8144
8145 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8146 (ppcfbsd_init_abi): Install gdbarch
8147 "fetch_tls_load_module_address" and "get_thread_local_address"
8148 methods.
8149
81502019-03-12 John Baldwin <jhb@FreeBSD.org>
8151
8152 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8153 (riscv_fbsd_init_abi): Install gdbarch
8154 "fetch_tls_load_module_address" and "get_thread_local_address"
8155 methods.
8156
81572019-03-12 John Baldwin <jhb@FreeBSD.org>
8158
8159 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8160 (i386fbsd_init_abi): Install gdbarch
8161 "fetch_tls_load_module_address" and "get_thread_local_address"
8162 methods.
8163
81642019-03-12 John Baldwin <jhb@FreeBSD.org>
8165
8166 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8167 (amd64fbsd_init_abi): Install gdbarch
8168 "fetch_tls_load_module_address" and "get_thread_local_address"
8169 methods.
8170
81712019-03-12 John Baldwin <jhb@FreeBSD.org>
8172
8173 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8174 (struct fbsd_pspace_data): New type.
8175 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8176 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8177 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8178 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8179 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8180
81812019-03-12 John Baldwin <jhb@FreeBSD.org>
8182
8183 * gdbtypes.c (lookup_struct_elt): New function.
8184 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8185 * gdbtypes.h (struct struct_elt): New type.
8186 (lookup_struct_elt): New prototype.
8187
81882019-03-12 John Baldwin <jhb@FreeBSD.org>
8189
8190 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8191 remove disabled code block.
8192
81932019-03-12 John Baldwin <jhb@FreeBSD.org>
8194
8195 * gdbarch.sh (get_thread_local_address): New method.
8196 * gdbarch.h, gdbarch.c: Regenerate.
8197 * target.c (target_translate_tls_address): Use
8198 gdbarch_get_thread_local_address if present instead of
8199 target::get_thread_local_address.
8200
82012019-03-12 John Baldwin <jhb@FreeBSD.org>
8202
8203 * target.h (target::get_thread_local_address): Update comment.
8204
82052019-03-12 John Baldwin <jhb@FreeBSD.org>
8206
8207 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8208 objfile->separate_debug_objfile_backlink if not NULL.
8209
82102019-03-12 John Baldwin <jhb@FreeBSD.org>
8211
8212 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8213 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8214 (amd64bsd_store_inferior_registers): Likewise.
8215 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8216 Enable segment base registers.
8217 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8218 PT_GETFSBASE and PT_GETGSBASE.
8219 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8220 PT_SETGSBASE.
8221 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8222 segment base registers.
8223 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8224
82252019-03-12 John Baldwin <jhb@FreeBSD.org>
8226
8227 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8228 Update calls to i386_target_description to add 'segments'
8229 parameter.
8230 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8231 add segment base registers.
8232 * arch/i386.c (i386_create_target_description): Add 'segments'
8233 parameter to enable segment base registers.
8234 * arch/i386.h (i386_create_target_description): Likewise.
8235 * features/i386/32bit-segments.xml: New file.
8236 * features/i386/32bit-segments.c: Generate.
8237 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8238 call to i386_target_description to add 'segments' parameter.
8239 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8240 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8241 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8242 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8243 if feature is present.
8244 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8245 Add 'segments' parameter to call to i386_target_description.
8246 (i386_target_description): Add 'segments' parameter to enable
8247 segment base registers.
8248 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8249 to call to i386_target_description.
8250 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8251 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8252 Define I386_NUM_REGS.
8253 (i386_target_description): Add 'segments' parameter to enable
8254 segment base registers.
8255
82562019-03-12 Eli Zaretskii <eliz@gnu.org>
8257
8258 PR/24325
8259 * source-cache.c: #undef open and close, to avoid unresolved
8260 externals during linking.
8261
82622019-03-12 Tom Tromey <tromey@adacore.com>
8263
8264 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8265 const. Add initializers.
8266 (_initialize_remote): Don't initialize ptid globals.
8267
82682019-03-12 Pedro Alves <palves@redhat.com>
8269
8270 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8271
82722019-03-12 Pedro Alves <palves@redhat.com>
8273
8274 * cp-name-parser.y (main): Remove unused 'len' variable.
8275
82762019-03-12 Tom Tromey <tromey@adacore.com>
8277
8278 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8279 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8280
82812019-03-12 Tom Tromey <tromey@adacore.com>
8282
8283 * linux-nat.c (iterate_over_lwps): Update.
8284 (stop_callback): Remove parameter.
8285 (stop_wait_callback, detach_callback, resume_set_callback)
8286 (select_singlestep_lwp_callback, set_ignore_sigint)
8287 (status_callback, resumed_callback, resume_clear_callback)
8288 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8289 data parameter.
8290 (linux_nat_target::detach, linux_nat_target::resume)
8291 (linux_stop_and_wait_all_lwps, select_event_lwp)
8292 (linux_nat_filter_event, linux_nat_wait_1)
8293 (linux_nat_target::kill, linux_nat_target::stop)
8294 (linux_nat_target::stop): Update.
8295 (linux_nat_resume_callback): Change type.
8296 (resume_stopped_resumed_lwps, count_events_callback)
8297 (select_event_lwp_callback): Likewise.
8298 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8299 * arm-linux-nat.c (struct update_registers_data): Remove.
8300 (update_registers_callback): Change type.
8301 (arm_linux_insert_hw_breakpoint1): Update.
8302 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8303 parameter.
8304 (x86_linux_dr_set_addr): Update.
8305 (x86_linux_dr_set_control): Update.
8306 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8307 (iterate_over_lwps): Use gdb::function_view.
8308 * nat/aarch64-linux-hw-point.c (struct
8309 aarch64_dr_update_callback_param): Remove.
8310 (debug_reg_change_callback): Change type.
8311 (aarch64_notify_debug_reg_change): Update.
8312 * s390-linux-nat.c (s390_refresh_per_info): Update.
8313
83142019-03-11 Tom Tromey <tromey@adacore.com>
8315
8316 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8317 redundant assignment to "this_cu".
8318
83192019-03-08 Simon Marchi <simon.marchi@efficios.com>
8320
8321 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8322
83232019-03-08 Simon Marchi <simon.marchi@efficios.com>
8324
8325 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8326 from...
8327 (rank_one_type): ... this.
8328
83292019-03-08 Simon Marchi <simon.marchi@efficios.com>
8330
8331 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8332 from...
8333 (rank_one_type): ... this.
8334
83352019-03-08 Simon Marchi <simon.marchi@efficios.com>
8336
8337 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8338 from...
8339 (rank_one_type): ... this.
8340
83412019-03-08 Simon Marchi <simon.marchi@efficios.com>
8342
8343 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8344 from...
8345 (rank_one_type): ... this.
8346
83472019-03-08 Simon Marchi <simon.marchi@efficios.com>
8348
8349 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8350 from...
8351 (rank_one_type): ... this.
8352
83532019-03-08 Simon Marchi <simon.marchi@efficios.com>
8354
8355 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8356 from...
8357 (rank_one_type): ... this.
8358
83592019-03-08 Simon Marchi <simon.marchi@efficios.com>
8360
8361 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8362 from...
8363 (rank_one_type): ... this.
8364
83652019-03-08 Simon Marchi <simon.marchi@efficios.com>
8366
8367 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8368 from...
8369 (rank_one_type): ... this.
8370
83712019-03-08 Simon Marchi <simon.marchi@efficios.com>
8372
8373 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8374 from...
8375 (rank_one_type): ... this.
8376
83772019-03-08 Simon Marchi <simon.marchi@efficios.com>
8378
8379 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8380 from...
8381 (rank_one_type): ... this.
8382
83832019-03-08 Simon Marchi <simon.marchi@efficios.com>
8384
8385 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8386 from...
8387 (rank_one_type): ... this.
8388
83892019-03-08 Simon Marchi <simon.marchi@efficios.com>
8390
8391 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8392 from...
8393 (rank_one_type): ... this.
8394
83952019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8396
8397 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8398 inferior-events' shows the example events.
8399
84002019-03-08 Eli Zaretskii <eliz@gnu.org>
8401
8402 Support styling on native MS-Windows console
8403
8404 PR/24315
8405 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8406 on MS-Windows if $TERM is not defined.
8407
8408 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8409
8410 * posix-hdep.c (gdb_console_fputs):
8411 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8412 functions.
8413 * ui-file.h (gdb_console_fputs): Add prototype.
8414
8415 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8416 back to fputs only if the former returns zero.
8417
84182019-03-07 Tom Tromey <tom@tromey.com>
8419
8420 * symmisc.c (print_symbol_bcache_statistics): Update.
8421 (print_objfile_statistics): Update.
8422 * symfile.c (allocate_symtab): Update.
8423 * stabsread.c: Don't include bcache.h.
8424 * psymtab.h (struct psymbol_bcache): Don't declare.
8425 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8426 (psymbol_bcache_init, psymbol_bcache_free)
8427 (psymbol_bcache_get_bcache): Don't declare.
8428 * psymtab.c (struct psymbol_bcache): Remove.
8429 (psymtab_storage::psymtab_storage): Update.
8430 (psymtab_storage::~psymtab_storage): Update.
8431 (psymbol_bcache_init, psymbol_bcache_free)
8432 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8433 (add_psymbol_to_bcache): Update.
8434 (allocate_psymtab): Update.
8435 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8436 macro_cache>: No longer pointers.
8437 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8438 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8439 * macrotab.c (macro_bcache): Update.
8440 * macroexp.c: Don't include bcache.h.
8441 * gdbtypes.c (check_types_worklist): Update.
8442 (types_deeply_equal): Remove TRY/CATCH. Update.
8443 * elfread.c (elf_symtab_read): Update.
8444 * dwarf2read.c: Don't include bcache.h.
8445 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8446 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8447 (print_bcache_statistics, bcache_memory_used): Don't declare.
8448 (struct bcache): Move from bcache.c. Add constructor, destructor,
8449 methods. Rename all data members.
8450 * bcache.c (struct bcache): Move to bcache.h.
8451 (bcache::expand_hash_table): Rename from expand_hash_table.
8452 (bcache): Remove.
8453 (bcache::insert): Rename from bcache_full.
8454 (bcache::compare): Rename from bcache_compare.
8455 (bcache_xmalloc): Remove.
8456 (bcache::~bcache): Rename from bcache_xfree.
8457 (bcache::print_statistics): Rename from print_bcache_statistics.
8458 (bcache::memory_used): Rename from bcache_memory_used.
8459
84602019-03-07 Pedro Alves <palves@redhat.com>
8461
8462 * infrun.c (normal_stop): Also check for
8463 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8464
84652019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8466
8467 * f-lang.c (value_from_host_double): Moved to...
8468 * value.c (value_from_host_double): ...here.
8469 * value.h (value_from_host_double): Declare.
8470 * guile/scm-math.c (vlscm_convert_typed_number): Use
8471 value_from_host_double.
8472 (vlscm_convert_number): Likewise.
8473 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8474 * python/py-value.c (convert_value_from_python): Likewise.
8475
84762019-03-06 Tom Tromey <tom@tromey.com>
8477
8478 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8479
84802019-03-06 Tom Tromey <tom@tromey.com>
8481
8482 * utils.h (free_current_contents): Don't declare.
8483 * utils.c (free_current_contents): Remove.
8484
84852019-03-06 Tom Tromey <tom@tromey.com>
8486
8487 * top.c (quit_force): Update.
8488 * main.c (captured_command_loop): Update.
8489 * common/new-op.c (operator new): Update.
8490 * common/common-exceptions.c (struct catcher)
8491 <save_cleanup_chain>: Remove member.
8492 (exceptions_state_mc_init): Update.
8493 (exception_try_scope_entry): Return nullptr.
8494 (exception_try_scope_exit, exception_rethrow)
8495 (throw_exception_sjlj, throw_exception_cxx): Update.
8496 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8497 (all_cleanups, do_cleanups, discard_cleanups)
8498 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8499 (restore_cleanups, restore_final_cleanups): Don't declare.
8500 (do_final_cleanups): Remove parameter.
8501 * common/cleanups.c (cleanup_chain, make_cleanup)
8502 (make_cleanup_dtor, all_cleanups, do_cleanups)
8503 (discard_my_cleanups, discard_cleanups)
8504 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8505 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8506 (null_cleanup): Remove.
8507 (do_final_cleanups): Remove parameter.
8508
85092019-03-06 Tom Tromey <tom@tromey.com>
8510
8511 * remote.c (remote_target::remote_parse_stop_reply): Use
8512 unique_xmalloc_ptr.
8513
85142019-03-06 Tom Tromey <tom@tromey.com>
8515
8516 * stabsread.c (struct stabs_field_info): Rename from field_info.
8517 <list, fnlist>: Add initializers.
8518 <obstack>: New member.
8519 (read_member_functions, read_struct_fields, read_baseclasses):
8520 Allocate on obstack. Don't use cleanups.
8521 (read_one_struct_field, read_member_functions, read_struct_fields)
8522 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8523 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8524 (read_struct_type): Update.
8525
85262019-03-06 Tom Tromey <tom@tromey.com>
8527
8528 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8529 * common/filestuff.h (make_cleanup_close): Don't declare.
8530 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8531 Remove.
8532
85332019-03-06 Tom Tromey <tom@tromey.com>
8534
8535 * solib-aix.c: Use make_scope_exit.
8536
85372019-03-06 Tom Tromey <tom@tromey.com>
8538
8539 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8540 Use make_scope_exit.
8541
85422019-03-06 Tom Tromey <tom@tromey.com>
8543
8544 * solib-svr4.c (disable_probes_interface): Remove parameter.
8545 (svr4_handle_solib_event): Use make_scope_exit.
8546
85472019-03-06 Tom Tromey <tom@tromey.com>
8548
8549 * remote.c (struct stop_reply_deleter): Remove.
8550 (stop_reply_up): Update.
8551 (struct stop_reply): Derive from notif_event. Don't typedef.
8552 <regcache>: Now a std::vector.
8553 (stop_reply_xfree): Remove.
8554 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8555 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8556 (remote_target::discard_pending_stop_replies): Use delete.
8557 (remote_target::remote_parse_stop_reply): Update.
8558 (remote_target::process_stop_reply): Update.
8559 * remote-notif.h (struct notif_event): Add virtual destructor.
8560 Remove "dtr" member.
8561 (struct notif_client) <alloc_event>: Return a unique_ptr.
8562 (notif_event_xfree): Don't declare.
8563 (notif_event_up): New typedef.
8564 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8565 (notif_event_xfree, do_notif_event_xfree): Remove.
8566 (remote_notif_state_xfree): Update.
8567
85682019-03-06 Tom Tromey <tom@tromey.com>
8569
8570 * infrun.c (displaced_step_clear_cleanup): Now a
8571 forward_scope_exit type.
8572 (displaced_step_prepare_throw): Update.
8573 (displaced_step_fixup): Update.
8574
85752019-03-06 Tom Tromey <tom@tromey.com>
8576
8577 * inferior.h (class inferior): Update comment.
8578 * gdbthread.h (class thread_info): Update comment.
8579
85802019-03-06 Joel Brobecker <brobecker@adacore.com>
8581 Tom Tromey <tom@tromey.com>
8582
8583 * stabsread.h (struct stab_section_list): Remove.
8584 (coffstab_build_psymtabs): Update.
8585 * dbxread.c (symbuf_sections): Now a std::vector.
8586 (sect_idx): New global.
8587 (fill_symbuf): Update.
8588 (coffstab_build_psymtabs): Change type of stabsects parameter.
8589 Update.
8590 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8591 std::vector.
8592 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8593 (coff_locate_sections): Update.
8594 (coff_symfile_read): Remove cleanups. Update.
8595 (init_stringtab): Add storage parameter.
8596 (free_stringtab, free_stringtab_cleanup): Remove.
8597 (init_lineno): Add storage parameter.
8598 (free_linetab, free_linetab_cleanup): Remove.
8599
86002019-03-06 Pedro Alves <palves@redhat.com>
8601
8602 * linux-fork.c (fork_info::clobber_regs): Delete.
8603 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8604 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8605 comment. Adjust.
8606 (scoped_switch_fork_info::scoped_switch_fork_info)
8607 (checkpoint_command, linux_fork_context): Adjust
8608 fork_save_infrun_state calls.
8609
86102019-03-06 Pedro Alves <palves@redhat.com>
8611
8612 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8613 (inf_has_multiple_threads): Return 'bool' and rewrite using
8614 inferior_info::threads().
8615
86162019-03-06 Pedro Alves <palves@redhat.com>
8617
8618 * linux-fork.c: Include <list>.
8619 (fork_list): Now a std::list instance.
8620 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8621 (forks_exist_p, find_last_fork): Adjust.
8622 (new_fork): Delete.
8623 (one_fork_p): New.
8624 (add_fork): Adjust.
8625 (free_fork): Delete, folded into fork_info::~fork_info().
8626 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8627 Adjust.
8628 (init_fork_list): Delete.
8629 (linux_fork_killall, linux_fork_mourn_inferior)
8630 (linux_fork_detach, info_checkpoints_command): Adjust.
8631 (_initialize_linux_fork): No longer call init_fork_list.
8632
86332019-03-06 Pedro Alves <palves@redhat.com>
8634
8635 * linux-fork.c (new_fork): New, split out of ...
8636 (add_fork): ... this. Return void. Move "first fork" special
8637 case from here, to ...
8638 (checkpoint_command): ... here.
8639 * linux-linux.h (add_fork): Return void.
8640
86412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8642
8643 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8644
86452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8646 Chris January <chris.january@arm.com>
8647 David Lecomber <david.lecomber@arm.com>
8648
8649 * f-exp.y: New token, UNOP_INTRINSIC.
8650 (exp): New pattern using UNOP_INTRINSIC token.
8651 (f77_keywords): Add 'abs' keyword.
8652 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8653 (value_from_host_double): New function.
8654 (evaluate_subexp_f): Support UNOP_ABS.
8655
86562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8657
8658 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8659 types.
8660
86612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8662
8663 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8664 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8665 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8666
86672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8668
8669 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8670
86712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8672 Chris January <chris.january@arm.com>
8673
8674 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8675 * f-exp.y: Define 'KIND' token.
8676 (exp): New pattern for KIND expressions.
8677 (ptype): Handle types with a kind extension.
8678 (direct_abs_decl): Extend to spot kind extensions.
8679 (f77_keywords): Add 'kind' to the list.
8680 (push_kind_type): New function.
8681 (convert_to_kind_type): New function.
8682 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8683 * parse.c (operator_length_standard): Likewise.
8684 * parser-defs.h (enum type_pieces): Add tp_kind.
8685 * std-operator.def: Add UNOP_KIND.
8686
86872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8688
8689 * f-exp.y (f_parse): Set yydebug.
8690
86912019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8692
8693 * f-lang.c (evaluate_subexp_f): New function.
8694 (exp_descriptor_f): New global.
8695 (f_language_defn): Use exp_descriptor_f instead of
8696 exp_descriptor_standard.
8697
86982019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8699
8700 * f-exp.y (struct token): Add comments.
8701 (dot_ops): Remove uppercase versions and the end marker.
8702 (f77_keywords): Likewise.
8703 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8704 entries in the dot_ops array are case insensitive, and use
8705 strncasecmp to compare strings. Also some whitespace cleanup in
8706 this area. Similar for the f77_keywords array, except entries in
8707 this list might be case sensitive.
8708
87092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8710
8711 * f-exp.y (struct f77_boolean_val): Add comments.
8712 (boolean_values): Remove uppercase versions, and end marker.
8713 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8714 and use strncasecmp to achieve case insensitivity. Additionally,
8715 perform whitespace cleanup around this code.
8716
87172019-03-06 Tom Tromey <tromey@adacore.com>
8718
8719 * remote-sim.c (gdbsim_target_open): Use result of
8720 gdb_argv::release.
8721
87222019-03-06 Richard Bunt <richard.bunt@arm.com>
8723 Dirk Schubert <dirk.schubert@arm.com>
8724 Chris January <chris.january@arm.com>
8725
8726 * eval.c (evaluate_subexp_standard): Call Fortran argument
8727 wrapping logic.
8728 * f-lang.c (struct value): A value which can be passed into a
8729 Fortran function call.
8730 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8731 where appropriate.
8732 (struct type): Value ready for a Fortran function call.
8733 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8734 is needed.
8735 * f-lang.h (fortran_argument_convert): Declaration.
8736 (fortran_preserve_arg_pointer): Declaration.
8737 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8738
87392019-03-05 Tom Tromey <tromey@adacore.com>
8740
8741 * python/py-prettyprint.c (print_string_repr): Remove #if.
8742 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8743
87442019-03-05 Tom Tromey <tromey@adacore.com>
8745
8746 * target.c (the_dummy_target): Move later. Change type to
8747 "dummy_target".
8748 (initialize_targets): Don't initialize the_dummy_target.
8749
87502019-03-05 Tom Tromey <tromey@adacore.com>
8751
8752 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8753 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8754
87552019-03-05 Tom Tromey <tromey@adacore.com>
8756
8757 * windows-nat.c (windows_nat_target::attach)
8758 (windows_nat_target::detach): Don't call gdb_flush.
8759 * valprint.c (generic_val_print, val_print, val_print_string):
8760 Don't call gdb_flush.
8761 * utils.c (defaulted_query): Don't call gdb_flush.
8762 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8763 * target.c (target_announce_detach): Don't call gdb_flush.
8764 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8765 * remote.c (extended_remote_target::attach): Don't call
8766 gdb_flush.
8767 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8768 * printcmd.c (do_examine): Don't call gdb_flush.
8769 (info_display_command): Don't call gdb_flush.
8770 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8771 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8772 * memattr.c (info_mem_command): Don't call gdb_flush.
8773 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8774 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8775 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8776 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8777 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8778 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8779 (gnu_nat_target::detach): Don't call gdb_flush.
8780 * f-valprint.c (f_val_print): Don't call gdb_flush.
8781 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8782 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8783 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8784 gdb_flush.
8785 * c-valprint.c (c_val_print): Don't call gdb_flush.
8786 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8787
87882019-03-05 Tom Tromey <tromey@adacore.com>
8789
8790 * varobj.c (update_dynamic_varobj_children): Update.
8791 (install_default_visualizer): Use reset, not release.
8792 * value.c (set_internalvar): Update.
8793 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8794 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8795 ATTRIBUTE_UNUSED_RESULT.
8796
87972019-03-05 Tom Tromey <tromey@adacore.com>
8798
8799 * remote.c (class scoped_remote_fd) <release>: Add
8800 ATTRIBUTE_UNUSED_RESULT.
8801
88022019-03-05 Tom Tromey <tromey@adacore.com>
8803
8804 * macroexp.c (struct macro_buffer) <release>: Add
8805 ATTRIBUTE_UNUSED_RESULT.
8806
88072019-03-05 Tom Tromey <tromey@adacore.com>
8808
8809 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8810 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8811 ATTRIBUTE_UNUSED_RESULT.
8812
88132019-03-05 Tom Tromey <tromey@adacore.com>
8814
8815 * common/scoped_fd.h (class scoped_fd) <release>: Add
8816 ATTRIBUTE_UNUSED_RESULT.
8817
88182019-03-05 Tom Tromey <tromey@adacore.com>
8819
8820 * parser-defs.h (struct parser_state) <release>: Add
8821 ATTRIBUTE_UNUSED_RESULT.
8822
88232019-03-05 Tom Tromey <tromey@adacore.com>
8824
8825 * utils.h (class gdb_argv) <release>: Add
8826 ATTRIBUTE_UNUSED_RESULT.
8827 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8828
88292019-03-02 Eli Zaretskii <eliz@gnu.org>
8830
8831 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8832 for-loop range, to avoid compiler warnings.
8833
8834 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8835 avoid compiler warnings about unused variables.
8836
8837 * NEWS: Mention end of support for native debugging on MS-Windows
8838 before XP.
8839
8840 PR gdb/24292
8841 * common/netstuff.c:
8842 * gdbserver/gdbreplay.c
8843 * gdbserver/remote-utils.c:
8844 * ser-tcp.c:
8845 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8846 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8847 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8848 'getaddrinfo' and 'freeaddrinfo' were not available before
8849 Windows XP, and mingw.org's MinGW headers by default define
8850 _WIN32_WINNT to 0x500.
8851
88522019-03-01 Gary Benson <gbenson@redhat.com>
8853
8854 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8855
88562019-02-28 Brian Vandenberg <phantall@gmail.com>
8857 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8858
8859 PR gdb/8527
8860 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8861 set_sigint_trap, clear_sigint_trap.
8862
88632019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8864
8865 * target.c (target_detach): Clear the regcache and the
8866 frame cache.
8867
88682019-02-27 Pedro Alves <palves@redhat.com>
8869
8870 * utils.c (set_screen_size): When we cap the height/width sizes,
8871 tweak the corresponding command variable to show "unlimited":
8872
88732019-02-27 Saagar Jha <saagar@saagarjha.com>
8874 Pedro Alves <palves@redhat.com>
8875
8876 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8877 before calling rl_set_screen_size.
8878
88792019-02-27 Tom Tromey <tromey@adacore.com>
8880
8881 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8882 define.
8883 * python/py-value.c: Remove Python 2.4 workaround.
8884 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8885 workaround.
8886 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8887 Python 2.4 workaround.
8888 * python/python-internal.h: Remove Python 2.4 comment.
8889 (Py_ssize_t): Don't define.
8890 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8891 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8892 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8893 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8894 * python/python.c (do_start_initialization): Remove Python 2.4
8895 workaround.
8896 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8897 (print_children): Remove Python 2.4 workaround.
8898 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8899 workaround.
8900 (CHARBUFFERPROC_NAME): Remove.
8901 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8902 Python 2.4 workaround.
8903
89042019-02-27 Kevin Buettner <kevinb@redhat.com>
8905
8906 * NEWS: Note minimum Python version.
8907
89082019-02-27 Kevin Buettner <kevinb@redhat.com>
8909
8910 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8911 code from these functions. Remove corresponding ifdefs. Use
8912 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8913 Remove gotos and target of gotos.
8914 (infpy_search_memory): Likewise.
8915
89162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8917
8918 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8919 (hppa_gdbarch_init): Don't register deleted functions with
8920 gdbarch.
8921
89222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8923
8924 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8925 (h8300_unwind_sp): Delete.
8926 (h8300_dummy_id): Delete.
8927 (h8300_gdbarch_init): Don't register deleted functions with
8928 gdbarch.
8929
89302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8931
8932 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8933 (ft32_unwind_pc): Delete.
8934 (ft32_unwind_sp): Delete.
8935 (ft32_gdbarch_init): Don't register deleted functions with
8936 gdbarch.
8937
89382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8939
8940 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8941 (frv_unwind_pc): Delete.
8942 (frv_unwind_sp): Delete.
8943 (frv_gdbarch_init): Don't register deleted functions with
8944 gdbarch.
8945
89462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8947
8948 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8949 (riscv_unwind_pc): Delete.
8950 (riscv_unwind_sp): Delete.
8951 (riscv_gdbarch_init): Don't register deleted functions with
8952 gdbarch.
8953
89542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8955
8956 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8957 (csky_unwind_pc): Delete.
8958 (csky_unwind_sp): Delete.
8959 (csky_gdbarch_init): Don't register deleted functions with
8960 gdbarch.
8961
89622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8963
8964 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8965 (cris_unwind_pc): Delete.
8966 (cris_unwind_sp): Delete.
8967 (cris_gdbarch_init): Don't register deleted functions with
8968 gdbarch.
8969
89702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8971
8972 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8973 (bfin_unwind_pc): Delete.
8974 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8975
89762019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8977
8978 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8979 (arm_unwind_pc): Delete.
8980 (arm_unwind_sp): Delete.
8981 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8982
89832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8984
8985 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8986 (arc_unwind_pc): Delete.
8987 (arc_unwind_sp): Delete.
8988 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8989
89902019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8991
8992 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8993 (alpha_unwind_pc): Delete.
8994 (alpha_gdbarch_init): Don't register deleted functions with
8995 gdbarch.
8996
89972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8998
8999 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9000 (aarch64_unwind_pc): Delete.
9001 (aarch64_unwind_sp): Delete.
9002 (aarch64_gdbarch_init): Don't register deleted functions with
9003 gdbarch.
9004
90052019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9006
9007 * gdbtypes.c (type_align): Don't consider static members when
9008 computing structure alignment.
9009
90102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9011
9012 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9013 return 0 for other types.
9014 * arch-utils.c (default_type_align): Always return 0.
9015 * gdbarch.h: Regenerate.
9016 * gdbarch.sh (type_align): Extend comment.
9017 * gdbtypes.c (type_align): Add additional comments, always call
9018 gdbarch_type_align before applying the default rules.
9019 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9020 generic code will then apply a suitable default.
9021 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9022 types, return 0 for other types.
9023
90242019-02-27 Joel Brobecker <brobecker@adacore.com>
9025
9026 * NEWS: Create a new section for the next release branch.
9027 Rename the section of the current branch, now that it has
9028 been cut.
9029
90302019-02-27 Joel Brobecker <brobecker@adacore.com>
9031
9032 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9033 * version.in: Bump version to 8.3.50.DATE-git.
9034
90352019-02-26 Simon Marchi <simon.marchi@efficios.com>
9036
9037 * aix-thread.c (ptid_cmp): Remove unused variable.
9038 (get_signaled_thread): Likewise.
9039 (store_regs_user_thread): Likewise.
9040 (store_regs_kernel_thread): Likewise.
9041 (fetch_regs_kernel_thread): Remove shadowed variable.
9042
90432019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9044
9045 * features/riscv/32bit-cpu.xml: Add register numbers.
9046 * features/riscv/32bit-fpu.c: Regenerate.
9047 * features/riscv/32bit-fpu.xml: Add register numbers.
9048 * features/riscv/64bit-cpu.xml: Add register numbers.
9049 * features/riscv/64bit-fpu.c: Regenerate.
9050 * features/riscv/64bit-fpu.xml: Add register numbers.
9051
90522019-02-26 Kevin Buettner <kevinb@redhat.com>
9053
9054 * NEWS: Mention two argument form of gdb.Value constructor.
9055 * python/py-value.c (convert_buffer_and_type_to_value): New
9056 function.
9057 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9058 Add support for handling an optional second argument. Call
9059 convert_buffer_and_type_to_value as appropriate.
9060 * python/python-internal.h (Py_buffer_deleter): New struct.
9061 (Py_buffer_up): New typedef.
9062
90632019-02-25 John Baldwin <jhb@FreeBSD.org>
9064
9065 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9066 instead of releasing ownership.
9067
90682019-02-25 Jordan Rupprecht <rupprecht@google.com>
9069
9070 * dwarf2read.c (open_and_init_dwp_file): Call
9071 elf_numsections instead of bfd_count_sections to initialize
9072 dwp_file->num_sections.
9073
90742019-02-25 Tom Tromey <tromey@adacore.com>
9075
9076 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9077
90782019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9079
9080 * gcore.in: Add '--readnever' option when invoking GDB.
9081
90822019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9083
9084 * MAINTAINERS: Update my email address.
9085
90862019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9087
9088 * build-id.c (build_id_to_debug_bfd_1): New function.
9089 (build_id_to_debug_bfd): Look for separate debug file in
9090 sysroot.
9091
90922019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9093
9094 * gdbarch.sh: Update the copyright year range that is placed into
9095 generated files.
9096
90972019-02-22 Keith Seitz <keiths@redhat.com>
9098
9099 PR symtab/23853
9100 * linespec.c (create_sals_line_offset): Search for the default
9101 symtab's filename instead of its fullname.
9102
91032019-02-21 Alan Hayward <alan.hayward@arm.com>
9104
9105 * NEWS: Update style defaults.
9106
91072019-02-21 Alan Hayward <alan.hayward@arm.com>
9108
9109 * main.c (captured_main_1): Disable styling in batch mode.
9110
91112019-02-20 Tom Tromey <tom@tromey.com>
9112
9113 * symtab.c (symtab_symbol_info): Fix typos.
9114
91152019-02-20 Tom Tromey <tromey@adacore.com>
9116
9117 * findcmd.c (_initialize_mem_search): Use upper case for
9118 metasyntactic variables.
9119
91202019-02-20 Alan Hayward <alan.hayward@arm.com>
9121
9122 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9123 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9124
91252019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9126
9127 * top.h (source_file_name): Change to std::string.
9128 * top.c (source_file_name): Likewise.
9129 (command_line_input): Adjust.
9130 * cli/cli-script.c (script_from_file): Adjust.
9131
91322019-02-19 Tom Tromey <tromey@adacore.com>
9133
9134 * ravenscar-thread.c
9135 (ravenscar_thread_target::update_thread_list): Don't call
9136 ada_build_task_list.
9137 * ada-lang.h (ada_build_task_list): Don't declare.
9138 * ada-tasks.c (struct ada_tasks_inferior_data)
9139 <task_list_valid_p>: Now bool.
9140 (read_known_tasks, ada_task_list_changed)
9141 (ada_tasks_invalidate_inferior_data): Update.
9142 (read_known_tasks_array): Return bool.
9143 (read_known_tasks_list): Likewise.
9144 (read_known_tasks): Return void.
9145 (ada_build_task_list): Now static.
9146
91472019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9148
9149 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9150 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9151
91522019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9153
9154 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9155 variant for ada_tasks_pspace_data_handle and
9156 ada_tasks_inferior_data_handle.
9157 (ada_tasks_pspace_data_cleanup): New function.
9158 (ada_tasks_inferior_data_cleanup): New function.
9159
91602019-02-17 Tom Tromey <tom@tromey.com>
9161
9162 * macrotab.h (macro_source_fullname): Return a std::string.
9163 * macrotab.c (macro_include, check_for_redefinition)
9164 (macro_undef, macro_lookup_definition, foreach_macro)
9165 (foreach_macro_in_scope): Update.
9166 (macro_source_fullname): Return a std::string.
9167 * macrocmd.c (show_pp_source_pos): Update.
9168
91692019-02-17 Tom Tromey <tom@tromey.com>
9170
9171 * macrocmd.c (show_pp_source_pos): Style the file names.
9172
91732019-02-17 Tom Tromey <tom@tromey.com>
9174
9175 PR tui/24197:
9176 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9177
91782019-02-17 Tom Tromey <tom@tromey.com>
9179
9180 * ada-lang.c (user_select_syms): Use filtered printing.
9181 * utils.c (wrap_style): New global.
9182 (desired_style): Remove.
9183 (emit_style_escape): Add stream parameter.
9184 (set_output_style, reset_terminal_style, prompt_for_continue):
9185 Update.
9186 (flush_wrap_buffer): Only flush gdb_stdout.
9187 (wrap_here): Set wrap_style.
9188 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9189 treat escape sequences as a character. Change when wrap buffer is
9190 flushed.
9191 (fputs_styled): Do not set the output style when the default is
9192 requested.
9193 * ui-style.h (struct ui_file_style) <is_default>: New method.
9194 * source.c (print_source_lines_base): Emit escape sequences in one
9195 piece.
9196
91972019-02-17 Joel Brobecker <brobecker@adacore.com>
9198
9199 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9200 integers and enumeration types.
9201
92022019-02-17 Joel Brobecker <brobecker@adacore.com>
9203
9204 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9205 instead of lookup_symbol_in_language
9206 (do_exact_match): New function.
9207 (ada_get_symbol_name_matcher): Return do_exact_match when
9208 doing a verbatim match.
9209
92102019-02-15 Tom Tromey <tromey@adacore.com>
9211
9212 * ravenscar-thread.c (ravenscar_thread_target::resume)
9213 (ravenscar_thread_target::wait): Special case wildcard requests.
9214
92152019-02-15 Tom Tromey <tromey@adacore.com>
9216
9217 * ravenscar-thread.c (base_ptid): Remove.
9218 (struct ravenscar_thread_target) <close>: New method.
9219 <m_base_ptid>: New member.
9220 <update_inferior_ptid, active_task, task_is_currently_active,
9221 runtime_initialized>: Declare methods.
9222 <ravenscar_thread_target>: Add constructor.
9223 (ravenscar_thread_target::task_is_currently_active)
9224 (ravenscar_thread_target::update_inferior_ptid)
9225 (ravenscar_runtime_initialized): Rename. Now methods.
9226 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9227 (ravenscar_thread_target::update_thread_list): Update.
9228 (ravenscar_thread_target::active_task): Now method.
9229 (ravenscar_thread_target::store_registers)
9230 (ravenscar_thread_target::prepare_to_store)
9231 (ravenscar_thread_target::prepare_to_store)
9232 (ravenscar_thread_target::mourn_inferior): Update.
9233 (ravenscar_inferior_created): Use "new" to create target.
9234 (ravenscar_thread_target::get_ada_task_ptid): Update.
9235 (_initialize_ravenscar): Don't initialize base_ptid.
9236 (ravenscar_ops): Remove global.
9237
92382019-02-15 Tom Tromey <tromey@adacore.com>
9239
9240 * target.h (push_target): Declare new overload.
9241 * target.c (push_target): New overload, taking an rvalue reference.
9242 * remote.c (remote_target::open_1): Use push_target overload.
9243 * corelow.c (core_target_open): Use push_target overload.
9244
92452019-02-15 Tom Tromey <tromey@adacore.com>
9246
9247 * ravenscar-thread.c (is_ravenscar_task)
9248 (ravenscar_task_is_currently_active): Return bool.
9249 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9250 (_initialize_ravenscar): Remove "(void)".
9251 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9252 Return bool.
9253
92542019-02-15 Tom Tromey <tromey@adacore.com>
9255
9256 * ravenscar-thread.c (ravenscar_runtime_initializer)
9257 (has_ravenscar_runtime, get_running_thread_id)
9258 (ravenscar_thread_target::resume): Fix indentation.
9259
92602019-02-15 Tom Tromey <tromey@adacore.com>
9261
9262 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9263 from ravenscar_arch_ops.
9264 (sparc_ravenscar_ops::fetch_registers)
9265 (sparc_ravenscar_ops::store_registers): Now methods.
9266 (sparc_ravenscar_prepare_to_store): Remove.
9267 (sparc_ravenscar_ops): Redefine.
9268 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9269 methods and destructor. Remove members.
9270 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9271 (ravenscar_thread_target::store_registers)
9272 (ravenscar_thread_target::prepare_to_store): Update.
9273 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9274 Remove.
9275 (struct ppc_ravenscar_powerpc_ops): Derive from
9276 ravenscar_arch_ops.
9277 (ppc_ravenscar_powerpc_ops::fetch_registers)
9278 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9279 (ppc_ravenscar_powerpc_ops): Redefine.
9280 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9281 (ppc_ravenscar_e500_ops::fetch_registers)
9282 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9283 (ppc_ravenscar_e500_ops): Redefine.
9284 * aarch64-ravenscar-thread.c
9285 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9286 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9287 (aarch64_ravenscar_fetch_registers)
9288 (aarch64_ravenscar_store_registers): Now methods.
9289 (aarch64_ravenscar_ops): Redefine.
9290
92912019-02-15 Tom Tromey <tromey@adacore.com>
9292
9293 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9294 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9295 (ravenscar_thread_target::stopped_by_watchpoint)
9296 (ravenscar_thread_target::stopped_data_address)
9297 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9298
92992019-02-15 Tom Tromey <tromey@adacore.com>
9300
9301 * ravenscar-thread.c: Fix some typos.
9302
93032019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9304 Tom Tromey <tromey@adacore.com>
9305
9306 * ada-lang.c (ada_exception_sal): Change addr_string to a
9307 std::string.
9308 (create_ada_exception_catchpoint): Update.
9309
93102019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9311 Tom Tromey <tromey@adacore.com>
9312
9313 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9314 (bp_location_ops): Remove.
9315 (base_breakpoint_allocate_location): Update.
9316 (free_bp_location): Update.
9317 * ada-lang.c (class ada_catchpoint_location)
9318 <ada_catchpoint_location>: Remove ops parameter.
9319 (ada_catchpoint_location_dtor): Remove.
9320 (ada_catchpoint_location_ops): Remove.
9321 (allocate_location_exception): Update.
9322 * breakpoint.h (struct bp_location_ops): Remove.
9323 (class bp_location) <bp_location>: Remove bp_location_ops
9324 parameter.
9325 <~bp_location>: Add destructor.
9326 <ops>: Remove.
9327
93282019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9329 Pedro Alves <palves@redhat.com>
9330
9331 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9332 'PATH_MAX'.
9333
93342019-02-14 David Michael <fedora.dm0@gmail.com>
9335 Samuel Thibault <samuel.thibault@gnu.org>
9336 Thomas Schwinge <thomas@codesourcery.com>
9337
9338 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9339 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9340
93412019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9342
9343 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9344 (check_empty): Use "const char *".
9345
9346 * gnu-nat.c (gnu_nat_target::detach): Instead of
9347 'detach_inferior (pid)' call
9348 'detach_inferior (find_inferior_pid (pid))'.
9349
9350 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9351 'nat/fork-inferior.o'.
9352 * gnu-nat.c: #include "nat/fork-inferior.h".
9353
9354 * gnu-nat.c (gnu_nat_target::detach): Instead of
9355 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9356 * gnu-nat.h: #include "inf-child.h".
9357 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9358 'i386_gnu_nat_target::fetch_registers'.
9359 (gnu_store_registers): Rename/move to
9360 'i386_gnu_nat_target::store_registers'.
9361
9362 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9363 * gnu-nat.h (mach_thread_info): New function.
9364 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9365
9366 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9367
93682019-02-14 Frederic Konrad <konrad@adacore.com>
9369
9370 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9371
93722019-02-14 Joel Brobecker <brobecker@adacore.com>
9373
9374 * windows-nat.c (windows_add_thread): Add new parameter
9375 "main_thread_p" with default value set to false. Update
9376 function documentation as well as all callers.
9377 (windows_delete_thread): Likewise.
9378 (fake_create_process): Update call to windows_add_thread.
9379 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9380 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9381 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9382 call to windows_delete_thread.
9383
93842019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9385
9386 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9387
93882019-02-12 John Baldwin <jhb@FreeBSD.org>
9389
9390 * symfile.c (find_separate_debug_file): Use canonical path of
9391 sysroot with child_path instead of gdb_sysroot if it is valid.
9392
93932019-02-12 John Baldwin <jhb@FreeBSD.org>
9394
9395 * symfile.c (find_separate_debug_file): Use child_path to
9396 determine if an object file is under a sysroot.
9397
93982019-02-12 John Baldwin <jhb@FreeBSD.org>
9399
9400 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9401 unittests/child-path-selftests.c.
9402 * common/pathstuff.c (child_path): New function.
9403 * common/pathstuff.h (child_path): New prototype.
9404 * unittests/child-path-selftests.c: New file.
9405
94062019-02-12 John Baldwin <jhb@FreeBSD.org>
9407
9408 * symfile.c (find_separate_debug_file): Look for separate debug
9409 files in debug directories under the sysroot.
9410
94112019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9412
9413 * symtab.h (struct minimal_symbol data_p): New const method.
9414 (struct minimal_symbol text_p): Likewise.
9415 * symtab.c (output_source_filename): Use file name style
9416 to print file name.
9417 (print_symbol_info): Likewise.
9418 (print_msymbol_info): Use address style to print addresses.
9419 Use function name style to print executable text symbols.
9420 (expand_symtab_containing_pc): Use data_p.
9421 (find_pc_sect_compunit_symtab): Likewise.
9422
94232019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9424
9425 * breakpoint.c (describe_other_breakpoints): Use address style
9426 to print addresses.
9427 (say_where): Likewise.
9428
94292019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9430
9431 * ada-typeprint.c (print_func_type): Print function name
9432 style to print function name.
9433 * c-typeprint.c (c_print_type_1): Likewise.
9434
94352019-02-11 Alan Hayward <alan.hayward@arm.com>
9436
9437 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9438 for execve.
9439
94402019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9441
9442 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9443 type_stack.
9444
94452019-02-10 Joel Brobecker <brobecker@adacore.com>
9446
9447 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9448 TYPE_CODE_REF types.
9449
94502019-02-08 Jim Wilson <jimw@sifive.com>
9451
9452 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9453 (riscv_linux_fregset): New.
9454 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9455
94562019-02-07 Tom Tromey <tom@tromey.com>
9457
9458 * thread.c (thread_cancel_execution_command): Update.
9459 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9460 methods.
9461 (struct thread_fsm_ops): Remove.
9462 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9463 (thread_fsm_should_stop, thread_fsm_return_value)
9464 (thread_fsm_set_finished, thread_fsm_finished_p)
9465 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9466 Don't declare.
9467 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9468 * infrun.c (clear_proceed_status_thread)
9469 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9470 (print_stop_event): Update.
9471 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9472 Add constructor.
9473 (step_command_fsm_ops): Remove.
9474 (new_step_command_fsm): Remove.
9475 (step_1): Update.
9476 (step_command_fsm::should_stop): Rename from
9477 step_command_fsm_should_stop.
9478 (step_command_fsm::clean_up): Rename from
9479 step_command_fsm_clean_up.
9480 (step_command_fsm::do_async_reply_reason): Rename from
9481 step_command_fsm_async_reply_reason.
9482 (struct until_next_fsm): Inherit from thread_fsm. Add
9483 constructor.
9484 (until_next_fsm_ops): Remove.
9485 (new_until_next_fsm): Remove.
9486 (until_next_fsm::should_stop): Rename from
9487 until_next_fsm_should_stop.
9488 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9489 (until_next_fsm::do_async_reply_reason): Rename from
9490 until_next_fsm_async_reply_reason.
9491 (struct finish_command_fsm): Inherit from thread_fsm. Add
9492 constructor. Change type of breakpoint.
9493 (finish_command_fsm_ops): Remove.
9494 (new_finish_command_fsm): Remove.
9495 (finish_command_fsm::should_stop): Rename from
9496 finish_command_fsm_should_stop.
9497 (finish_command_fsm::clean_up): Rename from
9498 finish_command_fsm_clean_up.
9499 (finish_command_fsm::return_value): Rename from
9500 finish_command_fsm_return_value.
9501 (finish_command_fsm::do_async_reply_reason): Rename from
9502 finish_command_fsm_async_reply_reason.
9503 (finish_command): Update.
9504 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9505 Add constructor.
9506 (call_thread_fsm_ops): Remove.
9507 (call_thread_fsm::call_thread_fsm): Rename from
9508 new_call_thread_fsm.
9509 (call_thread_fsm::should_stop): Rename from
9510 call_thread_fsm_should_stop.
9511 (call_thread_fsm::should_notify_stop): Rename from
9512 call_thread_fsm_should_notify_stop.
9513 (run_inferior_call, call_function_by_hand_dummy): Update.
9514 * cli/cli-interp.c (should_print_stop_to_console): Update.
9515 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9516 Add constructor. Change type of location_breakpoint,
9517 caller_breakpoint.
9518 (until_break_fsm_ops): Remove.
9519 (new_until_break_fsm): Remove.
9520 (until_break_fsm::should_stop): Rename from
9521 until_break_fsm_should_stop.
9522 (until_break_fsm::clean_up): Rename from
9523 until_break_fsm_clean_up.
9524 (until_break_fsm::do_async_reply_reason): Rename from
9525 until_break_fsm_async_reply_reason.
9526 (until_break_command): Update.
9527 * thread-fsm.c: Remove.
9528 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9529
95302019-02-07 Tom Tromey <tom@tromey.com>
9531
9532 * yy-remap.h: Add include guard.
9533 * xtensa-tdep.h: Add include guard.
9534 * xcoffread.h: Rename include guard.
9535 * varobj-iter.h: Add include guard.
9536 * tui/tui.h: Rename include guard.
9537 * tui/tui-winsource.h: Rename include guard.
9538 * tui/tui-wingeneral.h: Rename include guard.
9539 * tui/tui-windata.h: Rename include guard.
9540 * tui/tui-win.h: Rename include guard.
9541 * tui/tui-stack.h: Rename include guard.
9542 * tui/tui-source.h: Rename include guard.
9543 * tui/tui-regs.h: Rename include guard.
9544 * tui/tui-out.h: Rename include guard.
9545 * tui/tui-layout.h: Rename include guard.
9546 * tui/tui-io.h: Rename include guard.
9547 * tui/tui-hooks.h: Rename include guard.
9548 * tui/tui-file.h: Rename include guard.
9549 * tui/tui-disasm.h: Rename include guard.
9550 * tui/tui-data.h: Rename include guard.
9551 * tui/tui-command.h: Rename include guard.
9552 * tic6x-tdep.h: Add include guard.
9553 * target/waitstatus.h: Rename include guard.
9554 * target/wait.h: Rename include guard.
9555 * target/target.h: Rename include guard.
9556 * target/resume.h: Rename include guard.
9557 * target-float.h: Rename include guard.
9558 * stabsread.h: Add include guard.
9559 * rs6000-tdep.h: Add include guard.
9560 * riscv-fbsd-tdep.h: Add include guard.
9561 * regformats/regdef.h: Rename include guard.
9562 * record.h: Rename include guard.
9563 * python/python.h: Rename include guard.
9564 * python/python-internal.h: Rename include guard.
9565 * python/py-stopevent.h: Rename include guard.
9566 * python/py-ref.h: Rename include guard.
9567 * python/py-record.h: Rename include guard.
9568 * python/py-record-full.h: Rename include guard.
9569 * python/py-record-btrace.h: Rename include guard.
9570 * python/py-instruction.h: Rename include guard.
9571 * python/py-events.h: Rename include guard.
9572 * python/py-event.h: Rename include guard.
9573 * procfs.h: Add include guard.
9574 * proc-utils.h: Add include guard.
9575 * p-lang.h: Add include guard.
9576 * or1k-tdep.h: Rename include guard.
9577 * observable.h: Rename include guard.
9578 * nto-tdep.h: Rename include guard.
9579 * nat/x86-linux.h: Rename include guard.
9580 * nat/x86-linux-dregs.h: Rename include guard.
9581 * nat/x86-gcc-cpuid.h: Add include guard.
9582 * nat/x86-dregs.h: Rename include guard.
9583 * nat/x86-cpuid.h: Rename include guard.
9584 * nat/ppc-linux.h: Rename include guard.
9585 * nat/mips-linux-watch.h: Rename include guard.
9586 * nat/linux-waitpid.h: Rename include guard.
9587 * nat/linux-ptrace.h: Rename include guard.
9588 * nat/linux-procfs.h: Rename include guard.
9589 * nat/linux-osdata.h: Rename include guard.
9590 * nat/linux-nat.h: Rename include guard.
9591 * nat/linux-namespaces.h: Rename include guard.
9592 * nat/linux-btrace.h: Rename include guard.
9593 * nat/glibc_thread_db.h: Rename include guard.
9594 * nat/gdb_thread_db.h: Rename include guard.
9595 * nat/gdb_ptrace.h: Rename include guard.
9596 * nat/fork-inferior.h: Rename include guard.
9597 * nat/amd64-linux-siginfo.h: Rename include guard.
9598 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9599 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9600 * nat/aarch64-linux.h: Rename include guard.
9601 * nat/aarch64-linux-hw-point.h: Rename include guard.
9602 * mn10300-tdep.h: Add include guard.
9603 * mips-linux-tdep.h: Add include guard.
9604 * mi/mi-parse.h: Rename include guard.
9605 * mi/mi-out.h: Rename include guard.
9606 * mi/mi-main.h: Rename include guard.
9607 * mi/mi-interp.h: Rename include guard.
9608 * mi/mi-getopt.h: Rename include guard.
9609 * mi/mi-console.h: Rename include guard.
9610 * mi/mi-common.h: Rename include guard.
9611 * mi/mi-cmds.h: Rename include guard.
9612 * mi/mi-cmd-break.h: Rename include guard.
9613 * m2-lang.h: Add include guard.
9614 * location.h: Rename include guard.
9615 * linux-record.h: Rename include guard.
9616 * linux-nat.h: Add include guard.
9617 * linux-fork.h: Add include guard.
9618 * i386-darwin-tdep.h: Rename include guard.
9619 * hppa-linux-offsets.h: Add include guard.
9620 * guile/guile.h: Rename include guard.
9621 * guile/guile-internal.h: Rename include guard.
9622 * gnu-nat.h: Rename include guard.
9623 * gdb-stabs.h: Rename include guard.
9624 * frv-tdep.h: Add include guard.
9625 * f-lang.h: Add include guard.
9626 * event-loop.h: Add include guard.
9627 * darwin-nat.h: Rename include guard.
9628 * cp-abi.h: Rename include guard.
9629 * config/sparc/nm-sol2.h: Rename include guard.
9630 * config/nm-nto.h: Rename include guard.
9631 * config/nm-linux.h: Add include guard.
9632 * config/i386/nm-i386gnu.h: Rename include guard.
9633 * config/djgpp/nl_types.h: Rename include guard.
9634 * config/djgpp/langinfo.h: Rename include guard.
9635 * compile/gcc-cp-plugin.h: Add include guard.
9636 * compile/gcc-c-plugin.h: Add include guard.
9637 * compile/compile.h: Rename include guard.
9638 * compile/compile-object-run.h: Rename include guard.
9639 * compile/compile-object-load.h: Rename include guard.
9640 * compile/compile-internal.h: Rename include guard.
9641 * compile/compile-cplus.h: Rename include guard.
9642 * compile/compile-c.h: Rename include guard.
9643 * common/xml-utils.h: Rename include guard.
9644 * common/x86-xstate.h: Rename include guard.
9645 * common/version.h: Rename include guard.
9646 * common/vec.h: Rename include guard.
9647 * common/tdesc.h: Rename include guard.
9648 * common/selftest.h: Rename include guard.
9649 * common/scoped_restore.h: Rename include guard.
9650 * common/scoped_mmap.h: Rename include guard.
9651 * common/scoped_fd.h: Rename include guard.
9652 * common/safe-iterator.h: Rename include guard.
9653 * common/run-time-clock.h: Rename include guard.
9654 * common/refcounted-object.h: Rename include guard.
9655 * common/queue.h: Rename include guard.
9656 * common/ptid.h: Rename include guard.
9657 * common/print-utils.h: Rename include guard.
9658 * common/preprocessor.h: Rename include guard.
9659 * common/pathstuff.h: Rename include guard.
9660 * common/observable.h: Rename include guard.
9661 * common/netstuff.h: Rename include guard.
9662 * common/job-control.h: Rename include guard.
9663 * common/host-defs.h: Rename include guard.
9664 * common/gdb_wait.h: Rename include guard.
9665 * common/gdb_vecs.h: Rename include guard.
9666 * common/gdb_unlinker.h: Rename include guard.
9667 * common/gdb_unique_ptr.h: Rename include guard.
9668 * common/gdb_tilde_expand.h: Rename include guard.
9669 * common/gdb_sys_time.h: Rename include guard.
9670 * common/gdb_string_view.h: Rename include guard.
9671 * common/gdb_splay_tree.h: Rename include guard.
9672 * common/gdb_setjmp.h: Rename include guard.
9673 * common/gdb_ref_ptr.h: Rename include guard.
9674 * common/gdb_optional.h: Rename include guard.
9675 * common/gdb_locale.h: Rename include guard.
9676 * common/gdb_assert.h: Rename include guard.
9677 * common/filtered-iterator.h: Rename include guard.
9678 * common/filestuff.h: Rename include guard.
9679 * common/fileio.h: Rename include guard.
9680 * common/environ.h: Rename include guard.
9681 * common/common-utils.h: Rename include guard.
9682 * common/common-types.h: Rename include guard.
9683 * common/common-regcache.h: Rename include guard.
9684 * common/common-inferior.h: Rename include guard.
9685 * common/common-gdbthread.h: Rename include guard.
9686 * common/common-exceptions.h: Rename include guard.
9687 * common/common-defs.h: Rename include guard.
9688 * common/common-debug.h: Rename include guard.
9689 * common/cleanups.h: Rename include guard.
9690 * common/buffer.h: Rename include guard.
9691 * common/btrace-common.h: Rename include guard.
9692 * common/break-common.h: Rename include guard.
9693 * cli/cli-utils.h: Rename include guard.
9694 * cli/cli-style.h: Rename include guard.
9695 * cli/cli-setshow.h: Rename include guard.
9696 * cli/cli-script.h: Rename include guard.
9697 * cli/cli-interp.h: Rename include guard.
9698 * cli/cli-decode.h: Rename include guard.
9699 * cli/cli-cmds.h: Rename include guard.
9700 * charset-list.h: Add include guard.
9701 * buildsym-legacy.h: Rename include guard.
9702 * bfin-tdep.h: Add include guard.
9703 * ax.h: Rename include guard.
9704 * arm-linux-tdep.h: Add include guard.
9705 * arm-fbsd-tdep.h: Add include guard.
9706 * arch/xtensa.h: Rename include guard.
9707 * arch/tic6x.h: Add include guard.
9708 * arch/i386.h: Add include guard.
9709 * arch/arm.h: Rename include guard.
9710 * arch/arm-linux.h: Rename include guard.
9711 * arch/arm-get-next-pcs.h: Rename include guard.
9712 * arch/amd64.h: Add include guard.
9713 * arch/aarch64-insn.h: Rename include guard.
9714 * arch-utils.h: Rename include guard.
9715 * annotate.h: Add include guard.
9716 * amd64-darwin-tdep.h: Rename include guard.
9717 * aarch64-linux-tdep.h: Add include guard.
9718 * aarch64-fbsd-tdep.h: Add include guard.
9719 * aarch32-linux-nat.h: Add include guard.
9720
97212019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9722
9723 * macrotab.c (macro_define_internal): New function that
9724 factorizes macro_define_object_internal and macro_define_function
9725 code.
9726 (macro_define_object_internal): Use macro_define_internal.
9727 (macro_define_function): Likewise.
9728
97292019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9730
9731 * macrocmd.c (extract_identifier): Return
9732 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9733 callers.
9734
97352019-02-06 John Baldwin <jhb@FreeBSD.org>
9736
9737 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9738
97392019-02-05 Tom Tromey <tom@tromey.com>
9740
9741 * target.c (target_stack::unpush): Move assertion earlier.
9742
97432019-01-30 Tom Tromey <tom@tromey.com>
9744
9745 PR python/23615:
9746 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9747 (gdbpy_parse_and_eval): Likewise.
9748 * python/python-internal.h (gdbpy_allow_threads): New class.
9749
97502019-01-28 John Baldwin <jhb@FreeBSD.org>
9751
9752 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9753 (aarch64_fbsd_fpregmap): Move earlier.
9754 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9755 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9756 instead of individual calls to trad_frame_set_reg_addr.
9757 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9758 earlier.
9759 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9760 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9761 instead of individual calls to trad_frame_set_reg_addr.
9762
97632019-01-28 Alan Hayward <alan.hayward@arm.com>
9764
9765 * CONTRIBUTE: Replace contribution list with wiki link.
9766
97672019-01-25 Tom Tromey <tom@tromey.com>
9768
9769 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9770
97712019-01-25 Tom Tromey <tom@tromey.com>
9772
9773 * xtensa-linux-nat.c: Fix common/ includes.
9774 * xml-support.h: Fix common/ includes.
9775 * xml-support.c: Fix common/ includes.
9776 * x86-linux-nat.c: Fix common/ includes.
9777 * windows-nat.c: Fix common/ includes.
9778 * varobj.h: Fix common/ includes.
9779 * varobj.c: Fix common/ includes.
9780 * value.c: Fix common/ includes.
9781 * valops.c: Fix common/ includes.
9782 * utils.c: Fix common/ includes.
9783 * unittests/xml-utils-selftests.c: Fix common/ includes.
9784 * unittests/utils-selftests.c: Fix common/ includes.
9785 * unittests/unpack-selftests.c: Fix common/ includes.
9786 * unittests/tracepoint-selftests.c: Fix common/ includes.
9787 * unittests/style-selftests.c: Fix common/ includes.
9788 * unittests/string_view-selftests.c: Fix common/ includes.
9789 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9790 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9791 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9792 * unittests/rsp-low-selftests.c: Fix common/ includes.
9793 * unittests/parse-connection-spec-selftests.c: Fix common/
9794 includes.
9795 * unittests/optional-selftests.c: Fix common/ includes.
9796 * unittests/offset-type-selftests.c: Fix common/ includes.
9797 * unittests/observable-selftests.c: Fix common/ includes.
9798 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9799 * unittests/memrange-selftests.c: Fix common/ includes.
9800 * unittests/memory-map-selftests.c: Fix common/ includes.
9801 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9802 * unittests/function-view-selftests.c: Fix common/ includes.
9803 * unittests/environ-selftests.c: Fix common/ includes.
9804 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9805 * unittests/common-utils-selftests.c: Fix common/ includes.
9806 * unittests/cli-utils-selftests.c: Fix common/ includes.
9807 * unittests/array-view-selftests.c: Fix common/ includes.
9808 * ui-file.c: Fix common/ includes.
9809 * tui/tui-io.c: Fix common/ includes.
9810 * tracepoint.h: Fix common/ includes.
9811 * tracepoint.c: Fix common/ includes.
9812 * tracefile-tfile.c: Fix common/ includes.
9813 * top.h: Fix common/ includes.
9814 * top.c: Fix common/ includes.
9815 * thread.c: Fix common/ includes.
9816 * target/waitstatus.h: Fix common/ includes.
9817 * target/waitstatus.c: Fix common/ includes.
9818 * target.h: Fix common/ includes.
9819 * target.c: Fix common/ includes.
9820 * target-memory.c: Fix common/ includes.
9821 * target-descriptions.c: Fix common/ includes.
9822 * symtab.h: Fix common/ includes.
9823 * symfile.c: Fix common/ includes.
9824 * stap-probe.c: Fix common/ includes.
9825 * spu-linux-nat.c: Fix common/ includes.
9826 * sparc-nat.c: Fix common/ includes.
9827 * source.c: Fix common/ includes.
9828 * solib.c: Fix common/ includes.
9829 * solib-target.c: Fix common/ includes.
9830 * ser-unix.c: Fix common/ includes.
9831 * ser-tcp.c: Fix common/ includes.
9832 * ser-pipe.c: Fix common/ includes.
9833 * ser-base.c: Fix common/ includes.
9834 * selftest-arch.c: Fix common/ includes.
9835 * s12z-tdep.c: Fix common/ includes.
9836 * rust-exp.y: Fix common/ includes.
9837 * rs6000-aix-tdep.c: Fix common/ includes.
9838 * riscv-tdep.c: Fix common/ includes.
9839 * remote.c: Fix common/ includes.
9840 * remote-notif.h: Fix common/ includes.
9841 * remote-fileio.h: Fix common/ includes.
9842 * remote-fileio.c: Fix common/ includes.
9843 * regcache.h: Fix common/ includes.
9844 * regcache.c: Fix common/ includes.
9845 * record-btrace.c: Fix common/ includes.
9846 * python/python.c: Fix common/ includes.
9847 * python/py-type.c: Fix common/ includes.
9848 * python/py-inferior.c: Fix common/ includes.
9849 * progspace.h: Fix common/ includes.
9850 * producer.c: Fix common/ includes.
9851 * procfs.c: Fix common/ includes.
9852 * proc-api.c: Fix common/ includes.
9853 * printcmd.c: Fix common/ includes.
9854 * ppc-linux-nat.c: Fix common/ includes.
9855 * parser-defs.h: Fix common/ includes.
9856 * osdata.c: Fix common/ includes.
9857 * obsd-nat.c: Fix common/ includes.
9858 * nat/x86-linux.c: Fix common/ includes.
9859 * nat/x86-linux-dregs.c: Fix common/ includes.
9860 * nat/x86-dregs.h: Fix common/ includes.
9861 * nat/x86-dregs.c: Fix common/ includes.
9862 * nat/ppc-linux.c: Fix common/ includes.
9863 * nat/mips-linux-watch.h: Fix common/ includes.
9864 * nat/mips-linux-watch.c: Fix common/ includes.
9865 * nat/linux-waitpid.c: Fix common/ includes.
9866 * nat/linux-ptrace.h: Fix common/ includes.
9867 * nat/linux-ptrace.c: Fix common/ includes.
9868 * nat/linux-procfs.c: Fix common/ includes.
9869 * nat/linux-personality.c: Fix common/ includes.
9870 * nat/linux-osdata.c: Fix common/ includes.
9871 * nat/linux-namespaces.c: Fix common/ includes.
9872 * nat/linux-btrace.h: Fix common/ includes.
9873 * nat/linux-btrace.c: Fix common/ includes.
9874 * nat/fork-inferior.c: Fix common/ includes.
9875 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9876 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9877 * nat/aarch64-linux.c: Fix common/ includes.
9878 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9879 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9880 * namespace.h: Fix common/ includes.
9881 * mips-linux-tdep.c: Fix common/ includes.
9882 * minsyms.c: Fix common/ includes.
9883 * mi/mi-parse.h: Fix common/ includes.
9884 * mi/mi-main.c: Fix common/ includes.
9885 * mi/mi-cmd-env.c: Fix common/ includes.
9886 * memrange.h: Fix common/ includes.
9887 * memattr.c: Fix common/ includes.
9888 * maint.h: Fix common/ includes.
9889 * maint.c: Fix common/ includes.
9890 * main.c: Fix common/ includes.
9891 * machoread.c: Fix common/ includes.
9892 * location.c: Fix common/ includes.
9893 * linux-thread-db.c: Fix common/ includes.
9894 * linux-nat.c: Fix common/ includes.
9895 * linux-fork.c: Fix common/ includes.
9896 * inline-frame.c: Fix common/ includes.
9897 * infrun.c: Fix common/ includes.
9898 * inflow.c: Fix common/ includes.
9899 * inferior.h: Fix common/ includes.
9900 * inferior.c: Fix common/ includes.
9901 * infcmd.c: Fix common/ includes.
9902 * inf-ptrace.c: Fix common/ includes.
9903 * inf-child.c: Fix common/ includes.
9904 * ia64-linux-nat.c: Fix common/ includes.
9905 * i387-tdep.c: Fix common/ includes.
9906 * i386-tdep.c: Fix common/ includes.
9907 * i386-linux-tdep.c: Fix common/ includes.
9908 * i386-linux-nat.c: Fix common/ includes.
9909 * i386-go32-tdep.c: Fix common/ includes.
9910 * i386-fbsd-tdep.c: Fix common/ includes.
9911 * i386-fbsd-nat.c: Fix common/ includes.
9912 * guile/scm-type.c: Fix common/ includes.
9913 * guile/guile.c: Fix common/ includes.
9914 * go32-nat.c: Fix common/ includes.
9915 * gnu-nat.c: Fix common/ includes.
9916 * gdbthread.h: Fix common/ includes.
9917 * gdbarch-selftests.c: Fix common/ includes.
9918 * gdb_usleep.c: Fix common/ includes.
9919 * gdb_select.h: Fix common/ includes.
9920 * gdb_bfd.c: Fix common/ includes.
9921 * gcore.c: Fix common/ includes.
9922 * fork-child.c: Fix common/ includes.
9923 * findvar.c: Fix common/ includes.
9924 * fbsd-nat.c: Fix common/ includes.
9925 * event-top.c: Fix common/ includes.
9926 * event-loop.c: Fix common/ includes.
9927 * dwarf2read.c: Fix common/ includes.
9928 * dwarf2loc.c: Fix common/ includes.
9929 * dwarf2-frame.c: Fix common/ includes.
9930 * dwarf-index-cache.c: Fix common/ includes.
9931 * dtrace-probe.c: Fix common/ includes.
9932 * disasm-selftests.c: Fix common/ includes.
9933 * defs.h: Fix common/ includes.
9934 * csky-tdep.c: Fix common/ includes.
9935 * cp-valprint.c: Fix common/ includes.
9936 * cp-support.h: Fix common/ includes.
9937 * cp-support.c: Fix common/ includes.
9938 * corelow.c: Fix common/ includes.
9939 * completer.h: Fix common/ includes.
9940 * completer.c: Fix common/ includes.
9941 * compile/compile.c: Fix common/ includes.
9942 * compile/compile-loc2c.c: Fix common/ includes.
9943 * compile/compile-cplus-types.c: Fix common/ includes.
9944 * compile/compile-cplus-symbols.c: Fix common/ includes.
9945 * command.h: Fix common/ includes.
9946 * cli/cli-dump.c: Fix common/ includes.
9947 * cli/cli-cmds.c: Fix common/ includes.
9948 * charset.c: Fix common/ includes.
9949 * build-id.c: Fix common/ includes.
9950 * btrace.h: Fix common/ includes.
9951 * btrace.c: Fix common/ includes.
9952 * breakpoint.h: Fix common/ includes.
9953 * breakpoint.c: Fix common/ includes.
9954 * ax.h:
9955 (enum agent_op): Fix common/ includes.
9956 * ax-general.c (struct aop_map): Fix common/ includes.
9957 * ax-gdb.c: Fix common/ includes.
9958 * auxv.c: Fix common/ includes.
9959 * auto-load.c: Fix common/ includes.
9960 * arm-tdep.c: Fix common/ includes.
9961 * arch/riscv.c: Fix common/ includes.
9962 * arch/ppc-linux-common.c: Fix common/ includes.
9963 * arch/i386.c: Fix common/ includes.
9964 * arch/arm.c: Fix common/ includes.
9965 * arch/arm-linux.c: Fix common/ includes.
9966 * arch/arm-get-next-pcs.c: Fix common/ includes.
9967 * arch/amd64.c: Fix common/ includes.
9968 * arch/aarch64.c: Fix common/ includes.
9969 * arch/aarch64-insn.c: Fix common/ includes.
9970 * arch-utils.c: Fix common/ includes.
9971 * amd64-windows-tdep.c: Fix common/ includes.
9972 * amd64-tdep.c: Fix common/ includes.
9973 * amd64-sol2-tdep.c: Fix common/ includes.
9974 * amd64-obsd-tdep.c: Fix common/ includes.
9975 * amd64-nbsd-tdep.c: Fix common/ includes.
9976 * amd64-linux-tdep.c: Fix common/ includes.
9977 * amd64-linux-nat.c: Fix common/ includes.
9978 * amd64-fbsd-tdep.c: Fix common/ includes.
9979 * amd64-fbsd-nat.c: Fix common/ includes.
9980 * amd64-dicos-tdep.c: Fix common/ includes.
9981 * amd64-darwin-tdep.c: Fix common/ includes.
9982 * agent.c: Fix common/ includes.
9983 * ada-lang.h: Fix common/ includes.
9984 * ada-lang.c: Fix common/ includes.
9985 * aarch64-tdep.c: Fix common/ includes.
9986
99872019-01-25 Tom Tromey <tom@tromey.com>
9988
9989 * common/create-version.sh: Use common/version.h.
9990
99912019-01-24 Pedro Alves <palves@redhat.com>
9992
9993 * infrun.c (signal_stop, signal_print, signal_program)
9994 (signal_catch, signal_pass): Now arrays instead of pointers.
9995 (update_signals_program_target, do_target_resume)
9996 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9997 * linux-nat.c (linux_nat_target::pass_signals)
9998 (linux_nat_target::create_inferior, linux_nat_target::attach):
9999 Adjust.
10000 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10001 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10002 * procfs.c (procfs_target::pass_signals): Adjust.
10003 * record-full.c (record_full_target::resume): Adjust.
10004 * remote.c (remote_target::pass_signals)
10005 (remote_target::program_signals): Adjust.
10006 * target-debug.h (target_debug_print_signals): Now takes a
10007 gdb::array_view as parameter. Adjust.
10008 * target.h (target_ops) <pass_signals, program_signals>: Replace
10009 pointer and length parameters with gdb::array_view.
10010 (target_pass_signals, target_program_signals): Likewise.
10011 * target-delegates.c: Regenerate.
10012
100132019-01-24 Pedro Alves <palves@redhat.com>
10014
10015 * common/forward-scope-exit.h
10016 (forward_scope_exit::forward_scope_exit): Pass arguments to
10017 m_bind_function directly, instead of creating a std::bind and
10018 copying that.
10019
100202019-01-24 Alan Hayward <alan.hayward@arm.com>
10021
10022 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10023 for static members.
10024 (pass_in_v_vfp_candidate): Likewise.
10025
100262019-01-23 Tom Tromey <tom@tromey.com>
10027 Pedro Alves <palves@redhat.com>
10028
10029 * regcache.c (class regcache_invalidator): Remove.
10030 (regcache::raw_write): Use make_scope_exit.
10031
100322019-01-23 Tom Tromey <tom@tromey.com>
10033
10034 * ui-out.h (class ui_out_emit_type): Update comment.
10035
100362019-01-23 Tom Tromey <tom@tromey.com>
10037
10038 * infrun.c (fetch_inferior_event): Update comment.
10039
100402019-01-23 Tom Tromey <tom@tromey.com>
10041 Pedro Alves <palves@redhat.com>
10042
10043 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10044 parameter.
10045 (fetch_inferior_event): Use SCOPE_EXIT.
10046
10047
100482019-01-23 Tom Tromey <tom@tromey.com>
10049 Pedro Alves <palves@redhat.com>
10050
10051 * infrun.c (disable_thread_events): Delete.
10052 (stop_all_threads): Use SCOPE_EXIT.
10053
100542019-01-23 Tom Tromey <tom@tromey.com>
10055 Pedro Alves <palves@redhat.com>
10056
10057 * symfile.c: Include forward-scope-exit.h.
10058 (clear_symtab_users_cleanup): Replace forward declaration with
10059 a FORWARD_SCOPE_EXIT.
10060 (syms_from_objfile_1): Use the forward_scope_exit and
10061 gdb::optional instead of cleanup_function.
10062 (reread_symbols): Use the forward_scope_exit instead of
10063 cleanup_function.
10064 (clear_symtab_users_cleanup): Remove function.
10065
100662019-01-23 Tom Tromey <tom@tromey.com>
10067 Pedro Alves <palves@redhat.com>
10068
10069 * linux-nat.c: Include scope-exit.h.
10070 (cleanup_target_stop): Remove.
10071 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10072 SCOPE_EXIT.
10073
100742019-01-23 Tom Tromey <tom@tromey.com>
10075 Pedro Alves <palves@redhat.com>
10076
10077 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10078 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10079
100802019-01-23 Tom Tromey <tom@tromey.com>
10081 Andrew Burgess <andrew.burgess@embecosm.com>
10082 Pedro Alves <palves@redhat.com>
10083
10084 * infrun.c (fetch_inferior_event): Use scope_exit.
10085 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10086 * top.c (execute_command): Use scope_exit.
10087 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10088 * utils.c (do_bpstat_clear_actions_cleanup)
10089 (make_bpstat_clear_actions_cleanup): Remove.
10090
100912019-01-23 Tom Tromey <tom@tromey.com>
10092 Pedro Alves <palves@redhat.com>
10093
10094 * infrun.c: Include "common/scope-exit.h"
10095 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10096 (wait_for_inferior): Use SCOPE_EXIT.
10097 (fetch_inferior_event): Use scope_exit.
10098
100992019-01-23 Tom Tromey <tom@tromey.com>
10100 Pedro Alves <palves@redhat.com>
10101
10102 * breakpoint.c (create_breakpoint): Remove cleanup.
10103
101042019-01-23 Tom Tromey <tom@tromey.com>
10105 Andrew Burgess <andrew.burgess@embecosm.com>
10106 Pedro Alves <palves@redhat.com>
10107
101082019-01-23 Pedro Alves <palves@redhat.com>
10109
10110 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10111
101122019-01-23 Pedro Alves <palves@redhat.com>
10113 Andrew Burgess <andrew.burgess@embecosm.com>
10114
10115 * gdbthread.h: Include "common/forward-scope-exit.h".
10116 (scoped_finish_thread_state): Redefine custom class in terms of
10117 forward_scope_exit.
10118
101192019-01-23 Pedro Alves <palves@redhat.com>
10120 Andrew Burgess <andrew.burgess@embecosm.com>
10121
10122 * common/forward-scope-exit.h: New file.
10123
101242019-01-23 Pedro Alves <palves@redhat.com>
10125 Andrew Burgess <andrew.burgess@embecosm.com>
10126 Tom Tromey <tom@tromey.com>
10127
10128 * common/scope-exit.h: New file.
10129
101302019-01-23 Pedro Alves <palves@redhat.com>
10131
10132 * common/preprocessor.h (ESC): Rename to ...
10133 (ESC_PARENS): ... this.
10134 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10135 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10136
101372019-01-23 Tom Tromey <tom@tromey.com>
10138
10139 * language.h (class scoped_switch_to_sym_language_if_auto):
10140 Initialize m_lang in both cases.
10141
101422019-01-23 Alan Hayward <alan.hayward@arm.com>
10143
10144 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10145 with XCNEW.
10146
101472019-01-22 Tom Tromey <tom@tromey.com>
10148
10149 * corelow.c: Do not include sys/file.h.
10150
101512019-01-22 Tom Tromey <tom@tromey.com>
10152
10153 * tui/tui-wingeneral.h: Include gdb_curses.h.
10154
101552019-01-22 Tom Tromey <tom@tromey.com>
10156
10157 * source-cache.h (class source_cache) <get_source_lines,
10158 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10159
101602019-01-22 Tom Tromey <tom@tromey.com>
10161
10162 * remote-fileio.h (struct remote_target): Declare.
10163
101642019-01-22 Tom Tromey <tom@tromey.com>
10165
10166 * python/py-arch.c: Do not include py-ref.h.
10167 * python/py-bpevent.c: Do not include py-ref.h.
10168 * python/py-cmd.c: Do not include py-ref.h.
10169 * python/py-continueevent.c: Do not include py-ref.h.
10170 * python/py-event.h: Do not include py-ref.h.
10171 * python/py-evtregistry.c: Do not include py-ref.h.
10172 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10173 * python/py-frame.c: Do not include py-ref.h.
10174 * python/py-framefilter.c: Do not include py-ref.h.
10175 * python/py-function.c: Do not include py-ref.h.
10176 * python/py-infevents.c: Do not include py-ref.h.
10177 * python/py-linetable.c: Do not include py-ref.h.
10178 * python/py-objfile.c: Do not include py-ref.h.
10179 * python/py-param.c: Do not include py-ref.h.
10180 * python/py-prettyprint.c: Do not include py-ref.h.
10181 * python/py-progspace.c: Do not include py-ref.h.
10182 * python/py-symbol.c: Do not include py-ref.h.
10183 * python/py-symtab.c: Do not include py-ref.h.
10184 * python/py-type.c: Do not include py-ref.h.
10185 * python/py-unwind.c: Do not include py-ref.h.
10186 * python/py-utils.c: Do not include py-ref.h.
10187 * python/py-value.c: Do not include py-ref.h.
10188 * python/py-varobj.c: Do not include py-ref.h.
10189 * python/py-xmethods.c: Do not include py-ref.h.
10190 * python/python.c: Do not include py-ref.h.
10191 * varobj.c: Do not include py-ref.h.
10192
101932019-01-22 Tom Tromey <tom@tromey.com>
10194
10195 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10196 keyword for bcache.
10197
101982019-01-22 Tom Tromey <tom@tromey.com>
10199
10200 * compile/compile-cplus-types.c: Remove a comment by #include.
10201
102022019-01-22 Tom Tromey <tom@tromey.com>
10203
10204 * compile/gcc-c-plugin.h: Include compile-internal.h.
10205
102062019-01-22 Tom Tromey <tom@tromey.com>
10207
10208 * stabsread.c (EXTERN): Do not define.
10209 (symnum, next_symbol_text_func, processing_gcc_compilation)
10210 (within_function, global_sym_chain, global_stabs)
10211 (previous_stab_code, this_object_header_files)
10212 (n_this_object_header_files)
10213 (n_allocated_this_object_header_files): Define.
10214 * stabsread.h (EXTERN): Never define. Use "extern".
10215
102162019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10217
10218 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10219 history_value.
10220
102212019-01-21 Tom Tromey <tom@tromey.com>
10222
10223 * ui-out.c: Fix includes.
10224 * tui/tui-source.c: Fix includes.
10225 * target.c: Fix includes.
10226 * remote.c: Fix includes.
10227 * regcache.c: Fix includes.
10228 * python/py-block.c: Fix includes.
10229 * printcmd.c: Fix includes.
10230 * or1k-tdep.c: Fix includes.
10231 * mi/mi-main.c: Fix includes.
10232 * m32r-tdep.c: Fix includes.
10233 * csky-tdep.c: Fix includes.
10234 * compile/compile-cplus-types.c: Fix includes.
10235 * cli/cli-interp.c: Fix includes.
10236
102372019-01-21 Alan Hayward <alan.hayward@arm.com>
10238
10239 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10240 for padding.
10241
102422019-01-16 Tom Tromey <tom@tromey.com>
10243
10244 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10245 earlier.
10246 (struct objfile) <msymbols_range>: Move from top level.
10247 <msymbols>: New method.
10248 (class objfile_msymbols): Remove.
10249 * symtab.c (default_collect_symbol_completion_matches_break_on):
10250 Update.
10251 * symmisc.c (dump_msymbols): Update.
10252 * stabsread.c (scan_file_globals): Update.
10253 * objc-lang.c (info_selectors_command, info_classes_command)
10254 (find_methods): Update.
10255 * minsyms.c (find_solib_trampoline_target): Update.
10256 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10257 * coffread.c (coff_symfile_read): Update.
10258 * ada-lang.c (ada_lookup_simple_minsym)
10259 (ada_collect_symbol_completion_matches): Update.
10260
102612019-01-16 Tom Tromey <tom@tromey.com>
10262
10263 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10264 type. Remove no-argument constructor.
10265 <iterator::operator++>: Simplify.
10266 <begin>: Update.
10267 <end>: Use minimal_symbol_count.
10268
102692019-01-16 Tom Tromey <tom@tromey.com>
10270
10271 * objfiles.h (struct objfile) <psymtabs>: New method.
10272 (class objfile_psymtabs): Remove.
10273 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10274 typedef.
10275 <range>: New method.
10276 (require_partial_symbols): Change return type.
10277 * psymtab.c (require_partial_symbols)
10278 (psym_expand_symtabs_matching): Update.
10279 * mdebugread.c (parse_partial_symbols): Update.
10280 * dbxread.c (dbx_end_psymtab): Update.
10281
102822019-01-15 Tom Tromey <tom@tromey.com>
10283
10284 * symtab.c (lookup_objfile_from_block)
10285 (lookup_symbol_in_objfile_symtabs)
10286 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10287 (find_line_symtab, info_sources_command)
10288 (default_collect_symbol_completion_matches_break_on)
10289 (make_source_files_completion_list): Update.
10290 * symmisc.c (print_objfile_statistics, dump_objfile)
10291 (maintenance_print_symbols, maintenance_info_symtabs)
10292 (maintenance_check_symtabs, maintenance_info_line_tables):
10293 Update.
10294 * source.c (select_source_symtab)
10295 (forget_cached_source_info_for_objfile): Update.
10296 * objfiles.h (class objfile_compunits): Remove.
10297 (struct objfile) <compunits_range>: New typedef.
10298 (compunits): New method.
10299 * objfiles.c (objfile_relocate1): Update.
10300 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10301 * maint.c (count_symtabs_and_blocks): Update.
10302 * linespec.c (iterate_over_all_matching_symtabs): Update.
10303 * cp-support.c (add_symbol_overload_list_qualified): Update.
10304 * coffread.c (coff_symtab_read): Update.
10305 * ada-lang.c (add_nonlocal_symbols)
10306 (ada_collect_symbol_completion_matches)
10307 (ada_add_global_exceptions): Update.
10308
103092019-01-15 Tom Tromey <tom@tromey.com>
10310
10311 * progspace.h (program_space) <objfiles_safe_range>: New
10312 typedef.
10313 <objfiles_safe>: New method.
10314 * objfiles.h (class all_objfiles_safe): Remove.
10315 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10316 * jit.c (jit_inferior_exit_hook): Update.
10317
103182019-01-17 Tom Tromey <tom@tromey.com>
10319
10320 * progspace.h (program_space) <objfiles_range>: New typedef.
10321 <objfiles>: New method.
10322 <objfiles_head>: Rename from objfiles.
10323 (object_files): Update.
10324 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10325 * guile/scm-pretty-print.c
10326 (ppscm_find_pretty_printer_from_objfiles): Update.
10327 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10328 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10329 Update.
10330 * python/py-progspace.c (pspy_get_objfiles): Update.
10331 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10332 Update.
10333 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10334 (objfpy_lookup_objfile_by_build_id): Update.
10335 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10336 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10337 Update.
10338 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10339 (expand_symtab_containing_pc, lookup_objfile_from_block)
10340 (lookup_static_symbol, basic_lookup_transparent_type)
10341 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10342 (find_line_symtab, info_sources_command)
10343 (default_collect_symbol_completion_matches_break_on)
10344 (make_source_files_completion_list, find_main_name): Update.
10345 * symmisc.c (print_symbol_bcache_statistics)
10346 (print_objfile_statistics, maintenance_print_symbols)
10347 (maintenance_print_msymbols, maintenance_print_objfiles)
10348 (maintenance_info_symtabs, maintenance_check_symtabs)
10349 (maintenance_expand_symtabs, maintenance_info_line_tables):
10350 Update.
10351 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10352 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10353 (map_overlay_command, unmap_overlay_command)
10354 (simple_overlay_update, expand_symtabs_matching)
10355 (map_symbol_filenames): Update.
10356 * symfile-debug.c (set_debug_symfile): Update.
10357 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10358 Update.
10359 * source.c (select_source_symtab, forget_cached_source_info):
10360 Update.
10361 * solib.c (solib_read_symbols): Update.
10362 * solib-spu.c (append_ocl_sos): Update.
10363 * psymtab.c (maintenance_print_psymbols)
10364 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10365 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10366 * printcmd.c (info_symbol_command): Update.
10367 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10368 Update.
10369 * objfiles.h (class all_objfiles): Remove.
10370 * objfiles.c (have_partial_symbols, have_full_symbols)
10371 (have_minimal_symbols, qsort_cmp, update_section_map)
10372 (shared_objfile_contains_address_p)
10373 (default_iterate_over_objfiles_in_search_order): Update.
10374 * objc-lang.c (info_selectors_command, info_classes_command)
10375 (find_methods): Update.
10376 * minsyms.c (find_solib_trampoline_target): Update.
10377 * maint.c (maintenance_info_sections)
10378 (maintenance_translate_address, count_symtabs_and_blocks):
10379 Update.
10380 * main.c (captured_main_1): Update.
10381 * linux-thread-db.c (try_thread_db_load_from_pdir)
10382 (has_libpthread): Update.
10383 * linespec.c (iterate_over_all_matching_symtabs)
10384 (search_minsyms_for_name): Update.
10385 * jit.c (jit_find_objf_with_entry_addr): Update.
10386 * hppa-tdep.c (find_unwind_entry)
10387 (hppa_lookup_stub_minimal_symbol): Update.
10388 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10389 Update.
10390 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10391 (elf_gnu_ifunc_resolve_by_got): Update.
10392 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10393 * dwarf-index-write.c (save_gdb_index_command): Update.
10394 * cp-support.c (add_symbol_overload_list_qualified): Update.
10395 * breakpoint.c (create_overlay_event_breakpoint)
10396 (create_longjmp_master_breakpoint)
10397 (create_std_terminate_master_breakpoint)
10398 (create_exception_master_breakpoint): Update.
10399 * blockframe.c (find_pc_partial_function): Update.
10400 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10401 (ada_collect_symbol_completion_matches)
10402 (ada_add_global_exceptions): Update.
10403
104042019-01-17 Tom Tromey <tom@tromey.com>
10405
10406 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10407 declare VEC.
10408 (solib_target_parse_libraries): Change return type.
10409 (library_list_start_segment, library_list_start_section)
10410 (library_list_end_library, library_list_start_library); Update.
10411 (solib_target_free_library_list): Remove.
10412 (solib_target_parse_libraries): Remove cleanup. Change return
10413 type.
10414 (solib_target_current_sos): Update.
10415
104162019-01-17 Tom Tromey <tromey@bapiya>
10417
10418 * valprint.c: Replace "the the" with "the".
10419 * symtab.c: Replace "the the" with "the".
10420 * solib.c: Replace "the the" with "the".
10421 * solib-dsbt.c: Replace "the the" with "the".
10422 * linespec.c: Replace "the the" with "the".
10423 * dwarf2loc.h: Replace "the the" with "the".
10424 * amd64-windows-tdep.c: Replace "the the" with "the".
10425 * aarch64-tdep.c: Replace "the the" with "the".
10426
104272019-01-16 Keith Seitz <keiths@redhat.com>
10428
10429 PR gdb/23773
10430 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10431 <builder>: Rename to ..
10432 <m_builder>: ... this and make private.
10433 (dwarf2_cu::get_builder): New method. Change all users of
10434 `builder' to use this method.
10435 (dwarf2_start_symtab): Move to ...
10436 (dwarf2_cu::start_symtab): ... here. Update all callers
10437 (setup_type_unit_groups): Move to ...
10438 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10439 callers.
10440 (dwarf2_cu::reset_builder): New method.
10441 (process_full_compunit, process_full_type_unit): Use
10442 dwarf2_cu::reset_builder.
10443 (follow_die_offset): Record the ancestor CU if it is different
10444 from the followed DIE's CU.
10445 (follow_die_sig_1): Likewise.
10446
104472019-01-15 Tom Tromey <tom@tromey.com>
10448
10449 * remote.c (class remote_state) <buf>: Now a char_vector.
10450 <buf_size>: Remove.
10451 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10452 parameter.
10453 (remote_target::getpkt_or_notif_sane_1)
10454 (remote_target::getpkt_sane)
10455 (remote_target::getpkt_or_notif_sane): Likewise.
10456 (class remote_target) <putpkt>: New overload.
10457 (remote_target::read_frame): Change type of "buf_p". Remove
10458 sizeof_p parameter.
10459 (packet_ok): New overload.
10460 (packet_check_result): New overload.
10461 Update all uses.
10462
104632019-01-14 Tom Tromey <tom@tromey.com>
10464
10465 * remote-notif.c (handle_notification, remote_notif_ack)
10466 (remote_notif_parse): Make "buf" const.
10467 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10468 const.
10469 (remote_notif_parse, remote_notif_ack, handle_notification):
10470 Likewise.
10471 * remote.c (remote_notif_stop_parse): Make "buf" const.
10472 (remote_target::remote_parse_stop_reply): Make "buf" const.
10473 (remote_notif_stop_ack): Make "buf" const.
10474
104752019-01-14 Tom Tromey <tom@tromey.com>
10476
10477 * remote.c (remote_console_output): Make parameter const.
10478
104792019-01-14 Tom Tromey <tom@tromey.com>
10480
10481 * target-debug.h (target_debug_print_signals): Constify.
10482 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10483 * procfs.c (procfs_target::pass_signals): Update.
10484 * linux-nat.c (linux_nat_target::pass_signals): Update.
10485 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10486 * target-delegates.c: Rebuild.
10487 * remote.c (remote_target::program_signals): Update.
10488 (remote_target::pass_signals): Update.
10489 * target.c (target_pass_signals): Constify argument.
10490 (target_program_signals): Likewise.
10491 * target.h (struct target_ops) <pass_signals, program_signals>:
10492 Constify argument.
10493 (target_pass_signals, target_program_signals): Constify argument.
10494
104952019-01-14 Tom Tromey <tom@tromey.com>
10496
10497 PR tui/28819:
10498 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10499
105002019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10501
10502 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10503 field.
10504 * rs6000-tdep.c: Include reggroups.h.
10505 (IS_V_ALIAS_PSEUDOREG): Define.
10506 (rs6000_register_name): Return names for the "vX" aliases.
10507 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10508 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10509 aliases. Call default_register_reggroup_p for all other
10510 pseudo-registers.
10511 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10512 New functions.
10513 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10514 Handle "vX" aliases.
10515 (v_alias_pseudo_register_collect): New function.
10516 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10517 (rs6000_gdbarch_init): Initialize "vX" aliases as
10518 pseudo-registers. Restore registration of
10519 rs6000_pseudo_register_reggroup_p with
10520 set_tdesc_pseudo_register_reggroup_p.
10521
105222019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10523
10524 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10525 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10526 set_gdbarch_num_pseudo_regs.
10527
105282019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10529
10530 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10531 Remove arg prefixname, add do_set and do_show.
10532 Add member functions set_list and show_list.
10533 * cli/cli-style.c (class cli_style_option): Update accordingly.
10534 (style_set_list): Move to file scope.
10535 (style_show_list): Likewise.
10536 (set_style): Call help_list.
10537 (show_style): Call cmd_show_list.
10538 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10539 Update to use the new macro.
10540
105412019-10-12 Joel Brobecker <brobecker@adacore.com>
10542
10543 * ada-lang.c (_initialize_ada_language): Expand the help text
10544 for the "catch exception" command.
10545
105462019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10547
10548 * symtab.c (matching_obj_sections): Initialize obj,
10549 declare it closer to its usage.
10550
105512019-01-10 Tom Tromey <tom@tromey.com>
10552
10553 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10554 (basic_inf_threads_range): Remove.
10555 (inf_threads_range, inf_non_exited_threads_range)
10556 (safe_inf_threads_range): Use next_adapter.
10557
105582019-01-10 Keith Seitz <keiths@redhat.com>
10559
10560 PR gdb/23712
10561 PR symtab/23010
10562 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10563 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10564
105652019-01-10 Keith Seitz <keiths@redhat.com>
10566
10567 PR gdb/23712
10568 PR symtab/23010
10569 * dictionary.c (pending_to_vector): Remove.
10570 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10571 Remove _1 suffix, replacing functions of the same name. Update
10572 all callers.
10573 (dict_create_hashed, dict_create_hashed_expandable)
10574 (dict_create_linear, dict_create_linear_expandable, dict_free)
10575 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10576 Make functions static.
10577
105782019-01-10 Keith Seitz <keiths@redhat.com>
10579
10580 PR gdb/23712
10581 PR symtab/23010
10582 * dictionary.h (struct dictionary): Replace declaration with
10583 multidictionary.
10584 (dict_create_hashed, dict_create_hashed_expandable)
10585 (dict_create_linear, dict_create_linear_expandable)
10586 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10587 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10588 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10589 taking multidictionary argument.
10590 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10591 * block.h (struct block) <dict>: Change to multidictionary
10592 and rename `multidict'.
10593 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10594 symmisc.c: Update all dictionary references to multidictionary.
10595
105962019-01-10 Keith Seitz <keiths@redhat.com>
10597
10598 PR gdb/23712
10599 PR symtab/23010
10600 * dictionary.c: Include unordered_map.
10601 (pending_to_vector): New function.
10602 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10603 Rewrite the non-"_1" functions to take vector instead
10604 of linked list.
10605 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10606 "new" _1 versions of the same name.
10607 (multidictionary): Define.
10608 (std::hash<enum language): New definition.
10609 (collate_pending_symbols_by_language, mdict_create_hashed)
10610 (mdict_create_hashed_expandable, mdict_create_linear)
10611 (mdict_create_linear_expandable, mdict_free)
10612 (find_language_dictionary, create_new_language_dictionary)
10613 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10614 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10615 (mdict_size, mdict_empty): New functions.
10616 * dictionary.h (mdict_iterator): Define.
10617
106182019-01-10 Pedro Alves <palves@redhat.com>
10619
10620 * breakpoint.c (read_uploaded_action)
10621 (create_tracepoint_from_upload): Adjust to use
10622 gdb::unique_xmalloc_ptr.
10623 * ctf.c (ctf_write_uploaded_tp):
10624 (SET_ARRAY_FIELD): Use emplace_back.
10625 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10626 * tracefile-tfile.c (tfile_write_uploaded_tp):
10627 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10628 gdb::unique_xmalloc_ptr.
10629 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10630 at_string, cond_string, cmd_strings>: Replace char pointers
10631 with gdb::unique_xmalloc_ptr.
10632
106332019-01-10 Pedro Alves <palves@redhat.com>
10634
10635 * solib-target.c (library_list_start_library): Don't xstrdup name.
10636
106372019-01-10 Pedro Alves <palves@redhat.com>
10638
10639 * mdebugread.c (parse_partial_symbols): Use
10640 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10641
106422019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10643
10644 * linux-fork.c (scoped_switch_fork_info)
10645 <~scoped_switch_fork_info>: Fix incorrect variable name.
10646
106472019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10648
10649 * linux-fork.c (scoped_switch_fork_info)
10650 <scoped_switch_fork_info>: Make explicit.
10651 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10652
106532019-01-10 Tom Tromey <tom@tromey.com>
10654
10655 * objfiles.h (objfile::reset_psymtabs): Update.
10656 * objfiles.c (objfile::objfile): Update.
10657 * psymtab.h (psymtab_storage::obstack): Update.
10658 (psymtab_storage::m_obstack): Use gdb::optional.
10659 (class psymtab_storage): Update comment. Remove objfile
10660 parameter.
10661 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10662
106632019-01-10 Tom Tromey <tom@tromey.com>
10664
10665 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10666 <free_psymtabs>: Now private.
10667 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10668 (allocate_psymtab): Use new method.
10669
106702019-01-10 Tom Tromey <tom@tromey.com>
10671
10672 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10673 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10674 * mdebugread.c (parse_partial_symbols): Use
10675 allocate_dependencies.
10676 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10677 allocate_dependencies.
10678 (process_psymtab_comp_unit_reader)
10679 (build_type_psymtab_dependencies): Likewise.
10680 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10681
106822019-01-10 Tom Tromey <tom@tromey.com>
10683
10684 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10685 PSYMBOL_SET_LANGUAGE.
10686 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10687
106882019-01-10 Tom Tromey <tom@tromey.com>
10689
10690 * psymtab.h (psymtab_storage::obstack): New method.
10691 <m_obstack>: Rename from obstack; now private.
10692 * psymtab.c (psymtab_storage): Update.
10693 * dwarf2read.c (create_addrmap_from_index)
10694 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10695 Update.
10696
106972019-01-10 Tom Tromey <tom@tromey.com>
10698
10699 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10700 * objfiles.h (objfile::reset_psymtabs): New method.
10701
107022019-01-10 Tom Tromey <tom@tromey.com>
10703
10704 * symmisc.c (print_symbol_bcache_statistics): Update.
10705 (print_objfile_statistics): Update.
10706 * symfile.c (reread_symbols): Update.
10707 * psymtab.h (class psymtab_storage): New.
10708 * psymtab.c (psymtab_storage): New constructor.
10709 (~psymtab_storage): New destructor.
10710 (require_partial_symbols): Update.
10711 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10712 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10713 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10714 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10715 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10716 (start_psymtab_common, end_psymtab_common)
10717 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10718 (allocate_psymtab): Update.
10719 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10720 Update.
10721 (dump_psymtab_addrmap, maintenance_print_psymbols)
10722 (maintenance_check_psymtabs): Update.
10723 (class objfile_psymtabs): Move to objfiles.h.
10724 * psympriv.h (discard_psymtab): Now inline.
10725 (psymtab_discarder::psymtab_discarder): Update.
10726 (psymtab_discarder::~psymtab_discarder): Update.
10727 (ALL_OBJFILE_PSYMTABS): Rewrite.
10728 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10729 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10730 Remove fields.
10731 <partial_symtabs>: New field.
10732 (class objfile_psymtabs): Move from psymtab.h. Update.
10733 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10734 psymbol_cache.
10735 (objfile::~objfile): Don't destroy psymbol_cache.
10736 * mdebugread.c (parse_partial_symbols): Update.
10737 * dwarf2read.c (create_addrmap_from_index)
10738 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10739 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10740 (add_partial_subprogram, dwarf2_ranges_read): Update.
10741 * dwarf-index-write.c (write_address_map)
10742 (write_one_signatured_type, recursively_write_psymbols)
10743 (class debug_names, class debug_names, write_psymtabs_to_index):
10744 Update.
10745
107462019-01-10 Tom Tromey <tom@tromey.com>
10747
10748 * symtab.h (SYMBOL_SET_NAMES): Update.
10749 (symbol_set_names): Update.
10750 (MSYMBOL_SET_NAMES): Update.
10751 * symtab.c (symbol_set_names): Change argument to be an
10752 objfile_per_bfd_storage.
10753 * psymtab.c (add_psymbol_to_bcache): Update.
10754 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10755
107562019-01-10 Tom Tromey <tom@tromey.com>
10757
10758 * symtab.c (create_demangled_names_hash): Change argument to be an
10759 objfile_per_bfd_storage.
10760 (symbol_set_names): Update.
10761
107622019-01-10 Tom Tromey <tom@tromey.com>
10763
10764 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10765 init_psymbol_list.
10766 * psymtab.c (init_psymbol_list): Do nothing if already called.
10767 * psympriv.h (init_psymbol_list): Add comment.
10768 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10769 init_psymbol_list.
10770 * dbxread.c (dbx_symfile_read): Unconditionally call
10771 init_psymbol_list.
10772
107732019-01-10 Tom Tromey <tom@tromey.com>
10774
10775 * xcoffread.c (scan_xcoff_symtab): Update.
10776 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10777 "where".
10778 * mdebugread.c (parse_partial_symbols)
10779 (handle_psymbol_enumerators): Update.
10780 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10781 * dbxread.c (read_dbx_symtab): Update.
10782 * psympriv.h (psymbol_placement): New enum.
10783 (add_psymbol_to_list): Update.
10784
107852019-01-10 Tom Tromey <tom@tromey.com>
10786
10787 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10788 static_psymbols parameters.
10789 (scan_xcoff_symtab): Update.
10790 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10791 static_psymbols parameters.
10792 * psympriv.h (start_psymtab_common): Update.
10793 * mdebugread.c (parse_partial_symbols): Update.
10794 * dwarf2read.c (create_partial_symtab): Update.
10795 * dbxread.c (read_dbx_symtab): Update.
10796 (start_psymtab): Remove global_psymbols and static_psymbols
10797 parameters.
10798
107992019-01-10 Tom Tromey <tom@tromey.com>
10800
10801 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10802 * psymtab.c (allocate_psymtab): Add comment.
10803 * psympriv.h (allocate_psymtab): Add comment.
10804 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10805 initializations.
10806 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10807
108082019-01-10 Tom Tromey <tom@tromey.com>
10809
10810 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10811 Don't declare.
10812 * mipsread.c: Include mdebugread.h.
10813 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10814 Declare.
10815 * elfread.c: Include mdebugread.h.
10816
108172019-01-09 Tom Tromey <tom@tromey.com>
10818
10819 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10820 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10821 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10822 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10823 (psym_lookup_symbol, psym_find_last_source_symtab)
10824 (psym_forget_cached_source_info, psym_print_stats)
10825 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10826 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10827 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10828 (psym_find_compunit_symtab_by_address)
10829 (maintenance_print_psymbols, maintenance_info_psymtabs)
10830 (maintenance_check_psymtabs): Use ranged for.
10831 * psymtab.h (class objfile_psymtabs): New.
10832 (require_partial_symbols): Return objfile_psymtabs.
10833 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10834
108352019-01-09 Tom Tromey <tom@tromey.com>
10836
10837 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10838 (find_pc_mapped_section, list_overlays_command)
10839 (map_overlay_command, unmap_overlay_command)
10840 (simple_overlay_update): Use all_objfiles.
10841 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10842 * printcmd.c (info_symbol_command): Use all_objfiles.
10843 * objfiles.h (ALL_OBJSECTIONS): Remove.
10844 * maint.c (maintenance_translate_address): Use all_objfiles.
10845 * gcore.c (gcore_create_callback): Use all_objfiles.
10846 (objfile_find_memory_regions): Likewise.
10847
108482019-01-09 Tom Tromey <tom@tromey.com>
10849
10850 * symtab.c (find_line_symtab, info_sources_command)
10851 (make_source_files_completion_list): Use objfile_compunits.
10852 * source.c (select_source_symtab): Use objfile_compunits.
10853 * objfiles.h (struct objfile): Update comment.
10854 (ALL_OBJFILES): Remove.
10855 (ALL_FILETABS): Remove.
10856 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10857 objfile_compunits.
10858
108592019-01-09 Tom Tromey <tom@tromey.com>
10860
10861 * symmisc.c (print_objfile_statistics, dump_objfile)
10862 (maintenance_print_symbols): Use compunit_filetabs.
10863 * source.c (forget_cached_source_info_for_objfile): Use
10864 compunit_filetabs.
10865 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10866 (ALL_FILETABS): Use compunit_filetabs.
10867 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10868 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10869
108702019-01-09 Tom Tromey <tom@tromey.com>
10871
10872 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10873 (compunit_filetabs): New.
10874 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10875 compunit_filetabs.
10876 (info_sources_command, make_source_files_completion_list): Remove
10877 declaration.
10878 * symmisc.c (print_objfile_statistics, dump_objfile)
10879 (maintenance_print_symbols): Remove declaration.
10880 (maintenance_info_symtabs): Use compunit_filetabs.
10881 (maintenance_info_line_tables): Likewise.
10882 * source.c (select_source_symtab): Change local variable name.
10883 (forget_cached_source_info_for_objfile): Remove declaration.
10884 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10885 * objfiles.c (objfile_relocate1): Remove declaration.
10886 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10887 declaration.
10888 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10889 * coffread.c (coff_symtab_read): Remove declaration.
10890 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10891 compunit_filetabs.
10892
108932019-01-09 Tom Tromey <tom@tromey.com>
10894
10895 * symtab.c (lookup_objfile_from_block)
10896 (find_pc_sect_compunit_symtab, search_symbols)
10897 (default_collect_symbol_completion_matches_break_on): Use
10898 objfile_compunits.
10899 * objfiles.h (ALL_COMPUNITS): Remove.
10900 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10901 * cp-support.c (add_symbol_overload_list_qualified): Use
10902 objfile_compunits.
10903 * ada-lang.c (ada_collect_symbol_completion_matches)
10904 (ada_add_global_exceptions): Use objfile_compunits.
10905
109062019-01-09 Tom Tromey <tom@tromey.com>
10907
10908 * source.c (select_source_symtab)
10909 (forget_cached_source_info_for_objfile): Remove declaration.
10910 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10911 declaration.
10912 * maint.c (count_symtabs_and_blocks): Remove declaration.
10913 * cp-support.c (add_symbol_overload_list_qualified): Remove
10914 declaration.
10915 * coffread.c (coff_symtab_read): Remove declaration.
10916 * symtab.c (lookup_symbol_in_objfile_symtabs)
10917 (basic_lookup_transparent_type_1): Use objfile_compunits.
10918 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10919 (info_sources_command, search_symbols)
10920 (default_collect_symbol_completion_matches_break_on)
10921 (make_source_files_completion_list): Remove declaration.
10922 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10923 (ada_collect_symbol_completion_matches)
10924 (ada_add_global_exceptions): Remove declaration.
10925 * linespec.c (iterate_over_all_matching_symtabs): Use
10926 objfile_compunits.
10927 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10928 (class objfile_compunits): New.
10929 (ALL_COMPUNITS): Use objfile_compunits.
10930 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10931 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10932 objfile_compunits.
10933 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10934
109352019-01-09 Tom Tromey <tom@tromey.com>
10936
10937 * symtab.c (search_symbols)
10938 (default_collect_symbol_completion_matches_break_on): Use
10939 objfile_msymbols.
10940 * ada-lang.c (ada_lookup_simple_minsym)
10941 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10942 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10943 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10944 objfile_msymbols.
10945 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10946 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10947 * objc-lang.c (find_methods): Use objfile_msymbols.
10948 (info_selectors_command, info_classes_command): Likewise.
10949 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10950 * objfiles.h (class objfile_msymbols): New.
10951 (ALL_OBJFILE_MSYMBOLS): Remove.
10952 (ALL_MSYMBOLS): Remove.
10953
109542019-01-09 Tom Tromey <tom@tromey.com>
10955
10956 * common/next-iterator.h (next_adapter): Add Iterator template
10957 parameter.
10958 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10959 (class all_objfiles_safe): New.
10960 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10961 * objfiles.c (put_objfile_before): Update comment.
10962 (add_separate_debug_objfile): Likewise.
10963 (free_all_objfiles): Use all_objfiles_safe.
10964 (objfile_purge_solibs): Likewise.
10965
109662019-01-09 Tom Tromey <tom@tromey.com>
10967
10968 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10969 (expand_symtab_containing_pc, lookup_static_symbol)
10970 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10971 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10972 all_objfiles.
10973 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10974 * breakpoint.c (create_overlay_event_breakpoint)
10975 (create_longjmp_master_breakpoint)
10976 (create_std_terminate_master_breakpoint)
10977 (create_exception_master_breakpoint): Use all_objfiles.
10978 * linux-thread-db.c (try_thread_db_load_from_pdir)
10979 (has_libpthread): Use all_objfiles.
10980 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10981 * linespec.c (iterate_over_all_matching_symtabs)
10982 (search_minsyms_for_name): Use all_objfiles.
10983 * maint.c (maintenance_info_sections): Use all_objfiles.
10984 * main.c (captured_main_1): Use all_objfiles.
10985 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10986 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10987 * guile/scm-pretty-print.c
10988 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10989 * solib-spu.c (append_ocl_sos): Use all_objfiles.
10990 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10991 (maintenance_print_msymbols): Use all_objfiles.
10992 * source.c (select_source_symtab): Use all_objfiles.
10993 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10994 * symfile.c (remove_symbol_file_command)
10995 (expand_symtabs_matching, map_symbol_filenames): Use
10996 all_objfiles.
10997 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10998 all_objfiles.
10999 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11000 * objc-lang.c (find_methods): Use all_objfiles.
11001 * objfiles.c (have_partial_symbols, have_full_symbols)
11002 (have_minimal_symbols, qsort_cmp)
11003 (default_iterate_over_objfiles_in_search_order): Use
11004 all_objfiles.
11005 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11006 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11007 (maintenance_check_psymtabs): Use all_objfiles.
11008 (ALL_PSYMTABS): Remove.
11009 * compile/compile-object-run.c (do_module_cleanup): Use
11010 all_objfiles.
11011 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11012 * cp-support.c (add_symbol_overload_list_qualified): Use
11013 all_objfiles.
11014 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11015 Use all_objfiles.
11016 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11017 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11018 all_objfiles.
11019 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11020 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11021 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11022 Uses all_objfiles.
11023 * solib.c (solib_read_symbols): Use all_objfiles
11024
110252019-01-09 Tom Tromey <tom@tromey.com>
11026
11027 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11028 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11029 all_objfiles.
11030 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11031 * symmisc.c (print_symbol_bcache_statistics)
11032 (print_objfile_statistics, maintenance_print_objfiles)
11033 (maintenance_info_symtabs, maintenance_check_symtabs)
11034 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11035 all_objfiles.
11036 * source.c (forget_cached_source_info): Use all_objfiles.
11037 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11038 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11039 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11040 * objfiles.c (update_section_map): Use all_objfiles.
11041 (shared_objfile_contains_address_p): Likewise.
11042 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11043 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11044
110452019-01-09 Tom Tromey <tom@tromey.com>
11046
11047 * common/next-iterator.h: New file.
11048 * objfiles.h (class all_objfiles): New.
11049 (struct objfile_iterator): New.
11050
110512019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11052
11053 * NEWS: Move the description of the changed "frame", "select-frame",
11054 and "info frame" commands to the Changed commands section.
11055
110562019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11057
11058 * gdbtypes.c (check_stub_method_group): Remove handling of old
11059 mangling schemes.
11060 * linespec.c (find_methods): Likewise.
11061 * stabsread.c (read_member_functions): Likewise.
11062 * valops.c (search_struct_method): Likewise.
11063 (value_struct_elt_for_reference): Likewise.
11064 * NEWS: Mention this change.
11065
110662019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11067
11068 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11069 print_source_lines.
11070 * source.c (print_source_lines_base): Update line number check.
11071 (print_source_lines): New function.
11072 (source_lines_range::source_lines_range): New function.
11073 * source.h (class source_lines_range): New class.
11074 (print_source_lines): New declaration.
11075
110762019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11077
11078 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11079
110802019-01-08 Tom Tromey <tom@tromey.com>
11081 Simon Marchi <simon.marchi@ericsson.com>
11082
11083 PR gdb/24060
11084 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11085 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11086 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11087 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11088 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11089 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11090
110912019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11092
11093 * source.c (select_source_symtab): Move header comment to
11094 declaration in source.h.
11095 (forget_cached_source_info_for_objfile): Likewise.
11096 (forget_cached_source_info): Likewise.
11097 (identify_source_line): Likewise.
11098 * source.h (identify_source_line): Move declaration from symtab.h
11099 and add comment from source.c
11100 (print_source_lines): Likewise.
11101 (forget_cached_source_info_for_objfile): Likewise.
11102 (forget_cached_source_info): Likewise.
11103 (select_source_symtab): Likewise.
11104 (enum print_source_lines_flag): Move definition from symtab.h.
11105 * symtab.h (identify_source_line): Move declaration to source.h.
11106 (print_source_lines): Likewise.
11107 (forget_cached_source_info_for_objfile): Likewise.
11108 (forget_cached_source_info): Likewise.
11109 (select_source_symtab): Likewise.
11110 (enum print_source_lines_flag): Move definition to source.h.
11111 * tui/tui-hooks.c: Add 'source.h' include.
11112
111132019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11114
11115 * source.c (print_source_lines_base): Handle requests to print
11116 reverse line number sequences, and guard against empty lines
11117 string.
11118
111192019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11120
11121 * source.c (print_source_lines_base): Fix skip of '\r' if next
11122 character is '\n'.
11123
111242019-01-06 Tom Tromey <tom@tromey.com>
11125
11126 * c-exp.y (struct c_parse_state) <macro_original_text,
11127 expansion_obstack>: New member.
11128 (macro_original_text, expansion_obstack): Remove globals.
11129 (scan_macro_expansion, scanning_macro_expansion)
11130 (finished_macro_expansion): Update.
11131 (scan_macro_cleanup): Remove.
11132 (yylex, c_parse): Update.
11133
111342019-01-06 Tom Tromey <tom@tromey.com>
11135
11136 * c-exp.y (struct c_parse_state) <strings>: New member.
11137 (operator_stoken): Update.
11138
111392019-01-06 Tom Tromey <tom@tromey.com>
11140
11141 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11142 (union type_stack_elt) <typelist_val>: Now a pointer to
11143 std::vector.
11144 (type_stack_cleanup): Don't declare.
11145 (push_typelist): Update.
11146 * parse.c (pop_typelist): Return a std::vector.
11147 (push_typelist): Take a std::vector.
11148 (follow_types): Update. Do not free args.
11149 (type_stack_cleanup): Remove.
11150 * c-exp.y (struct c_parse_state): New.
11151 (cpstate): New global.
11152 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11153 (nonempty_typelist): Update.
11154 (func_mod): Create a new vector.
11155 (c_parse): Create a c_parse_state.
11156 (check_parameter_typelist): Do not delete params.
11157 (function_method): Update. Do not delete type_list.
11158
111592019-01-06 Tom Tromey <tom@tromey.com>
11160
11161 PR gdb/28155:
11162 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11163 check_typedef.
11164 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11165 (print_return_value): Likewise.
11166
111672019-01-05 Tom Tromey <tom@tromey.com>
11168
11169 * contrib/cleanup_check.py: Remove.
11170 * contrib/gcc-with-excheck: Remove.
11171 * contrib/exsummary.py: Remove.
11172 * contrib/excheck.py: Remove.
11173
111742019-01-05 Joel Brobecker <brobecker@adacore.com>
11175
11176 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11177 NULL. Initialize tpprev to NULL instead of assigning it
11178 to NULL on the next statement.
11179 * windows-nat.c (windows_delete_thread): Remove check for
11180 main_thread_id before printing thread exit notifications.
11181 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11182 Remove thread ID check against main_thread_id.
11183 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11184 windows_delete_thread.
11185 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11186
111872019-01-04 Tom Tromey <tom@tromey.com>
11188
11189 * compile/compile.c (_initialize_compile): Use upper case for
11190 metasyntactic variables.
11191 * symmisc.c (_initialize_symmisc): Use upper case for
11192 metasyntactic variables.
11193 * psymtab.c (_initialize_psymtab): Use upper case for
11194 metasyntactic variables.
11195 * demangle.c (demangle_command): Use upper case for metasyntactic
11196 variables.
11197 (_initialize_demangler): Likewise.
11198 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11199 variables.
11200
112012019-01-03 Tom Tromey <tom@tromey.com>
11202
11203 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11204
112052019-01-03 Tom Tromey <tom@tromey.com>
11206
11207 * python/py-symtab.c (salpy_str): Update.
11208 (struct salpy_sal_object) <symtab>: Now a PyObject.
11209 (salpy_dealloc): Update.
11210 (del_objfile_sal): Use gdbpy_ref.
11211
112122019-01-03 Tom Tromey <tom@tromey.com>
11213
11214 * python/py-type.c (convert_field): Use new_reference. Return
11215 gdbpy_ref.
11216 (make_fielditem): Return gdbpy_ref.
11217 (typy_fields): Update.
11218 (typy_getitem): Update.
11219 (field_name): Return gdbpy_ref. Use new_reference.
11220 (typy_iterator_iternext): Update.
11221
112222019-01-03 Tom Tromey <tom@tromey.com>
11223
11224 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11225
112262019-01-03 Tom Tromey <tom@tromey.com>
11227
11228 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11229 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11230 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11231 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11232 (pspy_set_type_printers): Likewise.
11233 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11234 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11235 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11236 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11237 (objfpy_set_type_printers): Likewise.
11238
112392019-01-03 Tom Tromey <tom@tromey.com>
11240
11241 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11242 (gdbpy_print_stack): Use gdbpy_err_fetch.
11243 * python/python-internal.h (class gdbpy_err_fetch): New class.
11244 (class gdbpy_enter) <m_error_type, m_error_value,
11245 m_error_traceback>: Remove.
11246 <m_error>: New member.
11247 (gdbpy_exception_to_string): Don't declare.
11248 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11249 * python/py-value.c (convert_value_from_python): Use
11250 gdbpy_err_fetch.
11251 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11252 gdbpy_exception_to_string.
11253 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11254 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11255 gdbpy_err_fetch.
11256
112572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11258
11259 * linux-nat.c (delete_lwp_cleanup): Delete.
11260 (struct lwp_deleter): New struct.
11261 (lwp_info_up): New typedef.
11262 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11263 lwp_info_up.
11264
112652019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11266
11267 * linux-fork.c (class scoped_switch_fork_info): New class.
11268 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11269
112702019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11271
11272 * valops.c (find_overload_match): Remove use of null_cleanup, and
11273 calls to do_cleanups.
11274
112752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11276
11277 * compile/compile-cplus-types.c
11278 (compile_cplus_instance::decl_name): Handle changes to
11279 cp_func_name.
11280 * cp-support.c (cp_func_name): Update header comment, update
11281 return type.
11282 * cp-support.h (cp_func_name): Update return type in declaration.
11283 * valops.c (find_overload_match): Move temp_func local to top
11284 level of function and change its type. Use temp_func to hold and
11285 delete temporary string obtained from cp_func_name.
11286
112872019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11288
11289 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11290 gdb::char_vector, remove cleanup, and update uses of `msg`.
11291
112922019-01-03 Jim Wilson <jimw@sifive.com>
11293
11294 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11295
112962019-01-02 Tom Tromey <tom@tromey.com>
11297
11298 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11299 (tdesc_parse_xml): Remove cleanups.
11300 * target-descriptions.h (make_cleanup_free_target_description):
11301 Don't declare.
11302 (target_desc_deleter): New struct.
11303 (target_desc_up): New typedef.
11304 * target-descriptions.c (target_desc_deleter::operator()): Rename
11305 from free_target_description.
11306 (make_cleanup_free_target_description): Remove.
11307
113082019-01-02 Tom Tromey <tom@tromey.com>
11309
11310 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11311 constructor, destructor.
11312 (linespec_parser): Remove typedef.
11313 (~linespec_parser): Rename from linespec_parser_delete.
11314 (linespec_lex_to_end, linespec_complete_label)
11315 (linespec_complete): Update.
11316 (decode_line_full): Remove cleanups.
11317 (decode_line_1): Update.
11318
113192019-01-02 Tom Tromey <tom@tromey.com>
11320
11321 * python/python-internal.h (inferior_to_inferior_object): Change
11322 return type.
11323 * python/py-exitedevent.c (create_exited_event_object): Update.
11324 * python/py-inferior.c (inferior_to_inferior_object): Return
11325 gdbpy_ref.
11326 (python_new_inferior, python_inferior_deleted)
11327 (thread_to_thread_object, delete_thread_object)
11328 (build_inferior_list, gdbpy_selected_inferior): Update.
11329 * python/py-infthread.c (create_thread_object): Update. Also fail
11330 if inferior_to_inferior_object fails.
11331
113322019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11333
11334 * inferior.h (class inferior) <displaced_step_state>: New field.
11335 * infrun.h (struct displaced_step_state): Move here from
11336 infrun.c. Initialize fields, add constructor.
11337 <inf>: Remove field.
11338 <reset>: New method.
11339 * infrun.c (struct displaced_step_inferior_state): Move to
11340 infrun.h.
11341 (displaced_step_inferior_states): Remove.
11342 (get_displaced_stepping_state): Adust.
11343 (displaced_step_in_progress_any_inferior): Adjust.
11344 (displaced_step_in_progress_thread): Adjust.
11345 (displaced_step_in_progress): Adjust.
11346 (add_displaced_stepping_state): Remove.
11347 (get_displaced_step_closure_by_addr): Adjust.
11348 (remove_displaced_stepping_state): Remove.
11349 (infrun_inferior_exit): Call displaced_step_state.reset.
11350 (use_displaced_stepping): Don't check for NULL.
11351 (displaced_step_prepare_throw): Call
11352 get_displaced_stepping_state.
11353 (displaced_step_fixup): Don't check for NULL.
11354 (prepare_for_detach): Don't check for NULL.
11355
113562019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11357
11358 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11359 in case of call that did not complete.
11360
113612019-01-02 Andrey Utkin <autkin@undo.io>
11362
11363 * symfile.c (find_separate_debug_file): Fix search of debug files for
11364 remote debuggee.
11365
113662019-01-02 Tom Tromey <tom@tromey.com>
11367
11368 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11369 indentation.
11370 * python/py-frame.c (frapy_older): Remove cast.
11371 (frapy_newer): Likewise.
11372 * python/py-breakpoint.c (local_setattro): Remove cast.
11373 * python/py-arch.c (archpy_name): Remove local variable.
11374 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11375
113762019-01-02 Joel Brobecker <brobecker@adacore.com>
11377
11378 * unittests/basic_string_view/element_access/char/empty.cc:
11379 Fix year range in copyright header.
11380
113812019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11382
11383 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11384 Delete.
11385 <operator==>: Update with for removed field.
11386 <hash>: Likewise.
11387 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11388 <isa_features>: ...this.
11389 <abi_features>: New field.
11390 (riscv_isa_flen): Update comment.
11391 (riscv_abi_xlen): New declaration.
11392 (riscv_abi_flen): New declaration.
11393 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11394 isa_features.
11395 (riscv_abi_xlen): New function.
11396 (riscv_isa_flen): Update to get answer from isa_features.
11397 (riscv_abi_flen): New function.
11398 (riscv_has_fp_abi): Update to get answer from abi_features.
11399 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11400 xlen and flen.
11401 (riscv_call_info) <xlen, flen>: Update comment.
11402 (riscv_call_arg_struct): Remove invalid assertions
11403 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11404 is removed.
11405 (riscv_gdbarch_init): Gather isa features and abi features
11406 separately, ensure both match on the gdbarch when reusing an old
11407 gdbarch. Relax an error check to allow 32-bit abi float to run on
11408 a target with 64-bit float hardware.
11409
114102019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11411
11412 * source.c (search_command_helper): Stop reverse search
11413 when line 1 has been searched.
11414
114152019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11416
11417 * record-full.c (record_full_base_target::close): Rewrite
11418 record_full_core_buf_list free logic.
11419
114202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11421
11422 * break-catch-syscall.c (print_one_catch_syscall): xfree
11423 the last text.
11424
114252019-01-01 Joel Brobecker <brobecker@adacore.com>
11426
11427 * top.c (print_gdb_version): Update Copyright year in version
11428 message.
11429
114302019-01-01 Joel Brobecker <brobecker@adacore.com>
11431
11432 Update copyright year range in all GDB files.
11433
114342019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
11435
11436 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11437
11438For older changes see ChangeLog-2018.
11439\f
11440Local Variables:
11441mode: change-log
11442left-margin: 8
11443fill-column: 74
11444version-control: never
11445coding: utf-8
11446End:
11447
GDB Binutils - Deliverables
This page took 0.075102 seconds and 4 git commands to generate.