jit: c++-ify gdb_block
[deliverable/binutils-gdb.git] / gdb / ChangeLog
... / ...
CommitLineData
12019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
2
3 * jit.c (struct gdb_block): Add constructor, initialize
4 real_block and next fields.
5 <name>: Change type to gdb::unique_xmalloc_ptr.
6 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
7 (jit_block_open_impl): Allocate gdb_block with new.
8 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
9
102019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
11
12 * jit.c: Include forward_list.
13 (struct gdb_symtab) <next>: Remove field.
14 (struct gdb_object) <symtabs>: Change type to
15 std::forward_list<gdb_symtab>.
16 (jit_object_open_impl): Allocate gdb_object with new.
17 (jit_symtab_open_impl): Adjust to std::forward_list.
18 (finalize_symtab): Don't delete symtab.
19 (jit_object_close_impl): Adjust to std::forward_list. Free
20 gdb_object with delete.
21
222019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
23
24 * jit.c (struct gdb_symtab): Add constructor, destructor,
25 initialize fields.
26 <linetable>: Change type to unique_xmalloc_ptr.
27 <file_name>: Change type to std::string.
28 (jit_symtab_open_impl): Allocate gdb_symtab with new.
29 (jit_symtab_line_mapping_add_impl): Adjust.
30 (finalize_symtab): Adjust, call delete on stab.
31
322019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
33
34 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
35
362019-12-16 Tom Tromey <tromey@adacore.com>
37
38 * windows-nat.c (windows_nat_target::attach): Update.
39 * remote.c (extended_remote_target::attach): Update.
40 * procfs.c (procfs_target::attach): Update.
41 * nto-procfs.c (nto_procfs_target::attach): Update.
42 (nto_procfs_target::create_inferior): Update.
43 * inf-ptrace.c (inf_ptrace_target::attach): Update.
44 * gnu-nat.c (gnu_nat_target::attach): Update.
45 (gnu_nat_target::detach): Update.
46 * darwin-nat.c (darwin_nat_target::attach): Update.
47 * corefile.c (get_exec_file): Constify result. Remove extraneous
48 return.
49 * bsd-kvm.c (bsd_kvm_target_open): Update.
50 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
51
522019-12-16 Christian Biesinger <cbiesinger@google.com>
53
54 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
55 (we no longer need to include time.h before pathmax.h)
56
572019-12-15 Christian Biesinger <cbiesinger@google.com>
58
59 * ada-exp.y (write_ambiguous_var): Update.
60 * coffread.c (process_coff_symbol): Update.
61 * ctfread.c (ctf_add_enum_member_cb): Update.
62 (new_symbol): Update.
63 * dwarf2read.c (fixup_go_packaging): Update.
64 (new_symbol): Update.
65 * language.c (language_alloc_type_symbol): Update.
66 * mdebugread.c (new_symbol): Update.
67 * minsyms.c (minimal_symbol_reader::record_full): Update.
68 * psymtab.c (add_psymbol_to_bcache): Update.
69 * stabsread.c (define_symbol): Update.
70 (read_enum_type): Update.
71 * symtab.c (symbol_set_language): Make this a member function...
72 (general_symbol_info::set_language): ... here.
73 * symtab.h (struct general_symbol_info) <set_language>: New function.
74 (SYMBOL_SET_LANGUAGE): Remove.
75 (symbol_set_language): Remove.
76
772019-12-15 Christian Biesinger <cbiesinger@google.com>
78
79 * ada-lang.c (ada_add_block_symbols): Update.
80 (ada_collect_symbol_completion_matches): Update.
81 * ax-gdb.c (gen_expr): Update.
82 * block.c (block_lookup_symbol): Update.
83 (block_lookup_symbol_primary): Update.
84 (block_find_symbol): Update.
85 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
86 * dbxread.c (process_one_symbol): Update.
87 * dictionary.c (insert_symbol_hashed): Update.
88 (collate_pending_symbols_by_language): Update.
89 (mdict_add_symbol): Update.
90 * dwarf-index-write.c (write_psymbols): Update.
91 * dwarf2read.c (fixup_go_packaging): Update.
92 * findvar.c (read_var_value): Update.
93 * ft32-tdep.c (ft32_skip_prologue): Update.
94 * go-lang.c (go_symbol_package_name): Update.
95 * language.h (scoped_switch_to_sym_language_if_auto::
96 scoped_switch_to_sym_language_if_auto): Update.
97 * linespec.c (find_method): Update.
98 (find_label_symbols_in_block): Update.
99 * mdebugread.c (parse_symbol): Update.
100 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
101 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
102 (minimal_symbol_reader::install): Update.
103 * moxie-tdep.c (moxie_skip_prologue): Update.
104 * parse.c (parse_exp_in_context): Update.
105 * psymtab.c (psymbol_name_matches): Update.
106 (match_partial_symbol): Update.
107 (lookup_partial_symbol): Update.
108 (psymbol_hash): Update.
109 (psymbol_compare): Update.
110 * python/py-framefilter.c (extract_sym): Update.
111 (py_print_single_arg): Update.
112 * stabsread.c (define_symbol): Update.
113 * stack.c (print_frame_arg): Update.
114 (find_frame_funname): Update.
115 (info_frame_command_core): Update.
116 * symfile.c (set_initial_language): Update.
117 * symtab.c (symbol_set_demangled_name): Update.
118 (symbol_get_demangled_name): Update.
119 (symbol_set_language): Update.
120 (symbol_find_demangled_name): Update.
121 (symbol_set_names): Update.
122 (general_symbol_info::natural_name): Update.
123 (general_symbol_info::demangled_name): Update.
124 (general_symbol_info::search_name): Update.
125 (symbol_matches_search_name): Update.
126 (eq_symbol_entry): Update.
127 (iterate_over_symbols): Update.
128 (completion_list_add_symbol): Update.
129 (completion_list_add_msymbol): Update.
130 (completion_list_add_fields): Update.
131 * symtab.h (struct general_symbol_info) <language>: New function.
132 <language>: Rename to...
133 <m_language>: ...this.
134 (SYMBOL_LANGUAGE): Remove.
135 (MSYMBOL_LANGUAGE): Remove.
136 (struct symbol) <ctor>: Update.
137 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
138
1392019-12-15 Christian Biesinger <cbiesinger@google.com>
140
141 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
142 set the language of sym.
143 * language.c (language_alloc_type_symbol): Likewise.
144
1452019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
146
147 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
148 PR gdb/23613
149 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
150 * corelow.c: Include 'gdbsupport/pathstuff.h'.
151 (core_target_open): Use 'gdb_abspath'.
152 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
153 'current_directory == NULL' case.
154 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
155 explain what happens when 'current_directory' is NULL.
156 * go32-nat.c (go32_nat_target::wait): Check if
157 'current_directory' is NULL before call to 'chdir'.
158 * source.c (add_path): Use 'gdb_abspath'.
159 * top.c: Include 'gdbsupport/pathstuff.h'.
160 (init_history): Use 'gdb_abspath'.
161 (set_history_filename): Likewise.
162 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
163 (tfile_target_open): Use 'gdb_abspath'.
164
1652019-12-13 Tom Tromey <tromey@adacore.com>
166
167 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
168 warning or error.
169
1702019-12-13 Tom Tromey <tromey@adacore.com>
171
172 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
173
1742019-12-13 Tom Tromey <tromey@adacore.com>
175
176 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
177
1782019-12-13 Tom Tromey <tromey@adacore.com>
179
180 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
181
1822019-12-13 Tom Tromey <tromey@adacore.com>
183
184 * gdbsupport/common-utils.c (string_printf, string_vprintf)
185 (string_vappendf): Add ARI comment.
186
1872019-12-13 Tom Tromey <tromey@adacore.com>
188
189 * contrib/ari/gdb_ari.sh: Remove "fix" call for
190 floatformat_to_double.
191 * target-float.c (host_float_ops<T>::from_target): Add ARI
192 comment.
193
1942019-12-13 Tom Tromey <tromey@adacore.com>
195
196 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
197 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
198 ARI marker to abort.
199 * event-top.c (handle_sigsegv): Add ARI marker to abort.
200
2012019-12-13 Tom Tromey <tromey@adacore.com>
202
203 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
204
2052019-12-13 Tom Tromey <tromey@adacore.com>
206
207 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
208
2092019-12-13 Tom Tromey <tromey@adacore.com>
210
211 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
212 checks.
213
2142019-12-13 Tom Tromey <tromey@adacore.com>
215
216 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
217 end>: No longer "const".
218
2192019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
220
221 * jit.c: Fix indentation, replace spaces with tabs where
222 applicable.
223
2242019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
225
226 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
227
2282019-12-12 Tom Tromey <tom@tromey.com>
229
230 * objfiles.h (struct objfile) <partial_symtabs>: Now a
231 unique_ptr.
232
2332019-12-12 Tom Tromey <tom@tromey.com>
234
235 * progspace.h (objfile_list): New typedef.
236 (class unwrapping_objfile_iterator)
237 (struct unwrapping_objfile_range): Newl
238 (struct program_space) <objfiles_range>: Change type.
239 <objfiles>: Change return type.
240 <add_objfile>: Change type of "objfile" parameter.
241 <objfiles_list>: Now a list of shared_ptr.
242 * progspace.c (program_space::add_objfile): Change type of
243 "objfile". Update.
244 (program_space::remove_objfile): Update.
245 * objfiles.h (struct objfile) <~objfile>: Make public.
246 * objfiles.c (objfile::make): Update.
247 (objfile::unlink): Don't call delete.
248
2492019-12-12 Tom Tromey <tom@tromey.com>
250
251 * symfile.c (symbol_file_clear): Update.
252 * progspace.h (struct program_space) <free_all_objfiles>: Declare
253 method.
254 * progspace.c (program_space::free_all_objfiles): New method.
255 * objfiles.h (free_all_objfiles): Don't declare.
256 * objfiles.c (free_all_objfiles): Move to program_space.
257
2582019-12-12 Tom Tromey <tom@tromey.com>
259
260 * progspace.c (program_space::add_objfile)
261 (program_space::remove_objfile): Update.
262 (program_space::multi_objfile_p): Remove.
263 * objfiles.h (struct objfile) <next>: Remove.
264 * objfiles.c (objfile::objfile): Update.
265 (put_objfile_before): Update.
266 (unlink_objfile): Update.
267 * progspace.h (object_files): Remove.
268 (struct program_space) <objfiles_head>: Remove.
269 <objfiles_list>: New member.
270 <objfiles_range, objfiles_safe_range>: Change type.
271 (objfiles): Change return type.
272 (objfiles_safe): Update.
273 (multi_objfile_p): Rewrite and inline.
274 (object_files): Remove macro.
275
2762019-12-12 Tom Tromey <tom@tromey.com>
277
278 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
279 second constructor.
280 (basic_safe_range): New class.
281
2822019-12-12 Tom Tromey <tom@tromey.com>
283
284 * progspace.c (program_space::multi_objfile_p): New method.
285 * printcmd.c (info_symbol_command): Update.
286 * maint.c (maintenance_translate_address): Update.
287 * objfiles.h (MULTI_OBJFILE_P): Remove.
288 * progspace.h (struct program_space) <multi_objfile_p>: New
289 method.
290
2912019-12-12 Tom Tromey <tom@tromey.com>
292
293 * progspace.h (struct program_space) <remove_objfile>: Declare.
294 * progspace.c (program_space::remove_objfile): New method.
295 * objfiles.c (unlink_objfile): Remove.
296 (objfile::unlink): Call remove_objfile.
297 (objfile): Don't call unlink_objfile.
298
2992019-12-12 Tom Tromey <tom@tromey.com>
300
301 * progspace.h (struct program_space) <add_objfile>: Declare
302 method.
303 * progspace.c (program_space::add_objfile): New method.
304 * objfiles.c (~objfile): Don't unlink objfile.
305 (put_objfile_before): Remove.
306 (add_separate_debug_objfile): Don't call put_objfile_before.
307 (objfile::make): Call add_objfile. Set new_objfiles_available on
308 the per-program-space data.
309
3102019-12-12 Tom Tromey <tom@tromey.com>
311
312 * symfile.c (syms_from_objfile_1): Use objfile_up.
313 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
314 method.
315 (reread_symbols): Use objfile_up.
316 * solib.c (update_solib_list, reload_shared_libraries_1): Call
317 unlink method.
318 * objfiles.h (struct objfile) <~objfile>: Now private.
319 <unlink>: New method.
320 (struct objfile_deleter): New.
321 (objfile_up): New typedef.
322 * objfiles.c (objfile::unlink): New method.
323 (free_objfile_separate_debug, free_all_objfiles)
324 (objfile_purge_solibs): Use it.
325 * jit.c (jit_unregister_code): Remove.
326 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
327 objfile.
328 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
329 objfile.
330 * compile/compile-object-load.c (compile_object_load): Use
331 objfile_up.
332
3332019-12-12 Tom Tromey <tom@tromey.com>
334
335 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
336 objfile::make.
337 * objfiles.h (struct objjfile) <make>: No longer inline.
338 (add_separate_debug_objfile): Don't declare.
339 * objfiles.c (add_separate_debug_objfile): Now static.
340 (objfile::make): Move from objfiles.h. Call
341 add_separate_debug_objfile. Add "parent" parameter.
342
3432019-12-12 Tom Tromey <tom@tromey.com>
344
345 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
346 * objfiles.h (struct objfile): Make constructor private.
347 <make>: New static method.
348 * jit.c (jit_object_close_impl): Update.
349
3502019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
351
352 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
353 gdb::byte_vector.
354
3552019-12-12 Tom Tromey <tromey@adacore.com>
356
357 * xml-support.c (xml_fetch_content_from_file): Don't call
358 malloc_failure.
359 * utils.h (class gdb_argv): Remove malloc_failure comment.
360 * utils.c (gdb_argv::reset): Don't call malloc_failure.
361
3622019-12-12 Tom Tromey <tromey@adacore.com>
363
364 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
365 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
366 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
367 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
368 * riscv-ravenscar-thread.c: New file.
369 * riscv-ravenscar-thread.h: New file.
370 * riscv-tdep.c (riscv_gdbarch_init): Call
371 register_riscv_ravenscar_ops.
372
3732019-12-12 Tom Tromey <tromey@adacore.com>
374
375 * gdbsupport/thread-pool.c (set_thread_name): Use
376 ATTRIBUTE_UNUSED.
377
3782019-12-12 Luis Machado <luis.machado@linaro.org>
379
380 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
381 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
382 macros.
383
3842019-12-11 Tom Tromey <tom@tromey.com>
385
386 * tui/tui-win.c (tui_set_win_height_command): Call
387 tui_adjust_window_height.
388 (tui_adjust_win_heights, new_height_ok): Remove.
389 * tui/tui-layout.h (tui_adjust_window_height): Declare.
390 * tui/tui-layout.c (tui_adjust_window_height): New function.
391
3922019-12-11 Tom Tromey <tom@tromey.com>
393
394 * tui/tui-win.c (tui_resize_all): Remove code, call
395 tui_apply_current_layout.
396
3972019-12-11 Tom Tromey <tom@tromey.com>
398
399 * tui/tui-layout.h (tui_apply_current_layout): Declare.
400 * tui/tui-layout.c (standard_layouts, applied_layout): New
401 globals.
402 (tui_apply_current_layout): New function.
403 (show_layout): Set applied_layout. Call
404 tui_apply_current_layout.
405 (show_source_command, show_disasm_command)
406 (show_source_disasm_command, show_data)
407 (show_source_or_disasm_and_command): Remove.
408 (initialize_layouts): New function.
409 (_initialize_tui_layout): Call initialize_layouts.
410
4112019-12-11 Tom Tromey <tom@tromey.com>
412
413 * tui/tui-layout.h (class tui_layout_base)
414 (class tui_layout_window, class tui_layout_split): New.
415 * tui/tui-layout.c (tui_get_window_by_name)
416 (tui_layout_window::clone, tui_layout_window::apply)
417 (tui_layout_window::get_sizes, tui_layout_window::add_split)
418 (tui_layout_split::add_window, tui_layout_split::clone)
419 (tui_layout_split::get_sizes)
420 (tui_layout_split::set_weights_from_heights)
421 (tui_layout_split::adjust_size, tui_layout_split::apply): New
422 functions.
423 (tui_layout_split::add_split, tui_layout_split::add_split)
424 (tui_layout_split::set_weights_from_heights)
425 (tui_layout_split::set_weights_from_heights): New functions.
426
4272019-12-11 Tom Tromey <tom@tromey.com>
428
429 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
430 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
431 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
432 * tui/tui-data.h (struct tui_point): Remove.
433 (struct tui_gen_win_info) <origin>: Remove.
434 <x, y>: New fields.
435 * tui/tui-command.c (tui_cmd_window::resize): Update.
436
4372019-12-11 Tom Tromey <tom@tromey.com>
438
439 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
440 Implement.
441 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
442 Implement.
443 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
444 method.
445 (struct tui_win_info) <min_height>: Implement.
446
4472019-12-11 Tom Tromey <tom@tromey.com>
448
449 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
450 (struct tui_win_info) <can_box>: Update.
451
4522019-12-11 Tom Tromey <tom@tromey.com>
453
454 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
455 method.
456 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
457 method.
458 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
459 method.
460 (struct tui_win_info) <max_height>: Now override.
461
4622019-12-11 Joel Brobecker <brobecker@adacore.com>
463
464 * NEWS: Create a new section for the next release branch.
465 Rename the section of the current branch, now that it has
466 been cut.
467
4682019-12-11 Joel Brobecker <brobecker@adacore.com>
469
470 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
471 * version.in: Bump version to 10.0.50.DATE-git.
472
4732019-12-11 Tom Tromey <tromey@adacore.com>
474
475 PR build/25268:
476 * gdbsupport/thread-pool.c (set_thread_name): New function.
477 (thread_pool::set_thread_count): Don't call pthread_setname_np.
478 (thread_pool::thread_function): Call set_thread_name.
479
4802019-12-11 Tom Tromey <tromey@adacore.com>
481
482 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
483 bfd_get_signed_8.
484
4852019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
486
487 * NEWS: Document -raw-values option and the related setting commands.
488 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
489 only set it on when /r is given.
490 * valprint.c (value_print_option_defs): New element raw-values.
491 * Makefile.in: Add the new file.
492
4932019-12-10 Christian Biesinger <cbiesinger@google.com>
494
495 * gdbsupport/safe-strerror.c: Supress the unused function warning
496 for select_strerror_r.
497
4982019-12-10 Christian Biesinger <cbiesinger@google.com>
499
500 * config.in: Regenerate.
501 * configure: Regenerate.
502 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
503 safe_strerror instead of strerror.
504 * gdbsupport/common.m4: Don't check for strerror.
505 * gdbsupport/safe-strerror.c: Support both the glibc version
506 of strerror_r and the XSI version.
507
5082019-12-10 Tom Tromey <tromey@adacore.com>
509
510 * ada-typeprint.c (print_choices): Use a single "?".
511 (print_variant_part): Print "?" if the discriminant name
512 is not known.
513
5142019-12-10 George Barrett <bob@bob131.so>
515
516 Fix scripted probe breakpoints.
517 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
518 declaration forward.
519 (breakpoint_ops_for_event_location_type)
520 (breakpoint_ops_for_event_location): Add function definitions.
521 (break_command_1, trace_command): Use
522 breakpoint_ops_for_event_location.
523 * breakpoint.h (breakpoint_ops_for_event_location): Add function
524 declarations.
525 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
526 breakpoint_ops_for_event_location.
527 * python/py-breakpoint.c (bppy_init): Use
528 breakpoint_ops_for_event_location.
529
5302019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
531
532 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
533 when ranking an lvalue argument for an rvalue parameter.
534
5352019-12-08 Wataru Ashihara <wataash@wataash.com>
536
537 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
538 template argument for scoped_restore_tmpl from bool to int.
539
5402019-12-07 Keith Seitz <keiths@redhat.com>
541
542 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
543 (build_id_to_debug_bfd): Make static, rewriting to use
544 build_id_to_bfd_suffix.
545 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
546 adding `suffix' parameter. Append SUFFIX to file names
547 when searching for matching files.
548 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
549 (build_id_to_exec_bfd): Likewise.
550 * build-id.h (build_id_to_debug_bfd): Clarify that function
551 searches for BFD of debug info file.
552 (build_id_to_exec_bfd): Declare.
553 * corelow.c: Include build-id.h.
554 (locate_exec_from_corefile_build_id): New function.
555 (core_target_open): If no executable BFD is found,
556 search for a core file BFD using build-id.
557
5582019-12-06 Christian Biesinger <cbiesinger@google.com>
559
560 * bcache.c: Put in namespace gdb.
561 * bcache.h: Likewise.
562 * gdbtypes.c (check_types_worklist): Update.
563 (types_deeply_equal): Update.
564 * macrotab.c (struct macro_table) <bcache>: Update.
565 (new_macro_table): Update.
566 * macrotab.h (struct bcache): Put this forward declaration
567 inside namespace gdb.
568 (new_macro_table): Update.
569 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
570 Update.
571 <macro_cache>: Update.
572 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
573
5742019-12-06 Tom de Vries <tdevries@suse.de>
575
576 PR symtab/24971
577 * block.c (best_symbol, better_symbol): New function.
578 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
579 decl.
580
5812019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
582
583 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
584 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
585 for ranking see-through reference cases.
586
5872019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
588 * stack.c (faas_command): Check a command is provided.
589 * thread.c (taas_command, tfaas_command): Likewise.
590
5912019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
592 * inferior.c (prune_inferiors): Only call delete_inferior,
593 Do not modify the inferior list.
594
5952019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
596
597 * c-exp.y: Update calls to lookup_typename,
598 lookup_signed_typename and lookup_unsigned_typename.
599 * c-lang.c (evaluate_subexp_c): Likewise.
600 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
601 Likewise.
602 * eval.c (binop_promote): Likewise.
603 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
604 (lookup_unsigned_typename): Likewise.
605 (lookup_signed_typename): Likewise.
606 * gdbtypes.h (lookup_unsigned_typename): Likewise.
607 (lookup_signed_typename): Likewise.
608 (lookup_typename): Likewise.
609 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
610 lookup_typename, lookup_signed_typename,
611 lookup_unsigned_typename.
612 * m2-exp.y: Likewise.
613 * printcmd.c (printf_wide_c_string): Likewise.
614 (ui_printf): Likewise.
615 * python/py-type.c (typy_lookup_typename): Likewise.
616 * python/py-xmethods.c (python_xmethod_worker::invoke):
617 Likewise.
618 * rust-exp.y: Likewise.
619
6202019-12-04 Christian Biesinger <cbiesinger@google.com>
621
622 * configure.nat (obsd64): Add missing files x86-nat.o and
623 nat/x86-dregs.o.
624
6252019-12-04 Tom Tromey <tom@tromey.com>
626
627 * valprint.c (val_print_string): Use metadata_style.
628 * go-valprint.c (print_go_string): Use metadata style.
629 * p-valprint.c (pascal_object_print_static_field): Use metadata
630 style.
631 * cp-valprint.c (cp_print_static_field): Use metadata style.
632
6332019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
634 Chris January <chris.january@arm.com>
635
636 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
637 tokens.
638 (typebase): New patterns for complex, single/double precision, and
639 single/double complex.
640 (f77_keywords): Change token for complex keyword, and add single,
641 double, and precision keywords.
642
6432019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
644
645 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
646 "info io_registers".
647
6482019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
649
650 * regcache.c (cooked_read_test): Initialize thread list of
651 mock_inferior.
652
6532019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
654
655 * aarch64-linux-tdep.c: Remove includes.
656
6572019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
658
659 * aarch64-tdep.c: Remove includes.
660
6612019-12-04 Simon Marchi <simon.marchi@efficios.com>
662
663 * filtered-iterator.h (filtered_iterator) <operator==,
664 operator!=>: Compare wrapped iterators, not wrapped pointers.
665 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
666 unittests/filtered_iterator-selftests.c.
667 * unittests/filtered_iterator-selftests.c: New file.
668
6692019-12-04 Tom Tromey <tromey@adacore.com>
670
671 * gdbtypes.c (create_range_type): Inherit endianity
672 from base type.
673
6742019-12-04 Tom Tromey <tromey@adacore.com>
675
676 * ada-lang.c (decode_constrained_packed_array)
677 (ada_value_assign, value_assign_to_component): Update.
678 * dwarf2loc.c (rw_pieced_value, access_memory)
679 (dwarf2_compile_expr_to_ax): Update.
680 * dwarf2read.c (dwarf2_add_field): Update.
681 * eval.c (evaluate_subexp_standard): Update.
682 * gdbarch.c, gdbarch.h: Rebuild.
683 * gdbarch.sh (bits_big_endian): Remove.
684 * gdbtypes.h (union field_location): Update comment.
685 * target-descriptions.c (make_gdb_type): Update.
686 * valarith.c (value_bit_index): Update.
687 * value.c (struct value) <bitpos>: Update comment.
688 (unpack_bits_as_long, modify_field): Update.
689 * value.h (value_bitpos): Update comment.
690
6912019-12-04 Tom Tromey <tromey@adacore.com>
692
693 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
694 endian-ness.
695
6962019-12-04 Tom Tromey <tromey@adacore.com>
697
698 * dwarf2read.c (dwarf2_init_float_type)
699 (dwarf2_init_complex_target_type): Add byte_order parameter.
700 (read_base_type): Compute byte order earlier.
701 * gdbtypes.c (init_float_type): Add byte_order parameter.
702 * gdbtypes.h (init_float_type): Add byte_order parameter.
703
7042019-12-04 Tom Tromey <tromey@adacore.com>
705
706 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
707
7082019-12-04 Tom Tromey <tromey@adacore.com>
709
710 * dwarf2read.c (process_structure_scope): Initialize
711 "discr_offset".
712
7132019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
714
715 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
716 add it into the search spec.
717 (parse_max_results_option): New function.
718 (mi_info_functions_or_variables): Parse -max-results flag and pass
719 it to mi_symbol_info.
720 (mi_cmd_symbol_info_modules): Likewise.
721 (mi_cmd_symbol_info_types): Likewise.
722 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
723 return type to bool, change result container into a set, and don't
724 add new results if we have enough already.
725 (global_symbol_searcher::add_matching_msymbols): Change return
726 type to bool, and don't add new results if we have enough already.
727 (sort_search_symbols_remove_dups): Delete.
728 (global_symbol_searcher::search): Early exit from search loop when
729 we have enough results. Use a std::set to collect the results
730 from calling add_matching_symbols.
731 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
732 member function.
733 (global_symbol_searcher) <m_max_search_results>: New member
734 variable.
735 (global_symbol_searcher) <add_matching_symbols>: Update header
736 comment and change return type to bool.
737 (global_symbol_searcher) <add_matching_msymbols>: Update header
738 comment and change return type to bool.
739
7402019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
741
742 * symtab.c (symbol_search::compare_search_syms): Update header
743 comment.
744 (global_symbol_searcher::is_suitable_msymbol): New function.
745 (global_symbol_searcher::expand_symtabs): New function.
746 (global_symbol_searcher::add_matching_symbols): New function.
747 (global_symbol_searcher::add_matching_msymbols): New function.
748 (global_symbol_searcher::search): Move most of the content
749 into the new functions above, and call them as needed.
750 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
751 function.
752 (global_symbol_searcher) <add_matching_symbols>: New member
753 function.
754 (global_symbol_searcher) <add_matching_msymbols>: New member
755 function.
756 (global_symbol_searcher) <is_suitable_msymbol>: New member
757 function.
758
7592019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
760
761 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
762 -symbol-info-module-variables entries.
763 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
764 (mi_cmd_symbol_info_module_variables): Declare.
765 * mi/mi-symbol-cmds.c
766 (module_symbol_search_iterator): New typedef.
767 (output_module_symbols_in_single_module_and_file): New function.
768 (output_module_symbols_in_single_module): New function.
769 (mi_info_module_functions_or_variables): New function.
770 (mi_cmd_symbol_info_module_functions): New function.
771 (mi_cmd_symbol_info_module_variables): New function.
772 * NEWS: Mention new MI command.
773
7742019-12-03 Christian Biesinger <cbiesinger@google.com>
775
776 * bcache.c (hash): Remove.
777 (hash_continue): Remove.
778 * bcache.h (hash): Remove.
779 (hash_continue): Remove.
780 (struct bcache) <ctor>: Update.
781 * psymtab.c (psymbol_hash): Update.
782 * stabsread.c (hashname): Update.
783 * utils.h (fast_hash): Add an argument for a start value,
784 defaulting to zero.
785
7862019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
787 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
788 (destroy_block_symbol_cache): New function.
789 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
790 (resize_symbol_cache): Likewise.
791
7922019-12-02 Tom Tromey <tom@tromey.com>
793
794 * unittests/tui-selftests.c (run_tests): Make conditional.
795 (_initialize_tui_selftest): Make conditional.
796
7972019-12-02 Christian Biesinger <cbiesinger@google.com>
798
799 * aix-thread.c (debug_aix_thread): Change type to bool.
800
8012019-12-02 Luis Machado <luis.machado@linaro.org>
802
803 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
804
8052019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
806
807 * dwarf2read.c (read_tag_string_type): Read the fields required to
808 make a dynamic string, and possibly create a dynamic range for the
809 string.
810 (attr_to_dynamic_prop): Setup is_reference based on the type of
811 attribute being processed.
812 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
813 (resolve_dynamic_array): Rename to...
814 (resolve_dynamic_array_or_string): ...this, update header comment,
815 and accept TYPE_CODE_STRING.
816 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
817
8182019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
819
820 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
821 of its implementation from...
822 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
823 the new function.
824
8252019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
826
827 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
828 create a range with stride where appropriate.
829 * f-valprint.c: Include 'gdbarch.h'.
830 (f77_print_array_1): Take the stride into account when walking the
831 array. Also convert the stride into addressable units.
832 * gdbtypes.c (create_range_type): Initialise the stride to
833 constant zero.
834 (create_range_type_with_stride): New function, initialise the
835 range as normal, and then setup the stride.
836 (has_static_range): Include the stride here. Also change the
837 return type to bool.
838 (create_array_type_with_stride): Consider the range stride if the
839 array isn't given its own stride.
840 (resolve_dynamic_range): Resolve the stride if needed.
841 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
842 (struct range_bounds) <flag_is_byte_stride>: New member variable.
843 (TYPE_BIT_STRIDE): Define.
844 (TYPE_ARRAY_BIT_STRIDE): Define.
845 (create_range_type_with_stride): Declare.
846 * valarith.c (value_subscripted_rvalue): Take range stride into
847 account when walking the array.
848
8492019-12-01 Tom Tromey <tom@tromey.com>
850
851 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
852 specially.
853
8542019-12-01 Tom Tromey <tom@tromey.com>
855
856 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
857 \0.
858 * unittests/tui-selftests.c: New file.
859 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
860
8612019-12-01 Tom Tromey <tom@tromey.com>
862
863 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
864
8652019-12-01 Tom Tromey <tom@tromey.com>
866
867 * NEWS: Document new settings.
868 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
869 * tui/tui-win.c (_initialize_tui_win): Add border style
870 observers.
871 * tui/tui-io.h (tui_apply_style): Declare.
872 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
873 longer static.
874 (apply_ansi_escape, tui_set_reverse_mode): Update.
875 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
876 Add "skip_intensity" parameter.
877 <changed>: New member.
878 <do_set_value>: Declare.
879 (tui_border_style, tui_active_border_style): Declare.
880 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
881 globals.
882 (cli_style_option): Initialize "changed".
883 (cli_style_option::do_set_value): New function.
884 (cli_style_option::add_setshow_commands): Add "skip_intensity"
885 parameter. Update.
886 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
887 (_initialize_cli_style): Update. Create TUI border style
888 commands.
889
8902019-12-01 Tom Tromey <tom@tromey.com>
891
892 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
893 parameter.
894 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
895 parameter.
896 * tui/tui-win.h (compact_source): Declare.
897 * tui/tui-win.c (compact_source): New global.
898 (tui_set_compact_source, tui_show_compact_source): New functions.
899 (_initialize_tui_win): Add "compact-source" setting.
900 * tui/tui-source.c (tui_source_window::set_contents): Handle
901 compact_source setting.
902 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
903 * NEWS: Document new setting.
904
9052019-11-30 Tom Tromey <tom@tromey.com>
906
907 * dwarf2read.c (dwarf2_add_field): Include field offset when
908 computing variant part length.
909
9102019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
911 * NEWS: Mention define-prefix. Tell that command names can now
912 contain a . character.
913
9142019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
915
916 * command.h (valid_cmd_char_p): Declare.
917 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
918 the check of valid command char.
919 (find_command_name_length, valid_user_defined_cmd_name_p): Use
920 valid_cmd_char_p.
921 * cli/cli-script.c (validate_comname): Likewise.
922 * completer.c (gdb_completer_command_word_break_characters):
923 Do not remove . from the word break char, update comments.
924 (complete_line_internal_1): Use valid_cmd_char_p.
925 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
926 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
927
9282019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
929
930 * cli/cli-script.c (do_define_command): Ensure a redefined
931 prefix command is kept as a prefix command.
932 (define_prefix_command): New function.
933 (show_user_1): Report user defined prefixes.
934 (_initialize_cli_script): Create the new 'define-prefix' command.
935 Add completers for 'define' and 'document'.
936 * top.c (execute_command): If command is a user-defined prefix only
937 command, report the list of commands for this prefix command.
938
9392019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
940
941 * valops.c (find_oload_champ): Improve debug output.
942
9432019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
944
945 * valops.c (find_oload_champ): Print part of debug messages
946 before the badness vector is std::move'd.
947
9482019-11-28 Tom Tromey <tom@tromey.com>
949
950 * value.c (creal_internal_fn): Fix comment.
951
9522019-11-28 Tom Tromey <tom@tromey.com>
953
954 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
955 flag_bound_evaluated>: Now unsigned.
956
9572019-11-28 Tom Tromey <tom@tromey.com>
958
959 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
960 declare.
961
9622019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
963
964 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
965 debug output.
966 * jit.c (jit_unregister_code): Add debug print to match
967 `jit_register_code`.
968
9692019-11-27 Christian Biesinger <cbiesinger@google.com>
970
971 * NEWS: Mention the new multithreaded symbol loading.
972
9732019-11-27 Christian Biesinger <cbiesinger@google.com>
974
975 * maint.c (n_worker_threads): Default to 0.
976 (worker_threads_disabled): New function.
977 * maint.h (worker_threads_disabled): New function.
978 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
979 here if worker_threads_disabled () is true.
980 (minimal_symbol_reader::install): Skip all threading if
981 worker_threads_disabled () is true.
982
9832019-11-27 Christian Biesinger <cbiesinger@google.com>
984
985 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
986 hash code if possible.
987 (add_minsym_to_demangled_hash_table): Likewise.
988 (minimal_symbol_reader::install): Compute the hash codes for msymbol
989 on the background thread.
990 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
991 Add these fields.
992
9932019-11-27 Christian Biesinger <cbiesinger@google.com>
994
995 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
996 of the mangled name on the background thread.
997 * symtab.c (symbol_set_names): Allow passing in the hash of the
998 linkage_name.
999 * symtab.h (symbol_set_names): Likewise.
1000
10012019-11-27 Kevin Buettner <kevinb@redhat.com>
1002
1003 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1004 physnames are computed for inherited DIEs.
1005
10062019-11-27 Tom Tromey <tromey@adacore.com>
1007
1008 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1009 backslashes.
1010 * cp-support.c: Remove unnecessary backslashes.
1011
10122019-11-27 Christian Biesinger <cbiesinger@google.com>
1013
1014 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1015 with sym->set_linkage_name.
1016 * coffread.c (coff_read_enum_type): Likewise.
1017 * mdebugread.c (parse_symbol): Likewise.
1018 * stabsread.c (patch_block_stabs): Likewise.
1019 (define_symbol): Likewise.
1020 (read_enum_type): Likewise.
1021 (common_block_end): Likewise.
1022 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1023 function.
1024 (SYMBOL_SET_LINKAGE_NAME): Remove.
1025 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1026 with sym->set_linkage_name.
1027
10282019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1029
1030 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1031 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1032 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1033 * NEWS: Mention new MI command.
1034
10352019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1036
1037 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1038 '-symbol-info-types', and '-symbol-info-variables'.
1039 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1040 (mi_cmd_symbol_info_types): Declare.
1041 (mi_cmd_symbol_info_variables): Declare.
1042 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1043 (output_debug_symbol): New function.
1044 (output_nondebug_symbol): New function.
1045 (mi_symbol_info): New function.
1046 (mi_info_functions_or_variables): New function.
1047 (mi_cmd_symbol_info_functions): New function.
1048 (mi_cmd_symbol_info_types): New function.
1049 (mi_cmd_symbol_info_variables): New function.
1050 * NEWS: Mention new commands.
1051
10522019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1053
1054 * symtab.c (symbol_to_info_string): New function, most content
1055 moved from print_symbol_info, but updated to return a std::string.
1056 (print_symbol_info): Update to use symbol_to_info_string and print
1057 returned string.
1058 * symtab.h (symbol_to_info_string): Declare new function.
1059
10602019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1061
1062 * python/python.c (gdbpy_rbreak): Convert to using
1063 global_symbol_searcher.
1064 * symtab.c (file_matches): Convert return type to bool, change
1065 file list to std::vector, update header comment.
1066 (search_symbols): Rename to...
1067 (global_symbol_searcher::search): ...this and update now its
1068 a member function of global_symbol_searcher. Take account of the
1069 changes to file_matches.
1070 (symtab_symbol_info): Convert to using global_symbol_searcher.
1071 (rbreak_command): Likewise.
1072 (search_module_symbols): Likewise.
1073 * symtab.h (enum symbol_search): Update comment.
1074 (search_symbols): Remove declaration.
1075 (class global_symbol_searcher): New class.
1076
10772019-11-26 Tom Tromey <tromey@adacore.com>
1078
1079 * cp-support.c (_initialize_cp_support): Conditionally initialize
1080 gdb_demangle_attempt_core_dump.
1081
10822019-11-26 Tom Tromey <tom@tromey.com>
1083
1084 * python/py-function.c (fnpy_init): Update.
1085 * value.h (add_internal_function): Adjust declaration.
1086 * value.c (function_destroyer): Remove.
1087 (do_add_internal_function): Don't set destroyer or copy name.
1088 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1089 Set name_allocated.
1090 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1091 (cmdpy_init): Set name_allocated.
1092 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1093 member.
1094 (~cmd_list_element): Free "name" if needed.
1095
10962019-11-26 Tom Tromey <tom@tromey.com>
1097
1098 * value.h (add_internal_function): Add new overload. Move
1099 documentation from value.h.
1100 * value.c (do_add_internal_function): New function.
1101 (add_internal_function): Use it. Add new overload.
1102 (function_destroyer): Don't free doc.
1103 * python/py-function.c (fnpy_init): Update.
1104
11052019-11-26 Tom Tromey <tom@tromey.com>
1106
1107 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1108 (cmdpy_init): Set "doc_allocated".
1109
11102019-11-26 Tom Tromey <tom@tromey.com>
1111
1112 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1113 name of worker thread.
1114 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1115 pthread_setname_np.
1116 * configure, config.in: Rebuild.
1117
11182019-11-26 Tom Tromey <tom@tromey.com>
1119
1120 * python/python.c (class gdbpy_gil): New.
1121 (struct gdbpy_event): Add constructor, destructor, operator().
1122 (gdbpy_post_event): Use run_on_main_thread.
1123 (gdbpy_initialize_events): Remove.
1124 (do_start_initialization): Update.
1125
11262019-11-26 Tom Tromey <tom@tromey.com>
1127
1128 * NEWS: Add entry.
1129 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1130 commands. Call update_thread_pool_size.
1131 (update_thread_pool_size, maintenance_set_worker_threads): New
1132 functions.
1133 (n_worker_threads): New global.
1134
11352019-11-26 Christian Biesinger <cbiesinger@google.com>
1136 Tom Tromey <tom@tromey.com>
1137
1138 * minsyms.c (minimal_symbol_reader::install): Use
1139 parallel_for_each.
1140 * gdbsupport/parallel-for.h: New file.
1141 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1142
11432019-11-26 Christian Biesinger <cbiesinger@google.com>
1144 Tom Tromey <tom@tromey.com>
1145
1146 * gdbsupport/thread-pool.h: New file.
1147 * gdbsupport/thread-pool.c: New file.
1148 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1149 (HFILES_NO_SRCDIR): Add thread-pool.h.
1150
11512019-11-26 Tom Tromey <tom@tromey.com>
1152
1153 * event-top.h (thread_local_segv_handler): Declare.
1154 * event-top.c (thread_local_segv_handler): New global.
1155 (install_handle_sigsegv, handle_sigsegv): New functions.
1156 (async_init_signals): Install SIGSEGV handler.
1157 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1158 thread-local.
1159 (report_failed_demangle): New function.
1160 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1161 handler-setting code, instead use segv_handler. Run warning code
1162 on main thread.
1163
11642019-11-26 Tom Tromey <tom@tromey.com>
1165
1166 * run-on-main-thread.c: New file.
1167 * run-on-main-thread.h: New file.
1168 * unittests/main-thread-selftests.c: New file.
1169 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1170 main-thread-selftests.c.
1171 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1172 (COMMON_SFILES): Add run-on-main-thread.c.
1173
11742019-11-26 Tom Tromey <tom@tromey.com>
1175
1176 * main.c (setup_alternate_signal_stack): Remove.
1177 (captured_main_1): Use gdb::alternate_signal_stack.
1178 * gdbsupport/alt-stack.h: New file.
1179
11802019-11-26 Tom Tromey <tom@tromey.com>
1181
1182 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1183 Remove comment.
1184 (save_original_signals_state, restore_original_signals_state): Use
1185 gdb_sigmask.
1186 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1187 (_initialize_linux_nat): Use gdb_sigmask.
1188 * guile/guile.c (_initialize_guile): Use block_signals.
1189 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1190 * gdbsupport/gdb-sigmask.h: New file.
1191 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1192 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1193 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1194 pthread_sigmask.
1195 * configure, config.in: Rebuild.
1196 * gdbsupport/block-signals.h: New file.
1197
11982019-11-26 Tom Tromey <tom@tromey.com>
1199
1200 * acinclude.m4: Include ax_pthread.m4.
1201 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1202 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1203 (CLIBS): Use PTHREAD_LIBS.
1204 (aclocal_m4_deps): Add ax_pthread.m4.
1205 * config.in, configure: Rebuild.
1206 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1207
12082019-11-26 Tom Tromey <tom@tromey.com>
1209
1210 * symtab.h (struct minimal_symbol) <name_set>: New member.
1211 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1212 Don't call symbol_set_names.
1213 (minimal_symbol_reader::install): Call symbol_set_names.
1214
12152019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1216
1217 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1218 restore_active_ext_lang, as GIL is needed for (indirectly)
1219 called PyOS_InterruptOccurred.
1220
12212019-11-26 Simon Marchi <simon.marchi@efficios.com>
1222
1223 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1224 definition.
1225
12262019-11-26 Simon Marchi <simon.marchi@efficios.com>
1227
1228 * remote-sim.c (simulator_command): Make static, remove
1229 declaration.
1230
12312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1232
1233 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1234 static.
1235 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1236 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1237 (main): Likewise.
1238 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1239 (main): Likewise.
1240 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1241 (main): Likewise.
1242 * unittests/basic_string_view/element_access/char/1.cc (test01):
1243 Likewise.
1244 (main): Likewise.
1245 * unittests/basic_string_view/element_access/char/empty.cc (main):
1246 Likewise.
1247 * unittests/basic_string_view/element_access/char/front_back.cc
1248 (test01): Likewise.
1249 (main): Likewise.
1250 * unittests/basic_string_view/inserters/char/2.cc (test05):
1251 Likewise.
1252 (main): Likewise.
1253 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1254 (test01): Likewise.
1255 (main): Likewise.
1256 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1257 (test01): Likewise.
1258 (main): Likewise.
1259 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1260 Likewise.
1261 * unittests/basic_string_view/operations/compare/char/1.cc
1262 (test01): Likewise.
1263 (main): Likewise.
1264 * unittests/basic_string_view/operations/compare/char/13650.cc
1265 (test01): Likewise.
1266 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1267 Likewise.
1268 (main): Likewise.
1269 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1270 Likewise.
1271 (main): Likewise.
1272 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1273 Likewise.
1274 (main): Likewise.
1275 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1276 Likewise.
1277 (main): Likewise.
1278 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1279 Likewise.
1280 (main): Likewise.
1281 * unittests/basic_string_view/operations/find/char/4.cc (main):
1282 Likewise.
1283 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1284 Likewise.
1285 (main): Likewise.
1286 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1287 Likewise.
1288 (main): Likewise.
1289 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1290 Likewise.
1291 (main): Likewise.
1292 * unittests/basic_string_view/operations/substr/char/1.cc
1293 (test01): Likewise.
1294 (main): Likewise.
1295 * unittests/basic_string_view/operators/char/2.cc (main):
1296 Likewise.
1297 * unittests/optional/assignment/1.cc (test): Likewise.
1298 * unittests/optional/assignment/2.cc (test): Likewise.
1299 * unittests/optional/assignment/3.cc (test): Likewise.
1300 * unittests/optional/assignment/4.cc (test): Likewise.
1301 * unittests/optional/assignment/5.cc (test): Likewise.
1302 * unittests/optional/assignment/6.cc (test): Likewise.
1303 * unittests/optional/assignment/7.cc (test): Likewise.
1304 * unittests/optional/cons/copy.cc (test): Likewise.
1305 * unittests/optional/cons/default.cc (test): Likewise.
1306 * unittests/optional/cons/move.cc (test): Likewise.
1307 * unittests/optional/cons/value.cc (test): Likewise.
1308 * unittests/optional/in_place.cc (test): Likewise.
1309 * unittests/optional/observers/1.cc (test): Likewise.
1310 * unittests/optional/observers/2.cc (test): Likewise.
1311
13122019-11-26 Simon Marchi <simon.marchi@efficios.com>
1313
1314 * tui-win.h (tui_set_var_cmd): Remove.
1315 * tui-win.c (tui_set_var_cmd): Make static.
1316
13172019-11-26 Simon Marchi <simon.marchi@efficios.com>
1318
1319 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1320 rbreak_command_wrapper): Remove.
1321 * symtab.c (rbreak_command_wrapper): Remove.
1322
13232019-11-26 Simon Marchi <simon.marchi@efficios.com>
1324
1325 * inferior.h (info_terminal_command): Remove declaration.
1326 * inflow.c (info_terminal_command): Make static.
1327
13282019-11-26 Simon Marchi <simon.marchi@efficios.com>
1329
1330 * inferior.c (exit_inferior_silent): Remove.
1331
13322019-11-26 Simon Marchi <simon.marchi@efficios.com>
1333
1334 * dictionary.c (dict_empty, mdict_empty): Remove.
1335 * dictionary.c (mdict_empty): Remove.
1336
13372019-11-26 Simon Marchi <simon.marchi@efficios.com>
1338
1339 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1340 (arc_insn_get_memory_offset): Likewise.
1341 (arc_insn_dump): Likewise.
1342 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1343 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1344 * dictionary.c (dict_iterator_next): Likewise.
1345 (dict_iter_match_first): Likewise.
1346 (dict_iter_match_next): Likewise.
1347 * f-lang.c (evaluate_subexp_f): Likewise.
1348 * hppa-tdep.c (hppa_read_pc): Likewise.
1349 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1350 * parse.c (write_exp_elt_msym): Likewise.
1351 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1352 * remote.c (remote_packet_size): Likewise.
1353 (remote_notif_stop_parse): Likewise.
1354 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1355 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1356 * source.c (prepare_path_for_appending): Likewise.
1357 * sparc64-linux-tdep.c
1358 (sparc64_linux_handle_segmentation_fault); Likewise.
1359 * stack.c (frame_selection_by_function_completer): Likewise.
1360
13612019-11-26 Simon Marchi <simon.marchi@efficios.com>
1362
1363 * completer.c (set_gdb_completion_word_break_characters):
1364 Remove.
1365
13662019-11-26 Simon Marchi <simon.marchi@efficios.com>
1367
1368 * dwarf-index-write.c: Include dwarf-index-write.h.
1369 * mi/mi-interp.c: Include mi/mi-interp.h.
1370
13712019-11-26 Simon Marchi <simon.marchi@efficios.com>
1372
1373 * aarch32-tdep.c: Include aarch32-tdep.h.
1374 * aarch32-tdep.h: Forward-declare struct target_desc.
1375
13762019-11-26 Christian Biesinger <cbiesinger@google.com>
1377
1378 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1379 strerror.
1380 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1381 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1382
13832019-11-25 Tom de Vries <tdevries@suse.de>
1384
1385 * contrib/words.sh: Add -c option.
1386
13872019-11-25 Christian Biesinger <cbiesinger@google.com>
1388
1389 * solib.c (solib_find_1): Change int to bool.
1390 (exec_file_find): Change int to bool.
1391 (solib_find): Change int to bool.
1392 (solib_read_symbols): Change int to bool.
1393 (solib_used): Change int to bool.
1394 (solib_add): Change int to bool.
1395 (info_sharedlibrary_command): Change int to bool.
1396 (solib_contains_address_p): Change int to bool.
1397 (solib_keep_data_in_core): Change int to bool.
1398 (in_solib_dynsym_resolve_code): Change int to bool.
1399 (reload_shared_libraries_1): Change int to bool.
1400 (gdb_sysroot_changed): Change int to bool.
1401 * solib.h (solib_read_symbols): Change int to bool.
1402 (solib_contains_address_p): Change int to bool.
1403 (solib_keep_data_in_core): Change int to bool.
1404 (in_solib_dynsym_resolve_code): Change int to bool.
1405 (libpthread_name_p): Change int to bool.
1406
14072019-11-25 Luis Machado <luis.machado@linaro.org>
1408
1409 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1410 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1411 (remote_packet_max_chars): New static global.
1412 (show_remote_packet_max_chars): New function.
1413 (remote_target::putpkt_binary): Adjust to use new
1414 remote_packet_max_chars option.
1415 (remote_target::getpkt_or_notif_sane_1): Likewise.
1416 (_initialize_remote): Register new remote-packet-max-chars option.
1417
14182019-11-24 Simon Marchi <simon.marchi@efficios.com>
1419
1420 * m68k-linux-nat.c: Include gdbarch.h.
1421
14222019-11-24 Tom Tromey <tom@tromey.com>
1423
1424 * symfile.c (read_symbols): Update.
1425 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1426 bool.
1427 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1428 (psym_lookup_symbol, psym_find_last_source_symtab)
1429 (psym_forget_cached_source_info, psym_print_stats)
1430 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1431 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1432 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1433 (psym_find_compunit_symtab_by_address)
1434 (maintenance_print_psymbols, maintenance_info_psymtabs)
1435 (maintenance_check_psymtabs): Update.
1436 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1437 bool.
1438
14392019-11-22 Tom Tromey <tom@tromey.com>
1440
1441 * observable.h: Update comments.
1442
14432019-11-22 Tom Tromey <tromey@adacore.com>
1444
1445 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1446 (print_ada_task_info): Don't try to fetch thread id if task is not
1447 alive.
1448
14492019-11-22 Christian Biesinger <cbiesinger@google.com>
1450
1451 * ada-exp.y: Update.
1452 * ada-lang.c (sort_choices): Update.
1453 (ada_print_symbol_signature): Update.
1454 (resolve_subexp): Update.
1455 (ada_parse_renaming): Update.
1456 (ada_read_renaming_var_value): Update.
1457 (lesseq_defined_than): Update.
1458 (remove_extra_symbols): Update.
1459 (remove_irrelevant_renamings): Update.
1460 (ada_add_block_symbols): Update.
1461 (ada_collect_symbol_completion_matches): Update.
1462 (ada_is_renaming_symbol): Update.
1463 (aggregate_assign_from_choices): Update.
1464 (ada_evaluate_subexp): Update.
1465 (ada_has_this_exception_support): Update.
1466 (ada_is_non_standard_exception_sym): Update.
1467 (ada_add_exceptions_from_frame): Update.
1468 (ada_add_global_exceptions): Update.
1469 (ada_print_subexp): Update.
1470 * ax-gdb.c (gen_var_ref): Update.
1471 (gen_maybe_namespace_elt): Update.
1472 (gen_expr_for_cast): Update.
1473 (gen_expr): Update.
1474 * block.h: Update.
1475 * blockframe.c (find_pc_partial_function): Update.
1476 * breakpoint.c (print_breakpoint_location): Update.
1477 (update_static_tracepoint): Update.
1478 * btrace.c (ftrace_print_function_name): Update.
1479 (ftrace_function_switched): Update.
1480 * buildsym.c (find_symbol_in_list): Update.
1481 * c-exp.y: Update.
1482 * c-typeprint.c (c_print_typedef): Update.
1483 (c_type_print_template_args): Update.
1484 * cli/cli-cmds.c (edit_command): Update.
1485 (list_command): Update.
1486 (print_sal_location): Update.
1487 * coffread.c (patch_opaque_types): Update.
1488 (process_coff_symbol): Update.
1489 (coff_read_enum_type): Update.
1490 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1491 (convert_one_symbol): Update.
1492 (hash_symname): Update.
1493 (eq_symname): Update.
1494 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1495 * compile/compile-cplus-types.c (debug_print_scope): Update.
1496 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1497 * compile/compile-object-load.c (get_out_value_type): Update.
1498 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1499 (search_symbol_list): Update.
1500 (cp_lookup_symbol_imports_or_template): Update.
1501 * cp-support.c (overload_list_add_symbol): Update.
1502 * ctfread.c (psymtab_to_symtab): Update.
1503 * dbxread.c (cp_set_block_scope): Update.
1504 * dictionary.c (iter_match_first_hashed): Update.
1505 (iter_match_next_hashed): Update.
1506 (insert_symbol_hashed): Update.
1507 (iter_match_next_linear): Update.
1508 * dictionary.h: Update.
1509 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1510 (locexpr_describe_location_piece): Update.
1511 (locexpr_describe_location_1): Update.
1512 (locexpr_generate_c_location): Update.
1513 (loclist_describe_location): Update.
1514 (loclist_generate_c_location): Update.
1515 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1516 (read_func_scope): Update.
1517 (process_enumeration_scope): Update.
1518 (new_symbol): Update.
1519 (dwarf2_const_value): Update.
1520 (dwarf2_symbol_mark_computed): Update.
1521 * eval.c (evaluate_funcall): Update.
1522 (evaluate_subexp_standard): Update.
1523 * expprint.c (print_subexp_standard): Update.
1524 (dump_subexp_body_standard): Update.
1525 * f-valprint.c (info_common_command_for_block): Update.
1526 * findvar.c (get_hosting_frame): Update.
1527 (default_read_var_value): Update.
1528 * go-lang.c (go_symbol_package_name): Update.
1529 * guile/scm-block.c (bkscm_print_block_smob): Update.
1530 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1531 (gdbscm_symbol_name): Update.
1532 (gdbscm_symbol_linkage_name): Update.
1533 (gdbscm_symbol_print_name): Update.
1534 * infcall.c (get_function_name): Update.
1535 * infcmd.c (jump_command): Update.
1536 (finish_command): Update.
1537 * infrun.c (insert_exception_resume_breakpoint): Update.
1538 * linespec.c (canonicalize_linespec): Update.
1539 (create_sals_line_offset): Update.
1540 (convert_linespec_to_sals): Update.
1541 (complete_label): Update.
1542 (find_label_symbols_in_block): Update.
1543 * m2-typeprint.c (m2_print_typedef): Update.
1544 * mdebugread.c (mdebug_reg_to_regnum): Update.
1545 (parse_symbol): Update.
1546 (mylookup_symbol): Update.
1547 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1548 (list_args_or_locals): Update.
1549 * objc-lang.c (compare_selectors): Update.
1550 (info_selectors_command): Update.
1551 (compare_classes): Update.
1552 (info_classes_command): Update.
1553 (find_imps): Update.
1554 * p-typeprint.c (pascal_print_typedef): Update.
1555 * printcmd.c (build_address_symbolic): Update.
1556 (info_address_command): Update.
1557 (print_variable_and_value): Update.
1558 * python/py-framefilter.c (extract_sym): Update.
1559 (py_print_single_arg): Update.
1560 * python/py-symbol.c (sympy_str): Update.
1561 (sympy_get_name): Update.
1562 (sympy_get_linkage_name): Update.
1563 * python/python.c (gdbpy_rbreak): Update.
1564 * record-btrace.c (btrace_get_bfun_name): Update.
1565 (btrace_call_history): Update.
1566 * rust-lang.c (rust_print_typedef): Update.
1567 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1568 * stabsread.c (stab_reg_to_regnum): Update.
1569 (define_symbol): Update.
1570 (read_enum_type): Update.
1571 (common_block_end): Update.
1572 (cleanup_undefined_types_1): Update.
1573 (scan_file_globals): Update.
1574 * stack.c (print_frame_arg): Update.
1575 (print_frame_args): Update.
1576 (find_frame_funname): Update.
1577 (info_frame_command_core): Update.
1578 (iterate_over_block_locals): Update.
1579 (print_block_frame_labels): Update.
1580 (do_print_variable_and_value): Update.
1581 (iterate_over_block_arg_vars): Update.
1582 (return_command): Update.
1583 * symmisc.c (dump_symtab_1): Update.
1584 (print_symbol): Update.
1585 * symtab.c (eq_symbol_entry): Update.
1586 (symbol_cache_dump): Update.
1587 (lookup_language_this): Update.
1588 (find_pc_sect_line): Update.
1589 (skip_prologue_sal): Update.
1590 (symbol_search::compare_search_syms): Update.
1591 (treg_matches_sym_type_name): Update.
1592 (search_symbols): Update.
1593 (print_symbol_info): Update.
1594 (rbreak_command): Update.
1595 (completion_list_add_symbol): Update.
1596 (find_gnu_ifunc): Update.
1597 (get_symbol_address): Update.
1598 (search_module_symbols): Update.
1599 (info_module_subcommand): Update.
1600 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1601 (SYMBOL_LINKAGE_NAME): Remove.
1602 (SYMBOL_DEMANGLED_NAME): Remove.
1603 (SYMBOL_PRINT_NAME): Remove.
1604 (SYMBOL_SEARCH_NAME): Remove.
1605 * tracepoint.c (set_traceframe_context): Update.
1606 (validate_actionline): Update.
1607 (collection_list::collect_symbol): Update.
1608 (encode_actions_1): Update.
1609 (info_scope_command): Update.
1610 (print_one_static_tracepoint_marker): Update.
1611 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1612 * valops.c (address_of_variable): Update.
1613 (find_overload_match): Update.
1614 (find_oload_champ): Update.
1615
16162019-11-22 Christian Biesinger <cbiesinger@google.com>
1617
1618 * ada-lang.c (ada_lookup_simple_minsym): Update.
1619 (ada_collect_symbol_completion_matches): Update.
1620 * ada-tasks.c (read_atcb): Update.
1621 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1622 (amd64_windows_skip_trampoline_code): Update.
1623 * arm-tdep.c (skip_prologue_function): Update.
1624 (arm_skip_stack_protector): Update.
1625 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1626 (arm_wince_skip_main_prologue): Update.
1627 * ax-gdb.c (gen_expr): Update.
1628 * block.c (call_site_for_pc): Update.
1629 * blockframe.c (find_pc_partial_function): Update.
1630 * breakpoint.c (set_breakpoint_location_function): Update.
1631 * btrace.c (ftrace_print_function_name): Update.
1632 (ftrace_function_switched): Update.
1633 * c-valprint.c (print_unpacked_pointer): Update.
1634 * coffread.c (coff_symfile_read): Update.
1635 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1636 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1637 * dwarf-index-write.c (write_psymbols): Update.
1638 * dwarf2loc.c (call_site_to_target_addr): Update.
1639 (func_verify_no_selftailcall): Update.
1640 (tailcall_dump): Update.
1641 (call_site_find_chain_1): Update.
1642 (dwarf_expr_reg_to_entry_parameter): Update.
1643 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1644 * eval.c (evaluate_funcall): Update.
1645 (evaluate_subexp_standard): Update.
1646 (evaluate_subexp_for_sizeof): Update.
1647 * expprint.c (print_subexp_standard): Update.
1648 (dump_subexp_body_standard): Update.
1649 * frame.c (get_prev_frame_always_1): Update.
1650 * frv-tdep.c (frv_skip_main_prologue): Update.
1651 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1652 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1653 (gnuv3_get_typename_from_type_info): Update.
1654 (gnuv3_skip_trampoline): Update.
1655 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1656 * i386-tdep.c (i386_skip_main_prologue): Update.
1657 (i386_pe_skip_trampoline_code): Update.
1658 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1659 * infcall.c (get_function_name): Update.
1660 * linespec.c (minsym_found): Update.
1661 * linux-fork.c (info_checkpoints_command): Update.
1662 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1663 (m32c_m16c_pointer_to_address): Update.
1664 * maint.c (maintenance_translate_address): Update.
1665 * minsyms.c (add_minsym_to_hash_table): Update.
1666 (add_minsym_to_demangled_hash_table): Update.
1667 (lookup_minimal_symbol_mangled): Update.
1668 (lookup_minimal_symbol_demangled): Update.
1669 (lookup_minimal_symbol_linkage): Update.
1670 (lookup_minimal_symbol_text): Update.
1671 (lookup_minimal_symbol_by_pc_name): Update.
1672 (minimal_symbol_is_less_than): Update.
1673 (compact_minimal_symbols): Update.
1674 (build_minimal_symbol_hash_tables): Update.
1675 (find_solib_trampoline_target): Update.
1676 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1677 (mips_skip_pic_trampoline_code): Update.
1678 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1679 * objc-lang.c (info_selectors_command): Update.
1680 (info_classes_command): Update.
1681 (find_methods): Update.
1682 (find_imps): Update.
1683 * p-valprint.c (pascal_val_print): Update.
1684 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1685 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1686 * printcmd.c (build_address_symbolic): Update.
1687 (info_symbol_command): Update.
1688 * psymtab.c (psymbol_name_matches): Update.
1689 (match_partial_symbol): Update.
1690 (lookup_partial_symbol): Update.
1691 (print_partial_symbols): Update.
1692 (sort_pst_symbols): Update.
1693 (maintenance_check_psymtabs): Update.
1694 * python/py-framefilter.c (py_print_frame): Update.
1695 * python/python.c (gdbpy_rbreak): Update.
1696 * record-btrace.c (btrace_get_bfun_name): Update.
1697 (btrace_call_history): Update.
1698 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1699 (rs6000_skip_trampoline_code): Update.
1700 * sol-thread.c (info_cb): Update.
1701 * stabsread.c (scan_file_globals): Update.
1702 * stack.c (find_frame_funname): Update.
1703 (info_frame_command_core): Update.
1704 * symmisc.c (dump_msymbols): Update.
1705 * symtab.c (symbol_natural_name): Rename to..,
1706 (general_symbol_info::natural_name): ...this.
1707 (symbol_demangled_name): Rename to...
1708 (general_symbol_info::demangled_name): ...this.
1709 (symbol_search_name): Rename to...
1710 (general_symbol_info::search_name): ...this.
1711 (symbol_matches_search_name): Update.
1712 (find_pc_sect_line): Update.
1713 (skip_prologue_sal): Update.
1714 (search_symbols): Update.
1715 (print_msymbol_info): Update.
1716 (rbreak_command): Update.
1717 (completion_list_add_msymbol): Update.
1718 (completion_list_objc_symbol): Update.
1719 (get_msymbol_address): Update.
1720 * symtab.h (struct general_symbol_info): Add member functions
1721 natural_name (), linkage_name (), print_name (), demangled_name (),
1722 and search_name ().
1723 (SYMBOL_NATURAL_NAME): Update.
1724 (symbol_natural_name): Move to a member function on general_symbol_info.
1725 (SYMBOL_DEMANGLED_NAME): Update.
1726 (symbol_demangled_name): Move to a member function on
1727 general_symbol_info.
1728 (SYMBOL_SEARCH_NAME): Update.
1729 (symbol_search_name): Move to a member function on general_symbol_info.
1730 (MSYMBOL_NATURAL_NAME): Remove.
1731 (MSYMBOL_LINKAGE_NAME): Remove.
1732 (MSYMBOL_PRINT_NAME): Remove.
1733 (MSYMBOL_DEMANGLED_NAME): Remove.
1734 (MSYMBOL_SEARCH_NAME): Remove.
1735 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1736
17372019-11-22 Christian Biesinger <cbiesinger@google.com>
1738
1739 * symtab.c (create_demangled_names_hash): Use per_bfd->
1740 minimal_symbol_count for computing the initial size, if greater
1741 than our default size.
1742
17432019-11-22 Tom de Vries <tdevries@suse.de>
1744
1745 * contrib/words.sh: Improve words extraction.
1746
17472019-11-22 Tom de Vries <tdevries@suse.de>
1748
1749 * contrib/words.sh: Combine sed invocations.
1750
17512019-11-21 Christian Biesinger <cbiesinger@google.com>
1752
1753 * Makefile.in: Update.
1754 * demangle.c: Rename to...
1755 * gdb-demangle.c: ..this.
1756 (is_cplus_marker): Change return type to bool.
1757 (_initialize_demangler): Rename to...
1758 (_initialize_gdb_demangle): ...this.
1759 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1760 * symtab.h (demangle): Remove declaration; instead include
1761 gdb-demangle.h.
1762
17632019-11-21 Tom Tromey <tromey@adacore.com>
1764
1765 * gdbsupport/format.c (format_pieces): Parse %I64d.
1766 * unittests/format_pieces-selftests.c (test_windows_formats): New
1767 function.
1768 (run_tests): Call it.
1769
17702019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1771
1772 Byte reverse display of variables with DW_END_big, DW_END_little
1773 (DW_AT_endianity) dwarf attributes if different than the native
1774 byte order.
1775 * ada-lang.c (ada_value_binop):
1776 Use type_byte_order instead of gdbarch_byte_order.
1777 * ada-valprint.c (printstr):
1778 (ada_val_print_string):
1779 * ada-lang.c (value_pointer):
1780 (ada_value_binop):
1781 Use type_byte_order instead of gdbarch_byte_order.
1782 * c-lang.c (c_get_string):
1783 Use type_byte_order instead of gdbarch_byte_order.
1784 * c-valprint.c (c_val_print_array):
1785 Use type_byte_order instead of gdbarch_byte_order.
1786 * cp-valprint.c (cp_print_class_member):
1787 Use type_byte_order instead of gdbarch_byte_order.
1788 * dwarf2loc.c (rw_pieced_value):
1789 Use type_byte_order instead of gdbarch_byte_order.
1790 * dwarf2read.c (read_base_type): Handle DW_END_big,
1791 DW_END_little
1792 * f-lang.c (f_get_encoding):
1793 Use type_byte_order instead of gdbarch_byte_order.
1794 * findvar.c (default_read_var_value):
1795 Use type_byte_order instead of gdbarch_byte_order.
1796 * gdbtypes.c (check_types_equal):
1797 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1798 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1799 and TYPE_ENDIANITY_LITTLE if set.
1800 (type_byte_order): new function.
1801 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1802 (struct main_type) <flag_endianity_not_default>:
1803 New field.
1804 (type_byte_order): New function.
1805 * infcmd.c (default_print_one_register_info):
1806 Use type_byte_order instead of gdbarch_byte_order.
1807 * p-lang.c (pascal_printstr):
1808 Use type_byte_order instead of gdbarch_byte_order.
1809 * p-valprint.c (pascal_val_print):
1810 Use type_byte_order instead of gdbarch_byte_order.
1811 * printcmd.c (print_scalar_formatted):
1812 Use type_byte_order instead of gdbarch_byte_order.
1813 * solib-darwin.c (darwin_current_sos):
1814 Use type_byte_order instead of gdbarch_byte_order.
1815 * solib-svr4.c (solib_svr4_r_ldsomap):
1816 Use type_byte_order instead of gdbarch_byte_order.
1817 * stap-probe.c (stap_modify_semaphore):
1818 Use type_byte_order instead of gdbarch_byte_order.
1819 * target-float.c (target_float_same_format_p):
1820 Use type_byte_order instead of gdbarch_byte_order.
1821 * valarith.c (scalar_binop):
1822 (value_bit_index):
1823 Use type_byte_order instead of gdbarch_byte_order.
1824 * valops.c (value_cast):
1825 Use type_byte_order instead of gdbarch_byte_order.
1826 * valprint.c (generic_emit_char):
1827 (generic_printstr):
1828 (val_print_string):
1829 Use type_byte_order instead of gdbarch_byte_order.
1830 * value.c (unpack_long):
1831 (unpack_bits_as_long):
1832 (unpack_value_bitfield):
1833 (modify_field):
1834 (pack_long):
1835 (pack_unsigned_long):
1836 Use type_byte_order instead of gdbarch_byte_order.
1837 * findvar.c (unsigned_pointer_to_address):
1838 (signed_pointer_to_address):
1839 (unsigned_address_to_pointer):
1840 (address_to_signed_pointer):
1841 (default_read_var_value):
1842 (default_value_from_register):
1843 Use type_byte_order instead of gdbarch_byte_order.
1844 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1845 Use type_byte_order instead of gdbarch_byte_order.
1846 * riscv-tdep.c (riscv_print_one_register_info):
1847 Use type_byte_order instead of gdbarch_byte_order.
1848
18492019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1850
1851 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1852 (current_ui_gdb_stdin_ptr): Likewise.
1853 (current_ui_gdb_stderr_ptr): Likewise.
1854 (current_ui_gdb_stdlog_ptr): Likewise.
1855 (current_ui_current_uiout_ptr): Likewise.
1856 (gen_ret_current_ui_field_ptr): Remove.
1857
18582019-11-21 Tom de Vries <tdevries@suse.de>
1859
1860 PR gdb/24956
1861 * cli/cli-script.c (execute_control_command): Only switch to
1862 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1863
18642019-11-19 Tom Tromey <tom@tromey.com>
1865
1866 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1867 Now static. Change type of "name".
1868 (tui_set_win_height_command): Don't copy "arg".
1869 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1870 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1871
18722019-11-19 Ali Tamur <tamur@google.com>
1873
1874 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1875 "if (attr != nullptr)".
1876 (dwarf2_find_base_address): Likewise.
1877 (dwarf2_build_include_psymtabs): Likewise.
1878 (read_cutu_die_from_dwo): Likewise.
1879 (read_func_scope): Likewise.
1880 (read_call_site_scope): Likewise.
1881 (dwarf2_get_pc_bounds): Likewise.
1882 (dwarf2_record_block_ranges): Likewise.
1883 (dwarf2_add_field): Likewise.
1884 (dwarf2_add_member_fn): Likewise.
1885 (read_structure_type): Likewise.
1886 (read_enumeration_type): Likewise.
1887 (read_array_type): Likewise.
1888 (read_array_order): Likewise.
1889 (read_set_type): Likewise.
1890 (read_common_block): Likewise.
1891 (read_tag_reference_type): Likewise.
1892 (read_tag_string_type): Likewise.
1893 (read_subroutine_type): Likewise.
1894 (read_base_type): Likewise.
1895 (read_subrange_type): Likewise.
1896 (new_symbol): Likewise.
1897 (prepare_one_comp_unit): Likewise.
1898
18992019-11-19 Tom Tromey <tromey@adacore.com>
1900
1901 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1902 result in error when DebugActiveProcess fails.
1903
19042019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1905 Pedro Alves <palves@redhat.com>
1906
1907 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1908 * target.c (target_stack::push): Call 'unpush' if there's a
1909 target on top of the stack.
1910
19112019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1912
1913 * python/py-block.c (blpy_dealloc): Call tp_free.
1914 (blpy_block_syms_dealloc): Likewise.
1915 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1916 * python/py-inferior.c (infpy_dealloc): Likewise.
1917 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1918 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1919 * python/py-symbol.c (sympy_dealloc): Likewise.
1920 * python/py-symtab.c (stpy_dealloc): Likewise.
1921 * python/py-type.c (typy_iterator_dealloc): Likewise.
1922
19232019-11-18 Christian Biesinger <cbiesinger@google.com>
1924
1925 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1926 constructor instead of using a class initializer.
1927
19282019-11-15 Christian Biesinger <cbiesinger@google.com>
1929
1930 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1931 * configure: Regenerate.
1932 * configure.ac: Don't source common.host.
1933 * gdbsupport/common.host: Remove.
1934 * gdbsupport/mingw-strerror.c: Remove.
1935 * gdbsupport/posix-strerror.c: Rename to...
1936 * gdbsupport/safe-strerror.c: ...this.
1937
19382019-11-15 Christian Biesinger <cbiesinger@google.com>
1939
1940 * maint.c (scoped_command_stats::print_time): Use localtime_r
1941 instead of localtime (provided through gnulib if necessary).
1942 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1943 of ctime.
1944
19452019-11-15 Christian Biesinger <cbiesinger@google.com>
1946
1947 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1948 avoid compile errors.
1949
19502019-11-15 Christian Biesinger <cbiesinger@google.com>
1951
1952 * config.in: Regenerate.
1953 * configure: Regenerate.
1954 * gdbsupport/common.m4: No longer check for strerror_r.
1955 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1956 POSIX version of strerror_r, now that gnulib provides it if
1957 necessary.
1958
19592019-11-14 Christian Biesinger <cbiesinger@google.com>
1960
1961 * README (`configure' options): Update.
1962
19632019-11-14 Tom Tromey <tromey@adacore.com>
1964
1965 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1966 expected type for the RHS if the LHS is a convenience variable.
1967
19682019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1969
1970 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1971 Provide explicit default and copy constructor.
1972
19732019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1974
1975 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1976 only call Py_INCREF (newbp) in the bppy_pending_object case.
1977
19782019-11-13 Tom Tromey <tromey@adacore.com>
1979
1980 PR build/25182:
1981 * psympriv.h (partial_symbol): Remove static assert.
1982 * symtab.h (general_symbol_info, symbol): Remove static assert.
1983
19842019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1985
1986 * gdbsupport/format.c (format_pieces::format_pieces): Support
1987 printf 'z' size modifier.
1988 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1989 * printcmd.c (ui_printf): Handle size_t_arg.
1990 * ui-out.c (ui_out::vmessage): Likewise.
1991 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1992 function.
1993 (run_tests): Call test_format_int_sizes.
1994
19952019-11-12 Christian Biesinger <cbiesinger@google.com>
1996
1997 * ada-exp.y (write_ambiguous_var): Update.
1998 * buildsym.c (add_symbol_to_list): Update.
1999 * dwarf2read.c (read_variable): Update.
2000 (new_symbol): Update.
2001 * jit.c (finalize_symtab): Update.
2002 * language.c (language_alloc_type_symbol): Update.
2003 * symtab.c (fixup_symbol_section): Update.
2004 (initialize_objfile_symbol_1): Move code to...
2005 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2006 (allocate_symbol): Update.
2007 (allocate_template_symbol): Update.
2008 (get_symbol_address): Update.
2009 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2010 of having as a field, and add a constructor.
2011 (SYMBOL_VALUE): Update.
2012 (SYMBOL_VALUE_ADDRESS): Update.
2013 (SET_SYMBOL_VALUE_ADDRESS): Update.
2014 (SYMBOL_VALUE_BYTES): Update.
2015 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2016 (SYMBOL_BLOCK_VALUE): Update.
2017 (SYMBOL_VALUE_CHAIN): Update.
2018 (SYMBOL_LANGUAGE): Update.
2019 (SYMBOL_SECTION): Update.
2020 (SYMBOL_OBJ_SECTION): Update.
2021 (SYMBOL_SET_LANGUAGE): Update.
2022 (SYMBOL_SET_LINKAGE_NAME): Update.
2023 (SYMBOL_SET_NAMES): Update.
2024 (SYMBOL_NATURAL_NAME): Update.
2025 (SYMBOL_LINKAGE_NAME): Update.
2026 (SYMBOL_DEMANGLED_NAME): Update.
2027 (SYMBOL_SEARCH_NAME): Update.
2028 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2029 (struct symbol): Update.
2030 (struct template_symbol): Update.
2031 (struct rust_vtable_symbol): Update.
2032 * xcoffread.c (SYMBOL_DUP): Update.
2033
20342019-11-12 Tom Tromey <tom@tromey.com>
2035
2036 * tui/tui-layout.c (show_layout): Set current_layout.
2037 (show_source_disasm_command, show_data)
2038 (show_source_or_disasm_and_command): Don't set current_layout.
2039
20402019-11-12 Tom Tromey <tom@tromey.com>
2041
2042 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2043
20442019-11-12 Tom Tromey <tom@tromey.com>
2045
2046 * tui/tui-win.c (resize_message): New global.
2047 (show_tui_resize_message): New function.
2048 (tui_async_resize_screen): Print message if requested.
2049 (_initialize_tui_win): Add tui-resize-message setting.
2050 * NEWS: Add entry for new commands.
2051
20522019-11-11 Tom Tromey <tom@tromey.com>
2053
2054 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2055 functions.
2056
20572019-11-11 Christian Biesinger <cbiesinger@google.com>
2058
2059 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2060
20612019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2062
2063 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2064 function.
2065 * python/python-internal.h (gdbpy_lookup_static_symbols):
2066 Declare new function.
2067 * python/python.c (python_GdbMethods): Add
2068 gdb.lookup_static_symbols method.
2069 * NEWS: Mention gdb.lookup_static_symbols.
2070
20712019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2072
2073 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2074 static block of current object file first. Also fix typo in
2075 header comment.
2076
20772019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2078
2079 * stack.c (set_last_displayed_sal): Delete.
2080 (last_displayed_sal_valid): Delete.
2081 (last_displayed_pspace): Delete.
2082 (last_displayed_addr): Delete.
2083 (last_displayed_symtab): Delete.
2084 (last_displayed_line): Delete.
2085 (class last_displayed_symtab_info_type): New.
2086 (last_displayed_symtab_info): New static global variable.
2087 (print_frame_info): Call methods on last_displayed_symtab_info.
2088 (clear_last_displayed_sal): Update header comment, and make use of
2089 last_displayed_symtab_info.
2090 (last_displayed_sal_is_valid): Likewise.
2091 (get_last_displayed_pspace): Likewise.
2092 (get_last_displayed_addr): Likewise.
2093 (get_last_displayed_symtab): Likewise.
2094 (get_last_displayed_line): Likewise.
2095 (get_last_displayed_sal): Likewise.
2096 * stack.h (clear_last_displayed_sal): Update header comment.
2097 (last_displayed_sal_is_valid): Likewise.
2098 (get_last_displayed_pspace): Likewise.
2099 (get_last_displayed_addr): Likewise.
2100 (get_last_displayed_symtab): Likewise.
2101 (get_last_displayed_line): Likewise.
2102 (get_last_displayed_sal): Likewise.
2103
21042019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2105
2106 * stack.c (frame_show_address): Convert return type to bool.
2107 * stack.h (frame_show_address): Likewise, and update header
2108 comment.
2109
21102019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2111
2112 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2113 * unittests/vec-utils-selftests.c: New file.
2114 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2115
21162019-11-10 Tom Tromey <tom@tromey.com>
2117
2118 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2119 (tui_highlight_win): Likewise.
2120 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2121 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2122 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2123 Don't set can_highlight.
2124
21252019-11-10 Tom Tromey <tom@tromey.com>
2126
2127 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2128 Remove unused declaration.
2129
21302019-11-08 Tom Tromey <tromey@adacore.com>
2131
2132 * top.c (read_command_file): Update.
2133 (command_line_input): Make return type const.
2134 * python/py-gdb-readline.c: Update.
2135 * linespec.c (decode_line_2): Update.
2136 * defs.h (command_line_input): Make return type const.
2137 * cli/cli-script.c (read_next_line): Make return type const.
2138 * ada-lang.c (get_selections): Update.
2139
21402019-11-06 Christian Biesinger <cbiesinger@google.com>
2141
2142 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2143 * mi/mi-main.c (output_cores): Likewise.
2144 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2145 (linux_xfer_osdata_modules): Likewise.
2146 * remote.c (register_remote_support_xml): Likewise.
2147 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2148 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2149
21502019-11-06 Tom Tromey <tom@tromey.com>
2151
2152 * tui/tui-interp.c: Don't include readline.h.
2153 * tui/tui-hooks.c: Don't include readline.h.
2154 * symmisc.c: Include tilde.h, not readline.h.
2155 * symfile.c: Include tilde.h, not readline.h.
2156 * source.c: Include tilde.h, not readline.h.
2157 * solib.c: Include tilde.h, not readline.h.
2158 * psymtab.c: Include tilde.h, not readline.h.
2159 * exec.c: Include tilde.h, not readline.h.
2160 * corelow.c: Include tilde.h, not readline.h.
2161 * cli/cli-dump.c: Include tilde.h, not readline.h.
2162 * cli/cli-cmds.c: Don't include readline.h.
2163
21642019-11-05 Tom Tromey <tom@tromey.com>
2165
2166 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2167 (tui_disassemble): Set addr_size.
2168 (tui_disasm_window::set_contents): Use addr_size.
2169
21702019-11-05 Tom Tromey <tom@tromey.com>
2171
2172 * rust-lang.c (rust_language_defn): Update.
2173 * python/py-value.c (valpy_string): Call c_get_string.
2174 * p-lang.c (pascal_language_defn): Update.
2175 * opencl-lang.c (opencl_language_defn): Update.
2176 * objc-lang.c (objc_language_defn): Update.
2177 * m2-lang.c (m2_language_defn): Update.
2178 * language.c (unknown_language_defn, auto_language_defn): Update.
2179 (default_get_string): Remove.
2180 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2181 * go-lang.c (go_language_defn): Update.
2182 * f-lang.c (f_language_defn): Update.
2183 * d-lang.c (d_language_defn): Update.
2184 * c-lang.c (c_language_defn, cplus_language_defn)
2185 (asm_language_defn, minimal_language_defn): Update.
2186 * ada-lang.c (ada_language_defn): Update.
2187 * language.h (struct language_defn) <la_get_string>: Remove.
2188 (LA_GET_STRING): Remove.
2189 (default_get_string): Don't declare.
2190
21912019-11-05 Tom Tromey <tom@tromey.com>
2192
2193 * tui/tui-source.h (struct tui_source_window): Inline
2194 constructor. Remove destructor.
2195 <style_changed, m_observable>: Move to superclass.
2196 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2197 (struct tui_source_window_base): Move private members to end.
2198 <style_changed, m_observable>: Move from tui_source_window.
2199 * tui/tui-winsource.c (tui_copy_source_line): Move from
2200 tui-source.c. Rename from copy_source_line. Add special handling
2201 for negative line number.
2202 (tui_source_window_base::style_changed): Move from
2203 tui_source_window.
2204 (tui_source_window_base): Register observer.
2205 (~tui_source_window_base): New.
2206 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2207 rename.
2208 (tui_source_window::set_contents): Use tui_copy_source_line.
2209 (tui_source_window::tui_source_window): Move to tui-source.h.
2210 (tui_source_window::~tui_source_window): Remove.
2211 (tui_source_window::style_changed): Move to superclass.
2212 * tui/tui-disasm.c (tui_disassemble): Create string file with
2213 styling, when possible. Add "addr_size" parameter.
2214 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2215 Don't compute maximum size.
2216 (len_without_escapes): New function
2217
22182019-11-05 Tom Tromey <tom@tromey.com>
2219
2220 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2221 std::string.
2222 * tui/tui-winsource.c (tui_show_source_line): Update.
2223 * tui/tui-source.c (tui_source_window::set_contents): Update.
2224 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2225
22262019-11-05 Christian Biesinger <cbiesinger@google.com>
2227
2228 * symtab.h (gdb_static_assert): Put && operator at the beginning
2229 of the line instead of the end.
2230
22312019-11-04 Christian Biesinger <cbiesinger@google.com>
2232
2233 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2234 and sizeof (symbol).
2235 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2236
22372019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2238
2239 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2240 * configure.host: Mark *-*-solaris2.10* obsolete.
2241 * configure.tgt: Mark Solaris < 11 obsolete.
2242 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2243 Update target triplet.
2244
22452019-11-01 Tom Tromey <tromey@adacore.com>
2246
2247 * utils.c (print_sys_errmsg): Simplify.
2248
22492019-11-01 Tom Tromey <tromey@adacore.com>
2250
2251 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2252
22532019-11-01 Christian Biesinger <cbiesinger@google.com>
2254
2255 * configure: Regenerate.
2256 * configure.ac: Remove check for strerror_r.
2257 * gdbsupport/common.m4: Check for strerror_r.
2258
22592019-11-01 Luis Machado <luis.machado@linaro.org>
2260
2261 PR gdb/25124
2262
2263 * arm-tdep.c (arm_per_objfile): Rename to ...
2264 (arm_per_bfd): ... this.
2265 (arm_objfile_data_key): Rename to ...
2266 (arm_bfd_data_key): ... this.
2267 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2268 data.
2269 (arm_record_special_symbol): Likewise.
2270
22712019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2272
2273 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2274 end.
2275 * c-typeprint.c (c_print_typedef): Likewise.
2276 * f-typeprint.c (f_print_typedef): Likewise.
2277 * m2-typeprint.c (m2_print_typedef): Likewise.
2278 * p-typeprint.c (pascal_print_typedef): Likewise.
2279 * rust-lang.c (rust_print_typedef): Likewise.
2280 * symtab.c (print_symbol_info): Print a newline after calling
2281 typedef_print.
2282
22832019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2284
2285 * symtab.c (info_module_cmdlist): New variable.
2286 (info_module_command): New function.
2287 (search_module_symbols): New function.
2288 (info_module_subcommand): New function.
2289 (struct info_modules_var_func_options): New struct.
2290 (info_modules_var_func_options_defs): New variable.
2291 (make_info_modules_var_func_options_def_group): New function.
2292 (info_module_functions_command): New function.
2293 (info_module_variables_command): New function.
2294 (info_module_var_func_command_completer): New function.
2295 (_initialize_symtab): Register new 'info module functions' and
2296 'info module variables' commands.
2297 * symtab.h (typedef symbol_search_in_module): New typedef.
2298 (search_module_symbols): Declare new function.
2299 * NEWS: Mention new commands.
2300
23012019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2302
2303 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2304 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2305 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2306 MODULES_DOMAIN.
2307 (scan_partial_symbols): Only create partial module symbols for non
2308 declarations.
2309 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2310 and MODULES_DOMAIN.
2311 * symtab.c (search_domain_name): Likewise.
2312 (search_symbols): Likewise.
2313 (print_symbol_info): Likewise.
2314 (symtab_symbol_info): Likewise.
2315 (info_modules_command): New function.
2316 (_initialize_symtab): Register 'info modules' command.
2317 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2318 * NEWS: Mention new 'info modules' command.
2319
23202019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2321
2322 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2323 and $_gdb_maint_setting_str.
2324
23252019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2326
2327 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2328 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2329 (str_value_from_setting, gdb_setting_str_internal_fn)
2330 (gdb_maint_setting_str_internal_fn): New functions.
2331 (_initialize_cli_cmds): Define the new convenience functions.
2332 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2333 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2334
23352019-10-31 Christian Biesinger <cbiesinger@google.com>
2336
2337 * agent.c (set_can_use_agent): When the setting is turned on,
2338 look up agent symbols if we don't have them yet.
2339 (agent_new_objfile): Don't look up agent symbols when the agent
2340 setting is off.
2341
23422019-10-31 Christian Biesinger <cbiesinger@google.com>
2343
2344 * config.in: Regenerate.
2345
23462019-10-31 Christian Biesinger <cbiesinger@google.com>
2347
2348 * configure: Regenerate.
2349 * configure.ac: Check for strerror_r.
2350 * gdbsupport/common-utils.h (safe_strerror): Change return value
2351 to const char * and document that this function is now threadsafe.
2352 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2353 thread_local and call strerror_r, if available.
2354 * utils.c (perror_string): Update.
2355 (print_sys_errmsg): Update.
2356
23572019-10-31 Luis Machado <luis.machado@linaro.org>
2358
2359 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2360 objfile_key.
2361 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2362 objfile to fetch per-bfd data.
2363 (arm_find_exidx_entry): Likewise.
2364
23652019-10-31 Christian Biesinger <cbiesinger@google.com>
2366
2367 * gdbsupport/agent.c (debug_agent): Change type to bool.
2368 (use_agent): Likewise.
2369 (all_agent_symbols_look_up): Likewise.
2370 (agent_loaded_p): Change return value to bool.
2371 (agent_look_up_symbols): Update.
2372 (agent_capability_check): Change return value to bool.
2373 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2374 (debug_agent): Change type to bool.
2375 (use_agent): Likewise.
2376 (agent_capability_check): Change return value to bool.
2377
23782019-10-30 Christian Biesinger <cbiesinger@google.com>
2379
2380 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2381 (build_minimal_symbol_hash_tables): Code to clear the table moved
2382 to clear_minimal_symbol_hash_tables.
2383 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2384 when needed.
2385
23862019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2387
2388 * infcmd.c: Remove includes.
2389 * infrun.c: Remove includes.
2390
23912019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2392
2393 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2394 (grow_vect): Remove declaration.
2395 (ada_type_of_array): Remove declaration.
2396 (ada_update_initial_language): Remove declaration.
2397 (ada_fold_name): Remove declaration.
2398 (ada_fill_in_ada_prototype): Remove declaration.
2399 (user_select_syms): Remove declaration.
2400 (get_selections): Remove declaration.
2401 (ada_tag_type): Remove declaration.
2402 (ada_value_tag): Remove declaration.
2403 (ada_is_others_clause): Remove declaration.
2404 (ada_in_variant): Remove declaration.
2405 (ada_value_struct_elt): Remove declaration.
2406 (ada_attribute_name): Remove declaration.
2407 (ada_system_address_type): Remove declaration.
2408 * ada-lang.c (ada_watch_location_expression): Make static.
2409 (GROW_VECT): Move here from ada-lang.h.
2410 (grow_vect): Make static.
2411 (ada_update_initial_language): Make static.
2412 (ada_fold_name): Make static.
2413 (ada_type_of_array): Make static.
2414 (encoded_ordered_before): Move up.
2415 (sort_choices): Move up.
2416 (print_signatures): Move up.
2417 (ada_print_symbol_signature): Move up.
2418 (get_selections): Move up and make static.
2419 (user_select_syms): Move up and make static.
2420 (ada_value_struct_elt): Move up and make static.
2421 (ada_tag_type): Make static.
2422 (ada_value_tag): Make static.
2423 (ada_is_others_clause): Make static.
2424 (ada_in_variant): Make static.
2425 (ada_attribute_name): Make static.
2426
24272019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2428
2429 * ada-lang.c: Remove includes.
2430 * ada-typeprint.c: Remove includes.
2431 * ada-valprint.c: Remove includes.
2432
24332019-10-29 Simon Marchi <simon.marchi@efficios.com>
2434
2435 * addrmap.c: Add static assertions of type size, moved from
2436 _initialize_addrmap.
2437 (_initialize_addrmap): Remove.
2438
24392019-10-29 Christian Biesinger <cbiesinger@google.com>
2440
2441 * coffread.c (record_minimal_symbol): Update.
2442 (process_coff_symbol): Update.
2443 * dbxread.c (read_dbx_symtab): Update.
2444 * dwarf2read.c (add_partial_symbol): Update.
2445 (fixup_go_packaging): Update.
2446 (load_partial_dies): Update.
2447 (new_symbol): Update.
2448 * elfread.c (record_minimal_symbol): Change signature to use
2449 gdb::string_view instead of name+len.
2450 (elf_symtab_read): Update.
2451 (elf_rel_plt_read): Update.
2452 * mdebugread.c (parse_partial_symbols): Update.
2453 (handle_psymbol_enumerators): Update.
2454 (new_symbol): Update.
2455 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2456 to use gdb::string_view instead of name+len.
2457 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2458 * psympriv.h (add_psymbol_to_list): Likewise.
2459 * psymtab.c (add_psymbol_to_bcache): Likewise.
2460 (add_psymbol_to_list): Likewise.
2461 * stabsread.c (define_symbol): Update.
2462 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2463 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2464 (symbol_set_names): Likewise.
2465 * xcoffread.c (scan_xcoff_symtab): Update.
2466
24672019-10-29 Christian Biesinger <cbiesinger@google.com>
2468
2469 * symtab.h (symbol_set_names): Document that copy_name must be
2470 set to true for non-nullterminated strings.
2471 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2472 linkage_name if the entry was not found and we need to demangle.
2473
24742019-10-29 Christian Biesinger <cbiesinger@google.com>
2475
2476 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2477 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2478 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2479 * gdbsupport/gdb_binary_search.h: New file.
2480
24812019-10-29 Christian Biesinger <cbiesinger@google.com>
2482
2483 * NEWS: Mention new --with-system-gdbinit-dir option.
2484 * config.in: Regenerate.
2485 * configure: Regenerate.
2486 * configure.ac: Add new option --with-system-gdbinit-dir.
2487 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2488 for a ".gdb" suffix.
2489 * main.c (get_init_files): Change system_gdbinit argument to
2490 a vector and return the files in SYSTEM_GDBINIT_DIR in
2491 addition to SYSTEM_GDBINIT.
2492 (captured_main_1): Update.
2493 (print_gdb_help): Update.
2494 * top.c (print_gdb_configuration): Also print the value of
2495 SYSTEM_GDBINIT_DIR.
2496
24972019-10-28 Christian Biesinger <cbiesinger@google.com>
2498
2499 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2500 that takes gdb::string_view arguments.
2501
25022019-10-26 Tom de Vries <tdevries@suse.de>
2503
2504 * aarch64-linux-tdep.c: Fix typos in comments.
2505 * aarch64-tdep.c: Same.
2506 * ada-lang.c: Same.
2507 * amd64-nat.c: Same.
2508 * arc-tdep.c: Same.
2509 * arch/aarch64-insn.c: Same.
2510 * block.c: Same.
2511 * breakpoint.h: Same.
2512 * btrace.h: Same.
2513 * c-varobj.c: Same.
2514 * cli/cli-decode.c: Same.
2515 * cli/cli-script.c: Same.
2516 * cli/cli-utils.h: Same.
2517 * coff-pe-read.c: Same.
2518 * coffread.c: Same.
2519 * compile/compile-cplus-symbols.c: Same.
2520 * compile/compile-object-run.c: Same.
2521 * completer.c: Same.
2522 * corelow.c: Same.
2523 * cp-support.c: Same.
2524 * demangle.c: Same.
2525 * dwarf-index-write.c: Same.
2526 * dwarf2-frame.c: Same.
2527 * dwarf2-frame.h: Same.
2528 * eval.c: Same.
2529 * frame-base.h: Same.
2530 * frame.h: Same.
2531 * gdbcmd.h: Same.
2532 * gdbtypes.h: Same.
2533 * gnu-nat.c: Same.
2534 * guile/scm-objfile.c: Same.
2535 * i386-tdep.c: Same.
2536 * i386-tdep.h: Same.
2537 * infcall.c: Same.
2538 * infcall.h: Same.
2539 * linux-nat.c: Same.
2540 * m68k-tdep.c: Same.
2541 * macroexp.c: Same.
2542 * memattr.c: Same.
2543 * mi/mi-cmd-disas.c: Same.
2544 * mi/mi-getopt.h: Same.
2545 * mi/mi-main.c: Same.
2546 * minsyms.c: Same.
2547 * nat/aarch64-sve-linux-sigcontext.h: Same.
2548 * objfiles.h: Same.
2549 * ppc-linux-nat.c: Same.
2550 * ppc-linux-tdep.c: Same.
2551 * ppc-tdep.h: Same.
2552 * progspace.h: Same.
2553 * prologue-value.h: Same.
2554 * python/py-evtregistry.c: Same.
2555 * python/py-instruction.h: Same.
2556 * record-btrace.c: Same.
2557 * record-full.c: Same.
2558 * remote.c: Same.
2559 * rs6000-tdep.c: Same.
2560 * ser-tcp.c: Same.
2561 * sol-thread.c: Same.
2562 * sparc-sol2-tdep.c: Same.
2563 * sparc64-tdep.c: Same.
2564 * stabsread.c: Same.
2565 * symfile.c: Same.
2566 * symtab.h: Same.
2567 * target.c: Same.
2568 * tracepoint.c: Same.
2569 * tui/tui-data.h: Same.
2570 * tui/tui-io.c: Same.
2571 * tui/tui-win.c: Same.
2572 * tui/tui.c: Same.
2573 * unittests/rsp-low-selftests.c: Same.
2574 * user-regs.h: Same.
2575 * utils.c: Same.
2576 * utils.h: Same.
2577 * valarith.c: Same.
2578 * valops.c: Same.
2579 * valprint.c: Same.
2580 * valprint.h: Same.
2581 * value.c: Same.
2582 * value.h: Same.
2583 * varobj.c: Same.
2584 * x86-nat.h: Same.
2585 * xtensa-tdep.c: Same.
2586
25872019-10-25 Ali Tamur <tamur@google.com>
2588
2589 * charset.c (find_charset_names): Reflect API change.
2590
25912019-10-25 Christian Biesinger <cbiesinger@google.com>
2592
2593 * symtab.c (struct demangled_name_entry): Change demangled name
2594 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2595 part of the struct anymore.
2596 (symbol_set_names): No longer obstack allocate + copy the demangled
2597 name, just store the allocated name from bfd.
2598
25992019-10-25 Tom Tromey <tromey@adacore.com>
2600
2601 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2602 (bsearch_cie_cmp, add_cie): Remove.
2603 (find_cie): Reimplement.
2604 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2605 (dwarf2_build_frame_info): Update.
2606
26072019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2608
2609 PR gdb/25126
2610 * symfile.c (reread_symbols): Call forget_cached_source_info to
2611 clear the stale source cache.
2612
26132019-10-24 Christian Biesinger <cbiesinger@google.com>
2614
2615 * configure: Regenerate.
2616 * configure.ac: Remove code that sets python_has_threads.
2617
26182019-10-24 Christian Biesinger <cbiesinger@google.com>
2619
2620 * config.in: Regenerate.
2621 * configure: Regenerate.
2622 * configure.ac: Remove the code that uses sed to get the python
2623 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2624
26252019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2626
2627 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2628 error paths.
2629
26302019-10-23 Tom Tromey <tom@tromey.com>
2631
2632 * arc-tdep.c: Remove ".." from include.
2633 * frv-tdep.c: Remove ".." from include.
2634 * lm32-tdep.c: Remove ".." from include.
2635 * microblaze-tdep.c: Remove ".." from include.
2636 * or1k-tdep.h: Remove ".." from include.
2637 * s12z-tdep.c: Remove ".." from include.
2638 * Makefile.in (OPCODES_CFLAGS): Add comment.
2639 (TOP_CFLAGS): New variable.
2640 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2641
26422019-10-23 Tom Tromey <tom@tromey.com>
2643
2644 * Makefile.in (READLINE_DIR): Update.
2645
26462019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2647
2648 * infcall.c (call_function_by_hand_dummy): Fix the function
2649 comment. And extract out a code section into...
2650 (reserve_stack_space): ...this new function.
2651
26522019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2653
2654 * infcall.c (value_arg_coerce): Remove an unused parameter.
2655 (call_function_by_hand_dummy): Update the call to
2656 'value_arg_coerce'.
2657
26582019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2659
2660 * infcall.c (call_function_by_hand_dummy): Refactor.
2661
26622019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2663
2664 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2665
26662019-10-23 Tom Tromey <tom@tromey.com>
2667
2668 * configure: Rebuild.
2669 * configure.ac: Don't check for sigprocmask.
2670 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2671
26722019-10-23 Tom Tromey <tom@tromey.com>
2673
2674 * configure: Rebuild.
2675 * acinclude.m4: Use m4_include, not sinclude.
2676
26772019-10-23 Tom de Vries <tdevries@suse.de>
2678
2679 PR breakpoints/24687
2680 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2681
26822019-10-22 Christian Biesinger <cbiesinger@google.com>
2683
2684 * symtab.c (struct demangled_name_entry) <language>: Change from
2685 bitfield to regular variable.
2686
26872019-10-22 Christian Biesinger <cbiesinger@google.com>
2688
2689 * symtab.c (struct demangled_name_entry): Add a constructor.
2690 (free_demangled_name_entry): New function to call the destructor
2691 for demangled_name_entry.
2692 (create_demangled_names_hash): Pass free_demangled_name_entry to
2693 htab_create_alloc.
2694 (symbol_set_names): Call placement new for demangled_name_entry.
2695 * utils.c: No longer include xxhash.h here, now that fast_hash
2696 is inlined in the header.
2697 * utils.h: Instead, include it here.
2698
26992019-10-22 Christian Biesinger <cbiesinger@google.com>
2700
2701 * Makefile.in: Link with libxxhash.
2702 * config.in: Regenerate.
2703 * configure: Regenerate.
2704 * configure.ac: Search for libxxhash.
2705 * utils.c (fast_hash): Use xxhash if present.
2706
27072019-10-22 Christian Biesinger <cbiesinger@google.com>
2708
2709 * utils.h (fast_hash): New function.
2710 * symtab.c (hash_demangled_name_entry): Call new function
2711 fast_hash.
2712
27132019-10-22 Christian Biesinger <cbiesinger@google.com>
2714
2715 * symtab.c (struct demangled_name_entry): Change type of mangled
2716 to gdb::string_view. Also adds a constructor that takes the
2717 mangled name.
2718 (hash_demangled_name_entry): Update.
2719 (eq_demangled_name_entry): Update.
2720 (free_demangled_name_entry): New function to call the destructor
2721 now that this is not a POD anymore.
2722 (create_demangled_names_hash): Pass free_demangled_name_entry to
2723 htab_create_alloc.
2724 (symbol_set_names): Update.
2725
27262019-10-21 Ali Tamur <tamu@google.com>
2727
2728 * dwarf2read.c (dir_index): Change type.
2729 (file_name_index): Likewise.
2730 (line_header::include_dir_at): Change comment and implementation on
2731 whether it is DWARF 5.
2732 (line_header::is_valid_file_index): New function.
2733 (line_header::file_name_at): Change comment and implementation on
2734 whether it is DWARF 5.
2735 (line_header::file_names): Change to private field renamed as
2736 m_file_names and introduce a new accessor method.
2737 (line_header::file_names_size): New method.
2738 (line_header::include_dirs): Change to private field and rename as
2739 m_include_dirs.
2740 (dw2_get_file_names_reader): Define local var at a smaller scope and
2741 reflect API change.
2742 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2743 (process_structure_scope): Likewise.
2744 (line_header::add_include_dir): Change message and reflect renaming.
2745 (line_header::add_file_name): Likewise.
2746 (read_formatted_entries): Handle DW_FORM_data16.
2747 (dwarf_decode_line_header): Fix line header length calculation.
2748 (psymtab_include_file_name): Change comment and API.
2749 (lnp_state_machine::m_file): Update comment and reflect type change.
2750 (lnp_state_machine::record_line): Reflect type change.
2751 (dwarf_decode_lines): Reflect API change.
2752 (file_file_name): Likewise.
2753 (file_full_name): Likewise.
2754
27552019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2756
2757 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2758
27592019-10-21 Tom Tromey <tom@tromey.com>
2760
2761 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2762
27632019-10-21 Tom Tromey <tom@tromey.com>
2764
2765 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2766 NM_H. Use AC_CONFIG_LINKS.
2767 * configure: Rebuild.
2768 * Makefile.in (NM_H): New variable.
2769 (generated_files): Add NM_H. Remove gcore.
2770 (nm.h, stamp-nmh): New targets.
2771
27722019-10-20 Tom Tromey <tom@tromey.com>
2773
2774 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2775 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2776 obsolete comment.
2777 (put_objfile_before): Now static.
2778
27792019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2780
2781 * gdbsupport/common-utils.h (startswith): Change return type to
2782 bool.
2783
27842019-10-19 Christian Biesinger <cbiesinger@google.com>
2785
2786 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2787 * breakpoint.c (bp_locations_compare): Rename to...
2788 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2789 (update_global_location_list): Use std::sort instead of qsort.
2790 * buildsym.c (compare_line_numbers): Rename to...
2791 (lte_is_less_than): ...this, and change to std::sort semantics.
2792 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2793 instead of qsort.
2794 * disasm.c (compare_lines): Rename to...
2795 (line_is_less_than): ...this, and change to std::sort semantics.
2796 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2797 of qsort.
2798 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2799 (fde_is_less_than): ...this, and change to std::sort semantics.
2800 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2801 * mdebugread.c (compare_blocks):
2802 (block_is_less_than): ...this, and change to std::sort semantics.
2803 (sort_blocks): Call std::sort instead of qsort.
2804 * objfiles.c (qsort_cmp): Rename to...
2805 (sort_cmp): ...this, and change to std::sort semantics.
2806 (update_section_map): Call std::sort instead of qsort.
2807 * remote.c (compare_pnums): Remove.
2808 (map_regcache_remote_table): Call std::sort instead of qsort.
2809 * utils.c (compare_positive_ints): Remove.
2810 * utils.h (compare_positive_ints): Remove.
2811 * xcoffread.c (compare_lte): Remove.
2812 (arrange_linetable): Call std::sort instead of qsort.
2813
28142019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2815
2816 * symfile.c (init_entry_point_info): Fix typo.
2817 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2818
28192019-10-18 Tom de Vries <tdevries@suse.de>
2820
2821 * aarch64-tdep.c: Fix typos in comments.
2822 * ada-lang.c: Same.
2823 * ada-tasks.c: Same.
2824 * alpha-tdep.c: Same.
2825 * alpha-tdep.h: Same.
2826 * amd64-nat.c: Same.
2827 * amd64-windows-tdep.c: Same.
2828 * arc-tdep.c: Same.
2829 * arc-tdep.h: Same.
2830 * arch-utils.c: Same.
2831 * arm-nbsd-tdep.c: Same.
2832 * arm-tdep.c: Same.
2833 * ax-gdb.c: Same.
2834 * blockframe.c: Same.
2835 * btrace.c: Same.
2836 * c-varobj.c: Same.
2837 * coff-pe-read.c: Same.
2838 * coffread.c: Same.
2839 * cris-tdep.c: Same.
2840 * darwin-nat.c: Same.
2841 * dbxread.c: Same.
2842 * dcache.c: Same.
2843 * disasm.c: Same.
2844 * dtrace-probe.c: Same.
2845 * dwarf-index-write.c: Same.
2846 * dwarf2-frame-tailcall.c: Same.
2847 * dwarf2-frame.c: Same.
2848 * dwarf2read.c: Same.
2849 * eval.c: Same.
2850 * exceptions.c: Same.
2851 * fbsd-tdep.c: Same.
2852 * findvar.c: Same.
2853 * frame.c: Same.
2854 * frv-tdep.c: Same.
2855 * gnu-v3-abi.c: Same.
2856 * go32-nat.c: Same.
2857 * h8300-tdep.c: Same.
2858 * hppa-tdep.c: Same.
2859 * i386-linux-tdep.c: Same.
2860 * i386-tdep.c: Same.
2861 * ia64-libunwind-tdep.c: Same.
2862 * ia64-tdep.c: Same.
2863 * infcmd.c: Same.
2864 * infrun.c: Same.
2865 * linespec.c: Same.
2866 * linux-nat.c: Same.
2867 * linux-thread-db.c: Same.
2868 * machoread.c: Same.
2869 * mdebugread.c: Same.
2870 * mep-tdep.c: Same.
2871 * mn10300-tdep.c: Same.
2872 * namespace.c: Same.
2873 * objfiles.c: Same.
2874 * opencl-lang.c: Same.
2875 * or1k-tdep.c: Same.
2876 * osabi.c: Same.
2877 * ppc-linux-nat.c: Same.
2878 * ppc-linux-tdep.c: Same.
2879 * ppc-sysv-tdep.c: Same.
2880 * printcmd.c: Same.
2881 * procfs.c: Same.
2882 * record-btrace.c: Same.
2883 * record-full.c: Same.
2884 * remote-fileio.c: Same.
2885 * remote.c: Same.
2886 * rs6000-tdep.c: Same.
2887 * s12z-tdep.c: Same.
2888 * score-tdep.c: Same.
2889 * ser-base.c: Same.
2890 * ser-go32.c: Same.
2891 * skip.c: Same.
2892 * sol-thread.c: Same.
2893 * solib-svr4.c: Same.
2894 * solib.c: Same.
2895 * source.c: Same.
2896 * sparc-nat.c: Same.
2897 * sparc-sol2-tdep.c: Same.
2898 * sparc-tdep.c: Same.
2899 * sparc64-tdep.c: Same.
2900 * stabsread.c: Same.
2901 * stack.c: Same.
2902 * symfile.c: Same.
2903 * symtab.c: Same.
2904 * target-descriptions.c: Same.
2905 * target-float.c: Same.
2906 * thread.c: Same.
2907 * utils.c: Same.
2908 * valops.c: Same.
2909 * valprint.c: Same.
2910 * value.c: Same.
2911 * varobj.c: Same.
2912 * windows-nat.c: Same.
2913 * xcoffread.c: Same.
2914 * xstormy16-tdep.c: Same.
2915 * xtensa-tdep.c: Same.
2916
29172019-10-17 Tom Tromey <tromey@adacore.com>
2918
2919 * configure: Rebuild.
2920 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2921 in AC_CONFIG_FILES invocation.
2922 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2923 new-style config.status invocation.
2924
29252019-10-17 Tom de Vries <tdevries@suse.de>
2926
2927 * arm-nbsd-nat.c: Fix typos in comments.
2928 * arm-tdep.c: Same.
2929 * darwin-nat-info.c: Same.
2930 * dwarf2read.c: Same.
2931 * elfread.c: Same.
2932 * event-top.c: Same.
2933 * findvar.c: Same.
2934 * gdbtypes.c: Same.
2935 * hppa-tdep.c: Same.
2936 * i386-tdep.c: Same.
2937 * jit.c: Same.
2938 * main.c: Same.
2939 * mdebugread.c: Same.
2940 * moxie-tdep.c: Same.
2941 * nto-procfs.c: Same.
2942 * osabi.c: Same.
2943 * ppc-linux-tdep.c: Same.
2944 * remote.c: Same.
2945 * riscv-tdep.c: Same.
2946 * s390-tdep.c: Same.
2947 * sh-tdep.c: Same.
2948 * sparc-linux-tdep.c: Same.
2949 * sparc-nat.c: Same.
2950 * stack.c: Same.
2951 * target-descriptions.c: Same.
2952 * top.c: Same.
2953 * varobj.c: Same.
2954
29552019-10-16 Tom Tromey <tom@tromey.com>
2956
2957 * objfiles.h (struct objfile) <original_name>: Now const.
2958
29592019-10-16 Christian Biesinger <cbiesinger@google.com>
2960
2961 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2962 pass on to sigsetjmp's second argument.
2963 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2964
29652019-10-16 Keith Seitz <keiths@redhat.com>
2966
2967 PR gdb/23567
2968 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2969 sections whose size is greater than the file size.
2970
29712019-10-16 Jim Wilson <jimw@sifive.com>
2972
2973 * riscv-tdep.c (riscv_gcc_target_options): New.
2974 (riscv_gnu_triplet_regexp): New.
2975 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2976 set_gdbarch_gnu_triplet_regexp.
2977
29782019-10-16 Christian Biesinger <cbiesinger@google.com>
2979
2980 * Makefile.in: Add xml-builtin.h.
2981 * features/feature_to_c.sh: Add an include for xml-builtin.h
2982 to ensure that the compiler checks that the types match.
2983 * xml-builtin.h: New file.
2984 * xml-support.c (fetch_xml_builtin): Add missing const.
2985 * xml-support.h: Remove declaration of xml_builtins.
2986
29872019-10-16 Tom de Vries <tdevries@suse.de>
2988
2989 PR tdep/25096
2990 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2991 (amd64_classify_aggregate): ... here.
2992 (amd64_classify_aggregate_field): Handled fiels of nested structs
2993 recursively.
2994
29952019-10-16 Tom de Vries <tdevries@suse.de>
2996
2997 PR tdep/24104
2998 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2999 that handles 'theclass'.
3000
30012019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3002
3003 * linespec.c (decode_digits_ordinary): Update comment.
3004 * make-target-delegates: No longer need to handle VEC case.
3005 * memrange.c (normalize_mem_ranges): Update comment.
3006 * namespace.c (add_using_directive): Update comment.
3007 * objc-lang.c (uniquify_strings): Update comment.
3008 * ppc-linux-nat.c (struct thread_points): Update comment.
3009 * probe.h (find_probes_in_objfile): Update comment.
3010 * target.h (enum flash_preserve_mode): Update comment.
3011 * varobj.c (varobj_restrict_range): Update comment.
3012 * varobj.h (varobj_list_children): Update comment.
3013
30142019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3015
3016 * Makefile.in: Remove references to vec.h and vec.c.
3017 * aarch64-tdep.c: No longer include vec.h.
3018 * ada-lang.c: Likewise.
3019 * ada-lang.h: Likewise.
3020 * arm-tdep.c: Likewise.
3021 * ax.h: Likewise.
3022 * breakpoint.h: Likewise.
3023 * charset.c: Likewise.
3024 * cp-support.h: Likewise.
3025 * dtrace-probe.c: Likewise.
3026 * dwarf2read.c: Likewise.
3027 * extension.h: Likewise.
3028 * gdb_bfd.c: Likewise.
3029 * gdbsupport/gdb_vecs.h: Likewise.
3030 * gdbsupport/vec.c: Remove.
3031 * gdbsupport/vec.h: Remove.
3032 * gdbthread.h: Likewise.
3033 * guile/scm-type.c: Likewise.
3034 * inline-frame.c: Likewise.
3035 * machoread.c: Likewise.
3036 * memattr.c: Likewise.
3037 * memrange.h: Likewise.
3038 * namespace.h: Likewise.
3039 * nat/linux-btrace.h: Likewise.
3040 * osdata.c: Likewise.
3041 * parser-defs.h: Likewise.
3042 * progspace.h: Likewise.
3043 * python/py-type.c: Likewise.
3044 * record-btrace.c: Likewise.
3045 * rust-exp.y: Likewise.
3046 * solib-target.c: Likewise.
3047 * stap-probe.c: Likewise.
3048 * target-descriptions.c: Likewise.
3049 * target-memory.c: Likewise.
3050 * target.h: Likewise.
3051 * varobj.c: Likewise.
3052 * varobj.h: Likewise.
3053 * xml-support.h: Likewise.
3054
30552019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3056
3057 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3058 Update for new std::vector based implementation.
3059 (process_psymtab_comp_unit_reader): Likewise.
3060 (scan_partial_symbols): Likewise.
3061 (recursively_compute_inclusions): Likewise.
3062 (compute_compunit_symtab_includes): Likewise.
3063 (process_imported_unit_die): Likewise.
3064 (queue_and_load_dwo_tu): Likewise.
3065 (follow_die_sig_1): Likewise.
3066 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3067 (typedef dwarf2_per_cu_ptr): Remove.
3068 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3069 function.
3070 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3071 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3072 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3073 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3074 std::vector.
3075
30762019-10-15 Tom Tromey <tromey@adacore.com>
3077
3078 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3079 TID.
3080
30812019-10-15 Tom Tromey <tromey@adacore.com>
3082
3083 * windows-nat.c (windows_nat_target::fetch_registers)
3084 (windows_nat_target::store_registers): Rename "pid" to "tid".
3085
30862019-10-15 Tom Tromey <tromey@adacore.com>
3087
3088 * gdbarch.h, gdbarch.c: Rebuild.
3089 * gdbarch.sh (gcc_target_options): Change return type to
3090 std::string.
3091 * compile/compile.c (get_args): Update.
3092 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3093 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3094 std::string.
3095 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3096 std::string.
3097 * arch-utils.c (default_gcc_target_options): Return std::string.
3098 * arch-utils.h (default_gcc_target_options): Return std::string.
3099 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3100
31012019-10-15 Christian Biesinger <cbiesinger@google.com>
3102
3103 * breakpoint.c (breakpoint_chain): Make static.
3104 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3105 of accessing breakpoint_chain.
3106
31072019-10-15 Christian Biesinger <cbiesinger@google.com>
3108
3109 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3110 to a gdb::function_view and return value to bool.
3111 * breakpoint.h (iterate_over_breakpoints): Likewise.
3112 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3113 (pop_dummy_frame): Update.
3114 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3115 (gdbscm_breakpoints): Update.
3116 * python/py-breakpoint.c (build_bp_list): Update.
3117 (gdbpy_breakpoints): Update.
3118 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3119 Update.
3120 (bpfinishpy_handle_stop): Update.
3121 (bpfinishpy_handle_exit): Update.
3122 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3123 (svr4_update_solib_event_breakpoints): Update.
3124
31252019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3126
3127 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3128 when unwrapping single-field structs.
3129
31302019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3131
3132 * dwarf2read.c: Remove includes.
3133
31342019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3135
3136 * ui-out.c (ui_out::call_do_message): Silence
3137 -Wformat-nonliteral warning.
3138
31392019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3140
3141 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3142 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3143 include: readline/tilde.h.
3144
31452019-10-12 Christian Biesinger <cbiesinger@google.com>
3146
3147 * remote.c (remote_target::get_trace_status): Remove declaration of
3148 trace_regblock_size.
3149
31502019-10-12 Christian Biesinger <cbiesinger@google.com>
3151
3152 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3153 (show_user): Remove declaration of cmdlist.
3154 * cli/cli-cmds.h (max_user_call_depth): Declare.
3155 * cli/cli-script.c (execute_user_command): Remove declaration
3156 of max_user_call_depth.
3157
31582019-10-11 Jim Wilson <jimw@sifive.com>
3159
3160 * gdbsupport/print-utils.h (pulongest): Fix comment.
3161 (plongest): Likewise.
3162 (phex): Add missing comment, mention leading zeros.
3163 (phex_nz): Add mention of no leading zeros to comment.
3164
3165 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3166 plongest instead of unsigned long long cast.
3167
31682019-10-10 Christian Biesinger <cbiesinger@google.com>
3169
3170 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3171 for external_editor_command and gdbtk_test.
3172
31732019-10-10 Christian Biesinger <cbiesinger@google.com>
3174
3175 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3176 * varobj.c (varobjdebug): Move comment to...
3177 * varobj.h (varobjdebug): ...here, and declare.
3178
31792019-10-09 Tom Tromey <tom@tromey.com>
3180
3181 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3182 erase_data_content.
3183
31842019-10-09 Tom Tromey <tom@tromey.com>
3185
3186 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3187 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3188 * tui/tui-command.c (tui_cmd_window::resize)
3189 (tui_refresh_cmd_win): Update.
3190 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3191 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3192 * tui/tui-data.c (~tui_gen_win_info): Remove.
3193 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3194 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3195 (tui_redisplay_readline, tui_mld_flush)
3196 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3197 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3198 (tui_data_window::erase_data_content)
3199 (tui_data_item_window::rerender)
3200 (tui_data_item_window::refresh_window): Update.
3201 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3202 (box_win, tui_gen_win_info::make_window)
3203 (tui_gen_win_info::make_visible): Update.
3204 (tui_delete_win): Remove.
3205 * tui/tui-winsource.c
3206 (tui_source_window_base::do_erase_source_content): Update.
3207 (tui_show_source_line, tui_source_window_base::update_tab_width)
3208 (tui_source_window_base::update_exec_info): Update.
3209 * tui/tui-data.h (struct curses_deleter): New.
3210 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3211 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3212
32132019-10-09 Tom Tromey <tom@tromey.com>
3214
3215 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3216
32172019-10-09 Tom Tromey <tom@tromey.com>
3218
3219 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3220 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3221
32222019-10-09 Tom Tromey <tom@tromey.com>
3223
3224 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3225 window height directly.
3226 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3227 declare.
3228 * tui/tui-layout.c (tui_default_win_height): Remove.
3229 (tui_default_win_viewport_height): Remove.
3230
32312019-10-09 Tom Tromey <tom@tromey.com>
3232
3233 * tui/tui.h: Remove comments.
3234
32352019-10-09 Tom de Vries <tdevries@suse.de>
3236
3237 * python/lib/gdb/printer/bound_registers.py: Use
3238 '^builtin_type_bound128' as regexp argument for
3239 add_builtin_pretty_printer.
3240
32412019-10-09 Christian Biesinger <cbiesinger@google.com>
3242
3243 * guile/guile.c (guile_extension_script_ops): Remove forward
3244 declaration and mark as static.
3245 (guile_script_ops): Likewise.
3246 (extension_language_guile): Move further down in the file so
3247 it can reference the definitions for guile_{extension_,}script_ops.
3248
32492019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3250
3251 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3252 except SORTL, DFLTCC, and KDSA.
3253
32542019-10-08 Tom Tromey <tromey@adacore.com>
3255
3256 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3257 (struct safe_symbol_file_add_args): Remove.
3258
32592019-10-08 Tom Tromey <tromey@adacore.com>
3260
3261 * windows-nat.c: Don't include buildsym-legacy.h.
3262
32632019-10-08 Tom Tromey <tromey@adacore.com>
3264
3265 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3266
32672019-10-08 Christian Biesinger <cbiesinger@google.com>
3268
3269 * gdbtypes.c (overload_debug): Move comment to header.
3270 * gdbtypes.h (overload_debug): Declare.
3271 * valops.c: Remove declaration of overload_debug, instead
3272 include gdbtypes.h.
3273
32742019-10-08 Christian Biesinger <cbiesinger@google.com>
3275
3276 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3277 through _().
3278 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3279 move comment...
3280 * language.h (lang_frame_mismatch_warn): ... here. Also add
3281 declaration.
3282 * top.c (lang_frame_mismatch_warn): Remove declaration.
3283 (check_frame_language_change): Pass lang_frame_mismatch_warn
3284 through _().
3285
32862019-10-07 Christian Biesinger <cbiesinger@google.com>
3287
3288 * c-lang.h (vtbl_ptr_name): Declare.
3289 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3290 it from the header.
3291 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3292
32932019-10-07 Christian Biesinger <cbiesinger@google.com>
3294
3295 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3296 gdb_static_assert.
3297
32982019-10-07 Weimin Pan <weimin.pan@oracle.com>
3299
3300 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3301 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3302 * ctfread.c: New file.
3303 * ctfread.h: New file.
3304 * elfread.c: Include ctfread.h.
3305 (struct elfinfo text_p): New member ctfsect.
3306 (elf_locate_sections): Mark CTF section.
3307 (elf_symfile_read): Call elfctf_build_psymtabs.
3308 * Makefile.in (LIBCTF): Add.
3309 (CLIBS): Use it.
3310 (CDEPS): Likewise.
3311 (DIST): Add ctfread.c.
3312
33132019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3314
3315 * ctfread.c (struct nextfield): Renamed to ...
3316 (struct ctf_nextfield): ... this.
3317 (struct field_info): Renamed to ...
3318 (strut ctf_field_info): ... this.
3319 (attach_fields_to_type): Update for renamed structures.
3320 (ctf_add_member_cb): Likewise.
3321 (ctf_add_enum_member_cb): Likewise.
3322 (process_struct_members): Likewise.
3323 (process_enum_type): Likewise.
3324
33252019-10-07 Weimin Pan <weimin.pan@oracle.com>
3326
3327 * tracectf.h: Rename, was ctf.h.
3328 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3329 * tracefile.c: Likewise.
3330 * tracepoint.c: Remove unused include ctf.h.
3331 * mi/mi-main.c: Likewise.
3332 * Makefile.in Replace ctf.c with tracectf.c.
3333
33342019-10-06 Joel Brobecker <brobecker@adacore.com>
3335
3336 * version.in: Change version number to "9.0.50.DATE-git".
3337
33382019-10-03 Tom Tromey <tom@tromey.com>
3339
3340 PR rust/24976:
3341 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3342
33432019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3344
3345 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3346 cp_search_name_hash.
3347 * NEWS: Add entry about nested function support.
3348
33492019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3350 Andrew Burgess <andrew.burgess@embecosm.com>
3351
3352 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3353 for nested static variables when searchin VAR_DOMAIN.
3354 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3355 global scope, update comment.
3356 (add_partial_subprogram): Call add_partial_subprogram recursively
3357 for nested subroutines when processinng Fortran.
3358 (load_partial_dies): Process the child entities of a subprogram
3359 when processing Fortran.
3360 (partial_die_parent_scope): Handle building scope
3361 for Fortran nested functions.
3362 (process_die): Record that nested functions have a scope.
3363 (new_symbol): Always record Fortran subprograms on the global
3364 symbol list.
3365 (determine_prefix): How to build the prefix for Fortran
3366 subprograms.
3367
33682019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3369
3370 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3371 have just sent the thread a SIGSTOP and are waiting for it to
3372 arrive.
3373
33742019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3375
3376 * btrace.c (btrace_add_pc): Remove whitespace before the template
3377 parameter in 'std::vector <...>'.
3378 (parse_xml_btrace_block): Likewise.
3379 (btrace_maint_decode_pt): Likewise.
3380 (btrace_maint_update_packets): Likewise.
3381 (btrace_maint_print_packets): Likewise.
3382 * btrace.h (struct btrace_maint_info): Likewise.
3383 * dwarf2read.c (struct type_unit_group): Likewise.
3384 (build_type_psymtabs_reader): Likewise.
3385 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3386 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3387 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3388
33892019-10-03 Tom de Vries <tdevries@suse.de>
3390
3391 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3392 the first line of the help text for set/show style metadata.
3393
33942019-10-02 Tom Tromey <tromey@adacore.com>
3395
3396 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3397 * gdbsupport/common-inferior.c: New file.
3398 * infcmd.c (startup_with_shell): Don't define.
3399 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3400 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3401 * inferior.h (startup_with_shell): Don't declare.
3402
34032019-10-02 Christian Biesinger <cbiesinger@google.com>
3404
3405 * gdbsupport/gdb_assert.h: Include errors.h.
3406 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3407
34082019-10-02 Tom Tromey <tromey@adacore.com>
3409
3410 * NEWS: Add $_ada_exception entry.
3411 * ada-lang.c (struct ada_catchpoint): Add constructor.
3412 <m_kind>: New member.
3413 (allocate_location_exception, re_set_exception): Remove
3414 "ex" parameter.
3415 (should_stop_exception): Compute $_ada_exception.
3416 (check_status_exception, print_it_exception)
3417 (print_one_exception, print_mention_exception): Remove
3418 "ex" parameter.
3419 (allocate_location_catch_exception, re_set_catch_exception)
3420 (check_status_exception, print_it_catch_exception)
3421 (print_one_catch_exception, print_mention_catch_exception)
3422 (print_recreate_catch_exception)
3423 (allocate_location_catch_exception_unhandled)
3424 (re_set_catch_exception_unhandled)
3425 (check_status_exception, print_it_catch_exception_unhandled)
3426 (print_one_catch_exception_unhandled)
3427 (print_mention_catch_exception_unhandled)
3428 (print_recreate_catch_exception_unhandled)
3429 (allocate_location_catch_assert, re_set_catch_assert)
3430 (check_status_assert, print_it_catch_assert)
3431 (print_one_catch_assert, print_mention_catch_assert)
3432 (print_recreate_catch_assert)
3433 (allocate_location_catch_handlers, re_set_catch_handlers)
3434 (check_status_handlers, print_it_catch_handlers)
3435 (print_one_catch_handlers, print_mention_catch_handlers)
3436 (print_recreate_catch_handlers): Remove.
3437 (create_ada_exception_catchpoint): Update.
3438 (initialize_ada_catchpoint_ops): Update.
3439
34402019-10-02 Tom Tromey <tromey@adacore.com>
3441
3442 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3443 (create_excep_cond_exprs): Simplify exception string computation.
3444 (ada_exception_catchpoint_cond_string): Likewise.
3445
34462019-10-02 Tom Tromey <tromey@adacore.com>
3447
3448 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3449 * ada-lang.c (lesseq_defined_than): Handle
3450 LOC_STATIC.
3451 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3452 parameter.
3453 (dwarf2_has_info): Likewise.
3454 (new_symbol): Set maybe_copied on symbol when
3455 appropriate.
3456 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3457 parameter.
3458 <can_copy>: New member.
3459 * elfread.c (record_minimal_symbol): Set maybe_copied
3460 on symbol when appropriate.
3461 (elf_symfile_read): Update call to dwarf2_has_info.
3462 * minsyms.c (lookup_minimal_symbol_linkage): New
3463 function.
3464 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3465 * symtab.c (get_symbol_address, get_msymbol_address):
3466 New functions.
3467 * symtab.h (get_symbol_address, get_msymbol_address):
3468 Declare.
3469 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3470 maybe_copied.
3471 (struct symbol, struct minimal_symbol) <maybe_copied>:
3472 New member.
3473
34742019-10-02 Tom Tromey <tromey@adacore.com>
3475
3476 * source.c (struct current_source_location): New.
3477 (current_source_key): New global.
3478 (current_source_symtab, current_source_line)
3479 (current_source_pspace): Remove.
3480 (get_source_location): New function.
3481 (get_current_source_symtab_and_line)
3482 (set_default_source_symtab_and_line)
3483 (set_current_source_symtab_and_line)
3484 (clear_current_source_symtab_and_line, select_source_symtab)
3485 (info_source_command, print_source_lines_base)
3486 (info_line_command, search_command_helper, _initialize_source):
3487 Update.
3488
34892019-10-02 Tom Tromey <tromey@adacore.com>
3490
3491 * source.c (select_source_symtab): Don't call
3492 decode_line_with_current_source.
3493
34942019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3495
3496 * symtab.c (lookup_global_symbol): Search global block.
3497
34982019-10-02 Tom Tromey <tromey@adacore.com>
3499
3500 * coffread.c (process_coff_symbol): Update.
3501 * dwarf2read.c (var_decode_location, new_symbol): Update.
3502 * mdebugread.c (parse_symbol): Update.
3503 * objfiles.c (relocate_one_symbol): Update.
3504 * stabsread.c (define_symbol, fix_common_block)
3505 (scan_file_globals): Update.
3506 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3507 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3508 * xcoffread.c (process_xcoff_symbol): Update.
3509
35102019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3511
3512 * MAINTAINERS: Update my email address.
3513
35142019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3515
3516 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3517 std::vector.
3518 (build_type_psymtabs_reader): Update for std::vector.
3519 (build_type_psymtab_dependencies): Likewise.
3520 * dwarf2read.h: Remove use of DEF_VEC_P.
3521 (typedef sig_type_ptr): Delete.
3522
35232019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3524
3525 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3526 to std::vector.
3527 (btrace_maint_decode_pt): Likewise, and move allocation of the
3528 vector outside of the loop.
3529 (btrace_maint_update_packets): Update to handle change from VEC to
3530 std::vector.
3531 (btrace_maint_print_packets): Likewise.
3532 (maint_info_btrace_cmd): Likewise.
3533 * btrace.h: Remove use of DEF_VEC_O.
3534 (typedef btrace_pt_packet_s): Delete.
3535 (struct btrace_maint_info) <packets>: Change fromm VEC to
3536 std::vector.
3537 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3538
35392019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3540
3541 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3542 make accesses into the vector constant references.
3543 (btrace_add_pc): Update for std::vector.
3544 (btrace_stitch_bts): Likewise.
3545 (parse_xml_btrace_block): Likewise.
3546 (btrace_maint_update_packets): Likewise.
3547 (btrace_maint_print_packets): Likewise.
3548 (maint_info_btrace_cmd): Likewise.
3549 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3550 std::vector.
3551 (btrace_data::empty): Likewise.
3552 (btrace_data_append): Likewise.
3553 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3554 (typedef btrace_block_s): Delete.
3555 (struct btrace_block): Add constructor.
3556 (struct btrace_data_bts) <blocks>: Change to std::vector.
3557 * nat/linux-btrace.c (perf_event_read_bts): Update for
3558 std::vector.
3559 (linux_read_bts): Likewise.
3560
35612019-10-01 Tom Tromey <tom@tromey.com>
3562
3563 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3564
35652019-10-01 Tom Tromey <tom@tromey.com>
3566
3567 * stack.c (print_frame, info_frame_command_core): Use
3568 styled_string.
3569 * linux-thread-db.c (try_thread_db_load_1)
3570 (try_thread_db_load_from_pdir_1): Use styled_string.
3571 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3572 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3573 (maybe_print_unsupported_script_warning)
3574 (maybe_print_script_not_found_warning): Use styled_string.
3575 * ada-lang.c (user_select_syms): Use styled_string.
3576
35772019-10-01 Tom Tromey <tom@tromey.com>
3578
3579 * p-lang.c (pascal_printstr): Use metadata style.
3580 * value.c (show_convenience): Use metadata style.
3581 * valprint.c (valprint_check_validity, val_print_optimized_out)
3582 (val_print_not_saved, val_print_unavailable)
3583 (val_print_invalid_address, generic_val_print, val_print)
3584 (value_check_printable, val_print_array_elements): Use metadata
3585 style.
3586 * ui-out.h (class ui_out) <field_fmt>: New overload.
3587 <do_field_fmt>: Add style parameter.
3588 * ui-out.c (ui_out::field_fmt): New overload.
3589 * typeprint.c (type_print_unknown_return_type)
3590 (val_print_not_allocated, val_print_not_associated): Use metadata
3591 style.
3592 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3593 parameter.
3594 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3595 * tracepoint.c (tvariables_info_1): Use metadata style.
3596 * stack.c (print_frame_arg, print_frame_info, print_frame)
3597 (info_frame_command_core): Use metadata style.
3598 * skip.c (info_skip_command): Use metadata style.
3599 * rust-lang.c (rust_print_enum): Use metadata style.
3600 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3601 metadata style.
3602 * python/py-framefilter.c (py_print_single_arg): Use metadata
3603 style.
3604 * printcmd.c (do_one_display, print_variable_and_value): Use
3605 metadata style.
3606 * p-valprint.c (pascal_val_print)
3607 (pascal_object_print_value_fields): Use metadata style.
3608 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3609 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3610 parameter.
3611 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3612 * m2-valprint.c (m2_print_long_set): Use metadata style.
3613 * m2-typeprint.c (m2_print_type): Use metadata style.
3614 * infcmd.c (print_return_value_1): Use metadata style.
3615 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3616 * f-valprint.c (info_common_command_for_block): Use metadata
3617 style.
3618 * f-typeprint.c (f_type_print_base): Use metadata style.
3619 * expprint.c (print_subexp_standard): Use metadata style.
3620 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3621 * cli/cli-style.h (class cli_style_option): Add constructor.
3622 (metadata_style): Declare.
3623 * cli/cli-style.c (metadata_style): New global.
3624 (_initialize_cli_style): Register metadata style.
3625 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3626 parameter.
3627 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3628 * c-typeprint.c (c_type_print_base_struct_union)
3629 (c_type_print_base_1): Use metadata style.
3630 * breakpoint.c (watchpoint_value_print)
3631 (print_one_breakpoint_location): Use metadata style.
3632 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3633 style.
3634 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3635 style.
3636 * ada-valprint.c (val_print_packed_array_elements, printstr)
3637 (print_field_values, ada_val_print_ref, ada_val_print): Use
3638 metadata style.
3639 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3640 style.
3641 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3642 style.
3643 * ada-lang.c (user_select_syms): Use metadata style.
3644
36452019-10-01 Tom Tromey <tom@tromey.com>
3646
3647 * cli/cli-cmds.c (pwd_command): Style output.
3648
36492019-10-01 Pedro Alves <palves@redhat.com>
3650 Tom Tromey <tom@tromey.com>
3651
3652 * symtab.c (print_symbol_info): Use %ps.
3653 (print_msymbol_info): Use %ps.
3654 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3655 * printcmd.c (print_variable_and_value): Use %ps.
3656 * macrocmd.c (show_pp_source_pos): Use %ps.
3657 * infrun.c (print_exited_reason): Use ui_out::message.
3658 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3659 (describe_other_breakpoints): Use ui_out::message and new
3660 formats.
3661 (say_where): Use new formats.
3662 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3663 and new formats.
3664
36652019-10-01 Pedro Alves <palves@redhat.com>
3666 Tom Tromey <tom@tromey.com>
3667
3668 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3669 (test_gdb_formats): New function.
3670 (run_tests): Call it.
3671 (test_format_specifier): Update.
3672 * utils.h (fputs_filtered): Update comment.
3673 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3674 (fputs_styled_unfiltered): Declare.
3675 * utils.c (fputs_styled_unfiltered): New function.
3676 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3677 (vfprintf_filtered): Update.
3678 (vfprintf_unfiltered, vprintf_filtered): Update.
3679 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3680 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3681 disallow_ui_out_field>: New constants.
3682 (enum class field_kind): New.
3683 (struct base_field_s, struct signed_field_s): New.
3684 (signed_field): New function.
3685 (struct string_field_s): New.
3686 (string_field): New function.
3687 (struct styled_string_s): New.
3688 (styled_string): New function.
3689 (class ui_out) <message>: Add comment.
3690 <vmessage, call_do_message>: New methods.
3691 <do_message>: Add style parameter.
3692 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3693 methods.
3694 (ui_out::message): Rewrite.
3695 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3696 parameter.
3697 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3698 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3699 gdb_extensions parameter.
3700 (class format_piece): Add parameter to constructor.
3701 (n_int_args): New field.
3702 * gdbsupport/format.c (format_pieces::format_pieces): Add
3703 gdb_extensions parameter. Handle '*'.
3704 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3705 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3706 vfprintf_styled_no_gdbfmt.
3707 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3708 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3709 unfiltered output.
3710 * ui-style.h (struct ui_file_style) <ptr>: New method.
3711
37122019-10-01 Tom Tromey <tom@tromey.com>
3713
3714 * unittests/format_pieces-selftests.c: Update. Add final format.
3715 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3716 empty literal pieces.
3717
37182019-10-01 Tom Tromey <tom@tromey.com>
3719
3720 * ui-out.h (enum class ui_out_style_kind): Remove.
3721 (class ui_out) <field_string, field_stsream, do_field_string>:
3722 Change type of "style".
3723 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3724 (ui_out::field_string): Update.
3725 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3726 of "style".
3727 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3728 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3729 * stack.c (print_frame_arg, print_frame_info, print_frame):
3730 Update.
3731 * source.c (print_source_lines_base): Update.
3732 * solib.c (info_sharedlibrary_command): Update.
3733 * skip.c (info_skip_command): Update.
3734 * record-btrace.c (btrace_call_history_src_line)
3735 (btrace_call_history): Update.
3736 * python/py-framefilter.c (py_print_frame): Update.
3737 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3738 "style".
3739 * mi/mi-out.c (mi_ui_out::do_table_header)
3740 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3741 (mi_ui_out::do_field_string): Update.
3742 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3743 Update.
3744 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3745 "style".
3746 * cli-out.c (cli_ui_out::do_table_header)
3747 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3748 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3749 (cli_ui_out::do_field_fmt): Update.
3750 * breakpoint.c (print_breakpoint_location): Update.
3751 (update_static_tracepoint): Update.
3752
37532019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3754
3755 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3756 conversion of gdb_datadir.
3757 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3758 remove not needed c_str ().
3759
37602019-09-30 Ali Tamur <tamur@google.com>
3761
3762 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3763 (dwarf2_string_attr): Likewise.
3764
37652019-09-30 Ali Tamur <tamur@google.com>
3766
3767 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3768 (process_full_type_unit): Likewise.
3769 (dump_die_shallow): Likewise.
3770 (cu_debug_loc_section): Likewise.
3771
37722019-09-28 Christian Biesinger <cbiesinger@google.com>
3773
3774 * minsyms.c (compare_minimal_symbols): Rename to...
3775 (minimal_symbol_is_less_than): ...this, and adjust to STL
3776 conventions (return bool, take arguments as references)
3777 (minimal_symbol_reader::install): Call std::sort instead
3778 of qsort.
3779
37802019-09-29 Christian Biesinger <cbiesinger@google.com>
3781
3782 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3783 hash and why.
3784 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3785 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3786
37872019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3788
3789 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3790 * psympriv.h (add_psymbol_to_list): Move comment here and update
3791 it.
3792
37932019-09-29 Tom de Vries <tdevries@suse.de>
3794
3795 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3796 Use $tmpdir/$(basename "$output_file").dwz instead of
3797 "${output_file}.dwz".
3798
37992019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3800
3801 PR gdb/25045
3802 * hppa-linux-nat.c: Include gdbarch.h.
3803
38042019-09-26 Christian Biesinger <cbiesinger@google.com>
3805
3806 * blockframe.c (find_pc_partial_function): Change return type to bool.
3807 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3808 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3809 (stub_gnu_ifunc_resolve_name): Likewise.
3810 * symtab.c (compare_filenames_for_search): Likewise.
3811 (compare_glob_filenames_for_search): Likewise.
3812 (matching_obj_sections): Likewise.
3813 (symbol_matches_domain): Likewise.
3814 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3815 (find_line_pc): Change return type to bool.
3816 (find_line_pc_range): Likewise.
3817 (producer_is_realview): Likewise.
3818 * symtab.h (symbol_matches_domain): Likewise.
3819 (find_pc_partial_function): Likewise.
3820 (find_pc_line_pc_range): Likewise.
3821 (in_gnu_ifunc_stub): Likewise.
3822 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3823 (find_line_pc): Likewise.
3824 (find_line_pc_range): Likewise.
3825 (matching_obj_sections): Likewise.
3826 (find_line_symtab): Change out parameter to bool.
3827 (producer_is_realview): Change return type to bool.
3828 (compare_filenames_for_search): Likewise.
3829 (compare_glob_filenames_for_search): Likewise.
3830
38312019-09-26 Tom Tromey <tom@tromey.com>
3832
3833 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3834 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3835 * gdb_usleep.h: Remove.
3836 * gdb_usleep.c: Remove.
3837 * utils.c: Don't include gdb_usleep.h.
3838
38392019-09-26 Tom Tromey <tromey@adacore.com>
3840
3841 * python/py-type.c (type_to_type_object): Call check_typedef
3842 for stub types.
3843
38442019-09-26 Tom Tromey <tom@tromey.com>
3845
3846 * utils.h (initialize_utils): Don't declare.
3847 * top.c (gdb_init): Don't call initialize_utils.
3848 * utils.c (initialize_utils): Remove. Move contents...
3849 (_initialize_utils): ... here.
3850
38512019-09-25 Tom Tromey <tom@tromey.com>
3852
3853 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3854 * utils.h (make_hex_string): Don't declare.
3855 * utils.c (make_hex_string): Remove.
3856
38572019-09-24 Tom de Vries <tdevries@suse.de>
3858
3859 PR gdb/23815
3860 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3861 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3862
38632019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3864
3865 * NEWS: Mention new simulator port for PRU.
3866
38672019-09-23 Christian Biesinger <cbiesinger@google.com>
3868
3869 * ada-exp.y (write_object_remaining): Update.
3870 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3871 and eliminate the static buffer.
3872 (ada_decode_symbol): Update.
3873 (ada_la_decode): Update.
3874 (ada_sniff_from_mangled_name): Update.
3875 (is_valid_name_for_wild_match): Update.
3876 (ada_lookup_name_info::matches): Update and simplify.
3877 (name_matches_regex): Update.
3878 (ada_add_global_exceptions): Update.
3879 * ada-lang.h (ada_decode): Update signature.
3880 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3881 * dwarf-index-write.c (debug_names::insert): Update.
3882
38832019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3884
3885 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3886 formatting.
3887
38882019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3889
3890 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3891 Change "nonzero" to "true" in documentation.
3892
38932019-09-20 Christian Biesinger <cbiesinger@google.com>
3894
3895 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3896 (_initialize_darwin_solib): Don't set
3897 darwin_so_ops.lookup_lib_global_symbol.
3898 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3899 set_gdbarch_iterate_over_objfiles_in_search_order.
3900 (elf_lookup_lib_symbol): Rename to...
3901 (svr4_iterate_over_objfiles_in_search_order): this, and update
3902 to iterate semantics.
3903 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3904 * solib.c (solib_global_lookup): Remove.
3905 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3906 (solib_global_lookup): Remove.
3907 * symtab.c (lookup_global_or_static_symbol): Remove call to
3908 solib_global_lookup.
3909
39102019-09-20 Joel Brobecker <brobecker@adacore.com>
3911
3912 * NEWS: Move entries about default MI version now being
3913 version 3, and about the GDB/MI fix for multi-location
3914 breakpoints to the "since GDB 8.3" section.
3915
39162019-09-20 Joel Brobecker <brobecker@adacore.com>
3917
3918 GDB 8.3.1 released.
3919
39202019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3921
3922 * NEWS: Mention that Cell/B.E. debugging support was removed.
3923 * MAINTAINERS: Remove spu target.
3924
3925 * config/djgpp/fnchange.lst: Remove entries for removed files.
3926
3927 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3928 spu-multiarch.o, and spu-tdep.o.
3929 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3930 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3931 spu-multiarch.c, and spu-tdep.c.
3932 * spu-linux-nat.c: Remove file.
3933 * spu-multiarch.c: Remove file.
3934 * spu-tdep.c: Remove file.
3935 * spu-tdep.h: Remove file.
3936 * solib-spu.c: Remove file.
3937 * solib-spu.h: Remove file.
3938
3939 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3940 * configure.nat (spu-linux): Remove.
3941 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3942 solib-multiarch.o from gdb_target_obs.
3943 (spu*-*-*): Remove.
3944
3945 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3946 feature flag.
3947 (ppc_linux_no_features): Update.
3948 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3949 Cell/B.E. support.
3950 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3951 (tdesc_powerpc_cell64l): Likewise.
3952 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3953 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3954 Cell/B.E. support.
3955 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3956 Do not include "features/rs6000/powerpc-cell32l.c" or
3957 "features/rs6000/powerpc-cell64l.c".
3958 (ppc_linux_spu_section): Remove.
3959 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3960 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3961 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3962 (ppc_linux_spe_context_lookup): Remove.
3963 (ppc_linux_spe_context_inferior_created): Remove.
3964 (ppc_linux_spe_context_solib_loaded): Remove.
3965 (ppc_linux_spe_context_solib_unloaded): Remove.
3966 (ppc_linux_spe_context): Remove.
3967 (struct ppu2spu_cache): Remove.
3968 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3969 (struct ppu2spu_data): Remove.
3970 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3971 ppu2spu_unwind): Remove.
3972 (ppc_linux_init_abi): Remove Cell/B.E. support.
3973 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3974
3975 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3976 (rs6000/powerpc-cell64l-expedite): Likewise
3977 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3978 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3979 rs6000/powerpc-cell64l.xml.
3980 * features/rs6000/powerpc-cell32l.xml: Remove.
3981 * features/rs6000/powerpc-cell64l.xml: Likewise.
3982 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3983 * features/rs6000/powerpc-cell64l.c: Likewise.
3984 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3985 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3986 * regformats/reg-spu.dat: Remove.
3987
3988 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3989 * corelow.c (struct spuid_list): Remove.
3990 (add_to_spuid_list): Remove.
3991 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3992 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3993 (remote_protocol_features): Remove associated entries.
3994 (_initialize_remote): No longer initialize them.
3995 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3996 * linux-nat.c (SPUFS_MAGIC): Remove.
3997 (linux_proc_xfer_spu): Remove.
3998 (spu_enumerate_spu_ids): Remove.
3999 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4000 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4001 (linux_make_corefile_notes): No longer call it.
4002
4003 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4004 (cooked_write_test): Likewise.
4005
40062019-09-20 Tom Tromey <tom@tromey.com>
4007
4008 * NEWS: Mention case-sensitivity of TUI commands.
4009 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4010 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4011 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4012
40132019-09-20 Tom Tromey <tom@tromey.com>
4014
4015 * tui/tui-source.c (tui_source_window::set_contents): Use
4016 make_unique_xstrdup.
4017 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4018 make_unique_xstrdup.
4019
40202019-09-20 Tom Tromey <tom@tromey.com>
4021
4022 * tui/tui-data.c: Remove separator comments.
4023 * tui/tui-layout.c: Remove separator comments.
4024 * tui/tui-win.c: Remove separator comments.
4025 * tui/tui-wingeneral.c: Remove separator comments.
4026
40272019-09-20 Tom Tromey <tom@tromey.com>
4028
4029 * tui/tui.h (strcat_to_buf): Don't declare.
4030 * tui/tui.c (strcat_to_buf): Remove.
4031
40322019-09-20 Tom Tromey <tom@tromey.com>
4033
4034 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4035 from "fullname".
4036 * tui/tui-source.c (tui_source_window::set_contents)
4037 (tui_source_window::location_matches_p)
4038 (tui_source_window::maybe_update): Update.
4039
40402019-09-20 Tom Tromey <tom@tromey.com>
4041
4042 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4043 Update.
4044 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4045 prefix.
4046 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4047 (tui_data_window::line_from_reg_element_no)
4048 (tui_data_window::first_reg_element_no_inline)
4049 (tui_data_window::show_registers)
4050 (tui_data_window::show_register_group)
4051 (tui_data_window::display_registers_from)
4052 (tui_data_window::display_registers_from_line)
4053 (tui_data_window::first_data_item_displayed)
4054 (tui_data_window::delete_data_content_windows)
4055 (tui_data_window::erase_data_content)
4056 (tui_data_window::do_scroll_vertical)
4057 (tui_data_window::refresh_window)
4058 (tui_data_window::check_register_values): Update.
4059
40602019-09-20 Tom Tromey <tom@tromey.com>
4061
4062 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4063 (struct tui_locator_window) <full_name, proc_name>: Now
4064 std::string.
4065 * tui/tui-stack.c (tui_locator_window::make_status_line)
4066 (tui_locator_window::set_locator_fullname)
4067 (tui_locator_window::set_locator_info): Update.
4068 * tui/tui-source.c (tui_source_window::set_contents)
4069 (tui_source_window::showing_source_p): Update.
4070
40712019-09-20 Tom Tromey <tom@tromey.com>
4072
4073 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4074 Don't call tui_locator_win_info_ptr.
4075
40762019-09-20 Tom Tromey <tom@tromey.com>
4077
4078 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4079
40802019-09-20 Tom Tromey <tom@tromey.com>
4081
4082 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4083 height for locator.
4084 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4085 * tui/tui-layout.c (show_source_disasm_command, show_data)
4086 (show_source_or_disasm_and_command): Use 1 as height for locator.
4087
40882019-09-20 Tom Tromey <tom@tromey.com>
4089
4090 * tui/tui.c (tui_enable): Update.
4091 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4092 Update.
4093 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4094 Update.
4095 * tui/tui-data.c (win_resized): Now bool.
4096 (tui_win_resized): Return bool.
4097 (tui_set_win_resized_to): Accept a bool.
4098
40992019-09-20 Tom Tromey <tom@tromey.com>
4100
4101 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4102 Change type of "refresh_values_only".
4103 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4104 type of "refresh_values_only".
4105
41062019-09-20 Tom Tromey <tom@tromey.com>
4107
4108 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4109 std::string.
4110 (tui_disassemble): Add "pos" parameter.
4111 (tui_disasm_window::set_contents): Simplify.
4112
41132019-09-20 Tom Tromey <tom@tromey.com>
4114
4115 * tui/tui-winsource.h (struct tui_source_window_base)
4116 <show_source_content>: Now private.
4117 * tui/tui-winsource.c
4118 (tui_source_window_base::show_source_content): Don't handle empty
4119 content case.
4120
41212019-09-20 Tom Tromey <tom@tromey.com>
4122
4123 * tui/tui-layout.c (show_source_disasm_command)
4124 (show_source_or_disasm_and_command): Don't call
4125 show_source_content.
4126
41272019-09-20 Tom Tromey <tom@tromey.com>
4128
4129 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4130 Declare.
4131 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4132 from tui_make_status_line.
4133 (tui_locator_window::rerender): Update.
4134
41352019-09-20 Tom Tromey <tom@tromey.com>
4136
4137 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4138 (tui_locator_window::rerender): Update.
4139
41402019-09-20 Tom Tromey <tom@tromey.com>
4141
4142 * tui/tui-winsource.h (struct tui_source_window_base)
4143 <~tui_source_window_base>: Don't declare.
4144 <fullname>: Remove.
4145 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4146 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4147 member.
4148 * tui/tui-source.c (tui_source_window::set_contents): Update.
4149 (tui_source_window::location_matches_p)
4150 (tui_source_window::maybe_update): Update.
4151
41522019-09-20 Tom Tromey <tom@tromey.com>
4153
4154 * tui/tui-winsource.h (~tui_source_element): Remove.
4155 (tui_source_element): Update.
4156 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4157 * tui/tui-winsource.c (tui_show_source_line): Update.
4158 * tui/tui-source.c (tui_source_window::set_contents): Update.
4159 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4160
41612019-09-20 Tom Tromey <tom@tromey.com>
4162
4163 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4164 declare.
4165 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4166 tui_clear_source_windows_detail.
4167 * tui/tui-winsource.h (struct tui_source_window_base)
4168 <clear_detail>: Don't declare.
4169 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4170 Remove.
4171 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4172
41732019-09-20 Tom Tromey <tromey@adacore.com>
4174
4175 PR ada/24919:
4176 * block.c (contained_in): Fix final return value.
4177
41782019-09-20 Alan Modra <amodra@gmail.com>
4179
4180 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4181 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4182 (read_indirect_string_from_dwz): Use bfd accessor.
4183 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4184 * machoread.c (macho_symfile_read_all_oso): Likewise.
4185 * solib.c (solib_bfd_open): Likewise.
4186
41872019-09-19 Christian Biesinger <cbiesinger@google.com>
4188
4189 * eval.c: Move declaration of overload_resolution to...
4190 * value.h: ...here.
4191
41922019-09-19 Christian Biesinger <cbiesinger@google.com>
4193
4194 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4195 * arm-linux-tdep.c: Likewise.
4196 * arm-nbsd-nat.c: Likewise.
4197 * arm-tdep.h: Declare arm_apcs_32.
4198 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4199
42002019-09-19 Christian Biesinger <cbiesinger@google.com>
4201
4202 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4203 * dwarf2read.h: Declare dwarf_always_disassemble.
4204
42052019-09-19 Tom de Vries <tdevries@suse.de>
4206
4207 PR gdb/25009
4208 * source-cache.c (source_cache::ensure): Catch exception thrown during
4209 construction of the highlighter.
4210
42112019-09-18 Alan Modra <amodra@gmail.com>
4212
4213 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4214 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4215 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4216 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4217 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4218 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4219 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4220 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4221 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4222 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4223 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4224 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4225 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4226 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4227 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4228 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4229 * mi/mi-interp.c: Update throughout for bfd section macro and
4230 function changes.
4231 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4232 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4233
42342019-09-18 Tom Tromey <tom@tromey.com>
4235
4236 * NEWS: Add entry.
4237 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4238 call rl_initialize.
4239 (tui_enable): Do not call rl_initialize.
4240
42412019-09-18 Christian Groessler <chris@groessler.org>
4242
4243 * alpha-linux-nat.c: Include gdbarch.h.
4244
42452019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4246
4247 * ui-file.c: Include cli/cli-style.h.
4248 (term_cli_styling): Remove cli_styling declaration.
4249
42502019-09-18 Alan Modra <amodra@gmail.com>
4251
4252 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4253 to bfd_asymbol_section.
4254
42552019-09-18 Alan Modra <amodra@gmail.com>
4256
4257 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4258 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4259 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4260
42612019-09-18 Alan Modra <amodra@gmail.com>
4262
4263 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4264 * spu-linux-nat.c (spu_bfd_open): Likewise.
4265
42662019-09-18 Christian Biesinger <cbiesinger@google.com>
4267
4268 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4269 to bool to match definition in dwarf2read.c.
4270
42712019-09-17 Christian Biesinger <cbiesinger@google.com>
4272
4273 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4274 (print_signatures): Likewise.
4275 (trust_pad_over_xvs): Likewise.
4276 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4277 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4278 * arm-linux-nat.c (arm_apcs_32): Likewise.
4279 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4280 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4281 * arm-tdep.c (arm_debug): Likewise.
4282 (arm_apcs_32): Likewise.
4283 * auto-load.c (debug_auto_load): Likewise.
4284 (auto_load_gdb_scripts): Likewise.
4285 (global_auto_load): Likewise.
4286 (auto_load_local_gdbinit): Likewise.
4287 (auto_load_local_gdbinit_loaded): Likewise.
4288 * auto-load.h (global_auto_load): Likewise.
4289 (auto_load_local_gdbinit): Likewise.
4290 (auto_load_local_gdbinit_loaded): Likewise.
4291 * breakpoint.c (disconnected_dprintf): Likewise.
4292 (breakpoint_proceeded): Likewise.
4293 (automatic_hardware_breakpoints): Likewise.
4294 (always_inserted_mode): Likewise.
4295 (target_exact_watchpoints): Likewise.
4296 (_initialize_breakpoint): Update.
4297 * breakpoint.h (target_exact_watchpoints): Change to bool.
4298 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4299 * cli/cli-cmds.c (trace_commands): Likewise.
4300 * cli/cli-cmds.h (trace_commands): Likewise.
4301 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4302 to bool*.
4303 * cli/cli-logging.c (logging_overwrite): Change to bool.
4304 (logging_redirect): Likewise.
4305 (debug_redirect): Likewise.
4306 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4307 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4308 to bool.
4309 <boolean_option_def>: Update.
4310 (struct flag_option_def): Change default type of Context to bool
4311 from int.
4312 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4313 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4314 (get_setshow_command_value_string): Likewise.
4315 * cli/cli-style.c (cli_styling): Change to bool.
4316 (source_styling): Likewise.
4317 * cli/cli-style.h (source_styling): Likewise.
4318 (cli_styling): Likewise.
4319 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4320 to bool.
4321 * command.h (var_types): Update comment.
4322 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4323 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4324 bool.
4325 (debug_compile_cplus_scopes): Likewise.
4326 * compile/compile-internal.h (compile_debug): Likewise.
4327 * compile/compile.c (compile_debug): Likewise.
4328 (struct compile_options) <raw>: Likewise.
4329 * cp-support.c (catch_demangler_crashes): Likewise.
4330 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4331 (usr_cmd_cris_dwarf2_cfi): Likewise.
4332 * csky-tdep.c (csky_debug): Likewise.
4333 * darwin-nat.c (enable_mach_exceptions): Likewise.
4334 * dcache.c (dcache_enabled_p): Likewise.
4335 * defs.h (info_verbose): Likewise.
4336 * demangle.c (demangle): Likewise.
4337 (asm_demangle): Likewise.
4338 * dwarf-index-cache.c (debug_index_cache): Likewise.
4339 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4340 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4341 * dwarf2read.c (check_physname): Likewise.
4342 (use_deprecated_index_sections): Likewise.
4343 (dwarf_always_disassemble): Likewise.
4344 * eval.c (overload_resolution): Likewise.
4345 * event-top.c (set_editing_cmd_var): Likewise.
4346 (exec_done_display_p): Likewise.
4347 * event-top.h (set_editing_cmd_var): Likewise.
4348 (exec_done_display_p): Likewise.
4349 * exec.c (write_files): Likewise.
4350 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4351 (debug_fbsd_nat): Likewise.
4352 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4353 Likewise.
4354 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4355 <backtrace_past_entry> Likewise.
4356 * gdb-demangle.h (demangle): Likewise.
4357 (asm_demangle): Likewise.
4358 * gdb_bfd.c (bfd_sharing): Likewise.
4359 * gdbcore.h (write_files): Likewise.
4360 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4361 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4362 * gdbthread.h (print_thread_events): Likewise.
4363 * gdbtypes.c (opaque_type_resolution): Likewise.
4364 (strict_type_checking): Likewise.
4365 * gnu-nat.c (gnu_debug_flag): Likewise.
4366 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4367 * guile/scm-param.c (pascm_variable): Add boolval.
4368 (add_setshow_generic): Update.
4369 (pascm_param_value): Update.
4370 (pascm_set_param_value_x): Update.
4371 * hppa-tdep.c (hppa_debug): Change to bool..
4372 * infcall.c (may_call_functions_p): Likewise.
4373 (coerce_float_to_double_p): Likewise.
4374 (unwind_on_signal_p): Likewise.
4375 (unwind_on_terminating_exception_p): Likewise.
4376 * infcmd.c (startup_with_shell): Likewise.
4377 * inferior.c (print_inferior_events): Likewise.
4378 * inferior.h (startup_with_shell): Likewise.
4379 (print_inferior_events): Likewise.
4380 * infrun.c (step_stop_if_no_debug): Likewise.
4381 (detach_fork): Likewise.
4382 (debug_displaced): Likewise.
4383 (disable_randomization): Likewise.
4384 (non_stop): Likewise.
4385 (non_stop_1): Likewise.
4386 (observer_mode): Likewise.
4387 (observer_mode_1): Likewise.
4388 (set_observer_mode): Update.
4389 (sched_multi): Change to bool.
4390 * infrun.h (debug_displaced): Likewise.
4391 (sched_multi): Likewise.
4392 (step_stop_if_no_debug): Likewise.
4393 (non_stop): Likewise.
4394 (disable_randomization): Likewise.
4395 * linux-tdep.c (use_coredump_filter): Likewise.
4396 (dump_excluded_mappings): Likewise.
4397 * linux-thread-db.c (auto_load_thread_db): Likewise.
4398 (check_thread_db_on_load): Likewise.
4399 * main.c (captured_main_1): Update.
4400 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4401 xx2_opt, boolean_opt>: Change to bool.
4402 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4403 * maint.c (maintenance_profile_p): Likewise.
4404 (per_command_time): Likewise.
4405 (per_command_space): Likewise.
4406 (per_command_symtab): Likewise.
4407 * memattr.c (inaccessible_by_default): Likewise.
4408 * mi/mi-main.c (mi_async): Likewise.
4409 (mi_async_1): Likewise.
4410 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4411 * nat/fork-inferior.h (startup_with_shell): Likewise.
4412 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4413 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4414 * nios2-tdep.c (nios2_debug): Likewise.
4415 * or1k-tdep.c (or1k_debug): Likewise.
4416 * parse.c (parser_debug): Likewise.
4417 * parser-defs.h (parser_debug): Likewise.
4418 * printcmd.c (print_symbol_filename): Likewise.
4419 * proc-api.c (procfs_trace): Likewise.
4420 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4421 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4422 (set_parameter_value): Update.
4423 (add_setshow_generic): Update.
4424 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4425 to bool*.
4426 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4427 int*.
4428 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4429 * record-btrace.c (record_btrace_target::store_registers): Update.
4430 * record-full.c (record_full_memory_query): Change to bool.
4431 (record_full_stop_at_limit): Likewise.
4432 * record-full.h (record_full_memory_query): Likewise.
4433 * remote-notif.c (notif_debug): Likewise.
4434 * remote-notif.h (notif_debug): Likewise.
4435 * remote.c (use_range_stepping): Likewise.
4436 (interrupt_on_connect): Likewise.
4437 (remote_break): Likewise.
4438 * ser-tcp.c (tcp_auto_retry): Likewise.
4439 * ser-unix.c (serial_hwflow): Likewise.
4440 * skip.c (debug_skip): Likewise.
4441 * solib-aix.c (solib_aix_debug): Likewise.
4442 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4443 (spu_auto_flush_cache_p): Likewise.
4444 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4445 Likewise.
4446 (struct info_print_options) <quiet>: Likewise.
4447 * symfile-debug.c (debug_symfile): Likewise.
4448 * symfile.c (auto_solib_add): Likewise.
4449 (separate_debug_file_debug): Likewise.
4450 * symfile.h (auto_solib_add): Likewise.
4451 (separate_debug_file_debug): Likewise.
4452 * symtab.c (basenames_may_differ): Likewise.
4453 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4454 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4455 (struct info_types_options) <quiet>: Likewise.
4456 * symtab.h (demangle): Likewise.
4457 (basenames_may_differ): Likewise.
4458 * target-dcache.c (stack_cache_enabled_1): Likewise.
4459 (code_cache_enabled_1): Likewise.
4460 * target.c (trust_readonly): Likewise.
4461 (may_write_registers): Likewise.
4462 (may_write_memory): Likewise.
4463 (may_insert_breakpoints): Likewise.
4464 (may_insert_tracepoints): Likewise.
4465 (may_insert_fast_tracepoints): Likewise.
4466 (may_stop): Likewise.
4467 (auto_connect_native_target): Likewise.
4468 (target_stop_and_wait): Update.
4469 (target_async_permitted): Change to bool.
4470 (target_async_permitted_1): Likewise.
4471 (may_write_registers_1): Likewise.
4472 (may_write_memory_1): Likewise.
4473 (may_insert_breakpoints_1): Likewise.
4474 (may_insert_tracepoints_1): Likewise.
4475 (may_insert_fast_tracepoints_1): Likewise.
4476 (may_stop_1): Likewise.
4477 * target.h (target_async_permitted): Likewise.
4478 (may_write_registers): Likewise.
4479 (may_write_memory): Likewise.
4480 (may_insert_breakpoints): Likewise.
4481 (may_insert_tracepoints): Likewise.
4482 (may_insert_fast_tracepoints): Likewise.
4483 (may_stop): Likewise.
4484 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4485 (make_thread_apply_all_options_def_group): Change argument from int*
4486 to bool*.
4487 (thread_apply_all_command): Update.
4488 (print_thread_events): Change to bool.
4489 * top.c (confirm): Likewise.
4490 (command_editing_p): Likewise.
4491 (history_expansion_p): Likewise.
4492 (write_history_p): Likewise.
4493 (info_verbose): Likewise.
4494 * top.h (confirm): Likewise.
4495 (history_expansion_p): Likewise.
4496 * tracepoint.c (disconnected_tracing): Likewise.
4497 (circular_trace_buffer): Likewise.
4498 * typeprint.c (print_methods): Likewise.
4499 (print_typedefs): Likewise.
4500 * utils.c (debug_timestamp): Likewise.
4501 (sevenbit_strings): Likewise.
4502 (pagination_enabled): Likewise.
4503 * utils.h (sevenbit_strings): Likewise.
4504 (pagination_enabled): Likewise.
4505 * valops.c (overload_resolution): Likewise.
4506 * valprint.h (struct value_print_options) <prettyformat_arrays,
4507 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4508 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4509 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4510 Likewise.
4511 * windows-nat.c (new_console): Likewise.
4512 (cygwin_exceptions): Likewise.
4513 (new_group): Likewise.
4514 (debug_exec): Likewise.
4515 (debug_events): Likewise.
4516 (debug_memory): Likewise.
4517 (debug_exceptions): Likewise.
4518 (useshell): Likewise.
4519 * windows-tdep.c (maint_display_all_tib): Likewise.
4520 * xml-support.c (debug_xml): Likewise.
4521
45222019-09-17 Mike Gulick <mgulick@mathworks.com>
4523
4524 * source.c (prepare_path_for_appending): New function.
4525 (openp): Make use of new function.
4526 (find_and_open_source): Search for the compilation directory and
4527 source file as a relative path beneath the directory search path.
4528
45292019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4530
4531 * source-cache.c (source_cache::get_line_charpos): Catch
4532 exceptions and return false, this matches the behaviour documented
4533 in the header file.
4534
45352019-09-17 Joel Brobecker <brobecker@adacore.com>
4536
4537 * ada-tasks.c (info_task): Remove quoting of the task's name.
4538
45392019-09-16 Christian Biesinger <cbiesinger@google.com>
4540
4541 * symfile.c (auto_solib_add): Replace comment with a reference
4542 to the header file.
4543
45442019-09-14 Christian Biesinger <cbiesinger@google.com>
4545
4546 * NEWS: Mention that gdb can now be compiled with Python 3
4547 on Windows.
4548
45492019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4550
4551 * maint.c (maint_print_section_data::maint_print_section_data):
4552 Force use of 'float log10 (float)' by casting the argument to
4553 float.
4554
45552019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4556
4557 * maint.c: Add 'cmath' include.
4558 (struct maint_print_section_data): New structure.
4559 (print_section_index): New function.
4560 (print_bfd_section_info): Add header comment, small whitespace
4561 cleanup, and update to call new print_section_index function.
4562 (print_objfile_section_info): Likewise.
4563 (maint_obj_section_from_bfd_section): New function.
4564 (print_bfd_section_info_maybe_relocated): New function.
4565 (maintenance_info_sections): Add header comment, always use
4566 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4567
45682019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4569
4570 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4571 inner scope, add check that the objfile has psymtabs before
4572 checking psymtabs_addrmap.
4573 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4574
45752019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4576
4577 * NEWS: Announce that Ada task names are now shown at more places,
4578 and between quotes (except in info task output).
4579 * gdb/ada-tasks.c (task_to_str): New function.
4580 (display_current_task_id): Call task_to_str.
4581 (task_command_1): Likewise.
4582 (print_ada_task_info): In non-mi mode, Properly align headers and data
4583 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4584
45852019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4586
4587 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4588 prstatus.pr_lwp.pr_info instead of making it up.
4589
45902019-09-11 Christian Biesinger <cbiesinger@google.com>
4591
4592 * auto-load.c (auto_load_expand_dir_vars): Update.
4593 * defs.h (gdb_datadir): Change to std::string.
4594 (python_libdir): Likewise.
4595 (relocate_gdb_directory): Change return type to std::string.
4596 * guile/guile.c (gdbscm_data_directory): Update.
4597 (initialize_scheme_side): Update.
4598 * jit.c (jit_reader_dir): Change to std::string.
4599 (jit_reader_load_command): Update.
4600 * main.c (gdb_datadir): Change to std::string.
4601 (python_libdir): Likewise.
4602 (set_gdb_data_directory): Update.
4603 (relocate_path): Change to return std::string.
4604 (relocate_gdb_directory): Change to return std::string.
4605 (relocate_gdbinit_path_maybe_in_datadir): Update.
4606 (captured_main_1): Update.
4607 * python/python.c (do_start_initialization): Update.
4608 * top.c (show_gdb_datadir): Update.
4609 * xml-syscall.c (xml_init_syscalls_info): Update.
4610 (init_syscalls_info): Update.
4611
46122019-09-11 Christian Biesinger <cbiesinger@google.com>
4613
4614 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4615 out of get_init_files.
4616 (get_init_files): Update.
4617
46182019-09-11 Christian Biesinger <cbiesinger@google.com>
4619
4620 * main.c (get_init_files): Change to use std::string.
4621 (captured_main_1): Update.
4622 (print_gdb_help): Update.
4623
46242019-09-11 Ali Tamur <tamur@google.com>
4625
4626 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4627 implementation.
4628
46292019-09-11 Christian Biesinger <cbiesinger@google.com>
4630
4631 * dbxread.c (read_dbx_symtab): Update.
4632 * dwarf2read.c (load_partial_dies): Update.
4633 * mdebugread.c (parse_partial_symbols): Update.
4634 (handle_psymbol_enumerators): Update.
4635 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4636 * psymtab.c (add_psymbol_to_bcache): Likewise.
4637 (add_psymbol_to_list): Likewise.
4638 * symtab.c (symbol_set_names): Likewise.
4639 * symtab.h (symbol_set_names): Likewise.
4640 * xcoffread.c (scan_xcoff_symtab): Update.
4641
46422019-09-11 Tom Tromey <tom@tromey.com>
4643
4644 * symfile-mem.c (symbol_file_add_from_memory): Use
4645 bfd_set_filename.
4646 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4647 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4648
46492019-09-10 Tom Tromey <tromey@adacore.com>
4650
4651 * dwarf-index-write.c (write_psymbols): Extend error message.
4652 (debug_names::insert): Add Ada code.
4653 (debug_names::write_psymbols): Remove Ada check.
4654 (debug_names) <m_string_obstack>: New member.
4655 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4656 (gdb_index_symbol_name_matcher::matches): Remove.
4657 (mapped_index_base::find_name_components_bounds): Add "lang"
4658 parameter.
4659 (mapped_index_base::build_name_components): Also split names
4660 according to Ada syntax.
4661 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4662 type of "match_callback".
4663 (check_match, check_find_bounds_finds)
4664 (dw2_expand_symtabs_matching): Update.
4665 (dw2_debug_names_iterator): Add new constructor.
4666 (dw2_debug_names_map_matching_symbols): New function.
4667 (dw2_debug_names_expand_symtabs_matching): Update.
4668 (dwarf2_debug_names_functions): Use
4669 dw2_debug_names_map_matching_symbols.
4670
46712019-09-10 Tom Tromey <tromey@adacore.com>
4672
4673 * dwarf2read.c (dw2_get_file_names_reader): Add the
4674 CU's file name to the results.
4675
46762019-09-10 Tom Tromey <tromey@adacore.com>
4677
4678 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4679 map_matching_symbols. Update.
4680 * dwarf2read.c (dw2_map_matching_symbols): Update.
4681 * psymtab.c (match_partial_symbol): Change type; update.
4682 (psym_map_matching_symbols): Likewise.
4683 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4684 type; update.
4685 * symfile.h (struct quick_symbol_functions)
4686 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4687 Remove "match".
4688
46892019-09-10 Tom Tromey <tromey@adacore.com>
4690
4691 * psymtab.c (map_block): Remove.
4692 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4693 * symtab.c (iterate_over_symbols_terminated): New function.
4694 * symtab.c (iterate_over_symbols_terminated): Declare.
4695
46962019-09-10 Tom Tromey <tromey@adacore.com>
4697
4698 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4699 * language.h (struct language_defn) <la_iterate_over_symbols>:
4700 Return bool.
4701 * symtab.c (iterate_over_symbols): Return bool.
4702 * symtab.h (iterate_over_symbols): Return bool.
4703
47042019-09-10 Tom Tromey <tromey@adacore.com>
4705
4706 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4707 (add_nonlocal_symbols): Update.
4708 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4709 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4710 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4711 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4712 Change type of "callback". Remove "data".
4713
4714
47152019-09-09 Ali Tamur <tamur@google.com>
4716
4717 * dwarf2read.c (comp_unit_head): Update comment.
4718 (dwarf2_dwo_name): New function declaration.
4719 (dwarf_unit_type_name): New function declaration.
4720 (read_comp_unit_head): Add support for new compilation units,
4721 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4722 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4723 (currently named as "signature") in their header. Also clarify error
4724 messages.
4725 (lookup_dwo_id): New function. Returns the dwo id of the given
4726 compile unit.
4727 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4728 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4729 functions.
4730 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4731 (dwarf2_dwo_name): Get the dwo name if present.
4732 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4733 purposes.
4734
47352019-09-09 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4738
47392019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4740
4741 * python/python.c (do_start_initialization): Make progname_copy static,
4742 to avoid a leak report.
4743
47442019-09-08 Tom Tromey <tom@tromey.com>
4745
4746 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4747
47482019-09-07 Simon Marchi <simon.marchi@efficios.com>
4749
4750 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4751 Change type to gdb::optional<block_enum>.
4752 (dw2_symtab_iter_init): Change block_index parameter type
4753 to gdb::optional<block_enum>.
4754 (dw2_lookup_symbol): Change block_index parameter
4755 type to block_enum.c
4756 (dw2_debug_names_lookup_symbol): Likewise.
4757 * psymtab.c (psym_lookup_symbol): Likewise.
4758 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4759 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4760 Likewise.
4761
47622019-09-06 Christian Biesinger <cbiesinger@google.com>
4763
4764 * defs.h (relocate_gdb_directory): Change int to bool in
4765 signature and rename flag to relocatable.
4766 * main.c (relocate_path): Likewise.
4767 (relocate_gdb_directory): Likewise.
4768
47692019-09-06 Alan Modra <amodra@gmail.com>
4770
4771 * coffread.c (coff_symfile_read): Constify filename variable.
4772 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4773 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4774 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4775 * solib.c (reload_shared_libraries_1): Likewise.
4776 * symfile.c (reread_symbols): Likewise.
4777 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4778 * solib-darwin.c (darwin_bfd_open): Likewise.
4779 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4780
47812019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4782
4783 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4784 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4785
47862019-09-03 Tom Tromey <tromey@adacore.com>
4787
4788 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4789 types.
4790 (has_negatives): Unbias a range type bound.
4791 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4792 * gdbtypes.c (operator==): Handle new field.
4793 (create_range_type): Add "bias" parameter.
4794 (create_static_range_type, resolve_dynamic_range): Update.
4795 * gdbtypes.h (struct range_bounds) <bias>: New member.
4796 (create_range_type): Add bias parameter.
4797 * printcmd.c (print_scalar_formatted): Unbias range types.
4798 * value.c (unpack_long): Unbias range types.
4799 (pack_long): Bias range types.
4800
48012019-09-02 Alan Hayward <alan.hayward@arm.com>
4802
4803 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4804 probe arguments.
4805
48062019-09-02 Alan Hayward <alan.hayward@arm.com>
4807
4808 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4809 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4810 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4811 (compile_probe_arg): Likewise.
4812 * probe.h (get_argument_count): Likewise.
4813 * solib-svr4.c (solib_event_probe_action): Likewise.
4814 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4815
48162019-09-02 Alan Hayward <alan.hayward@arm.com>
4817
4818 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4819 code to here...
4820 (svr4_create_solib_event_breakpoints): ...from here.
4821
48222019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4823
4824 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4825 suffix from warning message.
4826
48272019-08-30 Tom Tromey <tom@tromey.com>
4828
4829 * tui/tui-winsource.h (struct tui_source_window_base)
4830 <refresh_all>: Don't declare.
4831 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4832 Remove.
4833 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4834 tui_show_locator_content.
4835 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4836 declare.
4837 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4838 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4839 declare.
4840
48412019-08-30 Tom Tromey <tom@tromey.com>
4842
4843 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4844
48452019-08-30 Tom Tromey <tom@tromey.com>
4846
4847 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4848 Remove unnecessary forward declarations.
4849
48502019-08-30 Tom Tromey <tom@tromey.com>
4851
4852 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4853 rerender.
4854 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4855 tui_show_locator_content.
4856
48572019-08-30 Tom Tromey <tom@tromey.com>
4858
4859 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4860 (tui_locator_window::rerender): Rewrite using body of previous
4861 tui_show_locator_content.
4862
48632019-08-30 Tom Tromey <tom@tromey.com>
4864
4865 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4866 set_locator_fullname>: New methods.
4867 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4868 Rename from tui_set_locator_fullname.
4869 (tui_locator_window::set_locator_info): Rename from
4870 tui_set_locator_info. Return bool.
4871 (tui_update_locator_fullname, tui_show_frame_info): Update.
4872
48732019-08-30 Tom Tromey <tom@tromey.com>
4874
4875 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4876
48772019-08-30 Tom Tromey <tom@tromey.com>
4878
4879 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4880 call touchwin.
4881
48822019-08-30 Tom Tromey <tom@tromey.com>
4883
4884 * tui/tui-wingeneral.c (box_win): Assume win_info and
4885 win_info->handle cannot be NULL.
4886
48872019-08-30 Tom Tromey <tom@tromey.com>
4888
4889 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4890 refresh_window>: Declare.
4891 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4892 resize.
4893 (tui_data_item_window::rerender): Rename from
4894 tui_display_register.
4895 (tui_data_item_window::refresh_window): New method.
4896 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4897 no-op.
4898
48992019-08-30 Tom Tromey <tom@tromey.com>
4900
4901 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4902 regs_column_count, current_group>: Move later. Now private.
4903 <get_current_group>: New method.
4904 * tui/tui-regs.c (tui_reg_command): Update.
4905 * tui/tui-layout.c (tui_set_layout): Update.
4906
49072019-08-30 Tom Tromey <tom@tromey.com>
4908
4909 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4910 (tui_data_window::rerender): Don't call
4911 check_and_display_highlight_if_needed.
4912 (tui_data_window::refresh_all): Remove call to
4913 erase_data_content.
4914
49152019-08-30 Tom Tromey <tom@tromey.com>
4916
4917 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4918 (tui_data_window::display_registers_from)
4919 (tui_data_window::display_reg_element_at_line)
4920 (tui_data_window::display_registers_from_line): Remove checks of
4921 "empty".
4922
49232019-08-30 Tom Tromey <tom@tromey.com>
4924
4925 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4926 Don't declare.
4927 * tui/tui-regs.c (tui_data_window::show_registers): Call
4928 rerender.
4929 (tui_data_window::rerender): Rename from display_all_data.
4930 (tui_data_window::rerender): Remove old implementation.
4931
49322019-08-30 Tom Tromey <tom@tromey.com>
4933
4934 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4935 text.
4936 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4937
49382019-08-29 Bernhard Wodok <barto@gmx.net>
4939 Sergio Durigan Junior <sergiodj@redhat.com>
4940
4941 PR win32/24284
4942 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4943
49442019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4945
4946 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4947 when searching for types.
4948
49492019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4950
4951 * f-lang.c (f_language_defn): Use f_print_typedef.
4952 * f-lang.h (f_print_typedef): Declare.
4953 * f-typeprint.c (f_print_typedef): Define.
4954
49552019-08-27 Christian Biesinger <cbiesinger@google.com>
4956
4957 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4958
49592019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4960
4961 * cli/cli-utils.c (info_print_options_defs): Delete.
4962 (make_info_print_options_def_group): Delete.
4963 (extract_info_print_options): Delete.
4964 (info_print_command_completer): Delete.
4965 (info_print_args_help): Add extra parameter, and optionally
4966 include text about -n flag.
4967 * cli/cli-utils.h (struct info_print_options): Delete.
4968 (extract_info_print_options): Delete declaration.
4969 (info_print_command_completer): Delete declaration.
4970 (info_print_args_help): Add extra parameter, extend header
4971 comment.
4972 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4973 search_symbols.
4974 * stack.c (struct info_print_options): New type.
4975 (info_print_options_defs): New file scoped variable.
4976 (make_info_print_options_def_group): New static function.
4977 (info_print_command_completer): New static function.
4978 (info_locals_command): Update to use new local functions.
4979 (info_args_command): Likewise.
4980 (_initialize_stack): Add extra parameter to calls to
4981 info_print_args_help.
4982 * symtab.c (search_symbols): Add extra parameter, use this to
4983 possibly excluse non-debug symbols.
4984 (symtab_symbol_info): Add extra parameter, which is passed on to
4985 search_symbols.
4986 (struct info_print_options): New type.
4987 (info_print_options_defs): New file scoped variable.
4988 (make_info_print_options_def_group): New static function.
4989 (info_print_command_completer): New static function.
4990 (info_variables_command): Update to use local functions, and pass
4991 extra parameter through to symtab_symbol_info.
4992 (info_functions_command): Likewise.
4993 (info_types_command): Pass additional argument through to
4994 symtab_symbol_info.
4995 (rbreak_command): Pass extra argument to search_symbols.
4996 (_initialize_symtab): Add extra arguments for calls to
4997 info_print_args_help, and update help text for 'info variables',
4998 'whereis', and 'info functions' commands.
4999 * symtab.h (search_symbols): Add extra argument to declaration.
5000 * NEWS: Mention new flags.
5001
50022019-08-26 Christian Biesinger <cbiesinger@google.com>
5003
5004 * symtab.c (lookup_static_symbol): Call the new function (and move
5005 it down to be next to lookup_global_symbol).
5006 (struct global_sym_lookup_data): Add block_enum member and rename to...
5007 (struct global_or_static_sym_lookup_data): ...this.
5008 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5009 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5010 (lookup_symbol_global_or_static_iterator_cb): ...this.
5011 (lookup_global_or_static_symbol): New function.
5012 (lookup_global_symbol): Call new function.
5013
50142019-08-26 Tom de Vries <tdevries@suse.de>
5015
5016 PR c++/24852
5017 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5018 when pc_probe.prob == NULL.
5019
50202019-08-25 Simon Marchi <simon.marchi@efficios.com>
5021
5022 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5023 variable symbol_linkage to symbol_linkage_.
5024
50252019-08-25 Simon Marchi <simon.marchi@efficios.com>
5026
5027 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5028 represent whether the symbol is static, dynamic, or we don't
5029 know.
5030
50312019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5032
5033 * gdb/rx-tdep.c (rx_register_names): New.
5034 (rx_register_name): Delete.
5035 (rx_psw_type): Delete.
5036 (rx_fpsw_type): Delete.
5037 (rx_register_type): Delete.
5038 (rx_gdbarch_init): Convert target-descriptions.
5039 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5040 * gdb/features/Makefile: Add rx.xml.
5041 * gdb/features/rx.xml: New.
5042 * gdb/features/rx.c: Generated.
5043 * gdb/NEWS: Mention target description support.
5044
50452019-08-22 Christian Biesinger <cbiesinger@google.com>
5046
5047 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5048 *slot_ptr.
5049
50502019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5051
5052 * configure.ac: Don't check for 'dlfcn.h' (moved to
5053 gdbsupport/common.m4).
5054 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5055 'gdbsupport/'.
5056 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5057 * compile/compile-c-support.c: Include
5058 'gdbsupport/gdb-dlfcn.h'.
5059 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5060 * gdb-dlfcn.c: Move to...
5061 * gdbsupport/gdb-dlfcn.c: ... here.
5062 * gdb-dlfcn.h: Move to...
5063 * gdbsupport/gdb-dlfcn.h: ... here.
5064
50652019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5066
5067 * nios2-tdep.c (struct reg_value): Improve comments. Make
5068 the offset field signed.
5069
50702019-08-22 Christian Biesinger <cbiesinger@google.com>
5071
5072 * python/lib/gdb/__init__.py (_execute_file): New function.
5073 * python/python.c (python_run_simple_file): Call gdb._execute_file
5074 on Windows.
5075
50762019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5077
5078 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5079 all uses as this was never set to anything but a zero value.
5080
50812019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5082
5083 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5084
50852019-08-21 Christian Biesinger <cbiesinger@google.com>
5086
5087 * tui/tui-data.h (tui_gen_win_info): Add an =default
5088 move constructor, required by some GCC versions.
5089
50902019-08-21 Jinke Fan <fanjinke51@yeah.net>
5091
5092 * go32-nat.c (go32_sysinfo): Add hygon_p.
5093
50942019-08-20 Tom Tromey <tom@tromey.com>
5095
5096 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5097 line_from_reg_element_no, first_reg_element_no_inline,
5098 display_all_data, delete_data_content_windows,
5099 erase_data_content>: Now private.
5100
51012019-08-20 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5104 (tui_unhighlight_win, tui_highlight_win)
5105 (tui_win_info::make_window): Update.
5106 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5107
51082019-08-20 Tom Tromey <tom@tromey.com>
5109
5110 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5111 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5112 (MAX_PID_WIDTH): Move to tui-stack.c.
5113 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5114 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5115 (MAX_PID_WIDTH): Move from tui-data.h.
5116
51172019-08-20 Tom Tromey <tom@tromey.com>
5118
5119 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5120 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5121 (box_win): Update.
5122 (tui_gen_win_info::make_window): Rename from tui_make_window.
5123 (tui_win_info::make_window): New method.
5124 (tui_gen_win_info::make_visible): Update.
5125 * tui/tui-source.c (tui_source_window::set_contents): Update.
5126 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5127 (tui_data_window::display_registers_from): Update.
5128 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5129 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5130 Declare.
5131 <can_box>: Remove.
5132 <title>: Remove.
5133 (struct tui_win_info) <make_window>: Declare.
5134 <can_box>: Now virtual.
5135 <title>: New member.
5136 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5137 * tui/tui-command.c (tui_cmd_window::resize): Update.
5138
51392019-08-20 Tom Tromey <tom@tromey.com>
5140
5141 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5142 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5143 (tui_data_window::check_register_values): Update.
5144
51452019-08-20 Tom Tromey <tom@tromey.com>
5146
5147 * tui/tui-regs.h (struct tui_data_window): Use
5148 DISABLE_COPY_AND_ASSIGN.
5149 <regs_content>: Change type, removing unique_ptr.
5150 <tui_data_window>: Add move constructor.
5151 * tui/tui-regs.c (tui_data_window::show_registers)
5152 (tui_data_window::show_register_group)
5153 (tui_data_window::display_registers_from)
5154 (tui_data_window::display_registers_from)
5155 (tui_data_window::first_data_item_displayed)
5156 (tui_data_window::delete_data_content_windows)
5157 (tui_data_window::rerender, tui_data_window::refresh_window)
5158 (tui_data_window::check_register_values): Update.
5159
51602019-08-20 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5163 show_register_group>: Declare.
5164 (tui_show_register_group): Don't declare.
5165 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5166 tui_show_registers.
5167 (tui_data_window::show_register_group): Rename from
5168 tui_show_register_group.
5169 (tui_data_window::check_register_values, tui_reg_command):
5170 Update.
5171 * tui/tui-layout.c (tui_set_layout): Update.
5172
51732019-08-20 Tom Tromey <tom@tromey.com>
5174
5175 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5176 Declare.
5177 (tui_check_register_values): Don't declare.
5178 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5179 from tui_check_register_values.
5180 * tui/tui-hooks.c (tui_register_changed): Update.
5181
51822019-08-20 Tom Tromey <tom@tromey.com>
5183
5184 * tui/tui-regs.c (tui_reg_layout): Move later.
5185 (tui_show_registers): Don't enable TUI mode or change layout.
5186
51872019-08-20 Tom Tromey <tom@tromey.com>
5188
5189 * tui/tui-regs.h (struct tui_data_item_window)
5190 <~tui_data_item_window>: Remove.
5191 <content>: Now a unique_xmalloc_ptr.
5192 * tui/tui-regs.c (tui_register_format): Return a
5193 unique_xmalloc_ptr.
5194 (tui_get_register): Update.
5195 (~tui_data_item_window): Remove.
5196 (tui_data_window::display_registers_from, tui_display_register):
5197 Update.
5198 * tui/tui-io.h (tui_expand_tabs): Update.
5199 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5200 Remove "col" parameter.
5201
52022019-08-20 Tom Tromey <tom@tromey.com>
5203
5204 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5205 field.
5206 * tui/tui-regs.c (~tui_data_item_window): Update.
5207
52082019-08-20 Tom Tromey <tom@tromey.com>
5209
5210 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5211 earlier.
5212
52132019-08-20 Tom Tromey <tom@tromey.com>
5214
5215 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5216
52172019-08-20 Tom Tromey <tom@tromey.com>
5218
5219 * tui/tui-source.h (struct tui_source_window): Update.
5220 * tui/tui-regs.c (tui_show_registers): Update.
5221 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5222 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5223 (NO_REGS_STRING): Remove defines.
5224
52252019-08-20 Conrad Meyer <cem@FreeBSD.org>
5226
5227 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5228 unnecessary thread walk if remote doesn't support the packet.
5229
52302019-08-19 Tom Tromey <tromey@adacore.com>
5231
5232 * python/py-value.c (value_has_field): Fix indentation.
5233
52342019-08-19 Tom Tromey <tromey@adacore.com>
5235
5236 * printcmd.c (do_one_display, info_display_command): Update.
5237 * block.h (contained_in): Return bool. Add allow_nested
5238 parameter.
5239 * block.c (contained_in): Return bool. Add allow_nested
5240 parameter.
5241
52422019-08-19 Tom Tromey <tom@tromey.com>
5243
5244 * configure: Rebuild.
5245 * configure.ac: Disallow the combination of -static-libstdc++ and
5246 source highlight.
5247 * source-cache.c (get_language_name): Handle rust.
5248 (source_cache::get_source_lines): Ignore highlighting exceptions.
5249
52502019-08-16 Tom Tromey <tom@tromey.com>
5251
5252 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5253 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5254 (struct tui_source_window_base) <make_visible, refresh_window,
5255 resize>: Remove methods.
5256 <execution_info>: Remove field.
5257 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5258 (tui_show_source_line, tui_source_window_base)
5259 (~tui_source_window_base): Update.
5260 (tui_source_window_base::resize)
5261 (tui_source_window_base::make_visible)
5262 (tui_source_window_base::refresh_window): Remove.
5263 (tui_source_window_base::update_exec_info): Update.
5264 * tui/tui-source.c (tui_source_window::set_contents): Update.
5265 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5266
52672019-08-16 Tom Tromey <tom@tromey.com>
5268
5269 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5270 deprecated_query_hook.
5271
52722019-08-16 Tom Tromey <tom@tromey.com>
5273
5274 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5275 (tui_update_source_windows_with_line): Update.
5276 * tui/tui-source.h (struct tui_source_window)
5277 <show_symtab_source>: Declare.
5278 (tui_show_symtab_source): Don't declare.
5279 * tui/tui-source.c (tui_show_symtab_source): Rename from
5280 tui_show_symtab_source.
5281
52822019-08-16 Tom Tromey <tom@tromey.com>
5283
5284 * tui/tui-winsource.h (struct tui_source_window_base)
5285 <set_contents>: Declare.
5286 * tui/tui-winsource.c
5287 (tui_source_window_base::update_source_window_as_is): Update.
5288 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5289 Declare.
5290 (tui_set_source_content): Don't declare.
5291 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5292 tui_set_source_content.
5293 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5294 Declare.
5295 (tui_set_disassem_content): Don't declare.
5296 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5297 tui_set_disassem_content.
5298
52992019-08-16 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-winsource.h (struct tui_source_window_base)
5302 <update_breakpoint_info>: Declare.
5303 (tui_update_breakpoint_info): Don't declare.
5304 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5305 (tui_update_all_breakpoint_info): Update.
5306 (tui_source_window_base::update_breakpoint_info): Rename from
5307 tui_update_breakpoint_info.
5308 (tui_source_window_base::update_exec_info): Update.
5309
53102019-08-16 Tom Tromey <tom@tromey.com>
5311
5312 * tui/tui-winsource.h (struct tui_source_window_base)
5313 <update_source_window>: Declare.
5314 (tui_update_source_window): Don't declare.
5315 * tui/tui-winsource.c
5316 (tui_source_window_base::update_source_window): Rename from
5317 tui_update_source_window.
5318 (tui_source_window_base::rerender): Update.
5319 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5320 * tui/tui-disasm.c (tui_show_disassem)
5321 (tui_show_disassem_and_update_source)
5322 (tui_disasm_window::maybe_update): Update.
5323
53242019-08-16 Tom Tromey <tom@tromey.com>
5325
5326 * tui/tui-winsource.h (struct tui_source_window_base)
5327 <update_source_window_as_is>: Declare.
5328 (tui_update_source_window_as_is): Don't declare.
5329 * tui/tui-winsource.c (tui_update_source_window): Update
5330 (tui_source_window_base::update_source_window_as_is): Rename from
5331 tui_update_source_window_as_is.
5332 (tui_source_window_base::refill): Update.
5333 * tui/tui-source.c (tui_show_symtab_source): Update.
5334 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5335 Update.
5336
53372019-08-16 Tom Tromey <tom@tromey.com>
5338
5339 * tui/tui-winsource.h (tui_update_source_window)
5340 (tui_update_source_window_as_is): Remove "noerror" parameter.
5341 * tui/tui-winsource.c (tui_update_source_window)
5342 (tui_update_source_window_as_is): Remove "noerror" parameter.
5343 (tui_update_source_windows_with_addr)
5344 (tui_update_source_windows_with_line)
5345 (tui_source_window_base::rerender)
5346 (tui_source_window_base::refill): Update.
5347 * tui/tui-source.h (tui_set_source_content)
5348 (tui_show_symtab_source): Remove "noerror" parameter.
5349 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5350 parameter.
5351 (tui_show_symtab_source): Likewise.
5352 (tui_source_window::maybe_update): Update.
5353 * tui/tui-disasm.c (tui_show_disassem)
5354 (tui_show_disassem_and_update_source)
5355 (tui_disasm_window::do_scroll_vertical)
5356 (tui_disasm_window::maybe_update): Update.
5357
53582019-08-16 Tom Tromey <tom@tromey.com>
5359
5360 * tui/tui.c (tui_is_window_visible): Update.
5361 * tui/tui-wingeneral.c (tui_make_window)
5362 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5363 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5364 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5365 (tui_set_win_height_command, parse_scrolling_args): Update.
5366 * tui/tui-source.c (tui_source_window::style_changed): Update.
5367 * tui/tui-regs.c (tui_show_registers)
5368 (tui_data_window::first_data_item_displayed)
5369 (tui_data_window::delete_data_content_windows)
5370 (tui_check_register_values, tui_reg_command): Update.
5371 * tui/tui-disasm.c (tui_show_disassem): Update.
5372 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5373 method.
5374 <is_visible>: Remove field.
5375 * tui/tui-data.c (tui_next_win, tui_prev_win)
5376 (tui_delete_invisible_windows): Update.
5377
53782019-08-16 Tom Tromey <tom@tromey.com>
5379
5380 * tui/tui-winsource.h (struct tui_source_window_base)
5381 <m_has_locator>: Remove.
5382 * tui/tui-layout.c (show_source_disasm_command, show_data)
5383 (show_source_or_disasm_and_command): Update.
5384
53852019-08-16 Alan Hayward <alan.hayward@arm.com>
5386
5387 * NEWS (Other MI changes): New subsection.
5388 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5389 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5390 * arch-utils.c (default_get_pc_address_flags): New function.
5391 * arch-utils.h (default_get_pc_address_flags): New declaration.
5392 * gdbarch.sh: Add get_pc_address_flags.
5393 * gdbarch.c: Regenerate.
5394 * gdbarch.h: Likewise.
5395 * stack.c (print_pc): New function.
5396 (print_frame_info) (print_frame): Call print_pc.
5397
53982019-08-16 Tom de Vries <tdevries@suse.de>
5399
5400 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5401 print_objfile_section_info.
5402
54032019-08-15 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5406 calling update_cmdwin_start_line.
5407 * tui/tui-winsource.h (struct tui_source_window_base)
5408 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5409 <rerender>: Declare.
5410 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5411 Call rerender.
5412 (tui_source_window_base::set_new_height): Remove.
5413 (tui_source_window_base::rerender): Rename from
5414 do_make_visible_with_new_height.
5415 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5416 resize method.
5417 (tui_win_info::make_invisible_and_set_new_height)
5418 (tui_win_info::make_visible_with_new_height): Remove.
5419 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5420 Declare.
5421 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5422 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5423 do_make_visible_with_new_height>: Don't declare.
5424 <rerender>: Declare.
5425 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5426 set_new_height.
5427 (tui_data_window::do_make_visible_with_new_height): Remove.
5428 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5429 call tui_show_locator_content.
5430 (tui_gen_win_info::resize): Call rerender.
5431 (show_source_or_disasm_and_command): Don't call
5432 tui_show_locator_content.
5433 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5434 method.
5435 (struct tui_win_info) <rerender>: Declare.
5436 <set_new_height, make_invisible_and_set_new_height,
5437 make_visible_with_new_height>: Don't declare.
5438 * tui/tui-data.c (tui_win_list::rerender): New method.
5439 * tui/tui-command.h (struct tui_cmd_window)
5440 <do_make_visible_with_new_height>: Don't declare.
5441 * tui/tui-command.c
5442 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5443
54442019-08-15 Tom Tromey <tromey@adacore.com>
5445
5446 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5447 * ada-lang.c (ada_enum_name): Likewise.
5448
54492019-08-15 Christian Biesinger <cbiesinger@google.com>
5450
5451 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5452 leading underscore.
5453 (GdbOutputErrorFile): Likewise.
5454 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5455 accordingly.
5456 (execute_unwinders): Rename to have a leading underscore.
5457 (auto_load_packages): Likewise.
5458 (global scope): Adjust call to auto_load_packages accordingly.
5459 (GdbSetPythonDirectory): Likewise.
5460 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5461 instead of execute_unwinders.
5462
54632019-08-15 Tom Tromey <tom@tromey.com>
5464
5465 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5466 (show_data): Don't change window visibility.
5467 (tui_gen_win_info::resize): Remove special case for command
5468 window. Use wresize, when available.
5469 (show_source_or_disasm_and_command): Don't change window
5470 visibility.
5471 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5472 <make_visible>: New method.
5473 * tui/tui-command.c (tui_cmd_window::resize): New method.
5474
54752019-08-15 Tom Tromey <tom@tromey.com>
5476
5477 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5478 (struct tui_source_windows): New.
5479 * tui/tui-winsource.c (tui_display_main): Update.
5480 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5481 (new_height_ok, parse_scrolling_args): Update.
5482 * tui/tui-layout.c (show_layout, show_data): Update.
5483 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5484 (tui_add_to_source_windows): Don't declare.
5485 * tui/tui-data.c (source_windows, tui_source_windows)
5486 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5487
54882019-08-15 Tom Tromey <tom@tromey.com>
5489
5490 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5491 Rename from reset.
5492 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5493 * tui/tui-layout.c (show_source_disasm_command, show_data):
5494 Update.
5495 (tui_gen_win_info::resize): Rename.
5496 (show_source_or_disasm_and_command): Update.
5497 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5498 reset.
5499
55002019-08-15 Tom Tromey <tom@tromey.com>
5501
5502 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5503 * tui/tui-interp.c (tui_interp::init): Don't call
5504 tui_initialize_static_data.
5505 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5506
55072019-08-15 Tom Tromey <tom@tromey.com>
5508
5509 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5510 examine tui_win_list.
5511
55122019-08-15 Tom Tromey <tom@tromey.com>
5513
5514 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5515 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5516 tui_clear_source_content.
5517 (tui_clear_source_content): Remove.
5518 (tui_source_window_base::do_erase_source_content): Hoist call to
5519 content.clear().
5520 * tui/tui-stack.c (tui_show_frame_info): Don't call
5521 tui_clear_source_content.
5522
55232019-08-15 Tom Tromey <tom@tromey.com>
5524
5525 * tui/tui-winsource.h (struct tui_source_window_base)
5526 <do_erase_source_content>: New method.
5527 <erase_source_content>: New method.
5528 (tui_erase_source_content): Don't declare.
5529 * tui/tui-winsource.c (tui_clear_source_content): Update.
5530 (tui_source_window_base::do_erase_source_content): Rename from
5531 tui_erase_source_content.
5532 (tui_source_window_base::show_source_content): Update.
5533 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5534 * tui/tui-source.h (struct tui_source_window)
5535 <erase_source_content>: New method.
5536 * tui/tui-disasm.h (struct tui_disasm_window)
5537 <erase_source_content>: New method.
5538
55392019-08-15 Tom Tromey <tom@tromey.com>
5540
5541 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5542 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5543 constructor.
5544 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5545 * tui/tui-source.c (tui_set_source_content): Update.
5546 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5547
55482019-08-15 Tom Tromey <tom@tromey.com>
5549
5550 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5551 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5552 tui-source.c.
5553 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5554 Declare.
5555 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5556 method.
5557 (tui_source_window::maybe_update): Update.
5558
55592019-08-15 Tom Tromey <tom@tromey.com>
5560
5561 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5562 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5563 tui-disasm.c.
5564 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5565 Declare.
5566 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5567 method.
5568 (tui_disasm_window::maybe_update): Update.
5569
55702019-08-15 Tom Tromey <tom@tromey.com>
5571
5572 * tui/tui-winsource.h (struct tui_source_window_base)
5573 <maybe_update>: Declare.
5574 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5575 method.
5576 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5577 Declare.
5578 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5579 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5580 Declare.
5581 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5582
55832019-08-15 Tom Tromey <tom@tromey.com>
5584
5585 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5586
55872019-08-15 Tom Tromey <tom@tromey.com>
5588
5589 * tui/tui-wingeneral.c: Include tui-stack.h.
5590 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5591 (struct tui_locator_window): Move from tui-data.h.
5592 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5593 (tui_initialize_static_data): Move from tui-data.c.
5594 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5595 (struct tui_locator_window): Move to tui-stack.c.
5596 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5597 (tui_initialize_static_data): Move to tui-stack.c.
5598
55992019-08-15 Tom Tromey <tom@tromey.com>
5600
5601 * tui/tui-layout.c (show_source_disasm_command)
5602 (show_source_or_disasm_and_command): Use make_visible method, not
5603 tui_make_window.
5604 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5605 Remove.
5606
56072019-08-15 Tom Tromey <tom@tromey.com>
5608
5609 * tui/tui-wingeneral.h (tui_make_window): Update.
5610 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5611 parameter.
5612 (tui_gen_win_info::make_visible): Update.
5613 * tui/tui-regs.c (tui_data_window::display_registers_from):
5614 Update.
5615 * tui/tui-layout.c (show_source_disasm_command)
5616 (show_source_or_disasm_and_command): Update.
5617 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5618 (enum tui_box): Remove.
5619 (struct tui_win_info) <can_box>: New method.
5620 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5621 method.
5622
56232019-08-15 Tom de Vries <tdevries@suse.de>
5624
5625 * linux-nat-trad.c: Include gdbarch.h.
5626
56272019-08-14 Alan Hayward <alan.hayward@arm.com>
5628
5629 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5630 register sizes.
5631
56322019-08-14 Tom Tromey <tromey@adacore.com>
5633
5634 * darwin-nat.c: Include gdbarch.h.
5635 * darwin-nat-info.c: Include gdbarch.h.
5636
56372019-08-13 Tom Tromey <tom@tromey.com>
5638
5639 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5640 Remove.
5641 * tui/tui-data.c (tui_initialize_static_data): Update.
5642
56432019-08-13 Tom Tromey <tom@tromey.com>
5644
5645 * tui/tui-winsource.h (struct tui_exec_info_window)
5646 <~tui_exec_info_window, maybe_allocate_content, get_content,
5647 m_content>: Remove.
5648 (struct tui_source_window_base) <set_exec_info_content,
5649 show_exec_info_content>: Don't declare.
5650 * tui/tui-winsource.c
5651 (tui_exec_info_window::maybe_allocate_content): Remove.
5652 (tui_source_window_base::update_exec_info): Rename from
5653 set_exec_info_content.
5654 (tui_source_window_base::show_exec_info_content)
5655 (tui_source_window_base::update_exec_info): Remove.
5656
56572019-08-13 Tom Tromey <tom@tromey.com>
5658
5659 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5660 declare.
5661 * tui/tui-winsource.c (tui_update_source_window_as_is)
5662 (tui_update_source_windows_with_addr, tui_erase_source_content):
5663 Update.
5664 (tui_clear_exec_info_content): Remove.
5665
56662019-08-13 Tom Tromey <tom@tromey.com>
5667
5668 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5669 declare.
5670 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5671 call tui_erase_exec_info_content.
5672 (tui_clear_exec_info_content): Rename from
5673 tui_erase_exec_info_content.
5674 (tui_clear_exec_info_content): Delete.
5675
56762019-08-13 Tom Tromey <tom@tromey.com>
5677
5678 * tui/tui-winsource.h (struct tui_source_window_base)
5679 <show_exec_info_content>: Declare.
5680 (tui_show_exec_info_content): Don't declare.
5681 * tui/tui-winsource.c
5682 (tui_source_window_base::show_exec_info_content): Rename from
5683 tui_show_exec_info_content.
5684 (tui_source_window_base::update_exec_info): Update.
5685
56862019-08-13 Tom Tromey <tom@tromey.com>
5687
5688 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5689 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5690 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5691 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5692 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5693 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5694 ... here.
5695
56962019-08-13 Tom Tromey <tom@tromey.com>
5697
5698 * tui/tui-winsource.h (struct tui_source_window_base)
5699 <update_exec_info>: Declare.
5700 (tui_update_exec_info): Don't declare.
5701 * tui/tui-winsource.c (tui_update_source_window_as_is)
5702 (tui_source_window_base::refresh_all)
5703 (tui_update_all_breakpoint_info): Update.
5704 (tui_source_window_base::update_exec_info): Rename from
5705 tui_update_exec_info.
5706 * tui/tui-stack.c (tui_show_frame_info): Update.
5707
57082019-08-13 Tom Tromey <tom@tromey.com>
5709
5710 * tui/tui-winsource.h (struct tui_source_window_base)
5711 <set_exec_info_content>: Declare.
5712 (tui_set_exec_info_content): Don't declare.
5713 * tui/tui-winsource.c
5714 (tui_source_window_base::set_exec_info_content): Rename from
5715 tui_set_exec_info_content.
5716 (tui_update_exec_info): Update.
5717
57182019-08-13 Tom Tromey <tom@tromey.com>
5719
5720 * tui/tui-winsource.h (struct tui_source_window_base)
5721 <show_source_content>: Declare.
5722 (tui_show_source_content): Don't declare.
5723 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5724 (tui_source_window_base::show_source_content): Rename from
5725 tui_show_source_content.
5726 (tui_source_window_base::refresh_all): Update.
5727 * tui/tui-layout.c (show_source_disasm_command)
5728 (show_source_or_disasm_and_command): Update.
5729
57302019-08-13 Tom Tromey <tom@tromey.com>
5731
5732 * tui/tui-winsource.c (tui_erase_source_content)
5733 (tui_show_source_content, tui_source_window_base::refresh_all):
5734 Update.
5735 * tui/tui-wingeneral.h
5736 (tui_check_and_display_highlight_if_needed): Don't declare.
5737 * tui/tui-wingeneral.c
5738 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5739 check_and_display_highlight_if_needed.
5740 * tui/tui-win.c (tui_rehighlight_all)
5741 (tui_win_info::make_visible_with_new_height): Update.
5742 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5743 (tui_data_window::erase_data_content)
5744 (tui_data_window::display_all_data): Update.
5745 * tui/tui-data.h (struct tui_win_info)
5746 <check_and_display_highlight_if_needed>: Declare.
5747
57482019-08-13 Tom Tromey <tom@tromey.com>
5749
5750 * tui/tui-win.c (tui_resize_all): Call
5751 tui_delete_invisible_windows.
5752 * tui/tui-layout.c (show_layout): Call
5753 tui_delete_invisible_windows.
5754 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5755 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5756
57572019-08-13 Tom Tromey <tom@tromey.com>
5758
5759 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5760 tui_add_win_to_layout.
5761
57622019-08-13 Tom Tromey <tom@tromey.com>
5763
5764 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5765 * tui/tui-layout.c (tui_default_win_height): Now static.
5766
57672019-08-13 Tom Tromey <tom@tromey.com>
5768
5769 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5770 single switch.
5771 (show_source_disasm_command, show_source_or_disasm_and_command):
5772 Don't check current layout.
5773
57742019-08-13 Tom Tromey <tom@tromey.com>
5775
5776 * tui/tui-wingeneral.c (make_all_visible): Remove.
5777 (tui_make_all_invisible): Simplify.
5778 * tui/tui-layout.c (tui_make_all_invisible): Move from
5779 tui-wingeneral.c; simplify.
5780 (show_layout): Hoist call to tui_make_all_invisible.
5781 (show_data): Don't call tui_make_all_invisible.
5782
57832019-08-13 Tom Tromey <tom@tromey.com>
5784
5785 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5786 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5787
57882019-08-13 Tom Tromey <tom@tromey.com>
5789
5790 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5791 tui-data.c.
5792 (show_source_disasm_command, show_data)
5793 (show_source_or_disasm_and_command): Don't use
5794 tui_set_current_layout_to.
5795 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5796 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5797 tui-layout.c.
5798 (tui_set_current_layout_to): Remove.
5799
58002019-08-13 Tom Tromey <tom@tromey.com>
5801
5802 * tui/tui-layout.c (tui_set_layout): Update.
5803 * tui/tui-data.h (struct tui_layout_def): Remove.
5804 (tui_layout_def): Don't declare.
5805 * tui/tui-data.c (layout_def): Remove.
5806 (tui_layout_def): Remove.
5807
58082019-08-13 Tom Tromey <tom@tromey.com>
5809
5810 * tui/tui-winsource.h (struct tui_source_window_base)
5811 <clear_detail>: No longer "override".
5812 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5813 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5814 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5815 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5816 Remove.
5817 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5818
58192019-08-13 Tom Tromey <tromey@adacore.com>
5820
5821 * tracepoint.c: Don't include readline.h or history.h.
5822
58232019-08-12 Tom Tromey <tom@tromey.com>
5824
5825 * configure: Rebuild.
5826 * configure.ac: Check for readline 7.
5827 * NEWS: Mention readline 7 requirement.
5828 * README: Update.
5829
58302019-08-12 Tom Tromey <tom@tromey.com>
5831
5832 * mingw-hdep.c (gdb_select): Remove readline hack.
5833
58342019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5835
5836 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5837 when the function fails.
5838
58392019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5840
5841 * s390-tdep.c (s390_type_align): New function.
5842 (s390_gdbarch_init): Set it as type_align gdbarch method.
5843
58442019-08-09 Tom de Vries <tdevries@suse.de>
5845
5846 PR gdb/24591
5847 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5848 pc_low with relocation offset.
5849
58502019-08-07 Tom Tromey <tromey@adacore.com>
5851
5852 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5853 (print_frame_args): Update.
5854 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5855 Update.
5856 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5857 * frame.h (struct frame_arg): Add initializers.
5858 <error>: Now a unique_xmalloc_ptr.
5859
58602019-08-07 Alan Hayward <alan.hayward@arm.com>
5861
5862 * NEWS: Expand the Pointer Authentication entry.
5863 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5864 (aarch64_frame_unmask_lr): ... to this.
5865 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5866 Call aarch64_frame_unmask_lr.
5867 * frame.c (struct frame_info): Add "masked" variable.
5868 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5869 (fprint_frame): Check for masked pc.
5870 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5871 declarations.
5872 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5873 * stack.c (print_frame): Check for masked pc.
5874
58752019-08-06 Tom Tromey <tom@tromey.com>
5876
5877 * stabsread.c (patch_block_stabs, read_one_struct_field)
5878 (read_enum_type): Use obstack_strndup.
5879 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5880 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5881 * dwarf2read.c (guess_full_die_structure_name)
5882 (anonymous_struct_prefix): Use obstack_strndup.
5883 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5884 * c-exp.y (yylex): Use obstack_strndup.
5885 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5886 (write_var_or_type): Use obstack_strndup.
5887
58882019-08-06 Tom Tromey <tom@tromey.com>
5889
5890 * symfile.c (reread_symbols): Use obstack_strdup.
5891 * stabsread.c (read_type): Use obstack_strdup.
5892 * gdb_obstack.h (obstack_strdup): New overload.
5893 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5894 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5895 (dwarf2_canonicalize_name): Use obstack_strdup.
5896 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5897 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5898 Use obstack_strdup.
5899
59002019-08-06 Tom Tromey <tom@tromey.com>
5901
5902 * gdb_obstack.h (obstack_strdup): Define.
5903 * gdb_obstack.c (obstack_strdup): Don't define.
5904
59052019-08-06 Tom Tromey <tom@tromey.com>
5906
5907 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5908 obstack_strdup.
5909 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5910 obstack_strdup.
5911 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5912 * stabsread.c (common_block_start): Use obstack_strdup.
5913 * objfiles.c (set_objfile_main_name, objfile): Use
5914 obstack_strdup.
5915 * namespace.c (add_using_directive): Use obstack_strdup.
5916 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5917 * jit.c (finalize_symtab): Use obstack_strdup.
5918 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5919 (guess_partial_die_structure_name, partial_die_info::fixup)
5920 (dwarf2_name): Use obstack_strdup.
5921 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5922 obstack_strdup.
5923 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5924 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5925 obstack_strdup.
5926 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5927
59282019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5929
5930 * unittests/help-doc-selftests.c: New file.
5931 * Makefile.in: Add the new file.
5932
59332019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5934
5935 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5936 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5937 the full first line, except when FOR_VALUE_PREFIX. In this case,
5938 the trailing '.' is not output, and the first character is uppercased.
5939 (print_help_for_command): Update call to print_doc_line.
5940 (print_doc_of_command): Likewise.
5941 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5942 * cli/cli-option.c (append_indented_doc): Do not append newline.
5943 (build_help_option): Append newline after first appended_indented_doc
5944 only if a second call is done.
5945 (build_help): Append 2 new lines before each option, except the first
5946 one.
5947 * compile/compile.c (_initialize_compile): Add new lines after
5948 %OPTIONS%, when not at the end of the help.
5949 Change help doc or code
5950 producing the help doc to respect the invariants.
5951 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5952 Also removed the new line after 'Options:', as all other commands
5953 do not put an empty line between 'Options:' and the first option.
5954 * printcmd.c (_initialize_printcmd): Likewise.
5955 * stack.c (_initialize_stack): Likewise.
5956 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5957 incorrectly telling COMMAND is optional.
5958 * ada-lang.c (_initialize_ada_language): Change help doc or code
5959 producing the help doc to respect the invariants.
5960 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5961 * breakpoint.c (_initialize_breakpoint): Likewise.
5962 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5963 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5964 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5965 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5966 _initialize_cli_style): Likewise.
5967 * corelow.c (core_target_info): Likewise.
5968 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5969 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5970 * filesystem.c (_initialize_filesystem): Likewise.
5971 * frame.c (_initialize_frame): Likewise.
5972 * gnu-nat.c (add_task_commands): Likewise.
5973 * infcall.c (_initialize_infcall): Likewise.
5974 * infcmd.c (_initialize_infcmd): Likewise.
5975 * interps.c (_initialize_interpreter): Likewise.
5976 * language.c (_initialize_language): Likewise.
5977 * linux-fork.c (_initialize_linux_fork): Likewise.
5978 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5979 * maint.c (_initialize_maint_cmds): Likewise.
5980 * memattr.c (_initialize_mem): Likewise.
5981 * printcmd.c (_initialize_printcmd): Likewise.
5982 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5983 _RegEx): Likewise.
5984 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5985 * record-btrace.c (_initialize_record_btrace): Likewise.
5986 * record-full.c (_initialize_record_full): Likewise.
5987 * record.c (_initialize_record): Likewise.
5988 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5989 * regcache.c (_initialize_regcache): Likewise.
5990 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5991 _initialize_remote): Likewise.
5992 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5993 * serial.c (_initialize_serial): Likewise.
5994 * skip.c (_initialize_step_skip): Likewise.
5995 * source.c (_initialize_source): Likewise.
5996 * stack.c (_initialize_stack): Likewise.
5997 * symfile.c (_initialize_symfile): Likewise.
5998 * symtab.c (_initialize_symtab): Likewise.
5999 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6000 * top.c (init_main): Likewise.
6001 * tracefile-tfile.c (tfile_target_info): Likewise.
6002 * tracepoint.c (_initialize_tracepoint): Likewise.
6003 * tui/tui-win.c (_initialize_tui_win): Likewise.
6004 * utils.c (add_internal_problem_command): Likewise.
6005 * valprint.c (value_print_option_defs): Likewise.
6006
60072019-08-06 Frank Ch. Eigler <fche@redhat.com>
6008
6009 PR build/24886
6010 * configure.ac: Drop enable-libmcheck support.
6011 * configure, config.in: Rebuild.
6012 * libmcheck.m4: Remove.
6013 * acinclude.m4: Don't include it.
6014 * Makefile.in: Don't distribute it.
6015 * top.c (print_gdb_configuration): Don't mention it.
6016
60172019-08-06 Tom Tromey <tom@tromey.com>
6018
6019 * utils.c (set_output_style): Sometimes pass stream to
6020 emit_style_escape.
6021 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6022 * record-btrace.c (btrace_insn_history): Update.
6023 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6024 method.
6025 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6026 Update initializers.
6027 <m_uiout>: New field.
6028 <m_di>: Move lower.
6029 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6030 Remove "uiout" parameter.
6031 (dump_insns): Update.
6032 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6033 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6034
60352019-08-06 Christian Biesinger <cbiesinger@google.com>
6036
6037 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6038 (error_in_psymtab_expansion): Likewise.
6039 (lookup_symbol_via_quick_fns): Likewise.
6040 (basic_lookup_transparent_type_quick): Likewise.
6041 (basic_lookup_transparent_type_1): Likewise.
6042
60432019-08-06 Tom Tromey <tromey@adacore.com>
6044
6045 * source.c (last_source_error): Now bool.
6046 (print_source_lines_base): Make "noprint" bool. Only open
6047 source file when last_source_visited changes.
6048
60492019-08-06 Tom Tromey <tromey@adacore.com>
6050
6051 * annotate.c (annotate_source_line): Use g_source_cache.
6052 * source-cache.c (source_cache::get_plain_source_lines): Change
6053 parameters. Populate m_offset_cache.
6054 (source_cache::ensure): New method.
6055 (source_cache::get_line_charpos): New method.
6056 (extract_lines): Move lower. Change parameters.
6057 (source_cache::get_source_lines): Move lower.
6058 * source-cache.h (class source_cache): Update comment.
6059 <get_line_charpos>: New method.
6060 <get_source_lines>: Update comment.
6061 <clear>: Clear m_offset_cache.
6062 <get_plain_source_lines>: Change parameters.
6063 <ensure>: New method
6064 <m_offset_cache>: New member.
6065 * source.c (forget_cached_source_info_for_objfile): Update.
6066 (info_source_command): Use g_source_cache.
6067 (find_source_lines, open_source_file_with_line_charpos): Remove.
6068 (print_source_lines_base, search_command_helper): Use g_source_cache.
6069 * source.h (open_source_file_with_line_charpos): Don't declare.
6070 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6071 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6072 Use g_source_cache.
6073
60742019-08-06 Tom Tromey <tromey@adacore.com>
6075
6076 * source-cache.c (source_cache::get_plain_source_lines):
6077 Remove "first_line" and "last_line" parameters.
6078 (source_cache::get_source_lines): Cache plain text.
6079 * source-cache.h (class source_cache)
6080 <get_plain_source_lines>: Update.
6081
60822019-08-06 Tom Tromey <tromey@adacore.com>
6083
6084 * source-cache.c (extract_lines): No longer a method.
6085 Changed type of parameter. Include final newline.
6086 (selftests::extract_lines_test): New function.
6087 (_initialize_source_cache): Likewise.
6088 * source-cache.h (class source_cache)
6089 <extract_lines>: Don't declare.
6090
60912019-08-06 Tom Tromey <tromey@adacore.com>
6092
6093 * breakpoint.c (init_breakpoint_sal): Update.
6094 (breakpoint): Update.
6095 * breakpoint.h (struct breakpoint) <filter>: Now a
6096 unique_xmalloc_ptr.
6097
60982019-08-05 Christian Biesinger <cbiesinger@google.com>
6099
6100 * NEWS: Mention dictionary access on blocks.
6101 * python/py-block.c (blpy_getitem): New function.
6102 (block_object_as_mapping): New struct.
6103 (block_object_type): Use new struct for tp_as_mapping field.
6104
61052019-08-05 Christian Biesinger <cbiesinger@google.com>
6106
6107 * objfiles.h (objfile): Add a comment describing partial symbols.
6108
61092019-08-05 Tom Tromey <tromey@adacore.com>
6110
6111 * compile/compile.c (_initialize_compile): Use _(), not N_().
6112 * thread.c (_initialize_thread): Use _(), not N_().
6113 * stack.c (_initialize_stack): Use _(), not N_().
6114 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6115
61162019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6117
6118 * dwarf2read.c (struct dw2_symtab_iterator):
6119 <want_specific_block>: Remove.
6120 <block_index>: Change type to gdb::optional.
6121 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6122 change type of BLOCK_INDEX parameter to gdb::optional.
6123 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6124 (dw2_lookup_symbol): Don't pass argument for
6125 WANT_SPECIFIC_BLOCK.
6126 (dw2_expand_symtabs_for_function): Don't pass argument for
6127 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6128 (class dw2_debug_names_iterator)
6129 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6130 parameter, change BLOCK_INDEX type to gdb::optional.
6131 <m_want_specific_block>: Remove.
6132 <m_block_index>: Change type to gdb::optional.
6133 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6134 gdb::optional. Re-write in function of gdb::optional.
6135 (dw2_debug_names_lookup_symbol): Don't pass argument for
6136 WANT_SPECIFIC_BLOCK.
6137 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6138 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6139 BLOCK_INDEX.
6140
61412019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6142
6143 * NEWS: Mention changes to "info sources" command.
6144
61452019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6146
6147 * symtab.c (filename_partial_match_opts): New struct type.
6148 (struct output_source_filename_data): New members
6149 regexp, c_regexp, partial_match.
6150 (output_source_filename): Use new members to decide to print file.
6151 (info_sources_option_defs): New variable.
6152 (make_info_sources_options_def_group, print_info_sources_header,
6153 info_sources_command_completer):
6154 New functions.
6155 (info_sources_command): Read new optional arguments.
6156 (_initialize_symtab): Update info sources help.
6157
61582019-08-02 Alexandre Oliva <oliva@adacore.com>
6159
6160 * ada-lang.c (exception_support_info_v0): Renamed from...
6161 (default_exception_support_info): ... this. Create new
6162 definition for v1.
6163 (ada_has_this_exception_support): Look up catch_handlers_sym.
6164 (ada_exception_support_info_sniffer): Try v0 after default.
6165
61662019-08-01 Tom Tromey <tromey@adacore.com>
6167
6168 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6169 gdbarch.h.
6170
61712019-08-01 Christian Biesinger <cbiesinger@google.com>
6172
6173 * s12z-tdep.c: Fix include path for s12z-opc.h.
6174
61752019-08-01 Alan Hayward <alan.hayward@arm.com>
6176
6177 * NEWS: Require GNU make 3.82.
6178
61792019-07-16 Tom Tromey <tom@tromey.com>
6180
6181 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6182 declare.
6183
61842019-07-30 Tom Tromey <tromey@adacore.com>
6185
6186 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6187
61882019-07-30 Kevin Buettner <kevinb@redhat.com>
6189
6190 * printcmd.c (print_address_symbolic): Print negative offsets.
6191 (build_address_symbolic): Force signed arithmetic when computing
6192 offset.
6193
61942019-07-30 Christian Biesinger <cbiesinger@google.com>
6195
6196 PR/24474: Add a function to lookup static variables.
6197 * NEWS: Mention this new function.
6198 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6199 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6200 * python/python.c (python_GdbMethods): Add new function.
6201
62022019-07-29 Christian Biesinger <cbiesinger@google.com>
6203
6204 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6205 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6206 (objfpy_lookup_static_symbol): New function.
6207 (objfile_object_methods): Add new functions.
6208
62092019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6210
6211 * NEWS: Mention 'set|show print frame-info'. Mention new
6212 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6213 backtrace argument. Mention that python frame filtering code
6214 is now consistent with what 'backtrace' command prints.
6215
62162019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6217
6218 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6219 comments.
6220 (print_frame_info_auto, print_frame_info_source_line,
6221 print_frame_info_location, print_frame_info_source_and_location,
6222 print_frame_info_location_and_address, print_frame_info_short_location):
6223 New declarations.
6224 (struct frame_print_options): New member print_frame_info.
6225 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6226 * stack.h (get_user_print_what_frame_info): New declaration.
6227 (frame_show_address): New declaration.
6228 * stack.c (print_frame_arguments_choices): New value 'presence'.
6229 (print_frame_info_auto, print_frame_info_source_line,
6230 print_frame_info_location, print_frame_info_source_and_location,
6231 print_frame_info_location_and_address, print_frame_info_short_location,
6232 print_frame_info_choices, print_frame_info_print_what): New definitions.
6233 (print_frame_args): Only print dots for args if print frame-arguments
6234 is 'presence'.
6235 (frame_print_option_defs): New element for "frame-info".
6236 (get_user_print_what_frame_info): New function.
6237 (frame_show_address): Make non static. Move comment to stack.h.
6238 (print_frame_info_to_print_what): New function.
6239 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6240 to decide what to print.
6241 (backtrace_command_1): Handle the new print_frame_arguments_presence
6242 value.
6243 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6244 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6245 (py_print_frame): In non-mi mode, use LOCATION as default for
6246 print_what, similarly to frame information printed directly by
6247 backtrace command. Handle frame-info user option in non MI mode.
6248
62492019-07-27 Kevin Buettner <kevinb@redhat.com>
6250
6251 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6252 Add case for debugging 32-bit target on 64-bit host. Revise
6253 comment.
6254
62552019-07-27 Kevin Buettner <kevinb@redhat.com>
6256
6257 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6258 instead of find_function_entry_range_from_pc.
6259
62602019-07-27 Kevin Buettner <kevinb@redhat.com>
6261
6262 * stack.c (find_frame_funname): Remove code which preferred
6263 minsym over symtab sym in "certain pathological cases".
6264
6265 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6266 parameter. Change type of "do_demangle" to bool.
6267 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6268 Pass suitable "prefer_sym_over_minsym" flag to
6269 build_address_symbolic(). Don't output "+" for negative offsets.
6270 * printcmd.c (print_address_symbolic): Update invocation of
6271 build_address_symbolic to include a "prefer_sym_over_minsym"
6272 flag.
6273 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6274 Restrict cases in which use of minimal symbol is preferred to that
6275 of a found symbol. Update comments.
6276
6277 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6278 for entry pc when entry pc is out of range for that FDE.
6279
62802019-07-26 Brian Callahan <bcallah@openbsd.org>
6281
6282 PR gdb/24839:
6283 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6284 type.
6285
62862019-07-25 Christian Biesinger <cbiesinger@google.com>
6287
6288 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6289 this function's Python signature.
6290
6291
62922019-07-24 Christian Biesinger <cbiesinger@google.com>
6293
6294 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6295 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6296 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6297 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6298 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6299
6300
63012019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6302
6303 * h8300-tdep.c (h8300_register_name_common): New.
6304 h8300_register_name): Use h8300_register_name_common.
6305 (h8300s_register_name): Likewise.
6306 (h8300sx_register_name): Likewise.
6307 (h8300h_register_nam): New.
6308 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6309
6310
63112019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6312
6313 * arm-tdep.c (arm_skip_cmse_entry): New function.
6314 (arm_is_sgstubs_section): New function.
6315 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6316
63172019-07-22 Tom Tromey <tom@tromey.com>
6318
6319 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6320 Don't self-assign.
6321
63222019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6323
6324 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6325 type_print.
6326
63272019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6328
6329 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6330 so that GDB doesn't match any msymbols when searching in the
6331 TYPES_DOMAIN.
6332 (print_symbol_info): Print using typedef_print or type_print based
6333 on the type of the symbol. Add updated FIXME comment moved from...
6334 (_initialize_symtab): ... move and update FIXME comment to above.
6335
63362019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6337
6338 * NEWS: Mention adding -q option to "info types".
6339 * symtab.c (struct info_types_options): New struct.
6340 (info_types_options_defs): New variable.
6341 (make_info_types_options_def_group): New function.
6342 (info_types_command): Use gdb::option framework to parse options.
6343 (info_types_command_completer): New function.
6344 (_initialize_symtab): Extend the help text on "info types" and
6345 register command completer.
6346
63472019-07-21 Christian Biesinger <cbiesinger@google.com>
6348
6349 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6350 (lookup_symbol_in_objfile): Change int to block_enum and add a
6351 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6352
63532019-07-20 Christian Biesinger <cbiesinger@google.com>
6354
6355 * MAINTAINERS (Write After Approval): Add self.
6356
63572019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6358
6359 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6360 instruction to the dummy code region.
6361
63622019-07-19 Tom Tromey <tromey@adacore.com>
6363
6364 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6365 (ARGSUSED, PARAMS, __func__): Remove rules.
6366
63672019-07-19 Alan Hayward <alan.hayward@arm.com>
6368
6369 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6370 * features/arm/arm-with-iwmmxt.c: Remove.
6371 * features/arm/arm-with-iwmmxt.xml: Remove.
6372 * features/arm/arm-with-m-fpa-layout.c: Remove.
6373 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6374 * features/arm/arm-with-m-vfp-d16.c: Remove.
6375 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6376 * features/arm/arm-with-m.c: Remove.
6377 * features/arm/arm-with-m.xml: Remove.
6378 * features/arm/arm-with-neon.c: Remove.
6379 * features/arm/arm-with-neon.xml: Remove.
6380 * features/arm/arm-with-vfpv2.c: Remove.
6381 * features/arm/arm-with-vfpv2.xml: Remove.
6382 * features/arm/arm-with-vfpv3.c: Remove.
6383 * features/arm/arm-with-vfpv3.xml: Remove.
6384
63852019-07-19 Alan Hayward <alan.hayward@arm.com>
6386
6387 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6388
63892019-07-19 Alan Hayward <alan.hayward@arm.com>
6390
6391 * arch/aarch32.c (aarch32_create_target_description): Create
6392 target descriptions using features.
6393 * arch/arm.c (arm_create_target_description)
6394 (arm_create_mprofile_target_description): Likewise.
6395 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6396
63972019-07-19 Alan Hayward <alan.hayward@arm.com>
6398
6399 * Makefile.in: Add new files.
6400 * aarch32-tdep.c: New file.
6401 * aarch32-tdep.h: New file.
6402 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6403 Call aarch32_read_description.
6404 * arch/aarch32.c: New file.
6405 * arch/aarch32.h: New file.
6406 * arch/arm.c (arm_create_target_description)
6407 (arm_create_mprofile_target_description): New function.
6408 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6409 (arm_create_target_description)
6410 (arm_create_mprofile_target_description): New declaration.
6411 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6412 read_description functions.
6413 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6414 Likewise.
6415 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6416 * arm-tdep.c (tdesc_arm_list): New variable.
6417 (arm_register_g_packet_guesses): Call create description functions.
6418 (arm_read_description) (arm_read_mprofile_description): New
6419 function.
6420 * arm-tdep.h (arm_read_description)
6421 (arm_read_mprofile_description): Add declaration.
6422 * configure.tgt: Add new files.
6423
64242019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6425
6426 * top.c (new_ui_command): Open specified terminal just once.
6427
64282019-07-18 Tom Tromey <tromey@adacore.com>
6429
6430 * symtab.c (main_name): Constify return type.
6431 * symfile.c (set_initial_language): Update.
6432 * symtab.h (main_name): Constify return type.
6433
64342019-07-17 Tom Tromey <tom@tromey.com>
6435
6436 * tui/tui-winsource.c (tui_update_source_window)
6437 (tui_update_source_window_as_is)
6438 (tui_update_source_windows_with_line): Remove return.
6439 * tui/tui-disasm.c (tui_show_disassem)
6440 (tui_show_disassem_and_update_source): Remove return.
6441 * tui/tui.c (tui_reset): Remove return.
6442 * tui/tui-wingeneral.c
6443 (tui_check_and_display_highlight_if_needed): Remove return.
6444
64452019-07-17 Tom Tromey <tom@tromey.com>
6446
6447 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6448
64492019-07-17 Tom Tromey <tom@tromey.com>
6450
6451 * tui/tui-winsource.h (struct tui_exec_info_window)
6452 (struct tui_source_window_base): Move from tui-data.h.
6453 * tui/tui-winsource.c: Move many method definitions from
6454 elsewhere. Remove "structuring" comments.
6455 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6456 (tui_source_window_base::refresh_window): Move to
6457 tui-winsource.c.
6458 * tui/tui-win.c (tui_source_window_base::refresh_all)
6459 (tui_source_window_base::update_tab_width)
6460 (tui_source_window_base::set_new_height)
6461 (tui_source_window_base::do_make_visible_with_new_height): Move to
6462 tui-winsource.c.
6463 * tui/tui-source.h: Update.
6464 * tui/tui-source.c (tui_source_window_base::reset): Move to
6465 tui-winsource.c.
6466 * tui/tui-disasm.h: Update.
6467 * tui/tui-data.h (struct tui_exec_info_window): Move to
6468 tui-winsource.h.
6469 (struct tui_source_window_base): Likewise.
6470 * tui/tui-data.c (tui_source_window_base::clear_detail)
6471 (tui_source_window_base, ~tui_source_window_base): Move to
6472 tui-winsource.c.
6473
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-win.c (tui_resize_all)
6477 (tui_source_window_base::update_tab_width)
6478 (tui_adjust_win_heights): Update.
6479 (tui_win_info::make_invisible_and_set_new_height): Rename from
6480 make_invisible_and_set_new_height.
6481 * tui/tui-data.h (struct tui_win_info)
6482 <make_invisible_and_set_new_height>: New method.
6483
64842019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui.c: Update.
6487 * tui/tui-source.h (struct tui_source_window): Move from
6488 tui-data.h.
6489 * tui/tui-layout.c: Update.
6490 * tui/tui-disasm.c: Update.
6491 * tui/tui-data.h (struct tui_source_window): Move to
6492 tui-source.h.
6493
64942019-07-17 Tom Tromey <tom@tromey.com>
6495
6496 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6497 tui-data.h.
6498 * tui/tui-data.h (struct tui_disasm_window): Move to
6499 tui-disasm.h.
6500
65012019-07-17 Tom Tromey <tom@tromey.com>
6502
6503 * tui/tui-regs.h (struct tui_data_item_window): Move from
6504 tui-data.h.
6505 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6506 * tui/tui-data.h (struct tui_data_item_window): Move to
6507 tui-regs.h.
6508 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6509
65102019-07-17 Tom Tromey <tom@tromey.com>
6511
6512 * tui/tui.c: Update.
6513 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6514 (tui_cmd_window::max_height): Move to tui-command.c.
6515 * tui/tui-layout.c: Update.
6516 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6517 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6518 tui-command.c.
6519 * tui/tui-command.h (struct tui_cmd_window): Move from
6520 tui-data.h.
6521 * tui/tui-command.c: Remove "structuring" comments.
6522 (tui_cmd_window::clear_detail)
6523 (tui_cmd_window::do_make_visible_with_new_height)
6524 (tui_cmd_window::max_height): Move from elsewhere.
6525
65262019-07-17 Tom Tromey <tom@tromey.com>
6527
6528 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6529 Now static.
6530 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6531 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6532
65332019-07-17 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui.c: Update.
6536 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6537 tui-regs.c.
6538 * tui/tui-windata.h: Remove file.
6539 * tui/tui-windata.c: Remove file.
6540 * tui/tui-win.c (tui_data_window::set_new_height)
6541 (tui_data_window::do_make_visible_with_new_height): Move to
6542 tui-regs.c.
6543 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6544 * tui/tui-regs.c: Remove "structuring" comments.
6545 (tui_data_window::first_data_item_displayed)
6546 (tui_data_window::delete_data_content_windows)
6547 (tui_data_window::erase_data_content)
6548 (tui_data_window::display_all_data)
6549 (tui_data_window::refresh_all)
6550 (tui_data_window::do_scroll_vertical)
6551 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6552 (tui_data_window::do_make_visible_with_new_height)
6553 (tui_data_window::refresh_window): Move from elsewhere.
6554 (_initialize_tui_regs): Move to end of file.
6555 * tui/tui-layout.c: Update.
6556 * tui/tui-hooks.c: Update.
6557 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6558 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6559 tui-regs.c.
6560 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6561
65622019-07-17 Tom Tromey <tom@tromey.com>
6563
6564 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6565 seen.
6566
65672019-07-17 Tom Tromey <tom@tromey.com>
6568
6569 * tui/tui-win.c (tui_source_window_base::set_new_height)
6570 (tui_source_window_base::do_make_visible_with_new_height): Use
6571 m_has_locator field directly.
6572 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6573 method.
6574 (struct tui_source_window_base) <has_locator>: Likewise.
6575
65762019-07-17 Tom Tromey <tom@tromey.com>
6577
6578 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6579 Don't declare.
6580 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6581 Remove.
6582 * tui/tui-win.c (tui_source_window_base::set_new_height)
6583 (tui_source_window_base::set_new_height)
6584 (make_invisible_and_set_new_height)
6585 (tui_source_window_base::do_make_visible_with_new_height)
6586 (tui_source_window_base::do_make_visible_with_new_height):
6587 Update.
6588 * tui/tui-layout.c (show_source_disasm_command, show_data)
6589 (show_source_or_disasm_and_command): Update.
6590 * tui/tui-layout.c (show_layout): Update.
6591
65922019-07-17 Tom Tromey <tom@tromey.com>
6593
6594 * tui/tui-layout.c (make_data_window): Remove.
6595 (show_data): Unify creation and re-initialization cases.
6596
65972019-07-17 Tom Tromey <tom@tromey.com>
6598
6599 * tui/tui-layout.c (make_source_window, make_disasm_window):
6600 Remove.
6601 (show_data): Unify creation and re-initialization cases.
6602
66032019-07-17 Tom Tromey <tom@tromey.com>
6604
6605 * tui/tui-layout.c (make_command_window): Remove.
6606 (show_source_disasm_command, show_source_or_disasm_and_command):
6607 Unify creation and re-initialization cases.
6608
66092019-07-17 Tom Tromey <tom@tromey.com>
6610
6611 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6612 creation and re-initialization cases.
6613
66142019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 * tui/tui-regs.c (tui_get_register): Return void.
6617
66182019-07-17 Tom Tromey <tom@tromey.com>
6619
6620 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6621 Simplify.
6622
66232019-07-17 Tom Tromey <tom@tromey.com>
6624
6625 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6626 resetting.
6627
66282019-07-17 Tom Tromey <tom@tromey.com>
6629
6630 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6631 * tui/tui-regs.c (tui_reg_layout): New function.
6632 (tui_show_registers, tui_reg_command): Use it.
6633 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6634 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6635 parameters.
6636 (tui_layout_command): Remove.
6637
66382019-07-17 Tom Tromey <tom@tromey.com>
6639
6640 * tui/tui-layout.h (tui/tui-layout): Return void.
6641 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6642
66432019-07-17 Tom Tromey <tom@tromey.com>
6644
6645 * tui/tui-layout.c (show_source_disasm_command, show_data):
6646 Update.
6647 (reset_locator): Remove.
6648 (show_source_or_disasm_and_command): Update.
6649
66502019-07-17 Tom Tromey <tom@tromey.com>
6651
6652 * tui/tui-source.c (tui_source_window_base::reset): Remove
6653 win_type parameter.
6654 * tui/tui-layout.c (make_command_window, make_source_window)
6655 (make_disasm_window, make_data_window)
6656 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6657 (reset_locator, show_source_or_disasm_and_command): Update.
6658 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6659 win_type parameter.
6660 (struct tui_source_window_base) <reset>: Likewise.
6661
66622019-07-17 Tom Tromey <tom@tromey.com>
6663
6664 * tui/tui-layout.c (show_source_disasm_command): Use
6665 reset_locator.
6666 (reset_locator): New function.
6667 (init_and_make_win): Remove.
6668 (show_source_or_disasm_and_command): Use reset_locator.
6669
66702019-07-17 Tom Tromey <tom@tromey.com>
6671
6672 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6673 condition.
6674 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6675 Remove condition.
6676 * tui/tui-source.c (tui_source_window_base::reset): New method.
6677 * tui/tui-layout.c (make_command_window): Don't call
6678 init_and_make_win.
6679 (make_source_window, make_disasm_window): Don't call
6680 make_source_or_disasm_window.
6681 (make_data_window): Don't call init_and_make_win. Change calling
6682 convention.
6683 (show_source_disasm_command, show_data): Simplify.
6684 (make_source_or_disasm_window): Remove.
6685 (show_source_or_disasm_and_command): Simplify.
6686 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6687 (struct tui_source_window_base) <reset>: Likewise.
6688 <execution_info>: Remove initializer.
6689 * tui/tui-data.c (tui_source_window_base): Initialize
6690 execution_info.
6691
66922019-07-17 Tom Tromey <tom@tromey.com>
6693
6694 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6695 variable.
6696
66972019-07-17 Tom Tromey <tom@tromey.com>
6698
6699 * tui/tui.c (tui_rl_other_window): Update.
6700 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6701 superclass method first. Always iterate over regs_content.
6702 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6703 method.
6704 * tui/tui-win.c (tui_set_focus_command): Update.
6705
67062019-07-17 Tom Tromey <tom@tromey.com>
6707
6708 * tui/tui-win.c (tui_set_focus_command): Rename from
6709 tui_set_focus. Call tui_enable.
6710 (tui_set_focus_command): Remove.
6711
67122019-07-17 Tom Tromey <tom@tromey.com>
6713
6714 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6715 refresh_window.
6716 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6717 touchwin.
6718 (tui_data_window::refresh_window): Call refresh_window on data
6719 items. Always call superclass refresh_window.
6720 (tui_win_info::refresh): Remove.
6721 (tui_source_window_base::refresh_window): Update.
6722 (tui_refresh_all): Update.
6723 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6724 refresh_window.
6725 (show_source_or_disasm_and_command): Likewise.
6726 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6727 (struct tui_source_window_base) <refresh>: Likewise.
6728
67292019-07-17 Tom Tromey <tom@tromey.com>
6730
6731 * tui/tui-winsource.c (tui_clear_source_content)
6732 (tui_show_source_content): Update.
6733 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6734 whether content is empty.
6735 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6736 Remove.
6737
67382019-07-17 Tom Tromey <tom@tromey.com>
6739
6740 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6741 window's contents.
6742 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6743 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6744
67452019-07-17 Tom Tromey <tom@tromey.com>
6746
6747 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6748 (struct tui_data_item_window): Update.
6749
67502019-07-17 Tom Tromey <tom@tromey.com>
6751
6752 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6753 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6754 defines.
6755
67562019-07-17 Tom Tromey <tom@tromey.com>
6757
6758 * tui/tui-winsource.h (tui_erase_source_content)
6759 (tui_clear_source_content): Remove "display_prompt" parameter.
6760 * tui/tui-winsource.c (tui_update_source_window_as_is)
6761 (tui_update_source_windows_with_addr): Update.
6762 (tui_clear_source_content): Remove "display_prompt" parameter.
6763 (tui_erase_source_content): Likewise. Simplify.
6764 (tui_show_source_content): Update.
6765 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6766 * tui/tui-stack.c (tui_show_frame_info): Update.
6767 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6768 Remove defines.
6769
67702019-07-17 Tom Tromey <tom@tromey.com>
6771
6772 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6773 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6774 parameter.
6775 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6776 parameter.
6777
67782019-07-17 Tom Tromey <tom@tromey.com>
6779
6780 * tui/tui-winsource.c (tui_clear_source_content)
6781 (tui_show_source_content, tui_show_exec_info_content)
6782 (tui_clear_exec_info_content): Update.
6783 * tui/tui-stack.c (tui_show_locator_content): Update.
6784 (tui_show_frame_info): Update.
6785 * tui/tui-source.h (tui_source_window): Don't declare.
6786 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6787 from tui_source_is_displayed.
6788 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6789 Remove field.
6790 (struct tui_source_window_base) <content_in_use>: New field. Now
6791 bool.
6792 (struct tui_source_window) <showing_source_p>: New method.
6793 (TUI_SRC_WIN): Change cast.
6794 * tui/tui-data.c (tui_initialize_static_data): Update.
6795
67962019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6799 location_matches_p.
6800 * tui/tui-source.c (tui_source_window::location_matches_p): New
6801 method.
6802 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6803 method.
6804 * tui/tui-data.h (struct tui_source_window_base)
6805 <location_matches_p>: New method.
6806 (struct tui_source_window, struct tui_disasm_window)
6807 <location_matches_p>: Likewise.
6808
68092019-07-17 Tom Tromey <tom@tromey.com>
6810
6811 * tui/tui-win.c (tui_set_win_height_command): Rename from
6812 tui_set_win_height.
6813 (tui_set_win_height_command): Remove.
6814
68152019-07-17 Tom Tromey <tom@tromey.com>
6816
6817 * tui/tui-source.c (tui_source_window): New constructor. Add
6818 observer.
6819 (~tui_source_window): New destructor.
6820 (tui_source_window::style_changed): New method.
6821 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6822 (tui_attach_detach_observers): Update.
6823 * tui/tui-data.h (struct tui_source_window): Make constructor not
6824 inline. Add destructor.
6825 (struct tui_source_window) <style_changed>: New method.
6826 <m_observable>: New member.
6827
68282019-07-17 Tom Tromey <tom@tromey.com>
6829
6830 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6831 * tui/tui-win.c (tui_resize_all): Fix typo.
6832
68332019-07-17 Tom Tromey <tom@tromey.com>
6834
6835 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6836 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6837 (tui_refresh_all): Remove "list" parameter. Use foreach.
6838 * tui/tui-win.c (window_name_completer): Use foreach.
6839 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6840 (update_tab_width): Likewise.
6841 * tui/tui-layout.c (show_layout): Update.
6842 * tui/tui-data.h (class tui_window_iterator): New.
6843 (struct all_tui_windows): New.
6844 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6845
68462019-07-17 Tom Tromey <tom@tromey.com>
6847
6848 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6849 parameter. Don't reference globals.
6850 (tui_reg_command): Update.
6851
68522019-07-17 Tom Tromey <tom@tromey.com>
6853
6854 * tui/tui-regs.c (tui_show_registers): Simplify.
6855
68562019-07-17 Tom Tromey <tom@tromey.com>
6857
6858 * tui/tui-regs.c (tui_show_registers): Update.
6859 (tui_show_register_group): Add win_info parameter.
6860
68612019-07-17 Tom Tromey <tom@tromey.com>
6862
6863 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6864 Rename from tui_display_reg_element_at_line.
6865 (tui_data_window::display_registers_from_line): Update.
6866 * tui/tui-data.h (struct tui_data_window)
6867 <display_reg_element_at_line>: New method.
6868
68692019-07-17 Tom Tromey <tom@tromey.com>
6870
6871 * tui/tui-regs.h (tui_display_registers_from)
6872 (tui_display_registers_from_line): Don't declare.
6873 * tui/tui-windata.c (tui_data_window::display_all_data)
6874 (tui_data_window::refresh_all)
6875 (tui_data_window::do_scroll_vertical): Update.
6876 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6877 from tui_display_registers_from.
6878 (tui_display_reg_element_at_line): Update.
6879 (tui_data_window::display_registers_from_line): Rename from
6880 tui_display_registers_from_line.
6881 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6882 display_registers_from_line>: New methods.
6883
68842019-07-17 Tom Tromey <tom@tromey.com>
6885
6886 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6887 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6888 from tui_erase_data_content.
6889 (tui_data_window::display_all_data)
6890 (tui_data_window::refresh_all)
6891 (tui_data_window::do_scroll_vertical): Update.
6892 * tui/tui-regs.c (tui_show_registers): Update.
6893 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6894 New method.
6895
68962019-07-17 Tom Tromey <tom@tromey.com>
6897
6898 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6899 declare.
6900 * tui/tui-windata.c
6901 (tui_data_window::delete_data_content_windows): Rename from
6902 tui_delete_data_content_windows.
6903 (tui_data_window::display_all_data)
6904 (tui_data_window::do_scroll_vertical): Update.
6905 * tui/tui-data.h (struct tui_data_window)
6906 <delete_data_content_windows>: New method.
6907
69082019-07-17 Tom Tromey <tom@tromey.com>
6909
6910 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6911 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6912
69132019-07-17 Tom Tromey <tom@tromey.com>
6914
6915 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6916 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6917 from tui_display_all_data.
6918 * tui/tui-win.c
6919 (tui_data_window::do_make_visible_with_new_height): Update.
6920 * tui/tui-regs.c (tui_show_registers): Update.
6921 * tui/tui-layout.c (tui_set_layout): Update.
6922 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6923 method.
6924
69252019-07-17 Tom Tromey <tom@tromey.com>
6926
6927 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6928 * tui/tui-windata.c (tui_display_data_from): Remove.
6929 (tui_data_window::refresh_all): Update.
6930
69312019-07-17 Tom Tromey <tom@tromey.com>
6932
6933 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6934 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6935 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6936 tui_display_registers_from_line.
6937 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6938 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6939 "force_display" parameter.
6940
69412019-07-17 Tom Tromey <tom@tromey.com>
6942
6943 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6944 declare.
6945 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6946 Rename from tui_first_reg_element_no_inline.
6947 (tui_display_reg_element_at_line)
6948 (tui_display_registers_from_line): Update.
6949 * tui/tui-data.h (struct tui_data_window)
6950 <first_reg_element_no_inline>: New method.
6951
69522019-07-17 Tom Tromey <tom@tromey.com>
6953
6954 * tui/tui-windata.c (tui_display_data_from)
6955 (tui_data_window::do_scroll_vertical): Update.
6956 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6957 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6958 Rename from tui_line_from_reg_element_no.
6959 (tui_display_registers_from_line): Update.
6960 * tui/tui-data.h (struct tui_data_window)
6961 <line_from_reg_element_no>: New method.
6962
69632019-07-17 Tom Tromey <tom@tromey.com>
6964
6965 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6966 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6967 tui_last_regs_line_no.
6968 (tui_display_reg_element_at_line)
6969 (tui_display_registers_from_line): Update.
6970 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6971 method.
6972
69732019-07-17 Tom Tromey <tom@tromey.com>
6974
6975 PR tui/24722:
6976 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6977 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6978 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6979 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6980 (tui_update_breakpoint_info): Likewise.
6981 * tui/tui-hooks.c (tui_event_create_breakpoint)
6982 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6983 Update.
6984
69852019-07-17 Tom Tromey <tom@tromey.com>
6986
6987 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6988
69892019-07-17 Tom Tromey <tom@tromey.com>
6990
6991 * tui/tui-winsource.c (tui_update_source_window_as_is)
6992 (tui_update_source_windows_with_addr): Update.
6993 * tui/tui-source.h (tui_set_source_content)
6994 (tui_show_symtab_source): Add "win_info" parameter.
6995 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6996 parameter.
6997 (tui_show_symtab_source): Likewise.
6998
69992019-07-17 Tom Tromey <tom@tromey.com>
7000
7001 * tui/tui-wingeneral.c
7002 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7003
70042019-07-17 Tom Tromey <tom@tromey.com>
7005
7006 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7007 (struct tui_cmd_window) <can_scroll>: New method.
7008 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7009 method.
7010
70112019-07-17 Tom Tromey <tromey@adacore.com>
7012
7013 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7014 do_field_signed>: Rename. Change type of "value".
7015 * ui-out.c (ui_out::field_signed): Rename from field_int.
7016 Change type of "value".
7017 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7018 type of "value".
7019 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7020 do_field_int. Change type of "value".
7021 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7022 do_field_int. Change type of "value".
7023 * tracepoint.c (trace_status_mi, tfind_1)
7024 (print_one_static_tracepoint_marker): Update.
7025 * thread.c (print_thread_info_1, print_selected_thread_frame):
7026 Update.
7027 * stack.c (print_frame, print_frame_info): Update.
7028 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7029 Update.
7030 * source.c (print_source_lines_base): Update.
7031 * skip.c (info_skip_command): Update.
7032 * record-btrace.c (btrace_ui_out_decode_error)
7033 (btrace_call_history_src_line): Update.
7034 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7035 Update.
7036 * progspace.c (print_program_space): Update.
7037 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7038 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7039 do_field_int. Change type of "value".
7040 * mi/mi-out.c (mi_ui_out::do_table_begin)
7041 (mi_ui_out::do_table_header): Update.
7042 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7043 type of "value".
7044 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7045 (mi_cmd_data_list_changed_registers, output_register)
7046 (mi_cmd_data_read_memory, mi_load_progress)
7047 (mi_cmd_trace_frame_collected): Update.
7048 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7049 Update.
7050 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7051 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7052 (mi_cmd_var_list_children, varobj_update_one): Update.
7053 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7054 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7055 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7056 * inferior.c (print_inferior): Update.
7057 * gdb_bfd.c (print_one_bfd): Update.
7058 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7059 Update.
7060 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7061 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7062 do_field_int. Change type of "value".
7063 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7064 do_field_int. Change type of "value".
7065 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7066 (print_one_breakpoint_location, print_it_catch_fork)
7067 (print_one_catch_fork, print_it_catch_vfork)
7068 (print_one_catch_vfork, print_it_catch_solib)
7069 (print_it_catch_exec, print_it_ranged_breakpoint)
7070 (print_mention_watchpoint, print_mention_masked_watchpoint)
7071 (bkpt_print_it, update_static_tracepoint): Update.
7072 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7073 * break-catch-syscall.c (print_it_catch_syscall): Update.
7074 * ada-tasks.c (print_ada_task_info): Update.
7075 * ada-lang.c (print_it_exception, print_mention_exception):
7076 Update.
7077
70782019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7079
7080 PR breakpoints/24541
7081 * gdbarch.c: Regenerate.
7082 * gdbarch.h: Regenerate.
7083 * gdbarch.sh: Adjust return type and parameter types for
7084 'stap_adjust_register'.
7085 (i386_stap_adjust_register): Adjust signature and return new
7086 register name.
7087 * stap-probe.c (stap_parse_register_operand): Adjust use of
7088 'gdbarch_stap_adjust_register'.
7089
70902019-07-17 Tom Tromey <tromey@adacore.com>
7091
7092 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7093 declare VEC.
7094 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7095 std::vector.
7096 (struct s390_process_info): Add initializers.
7097 (s390_add_process): Use new.
7098 (s390_linux_nat_target::low_forget_process): Use delete.
7099 (s390_linux_nat_target::low_new_fork)
7100 (s390_linux_nat_target::stopped_by_watchpoint)
7101 (s390_linux_nat_target::low_prepare_to_resume)
7102 (s390_linux_nat_target::insert_watchpoint)
7103 (s390_linux_nat_target::insert_hw_breakpoint)
7104 (s390_linux_nat_target::remove_watchpoint)
7105 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7106
71072019-07-16 John Baldwin <jhb@FreeBSD.org>
7108
7109 * aarch64-fbsd-nat.c: Include regcache.h.
7110 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7111 argument.
7112 (aarch64_fbsd_nat_target::fetch_registers)
7113 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7114 variable.
7115 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7116
71172019-07-16 John Baldwin <jhb@FreeBSD.org>
7118
7119 * fbsd-nat.c: Include gdbarch.h.
7120
71212019-07-15 Tom Tromey <tromey@adacore.com>
7122
7123 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7124
71252019-07-15 Tom Tromey <tromey@adacore.com>
7126
7127 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7128 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7129 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7130 * cli-out.c (cli_ui_out::do_field_int): New method.
7131 * ui-out.c (ui_out::field_unsigned): New method.
7132 * symfile.c (generic_load): Use field_unsigned.
7133 (print_transfer_performance): Likewise.
7134 * record-btrace.c (ui_out_field_uint): Remove.
7135 (btrace_call_history_insn_range, btrace_call_history): Use
7136 field_unsigned.
7137 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7138 field_unsigned.
7139 * ui-out.h (class ui_out) <field_unsigned>: New method.
7140 <do_field_unsigned>: Likewise.
7141
71422019-07-15 Tom Tromey <tromey@adacore.com>
7143
7144 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7145 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7146 * target.c (flash_erase_command): Use field_string.
7147 * infrun.c (print_signal_received_reason): Use field_string.
7148 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7149 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7150 field_string.
7151 * ada-tasks.c (print_ada_task_info): Use field_string.
7152
71532019-07-15 Tom Tromey <tromey@adacore.com>
7154
7155 * target.c (flash_erase_command): Use field_core_addr.
7156 * symfile.c (generic_load): Use field_core_addr.
7157 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7158 Use field_core_addr.
7159 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7160 field_core_addr.
7161
71622019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7163
7164 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7165 value if its desired type is smaller than a CORE_ADDR and signed.
7166
71672019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7168
7169 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7170 of changes to field names, and use new is_reference field to
7171 decide if a property is a reference or not.
7172 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7173 field.
7174 (struct dwarf2_property_baton): Update header comment, rename
7175 'referenced_type' to 'property_type' and update comments.
7176 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7177 default property type, store in property baton, update to take
7178 accound of renamed field.
7179 (read_func_scope): Update call to attr_to_dynamic_prop.
7180 (read_array_type): Likewise.
7181 (dwarf2_per_cu_addr_sized_int_type): New function.
7182 (read_subrange_index_type): Move type finding code to
7183 dwarf2_per_cu_addr_sized_int_type.
7184 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7185 (dwarf2_per_cu_addr_type): New function.
7186 (set_die_type): Update calls to attr_to_dynamic_prop.
7187
71882019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7189
7190 * dwarf2read.c (read_subrange_index_type): New function.
7191 (read_subrange_type): Move code into new function and call it.
7192 * gdbtypes.c (create_range_type): Add some asserts.
7193
71942019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7195
7196 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7197 update return statements.
7198 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7199 declaration, and update comment to match.
7200 * gdbtypes.c (resolve_dynamic_array): Update call to
7201 dwarf2_evaluate_property to match new return type.
7202
72032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7204
7205 * valarith.c (value_subscripted_rvalue): Change lowerbound
7206 parameter type from int to LONGEST.
7207 * value.h (value_subscripted_rvalue): Likewise in declaration.
7208
72092019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7210
7211 * cli/cli-utils.c (info_print_command_completer): New function.
7212 * cli/cli-utils.h: Add 'completer.h' include, and forward
7213 declaration for 'struct cmd_list_element'.
7214 (info_print_command_completer): Declare.
7215 * stack.c (_initialize_stack): Add completer for 'info locals' and
7216 'info args'.
7217 * symtab.c (_initialize_symtab): Add completer for 'info
7218 variables' and 'info functions'.
7219 * NEWS: Mention completion for additional info commands.
7220
72212019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7222
7223 * cli/cli-utils.c (extract_info_print_args): Delete.
7224 (extract_arg_maybe_quoted): Delete.
7225 (info_print_options_defs): New variable.
7226 (make_info_print_options_def_group): New function.
7227 (extract_info_print_options): Define new function.
7228 * cli/cli-utils.h (extract_info_print_args): Delete.
7229 (struct info_print_options): New structure.
7230 (extract_info_print_options): Declare new function.
7231 * stack.c (info_locals_command): Update to use new
7232 extract_info_print_options, also add a header comment.
7233 (info_args_command): Likewise.
7234 * symtab.c (info_variables_command): Likewise.
7235 (info_functions_command): Likewise.
7236
72372019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7238
7239 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7240 to extract string arguments.
7241 * common/common-utils.c (extract_string_maybe_quoted): New function.
7242 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7243
72442019-07-11 Tom Tromey <tromey@adacore.com>
7245
7246 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7247 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7248 * top.h (gdbinit): Don't declare.
7249 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7250 into...
7251 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7252 * top.c (gdb_init): Don't call init_cli_cmds.
7253 (gdbinit): Remove.
7254 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7255
72562019-07-11 Tom Tromey <tromey@adacore.com>
7257
7258 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7259 after it has been moved.
7260
72612019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7262
7263 * valops.c (value_must_coerce_to_target): Change return type to
7264 bool.
7265 * value.h (value_must_coerce_to_target): Likewise.
7266
72672019-07-10 Simon Marchi <simon.marchi@efficios.com>
7268
7269 * breakpoint.c (is_hardware_watchpoint): Remove
7270 forward-declaration.
7271 (is_masked_watchpoint): Change return type to bool.
7272 (is_tracepoint): Likewise.
7273 (is_breakpoint): Likewise.
7274 (is_hardware_watchpoint): Likewise.
7275 (is_watchpoint): Likewise.
7276 (is_no_memory_software_watchpoint): Likewise.
7277 (is_catchpoint): Likewise.
7278 (breakpoint_1): Make FILTER parameter's return type bool.
7279 is_masked_watchpoint): Change return type to bool.
7280 (save_breakpoints): Make FILTER parameter's return type bool.
7281 * breakpoint.h (is_breakpoint): Change return type to bool.
7282 (is_watchpoint): Likewise.
7283 (is_catchpoint): Likewise.
7284 (is_tracepoint): Likewise.
7285
72862019-07-10 Tom Tromey <tom@tromey.com>
7287
7288 * defs.h: Don't include gdbarch.h.
7289 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7290 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7291 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7292 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7293 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7294 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7295 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7296 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7297 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7298 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7299 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7300 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7301 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7302 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7303 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7304 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7305 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7306 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7307 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7308 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7309 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7310 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7311 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7312 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7313 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7314 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7315 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7316
73172019-07-10 Tom Tromey <tromey@adacore.com>
7318
7319 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7320 * breakpoint.c (init_ada_exception_breakpoint): Register as
7321 bp_catchpoint.
7322 (print_one_breakpoint_location, print_one_breakpoint): Use
7323 is_ada_exception_catchpoint.
7324 * ada-lang.c (class ada_catchpoint_location): Pass
7325 bp_loc_software_breakpoint to bp_location constructor.
7326 (is_ada_exception_catchpoint): New function.
7327
73282019-07-10 Tom Tromey <tromey@adacore.com>
7329
7330 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7331 VEC.
7332 (struct arm_exidx_entry): New method operator<.
7333 (struct arm_exidx_data) <section_maps>: Change type.
7334 (arm_exidx_data_free): Remove.
7335 (arm_exidx_data_key): Change type. Move lower.
7336 (arm_exidx_new_objfile): Update.
7337 (arm_compare_exidx_entries): Remove.
7338 (arm_find_exidx_entry, _initialize_arm_tdep)
7339
73402019-07-10 Tom Tromey <tromey@adacore.com>
7341
7342 * solib-spu.c (ocl_program_data_key): Change type.
7343 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7344 Update.
7345
73462019-07-10 Tom Tromey <tromey@adacore.com>
7347
7348 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7349 (struct solib_aix_inferior_data) <library_list>: Change type.
7350 (solib_aix_inferior_data_handle): Change type.
7351 (get_solib_aix_inferior_data): Update.
7352 (solib_aix_free_library_list): Remove.
7353 (library_list_start_library): Update.
7354 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7355 return type.
7356 (solib_aix_get_library_list)
7357 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7358 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7359
73602019-07-10 Tom Tromey <tromey@adacore.com>
7361
7362 * solib-dsbt.c (struct dsbt_info): Add initializers.
7363 (solib_dsbt_pspace_data): Change type.
7364 (dsbt_pspace_data_cleanup): Remove.
7365 (get_dsbt_info, _initialize_dsbt_solib): Update.
7366
73672019-07-10 Tom Tromey <tromey@adacore.com>
7368
7369 * spu-tdep.c (spu_overlay_data): Change type.
7370 (spu_get_overlay_table, spu_overlay_new_objfile)
7371 (_initialize_spu_tdep): Update.
7372
73732019-07-10 Tom Tromey <tromey@adacore.com>
7374
7375 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7376 destructor.
7377 (dbx_objfile_data_key): Change type and declare later.
7378 (DBX_SYMFILE_INFO): Rewrite.
7379 * dbxread.c (dbx_objfile_data_key): Change type.
7380 (dbx_symfile_init): Update.
7381 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7382 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7383 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7384
73852019-07-10 Tom Tromey <tromey@adacore.com>
7386
7387 * jit.c (jit_program_space_key): Change type. Move lower.
7388 (get_jit_program_space_data): Update.
7389 (jit_program_space_data_cleanup): Remove.
7390 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7391 Update.
7392 (struct jit_program_space_data): Add initializers.
7393
73942019-07-10 Tom Tromey <tromey@adacore.com>
7395
7396 * solib-darwin.c (struct darwin_info): Add initializers.
7397 (solib_darwin_pspace_data): Change type.
7398 (darwin_pspace_data_cleanup): Remove.
7399 (get_darwin_info, _initialize_darwin_solib): Update.
7400
74012019-07-10 Tom Tromey <tromey@adacore.com>
7402
7403 * remote-sim.c (struct sim_inferior_data): Add initializers,
7404 constructor, and destructor.
7405 (sim_inferior_data_key): Change type. Move lower.
7406 (check_for_duplicate_sim_descriptor): Update.
7407 (get_sim_inferior_data): Use new. Update.
7408 (~sim_inferior_data_cleanup): Rename from
7409 sim_inferior_data_cleanup. Simplify.
7410 (gdbsim_close_inferior, simulator_command)
7411 (sim_command_completer, _initialize_remote_sim): Update.
7412 (next_pid, INITIAL_PID): Move earlier.
7413
74142019-07-10 Tom Tromey <tromey@adacore.com>
7415
7416 * python/python-internal.h (create_thread_object): Return
7417 gdbpy_ref.
7418 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7419 * python/py-inferior.c (struct threadlist_entry): Add
7420 constructor.
7421 <thread_obj>: Now a gdbpy_ref.
7422 (thread_to_thread_object): Update.
7423 (add_thread_object): Use new.
7424 (delete_thread_object): Use delete.
7425 (infpy_threads): Update.
7426 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7427 GIL.
7428
74292019-07-10 Tom Tromey <tromey@adacore.com>
7430
7431 * valops.c (value_cast): Specialize error message for Ada.
7432
74332019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7434
7435 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7436
74372019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7438
7439 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7440 bpstat_should_step): Return bool, adjust comments.
7441 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7442 bpstat_should_step): Likewise.
7443
74442019-07-10 Alan Hayward <alan.hayward@arm.com>
7445
7446 * features/Makefile: Use feature target descriptions for Arm.
7447 * features/arm/arm-core.c: Generate new file.
7448 * features/arm/arm-fpa.c: Likewise.
7449 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7450 * features/arm/arm-m-profile.c: Likewise.
7451 * features/arm/arm-vfpv2.c: Likewise.
7452 * features/arm/arm-vfpv3.c: Likewise.
7453 * features/arm/xscale-iwmmxt.c: Likewise.
7454 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7455
74562019-07-10 Alan Hayward <alan.hayward@arm.com>
7457
7458 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7459 ptrace earlier.
7460
74612019-07-10 Alan Hayward <alan.hayward@arm.com>
7462
7463 * features/aarch64-pauth.c: Regenerate.
7464
74652019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7466
7467 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7468 bool.
7469 (bpstat_what): Use false instead of 0.
7470
74712019-07-09 Pedro Alves <palves@redhat.com>
7472
7473 * break-catch-throw.c (is_exception_catchpoint): New.
7474 * breakpoint.c (print_one_breakpoint_location): New parameter
7475 'raw_loc'. Handle it. Use
7476 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7477 looking at the breakpoint's type.
7478 (print_one_breakpoint): If handling "maint info breakpoints", also
7479 print locations of exception catchpoints.
7480 * breakpoint.h (is_exception_catchpoint): Declare.
7481
74822019-07-09 Pedro Alves <palves@redhat.com>
7483
7484 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7485 "addr" field.
7486 (allocate_location_exception_catchpoint): New.
7487 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7488 (initialize_throw_catchpoint_ops): Install
7489 allocate_location_exception_catchpoint as allocate_location
7490 method.
7491 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7492 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7493 bp_loc_other.
7494 (breakpoint_address_is_meaningful): Delete.
7495 (bl_address_is_meaningful): New.
7496 (breakpoint_locations_match): Adjust comment.
7497 (bp_location_from_bp_type): New, factored out of...
7498 (bp_location::bp_location(breakpoint *)): ... this.
7499 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7500 factored out of...
7501 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7502 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7503 breakpoint_address_is_meaningful.
7504 (bp_locations_compare): Adjust comment.
7505 (update_global_location_list): Use bl_address_is_meaningful
7506 instead of breakpoint_address_is_meaningful.
7507 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7508 explicit.
7509 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7510 * python/py-breakpoint.c (bppy_get_location): No longer check
7511 whether location is null.
7512
75132019-07-09 Pedro Alves <palves@redhat.com>
7514
7515 PR c++/15468
7516 * breakpoint.c (print_one_breakpoint_location): Remove
7517 single-location assert.
7518
75192019-07-09 Tom Tromey <tom@tromey.com>
7520
7521 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7522 * configure: Rebuild.
7523 * configure.ac: Change common to gdbsupport.
7524 * gdbsupport: Rename from common.
7525 * acinclude.m4: Change common to gdbsupport.
7526 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7527 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7528 gdbsupport.
7529 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7530 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7531 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7532 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7533 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7534 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7535 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7536 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7537 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7538 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7539 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7540 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7541 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7542 coff-pe-read.c, command.h, compile/compile-c-support.c,
7543 compile/compile-c.h, compile/compile-cplus-symbols.c,
7544 compile/compile-cplus-types.c, compile/compile-cplus.h,
7545 compile/compile-loc2c.c, compile/compile.c, completer.c,
7546 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7547 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7548 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7549 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7550 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7551 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7552 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7553 features/aarch64-core.c, features/aarch64-fpu.c,
7554 features/aarch64-pauth.c, features/aarch64-sve.c,
7555 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7556 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7557 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7558 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7559 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7560 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7561 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7562 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7563 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7564 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7565 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7566 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7567 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7568 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7569 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7570 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7571 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7572 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7573 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7574 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7575 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7576 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7577 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7578 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7579 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7580 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7581 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7582 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7583 minsyms.c, mips-linux-tdep.c, namespace.h,
7584 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7585 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7586 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7587 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7588 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7589 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7590 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7591 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7592 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7593 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7594 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7595 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7596 procfs.c, producer.c, progspace.h, psymtab.h,
7597 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7598 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7599 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7600 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7601 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7602 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7603 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7604 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7605 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7606 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7607 target-memory.c, target.c, target.h, target/waitstatus.c,
7608 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7609 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7610 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7611 unittests/array-view-selftests.c,
7612 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7613 unittests/common-utils-selftests.c,
7614 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7615 unittests/format_pieces-selftests.c,
7616 unittests/function-view-selftests.c,
7617 unittests/lookup_name_info-selftests.c,
7618 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7619 unittests/mkdir-recursive-selftests.c,
7620 unittests/observable-selftests.c,
7621 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7622 unittests/parse-connection-spec-selftests.c,
7623 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7624 unittests/scoped_fd-selftests.c,
7625 unittests/scoped_mmap-selftests.c,
7626 unittests/scoped_restore-selftests.c,
7627 unittests/string_view-selftests.c, unittests/style-selftests.c,
7628 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7629 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7630 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7631 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7632 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7633 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7634
76352019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7636
7637 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7638 bool value.
7639 (decode_digits_ordinary): Set explicit_line field in sal.
7640 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7641 symtab_and_line that was set on an explicit line number in
7642 assembler code. Do always update the recorded symtab and line if
7643 we do skip the prologue.
7644
76452019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7646
7647 * breakpoint.c (set_breakpoint_location_function): Remove
7648 explicit_loc parameter.
7649 (momentary_breakpoint_from_master): Update call to
7650 set_breakpoint_location_function.
7651 (add_location_to_breakpoint): Likewise.
7652
76532019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7654
7655 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7656 required features based on default bfd type when no specific bfd
7657 is present.
7658
76592019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7660
7661 * NEWS: Mention that GDB printf and eval commands can now print
7662 C-style and Ada-style convenience var strings without
7663 calling the inferior.
7664 * printcmd.c (printf_c_string): Locally print GDB internal var
7665 instead of transiting via the inferior.
7666 (printf_wide_c_string): Likewise.
7667
76682019-07-04 Alan Hayward <alan.hayward@arm.com>
7669
7670 PR breakpoints/25011
7671 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7672
76732019-07-04 Tom Tromey <tom@tromey.com>
7674
7675 PR tui/24724:
7676 * tui/tui-winsource.c (tui_clear_source_content): Update.
7677 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7678 (tui_update_breakpoint_info): Update.
7679 (tui_set_exec_info_content): Update.
7680 * tui/tui-source.c (tui_set_source_content_nil): Update.
7681 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7682 has_break.
7683 * tui/tui-data.h (enum tui_bp_flag): New.
7684 (tui_bp_flags): New enum flags type.
7685 (struct tui_source_element) <break_mode>: Change type. Rename
7686 from has_break.
7687 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7688 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7689 constants.
7690 * tui/tui-winsource.h: Fix comment.
7691
76922019-07-04 Alan Hayward <alan.hayward@arm.com>
7693
7694 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7695 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7696 (store_fpregs_to_thread)
7697 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7698 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7699 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7700 (IWMMXT_REGS_SIZE): Add define.
7701 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7702 (fetch_vfp_regs, store_vfp_regs)
7703 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7704 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7705
77062019-07-04 Alan Hayward <alan.hayward@arm.com>
7707
7708 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7709 defines.
7710 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7711 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7712 (ARM_INT_REGISTER_SIZE): ...to this.
7713 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7714 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7715 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7716 (arm_linux_collect_gregset, supply_nwfpe_register)
7717 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7718 defines.
7719 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7720 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7721 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7722 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7723 (arm_return_in_memory, arm_store_return_value)
7724 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7725 (arm_record_ld_st_multiple): Likewise.
7726 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7727 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7728
77292019-07-04 Alan Hayward <alan.hayward@arm.com>
7730
7731 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7732 AARCH64_DISPLACED_MODIFIED_INSNS.
7733 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7734 (aarch64_displaced_step_copy_insn): Likewise.
7735 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7736 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7737 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7738 ARM_DISPLACED_MODIFIED_INSNS.
7739 * arm-tdep.c (arm_gdbarch_init): Likewise.
7740 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7741 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7742 (struct arm_displaced_step_closure): Use
7743 ARM_DISPLACED_MODIFIED_INSNS.
7744
77452019-07-04 Alan Hayward <alan.hayward@arm.com>
7746
7747 * features/Makefile: Remove unused xml files.
7748 * features/aarch64.xml: Remove.
7749 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7750 * features/i386/amd64-avx-avx512.xml: Remove.
7751 * features/i386/amd64-avx-linux.xml: Remove.
7752 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7753 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7754 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7755 * features/i386/amd64-avx-mpx.xml: Remove.
7756 * features/i386/amd64-avx.xml: Remove.
7757 * features/i386/amd64-linux.xml: Remove.
7758 * features/i386/amd64-mpx-linux.xml: Remove.
7759 * features/i386/amd64-mpx.xml: Remove.
7760 * features/i386/amd64.xml: Remove.
7761 * features/i386/i386-avx-avx512-linux.xml: Remove.
7762 * features/i386/i386-avx-avx512.xml: Remove.
7763 * features/i386/i386-avx-linux.xml: Remove.
7764 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7765 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7766 * features/i386/i386-avx-mpx-linux.xml: Remove.
7767 * features/i386/i386-avx-mpx.xml: Remove.
7768 * features/i386/i386-avx.xml: Remove.
7769 * features/i386/i386-linux.xml: Remove.
7770 * features/i386/i386-mmx-linux.xml: Remove.
7771 * features/i386/i386-mmx.xml: Remove.
7772 * features/i386/i386-mpx-linux.xml: Remove.
7773 * features/i386/i386-mpx.xml: Remove.
7774 * features/i386/i386.xml: Remove.
7775 * features/i386/x32-avx-avx512-linux.xml: Remove.
7776 * features/i386/x32-avx-linux.xml: Remove.
7777 * features/i386/x32-linux.xml: Remove.
7778
77792019-07-04 Alan Hayward <alan.hayward@arm.com>
7780
7781 * regformats/aarch64.dat: Remove.
7782 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7783 * regformats/i386/amd64-avx-linux.dat: Remove.
7784 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7785 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7786 * regformats/i386/amd64-linux.dat: Remove.
7787 * regformats/i386/amd64-mpx-linux.dat: Remove.
7788 * regformats/i386/amd64.dat: Remove.
7789 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7790 * regformats/i386/i386-avx-linux.dat: Remove.
7791 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7792 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7793 * regformats/i386/i386-linux.dat: Remove.
7794 * regformats/i386/i386-mmx-linux.dat: Remove.
7795 * regformats/i386/i386-mpx-linux.dat: Remove.
7796 * regformats/i386/i386.dat: Remove.
7797 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7798 * regformats/i386/x32-avx-linux.dat: Remove.
7799 * regformats/i386/x32-linux.dat: Remove.
7800
78012019-07-04 Alan Hayward <alan.hayward@arm.com>
7802
7803 * aarch64-tdep.c: Remove xml self tests.
7804 * amd64-linux-tdep.c: Likewise.
7805 * amd64-tdep.c: Likewise.
7806 * i386-linux-tdep.c: Likewise.
7807 * i386-tdep.c: Likewise.
7808
78092019-07-03 Pedro Alves <palves@redhat.com>
7810
7811 PR cli/24732
7812 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7813 (pipe_cmd_option_defs): New.
7814 (make_pipe_cmd_options_def_group): New.
7815 (pipe_command): Use gdb::option::process_options.
7816 (pipe_command_completer): New function.
7817 (_initialize_cli_cmds): Install completer for "pipe" command.
7818
78192019-07-03 Pedro Alves <palves@redhat.com>
7820
7821 * cli/cli-option.c (union option_value) <string>: New field.
7822 (struct option_def_and_value): Add ctor, move ctor, dtor and
7823 use DISABLE_COPY_AND_ASSIGN.
7824 (option_def_and_value::clear_value): New.
7825 (parse_option, save_option_value_in_ctx, get_val_type_str)
7826 (add_setshow_cmds_for_options): Handle var_string.
7827 * cli-option.h (union option_def::var_address) <string>: New
7828 field.
7829 (struct string_option_def): New.
7830 * maint-test-options.c (struct test_options_opts): Add default
7831 ctor and use DISABLE_COPY_AND_ASSIGN.
7832 <string_opt>: New field.
7833 (test_options_opts::~test_options_opts): New.
7834 (test_options_opts::dump): Also dump "-string".
7835 (test_options_option_defs): Install "string.
7836
78372019-07-03 Pedro Alves <palves@redhat.com>
7838
7839 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7840 option_value with a null enumeration.
7841 (complete_options): Save the option values in the context.
7842 (save_option_value_in_ctx): New, factored out from ...
7843 (process_options): ... here.
7844 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7845 of the function.
7846 * maint-test-options.c (test_options_opts::dump): New, factored
7847 out from ...
7848 (maintenance_test_options_command_mode): ... here.
7849 (maintenance_test_options_command_completion_result): Delete.
7850 (maintenance_test_options_command_completion_text): Update
7851 comment.
7852 (maintenance_show_test_options_completion_result): Change
7853 prototype. Just print
7854 maintenance_test_options_command_completion_text.
7855 (save_completion_result): New.
7856 (maintenance_test_options_completer_mode): Pass options context to
7857 complete_options, and then save a dump.
7858 (_initialize_maint_test_options): Use add_cmd to install "maint
7859 show test-options-completion-result".
7860
78612019-07-03 Pedro Alves <palves@redhat.com>
7862
7863 * NEWS (New commands): Mention "with" and "maint with".
7864 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7865 (with_command, with_command_completer): New.
7866 (pipe_command): Adjust to new repeat_previous
7867 interface.
7868 (_initialize_cli_cmds): Install the "with" command and its "w"
7869 alias.
7870 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7871 declarations.
7872 * cli/cli-setshow.c (parse_cli_var_uinteger)
7873 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7874 argument strings for all var_types.
7875 (get_setshow_command_value_string): New, factored out from ...
7876 (do_show_command): ... this.
7877 * cli/cli-setshow.h: Include <string>.
7878 (get_setshow_command_value_string): Declare.
7879 * command.h (repeat_previous): Now returns const char *. Adjust
7880 comment.
7881 * maint.c: Include "cli/cli-cmds.h".
7882 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7883 (_initialize_maint_cmds): Register the "maintenance with" command.
7884 * top.c (repeat_previous): Move bits from pipe_command here:
7885 Return the saved command line, if any; error out if there's no
7886 command to relaunch.
7887
78882019-07-03 Pedro Alves <palves@redhat.com>
7889
7890 * NEWS (New commands): Mention "maint set/show test-settings"
7891 instead of "maint test-settings".
7892 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7893 (maintenance_test_settings_set_list): Rename to ...
7894 (maintenance_set_test_settings_list): ... this.
7895 (maintenance_test_settings_show_list): Rename to ...
7896 (maintenance_show_test_settings_list): ... this.
7897 (maintenance_test_settings_cmd): Delete.
7898 (maintenance_test_settings_set_cmd): ...
7899 (maintenance_set_test_settings_cmd): ... this.
7900 (maintenance_test_settings_show_cmd): ...
7901 (maintenance_show_test_settings_cmd): ... this.
7902 (maintenance_test_settings_show_value_cmd):
7903 (maintenance_show_test_settings_value_cmd): ... this.
7904 (_initialize_maint_test_settings): No longer install the "maint
7905 test-settings" prefix command. Rename "maint test-settings set"
7906 to "maint set test-settings", and "maint test-settings show" to
7907 "maint show test-settings". Adjust all subcommands.
7908
79092019-07-03 Pedro Alves <palves@redhat.com>
7910
7911 * maint-test-settings.c: Fix file's intro comment. Replace all
7912 references to "test-options" with references to "test-settings",
7913 in comments.
7914
79152019-07-03 Pedro Alves <palves@redhat.com>
7916
7917 * maint-test-settings.c (maintenance_test_settings_xxx)
7918 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7919 New.
7920 (maintenance_test_settings_enums): Use them.
7921 (maintenance_test_settings_enum): Default to
7922 maintenance_test_settings_xxx.
7923 (_initialize_maint_test_settings): Initialize
7924 MAINTENANCE_TEST_SETTINGS_FILENAME.
7925
79262019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7927
7928 * breakpoint.h (remove_breakpoints_inf): Change return type to
7929 void, move function documentation here.
7930 * breakpoint.c (remove_breakpoints_inf): Change return type to
7931 void, move function documentation to header.
7932
79332019-07-02 Pedro Alves <palves@redhat.com>
7934
7935 * NEWS (Completion improvements): Mention "info threads".
7936 * thread.c (struct info_threads_opts, info_threads_option_defs)
7937 (make_info_threads_options_def_group): New.
7938 (info_threads_command): Use gdb::option::process_options.
7939 (info_threads_command_completer): New.
7940 (_initialize_thread): Use gdb::option::build_help to build the
7941 help text for "info threads".
7942
79432019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7944
7945 * defs.h (generic_load): Move from here...
7946 * symfile.h (generic_load): ... to here. Rename name parameter
7947 to args.
7948 * symfile.c (generic_load): Add comment.
7949
79502019-07-01 Tom Tromey <tromey@adacore.com>
7951
7952 * dwarf2read.c
7953 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7954 declaration of without_params. Fix formatting.
7955
79562019-07-01 Tom Tromey <tromey@adacore.com>
7957
7958 * ada-exp.y (find_primitive_type): Update.
7959 * ada-lang.h (ada_lookup_symbol): Update.
7960 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7961 parameter.
7962 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7963
79642019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7965
7966 PR breakpoints/24541
7967 * gdbarch.c: Regenerate.
7968 * gdbarch.h: Regenerate.
7969 * gdbarch.sh: Add 'stap_adjust_register'.
7970 * i386-tdep.c: Include '<unordered_set>'.
7971 (i386_stap_adjust_register): New function.
7972 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7973 * stap-probe.c (stap_parse_register_operand): Call
7974 'gdbarch_stap_adjust_register'.
7975
79762019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7977
7978 PR python/24742
7979 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7980 * python/python.c (do_start_initialization): Use 'xmalloc'
7981 instead of 'PyMem_Malloc'.
7982
79832019-06-28 Tom Tromey <tromey@adacore.com>
7984
7985 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7986 for Ada.
7987
79882019-06-27 Tom Tromey <tromey@adacore.com>
7989
7990 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7991 objfile_key.
7992 (arm_find_mapping_symbol, arm_record_special_symbol)
7993 (_initialize_arm_tdep): Update.
7994 (arm_objfile_data_free): Remove.
7995
79962019-06-27 Tom Tromey <tromey@adacore.com>
7997
7998 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7999 to cp_print_static_field.
8000
80012019-06-26 Tom Tromey <tromey@adacore.com>
8002
8003 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8004 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8005 declare.
8006
80072019-06-26 Alan Hayward <alan.hayward@arm.com>
8008
8009 * features/aarch64-core.c (create_feature_aarch64_core):
8010 Regenerate.
8011 * features/aarch64-core.xml: Add cpsr flags.
8012
80132019-06-26 Alan Hayward <alan.hayward@arm.com>
8014
8015 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8016 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8017
80182019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8019
8020 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8021 field.
8022 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8023 use.
8024 (arm_record_special_symbol): Don't insert new symbol in sorted
8025 position, push it at the end.
8026
80272019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8028
8029 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8030 (arm_mapping_symbol_s): Remove.
8031 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8032 (arm_mapping_symbol_vec): New typedef.
8033 (struct arm_per_objfile): Add constructor.
8034 <section_maps>: Change type to
8035 std::unique_ptr<arm_mapping_symbol_vec[]>.
8036 (arm_compare_mapping_symbols): Remove.
8037 (arm_find_mapping_symbol): Adjust to section_maps type change.
8038 (arm_objfile_data_free): Call delete on arm_per_objfile.
8039 (arm_record_special_symbol): Adjust to section_maps type change.
8040 Allocate arm_per_objfile with new.
8041
80422019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8043
8044 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8045 with the command prefix.
8046
80472019-06-25 Tom Tromey <tom@tromey.com>
8048
8049 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8050 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8051
80522019-06-25 Tom Tromey <tom@tromey.com>
8053
8054 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8055 type.
8056 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8057 protected.
8058
80592019-06-25 Tom Tromey <tom@tromey.com>
8060
8061 * tui/tui-winsource.c
8062 (tui_source_window_base::set_is_exec_point_at): Add check against
8063 LOA_ADDRESS.
8064
80652019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-source.c (tui_set_source_content): Don't check before
8068 xfree.
8069 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8070
80712019-06-25 Tom Tromey <tom@tromey.com>
8072
8073 * tui/tui-winsource.h (tui_update_source_window_as_is)
8074 (tui_alloc_source_buffer, tui_line_is_displayed)
8075 (tui_addr_is_displayed): Change type of win_info.
8076 * tui/tui-winsource.c (tui_update_source_window_as_is)
8077 (tui_clear_source_content, tui_show_source_line)
8078 (tui_show_source_content, tui_source_window_base::refill)
8079 (tui_source_window_base::set_is_exec_point_at)
8080 (tui_source_window_base::set_is_exec_point_at)
8081 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8082 (tui_alloc_source_buffer, tui_line_is_displayed)
8083 (tui_addr_is_displayed): Change type of win_info. Update.
8084 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8085 (tui_source_window_base::do_make_visible_with_new_height):
8086 Update.
8087 * tui/tui-source.c (tui_set_source_content)
8088 (tui_set_source_content_nil)
8089 (tui_source_window::do_scroll_vertical): Update.
8090 * tui/tui-layout.c (show_layout): Update.
8091 * tui/tui-disasm.c (tui_set_disassem_content)
8092 (tui_disasm_window::do_scroll_vertical): Update.
8093 * tui/tui-data.h (tui_win_content): Remove.
8094 (struct tui_gen_win_info) <content, content_size>: Remove.
8095 (struct tui_source_element): Add initializers and destructor.
8096 (union tui_which_element, struct tui_win_element): Remove.
8097 (struct tui_source_window_base) <content>: New field.
8098 (struct tui_data_window): Remove destructor.
8099 (tui_alloc_content, tui_free_win_content)
8100 (tui_free_all_source_wins_content): Don't declare.
8101 * tui/tui-data.c (tui_initialize_static_data): Update.
8102 (init_content_element, tui_alloc_content): Remove.
8103 (~tui_gen_win_info): Update.
8104 (~tui_data_window, tui_free_all_source_wins_content)
8105 (tui_free_win_content, free_content, free_content_elements):
8106 Remove.
8107
81082019-06-25 Tom Tromey <tom@tromey.com>
8109
8110 * tui/tui-winsource.h (tui_clear_source_content)
8111 (tui_erase_source_content, tui_show_source_content): Change type
8112 of win_info.
8113 * tui/tui-winsource.c (tui_clear_source_content)
8114 (tui_erase_source_content, tui_show_source_content): Change type
8115 of win_info.
8116 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8117 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8118 win_info.
8119 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8120 win_info.
8121 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8122
81232019-06-25 Tom Tromey <tom@tromey.com>
8124
8125 * tui/tui-winsource.c (tui_clear_source_content)
8126 (tui_source_window_base::set_is_exec_point_at): Update.
8127 * tui/tui-source.c (tui_set_source_content_nil): Update.
8128 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8129 a bool.
8130 * tui/tui-data.c (init_content_element): Update.
8131
81322019-06-25 Tom Tromey <tom@tromey.com>
8133
8134 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8135 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8136 * tui/tui-layout.c (init_and_make_win): Update.
8137 * tui/tui.h (enum tui_win_type): Update.
8138 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8139 tui_win_is_auxillary.
8140 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8141 tui_win_is_auxillary.
8142
81432019-06-25 Tom Tromey <tom@tromey.com>
8144
8145 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8146 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8147 (tui_delete_data_content_windows, tui_display_all_data)
8148 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8149 Update.
8150 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8151 * tui/tui-regs.c (tui_last_regs_line_no)
8152 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8153 (tui_show_registers): Update.
8154 (tui_show_register_group): Return void. Update.
8155 (tui_display_registers_from, tui_display_reg_element_at_line)
8156 (tui_display_registers_from_line, tui_check_register_values):
8157 Update.
8158 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8159 member.
8160 (struct tui_data_window) <regs_content>: Now a std::vector.
8161 <regs_content_count>: Remove.
8162 (tui_add_content_elements, tui_free_data_content): Don't declare.
8163 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8164 (init_content_element): Remove DATA_WIN case. Add assert.
8165 (tui_add_content_elements): Remove.
8166 (tui_data_window): Update.
8167 (tui_free_data_content): Remove.
8168 (free_content_elements): Remove DATA_WIN case.
8169
81702019-06-25 Tom Tromey <tom@tromey.com>
8171
8172 * tui/tui-data.c (tui_data_item_window): Update.
8173 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8174 * tui/tui-windata.c (tui_display_all_data)
8175 (tui_display_data_from_line): Update.
8176 (tui_check_data_values): Remove.
8177 * tui/tui-regs.c (tui_show_register_group)
8178 (tui_display_reg_element_at_line): Update.
8179 * tui/tui-hooks.c (tui_register_changed)
8180 (tui_refresh_frame_and_register_information): Call
8181 tui_check_register_values.
8182 * tui/tui-data.h (struct tui_data_window) <data_content,
8183 data_content_count, data_type>: Remove.
8184 (enum tui_data_type): Remove.
8185
8186 * tui/tui-data.c (tui_data_window::clear_detail)
8187 (~tui_data_window): Update.
8188
81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8192 declare.
8193 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8194 Rename from tui_first_data_item_displayed. Update.
8195 (tui_data_window::refresh_all)
8196 (tui_data_window::do_scroll_vertical): Update.
8197 * tui/tui-data.h (struct tui_data_window)
8198 <first_data_item_displayed>: Declare new method.
8199
82002019-06-25 Tom Tromey <tom@tromey.com>
8201
8202 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8203 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8204 contents...
8205 (tui_initialize_static_data): ...here.
8206
82072019-06-25 Tom Tromey <tom@tromey.com>
8208
8209 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8210 (tui_display_registers_from, tui_check_register_values): Update.
8211 (tui_display_register): Remove win_info parameter; update.
8212 (tui_get_register): Change type of parameters.
8213 * tui/tui-data.h (struct tui_data_element): Remove.
8214 (union tui_which_element) <data>: Remove.
8215 <data_window>: Change type.
8216 (struct tui_data_item_window): New.
8217 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8218 case. Add assert.
8219 (~tui_data_item_window): New destructor.
8220 (free_content_elements): Remove DATA_ITEM_WIN case.
8221
82222019-06-25 Tom Tromey <tom@tromey.com>
8223
8224 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8225 Remove.
8226
82272019-06-25 Tom Tromey <tom@tromey.com>
8228
8229 * tui/tui-data.h (struct tui_command_element): Remove.
8230 (union tui_which_element) <command>: Remove.
8231 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8232 assert.
8233 (free_content_elements): Remove CMD_WIN case.
8234
82352019-06-25 Tom Tromey <tom@tromey.com>
8236
8237 * tui/tui-layout.c (tui_set_layout): Update.
8238 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8239 * tui/tui-data.c (layout_def): Update.
8240
82412019-06-25 Tom Tromey <tom@tromey.com>
8242
8243 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8244 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8245 (tui_source_window_base::set_new_height): Update.
8246 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8247 Update.
8248 (tui_set_locator_fullname, tui_set_locator_info)
8249 (tui_show_frame_info): Update.
8250 * tui/tui-source.c (tui_set_source_content)
8251 (tui_source_is_displayed): Update.
8252 * tui/tui-layout.c (show_source_disasm_command, show_data)
8253 (show_source_or_disasm_and_command): Update.
8254 * tui/tui-disasm.c (tui_set_disassem_content)
8255 (tui_get_begin_asm_address): Update.
8256 * tui/tui-data.h (struct tui_locator_element): Remove.
8257 (union tui_which_element) <locator>: Remove.
8258 (struct tui_locator_window): New.
8259 (tui_locator_win_info_ptr): Change return type.
8260 * tui/tui-data.c (_locator): Change type.
8261 (tui_locator_win_info_ptr): Change return type.
8262 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8263 (tui_alloc_content): Add assert.
8264
82652019-06-25 Tom Tromey <tom@tromey.com>
8266
8267 * tui/tui-winsource.c
8268 (tui_exec_info_window::maybe_allocate_content): New method.
8269 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8270 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8271 (make_source_or_disasm_window): Add cast.
8272 * tui/tui-data.h (union tui_which_element) <simple_string>:
8273 Remove.
8274 (struct tui_source_info): New.
8275 (struct tui_source_window_base) <execution_info>: Change type.
8276 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8277 case, and add assert.
8278 (tui_alloc_content): Add assert.
8279
82802019-06-25 Tom Tromey <tom@tromey.com>
8281
8282 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8283 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8284 * tui/tui-data.c (tui_alloc_win_info): Remove.
8285
82862019-06-25 Tom Tromey <tom@tromey.com>
8287
8288 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8289 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8290 can_highlight.
8291
82922019-06-25 Tom Tromey <tom@tromey.com>
8293
8294 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8295 make_visible_with_new_height method.
8296 (tui_win_info::make_visible_with_new_height): New method.
8297 (tui_source_window_base::do_make_visible_with_new_height)
8298 (tui_data_window::do_make_visible_with_new_height)
8299 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8300 (make_visible_with_new_height): Remove.
8301 (tui_resize_all, tui_adjust_win_heights): Use
8302 make_visible_with_new_height method.
8303 * tui/tui-data.h (struct tui_win_info)
8304 <do_make_visible_with_new_height, make_visible_with_new_height>:
8305 New methods.
8306 (struct tui_source_window_base, struct tui_data_window)
8307 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8308 methods.
8309
83102019-06-25 Tom Tromey <tom@tromey.com>
8311
8312 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8313 method.
8314 (update_tab_width): Call update_tab_width method.
8315 * tui/tui-data.h (struct tui_win_info)
8316 (struct tui_source_window_base) <update_tab_width>: New methods.
8317
83182019-06-25 Tom Tromey <tom@tromey.com>
8319
8320 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8321 parameter.
8322 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8323 parameter.
8324 (tui_gen_win_info::make_visible): Update.
8325 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8326 parameter.
8327 * tui/tui-data.h (enum tui_box): New enum.
8328 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8329
83302019-06-25 Tom Tromey <tom@tromey.com>
8331
8332 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8333 init_and_make_win for EXEC_INFO_WIN.
8334 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8335 longer inline.
8336 (struct tui_win_info) <~tui_win_info>: Inline.
8337 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8338 Don't declare.
8339 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8340 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8341 Remove.
8342 (tui_initialize_static_data): Update.
8343 (~tui_gen_win_info): Handle more cleanup here.
8344 (~tui_source_window_base): Delete "execution_info".
8345 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8346
83472019-06-25 Tom Tromey <tom@tromey.com>
8348
8349 * tui/tui-layout.c (make_command_window): Don't set
8350 can_highlight.
8351 (show_source_disasm_command): Call the reset method.
8352 (show_data): Don't set can_highlight. Call the reset method.
8353 (tui_gen_win_info::reset): Rename from init_gen_win_info
8354 (init_and_make_win): Simplify. Return tui_gen_win_info.
8355 (show_source_or_disasm_and_command): Call the reset method.
8356 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8357 (struct tui_cmd_window): Set can_highlight.
8358
83592019-06-25 Tom Tromey <tom@tromey.com>
8360
8361 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8362 from make_visible.
8363 (tui_make_visible, tui_make_invisible): Rewrite.
8364 (tui_win_info::make_visible): Remove.
8365 (tui_source_window_base::make_visible): Update.
8366 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8367 method. Moved from...
8368 (struct tui_win_info) <make_visible>: ...here.
8369
83702019-06-25 Tom Tromey <tom@tromey.com>
8371
8372 * tui/tui-winsource.c
8373 (tui_source_window_base::do_scroll_horizontal): Remove direction
8374 parameter.
8375 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8376 direction parameter.
8377 * tui/tui-win.c (tui_win_info::forward_scroll)
8378 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8379 (tui_win_info::right_scroll): Update.
8380 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8381 direction parameter.
8382 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8383 direction parameter.
8384 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8385 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8386 Remove direction parameter.
8387 (struct tui_source_window_base, struct tui_source_window)
8388 (struct tui_disasm_window, struct tui_data_window)
8389 (struct tui_cmd_window): Update.
8390
83912019-06-25 Tom Tromey <tom@tromey.com>
8392
8393 * tui/tui-winsource.h (tui_set_exec_info_content)
8394 (tui_show_exec_info_content, tui_erase_exec_info_content)
8395 (tui_clear_exec_info_content, tui_update_exec_info): Change
8396 argument to tui_source_window_base.
8397 * tui/tui-winsource.c (tui_set_exec_info_content)
8398 (tui_show_exec_info_content, tui_erase_exec_info_content)
8399 (tui_clear_exec_info_content, tui_update_exec_info): Change
8400 argument to tui_source_window_base.
8401
84022019-06-25 Tom Tromey <tom@tromey.com>
8403
8404 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8405 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8406
84072019-06-25 Tom Tromey <tom@tromey.com>
8408
8409 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8410 check.
8411
84122019-06-25 Tom Tromey <tom@tromey.com>
8413
8414 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8415 type to void.
8416 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8417 type to void.
8418 * tui/tui-source.c (tui_set_source_content): Update.
8419 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8420
84212019-06-25 Tom Tromey <tom@tromey.com>
8422
8423 * tui/tui-win.c (window_name_completer, tui_set_focus)
8424 (tui_all_windows_info): Use name method.
8425 * tui/tui-data.h (struct tui_gen_win_info)
8426 (struct tui_source_window, struct tui_disasm_window)
8427 (struct tui_data_window, struct tui_cmd_window) <name>: New
8428 method.
8429 (tui_win_name): Don't declare.
8430 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8431 (tui_win_name): Remove.
8432
84332019-06-25 Tom Tromey <tom@tromey.com>
8434
8435 * tui/tui-winsource.h (tui_update_source_window)
8436 (tui_update_source_window_as_is): Change parameter type.
8437 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8438 to be a tui_source_window_base.
8439 (tui_update_source_window_as_is): Likewise.
8440 * tui/tui-win.c (make_visible_with_new_height): Update.
8441
84422019-06-25 Tom Tromey <tom@tromey.com>
8443
8444 * tui/tui-winsource.c (tui_erase_source_content)
8445 (tui_show_source_content, tui_show_exec_info_content)
8446 (tui_erase_exec_info_content): Use refresh_window method.
8447 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8448 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8449 from tui_refresh_win.
8450 (tui_data_window::refresh_window): New method.
8451 (tui_win_info::refresh, tui_source_window_base::refresh)
8452 (tui_refresh_all): Use refresh_window method.
8453 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8454 method.
8455 * tui/tui-regs.c (tui_display_register): Call refresh_window
8456 method.
8457 * tui/tui-layout.c (show_source_disasm_command)
8458 (show_source_or_disasm_and_command): Call refresh_window method.
8459 * tui/tui-data.h (struct tui_gen_win_info)
8460 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8461 New method.
8462
84632019-06-25 Tom Tromey <tom@tromey.com>
8464
8465 * tui/tui.c (tui_rl_other_window, tui_enable)
8466 (tui_is_window_visible, tui_get_command_dimension): Update.
8467 * tui/tui-winsource.c (tui_update_source_window_as_is)
8468 (tui_clear_source_content, tui_erase_source_content)
8469 (tui_show_source_line, tui_source_window_base::refill)
8470 (tui_source_window_base::do_scroll_horizontal)
8471 (tui_source_window_base::set_is_exec_point_at)
8472 (tui_update_breakpoint_info, tui_set_exec_info_content)
8473 (tui_alloc_source_buffer, tui_line_is_displayed)
8474 (tui_addr_is_displayed): Update.
8475 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8476 (tui_check_and_display_highlight_if_needed)
8477 (tui_win_info::make_visible, tui_win_info::refresh)
8478 (tui_refresh_all): Update.
8479 * tui/tui-windata.c (tui_first_data_item_displayed)
8480 (tui_delete_data_content_windows, tui_erase_data_content)
8481 (tui_display_all_data, tui_data_window::refresh_all)
8482 (tui_check_data_values): Update.
8483 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8484 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8485 (tui_win_info::backward_scroll, tui_refresh_all_win)
8486 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8487 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8488 (tui_source_window_base::set_new_height)
8489 (tui_data_window::set_new_height)
8490 (make_invisible_and_set_new_height)
8491 (make_visible_with_new_height, new_height_ok)
8492 (parse_scrolling_args): Update.
8493 * tui/tui-stack.c (tui_show_frame_info): Update.
8494 * tui/tui-source.c (tui_set_source_content)
8495 (tui_set_source_content_nil, tui_source_is_displayed)
8496 (tui_source_window::do_scroll_vertical): Update.
8497 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8498 (tui_display_registers_from, tui_display_reg_element_at_line)
8499 (tui_check_register_values, tui_reg_command): Update.
8500 * tui/tui-layout.c (tui_default_win_height)
8501 (show_source_disasm_command, show_data, init_and_make_win)
8502 (show_source_or_disasm_and_command): Update.
8503 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8504 (tui_redisplay_readline, tui_mld_flush)
8505 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8506 (tui_getc): Update.
8507 * tui/tui-disasm.c (tui_set_disassem_content)
8508 (tui_disasm_window::do_scroll_vertical): Update.
8509 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8510 Now virtual.
8511 (struct tui_win_info): Derive from tui_gen_win_info.
8512 <~tui_win_info>: Mark as override.
8513 <generic>: Remove member.
8514 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8515 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8516 (~tui_data_window, ~tui_win_info)
8517 (tui_free_all_source_wins_content): Update.
8518 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8519
85202019-06-25 Tom Tromey <tom@tromey.com>
8521
8522 * tui/tui-layout.c (init_and_make_win): Use new.
8523 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8524 destructor, initializers.
8525 (tui_alloc_generic_win_info): Don't declare.
8526 * tui/tui-data.c (_locator): Add argument to constructor.
8527 (source_win, disasm_win): New globals.
8528 (exec_info): Remove.
8529 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8530 Update.
8531 (tui_alloc_generic_win_info): Remove.
8532 (init_content_element): Use new.
8533 (tui_win_info::tui_win_info): Update.
8534 (free_content_elements) <case DATA_WIN>: Use delete.
8535
85362019-06-25 Tom Tromey <tom@tromey.com>
8537
8538 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8539 * tui/tui-windata.c (tui_first_data_item_displayed)
8540 (tui_delete_data_content_windows): Update.
8541 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8542 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8543 (tui_display_registers_from, tui_check_register_values): Update.
8544 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8545 pointer.
8546 * tui/tui-data.c (init_content_element): Update. Allocate the new
8547 window.
8548 (tui_free_data_content): Update.
8549 (free_content_elements) <case DATA_WIN>: Free the window.
8550
85512019-06-25 Tom Tromey <tom@tromey.com>
8552
8553 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8554 Update.
8555 * tui/tui-layout.c (make_command_window)
8556 (show_source_disasm_command, show_data, init_and_make_win)
8557 (show_source_or_disasm_and_command): Update.
8558 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8559 method.
8560 <can_highight, is_highlighted>: Now bool.
8561 (tui_set_win_highlight): Don't declare.
8562 * tui/tui-data.c (tui_set_win_highlight): Remove.
8563
85642019-06-25 Tom Tromey <tom@tromey.com>
8565
8566 * tui/tui-wingeneral.c (make_visible): Remove check of window
8567 type.
8568
85692019-06-25 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-win.c (tui_win_info::max_height)
8572 (tui_cmd_window::max_height): New methods.
8573 (new_height_ok): Call max_height.
8574 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8575 <max_height>: New method.
8576
85772019-06-25 Tom Tromey <tom@tromey.com>
8578
8579 * tui/tui-win.c (tui_source_window_base::set_new_height)
8580 (tui_data_window::set_new_height): New methods.
8581 (make_invisible_and_set_new_height): Call set_new_height method.
8582 * tui/tui-data.h (struct tui_win_info)
8583 (struct tui_source_window_base, struct tui_data_window)
8584 <set_new_height>: New method.
8585
85862019-06-25 Tom Tromey <tom@tromey.com>
8587
8588 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8589 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8590 tui_refresh_data_win.
8591 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8592 method.
8593 (tui_refresh_all_win): Call the refresh_all method.
8594 (tui_set_focus): Likewise.
8595 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8596 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8597 Likewise.
8598
85992019-06-25 Tom Tromey <tom@tromey.com>
8600
8601 * tui/tui-winsource.h (tui_refill_source_window)
8602 (tui_set_is_exec_point_at): Don't declare.
8603 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8604 (tui_source_window_base::refill): Rename from
8605 tui_refill_source_window.
8606 (tui_source_window_base::do_scroll_horizontal): Update.
8607 (tui_source_window_base::set_is_exec_point_at): Rename from
8608 tui_set_is_exec_point_at.
8609 (tui_update_all_breakpoint_info): Update.
8610 * tui/tui-stack.c (tui_show_frame_info): Update.
8611 * tui/tui-layout.c (show_data): Add cast.
8612 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8613 * tui/tui-data.h (struct tui_source_window_base) <refill,
8614 set_is_exec_point_at>: New methods.
8615 (tui_source_windows, tui_add_to_source_windows): Update types.
8616 (tui_add_to_source_windows): Remove redundant declaration.
8617 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8618 (tui_source_windows): Change return type.
8619 (tui_clear_source_windows_detail): Update.
8620 (tui_add_to_source_windows): Change type of parameter.
8621 (tui_free_all_source_wins_content): Update.
8622
86232019-06-25 Tom Tromey <tom@tromey.com>
8624
8625 * tui/tui-wingeneral.c (tui_win_info::refresh)
8626 (tui_source_window_base::refresh): New methods.
8627 (tui_refresh_all): Call the refresh method.
8628 * tui/tui-data.h (struct tui_win_info)
8629 (struct tui_source_window_base) <refresh>: New method.
8630
86312019-06-25 Tom Tromey <tom@tromey.com>
8632
8633 * tui/tui.h (tui_is_window_visible): Return bool.
8634 * tui/tui.c (tui_is_window_visible): Return bool.
8635 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8636 (tui_make_visible, tui_make_invisible)
8637 (tui_win_info::make_visible)
8638 (tui_source_window_base::make_visible, make_all_visible)
8639 (tui_make_all_visible, tui_make_all_invisible): Update.
8640 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8641 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8642 bool.
8643 (struct tui_win_info, struct tui_source_window_base)
8644 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8645 * tui/tui-data.c (tui_init_generic_part): Update.
8646
86472019-06-25 Tom Tromey <tom@tromey.com>
8648
8649 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8650 (tui_source_window_base::make_visible): New methods.
8651 (make_all_visible): Make method call.
8652 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8653 (struct tui_source_window_base, struct tui_cmd_window): Override
8654 make_visible.
8655 (tui_win_is_source_type): Don't declare.
8656 * tui/tui-data.c (tui_win_is_source_type): Remove.
8657
86582019-06-25 Tom Tromey <tom@tromey.com>
8659
8660 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8661 NULL check.
8662
86632019-06-25 Tom Tromey <tom@tromey.com>
8664
8665 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8666 Inline constructor. Add initializers for members.
8667 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8668 constructors; now inline in class.
8669
86702019-06-25 Tom Tromey <tom@tromey.com>
8671
8672 * tui/tui-regs.c (tui_show_registers): Update.
8673 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8674 bool.
8675 * tui/tui-data.c (tui_data_window::clear_detail)
8676 (tui_data_window): Update.
8677
86782019-06-25 Tom Tromey <tom@tromey.com>
8679
8680 * tui/tui-windata.c (tui_display_all_data)
8681 (tui_display_data_from_line, tui_display_data_from)
8682 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8683 Update.
8684 * tui/tui-regs.c (tui_last_regs_line_no)
8685 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8686 (tui_show_registers, tui_show_register_group)
8687 (tui_display_registers_from, tui_display_reg_element_at_line)
8688 (tui_display_registers_from_line, tui_check_register_values)
8689 (tui_reg_next, tui_reg_prev): Update.
8690 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8691 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8692 tui_data_window.
8693 (struct tui_win_info) <detail>: Remove. Add new fields from
8694 tui_data_info.
8695 (TUI_DATA_WIN): Add cast.
8696 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8697 (~tui_data_window): Simplify.
8698
86992019-06-25 Tom Tromey <tom@tromey.com>
8700
8701 * tui/tui-layout.c (show_source_disasm_command)
8702 (show_source_or_disasm_and_command): Update.
8703 * tui/tui-io.c (update_cmdwin_start_line)
8704 (tui_redisplay_readline): Update.
8705 * tui/tui-data.h (struct tui_command_info): Remove.
8706 (struct tui_win_info) <detail>: Remove command_info member.
8707 (struct tui_data_window) <start_line>: New member, from
8708 tui_command_info.
8709 (TUI_CMD_WIN): Add casts.
8710
87112019-06-25 Tom Tromey <tom@tromey.com>
8712
8713 * tui/tui-winsource.c (tui_update_source_window)
8714 (tui_refill_source_window)
8715 (tui_source_window_base::do_scroll_horizontal)
8716 (tui_update_breakpoint_info, tui_set_exec_info_content)
8717 (tui_show_exec_info_content, tui_erase_exec_info_content)
8718 (tui_clear_exec_info_content): Update.
8719 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8720 Update.
8721 * tui/tui-win.c (make_invisible_and_set_new_height)
8722 (make_visible_with_new_height): Update.
8723 * tui/tui-source.c (tui_set_source_content)
8724 (tui_show_symtab_source): Update.
8725 * tui/tui-layout.c (extract_display_start_addr)
8726 (show_source_disasm_command, show_data)
8727 (make_source_or_disasm_window)
8728 (show_source_or_disasm_and_command): Update.
8729 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8730 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8731 "gdbarch".
8732 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8733 to tui_source_window_base.
8734 (struct tui_win_info) <detail>: Remove source_info member.
8735 (struct tui_source_window_base) <has_locator>: Inline.
8736 Move contents from tui_source_info; rename has_locator member to
8737 m_has_locator.
8738 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8739 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8740 header file.
8741 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8742 Simplify.
8743 (tui_free_all_source_wins_content): Cast to
8744 tui_source_window_base.
8745
87462019-06-25 Tom Tromey <tom@tromey.com>
8747
8748 * tui/tui-win.c (make_invisible_and_set_new_height)
8749 (make_visible_with_new_height): Call has_locator method.
8750 * tui/tui-layout.c (show_source_disasm_command, show_data)
8751 (show_source_or_disasm_and_command): Update for bool change.
8752 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8753 (tui_win_info) <has_locator>: New method.
8754 (struct tui_source_window_base) <has_locator>: New method.
8755 (tui_win_has_locator): Don't declare.
8756 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8757 from tui_win_has_locator.
8758 (tui_source_window_base): Use false, not FALSE.
8759
87602019-06-25 Tom Tromey <tom@tromey.com>
8761
8762 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8763 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8764 clear_detail method directly.
8765 (tui_clear_win_detail): Remove.
8766
87672019-06-25 Tom Tromey <tom@tromey.com>
8768
8769 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8770 "this", not TUI_DISASM_WIN.
8771
87722019-06-25 Tom Tromey <tom@tromey.com>
8773
8774 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8775 declare.
8776 * tui/tui-winsource.c
8777 (tui_source_window_base::do_scroll_horizontal): Rename from
8778 tui_horizontal_source_scroll.
8779 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8780 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8781 from tui_vertical_data_scroll.
8782 * tui/tui-win.h (tui_scroll): Don't declare.
8783 * tui/tui-win.c (tui_win_info::forward_scroll)
8784 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8785 (tui_win_info::right_scroll): Rename and update.
8786 (tui_scroll_forward_command, tui_scroll_backward_command)
8787 (tui_scroll_left_command, tui_scroll_right_command): Update.
8788 (tui_scroll): Remove.
8789 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8790 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8791 from tui_vertical_source_scroll.
8792 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8793 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8794 from tui_vertical_disassem_scroll.
8795 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8796 do_scroll_horizontal>: New methods.
8797 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8798 Likewise.
8799 (struct tui_source_window_base): Add do_scroll_horizontal.
8800 (struct tui_source_window, struct tui_disasm_window): Add
8801 do_scroll_vertical.
8802 (struct tui_data_window, struct tui_cmd_window): Add
8803 do_scroll_horizontal and do_scroll_vertical.
8804 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8805
88062019-06-25 Tom Tromey <tom@tromey.com>
8807
8808 * tui/tui-data.h (struct tui_source_window_base): New struct.
8809 (struct tui_source_window): Derive from tui_source_window_base.
8810 (struct tui_disasm_window): New struct.
8811 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8812 from tui_source_window::clear_detail.
8813 (tui_source_window_base): Rename from tui_source_window.
8814 (~tui_source_window_base): Rename from ~tui_source_window.
8815 (tui_alloc_win_info): Create a tui_disasm_window.
8816
88172019-06-25 Tom Tromey <tom@tromey.com>
8818
8819 * tui/tui-data.h (struct tui_source_window)
8820 (struct tui_data_window): Declare destructors.
8821 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8822 destructors.
8823 (tui_win_info): Simplify.
8824
88252019-06-25 Tom Tromey <tom@tromey.com>
8826
8827 * tui/tui-winsource.c (tui_display_main)
8828 (tui_update_source_windows_with_addr)
8829 (tui_update_all_breakpoint_info): Update.
8830 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8831 (new_height_ok, parse_scrolling_args): Update.
8832 * tui/tui-stack.c (tui_show_frame_info): Update.
8833 * tui/tui-data.h (struct tui_list): Remove.
8834 (tui_source_windows): Return a reference to a std::vector.
8835 * tui/tui-data.c (source_windows): Now a std::vector.
8836 (tui_source_windows): Change return type.
8837 (tui_clear_source_windows): Rewrite.
8838 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8839 (tui_free_all_source_wins_content): Rewrite.
8840
88412019-06-25 Tom Tromey <tom@tromey.com>
8842
8843 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8844 (struct tui_data_window, struct tui_cmd_window): Declare
8845 clear_detail method.
8846 * tui/tui-data.c (tui_source_window::clear_detail)
8847 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8848 methods.
8849 (tui_clear_win_detail): Simplify.
8850
88512019-06-25 Tom Tromey <tom@tromey.com>
8852
8853 * tui/tui-layout.c (make_source_window, make_disasm_window)
8854 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8855 Return the new window.
8856 (show_source_disasm_command, show_data)
8857 (show_source_or_disasm_and_command): Update.
8858
88592019-06-25 Tom Tromey <tom@tromey.com>
8860
8861 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8862 parameter. Return the new window.
8863 (show_source_disasm_command): Update and remove NULL check.
8864 (show_source_or_disasm_and_command): Update.
8865
88662019-06-25 Tom Tromey <tom@tromey.com>
8867
8868 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8869
88702019-06-25 Tom Tromey <tom@tromey.com>
8871
8872 * tui/tui-data.h (struct tui_win_info): Make constructor
8873 protected. Make destructor virtual. Add initializers.
8874 (tui_source_window, tui_data_window, tui_cmd_window): New
8875 classes.
8876 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8877 constructor. Add "type" parameter.
8878 (tui_source_window, tui_data_window, tui_cmd_window): New
8879 constructors.
8880 (tui_alloc_win_info): Instantiate the appropriate subclass.
8881
88822019-06-25 Tom Tromey <tom@tromey.com>
8883
8884 * tui/tui-win.c (tui_resize_all): Use delete.
8885 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8886 destructor.
8887 (tui_free_window): Don't declare.
8888 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8889 Update.
8890
88912019-06-25 Tom Tromey <tom@tromey.com>
8892
8893 * tui/tui-data.h (struct tui_win_info): Add constructor.
8894 * tui/tui-data.c (tui_alloc_win_info): Use new.
8895 (tui_free_window): Use delete.
8896
88972019-06-22 Tom Tromey <tom@tromey.com>
8898
8899 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8900 declare.
8901 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8902
89032019-06-22 Tom Tromey <tom@tromey.com>
8904
8905 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8906 declare.
8907 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8908
89092019-06-22 Tom de Vries <tdevries@suse.de>
8910
8911 * dwarf2read.c (create_addrmap_from_aranges)
8912 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8913 instead of '%zu'.
8914
89152019-06-21 Simon Marchi <simon.marchi@efficios.com>
8916
8917 * dwarf2read.h (dwarf2_section_info_def): Remove.
8918 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8919 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8920 std::vector<dwarf2_section_info>.
8921 (struct dwo_file) <~dwo_file>: Remove.
8922 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8923 types field.
8924 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8925 (dwarf2_read_debug_names): Likewise.
8926 (create_debug_types_hash_table): Change parameter type to
8927 array_view, adjust code accordingly.
8928 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8929 (partial_die_info::fixup): Likewise.
8930 (determine_prefix): Likewise.
8931 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8932
89332019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8934
8935 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8936 gdb_bfd_ref_ptr.
8937 <~dwo_file>: Remove call to gdb_bfd_unref.
8938 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8939 gdb_bfd_ref_ptr::get.
8940
89412019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8942
8943 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8944 type to htab_up.
8945 * dwarf2read.c (struct dwo_file): Initialize fields.
8946 <~dwo_file>: New.
8947 (free_dwo_file): Remove, move content to ~dwo_file.
8948 (struct dwo_file_deleter): Remove.
8949 (dwo_file_up>: Remove custom deleter.
8950 (free_dwo_files): Remove.
8951 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8952 dwo_files.
8953 (process_skeletonless_type_units): Call unique_ptr::get.
8954 (allocate_dwo_file_hash_table): Add deleter to created hash
8955 table. Change return type to htab_up.
8956 (lookup_dwo_file_slot): Don't memset dwo_file, call
8957 unique_ptr::get.
8958 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8959 (create_dwo_unit_in_dwp_v2): Likewise.
8960 (open_and_init_dwo_file): Likewise.
8961 (free_dwo_file_from_slot): Remove.
8962
89632019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8964
8965 * dwarf2read.h (struct dwarf2_section_info) <readin,
8966 is_virtual>: Change type to bool.
8967 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8968 true instead of 1.
8969
89702019-06-19 Tom Tromey <tom@tromey.com>
8971
8972 * tui/tui-data.h (tui_init_content_element): Don't declare.
8973
89742019-06-19 Tom Tromey <tom@tromey.com>
8975
8976 * tui/tui-data.h (tui_init_win_info): Don't declare.
8977
89782019-06-19 Tom de Vries <tdevries@suse.de>
8979
8980 * dwarf2read.h (abstract_to_concrete): Change type to
8981 std::unordered_map<sect_offset, std::vector<sect_offset>,
8982 gdb::hash_enum<sect_offset>>.
8983
89842019-06-19 Tom Tromey <tromey@adacore.com>
8985
8986 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8987 EVAL_AVOID_SIDE_EFFECTS specially.
8988
89892019-06-19 Tom Tromey <tromey@adacore.com>
8990
8991 * source-cache.c (highlighter): New global.
8992 (source_cache::get_source_lines): Create a highlighter on demand.
8993
89942019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8995
8996 * defs.h (deprecated_interactive_hook): Delete declaration.
8997 * interps.c (clear_interpreter_hooks): Remove use of
8998 deprecated_interactive_hook.
8999 * top.c (deprecated_interactive_hook): Delete definition.
9000 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9001
90022019-06-18 Tom de Vries <tdevries@suse.de>
9003
9004 PR gdb/24515
9005 * dwarf2read.h (abstract_to_concrete): Change type from
9006 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9007 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9008 * dwarf2read.c (read_variable): Update.
9009 (dwarf2_fetch_die_loc_sect_off): Update.
9010
90112019-06-17 Tom de Vries <tdevries@suse.de>
9012
9013 PR gdb/24617
9014 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9015 accessing parent[parent_len - 1].
9016
90172019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9018
9019 PR gdb/24364
9020 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9021 call dtrace_process_dof with NULL dof.
9022
90232019-06-16 Tom de Vries <tdevries@suse.de>
9024
9025 PR gdb/24445
9026 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9027
90282019-06-16 Tom Tromey <tom@tromey.com>
9029
9030 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9031 (make_all_visible): Use address of member.
9032
90332019-06-16 Tom Tromey <tom@tromey.com>
9034
9035 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9036 (tui_free_window, free_content, free_content_elements): Remove
9037 unnecessary cast.
9038 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9039 cast.
9040 * tui/tui-regs.c (tui_show_register_group)
9041 (tui_display_registers_from, tui_display_reg_element_at_line):
9042 Remove unnecessary cast.
9043
90442019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9045
9046 * linux-nat.c (normal_mask): Delete.
9047 (_initialize_linux_nat): Don't initialise normal_mask.
9048
90492019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9050
9051 PR gdb/24445
9052 * dwarf-index-write.h (write_psymtabs_to_index): Add
9053 dwz_basename parameter.
9054 * dwarf-index-write.c (write_gdbindex): Move file writing to
9055 write_gdbindex_1. Change return type void.
9056 (assert_file_size): Move up, remove filename parameter.
9057 (write_gdbindex_1): New function.
9058 (write_debug_names): Change return type to void, call
9059 assert_file_size.
9060 (struct index_wip_file): New struct.
9061 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9062 file logic to index_wip_file. Write index for dwz file if
9063 needed.
9064 (save_gdb_index_command): Pass basename of dwz file, if present.
9065 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9066 build-id of dwz file, if present.
9067 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9068 (dwarf2_get_dwz_file): Likewise.
9069 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9070 (dwarf2_get_dwz_file): Likewise.
9071
90722019-06-16 Tom Tromey <tom@tromey.com>
9073
9074 * coffread.c (process_coff_symbol): Use xstrdup.
9075 * value.c (create_internalvar): Use xstrdup.
9076
90772019-06-16 Tom Tromey <tom@tromey.com>
9078
9079 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9080 * breakpoint.c (stopin_command, stopat_command)
9081 (until_break_command, decode_location_default): Remove unnecessary
9082 cast.
9083 * utils.c (subset_compare): Remove unnecessary cast.
9084 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9085 cast.
9086 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9087 cast.
9088 * infcmd.c (path_command): Remove unnecessary cast.
9089 * coffread.c (decode_type): Remove unnecessary cast.
9090 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9091 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9092 * tui/tui-stack.c (tui_show_locator_content)
9093 (tui_show_frame_info): Remove unnecessary cast.
9094 * tui/tui-win.c (tui_scroll_forward_command)
9095 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9096 (parse_scrolling_args): Remove unnecessary cast.
9097 * tui/tui-data.c (init_win_info, tui_del_window)
9098 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9099 (free_content_elements): Remove unnecessary cast.
9100 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9101 unnecessary cast.
9102 * tui/tui-source.c (tui_set_source_content)
9103 (tui_vertical_source_scroll): Remove unnecessary cast.
9104 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9105 cast.
9106 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9107 * tui/tui-regs.c (tui_display_registers_from)
9108 (tui_display_register): Remove unnecessary cast.
9109 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9110 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9111 (make_visible): Remove unnecessary cast.
9112 * tui/tui-winsource.c (tui_erase_source_content)
9113 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9114 unnecessary cast.
9115 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9116 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9117 * stabsread.c (read_type, read_array_type, read_range_type):
9118 Remove unnecessary cast.
9119 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9120 (parse_symbol, parse_type, upgrade_type, parse_external)
9121 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9122 unnecessary cast.
9123 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9124
91252019-06-16 Tom Tromey <tom@tromey.com>
9126
9127 * tui/tui-data.c (tui_alloc_generic_win_info)
9128 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9129 checks.
9130
91312019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9132 Andrew Burgess <andrew.burgess@embecosm.com>
9133
9134 * f-typeprint.c (f_print_type): Don't return early for not
9135 associated or not allocated types.
9136 (f_type_print_varspec_suffix): Add print_rank parameter and print
9137 ranks of array types in case they dangling.
9138 (f_type_print_base): Add print_rank parameter.
9139
91402019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9141
9142 * NEWS: Mention new MI commands.
9143 * break-catch-throw.c (enum exception_event_kind): Move to
9144 breakpoint.h.
9145 (print_mention_exception_catchpoint): Output text as a single
9146 message.
9147 (catch_exception_command_1): Rename to...
9148 (catch_exception_event): ...this, make non-static, update header
9149 command, and change some parameter types.
9150 (catch_catch_command): Update for changes to
9151 catch_exception_command_1.
9152 (catch_throw_command): Likewise.
9153 (catch_rethrow_command): Likewise.
9154 * breakpoint.c (enum exception_event_kind): Delete.
9155 * breakpoint.h (enum exception_event_kind): Moved here from
9156 break-catch-throw.c.
9157 (catch_exception_event): Declare.
9158 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9159 (mi_cmd_catch_throw): New function.
9160 (mi_cmd_catch_rethrow): New function.
9161 (mi_cmd_catch_catch): New function.
9162 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9163 'catch-catch' entries.
9164 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9165 (mi_cmd_catch_rethrow): Declare.
9166 (mi_cmd_catch_catch): Declare.
9167
91682019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9169
9170 * annotate.c (annotate_source_line): Change return type to void,
9171 update implementation to match.
9172 * annotate.h (annotate_source_line): Change return type to void,
9173 update header comment.
9174 * stack.c (print_frame_info): Don't change what frame information
9175 is printed based on whether annotations are on or not.
9176
91772019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9178
9179 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9180 (annotate_source): Make static.
9181 (annotate_source_line): Moved from source.c and renamed from
9182 identify_source_line. Update the return type.
9183 * annotate.h (annotate_source): Delete declaration.
9184 (annotate_source_line): Declaration moved from source.h, and
9185 renamed from identify_source_line. Return type updated.
9186 * source.c (identify_source_line): Moved to annotate.c and renamed
9187 to annotate_source_line.
9188 (info_line_command): Remove check of annotation_level.
9189 * source.h (identify_source_line): Move declaration to annotate.h
9190 and rename to annotate_source_line.
9191 * stack.c: Add 'annotate.h' include.
9192 (print_frame_info): Remove check of annotation_level before
9193 calling annotate_source_line.
9194
91952019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9196
9197 * source-cache.c (source_cache::get_plain_source_lines): Use
9198 open_source_file_with_line_charpos instead of just
9199 open_source_file, remove call to find_source_lines.
9200 (source_cache::get_source_lines): Likewise.
9201 * source.c (find_source_lines): Make static.
9202 (get_filename_and_charpos): Renamed into...
9203 (open_source_file_with_line_charpos): ..this along with changes to
9204 return a scoped_fd, and some other minor clean ups.
9205 (identify_source_line): Use open_source_file_with_line_charpos.
9206 (search_command_helper): Use open_source_file_with_line_charpos
9207 instead of just open_source_file, remove call to
9208 find_source_lines.
9209 * source.h (open_source_file_with_line_charpos): Declare new
9210 function.
9211 (find_source_lines): Delete declaration.
9212
92132019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9214
9215 * source.c (get_filename_and_charpos): Remove fullname
9216 parameter.
9217 (identify_source_line): Update call to get_filename_and_charpos.
9218
92192019-06-14 Tom Tromey <tromey@adacore.com>
9220
9221 PR gdb/24502:
9222 * ui-style.h (skip_ansi_escape): Update comment.
9223 * ui-file.h (class no_terminal_escape_file): New class.
9224 * ui-file.c (no_terminal_escape_file::write)
9225 (no_terminal_escape_file::puts): New methods.
9226 * cli/cli-logging.c (handle_redirections): Use
9227 no_terminal_escape_file.
9228
92292019-06-14 Tom Tromey <tromey@adacore.com>
9230
9231 * NEWS: Move convenience variable news above Python news.
9232
92332019-06-14 Tom Tromey <tom@tromey.com>
9234
9235 * gnulib: Move directory to top-level.
9236 * configure.ac: Don't configure gnulib.
9237 * configure: Rebuild.
9238 * common/common-defs.h: Use new path to gnulib.
9239 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9240 (GNULIB_H): Remove.
9241 (INCGNU): Look in new gnulib location.
9242 (HFILES_NO_SRCDIR): Remove gnulib files.
9243 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9244 (generated_files): Remove GNULIB_H.
9245 ($(LIBGNU), all-lib): Remove targets.
9246 (distclean): Don't mention GNULIB_BUILDDIR.
9247 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9248
92492019-06-14 Tom Tromey <tromey@adacore.com>
9250
9251 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9252 Warn if symbol file does not provide any symbols.
9253
92542019-06-14 Tom Tromey <tromey@adacore.com>
9255
9256 * source.c (find_and_open_source): Respect basenames_may_differ.
9257
92582019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9259
9260 * annotate.c (annotate_breakpoints_invalid): Make use of
9261 scoped_restore_terminal_state.
9262 (annotate_frames_invalid): Likewise.
9263
92642019-06-14 Tom Tromey <tromey@adacore.com>
9265
9266 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9267 allow assignment to an internalvar.
9268
92692019-06-14 Tom Tromey <tromey@adacore.com>
9270
9271 * ada-lex.l: Allow "_" in attribute names.
9272
92732019-06-14 Tom Tromey <tromey@adacore.com>
9274
9275 PR gdb/24653:
9276 * regcache.c (registers_changed): Don't call alloca.
9277 * top.c (execute_command): Don't call alloca.
9278
92792019-06-13 Pedro Alves <palves@redhat.com>
9280
9281 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9282 'expression'. When parsing an expression, error out if there's
9283 junk after "unlimited".
9284 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9285 (do_set_command): Adjust calls to is_unlimited_literal.
9286
92872019-06-13 Pedro Alves <palves@redhat.com>
9288
9289 * compile/compile.c (make_compile_options_def_group): Add braces
9290 around array_view initializer.
9291 * thread.c (make_thread_apply_all_options_def_group)
9292 (make_thread_apply_all_options_def_group): Likewise.
9293
92942019-06-13 Pedro Alves <palves@redhat.com>
9295
9296 * NEWS (New commands): Mention "maint test-options
9297 require-delimiter", "maint test-options unknown-is-error", "maint
9298 test-options unknown-is-operand" and "maint show
9299 test-options-completion-result".
9300 (New command options, command completion): New section.
9301 (Completion improvements): New section.
9302 Mention that you can abbreviate "unlimited".
9303
93042019-06-13 Pedro Alves <palves@redhat.com>
9305
9306 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9307 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9308 * unittests/cli-utils-selftests.c (test_parse_flags)
9309 (test_parse_flags_qcs): Delete.
9310 (test_cli_utils): Don't call deleted functions.
9311
93122019-06-13 Pedro Alves <palves@redhat.com>
9313
9314 * thread.c: Include "cli/cli-option.h".
9315 (tp_array_compar_ascending): Global.
9316 (tp_array_compar): Delete function.
9317 (tp_array_compar_ascending, tp_array_compar_descending): New
9318 functions.
9319 (ascending_option_def, qcs_flag_option_def)
9320 (thr_qcs_flags_option_defs)
9321 (make_thread_apply_all_options_def_group)
9322 (make_thread_apply_options_def_group): New.
9323 (thread_apply_all_command): Use gdb::option::process_options.
9324 (thread_apply_command_completer)
9325 (thread_apply_all_command_completer): New.
9326 (thread_apply_command): Use gdb::option::process_options.
9327 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9328 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9329 to generate help text of "thread apply". Adjust "taas"'s help.
9330 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9331 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9332
93332019-06-13 Pedro Alves <palves@redhat.com>
9334
9335 * thread.c (thread_apply_command): Check for invalid TID with
9336 isdigit instead of !isalpha.
9337
93382019-06-13 Pedro Alves <palves@redhat.com>
9339
9340 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9341 (validate_flags_qcs): New.
9342 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9343 (validate_flags_qcs): Declare.
9344 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9345 (make_frame_apply_options_def_group): New.
9346 (frame_apply_command_count): Process options with
9347 gdb::option::process_options.
9348 (frame_apply_completer): New.
9349 (frame_apply_level_completer, frame_apply_all_completer)
9350 (frame_apply_completer): New.
9351 (_initialize_stack): Update help of "frame apply", "frame apply
9352 level", "frame apply all" and "faas" to mention supported options
9353 and install command completers.
9354 * stack.h (frame_apply_all_completer): Declare.
9355 * thread.c: Include "stack.h".
9356 (tfaas_command): Add "--".
9357 (_initialize_thread): Update help "tfaas" to mention supported
9358 options and install command completer.
9359
93602019-06-13 Pedro Alves <palves@redhat.com>
9361
9362 * completer.c (complete_nested_command_line): New.
9363 (gdb_completion_word_break_characters_throw): Add assertion.
9364 * completer.h (complete_nested_command_line): Declare.
9365
93662019-06-13 Pedro Alves <palves@redhat.com>
9367
9368 * stack.c (parse_backtrace_qualifiers): New.
9369 (backtrace_command): Use it.
9370 (backtrace_command_completer): Complete on qualifiers.
9371
93722019-06-13 Pedro Alves <palves@redhat.com>
9373
9374 * frame.c: Include "cli/cli-option.h.
9375 (user_set_backtrace_options): New.
9376 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9377 Delete.
9378 (get_prev_frame): Adjust.
9379 (boolean_option_def, uinteger_option_def)
9380 (set_backtrace_option_defs): New.
9381 (_initialize_frame): Adjust and use
9382 gdb::option::add_setshow_cmds_for_options to install "set
9383 backtrace past-main" and "set backtrace past-entry".
9384 * frame.h: Include "cli/cli-option.h".
9385 (struct frame_print_options): Forward declare.
9386 (print_frame_arguments_all, print_frame_arguments_scalars)
9387 (print_frame_arguments_none): Declare.
9388 (print_entry_values): Delete declaration.
9389 (struct frame_print_options, user_frame_print_options): New.
9390 (struct set_backtrace_options): New.
9391 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9392 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9393 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9394 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9395 (list_args_or_locals): Add frame_print_options parameter.
9396 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9397 * python/py-framefilter.c (enumerate_args): Pass down
9398 USER_FRAME_PRINT_OPTIONS.
9399 * stack.c: Include "cli/cli-option.h".
9400 (print_frame_arguments_all, print_frame_arguments_scalars)
9401 (print_frame_arguments_none): Declare.
9402 (print_raw_frame_arguments, print_entry_values): Delete.
9403 (user_frame_print_options): New.
9404 (boolean_option_def, enum_option_def, frame_print_option_defs):
9405 New.
9406 (struct backtrace_cmd_options): New.
9407 (bt_flag_option_def): New.
9408 (backtrace_command_option_defs): New.
9409 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9410 (print_frame_arg, read_frame_arg, print_frame_args)
9411 (print_frame_info, print_frame): Add frame_print_options parameter
9412 and use it.
9413 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9414 (backtrace_command_1): Add frame_print_options and
9415 backtrace_cmd_options parameters and use them.
9416 (make_backtrace_options_def_group): New.
9417 (backtrace_command): Process command options with
9418 gdb::option::process_options.
9419 (backtrace_command_completer): New.
9420 (_initialize_stack): Extend "backtrace"'s help to mention
9421 supported options. Install completer for "backtrace".
9422 Install some settings commands with add_setshow_cmds_for_options.
9423
94242019-06-13 Pedro Alves <palves@redhat.com>
9425
9426 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9427 and that "set/show print raw frame-arguments" are now deprecated.
9428
9429 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9430 command.
9431 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9432 * stack.c (_initialize_stack): Install "set/show print
9433 raw-frame-arguments", and deprecate "set/show print raw
9434 frame-arguments".
9435 * valprint.c (_initialize_valprint): Deprecate "set/show print
9436 raw".
9437
94382019-06-13 Pedro Alves <palves@redhat.com>
9439
9440 * compile/compile.c (struct compile_options): New.
9441 (compile_flag_option_def, compile_command_option_defs)
9442 (make_compile_options_def_group): New.
9443 (compile_file_command): Handle options with
9444 gdb::option::process_options.
9445 (compile_file_command_completer): New function.
9446 (compile_code_command): Handle options with
9447 gdb::option::process_options.
9448 (compile_code_command_completer): New function.
9449 (_initialize_compiler): Install completers for "compile code" and
9450 "compile file". Mention available options in "compile code" and
9451 "compile code"'s help.
9452 * completer.c (advance_to_completion_word): New, factored out from
9453 ...
9454 (advance_to_expression_complete_word_point): ... this.
9455 (advance_to_filename_complete_word_point): New.
9456 * completer.h (advance_to_filename_complete_word_point): New
9457 declaration.
9458
94592019-06-13 Pedro Alves <palves@redhat.com>
9460
9461 * compile/compile.c: Include "cli/cli-option.h".
9462 (compile_print_value): Scope data pointer is now a
9463 value_print_options pointer; adjust.
9464 (compile_print_command): Process options. Scope data pointer is
9465 now a value_print_options pointer; adjust.
9466 (_initialize_compile): Update "compile print"'s help to include
9467 supported options. Install a completer for "compile print".
9468 * cp-valprint.c (show_vtblprint, show_objectprint)
9469 (show_static_field_print): Delete.
9470 (_initialize_cp_valprint): Don't install "set print
9471 static-members", "set print vtbl", "set print object" here.
9472 * printcmd.c: Include "cli/cli-option.h" and
9473 "common/gdb_optional.h".
9474 (print_command_parse_format): Rework to fill in a
9475 value_print_options instead of a format_data.
9476 (print_value): Change parameter type from format_data pointer to
9477 value_print_options reference. Adjust.
9478 (print_command_1): Process options. Adjust to pass down a
9479 value_print_options.
9480 (print_command_completer): New.
9481 (_initialize_printcmd): Install print_command_completer as
9482 handle_brkchars completer for the "print" command. Update
9483 "print"'s help to include supported options.
9484 * valprint.c: Include "cli/cli-option.h".
9485 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9486 here from cp-valprint.c.
9487 (boolean_option_def, uinteger_option_def)
9488 (value_print_option_defs, make_value_print_options_def_group):
9489 New. Use gdb::option::add_setshow_cmds_for_options to install
9490 "set print elements", "set print null-stop", "set print repeats",
9491 "set print pretty", "set print union", "set print array", "set
9492 print address", "set print symbol", "set print array-indexes".
9493 * valprint.h: Include <string> and "cli/cli-option.h".
9494 (make_value_print_options_def_group): Declare.
9495 (print_value): Change parameter type from format_data pointer to
9496 value_print_options reference.
9497 (print_command_completer): Declare.
9498
94992019-06-13 Pedro Alves <palves@redhat.com>
9500
9501 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9502 (COMMON_SFILES): Add maint-test-settings.c.
9503 * cli/cli-decode.c (boolean_enums): New global, factored out from
9504 ...
9505 (add_setshow_boolean_cmd): ... here.
9506 * cli/cli-decode.h (boolean_enums): Declare.
9507 * cli/cli-option.c: New file.
9508 * cli/cli-option.h: New file.
9509 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9510 factored out from ...
9511 (parse_cli_boolean_value(const char *)): ... this.
9512 (is_unlimited_literal): Change parameter type to pointer to
9513 pointer. Adjust and advance ARG pointer.
9514 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9515 (parse_cli_var_enum): New, factored out from ...
9516 (do_set_command): ... this. Adjust.
9517 * cli/cli-setshow.h (parse_cli_boolean_value)
9518 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9519 (parse_cli_var_enum): Declare.
9520 * cli/cli-utils.c: Include "cli/cli-option.h".
9521 (get_ulongest): New.
9522 * cli/cli-utils.h (get_ulongest): Declare.
9523 (check_for_argument): New overloads.
9524 * maint-test-options.c: New file.
9525
95262019-06-13 Pedro Alves <palves@redhat.com>
9527
9528 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9529 parse a range if "-" is at the end of the string.
9530
95312019-06-13 Pedro Alves <palves@redhat.com>
9532
9533 * cli/cli-setshow.c (parse_auto_binary_operation)
9534 (parse_cli_boolean_value): Don't allow "o".
9535
95362019-06-13 Pedro Alves <palves@redhat.com>
9537
9538 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9539 * NEWS: Mention maint test-settings KIND.
9540 * maint-test-settings.c: New file.
9541
95422019-06-13 Pedro Alves <palves@redhat.com>
9543
9544 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9545 completer.
9546 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9547 "set" completers.
9548
95492019-06-13 Pedro Alves <palves@redhat.com>
9550
9551 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9552 after item.
9553
95542019-06-13 Pedro Alves <palves@redhat.com>
9555
9556 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9557
95582019-06-13 Pedro Alves <palves@redhat.com>
9559
9560 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9561 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9562 call.
9563 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9564 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9565 calls.
9566 (check_for_argument): Skip spaces after argument.
9567
95682019-06-13 Pedro Alves <palves@redhat.com>
9569
9570 * thread.c (thread_apply_command): Adjust TID parsing.
9571 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9572 detected before end of string.
9573 (tid_is_in_list): Error out if LIST is invalid.
9574
95752019-06-13 Pedro Alves <palves@redhat.com>
9576
9577 * completer.c (complete_line_internal_1): Rewind completion word
9578 point.
9579 (completion_tracker::advance_custom_word_point_by): Change
9580 parameter type to int.
9581 * completer.h (completion_tracker::advance_custom_word_point_by):
9582 Likewise.
9583
95842019-06-13 Pedro Alves <palves@redhat.com>
9585
9586 * completer.c (advance_to_completion_word): Handle delimiters.
9587
95882019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9589
9590 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9591
95922019-06-11 Tom Tromey <tom@tromey.com>
9593
9594 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9595 (xmalloc_failed): Move to alloc.c.
9596 * alloc.c: New file.
9597 * Makefile.in (COMMON_SFILES): Add alloc.c.
9598
95992019-06-11 Tom Tromey <tom@tromey.com>
9600
9601 * nat/linux-waitpid.c: Don't include server.h.
9602 (linux_debug): Remove.
9603 (my_waitpid): Update.
9604
96052019-06-11 Tom Tromey <tromey@adacore.com>
9606
9607 * infcall.c (_initialize_infcall): Remove trailing newline from
9608 help.
9609 * user-regs.c (_initialize_user_regs): Remove trailing newline
9610 from help.
9611 * typeprint.c (_initialize_typeprint): Remove trailing newline
9612 from help.
9613 * reverse.c (_initialize_reverse): Remove trailing newlines from
9614 help.
9615 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9616 from help.
9617 * language.c (add_set_language_command): Remove trailing newline
9618 from help.
9619 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9620 help.
9621 * disasm.c (_initialize_disasm): Remove trailing newline from
9622 help.
9623 * top.c (init_main): Remove trailing newline from help.
9624 * interps.c (_initialize_interpreter): Remove trailing newline
9625 from help.
9626 * btrace.c (_initialize_btrace): Remove trailing newlines from
9627 help.
9628 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9629 from help.
9630 * python/python.c (_initialize_python): Remove trailing newline
9631 from help.
9632 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9633 help.
9634 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9635 from help. Reformat some text.
9636 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9637 from help.
9638 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9639 newline from help.
9640
96412019-06-11 Tom Tromey <tromey@adacore.com>
9642
9643 * darwin-nat.c (darwin_decode_exception_message)
9644 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9645
96462019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9647
9648 * valops.c (value_slice): Check for not allocated or not
9649 associated values.
9650
96512019-06-10 Tom de Vries <tdevries@suse.de>
9652
9653 PR gdb/24618
9654 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9655 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9656 invalid.
9657
96582019-06-10 Tom de Vries <tdevries@suse.de>
9659
9660 PR gdb/24611
9661 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9662 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9663
96642019-06-10 Tom de Vries <tdevries@suse.de>
9665
9666 PR symtab/24545
9667 * symtab.c (struct demangled_name_entry): Add language field.
9668 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9669 static minimal symbol". Set and use language field.
9670
96712019-06-10 Tom Tromey <tromey@adacore.com>
9672
9673 * ada-lang.c (_initialize_ada_language): Update help text.
9674
96752019-06-10 Tom Tromey <tromey@adacore.com>
9676
9677 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9678 with a newline.
9679 * guile/guile.c (handle_boot_error): Don't end warning with a
9680 newline.
9681 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9682 warning with a newline.
9683 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9684 newline.
9685 (s12z_frame_cache): Likewise.
9686 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9687 a newline.
9688 * solib-svr4.c (disable_probes_interface): Don't end warning with
9689 a newline.
9690 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9691 newline.
9692 * python/python.c (do_finish_initialization): Don't end warning
9693 with a newline.
9694
96952019-06-10 Tom Tromey <tom@tromey.com>
9696
9697 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9698 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9699 gdbpy_enter.
9700
97012019-06-10 Tom Tromey <tromey@adacore.com>
9702
9703 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9704 data.
9705 (elf_new_init): Don't call stabsread_new_init.
9706 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9707 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9708 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9709
97102019-06-10 Tom de Vries <tdevries@suse.de>
9711
9712 PR symtab/16264
9713 PR symtab/24517
9714 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9715
97162019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9717
9718 * source.c (find_and_open_source): Also rewrite relative file
9719 names.
9720
97212019-04-26 Amos Bird <amosbird@gmail.com>
9722
9723 * annotate.c (annotate_thread_exited): Add "thread-exited"
9724 annotation.
9725
97262019-06-06 Tom Tromey <tromey@adacore.com>
9727
9728 * maint.h (class scoped_command_stats): Use
9729 DISABLE_COPY_AND_ASSIGN.
9730 <print_time>: New method.
9731 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9732 print_time.
9733 (scoped_command_stats::print_time): New method.
9734
97352019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9736
9737 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9738 instructions of lengths 6 or 8 bytes.
9739
97402019-06-04 Pedro Alves <palves@redhat.com>
9741
9742 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9743
9744 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9745 * breakpoint.c (condition_completer): Likewise.
9746 * cli/cli-dump.c (scan_expression): Likewise.
9747 * common/filestuff.c (mkdir_recursive): Likewise.
9748 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9749 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9750 (gdb_abspath): Likewise.
9751 * compile/compile-cplus-types.c
9752 (compile_cplus_instance::decl_name): Likewise.
9753 * completer.c (complete_explicit_location):
9754 (signal_completer, reg_or_group_completer_1): Likewise.
9755 * cp-support.c (cp_remove_params_if_any): Likewise.
9756 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9757 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9758 * infcmd.c (strip_bg_char): Likewise.
9759 * linespec.c (copy_token_string): Likewise.
9760 * mi/mi-main.c (output_cores): Likewise.
9761 * psymtab.c (psymtab_search_name):
9762 * symfile.c (test_set_ext_lang_command): Likewise.
9763 * target.c (target_fileio_read_stralloc): Likewise.
9764 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9765 * value.c (complete_internalvar): Likewise.
9766
97672019-06-04 Christian Biesinger <cbiesinger@google.com>
9768
9769 Add objfile property to gdb.Type.
9770 * NEWS: Mention Python API addition.
9771 * python/py-type.c (typy_get_objfile): New method.
9772
97732019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9774
9775 * NEWS: Mention the new set|show style [title|highlight].
9776 Mention changes to "show style", "help" and "apropos".
9777
97782019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9779
9780 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9781 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9782 instead of print_help_for_command.
9783 (print_doc_of_command): New function.
9784 (help_list): Add 'apropos -v word' suggestion.
9785 (print_help_for_command): Style the command name using title style.
9786 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9787 (_initialize_cli_cmds): Describe -v in apropos_command help.
9788
97892019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9790
9791 * cli/cli-style.h (cli_style_option): Add name in constructor,
9792 add m_name class member, add constructor with intensity,
9793 add name class function.
9794 (cli_style_option::add_setshow_commands): Remove name argument.
9795 (highlight_style, title_style): New styles.
9796 * cli/cli-style.c (do_show): New function that shows a style
9797 characteristic styling the style name with itself.
9798 (set_style_name): New function.
9799 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9800 Update all callers according to the changes in cli/cli-style.h.
9801 * utils.h (fputs_highlighted): New function.
9802 * utils.c (fputs_highlighted): Likewise.
9803
98042019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9805
9806 * NEWS: Mention new pipe command and new convenience variables.
9807
98082019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9809
9810 * cli/cli-cmds.c (pipe_command): New function.
9811 (_initialize_cli_cmds): Call add_com for pipe_command.
9812 Define | as an alias for pipe.
9813 (exit_status_set_internal_vars): New function.
9814 (shell_escape): Call exit_status_set_internal_vars.
9815 cli/cli-decode.c (find_command_name_length): Recognize | as
9816 a single character command.
9817
98182019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9819
9820 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9821 top.c (execute_command_to_ui_file): New function, mostly a copy
9822 of execute_command_to_string.
9823 (execute_command_to_string): Implement by calling
9824 execute_command_to_ui_file.
9825
98262019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9827
9828 * top.h (saved_command_line): Remove declaration.
9829 * top.c (previous_saved_command_line, previous_repeat_arguments):
9830 New variables.
9831 (saved_command_line): Make static, define together with other
9832 'repeat variables'.
9833 (dont_repeat): Clear repeat_arguments.
9834 (repeat_previous, get_saved_command_line, save_command_line):
9835 New functions.
9836 (gdb_init): Initialize saved_command_line
9837 and previous_saved_command_line.
9838 * main.c (captured_main_1): Remove saved_command_line initialization.
9839 * event-top.c (handle_line_of_input): Update to use
9840 the new 'repeat' related functions instead of direct access to
9841 saved_command_line.
9842 * command.h (repeat_previous, get_saved_command_line,
9843 save_command_line): New declarations.
9844 (dont_repeat): Add comment.
9845
98462019-05-30 Tom Tromey <tromey@adacore.com>
9847
9848 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9849 Fix comment.
9850 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9851
98522019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9853
9854 PR cli/24587
9855 * completer.c (complete): Initialize variable word.
9856
98572019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9858
9859 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9860 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9861 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9862 'body' is NULL to the outter 'if', protecting the '!is_define'
9863 situation as well.
9864
98652019-05-29 Tom Tromey <tromey@adacore.com>
9866
9867 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9868 (dwarf_unknown): New function.
9869 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9870 (dwarf_type_encoding_name): Use dwarf_unknown.
9871
98722019-05-29 Tom Tromey <tromey@adacore.com>
9873
9874 PR c++/20020:
9875 * cp-valprint.c (cp_print_value_fields): Call
9876 cp_print_static_field inside "try".
9877
98782019-05-29 Tom Tromey <tromey@adacore.com>
9879
9880 * inflow.c (struct terminal_info): Add default operator=.
9881 * configure: Rebuild.
9882 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9883 -Wdeprecated-copy-dtor, -Wredundant-move.
9884
98852019-05-29 Tom Tromey <tromey@adacore.com>
9886
9887 * NEWS: Add entry.
9888 * infcmd.c (print_return_value_1): Handle finish_print
9889 option.
9890 (show_print_finish): New function.
9891 (_initialize_infcmd): Add "set/show print finish" commands.
9892 * valprint.c (user_print_options): Initialize new member.
9893 * valprint.h (struct value_print_options) <finish_print>: New
9894 member.
9895
98962019-05-28 Tom Tromey <tromey@adacore.com>
9897
9898 * ada-lang.c (ada_remove_Xbn_suffix)
9899 (find_old_style_renaming_symbol)
9900 (parse_old_style_renaming): Remove.
9901 (ada_find_renaming_symbol): Don't call
9902 find_old_style_renaming_symbol.
9903 (ada_is_renaming_symbol): Rename from
9904 ada_find_renaming_symbol. Remove "block" parameter. Return
9905 bool. Now static.
9906 (ada_read_var_value): Update and simplify.
9907 * ada-exp.y (write_var_or_type): Remove old code.
9908
99092019-05-28 Alan Hayward <alan.hayward@arm.com>
9910
9911 PR gdb/25010
9912 * event-top.c: Remove include comment.
9913 * inflow.c (class scoped_ignore_sigttou): Move from here...
9914 * inflow.h (class scoped_ignore_sigttou): ...to here.
9915 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9916 * top.c: Remove include comment.
9917
99182019-05-27 Tom Tromey <tom@tromey.com>
9919
9920 * NEWS: Fix typo.
9921
99222019-05-22 Tom Tromey <tromey@adacore.com>
9923
9924 * target.c (target_follow_exec): Constify parameter.
9925 * target-delegates.c: Rebuild.
9926 * remote.c (remote_target::follow_exec): Constify parameter.
9927 * infrun.c (follow_exec): Constify parameter.
9928 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9929 (target_follow_exec): Likewise.
9930
99312019-05-22 Alan Hayward <alan.hayward@arm.com>
9932
9933 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9934 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9935
99362019-05-22 Alan Hayward <alan.hayward@arm.com>
9937
9938 * NEWS: Add debugredirect and testsuite sections.
9939
99402019-05-22 Simon Cook <simon.cook@embecosm.com>
9941
9942 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9943 target descriptions using exclusively floating point register name
9944 aliases.
9945
99462019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9947
9948 PR gdb/18644:
9949 * f-lang.c (build_fortran_types): Handle the case where
9950 gdbarch_floatformat_for_type returns a nullptr.
9951
99522019-05-21 Tom de Vries <tdevries@suse.de>
9953
9954 PR cli/24587
9955 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9956
99572019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9958
9959 PR gdb/18644:
9960 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9961 16-byte floats.
9962 * i386-tdep.c (i386_floatformat_for_type): Use
9963 floatformats_ia64_quad for the 16-byte floating point component
9964 within a fortran 32-byte complex number.
9965
99662019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9967
9968 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9969 delete default constructor.
9970 (find_partial_die): Update to return const struct.
9971 (partial_die_parent_scope): Move variable declaration into scope
9972 of its use and change its type to auto.
9973 (guess_partial_die_structure_name): Likewise.
9974 (partial_die_info::fixup): Likewise.
9975
99762019-05-17 Tom Tromey <tromey@adacore.com>
9977
9978 * source.c (find_and_open_source): Remove cast.
9979
99802019-05-17 Tom Tromey <tromey@adacore.com>
9981
9982 * annotate.c (annotate_source): Make "filename" const.
9983 * annotate.h (annotate_source): Use const.
9984
99852019-05-17 Alan Hayward <alan.hayward@arm.com>
9986
9987 * disasm.c (set_disassembler_options): Send errors to stderr.
9988
99892019-05-17 Alan Hayward <alan.hayward@arm.com>
9990
9991 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9992 (cli_interp_base::set_logging): Check debug_redirect.
9993 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9994 * cli/cli-logging.c (debug_redirect): Add static variable.
9995 (pop_output_files): Add default param.
9996 (handle_redirections): Print debug setting.
9997 (show_logging_command): Likewise.
9998 (_initialize_cli_logging): Add debugredirect command.
9999 * interps.c (current_interp_set_logging): Add debug_redirect
10000 parameter.
10001 * interps.h (set_logging): Add debug_redirect parameter.
10002 (current_interp_set_logging): Likewise.
10003 * mi/mi-common.h: Likewise.
10004 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10005
100062019-05-17 Alan Hayward <alan.hayward@arm.com>
10007 Tom Tromey <tromey@adacore.com>
10008
10009 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10010 directly.
10011 * cli/cli-interp.h (make_logging_output): Remove declaration.
10012 * cli/cli-logging.c (make_logging_output): Remove function.
10013 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10014 directly.
10015 * ui-file.c (tee_file::tee_file): Remove bools.
10016 (tee_file::~tee_file): Remove deletes.
10017 * ui-file.h (tee_file): Remove bools.
10018
100192019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10020
10021 * mi/mi-cmds.h (mi_cmd_complete): New function.
10022 * mi/mi-main.c (mi_cmd_complete): Likewise.
10023 * mi/mi-cmds.c: Define new MI command -complete.
10024 * NEWS: Mention new -complete command.
10025
100262019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10027
10028 * completer.h (complete): New function.
10029 * completer.c (complete): Likewise.
10030 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10031 function defined in completer.h.
10032
100332019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10034
10035 * MAINTAINERS (Write After Approval): Add myself.
10036
100372019-05-17 Tom de Vries <tdevries@suse.de>
10038
10039 PR gdb/24094
10040 * dwarf2read.c (struct cu_partial_die_info): New struct.
10041 (find_partial_die): Return cu_partial_die_info.
10042 (partial_die_parent_scope, guess_partial_die_structure_name)
10043 (partial_die_info::fixup): Handle new return type of find_partial_die.
10044
100452019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10046
10047 PR breakpoints/24541
10048 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10049 "std::string", simplifying the algorithm.
10050
100512019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10052
10053 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10054 (stap_static_probe_ops::get_probes): Likewise.
10055
100562019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10057
10058 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10059 '-')" and "else if".
10060 (stap_parse_single_operand): Join checks for
10061 "gdbarch_stap_parse_special_token_p" and
10062 "gdbarch_stap_parse_special_token" in the same "if" statement.
10063 Invert check when verifying for operation on register
10064 displacement.
10065
100662019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10067
10068 * stap-probe.c (stap_get_opcode): Update comment.
10069 (stap_get_expected_argument_type): Likewise.
10070 (handle_stap_probe): Likewise.
10071
100722019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10073
10074 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10075 return type to 'bool'. Adjust comment. Use 'bool' when
10076 appropriate.
10077 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10078 * stap-probe.c (stap_parse_argument_1): Likewise.
10079 (stap_is_operator): Likewise.
10080 (stap_is_generic_prefix): Likewise.
10081 (stap_is_register_prefix): Likewise.
10082 (stap_is_register_indirection_prefix): Likewise.
10083 (stap_is_integer_prefix): Likewise.
10084 (stap_generic_check_suffix): Likewise.
10085 (stap_check_integer_suffix): Likewise.
10086 (stap_check_register_suffix): Likewise.
10087 (stap_check_register_indirection_suffix): Likewise.
10088 (stap_parse_register_operand): Likewise.
10089 (stap_parse_single_operand): Likewise.
10090 (stap_parse_argument_1): Likewise.
10091 (stap_probe::get_argument_count): Likewise.
10092 (stap_is_operator): Likewise.
10093
100942019-05-16 Tom Tromey <tromey@adacore.com>
10095
10096 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10097 keyword to foreach.
10098
100992019-05-15 Simon Marchi <simon.marchi@efficios.com>
10100
10101 * linux-thread-db.c (try_thread_db_load_1): Change return type
10102 to bool.
10103 (try_thread_db_load): Likewise.
10104 (try_thread_db_load_from_pdir_1): Likewise.
10105 (try_thread_db_load_from_pdir): Likewise.
10106 (try_thread_db_load_from_sdir): Likewise.
10107 (try_thread_db_load_from_dir): Likewise.
10108 (thread_db_load_search): Likewise.
10109 (has_libpthread): Likewise.
10110 (thread_db_load): Likewise.
10111
101122019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10113
10114 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10115 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10116 NULL, and complain/return if that's the case.
10117
101182019-05-15 John Darrington <john@darrington.wattle.id.au>
10119
10120 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10121 (advance, posn, abstract_read_memory): New functions.
10122 [struct mem_read_abstraction]: New struct.
10123 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10124
101252019-05-14 Tom Tromey <tromey@adacore.com>
10126
10127 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10128 value is not lval_memory.
10129
101302019-05-14 Tom Tromey <tromey@adacore.com>
10131
10132 * solib.c (info_sharedlibrary_command): Style the file name.
10133
101342019-05-14 Alan Hayward <alan.hayward@arm.com>
10135
10136 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10137 (aarch64_vnv_type): Likewise.
10138 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10139 * common/tdesc.c: Likewise.
10140 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10141 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10142 * features/aarch64-fpu.xml: Add ieee half view.
10143 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10144 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10145 * gdbtypes.h (struct builtin_type): Likewise.
10146 (struct objfile_type): Likewise.
10147
101482019-05-12 Paul Naert <paul.naert@polymtl.ca>
10149
10150 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10151 typo.
10152 * location.h (string_to_event_location): Likewise.
10153
101542019-05-11 Joel Brobecker <brobecker@adacore.com>
10155
10156 GDB 8.3 released.
10157
101582019-05-10 Simon Marchi <simon.marchi@efficios.com>
10159
10160 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10161 New variable declaration.
10162 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10163 New variable.
10164 (print_one_breakpoint): Use ui_out::test_flags and new global
10165 variable to compute use_fixed_output.
10166 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10167 Remove.
10168 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10169 (mi_multi_location_breakpoint_output_fixed): Remove.
10170 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10171 new variable.
10172 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10173 fix_multi_location_breakpoint_output flag if version >= 3.
10174 * ui-out.h (enum ui_out_flag)
10175 <fix_multi_location_breakpoint_output>: New enumerator.
10176
101772019-05-10 Simon Marchi <simon.marchi@efficios.com>
10178
10179 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10180
101812019-05-10 Tom Tromey <tromey@adacore.com>
10182
10183 * ada-lang.c (catch_ada_completer): New function.
10184 (_initialize_ada_language): Use it.
10185
101862019-05-10 Tom Tromey <tromey@adacore.com>
10187
10188 * thread.c (print_thread_info): Make "requested_threads" const.
10189 * gdbthread.h (print_thread_info): Make "requested_threads"
10190 const.
10191 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10192 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10193
101942019-05-08 Tom Tromey <tom@tromey.com>
10195
10196 * gdbtypes.c (objfile_type_data): Change type.
10197 (objfile_type, _initialize_gdbtypes): Update.
10198
101992019-05-08 Tom Tromey <tom@tromey.com>
10200
10201 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10202 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10203 (_initialize_dwarf2_frame): Update.
10204
102052019-05-08 Tom Tromey <tom@tromey.com>
10206
10207 * objc-lang.c (objc_objfile_data): Change type.
10208 (find_methods): Update.
10209 (_initialize_objc_lang): Remove.
10210
102112019-05-08 Tom Tromey <tom@tromey.com>
10212
10213 * stabsread.c (rs6000_builtin_type_data): Change type.
10214 (rs6000_builtin_type, _initialize_stabsread): Update.
10215
102162019-05-08 Tom Tromey <tom@tromey.com>
10217
10218 * mips-tdep.c (mips_pdr_data): Remove.
10219 (_initialize_mips_tdep): Update.
10220
102212019-05-08 Tom Tromey <tom@tromey.com>
10222
10223 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10224 (hppa_init_objfile_priv_data, read_unwind_info)
10225 (find_unwind_entry, _initialize_hppa_tdep): Update.
10226
102272019-05-08 Tom Tromey <tom@tromey.com>
10228
10229 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10230 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10231 on obstack.
10232 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10233
102342019-05-08 Tom Tromey <tom@tromey.com>
10235
10236 * mdebugread.c (basic_type_data): Change type.
10237 (basic_type, _initialize_mdebugread): Update.
10238
102392019-05-08 Tom Tromey <tom@tromey.com>
10240
10241 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10242
102432019-05-08 Tom Tromey <tom@tromey.com>
10244
10245 * nto-tdep.c (nto_inferior_data_reg): Change type.
10246 (nto_inferior_data): Update.
10247 (nto_inferior_data_cleanup, nto_new_inferior_data)
10248 (_initialize_nto_tdep): Remove.
10249 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10250
102512019-05-08 Tom Tromey <tom@tromey.com>
10252
10253 * ada-lang.c (struct ada_inferior_data): Add initializers.
10254 (ada_inferior_data): Change type.
10255 (ada_inferior_data_cleanup): Remove.
10256 (get_ada_inferior_data, ada_inferior_exit)
10257 (struct ada_pspace_data): Add initializers, destructor.
10258 (ada_pspace_data_handle): Change type.
10259 (get_ada_pspace_data): Update.
10260 (ada_pspace_data_cleanup): Remove.
10261
102622019-05-08 Tom Tromey <tom@tromey.com>
10263
10264 * coffread.c (struct coff_symfile_info): Add initializers.
10265 (coff_objfile_data_key): Move lower. Change type.
10266 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10267 Update.
10268 (coff_free_info): Remove.
10269
102702019-05-08 Tom Tromey <tom@tromey.com>
10271
10272 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10273 (fbsd_pspace_data_handle): Move lower. Change type.
10274 (get_fbsd_pspace_data): Update.
10275 (fbsd_pspace_data_cleanup): Remove.
10276 (_initialize_fbsd_tdep): Update.
10277
102782019-05-08 Tom Tromey <tom@tromey.com>
10279
10280 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10281 (get_ada_tasks_pspace_data): Update.
10282 (ada_tasks_pspace_data_cleanup): Remove.
10283 (_initialize_tasks): Update.
10284 (ada_tasks_inferior_data_handle): Change type.
10285 (get_ada_tasks_inferior_data): Update.
10286 (ada_tasks_inferior_data_cleanup): Remove.
10287 (struct ada_tasks_pspace_data): Add initializers.
10288
102892019-05-08 Tom Tromey <tom@tromey.com>
10290
10291 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10292 * symfile-debug.c (debug_sym_get_probes): Change type.
10293 * stap-probe.c (handle_stap_probe):
10294 (stap_static_probe_ops::get_probes): Change type.
10295 * probe.h (class static_probe_ops) <get_probes>: Change type.
10296 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10297 (parse_probes_in_pspace): Update.
10298 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10299 Update.
10300 (any_static_probe_ops::get_probes): Change type.
10301 * elfread.c (elfread_data): New typedef.
10302 (probe_key): Change type.
10303 (elf_get_probes): Likewise. Update.
10304 (probe_key_free): Remove.
10305 (_initialize_elfread): Update.
10306 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10307 Change type.
10308 (dtrace_process_dof_probe, dtrace_process_dof)
10309 (dtrace_static_probe_ops::get_probe): Change type.
10310
103112019-05-08 Tom Tromey <tom@tromey.com>
10312
10313 * xcoffread.c (struct xcoff_symfile_info): Rename from
10314 coff_symfile_info. Add initializers.
10315 (xcoff_objfile_data_key): Move lower. Change type.
10316 (XCOFF_DATA): Rewrite.
10317 (xcoff_free_info): Remove.
10318 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10319 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10320 (xcoff_initial_scan): Update.
10321
103222019-05-08 Tom Tromey <tom@tromey.com>
10323
10324 * solib-svr4.c (struct svr4_info): Add initializers and
10325 destructor.
10326 <probes_table>: Now an htab_up.
10327 (solib_svr4_pspace_data): Change type.
10328 (free_probes_table): Simplify.
10329 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10330 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10331 (probes_table_remove_objfile_probes, register_solib_event_probe)
10332 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10333 (_initialize_svr4_solib): Update.
10334
103352019-05-08 Tom Tromey <tom@tromey.com>
10336
10337 * remote.c (remote_pspace_data): Change type.
10338 (remote_pspace_data_cleanup): Remove.
10339 (get_remote_exec_file, set_pspace_remote_exec_file)
10340 (_initialize_remote): Update.
10341
103422019-05-08 Tom Tromey <tom@tromey.com>
10343
10344 * breakpoint.c (breakpoint_objfile_key): Change type.
10345 (get_breakpoint_objfile_data): Update.
10346 (free_breakpoint_objfile_data): Remove.
10347 (_initialize_breakpoint): Update.
10348
103492019-05-08 Tom Tromey <tom@tromey.com>
10350
10351 * linux-tdep.c (struct linux_info): Add initializers.
10352 (linux_inferior_data): Move. Change type.
10353 (invalidate_linux_cache_inf): Update.
10354 (linux_inferior_data_cleanup): Remove.
10355 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10356
103572019-05-08 Tom Tromey <tom@tromey.com>
10358
10359 * auxv.c (auxv_inferior_data): Move. Change type.
10360 (auxv_inferior_data_cleanup): Remove.
10361 (invalidate_auxv_cache_inf): Rewrite.
10362 (get_auxv_inferior_data, _initialize_auxv): Update.
10363
103642019-05-08 Tom Tromey <tom@tromey.com>
10365
10366 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10367 (symfile_debug_objfile_data_key): Change type.
10368 (symfile_debug_installed, debug_qf_has_symbols)
10369 (debug_qf_find_last_source_symtab)
10370 (debug_qf_forget_cached_source_info)
10371 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10372 (debug_qf_print_stats, debug_qf_dump)
10373 (debug_qf_expand_symtabs_for_function)
10374 (debug_qf_expand_all_symtabs)
10375 (debug_qf_expand_symtabs_with_fullname)
10376 (debug_qf_map_matching_symbols)
10377 (debug_qf_expand_symtabs_matching)
10378 (debug_qf_find_pc_sect_compunit_symtab)
10379 (debug_qf_map_symbol_filenames)
10380 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10381 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10382 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10383 (debug_sym_read_linetable, debug_sym_relocate): Update.
10384 (symfile_debug_free_objfile): Remove.
10385 (install_symfile_debug_logging, _initialize_symfile_debug):
10386 Update.
10387
103882019-05-08 Tom Tromey <tom@tromey.com>
10389
10390 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10391 allocate_on_obstack.
10392 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10393 (get_dwarf2_per_objfile): Update.
10394 (set_dwarf2_per_objfile): Remove.
10395 (dwarf2_has_info, dwarf2_get_section_info): Update.
10396 (dwarf2_free_objfile): Remove.
10397 (_initialize_dwarf2_read): Update.
10398
103992019-05-08 Tom Tromey <tom@tromey.com>
10400
10401 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10402 initializers.
10403 <unsupported_script_warning_printed,
10404 script_not_found_warning_printed>: Now bool.
10405 (auto_load_pspace_data): Change type.
10406 (~auto_load_pspace_info): Rename from
10407 auto_load_pspace_data_cleanup.
10408 (get_auto_load_pspace_data, init_loaded_scripts_info)
10409 (clear_section_scripts, maybe_print_unsupported_script_warning)
10410 (maybe_print_script_not_found_warning, _initialize_auto_load):
10411 Update.
10412
104132019-05-08 Tom Tromey <tom@tromey.com>
10414
10415 * objfiles.c (objfile_pspace_info): Add destructor and
10416 initializers.
10417 (objfiles_pspace_data): Change type.
10418 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10419 (get_objfile_pspace_data): Update.
10420 (objfiles_bfd_data): Change type.
10421 (get_objfile_bfd_data): Update.
10422 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10423
104242019-05-08 Tom Tromey <tom@tromey.com>
10425
10426 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10427 Change type.
10428 (get_catch_syscall_inferior_data): Update.
10429 (catch_syscall_inferior_data_cleanup): Remove.
10430 (_initialize_break_catch_syscall): Update.
10431
104322019-05-08 Tom Tromey <tom@tromey.com>
10433
10434 * inflow.c (struct terminal_info): Add destructor and
10435 initializers.
10436 (inflow_inferior_data): Change type.
10437 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10438 (get_inflow_inferior_data, inflow_inferior_exit)
10439 (swap_terminal_info, _initialize_inflow): Update.
10440
104412019-05-08 Tom Tromey <tom@tromey.com>
10442
10443 * target-dcache.c (target_dcache_cleanup): Remove.
10444 (target_dcache_aspace_key): Change type.
10445 (target_dcache_init_p, target_dcache_invalidate)
10446 (target_dcache_get, target_dcache_get_or_init)
10447 (_initialize_target_dcache): Update.
10448 * dcache.h (struct dcache_deleter): New.
10449
104502019-05-08 Tom Tromey <tom@tromey.com>
10451
10452 * symtab.c (struct symbol_cache): Add destructor and
10453 initializers.
10454 (symbol_cache_key): Move. Change type.
10455 (make_symbol_cache, free_symbol_cache): Remove.
10456 (get_symbol_cache): Update.
10457 (symbol_cache_cleanup): Remove.
10458 (ALL_PSPACES, symbol_cache_flush)
10459 (maintenance_print_symbol_cache)
10460 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10461 Update.
10462
104632019-05-08 Tom Tromey <tom@tromey.com>
10464
10465 * symtab.c (struct main_info): Add destructor and initializers.
10466 (main_progspace_key): Move. Change type.
10467 (get_main_info): Update.
10468 (main_info_cleanup): Remove.
10469 (_initialize_symtab): Update.
10470
104712019-05-08 Tom Tromey <tom@tromey.com>
10472
10473 * registry.h (DECLARE_REGISTRY): Define the _key class.
10474
104752019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10476
10477 * NEWS: Merge two 'New commands' sections.
10478
104792019-05-08 Joel Brobecker <brobecker@adacore.com>
10480
10481 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10482 parameter and use Ada language definition instead.
10483 (ada_val_print_ptr): Remove unused language parameter.
10484 (ada_val_print_num): Remove language parameter and use Ada language
10485 definition instead.
10486 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10487 parameter.
10488 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10489 parameter and use Ada language definition instead.
10490 (ada_val_print_1): Update all ada_val_print_xxx calls.
10491 Remove language parameter.
10492 (ada_val_print): Update ada_val_print_1 call.
10493
104942019-05-08 Tom Tromey <tromey@adacore.com>
10495
10496 * remote.c (remote_hw_watchpoint_limit)
10497 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10498 Now static.
10499
105002019-05-08 Tom Tromey <tromey@adacore.com>
10501
10502 * maint.c (_initialize_maint_cmds): Move initialization code to
10503 remote.c.
10504 (watchdog, show_watchdog): Move to remote.c.
10505 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10506 "watchdog" static.
10507 (_initialize_remote): Move initialization code from maint.c.
10508 * defs.h (watchdog): Don't declare.
10509
105102019-05-08 Tom Tromey <tromey@adacore.com>
10511
10512 * tui/tui-interp.c: Include main.h.
10513 * interps.c: Include main.h.
10514 * main.h (interpreter_p): Declare.
10515 * defs.h (interpreter_p): Don't declare.
10516
105172019-05-08 Tom Tromey <tromey@adacore.com>
10518
10519 * dwarf2loc.c: Include dwarf2read.h.
10520 * defs.h (read_unsigned_leb128): Don't declare.
10521 * dwarf2read.h (read_unsigned_leb128): Declare.
10522
105232019-05-08 Tom Tromey <tromey@adacore.com>
10524
10525 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10526 method.
10527
105282019-05-08 Tom Tromey <tromey@adacore.com>
10529
10530 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10531 when no wrap column is set.
10532
105332019-05-08 Tom Tromey <tromey@adacore.com>
10534
10535 * c-lang.c (c_get_string): Handle non-C-style arrays.
10536
105372019-05-08 Tom Tromey <tromey@adacore.com>
10538
10539 * typeprint.c (print_offset_data::update): Print the bit offset,
10540 not the number of bits remaining.
10541
105422019-05-08 Tom Tromey <tromey@adacore.com>
10543
10544 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10545 padding at end of comment.
10546
105472019-05-08 Tom Tromey <tromey@adacore.com>
10548
10549 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10550 Compare main types.
10551
105522019-05-06 Tom Tromey <tom@tromey.com>
10553
10554 * common/scoped_mmap.c: Include common-defs.h.
10555 * common/scoped_mmap.h: Don't include config.h.
10556
105572019-05-04 Tom Tromey <tom@tromey.com>
10558
10559 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10560 (struct aarch64_call_info): Add initializers.
10561 <si>: Now a std::vector.
10562 (pass_on_stack, aarch64_push_dummy_call): Update.
10563
105642019-05-04 Simon Marchi <simon.marchi@efficios.com>
10565 Tom Tromey <tom@tromey.com>
10566
10567 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10568 (ppc_threads): Now a std::vector. Now static.
10569 (hwdebug_find_thread_points_by_tid)
10570 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10571 Update.
10572
105732019-05-04 Tom Tromey <tom@tromey.com>
10574
10575 * arc-tdep.c (arc_tdesc_init): Return bool.
10576
105772019-05-04 Tom Tromey <tom@tromey.com>
10578
10579 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10580 Use gdb_assert_not_reached.
10581
105822019-05-04 Tom Tromey <tom@tromey.com>
10583
10584 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10585 "false".
10586
105872019-05-04 Tom Tromey <tom@tromey.com>
10588
10589 * arc-tdep.c (arc_tdesc_init): Use bool.
10590
105912019-05-04 Tom Tromey <tom@tromey.com>
10592
10593 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10594
105952019-05-04 Tom Tromey <tom@tromey.com>
10596
10597 * cli/cli-cmds.c (valid_command_p): Return bool.
10598
105992019-05-04 Tom Tromey <tom@tromey.com>
10600
10601 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10602 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10603
106042019-05-04 Raul Tambre <raul@tambre.ee>
10605
10606 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10607 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10608 operator for comparison.
10609
106102019-05-04 Tom Tromey <tom@tromey.com>
10611
10612 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10613 (lookup_partial_symbol, print_partial_symbols)
10614 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10615 (psymbol_compare): Update.
10616 (add_psymbol_to_bcache): Clear the entire psymbol.
10617 (maintenance_check_psymtabs): Update.
10618 * psympriv.h (struct partial_symbol): Don't derive from
10619 general_symbol_info.
10620 <obj_section, unrelocated_address, address,
10621 set_unrelocated_address>: Update.
10622 <ginfo>: New member.
10623 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10624 (debug_names::write_psymbols): Update.
10625
106262019-05-04 Tom de Vries <tdevries@suse.de>
10627
10628 * contrib/cc-with-tweaks.sh: Support -n arg.
10629
106302019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10631
10632 * corelow.c (core_target::detach): Ensure frame cache and
10633 register caches are cleared.
10634 inferior.c (exit_inferior_1): Likewise.
10635
106362019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10637 Tom Tromey <tom@tromey.com>
10638
10639 * dictionary.c (collate_pending_symbols_by_language): Remove
10640 "struct" from foreach.
10641 * symtab.c (lookup_global_symbol_from_objfile)
10642 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10643 foreach.
10644 * ser-tcp.c (net_open): Remove "struct" from foreach.
10645 * objfiles.c (objfile_relocate, objfile_rebase)
10646 (objfile_has_symbols): Remove "struct" from foreach.
10647 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10648 from foreach.
10649 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10650 foreach.
10651 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10652 "struct" from foreach.
10653 * ada-lang.c (create_excep_cond_exprs)
10654 (ada_exception_catchpoint_cond_string): Remove "struct" from
10655 foreach.
10656
106572019-05-03 Tom Tromey <tromey@adacore.com>
10658
10659 * ada-exp.y (convert_char_literal): Check suffix of each
10660 enumerator.
10661
106622019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10663
10664 PR ada/21406:
10665 * ada-exp.y (yywrap): Don't define.
10666 * ada-lex.l (%option): Add noyywrap
10667 (yywrap): Remove.
10668
106692019-05-03 Eli Zaretskii <eliz@gnu.org>
10670
10671 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10672 _WIN32_WINNT to the XP level, unless already defined to a higher
10673 level.
10674
10675 * unittests/parse-connection-spec-selftests.c:
10676 * ser-tcp.c:
10677 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10678 override.
10679
10680 * symfile.c (find_separate_debug_file): Remove colon from the
10681 drive spec of DOS/Windows file names of the target, so that the
10682 file name produced from DEBUGDIR and the target's directory will
10683 be valid on DOS/Windows systems.
10684
106852019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10686
10687 * rust-lang.c (val_print_struct): Handle printing structures
10688 containing strings.
10689
106902019-05-02 Tom Tromey <tromey@adacore.com>
10691
10692 * valarith.c (_initialize_valarith): Remove.
10693
106942019-05-01 Tom Tromey <tromey@adacore.com>
10695
10696 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10697 bitfields.
10698
106992019-05-01 Tom Tromey <tromey@adacore.com>
10700
10701 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10702 for big-endian copies.
10703
107042019-04-30 Ali Tamur <tamur@google.com>
10705 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10706 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10707 (read_3_bytes): New function.
10708
107092019-04-30 Joel Brobecker <brobecker@adacore.com>
10710
10711 * windows-nat.c (main_thread_id): Delete.
10712 (handle_output_debug_string): Replace main_thread_id by
10713 current_event.dwThreadId.
10714 (fake_create_process): Likewise.
10715 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10716 Do not set main_thread_id.
10717 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10718 current_event.dwThreadId.
10719 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10720
107212019-04-30 Joel Brobecker <brobecker@adacore.com>
10722
10723 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10724 Use current_event.dwThreadId instead of main_thread_id.
10725
107262019-04-30 Tom Tromey <tromey@adacore.com>
10727
10728 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10729 (create_excep_cond_exprs): Iterate over program spaces.
10730 (ada_exception_catchpoint_cond_string): Examine all minimal
10731 symbols for exception types.
10732
107332019-04-30 Tom Tromey <tromey@adacore.com>
10734
10735 PR c++/24470:
10736 * dwarf2read.c (process_structure_scope): Handle case where type
10737 has template parameters but no symbol was created.
10738
107392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10740 Chris January <chris.january@arm.com>
10741
10742 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10743 qualifier.
10744 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10745
107462019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10747
10748 * f-typeprint.c (f_print_type): Update rules for printing
10749 whitespace.
10750 (f_type_print_varspec_suffix): Likewise.
10751
107522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10753 Chris January <chris.january@arm.com>
10754
10755 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10756 function arguments.
10757
107582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10759
10760 * f-lang.c (build_fortran_types): Change name of void type to
10761 lower case.
10762 * f-typeprint.c (f_type_print_base): Print the name of the void
10763 type, rather than a fixed string.
10764 * f-valprint.c (f_decorations): Use lower case void string.
10765
107662019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10767 Chris January <chris.january@arm.com>
10768
10769 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10770 types for Fortran.
10771
107722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10773 Chris January <chris.january@arm.com>
10774 David Lecomber <david.lecomber@arm.com>
10775
10776 * f-exp.y (BINOP_INTRINSIC): New token.
10777 (exp): New parser rule handling BINOP_INTRINSIC.
10778 (f77_keywords): Add new builtin procedures.
10779 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10780 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10781 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10782 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10783 (print_unop_subexp_f): New function.
10784 (print_binop_subexp_f): New function.
10785 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10786 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10787 (dump_subexp_body_f): Likewise.
10788 (operator_check_f): Likewise.
10789 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10790 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10791
107922019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10793
10794 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10795 UNOP_KIND.
10796 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10797 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10798 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10799 (operator_length_f): New fuction.
10800 (print_subexp_f): New function.
10801 (op_name_f): New function.
10802 (dump_subexp_body_f): New function.
10803 (operator_check_f): New function.
10804 (exp_descriptor_f): Replace standard expression handling functions
10805 with new functions.
10806 * gdb/fortran-operator.def: New file.
10807 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10808 * gdb/std-operator.def: Remove UNOP_KIND.
10809
108102019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10811
10812 * std-operator.def: Remove unbalanced, stray double quote
10813 character.
10814
108152019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10816 Chris January <chris.january@arm.com>
10817 Daniel Everett <daniel.everett@arm.com>
10818 Nick Forrington <nick.forrington@arm.com>
10819 Richard Bunt <richard.bunt@arm.com>
10820
10821 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10822 of depth when printing anonymous structs or unions.
10823 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10824 Don't print either the top-level value, or the children if the
10825 max-depth is exceeded.
10826 (ppscm_print_children): When printing the key of a map, allow one
10827 extra level of depth.
10828 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10829 print either the top-level value, or the children if the max-depth
10830 is exceeded.
10831 (print_children): When printing the key of a map, allow one extra
10832 level of depth.
10833 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10834 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10835 (user_print_options): Initialise max_depth field.
10836 (val_print_scalar_or_string_type_p): New function.
10837 (val_print): Check to see if the max depth has been reached.
10838 (val_print_check_max_depth): Define new function.
10839 (show_print_max_depth): New function.
10840 (_initialize_valprint): Add 'print max-depth' option.
10841 * valprint.h (struct value_print_options) <max_depth>: New field.
10842 (val_print_check_max_depth): Declare new function.
10843 * NEWS: Document new feature.
10844
108452019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10846
10847 * ada-lang.c (ada_language_defn): Initialise new field.
10848 * c-lang.c (c_is_string_type_p): New function.
10849 (c_language_defn): Initialise new field.
10850 (cplus_language_defn): Initialise new field.
10851 (asm_language_defn): Initialise new field.
10852 (minimal_language_defn): Initialise new field.
10853 * c-lang.h (c_is_string_type_p): Declare new function.
10854 * d-lang.c (d_language_defn): Initialise new field.
10855 * f-lang.c (f_is_string_type_p): New function.
10856 (f_language_defn): Initialise new field.
10857 * go-lang.c (go_is_string_type_p): New function.
10858 (go_language_defn): Initialise new field.
10859 * language.c (default_is_string_type_p): New function.
10860 (unknown_language_defn): Initialise new field.
10861 (auto_language_defn): Initialise new field.
10862 * language.h (struct language_defn) <la_is_string_type_p>: New
10863 member variable.
10864 (default_is_string_type_p): Declare new function.
10865 * m2-lang.c (m2_language_defn): Initialise new field.
10866 * objc-lang.c (objc_language_defn): Initialise new field.
10867 * opencl-lang.c (opencl_language_defn): Initialise new field.
10868 * p-lang.c (pascal_is_string_type_p): New function.
10869 (pascal_language_defn): Initialise new field.
10870 * rust-lang.c (rust_is_string_type_p): New function.
10871 (rust_language_defn): Initialise new field.
10872
108732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10874
10875 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10876 New field.
10877 * ada-lang.c (ada_language_defn): Initialise new field.
10878 * c-lang.c (c_language_defn): Likewise.
10879 (cplus_language_defn): Likewise.
10880 (asm_language_defn): Likewise.
10881 (minimal_language_defn): Likewise.
10882 * d-lang.c (d_language_defn): Likewise.
10883 * f-lang.c (f_language_defn): Likewise.
10884 * go-lang.c (go_language_defn): Likewise.
10885 * language.c (unknown_language_defn): Likewise.
10886 (auto_language_defn): Likewise.
10887 * m2-lang.c (m2_language_defn): Likewise.
10888 * objc-lang.c (objc_language_defn): Likewise.
10889 * opencl-lang.c (opencl_language_defn): Likewise.
10890 * p-lang.c (pascal_language_defn): Likewise.
10891 * rust-lang.c (rust_language_defn): Likewise.
10892
108932019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10894
10895 * ada-lang.c (ada_is_character_type): Change return type to bool.
10896 (ada_is_string_type): Likewise.
10897 * ada-lang.h (ada_is_character_type): Update declaration
10898 (ada_is_string_type): Likewise.
10899
109002019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10901
10902 Support style in 'frame|thread apply'
10903
10904 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10905 * record.c (record_start, record_stop): Update callers of
10906 execute_command_to_string with false.
10907 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10908 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10909 methods.
10910 (class string_file): New constructor with term_out parameter.
10911 Override methods term_out and can_emit_style_escape. New member
10912 term_out.
10913 (class stdio_file): Override can_emit_style_escape.
10914 (class tee_file): Override term_out and can_emit_style_escape.
10915 * utils.h (can_emit_style_escape): Remove.
10916 * utils.c (can_emit_style_escape): Likewise.
10917 Update all callers of can_emit_style_escape (SOMESTREAM) to
10918 SOMESTREAM->can_emit_style_escape.
10919 * source-cache.c (source_cache::get_source_lines): Likewise.
10920 * stack.c (frame_apply_command_count): Call execute_command_to_string
10921 passing the term_out characteristic of the current gdb_stdout.
10922 * thread.c (thr_try_catch_cmd): Likewise.
10923 * top.c (execute_command_to_string): pass term_out parameter
10924 to construct the string_file for the command output.
10925 * ui-file.c (term_cli_styling): New function (most code moved
10926 from utils.c can_emit_style_escape).
10927 (string_file::string_file, string_file::can_emit_style_escape,
10928 stdio_file::can_emit_style_escape, tee_file::term_out,
10929 tee_file::can_emit_style_escape): New functions.
10930
109312019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10932
10933 * NEWS: Mention the new set|show may-call-functions.
10934 * infcall.c (may_call_functions_p): New variable.
10935 (show_may_call_functions_p): New function.
10936 (call_function_by_hand_dummy): Throws an error if not
10937 may-call-functions.
10938 (_initialize_infcall): Call add_setshow_boolean_cmd for
10939 may-call-functions.
10940
109412019-04-25 Keith Seitz <keiths@redhat.com>
10942
10943 PR c++/24367
10944 * cp-support.c (inspect_type): Don't attempt substitutions
10945 of symbol with the same name.
10946
109472019-04-25 Tom Tromey <tromey@adacore.com>
10948
10949 PR gdb/24475:
10950 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10951 static.
10952
109532019-04-25 Tom Tromey <tromey@adacore.com>
10954
10955 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10956 rvalue reference.
10957 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10958 (gdb_xml_parser::parse): Use std::move.
10959 * python/python-internal.h (gdbpy_convert_exception): Take a const
10960 reference.
10961 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10962 std::move.
10963 * python/py-utils.c (gdbpy_convert_exception): Take a const
10964 reference.
10965 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10966 Use std::move.
10967 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10968 Use std::move.
10969 * mi/mi-main.c (mi_print_exception): Take a const reference.
10970 * main.c (handle_command_errors): Take a const reference.
10971 * linespec.c (parse_linespec): Use std::move.
10972 * infcall.c (run_inferior_call): Use std::move.
10973 (call_function_by_hand_dummy): Use std::move.
10974 * exec.c (try_open_exec_file): Use std::move.
10975 * exceptions.h (exception_print, exception_fprintf)
10976 (exception_print_same): Update.
10977 * exceptions.c (print_exception, exception_print)
10978 (exception_fprintf, exception_print_same): Change parameters to
10979 const reference.
10980 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10981 * common/new-op.c: Use std::move.
10982 * common/common-exceptions.h (struct gdb_exception): Add move
10983 constructor.
10984 (struct gdb_exception_error, struct gdb_exception_quit, struct
10985 gdb_quit_bad_alloc): Change constructor to move constructor.
10986 (throw_exception): Change parameter to rvalue reference.
10987 * common/common-exceptions.c (throw_exception): Take rvalue
10988 reference.
10989 * cli/cli-interp.c (safe_execute_command): Use std::move.
10990 * breakpoint.c (insert_bp_location, location_to_sals): Use
10991 std::move.
10992
109932019-04-25 Tom Tromey <tromey@adacore.com>
10994
10995 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10996 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10997 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10998 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10999 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11000 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11001 guile/scm-value.c: Use unpack.
11002 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11003 gdbscm_gdb_exception.
11004 (gdbscm_throw_gdb_exception): Likewise.
11005 (struct gdbscm_gdb_exception): New.
11006 (unpack): New function.
11007 (gdbscm_wrap): Use unpack.
11008
110092019-04-25 Tom Tromey <tromey@adacore.com>
11010
11011 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11012 (gdb_rl_callback_handler): Use std::move.
11013 * common/common-exceptions.h (struct gdb_exception): Add move
11014 assignment operator.
11015 (throw_exception_sjlj): Change "exception" to const reference.
11016 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11017 (throw_exception_sjlj): Change "exception" to const reference.
11018
110192019-04-25 Tom Tromey <tromey@adacore.com>
11020
11021 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11022 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11023 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11024 Update.
11025 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11026 Update.
11027 * mi/mi-interp.c (mi_interp::exec): Update.
11028 * linespec.c (parse_linespec): Update.
11029 * infcall.c (run_inferior_call): Update.
11030 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11031 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11032 (gdbscm_lookup_global_symbol): Update.
11033 * guile/scm-param.c (gdbscm_parameter_value): Update.
11034 * guile/scm-frame.c (gdbscm_frame_read_register)
11035 (gdbscm_frame_read_var): Update.
11036 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11037 * exec.c (try_open_exec_file): Update.
11038 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11039 (gdb_rl_callback_handler): Update.
11040 * common/common-exceptions.h (exception_none): Don't declare.
11041 * common/common-exceptions.c (exception_none): Don't define.
11042 (struct catcher) <exception>: Update.
11043 * cli/cli-interp.c (safe_execute_command): Update.
11044 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11045
110462019-04-25 Ali Tamur <tamur@google.com>
11047
11048 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11049 (read_attribute_value): Likewise.
11050 (dwarf2_read_addr_index): Update comment.
11051 (read_str_index): Add DW_FORM_strx.
11052 (dwarf2_string_attr): Likewise.
11053 (dwarf2_const_value_attr): Likewise.
11054 (dump_die_shallow): Likewise.
11055 (dwarf2_fetch_constant_bytes): Likewise.
11056 (skip_form_bytes): Likewise.
11057 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11058
110592019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11060
11061 PR corefiles/11608
11062 PR corefiles/18187
11063 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11064 OFFSET. Verify if current mapping contains an ELF header.
11065 (linux_find_memory_regions_full): Adjust call to
11066 dump_mapping_p.
11067
110682019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11069 Kang Li <kanglictf@gmail.com>
11070
11071 PR gdb/21600
11072
11073 * dwarf2-frame.c (read_initial_length): Be consistent about using
11074 unsigned representation of length.
11075 (decode_frame_entry_1): Likewise. Check for wraparound of
11076 end pointer as well as buffer overflow.
11077
110782019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11079
11080 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11081 "vq".
11082
110832019-04-24 Tom Tromey <tromey@adacore.com>
11084
11085 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11086
110872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11088
11089 * s12z-tdep.c (s12z_unwind_pc): Delete.
11090 (s12z_unwind_sp): Delete.
11091 (s12z_gdbarch_init): Don't register deleted functions with
11092 gdbarch.
11093
110942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11095
11096 * rl78-tdep.c (rl78_unwind_sp): Delete.
11097 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11098
110992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11100
11101 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11102 (xstormy16_unwind_pc): Delete.
11103 (xstormy16_dummy_id): Delete.
11104 (xstormy16_gdbarch_init): Don't register deleted functions with
11105 gdbarch.
11106
111072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11108
11109 * vax-tdep.c (vax_unwind_pc): Delete.
11110 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11111
111122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11113
11114 * v850-tdep.c (v850_unwind_sp): Delete.
11115 (v850_unwind_pc): Delete.
11116 (v850_dummy_id): Delete.
11117 (v850_gdbarch_init): Don't register deleted functions with
11118 gdbarch.
11119
111202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11121
11122 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11123 (tilegx_unwind_pc): Delete.
11124 (tilegx_unwind_dummy_id): Delete.
11125 (tilegx_gdbarch_init): Don't register deleted functions with
11126 gdbarch.
11127
111282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11129
11130 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11131 (tic6x_dummy_id): Delete.
11132 (tic6x_gdbarch_init): Don't register deleted functions with
11133 gdbarch.
11134
111352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11136
11137 * sparc-tdep.c (sparc_unwind_pc): Delete.
11138 (sparc32_gdbarch_init): Don't register deleted function with
11139 gdbarch.
11140
111412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11142
11143 * sh-tdep.c (sh_unwind_sp): Delete.
11144 (sh_unwind_pc): Delete.
11145 (sh_dummy_id): Delete.
11146 (sh_gdbarch_init): Don't register deleted functions with
11147 gdbarch.
11148
111492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11150
11151 * score-tdep.c (score_unwind_sp): Delete.
11152 (score_unwind_pc): Delete.
11153 (score_dummy_id): Delete.
11154 (score_gdbarch_init): Don't register deleted functions with
11155 gdbarch.
11156
111572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11158
11159 * rx-tdep.c (rx_unwind_pc): Delete.
11160 (rx_unwind_sp): Delete.
11161 (rx_dummy_id): Delete.
11162 (rx_gdbarch_init): Don't register deleted functions with
11163 gdbarch. Update comment.
11164
111652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11166
11167 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11168 (rs6000_dummy_id): Delete.
11169 (rs6000_gdbarch_init): Don't register deleted functions with
11170 gdbarch.
11171
111722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11173
11174 * or1k-tdep.c (or1k_dummy_id): Delete.
11175 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11176
111772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11178
11179 * nios2-tdep.c (nios2_dummy_id): Delete.
11180 (nios2_unwind_sp): Delete.
11181 (nios2_gdbarch_init): Don't register deleted functions with
11182 gdbarch.
11183
111842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11185
11186 * nds32-tdep.c (nds32_dummy_id): Delete.
11187 (nds32_unwind_pc): Delete.
11188 (nds32_unwind_sp): Delete.
11189 (nds32_gdbarch_init): Don't register deleted functions with
11190 gdbarch.
11191
111922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11193
11194 * msp430-tdep.c (msp430_unwind_pc): Delete.
11195 (msp430_unwind_sp): Delete.
11196 (msp430_dummy_id): Delete.
11197 (msp430_gdbarch_init): Don't register deleted functions with
11198 gdbarch.
11199
112002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11201
11202 * moxie-tdep.c (moxie_unwind_sp): Delete.
11203 (moxie_unwind_pc): Delete.
11204 (moxie_dummy_id): Delete.
11205 (moxie_gdbarch_init): Don't register deleted functions with
11206 gdbarch.
11207
112082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11209
11210 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11211 (mn10300_unwind_pc): Delete.
11212 (mn10300_unwind_sp): Delete.
11213 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11214 mn10300_unwind_sp.
11215 (mn10300_frame_unwind_init): Don't register deleted functions with
11216 gdbarch.
11217
112182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11219
11220 * mep-tdep.c (mep_unwind_pc): Delete.
11221 (mep_unwind_sp): Delete.
11222 (mep_dummy_id): Delete.
11223 (mep_gdbarch_init): Don't register deleted functions with
11224 gdbarch.
11225
112262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11227
11228 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11229 (m68hc11_unwind_sp): Delete.
11230 (m68hc11_gdbarch_init): Don't register deleted functions with
11231 gdbarch.
11232
112332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11234
11235 * m32r-tdep.c (m32r_unwind_sp): Delete.
11236 (m32r_unwind_pc): Delete.
11237 (m32r_dummy_id): Delete.
11238 (m32r_gdbarch_init): Don't register deleted functions with
11239 gdbarch.
11240
112412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11242
11243 * m32c-tdep.c (m32c_unwind_pc): Delete.
11244 (m32c_unwind_sp): Delete.
11245 (m32c_dummy_id): Delete.
11246 (m32c_gdbarch_init): Don't register deleted functions with
11247 gdbarch.
11248
112492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11250
11251 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11252 (lm32_unwind_pc): Delete.
11253 (lm32_dummy_id): Delete.
11254 (lm32_gdbarch_init): Don't register deleted functions with
11255 gdbarch.
11256
112572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11258
11259 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11260 (iq2000_unwind_pc): Delete.
11261 (iq2000_dummy_id): Delete.
11262 (iq2000_gdbarch_init): Don't register deleted functions with
11263 gdbarch.
11264
112652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11266
11267 * nds32-tdep.c (nds32_type_align): Delete.
11268 (nds32_push_dummy_call): Use type_align instead.
11269
112702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11271
11272 * arm-tdep.c (arm_type_align): Only handle vector override case.
11273 (arm_push_dummy_call): Use type_align.
11274 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11275
112762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11277
11278 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11279 case.
11280 (pass_on_stack): Use type_align.
11281 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11282 function.
11283
112842019-04-23 Tom Tromey <tromey@adacore.com>
11285
11286 * dwarf2read.c (line_header::file_name_at): Remove unused
11287 overload.
11288
112892019-04-23 Tom de Vries <tdevries@suse.de>
11290
11291 PR gdb/24438
11292 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11293 invocation.
11294
11295
112962019-03-27 Ali Tamur <tamur@google.com>
11297
11298 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11299 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11300 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11301 (dwarf_expr_context::get_addr_index): Likewise
11302 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11303 (symbol_needs_eval_context::get_addr_index): Likewise
11304 (disassemble_dwarf_expression): Add DW_OP_addrx
11305 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11306 (read_cutu_die_from_dwo): Update comment
11307 (skip_one_die): Add DW_FORM_addrx
11308 (read_attribute_value): Likewise
11309 (var_decode_location): Add DW_OP_addrx
11310 (dwarf2_const_value_attr): Add DW_FORM_addrx
11311 (dump_die_shallow): Likewise
11312 (dwarf2_fetch_constant_bytes): Likewise
11313 (decode_locdesc): Add DW_OP_addrx
11314 (skip_form_bytes): Add DW_FORM_addrx
11315
113162019-04-22 Ali Tamur <tamur@google.com>
11317
11318 * MAINTAINERS (Write After Approval): Add self.
11319
113202019-04-22 Simon Marchi <simon.marchi@efficios.com>
11321
11322 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11323 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11324 (open_symbol_file_object): Likewise.
11325 (svr4_default_sos): Add info parameter.
11326 (svr4_read_so_list): Likewise.
11327 (svr4_current_sos_direct): Adjust functions calls to pass down
11328 info.
11329 (svr4_current_sos_1): Add info parameter.
11330 (svr4_current_sos): Call get_svr4_info, pass info down to
11331 svr4_current_sos_1.
11332 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11333 get_svr4_info.
11334 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11335 get_svr4_info.
11336 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11337 to get_svr4_info.
11338 (probes_table_remove_objfile_probes): Likewise.
11339 (register_solib_event_probe): Add info parameter.
11340 (solist_update_incremental): Pass info parameter down to
11341 svr4_read_so_list.
11342 (disable_probes_interface): Add info parameter.
11343 (svr4_handle_solib_event): Pass current_program_space to
11344 get_svr4_info. Adjust disable_probes_interface cleanup.
11345 (svr4_create_probe_breakpoints): Add info parameter, pass it
11346 down to register_solib_event_probe.
11347 (svr4_create_solib_event_breakpoints): Add info parameter,
11348 pass it down to svr4_create_probe_breakpoints.
11349 (enable_break): Pass info down to
11350 svr4_create_solib_event_breakpoints.
11351 (svr4_solib_create_inferior_hook): Pass current_program_space to
11352 get_svr4_info.
11353 (svr4_clear_solib): Likewise.
11354
113552019-04-22 Pedro Alves <palves@redhat.com>
11356
11357 * solib-svr4.c (svr4_free_objfile_observer): New.
11358 (probe_and_action::objfile): New field.
11359 (probes_table_htab_remove_objfile_probes)
11360 (probes_table_remove_objfile_probes): New functions.
11361 (register_solib_event_probe): Add 'objfile' parameter. Store it
11362 in the new probe_and_action. Don't store the probe in 'lookup'.
11363 (svr4_create_probe_breakpoints): Pass objfile to
11364 register_solib_event_probe.
11365 (_initialize_svr4_solib): Register a free_objfile observer.
11366
113672019-04-19 Tom Tromey <tom@tromey.com>
11368
11369 * common/queue.h: Remove.
11370
113712019-04-19 Tom Tromey <tom@tromey.com>
11372
11373 * event-loop.c: Don't include "common/queue.h".
11374
113752019-04-19 Tom Tromey <tom@tromey.com>
11376
11377 * remote.c (remote_target): Use delete.
11378 * remote-notif.h: Include <list>, not "common/queue.h".
11379 (notif_client_p): Remove typedef.
11380 (remote_notif_state): Add constructor, destructor, initializer.
11381 <notif_queue>: Now a std::list.
11382 (remote_notif_state_xfree): Don't declare.
11383 * remote-notif.c (remote_notif_process, handle_notification)
11384 (remote_notif_state_allocate): Update.
11385 (~remote_notif_state): Rename from remote_notif_state_xfree.
11386
113872019-04-19 Tom Tromey <tom@tromey.com>
11388
11389 * symfile.c (reread_symbols): Update.
11390 * objfiles.c (objfile_register_static_link)
11391 (objfile_lookup_static_link): Update
11392 (~objfile) Don't delete static_links.
11393 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11394
113952019-04-19 Tom Tromey <tom@tromey.com>
11396
11397 * type-stack.h (struct type_stack) <insert>: Constify string.
11398 * type-stack.c (type_stack::insert): Constify string.
11399 * gdbtypes.h (lookup_template_type): Update.
11400 (address_space_name_to_int): Update.
11401 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11402 const.
11403 (lookup_template_type): Make name const.
11404 * c-exp.y: Update rules.
11405 (lex_one_token, classify_name, classify_inner_name)
11406 (c_print_token): Update.
11407 * p-exp.y: Update rules.
11408 (yylex): Update.
11409 * f-exp.y: Update rules.
11410 (yylex): Update.
11411 * d-exp.y: Update rules.
11412 (lex_one_token, classify_name, classify_inner_name): Update.
11413 * parse.c (write_dollar_variable, copy_name): Return std::string.
11414 * parser-defs.h (copy_name): Change return type.
11415 * m2-exp.y: Update rules.
11416 (yylex): Update.
11417 * go-exp.y (lex_one_token): Update.
11418 Update rules.
11419 (classify_unsafe_function, classify_packaged_name)
11420 (classify_name, yylex): Update.
11421
114222019-04-19 Sergei Trofimovich <siarheit@google.com>
11423
11424 * configure.ac: add --enable-source-highlight switch.
11425 * configure: Regenerate.
11426 * top.c (print_gdb_version): plumb --enable-source-highlight
11427 status to "show configuration".
11428
114292019-04-19 Tom Tromey <tromey@adacore.com>
11430
11431 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11432 Check ADA_TYPE_P.
11433 (empty_record, ada_template_to_fixed_record_type_1)
11434 (template_to_static_fixed_type)
11435 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11436 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11437 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11438 macros.
11439
114402019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11441
11442 PR symtab/24423:
11443 * source.c (print_source_lines_base): Advance "iter" when a
11444 control character is seen.
11445
114462019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11447
11448 * inferior.h (struct infcall_suspend_state_deleter):
11449 Catch exception in destructor to avoid crash.
11450
114512019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11452
11453 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11454 close to the add_com "shell".
11455
114562019-04-18 Tom Tromey <tromey@adacore.com>
11457
11458 * process-stratum-target.h (class process_stratum_target)
11459 <stratum>: Add "final".
11460
114612019-04-17 Tom Tromey <tromey@adacore.com>
11462
11463 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11464 against nullptr before use.
11465
114662019-04-17 Alan Hayward <alan.hayward@arm.com>
11467
11468 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11469
114702019-04-17 Jim Wilson <jimw@sifive.com>
11471 Andrew Burgess <andrew.burgess@embecosm.com>
11472
11473 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11474 code read might fail, assume 4-byte breakpoint in that case.
11475
114762019-04-15 Leszek Swirski <leszeks@google.com>
11477
11478 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11479 rather than a hand-rolled POD check when checking for forced MEMORY
11480 classification.
11481
114822019-04-15 Alan Hayward <alan.hayward@arm.com>
11483
11484 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11485 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11486 function.
11487 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11488 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11489 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11490 declaration.
11491
114922019-04-15 Alan Hayward <alan.hayward@arm.com>
11493
11494 * aarch64-linux-nat.c
11495 (aarch64_linux_nat_target::thread_architecture): Add override.
11496 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11497 each VQ.
11498
114992019-04-15 Alan Hayward <alan.hayward@arm.com>
11500
11501 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11502
115032019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11504
11505 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11506 target types of size 96-bits, add some additional comments, and
11507 check that the builtin type we found was the correct size.
11508
115092019-04-12 Eli Zaretskii <eliz@gnu.org>
11510
11511 * utils.c (prompt_for_continue): Don't restore the styling at the
11512 end, as applied_style has the wrong value. This fixes styling in
11513 long lists of file names that are interrupted by the "Continue?"
11514 prompt.
11515
115162019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11517
11518 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11519 * c-lang.c (c_language_defn): Likewise.
11520 (cplus_language_defn): Likewise.
11521 (asm_language_defn): Likewise.
11522 (minimal_language_defn): Likewise.
11523 * d-lang.c (d_language_defn): Likewise.
11524 * f-lang.c (f_language_defn): Likewise.
11525 * go-lang.c (go_language_defn): Likewise.
11526 * language.c (unknown_language_defn): Likewise.
11527 (auto_language_defn): Likewise.
11528 * language.h (struct language_defn): Remove la_magic field.
11529 (LANG_MAGIC): Delete.
11530 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11531 * objc-lang.c (objc_language_defn): Likewise.
11532 * opencl-lang.c (opencl_language_defn): Likewise.
11533 * p-lang.c (pascal_language_defn): Likewise.
11534 * rust-lang.c (rust_language_defn): Likewise.
11535
115362019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11537
11538 * riscv-tdep.c (riscv_type_align): New function.
11539 (riscv_type_alignment): Delete.
11540 (riscv_arg_location): Use 'type_align'.
11541 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11542
115432019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11544
11545 * gdbtypes.c (type_align): A struct with no non-static fields also
11546 has alignment of 1.
11547
115482019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11549
11550 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11551 component to 0.
11552 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11553 member.
11554 (riscv_struct_info::analyse): New implementation using new
11555 analyse_inner member function.
11556 (riscv_struct_info::field_offset): New member function.
11557 (riscv_struct_info::m_offsets): New member variable.
11558 (riscv_struct_info::analyse_inner): New private member function,
11559 takes the old implementation of riscv_struct_info::analyse but
11560 extended to track field offsets.
11561 (riscv_call_arg_struct): Update the struct folding special cases
11562 to handle cases where empty C++ structs, which are non-zero
11563 length, are found.
11564 (riscv_arg_location): Initialise the length of each location, a
11565 non-zero length now indicates the location is in use.
11566 (riscv_push_dummy_call): Allow for the first location having a
11567 non-zero offset when setting up arguments.
11568 (riscv_return_value): Likewise, but for return values.
11569
115702019-04-11 Tom Tromey <tromey@adacore.com>
11571
11572 * utils.c (internal_vproblem): Make "msg" const.
11573
115742019-04-11 Alan Hayward <alan.hayward@arm.com>
11575
11576 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11577 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11578 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11579 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11580
115812019-04-10 Kevin Buettner <kevinb@redhat.com>
11582
11583 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11584 function.
11585 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11586 of amd64_collect_native_gregset.
11587 (amd64_linux_nat_target::store_registers): Likewise.
11588
115892019-04-10 Tom Tromey <tom@tromey.com>
11590
11591 * symtab.c (lookup_global_symbol_from_objfile)
11592 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11593 * objfiles.h (class separate_debug_iterator): New.
11594 (class separate_debug_range): New.
11595 (struct objfile) <separate_debug_objfiles>: New method.
11596 (objfile_separate_debug_iterate): Don't declare.
11597 * objfiles.c (separate_debug_iterator::operator++): Rename from
11598 objfile_separate_debug_iterate.
11599 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11600 iterator.
11601 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11602 iterator.
11603
116042019-04-10 Tom Tromey <tom@tromey.com>
11605
11606 * symfile.c (reread_symbols): Remove old comment.
11607 * objfiles.c (free_all_objfiles): Fix a typo.
11608
116092019-04-10 Tom Tromey <tom@tromey.com>
11610
11611 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11612 * minsyms.c (lookup_minimal_symbol): Use foreach.
11613 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11614 (lookup_minimal_symbol_solib_trampoline): Likewise.
11615 * symfile.c (reread_symbols): Use foreach.
11616
116172019-04-09 Ivan Begert <ivanbegert@gmail.com>
11618 Tom Tromey <tromey@adacore.com>
11619
11620 PR rust/24414:
11621 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11622 (rust_lex_int_test): Change "value" to be LONGEST.
11623 (rust_lex_tests): Add test for long integer literal.
11624
116252019-04-09 Tom Tromey <tromey@adacore.com>
11626
11627 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11628 to bool.
11629 (extended_remote_target::attach): Update.
11630 (remote_target::remote_notice_new_inferior): Update.
11631 (remote_target::add_current_inferior_and_thread): Update.
11632 * inferior.c (exit_inferior_1): Use "false".
11633 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11634
116352019-04-09 Simon Marchi <simon.marchi@efficios.com>
11636
11637 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11638 the "start" command.
11639
116402019-04-08 Kevin Buettner <kevinb@redhat.com>
11641
11642 * python/py-inferior.c (infpy_thread_from_thread_handle):
11643 Adjust comments to reflect renaming of thread_from_thread_handle
11644 to thread_from_handle. Adjust keywords. Fix type error message.
11645 (inferior_object_methods): Add thread_from_handle. Retain
11646 thread_from_thread_handle, but mark it as deprecated.
11647
116482019-04-08 Kevin Buettner <kevinb@redhat.com>
11649
11650 * gdbthread.h (find_thread_by_handle): Revise declaration.
11651 * thread.c (find_thread_by_handle): Likewise. Adjust
11652 implementation too.
11653 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11654 support for buffer objects as handles.
11655
116562019-04-08 Kevin Buettner <kevinb@redhat.com>
11657
11658 * python/py-infthread.c (thpy_thread_handle): New function.
11659 (thread_object_methods): Register thpy_thread_handle.
11660
116612019-04-08 Kevin Buettner <kevinb@redhat.com>
11662
11663 * gdbthread.h (thread_to_thread_handle): Declare.
11664 * thread.c (gdbtypes.h): Include.
11665 (thread_to_thread_handle): New function.
11666
11667 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11668 (target_thread_info_to_thread_handle): Declare.
11669 * target.c (target_thread_info_to_thread_handle): New function.
11670 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11671 * target-delegates.c: Regenerate.
11672
11673 * linux-thread-db.c (class thread_db_target): Add method
11674 thread_info_to_thread_handle.
11675 (thread_db_target::thread_info_to_thread_handle): Define.
11676 * remote.c (class remote_target): Add new method
11677 thread_info_to_thread_handle.
11678 (remote_target::thread_info_to_thread_handle): Define.
11679
116802019-04-08 Pedro Alves <palves@redhat.com>
11681
11682 * common/common-exceptions.c (throw_exception): Don't create
11683 named object to throw; throw directly.
11684 (throw_it): Likewise. Don't initialize gdb_exception::message
11685 here, with new; pass FMT and AP to the ctor instead.
11686 * common/common-exceptions.h: Include <string>.
11687 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11688 const char *, va_list)): New ctor. Use std::make_shared.
11689 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11690 errors)): Delete.
11691 (gdb_exception_error::gdb_exception_error(enum errors, const char
11692 *, va_list)): New.
11693 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11694 Add assertion.
11695 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11696 errors)): Delete.
11697 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11698 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11699 Add assertion.
11700
117012019-04-08 Tom Tromey <tom@tromey.com>
11702
11703 * valops.c (value_rtti_indirect_type): Replace throw_exception
11704 with throw.
11705 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11706 with throw.
11707 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11708 throw.
11709 * target.c (target_translate_tls_address): Replace throw_exception
11710 with throw.
11711 * stack.c (frame_apply_command_count): Replace throw_exception
11712 with throw.
11713 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11714 throw.
11715 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11716 with throw.
11717 * rs6000-tdep.c (rs6000_frame_cache)
11718 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11719 * remote.c: Replace throw_exception with throw.
11720 * record-full.c (record_full_message, record_full_wait_1)
11721 (record_full_restore): Replace throw_exception with throw.
11722 * record-btrace.c:
11723 (get_thread_current_frame_id, record_btrace_start_replaying)
11724 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11725 (cmd_record_btrace_start): Replace throw_exception with throw.
11726 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11727 throw.
11728 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11729 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11730 * linespec.c:
11731 (find_linespec_symbols): Replace throw_exception with throw.
11732 * infrun.c (displaced_step_prepare, resume): Replace
11733 throw_exception with throw.
11734 * infcmd.c (post_create_inferior): Replace throw_exception with
11735 throw.
11736 * inf-loop.c (inferior_event_handler): Replace throw_exception
11737 with throw.
11738 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11739 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11740 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11741 (get_prev_frame_always, get_frame_pc_if_available)
11742 (get_frame_address_in_block_if_available, get_frame_language):
11743 Replace throw_exception with throw.
11744 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11745 throw_exception with throw.
11746 * eval.c (fetch_subexp_value, evaluate_var_value)
11747 (evaluate_funcall, evaluate_subexp_standard): Replace
11748 throw_exception with throw.
11749 * dwarf2loc.c (call_site_find_chain)
11750 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11751 Replace throw_exception with throw.
11752 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11753 with throw.
11754 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11755 throw.
11756 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11757 * completer.c (complete_line_internal): Replace throw_exception
11758 with throw.
11759 * compile/compile-object-run.c (compile_object_run): Replace
11760 throw_exception with throw.
11761 * cli/cli-script.c (process_next_line): Replace throw_exception
11762 with throw.
11763 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11764 (btrace_enable, btrace_maint_update_pt_packets): Replace
11765 throw_exception with throw.
11766 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11767 throw_exception with throw.
11768 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11769 throw_exception with throw.
11770 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11771 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11772 * aarch64-tdep.c (aarch64_make_prologue_cache)
11773 (aarch64_make_stub_cache): Replace throw_exception with throw.
11774
117752019-04-08 Tom Tromey <tom@tromey.com>
11776
11777 * common/common-exceptions.c (throw_exception): Rename from
11778 throw_exception_cxx. Remove old copy. Make argument const.
11779 (throw_it): Create and throw exception objects directly.
11780 * common/common-exceptions.h (throw_exception): Make argument
11781 const.
11782 (struct gdb_exception_error): Add constructor.
11783 (struct gdb_exception_quit): Add constructor.
11784
117852019-04-08 Tom Tromey <tom@tromey.com>
11786
11787 * common/common-exceptions.h (exception_rethrow): Don't declare.
11788 (TRY_SJLJ): Update comment.
11789 (TRY, CATCH, END_CATCH): Remove.
11790 * common/common-exceptions.c (exception_rethrow): Remove.
11791
117922019-04-08 Tom Tromey <tom@tromey.com>
11793
11794 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11795 Remove.
11796 (gdb_exception_error): Rename from
11797 gdb_exception_RETURN_MASK_ERROR.
11798 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11799 (gdb_quit_bad_alloc): Update.
11800 * aarch64-tdep.c: Update.
11801 * ada-lang.c: Update.
11802 * ada-typeprint.c: Update.
11803 * ada-valprint.c: Update.
11804 * amd64-tdep.c: Update.
11805 * arch-utils.c: Update.
11806 * break-catch-throw.c: Update.
11807 * breakpoint.c: Update.
11808 * btrace.c: Update.
11809 * c-varobj.c: Update.
11810 * cli/cli-cmds.c: Update.
11811 * cli/cli-interp.c: Update.
11812 * cli/cli-script.c: Update.
11813 * common/common-exceptions.c: Update.
11814 * common/new-op.c: Update.
11815 * common/selftest.c: Update.
11816 * compile/compile-c-symbols.c: Update.
11817 * compile/compile-cplus-symbols.c: Update.
11818 * compile/compile-object-load.c: Update.
11819 * compile/compile-object-run.c: Update.
11820 * completer.c: Update.
11821 * corelow.c: Update.
11822 * cp-abi.c: Update.
11823 * cp-support.c: Update.
11824 * cp-valprint.c: Update.
11825 * darwin-nat.c: Update.
11826 * disasm-selftests.c: Update.
11827 * dtrace-probe.c: Update.
11828 * dwarf-index-cache.c: Update.
11829 * dwarf-index-write.c: Update.
11830 * dwarf2-frame-tailcall.c: Update.
11831 * dwarf2-frame.c: Update.
11832 * dwarf2loc.c: Update.
11833 * dwarf2read.c: Update.
11834 * eval.c: Update.
11835 * event-loop.c: Update.
11836 * event-top.c: Update.
11837 * exec.c: Update.
11838 * f-valprint.c: Update.
11839 * fbsd-tdep.c: Update.
11840 * frame-unwind.c: Update.
11841 * frame.c: Update.
11842 * gdbtypes.c: Update.
11843 * gnu-v3-abi.c: Update.
11844 * guile/guile-internal.h: Update.
11845 * guile/scm-block.c: Update.
11846 * guile/scm-breakpoint.c: Update.
11847 * guile/scm-cmd.c: Update.
11848 * guile/scm-disasm.c: Update.
11849 * guile/scm-frame.c: Update.
11850 * guile/scm-lazy-string.c: Update.
11851 * guile/scm-math.c: Update.
11852 * guile/scm-param.c: Update.
11853 * guile/scm-ports.c: Update.
11854 * guile/scm-pretty-print.c: Update.
11855 * guile/scm-symbol.c: Update.
11856 * guile/scm-symtab.c: Update.
11857 * guile/scm-type.c: Update.
11858 * guile/scm-value.c: Update.
11859 * i386-linux-tdep.c: Update.
11860 * i386-tdep.c: Update.
11861 * inf-loop.c: Update.
11862 * infcall.c: Update.
11863 * infcmd.c: Update.
11864 * infrun.c: Update.
11865 * jit.c: Update.
11866 * language.c: Update.
11867 * linespec.c: Update.
11868 * linux-fork.c: Update.
11869 * linux-nat.c: Update.
11870 * linux-tdep.c: Update.
11871 * linux-thread-db.c: Update.
11872 * main.c: Update.
11873 * mi/mi-cmd-break.c: Update.
11874 * mi/mi-cmd-stack.c: Update.
11875 * mi/mi-interp.c: Update.
11876 * mi/mi-main.c: Update.
11877 * objc-lang.c: Update.
11878 * p-valprint.c: Update.
11879 * parse.c: Update.
11880 * ppc-linux-tdep.c: Update.
11881 * printcmd.c: Update.
11882 * python/py-arch.c: Update.
11883 * python/py-breakpoint.c: Update.
11884 * python/py-cmd.c: Update.
11885 * python/py-finishbreakpoint.c: Update.
11886 * python/py-frame.c: Update.
11887 * python/py-framefilter.c: Update.
11888 * python/py-gdb-readline.c: Update.
11889 * python/py-inferior.c: Update.
11890 * python/py-infthread.c: Update.
11891 * python/py-lazy-string.c: Update.
11892 * python/py-linetable.c: Update.
11893 * python/py-objfile.c: Update.
11894 * python/py-param.c: Update.
11895 * python/py-prettyprint.c: Update.
11896 * python/py-progspace.c: Update.
11897 * python/py-record-btrace.c: Update.
11898 * python/py-record.c: Update.
11899 * python/py-symbol.c: Update.
11900 * python/py-type.c: Update.
11901 * python/py-unwind.c: Update.
11902 * python/py-utils.c: Update.
11903 * python/py-value.c: Update.
11904 * python/python.c: Update.
11905 * record-btrace.c: Update.
11906 * record-full.c: Update.
11907 * remote-fileio.c: Update.
11908 * remote.c: Update.
11909 * riscv-tdep.c: Update.
11910 * rs6000-aix-tdep.c: Update.
11911 * rs6000-tdep.c: Update.
11912 * rust-exp.y: Update.
11913 * rust-lang.c: Update.
11914 * s390-tdep.c: Update.
11915 * selftest-arch.c: Update.
11916 * solib-dsbt.c: Update.
11917 * solib-frv.c: Update.
11918 * solib-spu.c: Update.
11919 * solib-svr4.c: Update.
11920 * solib.c: Update.
11921 * sparc64-linux-tdep.c: Update.
11922 * stack.c: Update.
11923 * symfile-mem.c: Update.
11924 * symmisc.c: Update.
11925 * target.c: Update.
11926 * thread.c: Update.
11927 * top.c: Update.
11928 * tracefile-tfile.c: Update.
11929 * tui/tui.c: Update.
11930 * typeprint.c: Update.
11931 * unittests/cli-utils-selftests.c: Update.
11932 * unittests/parse-connection-spec-selftests.c: Update.
11933 * valops.c: Update.
11934 * valprint.c: Update.
11935 * value.c: Update.
11936 * varobj.c: Update.
11937 * windows-nat.c: Update.
11938 * x86-linux-nat.c: Update.
11939 * xml-support.c: Update.
11940
119412019-04-08 Tom Tromey <tom@tromey.com>
11942
11943 * xml-support.c: Use C++ exception handling.
11944 * x86-linux-nat.c: Use C++ exception handling.
11945 * windows-nat.c: Use C++ exception handling.
11946 * varobj.c: Use C++ exception handling.
11947 * value.c: Use C++ exception handling.
11948 * valprint.c: Use C++ exception handling.
11949 * valops.c: Use C++ exception handling.
11950 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11951 handling.
11952 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11953 * typeprint.c: Use C++ exception handling.
11954 * tui/tui.c: Use C++ exception handling.
11955 * tracefile-tfile.c: Use C++ exception handling.
11956 * top.c: Use C++ exception handling.
11957 * thread.c: Use C++ exception handling.
11958 * target.c: Use C++ exception handling.
11959 * symmisc.c: Use C++ exception handling.
11960 * symfile-mem.c: Use C++ exception handling.
11961 * stack.c: Use C++ exception handling.
11962 * sparc64-linux-tdep.c: Use C++ exception handling.
11963 * solib.c: Use C++ exception handling.
11964 * solib-svr4.c: Use C++ exception handling.
11965 * solib-spu.c: Use C++ exception handling.
11966 * solib-frv.c: Use C++ exception handling.
11967 * solib-dsbt.c: Use C++ exception handling.
11968 * selftest-arch.c: Use C++ exception handling.
11969 * s390-tdep.c: Use C++ exception handling.
11970 * rust-lang.c: Use C++ exception handling.
11971 * rust-exp.y: Use C++ exception handling.
11972 * rs6000-tdep.c: Use C++ exception handling.
11973 * rs6000-aix-tdep.c: Use C++ exception handling.
11974 * riscv-tdep.c: Use C++ exception handling.
11975 * remote.c: Use C++ exception handling.
11976 * remote-fileio.c: Use C++ exception handling.
11977 * record-full.c: Use C++ exception handling.
11978 * record-btrace.c: Use C++ exception handling.
11979 * python/python.c: Use C++ exception handling.
11980 * python/py-value.c: Use C++ exception handling.
11981 * python/py-utils.c: Use C++ exception handling.
11982 * python/py-unwind.c: Use C++ exception handling.
11983 * python/py-type.c: Use C++ exception handling.
11984 * python/py-symbol.c: Use C++ exception handling.
11985 * python/py-record.c: Use C++ exception handling.
11986 * python/py-record-btrace.c: Use C++ exception handling.
11987 * python/py-progspace.c: Use C++ exception handling.
11988 * python/py-prettyprint.c: Use C++ exception handling.
11989 * python/py-param.c: Use C++ exception handling.
11990 * python/py-objfile.c: Use C++ exception handling.
11991 * python/py-linetable.c: Use C++ exception handling.
11992 * python/py-lazy-string.c: Use C++ exception handling.
11993 * python/py-infthread.c: Use C++ exception handling.
11994 * python/py-inferior.c: Use C++ exception handling.
11995 * python/py-gdb-readline.c: Use C++ exception handling.
11996 * python/py-framefilter.c: Use C++ exception handling.
11997 * python/py-frame.c: Use C++ exception handling.
11998 * python/py-finishbreakpoint.c: Use C++ exception handling.
11999 * python/py-cmd.c: Use C++ exception handling.
12000 * python/py-breakpoint.c: Use C++ exception handling.
12001 * python/py-arch.c: Use C++ exception handling.
12002 * printcmd.c: Use C++ exception handling.
12003 * ppc-linux-tdep.c: Use C++ exception handling.
12004 * parse.c: Use C++ exception handling.
12005 * p-valprint.c: Use C++ exception handling.
12006 * objc-lang.c: Use C++ exception handling.
12007 * mi/mi-main.c: Use C++ exception handling.
12008 * mi/mi-interp.c: Use C++ exception handling.
12009 * mi/mi-cmd-stack.c: Use C++ exception handling.
12010 * mi/mi-cmd-break.c: Use C++ exception handling.
12011 * main.c: Use C++ exception handling.
12012 * linux-thread-db.c: Use C++ exception handling.
12013 * linux-tdep.c: Use C++ exception handling.
12014 * linux-nat.c: Use C++ exception handling.
12015 * linux-fork.c: Use C++ exception handling.
12016 * linespec.c: Use C++ exception handling.
12017 * language.c: Use C++ exception handling.
12018 * jit.c: Use C++ exception handling.
12019 * infrun.c: Use C++ exception handling.
12020 * infcmd.c: Use C++ exception handling.
12021 * infcall.c: Use C++ exception handling.
12022 * inf-loop.c: Use C++ exception handling.
12023 * i386-tdep.c: Use C++ exception handling.
12024 * i386-linux-tdep.c: Use C++ exception handling.
12025 * guile/scm-value.c: Use C++ exception handling.
12026 * guile/scm-type.c: Use C++ exception handling.
12027 * guile/scm-symtab.c: Use C++ exception handling.
12028 * guile/scm-symbol.c: Use C++ exception handling.
12029 * guile/scm-pretty-print.c: Use C++ exception handling.
12030 * guile/scm-ports.c: Use C++ exception handling.
12031 * guile/scm-param.c: Use C++ exception handling.
12032 * guile/scm-math.c: Use C++ exception handling.
12033 * guile/scm-lazy-string.c: Use C++ exception handling.
12034 * guile/scm-frame.c: Use C++ exception handling.
12035 * guile/scm-disasm.c: Use C++ exception handling.
12036 * guile/scm-cmd.c: Use C++ exception handling.
12037 * guile/scm-breakpoint.c: Use C++ exception handling.
12038 * guile/scm-block.c: Use C++ exception handling.
12039 * guile/guile-internal.h: Use C++ exception handling.
12040 * gnu-v3-abi.c: Use C++ exception handling.
12041 * gdbtypes.c: Use C++ exception handling.
12042 * frame.c: Use C++ exception handling.
12043 * frame-unwind.c: Use C++ exception handling.
12044 * fbsd-tdep.c: Use C++ exception handling.
12045 * f-valprint.c: Use C++ exception handling.
12046 * exec.c: Use C++ exception handling.
12047 * event-top.c: Use C++ exception handling.
12048 * event-loop.c: Use C++ exception handling.
12049 * eval.c: Use C++ exception handling.
12050 * dwarf2read.c: Use C++ exception handling.
12051 * dwarf2loc.c: Use C++ exception handling.
12052 * dwarf2-frame.c: Use C++ exception handling.
12053 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12054 * dwarf-index-write.c: Use C++ exception handling.
12055 * dwarf-index-cache.c: Use C++ exception handling.
12056 * dtrace-probe.c: Use C++ exception handling.
12057 * disasm-selftests.c: Use C++ exception handling.
12058 * darwin-nat.c: Use C++ exception handling.
12059 * cp-valprint.c: Use C++ exception handling.
12060 * cp-support.c: Use C++ exception handling.
12061 * cp-abi.c: Use C++ exception handling.
12062 * corelow.c: Use C++ exception handling.
12063 * completer.c: Use C++ exception handling.
12064 * compile/compile-object-run.c: Use C++ exception handling.
12065 * compile/compile-object-load.c: Use C++ exception handling.
12066 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12067 * compile/compile-c-symbols.c: Use C++ exception handling.
12068 * common/selftest.c: Use C++ exception handling.
12069 * common/new-op.c: Use C++ exception handling.
12070 * cli/cli-script.c: Use C++ exception handling.
12071 * cli/cli-interp.c: Use C++ exception handling.
12072 * cli/cli-cmds.c: Use C++ exception handling.
12073 * c-varobj.c: Use C++ exception handling.
12074 * btrace.c: Use C++ exception handling.
12075 * breakpoint.c: Use C++ exception handling.
12076 * break-catch-throw.c: Use C++ exception handling.
12077 * arch-utils.c: Use C++ exception handling.
12078 * amd64-tdep.c: Use C++ exception handling.
12079 * ada-valprint.c: Use C++ exception handling.
12080 * ada-typeprint.c: Use C++ exception handling.
12081 * ada-lang.c: Use C++ exception handling.
12082 * aarch64-tdep.c: Use C++ exception handling.
12083
120842019-04-08 Tom Tromey <tom@tromey.com>
12085
12086 * xml-support.c (gdb_xml_parser::parse): Update.
12087 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12088 * value.c (show_convenience): Update.
12089 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12090 (test_parse_flags_qcs): Update.
12091 * thread.c (thr_try_catch_cmd): Update.
12092 * target.c (target_translate_tls_address): Update.
12093 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12094 (info_frame_command_core, frame_apply_command_count): Update.
12095 * rust-exp.y (rust_lex_exception_test): Update.
12096 * riscv-tdep.c (riscv_print_one_register_info): Update.
12097 * remote.c (remote_target::enable_btrace): Update.
12098 * record-btrace.c (record_btrace_enable_warn): Update.
12099 * python/py-utils.c (gdbpy_convert_exception): Update.
12100 * printcmd.c (do_one_display, print_variable_and_value): Update.
12101 * mi/mi-main.c (mi_print_exception): Update.
12102 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12103 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12104 * linux-nat.c (linux_nat_target::attach): Update.
12105 * linux-fork.c (class scoped_switch_fork_info): Update.
12106 * infrun.c (displaced_step_prepare): Update.
12107 * infcall.c (call_function_by_hand_dummy): Update.
12108 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12109 * gnu-v3-abi.c (print_one_vtable): Update.
12110 * frame.c (get_prev_frame_always): Update.
12111 * f-valprint.c (info_common_command_for_block): Update.
12112 * exec.c (try_open_exec_file): Update.
12113 * exceptions.c (print_exception, exception_print)
12114 (exception_fprintf, exception_print_same): Update.
12115 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12116 * dwarf-index-cache.c (index_cache::store)
12117 (index_cache::lookup_gdb_index): Update.
12118 * darwin-nat.c (maybe_cache_shell): Update.
12119 * cp-valprint.c (cp_print_value_fields): Update.
12120 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12121 (gcc_cplus_symbol_address): Update.
12122 * compile/compile-c-symbols.c (gcc_convert_symbol)
12123 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12124 * common/selftest.c: Update.
12125 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12126 a std::string.
12127 (exception_try_scope_entry, exception_try_scope_exit): Don't
12128 declare.
12129 (struct exception_try_scope): Remove.
12130 (TRY): Don't use exception_try_scope.
12131 (struct gdb_exception): Add constructor, operator=.
12132 <what>: New method.
12133 (struct gdb_exception_RETURN_MASK_ALL)
12134 (struct gdb_exception_RETURN_MASK_ERROR)
12135 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12136 (struct gdb_quit_bad_alloc): Update.
12137 * common/common-exceptions.c (exception_none): Change
12138 initializer.
12139 (struct catcher) <state, exception>: Initialize inline.
12140 <prev>: Remove member.
12141 (current_catcher): Remove.
12142 (catchers): New global.
12143 (exceptions_state_mc_init): Simplify.
12144 (catcher_pop): Remove.
12145 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12146 (try_scope_depth, exception_try_scope_entry)
12147 (exception_try_scope_exit): Remove.
12148 (throw_exception_sjlj): Update.
12149 (exception_messages, exception_messages_size): Remove.
12150 (throw_it): Simplify.
12151 (gdb_exception_sliced_copy): Remove.
12152 (throw_exception_cxx): Update.
12153 * cli/cli-script.c (script_from_file): Update.
12154 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12155 Update.
12156 * ada-valprint.c (ada_val_print): Update.
12157 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12158 (create_excep_cond_exprs): Update.
12159
121602019-04-08 Tom Tromey <tom@tromey.com>
12161
12162 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12163 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12164 (TRY, CATCH, END_CATCH): Remove some definitions.
12165 * common/common-exceptions.c: Don't use GDB_XCPT.
12166 (catcher_list_size): Remove.
12167 (throw_exception, throw_it): Simplify.
12168
121692019-04-05 Tom Tromey <tom@tromey.com>
12170
12171 Revert the header-sorting patch.
12172 * ft32-tdep.c: Revert.
12173 * frv-tdep.c: Revert.
12174 * frv-linux-tdep.c: Revert.
12175 * frame.c: Revert.
12176 * frame-unwind.c: Revert.
12177 * frame-base.c: Revert.
12178 * fork-child.c: Revert.
12179 * findvar.c: Revert.
12180 * findcmd.c: Revert.
12181 * filesystem.c: Revert.
12182 * filename-seen-cache.h: Revert.
12183 * filename-seen-cache.c: Revert.
12184 * fbsd-tdep.c: Revert.
12185 * fbsd-nat.h: Revert.
12186 * fbsd-nat.c: Revert.
12187 * f-valprint.c: Revert.
12188 * f-typeprint.c: Revert.
12189 * f-lang.c: Revert.
12190 * extension.h: Revert.
12191 * extension.c: Revert.
12192 * extension-priv.h: Revert.
12193 * expprint.c: Revert.
12194 * exec.h: Revert.
12195 * exec.c: Revert.
12196 * exceptions.c: Revert.
12197 * event-top.c: Revert.
12198 * event-loop.c: Revert.
12199 * eval.c: Revert.
12200 * elfread.c: Revert.
12201 * dwarf2read.h: Revert.
12202 * dwarf2read.c: Revert.
12203 * dwarf2loc.c: Revert.
12204 * dwarf2expr.h: Revert.
12205 * dwarf2expr.c: Revert.
12206 * dwarf2-frame.c: Revert.
12207 * dwarf2-frame-tailcall.c: Revert.
12208 * dwarf-index-write.h: Revert.
12209 * dwarf-index-write.c: Revert.
12210 * dwarf-index-common.c: Revert.
12211 * dwarf-index-cache.h: Revert.
12212 * dwarf-index-cache.c: Revert.
12213 * dummy-frame.c: Revert.
12214 * dtrace-probe.c: Revert.
12215 * disasm.h: Revert.
12216 * disasm.c: Revert.
12217 * disasm-selftests.c: Revert.
12218 * dictionary.c: Revert.
12219 * dicos-tdep.c: Revert.
12220 * demangle.c: Revert.
12221 * dcache.h: Revert.
12222 * dcache.c: Revert.
12223 * darwin-nat.h: Revert.
12224 * darwin-nat.c: Revert.
12225 * darwin-nat-info.c: Revert.
12226 * d-valprint.c: Revert.
12227 * d-namespace.c: Revert.
12228 * d-lang.c: Revert.
12229 * ctf.c: Revert.
12230 * csky-tdep.c: Revert.
12231 * csky-linux-tdep.c: Revert.
12232 * cris-tdep.c: Revert.
12233 * cris-linux-tdep.c: Revert.
12234 * cp-valprint.c: Revert.
12235 * cp-support.c: Revert.
12236 * cp-namespace.c: Revert.
12237 * cp-abi.c: Revert.
12238 * corelow.c: Revert.
12239 * corefile.c: Revert.
12240 * continuations.c: Revert.
12241 * completer.h: Revert.
12242 * completer.c: Revert.
12243 * complaints.c: Revert.
12244 * coffread.c: Revert.
12245 * coff-pe-read.c: Revert.
12246 * cli-out.h: Revert.
12247 * cli-out.c: Revert.
12248 * charset.c: Revert.
12249 * c-varobj.c: Revert.
12250 * c-valprint.c: Revert.
12251 * c-typeprint.c: Revert.
12252 * c-lang.c: Revert.
12253 * buildsym.c: Revert.
12254 * buildsym-legacy.c: Revert.
12255 * build-id.h: Revert.
12256 * build-id.c: Revert.
12257 * btrace.c: Revert.
12258 * bsd-uthread.c: Revert.
12259 * breakpoint.h: Revert.
12260 * breakpoint.c: Revert.
12261 * break-catch-throw.c: Revert.
12262 * break-catch-syscall.c: Revert.
12263 * break-catch-sig.c: Revert.
12264 * blockframe.c: Revert.
12265 * block.c: Revert.
12266 * bfin-tdep.c: Revert.
12267 * bfin-linux-tdep.c: Revert.
12268 * bfd-target.c: Revert.
12269 * bcache.c: Revert.
12270 * ax-general.c: Revert.
12271 * ax-gdb.h: Revert.
12272 * ax-gdb.c: Revert.
12273 * avr-tdep.c: Revert.
12274 * auxv.c: Revert.
12275 * auto-load.c: Revert.
12276 * arm-wince-tdep.c: Revert.
12277 * arm-tdep.c: Revert.
12278 * arm-symbian-tdep.c: Revert.
12279 * arm-pikeos-tdep.c: Revert.
12280 * arm-obsd-tdep.c: Revert.
12281 * arm-nbsd-tdep.c: Revert.
12282 * arm-nbsd-nat.c: Revert.
12283 * arm-linux-tdep.c: Revert.
12284 * arm-linux-nat.c: Revert.
12285 * arm-fbsd-tdep.c: Revert.
12286 * arm-fbsd-nat.c: Revert.
12287 * arm-bsd-tdep.c: Revert.
12288 * arch-utils.c: Revert.
12289 * arc-tdep.c: Revert.
12290 * arc-newlib-tdep.c: Revert.
12291 * annotate.h: Revert.
12292 * annotate.c: Revert.
12293 * amd64-windows-tdep.c: Revert.
12294 * amd64-windows-nat.c: Revert.
12295 * amd64-tdep.c: Revert.
12296 * amd64-sol2-tdep.c: Revert.
12297 * amd64-obsd-tdep.c: Revert.
12298 * amd64-obsd-nat.c: Revert.
12299 * amd64-nbsd-tdep.c: Revert.
12300 * amd64-nbsd-nat.c: Revert.
12301 * amd64-nat.c: Revert.
12302 * amd64-linux-tdep.c: Revert.
12303 * amd64-linux-nat.c: Revert.
12304 * amd64-fbsd-tdep.c: Revert.
12305 * amd64-fbsd-nat.c: Revert.
12306 * amd64-dicos-tdep.c: Revert.
12307 * amd64-darwin-tdep.c: Revert.
12308 * amd64-bsd-nat.c: Revert.
12309 * alpha-tdep.c: Revert.
12310 * alpha-obsd-tdep.c: Revert.
12311 * alpha-nbsd-tdep.c: Revert.
12312 * alpha-mdebug-tdep.c: Revert.
12313 * alpha-linux-tdep.c: Revert.
12314 * alpha-linux-nat.c: Revert.
12315 * alpha-bsd-tdep.c: Revert.
12316 * alpha-bsd-nat.c: Revert.
12317 * aix-thread.c: Revert.
12318 * agent.c: Revert.
12319 * addrmap.c: Revert.
12320 * ada-varobj.c: Revert.
12321 * ada-valprint.c: Revert.
12322 * ada-typeprint.c: Revert.
12323 * ada-tasks.c: Revert.
12324 * ada-lang.c: Revert.
12325 * aarch64-tdep.c: Revert.
12326 * aarch64-ravenscar-thread.c: Revert.
12327 * aarch64-newlib-tdep.c: Revert.
12328 * aarch64-linux-tdep.c: Revert.
12329 * aarch64-linux-nat.c: Revert.
12330 * aarch64-fbsd-tdep.c: Revert.
12331 * aarch64-fbsd-nat.c: Revert.
12332 * aarch32-linux-nat.c: Revert.
12333
123342019-04-05 Tom Tromey <tom@tromey.com>
12335
12336 * ft32-tdep.c: Sort headers.
12337 * frv-tdep.c: Sort headers.
12338 * frv-linux-tdep.c: Sort headers.
12339 * frame.c: Sort headers.
12340 * frame-unwind.c: Sort headers.
12341 * frame-base.c: Sort headers.
12342 * fork-child.c: Sort headers.
12343 * findvar.c: Sort headers.
12344 * findcmd.c: Sort headers.
12345 * filesystem.c: Sort headers.
12346 * filename-seen-cache.h: Sort headers.
12347 * filename-seen-cache.c: Sort headers.
12348 * fbsd-tdep.c: Sort headers.
12349 * fbsd-nat.h: Sort headers.
12350 * fbsd-nat.c: Sort headers.
12351 * f-valprint.c: Sort headers.
12352 * f-typeprint.c: Sort headers.
12353 * f-lang.c: Sort headers.
12354 * extension.h: Sort headers.
12355 * extension.c: Sort headers.
12356 * extension-priv.h: Sort headers.
12357 * expprint.c: Sort headers.
12358 * exec.h: Sort headers.
12359 * exec.c: Sort headers.
12360 * exceptions.c: Sort headers.
12361 * event-top.c: Sort headers.
12362 * event-loop.c: Sort headers.
12363 * eval.c: Sort headers.
12364 * elfread.c: Sort headers.
12365 * dwarf2read.h: Sort headers.
12366 * dwarf2read.c: Sort headers.
12367 * dwarf2loc.c: Sort headers.
12368 * dwarf2expr.h: Sort headers.
12369 * dwarf2expr.c: Sort headers.
12370 * dwarf2-frame.c: Sort headers.
12371 * dwarf2-frame-tailcall.c: Sort headers.
12372 * dwarf-index-write.h: Sort headers.
12373 * dwarf-index-write.c: Sort headers.
12374 * dwarf-index-common.c: Sort headers.
12375 * dwarf-index-cache.h: Sort headers.
12376 * dwarf-index-cache.c: Sort headers.
12377 * dummy-frame.c: Sort headers.
12378 * dtrace-probe.c: Sort headers.
12379 * disasm.h: Sort headers.
12380 * disasm.c: Sort headers.
12381 * disasm-selftests.c: Sort headers.
12382 * dictionary.c: Sort headers.
12383 * dicos-tdep.c: Sort headers.
12384 * demangle.c: Sort headers.
12385 * dcache.h: Sort headers.
12386 * dcache.c: Sort headers.
12387 * darwin-nat.h: Sort headers.
12388 * darwin-nat.c: Sort headers.
12389 * darwin-nat-info.c: Sort headers.
12390 * d-valprint.c: Sort headers.
12391 * d-namespace.c: Sort headers.
12392 * d-lang.c: Sort headers.
12393 * ctf.c: Sort headers.
12394 * csky-tdep.c: Sort headers.
12395 * csky-linux-tdep.c: Sort headers.
12396 * cris-tdep.c: Sort headers.
12397 * cris-linux-tdep.c: Sort headers.
12398 * cp-valprint.c: Sort headers.
12399 * cp-support.c: Sort headers.
12400 * cp-namespace.c: Sort headers.
12401 * cp-abi.c: Sort headers.
12402 * corelow.c: Sort headers.
12403 * corefile.c: Sort headers.
12404 * continuations.c: Sort headers.
12405 * completer.h: Sort headers.
12406 * completer.c: Sort headers.
12407 * complaints.c: Sort headers.
12408 * coffread.c: Sort headers.
12409 * coff-pe-read.c: Sort headers.
12410 * cli-out.h: Sort headers.
12411 * cli-out.c: Sort headers.
12412 * charset.c: Sort headers.
12413 * c-varobj.c: Sort headers.
12414 * c-valprint.c: Sort headers.
12415 * c-typeprint.c: Sort headers.
12416 * c-lang.c: Sort headers.
12417 * buildsym.c: Sort headers.
12418 * buildsym-legacy.c: Sort headers.
12419 * build-id.h: Sort headers.
12420 * build-id.c: Sort headers.
12421 * btrace.c: Sort headers.
12422 * bsd-uthread.c: Sort headers.
12423 * breakpoint.h: Sort headers.
12424 * breakpoint.c: Sort headers.
12425 * break-catch-throw.c: Sort headers.
12426 * break-catch-syscall.c: Sort headers.
12427 * break-catch-sig.c: Sort headers.
12428 * blockframe.c: Sort headers.
12429 * block.c: Sort headers.
12430 * bfin-tdep.c: Sort headers.
12431 * bfin-linux-tdep.c: Sort headers.
12432 * bfd-target.c: Sort headers.
12433 * bcache.c: Sort headers.
12434 * ax-general.c: Sort headers.
12435 * ax-gdb.h: Sort headers.
12436 * ax-gdb.c: Sort headers.
12437 * avr-tdep.c: Sort headers.
12438 * auxv.c: Sort headers.
12439 * auto-load.c: Sort headers.
12440 * arm-wince-tdep.c: Sort headers.
12441 * arm-tdep.c: Sort headers.
12442 * arm-symbian-tdep.c: Sort headers.
12443 * arm-pikeos-tdep.c: Sort headers.
12444 * arm-obsd-tdep.c: Sort headers.
12445 * arm-nbsd-tdep.c: Sort headers.
12446 * arm-nbsd-nat.c: Sort headers.
12447 * arm-linux-tdep.c: Sort headers.
12448 * arm-linux-nat.c: Sort headers.
12449 * arm-fbsd-tdep.c: Sort headers.
12450 * arm-fbsd-nat.c: Sort headers.
12451 * arm-bsd-tdep.c: Sort headers.
12452 * arch-utils.c: Sort headers.
12453 * arc-tdep.c: Sort headers.
12454 * arc-newlib-tdep.c: Sort headers.
12455 * annotate.h: Sort headers.
12456 * annotate.c: Sort headers.
12457 * amd64-windows-tdep.c: Sort headers.
12458 * amd64-windows-nat.c: Sort headers.
12459 * amd64-tdep.c: Sort headers.
12460 * amd64-sol2-tdep.c: Sort headers.
12461 * amd64-obsd-tdep.c: Sort headers.
12462 * amd64-obsd-nat.c: Sort headers.
12463 * amd64-nbsd-tdep.c: Sort headers.
12464 * amd64-nbsd-nat.c: Sort headers.
12465 * amd64-nat.c: Sort headers.
12466 * amd64-linux-tdep.c: Sort headers.
12467 * amd64-linux-nat.c: Sort headers.
12468 * amd64-fbsd-tdep.c: Sort headers.
12469 * amd64-fbsd-nat.c: Sort headers.
12470 * amd64-dicos-tdep.c: Sort headers.
12471 * amd64-darwin-tdep.c: Sort headers.
12472 * amd64-bsd-nat.c: Sort headers.
12473 * alpha-tdep.c: Sort headers.
12474 * alpha-obsd-tdep.c: Sort headers.
12475 * alpha-nbsd-tdep.c: Sort headers.
12476 * alpha-mdebug-tdep.c: Sort headers.
12477 * alpha-linux-tdep.c: Sort headers.
12478 * alpha-linux-nat.c: Sort headers.
12479 * alpha-bsd-tdep.c: Sort headers.
12480 * alpha-bsd-nat.c: Sort headers.
12481 * aix-thread.c: Sort headers.
12482 * agent.c: Sort headers.
12483 * addrmap.c: Sort headers.
12484 * ada-varobj.c: Sort headers.
12485 * ada-valprint.c: Sort headers.
12486 * ada-typeprint.c: Sort headers.
12487 * ada-tasks.c: Sort headers.
12488 * ada-lang.c: Sort headers.
12489 * aarch64-tdep.c: Sort headers.
12490 * aarch64-ravenscar-thread.c: Sort headers.
12491 * aarch64-newlib-tdep.c: Sort headers.
12492 * aarch64-linux-tdep.c: Sort headers.
12493 * aarch64-linux-nat.c: Sort headers.
12494 * aarch64-fbsd-tdep.c: Sort headers.
12495 * aarch64-fbsd-nat.c: Sort headers.
12496 * aarch32-linux-nat.c: Sort headers.
12497
124982019-04-04 Tom Tromey <tom@tromey.com>
12499
12500 * varobj.c (varobj_create): Update.
12501 * rust-exp.y (struct rust_parser) <update_innermost_block,
12502 lookup_symbol>: New methods.
12503 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12504 Rename.
12505 (rust_parser::rust_lookup_type)
12506 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12507 * printcmd.c (display_command, do_one_display): Update.
12508 * parser-defs.h (struct parser_state) <parser_state>: Add
12509 "tracker" parameter.
12510 (block_tracker): New member.
12511 (class innermost_block_tracker) <innermost_block_tracker>: Add
12512 "types" parameter.
12513 <reset>: Remove method.
12514 (innermost_block): Don't declare.
12515 (null_post_parser): Update.
12516 * parse.c (innermost_block): Remove global.
12517 (write_dollar_variable): Update.
12518 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12519 Remove "tracker_types" parameter.
12520 (parse_expression): Add "tracker" parameter.
12521 (parse_expression_for_completion): Update.
12522 (null_post_parser): Add "tracker" parameter.
12523 * p-exp.y: Update rules.
12524 * m2-exp.y: Update rules.
12525 * language.h (struct language_defn) <la_post_parser>: Add
12526 "tracker" parameter.
12527 * go-exp.y: Update rules.
12528 * f-exp.y: Update rules.
12529 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12530 parameter.
12531 * d-exp.y: Update rules.
12532 * c-exp.y: Update rules.
12533 * breakpoint.c (set_breakpoint_condition): Create an
12534 innermost_block_tracker.
12535 (watch_command_1): Likewise.
12536 * ada-lang.c (resolve): Add "tracker" parameter.
12537 (resolve_subexp): Likewise.
12538 * ada-exp.y (write_var_from_sym): Update.
12539
125402019-04-04 Tom Tromey <tom@tromey.com>
12541
12542 * type-stack.h: New file.
12543 * type-stack.c: New file.
12544 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12545 type-stack.h.
12546 (insert_into_type_stack, insert_type, push_type, push_type_int)
12547 (insert_type_address_space, pop_type, pop_type_int)
12548 (pop_typelist, pop_type_stack, append_type_stack)
12549 (push_type_stack, get_type_stack, push_typelist)
12550 (follow_type_instance_flags, follow_types): Don't declare.
12551 * parse.c (type_stack): Remove global.
12552 (parse_exp_in_context): Update.
12553 (insert_into_type_stack, insert_type, push_type, push_type_int)
12554 (insert_type_address_space, pop_type, pop_type_int)
12555 (pop_typelist, pop_type_stack, append_type_stack)
12556 (push_type_stack, get_type_stack, push_typelist)
12557 (follow_type_instance_flags, follow_types): Remove (moved to
12558 type-stack.c).
12559 * f-exp.y (type_stack): New global.
12560 Update rules.
12561 (push_kind_type, f_parse): Update.
12562 * d-exp.y (type_stack): New global.
12563 Update rules.
12564 (d_parse): Update.
12565 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12566 Update rules.
12567 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12568 (HFILES_NO_SRCDIR): Add type-stack.h.
12569
125702019-04-04 Tom Tromey <tom@tromey.com>
12571
12572 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12573 (rust_parser::convert_ast_to_expression, rust_parse)
12574 (rust_lex_test_completion, rust_lex_tests): Update.
12575 * parser-defs.h (struct expr_completion_state): New.
12576 (struct parser_state) <parser_state>: Add completion parameter.
12577 <mark_struct_expression, mark_completion_tag>: New methods.
12578 <parse_completion, m_completion_state>: New members.
12579 (prefixify_expression, null_post_parser): Update.
12580 (mark_struct_expression, mark_completion_tag): Don't declare.
12581 * parse.c (parse_completion, expout_last_struct)
12582 (expout_tag_completion_type, expout_completion_name): Remove
12583 globals.
12584 (parser_state::mark_struct_expression)
12585 (parser_state::mark_completion_tag): Now methods.
12586 (prefixify_expression): Add last_struct parameter.
12587 (prefixify_subexp): Likewise.
12588 (parse_exp_1): Update.
12589 (parse_exp_in_context): Add cstate parameter. Update.
12590 (parse_expression_for_completion): Create an
12591 expr_completion_state.
12592 (null_post_parser): Add "completion" parameter.
12593 * p-exp.y: Update rules.
12594 (yylex): Update.
12595 * language.h (struct language_defn) <la_post_parser>: Add
12596 "completing" parameter.
12597 * go-exp.y: Update rules.
12598 (lex_one_token): Update.
12599 * expression.h (parse_completion): Don't declare.
12600 * d-exp.y: Update rules.
12601 (lex_one_token): Update rules.
12602 * c-exp.y: Update rules.
12603 (lex_one_token): Update.
12604 * ada-lang.c (resolve): Add "parse_completion" parameter.
12605 (resolve_subexp): Likewise.
12606 (ada_resolve_function): Likewise.
12607
126082019-04-04 Tom Tromey <tom@tromey.com>
12609
12610 * parser-defs.h (struct parser_state) <start_arglist,
12611 end_arglist>: New methods.
12612 <arglist_len, m_funcall_chain>: New members.
12613 (arglist_len, start_arglist, end_arglist): Don't declare.
12614 * parse.c (arglist_len, funcall_chain): Remove global.
12615 (start_arglist, end_arglist): Remove functions.
12616 (parse_exp_in_context): Update.
12617 * p-exp.y: Update rules.
12618 * m2-exp.y: Update rules.
12619 * go-exp.y: Update rules.
12620 * f-exp.y: Update rules.
12621 * d-exp.y: Update rules.
12622 * c-exp.y: Update rules.
12623
126242019-04-04 Tom Tromey <tom@tromey.com>
12625
12626 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12627 lex_operator, push_back>: New methods.
12628 Update all rules.
12629 (rust_parser::lex_hex, lex_escape): Rename and update.
12630 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12631 (rust_parser::lex_operator): Rename and update.
12632 (rust_parser::lex_number, rustyylex, rustyyerror)
12633 (rust_lex_test_init, rust_lex_test_sequence)
12634 (rust_lex_test_push_back, rust_lex_tests): Update.
12635 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12636 parameter.
12637 <lexptr, prev_lexptr>: New members.
12638 (lexptr, prev_lexptr): Don't declare.
12639 * parse.c (lexptr, prev_lexptr): Remove globals.
12640 (parse_exp_in_context): Update.
12641 * p-exp.y (yylex, yyerror): Update.
12642 * m2-exp.y (parse_number, yylex, yyerror): Update.
12643 * go-exp.y (lex_one_token, yyerror): Update.
12644 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12645 * d-exp.y (lex_one_token, yyerror): Update.
12646 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12647 (lex_one_token, yyerror): Update.
12648 * ada-lex.l (YY_INPUT): Update.
12649 (rewind_to_char): Update.
12650 * ada-exp.y (yyerror): Update.
12651
126522019-04-04 Tom Tromey <tom@tromey.com>
12653
12654 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12655 * parser-defs.h (struct parser_state) <parser_state>: Add new
12656 parameter.
12657 <comma_terminates>: New member.
12658 (comma_terminates): Don't declare global.
12659 * parse.c (comma_terminates): Remove global.
12660 (parse_exp_in_context): Update.
12661 * p-exp.y (yylex): Update.
12662 * m2-exp.y (yylex): Update.
12663 * go-exp.y (lex_one_token): Update.
12664 * f-exp.y (yylex): Update.
12665 * d-exp.y (lex_one_token): Update.
12666 * c-exp.y (lex_one_token): Update.
12667 * ada-lex.l: Update.
12668
126692019-04-04 Tom Tromey <tom@tromey.com>
12670
12671 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12672 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12673 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12674 * parser-defs.h (paren_depth): Don't declare.
12675 * parse.c (paren_depth): Remove global.
12676 (parse_exp_in_context): Update.
12677 * p-exp.y (paren_depth): New global.
12678 (pascal_parse): Initialize it.
12679 * m2-exp.y (paren_depth): New global.
12680 (m2_parse): Initialize it.
12681 * go-exp.y (paren_depth): New global.
12682 (go_parse): Initialize it.
12683 * f-exp.y (paren_depth): New global.
12684 (f_parse): Initialize it.
12685 * d-exp.y (paren_depth): New global.
12686 (d_parse): Initialize it.
12687 * c-exp.y (paren_depth): New global.
12688 (c_parse): Initialize it.
12689 * ada-lex.l (paren_depth): New global.
12690 (lexer_init): Initialize it.
12691
126922019-04-04 Tom Tromey <tom@tromey.com>
12693
12694 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12695 (rust_parser::convert_ast_to_type)
12696 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12697 * parser-defs.h (struct parser_state) <parser_state>: Add
12698 parameters. Initialize new members.
12699 <expression_context_block, expression_context_pc>: New members.
12700 * parse.c (expression_context_block, expression_context_pc):
12701 Remove globals.
12702 (parse_exp_in_context): Update.
12703 * p-exp.y: Update all rules.
12704 (yylex): Update.
12705 * m2-exp.y: Update all rules.
12706 (yylex): Update.
12707 * go-exp.y (yylex): Update.
12708 * f-exp.y (yylex): Update.
12709 * d-exp.y: Update all rules.
12710 (yylex): Update.
12711 * c-exp.y: Update all rules.
12712 (lex_one_token, classify_name, yylex, c_parse): Update.
12713 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12714
127152019-04-04 Tom Tromey <tom@tromey.com>
12716
12717 * gdbarch.h, gdbarch.c: Rebuild.
12718 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12719 * stap-probe.h:
12720 (struct stap_parse_info): Replace "parser_state" with
12721 "expr_builder".
12722 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12723 (parser_state): New class.
12724 * parse.c (expr_builder): Rename.
12725 (expr_builder::release): Rename.
12726 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12727 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12728 (write_exp_elt_longcst, write_exp_elt_floatcst)
12729 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12730 (write_exp_string_vector, write_exp_bitstring)
12731 (write_exp_msymbol, mark_struct_expression)
12732 (write_dollar_variable)
12733 (insert_type_address_space, increase_expout_size): Replace
12734 "parser_state" with "expr_builder".
12735 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12736 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12737 "parser_state" with "expr_builder".
12738
127392019-04-04 Tom Tromey <tom@tromey.com>
12740
12741 * rust-exp.y: Replace "parse_language" with method call.
12742 * p-exp.y:
12743 (yylex): Replace "parse_language" with method call.
12744 * m2-exp.y:
12745 (yylex): Replace "parse_language" with method call.
12746 * go-exp.y (classify_name): Replace "parse_language" with method
12747 call.
12748 * f-exp.y (yylex): Replace "parse_language" with method call.
12749 * d-exp.y (lex_one_token): Replace "parse_language" with method
12750 call.
12751 * c-exp.y:
12752 (lex_one_token, classify_name, yylex): Replace "parse_language"
12753 with method call.
12754 * ada-exp.y (find_primitive_type, type_char)
12755 (type_system_address): Replace "parse_language" with method call.
12756
127572019-04-04 Tom Tromey <tom@tromey.com>
12758
12759 * rust-exp.y: Replace "parse_gdbarch" with method call.
12760 * parse.c (write_dollar_variable, insert_type_address_space):
12761 Replace "parse_gdbarch" with method call.
12762 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12763 call.
12764 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12765 call.
12766 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12767 "parse_gdbarch" with method call.
12768 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12769 with method call.
12770 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12771 "parse_gdbarch" with method call.
12772 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12773 "parse_gdbarch" with method call.
12774 * c-exp.y (parse_type, parse_number, classify_name): Replace
12775 "parse_gdbarch" with method call.
12776 * ada-lex.l: Replace "parse_gdbarch" with method call.
12777 * ada-exp.y (parse_type, find_primitive_type, type_char)
12778 (type_system_address): Replace "parse_gdbarch" with method call.
12779
127802019-04-04 Tom Tromey <tom@tromey.com>
12781
12782 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12783 * stap-probe.c (stap_parse_argument): Update.
12784 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12785 initial_size parameter.
12786 * rust-exp.y (rust_lex_tests): Update.
12787 * parse.c (parser_state): Update.
12788 (parse_exp_in_context): Update.
12789 * parser-defs.h (struct parser_state) <parser_state>: Remove
12790 "initial_size" parameter.
12791
127922019-04-04 Tom Tromey <tom@tromey.com>
12793
12794 * parser-defs.h (increase_expout_size): Don't declare.
12795 * parse.c (increase_expout_size): Now static.
12796
127972019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12798
12799 * gnu-nat.c (gnu_nat_target::wait): Fix
12800 target_waitstatus_to_string call.
12801
128022019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12803
12804 * eval.c (evaluate_subexp_standard): Handle internal functions
12805 during Fortran function call handling.
12806
128072019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12808
12809 * NEWS: Mention new internal functions.
12810 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12811 (read_base_type): Use dwarf2_init_complex_target_type.
12812 * value.c (creal_internal_fn): New function.
12813 (cimag_internal_fn): New function.
12814 (_initialize_values): Register new internal functions.
12815
128162019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12817
12818 * infrun.c (stop_all_threads): If debug_infrun, always
12819 trace the wait status after wait_one, using
12820 target_waitstatus_to_string and target_pid_to_str.
12821 (handle_inferior_event): Replace various trace of
12822 wait status kind by a single trace.
12823 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12824 wait status kind image by target_waitstatus_to_string.
12825 * target/waitstatus.c (target_waitstatus_to_string): Fix
12826 obsolete comment.
12827
128282019-04-01 Tom Tromey <tromey@adacore.com>
12829
12830 PR symtab/23331:
12831 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12832
128332019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12834 Pedro Alves <palves@redhat.com>
12835
12836 * top.c (quit_force): Call 'finalize_values'.
12837 * value.c (finalize_values): New function.
12838 * value.h (finalize_values): Declare.
12839
128402019-03-30 Eli Zaretskii <eliz@gnu.org>
12841
12842 * NEWS: Announce $_gdb_major and $_gdb_minor.
12843
12844 * top.c (init_gdb_version_vars): New function.
12845 (gdb_init): Call init_gdb_version_vars.
12846
128472019-03-29 Tom Tromey <tromey@adacore.com>
12848
12849 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12850 help text. Remove dead code.
12851
128522019-03-29 Keith Seitz <keiths@redhat.com>
12853
12854 From Siddhesh Poyarekar:
12855 * f-lang.h (f77_get_upperbound): Return LONGEST.
12856 (f77_get_lowerbound): Likewise.
12857 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12858 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12859 print them.
12860 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12861 plongest to format print it.
12862 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12863 (f77_get_upperbound): Likewise.
12864 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12865 LOWER_BOUND to LONGEST.
12866 (f77_create_arrayprint_offset_tbl): Likewise.
12867
128682019-03-29 Keith Seitz <keiths@redhat.com>
12869
12870 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12871 %s/pulongest for TYPE_LENGTH instead of %d in format
12872 strings.
12873 * ada-typerint.c (ada_print_type): Likewise.
12874 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12875 * compile/compile-c-support.c (generate_register_struct): Likewise.
12876 * gdbtypes.c (recursive_dump_type): Likewise.
12877 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12878 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12879 instead of %d in format strings.
12880 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12881 to std::min to ULONGEST.
12882 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12883 instead of %d in format strings.
12884 * tracepoint.c (info_scope_command): Likewise.
12885 * typeprint.c (print_offset_data::update)
12886 (print_offset_data::finish): Likewise.
12887 * xtensa-tdep.c (xtensa_store_return_value)
12888 (xtensa_push_dummy_call): Likewise.
12889
128902019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12891
12892 * windows-nat.c (display_selector): Fixed format specifications
12893 for 64-bit Cygwin.
12894
128952019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12896
12897 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12898
128992019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12900
12901 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12902 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12903 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12904 (nios2_linux_init_abi): Install it.
12905
129062019-03-28 Alan Hayward <alan.hayward@arm.com>
12907
12908 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12909
129102019-03-28 Alan Hayward <alan.hayward@arm.com>
12911
12912 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12913
129142019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12915 Tom Tromey <tromey@adacore.com>
12916
12917 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12918
129192019-03-26 Joel Brobecker <brobecker@adacore.com>
12920
12921 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12922 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12923 method to compute the bounds of range types. Also print "[evaluated]"
12924 if the bounds' values come from a dynamic evaluation.
12925
129262019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12927
12928 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12929 whitespace when pretty printing is on.
12930
129312019-03-26 Alan Hayward <alan.hayward@arm.com>
12932
12933 * ppc-linux-nat.c: Add include.
12934
129352019-03-26 Alan Hayward <alan.hayward@arm.com>
12936
12937 * NEWS: Mention AArch64 Pointer Authentication.
12938
129392019-03-26 Alan Hayward <alan.hayward@arm.com>
12940
12941 * arm-linux-nat.c: Add include.
12942
129432019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12944
12945 * source-cache.c (source_cache::get_source_lines): Re-read
12946 fullname after calling open_source_file.
12947
129482019-03-25 John Baldwin <jhb@FreeBSD.org>
12949
12950 * NEWS: Mention TLS support for FreeBSD.
12951
129522019-03-25 Tom Tromey <tromey@adacore.com>
12953
12954 * minsyms.c (BUNCH_SIZE): Update comment.
12955 (~minimal_symbol_reader): Remove old comment.
12956 (compact_minimal_symbols): Update comment.
12957 (minimal_symbol_reader::install): Remove old comment. Update
12958 other comments.
12959
129602019-03-25 Alan Hayward <alan.hayward@arm.com>
12961
12962 * s390-linux-nat.c: Add include.
12963
129642019-03-25 Alan Hayward <alan.hayward@arm.com>
12965
12966 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12967 Call linux_get_hwcap.
12968 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12969 Likewise.
12970 (aarch64_linux_get_hwcap): Remove function.
12971 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12972 declaration.
12973 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12974 linux_get_hwcap.
12975 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12976 * linux-tdep.c (linux_get_hwcap): Add function.
12977 (linux_get_hwcap2): Likewise.
12978 * linux-tdep.h (linux_get_hwcap): Add declaration.
12979 (linux_get_hwcap2): Likewise.
12980 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12981 (ppc_linux_get_hwcap2): Likewise.
12982 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12983 linux_get_hwcap.
12984 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12985 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12986 (ppc_linux_nat_target::read_description): Likewise.
12987 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12988 * s390-linux-nat.c: Likewise.
12989 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12990
129912019-03-24 Tom Tromey <tom@tromey.com>
12992
12993 * ada-lang.c (standard_lookup): Simplify initialization.
12994 (ada_lookup_symbol_nonlocal): Simplify return.
12995 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12996 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12997 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12998 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12999 initialization.
13000 * solib.c (solib_global_lookup): Simplify.
13001 * symtab.c (null_block_symbol): Remove.
13002 (symbol_cache_lookup): Simplify returns.
13003 (lookup_language_this): Simplify returns.
13004 (lookup_symbol_aux): Simplify return.
13005 (lookup_local_symbol): Simplify returns.
13006 (lookup_global_symbol_from_objfile): Simplify return.
13007 (lookup_symbol_in_objfile_symtabs)
13008 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13009 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13010 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13011 * cp-namespace.c (cp_lookup_bare_symbol)
13012 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13013 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13014 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13015 (cp_lookup_symbol_via_imports): Simplify initialization.
13016 (find_symbol_in_baseclass): Likewise.
13017 * symtab.h (null_block_symbol): Remove.
13018 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13019 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13020 (d_lookup_symbol_module): Likewise.
13021 (find_symbol_in_baseclass): Simplify initialization.
13022
130232019-03-24 Tom Tromey <tom@tromey.com>
13024
13025 * expression.h: Don't include symtab.h.
13026 (struct block): Forward declare.
13027
130282019-03-24 Tom Tromey <tom@tromey.com>
13029
13030 * c-exp.y (typebase): Remove casts.
13031 * gdbtypes.c (lookup_unsigned_typename, )
13032 (lookup_signed_typename): Remove cast.
13033 * eval.c (parse_to_comma_and_eval): Remove cast.
13034 * parse.c (write_dollar_variable): Remove cast.
13035 * block.h (struct block) <superblock>: Now const.
13036 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13037 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13038 (map_block): Make "block" const.
13039 * symfile.h (struct quick_symbol_functions)
13040 <map_matching_symbols>: Constify block argument to "callback".
13041 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13042 const.
13043 (find_pc_sect_compunit_symtab): Make "b" const.
13044 (find_symbol_at_address): Likewise.
13045 (search_symbols): Likewise.
13046 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13047 (dw2_debug_names_lookup_symbol): Likewise.
13048 (dw2_map_matching_symbols): Update.
13049 * p-valprint.c (pascal_val_print): Remove "block".
13050 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13051 (aux_add_nonlocal_symbols): Make "block" const.
13052 (resolve_subexp): Remove cast.
13053 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13054 const.
13055 (iterate_over_file_blocks): Likewise.
13056 * f-exp.y (%union) <bval>: Remove.
13057 * coffread.c (patch_opaque_types): Make "b" const.
13058 * spu-tdep.c (spu_catch_start): Make "block" const.
13059 * c-valprint.c (print_unpacked_pointer): Remove "block".
13060 * symmisc.c (dump_symtab_1): Make "b" const.
13061 (block_depth): Make "block" const.
13062 * d-exp.y (%union) <bval>: Remove.
13063 * cp-support.h (cp_lookup_rtti_type): Update.
13064 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13065 * psymtab.c (psym_lookup_symbol): Make "block" const.
13066 (maintenance_check_psymtabs): Make "b" const.
13067 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13068 (enumerate_locals, enumerate_args): Update.
13069 * python/py-symtab.c (stpy_global_block): Make "block" const.
13070 (stpy_static_block): Likewise.
13071 * inline-frame.c (block_starting_point_at): Make "new_block"
13072 const.
13073 * block.c (find_block_in_blockvector): Make return type const.
13074 (blockvector_for_pc_sect): Make "b" const.
13075 (find_block_in_blockvector): Make "b" const.
13076
130772019-03-23 Tom Tromey <tom@tromey.com>
13078
13079 * varobj.c (varobj_create): Update.
13080 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13081 * printcmd.c (display_command, do_one_display): Don't reset
13082 innermost_block.
13083 * parser-defs.h (enum innermost_block_tracker_type): Move to
13084 expression.h.
13085 (innermost_block): Update comment.
13086 * parse.c (parse_exp_1): Add tracker_types parameter.
13087 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13088 tracker_types parameter. Reset innermost_block.
13089 (parse_exp_in_context): Remove.
13090 (parse_expression_for_completion): Update.
13091 * objfiles.c (~objfile): Don't reset expression_context_block or
13092 innermost_block.
13093 * expression.h (enum innermost_block_tracker_type): Move from
13094 parser-defs.h.
13095 (parse_exp_1): Add tracker_types parameter.
13096 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13097 reset innermost_block.
13098
130992019-03-23 Tom Tromey <tom@tromey.com>
13100
13101 * objfiles.h: Include bcache.h.
13102
131032019-03-23 Tom Tromey <tom@tromey.com>
13104
13105 * linespec.c (get_current_search_block): Use
13106 scoped_restore_current_language.
13107 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13108
131092019-03-22 Alan Hayward <alan.hayward@arm.com>
13110 Jiong Wang <jiong.wang@arm.com>
13111
13112 * aarch64-linux-tdep.c
13113 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13114 section.
13115 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13116
131172019-03-22 Alan Hayward <alan.hayward@arm.com>
13118 Jiong Wang <jiong.wang@arm.com>
13119
13120 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13121 instructions.
13122 (aarch64_analyze_prologue_test): Add PACIASP test.
13123 (aarch64_prologue_prev_register): Unmask PC value.
13124
131252019-03-22 Alan Hayward <alan.hayward@arm.com>
13126 Jiong Wang <jiong.wang@arm.com>
13127
13128 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13129 (aarch64_dwarf2_prev_register): Unmask PC value.
13130 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13131 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13132 DW_CFA_AARCH64_negate_ra_state.
13133 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13134
131352019-03-22 Alan Hayward <alan.hayward@arm.com>
13136 Jiong Wang <jiong.wang@arm.com>
13137
13138 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13139 registers.
13140 (aarch64_pseudo_register_name): Likewise.
13141 (aarch64_pseudo_register_type): Likewise.
13142 (aarch64_pseudo_register_reggroup_p): Likewise.
13143 (aarch64_gdbarch_init): Add pauth registers.
13144 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13145 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13146 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13147 (struct gdbarch_tdep): Add regnum for ra_state.
13148
131492019-03-22 Alan Hayward <alan.hayward@arm.com>
13150 Jiong Wang <jiong.wang@arm.com>
13151
13152 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13153
131542019-03-22 Alan Hayward <alan.hayward@arm.com>
13155 Jiong Wang <jiong.wang@arm.com>
13156
13157 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13158 function.
13159 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13160 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13161 (aarch64_gdbarch_init): Add puth registers.
13162 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13163 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13164 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13165
131662019-03-22 Alan Hayward <alan.hayward@arm.com>
13167 Jiong Wang <jiong.wang@arm.com>
13168
13169 * aarch64-linux-nat.c
13170 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13171 * aarch64-linux-tdep.c
13172 (aarch64_linux_core_read_description): Likewise.
13173 (aarch64_linux_get_hwcap): New function.
13174 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13175 (aarch64_linux_get_hwcap): New declaration.
13176
131772019-03-22 Alan Hayward <alan.hayward@arm.com>
13178 Jiong Wang <jiong.wang@arm.com>
13179
13180 * aarch64-linux-nat.c
13181 (aarch64_linux_nat_target::read_description): Add pauth param.
13182 * aarch64-linux-tdep.c
13183 (aarch64_linux_core_read_description): Likewise.
13184 * aarch64-tdep.c (struct target_desc): Add in pauth.
13185 (aarch64_read_description): Add pauth param.
13186 (aarch64_gdbarch_init): Likewise.
13187 * aarch64-tdep.h (aarch64_read_description): Likewise.
13188 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13189 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13190 * features/Makefile: Add new files.
13191 * features/aarch64-pauth.c: New file.
13192 * features/aarch64-pauth.xml: New file.
13193
131942019-03-20 Tom Tromey <tromey@adacore.com>
13195
13196 * infrun.c (handle_inferior_event): Rename from
13197 handle_inferior_event_1. Create a scoped_value_mark.
13198 (handle_inferior_event): Remove.
13199
132002019-03-19 Tom Tromey <tromey@adacore.com>
13201
13202 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13203 * infrun.h (print_stop_event): Add "displays" parameter.
13204 * infrun.c (print_stop_event): Add "displays" parameter.
13205
132062019-03-19 Pedro Alves <palves@redhat.com>
13207
13208 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13209 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13210 to -1. Fix TABs vs spaces.
13211 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13212 * tui/tui-out.h (tui_ui_out) Add intro comments.
13213 <m_line, m_start_of_line>: In-class initialize, and add describing
13214 comment.
13215
132162019-03-18 Alan Hayward <alan.hayward@arm.com>
13217
13218 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13219 variable names.
13220 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13221
132222019-03-18 Pedro Alves <palves@redhat.com>
13223 Eli Zaretskii <eliz@gnu.org>
13224
13225 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13226 m_line and m_start_of_line.
13227
132282019-03-18 Eli Zaretskii <eliz@gnu.org>
13229
13230 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13231 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13232 it returns a newline. This fixes a regression in TU mode, whereby
13233 the next line is output on the same screen line as the user input.
13234
132352019-03-18 Tom Tromey <tromey@adacore.com>
13236
13237 * minsyms.c (minimal_symbol_reader::install): Remove call to
13238 obstack_blank.
13239
132402019-03-18 Pedro Alves <palves@redhat.com>
13241
13242 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13243 New globals.
13244 (apply_style): New, factored out from ...
13245 (apply_ansi_escape): ... this. Handle reverse video mode.
13246 (tui_set_reverse_mode): New function.
13247 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13248 * tui/tui-winsource.c (tui_show_source_line): Use
13249 tui_set_reverse_mode instead of setting A_STANDOUT.
13250 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13251 New setter methods.
13252
132532019-03-18 Hannes Domani <ssbssa@yahoo.de>
13254
13255 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13256 Handle tabs.
13257
132582019-03-18 Tom Tromey <tromey@adacore.com>
13259
13260 * ada-lang.c (empty_array): Add "high" parameter.
13261 (ada_evaluate_subexp): Update.
13262
132632019-03-17 Sergei Trofimovich <siarheit@google.com>
13264
13265 * unittests/string_view-selftests.c: Define
13266 _initialize_string_view_selftests unconditionally.
13267
132682019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13269
13270 PR gdb/24350
13271 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13272
132732019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13274
13275 PR gdb/24351
13276 * windows-nat.c (display_selector): Fix format specifiers.
13277
132782019-03-17 Eli Zaretskii <eliz@gnu.org>
13279
13280 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13281 tui_refill_source_window instead of tui_refresh_win, to update the
13282 current execution line. This fixes redisplay of the current line
13283 when stepping through the code with "next" or "step".
13284
132852019-03-16 Eli Zaretskii <eliz@gnu.org>
13286
13287 * source-cache.c (source_cache::get_source_lines): Call
13288 find_source_lines to initialize s->nlines. This fixes vertical
13289 scrolling of TUI source window when the DOWN arrow is pressed.
13290
132912019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13292
13293 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13294 linux-thread-db.c (_initialize_thread_db): Likewise.
13295
132962019-03-16 Eli Zaretskii <eliz@gnu.org>
13297
13298 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13299 wclrtoeol in tui_show_source_line". This reverts changes made in
13300 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13301
133022019-03-15 Tom Tromey <tom@tromey.com>
13303
13304 * symtab.h (struct minimal_symbol): Derive from
13305 general_symbol_info.
13306 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13307 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13308 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13309 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13310 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13311 (MSYMBOL_SEARCH_NAME): Update.
13312 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13313 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13314 * minsyms.c (minimal_symbol_reader::record_full): Update.
13315
133162019-03-15 Tom Tromey <tom@tromey.com>
13317
13318 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13319
133202019-03-15 Tom Tromey <tom@tromey.com>
13321
13322 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13323 unique_xmalloc_ptr.
13324 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13325 Update.
13326 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13327 (build_minimal_symbol_hash_tables)
13328 (minimal_symbol_reader::install): Update.
13329
133302019-03-15 Tom Tromey <tom@tromey.com>
13331
13332 * symtab.c (create_demangled_names_hash): Update.
13333 (symbol_set_names): Update.
13334 * objfiles.h (struct objfile_per_bfd_storage)
13335 <demangled_names_hash>: Now an htab_up.
13336 * objfiles.c (objfile_per_bfd_storage): Simplify.
13337
133382019-03-15 Tom Tromey <tom@tromey.com>
13339
13340 * objfiles.h (struct objfile_per_bfd_storage): Declare
13341 destructor.
13342 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13343 New.
13344 (get_objfile_bfd_data): Use new. Don't initialize
13345 language_of_main.
13346 (free_objfile_per_bfd_storage): Remove.
13347 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13348
133492019-03-15 Tom Tromey <tom@tromey.com>
13350
13351 * symfile.c (reread_symbols): Update.
13352 * objfiles.c (objfile::objfile): Update.
13353 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13354 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13355 comment.
13356 (minimal_symbol_reader::install): Update.
13357 (terminate_minimal_symbol_table): Remove.
13358 * jit.c (jit_object_close_impl): Update.
13359
133602019-03-15 Tom Tromey <tom@tromey.com>
13361
13362 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13363 initializations.
13364
133652019-03-15 Tom Tromey <tom@tromey.com>
13366
13367 * objfiles.h (struct objfile_per_bfd_storage)
13368 <demangled_hash_languages>: Now a bitset.
13369 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13370 (lookup_minimal_symbol): Update.
13371
133722019-03-15 Tom Tromey <tom@tromey.com>
13373
13374 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13375 Don't return the symbol.
13376 * coffread.c (record_minimal_symbol): Use record_full.
13377
133782019-03-14 Eli Zaretskii <eliz@gnu.org>
13379
13380 The MS-Windows port of ncurses fails to switch to a color pair if
13381 one or both of the colors are the implicit default colors. This
13382 change records the default colors when TUI is initialized, and
13383 then specifies them explicitly when a color pair uses the default
13384 colors. This allows color styling in TUI mode on MS-Windows.
13385
13386 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13387 ncurses_norm_attr.
13388 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13389 colors in ncurses_norm_attr.
13390 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13391 "none", replace it with the default color recorded in
13392 ncurses_norm_attr.
13393
133942019-03-14 Tom Tromey <tromey@adacore.com>
13395
13396 * source-cache.h (class source_cache) <get_source_lines>: Return
13397 std::string.
13398 * source-cache.c (source_cache::extract_lines): Handle case where
13399 first_pos==npos. Return std::string.
13400 (source_cache::get_source_lines): Update.
13401
134022019-03-14 Tom Tromey <tromey@adacore.com>
13403
13404 * NEWS: Add item for "style sources" commands.
13405 * source-cache.c (source_cache::get_source_lines): Check
13406 source_styling.
13407 * cli/cli-style.c (source_styling): New global.
13408 (_initialize_cli_style): Add "style sources" commands.
13409 (show_style_sources): New function.
13410 * cli/cli-style.h (source_styling): Declare.
13411
134122019-03-14 Pedro Alves <palves@redhat.com>
13413 Tom Tromey <tromey@adacore.com>
13414
13415 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13416 * tui/tui-winsource.c (tui_refill_source_window): New function,
13417 from...
13418 (tui_horizontal_source_scroll): ... here. Move some logic.
13419 * cli/cli-style.c (set_style_enabled): Notify new observable.
13420 * tui/tui-hooks.c (tui_redisplay_source): New function.
13421 (tui_attach_detach_observers): Attach or detach
13422 tui_redisplay_source.
13423 * observable.h (source_styling_changed): New observable.
13424 * observable.c: Define source_styling_changed observable.
13425
134262019-03-13 Tom Tromey <tromey@adacore.com>
13427
13428 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13429 (i386_gnu_nat_target::store_registers): Update.
13430 * target-debug.h (target_debug_print_std_string): New macro.
13431 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13432 * windows-tdep.c (display_one_tib): Update.
13433 * tui/tui-stack.c (tui_make_status_line): Update.
13434 * top.c (print_inferior_quit_action): Update.
13435 * thread.c (thr_try_catch_cmd): Update.
13436 (add_thread_with_info): Update.
13437 (thread_target_id_str): Update.
13438 (thr_try_catch_cmd): Update.
13439 (thread_command): Update.
13440 (thread_find_command): Update.
13441 * record-btrace.c (record_btrace_target::info_record)
13442 (record_btrace_resume_thread, record_btrace_target::resume)
13443 (record_btrace_cancel_resume, record_btrace_step_thread)
13444 (record_btrace_target::wait, record_btrace_target::wait)
13445 (record_btrace_target::wait, record_btrace_target::stop): Update.
13446 * progspace.c (print_program_space): Update.
13447 * process-stratum-target.c
13448 (process_stratum_target::thread_address_space): Update.
13449 * linux-fork.c (linux_fork_mourn_inferior)
13450 (detach_checkpoint_command, info_checkpoints_command)
13451 (linux_fork_context): Update.
13452 (linux_fork_detach): Update.
13453 (class scoped_switch_fork_info): Update.
13454 (delete_checkpoint_command): Update.
13455 * infrun.c (follow_fork_inferior): Update.
13456 (follow_fork_inferior): Update.
13457 (proceed_after_vfork_done): Update.
13458 (handle_vfork_child_exec_or_exit): Update.
13459 (follow_exec): Update.
13460 (displaced_step_prepare_throw): Update.
13461 (displaced_step_restore): Update.
13462 (start_step_over): Update.
13463 (resume_1): Update.
13464 (clear_proceed_status_thread): Update.
13465 (proceed): Update.
13466 (print_target_wait_results): Update.
13467 (do_target_wait): Update.
13468 (context_switch): Update.
13469 (stop_all_threads): Update.
13470 (restart_threads): Update.
13471 (finish_step_over): Update.
13472 (handle_signal_stop): Update.
13473 (switch_back_to_stepped_thread): Update.
13474 (keep_going_pass_signal): Update.
13475 (print_exited_reason): Update.
13476 (normal_stop): Update.
13477 * inferior.c (inferior_pid_to_str): Change return type.
13478 (print_selected_inferior): Update.
13479 (add_inferior): Update.
13480 (detach_inferior): Update.
13481 * dummy-frame.c (fprint_dummy_frames): Update.
13482 * dcache.c (dcache_info_1): Update.
13483 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13484 (btrace_fetch, btrace_clear): Update.
13485 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13486 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13487 type.
13488 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13489 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13490 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13491 * gdbarch.c, gdbarch.h: Rebuild.
13492 * gdbarch.sh (core_pid_to_str): Change return type.
13493 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13494 return type.
13495 (windows_nat_target::pid_to_str): Change return type.
13496 (windows_delete_thread): Update.
13497 (windows_nat_target::attach): Update.
13498 (windows_nat_target::files_info): Update.
13499 * target-delegates.c: Rebuild.
13500 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13501 return type.
13502 (sol_thread_target::pid_to_str): Change return type.
13503 * remote.c (class remote_target) <pid_to_str>: Change return
13504 type.
13505 (remote_target::pid_to_str): Change return type.
13506 (extended_remote_target::attach, remote_target::remote_stop_ns)
13507 (remote_target::remote_notif_remove_queued_reply)
13508 (remote_target::push_stop_reply, remote_target::disable_btrace):
13509 Update.
13510 (extended_remote_target::attach): Update.
13511 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13512 type.
13513 (gdbsim_target::pid_to_str): Change return type.
13514 * ravenscar-thread.c (struct ravenscar_thread_target)
13515 <pid_to_str>: Change return type.
13516 (ravenscar_thread_target::pid_to_str): Change return type.
13517 * procfs.c (class procfs_target) <pid_to_str>: Change return
13518 type.
13519 (procfs_target::pid_to_str): Change return type.
13520 (procfs_target::attach): Update.
13521 (procfs_target::detach): Update.
13522 (procfs_target::fetch_registers): Update.
13523 (procfs_target::store_registers): Update.
13524 (procfs_target::wait): Update.
13525 (procfs_target::files_info): Update.
13526 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13527 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13528 return type.
13529 (nto_procfs_target::pid_to_str): Change return type.
13530 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13531 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13532 return type.
13533 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13534 (exit_lwp): Update.
13535 (attach_proc_task_lwp_callback, get_detach_signal)
13536 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13537 (linux_nat_target::resume, wait_lwp, stop_callback)
13538 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13539 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13540 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13541 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13542 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13543 type.
13544 (inf_ptrace_target::attach): Update.
13545 (inf_ptrace_target::files_info): Update.
13546 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13547 type.
13548 (go32_nat_target::pid_to_str): Change return type.
13549 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13550 (gnu_nat_target::wait): Update.
13551 (gnu_nat_target::wait): Update.
13552 (gnu_nat_target::resume): Update.
13553 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13554 (fbsd_nat_target::wait): Update.
13555 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13556 type.
13557 (darwin_nat_target::attach): Update.
13558 * corelow.c (class core_target) <pid_to_str>: Change return type.
13559 (core_target::pid_to_str): Change return type.
13560 * target.c (normal_pid_to_str): Change return type.
13561 (default_pid_to_str): Likewise.
13562 (target_pid_to_str): Change return type.
13563 (target_translate_tls_address): Update.
13564 (target_announce_detach): Update.
13565 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13566 return type.
13567 (bsd_uthread_target::pid_to_str): Change return type.
13568 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13569 type.
13570 (bsd_kvm_target::pid_to_str): Change return type.
13571 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13572 return type.
13573 (aix_thread_target::pid_to_str): Change return type.
13574 * target.h (struct target_ops) <pid_to_str>: Change return type.
13575 (target_pid_to_str, normal_pid_to_str): Likewise.
13576 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13577 type.
13578 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13579 type.
13580 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13581 return type.
13582 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13583 type.
13584 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13585 type.
13586 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13587 return type.
13588
135892019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13590
13591 * NEWS: Mention that the new default MI version is 3. Mention
13592 changes to the output of commands and events that deal with
13593 multi-location breakpoints.
13594 * breakpoint.c: Include "mi/mi-out.h".
13595 (print_one_breakpoint): Change output syntax if using MI version
13596 >= 3.
13597 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13598 New.
13599 (mi_multi_location_breakpoint_output_fixed): New.
13600 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13601 (mi_cmd_fix_multi_location_breakpoint_output): New.
13602 (mi_multi_location_breakpoint_output_fixed): New.
13603 * mi/mi-cmds.c (mi_cmds): Register command
13604 -fix-multi-location-breakpoint-output.
13605 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13606 interpreter "mi".
13607
136082019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13609
13610 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13611 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13612 instantiate mi_ui_out based on interpreter name.
13613 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13614 * mi/mi-main.c (mi_load_progress): Likewise.
13615
136162019-03-12 John Baldwin <jhb@FreeBSD.org>
13617
13618 * NEWS: Combine separate "New targets" sections for 8.3.
13619
136202019-03-12 John Baldwin <jhb@FreeBSD.org>
13621
13622 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13623 (ppcfbsd_init_abi): Install gdbarch
13624 "fetch_tls_load_module_address" and "get_thread_local_address"
13625 methods.
13626
136272019-03-12 John Baldwin <jhb@FreeBSD.org>
13628
13629 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13630 (riscv_fbsd_init_abi): Install gdbarch
13631 "fetch_tls_load_module_address" and "get_thread_local_address"
13632 methods.
13633
136342019-03-12 John Baldwin <jhb@FreeBSD.org>
13635
13636 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13637 (i386fbsd_init_abi): Install gdbarch
13638 "fetch_tls_load_module_address" and "get_thread_local_address"
13639 methods.
13640
136412019-03-12 John Baldwin <jhb@FreeBSD.org>
13642
13643 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13644 (amd64fbsd_init_abi): Install gdbarch
13645 "fetch_tls_load_module_address" and "get_thread_local_address"
13646 methods.
13647
136482019-03-12 John Baldwin <jhb@FreeBSD.org>
13649
13650 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13651 (struct fbsd_pspace_data): New type.
13652 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13653 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13654 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13655 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13656 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13657
136582019-03-12 John Baldwin <jhb@FreeBSD.org>
13659
13660 * gdbtypes.c (lookup_struct_elt): New function.
13661 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13662 * gdbtypes.h (struct struct_elt): New type.
13663 (lookup_struct_elt): New prototype.
13664
136652019-03-12 John Baldwin <jhb@FreeBSD.org>
13666
13667 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13668 remove disabled code block.
13669
136702019-03-12 John Baldwin <jhb@FreeBSD.org>
13671
13672 * gdbarch.sh (get_thread_local_address): New method.
13673 * gdbarch.h, gdbarch.c: Regenerate.
13674 * target.c (target_translate_tls_address): Use
13675 gdbarch_get_thread_local_address if present instead of
13676 target::get_thread_local_address.
13677
136782019-03-12 John Baldwin <jhb@FreeBSD.org>
13679
13680 * target.h (target::get_thread_local_address): Update comment.
13681
136822019-03-12 John Baldwin <jhb@FreeBSD.org>
13683
13684 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13685 objfile->separate_debug_objfile_backlink if not NULL.
13686
136872019-03-12 John Baldwin <jhb@FreeBSD.org>
13688
13689 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13690 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13691 (amd64bsd_store_inferior_registers): Likewise.
13692 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13693 Enable segment base registers.
13694 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13695 PT_GETFSBASE and PT_GETGSBASE.
13696 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13697 PT_SETGSBASE.
13698 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13699 segment base registers.
13700 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13701
137022019-03-12 John Baldwin <jhb@FreeBSD.org>
13703
13704 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13705 Update calls to i386_target_description to add 'segments'
13706 parameter.
13707 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13708 add segment base registers.
13709 * arch/i386.c (i386_create_target_description): Add 'segments'
13710 parameter to enable segment base registers.
13711 * arch/i386.h (i386_create_target_description): Likewise.
13712 * features/i386/32bit-segments.xml: New file.
13713 * features/i386/32bit-segments.c: Generate.
13714 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13715 call to i386_target_description to add 'segments' parameter.
13716 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13717 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13718 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13719 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13720 if feature is present.
13721 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13722 Add 'segments' parameter to call to i386_target_description.
13723 (i386_target_description): Add 'segments' parameter to enable
13724 segment base registers.
13725 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13726 to call to i386_target_description.
13727 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13728 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13729 Define I386_NUM_REGS.
13730 (i386_target_description): Add 'segments' parameter to enable
13731 segment base registers.
13732
137332019-03-12 Eli Zaretskii <eliz@gnu.org>
13734
13735 PR/24325
13736 * source-cache.c: #undef open and close, to avoid unresolved
13737 externals during linking.
13738
137392019-03-12 Tom Tromey <tromey@adacore.com>
13740
13741 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13742 const. Add initializers.
13743 (_initialize_remote): Don't initialize ptid globals.
13744
137452019-03-12 Pedro Alves <palves@redhat.com>
13746
13747 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13748
137492019-03-12 Pedro Alves <palves@redhat.com>
13750
13751 * cp-name-parser.y (main): Remove unused 'len' variable.
13752
137532019-03-12 Tom Tromey <tromey@adacore.com>
13754
13755 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13756 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13757
137582019-03-12 Tom Tromey <tromey@adacore.com>
13759
13760 * linux-nat.c (iterate_over_lwps): Update.
13761 (stop_callback): Remove parameter.
13762 (stop_wait_callback, detach_callback, resume_set_callback)
13763 (select_singlestep_lwp_callback, set_ignore_sigint)
13764 (status_callback, resumed_callback, resume_clear_callback)
13765 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13766 data parameter.
13767 (linux_nat_target::detach, linux_nat_target::resume)
13768 (linux_stop_and_wait_all_lwps, select_event_lwp)
13769 (linux_nat_filter_event, linux_nat_wait_1)
13770 (linux_nat_target::kill, linux_nat_target::stop)
13771 (linux_nat_target::stop): Update.
13772 (linux_nat_resume_callback): Change type.
13773 (resume_stopped_resumed_lwps, count_events_callback)
13774 (select_event_lwp_callback): Likewise.
13775 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13776 * arm-linux-nat.c (struct update_registers_data): Remove.
13777 (update_registers_callback): Change type.
13778 (arm_linux_insert_hw_breakpoint1): Update.
13779 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13780 parameter.
13781 (x86_linux_dr_set_addr): Update.
13782 (x86_linux_dr_set_control): Update.
13783 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13784 (iterate_over_lwps): Use gdb::function_view.
13785 * nat/aarch64-linux-hw-point.c (struct
13786 aarch64_dr_update_callback_param): Remove.
13787 (debug_reg_change_callback): Change type.
13788 (aarch64_notify_debug_reg_change): Update.
13789 * s390-linux-nat.c (s390_refresh_per_info): Update.
13790
137912019-03-11 Tom Tromey <tromey@adacore.com>
13792
13793 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13794 redundant assignment to "this_cu".
13795
137962019-03-08 Simon Marchi <simon.marchi@efficios.com>
13797
13798 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13799
138002019-03-08 Simon Marchi <simon.marchi@efficios.com>
13801
13802 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13803 from...
13804 (rank_one_type): ... this.
13805
138062019-03-08 Simon Marchi <simon.marchi@efficios.com>
13807
13808 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13809 from...
13810 (rank_one_type): ... this.
13811
138122019-03-08 Simon Marchi <simon.marchi@efficios.com>
13813
13814 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13815 from...
13816 (rank_one_type): ... this.
13817
138182019-03-08 Simon Marchi <simon.marchi@efficios.com>
13819
13820 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13821 from...
13822 (rank_one_type): ... this.
13823
138242019-03-08 Simon Marchi <simon.marchi@efficios.com>
13825
13826 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13827 from...
13828 (rank_one_type): ... this.
13829
138302019-03-08 Simon Marchi <simon.marchi@efficios.com>
13831
13832 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13833 from...
13834 (rank_one_type): ... this.
13835
138362019-03-08 Simon Marchi <simon.marchi@efficios.com>
13837
13838 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13839 from...
13840 (rank_one_type): ... this.
13841
138422019-03-08 Simon Marchi <simon.marchi@efficios.com>
13843
13844 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13845 from...
13846 (rank_one_type): ... this.
13847
138482019-03-08 Simon Marchi <simon.marchi@efficios.com>
13849
13850 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13851 from...
13852 (rank_one_type): ... this.
13853
138542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13855
13856 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13857 from...
13858 (rank_one_type): ... this.
13859
138602019-03-08 Simon Marchi <simon.marchi@efficios.com>
13861
13862 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13863 from...
13864 (rank_one_type): ... this.
13865
138662019-03-08 Simon Marchi <simon.marchi@efficios.com>
13867
13868 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13869 from...
13870 (rank_one_type): ... this.
13871
138722019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13873
13874 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13875 inferior-events' shows the example events.
13876
138772019-03-08 Eli Zaretskii <eliz@gnu.org>
13878
13879 Support styling on native MS-Windows console
13880
13881 PR/24315
13882 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13883 on MS-Windows if $TERM is not defined.
13884
13885 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13886
13887 * posix-hdep.c (gdb_console_fputs):
13888 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13889 functions.
13890 * ui-file.h (gdb_console_fputs): Add prototype.
13891
13892 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13893 back to fputs only if the former returns zero.
13894
138952019-03-07 Tom Tromey <tom@tromey.com>
13896
13897 * symmisc.c (print_symbol_bcache_statistics): Update.
13898 (print_objfile_statistics): Update.
13899 * symfile.c (allocate_symtab): Update.
13900 * stabsread.c: Don't include bcache.h.
13901 * psymtab.h (struct psymbol_bcache): Don't declare.
13902 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13903 (psymbol_bcache_init, psymbol_bcache_free)
13904 (psymbol_bcache_get_bcache): Don't declare.
13905 * psymtab.c (struct psymbol_bcache): Remove.
13906 (psymtab_storage::psymtab_storage): Update.
13907 (psymtab_storage::~psymtab_storage): Update.
13908 (psymbol_bcache_init, psymbol_bcache_free)
13909 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13910 (add_psymbol_to_bcache): Update.
13911 (allocate_psymtab): Update.
13912 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13913 macro_cache>: No longer pointers.
13914 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13915 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13916 * macrotab.c (macro_bcache): Update.
13917 * macroexp.c: Don't include bcache.h.
13918 * gdbtypes.c (check_types_worklist): Update.
13919 (types_deeply_equal): Remove TRY/CATCH. Update.
13920 * elfread.c (elf_symtab_read): Update.
13921 * dwarf2read.c: Don't include bcache.h.
13922 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13923 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13924 (print_bcache_statistics, bcache_memory_used): Don't declare.
13925 (struct bcache): Move from bcache.c. Add constructor, destructor,
13926 methods. Rename all data members.
13927 * bcache.c (struct bcache): Move to bcache.h.
13928 (bcache::expand_hash_table): Rename from expand_hash_table.
13929 (bcache): Remove.
13930 (bcache::insert): Rename from bcache_full.
13931 (bcache::compare): Rename from bcache_compare.
13932 (bcache_xmalloc): Remove.
13933 (bcache::~bcache): Rename from bcache_xfree.
13934 (bcache::print_statistics): Rename from print_bcache_statistics.
13935 (bcache::memory_used): Rename from bcache_memory_used.
13936
139372019-03-07 Pedro Alves <palves@redhat.com>
13938
13939 * infrun.c (normal_stop): Also check for
13940 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13941
139422019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13943
13944 * f-lang.c (value_from_host_double): Moved to...
13945 * value.c (value_from_host_double): ...here.
13946 * value.h (value_from_host_double): Declare.
13947 * guile/scm-math.c (vlscm_convert_typed_number): Use
13948 value_from_host_double.
13949 (vlscm_convert_number): Likewise.
13950 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13951 * python/py-value.c (convert_value_from_python): Likewise.
13952
139532019-03-06 Tom Tromey <tom@tromey.com>
13954
13955 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13956
139572019-03-06 Tom Tromey <tom@tromey.com>
13958
13959 * utils.h (free_current_contents): Don't declare.
13960 * utils.c (free_current_contents): Remove.
13961
139622019-03-06 Tom Tromey <tom@tromey.com>
13963
13964 * top.c (quit_force): Update.
13965 * main.c (captured_command_loop): Update.
13966 * common/new-op.c (operator new): Update.
13967 * common/common-exceptions.c (struct catcher)
13968 <save_cleanup_chain>: Remove member.
13969 (exceptions_state_mc_init): Update.
13970 (exception_try_scope_entry): Return nullptr.
13971 (exception_try_scope_exit, exception_rethrow)
13972 (throw_exception_sjlj, throw_exception_cxx): Update.
13973 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13974 (all_cleanups, do_cleanups, discard_cleanups)
13975 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13976 (restore_cleanups, restore_final_cleanups): Don't declare.
13977 (do_final_cleanups): Remove parameter.
13978 * common/cleanups.c (cleanup_chain, make_cleanup)
13979 (make_cleanup_dtor, all_cleanups, do_cleanups)
13980 (discard_my_cleanups, discard_cleanups)
13981 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13982 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13983 (null_cleanup): Remove.
13984 (do_final_cleanups): Remove parameter.
13985
139862019-03-06 Tom Tromey <tom@tromey.com>
13987
13988 * remote.c (remote_target::remote_parse_stop_reply): Use
13989 unique_xmalloc_ptr.
13990
139912019-03-06 Tom Tromey <tom@tromey.com>
13992
13993 * stabsread.c (struct stabs_field_info): Rename from field_info.
13994 <list, fnlist>: Add initializers.
13995 <obstack>: New member.
13996 (read_member_functions, read_struct_fields, read_baseclasses):
13997 Allocate on obstack. Don't use cleanups.
13998 (read_one_struct_field, read_member_functions, read_struct_fields)
13999 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14000 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14001 (read_struct_type): Update.
14002
140032019-03-06 Tom Tromey <tom@tromey.com>
14004
14005 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14006 * common/filestuff.h (make_cleanup_close): Don't declare.
14007 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14008 Remove.
14009
140102019-03-06 Tom Tromey <tom@tromey.com>
14011
14012 * solib-aix.c: Use make_scope_exit.
14013
140142019-03-06 Tom Tromey <tom@tromey.com>
14015
14016 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14017 Use make_scope_exit.
14018
140192019-03-06 Tom Tromey <tom@tromey.com>
14020
14021 * solib-svr4.c (disable_probes_interface): Remove parameter.
14022 (svr4_handle_solib_event): Use make_scope_exit.
14023
140242019-03-06 Tom Tromey <tom@tromey.com>
14025
14026 * remote.c (struct stop_reply_deleter): Remove.
14027 (stop_reply_up): Update.
14028 (struct stop_reply): Derive from notif_event. Don't typedef.
14029 <regcache>: Now a std::vector.
14030 (stop_reply_xfree): Remove.
14031 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14032 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14033 (remote_target::discard_pending_stop_replies): Use delete.
14034 (remote_target::remote_parse_stop_reply): Update.
14035 (remote_target::process_stop_reply): Update.
14036 * remote-notif.h (struct notif_event): Add virtual destructor.
14037 Remove "dtr" member.
14038 (struct notif_client) <alloc_event>: Return a unique_ptr.
14039 (notif_event_xfree): Don't declare.
14040 (notif_event_up): New typedef.
14041 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14042 (notif_event_xfree, do_notif_event_xfree): Remove.
14043 (remote_notif_state_xfree): Update.
14044
140452019-03-06 Tom Tromey <tom@tromey.com>
14046
14047 * infrun.c (displaced_step_clear_cleanup): Now a
14048 forward_scope_exit type.
14049 (displaced_step_prepare_throw): Update.
14050 (displaced_step_fixup): Update.
14051
140522019-03-06 Tom Tromey <tom@tromey.com>
14053
14054 * inferior.h (class inferior): Update comment.
14055 * gdbthread.h (class thread_info): Update comment.
14056
140572019-03-06 Joel Brobecker <brobecker@adacore.com>
14058 Tom Tromey <tom@tromey.com>
14059
14060 * stabsread.h (struct stab_section_list): Remove.
14061 (coffstab_build_psymtabs): Update.
14062 * dbxread.c (symbuf_sections): Now a std::vector.
14063 (sect_idx): New global.
14064 (fill_symbuf): Update.
14065 (coffstab_build_psymtabs): Change type of stabsects parameter.
14066 Update.
14067 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14068 std::vector.
14069 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14070 (coff_locate_sections): Update.
14071 (coff_symfile_read): Remove cleanups. Update.
14072 (init_stringtab): Add storage parameter.
14073 (free_stringtab, free_stringtab_cleanup): Remove.
14074 (init_lineno): Add storage parameter.
14075 (free_linetab, free_linetab_cleanup): Remove.
14076
140772019-03-06 Pedro Alves <palves@redhat.com>
14078
14079 * linux-fork.c (fork_info::clobber_regs): Delete.
14080 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14081 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14082 comment. Adjust.
14083 (scoped_switch_fork_info::scoped_switch_fork_info)
14084 (checkpoint_command, linux_fork_context): Adjust
14085 fork_save_infrun_state calls.
14086
140872019-03-06 Pedro Alves <palves@redhat.com>
14088
14089 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14090 (inf_has_multiple_threads): Return 'bool' and rewrite using
14091 inferior_info::threads().
14092
140932019-03-06 Pedro Alves <palves@redhat.com>
14094
14095 * linux-fork.c: Include <list>.
14096 (fork_list): Now a std::list instance.
14097 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14098 (forks_exist_p, find_last_fork): Adjust.
14099 (new_fork): Delete.
14100 (one_fork_p): New.
14101 (add_fork): Adjust.
14102 (free_fork): Delete, folded into fork_info::~fork_info().
14103 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14104 Adjust.
14105 (init_fork_list): Delete.
14106 (linux_fork_killall, linux_fork_mourn_inferior)
14107 (linux_fork_detach, info_checkpoints_command): Adjust.
14108 (_initialize_linux_fork): No longer call init_fork_list.
14109
141102019-03-06 Pedro Alves <palves@redhat.com>
14111
14112 * linux-fork.c (new_fork): New, split out of ...
14113 (add_fork): ... this. Return void. Move "first fork" special
14114 case from here, to ...
14115 (checkpoint_command): ... here.
14116 * linux-linux.h (add_fork): Return void.
14117
141182019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14119
14120 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14121
141222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14123 Chris January <chris.january@arm.com>
14124 David Lecomber <david.lecomber@arm.com>
14125
14126 * f-exp.y: New token, UNOP_INTRINSIC.
14127 (exp): New pattern using UNOP_INTRINSIC token.
14128 (f77_keywords): Add 'abs' keyword.
14129 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14130 (value_from_host_double): New function.
14131 (evaluate_subexp_f): Support UNOP_ABS.
14132
141332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14134
14135 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14136 types.
14137
141382019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14139
14140 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14141 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14142 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14143
141442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14145
14146 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14147
141482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14149 Chris January <chris.january@arm.com>
14150
14151 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14152 * f-exp.y: Define 'KIND' token.
14153 (exp): New pattern for KIND expressions.
14154 (ptype): Handle types with a kind extension.
14155 (direct_abs_decl): Extend to spot kind extensions.
14156 (f77_keywords): Add 'kind' to the list.
14157 (push_kind_type): New function.
14158 (convert_to_kind_type): New function.
14159 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14160 * parse.c (operator_length_standard): Likewise.
14161 * parser-defs.h (enum type_pieces): Add tp_kind.
14162 * std-operator.def: Add UNOP_KIND.
14163
141642019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14165
14166 * f-exp.y (f_parse): Set yydebug.
14167
141682019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14169
14170 * f-lang.c (evaluate_subexp_f): New function.
14171 (exp_descriptor_f): New global.
14172 (f_language_defn): Use exp_descriptor_f instead of
14173 exp_descriptor_standard.
14174
141752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14176
14177 * f-exp.y (struct token): Add comments.
14178 (dot_ops): Remove uppercase versions and the end marker.
14179 (f77_keywords): Likewise.
14180 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14181 entries in the dot_ops array are case insensitive, and use
14182 strncasecmp to compare strings. Also some whitespace cleanup in
14183 this area. Similar for the f77_keywords array, except entries in
14184 this list might be case sensitive.
14185
141862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14187
14188 * f-exp.y (struct f77_boolean_val): Add comments.
14189 (boolean_values): Remove uppercase versions, and end marker.
14190 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14191 and use strncasecmp to achieve case insensitivity. Additionally,
14192 perform whitespace cleanup around this code.
14193
141942019-03-06 Tom Tromey <tromey@adacore.com>
14195
14196 * remote-sim.c (gdbsim_target_open): Use result of
14197 gdb_argv::release.
14198
141992019-03-06 Richard Bunt <richard.bunt@arm.com>
14200 Dirk Schubert <dirk.schubert@arm.com>
14201 Chris January <chris.january@arm.com>
14202
14203 * eval.c (evaluate_subexp_standard): Call Fortran argument
14204 wrapping logic.
14205 * f-lang.c (struct value): A value which can be passed into a
14206 Fortran function call.
14207 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14208 where appropriate.
14209 (struct type): Value ready for a Fortran function call.
14210 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14211 is needed.
14212 * f-lang.h (fortran_argument_convert): Declaration.
14213 (fortran_preserve_arg_pointer): Declaration.
14214 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14215
142162019-03-05 Tom Tromey <tromey@adacore.com>
14217
14218 * python/py-prettyprint.c (print_string_repr): Remove #if.
14219 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14220
142212019-03-05 Tom Tromey <tromey@adacore.com>
14222
14223 * target.c (the_dummy_target): Move later. Change type to
14224 "dummy_target".
14225 (initialize_targets): Don't initialize the_dummy_target.
14226
142272019-03-05 Tom Tromey <tromey@adacore.com>
14228
14229 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14230 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14231
142322019-03-05 Tom Tromey <tromey@adacore.com>
14233
14234 * windows-nat.c (windows_nat_target::attach)
14235 (windows_nat_target::detach): Don't call gdb_flush.
14236 * valprint.c (generic_val_print, val_print, val_print_string):
14237 Don't call gdb_flush.
14238 * utils.c (defaulted_query): Don't call gdb_flush.
14239 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14240 * target.c (target_announce_detach): Don't call gdb_flush.
14241 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14242 * remote.c (extended_remote_target::attach): Don't call
14243 gdb_flush.
14244 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14245 * printcmd.c (do_examine): Don't call gdb_flush.
14246 (info_display_command): Don't call gdb_flush.
14247 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14248 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14249 * memattr.c (info_mem_command): Don't call gdb_flush.
14250 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14251 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14252 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14253 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14254 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14255 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14256 (gnu_nat_target::detach): Don't call gdb_flush.
14257 * f-valprint.c (f_val_print): Don't call gdb_flush.
14258 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14259 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14260 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14261 gdb_flush.
14262 * c-valprint.c (c_val_print): Don't call gdb_flush.
14263 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14264
142652019-03-05 Tom Tromey <tromey@adacore.com>
14266
14267 * varobj.c (update_dynamic_varobj_children): Update.
14268 (install_default_visualizer): Use reset, not release.
14269 * value.c (set_internalvar): Update.
14270 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14271 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14272 ATTRIBUTE_UNUSED_RESULT.
14273
142742019-03-05 Tom Tromey <tromey@adacore.com>
14275
14276 * remote.c (class scoped_remote_fd) <release>: Add
14277 ATTRIBUTE_UNUSED_RESULT.
14278
142792019-03-05 Tom Tromey <tromey@adacore.com>
14280
14281 * macroexp.c (struct macro_buffer) <release>: Add
14282 ATTRIBUTE_UNUSED_RESULT.
14283
142842019-03-05 Tom Tromey <tromey@adacore.com>
14285
14286 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14287 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14288 ATTRIBUTE_UNUSED_RESULT.
14289
142902019-03-05 Tom Tromey <tromey@adacore.com>
14291
14292 * common/scoped_fd.h (class scoped_fd) <release>: Add
14293 ATTRIBUTE_UNUSED_RESULT.
14294
142952019-03-05 Tom Tromey <tromey@adacore.com>
14296
14297 * parser-defs.h (struct parser_state) <release>: Add
14298 ATTRIBUTE_UNUSED_RESULT.
14299
143002019-03-05 Tom Tromey <tromey@adacore.com>
14301
14302 * utils.h (class gdb_argv) <release>: Add
14303 ATTRIBUTE_UNUSED_RESULT.
14304 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14305
143062019-03-02 Eli Zaretskii <eliz@gnu.org>
14307
14308 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14309 for-loop range, to avoid compiler warnings.
14310
14311 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14312 avoid compiler warnings about unused variables.
14313
14314 * NEWS: Mention end of support for native debugging on MS-Windows
14315 before XP.
14316
14317 PR gdb/24292
14318 * common/netstuff.c:
14319 * gdbserver/gdbreplay.c
14320 * gdbserver/remote-utils.c:
14321 * ser-tcp.c:
14322 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14323 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14324 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14325 'getaddrinfo' and 'freeaddrinfo' were not available before
14326 Windows XP, and mingw.org's MinGW headers by default define
14327 _WIN32_WINNT to 0x500.
14328
143292019-03-01 Gary Benson <gbenson@redhat.com>
14330
14331 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14332
143332019-02-28 Brian Vandenberg <phantall@gmail.com>
14334 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14335
14336 PR gdb/8527
14337 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14338 set_sigint_trap, clear_sigint_trap.
14339
143402019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14341
14342 * target.c (target_detach): Clear the regcache and the
14343 frame cache.
14344
143452019-02-27 Pedro Alves <palves@redhat.com>
14346
14347 * utils.c (set_screen_size): When we cap the height/width sizes,
14348 tweak the corresponding command variable to show "unlimited":
14349
143502019-02-27 Saagar Jha <saagar@saagarjha.com>
14351 Pedro Alves <palves@redhat.com>
14352
14353 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14354 before calling rl_set_screen_size.
14355
143562019-02-27 Tom Tromey <tromey@adacore.com>
14357
14358 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14359 define.
14360 * python/py-value.c: Remove Python 2.4 workaround.
14361 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14362 workaround.
14363 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14364 Python 2.4 workaround.
14365 * python/python-internal.h: Remove Python 2.4 comment.
14366 (Py_ssize_t): Don't define.
14367 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14368 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14369 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14370 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14371 * python/python.c (do_start_initialization): Remove Python 2.4
14372 workaround.
14373 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14374 (print_children): Remove Python 2.4 workaround.
14375 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14376 workaround.
14377 (CHARBUFFERPROC_NAME): Remove.
14378 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14379 Python 2.4 workaround.
14380
143812019-02-27 Kevin Buettner <kevinb@redhat.com>
14382
14383 * NEWS: Note minimum Python version.
14384
143852019-02-27 Kevin Buettner <kevinb@redhat.com>
14386
14387 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14388 code from these functions. Remove corresponding ifdefs. Use
14389 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14390 Remove gotos and target of gotos.
14391 (infpy_search_memory): Likewise.
14392
143932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14394
14395 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14396 (hppa_gdbarch_init): Don't register deleted functions with
14397 gdbarch.
14398
143992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14400
14401 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14402 (h8300_unwind_sp): Delete.
14403 (h8300_dummy_id): Delete.
14404 (h8300_gdbarch_init): Don't register deleted functions with
14405 gdbarch.
14406
144072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14408
14409 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14410 (ft32_unwind_pc): Delete.
14411 (ft32_unwind_sp): Delete.
14412 (ft32_gdbarch_init): Don't register deleted functions with
14413 gdbarch.
14414
144152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14416
14417 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14418 (frv_unwind_pc): Delete.
14419 (frv_unwind_sp): Delete.
14420 (frv_gdbarch_init): Don't register deleted functions with
14421 gdbarch.
14422
144232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14424
14425 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14426 (riscv_unwind_pc): Delete.
14427 (riscv_unwind_sp): Delete.
14428 (riscv_gdbarch_init): Don't register deleted functions with
14429 gdbarch.
14430
144312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14432
14433 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14434 (csky_unwind_pc): Delete.
14435 (csky_unwind_sp): Delete.
14436 (csky_gdbarch_init): Don't register deleted functions with
14437 gdbarch.
14438
144392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14440
14441 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14442 (cris_unwind_pc): Delete.
14443 (cris_unwind_sp): Delete.
14444 (cris_gdbarch_init): Don't register deleted functions with
14445 gdbarch.
14446
144472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14448
14449 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14450 (bfin_unwind_pc): Delete.
14451 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14452
144532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14454
14455 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14456 (arm_unwind_pc): Delete.
14457 (arm_unwind_sp): Delete.
14458 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14459
144602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14461
14462 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14463 (arc_unwind_pc): Delete.
14464 (arc_unwind_sp): Delete.
14465 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14466
144672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14468
14469 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14470 (alpha_unwind_pc): Delete.
14471 (alpha_gdbarch_init): Don't register deleted functions with
14472 gdbarch.
14473
144742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14475
14476 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14477 (aarch64_unwind_pc): Delete.
14478 (aarch64_unwind_sp): Delete.
14479 (aarch64_gdbarch_init): Don't register deleted functions with
14480 gdbarch.
14481
144822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14483
14484 * gdbtypes.c (type_align): Don't consider static members when
14485 computing structure alignment.
14486
144872019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14488
14489 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14490 return 0 for other types.
14491 * arch-utils.c (default_type_align): Always return 0.
14492 * gdbarch.h: Regenerate.
14493 * gdbarch.sh (type_align): Extend comment.
14494 * gdbtypes.c (type_align): Add additional comments, always call
14495 gdbarch_type_align before applying the default rules.
14496 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14497 generic code will then apply a suitable default.
14498 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14499 types, return 0 for other types.
14500
145012019-02-27 Joel Brobecker <brobecker@adacore.com>
14502
14503 * NEWS: Create a new section for the next release branch.
14504 Rename the section of the current branch, now that it has
14505 been cut.
14506
145072019-02-27 Joel Brobecker <brobecker@adacore.com>
14508
14509 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14510 * version.in: Bump version to 8.3.50.DATE-git.
14511
145122019-02-26 Simon Marchi <simon.marchi@efficios.com>
14513
14514 * aix-thread.c (ptid_cmp): Remove unused variable.
14515 (get_signaled_thread): Likewise.
14516 (store_regs_user_thread): Likewise.
14517 (store_regs_kernel_thread): Likewise.
14518 (fetch_regs_kernel_thread): Remove shadowed variable.
14519
145202019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14521
14522 * features/riscv/32bit-cpu.xml: Add register numbers.
14523 * features/riscv/32bit-fpu.c: Regenerate.
14524 * features/riscv/32bit-fpu.xml: Add register numbers.
14525 * features/riscv/64bit-cpu.xml: Add register numbers.
14526 * features/riscv/64bit-fpu.c: Regenerate.
14527 * features/riscv/64bit-fpu.xml: Add register numbers.
14528
145292019-02-26 Kevin Buettner <kevinb@redhat.com>
14530
14531 * NEWS: Mention two argument form of gdb.Value constructor.
14532 * python/py-value.c (convert_buffer_and_type_to_value): New
14533 function.
14534 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14535 Add support for handling an optional second argument. Call
14536 convert_buffer_and_type_to_value as appropriate.
14537 * python/python-internal.h (Py_buffer_deleter): New struct.
14538 (Py_buffer_up): New typedef.
14539
145402019-02-25 John Baldwin <jhb@FreeBSD.org>
14541
14542 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14543 instead of releasing ownership.
14544
145452019-02-25 Jordan Rupprecht <rupprecht@google.com>
14546
14547 * dwarf2read.c (open_and_init_dwp_file): Call
14548 elf_numsections instead of bfd_count_sections to initialize
14549 dwp_file->num_sections.
14550
145512019-02-25 Tom Tromey <tromey@adacore.com>
14552
14553 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14554
145552019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14556
14557 * gcore.in: Add '--readnever' option when invoking GDB.
14558
145592019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14560
14561 * MAINTAINERS: Update my email address.
14562
145632019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14564
14565 * build-id.c (build_id_to_debug_bfd_1): New function.
14566 (build_id_to_debug_bfd): Look for separate debug file in
14567 sysroot.
14568
145692019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14570
14571 * gdbarch.sh: Update the copyright year range that is placed into
14572 generated files.
14573
145742019-02-22 Keith Seitz <keiths@redhat.com>
14575
14576 PR symtab/23853
14577 * linespec.c (create_sals_line_offset): Search for the default
14578 symtab's filename instead of its fullname.
14579
145802019-02-21 Alan Hayward <alan.hayward@arm.com>
14581
14582 * NEWS: Update style defaults.
14583
145842019-02-21 Alan Hayward <alan.hayward@arm.com>
14585
14586 * main.c (captured_main_1): Disable styling in batch mode.
14587
145882019-02-20 Tom Tromey <tom@tromey.com>
14589
14590 * symtab.c (symtab_symbol_info): Fix typos.
14591
145922019-02-20 Tom Tromey <tromey@adacore.com>
14593
14594 * findcmd.c (_initialize_mem_search): Use upper case for
14595 metasyntactic variables.
14596
145972019-02-20 Alan Hayward <alan.hayward@arm.com>
14598
14599 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14600 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14601
146022019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14603
14604 * top.h (source_file_name): Change to std::string.
14605 * top.c (source_file_name): Likewise.
14606 (command_line_input): Adjust.
14607 * cli/cli-script.c (script_from_file): Adjust.
14608
146092019-02-19 Tom Tromey <tromey@adacore.com>
14610
14611 * ravenscar-thread.c
14612 (ravenscar_thread_target::update_thread_list): Don't call
14613 ada_build_task_list.
14614 * ada-lang.h (ada_build_task_list): Don't declare.
14615 * ada-tasks.c (struct ada_tasks_inferior_data)
14616 <task_list_valid_p>: Now bool.
14617 (read_known_tasks, ada_task_list_changed)
14618 (ada_tasks_invalidate_inferior_data): Update.
14619 (read_known_tasks_array): Return bool.
14620 (read_known_tasks_list): Likewise.
14621 (read_known_tasks): Return void.
14622 (ada_build_task_list): Now static.
14623
146242019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14625
14626 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14627 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14628
146292019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14630
14631 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14632 variant for ada_tasks_pspace_data_handle and
14633 ada_tasks_inferior_data_handle.
14634 (ada_tasks_pspace_data_cleanup): New function.
14635 (ada_tasks_inferior_data_cleanup): New function.
14636
146372019-02-17 Tom Tromey <tom@tromey.com>
14638
14639 * macrotab.h (macro_source_fullname): Return a std::string.
14640 * macrotab.c (macro_include, check_for_redefinition)
14641 (macro_undef, macro_lookup_definition, foreach_macro)
14642 (foreach_macro_in_scope): Update.
14643 (macro_source_fullname): Return a std::string.
14644 * macrocmd.c (show_pp_source_pos): Update.
14645
146462019-02-17 Tom Tromey <tom@tromey.com>
14647
14648 * macrocmd.c (show_pp_source_pos): Style the file names.
14649
146502019-02-17 Tom Tromey <tom@tromey.com>
14651
14652 PR tui/24197:
14653 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14654
146552019-02-17 Tom Tromey <tom@tromey.com>
14656
14657 * ada-lang.c (user_select_syms): Use filtered printing.
14658 * utils.c (wrap_style): New global.
14659 (desired_style): Remove.
14660 (emit_style_escape): Add stream parameter.
14661 (set_output_style, reset_terminal_style, prompt_for_continue):
14662 Update.
14663 (flush_wrap_buffer): Only flush gdb_stdout.
14664 (wrap_here): Set wrap_style.
14665 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14666 treat escape sequences as a character. Change when wrap buffer is
14667 flushed.
14668 (fputs_styled): Do not set the output style when the default is
14669 requested.
14670 * ui-style.h (struct ui_file_style) <is_default>: New method.
14671 * source.c (print_source_lines_base): Emit escape sequences in one
14672 piece.
14673
146742019-02-17 Joel Brobecker <brobecker@adacore.com>
14675
14676 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14677 integers and enumeration types.
14678
146792019-02-17 Joel Brobecker <brobecker@adacore.com>
14680
14681 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14682 instead of lookup_symbol_in_language
14683 (do_exact_match): New function.
14684 (ada_get_symbol_name_matcher): Return do_exact_match when
14685 doing a verbatim match.
14686
146872019-02-15 Tom Tromey <tromey@adacore.com>
14688
14689 * ravenscar-thread.c (ravenscar_thread_target::resume)
14690 (ravenscar_thread_target::wait): Special case wildcard requests.
14691
146922019-02-15 Tom Tromey <tromey@adacore.com>
14693
14694 * ravenscar-thread.c (base_ptid): Remove.
14695 (struct ravenscar_thread_target) <close>: New method.
14696 <m_base_ptid>: New member.
14697 <update_inferior_ptid, active_task, task_is_currently_active,
14698 runtime_initialized>: Declare methods.
14699 <ravenscar_thread_target>: Add constructor.
14700 (ravenscar_thread_target::task_is_currently_active)
14701 (ravenscar_thread_target::update_inferior_ptid)
14702 (ravenscar_runtime_initialized): Rename. Now methods.
14703 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14704 (ravenscar_thread_target::update_thread_list): Update.
14705 (ravenscar_thread_target::active_task): Now method.
14706 (ravenscar_thread_target::store_registers)
14707 (ravenscar_thread_target::prepare_to_store)
14708 (ravenscar_thread_target::prepare_to_store)
14709 (ravenscar_thread_target::mourn_inferior): Update.
14710 (ravenscar_inferior_created): Use "new" to create target.
14711 (ravenscar_thread_target::get_ada_task_ptid): Update.
14712 (_initialize_ravenscar): Don't initialize base_ptid.
14713 (ravenscar_ops): Remove global.
14714
147152019-02-15 Tom Tromey <tromey@adacore.com>
14716
14717 * target.h (push_target): Declare new overload.
14718 * target.c (push_target): New overload, taking an rvalue reference.
14719 * remote.c (remote_target::open_1): Use push_target overload.
14720 * corelow.c (core_target_open): Use push_target overload.
14721
147222019-02-15 Tom Tromey <tromey@adacore.com>
14723
14724 * ravenscar-thread.c (is_ravenscar_task)
14725 (ravenscar_task_is_currently_active): Return bool.
14726 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14727 (_initialize_ravenscar): Remove "(void)".
14728 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14729 Return bool.
14730
147312019-02-15 Tom Tromey <tromey@adacore.com>
14732
14733 * ravenscar-thread.c (ravenscar_runtime_initializer)
14734 (has_ravenscar_runtime, get_running_thread_id)
14735 (ravenscar_thread_target::resume): Fix indentation.
14736
147372019-02-15 Tom Tromey <tromey@adacore.com>
14738
14739 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14740 from ravenscar_arch_ops.
14741 (sparc_ravenscar_ops::fetch_registers)
14742 (sparc_ravenscar_ops::store_registers): Now methods.
14743 (sparc_ravenscar_prepare_to_store): Remove.
14744 (sparc_ravenscar_ops): Redefine.
14745 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14746 methods and destructor. Remove members.
14747 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14748 (ravenscar_thread_target::store_registers)
14749 (ravenscar_thread_target::prepare_to_store): Update.
14750 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14751 Remove.
14752 (struct ppc_ravenscar_powerpc_ops): Derive from
14753 ravenscar_arch_ops.
14754 (ppc_ravenscar_powerpc_ops::fetch_registers)
14755 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14756 (ppc_ravenscar_powerpc_ops): Redefine.
14757 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14758 (ppc_ravenscar_e500_ops::fetch_registers)
14759 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14760 (ppc_ravenscar_e500_ops): Redefine.
14761 * aarch64-ravenscar-thread.c
14762 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14763 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14764 (aarch64_ravenscar_fetch_registers)
14765 (aarch64_ravenscar_store_registers): Now methods.
14766 (aarch64_ravenscar_ops): Redefine.
14767
147682019-02-15 Tom Tromey <tromey@adacore.com>
14769
14770 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14771 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14772 (ravenscar_thread_target::stopped_by_watchpoint)
14773 (ravenscar_thread_target::stopped_data_address)
14774 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14775
147762019-02-15 Tom Tromey <tromey@adacore.com>
14777
14778 * ravenscar-thread.c: Fix some typos.
14779
147802019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14781 Tom Tromey <tromey@adacore.com>
14782
14783 * ada-lang.c (ada_exception_sal): Change addr_string to a
14784 std::string.
14785 (create_ada_exception_catchpoint): Update.
14786
147872019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14788 Tom Tromey <tromey@adacore.com>
14789
14790 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14791 (bp_location_ops): Remove.
14792 (base_breakpoint_allocate_location): Update.
14793 (free_bp_location): Update.
14794 * ada-lang.c (class ada_catchpoint_location)
14795 <ada_catchpoint_location>: Remove ops parameter.
14796 (ada_catchpoint_location_dtor): Remove.
14797 (ada_catchpoint_location_ops): Remove.
14798 (allocate_location_exception): Update.
14799 * breakpoint.h (struct bp_location_ops): Remove.
14800 (class bp_location) <bp_location>: Remove bp_location_ops
14801 parameter.
14802 <~bp_location>: Add destructor.
14803 <ops>: Remove.
14804
148052019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14806 Pedro Alves <palves@redhat.com>
14807
14808 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14809 'PATH_MAX'.
14810
148112019-02-14 David Michael <fedora.dm0@gmail.com>
14812 Samuel Thibault <samuel.thibault@gnu.org>
14813 Thomas Schwinge <thomas@codesourcery.com>
14814
14815 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14816 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14817
148182019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14819
14820 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14821 (check_empty): Use "const char *".
14822
14823 * gnu-nat.c (gnu_nat_target::detach): Instead of
14824 'detach_inferior (pid)' call
14825 'detach_inferior (find_inferior_pid (pid))'.
14826
14827 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14828 'nat/fork-inferior.o'.
14829 * gnu-nat.c: #include "nat/fork-inferior.h".
14830
14831 * gnu-nat.c (gnu_nat_target::detach): Instead of
14832 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14833 * gnu-nat.h: #include "inf-child.h".
14834 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14835 'i386_gnu_nat_target::fetch_registers'.
14836 (gnu_store_registers): Rename/move to
14837 'i386_gnu_nat_target::store_registers'.
14838
14839 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14840 * gnu-nat.h (mach_thread_info): New function.
14841 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14842
14843 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14844
148452019-02-14 Frederic Konrad <konrad@adacore.com>
14846
14847 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14848
148492019-02-14 Joel Brobecker <brobecker@adacore.com>
14850
14851 * windows-nat.c (windows_add_thread): Add new parameter
14852 "main_thread_p" with default value set to false. Update
14853 function documentation as well as all callers.
14854 (windows_delete_thread): Likewise.
14855 (fake_create_process): Update call to windows_add_thread.
14856 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14857 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14858 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14859 call to windows_delete_thread.
14860
148612019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14862
14863 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14864
148652019-02-12 John Baldwin <jhb@FreeBSD.org>
14866
14867 * symfile.c (find_separate_debug_file): Use canonical path of
14868 sysroot with child_path instead of gdb_sysroot if it is valid.
14869
148702019-02-12 John Baldwin <jhb@FreeBSD.org>
14871
14872 * symfile.c (find_separate_debug_file): Use child_path to
14873 determine if an object file is under a sysroot.
14874
148752019-02-12 John Baldwin <jhb@FreeBSD.org>
14876
14877 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14878 unittests/child-path-selftests.c.
14879 * common/pathstuff.c (child_path): New function.
14880 * common/pathstuff.h (child_path): New prototype.
14881 * unittests/child-path-selftests.c: New file.
14882
148832019-02-12 John Baldwin <jhb@FreeBSD.org>
14884
14885 * symfile.c (find_separate_debug_file): Look for separate debug
14886 files in debug directories under the sysroot.
14887
148882019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14889
14890 * symtab.h (struct minimal_symbol data_p): New const method.
14891 (struct minimal_symbol text_p): Likewise.
14892 * symtab.c (output_source_filename): Use file name style
14893 to print file name.
14894 (print_symbol_info): Likewise.
14895 (print_msymbol_info): Use address style to print addresses.
14896 Use function name style to print executable text symbols.
14897 (expand_symtab_containing_pc): Use data_p.
14898 (find_pc_sect_compunit_symtab): Likewise.
14899
149002019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14901
14902 * breakpoint.c (describe_other_breakpoints): Use address style
14903 to print addresses.
14904 (say_where): Likewise.
14905
149062019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14907
14908 * ada-typeprint.c (print_func_type): Print function name
14909 style to print function name.
14910 * c-typeprint.c (c_print_type_1): Likewise.
14911
149122019-02-11 Alan Hayward <alan.hayward@arm.com>
14913
14914 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14915 for execve.
14916
149172019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14918
14919 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14920 type_stack.
14921
149222019-02-10 Joel Brobecker <brobecker@adacore.com>
14923
14924 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14925 TYPE_CODE_REF types.
14926
149272019-02-08 Jim Wilson <jimw@sifive.com>
14928
14929 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14930 (riscv_linux_fregset): New.
14931 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14932
149332019-02-07 Tom Tromey <tom@tromey.com>
14934
14935 * thread.c (thread_cancel_execution_command): Update.
14936 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14937 methods.
14938 (struct thread_fsm_ops): Remove.
14939 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14940 (thread_fsm_should_stop, thread_fsm_return_value)
14941 (thread_fsm_set_finished, thread_fsm_finished_p)
14942 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14943 Don't declare.
14944 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14945 * infrun.c (clear_proceed_status_thread)
14946 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14947 (print_stop_event): Update.
14948 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14949 Add constructor.
14950 (step_command_fsm_ops): Remove.
14951 (new_step_command_fsm): Remove.
14952 (step_1): Update.
14953 (step_command_fsm::should_stop): Rename from
14954 step_command_fsm_should_stop.
14955 (step_command_fsm::clean_up): Rename from
14956 step_command_fsm_clean_up.
14957 (step_command_fsm::do_async_reply_reason): Rename from
14958 step_command_fsm_async_reply_reason.
14959 (struct until_next_fsm): Inherit from thread_fsm. Add
14960 constructor.
14961 (until_next_fsm_ops): Remove.
14962 (new_until_next_fsm): Remove.
14963 (until_next_fsm::should_stop): Rename from
14964 until_next_fsm_should_stop.
14965 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14966 (until_next_fsm::do_async_reply_reason): Rename from
14967 until_next_fsm_async_reply_reason.
14968 (struct finish_command_fsm): Inherit from thread_fsm. Add
14969 constructor. Change type of breakpoint.
14970 (finish_command_fsm_ops): Remove.
14971 (new_finish_command_fsm): Remove.
14972 (finish_command_fsm::should_stop): Rename from
14973 finish_command_fsm_should_stop.
14974 (finish_command_fsm::clean_up): Rename from
14975 finish_command_fsm_clean_up.
14976 (finish_command_fsm::return_value): Rename from
14977 finish_command_fsm_return_value.
14978 (finish_command_fsm::do_async_reply_reason): Rename from
14979 finish_command_fsm_async_reply_reason.
14980 (finish_command): Update.
14981 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14982 Add constructor.
14983 (call_thread_fsm_ops): Remove.
14984 (call_thread_fsm::call_thread_fsm): Rename from
14985 new_call_thread_fsm.
14986 (call_thread_fsm::should_stop): Rename from
14987 call_thread_fsm_should_stop.
14988 (call_thread_fsm::should_notify_stop): Rename from
14989 call_thread_fsm_should_notify_stop.
14990 (run_inferior_call, call_function_by_hand_dummy): Update.
14991 * cli/cli-interp.c (should_print_stop_to_console): Update.
14992 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14993 Add constructor. Change type of location_breakpoint,
14994 caller_breakpoint.
14995 (until_break_fsm_ops): Remove.
14996 (new_until_break_fsm): Remove.
14997 (until_break_fsm::should_stop): Rename from
14998 until_break_fsm_should_stop.
14999 (until_break_fsm::clean_up): Rename from
15000 until_break_fsm_clean_up.
15001 (until_break_fsm::do_async_reply_reason): Rename from
15002 until_break_fsm_async_reply_reason.
15003 (until_break_command): Update.
15004 * thread-fsm.c: Remove.
15005 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15006
150072019-02-07 Tom Tromey <tom@tromey.com>
15008
15009 * yy-remap.h: Add include guard.
15010 * xtensa-tdep.h: Add include guard.
15011 * xcoffread.h: Rename include guard.
15012 * varobj-iter.h: Add include guard.
15013 * tui/tui.h: Rename include guard.
15014 * tui/tui-winsource.h: Rename include guard.
15015 * tui/tui-wingeneral.h: Rename include guard.
15016 * tui/tui-windata.h: Rename include guard.
15017 * tui/tui-win.h: Rename include guard.
15018 * tui/tui-stack.h: Rename include guard.
15019 * tui/tui-source.h: Rename include guard.
15020 * tui/tui-regs.h: Rename include guard.
15021 * tui/tui-out.h: Rename include guard.
15022 * tui/tui-layout.h: Rename include guard.
15023 * tui/tui-io.h: Rename include guard.
15024 * tui/tui-hooks.h: Rename include guard.
15025 * tui/tui-file.h: Rename include guard.
15026 * tui/tui-disasm.h: Rename include guard.
15027 * tui/tui-data.h: Rename include guard.
15028 * tui/tui-command.h: Rename include guard.
15029 * tic6x-tdep.h: Add include guard.
15030 * target/waitstatus.h: Rename include guard.
15031 * target/wait.h: Rename include guard.
15032 * target/target.h: Rename include guard.
15033 * target/resume.h: Rename include guard.
15034 * target-float.h: Rename include guard.
15035 * stabsread.h: Add include guard.
15036 * rs6000-tdep.h: Add include guard.
15037 * riscv-fbsd-tdep.h: Add include guard.
15038 * regformats/regdef.h: Rename include guard.
15039 * record.h: Rename include guard.
15040 * python/python.h: Rename include guard.
15041 * python/python-internal.h: Rename include guard.
15042 * python/py-stopevent.h: Rename include guard.
15043 * python/py-ref.h: Rename include guard.
15044 * python/py-record.h: Rename include guard.
15045 * python/py-record-full.h: Rename include guard.
15046 * python/py-record-btrace.h: Rename include guard.
15047 * python/py-instruction.h: Rename include guard.
15048 * python/py-events.h: Rename include guard.
15049 * python/py-event.h: Rename include guard.
15050 * procfs.h: Add include guard.
15051 * proc-utils.h: Add include guard.
15052 * p-lang.h: Add include guard.
15053 * or1k-tdep.h: Rename include guard.
15054 * observable.h: Rename include guard.
15055 * nto-tdep.h: Rename include guard.
15056 * nat/x86-linux.h: Rename include guard.
15057 * nat/x86-linux-dregs.h: Rename include guard.
15058 * nat/x86-gcc-cpuid.h: Add include guard.
15059 * nat/x86-dregs.h: Rename include guard.
15060 * nat/x86-cpuid.h: Rename include guard.
15061 * nat/ppc-linux.h: Rename include guard.
15062 * nat/mips-linux-watch.h: Rename include guard.
15063 * nat/linux-waitpid.h: Rename include guard.
15064 * nat/linux-ptrace.h: Rename include guard.
15065 * nat/linux-procfs.h: Rename include guard.
15066 * nat/linux-osdata.h: Rename include guard.
15067 * nat/linux-nat.h: Rename include guard.
15068 * nat/linux-namespaces.h: Rename include guard.
15069 * nat/linux-btrace.h: Rename include guard.
15070 * nat/glibc_thread_db.h: Rename include guard.
15071 * nat/gdb_thread_db.h: Rename include guard.
15072 * nat/gdb_ptrace.h: Rename include guard.
15073 * nat/fork-inferior.h: Rename include guard.
15074 * nat/amd64-linux-siginfo.h: Rename include guard.
15075 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15076 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15077 * nat/aarch64-linux.h: Rename include guard.
15078 * nat/aarch64-linux-hw-point.h: Rename include guard.
15079 * mn10300-tdep.h: Add include guard.
15080 * mips-linux-tdep.h: Add include guard.
15081 * mi/mi-parse.h: Rename include guard.
15082 * mi/mi-out.h: Rename include guard.
15083 * mi/mi-main.h: Rename include guard.
15084 * mi/mi-interp.h: Rename include guard.
15085 * mi/mi-getopt.h: Rename include guard.
15086 * mi/mi-console.h: Rename include guard.
15087 * mi/mi-common.h: Rename include guard.
15088 * mi/mi-cmds.h: Rename include guard.
15089 * mi/mi-cmd-break.h: Rename include guard.
15090 * m2-lang.h: Add include guard.
15091 * location.h: Rename include guard.
15092 * linux-record.h: Rename include guard.
15093 * linux-nat.h: Add include guard.
15094 * linux-fork.h: Add include guard.
15095 * i386-darwin-tdep.h: Rename include guard.
15096 * hppa-linux-offsets.h: Add include guard.
15097 * guile/guile.h: Rename include guard.
15098 * guile/guile-internal.h: Rename include guard.
15099 * gnu-nat.h: Rename include guard.
15100 * gdb-stabs.h: Rename include guard.
15101 * frv-tdep.h: Add include guard.
15102 * f-lang.h: Add include guard.
15103 * event-loop.h: Add include guard.
15104 * darwin-nat.h: Rename include guard.
15105 * cp-abi.h: Rename include guard.
15106 * config/sparc/nm-sol2.h: Rename include guard.
15107 * config/nm-nto.h: Rename include guard.
15108 * config/nm-linux.h: Add include guard.
15109 * config/i386/nm-i386gnu.h: Rename include guard.
15110 * config/djgpp/nl_types.h: Rename include guard.
15111 * config/djgpp/langinfo.h: Rename include guard.
15112 * compile/gcc-cp-plugin.h: Add include guard.
15113 * compile/gcc-c-plugin.h: Add include guard.
15114 * compile/compile.h: Rename include guard.
15115 * compile/compile-object-run.h: Rename include guard.
15116 * compile/compile-object-load.h: Rename include guard.
15117 * compile/compile-internal.h: Rename include guard.
15118 * compile/compile-cplus.h: Rename include guard.
15119 * compile/compile-c.h: Rename include guard.
15120 * common/xml-utils.h: Rename include guard.
15121 * common/x86-xstate.h: Rename include guard.
15122 * common/version.h: Rename include guard.
15123 * common/vec.h: Rename include guard.
15124 * common/tdesc.h: Rename include guard.
15125 * common/selftest.h: Rename include guard.
15126 * common/scoped_restore.h: Rename include guard.
15127 * common/scoped_mmap.h: Rename include guard.
15128 * common/scoped_fd.h: Rename include guard.
15129 * common/safe-iterator.h: Rename include guard.
15130 * common/run-time-clock.h: Rename include guard.
15131 * common/refcounted-object.h: Rename include guard.
15132 * common/queue.h: Rename include guard.
15133 * common/ptid.h: Rename include guard.
15134 * common/print-utils.h: Rename include guard.
15135 * common/preprocessor.h: Rename include guard.
15136 * common/pathstuff.h: Rename include guard.
15137 * common/observable.h: Rename include guard.
15138 * common/netstuff.h: Rename include guard.
15139 * common/job-control.h: Rename include guard.
15140 * common/host-defs.h: Rename include guard.
15141 * common/gdb_wait.h: Rename include guard.
15142 * common/gdb_vecs.h: Rename include guard.
15143 * common/gdb_unlinker.h: Rename include guard.
15144 * common/gdb_unique_ptr.h: Rename include guard.
15145 * common/gdb_tilde_expand.h: Rename include guard.
15146 * common/gdb_sys_time.h: Rename include guard.
15147 * common/gdb_string_view.h: Rename include guard.
15148 * common/gdb_splay_tree.h: Rename include guard.
15149 * common/gdb_setjmp.h: Rename include guard.
15150 * common/gdb_ref_ptr.h: Rename include guard.
15151 * common/gdb_optional.h: Rename include guard.
15152 * common/gdb_locale.h: Rename include guard.
15153 * common/gdb_assert.h: Rename include guard.
15154 * common/filtered-iterator.h: Rename include guard.
15155 * common/filestuff.h: Rename include guard.
15156 * common/fileio.h: Rename include guard.
15157 * common/environ.h: Rename include guard.
15158 * common/common-utils.h: Rename include guard.
15159 * common/common-types.h: Rename include guard.
15160 * common/common-regcache.h: Rename include guard.
15161 * common/common-inferior.h: Rename include guard.
15162 * common/common-gdbthread.h: Rename include guard.
15163 * common/common-exceptions.h: Rename include guard.
15164 * common/common-defs.h: Rename include guard.
15165 * common/common-debug.h: Rename include guard.
15166 * common/cleanups.h: Rename include guard.
15167 * common/buffer.h: Rename include guard.
15168 * common/btrace-common.h: Rename include guard.
15169 * common/break-common.h: Rename include guard.
15170 * cli/cli-utils.h: Rename include guard.
15171 * cli/cli-style.h: Rename include guard.
15172 * cli/cli-setshow.h: Rename include guard.
15173 * cli/cli-script.h: Rename include guard.
15174 * cli/cli-interp.h: Rename include guard.
15175 * cli/cli-decode.h: Rename include guard.
15176 * cli/cli-cmds.h: Rename include guard.
15177 * charset-list.h: Add include guard.
15178 * buildsym-legacy.h: Rename include guard.
15179 * bfin-tdep.h: Add include guard.
15180 * ax.h: Rename include guard.
15181 * arm-linux-tdep.h: Add include guard.
15182 * arm-fbsd-tdep.h: Add include guard.
15183 * arch/xtensa.h: Rename include guard.
15184 * arch/tic6x.h: Add include guard.
15185 * arch/i386.h: Add include guard.
15186 * arch/arm.h: Rename include guard.
15187 * arch/arm-linux.h: Rename include guard.
15188 * arch/arm-get-next-pcs.h: Rename include guard.
15189 * arch/amd64.h: Add include guard.
15190 * arch/aarch64-insn.h: Rename include guard.
15191 * arch-utils.h: Rename include guard.
15192 * annotate.h: Add include guard.
15193 * amd64-darwin-tdep.h: Rename include guard.
15194 * aarch64-linux-tdep.h: Add include guard.
15195 * aarch64-fbsd-tdep.h: Add include guard.
15196 * aarch32-linux-nat.h: Add include guard.
15197
151982019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15199
15200 * macrotab.c (macro_define_internal): New function that
15201 factorizes macro_define_object_internal and macro_define_function
15202 code.
15203 (macro_define_object_internal): Use macro_define_internal.
15204 (macro_define_function): Likewise.
15205
152062019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15207
15208 * macrocmd.c (extract_identifier): Return
15209 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15210 callers.
15211
152122019-02-06 John Baldwin <jhb@FreeBSD.org>
15213
15214 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15215
152162019-02-05 Tom Tromey <tom@tromey.com>
15217
15218 * target.c (target_stack::unpush): Move assertion earlier.
15219
152202019-01-30 Tom Tromey <tom@tromey.com>
15221
15222 PR python/23615:
15223 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15224 (gdbpy_parse_and_eval): Likewise.
15225 * python/python-internal.h (gdbpy_allow_threads): New class.
15226
152272019-01-28 John Baldwin <jhb@FreeBSD.org>
15228
15229 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15230 (aarch64_fbsd_fpregmap): Move earlier.
15231 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15232 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15233 instead of individual calls to trad_frame_set_reg_addr.
15234 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15235 earlier.
15236 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15237 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15238 instead of individual calls to trad_frame_set_reg_addr.
15239
152402019-01-28 Alan Hayward <alan.hayward@arm.com>
15241
15242 * CONTRIBUTE: Replace contribution list with wiki link.
15243
152442019-01-25 Tom Tromey <tom@tromey.com>
15245
15246 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15247
152482019-01-25 Tom Tromey <tom@tromey.com>
15249
15250 * xtensa-linux-nat.c: Fix common/ includes.
15251 * xml-support.h: Fix common/ includes.
15252 * xml-support.c: Fix common/ includes.
15253 * x86-linux-nat.c: Fix common/ includes.
15254 * windows-nat.c: Fix common/ includes.
15255 * varobj.h: Fix common/ includes.
15256 * varobj.c: Fix common/ includes.
15257 * value.c: Fix common/ includes.
15258 * valops.c: Fix common/ includes.
15259 * utils.c: Fix common/ includes.
15260 * unittests/xml-utils-selftests.c: Fix common/ includes.
15261 * unittests/utils-selftests.c: Fix common/ includes.
15262 * unittests/unpack-selftests.c: Fix common/ includes.
15263 * unittests/tracepoint-selftests.c: Fix common/ includes.
15264 * unittests/style-selftests.c: Fix common/ includes.
15265 * unittests/string_view-selftests.c: Fix common/ includes.
15266 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15267 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15268 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15269 * unittests/rsp-low-selftests.c: Fix common/ includes.
15270 * unittests/parse-connection-spec-selftests.c: Fix common/
15271 includes.
15272 * unittests/optional-selftests.c: Fix common/ includes.
15273 * unittests/offset-type-selftests.c: Fix common/ includes.
15274 * unittests/observable-selftests.c: Fix common/ includes.
15275 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15276 * unittests/memrange-selftests.c: Fix common/ includes.
15277 * unittests/memory-map-selftests.c: Fix common/ includes.
15278 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15279 * unittests/function-view-selftests.c: Fix common/ includes.
15280 * unittests/environ-selftests.c: Fix common/ includes.
15281 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15282 * unittests/common-utils-selftests.c: Fix common/ includes.
15283 * unittests/cli-utils-selftests.c: Fix common/ includes.
15284 * unittests/array-view-selftests.c: Fix common/ includes.
15285 * ui-file.c: Fix common/ includes.
15286 * tui/tui-io.c: Fix common/ includes.
15287 * tracepoint.h: Fix common/ includes.
15288 * tracepoint.c: Fix common/ includes.
15289 * tracefile-tfile.c: Fix common/ includes.
15290 * top.h: Fix common/ includes.
15291 * top.c: Fix common/ includes.
15292 * thread.c: Fix common/ includes.
15293 * target/waitstatus.h: Fix common/ includes.
15294 * target/waitstatus.c: Fix common/ includes.
15295 * target.h: Fix common/ includes.
15296 * target.c: Fix common/ includes.
15297 * target-memory.c: Fix common/ includes.
15298 * target-descriptions.c: Fix common/ includes.
15299 * symtab.h: Fix common/ includes.
15300 * symfile.c: Fix common/ includes.
15301 * stap-probe.c: Fix common/ includes.
15302 * spu-linux-nat.c: Fix common/ includes.
15303 * sparc-nat.c: Fix common/ includes.
15304 * source.c: Fix common/ includes.
15305 * solib.c: Fix common/ includes.
15306 * solib-target.c: Fix common/ includes.
15307 * ser-unix.c: Fix common/ includes.
15308 * ser-tcp.c: Fix common/ includes.
15309 * ser-pipe.c: Fix common/ includes.
15310 * ser-base.c: Fix common/ includes.
15311 * selftest-arch.c: Fix common/ includes.
15312 * s12z-tdep.c: Fix common/ includes.
15313 * rust-exp.y: Fix common/ includes.
15314 * rs6000-aix-tdep.c: Fix common/ includes.
15315 * riscv-tdep.c: Fix common/ includes.
15316 * remote.c: Fix common/ includes.
15317 * remote-notif.h: Fix common/ includes.
15318 * remote-fileio.h: Fix common/ includes.
15319 * remote-fileio.c: Fix common/ includes.
15320 * regcache.h: Fix common/ includes.
15321 * regcache.c: Fix common/ includes.
15322 * record-btrace.c: Fix common/ includes.
15323 * python/python.c: Fix common/ includes.
15324 * python/py-type.c: Fix common/ includes.
15325 * python/py-inferior.c: Fix common/ includes.
15326 * progspace.h: Fix common/ includes.
15327 * producer.c: Fix common/ includes.
15328 * procfs.c: Fix common/ includes.
15329 * proc-api.c: Fix common/ includes.
15330 * printcmd.c: Fix common/ includes.
15331 * ppc-linux-nat.c: Fix common/ includes.
15332 * parser-defs.h: Fix common/ includes.
15333 * osdata.c: Fix common/ includes.
15334 * obsd-nat.c: Fix common/ includes.
15335 * nat/x86-linux.c: Fix common/ includes.
15336 * nat/x86-linux-dregs.c: Fix common/ includes.
15337 * nat/x86-dregs.h: Fix common/ includes.
15338 * nat/x86-dregs.c: Fix common/ includes.
15339 * nat/ppc-linux.c: Fix common/ includes.
15340 * nat/mips-linux-watch.h: Fix common/ includes.
15341 * nat/mips-linux-watch.c: Fix common/ includes.
15342 * nat/linux-waitpid.c: Fix common/ includes.
15343 * nat/linux-ptrace.h: Fix common/ includes.
15344 * nat/linux-ptrace.c: Fix common/ includes.
15345 * nat/linux-procfs.c: Fix common/ includes.
15346 * nat/linux-personality.c: Fix common/ includes.
15347 * nat/linux-osdata.c: Fix common/ includes.
15348 * nat/linux-namespaces.c: Fix common/ includes.
15349 * nat/linux-btrace.h: Fix common/ includes.
15350 * nat/linux-btrace.c: Fix common/ includes.
15351 * nat/fork-inferior.c: Fix common/ includes.
15352 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15353 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15354 * nat/aarch64-linux.c: Fix common/ includes.
15355 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15356 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15357 * namespace.h: Fix common/ includes.
15358 * mips-linux-tdep.c: Fix common/ includes.
15359 * minsyms.c: Fix common/ includes.
15360 * mi/mi-parse.h: Fix common/ includes.
15361 * mi/mi-main.c: Fix common/ includes.
15362 * mi/mi-cmd-env.c: Fix common/ includes.
15363 * memrange.h: Fix common/ includes.
15364 * memattr.c: Fix common/ includes.
15365 * maint.h: Fix common/ includes.
15366 * maint.c: Fix common/ includes.
15367 * main.c: Fix common/ includes.
15368 * machoread.c: Fix common/ includes.
15369 * location.c: Fix common/ includes.
15370 * linux-thread-db.c: Fix common/ includes.
15371 * linux-nat.c: Fix common/ includes.
15372 * linux-fork.c: Fix common/ includes.
15373 * inline-frame.c: Fix common/ includes.
15374 * infrun.c: Fix common/ includes.
15375 * inflow.c: Fix common/ includes.
15376 * inferior.h: Fix common/ includes.
15377 * inferior.c: Fix common/ includes.
15378 * infcmd.c: Fix common/ includes.
15379 * inf-ptrace.c: Fix common/ includes.
15380 * inf-child.c: Fix common/ includes.
15381 * ia64-linux-nat.c: Fix common/ includes.
15382 * i387-tdep.c: Fix common/ includes.
15383 * i386-tdep.c: Fix common/ includes.
15384 * i386-linux-tdep.c: Fix common/ includes.
15385 * i386-linux-nat.c: Fix common/ includes.
15386 * i386-go32-tdep.c: Fix common/ includes.
15387 * i386-fbsd-tdep.c: Fix common/ includes.
15388 * i386-fbsd-nat.c: Fix common/ includes.
15389 * guile/scm-type.c: Fix common/ includes.
15390 * guile/guile.c: Fix common/ includes.
15391 * go32-nat.c: Fix common/ includes.
15392 * gnu-nat.c: Fix common/ includes.
15393 * gdbthread.h: Fix common/ includes.
15394 * gdbarch-selftests.c: Fix common/ includes.
15395 * gdb_usleep.c: Fix common/ includes.
15396 * gdb_select.h: Fix common/ includes.
15397 * gdb_bfd.c: Fix common/ includes.
15398 * gcore.c: Fix common/ includes.
15399 * fork-child.c: Fix common/ includes.
15400 * findvar.c: Fix common/ includes.
15401 * fbsd-nat.c: Fix common/ includes.
15402 * event-top.c: Fix common/ includes.
15403 * event-loop.c: Fix common/ includes.
15404 * dwarf2read.c: Fix common/ includes.
15405 * dwarf2loc.c: Fix common/ includes.
15406 * dwarf2-frame.c: Fix common/ includes.
15407 * dwarf-index-cache.c: Fix common/ includes.
15408 * dtrace-probe.c: Fix common/ includes.
15409 * disasm-selftests.c: Fix common/ includes.
15410 * defs.h: Fix common/ includes.
15411 * csky-tdep.c: Fix common/ includes.
15412 * cp-valprint.c: Fix common/ includes.
15413 * cp-support.h: Fix common/ includes.
15414 * cp-support.c: Fix common/ includes.
15415 * corelow.c: Fix common/ includes.
15416 * completer.h: Fix common/ includes.
15417 * completer.c: Fix common/ includes.
15418 * compile/compile.c: Fix common/ includes.
15419 * compile/compile-loc2c.c: Fix common/ includes.
15420 * compile/compile-cplus-types.c: Fix common/ includes.
15421 * compile/compile-cplus-symbols.c: Fix common/ includes.
15422 * command.h: Fix common/ includes.
15423 * cli/cli-dump.c: Fix common/ includes.
15424 * cli/cli-cmds.c: Fix common/ includes.
15425 * charset.c: Fix common/ includes.
15426 * build-id.c: Fix common/ includes.
15427 * btrace.h: Fix common/ includes.
15428 * btrace.c: Fix common/ includes.
15429 * breakpoint.h: Fix common/ includes.
15430 * breakpoint.c: Fix common/ includes.
15431 * ax.h:
15432 (enum agent_op): Fix common/ includes.
15433 * ax-general.c (struct aop_map): Fix common/ includes.
15434 * ax-gdb.c: Fix common/ includes.
15435 * auxv.c: Fix common/ includes.
15436 * auto-load.c: Fix common/ includes.
15437 * arm-tdep.c: Fix common/ includes.
15438 * arch/riscv.c: Fix common/ includes.
15439 * arch/ppc-linux-common.c: Fix common/ includes.
15440 * arch/i386.c: Fix common/ includes.
15441 * arch/arm.c: Fix common/ includes.
15442 * arch/arm-linux.c: Fix common/ includes.
15443 * arch/arm-get-next-pcs.c: Fix common/ includes.
15444 * arch/amd64.c: Fix common/ includes.
15445 * arch/aarch64.c: Fix common/ includes.
15446 * arch/aarch64-insn.c: Fix common/ includes.
15447 * arch-utils.c: Fix common/ includes.
15448 * amd64-windows-tdep.c: Fix common/ includes.
15449 * amd64-tdep.c: Fix common/ includes.
15450 * amd64-sol2-tdep.c: Fix common/ includes.
15451 * amd64-obsd-tdep.c: Fix common/ includes.
15452 * amd64-nbsd-tdep.c: Fix common/ includes.
15453 * amd64-linux-tdep.c: Fix common/ includes.
15454 * amd64-linux-nat.c: Fix common/ includes.
15455 * amd64-fbsd-tdep.c: Fix common/ includes.
15456 * amd64-fbsd-nat.c: Fix common/ includes.
15457 * amd64-dicos-tdep.c: Fix common/ includes.
15458 * amd64-darwin-tdep.c: Fix common/ includes.
15459 * agent.c: Fix common/ includes.
15460 * ada-lang.h: Fix common/ includes.
15461 * ada-lang.c: Fix common/ includes.
15462 * aarch64-tdep.c: Fix common/ includes.
15463
154642019-01-25 Tom Tromey <tom@tromey.com>
15465
15466 * common/create-version.sh: Use common/version.h.
15467
154682019-01-24 Pedro Alves <palves@redhat.com>
15469
15470 * infrun.c (signal_stop, signal_print, signal_program)
15471 (signal_catch, signal_pass): Now arrays instead of pointers.
15472 (update_signals_program_target, do_target_resume)
15473 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15474 * linux-nat.c (linux_nat_target::pass_signals)
15475 (linux_nat_target::create_inferior, linux_nat_target::attach):
15476 Adjust.
15477 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15478 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15479 * procfs.c (procfs_target::pass_signals): Adjust.
15480 * record-full.c (record_full_target::resume): Adjust.
15481 * remote.c (remote_target::pass_signals)
15482 (remote_target::program_signals): Adjust.
15483 * target-debug.h (target_debug_print_signals): Now takes a
15484 gdb::array_view as parameter. Adjust.
15485 * target.h (target_ops) <pass_signals, program_signals>: Replace
15486 pointer and length parameters with gdb::array_view.
15487 (target_pass_signals, target_program_signals): Likewise.
15488 * target-delegates.c: Regenerate.
15489
154902019-01-24 Pedro Alves <palves@redhat.com>
15491
15492 * common/forward-scope-exit.h
15493 (forward_scope_exit::forward_scope_exit): Pass arguments to
15494 m_bind_function directly, instead of creating a std::bind and
15495 copying that.
15496
154972019-01-24 Alan Hayward <alan.hayward@arm.com>
15498
15499 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15500 for static members.
15501 (pass_in_v_vfp_candidate): Likewise.
15502
155032019-01-23 Tom Tromey <tom@tromey.com>
15504 Pedro Alves <palves@redhat.com>
15505
15506 * regcache.c (class regcache_invalidator): Remove.
15507 (regcache::raw_write): Use make_scope_exit.
15508
155092019-01-23 Tom Tromey <tom@tromey.com>
15510
15511 * ui-out.h (class ui_out_emit_type): Update comment.
15512
155132019-01-23 Tom Tromey <tom@tromey.com>
15514
15515 * infrun.c (fetch_inferior_event): Update comment.
15516
155172019-01-23 Tom Tromey <tom@tromey.com>
15518 Pedro Alves <palves@redhat.com>
15519
15520 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15521 parameter.
15522 (fetch_inferior_event): Use SCOPE_EXIT.
15523
15524
155252019-01-23 Tom Tromey <tom@tromey.com>
15526 Pedro Alves <palves@redhat.com>
15527
15528 * infrun.c (disable_thread_events): Delete.
15529 (stop_all_threads): Use SCOPE_EXIT.
15530
155312019-01-23 Tom Tromey <tom@tromey.com>
15532 Pedro Alves <palves@redhat.com>
15533
15534 * symfile.c: Include forward-scope-exit.h.
15535 (clear_symtab_users_cleanup): Replace forward declaration with
15536 a FORWARD_SCOPE_EXIT.
15537 (syms_from_objfile_1): Use the forward_scope_exit and
15538 gdb::optional instead of cleanup_function.
15539 (reread_symbols): Use the forward_scope_exit instead of
15540 cleanup_function.
15541 (clear_symtab_users_cleanup): Remove function.
15542
155432019-01-23 Tom Tromey <tom@tromey.com>
15544 Pedro Alves <palves@redhat.com>
15545
15546 * linux-nat.c: Include scope-exit.h.
15547 (cleanup_target_stop): Remove.
15548 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15549 SCOPE_EXIT.
15550
155512019-01-23 Tom Tromey <tom@tromey.com>
15552 Pedro Alves <palves@redhat.com>
15553
15554 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15555 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15556
155572019-01-23 Tom Tromey <tom@tromey.com>
15558 Andrew Burgess <andrew.burgess@embecosm.com>
15559 Pedro Alves <palves@redhat.com>
15560
15561 * infrun.c (fetch_inferior_event): Use scope_exit.
15562 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15563 * top.c (execute_command): Use scope_exit.
15564 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15565 * utils.c (do_bpstat_clear_actions_cleanup)
15566 (make_bpstat_clear_actions_cleanup): Remove.
15567
155682019-01-23 Tom Tromey <tom@tromey.com>
15569 Pedro Alves <palves@redhat.com>
15570
15571 * infrun.c: Include "common/scope-exit.h"
15572 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15573 (wait_for_inferior): Use SCOPE_EXIT.
15574 (fetch_inferior_event): Use scope_exit.
15575
155762019-01-23 Tom Tromey <tom@tromey.com>
15577 Pedro Alves <palves@redhat.com>
15578
15579 * breakpoint.c (create_breakpoint): Remove cleanup.
15580
155812019-01-23 Tom Tromey <tom@tromey.com>
15582 Andrew Burgess <andrew.burgess@embecosm.com>
15583 Pedro Alves <palves@redhat.com>
15584
155852019-01-23 Pedro Alves <palves@redhat.com>
15586
15587 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15588
155892019-01-23 Pedro Alves <palves@redhat.com>
15590 Andrew Burgess <andrew.burgess@embecosm.com>
15591
15592 * gdbthread.h: Include "common/forward-scope-exit.h".
15593 (scoped_finish_thread_state): Redefine custom class in terms of
15594 forward_scope_exit.
15595
155962019-01-23 Pedro Alves <palves@redhat.com>
15597 Andrew Burgess <andrew.burgess@embecosm.com>
15598
15599 * common/forward-scope-exit.h: New file.
15600
156012019-01-23 Pedro Alves <palves@redhat.com>
15602 Andrew Burgess <andrew.burgess@embecosm.com>
15603 Tom Tromey <tom@tromey.com>
15604
15605 * common/scope-exit.h: New file.
15606
156072019-01-23 Pedro Alves <palves@redhat.com>
15608
15609 * common/preprocessor.h (ESC): Rename to ...
15610 (ESC_PARENS): ... this.
15611 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15612 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15613
156142019-01-23 Tom Tromey <tom@tromey.com>
15615
15616 * language.h (class scoped_switch_to_sym_language_if_auto):
15617 Initialize m_lang in both cases.
15618
156192019-01-23 Alan Hayward <alan.hayward@arm.com>
15620
15621 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15622 with XCNEW.
15623
156242019-01-22 Tom Tromey <tom@tromey.com>
15625
15626 * corelow.c: Do not include sys/file.h.
15627
156282019-01-22 Tom Tromey <tom@tromey.com>
15629
15630 * tui/tui-wingeneral.h: Include gdb_curses.h.
15631
156322019-01-22 Tom Tromey <tom@tromey.com>
15633
15634 * source-cache.h (class source_cache) <get_source_lines,
15635 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15636
156372019-01-22 Tom Tromey <tom@tromey.com>
15638
15639 * remote-fileio.h (struct remote_target): Declare.
15640
156412019-01-22 Tom Tromey <tom@tromey.com>
15642
15643 * python/py-arch.c: Do not include py-ref.h.
15644 * python/py-bpevent.c: Do not include py-ref.h.
15645 * python/py-cmd.c: Do not include py-ref.h.
15646 * python/py-continueevent.c: Do not include py-ref.h.
15647 * python/py-event.h: Do not include py-ref.h.
15648 * python/py-evtregistry.c: Do not include py-ref.h.
15649 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15650 * python/py-frame.c: Do not include py-ref.h.
15651 * python/py-framefilter.c: Do not include py-ref.h.
15652 * python/py-function.c: Do not include py-ref.h.
15653 * python/py-infevents.c: Do not include py-ref.h.
15654 * python/py-linetable.c: Do not include py-ref.h.
15655 * python/py-objfile.c: Do not include py-ref.h.
15656 * python/py-param.c: Do not include py-ref.h.
15657 * python/py-prettyprint.c: Do not include py-ref.h.
15658 * python/py-progspace.c: Do not include py-ref.h.
15659 * python/py-symbol.c: Do not include py-ref.h.
15660 * python/py-symtab.c: Do not include py-ref.h.
15661 * python/py-type.c: Do not include py-ref.h.
15662 * python/py-unwind.c: Do not include py-ref.h.
15663 * python/py-utils.c: Do not include py-ref.h.
15664 * python/py-value.c: Do not include py-ref.h.
15665 * python/py-varobj.c: Do not include py-ref.h.
15666 * python/py-xmethods.c: Do not include py-ref.h.
15667 * python/python.c: Do not include py-ref.h.
15668 * varobj.c: Do not include py-ref.h.
15669
156702019-01-22 Tom Tromey <tom@tromey.com>
15671
15672 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15673 keyword for bcache.
15674
156752019-01-22 Tom Tromey <tom@tromey.com>
15676
15677 * compile/compile-cplus-types.c: Remove a comment by #include.
15678
156792019-01-22 Tom Tromey <tom@tromey.com>
15680
15681 * compile/gcc-c-plugin.h: Include compile-internal.h.
15682
156832019-01-22 Tom Tromey <tom@tromey.com>
15684
15685 * stabsread.c (EXTERN): Do not define.
15686 (symnum, next_symbol_text_func, processing_gcc_compilation)
15687 (within_function, global_sym_chain, global_stabs)
15688 (previous_stab_code, this_object_header_files)
15689 (n_this_object_header_files)
15690 (n_allocated_this_object_header_files): Define.
15691 * stabsread.h (EXTERN): Never define. Use "extern".
15692
156932019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15694
15695 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15696 history_value.
15697
156982019-01-21 Tom Tromey <tom@tromey.com>
15699
15700 * ui-out.c: Fix includes.
15701 * tui/tui-source.c: Fix includes.
15702 * target.c: Fix includes.
15703 * remote.c: Fix includes.
15704 * regcache.c: Fix includes.
15705 * python/py-block.c: Fix includes.
15706 * printcmd.c: Fix includes.
15707 * or1k-tdep.c: Fix includes.
15708 * mi/mi-main.c: Fix includes.
15709 * m32r-tdep.c: Fix includes.
15710 * csky-tdep.c: Fix includes.
15711 * compile/compile-cplus-types.c: Fix includes.
15712 * cli/cli-interp.c: Fix includes.
15713
157142019-01-21 Alan Hayward <alan.hayward@arm.com>
15715
15716 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15717 for padding.
15718
157192019-01-16 Tom Tromey <tom@tromey.com>
15720
15721 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15722 earlier.
15723 (struct objfile) <msymbols_range>: Move from top level.
15724 <msymbols>: New method.
15725 (class objfile_msymbols): Remove.
15726 * symtab.c (default_collect_symbol_completion_matches_break_on):
15727 Update.
15728 * symmisc.c (dump_msymbols): Update.
15729 * stabsread.c (scan_file_globals): Update.
15730 * objc-lang.c (info_selectors_command, info_classes_command)
15731 (find_methods): Update.
15732 * minsyms.c (find_solib_trampoline_target): Update.
15733 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15734 * coffread.c (coff_symfile_read): Update.
15735 * ada-lang.c (ada_lookup_simple_minsym)
15736 (ada_collect_symbol_completion_matches): Update.
15737
157382019-01-16 Tom Tromey <tom@tromey.com>
15739
15740 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15741 type. Remove no-argument constructor.
15742 <iterator::operator++>: Simplify.
15743 <begin>: Update.
15744 <end>: Use minimal_symbol_count.
15745
157462019-01-16 Tom Tromey <tom@tromey.com>
15747
15748 * objfiles.h (struct objfile) <psymtabs>: New method.
15749 (class objfile_psymtabs): Remove.
15750 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15751 typedef.
15752 <range>: New method.
15753 (require_partial_symbols): Change return type.
15754 * psymtab.c (require_partial_symbols)
15755 (psym_expand_symtabs_matching): Update.
15756 * mdebugread.c (parse_partial_symbols): Update.
15757 * dbxread.c (dbx_end_psymtab): Update.
15758
157592019-01-15 Tom Tromey <tom@tromey.com>
15760
15761 * symtab.c (lookup_objfile_from_block)
15762 (lookup_symbol_in_objfile_symtabs)
15763 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15764 (find_line_symtab, info_sources_command)
15765 (default_collect_symbol_completion_matches_break_on)
15766 (make_source_files_completion_list): Update.
15767 * symmisc.c (print_objfile_statistics, dump_objfile)
15768 (maintenance_print_symbols, maintenance_info_symtabs)
15769 (maintenance_check_symtabs, maintenance_info_line_tables):
15770 Update.
15771 * source.c (select_source_symtab)
15772 (forget_cached_source_info_for_objfile): Update.
15773 * objfiles.h (class objfile_compunits): Remove.
15774 (struct objfile) <compunits_range>: New typedef.
15775 (compunits): New method.
15776 * objfiles.c (objfile_relocate1): Update.
15777 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15778 * maint.c (count_symtabs_and_blocks): Update.
15779 * linespec.c (iterate_over_all_matching_symtabs): Update.
15780 * cp-support.c (add_symbol_overload_list_qualified): Update.
15781 * coffread.c (coff_symtab_read): Update.
15782 * ada-lang.c (add_nonlocal_symbols)
15783 (ada_collect_symbol_completion_matches)
15784 (ada_add_global_exceptions): Update.
15785
157862019-01-15 Tom Tromey <tom@tromey.com>
15787
15788 * progspace.h (program_space) <objfiles_safe_range>: New
15789 typedef.
15790 <objfiles_safe>: New method.
15791 * objfiles.h (class all_objfiles_safe): Remove.
15792 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15793 * jit.c (jit_inferior_exit_hook): Update.
15794
157952019-01-17 Tom Tromey <tom@tromey.com>
15796
15797 * progspace.h (program_space) <objfiles_range>: New typedef.
15798 <objfiles>: New method.
15799 <objfiles_head>: Rename from objfiles.
15800 (object_files): Update.
15801 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15802 * guile/scm-pretty-print.c
15803 (ppscm_find_pretty_printer_from_objfiles): Update.
15804 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15805 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15806 Update.
15807 * python/py-progspace.c (pspy_get_objfiles): Update.
15808 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15809 Update.
15810 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15811 (objfpy_lookup_objfile_by_build_id): Update.
15812 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15813 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15814 Update.
15815 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15816 (expand_symtab_containing_pc, lookup_objfile_from_block)
15817 (lookup_static_symbol, basic_lookup_transparent_type)
15818 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15819 (find_line_symtab, info_sources_command)
15820 (default_collect_symbol_completion_matches_break_on)
15821 (make_source_files_completion_list, find_main_name): Update.
15822 * symmisc.c (print_symbol_bcache_statistics)
15823 (print_objfile_statistics, maintenance_print_symbols)
15824 (maintenance_print_msymbols, maintenance_print_objfiles)
15825 (maintenance_info_symtabs, maintenance_check_symtabs)
15826 (maintenance_expand_symtabs, maintenance_info_line_tables):
15827 Update.
15828 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15829 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15830 (map_overlay_command, unmap_overlay_command)
15831 (simple_overlay_update, expand_symtabs_matching)
15832 (map_symbol_filenames): Update.
15833 * symfile-debug.c (set_debug_symfile): Update.
15834 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15835 Update.
15836 * source.c (select_source_symtab, forget_cached_source_info):
15837 Update.
15838 * solib.c (solib_read_symbols): Update.
15839 * solib-spu.c (append_ocl_sos): Update.
15840 * psymtab.c (maintenance_print_psymbols)
15841 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15842 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15843 * printcmd.c (info_symbol_command): Update.
15844 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15845 Update.
15846 * objfiles.h (class all_objfiles): Remove.
15847 * objfiles.c (have_partial_symbols, have_full_symbols)
15848 (have_minimal_symbols, qsort_cmp, update_section_map)
15849 (shared_objfile_contains_address_p)
15850 (default_iterate_over_objfiles_in_search_order): Update.
15851 * objc-lang.c (info_selectors_command, info_classes_command)
15852 (find_methods): Update.
15853 * minsyms.c (find_solib_trampoline_target): Update.
15854 * maint.c (maintenance_info_sections)
15855 (maintenance_translate_address, count_symtabs_and_blocks):
15856 Update.
15857 * main.c (captured_main_1): Update.
15858 * linux-thread-db.c (try_thread_db_load_from_pdir)
15859 (has_libpthread): Update.
15860 * linespec.c (iterate_over_all_matching_symtabs)
15861 (search_minsyms_for_name): Update.
15862 * jit.c (jit_find_objf_with_entry_addr): Update.
15863 * hppa-tdep.c (find_unwind_entry)
15864 (hppa_lookup_stub_minimal_symbol): Update.
15865 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15866 Update.
15867 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15868 (elf_gnu_ifunc_resolve_by_got): Update.
15869 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15870 * dwarf-index-write.c (save_gdb_index_command): Update.
15871 * cp-support.c (add_symbol_overload_list_qualified): Update.
15872 * breakpoint.c (create_overlay_event_breakpoint)
15873 (create_longjmp_master_breakpoint)
15874 (create_std_terminate_master_breakpoint)
15875 (create_exception_master_breakpoint): Update.
15876 * blockframe.c (find_pc_partial_function): Update.
15877 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15878 (ada_collect_symbol_completion_matches)
15879 (ada_add_global_exceptions): Update.
15880
158812019-01-17 Tom Tromey <tom@tromey.com>
15882
15883 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15884 declare VEC.
15885 (solib_target_parse_libraries): Change return type.
15886 (library_list_start_segment, library_list_start_section)
15887 (library_list_end_library, library_list_start_library); Update.
15888 (solib_target_free_library_list): Remove.
15889 (solib_target_parse_libraries): Remove cleanup. Change return
15890 type.
15891 (solib_target_current_sos): Update.
15892
158932019-01-17 Tom Tromey <tromey@bapiya>
15894
15895 * valprint.c: Replace "the the" with "the".
15896 * symtab.c: Replace "the the" with "the".
15897 * solib.c: Replace "the the" with "the".
15898 * solib-dsbt.c: Replace "the the" with "the".
15899 * linespec.c: Replace "the the" with "the".
15900 * dwarf2loc.h: Replace "the the" with "the".
15901 * amd64-windows-tdep.c: Replace "the the" with "the".
15902 * aarch64-tdep.c: Replace "the the" with "the".
15903
159042019-01-16 Keith Seitz <keiths@redhat.com>
15905
15906 PR gdb/23773
15907 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15908 <builder>: Rename to ..
15909 <m_builder>: ... this and make private.
15910 (dwarf2_cu::get_builder): New method. Change all users of
15911 `builder' to use this method.
15912 (dwarf2_start_symtab): Move to ...
15913 (dwarf2_cu::start_symtab): ... here. Update all callers
15914 (setup_type_unit_groups): Move to ...
15915 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15916 callers.
15917 (dwarf2_cu::reset_builder): New method.
15918 (process_full_compunit, process_full_type_unit): Use
15919 dwarf2_cu::reset_builder.
15920 (follow_die_offset): Record the ancestor CU if it is different
15921 from the followed DIE's CU.
15922 (follow_die_sig_1): Likewise.
15923
159242019-01-15 Tom Tromey <tom@tromey.com>
15925
15926 * remote.c (class remote_state) <buf>: Now a char_vector.
15927 <buf_size>: Remove.
15928 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15929 parameter.
15930 (remote_target::getpkt_or_notif_sane_1)
15931 (remote_target::getpkt_sane)
15932 (remote_target::getpkt_or_notif_sane): Likewise.
15933 (class remote_target) <putpkt>: New overload.
15934 (remote_target::read_frame): Change type of "buf_p". Remove
15935 sizeof_p parameter.
15936 (packet_ok): New overload.
15937 (packet_check_result): New overload.
15938 Update all uses.
15939
159402019-01-14 Tom Tromey <tom@tromey.com>
15941
15942 * remote-notif.c (handle_notification, remote_notif_ack)
15943 (remote_notif_parse): Make "buf" const.
15944 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15945 const.
15946 (remote_notif_parse, remote_notif_ack, handle_notification):
15947 Likewise.
15948 * remote.c (remote_notif_stop_parse): Make "buf" const.
15949 (remote_target::remote_parse_stop_reply): Make "buf" const.
15950 (remote_notif_stop_ack): Make "buf" const.
15951
159522019-01-14 Tom Tromey <tom@tromey.com>
15953
15954 * remote.c (remote_console_output): Make parameter const.
15955
159562019-01-14 Tom Tromey <tom@tromey.com>
15957
15958 * target-debug.h (target_debug_print_signals): Constify.
15959 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15960 * procfs.c (procfs_target::pass_signals): Update.
15961 * linux-nat.c (linux_nat_target::pass_signals): Update.
15962 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15963 * target-delegates.c: Rebuild.
15964 * remote.c (remote_target::program_signals): Update.
15965 (remote_target::pass_signals): Update.
15966 * target.c (target_pass_signals): Constify argument.
15967 (target_program_signals): Likewise.
15968 * target.h (struct target_ops) <pass_signals, program_signals>:
15969 Constify argument.
15970 (target_pass_signals, target_program_signals): Constify argument.
15971
159722019-01-14 Tom Tromey <tom@tromey.com>
15973
15974 PR tui/28819:
15975 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15976
159772019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15978
15979 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15980 field.
15981 * rs6000-tdep.c: Include reggroups.h.
15982 (IS_V_ALIAS_PSEUDOREG): Define.
15983 (rs6000_register_name): Return names for the "vX" aliases.
15984 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15985 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15986 aliases. Call default_register_reggroup_p for all other
15987 pseudo-registers.
15988 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15989 New functions.
15990 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15991 Handle "vX" aliases.
15992 (v_alias_pseudo_register_collect): New function.
15993 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15994 (rs6000_gdbarch_init): Initialize "vX" aliases as
15995 pseudo-registers. Restore registration of
15996 rs6000_pseudo_register_reggroup_p with
15997 set_tdesc_pseudo_register_reggroup_p.
15998
159992019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16000
16001 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16002 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16003 set_gdbarch_num_pseudo_regs.
16004
160052019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16006
16007 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16008 Remove arg prefixname, add do_set and do_show.
16009 Add member functions set_list and show_list.
16010 * cli/cli-style.c (class cli_style_option): Update accordingly.
16011 (style_set_list): Move to file scope.
16012 (style_show_list): Likewise.
16013 (set_style): Call help_list.
16014 (show_style): Call cmd_show_list.
16015 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16016 Update to use the new macro.
16017
160182019-10-12 Joel Brobecker <brobecker@adacore.com>
16019
16020 * ada-lang.c (_initialize_ada_language): Expand the help text
16021 for the "catch exception" command.
16022
160232019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16024
16025 * symtab.c (matching_obj_sections): Initialize obj,
16026 declare it closer to its usage.
16027
160282019-01-10 Tom Tromey <tom@tromey.com>
16029
16030 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16031 (basic_inf_threads_range): Remove.
16032 (inf_threads_range, inf_non_exited_threads_range)
16033 (safe_inf_threads_range): Use next_adapter.
16034
160352019-01-10 Keith Seitz <keiths@redhat.com>
16036
16037 PR gdb/23712
16038 PR symtab/23010
16039 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16040 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16041
160422019-01-10 Keith Seitz <keiths@redhat.com>
16043
16044 PR gdb/23712
16045 PR symtab/23010
16046 * dictionary.c (pending_to_vector): Remove.
16047 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16048 Remove _1 suffix, replacing functions of the same name. Update
16049 all callers.
16050 (dict_create_hashed, dict_create_hashed_expandable)
16051 (dict_create_linear, dict_create_linear_expandable, dict_free)
16052 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16053 Make functions static.
16054
160552019-01-10 Keith Seitz <keiths@redhat.com>
16056
16057 PR gdb/23712
16058 PR symtab/23010
16059 * dictionary.h (struct dictionary): Replace declaration with
16060 multidictionary.
16061 (dict_create_hashed, dict_create_hashed_expandable)
16062 (dict_create_linear, dict_create_linear_expandable)
16063 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16064 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16065 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16066 taking multidictionary argument.
16067 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16068 * block.h (struct block) <dict>: Change to multidictionary
16069 and rename `multidict'.
16070 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16071 symmisc.c: Update all dictionary references to multidictionary.
16072
160732019-01-10 Keith Seitz <keiths@redhat.com>
16074
16075 PR gdb/23712
16076 PR symtab/23010
16077 * dictionary.c: Include unordered_map.
16078 (pending_to_vector): New function.
16079 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16080 Rewrite the non-"_1" functions to take vector instead
16081 of linked list.
16082 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16083 "new" _1 versions of the same name.
16084 (multidictionary): Define.
16085 (std::hash<enum language): New definition.
16086 (collate_pending_symbols_by_language, mdict_create_hashed)
16087 (mdict_create_hashed_expandable, mdict_create_linear)
16088 (mdict_create_linear_expandable, mdict_free)
16089 (find_language_dictionary, create_new_language_dictionary)
16090 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16091 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16092 (mdict_size, mdict_empty): New functions.
16093 * dictionary.h (mdict_iterator): Define.
16094
160952019-01-10 Pedro Alves <palves@redhat.com>
16096
16097 * breakpoint.c (read_uploaded_action)
16098 (create_tracepoint_from_upload): Adjust to use
16099 gdb::unique_xmalloc_ptr.
16100 * ctf.c (ctf_write_uploaded_tp):
16101 (SET_ARRAY_FIELD): Use emplace_back.
16102 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16103 * tracefile-tfile.c (tfile_write_uploaded_tp):
16104 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16105 gdb::unique_xmalloc_ptr.
16106 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16107 at_string, cond_string, cmd_strings>: Replace char pointers
16108 with gdb::unique_xmalloc_ptr.
16109
161102019-01-10 Pedro Alves <palves@redhat.com>
16111
16112 * solib-target.c (library_list_start_library): Don't xstrdup name.
16113
161142019-01-10 Pedro Alves <palves@redhat.com>
16115
16116 * mdebugread.c (parse_partial_symbols): Use
16117 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16118
161192019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16120
16121 * linux-fork.c (scoped_switch_fork_info)
16122 <~scoped_switch_fork_info>: Fix incorrect variable name.
16123
161242019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16125
16126 * linux-fork.c (scoped_switch_fork_info)
16127 <scoped_switch_fork_info>: Make explicit.
16128 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16129
161302019-01-10 Tom Tromey <tom@tromey.com>
16131
16132 * objfiles.h (objfile::reset_psymtabs): Update.
16133 * objfiles.c (objfile::objfile): Update.
16134 * psymtab.h (psymtab_storage::obstack): Update.
16135 (psymtab_storage::m_obstack): Use gdb::optional.
16136 (class psymtab_storage): Update comment. Remove objfile
16137 parameter.
16138 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16139
161402019-01-10 Tom Tromey <tom@tromey.com>
16141
16142 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16143 <free_psymtabs>: Now private.
16144 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16145 (allocate_psymtab): Use new method.
16146
161472019-01-10 Tom Tromey <tom@tromey.com>
16148
16149 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16150 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16151 * mdebugread.c (parse_partial_symbols): Use
16152 allocate_dependencies.
16153 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16154 allocate_dependencies.
16155 (process_psymtab_comp_unit_reader)
16156 (build_type_psymtab_dependencies): Likewise.
16157 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16158
161592019-01-10 Tom Tromey <tom@tromey.com>
16160
16161 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16162 PSYMBOL_SET_LANGUAGE.
16163 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16164
161652019-01-10 Tom Tromey <tom@tromey.com>
16166
16167 * psymtab.h (psymtab_storage::obstack): New method.
16168 <m_obstack>: Rename from obstack; now private.
16169 * psymtab.c (psymtab_storage): Update.
16170 * dwarf2read.c (create_addrmap_from_index)
16171 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16172 Update.
16173
161742019-01-10 Tom Tromey <tom@tromey.com>
16175
16176 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16177 * objfiles.h (objfile::reset_psymtabs): New method.
16178
161792019-01-10 Tom Tromey <tom@tromey.com>
16180
16181 * symmisc.c (print_symbol_bcache_statistics): Update.
16182 (print_objfile_statistics): Update.
16183 * symfile.c (reread_symbols): Update.
16184 * psymtab.h (class psymtab_storage): New.
16185 * psymtab.c (psymtab_storage): New constructor.
16186 (~psymtab_storage): New destructor.
16187 (require_partial_symbols): Update.
16188 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16189 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16190 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16191 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16192 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16193 (start_psymtab_common, end_psymtab_common)
16194 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16195 (allocate_psymtab): Update.
16196 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16197 Update.
16198 (dump_psymtab_addrmap, maintenance_print_psymbols)
16199 (maintenance_check_psymtabs): Update.
16200 (class objfile_psymtabs): Move to objfiles.h.
16201 * psympriv.h (discard_psymtab): Now inline.
16202 (psymtab_discarder::psymtab_discarder): Update.
16203 (psymtab_discarder::~psymtab_discarder): Update.
16204 (ALL_OBJFILE_PSYMTABS): Rewrite.
16205 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16206 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16207 Remove fields.
16208 <partial_symtabs>: New field.
16209 (class objfile_psymtabs): Move from psymtab.h. Update.
16210 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16211 psymbol_cache.
16212 (objfile::~objfile): Don't destroy psymbol_cache.
16213 * mdebugread.c (parse_partial_symbols): Update.
16214 * dwarf2read.c (create_addrmap_from_index)
16215 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16216 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16217 (add_partial_subprogram, dwarf2_ranges_read): Update.
16218 * dwarf-index-write.c (write_address_map)
16219 (write_one_signatured_type, recursively_write_psymbols)
16220 (class debug_names, class debug_names, write_psymtabs_to_index):
16221 Update.
16222
162232019-01-10 Tom Tromey <tom@tromey.com>
16224
16225 * symtab.h (SYMBOL_SET_NAMES): Update.
16226 (symbol_set_names): Update.
16227 (MSYMBOL_SET_NAMES): Update.
16228 * symtab.c (symbol_set_names): Change argument to be an
16229 objfile_per_bfd_storage.
16230 * psymtab.c (add_psymbol_to_bcache): Update.
16231 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16232
162332019-01-10 Tom Tromey <tom@tromey.com>
16234
16235 * symtab.c (create_demangled_names_hash): Change argument to be an
16236 objfile_per_bfd_storage.
16237 (symbol_set_names): Update.
16238
162392019-01-10 Tom Tromey <tom@tromey.com>
16240
16241 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16242 init_psymbol_list.
16243 * psymtab.c (init_psymbol_list): Do nothing if already called.
16244 * psympriv.h (init_psymbol_list): Add comment.
16245 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16246 init_psymbol_list.
16247 * dbxread.c (dbx_symfile_read): Unconditionally call
16248 init_psymbol_list.
16249
162502019-01-10 Tom Tromey <tom@tromey.com>
16251
16252 * xcoffread.c (scan_xcoff_symtab): Update.
16253 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16254 "where".
16255 * mdebugread.c (parse_partial_symbols)
16256 (handle_psymbol_enumerators): Update.
16257 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16258 * dbxread.c (read_dbx_symtab): Update.
16259 * psympriv.h (psymbol_placement): New enum.
16260 (add_psymbol_to_list): Update.
16261
162622019-01-10 Tom Tromey <tom@tromey.com>
16263
16264 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16265 static_psymbols parameters.
16266 (scan_xcoff_symtab): Update.
16267 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16268 static_psymbols parameters.
16269 * psympriv.h (start_psymtab_common): Update.
16270 * mdebugread.c (parse_partial_symbols): Update.
16271 * dwarf2read.c (create_partial_symtab): Update.
16272 * dbxread.c (read_dbx_symtab): Update.
16273 (start_psymtab): Remove global_psymbols and static_psymbols
16274 parameters.
16275
162762019-01-10 Tom Tromey <tom@tromey.com>
16277
16278 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16279 * psymtab.c (allocate_psymtab): Add comment.
16280 * psympriv.h (allocate_psymtab): Add comment.
16281 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16282 initializations.
16283 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16284
162852019-01-10 Tom Tromey <tom@tromey.com>
16286
16287 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16288 Don't declare.
16289 * mipsread.c: Include mdebugread.h.
16290 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16291 Declare.
16292 * elfread.c: Include mdebugread.h.
16293
162942019-01-09 Tom Tromey <tom@tromey.com>
16295
16296 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16297 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16298 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16299 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16300 (psym_lookup_symbol, psym_find_last_source_symtab)
16301 (psym_forget_cached_source_info, psym_print_stats)
16302 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16303 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16304 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16305 (psym_find_compunit_symtab_by_address)
16306 (maintenance_print_psymbols, maintenance_info_psymtabs)
16307 (maintenance_check_psymtabs): Use ranged for.
16308 * psymtab.h (class objfile_psymtabs): New.
16309 (require_partial_symbols): Return objfile_psymtabs.
16310 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16311
163122019-01-09 Tom Tromey <tom@tromey.com>
16313
16314 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16315 (find_pc_mapped_section, list_overlays_command)
16316 (map_overlay_command, unmap_overlay_command)
16317 (simple_overlay_update): Use all_objfiles.
16318 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16319 * printcmd.c (info_symbol_command): Use all_objfiles.
16320 * objfiles.h (ALL_OBJSECTIONS): Remove.
16321 * maint.c (maintenance_translate_address): Use all_objfiles.
16322 * gcore.c (gcore_create_callback): Use all_objfiles.
16323 (objfile_find_memory_regions): Likewise.
16324
163252019-01-09 Tom Tromey <tom@tromey.com>
16326
16327 * symtab.c (find_line_symtab, info_sources_command)
16328 (make_source_files_completion_list): Use objfile_compunits.
16329 * source.c (select_source_symtab): Use objfile_compunits.
16330 * objfiles.h (struct objfile): Update comment.
16331 (ALL_OBJFILES): Remove.
16332 (ALL_FILETABS): Remove.
16333 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16334 objfile_compunits.
16335
163362019-01-09 Tom Tromey <tom@tromey.com>
16337
16338 * symmisc.c (print_objfile_statistics, dump_objfile)
16339 (maintenance_print_symbols): Use compunit_filetabs.
16340 * source.c (forget_cached_source_info_for_objfile): Use
16341 compunit_filetabs.
16342 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16343 (ALL_FILETABS): Use compunit_filetabs.
16344 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16345 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16346
163472019-01-09 Tom Tromey <tom@tromey.com>
16348
16349 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16350 (compunit_filetabs): New.
16351 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16352 compunit_filetabs.
16353 (info_sources_command, make_source_files_completion_list): Remove
16354 declaration.
16355 * symmisc.c (print_objfile_statistics, dump_objfile)
16356 (maintenance_print_symbols): Remove declaration.
16357 (maintenance_info_symtabs): Use compunit_filetabs.
16358 (maintenance_info_line_tables): Likewise.
16359 * source.c (select_source_symtab): Change local variable name.
16360 (forget_cached_source_info_for_objfile): Remove declaration.
16361 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16362 * objfiles.c (objfile_relocate1): Remove declaration.
16363 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16364 declaration.
16365 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16366 * coffread.c (coff_symtab_read): Remove declaration.
16367 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16368 compunit_filetabs.
16369
163702019-01-09 Tom Tromey <tom@tromey.com>
16371
16372 * symtab.c (lookup_objfile_from_block)
16373 (find_pc_sect_compunit_symtab, search_symbols)
16374 (default_collect_symbol_completion_matches_break_on): Use
16375 objfile_compunits.
16376 * objfiles.h (ALL_COMPUNITS): Remove.
16377 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16378 * cp-support.c (add_symbol_overload_list_qualified): Use
16379 objfile_compunits.
16380 * ada-lang.c (ada_collect_symbol_completion_matches)
16381 (ada_add_global_exceptions): Use objfile_compunits.
16382
163832019-01-09 Tom Tromey <tom@tromey.com>
16384
16385 * source.c (select_source_symtab)
16386 (forget_cached_source_info_for_objfile): Remove declaration.
16387 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16388 declaration.
16389 * maint.c (count_symtabs_and_blocks): Remove declaration.
16390 * cp-support.c (add_symbol_overload_list_qualified): Remove
16391 declaration.
16392 * coffread.c (coff_symtab_read): Remove declaration.
16393 * symtab.c (lookup_symbol_in_objfile_symtabs)
16394 (basic_lookup_transparent_type_1): Use objfile_compunits.
16395 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16396 (info_sources_command, search_symbols)
16397 (default_collect_symbol_completion_matches_break_on)
16398 (make_source_files_completion_list): Remove declaration.
16399 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16400 (ada_collect_symbol_completion_matches)
16401 (ada_add_global_exceptions): Remove declaration.
16402 * linespec.c (iterate_over_all_matching_symtabs): Use
16403 objfile_compunits.
16404 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16405 (class objfile_compunits): New.
16406 (ALL_COMPUNITS): Use objfile_compunits.
16407 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16408 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16409 objfile_compunits.
16410 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16411
164122019-01-09 Tom Tromey <tom@tromey.com>
16413
16414 * symtab.c (search_symbols)
16415 (default_collect_symbol_completion_matches_break_on): Use
16416 objfile_msymbols.
16417 * ada-lang.c (ada_lookup_simple_minsym)
16418 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16419 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16420 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16421 objfile_msymbols.
16422 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16423 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16424 * objc-lang.c (find_methods): Use objfile_msymbols.
16425 (info_selectors_command, info_classes_command): Likewise.
16426 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16427 * objfiles.h (class objfile_msymbols): New.
16428 (ALL_OBJFILE_MSYMBOLS): Remove.
16429 (ALL_MSYMBOLS): Remove.
16430
164312019-01-09 Tom Tromey <tom@tromey.com>
16432
16433 * common/next-iterator.h (next_adapter): Add Iterator template
16434 parameter.
16435 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16436 (class all_objfiles_safe): New.
16437 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16438 * objfiles.c (put_objfile_before): Update comment.
16439 (add_separate_debug_objfile): Likewise.
16440 (free_all_objfiles): Use all_objfiles_safe.
16441 (objfile_purge_solibs): Likewise.
16442
164432019-01-09 Tom Tromey <tom@tromey.com>
16444
16445 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16446 (expand_symtab_containing_pc, lookup_static_symbol)
16447 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16448 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16449 all_objfiles.
16450 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16451 * breakpoint.c (create_overlay_event_breakpoint)
16452 (create_longjmp_master_breakpoint)
16453 (create_std_terminate_master_breakpoint)
16454 (create_exception_master_breakpoint): Use all_objfiles.
16455 * linux-thread-db.c (try_thread_db_load_from_pdir)
16456 (has_libpthread): Use all_objfiles.
16457 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16458 * linespec.c (iterate_over_all_matching_symtabs)
16459 (search_minsyms_for_name): Use all_objfiles.
16460 * maint.c (maintenance_info_sections): Use all_objfiles.
16461 * main.c (captured_main_1): Use all_objfiles.
16462 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16463 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16464 * guile/scm-pretty-print.c
16465 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16466 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16467 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16468 (maintenance_print_msymbols): Use all_objfiles.
16469 * source.c (select_source_symtab): Use all_objfiles.
16470 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16471 * symfile.c (remove_symbol_file_command)
16472 (expand_symtabs_matching, map_symbol_filenames): Use
16473 all_objfiles.
16474 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16475 all_objfiles.
16476 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16477 * objc-lang.c (find_methods): Use all_objfiles.
16478 * objfiles.c (have_partial_symbols, have_full_symbols)
16479 (have_minimal_symbols, qsort_cmp)
16480 (default_iterate_over_objfiles_in_search_order): Use
16481 all_objfiles.
16482 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16483 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16484 (maintenance_check_psymtabs): Use all_objfiles.
16485 (ALL_PSYMTABS): Remove.
16486 * compile/compile-object-run.c (do_module_cleanup): Use
16487 all_objfiles.
16488 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16489 * cp-support.c (add_symbol_overload_list_qualified): Use
16490 all_objfiles.
16491 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16492 Use all_objfiles.
16493 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16494 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16495 all_objfiles.
16496 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16497 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16498 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16499 Uses all_objfiles.
16500 * solib.c (solib_read_symbols): Use all_objfiles
16501
165022019-01-09 Tom Tromey <tom@tromey.com>
16503
16504 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16505 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16506 all_objfiles.
16507 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16508 * symmisc.c (print_symbol_bcache_statistics)
16509 (print_objfile_statistics, maintenance_print_objfiles)
16510 (maintenance_info_symtabs, maintenance_check_symtabs)
16511 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16512 all_objfiles.
16513 * source.c (forget_cached_source_info): Use all_objfiles.
16514 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16515 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16516 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16517 * objfiles.c (update_section_map): Use all_objfiles.
16518 (shared_objfile_contains_address_p): Likewise.
16519 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16520 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16521
165222019-01-09 Tom Tromey <tom@tromey.com>
16523
16524 * common/next-iterator.h: New file.
16525 * objfiles.h (class all_objfiles): New.
16526 (struct objfile_iterator): New.
16527
165282019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16529
16530 * NEWS: Move the description of the changed "frame", "select-frame",
16531 and "info frame" commands to the Changed commands section.
16532
165332019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16534
16535 * gdbtypes.c (check_stub_method_group): Remove handling of old
16536 mangling schemes.
16537 * linespec.c (find_methods): Likewise.
16538 * stabsread.c (read_member_functions): Likewise.
16539 * valops.c (search_struct_method): Likewise.
16540 (value_struct_elt_for_reference): Likewise.
16541 * NEWS: Mention this change.
16542
165432019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16544
16545 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16546 print_source_lines.
16547 * source.c (print_source_lines_base): Update line number check.
16548 (print_source_lines): New function.
16549 (source_lines_range::source_lines_range): New function.
16550 * source.h (class source_lines_range): New class.
16551 (print_source_lines): New declaration.
16552
165532019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16554
16555 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16556
165572019-01-08 Tom Tromey <tom@tromey.com>
16558 Simon Marchi <simon.marchi@ericsson.com>
16559
16560 PR gdb/24060
16561 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16562 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16563 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16564 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16565 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16566 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16567
165682019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16569
16570 * source.c (select_source_symtab): Move header comment to
16571 declaration in source.h.
16572 (forget_cached_source_info_for_objfile): Likewise.
16573 (forget_cached_source_info): Likewise.
16574 (identify_source_line): Likewise.
16575 * source.h (identify_source_line): Move declaration from symtab.h
16576 and add comment from source.c
16577 (print_source_lines): Likewise.
16578 (forget_cached_source_info_for_objfile): Likewise.
16579 (forget_cached_source_info): Likewise.
16580 (select_source_symtab): Likewise.
16581 (enum print_source_lines_flag): Move definition from symtab.h.
16582 * symtab.h (identify_source_line): Move declaration to source.h.
16583 (print_source_lines): Likewise.
16584 (forget_cached_source_info_for_objfile): Likewise.
16585 (forget_cached_source_info): Likewise.
16586 (select_source_symtab): Likewise.
16587 (enum print_source_lines_flag): Move definition to source.h.
16588 * tui/tui-hooks.c: Add 'source.h' include.
16589
165902019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16591
16592 * source.c (print_source_lines_base): Handle requests to print
16593 reverse line number sequences, and guard against empty lines
16594 string.
16595
165962019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16597
16598 * source.c (print_source_lines_base): Fix skip of '\r' if next
16599 character is '\n'.
16600
166012019-01-06 Tom Tromey <tom@tromey.com>
16602
16603 * c-exp.y (struct c_parse_state) <macro_original_text,
16604 expansion_obstack>: New member.
16605 (macro_original_text, expansion_obstack): Remove globals.
16606 (scan_macro_expansion, scanning_macro_expansion)
16607 (finished_macro_expansion): Update.
16608 (scan_macro_cleanup): Remove.
16609 (yylex, c_parse): Update.
16610
166112019-01-06 Tom Tromey <tom@tromey.com>
16612
16613 * c-exp.y (struct c_parse_state) <strings>: New member.
16614 (operator_stoken): Update.
16615
166162019-01-06 Tom Tromey <tom@tromey.com>
16617
16618 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16619 (union type_stack_elt) <typelist_val>: Now a pointer to
16620 std::vector.
16621 (type_stack_cleanup): Don't declare.
16622 (push_typelist): Update.
16623 * parse.c (pop_typelist): Return a std::vector.
16624 (push_typelist): Take a std::vector.
16625 (follow_types): Update. Do not free args.
16626 (type_stack_cleanup): Remove.
16627 * c-exp.y (struct c_parse_state): New.
16628 (cpstate): New global.
16629 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16630 (nonempty_typelist): Update.
16631 (func_mod): Create a new vector.
16632 (c_parse): Create a c_parse_state.
16633 (check_parameter_typelist): Do not delete params.
16634 (function_method): Update. Do not delete type_list.
16635
166362019-01-06 Tom Tromey <tom@tromey.com>
16637
16638 PR gdb/28155:
16639 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16640 check_typedef.
16641 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16642 (print_return_value): Likewise.
16643
166442019-01-05 Tom Tromey <tom@tromey.com>
16645
16646 * contrib/cleanup_check.py: Remove.
16647 * contrib/gcc-with-excheck: Remove.
16648 * contrib/exsummary.py: Remove.
16649 * contrib/excheck.py: Remove.
16650
166512019-01-05 Joel Brobecker <brobecker@adacore.com>
16652
16653 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16654 NULL. Initialize tpprev to NULL instead of assigning it
16655 to NULL on the next statement.
16656 * windows-nat.c (windows_delete_thread): Remove check for
16657 main_thread_id before printing thread exit notifications.
16658 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16659 Remove thread ID check against main_thread_id.
16660 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16661 windows_delete_thread.
16662 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16663
166642019-01-04 Tom Tromey <tom@tromey.com>
16665
16666 * compile/compile.c (_initialize_compile): Use upper case for
16667 metasyntactic variables.
16668 * symmisc.c (_initialize_symmisc): Use upper case for
16669 metasyntactic variables.
16670 * psymtab.c (_initialize_psymtab): Use upper case for
16671 metasyntactic variables.
16672 * demangle.c (demangle_command): Use upper case for metasyntactic
16673 variables.
16674 (_initialize_demangler): Likewise.
16675 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16676 variables.
16677
166782019-01-03 Tom Tromey <tom@tromey.com>
16679
16680 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16681
166822019-01-03 Tom Tromey <tom@tromey.com>
16683
16684 * python/py-symtab.c (salpy_str): Update.
16685 (struct salpy_sal_object) <symtab>: Now a PyObject.
16686 (salpy_dealloc): Update.
16687 (del_objfile_sal): Use gdbpy_ref.
16688
166892019-01-03 Tom Tromey <tom@tromey.com>
16690
16691 * python/py-type.c (convert_field): Use new_reference. Return
16692 gdbpy_ref.
16693 (make_fielditem): Return gdbpy_ref.
16694 (typy_fields): Update.
16695 (typy_getitem): Update.
16696 (field_name): Return gdbpy_ref. Use new_reference.
16697 (typy_iterator_iternext): Update.
16698
166992019-01-03 Tom Tromey <tom@tromey.com>
16700
16701 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16702
167032019-01-03 Tom Tromey <tom@tromey.com>
16704
16705 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16706 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16707 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16708 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16709 (pspy_set_type_printers): Likewise.
16710 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16711 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16712 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16713 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16714 (objfpy_set_type_printers): Likewise.
16715
167162019-01-03 Tom Tromey <tom@tromey.com>
16717
16718 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16719 (gdbpy_print_stack): Use gdbpy_err_fetch.
16720 * python/python-internal.h (class gdbpy_err_fetch): New class.
16721 (class gdbpy_enter) <m_error_type, m_error_value,
16722 m_error_traceback>: Remove.
16723 <m_error>: New member.
16724 (gdbpy_exception_to_string): Don't declare.
16725 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16726 * python/py-value.c (convert_value_from_python): Use
16727 gdbpy_err_fetch.
16728 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16729 gdbpy_exception_to_string.
16730 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16731 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16732 gdbpy_err_fetch.
16733
167342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16735
16736 * linux-nat.c (delete_lwp_cleanup): Delete.
16737 (struct lwp_deleter): New struct.
16738 (lwp_info_up): New typedef.
16739 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16740 lwp_info_up.
16741
167422019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16743
16744 * linux-fork.c (class scoped_switch_fork_info): New class.
16745 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16746
167472019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16748
16749 * valops.c (find_overload_match): Remove use of null_cleanup, and
16750 calls to do_cleanups.
16751
167522019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16753
16754 * compile/compile-cplus-types.c
16755 (compile_cplus_instance::decl_name): Handle changes to
16756 cp_func_name.
16757 * cp-support.c (cp_func_name): Update header comment, update
16758 return type.
16759 * cp-support.h (cp_func_name): Update return type in declaration.
16760 * valops.c (find_overload_match): Move temp_func local to top
16761 level of function and change its type. Use temp_func to hold and
16762 delete temporary string obtained from cp_func_name.
16763
167642019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16765
16766 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16767 gdb::char_vector, remove cleanup, and update uses of `msg`.
16768
167692019-01-03 Jim Wilson <jimw@sifive.com>
16770
16771 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16772
167732019-01-02 Tom Tromey <tom@tromey.com>
16774
16775 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16776 (tdesc_parse_xml): Remove cleanups.
16777 * target-descriptions.h (make_cleanup_free_target_description):
16778 Don't declare.
16779 (target_desc_deleter): New struct.
16780 (target_desc_up): New typedef.
16781 * target-descriptions.c (target_desc_deleter::operator()): Rename
16782 from free_target_description.
16783 (make_cleanup_free_target_description): Remove.
16784
167852019-01-02 Tom Tromey <tom@tromey.com>
16786
16787 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16788 constructor, destructor.
16789 (linespec_parser): Remove typedef.
16790 (~linespec_parser): Rename from linespec_parser_delete.
16791 (linespec_lex_to_end, linespec_complete_label)
16792 (linespec_complete): Update.
16793 (decode_line_full): Remove cleanups.
16794 (decode_line_1): Update.
16795
167962019-01-02 Tom Tromey <tom@tromey.com>
16797
16798 * python/python-internal.h (inferior_to_inferior_object): Change
16799 return type.
16800 * python/py-exitedevent.c (create_exited_event_object): Update.
16801 * python/py-inferior.c (inferior_to_inferior_object): Return
16802 gdbpy_ref.
16803 (python_new_inferior, python_inferior_deleted)
16804 (thread_to_thread_object, delete_thread_object)
16805 (build_inferior_list, gdbpy_selected_inferior): Update.
16806 * python/py-infthread.c (create_thread_object): Update. Also fail
16807 if inferior_to_inferior_object fails.
16808
168092019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16810
16811 * inferior.h (class inferior) <displaced_step_state>: New field.
16812 * infrun.h (struct displaced_step_state): Move here from
16813 infrun.c. Initialize fields, add constructor.
16814 <inf>: Remove field.
16815 <reset>: New method.
16816 * infrun.c (struct displaced_step_inferior_state): Move to
16817 infrun.h.
16818 (displaced_step_inferior_states): Remove.
16819 (get_displaced_stepping_state): Adust.
16820 (displaced_step_in_progress_any_inferior): Adjust.
16821 (displaced_step_in_progress_thread): Adjust.
16822 (displaced_step_in_progress): Adjust.
16823 (add_displaced_stepping_state): Remove.
16824 (get_displaced_step_closure_by_addr): Adjust.
16825 (remove_displaced_stepping_state): Remove.
16826 (infrun_inferior_exit): Call displaced_step_state.reset.
16827 (use_displaced_stepping): Don't check for NULL.
16828 (displaced_step_prepare_throw): Call
16829 get_displaced_stepping_state.
16830 (displaced_step_fixup): Don't check for NULL.
16831 (prepare_for_detach): Don't check for NULL.
16832
168332019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16834
16835 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16836 in case of call that did not complete.
16837
168382019-01-02 Andrey Utkin <autkin@undo.io>
16839
16840 * symfile.c (find_separate_debug_file): Fix search of debug files for
16841 remote debuggee.
16842
168432019-01-02 Tom Tromey <tom@tromey.com>
16844
16845 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16846 indentation.
16847 * python/py-frame.c (frapy_older): Remove cast.
16848 (frapy_newer): Likewise.
16849 * python/py-breakpoint.c (local_setattro): Remove cast.
16850 * python/py-arch.c (archpy_name): Remove local variable.
16851 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16852
168532019-01-02 Joel Brobecker <brobecker@adacore.com>
16854
16855 * unittests/basic_string_view/element_access/char/empty.cc:
16856 Fix year range in copyright header.
16857
168582019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16859
16860 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16861 Delete.
16862 <operator==>: Update with for removed field.
16863 <hash>: Likewise.
16864 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16865 <isa_features>: ...this.
16866 <abi_features>: New field.
16867 (riscv_isa_flen): Update comment.
16868 (riscv_abi_xlen): New declaration.
16869 (riscv_abi_flen): New declaration.
16870 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16871 isa_features.
16872 (riscv_abi_xlen): New function.
16873 (riscv_isa_flen): Update to get answer from isa_features.
16874 (riscv_abi_flen): New function.
16875 (riscv_has_fp_abi): Update to get answer from abi_features.
16876 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16877 xlen and flen.
16878 (riscv_call_info) <xlen, flen>: Update comment.
16879 (riscv_call_arg_struct): Remove invalid assertions
16880 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16881 is removed.
16882 (riscv_gdbarch_init): Gather isa features and abi features
16883 separately, ensure both match on the gdbarch when reusing an old
16884 gdbarch. Relax an error check to allow 32-bit abi float to run on
16885 a target with 64-bit float hardware.
16886
168872019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16888
16889 * source.c (search_command_helper): Stop reverse search
16890 when line 1 has been searched.
16891
168922019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16893
16894 * record-full.c (record_full_base_target::close): Rewrite
16895 record_full_core_buf_list free logic.
16896
168972019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16898
16899 * break-catch-syscall.c (print_one_catch_syscall): xfree
16900 the last text.
16901
169022019-01-01 Joel Brobecker <brobecker@adacore.com>
16903
16904 * top.c (print_gdb_version): Update Copyright year in version
16905 message.
16906
169072019-01-01 Joel Brobecker <brobecker@adacore.com>
16908
16909 Update copyright year range in all GDB files.
16910
169112019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16912
16913 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16914
16915For older changes see ChangeLog-2018.
16916\f
16917Local Variables:
16918mode: change-log
16919left-margin: 8
16920fill-column: 74
16921version-control: never
16922coding: utf-8
16923End:
16924
This page took 0.115207 seconds and 4 git commands to generate.