bfd/ChangeLog

   1 2020-04-01  Hans-Peter Nilsson  <hp@bitrange.com>
   2
   3         * mmo.c (mmo_scan): Create .text section only when needed, not
   4         from the start.
   5
   6 2020-03-31  Alan Modra  <amodra@gmail.com>
   7
   8         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
   9         return value check.
  10
  11 2020-03-31  Alan Modra  <amodra@gmail.com>
  12
  13         * vms-alpha.c (image_write): Check bounds for sections without
  14         contents too.  Error on non-zero write to section without
  15         contents.
  16         (_bfd_vms_slurp_etir): Check return of image_write* functions.
  17
  18 2020-03-31  Alan Modra  <amodra@gmail.com>
  19
  20         * tekhex.c (pass_over): Check is_eof before reading buffer.
  21
  22 2020-03-30  Nick Clifton  <nickc@redhat.com>
  23
  24         PR binutils/pr25662
  25         * libcoff-in.h (struct pe_tdata): Rename the insert_timestamp
  26         field to timestamp and make it an integer.
  27         * libcoff.h: Regenerate.
  28         * peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Test the timestamp
  29         field in the pe_data structure rather than the insert_timestamp
  30         field.
  31
  32 2020-03-30  Alan Modra  <amodra@gmail.com>
  33
  34         PR 25745
  35         * elf64-ppc.c (ppc64_elf_build_stubs): Use asprintf to form
  36         statistics message.
  37
  38 2020-03-26  Nick Clifton  <nickc@redhat.com>
  39
  40         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): Delete.
  41         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Remove
  42         prototype.
  43         * libbfd.h: Regenerate.
  44
  45 2020-03-26  Alan Modra  <amodra@gmail.com>
  46
  47         * i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread.
  48
  49 2020-03-26  Alan Modra  <amodra@gmail.com>
  50
  51         * vms-alpha.c (dst_define_location): Limit size of dst_ptr_offsets
  52         array.
  53         (_bfd_vms_slurp_object_records): Rename "err" to "ok".
  54
  55 2020-03-25  Nick Clifton  <nickc@redhat.com>
  56
  57         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): New
  58         function.
  59         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Prototype.
  60         * libbfd.h: Regenerate.
  61
  62 2020-03-25  Shahab Vahedi  <shahab@synopsys.com>
  63
  64         * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
  65         correct field name in the output string.
  66
  67 2020-03-25  Alan Modra  <amodra@gmail.com>
  68
  69         PR 25662
  70         * elf.c (assign_file_positions_for_load_sections): Adjust offset
  71         for SHT_NOBITS section if first in segment.
  72
  73 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
  74
  75         PR binutils/25708
  76         * elf-bfd.h (_bfd_elf_get_symbol_version_name): Renamed to ...
  77         (_bfd_elf_get_symbol_version_string): This.
  78         * elf.c (_bfd_elf_get_symbol_version_name): Renamed to ...
  79         (_bfd_elf_get_symbol_version_string): This.
  80         (bfd_elf_print_symbol): Pass TRUE to
  81         _bfd_elf_get_symbol_version_string.
  82         * libbfd-in.h (_bfd_nosymbols_get_symbol_version_string): Add a
  83         bfd_boolean argument.
  84         * syms.c (_bfd_nosymbols_get_symbol_version_string): Likewise.
  85         * targets.c  (_bfd_get_symbol_version_string): Likewise.
  86         (bfd_get_symbol_version_string): Likewise.
  87         * bfd-in2.h: Regenerated.
  88
  89 2020-03-24  Nick Clifton  <nickc@redhat.com>
  90             Jaydeep Chauhan  <jaydeepchauhan1494@gmail.com>
  91
  92         PR 25713
  93         * bfdio.c (_bfd_real_fopen): Add code to handle long filenames on
  94         Win32 systems.
  95
  96 2020-03-24  Nick Clifton  <nickc@redhat.com>
  97
  98         PR 25681
  99         * elf.c (_bfd_elf_map_sections_to_segments): When looking for a
 100         segment to use for PT_GNU_RELRO, ignore empty sections in a
 101         segment's current list.
 102
 103 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 104
 105         PR binutils/25717
 106         * elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
 107
 108 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 109
 110         PR binutils/25708
 111         * elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
 112         * elf.c (_bfd_elf_get_symbol_version_name): New function.  Based
 113         on the previous _bfd_elf_get_symbol_version_string.
 114         (_bfd_elf_get_symbol_version_string): Use it.
 115
 116 2020-03-24  Alan Modra  <amodra@gmail.com>
 117
 118         * archive.c (_bfd_generic_read_ar_hdr_mag): Sanity check extended
 119         name size.  Use bfd_malloc rather than bfd_zmalloc, clearing just
 120         struct areltdata.
 121
 122 2020-03-23  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 123
 124         * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment.
 125
 126 2020-03-23  Alan Modra  <amodra@gmail.com>
 127
 128         * ecoff.c (_bfd_ecoff_slurp_armap): Sanity check parsed_size and
 129         symbol count.  Allocate an extra byte to ensure name strings
 130         are terminated.  Sanity check name offsets.  Release memory on
 131         error return.
 132
 133 2020-03-23  Alan Modra  <amodra@gmail.com>
 134
 135         * i386msdos.c (msdos_object_p): Don't access e_lfanew when that
 136         field hasn't been read.  Remove unnecessary casts.
 137
 138 2020-03-22  Alan Modra  <amodra@gmail.com>
 139
 140         * coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large
 141         enough to read number of symbols.
 142
 143 2020-03-20  H.J. Lu  <hongjiu.lu@intel.com>
 144
 145         * configure.ac (HAVE_EXECUTABLE_SUFFIX): Removed.
 146         (EXECUTABLE_SUFFIX): Likewise.
 147         * config.in: Regenerated.
 148         * configure: Likewise.
 149         * plugin.c (bfd_plugin_close_and_cleanup): Defined as
 150         _bfd_generic_close_and_cleanup.
 151         (plugin_list_entry): Remove resolution_file, resolution_option,
 152         real_bfd, real_nsyms, real_syms, lto_nsyms, lto_syms, gcc,
 153         lto_wrapper, gcc_env and initialized,
 154         (need_lto_wrapper_p): Removed.
 155         (get_lto_wrapper): Likewise.
 156         (setup_lto_wrapper_env): Likewise.
 157         (register_all_symbols_read): Likewise.
 158         (egister_cleanup): Likewise.
 159         (get_symbols): Likewise.
 160         (add_input_file): Likewise.
 161         (bfd_plugin_set_program_name): Remove need_lto_wrapper.
 162         (add_symbols): Updated.
 163         (try_claim): Likewise.
 164         (try_load_plugin): Likewise.
 165         (bfd_plugin_canonicalize_symtab): Likewise.
 166         * plugin.h (bfd_plugin_set_program_name): Remove int argument.
 167         (plugin_data_struct): Remove real_bfd, real_nsyms and real_syms.
 168
 169 2020-03-19  H.J. Lu  <hongjiu.lu@intel.com>
 170
 171         PR binutils/25640
 172         * plugin.c (plugin_list_entry): Add has_symbol_type.
 173         (add_symbols_v2): New function.
 174         (bfd_plugin_open_input): Don't invoke LTO wrapper if LTO plugin
 175         provides symbol type.
 176         (try_load_plugin): Add LDPT_ADD_SYMBOLS_V2.
 177         (bfd_plugin_canonicalize_symtab): Use LTO plugin symbol type if
 178         available.
 179
 180 2020-03-20  Alan Modra  <amodra@gmail.com>
 181
 182         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Ensure size is large
 183         enough to read number of symbols.
 184
 185 2020-03-20  Alan Modra  <amodra@gmail.com>
 186
 187         * elf.c (_bfd_elf_setup_sections): Don't test known non-NULL
 188         backend functions for NULL before calling.
 189         (copy_special_section_fields, _bfd_elf_copy_private_bfd_data),
 190         (bfd_section_from_shdr, assign_section_numbers): Likewise.
 191         * elfcode.h (elf_write_relocs, elf_slurp_reloc_table): Likewise.
 192         * elfnn-ia64.c (ignore_errors): New function.
 193         (elf_backend_link_order_error_handler): Redefine as ignore_errors.
 194
 195 2020-03-19  Nick Clifton  <nickc@redhat.com>
 196
 197         PR 25676
 198         * dwarf2.c (struct varinfo): Add unit_offset field to record the
 199         location of the varinfo in the unit's debug info data.  Change the
 200         type of the stack field to a boolean.
 201         (lookup_var_by_offset): New function.  Returns the varinfo
 202         structure for the variable described at the given offset in the
 203         unit's debug info.
 204         (scan_unit_for_symbols): Add support for variables which have the
 205         DW_AT_specification attribute.
 206
 207 2020-03-19  Nick Clifton  <nickc@redhat.com>
 208
 209         PR 25699
 210         * elf.c (bfd_elf_set_group_contents): Replace assertion with an
 211         error return.
 212
 213 2020-03-19  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 214
 215         * elfxx-riscv.c (riscv_parse_subset): Don't use C99.
 216
 217 2020-03-18  Nick Clifton  <nickc@redhat.com>
 218
 219         PR 25673
 220         * elf.c (_bfd_elf_write_secondary_reloc_section): Fix illegal
 221         memory access when processing a corrupt secondary reloc section.
 222
 223 2020-03-18  Christophe Lyon  <christophe.lyon@linaro.org>
 224
 225         * elf32-arm.c (arm_build_one_stub): Emit a fatal error message
 226         instead of calling abort.
 227         * elf32-csky.c (csky_build_one_stub): Likewise.
 228         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 229         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 230         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 231         * elf32-metag.c (metag_build_one_stub): Likewise.
 232         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 233         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 234         (ppc_size_one_stub): Likewise.
 235         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 236
 237 2020-03-17  Nick Clifton  <nickc@redhat.com>
 238
 239         PR 25688
 240         * elf.c (_bfd_elf_copy_special_section_fields): Replace assertions
 241         with error messages.
 242
 243 2020-03-17  Nick Clifton  <nickc@redhat.com>
 244
 245         PR 25687
 246         * elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
 247         free.  Add free on another failure path.
 248
 249 2020-03-16  Alan Modra  <amodra@gmail.com>
 250
 251         PR 25675
 252         * elf.c (elf_sort_segments): Don't call bfd_octets_per_byte unless
 253         we have a non-zero section count.  Do lma comparison in octets.
 254
 255 2020-03-16  Alan Modra  <amodra@gmail.com>
 256
 257         * vms-alpha.c (dst_restore_location): Validate index into
 258         dst_ptr_offsets array before accessing.  Return status.
 259         (dst_retrieve_location): Similarly, making "loc" parameter a
 260         pointer to return value.
 261         (_bfd_vms_slurp_etir): Update calls to above functions.
 262
 263 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 264
 265         * configure.ac: Include netbsd-core.lo for all NetBSD arm and mips
 266         targets.
 267         * configure: Regenerated.
 268
 269 2020-03-14  Alan Modra  <amodra@gmail.com>
 270
 271         * section.c (BFD_FAKE_SECTIONS): Formatting.
 272         * bfd-in2.h: Regenerate.
 273
 274 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 275
 276         * elf.c (elfcore_grok_netbsd_note): Add support for
 277         NT_NETBSDCORE_LWPSTATUS notes.
 278
 279 2020-03-13  Christophe Lyon  <christophe.lyon@linaro.org>
 280
 281         * bfd-in2.h: Regenerate.
 282         * section.c (asection): Add already_assigned field.
 283         (BFD_FAKE_SECTION): Add default initializer for it.
 284         * ecoff.c (bfd_debug_section): Initialize already_assigned field.
 285         * elf32-arm.c (arm_build_one_stub): Add support for
 286         non_contiguous_regions.
 287         * elf32-csky.c (csky_build_one_stub): Likewise.
 288         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 289         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 290         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 291         * elf32-metag.c (metag_build_one_stub): Likewise.
 292         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 293         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 294         (ppc_size_one_stub): Likewise.
 295         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 296         * elflink.c (elf_link_input_bfd): Likewise.
 297
 298 2020-03-13  H.J. Lu  <hongjiu.lu@intel.com>
 299
 300         PR ld/24920
 301         * elf-linker-x86.h (elf_linker_x86_params): Add
 302         static_before_all_inputs and has_dynamic_linker.
 303         * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
 304         dynamic input objects if -static is passed at command-line
 305         before all input files without --dynamic-linker unless
 306         --no-dynamic-linker is used.
 307
 308 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 309
 310         * elf.c (elfcore_grok_netbsd_note): Add support for aarch64.
 311
 312 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 313
 314         * bfd.c (bfd_record_phdr): New local "opb".  Fix assignment of
 315         "p_paddr" from "at".
 316         * elfcode.h (bfd_from_remote_memory): Add units to several
 317         parameters.  New local "opb".  Fix usage of p_align.  Fix
 318         calculation of "localbase" from "ehdr_vma" and "p_vaddr".  Fix
 319         call of target_read_memory.
 320         * elflink.c (elf_fixup_link_order): Fix scope of "s" local.  Fix
 321         calculation of "offset" and "output_offset".
 322         (bfd_elf_final_link): New local "opb".  Fix calculation of "size"
 323         from "offset" and fix calculation of "end" from "vma+size".  Fix
 324         comparison between "sh_addr" and "vma"/"output_offset".
 325         (bfd_elf_discard_info): Fix calculation of "eh_alignment".
 326         * elf-bfd.h (struct elf_link_hash_table): Add unit to tls_size
 327         member.
 328         * elf.c (_bfd_elf_map_sections_to_segments): Add unit (bytes/
 329         octets) to "wrap_to2 and "phdr_size" locals.  Fix calculation of
 330         "wrap_to" value.  Add unit (bytes) to phdr_lma variable.  Fix
 331         assignment of p_paddr from phdr_lma.  Fix comparison between
 332         "lma+size" and "next->lma".
 333         (elf_sort_segments): Fix assignment from p_paddr to lma.
 334         (assign_file_positions_for_load_sections): Add unit (bytes) to
 335         local "align".  Fix calculation of local "off_adjust".  Fix
 336         calculation of local "filehdr_vaddr".
 337         (assign_file_positions_for_non_load_sections): New local "opb".
 338         Fix calculation of "end" from "p_size". Fix comparison between
 339         "vma+SECTION_SIZE" and "start".  Fix calculation of "p_memsz"
 340         from "end" and "p_vaddr".
 341         (rewrite_elf_program_header): Fix comparison between p_vaddr and
 342         vma.  Fix assignment to p_paddr from lma.  Fix comparison between
 343         p_paddr and lma.  Fix assignment to p_paddr from lma.
 344         * merge.c (sec_merge_emit): New local "opb". Convert
 345         "alignment_power" to octets.
 346         (_bfd_add_merge_section): New locals "alignment_power" and
 347         "opb".  Fix comparison between "alignment_power" and
 348         "sizeof(align)".
 349         (_bfd_merge_sections): New local "opb".  Divide size by opb
 350         before checking align mask.
 351
 352 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 353
 354         * elf.c (_bfd_elf_make_section_from_shdr): Introduce new temp
 355         opb.  Divide Elf_Internal_Shdr::sh_addr by opb when setting
 356         section LMA/VMA.
 357         (_bfd_elf_make_section_from_phdr): Similarly.
 358         (elf_fake_sections): Fix calculation of
 359         Elf_Internal_shdr::sh_addr from section VMA.
 360         (_bfd_elf_map_sections_to_segments): Fix mixup between octets
 361         and bytes.
 362         (assign_file_positions_for_load_sections): Fix calculations of
 363         Elf_Internal_shdr::p_vaddr and p_paddr from section LMA/VMA.  Fix
 364         comparison between program header address and section LMA.
 365         (assign_file_positions_for_non_load_sections): Likewise.
 366         (rewrite_elf_program_header): Likewise.  Introduce new temp opb.
 367         (IS_CONTAINED_BY_VMA): Add parameter opb.
 368         (IS_CONTAINED_BY_LMA,IS_SECTION_IN_INPUT_SEGMENT,
 369         INCLUDE_SECTION_IN_SEGMENT): Likewise.
 370         (copy_elf_program_header): Update call to ELF_SECTION_IN_SEGMENT.
 371         Fix calculations of p_addr_valid and p_vaddr_offset.
 372         * elflink.c (elf_link_add_object_symbols): Multiply section VMA
 373         with octets per byte when comparing against p_vaddr.
 374
 375 2020-03-11  Alan Modra  <amodra@gmail.com>
 376
 377         * som.c (setup_sections): Sanity check subspace.name.
 378
 379 2020-03-11  Alan Modra  <amodra@gmail.com>
 380
 381         * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
 382
 383 2020-03-10  Alan Modra  <amodra@gmail.com>
 384
 385         PR 25648
 386         * ihex.c (ihex_write_object_contents): Don't assume ordering of
 387         addresses here.
 388
 389 2020-03-09  Alan Modra  <amodra@gmail.com>
 390
 391         * wasm-module.c (wasm_scan): Sanity check file name length
 392         before allocating memory.  Move common section setup code.  Do
 393         without bfd_tell to calculate section size.
 394
 395 2020-03-06  Nick Clifton  <nickc@redhat.com>
 396
 397         * elf.c (_bfd_elf_set_section_contents): Replace call to abort
 398         with error messages and failure return values.
 399
 400 2020-03-05  Max Filippov  <jcmvbkbc@gmail.com>
 401
 402         * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
 403         relocation sections for any removed reference to a dynamic symbol.
 404
 405 2020-03-05  Nick Clifton  <nickc@redhat.com>
 406
 407         * elf-bfd.h (struct elf_backend_data): Add new fields:
 408         init_secondary_reloc_section, slurp_secondary_reloc_section,
 409         write_secondary_reloc_section.
 410         (_bfd_elf_init_secondary_reloc_section): Prototype.
 411         (_bfd_elf_slurp_secondary_reloc_section): Prototype.
 412         (_bfd_elf_write_secondary_reloc_section): Prototype.
 413         * elf.c ( bfd_section_from_shdr): Invoke the new
 414         init_secondary_reloc_section backend function, if defined, when a
 415         second reloc section is encountered.
 416         (swap_out_syms): Invoke the new symbol_section_index function, if
 417         defined, when computing the section index of an OS/PROC specific
 418         symbol.
 419         (_bfd_elf_init_secondary_reloc_section): New function.
 420         (_bfd_elf_slurp_secondary_reloc_section): New function.
 421         (_bfd_elf_write_secondary_reloc_section): New function.
 422         (_bfd_elf_copy_special_section_fields): New function.
 423         * elfcode.h (elf_write_relocs): Invoke the new
 424         write_secondary_relocs function, if defined, in order to emit
 425         secondary relocs.
 426         (elf_slurp_reloc_table): Invoke the new slurp_secondary_relocs
 427         function, if defined, in order to read in secondary relocs.
 428         * elfxx-target.h (elf_backend_copy_special_section_fields):
 429         Provide a non-NULL default definition.
 430         (elf_backend_init_secondary_reloc_section): Likewise.
 431         (elf_backend_slurp_secondary_reloc_section): Likewise.
 432         (elf_backend_write_secondary_reloc_section): Likewise.
 433         (struct elf_backend_data elfNN_bed): Add initialisers for the new
 434         fields.
 435         * configure.ac (score_elf32_[bl]e_vec): Add elf64.lo
 436         * configure: Regenerate.
 437
 438 2020-03-05  Alan Modra  <amodra@gmail.com>
 439
 440         * archive64.c (_bfd_archive_64_bit_slurp_armap): Check parsed_size
 441         against file size before allocating memory.  Use bfd_alloc rather
 442         than bfd_zalloc for carsym/strings memory.
 443
 444 2020-03-04  Alan Modra  <amodra@gmail.com>
 445
 446         * elf.c (elf_fake_sections): Ensure sh_addralign is such that
 447         sh_addr mod sh_addalign is zero.
 448
 449 2020-03-04  Alan Modra  <amodra@gmail.com>
 450
 451         * format.c (bfd_check_format_matches): Call cleanup on error exit.
 452
 453 2020-03-03  Alan Modra  <amodra@gmail.com>
 454
 455         * format.c (struct bfd_preserve): Add cleanup field.
 456         (bfd_preserve_save): Add cleanup param and save.
 457         (bfd_preserve_restore): Return cleanup.
 458         (bfd_preserve_finish): Call the cleanup for the discarded match.
 459         (bfd_check_format_matches): Pass cleanup to bfd_preserve_save,
 460         and clear when preserving a match.  Restore cleanup too when
 461         restoring that match.
 462
 463 2020-03-02  Alan Modra  <amodra@gmail.com>
 464
 465         * cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
 466         * hpux-core.c (hpux_core_core_file_p): Update prototype.
 467         * sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
 468         (core_sco5_vec): Correct initialisers.
 469
 470 2020-03-02  Alan Modra  <amodra@gmail.com>
 471
 472         * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.
 473         * aix5ppc-core.c (xcoff64_core_p): Likewise.
 474         * cisco-core.c (cisco_core_file_validate): Likewise.
 475         * hppabsd-core.c (hppabsd_core_core_file_p): Likewise.
 476         * hpux-core.c (hpux_core_core_file_p): Likewise.
 477         * irix-core.c (irix_core_core_file_p): Likewise.
 478         * lynx-core.c (lynx_core_file_p): Likewise.
 479         * netbsd-core.c (netbsd_core_file_p): Likewise.
 480         * osf-core.c (osf_core_core_file_p): Likewise.
 481         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
 482         * sco5-core.c (sco5_core_file_p): Likewise.
 483
 484 2020-03-02  H.J. Lu  <hongjiu.lu@intel.com>
 485
 486         * trad-core.c (trad_unix_core_file_p): Return bfd_cleanup.
 487
 488 2020-03-02  Alan Modra  <amodra@gmail.com>
 489
 490         * targets.c (bfd_cleanup): New typedef.
 491         (struct bfd <_bfd_check_format>): Return a bfd_cleanup.
 492         * libbfd-in.h (_bfd_no_cleanup): Define.
 493         * format.c (bfd_reinit): Add cleanup parameter, call it.
 494         (bfd_check_format_matches): Set cleanup from _bfd_check_format
 495         call and pass to bfd_reinit.  Delete temp, use abfd->xvec instead.
 496         * aout-target.h (callback, object_p): Return bfd_cleanup.
 497         * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise.
 498         * archive.c (bfd_generic_archive_p): Likewise.
 499         * binary.c (binary_object_p): Likewise.
 500         * coff-alpha.c (alpha_ecoff_object_p): Likewise.
 501         * coff-ia64.c (ia64coff_object_p): Likewise.
 502         * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise.
 503         * coff-sh.c (coff_small_object_p): Likewise.
 504         * coff-stgo32.c (go32_check_format): Likewise.
 505         * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p),
 506         (xcoff64_core_p): Likewise.
 507         * coffgen.c (coff_real_object_p, coff_object_p): Likewise.
 508         * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p),
 509         (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise.
 510         * elfcode.h (elf_object_p): Likewise.
 511         * elfcore.h (elf_core_file_p): Likewise.
 512         * i386msdos.c (msdos_object_p): Likewise.
 513         * ihex.c (ihex_object_p): Likewise.
 514         * libaout.h (some_aout_object_p): Likewise.
 515         * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target),
 516         (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise.
 517         * libbfd.c (_bfd_dummy_target): Likewise.
 518         * libcoff-in.h (coff_object_p): Likewise.
 519         * mach-o-aarch64.c (bfd_mach_o_arm64_object_p),
 520         (bfd_mach_o_arm64_core_p): Likewise.
 521         * mach-o-arm.c (bfd_mach_o_arm_object_p),
 522         (bfd_mach_o_arm_core_p): Likewise.
 523         * mach-o-i386.c (bfd_mach_o_i386_object_p),
 524         (bfd_mach_o_i386_core_p): Likewise.
 525         * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p),
 526         (bfd_mach_o_x86_64_core_p): Likewise.
 527         * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p),
 528         (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise.
 529         * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p),
 530         (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise.
 531         * mmo.c (mmo_object_p): Likewise.
 532         * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
 533         * peicode.h (coff_real_object_p, pe_ILF_object_p),
 534         (pe_bfd_object_p): Likewise.
 535         * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise.
 536         * ppcboot.c (ppcboot_object_p): Likewise.
 537         * rs6000-core.c (rs6000coff_core_p): Likewise.
 538         * som.c (som_object_setup, som_object_p): Likewise.
 539         * srec.c (srec_object_p, symbolsrec_object_p): Likewise.
 540         * tekhex.c (tekhex_object_p): Likewise.
 541         * vms-alpha.c (alpha_vms_object_p): Likewise.
 542         * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p),
 543         (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise.
 544         * wasm-module.c (wasm_object_p): Likewise.
 545         * xsym.c (bfd_sym_object_p): Likewise.
 546         * xsym.h (bfd_sym_object_p): Likewise.
 547         * aoutx.h (some_aout_object_p): Likewise, and callback parameter
 548         return type.
 549         * pdp11.c (some_aout_object_p): Likewise.
 550         * plugin.c (register_ld_plugin_object_p): Update object_p
 551         parameter type.
 552         * plugin.h (register_ld_plugin_object_p): Likewise.
 553         * bfd-in2.h: Regenerate.
 554         * libbfd.h: Regenerate.
 555         * libcoff.h: Regenerate.
 556
 557 2020-03-02  Alan Modra  <amodra@gmail.com>
 558
 559         * coff-alpha.c (alpha_ecoff_le_vec): Add SEC_SMALL_DATA to
 560         applicable section flags.
 561         * coff-mips.c (mips_ecoff_le_vec, mips_ecoff_be_vec): Likewise.
 562         (mips_ecoff_bele_vec): Likewise.
 563         * coffcode.h (sec_to_styp_flags): Set SEC_SMALL_DATA for .sdata
 564         and .sbss sections.
 565         * ecoff.c (_bfd_ecoff_new_section_hook): Likewise.
 566         (_bfd_ecoff_styp_to_sec_flags): Likewise.
 567
 568 2020-03-02  Alan Modra  <amodra@gmail.com>
 569
 570         * elf32-m32r.c (m32r_elf_section_flags): New function.
 571         (elf_backend_section_flags): Define.
 572         * elf32-nds32.c (nds32_elf_section_flags): New function.
 573         (elf_backend_section_flags): Define.
 574         * elf32-ppc.c (ppc_elf_section_from_shdr): Set SEC_SMALL_DATA for
 575         .sbss and .sdata sections.
 576         * elf32-v850.c (v850_elf_section_from_shdr): Set SEC_SMALL_DATA
 577         for SHF_V850_GPREL sections.
 578         * elf64-alpha.c (elf64_alpha_section_from_shdr): Delete outdated
 579         FIXME.
 580         * elf64-hppa.c (elf64_hppa_section_from_shdr): Set SEC_SMALL_DATA
 581         for SHF_PARISC_SHORT sections.
 582         * elf64-ppc.c (ppc64_elf_section_flags): New function.
 583         (elf_backend_section_flags): Define.
 584         * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Set SEC_SMALL_DATA
 585         for SHF_MIPS_GPREL sections.  Delete FIXME.
 586
 587 2020-03-02  Alan Modra  <amodra@gmail.com>
 588
 589         * elf-bfd.h (elf_backend_section_flags): Remove flagword* param.
 590         * elf.c (_bfd_elf_make_section_from_shdr): Set section flags before
 591         calling elf_backend_section_flags with adjusted params.  Use
 592         newsect->flags past that point.
 593         (_bfd_elf_new_section_hook): Always set sh_type and sh_flags for
 594         special sections.
 595         (_bfd_elf_init_private_section_data): Allow normal sh_type sections
 596         to have their type overridden, and all sh_flags but processor and
 597         os specific.
 598         * elf32-arm.c (elf32_arm_section_flags): Adjust for changed params.
 599         * elf32-mep.c (mep_elf_section_flags): Likewise.
 600         * elf32-nios2.c (nios2_elf32_section_flags): Likewise.
 601         * elf64-alpha.c (elf64_alpha_section_flags): Likewise.
 602         * elf64-ia64-vms.c (elf64_ia64_section_flags): Likewise.
 603         * elfnn-ia64.c (elfNN_ia64_section_flags): Likewise.
 604         * elfnn-aarch64.c (elfNN_aarch64_size_stubs): Exclude the linker
 605         stub BFD and non-aarch64 input files when scanning for stubs.
 606
 607 2020-03-02  Alan Modra  <amodra@gmail.com>
 608
 609         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
 610         limit to decompressed element size.
 611
 612 2020-03-02  Alan Modra  <amodra@gmail.com>
 613
 614         * vms-lib.c (vms_traverse_index): Add recur_count param and
 615         update calls.  Fail on excessive recursion.
 616
 617 2020-03-02  Alan Modra  <amodra@gmail.com>
 618
 619         * vms-alpha.c (vms_get_remaining_object_record): Use
 620         bfd_realloc_or_free rather than bfd_realloc.
 621         (add_symbol_entry, vector_grow1, alpha_vms_slurp_relocs): Likewise.
 622         (dst_define_location, parse_module): Likewise, and check realloc
 623         return status before using memory.  Return status from function
 624         adjusting all callers.
 625
 626 2020-02-28  Alan Modra  <amodra@gmail.com>
 627
 628         * vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
 629
 630 2020-02-28  Alan Modra  <amodra@gmail.com>
 631
 632         * vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.
 633         Remove duplicate undersize check.
 634
 635 2020-02-27  Alan Modra  <amodra@gmail.com>
 636
 637         PR 24511
 638         * mmo.c (mmo_scan): Set SEC_DATA for .data.
 639
 640 2020-02-27  Alan Modra  <amodra@gmail.com>
 641
 642         PR 24511
 643         * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
 644         (coff_section_type): Adjust comment.
 645         (decode_section_type): Likewise.  Call coff_section_type before
 646         decode_section_type.
 647         (bfd_decode_symclass): Use 'c' for common sections other than
 648         the standard one.
 649
 650 2020-02-27  Alan Modra  <amodra@gmail.com>
 651
 652         * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Put all data in one
 653         malloc'd block.
 654
 655 2020-02-27  Alan Modra  <amodra@gmail.com>
 656
 657         * bfd.c (bfd_stat_arch_elt): Use vector of containing archive,
 658         if file is an archive element.
 659         * bfd-in2.h: Regenerate.
 660
 661 2020-02-26  Alan Modra  <amodra@gmail.com>
 662
 663         * archive.c (do_slurp_bsd_armap): Increase minimum parsed_size, and
 664         bfd_set_error on failing test.  Don't bother changing bfd_error on
 665         file read error.  Check symdef_count is multiple of BSD_SYMDEF_SIZE.
 666         Check sym name is within string buffer.  Use size_t for some vars.
 667         (do_slurp_coff_armap): Use size_t for some variables, fix size of
 668         int_buf.  Don't change bfd_error on file read error.  Use
 669         _bfd_mul_overflow when calculating carsym buffer size.  Reorder
 670         calculations to catch overflows before they occur.  malloc and
 671         free raw armap rather than using bfd_alloc.  Read raw armap before
 672         allocating carsym+strings buffer.
 673         (_bfd_slurp_extended_name_table): Localize variables.  Check
 674         name size against file size.
 675
 676 2020-02-26  Alan Modra  <amodra@gmail.com>
 677
 678         * vms-lib.c (vms_lib_read_index): Release correct buffer.
 679
 680 2020-02-26  Alan Modra  <amodra@gmail.com>
 681
 682         * elf32-rx.c (rx_elf_relocate_section): Use bfd_malloc rather than
 683         malloc.  Check for NULL return from bfd_malloc.
 684         (rx_table_find, rx_table_map): Likewise.
 685         (rx_set_section_contents): Check bfd_alloc return.
 686         (rx_dump_symtab): Don't alloc internal_syms or external_syms.
 687
 688 2020-02-26  Alan Modra  <amodra@gmail.com>
 689
 690         * aoutx.h: Indent labels correctly.  Format error strings.
 691         * archive.c: Likewise.
 692         * archive64.c: Likewise.
 693         * coff-arm.c: Likewise.
 694         * coff-rs6000.c: Likewise.
 695         * coff-stgo32.c: Likewise.
 696         * cpu-arm.c: Likewise.
 697         * dwarf2.c: Likewise.
 698         * elf-ifunc.c: Likewise.
 699         * elf-properties.c: Likewise.
 700         * elf-s390-common.c: Likewise.
 701         * elf-strtab.c: Likewise.
 702         * elf.c: Likewise.
 703         * elf32-arm.c: Likewise.
 704         * elf32-bfin.c: Likewise.
 705         * elf32-cr16.c: Likewise.
 706         * elf32-csky.c: Likewise.
 707         * elf32-i386.c: Likewise.
 708         * elf32-m68k.c: Likewise.
 709         * elf32-msp430.c: Likewise.
 710         * elf32-nds32.c: Likewise.
 711         * elf32-nios2.c: Likewise.
 712         * elf32-pru.c: Likewise.
 713         * elf32-xtensa.c: Likewise.
 714         * elf64-ia64-vms.c: Likewise.
 715         * elf64-x86-64.c: Likewise.
 716         * elfcode.h: Likewise.
 717         * elfcore.h: Likewise.
 718         * elflink.c: Likewise.
 719         * elfnn-aarch64.c: Likewise.
 720         * elfnn-ia64.c: Likewise.
 721         * elfnn-riscv.c: Likewise.
 722         * elfxx-mips.c: Likewise.
 723         * elfxx-sparc.c: Likewise.
 724         * elfxx-x86.c: Likewise.
 725         * i386lynx.c: Likewise.
 726         * merge.c: Likewise.
 727         * pdp11.c: Likewise.
 728         * plugin.c: Likewise.
 729         * reloc.c: Likewise.
 730
 731 2020-02-26  Alan Modra  <amodra@gmail.com>
 732
 733         PR 25593
 734         * elf-bfd.h (struct elf_link_hash_table): Rename "loaded" to
 735         "dyn_loaded".
 736         (bfd_elf_add_dt_needed_tag): Declare.
 737         * elf-strtab.c (_bfd_elf_strtab_restore): Handle NULL buf.
 738         * elflink.c (bfd_elf_add_dt_needed_tag): Make global and rename
 739         from elf_add_dt_needed_tag.  Remove soname and doit param.
 740         (elf_link_add_object_symbols): Don't use elf_add_dt_needed_tag
 741         to see whether as-needed lib is already loaded, use dyn_loaded
 742         list instead.  When saving and restoring around as-needed lib
 743         handle possibility that dynstr has not been initialised.  Don't
 744         add DT_NEEDED tags here.  Limit dyn_loaded list to dynamic libs.
 745         Mark libs loaded via DT_NEEDED entries of other libs with
 746         DYN_NO_NEEDED if they should not be mentioned in DT_NEEDED of
 747         the output.
 748         (elf_link_check_versioned_symbol): Remove now unneccesary
 749         DYNAMIC check when traversing dyn_loaded list.
 750
 751 2020-02-26  Alan Modra  <amodra@gmail.com>
 752
 753         * bfdio.c (bfd_get_file_size): Ignore bogus archive element sizes.
 754
 755 2020-02-25  H.J. Lu  <hongjiu.lu@intel.com>
 756
 757         PR binutils/25584
 758         * plugin.c (need_lto_wrapper_p): New.
 759         (bfd_plugin_set_program_name): Add an int argument to set
 760         need_lto_wrapper_p.
 761         (get_lto_wrapper): Return FALSE if need_lto_wrapper_p isn't
 762         set.
 763         * plugin.h (bfd_plugin_set_program_name): Add an int argument.
 764
 765 2020-02-24  Alan Modra  <amodra@gmail.com>
 766
 767         * vms-lib.c (_bfd_vms_lib_archive_p): Correct overflow checks.
 768
 769 2020-02-24  Alan Modra  <amodra@gmail.com>
 770
 771         * vms-lib.c (struct carsym_mem): Add limit.
 772         (vms_add_index): Heed limit.
 773         (vms_traverse_index): Catch buffer overflows.  Remove outdated fixme.
 774         (vms_lib_read_index): Set up limit.  Catch 32-bit overflow.
 775         Always return actual number read.
 776         (_bfd_vms_lib_archive_p): Catch buffer overflows.  Replace
 777         assertion with error exit.
 778
 779 2020-02-22  Alan Modra  <amodra@gmail.com>
 780
 781         PR 25585
 782         * elf.c (assign_file_positions_for_load_sections): Continue linking
 783         on "PHDR segment not covered by LOAD segment" errors.
 784
 785 2020-02-21  Alan Modra  <amodra@gmail.com>
 786
 787         * mach-o.c (bfd_mach_o_canonicalize_relocs): Fix ineffective
 788         overflow check.
 789         (bfd_mach_o_canonicalize_reloc): Likewise.
 790         (bfd_mach_o_canonicalize_dynamic_reloc): Likewise.  Sanity check
 791         counts and offsets against file size.
 792         (bfd_mach_o_build_dysymtab): Fix ineffective overflow check.
 793         (bfd_mach_o_mangle_sections): Remove unnecessary overflow check.
 794         (bfd_mach_o_read_symtab_symbols): Sanity check count and offset
 795         against file size.  Delete symbol table error message.
 796         (bfd_mach_o_read_dysymtab): Sanity check counts and offsets
 797         against file size.
 798         (bfd_mach_o_read_symtab): Likewise.
 799         (bfd_mach_o_read_command): Pass file size.
 800         (bfd_mach_o_scan): Sanity check command count against file size.
 801
 802 2020-02-21  Alan Modra  <amodra@gmail.com>
 803
 804         PR 25569
 805         * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
 806         "text", "data" and "bss" section pointer vars.  Don't update
 807         section size, just exec header sizes.
 808         (adjust_sizes_and_vmas): Don't update text section size.  Set
 809         initial exec header a_text.  Print exec headers sizes.
 810         * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
 811         (adjust_sizes_and_vmas): Similarly.  Formatting.
 812         (final_link): Correct final file extension.
 813
 814 2020-02-20  Nick Clifton  <nickc@redhat.com>
 815
 816         * elf-bfd.h (struct elf_backend_data): Add symbol_section_index
 817         callback.
 818         * elfxx-target.h (elf_backend_symbol_section_index): Provide
 819         default definition.
 820         (elfNN_bed): Initialise the symbol_section_index field.
 821         * elf.c (swap_out_syms): Call symbol_section_index, if defined, on
 822         OS and PROC specific section indicies.  Warn if converting other
 823         reserved incidies to SHN_ABS.
 824
 825 2020-02-19  Sergey Belyashov  <sergey.belyashov@gmail.com>
 826
 827         PR 25537
 828         * cpu-z80.c: Add machine type compatibility checking.
 829
 830 2020-02-19  H.J. Lu  <hongjiu.lu@intel.com>
 831
 832         PR binutils/25355
 833         * plugin.c (plugin_list_entry): Remove handle.
 834         (try_load_plugin): Call dlclose before return.
 835
 836 2020-02-19  Alan Modra  <amodra@gmail.com>
 837
 838         * libbfd-in.h (_bfd_constant_p): Define.
 839         (_bfd_alloc_and_read, _bfd_malloc_and_read): Check read size against
 840         file size before allocating memory.
 841         * coffgen.c (_bfd_coff_get_external_symbols): Remove file size check.
 842         * elf.c (bfd_elf_get_str_section): Likewise.
 843         (_bfd_elf_slurp_version_tables): Likewise.
 844         * libbfd.h: Regenerate.
 845
 846 2020-02-19  Alan Modra  <amodra@gmail.com>
 847
 848         * libbfd-in.h (_bfd_alloc_and_read, _bfd_malloc_and_read): New.
 849         * aoutx.h (aout_get_external_symbols): Replace calls to
 850         bfd_[m]alloc and bfd_bread with call to _bfd_[m]alloc_and_read.
 851         (slurp_reloc_table): Likewise.
 852         * archive.c (do_slurp_bsd_armap): Likewise.
 853         (do_slurp_coff_armap): Likewise.
 854         * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
 855         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Likewise.
 856         * coff64-rs6000.c (xcoff64_slurp_armap): Likewise.
 857         * coffcode.h (coff_set_arch_mach_hook, buy_and_read): Likewise.
 858         * coffgen.c (coff_real_object_p, coff_object_p, build_debug_section),
 859         (_bfd_coff_get_external_symbols): Likewise.
 860         * ecoff.c (ecoff_slurp_symbolic_header),
 861         (_bfd_ecoff_slurp_symbolic_info, ecoff_slurp_reloc_table),
 862         (_bfd_ecoff_slurp_armap, ecoff_link_add_object_symbols, READ),
 863         (ecoff_indirect_link_order): Likewise.
 864         * elf.c (bfd_elf_get_str_section, setup_group, elf_read_notes),
 865         (_bfd_elf_slurp_version_tables): Likewise.
 866         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 867         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 868         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 869         * elf64-alpha.c (READ): Likewise.
 870         * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Likewise.
 871         * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
 872         * elfcode.h (elf_slurp_symbol_table),
 873         (elf_slurp_reloc_table_from_section): Likewise.
 874         * elflink.c (elf_link_add_object_symbols),
 875         (elf_link_check_versioned_symbol): Likewise.
 876         * elfxx-mips.c (READ): Likewise.
 877         * i386lynx.c (slurp_reloc_table): Likewise.
 878         * lynx-core.c (lynx_core_file_p): Likewise.
 879         * mach-o.c (bfd_mach_o_canonicalize_relocs),
 880         (bfd_mach_o_read_symtab_strtab, bfd_mach_o_alloc_and_read),
 881         (bfd_mach_o_read_prebound_dylib, bfd_mach_o_read_dyld_content
 882         * pdp11.c (aout_get_external_symbols, slurp_reloc_table
 883         * pef.c (bfd_pef_print_loader_section, bfd_pef_scan_start_address),
 884         (bfd_pef_parse_symbols): Likewise.
 885         * peicode.h (pe_ILF_object_p, pe_bfd_object_p
 886         * som.c (setup_sections, som_slurp_string_table),
 887         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 888         (som_bfd_fill_in_ar_symbols): Likewise.
 889         * vms-alpha.c (module_find_nearest_line, evax_bfd_print_dst),
 890         (evax_bfd_print_image): Likewise.
 891         * vms-lib.c (_bfd_vms_lib_archive_p): Likewise.
 892         * wasm-module.c (wasm_scan): Likewise.
 893         * xcofflink.c (xcoff_link_add_symbols): Likewise.
 894         * xsym.c (bfd_sym_read_name_table),
 895         (bfd_sym_print_type_information_table_entry): Likewise.
 896         * libbfd.h: Regenerate.
 897
 898 2020-02-19  Alan Modra  <amodra@gmail.com>
 899
 900         * aoutx.h (slurp_reloc_table): Allocate reloc_cache after
 901         reading external relocs.
 902         * ecoff.c (ecoff_slurp_reloc_table): Likewise.
 903         * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error
 904         after bfd_bread.
 905         * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary
 906         bfd_release.
 907         * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*.
 908         (m32c_elf_relax_section): Likewise.
 909         * elf32-rl78.c (rl78_offset_for_reloc): Likewise.
 910         (rl78_elf_relax_section): Likewise.
 911         * elf32-rx.c (rx_offset_for_reloc): Likewise.
 912         (elf32_rx_relax_section): Likewise.
 913         * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better
 914         parameter types and use..
 915         (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib),
 916         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions.
 917         * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr
 918         being read from file, just the extra.
 919         * som.c (som_slurp_symbol_table): Allocate internal symbol buffer
 920         after reading external syms.  Free on failure.
 921
 922 2020-02-19  Alan Modra  <amodra@gmail.com>
 923
 924         * coffcode.h (buy_and_read, coff_slurp_line_table),
 925         (coff_slurp_symbol_table, coff_slurp_reloc_table): Replace
 926         bfd_[z][m]alloc2 calls with _bfd_mul_overflow followed by the
 927         corresponding bfd_alloc call.  Adjust variables to suit.
 928         * coffgen.c (_bfd_coff_get_external_symbols): Likewise.
 929         * ecoff.c (_bfd_ecoff_slurp_symbolic_info),
 930         (_bfd_ecoff_slurp_symbol_table, READ): Likewise.
 931         * elf.c (bfd_elf_get_elf_syms, setup_group, bfd_section_from_shdr),
 932         (swap_out_syms, _bfd_elf_slurp_version_tables): Likewise.
 933         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 934         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 935         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 936         * elf64-alpha.c (READ): Likewise.
 937         * elfcode.h (elf_object_p, elf_write_relocs, elf_write_shdrs_and_ehdr),
 938         (elf_slurp_symbol_table, elf_slurp_reloc_table),
 939         (bfd_from_remote_memory): Likewise.
 940         * elfcore.h (core_find_build_id): Likewise.
 941         * elfxx-mips.c (READ): Likewise.
 942         * mach-o.c (bfd_mach_o_mangle_sections),
 943         (bfd_mach_o_read_symtab_symbols, bfd_mach_o_read_thread),
 944         (bfd_mach_o_read_dysymtab, bfd_mach_o_flatten_sections),
 945         (bfd_mach_o_scan, bfd_mach_o_fat_archive_p): Likewise.
 946         * som.c (setup_sections, som_prep_for_fixups)
 947         (som_build_and_write_symbol_table, som_slurp_symbol_table),
 948         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 949         (som_bfd_fill_in_ar_symbols, som_slurp_armap),
 950         (som_bfd_ar_write_symbol_stuff): Likewise.
 951         * vms-alpha.c (vector_grow1): Likewise.
 952         * vms-lib.c (vms_add_index): Likewise.
 953         * wasm-module.c (wasm_scan_name_function_section): Likewise.
 954         * libbfd.c (bfd_malloc2, bfd_realloc2, bfd_zmalloc2): Delete.
 955         * opncls.c (bfd_alloc2, bfd_zalloc2): Delete.
 956         * libbfd-in.h (bfd_malloc2, bfd_realloc2, bfd_zmalloc2),
 957         (bfd_alloc2, bfd_zalloc2): Delete.
 958         (_bfd_mul_overflow): Define.
 959         * libbfd.h: Regenerate.
 960
 961 2020-02-19  Alan Modra  <amodra@gmail.com>
 962
 963         * elf.c (bfd_section_from_shdr): Use bfd_zalloc rather than
 964         bfd_zalloc2.
 965         (assign_section_numbers): Likewise.
 966         (elf_map_symbols): Likewise, and bfd_alloc rather than bfd_alloc2.
 967         (_bfd_elf_map_sections_to_segments): Use bfd_malloc rather than
 968         bfd_malloc2, size_t amt, and unsigned tls_count.
 969         (rewrite_elf_program_header): Use bfd_malloc and size_t amt.
 970         * elflink.c (elf_create_symbuf): Use bfd_malloc.
 971         (elf_output_implib): Use bfd_alloc.
 972
 973 2020-02-19  Alan Modra  <amodra@gmail.com>
 974
 975         * bfd.c (struct bfd): Move format and direction to other
 976         bitfields.  Add "size".
 977         * bfdio.c (bfd_get_size): Cache size when not writing file.
 978         * opncls.c (bfd_get_debug_link_info_1): Allow for bfd_get_size
 979         returning zero, ie. unknown.
 980         (bfd_get_alt_debug_link_info): Likewise.
 981         * bfd-in2.h: Regenerate.
 982
 983 2020-02-19  Alan Modra  <amodra@gmail.com>
 984
 985         * coffgen.c (_bfd_coff_get_external_symbols): Don't call
 986         bfd_get_file_size twice.
 987         (_bfd_coff_read_string_table): Allow for bfd_get_file_size
 988         zero, ie. unknown, return.
 989         * elf-attrs.c (_bfd_elf_parse_attributes): Likewise.
 990         * elfcode.h (elf_swap_shdr_in): Likewise.
 991         (elf_object_p): Don't call bfd_get_file_size twice and correct
 992         file size check.
 993
 994 2020-02-19  Alan Modra  <amodra@gmail.com>
 995
 996         * mach-o.c (bfd_mach_o_flatten_sections): Return a bfd_boolean,
 997         FALSE if memory alloc fails.  Adjust calls.
 998         * som.c (som_prep_for_fixups): Likewise.
 999         * vms-alpha.c (alpha_vms_add_fixup_lp, alpha_vms_add_fixup_ca),
1000         (alpha_vms_add_fixup_qr, alpha_vms_add_fixup_lr),
1001         (alpha_vms_add_lw_reloc, alpha_vms_add_qw_reloc): Likewise.
1002         * som.c (som_build_and_write_symbol_table): Return via error_return
1003         on seek failure.
1004         * vms-alpha.c (VEC_APPEND): Adjust for vector_grow1 changes.
1005         (VEC_APPEND_EL): Delete.
1006         (vector_grow1): Return pointer to element.  Catch overflow.
1007         Return NULL on memory allocation failure.
1008         (alpha_vms_add_fixup_lp): Replace VEC_APPEND_EL with VEC_APPEND.
1009         (alpha_vms_add_fixup_ca): Likewise.
1010         (alpha_vms_link_add_object_symbols): Check VEC_APPEND result
1011         before using.
1012         * elf.c (bfd_section_from_shdr): Check bfd_zalloc2 result.
1013
1014 2020-02-19  Alan Modra  <amodra@gmail.com>
1015
1016         * aix386-core.c (aix386_core_file_p): Use size_t for "amt".
1017         * aout-target.h (object_p): Likewise.
1018         * aout-tic30.c (tic30_aout_object_p): Likewise.
1019         * aoutx.h (some_aout_object_p, mkobject, make_empty_symbol),
1020         (emit_stringtab, write_syms, link_hash_table_create),
1021         (aout_link_write_other_symbol): Likewise.
1022         * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p),
1023         (bfd_ar_hdr_from_filesystem, _bfd_write_archive_contents),
1024         (_bfd_compute_and_write_armap): Likewise.
1025         * archures.c (bfd_arch_list): Likewise.
1026         * bfd.c (bfd_record_phdr): Likewise.
1027         * binary.c (binary_canonicalize_symtab): Likewise.
1028         * cisco-core.c (cisco_core_file_validate): Likewise.
1029         * coff-arm.c (coff_arm_link_hash_table_create, find_thumb_glue),
1030         (find_arm_glue, record_arm_to_thumb_glue),
1031         (record_thumb_to_arm_glue): Likewise.
1032         * coff-ppc.c (ppc_coff_link_hash_table_create, record_toc),
1033         (ppc_allocate_toc_section): Likewise.
1034         * coff-rs6000.c (_bfd_xcoff_mkobject, _bfd_xcoff_archive_p): Likewise.
1035         * coff-sh.c (sh_relax_section): Likewise.
1036         * coff64-rs6000.c (xcoff64_archive_p): Likewise.
1037         * coffcode.h (handle_COMDAT, coff_new_section_hook),
1038         (coff_set_alignment_hook, coff_mkobject),
1039         (coff_compute_section_file_positions): Likewise.
1040         * coffgen.c (coff_make_empty_symbol, coff_bfd_make_debug_symbol),
1041         (coff_find_nearest_line_with_names),
1042         ( bfd_coff_set_symbol_class): Likewise.
1043         * cofflink.c (_bfd_coff_link_hash_table_create),
1044         (_bfd_coff_link_input_bfd): Likewise.
1045         * dwarf1.c (alloc_dwarf1_unit, alloc_dwarf1_func): Likewise.
1046         * dwarf2.c (read_abbrevs, read_attribute_value, add_line_info),
1047         (build_line_info_table, sort_line_sequences),
1048         (line_info_add_include_dir, line_info_add_file_name),
1049         (decode_line_info, scan_unit_for_symbols, parse_comp_unit),
1050         (place_sections, _bfd_dwarf2_slurp_debug_info): Likewise.
1051         * ecoff.c (_bfd_ecoff_mkobject, _bfd_ecoff_make_empty_symbol),
1052         (_bfd_ecoff_find_nearest_line),
1053         (_bfd_ecoff_bfd_link_hash_table_create): Likewise.
1054         * ecofflink.c (bfd_ecoff_debug_init): Likewise.
1055         * elf-hppa.h (_bfd_elf_hppa_gen_reloc_type): Likewise.
1056         * elf-m10300.c (mn10300_elf_relax_section),
1057         (elf32_mn10300_link_hash_table_create): Likewise.
1058         * elf-strtab.c (_bfd_elf_strtab_init): Likewise.
1059         * elf.c (make_mapping, copy_elf_program_header): Likewise.
1060         * elf32-arm.c (elf32_arm_link_hash_table_create),
1061         (elf32_arm_setup_section_lists, elf32_arm_check_relocs),
1062         (elf32_arm_new_section_hook): Likewise.
1063         * elf32-avr.c (elf_avr_new_section_hook),
1064         (elf32_avr_link_hash_table_create, get_local_syms),
1065         (elf32_avr_setup_section_lists): Likewise.
1066         * elf32-bfin.c (bfinfdpic_elf_link_hash_table_create),
1067         (bfin_link_hash_table_create): Likewise.
1068         * elf32-cr16.c (elf32_cr16_link_hash_table_create): Likewise.
1069         * elf32-cris.c (elf_cris_link_hash_table_create): Likewise.
1070         * elf32-csky.c (csky_elf_link_hash_table_create),
1071         (csky_elf_check_relocs, elf32_csky_setup_section_lists): Likewise.
1072         * elf32-frv.c (frvfdpic_elf_link_hash_table_create): Likewise.
1073         * elf32-hppa.c (elf32_hppa_link_hash_table_create),
1074         (elf32_hppa_setup_section_lists, get_local_syms): Likewise.
1075         * elf32-i386.c (elf_i386_check_relocs): Likewise.
1076         * elf32-lm32.c (lm32_elf_link_hash_table_create): Likewise.
1077         * elf32-m32r.c (m32r_elf_link_hash_table_create),
1078         (m32r_elf_check_relocs): Likewise.
1079         * elf32-m68hc1x.c (m68hc11_elf_hash_table_create),
1080         (elf32_m68hc11_setup_section_lists),
1081         (elf32_m68hc11_size_stubs): Likewise.
1082         * elf32-m68k.c (elf_m68k_link_hash_table_create): Likewise.
1083         * elf32-metag.c (elf_metag_link_hash_table_create),
1084         (elf_metag_setup_section_lists): Likewise.
1085         * elf32-microblaze.c (microblaze_elf_link_hash_table_create),
1086         (microblaze_elf_check_relocs): Likewise.
1087         * elf32-nds32.c (nds32_elf_link_hash_table_create),
1088         (nds32_elf_check_relocs): Likewise.
1089         * elf32-nios2.c (nios2_elf32_setup_section_lists),
1090         (get_local_syms, nios2_elf32_check_relocs),
1091         (nios2_elf32_link_hash_table_create): Likewise.
1092         * elf32-or1k.c (or1k_elf_link_hash_table_create),
1093         (or1k_elf_check_relocs): Likewise.
1094         * elf32-ppc.c (ppc_elf_modify_segment_map, update_plt_info): Likewise.
1095         * elf32-pru.c (pru_elf32_link_hash_table_create): Likewise.
1096         * elf32-s390.c (elf_s390_link_hash_table_create),
1097         (elf_s390_check_relocs): Likewise.
1098         * elf32-score.c (score_elf_create_got_section),
1099         (s3_elf32_score_new_section_hook),
1100         (elf32_score_link_hash_table_create): Likewise.
1101         * elf32-score7.c (score_elf_create_got_section),
1102         (s7_elf32_score_new_section_hook): Likewise.
1103         * elf32-sh.c (sh_elf_link_hash_table_create),
1104         (sh_elf_check_relocs): Likewise.
1105         * elf32-tic6x.c (elf32_tic6x_link_hash_table_create),
1106         (elf32_tic6x_new_section_hook, elf32_tic6x_check_relocs): Likewise.
1107         * elf32-tilepro.c (tilepro_elf_link_hash_table_create),
1108         (tilepro_elf_check_relocs): Likewise.
1109         * elf32-v850.c (remember_hi16s_reloc): Likewise.
1110         * elf32-vax.c (elf_vax_link_hash_table_create): Likewise.
1111         * elf32-xtensa.c (elf_xtensa_link_hash_table_create),
1112         (elf_xtensa_new_section_hook): Likewise.
1113         * elf64-alpha.c (elf64_alpha_bfd_link_hash_table_create),
1114         (get_got_entry, elf64_alpha_check_relocs): Likewise.
1115         * elf64-hppa.c (elf64_hppa_hash_table_create): Likewise.
1116         * elf64-ia64-vms.c (elf64_ia64_object_p): Likewise.
1117         * elf64-mmix.c (mmix_elf_new_section_hook): Likewise.
1118         * elf64-ppc.c (ppc64_elf_new_section_hook),
1119         (ppc64_elf_link_hash_table_create, update_local_sym_info),
1120         (update_plt_info, ppc64_elf_check_relocs): Likewise.
1121         * elf64-s390.c (elf_s390_link_hash_table_create),
1122         (elf_s390_check_relocs): Likewise.
1123         * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
1124         * elflink.c (bfd_elf_link_record_local_dynamic_symbol),
1125         (_bfd_elf_link_find_version_dependencies, elf_link_add_object_symbols),
1126         (elf_link_add_archive_symbols, compute_bucket_count),
1127         (bfd_elf_size_dynsym_hash_dynstr, _bfd_elf_link_hash_table_create),
1128         (bfd_elf_get_bfd_needed_list, elf_link_swap_symbols_out),
1129         (bfd_elf_final_link): Likewise.
1130         * elfnn-aarch64.c (elfNN_aarch64_link_hash_table_create),
1131         (elfNN_aarch64_setup_section_lists, elfNN_aarch64_check_relocs),
1132         (elfNN_aarch64_new_section_hook): Likewise.
1133         * elfnn-ia64.c (elfNN_ia64_object_p): Likewise.
1134         * elfnn-riscv.c (riscv_elf_link_hash_table_create),
1135         (riscv_elf_check_relocs): Likewise.
1136         * elfxx-mips.c (_bfd_mips_elf_new_section_hook),
1137         (_bfd_mips_elf_add_symbol_hook, _bfd_mips_elf_check_relocs),
1138         (_bfd_mips_elf_modify_segment_map, _bfd_mips_elf_set_section_contents),
1139         (_bfd_mips_elf_link_hash_table_create): Likewise.
1140         * elfxx-sparc.c (_bfd_sparc_elf_link_hash_table_create),
1141         (_bfd_sparc_elf_check_relocs),
1142         (_bfd_sparc_elf_new_section_hook): Likewise.
1143         * elfxx-tilegx.c (tilegx_elf_link_hash_table_create),
1144         (tilegx_elf_check_relocs): Likewise.
1145         * elfxx-x86.c (_bfd_x86_elf_link_hash_table_create): Likewise.
1146         * format.c (bfd_check_format_matches): Likewise.
1147         * hash.c (_bfd_stringtab_init): Likewise.
1148         * ihex.c (ihex_scan): Likewise.
1149         * irix-core.c (irix_core_core_file_p): Likewise.
1150         * linker.c (bfd_wrapped_link_hash_lookup),
1151         (_bfd_generic_link_hash_table_create),
1152         (_bfd_generic_reloc_link_order): Likewise.
1153         * lynx-core.c (lynx_core_file_p): Likewise.
1154         * netbsd-core.c (netbsd_core_file_p): Likewise.
1155         * osf-core.c (osf_core_core_file_p): Likewise.
1156         * pdp11.c (some_aout_object_p, mkobject, make_empty_symbol),
1157         (link_hash_table_create, aout_link_write_other_symbol): Likewise.
1158         * peXXigen.c (_bfd_XX_bfd_copy_private_section_data): Likewise.
1159         * peicode.h (pe_mkobject): Likewise.
1160         * ppcboot.c (ppcboot_mkobject, ppcboot_canonicalize_symtab): Likewise.
1161         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
1162         * sco5-core.c (read_uarea): Likewise.
1163         * som.c (hppa_som_gen_reloc_type, som_object_p, som_prep_headers),
1164         (som_write_fixups, som_write_space_strings, som_write_symbol_strings),
1165         (som_finish_writing, som_canonicalize_symtab, som_new_section_hook),
1166         (som_bfd_copy_private_section_data, bfd_som_set_section_attributes),
1167         (bfd_som_attach_aux_hdr, som_write_armap): Likewise.
1168         * srec.c (srec_scan): Likewise.
1169         * syms.c (_bfd_generic_make_empty_symbol): Likewise.
1170         * targets.c (bfd_target_list): Likewise.
1171         * tekhex.c (first_phase, tekhex_sizeof_headers): Likewise.
1172         * trad-core.c (trad_unix_core_file_p): Likewise.
1173         * vms-alpha.c (vms_initialize, alpha_vms_bfd_link_hash_table_create),
1174         (vms_new_section_hook): Likewise.
1175         * wasm-module.c (wasm_make_empty_symbol): Likewise.
1176         * xcofflink.c (xcoff_get_section_contents),
1177         (_bfd_xcoff_bfd_link_hash_table_create, xcoff_set_import_path),
1178         (xcoff_find_function, bfd_xcoff_link_record_set, xcoff_build_ldsym),
1179         (bfd_xcoff_size_dynamic_sections, xcoff_link_input_bfd): Likewise.
1180
1181 2020-02-19  Alan Modra  <amodra@gmail.com>
1182
1183         * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
1184
1185 2020-02-13  H.J. Lu  <hongjiu.lu@intel.com>
1186
1187         * plugin.c (try_load_plugin): Make plugin_list_iter an argument
1188         and use it if it isn't NULL.  Remove has_plugin_p argument.  Add
1189         a build_list_p argument.  Don't search plugin_list.  Short circuit
1190         when building the plugin list.
1191         (has_plugin): Renamed to has_plugin_list.
1192         (bfd_plugin_set_plugin): Don't set has_plugin.
1193         (bfd_plugin_specified_p): Check plugin_list instead.
1194         (build_plugin_list): New function.
1195         (load_plugin): Call build_plugin_list and use plugin_list.
1196
1197 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1198
1199         PR binutils/25355
1200         * plugin.c (try_claim): Always clean up for LTO wrapper.
1201         (try_load_plugin): Treat each object as independent.  Create a
1202         copy for plugin name.
1203
1204 2020-02-11  Nick Clifton  <nickc@redhat.com>
1205
1206         * elf32-msp430.c (msp430_final_link_relocate): Always use longs
1207         for addresses in print statements.
1208         (msp430_elf_relax_delete_bytes): Likewise.
1209         (msp430_elf_relax_add_words): Likewise.
1210         (msp430_elf_relax_section): Likewise.
1211
1212 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1213
1214         * plugin.c (add_symbols): Clear plugin_data memory.
1215
1216 2020-02-10  H.J. Lu  <hongjiu.lu@intel.com>
1217
1218         PR binutils/25355
1219         * configure.ac (HAVE_EXECUTABLE_SUFFIX): New AC_DEFINE.
1220         (EXECUTABLE_SUFFIX): Likewise.
1221         * config.in: Regenerated.
1222         * configure: Likewise.
1223         * plugin.c (bfd_plugin_close_and_cleanup): Removed.
1224         (plugin_list_entry): Add all_symbols_read, cleanup_handler,
1225         gcc, lto_wrapper, resolution_file, resolution_option, gcc_env,
1226         real_bfd, real_nsyms, real_syms, lto_nsyms and lto_syms.
1227         (get_lto_wrapper): New.
1228         (setup_lto_wrapper_env): Likewise.
1229         (current_plugin): Likewise.
1230         (register_all_symbols_read): Likewise.
1231         (register_cleanup): Likewise.
1232         (get_symbols): Likewise.
1233         (add_input_file): Likewise.
1234         (bfd_plugin_close_and_cleanup): Likewise.
1235         (claim_file): Removed.
1236         (register_claim_file): Set current_plugin->claim_file.
1237         (add_symbols): Make a copy of LTO symbols.  Set lto_nsyms and
1238         lto_syms in current_plugin.
1239         (try_claim): Use current_plugin->claim_file.  Call LTO plugin
1240         all_symbols_read handler.  Copy real symbols to plugin_data.
1241         Call LTO plugin cleanup handler.  Clean up for LTO wrapper.
1242         (try_load_plugin): Don't reuse the previous plugin for LTO
1243         wrapper.  Set up GCC LTO wrapper if possible.  Don't set
1244         plugin_list_iter->claim_file.
1245         (bfd_plugin_canonicalize_symtab): Use real LTO symbols if
1246         possible.
1247         * plugin.h (plugin_data_struct): Add real_bfd, real_nsyms and
1248         real_syms.
1249
1250 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1251
1252         * elf32-msp430.c (msp430_elf_relax_section): Before relaxing a branch,
1253         check if previous instruction matches a conditional jump inserted
1254         earlier. Invert conditional jump and delete branch in this case.
1255
1256 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1257
1258         * elf32-msp430.c (msp430_elf_relax_add_two_words): Rename to
1259         msp430_elf_relax_add_words. Support insertion of either one or two
1260         words.
1261         (msp430_elf_relax_section): Catch opcode of 0x3c00 when relocation
1262         needs to be grown. Handle insertion of branch instruction to replace
1263         jump.
1264
1265 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1266
1267         * elf32-msp430.c (msp430_final_link_relocate): Add printf statements for
1268         debugging relocations.
1269         (msp430_elf_relax_delete_bytes): Likewise.
1270         (msp430_elf_relax_add_two_words): Likewise.
1271         (msp430_elf_relax_section): Likewise.
1272
1273 2020-02-10  Alan Modra  <amodra@gmail.com>
1274
1275         * archures.c: Wrap overlong z80 comments.
1276         * bfd-in2.h: Regenerate.
1277
1278 2020-02-07  Sergey Belyashov  <sergey.belyashov@gmail.com>
1279
1280         PR 25469
1281         * archures.c: Add GBZ80 and Z80N machine values.
1282         * reloc.c: Add BFD_RELOC_Z80_16_BE.
1283         * coff-z80.c: Add support for new reloc.
1284         * coffcode.h: Add support for new machine values.
1285         * cpu-z80.c: Add support for new machine names.
1286         * elf32-z80.c: Add support for new reloc.
1287         * bfd-in2.h: Regenerate.
1288         * libbfd.h: Regenerate.
1289
1290 2020-02-07  Nick Clifton  <nickc@redhat.com>
1291
1292         PR 23932
1293         * elf.c (rewrite_elf_program_header): Do not complain if no
1294         sections are mapped to a segment.
1295
1296 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1297
1298         PR ld/25490
1299         * elflink.c (_bfd_elf_gc_mark_extra_sections): Issue an error
1300         for garbage collection on __patchable_function_entries section
1301         without linked-to section.
1302
1303 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1304
1305         PR gas/25381
1306         * bfd-in2.h: Regenerated.
1307         * elflink.c (_bfd_elf_gc_mark_extra_sections): Call mark_hook
1308         on section if gc_mark of any of its linked-to sections is set
1309         and don't set gc_mark again.
1310         * section.c (asection): Add linked_to_symbol_name to map_head
1311         union.
1312
1313 2020-02-06  Maciej W. Rozycki  <macro@wdc.com>
1314
1315         * elf32-v850.c (v850_elf_relax_section): Fix the index used for
1316         reporting an unrecognized instruction with R_V850_LONGJUMP.
1317
1318 2020-02-05  Alan Modra  <amodra@gmail.com>
1319
1320         * elf64-ppc.c (ppc_stub_plt_branch): Match comment with reality.
1321
1322 2020-02-04  Alan Modra  <amodra@gmail.com>
1323
1324         * elf32-ppc.c (ppc_elf_relocate_section): After applying
1325         R_PPC_VLE_ADDR20, goto copy_reloc.
1326
1327 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1328
1329         * bfd-in2.h: Regenerated.
1330         * section.c (SEC_ASSEMBLER_SECTION_ID): Fix a typo in comments.
1331
1332 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1333
1334         PR gas/25380
1335         * bfd-in2.h: Regenerated.
1336         * ecoff.c (bfd_debug_section): Add section_id.
1337         * section.c (bfd_section): Add section_id.
1338         (SEC_ASSEMBLER_SECTION_ID): New.
1339         (BFD_FAKE_SECTION): Add section_id.
1340
1341 2020-02-01  Nick Clifton  <nickc@redhat.com>
1342
1343         * config.bfd: Move the c30-aout and tic30-aout targets onto the
1344         obsolete list.
1345
1346 2020-01-31  Sandra Loosemore  <sandra@codesourcery.com>
1347
1348         * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): DW_EH_PE_datarel
1349         encodings are relative to the GOT on nios2, too.
1350
1351 2020-01-31  Alan Modra  <amodra@gmail.com>
1352
1353         * Makefile.am (elf32-target.h, elf64-target.h): Don't use a temp
1354         file.  Use $< and $@ in rules.
1355         (elf32-aarch64.c, elf64-aarch64.c): Likewise.
1356         (elf32-ia64.c, elf64-ia64.c): Likewise.
1357         (elf32-riscv.c, elf64-riscv.c): Likewise.
1358         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1359         (elf32-aarch64.c, elf64-aarch64.c): Don't emit $srcdir on #line.
1360         (elf32-riscv.c, elf64-riscv.c): Likewise, and use $(SED).
1361         (elf32-ia64.c, elf64-ia64.c): Do emit #line.
1362         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1363         * Makefile.in: Regenerate.
1364
1365 2020-01-31  Alan Modra  <amodra@gmail.com>
1366
1367         PR 4110
1368         * elf.c (setup_group): Don't clear entire section contents,
1369         just the padding after group flags.  Release alloc'd memory
1370         after a seek or read failure.
1371
1372 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1373
1374         * peXXigen.c (pe_is_repro): New function.
1375         (_bfd_XX_print_private_bfd_data_common): Note timestamp is
1376         actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
1377
1378 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1379
1380         * peXXigen.c (debug_type_names): Add names for new debug data type
1381         values.
1382
1383 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1384
1385         * peXXigen.c (pe_print_debugdata): Fix the iteration variable for
1386         inner loop.  Fix a memory leak.
1387
1388 2020-01-30  Alan Modra  <amodra@gmail.com>
1389
1390         * coffgen.c (coff_real_object_p): Don't clear obj_coff_keep_syms
1391         or obj_coff_keep_strings here.
1392         (coff_get_normalized_symtab): Free external syms directly.
1393         * xcofflink.c (xcoff_link_input_bfd): Restore obj_coff_keep_syms
1394         on error exit path.
1395
1396 2020-01-27  Jim Wilson  <jimw@sifive.com>
1397
1398         * cpu-riscv.c (riscv_scan): New.
1399         (N): Change bfd_default_scan to riscv_scan.
1400
1401 2020-01-27  Andreas Schwab  <schwab@suse.de>
1402
1403         * Makefile.am (ALL_MACHINES): Remove cpu-plugin.lo.
1404         (ALL_MACHINES_CFILES): Remove cpu-plugin.c.
1405         * Makefile.in: Regenerate.
1406         * cpu-plugin.c: Remove.
1407         * archures.c (enum bfd_architecture): Remove bfd_arch_plugin.
1408         (bfd_plugin_arch): Remove declaration.
1409         * bfd-in2.h: Regenerate.
1410         * po/SRC-POTFILES.in: Regenerate.
1411
1412 2020-01-27  H.J. Lu  <hongjiu.lu@intel.com>
1413             Alan Modra  <amodra@gmail.com>
1414
1415         PR ld/25458
1416         * elflink.c (_bfd_elf_gc_mark_rsec): Mark all weak aliases.
1417
1418 2020-01-24  Jim Wilson  <jimw@sifive.com>
1419
1420         * elfxx-riscv.c (riscv_get_prefix_class): Format s case like others.
1421         (riscv_parse_prefixed_ext): Fix s extension comment and reword to
1422         avoid over long line.
1423
1424 2020-01-24  Nick Clifton  <nickc@redhat.com>
1425
1426         PR 25447
1427         * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep
1428         syms and keep strings flags as these may have been set in order to
1429         prevent a bogus call to free.
1430
1431 2020-01-23  Nick Clifton  <nickc@redhat.com>
1432
1433         * po/fr.po: Updated French translation.
1434
1435 2020-01-23  Alan Modra  <amodra@gmail.com>
1436
1437         PR 25444
1438         * elf.c (assign_file_positions_for_load_sections): Avoid divide
1439         by zero when p_align is zero.
1440
1441 2020-01-22  Maxim Blinov  <maxim.blinov@embecosm.com>
1442
1443         * bfd/elfnn-riscv.c (riscv_skip_prefix): New.
1444         (riscv_prefix_cmp): Likewise.
1445         (riscv_non_std_ext_p): Deleted.
1446         (riscv_std_sv_ext_p): Likewise.
1447         (riscv_non_std_sv_ext_p): Likewise.
1448         (riscv_merge_non_std_and_sv_ext): Rename to...
1449         (riscv_merge_multi_letter_ext): and modified to use riscv_prefix_cmp.
1450         (riscv_merge_arch_attr_info): Replace 3 calls to
1451         riscv_merge_non_std_and_sv_ext with single call to
1452         riscv_merge_multi_letter_ext.
1453         * bfd/elfxx-riscv.c (riscv_parse_std_ext): Break if we
1454         encounter a 'z' prefix.
1455         (riscv_get_prefix_class): New function, return prefix class based
1456         on first few characters of input string.
1457         (riscv_parse_config): New structure to factor out minor differences
1458         in extension class parsing behaviour.
1459         (riscv_parse_sv_or_non_std_ext): Rename to...
1460         (riscv_parse_prefixed_ext): and parameterise with
1461         riscv_parse_config.
1462         (riscv_std_z_ext_strtab, riscv_std_s_ext_strtab): New.
1463         (riscv_multi_letter_ext_valid_p): New.
1464         (riscv_ext_x_valid_p, riscv_ext_z_valid_p, riscv_ext_s_valid_p): New.
1465         (riscv_parse_subset): Delegate all non-single-letter parsing work
1466         to riscv_parse_prefixed_ext.
1467         * bfd/elfxx-riscv.h (riscv_isa_ext_class): New type.
1468         (riscv_get_prefix_class): Declare.
1469
1470 2020-01-22  Alan Modra  <amodra@gmail.com>
1471
1472         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_group.
1473         (ppc64_elf_archive_symbol_lookup): Extract __tls_get_addr_opt for
1474         __tls_get_addr_desc.
1475         (ppc64_elf_size_stubs): Add section for linker generated
1476         __tls_get_addr_desc wrapper function.  Loop at least once if
1477         generating this function.
1478         (emit_tga_desc, emit_tga_desc_eh_frame): New functions.
1479         (ppc64_elf_build_stubs): Generate __tls_get_addr_desc.
1480
1481 2020-01-22  Alan Modra  <amodra@gmail.com>
1482
1483         * elf64-ppc.h (struct ppc64_elf_params): Add no_tls_get_addr_regsave.
1484         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_desc and
1485         tga_desc_fd.
1486         (is_tls_get_addr): Match tga_desc and tga_desc_df too.
1487         (STDU_R1_0R1, ADDI_R1_R1): Define.
1488         (tls_get_addr_prologue, tls_get_addr_epilogue): New functions.
1489         (ppc64_elf_tls_setup): Set up tga_desc and tga_desc_fd.  Indirect
1490         tga_desc_fd to opt_fd, and tga_desc to opt.  Set
1491         no_tls_get_addr_regsave.
1492         (branch_reloc_hash_match): Add hash3 and hash4.
1493         (ppc64_elf_tls_optimize): Handle tga_desc_fd and tga_desc too.
1494         (ppc64_elf_size_dynamic_sections): Likewise.
1495         (ppc64_elf_relocate_section): Likewise.
1496         (plt_stub_size, build_plt_stub): Likewise.  Size regsave
1497         __tls_get_addr stub.
1498         (build_tls_get_addr_stub): Build regsave __tls_get_addr stub and
1499         eh_frame.
1500         (ppc_size_one_stub): Handle tga_desc_fd and tga_desc too.  Size
1501         eh_frame for regsave __tls_get_addr.
1502
1503 2020-01-22  Alan Modra  <amodra@gmail.com>
1504
1505         * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
1506         which __tls_get_addr calls will be eliminated.
1507
1508 2020-01-20  Nick Clifton  <nickc@redhat.com>
1509
1510         * po/pt.po: Updates Portuguese translation.
1511         * po/ru.po: Updated Russian translation.
1512         * po/uk.po: Updated Ukranian translation.
1513
1514 2020-01-20  H.J. Lu  <hongjiu.lu@intel.com>
1515
1516         PR ld/25416
1517         * elf64-x86-64.c (elf_x86_64_check_tls_transition): Support
1518         "rex leal x@tlsdesc(%rip), %reg" and "call *x@tlsdesc(%eax)" in
1519         X32 mode.
1520         (elf_x86_64_relocate_section): In x32 mode, for GDesc -> LE
1521         transition, relax "rex leal x@tlsdesc(%rip), %reg" to
1522         "rex movl $x@tpoff, %reg", for GDesc -> IE transition, relax
1523         "rex leal x@tlsdesc(%rip), %reg" to
1524         "rex movl x@gottpoff(%rip), %eax".  For both transitions, relax
1525         "call *(%eax)" to "nopl (%rax)".
1526
1527 2020-01-20  Alan Modra  <amodra@gmail.com>
1528
1529         * elf64-ppc.c (LD_R11_0R3, CMPDI_R11_0, STD_R11_0R1, LD_R11_0R1),
1530         (MTLR_R11): Don't define.
1531         (LD_R0_0R3, CMPDI_R0_0): Define.
1532         (build_tls_get_addr_stub): Don't use r11 in stub.
1533
1534 2020-01-20  Alan Modra  <amodra@gmail.com>
1535
1536         * elf64-ppc.c (ppc_elf_hash_entry): New function, use throughout file.
1537         (defined_sym_val, is_tls_get_addr): Likewise.
1538
1539 2020-01-18  Nick Clifton  <nickc@redhat.com>
1540
1541         * version.m4 (BFD_VERSION): Set to 2.34.50.
1542         * configure: Regenerate.
1543         * po/bfd.pot: Regenerate.
1544
1545 2020-01-18  Nick Clifton  <nickc@redhat.com>
1546
1547         Binutils 2.34 branch created.
1548
1549 2020-01-17  Christian Biesinger  <cbiesinger@google.com>
1550
1551         * coff-arm.c: Fix spelling error (seperate).
1552         * elfxx-riscv.c (riscv_parse_sv_or_non_std_ext): Fix spelling
1553         error (seperate).
1554         * sysdep.h (strnlen): Fix spelling error (seperate).
1555
1556 2020-01-15  Lars Brinkhoff  <lars@nocrew.org>
1557
1558         PR 20694
1559         * pdp11.c (TARGET_PAGE_SIZE): Set to 8192.
1560
1561 2020-01-15  Alan Modra  <amodra@gmail.com>
1562
1563         PR 25384
1564         * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
1565         (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
1566         of function symbols unless dot symbols are present.  Do warn
1567         whenever one is created, regardles of whether a PLT entry is
1568         also emitted for the function symbol.
1569
1570 2020-01-14  Alan Modra  <amodra@gmail.com>
1571
1572         * som.c (som_bfd_count_ar_symbols): Error when file position
1573         of symbols on chains is not strictly increasing.
1574
1575 2020-01-14  Alan Modra  <amodra@gmail.com>
1576
1577         * vms.h (VMS_DEBUG): Define as 0.
1578         * vms-alpha.c (image_write): Move debug output after bounds check.
1579         Tidy bounds check.
1580         (_bfd_vms_slurp_eihd): Warning fix.
1581         (_bfd_vms_slurp_etir): Init variables to avoid bogus warnings.
1582
1583 2020-01-13  Alan Modra  <amodra@gmail.com>
1584
1585         * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
1586         for "ignored" records.
1587
1588 2020-01-13  Alan Modra  <amodra@gmail.com>
1589
1590         * wasm-module.c (wasm_scan_name_function_section): Formatting.
1591         Delete asect name check.  Move asect NULL check to wasm_object_p.
1592         Correct bounds check of sizes against end.  Replace uses of
1593         bfd_zalloc with bfd_alloc, zeroing only necessary bytes.  Use
1594         just one bfd_release.
1595         (wasm_scan): Don't use malloc/strdup for section names,
1596         bfd_alloc instead.  Simplify code prefixing section name.
1597         Formatting.  Don't attempt to free memory here..
1598         (wasm_object_p): ..do so here.
1599
1600 2020-01-10  Szabolcs Nagy  <szabolcs.nagy@arm.com>
1601
1602         PR ld/22269
1603         * elf32-arm.c (elf32_arm_final_link_relocate): Use
1604         UNDEFWEAK_NO_DYNAMIC_RELOC.
1605         (allocate_dynrelocs_for_symbol): Likewise.
1606
1607 2020-01-10  Tamar Christina  <tamar.christina@arm.com>
1608
1609         PR 25210
1610         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass.
1611
1612 2020-01-10  Alan Modra  <amodra@gmail.com>
1613
1614         * coff-alpha.c (alpha_ecoff_object_p): Calculate size in bfd_size_type.
1615
1616 2020-01-09  Nick Clifton  <nickc@redhat.com>
1617
1618         PR 25221
1619         * bfd.c (bfd_convert_section_contents): Check for a compress
1620         header size that is larger than the actual section size.
1621
1622 2020-01-08  Alan Modra  <amodra@gmail.com>
1623
1624         PR 25351
1625         * elflink.c (bfd_elf_final_link): Call _bfd_fix_excluded_sec_syms
1626         after removing sections.
1627
1628 2020-01-06  Jim Wilson  <jimw@sifive.com>
1629
1630         PR 25205
1631         * elfnn-riscv.c (riscv_elf_relocate_section) <R_RISCV_CALL>: Add
1632         check for !bfd_link_pic (info).
1633         <R_RISCV_CALL_PLT>: Move next to R_RISCV_CALL.
1634         <R_RISCV_JAL>: Add comment.
1635         (_bfd_riscv_relax_section): For plt.offset check, add check for
1636         bfd_link_pic (info).  Add comment.
1637
1638 2020-01-06  Alan Modra  <amodra@gmail.com>
1639
1640         * format.c (bfd_check_format_matches): Ignore bfd_error on target
1641         match failures.  Don't init to bfd_error_wrong_format before
1642         calling _bfd_check_format.
1643
1644 2020-01-06  Alan Modra  <amodra@gmail.com>
1645
1646         * vms-alpha.c (_bfd_vms_push, _bfd_vms_pop): Return pass/fail
1647         status rather than exiting on stack overflow or underflow.
1648         (_bfd_vms_slurp_etir): Adjust to suit.
1649
1650 2020-01-06  Alan Modra  <amodra@gmail.com>
1651
1652         * som.c (som_bfd_fill_in_ar_symbols): Bounds check som_dict index.
1653
1654 2020-01-06  Alan Modra  <amodra@gmail.com>
1655
1656         * mach-o.c (bfd_mach_o_read_dylinker): Don't read past end of
1657         command.  Check name offset is within command.
1658         (bfd_mach_o_read_dylib, bfd_mach_o_read_prebound_dylib),
1659         (bfd_mach_o_read_prebind_cksum, bfd_mach_o_read_twolevel_hints),
1660         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_dysymtab),
1661         (bfd_mach_o_read_symtab, bfd_mach_o_read_uuid),
1662         (bfd_mach_o_read_linkedit, bfd_mach_o_read_str),
1663         (bfd_mach_o_read_dyld_info, bfd_mach_o_read_version_min),
1664         (bfd_mach_o_read_encryption_info, bfd_mach_o_read_source_version),
1665         (bfd_mach_o_read_encryption_info_64, bfd_mach_o_read_main),
1666         (bfd_mach_o_read_note, bfd_mach_o_read_build_version),
1667         (bfd_mach_o_read_segment): Similarly.
1668         (bfd_mach_o_read_thread): Properly bound check thread struct.
1669         Don't repeat checks on second loop.
1670         (bfd_mach_o_read_command): Fail on invalid command length.
1671
1672 2020-01-04  Alan Modra  <amodra@gmail.com>
1673
1674         * format.c (bfd_check_format_matches): Add preserve_match.
1675         Save initial bfd state in "preserve", matched bfd state in
1676         "preserve_match".  Save just the first match.  Release
1677         bfd_alloc memory.  Restore and finish preserved state as
1678         appropriate on all function exit paths.
1679
1680 2020-01-04  Alan Modra  <amodra@gmail.com>
1681
1682         * mmo.c (mmo_mkobject): Allocate tdata with bfd_zalloc.
1683
1684 2020-01-04  Alan Modra  <amodra@gmail.com>
1685
1686         * coffgen.c (coff_real_object_p): Free malloc'd memory on target
1687         match too.
1688
1689 2020-01-03  Nick Clifton  <nickc@redhat.com>
1690
1691         PR 25307
1692         (bfd_pef_parse_function_stubs): Correct the test that ensures that
1693         there is enough data remaining in the code buffer before
1694         attempting to read a function stub.
1695
1696 2020-01-03  Nick Clifton  <nickc@redhat.com>
1697
1698         PR 25308
1699         * elf-properties.c (_bfd_elf_convert_gnu_properties): Check the
1700         return value from bfd_malloc.
1701         * elf32-arm.c (bfd_elf32_arm_vfp11_fix_veneer_locations): Likewise.
1702         (bfd_elf32_arm_stm32l4xx_fix_veneer_locations): Likewise.
1703         (elf32_arm_filter_cmse_symbols): Likewise.
1704         (elf32_arm_write_section): Likewise.
1705         * mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
1706         (bfd_mach_o_follow_dsym): Likewise.
1707         * pef.c (bfd_pef_print_loader_section): Likewise.
1708         (bfd_pef_scan_start_address): Likewise.
1709         (bfd_pef_parse_function_stubs): Likewise.
1710         (bfd_pef_parse_symbols): Likewise.
1711
1712 2020-01-03  Sergei Trofimovich  <siarheit@google.com>
1713
1714         * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): don't fail
1715         on binary inputs ld/PR25316.
1716         (is_ia64_elf): new helper to filter on ia64 objects.
1717
1718 2020-01-03  Jan Beulich  <jbeulich@suse.com>
1719
1720         * mach-o.c (cpusubtype, bfd_mach_o_header_p): Insert underscore
1721         in parameter names.
1722         (bfd_mach_o_scan): Insert underscore in two variable names.
1723
1724 2020-01-02  Sergey Belyashov  <sergey.belyashov@gmail.com>
1725
1726         * Makefile.am: Add z80-elf target support.
1727         * configure.ac: Likewise.
1728         * targets.c: Likewise.
1729         * Makefile.in: Regenerate.
1730         * configure: Regenerate.
1731         * config.bfd: Add z80-elf target support and new arches: ez80 and
1732         z180.
1733         * elf32-z80.c: New file.
1734         * archures.c: Add new z80 architectures: eZ80 and Z180.
1735         * coffcode.h: Likewise.
1736         * cpu-z80.c: Likewise.
1737         * coff-z80.c: Add new relocations for Z80 target and local label
1738         check.
1739         * reloc.c: Add new relocs.
1740         * bfd-in2.h: Regenerate.
1741         * libbfd.h: Regenerate.
1742
1743 2020-01-02  Tamar Christina  <tamar.christina@arm.com>
1744
1745         PR 25210
1746         PR 24753
1747         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
1748
1749 2020-01-01  Alan Modra  <amodra@gmail.com>
1750
1751         Update year range in copyright notice of all files.
1752
1753 For older changes see ChangeLog-2019
1754 \f
1755 Copyright (C) 2020 Free Software Foundation, Inc.
1756
1757 Copying and distribution of this file, with or without modification,
1758 are permitted in any medium without royalty provided the copyright
1759 notice and this notice are preserved.
1760
1761 Local Variables:
1762 mode: change-log
1763 left-margin: 8
1764 fill-column: 74
1765 version-control: never
1766 End: