Re: PR25993, read of freed memory
[deliverable/binutils-gdb.git] / bfd / ChangeLog
1 2020-05-21 Alan Modra <amodra@gmail.com>
2
3 PR 25993
4 * opncls.c (_bfd_free_cached_info): Keep a copy of the bfd
5 filename.
6 (_bfd_delete_bfd): Free the copy.
7 (_bfd_new_bfd): Free nbfd->memory on error.
8
9 2020-05-21 Alan Modra <amodra@gmail.com>
10
11 * aoutx.h: Replace "if (x) free (x)" with "free (x)" throughout.
12 * archive.c, * bfd.c, * bfdio.c, * coff-alpha.c, * coff-ppc.c,
13 * coff-sh.c, * coff-stgo32.c, * coffcode.h, * coffgen.c,
14 * cofflink.c, * cpu-arm.c, * doc/chew.c, * dwarf2.c, * ecoff.c,
15 * ecofflink.c, * elf-eh-frame.c, * elf-m10200.c, * elf-m10300.c,
16 * elf-strtab.c, * elf.c, * elf32-arc.c, * elf32-arm.c,
17 * elf32-avr.c, * elf32-bfin.c, * elf32-cr16.c, * elf32-crx.c,
18 * elf32-epiphany.c, * elf32-ft32.c, * elf32-h8300.c,
19 * elf32-ip2k.c, * elf32-m32c.c, * elf32-m68hc11.c,
20 * elf32-m68k.c, * elf32-microblaze.c, * elf32-msp430.c,
21 * elf32-nds32.c, * elf32-nios2.c, * elf32-ppc.c, * elf32-pru.c,
22 * elf32-rl78.c, * elf32-rx.c, * elf32-sh.c, * elf32-spu.c,
23 * elf32-v850.c, * elf32-xtensa.c, * elf64-alpha.c,
24 * elf64-hppa.c, * elf64-ia64-vms.c, * elf64-mips.c
25 * elf64-mmix.c, * elf64-ppc.c, * elf64-sparc.c, * elfcode.h,
26 * elflink.c, * elfnn-ia64.c, * elfnn-riscv.c, * elfxx-mips.c,
27 * elfxx-x86.c, * format.c, * ihex.c, * libbfd.c, * linker.c,
28 * mmo.c, * opncls.c, * pdp11.c, * peXXigen.c, * pef.c,
29 * peicode.h, * simple.c, * som.c, * srec.c, * stabs.c, * syms.c,
30 * targets.c, * vms-lib.c, * xcofflink.c, * xtensa-isa.c: Likewise.
31
32 2020-05-20 Nelson Chu <nelson.chu@sifive.com>
33
34 * elfxx-riscv.h (riscv_parse_subset_t): Add new callback function
35 get_default_version. It is used to find the default version for
36 the specific extension.
37 * elfxx-riscv.c (riscv_parsing_subset_version): Remove the parameters
38 default_major_version and default_minor_version. Add new bfd_boolean
39 parameter *use_default_version. Set it to TRUE if we need to call
40 the callback rps->get_default_version to find the default version.
41 (riscv_parse_std_ext): Call rps->get_default_version if we fail to find
42 the default version in riscv_parsing_subset_version, and then call
43 riscv_add_subset to add the subset into subset list.
44 (riscv_parse_prefixed_ext): Likewise.
45 (riscv_std_z_ext_strtab): Support Zicsr extensions.
46 * elfnn-riscv.c (riscv_merge_std_ext): Use strcasecmp to compare the
47 strings rather than characters.
48 riscv_merge_arch_attr_info): The callback function get_default_version
49 is only needed for assembler, so set it to NULL int the linker.
50 * elfxx-riscv.c (riscv_estimate_digit): Remove the static.
51 * elfxx-riscv.h: Updated.
52
53 2020-05-20 Alan Modra <amodra@gmail.com>
54
55 PR 25993
56 * archive.c (_bfd_get_elt_at_filepos): Don't strdup filename,
57 use bfd_set_filename.
58 * elfcode.h (_bfd_elf_bfd_from_remote_memory): Likewise.
59 * mach-o.c (bfd_mach_o_fat_member_init): Likewise.
60 * opncls.c (bfd_fopen, bfd_openstreamr, bfd_openr_iovec, bfd_openw),
61 (bfd_create): Likewise.
62 (_bfd_delete_bfd): Don't free filename.
63 (bfd_set_filename): Copy filename param to bfd_alloc'd memory,
64 return pointer to the copy or NULL on alloc fail.
65 * vms-lib.c (_bfd_vms_lib_get_module): Free newname and test
66 result of bfd_set_filename.
67 * bfd-in2.h: Regenerate.
68
69 2020-05-20 Alan Modra <amodra@gmail.com>
70
71 PR 26011
72 * elf.c (_bfd_elf_get_reloc_upper_bound): Sanity check reloc
73 section size against file size.
74 (_bfd_elf_get_dynamic_reloc_upper_bound): Likewise.
75
76 2020-05-19 Gunther Nikl <gnikl@justmail.de>
77
78 PR 26005
79 * elf.c (bfd_section_from_shdr): Replace bfd_zmalloc with bfd_malloc
80 and memset when allocating memory for the sections_being_created
81 array.
82
83 2020-05-19 Stafford Horne <shorne@gmail.com>
84
85 * elf32-or1k.c (or1k_elf_finish_dynamic_symbol): Rename srela
86 to relgot.
87 (or1k_elf_relocate_section): Access srelgot via
88 htab->root.srelgot. Add assertions for srelgot->contents.
89 Introduce local variable for srelgot to not reuse global
90 sreloc.
91 (or1k_elf_relocate_section): Fixup dynamic symbol detection.
92 (or1k_set_got_and_rela_sizes): New function.
93 (or1k_initial_exec_offset): New function.
94 (TLS_GD, TLS_IE, TLS_LD, TLS_LE): Redefine macros as masks.
95 (or1k_elf_relocate_section): Allow for TLS to handle multiple
96 model access.
97 (or1k_elf_check_relocs): Use OR to set TLS access.
98 (allocate_dynrelocs): Use or1k_set_got_and_rela_sizes to set
99 sizes.
100 (or1k_elf_size_dynamic_sections): Use
101 or1k_set_got_and_rela_sizes to set sizes.
102 (or1k_elf_relocate_section): Fixup PCREL relocation calculation.
103 (TCB_SIZE): New macro.
104 (tpoff): Use TCB_SIZE and alignment to calculate offset.
105 (allocate_dynrelocs, readonly_dynrelocs, or1k_elf_check_relocs)
106 (or1k_elf_size_dynamic_sections): Rename p to sec_relocs.
107 (allocate_dynrelocs): Rename s to splt or sgot based on usage.
108 (tpoff): Add dynamic boolean argument.
109 (or1k_elf_relocate_section): Pass dynamic flag to tpoff.
110
111 2020-05-19 Siddhesh Poyarekar <siddesh.poyarekar@arm.com>
112
113 * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Club
114 BFD_RELOC_AARCH64_BRANCH19 and BFD_RELOC_AARCH64_TSTBR14
115 cases with BFD_RELOC_AARCH64_JUMP26.
116 (elfNN_aarch64_check_relocs): Likewise.
117
118 2020-05-19 Alan Modra <amodra@gmail.com>
119
120 * aix5ppc-core.c (xcoff64_core_file_matches_executable_p): Use
121 bfd_get_filename rather than accessing bfd->filename directly.
122 * aout-target.h (MY (object_p)): Likewise.
123 * aoutx.h (aout_find_nearest_line, aout_link_write_symbols): Likewise.
124 * archive.c (find_nested_archive, _bfd_generic_read_ar_hdr_mag),
125 (_bfd_construct_extended_name_table, _bfd_bsd44_write_ar_hdr),
126 (_bfd_archive_bsd44_construct_extended_name_table),
127 (_bfd_write_archive_contents, _bfd_compute_and_write_armap),
128 (_bfd_bsd_write_armap): Likewise.
129 * bfd.c (bfd_errmsg, _bfd_doprnt): Likewise.
130 * cache.c (bfd_open_file): Likewise.
131 * ecoff.c (_bfd_ecoff_write_armap): Likewise.
132 * ecofflink.c (bfd_ecoff_debug_accumulate_other): Likewise.
133 * elf32-bfin.c (bfinfdpic_relocate_section): Likewise.
134 * elf32-frv.c (elf32_frv_relocate_section): Likewise.
135 * elf32-hppa.c (elf32_hppa_final_link): Likewise.
136 * elf32-nds32.c (nds32_elf_output_symbol_hook),
137 (patch_tls_desc_to_ie): Likewise.
138 * elf32-spu.c (sort_bfds, print_one_overlay_section),
139 (spu_elf_auto_overlay): Likewise.
140 * elf64-hppa.c (elf_hppa_final_link): Likewise.
141 * elf64-ia64-vms.c (elf64_ia64_size_dynamic_sections): Likewise.
142 * elfcore.h (elf_core_file_matches_executable_p): Likewise.
143 * elflink.c (bfd_elf_size_dynamic_sections),
144 (elf_link_input_bfd): Likewise.
145 * linker.c (_bfd_generic_link_output_symbols): Likewise.
146 * mach-o.c (bfd_mach_o_follow_dsym),
147 (bfd_mach_o_close_and_cleanup): Likewise.
148 * opncls.c (_bfd_delete_bfd, _maybe_make_executable),
149 (find_separate_debug_file, get_build_id_name): Likewise.
150 * pdp11.c (aout_find_nearest_line, aout_link_write_symbols): Likewise.
151 * plugin.c (bfd_plugin_open_input): Likewise.
152 * rs6000-core.c (rs6000coff_core_file_matches_executable_p): Likewise.
153 * som.c (som_write_armap): Likewise.
154 * srec.c (srec_write_record, srec_write_symbols): Likewise.
155 * vms-lib.c (_bfd_vms_lib_get_imagelib_file),
156 (_bfd_vms_lib_write_archive_contents): Likewise.
157 * xcofflink.c (xcoff_link_add_dynamic_symbols): Likewise.
158
159 2020-05-19 Alan Modra <amodra@gmail.com>
160
161 PR 25713
162 * bfdio.c (_bfd_real_fopen): Typo fix.
163
164 2020-05-18 Nick Clifton <nickc@redhat.com>
165
166 PR 26005
167 * elf.c (bfd_section_from_shdr): Use bfd_malloc to allocate memory
168 for the sections_being_created array.
169
170 2020-05-18 Alan Modra <amodra@gmail.com>
171
172 * ecoff.c (ecoff_slurp_reloc_table): Malloc external_relocs so
173 they can be freed without also freeing internal_relocs.
174
175 2020-05-18 Jaydeep Chauhan <jaydeepchauhan1494@gmail.com>
176
177 PR 25713
178 * bfdio.c (_bfd_real_fopen): Convert UNIX style sirectory
179 separators into DOS style when creating a WIN32 fullpath.
180
181 2020-05-14 Nelson Chu <nelson.chu@sifive.com>
182
183 * elfnn-riscv.c (elfNN_riscv_mkobject): New function. We need this
184 to initialize RISC-V tdata.
185
186 2020-05-12 Gunther Nikl <gnikl@justmail.de>
187
188 * aoutx.h (NAME (aout, swap_std_reloc_out)): Reject an unsupported
189 relocation size.
190
191 2020-05-11 Alan Modra <amodra@gmail.com>
192
193 * elf64-ppc.c (xlate_pcrel_opt): Handle lxvp and stxvp.
194
195 2020-05-11 Alan Modra <amodra@gmail.com>
196
197 * elf64-ppc.c: Rename powerxx to power10 throughout.
198
199 2020-05-11 Alan Modra <amodra@gmail.com>
200
201 PR 25961
202 * coffgen.c (coff_get_normalized_symtab): Check that buffer
203 contains required number of auxents before processing any auxent.
204 * coffswap.h (coff_swap_aux_in <C_FILE>): Only swap in extended
205 file name from auxents for PE.
206
207 2020-05-04 Gunther Nikl <gnikl@justmail.de>
208
209 * aout-cris.c (DEFAULT_ARCH): Delete define.
210 (MY_set_arch_mach): Likewise.
211 (SET_ARCH_MACH): Use bfd_set_arch_mach with an explicit architecture
212 of bfd_arch_cris.
213 (swap_ext_reloc_in): Add casts to r_index extraction. Mask valid bits
214 of r_type before the shift.
215
216 2020-05-04 Wilco Dijkstra <wdijkstr@arm.com>
217
218 PR ld/25665
219 * elfnn-aarch64.c (group_sections): Copy implementation from
220 elf32-arm.c.
221
222 2020-05-01 Alan Modra <amodra@gmail.com>
223
224 PR 25900
225 * elfnn-riscv.c (_bfd_riscv_relax_section): Check root.type before
226 accessing root.u.def of symbols. Also check root.u.def.section
227 is non-NULL. Reverse tests so as to make the logic positive.
228
229 2020-05-01 Alan Modra <amodra@gmail.com>
230
231 PR 25882
232 * elf32-tic6x.c (elf32_tic6x_merge_attributes): Don't transfer
233 Tag_ABI_PIC or Tag_ABI_PID from dynamic objects to the output.
234
235 2020-05-01 Alan Modra <amodra@gmail.com>
236
237 PR 25882
238 * elf32-bfin.c (elf32_bfin_merge_private_bfd_data): Add FIXME.
239 * elf32-frv.c (frv_elf_merge_private_bfd_data): Likewise.
240 * elfxx-mips.c (_bfd_mips_elf_merge_private_bfd_data): Likewise.
241 * elf32-nds32.c (nds32_elf_merge_private_bfd_data): Likewise.
242 * elf32-score.c (s3_elf32_score_merge_private_bfd_data): Likewise.
243 * elf32-score7.c (s7_elf32_score_merge_private_bfd_data): Likewise.
244 * elf32-sh.c (sh_elf_merge_private_data): Likewise.
245 * elf32-tic6x.c (elf32_tic6x_merge_attributes): Likewise.
246 * elf64-ia64-vms.c (elf64_ia64_merge_private_bfd_data): Likewise.
247 * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): Likewise.
248
249 2020-05-01 Alan Modra <amodra@gmail.com>
250
251 PR 25882
252 * elf32-ppc.c (ppc_elf_merge_private_bfd_data): Ignore e_flags
253 from shared libraries.
254
255 2020-04-29 Max Filippov <jcmvbkbc@gmail.com>
256
257 * elf32-xtensa.c (relax_section): Don't negate diff_value for
258 XTENSA_NDIFF relocations. Don't add sign bits whe diff_value
259 equals 0. Report overflow when the result has negative sign but
260 all significant bits are zero.
261
262 2020-04-29 Gunther Nikl <gnikl@justmail.de>
263
264 * aoutx.h (swap_std_reloc_out): Special case 64 bit relocations.
265 (aout_link_reloc_link_order): Likewise. Make r_length an unsigned.
266
267 2020-04-28 Alan Modra <amodra@gmail.com>
268
269 * vms-alpha.c (_bfd_vms_slurp_etir): Correct divide by zero check.
270 Emit warning message.
271
272 2020-04-27 Tamar Christina <tamar.christina@arm.com>
273
274 * coff-i386.c (COFF_WITH_PE_BIGOBJ): New.
275 * coff-x86_64.c (COFF_WITH_PE_BIGOBJ): New.
276 * config.bfd (targ_selvecs): Rename x86_64_pe_be_vec
277 to x86_64_pe_big_vec as it not a big-endian format.
278 (vec i386_pe_big_vec): New.
279 * configure.ac: Likewise.
280 * targets.c: Likewise.
281 * configure: Regenerate.
282 * pe-i386.c (TARGET_SYM_BIG, TARGET_NAME_BIG,
283 COFF_WITH_PE_BIGOBJ): New.
284 * pe-x86_64.c (TARGET_SYM_BIG, TARGET_NAME_BIG):
285 New.
286 (x86_64_pe_be_vec): Moved.
287
288 2020-04-23 Anton Kolesov <anton.kolesov@synopsys.com>
289
290 * elf-bfd.h (elfcore_write_arc_v2): Add prototype.
291 * elf.c (elfcore_grok_arc_v2): New function.
292 (elfcore_grok_note): Call the new function to handle the corresponding
293 note.
294 (elfcore_write_arc_v2): New function.
295 (elfcore_write_register_note): Call the new function to handle the
296 corresponding pseudo-sections.
297
298 2020-04-22 Max Filippov <jcmvbkbc@gmail.com>
299
300 PR ld/25861
301 * bfd-in2.h: Regenerated.
302 * elf32-xtensa.c (elf_howto_table): New entries for
303 R_XTENSA_PDIFF{8,16,32} and R_XTENSA_NDIFF{8,16,32}.
304 (elf_xtensa_reloc_type_lookup, elf_xtensa_do_reloc)
305 (relax_section): Add cases for R_XTENSA_PDIFF{8,16,32} and
306 R_XTENSA_NDIFF{8,16,32}.
307 * libbfd.h (bfd_reloc_code_real_names): Add names for
308 BFD_RELOC_XTENSA_PDIFF{8,16,32} and
309 BFD_RELOC_XTENSA_NDIFF{8,16,32}.
310 * reloc.c: Add documentation for BFD_RELOC_XTENSA_PDIFF{8,16,32}
311 and BFD_RELOC_XTENSA_NDIFF{8,16,32}.
312
313 2020-04-21 Tamar Christina <tamar.christina@arm.com>
314
315 PR binutils/24753
316 * compress.c (bfd_get_full_section_contents): Exclude sections with no
317 content.
318
319 2020-04-21 H.J. Lu <hongjiu.lu@intel.com>
320
321 PR ld/25849
322 * elf-bfd.h (elf_backend_data): Add
323 elf_backend_strip_zero_sized_dynamic_sections.
324 (_bfd_elf_strip_zero_sized_dynamic_sections): New prototype.
325 * elf64-alpha.c (elf_backend_strip_zero_sized_dynamic_sections):
326 New macro.
327 * elflink.c (_bfd_elf_strip_zero_sized_dynamic_sections): New
328 function.
329 * elfxx-target.h (elf_backend_strip_zero_sized_dynamic_sections):
330 New macro.
331 (elfNN_bed): Add elf_backend_strip_zero_sized_dynamic_sections.
332
333 2020-04-21 H.J. Lu <hongjiu.lu@intel.com>
334
335 * elf64-alpha.c (alpha_elf_reloc_entry): Replace reltext with
336 sec.
337 (elf64_alpha_check_relocs): Set sec instead of reltext. Warn
338 DT_TEXTREL with -M.
339 (elf64_alpha_calc_dynrel_sizes): Warn DT_TEXTREL with -M.
340
341 2020-04-21 Nick Clifton <nickc@redhat.com>
342
343 * po/sr.po: Updated Serbian translation.
344
345 2020-04-21 Alan Modra <amodra@gmail.com>
346
347 * elf32-sh.c (sh_elf_relocate_section): Remove STO_SH5_ISA32
348 processing.
349
350 2020-04-20 Stephen Casner <casner@acm.org>
351
352 * pdp11.c (N_STAB): Modify value to avoid conflict with N_EXT
353 causing globals from linker script to be treated as debug symbols.
354 (translate_symbol_table): Don't sign-extend symbol values from 16
355 to 64 bits in nm output.
356
357 2020-04-20 Alan Modra <amodra@gmail.com>
358
359 * elf64-ppc.c (ppc64_elf_size_stubs): Strip relbrlt too.
360
361 2020-04-18 Alan Modra <amodra@gmail.com>
362
363 * section.c (bfd_is_const_section): Correct test for special
364 sections.
365 * bfd-in2.h: Regenerate.
366
367 2020-04-17 Alan Modra <amodra@gmail.com>
368
369 PR 25842
370 * elf.c (_bfd_elf_get_symbol_version_string): Don't segfault on
371 NULL nodename.
372
373 2020-04-16 Nick Clifton <nickc@redhat.com>
374
375 PR 25803
376 * elfxx-mips.c (_bfd_mips_elf_adjust_dynamic_symbol): Replace an
377 abort with a more helpful error message.
378
379 2020-04-16 Alan Modra <amodra@gmail.com>
380
381 PR 25827
382 * dwarf2.c (scan_unit_for_symbols): Wrap overlong lines. Don't
383 strdup(0).
384
385 2020-04-15 Fangrui Song <maskray@google.com>
386
387 PR binutils/24613
388 * coff-rs6000.c (xcoff_ppc_relocate_section): Change RM_GENERATE_ERROR
389 to RM_DIAGNOSE plus a check of warn_unresolved_syms.
390 * coff64-rs6000.c (xcoff_ppc_relocate_section): Likewise.
391 * elf-bfd.h (_bfd_elf_large_com_section): Likewise.
392 * elf32-m32r.c (m32r_elf_relocate_section): Likewise.
393 * elf32-score.c (s3_bfd_score_elf_relocate_section): Likewise.
394 * elf32-score7.c (s7_bfd_score_elf_relocate_section): Likewise.
395 * elf32-sh.c (sh_elf_relocate_section): Likewise.
396 * elf32-spu.c (spu_elf_relocate_section): Likewise.
397 * elf64-hppa.c (elf64_hppa_relocate_section): Likewise.
398 * elflink.c (elf_link_output_extsym): Likewise.
399 * elfxx-mips.c (mips_elf_calculate_relocation): Likewise.
400
401 2020-04-15 Alan Modra <amodra@gmail.com>
402
403 PR 25823
404 * peXXigen.c (_bfd_XXi_swap_sym_in <C_SECTION>): Don't use a
405 pointer into strings that may be freed for section name, always
406 allocate a new string.
407
408 2020-04-14 Juan Manuel Guerrero <juan.guerrero@gmx.de>
409 Jan W. Jagersma <jwjagersma@gmail.com>
410
411 * coff-go32.c (COFF_GO32, IMAGE_SCN_LNK_NRELOC_OVFL)
412 (coff_SWAP_scnhdr_in, coff_SWAP_scnhdr_out): Define.
413 (_bfd_go32_swap_scnhdr_in, _bfd_go32_swap_scnhdr_out)
414 (_bfd_go32_mkobject): New functions.
415 * coff-stgo32.c (IMAGE_SCN_LNK_NRELOC_OVFL)
416 (coff_SWAP_scnhdr_in, coff_SWAP_scnhdr_out): Define.
417 (go32exe_mkobject): Call _bfd_go32_mkobject.
418 * coffcode.h (COFF_WITH_EXTENDED_RELOC_COUNTER): Define.
419 (coff_set_alignment_hook): Define function for COFF_GO32_EXE
420 and COFF_GO32.
421 (coff_write_relocs): Enable extended reloc counter code if
422 COFF_WITH_EXTENDED_RELOC_COUNTER is defined. Test for obj_go32.
423 (coff_write_object_contents): Likewise. Pad section headers
424 for COFF_GO32 and COFF_GO32EXE. Use bfd_coff_swap_scnhdr_out
425 instead of coff_swap_scnhdr_out.
426 * cofflink.c (_bfd_coff_final_link): Test also for obj_go32 to
427 enable extended reloc counter.
428 * coffswap.h: (coff_swap_scnhdr_in, coff_swap_scnhdr_out):
429 Declare with ATTRIBUTE_UNUSED.
430 * libcoff-in.h: (struct coff_tdata): New field go32.
431 (obj_go32): Define.
432 * libcoff.h: Regenerate.
433
434 2020-04-14 Fangrui Song <maskray@google.com>
435
436 PR gas/25768
437 * elf.c (assign_section_numbers): Always set .stab sh_entsize to
438 12.
439
440 2020-04-14 Stephen Casner <casner@acm.org>
441
442 PR ld/25677
443 * pdp11.c: Add implementation of --imagic option.
444 (adjust_o_magic): Fix objcopy --extract-symbol test.
445 * libaout.h (enum aout_magic): Add i_magic.
446
447 2020-04-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
448 Nick Clifton <nickc@redhat.com>
449
450 * elf32-sparc.c (sparc_final_write_processing): Fix whitespace.
451 <0>: Ignore.
452 <default>: Error rather than abort.
453
454 2020-04-03 H.J. Lu <hongjiu.lu@intel.com>
455
456 PR ld/25767
457 * elf.c (_bfd_elf_fixup_group_sections): Remove zero-sized
458 relocation section from section group.
459
460 2020-04-02 Jan W. Jagersma <jwjagersma@gmail.com>
461
462 * bfdio.c (bfd_bread, bfd_tell, bfd_seek, bfd_mmap): Always add
463 bfd->origin to file offset.
464 * bfdwin.c (bfd_get_file_window): Likewise.
465 * bfd.c: Clarify the use of the bfd->origin field.
466 * bfd-in2.h: Regenerate.
467 * coff-i386.c: Don't include go32exe.h. Allow overriding
468 coff_write_object_contents via COFF_WRITE_CONTENTS.
469 * coff-stgo32.c (go32exe_cleanup, go32exe_mkobject)
470 (go32exe_write_object_contents): New functions.
471 (go32exe_temp_stub, go32exe_temp_stub_size): New static globals.
472 (COFF_WRITE_CONTENTS, GO32EXE_DEFAULT_STUB_SIZE): Define.
473 (create_go32_stub): Remove check for 2k size limit. Read stub
474 from go32exe_temp_stub if present.
475 (go32_stubbed_coff_bfd_copy_private_bfd_data): Allocate and
476 copy variable-length stub.
477 (go32_check_format): Read stub to go32exe_temp_stub, set
478 origin, return go32exe_cleanup.
479 (adjust_filehdr_in_post, adjust_filehdr_out_pre)
480 (adjust_filehdr_out_post, adjust_scnhdr_in_post)
481 (adjust_scnhdr_out_pre, adjust_scnhdr_out_post)
482 (adjust_aux_in_post, adjust_aux_out_pre, adjust_aux_out_post):
483 Remove functions and their associated #defines.
484 * coffcode.h (coff_mkobject_hook): Remove stub copying code.
485 * libcoff-in.h: (struct coff_tdata): New field stub_size.
486 Rename field go32stub to stub.
487 * libcoff.h: Regenerate.
488 * coff-stgo32.c (go32_check_format): Rename to...
489 (go32exe_check_format): ...this.
490 (go32_stubbed_coff_bfd_copy_private_bfd_data): Rename to...
491 (go32exe_copy_private_bfd_data): ...this.
492 (stub_bytes): Rename to...
493 (go32exe_default_stub): ...this.
494 (create_go32_stub): Rename to...
495 (go32exe_create_stub): ...this.
496 * coff-stgo32.c (go32exe_copy_private_bfd_data): Avoid realloc
497 when possible.
498
499 2020-04-01 H.J. Lu <hongjiu.lu@intel.com>
500
501 PR ld/25749
502 PR ld/25754
503 * elf32-i386.c (elf_i386_convert_load_reloc): Convert load
504 relocation to R_386_32 for relocation against non-preemptible
505 absolute symbol.
506 (elf_i386_check_relocs): Call _bfd_elf_x86_valid_reloc_p. Don't
507 allocate dynamic relocation for non-preemptible absolute symbol.
508 (elf_i386_relocate_section): Pass sec to
509 GENERATE_DYNAMIC_RELOCATION_P.
510 * elf64-x86-64.c (R_X86_64_converted_reloc_bit): Moved.
511 (elf_x86_64_convert_load_reloc): Covert load relocation to
512 R_X86_64_32S or R_X86_64_32 for relocation against non-preemptible
513 absolute symbol. Don't convert to R_X86_64_32S nor R_X86_64_32
514 for non-preemptible absolute symbol if they overflow.
515 (elf_x86_64_check_relocs): Call _bfd_elf_x86_valid_reloc_p. Set
516 tls_type for GOT slot to GOT_ABS for non-preemptible absolute
517 symbol. Don't allocate dynamic relocation for non-preemptible
518 absolute symbol.
519 (elf_x86_64_relocate_section): Don't generate relative relocation
520 for GOTPCREL relocations aganst local absolute symbol. Pass sec
521 to GENERATE_DYNAMIC_RELOCATION_P.
522 * elfxx-x86.c (elf_x86_allocate_dynrelocs): No dynamic relocation
523 against non-preemptible absolute symbol.
524 (_bfd_elf_x86_valid_reloc_p): New function.
525 (_bfd_x86_elf_size_dynamic_sections): No dynamic relocation for
526 GOT_ABS GOT slot.
527 * elfxx-x86.h (GENERATE_DYNAMIC_RELOCATION_P): Add an SEC
528 argument. Don't generate dynamic relocation against
529 non-preemptible absolute symbol.
530 (ABS_SYMBOL_P): New.
531 (GENERATE_RELATIVE_RELOC_P): Don't generate relative relocation
532 against non-preemptible absolute symbol.
533 (GOT_ABS): New.
534 (R_X86_64_converted_reloc_bit): New. Moved from elf64-x86-64.c.
535 (_bfd_elf_x86_valid_reloc_p): New.
536
537 2020-04-01 Tamar Christina <tamar.christina@arm.com>
538
539 PR ld/16017
540 * elf32-arm.c (elf32_arm_populate_plt_entry): Set LSB of the PLT0
541 address in the GOT if in thumb only mode.
542
543 2020-04-01 Tamar Christina <tamar.christina@arm.com>
544
545 * elf32-arm.c (elf32_thumb2_plt_entry): Fix PC-rel offset.
546
547 2020-04-01 Hans-Peter Nilsson <hp@bitrange.com>
548
549 * mmo.c (mmo_scan): Create .text section only when needed, not
550 from the start.
551
552 2020-03-31 Alan Modra <amodra@gmail.com>
553
554 * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
555 return value check.
556
557 2020-03-31 Alan Modra <amodra@gmail.com>
558
559 * vms-alpha.c (image_write): Check bounds for sections without
560 contents too. Error on non-zero write to section without
561 contents.
562 (_bfd_vms_slurp_etir): Check return of image_write* functions.
563
564 2020-03-31 Alan Modra <amodra@gmail.com>
565
566 * tekhex.c (pass_over): Check is_eof before reading buffer.
567
568 2020-03-30 Nick Clifton <nickc@redhat.com>
569
570 PR binutils/pr25662
571 * libcoff-in.h (struct pe_tdata): Rename the insert_timestamp
572 field to timestamp and make it an integer.
573 * libcoff.h: Regenerate.
574 * peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Test the timestamp
575 field in the pe_data structure rather than the insert_timestamp
576 field.
577
578 2020-03-30 Alan Modra <amodra@gmail.com>
579
580 PR 25745
581 * elf64-ppc.c (ppc64_elf_build_stubs): Use asprintf to form
582 statistics message.
583
584 2020-03-26 Nick Clifton <nickc@redhat.com>
585
586 * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): Delete.
587 * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Remove
588 prototype.
589 * libbfd.h: Regenerate.
590
591 2020-03-26 Alan Modra <amodra@gmail.com>
592
593 * i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread.
594
595 2020-03-26 Alan Modra <amodra@gmail.com>
596
597 * vms-alpha.c (dst_define_location): Limit size of dst_ptr_offsets
598 array.
599 (_bfd_vms_slurp_object_records): Rename "err" to "ok".
600
601 2020-03-25 Nick Clifton <nickc@redhat.com>
602
603 * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): New
604 function.
605 * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Prototype.
606 * libbfd.h: Regenerate.
607
608 2020-03-25 Shahab Vahedi <shahab@synopsys.com>
609
610 * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
611 correct field name in the output string.
612
613 2020-03-25 Alan Modra <amodra@gmail.com>
614
615 PR 25662
616 * elf.c (assign_file_positions_for_load_sections): Adjust offset
617 for SHT_NOBITS section if first in segment.
618
619 2020-03-24 H.J. Lu <hongjiu.lu@intel.com>
620
621 PR binutils/25708
622 * elf-bfd.h (_bfd_elf_get_symbol_version_name): Renamed to ...
623 (_bfd_elf_get_symbol_version_string): This.
624 * elf.c (_bfd_elf_get_symbol_version_name): Renamed to ...
625 (_bfd_elf_get_symbol_version_string): This.
626 (bfd_elf_print_symbol): Pass TRUE to
627 _bfd_elf_get_symbol_version_string.
628 * libbfd-in.h (_bfd_nosymbols_get_symbol_version_string): Add a
629 bfd_boolean argument.
630 * syms.c (_bfd_nosymbols_get_symbol_version_string): Likewise.
631 * targets.c (_bfd_get_symbol_version_string): Likewise.
632 (bfd_get_symbol_version_string): Likewise.
633 * bfd-in2.h: Regenerated.
634
635 2020-03-24 Nick Clifton <nickc@redhat.com>
636 Jaydeep Chauhan <jaydeepchauhan1494@gmail.com>
637
638 PR 25713
639 * bfdio.c (_bfd_real_fopen): Add code to handle long filenames on
640 Win32 systems.
641
642 2020-03-24 Nick Clifton <nickc@redhat.com>
643
644 PR 25681
645 * elf.c (_bfd_elf_map_sections_to_segments): When looking for a
646 segment to use for PT_GNU_RELRO, ignore empty sections in a
647 segment's current list.
648
649 2020-03-24 H.J. Lu <hongjiu.lu@intel.com>
650
651 PR binutils/25717
652 * elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
653
654 2020-03-24 H.J. Lu <hongjiu.lu@intel.com>
655
656 PR binutils/25708
657 * elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
658 * elf.c (_bfd_elf_get_symbol_version_name): New function. Based
659 on the previous _bfd_elf_get_symbol_version_string.
660 (_bfd_elf_get_symbol_version_string): Use it.
661
662 2020-03-24 Alan Modra <amodra@gmail.com>
663
664 * archive.c (_bfd_generic_read_ar_hdr_mag): Sanity check extended
665 name size. Use bfd_malloc rather than bfd_zmalloc, clearing just
666 struct areltdata.
667
668 2020-03-23 Sebastian Huber <sebastian.huber@embedded-brains.de>
669
670 * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment.
671
672 2020-03-23 Alan Modra <amodra@gmail.com>
673
674 * ecoff.c (_bfd_ecoff_slurp_armap): Sanity check parsed_size and
675 symbol count. Allocate an extra byte to ensure name strings
676 are terminated. Sanity check name offsets. Release memory on
677 error return.
678
679 2020-03-23 Alan Modra <amodra@gmail.com>
680
681 * i386msdos.c (msdos_object_p): Don't access e_lfanew when that
682 field hasn't been read. Remove unnecessary casts.
683
684 2020-03-22 Alan Modra <amodra@gmail.com>
685
686 * coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large
687 enough to read number of symbols.
688
689 2020-03-20 H.J. Lu <hongjiu.lu@intel.com>
690
691 * configure.ac (HAVE_EXECUTABLE_SUFFIX): Removed.
692 (EXECUTABLE_SUFFIX): Likewise.
693 * config.in: Regenerated.
694 * configure: Likewise.
695 * plugin.c (bfd_plugin_close_and_cleanup): Defined as
696 _bfd_generic_close_and_cleanup.
697 (plugin_list_entry): Remove resolution_file, resolution_option,
698 real_bfd, real_nsyms, real_syms, lto_nsyms, lto_syms, gcc,
699 lto_wrapper, gcc_env and initialized,
700 (need_lto_wrapper_p): Removed.
701 (get_lto_wrapper): Likewise.
702 (setup_lto_wrapper_env): Likewise.
703 (register_all_symbols_read): Likewise.
704 (egister_cleanup): Likewise.
705 (get_symbols): Likewise.
706 (add_input_file): Likewise.
707 (bfd_plugin_set_program_name): Remove need_lto_wrapper.
708 (add_symbols): Updated.
709 (try_claim): Likewise.
710 (try_load_plugin): Likewise.
711 (bfd_plugin_canonicalize_symtab): Likewise.
712 * plugin.h (bfd_plugin_set_program_name): Remove int argument.
713 (plugin_data_struct): Remove real_bfd, real_nsyms and real_syms.
714
715 2020-03-19 H.J. Lu <hongjiu.lu@intel.com>
716
717 PR binutils/25640
718 * plugin.c (plugin_list_entry): Add has_symbol_type.
719 (add_symbols_v2): New function.
720 (bfd_plugin_open_input): Don't invoke LTO wrapper if LTO plugin
721 provides symbol type.
722 (try_load_plugin): Add LDPT_ADD_SYMBOLS_V2.
723 (bfd_plugin_canonicalize_symtab): Use LTO plugin symbol type if
724 available.
725
726 2020-03-20 Alan Modra <amodra@gmail.com>
727
728 * coff-rs6000.c (_bfd_xcoff_slurp_armap): Ensure size is large
729 enough to read number of symbols.
730
731 2020-03-20 Alan Modra <amodra@gmail.com>
732
733 * elf.c (_bfd_elf_setup_sections): Don't test known non-NULL
734 backend functions for NULL before calling.
735 (copy_special_section_fields, _bfd_elf_copy_private_bfd_data),
736 (bfd_section_from_shdr, assign_section_numbers): Likewise.
737 * elfcode.h (elf_write_relocs, elf_slurp_reloc_table): Likewise.
738 * elfnn-ia64.c (ignore_errors): New function.
739 (elf_backend_link_order_error_handler): Redefine as ignore_errors.
740
741 2020-03-19 Nick Clifton <nickc@redhat.com>
742
743 PR 25676
744 * dwarf2.c (struct varinfo): Add unit_offset field to record the
745 location of the varinfo in the unit's debug info data. Change the
746 type of the stack field to a boolean.
747 (lookup_var_by_offset): New function. Returns the varinfo
748 structure for the variable described at the given offset in the
749 unit's debug info.
750 (scan_unit_for_symbols): Add support for variables which have the
751 DW_AT_specification attribute.
752
753 2020-03-19 Nick Clifton <nickc@redhat.com>
754
755 PR 25699
756 * elf.c (bfd_elf_set_group_contents): Replace assertion with an
757 error return.
758
759 2020-03-19 Sebastian Huber <sebastian.huber@embedded-brains.de>
760
761 * elfxx-riscv.c (riscv_parse_subset): Don't use C99.
762
763 2020-03-18 Nick Clifton <nickc@redhat.com>
764
765 PR 25673
766 * elf.c (_bfd_elf_write_secondary_reloc_section): Fix illegal
767 memory access when processing a corrupt secondary reloc section.
768
769 2020-03-18 Christophe Lyon <christophe.lyon@linaro.org>
770
771 * elf32-arm.c (arm_build_one_stub): Emit a fatal error message
772 instead of calling abort.
773 * elf32-csky.c (csky_build_one_stub): Likewise.
774 * elf32-hppa.c (hppa_build_one_stub): Likewise.
775 * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
776 * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
777 * elf32-metag.c (metag_build_one_stub): Likewise.
778 * elf32-nios2.c (nios2_build_one_stub): Likewise.
779 * elf64-ppc.c (ppc_build_one_stub): Likewise.
780 (ppc_size_one_stub): Likewise.
781 * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
782
783 2020-03-17 Nick Clifton <nickc@redhat.com>
784
785 PR 25688
786 * elf.c (_bfd_elf_copy_special_section_fields): Replace assertions
787 with error messages.
788
789 2020-03-17 Nick Clifton <nickc@redhat.com>
790
791 PR 25687
792 * elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
793 free. Add free on another failure path.
794
795 2020-03-16 Alan Modra <amodra@gmail.com>
796
797 PR 25675
798 * elf.c (elf_sort_segments): Don't call bfd_octets_per_byte unless
799 we have a non-zero section count. Do lma comparison in octets.
800
801 2020-03-16 Alan Modra <amodra@gmail.com>
802
803 * vms-alpha.c (dst_restore_location): Validate index into
804 dst_ptr_offsets array before accessing. Return status.
805 (dst_retrieve_location): Similarly, making "loc" parameter a
806 pointer to return value.
807 (_bfd_vms_slurp_etir): Update calls to above functions.
808
809 2020-03-14 Kamil Rytarowski <n54@gmx.com>
810
811 * configure.ac: Include netbsd-core.lo for all NetBSD arm and mips
812 targets.
813 * configure: Regenerated.
814
815 2020-03-14 Alan Modra <amodra@gmail.com>
816
817 * section.c (BFD_FAKE_SECTIONS): Formatting.
818 * bfd-in2.h: Regenerate.
819
820 2020-03-13 Kamil Rytarowski <n54@gmx.com>
821
822 * elf.c (elfcore_grok_netbsd_note): Add support for
823 NT_NETBSDCORE_LWPSTATUS notes.
824
825 2020-03-13 Christophe Lyon <christophe.lyon@linaro.org>
826
827 * bfd-in2.h: Regenerate.
828 * section.c (asection): Add already_assigned field.
829 (BFD_FAKE_SECTION): Add default initializer for it.
830 * ecoff.c (bfd_debug_section): Initialize already_assigned field.
831 * elf32-arm.c (arm_build_one_stub): Add support for
832 non_contiguous_regions.
833 * elf32-csky.c (csky_build_one_stub): Likewise.
834 * elf32-hppa.c (hppa_build_one_stub): Likewise.
835 * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
836 * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
837 * elf32-metag.c (metag_build_one_stub): Likewise.
838 * elf32-nios2.c (nios2_build_one_stub): Likewise.
839 * elf64-ppc.c (ppc_build_one_stub): Likewise.
840 (ppc_size_one_stub): Likewise.
841 * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
842 * elflink.c (elf_link_input_bfd): Likewise.
843
844 2020-03-13 H.J. Lu <hongjiu.lu@intel.com>
845
846 PR ld/24920
847 * elf-linker-x86.h (elf_linker_x86_params): Add
848 static_before_all_inputs and has_dynamic_linker.
849 * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
850 dynamic input objects if -static is passed at command-line
851 before all input files without --dynamic-linker unless
852 --no-dynamic-linker is used.
853
854 2020-03-13 Kamil Rytarowski <n54@gmx.com>
855
856 * elf.c (elfcore_grok_netbsd_note): Add support for aarch64.
857
858 2020-03-13 Christian Eggers <ceggers@gmx.de>
859
860 * bfd.c (bfd_record_phdr): New local "opb". Fix assignment of
861 "p_paddr" from "at".
862 * elfcode.h (bfd_from_remote_memory): Add units to several
863 parameters. New local "opb". Fix usage of p_align. Fix
864 calculation of "localbase" from "ehdr_vma" and "p_vaddr". Fix
865 call of target_read_memory.
866 * elflink.c (elf_fixup_link_order): Fix scope of "s" local. Fix
867 calculation of "offset" and "output_offset".
868 (bfd_elf_final_link): New local "opb". Fix calculation of "size"
869 from "offset" and fix calculation of "end" from "vma+size". Fix
870 comparison between "sh_addr" and "vma"/"output_offset".
871 (bfd_elf_discard_info): Fix calculation of "eh_alignment".
872 * elf-bfd.h (struct elf_link_hash_table): Add unit to tls_size
873 member.
874 * elf.c (_bfd_elf_map_sections_to_segments): Add unit (bytes/
875 octets) to "wrap_to2 and "phdr_size" locals. Fix calculation of
876 "wrap_to" value. Add unit (bytes) to phdr_lma variable. Fix
877 assignment of p_paddr from phdr_lma. Fix comparison between
878 "lma+size" and "next->lma".
879 (elf_sort_segments): Fix assignment from p_paddr to lma.
880 (assign_file_positions_for_load_sections): Add unit (bytes) to
881 local "align". Fix calculation of local "off_adjust". Fix
882 calculation of local "filehdr_vaddr".
883 (assign_file_positions_for_non_load_sections): New local "opb".
884 Fix calculation of "end" from "p_size". Fix comparison between
885 "vma+SECTION_SIZE" and "start". Fix calculation of "p_memsz"
886 from "end" and "p_vaddr".
887 (rewrite_elf_program_header): Fix comparison between p_vaddr and
888 vma. Fix assignment to p_paddr from lma. Fix comparison between
889 p_paddr and lma. Fix assignment to p_paddr from lma.
890 * merge.c (sec_merge_emit): New local "opb". Convert
891 "alignment_power" to octets.
892 (_bfd_add_merge_section): New locals "alignment_power" and
893 "opb". Fix comparison between "alignment_power" and
894 "sizeof(align)".
895 (_bfd_merge_sections): New local "opb". Divide size by opb
896 before checking align mask.
897
898 2020-03-13 Christian Eggers <ceggers@gmx.de>
899
900 * elf.c (_bfd_elf_make_section_from_shdr): Introduce new temp
901 opb. Divide Elf_Internal_Shdr::sh_addr by opb when setting
902 section LMA/VMA.
903 (_bfd_elf_make_section_from_phdr): Similarly.
904 (elf_fake_sections): Fix calculation of
905 Elf_Internal_shdr::sh_addr from section VMA.
906 (_bfd_elf_map_sections_to_segments): Fix mixup between octets
907 and bytes.
908 (assign_file_positions_for_load_sections): Fix calculations of
909 Elf_Internal_shdr::p_vaddr and p_paddr from section LMA/VMA. Fix
910 comparison between program header address and section LMA.
911 (assign_file_positions_for_non_load_sections): Likewise.
912 (rewrite_elf_program_header): Likewise. Introduce new temp opb.
913 (IS_CONTAINED_BY_VMA): Add parameter opb.
914 (IS_CONTAINED_BY_LMA,IS_SECTION_IN_INPUT_SEGMENT,
915 INCLUDE_SECTION_IN_SEGMENT): Likewise.
916 (copy_elf_program_header): Update call to ELF_SECTION_IN_SEGMENT.
917 Fix calculations of p_addr_valid and p_vaddr_offset.
918 * elflink.c (elf_link_add_object_symbols): Multiply section VMA
919 with octets per byte when comparing against p_vaddr.
920
921 2020-03-11 Alan Modra <amodra@gmail.com>
922
923 * som.c (setup_sections): Sanity check subspace.name.
924
925 2020-03-11 Alan Modra <amodra@gmail.com>
926
927 * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
928
929 2020-03-10 Alan Modra <amodra@gmail.com>
930
931 PR 25648
932 * ihex.c (ihex_write_object_contents): Don't assume ordering of
933 addresses here.
934
935 2020-03-09 Alan Modra <amodra@gmail.com>
936
937 * wasm-module.c (wasm_scan): Sanity check file name length
938 before allocating memory. Move common section setup code. Do
939 without bfd_tell to calculate section size.
940
941 2020-03-06 Nick Clifton <nickc@redhat.com>
942
943 * elf.c (_bfd_elf_set_section_contents): Replace call to abort
944 with error messages and failure return values.
945
946 2020-03-05 Max Filippov <jcmvbkbc@gmail.com>
947
948 * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
949 relocation sections for any removed reference to a dynamic symbol.
950
951 2020-03-05 Nick Clifton <nickc@redhat.com>
952
953 * elf-bfd.h (struct elf_backend_data): Add new fields:
954 init_secondary_reloc_section, slurp_secondary_reloc_section,
955 write_secondary_reloc_section.
956 (_bfd_elf_init_secondary_reloc_section): Prototype.
957 (_bfd_elf_slurp_secondary_reloc_section): Prototype.
958 (_bfd_elf_write_secondary_reloc_section): Prototype.
959 * elf.c ( bfd_section_from_shdr): Invoke the new
960 init_secondary_reloc_section backend function, if defined, when a
961 second reloc section is encountered.
962 (swap_out_syms): Invoke the new symbol_section_index function, if
963 defined, when computing the section index of an OS/PROC specific
964 symbol.
965 (_bfd_elf_init_secondary_reloc_section): New function.
966 (_bfd_elf_slurp_secondary_reloc_section): New function.
967 (_bfd_elf_write_secondary_reloc_section): New function.
968 (_bfd_elf_copy_special_section_fields): New function.
969 * elfcode.h (elf_write_relocs): Invoke the new
970 write_secondary_relocs function, if defined, in order to emit
971 secondary relocs.
972 (elf_slurp_reloc_table): Invoke the new slurp_secondary_relocs
973 function, if defined, in order to read in secondary relocs.
974 * elfxx-target.h (elf_backend_copy_special_section_fields):
975 Provide a non-NULL default definition.
976 (elf_backend_init_secondary_reloc_section): Likewise.
977 (elf_backend_slurp_secondary_reloc_section): Likewise.
978 (elf_backend_write_secondary_reloc_section): Likewise.
979 (struct elf_backend_data elfNN_bed): Add initialisers for the new
980 fields.
981 * configure.ac (score_elf32_[bl]e_vec): Add elf64.lo
982 * configure: Regenerate.
983
984 2020-03-05 Alan Modra <amodra@gmail.com>
985
986 * archive64.c (_bfd_archive_64_bit_slurp_armap): Check parsed_size
987 against file size before allocating memory. Use bfd_alloc rather
988 than bfd_zalloc for carsym/strings memory.
989
990 2020-03-04 Alan Modra <amodra@gmail.com>
991
992 * elf.c (elf_fake_sections): Ensure sh_addralign is such that
993 sh_addr mod sh_addalign is zero.
994
995 2020-03-04 Alan Modra <amodra@gmail.com>
996
997 * format.c (bfd_check_format_matches): Call cleanup on error exit.
998
999 2020-03-03 Alan Modra <amodra@gmail.com>
1000
1001 * format.c (struct bfd_preserve): Add cleanup field.
1002 (bfd_preserve_save): Add cleanup param and save.
1003 (bfd_preserve_restore): Return cleanup.
1004 (bfd_preserve_finish): Call the cleanup for the discarded match.
1005 (bfd_check_format_matches): Pass cleanup to bfd_preserve_save,
1006 and clear when preserving a match. Restore cleanup too when
1007 restoring that match.
1008
1009 2020-03-02 Alan Modra <amodra@gmail.com>
1010
1011 * cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
1012 * hpux-core.c (hpux_core_core_file_p): Update prototype.
1013 * sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
1014 (core_sco5_vec): Correct initialisers.
1015
1016 2020-03-02 Alan Modra <amodra@gmail.com>
1017
1018 * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.
1019 * aix5ppc-core.c (xcoff64_core_p): Likewise.
1020 * cisco-core.c (cisco_core_file_validate): Likewise.
1021 * hppabsd-core.c (hppabsd_core_core_file_p): Likewise.
1022 * hpux-core.c (hpux_core_core_file_p): Likewise.
1023 * irix-core.c (irix_core_core_file_p): Likewise.
1024 * lynx-core.c (lynx_core_file_p): Likewise.
1025 * netbsd-core.c (netbsd_core_file_p): Likewise.
1026 * osf-core.c (osf_core_core_file_p): Likewise.
1027 * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
1028 * sco5-core.c (sco5_core_file_p): Likewise.
1029
1030 2020-03-02 H.J. Lu <hongjiu.lu@intel.com>
1031
1032 * trad-core.c (trad_unix_core_file_p): Return bfd_cleanup.
1033
1034 2020-03-02 Alan Modra <amodra@gmail.com>
1035
1036 * targets.c (bfd_cleanup): New typedef.
1037 (struct bfd <_bfd_check_format>): Return a bfd_cleanup.
1038 * libbfd-in.h (_bfd_no_cleanup): Define.
1039 * format.c (bfd_reinit): Add cleanup parameter, call it.
1040 (bfd_check_format_matches): Set cleanup from _bfd_check_format
1041 call and pass to bfd_reinit. Delete temp, use abfd->xvec instead.
1042 * aout-target.h (callback, object_p): Return bfd_cleanup.
1043 * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise.
1044 * archive.c (bfd_generic_archive_p): Likewise.
1045 * binary.c (binary_object_p): Likewise.
1046 * coff-alpha.c (alpha_ecoff_object_p): Likewise.
1047 * coff-ia64.c (ia64coff_object_p): Likewise.
1048 * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise.
1049 * coff-sh.c (coff_small_object_p): Likewise.
1050 * coff-stgo32.c (go32_check_format): Likewise.
1051 * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p),
1052 (xcoff64_core_p): Likewise.
1053 * coffgen.c (coff_real_object_p, coff_object_p): Likewise.
1054 * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p),
1055 (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise.
1056 * elfcode.h (elf_object_p): Likewise.
1057 * elfcore.h (elf_core_file_p): Likewise.
1058 * i386msdos.c (msdos_object_p): Likewise.
1059 * ihex.c (ihex_object_p): Likewise.
1060 * libaout.h (some_aout_object_p): Likewise.
1061 * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target),
1062 (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise.
1063 * libbfd.c (_bfd_dummy_target): Likewise.
1064 * libcoff-in.h (coff_object_p): Likewise.
1065 * mach-o-aarch64.c (bfd_mach_o_arm64_object_p),
1066 (bfd_mach_o_arm64_core_p): Likewise.
1067 * mach-o-arm.c (bfd_mach_o_arm_object_p),
1068 (bfd_mach_o_arm_core_p): Likewise.
1069 * mach-o-i386.c (bfd_mach_o_i386_object_p),
1070 (bfd_mach_o_i386_core_p): Likewise.
1071 * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p),
1072 (bfd_mach_o_x86_64_core_p): Likewise.
1073 * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p),
1074 (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise.
1075 * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p),
1076 (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise.
1077 * mmo.c (mmo_object_p): Likewise.
1078 * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
1079 * peicode.h (coff_real_object_p, pe_ILF_object_p),
1080 (pe_bfd_object_p): Likewise.
1081 * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise.
1082 * ppcboot.c (ppcboot_object_p): Likewise.
1083 * rs6000-core.c (rs6000coff_core_p): Likewise.
1084 * som.c (som_object_setup, som_object_p): Likewise.
1085 * srec.c (srec_object_p, symbolsrec_object_p): Likewise.
1086 * tekhex.c (tekhex_object_p): Likewise.
1087 * vms-alpha.c (alpha_vms_object_p): Likewise.
1088 * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p),
1089 (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise.
1090 * wasm-module.c (wasm_object_p): Likewise.
1091 * xsym.c (bfd_sym_object_p): Likewise.
1092 * xsym.h (bfd_sym_object_p): Likewise.
1093 * aoutx.h (some_aout_object_p): Likewise, and callback parameter
1094 return type.
1095 * pdp11.c (some_aout_object_p): Likewise.
1096 * plugin.c (register_ld_plugin_object_p): Update object_p
1097 parameter type.
1098 * plugin.h (register_ld_plugin_object_p): Likewise.
1099 * bfd-in2.h: Regenerate.
1100 * libbfd.h: Regenerate.
1101 * libcoff.h: Regenerate.
1102
1103 2020-03-02 Alan Modra <amodra@gmail.com>
1104
1105 * coff-alpha.c (alpha_ecoff_le_vec): Add SEC_SMALL_DATA to
1106 applicable section flags.
1107 * coff-mips.c (mips_ecoff_le_vec, mips_ecoff_be_vec): Likewise.
1108 (mips_ecoff_bele_vec): Likewise.
1109 * coffcode.h (sec_to_styp_flags): Set SEC_SMALL_DATA for .sdata
1110 and .sbss sections.
1111 * ecoff.c (_bfd_ecoff_new_section_hook): Likewise.
1112 (_bfd_ecoff_styp_to_sec_flags): Likewise.
1113
1114 2020-03-02 Alan Modra <amodra@gmail.com>
1115
1116 * elf32-m32r.c (m32r_elf_section_flags): New function.
1117 (elf_backend_section_flags): Define.
1118 * elf32-nds32.c (nds32_elf_section_flags): New function.
1119 (elf_backend_section_flags): Define.
1120 * elf32-ppc.c (ppc_elf_section_from_shdr): Set SEC_SMALL_DATA for
1121 .sbss and .sdata sections.
1122 * elf32-v850.c (v850_elf_section_from_shdr): Set SEC_SMALL_DATA
1123 for SHF_V850_GPREL sections.
1124 * elf64-alpha.c (elf64_alpha_section_from_shdr): Delete outdated
1125 FIXME.
1126 * elf64-hppa.c (elf64_hppa_section_from_shdr): Set SEC_SMALL_DATA
1127 for SHF_PARISC_SHORT sections.
1128 * elf64-ppc.c (ppc64_elf_section_flags): New function.
1129 (elf_backend_section_flags): Define.
1130 * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Set SEC_SMALL_DATA
1131 for SHF_MIPS_GPREL sections. Delete FIXME.
1132
1133 2020-03-02 Alan Modra <amodra@gmail.com>
1134
1135 * elf-bfd.h (elf_backend_section_flags): Remove flagword* param.
1136 * elf.c (_bfd_elf_make_section_from_shdr): Set section flags before
1137 calling elf_backend_section_flags with adjusted params. Use
1138 newsect->flags past that point.
1139 (_bfd_elf_new_section_hook): Always set sh_type and sh_flags for
1140 special sections.
1141 (_bfd_elf_init_private_section_data): Allow normal sh_type sections
1142 to have their type overridden, and all sh_flags but processor and
1143 os specific.
1144 * elf32-arm.c (elf32_arm_section_flags): Adjust for changed params.
1145 * elf32-mep.c (mep_elf_section_flags): Likewise.
1146 * elf32-nios2.c (nios2_elf32_section_flags): Likewise.
1147 * elf64-alpha.c (elf64_alpha_section_flags): Likewise.
1148 * elf64-ia64-vms.c (elf64_ia64_section_flags): Likewise.
1149 * elfnn-ia64.c (elfNN_ia64_section_flags): Likewise.
1150 * elfnn-aarch64.c (elfNN_aarch64_size_stubs): Exclude the linker
1151 stub BFD and non-aarch64 input files when scanning for stubs.
1152
1153 2020-03-02 Alan Modra <amodra@gmail.com>
1154
1155 * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
1156 limit to decompressed element size.
1157
1158 2020-03-02 Alan Modra <amodra@gmail.com>
1159
1160 * vms-lib.c (vms_traverse_index): Add recur_count param and
1161 update calls. Fail on excessive recursion.
1162
1163 2020-03-02 Alan Modra <amodra@gmail.com>
1164
1165 * vms-alpha.c (vms_get_remaining_object_record): Use
1166 bfd_realloc_or_free rather than bfd_realloc.
1167 (add_symbol_entry, vector_grow1, alpha_vms_slurp_relocs): Likewise.
1168 (dst_define_location, parse_module): Likewise, and check realloc
1169 return status before using memory. Return status from function
1170 adjusting all callers.
1171
1172 2020-02-28 Alan Modra <amodra@gmail.com>
1173
1174 * vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
1175
1176 2020-02-28 Alan Modra <amodra@gmail.com>
1177
1178 * vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.
1179 Remove duplicate undersize check.
1180
1181 2020-02-27 Alan Modra <amodra@gmail.com>
1182
1183 PR 24511
1184 * mmo.c (mmo_scan): Set SEC_DATA for .data.
1185
1186 2020-02-27 Alan Modra <amodra@gmail.com>
1187
1188 PR 24511
1189 * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
1190 (coff_section_type): Adjust comment.
1191 (decode_section_type): Likewise. Call coff_section_type before
1192 decode_section_type.
1193 (bfd_decode_symclass): Use 'c' for common sections other than
1194 the standard one.
1195
1196 2020-02-27 Alan Modra <amodra@gmail.com>
1197
1198 * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Put all data in one
1199 malloc'd block.
1200
1201 2020-02-27 Alan Modra <amodra@gmail.com>
1202
1203 * bfd.c (bfd_stat_arch_elt): Use vector of containing archive,
1204 if file is an archive element.
1205 * bfd-in2.h: Regenerate.
1206
1207 2020-02-26 Alan Modra <amodra@gmail.com>
1208
1209 * archive.c (do_slurp_bsd_armap): Increase minimum parsed_size, and
1210 bfd_set_error on failing test. Don't bother changing bfd_error on
1211 file read error. Check symdef_count is multiple of BSD_SYMDEF_SIZE.
1212 Check sym name is within string buffer. Use size_t for some vars.
1213 (do_slurp_coff_armap): Use size_t for some variables, fix size of
1214 int_buf. Don't change bfd_error on file read error. Use
1215 _bfd_mul_overflow when calculating carsym buffer size. Reorder
1216 calculations to catch overflows before they occur. malloc and
1217 free raw armap rather than using bfd_alloc. Read raw armap before
1218 allocating carsym+strings buffer.
1219 (_bfd_slurp_extended_name_table): Localize variables. Check
1220 name size against file size.
1221
1222 2020-02-26 Alan Modra <amodra@gmail.com>
1223
1224 * vms-lib.c (vms_lib_read_index): Release correct buffer.
1225
1226 2020-02-26 Alan Modra <amodra@gmail.com>
1227
1228 * elf32-rx.c (rx_elf_relocate_section): Use bfd_malloc rather than
1229 malloc. Check for NULL return from bfd_malloc.
1230 (rx_table_find, rx_table_map): Likewise.
1231 (rx_set_section_contents): Check bfd_alloc return.
1232 (rx_dump_symtab): Don't alloc internal_syms or external_syms.
1233
1234 2020-02-26 Alan Modra <amodra@gmail.com>
1235
1236 * aoutx.h: Indent labels correctly. Format error strings.
1237 * archive.c: Likewise.
1238 * archive64.c: Likewise.
1239 * coff-arm.c: Likewise.
1240 * coff-rs6000.c: Likewise.
1241 * coff-stgo32.c: Likewise.
1242 * cpu-arm.c: Likewise.
1243 * dwarf2.c: Likewise.
1244 * elf-ifunc.c: Likewise.
1245 * elf-properties.c: Likewise.
1246 * elf-s390-common.c: Likewise.
1247 * elf-strtab.c: Likewise.
1248 * elf.c: Likewise.
1249 * elf32-arm.c: Likewise.
1250 * elf32-bfin.c: Likewise.
1251 * elf32-cr16.c: Likewise.
1252 * elf32-csky.c: Likewise.
1253 * elf32-i386.c: Likewise.
1254 * elf32-m68k.c: Likewise.
1255 * elf32-msp430.c: Likewise.
1256 * elf32-nds32.c: Likewise.
1257 * elf32-nios2.c: Likewise.
1258 * elf32-pru.c: Likewise.
1259 * elf32-xtensa.c: Likewise.
1260 * elf64-ia64-vms.c: Likewise.
1261 * elf64-x86-64.c: Likewise.
1262 * elfcode.h: Likewise.
1263 * elfcore.h: Likewise.
1264 * elflink.c: Likewise.
1265 * elfnn-aarch64.c: Likewise.
1266 * elfnn-ia64.c: Likewise.
1267 * elfnn-riscv.c: Likewise.
1268 * elfxx-mips.c: Likewise.
1269 * elfxx-sparc.c: Likewise.
1270 * elfxx-x86.c: Likewise.
1271 * i386lynx.c: Likewise.
1272 * merge.c: Likewise.
1273 * pdp11.c: Likewise.
1274 * plugin.c: Likewise.
1275 * reloc.c: Likewise.
1276
1277 2020-02-26 Alan Modra <amodra@gmail.com>
1278
1279 PR 25593
1280 * elf-bfd.h (struct elf_link_hash_table): Rename "loaded" to
1281 "dyn_loaded".
1282 (bfd_elf_add_dt_needed_tag): Declare.
1283 * elf-strtab.c (_bfd_elf_strtab_restore): Handle NULL buf.
1284 * elflink.c (bfd_elf_add_dt_needed_tag): Make global and rename
1285 from elf_add_dt_needed_tag. Remove soname and doit param.
1286 (elf_link_add_object_symbols): Don't use elf_add_dt_needed_tag
1287 to see whether as-needed lib is already loaded, use dyn_loaded
1288 list instead. When saving and restoring around as-needed lib
1289 handle possibility that dynstr has not been initialised. Don't
1290 add DT_NEEDED tags here. Limit dyn_loaded list to dynamic libs.
1291 Mark libs loaded via DT_NEEDED entries of other libs with
1292 DYN_NO_NEEDED if they should not be mentioned in DT_NEEDED of
1293 the output.
1294 (elf_link_check_versioned_symbol): Remove now unneccesary
1295 DYNAMIC check when traversing dyn_loaded list.
1296
1297 2020-02-26 Alan Modra <amodra@gmail.com>
1298
1299 * bfdio.c (bfd_get_file_size): Ignore bogus archive element sizes.
1300
1301 2020-02-25 H.J. Lu <hongjiu.lu@intel.com>
1302
1303 PR binutils/25584
1304 * plugin.c (need_lto_wrapper_p): New.
1305 (bfd_plugin_set_program_name): Add an int argument to set
1306 need_lto_wrapper_p.
1307 (get_lto_wrapper): Return FALSE if need_lto_wrapper_p isn't
1308 set.
1309 * plugin.h (bfd_plugin_set_program_name): Add an int argument.
1310
1311 2020-02-24 Alan Modra <amodra@gmail.com>
1312
1313 * vms-lib.c (_bfd_vms_lib_archive_p): Correct overflow checks.
1314
1315 2020-02-24 Alan Modra <amodra@gmail.com>
1316
1317 * vms-lib.c (struct carsym_mem): Add limit.
1318 (vms_add_index): Heed limit.
1319 (vms_traverse_index): Catch buffer overflows. Remove outdated fixme.
1320 (vms_lib_read_index): Set up limit. Catch 32-bit overflow.
1321 Always return actual number read.
1322 (_bfd_vms_lib_archive_p): Catch buffer overflows. Replace
1323 assertion with error exit.
1324
1325 2020-02-22 Alan Modra <amodra@gmail.com>
1326
1327 PR 25585
1328 * elf.c (assign_file_positions_for_load_sections): Continue linking
1329 on "PHDR segment not covered by LOAD segment" errors.
1330
1331 2020-02-21 Alan Modra <amodra@gmail.com>
1332
1333 * mach-o.c (bfd_mach_o_canonicalize_relocs): Fix ineffective
1334 overflow check.
1335 (bfd_mach_o_canonicalize_reloc): Likewise.
1336 (bfd_mach_o_canonicalize_dynamic_reloc): Likewise. Sanity check
1337 counts and offsets against file size.
1338 (bfd_mach_o_build_dysymtab): Fix ineffective overflow check.
1339 (bfd_mach_o_mangle_sections): Remove unnecessary overflow check.
1340 (bfd_mach_o_read_symtab_symbols): Sanity check count and offset
1341 against file size. Delete symbol table error message.
1342 (bfd_mach_o_read_dysymtab): Sanity check counts and offsets
1343 against file size.
1344 (bfd_mach_o_read_symtab): Likewise.
1345 (bfd_mach_o_read_command): Pass file size.
1346 (bfd_mach_o_scan): Sanity check command count against file size.
1347
1348 2020-02-21 Alan Modra <amodra@gmail.com>
1349
1350 PR 25569
1351 * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
1352 "text", "data" and "bss" section pointer vars. Don't update
1353 section size, just exec header sizes.
1354 (adjust_sizes_and_vmas): Don't update text section size. Set
1355 initial exec header a_text. Print exec headers sizes.
1356 * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
1357 (adjust_sizes_and_vmas): Similarly. Formatting.
1358 (final_link): Correct final file extension.
1359
1360 2020-02-20 Nick Clifton <nickc@redhat.com>
1361
1362 * elf-bfd.h (struct elf_backend_data): Add symbol_section_index
1363 callback.
1364 * elfxx-target.h (elf_backend_symbol_section_index): Provide
1365 default definition.
1366 (elfNN_bed): Initialise the symbol_section_index field.
1367 * elf.c (swap_out_syms): Call symbol_section_index, if defined, on
1368 OS and PROC specific section indicies. Warn if converting other
1369 reserved incidies to SHN_ABS.
1370
1371 2020-02-19 Sergey Belyashov <sergey.belyashov@gmail.com>
1372
1373 PR 25537
1374 * cpu-z80.c: Add machine type compatibility checking.
1375
1376 2020-02-19 H.J. Lu <hongjiu.lu@intel.com>
1377
1378 PR binutils/25355
1379 * plugin.c (plugin_list_entry): Remove handle.
1380 (try_load_plugin): Call dlclose before return.
1381
1382 2020-02-19 Alan Modra <amodra@gmail.com>
1383
1384 * libbfd-in.h (_bfd_constant_p): Define.
1385 (_bfd_alloc_and_read, _bfd_malloc_and_read): Check read size against
1386 file size before allocating memory.
1387 * coffgen.c (_bfd_coff_get_external_symbols): Remove file size check.
1388 * elf.c (bfd_elf_get_str_section): Likewise.
1389 (_bfd_elf_slurp_version_tables): Likewise.
1390 * libbfd.h: Regenerate.
1391
1392 2020-02-19 Alan Modra <amodra@gmail.com>
1393
1394 * libbfd-in.h (_bfd_alloc_and_read, _bfd_malloc_and_read): New.
1395 * aoutx.h (aout_get_external_symbols): Replace calls to
1396 bfd_[m]alloc and bfd_bread with call to _bfd_[m]alloc_and_read.
1397 (slurp_reloc_table): Likewise.
1398 * archive.c (do_slurp_bsd_armap): Likewise.
1399 (do_slurp_coff_armap): Likewise.
1400 * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
1401 * coff-rs6000.c (_bfd_xcoff_slurp_armap): Likewise.
1402 * coff64-rs6000.c (xcoff64_slurp_armap): Likewise.
1403 * coffcode.h (coff_set_arch_mach_hook, buy_and_read): Likewise.
1404 * coffgen.c (coff_real_object_p, coff_object_p, build_debug_section),
1405 (_bfd_coff_get_external_symbols): Likewise.
1406 * ecoff.c (ecoff_slurp_symbolic_header),
1407 (_bfd_ecoff_slurp_symbolic_info, ecoff_slurp_reloc_table),
1408 (_bfd_ecoff_slurp_armap, ecoff_link_add_object_symbols, READ),
1409 (ecoff_indirect_link_order): Likewise.
1410 * elf.c (bfd_elf_get_str_section, setup_group, elf_read_notes),
1411 (_bfd_elf_slurp_version_tables): Likewise.
1412 * elf32-m32c.c (m32c_elf_relax_section): Likewise.
1413 * elf32-rl78.c (rl78_elf_relax_section): Likewise.
1414 * elf32-rx.c (elf32_rx_relax_section): Likewise.
1415 * elf64-alpha.c (READ): Likewise.
1416 * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Likewise.
1417 * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
1418 * elfcode.h (elf_slurp_symbol_table),
1419 (elf_slurp_reloc_table_from_section): Likewise.
1420 * elflink.c (elf_link_add_object_symbols),
1421 (elf_link_check_versioned_symbol): Likewise.
1422 * elfxx-mips.c (READ): Likewise.
1423 * i386lynx.c (slurp_reloc_table): Likewise.
1424 * lynx-core.c (lynx_core_file_p): Likewise.
1425 * mach-o.c (bfd_mach_o_canonicalize_relocs),
1426 (bfd_mach_o_read_symtab_strtab, bfd_mach_o_alloc_and_read),
1427 (bfd_mach_o_read_prebound_dylib, bfd_mach_o_read_dyld_content
1428 * pdp11.c (aout_get_external_symbols, slurp_reloc_table
1429 * pef.c (bfd_pef_print_loader_section, bfd_pef_scan_start_address),
1430 (bfd_pef_parse_symbols): Likewise.
1431 * peicode.h (pe_ILF_object_p, pe_bfd_object_p
1432 * som.c (setup_sections, som_slurp_string_table),
1433 (som_slurp_reloc_table, som_bfd_count_ar_symbols),
1434 (som_bfd_fill_in_ar_symbols): Likewise.
1435 * vms-alpha.c (module_find_nearest_line, evax_bfd_print_dst),
1436 (evax_bfd_print_image): Likewise.
1437 * vms-lib.c (_bfd_vms_lib_archive_p): Likewise.
1438 * wasm-module.c (wasm_scan): Likewise.
1439 * xcofflink.c (xcoff_link_add_symbols): Likewise.
1440 * xsym.c (bfd_sym_read_name_table),
1441 (bfd_sym_print_type_information_table_entry): Likewise.
1442 * libbfd.h: Regenerate.
1443
1444 2020-02-19 Alan Modra <amodra@gmail.com>
1445
1446 * aoutx.h (slurp_reloc_table): Allocate reloc_cache after
1447 reading external relocs.
1448 * ecoff.c (ecoff_slurp_reloc_table): Likewise.
1449 * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error
1450 after bfd_bread.
1451 * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary
1452 bfd_release.
1453 * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*.
1454 (m32c_elf_relax_section): Likewise.
1455 * elf32-rl78.c (rl78_offset_for_reloc): Likewise.
1456 (rl78_elf_relax_section): Likewise.
1457 * elf32-rx.c (rx_offset_for_reloc): Likewise.
1458 (elf32_rx_relax_section): Likewise.
1459 * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better
1460 parameter types and use..
1461 (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib),
1462 (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions.
1463 * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr
1464 being read from file, just the extra.
1465 * som.c (som_slurp_symbol_table): Allocate internal symbol buffer
1466 after reading external syms. Free on failure.
1467
1468 2020-02-19 Alan Modra <amodra@gmail.com>
1469
1470 * coffcode.h (buy_and_read, coff_slurp_line_table),
1471 (coff_slurp_symbol_table, coff_slurp_reloc_table): Replace
1472 bfd_[z][m]alloc2 calls with _bfd_mul_overflow followed by the
1473 corresponding bfd_alloc call. Adjust variables to suit.
1474 * coffgen.c (_bfd_coff_get_external_symbols): Likewise.
1475 * ecoff.c (_bfd_ecoff_slurp_symbolic_info),
1476 (_bfd_ecoff_slurp_symbol_table, READ): Likewise.
1477 * elf.c (bfd_elf_get_elf_syms, setup_group, bfd_section_from_shdr),
1478 (swap_out_syms, _bfd_elf_slurp_version_tables): Likewise.
1479 * elf32-m32c.c (m32c_elf_relax_section): Likewise.
1480 * elf32-rl78.c (rl78_elf_relax_section): Likewise.
1481 * elf32-rx.c (elf32_rx_relax_section): Likewise.
1482 * elf64-alpha.c (READ): Likewise.
1483 * elfcode.h (elf_object_p, elf_write_relocs, elf_write_shdrs_and_ehdr),
1484 (elf_slurp_symbol_table, elf_slurp_reloc_table),
1485 (bfd_from_remote_memory): Likewise.
1486 * elfcore.h (core_find_build_id): Likewise.
1487 * elfxx-mips.c (READ): Likewise.
1488 * mach-o.c (bfd_mach_o_mangle_sections),
1489 (bfd_mach_o_read_symtab_symbols, bfd_mach_o_read_thread),
1490 (bfd_mach_o_read_dysymtab, bfd_mach_o_flatten_sections),
1491 (bfd_mach_o_scan, bfd_mach_o_fat_archive_p): Likewise.
1492 * som.c (setup_sections, som_prep_for_fixups)
1493 (som_build_and_write_symbol_table, som_slurp_symbol_table),
1494 (som_slurp_reloc_table, som_bfd_count_ar_symbols),
1495 (som_bfd_fill_in_ar_symbols, som_slurp_armap),
1496 (som_bfd_ar_write_symbol_stuff): Likewise.
1497 * vms-alpha.c (vector_grow1): Likewise.
1498 * vms-lib.c (vms_add_index): Likewise.
1499 * wasm-module.c (wasm_scan_name_function_section): Likewise.
1500 * libbfd.c (bfd_malloc2, bfd_realloc2, bfd_zmalloc2): Delete.
1501 * opncls.c (bfd_alloc2, bfd_zalloc2): Delete.
1502 * libbfd-in.h (bfd_malloc2, bfd_realloc2, bfd_zmalloc2),
1503 (bfd_alloc2, bfd_zalloc2): Delete.
1504 (_bfd_mul_overflow): Define.
1505 * libbfd.h: Regenerate.
1506
1507 2020-02-19 Alan Modra <amodra@gmail.com>
1508
1509 * elf.c (bfd_section_from_shdr): Use bfd_zalloc rather than
1510 bfd_zalloc2.
1511 (assign_section_numbers): Likewise.
1512 (elf_map_symbols): Likewise, and bfd_alloc rather than bfd_alloc2.
1513 (_bfd_elf_map_sections_to_segments): Use bfd_malloc rather than
1514 bfd_malloc2, size_t amt, and unsigned tls_count.
1515 (rewrite_elf_program_header): Use bfd_malloc and size_t amt.
1516 * elflink.c (elf_create_symbuf): Use bfd_malloc.
1517 (elf_output_implib): Use bfd_alloc.
1518
1519 2020-02-19 Alan Modra <amodra@gmail.com>
1520
1521 * bfd.c (struct bfd): Move format and direction to other
1522 bitfields. Add "size".
1523 * bfdio.c (bfd_get_size): Cache size when not writing file.
1524 * opncls.c (bfd_get_debug_link_info_1): Allow for bfd_get_size
1525 returning zero, ie. unknown.
1526 (bfd_get_alt_debug_link_info): Likewise.
1527 * bfd-in2.h: Regenerate.
1528
1529 2020-02-19 Alan Modra <amodra@gmail.com>
1530
1531 * coffgen.c (_bfd_coff_get_external_symbols): Don't call
1532 bfd_get_file_size twice.
1533 (_bfd_coff_read_string_table): Allow for bfd_get_file_size
1534 zero, ie. unknown, return.
1535 * elf-attrs.c (_bfd_elf_parse_attributes): Likewise.
1536 * elfcode.h (elf_swap_shdr_in): Likewise.
1537 (elf_object_p): Don't call bfd_get_file_size twice and correct
1538 file size check.
1539
1540 2020-02-19 Alan Modra <amodra@gmail.com>
1541
1542 * mach-o.c (bfd_mach_o_flatten_sections): Return a bfd_boolean,
1543 FALSE if memory alloc fails. Adjust calls.
1544 * som.c (som_prep_for_fixups): Likewise.
1545 * vms-alpha.c (alpha_vms_add_fixup_lp, alpha_vms_add_fixup_ca),
1546 (alpha_vms_add_fixup_qr, alpha_vms_add_fixup_lr),
1547 (alpha_vms_add_lw_reloc, alpha_vms_add_qw_reloc): Likewise.
1548 * som.c (som_build_and_write_symbol_table): Return via error_return
1549 on seek failure.
1550 * vms-alpha.c (VEC_APPEND): Adjust for vector_grow1 changes.
1551 (VEC_APPEND_EL): Delete.
1552 (vector_grow1): Return pointer to element. Catch overflow.
1553 Return NULL on memory allocation failure.
1554 (alpha_vms_add_fixup_lp): Replace VEC_APPEND_EL with VEC_APPEND.
1555 (alpha_vms_add_fixup_ca): Likewise.
1556 (alpha_vms_link_add_object_symbols): Check VEC_APPEND result
1557 before using.
1558 * elf.c (bfd_section_from_shdr): Check bfd_zalloc2 result.
1559
1560 2020-02-19 Alan Modra <amodra@gmail.com>
1561
1562 * aix386-core.c (aix386_core_file_p): Use size_t for "amt".
1563 * aout-target.h (object_p): Likewise.
1564 * aout-tic30.c (tic30_aout_object_p): Likewise.
1565 * aoutx.h (some_aout_object_p, mkobject, make_empty_symbol),
1566 (emit_stringtab, write_syms, link_hash_table_create),
1567 (aout_link_write_other_symbol): Likewise.
1568 * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p),
1569 (bfd_ar_hdr_from_filesystem, _bfd_write_archive_contents),
1570 (_bfd_compute_and_write_armap): Likewise.
1571 * archures.c (bfd_arch_list): Likewise.
1572 * bfd.c (bfd_record_phdr): Likewise.
1573 * binary.c (binary_canonicalize_symtab): Likewise.
1574 * cisco-core.c (cisco_core_file_validate): Likewise.
1575 * coff-arm.c (coff_arm_link_hash_table_create, find_thumb_glue),
1576 (find_arm_glue, record_arm_to_thumb_glue),
1577 (record_thumb_to_arm_glue): Likewise.
1578 * coff-ppc.c (ppc_coff_link_hash_table_create, record_toc),
1579 (ppc_allocate_toc_section): Likewise.
1580 * coff-rs6000.c (_bfd_xcoff_mkobject, _bfd_xcoff_archive_p): Likewise.
1581 * coff-sh.c (sh_relax_section): Likewise.
1582 * coff64-rs6000.c (xcoff64_archive_p): Likewise.
1583 * coffcode.h (handle_COMDAT, coff_new_section_hook),
1584 (coff_set_alignment_hook, coff_mkobject),
1585 (coff_compute_section_file_positions): Likewise.
1586 * coffgen.c (coff_make_empty_symbol, coff_bfd_make_debug_symbol),
1587 (coff_find_nearest_line_with_names),
1588 ( bfd_coff_set_symbol_class): Likewise.
1589 * cofflink.c (_bfd_coff_link_hash_table_create),
1590 (_bfd_coff_link_input_bfd): Likewise.
1591 * dwarf1.c (alloc_dwarf1_unit, alloc_dwarf1_func): Likewise.
1592 * dwarf2.c (read_abbrevs, read_attribute_value, add_line_info),
1593 (build_line_info_table, sort_line_sequences),
1594 (line_info_add_include_dir, line_info_add_file_name),
1595 (decode_line_info, scan_unit_for_symbols, parse_comp_unit),
1596 (place_sections, _bfd_dwarf2_slurp_debug_info): Likewise.
1597 * ecoff.c (_bfd_ecoff_mkobject, _bfd_ecoff_make_empty_symbol),
1598 (_bfd_ecoff_find_nearest_line),
1599 (_bfd_ecoff_bfd_link_hash_table_create): Likewise.
1600 * ecofflink.c (bfd_ecoff_debug_init): Likewise.
1601 * elf-hppa.h (_bfd_elf_hppa_gen_reloc_type): Likewise.
1602 * elf-m10300.c (mn10300_elf_relax_section),
1603 (elf32_mn10300_link_hash_table_create): Likewise.
1604 * elf-strtab.c (_bfd_elf_strtab_init): Likewise.
1605 * elf.c (make_mapping, copy_elf_program_header): Likewise.
1606 * elf32-arm.c (elf32_arm_link_hash_table_create),
1607 (elf32_arm_setup_section_lists, elf32_arm_check_relocs),
1608 (elf32_arm_new_section_hook): Likewise.
1609 * elf32-avr.c (elf_avr_new_section_hook),
1610 (elf32_avr_link_hash_table_create, get_local_syms),
1611 (elf32_avr_setup_section_lists): Likewise.
1612 * elf32-bfin.c (bfinfdpic_elf_link_hash_table_create),
1613 (bfin_link_hash_table_create): Likewise.
1614 * elf32-cr16.c (elf32_cr16_link_hash_table_create): Likewise.
1615 * elf32-cris.c (elf_cris_link_hash_table_create): Likewise.
1616 * elf32-csky.c (csky_elf_link_hash_table_create),
1617 (csky_elf_check_relocs, elf32_csky_setup_section_lists): Likewise.
1618 * elf32-frv.c (frvfdpic_elf_link_hash_table_create): Likewise.
1619 * elf32-hppa.c (elf32_hppa_link_hash_table_create),
1620 (elf32_hppa_setup_section_lists, get_local_syms): Likewise.
1621 * elf32-i386.c (elf_i386_check_relocs): Likewise.
1622 * elf32-lm32.c (lm32_elf_link_hash_table_create): Likewise.
1623 * elf32-m32r.c (m32r_elf_link_hash_table_create),
1624 (m32r_elf_check_relocs): Likewise.
1625 * elf32-m68hc1x.c (m68hc11_elf_hash_table_create),
1626 (elf32_m68hc11_setup_section_lists),
1627 (elf32_m68hc11_size_stubs): Likewise.
1628 * elf32-m68k.c (elf_m68k_link_hash_table_create): Likewise.
1629 * elf32-metag.c (elf_metag_link_hash_table_create),
1630 (elf_metag_setup_section_lists): Likewise.
1631 * elf32-microblaze.c (microblaze_elf_link_hash_table_create),
1632 (microblaze_elf_check_relocs): Likewise.
1633 * elf32-nds32.c (nds32_elf_link_hash_table_create),
1634 (nds32_elf_check_relocs): Likewise.
1635 * elf32-nios2.c (nios2_elf32_setup_section_lists),
1636 (get_local_syms, nios2_elf32_check_relocs),
1637 (nios2_elf32_link_hash_table_create): Likewise.
1638 * elf32-or1k.c (or1k_elf_link_hash_table_create),
1639 (or1k_elf_check_relocs): Likewise.
1640 * elf32-ppc.c (ppc_elf_modify_segment_map, update_plt_info): Likewise.
1641 * elf32-pru.c (pru_elf32_link_hash_table_create): Likewise.
1642 * elf32-s390.c (elf_s390_link_hash_table_create),
1643 (elf_s390_check_relocs): Likewise.
1644 * elf32-score.c (score_elf_create_got_section),
1645 (s3_elf32_score_new_section_hook),
1646 (elf32_score_link_hash_table_create): Likewise.
1647 * elf32-score7.c (score_elf_create_got_section),
1648 (s7_elf32_score_new_section_hook): Likewise.
1649 * elf32-sh.c (sh_elf_link_hash_table_create),
1650 (sh_elf_check_relocs): Likewise.
1651 * elf32-tic6x.c (elf32_tic6x_link_hash_table_create),
1652 (elf32_tic6x_new_section_hook, elf32_tic6x_check_relocs): Likewise.
1653 * elf32-tilepro.c (tilepro_elf_link_hash_table_create),
1654 (tilepro_elf_check_relocs): Likewise.
1655 * elf32-v850.c (remember_hi16s_reloc): Likewise.
1656 * elf32-vax.c (elf_vax_link_hash_table_create): Likewise.
1657 * elf32-xtensa.c (elf_xtensa_link_hash_table_create),
1658 (elf_xtensa_new_section_hook): Likewise.
1659 * elf64-alpha.c (elf64_alpha_bfd_link_hash_table_create),
1660 (get_got_entry, elf64_alpha_check_relocs): Likewise.
1661 * elf64-hppa.c (elf64_hppa_hash_table_create): Likewise.
1662 * elf64-ia64-vms.c (elf64_ia64_object_p): Likewise.
1663 * elf64-mmix.c (mmix_elf_new_section_hook): Likewise.
1664 * elf64-ppc.c (ppc64_elf_new_section_hook),
1665 (ppc64_elf_link_hash_table_create, update_local_sym_info),
1666 (update_plt_info, ppc64_elf_check_relocs): Likewise.
1667 * elf64-s390.c (elf_s390_link_hash_table_create),
1668 (elf_s390_check_relocs): Likewise.
1669 * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
1670 * elflink.c (bfd_elf_link_record_local_dynamic_symbol),
1671 (_bfd_elf_link_find_version_dependencies, elf_link_add_object_symbols),
1672 (elf_link_add_archive_symbols, compute_bucket_count),
1673 (bfd_elf_size_dynsym_hash_dynstr, _bfd_elf_link_hash_table_create),
1674 (bfd_elf_get_bfd_needed_list, elf_link_swap_symbols_out),
1675 (bfd_elf_final_link): Likewise.
1676 * elfnn-aarch64.c (elfNN_aarch64_link_hash_table_create),
1677 (elfNN_aarch64_setup_section_lists, elfNN_aarch64_check_relocs),
1678 (elfNN_aarch64_new_section_hook): Likewise.
1679 * elfnn-ia64.c (elfNN_ia64_object_p): Likewise.
1680 * elfnn-riscv.c (riscv_elf_link_hash_table_create),
1681 (riscv_elf_check_relocs): Likewise.
1682 * elfxx-mips.c (_bfd_mips_elf_new_section_hook),
1683 (_bfd_mips_elf_add_symbol_hook, _bfd_mips_elf_check_relocs),
1684 (_bfd_mips_elf_modify_segment_map, _bfd_mips_elf_set_section_contents),
1685 (_bfd_mips_elf_link_hash_table_create): Likewise.
1686 * elfxx-sparc.c (_bfd_sparc_elf_link_hash_table_create),
1687 (_bfd_sparc_elf_check_relocs),
1688 (_bfd_sparc_elf_new_section_hook): Likewise.
1689 * elfxx-tilegx.c (tilegx_elf_link_hash_table_create),
1690 (tilegx_elf_check_relocs): Likewise.
1691 * elfxx-x86.c (_bfd_x86_elf_link_hash_table_create): Likewise.
1692 * format.c (bfd_check_format_matches): Likewise.
1693 * hash.c (_bfd_stringtab_init): Likewise.
1694 * ihex.c (ihex_scan): Likewise.
1695 * irix-core.c (irix_core_core_file_p): Likewise.
1696 * linker.c (bfd_wrapped_link_hash_lookup),
1697 (_bfd_generic_link_hash_table_create),
1698 (_bfd_generic_reloc_link_order): Likewise.
1699 * lynx-core.c (lynx_core_file_p): Likewise.
1700 * netbsd-core.c (netbsd_core_file_p): Likewise.
1701 * osf-core.c (osf_core_core_file_p): Likewise.
1702 * pdp11.c (some_aout_object_p, mkobject, make_empty_symbol),
1703 (link_hash_table_create, aout_link_write_other_symbol): Likewise.
1704 * peXXigen.c (_bfd_XX_bfd_copy_private_section_data): Likewise.
1705 * peicode.h (pe_mkobject): Likewise.
1706 * ppcboot.c (ppcboot_mkobject, ppcboot_canonicalize_symtab): Likewise.
1707 * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
1708 * sco5-core.c (read_uarea): Likewise.
1709 * som.c (hppa_som_gen_reloc_type, som_object_p, som_prep_headers),
1710 (som_write_fixups, som_write_space_strings, som_write_symbol_strings),
1711 (som_finish_writing, som_canonicalize_symtab, som_new_section_hook),
1712 (som_bfd_copy_private_section_data, bfd_som_set_section_attributes),
1713 (bfd_som_attach_aux_hdr, som_write_armap): Likewise.
1714 * srec.c (srec_scan): Likewise.
1715 * syms.c (_bfd_generic_make_empty_symbol): Likewise.
1716 * targets.c (bfd_target_list): Likewise.
1717 * tekhex.c (first_phase, tekhex_sizeof_headers): Likewise.
1718 * trad-core.c (trad_unix_core_file_p): Likewise.
1719 * vms-alpha.c (vms_initialize, alpha_vms_bfd_link_hash_table_create),
1720 (vms_new_section_hook): Likewise.
1721 * wasm-module.c (wasm_make_empty_symbol): Likewise.
1722 * xcofflink.c (xcoff_get_section_contents),
1723 (_bfd_xcoff_bfd_link_hash_table_create, xcoff_set_import_path),
1724 (xcoff_find_function, bfd_xcoff_link_record_set, xcoff_build_ldsym),
1725 (bfd_xcoff_size_dynamic_sections, xcoff_link_input_bfd): Likewise.
1726
1727 2020-02-19 Alan Modra <amodra@gmail.com>
1728
1729 * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
1730
1731 2020-02-13 H.J. Lu <hongjiu.lu@intel.com>
1732
1733 * plugin.c (try_load_plugin): Make plugin_list_iter an argument
1734 and use it if it isn't NULL. Remove has_plugin_p argument. Add
1735 a build_list_p argument. Don't search plugin_list. Short circuit
1736 when building the plugin list.
1737 (has_plugin): Renamed to has_plugin_list.
1738 (bfd_plugin_set_plugin): Don't set has_plugin.
1739 (bfd_plugin_specified_p): Check plugin_list instead.
1740 (build_plugin_list): New function.
1741 (load_plugin): Call build_plugin_list and use plugin_list.
1742
1743 2020-02-11 H.J. Lu <hongjiu.lu@intel.com>
1744
1745 PR binutils/25355
1746 * plugin.c (try_claim): Always clean up for LTO wrapper.
1747 (try_load_plugin): Treat each object as independent. Create a
1748 copy for plugin name.
1749
1750 2020-02-11 Nick Clifton <nickc@redhat.com>
1751
1752 * elf32-msp430.c (msp430_final_link_relocate): Always use longs
1753 for addresses in print statements.
1754 (msp430_elf_relax_delete_bytes): Likewise.
1755 (msp430_elf_relax_add_words): Likewise.
1756 (msp430_elf_relax_section): Likewise.
1757
1758 2020-02-11 H.J. Lu <hongjiu.lu@intel.com>
1759
1760 * plugin.c (add_symbols): Clear plugin_data memory.
1761
1762 2020-02-10 H.J. Lu <hongjiu.lu@intel.com>
1763
1764 PR binutils/25355
1765 * configure.ac (HAVE_EXECUTABLE_SUFFIX): New AC_DEFINE.
1766 (EXECUTABLE_SUFFIX): Likewise.
1767 * config.in: Regenerated.
1768 * configure: Likewise.
1769 * plugin.c (bfd_plugin_close_and_cleanup): Removed.
1770 (plugin_list_entry): Add all_symbols_read, cleanup_handler,
1771 gcc, lto_wrapper, resolution_file, resolution_option, gcc_env,
1772 real_bfd, real_nsyms, real_syms, lto_nsyms and lto_syms.
1773 (get_lto_wrapper): New.
1774 (setup_lto_wrapper_env): Likewise.
1775 (current_plugin): Likewise.
1776 (register_all_symbols_read): Likewise.
1777 (register_cleanup): Likewise.
1778 (get_symbols): Likewise.
1779 (add_input_file): Likewise.
1780 (bfd_plugin_close_and_cleanup): Likewise.
1781 (claim_file): Removed.
1782 (register_claim_file): Set current_plugin->claim_file.
1783 (add_symbols): Make a copy of LTO symbols. Set lto_nsyms and
1784 lto_syms in current_plugin.
1785 (try_claim): Use current_plugin->claim_file. Call LTO plugin
1786 all_symbols_read handler. Copy real symbols to plugin_data.
1787 Call LTO plugin cleanup handler. Clean up for LTO wrapper.
1788 (try_load_plugin): Don't reuse the previous plugin for LTO
1789 wrapper. Set up GCC LTO wrapper if possible. Don't set
1790 plugin_list_iter->claim_file.
1791 (bfd_plugin_canonicalize_symtab): Use real LTO symbols if
1792 possible.
1793 * plugin.h (plugin_data_struct): Add real_bfd, real_nsyms and
1794 real_syms.
1795
1796 2020-02-10 Jozef Lawrynowicz <jozef.l@mittosystems.com>
1797
1798 * elf32-msp430.c (msp430_elf_relax_section): Before relaxing a branch,
1799 check if previous instruction matches a conditional jump inserted
1800 earlier. Invert conditional jump and delete branch in this case.
1801
1802 2020-02-10 Jozef Lawrynowicz <jozef.l@mittosystems.com>
1803
1804 * elf32-msp430.c (msp430_elf_relax_add_two_words): Rename to
1805 msp430_elf_relax_add_words. Support insertion of either one or two
1806 words.
1807 (msp430_elf_relax_section): Catch opcode of 0x3c00 when relocation
1808 needs to be grown. Handle insertion of branch instruction to replace
1809 jump.
1810
1811 2020-02-10 Jozef Lawrynowicz <jozef.l@mittosystems.com>
1812
1813 * elf32-msp430.c (msp430_final_link_relocate): Add printf statements for
1814 debugging relocations.
1815 (msp430_elf_relax_delete_bytes): Likewise.
1816 (msp430_elf_relax_add_two_words): Likewise.
1817 (msp430_elf_relax_section): Likewise.
1818
1819 2020-02-10 Alan Modra <amodra@gmail.com>
1820
1821 * archures.c: Wrap overlong z80 comments.
1822 * bfd-in2.h: Regenerate.
1823
1824 2020-02-07 Sergey Belyashov <sergey.belyashov@gmail.com>
1825
1826 PR 25469
1827 * archures.c: Add GBZ80 and Z80N machine values.
1828 * reloc.c: Add BFD_RELOC_Z80_16_BE.
1829 * coff-z80.c: Add support for new reloc.
1830 * coffcode.h: Add support for new machine values.
1831 * cpu-z80.c: Add support for new machine names.
1832 * elf32-z80.c: Add support for new reloc.
1833 * bfd-in2.h: Regenerate.
1834 * libbfd.h: Regenerate.
1835
1836 2020-02-07 Nick Clifton <nickc@redhat.com>
1837
1838 PR 23932
1839 * elf.c (rewrite_elf_program_header): Do not complain if no
1840 sections are mapped to a segment.
1841
1842 2020-02-06 H.J. Lu <hongjiu.lu@intel.com>
1843
1844 PR ld/25490
1845 * elflink.c (_bfd_elf_gc_mark_extra_sections): Issue an error
1846 for garbage collection on __patchable_function_entries section
1847 without linked-to section.
1848
1849 2020-02-06 H.J. Lu <hongjiu.lu@intel.com>
1850
1851 PR gas/25381
1852 * bfd-in2.h: Regenerated.
1853 * elflink.c (_bfd_elf_gc_mark_extra_sections): Call mark_hook
1854 on section if gc_mark of any of its linked-to sections is set
1855 and don't set gc_mark again.
1856 * section.c (asection): Add linked_to_symbol_name to map_head
1857 union.
1858
1859 2020-02-06 Maciej W. Rozycki <macro@wdc.com>
1860
1861 * elf32-v850.c (v850_elf_relax_section): Fix the index used for
1862 reporting an unrecognized instruction with R_V850_LONGJUMP.
1863
1864 2020-02-05 Alan Modra <amodra@gmail.com>
1865
1866 * elf64-ppc.c (ppc_stub_plt_branch): Match comment with reality.
1867
1868 2020-02-04 Alan Modra <amodra@gmail.com>
1869
1870 * elf32-ppc.c (ppc_elf_relocate_section): After applying
1871 R_PPC_VLE_ADDR20, goto copy_reloc.
1872
1873 2020-02-02 H.J. Lu <hongjiu.lu@intel.com>
1874
1875 * bfd-in2.h: Regenerated.
1876 * section.c (SEC_ASSEMBLER_SECTION_ID): Fix a typo in comments.
1877
1878 2020-02-02 H.J. Lu <hongjiu.lu@intel.com>
1879
1880 PR gas/25380
1881 * bfd-in2.h: Regenerated.
1882 * ecoff.c (bfd_debug_section): Add section_id.
1883 * section.c (bfd_section): Add section_id.
1884 (SEC_ASSEMBLER_SECTION_ID): New.
1885 (BFD_FAKE_SECTION): Add section_id.
1886
1887 2020-02-01 Nick Clifton <nickc@redhat.com>
1888
1889 * config.bfd: Move the c30-aout and tic30-aout targets onto the
1890 obsolete list.
1891
1892 2020-01-31 Sandra Loosemore <sandra@codesourcery.com>
1893
1894 * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): DW_EH_PE_datarel
1895 encodings are relative to the GOT on nios2, too.
1896
1897 2020-01-31 Alan Modra <amodra@gmail.com>
1898
1899 * Makefile.am (elf32-target.h, elf64-target.h): Don't use a temp
1900 file. Use $< and $@ in rules.
1901 (elf32-aarch64.c, elf64-aarch64.c): Likewise.
1902 (elf32-ia64.c, elf64-ia64.c): Likewise.
1903 (elf32-riscv.c, elf64-riscv.c): Likewise.
1904 (peigen.c, pepigen.c, pex64igen.c): Likewise.
1905 (elf32-aarch64.c, elf64-aarch64.c): Don't emit $srcdir on #line.
1906 (elf32-riscv.c, elf64-riscv.c): Likewise, and use $(SED).
1907 (elf32-ia64.c, elf64-ia64.c): Do emit #line.
1908 (peigen.c, pepigen.c, pex64igen.c): Likewise.
1909 * Makefile.in: Regenerate.
1910
1911 2020-01-31 Alan Modra <amodra@gmail.com>
1912
1913 PR 4110
1914 * elf.c (setup_group): Don't clear entire section contents,
1915 just the padding after group flags. Release alloc'd memory
1916 after a seek or read failure.
1917
1918 2020-01-16 Jon Turney <jon.turney@dronecode.org.uk>
1919
1920 * peXXigen.c (pe_is_repro): New function.
1921 (_bfd_XX_print_private_bfd_data_common): Note timestamp is
1922 actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
1923
1924 2020-01-16 Jon Turney <jon.turney@dronecode.org.uk>
1925
1926 * peXXigen.c (debug_type_names): Add names for new debug data type
1927 values.
1928
1929 2020-01-16 Jon Turney <jon.turney@dronecode.org.uk>
1930
1931 * peXXigen.c (pe_print_debugdata): Fix the iteration variable for
1932 inner loop. Fix a memory leak.
1933
1934 2020-01-30 Alan Modra <amodra@gmail.com>
1935
1936 * coffgen.c (coff_real_object_p): Don't clear obj_coff_keep_syms
1937 or obj_coff_keep_strings here.
1938 (coff_get_normalized_symtab): Free external syms directly.
1939 * xcofflink.c (xcoff_link_input_bfd): Restore obj_coff_keep_syms
1940 on error exit path.
1941
1942 2020-01-27 Jim Wilson <jimw@sifive.com>
1943
1944 * cpu-riscv.c (riscv_scan): New.
1945 (N): Change bfd_default_scan to riscv_scan.
1946
1947 2020-01-27 Andreas Schwab <schwab@suse.de>
1948
1949 * Makefile.am (ALL_MACHINES): Remove cpu-plugin.lo.
1950 (ALL_MACHINES_CFILES): Remove cpu-plugin.c.
1951 * Makefile.in: Regenerate.
1952 * cpu-plugin.c: Remove.
1953 * archures.c (enum bfd_architecture): Remove bfd_arch_plugin.
1954 (bfd_plugin_arch): Remove declaration.
1955 * bfd-in2.h: Regenerate.
1956 * po/SRC-POTFILES.in: Regenerate.
1957
1958 2020-01-27 H.J. Lu <hongjiu.lu@intel.com>
1959 Alan Modra <amodra@gmail.com>
1960
1961 PR ld/25458
1962 * elflink.c (_bfd_elf_gc_mark_rsec): Mark all weak aliases.
1963
1964 2020-01-24 Jim Wilson <jimw@sifive.com>
1965
1966 * elfxx-riscv.c (riscv_get_prefix_class): Format s case like others.
1967 (riscv_parse_prefixed_ext): Fix s extension comment and reword to
1968 avoid over long line.
1969
1970 2020-01-24 Nick Clifton <nickc@redhat.com>
1971
1972 PR 25447
1973 * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep
1974 syms and keep strings flags as these may have been set in order to
1975 prevent a bogus call to free.
1976
1977 2020-01-23 Nick Clifton <nickc@redhat.com>
1978
1979 * po/fr.po: Updated French translation.
1980
1981 2020-01-23 Alan Modra <amodra@gmail.com>
1982
1983 PR 25444
1984 * elf.c (assign_file_positions_for_load_sections): Avoid divide
1985 by zero when p_align is zero.
1986
1987 2020-01-22 Maxim Blinov <maxim.blinov@embecosm.com>
1988
1989 * bfd/elfnn-riscv.c (riscv_skip_prefix): New.
1990 (riscv_prefix_cmp): Likewise.
1991 (riscv_non_std_ext_p): Deleted.
1992 (riscv_std_sv_ext_p): Likewise.
1993 (riscv_non_std_sv_ext_p): Likewise.
1994 (riscv_merge_non_std_and_sv_ext): Rename to...
1995 (riscv_merge_multi_letter_ext): and modified to use riscv_prefix_cmp.
1996 (riscv_merge_arch_attr_info): Replace 3 calls to
1997 riscv_merge_non_std_and_sv_ext with single call to
1998 riscv_merge_multi_letter_ext.
1999 * bfd/elfxx-riscv.c (riscv_parse_std_ext): Break if we
2000 encounter a 'z' prefix.
2001 (riscv_get_prefix_class): New function, return prefix class based
2002 on first few characters of input string.
2003 (riscv_parse_config): New structure to factor out minor differences
2004 in extension class parsing behaviour.
2005 (riscv_parse_sv_or_non_std_ext): Rename to...
2006 (riscv_parse_prefixed_ext): and parameterise with
2007 riscv_parse_config.
2008 (riscv_std_z_ext_strtab, riscv_std_s_ext_strtab): New.
2009 (riscv_multi_letter_ext_valid_p): New.
2010 (riscv_ext_x_valid_p, riscv_ext_z_valid_p, riscv_ext_s_valid_p): New.
2011 (riscv_parse_subset): Delegate all non-single-letter parsing work
2012 to riscv_parse_prefixed_ext.
2013 * bfd/elfxx-riscv.h (riscv_isa_ext_class): New type.
2014 (riscv_get_prefix_class): Declare.
2015
2016 2020-01-22 Alan Modra <amodra@gmail.com>
2017
2018 * elf64-ppc.c (struct ppc_link_hash_table): Add tga_group.
2019 (ppc64_elf_archive_symbol_lookup): Extract __tls_get_addr_opt for
2020 __tls_get_addr_desc.
2021 (ppc64_elf_size_stubs): Add section for linker generated
2022 __tls_get_addr_desc wrapper function. Loop at least once if
2023 generating this function.
2024 (emit_tga_desc, emit_tga_desc_eh_frame): New functions.
2025 (ppc64_elf_build_stubs): Generate __tls_get_addr_desc.
2026
2027 2020-01-22 Alan Modra <amodra@gmail.com>
2028
2029 * elf64-ppc.h (struct ppc64_elf_params): Add no_tls_get_addr_regsave.
2030 * elf64-ppc.c (struct ppc_link_hash_table): Add tga_desc and
2031 tga_desc_fd.
2032 (is_tls_get_addr): Match tga_desc and tga_desc_df too.
2033 (STDU_R1_0R1, ADDI_R1_R1): Define.
2034 (tls_get_addr_prologue, tls_get_addr_epilogue): New functions.
2035 (ppc64_elf_tls_setup): Set up tga_desc and tga_desc_fd. Indirect
2036 tga_desc_fd to opt_fd, and tga_desc to opt. Set
2037 no_tls_get_addr_regsave.
2038 (branch_reloc_hash_match): Add hash3 and hash4.
2039 (ppc64_elf_tls_optimize): Handle tga_desc_fd and tga_desc too.
2040 (ppc64_elf_size_dynamic_sections): Likewise.
2041 (ppc64_elf_relocate_section): Likewise.
2042 (plt_stub_size, build_plt_stub): Likewise. Size regsave
2043 __tls_get_addr stub.
2044 (build_tls_get_addr_stub): Build regsave __tls_get_addr stub and
2045 eh_frame.
2046 (ppc_size_one_stub): Handle tga_desc_fd and tga_desc too. Size
2047 eh_frame for regsave __tls_get_addr.
2048
2049 2020-01-22 Alan Modra <amodra@gmail.com>
2050
2051 * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
2052 which __tls_get_addr calls will be eliminated.
2053
2054 2020-01-20 Nick Clifton <nickc@redhat.com>
2055
2056 * po/pt.po: Updates Portuguese translation.
2057 * po/ru.po: Updated Russian translation.
2058 * po/uk.po: Updated Ukranian translation.
2059
2060 2020-01-20 H.J. Lu <hongjiu.lu@intel.com>
2061
2062 PR ld/25416
2063 * elf64-x86-64.c (elf_x86_64_check_tls_transition): Support
2064 "rex leal x@tlsdesc(%rip), %reg" and "call *x@tlsdesc(%eax)" in
2065 X32 mode.
2066 (elf_x86_64_relocate_section): In x32 mode, for GDesc -> LE
2067 transition, relax "rex leal x@tlsdesc(%rip), %reg" to
2068 "rex movl $x@tpoff, %reg", for GDesc -> IE transition, relax
2069 "rex leal x@tlsdesc(%rip), %reg" to
2070 "rex movl x@gottpoff(%rip), %eax". For both transitions, relax
2071 "call *(%eax)" to "nopl (%rax)".
2072
2073 2020-01-20 Alan Modra <amodra@gmail.com>
2074
2075 * elf64-ppc.c (LD_R11_0R3, CMPDI_R11_0, STD_R11_0R1, LD_R11_0R1),
2076 (MTLR_R11): Don't define.
2077 (LD_R0_0R3, CMPDI_R0_0): Define.
2078 (build_tls_get_addr_stub): Don't use r11 in stub.
2079
2080 2020-01-20 Alan Modra <amodra@gmail.com>
2081
2082 * elf64-ppc.c (ppc_elf_hash_entry): New function, use throughout file.
2083 (defined_sym_val, is_tls_get_addr): Likewise.
2084
2085 2020-01-18 Nick Clifton <nickc@redhat.com>
2086
2087 * version.m4 (BFD_VERSION): Set to 2.34.50.
2088 * configure: Regenerate.
2089 * po/bfd.pot: Regenerate.
2090
2091 2020-01-18 Nick Clifton <nickc@redhat.com>
2092
2093 Binutils 2.34 branch created.
2094
2095 2020-01-17 Christian Biesinger <cbiesinger@google.com>
2096
2097 * coff-arm.c: Fix spelling error (seperate).
2098 * elfxx-riscv.c (riscv_parse_sv_or_non_std_ext): Fix spelling
2099 error (seperate).
2100 * sysdep.h (strnlen): Fix spelling error (seperate).
2101
2102 2020-01-15 Lars Brinkhoff <lars@nocrew.org>
2103
2104 PR 20694
2105 * pdp11.c (TARGET_PAGE_SIZE): Set to 8192.
2106
2107 2020-01-15 Alan Modra <amodra@gmail.com>
2108
2109 PR 25384
2110 * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
2111 (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
2112 of function symbols unless dot symbols are present. Do warn
2113 whenever one is created, regardles of whether a PLT entry is
2114 also emitted for the function symbol.
2115
2116 2020-01-14 Alan Modra <amodra@gmail.com>
2117
2118 * som.c (som_bfd_count_ar_symbols): Error when file position
2119 of symbols on chains is not strictly increasing.
2120
2121 2020-01-14 Alan Modra <amodra@gmail.com>
2122
2123 * vms.h (VMS_DEBUG): Define as 0.
2124 * vms-alpha.c (image_write): Move debug output after bounds check.
2125 Tidy bounds check.
2126 (_bfd_vms_slurp_eihd): Warning fix.
2127 (_bfd_vms_slurp_etir): Init variables to avoid bogus warnings.
2128
2129 2020-01-13 Alan Modra <amodra@gmail.com>
2130
2131 * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
2132 for "ignored" records.
2133
2134 2020-01-13 Alan Modra <amodra@gmail.com>
2135
2136 * wasm-module.c (wasm_scan_name_function_section): Formatting.
2137 Delete asect name check. Move asect NULL check to wasm_object_p.
2138 Correct bounds check of sizes against end. Replace uses of
2139 bfd_zalloc with bfd_alloc, zeroing only necessary bytes. Use
2140 just one bfd_release.
2141 (wasm_scan): Don't use malloc/strdup for section names,
2142 bfd_alloc instead. Simplify code prefixing section name.
2143 Formatting. Don't attempt to free memory here..
2144 (wasm_object_p): ..do so here.
2145
2146 2020-01-10 Szabolcs Nagy <szabolcs.nagy@arm.com>
2147
2148 PR ld/22269
2149 * elf32-arm.c (elf32_arm_final_link_relocate): Use
2150 UNDEFWEAK_NO_DYNAMIC_RELOC.
2151 (allocate_dynrelocs_for_symbol): Likewise.
2152
2153 2020-01-10 Tamar Christina <tamar.christina@arm.com>
2154
2155 PR 25210
2156 * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass.
2157
2158 2020-01-10 Alan Modra <amodra@gmail.com>
2159
2160 * coff-alpha.c (alpha_ecoff_object_p): Calculate size in bfd_size_type.
2161
2162 2020-01-09 Nick Clifton <nickc@redhat.com>
2163
2164 PR 25221
2165 * bfd.c (bfd_convert_section_contents): Check for a compress
2166 header size that is larger than the actual section size.
2167
2168 2020-01-08 Alan Modra <amodra@gmail.com>
2169
2170 PR 25351
2171 * elflink.c (bfd_elf_final_link): Call _bfd_fix_excluded_sec_syms
2172 after removing sections.
2173
2174 2020-01-06 Jim Wilson <jimw@sifive.com>
2175
2176 PR 25205
2177 * elfnn-riscv.c (riscv_elf_relocate_section) <R_RISCV_CALL>: Add
2178 check for !bfd_link_pic (info).
2179 <R_RISCV_CALL_PLT>: Move next to R_RISCV_CALL.
2180 <R_RISCV_JAL>: Add comment.
2181 (_bfd_riscv_relax_section): For plt.offset check, add check for
2182 bfd_link_pic (info). Add comment.
2183
2184 2020-01-06 Alan Modra <amodra@gmail.com>
2185
2186 * format.c (bfd_check_format_matches): Ignore bfd_error on target
2187 match failures. Don't init to bfd_error_wrong_format before
2188 calling _bfd_check_format.
2189
2190 2020-01-06 Alan Modra <amodra@gmail.com>
2191
2192 * vms-alpha.c (_bfd_vms_push, _bfd_vms_pop): Return pass/fail
2193 status rather than exiting on stack overflow or underflow.
2194 (_bfd_vms_slurp_etir): Adjust to suit.
2195
2196 2020-01-06 Alan Modra <amodra@gmail.com>
2197
2198 * som.c (som_bfd_fill_in_ar_symbols): Bounds check som_dict index.
2199
2200 2020-01-06 Alan Modra <amodra@gmail.com>
2201
2202 * mach-o.c (bfd_mach_o_read_dylinker): Don't read past end of
2203 command. Check name offset is within command.
2204 (bfd_mach_o_read_dylib, bfd_mach_o_read_prebound_dylib),
2205 (bfd_mach_o_read_prebind_cksum, bfd_mach_o_read_twolevel_hints),
2206 (bfd_mach_o_read_fvmlib, bfd_mach_o_read_dysymtab),
2207 (bfd_mach_o_read_symtab, bfd_mach_o_read_uuid),
2208 (bfd_mach_o_read_linkedit, bfd_mach_o_read_str),
2209 (bfd_mach_o_read_dyld_info, bfd_mach_o_read_version_min),
2210 (bfd_mach_o_read_encryption_info, bfd_mach_o_read_source_version),
2211 (bfd_mach_o_read_encryption_info_64, bfd_mach_o_read_main),
2212 (bfd_mach_o_read_note, bfd_mach_o_read_build_version),
2213 (bfd_mach_o_read_segment): Similarly.
2214 (bfd_mach_o_read_thread): Properly bound check thread struct.
2215 Don't repeat checks on second loop.
2216 (bfd_mach_o_read_command): Fail on invalid command length.
2217
2218 2020-01-04 Alan Modra <amodra@gmail.com>
2219
2220 * format.c (bfd_check_format_matches): Add preserve_match.
2221 Save initial bfd state in "preserve", matched bfd state in
2222 "preserve_match". Save just the first match. Release
2223 bfd_alloc memory. Restore and finish preserved state as
2224 appropriate on all function exit paths.
2225
2226 2020-01-04 Alan Modra <amodra@gmail.com>
2227
2228 * mmo.c (mmo_mkobject): Allocate tdata with bfd_zalloc.
2229
2230 2020-01-04 Alan Modra <amodra@gmail.com>
2231
2232 * coffgen.c (coff_real_object_p): Free malloc'd memory on target
2233 match too.
2234
2235 2020-01-03 Nick Clifton <nickc@redhat.com>
2236
2237 PR 25307
2238 (bfd_pef_parse_function_stubs): Correct the test that ensures that
2239 there is enough data remaining in the code buffer before
2240 attempting to read a function stub.
2241
2242 2020-01-03 Nick Clifton <nickc@redhat.com>
2243
2244 PR 25308
2245 * elf-properties.c (_bfd_elf_convert_gnu_properties): Check the
2246 return value from bfd_malloc.
2247 * elf32-arm.c (bfd_elf32_arm_vfp11_fix_veneer_locations): Likewise.
2248 (bfd_elf32_arm_stm32l4xx_fix_veneer_locations): Likewise.
2249 (elf32_arm_filter_cmse_symbols): Likewise.
2250 (elf32_arm_write_section): Likewise.
2251 * mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
2252 (bfd_mach_o_follow_dsym): Likewise.
2253 * pef.c (bfd_pef_print_loader_section): Likewise.
2254 (bfd_pef_scan_start_address): Likewise.
2255 (bfd_pef_parse_function_stubs): Likewise.
2256 (bfd_pef_parse_symbols): Likewise.
2257
2258 2020-01-03 Sergei Trofimovich <siarheit@google.com>
2259
2260 * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): don't fail
2261 on binary inputs ld/PR25316.
2262 (is_ia64_elf): new helper to filter on ia64 objects.
2263
2264 2020-01-03 Jan Beulich <jbeulich@suse.com>
2265
2266 * mach-o.c (cpusubtype, bfd_mach_o_header_p): Insert underscore
2267 in parameter names.
2268 (bfd_mach_o_scan): Insert underscore in two variable names.
2269
2270 2020-01-02 Sergey Belyashov <sergey.belyashov@gmail.com>
2271
2272 * Makefile.am: Add z80-elf target support.
2273 * configure.ac: Likewise.
2274 * targets.c: Likewise.
2275 * Makefile.in: Regenerate.
2276 * configure: Regenerate.
2277 * config.bfd: Add z80-elf target support and new arches: ez80 and
2278 z180.
2279 * elf32-z80.c: New file.
2280 * archures.c: Add new z80 architectures: eZ80 and Z180.
2281 * coffcode.h: Likewise.
2282 * cpu-z80.c: Likewise.
2283 * coff-z80.c: Add new relocations for Z80 target and local label
2284 check.
2285 * reloc.c: Add new relocs.
2286 * bfd-in2.h: Regenerate.
2287 * libbfd.h: Regenerate.
2288
2289 2020-01-02 Tamar Christina <tamar.christina@arm.com>
2290
2291 PR 25210
2292 PR 24753
2293 * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
2294
2295 2020-01-01 Alan Modra <amodra@gmail.com>
2296
2297 Update year range in copyright notice of all files.
2298
2299 For older changes see ChangeLog-2019
2300 \f
2301 Copyright (C) 2020 Free Software Foundation, Inc.
2302
2303 Copying and distribution of this file, with or without modification,
2304 are permitted in any medium without royalty provided the copyright
2305 notice and this notice are preserved.
2306
2307 Local Variables:
2308 mode: change-log
2309 left-margin: 8
2310 fill-column: 74
2311 version-control: never
2312 End:
This page took 0.087339 seconds and 5 git commands to generate.