drivers/gpu/drm/i915/intel_dp_mst.c

   1 /*
   2  * Copyright © 2008 Intel Corporation
   3  *             2014 Red Hat Inc.
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  22  * IN THE SOFTWARE.
  23  *
  24  */
  25
  26 #include <drm/drmP.h>
  27 #include "i915_drv.h"
  28 #include "intel_drv.h"
  29 #include <drm/drm_atomic_helper.h>
  30 #include <drm/drm_crtc_helper.h>
  31 #include <drm/drm_edid.h>
  32
  33 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
  34                                         struct intel_crtc_state *pipe_config)
  35 {
  36         struct drm_device *dev = encoder->base.dev;
  37         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  38         struct intel_digital_port *intel_dig_port = intel_mst->primary;
  39         struct intel_dp *intel_dp = &intel_dig_port->dp;
  40         struct drm_atomic_state *state;
  41         int bpp, i;
  42         int lane_count, slots;
  43         struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  44         struct drm_connector *drm_connector;
  45         struct intel_connector *connector, *found = NULL;
  46         struct drm_connector_state *connector_state;
  47         int mst_pbn;
  48
  49         pipe_config->dp_encoder_is_mst = true;
  50         pipe_config->has_pch_encoder = false;
  51         pipe_config->has_dp_encoder = true;
  52         bpp = 24;
  53         /*
  54          * for MST we always configure max link bw - the spec doesn't
  55          * seem to suggest we should do otherwise.
  56          */
  57         lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
  58
  59
  60         pipe_config->lane_count = lane_count;
  61
  62         pipe_config->pipe_bpp = 24;
  63         pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
  64
  65         state = pipe_config->base.state;
  66
  67         for_each_connector_in_state(state, drm_connector, connector_state, i) {
  68                 connector = to_intel_connector(drm_connector);
  69
  70                 if (connector_state->best_encoder == &encoder->base) {
  71                         found = connector;
  72                         break;
  73                 }
  74         }
  75
  76         if (!found) {
  77                 DRM_ERROR("can't find connector\n");
  78                 return false;
  79         }
  80
  81         mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->clock, bpp);
  82
  83         pipe_config->pbn = mst_pbn;
  84         slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
  85
  86         intel_link_compute_m_n(bpp, lane_count,
  87                                adjusted_mode->crtc_clock,
  88                                pipe_config->port_clock,
  89                                &pipe_config->dp_m_n);
  90
  91         pipe_config->dp_m_n.tu = slots;
  92
  93         if (IS_HASWELL(dev) || IS_BROADWELL(dev))
  94                 hsw_dp_set_ddi_pll_sel(pipe_config);
  95
  96         return true;
  97
  98 }
  99
 100 static void intel_mst_disable_dp(struct intel_encoder *encoder)
 101 {
 102         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 103         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 104         struct intel_dp *intel_dp = &intel_dig_port->dp;
 105         int ret;
 106
 107         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 108
 109         drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->port);
 110
 111         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 112         if (ret) {
 113                 DRM_ERROR("failed to update payload %d\n", ret);
 114         }
 115 }
 116
 117 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
 118 {
 119         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 120         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 121         struct intel_dp *intel_dp = &intel_dig_port->dp;
 122
 123         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 124
 125         /* this can fail */
 126         drm_dp_check_act_status(&intel_dp->mst_mgr);
 127         /* and this can also fail */
 128         drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 129
 130         drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->port);
 131
 132         intel_dp->active_mst_links--;
 133         intel_mst->port = NULL;
 134         if (intel_dp->active_mst_links == 0) {
 135                 intel_dig_port->base.post_disable(&intel_dig_port->base);
 136                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 137         }
 138 }
 139
 140 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
 141 {
 142         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 143         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 144         struct intel_dp *intel_dp = &intel_dig_port->dp;
 145         struct drm_device *dev = encoder->base.dev;
 146         struct drm_i915_private *dev_priv = dev->dev_private;
 147         enum port port = intel_dig_port->port;
 148         int ret;
 149         uint32_t temp;
 150         struct intel_connector *found = NULL, *connector;
 151         int slots;
 152         struct drm_crtc *crtc = encoder->base.crtc;
 153         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 154
 155         for_each_intel_connector(dev, connector) {
 156                 if (connector->base.state->best_encoder == &encoder->base) {
 157                         found = connector;
 158                         break;
 159                 }
 160         }
 161
 162         if (!found) {
 163                 DRM_ERROR("can't find connector\n");
 164                 return;
 165         }
 166
 167         /* MST encoders are bound to a crtc, not to a connector,
 168          * force the mapping here for get_hw_state.
 169          */
 170         found->encoder = encoder;
 171
 172         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 173         intel_mst->port = found->port;
 174
 175         if (intel_dp->active_mst_links == 0) {
 176                 enum port port = intel_ddi_get_encoder_port(encoder);
 177
 178                 intel_dp_set_link_params(intel_dp, intel_crtc->config);
 179
 180                 /* FIXME: add support for SKL */
 181                 if (INTEL_INFO(dev)->gen < 9)
 182                         I915_WRITE(PORT_CLK_SEL(port),
 183                                    intel_crtc->config->ddi_pll_sel);
 184
 185                 intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
 186
 187                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
 188
 189
 190                 intel_dp_start_link_train(intel_dp);
 191                 intel_dp_complete_link_train(intel_dp);
 192                 intel_dp_stop_link_train(intel_dp);
 193         }
 194
 195         ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
 196                                        intel_mst->port,
 197                                        intel_crtc->config->pbn, &slots);
 198         if (ret == false) {
 199                 DRM_ERROR("failed to allocate vcpi\n");
 200                 return;
 201         }
 202
 203
 204         intel_dp->active_mst_links++;
 205         temp = I915_READ(DP_TP_STATUS(port));
 206         I915_WRITE(DP_TP_STATUS(port), temp);
 207
 208         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 209 }
 210
 211 static void intel_mst_enable_dp(struct intel_encoder *encoder)
 212 {
 213         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 214         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 215         struct intel_dp *intel_dp = &intel_dig_port->dp;
 216         struct drm_device *dev = intel_dig_port->base.base.dev;
 217         struct drm_i915_private *dev_priv = dev->dev_private;
 218         enum port port = intel_dig_port->port;
 219         int ret;
 220
 221         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 222
 223         if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
 224                      1))
 225                 DRM_ERROR("Timed out waiting for ACT sent\n");
 226
 227         ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
 228
 229         ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 230 }
 231
 232 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
 233                                       enum pipe *pipe)
 234 {
 235         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 236         *pipe = intel_mst->pipe;
 237         if (intel_mst->port)
 238                 return true;
 239         return false;
 240 }
 241
 242 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
 243                                         struct intel_crtc_state *pipe_config)
 244 {
 245         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 246         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 247         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 248         struct drm_device *dev = encoder->base.dev;
 249         struct drm_i915_private *dev_priv = dev->dev_private;
 250         enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
 251         u32 temp, flags = 0;
 252
 253         pipe_config->has_dp_encoder = true;
 254
 255         temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
 256         if (temp & TRANS_DDI_PHSYNC)
 257                 flags |= DRM_MODE_FLAG_PHSYNC;
 258         else
 259                 flags |= DRM_MODE_FLAG_NHSYNC;
 260         if (temp & TRANS_DDI_PVSYNC)
 261                 flags |= DRM_MODE_FLAG_PVSYNC;
 262         else
 263                 flags |= DRM_MODE_FLAG_NVSYNC;
 264
 265         switch (temp & TRANS_DDI_BPC_MASK) {
 266         case TRANS_DDI_BPC_6:
 267                 pipe_config->pipe_bpp = 18;
 268                 break;
 269         case TRANS_DDI_BPC_8:
 270                 pipe_config->pipe_bpp = 24;
 271                 break;
 272         case TRANS_DDI_BPC_10:
 273                 pipe_config->pipe_bpp = 30;
 274                 break;
 275         case TRANS_DDI_BPC_12:
 276                 pipe_config->pipe_bpp = 36;
 277                 break;
 278         default:
 279                 break;
 280         }
 281         pipe_config->base.adjusted_mode.flags |= flags;
 282
 283         pipe_config->lane_count =
 284                 ((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
 285
 286         intel_dp_get_m_n(crtc, pipe_config);
 287
 288         intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
 289 }
 290
 291 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
 292 {
 293         struct intel_connector *intel_connector = to_intel_connector(connector);
 294         struct intel_dp *intel_dp = intel_connector->mst_port;
 295         struct edid *edid;
 296         int ret;
 297
 298         edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
 299         if (!edid)
 300                 return 0;
 301
 302         ret = intel_connector_update_modes(connector, edid);
 303         kfree(edid);
 304
 305         return ret;
 306 }
 307
 308 static enum drm_connector_status
 309 intel_dp_mst_detect(struct drm_connector *connector, bool force)
 310 {
 311         struct intel_connector *intel_connector = to_intel_connector(connector);
 312         struct intel_dp *intel_dp = intel_connector->mst_port;
 313
 314         return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
 315 }
 316
 317 static int
 318 intel_dp_mst_set_property(struct drm_connector *connector,
 319                           struct drm_property *property,
 320                           uint64_t val)
 321 {
 322         return 0;
 323 }
 324
 325 static void
 326 intel_dp_mst_connector_destroy(struct drm_connector *connector)
 327 {
 328         struct intel_connector *intel_connector = to_intel_connector(connector);
 329
 330         if (!IS_ERR_OR_NULL(intel_connector->edid))
 331                 kfree(intel_connector->edid);
 332
 333         drm_connector_cleanup(connector);
 334         kfree(connector);
 335 }
 336
 337 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
 338         .dpms = drm_atomic_helper_connector_dpms,
 339         .detect = intel_dp_mst_detect,
 340         .fill_modes = drm_helper_probe_single_connector_modes,
 341         .set_property = intel_dp_mst_set_property,
 342         .atomic_get_property = intel_connector_atomic_get_property,
 343         .destroy = intel_dp_mst_connector_destroy,
 344         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 345         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 346 };
 347
 348 static int intel_dp_mst_get_modes(struct drm_connector *connector)
 349 {
 350         return intel_dp_mst_get_ddc_modes(connector);
 351 }
 352
 353 static enum drm_mode_status
 354 intel_dp_mst_mode_valid(struct drm_connector *connector,
 355                         struct drm_display_mode *mode)
 356 {
 357         /* TODO - validate mode against available PBN for link */
 358         if (mode->clock < 10000)
 359                 return MODE_CLOCK_LOW;
 360
 361         if (mode->flags & DRM_MODE_FLAG_DBLCLK)
 362                 return MODE_H_ILLEGAL;
 363
 364         return MODE_OK;
 365 }
 366
 367 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
 368                                                          struct drm_connector_state *state)
 369 {
 370         struct intel_connector *intel_connector = to_intel_connector(connector);
 371         struct intel_dp *intel_dp = intel_connector->mst_port;
 372         struct intel_crtc *crtc = to_intel_crtc(state->crtc);
 373
 374         return &intel_dp->mst_encoders[crtc->pipe]->base.base;
 375 }
 376
 377 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
 378 {
 379         struct intel_connector *intel_connector = to_intel_connector(connector);
 380         struct intel_dp *intel_dp = intel_connector->mst_port;
 381         return &intel_dp->mst_encoders[0]->base.base;
 382 }
 383
 384 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
 385         .get_modes = intel_dp_mst_get_modes,
 386         .mode_valid = intel_dp_mst_mode_valid,
 387         .atomic_best_encoder = intel_mst_atomic_best_encoder,
 388         .best_encoder = intel_mst_best_encoder,
 389 };
 390
 391 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
 392 {
 393         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
 394
 395         drm_encoder_cleanup(encoder);
 396         kfree(intel_mst);
 397 }
 398
 399 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
 400         .destroy = intel_dp_mst_encoder_destroy,
 401 };
 402
 403 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
 404 {
 405         if (connector->encoder && connector->base.state->crtc) {
 406                 enum pipe pipe;
 407                 if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
 408                         return false;
 409                 return true;
 410         }
 411         return false;
 412 }
 413
 414 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
 415 {
 416 #ifdef CONFIG_DRM_FBDEV_EMULATION
 417         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 418         drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, &connector->base);
 419 #endif
 420 }
 421
 422 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
 423 {
 424 #ifdef CONFIG_DRM_FBDEV_EMULATION
 425         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 426         drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, &connector->base);
 427 #endif
 428 }
 429
 430 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
 431 {
 432         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 433         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 434         struct drm_device *dev = intel_dig_port->base.base.dev;
 435         struct intel_connector *intel_connector;
 436         struct drm_connector *connector;
 437         int i;
 438
 439         intel_connector = intel_connector_alloc();
 440         if (!intel_connector)
 441                 return NULL;
 442
 443         connector = &intel_connector->base;
 444         drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
 445         drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
 446
 447         intel_connector->unregister = intel_connector_unregister;
 448         intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
 449         intel_connector->mst_port = intel_dp;
 450         intel_connector->port = port;
 451
 452         for (i = PIPE_A; i <= PIPE_C; i++) {
 453                 drm_mode_connector_attach_encoder(&intel_connector->base,
 454                                                   &intel_dp->mst_encoders[i]->base.base);
 455         }
 456         intel_dp_add_properties(intel_dp, connector);
 457
 458         drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
 459         drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
 460
 461         drm_mode_connector_set_path_property(connector, pathprop);
 462         drm_modeset_lock_all(dev);
 463         intel_connector_add_to_fbdev(intel_connector);
 464         drm_modeset_unlock_all(dev);
 465         drm_connector_register(&intel_connector->base);
 466         return connector;
 467 }
 468
 469 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 470                                            struct drm_connector *connector)
 471 {
 472         struct intel_connector *intel_connector = to_intel_connector(connector);
 473         struct drm_device *dev = connector->dev;
 474
 475         /* need to nuke the connector */
 476         drm_modeset_lock_all(dev);
 477         if (connector->state->crtc) {
 478                 struct drm_mode_set set;
 479                 int ret;
 480
 481                 memset(&set, 0, sizeof(set));
 482                 set.crtc = connector->state->crtc,
 483
 484                 ret = drm_atomic_helper_set_config(&set);
 485
 486                 WARN(ret, "Disabling mst crtc failed with %i\n", ret);
 487         }
 488         drm_modeset_unlock_all(dev);
 489
 490         intel_connector->unregister(intel_connector);
 491
 492         drm_modeset_lock_all(dev);
 493         intel_connector_remove_from_fbdev(intel_connector);
 494         drm_connector_cleanup(connector);
 495         drm_modeset_unlock_all(dev);
 496
 497         kfree(intel_connector);
 498         DRM_DEBUG_KMS("\n");
 499 }
 500
 501 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
 502 {
 503         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 504         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 505         struct drm_device *dev = intel_dig_port->base.base.dev;
 506
 507         drm_kms_helper_hotplug_event(dev);
 508 }
 509
 510 static struct drm_dp_mst_topology_cbs mst_cbs = {
 511         .add_connector = intel_dp_add_mst_connector,
 512         .destroy_connector = intel_dp_destroy_mst_connector,
 513         .hotplug = intel_dp_mst_hotplug,
 514 };
 515
 516 static struct intel_dp_mst_encoder *
 517 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
 518 {
 519         struct intel_dp_mst_encoder *intel_mst;
 520         struct intel_encoder *intel_encoder;
 521         struct drm_device *dev = intel_dig_port->base.base.dev;
 522
 523         intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
 524
 525         if (!intel_mst)
 526                 return NULL;
 527
 528         intel_mst->pipe = pipe;
 529         intel_encoder = &intel_mst->base;
 530         intel_mst->primary = intel_dig_port;
 531
 532         drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
 533                          DRM_MODE_ENCODER_DPMST);
 534
 535         intel_encoder->type = INTEL_OUTPUT_DP_MST;
 536         intel_encoder->crtc_mask = 0x7;
 537         intel_encoder->cloneable = 0;
 538
 539         intel_encoder->compute_config = intel_dp_mst_compute_config;
 540         intel_encoder->disable = intel_mst_disable_dp;
 541         intel_encoder->post_disable = intel_mst_post_disable_dp;
 542         intel_encoder->pre_enable = intel_mst_pre_enable_dp;
 543         intel_encoder->enable = intel_mst_enable_dp;
 544         intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
 545         intel_encoder->get_config = intel_dp_mst_enc_get_config;
 546
 547         return intel_mst;
 548
 549 }
 550
 551 static bool
 552 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
 553 {
 554         int i;
 555         struct intel_dp *intel_dp = &intel_dig_port->dp;
 556
 557         for (i = PIPE_A; i <= PIPE_C; i++)
 558                 intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
 559         return true;
 560 }
 561
 562 int
 563 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
 564 {
 565         struct intel_dp *intel_dp = &intel_dig_port->dp;
 566         struct drm_device *dev = intel_dig_port->base.base.dev;
 567         int ret;
 568
 569         intel_dp->can_mst = true;
 570         intel_dp->mst_mgr.cbs = &mst_cbs;
 571
 572         /* create encoders */
 573         intel_dp_create_fake_mst_encoders(intel_dig_port);
 574         ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
 575         if (ret) {
 576                 intel_dp->can_mst = false;
 577                 return ret;
 578         }
 579         return 0;
 580 }
 581
 582 void
 583 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
 584 {
 585         struct intel_dp *intel_dp = &intel_dig_port->dp;
 586
 587         if (!intel_dp->can_mst)
 588                 return;
 589
 590         drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
 591         /* encoders will get killed by normal cleanup */
 592 }