drivers/staging/media/omap4iss/iss_video.c

   1 /*
   2  * TI OMAP4 ISS V4L2 Driver - Generic video node
   3  *
   4  * Copyright (C) 2012 Texas Instruments, Inc.
   5  *
   6  * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
   7  *
   8  * This program is free software; you can redistribute it and/or modify
   9  * it under the terms of the GNU General Public License as published by
  10  * the Free Software Foundation; either version 2 of the License, or
  11  * (at your option) any later version.
  12  */
  13
  14 #include <asm/cacheflush.h>
  15 #include <linux/clk.h>
  16 #include <linux/mm.h>
  17 #include <linux/pagemap.h>
  18 #include <linux/sched.h>
  19 #include <linux/slab.h>
  20 #include <linux/vmalloc.h>
  21 #include <linux/module.h>
  22
  23 #include <media/v4l2-dev.h>
  24 #include <media/v4l2-ioctl.h>
  25 #include <media/v4l2-mc.h>
  26
  27 #include "iss_video.h"
  28 #include "iss.h"
  29
  30 /* -----------------------------------------------------------------------------
  31  * Helper functions
  32  */
  33
  34 static struct iss_format_info formats[] = {
  35         { MEDIA_BUS_FMT_Y8_1X8, MEDIA_BUS_FMT_Y8_1X8,
  36           MEDIA_BUS_FMT_Y8_1X8, MEDIA_BUS_FMT_Y8_1X8,
  37           V4L2_PIX_FMT_GREY, 8, "Greyscale 8 bpp", },
  38         { MEDIA_BUS_FMT_Y10_1X10, MEDIA_BUS_FMT_Y10_1X10,
  39           MEDIA_BUS_FMT_Y10_1X10, MEDIA_BUS_FMT_Y8_1X8,
  40           V4L2_PIX_FMT_Y10, 10, "Greyscale 10 bpp", },
  41         { MEDIA_BUS_FMT_Y12_1X12, MEDIA_BUS_FMT_Y10_1X10,
  42           MEDIA_BUS_FMT_Y12_1X12, MEDIA_BUS_FMT_Y8_1X8,
  43           V4L2_PIX_FMT_Y12, 12, "Greyscale 12 bpp", },
  44         { MEDIA_BUS_FMT_SBGGR8_1X8, MEDIA_BUS_FMT_SBGGR8_1X8,
  45           MEDIA_BUS_FMT_SBGGR8_1X8, MEDIA_BUS_FMT_SBGGR8_1X8,
  46           V4L2_PIX_FMT_SBGGR8, 8, "BGGR Bayer 8 bpp", },
  47         { MEDIA_BUS_FMT_SGBRG8_1X8, MEDIA_BUS_FMT_SGBRG8_1X8,
  48           MEDIA_BUS_FMT_SGBRG8_1X8, MEDIA_BUS_FMT_SGBRG8_1X8,
  49           V4L2_PIX_FMT_SGBRG8, 8, "GBRG Bayer 8 bpp", },
  50         { MEDIA_BUS_FMT_SGRBG8_1X8, MEDIA_BUS_FMT_SGRBG8_1X8,
  51           MEDIA_BUS_FMT_SGRBG8_1X8, MEDIA_BUS_FMT_SGRBG8_1X8,
  52           V4L2_PIX_FMT_SGRBG8, 8, "GRBG Bayer 8 bpp", },
  53         { MEDIA_BUS_FMT_SRGGB8_1X8, MEDIA_BUS_FMT_SRGGB8_1X8,
  54           MEDIA_BUS_FMT_SRGGB8_1X8, MEDIA_BUS_FMT_SRGGB8_1X8,
  55           V4L2_PIX_FMT_SRGGB8, 8, "RGGB Bayer 8 bpp", },
  56         { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8,
  57           MEDIA_BUS_FMT_SGRBG10_1X10, 0,
  58           V4L2_PIX_FMT_SGRBG10DPCM8, 8, "GRBG Bayer 10 bpp DPCM8",  },
  59         { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SBGGR10_1X10,
  60           MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SBGGR8_1X8,
  61           V4L2_PIX_FMT_SBGGR10, 10, "BGGR Bayer 10 bpp", },
  62         { MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10,
  63           MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SGBRG8_1X8,
  64           V4L2_PIX_FMT_SGBRG10, 10, "GBRG Bayer 10 bpp", },
  65         { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SGRBG10_1X10,
  66           MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SGRBG8_1X8,
  67           V4L2_PIX_FMT_SGRBG10, 10, "GRBG Bayer 10 bpp", },
  68         { MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10,
  69           MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SRGGB8_1X8,
  70           V4L2_PIX_FMT_SRGGB10, 10, "RGGB Bayer 10 bpp", },
  71         { MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SBGGR10_1X10,
  72           MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SBGGR8_1X8,
  73           V4L2_PIX_FMT_SBGGR12, 12, "BGGR Bayer 12 bpp", },
  74         { MEDIA_BUS_FMT_SGBRG12_1X12, MEDIA_BUS_FMT_SGBRG10_1X10,
  75           MEDIA_BUS_FMT_SGBRG12_1X12, MEDIA_BUS_FMT_SGBRG8_1X8,
  76           V4L2_PIX_FMT_SGBRG12, 12, "GBRG Bayer 12 bpp", },
  77         { MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SGRBG10_1X10,
  78           MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SGRBG8_1X8,
  79           V4L2_PIX_FMT_SGRBG12, 12, "GRBG Bayer 12 bpp", },
  80         { MEDIA_BUS_FMT_SRGGB12_1X12, MEDIA_BUS_FMT_SRGGB10_1X10,
  81           MEDIA_BUS_FMT_SRGGB12_1X12, MEDIA_BUS_FMT_SRGGB8_1X8,
  82           V4L2_PIX_FMT_SRGGB12, 12, "RGGB Bayer 12 bpp", },
  83         { MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_UYVY8_1X16,
  84           MEDIA_BUS_FMT_UYVY8_1X16, 0,
  85           V4L2_PIX_FMT_UYVY, 16, "YUV 4:2:2 (UYVY)", },
  86         { MEDIA_BUS_FMT_YUYV8_1X16, MEDIA_BUS_FMT_YUYV8_1X16,
  87           MEDIA_BUS_FMT_YUYV8_1X16, 0,
  88           V4L2_PIX_FMT_YUYV, 16, "YUV 4:2:2 (YUYV)", },
  89         { MEDIA_BUS_FMT_YUYV8_1_5X8, MEDIA_BUS_FMT_YUYV8_1_5X8,
  90           MEDIA_BUS_FMT_YUYV8_1_5X8, 0,
  91           V4L2_PIX_FMT_NV12, 8, "YUV 4:2:0 (NV12)", },
  92 };
  93
  94 const struct iss_format_info *
  95 omap4iss_video_format_info(u32 code)
  96 {
  97         unsigned int i;
  98
  99         for (i = 0; i < ARRAY_SIZE(formats); ++i) {
 100                 if (formats[i].code == code)
 101                         return &formats[i];
 102         }
 103
 104         return NULL;
 105 }
 106
 107 /*
 108  * iss_video_mbus_to_pix - Convert v4l2_mbus_framefmt to v4l2_pix_format
 109  * @video: ISS video instance
 110  * @mbus: v4l2_mbus_framefmt format (input)
 111  * @pix: v4l2_pix_format format (output)
 112  *
 113  * Fill the output pix structure with information from the input mbus format.
 114  * The bytesperline and sizeimage fields are computed from the requested bytes
 115  * per line value in the pix format and information from the video instance.
 116  *
 117  * Return the number of padding bytes at end of line.
 118  */
 119 static unsigned int iss_video_mbus_to_pix(const struct iss_video *video,
 120                                           const struct v4l2_mbus_framefmt *mbus,
 121                                           struct v4l2_pix_format *pix)
 122 {
 123         unsigned int bpl = pix->bytesperline;
 124         unsigned int min_bpl;
 125         unsigned int i;
 126
 127         memset(pix, 0, sizeof(*pix));
 128         pix->width = mbus->width;
 129         pix->height = mbus->height;
 130
 131         /* Skip the last format in the loop so that it will be selected if no
 132          * match is found.
 133          */
 134         for (i = 0; i < ARRAY_SIZE(formats) - 1; ++i) {
 135                 if (formats[i].code == mbus->code)
 136                         break;
 137         }
 138
 139         min_bpl = pix->width * ALIGN(formats[i].bpp, 8) / 8;
 140
 141         /* Clamp the requested bytes per line value. If the maximum bytes per
 142          * line value is zero, the module doesn't support user configurable line
 143          * sizes. Override the requested value with the minimum in that case.
 144          */
 145         if (video->bpl_max)
 146                 bpl = clamp(bpl, min_bpl, video->bpl_max);
 147         else
 148                 bpl = min_bpl;
 149
 150         if (!video->bpl_zero_padding || bpl != min_bpl)
 151                 bpl = ALIGN(bpl, video->bpl_alignment);
 152
 153         pix->pixelformat = formats[i].pixelformat;
 154         pix->bytesperline = bpl;
 155         pix->sizeimage = pix->bytesperline * pix->height;
 156         pix->colorspace = mbus->colorspace;
 157         pix->field = mbus->field;
 158
 159         /* FIXME: Special case for NV12! We should make this nicer... */
 160         if (pix->pixelformat == V4L2_PIX_FMT_NV12)
 161                 pix->sizeimage += (pix->bytesperline * pix->height) / 2;
 162
 163         return bpl - min_bpl;
 164 }
 165
 166 static void iss_video_pix_to_mbus(const struct v4l2_pix_format *pix,
 167                                   struct v4l2_mbus_framefmt *mbus)
 168 {
 169         unsigned int i;
 170
 171         memset(mbus, 0, sizeof(*mbus));
 172         mbus->width = pix->width;
 173         mbus->height = pix->height;
 174
 175         /* Skip the last format in the loop so that it will be selected if no
 176          * match is found.
 177          */
 178         for (i = 0; i < ARRAY_SIZE(formats) - 1; ++i) {
 179                 if (formats[i].pixelformat == pix->pixelformat)
 180                         break;
 181         }
 182
 183         mbus->code = formats[i].code;
 184         mbus->colorspace = pix->colorspace;
 185         mbus->field = pix->field;
 186 }
 187
 188 static struct v4l2_subdev *
 189 iss_video_remote_subdev(struct iss_video *video, u32 *pad)
 190 {
 191         struct media_pad *remote;
 192
 193         remote = media_entity_remote_pad(&video->pad);
 194
 195         if (!remote || !is_media_entity_v4l2_subdev(remote->entity))
 196                 return NULL;
 197
 198         if (pad)
 199                 *pad = remote->index;
 200
 201         return media_entity_to_v4l2_subdev(remote->entity);
 202 }
 203
 204 /* Return a pointer to the ISS video instance at the far end of the pipeline. */
 205 static struct iss_video *
 206 iss_video_far_end(struct iss_video *video)
 207 {
 208         struct media_entity_graph graph;
 209         struct media_entity *entity = &video->video.entity;
 210         struct media_device *mdev = entity->graph_obj.mdev;
 211         struct iss_video *far_end = NULL;
 212
 213         mutex_lock(&mdev->graph_mutex);
 214
 215         if (media_entity_graph_walk_init(&graph, mdev)) {
 216                 mutex_unlock(&mdev->graph_mutex);
 217                 return NULL;
 218         }
 219
 220         media_entity_graph_walk_start(&graph, entity);
 221
 222         while ((entity = media_entity_graph_walk_next(&graph))) {
 223                 if (entity == &video->video.entity)
 224                         continue;
 225
 226                 if (!is_media_entity_v4l2_video_device(entity))
 227                         continue;
 228
 229                 far_end = to_iss_video(media_entity_to_video_device(entity));
 230                 if (far_end->type != video->type)
 231                         break;
 232
 233                 far_end = NULL;
 234         }
 235
 236         mutex_unlock(&mdev->graph_mutex);
 237
 238         media_entity_graph_walk_cleanup(&graph);
 239
 240         return far_end;
 241 }
 242
 243 static int
 244 __iss_video_get_format(struct iss_video *video,
 245                        struct v4l2_mbus_framefmt *format)
 246 {
 247         struct v4l2_subdev_format fmt;
 248         struct v4l2_subdev *subdev;
 249         u32 pad;
 250         int ret;
 251
 252         subdev = iss_video_remote_subdev(video, &pad);
 253         if (!subdev)
 254                 return -EINVAL;
 255
 256         memset(&fmt, 0, sizeof(fmt));
 257         fmt.pad = pad;
 258         fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
 259
 260         mutex_lock(&video->mutex);
 261         ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
 262         mutex_unlock(&video->mutex);
 263
 264         if (ret)
 265                 return ret;
 266
 267         *format = fmt.format;
 268         return 0;
 269 }
 270
 271 static int
 272 iss_video_check_format(struct iss_video *video, struct iss_video_fh *vfh)
 273 {
 274         struct v4l2_mbus_framefmt format;
 275         struct v4l2_pix_format pixfmt;
 276         int ret;
 277
 278         ret = __iss_video_get_format(video, &format);
 279         if (ret < 0)
 280                 return ret;
 281
 282         pixfmt.bytesperline = 0;
 283         ret = iss_video_mbus_to_pix(video, &format, &pixfmt);
 284
 285         if (vfh->format.fmt.pix.pixelformat != pixfmt.pixelformat ||
 286             vfh->format.fmt.pix.height != pixfmt.height ||
 287             vfh->format.fmt.pix.width != pixfmt.width ||
 288             vfh->format.fmt.pix.bytesperline != pixfmt.bytesperline ||
 289             vfh->format.fmt.pix.sizeimage != pixfmt.sizeimage)
 290                 return -EINVAL;
 291
 292         return ret;
 293 }
 294
 295 /* -----------------------------------------------------------------------------
 296  * Video queue operations
 297  */
 298
 299 static int iss_video_queue_setup(struct vb2_queue *vq,
 300                                  unsigned int *count, unsigned int *num_planes,
 301                                  unsigned int sizes[], struct device *alloc_devs[])
 302 {
 303         struct iss_video_fh *vfh = vb2_get_drv_priv(vq);
 304         struct iss_video *video = vfh->video;
 305
 306         /* Revisit multi-planar support for NV12 */
 307         *num_planes = 1;
 308
 309         sizes[0] = vfh->format.fmt.pix.sizeimage;
 310         if (sizes[0] == 0)
 311                 return -EINVAL;
 312
 313         *count = min(*count, video->capture_mem / PAGE_ALIGN(sizes[0]));
 314
 315         return 0;
 316 }
 317
 318 static void iss_video_buf_cleanup(struct vb2_buffer *vb)
 319 {
 320         struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
 321         struct iss_buffer *buffer = container_of(vbuf, struct iss_buffer, vb);
 322
 323         if (buffer->iss_addr)
 324                 buffer->iss_addr = 0;
 325 }
 326
 327 static int iss_video_buf_prepare(struct vb2_buffer *vb)
 328 {
 329         struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
 330         struct iss_video_fh *vfh = vb2_get_drv_priv(vb->vb2_queue);
 331         struct iss_buffer *buffer = container_of(vbuf, struct iss_buffer, vb);
 332         struct iss_video *video = vfh->video;
 333         unsigned long size = vfh->format.fmt.pix.sizeimage;
 334         dma_addr_t addr;
 335
 336         if (vb2_plane_size(vb, 0) < size)
 337                 return -ENOBUFS;
 338
 339         addr = vb2_dma_contig_plane_dma_addr(vb, 0);
 340         if (!IS_ALIGNED(addr, 32)) {
 341                 dev_dbg(video->iss->dev,
 342                         "Buffer address must be aligned to 32 bytes boundary.\n");
 343                 return -EINVAL;
 344         }
 345
 346         vb2_set_plane_payload(vb, 0, size);
 347         buffer->iss_addr = addr;
 348         return 0;
 349 }
 350
 351 static void iss_video_buf_queue(struct vb2_buffer *vb)
 352 {
 353         struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
 354         struct iss_video_fh *vfh = vb2_get_drv_priv(vb->vb2_queue);
 355         struct iss_video *video = vfh->video;
 356         struct iss_buffer *buffer = container_of(vbuf, struct iss_buffer, vb);
 357         struct iss_pipeline *pipe = to_iss_pipeline(&video->video.entity);
 358         unsigned long flags;
 359         bool empty;
 360
 361         spin_lock_irqsave(&video->qlock, flags);
 362
 363         /* Mark the buffer is faulty and give it back to the queue immediately
 364          * if the video node has registered an error. vb2 will perform the same
 365          * check when preparing the buffer, but that is inherently racy, so we
 366          * need to handle the race condition with an authoritative check here.
 367          */
 368         if (unlikely(video->error)) {
 369                 vb2_buffer_done(vb, VB2_BUF_STATE_ERROR);
 370                 spin_unlock_irqrestore(&video->qlock, flags);
 371                 return;
 372         }
 373
 374         empty = list_empty(&video->dmaqueue);
 375         list_add_tail(&buffer->list, &video->dmaqueue);
 376
 377         spin_unlock_irqrestore(&video->qlock, flags);
 378
 379         if (empty) {
 380                 enum iss_pipeline_state state;
 381                 unsigned int start;
 382
 383                 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
 384                         state = ISS_PIPELINE_QUEUE_OUTPUT;
 385                 else
 386                         state = ISS_PIPELINE_QUEUE_INPUT;
 387
 388                 spin_lock_irqsave(&pipe->lock, flags);
 389                 pipe->state |= state;
 390                 video->ops->queue(video, buffer);
 391                 video->dmaqueue_flags |= ISS_VIDEO_DMAQUEUE_QUEUED;
 392
 393                 start = iss_pipeline_ready(pipe);
 394                 if (start)
 395                         pipe->state |= ISS_PIPELINE_STREAM;
 396                 spin_unlock_irqrestore(&pipe->lock, flags);
 397
 398                 if (start)
 399                         omap4iss_pipeline_set_stream(pipe,
 400                                                 ISS_PIPELINE_STREAM_SINGLESHOT);
 401         }
 402 }
 403
 404 static const struct vb2_ops iss_video_vb2ops = {
 405         .queue_setup    = iss_video_queue_setup,
 406         .buf_prepare    = iss_video_buf_prepare,
 407         .buf_queue      = iss_video_buf_queue,
 408         .buf_cleanup    = iss_video_buf_cleanup,
 409 };
 410
 411 /*
 412  * omap4iss_video_buffer_next - Complete the current buffer and return the next
 413  * @video: ISS video object
 414  *
 415  * Remove the current video buffer from the DMA queue and fill its timestamp,
 416  * field count and state fields before waking up its completion handler.
 417  *
 418  * For capture video nodes, the buffer state is set to VB2_BUF_STATE_DONE if no
 419  * error has been flagged in the pipeline, or to VB2_BUF_STATE_ERROR otherwise.
 420  *
 421  * The DMA queue is expected to contain at least one buffer.
 422  *
 423  * Return a pointer to the next buffer in the DMA queue, or NULL if the queue is
 424  * empty.
 425  */
 426 struct iss_buffer *omap4iss_video_buffer_next(struct iss_video *video)
 427 {
 428         struct iss_pipeline *pipe = to_iss_pipeline(&video->video.entity);
 429         enum iss_pipeline_state state;
 430         struct iss_buffer *buf;
 431         unsigned long flags;
 432
 433         spin_lock_irqsave(&video->qlock, flags);
 434         if (WARN_ON(list_empty(&video->dmaqueue))) {
 435                 spin_unlock_irqrestore(&video->qlock, flags);
 436                 return NULL;
 437         }
 438
 439         buf = list_first_entry(&video->dmaqueue, struct iss_buffer,
 440                                list);
 441         list_del(&buf->list);
 442         spin_unlock_irqrestore(&video->qlock, flags);
 443
 444         buf->vb.vb2_buf.timestamp = ktime_get_ns();
 445
 446         /* Do frame number propagation only if this is the output video node.
 447          * Frame number either comes from the CSI receivers or it gets
 448          * incremented here if H3A is not active.
 449          * Note: There is no guarantee that the output buffer will finish
 450          * first, so the input number might lag behind by 1 in some cases.
 451          */
 452         if (video == pipe->output && !pipe->do_propagation)
 453                 buf->vb.sequence =
 454                         atomic_inc_return(&pipe->frame_number);
 455         else
 456                 buf->vb.sequence = atomic_read(&pipe->frame_number);
 457
 458         vb2_buffer_done(&buf->vb.vb2_buf, pipe->error ?
 459                         VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE);
 460         pipe->error = false;
 461
 462         spin_lock_irqsave(&video->qlock, flags);
 463         if (list_empty(&video->dmaqueue)) {
 464                 spin_unlock_irqrestore(&video->qlock, flags);
 465                 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
 466                         state = ISS_PIPELINE_QUEUE_OUTPUT
 467                               | ISS_PIPELINE_STREAM;
 468                 else
 469                         state = ISS_PIPELINE_QUEUE_INPUT
 470                               | ISS_PIPELINE_STREAM;
 471
 472                 spin_lock_irqsave(&pipe->lock, flags);
 473                 pipe->state &= ~state;
 474                 if (video->pipe.stream_state == ISS_PIPELINE_STREAM_CONTINUOUS)
 475                         video->dmaqueue_flags |= ISS_VIDEO_DMAQUEUE_UNDERRUN;
 476                 spin_unlock_irqrestore(&pipe->lock, flags);
 477                 return NULL;
 478         }
 479
 480         if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && pipe->input) {
 481                 spin_lock(&pipe->lock);
 482                 pipe->state &= ~ISS_PIPELINE_STREAM;
 483                 spin_unlock(&pipe->lock);
 484         }
 485
 486         buf = list_first_entry(&video->dmaqueue, struct iss_buffer,
 487                                list);
 488         spin_unlock_irqrestore(&video->qlock, flags);
 489         buf->vb.vb2_buf.state = VB2_BUF_STATE_ACTIVE;
 490         return buf;
 491 }
 492
 493 /*
 494  * omap4iss_video_cancel_stream - Cancel stream on a video node
 495  * @video: ISS video object
 496  *
 497  * Cancelling a stream mark all buffers on the video node as erroneous and makes
 498  * sure no new buffer can be queued.
 499  */
 500 void omap4iss_video_cancel_stream(struct iss_video *video)
 501 {
 502         unsigned long flags;
 503
 504         spin_lock_irqsave(&video->qlock, flags);
 505
 506         while (!list_empty(&video->dmaqueue)) {
 507                 struct iss_buffer *buf;
 508
 509                 buf = list_first_entry(&video->dmaqueue, struct iss_buffer,
 510                                        list);
 511                 list_del(&buf->list);
 512                 vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
 513         }
 514
 515         vb2_queue_error(video->queue);
 516         video->error = true;
 517
 518         spin_unlock_irqrestore(&video->qlock, flags);
 519 }
 520
 521 /* -----------------------------------------------------------------------------
 522  * V4L2 ioctls
 523  */
 524
 525 static int
 526 iss_video_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
 527 {
 528         struct iss_video *video = video_drvdata(file);
 529
 530         strlcpy(cap->driver, ISS_VIDEO_DRIVER_NAME, sizeof(cap->driver));
 531         strlcpy(cap->card, video->video.name, sizeof(cap->card));
 532         strlcpy(cap->bus_info, "media", sizeof(cap->bus_info));
 533
 534         if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
 535                 cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
 536         else
 537                 cap->device_caps = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
 538
 539         cap->capabilities = V4L2_CAP_DEVICE_CAPS | V4L2_CAP_STREAMING
 540                           | V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VIDEO_OUTPUT;
 541
 542         return 0;
 543 }
 544
 545 static int
 546 iss_video_enum_format(struct file *file, void *fh, struct v4l2_fmtdesc *f)
 547 {
 548         struct iss_video *video = video_drvdata(file);
 549         struct v4l2_mbus_framefmt format;
 550         unsigned int index = f->index;
 551         unsigned int i;
 552         int ret;
 553
 554         if (f->type != video->type)
 555                 return -EINVAL;
 556
 557         ret = __iss_video_get_format(video, &format);
 558         if (ret < 0)
 559                 return ret;
 560
 561         for (i = 0; i < ARRAY_SIZE(formats); ++i) {
 562                 const struct iss_format_info *info = &formats[i];
 563
 564                 if (format.code != info->code)
 565                         continue;
 566
 567                 if (index == 0) {
 568                         f->pixelformat = info->pixelformat;
 569                         strlcpy(f->description, info->description,
 570                                 sizeof(f->description));
 571                         return 0;
 572                 }
 573
 574                 index--;
 575         }
 576
 577         return -EINVAL;
 578 }
 579
 580 static int
 581 iss_video_get_format(struct file *file, void *fh, struct v4l2_format *format)
 582 {
 583         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 584         struct iss_video *video = video_drvdata(file);
 585
 586         if (format->type != video->type)
 587                 return -EINVAL;
 588
 589         mutex_lock(&video->mutex);
 590         *format = vfh->format;
 591         mutex_unlock(&video->mutex);
 592
 593         return 0;
 594 }
 595
 596 static int
 597 iss_video_set_format(struct file *file, void *fh, struct v4l2_format *format)
 598 {
 599         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 600         struct iss_video *video = video_drvdata(file);
 601         struct v4l2_mbus_framefmt fmt;
 602
 603         if (format->type != video->type)
 604                 return -EINVAL;
 605
 606         mutex_lock(&video->mutex);
 607
 608         /* Fill the bytesperline and sizeimage fields by converting to media bus
 609          * format and back to pixel format.
 610          */
 611         iss_video_pix_to_mbus(&format->fmt.pix, &fmt);
 612         iss_video_mbus_to_pix(video, &fmt, &format->fmt.pix);
 613
 614         vfh->format = *format;
 615
 616         mutex_unlock(&video->mutex);
 617         return 0;
 618 }
 619
 620 static int
 621 iss_video_try_format(struct file *file, void *fh, struct v4l2_format *format)
 622 {
 623         struct iss_video *video = video_drvdata(file);
 624         struct v4l2_subdev_format fmt;
 625         struct v4l2_subdev *subdev;
 626         u32 pad;
 627         int ret;
 628
 629         if (format->type != video->type)
 630                 return -EINVAL;
 631
 632         subdev = iss_video_remote_subdev(video, &pad);
 633         if (!subdev)
 634                 return -EINVAL;
 635
 636         iss_video_pix_to_mbus(&format->fmt.pix, &fmt.format);
 637
 638         fmt.pad = pad;
 639         fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
 640         ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
 641         if (ret)
 642                 return ret;
 643
 644         iss_video_mbus_to_pix(video, &fmt.format, &format->fmt.pix);
 645         return 0;
 646 }
 647
 648 static int
 649 iss_video_get_param(struct file *file, void *fh, struct v4l2_streamparm *a)
 650 {
 651         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 652         struct iss_video *video = video_drvdata(file);
 653
 654         if (video->type != V4L2_BUF_TYPE_VIDEO_OUTPUT ||
 655             video->type != a->type)
 656                 return -EINVAL;
 657
 658         memset(a, 0, sizeof(*a));
 659         a->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
 660         a->parm.output.capability = V4L2_CAP_TIMEPERFRAME;
 661         a->parm.output.timeperframe = vfh->timeperframe;
 662
 663         return 0;
 664 }
 665
 666 static int
 667 iss_video_set_param(struct file *file, void *fh, struct v4l2_streamparm *a)
 668 {
 669         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 670         struct iss_video *video = video_drvdata(file);
 671
 672         if (video->type != V4L2_BUF_TYPE_VIDEO_OUTPUT ||
 673             video->type != a->type)
 674                 return -EINVAL;
 675
 676         if (a->parm.output.timeperframe.denominator == 0)
 677                 a->parm.output.timeperframe.denominator = 1;
 678
 679         vfh->timeperframe = a->parm.output.timeperframe;
 680
 681         return 0;
 682 }
 683
 684 static int
 685 iss_video_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *rb)
 686 {
 687         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 688
 689         return vb2_reqbufs(&vfh->queue, rb);
 690 }
 691
 692 static int
 693 iss_video_querybuf(struct file *file, void *fh, struct v4l2_buffer *b)
 694 {
 695         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 696
 697         return vb2_querybuf(&vfh->queue, b);
 698 }
 699
 700 static int
 701 iss_video_qbuf(struct file *file, void *fh, struct v4l2_buffer *b)
 702 {
 703         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 704
 705         return vb2_qbuf(&vfh->queue, b);
 706 }
 707
 708 static int
 709 iss_video_expbuf(struct file *file, void *fh, struct v4l2_exportbuffer *e)
 710 {
 711         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 712
 713         return vb2_expbuf(&vfh->queue, e);
 714 }
 715
 716 static int
 717 iss_video_dqbuf(struct file *file, void *fh, struct v4l2_buffer *b)
 718 {
 719         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 720
 721         return vb2_dqbuf(&vfh->queue, b, file->f_flags & O_NONBLOCK);
 722 }
 723
 724 /*
 725  * Stream management
 726  *
 727  * Every ISS pipeline has a single input and a single output. The input can be
 728  * either a sensor or a video node. The output is always a video node.
 729  *
 730  * As every pipeline has an output video node, the ISS video objects at the
 731  * pipeline output stores the pipeline state. It tracks the streaming state of
 732  * both the input and output, as well as the availability of buffers.
 733  *
 734  * In sensor-to-memory mode, frames are always available at the pipeline input.
 735  * Starting the sensor usually requires I2C transfers and must be done in
 736  * interruptible context. The pipeline is started and stopped synchronously
 737  * to the stream on/off commands. All modules in the pipeline will get their
 738  * subdev set stream handler called. The module at the end of the pipeline must
 739  * delay starting the hardware until buffers are available at its output.
 740  *
 741  * In memory-to-memory mode, starting/stopping the stream requires
 742  * synchronization between the input and output. ISS modules can't be stopped
 743  * in the middle of a frame, and at least some of the modules seem to become
 744  * busy as soon as they're started, even if they don't receive a frame start
 745  * event. For that reason frames need to be processed in single-shot mode. The
 746  * driver needs to wait until a frame is completely processed and written to
 747  * memory before restarting the pipeline for the next frame. Pipelined
 748  * processing might be possible but requires more testing.
 749  *
 750  * Stream start must be delayed until buffers are available at both the input
 751  * and output. The pipeline must be started in the videobuf queue callback with
 752  * the buffers queue spinlock held. The modules subdev set stream operation must
 753  * not sleep.
 754  */
 755 static int
 756 iss_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
 757 {
 758         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 759         struct iss_video *video = video_drvdata(file);
 760         struct media_entity_graph graph;
 761         struct media_entity *entity = &video->video.entity;
 762         enum iss_pipeline_state state;
 763         struct iss_pipeline *pipe;
 764         struct iss_video *far_end;
 765         unsigned long flags;
 766         int ret;
 767
 768         if (type != video->type)
 769                 return -EINVAL;
 770
 771         mutex_lock(&video->stream_lock);
 772
 773         /* Start streaming on the pipeline. No link touching an entity in the
 774          * pipeline can be activated or deactivated once streaming is started.
 775          */
 776         pipe = entity->pipe
 777              ? to_iss_pipeline(entity) : &video->pipe;
 778         pipe->external = NULL;
 779         pipe->external_rate = 0;
 780         pipe->external_bpp = 0;
 781
 782         ret = media_entity_enum_init(&pipe->ent_enum, entity->graph_obj.mdev);
 783         if (ret)
 784                 goto err_graph_walk_init;
 785
 786         ret = media_entity_graph_walk_init(&graph, entity->graph_obj.mdev);
 787         if (ret)
 788                 goto err_graph_walk_init;
 789
 790         if (video->iss->pdata->set_constraints)
 791                 video->iss->pdata->set_constraints(video->iss, true);
 792
 793         ret = media_entity_pipeline_start(entity, &pipe->pipe);
 794         if (ret < 0)
 795                 goto err_media_entity_pipeline_start;
 796
 797         media_entity_graph_walk_start(&graph, entity);
 798         while ((entity = media_entity_graph_walk_next(&graph)))
 799                 media_entity_enum_set(&pipe->ent_enum, entity);
 800
 801         /* Verify that the currently configured format matches the output of
 802          * the connected subdev.
 803          */
 804         ret = iss_video_check_format(video, vfh);
 805         if (ret < 0)
 806                 goto err_iss_video_check_format;
 807
 808         video->bpl_padding = ret;
 809         video->bpl_value = vfh->format.fmt.pix.bytesperline;
 810
 811         /* Find the ISS video node connected at the far end of the pipeline and
 812          * update the pipeline.
 813          */
 814         far_end = iss_video_far_end(video);
 815
 816         if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
 817                 state = ISS_PIPELINE_STREAM_OUTPUT | ISS_PIPELINE_IDLE_OUTPUT;
 818                 pipe->input = far_end;
 819                 pipe->output = video;
 820         } else {
 821                 if (!far_end) {
 822                         ret = -EPIPE;
 823                         goto err_iss_video_check_format;
 824                 }
 825
 826                 state = ISS_PIPELINE_STREAM_INPUT | ISS_PIPELINE_IDLE_INPUT;
 827                 pipe->input = video;
 828                 pipe->output = far_end;
 829         }
 830
 831         spin_lock_irqsave(&pipe->lock, flags);
 832         pipe->state &= ~ISS_PIPELINE_STREAM;
 833         pipe->state |= state;
 834         spin_unlock_irqrestore(&pipe->lock, flags);
 835
 836         /* Set the maximum time per frame as the value requested by userspace.
 837          * This is a soft limit that can be overridden if the hardware doesn't
 838          * support the request limit.
 839          */
 840         if (video->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
 841                 pipe->max_timeperframe = vfh->timeperframe;
 842
 843         video->queue = &vfh->queue;
 844         INIT_LIST_HEAD(&video->dmaqueue);
 845         video->error = false;
 846         atomic_set(&pipe->frame_number, -1);
 847
 848         ret = vb2_streamon(&vfh->queue, type);
 849         if (ret < 0)
 850                 goto err_iss_video_check_format;
 851
 852         /* In sensor-to-memory mode, the stream can be started synchronously
 853          * to the stream on command. In memory-to-memory mode, it will be
 854          * started when buffers are queued on both the input and output.
 855          */
 856         if (!pipe->input) {
 857                 unsigned long flags;
 858
 859                 ret = omap4iss_pipeline_set_stream(pipe,
 860                                               ISS_PIPELINE_STREAM_CONTINUOUS);
 861                 if (ret < 0)
 862                         goto err_omap4iss_set_stream;
 863                 spin_lock_irqsave(&video->qlock, flags);
 864                 if (list_empty(&video->dmaqueue))
 865                         video->dmaqueue_flags |= ISS_VIDEO_DMAQUEUE_UNDERRUN;
 866                 spin_unlock_irqrestore(&video->qlock, flags);
 867         }
 868
 869         media_entity_graph_walk_cleanup(&graph);
 870
 871         mutex_unlock(&video->stream_lock);
 872
 873         return 0;
 874
 875 err_omap4iss_set_stream:
 876         vb2_streamoff(&vfh->queue, type);
 877 err_iss_video_check_format:
 878         media_entity_pipeline_stop(&video->video.entity);
 879 err_media_entity_pipeline_start:
 880         if (video->iss->pdata->set_constraints)
 881                 video->iss->pdata->set_constraints(video->iss, false);
 882         video->queue = NULL;
 883
 884         media_entity_graph_walk_cleanup(&graph);
 885
 886 err_graph_walk_init:
 887         media_entity_enum_cleanup(&pipe->ent_enum);
 888
 889         mutex_unlock(&video->stream_lock);
 890
 891         return ret;
 892 }
 893
 894 static int
 895 iss_video_streamoff(struct file *file, void *fh, enum v4l2_buf_type type)
 896 {
 897         struct iss_video_fh *vfh = to_iss_video_fh(fh);
 898         struct iss_video *video = video_drvdata(file);
 899         struct iss_pipeline *pipe = to_iss_pipeline(&video->video.entity);
 900         enum iss_pipeline_state state;
 901         unsigned long flags;
 902
 903         if (type != video->type)
 904                 return -EINVAL;
 905
 906         mutex_lock(&video->stream_lock);
 907
 908         if (!vb2_is_streaming(&vfh->queue))
 909                 goto done;
 910
 911         /* Update the pipeline state. */
 912         if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
 913                 state = ISS_PIPELINE_STREAM_OUTPUT
 914                       | ISS_PIPELINE_QUEUE_OUTPUT;
 915         else
 916                 state = ISS_PIPELINE_STREAM_INPUT
 917                       | ISS_PIPELINE_QUEUE_INPUT;
 918
 919         spin_lock_irqsave(&pipe->lock, flags);
 920         pipe->state &= ~state;
 921         spin_unlock_irqrestore(&pipe->lock, flags);
 922
 923         /* Stop the stream. */
 924         omap4iss_pipeline_set_stream(pipe, ISS_PIPELINE_STREAM_STOPPED);
 925         vb2_streamoff(&vfh->queue, type);
 926         video->queue = NULL;
 927
 928         media_entity_enum_cleanup(&pipe->ent_enum);
 929
 930         if (video->iss->pdata->set_constraints)
 931                 video->iss->pdata->set_constraints(video->iss, false);
 932         media_entity_pipeline_stop(&video->video.entity);
 933
 934 done:
 935         mutex_unlock(&video->stream_lock);
 936         return 0;
 937 }
 938
 939 static int
 940 iss_video_enum_input(struct file *file, void *fh, struct v4l2_input *input)
 941 {
 942         if (input->index > 0)
 943                 return -EINVAL;
 944
 945         strlcpy(input->name, "camera", sizeof(input->name));
 946         input->type = V4L2_INPUT_TYPE_CAMERA;
 947
 948         return 0;
 949 }
 950
 951 static int
 952 iss_video_g_input(struct file *file, void *fh, unsigned int *input)
 953 {
 954         *input = 0;
 955
 956         return 0;
 957 }
 958
 959 static int
 960 iss_video_s_input(struct file *file, void *fh, unsigned int input)
 961 {
 962         return input == 0 ? 0 : -EINVAL;
 963 }
 964
 965 static const struct v4l2_ioctl_ops iss_video_ioctl_ops = {
 966         .vidioc_querycap                = iss_video_querycap,
 967         .vidioc_enum_fmt_vid_cap        = iss_video_enum_format,
 968         .vidioc_g_fmt_vid_cap           = iss_video_get_format,
 969         .vidioc_s_fmt_vid_cap           = iss_video_set_format,
 970         .vidioc_try_fmt_vid_cap         = iss_video_try_format,
 971         .vidioc_g_fmt_vid_out           = iss_video_get_format,
 972         .vidioc_s_fmt_vid_out           = iss_video_set_format,
 973         .vidioc_try_fmt_vid_out         = iss_video_try_format,
 974         .vidioc_g_parm                  = iss_video_get_param,
 975         .vidioc_s_parm                  = iss_video_set_param,
 976         .vidioc_reqbufs                 = iss_video_reqbufs,
 977         .vidioc_querybuf                = iss_video_querybuf,
 978         .vidioc_qbuf                    = iss_video_qbuf,
 979         .vidioc_expbuf                  = iss_video_expbuf,
 980         .vidioc_dqbuf                   = iss_video_dqbuf,
 981         .vidioc_streamon                = iss_video_streamon,
 982         .vidioc_streamoff               = iss_video_streamoff,
 983         .vidioc_enum_input              = iss_video_enum_input,
 984         .vidioc_g_input                 = iss_video_g_input,
 985         .vidioc_s_input                 = iss_video_s_input,
 986 };
 987
 988 /* -----------------------------------------------------------------------------
 989  * V4L2 file operations
 990  */
 991
 992 static int iss_video_open(struct file *file)
 993 {
 994         struct iss_video *video = video_drvdata(file);
 995         struct iss_video_fh *handle;
 996         struct vb2_queue *q;
 997         int ret = 0;
 998
 999         handle = kzalloc(sizeof(*handle), GFP_KERNEL);
1000         if (!handle)
1001                 return -ENOMEM;
1002
1003         v4l2_fh_init(&handle->vfh, &video->video);
1004         v4l2_fh_add(&handle->vfh);
1005
1006         /* If this is the first user, initialise the pipeline. */
1007         if (!omap4iss_get(video->iss)) {
1008                 ret = -EBUSY;
1009                 goto done;
1010         }
1011
1012         ret = v4l2_pipeline_pm_use(&video->video.entity, 1);
1013         if (ret < 0) {
1014                 omap4iss_put(video->iss);
1015                 goto done;
1016         }
1017
1018         q = &handle->queue;
1019
1020         q->type = video->type;
1021         q->io_modes = VB2_MMAP | VB2_DMABUF;
1022         q->drv_priv = handle;
1023         q->ops = &iss_video_vb2ops;
1024         q->mem_ops = &vb2_dma_contig_memops;
1025         q->buf_struct_size = sizeof(struct iss_buffer);
1026         q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
1027         q->dev = video->iss->dev;
1028
1029         ret = vb2_queue_init(q);
1030         if (ret) {
1031                 omap4iss_put(video->iss);
1032                 goto done;
1033         }
1034
1035         memset(&handle->format, 0, sizeof(handle->format));
1036         handle->format.type = video->type;
1037         handle->timeperframe.denominator = 1;
1038
1039         handle->video = video;
1040         file->private_data = &handle->vfh;
1041
1042 done:
1043         if (ret < 0) {
1044                 v4l2_fh_del(&handle->vfh);
1045                 kfree(handle);
1046         }
1047
1048         return ret;
1049 }
1050
1051 static int iss_video_release(struct file *file)
1052 {
1053         struct iss_video *video = video_drvdata(file);
1054         struct v4l2_fh *vfh = file->private_data;
1055         struct iss_video_fh *handle = to_iss_video_fh(vfh);
1056
1057         /* Disable streaming and free the buffers queue resources. */
1058         iss_video_streamoff(file, vfh, video->type);
1059
1060         v4l2_pipeline_pm_use(&video->video.entity, 0);
1061
1062         /* Release the videobuf2 queue */
1063         vb2_queue_release(&handle->queue);
1064
1065         v4l2_fh_del(vfh);
1066         kfree(handle);
1067         file->private_data = NULL;
1068
1069         omap4iss_put(video->iss);
1070
1071         return 0;
1072 }
1073
1074 static unsigned int iss_video_poll(struct file *file, poll_table *wait)
1075 {
1076         struct iss_video_fh *vfh = to_iss_video_fh(file->private_data);
1077
1078         return vb2_poll(&vfh->queue, file, wait);
1079 }
1080
1081 static int iss_video_mmap(struct file *file, struct vm_area_struct *vma)
1082 {
1083         struct iss_video_fh *vfh = to_iss_video_fh(file->private_data);
1084
1085         return vb2_mmap(&vfh->queue, vma);
1086 }
1087
1088 static struct v4l2_file_operations iss_video_fops = {
1089         .owner = THIS_MODULE,
1090         .unlocked_ioctl = video_ioctl2,
1091         .open = iss_video_open,
1092         .release = iss_video_release,
1093         .poll = iss_video_poll,
1094         .mmap = iss_video_mmap,
1095 };
1096
1097 /* -----------------------------------------------------------------------------
1098  * ISS video core
1099  */
1100
1101 static const struct iss_video_operations iss_video_dummy_ops = {
1102 };
1103
1104 int omap4iss_video_init(struct iss_video *video, const char *name)
1105 {
1106         const char *direction;
1107         int ret;
1108
1109         switch (video->type) {
1110         case V4L2_BUF_TYPE_VIDEO_CAPTURE:
1111                 direction = "output";
1112                 video->pad.flags = MEDIA_PAD_FL_SINK;
1113                 break;
1114         case V4L2_BUF_TYPE_VIDEO_OUTPUT:
1115                 direction = "input";
1116                 video->pad.flags = MEDIA_PAD_FL_SOURCE;
1117                 break;
1118
1119         default:
1120                 return -EINVAL;
1121         }
1122
1123         ret = media_entity_pads_init(&video->video.entity, 1, &video->pad);
1124         if (ret < 0)
1125                 return ret;
1126
1127         spin_lock_init(&video->qlock);
1128         mutex_init(&video->mutex);
1129         atomic_set(&video->active, 0);
1130
1131         spin_lock_init(&video->pipe.lock);
1132         mutex_init(&video->stream_lock);
1133
1134         /* Initialize the video device. */
1135         if (!video->ops)
1136                 video->ops = &iss_video_dummy_ops;
1137
1138         video->video.fops = &iss_video_fops;
1139         snprintf(video->video.name, sizeof(video->video.name),
1140                  "OMAP4 ISS %s %s", name, direction);
1141         video->video.vfl_type = VFL_TYPE_GRABBER;
1142         video->video.release = video_device_release_empty;
1143         video->video.ioctl_ops = &iss_video_ioctl_ops;
1144         video->pipe.stream_state = ISS_PIPELINE_STREAM_STOPPED;
1145
1146         video_set_drvdata(&video->video, video);
1147
1148         return 0;
1149 }
1150
1151 void omap4iss_video_cleanup(struct iss_video *video)
1152 {
1153         media_entity_cleanup(&video->video.entity);
1154         mutex_destroy(&video->stream_lock);
1155         mutex_destroy(&video->mutex);
1156 }
1157
1158 int omap4iss_video_register(struct iss_video *video, struct v4l2_device *vdev)
1159 {
1160         int ret;
1161
1162         video->video.v4l2_dev = vdev;
1163
1164         ret = video_register_device(&video->video, VFL_TYPE_GRABBER, -1);
1165         if (ret < 0)
1166                 dev_err(video->iss->dev,
1167                         "could not register video device (%d)\n", ret);
1168
1169         return ret;
1170 }
1171
1172 void omap4iss_video_unregister(struct iss_video *video)
1173 {
1174         video_unregister_device(&video->video);
1175 }