gdb/ChangeLog

   1 2019-11-05  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-source.h (struct tui_source_window): Inline
   4         constructor.  Remove destructor.
   5         <style_changed, m_observable>: Move to superclass.
   6         * tui/tui-winsource.h (tui_copy_source_line): Declare.
   7         (struct tui_source_window_base): Move private members to end.
   8         <style_changed, m_observable>: Move from tui_source_window.
   9         * tui/tui-winsource.c (tui_copy_source_line): Move from
  10         tui-source.c.  Rename from copy_source_line.  Add special handling
  11         for negative line number.
  12         (tui_source_window_base::style_changed): Move from
  13         tui_source_window.
  14         (tui_source_window_base): Register observer.
  15         (~tui_source_window_base): New.
  16         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
  17         rename.
  18         (tui_source_window::set_contents): Use tui_copy_source_line.
  19         (tui_source_window::tui_source_window): Move to tui-source.h.
  20         (tui_source_window::~tui_source_window): Remove.
  21         (tui_source_window::style_changed): Move to superclass.
  22         * tui/tui-disasm.c (tui_disassemble): Create string file with
  23         styling, when possible.  Add "addr_size" parameter.
  24         (tui_disasm_window::set_contents): Use tui_copy_source_line.
  25         Don't compute maximum size.
  26         (len_without_escapes): New function
  27
  28 2019-11-05  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
  31         std::string.
  32         * tui/tui-winsource.c (tui_show_source_line): Update.
  33         * tui/tui-source.c (tui_source_window::set_contents): Update.
  34         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  35
  36 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * symtab.h (gdb_static_assert): Put && operator at the beginning
  39         of the line instead of the end.
  40
  41 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
  42
  43         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
  44         and sizeof (symbol).
  45         * symtab.h: Add a static_assert for sizeof (partial_symbol).
  46
  47 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  48
  49         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
  50         * configure.host: Mark *-*-solaris2.10* obsolete.
  51         * configure.tgt: Mark Solaris < 11 obsolete.
  52         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
  53         Update target triplet.
  54
  55 2019-11-01  Tom Tromey  <tromey@adacore.com>
  56
  57         * utils.c (print_sys_errmsg): Simplify.
  58
  59 2019-11-01  Tom Tromey  <tromey@adacore.com>
  60
  61         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
  62
  63 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * configure: Regenerate.
  66         * configure.ac: Remove check for strerror_r.
  67         * gdbsupport/common.m4: Check for strerror_r.
  68
  69 2019-11-01  Luis Machado  <luis.machado@linaro.org>
  70
  71         PR gdb/25124
  72
  73         * arm-tdep.c (arm_per_objfile): Rename to ...
  74         (arm_per_bfd): ... this.
  75         (arm_objfile_data_key): Rename to ...
  76         (arm_bfd_data_key): ... this.
  77         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
  78         data.
  79         (arm_record_special_symbol): Likewise.
  80
  81 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
  84         end.
  85         * c-typeprint.c (c_print_typedef): Likewise.
  86         * f-typeprint.c (f_print_typedef): Likewise.
  87         * m2-typeprint.c (m2_print_typedef): Likewise.
  88         * p-typeprint.c (pascal_print_typedef): Likewise.
  89         * rust-lang.c (rust_print_typedef): Likewise.
  90         * symtab.c (print_symbol_info): Print a newline after calling
  91         typedef_print.
  92
  93 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * symtab.c (info_module_cmdlist): New variable.
  96         (info_module_command): New function.
  97         (search_module_symbols): New function.
  98         (info_module_subcommand): New function.
  99         (struct info_modules_var_func_options): New struct.
 100         (info_modules_var_func_options_defs): New variable.
 101         (make_info_modules_var_func_options_def_group): New function.
 102         (info_module_functions_command): New function.
 103         (info_module_variables_command): New function.
 104         (info_module_var_func_command_completer): New function.
 105         (_initialize_symtab): Register new 'info module functions' and
 106         'info module variables' commands.
 107         * symtab.h (typedef symbol_search_in_module): New typedef.
 108         (search_module_symbols): Declare new function.
 109         * NEWS: Mention new commands.
 110
 111 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 114         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 115         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 116         MODULES_DOMAIN.
 117         (scan_partial_symbols): Only create partial module symbols for non
 118         declarations.
 119         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 120         and MODULES_DOMAIN.
 121         * symtab.c (search_domain_name): Likewise.
 122         (search_symbols): Likewise.
 123         (print_symbol_info): Likewise.
 124         (symtab_symbol_info): Likewise.
 125         (info_modules_command): New function.
 126         (_initialize_symtab): Register 'info modules' command.
 127         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 128         * NEWS: Mention new 'info modules' command.
 129
 130 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 131
 132         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 133         and $_gdb_maint_setting_str.
 134
 135 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136
 137         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 138         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 139         (str_value_from_setting, gdb_setting_str_internal_fn)
 140         (gdb_maint_setting_str_internal_fn): New functions.
 141         (_initialize_cli_cmds): Define the new convenience functions.
 142         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 143         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 144
 145 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 146
 147         * agent.c (set_can_use_agent): When the setting is turned on,
 148         look up agent symbols if we don't have them yet.
 149         (agent_new_objfile): Don't look up agent symbols when the agent
 150         setting is off.
 151
 152 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 153
 154         * config.in: Regenerate.
 155
 156 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * configure: Regenerate.
 159         * configure.ac: Check for strerror_r.
 160         * gdbsupport/common-utils.h (safe_strerror): Change return value
 161         to const char * and document that this function is now threadsafe.
 162         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 163         thread_local and call strerror_r, if available.
 164         * utils.c (perror_string): Update.
 165         (print_sys_errmsg): Update.
 166
 167 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 168
 169         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 170         objfile_key.
 171         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 172         objfile to fetch per-bfd data.
 173         (arm_find_exidx_entry): Likewise.
 174
 175 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * gdbsupport/agent.c (debug_agent): Change type to bool.
 178         (use_agent): Likewise.
 179         (all_agent_symbols_look_up): Likewise.
 180         (agent_loaded_p): Change return value to bool.
 181         (agent_look_up_symbols): Update.
 182         (agent_capability_check): Change return value to bool.
 183         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 184         (debug_agent): Change type to bool.
 185         (use_agent): Likewise.
 186         (agent_capability_check): Change return value to bool.
 187
 188 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 191         (build_minimal_symbol_hash_tables): Code to clear the table moved
 192         to clear_minimal_symbol_hash_tables.
 193         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 194         when needed.
 195
 196 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 197
 198         * infcmd.c: Remove includes.
 199         * infrun.c: Remove includes.
 200
 201 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 202
 203         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 204         (grow_vect): Remove declaration.
 205         (ada_type_of_array): Remove declaration.
 206         (ada_update_initial_language): Remove declaration.
 207         (ada_fold_name): Remove declaration.
 208         (ada_fill_in_ada_prototype): Remove declaration.
 209         (user_select_syms): Remove declaration.
 210         (get_selections): Remove declaration.
 211         (ada_tag_type): Remove declaration.
 212         (ada_value_tag): Remove declaration.
 213         (ada_is_others_clause): Remove declaration.
 214         (ada_in_variant): Remove declaration.
 215         (ada_value_struct_elt): Remove declaration.
 216         (ada_attribute_name): Remove declaration.
 217         (ada_system_address_type): Remove declaration.
 218         * ada-lang.c (ada_watch_location_expression): Make static.
 219         (GROW_VECT): Move here from ada-lang.h.
 220         (grow_vect): Make static.
 221         (ada_update_initial_language): Make static.
 222         (ada_fold_name): Make static.
 223         (ada_type_of_array): Make static.
 224         (encoded_ordered_before): Move up.
 225         (sort_choices): Move up.
 226         (print_signatures): Move up.
 227         (ada_print_symbol_signature): Move up.
 228         (get_selections): Move up and make static.
 229         (user_select_syms): Move up and make static.
 230         (ada_value_struct_elt): Move up and make static.
 231         (ada_tag_type): Make static.
 232         (ada_value_tag): Make static.
 233         (ada_is_others_clause): Make static.
 234         (ada_in_variant): Make static.
 235         (ada_attribute_name): Make static.
 236
 237 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 238
 239         * ada-lang.c: Remove includes.
 240         * ada-typeprint.c: Remove includes.
 241         * ada-valprint.c: Remove includes.
 242
 243 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 244
 245         * addrmap.c: Add static assertions of type size, moved from
 246         _initialize_addrmap.
 247         (_initialize_addrmap): Remove.
 248
 249 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * coffread.c (record_minimal_symbol): Update.
 252         (process_coff_symbol): Update.
 253         * dbxread.c (read_dbx_symtab): Update.
 254         * dwarf2read.c (add_partial_symbol): Update.
 255         (fixup_go_packaging): Update.
 256         (load_partial_dies): Update.
 257         (new_symbol): Update.
 258         * elfread.c (record_minimal_symbol): Change signature to use
 259         gdb::string_view instead of name+len.
 260         (elf_symtab_read): Update.
 261         (elf_rel_plt_read): Update.
 262         * mdebugread.c (parse_partial_symbols): Update.
 263         (handle_psymbol_enumerators): Update.
 264         (new_symbol): Update.
 265         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 266         to use gdb::string_view instead of name+len.
 267         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 268         * psympriv.h (add_psymbol_to_list): Likewise.
 269         * psymtab.c (add_psymbol_to_bcache): Likewise.
 270         (add_psymbol_to_list): Likewise.
 271         * stabsread.c (define_symbol): Update.
 272         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 273         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 274         (symbol_set_names): Likewise.
 275         * xcoffread.c (scan_xcoff_symtab): Update.
 276
 277 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * symtab.h (symbol_set_names): Document that copy_name must be
 280         set to true for non-nullterminated strings.
 281         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 282         linkage_name if the entry was not found and we need to demangle.
 283
 284 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 285
 286         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 287         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 288         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 289         * gdbsupport/gdb_binary_search.h: New file.
 290
 291 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 292
 293         * NEWS: Mention new --with-system-gdbinit-dir option.
 294         * config.in: Regenerate.
 295         * configure: Regenerate.
 296         * configure.ac: Add new option --with-system-gdbinit-dir.
 297         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 298         for a ".gdb" suffix.
 299         * main.c (get_init_files): Change system_gdbinit argument to
 300         a vector and return the files in SYSTEM_GDBINIT_DIR in
 301         addition to SYSTEM_GDBINIT.
 302         (captured_main_1): Update.
 303         (print_gdb_help): Update.
 304         * top.c (print_gdb_configuration): Also print the value of
 305         SYSTEM_GDBINIT_DIR.
 306
 307 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 310         that takes gdb::string_view arguments.
 311
 312 2019-10-26  Tom de Vries  <tdevries@suse.de>
 313
 314         * aarch64-linux-tdep.c: Fix typos in comments.
 315         * aarch64-tdep.c: Same.
 316         * ada-lang.c: Same.
 317         * amd64-nat.c: Same.
 318         * arc-tdep.c: Same.
 319         * arch/aarch64-insn.c: Same.
 320         * block.c: Same.
 321         * breakpoint.h: Same.
 322         * btrace.h: Same.
 323         * c-varobj.c: Same.
 324         * cli/cli-decode.c: Same.
 325         * cli/cli-script.c: Same.
 326         * cli/cli-utils.h: Same.
 327         * coff-pe-read.c: Same.
 328         * coffread.c: Same.
 329         * compile/compile-cplus-symbols.c: Same.
 330         * compile/compile-object-run.c: Same.
 331         * completer.c: Same.
 332         * corelow.c: Same.
 333         * cp-support.c: Same.
 334         * demangle.c: Same.
 335         * dwarf-index-write.c: Same.
 336         * dwarf2-frame.c: Same.
 337         * dwarf2-frame.h: Same.
 338         * eval.c: Same.
 339         * frame-base.h: Same.
 340         * frame.h: Same.
 341         * gdbcmd.h: Same.
 342         * gdbtypes.h: Same.
 343         * gnu-nat.c: Same.
 344         * guile/scm-objfile.c: Same.
 345         * i386-tdep.c: Same.
 346         * i386-tdep.h: Same.
 347         * infcall.c: Same.
 348         * infcall.h: Same.
 349         * linux-nat.c: Same.
 350         * m68k-tdep.c: Same.
 351         * macroexp.c: Same.
 352         * memattr.c: Same.
 353         * mi/mi-cmd-disas.c: Same.
 354         * mi/mi-getopt.h: Same.
 355         * mi/mi-main.c: Same.
 356         * minsyms.c: Same.
 357         * nat/aarch64-sve-linux-sigcontext.h: Same.
 358         * objfiles.h: Same.
 359         * ppc-linux-nat.c: Same.
 360         * ppc-linux-tdep.c: Same.
 361         * ppc-tdep.h: Same.
 362         * progspace.h: Same.
 363         * prologue-value.h: Same.
 364         * python/py-evtregistry.c: Same.
 365         * python/py-instruction.h: Same.
 366         * record-btrace.c: Same.
 367         * record-full.c: Same.
 368         * remote.c: Same.
 369         * rs6000-tdep.c: Same.
 370         * ser-tcp.c: Same.
 371         * sol-thread.c: Same.
 372         * sparc-sol2-tdep.c: Same.
 373         * sparc64-tdep.c: Same.
 374         * stabsread.c: Same.
 375         * symfile.c: Same.
 376         * symtab.h: Same.
 377         * target.c: Same.
 378         * tracepoint.c: Same.
 379         * tui/tui-data.h: Same.
 380         * tui/tui-io.c: Same.
 381         * tui/tui-win.c: Same.
 382         * tui/tui.c: Same.
 383         * unittests/rsp-low-selftests.c: Same.
 384         * user-regs.h: Same.
 385         * utils.c: Same.
 386         * utils.h: Same.
 387         * valarith.c: Same.
 388         * valops.c: Same.
 389         * valprint.c: Same.
 390         * valprint.h: Same.
 391         * value.c: Same.
 392         * value.h: Same.
 393         * varobj.c: Same.
 394         * x86-nat.h: Same.
 395         * xtensa-tdep.c: Same.
 396
 397 2019-10-25  Ali Tamur <tamur@google.com>
 398
 399         * charset.c (find_charset_names): Reflect API change.
 400
 401 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * symtab.c (struct demangled_name_entry): Change demangled name
 404         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 405         part of the struct anymore.
 406         (symbol_set_names): No longer obstack allocate + copy the demangled
 407         name, just store the allocated name from bfd.
 408
 409 2019-10-25  Tom Tromey  <tromey@adacore.com>
 410
 411         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 412         (bsearch_cie_cmp, add_cie): Remove.
 413         (find_cie): Reimplement.
 414         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 415         (dwarf2_build_frame_info): Update.
 416
 417 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 418
 419         PR gdb/25126
 420         * symfile.c (reread_symbols): Call forget_cached_source_info to
 421         clear the stale source cache.
 422
 423 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 424
 425         * configure: Regenerate.
 426         * configure.ac: Remove code that sets python_has_threads.
 427
 428 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * config.in: Regenerate.
 431         * configure: Regenerate.
 432         * configure.ac: Remove the code that uses sed to get the python
 433         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 434
 435 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 438         error paths.
 439
 440 2019-10-23  Tom Tromey  <tom@tromey.com>
 441
 442         * arc-tdep.c: Remove ".." from include.
 443         * frv-tdep.c: Remove ".." from include.
 444         * lm32-tdep.c: Remove ".." from include.
 445         * microblaze-tdep.c: Remove ".." from include.
 446         * or1k-tdep.h: Remove ".." from include.
 447         * s12z-tdep.c: Remove ".." from include.
 448         * Makefile.in (OPCODES_CFLAGS): Add comment.
 449         (TOP_CFLAGS): New variable.
 450         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 451
 452 2019-10-23  Tom Tromey  <tom@tromey.com>
 453
 454         * Makefile.in (READLINE_DIR): Update.
 455
 456 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 457
 458         * infcall.c (call_function_by_hand_dummy): Fix the function
 459         comment.  And extract out a code section into...
 460         (reserve_stack_space): ...this new function.
 461
 462 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 463
 464         * infcall.c (value_arg_coerce): Remove an unused parameter.
 465         (call_function_by_hand_dummy): Update the call to
 466         'value_arg_coerce'.
 467
 468 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 469
 470         * infcall.c (call_function_by_hand_dummy): Refactor.
 471
 472 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 473
 474         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 475
 476 2019-10-23  Tom Tromey  <tom@tromey.com>
 477
 478         * configure: Rebuild.
 479         * configure.ac: Don't check for sigprocmask.
 480         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 481
 482 2019-10-23  Tom Tromey  <tom@tromey.com>
 483
 484         * configure: Rebuild.
 485         * acinclude.m4: Use m4_include, not sinclude.
 486
 487 2019-10-23  Tom de Vries  <tdevries@suse.de>
 488
 489         PR breakpoints/24687
 490         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 491
 492 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * symtab.c (struct demangled_name_entry) <language>: Change from
 495         bitfield to regular variable.
 496
 497 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 498
 499         * symtab.c (struct demangled_name_entry): Add a constructor.
 500         (free_demangled_name_entry): New function to call the destructor
 501         for demangled_name_entry.
 502         (create_demangled_names_hash): Pass free_demangled_name_entry to
 503         htab_create_alloc.
 504         (symbol_set_names): Call placement new for demangled_name_entry.
 505         * utils.c: No longer include xxhash.h here, now that fast_hash
 506         is inlined in the header.
 507         * utils.h: Instead, include it here.
 508
 509 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 510
 511         * Makefile.in: Link with libxxhash.
 512         * config.in: Regenerate.
 513         * configure: Regenerate.
 514         * configure.ac: Search for libxxhash.
 515         * utils.c (fast_hash): Use xxhash if present.
 516
 517 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 518
 519         * utils.h (fast_hash): New function.
 520         * symtab.c (hash_demangled_name_entry): Call new function
 521         fast_hash.
 522
 523 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * symtab.c (struct demangled_name_entry): Change type of mangled
 526         to gdb::string_view. Also adds a constructor that takes the
 527         mangled name.
 528         (hash_demangled_name_entry): Update.
 529         (eq_demangled_name_entry): Update.
 530         (free_demangled_name_entry): New function to call the destructor
 531         now that this is not a POD anymore.
 532         (create_demangled_names_hash): Pass free_demangled_name_entry to
 533         htab_create_alloc.
 534         (symbol_set_names): Update.
 535
 536 2019-10-21  Ali Tamur  <tamu@google.com>
 537
 538         * dwarf2read.c (dir_index): Change type.
 539         (file_name_index): Likewise.
 540         (line_header::include_dir_at): Change comment and implementation on
 541         whether it is DWARF 5.
 542         (line_header::is_valid_file_index): New function.
 543         (line_header::file_name_at): Change comment and implementation on
 544         whether it is DWARF 5.
 545         (line_header::file_names): Change to private field renamed as
 546         m_file_names and introduce a new accessor method.
 547         (line_header::file_names_size): New method.
 548         (line_header::include_dirs): Change to private field and rename as
 549         m_include_dirs.
 550         (dw2_get_file_names_reader): Define local var at a smaller scope and
 551         reflect API change.
 552         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 553         (process_structure_scope): Likewise.
 554         (line_header::add_include_dir): Change message and reflect renaming.
 555         (line_header::add_file_name): Likewise.
 556         (read_formatted_entries): Handle DW_FORM_data16.
 557         (dwarf_decode_line_header): Fix line header length calculation.
 558         (psymtab_include_file_name): Change comment and API.
 559         (lnp_state_machine::m_file): Update comment and reflect type change.
 560         (lnp_state_machine::record_line): Reflect type change.
 561         (dwarf_decode_lines): Reflect API change.
 562         (file_file_name): Likewise.
 563         (file_full_name): Likewise.
 564
 565 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 568
 569 2019-10-21  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 572
 573 2019-10-21  Tom Tromey  <tom@tromey.com>
 574
 575         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 576         NM_H.   Use AC_CONFIG_LINKS.
 577         * configure: Rebuild.
 578         * Makefile.in (NM_H): New variable.
 579         (generated_files): Add NM_H.  Remove gcore.
 580         (nm.h, stamp-nmh): New targets.
 581
 582 2019-10-20  Tom Tromey  <tom@tromey.com>
 583
 584         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 585         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 586         obsolete comment.
 587         (put_objfile_before): Now static.
 588
 589 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 590
 591         * gdbsupport/common-utils.h (startswith): Change return type to
 592         bool.
 593
 594 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 595
 596         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 597         * breakpoint.c (bp_locations_compare): Rename to...
 598         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 599         (update_global_location_list): Use std::sort instead of qsort.
 600         * buildsym.c (compare_line_numbers): Rename to...
 601         (lte_is_less_than): ...this, and change to std::sort semantics.
 602         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 603         instead of qsort.
 604         * disasm.c (compare_lines): Rename to...
 605         (line_is_less_than): ...this, and change to std::sort semantics.
 606         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 607         of qsort.
 608         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 609         (fde_is_less_than): ...this, and change to std::sort semantics.
 610         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 611         * mdebugread.c (compare_blocks):
 612         (block_is_less_than): ...this, and change to std::sort semantics.
 613         (sort_blocks): Call std::sort instead of qsort.
 614         * objfiles.c (qsort_cmp): Rename to...
 615         (sort_cmp): ...this, and change to std::sort semantics.
 616         (update_section_map): Call std::sort instead of qsort.
 617         * remote.c (compare_pnums): Remove.
 618         (map_regcache_remote_table): Call std::sort instead of qsort.
 619         * utils.c (compare_positive_ints): Remove.
 620         * utils.h (compare_positive_ints): Remove.
 621         * xcoffread.c (compare_lte): Remove.
 622         (arrange_linetable): Call std::sort instead of qsort.
 623
 624 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 625
 626         * symfile.c (init_entry_point_info): Fix typo.
 627         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 628
 629 2019-10-18  Tom de Vries  <tdevries@suse.de>
 630
 631         * aarch64-tdep.c: Fix typos in comments.
 632         * ada-lang.c: Same.
 633         * ada-tasks.c: Same.
 634         * alpha-tdep.c: Same.
 635         * alpha-tdep.h: Same.
 636         * amd64-nat.c: Same.
 637         * amd64-windows-tdep.c: Same.
 638         * arc-tdep.c: Same.
 639         * arc-tdep.h: Same.
 640         * arch-utils.c: Same.
 641         * arm-nbsd-tdep.c: Same.
 642         * arm-tdep.c: Same.
 643         * ax-gdb.c: Same.
 644         * blockframe.c: Same.
 645         * btrace.c: Same.
 646         * c-varobj.c: Same.
 647         * coff-pe-read.c: Same.
 648         * coffread.c: Same.
 649         * cris-tdep.c: Same.
 650         * darwin-nat.c: Same.
 651         * dbxread.c: Same.
 652         * dcache.c: Same.
 653         * disasm.c: Same.
 654         * dtrace-probe.c: Same.
 655         * dwarf-index-write.c: Same.
 656         * dwarf2-frame-tailcall.c: Same.
 657         * dwarf2-frame.c: Same.
 658         * dwarf2read.c: Same.
 659         * eval.c: Same.
 660         * exceptions.c: Same.
 661         * fbsd-tdep.c: Same.
 662         * findvar.c: Same.
 663         * frame.c: Same.
 664         * frv-tdep.c: Same.
 665         * gnu-v3-abi.c: Same.
 666         * go32-nat.c: Same.
 667         * h8300-tdep.c: Same.
 668         * hppa-tdep.c: Same.
 669         * i386-linux-tdep.c: Same.
 670         * i386-tdep.c: Same.
 671         * ia64-libunwind-tdep.c: Same.
 672         * ia64-tdep.c: Same.
 673         * infcmd.c: Same.
 674         * infrun.c: Same.
 675         * linespec.c: Same.
 676         * linux-nat.c: Same.
 677         * linux-thread-db.c: Same.
 678         * machoread.c: Same.
 679         * mdebugread.c: Same.
 680         * mep-tdep.c: Same.
 681         * mn10300-tdep.c: Same.
 682         * namespace.c: Same.
 683         * objfiles.c: Same.
 684         * opencl-lang.c: Same.
 685         * or1k-tdep.c: Same.
 686         * osabi.c: Same.
 687         * ppc-linux-nat.c: Same.
 688         * ppc-linux-tdep.c: Same.
 689         * ppc-sysv-tdep.c: Same.
 690         * printcmd.c: Same.
 691         * procfs.c: Same.
 692         * record-btrace.c: Same.
 693         * record-full.c: Same.
 694         * remote-fileio.c: Same.
 695         * remote.c: Same.
 696         * rs6000-tdep.c: Same.
 697         * s12z-tdep.c: Same.
 698         * score-tdep.c: Same.
 699         * ser-base.c: Same.
 700         * ser-go32.c: Same.
 701         * skip.c: Same.
 702         * sol-thread.c: Same.
 703         * solib-svr4.c: Same.
 704         * solib.c: Same.
 705         * source.c: Same.
 706         * sparc-nat.c: Same.
 707         * sparc-sol2-tdep.c: Same.
 708         * sparc-tdep.c: Same.
 709         * sparc64-tdep.c: Same.
 710         * stabsread.c: Same.
 711         * stack.c: Same.
 712         * symfile.c: Same.
 713         * symtab.c: Same.
 714         * target-descriptions.c: Same.
 715         * target-float.c: Same.
 716         * thread.c: Same.
 717         * utils.c: Same.
 718         * valops.c: Same.
 719         * valprint.c: Same.
 720         * value.c: Same.
 721         * varobj.c: Same.
 722         * windows-nat.c: Same.
 723         * xcoffread.c: Same.
 724         * xstormy16-tdep.c: Same.
 725         * xtensa-tdep.c: Same.
 726
 727 2019-10-17  Tom Tromey  <tromey@adacore.com>
 728
 729         * configure: Rebuild.
 730         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 731         in AC_CONFIG_FILES invocation.
 732         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 733         new-style config.status invocation.
 734
 735 2019-10-17  Tom de Vries  <tdevries@suse.de>
 736
 737         * arm-nbsd-nat.c: Fix typos in comments.
 738         * arm-tdep.c: Same.
 739         * darwin-nat-info.c: Same.
 740         * dwarf2read.c: Same.
 741         * elfread.c: Same.
 742         * event-top.c: Same.
 743         * findvar.c: Same.
 744         * gdbtypes.c: Same.
 745         * hppa-tdep.c: Same.
 746         * i386-tdep.c: Same.
 747         * jit.c: Same.
 748         * main.c: Same.
 749         * mdebugread.c: Same.
 750         * moxie-tdep.c: Same.
 751         * nto-procfs.c: Same.
 752         * osabi.c: Same.
 753         * ppc-linux-tdep.c: Same.
 754         * remote.c: Same.
 755         * riscv-tdep.c: Same.
 756         * s390-tdep.c: Same.
 757         * sh-tdep.c: Same.
 758         * sparc-linux-tdep.c: Same.
 759         * sparc-nat.c: Same.
 760         * stack.c: Same.
 761         * target-descriptions.c: Same.
 762         * top.c: Same.
 763         * varobj.c: Same.
 764
 765 2019-10-16  Tom Tromey  <tom@tromey.com>
 766
 767         * objfiles.h (struct objfile) <original_name>: Now const.
 768
 769 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 772         pass on to sigsetjmp's second argument.
 773         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 774
 775 2019-10-16  Keith Seitz  <keiths@redhat.com>
 776
 777         PR gdb/23567
 778         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 779         sections whose size is greater than the file size.
 780
 781 2019-10-16  Jim Wilson  <jimw@sifive.com>
 782
 783         * riscv-tdep.c (riscv_gcc_target_options): New.
 784         (riscv_gnu_triplet_regexp): New.
 785         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 786         set_gdbarch_gnu_triplet_regexp.
 787
 788 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 789
 790         * Makefile.in: Add xml-builtin.h.
 791         * features/feature_to_c.sh: Add an include for xml-builtin.h
 792         to ensure that the compiler checks that the types match.
 793         * xml-builtin.h: New file.
 794         * xml-support.c (fetch_xml_builtin): Add missing const.
 795         * xml-support.h: Remove declaration of xml_builtins.
 796
 797 2019-10-16  Tom de Vries  <tdevries@suse.de>
 798
 799         PR tdep/25096
 800         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 801         (amd64_classify_aggregate): ... here.
 802         (amd64_classify_aggregate_field): Handled fiels of nested structs
 803         recursively.
 804
 805 2019-10-16  Tom de Vries  <tdevries@suse.de>
 806
 807         PR tdep/24104
 808         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 809         that handles 'theclass'.
 810
 811 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * linespec.c (decode_digits_ordinary): Update comment.
 814         * make-target-delegates: No longer need to handle VEC case.
 815         * memrange.c (normalize_mem_ranges): Update comment.
 816         * namespace.c (add_using_directive): Update comment.
 817         * objc-lang.c (uniquify_strings): Update comment.
 818         * ppc-linux-nat.c (struct thread_points): Update comment.
 819         * probe.h (find_probes_in_objfile): Update comment.
 820         * target.h (enum flash_preserve_mode): Update comment.
 821         * varobj.c (varobj_restrict_range): Update comment.
 822         * varobj.h (varobj_list_children): Update comment.
 823
 824 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * Makefile.in: Remove references to vec.h and vec.c.
 827         * aarch64-tdep.c: No longer include vec.h.
 828         * ada-lang.c: Likewise.
 829         * ada-lang.h: Likewise.
 830         * arm-tdep.c: Likewise.
 831         * ax.h: Likewise.
 832         * breakpoint.h: Likewise.
 833         * charset.c: Likewise.
 834         * cp-support.h: Likewise.
 835         * dtrace-probe.c: Likewise.
 836         * dwarf2read.c: Likewise.
 837         * extension.h: Likewise.
 838         * gdb_bfd.c: Likewise.
 839         * gdbsupport/gdb_vecs.h: Likewise.
 840         * gdbsupport/vec.c: Remove.
 841         * gdbsupport/vec.h: Remove.
 842         * gdbthread.h: Likewise.
 843         * guile/scm-type.c: Likewise.
 844         * inline-frame.c: Likewise.
 845         * machoread.c: Likewise.
 846         * memattr.c: Likewise.
 847         * memrange.h: Likewise.
 848         * namespace.h: Likewise.
 849         * nat/linux-btrace.h: Likewise.
 850         * osdata.c: Likewise.
 851         * parser-defs.h: Likewise.
 852         * progspace.h: Likewise.
 853         * python/py-type.c: Likewise.
 854         * record-btrace.c: Likewise.
 855         * rust-exp.y: Likewise.
 856         * solib-target.c: Likewise.
 857         * stap-probe.c: Likewise.
 858         * target-descriptions.c: Likewise.
 859         * target-memory.c: Likewise.
 860         * target.h: Likewise.
 861         * varobj.c: Likewise.
 862         * varobj.h: Likewise.
 863         * xml-support.h: Likewise.
 864
 865 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 868         Update for new std::vector based implementation.
 869         (process_psymtab_comp_unit_reader): Likewise.
 870         (scan_partial_symbols): Likewise.
 871         (recursively_compute_inclusions): Likewise.
 872         (compute_compunit_symtab_includes): Likewise.
 873         (process_imported_unit_die): Likewise.
 874         (queue_and_load_dwo_tu): Likewise.
 875         (follow_die_sig_1): Likewise.
 876         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 877         (typedef dwarf2_per_cu_ptr): Remove.
 878         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 879         function.
 880         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 881         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 882         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 883         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 884         std::vector.
 885
 886 2019-10-15  Tom Tromey  <tromey@adacore.com>
 887
 888         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 889         TID.
 890
 891 2019-10-15  Tom Tromey  <tromey@adacore.com>
 892
 893         * windows-nat.c (windows_nat_target::fetch_registers)
 894         (windows_nat_target::store_registers): Rename "pid" to "tid".
 895
 896 2019-10-15  Tom Tromey  <tromey@adacore.com>
 897
 898         * gdbarch.h, gdbarch.c: Rebuild.
 899         * gdbarch.sh (gcc_target_options): Change return type to
 900         std::string.
 901         * compile/compile.c (get_args): Update.
 902         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 903         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 904         std::string.
 905         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 906         std::string.
 907         * arch-utils.c (default_gcc_target_options): Return std::string.
 908         * arch-utils.h (default_gcc_target_options): Return std::string.
 909         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 910
 911 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 912
 913         * breakpoint.c (breakpoint_chain): Make static.
 914         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 915         of accessing breakpoint_chain.
 916
 917 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 918
 919         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 920         to a gdb::function_view and return value to bool.
 921         * breakpoint.h (iterate_over_breakpoints): Likewise.
 922         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 923         (pop_dummy_frame): Update.
 924         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 925         (gdbscm_breakpoints): Update.
 926         * python/py-breakpoint.c (build_bp_list): Update.
 927         (gdbpy_breakpoints): Update.
 928         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 929         Update.
 930         (bpfinishpy_handle_stop): Update.
 931         (bpfinishpy_handle_exit): Update.
 932         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 933         (svr4_update_solib_event_breakpoints): Update.
 934
 935 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 936
 937         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 938         when unwrapping single-field structs.
 939
 940 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * dwarf2read.c: Remove includes.
 943
 944 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 945
 946         * ui-out.c (ui_out::call_do_message): Silence
 947         -Wformat-nonliteral warning.
 948
 949 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 950
 951         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 952         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 953         include: readline/tilde.h.
 954
 955 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 956
 957         * remote.c (remote_target::get_trace_status): Remove declaration of
 958         trace_regblock_size.
 959
 960 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 961
 962         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 963         (show_user): Remove declaration of cmdlist.
 964         * cli/cli-cmds.h (max_user_call_depth): Declare.
 965         * cli/cli-script.c (execute_user_command): Remove declaration
 966         of max_user_call_depth.
 967
 968 2019-10-11  Jim Wilson  <jimw@sifive.com>
 969
 970         * gdbsupport/print-utils.h (pulongest): Fix comment.
 971         (plongest): Likewise.
 972         (phex): Add missing comment, mention leading zeros.
 973         (phex_nz): Add mention of no leading zeros to comment.
 974
 975         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 976         plongest instead of unsigned long long cast.
 977
 978 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 979
 980         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 981         for external_editor_command and gdbtk_test.
 982
 983 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 984
 985         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 986         * varobj.c (varobjdebug): Move comment to...
 987         * varobj.h (varobjdebug): ...here, and declare.
 988
 989 2019-10-09  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 992         erase_data_content.
 993
 994 2019-10-09  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 997         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 998         * tui/tui-command.c (tui_cmd_window::resize)
 999         (tui_refresh_cmd_win): Update.
1000         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1001         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1002         * tui/tui-data.c (~tui_gen_win_info): Remove.
1003         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1004         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1005         (tui_redisplay_readline, tui_mld_flush)
1006         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1007         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1008         (tui_data_window::erase_data_content)
1009         (tui_data_item_window::rerender)
1010         (tui_data_item_window::refresh_window): Update.
1011         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1012         (box_win, tui_gen_win_info::make_window)
1013         (tui_gen_win_info::make_visible): Update.
1014         (tui_delete_win): Remove.
1015         * tui/tui-winsource.c
1016         (tui_source_window_base::do_erase_source_content): Update.
1017         (tui_show_source_line, tui_source_window_base::update_tab_width)
1018         (tui_source_window_base::update_exec_info): Update.
1019         * tui/tui-data.h (struct curses_deleter): New.
1020         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1021         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1022
1023 2019-10-09  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1026
1027 2019-10-09  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1030         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1031
1032 2019-10-09  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1035         window height directly.
1036         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1037         declare.
1038         * tui/tui-layout.c (tui_default_win_height): Remove.
1039         (tui_default_win_viewport_height): Remove.
1040
1041 2019-10-09  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui.h: Remove comments.
1044
1045 2019-10-09  Tom de Vries  <tdevries@suse.de>
1046
1047         * python/lib/gdb/printer/bound_registers.py: Use
1048         '^builtin_type_bound128' as regexp argument for
1049         add_builtin_pretty_printer.
1050
1051 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * guile/guile.c (guile_extension_script_ops): Remove forward
1054         declaration and mark as static.
1055         (guile_script_ops): Likewise.
1056         (extension_language_guile): Move further down in the file so
1057         it can reference the definitions for guile_{extension_,}script_ops.
1058
1059 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1060
1061         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1062         except SORTL, DFLTCC, and KDSA.
1063
1064 2019-10-08  Tom Tromey  <tromey@adacore.com>
1065
1066         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1067         (struct safe_symbol_file_add_args): Remove.
1068
1069 2019-10-08  Tom Tromey  <tromey@adacore.com>
1070
1071         * windows-nat.c: Don't include buildsym-legacy.h.
1072
1073 2019-10-08  Tom Tromey  <tromey@adacore.com>
1074
1075         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1076
1077 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1078
1079         * gdbtypes.c (overload_debug): Move comment to header.
1080         * gdbtypes.h (overload_debug): Declare.
1081         * valops.c: Remove declaration of overload_debug, instead
1082         include gdbtypes.h.
1083
1084 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1085
1086         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1087         through _().
1088         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1089         move comment...
1090         * language.h (lang_frame_mismatch_warn): ... here. Also add
1091         declaration.
1092         * top.c (lang_frame_mismatch_warn): Remove declaration.
1093         (check_frame_language_change): Pass lang_frame_mismatch_warn
1094         through _().
1095
1096 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1097
1098         * c-lang.h (vtbl_ptr_name): Declare.
1099         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1100         it from the header.
1101         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1102
1103 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1104
1105         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1106         gdb_static_assert.
1107
1108 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1109
1110         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1111         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1112         * ctfread.c: New file.
1113         * ctfread.h: New file.
1114         * elfread.c: Include ctfread.h.
1115         (struct elfinfo text_p): New member ctfsect.
1116         (elf_locate_sections): Mark CTF section.
1117         (elf_symfile_read): Call elfctf_build_psymtabs.
1118         * Makefile.in (LIBCTF): Add.
1119         (CLIBS): Use it.
1120         (CDEPS): Likewise.
1121         (DIST): Add ctfread.c.
1122
1123 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * ctfread.c (struct nextfield): Renamed to ...
1126         (struct ctf_nextfield): ... this.
1127         (struct field_info): Renamed to ...
1128         (strut ctf_field_info): ... this.
1129         (attach_fields_to_type): Update for renamed structures.
1130         (ctf_add_member_cb): Likewise.
1131         (ctf_add_enum_member_cb): Likewise.
1132         (process_struct_members): Likewise.
1133         (process_enum_type): Likewise.
1134
1135 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1136
1137         * tracectf.h: Rename, was ctf.h.
1138         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1139         * tracefile.c: Likewise.
1140         * tracepoint.c: Remove unused include ctf.h.
1141         * mi/mi-main.c: Likewise.
1142         * Makefile.in Replace ctf.c with tracectf.c.
1143
1144 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1145
1146         * version.in: Change version number to "9.0.50.DATE-git".
1147
1148 2019-10-03  Tom Tromey  <tom@tromey.com>
1149
1150         PR rust/24976:
1151         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1152
1153 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1156         cp_search_name_hash.
1157         * NEWS: Add entry about nested function support.
1158
1159 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1160             Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1163         for nested static variables when searchin VAR_DOMAIN.
1164         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1165         global scope, update comment.
1166         (add_partial_subprogram): Call add_partial_subprogram recursively
1167         for nested subroutines when processinng Fortran.
1168         (load_partial_dies): Process the child entities of a subprogram
1169         when processing Fortran.
1170         (partial_die_parent_scope): Handle building scope
1171         for Fortran nested functions.
1172         (process_die): Record that nested functions have a scope.
1173         (new_symbol): Always record Fortran subprograms on the global
1174         symbol list.
1175         (determine_prefix): How to build the prefix for Fortran
1176         subprograms.
1177
1178 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1181         have just sent the thread a SIGSTOP and are waiting for it to
1182         arrive.
1183
1184 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * btrace.c (btrace_add_pc): Remove whitespace before the template
1187         parameter in 'std::vector <...>'.
1188         (parse_xml_btrace_block): Likewise.
1189         (btrace_maint_decode_pt): Likewise.
1190         (btrace_maint_update_packets): Likewise.
1191         (btrace_maint_print_packets): Likewise.
1192         * btrace.h (struct btrace_maint_info): Likewise.
1193         * dwarf2read.c (struct type_unit_group): Likewise.
1194         (build_type_psymtabs_reader): Likewise.
1195         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1196         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1197         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1198
1199 2019-10-03  Tom de Vries  <tdevries@suse.de>
1200
1201         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1202         the first line of the help text for set/show style metadata.
1203
1204 2019-10-02  Tom Tromey  <tromey@adacore.com>
1205
1206         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1207         * gdbsupport/common-inferior.c: New file.
1208         * infcmd.c (startup_with_shell): Don't define.
1209         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1210         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1211         * inferior.h (startup_with_shell): Don't declare.
1212
1213 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1214
1215         * gdbsupport/gdb_assert.h: Include errors.h.
1216         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1217
1218 2019-10-02  Tom Tromey  <tromey@adacore.com>
1219
1220         * NEWS: Add $_ada_exception entry.
1221         * ada-lang.c (struct ada_catchpoint): Add constructor.
1222         <m_kind>: New member.
1223         (allocate_location_exception, re_set_exception): Remove
1224         "ex" parameter.
1225         (should_stop_exception): Compute $_ada_exception.
1226         (check_status_exception, print_it_exception)
1227         (print_one_exception, print_mention_exception): Remove
1228         "ex" parameter.
1229         (allocate_location_catch_exception, re_set_catch_exception)
1230         (check_status_exception, print_it_catch_exception)
1231         (print_one_catch_exception, print_mention_catch_exception)
1232         (print_recreate_catch_exception)
1233         (allocate_location_catch_exception_unhandled)
1234         (re_set_catch_exception_unhandled)
1235         (check_status_exception, print_it_catch_exception_unhandled)
1236         (print_one_catch_exception_unhandled)
1237         (print_mention_catch_exception_unhandled)
1238         (print_recreate_catch_exception_unhandled)
1239         (allocate_location_catch_assert, re_set_catch_assert)
1240         (check_status_assert, print_it_catch_assert)
1241         (print_one_catch_assert, print_mention_catch_assert)
1242         (print_recreate_catch_assert)
1243         (allocate_location_catch_handlers, re_set_catch_handlers)
1244         (check_status_handlers, print_it_catch_handlers)
1245         (print_one_catch_handlers, print_mention_catch_handlers)
1246         (print_recreate_catch_handlers): Remove.
1247         (create_ada_exception_catchpoint): Update.
1248         (initialize_ada_catchpoint_ops): Update.
1249
1250 2019-10-02  Tom Tromey  <tromey@adacore.com>
1251
1252         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1253         (create_excep_cond_exprs): Simplify exception string computation.
1254         (ada_exception_catchpoint_cond_string): Likewise.
1255
1256 2019-10-02  Tom Tromey  <tromey@adacore.com>
1257
1258         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1259         * ada-lang.c (lesseq_defined_than): Handle
1260         LOC_STATIC.
1261         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1262         parameter.
1263         (dwarf2_has_info): Likewise.
1264         (new_symbol): Set maybe_copied on symbol when
1265         appropriate.
1266         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1267         parameter.
1268         <can_copy>: New member.
1269         * elfread.c (record_minimal_symbol): Set maybe_copied
1270         on symbol when appropriate.
1271         (elf_symfile_read): Update call to dwarf2_has_info.
1272         * minsyms.c (lookup_minimal_symbol_linkage): New
1273         function.
1274         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1275         * symtab.c (get_symbol_address, get_msymbol_address):
1276         New functions.
1277         * symtab.h (get_symbol_address, get_msymbol_address):
1278         Declare.
1279         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1280         maybe_copied.
1281         (struct symbol, struct minimal_symbol) <maybe_copied>:
1282         New member.
1283
1284 2019-10-02  Tom Tromey  <tromey@adacore.com>
1285
1286         * source.c (struct current_source_location): New.
1287         (current_source_key): New global.
1288         (current_source_symtab, current_source_line)
1289         (current_source_pspace): Remove.
1290         (get_source_location): New function.
1291         (get_current_source_symtab_and_line)
1292         (set_default_source_symtab_and_line)
1293         (set_current_source_symtab_and_line)
1294         (clear_current_source_symtab_and_line, select_source_symtab)
1295         (info_source_command, print_source_lines_base)
1296         (info_line_command, search_command_helper, _initialize_source):
1297         Update.
1298
1299 2019-10-02  Tom Tromey  <tromey@adacore.com>
1300
1301         * source.c (select_source_symtab): Don't call
1302         decode_line_with_current_source.
1303
1304 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * symtab.c (lookup_global_symbol): Search global block.
1307
1308 2019-10-02  Tom Tromey  <tromey@adacore.com>
1309
1310         * coffread.c (process_coff_symbol): Update.
1311         * dwarf2read.c (var_decode_location, new_symbol): Update.
1312         * mdebugread.c (parse_symbol): Update.
1313         * objfiles.c (relocate_one_symbol): Update.
1314         * stabsread.c (define_symbol, fix_common_block)
1315         (scan_file_globals): Update.
1316         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1317         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1318         * xcoffread.c (process_xcoff_symbol): Update.
1319
1320 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1321
1322         * MAINTAINERS: Update my email address.
1323
1324 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1327         std::vector.
1328         (build_type_psymtabs_reader): Update for std::vector.
1329         (build_type_psymtab_dependencies): Likewise.
1330         * dwarf2read.h: Remove use of DEF_VEC_P.
1331         (typedef sig_type_ptr): Delete.
1332
1333 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1336         to std::vector.
1337         (btrace_maint_decode_pt): Likewise, and move allocation of the
1338         vector outside of the loop.
1339         (btrace_maint_update_packets): Update to handle change from VEC to
1340         std::vector.
1341         (btrace_maint_print_packets): Likewise.
1342         (maint_info_btrace_cmd): Likewise.
1343         * btrace.h: Remove use of DEF_VEC_O.
1344         (typedef btrace_pt_packet_s): Delete.
1345         (struct btrace_maint_info) <packets>: Change fromm VEC to
1346         std::vector.
1347         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1348
1349 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1352         make accesses into the vector constant references.
1353         (btrace_add_pc): Update for std::vector.
1354         (btrace_stitch_bts): Likewise.
1355         (parse_xml_btrace_block): Likewise.
1356         (btrace_maint_update_packets): Likewise.
1357         (btrace_maint_print_packets): Likewise.
1358         (maint_info_btrace_cmd): Likewise.
1359         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1360         std::vector.
1361         (btrace_data::empty): Likewise.
1362         (btrace_data_append): Likewise.
1363         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1364         (typedef btrace_block_s): Delete.
1365         (struct btrace_block): Add constructor.
1366         (struct btrace_data_bts) <blocks>: Change to std::vector.
1367         * nat/linux-btrace.c (perf_event_read_bts): Update for
1368         std::vector.
1369         (linux_read_bts): Likewise.
1370
1371 2019-10-01  Tom Tromey  <tom@tromey.com>
1372
1373         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1374
1375 2019-10-01  Tom Tromey  <tom@tromey.com>
1376
1377         * stack.c (print_frame, info_frame_command_core): Use
1378         styled_string.
1379         * linux-thread-db.c (try_thread_db_load_1)
1380         (try_thread_db_load_from_pdir_1): Use styled_string.
1381         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1382         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1383         (maybe_print_unsupported_script_warning)
1384         (maybe_print_script_not_found_warning): Use styled_string.
1385         * ada-lang.c (user_select_syms): Use styled_string.
1386
1387 2019-10-01  Tom Tromey  <tom@tromey.com>
1388
1389         * p-lang.c (pascal_printstr): Use metadata style.
1390         * value.c (show_convenience): Use metadata style.
1391         * valprint.c (valprint_check_validity, val_print_optimized_out)
1392         (val_print_not_saved, val_print_unavailable)
1393         (val_print_invalid_address, generic_val_print, val_print)
1394         (value_check_printable, val_print_array_elements): Use metadata
1395         style.
1396         * ui-out.h (class ui_out) <field_fmt>: New overload.
1397         <do_field_fmt>: Add style parameter.
1398         * ui-out.c (ui_out::field_fmt): New overload.
1399         * typeprint.c (type_print_unknown_return_type)
1400         (val_print_not_allocated, val_print_not_associated): Use metadata
1401         style.
1402         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1403         parameter.
1404         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1405         * tracepoint.c (tvariables_info_1): Use metadata style.
1406         * stack.c (print_frame_arg, print_frame_info, print_frame)
1407         (info_frame_command_core): Use metadata style.
1408         * skip.c (info_skip_command): Use metadata style.
1409         * rust-lang.c (rust_print_enum): Use metadata style.
1410         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1411         metadata style.
1412         * python/py-framefilter.c (py_print_single_arg): Use metadata
1413         style.
1414         * printcmd.c (do_one_display, print_variable_and_value): Use
1415         metadata style.
1416         * p-valprint.c (pascal_val_print)
1417         (pascal_object_print_value_fields): Use metadata style.
1418         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1419         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1420         parameter.
1421         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1422         * m2-valprint.c (m2_print_long_set): Use metadata style.
1423         * m2-typeprint.c (m2_print_type): Use metadata style.
1424         * infcmd.c (print_return_value_1): Use metadata style.
1425         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1426         * f-valprint.c (info_common_command_for_block): Use metadata
1427         style.
1428         * f-typeprint.c (f_type_print_base): Use metadata style.
1429         * expprint.c (print_subexp_standard): Use metadata style.
1430         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1431         * cli/cli-style.h (class cli_style_option): Add constructor.
1432         (metadata_style): Declare.
1433         * cli/cli-style.c (metadata_style): New global.
1434         (_initialize_cli_style): Register metadata style.
1435         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1436         parameter.
1437         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1438         * c-typeprint.c (c_type_print_base_struct_union)
1439         (c_type_print_base_1): Use metadata style.
1440         * breakpoint.c (watchpoint_value_print)
1441         (print_one_breakpoint_location): Use metadata style.
1442         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1443         style.
1444         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1445         style.
1446         * ada-valprint.c (val_print_packed_array_elements, printstr)
1447         (print_field_values, ada_val_print_ref, ada_val_print): Use
1448         metadata style.
1449         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1450         style.
1451         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1452         style.
1453         * ada-lang.c (user_select_syms): Use metadata style.
1454
1455 2019-10-01  Tom Tromey  <tom@tromey.com>
1456
1457         * cli/cli-cmds.c (pwd_command): Style output.
1458
1459 2019-10-01  Pedro Alves  <palves@redhat.com>
1460             Tom Tromey  <tom@tromey.com>
1461
1462         * symtab.c (print_symbol_info): Use %ps.
1463         (print_msymbol_info): Use %ps.
1464         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1465         * printcmd.c (print_variable_and_value): Use %ps.
1466         * macrocmd.c (show_pp_source_pos): Use %ps.
1467         * infrun.c (print_exited_reason): Use ui_out::message.
1468         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1469         (describe_other_breakpoints): Use ui_out::message and new
1470         formats.
1471         (say_where): Use new formats.
1472         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1473         and new formats.
1474
1475 2019-10-01  Pedro Alves  <palves@redhat.com>
1476             Tom Tromey  <tom@tromey.com>
1477
1478         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1479         (test_gdb_formats): New function.
1480         (run_tests): Call it.
1481         (test_format_specifier): Update.
1482         * utils.h (fputs_filtered): Update comment.
1483         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1484         (fputs_styled_unfiltered): Declare.
1485         * utils.c (fputs_styled_unfiltered): New function.
1486         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1487         (vfprintf_filtered): Update.
1488         (vfprintf_unfiltered, vprintf_filtered): Update.
1489         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1490         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1491         disallow_ui_out_field>: New constants.
1492         (enum class field_kind): New.
1493         (struct base_field_s, struct signed_field_s): New.
1494         (signed_field): New function.
1495         (struct string_field_s): New.
1496         (string_field): New function.
1497         (struct styled_string_s): New.
1498         (styled_string): New function.
1499         (class ui_out) <message>: Add comment.
1500         <vmessage, call_do_message>: New methods.
1501         <do_message>: Add style parameter.
1502         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1503         methods.
1504         (ui_out::message): Rewrite.
1505         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1506         parameter.
1507         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1508         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1509         gdb_extensions parameter.
1510         (class format_piece): Add parameter to constructor.
1511         (n_int_args): New field.
1512         * gdbsupport/format.c (format_pieces::format_pieces): Add
1513         gdb_extensions parameter.  Handle '*'.
1514         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1515         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1516         vfprintf_styled_no_gdbfmt.
1517         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1518         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1519         unfiltered output.
1520         * ui-style.h (struct ui_file_style) <ptr>: New method.
1521
1522 2019-10-01  Tom Tromey  <tom@tromey.com>
1523
1524         * unittests/format_pieces-selftests.c: Update.  Add final format.
1525         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1526         empty literal pieces.
1527
1528 2019-10-01  Tom Tromey  <tom@tromey.com>
1529
1530         * ui-out.h (enum class ui_out_style_kind): Remove.
1531         (class ui_out) <field_string, field_stsream, do_field_string>:
1532         Change type of "style".
1533         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1534         (ui_out::field_string): Update.
1535         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1536         of "style".
1537         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1538         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1539         * stack.c (print_frame_arg, print_frame_info, print_frame):
1540         Update.
1541         * source.c (print_source_lines_base): Update.
1542         * solib.c (info_sharedlibrary_command): Update.
1543         * skip.c (info_skip_command): Update.
1544         * record-btrace.c (btrace_call_history_src_line)
1545         (btrace_call_history): Update.
1546         * python/py-framefilter.c (py_print_frame): Update.
1547         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1548         "style".
1549         * mi/mi-out.c (mi_ui_out::do_table_header)
1550         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1551         (mi_ui_out::do_field_string): Update.
1552         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1553         Update.
1554         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1555         "style".
1556         * cli-out.c (cli_ui_out::do_table_header)
1557         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1558         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1559         (cli_ui_out::do_field_fmt): Update.
1560         * breakpoint.c (print_breakpoint_location): Update.
1561         (update_static_tracepoint): Update.
1562
1563 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1564
1565         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1566         conversion of gdb_datadir.
1567         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1568         remove not needed c_str ().
1569
1570 2019-09-30  Ali Tamur <tamur@google.com>
1571
1572         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1573         (dwarf2_string_attr): Likewise.
1574
1575 2019-09-30  Ali Tamur <tamur@google.com>
1576
1577         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1578         (process_full_type_unit): Likewise.
1579         (dump_die_shallow): Likewise.
1580         (cu_debug_loc_section): Likewise.
1581
1582 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1583
1584         * minsyms.c (compare_minimal_symbols): Rename to...
1585         (minimal_symbol_is_less_than): ...this, and adjust to STL
1586         conventions (return bool, take arguments as references)
1587         (minimal_symbol_reader::install): Call std::sort instead
1588         of qsort.
1589
1590 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1591
1592         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1593         hash and why.
1594         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1595         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1596
1597 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1598
1599         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1600         * psympriv.h (add_psymbol_to_list): Move comment here and update
1601         it.
1602
1603 2019-09-29  Tom de Vries  <tdevries@suse.de>
1604
1605         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1606         Use $tmpdir/$(basename "$output_file").dwz instead of
1607         "${output_file}.dwz".
1608
1609 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1610
1611         PR gdb/25045
1612         * hppa-linux-nat.c: Include gdbarch.h.
1613
1614 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1615
1616         * blockframe.c (find_pc_partial_function): Change return type to bool.
1617         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1618         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1619         (stub_gnu_ifunc_resolve_name): Likewise.
1620         * symtab.c (compare_filenames_for_search): Likewise.
1621         (compare_glob_filenames_for_search): Likewise.
1622         (matching_obj_sections): Likewise.
1623         (symbol_matches_domain): Likewise.
1624         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1625         (find_line_pc): Change return type to bool.
1626         (find_line_pc_range): Likewise.
1627         (producer_is_realview): Likewise.
1628         * symtab.h (symbol_matches_domain): Likewise.
1629         (find_pc_partial_function): Likewise.
1630         (find_pc_line_pc_range): Likewise.
1631         (in_gnu_ifunc_stub): Likewise.
1632         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1633         (find_line_pc): Likewise.
1634         (find_line_pc_range): Likewise.
1635         (matching_obj_sections): Likewise.
1636         (find_line_symtab): Change out parameter to bool.
1637         (producer_is_realview): Change return type to bool.
1638         (compare_filenames_for_search): Likewise.
1639         (compare_glob_filenames_for_search): Likewise.
1640
1641 2019-09-26  Tom Tromey  <tom@tromey.com>
1642
1643         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1644         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1645         * gdb_usleep.h: Remove.
1646         * gdb_usleep.c: Remove.
1647         * utils.c: Don't include gdb_usleep.h.
1648
1649 2019-09-26  Tom Tromey  <tromey@adacore.com>
1650
1651         * python/py-type.c (type_to_type_object): Call check_typedef
1652         for stub types.
1653
1654 2019-09-26  Tom Tromey  <tom@tromey.com>
1655
1656         * utils.h (initialize_utils): Don't declare.
1657         * top.c (gdb_init): Don't call initialize_utils.
1658         * utils.c (initialize_utils): Remove.  Move contents...
1659         (_initialize_utils): ... here.
1660
1661 2019-09-25  Tom Tromey  <tom@tromey.com>
1662
1663         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1664         * utils.h (make_hex_string): Don't declare.
1665         * utils.c (make_hex_string): Remove.
1666
1667 2019-09-24  Tom de Vries  <tdevries@suse.de>
1668
1669         PR gdb/23815
1670         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1671         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1672
1673 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1674
1675         * NEWS: Mention new simulator port for PRU.
1676
1677 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1678
1679         * ada-exp.y (write_object_remaining): Update.
1680         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1681         and eliminate the static buffer.
1682         (ada_decode_symbol): Update.
1683         (ada_la_decode): Update.
1684         (ada_sniff_from_mangled_name): Update.
1685         (is_valid_name_for_wild_match): Update.
1686         (ada_lookup_name_info::matches): Update and simplify.
1687         (name_matches_regex): Update.
1688         (ada_add_global_exceptions): Update.
1689         * ada-lang.h (ada_decode): Update signature.
1690         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1691         * dwarf-index-write.c (debug_names::insert): Update.
1692
1693 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1694
1695         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1696         formatting.
1697
1698 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1699
1700         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1701         Change "nonzero" to "true" in documentation.
1702
1703 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1704
1705         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1706         (_initialize_darwin_solib): Don't set
1707         darwin_so_ops.lookup_lib_global_symbol.
1708         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1709         set_gdbarch_iterate_over_objfiles_in_search_order.
1710         (elf_lookup_lib_symbol): Rename to...
1711         (svr4_iterate_over_objfiles_in_search_order): this, and update
1712         to iterate semantics.
1713         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1714         * solib.c (solib_global_lookup): Remove.
1715         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1716         (solib_global_lookup): Remove.
1717         * symtab.c (lookup_global_or_static_symbol): Remove call to
1718         solib_global_lookup.
1719
1720 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1721
1722         * NEWS: Move entries about default MI version now being
1723         version 3, and about the GDB/MI fix for multi-location
1724         breakpoints to the "since GDB 8.3" section.
1725
1726 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1727
1728         GDB 8.3.1 released.
1729
1730 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1731
1732         * NEWS: Mention that Cell/B.E. debugging support was removed.
1733         * MAINTAINERS: Remove spu target.
1734
1735         * config/djgpp/fnchange.lst: Remove entries for removed files.
1736
1737         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1738         spu-multiarch.o, and spu-tdep.o.
1739         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1740         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1741         spu-multiarch.c, and spu-tdep.c.
1742         * spu-linux-nat.c: Remove file.
1743         * spu-multiarch.c: Remove file.
1744         * spu-tdep.c: Remove file.
1745         * spu-tdep.h: Remove file.
1746         * solib-spu.c: Remove file.
1747         * solib-spu.h: Remove file.
1748
1749         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1750         * configure.nat (spu-linux): Remove.
1751         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1752         solib-multiarch.o from gdb_target_obs.
1753         (spu*-*-*): Remove.
1754
1755         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1756         feature flag.
1757         (ppc_linux_no_features): Update.
1758         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1759         Cell/B.E. support.
1760         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1761         (tdesc_powerpc_cell64l): Likewise.
1762         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1763         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1764         Cell/B.E. support.
1765         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1766         Do not include "features/rs6000/powerpc-cell32l.c" or
1767         "features/rs6000/powerpc-cell64l.c".
1768         (ppc_linux_spu_section): Remove.
1769         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1770         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1771         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1772         (ppc_linux_spe_context_lookup): Remove.
1773         (ppc_linux_spe_context_inferior_created): Remove.
1774         (ppc_linux_spe_context_solib_loaded): Remove.
1775         (ppc_linux_spe_context_solib_unloaded): Remove.
1776         (ppc_linux_spe_context): Remove.
1777         (struct ppu2spu_cache): Remove.
1778         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1779         (struct ppu2spu_data): Remove.
1780         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1781         ppu2spu_unwind): Remove.
1782         (ppc_linux_init_abi): Remove Cell/B.E. support.
1783         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1784
1785         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1786         (rs6000/powerpc-cell64l-expedite): Likewise
1787         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1788         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1789         rs6000/powerpc-cell64l.xml.
1790         * features/rs6000/powerpc-cell32l.xml: Remove.
1791         * features/rs6000/powerpc-cell64l.xml: Likewise.
1792         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1793         * features/rs6000/powerpc-cell64l.c: Likewise.
1794         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1795         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1796         * regformats/reg-spu.dat: Remove.
1797
1798         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1799         * corelow.c (struct spuid_list): Remove.
1800         (add_to_spuid_list): Remove.
1801         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1802         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1803         (remote_protocol_features): Remove associated entries.
1804         (_initialize_remote): No longer initialize them.
1805         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1806         * linux-nat.c (SPUFS_MAGIC): Remove.
1807         (linux_proc_xfer_spu): Remove.
1808         (spu_enumerate_spu_ids): Remove.
1809         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1810         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1811         (linux_make_corefile_notes): No longer call it.
1812
1813         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1814         (cooked_write_test): Likewise.
1815
1816 2019-09-20  Tom Tromey  <tom@tromey.com>
1817
1818         * NEWS: Mention case-sensitivity of TUI commands.
1819         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1820         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1821         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1822
1823 2019-09-20  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-source.c (tui_source_window::set_contents): Use
1826         make_unique_xstrdup.
1827         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1828         make_unique_xstrdup.
1829
1830 2019-09-20  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-data.c: Remove separator comments.
1833         * tui/tui-layout.c: Remove separator comments.
1834         * tui/tui-win.c: Remove separator comments.
1835         * tui/tui-wingeneral.c: Remove separator comments.
1836
1837 2019-09-20  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui.h (strcat_to_buf): Don't declare.
1840         * tui/tui.c (strcat_to_buf): Remove.
1841
1842 2019-09-20  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1845         from "fullname".
1846         * tui/tui-source.c (tui_source_window::set_contents)
1847         (tui_source_window::location_matches_p)
1848         (tui_source_window::maybe_update): Update.
1849
1850 2019-09-20  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1853         Update.
1854         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1855         prefix.
1856         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1857         (tui_data_window::line_from_reg_element_no)
1858         (tui_data_window::first_reg_element_no_inline)
1859         (tui_data_window::show_registers)
1860         (tui_data_window::show_register_group)
1861         (tui_data_window::display_registers_from)
1862         (tui_data_window::display_registers_from_line)
1863         (tui_data_window::first_data_item_displayed)
1864         (tui_data_window::delete_data_content_windows)
1865         (tui_data_window::erase_data_content)
1866         (tui_data_window::do_scroll_vertical)
1867         (tui_data_window::refresh_window)
1868         (tui_data_window::check_register_values): Update.
1869
1870 2019-09-20  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1873         (struct tui_locator_window) <full_name, proc_name>: Now
1874         std::string.
1875         * tui/tui-stack.c (tui_locator_window::make_status_line)
1876         (tui_locator_window::set_locator_fullname)
1877         (tui_locator_window::set_locator_info): Update.
1878         * tui/tui-source.c (tui_source_window::set_contents)
1879         (tui_source_window::showing_source_p): Update.
1880
1881 2019-09-20  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1884         Don't call tui_locator_win_info_ptr.
1885
1886 2019-09-20  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1889
1890 2019-09-20  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1893         height for locator.
1894         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1895         * tui/tui-layout.c (show_source_disasm_command, show_data)
1896         (show_source_or_disasm_and_command): Use 1 as height for locator.
1897
1898 2019-09-20  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui.c (tui_enable): Update.
1901         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1902         Update.
1903         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1904         Update.
1905         * tui/tui-data.c (win_resized): Now bool.
1906         (tui_win_resized): Return bool.
1907         (tui_set_win_resized_to): Accept a bool.
1908
1909 2019-09-20  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1912         Change type of "refresh_values_only".
1913         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1914         type of "refresh_values_only".
1915
1916 2019-09-20  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1919         std::string.
1920         (tui_disassemble): Add "pos" parameter.
1921         (tui_disasm_window::set_contents): Simplify.
1922
1923 2019-09-20  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.h (struct tui_source_window_base)
1926         <show_source_content>: Now private.
1927         * tui/tui-winsource.c
1928         (tui_source_window_base::show_source_content): Don't handle empty
1929         content case.
1930
1931 2019-09-20  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-layout.c (show_source_disasm_command)
1934         (show_source_or_disasm_and_command): Don't call
1935         show_source_content.
1936
1937 2019-09-20  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1940         Declare.
1941         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1942         from tui_make_status_line.
1943         (tui_locator_window::rerender): Update.
1944
1945 2019-09-20  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1948         (tui_locator_window::rerender): Update.
1949
1950 2019-09-20  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-winsource.h (struct tui_source_window_base)
1953         <~tui_source_window_base>: Don't declare.
1954         <fullname>: Remove.
1955         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1956         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1957         member.
1958         * tui/tui-source.c (tui_source_window::set_contents): Update.
1959         (tui_source_window::location_matches_p)
1960         (tui_source_window::maybe_update): Update.
1961
1962 2019-09-20  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-winsource.h (~tui_source_element): Remove.
1965         (tui_source_element): Update.
1966         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1967         * tui/tui-winsource.c (tui_show_source_line): Update.
1968         * tui/tui-source.c (tui_source_window::set_contents): Update.
1969         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1970
1971 2019-09-20  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1974         declare.
1975         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1976         tui_clear_source_windows_detail.
1977         * tui/tui-winsource.h (struct tui_source_window_base)
1978         <clear_detail>: Don't declare.
1979         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1980         Remove.
1981         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1982
1983 2019-09-20  Tom Tromey  <tromey@adacore.com>
1984
1985         PR ada/24919:
1986         * block.c (contained_in): Fix final return value.
1987
1988 2019-09-20  Alan Modra  <amodra@gmail.com>
1989
1990         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1991         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1992         (read_indirect_string_from_dwz): Use bfd accessor.
1993         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1994         * machoread.c (macho_symfile_read_all_oso): Likewise.
1995         * solib.c (solib_bfd_open): Likewise.
1996
1997 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1998
1999         * eval.c: Move declaration of overload_resolution to...
2000         * value.h: ...here.
2001
2002 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2003
2004         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2005         * arm-linux-tdep.c: Likewise.
2006         * arm-nbsd-nat.c: Likewise.
2007         * arm-tdep.h: Declare arm_apcs_32.
2008         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2009
2010 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2011
2012         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2013         * dwarf2read.h: Declare dwarf_always_disassemble.
2014
2015 2019-09-19  Tom de Vries  <tdevries@suse.de>
2016
2017         PR gdb/25009
2018         * source-cache.c (source_cache::ensure): Catch exception thrown during
2019         construction of the highlighter.
2020
2021 2019-09-18  Alan Modra  <amodra@gmail.com>
2022
2023         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2024         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2025         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2026         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2027         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2028         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2029         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2030         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2031         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2032         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2033         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2034         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2035         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2036         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2037         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2038         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2039         * mi/mi-interp.c: Update throughout for bfd section macro and
2040         function changes.
2041         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2042         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2043
2044 2019-09-18  Tom Tromey  <tom@tromey.com>
2045
2046         * NEWS: Add entry.
2047         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2048         call rl_initialize.
2049         (tui_enable): Do not call rl_initialize.
2050
2051 2019-09-18  Christian Groessler  <chris@groessler.org>
2052
2053         * alpha-linux-nat.c: Include gdbarch.h.
2054
2055 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2056
2057         * ui-file.c: Include cli/cli-style.h.
2058         (term_cli_styling): Remove cli_styling declaration.
2059
2060 2019-09-18  Alan Modra  <amodra@gmail.com>
2061
2062         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2063         to bfd_asymbol_section.
2064
2065 2019-09-18  Alan Modra  <amodra@gmail.com>
2066
2067         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2068         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2069         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2070
2071 2019-09-18  Alan Modra  <amodra@gmail.com>
2072
2073         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2074         * spu-linux-nat.c (spu_bfd_open): Likewise.
2075
2076 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2079         to bool to match definition in dwarf2read.c.
2080
2081 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2082
2083         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2084         (print_signatures): Likewise.
2085         (trust_pad_over_xvs): Likewise.
2086         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2087         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2088         * arm-linux-nat.c (arm_apcs_32): Likewise.
2089         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2090         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2091         * arm-tdep.c (arm_debug): Likewise.
2092         (arm_apcs_32): Likewise.
2093         * auto-load.c (debug_auto_load): Likewise.
2094         (auto_load_gdb_scripts): Likewise.
2095         (global_auto_load): Likewise.
2096         (auto_load_local_gdbinit): Likewise.
2097         (auto_load_local_gdbinit_loaded): Likewise.
2098         * auto-load.h (global_auto_load): Likewise.
2099         (auto_load_local_gdbinit): Likewise.
2100         (auto_load_local_gdbinit_loaded): Likewise.
2101         * breakpoint.c (disconnected_dprintf): Likewise.
2102         (breakpoint_proceeded): Likewise.
2103         (automatic_hardware_breakpoints): Likewise.
2104         (always_inserted_mode): Likewise.
2105         (target_exact_watchpoints): Likewise.
2106         (_initialize_breakpoint): Update.
2107         * breakpoint.h (target_exact_watchpoints): Change to bool.
2108         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2109         * cli/cli-cmds.c (trace_commands): Likewise.
2110         * cli/cli-cmds.h (trace_commands): Likewise.
2111         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2112         to bool*.
2113         * cli/cli-logging.c (logging_overwrite): Change to bool.
2114         (logging_redirect): Likewise.
2115         (debug_redirect): Likewise.
2116         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2117         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2118         to bool.
2119         <boolean_option_def>: Update.
2120         (struct flag_option_def): Change default type of Context to bool
2121         from int.
2122         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2123         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2124         (get_setshow_command_value_string): Likewise.
2125         * cli/cli-style.c (cli_styling): Change to bool.
2126         (source_styling): Likewise.
2127         * cli/cli-style.h (source_styling): Likewise.
2128         (cli_styling): Likewise.
2129         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2130         to bool.
2131         * command.h (var_types): Update comment.
2132         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2133         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2134         bool.
2135         (debug_compile_cplus_scopes): Likewise.
2136         * compile/compile-internal.h (compile_debug): Likewise.
2137         * compile/compile.c (compile_debug): Likewise.
2138         (struct compile_options) <raw>: Likewise.
2139         * cp-support.c (catch_demangler_crashes): Likewise.
2140         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2141         (usr_cmd_cris_dwarf2_cfi): Likewise.
2142         * csky-tdep.c (csky_debug): Likewise.
2143         * darwin-nat.c (enable_mach_exceptions): Likewise.
2144         * dcache.c (dcache_enabled_p): Likewise.
2145         * defs.h (info_verbose): Likewise.
2146         * demangle.c (demangle): Likewise.
2147         (asm_demangle): Likewise.
2148         * dwarf-index-cache.c (debug_index_cache): Likewise.
2149         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2150         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2151         * dwarf2read.c (check_physname): Likewise.
2152         (use_deprecated_index_sections): Likewise.
2153         (dwarf_always_disassemble): Likewise.
2154         * eval.c (overload_resolution): Likewise.
2155         * event-top.c (set_editing_cmd_var): Likewise.
2156         (exec_done_display_p): Likewise.
2157         * event-top.h (set_editing_cmd_var): Likewise.
2158         (exec_done_display_p): Likewise.
2159         * exec.c (write_files): Likewise.
2160         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2161         (debug_fbsd_nat): Likewise.
2162         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2163         Likewise.
2164         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2165         <backtrace_past_entry> Likewise.
2166         * gdb-demangle.h (demangle): Likewise.
2167         (asm_demangle): Likewise.
2168         * gdb_bfd.c (bfd_sharing): Likewise.
2169         * gdbcore.h (write_files): Likewise.
2170         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2171         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2172         * gdbthread.h (print_thread_events): Likewise.
2173         * gdbtypes.c (opaque_type_resolution): Likewise.
2174         (strict_type_checking): Likewise.
2175         * gnu-nat.c (gnu_debug_flag): Likewise.
2176         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2177         * guile/scm-param.c (pascm_variable): Add boolval.
2178         (add_setshow_generic): Update.
2179         (pascm_param_value): Update.
2180         (pascm_set_param_value_x): Update.
2181         * hppa-tdep.c (hppa_debug): Change to bool..
2182         * infcall.c (may_call_functions_p): Likewise.
2183         (coerce_float_to_double_p): Likewise.
2184         (unwind_on_signal_p): Likewise.
2185         (unwind_on_terminating_exception_p): Likewise.
2186         * infcmd.c (startup_with_shell): Likewise.
2187         * inferior.c (print_inferior_events): Likewise.
2188         * inferior.h (startup_with_shell): Likewise.
2189         (print_inferior_events): Likewise.
2190         * infrun.c (step_stop_if_no_debug): Likewise.
2191         (detach_fork): Likewise.
2192         (debug_displaced): Likewise.
2193         (disable_randomization): Likewise.
2194         (non_stop): Likewise.
2195         (non_stop_1): Likewise.
2196         (observer_mode): Likewise.
2197         (observer_mode_1): Likewise.
2198         (set_observer_mode): Update.
2199         (sched_multi): Change to bool.
2200         * infrun.h (debug_displaced): Likewise.
2201         (sched_multi): Likewise.
2202         (step_stop_if_no_debug): Likewise.
2203         (non_stop): Likewise.
2204         (disable_randomization): Likewise.
2205         * linux-tdep.c (use_coredump_filter): Likewise.
2206         (dump_excluded_mappings): Likewise.
2207         * linux-thread-db.c (auto_load_thread_db): Likewise.
2208         (check_thread_db_on_load): Likewise.
2209         * main.c (captured_main_1): Update.
2210         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2211         xx2_opt, boolean_opt>: Change to bool.
2212         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2213         * maint.c (maintenance_profile_p): Likewise.
2214         (per_command_time): Likewise.
2215         (per_command_space): Likewise.
2216         (per_command_symtab): Likewise.
2217         * memattr.c (inaccessible_by_default): Likewise.
2218         * mi/mi-main.c (mi_async): Likewise.
2219         (mi_async_1): Likewise.
2220         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2221         * nat/fork-inferior.h (startup_with_shell): Likewise.
2222         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2223         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2224         * nios2-tdep.c (nios2_debug): Likewise.
2225         * or1k-tdep.c (or1k_debug): Likewise.
2226         * parse.c (parser_debug): Likewise.
2227         * parser-defs.h (parser_debug): Likewise.
2228         * printcmd.c (print_symbol_filename): Likewise.
2229         * proc-api.c (procfs_trace): Likewise.
2230         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2231         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2232         (set_parameter_value): Update.
2233         (add_setshow_generic): Update.
2234         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2235         to bool*.
2236         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2237         int*.
2238         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2239         * record-btrace.c (record_btrace_target::store_registers): Update.
2240         * record-full.c (record_full_memory_query): Change to bool.
2241         (record_full_stop_at_limit): Likewise.
2242         * record-full.h (record_full_memory_query): Likewise.
2243         * remote-notif.c (notif_debug): Likewise.
2244         * remote-notif.h (notif_debug): Likewise.
2245         * remote.c (use_range_stepping): Likewise.
2246         (interrupt_on_connect): Likewise.
2247         (remote_break): Likewise.
2248         * ser-tcp.c (tcp_auto_retry): Likewise.
2249         * ser-unix.c (serial_hwflow): Likewise.
2250         * skip.c (debug_skip): Likewise.
2251         * solib-aix.c (solib_aix_debug): Likewise.
2252         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2253         (spu_auto_flush_cache_p): Likewise.
2254         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2255         Likewise.
2256         (struct info_print_options) <quiet>: Likewise.
2257         * symfile-debug.c (debug_symfile): Likewise.
2258         * symfile.c (auto_solib_add): Likewise.
2259         (separate_debug_file_debug): Likewise.
2260         * symfile.h (auto_solib_add): Likewise.
2261         (separate_debug_file_debug): Likewise.
2262         * symtab.c (basenames_may_differ): Likewise.
2263         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2264         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2265         (struct info_types_options) <quiet>: Likewise.
2266         * symtab.h (demangle): Likewise.
2267         (basenames_may_differ): Likewise.
2268         * target-dcache.c (stack_cache_enabled_1): Likewise.
2269         (code_cache_enabled_1): Likewise.
2270         * target.c (trust_readonly): Likewise.
2271         (may_write_registers): Likewise.
2272         (may_write_memory): Likewise.
2273         (may_insert_breakpoints): Likewise.
2274         (may_insert_tracepoints): Likewise.
2275         (may_insert_fast_tracepoints): Likewise.
2276         (may_stop): Likewise.
2277         (auto_connect_native_target): Likewise.
2278         (target_stop_and_wait): Update.
2279         (target_async_permitted): Change to bool.
2280         (target_async_permitted_1): Likewise.
2281         (may_write_registers_1): Likewise.
2282         (may_write_memory_1): Likewise.
2283         (may_insert_breakpoints_1): Likewise.
2284         (may_insert_tracepoints_1): Likewise.
2285         (may_insert_fast_tracepoints_1): Likewise.
2286         (may_stop_1): Likewise.
2287         * target.h (target_async_permitted): Likewise.
2288         (may_write_registers): Likewise.
2289         (may_write_memory): Likewise.
2290         (may_insert_breakpoints): Likewise.
2291         (may_insert_tracepoints): Likewise.
2292         (may_insert_fast_tracepoints): Likewise.
2293         (may_stop): Likewise.
2294         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2295         (make_thread_apply_all_options_def_group): Change argument from int*
2296         to bool*.
2297         (thread_apply_all_command): Update.
2298         (print_thread_events): Change to bool.
2299         * top.c (confirm): Likewise.
2300         (command_editing_p): Likewise.
2301         (history_expansion_p): Likewise.
2302         (write_history_p): Likewise.
2303         (info_verbose): Likewise.
2304         * top.h (confirm): Likewise.
2305         (history_expansion_p): Likewise.
2306         * tracepoint.c (disconnected_tracing): Likewise.
2307         (circular_trace_buffer): Likewise.
2308         * typeprint.c (print_methods): Likewise.
2309         (print_typedefs): Likewise.
2310         * utils.c (debug_timestamp): Likewise.
2311         (sevenbit_strings): Likewise.
2312         (pagination_enabled): Likewise.
2313         * utils.h (sevenbit_strings): Likewise.
2314         (pagination_enabled): Likewise.
2315         * valops.c (overload_resolution): Likewise.
2316         * valprint.h (struct value_print_options) <prettyformat_arrays,
2317         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2318         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2319         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2320         Likewise.
2321         * windows-nat.c (new_console): Likewise.
2322         (cygwin_exceptions): Likewise.
2323         (new_group): Likewise.
2324         (debug_exec): Likewise.
2325         (debug_events): Likewise.
2326         (debug_memory): Likewise.
2327         (debug_exceptions): Likewise.
2328         (useshell): Likewise.
2329         * windows-tdep.c (maint_display_all_tib): Likewise.
2330         * xml-support.c (debug_xml): Likewise.
2331
2332 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2333
2334         * source.c (prepare_path_for_appending): New function.
2335         (openp): Make use of new function.
2336         (find_and_open_source): Search for the compilation directory and
2337         source file as a relative path beneath the directory search path.
2338
2339 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * source-cache.c (source_cache::get_line_charpos): Catch
2342         exceptions and return false, this matches the behaviour documented
2343         in the header file.
2344
2345 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2346
2347         * ada-tasks.c (info_task): Remove quoting of the task's name.
2348
2349 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2350
2351         * symfile.c (auto_solib_add): Replace comment with a reference
2352         to the header file.
2353
2354 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2355
2356         * NEWS: Mention that gdb can now be compiled with Python 3
2357         on Windows.
2358
2359 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * maint.c (maint_print_section_data::maint_print_section_data):
2362         Force use of 'float log10 (float)' by casting the argument to
2363         float.
2364
2365 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * maint.c: Add 'cmath' include.
2368         (struct maint_print_section_data): New structure.
2369         (print_section_index): New function.
2370         (print_bfd_section_info): Add header comment, small whitespace
2371         cleanup, and update to call new print_section_index function.
2372         (print_objfile_section_info): Likewise.
2373         (maint_obj_section_from_bfd_section): New function.
2374         (print_bfd_section_info_maybe_relocated): New function.
2375         (maintenance_info_sections): Add header comment, always use
2376         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2377
2378 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2379
2380         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2381         inner scope, add check that the objfile has psymtabs before
2382         checking psymtabs_addrmap.
2383         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2384
2385 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2386
2387         * NEWS: Announce that Ada task names are now shown at more places,
2388         and between quotes (except in info task output).
2389         * gdb/ada-tasks.c (task_to_str): New function.
2390         (display_current_task_id): Call task_to_str.
2391         (task_command_1): Likewise.
2392         (print_ada_task_info): In non-mi mode, Properly align headers and data
2393         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2394
2395 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2396
2397         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2398         prstatus.pr_lwp.pr_info instead of making it up.
2399
2400 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2401
2402         * auto-load.c (auto_load_expand_dir_vars): Update.
2403         * defs.h (gdb_datadir): Change to std::string.
2404         (python_libdir): Likewise.
2405         (relocate_gdb_directory): Change return type to std::string.
2406         * guile/guile.c (gdbscm_data_directory): Update.
2407         (initialize_scheme_side): Update.
2408         * jit.c (jit_reader_dir): Change to std::string.
2409         (jit_reader_load_command): Update.
2410         * main.c (gdb_datadir): Change to std::string.
2411         (python_libdir): Likewise.
2412         (set_gdb_data_directory): Update.
2413         (relocate_path): Change to return std::string.
2414         (relocate_gdb_directory): Change to return std::string.
2415         (relocate_gdbinit_path_maybe_in_datadir): Update.
2416         (captured_main_1): Update.
2417         * python/python.c (do_start_initialization): Update.
2418         * top.c (show_gdb_datadir): Update.
2419         * xml-syscall.c (xml_init_syscalls_info): Update.
2420         (init_syscalls_info): Update.
2421
2422 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2423
2424         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2425         out of get_init_files.
2426         (get_init_files): Update.
2427
2428 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * main.c (get_init_files): Change to use std::string.
2431         (captured_main_1): Update.
2432         (print_gdb_help): Update.
2433
2434 2019-09-11  Ali Tamur  <tamur@google.com>
2435
2436         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2437         implementation.
2438
2439 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2440
2441         * dbxread.c (read_dbx_symtab): Update.
2442         * dwarf2read.c (load_partial_dies): Update.
2443         * mdebugread.c (parse_partial_symbols): Update.
2444         (handle_psymbol_enumerators): Update.
2445         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2446         * psymtab.c (add_psymbol_to_bcache): Likewise.
2447         (add_psymbol_to_list): Likewise.
2448         * symtab.c (symbol_set_names): Likewise.
2449         * symtab.h (symbol_set_names): Likewise.
2450         * xcoffread.c (scan_xcoff_symtab): Update.
2451
2452 2019-09-11  Tom Tromey  <tom@tromey.com>
2453
2454         * symfile-mem.c (symbol_file_add_from_memory): Use
2455         bfd_set_filename.
2456         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2457         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2458
2459 2019-09-10  Tom Tromey  <tromey@adacore.com>
2460
2461         * dwarf-index-write.c (write_psymbols): Extend error message.
2462         (debug_names::insert): Add Ada code.
2463         (debug_names::write_psymbols): Remove Ada check.
2464         (debug_names) <m_string_obstack>: New member.
2465         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2466         (gdb_index_symbol_name_matcher::matches): Remove.
2467         (mapped_index_base::find_name_components_bounds): Add "lang"
2468         parameter.
2469         (mapped_index_base::build_name_components): Also split names
2470         according to Ada syntax.
2471         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2472         type of "match_callback".
2473         (check_match, check_find_bounds_finds)
2474         (dw2_expand_symtabs_matching): Update.
2475         (dw2_debug_names_iterator): Add new constructor.
2476         (dw2_debug_names_map_matching_symbols): New function.
2477         (dw2_debug_names_expand_symtabs_matching): Update.
2478         (dwarf2_debug_names_functions): Use
2479         dw2_debug_names_map_matching_symbols.
2480
2481 2019-09-10  Tom Tromey  <tromey@adacore.com>
2482
2483         * dwarf2read.c (dw2_get_file_names_reader): Add the
2484         CU's file name to the results.
2485
2486 2019-09-10  Tom Tromey  <tromey@adacore.com>
2487
2488         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2489         map_matching_symbols.  Update.
2490         * dwarf2read.c (dw2_map_matching_symbols): Update.
2491         * psymtab.c (match_partial_symbol): Change type; update.
2492         (psym_map_matching_symbols): Likewise.
2493         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2494         type; update.
2495         * symfile.h (struct quick_symbol_functions)
2496         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2497         Remove "match".
2498
2499 2019-09-10  Tom Tromey  <tromey@adacore.com>
2500
2501         * psymtab.c (map_block): Remove.
2502         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2503         * symtab.c (iterate_over_symbols_terminated): New function.
2504         * symtab.c (iterate_over_symbols_terminated): Declare.
2505
2506 2019-09-10  Tom Tromey  <tromey@adacore.com>
2507
2508         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2509         * language.h (struct language_defn) <la_iterate_over_symbols>:
2510         Return bool.
2511         * symtab.c (iterate_over_symbols): Return bool.
2512         * symtab.h (iterate_over_symbols): Return bool.
2513
2514 2019-09-10  Tom Tromey  <tromey@adacore.com>
2515
2516         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2517         (add_nonlocal_symbols): Update.
2518         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2519         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2520         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2521         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2522         Change type of "callback".  Remove "data".
2523
2524
2525 2019-09-09  Ali Tamur  <tamur@google.com>
2526
2527         * dwarf2read.c (comp_unit_head): Update comment.
2528         (dwarf2_dwo_name): New function declaration.
2529         (dwarf_unit_type_name): New function declaration.
2530         (read_comp_unit_head): Add support for new compilation units,
2531         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2532         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2533         (currently named as "signature") in their header. Also clarify error
2534         messages.
2535         (lookup_dwo_id): New function. Returns the dwo id of the given
2536         compile unit.
2537         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2538         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2539         functions.
2540         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2541         (dwarf2_dwo_name): Get the dwo name if present.
2542         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2543         purposes.
2544
2545 2019-09-09  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2548
2549 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2550
2551         * python/python.c (do_start_initialization): Make progname_copy static,
2552         to avoid a leak report.
2553
2554 2019-09-08  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2557
2558 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2559
2560         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2561         Change type to gdb::optional<block_enum>.
2562         (dw2_symtab_iter_init): Change block_index parameter type
2563         to gdb::optional<block_enum>.
2564         (dw2_lookup_symbol): Change block_index parameter
2565         type to block_enum.c
2566         (dw2_debug_names_lookup_symbol): Likewise.
2567         * psymtab.c (psym_lookup_symbol): Likewise.
2568         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2569         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2570         Likewise.
2571
2572 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2573
2574         * defs.h (relocate_gdb_directory): Change int to bool in
2575         signature and rename flag to relocatable.
2576         * main.c (relocate_path): Likewise.
2577         (relocate_gdb_directory): Likewise.
2578
2579 2019-09-06  Alan Modra  <amodra@gmail.com>
2580
2581         * coffread.c (coff_symfile_read): Constify filename variable.
2582         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2583         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2584         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2585         * solib.c (reload_shared_libraries_1): Likewise.
2586         * symfile.c (reread_symbols): Likewise.
2587         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2588         * solib-darwin.c (darwin_bfd_open): Likewise.
2589         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2590
2591 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2592
2593         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2594         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2595
2596 2019-09-03  Tom Tromey  <tromey@adacore.com>
2597
2598         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2599         types.
2600         (has_negatives): Unbias a range type bound.
2601         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2602         * gdbtypes.c (operator==): Handle new field.
2603         (create_range_type): Add "bias" parameter.
2604         (create_static_range_type, resolve_dynamic_range): Update.
2605         * gdbtypes.h (struct range_bounds) <bias>: New member.
2606         (create_range_type): Add bias parameter.
2607         * printcmd.c (print_scalar_formatted): Unbias range types.
2608         * value.c (unpack_long): Unbias range types.
2609         (pack_long): Bias range types.
2610
2611 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2612
2613         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2614         probe arguments.
2615
2616 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2617
2618         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2619         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2620         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2621         (compile_probe_arg): Likewise.
2622         * probe.h (get_argument_count): Likewise.
2623         * solib-svr4.c (solib_event_probe_action): Likewise.
2624         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2625
2626 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2627
2628         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2629         code to here...
2630         (svr4_create_solib_event_breakpoints): ...from here.
2631
2632 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2633
2634         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2635         suffix from warning message.
2636
2637 2019-08-30  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-winsource.h (struct tui_source_window_base)
2640         <refresh_all>: Don't declare.
2641         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2642         Remove.
2643         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2644         tui_show_locator_content.
2645         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2646         declare.
2647         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2648         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2649         declare.
2650
2651 2019-08-30  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2654
2655 2019-08-30  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2658         Remove unnecessary forward declarations.
2659
2660 2019-08-30  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2663         rerender.
2664         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2665         tui_show_locator_content.
2666
2667 2019-08-30  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2670         (tui_locator_window::rerender): Rewrite using body of previous
2671         tui_show_locator_content.
2672
2673 2019-08-30  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2676         set_locator_fullname>: New methods.
2677         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2678         Rename from tui_set_locator_fullname.
2679         (tui_locator_window::set_locator_info): Rename from
2680         tui_set_locator_info.  Return bool.
2681         (tui_update_locator_fullname, tui_show_frame_info): Update.
2682
2683 2019-08-30  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2686
2687 2019-08-30  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2690         call touchwin.
2691
2692 2019-08-30  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-wingeneral.c (box_win): Assume win_info and
2695         win_info->handle cannot be NULL.
2696
2697 2019-08-30  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2700         refresh_window>: Declare.
2701         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2702         resize.
2703         (tui_data_item_window::rerender): Rename from
2704         tui_display_register.
2705         (tui_data_item_window::refresh_window): New method.
2706         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2707         no-op.
2708
2709 2019-08-30  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2712         regs_column_count, current_group>: Move later.  Now private.
2713         <get_current_group>: New method.
2714         * tui/tui-regs.c (tui_reg_command): Update.
2715         * tui/tui-layout.c (tui_set_layout): Update.
2716
2717 2019-08-30  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2720         (tui_data_window::rerender): Don't call
2721         check_and_display_highlight_if_needed.
2722         (tui_data_window::refresh_all): Remove call to
2723         erase_data_content.
2724
2725 2019-08-30  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2728         (tui_data_window::display_registers_from)
2729         (tui_data_window::display_reg_element_at_line)
2730         (tui_data_window::display_registers_from_line): Remove checks of
2731         "empty".
2732
2733 2019-08-30  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2736         Don't declare.
2737         * tui/tui-regs.c (tui_data_window::show_registers): Call
2738         rerender.
2739         (tui_data_window::rerender): Rename from display_all_data.
2740         (tui_data_window::rerender): Remove old implementation.
2741
2742 2019-08-30  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2745         text.
2746         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2747
2748 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2749             Sergio Durigan Junior  <sergiodj@redhat.com>
2750
2751         PR win32/24284
2752         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2753
2754 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2757         when searching for types.
2758
2759 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * f-lang.c (f_language_defn): Use f_print_typedef.
2762         * f-lang.h (f_print_typedef): Declare.
2763         * f-typeprint.c (f_print_typedef): Define.
2764
2765 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2766
2767         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2768
2769 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * cli/cli-utils.c (info_print_options_defs): Delete.
2772         (make_info_print_options_def_group): Delete.
2773         (extract_info_print_options): Delete.
2774         (info_print_command_completer): Delete.
2775         (info_print_args_help): Add extra parameter, and optionally
2776         include text about -n flag.
2777         * cli/cli-utils.h (struct info_print_options): Delete.
2778         (extract_info_print_options): Delete declaration.
2779         (info_print_command_completer): Delete declaration.
2780         (info_print_args_help): Add extra parameter, extend header
2781         comment.
2782         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2783         search_symbols.
2784         * stack.c (struct info_print_options): New type.
2785         (info_print_options_defs): New file scoped variable.
2786         (make_info_print_options_def_group): New static function.
2787         (info_print_command_completer): New static function.
2788         (info_locals_command): Update to use new local functions.
2789         (info_args_command): Likewise.
2790         (_initialize_stack): Add extra parameter to calls to
2791         info_print_args_help.
2792         * symtab.c (search_symbols): Add extra parameter, use this to
2793         possibly excluse non-debug symbols.
2794         (symtab_symbol_info): Add extra parameter, which is passed on to
2795         search_symbols.
2796         (struct info_print_options): New type.
2797         (info_print_options_defs): New file scoped variable.
2798         (make_info_print_options_def_group): New static function.
2799         (info_print_command_completer): New static function.
2800         (info_variables_command): Update to use local functions, and pass
2801         extra parameter through to symtab_symbol_info.
2802         (info_functions_command): Likewise.
2803         (info_types_command): Pass additional argument through to
2804         symtab_symbol_info.
2805         (rbreak_command): Pass extra argument to search_symbols.
2806         (_initialize_symtab): Add extra arguments for calls to
2807         info_print_args_help, and update help text for 'info variables',
2808         'whereis', and 'info functions' commands.
2809         * symtab.h (search_symbols): Add extra argument to declaration.
2810         * NEWS: Mention new flags.
2811
2812 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2813
2814         * symtab.c (lookup_static_symbol): Call the new function (and move
2815         it down to be next to lookup_global_symbol).
2816         (struct global_sym_lookup_data): Add block_enum member and rename to...
2817         (struct global_or_static_sym_lookup_data): ...this.
2818         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2819         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2820         (lookup_symbol_global_or_static_iterator_cb): ...this.
2821         (lookup_global_or_static_symbol): New function.
2822         (lookup_global_symbol): Call new function.
2823
2824 2019-08-26  Tom de Vries  <tdevries@suse.de>
2825
2826         PR c++/24852
2827         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2828         when pc_probe.prob == NULL.
2829
2830 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2831
2832         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2833         variable symbol_linkage to symbol_linkage_.
2834
2835 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2836
2837         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2838         represent whether the symbol is static, dynamic, or we don't
2839         know.
2840
2841 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2842
2843         * gdb/rx-tdep.c (rx_register_names): New.
2844         (rx_register_name): Delete.
2845         (rx_psw_type): Delete.
2846         (rx_fpsw_type): Delete.
2847         (rx_register_type): Delete.
2848         (rx_gdbarch_init): Convert target-descriptions.
2849         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2850         * gdb/features/Makefile: Add rx.xml.
2851         * gdb/features/rx.xml: New.
2852         * gdb/features/rx.c: Generated.
2853         * gdb/NEWS: Mention target description support.
2854
2855 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2856
2857         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2858         *slot_ptr.
2859
2860 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2861
2862         * configure.ac: Don't check for 'dlfcn.h' (moved to
2863         gdbsupport/common.m4).
2864         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2865         'gdbsupport/'.
2866         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2867         * compile/compile-c-support.c: Include
2868         'gdbsupport/gdb-dlfcn.h'.
2869         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2870         * gdb-dlfcn.c: Move to...
2871         * gdbsupport/gdb-dlfcn.c: ... here.
2872         * gdb-dlfcn.h: Move to...
2873         * gdbsupport/gdb-dlfcn.h: ... here.
2874
2875 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2876
2877         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2878         the offset field signed.
2879
2880 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2881
2882         * python/lib/gdb/__init__.py (_execute_file): New function.
2883         * python/python.c (python_run_simple_file): Call gdb._execute_file
2884         on Windows.
2885
2886 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2889         all uses as this was never set to anything but a zero value.
2890
2891 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2892
2893         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2894
2895 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2896
2897         * tui/tui-data.h (tui_gen_win_info): Add an =default
2898         move constructor, required by some GCC versions.
2899
2900 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2901
2902         * go32-nat.c (go32_sysinfo): Add hygon_p.
2903
2904 2019-08-20  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2907         line_from_reg_element_no, first_reg_element_no_inline,
2908         display_all_data, delete_data_content_windows,
2909         erase_data_content>: Now private.
2910
2911 2019-08-20  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2914         (tui_unhighlight_win, tui_highlight_win)
2915         (tui_win_info::make_window): Update.
2916         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2917
2918 2019-08-20  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2921         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2922         (MAX_PID_WIDTH): Move to tui-stack.c.
2923         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2924         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2925         (MAX_PID_WIDTH): Move from tui-data.h.
2926
2927 2019-08-20  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2930         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2931         (box_win): Update.
2932         (tui_gen_win_info::make_window): Rename from tui_make_window.
2933         (tui_win_info::make_window): New method.
2934         (tui_gen_win_info::make_visible): Update.
2935         * tui/tui-source.c (tui_source_window::set_contents): Update.
2936         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2937         (tui_data_window::display_registers_from): Update.
2938         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2939         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2940         Declare.
2941         <can_box>: Remove.
2942         <title>: Remove.
2943         (struct tui_win_info) <make_window>: Declare.
2944         <can_box>: Now virtual.
2945         <title>: New member.
2946         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2947         * tui/tui-command.c (tui_cmd_window::resize): Update.
2948
2949 2019-08-20  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2952         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2953         (tui_data_window::check_register_values): Update.
2954
2955 2019-08-20  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-regs.h (struct tui_data_window): Use
2958         DISABLE_COPY_AND_ASSIGN.
2959         <regs_content>: Change type, removing unique_ptr.
2960         <tui_data_window>: Add move constructor.
2961         * tui/tui-regs.c (tui_data_window::show_registers)
2962         (tui_data_window::show_register_group)
2963         (tui_data_window::display_registers_from)
2964         (tui_data_window::display_registers_from)
2965         (tui_data_window::first_data_item_displayed)
2966         (tui_data_window::delete_data_content_windows)
2967         (tui_data_window::rerender, tui_data_window::refresh_window)
2968         (tui_data_window::check_register_values): Update.
2969
2970 2019-08-20  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2973         show_register_group>: Declare.
2974         (tui_show_register_group): Don't declare.
2975         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2976         tui_show_registers.
2977         (tui_data_window::show_register_group): Rename from
2978         tui_show_register_group.
2979         (tui_data_window::check_register_values, tui_reg_command):
2980         Update.
2981         * tui/tui-layout.c (tui_set_layout): Update.
2982
2983 2019-08-20  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2986         Declare.
2987         (tui_check_register_values): Don't declare.
2988         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2989         from tui_check_register_values.
2990         * tui/tui-hooks.c (tui_register_changed): Update.
2991
2992 2019-08-20  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-regs.c (tui_reg_layout): Move later.
2995         (tui_show_registers): Don't enable TUI mode or change layout.
2996
2997 2019-08-20  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-regs.h (struct tui_data_item_window)
3000         <~tui_data_item_window>: Remove.
3001         <content>: Now a unique_xmalloc_ptr.
3002         * tui/tui-regs.c (tui_register_format): Return a
3003         unique_xmalloc_ptr.
3004         (tui_get_register): Update.
3005         (~tui_data_item_window): Remove.
3006         (tui_data_window::display_registers_from, tui_display_register):
3007         Update.
3008         * tui/tui-io.h (tui_expand_tabs): Update.
3009         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3010         Remove "col" parameter.
3011
3012 2019-08-20  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3015         field.
3016         * tui/tui-regs.c (~tui_data_item_window): Update.
3017
3018 2019-08-20  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3021         earlier.
3022
3023 2019-08-20  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3026
3027 2019-08-20  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-source.h (struct tui_source_window): Update.
3030         * tui/tui-regs.c (tui_show_registers): Update.
3031         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3032         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3033         (NO_REGS_STRING): Remove defines.
3034
3035 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3036
3037         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3038         unnecessary thread walk if remote doesn't support the packet.
3039
3040 2019-08-19  Tom Tromey  <tromey@adacore.com>
3041
3042         * python/py-value.c (value_has_field): Fix indentation.
3043
3044 2019-08-19  Tom Tromey  <tromey@adacore.com>
3045
3046         * printcmd.c (do_one_display, info_display_command): Update.
3047         * block.h (contained_in): Return bool.  Add allow_nested
3048         parameter.
3049         * block.c (contained_in): Return bool.  Add allow_nested
3050         parameter.
3051
3052 2019-08-19  Tom Tromey  <tom@tromey.com>
3053
3054         * configure: Rebuild.
3055         * configure.ac: Disallow the combination of -static-libstdc++ and
3056         source highlight.
3057         * source-cache.c (get_language_name): Handle rust.
3058         (source_cache::get_source_lines): Ignore highlighting exceptions.
3059
3060 2019-08-16  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3063         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3064         (struct tui_source_window_base) <make_visible, refresh_window,
3065         resize>: Remove methods.
3066         <execution_info>: Remove field.
3067         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3068         (tui_show_source_line, tui_source_window_base)
3069         (~tui_source_window_base): Update.
3070         (tui_source_window_base::resize)
3071         (tui_source_window_base::make_visible)
3072         (tui_source_window_base::refresh_window): Remove.
3073         (tui_source_window_base::update_exec_info): Update.
3074         * tui/tui-source.c (tui_source_window::set_contents): Update.
3075         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3076
3077 2019-08-16  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3080         deprecated_query_hook.
3081
3082 2019-08-16  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3085         (tui_update_source_windows_with_line): Update.
3086         * tui/tui-source.h (struct tui_source_window)
3087         <show_symtab_source>: Declare.
3088         (tui_show_symtab_source): Don't declare.
3089         * tui/tui-source.c (tui_show_symtab_source): Rename from
3090         tui_show_symtab_source.
3091
3092 2019-08-16  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.h (struct tui_source_window_base)
3095         <set_contents>: Declare.
3096         * tui/tui-winsource.c
3097         (tui_source_window_base::update_source_window_as_is): Update.
3098         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3099         Declare.
3100         (tui_set_source_content): Don't declare.
3101         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3102         tui_set_source_content.
3103         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3104         Declare.
3105         (tui_set_disassem_content): Don't declare.
3106         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3107         tui_set_disassem_content.
3108
3109 2019-08-16  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-winsource.h (struct tui_source_window_base)
3112         <update_breakpoint_info>: Declare.
3113         (tui_update_breakpoint_info): Don't declare.
3114         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3115         (tui_update_all_breakpoint_info): Update.
3116         (tui_source_window_base::update_breakpoint_info): Rename from
3117         tui_update_breakpoint_info.
3118         (tui_source_window_base::update_exec_info): Update.
3119
3120 2019-08-16  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.h (struct tui_source_window_base)
3123         <update_source_window>: Declare.
3124         (tui_update_source_window): Don't declare.
3125         * tui/tui-winsource.c
3126         (tui_source_window_base::update_source_window): Rename from
3127         tui_update_source_window.
3128         (tui_source_window_base::rerender): Update.
3129         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3130         * tui/tui-disasm.c (tui_show_disassem)
3131         (tui_show_disassem_and_update_source)
3132         (tui_disasm_window::maybe_update): Update.
3133
3134 2019-08-16  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-winsource.h (struct tui_source_window_base)
3137         <update_source_window_as_is>: Declare.
3138         (tui_update_source_window_as_is): Don't declare.
3139         * tui/tui-winsource.c (tui_update_source_window): Update
3140         (tui_source_window_base::update_source_window_as_is): Rename from
3141         tui_update_source_window_as_is.
3142         (tui_source_window_base::refill): Update.
3143         * tui/tui-source.c (tui_show_symtab_source): Update.
3144         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3145         Update.
3146
3147 2019-08-16  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-winsource.h (tui_update_source_window)
3150         (tui_update_source_window_as_is): Remove "noerror" parameter.
3151         * tui/tui-winsource.c (tui_update_source_window)
3152         (tui_update_source_window_as_is): Remove "noerror" parameter.
3153         (tui_update_source_windows_with_addr)
3154         (tui_update_source_windows_with_line)
3155         (tui_source_window_base::rerender)
3156         (tui_source_window_base::refill): Update.
3157         * tui/tui-source.h (tui_set_source_content)
3158         (tui_show_symtab_source): Remove "noerror" parameter.
3159         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3160         parameter.
3161         (tui_show_symtab_source): Likewise.
3162         (tui_source_window::maybe_update): Update.
3163         * tui/tui-disasm.c (tui_show_disassem)
3164         (tui_show_disassem_and_update_source)
3165         (tui_disasm_window::do_scroll_vertical)
3166         (tui_disasm_window::maybe_update): Update.
3167
3168 2019-08-16  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui.c (tui_is_window_visible): Update.
3171         * tui/tui-wingeneral.c (tui_make_window)
3172         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3173         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3174         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3175         (tui_set_win_height_command, parse_scrolling_args): Update.
3176         * tui/tui-source.c (tui_source_window::style_changed): Update.
3177         * tui/tui-regs.c (tui_show_registers)
3178         (tui_data_window::first_data_item_displayed)
3179         (tui_data_window::delete_data_content_windows)
3180         (tui_check_register_values, tui_reg_command): Update.
3181         * tui/tui-disasm.c (tui_show_disassem): Update.
3182         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3183         method.
3184         <is_visible>: Remove field.
3185         * tui/tui-data.c (tui_next_win, tui_prev_win)
3186         (tui_delete_invisible_windows): Update.
3187
3188 2019-08-16  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-winsource.h (struct tui_source_window_base)
3191         <m_has_locator>: Remove.
3192         * tui/tui-layout.c (show_source_disasm_command, show_data)
3193         (show_source_or_disasm_and_command): Update.
3194
3195 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3196
3197         * NEWS (Other MI changes): New subsection.
3198         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3199         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3200         * arch-utils.c (default_get_pc_address_flags): New function.
3201         * arch-utils.h (default_get_pc_address_flags): New declaration.
3202         * gdbarch.sh: Add get_pc_address_flags.
3203         * gdbarch.c: Regenerate.
3204         * gdbarch.h: Likewise.
3205         * stack.c (print_pc): New function.
3206         (print_frame_info) (print_frame): Call print_pc.
3207
3208 2019-08-16  Tom de Vries  <tdevries@suse.de>
3209
3210         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3211         print_objfile_section_info.
3212
3213 2019-08-15  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3216         calling update_cmdwin_start_line.
3217         * tui/tui-winsource.h (struct tui_source_window_base)
3218         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3219         <rerender>: Declare.
3220         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3221         Call rerender.
3222         (tui_source_window_base::set_new_height): Remove.
3223         (tui_source_window_base::rerender): Rename from
3224         do_make_visible_with_new_height.
3225         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3226         resize method.
3227         (tui_win_info::make_invisible_and_set_new_height)
3228         (tui_win_info::make_visible_with_new_height): Remove.
3229         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3230         Declare.
3231         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3232         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3233         do_make_visible_with_new_height>: Don't declare.
3234         <rerender>: Declare.
3235         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3236         set_new_height.
3237         (tui_data_window::do_make_visible_with_new_height): Remove.
3238         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3239         call tui_show_locator_content.
3240         (tui_gen_win_info::resize): Call rerender.
3241         (show_source_or_disasm_and_command): Don't call
3242         tui_show_locator_content.
3243         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3244         method.
3245         (struct tui_win_info) <rerender>: Declare.
3246         <set_new_height, make_invisible_and_set_new_height,
3247         make_visible_with_new_height>: Don't declare.
3248         * tui/tui-data.c (tui_win_list::rerender): New method.
3249         * tui/tui-command.h (struct tui_cmd_window)
3250         <do_make_visible_with_new_height>: Don't declare.
3251         * tui/tui-command.c
3252         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3253
3254 2019-08-15  Tom Tromey  <tromey@adacore.com>
3255
3256         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3257         * ada-lang.c (ada_enum_name): Likewise.
3258
3259 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3260
3261         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3262         leading underscore.
3263         (GdbOutputErrorFile): Likewise.
3264         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3265         accordingly.
3266         (execute_unwinders): Rename to have a leading underscore.
3267         (auto_load_packages): Likewise.
3268         (global scope): Adjust call to auto_load_packages accordingly.
3269         (GdbSetPythonDirectory): Likewise.
3270         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3271         instead of execute_unwinders.
3272
3273 2019-08-15  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3276         (show_data): Don't change window visibility.
3277         (tui_gen_win_info::resize): Remove special case for command
3278         window.  Use wresize, when available.
3279         (show_source_or_disasm_and_command): Don't change window
3280         visibility.
3281         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3282         <make_visible>: New method.
3283         * tui/tui-command.c (tui_cmd_window::resize): New method.
3284
3285 2019-08-15  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3288         (struct tui_source_windows): New.
3289         * tui/tui-winsource.c (tui_display_main): Update.
3290         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3291         (new_height_ok, parse_scrolling_args): Update.
3292         * tui/tui-layout.c (show_layout, show_data): Update.
3293         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3294         (tui_add_to_source_windows): Don't declare.
3295         * tui/tui-data.c (source_windows, tui_source_windows)
3296         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3297
3298 2019-08-15  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3301         Rename from reset.
3302         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3303         * tui/tui-layout.c (show_source_disasm_command, show_data):
3304         Update.
3305         (tui_gen_win_info::resize): Rename.
3306         (show_source_or_disasm_and_command): Update.
3307         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3308         reset.
3309
3310 2019-08-15  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3313         * tui/tui-interp.c (tui_interp::init): Don't call
3314         tui_initialize_static_data.
3315         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3316
3317 2019-08-15  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3320         examine tui_win_list.
3321
3322 2019-08-15  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3325         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3326         tui_clear_source_content.
3327         (tui_clear_source_content): Remove.
3328         (tui_source_window_base::do_erase_source_content): Hoist call to
3329         content.clear().
3330         * tui/tui-stack.c (tui_show_frame_info): Don't call
3331         tui_clear_source_content.
3332
3333 2019-08-15  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.h (struct tui_source_window_base)
3336         <do_erase_source_content>: New method.
3337         <erase_source_content>: New method.
3338         (tui_erase_source_content): Don't declare.
3339         * tui/tui-winsource.c (tui_clear_source_content): Update.
3340         (tui_source_window_base::do_erase_source_content): Rename from
3341         tui_erase_source_content.
3342         (tui_source_window_base::show_source_content): Update.
3343         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3344         * tui/tui-source.h (struct tui_source_window)
3345         <erase_source_content>: New method.
3346         * tui/tui-disasm.h (struct tui_disasm_window)
3347         <erase_source_content>: New method.
3348
3349 2019-08-15  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3352         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3353         constructor.
3354         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3355         * tui/tui-source.c (tui_set_source_content): Update.
3356         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3357
3358 2019-08-15  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3361         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3362         tui-source.c.
3363         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3364         Declare.
3365         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3366         method.
3367         (tui_source_window::maybe_update): Update.
3368
3369 2019-08-15  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3372         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3373         tui-disasm.c.
3374         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3375         Declare.
3376         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3377         method.
3378         (tui_disasm_window::maybe_update): Update.
3379
3380 2019-08-15  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-winsource.h (struct tui_source_window_base)
3383         <maybe_update>: Declare.
3384         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3385         method.
3386         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3387         Declare.
3388         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3389         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3390         Declare.
3391         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3392
3393 2019-08-15  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3396
3397 2019-08-15  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-wingeneral.c: Include tui-stack.h.
3400         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3401         (struct tui_locator_window): Move from tui-data.h.
3402         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3403         (tui_initialize_static_data): Move from tui-data.c.
3404         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3405         (struct tui_locator_window): Move to tui-stack.c.
3406         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3407         (tui_initialize_static_data): Move to tui-stack.c.
3408
3409 2019-08-15  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-layout.c (show_source_disasm_command)
3412         (show_source_or_disasm_and_command): Use make_visible method, not
3413         tui_make_window.
3414         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3415         Remove.
3416
3417 2019-08-15  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-wingeneral.h (tui_make_window): Update.
3420         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3421         parameter.
3422         (tui_gen_win_info::make_visible): Update.
3423         * tui/tui-regs.c (tui_data_window::display_registers_from):
3424         Update.
3425         * tui/tui-layout.c (show_source_disasm_command)
3426         (show_source_or_disasm_and_command): Update.
3427         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3428         (enum tui_box): Remove.
3429         (struct tui_win_info) <can_box>: New method.
3430         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3431         method.
3432
3433 2019-08-15  Tom de Vries  <tdevries@suse.de>
3434
3435         * linux-nat-trad.c: Include gdbarch.h.
3436
3437 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3438
3439         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3440         register sizes.
3441
3442 2019-08-14  Tom Tromey  <tromey@adacore.com>
3443
3444         * darwin-nat.c: Include gdbarch.h.
3445         * darwin-nat-info.c: Include gdbarch.h.
3446
3447 2019-08-13  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3450         Remove.
3451         * tui/tui-data.c (tui_initialize_static_data): Update.
3452
3453 2019-08-13  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-winsource.h (struct tui_exec_info_window)
3456         <~tui_exec_info_window, maybe_allocate_content, get_content,
3457         m_content>: Remove.
3458         (struct tui_source_window_base) <set_exec_info_content,
3459         show_exec_info_content>: Don't declare.
3460         * tui/tui-winsource.c
3461         (tui_exec_info_window::maybe_allocate_content): Remove.
3462         (tui_source_window_base::update_exec_info): Rename from
3463         set_exec_info_content.
3464         (tui_source_window_base::show_exec_info_content)
3465         (tui_source_window_base::update_exec_info): Remove.
3466
3467 2019-08-13  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3470         declare.
3471         * tui/tui-winsource.c (tui_update_source_window_as_is)
3472         (tui_update_source_windows_with_addr, tui_erase_source_content):
3473         Update.
3474         (tui_clear_exec_info_content): Remove.
3475
3476 2019-08-13  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3479         declare.
3480         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3481         call tui_erase_exec_info_content.
3482         (tui_clear_exec_info_content): Rename from
3483         tui_erase_exec_info_content.
3484         (tui_clear_exec_info_content): Delete.
3485
3486 2019-08-13  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-winsource.h (struct tui_source_window_base)
3489         <show_exec_info_content>: Declare.
3490         (tui_show_exec_info_content): Don't declare.
3491         * tui/tui-winsource.c
3492         (tui_source_window_base::show_exec_info_content): Rename from
3493         tui_show_exec_info_content.
3494         (tui_source_window_base::update_exec_info): Update.
3495
3496 2019-08-13  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3499         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3500         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3501         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3502         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3503         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3504         ... here.
3505
3506 2019-08-13  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-winsource.h (struct tui_source_window_base)
3509         <update_exec_info>: Declare.
3510         (tui_update_exec_info): Don't declare.
3511         * tui/tui-winsource.c (tui_update_source_window_as_is)
3512         (tui_source_window_base::refresh_all)
3513         (tui_update_all_breakpoint_info): Update.
3514         (tui_source_window_base::update_exec_info): Rename from
3515         tui_update_exec_info.
3516         * tui/tui-stack.c (tui_show_frame_info): Update.
3517
3518 2019-08-13  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-winsource.h (struct tui_source_window_base)
3521         <set_exec_info_content>: Declare.
3522         (tui_set_exec_info_content): Don't declare.
3523         * tui/tui-winsource.c
3524         (tui_source_window_base::set_exec_info_content): Rename from
3525         tui_set_exec_info_content.
3526         (tui_update_exec_info): Update.
3527
3528 2019-08-13  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-winsource.h (struct tui_source_window_base)
3531         <show_source_content>: Declare.
3532         (tui_show_source_content): Don't declare.
3533         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3534         (tui_source_window_base::show_source_content): Rename from
3535         tui_show_source_content.
3536         (tui_source_window_base::refresh_all): Update.
3537         * tui/tui-layout.c (show_source_disasm_command)
3538         (show_source_or_disasm_and_command): Update.
3539
3540 2019-08-13  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-winsource.c (tui_erase_source_content)
3543         (tui_show_source_content, tui_source_window_base::refresh_all):
3544         Update.
3545         * tui/tui-wingeneral.h
3546         (tui_check_and_display_highlight_if_needed): Don't declare.
3547         * tui/tui-wingeneral.c
3548         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3549         check_and_display_highlight_if_needed.
3550         * tui/tui-win.c (tui_rehighlight_all)
3551         (tui_win_info::make_visible_with_new_height): Update.
3552         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3553         (tui_data_window::erase_data_content)
3554         (tui_data_window::display_all_data): Update.
3555         * tui/tui-data.h (struct tui_win_info)
3556         <check_and_display_highlight_if_needed>: Declare.
3557
3558 2019-08-13  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-win.c (tui_resize_all): Call
3561         tui_delete_invisible_windows.
3562         * tui/tui-layout.c (show_layout): Call
3563         tui_delete_invisible_windows.
3564         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3565         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3566
3567 2019-08-13  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3570         tui_add_win_to_layout.
3571
3572 2019-08-13  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3575         * tui/tui-layout.c (tui_default_win_height): Now static.
3576
3577 2019-08-13  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3580         single switch.
3581         (show_source_disasm_command, show_source_or_disasm_and_command):
3582         Don't check current layout.
3583
3584 2019-08-13  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-wingeneral.c (make_all_visible): Remove.
3587         (tui_make_all_invisible): Simplify.
3588         * tui/tui-layout.c (tui_make_all_invisible): Move from
3589         tui-wingeneral.c; simplify.
3590         (show_layout): Hoist call to tui_make_all_invisible.
3591         (show_data): Don't call tui_make_all_invisible.
3592
3593 2019-08-13  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3596         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3597
3598 2019-08-13  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3601         tui-data.c.
3602         (show_source_disasm_command, show_data)
3603         (show_source_or_disasm_and_command): Don't use
3604         tui_set_current_layout_to.
3605         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3606         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3607         tui-layout.c.
3608         (tui_set_current_layout_to): Remove.
3609
3610 2019-08-13  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-layout.c (tui_set_layout): Update.
3613         * tui/tui-data.h (struct tui_layout_def): Remove.
3614         (tui_layout_def): Don't declare.
3615         * tui/tui-data.c (layout_def): Remove.
3616         (tui_layout_def): Remove.
3617
3618 2019-08-13  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-winsource.h (struct tui_source_window_base)
3621         <clear_detail>: No longer "override".
3622         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3623         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3624         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3625         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3626         Remove.
3627         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3628
3629 2019-08-13  Tom Tromey  <tromey@adacore.com>
3630
3631         * tracepoint.c: Don't include readline.h or history.h.
3632
3633 2019-08-12  Tom Tromey  <tom@tromey.com>
3634
3635         * configure: Rebuild.
3636         * configure.ac: Check for readline 7.
3637         * NEWS: Mention readline 7 requirement.
3638         * README: Update.
3639
3640 2019-08-12  Tom Tromey  <tom@tromey.com>
3641
3642         * mingw-hdep.c (gdb_select): Remove readline hack.
3643
3644 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3645
3646         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3647         when the function fails.
3648
3649 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3650
3651         * s390-tdep.c (s390_type_align): New function.
3652         (s390_gdbarch_init): Set it as type_align gdbarch method.
3653
3654 2019-08-09  Tom de Vries  <tdevries@suse.de>
3655
3656         PR gdb/24591
3657         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3658         pc_low with relocation offset.
3659
3660 2019-08-07  Tom Tromey  <tromey@adacore.com>
3661
3662         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3663         (print_frame_args): Update.
3664         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3665         Update.
3666         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3667         * frame.h (struct frame_arg): Add initializers.
3668         <error>: Now a unique_xmalloc_ptr.
3669
3670 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3671
3672         * NEWS: Expand the Pointer Authentication entry.
3673         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3674         (aarch64_frame_unmask_lr): ... to this.
3675         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3676         Call aarch64_frame_unmask_lr.
3677         * frame.c (struct frame_info): Add "masked" variable.
3678         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3679         (fprint_frame): Check for masked pc.
3680         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3681         declarations.
3682         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3683         * stack.c (print_frame): Check for masked pc.
3684
3685 2019-08-06  Tom Tromey  <tom@tromey.com>
3686
3687         * stabsread.c (patch_block_stabs, read_one_struct_field)
3688         (read_enum_type): Use obstack_strndup.
3689         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3690         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3691         * dwarf2read.c (guess_full_die_structure_name)
3692         (anonymous_struct_prefix): Use obstack_strndup.
3693         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3694         * c-exp.y (yylex): Use obstack_strndup.
3695         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3696         (write_var_or_type): Use obstack_strndup.
3697
3698 2019-08-06  Tom Tromey  <tom@tromey.com>
3699
3700         * symfile.c (reread_symbols): Use obstack_strdup.
3701         * stabsread.c (read_type): Use obstack_strdup.
3702         * gdb_obstack.h (obstack_strdup): New overload.
3703         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3704         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3705         (dwarf2_canonicalize_name): Use obstack_strdup.
3706         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3707         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3708         Use obstack_strdup.
3709
3710 2019-08-06  Tom Tromey  <tom@tromey.com>
3711
3712         * gdb_obstack.h (obstack_strdup): Define.
3713         * gdb_obstack.c (obstack_strdup): Don't define.
3714
3715 2019-08-06  Tom Tromey  <tom@tromey.com>
3716
3717         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3718         obstack_strdup.
3719         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3720         obstack_strdup.
3721         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3722         * stabsread.c (common_block_start): Use obstack_strdup.
3723         * objfiles.c (set_objfile_main_name, objfile): Use
3724         obstack_strdup.
3725         * namespace.c (add_using_directive): Use obstack_strdup.
3726         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3727         * jit.c (finalize_symtab): Use obstack_strdup.
3728         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3729         (guess_partial_die_structure_name, partial_die_info::fixup)
3730         (dwarf2_name): Use obstack_strdup.
3731         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3732         obstack_strdup.
3733         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3734         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3735         obstack_strdup.
3736         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3737
3738 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3739
3740         * unittests/help-doc-selftests.c: New file.
3741         * Makefile.in: Add the new file.
3742
3743 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3744
3745         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3746         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3747         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3748         the trailing '.' is not output, and the first character is uppercased.
3749         (print_help_for_command): Update call to print_doc_line.
3750         (print_doc_of_command): Likewise.
3751         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3752         * cli/cli-option.c (append_indented_doc): Do not append newline.
3753         (build_help_option): Append newline after first appended_indented_doc
3754         only if a second call is done.
3755         (build_help): Append 2 new lines before each option, except the first
3756         one.
3757         * compile/compile.c (_initialize_compile): Add new lines after
3758         %OPTIONS%, when not at the end of the help.
3759         Change help doc or code
3760         producing the help doc to respect the invariants.
3761         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3762         Also removed the new line after 'Options:', as all other commands
3763         do not put an empty line between 'Options:' and the first option.
3764         * printcmd.c (_initialize_printcmd): Likewise.
3765         * stack.c (_initialize_stack): Likewise.
3766         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3767         incorrectly telling COMMAND is optional.
3768         * ada-lang.c (_initialize_ada_language): Change help doc or code
3769         producing the help doc to respect the invariants.
3770         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3771         * breakpoint.c (_initialize_breakpoint): Likewise.
3772         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3773         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3774         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3775         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3776         _initialize_cli_style): Likewise.
3777         * corelow.c (core_target_info): Likewise.
3778         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3779         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3780         * filesystem.c (_initialize_filesystem): Likewise.
3781         * frame.c (_initialize_frame): Likewise.
3782         * gnu-nat.c (add_task_commands): Likewise.
3783         * infcall.c (_initialize_infcall): Likewise.
3784         * infcmd.c (_initialize_infcmd): Likewise.
3785         * interps.c (_initialize_interpreter): Likewise.
3786         * language.c (_initialize_language): Likewise.
3787         * linux-fork.c (_initialize_linux_fork): Likewise.
3788         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3789         * maint.c (_initialize_maint_cmds): Likewise.
3790         * memattr.c (_initialize_mem): Likewise.
3791         * printcmd.c (_initialize_printcmd): Likewise.
3792         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3793         _RegEx): Likewise.
3794         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3795         * record-btrace.c (_initialize_record_btrace): Likewise.
3796         * record-full.c (_initialize_record_full): Likewise.
3797         * record.c (_initialize_record): Likewise.
3798         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3799         * regcache.c (_initialize_regcache): Likewise.
3800         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3801         _initialize_remote): Likewise.
3802         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3803         * serial.c (_initialize_serial): Likewise.
3804         * skip.c (_initialize_step_skip): Likewise.
3805         * source.c (_initialize_source): Likewise.
3806         * stack.c (_initialize_stack): Likewise.
3807         * symfile.c (_initialize_symfile): Likewise.
3808         * symtab.c (_initialize_symtab): Likewise.
3809         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3810         * top.c (init_main): Likewise.
3811         * tracefile-tfile.c (tfile_target_info): Likewise.
3812         * tracepoint.c (_initialize_tracepoint): Likewise.
3813         * tui/tui-win.c (_initialize_tui_win): Likewise.
3814         * utils.c (add_internal_problem_command): Likewise.
3815         * valprint.c (value_print_option_defs): Likewise.
3816
3817 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3818
3819         PR build/24886
3820         * configure.ac: Drop enable-libmcheck support.
3821         * configure, config.in: Rebuild.
3822         * libmcheck.m4: Remove.
3823         * acinclude.m4: Don't include it.
3824         * Makefile.in: Don't distribute it.
3825         * top.c (print_gdb_configuration): Don't mention it.
3826
3827 2019-08-06  Tom Tromey  <tom@tromey.com>
3828
3829         * utils.c (set_output_style): Sometimes pass stream to
3830         emit_style_escape.
3831         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3832         * record-btrace.c (btrace_insn_history): Update.
3833         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3834         method.
3835         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3836         Update initializers.
3837         <m_uiout>: New field.
3838         <m_di>: Move lower.
3839         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3840         Remove "uiout" parameter.
3841         (dump_insns): Update.
3842         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3843         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3844
3845 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3846
3847         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3848         (error_in_psymtab_expansion): Likewise.
3849         (lookup_symbol_via_quick_fns): Likewise.
3850         (basic_lookup_transparent_type_quick): Likewise.
3851         (basic_lookup_transparent_type_1): Likewise.
3852
3853 2019-08-06  Tom Tromey  <tromey@adacore.com>
3854
3855         * source.c (last_source_error): Now bool.
3856         (print_source_lines_base): Make "noprint" bool.  Only open
3857         source file when last_source_visited changes.
3858
3859 2019-08-06  Tom Tromey  <tromey@adacore.com>
3860
3861         * annotate.c (annotate_source_line): Use g_source_cache.
3862         * source-cache.c (source_cache::get_plain_source_lines): Change
3863         parameters.  Populate m_offset_cache.
3864         (source_cache::ensure): New method.
3865         (source_cache::get_line_charpos): New method.
3866         (extract_lines): Move lower.  Change parameters.
3867         (source_cache::get_source_lines): Move lower.
3868         * source-cache.h (class source_cache): Update comment.
3869         <get_line_charpos>: New method.
3870         <get_source_lines>: Update comment.
3871         <clear>: Clear m_offset_cache.
3872         <get_plain_source_lines>: Change parameters.
3873         <ensure>: New method
3874         <m_offset_cache>: New member.
3875         * source.c (forget_cached_source_info_for_objfile): Update.
3876         (info_source_command): Use g_source_cache.
3877         (find_source_lines, open_source_file_with_line_charpos): Remove.
3878         (print_source_lines_base, search_command_helper): Use g_source_cache.
3879         * source.h (open_source_file_with_line_charpos): Don't declare.
3880         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3881         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3882         Use g_source_cache.
3883
3884 2019-08-06  Tom Tromey  <tromey@adacore.com>
3885
3886         * source-cache.c (source_cache::get_plain_source_lines):
3887         Remove "first_line" and "last_line" parameters.
3888         (source_cache::get_source_lines): Cache plain text.
3889         * source-cache.h (class source_cache)
3890         <get_plain_source_lines>: Update.
3891
3892 2019-08-06  Tom Tromey  <tromey@adacore.com>
3893
3894         * source-cache.c (extract_lines): No longer a method.
3895         Changed type of parameter.  Include final newline.
3896         (selftests::extract_lines_test): New function.
3897         (_initialize_source_cache): Likewise.
3898         * source-cache.h (class source_cache)
3899         <extract_lines>: Don't declare.
3900
3901 2019-08-06  Tom Tromey  <tromey@adacore.com>
3902
3903         * breakpoint.c (init_breakpoint_sal): Update.
3904         (breakpoint): Update.
3905         * breakpoint.h (struct breakpoint) <filter>: Now a
3906         unique_xmalloc_ptr.
3907
3908 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3909
3910         * NEWS: Mention dictionary access on blocks.
3911         * python/py-block.c (blpy_getitem): New function.
3912         (block_object_as_mapping): New struct.
3913         (block_object_type): Use new struct for tp_as_mapping field.
3914
3915 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3916
3917         * objfiles.h (objfile): Add a comment describing partial symbols.
3918
3919 2019-08-05  Tom Tromey  <tromey@adacore.com>
3920
3921         * compile/compile.c (_initialize_compile): Use _(), not N_().
3922         * thread.c (_initialize_thread): Use _(), not N_().
3923         * stack.c (_initialize_stack): Use _(), not N_().
3924         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3925
3926 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3927
3928         * dwarf2read.c (struct dw2_symtab_iterator):
3929         <want_specific_block>: Remove.
3930         <block_index>: Change type to gdb::optional.
3931         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3932         change type of BLOCK_INDEX parameter to gdb::optional.
3933         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3934         (dw2_lookup_symbol): Don't pass argument for
3935         WANT_SPECIFIC_BLOCK.
3936         (dw2_expand_symtabs_for_function): Don't pass argument for
3937         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3938         (class dw2_debug_names_iterator)
3939         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3940         parameter, change BLOCK_INDEX type to gdb::optional.
3941         <m_want_specific_block>: Remove.
3942         <m_block_index>: Change type to gdb::optional.
3943         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3944         gdb::optional.  Re-write in function of gdb::optional.
3945         (dw2_debug_names_lookup_symbol): Don't pass argument for
3946         WANT_SPECIFIC_BLOCK.
3947         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3948         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3949         BLOCK_INDEX.
3950
3951 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3952
3953         * NEWS: Mention changes to "info sources" command.
3954
3955 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3956
3957         * symtab.c (filename_partial_match_opts): New struct type.
3958         (struct output_source_filename_data): New members
3959         regexp, c_regexp, partial_match.
3960         (output_source_filename): Use new members to decide to print file.
3961         (info_sources_option_defs): New variable.
3962         (make_info_sources_options_def_group, print_info_sources_header,
3963         info_sources_command_completer):
3964         New functions.
3965         (info_sources_command): Read new optional arguments.
3966         (_initialize_symtab): Update info sources help.
3967
3968 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3969
3970         * ada-lang.c (exception_support_info_v0): Renamed from...
3971         (default_exception_support_info): ... this.  Create new
3972         definition for v1.
3973         (ada_has_this_exception_support): Look up catch_handlers_sym.
3974         (ada_exception_support_info_sniffer): Try v0 after default.
3975
3976 2019-08-01  Tom Tromey  <tromey@adacore.com>
3977
3978         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3979         gdbarch.h.
3980
3981 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3982
3983         * s12z-tdep.c: Fix include path for s12z-opc.h.
3984
3985 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3986
3987         * NEWS: Require GNU make 3.82.
3988
3989 2019-07-16  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3992         declare.
3993
3994 2019-07-30  Tom Tromey  <tromey@adacore.com>
3995
3996         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3997
3998 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3999
4000         * printcmd.c (print_address_symbolic): Print negative offsets.
4001         (build_address_symbolic): Force signed arithmetic when computing
4002         offset.
4003
4004 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4005
4006         PR/24474: Add a function to lookup static variables.
4007         * NEWS: Mention this new function.
4008         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4009         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4010         * python/python.c (python_GdbMethods): Add new function.
4011
4012 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4013
4014         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4015         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4016         (objfpy_lookup_static_symbol): New function.
4017         (objfile_object_methods): Add new functions.
4018
4019 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4020
4021         * NEWS: Mention 'set|show print frame-info'.  Mention new
4022         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4023         backtrace argument.  Mention that python frame filtering code
4024         is now consistent with what 'backtrace' command prints.
4025
4026 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4027
4028         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4029         comments.
4030         (print_frame_info_auto, print_frame_info_source_line,
4031         print_frame_info_location, print_frame_info_source_and_location,
4032         print_frame_info_location_and_address, print_frame_info_short_location):
4033         New declarations.
4034         (struct frame_print_options): New member print_frame_info.
4035         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4036         * stack.h (get_user_print_what_frame_info): New declaration.
4037         (frame_show_address): New declaration.
4038         * stack.c (print_frame_arguments_choices): New value 'presence'.
4039         (print_frame_info_auto, print_frame_info_source_line,
4040         print_frame_info_location, print_frame_info_source_and_location,
4041         print_frame_info_location_and_address, print_frame_info_short_location,
4042         print_frame_info_choices, print_frame_info_print_what): New definitions.
4043         (print_frame_args): Only print dots for args if print frame-arguments
4044         is 'presence'.
4045         (frame_print_option_defs): New element for "frame-info".
4046         (get_user_print_what_frame_info): New function.
4047         (frame_show_address): Make non static.  Move comment to stack.h.
4048         (print_frame_info_to_print_what): New function.
4049         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4050         to decide what to print.
4051         (backtrace_command_1): Handle the new print_frame_arguments_presence
4052         value.
4053         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4054         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4055         (py_print_frame): In non-mi mode, use LOCATION as default for
4056         print_what, similarly to frame information printed directly by
4057         backtrace command. Handle frame-info user option in non MI mode.
4058
4059 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4060
4061         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4062         Add case for debugging 32-bit target on 64-bit host.  Revise
4063         comment.
4064
4065 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4066
4067         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4068         instead of find_function_entry_range_from_pc.
4069
4070 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4071
4072         * stack.c (find_frame_funname): Remove code which preferred
4073         minsym over symtab sym in "certain pathological cases".
4074
4075         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4076         parameter.  Change type of "do_demangle" to bool.
4077         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4078         Pass suitable "prefer_sym_over_minsym" flag to
4079         build_address_symbolic().  Don't output "+" for negative offsets.
4080         * printcmd.c (print_address_symbolic): Update invocation of
4081         build_address_symbolic to include a "prefer_sym_over_minsym"
4082         flag.
4083         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4084         Restrict cases in which use of minimal symbol is preferred to that
4085         of a found symbol.  Update comments.
4086
4087         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4088         for entry pc when entry pc is out of range for that FDE.
4089
4090 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4091
4092         PR gdb/24839:
4093         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4094         type.
4095
4096 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4097
4098         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4099         this function's Python signature.
4100
4101
4102 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4103
4104         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4105         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4106         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4107         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4108         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4109
4110
4111 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4112
4113         * h8300-tdep.c (h8300_register_name_common): New.
4114         h8300_register_name): Use h8300_register_name_common.
4115         (h8300s_register_name): Likewise.
4116         (h8300sx_register_name): Likewise.
4117         (h8300h_register_nam): New.
4118         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4119
4120
4121 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4122
4123         * arm-tdep.c (arm_skip_cmse_entry): New function.
4124         (arm_is_sgstubs_section): New function.
4125         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4126
4127 2019-07-22  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4130         Don't self-assign.
4131
4132 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4135         type_print.
4136
4137 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4140         so that GDB doesn't match any msymbols when searching in the
4141         TYPES_DOMAIN.
4142         (print_symbol_info): Print using typedef_print or type_print based
4143         on the type of the symbol.  Add updated FIXME comment moved from...
4144         (_initialize_symtab): ... move and update FIXME comment to above.
4145
4146 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * NEWS: Mention adding -q option to "info types".
4149         * symtab.c (struct info_types_options): New struct.
4150         (info_types_options_defs): New variable.
4151         (make_info_types_options_def_group): New function.
4152         (info_types_command): Use gdb::option framework to parse options.
4153         (info_types_command_completer): New function.
4154         (_initialize_symtab): Extend the help text on "info types" and
4155         register command completer.
4156
4157 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4158
4159         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4160         (lookup_symbol_in_objfile): Change int to block_enum and add a
4161         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4162
4163 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4164
4165         * MAINTAINERS (Write After Approval): Add self.
4166
4167 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4170         instruction to the dummy code region.
4171
4172 2019-07-19  Tom Tromey  <tromey@adacore.com>
4173
4174         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4175         (ARGSUSED, PARAMS, __func__): Remove rules.
4176
4177 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4178
4179         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4180         * features/arm/arm-with-iwmmxt.c: Remove.
4181         * features/arm/arm-with-iwmmxt.xml: Remove.
4182         * features/arm/arm-with-m-fpa-layout.c: Remove.
4183         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4184         * features/arm/arm-with-m-vfp-d16.c: Remove.
4185         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4186         * features/arm/arm-with-m.c: Remove.
4187         * features/arm/arm-with-m.xml: Remove.
4188         * features/arm/arm-with-neon.c: Remove.
4189         * features/arm/arm-with-neon.xml: Remove.
4190         * features/arm/arm-with-vfpv2.c: Remove.
4191         * features/arm/arm-with-vfpv2.xml: Remove.
4192         * features/arm/arm-with-vfpv3.c: Remove.
4193         * features/arm/arm-with-vfpv3.xml: Remove.
4194
4195 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4196
4197         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4198
4199 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * arch/aarch32.c (aarch32_create_target_description): Create
4202         target descriptions using features.
4203         * arch/arm.c (arm_create_target_description)
4204         (arm_create_mprofile_target_description): Likewise.
4205         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4206
4207 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4208
4209         * Makefile.in: Add new files.
4210         * aarch32-tdep.c: New file.
4211         * aarch32-tdep.h: New file.
4212         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4213         Call aarch32_read_description.
4214         * arch/aarch32.c: New file.
4215         * arch/aarch32.h: New file.
4216         * arch/arm.c (arm_create_target_description)
4217         (arm_create_mprofile_target_description): New function.
4218         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4219         (arm_create_target_description)
4220         (arm_create_mprofile_target_description): New declaration.
4221         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4222         read_description functions.
4223         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4224         Likewise.
4225         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4226         * arm-tdep.c (tdesc_arm_list): New variable.
4227         (arm_register_g_packet_guesses): Call create description functions.
4228         (arm_read_description) (arm_read_mprofile_description): New
4229         function.
4230         * arm-tdep.h (arm_read_description)
4231         (arm_read_mprofile_description): Add declaration.
4232         * configure.tgt: Add new files.
4233
4234 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4235
4236         * top.c (new_ui_command): Open specified terminal just once.
4237
4238 2019-07-18  Tom Tromey  <tromey@adacore.com>
4239
4240         * symtab.c (main_name): Constify return type.
4241         * symfile.c (set_initial_language): Update.
4242         * symtab.h (main_name): Constify return type.
4243
4244 2019-07-17  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-winsource.c (tui_update_source_window)
4247         (tui_update_source_window_as_is)
4248         (tui_update_source_windows_with_line): Remove return.
4249         * tui/tui-disasm.c (tui_show_disassem)
4250         (tui_show_disassem_and_update_source): Remove return.
4251         * tui/tui.c (tui_reset): Remove return.
4252         * tui/tui-wingeneral.c
4253         (tui_check_and_display_highlight_if_needed): Remove return.
4254
4255 2019-07-17  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4258
4259 2019-07-17  Tom Tromey  <tom@tromey.com>
4260
4261         * tui/tui-winsource.h (struct tui_exec_info_window)
4262         (struct tui_source_window_base): Move from tui-data.h.
4263         * tui/tui-winsource.c: Move many method definitions from
4264         elsewhere.  Remove "structuring" comments.
4265         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4266         (tui_source_window_base::refresh_window): Move to
4267         tui-winsource.c.
4268         * tui/tui-win.c (tui_source_window_base::refresh_all)
4269         (tui_source_window_base::update_tab_width)
4270         (tui_source_window_base::set_new_height)
4271         (tui_source_window_base::do_make_visible_with_new_height): Move to
4272         tui-winsource.c.
4273         * tui/tui-source.h: Update.
4274         * tui/tui-source.c (tui_source_window_base::reset): Move to
4275         tui-winsource.c.
4276         * tui/tui-disasm.h: Update.
4277         * tui/tui-data.h (struct tui_exec_info_window): Move to
4278         tui-winsource.h.
4279         (struct tui_source_window_base): Likewise.
4280         * tui/tui-data.c (tui_source_window_base::clear_detail)
4281         (tui_source_window_base, ~tui_source_window_base): Move to
4282         tui-winsource.c.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-win.c (tui_resize_all)
4287         (tui_source_window_base::update_tab_width)
4288         (tui_adjust_win_heights): Update.
4289         (tui_win_info::make_invisible_and_set_new_height): Rename from
4290         make_invisible_and_set_new_height.
4291         * tui/tui-data.h (struct tui_win_info)
4292         <make_invisible_and_set_new_height>: New method.
4293
4294 2019-07-17  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui.c: Update.
4297         * tui/tui-source.h (struct tui_source_window): Move from
4298         tui-data.h.
4299         * tui/tui-layout.c: Update.
4300         * tui/tui-disasm.c: Update.
4301         * tui/tui-data.h (struct tui_source_window): Move to
4302         tui-source.h.
4303
4304 2019-07-17  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4307         tui-data.h.
4308         * tui/tui-data.h (struct tui_disasm_window): Move to
4309         tui-disasm.h.
4310
4311 2019-07-17  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui-regs.h (struct tui_data_item_window): Move from
4314         tui-data.h.
4315         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4316         * tui/tui-data.h (struct tui_data_item_window): Move to
4317         tui-regs.h.
4318         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4319
4320 2019-07-17  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui.c: Update.
4323         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4324         (tui_cmd_window::max_height): Move to tui-command.c.
4325         * tui/tui-layout.c: Update.
4326         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4327         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4328         tui-command.c.
4329         * tui/tui-command.h (struct tui_cmd_window): Move from
4330         tui-data.h.
4331         * tui/tui-command.c: Remove "structuring" comments.
4332         (tui_cmd_window::clear_detail)
4333         (tui_cmd_window::do_make_visible_with_new_height)
4334         (tui_cmd_window::max_height): Move from elsewhere.
4335
4336 2019-07-17  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4339         Now static.
4340         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4341         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4342
4343 2019-07-17  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui.c: Update.
4346         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4347         tui-regs.c.
4348         * tui/tui-windata.h: Remove file.
4349         * tui/tui-windata.c: Remove file.
4350         * tui/tui-win.c (tui_data_window::set_new_height)
4351         (tui_data_window::do_make_visible_with_new_height): Move to
4352         tui-regs.c.
4353         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4354         * tui/tui-regs.c: Remove "structuring" comments.
4355         (tui_data_window::first_data_item_displayed)
4356         (tui_data_window::delete_data_content_windows)
4357         (tui_data_window::erase_data_content)
4358         (tui_data_window::display_all_data)
4359         (tui_data_window::refresh_all)
4360         (tui_data_window::do_scroll_vertical)
4361         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4362         (tui_data_window::do_make_visible_with_new_height)
4363         (tui_data_window::refresh_window): Move from elsewhere.
4364         (_initialize_tui_regs): Move to end of file.
4365         * tui/tui-layout.c: Update.
4366         * tui/tui-hooks.c: Update.
4367         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4368         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4369         tui-regs.c.
4370         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4371
4372 2019-07-17  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4375         seen.
4376
4377 2019-07-17  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-win.c (tui_source_window_base::set_new_height)
4380         (tui_source_window_base::do_make_visible_with_new_height): Use
4381         m_has_locator field directly.
4382         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4383         method.
4384         (struct tui_source_window_base) <has_locator>: Likewise.
4385
4386 2019-07-17  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4389         Don't declare.
4390         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4391         Remove.
4392         * tui/tui-win.c (tui_source_window_base::set_new_height)
4393         (tui_source_window_base::set_new_height)
4394         (make_invisible_and_set_new_height)
4395         (tui_source_window_base::do_make_visible_with_new_height)
4396         (tui_source_window_base::do_make_visible_with_new_height):
4397         Update.
4398         * tui/tui-layout.c (show_source_disasm_command, show_data)
4399         (show_source_or_disasm_and_command): Update.
4400         * tui/tui-layout.c (show_layout): Update.
4401
4402 2019-07-17  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-layout.c (make_data_window): Remove.
4405         (show_data): Unify creation and re-initialization cases.
4406
4407 2019-07-17  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-layout.c (make_source_window, make_disasm_window):
4410         Remove.
4411         (show_data): Unify creation and re-initialization cases.
4412
4413 2019-07-17  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-layout.c (make_command_window): Remove.
4416         (show_source_disasm_command, show_source_or_disasm_and_command):
4417         Unify creation and re-initialization cases.
4418
4419 2019-07-17  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4422         creation and re-initialization cases.
4423
4424 2019-07-17  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-regs.c (tui_get_register): Return void.
4427
4428 2019-07-17  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4431         Simplify.
4432
4433 2019-07-17  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4436         resetting.
4437
4438 2019-07-17  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4441         * tui/tui-regs.c (tui_reg_layout): New function.
4442         (tui_show_registers, tui_reg_command): Use it.
4443         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4444         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4445         parameters.
4446         (tui_layout_command): Remove.
4447
4448 2019-07-17  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-layout.h (tui/tui-layout): Return void.
4451         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4452
4453 2019-07-17  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui-layout.c (show_source_disasm_command, show_data):
4456         Update.
4457         (reset_locator): Remove.
4458         (show_source_or_disasm_and_command): Update.
4459
4460 2019-07-17  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-source.c (tui_source_window_base::reset): Remove
4463         win_type parameter.
4464         * tui/tui-layout.c (make_command_window, make_source_window)
4465         (make_disasm_window, make_data_window)
4466         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4467         (reset_locator, show_source_or_disasm_and_command): Update.
4468         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4469         win_type parameter.
4470         (struct tui_source_window_base) <reset>: Likewise.
4471
4472 2019-07-17  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-layout.c (show_source_disasm_command): Use
4475         reset_locator.
4476         (reset_locator): New function.
4477         (init_and_make_win): Remove.
4478         (show_source_or_disasm_and_command): Use reset_locator.
4479
4480 2019-07-17  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4483         condition.
4484         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4485         Remove condition.
4486         * tui/tui-source.c (tui_source_window_base::reset): New method.
4487         * tui/tui-layout.c (make_command_window): Don't call
4488         init_and_make_win.
4489         (make_source_window, make_disasm_window): Don't call
4490         make_source_or_disasm_window.
4491         (make_data_window): Don't call init_and_make_win.  Change calling
4492         convention.
4493         (show_source_disasm_command, show_data): Simplify.
4494         (make_source_or_disasm_window): Remove.
4495         (show_source_or_disasm_and_command): Simplify.
4496         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4497         (struct tui_source_window_base) <reset>: Likewise.
4498         <execution_info>: Remove initializer.
4499         * tui/tui-data.c (tui_source_window_base): Initialize
4500         execution_info.
4501
4502 2019-07-17  Tom Tromey  <tom@tromey.com>
4503
4504         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4505         variable.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui.c (tui_rl_other_window): Update.
4510         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4511         superclass method first.  Always iterate over regs_content.
4512         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4513         method.
4514         * tui/tui-win.c (tui_set_focus_command): Update.
4515
4516 2019-07-17  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-win.c (tui_set_focus_command): Rename from
4519         tui_set_focus.  Call tui_enable.
4520         (tui_set_focus_command): Remove.
4521
4522 2019-07-17  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4525         refresh_window.
4526         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4527         touchwin.
4528         (tui_data_window::refresh_window): Call refresh_window on data
4529         items.  Always call superclass refresh_window.
4530         (tui_win_info::refresh): Remove.
4531         (tui_source_window_base::refresh_window): Update.
4532         (tui_refresh_all): Update.
4533         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4534         refresh_window.
4535         (show_source_or_disasm_and_command): Likewise.
4536         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4537         (struct tui_source_window_base) <refresh>: Likewise.
4538
4539 2019-07-17  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-winsource.c (tui_clear_source_content)
4542         (tui_show_source_content): Update.
4543         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4544         whether content is empty.
4545         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4546         Remove.
4547
4548 2019-07-17  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4551         window's contents.
4552         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4553         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4554
4555 2019-07-17  Tom Tromey  <tom@tromey.com>
4556
4557         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4558         (struct tui_data_item_window): Update.
4559
4560 2019-07-17  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4563         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4564         defines.
4565
4566 2019-07-17  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-winsource.h (tui_erase_source_content)
4569         (tui_clear_source_content): Remove "display_prompt" parameter.
4570         * tui/tui-winsource.c (tui_update_source_window_as_is)
4571         (tui_update_source_windows_with_addr): Update.
4572         (tui_clear_source_content): Remove "display_prompt" parameter.
4573         (tui_erase_source_content): Likewise.  Simplify.
4574         (tui_show_source_content): Update.
4575         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4576         * tui/tui-stack.c (tui_show_frame_info): Update.
4577         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4578         Remove defines.
4579
4580 2019-07-17  Tom Tromey  <tom@tromey.com>
4581
4582         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4583         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4584         parameter.
4585         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4586         parameter.
4587
4588 2019-07-17  Tom Tromey  <tom@tromey.com>
4589
4590         * tui/tui-winsource.c (tui_clear_source_content)
4591         (tui_show_source_content, tui_show_exec_info_content)
4592         (tui_clear_exec_info_content): Update.
4593         * tui/tui-stack.c (tui_show_locator_content): Update.
4594         (tui_show_frame_info): Update.
4595         * tui/tui-source.h (tui_source_window): Don't declare.
4596         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4597         from tui_source_is_displayed.
4598         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4599         Remove field.
4600         (struct tui_source_window_base) <content_in_use>: New field.  Now
4601         bool.
4602         (struct tui_source_window) <showing_source_p>: New method.
4603         (TUI_SRC_WIN): Change cast.
4604         * tui/tui-data.c (tui_initialize_static_data): Update.
4605
4606 2019-07-17  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4609         location_matches_p.
4610         * tui/tui-source.c (tui_source_window::location_matches_p): New
4611         method.
4612         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4613         method.
4614         * tui/tui-data.h (struct tui_source_window_base)
4615         <location_matches_p>: New method.
4616         (struct tui_source_window, struct tui_disasm_window)
4617         <location_matches_p>: Likewise.
4618
4619 2019-07-17  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-win.c (tui_set_win_height_command): Rename from
4622         tui_set_win_height.
4623         (tui_set_win_height_command): Remove.
4624
4625 2019-07-17  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-source.c (tui_source_window): New constructor.  Add
4628         observer.
4629         (~tui_source_window): New destructor.
4630         (tui_source_window::style_changed): New method.
4631         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4632         (tui_attach_detach_observers): Update.
4633         * tui/tui-data.h (struct tui_source_window): Make constructor not
4634         inline.  Add destructor.
4635         (struct tui_source_window) <style_changed>: New method.
4636         <m_observable>: New member.
4637
4638 2019-07-17  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4641         * tui/tui-win.c (tui_resize_all): Fix typo.
4642
4643 2019-07-17  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4646         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4647         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4648         * tui/tui-win.c (window_name_completer): Use foreach.
4649         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4650         (update_tab_width): Likewise.
4651         * tui/tui-layout.c (show_layout): Update.
4652         * tui/tui-data.h (class tui_window_iterator): New.
4653         (struct all_tui_windows): New.
4654         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4655
4656 2019-07-17  Tom Tromey  <tom@tromey.com>
4657
4658         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4659         parameter.  Don't reference globals.
4660         (tui_reg_command): Update.
4661
4662 2019-07-17  Tom Tromey  <tom@tromey.com>
4663
4664         * tui/tui-regs.c (tui_show_registers): Simplify.
4665
4666 2019-07-17  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-regs.c (tui_show_registers): Update.
4669         (tui_show_register_group): Add win_info parameter.
4670
4671 2019-07-17  Tom Tromey  <tom@tromey.com>
4672
4673         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4674         Rename from tui_display_reg_element_at_line.
4675         (tui_data_window::display_registers_from_line): Update.
4676         * tui/tui-data.h (struct tui_data_window)
4677         <display_reg_element_at_line>: New method.
4678
4679 2019-07-17  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-regs.h (tui_display_registers_from)
4682         (tui_display_registers_from_line): Don't declare.
4683         * tui/tui-windata.c (tui_data_window::display_all_data)
4684         (tui_data_window::refresh_all)
4685         (tui_data_window::do_scroll_vertical): Update.
4686         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4687         from tui_display_registers_from.
4688         (tui_display_reg_element_at_line): Update.
4689         (tui_data_window::display_registers_from_line): Rename from
4690         tui_display_registers_from_line.
4691         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4692         display_registers_from_line>: New methods.
4693
4694 2019-07-17  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4697         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4698         from tui_erase_data_content.
4699         (tui_data_window::display_all_data)
4700         (tui_data_window::refresh_all)
4701         (tui_data_window::do_scroll_vertical): Update.
4702         * tui/tui-regs.c (tui_show_registers): Update.
4703         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4704         New method.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4709         declare.
4710         * tui/tui-windata.c
4711         (tui_data_window::delete_data_content_windows): Rename from
4712         tui_delete_data_content_windows.
4713         (tui_data_window::display_all_data)
4714         (tui_data_window::do_scroll_vertical): Update.
4715         * tui/tui-data.h (struct tui_data_window)
4716         <delete_data_content_windows>: New method.
4717
4718 2019-07-17  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4721         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4722
4723 2019-07-17  Tom Tromey  <tom@tromey.com>
4724
4725         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4726         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4727         from tui_display_all_data.
4728         * tui/tui-win.c
4729         (tui_data_window::do_make_visible_with_new_height): Update.
4730         * tui/tui-regs.c (tui_show_registers): Update.
4731         * tui/tui-layout.c (tui_set_layout): Update.
4732         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4733         method.
4734
4735 2019-07-17  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4738         * tui/tui-windata.c (tui_display_data_from): Remove.
4739         (tui_data_window::refresh_all): Update.
4740
4741 2019-07-17  Tom Tromey  <tom@tromey.com>
4742
4743         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4744         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4745         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4746         tui_display_registers_from_line.
4747         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4748         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4749         "force_display" parameter.
4750
4751 2019-07-17  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4754         declare.
4755         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4756         Rename from tui_first_reg_element_no_inline.
4757         (tui_display_reg_element_at_line)
4758         (tui_display_registers_from_line): Update.
4759         * tui/tui-data.h (struct tui_data_window)
4760         <first_reg_element_no_inline>: New method.
4761
4762 2019-07-17  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-windata.c (tui_display_data_from)
4765         (tui_data_window::do_scroll_vertical): Update.
4766         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4767         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4768         Rename from tui_line_from_reg_element_no.
4769         (tui_display_registers_from_line): Update.
4770         * tui/tui-data.h (struct tui_data_window)
4771         <line_from_reg_element_no>: New method.
4772
4773 2019-07-17  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4776         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4777         tui_last_regs_line_no.
4778         (tui_display_reg_element_at_line)
4779         (tui_display_registers_from_line): Update.
4780         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4781         method.
4782
4783 2019-07-17  Tom Tromey  <tom@tromey.com>
4784
4785         PR tui/24722:
4786         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4787         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4788         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4789         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4790         (tui_update_breakpoint_info): Likewise.
4791         * tui/tui-hooks.c (tui_event_create_breakpoint)
4792         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4793         Update.
4794
4795 2019-07-17  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4798
4799 2019-07-17  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-winsource.c (tui_update_source_window_as_is)
4802         (tui_update_source_windows_with_addr): Update.
4803         * tui/tui-source.h (tui_set_source_content)
4804         (tui_show_symtab_source): Add "win_info" parameter.
4805         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4806         parameter.
4807         (tui_show_symtab_source): Likewise.
4808
4809 2019-07-17  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-wingeneral.c
4812         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4813
4814 2019-07-17  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4817         (struct tui_cmd_window) <can_scroll>: New method.
4818         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4819         method.
4820
4821 2019-07-17  Tom Tromey  <tromey@adacore.com>
4822
4823         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4824         do_field_signed>: Rename.  Change type of "value".
4825         * ui-out.c (ui_out::field_signed): Rename from field_int.
4826         Change type of "value".
4827         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4828         type of "value".
4829         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4830         do_field_int.  Change type of "value".
4831         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4832         do_field_int.  Change type of "value".
4833         * tracepoint.c (trace_status_mi, tfind_1)
4834         (print_one_static_tracepoint_marker): Update.
4835         * thread.c (print_thread_info_1, print_selected_thread_frame):
4836         Update.
4837         * stack.c (print_frame, print_frame_info): Update.
4838         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4839         Update.
4840         * source.c (print_source_lines_base): Update.
4841         * skip.c (info_skip_command): Update.
4842         * record-btrace.c (btrace_ui_out_decode_error)
4843         (btrace_call_history_src_line): Update.
4844         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4845         Update.
4846         * progspace.c (print_program_space): Update.
4847         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4848         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4849         do_field_int.  Change type of "value".
4850         * mi/mi-out.c (mi_ui_out::do_table_begin)
4851         (mi_ui_out::do_table_header): Update.
4852         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4853         type of "value".
4854         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4855         (mi_cmd_data_list_changed_registers, output_register)
4856         (mi_cmd_data_read_memory, mi_load_progress)
4857         (mi_cmd_trace_frame_collected): Update.
4858         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4859         Update.
4860         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4861         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4862         (mi_cmd_var_list_children, varobj_update_one): Update.
4863         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4864         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4865         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4866         * inferior.c (print_inferior): Update.
4867         * gdb_bfd.c (print_one_bfd): Update.
4868         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4869         Update.
4870         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4871         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4872         do_field_int.  Change type of "value".
4873         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4874         do_field_int.  Change type of "value".
4875         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4876         (print_one_breakpoint_location, print_it_catch_fork)
4877         (print_one_catch_fork, print_it_catch_vfork)
4878         (print_one_catch_vfork, print_it_catch_solib)
4879         (print_it_catch_exec, print_it_ranged_breakpoint)
4880         (print_mention_watchpoint, print_mention_masked_watchpoint)
4881         (bkpt_print_it, update_static_tracepoint): Update.
4882         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4883         * break-catch-syscall.c (print_it_catch_syscall): Update.
4884         * ada-tasks.c (print_ada_task_info): Update.
4885         * ada-lang.c (print_it_exception, print_mention_exception):
4886         Update.
4887
4888 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         PR breakpoints/24541
4891         * gdbarch.c: Regenerate.
4892         * gdbarch.h: Regenerate.
4893         * gdbarch.sh: Adjust return type and parameter types for
4894         'stap_adjust_register'.
4895         (i386_stap_adjust_register): Adjust signature and return new
4896         register name.
4897         * stap-probe.c (stap_parse_register_operand): Adjust use of
4898         'gdbarch_stap_adjust_register'.
4899
4900 2019-07-17  Tom Tromey  <tromey@adacore.com>
4901
4902         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4903         declare VEC.
4904         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4905         std::vector.
4906         (struct s390_process_info): Add initializers.
4907         (s390_add_process): Use new.
4908         (s390_linux_nat_target::low_forget_process): Use delete.
4909         (s390_linux_nat_target::low_new_fork)
4910         (s390_linux_nat_target::stopped_by_watchpoint)
4911         (s390_linux_nat_target::low_prepare_to_resume)
4912         (s390_linux_nat_target::insert_watchpoint)
4913         (s390_linux_nat_target::insert_hw_breakpoint)
4914         (s390_linux_nat_target::remove_watchpoint)
4915         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4916
4917 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4918
4919         * aarch64-fbsd-nat.c: Include regcache.h.
4920         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4921         argument.
4922         (aarch64_fbsd_nat_target::fetch_registers)
4923         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4924         variable.
4925         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4926
4927 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4928
4929         * fbsd-nat.c: Include gdbarch.h.
4930
4931 2019-07-15  Tom Tromey  <tromey@adacore.com>
4932
4933         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4934
4935 2019-07-15  Tom Tromey  <tromey@adacore.com>
4936
4937         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4938         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4939         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4940         * cli-out.c (cli_ui_out::do_field_int): New method.
4941         * ui-out.c (ui_out::field_unsigned): New method.
4942         * symfile.c (generic_load): Use field_unsigned.
4943         (print_transfer_performance): Likewise.
4944         * record-btrace.c (ui_out_field_uint): Remove.
4945         (btrace_call_history_insn_range, btrace_call_history): Use
4946         field_unsigned.
4947         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4948         field_unsigned.
4949         * ui-out.h (class ui_out) <field_unsigned>: New method.
4950         <do_field_unsigned>: Likewise.
4951
4952 2019-07-15  Tom Tromey  <tromey@adacore.com>
4953
4954         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4955         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4956         * target.c (flash_erase_command): Use field_string.
4957         * infrun.c (print_signal_received_reason): Use field_string.
4958         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4959         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4960         field_string.
4961         * ada-tasks.c (print_ada_task_info): Use field_string.
4962
4963 2019-07-15  Tom Tromey  <tromey@adacore.com>
4964
4965         * target.c (flash_erase_command): Use field_core_addr.
4966         * symfile.c (generic_load): Use field_core_addr.
4967         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4968         Use field_core_addr.
4969         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4970         field_core_addr.
4971
4972 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4975         value if its desired type is smaller than a CORE_ADDR and signed.
4976
4977 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4980         of changes to field names, and use new is_reference field to
4981         decide if a property is a reference or not.
4982         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4983         field.
4984         (struct dwarf2_property_baton): Update header comment, rename
4985         'referenced_type' to 'property_type' and update comments.
4986         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4987         default property type, store in property baton, update to take
4988         accound of renamed field.
4989         (read_func_scope): Update call to attr_to_dynamic_prop.
4990         (read_array_type): Likewise.
4991         (dwarf2_per_cu_addr_sized_int_type): New function.
4992         (read_subrange_index_type): Move type finding code to
4993         dwarf2_per_cu_addr_sized_int_type.
4994         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4995         (dwarf2_per_cu_addr_type): New function.
4996         (set_die_type): Update calls to attr_to_dynamic_prop.
4997
4998 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4999
5000         * dwarf2read.c (read_subrange_index_type): New function.
5001         (read_subrange_type): Move code into new function and call it.
5002         * gdbtypes.c (create_range_type): Add some asserts.
5003
5004 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5007         update return statements.
5008         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5009         declaration, and update comment to match.
5010         * gdbtypes.c (resolve_dynamic_array): Update call to
5011         dwarf2_evaluate_property to match new return type.
5012
5013 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * valarith.c (value_subscripted_rvalue): Change lowerbound
5016         parameter type from int to LONGEST.
5017         * value.h (value_subscripted_rvalue): Likewise in declaration.
5018
5019 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * cli/cli-utils.c (info_print_command_completer): New function.
5022         * cli/cli-utils.h: Add 'completer.h' include, and forward
5023         declaration for 'struct cmd_list_element'.
5024         (info_print_command_completer): Declare.
5025         * stack.c (_initialize_stack): Add completer for 'info locals' and
5026         'info args'.
5027         * symtab.c (_initialize_symtab): Add completer for 'info
5028         variables' and 'info functions'.
5029         * NEWS: Mention completion for additional info commands.
5030
5031 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * cli/cli-utils.c (extract_info_print_args): Delete.
5034         (extract_arg_maybe_quoted): Delete.
5035         (info_print_options_defs): New variable.
5036         (make_info_print_options_def_group): New function.
5037         (extract_info_print_options): Define new function.
5038         * cli/cli-utils.h (extract_info_print_args): Delete.
5039         (struct info_print_options): New structure.
5040         (extract_info_print_options): Declare new function.
5041         * stack.c (info_locals_command): Update to use new
5042         extract_info_print_options, also add a header comment.
5043         (info_args_command): Likewise.
5044         * symtab.c (info_variables_command): Likewise.
5045         (info_functions_command): Likewise.
5046
5047 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5050         to extract string arguments.
5051         * common/common-utils.c (extract_string_maybe_quoted): New function.
5052         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5053
5054 2019-07-11  Tom Tromey  <tromey@adacore.com>
5055
5056         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5057         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5058         * top.h (gdbinit): Don't declare.
5059         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5060         into...
5061         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5062         * top.c (gdb_init): Don't call init_cli_cmds.
5063         (gdbinit): Remove.
5064         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5065
5066 2019-07-11  Tom Tromey  <tromey@adacore.com>
5067
5068         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5069         after it has been moved.
5070
5071 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5072
5073         * valops.c (value_must_coerce_to_target): Change return type to
5074         bool.
5075         * value.h (value_must_coerce_to_target): Likewise.
5076
5077 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5078
5079         * breakpoint.c (is_hardware_watchpoint): Remove
5080         forward-declaration.
5081         (is_masked_watchpoint): Change return type to bool.
5082         (is_tracepoint): Likewise.
5083         (is_breakpoint): Likewise.
5084         (is_hardware_watchpoint): Likewise.
5085         (is_watchpoint): Likewise.
5086         (is_no_memory_software_watchpoint): Likewise.
5087         (is_catchpoint): Likewise.
5088         (breakpoint_1): Make FILTER parameter's return type bool.
5089         is_masked_watchpoint): Change return type to bool.
5090         (save_breakpoints): Make FILTER parameter's return type bool.
5091         * breakpoint.h (is_breakpoint): Change return type to bool.
5092         (is_watchpoint): Likewise.
5093         (is_catchpoint): Likewise.
5094         (is_tracepoint): Likewise.
5095
5096 2019-07-10  Tom Tromey  <tom@tromey.com>
5097
5098         * defs.h: Don't include gdbarch.h.
5099         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5100         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5101         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5102         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5103         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5104         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5105         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5106         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5107         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5108         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5109         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5110         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5111         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5112         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5113         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5114         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5115         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5116         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5117         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5118         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5119         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5120         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5121         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5122         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5123         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5124         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5125         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5126
5127 2019-07-10  Tom Tromey  <tromey@adacore.com>
5128
5129         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5130         * breakpoint.c (init_ada_exception_breakpoint): Register as
5131         bp_catchpoint.
5132         (print_one_breakpoint_location, print_one_breakpoint): Use
5133         is_ada_exception_catchpoint.
5134         * ada-lang.c (class ada_catchpoint_location): Pass
5135         bp_loc_software_breakpoint to bp_location constructor.
5136         (is_ada_exception_catchpoint): New function.
5137
5138 2019-07-10  Tom Tromey  <tromey@adacore.com>
5139
5140         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5141         VEC.
5142         (struct arm_exidx_entry): New method operator<.
5143         (struct arm_exidx_data) <section_maps>: Change type.
5144         (arm_exidx_data_free): Remove.
5145         (arm_exidx_data_key): Change type.  Move lower.
5146         (arm_exidx_new_objfile): Update.
5147         (arm_compare_exidx_entries): Remove.
5148         (arm_find_exidx_entry, _initialize_arm_tdep)
5149
5150 2019-07-10  Tom Tromey  <tromey@adacore.com>
5151
5152         * solib-spu.c (ocl_program_data_key): Change type.
5153         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5154         Update.
5155
5156 2019-07-10  Tom Tromey  <tromey@adacore.com>
5157
5158         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5159         (struct solib_aix_inferior_data) <library_list>: Change type.
5160         (solib_aix_inferior_data_handle): Change type.
5161         (get_solib_aix_inferior_data): Update.
5162         (solib_aix_free_library_list): Remove.
5163         (library_list_start_library): Update.
5164         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5165         return type.
5166         (solib_aix_get_library_list)
5167         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5168         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5169
5170 2019-07-10  Tom Tromey  <tromey@adacore.com>
5171
5172         * solib-dsbt.c (struct dsbt_info): Add initializers.
5173         (solib_dsbt_pspace_data): Change type.
5174         (dsbt_pspace_data_cleanup): Remove.
5175         (get_dsbt_info, _initialize_dsbt_solib): Update.
5176
5177 2019-07-10  Tom Tromey  <tromey@adacore.com>
5178
5179         * spu-tdep.c (spu_overlay_data): Change type.
5180         (spu_get_overlay_table, spu_overlay_new_objfile)
5181         (_initialize_spu_tdep): Update.
5182
5183 2019-07-10  Tom Tromey  <tromey@adacore.com>
5184
5185         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5186         destructor.
5187         (dbx_objfile_data_key): Change type and declare later.
5188         (DBX_SYMFILE_INFO): Rewrite.
5189         * dbxread.c (dbx_objfile_data_key): Change type.
5190         (dbx_symfile_init): Update.
5191         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5192         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5193         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5194
5195 2019-07-10  Tom Tromey  <tromey@adacore.com>
5196
5197         * jit.c (jit_program_space_key): Change type.  Move lower.
5198         (get_jit_program_space_data): Update.
5199         (jit_program_space_data_cleanup): Remove.
5200         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5201         Update.
5202         (struct jit_program_space_data): Add initializers.
5203
5204 2019-07-10  Tom Tromey  <tromey@adacore.com>
5205
5206         * solib-darwin.c (struct darwin_info): Add initializers.
5207         (solib_darwin_pspace_data): Change type.
5208         (darwin_pspace_data_cleanup): Remove.
5209         (get_darwin_info, _initialize_darwin_solib): Update.
5210
5211 2019-07-10  Tom Tromey  <tromey@adacore.com>
5212
5213         * remote-sim.c (struct sim_inferior_data): Add initializers,
5214         constructor, and destructor.
5215         (sim_inferior_data_key): Change type.  Move lower.
5216         (check_for_duplicate_sim_descriptor): Update.
5217         (get_sim_inferior_data): Use new.  Update.
5218         (~sim_inferior_data_cleanup): Rename from
5219         sim_inferior_data_cleanup.  Simplify.
5220         (gdbsim_close_inferior, simulator_command)
5221         (sim_command_completer, _initialize_remote_sim): Update.
5222         (next_pid, INITIAL_PID): Move earlier.
5223
5224 2019-07-10  Tom Tromey  <tromey@adacore.com>
5225
5226         * python/python-internal.h (create_thread_object): Return
5227         gdbpy_ref.
5228         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5229         * python/py-inferior.c (struct threadlist_entry): Add
5230         constructor.
5231         <thread_obj>: Now a gdbpy_ref.
5232         (thread_to_thread_object): Update.
5233         (add_thread_object): Use new.
5234         (delete_thread_object): Use delete.
5235         (infpy_threads): Update.
5236         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5237         GIL.
5238
5239 2019-07-10  Tom Tromey  <tromey@adacore.com>
5240
5241         * valops.c (value_cast): Specialize error message for Ada.
5242
5243 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5244
5245         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5246
5247 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5248
5249         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5250         bpstat_should_step): Return bool, adjust comments.
5251         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5252         bpstat_should_step): Likewise.
5253
5254 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5255
5256         * features/Makefile: Use feature target descriptions for Arm.
5257         * features/arm/arm-core.c: Generate new file.
5258         * features/arm/arm-fpa.c: Likewise.
5259         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5260         * features/arm/arm-m-profile.c: Likewise.
5261         * features/arm/arm-vfpv2.c: Likewise.
5262         * features/arm/arm-vfpv3.c: Likewise.
5263         * features/arm/xscale-iwmmxt.c: Likewise.
5264         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5265
5266 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5267
5268         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5269         ptrace earlier.
5270
5271 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5272
5273         * features/aarch64-pauth.c: Regenerate.
5274
5275 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5276
5277         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5278         bool.
5279         (bpstat_what): Use false instead of 0.
5280
5281 2019-07-09  Pedro Alves  <palves@redhat.com>
5282
5283         * break-catch-throw.c (is_exception_catchpoint): New.
5284         * breakpoint.c (print_one_breakpoint_location): New parameter
5285         'raw_loc'.  Handle it.  Use
5286         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5287         looking at the breakpoint's type.
5288         (print_one_breakpoint): If handling "maint info breakpoints", also
5289         print locations of exception catchpoints.
5290         * breakpoint.h (is_exception_catchpoint): Declare.
5291
5292 2019-07-09  Pedro Alves  <palves@redhat.com>
5293
5294         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5295         "addr" field.
5296         (allocate_location_exception_catchpoint): New.
5297         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5298         (initialize_throw_catchpoint_ops): Install
5299         allocate_location_exception_catchpoint as allocate_location
5300         method.
5301         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5302         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5303         bp_loc_other.
5304         (breakpoint_address_is_meaningful): Delete.
5305         (bl_address_is_meaningful): New.
5306         (breakpoint_locations_match): Adjust comment.
5307         (bp_location_from_bp_type): New, factored out of...
5308         (bp_location::bp_location(breakpoint *)): ... this.
5309         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5310         factored out of...
5311         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5312         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5313         breakpoint_address_is_meaningful.
5314         (bp_locations_compare): Adjust comment.
5315         (update_global_location_list): Use bl_address_is_meaningful
5316         instead of breakpoint_address_is_meaningful.
5317         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5318         explicit.
5319         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5320         * python/py-breakpoint.c (bppy_get_location): No longer check
5321         whether location is null.
5322
5323 2019-07-09  Pedro Alves  <palves@redhat.com>
5324
5325         PR c++/15468
5326         * breakpoint.c (print_one_breakpoint_location): Remove
5327         single-location assert.
5328
5329 2019-07-09  Tom Tromey  <tom@tromey.com>
5330
5331         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5332         * configure: Rebuild.
5333         * configure.ac: Change common to gdbsupport.
5334         * gdbsupport: Rename from common.
5335         * acinclude.m4: Change common to gdbsupport.
5336         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5337         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5338         gdbsupport.
5339         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5340         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5341         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5342         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5343         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5344         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5345         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5346         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5347         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5348         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5349         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5350         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5351         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5352         coff-pe-read.c, command.h, compile/compile-c-support.c,
5353         compile/compile-c.h, compile/compile-cplus-symbols.c,
5354         compile/compile-cplus-types.c, compile/compile-cplus.h,
5355         compile/compile-loc2c.c, compile/compile.c, completer.c,
5356         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5357         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5358         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5359         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5360         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5361         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5362         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5363         features/aarch64-core.c, features/aarch64-fpu.c,
5364         features/aarch64-pauth.c, features/aarch64-sve.c,
5365         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5366         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5367         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5368         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5369         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5370         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5371         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5372         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5373         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5374         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5375         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5376         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5377         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5378         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5379         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5380         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5381         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5382         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5383         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5384         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5385         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5386         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5387         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5388         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5389         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5390         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5391         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5392         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5393         minsyms.c, mips-linux-tdep.c, namespace.h,
5394         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5395         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5396         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5397         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5398         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5399         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5400         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5401         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5402         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5403         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5404         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5405         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5406         procfs.c, producer.c, progspace.h, psymtab.h,
5407         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5408         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5409         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5410         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5411         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5412         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5413         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5414         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5415         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5416         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5417         target-memory.c, target.c, target.h, target/waitstatus.c,
5418         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5419         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5420         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5421         unittests/array-view-selftests.c,
5422         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5423         unittests/common-utils-selftests.c,
5424         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5425         unittests/format_pieces-selftests.c,
5426         unittests/function-view-selftests.c,
5427         unittests/lookup_name_info-selftests.c,
5428         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5429         unittests/mkdir-recursive-selftests.c,
5430         unittests/observable-selftests.c,
5431         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5432         unittests/parse-connection-spec-selftests.c,
5433         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5434         unittests/scoped_fd-selftests.c,
5435         unittests/scoped_mmap-selftests.c,
5436         unittests/scoped_restore-selftests.c,
5437         unittests/string_view-selftests.c, unittests/style-selftests.c,
5438         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5439         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5440         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5441         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5442         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5443         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5444
5445 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5446
5447         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5448         bool value.
5449         (decode_digits_ordinary): Set explicit_line field in sal.
5450         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5451         symtab_and_line that was set on an explicit line number in
5452         assembler code.  Do always update the recorded symtab and line if
5453         we do skip the prologue.
5454
5455 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * breakpoint.c (set_breakpoint_location_function): Remove
5458         explicit_loc parameter.
5459         (momentary_breakpoint_from_master): Update call to
5460         set_breakpoint_location_function.
5461         (add_location_to_breakpoint): Likewise.
5462
5463 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5466         required features based on default bfd type when no specific bfd
5467         is present.
5468
5469 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5470
5471         * NEWS: Mention that GDB printf and eval commands can now print
5472         C-style and Ada-style convenience var strings without
5473         calling the inferior.
5474         * printcmd.c (printf_c_string): Locally print GDB internal var
5475         instead of transiting via the inferior.
5476         (printf_wide_c_string): Likewise.
5477
5478 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5479
5480         PR breakpoints/25011
5481         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5482
5483 2019-07-04  Tom Tromey  <tom@tromey.com>
5484
5485         PR tui/24724:
5486         * tui/tui-winsource.c (tui_clear_source_content): Update.
5487         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5488         (tui_update_breakpoint_info): Update.
5489         (tui_set_exec_info_content): Update.
5490         * tui/tui-source.c (tui_set_source_content_nil): Update.
5491         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5492         has_break.
5493         * tui/tui-data.h (enum tui_bp_flag): New.
5494         (tui_bp_flags): New enum flags type.
5495         (struct tui_source_element) <break_mode>: Change type.  Rename
5496         from has_break.
5497         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5498         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5499         constants.
5500         * tui/tui-winsource.h: Fix comment.
5501
5502 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5503
5504         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5505         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5506         (store_fpregs_to_thread)
5507         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5508         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5509         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5510         (IWMMXT_REGS_SIZE): Add define.
5511         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5512         (fetch_vfp_regs, store_vfp_regs)
5513         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5514         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5515
5516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5517
5518         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5519         defines.
5520         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5521         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5522         (ARM_INT_REGISTER_SIZE): ...to this.
5523         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5524         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5525         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5526         (arm_linux_collect_gregset, supply_nwfpe_register)
5527         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5528         defines.
5529         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5530         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5531         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5532         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5533         (arm_return_in_memory, arm_store_return_value)
5534         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5535         (arm_record_ld_st_multiple): Likewise.
5536         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5537         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5538
5539 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5540
5541         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5542         AARCH64_DISPLACED_MODIFIED_INSNS.
5543         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5544         (aarch64_displaced_step_copy_insn): Likewise.
5545         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5546         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5547         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5548         ARM_DISPLACED_MODIFIED_INSNS.
5549         * arm-tdep.c (arm_gdbarch_init): Likewise.
5550         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5551         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5552         (struct arm_displaced_step_closure): Use
5553         ARM_DISPLACED_MODIFIED_INSNS.
5554
5555 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5556
5557         * features/Makefile: Remove unused xml files.
5558         * features/aarch64.xml: Remove.
5559         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5560         * features/i386/amd64-avx-avx512.xml: Remove.
5561         * features/i386/amd64-avx-linux.xml: Remove.
5562         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5563         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5564         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5565         * features/i386/amd64-avx-mpx.xml: Remove.
5566         * features/i386/amd64-avx.xml: Remove.
5567         * features/i386/amd64-linux.xml: Remove.
5568         * features/i386/amd64-mpx-linux.xml: Remove.
5569         * features/i386/amd64-mpx.xml: Remove.
5570         * features/i386/amd64.xml: Remove.
5571         * features/i386/i386-avx-avx512-linux.xml: Remove.
5572         * features/i386/i386-avx-avx512.xml: Remove.
5573         * features/i386/i386-avx-linux.xml: Remove.
5574         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5575         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5576         * features/i386/i386-avx-mpx-linux.xml: Remove.
5577         * features/i386/i386-avx-mpx.xml: Remove.
5578         * features/i386/i386-avx.xml: Remove.
5579         * features/i386/i386-linux.xml: Remove.
5580         * features/i386/i386-mmx-linux.xml: Remove.
5581         * features/i386/i386-mmx.xml: Remove.
5582         * features/i386/i386-mpx-linux.xml: Remove.
5583         * features/i386/i386-mpx.xml: Remove.
5584         * features/i386/i386.xml: Remove.
5585         * features/i386/x32-avx-avx512-linux.xml: Remove.
5586         * features/i386/x32-avx-linux.xml: Remove.
5587         * features/i386/x32-linux.xml: Remove.
5588
5589 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5590
5591         * regformats/aarch64.dat: Remove.
5592         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5593         * regformats/i386/amd64-avx-linux.dat: Remove.
5594         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5595         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5596         * regformats/i386/amd64-linux.dat: Remove.
5597         * regformats/i386/amd64-mpx-linux.dat: Remove.
5598         * regformats/i386/amd64.dat: Remove.
5599         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5600         * regformats/i386/i386-avx-linux.dat: Remove.
5601         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5602         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5603         * regformats/i386/i386-linux.dat: Remove.
5604         * regformats/i386/i386-mmx-linux.dat: Remove.
5605         * regformats/i386/i386-mpx-linux.dat: Remove.
5606         * regformats/i386/i386.dat: Remove.
5607         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5608         * regformats/i386/x32-avx-linux.dat: Remove.
5609         * regformats/i386/x32-linux.dat: Remove.
5610
5611 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5612
5613         * aarch64-tdep.c: Remove xml self tests.
5614         * amd64-linux-tdep.c: Likewise.
5615         * amd64-tdep.c: Likewise.
5616         * i386-linux-tdep.c: Likewise.
5617         * i386-tdep.c: Likewise.
5618
5619 2019-07-03  Pedro Alves  <palves@redhat.com>
5620
5621         PR cli/24732
5622         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5623         (pipe_cmd_option_defs): New.
5624         (make_pipe_cmd_options_def_group): New.
5625         (pipe_command): Use gdb::option::process_options.
5626         (pipe_command_completer): New function.
5627         (_initialize_cli_cmds): Install completer for "pipe" command.
5628
5629 2019-07-03  Pedro Alves  <palves@redhat.com>
5630
5631         * cli/cli-option.c (union option_value) <string>: New field.
5632         (struct option_def_and_value): Add ctor, move ctor, dtor and
5633         use DISABLE_COPY_AND_ASSIGN.
5634         (option_def_and_value::clear_value): New.
5635         (parse_option, save_option_value_in_ctx, get_val_type_str)
5636         (add_setshow_cmds_for_options): Handle var_string.
5637         * cli-option.h (union option_def::var_address) <string>: New
5638         field.
5639         (struct string_option_def): New.
5640         * maint-test-options.c (struct test_options_opts): Add default
5641         ctor and use DISABLE_COPY_AND_ASSIGN.
5642         <string_opt>: New field.
5643         (test_options_opts::~test_options_opts): New.
5644         (test_options_opts::dump): Also dump "-string".
5645         (test_options_option_defs): Install "string.
5646
5647 2019-07-03  Pedro Alves  <palves@redhat.com>
5648
5649         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5650         option_value with a null enumeration.
5651         (complete_options): Save the option values in the context.
5652         (save_option_value_in_ctx): New, factored out from ...
5653         (process_options): ... here.
5654         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5655         of the function.
5656         * maint-test-options.c (test_options_opts::dump): New, factored
5657         out from ...
5658         (maintenance_test_options_command_mode): ... here.
5659         (maintenance_test_options_command_completion_result): Delete.
5660         (maintenance_test_options_command_completion_text): Update
5661         comment.
5662         (maintenance_show_test_options_completion_result): Change
5663         prototype.  Just print
5664         maintenance_test_options_command_completion_text.
5665         (save_completion_result): New.
5666         (maintenance_test_options_completer_mode): Pass options context to
5667         complete_options, and then save a dump.
5668         (_initialize_maint_test_options): Use add_cmd to install "maint
5669         show test-options-completion-result".
5670
5671 2019-07-03  Pedro Alves  <palves@redhat.com>
5672
5673         * NEWS (New commands): Mention "with" and "maint with".
5674         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5675         (with_command, with_command_completer): New.
5676         (pipe_command): Adjust to new repeat_previous
5677         interface.
5678         (_initialize_cli_cmds): Install the "with" command and its "w"
5679         alias.
5680         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5681         declarations.
5682         * cli/cli-setshow.c (parse_cli_var_uinteger)
5683         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5684         argument strings for all var_types.
5685         (get_setshow_command_value_string): New, factored out from ...
5686         (do_show_command): ... this.
5687         * cli/cli-setshow.h: Include <string>.
5688         (get_setshow_command_value_string): Declare.
5689         * command.h (repeat_previous): Now returns const char *.  Adjust
5690         comment.
5691         * maint.c: Include "cli/cli-cmds.h".
5692         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5693         (_initialize_maint_cmds): Register the "maintenance with" command.
5694         * top.c (repeat_previous): Move bits from pipe_command here:
5695         Return the saved command line, if any; error out if there's no
5696         command to relaunch.
5697
5698 2019-07-03  Pedro Alves  <palves@redhat.com>
5699
5700         * NEWS (New commands): Mention "maint set/show test-settings"
5701         instead of "maint test-settings".
5702         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5703         (maintenance_test_settings_set_list): Rename to ...
5704         (maintenance_set_test_settings_list): ... this.
5705         (maintenance_test_settings_show_list): Rename to  ...
5706         (maintenance_show_test_settings_list): ... this.
5707         (maintenance_test_settings_cmd): Delete.
5708         (maintenance_test_settings_set_cmd): ...
5709         (maintenance_set_test_settings_cmd): ... this.
5710         (maintenance_test_settings_show_cmd): ...
5711         (maintenance_show_test_settings_cmd): ... this.
5712         (maintenance_test_settings_show_value_cmd):
5713         (maintenance_show_test_settings_value_cmd): ... this.
5714         (_initialize_maint_test_settings): No longer install the "maint
5715         test-settings" prefix command.  Rename "maint test-settings set"
5716         to "maint set test-settings", and "maint test-settings show" to
5717         "maint show test-settings".  Adjust all subcommands.
5718
5719 2019-07-03  Pedro Alves  <palves@redhat.com>
5720
5721         * maint-test-settings.c: Fix file's intro comment.  Replace all
5722         references to "test-options" with references to "test-settings",
5723         in comments.
5724
5725 2019-07-03  Pedro Alves  <palves@redhat.com>
5726
5727         * maint-test-settings.c (maintenance_test_settings_xxx)
5728         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5729         New.
5730         (maintenance_test_settings_enums): Use them.
5731         (maintenance_test_settings_enum): Default to
5732         maintenance_test_settings_xxx.
5733         (_initialize_maint_test_settings): Initialize
5734         MAINTENANCE_TEST_SETTINGS_FILENAME.
5735
5736 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5737
5738         * breakpoint.h (remove_breakpoints_inf): Change return type to
5739         void, move function documentation here.
5740         * breakpoint.c (remove_breakpoints_inf): Change return type to
5741         void, move function documentation to header.
5742
5743 2019-07-02  Pedro Alves  <palves@redhat.com>
5744
5745         * NEWS (Completion improvements): Mention "info threads".
5746         * thread.c (struct info_threads_opts, info_threads_option_defs)
5747         (make_info_threads_options_def_group): New.
5748         (info_threads_command): Use gdb::option::process_options.
5749         (info_threads_command_completer): New.
5750         (_initialize_thread): Use gdb::option::build_help to build the
5751         help text for "info threads".
5752
5753 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5754
5755         * defs.h (generic_load): Move from here...
5756         * symfile.h (generic_load): ... to here.  Rename name parameter
5757         to args.
5758         * symfile.c (generic_load): Add comment.
5759
5760 2019-07-01  Tom Tromey  <tromey@adacore.com>
5761
5762         * dwarf2read.c
5763         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5764         declaration of without_params.  Fix formatting.
5765
5766 2019-07-01  Tom Tromey  <tromey@adacore.com>
5767
5768         * ada-exp.y (find_primitive_type): Update.
5769         * ada-lang.h (ada_lookup_symbol): Update.
5770         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5771         parameter.
5772         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5773
5774 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5775
5776         PR breakpoints/24541
5777         * gdbarch.c: Regenerate.
5778         * gdbarch.h: Regenerate.
5779         * gdbarch.sh: Add 'stap_adjust_register'.
5780         * i386-tdep.c: Include '<unordered_set>'.
5781         (i386_stap_adjust_register): New function.
5782         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5783         * stap-probe.c (stap_parse_register_operand): Call
5784         'gdbarch_stap_adjust_register'.
5785
5786 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5787
5788         PR python/24742
5789         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5790         * python/python.c (do_start_initialization): Use 'xmalloc'
5791         instead of 'PyMem_Malloc'.
5792
5793 2019-06-28  Tom Tromey  <tromey@adacore.com>
5794
5795         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5796         for Ada.
5797
5798 2019-06-27  Tom Tromey  <tromey@adacore.com>
5799
5800         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5801         objfile_key.
5802         (arm_find_mapping_symbol, arm_record_special_symbol)
5803         (_initialize_arm_tdep): Update.
5804         (arm_objfile_data_free): Remove.
5805
5806 2019-06-27  Tom Tromey  <tromey@adacore.com>
5807
5808         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5809         to cp_print_static_field.
5810
5811 2019-06-26  Tom Tromey  <tromey@adacore.com>
5812
5813         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5814         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5815         declare.
5816
5817 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5818
5819         * features/aarch64-core.c (create_feature_aarch64_core):
5820         Regenerate.
5821         * features/aarch64-core.xml: Add cpsr flags.
5822
5823 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5824
5825         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5826         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5827
5828 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5829
5830         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5831         field.
5832         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5833         use.
5834         (arm_record_special_symbol): Don't insert new symbol in sorted
5835         position, push it at the end.
5836
5837 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5838
5839         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5840         (arm_mapping_symbol_s): Remove.
5841         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5842         (arm_mapping_symbol_vec): New typedef.
5843         (struct arm_per_objfile): Add constructor.
5844         <section_maps>: Change type to
5845         std::unique_ptr<arm_mapping_symbol_vec[]>.
5846         (arm_compare_mapping_symbols): Remove.
5847         (arm_find_mapping_symbol): Adjust to section_maps type change.
5848         (arm_objfile_data_free): Call delete on arm_per_objfile.
5849         (arm_record_special_symbol): Adjust to section_maps type change.
5850         Allocate arm_per_objfile with new.
5851
5852 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5853
5854         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5855         with the command prefix.
5856
5857 2019-06-25  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5860         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5861
5862 2019-06-25  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5865         type.
5866         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5867         protected.
5868
5869 2019-06-25  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-winsource.c
5872         (tui_source_window_base::set_is_exec_point_at): Add check against
5873         LOA_ADDRESS.
5874
5875 2019-06-25  Tom Tromey  <tom@tromey.com>
5876
5877         * tui/tui-source.c (tui_set_source_content): Don't check before
5878         xfree.
5879         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5880
5881 2019-06-25  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-winsource.h (tui_update_source_window_as_is)
5884         (tui_alloc_source_buffer, tui_line_is_displayed)
5885         (tui_addr_is_displayed): Change type of win_info.
5886         * tui/tui-winsource.c (tui_update_source_window_as_is)
5887         (tui_clear_source_content, tui_show_source_line)
5888         (tui_show_source_content, tui_source_window_base::refill)
5889         (tui_source_window_base::set_is_exec_point_at)
5890         (tui_source_window_base::set_is_exec_point_at)
5891         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5892         (tui_alloc_source_buffer, tui_line_is_displayed)
5893         (tui_addr_is_displayed): Change type of win_info.  Update.
5894         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5895         (tui_source_window_base::do_make_visible_with_new_height):
5896         Update.
5897         * tui/tui-source.c (tui_set_source_content)
5898         (tui_set_source_content_nil)
5899         (tui_source_window::do_scroll_vertical): Update.
5900         * tui/tui-layout.c (show_layout): Update.
5901         * tui/tui-disasm.c (tui_set_disassem_content)
5902         (tui_disasm_window::do_scroll_vertical): Update.
5903         * tui/tui-data.h (tui_win_content): Remove.
5904         (struct tui_gen_win_info) <content, content_size>: Remove.
5905         (struct tui_source_element): Add initializers and destructor.
5906         (union tui_which_element, struct tui_win_element): Remove.
5907         (struct tui_source_window_base) <content>: New field.
5908         (struct tui_data_window): Remove destructor.
5909         (tui_alloc_content, tui_free_win_content)
5910         (tui_free_all_source_wins_content): Don't declare.
5911         * tui/tui-data.c (tui_initialize_static_data): Update.
5912         (init_content_element, tui_alloc_content): Remove.
5913         (~tui_gen_win_info): Update.
5914         (~tui_data_window, tui_free_all_source_wins_content)
5915         (tui_free_win_content, free_content, free_content_elements):
5916         Remove.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-winsource.h (tui_clear_source_content)
5921         (tui_erase_source_content, tui_show_source_content): Change type
5922         of win_info.
5923         * tui/tui-winsource.c (tui_clear_source_content)
5924         (tui_erase_source_content, tui_show_source_content): Change type
5925         of win_info.
5926         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5927         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5928         win_info.
5929         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5930         win_info.
5931         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5932
5933 2019-06-25  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-winsource.c (tui_clear_source_content)
5936         (tui_source_window_base::set_is_exec_point_at): Update.
5937         * tui/tui-source.c (tui_set_source_content_nil): Update.
5938         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5939         a bool.
5940         * tui/tui-data.c (init_content_element): Update.
5941
5942 2019-06-25  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5945         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5946         * tui/tui-layout.c (init_and_make_win): Update.
5947         * tui/tui.h (enum tui_win_type): Update.
5948         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5949         tui_win_is_auxillary.
5950         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5951         tui_win_is_auxillary.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5956         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5957         (tui_delete_data_content_windows, tui_display_all_data)
5958         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5959         Update.
5960         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5961         * tui/tui-regs.c (tui_last_regs_line_no)
5962         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5963         (tui_show_registers): Update.
5964         (tui_show_register_group): Return void.  Update.
5965         (tui_display_registers_from, tui_display_reg_element_at_line)
5966         (tui_display_registers_from_line, tui_check_register_values):
5967         Update.
5968         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5969         member.
5970         (struct tui_data_window) <regs_content>: Now a std::vector.
5971         <regs_content_count>: Remove.
5972         (tui_add_content_elements, tui_free_data_content): Don't declare.
5973         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5974         (init_content_element): Remove DATA_WIN case.  Add assert.
5975         (tui_add_content_elements): Remove.
5976         (tui_data_window): Update.
5977         (tui_free_data_content): Remove.
5978         (free_content_elements): Remove DATA_WIN case.
5979
5980 2019-06-25  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-data.c (tui_data_item_window): Update.
5983         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5984         * tui/tui-windata.c (tui_display_all_data)
5985         (tui_display_data_from_line): Update.
5986         (tui_check_data_values): Remove.
5987         * tui/tui-regs.c (tui_show_register_group)
5988         (tui_display_reg_element_at_line): Update.
5989         * tui/tui-hooks.c (tui_register_changed)
5990         (tui_refresh_frame_and_register_information): Call
5991         tui_check_register_values.
5992         * tui/tui-data.h (struct tui_data_window) <data_content,
5993         data_content_count, data_type>: Remove.
5994         (enum tui_data_type): Remove.
5995
5996         * tui/tui-data.c (tui_data_window::clear_detail)
5997         (~tui_data_window): Update.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6002         declare.
6003         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6004         Rename from tui_first_data_item_displayed.  Update.
6005         (tui_data_window::refresh_all)
6006         (tui_data_window::do_scroll_vertical): Update.
6007         * tui/tui-data.h (struct tui_data_window)
6008         <first_data_item_displayed>: Declare new method.
6009
6010 2019-06-25  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6013         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6014         contents...
6015         (tui_initialize_static_data): ...here.
6016
6017 2019-06-25  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6020         (tui_display_registers_from, tui_check_register_values): Update.
6021         (tui_display_register): Remove win_info parameter; update.
6022         (tui_get_register): Change type of parameters.
6023         * tui/tui-data.h (struct tui_data_element): Remove.
6024         (union tui_which_element) <data>: Remove.
6025         <data_window>: Change type.
6026         (struct tui_data_item_window): New.
6027         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6028         case.  Add assert.
6029         (~tui_data_item_window): New destructor.
6030         (free_content_elements): Remove DATA_ITEM_WIN case.
6031
6032 2019-06-25  Tom Tromey  <tom@tromey.com>
6033
6034         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6035         Remove.
6036
6037 2019-06-25  Tom Tromey  <tom@tromey.com>
6038
6039         * tui/tui-data.h (struct tui_command_element): Remove.
6040         (union tui_which_element) <command>: Remove.
6041         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6042         assert.
6043         (free_content_elements): Remove CMD_WIN case.
6044
6045 2019-06-25  Tom Tromey  <tom@tromey.com>
6046
6047         * tui/tui-layout.c (tui_set_layout): Update.
6048         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6049         * tui/tui-data.c (layout_def): Update.
6050
6051 2019-06-25  Tom Tromey  <tom@tromey.com>
6052
6053         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6054         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6055         (tui_source_window_base::set_new_height): Update.
6056         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6057         Update.
6058         (tui_set_locator_fullname, tui_set_locator_info)
6059         (tui_show_frame_info): Update.
6060         * tui/tui-source.c (tui_set_source_content)
6061         (tui_source_is_displayed): Update.
6062         * tui/tui-layout.c (show_source_disasm_command, show_data)
6063         (show_source_or_disasm_and_command): Update.
6064         * tui/tui-disasm.c (tui_set_disassem_content)
6065         (tui_get_begin_asm_address): Update.
6066         * tui/tui-data.h (struct tui_locator_element): Remove.
6067         (union tui_which_element) <locator>: Remove.
6068         (struct tui_locator_window): New.
6069         (tui_locator_win_info_ptr): Change return type.
6070         * tui/tui-data.c (_locator): Change type.
6071         (tui_locator_win_info_ptr): Change return type.
6072         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6073         (tui_alloc_content): Add assert.
6074
6075 2019-06-25  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-winsource.c
6078         (tui_exec_info_window::maybe_allocate_content): New method.
6079         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6080         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6081         (make_source_or_disasm_window): Add cast.
6082         * tui/tui-data.h (union tui_which_element) <simple_string>:
6083         Remove.
6084         (struct tui_source_info): New.
6085         (struct tui_source_window_base) <execution_info>: Change type.
6086         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6087         case, and add assert.
6088         (tui_alloc_content): Add assert.
6089
6090 2019-06-25  Tom Tromey  <tom@tromey.com>
6091
6092         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6093         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6094         * tui/tui-data.c (tui_alloc_win_info): Remove.
6095
6096 2019-06-25  Tom Tromey  <tom@tromey.com>
6097
6098         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6099         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6100         can_highlight.
6101
6102 2019-06-25  Tom Tromey  <tom@tromey.com>
6103
6104         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6105         make_visible_with_new_height method.
6106         (tui_win_info::make_visible_with_new_height): New method.
6107         (tui_source_window_base::do_make_visible_with_new_height)
6108         (tui_data_window::do_make_visible_with_new_height)
6109         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6110         (make_visible_with_new_height): Remove.
6111         (tui_resize_all, tui_adjust_win_heights): Use
6112         make_visible_with_new_height method.
6113         * tui/tui-data.h (struct tui_win_info)
6114         <do_make_visible_with_new_height, make_visible_with_new_height>:
6115         New methods.
6116         (struct tui_source_window_base, struct tui_data_window)
6117         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6118         methods.
6119
6120 2019-06-25  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6123         method.
6124         (update_tab_width): Call update_tab_width method.
6125         * tui/tui-data.h (struct tui_win_info)
6126         (struct tui_source_window_base) <update_tab_width>: New methods.
6127
6128 2019-06-25  Tom Tromey  <tom@tromey.com>
6129
6130         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6131         parameter.
6132         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6133         parameter.
6134         (tui_gen_win_info::make_visible): Update.
6135         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6136         parameter.
6137         * tui/tui-data.h (enum tui_box): New enum.
6138         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6139
6140 2019-06-25  Tom Tromey  <tom@tromey.com>
6141
6142         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6143         init_and_make_win for EXEC_INFO_WIN.
6144         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6145         longer inline.
6146         (struct tui_win_info) <~tui_win_info>: Inline.
6147         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6148         Don't declare.
6149         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6150         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6151         Remove.
6152         (tui_initialize_static_data): Update.
6153         (~tui_gen_win_info): Handle more cleanup here.
6154         (~tui_source_window_base): Delete "execution_info".
6155         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6156
6157 2019-06-25  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-layout.c (make_command_window): Don't set
6160         can_highlight.
6161         (show_source_disasm_command): Call the reset method.
6162         (show_data): Don't set can_highlight.  Call the reset method.
6163         (tui_gen_win_info::reset): Rename from init_gen_win_info
6164         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6165         (show_source_or_disasm_and_command): Call the reset method.
6166         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6167         (struct tui_cmd_window): Set can_highlight.
6168
6169 2019-06-25  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6172         from make_visible.
6173         (tui_make_visible, tui_make_invisible): Rewrite.
6174         (tui_win_info::make_visible): Remove.
6175         (tui_source_window_base::make_visible): Update.
6176         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6177         method.  Moved from...
6178         (struct tui_win_info) <make_visible>: ...here.
6179
6180 2019-06-25  Tom Tromey  <tom@tromey.com>
6181
6182         * tui/tui-winsource.c
6183         (tui_source_window_base::do_scroll_horizontal): Remove direction
6184         parameter.
6185         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6186         direction parameter.
6187         * tui/tui-win.c (tui_win_info::forward_scroll)
6188         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6189         (tui_win_info::right_scroll): Update.
6190         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6191         direction parameter.
6192         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6193         direction parameter.
6194         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6195         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6196         Remove direction parameter.
6197         (struct tui_source_window_base, struct tui_source_window)
6198         (struct tui_disasm_window, struct tui_data_window)
6199         (struct tui_cmd_window): Update.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-winsource.h (tui_set_exec_info_content)
6204         (tui_show_exec_info_content, tui_erase_exec_info_content)
6205         (tui_clear_exec_info_content, tui_update_exec_info): Change
6206         argument to tui_source_window_base.
6207         * tui/tui-winsource.c (tui_set_exec_info_content)
6208         (tui_show_exec_info_content, tui_erase_exec_info_content)
6209         (tui_clear_exec_info_content, tui_update_exec_info): Change
6210         argument to tui_source_window_base.
6211
6212 2019-06-25  Tom Tromey  <tom@tromey.com>
6213
6214         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6215         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6216
6217 2019-06-25  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6220         check.
6221
6222 2019-06-25  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6225         type to void.
6226         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6227         type to void.
6228         * tui/tui-source.c (tui_set_source_content): Update.
6229         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6230
6231 2019-06-25  Tom Tromey  <tom@tromey.com>
6232
6233         * tui/tui-win.c (window_name_completer, tui_set_focus)
6234         (tui_all_windows_info): Use name method.
6235         * tui/tui-data.h (struct tui_gen_win_info)
6236         (struct tui_source_window, struct tui_disasm_window)
6237         (struct tui_data_window, struct tui_cmd_window) <name>: New
6238         method.
6239         (tui_win_name): Don't declare.
6240         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6241         (tui_win_name): Remove.
6242
6243 2019-06-25  Tom Tromey  <tom@tromey.com>
6244
6245         * tui/tui-winsource.h (tui_update_source_window)
6246         (tui_update_source_window_as_is): Change parameter type.
6247         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6248         to be a tui_source_window_base.
6249         (tui_update_source_window_as_is): Likewise.
6250         * tui/tui-win.c (make_visible_with_new_height): Update.
6251
6252 2019-06-25  Tom Tromey  <tom@tromey.com>
6253
6254         * tui/tui-winsource.c (tui_erase_source_content)
6255         (tui_show_source_content, tui_show_exec_info_content)
6256         (tui_erase_exec_info_content): Use refresh_window method.
6257         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6258         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6259         from tui_refresh_win.
6260         (tui_data_window::refresh_window): New method.
6261         (tui_win_info::refresh, tui_source_window_base::refresh)
6262         (tui_refresh_all): Use refresh_window method.
6263         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6264         method.
6265         * tui/tui-regs.c (tui_display_register): Call refresh_window
6266         method.
6267         * tui/tui-layout.c (show_source_disasm_command)
6268         (show_source_or_disasm_and_command): Call refresh_window method.
6269         * tui/tui-data.h (struct tui_gen_win_info)
6270         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6271         New method.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui.c (tui_rl_other_window, tui_enable)
6276         (tui_is_window_visible, tui_get_command_dimension): Update.
6277         * tui/tui-winsource.c (tui_update_source_window_as_is)
6278         (tui_clear_source_content, tui_erase_source_content)
6279         (tui_show_source_line, tui_source_window_base::refill)
6280         (tui_source_window_base::do_scroll_horizontal)
6281         (tui_source_window_base::set_is_exec_point_at)
6282         (tui_update_breakpoint_info, tui_set_exec_info_content)
6283         (tui_alloc_source_buffer, tui_line_is_displayed)
6284         (tui_addr_is_displayed): Update.
6285         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6286         (tui_check_and_display_highlight_if_needed)
6287         (tui_win_info::make_visible, tui_win_info::refresh)
6288         (tui_refresh_all): Update.
6289         * tui/tui-windata.c (tui_first_data_item_displayed)
6290         (tui_delete_data_content_windows, tui_erase_data_content)
6291         (tui_display_all_data, tui_data_window::refresh_all)
6292         (tui_check_data_values): Update.
6293         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6294         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6295         (tui_win_info::backward_scroll, tui_refresh_all_win)
6296         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6297         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6298         (tui_source_window_base::set_new_height)
6299         (tui_data_window::set_new_height)
6300         (make_invisible_and_set_new_height)
6301         (make_visible_with_new_height, new_height_ok)
6302         (parse_scrolling_args): Update.
6303         * tui/tui-stack.c (tui_show_frame_info): Update.
6304         * tui/tui-source.c (tui_set_source_content)
6305         (tui_set_source_content_nil, tui_source_is_displayed)
6306         (tui_source_window::do_scroll_vertical): Update.
6307         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6308         (tui_display_registers_from, tui_display_reg_element_at_line)
6309         (tui_check_register_values, tui_reg_command): Update.
6310         * tui/tui-layout.c (tui_default_win_height)
6311         (show_source_disasm_command, show_data, init_and_make_win)
6312         (show_source_or_disasm_and_command): Update.
6313         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6314         (tui_redisplay_readline, tui_mld_flush)
6315         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6316         (tui_getc): Update.
6317         * tui/tui-disasm.c (tui_set_disassem_content)
6318         (tui_disasm_window::do_scroll_vertical): Update.
6319         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6320         Now virtual.
6321         (struct tui_win_info): Derive from tui_gen_win_info.
6322         <~tui_win_info>: Mark as override.
6323         <generic>: Remove member.
6324         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6325         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6326         (~tui_data_window, ~tui_win_info)
6327         (tui_free_all_source_wins_content): Update.
6328         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6329
6330 2019-06-25  Tom Tromey  <tom@tromey.com>
6331
6332         * tui/tui-layout.c (init_and_make_win): Use new.
6333         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6334         destructor, initializers.
6335         (tui_alloc_generic_win_info): Don't declare.
6336         * tui/tui-data.c (_locator): Add argument to constructor.
6337         (source_win, disasm_win): New globals.
6338         (exec_info): Remove.
6339         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6340         Update.
6341         (tui_alloc_generic_win_info): Remove.
6342         (init_content_element): Use new.
6343         (tui_win_info::tui_win_info): Update.
6344         (free_content_elements) <case DATA_WIN>: Use delete.
6345
6346 2019-06-25  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6349         * tui/tui-windata.c (tui_first_data_item_displayed)
6350         (tui_delete_data_content_windows): Update.
6351         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6352         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6353         (tui_display_registers_from, tui_check_register_values): Update.
6354         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6355         pointer.
6356         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6357         window.
6358         (tui_free_data_content): Update.
6359         (free_content_elements) <case DATA_WIN>: Free the window.
6360
6361 2019-06-25  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6364         Update.
6365         * tui/tui-layout.c (make_command_window)
6366         (show_source_disasm_command, show_data, init_and_make_win)
6367         (show_source_or_disasm_and_command): Update.
6368         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6369         method.
6370         <can_highight, is_highlighted>: Now bool.
6371         (tui_set_win_highlight): Don't declare.
6372         * tui/tui-data.c (tui_set_win_highlight): Remove.
6373
6374 2019-06-25  Tom Tromey  <tom@tromey.com>
6375
6376         * tui/tui-wingeneral.c (make_visible): Remove check of window
6377         type.
6378
6379 2019-06-25  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-win.c (tui_win_info::max_height)
6382         (tui_cmd_window::max_height): New methods.
6383         (new_height_ok): Call max_height.
6384         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6385         <max_height>: New method.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-win.c (tui_source_window_base::set_new_height)
6390         (tui_data_window::set_new_height): New methods.
6391         (make_invisible_and_set_new_height): Call set_new_height method.
6392         * tui/tui-data.h (struct tui_win_info)
6393         (struct tui_source_window_base, struct tui_data_window)
6394         <set_new_height>: New method.
6395
6396 2019-06-25  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6399         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6400         tui_refresh_data_win.
6401         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6402         method.
6403         (tui_refresh_all_win): Call the refresh_all method.
6404         (tui_set_focus): Likewise.
6405         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6406         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6407         Likewise.
6408
6409 2019-06-25  Tom Tromey  <tom@tromey.com>
6410
6411         * tui/tui-winsource.h (tui_refill_source_window)
6412         (tui_set_is_exec_point_at): Don't declare.
6413         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6414         (tui_source_window_base::refill): Rename from
6415         tui_refill_source_window.
6416         (tui_source_window_base::do_scroll_horizontal): Update.
6417         (tui_source_window_base::set_is_exec_point_at): Rename from
6418         tui_set_is_exec_point_at.
6419         (tui_update_all_breakpoint_info): Update.
6420         * tui/tui-stack.c (tui_show_frame_info): Update.
6421         * tui/tui-layout.c (show_data): Add cast.
6422         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6423         * tui/tui-data.h (struct tui_source_window_base) <refill,
6424         set_is_exec_point_at>: New methods.
6425         (tui_source_windows, tui_add_to_source_windows): Update types.
6426         (tui_add_to_source_windows): Remove redundant declaration.
6427         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6428         (tui_source_windows): Change return type.
6429         (tui_clear_source_windows_detail): Update.
6430         (tui_add_to_source_windows): Change type of parameter.
6431         (tui_free_all_source_wins_content): Update.
6432
6433 2019-06-25  Tom Tromey  <tom@tromey.com>
6434
6435         * tui/tui-wingeneral.c (tui_win_info::refresh)
6436         (tui_source_window_base::refresh): New methods.
6437         (tui_refresh_all): Call the refresh method.
6438         * tui/tui-data.h (struct tui_win_info)
6439         (struct tui_source_window_base) <refresh>: New method.
6440
6441 2019-06-25  Tom Tromey  <tom@tromey.com>
6442
6443         * tui/tui.h (tui_is_window_visible): Return bool.
6444         * tui/tui.c (tui_is_window_visible): Return bool.
6445         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6446         (tui_make_visible, tui_make_invisible)
6447         (tui_win_info::make_visible)
6448         (tui_source_window_base::make_visible, make_all_visible)
6449         (tui_make_all_visible, tui_make_all_invisible): Update.
6450         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6451         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6452         bool.
6453         (struct tui_win_info, struct tui_source_window_base)
6454         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6455         * tui/tui-data.c (tui_init_generic_part): Update.
6456
6457 2019-06-25  Tom Tromey  <tom@tromey.com>
6458
6459         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6460         (tui_source_window_base::make_visible): New methods.
6461         (make_all_visible): Make method call.
6462         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6463         (struct tui_source_window_base, struct tui_cmd_window): Override
6464         make_visible.
6465         (tui_win_is_source_type): Don't declare.
6466         * tui/tui-data.c (tui_win_is_source_type): Remove.
6467
6468 2019-06-25  Tom Tromey  <tom@tromey.com>
6469
6470         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6471         NULL check.
6472
6473 2019-06-25  Tom Tromey  <tom@tromey.com>
6474
6475         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6476         Inline constructor.  Add initializers for members.
6477         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6478         constructors; now inline in class.
6479
6480 2019-06-25  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-regs.c (tui_show_registers): Update.
6483         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6484         bool.
6485         * tui/tui-data.c (tui_data_window::clear_detail)
6486         (tui_data_window): Update.
6487
6488 2019-06-25  Tom Tromey  <tom@tromey.com>
6489
6490         * tui/tui-windata.c (tui_display_all_data)
6491         (tui_display_data_from_line, tui_display_data_from)
6492         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6493         Update.
6494         * tui/tui-regs.c (tui_last_regs_line_no)
6495         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6496         (tui_show_registers, tui_show_register_group)
6497         (tui_display_registers_from, tui_display_reg_element_at_line)
6498         (tui_display_registers_from_line, tui_check_register_values)
6499         (tui_reg_next, tui_reg_prev): Update.
6500         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6501         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6502         tui_data_window.
6503         (struct tui_win_info) <detail>: Remove.  Add new fields from
6504         tui_data_info.
6505         (TUI_DATA_WIN): Add cast.
6506         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6507         (~tui_data_window): Simplify.
6508
6509 2019-06-25  Tom Tromey  <tom@tromey.com>
6510
6511         * tui/tui-layout.c (show_source_disasm_command)
6512         (show_source_or_disasm_and_command): Update.
6513         * tui/tui-io.c (update_cmdwin_start_line)
6514         (tui_redisplay_readline): Update.
6515         * tui/tui-data.h (struct tui_command_info): Remove.
6516         (struct tui_win_info) <detail>: Remove command_info member.
6517         (struct tui_data_window) <start_line>: New member, from
6518         tui_command_info.
6519         (TUI_CMD_WIN): Add casts.
6520
6521 2019-06-25  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui-winsource.c (tui_update_source_window)
6524         (tui_refill_source_window)
6525         (tui_source_window_base::do_scroll_horizontal)
6526         (tui_update_breakpoint_info, tui_set_exec_info_content)
6527         (tui_show_exec_info_content, tui_erase_exec_info_content)
6528         (tui_clear_exec_info_content): Update.
6529         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6530         Update.
6531         * tui/tui-win.c (make_invisible_and_set_new_height)
6532         (make_visible_with_new_height): Update.
6533         * tui/tui-source.c (tui_set_source_content)
6534         (tui_show_symtab_source): Update.
6535         * tui/tui-layout.c (extract_display_start_addr)
6536         (show_source_disasm_command, show_data)
6537         (make_source_or_disasm_window)
6538         (show_source_or_disasm_and_command): Update.
6539         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6540         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6541         "gdbarch".
6542         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6543         to tui_source_window_base.
6544         (struct tui_win_info) <detail>: Remove source_info member.
6545         (struct tui_source_window_base) <has_locator>: Inline.
6546         Move contents from tui_source_info; rename has_locator member to
6547         m_has_locator.
6548         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6549         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6550         header file.
6551         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6552         Simplify.
6553         (tui_free_all_source_wins_content): Cast to
6554         tui_source_window_base.
6555
6556 2019-06-25  Tom Tromey  <tom@tromey.com>
6557
6558         * tui/tui-win.c (make_invisible_and_set_new_height)
6559         (make_visible_with_new_height): Call has_locator method.
6560         * tui/tui-layout.c (show_source_disasm_command, show_data)
6561         (show_source_or_disasm_and_command): Update for bool change.
6562         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6563         (tui_win_info) <has_locator>: New method.
6564         (struct tui_source_window_base) <has_locator>: New method.
6565         (tui_win_has_locator): Don't declare.
6566         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6567         from tui_win_has_locator.
6568         (tui_source_window_base): Use false, not FALSE.
6569
6570 2019-06-25  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6573         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6574         clear_detail method directly.
6575         (tui_clear_win_detail): Remove.
6576
6577 2019-06-25  Tom Tromey  <tom@tromey.com>
6578
6579         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6580         "this", not TUI_DISASM_WIN.
6581
6582 2019-06-25  Tom Tromey  <tom@tromey.com>
6583
6584         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6585         declare.
6586         * tui/tui-winsource.c
6587         (tui_source_window_base::do_scroll_horizontal): Rename from
6588         tui_horizontal_source_scroll.
6589         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6590         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6591         from tui_vertical_data_scroll.
6592         * tui/tui-win.h (tui_scroll): Don't declare.
6593         * tui/tui-win.c (tui_win_info::forward_scroll)
6594         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6595         (tui_win_info::right_scroll): Rename and update.
6596         (tui_scroll_forward_command, tui_scroll_backward_command)
6597         (tui_scroll_left_command, tui_scroll_right_command): Update.
6598         (tui_scroll): Remove.
6599         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6600         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6601         from tui_vertical_source_scroll.
6602         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6603         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6604         from tui_vertical_disassem_scroll.
6605         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6606         do_scroll_horizontal>: New methods.
6607         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6608         Likewise.
6609         (struct tui_source_window_base): Add do_scroll_horizontal.
6610         (struct tui_source_window, struct tui_disasm_window): Add
6611         do_scroll_vertical.
6612         (struct tui_data_window, struct tui_cmd_window): Add
6613         do_scroll_horizontal and do_scroll_vertical.
6614         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6615
6616 2019-06-25  Tom Tromey  <tom@tromey.com>
6617
6618         * tui/tui-data.h (struct tui_source_window_base): New struct.
6619         (struct tui_source_window): Derive from tui_source_window_base.
6620         (struct tui_disasm_window): New struct.
6621         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6622         from tui_source_window::clear_detail.
6623         (tui_source_window_base): Rename from tui_source_window.
6624         (~tui_source_window_base): Rename from ~tui_source_window.
6625         (tui_alloc_win_info): Create a tui_disasm_window.
6626
6627 2019-06-25  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-data.h (struct tui_source_window)
6630         (struct tui_data_window): Declare destructors.
6631         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6632         destructors.
6633         (tui_win_info): Simplify.
6634
6635 2019-06-25  Tom Tromey  <tom@tromey.com>
6636
6637         * tui/tui-winsource.c (tui_display_main)
6638         (tui_update_source_windows_with_addr)
6639         (tui_update_all_breakpoint_info): Update.
6640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6641         (new_height_ok, parse_scrolling_args): Update.
6642         * tui/tui-stack.c (tui_show_frame_info): Update.
6643         * tui/tui-data.h (struct tui_list): Remove.
6644         (tui_source_windows): Return a reference to a std::vector.
6645         * tui/tui-data.c (source_windows): Now a std::vector.
6646         (tui_source_windows): Change return type.
6647         (tui_clear_source_windows): Rewrite.
6648         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6649         (tui_free_all_source_wins_content): Rewrite.
6650
6651 2019-06-25  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6654         (struct tui_data_window, struct tui_cmd_window): Declare
6655         clear_detail method.
6656         * tui/tui-data.c (tui_source_window::clear_detail)
6657         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6658         methods.
6659         (tui_clear_win_detail): Simplify.
6660
6661 2019-06-25  Tom Tromey  <tom@tromey.com>
6662
6663         * tui/tui-layout.c (make_source_window, make_disasm_window)
6664         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6665         Return the new window.
6666         (show_source_disasm_command, show_data)
6667         (show_source_or_disasm_and_command): Update.
6668
6669 2019-06-25  Tom Tromey  <tom@tromey.com>
6670
6671         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6672         parameter.  Return the new window.
6673         (show_source_disasm_command): Update and remove NULL check.
6674         (show_source_or_disasm_and_command): Update.
6675
6676 2019-06-25  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6679
6680 2019-06-25  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-data.h (struct tui_win_info): Make constructor
6683         protected.  Make destructor virtual.  Add initializers.
6684         (tui_source_window, tui_data_window, tui_cmd_window): New
6685         classes.
6686         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6687         constructor.  Add "type" parameter.
6688         (tui_source_window, tui_data_window, tui_cmd_window): New
6689         constructors.
6690         (tui_alloc_win_info): Instantiate the appropriate subclass.
6691
6692 2019-06-25  Tom Tromey  <tom@tromey.com>
6693
6694         * tui/tui-win.c (tui_resize_all): Use delete.
6695         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6696         destructor.
6697         (tui_free_window): Don't declare.
6698         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6699         Update.
6700
6701 2019-06-25  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui-data.h (struct tui_win_info): Add constructor.
6704         * tui/tui-data.c (tui_alloc_win_info): Use new.
6705         (tui_free_window): Use delete.
6706
6707 2019-06-22  Tom Tromey  <tom@tromey.com>
6708
6709         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6710         declare.
6711         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6712
6713 2019-06-22  Tom Tromey  <tom@tromey.com>
6714
6715         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6716         declare.
6717         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6718
6719 2019-06-22  Tom de Vries  <tdevries@suse.de>
6720
6721         * dwarf2read.c (create_addrmap_from_aranges)
6722         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6723         instead of '%zu'.
6724
6725 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6726
6727         * dwarf2read.h (dwarf2_section_info_def): Remove.
6728         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6729         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6730         std::vector<dwarf2_section_info>.
6731         (struct dwo_file) <~dwo_file>: Remove.
6732         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6733         types field.
6734         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6735         (dwarf2_read_debug_names): Likewise.
6736         (create_debug_types_hash_table): Change parameter type to
6737         array_view, adjust code accordingly.
6738         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6739         (partial_die_info::fixup): Likewise.
6740         (determine_prefix): Likewise.
6741         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6742
6743 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6744
6745         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6746         gdb_bfd_ref_ptr.
6747         <~dwo_file>: Remove call to gdb_bfd_unref.
6748         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6749         gdb_bfd_ref_ptr::get.
6750
6751 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6752
6753         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6754         type to htab_up.
6755         * dwarf2read.c (struct dwo_file): Initialize fields.
6756         <~dwo_file>: New.
6757         (free_dwo_file): Remove, move content to ~dwo_file.
6758         (struct dwo_file_deleter): Remove.
6759         (dwo_file_up>: Remove custom deleter.
6760         (free_dwo_files): Remove.
6761         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6762         dwo_files.
6763         (process_skeletonless_type_units): Call unique_ptr::get.
6764         (allocate_dwo_file_hash_table): Add deleter to created hash
6765         table.  Change return type to htab_up.
6766         (lookup_dwo_file_slot): Don't memset dwo_file, call
6767         unique_ptr::get.
6768         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6769         (create_dwo_unit_in_dwp_v2): Likewise.
6770         (open_and_init_dwo_file): Likewise.
6771         (free_dwo_file_from_slot): Remove.
6772
6773 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6774
6775         * dwarf2read.h (struct dwarf2_section_info) <readin,
6776         is_virtual>: Change type to bool.
6777         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6778         true instead of 1.
6779
6780 2019-06-19  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-data.h (tui_init_content_element): Don't declare.
6783
6784 2019-06-19  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui-data.h (tui_init_win_info): Don't declare.
6787
6788 2019-06-19  Tom de Vries  <tdevries@suse.de>
6789
6790         * dwarf2read.h (abstract_to_concrete): Change type to
6791         std::unordered_map<sect_offset, std::vector<sect_offset>,
6792         gdb::hash_enum<sect_offset>>.
6793
6794 2019-06-19  Tom Tromey  <tromey@adacore.com>
6795
6796         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6797         EVAL_AVOID_SIDE_EFFECTS specially.
6798
6799 2019-06-19  Tom Tromey  <tromey@adacore.com>
6800
6801         * source-cache.c (highlighter): New global.
6802         (source_cache::get_source_lines): Create a highlighter on demand.
6803
6804 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6805
6806         * defs.h (deprecated_interactive_hook): Delete declaration.
6807         * interps.c (clear_interpreter_hooks): Remove use of
6808         deprecated_interactive_hook.
6809         * top.c (deprecated_interactive_hook): Delete definition.
6810         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6811
6812 2019-06-18  Tom de Vries  <tdevries@suse.de>
6813
6814         PR gdb/24515
6815         * dwarf2read.h (abstract_to_concrete): Change type from
6816         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6817         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6818         * dwarf2read.c (read_variable): Update.
6819         (dwarf2_fetch_die_loc_sect_off): Update.
6820
6821 2019-06-17  Tom de Vries  <tdevries@suse.de>
6822
6823         PR gdb/24617
6824         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6825         accessing parent[parent_len - 1].
6826
6827 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6828
6829         PR gdb/24364
6830         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6831         call dtrace_process_dof with NULL dof.
6832
6833 2019-06-16  Tom de Vries  <tdevries@suse.de>
6834
6835         PR gdb/24445
6836         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6837
6838 2019-06-16  Tom Tromey  <tom@tromey.com>
6839
6840         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6841         (make_all_visible): Use address of member.
6842
6843 2019-06-16  Tom Tromey  <tom@tromey.com>
6844
6845         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6846         (tui_free_window, free_content, free_content_elements): Remove
6847         unnecessary cast.
6848         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6849         cast.
6850         * tui/tui-regs.c (tui_show_register_group)
6851         (tui_display_registers_from, tui_display_reg_element_at_line):
6852         Remove unnecessary cast.
6853
6854 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * linux-nat.c (normal_mask): Delete.
6857         (_initialize_linux_nat): Don't initialise normal_mask.
6858
6859 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6860
6861         PR gdb/24445
6862         * dwarf-index-write.h (write_psymtabs_to_index): Add
6863         dwz_basename parameter.
6864         * dwarf-index-write.c (write_gdbindex): Move file writing to
6865         write_gdbindex_1.  Change return type void.
6866         (assert_file_size): Move up, remove filename parameter.
6867         (write_gdbindex_1): New function.
6868         (write_debug_names): Change return type to void, call
6869         assert_file_size.
6870         (struct index_wip_file): New struct.
6871         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6872         file logic to index_wip_file.  Write index for dwz file if
6873         needed.
6874         (save_gdb_index_command): Pass basename of dwz file, if present.
6875         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6876         build-id of dwz file, if present.
6877         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6878         (dwarf2_get_dwz_file): Likewise.
6879         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6880         (dwarf2_get_dwz_file): Likewise.
6881
6882 2019-06-16  Tom Tromey  <tom@tromey.com>
6883
6884         * coffread.c (process_coff_symbol): Use xstrdup.
6885         * value.c (create_internalvar): Use xstrdup.
6886
6887 2019-06-16  Tom Tromey  <tom@tromey.com>
6888
6889         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6890         * breakpoint.c (stopin_command, stopat_command)
6891         (until_break_command, decode_location_default): Remove unnecessary
6892         cast.
6893         * utils.c (subset_compare): Remove unnecessary cast.
6894         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6895         cast.
6896         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6897         cast.
6898         * infcmd.c (path_command): Remove unnecessary cast.
6899         * coffread.c (decode_type): Remove unnecessary cast.
6900         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6901         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6902         * tui/tui-stack.c (tui_show_locator_content)
6903         (tui_show_frame_info): Remove unnecessary cast.
6904         * tui/tui-win.c (tui_scroll_forward_command)
6905         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6906         (parse_scrolling_args): Remove unnecessary cast.
6907         * tui/tui-data.c (init_win_info, tui_del_window)
6908         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6909         (free_content_elements): Remove unnecessary cast.
6910         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6911         unnecessary cast.
6912         * tui/tui-source.c (tui_set_source_content)
6913         (tui_vertical_source_scroll): Remove unnecessary cast.
6914         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6915         cast.
6916         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6917         * tui/tui-regs.c (tui_display_registers_from)
6918         (tui_display_register): Remove unnecessary cast.
6919         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6920         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6921         (make_visible): Remove unnecessary cast.
6922         * tui/tui-winsource.c (tui_erase_source_content)
6923         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6924         unnecessary cast.
6925         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6926         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6927         * stabsread.c (read_type, read_array_type, read_range_type):
6928         Remove unnecessary cast.
6929         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6930         (parse_symbol, parse_type, upgrade_type, parse_external)
6931         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6932         unnecessary cast.
6933         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6934
6935 2019-06-16  Tom Tromey  <tom@tromey.com>
6936
6937         * tui/tui-data.c (tui_alloc_generic_win_info)
6938         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6939         checks.
6940
6941 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6942             Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * f-typeprint.c (f_print_type): Don't return early for not
6945         associated or not allocated types.
6946         (f_type_print_varspec_suffix): Add print_rank parameter and print
6947         ranks of array types in case they dangling.
6948         (f_type_print_base): Add print_rank parameter.
6949
6950 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6951
6952         * NEWS: Mention new MI commands.
6953         * break-catch-throw.c (enum exception_event_kind): Move to
6954         breakpoint.h.
6955         (print_mention_exception_catchpoint): Output text as a single
6956         message.
6957         (catch_exception_command_1): Rename to...
6958         (catch_exception_event): ...this, make non-static, update header
6959         command, and change some parameter types.
6960         (catch_catch_command): Update for changes to
6961         catch_exception_command_1.
6962         (catch_throw_command): Likewise.
6963         (catch_rethrow_command): Likewise.
6964         * breakpoint.c (enum exception_event_kind): Delete.
6965         * breakpoint.h (enum exception_event_kind): Moved here from
6966         break-catch-throw.c.
6967         (catch_exception_event): Declare.
6968         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6969         (mi_cmd_catch_throw): New function.
6970         (mi_cmd_catch_rethrow): New function.
6971         (mi_cmd_catch_catch): New function.
6972         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6973         'catch-catch' entries.
6974         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6975         (mi_cmd_catch_rethrow): Declare.
6976         (mi_cmd_catch_catch): Declare.
6977
6978 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6979
6980         * annotate.c (annotate_source_line): Change return type to void,
6981         update implementation to match.
6982         * annotate.h (annotate_source_line): Change return type to void,
6983         update header comment.
6984         * stack.c (print_frame_info): Don't change what frame information
6985         is printed based on whether annotations are on or not.
6986
6987 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6988
6989         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6990         (annotate_source): Make static.
6991         (annotate_source_line): Moved from source.c and renamed from
6992         identify_source_line.  Update the return type.
6993         * annotate.h (annotate_source): Delete declaration.
6994         (annotate_source_line): Declaration moved from source.h, and
6995         renamed from identify_source_line.  Return type updated.
6996         * source.c (identify_source_line): Moved to annotate.c and renamed
6997         to annotate_source_line.
6998         (info_line_command): Remove check of annotation_level.
6999         * source.h (identify_source_line): Move declaration to annotate.h
7000         and rename to annotate_source_line.
7001         * stack.c: Add 'annotate.h' include.
7002         (print_frame_info): Remove check of annotation_level before
7003         calling annotate_source_line.
7004
7005 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * source-cache.c (source_cache::get_plain_source_lines): Use
7008         open_source_file_with_line_charpos instead of just
7009         open_source_file, remove call to find_source_lines.
7010         (source_cache::get_source_lines): Likewise.
7011         * source.c (find_source_lines): Make static.
7012         (get_filename_and_charpos): Renamed into...
7013         (open_source_file_with_line_charpos): ..this along with changes to
7014         return a scoped_fd, and some other minor clean ups.
7015         (identify_source_line): Use open_source_file_with_line_charpos.
7016         (search_command_helper): Use open_source_file_with_line_charpos
7017         instead of just open_source_file, remove call to
7018         find_source_lines.
7019         * source.h (open_source_file_with_line_charpos): Declare new
7020         function.
7021         (find_source_lines): Delete declaration.
7022
7023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7024
7025         * source.c (get_filename_and_charpos): Remove fullname
7026         parameter.
7027         (identify_source_line): Update call to get_filename_and_charpos.
7028
7029 2019-06-14  Tom Tromey  <tromey@adacore.com>
7030
7031         PR gdb/24502:
7032         * ui-style.h (skip_ansi_escape): Update comment.
7033         * ui-file.h (class no_terminal_escape_file): New class.
7034         * ui-file.c (no_terminal_escape_file::write)
7035         (no_terminal_escape_file::puts): New methods.
7036         * cli/cli-logging.c (handle_redirections): Use
7037         no_terminal_escape_file.
7038
7039 2019-06-14  Tom Tromey  <tromey@adacore.com>
7040
7041         * NEWS: Move convenience variable news above Python news.
7042
7043 2019-06-14  Tom Tromey  <tom@tromey.com>
7044
7045         * gnulib: Move directory to top-level.
7046         * configure.ac: Don't configure gnulib.
7047         * configure: Rebuild.
7048         * common/common-defs.h: Use new path to gnulib.
7049         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7050         (GNULIB_H): Remove.
7051         (INCGNU): Look in new gnulib location.
7052         (HFILES_NO_SRCDIR): Remove gnulib files.
7053         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7054         (generated_files): Remove GNULIB_H.
7055         ($(LIBGNU), all-lib): Remove targets.
7056         (distclean): Don't mention GNULIB_BUILDDIR.
7057         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7058
7059 2019-06-14  Tom Tromey  <tromey@adacore.com>
7060
7061         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7062         Warn if symbol file does not provide any symbols.
7063
7064 2019-06-14  Tom Tromey  <tromey@adacore.com>
7065
7066         * source.c (find_and_open_source): Respect basenames_may_differ.
7067
7068 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7069
7070         * annotate.c (annotate_breakpoints_invalid): Make use of
7071         scoped_restore_terminal_state.
7072         (annotate_frames_invalid): Likewise.
7073
7074 2019-06-14  Tom Tromey  <tromey@adacore.com>
7075
7076         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7077         allow assignment to an internalvar.
7078
7079 2019-06-14  Tom Tromey  <tromey@adacore.com>
7080
7081         * ada-lex.l: Allow "_" in attribute names.
7082
7083 2019-06-14  Tom Tromey  <tromey@adacore.com>
7084
7085         PR gdb/24653:
7086         * regcache.c (registers_changed): Don't call alloca.
7087         * top.c (execute_command): Don't call alloca.
7088
7089 2019-06-13  Pedro Alves  <palves@redhat.com>
7090
7091         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7092         'expression'.  When parsing an expression, error out if there's
7093         junk after "unlimited".
7094         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7095         (do_set_command): Adjust calls to is_unlimited_literal.
7096
7097 2019-06-13  Pedro Alves  <palves@redhat.com>
7098
7099         * compile/compile.c (make_compile_options_def_group): Add braces
7100         around array_view initializer.
7101         * thread.c (make_thread_apply_all_options_def_group)
7102         (make_thread_apply_all_options_def_group): Likewise.
7103
7104 2019-06-13  Pedro Alves  <palves@redhat.com>
7105
7106         * NEWS (New commands): Mention "maint test-options
7107         require-delimiter", "maint test-options unknown-is-error", "maint
7108         test-options unknown-is-operand" and "maint show
7109         test-options-completion-result".
7110         (New command options, command completion): New section.
7111         (Completion improvements): New section.
7112         Mention that you can abbreviate "unlimited".
7113
7114 2019-06-13  Pedro Alves  <palves@redhat.com>
7115
7116         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7117         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7118         * unittests/cli-utils-selftests.c (test_parse_flags)
7119         (test_parse_flags_qcs): Delete.
7120         (test_cli_utils): Don't call deleted functions.
7121
7122 2019-06-13  Pedro Alves  <palves@redhat.com>
7123
7124         * thread.c: Include "cli/cli-option.h".
7125         (tp_array_compar_ascending): Global.
7126         (tp_array_compar): Delete function.
7127         (tp_array_compar_ascending, tp_array_compar_descending): New
7128         functions.
7129         (ascending_option_def, qcs_flag_option_def)
7130         (thr_qcs_flags_option_defs)
7131         (make_thread_apply_all_options_def_group)
7132         (make_thread_apply_options_def_group): New.
7133         (thread_apply_all_command): Use gdb::option::process_options.
7134         (thread_apply_command_completer)
7135         (thread_apply_all_command_completer): New.
7136         (thread_apply_command): Use gdb::option::process_options.
7137         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7138         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7139         to generate help text of "thread apply".  Adjust "taas"'s help.
7140         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7141         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7142
7143 2019-06-13  Pedro Alves  <palves@redhat.com>
7144
7145         * thread.c (thread_apply_command): Check for invalid TID with
7146         isdigit instead of !isalpha.
7147
7148 2019-06-13  Pedro Alves  <palves@redhat.com>
7149
7150         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7151         (validate_flags_qcs): New.
7152         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7153         (validate_flags_qcs): Declare.
7154         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7155         (make_frame_apply_options_def_group): New.
7156         (frame_apply_command_count): Process options with
7157         gdb::option::process_options.
7158         (frame_apply_completer): New.
7159         (frame_apply_level_completer, frame_apply_all_completer)
7160         (frame_apply_completer): New.
7161         (_initialize_stack): Update help of "frame apply", "frame apply
7162         level", "frame apply all" and "faas" to mention supported options
7163         and install command completers.
7164         * stack.h (frame_apply_all_completer): Declare.
7165         * thread.c: Include "stack.h".
7166         (tfaas_command): Add "--".
7167         (_initialize_thread): Update help "tfaas" to mention supported
7168         options and install command completer.
7169
7170 2019-06-13  Pedro Alves  <palves@redhat.com>
7171
7172         * completer.c (complete_nested_command_line): New.
7173         (gdb_completion_word_break_characters_throw): Add assertion.
7174         * completer.h (complete_nested_command_line): Declare.
7175
7176 2019-06-13  Pedro Alves  <palves@redhat.com>
7177
7178         * stack.c (parse_backtrace_qualifiers): New.
7179         (backtrace_command): Use it.
7180         (backtrace_command_completer): Complete on qualifiers.
7181
7182 2019-06-13  Pedro Alves  <palves@redhat.com>
7183
7184         * frame.c: Include "cli/cli-option.h.
7185         (user_set_backtrace_options): New.
7186         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7187         Delete.
7188         (get_prev_frame): Adjust.
7189         (boolean_option_def, uinteger_option_def)
7190         (set_backtrace_option_defs): New.
7191         (_initialize_frame): Adjust and use
7192         gdb::option::add_setshow_cmds_for_options to install "set
7193         backtrace past-main" and "set backtrace past-entry".
7194         * frame.h: Include "cli/cli-option.h".
7195         (struct frame_print_options): Forward declare.
7196         (print_frame_arguments_all, print_frame_arguments_scalars)
7197         (print_frame_arguments_none): Declare.
7198         (print_entry_values): Delete declaration.
7199         (struct frame_print_options, user_frame_print_options): New.
7200         (struct set_backtrace_options): New.
7201         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7202         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7203         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7204         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7205         (list_args_or_locals): Add frame_print_options parameter.
7206         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7207         * python/py-framefilter.c (enumerate_args): Pass down
7208         USER_FRAME_PRINT_OPTIONS.
7209         * stack.c: Include "cli/cli-option.h".
7210         (print_frame_arguments_all, print_frame_arguments_scalars)
7211         (print_frame_arguments_none): Declare.
7212         (print_raw_frame_arguments, print_entry_values): Delete.
7213         (user_frame_print_options): New.
7214         (boolean_option_def, enum_option_def, frame_print_option_defs):
7215         New.
7216         (struct backtrace_cmd_options): New.
7217         (bt_flag_option_def): New.
7218         (backtrace_command_option_defs): New.
7219         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7220         (print_frame_arg, read_frame_arg, print_frame_args)
7221         (print_frame_info, print_frame): Add frame_print_options parameter
7222         and use it.
7223         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7224         (backtrace_command_1): Add frame_print_options and
7225         backtrace_cmd_options parameters and use them.
7226         (make_backtrace_options_def_group): New.
7227         (backtrace_command): Process command options with
7228         gdb::option::process_options.
7229         (backtrace_command_completer): New.
7230         (_initialize_stack): Extend "backtrace"'s help to mention
7231         supported options.  Install completer for "backtrace".
7232         Install some settings commands with add_setshow_cmds_for_options.
7233
7234 2019-06-13  Pedro Alves  <palves@redhat.com>
7235
7236         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7237         and that "set/show print raw frame-arguments" are now deprecated.
7238
7239         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7240         command.
7241         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7242         * stack.c (_initialize_stack): Install "set/show print
7243         raw-frame-arguments", and deprecate "set/show print raw
7244         frame-arguments".
7245         * valprint.c (_initialize_valprint): Deprecate "set/show print
7246         raw".
7247
7248 2019-06-13  Pedro Alves  <palves@redhat.com>
7249
7250         * compile/compile.c (struct compile_options): New.
7251         (compile_flag_option_def, compile_command_option_defs)
7252         (make_compile_options_def_group): New.
7253         (compile_file_command): Handle options with
7254         gdb::option::process_options.
7255         (compile_file_command_completer): New function.
7256         (compile_code_command): Handle options with
7257         gdb::option::process_options.
7258         (compile_code_command_completer): New function.
7259         (_initialize_compiler): Install completers for "compile code" and
7260         "compile file".  Mention available options in "compile code" and
7261         "compile code"'s help.
7262         * completer.c (advance_to_completion_word): New, factored out from
7263         ...
7264         (advance_to_expression_complete_word_point): ... this.
7265         (advance_to_filename_complete_word_point): New.
7266         * completer.h (advance_to_filename_complete_word_point): New
7267         declaration.
7268
7269 2019-06-13  Pedro Alves  <palves@redhat.com>
7270
7271         * compile/compile.c: Include "cli/cli-option.h".
7272         (compile_print_value): Scope data pointer is now a
7273         value_print_options pointer; adjust.
7274         (compile_print_command): Process options.  Scope data pointer is
7275         now a value_print_options pointer; adjust.
7276         (_initialize_compile): Update "compile print"'s help to include
7277         supported options.  Install a completer for "compile print".
7278         * cp-valprint.c (show_vtblprint, show_objectprint)
7279         (show_static_field_print): Delete.
7280         (_initialize_cp_valprint): Don't install "set print
7281         static-members", "set print vtbl", "set print object" here.
7282         * printcmd.c: Include "cli/cli-option.h" and
7283         "common/gdb_optional.h".
7284         (print_command_parse_format): Rework to fill in a
7285         value_print_options instead of a format_data.
7286         (print_value): Change parameter type from format_data pointer to
7287         value_print_options reference.  Adjust.
7288         (print_command_1): Process options.  Adjust to pass down a
7289         value_print_options.
7290         (print_command_completer): New.
7291         (_initialize_printcmd): Install print_command_completer as
7292         handle_brkchars completer for the "print" command.  Update
7293         "print"'s help to include supported options.
7294         * valprint.c: Include "cli/cli-option.h".
7295         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7296         here from cp-valprint.c.
7297         (boolean_option_def, uinteger_option_def)
7298         (value_print_option_defs, make_value_print_options_def_group):
7299         New.  Use gdb::option::add_setshow_cmds_for_options to install
7300         "set print elements", "set print null-stop", "set print repeats",
7301         "set print pretty", "set print union", "set print array", "set
7302         print address", "set print symbol", "set print array-indexes".
7303         * valprint.h: Include <string> and "cli/cli-option.h".
7304         (make_value_print_options_def_group): Declare.
7305         (print_value): Change parameter type from format_data pointer to
7306         value_print_options reference.
7307         (print_command_completer): Declare.
7308
7309 2019-06-13  Pedro Alves  <palves@redhat.com>
7310
7311         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7312         (COMMON_SFILES): Add maint-test-settings.c.
7313         * cli/cli-decode.c (boolean_enums): New global, factored out from
7314         ...
7315         (add_setshow_boolean_cmd): ... here.
7316         * cli/cli-decode.h (boolean_enums): Declare.
7317         * cli/cli-option.c: New file.
7318         * cli/cli-option.h: New file.
7319         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7320         factored out from ...
7321         (parse_cli_boolean_value(const char *)): ... this.
7322         (is_unlimited_literal): Change parameter type to pointer to
7323         pointer.  Adjust and advance ARG pointer.
7324         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7325         (parse_cli_var_enum): New, factored out from ...
7326         (do_set_command): ... this.  Adjust.
7327         * cli/cli-setshow.h (parse_cli_boolean_value)
7328         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7329         (parse_cli_var_enum): Declare.
7330         * cli/cli-utils.c: Include "cli/cli-option.h".
7331         (get_ulongest): New.
7332         * cli/cli-utils.h (get_ulongest): Declare.
7333         (check_for_argument): New overloads.
7334         * maint-test-options.c: New file.
7335
7336 2019-06-13  Pedro Alves  <palves@redhat.com>
7337
7338         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7339         parse a range if "-" is at the end of the string.
7340
7341 2019-06-13  Pedro Alves  <palves@redhat.com>
7342
7343         * cli/cli-setshow.c (parse_auto_binary_operation)
7344         (parse_cli_boolean_value): Don't allow "o".
7345
7346 2019-06-13  Pedro Alves  <palves@redhat.com>
7347
7348         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7349         * NEWS: Mention maint test-settings KIND.
7350         * maint-test-settings.c: New file.
7351
7352 2019-06-13  Pedro Alves  <palves@redhat.com>
7353
7354         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7355         completer.
7356         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7357         "set" completers.
7358
7359 2019-06-13  Pedro Alves  <palves@redhat.com>
7360
7361         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7362         after item.
7363
7364 2019-06-13  Pedro Alves  <palves@redhat.com>
7365
7366         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7367
7368 2019-06-13  Pedro Alves <palves@redhat.com>
7369
7370         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7371         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7372         call.
7373         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7374         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7375         calls.
7376         (check_for_argument): Skip spaces after argument.
7377
7378 2019-06-13  Pedro Alves  <palves@redhat.com>
7379
7380         * thread.c (thread_apply_command): Adjust TID parsing.
7381         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7382         detected before end of string.
7383         (tid_is_in_list): Error out if LIST is invalid.
7384
7385 2019-06-13  Pedro Alves  <palves@redhat.com>
7386
7387         * completer.c (complete_line_internal_1): Rewind completion word
7388         point.
7389         (completion_tracker::advance_custom_word_point_by): Change
7390         parameter type to int.
7391         * completer.h (completion_tracker::advance_custom_word_point_by):
7392         Likewise.
7393
7394 2019-06-13  Pedro Alves  <palves@redhat.com>
7395
7396         * completer.c (advance_to_completion_word): Handle delimiters.
7397
7398 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7399
7400         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7401
7402 2019-06-11  Tom Tromey  <tom@tromey.com>
7403
7404         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7405         (xmalloc_failed): Move to alloc.c.
7406         * alloc.c: New file.
7407         * Makefile.in (COMMON_SFILES): Add alloc.c.
7408
7409 2019-06-11  Tom Tromey  <tom@tromey.com>
7410
7411         * nat/linux-waitpid.c: Don't include server.h.
7412         (linux_debug): Remove.
7413         (my_waitpid): Update.
7414
7415 2019-06-11  Tom Tromey  <tromey@adacore.com>
7416
7417         * infcall.c (_initialize_infcall): Remove trailing newline from
7418         help.
7419         * user-regs.c (_initialize_user_regs): Remove trailing newline
7420         from help.
7421         * typeprint.c (_initialize_typeprint): Remove trailing newline
7422         from help.
7423         * reverse.c (_initialize_reverse): Remove trailing newlines from
7424         help.
7425         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7426         from help.
7427         * language.c (add_set_language_command): Remove trailing newline
7428         from help.
7429         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7430         help.
7431         * disasm.c (_initialize_disasm): Remove trailing newline from
7432         help.
7433         * top.c (init_main): Remove trailing newline from help.
7434         * interps.c (_initialize_interpreter): Remove trailing newline
7435         from help.
7436         * btrace.c (_initialize_btrace): Remove trailing newlines from
7437         help.
7438         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7439         from help.
7440         * python/python.c (_initialize_python): Remove trailing newline
7441         from help.
7442         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7443         help.
7444         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7445         from help.  Reformat some text.
7446         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7447         from help.
7448         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7449         newline from help.
7450
7451 2019-06-11  Tom Tromey  <tromey@adacore.com>
7452
7453         * darwin-nat.c (darwin_decode_exception_message)
7454         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7455
7456 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         * valops.c (value_slice): Check for not allocated or not
7459         associated values.
7460
7461 2019-06-10  Tom de Vries  <tdevries@suse.de>
7462
7463         PR gdb/24618
7464         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7465         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7466         invalid.
7467
7468 2019-06-10  Tom de Vries  <tdevries@suse.de>
7469
7470         PR gdb/24611
7471         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7472         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7473
7474 2019-06-10  Tom de Vries  <tdevries@suse.de>
7475
7476         PR symtab/24545
7477         * symtab.c (struct demangled_name_entry): Add language field.
7478         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7479         static minimal symbol".  Set and use language field.
7480
7481 2019-06-10  Tom Tromey  <tromey@adacore.com>
7482
7483         * ada-lang.c (_initialize_ada_language): Update help text.
7484
7485 2019-06-10  Tom Tromey  <tromey@adacore.com>
7486
7487         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7488         with a newline.
7489         * guile/guile.c (handle_boot_error): Don't end warning with a
7490         newline.
7491         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7492         warning with a newline.
7493         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7494         newline.
7495         (s12z_frame_cache): Likewise.
7496         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7497         a newline.
7498         * solib-svr4.c (disable_probes_interface): Don't end warning with
7499         a newline.
7500         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7501         newline.
7502         * python/python.c (do_finish_initialization): Don't end warning
7503         with a newline.
7504
7505 2019-06-10  Tom Tromey  <tom@tromey.com>
7506
7507         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7508         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7509         gdbpy_enter.
7510
7511 2019-06-10  Tom Tromey  <tromey@adacore.com>
7512
7513         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7514         data.
7515         (elf_new_init): Don't call stabsread_new_init.
7516         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7517         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7518         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7519
7520 2019-06-10  Tom de Vries  <tdevries@suse.de>
7521
7522         PR symtab/16264
7523         PR symtab/24517
7524         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7525
7526 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7527
7528         * source.c (find_and_open_source): Also rewrite relative file
7529         names.
7530
7531 2019-04-26  Amos Bird  <amosbird@gmail.com>
7532
7533         * annotate.c (annotate_thread_exited): Add "thread-exited"
7534         annotation.
7535
7536 2019-06-06  Tom Tromey  <tromey@adacore.com>
7537
7538         * maint.h (class scoped_command_stats): Use
7539         DISABLE_COPY_AND_ASSIGN.
7540         <print_time>: New method.
7541         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7542         print_time.
7543         (scoped_command_stats::print_time): New method.
7544
7545 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7548         instructions of lengths 6 or 8 bytes.
7549
7550 2019-06-04  Pedro Alves  <palves@redhat.com>
7551
7552         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7553
7554         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7555         * breakpoint.c (condition_completer): Likewise.
7556         * cli/cli-dump.c (scan_expression): Likewise.
7557         * common/filestuff.c (mkdir_recursive): Likewise.
7558         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7559         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7560         (gdb_abspath): Likewise.
7561         * compile/compile-cplus-types.c
7562         (compile_cplus_instance::decl_name): Likewise.
7563         * completer.c (complete_explicit_location):
7564         (signal_completer, reg_or_group_completer_1): Likewise.
7565         * cp-support.c (cp_remove_params_if_any): Likewise.
7566         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7567         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7568         * infcmd.c (strip_bg_char): Likewise.
7569         * linespec.c (copy_token_string): Likewise.
7570         * mi/mi-main.c (output_cores): Likewise.
7571         * psymtab.c (psymtab_search_name):
7572         * symfile.c (test_set_ext_lang_command): Likewise.
7573         * target.c (target_fileio_read_stralloc): Likewise.
7574         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7575         * value.c (complete_internalvar): Likewise.
7576
7577 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7578
7579         Add objfile property to gdb.Type.
7580         * NEWS: Mention Python API addition.
7581         * python/py-type.c (typy_get_objfile): New method.
7582
7583 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7584
7585         * NEWS: Mention the new set|show style [title|highlight].
7586         Mention changes to "show style", "help" and "apropos".
7587
7588 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7589
7590         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7591         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7592         instead of print_help_for_command.
7593         (print_doc_of_command): New function.
7594         (help_list): Add 'apropos -v word' suggestion.
7595         (print_help_for_command): Style the command name using title style.
7596         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7597         (_initialize_cli_cmds): Describe -v in apropos_command help.
7598
7599 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7600
7601         * cli/cli-style.h (cli_style_option): Add name in constructor,
7602         add m_name class member, add constructor with intensity,
7603         add name class function.
7604         (cli_style_option::add_setshow_commands): Remove name argument.
7605         (highlight_style, title_style): New styles.
7606         * cli/cli-style.c (do_show): New function that shows a style
7607         characteristic styling the style name with itself.
7608         (set_style_name): New function.
7609         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7610         Update all callers according to the changes in cli/cli-style.h.
7611         * utils.h (fputs_highlighted): New function.
7612         * utils.c (fputs_highlighted): Likewise.
7613
7614 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7615
7616         * NEWS: Mention new pipe command and new convenience variables.
7617
7618 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7619
7620         * cli/cli-cmds.c (pipe_command): New function.
7621         (_initialize_cli_cmds): Call add_com for pipe_command.
7622         Define | as an alias for pipe.
7623         (exit_status_set_internal_vars): New function.
7624         (shell_escape): Call exit_status_set_internal_vars.
7625         cli/cli-decode.c (find_command_name_length): Recognize | as
7626         a single character command.
7627
7628 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7629
7630         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7631         top.c (execute_command_to_ui_file): New function, mostly a copy
7632         of execute_command_to_string.
7633         (execute_command_to_string): Implement by calling
7634         execute_command_to_ui_file.
7635
7636 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7637
7638         * top.h (saved_command_line): Remove declaration.
7639         * top.c (previous_saved_command_line, previous_repeat_arguments):
7640         New variables.
7641         (saved_command_line): Make static, define together with other
7642         'repeat variables'.
7643         (dont_repeat): Clear repeat_arguments.
7644         (repeat_previous, get_saved_command_line, save_command_line):
7645         New functions.
7646         (gdb_init): Initialize saved_command_line
7647         and previous_saved_command_line.
7648         * main.c (captured_main_1): Remove saved_command_line initialization.
7649         * event-top.c (handle_line_of_input): Update to use
7650         the new 'repeat' related functions instead of direct access to
7651         saved_command_line.
7652         * command.h (repeat_previous, get_saved_command_line,
7653         save_command_line): New declarations.
7654         (dont_repeat): Add comment.
7655
7656 2019-05-30  Tom Tromey  <tromey@adacore.com>
7657
7658         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7659         Fix comment.
7660         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7661
7662 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7663
7664         PR cli/24587
7665         * completer.c (complete): Initialize variable word.
7666
7667 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7668
7669         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7670         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7671         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7672         'body' is NULL to the outter 'if', protecting the '!is_define'
7673         situation as well.
7674
7675 2019-05-29  Tom Tromey  <tromey@adacore.com>
7676
7677         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7678         (dwarf_unknown): New function.
7679         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7680         (dwarf_type_encoding_name): Use dwarf_unknown.
7681
7682 2019-05-29  Tom Tromey  <tromey@adacore.com>
7683
7684         PR c++/20020:
7685         * cp-valprint.c (cp_print_value_fields): Call
7686         cp_print_static_field inside "try".
7687
7688 2019-05-29  Tom Tromey  <tromey@adacore.com>
7689
7690         * inflow.c (struct terminal_info): Add default operator=.
7691         * configure: Rebuild.
7692         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7693         -Wdeprecated-copy-dtor, -Wredundant-move.
7694
7695 2019-05-29  Tom Tromey  <tromey@adacore.com>
7696
7697         * NEWS: Add entry.
7698         * infcmd.c (print_return_value_1): Handle finish_print
7699         option.
7700         (show_print_finish): New function.
7701         (_initialize_infcmd): Add "set/show print finish" commands.
7702         * valprint.c (user_print_options): Initialize new member.
7703         * valprint.h (struct value_print_options) <finish_print>: New
7704         member.
7705
7706 2019-05-28  Tom Tromey  <tromey@adacore.com>
7707
7708         * ada-lang.c (ada_remove_Xbn_suffix)
7709         (find_old_style_renaming_symbol)
7710         (parse_old_style_renaming): Remove.
7711         (ada_find_renaming_symbol): Don't call
7712         find_old_style_renaming_symbol.
7713         (ada_is_renaming_symbol): Rename from
7714         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7715         bool.  Now static.
7716         (ada_read_var_value): Update and simplify.
7717         * ada-exp.y (write_var_or_type): Remove old code.
7718
7719 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7720
7721         PR gdb/25010
7722         * event-top.c: Remove include comment.
7723         * inflow.c (class scoped_ignore_sigttou): Move from here...
7724         * inflow.h (class scoped_ignore_sigttou): ...to here.
7725         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7726         * top.c:  Remove include comment.
7727
7728 2019-05-27  Tom Tromey  <tom@tromey.com>
7729
7730         * NEWS: Fix typo.
7731
7732 2019-05-22  Tom Tromey  <tromey@adacore.com>
7733
7734         * target.c (target_follow_exec): Constify parameter.
7735         * target-delegates.c: Rebuild.
7736         * remote.c (remote_target::follow_exec): Constify parameter.
7737         * infrun.c (follow_exec): Constify parameter.
7738         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7739         (target_follow_exec): Likewise.
7740
7741 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7742
7743         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7744         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7745
7746 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7747
7748         * NEWS: Add debugredirect and testsuite sections.
7749
7750 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7751
7752         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7753         target descriptions using exclusively floating point register name
7754         aliases.
7755
7756 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         PR gdb/18644:
7759         * f-lang.c (build_fortran_types): Handle the case where
7760         gdbarch_floatformat_for_type returns a nullptr.
7761
7762 2019-05-21  Tom de Vries  <tdevries@suse.de>
7763
7764         PR cli/24587
7765         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7766
7767 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         PR gdb/18644:
7770         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7771         16-byte floats.
7772         * i386-tdep.c (i386_floatformat_for_type): Use
7773         floatformats_ia64_quad for the 16-byte floating point component
7774         within a fortran 32-byte complex number.
7775
7776 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7779         delete default constructor.
7780         (find_partial_die): Update to return const struct.
7781         (partial_die_parent_scope): Move variable declaration into scope
7782         of its use and change its type to auto.
7783         (guess_partial_die_structure_name): Likewise.
7784         (partial_die_info::fixup): Likewise.
7785
7786 2019-05-17  Tom Tromey  <tromey@adacore.com>
7787
7788         * source.c (find_and_open_source): Remove cast.
7789
7790 2019-05-17  Tom Tromey  <tromey@adacore.com>
7791
7792         * annotate.c (annotate_source): Make "filename" const.
7793         * annotate.h (annotate_source): Use const.
7794
7795 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7796
7797         * disasm.c (set_disassembler_options): Send errors to stderr.
7798
7799 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7800
7801         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7802         (cli_interp_base::set_logging): Check debug_redirect.
7803         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7804         * cli/cli-logging.c (debug_redirect): Add static variable.
7805         (pop_output_files): Add default param.
7806         (handle_redirections): Print debug setting.
7807         (show_logging_command): Likewise.
7808         (_initialize_cli_logging): Add debugredirect command.
7809         * interps.c (current_interp_set_logging): Add debug_redirect
7810         parameter.
7811         * interps.h (set_logging): Add debug_redirect parameter.
7812         (current_interp_set_logging): Likewise.
7813         * mi/mi-common.h: Likewise.
7814         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7815
7816 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7817             Tom Tromey  <tromey@adacore.com>
7818
7819         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7820         directly.
7821         * cli/cli-interp.h (make_logging_output): Remove declaration.
7822         * cli/cli-logging.c (make_logging_output): Remove function.
7823         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7824         directly.
7825         * ui-file.c (tee_file::tee_file): Remove bools.
7826         (tee_file::~tee_file): Remove deletes.
7827         * ui-file.h (tee_file): Remove bools.
7828
7829 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7830
7831         * mi/mi-cmds.h (mi_cmd_complete): New function.
7832         * mi/mi-main.c (mi_cmd_complete): Likewise.
7833         * mi/mi-cmds.c: Define new MI command -complete.
7834         * NEWS: Mention new -complete command.
7835
7836 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7837
7838         * completer.h (complete): New function.
7839         * completer.c (complete): Likewise.
7840         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7841         function defined in completer.h.
7842
7843 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7844
7845         * MAINTAINERS (Write After Approval): Add myself.
7846
7847 2019-05-17  Tom de Vries  <tdevries@suse.de>
7848
7849         PR gdb/24094
7850         * dwarf2read.c (struct cu_partial_die_info): New struct.
7851         (find_partial_die): Return cu_partial_die_info.
7852         (partial_die_parent_scope, guess_partial_die_structure_name)
7853         (partial_die_info::fixup): Handle new return type of find_partial_die.
7854
7855 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7856
7857         PR breakpoints/24541
7858         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7859         "std::string", simplifying the algorithm.
7860
7861 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7862
7863         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7864         (stap_static_probe_ops::get_probes): Likewise.
7865
7866 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7867
7868         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7869         '-')" and "else if".
7870         (stap_parse_single_operand): Join checks for
7871         "gdbarch_stap_parse_special_token_p" and
7872         "gdbarch_stap_parse_special_token" in the same "if" statement.
7873         Invert check when verifying for operation on register
7874         displacement.
7875
7876 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7877
7878         * stap-probe.c (stap_get_opcode): Update comment.
7879         (stap_get_expected_argument_type): Likewise.
7880         (handle_stap_probe): Likewise.
7881
7882 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7883
7884         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7885         return type to 'bool'.  Adjust comment.  Use 'bool' when
7886         appropriate.
7887         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7888         * stap-probe.c (stap_parse_argument_1): Likewise.
7889         (stap_is_operator): Likewise.
7890         (stap_is_generic_prefix): Likewise.
7891         (stap_is_register_prefix): Likewise.
7892         (stap_is_register_indirection_prefix): Likewise.
7893         (stap_is_integer_prefix): Likewise.
7894         (stap_generic_check_suffix): Likewise.
7895         (stap_check_integer_suffix): Likewise.
7896         (stap_check_register_suffix): Likewise.
7897         (stap_check_register_indirection_suffix): Likewise.
7898         (stap_parse_register_operand): Likewise.
7899         (stap_parse_single_operand): Likewise.
7900         (stap_parse_argument_1): Likewise.
7901         (stap_probe::get_argument_count): Likewise.
7902         (stap_is_operator): Likewise.
7903
7904 2019-05-16  Tom Tromey  <tromey@adacore.com>
7905
7906         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7907         keyword to foreach.
7908
7909 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7910
7911         * linux-thread-db.c (try_thread_db_load_1): Change return type
7912         to bool.
7913         (try_thread_db_load): Likewise.
7914         (try_thread_db_load_from_pdir_1): Likewise.
7915         (try_thread_db_load_from_pdir): Likewise.
7916         (try_thread_db_load_from_sdir): Likewise.
7917         (try_thread_db_load_from_dir): Likewise.
7918         (thread_db_load_search): Likewise.
7919         (has_libpthread): Likewise.
7920         (thread_db_load): Likewise.
7921
7922 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7923
7924         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7925         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7926         NULL, and complain/return if that's the case.
7927
7928 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7929
7930         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7931         (advance, posn, abstract_read_memory): New functions.
7932         [struct mem_read_abstraction]: New struct.
7933         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7934
7935 2019-05-14  Tom Tromey  <tromey@adacore.com>
7936
7937         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7938         value is not lval_memory.
7939
7940 2019-05-14  Tom Tromey  <tromey@adacore.com>
7941
7942         * solib.c (info_sharedlibrary_command): Style the file name.
7943
7944 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7945
7946         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7947         (aarch64_vnv_type): Likewise.
7948         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7949         * common/tdesc.c: Likewise.
7950         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7951         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7952         * features/aarch64-fpu.xml: Add ieee half view.
7953         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7954         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7955         * gdbtypes.h (struct builtin_type): Likewise.
7956         (struct objfile_type): Likewise.
7957
7958 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7959
7960         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7961         typo.
7962         * location.h (string_to_event_location): Likewise.
7963
7964 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7965
7966         GDB 8.3 released.
7967
7968 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7969
7970         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7971         New variable declaration.
7972         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7973         New variable.
7974         (print_one_breakpoint): Use ui_out::test_flags and new global
7975         variable to compute use_fixed_output.
7976         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7977         Remove.
7978         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7979         (mi_multi_location_breakpoint_output_fixed): Remove.
7980         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7981         new variable.
7982         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7983         fix_multi_location_breakpoint_output flag if version >= 3.
7984         * ui-out.h (enum ui_out_flag)
7985         <fix_multi_location_breakpoint_output>: New enumerator.
7986
7987 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7988
7989         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7990
7991 2019-05-10  Tom Tromey  <tromey@adacore.com>
7992
7993         * ada-lang.c (catch_ada_completer): New function.
7994         (_initialize_ada_language): Use it.
7995
7996 2019-05-10  Tom Tromey  <tromey@adacore.com>
7997
7998         * thread.c (print_thread_info): Make "requested_threads" const.
7999         * gdbthread.h (print_thread_info): Make "requested_threads"
8000         const.
8001         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8002         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8003
8004 2019-05-08  Tom Tromey  <tom@tromey.com>
8005
8006         * gdbtypes.c (objfile_type_data): Change type.
8007         (objfile_type, _initialize_gdbtypes): Update.
8008
8009 2019-05-08  Tom Tromey  <tom@tromey.com>
8010
8011         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8012         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8013         (_initialize_dwarf2_frame): Update.
8014
8015 2019-05-08  Tom Tromey  <tom@tromey.com>
8016
8017         * objc-lang.c (objc_objfile_data): Change type.
8018         (find_methods): Update.
8019         (_initialize_objc_lang): Remove.
8020
8021 2019-05-08  Tom Tromey  <tom@tromey.com>
8022
8023         * stabsread.c (rs6000_builtin_type_data): Change type.
8024         (rs6000_builtin_type, _initialize_stabsread): Update.
8025
8026 2019-05-08  Tom Tromey  <tom@tromey.com>
8027
8028         * mips-tdep.c (mips_pdr_data): Remove.
8029         (_initialize_mips_tdep): Update.
8030
8031 2019-05-08  Tom Tromey  <tom@tromey.com>
8032
8033         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8034         (hppa_init_objfile_priv_data, read_unwind_info)
8035         (find_unwind_entry, _initialize_hppa_tdep): Update.
8036
8037 2019-05-08  Tom Tromey  <tom@tromey.com>
8038
8039         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8040         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8041         on obstack.
8042         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8043
8044 2019-05-08  Tom Tromey  <tom@tromey.com>
8045
8046         * mdebugread.c (basic_type_data): Change type.
8047         (basic_type, _initialize_mdebugread): Update.
8048
8049 2019-05-08  Tom Tromey  <tom@tromey.com>
8050
8051         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8052
8053 2019-05-08  Tom Tromey  <tom@tromey.com>
8054
8055         * nto-tdep.c (nto_inferior_data_reg): Change type.
8056         (nto_inferior_data): Update.
8057         (nto_inferior_data_cleanup, nto_new_inferior_data)
8058         (_initialize_nto_tdep): Remove.
8059         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8060
8061 2019-05-08  Tom Tromey  <tom@tromey.com>
8062
8063         * ada-lang.c (struct ada_inferior_data): Add initializers.
8064         (ada_inferior_data): Change type.
8065         (ada_inferior_data_cleanup): Remove.
8066         (get_ada_inferior_data, ada_inferior_exit)
8067         (struct ada_pspace_data): Add initializers, destructor.
8068         (ada_pspace_data_handle): Change type.
8069         (get_ada_pspace_data): Update.
8070         (ada_pspace_data_cleanup): Remove.
8071
8072 2019-05-08  Tom Tromey  <tom@tromey.com>
8073
8074         * coffread.c (struct coff_symfile_info): Add initializers.
8075         (coff_objfile_data_key): Move lower.  Change type.
8076         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8077         Update.
8078         (coff_free_info): Remove.
8079
8080 2019-05-08  Tom Tromey  <tom@tromey.com>
8081
8082         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8083         (fbsd_pspace_data_handle): Move lower.  Change type.
8084         (get_fbsd_pspace_data): Update.
8085         (fbsd_pspace_data_cleanup): Remove.
8086         (_initialize_fbsd_tdep): Update.
8087
8088 2019-05-08  Tom Tromey  <tom@tromey.com>
8089
8090         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8091         (get_ada_tasks_pspace_data): Update.
8092         (ada_tasks_pspace_data_cleanup): Remove.
8093         (_initialize_tasks): Update.
8094         (ada_tasks_inferior_data_handle): Change type.
8095         (get_ada_tasks_inferior_data): Update.
8096         (ada_tasks_inferior_data_cleanup): Remove.
8097         (struct ada_tasks_pspace_data): Add initializers.
8098
8099 2019-05-08  Tom Tromey  <tom@tromey.com>
8100
8101         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8102         * symfile-debug.c (debug_sym_get_probes): Change type.
8103         * stap-probe.c (handle_stap_probe):
8104         (stap_static_probe_ops::get_probes): Change type.
8105         * probe.h (class static_probe_ops) <get_probes>: Change type.
8106         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8107         (parse_probes_in_pspace): Update.
8108         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8109         Update.
8110         (any_static_probe_ops::get_probes): Change type.
8111         * elfread.c (elfread_data): New typedef.
8112         (probe_key): Change type.
8113         (elf_get_probes): Likewise.  Update.
8114         (probe_key_free): Remove.
8115         (_initialize_elfread): Update.
8116         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8117         Change type.
8118         (dtrace_process_dof_probe, dtrace_process_dof)
8119         (dtrace_static_probe_ops::get_probe): Change type.
8120
8121 2019-05-08  Tom Tromey  <tom@tromey.com>
8122
8123         * xcoffread.c (struct xcoff_symfile_info): Rename from
8124         coff_symfile_info.  Add initializers.
8125         (xcoff_objfile_data_key): Move lower.  Change type.
8126         (XCOFF_DATA): Rewrite.
8127         (xcoff_free_info): Remove.
8128         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8129         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8130         (xcoff_initial_scan): Update.
8131
8132 2019-05-08  Tom Tromey  <tom@tromey.com>
8133
8134         * solib-svr4.c (struct svr4_info): Add initializers and
8135         destructor.
8136         <probes_table>: Now an htab_up.
8137         (solib_svr4_pspace_data): Change type.
8138         (free_probes_table): Simplify.
8139         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8140         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8141         (probes_table_remove_objfile_probes, register_solib_event_probe)
8142         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8143         (_initialize_svr4_solib): Update.
8144
8145 2019-05-08  Tom Tromey  <tom@tromey.com>
8146
8147         * remote.c (remote_pspace_data): Change type.
8148         (remote_pspace_data_cleanup): Remove.
8149         (get_remote_exec_file, set_pspace_remote_exec_file)
8150         (_initialize_remote): Update.
8151
8152 2019-05-08  Tom Tromey  <tom@tromey.com>
8153
8154         * breakpoint.c (breakpoint_objfile_key): Change type.
8155         (get_breakpoint_objfile_data): Update.
8156         (free_breakpoint_objfile_data): Remove.
8157         (_initialize_breakpoint): Update.
8158
8159 2019-05-08  Tom Tromey  <tom@tromey.com>
8160
8161         * linux-tdep.c (struct linux_info): Add initializers.
8162         (linux_inferior_data): Move.  Change type.
8163         (invalidate_linux_cache_inf): Update.
8164         (linux_inferior_data_cleanup): Remove.
8165         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8166
8167 2019-05-08  Tom Tromey  <tom@tromey.com>
8168
8169         * auxv.c (auxv_inferior_data): Move.  Change type.
8170         (auxv_inferior_data_cleanup): Remove.
8171         (invalidate_auxv_cache_inf): Rewrite.
8172         (get_auxv_inferior_data, _initialize_auxv): Update.
8173
8174 2019-05-08  Tom Tromey  <tom@tromey.com>
8175
8176         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8177         (symfile_debug_objfile_data_key): Change type.
8178         (symfile_debug_installed, debug_qf_has_symbols)
8179         (debug_qf_find_last_source_symtab)
8180         (debug_qf_forget_cached_source_info)
8181         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8182         (debug_qf_print_stats, debug_qf_dump)
8183         (debug_qf_expand_symtabs_for_function)
8184         (debug_qf_expand_all_symtabs)
8185         (debug_qf_expand_symtabs_with_fullname)
8186         (debug_qf_map_matching_symbols)
8187         (debug_qf_expand_symtabs_matching)
8188         (debug_qf_find_pc_sect_compunit_symtab)
8189         (debug_qf_map_symbol_filenames)
8190         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8191         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8192         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8193         (debug_sym_read_linetable, debug_sym_relocate): Update.
8194         (symfile_debug_free_objfile): Remove.
8195         (install_symfile_debug_logging, _initialize_symfile_debug):
8196         Update.
8197
8198 2019-05-08  Tom Tromey  <tom@tromey.com>
8199
8200         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8201         allocate_on_obstack.
8202         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8203         (get_dwarf2_per_objfile): Update.
8204         (set_dwarf2_per_objfile): Remove.
8205         (dwarf2_has_info, dwarf2_get_section_info): Update.
8206         (dwarf2_free_objfile): Remove.
8207         (_initialize_dwarf2_read): Update.
8208
8209 2019-05-08  Tom Tromey  <tom@tromey.com>
8210
8211         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8212         initializers.
8213         <unsupported_script_warning_printed,
8214         script_not_found_warning_printed>: Now bool.
8215         (auto_load_pspace_data): Change type.
8216         (~auto_load_pspace_info): Rename from
8217         auto_load_pspace_data_cleanup.
8218         (get_auto_load_pspace_data, init_loaded_scripts_info)
8219         (clear_section_scripts, maybe_print_unsupported_script_warning)
8220         (maybe_print_script_not_found_warning, _initialize_auto_load):
8221         Update.
8222
8223 2019-05-08  Tom Tromey  <tom@tromey.com>
8224
8225         * objfiles.c (objfile_pspace_info): Add destructor and
8226         initializers.
8227         (objfiles_pspace_data): Change type.
8228         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8229         (get_objfile_pspace_data): Update.
8230         (objfiles_bfd_data): Change type.
8231         (get_objfile_bfd_data): Update.
8232         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8233
8234 2019-05-08  Tom Tromey  <tom@tromey.com>
8235
8236         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8237         Change type.
8238         (get_catch_syscall_inferior_data): Update.
8239         (catch_syscall_inferior_data_cleanup): Remove.
8240         (_initialize_break_catch_syscall): Update.
8241
8242 2019-05-08  Tom Tromey  <tom@tromey.com>
8243
8244         * inflow.c (struct terminal_info): Add destructor and
8245         initializers.
8246         (inflow_inferior_data): Change type.
8247         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8248         (get_inflow_inferior_data, inflow_inferior_exit)
8249         (swap_terminal_info, _initialize_inflow): Update.
8250
8251 2019-05-08  Tom Tromey  <tom@tromey.com>
8252
8253         * target-dcache.c (target_dcache_cleanup): Remove.
8254         (target_dcache_aspace_key): Change type.
8255         (target_dcache_init_p, target_dcache_invalidate)
8256         (target_dcache_get, target_dcache_get_or_init)
8257         (_initialize_target_dcache): Update.
8258         * dcache.h (struct dcache_deleter): New.
8259
8260 2019-05-08  Tom Tromey  <tom@tromey.com>
8261
8262         * symtab.c (struct symbol_cache): Add destructor and
8263         initializers.
8264         (symbol_cache_key): Move.  Change type.
8265         (make_symbol_cache, free_symbol_cache): Remove.
8266         (get_symbol_cache): Update.
8267         (symbol_cache_cleanup): Remove.
8268         (ALL_PSPACES, symbol_cache_flush)
8269         (maintenance_print_symbol_cache)
8270         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8271         Update.
8272
8273 2019-05-08  Tom Tromey  <tom@tromey.com>
8274
8275         * symtab.c (struct main_info): Add destructor and initializers.
8276         (main_progspace_key): Move.  Change type.
8277         (get_main_info): Update.
8278         (main_info_cleanup): Remove.
8279         (_initialize_symtab): Update.
8280
8281 2019-05-08  Tom Tromey  <tom@tromey.com>
8282
8283         * registry.h (DECLARE_REGISTRY): Define the _key class.
8284
8285 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8286
8287         * NEWS: Merge two 'New commands' sections.
8288
8289 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8290
8291         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8292         parameter and use Ada language definition instead.
8293         (ada_val_print_ptr): Remove unused language parameter.
8294         (ada_val_print_num): Remove language parameter and use Ada language
8295         definition instead.
8296         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8297         parameter.
8298         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8299         parameter and use Ada language definition instead.
8300         (ada_val_print_1): Update all ada_val_print_xxx calls.
8301         Remove language parameter.
8302         (ada_val_print): Update ada_val_print_1 call.
8303
8304 2019-05-08  Tom Tromey  <tromey@adacore.com>
8305
8306         * remote.c (remote_hw_watchpoint_limit)
8307         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8308         Now static.
8309
8310 2019-05-08  Tom Tromey  <tromey@adacore.com>
8311
8312         * maint.c (_initialize_maint_cmds): Move initialization code to
8313         remote.c.
8314         (watchdog, show_watchdog): Move to remote.c.
8315         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8316         "watchdog" static.
8317         (_initialize_remote): Move initialization code from maint.c.
8318         * defs.h (watchdog): Don't declare.
8319
8320 2019-05-08  Tom Tromey  <tromey@adacore.com>
8321
8322         * tui/tui-interp.c: Include main.h.
8323         * interps.c: Include main.h.
8324         * main.h (interpreter_p): Declare.
8325         * defs.h (interpreter_p): Don't declare.
8326
8327 2019-05-08  Tom Tromey  <tromey@adacore.com>
8328
8329         * dwarf2loc.c: Include dwarf2read.h.
8330         * defs.h (read_unsigned_leb128): Don't declare.
8331         * dwarf2read.h (read_unsigned_leb128): Declare.
8332
8333 2019-05-08  Tom Tromey  <tromey@adacore.com>
8334
8335         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8336         method.
8337
8338 2019-05-08  Tom Tromey  <tromey@adacore.com>
8339
8340         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8341         when no wrap column is set.
8342
8343 2019-05-08  Tom Tromey  <tromey@adacore.com>
8344
8345         * c-lang.c (c_get_string): Handle non-C-style arrays.
8346
8347 2019-05-08  Tom Tromey  <tromey@adacore.com>
8348
8349         * typeprint.c (print_offset_data::update): Print the bit offset,
8350         not the number of bits remaining.
8351
8352 2019-05-08  Tom Tromey  <tromey@adacore.com>
8353
8354         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8355         padding at end of comment.
8356
8357 2019-05-08  Tom Tromey  <tromey@adacore.com>
8358
8359         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8360         Compare main types.
8361
8362 2019-05-06  Tom Tromey  <tom@tromey.com>
8363
8364         * common/scoped_mmap.c: Include common-defs.h.
8365         * common/scoped_mmap.h: Don't include config.h.
8366
8367 2019-05-04  Tom Tromey  <tom@tromey.com>
8368
8369         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8370         (struct aarch64_call_info): Add initializers.
8371         <si>: Now a std::vector.
8372         (pass_on_stack, aarch64_push_dummy_call): Update.
8373
8374 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8375             Tom Tromey  <tom@tromey.com>
8376
8377         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8378         (ppc_threads): Now a std::vector.  Now static.
8379         (hwdebug_find_thread_points_by_tid)
8380         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8381         Update.
8382
8383 2019-05-04  Tom Tromey  <tom@tromey.com>
8384
8385         * arc-tdep.c (arc_tdesc_init): Return bool.
8386
8387 2019-05-04  Tom Tromey  <tom@tromey.com>
8388
8389         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8390         Use gdb_assert_not_reached.
8391
8392 2019-05-04  Tom Tromey  <tom@tromey.com>
8393
8394         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8395         "false".
8396
8397 2019-05-04  Tom Tromey  <tom@tromey.com>
8398
8399         * arc-tdep.c (arc_tdesc_init): Use bool.
8400
8401 2019-05-04  Tom Tromey  <tom@tromey.com>
8402
8403         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8404
8405 2019-05-04  Tom Tromey  <tom@tromey.com>
8406
8407         * cli/cli-cmds.c (valid_command_p): Return bool.
8408
8409 2019-05-04  Tom Tromey  <tom@tromey.com>
8410
8411         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8412         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8413
8414 2019-05-04  Raul Tambre  <raul@tambre.ee>
8415
8416         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8417         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8418         operator for comparison.
8419
8420 2019-05-04  Tom Tromey  <tom@tromey.com>
8421
8422         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8423         (lookup_partial_symbol, print_partial_symbols)
8424         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8425         (psymbol_compare): Update.
8426         (add_psymbol_to_bcache): Clear the entire psymbol.
8427         (maintenance_check_psymtabs): Update.
8428         * psympriv.h (struct partial_symbol): Don't derive from
8429         general_symbol_info.
8430         <obj_section, unrelocated_address, address,
8431         set_unrelocated_address>: Update.
8432         <ginfo>: New member.
8433         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8434         (debug_names::write_psymbols): Update.
8435
8436 2019-05-04  Tom de Vries  <tdevries@suse.de>
8437
8438         * contrib/cc-with-tweaks.sh: Support -n arg.
8439
8440 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8441
8442         * corelow.c (core_target::detach): Ensure frame cache and
8443         register caches are cleared.
8444         inferior.c (exit_inferior_1): Likewise.
8445
8446 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8447             Tom Tromey  <tom@tromey.com>
8448
8449         * dictionary.c (collate_pending_symbols_by_language): Remove
8450         "struct" from foreach.
8451         * symtab.c (lookup_global_symbol_from_objfile)
8452         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8453         foreach.
8454         * ser-tcp.c (net_open): Remove "struct" from foreach.
8455         * objfiles.c (objfile_relocate, objfile_rebase)
8456         (objfile_has_symbols): Remove "struct" from foreach.
8457         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8458         from foreach.
8459         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8460         foreach.
8461         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8462         "struct" from foreach.
8463         * ada-lang.c (create_excep_cond_exprs)
8464         (ada_exception_catchpoint_cond_string): Remove "struct" from
8465         foreach.
8466
8467 2019-05-03  Tom Tromey  <tromey@adacore.com>
8468
8469         * ada-exp.y (convert_char_literal): Check suffix of each
8470         enumerator.
8471
8472 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8473
8474         PR ada/21406:
8475         * ada-exp.y (yywrap): Don't define.
8476         * ada-lex.l (%option): Add noyywrap
8477         (yywrap): Remove.
8478
8479 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8480
8481         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8482         _WIN32_WINNT to the XP level, unless already defined to a higher
8483         level.
8484
8485         * unittests/parse-connection-spec-selftests.c:
8486         * ser-tcp.c:
8487         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8488         override.
8489
8490         * symfile.c (find_separate_debug_file): Remove colon from the
8491         drive spec of DOS/Windows file names of the target, so that the
8492         file name produced from DEBUGDIR and the target's directory will
8493         be valid on DOS/Windows systems.
8494
8495 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8496
8497         * rust-lang.c (val_print_struct): Handle printing structures
8498         containing strings.
8499
8500 2019-05-02  Tom Tromey  <tromey@adacore.com>
8501
8502         * valarith.c (_initialize_valarith): Remove.
8503
8504 2019-05-01  Tom Tromey  <tromey@adacore.com>
8505
8506         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8507         bitfields.
8508
8509 2019-05-01  Tom Tromey  <tromey@adacore.com>
8510
8511         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8512         for big-endian copies.
8513
8514 2019-04-30  Ali Tamur  <tamur@google.com>
8515         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8516         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8517         (read_3_bytes): New function.
8518
8519 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8520
8521         * windows-nat.c (main_thread_id): Delete.
8522         (handle_output_debug_string): Replace main_thread_id by
8523         current_event.dwThreadId.
8524         (fake_create_process): Likewise.
8525         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8526         Do not set main_thread_id.
8527         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8528         current_event.dwThreadId.
8529         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8530
8531 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8532
8533         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8534         Use current_event.dwThreadId instead of main_thread_id.
8535
8536 2019-04-30  Tom Tromey  <tromey@adacore.com>
8537
8538         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8539         (create_excep_cond_exprs): Iterate over program spaces.
8540         (ada_exception_catchpoint_cond_string): Examine all minimal
8541         symbols for exception types.
8542
8543 2019-04-30  Tom Tromey  <tromey@adacore.com>
8544
8545         PR c++/24470:
8546         * dwarf2read.c (process_structure_scope): Handle case where type
8547         has template parameters but no symbol was created.
8548
8549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8550             Chris January  <chris.january@arm.com>
8551
8552         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8553         qualifier.
8554         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8555
8556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8557
8558         * f-typeprint.c (f_print_type): Update rules for printing
8559         whitespace.
8560         (f_type_print_varspec_suffix): Likewise.
8561
8562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8563             Chris January  <chris.january@arm.com>
8564
8565         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8566         function arguments.
8567
8568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8569
8570         * f-lang.c (build_fortran_types): Change name of void type to
8571         lower case.
8572         * f-typeprint.c (f_type_print_base): Print the name of the void
8573         type, rather than a fixed string.
8574         * f-valprint.c (f_decorations): Use lower case void string.
8575
8576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8577             Chris January  <chris.january@arm.com>
8578
8579         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8580         types for Fortran.
8581
8582 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8583             Chris January  <chris.january@arm.com>
8584             David Lecomber  <david.lecomber@arm.com>
8585
8586         * f-exp.y (BINOP_INTRINSIC): New token.
8587         (exp): New parser rule handling BINOP_INTRINSIC.
8588         (f77_keywords): Add new builtin procedures.
8589         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8590         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8591         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8592         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8593         (print_unop_subexp_f): New function.
8594         (print_binop_subexp_f): New function.
8595         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8596         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8597         (dump_subexp_body_f): Likewise.
8598         (operator_check_f): Likewise.
8599         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8600         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8601
8602 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8603
8604         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8605         UNOP_KIND.
8606         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8607         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8608         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8609         (operator_length_f): New fuction.
8610         (print_subexp_f): New function.
8611         (op_name_f): New function.
8612         (dump_subexp_body_f): New function.
8613         (operator_check_f): New function.
8614         (exp_descriptor_f): Replace standard expression handling functions
8615         with new functions.
8616         * gdb/fortran-operator.def: New file.
8617         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8618         * gdb/std-operator.def: Remove UNOP_KIND.
8619
8620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8621
8622         * std-operator.def: Remove unbalanced, stray double quote
8623         character.
8624
8625 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8626             Chris January  <chris.january@arm.com>
8627             Daniel Everett  <daniel.everett@arm.com>
8628             Nick Forrington  <nick.forrington@arm.com>
8629             Richard Bunt  <richard.bunt@arm.com>
8630
8631         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8632         of depth when printing anonymous structs or unions.
8633         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8634         Don't print either the top-level value, or the children if the
8635         max-depth is exceeded.
8636         (ppscm_print_children): When printing the key of a map, allow one
8637         extra level of depth.
8638         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8639         print either the top-level value, or the children if the max-depth
8640         is exceeded.
8641         (print_children): When printing the key of a map, allow one extra
8642         level of depth.
8643         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8644         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8645         (user_print_options): Initialise max_depth field.
8646         (val_print_scalar_or_string_type_p): New function.
8647         (val_print): Check to see if the max depth has been reached.
8648         (val_print_check_max_depth): Define new function.
8649         (show_print_max_depth): New function.
8650         (_initialize_valprint): Add 'print max-depth' option.
8651         * valprint.h (struct value_print_options) <max_depth>: New field.
8652         (val_print_check_max_depth): Declare new function.
8653         * NEWS: Document new feature.
8654
8655 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * ada-lang.c (ada_language_defn): Initialise new field.
8658         * c-lang.c (c_is_string_type_p): New function.
8659         (c_language_defn): Initialise new field.
8660         (cplus_language_defn): Initialise new field.
8661         (asm_language_defn): Initialise new field.
8662         (minimal_language_defn): Initialise new field.
8663         * c-lang.h (c_is_string_type_p): Declare new function.
8664         * d-lang.c (d_language_defn): Initialise new field.
8665         * f-lang.c (f_is_string_type_p): New function.
8666         (f_language_defn): Initialise new field.
8667         * go-lang.c (go_is_string_type_p): New function.
8668         (go_language_defn): Initialise new field.
8669         * language.c (default_is_string_type_p): New function.
8670         (unknown_language_defn): Initialise new field.
8671         (auto_language_defn): Initialise new field.
8672         * language.h (struct language_defn) <la_is_string_type_p>: New
8673         member variable.
8674         (default_is_string_type_p): Declare new function.
8675         * m2-lang.c (m2_language_defn): Initialise new field.
8676         * objc-lang.c (objc_language_defn): Initialise new field.
8677         * opencl-lang.c (opencl_language_defn): Initialise new field.
8678         * p-lang.c (pascal_is_string_type_p): New function.
8679         (pascal_language_defn): Initialise new field.
8680         * rust-lang.c (rust_is_string_type_p): New function.
8681         (rust_language_defn): Initialise new field.
8682
8683 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8684
8685         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8686         New field.
8687         * ada-lang.c (ada_language_defn): Initialise new field.
8688         * c-lang.c (c_language_defn): Likewise.
8689         (cplus_language_defn): Likewise.
8690         (asm_language_defn): Likewise.
8691         (minimal_language_defn): Likewise.
8692         * d-lang.c (d_language_defn): Likewise.
8693         * f-lang.c (f_language_defn): Likewise.
8694         * go-lang.c (go_language_defn): Likewise.
8695         * language.c (unknown_language_defn): Likewise.
8696         (auto_language_defn): Likewise.
8697         * m2-lang.c (m2_language_defn): Likewise.
8698         * objc-lang.c (objc_language_defn): Likewise.
8699         * opencl-lang.c (opencl_language_defn): Likewise.
8700         * p-lang.c (pascal_language_defn): Likewise.
8701         * rust-lang.c (rust_language_defn): Likewise.
8702
8703 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8704
8705         * ada-lang.c (ada_is_character_type): Change return type to bool.
8706         (ada_is_string_type): Likewise.
8707         * ada-lang.h (ada_is_character_type): Update declaration
8708         (ada_is_string_type): Likewise.
8709
8710 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8711
8712         Support style in 'frame|thread apply'
8713
8714         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8715         * record.c (record_start, record_stop): Update callers of
8716         execute_command_to_string with false.
8717         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8718         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8719         methods.
8720         (class string_file): New constructor with term_out parameter.
8721         Override methods term_out and can_emit_style_escape.  New member
8722         term_out.
8723         (class stdio_file): Override can_emit_style_escape.
8724         (class tee_file): Override term_out and can_emit_style_escape.
8725         * utils.h (can_emit_style_escape): Remove.
8726         * utils.c (can_emit_style_escape): Likewise.
8727         Update all callers of can_emit_style_escape (SOMESTREAM) to
8728         SOMESTREAM->can_emit_style_escape.
8729         * source-cache.c (source_cache::get_source_lines): Likewise.
8730         * stack.c (frame_apply_command_count): Call execute_command_to_string
8731         passing the term_out characteristic of the current gdb_stdout.
8732         * thread.c (thr_try_catch_cmd): Likewise.
8733         * top.c (execute_command_to_string): pass term_out parameter
8734         to construct the string_file for the command output.
8735         * ui-file.c (term_cli_styling): New function (most code moved
8736         from utils.c can_emit_style_escape).
8737         (string_file::string_file, string_file::can_emit_style_escape,
8738         stdio_file::can_emit_style_escape, tee_file::term_out,
8739         tee_file::can_emit_style_escape): New functions.
8740
8741 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8742
8743         * NEWS: Mention the new set|show may-call-functions.
8744         * infcall.c (may_call_functions_p): New variable.
8745         (show_may_call_functions_p): New function.
8746         (call_function_by_hand_dummy): Throws an error if not
8747         may-call-functions.
8748         (_initialize_infcall): Call add_setshow_boolean_cmd for
8749         may-call-functions.
8750
8751 2019-04-25  Keith Seitz  <keiths@redhat.com>
8752
8753         PR c++/24367
8754         * cp-support.c (inspect_type): Don't attempt substitutions
8755         of symbol with the same name.
8756
8757 2019-04-25  Tom Tromey  <tromey@adacore.com>
8758
8759         PR gdb/24475:
8760         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8761         static.
8762
8763 2019-04-25  Tom Tromey  <tromey@adacore.com>
8764
8765         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8766         rvalue reference.
8767         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8768         (gdb_xml_parser::parse): Use std::move.
8769         * python/python-internal.h (gdbpy_convert_exception): Take a const
8770         reference.
8771         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8772         std::move.
8773         * python/py-utils.c (gdbpy_convert_exception): Take a const
8774         reference.
8775         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8776         Use std::move.
8777         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8778         Use std::move.
8779         * mi/mi-main.c (mi_print_exception): Take a const reference.
8780         * main.c (handle_command_errors): Take a const reference.
8781         * linespec.c (parse_linespec): Use std::move.
8782         * infcall.c (run_inferior_call): Use std::move.
8783         (call_function_by_hand_dummy): Use std::move.
8784         * exec.c (try_open_exec_file): Use std::move.
8785         * exceptions.h (exception_print, exception_fprintf)
8786         (exception_print_same): Update.
8787         * exceptions.c (print_exception, exception_print)
8788         (exception_fprintf, exception_print_same): Change parameters to
8789         const reference.
8790         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8791         * common/new-op.c: Use std::move.
8792         * common/common-exceptions.h (struct gdb_exception): Add move
8793         constructor.
8794         (struct gdb_exception_error, struct gdb_exception_quit, struct
8795         gdb_quit_bad_alloc): Change constructor to move constructor.
8796         (throw_exception): Change parameter to rvalue reference.
8797         * common/common-exceptions.c (throw_exception): Take rvalue
8798         reference.
8799         * cli/cli-interp.c (safe_execute_command): Use std::move.
8800         * breakpoint.c (insert_bp_location, location_to_sals): Use
8801         std::move.
8802
8803 2019-04-25  Tom Tromey  <tromey@adacore.com>
8804
8805         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8806         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8807         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8808         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8809         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8810         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8811         guile/scm-value.c: Use unpack.
8812         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8813         gdbscm_gdb_exception.
8814         (gdbscm_throw_gdb_exception): Likewise.
8815         (struct gdbscm_gdb_exception): New.
8816         (unpack): New function.
8817         (gdbscm_wrap): Use unpack.
8818
8819 2019-04-25  Tom Tromey  <tromey@adacore.com>
8820
8821         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8822         (gdb_rl_callback_handler): Use std::move.
8823         * common/common-exceptions.h (struct gdb_exception): Add move
8824         assignment operator.
8825         (throw_exception_sjlj): Change "exception" to const reference.
8826         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8827         (throw_exception_sjlj): Change "exception" to const reference.
8828
8829 2019-04-25  Tom Tromey  <tromey@adacore.com>
8830
8831         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8832         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8833         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8834         Update.
8835         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8836         Update.
8837         * mi/mi-interp.c (mi_interp::exec): Update.
8838         * linespec.c (parse_linespec): Update.
8839         * infcall.c (run_inferior_call): Update.
8840         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8841         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8842         (gdbscm_lookup_global_symbol): Update.
8843         * guile/scm-param.c (gdbscm_parameter_value): Update.
8844         * guile/scm-frame.c (gdbscm_frame_read_register)
8845         (gdbscm_frame_read_var): Update.
8846         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8847         * exec.c (try_open_exec_file): Update.
8848         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8849         (gdb_rl_callback_handler): Update.
8850         * common/common-exceptions.h (exception_none): Don't declare.
8851         * common/common-exceptions.c (exception_none): Don't define.
8852         (struct catcher) <exception>: Update.
8853         * cli/cli-interp.c (safe_execute_command): Update.
8854         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8855
8856 2019-04-25  Ali Tamur  <tamur@google.com>
8857
8858         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8859         (read_attribute_value): Likewise.
8860         (dwarf2_read_addr_index): Update comment.
8861         (read_str_index): Add DW_FORM_strx.
8862         (dwarf2_string_attr): Likewise.
8863         (dwarf2_const_value_attr): Likewise.
8864         (dump_die_shallow): Likewise.
8865         (dwarf2_fetch_constant_bytes): Likewise.
8866         (skip_form_bytes): Likewise.
8867         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8868
8869 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8870
8871         PR corefiles/11608
8872         PR corefiles/18187
8873         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8874         OFFSET.  Verify if current mapping contains an ELF header.
8875         (linux_find_memory_regions_full): Adjust call to
8876         dump_mapping_p.
8877
8878 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8879             Kang Li <kanglictf@gmail.com>
8880
8881         PR gdb/21600
8882
8883         * dwarf2-frame.c (read_initial_length): Be consistent about using
8884         unsigned representation of length.
8885         (decode_frame_entry_1): Likewise.  Check for wraparound of
8886         end pointer as well as buffer overflow.
8887
8888 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8889
8890         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8891         "vq".
8892
8893 2019-04-24  Tom Tromey  <tromey@adacore.com>
8894
8895         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8896
8897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * s12z-tdep.c (s12z_unwind_pc): Delete.
8900         (s12z_unwind_sp): Delete.
8901         (s12z_gdbarch_init): Don't register deleted functions with
8902         gdbarch.
8903
8904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8905
8906         * rl78-tdep.c (rl78_unwind_sp): Delete.
8907         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8908
8909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8910
8911         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8912         (xstormy16_unwind_pc): Delete.
8913         (xstormy16_dummy_id): Delete.
8914         (xstormy16_gdbarch_init): Don't register deleted functions with
8915         gdbarch.
8916
8917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8918
8919         * vax-tdep.c (vax_unwind_pc): Delete.
8920         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8921
8922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * v850-tdep.c (v850_unwind_sp): Delete.
8925         (v850_unwind_pc): Delete.
8926         (v850_dummy_id): Delete.
8927         (v850_gdbarch_init): Don't register deleted functions with
8928         gdbarch.
8929
8930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8931
8932         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8933         (tilegx_unwind_pc): Delete.
8934         (tilegx_unwind_dummy_id): Delete.
8935         (tilegx_gdbarch_init): Don't register deleted functions with
8936         gdbarch.
8937
8938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8941         (tic6x_dummy_id): Delete.
8942         (tic6x_gdbarch_init): Don't register deleted functions with
8943         gdbarch.
8944
8945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * sparc-tdep.c (sparc_unwind_pc): Delete.
8948         (sparc32_gdbarch_init): Don't register deleted function with
8949         gdbarch.
8950
8951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * sh-tdep.c (sh_unwind_sp): Delete.
8954         (sh_unwind_pc): Delete.
8955         (sh_dummy_id): Delete.
8956         (sh_gdbarch_init): Don't register deleted functions with
8957         gdbarch.
8958
8959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8960
8961         * score-tdep.c (score_unwind_sp): Delete.
8962         (score_unwind_pc): Delete.
8963         (score_dummy_id): Delete.
8964         (score_gdbarch_init): Don't register deleted functions with
8965         gdbarch.
8966
8967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8968
8969         * rx-tdep.c (rx_unwind_pc): Delete.
8970         (rx_unwind_sp): Delete.
8971         (rx_dummy_id): Delete.
8972         (rx_gdbarch_init): Don't register deleted functions with
8973         gdbarch.  Update comment.
8974
8975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8978         (rs6000_dummy_id): Delete.
8979         (rs6000_gdbarch_init): Don't register deleted functions with
8980         gdbarch.
8981
8982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * or1k-tdep.c (or1k_dummy_id): Delete.
8985         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8986
8987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8988
8989         * nios2-tdep.c (nios2_dummy_id): Delete.
8990         (nios2_unwind_sp): Delete.
8991         (nios2_gdbarch_init): Don't register deleted functions with
8992         gdbarch.
8993
8994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8995
8996         * nds32-tdep.c (nds32_dummy_id): Delete.
8997         (nds32_unwind_pc): Delete.
8998         (nds32_unwind_sp): Delete.
8999         (nds32_gdbarch_init): Don't register deleted functions with
9000         gdbarch.
9001
9002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * msp430-tdep.c (msp430_unwind_pc): Delete.
9005         (msp430_unwind_sp): Delete.
9006         (msp430_dummy_id): Delete.
9007         (msp430_gdbarch_init): Don't register deleted functions with
9008         gdbarch.
9009
9010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9011
9012         * moxie-tdep.c (moxie_unwind_sp): Delete.
9013         (moxie_unwind_pc): Delete.
9014         (moxie_dummy_id): Delete.
9015         (moxie_gdbarch_init): Don't register deleted functions with
9016         gdbarch.
9017
9018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9019
9020         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9021         (mn10300_unwind_pc): Delete.
9022         (mn10300_unwind_sp): Delete.
9023         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9024         mn10300_unwind_sp.
9025         (mn10300_frame_unwind_init): Don't register deleted functions with
9026         gdbarch.
9027
9028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * mep-tdep.c (mep_unwind_pc): Delete.
9031         (mep_unwind_sp): Delete.
9032         (mep_dummy_id): Delete.
9033         (mep_gdbarch_init): Don't register deleted functions with
9034         gdbarch.
9035
9036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9039         (m68hc11_unwind_sp): Delete.
9040         (m68hc11_gdbarch_init): Don't register deleted functions with
9041         gdbarch.
9042
9043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9044
9045         * m32r-tdep.c (m32r_unwind_sp): Delete.
9046         (m32r_unwind_pc): Delete.
9047         (m32r_dummy_id): Delete.
9048         (m32r_gdbarch_init): Don't register deleted functions with
9049         gdbarch.
9050
9051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9052
9053         * m32c-tdep.c (m32c_unwind_pc): Delete.
9054         (m32c_unwind_sp): Delete.
9055         (m32c_dummy_id): Delete.
9056         (m32c_gdbarch_init): Don't register deleted functions with
9057         gdbarch.
9058
9059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9060
9061         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9062         (lm32_unwind_pc): Delete.
9063         (lm32_dummy_id): Delete.
9064         (lm32_gdbarch_init): Don't register deleted functions with
9065         gdbarch.
9066
9067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9070         (iq2000_unwind_pc): Delete.
9071         (iq2000_dummy_id): Delete.
9072         (iq2000_gdbarch_init): Don't register deleted functions with
9073         gdbarch.
9074
9075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9076
9077         * nds32-tdep.c (nds32_type_align): Delete.
9078         (nds32_push_dummy_call): Use type_align instead.
9079
9080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9081
9082         * arm-tdep.c (arm_type_align): Only handle vector override case.
9083         (arm_push_dummy_call): Use type_align.
9084         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9085
9086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9089         case.
9090         (pass_on_stack): Use type_align.
9091         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9092         function.
9093
9094 2019-04-23  Tom Tromey  <tromey@adacore.com>
9095
9096         * dwarf2read.c (line_header::file_name_at): Remove unused
9097         overload.
9098
9099 2019-04-23  Tom de Vries  <tdevries@suse.de>
9100
9101         PR gdb/24438
9102         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9103         invocation.
9104
9105
9106 2019-03-27  Ali Tamur  <tamur@google.com>
9107
9108         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9109         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9110         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9111         (dwarf_expr_context::get_addr_index): Likewise
9112         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9113         (symbol_needs_eval_context::get_addr_index): Likewise
9114         (disassemble_dwarf_expression): Add DW_OP_addrx
9115         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9116         (read_cutu_die_from_dwo): Update comment
9117         (skip_one_die): Add DW_FORM_addrx
9118         (read_attribute_value): Likewise
9119         (var_decode_location): Add DW_OP_addrx
9120         (dwarf2_const_value_attr): Add DW_FORM_addrx
9121         (dump_die_shallow): Likewise
9122         (dwarf2_fetch_constant_bytes): Likewise
9123         (decode_locdesc): Add DW_OP_addrx
9124         (skip_form_bytes): Add DW_FORM_addrx
9125
9126 2019-04-22  Ali Tamur  <tamur@google.com>
9127
9128         * MAINTAINERS (Write After Approval): Add self.
9129
9130 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9131
9132         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9133         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9134         (open_symbol_file_object): Likewise.
9135         (svr4_default_sos): Add info parameter.
9136         (svr4_read_so_list): Likewise.
9137         (svr4_current_sos_direct): Adjust functions calls to pass down
9138         info.
9139         (svr4_current_sos_1): Add info parameter.
9140         (svr4_current_sos): Call get_svr4_info, pass info down to
9141         svr4_current_sos_1.
9142         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9143         get_svr4_info.
9144         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9145         get_svr4_info.
9146         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9147         to get_svr4_info.
9148         (probes_table_remove_objfile_probes): Likewise.
9149         (register_solib_event_probe): Add info parameter.
9150         (solist_update_incremental): Pass info parameter down to
9151         svr4_read_so_list.
9152         (disable_probes_interface): Add info parameter.
9153         (svr4_handle_solib_event): Pass current_program_space to
9154         get_svr4_info.  Adjust disable_probes_interface cleanup.
9155         (svr4_create_probe_breakpoints): Add info parameter, pass it
9156         down to register_solib_event_probe.
9157         (svr4_create_solib_event_breakpoints): Add info parameter,
9158         pass it down to svr4_create_probe_breakpoints.
9159         (enable_break): Pass info down to
9160         svr4_create_solib_event_breakpoints.
9161         (svr4_solib_create_inferior_hook): Pass current_program_space to
9162         get_svr4_info.
9163         (svr4_clear_solib): Likewise.
9164
9165 2019-04-22  Pedro Alves  <palves@redhat.com>
9166
9167         * solib-svr4.c (svr4_free_objfile_observer): New.
9168         (probe_and_action::objfile): New field.
9169         (probes_table_htab_remove_objfile_probes)
9170         (probes_table_remove_objfile_probes): New functions.
9171         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9172         in the new probe_and_action.  Don't store the probe in 'lookup'.
9173         (svr4_create_probe_breakpoints): Pass objfile to
9174         register_solib_event_probe.
9175         (_initialize_svr4_solib): Register a free_objfile observer.
9176
9177 2019-04-19  Tom Tromey  <tom@tromey.com>
9178
9179         * common/queue.h: Remove.
9180
9181 2019-04-19  Tom Tromey  <tom@tromey.com>
9182
9183         * event-loop.c: Don't include "common/queue.h".
9184
9185 2019-04-19  Tom Tromey  <tom@tromey.com>
9186
9187         * remote.c (remote_target): Use delete.
9188         * remote-notif.h: Include <list>, not "common/queue.h".
9189         (notif_client_p): Remove typedef.
9190         (remote_notif_state): Add constructor, destructor, initializer.
9191         <notif_queue>: Now a std::list.
9192         (remote_notif_state_xfree): Don't declare.
9193         * remote-notif.c (remote_notif_process, handle_notification)
9194         (remote_notif_state_allocate): Update.
9195         (~remote_notif_state): Rename from remote_notif_state_xfree.
9196
9197 2019-04-19  Tom Tromey  <tom@tromey.com>
9198
9199         * symfile.c (reread_symbols): Update.
9200         * objfiles.c (objfile_register_static_link)
9201         (objfile_lookup_static_link): Update
9202         (~objfile) Don't delete static_links.
9203         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9204
9205 2019-04-19  Tom Tromey  <tom@tromey.com>
9206
9207         * type-stack.h (struct type_stack) <insert>: Constify string.
9208         * type-stack.c (type_stack::insert): Constify string.
9209         * gdbtypes.h (lookup_template_type): Update.
9210         (address_space_name_to_int): Update.
9211         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9212         const.
9213         (lookup_template_type): Make name const.
9214         * c-exp.y: Update rules.
9215         (lex_one_token, classify_name, classify_inner_name)
9216         (c_print_token): Update.
9217         * p-exp.y: Update rules.
9218         (yylex): Update.
9219         * f-exp.y: Update rules.
9220         (yylex): Update.
9221         * d-exp.y: Update rules.
9222         (lex_one_token, classify_name, classify_inner_name): Update.
9223         * parse.c (write_dollar_variable, copy_name): Return std::string.
9224         * parser-defs.h (copy_name): Change return type.
9225         * m2-exp.y: Update rules.
9226         (yylex): Update.
9227         * go-exp.y (lex_one_token): Update.
9228         Update rules.
9229         (classify_unsafe_function, classify_packaged_name)
9230         (classify_name, yylex): Update.
9231
9232 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9233
9234         * configure.ac: add --enable-source-highlight switch.
9235         * configure: Regenerate.
9236         * top.c (print_gdb_version): plumb --enable-source-highlight
9237         status to "show configuration".
9238
9239 2019-04-19  Tom Tromey  <tromey@adacore.com>
9240
9241         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9242         Check ADA_TYPE_P.
9243         (empty_record, ada_template_to_fixed_record_type_1)
9244         (template_to_static_fixed_type)
9245         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9246         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9247         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9248         macros.
9249
9250 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9251
9252         PR symtab/24423:
9253         * source.c (print_source_lines_base): Advance "iter" when a
9254         control character is seen.
9255
9256 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9257
9258         * inferior.h (struct infcall_suspend_state_deleter):
9259         Catch exception in destructor to avoid crash.
9260
9261 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9262
9263         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9264         close to the add_com "shell".
9265
9266 2019-04-18  Tom Tromey  <tromey@adacore.com>
9267
9268         * process-stratum-target.h (class process_stratum_target)
9269         <stratum>: Add "final".
9270
9271 2019-04-17  Tom Tromey  <tromey@adacore.com>
9272
9273         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9274         against nullptr before use.
9275
9276 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9277
9278         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9279
9280 2019-04-17  Jim Wilson  <jimw@sifive.com>
9281             Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9284         code read might fail, assume 4-byte breakpoint in that case.
9285
9286 2019-04-15  Leszek Swirski  <leszeks@google.com>
9287
9288         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9289         rather than a hand-rolled POD check when checking for forced MEMORY
9290         classification.
9291
9292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9293
9294         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9295         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9296         function.
9297         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9298         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9299         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9300         declaration.
9301
9302 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9303
9304         * aarch64-linux-nat.c
9305         (aarch64_linux_nat_target::thread_architecture): Add override.
9306         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9307         each VQ.
9308
9309 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9310
9311         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9312
9313 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9316         target types of size 96-bits, add some additional comments, and
9317         check that the builtin type we found was the correct size.
9318
9319 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9320
9321         * utils.c (prompt_for_continue): Don't restore the styling at the
9322         end, as applied_style has the wrong value.  This fixes styling in
9323         long lists of file names that are interrupted by the "Continue?"
9324         prompt.
9325
9326 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9329         * c-lang.c (c_language_defn): Likewise.
9330         (cplus_language_defn): Likewise.
9331         (asm_language_defn): Likewise.
9332         (minimal_language_defn): Likewise.
9333         * d-lang.c (d_language_defn): Likewise.
9334         * f-lang.c (f_language_defn): Likewise.
9335         * go-lang.c (go_language_defn): Likewise.
9336         * language.c (unknown_language_defn): Likewise.
9337         (auto_language_defn): Likewise.
9338         * language.h (struct language_defn): Remove la_magic field.
9339         (LANG_MAGIC): Delete.
9340         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9341         * objc-lang.c (objc_language_defn): Likewise.
9342         * opencl-lang.c (opencl_language_defn): Likewise.
9343         * p-lang.c (pascal_language_defn): Likewise.
9344         * rust-lang.c (rust_language_defn): Likewise.
9345
9346 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * riscv-tdep.c (riscv_type_align): New function.
9349         (riscv_type_alignment): Delete.
9350         (riscv_arg_location): Use 'type_align'.
9351         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9352
9353 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9354
9355         * gdbtypes.c (type_align): A struct with no non-static fields also
9356         has alignment of 1.
9357
9358 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9359
9360         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9361         component to 0.
9362         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9363         member.
9364         (riscv_struct_info::analyse): New implementation using new
9365         analyse_inner member function.
9366         (riscv_struct_info::field_offset): New member function.
9367         (riscv_struct_info::m_offsets): New member variable.
9368         (riscv_struct_info::analyse_inner): New private member function,
9369         takes the old implementation of riscv_struct_info::analyse but
9370         extended to track field offsets.
9371         (riscv_call_arg_struct): Update the struct folding special cases
9372         to handle cases where empty C++ structs, which are non-zero
9373         length, are found.
9374         (riscv_arg_location): Initialise the length of each location, a
9375         non-zero length now indicates the location is in use.
9376         (riscv_push_dummy_call): Allow for the first location having a
9377         non-zero offset when setting up arguments.
9378         (riscv_return_value): Likewise, but for return values.
9379
9380 2019-04-11  Tom Tromey  <tromey@adacore.com>
9381
9382         * utils.c (internal_vproblem): Make "msg" const.
9383
9384 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9385
9386         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9387         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9388         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9389         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9390
9391 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9392
9393         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9394         function.
9395         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9396         of amd64_collect_native_gregset.
9397         (amd64_linux_nat_target::store_registers): Likewise.
9398
9399 2019-04-10  Tom Tromey  <tom@tromey.com>
9400
9401         * symtab.c (lookup_global_symbol_from_objfile)
9402         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9403         * objfiles.h (class separate_debug_iterator): New.
9404         (class separate_debug_range): New.
9405         (struct objfile) <separate_debug_objfiles>: New method.
9406         (objfile_separate_debug_iterate): Don't declare.
9407         * objfiles.c (separate_debug_iterator::operator++): Rename from
9408         objfile_separate_debug_iterate.
9409         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9410         iterator.
9411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9412         iterator.
9413
9414 2019-04-10  Tom Tromey  <tom@tromey.com>
9415
9416         * symfile.c (reread_symbols): Remove old comment.
9417         * objfiles.c (free_all_objfiles): Fix a typo.
9418
9419 2019-04-10  Tom Tromey  <tom@tromey.com>
9420
9421         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9422         * minsyms.c (lookup_minimal_symbol): Use foreach.
9423         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9424         (lookup_minimal_symbol_solib_trampoline): Likewise.
9425         * symfile.c (reread_symbols): Use foreach.
9426
9427 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9428             Tom Tromey  <tromey@adacore.com>
9429
9430         PR rust/24414:
9431         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9432         (rust_lex_int_test): Change "value" to be LONGEST.
9433         (rust_lex_tests): Add test for long integer literal.
9434
9435 2019-04-09  Tom Tromey  <tromey@adacore.com>
9436
9437         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9438         to bool.
9439         (extended_remote_target::attach): Update.
9440         (remote_target::remote_notice_new_inferior): Update.
9441         (remote_target::add_current_inferior_and_thread): Update.
9442         * inferior.c (exit_inferior_1): Use "false".
9443         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9444
9445 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9446
9447         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9448         the "start" command.
9449
9450 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9451
9452         * python/py-inferior.c (infpy_thread_from_thread_handle):
9453         Adjust comments to reflect renaming of thread_from_thread_handle
9454         to thread_from_handle.  Adjust keywords.  Fix type error message.
9455         (inferior_object_methods): Add thread_from_handle.  Retain
9456         thread_from_thread_handle, but mark it as deprecated.
9457
9458 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9459
9460         * gdbthread.h (find_thread_by_handle): Revise declaration.
9461         * thread.c (find_thread_by_handle): Likewise.  Adjust
9462         implementation too.
9463         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9464         support for buffer objects as handles.
9465
9466 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9467
9468         * python/py-infthread.c (thpy_thread_handle): New function.
9469         (thread_object_methods): Register thpy_thread_handle.
9470
9471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9472
9473         * gdbthread.h (thread_to_thread_handle): Declare.
9474         * thread.c (gdbtypes.h): Include.
9475         (thread_to_thread_handle): New function.
9476
9477         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9478         (target_thread_info_to_thread_handle): Declare.
9479         * target.c (target_thread_info_to_thread_handle): New function.
9480         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9481         * target-delegates.c: Regenerate.
9482
9483         * linux-thread-db.c (class thread_db_target): Add method
9484         thread_info_to_thread_handle.
9485         (thread_db_target::thread_info_to_thread_handle): Define.
9486         * remote.c (class remote_target): Add new method
9487         thread_info_to_thread_handle.
9488         (remote_target::thread_info_to_thread_handle): Define.
9489
9490 2019-04-08  Pedro Alves  <palves@redhat.com>
9491
9492         * common/common-exceptions.c (throw_exception): Don't create
9493         named object to throw; throw directly.
9494         (throw_it): Likewise.  Don't initialize gdb_exception::message
9495         here, with new; pass FMT and AP to the ctor instead.
9496         * common/common-exceptions.h: Include <string>.
9497         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9498         const char *, va_list)): New ctor.  Use std::make_shared.
9499         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9500         errors)): Delete.
9501         (gdb_exception_error::gdb_exception_error(enum errors, const char
9502         *, va_list)): New.
9503         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9504         Add assertion.
9505         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9506         errors)): Delete.
9507         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9508         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9509         Add assertion.
9510
9511 2019-04-08  Tom Tromey  <tom@tromey.com>
9512
9513         * valops.c (value_rtti_indirect_type): Replace throw_exception
9514         with throw.
9515         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9516         with throw.
9517         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9518         throw.
9519         * target.c (target_translate_tls_address): Replace throw_exception
9520         with throw.
9521         * stack.c (frame_apply_command_count): Replace throw_exception
9522         with throw.
9523         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9524         throw.
9525         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9526         with throw.
9527         * rs6000-tdep.c (rs6000_frame_cache)
9528         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9529         * remote.c: Replace throw_exception with throw.
9530         * record-full.c (record_full_message, record_full_wait_1)
9531         (record_full_restore): Replace throw_exception with throw.
9532         * record-btrace.c:
9533         (get_thread_current_frame_id, record_btrace_start_replaying)
9534         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9535         (cmd_record_btrace_start): Replace throw_exception with throw.
9536         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9537         throw.
9538         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9539         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9540         * linespec.c:
9541         (find_linespec_symbols): Replace throw_exception with throw.
9542         * infrun.c (displaced_step_prepare, resume): Replace
9543         throw_exception with throw.
9544         * infcmd.c (post_create_inferior): Replace throw_exception with
9545         throw.
9546         * inf-loop.c (inferior_event_handler): Replace throw_exception
9547         with throw.
9548         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9549         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9550         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9551         (get_prev_frame_always, get_frame_pc_if_available)
9552         (get_frame_address_in_block_if_available, get_frame_language):
9553         Replace throw_exception with throw.
9554         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9555         throw_exception with throw.
9556         * eval.c (fetch_subexp_value, evaluate_var_value)
9557         (evaluate_funcall, evaluate_subexp_standard): Replace
9558         throw_exception with throw.
9559         * dwarf2loc.c (call_site_find_chain)
9560         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9561         Replace throw_exception with throw.
9562         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9563         with throw.
9564         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9565         throw.
9566         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9567         * completer.c (complete_line_internal): Replace throw_exception
9568         with throw.
9569         * compile/compile-object-run.c (compile_object_run): Replace
9570         throw_exception with throw.
9571         * cli/cli-script.c (process_next_line): Replace throw_exception
9572         with throw.
9573         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9574         (btrace_enable, btrace_maint_update_pt_packets): Replace
9575         throw_exception with throw.
9576         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9577         throw_exception with throw.
9578         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9579         throw_exception with throw.
9580         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9581         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9582         * aarch64-tdep.c (aarch64_make_prologue_cache)
9583         (aarch64_make_stub_cache): Replace throw_exception with throw.
9584
9585 2019-04-08  Tom Tromey  <tom@tromey.com>
9586
9587         * common/common-exceptions.c (throw_exception): Rename from
9588         throw_exception_cxx.  Remove old copy.  Make argument const.
9589         (throw_it): Create and throw exception objects directly.
9590         * common/common-exceptions.h (throw_exception): Make argument
9591         const.
9592         (struct gdb_exception_error): Add constructor.
9593         (struct gdb_exception_quit): Add constructor.
9594
9595 2019-04-08  Tom Tromey  <tom@tromey.com>
9596
9597         * common/common-exceptions.h (exception_rethrow): Don't declare.
9598         (TRY_SJLJ): Update comment.
9599         (TRY, CATCH, END_CATCH): Remove.
9600         * common/common-exceptions.c (exception_rethrow): Remove.
9601
9602 2019-04-08  Tom Tromey  <tom@tromey.com>
9603
9604         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9605         Remove.
9606         (gdb_exception_error): Rename from
9607         gdb_exception_RETURN_MASK_ERROR.
9608         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9609         (gdb_quit_bad_alloc): Update.
9610         * aarch64-tdep.c: Update.
9611         * ada-lang.c: Update.
9612         * ada-typeprint.c: Update.
9613         * ada-valprint.c: Update.
9614         * amd64-tdep.c: Update.
9615         * arch-utils.c: Update.
9616         * break-catch-throw.c: Update.
9617         * breakpoint.c: Update.
9618         * btrace.c: Update.
9619         * c-varobj.c: Update.
9620         * cli/cli-cmds.c: Update.
9621         * cli/cli-interp.c: Update.
9622         * cli/cli-script.c: Update.
9623         * common/common-exceptions.c: Update.
9624         * common/new-op.c: Update.
9625         * common/selftest.c: Update.
9626         * compile/compile-c-symbols.c: Update.
9627         * compile/compile-cplus-symbols.c: Update.
9628         * compile/compile-object-load.c: Update.
9629         * compile/compile-object-run.c: Update.
9630         * completer.c: Update.
9631         * corelow.c: Update.
9632         * cp-abi.c: Update.
9633         * cp-support.c: Update.
9634         * cp-valprint.c: Update.
9635         * darwin-nat.c: Update.
9636         * disasm-selftests.c: Update.
9637         * dtrace-probe.c: Update.
9638         * dwarf-index-cache.c: Update.
9639         * dwarf-index-write.c: Update.
9640         * dwarf2-frame-tailcall.c: Update.
9641         * dwarf2-frame.c: Update.
9642         * dwarf2loc.c: Update.
9643         * dwarf2read.c: Update.
9644         * eval.c: Update.
9645         * event-loop.c: Update.
9646         * event-top.c: Update.
9647         * exec.c: Update.
9648         * f-valprint.c: Update.
9649         * fbsd-tdep.c: Update.
9650         * frame-unwind.c: Update.
9651         * frame.c: Update.
9652         * gdbtypes.c: Update.
9653         * gnu-v3-abi.c: Update.
9654         * guile/guile-internal.h: Update.
9655         * guile/scm-block.c: Update.
9656         * guile/scm-breakpoint.c: Update.
9657         * guile/scm-cmd.c: Update.
9658         * guile/scm-disasm.c: Update.
9659         * guile/scm-frame.c: Update.
9660         * guile/scm-lazy-string.c: Update.
9661         * guile/scm-math.c: Update.
9662         * guile/scm-param.c: Update.
9663         * guile/scm-ports.c: Update.
9664         * guile/scm-pretty-print.c: Update.
9665         * guile/scm-symbol.c: Update.
9666         * guile/scm-symtab.c: Update.
9667         * guile/scm-type.c: Update.
9668         * guile/scm-value.c: Update.
9669         * i386-linux-tdep.c: Update.
9670         * i386-tdep.c: Update.
9671         * inf-loop.c: Update.
9672         * infcall.c: Update.
9673         * infcmd.c: Update.
9674         * infrun.c: Update.
9675         * jit.c: Update.
9676         * language.c: Update.
9677         * linespec.c: Update.
9678         * linux-fork.c: Update.
9679         * linux-nat.c: Update.
9680         * linux-tdep.c: Update.
9681         * linux-thread-db.c: Update.
9682         * main.c: Update.
9683         * mi/mi-cmd-break.c: Update.
9684         * mi/mi-cmd-stack.c: Update.
9685         * mi/mi-interp.c: Update.
9686         * mi/mi-main.c: Update.
9687         * objc-lang.c: Update.
9688         * p-valprint.c: Update.
9689         * parse.c: Update.
9690         * ppc-linux-tdep.c: Update.
9691         * printcmd.c: Update.
9692         * python/py-arch.c: Update.
9693         * python/py-breakpoint.c: Update.
9694         * python/py-cmd.c: Update.
9695         * python/py-finishbreakpoint.c: Update.
9696         * python/py-frame.c: Update.
9697         * python/py-framefilter.c: Update.
9698         * python/py-gdb-readline.c: Update.
9699         * python/py-inferior.c: Update.
9700         * python/py-infthread.c: Update.
9701         * python/py-lazy-string.c: Update.
9702         * python/py-linetable.c: Update.
9703         * python/py-objfile.c: Update.
9704         * python/py-param.c: Update.
9705         * python/py-prettyprint.c: Update.
9706         * python/py-progspace.c: Update.
9707         * python/py-record-btrace.c: Update.
9708         * python/py-record.c: Update.
9709         * python/py-symbol.c: Update.
9710         * python/py-type.c: Update.
9711         * python/py-unwind.c: Update.
9712         * python/py-utils.c: Update.
9713         * python/py-value.c: Update.
9714         * python/python.c: Update.
9715         * record-btrace.c: Update.
9716         * record-full.c: Update.
9717         * remote-fileio.c: Update.
9718         * remote.c: Update.
9719         * riscv-tdep.c: Update.
9720         * rs6000-aix-tdep.c: Update.
9721         * rs6000-tdep.c: Update.
9722         * rust-exp.y: Update.
9723         * rust-lang.c: Update.
9724         * s390-tdep.c: Update.
9725         * selftest-arch.c: Update.
9726         * solib-dsbt.c: Update.
9727         * solib-frv.c: Update.
9728         * solib-spu.c: Update.
9729         * solib-svr4.c: Update.
9730         * solib.c: Update.
9731         * sparc64-linux-tdep.c: Update.
9732         * stack.c: Update.
9733         * symfile-mem.c: Update.
9734         * symmisc.c: Update.
9735         * target.c: Update.
9736         * thread.c: Update.
9737         * top.c: Update.
9738         * tracefile-tfile.c: Update.
9739         * tui/tui.c: Update.
9740         * typeprint.c: Update.
9741         * unittests/cli-utils-selftests.c: Update.
9742         * unittests/parse-connection-spec-selftests.c: Update.
9743         * valops.c: Update.
9744         * valprint.c: Update.
9745         * value.c: Update.
9746         * varobj.c: Update.
9747         * windows-nat.c: Update.
9748         * x86-linux-nat.c: Update.
9749         * xml-support.c: Update.
9750
9751 2019-04-08  Tom Tromey  <tom@tromey.com>
9752
9753         * xml-support.c: Use C++ exception handling.
9754         * x86-linux-nat.c: Use C++ exception handling.
9755         * windows-nat.c: Use C++ exception handling.
9756         * varobj.c: Use C++ exception handling.
9757         * value.c: Use C++ exception handling.
9758         * valprint.c: Use C++ exception handling.
9759         * valops.c: Use C++ exception handling.
9760         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9761         handling.
9762         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9763         * typeprint.c: Use C++ exception handling.
9764         * tui/tui.c: Use C++ exception handling.
9765         * tracefile-tfile.c: Use C++ exception handling.
9766         * top.c: Use C++ exception handling.
9767         * thread.c: Use C++ exception handling.
9768         * target.c: Use C++ exception handling.
9769         * symmisc.c: Use C++ exception handling.
9770         * symfile-mem.c: Use C++ exception handling.
9771         * stack.c: Use C++ exception handling.
9772         * sparc64-linux-tdep.c: Use C++ exception handling.
9773         * solib.c: Use C++ exception handling.
9774         * solib-svr4.c: Use C++ exception handling.
9775         * solib-spu.c: Use C++ exception handling.
9776         * solib-frv.c: Use C++ exception handling.
9777         * solib-dsbt.c: Use C++ exception handling.
9778         * selftest-arch.c: Use C++ exception handling.
9779         * s390-tdep.c: Use C++ exception handling.
9780         * rust-lang.c: Use C++ exception handling.
9781         * rust-exp.y: Use C++ exception handling.
9782         * rs6000-tdep.c: Use C++ exception handling.
9783         * rs6000-aix-tdep.c: Use C++ exception handling.
9784         * riscv-tdep.c: Use C++ exception handling.
9785         * remote.c: Use C++ exception handling.
9786         * remote-fileio.c: Use C++ exception handling.
9787         * record-full.c: Use C++ exception handling.
9788         * record-btrace.c: Use C++ exception handling.
9789         * python/python.c: Use C++ exception handling.
9790         * python/py-value.c: Use C++ exception handling.
9791         * python/py-utils.c: Use C++ exception handling.
9792         * python/py-unwind.c: Use C++ exception handling.
9793         * python/py-type.c: Use C++ exception handling.
9794         * python/py-symbol.c: Use C++ exception handling.
9795         * python/py-record.c: Use C++ exception handling.
9796         * python/py-record-btrace.c: Use C++ exception handling.
9797         * python/py-progspace.c: Use C++ exception handling.
9798         * python/py-prettyprint.c: Use C++ exception handling.
9799         * python/py-param.c: Use C++ exception handling.
9800         * python/py-objfile.c: Use C++ exception handling.
9801         * python/py-linetable.c: Use C++ exception handling.
9802         * python/py-lazy-string.c: Use C++ exception handling.
9803         * python/py-infthread.c: Use C++ exception handling.
9804         * python/py-inferior.c: Use C++ exception handling.
9805         * python/py-gdb-readline.c: Use C++ exception handling.
9806         * python/py-framefilter.c: Use C++ exception handling.
9807         * python/py-frame.c: Use C++ exception handling.
9808         * python/py-finishbreakpoint.c: Use C++ exception handling.
9809         * python/py-cmd.c: Use C++ exception handling.
9810         * python/py-breakpoint.c: Use C++ exception handling.
9811         * python/py-arch.c: Use C++ exception handling.
9812         * printcmd.c: Use C++ exception handling.
9813         * ppc-linux-tdep.c: Use C++ exception handling.
9814         * parse.c: Use C++ exception handling.
9815         * p-valprint.c: Use C++ exception handling.
9816         * objc-lang.c: Use C++ exception handling.
9817         * mi/mi-main.c: Use C++ exception handling.
9818         * mi/mi-interp.c: Use C++ exception handling.
9819         * mi/mi-cmd-stack.c: Use C++ exception handling.
9820         * mi/mi-cmd-break.c: Use C++ exception handling.
9821         * main.c: Use C++ exception handling.
9822         * linux-thread-db.c: Use C++ exception handling.
9823         * linux-tdep.c: Use C++ exception handling.
9824         * linux-nat.c: Use C++ exception handling.
9825         * linux-fork.c: Use C++ exception handling.
9826         * linespec.c: Use C++ exception handling.
9827         * language.c: Use C++ exception handling.
9828         * jit.c: Use C++ exception handling.
9829         * infrun.c: Use C++ exception handling.
9830         * infcmd.c: Use C++ exception handling.
9831         * infcall.c: Use C++ exception handling.
9832         * inf-loop.c: Use C++ exception handling.
9833         * i386-tdep.c: Use C++ exception handling.
9834         * i386-linux-tdep.c: Use C++ exception handling.
9835         * guile/scm-value.c: Use C++ exception handling.
9836         * guile/scm-type.c: Use C++ exception handling.
9837         * guile/scm-symtab.c: Use C++ exception handling.
9838         * guile/scm-symbol.c: Use C++ exception handling.
9839         * guile/scm-pretty-print.c: Use C++ exception handling.
9840         * guile/scm-ports.c: Use C++ exception handling.
9841         * guile/scm-param.c: Use C++ exception handling.
9842         * guile/scm-math.c: Use C++ exception handling.
9843         * guile/scm-lazy-string.c: Use C++ exception handling.
9844         * guile/scm-frame.c: Use C++ exception handling.
9845         * guile/scm-disasm.c: Use C++ exception handling.
9846         * guile/scm-cmd.c: Use C++ exception handling.
9847         * guile/scm-breakpoint.c: Use C++ exception handling.
9848         * guile/scm-block.c: Use C++ exception handling.
9849         * guile/guile-internal.h: Use C++ exception handling.
9850         * gnu-v3-abi.c: Use C++ exception handling.
9851         * gdbtypes.c: Use C++ exception handling.
9852         * frame.c: Use C++ exception handling.
9853         * frame-unwind.c: Use C++ exception handling.
9854         * fbsd-tdep.c: Use C++ exception handling.
9855         * f-valprint.c: Use C++ exception handling.
9856         * exec.c: Use C++ exception handling.
9857         * event-top.c: Use C++ exception handling.
9858         * event-loop.c: Use C++ exception handling.
9859         * eval.c: Use C++ exception handling.
9860         * dwarf2read.c: Use C++ exception handling.
9861         * dwarf2loc.c: Use C++ exception handling.
9862         * dwarf2-frame.c: Use C++ exception handling.
9863         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9864         * dwarf-index-write.c: Use C++ exception handling.
9865         * dwarf-index-cache.c: Use C++ exception handling.
9866         * dtrace-probe.c: Use C++ exception handling.
9867         * disasm-selftests.c: Use C++ exception handling.
9868         * darwin-nat.c: Use C++ exception handling.
9869         * cp-valprint.c: Use C++ exception handling.
9870         * cp-support.c: Use C++ exception handling.
9871         * cp-abi.c: Use C++ exception handling.
9872         * corelow.c: Use C++ exception handling.
9873         * completer.c: Use C++ exception handling.
9874         * compile/compile-object-run.c: Use C++ exception handling.
9875         * compile/compile-object-load.c: Use C++ exception handling.
9876         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9877         * compile/compile-c-symbols.c: Use C++ exception handling.
9878         * common/selftest.c: Use C++ exception handling.
9879         * common/new-op.c: Use C++ exception handling.
9880         * cli/cli-script.c: Use C++ exception handling.
9881         * cli/cli-interp.c: Use C++ exception handling.
9882         * cli/cli-cmds.c: Use C++ exception handling.
9883         * c-varobj.c: Use C++ exception handling.
9884         * btrace.c: Use C++ exception handling.
9885         * breakpoint.c: Use C++ exception handling.
9886         * break-catch-throw.c: Use C++ exception handling.
9887         * arch-utils.c: Use C++ exception handling.
9888         * amd64-tdep.c: Use C++ exception handling.
9889         * ada-valprint.c: Use C++ exception handling.
9890         * ada-typeprint.c: Use C++ exception handling.
9891         * ada-lang.c: Use C++ exception handling.
9892         * aarch64-tdep.c: Use C++ exception handling.
9893
9894 2019-04-08  Tom Tromey  <tom@tromey.com>
9895
9896         * xml-support.c (gdb_xml_parser::parse): Update.
9897         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9898         * value.c (show_convenience): Update.
9899         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9900         (test_parse_flags_qcs): Update.
9901         * thread.c (thr_try_catch_cmd): Update.
9902         * target.c (target_translate_tls_address): Update.
9903         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9904         (info_frame_command_core, frame_apply_command_count): Update.
9905         * rust-exp.y (rust_lex_exception_test): Update.
9906         * riscv-tdep.c (riscv_print_one_register_info): Update.
9907         * remote.c (remote_target::enable_btrace): Update.
9908         * record-btrace.c (record_btrace_enable_warn): Update.
9909         * python/py-utils.c (gdbpy_convert_exception): Update.
9910         * printcmd.c (do_one_display, print_variable_and_value): Update.
9911         * mi/mi-main.c (mi_print_exception): Update.
9912         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9913         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9914         * linux-nat.c (linux_nat_target::attach): Update.
9915         * linux-fork.c (class scoped_switch_fork_info): Update.
9916         * infrun.c (displaced_step_prepare): Update.
9917         * infcall.c (call_function_by_hand_dummy): Update.
9918         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9919         * gnu-v3-abi.c (print_one_vtable): Update.
9920         * frame.c (get_prev_frame_always): Update.
9921         * f-valprint.c (info_common_command_for_block): Update.
9922         * exec.c (try_open_exec_file): Update.
9923         * exceptions.c (print_exception, exception_print)
9924         (exception_fprintf, exception_print_same): Update.
9925         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9926         * dwarf-index-cache.c (index_cache::store)
9927         (index_cache::lookup_gdb_index): Update.
9928         * darwin-nat.c (maybe_cache_shell): Update.
9929         * cp-valprint.c (cp_print_value_fields): Update.
9930         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9931         (gcc_cplus_symbol_address): Update.
9932         * compile/compile-c-symbols.c (gcc_convert_symbol)
9933         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9934         * common/selftest.c: Update.
9935         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9936         a std::string.
9937         (exception_try_scope_entry, exception_try_scope_exit): Don't
9938         declare.
9939         (struct exception_try_scope): Remove.
9940         (TRY): Don't use exception_try_scope.
9941         (struct gdb_exception): Add constructor, operator=.
9942         <what>: New method.
9943         (struct gdb_exception_RETURN_MASK_ALL)
9944         (struct gdb_exception_RETURN_MASK_ERROR)
9945         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9946         (struct gdb_quit_bad_alloc): Update.
9947         * common/common-exceptions.c (exception_none): Change
9948         initializer.
9949         (struct catcher) <state, exception>: Initialize inline.
9950         <prev>: Remove member.
9951         (current_catcher): Remove.
9952         (catchers): New global.
9953         (exceptions_state_mc_init): Simplify.
9954         (catcher_pop): Remove.
9955         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9956         (try_scope_depth, exception_try_scope_entry)
9957         (exception_try_scope_exit): Remove.
9958         (throw_exception_sjlj): Update.
9959         (exception_messages, exception_messages_size): Remove.
9960         (throw_it): Simplify.
9961         (gdb_exception_sliced_copy): Remove.
9962         (throw_exception_cxx): Update.
9963         * cli/cli-script.c (script_from_file): Update.
9964         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9965         Update.
9966         * ada-valprint.c (ada_val_print): Update.
9967         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9968         (create_excep_cond_exprs): Update.
9969
9970 2019-04-08  Tom Tromey  <tom@tromey.com>
9971
9972         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9973         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9974         (TRY, CATCH, END_CATCH): Remove some definitions.
9975         * common/common-exceptions.c: Don't use GDB_XCPT.
9976         (catcher_list_size): Remove.
9977         (throw_exception, throw_it): Simplify.
9978
9979 2019-04-05  Tom Tromey  <tom@tromey.com>
9980
9981         Revert the header-sorting patch.
9982         * ft32-tdep.c: Revert.
9983         * frv-tdep.c: Revert.
9984         * frv-linux-tdep.c: Revert.
9985         * frame.c: Revert.
9986         * frame-unwind.c: Revert.
9987         * frame-base.c: Revert.
9988         * fork-child.c: Revert.
9989         * findvar.c: Revert.
9990         * findcmd.c: Revert.
9991         * filesystem.c: Revert.
9992         * filename-seen-cache.h: Revert.
9993         * filename-seen-cache.c: Revert.
9994         * fbsd-tdep.c: Revert.
9995         * fbsd-nat.h: Revert.
9996         * fbsd-nat.c: Revert.
9997         * f-valprint.c: Revert.
9998         * f-typeprint.c: Revert.
9999         * f-lang.c: Revert.
10000         * extension.h: Revert.
10001         * extension.c: Revert.
10002         * extension-priv.h: Revert.
10003         * expprint.c: Revert.
10004         * exec.h: Revert.
10005         * exec.c: Revert.
10006         * exceptions.c: Revert.
10007         * event-top.c: Revert.
10008         * event-loop.c: Revert.
10009         * eval.c: Revert.
10010         * elfread.c: Revert.
10011         * dwarf2read.h: Revert.
10012         * dwarf2read.c: Revert.
10013         * dwarf2loc.c: Revert.
10014         * dwarf2expr.h: Revert.
10015         * dwarf2expr.c: Revert.
10016         * dwarf2-frame.c: Revert.
10017         * dwarf2-frame-tailcall.c: Revert.
10018         * dwarf-index-write.h: Revert.
10019         * dwarf-index-write.c: Revert.
10020         * dwarf-index-common.c: Revert.
10021         * dwarf-index-cache.h: Revert.
10022         * dwarf-index-cache.c: Revert.
10023         * dummy-frame.c: Revert.
10024         * dtrace-probe.c: Revert.
10025         * disasm.h: Revert.
10026         * disasm.c: Revert.
10027         * disasm-selftests.c: Revert.
10028         * dictionary.c: Revert.
10029         * dicos-tdep.c: Revert.
10030         * demangle.c: Revert.
10031         * dcache.h: Revert.
10032         * dcache.c: Revert.
10033         * darwin-nat.h: Revert.
10034         * darwin-nat.c: Revert.
10035         * darwin-nat-info.c: Revert.
10036         * d-valprint.c: Revert.
10037         * d-namespace.c: Revert.
10038         * d-lang.c: Revert.
10039         * ctf.c: Revert.
10040         * csky-tdep.c: Revert.
10041         * csky-linux-tdep.c: Revert.
10042         * cris-tdep.c: Revert.
10043         * cris-linux-tdep.c: Revert.
10044         * cp-valprint.c: Revert.
10045         * cp-support.c: Revert.
10046         * cp-namespace.c: Revert.
10047         * cp-abi.c: Revert.
10048         * corelow.c: Revert.
10049         * corefile.c: Revert.
10050         * continuations.c: Revert.
10051         * completer.h: Revert.
10052         * completer.c: Revert.
10053         * complaints.c: Revert.
10054         * coffread.c: Revert.
10055         * coff-pe-read.c: Revert.
10056         * cli-out.h: Revert.
10057         * cli-out.c: Revert.
10058         * charset.c: Revert.
10059         * c-varobj.c: Revert.
10060         * c-valprint.c: Revert.
10061         * c-typeprint.c: Revert.
10062         * c-lang.c: Revert.
10063         * buildsym.c: Revert.
10064         * buildsym-legacy.c: Revert.
10065         * build-id.h: Revert.
10066         * build-id.c: Revert.
10067         * btrace.c: Revert.
10068         * bsd-uthread.c: Revert.
10069         * breakpoint.h: Revert.
10070         * breakpoint.c: Revert.
10071         * break-catch-throw.c: Revert.
10072         * break-catch-syscall.c: Revert.
10073         * break-catch-sig.c: Revert.
10074         * blockframe.c: Revert.
10075         * block.c: Revert.
10076         * bfin-tdep.c: Revert.
10077         * bfin-linux-tdep.c: Revert.
10078         * bfd-target.c: Revert.
10079         * bcache.c: Revert.
10080         * ax-general.c: Revert.
10081         * ax-gdb.h: Revert.
10082         * ax-gdb.c: Revert.
10083         * avr-tdep.c: Revert.
10084         * auxv.c: Revert.
10085         * auto-load.c: Revert.
10086         * arm-wince-tdep.c: Revert.
10087         * arm-tdep.c: Revert.
10088         * arm-symbian-tdep.c: Revert.
10089         * arm-pikeos-tdep.c: Revert.
10090         * arm-obsd-tdep.c: Revert.
10091         * arm-nbsd-tdep.c: Revert.
10092         * arm-nbsd-nat.c: Revert.
10093         * arm-linux-tdep.c: Revert.
10094         * arm-linux-nat.c: Revert.
10095         * arm-fbsd-tdep.c: Revert.
10096         * arm-fbsd-nat.c: Revert.
10097         * arm-bsd-tdep.c: Revert.
10098         * arch-utils.c: Revert.
10099         * arc-tdep.c: Revert.
10100         * arc-newlib-tdep.c: Revert.
10101         * annotate.h: Revert.
10102         * annotate.c: Revert.
10103         * amd64-windows-tdep.c: Revert.
10104         * amd64-windows-nat.c: Revert.
10105         * amd64-tdep.c: Revert.
10106         * amd64-sol2-tdep.c: Revert.
10107         * amd64-obsd-tdep.c: Revert.
10108         * amd64-obsd-nat.c: Revert.
10109         * amd64-nbsd-tdep.c: Revert.
10110         * amd64-nbsd-nat.c: Revert.
10111         * amd64-nat.c: Revert.
10112         * amd64-linux-tdep.c: Revert.
10113         * amd64-linux-nat.c: Revert.
10114         * amd64-fbsd-tdep.c: Revert.
10115         * amd64-fbsd-nat.c: Revert.
10116         * amd64-dicos-tdep.c: Revert.
10117         * amd64-darwin-tdep.c: Revert.
10118         * amd64-bsd-nat.c: Revert.
10119         * alpha-tdep.c: Revert.
10120         * alpha-obsd-tdep.c: Revert.
10121         * alpha-nbsd-tdep.c: Revert.
10122         * alpha-mdebug-tdep.c: Revert.
10123         * alpha-linux-tdep.c: Revert.
10124         * alpha-linux-nat.c: Revert.
10125         * alpha-bsd-tdep.c: Revert.
10126         * alpha-bsd-nat.c: Revert.
10127         * aix-thread.c: Revert.
10128         * agent.c: Revert.
10129         * addrmap.c: Revert.
10130         * ada-varobj.c: Revert.
10131         * ada-valprint.c: Revert.
10132         * ada-typeprint.c: Revert.
10133         * ada-tasks.c: Revert.
10134         * ada-lang.c: Revert.
10135         * aarch64-tdep.c: Revert.
10136         * aarch64-ravenscar-thread.c: Revert.
10137         * aarch64-newlib-tdep.c: Revert.
10138         * aarch64-linux-tdep.c: Revert.
10139         * aarch64-linux-nat.c: Revert.
10140         * aarch64-fbsd-tdep.c: Revert.
10141         * aarch64-fbsd-nat.c: Revert.
10142         * aarch32-linux-nat.c: Revert.
10143
10144 2019-04-05  Tom Tromey  <tom@tromey.com>
10145
10146         * ft32-tdep.c: Sort headers.
10147         * frv-tdep.c: Sort headers.
10148         * frv-linux-tdep.c: Sort headers.
10149         * frame.c: Sort headers.
10150         * frame-unwind.c: Sort headers.
10151         * frame-base.c: Sort headers.
10152         * fork-child.c: Sort headers.
10153         * findvar.c: Sort headers.
10154         * findcmd.c: Sort headers.
10155         * filesystem.c: Sort headers.
10156         * filename-seen-cache.h: Sort headers.
10157         * filename-seen-cache.c: Sort headers.
10158         * fbsd-tdep.c: Sort headers.
10159         * fbsd-nat.h: Sort headers.
10160         * fbsd-nat.c: Sort headers.
10161         * f-valprint.c: Sort headers.
10162         * f-typeprint.c: Sort headers.
10163         * f-lang.c: Sort headers.
10164         * extension.h: Sort headers.
10165         * extension.c: Sort headers.
10166         * extension-priv.h: Sort headers.
10167         * expprint.c: Sort headers.
10168         * exec.h: Sort headers.
10169         * exec.c: Sort headers.
10170         * exceptions.c: Sort headers.
10171         * event-top.c: Sort headers.
10172         * event-loop.c: Sort headers.
10173         * eval.c: Sort headers.
10174         * elfread.c: Sort headers.
10175         * dwarf2read.h: Sort headers.
10176         * dwarf2read.c: Sort headers.
10177         * dwarf2loc.c: Sort headers.
10178         * dwarf2expr.h: Sort headers.
10179         * dwarf2expr.c: Sort headers.
10180         * dwarf2-frame.c: Sort headers.
10181         * dwarf2-frame-tailcall.c: Sort headers.
10182         * dwarf-index-write.h: Sort headers.
10183         * dwarf-index-write.c: Sort headers.
10184         * dwarf-index-common.c: Sort headers.
10185         * dwarf-index-cache.h: Sort headers.
10186         * dwarf-index-cache.c: Sort headers.
10187         * dummy-frame.c: Sort headers.
10188         * dtrace-probe.c: Sort headers.
10189         * disasm.h: Sort headers.
10190         * disasm.c: Sort headers.
10191         * disasm-selftests.c: Sort headers.
10192         * dictionary.c: Sort headers.
10193         * dicos-tdep.c: Sort headers.
10194         * demangle.c: Sort headers.
10195         * dcache.h: Sort headers.
10196         * dcache.c: Sort headers.
10197         * darwin-nat.h: Sort headers.
10198         * darwin-nat.c: Sort headers.
10199         * darwin-nat-info.c: Sort headers.
10200         * d-valprint.c: Sort headers.
10201         * d-namespace.c: Sort headers.
10202         * d-lang.c: Sort headers.
10203         * ctf.c: Sort headers.
10204         * csky-tdep.c: Sort headers.
10205         * csky-linux-tdep.c: Sort headers.
10206         * cris-tdep.c: Sort headers.
10207         * cris-linux-tdep.c: Sort headers.
10208         * cp-valprint.c: Sort headers.
10209         * cp-support.c: Sort headers.
10210         * cp-namespace.c: Sort headers.
10211         * cp-abi.c: Sort headers.
10212         * corelow.c: Sort headers.
10213         * corefile.c: Sort headers.
10214         * continuations.c: Sort headers.
10215         * completer.h: Sort headers.
10216         * completer.c: Sort headers.
10217         * complaints.c: Sort headers.
10218         * coffread.c: Sort headers.
10219         * coff-pe-read.c: Sort headers.
10220         * cli-out.h: Sort headers.
10221         * cli-out.c: Sort headers.
10222         * charset.c: Sort headers.
10223         * c-varobj.c: Sort headers.
10224         * c-valprint.c: Sort headers.
10225         * c-typeprint.c: Sort headers.
10226         * c-lang.c: Sort headers.
10227         * buildsym.c: Sort headers.
10228         * buildsym-legacy.c: Sort headers.
10229         * build-id.h: Sort headers.
10230         * build-id.c: Sort headers.
10231         * btrace.c: Sort headers.
10232         * bsd-uthread.c: Sort headers.
10233         * breakpoint.h: Sort headers.
10234         * breakpoint.c: Sort headers.
10235         * break-catch-throw.c: Sort headers.
10236         * break-catch-syscall.c: Sort headers.
10237         * break-catch-sig.c: Sort headers.
10238         * blockframe.c: Sort headers.
10239         * block.c: Sort headers.
10240         * bfin-tdep.c: Sort headers.
10241         * bfin-linux-tdep.c: Sort headers.
10242         * bfd-target.c: Sort headers.
10243         * bcache.c: Sort headers.
10244         * ax-general.c: Sort headers.
10245         * ax-gdb.h: Sort headers.
10246         * ax-gdb.c: Sort headers.
10247         * avr-tdep.c: Sort headers.
10248         * auxv.c: Sort headers.
10249         * auto-load.c: Sort headers.
10250         * arm-wince-tdep.c: Sort headers.
10251         * arm-tdep.c: Sort headers.
10252         * arm-symbian-tdep.c: Sort headers.
10253         * arm-pikeos-tdep.c: Sort headers.
10254         * arm-obsd-tdep.c: Sort headers.
10255         * arm-nbsd-tdep.c: Sort headers.
10256         * arm-nbsd-nat.c: Sort headers.
10257         * arm-linux-tdep.c: Sort headers.
10258         * arm-linux-nat.c: Sort headers.
10259         * arm-fbsd-tdep.c: Sort headers.
10260         * arm-fbsd-nat.c: Sort headers.
10261         * arm-bsd-tdep.c: Sort headers.
10262         * arch-utils.c: Sort headers.
10263         * arc-tdep.c: Sort headers.
10264         * arc-newlib-tdep.c: Sort headers.
10265         * annotate.h: Sort headers.
10266         * annotate.c: Sort headers.
10267         * amd64-windows-tdep.c: Sort headers.
10268         * amd64-windows-nat.c: Sort headers.
10269         * amd64-tdep.c: Sort headers.
10270         * amd64-sol2-tdep.c: Sort headers.
10271         * amd64-obsd-tdep.c: Sort headers.
10272         * amd64-obsd-nat.c: Sort headers.
10273         * amd64-nbsd-tdep.c: Sort headers.
10274         * amd64-nbsd-nat.c: Sort headers.
10275         * amd64-nat.c: Sort headers.
10276         * amd64-linux-tdep.c: Sort headers.
10277         * amd64-linux-nat.c: Sort headers.
10278         * amd64-fbsd-tdep.c: Sort headers.
10279         * amd64-fbsd-nat.c: Sort headers.
10280         * amd64-dicos-tdep.c: Sort headers.
10281         * amd64-darwin-tdep.c: Sort headers.
10282         * amd64-bsd-nat.c: Sort headers.
10283         * alpha-tdep.c: Sort headers.
10284         * alpha-obsd-tdep.c: Sort headers.
10285         * alpha-nbsd-tdep.c: Sort headers.
10286         * alpha-mdebug-tdep.c: Sort headers.
10287         * alpha-linux-tdep.c: Sort headers.
10288         * alpha-linux-nat.c: Sort headers.
10289         * alpha-bsd-tdep.c: Sort headers.
10290         * alpha-bsd-nat.c: Sort headers.
10291         * aix-thread.c: Sort headers.
10292         * agent.c: Sort headers.
10293         * addrmap.c: Sort headers.
10294         * ada-varobj.c: Sort headers.
10295         * ada-valprint.c: Sort headers.
10296         * ada-typeprint.c: Sort headers.
10297         * ada-tasks.c: Sort headers.
10298         * ada-lang.c: Sort headers.
10299         * aarch64-tdep.c: Sort headers.
10300         * aarch64-ravenscar-thread.c: Sort headers.
10301         * aarch64-newlib-tdep.c: Sort headers.
10302         * aarch64-linux-tdep.c: Sort headers.
10303         * aarch64-linux-nat.c: Sort headers.
10304         * aarch64-fbsd-tdep.c: Sort headers.
10305         * aarch64-fbsd-nat.c: Sort headers.
10306         * aarch32-linux-nat.c: Sort headers.
10307
10308 2019-04-04  Tom Tromey  <tom@tromey.com>
10309
10310         * varobj.c (varobj_create): Update.
10311         * rust-exp.y (struct rust_parser) <update_innermost_block,
10312         lookup_symbol>: New methods.
10313         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10314         Rename.
10315         (rust_parser::rust_lookup_type)
10316         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10317         * printcmd.c (display_command, do_one_display): Update.
10318         * parser-defs.h (struct parser_state) <parser_state>: Add
10319         "tracker" parameter.
10320         (block_tracker): New member.
10321         (class innermost_block_tracker) <innermost_block_tracker>: Add
10322         "types" parameter.
10323         <reset>: Remove method.
10324         (innermost_block): Don't declare.
10325         (null_post_parser): Update.
10326         * parse.c (innermost_block): Remove global.
10327         (write_dollar_variable): Update.
10328         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10329         Remove "tracker_types" parameter.
10330         (parse_expression): Add "tracker" parameter.
10331         (parse_expression_for_completion): Update.
10332         (null_post_parser): Add "tracker" parameter.
10333         * p-exp.y: Update rules.
10334         * m2-exp.y: Update rules.
10335         * language.h (struct language_defn) <la_post_parser>: Add
10336         "tracker" parameter.
10337         * go-exp.y: Update rules.
10338         * f-exp.y: Update rules.
10339         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10340         parameter.
10341         * d-exp.y: Update rules.
10342         * c-exp.y: Update rules.
10343         * breakpoint.c (set_breakpoint_condition): Create an
10344         innermost_block_tracker.
10345         (watch_command_1): Likewise.
10346         * ada-lang.c (resolve): Add "tracker" parameter.
10347         (resolve_subexp): Likewise.
10348         * ada-exp.y (write_var_from_sym): Update.
10349
10350 2019-04-04  Tom Tromey  <tom@tromey.com>
10351
10352         * type-stack.h: New file.
10353         * type-stack.c: New file.
10354         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10355         type-stack.h.
10356         (insert_into_type_stack, insert_type, push_type, push_type_int)
10357         (insert_type_address_space, pop_type, pop_type_int)
10358         (pop_typelist, pop_type_stack, append_type_stack)
10359         (push_type_stack, get_type_stack, push_typelist)
10360         (follow_type_instance_flags, follow_types): Don't declare.
10361         * parse.c (type_stack): Remove global.
10362         (parse_exp_in_context): Update.
10363         (insert_into_type_stack, insert_type, push_type, push_type_int)
10364         (insert_type_address_space, pop_type, pop_type_int)
10365         (pop_typelist, pop_type_stack, append_type_stack)
10366         (push_type_stack, get_type_stack, push_typelist)
10367         (follow_type_instance_flags, follow_types): Remove (moved to
10368         type-stack.c).
10369         * f-exp.y (type_stack): New global.
10370         Update rules.
10371         (push_kind_type, f_parse): Update.
10372         * d-exp.y (type_stack): New global.
10373         Update rules.
10374         (d_parse): Update.
10375         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10376         Update rules.
10377         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10378         (HFILES_NO_SRCDIR): Add type-stack.h.
10379
10380 2019-04-04  Tom Tromey  <tom@tromey.com>
10381
10382         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10383         (rust_parser::convert_ast_to_expression, rust_parse)
10384         (rust_lex_test_completion, rust_lex_tests): Update.
10385         * parser-defs.h (struct expr_completion_state): New.
10386         (struct parser_state) <parser_state>: Add completion parameter.
10387         <mark_struct_expression, mark_completion_tag>: New methods.
10388         <parse_completion, m_completion_state>: New members.
10389         (prefixify_expression, null_post_parser): Update.
10390         (mark_struct_expression, mark_completion_tag): Don't declare.
10391         * parse.c (parse_completion, expout_last_struct)
10392         (expout_tag_completion_type, expout_completion_name): Remove
10393         globals.
10394         (parser_state::mark_struct_expression)
10395         (parser_state::mark_completion_tag): Now methods.
10396         (prefixify_expression): Add last_struct parameter.
10397         (prefixify_subexp): Likewise.
10398         (parse_exp_1): Update.
10399         (parse_exp_in_context): Add cstate parameter.  Update.
10400         (parse_expression_for_completion): Create an
10401         expr_completion_state.
10402         (null_post_parser): Add "completion" parameter.
10403         * p-exp.y: Update rules.
10404         (yylex): Update.
10405         * language.h (struct language_defn) <la_post_parser>: Add
10406         "completing" parameter.
10407         * go-exp.y: Update rules.
10408         (lex_one_token): Update.
10409         * expression.h (parse_completion): Don't declare.
10410         * d-exp.y: Update rules.
10411         (lex_one_token): Update rules.
10412         * c-exp.y: Update rules.
10413         (lex_one_token): Update.
10414         * ada-lang.c (resolve): Add "parse_completion" parameter.
10415         (resolve_subexp): Likewise.
10416         (ada_resolve_function): Likewise.
10417
10418 2019-04-04  Tom Tromey  <tom@tromey.com>
10419
10420         * parser-defs.h (struct parser_state) <start_arglist,
10421         end_arglist>: New methods.
10422         <arglist_len, m_funcall_chain>: New members.
10423         (arglist_len, start_arglist, end_arglist): Don't declare.
10424         * parse.c (arglist_len, funcall_chain): Remove global.
10425         (start_arglist, end_arglist): Remove functions.
10426         (parse_exp_in_context): Update.
10427         * p-exp.y: Update rules.
10428         * m2-exp.y: Update rules.
10429         * go-exp.y: Update rules.
10430         * f-exp.y: Update rules.
10431         * d-exp.y: Update rules.
10432         * c-exp.y: Update rules.
10433
10434 2019-04-04  Tom Tromey  <tom@tromey.com>
10435
10436         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10437         lex_operator, push_back>: New methods.
10438         Update all rules.
10439         (rust_parser::lex_hex, lex_escape): Rename and update.
10440         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10441         (rust_parser::lex_operator): Rename and update.
10442         (rust_parser::lex_number, rustyylex, rustyyerror)
10443         (rust_lex_test_init, rust_lex_test_sequence)
10444         (rust_lex_test_push_back, rust_lex_tests): Update.
10445         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10446         parameter.
10447         <lexptr, prev_lexptr>: New members.
10448         (lexptr, prev_lexptr): Don't declare.
10449         * parse.c (lexptr, prev_lexptr): Remove globals.
10450         (parse_exp_in_context): Update.
10451         * p-exp.y (yylex, yyerror): Update.
10452         * m2-exp.y (parse_number, yylex, yyerror): Update.
10453         * go-exp.y (lex_one_token, yyerror): Update.
10454         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10455         * d-exp.y (lex_one_token, yyerror): Update.
10456         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10457         (lex_one_token, yyerror): Update.
10458         * ada-lex.l (YY_INPUT): Update.
10459         (rewind_to_char): Update.
10460         * ada-exp.y (yyerror): Update.
10461
10462 2019-04-04  Tom Tromey  <tom@tromey.com>
10463
10464         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10465         * parser-defs.h (struct parser_state) <parser_state>: Add new
10466         parameter.
10467         <comma_terminates>: New member.
10468         (comma_terminates): Don't declare global.
10469         * parse.c (comma_terminates): Remove global.
10470         (parse_exp_in_context): Update.
10471         * p-exp.y (yylex): Update.
10472         * m2-exp.y (yylex): Update.
10473         * go-exp.y (lex_one_token): Update.
10474         * f-exp.y (yylex): Update.
10475         * d-exp.y (lex_one_token): Update.
10476         * c-exp.y (lex_one_token): Update.
10477         * ada-lex.l: Update.
10478
10479 2019-04-04  Tom Tromey  <tom@tromey.com>
10480
10481         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10482         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10483         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10484         * parser-defs.h (paren_depth): Don't declare.
10485         * parse.c (paren_depth): Remove global.
10486         (parse_exp_in_context): Update.
10487         * p-exp.y (paren_depth): New global.
10488         (pascal_parse): Initialize it.
10489         * m2-exp.y (paren_depth): New global.
10490         (m2_parse): Initialize it.
10491         * go-exp.y (paren_depth): New global.
10492         (go_parse): Initialize it.
10493         * f-exp.y (paren_depth): New global.
10494         (f_parse): Initialize it.
10495         * d-exp.y (paren_depth): New global.
10496         (d_parse): Initialize it.
10497         * c-exp.y (paren_depth): New global.
10498         (c_parse): Initialize it.
10499         * ada-lex.l (paren_depth): New global.
10500         (lexer_init): Initialize it.
10501
10502 2019-04-04  Tom Tromey  <tom@tromey.com>
10503
10504         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10505         (rust_parser::convert_ast_to_type)
10506         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10507         * parser-defs.h (struct parser_state) <parser_state>: Add
10508         parameters.  Initialize new members.
10509         <expression_context_block, expression_context_pc>: New members.
10510         * parse.c (expression_context_block, expression_context_pc):
10511         Remove globals.
10512         (parse_exp_in_context): Update.
10513         * p-exp.y: Update all rules.
10514         (yylex): Update.
10515         * m2-exp.y: Update all rules.
10516         (yylex): Update.
10517         * go-exp.y (yylex): Update.
10518         * f-exp.y (yylex): Update.
10519         * d-exp.y: Update all rules.
10520         (yylex): Update.
10521         * c-exp.y: Update all rules.
10522         (lex_one_token, classify_name, yylex, c_parse): Update.
10523         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10524
10525 2019-04-04  Tom Tromey  <tom@tromey.com>
10526
10527         * gdbarch.h, gdbarch.c: Rebuild.
10528         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10529         * stap-probe.h:
10530         (struct stap_parse_info): Replace "parser_state" with
10531         "expr_builder".
10532         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10533         (parser_state): New class.
10534         * parse.c (expr_builder): Rename.
10535         (expr_builder::release): Rename.
10536         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10537         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10538         (write_exp_elt_longcst, write_exp_elt_floatcst)
10539         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10540         (write_exp_string_vector, write_exp_bitstring)
10541         (write_exp_msymbol, mark_struct_expression)
10542         (write_dollar_variable)
10543         (insert_type_address_space, increase_expout_size): Replace
10544         "parser_state" with "expr_builder".
10545         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10546         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10547         "parser_state" with "expr_builder".
10548
10549 2019-04-04  Tom Tromey  <tom@tromey.com>
10550
10551         * rust-exp.y: Replace "parse_language" with method call.
10552         * p-exp.y:
10553         (yylex): Replace "parse_language" with method call.
10554         * m2-exp.y:
10555         (yylex): Replace "parse_language" with method call.
10556         * go-exp.y (classify_name): Replace "parse_language" with method
10557         call.
10558         * f-exp.y (yylex): Replace "parse_language" with method call.
10559         * d-exp.y (lex_one_token): Replace "parse_language" with method
10560         call.
10561         * c-exp.y:
10562         (lex_one_token, classify_name, yylex): Replace "parse_language"
10563         with method call.
10564         * ada-exp.y (find_primitive_type, type_char)
10565         (type_system_address): Replace "parse_language" with method call.
10566
10567 2019-04-04  Tom Tromey  <tom@tromey.com>
10568
10569         * rust-exp.y: Replace "parse_gdbarch" with method call.
10570         * parse.c (write_dollar_variable, insert_type_address_space):
10571         Replace "parse_gdbarch" with method call.
10572         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10573         call.
10574         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10575         call.
10576         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10577         "parse_gdbarch" with method call.
10578         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10579         with method call.
10580         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10581         "parse_gdbarch" with method call.
10582         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10583         "parse_gdbarch" with method call.
10584         * c-exp.y (parse_type, parse_number, classify_name): Replace
10585         "parse_gdbarch" with method call.
10586         * ada-lex.l: Replace "parse_gdbarch" with method call.
10587         * ada-exp.y (parse_type, find_primitive_type, type_char)
10588         (type_system_address): Replace "parse_gdbarch" with method call.
10589
10590 2019-04-04  Tom Tromey  <tom@tromey.com>
10591
10592         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10593         * stap-probe.c (stap_parse_argument): Update.
10594         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10595         initial_size parameter.
10596         * rust-exp.y (rust_lex_tests): Update.
10597         * parse.c (parser_state): Update.
10598         (parse_exp_in_context): Update.
10599         * parser-defs.h (struct parser_state) <parser_state>: Remove
10600         "initial_size" parameter.
10601
10602 2019-04-04  Tom Tromey  <tom@tromey.com>
10603
10604         * parser-defs.h (increase_expout_size): Don't declare.
10605         * parse.c (increase_expout_size): Now static.
10606
10607 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10608
10609         * gnu-nat.c (gnu_nat_target::wait): Fix
10610         target_waitstatus_to_string call.
10611
10612 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10613
10614         * eval.c (evaluate_subexp_standard): Handle internal functions
10615         during Fortran function call handling.
10616
10617 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10618
10619         * NEWS: Mention new internal functions.
10620         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10621         (read_base_type): Use dwarf2_init_complex_target_type.
10622         * value.c (creal_internal_fn): New function.
10623         (cimag_internal_fn): New function.
10624         (_initialize_values): Register new internal functions.
10625
10626 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10627
10628         * infrun.c (stop_all_threads): If debug_infrun, always
10629         trace the wait status after wait_one, using
10630         target_waitstatus_to_string and target_pid_to_str.
10631         (handle_inferior_event): Replace various trace of
10632         wait status kind by a single trace.
10633         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10634         wait status kind image by target_waitstatus_to_string.
10635         * target/waitstatus.c (target_waitstatus_to_string): Fix
10636         obsolete comment.
10637
10638 2019-04-01  Tom Tromey  <tromey@adacore.com>
10639
10640         PR symtab/23331:
10641         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10642
10643 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10644             Pedro Alves  <palves@redhat.com>
10645
10646         * top.c (quit_force): Call 'finalize_values'.
10647         * value.c (finalize_values): New function.
10648         * value.h (finalize_values): Declare.
10649
10650 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10651
10652         * NEWS: Announce $_gdb_major and $_gdb_minor.
10653
10654         * top.c (init_gdb_version_vars): New function.
10655         (gdb_init): Call init_gdb_version_vars.
10656
10657 2019-03-29  Tom Tromey  <tromey@adacore.com>
10658
10659         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10660         help text.  Remove dead code.
10661
10662 2019-03-29  Keith Seitz  <keiths@redhat.com>
10663
10664         From Siddhesh Poyarekar:
10665         * f-lang.h (f77_get_upperbound): Return LONGEST.
10666         (f77_get_lowerbound): Likewise.
10667         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10668         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10669         print them.
10670         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10671         plongest to format print it.
10672         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10673         (f77_get_upperbound): Likewise.
10674         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10675         LOWER_BOUND to LONGEST.
10676         (f77_create_arrayprint_offset_tbl): Likewise.
10677
10678 2019-03-29  Keith Seitz  <keiths@redhat.com>
10679
10680         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10681         %s/pulongest for TYPE_LENGTH instead of %d in format
10682         strings.
10683         * ada-typerint.c (ada_print_type): Likewise.
10684         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10685         * compile/compile-c-support.c (generate_register_struct): Likewise.
10686         * gdbtypes.c (recursive_dump_type): Likewise.
10687         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10688         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10689         instead of %d in format strings.
10690         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10691         to std::min to ULONGEST.
10692         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10693         instead of %d in format strings.
10694         * tracepoint.c (info_scope_command): Likewise.
10695         * typeprint.c (print_offset_data::update)
10696         (print_offset_data::finish): Likewise.
10697         * xtensa-tdep.c (xtensa_store_return_value)
10698         (xtensa_push_dummy_call): Likewise.
10699
10700 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10701
10702         * windows-nat.c (display_selector): Fixed format specifications
10703         for 64-bit Cygwin.
10704
10705 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10706
10707         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10708
10709 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10710
10711         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10712         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10713         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10714         (nios2_linux_init_abi): Install it.
10715
10716 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10717
10718         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10719
10720 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10721
10722         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10723
10724 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10725             Tom Tromey  <tromey@adacore.com>
10726
10727         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10728
10729 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10730
10731         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10732         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10733         method to compute the bounds of range types. Also print "[evaluated]"
10734         if the bounds' values come from a dynamic evaluation.
10735
10736 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10737
10738         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10739         whitespace when pretty printing is on.
10740
10741 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10742
10743         * ppc-linux-nat.c: Add include.
10744
10745 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10746
10747         * NEWS: Mention AArch64 Pointer Authentication.
10748
10749 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10750
10751         * arm-linux-nat.c: Add include.
10752
10753 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10754
10755         * source-cache.c (source_cache::get_source_lines): Re-read
10756         fullname after calling open_source_file.
10757
10758 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10759
10760         * NEWS: Mention TLS support for FreeBSD.
10761
10762 2019-03-25  Tom Tromey  <tromey@adacore.com>
10763
10764         * minsyms.c (BUNCH_SIZE): Update comment.
10765         (~minimal_symbol_reader): Remove old comment.
10766         (compact_minimal_symbols): Update comment.
10767         (minimal_symbol_reader::install): Remove old comment.  Update
10768         other comments.
10769
10770 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10771
10772         * s390-linux-nat.c: Add include.
10773
10774 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10775
10776         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10777         Call linux_get_hwcap.
10778         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10779         Likewise.
10780         (aarch64_linux_get_hwcap): Remove function.
10781         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10782         declaration.
10783         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10784         linux_get_hwcap.
10785         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10786         * linux-tdep.c (linux_get_hwcap): Add function.
10787         (linux_get_hwcap2): Likewise.
10788         * linux-tdep.h (linux_get_hwcap): Add declaration.
10789         (linux_get_hwcap2): Likewise.
10790         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10791         (ppc_linux_get_hwcap2): Likewise.
10792         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10793         linux_get_hwcap.
10794         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10795         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10796         (ppc_linux_nat_target::read_description): Likewise.
10797         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10798         * s390-linux-nat.c: Likewise.
10799         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10800
10801 2019-03-24  Tom Tromey  <tom@tromey.com>
10802
10803         * ada-lang.c (standard_lookup): Simplify initialization.
10804         (ada_lookup_symbol_nonlocal): Simplify return.
10805         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10806         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10807         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10808         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10809         initialization.
10810         * solib.c (solib_global_lookup): Simplify.
10811         * symtab.c (null_block_symbol): Remove.
10812         (symbol_cache_lookup): Simplify returns.
10813         (lookup_language_this): Simplify returns.
10814         (lookup_symbol_aux): Simplify return.
10815         (lookup_local_symbol): Simplify returns.
10816         (lookup_global_symbol_from_objfile): Simplify return.
10817         (lookup_symbol_in_objfile_symtabs)
10818         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10819         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10820         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10821         * cp-namespace.c (cp_lookup_bare_symbol)
10822         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10823         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10824         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10825         (cp_lookup_symbol_via_imports): Simplify initialization.
10826         (find_symbol_in_baseclass): Likewise.
10827         * symtab.h (null_block_symbol): Remove.
10828         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10829         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10830         (d_lookup_symbol_module): Likewise.
10831         (find_symbol_in_baseclass): Simplify initialization.
10832
10833 2019-03-24  Tom Tromey  <tom@tromey.com>
10834
10835         * expression.h: Don't include symtab.h.
10836         (struct block): Forward declare.
10837
10838 2019-03-24  Tom Tromey  <tom@tromey.com>
10839
10840         * c-exp.y (typebase): Remove casts.
10841         * gdbtypes.c (lookup_unsigned_typename, )
10842         (lookup_signed_typename): Remove cast.
10843         * eval.c (parse_to_comma_and_eval): Remove cast.
10844         * parse.c (write_dollar_variable): Remove cast.
10845         * block.h (struct block) <superblock>: Now const.
10846         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10847         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10848         (map_block): Make "block" const.
10849         * symfile.h (struct quick_symbol_functions)
10850         <map_matching_symbols>: Constify block argument to "callback".
10851         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10852         const.
10853         (find_pc_sect_compunit_symtab): Make "b" const.
10854         (find_symbol_at_address): Likewise.
10855         (search_symbols): Likewise.
10856         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10857         (dw2_debug_names_lookup_symbol): Likewise.
10858         (dw2_map_matching_symbols): Update.
10859         * p-valprint.c (pascal_val_print): Remove "block".
10860         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10861         (aux_add_nonlocal_symbols): Make "block" const.
10862         (resolve_subexp): Remove cast.
10863         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10864         const.
10865         (iterate_over_file_blocks): Likewise.
10866         * f-exp.y (%union) <bval>: Remove.
10867         * coffread.c (patch_opaque_types): Make "b" const.
10868         * spu-tdep.c (spu_catch_start): Make "block" const.
10869         * c-valprint.c (print_unpacked_pointer): Remove "block".
10870         * symmisc.c (dump_symtab_1): Make "b" const.
10871         (block_depth): Make "block" const.
10872         * d-exp.y (%union) <bval>: Remove.
10873         * cp-support.h (cp_lookup_rtti_type): Update.
10874         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10875         * psymtab.c (psym_lookup_symbol): Make "block" const.
10876         (maintenance_check_psymtabs): Make "b" const.
10877         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10878         (enumerate_locals, enumerate_args): Update.
10879         * python/py-symtab.c (stpy_global_block): Make "block" const.
10880         (stpy_static_block): Likewise.
10881         * inline-frame.c (block_starting_point_at): Make "new_block"
10882         const.
10883         * block.c (find_block_in_blockvector): Make return type const.
10884         (blockvector_for_pc_sect): Make "b" const.
10885         (find_block_in_blockvector): Make "b" const.
10886
10887 2019-03-23  Tom Tromey  <tom@tromey.com>
10888
10889         * varobj.c (varobj_create): Update.
10890         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10891         * printcmd.c (display_command, do_one_display): Don't reset
10892         innermost_block.
10893         * parser-defs.h (enum innermost_block_tracker_type): Move to
10894         expression.h.
10895         (innermost_block): Update comment.
10896         * parse.c (parse_exp_1): Add tracker_types parameter.
10897         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10898         tracker_types parameter.  Reset innermost_block.
10899         (parse_exp_in_context): Remove.
10900         (parse_expression_for_completion): Update.
10901         * objfiles.c (~objfile): Don't reset expression_context_block or
10902         innermost_block.
10903         * expression.h (enum innermost_block_tracker_type): Move from
10904         parser-defs.h.
10905         (parse_exp_1): Add tracker_types parameter.
10906         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10907         reset innermost_block.
10908
10909 2019-03-23  Tom Tromey  <tom@tromey.com>
10910
10911         * objfiles.h: Include bcache.h.
10912
10913 2019-03-23  Tom Tromey  <tom@tromey.com>
10914
10915         * linespec.c (get_current_search_block): Use
10916         scoped_restore_current_language.
10917         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10918
10919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10920             Jiong Wang  <jiong.wang@arm.com>
10921
10922         * aarch64-linux-tdep.c
10923         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10924         section.
10925         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10926
10927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10928             Jiong Wang  <jiong.wang@arm.com>
10929
10930         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10931         instructions.
10932         (aarch64_analyze_prologue_test): Add PACIASP test.
10933         (aarch64_prologue_prev_register): Unmask PC value.
10934
10935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10936             Jiong Wang  <jiong.wang@arm.com>
10937
10938         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10939         (aarch64_dwarf2_prev_register): Unmask PC value.
10940         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10941         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10942         DW_CFA_AARCH64_negate_ra_state.
10943         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10944
10945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10946             Jiong Wang  <jiong.wang@arm.com>
10947
10948         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10949         registers.
10950         (aarch64_pseudo_register_name): Likewise.
10951         (aarch64_pseudo_register_type): Likewise.
10952         (aarch64_pseudo_register_reggroup_p): Likewise.
10953         (aarch64_gdbarch_init): Add pauth registers.
10954         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10955         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10956         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10957         (struct gdbarch_tdep): Add regnum for ra_state.
10958
10959 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10960             Jiong Wang  <jiong.wang@arm.com>
10961
10962         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10963
10964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10965             Jiong Wang  <jiong.wang@arm.com>
10966
10967         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10968         function.
10969         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10970         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10971         (aarch64_gdbarch_init): Add puth registers.
10972         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10973         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10974         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10975
10976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10977             Jiong Wang  <jiong.wang@arm.com>
10978
10979         * aarch64-linux-nat.c
10980         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10981         * aarch64-linux-tdep.c
10982         (aarch64_linux_core_read_description): Likewise.
10983         (aarch64_linux_get_hwcap): New function.
10984         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10985         (aarch64_linux_get_hwcap): New declaration.
10986
10987 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10988             Jiong Wang  <jiong.wang@arm.com>
10989
10990         * aarch64-linux-nat.c
10991         (aarch64_linux_nat_target::read_description): Add pauth param.
10992         * aarch64-linux-tdep.c
10993         (aarch64_linux_core_read_description): Likewise.
10994         * aarch64-tdep.c (struct target_desc): Add in pauth.
10995         (aarch64_read_description): Add pauth param.
10996         (aarch64_gdbarch_init): Likewise.
10997         * aarch64-tdep.h (aarch64_read_description): Likewise.
10998         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10999         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11000         * features/Makefile: Add new files.
11001         * features/aarch64-pauth.c: New file.
11002         * features/aarch64-pauth.xml: New file.
11003
11004 2019-03-20  Tom Tromey  <tromey@adacore.com>
11005
11006         * infrun.c (handle_inferior_event): Rename from
11007         handle_inferior_event_1.  Create a scoped_value_mark.
11008         (handle_inferior_event): Remove.
11009
11010 2019-03-19  Tom Tromey  <tromey@adacore.com>
11011
11012         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11013         * infrun.h (print_stop_event): Add "displays" parameter.
11014         * infrun.c (print_stop_event): Add "displays" parameter.
11015
11016 2019-03-19  Pedro Alves  <palves@redhat.com>
11017
11018         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11019         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11020         to -1.  Fix TABs vs spaces.
11021         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11022         * tui/tui-out.h (tui_ui_out) Add intro comments.
11023         <m_line, m_start_of_line>: In-class initialize, and add describing
11024         comment.
11025
11026 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11027
11028         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11029         variable names.
11030         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11031
11032 2019-03-18  Pedro Alves  <palves@redhat.com>
11033             Eli Zaretskii <eliz@gnu.org>
11034
11035         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11036         m_line and m_start_of_line.
11037
11038 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11039
11040         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11041         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11042         it returns a newline.  This fixes a regression in TU mode, whereby
11043         the next line is output on the same screen line as the user input.
11044
11045 2019-03-18  Tom Tromey  <tromey@adacore.com>
11046
11047         * minsyms.c (minimal_symbol_reader::install): Remove call to
11048         obstack_blank.
11049
11050 2019-03-18  Pedro Alves  <palves@redhat.com>
11051
11052         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11053         New globals.
11054         (apply_style): New, factored out from ...
11055         (apply_ansi_escape): ... this.  Handle reverse video mode.
11056         (tui_set_reverse_mode): New function.
11057         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11058         * tui/tui-winsource.c (tui_show_source_line): Use
11059         tui_set_reverse_mode instead of setting A_STANDOUT.
11060         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11061         New setter methods.
11062
11063 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11064
11065         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11066         Handle tabs.
11067
11068 2019-03-18  Tom Tromey  <tromey@adacore.com>
11069
11070         * ada-lang.c (empty_array): Add "high" parameter.
11071         (ada_evaluate_subexp): Update.
11072
11073 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11074
11075         * unittests/string_view-selftests.c: Define
11076         _initialize_string_view_selftests unconditionally.
11077
11078 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11079
11080         PR gdb/24350
11081         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11082
11083 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11084
11085         PR gdb/24351
11086         * windows-nat.c (display_selector): Fix format specifiers.
11087
11088 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11089
11090         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11091         tui_refill_source_window instead of tui_refresh_win, to update the
11092         current execution line.  This fixes redisplay of the current line
11093         when stepping through the code with "next" or "step".
11094
11095 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11096
11097         * source-cache.c (source_cache::get_source_lines): Call
11098         find_source_lines to initialize s->nlines.  This fixes vertical
11099         scrolling of TUI source window when the DOWN arrow is pressed.
11100
11101 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11102
11103         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11104         linux-thread-db.c (_initialize_thread_db): Likewise.
11105
11106 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11107
11108         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11109         wclrtoeol in tui_show_source_line".  This reverts changes made in
11110         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11111
11112 2019-03-15  Tom Tromey  <tom@tromey.com>
11113
11114         * symtab.h (struct minimal_symbol): Derive from
11115         general_symbol_info.
11116         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11117         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11118         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11119         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11120         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11121         (MSYMBOL_SEARCH_NAME): Update.
11122         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11123         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11124         * minsyms.c (minimal_symbol_reader::record_full): Update.
11125
11126 2019-03-15  Tom Tromey  <tom@tromey.com>
11127
11128         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11129
11130 2019-03-15  Tom Tromey  <tom@tromey.com>
11131
11132         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11133         unique_xmalloc_ptr.
11134         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11135         Update.
11136         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11137         (build_minimal_symbol_hash_tables)
11138         (minimal_symbol_reader::install): Update.
11139
11140 2019-03-15  Tom Tromey  <tom@tromey.com>
11141
11142         * symtab.c (create_demangled_names_hash): Update.
11143         (symbol_set_names): Update.
11144         * objfiles.h (struct objfile_per_bfd_storage)
11145         <demangled_names_hash>: Now an htab_up.
11146         * objfiles.c (objfile_per_bfd_storage): Simplify.
11147
11148 2019-03-15  Tom Tromey  <tom@tromey.com>
11149
11150         * objfiles.h (struct objfile_per_bfd_storage): Declare
11151         destructor.
11152         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11153         New.
11154         (get_objfile_bfd_data): Use new.  Don't initialize
11155         language_of_main.
11156         (free_objfile_per_bfd_storage): Remove.
11157         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11158
11159 2019-03-15  Tom Tromey  <tom@tromey.com>
11160
11161         * symfile.c (reread_symbols): Update.
11162         * objfiles.c (objfile::objfile): Update.
11163         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11164         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11165         comment.
11166         (minimal_symbol_reader::install): Update.
11167         (terminate_minimal_symbol_table): Remove.
11168         * jit.c (jit_object_close_impl): Update.
11169
11170 2019-03-15  Tom Tromey  <tom@tromey.com>
11171
11172         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11173         initializations.
11174
11175 2019-03-15  Tom Tromey  <tom@tromey.com>
11176
11177         * objfiles.h (struct objfile_per_bfd_storage)
11178         <demangled_hash_languages>: Now a bitset.
11179         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11180         (lookup_minimal_symbol): Update.
11181
11182 2019-03-15  Tom Tromey  <tom@tromey.com>
11183
11184         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11185         Don't return the symbol.
11186         * coffread.c (record_minimal_symbol): Use record_full.
11187
11188 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11189
11190         The MS-Windows port of ncurses fails to switch to a color pair if
11191         one or both of the colors are the implicit default colors.  This
11192         change records the default colors when TUI is initialized, and
11193         then specifies them explicitly when a color pair uses the default
11194         colors.  This allows color styling in TUI mode on MS-Windows.
11195
11196         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11197         ncurses_norm_attr.
11198         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11199         colors in ncurses_norm_attr.
11200         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11201         "none", replace it with the default color recorded in
11202         ncurses_norm_attr.
11203
11204 2019-03-14  Tom Tromey  <tromey@adacore.com>
11205
11206         * source-cache.h (class source_cache) <get_source_lines>: Return
11207         std::string.
11208         * source-cache.c (source_cache::extract_lines): Handle case where
11209         first_pos==npos.  Return std::string.
11210         (source_cache::get_source_lines): Update.
11211
11212 2019-03-14  Tom Tromey  <tromey@adacore.com>
11213
11214         * NEWS: Add item for "style sources" commands.
11215         * source-cache.c (source_cache::get_source_lines): Check
11216         source_styling.
11217         * cli/cli-style.c (source_styling): New global.
11218         (_initialize_cli_style): Add "style sources" commands.
11219         (show_style_sources): New function.
11220         * cli/cli-style.h (source_styling): Declare.
11221
11222 2019-03-14  Pedro Alves  <palves@redhat.com>
11223             Tom Tromey  <tromey@adacore.com>
11224
11225         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11226         * tui/tui-winsource.c (tui_refill_source_window): New function,
11227         from...
11228         (tui_horizontal_source_scroll): ... here.  Move some logic.
11229         * cli/cli-style.c (set_style_enabled): Notify new observable.
11230         * tui/tui-hooks.c (tui_redisplay_source): New function.
11231         (tui_attach_detach_observers): Attach or detach
11232         tui_redisplay_source.
11233         * observable.h (source_styling_changed): New observable.
11234         * observable.c: Define source_styling_changed observable.
11235
11236 2019-03-13  Tom Tromey  <tromey@adacore.com>
11237
11238         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11239         (i386_gnu_nat_target::store_registers): Update.
11240         * target-debug.h (target_debug_print_std_string): New macro.
11241         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11242         * windows-tdep.c (display_one_tib): Update.
11243         * tui/tui-stack.c (tui_make_status_line): Update.
11244         * top.c (print_inferior_quit_action): Update.
11245         * thread.c (thr_try_catch_cmd): Update.
11246         (add_thread_with_info): Update.
11247         (thread_target_id_str): Update.
11248         (thr_try_catch_cmd): Update.
11249         (thread_command): Update.
11250         (thread_find_command): Update.
11251         * record-btrace.c (record_btrace_target::info_record)
11252         (record_btrace_resume_thread, record_btrace_target::resume)
11253         (record_btrace_cancel_resume, record_btrace_step_thread)
11254         (record_btrace_target::wait, record_btrace_target::wait)
11255         (record_btrace_target::wait, record_btrace_target::stop): Update.
11256         * progspace.c (print_program_space): Update.
11257         * process-stratum-target.c
11258         (process_stratum_target::thread_address_space): Update.
11259         * linux-fork.c (linux_fork_mourn_inferior)
11260         (detach_checkpoint_command, info_checkpoints_command)
11261         (linux_fork_context): Update.
11262         (linux_fork_detach): Update.
11263         (class scoped_switch_fork_info): Update.
11264         (delete_checkpoint_command): Update.
11265         * infrun.c (follow_fork_inferior): Update.
11266         (follow_fork_inferior): Update.
11267         (proceed_after_vfork_done): Update.
11268         (handle_vfork_child_exec_or_exit): Update.
11269         (follow_exec): Update.
11270         (displaced_step_prepare_throw): Update.
11271         (displaced_step_restore): Update.
11272         (start_step_over): Update.
11273         (resume_1): Update.
11274         (clear_proceed_status_thread): Update.
11275         (proceed): Update.
11276         (print_target_wait_results): Update.
11277         (do_target_wait): Update.
11278         (context_switch): Update.
11279         (stop_all_threads): Update.
11280         (restart_threads): Update.
11281         (finish_step_over): Update.
11282         (handle_signal_stop): Update.
11283         (switch_back_to_stepped_thread): Update.
11284         (keep_going_pass_signal): Update.
11285         (print_exited_reason): Update.
11286         (normal_stop): Update.
11287         * inferior.c (inferior_pid_to_str): Change return type.
11288         (print_selected_inferior): Update.
11289         (add_inferior): Update.
11290         (detach_inferior): Update.
11291         * dummy-frame.c (fprint_dummy_frames): Update.
11292         * dcache.c (dcache_info_1): Update.
11293         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11294         (btrace_fetch, btrace_clear): Update.
11295         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11296         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11297         type.
11298         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11299         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11300         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11301         * gdbarch.c, gdbarch.h: Rebuild.
11302         * gdbarch.sh (core_pid_to_str): Change return type.
11303         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11304         return type.
11305         (windows_nat_target::pid_to_str): Change return type.
11306         (windows_delete_thread): Update.
11307         (windows_nat_target::attach): Update.
11308         (windows_nat_target::files_info): Update.
11309         * target-delegates.c: Rebuild.
11310         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11311         return type.
11312         (sol_thread_target::pid_to_str): Change return type.
11313         * remote.c (class remote_target) <pid_to_str>: Change return
11314         type.
11315         (remote_target::pid_to_str): Change return type.
11316         (extended_remote_target::attach, remote_target::remote_stop_ns)
11317         (remote_target::remote_notif_remove_queued_reply)
11318         (remote_target::push_stop_reply, remote_target::disable_btrace):
11319         Update.
11320         (extended_remote_target::attach): Update.
11321         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11322         type.
11323         (gdbsim_target::pid_to_str): Change return type.
11324         * ravenscar-thread.c (struct ravenscar_thread_target)
11325         <pid_to_str>: Change return type.
11326         (ravenscar_thread_target::pid_to_str): Change return type.
11327         * procfs.c (class procfs_target) <pid_to_str>: Change return
11328         type.
11329         (procfs_target::pid_to_str): Change return type.
11330         (procfs_target::attach): Update.
11331         (procfs_target::detach): Update.
11332         (procfs_target::fetch_registers): Update.
11333         (procfs_target::store_registers): Update.
11334         (procfs_target::wait): Update.
11335         (procfs_target::files_info): Update.
11336         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11337         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11338         return type.
11339         (nto_procfs_target::pid_to_str): Change return type.
11340         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11341         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11342         return type.
11343         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11344         (exit_lwp): Update.
11345         (attach_proc_task_lwp_callback, get_detach_signal)
11346         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11347         (linux_nat_target::resume, wait_lwp, stop_callback)
11348         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11349         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11350         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11351         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11352         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11353         type.
11354         (inf_ptrace_target::attach): Update.
11355         (inf_ptrace_target::files_info): Update.
11356         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11357         type.
11358         (go32_nat_target::pid_to_str): Change return type.
11359         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11360         (gnu_nat_target::wait): Update.
11361         (gnu_nat_target::wait): Update.
11362         (gnu_nat_target::resume): Update.
11363         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11364         (fbsd_nat_target::wait): Update.
11365         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11366         type.
11367         (darwin_nat_target::attach): Update.
11368         * corelow.c (class core_target) <pid_to_str>: Change return type.
11369         (core_target::pid_to_str): Change return type.
11370         * target.c (normal_pid_to_str): Change return type.
11371         (default_pid_to_str): Likewise.
11372         (target_pid_to_str): Change return type.
11373         (target_translate_tls_address): Update.
11374         (target_announce_detach): Update.
11375         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11376         return type.
11377         (bsd_uthread_target::pid_to_str): Change return type.
11378         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11379         type.
11380         (bsd_kvm_target::pid_to_str): Change return type.
11381         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11382         return type.
11383         (aix_thread_target::pid_to_str): Change return type.
11384         * target.h (struct target_ops) <pid_to_str>: Change return type.
11385         (target_pid_to_str, normal_pid_to_str): Likewise.
11386         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11387         type.
11388         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11389         type.
11390         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11391         return type.
11392         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11393         type.
11394         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11395         type.
11396         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11397         return type.
11398
11399 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11400
11401         * NEWS: Mention that the new default MI version is 3.  Mention
11402         changes to the output of commands and events that deal with
11403         multi-location breakpoints.
11404         * breakpoint.c: Include "mi/mi-out.h".
11405         (print_one_breakpoint): Change output syntax if using MI version
11406         >= 3.
11407         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11408         New.
11409         (mi_multi_location_breakpoint_output_fixed): New.
11410         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11411         (mi_cmd_fix_multi_location_breakpoint_output): New.
11412         (mi_multi_location_breakpoint_output_fixed): New.
11413         * mi/mi-cmds.c (mi_cmds): Register command
11414         -fix-multi-location-breakpoint-output.
11415         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11416         interpreter "mi".
11417
11418 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11419
11420         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11421         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11422         instantiate mi_ui_out based on interpreter name.
11423         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11424         * mi/mi-main.c (mi_load_progress): Likewise.
11425
11426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11427
11428         * NEWS: Combine separate "New targets" sections for 8.3.
11429
11430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11431
11432         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11433         (ppcfbsd_init_abi): Install gdbarch
11434         "fetch_tls_load_module_address" and "get_thread_local_address"
11435         methods.
11436
11437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11438
11439         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11440         (riscv_fbsd_init_abi): Install gdbarch
11441         "fetch_tls_load_module_address" and "get_thread_local_address"
11442         methods.
11443
11444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11445
11446         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11447         (i386fbsd_init_abi): Install gdbarch
11448         "fetch_tls_load_module_address" and "get_thread_local_address"
11449         methods.
11450
11451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11452
11453         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11454         (amd64fbsd_init_abi): Install gdbarch
11455         "fetch_tls_load_module_address" and "get_thread_local_address"
11456         methods.
11457
11458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11459
11460         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11461         (struct fbsd_pspace_data): New type.
11462         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11463         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11464         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11465         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11466         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11467
11468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11469
11470         * gdbtypes.c (lookup_struct_elt): New function.
11471         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11472         * gdbtypes.h (struct struct_elt): New type.
11473         (lookup_struct_elt): New prototype.
11474
11475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11476
11477         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11478         remove disabled code block.
11479
11480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11481
11482         * gdbarch.sh (get_thread_local_address): New method.
11483         * gdbarch.h, gdbarch.c: Regenerate.
11484         * target.c (target_translate_tls_address): Use
11485         gdbarch_get_thread_local_address if present instead of
11486         target::get_thread_local_address.
11487
11488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11489
11490         * target.h (target::get_thread_local_address): Update comment.
11491
11492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11493
11494         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11495         objfile->separate_debug_objfile_backlink if not NULL.
11496
11497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11498
11499         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11500         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11501         (amd64bsd_store_inferior_registers): Likewise.
11502         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11503         Enable segment base registers.
11504         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11505         PT_GETFSBASE and PT_GETGSBASE.
11506         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11507         PT_SETGSBASE.
11508         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11509         segment base registers.
11510         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11511
11512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11513
11514         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11515         Update calls to i386_target_description to add 'segments'
11516         parameter.
11517         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11518         add segment base registers.
11519         * arch/i386.c (i386_create_target_description): Add 'segments'
11520         parameter to enable segment base registers.
11521         * arch/i386.h (i386_create_target_description): Likewise.
11522         * features/i386/32bit-segments.xml: New file.
11523         * features/i386/32bit-segments.c: Generate.
11524         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11525         call to i386_target_description to add 'segments' parameter.
11526         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11527         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11528         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11529         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11530         if feature is present.
11531         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11532         Add 'segments' parameter to call to i386_target_description.
11533         (i386_target_description): Add 'segments' parameter to enable
11534         segment base registers.
11535         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11536         to call to i386_target_description.
11537         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11538         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11539         Define I386_NUM_REGS.
11540         (i386_target_description): Add 'segments' parameter to enable
11541         segment base registers.
11542
11543 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11544
11545         PR/24325
11546         * source-cache.c: #undef open and close, to avoid unresolved
11547         externals during linking.
11548
11549 2019-03-12  Tom Tromey  <tromey@adacore.com>
11550
11551         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11552         const.  Add initializers.
11553         (_initialize_remote): Don't initialize ptid globals.
11554
11555 2019-03-12  Pedro Alves  <palves@redhat.com>
11556
11557         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11558
11559 2019-03-12  Pedro Alves  <palves@redhat.com>
11560
11561         * cp-name-parser.y (main): Remove unused 'len' variable.
11562
11563 2019-03-12  Tom Tromey  <tromey@adacore.com>
11564
11565         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11566         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11567
11568 2019-03-12  Tom Tromey  <tromey@adacore.com>
11569
11570         * linux-nat.c (iterate_over_lwps): Update.
11571         (stop_callback): Remove parameter.
11572         (stop_wait_callback, detach_callback, resume_set_callback)
11573         (select_singlestep_lwp_callback, set_ignore_sigint)
11574         (status_callback, resumed_callback, resume_clear_callback)
11575         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11576         data parameter.
11577         (linux_nat_target::detach, linux_nat_target::resume)
11578         (linux_stop_and_wait_all_lwps, select_event_lwp)
11579         (linux_nat_filter_event, linux_nat_wait_1)
11580         (linux_nat_target::kill, linux_nat_target::stop)
11581         (linux_nat_target::stop): Update.
11582         (linux_nat_resume_callback): Change type.
11583         (resume_stopped_resumed_lwps, count_events_callback)
11584         (select_event_lwp_callback): Likewise.
11585         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11586         * arm-linux-nat.c (struct update_registers_data): Remove.
11587         (update_registers_callback): Change type.
11588         (arm_linux_insert_hw_breakpoint1): Update.
11589         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11590         parameter.
11591         (x86_linux_dr_set_addr): Update.
11592         (x86_linux_dr_set_control): Update.
11593         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11594         (iterate_over_lwps): Use gdb::function_view.
11595         * nat/aarch64-linux-hw-point.c (struct
11596         aarch64_dr_update_callback_param): Remove.
11597         (debug_reg_change_callback): Change type.
11598         (aarch64_notify_debug_reg_change): Update.
11599         * s390-linux-nat.c (s390_refresh_per_info): Update.
11600
11601 2019-03-11  Tom Tromey  <tromey@adacore.com>
11602
11603         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11604         redundant assignment to "this_cu".
11605
11606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11607
11608         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11609
11610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11611
11612         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11613         from...
11614         (rank_one_type): ... this.
11615
11616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11617
11618         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11619         from...
11620         (rank_one_type): ... this.
11621
11622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11623
11624         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11625         from...
11626         (rank_one_type): ... this.
11627
11628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11629
11630         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11631         from...
11632         (rank_one_type): ... this.
11633
11634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11635
11636         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11637         from...
11638         (rank_one_type): ... this.
11639
11640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11641
11642         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11643         from...
11644         (rank_one_type): ... this.
11645
11646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11647
11648         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11649         from...
11650         (rank_one_type): ... this.
11651
11652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11653
11654         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11655         from...
11656         (rank_one_type): ... this.
11657
11658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11659
11660         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11661         from...
11662         (rank_one_type): ... this.
11663
11664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11665
11666         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11667         from...
11668         (rank_one_type): ... this.
11669
11670 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11671
11672         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11673         from...
11674         (rank_one_type): ... this.
11675
11676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11677
11678         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11679         from...
11680         (rank_one_type): ... this.
11681
11682 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11683
11684         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11685         inferior-events' shows the example events.
11686
11687 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11688
11689         Support styling on native MS-Windows console
11690
11691         PR/24315
11692         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11693         on MS-Windows if $TERM is not defined.
11694
11695         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11696
11697         * posix-hdep.c (gdb_console_fputs):
11698         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11699         functions.
11700         * ui-file.h (gdb_console_fputs): Add prototype.
11701
11702         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11703         back to fputs only if the former returns zero.
11704
11705 2019-03-07  Tom Tromey  <tom@tromey.com>
11706
11707         * symmisc.c (print_symbol_bcache_statistics): Update.
11708         (print_objfile_statistics): Update.
11709         * symfile.c (allocate_symtab): Update.
11710         * stabsread.c: Don't include bcache.h.
11711         * psymtab.h (struct psymbol_bcache): Don't declare.
11712         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11713         (psymbol_bcache_init, psymbol_bcache_free)
11714         (psymbol_bcache_get_bcache): Don't declare.
11715         * psymtab.c (struct psymbol_bcache): Remove.
11716         (psymtab_storage::psymtab_storage): Update.
11717         (psymtab_storage::~psymtab_storage): Update.
11718         (psymbol_bcache_init, psymbol_bcache_free)
11719         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11720         (add_psymbol_to_bcache): Update.
11721         (allocate_psymtab): Update.
11722         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11723         macro_cache>: No longer pointers.
11724         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11725         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11726         * macrotab.c (macro_bcache): Update.
11727         * macroexp.c: Don't include bcache.h.
11728         * gdbtypes.c (check_types_worklist): Update.
11729         (types_deeply_equal): Remove TRY/CATCH.  Update.
11730         * elfread.c (elf_symtab_read): Update.
11731         * dwarf2read.c: Don't include bcache.h.
11732         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11733         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11734         (print_bcache_statistics, bcache_memory_used): Don't declare.
11735         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11736         methods.  Rename all data members.
11737         * bcache.c (struct bcache): Move to bcache.h.
11738         (bcache::expand_hash_table): Rename from expand_hash_table.
11739         (bcache): Remove.
11740         (bcache::insert): Rename from bcache_full.
11741         (bcache::compare): Rename from bcache_compare.
11742         (bcache_xmalloc): Remove.
11743         (bcache::~bcache): Rename from bcache_xfree.
11744         (bcache::print_statistics): Rename from print_bcache_statistics.
11745         (bcache::memory_used): Rename from bcache_memory_used.
11746
11747 2019-03-07  Pedro Alves  <palves@redhat.com>
11748
11749         * infrun.c (normal_stop): Also check for
11750         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11751
11752 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11753
11754         * f-lang.c (value_from_host_double): Moved to...
11755         * value.c (value_from_host_double): ...here.
11756         * value.h (value_from_host_double): Declare.
11757         * guile/scm-math.c (vlscm_convert_typed_number): Use
11758         value_from_host_double.
11759         (vlscm_convert_number): Likewise.
11760         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11761         * python/py-value.c (convert_value_from_python): Likewise.
11762
11763 2019-03-06  Tom Tromey  <tom@tromey.com>
11764
11765         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11766
11767 2019-03-06  Tom Tromey  <tom@tromey.com>
11768
11769         * utils.h (free_current_contents): Don't declare.
11770         * utils.c (free_current_contents): Remove.
11771
11772 2019-03-06  Tom Tromey  <tom@tromey.com>
11773
11774         * top.c (quit_force): Update.
11775         * main.c (captured_command_loop): Update.
11776         * common/new-op.c (operator new): Update.
11777         * common/common-exceptions.c (struct catcher)
11778         <save_cleanup_chain>: Remove member.
11779         (exceptions_state_mc_init): Update.
11780         (exception_try_scope_entry): Return nullptr.
11781         (exception_try_scope_exit, exception_rethrow)
11782         (throw_exception_sjlj, throw_exception_cxx): Update.
11783         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11784         (all_cleanups, do_cleanups, discard_cleanups)
11785         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11786         (restore_cleanups, restore_final_cleanups): Don't declare.
11787         (do_final_cleanups): Remove parameter.
11788         * common/cleanups.c (cleanup_chain, make_cleanup)
11789         (make_cleanup_dtor, all_cleanups, do_cleanups)
11790         (discard_my_cleanups, discard_cleanups)
11791         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11792         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11793         (null_cleanup): Remove.
11794         (do_final_cleanups): Remove parameter.
11795
11796 2019-03-06  Tom Tromey  <tom@tromey.com>
11797
11798         * remote.c (remote_target::remote_parse_stop_reply): Use
11799         unique_xmalloc_ptr.
11800
11801 2019-03-06  Tom Tromey  <tom@tromey.com>
11802
11803         * stabsread.c (struct stabs_field_info): Rename from field_info.
11804         <list, fnlist>: Add initializers.
11805         <obstack>: New member.
11806         (read_member_functions, read_struct_fields, read_baseclasses):
11807         Allocate on obstack.  Don't use cleanups.
11808         (read_one_struct_field, read_member_functions, read_struct_fields)
11809         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11810         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11811         (read_struct_type): Update.
11812
11813 2019-03-06  Tom Tromey  <tom@tromey.com>
11814
11815         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11816         * common/filestuff.h (make_cleanup_close): Don't declare.
11817         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11818         Remove.
11819
11820 2019-03-06  Tom Tromey  <tom@tromey.com>
11821
11822         * solib-aix.c: Use make_scope_exit.
11823
11824 2019-03-06  Tom Tromey  <tom@tromey.com>
11825
11826         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11827         Use make_scope_exit.
11828
11829 2019-03-06  Tom Tromey  <tom@tromey.com>
11830
11831         * solib-svr4.c (disable_probes_interface): Remove parameter.
11832         (svr4_handle_solib_event): Use make_scope_exit.
11833
11834 2019-03-06  Tom Tromey  <tom@tromey.com>
11835
11836         * remote.c (struct stop_reply_deleter): Remove.
11837         (stop_reply_up): Update.
11838         (struct stop_reply): Derive from notif_event.  Don't typedef.
11839         <regcache>: Now a std::vector.
11840         (stop_reply_xfree): Remove.
11841         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11842         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11843         (remote_target::discard_pending_stop_replies): Use delete.
11844         (remote_target::remote_parse_stop_reply): Update.
11845         (remote_target::process_stop_reply): Update.
11846         * remote-notif.h (struct notif_event): Add virtual destructor.
11847         Remove "dtr" member.
11848         (struct notif_client) <alloc_event>: Return a unique_ptr.
11849         (notif_event_xfree): Don't declare.
11850         (notif_event_up): New typedef.
11851         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11852         (notif_event_xfree, do_notif_event_xfree): Remove.
11853         (remote_notif_state_xfree): Update.
11854
11855 2019-03-06  Tom Tromey  <tom@tromey.com>
11856
11857         * infrun.c (displaced_step_clear_cleanup): Now a
11858         forward_scope_exit type.
11859         (displaced_step_prepare_throw): Update.
11860         (displaced_step_fixup): Update.
11861
11862 2019-03-06  Tom Tromey  <tom@tromey.com>
11863
11864         * inferior.h (class inferior): Update comment.
11865         * gdbthread.h (class thread_info): Update comment.
11866
11867 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11868             Tom Tromey  <tom@tromey.com>
11869
11870         * stabsread.h (struct stab_section_list): Remove.
11871         (coffstab_build_psymtabs): Update.
11872         * dbxread.c (symbuf_sections): Now a std::vector.
11873         (sect_idx): New global.
11874         (fill_symbuf): Update.
11875         (coffstab_build_psymtabs): Change type of stabsects parameter.
11876         Update.
11877         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11878         std::vector.
11879         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11880         (coff_locate_sections): Update.
11881         (coff_symfile_read): Remove cleanups.  Update.
11882         (init_stringtab): Add storage parameter.
11883         (free_stringtab, free_stringtab_cleanup): Remove.
11884         (init_lineno): Add storage parameter.
11885         (free_linetab, free_linetab_cleanup): Remove.
11886
11887 2019-03-06  Pedro Alves  <palves@redhat.com>
11888
11889         * linux-fork.c (fork_info::clobber_regs): Delete.
11890         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11891         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11892         comment.  Adjust.
11893         (scoped_switch_fork_info::scoped_switch_fork_info)
11894         (checkpoint_command, linux_fork_context): Adjust
11895         fork_save_infrun_state calls.
11896
11897 2019-03-06  Pedro Alves  <palves@redhat.com>
11898
11899         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11900         (inf_has_multiple_threads): Return 'bool' and rewrite using
11901         inferior_info::threads().
11902
11903 2019-03-06  Pedro Alves  <palves@redhat.com>
11904
11905         * linux-fork.c: Include <list>.
11906         (fork_list): Now a std::list instance.
11907         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11908         (forks_exist_p, find_last_fork): Adjust.
11909         (new_fork): Delete.
11910         (one_fork_p): New.
11911         (add_fork): Adjust.
11912         (free_fork): Delete, folded into fork_info::~fork_info().
11913         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11914         Adjust.
11915         (init_fork_list): Delete.
11916         (linux_fork_killall, linux_fork_mourn_inferior)
11917         (linux_fork_detach, info_checkpoints_command): Adjust.
11918         (_initialize_linux_fork): No longer call init_fork_list.
11919
11920 2019-03-06  Pedro Alves  <palves@redhat.com>
11921
11922         * linux-fork.c (new_fork): New, split out of ...
11923         (add_fork): ... this.  Return void.  Move "first fork" special
11924         case from here, to ...
11925         (checkpoint_command): ... here.
11926         * linux-linux.h (add_fork): Return void.
11927
11928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11929
11930         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11931
11932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11933             Chris January  <chris.january@arm.com>
11934             David Lecomber  <david.lecomber@arm.com>
11935
11936         * f-exp.y: New token, UNOP_INTRINSIC.
11937         (exp): New pattern using UNOP_INTRINSIC token.
11938         (f77_keywords): Add 'abs' keyword.
11939         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11940         (value_from_host_double): New function.
11941         (evaluate_subexp_f): Support UNOP_ABS.
11942
11943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11944
11945         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11946         types.
11947
11948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11949
11950         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11951         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11952         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11953
11954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11955
11956         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11957
11958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11959             Chris January  <chris.january@arm.com>
11960
11961         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11962         * f-exp.y: Define 'KIND' token.
11963         (exp): New pattern for KIND expressions.
11964         (ptype): Handle types with a kind extension.
11965         (direct_abs_decl): Extend to spot kind extensions.
11966         (f77_keywords): Add 'kind' to the list.
11967         (push_kind_type): New function.
11968         (convert_to_kind_type): New function.
11969         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11970         * parse.c (operator_length_standard): Likewise.
11971         * parser-defs.h (enum type_pieces): Add tp_kind.
11972         * std-operator.def: Add UNOP_KIND.
11973
11974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11975
11976         * f-exp.y (f_parse): Set yydebug.
11977
11978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11979
11980         * f-lang.c (evaluate_subexp_f): New function.
11981         (exp_descriptor_f): New global.
11982         (f_language_defn): Use exp_descriptor_f instead of
11983         exp_descriptor_standard.
11984
11985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11986
11987         * f-exp.y (struct token): Add comments.
11988         (dot_ops): Remove uppercase versions and the end marker.
11989         (f77_keywords): Likewise.
11990         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11991         entries in the dot_ops array are case insensitive, and use
11992         strncasecmp to compare strings.  Also some whitespace cleanup in
11993         this area.  Similar for the f77_keywords array, except entries in
11994         this list might be case sensitive.
11995
11996 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11997
11998         * f-exp.y (struct f77_boolean_val): Add comments.
11999         (boolean_values): Remove uppercase versions, and end marker.
12000         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12001         and use strncasecmp to achieve case insensitivity.  Additionally,
12002         perform whitespace cleanup around this code.
12003
12004 2019-03-06  Tom Tromey  <tromey@adacore.com>
12005
12006         * remote-sim.c (gdbsim_target_open): Use result of
12007         gdb_argv::release.
12008
12009 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12010         Dirk Schubert  <dirk.schubert@arm.com>
12011         Chris January  <chris.january@arm.com>
12012
12013         * eval.c (evaluate_subexp_standard): Call Fortran argument
12014         wrapping logic.
12015         * f-lang.c (struct value): A value which can be passed into a
12016         Fortran function call.
12017         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12018         where appropriate.
12019         (struct type): Value ready for a Fortran function call.
12020         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12021         is needed.
12022         * f-lang.h (fortran_argument_convert): Declaration.
12023         (fortran_preserve_arg_pointer): Declaration.
12024         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12025
12026 2019-03-05  Tom Tromey  <tromey@adacore.com>
12027
12028         * python/py-prettyprint.c (print_string_repr): Remove #if.
12029         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12030
12031 2019-03-05  Tom Tromey  <tromey@adacore.com>
12032
12033         * target.c (the_dummy_target): Move later.  Change type to
12034         "dummy_target".
12035         (initialize_targets): Don't initialize the_dummy_target.
12036
12037 2019-03-05  Tom Tromey  <tromey@adacore.com>
12038
12039         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12040         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12041
12042 2019-03-05  Tom Tromey  <tromey@adacore.com>
12043
12044         * windows-nat.c (windows_nat_target::attach)
12045         (windows_nat_target::detach): Don't call gdb_flush.
12046         * valprint.c (generic_val_print, val_print, val_print_string):
12047         Don't call gdb_flush.
12048         * utils.c (defaulted_query): Don't call gdb_flush.
12049         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12050         * target.c (target_announce_detach): Don't call gdb_flush.
12051         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12052         * remote.c (extended_remote_target::attach): Don't call
12053         gdb_flush.
12054         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12055         * printcmd.c (do_examine): Don't call gdb_flush.
12056         (info_display_command): Don't call gdb_flush.
12057         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12058         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12059         * memattr.c (info_mem_command): Don't call gdb_flush.
12060         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12061         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12062         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12063         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12064         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12065         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12066         (gnu_nat_target::detach): Don't call gdb_flush.
12067         * f-valprint.c (f_val_print): Don't call gdb_flush.
12068         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12069         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12070         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12071         gdb_flush.
12072         * c-valprint.c (c_val_print): Don't call gdb_flush.
12073         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12074
12075 2019-03-05  Tom Tromey  <tromey@adacore.com>
12076
12077         * varobj.c (update_dynamic_varobj_children): Update.
12078         (install_default_visualizer): Use reset, not release.
12079         * value.c (set_internalvar): Update.
12080         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12081         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12082         ATTRIBUTE_UNUSED_RESULT.
12083
12084 2019-03-05  Tom Tromey  <tromey@adacore.com>
12085
12086         * remote.c (class scoped_remote_fd) <release>: Add
12087         ATTRIBUTE_UNUSED_RESULT.
12088
12089 2019-03-05  Tom Tromey  <tromey@adacore.com>
12090
12091         * macroexp.c (struct macro_buffer) <release>: Add
12092         ATTRIBUTE_UNUSED_RESULT.
12093
12094 2019-03-05  Tom Tromey  <tromey@adacore.com>
12095
12096         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12097         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12098         ATTRIBUTE_UNUSED_RESULT.
12099
12100 2019-03-05  Tom Tromey  <tromey@adacore.com>
12101
12102         * common/scoped_fd.h (class scoped_fd) <release>: Add
12103         ATTRIBUTE_UNUSED_RESULT.
12104
12105 2019-03-05  Tom Tromey  <tromey@adacore.com>
12106
12107         * parser-defs.h (struct parser_state) <release>: Add
12108         ATTRIBUTE_UNUSED_RESULT.
12109
12110 2019-03-05  Tom Tromey  <tromey@adacore.com>
12111
12112         * utils.h (class gdb_argv) <release>: Add
12113         ATTRIBUTE_UNUSED_RESULT.
12114         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12115
12116 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12117
12118         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12119         for-loop range, to avoid compiler warnings.
12120
12121         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12122         avoid compiler warnings about unused variables.
12123
12124         * NEWS: Mention end of support for native debugging on MS-Windows
12125         before XP.
12126
12127         PR gdb/24292
12128         * common/netstuff.c:
12129         * gdbserver/gdbreplay.c
12130         * gdbserver/remote-utils.c:
12131         * ser-tcp.c:
12132         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12133         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12134         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12135         'getaddrinfo' and 'freeaddrinfo' were not available before
12136         Windows XP, and mingw.org's MinGW headers by default define
12137         _WIN32_WINNT to 0x500.
12138
12139 2019-03-01  Gary Benson <gbenson@redhat.com>
12140
12141         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12142
12143 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12144             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12145
12146         PR gdb/8527
12147         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12148         set_sigint_trap, clear_sigint_trap.
12149
12150 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12151
12152         * target.c (target_detach): Clear the regcache and the
12153         frame cache.
12154
12155 2019-02-27  Pedro Alves  <palves@redhat.com>
12156
12157         * utils.c (set_screen_size): When we cap the height/width sizes,
12158         tweak the corresponding command variable to show "unlimited":
12159
12160 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12161             Pedro Alves  <palves@redhat.com>
12162
12163         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12164         before calling rl_set_screen_size.
12165
12166 2019-02-27  Tom Tromey  <tromey@adacore.com>
12167
12168         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12169         define.
12170         * python/py-value.c: Remove Python 2.4 workaround.
12171         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12172         workaround.
12173         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12174         Python 2.4 workaround.
12175         * python/python-internal.h: Remove Python 2.4 comment.
12176         (Py_ssize_t): Don't define.
12177         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12178         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12179         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12180         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12181         * python/python.c (do_start_initialization): Remove Python 2.4
12182         workaround.
12183         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12184         (print_children): Remove Python 2.4 workaround.
12185         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12186         workaround.
12187         (CHARBUFFERPROC_NAME): Remove.
12188         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12189         Python 2.4 workaround.
12190
12191 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12192
12193         * NEWS: Note minimum Python version.
12194
12195 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12196
12197         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12198         code from these functions.  Remove corresponding ifdefs.  Use
12199         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12200         Remove gotos and target of gotos.
12201         (infpy_search_memory): Likewise.
12202
12203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12204
12205         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12206         (hppa_gdbarch_init): Don't register deleted functions with
12207         gdbarch.
12208
12209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12210
12211         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12212         (h8300_unwind_sp): Delete.
12213         (h8300_dummy_id): Delete.
12214         (h8300_gdbarch_init): Don't register deleted functions with
12215         gdbarch.
12216
12217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12218
12219         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12220         (ft32_unwind_pc): Delete.
12221         (ft32_unwind_sp): Delete.
12222         (ft32_gdbarch_init): Don't register deleted functions with
12223         gdbarch.
12224
12225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12226
12227         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12228         (frv_unwind_pc): Delete.
12229         (frv_unwind_sp): Delete.
12230         (frv_gdbarch_init): Don't register deleted functions with
12231         gdbarch.
12232
12233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12234
12235         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12236         (riscv_unwind_pc): Delete.
12237         (riscv_unwind_sp): Delete.
12238         (riscv_gdbarch_init): Don't register deleted functions with
12239         gdbarch.
12240
12241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12242
12243         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12244         (csky_unwind_pc): Delete.
12245         (csky_unwind_sp): Delete.
12246         (csky_gdbarch_init): Don't register deleted functions with
12247         gdbarch.
12248
12249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12250
12251         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12252         (cris_unwind_pc): Delete.
12253         (cris_unwind_sp): Delete.
12254         (cris_gdbarch_init): Don't register deleted functions with
12255         gdbarch.
12256
12257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12258
12259         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12260         (bfin_unwind_pc): Delete.
12261         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12262
12263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12264
12265         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12266         (arm_unwind_pc): Delete.
12267         (arm_unwind_sp): Delete.
12268         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12269
12270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12273         (arc_unwind_pc): Delete.
12274         (arc_unwind_sp): Delete.
12275         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12276
12277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12278
12279         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12280         (alpha_unwind_pc): Delete.
12281         (alpha_gdbarch_init): Don't register deleted functions with
12282         gdbarch.
12283
12284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12285
12286         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12287         (aarch64_unwind_pc): Delete.
12288         (aarch64_unwind_sp): Delete.
12289         (aarch64_gdbarch_init): Don't register deleted functions with
12290         gdbarch.
12291
12292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12293
12294         * gdbtypes.c (type_align): Don't consider static members when
12295         computing structure alignment.
12296
12297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12298
12299         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12300         return 0 for other types.
12301         * arch-utils.c (default_type_align): Always return 0.
12302         * gdbarch.h: Regenerate.
12303         * gdbarch.sh (type_align): Extend comment.
12304         * gdbtypes.c (type_align): Add additional comments, always call
12305         gdbarch_type_align before applying the default rules.
12306         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12307         generic code will then apply a suitable default.
12308         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12309         types, return 0 for other types.
12310
12311 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12312
12313         * NEWS: Create a new section for the next release branch.
12314         Rename the section of the current branch, now that it has
12315         been cut.
12316
12317 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12318
12319         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12320         * version.in: Bump version to 8.3.50.DATE-git.
12321
12322 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12323
12324         * aix-thread.c (ptid_cmp): Remove unused variable.
12325         (get_signaled_thread): Likewise.
12326         (store_regs_user_thread): Likewise.
12327         (store_regs_kernel_thread): Likewise.
12328         (fetch_regs_kernel_thread): Remove shadowed variable.
12329
12330 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12331
12332         * features/riscv/32bit-cpu.xml: Add register numbers.
12333         * features/riscv/32bit-fpu.c: Regenerate.
12334         * features/riscv/32bit-fpu.xml: Add register numbers.
12335         * features/riscv/64bit-cpu.xml: Add register numbers.
12336         * features/riscv/64bit-fpu.c: Regenerate.
12337         * features/riscv/64bit-fpu.xml: Add register numbers.
12338
12339 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12340
12341         * NEWS: Mention two argument form of gdb.Value constructor.
12342         * python/py-value.c (convert_buffer_and_type_to_value): New
12343         function.
12344         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12345         Add support for handling an optional second argument.  Call
12346         convert_buffer_and_type_to_value as appropriate.
12347         * python/python-internal.h (Py_buffer_deleter): New struct.
12348         (Py_buffer_up): New typedef.
12349
12350 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12351
12352         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12353         instead of releasing ownership.
12354
12355 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12356
12357         * dwarf2read.c (open_and_init_dwp_file): Call
12358         elf_numsections instead of bfd_count_sections to initialize
12359         dwp_file->num_sections.
12360
12361 2019-02-25  Tom Tromey  <tromey@adacore.com>
12362
12363         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12364
12365 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12366
12367         * gcore.in: Add '--readnever' option when invoking GDB.
12368
12369 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12370
12371         * MAINTAINERS: Update my email address.
12372
12373 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12374
12375         * build-id.c (build_id_to_debug_bfd_1): New function.
12376         (build_id_to_debug_bfd): Look for separate debug file in
12377         sysroot.
12378
12379 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12380
12381         * gdbarch.sh: Update the copyright year range that is placed into
12382         generated files.
12383
12384 2019-02-22  Keith Seitz  <keiths@redhat.com>
12385
12386         PR symtab/23853
12387         * linespec.c (create_sals_line_offset): Search for the default
12388         symtab's filename instead of its fullname.
12389
12390 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12391
12392         * NEWS: Update style defaults.
12393
12394 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12395
12396         * main.c (captured_main_1): Disable styling in batch mode.
12397
12398 2019-02-20  Tom Tromey  <tom@tromey.com>
12399
12400         * symtab.c (symtab_symbol_info): Fix typos.
12401
12402 2019-02-20  Tom Tromey  <tromey@adacore.com>
12403
12404         * findcmd.c (_initialize_mem_search): Use upper case for
12405         metasyntactic variables.
12406
12407 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12408
12409         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12410         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12411
12412 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12413
12414         * top.h (source_file_name): Change to std::string.
12415         * top.c (source_file_name): Likewise.
12416         (command_line_input): Adjust.
12417         * cli/cli-script.c (script_from_file): Adjust.
12418
12419 2019-02-19  Tom Tromey  <tromey@adacore.com>
12420
12421         * ravenscar-thread.c
12422         (ravenscar_thread_target::update_thread_list): Don't call
12423         ada_build_task_list.
12424         * ada-lang.h (ada_build_task_list): Don't declare.
12425         * ada-tasks.c (struct ada_tasks_inferior_data)
12426         <task_list_valid_p>: Now bool.
12427         (read_known_tasks, ada_task_list_changed)
12428         (ada_tasks_invalidate_inferior_data): Update.
12429         (read_known_tasks_array): Return bool.
12430         (read_known_tasks_list): Likewise.
12431         (read_known_tasks): Return void.
12432         (ada_build_task_list): Now static.
12433
12434 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12435
12436         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12437         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12438
12439 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12440
12441         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12442         variant for ada_tasks_pspace_data_handle and
12443         ada_tasks_inferior_data_handle.
12444         (ada_tasks_pspace_data_cleanup): New function.
12445         (ada_tasks_inferior_data_cleanup): New function.
12446
12447 2019-02-17  Tom Tromey  <tom@tromey.com>
12448
12449         * macrotab.h (macro_source_fullname): Return a std::string.
12450         * macrotab.c (macro_include, check_for_redefinition)
12451         (macro_undef, macro_lookup_definition, foreach_macro)
12452         (foreach_macro_in_scope): Update.
12453         (macro_source_fullname): Return a std::string.
12454         * macrocmd.c (show_pp_source_pos): Update.
12455
12456 2019-02-17  Tom Tromey  <tom@tromey.com>
12457
12458         * macrocmd.c (show_pp_source_pos): Style the file names.
12459
12460 2019-02-17  Tom Tromey  <tom@tromey.com>
12461
12462         PR tui/24197:
12463         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12464
12465 2019-02-17  Tom Tromey  <tom@tromey.com>
12466
12467         * ada-lang.c (user_select_syms): Use filtered printing.
12468         * utils.c (wrap_style): New global.
12469         (desired_style): Remove.
12470         (emit_style_escape): Add stream parameter.
12471         (set_output_style, reset_terminal_style, prompt_for_continue):
12472         Update.
12473         (flush_wrap_buffer): Only flush gdb_stdout.
12474         (wrap_here): Set wrap_style.
12475         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12476         treat escape sequences as a character.  Change when wrap buffer is
12477         flushed.
12478         (fputs_styled): Do not set the output style when the default is
12479         requested.
12480         * ui-style.h (struct ui_file_style) <is_default>: New method.
12481         * source.c (print_source_lines_base): Emit escape sequences in one
12482         piece.
12483
12484 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12485
12486         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12487         integers and enumeration types.
12488
12489 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12490
12491         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12492         instead of lookup_symbol_in_language
12493         (do_exact_match): New function.
12494         (ada_get_symbol_name_matcher): Return do_exact_match when
12495         doing a verbatim match.
12496
12497 2019-02-15  Tom Tromey  <tromey@adacore.com>
12498
12499         * ravenscar-thread.c (ravenscar_thread_target::resume)
12500         (ravenscar_thread_target::wait): Special case wildcard requests.
12501
12502 2019-02-15  Tom Tromey  <tromey@adacore.com>
12503
12504         * ravenscar-thread.c (base_ptid): Remove.
12505         (struct ravenscar_thread_target) <close>: New method.
12506         <m_base_ptid>: New member.
12507         <update_inferior_ptid, active_task, task_is_currently_active,
12508         runtime_initialized>: Declare methods.
12509         <ravenscar_thread_target>: Add constructor.
12510         (ravenscar_thread_target::task_is_currently_active)
12511         (ravenscar_thread_target::update_inferior_ptid)
12512         (ravenscar_runtime_initialized): Rename.  Now methods.
12513         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12514         (ravenscar_thread_target::update_thread_list): Update.
12515         (ravenscar_thread_target::active_task): Now method.
12516         (ravenscar_thread_target::store_registers)
12517         (ravenscar_thread_target::prepare_to_store)
12518         (ravenscar_thread_target::prepare_to_store)
12519         (ravenscar_thread_target::mourn_inferior): Update.
12520         (ravenscar_inferior_created): Use "new" to create target.
12521         (ravenscar_thread_target::get_ada_task_ptid): Update.
12522         (_initialize_ravenscar): Don't initialize base_ptid.
12523         (ravenscar_ops): Remove global.
12524
12525 2019-02-15  Tom Tromey  <tromey@adacore.com>
12526
12527         * target.h (push_target): Declare new overload.
12528         * target.c (push_target): New overload, taking an rvalue reference.
12529         * remote.c (remote_target::open_1): Use push_target overload.
12530         * corelow.c (core_target_open): Use push_target overload.
12531
12532 2019-02-15  Tom Tromey  <tromey@adacore.com>
12533
12534         * ravenscar-thread.c (is_ravenscar_task)
12535         (ravenscar_task_is_currently_active): Return bool.
12536         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12537         (_initialize_ravenscar): Remove "(void)".
12538         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12539         Return bool.
12540
12541 2019-02-15  Tom Tromey  <tromey@adacore.com>
12542
12543         * ravenscar-thread.c (ravenscar_runtime_initializer)
12544         (has_ravenscar_runtime, get_running_thread_id)
12545         (ravenscar_thread_target::resume): Fix indentation.
12546
12547 2019-02-15  Tom Tromey  <tromey@adacore.com>
12548
12549         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12550         from ravenscar_arch_ops.
12551         (sparc_ravenscar_ops::fetch_registers)
12552         (sparc_ravenscar_ops::store_registers): Now methods.
12553         (sparc_ravenscar_prepare_to_store): Remove.
12554         (sparc_ravenscar_ops): Redefine.
12555         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12556         methods and destructor.  Remove members.
12557         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12558         (ravenscar_thread_target::store_registers)
12559         (ravenscar_thread_target::prepare_to_store): Update.
12560         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12561         Remove.
12562         (struct ppc_ravenscar_powerpc_ops): Derive from
12563         ravenscar_arch_ops.
12564         (ppc_ravenscar_powerpc_ops::fetch_registers)
12565         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12566         (ppc_ravenscar_powerpc_ops): Redefine.
12567         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12568         (ppc_ravenscar_e500_ops::fetch_registers)
12569         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12570         (ppc_ravenscar_e500_ops): Redefine.
12571         * aarch64-ravenscar-thread.c
12572         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12573         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12574         (aarch64_ravenscar_fetch_registers)
12575         (aarch64_ravenscar_store_registers): Now methods.
12576         (aarch64_ravenscar_ops): Redefine.
12577
12578 2019-02-15  Tom Tromey  <tromey@adacore.com>
12579
12580         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12581         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12582         (ravenscar_thread_target::stopped_by_watchpoint)
12583         (ravenscar_thread_target::stopped_data_address)
12584         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12585
12586 2019-02-15  Tom Tromey  <tromey@adacore.com>
12587
12588         * ravenscar-thread.c: Fix some typos.
12589
12590 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12591             Tom Tromey  <tromey@adacore.com>
12592
12593         * ada-lang.c (ada_exception_sal): Change addr_string to a
12594         std::string.
12595         (create_ada_exception_catchpoint): Update.
12596
12597 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12598             Tom Tromey  <tromey@adacore.com>
12599
12600         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12601         (bp_location_ops): Remove.
12602         (base_breakpoint_allocate_location): Update.
12603         (free_bp_location): Update.
12604         * ada-lang.c (class ada_catchpoint_location)
12605         <ada_catchpoint_location>: Remove ops parameter.
12606         (ada_catchpoint_location_dtor): Remove.
12607         (ada_catchpoint_location_ops): Remove.
12608         (allocate_location_exception): Update.
12609         * breakpoint.h (struct bp_location_ops): Remove.
12610         (class bp_location) <bp_location>: Remove bp_location_ops
12611         parameter.
12612         <~bp_location>: Add destructor.
12613         <ops>: Remove.
12614
12615 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12616             Pedro Alves  <palves@redhat.com>
12617
12618         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12619         'PATH_MAX'.
12620
12621 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12622             Samuel Thibault  <samuel.thibault@gnu.org>
12623             Thomas Schwinge  <thomas@codesourcery.com>
12624
12625         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12626         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12627
12628 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12629
12630         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12631         (check_empty): Use "const char *".
12632
12633         * gnu-nat.c (gnu_nat_target::detach): Instead of
12634         'detach_inferior (pid)' call
12635         'detach_inferior (find_inferior_pid (pid))'.
12636
12637         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12638         'nat/fork-inferior.o'.
12639         * gnu-nat.c: #include "nat/fork-inferior.h".
12640
12641         * gnu-nat.c (gnu_nat_target::detach): Instead of
12642         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12643         * gnu-nat.h: #include "inf-child.h".
12644         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12645         'i386_gnu_nat_target::fetch_registers'.
12646         (gnu_store_registers): Rename/move to
12647         'i386_gnu_nat_target::store_registers'.
12648
12649         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12650         * gnu-nat.h (mach_thread_info): New function.
12651         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12652
12653         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12654
12655 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12656
12657         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12658
12659 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12660
12661         * windows-nat.c (windows_add_thread): Add new parameter
12662         "main_thread_p" with default value set to false.  Update
12663         function documentation as well as all callers.
12664         (windows_delete_thread): Likewise.
12665         (fake_create_process): Update call to windows_add_thread.
12666         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12667         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12668         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12669         call to windows_delete_thread.
12670
12671 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12672
12673         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12674
12675 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12676
12677         * symfile.c (find_separate_debug_file): Use canonical path of
12678         sysroot with child_path instead of gdb_sysroot if it is valid.
12679
12680 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12681
12682         * symfile.c (find_separate_debug_file): Use child_path to
12683         determine if an object file is under a sysroot.
12684
12685 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12686
12687         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12688         unittests/child-path-selftests.c.
12689         * common/pathstuff.c (child_path): New function.
12690         * common/pathstuff.h (child_path): New prototype.
12691         * unittests/child-path-selftests.c: New file.
12692
12693 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12694
12695         * symfile.c (find_separate_debug_file): Look for separate debug
12696         files in debug directories under the sysroot.
12697
12698 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12699
12700         * symtab.h (struct minimal_symbol data_p): New const method.
12701         (struct minimal_symbol text_p): Likewise.
12702         * symtab.c (output_source_filename): Use file name style
12703         to print file name.
12704         (print_symbol_info): Likewise.
12705         (print_msymbol_info): Use address style to print addresses.
12706         Use function name style to print executable text symbols.
12707         (expand_symtab_containing_pc): Use data_p.
12708         (find_pc_sect_compunit_symtab): Likewise.
12709
12710 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12711
12712         * breakpoint.c (describe_other_breakpoints): Use address style
12713         to print addresses.
12714         (say_where): Likewise.
12715
12716 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12717
12718         * ada-typeprint.c (print_func_type): Print function name
12719         style to print function name.
12720         * c-typeprint.c (c_print_type_1): Likewise.
12721
12722 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12723
12724         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12725         for execve.
12726
12727 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12728
12729         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12730         type_stack.
12731
12732 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12733
12734         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12735         TYPE_CODE_REF types.
12736
12737 2019-02-08  Jim Wilson  <jimw@sifive.com>
12738
12739         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12740         (riscv_linux_fregset): New.
12741         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12742
12743 2019-02-07  Tom Tromey  <tom@tromey.com>
12744
12745         * thread.c (thread_cancel_execution_command): Update.
12746         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12747         methods.
12748         (struct thread_fsm_ops): Remove.
12749         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12750         (thread_fsm_should_stop, thread_fsm_return_value)
12751         (thread_fsm_set_finished, thread_fsm_finished_p)
12752         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12753         Don't declare.
12754         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12755         * infrun.c (clear_proceed_status_thread)
12756         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12757         (print_stop_event): Update.
12758         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12759         Add constructor.
12760         (step_command_fsm_ops): Remove.
12761         (new_step_command_fsm): Remove.
12762         (step_1): Update.
12763         (step_command_fsm::should_stop): Rename from
12764         step_command_fsm_should_stop.
12765         (step_command_fsm::clean_up): Rename from
12766         step_command_fsm_clean_up.
12767         (step_command_fsm::do_async_reply_reason): Rename from
12768         step_command_fsm_async_reply_reason.
12769         (struct until_next_fsm): Inherit from thread_fsm.  Add
12770         constructor.
12771         (until_next_fsm_ops): Remove.
12772         (new_until_next_fsm): Remove.
12773         (until_next_fsm::should_stop): Rename from
12774         until_next_fsm_should_stop.
12775         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12776         (until_next_fsm::do_async_reply_reason): Rename from
12777         until_next_fsm_async_reply_reason.
12778         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12779         constructor.  Change type of breakpoint.
12780         (finish_command_fsm_ops): Remove.
12781         (new_finish_command_fsm): Remove.
12782         (finish_command_fsm::should_stop): Rename from
12783         finish_command_fsm_should_stop.
12784         (finish_command_fsm::clean_up): Rename from
12785         finish_command_fsm_clean_up.
12786         (finish_command_fsm::return_value): Rename from
12787         finish_command_fsm_return_value.
12788         (finish_command_fsm::do_async_reply_reason): Rename from
12789         finish_command_fsm_async_reply_reason.
12790         (finish_command): Update.
12791         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12792         Add constructor.
12793         (call_thread_fsm_ops): Remove.
12794         (call_thread_fsm::call_thread_fsm): Rename from
12795         new_call_thread_fsm.
12796         (call_thread_fsm::should_stop): Rename from
12797         call_thread_fsm_should_stop.
12798         (call_thread_fsm::should_notify_stop): Rename from
12799         call_thread_fsm_should_notify_stop.
12800         (run_inferior_call, call_function_by_hand_dummy): Update.
12801         * cli/cli-interp.c (should_print_stop_to_console): Update.
12802         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12803         Add constructor.  Change type of location_breakpoint,
12804         caller_breakpoint.
12805         (until_break_fsm_ops): Remove.
12806         (new_until_break_fsm): Remove.
12807         (until_break_fsm::should_stop): Rename from
12808         until_break_fsm_should_stop.
12809         (until_break_fsm::clean_up): Rename from
12810         until_break_fsm_clean_up.
12811         (until_break_fsm::do_async_reply_reason): Rename from
12812         until_break_fsm_async_reply_reason.
12813         (until_break_command): Update.
12814         * thread-fsm.c: Remove.
12815         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12816
12817 2019-02-07  Tom Tromey  <tom@tromey.com>
12818
12819         * yy-remap.h: Add include guard.
12820         * xtensa-tdep.h: Add include guard.
12821         * xcoffread.h: Rename include guard.
12822         * varobj-iter.h: Add include guard.
12823         * tui/tui.h: Rename include guard.
12824         * tui/tui-winsource.h: Rename include guard.
12825         * tui/tui-wingeneral.h: Rename include guard.
12826         * tui/tui-windata.h: Rename include guard.
12827         * tui/tui-win.h: Rename include guard.
12828         * tui/tui-stack.h: Rename include guard.
12829         * tui/tui-source.h: Rename include guard.
12830         * tui/tui-regs.h: Rename include guard.
12831         * tui/tui-out.h: Rename include guard.
12832         * tui/tui-layout.h: Rename include guard.
12833         * tui/tui-io.h: Rename include guard.
12834         * tui/tui-hooks.h: Rename include guard.
12835         * tui/tui-file.h: Rename include guard.
12836         * tui/tui-disasm.h: Rename include guard.
12837         * tui/tui-data.h: Rename include guard.
12838         * tui/tui-command.h: Rename include guard.
12839         * tic6x-tdep.h: Add include guard.
12840         * target/waitstatus.h: Rename include guard.
12841         * target/wait.h: Rename include guard.
12842         * target/target.h: Rename include guard.
12843         * target/resume.h: Rename include guard.
12844         * target-float.h: Rename include guard.
12845         * stabsread.h: Add include guard.
12846         * rs6000-tdep.h: Add include guard.
12847         * riscv-fbsd-tdep.h: Add include guard.
12848         * regformats/regdef.h: Rename include guard.
12849         * record.h: Rename include guard.
12850         * python/python.h: Rename include guard.
12851         * python/python-internal.h: Rename include guard.
12852         * python/py-stopevent.h: Rename include guard.
12853         * python/py-ref.h: Rename include guard.
12854         * python/py-record.h: Rename include guard.
12855         * python/py-record-full.h: Rename include guard.
12856         * python/py-record-btrace.h: Rename include guard.
12857         * python/py-instruction.h: Rename include guard.
12858         * python/py-events.h: Rename include guard.
12859         * python/py-event.h: Rename include guard.
12860         * procfs.h: Add include guard.
12861         * proc-utils.h: Add include guard.
12862         * p-lang.h: Add include guard.
12863         * or1k-tdep.h: Rename include guard.
12864         * observable.h: Rename include guard.
12865         * nto-tdep.h: Rename include guard.
12866         * nat/x86-linux.h: Rename include guard.
12867         * nat/x86-linux-dregs.h: Rename include guard.
12868         * nat/x86-gcc-cpuid.h: Add include guard.
12869         * nat/x86-dregs.h: Rename include guard.
12870         * nat/x86-cpuid.h: Rename include guard.
12871         * nat/ppc-linux.h: Rename include guard.
12872         * nat/mips-linux-watch.h: Rename include guard.
12873         * nat/linux-waitpid.h: Rename include guard.
12874         * nat/linux-ptrace.h: Rename include guard.
12875         * nat/linux-procfs.h: Rename include guard.
12876         * nat/linux-osdata.h: Rename include guard.
12877         * nat/linux-nat.h: Rename include guard.
12878         * nat/linux-namespaces.h: Rename include guard.
12879         * nat/linux-btrace.h: Rename include guard.
12880         * nat/glibc_thread_db.h: Rename include guard.
12881         * nat/gdb_thread_db.h: Rename include guard.
12882         * nat/gdb_ptrace.h: Rename include guard.
12883         * nat/fork-inferior.h: Rename include guard.
12884         * nat/amd64-linux-siginfo.h: Rename include guard.
12885         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12886         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12887         * nat/aarch64-linux.h: Rename include guard.
12888         * nat/aarch64-linux-hw-point.h: Rename include guard.
12889         * mn10300-tdep.h: Add include guard.
12890         * mips-linux-tdep.h: Add include guard.
12891         * mi/mi-parse.h: Rename include guard.
12892         * mi/mi-out.h: Rename include guard.
12893         * mi/mi-main.h: Rename include guard.
12894         * mi/mi-interp.h: Rename include guard.
12895         * mi/mi-getopt.h: Rename include guard.
12896         * mi/mi-console.h: Rename include guard.
12897         * mi/mi-common.h: Rename include guard.
12898         * mi/mi-cmds.h: Rename include guard.
12899         * mi/mi-cmd-break.h: Rename include guard.
12900         * m2-lang.h: Add include guard.
12901         * location.h: Rename include guard.
12902         * linux-record.h: Rename include guard.
12903         * linux-nat.h: Add include guard.
12904         * linux-fork.h: Add include guard.
12905         * i386-darwin-tdep.h: Rename include guard.
12906         * hppa-linux-offsets.h: Add include guard.
12907         * guile/guile.h: Rename include guard.
12908         * guile/guile-internal.h: Rename include guard.
12909         * gnu-nat.h: Rename include guard.
12910         * gdb-stabs.h: Rename include guard.
12911         * frv-tdep.h: Add include guard.
12912         * f-lang.h: Add include guard.
12913         * event-loop.h: Add include guard.
12914         * darwin-nat.h: Rename include guard.
12915         * cp-abi.h: Rename include guard.
12916         * config/sparc/nm-sol2.h: Rename include guard.
12917         * config/nm-nto.h: Rename include guard.
12918         * config/nm-linux.h: Add include guard.
12919         * config/i386/nm-i386gnu.h: Rename include guard.
12920         * config/djgpp/nl_types.h: Rename include guard.
12921         * config/djgpp/langinfo.h: Rename include guard.
12922         * compile/gcc-cp-plugin.h: Add include guard.
12923         * compile/gcc-c-plugin.h: Add include guard.
12924         * compile/compile.h: Rename include guard.
12925         * compile/compile-object-run.h: Rename include guard.
12926         * compile/compile-object-load.h: Rename include guard.
12927         * compile/compile-internal.h: Rename include guard.
12928         * compile/compile-cplus.h: Rename include guard.
12929         * compile/compile-c.h: Rename include guard.
12930         * common/xml-utils.h: Rename include guard.
12931         * common/x86-xstate.h: Rename include guard.
12932         * common/version.h: Rename include guard.
12933         * common/vec.h: Rename include guard.
12934         * common/tdesc.h: Rename include guard.
12935         * common/selftest.h: Rename include guard.
12936         * common/scoped_restore.h: Rename include guard.
12937         * common/scoped_mmap.h: Rename include guard.
12938         * common/scoped_fd.h: Rename include guard.
12939         * common/safe-iterator.h: Rename include guard.
12940         * common/run-time-clock.h: Rename include guard.
12941         * common/refcounted-object.h: Rename include guard.
12942         * common/queue.h: Rename include guard.
12943         * common/ptid.h: Rename include guard.
12944         * common/print-utils.h: Rename include guard.
12945         * common/preprocessor.h: Rename include guard.
12946         * common/pathstuff.h: Rename include guard.
12947         * common/observable.h: Rename include guard.
12948         * common/netstuff.h: Rename include guard.
12949         * common/job-control.h: Rename include guard.
12950         * common/host-defs.h: Rename include guard.
12951         * common/gdb_wait.h: Rename include guard.
12952         * common/gdb_vecs.h: Rename include guard.
12953         * common/gdb_unlinker.h: Rename include guard.
12954         * common/gdb_unique_ptr.h: Rename include guard.
12955         * common/gdb_tilde_expand.h: Rename include guard.
12956         * common/gdb_sys_time.h: Rename include guard.
12957         * common/gdb_string_view.h: Rename include guard.
12958         * common/gdb_splay_tree.h: Rename include guard.
12959         * common/gdb_setjmp.h: Rename include guard.
12960         * common/gdb_ref_ptr.h: Rename include guard.
12961         * common/gdb_optional.h: Rename include guard.
12962         * common/gdb_locale.h: Rename include guard.
12963         * common/gdb_assert.h: Rename include guard.
12964         * common/filtered-iterator.h: Rename include guard.
12965         * common/filestuff.h: Rename include guard.
12966         * common/fileio.h: Rename include guard.
12967         * common/environ.h: Rename include guard.
12968         * common/common-utils.h: Rename include guard.
12969         * common/common-types.h: Rename include guard.
12970         * common/common-regcache.h: Rename include guard.
12971         * common/common-inferior.h: Rename include guard.
12972         * common/common-gdbthread.h: Rename include guard.
12973         * common/common-exceptions.h: Rename include guard.
12974         * common/common-defs.h: Rename include guard.
12975         * common/common-debug.h: Rename include guard.
12976         * common/cleanups.h: Rename include guard.
12977         * common/buffer.h: Rename include guard.
12978         * common/btrace-common.h: Rename include guard.
12979         * common/break-common.h: Rename include guard.
12980         * cli/cli-utils.h: Rename include guard.
12981         * cli/cli-style.h: Rename include guard.
12982         * cli/cli-setshow.h: Rename include guard.
12983         * cli/cli-script.h: Rename include guard.
12984         * cli/cli-interp.h: Rename include guard.
12985         * cli/cli-decode.h: Rename include guard.
12986         * cli/cli-cmds.h: Rename include guard.
12987         * charset-list.h: Add include guard.
12988         * buildsym-legacy.h: Rename include guard.
12989         * bfin-tdep.h: Add include guard.
12990         * ax.h: Rename include guard.
12991         * arm-linux-tdep.h: Add include guard.
12992         * arm-fbsd-tdep.h: Add include guard.
12993         * arch/xtensa.h: Rename include guard.
12994         * arch/tic6x.h: Add include guard.
12995         * arch/i386.h: Add include guard.
12996         * arch/arm.h: Rename include guard.
12997         * arch/arm-linux.h: Rename include guard.
12998         * arch/arm-get-next-pcs.h: Rename include guard.
12999         * arch/amd64.h: Add include guard.
13000         * arch/aarch64-insn.h: Rename include guard.
13001         * arch-utils.h: Rename include guard.
13002         * annotate.h: Add include guard.
13003         * amd64-darwin-tdep.h: Rename include guard.
13004         * aarch64-linux-tdep.h: Add include guard.
13005         * aarch64-fbsd-tdep.h: Add include guard.
13006         * aarch32-linux-nat.h: Add include guard.
13007
13008 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13009
13010         * macrotab.c (macro_define_internal): New function that
13011         factorizes macro_define_object_internal and macro_define_function
13012         code.
13013         (macro_define_object_internal): Use macro_define_internal.
13014         (macro_define_function): Likewise.
13015
13016 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13017
13018         * macrocmd.c (extract_identifier): Return
13019         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13020         callers.
13021
13022 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13023
13024         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13025
13026 2019-02-05  Tom Tromey  <tom@tromey.com>
13027
13028         * target.c (target_stack::unpush): Move assertion earlier.
13029
13030 2019-01-30  Tom Tromey  <tom@tromey.com>
13031
13032         PR python/23615:
13033         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13034         (gdbpy_parse_and_eval): Likewise.
13035         * python/python-internal.h (gdbpy_allow_threads): New class.
13036
13037 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13038
13039         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13040         (aarch64_fbsd_fpregmap): Move earlier.
13041         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13042         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13043         instead of individual calls to trad_frame_set_reg_addr.
13044         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13045         earlier.
13046         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13047         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13048         instead of individual calls to trad_frame_set_reg_addr.
13049
13050 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13051
13052         * CONTRIBUTE: Replace contribution list with wiki link.
13053
13054 2019-01-25  Tom Tromey  <tom@tromey.com>
13055
13056         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13057
13058 2019-01-25  Tom Tromey  <tom@tromey.com>
13059
13060         * xtensa-linux-nat.c: Fix common/ includes.
13061         * xml-support.h: Fix common/ includes.
13062         * xml-support.c: Fix common/ includes.
13063         * x86-linux-nat.c: Fix common/ includes.
13064         * windows-nat.c: Fix common/ includes.
13065         * varobj.h: Fix common/ includes.
13066         * varobj.c: Fix common/ includes.
13067         * value.c: Fix common/ includes.
13068         * valops.c: Fix common/ includes.
13069         * utils.c: Fix common/ includes.
13070         * unittests/xml-utils-selftests.c: Fix common/ includes.
13071         * unittests/utils-selftests.c: Fix common/ includes.
13072         * unittests/unpack-selftests.c: Fix common/ includes.
13073         * unittests/tracepoint-selftests.c: Fix common/ includes.
13074         * unittests/style-selftests.c: Fix common/ includes.
13075         * unittests/string_view-selftests.c: Fix common/ includes.
13076         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13077         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13078         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13079         * unittests/rsp-low-selftests.c: Fix common/ includes.
13080         * unittests/parse-connection-spec-selftests.c: Fix common/
13081         includes.
13082         * unittests/optional-selftests.c: Fix common/ includes.
13083         * unittests/offset-type-selftests.c: Fix common/ includes.
13084         * unittests/observable-selftests.c: Fix common/ includes.
13085         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13086         * unittests/memrange-selftests.c: Fix common/ includes.
13087         * unittests/memory-map-selftests.c: Fix common/ includes.
13088         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13089         * unittests/function-view-selftests.c: Fix common/ includes.
13090         * unittests/environ-selftests.c: Fix common/ includes.
13091         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13092         * unittests/common-utils-selftests.c: Fix common/ includes.
13093         * unittests/cli-utils-selftests.c: Fix common/ includes.
13094         * unittests/array-view-selftests.c: Fix common/ includes.
13095         * ui-file.c: Fix common/ includes.
13096         * tui/tui-io.c: Fix common/ includes.
13097         * tracepoint.h: Fix common/ includes.
13098         * tracepoint.c: Fix common/ includes.
13099         * tracefile-tfile.c: Fix common/ includes.
13100         * top.h: Fix common/ includes.
13101         * top.c: Fix common/ includes.
13102         * thread.c: Fix common/ includes.
13103         * target/waitstatus.h: Fix common/ includes.
13104         * target/waitstatus.c: Fix common/ includes.
13105         * target.h: Fix common/ includes.
13106         * target.c: Fix common/ includes.
13107         * target-memory.c: Fix common/ includes.
13108         * target-descriptions.c: Fix common/ includes.
13109         * symtab.h: Fix common/ includes.
13110         * symfile.c: Fix common/ includes.
13111         * stap-probe.c: Fix common/ includes.
13112         * spu-linux-nat.c: Fix common/ includes.
13113         * sparc-nat.c: Fix common/ includes.
13114         * source.c: Fix common/ includes.
13115         * solib.c: Fix common/ includes.
13116         * solib-target.c: Fix common/ includes.
13117         * ser-unix.c: Fix common/ includes.
13118         * ser-tcp.c: Fix common/ includes.
13119         * ser-pipe.c: Fix common/ includes.
13120         * ser-base.c: Fix common/ includes.
13121         * selftest-arch.c: Fix common/ includes.
13122         * s12z-tdep.c: Fix common/ includes.
13123         * rust-exp.y: Fix common/ includes.
13124         * rs6000-aix-tdep.c: Fix common/ includes.
13125         * riscv-tdep.c: Fix common/ includes.
13126         * remote.c: Fix common/ includes.
13127         * remote-notif.h: Fix common/ includes.
13128         * remote-fileio.h: Fix common/ includes.
13129         * remote-fileio.c: Fix common/ includes.
13130         * regcache.h: Fix common/ includes.
13131         * regcache.c: Fix common/ includes.
13132         * record-btrace.c: Fix common/ includes.
13133         * python/python.c: Fix common/ includes.
13134         * python/py-type.c: Fix common/ includes.
13135         * python/py-inferior.c: Fix common/ includes.
13136         * progspace.h: Fix common/ includes.
13137         * producer.c: Fix common/ includes.
13138         * procfs.c: Fix common/ includes.
13139         * proc-api.c: Fix common/ includes.
13140         * printcmd.c: Fix common/ includes.
13141         * ppc-linux-nat.c: Fix common/ includes.
13142         * parser-defs.h: Fix common/ includes.
13143         * osdata.c: Fix common/ includes.
13144         * obsd-nat.c: Fix common/ includes.
13145         * nat/x86-linux.c: Fix common/ includes.
13146         * nat/x86-linux-dregs.c: Fix common/ includes.
13147         * nat/x86-dregs.h: Fix common/ includes.
13148         * nat/x86-dregs.c: Fix common/ includes.
13149         * nat/ppc-linux.c: Fix common/ includes.
13150         * nat/mips-linux-watch.h: Fix common/ includes.
13151         * nat/mips-linux-watch.c: Fix common/ includes.
13152         * nat/linux-waitpid.c: Fix common/ includes.
13153         * nat/linux-ptrace.h: Fix common/ includes.
13154         * nat/linux-ptrace.c: Fix common/ includes.
13155         * nat/linux-procfs.c: Fix common/ includes.
13156         * nat/linux-personality.c: Fix common/ includes.
13157         * nat/linux-osdata.c: Fix common/ includes.
13158         * nat/linux-namespaces.c: Fix common/ includes.
13159         * nat/linux-btrace.h: Fix common/ includes.
13160         * nat/linux-btrace.c: Fix common/ includes.
13161         * nat/fork-inferior.c: Fix common/ includes.
13162         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13163         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13164         * nat/aarch64-linux.c: Fix common/ includes.
13165         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13166         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13167         * namespace.h: Fix common/ includes.
13168         * mips-linux-tdep.c: Fix common/ includes.
13169         * minsyms.c: Fix common/ includes.
13170         * mi/mi-parse.h: Fix common/ includes.
13171         * mi/mi-main.c: Fix common/ includes.
13172         * mi/mi-cmd-env.c: Fix common/ includes.
13173         * memrange.h: Fix common/ includes.
13174         * memattr.c: Fix common/ includes.
13175         * maint.h: Fix common/ includes.
13176         * maint.c: Fix common/ includes.
13177         * main.c: Fix common/ includes.
13178         * machoread.c: Fix common/ includes.
13179         * location.c: Fix common/ includes.
13180         * linux-thread-db.c: Fix common/ includes.
13181         * linux-nat.c: Fix common/ includes.
13182         * linux-fork.c: Fix common/ includes.
13183         * inline-frame.c: Fix common/ includes.
13184         * infrun.c: Fix common/ includes.
13185         * inflow.c: Fix common/ includes.
13186         * inferior.h: Fix common/ includes.
13187         * inferior.c: Fix common/ includes.
13188         * infcmd.c: Fix common/ includes.
13189         * inf-ptrace.c: Fix common/ includes.
13190         * inf-child.c: Fix common/ includes.
13191         * ia64-linux-nat.c: Fix common/ includes.
13192         * i387-tdep.c: Fix common/ includes.
13193         * i386-tdep.c: Fix common/ includes.
13194         * i386-linux-tdep.c: Fix common/ includes.
13195         * i386-linux-nat.c: Fix common/ includes.
13196         * i386-go32-tdep.c: Fix common/ includes.
13197         * i386-fbsd-tdep.c: Fix common/ includes.
13198         * i386-fbsd-nat.c: Fix common/ includes.
13199         * guile/scm-type.c: Fix common/ includes.
13200         * guile/guile.c: Fix common/ includes.
13201         * go32-nat.c: Fix common/ includes.
13202         * gnu-nat.c: Fix common/ includes.
13203         * gdbthread.h: Fix common/ includes.
13204         * gdbarch-selftests.c: Fix common/ includes.
13205         * gdb_usleep.c: Fix common/ includes.
13206         * gdb_select.h: Fix common/ includes.
13207         * gdb_bfd.c: Fix common/ includes.
13208         * gcore.c: Fix common/ includes.
13209         * fork-child.c: Fix common/ includes.
13210         * findvar.c: Fix common/ includes.
13211         * fbsd-nat.c: Fix common/ includes.
13212         * event-top.c: Fix common/ includes.
13213         * event-loop.c: Fix common/ includes.
13214         * dwarf2read.c: Fix common/ includes.
13215         * dwarf2loc.c: Fix common/ includes.
13216         * dwarf2-frame.c: Fix common/ includes.
13217         * dwarf-index-cache.c: Fix common/ includes.
13218         * dtrace-probe.c: Fix common/ includes.
13219         * disasm-selftests.c: Fix common/ includes.
13220         * defs.h: Fix common/ includes.
13221         * csky-tdep.c: Fix common/ includes.
13222         * cp-valprint.c: Fix common/ includes.
13223         * cp-support.h: Fix common/ includes.
13224         * cp-support.c: Fix common/ includes.
13225         * corelow.c: Fix common/ includes.
13226         * completer.h: Fix common/ includes.
13227         * completer.c: Fix common/ includes.
13228         * compile/compile.c: Fix common/ includes.
13229         * compile/compile-loc2c.c: Fix common/ includes.
13230         * compile/compile-cplus-types.c: Fix common/ includes.
13231         * compile/compile-cplus-symbols.c: Fix common/ includes.
13232         * command.h: Fix common/ includes.
13233         * cli/cli-dump.c: Fix common/ includes.
13234         * cli/cli-cmds.c: Fix common/ includes.
13235         * charset.c: Fix common/ includes.
13236         * build-id.c: Fix common/ includes.
13237         * btrace.h: Fix common/ includes.
13238         * btrace.c: Fix common/ includes.
13239         * breakpoint.h: Fix common/ includes.
13240         * breakpoint.c: Fix common/ includes.
13241         * ax.h:
13242         (enum agent_op): Fix common/ includes.
13243         * ax-general.c (struct aop_map): Fix common/ includes.
13244         * ax-gdb.c: Fix common/ includes.
13245         * auxv.c: Fix common/ includes.
13246         * auto-load.c: Fix common/ includes.
13247         * arm-tdep.c: Fix common/ includes.
13248         * arch/riscv.c: Fix common/ includes.
13249         * arch/ppc-linux-common.c: Fix common/ includes.
13250         * arch/i386.c: Fix common/ includes.
13251         * arch/arm.c: Fix common/ includes.
13252         * arch/arm-linux.c: Fix common/ includes.
13253         * arch/arm-get-next-pcs.c: Fix common/ includes.
13254         * arch/amd64.c: Fix common/ includes.
13255         * arch/aarch64.c: Fix common/ includes.
13256         * arch/aarch64-insn.c: Fix common/ includes.
13257         * arch-utils.c: Fix common/ includes.
13258         * amd64-windows-tdep.c: Fix common/ includes.
13259         * amd64-tdep.c: Fix common/ includes.
13260         * amd64-sol2-tdep.c: Fix common/ includes.
13261         * amd64-obsd-tdep.c: Fix common/ includes.
13262         * amd64-nbsd-tdep.c: Fix common/ includes.
13263         * amd64-linux-tdep.c: Fix common/ includes.
13264         * amd64-linux-nat.c: Fix common/ includes.
13265         * amd64-fbsd-tdep.c: Fix common/ includes.
13266         * amd64-fbsd-nat.c: Fix common/ includes.
13267         * amd64-dicos-tdep.c: Fix common/ includes.
13268         * amd64-darwin-tdep.c: Fix common/ includes.
13269         * agent.c: Fix common/ includes.
13270         * ada-lang.h: Fix common/ includes.
13271         * ada-lang.c: Fix common/ includes.
13272         * aarch64-tdep.c: Fix common/ includes.
13273
13274 2019-01-25  Tom Tromey  <tom@tromey.com>
13275
13276         * common/create-version.sh: Use common/version.h.
13277
13278 2019-01-24  Pedro Alves  <palves@redhat.com>
13279
13280         * infrun.c (signal_stop, signal_print, signal_program)
13281         (signal_catch, signal_pass): Now arrays instead of pointers.
13282         (update_signals_program_target, do_target_resume)
13283         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13284         * linux-nat.c (linux_nat_target::pass_signals)
13285         (linux_nat_target::create_inferior, linux_nat_target::attach):
13286         Adjust.
13287         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13288         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13289         * procfs.c (procfs_target::pass_signals): Adjust.
13290         * record-full.c (record_full_target::resume): Adjust.
13291         * remote.c (remote_target::pass_signals)
13292         (remote_target::program_signals): Adjust.
13293         * target-debug.h (target_debug_print_signals): Now takes a
13294         gdb::array_view as parameter.  Adjust.
13295         * target.h (target_ops) <pass_signals, program_signals>: Replace
13296         pointer and length parameters with gdb::array_view.
13297         (target_pass_signals, target_program_signals): Likewise.
13298         * target-delegates.c: Regenerate.
13299
13300 2019-01-24  Pedro Alves  <palves@redhat.com>
13301
13302         * common/forward-scope-exit.h
13303         (forward_scope_exit::forward_scope_exit): Pass arguments to
13304         m_bind_function directly, instead of creating a std::bind and
13305         copying that.
13306
13307 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13308
13309         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13310         for static members.
13311         (pass_in_v_vfp_candidate): Likewise.
13312
13313 2019-01-23  Tom Tromey  <tom@tromey.com>
13314             Pedro Alves  <palves@redhat.com>
13315
13316         * regcache.c (class regcache_invalidator): Remove.
13317         (regcache::raw_write): Use make_scope_exit.
13318
13319 2019-01-23  Tom Tromey  <tom@tromey.com>
13320
13321         * ui-out.h (class ui_out_emit_type): Update comment.
13322
13323 2019-01-23  Tom Tromey  <tom@tromey.com>
13324
13325         * infrun.c (fetch_inferior_event): Update comment.
13326
13327 2019-01-23  Tom Tromey  <tom@tromey.com>
13328             Pedro Alves  <palves@redhat.com>
13329
13330         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13331         parameter.
13332         (fetch_inferior_event): Use SCOPE_EXIT.
13333
13334
13335 2019-01-23  Tom Tromey  <tom@tromey.com>
13336             Pedro Alves  <palves@redhat.com>
13337
13338         * infrun.c (disable_thread_events): Delete.
13339         (stop_all_threads): Use SCOPE_EXIT.
13340
13341 2019-01-23  Tom Tromey  <tom@tromey.com>
13342             Pedro Alves  <palves@redhat.com>
13343
13344         * symfile.c: Include forward-scope-exit.h.
13345         (clear_symtab_users_cleanup): Replace forward declaration with
13346         a FORWARD_SCOPE_EXIT.
13347         (syms_from_objfile_1): Use the forward_scope_exit and
13348         gdb::optional instead of cleanup_function.
13349         (reread_symbols): Use the forward_scope_exit instead of
13350         cleanup_function.
13351         (clear_symtab_users_cleanup): Remove function.
13352
13353 2019-01-23  Tom Tromey  <tom@tromey.com>
13354             Pedro Alves  <palves@redhat.com>
13355
13356         * linux-nat.c: Include scope-exit.h.
13357         (cleanup_target_stop): Remove.
13358         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13359         SCOPE_EXIT.
13360
13361 2019-01-23  Tom Tromey  <tom@tromey.com>
13362             Pedro Alves  <palves@redhat.com>
13363
13364         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13365         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13366
13367 2019-01-23  Tom Tromey  <tom@tromey.com>
13368             Andrew Burgess  <andrew.burgess@embecosm.com>
13369             Pedro Alves  <palves@redhat.com>
13370
13371         * infrun.c (fetch_inferior_event): Use scope_exit.
13372         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13373         * top.c (execute_command): Use scope_exit.
13374         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13375         * utils.c (do_bpstat_clear_actions_cleanup)
13376         (make_bpstat_clear_actions_cleanup): Remove.
13377
13378 2019-01-23  Tom Tromey  <tom@tromey.com>
13379             Pedro Alves  <palves@redhat.com>
13380
13381         * infrun.c: Include "common/scope-exit.h"
13382         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13383         (wait_for_inferior): Use SCOPE_EXIT.
13384         (fetch_inferior_event): Use scope_exit.
13385
13386 2019-01-23  Tom Tromey  <tom@tromey.com>
13387             Pedro Alves  <palves@redhat.com>
13388
13389         * breakpoint.c (create_breakpoint): Remove cleanup.
13390
13391 2019-01-23  Tom Tromey  <tom@tromey.com>
13392             Andrew Burgess  <andrew.burgess@embecosm.com>
13393             Pedro Alves  <palves@redhat.com>
13394
13395 2019-01-23  Pedro Alves  <palves@redhat.com>
13396
13397         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13398
13399 2019-01-23  Pedro Alves  <palves@redhat.com>
13400             Andrew Burgess  <andrew.burgess@embecosm.com>
13401
13402         * gdbthread.h: Include "common/forward-scope-exit.h".
13403         (scoped_finish_thread_state): Redefine custom class in terms of
13404         forward_scope_exit.
13405
13406 2019-01-23  Pedro Alves  <palves@redhat.com>
13407             Andrew Burgess  <andrew.burgess@embecosm.com>
13408
13409         * common/forward-scope-exit.h: New file.
13410
13411 2019-01-23  Pedro Alves  <palves@redhat.com>
13412             Andrew Burgess  <andrew.burgess@embecosm.com>
13413             Tom Tromey  <tom@tromey.com>
13414
13415         * common/scope-exit.h: New file.
13416
13417 2019-01-23  Pedro Alves  <palves@redhat.com>
13418
13419         * common/preprocessor.h (ESC): Rename to ...
13420         (ESC_PARENS): ... this.
13421         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13422         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13423
13424 2019-01-23  Tom Tromey  <tom@tromey.com>
13425
13426         * language.h (class scoped_switch_to_sym_language_if_auto):
13427         Initialize m_lang in both cases.
13428
13429 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13430
13431         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13432         with XCNEW.
13433
13434 2019-01-22  Tom Tromey  <tom@tromey.com>
13435
13436         * corelow.c: Do not include sys/file.h.
13437
13438 2019-01-22  Tom Tromey  <tom@tromey.com>
13439
13440         * tui/tui-wingeneral.h: Include gdb_curses.h.
13441
13442 2019-01-22  Tom Tromey  <tom@tromey.com>
13443
13444         * source-cache.h (class source_cache) <get_source_lines,
13445         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13446
13447 2019-01-22  Tom Tromey  <tom@tromey.com>
13448
13449         * remote-fileio.h (struct remote_target): Declare.
13450
13451 2019-01-22  Tom Tromey  <tom@tromey.com>
13452
13453         * python/py-arch.c: Do not include py-ref.h.
13454         * python/py-bpevent.c: Do not include py-ref.h.
13455         * python/py-cmd.c: Do not include py-ref.h.
13456         * python/py-continueevent.c: Do not include py-ref.h.
13457         * python/py-event.h: Do not include py-ref.h.
13458         * python/py-evtregistry.c: Do not include py-ref.h.
13459         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13460         * python/py-frame.c: Do not include py-ref.h.
13461         * python/py-framefilter.c: Do not include py-ref.h.
13462         * python/py-function.c: Do not include py-ref.h.
13463         * python/py-infevents.c: Do not include py-ref.h.
13464         * python/py-linetable.c: Do not include py-ref.h.
13465         * python/py-objfile.c: Do not include py-ref.h.
13466         * python/py-param.c: Do not include py-ref.h.
13467         * python/py-prettyprint.c: Do not include py-ref.h.
13468         * python/py-progspace.c: Do not include py-ref.h.
13469         * python/py-symbol.c: Do not include py-ref.h.
13470         * python/py-symtab.c: Do not include py-ref.h.
13471         * python/py-type.c: Do not include py-ref.h.
13472         * python/py-unwind.c: Do not include py-ref.h.
13473         * python/py-utils.c: Do not include py-ref.h.
13474         * python/py-value.c: Do not include py-ref.h.
13475         * python/py-varobj.c: Do not include py-ref.h.
13476         * python/py-xmethods.c: Do not include py-ref.h.
13477         * python/python.c: Do not include py-ref.h.
13478         * varobj.c: Do not include py-ref.h.
13479
13480 2019-01-22  Tom Tromey  <tom@tromey.com>
13481
13482         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13483         keyword for bcache.
13484
13485 2019-01-22  Tom Tromey  <tom@tromey.com>
13486
13487         * compile/compile-cplus-types.c: Remove a comment by #include.
13488
13489 2019-01-22  Tom Tromey  <tom@tromey.com>
13490
13491         * compile/gcc-c-plugin.h: Include compile-internal.h.
13492
13493 2019-01-22  Tom Tromey  <tom@tromey.com>
13494
13495         * stabsread.c (EXTERN): Do not define.
13496         (symnum, next_symbol_text_func, processing_gcc_compilation)
13497         (within_function, global_sym_chain, global_stabs)
13498         (previous_stab_code, this_object_header_files)
13499         (n_this_object_header_files)
13500         (n_allocated_this_object_header_files): Define.
13501         * stabsread.h (EXTERN): Never define.  Use "extern".
13502
13503 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13504
13505         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13506         history_value.
13507
13508 2019-01-21  Tom Tromey  <tom@tromey.com>
13509
13510         * ui-out.c: Fix includes.
13511         * tui/tui-source.c: Fix includes.
13512         * target.c: Fix includes.
13513         * remote.c: Fix includes.
13514         * regcache.c: Fix includes.
13515         * python/py-block.c: Fix includes.
13516         * printcmd.c: Fix includes.
13517         * or1k-tdep.c: Fix includes.
13518         * mi/mi-main.c: Fix includes.
13519         * m32r-tdep.c: Fix includes.
13520         * csky-tdep.c: Fix includes.
13521         * compile/compile-cplus-types.c: Fix includes.
13522         * cli/cli-interp.c: Fix includes.
13523
13524 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13525
13526         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13527         for padding.
13528
13529 2019-01-16  Tom Tromey  <tom@tromey.com>
13530
13531         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13532         earlier.
13533         (struct objfile) <msymbols_range>: Move from top level.
13534         <msymbols>: New method.
13535         (class objfile_msymbols): Remove.
13536         * symtab.c (default_collect_symbol_completion_matches_break_on):
13537         Update.
13538         * symmisc.c (dump_msymbols): Update.
13539         * stabsread.c (scan_file_globals): Update.
13540         * objc-lang.c (info_selectors_command, info_classes_command)
13541         (find_methods): Update.
13542         * minsyms.c (find_solib_trampoline_target): Update.
13543         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13544         * coffread.c (coff_symfile_read): Update.
13545         * ada-lang.c (ada_lookup_simple_minsym)
13546         (ada_collect_symbol_completion_matches): Update.
13547
13548 2019-01-16  Tom Tromey  <tom@tromey.com>
13549
13550         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13551         type.  Remove no-argument constructor.
13552         <iterator::operator++>: Simplify.
13553         <begin>: Update.
13554         <end>: Use minimal_symbol_count.
13555
13556 2019-01-16  Tom Tromey  <tom@tromey.com>
13557
13558         * objfiles.h (struct objfile) <psymtabs>: New method.
13559         (class objfile_psymtabs): Remove.
13560         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13561         typedef.
13562         <range>: New method.
13563         (require_partial_symbols): Change return type.
13564         * psymtab.c (require_partial_symbols)
13565         (psym_expand_symtabs_matching): Update.
13566         * mdebugread.c (parse_partial_symbols): Update.
13567         * dbxread.c (dbx_end_psymtab): Update.
13568
13569 2019-01-15  Tom Tromey  <tom@tromey.com>
13570
13571         * symtab.c (lookup_objfile_from_block)
13572         (lookup_symbol_in_objfile_symtabs)
13573         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13574         (find_line_symtab, info_sources_command)
13575         (default_collect_symbol_completion_matches_break_on)
13576         (make_source_files_completion_list): Update.
13577         * symmisc.c (print_objfile_statistics, dump_objfile)
13578         (maintenance_print_symbols, maintenance_info_symtabs)
13579         (maintenance_check_symtabs, maintenance_info_line_tables):
13580         Update.
13581         * source.c (select_source_symtab)
13582         (forget_cached_source_info_for_objfile): Update.
13583         * objfiles.h (class objfile_compunits): Remove.
13584         (struct objfile) <compunits_range>: New typedef.
13585         (compunits): New method.
13586         * objfiles.c (objfile_relocate1): Update.
13587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13588         * maint.c (count_symtabs_and_blocks): Update.
13589         * linespec.c (iterate_over_all_matching_symtabs): Update.
13590         * cp-support.c (add_symbol_overload_list_qualified): Update.
13591         * coffread.c (coff_symtab_read): Update.
13592         * ada-lang.c (add_nonlocal_symbols)
13593         (ada_collect_symbol_completion_matches)
13594         (ada_add_global_exceptions): Update.
13595
13596 2019-01-15  Tom Tromey  <tom@tromey.com>
13597
13598         * progspace.h (program_space) <objfiles_safe_range>: New
13599         typedef.
13600         <objfiles_safe>: New method.
13601         * objfiles.h (class all_objfiles_safe): Remove.
13602         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13603         * jit.c (jit_inferior_exit_hook): Update.
13604
13605 2019-01-17  Tom Tromey  <tom@tromey.com>
13606
13607         * progspace.h (program_space) <objfiles_range>: New typedef.
13608         <objfiles>: New method.
13609         <objfiles_head>: Rename from objfiles.
13610         (object_files): Update.
13611         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13612         * guile/scm-pretty-print.c
13613         (ppscm_find_pretty_printer_from_objfiles): Update.
13614         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13615         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13616         Update.
13617         * python/py-progspace.c (pspy_get_objfiles): Update.
13618         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13619         Update.
13620         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13621         (objfpy_lookup_objfile_by_build_id): Update.
13622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13623         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13624         Update.
13625         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13626         (expand_symtab_containing_pc, lookup_objfile_from_block)
13627         (lookup_static_symbol, basic_lookup_transparent_type)
13628         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13629         (find_line_symtab, info_sources_command)
13630         (default_collect_symbol_completion_matches_break_on)
13631         (make_source_files_completion_list, find_main_name): Update.
13632         * symmisc.c (print_symbol_bcache_statistics)
13633         (print_objfile_statistics, maintenance_print_symbols)
13634         (maintenance_print_msymbols, maintenance_print_objfiles)
13635         (maintenance_info_symtabs, maintenance_check_symtabs)
13636         (maintenance_expand_symtabs, maintenance_info_line_tables):
13637         Update.
13638         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13639         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13640         (map_overlay_command, unmap_overlay_command)
13641         (simple_overlay_update, expand_symtabs_matching)
13642         (map_symbol_filenames): Update.
13643         * symfile-debug.c (set_debug_symfile): Update.
13644         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13645         Update.
13646         * source.c (select_source_symtab, forget_cached_source_info):
13647         Update.
13648         * solib.c (solib_read_symbols): Update.
13649         * solib-spu.c (append_ocl_sos): Update.
13650         * psymtab.c (maintenance_print_psymbols)
13651         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13652         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13653         * printcmd.c (info_symbol_command): Update.
13654         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13655         Update.
13656         * objfiles.h (class all_objfiles): Remove.
13657         * objfiles.c (have_partial_symbols, have_full_symbols)
13658         (have_minimal_symbols, qsort_cmp, update_section_map)
13659         (shared_objfile_contains_address_p)
13660         (default_iterate_over_objfiles_in_search_order): Update.
13661         * objc-lang.c (info_selectors_command, info_classes_command)
13662         (find_methods): Update.
13663         * minsyms.c (find_solib_trampoline_target): Update.
13664         * maint.c (maintenance_info_sections)
13665         (maintenance_translate_address, count_symtabs_and_blocks):
13666         Update.
13667         * main.c (captured_main_1): Update.
13668         * linux-thread-db.c (try_thread_db_load_from_pdir)
13669         (has_libpthread): Update.
13670         * linespec.c (iterate_over_all_matching_symtabs)
13671         (search_minsyms_for_name): Update.
13672         * jit.c (jit_find_objf_with_entry_addr): Update.
13673         * hppa-tdep.c (find_unwind_entry)
13674         (hppa_lookup_stub_minimal_symbol): Update.
13675         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13676         Update.
13677         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13678         (elf_gnu_ifunc_resolve_by_got): Update.
13679         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13680         * dwarf-index-write.c (save_gdb_index_command): Update.
13681         * cp-support.c (add_symbol_overload_list_qualified): Update.
13682         * breakpoint.c (create_overlay_event_breakpoint)
13683         (create_longjmp_master_breakpoint)
13684         (create_std_terminate_master_breakpoint)
13685         (create_exception_master_breakpoint): Update.
13686         * blockframe.c (find_pc_partial_function): Update.
13687         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13688         (ada_collect_symbol_completion_matches)
13689         (ada_add_global_exceptions): Update.
13690
13691 2019-01-17  Tom Tromey  <tom@tromey.com>
13692
13693         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13694         declare VEC.
13695         (solib_target_parse_libraries): Change return type.
13696         (library_list_start_segment, library_list_start_section)
13697         (library_list_end_library, library_list_start_library); Update.
13698         (solib_target_free_library_list): Remove.
13699         (solib_target_parse_libraries): Remove cleanup.  Change return
13700         type.
13701         (solib_target_current_sos): Update.
13702
13703 2019-01-17  Tom Tromey  <tromey@bapiya>
13704
13705         * valprint.c: Replace "the the" with "the".
13706         * symtab.c: Replace "the the" with "the".
13707         * solib.c: Replace "the the" with "the".
13708         * solib-dsbt.c: Replace "the the" with "the".
13709         * linespec.c: Replace "the the" with "the".
13710         * dwarf2loc.h: Replace "the the" with "the".
13711         * amd64-windows-tdep.c: Replace "the the" with "the".
13712         * aarch64-tdep.c: Replace "the the" with "the".
13713
13714 2019-01-16  Keith Seitz  <keiths@redhat.com>
13715
13716         PR gdb/23773
13717         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13718         <builder>: Rename to ..
13719         <m_builder>: ... this and make private.
13720         (dwarf2_cu::get_builder): New method.  Change all users of
13721         `builder' to use this method.
13722         (dwarf2_start_symtab): Move to ...
13723         (dwarf2_cu::start_symtab): ... here.  Update all callers
13724         (setup_type_unit_groups): Move to ...
13725         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13726         callers.
13727         (dwarf2_cu::reset_builder): New method.
13728         (process_full_compunit, process_full_type_unit): Use
13729         dwarf2_cu::reset_builder.
13730         (follow_die_offset): Record the ancestor CU if it is different
13731         from the followed DIE's CU.
13732         (follow_die_sig_1): Likewise.
13733
13734 2019-01-15  Tom Tromey  <tom@tromey.com>
13735
13736         * remote.c (class remote_state) <buf>: Now a char_vector.
13737         <buf_size>: Remove.
13738         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13739         parameter.
13740         (remote_target::getpkt_or_notif_sane_1)
13741         (remote_target::getpkt_sane)
13742         (remote_target::getpkt_or_notif_sane): Likewise.
13743         (class remote_target) <putpkt>: New overload.
13744         (remote_target::read_frame): Change type of "buf_p".  Remove
13745         sizeof_p parameter.
13746         (packet_ok): New overload.
13747         (packet_check_result): New overload.
13748         Update all uses.
13749
13750 2019-01-14  Tom Tromey  <tom@tromey.com>
13751
13752         * remote-notif.c (handle_notification, remote_notif_ack)
13753         (remote_notif_parse): Make "buf" const.
13754         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13755         const.
13756         (remote_notif_parse, remote_notif_ack, handle_notification):
13757         Likewise.
13758         * remote.c (remote_notif_stop_parse): Make "buf" const.
13759         (remote_target::remote_parse_stop_reply): Make "buf" const.
13760         (remote_notif_stop_ack): Make "buf" const.
13761
13762 2019-01-14  Tom Tromey  <tom@tromey.com>
13763
13764         * remote.c (remote_console_output): Make parameter const.
13765
13766 2019-01-14  Tom Tromey  <tom@tromey.com>
13767
13768         * target-debug.h (target_debug_print_signals): Constify.
13769         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13770         * procfs.c (procfs_target::pass_signals): Update.
13771         * linux-nat.c (linux_nat_target::pass_signals): Update.
13772         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13773         * target-delegates.c: Rebuild.
13774         * remote.c (remote_target::program_signals): Update.
13775         (remote_target::pass_signals): Update.
13776         * target.c (target_pass_signals): Constify argument.
13777         (target_program_signals): Likewise.
13778         * target.h (struct target_ops) <pass_signals, program_signals>:
13779         Constify argument.
13780         (target_pass_signals, target_program_signals): Constify argument.
13781
13782 2019-01-14  Tom Tromey  <tom@tromey.com>
13783
13784         PR tui/28819:
13785         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13786
13787 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13788
13789         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13790         field.
13791         * rs6000-tdep.c: Include reggroups.h.
13792         (IS_V_ALIAS_PSEUDOREG): Define.
13793         (rs6000_register_name): Return names for the "vX" aliases.
13794         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13795         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13796         aliases.  Call default_register_reggroup_p for all other
13797         pseudo-registers.
13798         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13799         New functions.
13800         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13801         Handle "vX" aliases.
13802         (v_alias_pseudo_register_collect): New function.
13803         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13804         (rs6000_gdbarch_init): Initialize "vX" aliases as
13805         pseudo-registers.  Restore registration of
13806         rs6000_pseudo_register_reggroup_p with
13807         set_tdesc_pseudo_register_reggroup_p.
13808
13809 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13810
13811         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13812         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13813         set_gdbarch_num_pseudo_regs.
13814
13815 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13816
13817         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13818         Remove arg prefixname, add do_set and do_show.
13819         Add member functions set_list and show_list.
13820         * cli/cli-style.c (class cli_style_option): Update accordingly.
13821         (style_set_list): Move to file scope.
13822         (style_show_list): Likewise.
13823         (set_style): Call help_list.
13824         (show_style): Call cmd_show_list.
13825         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13826         Update to use the new macro.
13827
13828 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13829
13830         * ada-lang.c (_initialize_ada_language): Expand the help text
13831         for the "catch exception" command.
13832
13833 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13834
13835         * symtab.c (matching_obj_sections): Initialize obj,
13836         declare it closer to its usage.
13837
13838 2019-01-10  Tom Tromey  <tom@tromey.com>
13839
13840         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13841         (basic_inf_threads_range): Remove.
13842         (inf_threads_range, inf_non_exited_threads_range)
13843         (safe_inf_threads_range): Use next_adapter.
13844
13845 2019-01-10  Keith Seitz  <keiths@redhat.com>
13846
13847         PR gdb/23712
13848         PR symtab/23010
13849         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13850         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13851
13852 2019-01-10  Keith Seitz  <keiths@redhat.com>
13853
13854         PR gdb/23712
13855         PR symtab/23010
13856         * dictionary.c (pending_to_vector): Remove.
13857         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13858         Remove _1 suffix, replacing functions of the same name.  Update
13859         all callers.
13860         (dict_create_hashed, dict_create_hashed_expandable)
13861         (dict_create_linear, dict_create_linear_expandable, dict_free)
13862         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13863         Make functions static.
13864
13865 2019-01-10  Keith Seitz  <keiths@redhat.com>
13866
13867         PR gdb/23712
13868         PR symtab/23010
13869         * dictionary.h (struct dictionary): Replace declaration with
13870         multidictionary.
13871         (dict_create_hashed, dict_create_hashed_expandable)
13872         (dict_create_linear, dict_create_linear_expandable)
13873         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13874         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13875         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13876         taking multidictionary argument.
13877         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13878         * block.h (struct block) <dict>: Change to multidictionary
13879         and rename `multidict'.
13880         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13881         symmisc.c: Update all dictionary references to multidictionary.
13882
13883 2019-01-10  Keith Seitz  <keiths@redhat.com>
13884
13885         PR gdb/23712
13886         PR symtab/23010
13887         * dictionary.c: Include unordered_map.
13888         (pending_to_vector): New function.
13889         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13890         Rewrite the non-"_1" functions to take vector instead
13891         of linked list.
13892         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13893         "new" _1 versions of the same name.
13894         (multidictionary): Define.
13895         (std::hash<enum language): New definition.
13896         (collate_pending_symbols_by_language, mdict_create_hashed)
13897         (mdict_create_hashed_expandable, mdict_create_linear)
13898         (mdict_create_linear_expandable, mdict_free)
13899         (find_language_dictionary, create_new_language_dictionary)
13900         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13901         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13902         (mdict_size, mdict_empty): New functions.
13903         * dictionary.h (mdict_iterator): Define.
13904
13905 2019-01-10  Pedro Alves  <palves@redhat.com>
13906
13907         * breakpoint.c (read_uploaded_action)
13908         (create_tracepoint_from_upload): Adjust to use
13909         gdb::unique_xmalloc_ptr.
13910         * ctf.c (ctf_write_uploaded_tp):
13911         (SET_ARRAY_FIELD): Use emplace_back.
13912         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13913         * tracefile-tfile.c (tfile_write_uploaded_tp):
13914         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13915         gdb::unique_xmalloc_ptr.
13916         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13917         at_string, cond_string, cmd_strings>: Replace char pointers
13918         with gdb::unique_xmalloc_ptr.
13919
13920 2019-01-10  Pedro Alves  <palves@redhat.com>
13921
13922         * solib-target.c (library_list_start_library): Don't xstrdup name.
13923
13924 2019-01-10  Pedro Alves  <palves@redhat.com>
13925
13926         * mdebugread.c (parse_partial_symbols): Use
13927         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13928
13929 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13930
13931         * linux-fork.c (scoped_switch_fork_info)
13932         <~scoped_switch_fork_info>: Fix incorrect variable name.
13933
13934 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13935
13936         * linux-fork.c (scoped_switch_fork_info)
13937         <scoped_switch_fork_info>: Make explicit.
13938         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13939
13940 2019-01-10  Tom Tromey  <tom@tromey.com>
13941
13942         * objfiles.h (objfile::reset_psymtabs): Update.
13943         * objfiles.c (objfile::objfile): Update.
13944         * psymtab.h (psymtab_storage::obstack): Update.
13945         (psymtab_storage::m_obstack): Use gdb::optional.
13946         (class psymtab_storage): Update comment.  Remove objfile
13947         parameter.
13948         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13949
13950 2019-01-10  Tom Tromey  <tom@tromey.com>
13951
13952         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13953         <free_psymtabs>: Now private.
13954         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13955         (allocate_psymtab): Use new method.
13956
13957 2019-01-10  Tom Tromey  <tom@tromey.com>
13958
13959         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13960         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13961         * mdebugread.c (parse_partial_symbols): Use
13962         allocate_dependencies.
13963         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13964         allocate_dependencies.
13965         (process_psymtab_comp_unit_reader)
13966         (build_type_psymtab_dependencies): Likewise.
13967         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13968
13969 2019-01-10  Tom Tromey  <tom@tromey.com>
13970
13971         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13972         PSYMBOL_SET_LANGUAGE.
13973         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13974
13975 2019-01-10  Tom Tromey  <tom@tromey.com>
13976
13977         * psymtab.h (psymtab_storage::obstack): New method.
13978         <m_obstack>: Rename from obstack; now private.
13979         * psymtab.c (psymtab_storage): Update.
13980         * dwarf2read.c (create_addrmap_from_index)
13981         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13982         Update.
13983
13984 2019-01-10  Tom Tromey  <tom@tromey.com>
13985
13986         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13987         * objfiles.h (objfile::reset_psymtabs): New method.
13988
13989 2019-01-10  Tom Tromey  <tom@tromey.com>
13990
13991         * symmisc.c (print_symbol_bcache_statistics): Update.
13992         (print_objfile_statistics): Update.
13993         * symfile.c (reread_symbols): Update.
13994         * psymtab.h (class psymtab_storage): New.
13995         * psymtab.c (psymtab_storage): New constructor.
13996         (~psymtab_storage): New destructor.
13997         (require_partial_symbols): Update.
13998         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13999         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14000         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14001         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14002         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14003         (start_psymtab_common, end_psymtab_common)
14004         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14005         (allocate_psymtab): Update.
14006         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14007         Update.
14008         (dump_psymtab_addrmap, maintenance_print_psymbols)
14009         (maintenance_check_psymtabs): Update.
14010         (class objfile_psymtabs): Move to objfiles.h.
14011         * psympriv.h (discard_psymtab): Now inline.
14012         (psymtab_discarder::psymtab_discarder): Update.
14013         (psymtab_discarder::~psymtab_discarder): Update.
14014         (ALL_OBJFILE_PSYMTABS): Rewrite.
14015         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14016         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14017         Remove fields.
14018         <partial_symtabs>: New field.
14019         (class objfile_psymtabs): Move from psymtab.h.  Update.
14020         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14021         psymbol_cache.
14022         (objfile::~objfile): Don't destroy psymbol_cache.
14023         * mdebugread.c (parse_partial_symbols): Update.
14024         * dwarf2read.c (create_addrmap_from_index)
14025         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14026         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14027         (add_partial_subprogram, dwarf2_ranges_read): Update.
14028         * dwarf-index-write.c (write_address_map)
14029         (write_one_signatured_type, recursively_write_psymbols)
14030         (class debug_names, class debug_names, write_psymtabs_to_index):
14031         Update.
14032
14033 2019-01-10  Tom Tromey  <tom@tromey.com>
14034
14035         * symtab.h (SYMBOL_SET_NAMES): Update.
14036         (symbol_set_names): Update.
14037         (MSYMBOL_SET_NAMES): Update.
14038         * symtab.c (symbol_set_names): Change argument to be an
14039         objfile_per_bfd_storage.
14040         * psymtab.c (add_psymbol_to_bcache): Update.
14041         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14042
14043 2019-01-10  Tom Tromey  <tom@tromey.com>
14044
14045         * symtab.c (create_demangled_names_hash): Change argument to be an
14046         objfile_per_bfd_storage.
14047         (symbol_set_names): Update.
14048
14049 2019-01-10  Tom Tromey  <tom@tromey.com>
14050
14051         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14052         init_psymbol_list.
14053         * psymtab.c (init_psymbol_list): Do nothing if already called.
14054         * psympriv.h (init_psymbol_list): Add comment.
14055         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14056         init_psymbol_list.
14057         * dbxread.c (dbx_symfile_read): Unconditionally call
14058         init_psymbol_list.
14059
14060 2019-01-10  Tom Tromey  <tom@tromey.com>
14061
14062         * xcoffread.c (scan_xcoff_symtab): Update.
14063         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14064         "where".
14065         * mdebugread.c (parse_partial_symbols)
14066         (handle_psymbol_enumerators): Update.
14067         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14068         * dbxread.c (read_dbx_symtab): Update.
14069         * psympriv.h (psymbol_placement): New enum.
14070         (add_psymbol_to_list): Update.
14071
14072 2019-01-10  Tom Tromey  <tom@tromey.com>
14073
14074         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14075         static_psymbols parameters.
14076         (scan_xcoff_symtab): Update.
14077         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14078         static_psymbols parameters.
14079         * psympriv.h (start_psymtab_common): Update.
14080         * mdebugread.c (parse_partial_symbols): Update.
14081         * dwarf2read.c (create_partial_symtab): Update.
14082         * dbxread.c (read_dbx_symtab): Update.
14083         (start_psymtab): Remove global_psymbols and static_psymbols
14084         parameters.
14085
14086 2019-01-10  Tom Tromey  <tom@tromey.com>
14087
14088         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14089         * psymtab.c (allocate_psymtab): Add comment.
14090         * psympriv.h (allocate_psymtab): Add comment.
14091         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14092         initializations.
14093         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14094
14095 2019-01-10  Tom Tromey  <tom@tromey.com>
14096
14097         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14098         Don't declare.
14099         * mipsread.c: Include mdebugread.h.
14100         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14101         Declare.
14102         * elfread.c: Include mdebugread.h.
14103
14104 2019-01-09  Tom Tromey  <tom@tromey.com>
14105
14106         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14107         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14108         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14109         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14110         (psym_lookup_symbol, psym_find_last_source_symtab)
14111         (psym_forget_cached_source_info, psym_print_stats)
14112         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14113         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14114         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14115         (psym_find_compunit_symtab_by_address)
14116         (maintenance_print_psymbols, maintenance_info_psymtabs)
14117         (maintenance_check_psymtabs): Use ranged for.
14118         * psymtab.h (class objfile_psymtabs): New.
14119         (require_partial_symbols): Return objfile_psymtabs.
14120         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14121
14122 2019-01-09  Tom Tromey  <tom@tromey.com>
14123
14124         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14125         (find_pc_mapped_section, list_overlays_command)
14126         (map_overlay_command, unmap_overlay_command)
14127         (simple_overlay_update): Use all_objfiles.
14128         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14129         * printcmd.c (info_symbol_command): Use all_objfiles.
14130         * objfiles.h (ALL_OBJSECTIONS): Remove.
14131         * maint.c (maintenance_translate_address): Use all_objfiles.
14132         * gcore.c (gcore_create_callback): Use all_objfiles.
14133         (objfile_find_memory_regions): Likewise.
14134
14135 2019-01-09  Tom Tromey  <tom@tromey.com>
14136
14137         * symtab.c (find_line_symtab, info_sources_command)
14138         (make_source_files_completion_list): Use objfile_compunits.
14139         * source.c (select_source_symtab): Use objfile_compunits.
14140         * objfiles.h (struct objfile): Update comment.
14141         (ALL_OBJFILES): Remove.
14142         (ALL_FILETABS): Remove.
14143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14144         objfile_compunits.
14145
14146 2019-01-09  Tom Tromey  <tom@tromey.com>
14147
14148         * symmisc.c (print_objfile_statistics, dump_objfile)
14149         (maintenance_print_symbols): Use compunit_filetabs.
14150         * source.c (forget_cached_source_info_for_objfile): Use
14151         compunit_filetabs.
14152         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14153         (ALL_FILETABS): Use compunit_filetabs.
14154         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14155         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14156
14157 2019-01-09  Tom Tromey  <tom@tromey.com>
14158
14159         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14160         (compunit_filetabs): New.
14161         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14162         compunit_filetabs.
14163         (info_sources_command, make_source_files_completion_list): Remove
14164         declaration.
14165         * symmisc.c (print_objfile_statistics, dump_objfile)
14166         (maintenance_print_symbols): Remove declaration.
14167         (maintenance_info_symtabs): Use compunit_filetabs.
14168         (maintenance_info_line_tables): Likewise.
14169         * source.c (select_source_symtab): Change local variable name.
14170         (forget_cached_source_info_for_objfile): Remove declaration.
14171         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14172         * objfiles.c (objfile_relocate1): Remove declaration.
14173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14174         declaration.
14175         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14176         * coffread.c (coff_symtab_read): Remove declaration.
14177         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14178         compunit_filetabs.
14179
14180 2019-01-09  Tom Tromey  <tom@tromey.com>
14181
14182         * symtab.c (lookup_objfile_from_block)
14183         (find_pc_sect_compunit_symtab, search_symbols)
14184         (default_collect_symbol_completion_matches_break_on): Use
14185         objfile_compunits.
14186         * objfiles.h (ALL_COMPUNITS): Remove.
14187         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14188         * cp-support.c (add_symbol_overload_list_qualified): Use
14189         objfile_compunits.
14190         * ada-lang.c (ada_collect_symbol_completion_matches)
14191         (ada_add_global_exceptions): Use objfile_compunits.
14192
14193 2019-01-09  Tom Tromey  <tom@tromey.com>
14194
14195         * source.c (select_source_symtab)
14196         (forget_cached_source_info_for_objfile): Remove declaration.
14197         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14198         declaration.
14199         * maint.c (count_symtabs_and_blocks): Remove declaration.
14200         * cp-support.c (add_symbol_overload_list_qualified): Remove
14201         declaration.
14202         * coffread.c (coff_symtab_read): Remove declaration.
14203         * symtab.c (lookup_symbol_in_objfile_symtabs)
14204         (basic_lookup_transparent_type_1): Use objfile_compunits.
14205         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14206         (info_sources_command, search_symbols)
14207         (default_collect_symbol_completion_matches_break_on)
14208         (make_source_files_completion_list): Remove declaration.
14209         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14210         (ada_collect_symbol_completion_matches)
14211         (ada_add_global_exceptions): Remove declaration.
14212         * linespec.c (iterate_over_all_matching_symtabs): Use
14213         objfile_compunits.
14214         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14215         (class objfile_compunits): New.
14216         (ALL_COMPUNITS): Use objfile_compunits.
14217         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14218         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14219         objfile_compunits.
14220         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14221
14222 2019-01-09  Tom Tromey  <tom@tromey.com>
14223
14224         * symtab.c (search_symbols)
14225         (default_collect_symbol_completion_matches_break_on): Use
14226         objfile_msymbols.
14227         * ada-lang.c (ada_lookup_simple_minsym)
14228         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14229         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14230         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14231         objfile_msymbols.
14232         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14233         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14234         * objc-lang.c (find_methods): Use objfile_msymbols.
14235         (info_selectors_command, info_classes_command): Likewise.
14236         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14237         * objfiles.h (class objfile_msymbols): New.
14238         (ALL_OBJFILE_MSYMBOLS): Remove.
14239         (ALL_MSYMBOLS): Remove.
14240
14241 2019-01-09  Tom Tromey  <tom@tromey.com>
14242
14243         * common/next-iterator.h (next_adapter): Add Iterator template
14244         parameter.
14245         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14246         (class all_objfiles_safe): New.
14247         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14248         * objfiles.c (put_objfile_before): Update comment.
14249         (add_separate_debug_objfile): Likewise.
14250         (free_all_objfiles): Use all_objfiles_safe.
14251         (objfile_purge_solibs): Likewise.
14252
14253 2019-01-09  Tom Tromey  <tom@tromey.com>
14254
14255         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14256         (expand_symtab_containing_pc, lookup_static_symbol)
14257         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14258         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14259         all_objfiles.
14260         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14261         * breakpoint.c (create_overlay_event_breakpoint)
14262         (create_longjmp_master_breakpoint)
14263         (create_std_terminate_master_breakpoint)
14264         (create_exception_master_breakpoint): Use all_objfiles.
14265         * linux-thread-db.c (try_thread_db_load_from_pdir)
14266         (has_libpthread): Use all_objfiles.
14267         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14268         * linespec.c (iterate_over_all_matching_symtabs)
14269         (search_minsyms_for_name): Use all_objfiles.
14270         * maint.c (maintenance_info_sections): Use all_objfiles.
14271         * main.c (captured_main_1): Use all_objfiles.
14272         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14273         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14274         * guile/scm-pretty-print.c
14275         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14276         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14277         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14278         (maintenance_print_msymbols): Use all_objfiles.
14279         * source.c (select_source_symtab): Use all_objfiles.
14280         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14281         * symfile.c (remove_symbol_file_command)
14282         (expand_symtabs_matching, map_symbol_filenames): Use
14283         all_objfiles.
14284         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14285         all_objfiles.
14286         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14287         * objc-lang.c (find_methods): Use all_objfiles.
14288         * objfiles.c (have_partial_symbols, have_full_symbols)
14289         (have_minimal_symbols, qsort_cmp)
14290         (default_iterate_over_objfiles_in_search_order): Use
14291         all_objfiles.
14292         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14293         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14294         (maintenance_check_psymtabs): Use all_objfiles.
14295         (ALL_PSYMTABS): Remove.
14296         * compile/compile-object-run.c (do_module_cleanup): Use
14297         all_objfiles.
14298         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14299         * cp-support.c (add_symbol_overload_list_qualified): Use
14300         all_objfiles.
14301         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14302         Use all_objfiles.
14303         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14304         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14305         all_objfiles.
14306         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14307         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14308         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14309         Uses all_objfiles.
14310         * solib.c (solib_read_symbols): Use all_objfiles
14311
14312 2019-01-09  Tom Tromey  <tom@tromey.com>
14313
14314         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14315         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14316         all_objfiles.
14317         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14318         * symmisc.c (print_symbol_bcache_statistics)
14319         (print_objfile_statistics, maintenance_print_objfiles)
14320         (maintenance_info_symtabs, maintenance_check_symtabs)
14321         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14322         all_objfiles.
14323         * source.c (forget_cached_source_info): Use all_objfiles.
14324         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14325         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14326         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14327         * objfiles.c (update_section_map): Use all_objfiles.
14328         (shared_objfile_contains_address_p): Likewise.
14329         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14330         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14331
14332 2019-01-09  Tom Tromey  <tom@tromey.com>
14333
14334         * common/next-iterator.h: New file.
14335         * objfiles.h (class all_objfiles): New.
14336         (struct objfile_iterator): New.
14337
14338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14339
14340         * NEWS: Move the description of the changed "frame", "select-frame",
14341          and "info frame" commands to the Changed commands section.
14342
14343 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14344
14345         * gdbtypes.c (check_stub_method_group): Remove handling of old
14346         mangling schemes.
14347         * linespec.c (find_methods): Likewise.
14348         * stabsread.c (read_member_functions): Likewise.
14349         * valops.c (search_struct_method): Likewise.
14350         (value_struct_elt_for_reference): Likewise.
14351         * NEWS: Mention this change.
14352
14353 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14354
14355         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14356         print_source_lines.
14357         * source.c (print_source_lines_base): Update line number check.
14358         (print_source_lines): New function.
14359         (source_lines_range::source_lines_range): New function.
14360         * source.h (class source_lines_range): New class.
14361         (print_source_lines): New declaration.
14362
14363 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14364
14365         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14366
14367 2019-01-08  Tom Tromey  <tom@tromey.com>
14368             Simon Marchi  <simon.marchi@ericsson.com>
14369
14370         PR gdb/24060
14371         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14372         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14373         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14374         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14375         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14376         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14377
14378 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14379
14380         * source.c (select_source_symtab): Move header comment to
14381         declaration in source.h.
14382         (forget_cached_source_info_for_objfile): Likewise.
14383         (forget_cached_source_info): Likewise.
14384         (identify_source_line): Likewise.
14385         * source.h (identify_source_line): Move declaration from symtab.h
14386         and add comment from source.c
14387         (print_source_lines): Likewise.
14388         (forget_cached_source_info_for_objfile): Likewise.
14389         (forget_cached_source_info): Likewise.
14390         (select_source_symtab): Likewise.
14391         (enum print_source_lines_flag): Move definition from symtab.h.
14392         * symtab.h (identify_source_line): Move declaration to source.h.
14393         (print_source_lines): Likewise.
14394         (forget_cached_source_info_for_objfile): Likewise.
14395         (forget_cached_source_info): Likewise.
14396         (select_source_symtab): Likewise.
14397         (enum print_source_lines_flag): Move definition to source.h.
14398         * tui/tui-hooks.c: Add 'source.h' include.
14399
14400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14401
14402         * source.c (print_source_lines_base): Handle requests to print
14403         reverse line number sequences, and guard against empty lines
14404         string.
14405
14406 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14407
14408         * source.c (print_source_lines_base): Fix skip of '\r' if next
14409         character is '\n'.
14410
14411 2019-01-06  Tom Tromey  <tom@tromey.com>
14412
14413         * c-exp.y (struct c_parse_state) <macro_original_text,
14414         expansion_obstack>: New member.
14415         (macro_original_text, expansion_obstack): Remove globals.
14416         (scan_macro_expansion, scanning_macro_expansion)
14417         (finished_macro_expansion): Update.
14418         (scan_macro_cleanup): Remove.
14419         (yylex, c_parse): Update.
14420
14421 2019-01-06  Tom Tromey  <tom@tromey.com>
14422
14423         * c-exp.y (struct c_parse_state) <strings>: New member.
14424         (operator_stoken): Update.
14425
14426 2019-01-06  Tom Tromey  <tom@tromey.com>
14427
14428         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14429         (union type_stack_elt) <typelist_val>: Now a pointer to
14430         std::vector.
14431         (type_stack_cleanup): Don't declare.
14432         (push_typelist): Update.
14433         * parse.c (pop_typelist): Return a std::vector.
14434         (push_typelist): Take a std::vector.
14435         (follow_types): Update.  Do not free args.
14436         (type_stack_cleanup): Remove.
14437         * c-exp.y (struct c_parse_state): New.
14438         (cpstate): New global.
14439         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14440         (nonempty_typelist): Update.
14441         (func_mod): Create a new vector.
14442         (c_parse): Create a c_parse_state.
14443         (check_parameter_typelist): Do not delete params.
14444         (function_method): Update.  Do not delete type_list.
14445
14446 2019-01-06  Tom Tromey  <tom@tromey.com>
14447
14448         PR gdb/28155:
14449         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14450         check_typedef.
14451         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14452         (print_return_value): Likewise.
14453
14454 2019-01-05  Tom Tromey  <tom@tromey.com>
14455
14456         * contrib/cleanup_check.py: Remove.
14457         * contrib/gcc-with-excheck: Remove.
14458         * contrib/exsummary.py: Remove.
14459         * contrib/excheck.py: Remove.
14460
14461 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14462
14463         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14464         NULL. Initialize tpprev to NULL instead of assigning it
14465         to NULL on the next statement.
14466         * windows-nat.c (windows_delete_thread): Remove check for
14467         main_thread_id before printing thread exit notifications.
14468         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14469         Remove thread ID check against main_thread_id.
14470         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14471         windows_delete_thread.
14472         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14473
14474 2019-01-04  Tom Tromey  <tom@tromey.com>
14475
14476         * compile/compile.c (_initialize_compile): Use upper case for
14477         metasyntactic variables.
14478         * symmisc.c (_initialize_symmisc): Use upper case for
14479         metasyntactic variables.
14480         * psymtab.c (_initialize_psymtab): Use upper case for
14481         metasyntactic variables.
14482         * demangle.c (demangle_command): Use upper case for metasyntactic
14483         variables.
14484         (_initialize_demangler): Likewise.
14485         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14486         variables.
14487
14488 2019-01-03  Tom Tromey  <tom@tromey.com>
14489
14490         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14491
14492 2019-01-03  Tom Tromey  <tom@tromey.com>
14493
14494         * python/py-symtab.c (salpy_str): Update.
14495         (struct salpy_sal_object) <symtab>: Now a PyObject.
14496         (salpy_dealloc): Update.
14497         (del_objfile_sal): Use gdbpy_ref.
14498
14499 2019-01-03  Tom Tromey  <tom@tromey.com>
14500
14501         * python/py-type.c (convert_field): Use new_reference.  Return
14502         gdbpy_ref.
14503         (make_fielditem): Return gdbpy_ref.
14504         (typy_fields): Update.
14505         (typy_getitem): Update.
14506         (field_name): Return gdbpy_ref.  Use new_reference.
14507         (typy_iterator_iternext): Update.
14508
14509 2019-01-03  Tom Tromey  <tom@tromey.com>
14510
14511         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14512
14513 2019-01-03  Tom Tromey  <tom@tromey.com>
14514
14515         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14516         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14517         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14518         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14519         (pspy_set_type_printers): Likewise.
14520         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14521         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14522         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14523         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14524         (objfpy_set_type_printers): Likewise.
14525
14526 2019-01-03  Tom Tromey  <tom@tromey.com>
14527
14528         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14529         (gdbpy_print_stack): Use gdbpy_err_fetch.
14530         * python/python-internal.h (class gdbpy_err_fetch): New class.
14531         (class gdbpy_enter) <m_error_type, m_error_value,
14532         m_error_traceback>: Remove.
14533         <m_error>: New member.
14534         (gdbpy_exception_to_string): Don't declare.
14535         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14536         * python/py-value.c (convert_value_from_python): Use
14537         gdbpy_err_fetch.
14538         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14539         gdbpy_exception_to_string.
14540         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14541         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14542         gdbpy_err_fetch.
14543
14544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14545
14546         * linux-nat.c (delete_lwp_cleanup): Delete.
14547         (struct lwp_deleter): New struct.
14548         (lwp_info_up): New typedef.
14549         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14550         lwp_info_up.
14551
14552 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14553
14554         * linux-fork.c (class scoped_switch_fork_info): New class.
14555         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14556
14557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14558
14559         * valops.c (find_overload_match): Remove use of null_cleanup, and
14560         calls to do_cleanups.
14561
14562 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14563
14564         * compile/compile-cplus-types.c
14565         (compile_cplus_instance::decl_name): Handle changes to
14566         cp_func_name.
14567         * cp-support.c (cp_func_name): Update header comment, update
14568         return type.
14569         * cp-support.h (cp_func_name): Update return type in declaration.
14570         * valops.c (find_overload_match): Move temp_func local to top
14571         level of function and change its type.  Use temp_func to hold and
14572         delete temporary string obtained from cp_func_name.
14573
14574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14575
14576         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14577         gdb::char_vector, remove cleanup, and update uses of `msg`.
14578
14579 2019-01-03  Jim Wilson  <jimw@sifive.com>
14580
14581         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14582
14583 2019-01-02  Tom Tromey  <tom@tromey.com>
14584
14585         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14586         (tdesc_parse_xml): Remove cleanups.
14587         * target-descriptions.h (make_cleanup_free_target_description):
14588         Don't declare.
14589         (target_desc_deleter): New struct.
14590         (target_desc_up): New typedef.
14591         * target-descriptions.c (target_desc_deleter::operator()): Rename
14592         from free_target_description.
14593         (make_cleanup_free_target_description): Remove.
14594
14595 2019-01-02  Tom Tromey  <tom@tromey.com>
14596
14597         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14598         constructor, destructor.
14599         (linespec_parser): Remove typedef.
14600         (~linespec_parser): Rename from linespec_parser_delete.
14601         (linespec_lex_to_end, linespec_complete_label)
14602         (linespec_complete): Update.
14603         (decode_line_full): Remove cleanups.
14604         (decode_line_1): Update.
14605
14606 2019-01-02  Tom Tromey  <tom@tromey.com>
14607
14608         * python/python-internal.h (inferior_to_inferior_object): Change
14609         return type.
14610         * python/py-exitedevent.c (create_exited_event_object): Update.
14611         * python/py-inferior.c (inferior_to_inferior_object): Return
14612         gdbpy_ref.
14613         (python_new_inferior, python_inferior_deleted)
14614         (thread_to_thread_object, delete_thread_object)
14615         (build_inferior_list, gdbpy_selected_inferior): Update.
14616         * python/py-infthread.c (create_thread_object): Update.  Also fail
14617         if inferior_to_inferior_object fails.
14618
14619 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14620
14621         * inferior.h (class inferior) <displaced_step_state>: New field.
14622         * infrun.h (struct displaced_step_state): Move here from
14623         infrun.c.  Initialize fields, add constructor.
14624         <inf>: Remove field.
14625         <reset>: New method.
14626         * infrun.c (struct displaced_step_inferior_state): Move to
14627         infrun.h.
14628         (displaced_step_inferior_states): Remove.
14629         (get_displaced_stepping_state): Adust.
14630         (displaced_step_in_progress_any_inferior): Adjust.
14631         (displaced_step_in_progress_thread): Adjust.
14632         (displaced_step_in_progress): Adjust.
14633         (add_displaced_stepping_state): Remove.
14634         (get_displaced_step_closure_by_addr): Adjust.
14635         (remove_displaced_stepping_state): Remove.
14636         (infrun_inferior_exit): Call displaced_step_state.reset.
14637         (use_displaced_stepping): Don't check for NULL.
14638         (displaced_step_prepare_throw): Call
14639         get_displaced_stepping_state.
14640         (displaced_step_fixup): Don't check for NULL.
14641         (prepare_for_detach): Don't check for NULL.
14642
14643 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14644
14645         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14646          in case of call that did not complete.
14647
14648 2019-01-02  Andrey Utkin  <autkin@undo.io>
14649
14650         * symfile.c (find_separate_debug_file): Fix search of debug files for
14651         remote debuggee.
14652
14653 2019-01-02  Tom Tromey  <tom@tromey.com>
14654
14655         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14656         indentation.
14657         * python/py-frame.c (frapy_older): Remove cast.
14658         (frapy_newer): Likewise.
14659         * python/py-breakpoint.c (local_setattro): Remove cast.
14660         * python/py-arch.c (archpy_name): Remove local variable.
14661         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14662
14663 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14664
14665         * unittests/basic_string_view/element_access/char/empty.cc:
14666         Fix year range in copyright header.
14667
14668 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14669
14670         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14671         Delete.
14672         <operator==>: Update with for removed field.
14673         <hash>: Likewise.
14674         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14675         <isa_features>: ...this.
14676         <abi_features>: New field.
14677         (riscv_isa_flen): Update comment.
14678         (riscv_abi_xlen): New declaration.
14679         (riscv_abi_flen): New declaration.
14680         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14681         isa_features.
14682         (riscv_abi_xlen): New function.
14683         (riscv_isa_flen): Update to get answer from isa_features.
14684         (riscv_abi_flen): New function.
14685         (riscv_has_fp_abi): Update to get answer from abi_features.
14686         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14687         xlen and flen.
14688         (riscv_call_info) <xlen, flen>: Update comment.
14689         (riscv_call_arg_struct): Remove invalid assertions
14690         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14691         is removed.
14692         (riscv_gdbarch_init): Gather isa features and abi features
14693         separately, ensure both match on the gdbarch when reusing an old
14694         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14695         a target with 64-bit float hardware.
14696
14697 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14698
14699         * source.c (search_command_helper): Stop reverse search
14700         when line 1 has been searched.
14701
14702 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14703
14704         * record-full.c (record_full_base_target::close): Rewrite
14705         record_full_core_buf_list free logic.
14706
14707 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14708
14709         * break-catch-syscall.c (print_one_catch_syscall): xfree
14710         the last text.
14711
14712 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14713
14714         * top.c (print_gdb_version): Update Copyright year in version
14715         message.
14716
14717 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14718
14719         Update copyright year range in all GDB files.
14720
14721 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14722
14723         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14724
14725 For older changes see ChangeLog-2018.
14726 \f
14727 Local Variables:
14728 mode: change-log
14729 left-margin: 8
14730 fill-column: 74
14731 version-control: never
14732 coding: utf-8
14733 End:
14734