gdb/ChangeLog

   1 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
   2             Pedro Alves  <palves@redhat.com>
   3
   4         * utils.c (set_screen_size): Reduce "infinite" rows and columns
   5         before calling rl_set_screen_size.
   6
   7 2019-02-27  Tom Tromey  <tromey@adacore.com>
   8
   9         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
  10         define.
  11         * python/py-value.c: Remove Python 2.4 workaround.
  12         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
  13         workaround.
  14         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
  15         Python 2.4 workaround.
  16         * python/python-internal.h: Remove Python 2.4 comment.
  17         (Py_ssize_t): Don't define.
  18         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
  19         (gdb_Py_DECREF): Remove Python 2.4 workaround.
  20         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
  21         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
  22         * python/python.c (do_start_initialization): Remove Python 2.4
  23         workaround.
  24         * python/py-prettyprint.c (class dummy_python_frame): Remove.
  25         (print_children): Remove Python 2.4 workaround.
  26         * python/py-inferior.c (buffer_procs): Remove Python 2.4
  27         workaround.
  28         (CHARBUFFERPROC_NAME): Remove.
  29         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
  30         Python 2.4 workaround.
  31
  32 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  33
  34         * NEWS: Note minimum Python version.
  35
  36 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  37
  38         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
  39         code from these functions.  Remove corresponding ifdefs.  Use
  40         Py_buffer_up instead of explicit calls to PyBuffer_Release.
  41         Remove gotos and target of gotos.
  42         (infpy_search_memory): Likewise.
  43
  44 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  45
  46         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
  47         (hppa_gdbarch_init): Don't register deleted functions with
  48         gdbarch.
  49
  50 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
  53         (h8300_unwind_sp): Delete.
  54         (h8300_dummy_id): Delete.
  55         (h8300_gdbarch_init): Don't register deleted functions with
  56         gdbarch.
  57
  58 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  59
  60         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
  61         (ft32_unwind_pc): Delete.
  62         (ft32_unwind_sp): Delete.
  63         (ft32_gdbarch_init): Don't register deleted functions with
  64         gdbarch.
  65
  66 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * gdb/frv-tdep.c (frv_dummy_id): Delete.
  69         (frv_unwind_pc): Delete.
  70         (frv_unwind_sp): Delete.
  71         (frv_gdbarch_init): Don't register deleted functions with
  72         gdbarch.
  73
  74 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
  77         (riscv_unwind_pc): Delete.
  78         (riscv_unwind_sp): Delete.
  79         (riscv_gdbarch_init): Don't register deleted functions with
  80         gdbarch.
  81
  82 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * gdb/csky-tdep.c (csky_dummy_id): Delete.
  85         (csky_unwind_pc): Delete.
  86         (csky_unwind_sp): Delete.
  87         (csky_gdbarch_init): Don't register deleted functions with
  88         gdbarch.
  89
  90 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * gdb/cris-tdep.c (cris_dummy_id): Delete.
  93         (cris_unwind_pc): Delete.
  94         (cris_unwind_sp): Delete.
  95         (cris_gdbarch_init): Don't register deleted functions with
  96         gdbarch.
  97
  98 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  99
 100         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 101         (bfin_unwind_pc): Delete.
 102         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 103
 104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 107         (arm_unwind_pc): Delete.
 108         (arm_unwind_sp): Delete.
 109         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 110
 111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 114         (arc_unwind_pc): Delete.
 115         (arc_unwind_sp): Delete.
 116         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 117
 118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 121         (alpha_unwind_pc): Delete.
 122         (alpha_gdbarch_init): Don't register deleted functions with
 123         gdbarch.
 124
 125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 128         (aarch64_unwind_pc): Delete.
 129         (aarch64_unwind_sp): Delete.
 130         (aarch64_gdbarch_init): Don't register deleted functions with
 131         gdbarch.
 132
 133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * gdbtypes.c (type_align): Don't consider static members when
 136         computing structure alignment.
 137
 138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 141         return 0 for other types.
 142         * arch-utils.c (default_type_align): Always return 0.
 143         * gdbarch.h: Regenerate.
 144         * gdbarch.sh (type_align): Extend comment.
 145         * gdbtypes.c (type_align): Add additional comments, always call
 146         gdbarch_type_align before applying the default rules.
 147         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 148         generic code will then apply a suitable default.
 149         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 150         types, return 0 for other types.
 151
 152 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 153
 154         * NEWS: Create a new section for the next release branch.
 155         Rename the section of the current branch, now that it has
 156         been cut.
 157
 158 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 159
 160         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 161         * version.in: Bump version to 8.3.50.DATE-git.
 162
 163 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 164
 165         * aix-thread.c (ptid_cmp): Remove unused variable.
 166         (get_signaled_thread): Likewise.
 167         (store_regs_user_thread): Likewise.
 168         (store_regs_kernel_thread): Likewise.
 169         (fetch_regs_kernel_thread): Remove shadowed variable.
 170
 171 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * features/riscv/32bit-cpu.xml: Add register numbers.
 174         * features/riscv/32bit-fpu.c: Regenerate.
 175         * features/riscv/32bit-fpu.xml: Add register numbers.
 176         * features/riscv/64bit-cpu.xml: Add register numbers.
 177         * features/riscv/64bit-fpu.c: Regenerate.
 178         * features/riscv/64bit-fpu.xml: Add register numbers.
 179
 180 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 181
 182         * NEWS: Mention two argument form of gdb.Value constructor.
 183         * python/py-value.c (convert_buffer_and_type_to_value): New
 184         function.
 185         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 186         Add support for handling an optional second argument.  Call
 187         convert_buffer_and_type_to_value as appropriate.
 188         * python/python-internal.h (Py_buffer_deleter): New struct.
 189         (Py_buffer_up): New typedef.
 190
 191 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 192
 193         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 194         instead of releasing ownership.
 195
 196 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 197
 198         * dwarf2read.c (open_and_init_dwp_file): Call
 199         elf_numsections instead of bfd_count_sections to initialize
 200         dwp_file->num_sections.
 201
 202 2019-02-25  Tom Tromey  <tromey@adacore.com>
 203
 204         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 205
 206 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 207
 208         * gcore.in: Add '--readnever' option when invoking GDB.
 209
 210 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 211
 212         * MAINTAINERS: Update my email address.
 213
 214 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 215
 216         * build-id.c (build_id_to_debug_bfd_1): New function.
 217         (build_id_to_debug_bfd): Look for separate debug file in
 218         sysroot.
 219
 220 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 221
 222         * gdbarch.sh: Update the copyright year range that is placed into
 223         generated files.
 224
 225 2019-02-22  Keith Seitz  <keiths@redhat.com>
 226
 227         PR symtab/23853
 228         * linespec.c (create_sals_line_offset): Search for the default
 229         symtab's filename instead of its fullname.
 230
 231 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 232
 233         * NEWS: Update style defaults.
 234
 235 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 236
 237         * main.c (captured_main_1): Disable styling in batch mode.
 238
 239 2019-02-20  Tom Tromey  <tom@tromey.com>
 240
 241         * symtab.c (symtab_symbol_info): Fix typos.
 242
 243 2019-02-20  Tom Tromey  <tromey@adacore.com>
 244
 245         * findcmd.c (_initialize_mem_search): Use upper case for
 246         metasyntactic variables.
 247
 248 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 251         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 252
 253 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 254
 255         * top.h (source_file_name): Change to std::string.
 256         * top.c (source_file_name): Likewise.
 257         (command_line_input): Adjust.
 258         * cli/cli-script.c (script_from_file): Adjust.
 259
 260 2019-02-19  Tom Tromey  <tromey@adacore.com>
 261
 262         * ravenscar-thread.c
 263         (ravenscar_thread_target::update_thread_list): Don't call
 264         ada_build_task_list.
 265         * ada-lang.h (ada_build_task_list): Don't declare.
 266         * ada-tasks.c (struct ada_tasks_inferior_data)
 267         <task_list_valid_p>: Now bool.
 268         (read_known_tasks, ada_task_list_changed)
 269         (ada_tasks_invalidate_inferior_data): Update.
 270         (read_known_tasks_array): Return bool.
 271         (read_known_tasks_list): Likewise.
 272         (read_known_tasks): Return void.
 273         (ada_build_task_list): Now static.
 274
 275 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 278         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 279
 280 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 281
 282         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 283         variant for ada_tasks_pspace_data_handle and
 284         ada_tasks_inferior_data_handle.
 285         (ada_tasks_pspace_data_cleanup): New function.
 286         (ada_tasks_inferior_data_cleanup): New function.
 287
 288 2019-02-17  Tom Tromey  <tom@tromey.com>
 289
 290         * macrotab.h (macro_source_fullname): Return a std::string.
 291         * macrotab.c (macro_include, check_for_redefinition)
 292         (macro_undef, macro_lookup_definition, foreach_macro)
 293         (foreach_macro_in_scope): Update.
 294         (macro_source_fullname): Return a std::string.
 295         * macrocmd.c (show_pp_source_pos): Update.
 296
 297 2019-02-17  Tom Tromey  <tom@tromey.com>
 298
 299         * macrocmd.c (show_pp_source_pos): Style the file names.
 300
 301 2019-02-17  Tom Tromey  <tom@tromey.com>
 302
 303         PR tui/24197:
 304         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 305
 306 2019-02-17  Tom Tromey  <tom@tromey.com>
 307
 308         * ada-lang.c (user_select_syms): Use filtered printing.
 309         * utils.c (wrap_style): New global.
 310         (desired_style): Remove.
 311         (emit_style_escape): Add stream parameter.
 312         (set_output_style, reset_terminal_style, prompt_for_continue):
 313         Update.
 314         (flush_wrap_buffer): Only flush gdb_stdout.
 315         (wrap_here): Set wrap_style.
 316         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 317         treat escape sequences as a character.  Change when wrap buffer is
 318         flushed.
 319         (fputs_styled): Do not set the output style when the default is
 320         requested.
 321         * ui-style.h (struct ui_file_style) <is_default>: New method.
 322         * source.c (print_source_lines_base): Emit escape sequences in one
 323         piece.
 324
 325 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 326
 327         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 328         integers and enumeration types.
 329
 330 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 331
 332         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 333         instead of lookup_symbol_in_language
 334         (do_exact_match): New function.
 335         (ada_get_symbol_name_matcher): Return do_exact_match when
 336         doing a verbatim match.
 337
 338 2019-02-15  Tom Tromey  <tromey@adacore.com>
 339
 340         * ravenscar-thread.c (ravenscar_thread_target::resume)
 341         (ravenscar_thread_target::wait): Special case wildcard requests.
 342
 343 2019-02-15  Tom Tromey  <tromey@adacore.com>
 344
 345         * ravenscar-thread.c (base_ptid): Remove.
 346         (struct ravenscar_thread_target) <close>: New method.
 347         <m_base_ptid>: New member.
 348         <update_inferior_ptid, active_task, task_is_currently_active,
 349         runtime_initialized>: Declare methods.
 350         <ravenscar_thread_target>: Add constructor.
 351         (ravenscar_thread_target::task_is_currently_active)
 352         (ravenscar_thread_target::update_inferior_ptid)
 353         (ravenscar_runtime_initialized): Rename.  Now methods.
 354         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 355         (ravenscar_thread_target::update_thread_list): Update.
 356         (ravenscar_thread_target::active_task): Now method.
 357         (ravenscar_thread_target::store_registers)
 358         (ravenscar_thread_target::prepare_to_store)
 359         (ravenscar_thread_target::prepare_to_store)
 360         (ravenscar_thread_target::mourn_inferior): Update.
 361         (ravenscar_inferior_created): Use "new" to create target.
 362         (ravenscar_thread_target::get_ada_task_ptid): Update.
 363         (_initialize_ravenscar): Don't initialize base_ptid.
 364         (ravenscar_ops): Remove global.
 365
 366 2019-02-15  Tom Tromey  <tromey@adacore.com>
 367
 368         * target.h (push_target): Declare new overload.
 369         * target.c (push_target): New overload, taking an rvalue reference.
 370         * remote.c (remote_target::open_1): Use push_target overload.
 371         * corelow.c (core_target_open): Use push_target overload.
 372
 373 2019-02-15  Tom Tromey  <tromey@adacore.com>
 374
 375         * ravenscar-thread.c (is_ravenscar_task)
 376         (ravenscar_task_is_currently_active): Return bool.
 377         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 378         (_initialize_ravenscar): Remove "(void)".
 379         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 380         Return bool.
 381
 382 2019-02-15  Tom Tromey  <tromey@adacore.com>
 383
 384         * ravenscar-thread.c (ravenscar_runtime_initializer)
 385         (has_ravenscar_runtime, get_running_thread_id)
 386         (ravenscar_thread_target::resume): Fix indentation.
 387
 388 2019-02-15  Tom Tromey  <tromey@adacore.com>
 389
 390         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 391         from ravenscar_arch_ops.
 392         (sparc_ravenscar_ops::fetch_registers)
 393         (sparc_ravenscar_ops::store_registers): Now methods.
 394         (sparc_ravenscar_prepare_to_store): Remove.
 395         (sparc_ravenscar_ops): Redefine.
 396         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 397         methods and destructor.  Remove members.
 398         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 399         (ravenscar_thread_target::store_registers)
 400         (ravenscar_thread_target::prepare_to_store): Update.
 401         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 402         Remove.
 403         (struct ppc_ravenscar_powerpc_ops): Derive from
 404         ravenscar_arch_ops.
 405         (ppc_ravenscar_powerpc_ops::fetch_registers)
 406         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 407         (ppc_ravenscar_powerpc_ops): Redefine.
 408         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 409         (ppc_ravenscar_e500_ops::fetch_registers)
 410         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 411         (ppc_ravenscar_e500_ops): Redefine.
 412         * aarch64-ravenscar-thread.c
 413         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 414         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 415         (aarch64_ravenscar_fetch_registers)
 416         (aarch64_ravenscar_store_registers): Now methods.
 417         (aarch64_ravenscar_ops): Redefine.
 418
 419 2019-02-15  Tom Tromey  <tromey@adacore.com>
 420
 421         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 422         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 423         (ravenscar_thread_target::stopped_by_watchpoint)
 424         (ravenscar_thread_target::stopped_data_address)
 425         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 426
 427 2019-02-15  Tom Tromey  <tromey@adacore.com>
 428
 429         * ravenscar-thread.c: Fix some typos.
 430
 431 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 432             Tom Tromey  <tromey@adacore.com>
 433
 434         * ada-lang.c (ada_exception_sal): Change addr_string to a
 435         std::string.
 436         (create_ada_exception_catchpoint): Update.
 437
 438 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 439             Tom Tromey  <tromey@adacore.com>
 440
 441         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 442         (bp_location_ops): Remove.
 443         (base_breakpoint_allocate_location): Update.
 444         (free_bp_location): Update.
 445         * ada-lang.c (class ada_catchpoint_location)
 446         <ada_catchpoint_location>: Remove ops parameter.
 447         (ada_catchpoint_location_dtor): Remove.
 448         (ada_catchpoint_location_ops): Remove.
 449         (allocate_location_exception): Update.
 450         * breakpoint.h (struct bp_location_ops): Remove.
 451         (class bp_location) <bp_location>: Remove bp_location_ops
 452         parameter.
 453         <~bp_location>: Add destructor.
 454         <ops>: Remove.
 455
 456 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 457             Pedro Alves  <palves@redhat.com>
 458
 459         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 460         'PATH_MAX'.
 461
 462 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 463             Samuel Thibault  <samuel.thibault@gnu.org>
 464             Thomas Schwinge  <thomas@codesourcery.com>
 465
 466         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 467         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 468
 469 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 470
 471         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 472         (check_empty): Use "const char *".
 473
 474         * gnu-nat.c (gnu_nat_target::detach): Instead of
 475         'detach_inferior (pid)' call
 476         'detach_inferior (find_inferior_pid (pid))'.
 477
 478         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 479         'nat/fork-inferior.o'.
 480         * gnu-nat.c: #include "nat/fork-inferior.h".
 481
 482         * gnu-nat.c (gnu_nat_target::detach): Instead of
 483         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 484         * gnu-nat.h: #include "inf-child.h".
 485         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 486         'i386_gnu_nat_target::fetch_registers'.
 487         (gnu_store_registers): Rename/move to
 488         'i386_gnu_nat_target::store_registers'.
 489
 490         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 491         * gnu-nat.h (mach_thread_info): New function.
 492         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 493
 494         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 495
 496 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 497
 498         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 499
 500 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 501
 502         * windows-nat.c (windows_add_thread): Add new parameter
 503         "main_thread_p" with default value set to false.  Update
 504         function documentation as well as all callers.
 505         (windows_delete_thread): Likewise.
 506         (fake_create_process): Update call to windows_add_thread.
 507         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 508         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 509         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 510         call to windows_delete_thread.
 511
 512 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 513
 514         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 515
 516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 517
 518         * symfile.c (find_separate_debug_file): Use canonical path of
 519         sysroot with child_path instead of gdb_sysroot if it is valid.
 520
 521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 522
 523         * symfile.c (find_separate_debug_file): Use child_path to
 524         determine if an object file is under a sysroot.
 525
 526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 529         unittests/child-path-selftests.c.
 530         * common/pathstuff.c (child_path): New function.
 531         * common/pathstuff.h (child_path): New prototype.
 532         * unittests/child-path-selftests.c: New file.
 533
 534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 535
 536         * symfile.c (find_separate_debug_file): Look for separate debug
 537         files in debug directories under the sysroot.
 538
 539 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 540
 541         * symtab.h (struct minimal_symbol data_p): New const method.
 542         (struct minimal_symbol text_p): Likewise.
 543         * symtab.c (output_source_filename): Use file name style
 544         to print file name.
 545         (print_symbol_info): Likewise.
 546         (print_msymbol_info): Use address style to print addresses.
 547         Use function name style to print executable text symbols.
 548         (expand_symtab_containing_pc): Use data_p.
 549         (find_pc_sect_compunit_symtab): Likewise.
 550
 551 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 552
 553         * breakpoint.c (describe_other_breakpoints): Use address style
 554         to print addresses.
 555         (say_where): Likewise.
 556
 557 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 558
 559         * ada-typeprint.c (print_func_type): Print function name
 560         style to print function name.
 561         * c-typeprint.c (c_print_type_1): Likewise.
 562
 563 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 564
 565         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 566         for execve.
 567
 568 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 569
 570         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 571         type_stack.
 572
 573 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 574
 575         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 576         TYPE_CODE_REF types.
 577
 578 2019-02-08  Jim Wilson  <jimw@sifive.com>
 579
 580         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 581         (riscv_linux_fregset): New.
 582         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 583
 584 2019-02-07  Tom Tromey  <tom@tromey.com>
 585
 586         * thread.c (thread_cancel_execution_command): Update.
 587         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 588         methods.
 589         (struct thread_fsm_ops): Remove.
 590         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 591         (thread_fsm_should_stop, thread_fsm_return_value)
 592         (thread_fsm_set_finished, thread_fsm_finished_p)
 593         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 594         Don't declare.
 595         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 596         * infrun.c (clear_proceed_status_thread)
 597         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 598         (print_stop_event): Update.
 599         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 600         Add constructor.
 601         (step_command_fsm_ops): Remove.
 602         (new_step_command_fsm): Remove.
 603         (step_1): Update.
 604         (step_command_fsm::should_stop): Rename from
 605         step_command_fsm_should_stop.
 606         (step_command_fsm::clean_up): Rename from
 607         step_command_fsm_clean_up.
 608         (step_command_fsm::do_async_reply_reason): Rename from
 609         step_command_fsm_async_reply_reason.
 610         (struct until_next_fsm): Inherit from thread_fsm.  Add
 611         constructor.
 612         (until_next_fsm_ops): Remove.
 613         (new_until_next_fsm): Remove.
 614         (until_next_fsm::should_stop): Rename from
 615         until_next_fsm_should_stop.
 616         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 617         (until_next_fsm::do_async_reply_reason): Rename from
 618         until_next_fsm_async_reply_reason.
 619         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 620         constructor.  Change type of breakpoint.
 621         (finish_command_fsm_ops): Remove.
 622         (new_finish_command_fsm): Remove.
 623         (finish_command_fsm::should_stop): Rename from
 624         finish_command_fsm_should_stop.
 625         (finish_command_fsm::clean_up): Rename from
 626         finish_command_fsm_clean_up.
 627         (finish_command_fsm::return_value): Rename from
 628         finish_command_fsm_return_value.
 629         (finish_command_fsm::do_async_reply_reason): Rename from
 630         finish_command_fsm_async_reply_reason.
 631         (finish_command): Update.
 632         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 633         Add constructor.
 634         (call_thread_fsm_ops): Remove.
 635         (call_thread_fsm::call_thread_fsm): Rename from
 636         new_call_thread_fsm.
 637         (call_thread_fsm::should_stop): Rename from
 638         call_thread_fsm_should_stop.
 639         (call_thread_fsm::should_notify_stop): Rename from
 640         call_thread_fsm_should_notify_stop.
 641         (run_inferior_call, call_function_by_hand_dummy): Update.
 642         * cli/cli-interp.c (should_print_stop_to_console): Update.
 643         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 644         Add constructor.  Change type of location_breakpoint,
 645         caller_breakpoint.
 646         (until_break_fsm_ops): Remove.
 647         (new_until_break_fsm): Remove.
 648         (until_break_fsm::should_stop): Rename from
 649         until_break_fsm_should_stop.
 650         (until_break_fsm::clean_up): Rename from
 651         until_break_fsm_clean_up.
 652         (until_break_fsm::do_async_reply_reason): Rename from
 653         until_break_fsm_async_reply_reason.
 654         (until_break_command): Update.
 655         * thread-fsm.c: Remove.
 656         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 657
 658 2019-02-07  Tom Tromey  <tom@tromey.com>
 659
 660         * yy-remap.h: Add include guard.
 661         * xtensa-tdep.h: Add include guard.
 662         * xcoffread.h: Rename include guard.
 663         * varobj-iter.h: Add include guard.
 664         * tui/tui.h: Rename include guard.
 665         * tui/tui-winsource.h: Rename include guard.
 666         * tui/tui-wingeneral.h: Rename include guard.
 667         * tui/tui-windata.h: Rename include guard.
 668         * tui/tui-win.h: Rename include guard.
 669         * tui/tui-stack.h: Rename include guard.
 670         * tui/tui-source.h: Rename include guard.
 671         * tui/tui-regs.h: Rename include guard.
 672         * tui/tui-out.h: Rename include guard.
 673         * tui/tui-layout.h: Rename include guard.
 674         * tui/tui-io.h: Rename include guard.
 675         * tui/tui-hooks.h: Rename include guard.
 676         * tui/tui-file.h: Rename include guard.
 677         * tui/tui-disasm.h: Rename include guard.
 678         * tui/tui-data.h: Rename include guard.
 679         * tui/tui-command.h: Rename include guard.
 680         * tic6x-tdep.h: Add include guard.
 681         * target/waitstatus.h: Rename include guard.
 682         * target/wait.h: Rename include guard.
 683         * target/target.h: Rename include guard.
 684         * target/resume.h: Rename include guard.
 685         * target-float.h: Rename include guard.
 686         * stabsread.h: Add include guard.
 687         * rs6000-tdep.h: Add include guard.
 688         * riscv-fbsd-tdep.h: Add include guard.
 689         * regformats/regdef.h: Rename include guard.
 690         * record.h: Rename include guard.
 691         * python/python.h: Rename include guard.
 692         * python/python-internal.h: Rename include guard.
 693         * python/py-stopevent.h: Rename include guard.
 694         * python/py-ref.h: Rename include guard.
 695         * python/py-record.h: Rename include guard.
 696         * python/py-record-full.h: Rename include guard.
 697         * python/py-record-btrace.h: Rename include guard.
 698         * python/py-instruction.h: Rename include guard.
 699         * python/py-events.h: Rename include guard.
 700         * python/py-event.h: Rename include guard.
 701         * procfs.h: Add include guard.
 702         * proc-utils.h: Add include guard.
 703         * p-lang.h: Add include guard.
 704         * or1k-tdep.h: Rename include guard.
 705         * observable.h: Rename include guard.
 706         * nto-tdep.h: Rename include guard.
 707         * nat/x86-linux.h: Rename include guard.
 708         * nat/x86-linux-dregs.h: Rename include guard.
 709         * nat/x86-gcc-cpuid.h: Add include guard.
 710         * nat/x86-dregs.h: Rename include guard.
 711         * nat/x86-cpuid.h: Rename include guard.
 712         * nat/ppc-linux.h: Rename include guard.
 713         * nat/mips-linux-watch.h: Rename include guard.
 714         * nat/linux-waitpid.h: Rename include guard.
 715         * nat/linux-ptrace.h: Rename include guard.
 716         * nat/linux-procfs.h: Rename include guard.
 717         * nat/linux-osdata.h: Rename include guard.
 718         * nat/linux-nat.h: Rename include guard.
 719         * nat/linux-namespaces.h: Rename include guard.
 720         * nat/linux-btrace.h: Rename include guard.
 721         * nat/glibc_thread_db.h: Rename include guard.
 722         * nat/gdb_thread_db.h: Rename include guard.
 723         * nat/gdb_ptrace.h: Rename include guard.
 724         * nat/fork-inferior.h: Rename include guard.
 725         * nat/amd64-linux-siginfo.h: Rename include guard.
 726         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 727         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 728         * nat/aarch64-linux.h: Rename include guard.
 729         * nat/aarch64-linux-hw-point.h: Rename include guard.
 730         * mn10300-tdep.h: Add include guard.
 731         * mips-linux-tdep.h: Add include guard.
 732         * mi/mi-parse.h: Rename include guard.
 733         * mi/mi-out.h: Rename include guard.
 734         * mi/mi-main.h: Rename include guard.
 735         * mi/mi-interp.h: Rename include guard.
 736         * mi/mi-getopt.h: Rename include guard.
 737         * mi/mi-console.h: Rename include guard.
 738         * mi/mi-common.h: Rename include guard.
 739         * mi/mi-cmds.h: Rename include guard.
 740         * mi/mi-cmd-break.h: Rename include guard.
 741         * m2-lang.h: Add include guard.
 742         * location.h: Rename include guard.
 743         * linux-record.h: Rename include guard.
 744         * linux-nat.h: Add include guard.
 745         * linux-fork.h: Add include guard.
 746         * i386-darwin-tdep.h: Rename include guard.
 747         * hppa-linux-offsets.h: Add include guard.
 748         * guile/guile.h: Rename include guard.
 749         * guile/guile-internal.h: Rename include guard.
 750         * gnu-nat.h: Rename include guard.
 751         * gdb-stabs.h: Rename include guard.
 752         * frv-tdep.h: Add include guard.
 753         * f-lang.h: Add include guard.
 754         * event-loop.h: Add include guard.
 755         * darwin-nat.h: Rename include guard.
 756         * cp-abi.h: Rename include guard.
 757         * config/sparc/nm-sol2.h: Rename include guard.
 758         * config/nm-nto.h: Rename include guard.
 759         * config/nm-linux.h: Add include guard.
 760         * config/i386/nm-i386gnu.h: Rename include guard.
 761         * config/djgpp/nl_types.h: Rename include guard.
 762         * config/djgpp/langinfo.h: Rename include guard.
 763         * compile/gcc-cp-plugin.h: Add include guard.
 764         * compile/gcc-c-plugin.h: Add include guard.
 765         * compile/compile.h: Rename include guard.
 766         * compile/compile-object-run.h: Rename include guard.
 767         * compile/compile-object-load.h: Rename include guard.
 768         * compile/compile-internal.h: Rename include guard.
 769         * compile/compile-cplus.h: Rename include guard.
 770         * compile/compile-c.h: Rename include guard.
 771         * common/xml-utils.h: Rename include guard.
 772         * common/x86-xstate.h: Rename include guard.
 773         * common/version.h: Rename include guard.
 774         * common/vec.h: Rename include guard.
 775         * common/tdesc.h: Rename include guard.
 776         * common/selftest.h: Rename include guard.
 777         * common/scoped_restore.h: Rename include guard.
 778         * common/scoped_mmap.h: Rename include guard.
 779         * common/scoped_fd.h: Rename include guard.
 780         * common/safe-iterator.h: Rename include guard.
 781         * common/run-time-clock.h: Rename include guard.
 782         * common/refcounted-object.h: Rename include guard.
 783         * common/queue.h: Rename include guard.
 784         * common/ptid.h: Rename include guard.
 785         * common/print-utils.h: Rename include guard.
 786         * common/preprocessor.h: Rename include guard.
 787         * common/pathstuff.h: Rename include guard.
 788         * common/observable.h: Rename include guard.
 789         * common/netstuff.h: Rename include guard.
 790         * common/job-control.h: Rename include guard.
 791         * common/host-defs.h: Rename include guard.
 792         * common/gdb_wait.h: Rename include guard.
 793         * common/gdb_vecs.h: Rename include guard.
 794         * common/gdb_unlinker.h: Rename include guard.
 795         * common/gdb_unique_ptr.h: Rename include guard.
 796         * common/gdb_tilde_expand.h: Rename include guard.
 797         * common/gdb_sys_time.h: Rename include guard.
 798         * common/gdb_string_view.h: Rename include guard.
 799         * common/gdb_splay_tree.h: Rename include guard.
 800         * common/gdb_setjmp.h: Rename include guard.
 801         * common/gdb_ref_ptr.h: Rename include guard.
 802         * common/gdb_optional.h: Rename include guard.
 803         * common/gdb_locale.h: Rename include guard.
 804         * common/gdb_assert.h: Rename include guard.
 805         * common/filtered-iterator.h: Rename include guard.
 806         * common/filestuff.h: Rename include guard.
 807         * common/fileio.h: Rename include guard.
 808         * common/environ.h: Rename include guard.
 809         * common/common-utils.h: Rename include guard.
 810         * common/common-types.h: Rename include guard.
 811         * common/common-regcache.h: Rename include guard.
 812         * common/common-inferior.h: Rename include guard.
 813         * common/common-gdbthread.h: Rename include guard.
 814         * common/common-exceptions.h: Rename include guard.
 815         * common/common-defs.h: Rename include guard.
 816         * common/common-debug.h: Rename include guard.
 817         * common/cleanups.h: Rename include guard.
 818         * common/buffer.h: Rename include guard.
 819         * common/btrace-common.h: Rename include guard.
 820         * common/break-common.h: Rename include guard.
 821         * cli/cli-utils.h: Rename include guard.
 822         * cli/cli-style.h: Rename include guard.
 823         * cli/cli-setshow.h: Rename include guard.
 824         * cli/cli-script.h: Rename include guard.
 825         * cli/cli-interp.h: Rename include guard.
 826         * cli/cli-decode.h: Rename include guard.
 827         * cli/cli-cmds.h: Rename include guard.
 828         * charset-list.h: Add include guard.
 829         * buildsym-legacy.h: Rename include guard.
 830         * bfin-tdep.h: Add include guard.
 831         * ax.h: Rename include guard.
 832         * arm-linux-tdep.h: Add include guard.
 833         * arm-fbsd-tdep.h: Add include guard.
 834         * arch/xtensa.h: Rename include guard.
 835         * arch/tic6x.h: Add include guard.
 836         * arch/i386.h: Add include guard.
 837         * arch/arm.h: Rename include guard.
 838         * arch/arm-linux.h: Rename include guard.
 839         * arch/arm-get-next-pcs.h: Rename include guard.
 840         * arch/amd64.h: Add include guard.
 841         * arch/aarch64-insn.h: Rename include guard.
 842         * arch-utils.h: Rename include guard.
 843         * annotate.h: Add include guard.
 844         * amd64-darwin-tdep.h: Rename include guard.
 845         * aarch64-linux-tdep.h: Add include guard.
 846         * aarch64-fbsd-tdep.h: Add include guard.
 847         * aarch32-linux-nat.h: Add include guard.
 848
 849 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * macrotab.c (macro_define_internal): New function that
 852         factorizes macro_define_object_internal and macro_define_function
 853         code.
 854         (macro_define_object_internal): Use macro_define_internal.
 855         (macro_define_function): Likewise.
 856
 857 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 858
 859         * macrocmd.c (extract_identifier): Return
 860         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 861         callers.
 862
 863 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 864
 865         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 866
 867 2019-02-05  Tom Tromey  <tom@tromey.com>
 868
 869         * target.c (target_stack::unpush): Move assertion earlier.
 870
 871 2019-01-30  Tom Tromey  <tom@tromey.com>
 872
 873         PR python/23615:
 874         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 875         (gdbpy_parse_and_eval): Likewise.
 876         * python/python-internal.h (gdbpy_allow_threads): New class.
 877
 878 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 879
 880         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 881         (aarch64_fbsd_fpregmap): Move earlier.
 882         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 883         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 884         instead of individual calls to trad_frame_set_reg_addr.
 885         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 886         earlier.
 887         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 888         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 889         instead of individual calls to trad_frame_set_reg_addr.
 890
 891 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 892
 893         * CONTRIBUTE: Replace contribution list with wiki link.
 894
 895 2019-01-25  Tom Tromey  <tom@tromey.com>
 896
 897         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 898
 899 2019-01-25  Tom Tromey  <tom@tromey.com>
 900
 901         * xtensa-linux-nat.c: Fix common/ includes.
 902         * xml-support.h: Fix common/ includes.
 903         * xml-support.c: Fix common/ includes.
 904         * x86-linux-nat.c: Fix common/ includes.
 905         * windows-nat.c: Fix common/ includes.
 906         * varobj.h: Fix common/ includes.
 907         * varobj.c: Fix common/ includes.
 908         * value.c: Fix common/ includes.
 909         * valops.c: Fix common/ includes.
 910         * utils.c: Fix common/ includes.
 911         * unittests/xml-utils-selftests.c: Fix common/ includes.
 912         * unittests/utils-selftests.c: Fix common/ includes.
 913         * unittests/unpack-selftests.c: Fix common/ includes.
 914         * unittests/tracepoint-selftests.c: Fix common/ includes.
 915         * unittests/style-selftests.c: Fix common/ includes.
 916         * unittests/string_view-selftests.c: Fix common/ includes.
 917         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 918         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 919         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 920         * unittests/rsp-low-selftests.c: Fix common/ includes.
 921         * unittests/parse-connection-spec-selftests.c: Fix common/
 922         includes.
 923         * unittests/optional-selftests.c: Fix common/ includes.
 924         * unittests/offset-type-selftests.c: Fix common/ includes.
 925         * unittests/observable-selftests.c: Fix common/ includes.
 926         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 927         * unittests/memrange-selftests.c: Fix common/ includes.
 928         * unittests/memory-map-selftests.c: Fix common/ includes.
 929         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 930         * unittests/function-view-selftests.c: Fix common/ includes.
 931         * unittests/environ-selftests.c: Fix common/ includes.
 932         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 933         * unittests/common-utils-selftests.c: Fix common/ includes.
 934         * unittests/cli-utils-selftests.c: Fix common/ includes.
 935         * unittests/array-view-selftests.c: Fix common/ includes.
 936         * ui-file.c: Fix common/ includes.
 937         * tui/tui-io.c: Fix common/ includes.
 938         * tracepoint.h: Fix common/ includes.
 939         * tracepoint.c: Fix common/ includes.
 940         * tracefile-tfile.c: Fix common/ includes.
 941         * top.h: Fix common/ includes.
 942         * top.c: Fix common/ includes.
 943         * thread.c: Fix common/ includes.
 944         * target/waitstatus.h: Fix common/ includes.
 945         * target/waitstatus.c: Fix common/ includes.
 946         * target.h: Fix common/ includes.
 947         * target.c: Fix common/ includes.
 948         * target-memory.c: Fix common/ includes.
 949         * target-descriptions.c: Fix common/ includes.
 950         * symtab.h: Fix common/ includes.
 951         * symfile.c: Fix common/ includes.
 952         * stap-probe.c: Fix common/ includes.
 953         * spu-linux-nat.c: Fix common/ includes.
 954         * sparc-nat.c: Fix common/ includes.
 955         * source.c: Fix common/ includes.
 956         * solib.c: Fix common/ includes.
 957         * solib-target.c: Fix common/ includes.
 958         * ser-unix.c: Fix common/ includes.
 959         * ser-tcp.c: Fix common/ includes.
 960         * ser-pipe.c: Fix common/ includes.
 961         * ser-base.c: Fix common/ includes.
 962         * selftest-arch.c: Fix common/ includes.
 963         * s12z-tdep.c: Fix common/ includes.
 964         * rust-exp.y: Fix common/ includes.
 965         * rs6000-aix-tdep.c: Fix common/ includes.
 966         * riscv-tdep.c: Fix common/ includes.
 967         * remote.c: Fix common/ includes.
 968         * remote-notif.h: Fix common/ includes.
 969         * remote-fileio.h: Fix common/ includes.
 970         * remote-fileio.c: Fix common/ includes.
 971         * regcache.h: Fix common/ includes.
 972         * regcache.c: Fix common/ includes.
 973         * record-btrace.c: Fix common/ includes.
 974         * python/python.c: Fix common/ includes.
 975         * python/py-type.c: Fix common/ includes.
 976         * python/py-inferior.c: Fix common/ includes.
 977         * progspace.h: Fix common/ includes.
 978         * producer.c: Fix common/ includes.
 979         * procfs.c: Fix common/ includes.
 980         * proc-api.c: Fix common/ includes.
 981         * printcmd.c: Fix common/ includes.
 982         * ppc-linux-nat.c: Fix common/ includes.
 983         * parser-defs.h: Fix common/ includes.
 984         * osdata.c: Fix common/ includes.
 985         * obsd-nat.c: Fix common/ includes.
 986         * nat/x86-linux.c: Fix common/ includes.
 987         * nat/x86-linux-dregs.c: Fix common/ includes.
 988         * nat/x86-dregs.h: Fix common/ includes.
 989         * nat/x86-dregs.c: Fix common/ includes.
 990         * nat/ppc-linux.c: Fix common/ includes.
 991         * nat/mips-linux-watch.h: Fix common/ includes.
 992         * nat/mips-linux-watch.c: Fix common/ includes.
 993         * nat/linux-waitpid.c: Fix common/ includes.
 994         * nat/linux-ptrace.h: Fix common/ includes.
 995         * nat/linux-ptrace.c: Fix common/ includes.
 996         * nat/linux-procfs.c: Fix common/ includes.
 997         * nat/linux-personality.c: Fix common/ includes.
 998         * nat/linux-osdata.c: Fix common/ includes.
 999         * nat/linux-namespaces.c: Fix common/ includes.
1000         * nat/linux-btrace.h: Fix common/ includes.
1001         * nat/linux-btrace.c: Fix common/ includes.
1002         * nat/fork-inferior.c: Fix common/ includes.
1003         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1004         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1005         * nat/aarch64-linux.c: Fix common/ includes.
1006         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1007         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1008         * namespace.h: Fix common/ includes.
1009         * mips-linux-tdep.c: Fix common/ includes.
1010         * minsyms.c: Fix common/ includes.
1011         * mi/mi-parse.h: Fix common/ includes.
1012         * mi/mi-main.c: Fix common/ includes.
1013         * mi/mi-cmd-env.c: Fix common/ includes.
1014         * memrange.h: Fix common/ includes.
1015         * memattr.c: Fix common/ includes.
1016         * maint.h: Fix common/ includes.
1017         * maint.c: Fix common/ includes.
1018         * main.c: Fix common/ includes.
1019         * machoread.c: Fix common/ includes.
1020         * location.c: Fix common/ includes.
1021         * linux-thread-db.c: Fix common/ includes.
1022         * linux-nat.c: Fix common/ includes.
1023         * linux-fork.c: Fix common/ includes.
1024         * inline-frame.c: Fix common/ includes.
1025         * infrun.c: Fix common/ includes.
1026         * inflow.c: Fix common/ includes.
1027         * inferior.h: Fix common/ includes.
1028         * inferior.c: Fix common/ includes.
1029         * infcmd.c: Fix common/ includes.
1030         * inf-ptrace.c: Fix common/ includes.
1031         * inf-child.c: Fix common/ includes.
1032         * ia64-linux-nat.c: Fix common/ includes.
1033         * i387-tdep.c: Fix common/ includes.
1034         * i386-tdep.c: Fix common/ includes.
1035         * i386-linux-tdep.c: Fix common/ includes.
1036         * i386-linux-nat.c: Fix common/ includes.
1037         * i386-go32-tdep.c: Fix common/ includes.
1038         * i386-fbsd-tdep.c: Fix common/ includes.
1039         * i386-fbsd-nat.c: Fix common/ includes.
1040         * guile/scm-type.c: Fix common/ includes.
1041         * guile/guile.c: Fix common/ includes.
1042         * go32-nat.c: Fix common/ includes.
1043         * gnu-nat.c: Fix common/ includes.
1044         * gdbthread.h: Fix common/ includes.
1045         * gdbarch-selftests.c: Fix common/ includes.
1046         * gdb_usleep.c: Fix common/ includes.
1047         * gdb_select.h: Fix common/ includes.
1048         * gdb_bfd.c: Fix common/ includes.
1049         * gcore.c: Fix common/ includes.
1050         * fork-child.c: Fix common/ includes.
1051         * findvar.c: Fix common/ includes.
1052         * fbsd-nat.c: Fix common/ includes.
1053         * event-top.c: Fix common/ includes.
1054         * event-loop.c: Fix common/ includes.
1055         * dwarf2read.c: Fix common/ includes.
1056         * dwarf2loc.c: Fix common/ includes.
1057         * dwarf2-frame.c: Fix common/ includes.
1058         * dwarf-index-cache.c: Fix common/ includes.
1059         * dtrace-probe.c: Fix common/ includes.
1060         * disasm-selftests.c: Fix common/ includes.
1061         * defs.h: Fix common/ includes.
1062         * csky-tdep.c: Fix common/ includes.
1063         * cp-valprint.c: Fix common/ includes.
1064         * cp-support.h: Fix common/ includes.
1065         * cp-support.c: Fix common/ includes.
1066         * corelow.c: Fix common/ includes.
1067         * completer.h: Fix common/ includes.
1068         * completer.c: Fix common/ includes.
1069         * compile/compile.c: Fix common/ includes.
1070         * compile/compile-loc2c.c: Fix common/ includes.
1071         * compile/compile-cplus-types.c: Fix common/ includes.
1072         * compile/compile-cplus-symbols.c: Fix common/ includes.
1073         * command.h: Fix common/ includes.
1074         * cli/cli-dump.c: Fix common/ includes.
1075         * cli/cli-cmds.c: Fix common/ includes.
1076         * charset.c: Fix common/ includes.
1077         * build-id.c: Fix common/ includes.
1078         * btrace.h: Fix common/ includes.
1079         * btrace.c: Fix common/ includes.
1080         * breakpoint.h: Fix common/ includes.
1081         * breakpoint.c: Fix common/ includes.
1082         * ax.h:
1083         (enum agent_op): Fix common/ includes.
1084         * ax-general.c (struct aop_map): Fix common/ includes.
1085         * ax-gdb.c: Fix common/ includes.
1086         * auxv.c: Fix common/ includes.
1087         * auto-load.c: Fix common/ includes.
1088         * arm-tdep.c: Fix common/ includes.
1089         * arch/riscv.c: Fix common/ includes.
1090         * arch/ppc-linux-common.c: Fix common/ includes.
1091         * arch/i386.c: Fix common/ includes.
1092         * arch/arm.c: Fix common/ includes.
1093         * arch/arm-linux.c: Fix common/ includes.
1094         * arch/arm-get-next-pcs.c: Fix common/ includes.
1095         * arch/amd64.c: Fix common/ includes.
1096         * arch/aarch64.c: Fix common/ includes.
1097         * arch/aarch64-insn.c: Fix common/ includes.
1098         * arch-utils.c: Fix common/ includes.
1099         * amd64-windows-tdep.c: Fix common/ includes.
1100         * amd64-tdep.c: Fix common/ includes.
1101         * amd64-sol2-tdep.c: Fix common/ includes.
1102         * amd64-obsd-tdep.c: Fix common/ includes.
1103         * amd64-nbsd-tdep.c: Fix common/ includes.
1104         * amd64-linux-tdep.c: Fix common/ includes.
1105         * amd64-linux-nat.c: Fix common/ includes.
1106         * amd64-fbsd-tdep.c: Fix common/ includes.
1107         * amd64-fbsd-nat.c: Fix common/ includes.
1108         * amd64-dicos-tdep.c: Fix common/ includes.
1109         * amd64-darwin-tdep.c: Fix common/ includes.
1110         * agent.c: Fix common/ includes.
1111         * ada-lang.h: Fix common/ includes.
1112         * ada-lang.c: Fix common/ includes.
1113         * aarch64-tdep.c: Fix common/ includes.
1114
1115 2019-01-25  Tom Tromey  <tom@tromey.com>
1116
1117         * common/create-version.sh: Use common/version.h.
1118
1119 2019-01-24  Pedro Alves  <palves@redhat.com>
1120
1121         * infrun.c (signal_stop, signal_print, signal_program)
1122         (signal_catch, signal_pass): Now arrays instead of pointers.
1123         (update_signals_program_target, do_target_resume)
1124         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1125         * linux-nat.c (linux_nat_target::pass_signals)
1126         (linux_nat_target::create_inferior, linux_nat_target::attach):
1127         Adjust.
1128         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1129         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1130         * procfs.c (procfs_target::pass_signals): Adjust.
1131         * record-full.c (record_full_target::resume): Adjust.
1132         * remote.c (remote_target::pass_signals)
1133         (remote_target::program_signals): Adjust.
1134         * target-debug.h (target_debug_print_signals): Now takes a
1135         gdb::array_view as parameter.  Adjust.
1136         * target.h (target_ops) <pass_signals, program_signals>: Replace
1137         pointer and length parameters with gdb::array_view.
1138         (target_pass_signals, target_program_signals): Likewise.
1139         * target-delegates.c: Regenerate.
1140
1141 2019-01-24  Pedro Alves  <palves@redhat.com>
1142
1143         * common/forward-scope-exit.h
1144         (forward_scope_exit::forward_scope_exit): Pass arguments to
1145         m_bind_function directly, instead of creating a std::bind and
1146         copying that.
1147
1148 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1151         for static members.
1152         (pass_in_v_vfp_candidate): Likewise.
1153
1154 2019-01-23  Tom Tromey  <tom@tromey.com>
1155             Pedro Alves  <palves@redhat.com>
1156
1157         * regcache.c (class regcache_invalidator): Remove.
1158         (regcache::raw_write): Use make_scope_exit.
1159
1160 2019-01-23  Tom Tromey  <tom@tromey.com>
1161
1162         * ui-out.h (class ui_out_emit_type): Update comment.
1163
1164 2019-01-23  Tom Tromey  <tom@tromey.com>
1165
1166         * infrun.c (fetch_inferior_event): Update comment.
1167
1168 2019-01-23  Tom Tromey  <tom@tromey.com>
1169             Pedro Alves  <palves@redhat.com>
1170
1171         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1172         parameter.
1173         (fetch_inferior_event): Use SCOPE_EXIT.
1174
1175
1176 2019-01-23  Tom Tromey  <tom@tromey.com>
1177             Pedro Alves  <palves@redhat.com>
1178
1179         * infrun.c (disable_thread_events): Delete.
1180         (stop_all_threads): Use SCOPE_EXIT.
1181
1182 2019-01-23  Tom Tromey  <tom@tromey.com>
1183             Pedro Alves  <palves@redhat.com>
1184
1185         * symfile.c: Include forward-scope-exit.h.
1186         (clear_symtab_users_cleanup): Replace forward declaration with
1187         a FORWARD_SCOPE_EXIT.
1188         (syms_from_objfile_1): Use the forward_scope_exit and
1189         gdb::optional instead of cleanup_function.
1190         (reread_symbols): Use the forward_scope_exit instead of
1191         cleanup_function.
1192         (clear_symtab_users_cleanup): Remove function.
1193
1194 2019-01-23  Tom Tromey  <tom@tromey.com>
1195             Pedro Alves  <palves@redhat.com>
1196
1197         * linux-nat.c: Include scope-exit.h.
1198         (cleanup_target_stop): Remove.
1199         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1200         SCOPE_EXIT.
1201
1202 2019-01-23  Tom Tromey  <tom@tromey.com>
1203             Pedro Alves  <palves@redhat.com>
1204
1205         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1206         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1207
1208 2019-01-23  Tom Tromey  <tom@tromey.com>
1209             Andrew Burgess  <andrew.burgess@embecosm.com>
1210             Pedro Alves  <palves@redhat.com>
1211
1212         * infrun.c (fetch_inferior_event): Use scope_exit.
1213         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1214         * top.c (execute_command): Use scope_exit.
1215         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1216         * utils.c (do_bpstat_clear_actions_cleanup)
1217         (make_bpstat_clear_actions_cleanup): Remove.
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * infrun.c: Include "common/scope-exit.h"
1223         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1224         (wait_for_inferior): Use SCOPE_EXIT.
1225         (fetch_inferior_event): Use scope_exit.
1226
1227 2019-01-23  Tom Tromey  <tom@tromey.com>
1228             Pedro Alves  <palves@redhat.com>
1229
1230         * breakpoint.c (create_breakpoint): Remove cleanup.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233             Andrew Burgess  <andrew.burgess@embecosm.com>
1234             Pedro Alves  <palves@redhat.com>
1235
1236 2019-01-23  Pedro Alves  <palves@redhat.com>
1237
1238         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1239
1240 2019-01-23  Pedro Alves  <palves@redhat.com>
1241             Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * gdbthread.h: Include "common/forward-scope-exit.h".
1244         (scoped_finish_thread_state): Redefine custom class in terms of
1245         forward_scope_exit.
1246
1247 2019-01-23  Pedro Alves  <palves@redhat.com>
1248             Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * common/forward-scope-exit.h: New file.
1251
1252 2019-01-23  Pedro Alves  <palves@redhat.com>
1253             Andrew Burgess  <andrew.burgess@embecosm.com>
1254             Tom Tromey  <tom@tromey.com>
1255
1256         * common/scope-exit.h: New file.
1257
1258 2019-01-23  Pedro Alves  <palves@redhat.com>
1259
1260         * common/preprocessor.h (ESC): Rename to ...
1261         (ESC_PARENS): ... this.
1262         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1263         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1264
1265 2019-01-23  Tom Tromey  <tom@tromey.com>
1266
1267         * language.h (class scoped_switch_to_sym_language_if_auto):
1268         Initialize m_lang in both cases.
1269
1270 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1271
1272         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1273         with XCNEW.
1274
1275 2019-01-22  Tom Tromey  <tom@tromey.com>
1276
1277         * corelow.c: Do not include sys/file.h.
1278
1279 2019-01-22  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-wingeneral.h: Include gdb_curses.h.
1282
1283 2019-01-22  Tom Tromey  <tom@tromey.com>
1284
1285         * source-cache.h (class source_cache) <get_source_lines,
1286         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1287
1288 2019-01-22  Tom Tromey  <tom@tromey.com>
1289
1290         * remote-fileio.h (struct remote_target): Declare.
1291
1292 2019-01-22  Tom Tromey  <tom@tromey.com>
1293
1294         * python/py-arch.c: Do not include py-ref.h.
1295         * python/py-bpevent.c: Do not include py-ref.h.
1296         * python/py-cmd.c: Do not include py-ref.h.
1297         * python/py-continueevent.c: Do not include py-ref.h.
1298         * python/py-event.h: Do not include py-ref.h.
1299         * python/py-evtregistry.c: Do not include py-ref.h.
1300         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1301         * python/py-frame.c: Do not include py-ref.h.
1302         * python/py-framefilter.c: Do not include py-ref.h.
1303         * python/py-function.c: Do not include py-ref.h.
1304         * python/py-infevents.c: Do not include py-ref.h.
1305         * python/py-linetable.c: Do not include py-ref.h.
1306         * python/py-objfile.c: Do not include py-ref.h.
1307         * python/py-param.c: Do not include py-ref.h.
1308         * python/py-prettyprint.c: Do not include py-ref.h.
1309         * python/py-progspace.c: Do not include py-ref.h.
1310         * python/py-symbol.c: Do not include py-ref.h.
1311         * python/py-symtab.c: Do not include py-ref.h.
1312         * python/py-type.c: Do not include py-ref.h.
1313         * python/py-unwind.c: Do not include py-ref.h.
1314         * python/py-utils.c: Do not include py-ref.h.
1315         * python/py-value.c: Do not include py-ref.h.
1316         * python/py-varobj.c: Do not include py-ref.h.
1317         * python/py-xmethods.c: Do not include py-ref.h.
1318         * python/python.c: Do not include py-ref.h.
1319         * varobj.c: Do not include py-ref.h.
1320
1321 2019-01-22  Tom Tromey  <tom@tromey.com>
1322
1323         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1324         keyword for bcache.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * compile/compile-cplus-types.c: Remove a comment by #include.
1329
1330 2019-01-22  Tom Tromey  <tom@tromey.com>
1331
1332         * compile/gcc-c-plugin.h: Include compile-internal.h.
1333
1334 2019-01-22  Tom Tromey  <tom@tromey.com>
1335
1336         * stabsread.c (EXTERN): Do not define.
1337         (symnum, next_symbol_text_func, processing_gcc_compilation)
1338         (within_function, global_sym_chain, global_stabs)
1339         (previous_stab_code, this_object_header_files)
1340         (n_this_object_header_files)
1341         (n_allocated_this_object_header_files): Define.
1342         * stabsread.h (EXTERN): Never define.  Use "extern".
1343
1344 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1345
1346         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1347         history_value.
1348
1349 2019-01-21  Tom Tromey  <tom@tromey.com>
1350
1351         * ui-out.c: Fix includes.
1352         * tui/tui-source.c: Fix includes.
1353         * target.c: Fix includes.
1354         * remote.c: Fix includes.
1355         * regcache.c: Fix includes.
1356         * python/py-block.c: Fix includes.
1357         * printcmd.c: Fix includes.
1358         * or1k-tdep.c: Fix includes.
1359         * mi/mi-main.c: Fix includes.
1360         * m32r-tdep.c: Fix includes.
1361         * csky-tdep.c: Fix includes.
1362         * compile/compile-cplus-types.c: Fix includes.
1363         * cli/cli-interp.c: Fix includes.
1364
1365 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1366
1367         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1368         for padding.
1369
1370 2019-01-16  Tom Tromey  <tom@tromey.com>
1371
1372         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1373         earlier.
1374         (struct objfile) <msymbols_range>: Move from top level.
1375         <msymbols>: New method.
1376         (class objfile_msymbols): Remove.
1377         * symtab.c (default_collect_symbol_completion_matches_break_on):
1378         Update.
1379         * symmisc.c (dump_msymbols): Update.
1380         * stabsread.c (scan_file_globals): Update.
1381         * objc-lang.c (info_selectors_command, info_classes_command)
1382         (find_methods): Update.
1383         * minsyms.c (find_solib_trampoline_target): Update.
1384         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1385         * coffread.c (coff_symfile_read): Update.
1386         * ada-lang.c (ada_lookup_simple_minsym)
1387         (ada_collect_symbol_completion_matches): Update.
1388
1389 2019-01-16  Tom Tromey  <tom@tromey.com>
1390
1391         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1392         type.  Remove no-argument constructor.
1393         <iterator::operator++>: Simplify.
1394         <begin>: Update.
1395         <end>: Use minimal_symbol_count.
1396
1397 2019-01-16  Tom Tromey  <tom@tromey.com>
1398
1399         * objfiles.h (struct objfile) <psymtabs>: New method.
1400         (class objfile_psymtabs): Remove.
1401         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1402         typedef.
1403         <range>: New method.
1404         (require_partial_symbols): Change return type.
1405         * psymtab.c (require_partial_symbols)
1406         (psym_expand_symtabs_matching): Update.
1407         * mdebugread.c (parse_partial_symbols): Update.
1408         * dbxread.c (dbx_end_psymtab): Update.
1409
1410 2019-01-15  Tom Tromey  <tom@tromey.com>
1411
1412         * symtab.c (lookup_objfile_from_block)
1413         (lookup_symbol_in_objfile_symtabs)
1414         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1415         (find_line_symtab, info_sources_command)
1416         (default_collect_symbol_completion_matches_break_on)
1417         (make_source_files_completion_list): Update.
1418         * symmisc.c (print_objfile_statistics, dump_objfile)
1419         (maintenance_print_symbols, maintenance_info_symtabs)
1420         (maintenance_check_symtabs, maintenance_info_line_tables):
1421         Update.
1422         * source.c (select_source_symtab)
1423         (forget_cached_source_info_for_objfile): Update.
1424         * objfiles.h (class objfile_compunits): Remove.
1425         (struct objfile) <compunits_range>: New typedef.
1426         (compunits): New method.
1427         * objfiles.c (objfile_relocate1): Update.
1428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1429         * maint.c (count_symtabs_and_blocks): Update.
1430         * linespec.c (iterate_over_all_matching_symtabs): Update.
1431         * cp-support.c (add_symbol_overload_list_qualified): Update.
1432         * coffread.c (coff_symtab_read): Update.
1433         * ada-lang.c (add_nonlocal_symbols)
1434         (ada_collect_symbol_completion_matches)
1435         (ada_add_global_exceptions): Update.
1436
1437 2019-01-15  Tom Tromey  <tom@tromey.com>
1438
1439         * progspace.h (program_space) <objfiles_safe_range>: New
1440         typedef.
1441         <objfiles_safe>: New method.
1442         * objfiles.h (class all_objfiles_safe): Remove.
1443         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1444         * jit.c (jit_inferior_exit_hook): Update.
1445
1446 2019-01-17  Tom Tromey  <tom@tromey.com>
1447
1448         * progspace.h (program_space) <objfiles_range>: New typedef.
1449         <objfiles>: New method.
1450         <objfiles_head>: Rename from objfiles.
1451         (object_files): Update.
1452         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1453         * guile/scm-pretty-print.c
1454         (ppscm_find_pretty_printer_from_objfiles): Update.
1455         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1456         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1457         Update.
1458         * python/py-progspace.c (pspy_get_objfiles): Update.
1459         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1460         Update.
1461         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1462         (objfpy_lookup_objfile_by_build_id): Update.
1463         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1464         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1465         Update.
1466         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1467         (expand_symtab_containing_pc, lookup_objfile_from_block)
1468         (lookup_static_symbol, basic_lookup_transparent_type)
1469         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1470         (find_line_symtab, info_sources_command)
1471         (default_collect_symbol_completion_matches_break_on)
1472         (make_source_files_completion_list, find_main_name): Update.
1473         * symmisc.c (print_symbol_bcache_statistics)
1474         (print_objfile_statistics, maintenance_print_symbols)
1475         (maintenance_print_msymbols, maintenance_print_objfiles)
1476         (maintenance_info_symtabs, maintenance_check_symtabs)
1477         (maintenance_expand_symtabs, maintenance_info_line_tables):
1478         Update.
1479         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1480         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1481         (map_overlay_command, unmap_overlay_command)
1482         (simple_overlay_update, expand_symtabs_matching)
1483         (map_symbol_filenames): Update.
1484         * symfile-debug.c (set_debug_symfile): Update.
1485         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1486         Update.
1487         * source.c (select_source_symtab, forget_cached_source_info):
1488         Update.
1489         * solib.c (solib_read_symbols): Update.
1490         * solib-spu.c (append_ocl_sos): Update.
1491         * psymtab.c (maintenance_print_psymbols)
1492         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1493         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1494         * printcmd.c (info_symbol_command): Update.
1495         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1496         Update.
1497         * objfiles.h (class all_objfiles): Remove.
1498         * objfiles.c (have_partial_symbols, have_full_symbols)
1499         (have_minimal_symbols, qsort_cmp, update_section_map)
1500         (shared_objfile_contains_address_p)
1501         (default_iterate_over_objfiles_in_search_order): Update.
1502         * objc-lang.c (info_selectors_command, info_classes_command)
1503         (find_methods): Update.
1504         * minsyms.c (find_solib_trampoline_target): Update.
1505         * maint.c (maintenance_info_sections)
1506         (maintenance_translate_address, count_symtabs_and_blocks):
1507         Update.
1508         * main.c (captured_main_1): Update.
1509         * linux-thread-db.c (try_thread_db_load_from_pdir)
1510         (has_libpthread): Update.
1511         * linespec.c (iterate_over_all_matching_symtabs)
1512         (search_minsyms_for_name): Update.
1513         * jit.c (jit_find_objf_with_entry_addr): Update.
1514         * hppa-tdep.c (find_unwind_entry)
1515         (hppa_lookup_stub_minimal_symbol): Update.
1516         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1517         Update.
1518         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1519         (elf_gnu_ifunc_resolve_by_got): Update.
1520         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1521         * dwarf-index-write.c (save_gdb_index_command): Update.
1522         * cp-support.c (add_symbol_overload_list_qualified): Update.
1523         * breakpoint.c (create_overlay_event_breakpoint)
1524         (create_longjmp_master_breakpoint)
1525         (create_std_terminate_master_breakpoint)
1526         (create_exception_master_breakpoint): Update.
1527         * blockframe.c (find_pc_partial_function): Update.
1528         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1529         (ada_collect_symbol_completion_matches)
1530         (ada_add_global_exceptions): Update.
1531
1532 2019-01-17  Tom Tromey  <tom@tromey.com>
1533
1534         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1535         declare VEC.
1536         (solib_target_parse_libraries): Change return type.
1537         (library_list_start_segment, library_list_start_section)
1538         (library_list_end_library, library_list_start_library); Update.
1539         (solib_target_free_library_list): Remove.
1540         (solib_target_parse_libraries): Remove cleanup.  Change return
1541         type.
1542         (solib_target_current_sos): Update.
1543
1544 2019-01-17  Tom Tromey  <tromey@bapiya>
1545
1546         * valprint.c: Replace "the the" with "the".
1547         * symtab.c: Replace "the the" with "the".
1548         * solib.c: Replace "the the" with "the".
1549         * solib-dsbt.c: Replace "the the" with "the".
1550         * linespec.c: Replace "the the" with "the".
1551         * dwarf2loc.h: Replace "the the" with "the".
1552         * amd64-windows-tdep.c: Replace "the the" with "the".
1553         * aarch64-tdep.c: Replace "the the" with "the".
1554
1555 2019-01-16  Keith Seitz  <keiths@redhat.com>
1556
1557         PR gdb/23773
1558         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1559         <builder>: Rename to ..
1560         <m_builder>: ... this and make private.
1561         (dwarf2_cu::get_builder): New method.  Change all users of
1562         `builder' to use this method.
1563         (dwarf2_start_symtab): Move to ...
1564         (dwarf2_cu::start_symtab): ... here.  Update all callers
1565         (setup_type_unit_groups): Move to ...
1566         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1567         callers.
1568         (dwarf2_cu::reset_builder): New method.
1569         (process_full_compunit, process_full_type_unit): Use
1570         dwarf2_cu::reset_builder.
1571         (follow_die_offset): Record the ancestor CU if it is different
1572         from the followed DIE's CU.
1573         (follow_die_sig_1): Likewise.
1574
1575 2019-01-15  Tom Tromey  <tom@tromey.com>
1576
1577         * remote.c (class remote_state) <buf>: Now a char_vector.
1578         <buf_size>: Remove.
1579         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1580         parameter.
1581         (remote_target::getpkt_or_notif_sane_1)
1582         (remote_target::getpkt_sane)
1583         (remote_target::getpkt_or_notif_sane): Likewise.
1584         (class remote_target) <putpkt>: New overload.
1585         (remote_target::read_frame): Change type of "buf_p".  Remove
1586         sizeof_p parameter.
1587         (packet_ok): New overload.
1588         (packet_check_result): New overload.
1589         Update all uses.
1590
1591 2019-01-14  Tom Tromey  <tom@tromey.com>
1592
1593         * remote-notif.c (handle_notification, remote_notif_ack)
1594         (remote_notif_parse): Make "buf" const.
1595         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1596         const.
1597         (remote_notif_parse, remote_notif_ack, handle_notification):
1598         Likewise.
1599         * remote.c (remote_notif_stop_parse): Make "buf" const.
1600         (remote_target::remote_parse_stop_reply): Make "buf" const.
1601         (remote_notif_stop_ack): Make "buf" const.
1602
1603 2019-01-14  Tom Tromey  <tom@tromey.com>
1604
1605         * remote.c (remote_console_output): Make parameter const.
1606
1607 2019-01-14  Tom Tromey  <tom@tromey.com>
1608
1609         * target-debug.h (target_debug_print_signals): Constify.
1610         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1611         * procfs.c (procfs_target::pass_signals): Update.
1612         * linux-nat.c (linux_nat_target::pass_signals): Update.
1613         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1614         * target-delegates.c: Rebuild.
1615         * remote.c (remote_target::program_signals): Update.
1616         (remote_target::pass_signals): Update.
1617         * target.c (target_pass_signals): Constify argument.
1618         (target_program_signals): Likewise.
1619         * target.h (struct target_ops) <pass_signals, program_signals>:
1620         Constify argument.
1621         (target_pass_signals, target_program_signals): Constify argument.
1622
1623 2019-01-14  Tom Tromey  <tom@tromey.com>
1624
1625         PR tui/28819:
1626         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1627
1628 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1629
1630         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1631         field.
1632         * rs6000-tdep.c: Include reggroups.h.
1633         (IS_V_ALIAS_PSEUDOREG): Define.
1634         (rs6000_register_name): Return names for the "vX" aliases.
1635         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1636         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1637         aliases.  Call default_register_reggroup_p for all other
1638         pseudo-registers.
1639         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1640         New functions.
1641         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1642         Handle "vX" aliases.
1643         (v_alias_pseudo_register_collect): New function.
1644         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1645         (rs6000_gdbarch_init): Initialize "vX" aliases as
1646         pseudo-registers.  Restore registration of
1647         rs6000_pseudo_register_reggroup_p with
1648         set_tdesc_pseudo_register_reggroup_p.
1649
1650 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1651
1652         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1653         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1654         set_gdbarch_num_pseudo_regs.
1655
1656 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1657
1658         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1659         Remove arg prefixname, add do_set and do_show.
1660         Add member functions set_list and show_list.
1661         * cli/cli-style.c (class cli_style_option): Update accordingly.
1662         (style_set_list): Move to file scope.
1663         (style_show_list): Likewise.
1664         (set_style): Call help_list.
1665         (show_style): Call cmd_show_list.
1666         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1667         Update to use the new macro.
1668
1669 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1670
1671         * ada-lang.c (_initialize_ada_language): Expand the help text
1672         for the "catch exception" command.
1673
1674 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1675
1676         * symtab.c (matching_obj_sections): Initialize obj,
1677         declare it closer to its usage.
1678
1679 2019-01-10  Tom Tromey  <tom@tromey.com>
1680
1681         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1682         (basic_inf_threads_range): Remove.
1683         (inf_threads_range, inf_non_exited_threads_range)
1684         (safe_inf_threads_range): Use next_adapter.
1685
1686 2019-01-10  Keith Seitz  <keiths@redhat.com>
1687
1688         PR gdb/23712
1689         PR symtab/23010
1690         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1691         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1692
1693 2019-01-10  Keith Seitz  <keiths@redhat.com>
1694
1695         PR gdb/23712
1696         PR symtab/23010
1697         * dictionary.c (pending_to_vector): Remove.
1698         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1699         Remove _1 suffix, replacing functions of the same name.  Update
1700         all callers.
1701         (dict_create_hashed, dict_create_hashed_expandable)
1702         (dict_create_linear, dict_create_linear_expandable, dict_free)
1703         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1704         Make functions static.
1705
1706 2019-01-10  Keith Seitz  <keiths@redhat.com>
1707
1708         PR gdb/23712
1709         PR symtab/23010
1710         * dictionary.h (struct dictionary): Replace declaration with
1711         multidictionary.
1712         (dict_create_hashed, dict_create_hashed_expandable)
1713         (dict_create_linear, dict_create_linear_expandable)
1714         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1715         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1716         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1717         taking multidictionary argument.
1718         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1719         * block.h (struct block) <dict>: Change to multidictionary
1720         and rename `multidict'.
1721         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1722         symmisc.c: Update all dictionary references to multidictionary.
1723
1724 2019-01-10  Keith Seitz  <keiths@redhat.com>
1725
1726         PR gdb/23712
1727         PR symtab/23010
1728         * dictionary.c: Include unordered_map.
1729         (pending_to_vector): New function.
1730         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1731         Rewrite the non-"_1" functions to take vector instead
1732         of linked list.
1733         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1734         "new" _1 versions of the same name.
1735         (multidictionary): Define.
1736         (std::hash<enum language): New definition.
1737         (collate_pending_symbols_by_language, mdict_create_hashed)
1738         (mdict_create_hashed_expandable, mdict_create_linear)
1739         (mdict_create_linear_expandable, mdict_free)
1740         (find_language_dictionary, create_new_language_dictionary)
1741         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1742         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1743         (mdict_size, mdict_empty): New functions.
1744         * dictionary.h (mdict_iterator): Define.
1745
1746 2019-01-10  Pedro Alves  <palves@redhat.com>
1747
1748         * breakpoint.c (read_uploaded_action)
1749         (create_tracepoint_from_upload): Adjust to use
1750         gdb::unique_xmalloc_ptr.
1751         * ctf.c (ctf_write_uploaded_tp):
1752         (SET_ARRAY_FIELD): Use emplace_back.
1753         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1754         * tracefile-tfile.c (tfile_write_uploaded_tp):
1755         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1756         gdb::unique_xmalloc_ptr.
1757         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1758         at_string, cond_string, cmd_strings>: Replace char pointers
1759         with gdb::unique_xmalloc_ptr.
1760
1761 2019-01-10  Pedro Alves  <palves@redhat.com>
1762
1763         * solib-target.c (library_list_start_library): Don't xstrdup name.
1764
1765 2019-01-10  Pedro Alves  <palves@redhat.com>
1766
1767         * mdebugread.c (parse_partial_symbols): Use
1768         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1769
1770 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1771
1772         * linux-fork.c (scoped_switch_fork_info)
1773         <~scoped_switch_fork_info>: Fix incorrect variable name.
1774
1775 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * linux-fork.c (scoped_switch_fork_info)
1778         <scoped_switch_fork_info>: Make explicit.
1779         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1780
1781 2019-01-10  Tom Tromey  <tom@tromey.com>
1782
1783         * objfiles.h (objfile::reset_psymtabs): Update.
1784         * objfiles.c (objfile::objfile): Update.
1785         * psymtab.h (psymtab_storage::obstack): Update.
1786         (psymtab_storage::m_obstack): Use gdb::optional.
1787         (class psymtab_storage): Update comment.  Remove objfile
1788         parameter.
1789         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1790
1791 2019-01-10  Tom Tromey  <tom@tromey.com>
1792
1793         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1794         <free_psymtabs>: Now private.
1795         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1796         (allocate_psymtab): Use new method.
1797
1798 2019-01-10  Tom Tromey  <tom@tromey.com>
1799
1800         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1801         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1802         * mdebugread.c (parse_partial_symbols): Use
1803         allocate_dependencies.
1804         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1805         allocate_dependencies.
1806         (process_psymtab_comp_unit_reader)
1807         (build_type_psymtab_dependencies): Likewise.
1808         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1809
1810 2019-01-10  Tom Tromey  <tom@tromey.com>
1811
1812         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1813         PSYMBOL_SET_LANGUAGE.
1814         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1815
1816 2019-01-10  Tom Tromey  <tom@tromey.com>
1817
1818         * psymtab.h (psymtab_storage::obstack): New method.
1819         <m_obstack>: Rename from obstack; now private.
1820         * psymtab.c (psymtab_storage): Update.
1821         * dwarf2read.c (create_addrmap_from_index)
1822         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1823         Update.
1824
1825 2019-01-10  Tom Tromey  <tom@tromey.com>
1826
1827         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1828         * objfiles.h (objfile::reset_psymtabs): New method.
1829
1830 2019-01-10  Tom Tromey  <tom@tromey.com>
1831
1832         * symmisc.c (print_symbol_bcache_statistics): Update.
1833         (print_objfile_statistics): Update.
1834         * symfile.c (reread_symbols): Update.
1835         * psymtab.h (class psymtab_storage): New.
1836         * psymtab.c (psymtab_storage): New constructor.
1837         (~psymtab_storage): New destructor.
1838         (require_partial_symbols): Update.
1839         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1840         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1841         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1842         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1843         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1844         (start_psymtab_common, end_psymtab_common)
1845         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1846         (allocate_psymtab): Update.
1847         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1848         Update.
1849         (dump_psymtab_addrmap, maintenance_print_psymbols)
1850         (maintenance_check_psymtabs): Update.
1851         (class objfile_psymtabs): Move to objfiles.h.
1852         * psympriv.h (discard_psymtab): Now inline.
1853         (psymtab_discarder::psymtab_discarder): Update.
1854         (psymtab_discarder::~psymtab_discarder): Update.
1855         (ALL_OBJFILE_PSYMTABS): Rewrite.
1856         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1857         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1858         Remove fields.
1859         <partial_symtabs>: New field.
1860         (class objfile_psymtabs): Move from psymtab.h.  Update.
1861         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1862         psymbol_cache.
1863         (objfile::~objfile): Don't destroy psymbol_cache.
1864         * mdebugread.c (parse_partial_symbols): Update.
1865         * dwarf2read.c (create_addrmap_from_index)
1866         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1867         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1868         (add_partial_subprogram, dwarf2_ranges_read): Update.
1869         * dwarf-index-write.c (write_address_map)
1870         (write_one_signatured_type, recursively_write_psymbols)
1871         (class debug_names, class debug_names, write_psymtabs_to_index):
1872         Update.
1873
1874 2019-01-10  Tom Tromey  <tom@tromey.com>
1875
1876         * symtab.h (SYMBOL_SET_NAMES): Update.
1877         (symbol_set_names): Update.
1878         (MSYMBOL_SET_NAMES): Update.
1879         * symtab.c (symbol_set_names): Change argument to be an
1880         objfile_per_bfd_storage.
1881         * psymtab.c (add_psymbol_to_bcache): Update.
1882         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1883
1884 2019-01-10  Tom Tromey  <tom@tromey.com>
1885
1886         * symtab.c (create_demangled_names_hash): Change argument to be an
1887         objfile_per_bfd_storage.
1888         (symbol_set_names): Update.
1889
1890 2019-01-10  Tom Tromey  <tom@tromey.com>
1891
1892         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1893         init_psymbol_list.
1894         * psymtab.c (init_psymbol_list): Do nothing if already called.
1895         * psympriv.h (init_psymbol_list): Add comment.
1896         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1897         init_psymbol_list.
1898         * dbxread.c (dbx_symfile_read): Unconditionally call
1899         init_psymbol_list.
1900
1901 2019-01-10  Tom Tromey  <tom@tromey.com>
1902
1903         * xcoffread.c (scan_xcoff_symtab): Update.
1904         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1905         "where".
1906         * mdebugread.c (parse_partial_symbols)
1907         (handle_psymbol_enumerators): Update.
1908         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1909         * dbxread.c (read_dbx_symtab): Update.
1910         * psympriv.h (psymbol_placement): New enum.
1911         (add_psymbol_to_list): Update.
1912
1913 2019-01-10  Tom Tromey  <tom@tromey.com>
1914
1915         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1916         static_psymbols parameters.
1917         (scan_xcoff_symtab): Update.
1918         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1919         static_psymbols parameters.
1920         * psympriv.h (start_psymtab_common): Update.
1921         * mdebugread.c (parse_partial_symbols): Update.
1922         * dwarf2read.c (create_partial_symtab): Update.
1923         * dbxread.c (read_dbx_symtab): Update.
1924         (start_psymtab): Remove global_psymbols and static_psymbols
1925         parameters.
1926
1927 2019-01-10  Tom Tromey  <tom@tromey.com>
1928
1929         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1930         * psymtab.c (allocate_psymtab): Add comment.
1931         * psympriv.h (allocate_psymtab): Add comment.
1932         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1933         initializations.
1934         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1935
1936 2019-01-10  Tom Tromey  <tom@tromey.com>
1937
1938         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1939         Don't declare.
1940         * mipsread.c: Include mdebugread.h.
1941         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1942         Declare.
1943         * elfread.c: Include mdebugread.h.
1944
1945 2019-01-09  Tom Tromey  <tom@tromey.com>
1946
1947         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1948         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1949         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1950         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1951         (psym_lookup_symbol, psym_find_last_source_symtab)
1952         (psym_forget_cached_source_info, psym_print_stats)
1953         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1954         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1955         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1956         (psym_find_compunit_symtab_by_address)
1957         (maintenance_print_psymbols, maintenance_info_psymtabs)
1958         (maintenance_check_psymtabs): Use ranged for.
1959         * psymtab.h (class objfile_psymtabs): New.
1960         (require_partial_symbols): Return objfile_psymtabs.
1961         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1962
1963 2019-01-09  Tom Tromey  <tom@tromey.com>
1964
1965         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1966         (find_pc_mapped_section, list_overlays_command)
1967         (map_overlay_command, unmap_overlay_command)
1968         (simple_overlay_update): Use all_objfiles.
1969         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1970         * printcmd.c (info_symbol_command): Use all_objfiles.
1971         * objfiles.h (ALL_OBJSECTIONS): Remove.
1972         * maint.c (maintenance_translate_address): Use all_objfiles.
1973         * gcore.c (gcore_create_callback): Use all_objfiles.
1974         (objfile_find_memory_regions): Likewise.
1975
1976 2019-01-09  Tom Tromey  <tom@tromey.com>
1977
1978         * symtab.c (find_line_symtab, info_sources_command)
1979         (make_source_files_completion_list): Use objfile_compunits.
1980         * source.c (select_source_symtab): Use objfile_compunits.
1981         * objfiles.h (struct objfile): Update comment.
1982         (ALL_OBJFILES): Remove.
1983         (ALL_FILETABS): Remove.
1984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1985         objfile_compunits.
1986
1987 2019-01-09  Tom Tromey  <tom@tromey.com>
1988
1989         * symmisc.c (print_objfile_statistics, dump_objfile)
1990         (maintenance_print_symbols): Use compunit_filetabs.
1991         * source.c (forget_cached_source_info_for_objfile): Use
1992         compunit_filetabs.
1993         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1994         (ALL_FILETABS): Use compunit_filetabs.
1995         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1996         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1997
1998 2019-01-09  Tom Tromey  <tom@tromey.com>
1999
2000         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2001         (compunit_filetabs): New.
2002         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2003         compunit_filetabs.
2004         (info_sources_command, make_source_files_completion_list): Remove
2005         declaration.
2006         * symmisc.c (print_objfile_statistics, dump_objfile)
2007         (maintenance_print_symbols): Remove declaration.
2008         (maintenance_info_symtabs): Use compunit_filetabs.
2009         (maintenance_info_line_tables): Likewise.
2010         * source.c (select_source_symtab): Change local variable name.
2011         (forget_cached_source_info_for_objfile): Remove declaration.
2012         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2013         * objfiles.c (objfile_relocate1): Remove declaration.
2014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2015         declaration.
2016         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2017         * coffread.c (coff_symtab_read): Remove declaration.
2018         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2019         compunit_filetabs.
2020
2021 2019-01-09  Tom Tromey  <tom@tromey.com>
2022
2023         * symtab.c (lookup_objfile_from_block)
2024         (find_pc_sect_compunit_symtab, search_symbols)
2025         (default_collect_symbol_completion_matches_break_on): Use
2026         objfile_compunits.
2027         * objfiles.h (ALL_COMPUNITS): Remove.
2028         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2029         * cp-support.c (add_symbol_overload_list_qualified): Use
2030         objfile_compunits.
2031         * ada-lang.c (ada_collect_symbol_completion_matches)
2032         (ada_add_global_exceptions): Use objfile_compunits.
2033
2034 2019-01-09  Tom Tromey  <tom@tromey.com>
2035
2036         * source.c (select_source_symtab)
2037         (forget_cached_source_info_for_objfile): Remove declaration.
2038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2039         declaration.
2040         * maint.c (count_symtabs_and_blocks): Remove declaration.
2041         * cp-support.c (add_symbol_overload_list_qualified): Remove
2042         declaration.
2043         * coffread.c (coff_symtab_read): Remove declaration.
2044         * symtab.c (lookup_symbol_in_objfile_symtabs)
2045         (basic_lookup_transparent_type_1): Use objfile_compunits.
2046         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2047         (info_sources_command, search_symbols)
2048         (default_collect_symbol_completion_matches_break_on)
2049         (make_source_files_completion_list): Remove declaration.
2050         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2051         (ada_collect_symbol_completion_matches)
2052         (ada_add_global_exceptions): Remove declaration.
2053         * linespec.c (iterate_over_all_matching_symtabs): Use
2054         objfile_compunits.
2055         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2056         (class objfile_compunits): New.
2057         (ALL_COMPUNITS): Use objfile_compunits.
2058         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2059         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2060         objfile_compunits.
2061         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2062
2063 2019-01-09  Tom Tromey  <tom@tromey.com>
2064
2065         * symtab.c (search_symbols)
2066         (default_collect_symbol_completion_matches_break_on): Use
2067         objfile_msymbols.
2068         * ada-lang.c (ada_lookup_simple_minsym)
2069         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2070         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2071         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2072         objfile_msymbols.
2073         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2074         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2075         * objc-lang.c (find_methods): Use objfile_msymbols.
2076         (info_selectors_command, info_classes_command): Likewise.
2077         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2078         * objfiles.h (class objfile_msymbols): New.
2079         (ALL_OBJFILE_MSYMBOLS): Remove.
2080         (ALL_MSYMBOLS): Remove.
2081
2082 2019-01-09  Tom Tromey  <tom@tromey.com>
2083
2084         * common/next-iterator.h (next_adapter): Add Iterator template
2085         parameter.
2086         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2087         (class all_objfiles_safe): New.
2088         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2089         * objfiles.c (put_objfile_before): Update comment.
2090         (add_separate_debug_objfile): Likewise.
2091         (free_all_objfiles): Use all_objfiles_safe.
2092         (objfile_purge_solibs): Likewise.
2093
2094 2019-01-09  Tom Tromey  <tom@tromey.com>
2095
2096         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2097         (expand_symtab_containing_pc, lookup_static_symbol)
2098         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2099         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2100         all_objfiles.
2101         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2102         * breakpoint.c (create_overlay_event_breakpoint)
2103         (create_longjmp_master_breakpoint)
2104         (create_std_terminate_master_breakpoint)
2105         (create_exception_master_breakpoint): Use all_objfiles.
2106         * linux-thread-db.c (try_thread_db_load_from_pdir)
2107         (has_libpthread): Use all_objfiles.
2108         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2109         * linespec.c (iterate_over_all_matching_symtabs)
2110         (search_minsyms_for_name): Use all_objfiles.
2111         * maint.c (maintenance_info_sections): Use all_objfiles.
2112         * main.c (captured_main_1): Use all_objfiles.
2113         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2114         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2115         * guile/scm-pretty-print.c
2116         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2117         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2118         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2119         (maintenance_print_msymbols): Use all_objfiles.
2120         * source.c (select_source_symtab): Use all_objfiles.
2121         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2122         * symfile.c (remove_symbol_file_command)
2123         (expand_symtabs_matching, map_symbol_filenames): Use
2124         all_objfiles.
2125         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2126         all_objfiles.
2127         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2128         * objc-lang.c (find_methods): Use all_objfiles.
2129         * objfiles.c (have_partial_symbols, have_full_symbols)
2130         (have_minimal_symbols, qsort_cmp)
2131         (default_iterate_over_objfiles_in_search_order): Use
2132         all_objfiles.
2133         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2134         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2135         (maintenance_check_psymtabs): Use all_objfiles.
2136         (ALL_PSYMTABS): Remove.
2137         * compile/compile-object-run.c (do_module_cleanup): Use
2138         all_objfiles.
2139         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2140         * cp-support.c (add_symbol_overload_list_qualified): Use
2141         all_objfiles.
2142         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2143         Use all_objfiles.
2144         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2145         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2146         all_objfiles.
2147         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2148         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2149         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2150         Uses all_objfiles.
2151         * solib.c (solib_read_symbols): Use all_objfiles
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2157         all_objfiles.
2158         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2159         * symmisc.c (print_symbol_bcache_statistics)
2160         (print_objfile_statistics, maintenance_print_objfiles)
2161         (maintenance_info_symtabs, maintenance_check_symtabs)
2162         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2163         all_objfiles.
2164         * source.c (forget_cached_source_info): Use all_objfiles.
2165         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2166         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2167         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2168         * objfiles.c (update_section_map): Use all_objfiles.
2169         (shared_objfile_contains_address_p): Likewise.
2170         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2171         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2172
2173 2019-01-09  Tom Tromey  <tom@tromey.com>
2174
2175         * common/next-iterator.h: New file.
2176         * objfiles.h (class all_objfiles): New.
2177         (struct objfile_iterator): New.
2178
2179 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2180
2181         * NEWS: Move the description of the changed "frame", "select-frame",
2182          and "info frame" commands to the Changed commands section.
2183
2184 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2185
2186         * gdbtypes.c (check_stub_method_group): Remove handling of old
2187         mangling schemes.
2188         * linespec.c (find_methods): Likewise.
2189         * stabsread.c (read_member_functions): Likewise.
2190         * valops.c (search_struct_method): Likewise.
2191         (value_struct_elt_for_reference): Likewise.
2192         * NEWS: Mention this change.
2193
2194 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2197         print_source_lines.
2198         * source.c (print_source_lines_base): Update line number check.
2199         (print_source_lines): New function.
2200         (source_lines_range::source_lines_range): New function.
2201         * source.h (class source_lines_range): New class.
2202         (print_source_lines): New declaration.
2203
2204 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2205
2206         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2207
2208 2019-01-08  Tom Tromey  <tom@tromey.com>
2209             Simon Marchi  <simon.marchi@ericsson.com>
2210
2211         PR gdb/24060
2212         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2213         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2214         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2215         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2216         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2217         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2218
2219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * source.c (select_source_symtab): Move header comment to
2222         declaration in source.h.
2223         (forget_cached_source_info_for_objfile): Likewise.
2224         (forget_cached_source_info): Likewise.
2225         (identify_source_line): Likewise.
2226         * source.h (identify_source_line): Move declaration from symtab.h
2227         and add comment from source.c
2228         (print_source_lines): Likewise.
2229         (forget_cached_source_info_for_objfile): Likewise.
2230         (forget_cached_source_info): Likewise.
2231         (select_source_symtab): Likewise.
2232         (enum print_source_lines_flag): Move definition from symtab.h.
2233         * symtab.h (identify_source_line): Move declaration to source.h.
2234         (print_source_lines): Likewise.
2235         (forget_cached_source_info_for_objfile): Likewise.
2236         (forget_cached_source_info): Likewise.
2237         (select_source_symtab): Likewise.
2238         (enum print_source_lines_flag): Move definition to source.h.
2239         * tui/tui-hooks.c: Add 'source.h' include.
2240
2241 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * source.c (print_source_lines_base): Handle requests to print
2244         reverse line number sequences, and guard against empty lines
2245         string.
2246
2247 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * source.c (print_source_lines_base): Fix skip of '\r' if next
2250         character is '\n'.
2251
2252 2019-01-06  Tom Tromey  <tom@tromey.com>
2253
2254         * c-exp.y (struct c_parse_state) <macro_original_text,
2255         expansion_obstack>: New member.
2256         (macro_original_text, expansion_obstack): Remove globals.
2257         (scan_macro_expansion, scanning_macro_expansion)
2258         (finished_macro_expansion): Update.
2259         (scan_macro_cleanup): Remove.
2260         (yylex, c_parse): Update.
2261
2262 2019-01-06  Tom Tromey  <tom@tromey.com>
2263
2264         * c-exp.y (struct c_parse_state) <strings>: New member.
2265         (operator_stoken): Update.
2266
2267 2019-01-06  Tom Tromey  <tom@tromey.com>
2268
2269         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2270         (union type_stack_elt) <typelist_val>: Now a pointer to
2271         std::vector.
2272         (type_stack_cleanup): Don't declare.
2273         (push_typelist): Update.
2274         * parse.c (pop_typelist): Return a std::vector.
2275         (push_typelist): Take a std::vector.
2276         (follow_types): Update.  Do not free args.
2277         (type_stack_cleanup): Remove.
2278         * c-exp.y (struct c_parse_state): New.
2279         (cpstate): New global.
2280         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2281         (nonempty_typelist): Update.
2282         (func_mod): Create a new vector.
2283         (c_parse): Create a c_parse_state.
2284         (check_parameter_typelist): Do not delete params.
2285         (function_method): Update.  Do not delete type_list.
2286
2287 2019-01-06  Tom Tromey  <tom@tromey.com>
2288
2289         PR gdb/28155:
2290         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2291         check_typedef.
2292         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2293         (print_return_value): Likewise.
2294
2295 2019-01-05  Tom Tromey  <tom@tromey.com>
2296
2297         * contrib/cleanup_check.py: Remove.
2298         * contrib/gcc-with-excheck: Remove.
2299         * contrib/exsummary.py: Remove.
2300         * contrib/excheck.py: Remove.
2301
2302 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2303
2304         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2305         NULL. Initialize tpprev to NULL instead of assigning it
2306         to NULL on the next statement.
2307         * windows-nat.c (windows_delete_thread): Remove check for
2308         main_thread_id before printing thread exit notifications.
2309         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2310         Remove thread ID check against main_thread_id.
2311         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2312         windows_delete_thread.
2313         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2314
2315 2019-01-04  Tom Tromey  <tom@tromey.com>
2316
2317         * compile/compile.c (_initialize_compile): Use upper case for
2318         metasyntactic variables.
2319         * symmisc.c (_initialize_symmisc): Use upper case for
2320         metasyntactic variables.
2321         * psymtab.c (_initialize_psymtab): Use upper case for
2322         metasyntactic variables.
2323         * demangle.c (demangle_command): Use upper case for metasyntactic
2324         variables.
2325         (_initialize_demangler): Likewise.
2326         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2327         variables.
2328
2329 2019-01-03  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2332
2333 2019-01-03  Tom Tromey  <tom@tromey.com>
2334
2335         * python/py-symtab.c (salpy_str): Update.
2336         (struct salpy_sal_object) <symtab>: Now a PyObject.
2337         (salpy_dealloc): Update.
2338         (del_objfile_sal): Use gdbpy_ref.
2339
2340 2019-01-03  Tom Tromey  <tom@tromey.com>
2341
2342         * python/py-type.c (convert_field): Use new_reference.  Return
2343         gdbpy_ref.
2344         (make_fielditem): Return gdbpy_ref.
2345         (typy_fields): Update.
2346         (typy_getitem): Update.
2347         (field_name): Return gdbpy_ref.  Use new_reference.
2348         (typy_iterator_iternext): Update.
2349
2350 2019-01-03  Tom Tromey  <tom@tromey.com>
2351
2352         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2353
2354 2019-01-03  Tom Tromey  <tom@tromey.com>
2355
2356         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2357         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2358         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2359         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2360         (pspy_set_type_printers): Likewise.
2361         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2362         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2363         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2364         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2365         (objfpy_set_type_printers): Likewise.
2366
2367 2019-01-03  Tom Tromey  <tom@tromey.com>
2368
2369         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2370         (gdbpy_print_stack): Use gdbpy_err_fetch.
2371         * python/python-internal.h (class gdbpy_err_fetch): New class.
2372         (class gdbpy_enter) <m_error_type, m_error_value,
2373         m_error_traceback>: Remove.
2374         <m_error>: New member.
2375         (gdbpy_exception_to_string): Don't declare.
2376         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2377         * python/py-value.c (convert_value_from_python): Use
2378         gdbpy_err_fetch.
2379         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2380         gdbpy_exception_to_string.
2381         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2382         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2383         gdbpy_err_fetch.
2384
2385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * linux-nat.c (delete_lwp_cleanup): Delete.
2388         (struct lwp_deleter): New struct.
2389         (lwp_info_up): New typedef.
2390         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2391         lwp_info_up.
2392
2393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2394
2395         * linux-fork.c (class scoped_switch_fork_info): New class.
2396         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2397
2398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * valops.c (find_overload_match): Remove use of null_cleanup, and
2401         calls to do_cleanups.
2402
2403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * compile/compile-cplus-types.c
2406         (compile_cplus_instance::decl_name): Handle changes to
2407         cp_func_name.
2408         * cp-support.c (cp_func_name): Update header comment, update
2409         return type.
2410         * cp-support.h (cp_func_name): Update return type in declaration.
2411         * valops.c (find_overload_match): Move temp_func local to top
2412         level of function and change its type.  Use temp_func to hold and
2413         delete temporary string obtained from cp_func_name.
2414
2415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2418         gdb::char_vector, remove cleanup, and update uses of `msg`.
2419
2420 2019-01-03  Jim Wilson  <jimw@sifive.com>
2421
2422         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2423
2424 2019-01-02  Tom Tromey  <tom@tromey.com>
2425
2426         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2427         (tdesc_parse_xml): Remove cleanups.
2428         * target-descriptions.h (make_cleanup_free_target_description):
2429         Don't declare.
2430         (target_desc_deleter): New struct.
2431         (target_desc_up): New typedef.
2432         * target-descriptions.c (target_desc_deleter::operator()): Rename
2433         from free_target_description.
2434         (make_cleanup_free_target_description): Remove.
2435
2436 2019-01-02  Tom Tromey  <tom@tromey.com>
2437
2438         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2439         constructor, destructor.
2440         (linespec_parser): Remove typedef.
2441         (~linespec_parser): Rename from linespec_parser_delete.
2442         (linespec_lex_to_end, linespec_complete_label)
2443         (linespec_complete): Update.
2444         (decode_line_full): Remove cleanups.
2445         (decode_line_1): Update.
2446
2447 2019-01-02  Tom Tromey  <tom@tromey.com>
2448
2449         * python/python-internal.h (inferior_to_inferior_object): Change
2450         return type.
2451         * python/py-exitedevent.c (create_exited_event_object): Update.
2452         * python/py-inferior.c (inferior_to_inferior_object): Return
2453         gdbpy_ref.
2454         (python_new_inferior, python_inferior_deleted)
2455         (thread_to_thread_object, delete_thread_object)
2456         (build_inferior_list, gdbpy_selected_inferior): Update.
2457         * python/py-infthread.c (create_thread_object): Update.  Also fail
2458         if inferior_to_inferior_object fails.
2459
2460 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2461
2462         * inferior.h (class inferior) <displaced_step_state>: New field.
2463         * infrun.h (struct displaced_step_state): Move here from
2464         infrun.c.  Initialize fields, add constructor.
2465         <inf>: Remove field.
2466         <reset>: New method.
2467         * infrun.c (struct displaced_step_inferior_state): Move to
2468         infrun.h.
2469         (displaced_step_inferior_states): Remove.
2470         (get_displaced_stepping_state): Adust.
2471         (displaced_step_in_progress_any_inferior): Adjust.
2472         (displaced_step_in_progress_thread): Adjust.
2473         (displaced_step_in_progress): Adjust.
2474         (add_displaced_stepping_state): Remove.
2475         (get_displaced_step_closure_by_addr): Adjust.
2476         (remove_displaced_stepping_state): Remove.
2477         (infrun_inferior_exit): Call displaced_step_state.reset.
2478         (use_displaced_stepping): Don't check for NULL.
2479         (displaced_step_prepare_throw): Call
2480         get_displaced_stepping_state.
2481         (displaced_step_fixup): Don't check for NULL.
2482         (prepare_for_detach): Don't check for NULL.
2483
2484 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2485
2486         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2487          in case of call that did not complete.
2488
2489 2019-01-02  Andrey Utkin  <autkin@undo.io>
2490
2491         * symfile.c (find_separate_debug_file): Fix search of debug files for
2492         remote debuggee.
2493
2494 2019-01-02  Tom Tromey  <tom@tromey.com>
2495
2496         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2497         indentation.
2498         * python/py-frame.c (frapy_older): Remove cast.
2499         (frapy_newer): Likewise.
2500         * python/py-breakpoint.c (local_setattro): Remove cast.
2501         * python/py-arch.c (archpy_name): Remove local variable.
2502         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2503
2504 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2505
2506         * unittests/basic_string_view/element_access/char/empty.cc:
2507         Fix year range in copyright header.
2508
2509 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2512         Delete.
2513         <operator==>: Update with for removed field.
2514         <hash>: Likewise.
2515         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2516         <isa_features>: ...this.
2517         <abi_features>: New field.
2518         (riscv_isa_flen): Update comment.
2519         (riscv_abi_xlen): New declaration.
2520         (riscv_abi_flen): New declaration.
2521         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2522         isa_features.
2523         (riscv_abi_xlen): New function.
2524         (riscv_isa_flen): Update to get answer from isa_features.
2525         (riscv_abi_flen): New function.
2526         (riscv_has_fp_abi): Update to get answer from abi_features.
2527         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2528         xlen and flen.
2529         (riscv_call_info) <xlen, flen>: Update comment.
2530         (riscv_call_arg_struct): Remove invalid assertions
2531         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2532         is removed.
2533         (riscv_gdbarch_init): Gather isa features and abi features
2534         separately, ensure both match on the gdbarch when reusing an old
2535         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2536         a target with 64-bit float hardware.
2537
2538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2539
2540         * source.c (search_command_helper): Stop reverse search
2541         when line 1 has been searched.
2542
2543 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2544
2545         * record-full.c (record_full_base_target::close): Rewrite
2546         record_full_core_buf_list free logic.
2547
2548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2549
2550         * break-catch-syscall.c (print_one_catch_syscall): xfree
2551         the last text.
2552
2553 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2554
2555         * top.c (print_gdb_version): Update Copyright year in version
2556         message.
2557
2558 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2559
2560         Update copyright year range in all GDB files.
2561
2562 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2563
2564         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2565
2566 For older changes see ChangeLog-2018.
2567 \f
2568 Local Variables:
2569 mode: change-log
2570 left-margin: 8
2571 fill-column: 74
2572 version-control: never
2573 coding: utf-8
2574 End:
2575