gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * compile/compile.c (make_compile_options_def_group): Add braces
   4         around array_view initializer.
   5         * thread.c (make_thread_apply_all_options_def_group)
   6         (make_thread_apply_all_options_def_group): Likewise.
   7
   8 2019-06-13  Pedro Alves  <palves@redhat.com>
   9
  10         * NEWS (New commands): Mention "maint test-options
  11         require-delimiter", "maint test-options unknown-is-error", "maint
  12         test-options unknown-is-operand" and "maint show
  13         test-options-completion-result".
  14         (New command options, command completion): New section.
  15         (Completion improvements): New section.
  16         Mention that you can abbreviate "unlimited".
  17
  18 2019-06-13  Pedro Alves  <palves@redhat.com>
  19
  20         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  21         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  22         * unittests/cli-utils-selftests.c (test_parse_flags)
  23         (test_parse_flags_qcs): Delete.
  24         (test_cli_utils): Don't call deleted functions.
  25
  26 2019-06-13  Pedro Alves  <palves@redhat.com>
  27
  28         * thread.c: Include "cli/cli-option.h".
  29         (tp_array_compar_ascending): Global.
  30         (tp_array_compar): Delete function.
  31         (tp_array_compar_ascending, tp_array_compar_descending): New
  32         functions.
  33         (ascending_option_def, qcs_flag_option_def)
  34         (thr_qcs_flags_option_defs)
  35         (make_thread_apply_all_options_def_group)
  36         (make_thread_apply_options_def_group): New.
  37         (thread_apply_all_command): Use gdb::option::process_options.
  38         (thread_apply_command_completer)
  39         (thread_apply_all_command_completer): New.
  40         (thread_apply_command): Use gdb::option::process_options.
  41         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
  42         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
  43         to generate help text of "thread apply".  Adjust "taas"'s help.
  44         * tid-parse.c (tid_range_parser::in_thread_range): New method.
  45         * tid-parse.h (tid_range_parser::in_thread_range): New method.
  46
  47 2019-06-13  Pedro Alves  <palves@redhat.com>
  48
  49         * thread.c (thread_apply_command): Check for invalid TID with
  50         isdigit instead of !isalpha.
  51
  52 2019-06-13  Pedro Alves  <palves@redhat.com>
  53
  54         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
  55         (validate_flags_qcs): New.
  56         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
  57         (validate_flags_qcs): Declare.
  58         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
  59         (make_frame_apply_options_def_group): New.
  60         (frame_apply_command_count): Process options with
  61         gdb::option::process_options.
  62         (frame_apply_completer): New.
  63         (frame_apply_level_completer, frame_apply_all_completer)
  64         (frame_apply_completer): New.
  65         (_initialize_stack): Update help of "frame apply", "frame apply
  66         level", "frame apply all" and "faas" to mention supported options
  67         and install command completers.
  68         * stack.h (frame_apply_all_completer): Declare.
  69         * thread.c: Include "stack.h".
  70         (tfaas_command): Add "--".
  71         (_initialize_thread): Update help "tfaas" to mention supported
  72         options and install command completer.
  73
  74 2019-06-13  Pedro Alves  <palves@redhat.com>
  75
  76         * completer.c (complete_nested_command_line): New.
  77         (gdb_completion_word_break_characters_throw): Add assertion.
  78         * completer.h (complete_nested_command_line): Declare.
  79
  80 2019-06-13  Pedro Alves  <palves@redhat.com>
  81
  82         * stack.c (parse_backtrace_qualifiers): New.
  83         (backtrace_command): Use it.
  84         (backtrace_command_completer): Complete on qualifiers.
  85
  86 2019-06-13  Pedro Alves  <palves@redhat.com>
  87
  88         * frame.c: Include "cli/cli-option.h.
  89         (user_set_backtrace_options): New.
  90         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  91         Delete.
  92         (get_prev_frame): Adjust.
  93         (boolean_option_def, uinteger_option_def)
  94         (set_backtrace_option_defs): New.
  95         (_initialize_frame): Adjust and use
  96         gdb::option::add_setshow_cmds_for_options to install "set
  97         backtrace past-main" and "set backtrace past-entry".
  98         * frame.h: Include "cli/cli-option.h".
  99         (struct frame_print_options): Forward declare.
 100         (print_frame_arguments_all, print_frame_arguments_scalars)
 101         (print_frame_arguments_none): Declare.
 102         (print_entry_values): Delete declaration.
 103         (struct frame_print_options, user_frame_print_options): New.
 104         (struct set_backtrace_options): New.
 105         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 106         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 107         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 108         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 109         (list_args_or_locals): Add frame_print_options parameter.
 110         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 111         * python/py-framefilter.c (enumerate_args): Pass down
 112         USER_FRAME_PRINT_OPTIONS.
 113         * stack.c: Include "cli/cli-option.h".
 114         (print_frame_arguments_all, print_frame_arguments_scalars)
 115         (print_frame_arguments_none): Declare.
 116         (print_raw_frame_arguments, print_entry_values): Delete.
 117         (user_frame_print_options): New.
 118         (boolean_option_def, enum_option_def, frame_print_option_defs):
 119         New.
 120         (struct backtrace_cmd_options): New.
 121         (bt_flag_option_def): New.
 122         (backtrace_command_option_defs): New.
 123         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 124         (print_frame_arg, read_frame_arg, print_frame_args)
 125         (print_frame_info, print_frame): Add frame_print_options parameter
 126         and use it.
 127         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 128         (backtrace_command_1): Add frame_print_options and
 129         backtrace_cmd_options parameters and use them.
 130         (make_backtrace_options_def_group): New.
 131         (backtrace_command): Process command options with
 132         gdb::option::process_options.
 133         (backtrace_command_completer): New.
 134         (_initialize_stack): Extend "backtrace"'s help to mention
 135         supported options.  Install completer for "backtrace".
 136         Install some settings commands with add_setshow_cmds_for_options.
 137
 138 2019-06-13  Pedro Alves  <palves@redhat.com>
 139
 140         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 141         and that "set/show print raw frame-arguments" are now deprecated.
 142
 143         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 144         command.
 145         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 146         * stack.c (_initialize_stack): Install "set/show print
 147         raw-frame-arguments", and deprecate "set/show print raw
 148         frame-arguments".
 149         * valprint.c (_initialize_valprint): Deprecate "set/show print
 150         raw".
 151
 152 2019-06-13  Pedro Alves  <palves@redhat.com>
 153
 154         * compile/compile.c (struct compile_options): New.
 155         (compile_flag_option_def, compile_command_option_defs)
 156         (make_compile_options_def_group): New.
 157         (compile_file_command): Handle options with
 158         gdb::option::process_options.
 159         (compile_file_command_completer): New function.
 160         (compile_code_command): Handle options with
 161         gdb::option::process_options.
 162         (compile_code_command_completer): New function.
 163         (_initialize_compiler): Install completers for "compile code" and
 164         "compile file".  Mention available options in "compile code" and
 165         "compile code"'s help.
 166         * completer.c (advance_to_completion_word): New, factored out from
 167         ...
 168         (advance_to_expression_complete_word_point): ... this.
 169         (advance_to_filename_complete_word_point): New.
 170         * completer.h (advance_to_filename_complete_word_point): New
 171         declaration.
 172
 173 2019-06-13  Pedro Alves  <palves@redhat.com>
 174
 175         * compile/compile.c: Include "cli/cli-option.h".
 176         (compile_print_value): Scope data pointer is now a
 177         value_print_options pointer; adjust.
 178         (compile_print_command): Process options.  Scope data pointer is
 179         now a value_print_options pointer; adjust.
 180         (_initialize_compile): Update "compile print"'s help to include
 181         supported options.  Install a completer for "compile print".
 182         * cp-valprint.c (show_vtblprint, show_objectprint)
 183         (show_static_field_print): Delete.
 184         (_initialize_cp_valprint): Don't install "set print
 185         static-members", "set print vtbl", "set print object" here.
 186         * printcmd.c: Include "cli/cli-option.h" and
 187         "common/gdb_optional.h".
 188         (print_command_parse_format): Rework to fill in a
 189         value_print_options instead of a format_data.
 190         (print_value): Change parameter type from format_data pointer to
 191         value_print_options reference.  Adjust.
 192         (print_command_1): Process options.  Adjust to pass down a
 193         value_print_options.
 194         (print_command_completer): New.
 195         (_initialize_printcmd): Install print_command_completer as
 196         handle_brkchars completer for the "print" command.  Update
 197         "print"'s help to include supported options.
 198         * valprint.c: Include "cli/cli-option.h".
 199         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 200         here from cp-valprint.c.
 201         (boolean_option_def, uinteger_option_def)
 202         (value_print_option_defs, make_value_print_options_def_group):
 203         New.  Use gdb::option::add_setshow_cmds_for_options to install
 204         "set print elements", "set print null-stop", "set print repeats",
 205         "set print pretty", "set print union", "set print array", "set
 206         print address", "set print symbol", "set print array-indexes".
 207         * valprint.h: Include <string> and "cli/cli-option.h".
 208         (make_value_print_options_def_group): Declare.
 209         (print_value): Change parameter type from format_data pointer to
 210         value_print_options reference.
 211         (print_command_completer): Declare.
 212
 213 2019-06-13  Pedro Alves  <palves@redhat.com>
 214
 215         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 216         (COMMON_SFILES): Add maint-test-settings.c.
 217         * cli/cli-decode.c (boolean_enums): New global, factored out from
 218         ...
 219         (add_setshow_boolean_cmd): ... here.
 220         * cli/cli-decode.h (boolean_enums): Declare.
 221         * cli/cli-option.c: New file.
 222         * cli/cli-option.h: New file.
 223         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 224         factored out from ...
 225         (parse_cli_boolean_value(const char *)): ... this.
 226         (is_unlimited_literal): Change parameter type to pointer to
 227         pointer.  Adjust and advance ARG pointer.
 228         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 229         (parse_cli_var_enum): New, factored out from ...
 230         (do_set_command): ... this.  Adjust.
 231         * cli/cli-setshow.h (parse_cli_boolean_value)
 232         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 233         (parse_cli_var_enum): Declare.
 234         * cli/cli-utils.c: Include "cli/cli-option.h".
 235         (get_ulongest): New.
 236         * cli/cli-utils.h (get_ulongest): Declare.
 237         (check_for_argument): New overloads.
 238         * maint-test-options.c: New file.
 239
 240 2019-06-13  Pedro Alves  <palves@redhat.com>
 241
 242         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 243         parse a range if "-" is at the end of the string.
 244
 245 2019-06-13  Pedro Alves  <palves@redhat.com>
 246
 247         * cli/cli-setshow.c (parse_auto_binary_operation)
 248         (parse_cli_boolean_value): Don't allow "o".
 249
 250 2019-06-13  Pedro Alves  <palves@redhat.com>
 251
 252         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 253         * NEWS: Mention maint test-settings KIND.
 254         * maint-test-settings.c: New file.
 255
 256 2019-06-13  Pedro Alves  <palves@redhat.com>
 257
 258         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 259         completer.
 260         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 261         "set" completers.
 262
 263 2019-06-13  Pedro Alves  <palves@redhat.com>
 264
 265         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 266         after item.
 267
 268 2019-06-13  Pedro Alves  <palves@redhat.com>
 269
 270         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 271
 272 2019-06-13  Pedro Alves <palves@redhat.com>
 273
 274         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 275         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 276         call.
 277         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 278         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 279         calls.
 280         (check_for_argument): Skip spaces after argument.
 281
 282 2019-06-13  Pedro Alves  <palves@redhat.com>
 283
 284         * thread.c (thread_apply_command): Adjust TID parsing.
 285         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 286         detected before end of string.
 287         (tid_is_in_list): Error out if LIST is invalid.
 288
 289 2019-06-13  Pedro Alves  <palves@redhat.com>
 290
 291         * completer.c (complete_line_internal_1): Rewind completion word
 292         point.
 293         (completion_tracker::advance_custom_word_point_by): Change
 294         parameter type to int.
 295         * completer.h (completion_tracker::advance_custom_word_point_by):
 296         Likewise.
 297
 298 2019-06-13  Pedro Alves  <palves@redhat.com>
 299
 300         * completer.c (advance_to_completion_word): Handle delimiters.
 301
 302 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 303
 304         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 305
 306 2019-06-11  Tom Tromey  <tom@tromey.com>
 307
 308         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 309         (xmalloc_failed): Move to alloc.c.
 310         * alloc.c: New file.
 311         * Makefile.in (COMMON_SFILES): Add alloc.c.
 312
 313 2019-06-11  Tom Tromey  <tom@tromey.com>
 314
 315         * nat/linux-waitpid.c: Don't include server.h.
 316         (linux_debug): Remove.
 317         (my_waitpid): Update.
 318
 319 2019-06-11  Tom Tromey  <tromey@adacore.com>
 320
 321         * infcall.c (_initialize_infcall): Remove trailing newline from
 322         help.
 323         * user-regs.c (_initialize_user_regs): Remove trailing newline
 324         from help.
 325         * typeprint.c (_initialize_typeprint): Remove trailing newline
 326         from help.
 327         * reverse.c (_initialize_reverse): Remove trailing newlines from
 328         help.
 329         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 330         from help.
 331         * language.c (add_set_language_command): Remove trailing newline
 332         from help.
 333         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 334         help.
 335         * disasm.c (_initialize_disasm): Remove trailing newline from
 336         help.
 337         * top.c (init_main): Remove trailing newline from help.
 338         * interps.c (_initialize_interpreter): Remove trailing newline
 339         from help.
 340         * btrace.c (_initialize_btrace): Remove trailing newlines from
 341         help.
 342         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 343         from help.
 344         * python/python.c (_initialize_python): Remove trailing newline
 345         from help.
 346         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 347         help.
 348         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 349         from help.  Reformat some text.
 350         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 351         from help.
 352         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 353         newline from help.
 354
 355 2019-06-11  Tom Tromey  <tromey@adacore.com>
 356
 357         * darwin-nat.c (darwin_decode_exception_message)
 358         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 359
 360 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * valops.c (value_slice): Check for not allocated or not
 363         associated values.
 364
 365 2019-06-10  Tom de Vries  <tdevries@suse.de>
 366
 367         PR gdb/24618
 368         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 369         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 370         invalid.
 371
 372 2019-06-10  Tom de Vries  <tdevries@suse.de>
 373
 374         PR gdb/24611
 375         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 376         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 377
 378 2019-06-10  Tom de Vries  <tdevries@suse.de>
 379
 380         PR symtab/24545
 381         * symtab.c (struct demangled_name_entry): Add language field.
 382         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 383         static minimal symbol".  Set and use language field.
 384
 385 2019-06-10  Tom Tromey  <tromey@adacore.com>
 386
 387         * ada-lang.c (_initialize_ada_language): Update help text.
 388
 389 2019-06-10  Tom Tromey  <tromey@adacore.com>
 390
 391         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 392         with a newline.
 393         * guile/guile.c (handle_boot_error): Don't end warning with a
 394         newline.
 395         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 396         warning with a newline.
 397         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 398         newline.
 399         (s12z_frame_cache): Likewise.
 400         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 401         a newline.
 402         * solib-svr4.c (disable_probes_interface): Don't end warning with
 403         a newline.
 404         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 405         newline.
 406         * python/python.c (do_finish_initialization): Don't end warning
 407         with a newline.
 408
 409 2019-06-10  Tom Tromey  <tom@tromey.com>
 410
 411         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 412         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 413         gdbpy_enter.
 414
 415 2019-06-10  Tom Tromey  <tromey@adacore.com>
 416
 417         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 418         data.
 419         (elf_new_init): Don't call stabsread_new_init.
 420         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 421         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 422         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 423
 424 2019-06-10  Tom de Vries  <tdevries@suse.de>
 425
 426         PR symtab/16264
 427         PR symtab/24517
 428         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 429
 430 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 431
 432         * source.c (find_and_open_source): Also rewrite relative file
 433         names.
 434
 435 2019-04-26  Amos Bird  <amosbird@gmail.com>
 436
 437         * annotate.c (annotate_thread_exited): Add "thread-exited"
 438         annotation.
 439
 440 2019-06-06  Tom Tromey  <tromey@adacore.com>
 441
 442         * maint.h (class scoped_command_stats): Use
 443         DISABLE_COPY_AND_ASSIGN.
 444         <print_time>: New method.
 445         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 446         print_time.
 447         (scoped_command_stats::print_time): New method.
 448
 449 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 450
 451         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 452         instructions of lengths 6 or 8 bytes.
 453
 454 2019-06-04  Pedro Alves  <palves@redhat.com>
 455
 456         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 457
 458         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 459         * breakpoint.c (condition_completer): Likewise.
 460         * cli/cli-dump.c (scan_expression): Likewise.
 461         * common/filestuff.c (mkdir_recursive): Likewise.
 462         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 463         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 464         (gdb_abspath): Likewise.
 465         * compile/compile-cplus-types.c
 466         (compile_cplus_instance::decl_name): Likewise.
 467         * completer.c (complete_explicit_location):
 468         (signal_completer, reg_or_group_completer_1): Likewise.
 469         * cp-support.c (cp_remove_params_if_any): Likewise.
 470         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 471         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 472         * infcmd.c (strip_bg_char): Likewise.
 473         * linespec.c (copy_token_string): Likewise.
 474         * mi/mi-main.c (output_cores): Likewise.
 475         * psymtab.c (psymtab_search_name):
 476         * symfile.c (test_set_ext_lang_command): Likewise.
 477         * target.c (target_fileio_read_stralloc): Likewise.
 478         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 479         * value.c (complete_internalvar): Likewise.
 480
 481 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 482
 483         Add objfile property to gdb.Type.
 484         * NEWS: Mention Python API addition.
 485         * python/py-type.c (typy_get_objfile): New method.
 486
 487 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 488
 489         * NEWS: Mention the new set|show style [title|highlight].
 490         Mention changes to "show style", "help" and "apropos".
 491
 492 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493
 494         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 495         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 496         instead of print_help_for_command.
 497         (print_doc_of_command): New function.
 498         (help_list): Add 'apropos -v word' suggestion.
 499         (print_help_for_command): Style the command name using title style.
 500         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 501         (_initialize_cli_cmds): Describe -v in apropos_command help.
 502
 503 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 504
 505         * cli/cli-style.h (cli_style_option): Add name in constructor,
 506         add m_name class member, add constructor with intensity,
 507         add name class function.
 508         (cli_style_option::add_setshow_commands): Remove name argument.
 509         (highlight_style, title_style): New styles.
 510         * cli/cli-style.c (do_show): New function that shows a style
 511         characteristic styling the style name with itself.
 512         (set_style_name): New function.
 513         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 514         Update all callers according to the changes in cli/cli-style.h.
 515         * utils.h (fputs_highlighted): New function.
 516         * utils.c (fputs_highlighted): Likewise.
 517
 518 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 519
 520         * NEWS: Mention new pipe command and new convenience variables.
 521
 522 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 523
 524         * cli/cli-cmds.c (pipe_command): New function.
 525         (_initialize_cli_cmds): Call add_com for pipe_command.
 526         Define | as an alias for pipe.
 527         (exit_status_set_internal_vars): New function.
 528         (shell_escape): Call exit_status_set_internal_vars.
 529         cli/cli-decode.c (find_command_name_length): Recognize | as
 530         a single character command.
 531
 532 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 533
 534         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 535         top.c (execute_command_to_ui_file): New function, mostly a copy
 536         of execute_command_to_string.
 537         (execute_command_to_string): Implement by calling
 538         execute_command_to_ui_file.
 539
 540 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 541
 542         * top.h (saved_command_line): Remove declaration.
 543         * top.c (previous_saved_command_line, previous_repeat_arguments):
 544         New variables.
 545         (saved_command_line): Make static, define together with other
 546         'repeat variables'.
 547         (dont_repeat): Clear repeat_arguments.
 548         (repeat_previous, get_saved_command_line, save_command_line):
 549         New functions.
 550         (gdb_init): Initialize saved_command_line
 551         and previous_saved_command_line.
 552         * main.c (captured_main_1): Remove saved_command_line initialization.
 553         * event-top.c (handle_line_of_input): Update to use
 554         the new 'repeat' related functions instead of direct access to
 555         saved_command_line.
 556         * command.h (repeat_previous, get_saved_command_line,
 557         save_command_line): New declarations.
 558         (dont_repeat): Add comment.
 559
 560 2019-05-30  Tom Tromey  <tromey@adacore.com>
 561
 562         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 563         Fix comment.
 564         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 565
 566 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 567
 568         PR cli/24587
 569         * completer.c (complete): Initialize variable word.
 570
 571 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 572
 573         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 574         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 575         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 576         'body' is NULL to the outter 'if', protecting the '!is_define'
 577         situation as well.
 578
 579 2019-05-29  Tom Tromey  <tromey@adacore.com>
 580
 581         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 582         (dwarf_unknown): New function.
 583         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 584         (dwarf_type_encoding_name): Use dwarf_unknown.
 585
 586 2019-05-29  Tom Tromey  <tromey@adacore.com>
 587
 588         PR c++/20020:
 589         * cp-valprint.c (cp_print_value_fields): Call
 590         cp_print_static_field inside "try".
 591
 592 2019-05-29  Tom Tromey  <tromey@adacore.com>
 593
 594         * inflow.c (struct terminal_info): Add default operator=.
 595         * configure: Rebuild.
 596         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 597         -Wdeprecated-copy-dtor, -Wredundant-move.
 598
 599 2019-05-29  Tom Tromey  <tromey@adacore.com>
 600
 601         * NEWS: Add entry.
 602         * infcmd.c (print_return_value_1): Handle finish_print
 603         option.
 604         (show_print_finish): New function.
 605         (_initialize_infcmd): Add "set/show print finish" commands.
 606         * valprint.c (user_print_options): Initialize new member.
 607         * valprint.h (struct value_print_options) <finish_print>: New
 608         member.
 609
 610 2019-05-28  Tom Tromey  <tromey@adacore.com>
 611
 612         * ada-lang.c (ada_remove_Xbn_suffix)
 613         (find_old_style_renaming_symbol)
 614         (parse_old_style_renaming): Remove.
 615         (ada_find_renaming_symbol): Don't call
 616         find_old_style_renaming_symbol.
 617         (ada_is_renaming_symbol): Rename from
 618         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 619         bool.  Now static.
 620         (ada_read_var_value): Update and simplify.
 621         * ada-exp.y (write_var_or_type): Remove old code.
 622
 623 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 624
 625         * event-top.c: Remove include comment.
 626         * inflow.c (class scoped_ignore_sigttou): Move from here...
 627         * inflow.h (class scoped_ignore_sigttou): ...to here.
 628         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 629         * top.c:  Remove include comment.
 630
 631 2019-05-27  Tom Tromey  <tom@tromey.com>
 632
 633         * NEWS: Fix typo.
 634
 635 2019-05-22  Tom Tromey  <tromey@adacore.com>
 636
 637         * target.c (target_follow_exec): Constify parameter.
 638         * target-delegates.c: Rebuild.
 639         * remote.c (remote_target::follow_exec): Constify parameter.
 640         * infrun.c (follow_exec): Constify parameter.
 641         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 642         (target_follow_exec): Likewise.
 643
 644 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 645
 646         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 647         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 648
 649 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 650
 651         * NEWS: Add debugredirect and testsuite sections.
 652
 653 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 654
 655         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 656         target descriptions using exclusively floating point register name
 657         aliases.
 658
 659 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         PR gdb/18644:
 662         * f-lang.c (build_fortran_types): Handle the case where
 663         gdbarch_floatformat_for_type returns a nullptr.
 664
 665 2019-05-21  Tom de Vries  <tdevries@suse.de>
 666
 667         PR cli/24587
 668         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 669
 670 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         PR gdb/18644:
 673         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 674         16-byte floats.
 675         * i386-tdep.c (i386_floatformat_for_type): Use
 676         floatformats_ia64_quad for the 16-byte floating point component
 677         within a fortran 32-byte complex number.
 678
 679 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 682         delete default constructor.
 683         (find_partial_die): Update to return const struct.
 684         (partial_die_parent_scope): Move variable declaration into scope
 685         of its use and change its type to auto.
 686         (guess_partial_die_structure_name): Likewise.
 687         (partial_die_info::fixup): Likewise.
 688
 689 2019-05-17  Tom Tromey  <tromey@adacore.com>
 690
 691         * source.c (find_and_open_source): Remove cast.
 692
 693 2019-05-17  Tom Tromey  <tromey@adacore.com>
 694
 695         * annotate.c (annotate_source): Make "filename" const.
 696         * annotate.h (annotate_source): Use const.
 697
 698 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 699
 700         * disasm.c (set_disassembler_options): Send errors to stderr.
 701
 702 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 703
 704         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 705         (cli_interp_base::set_logging): Check debug_redirect.
 706         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 707         * cli/cli-logging.c (debug_redirect): Add static variable.
 708         (pop_output_files): Add default param.
 709         (handle_redirections): Print debug setting.
 710         (show_logging_command): Likewise.
 711         (_initialize_cli_logging): Add debugredirect command.
 712         * interps.c (current_interp_set_logging): Add debug_redirect
 713         parameter.
 714         * interps.h (set_logging): Add debug_redirect parameter.
 715         (current_interp_set_logging): Likewise.
 716         * mi/mi-common.h: Likewise.
 717         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 718
 719 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 720             Tom Tromey  <tromey@adacore.com>
 721
 722         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 723         directly.
 724         * cli/cli-interp.h (make_logging_output): Remove declaration.
 725         * cli/cli-logging.c (make_logging_output): Remove function.
 726         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 727         directly.
 728         * ui-file.c (tee_file::tee_file): Remove bools.
 729         (tee_file::~tee_file): Remove deletes.
 730         * ui-file.h (tee_file): Remove bools.
 731
 732 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 733
 734         * mi/mi-cmds.h (mi_cmd_complete): New function.
 735         * mi/mi-main.c (mi_cmd_complete): Likewise.
 736         * mi/mi-cmds.c: Define new MI command -complete.
 737         * NEWS: Mention new -complete command.
 738
 739 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 740
 741         * completer.h (complete): New function.
 742         * completer.c (complete): Likewise.
 743         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 744         function defined in completer.h.
 745
 746 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 747
 748        * MAINTAINERS (Write After Approval): Add myself.
 749
 750 2019-05-17  Tom de Vries  <tdevries@suse.de>
 751
 752         PR gdb/24094
 753         * dwarf2read.c (struct cu_partial_die_info): New struct.
 754         (find_partial_die): Return cu_partial_die_info.
 755         (partial_die_parent_scope, guess_partial_die_structure_name)
 756         (partial_die_info::fixup): Handle new return type of find_partial_die.
 757
 758 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 759
 760         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 761         "std::string", simplifying the algorithm.
 762
 763 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 764
 765         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 766         (stap_static_probe_ops::get_probes): Likewise.
 767
 768 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 769
 770         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 771         '-')" and "else if".
 772         (stap_parse_single_operand): Join checks for
 773         "gdbarch_stap_parse_special_token_p" and
 774         "gdbarch_stap_parse_special_token" in the same "if" statement.
 775         Invert check when verifying for operation on register
 776         displacement.
 777
 778 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 779
 780         * stap-probe.c (stap_get_opcode): Update comment.
 781         (stap_get_expected_argument_type): Likewise.
 782         (handle_stap_probe): Likewise.
 783
 784 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 785
 786         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 787         return type to 'bool'.  Adjust comment.  Use 'bool' when
 788         appropriate.
 789         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 790         * stap-probe.c (stap_parse_argument_1): Likewise.
 791         (stap_is_operator): Likewise.
 792         (stap_is_generic_prefix): Likewise.
 793         (stap_is_register_prefix): Likewise.
 794         (stap_is_register_indirection_prefix): Likewise.
 795         (stap_is_integer_prefix): Likewise.
 796         (stap_generic_check_suffix): Likewise.
 797         (stap_check_integer_suffix): Likewise.
 798         (stap_check_register_suffix): Likewise.
 799         (stap_check_register_indirection_suffix): Likewise.
 800         (stap_parse_register_operand): Likewise.
 801         (stap_parse_single_operand): Likewise.
 802         (stap_parse_argument_1): Likewise.
 803         (stap_probe::get_argument_count): Likewise.
 804         (stap_is_operator): Likewise.
 805
 806 2019-05-16  Tom Tromey  <tromey@adacore.com>
 807
 808         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 809         keyword to foreach.
 810
 811 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 812
 813         * linux-thread-db.c (try_thread_db_load_1): Change return type
 814         to bool.
 815         (try_thread_db_load): Likewise.
 816         (try_thread_db_load_from_pdir_1): Likewise.
 817         (try_thread_db_load_from_pdir): Likewise.
 818         (try_thread_db_load_from_sdir): Likewise.
 819         (try_thread_db_load_from_dir): Likewise.
 820         (thread_db_load_search): Likewise.
 821         (has_libpthread): Likewise.
 822         (thread_db_load): Likewise.
 823
 824 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 825
 826         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 827         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 828         NULL, and complain/return if that's the case.
 829
 830 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 831
 832         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 833         (advance, posn, abstract_read_memory): New functions.
 834         [struct mem_read_abstraction]: New struct.
 835         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 836
 837 2019-05-14  Tom Tromey  <tromey@adacore.com>
 838
 839         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 840         value is not lval_memory.
 841
 842 2019-05-14  Tom Tromey  <tromey@adacore.com>
 843
 844         * solib.c (info_sharedlibrary_command): Style the file name.
 845
 846 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 847
 848         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 849         (aarch64_vnv_type): Likewise.
 850         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 851         * common/tdesc.c: Likewise.
 852         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 853         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 854         * features/aarch64-fpu.xml: Add ieee half view.
 855         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 856         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 857         * gdbtypes.h (struct builtin_type): Likewise.
 858         (struct objfile_type): Likewise.
 859
 860 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 861
 862         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 863         typo.
 864         * location.h (string_to_event_location): Likewise.
 865
 866 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 867
 868         GDB 8.3 released.
 869
 870 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 871
 872         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 873         New variable declaration.
 874         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 875         New variable.
 876         (print_one_breakpoint): Use ui_out::test_flags and new global
 877         variable to compute use_fixed_output.
 878         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 879         Remove.
 880         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 881         (mi_multi_location_breakpoint_output_fixed): Remove.
 882         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 883         new variable.
 884         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 885         fix_multi_location_breakpoint_output flag if version >= 3.
 886         * ui-out.h (enum ui_out_flag)
 887         <fix_multi_location_breakpoint_output>: New enumerator.
 888
 889 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 890
 891         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 892
 893 2019-05-10  Tom Tromey  <tromey@adacore.com>
 894
 895         * ada-lang.c (catch_ada_completer): New function.
 896         (_initialize_ada_language): Use it.
 897
 898 2019-05-10  Tom Tromey  <tromey@adacore.com>
 899
 900         * thread.c (print_thread_info): Make "requested_threads" const.
 901         * gdbthread.h (print_thread_info): Make "requested_threads"
 902         const.
 903         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 904         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 905
 906 2019-05-08  Tom Tromey  <tom@tromey.com>
 907
 908         * gdbtypes.c (objfile_type_data): Change type.
 909         (objfile_type, _initialize_gdbtypes): Update.
 910
 911 2019-05-08  Tom Tromey  <tom@tromey.com>
 912
 913         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 914         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 915         (_initialize_dwarf2_frame): Update.
 916
 917 2019-05-08  Tom Tromey  <tom@tromey.com>
 918
 919         * objc-lang.c (objc_objfile_data): Change type.
 920         (find_methods): Update.
 921         (_initialize_objc_lang): Remove.
 922
 923 2019-05-08  Tom Tromey  <tom@tromey.com>
 924
 925         * stabsread.c (rs6000_builtin_type_data): Change type.
 926         (rs6000_builtin_type, _initialize_stabsread): Update.
 927
 928 2019-05-08  Tom Tromey  <tom@tromey.com>
 929
 930         * mips-tdep.c (mips_pdr_data): Remove.
 931         (_initialize_mips_tdep): Update.
 932
 933 2019-05-08  Tom Tromey  <tom@tromey.com>
 934
 935         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 936         (hppa_init_objfile_priv_data, read_unwind_info)
 937         (find_unwind_entry, _initialize_hppa_tdep): Update.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 942         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 943         on obstack.
 944         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 945
 946 2019-05-08  Tom Tromey  <tom@tromey.com>
 947
 948         * mdebugread.c (basic_type_data): Change type.
 949         (basic_type, _initialize_mdebugread): Update.
 950
 951 2019-05-08  Tom Tromey  <tom@tromey.com>
 952
 953         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 954
 955 2019-05-08  Tom Tromey  <tom@tromey.com>
 956
 957         * nto-tdep.c (nto_inferior_data_reg): Change type.
 958         (nto_inferior_data): Update.
 959         (nto_inferior_data_cleanup, nto_new_inferior_data)
 960         (_initialize_nto_tdep): Remove.
 961         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 962
 963 2019-05-08  Tom Tromey  <tom@tromey.com>
 964
 965         * ada-lang.c (struct ada_inferior_data): Add initializers.
 966         (ada_inferior_data): Change type.
 967         (ada_inferior_data_cleanup): Remove.
 968         (get_ada_inferior_data, ada_inferior_exit)
 969         (struct ada_pspace_data): Add initializers, destructor.
 970         (ada_pspace_data_handle): Change type.
 971         (get_ada_pspace_data): Update.
 972         (ada_pspace_data_cleanup): Remove.
 973
 974 2019-05-08  Tom Tromey  <tom@tromey.com>
 975
 976         * coffread.c (struct coff_symfile_info): Add initializers.
 977         (coff_objfile_data_key): Move lower.  Change type.
 978         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 979         Update.
 980         (coff_free_info): Remove.
 981
 982 2019-05-08  Tom Tromey  <tom@tromey.com>
 983
 984         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 985         (fbsd_pspace_data_handle): Move lower.  Change type.
 986         (get_fbsd_pspace_data): Update.
 987         (fbsd_pspace_data_cleanup): Remove.
 988         (_initialize_fbsd_tdep): Update.
 989
 990 2019-05-08  Tom Tromey  <tom@tromey.com>
 991
 992         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 993         (get_ada_tasks_pspace_data): Update.
 994         (ada_tasks_pspace_data_cleanup): Remove.
 995         (_initialize_tasks): Update.
 996         (ada_tasks_inferior_data_handle): Change type.
 997         (get_ada_tasks_inferior_data): Update.
 998         (ada_tasks_inferior_data_cleanup): Remove.
 999         (struct ada_tasks_pspace_data): Add initializers.
1000
1001 2019-05-08  Tom Tromey  <tom@tromey.com>
1002
1003         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1004         * symfile-debug.c (debug_sym_get_probes): Change type.
1005         * stap-probe.c (handle_stap_probe):
1006         (stap_static_probe_ops::get_probes): Change type.
1007         * probe.h (class static_probe_ops) <get_probes>: Change type.
1008         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1009         (parse_probes_in_pspace): Update.
1010         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1011         Update.
1012         (any_static_probe_ops::get_probes): Change type.
1013         * elfread.c (elfread_data): New typedef.
1014         (probe_key): Change type.
1015         (elf_get_probes): Likewise.  Update.
1016         (probe_key_free): Remove.
1017         (_initialize_elfread): Update.
1018         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1019         Change type.
1020         (dtrace_process_dof_probe, dtrace_process_dof)
1021         (dtrace_static_probe_ops::get_probe): Change type.
1022
1023 2019-05-08  Tom Tromey  <tom@tromey.com>
1024
1025         * xcoffread.c (struct xcoff_symfile_info): Rename from
1026         coff_symfile_info.  Add initializers.
1027         (xcoff_objfile_data_key): Move lower.  Change type.
1028         (XCOFF_DATA): Rewrite.
1029         (xcoff_free_info): Remove.
1030         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1031         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1032         (xcoff_initial_scan): Update.
1033
1034 2019-05-08  Tom Tromey  <tom@tromey.com>
1035
1036         * solib-svr4.c (struct svr4_info): Add initializers and
1037         destructor.
1038         <probes_table>: Now an htab_up.
1039         (solib_svr4_pspace_data): Change type.
1040         (free_probes_table): Simplify.
1041         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1042         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1043         (probes_table_remove_objfile_probes, register_solib_event_probe)
1044         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1045         (_initialize_svr4_solib): Update.
1046
1047 2019-05-08  Tom Tromey  <tom@tromey.com>
1048
1049         * remote.c (remote_pspace_data): Change type.
1050         (remote_pspace_data_cleanup): Remove.
1051         (get_remote_exec_file, set_pspace_remote_exec_file)
1052         (_initialize_remote): Update.
1053
1054 2019-05-08  Tom Tromey  <tom@tromey.com>
1055
1056         * breakpoint.c (breakpoint_objfile_key): Change type.
1057         (get_breakpoint_objfile_data): Update.
1058         (free_breakpoint_objfile_data): Remove.
1059         (_initialize_breakpoint): Update.
1060
1061 2019-05-08  Tom Tromey  <tom@tromey.com>
1062
1063         * linux-tdep.c (struct linux_info): Add initializers.
1064         (linux_inferior_data): Move.  Change type.
1065         (invalidate_linux_cache_inf): Update.
1066         (linux_inferior_data_cleanup): Remove.
1067         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1068
1069 2019-05-08  Tom Tromey  <tom@tromey.com>
1070
1071         * auxv.c (auxv_inferior_data): Move.  Change type.
1072         (auxv_inferior_data_cleanup): Remove.
1073         (invalidate_auxv_cache_inf): Rewrite.
1074         (get_auxv_inferior_data, _initialize_auxv): Update.
1075
1076 2019-05-08  Tom Tromey  <tom@tromey.com>
1077
1078         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1079         (symfile_debug_objfile_data_key): Change type.
1080         (symfile_debug_installed, debug_qf_has_symbols)
1081         (debug_qf_find_last_source_symtab)
1082         (debug_qf_forget_cached_source_info)
1083         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1084         (debug_qf_print_stats, debug_qf_dump)
1085         (debug_qf_expand_symtabs_for_function)
1086         (debug_qf_expand_all_symtabs)
1087         (debug_qf_expand_symtabs_with_fullname)
1088         (debug_qf_map_matching_symbols)
1089         (debug_qf_expand_symtabs_matching)
1090         (debug_qf_find_pc_sect_compunit_symtab)
1091         (debug_qf_map_symbol_filenames)
1092         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1093         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1094         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1095         (debug_sym_read_linetable, debug_sym_relocate): Update.
1096         (symfile_debug_free_objfile): Remove.
1097         (install_symfile_debug_logging, _initialize_symfile_debug):
1098         Update.
1099
1100 2019-05-08  Tom Tromey  <tom@tromey.com>
1101
1102         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1103         allocate_on_obstack.
1104         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1105         (get_dwarf2_per_objfile): Update.
1106         (set_dwarf2_per_objfile): Remove.
1107         (dwarf2_has_info, dwarf2_get_section_info): Update.
1108         (dwarf2_free_objfile): Remove.
1109         (_initialize_dwarf2_read): Update.
1110
1111 2019-05-08  Tom Tromey  <tom@tromey.com>
1112
1113         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1114         initializers.
1115         <unsupported_script_warning_printed,
1116         script_not_found_warning_printed>: Now bool.
1117         (auto_load_pspace_data): Change type.
1118         (~auto_load_pspace_info): Rename from
1119         auto_load_pspace_data_cleanup.
1120         (get_auto_load_pspace_data, init_loaded_scripts_info)
1121         (clear_section_scripts, maybe_print_unsupported_script_warning)
1122         (maybe_print_script_not_found_warning, _initialize_auto_load):
1123         Update.
1124
1125 2019-05-08  Tom Tromey  <tom@tromey.com>
1126
1127         * objfiles.c (objfile_pspace_info): Add destructor and
1128         initializers.
1129         (objfiles_pspace_data): Change type.
1130         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1131         (get_objfile_pspace_data): Update.
1132         (objfiles_bfd_data): Change type.
1133         (get_objfile_bfd_data): Update.
1134         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1135
1136 2019-05-08  Tom Tromey  <tom@tromey.com>
1137
1138         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1139         Change type.
1140         (get_catch_syscall_inferior_data): Update.
1141         (catch_syscall_inferior_data_cleanup): Remove.
1142         (_initialize_break_catch_syscall): Update.
1143
1144 2019-05-08  Tom Tromey  <tom@tromey.com>
1145
1146         * inflow.c (struct terminal_info): Add destructor and
1147         initializers.
1148         (inflow_inferior_data): Change type.
1149         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1150         (get_inflow_inferior_data, inflow_inferior_exit)
1151         (swap_terminal_info, _initialize_inflow): Update.
1152
1153 2019-05-08  Tom Tromey  <tom@tromey.com>
1154
1155         * target-dcache.c (target_dcache_cleanup): Remove.
1156         (target_dcache_aspace_key): Change type.
1157         (target_dcache_init_p, target_dcache_invalidate)
1158         (target_dcache_get, target_dcache_get_or_init)
1159         (_initialize_target_dcache): Update.
1160         * dcache.h (struct dcache_deleter): New.
1161
1162 2019-05-08  Tom Tromey  <tom@tromey.com>
1163
1164         * symtab.c (struct symbol_cache): Add destructor and
1165         initializers.
1166         (symbol_cache_key): Move.  Change type.
1167         (make_symbol_cache, free_symbol_cache): Remove.
1168         (get_symbol_cache): Update.
1169         (symbol_cache_cleanup): Remove.
1170         (ALL_PSPACES, symbol_cache_flush)
1171         (maintenance_print_symbol_cache)
1172         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1173         Update.
1174
1175 2019-05-08  Tom Tromey  <tom@tromey.com>
1176
1177         * symtab.c (struct main_info): Add destructor and initializers.
1178         (main_progspace_key): Move.  Change type.
1179         (get_main_info): Update.
1180         (main_info_cleanup): Remove.
1181         (_initialize_symtab): Update.
1182
1183 2019-05-08  Tom Tromey  <tom@tromey.com>
1184
1185         * registry.h (DECLARE_REGISTRY): Define the _key class.
1186
1187 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * NEWS: Merge two 'New commands' sections.
1190
1191 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1192
1193         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1194         parameter and use Ada language definition instead.
1195         (ada_val_print_ptr): Remove unused language parameter.
1196         (ada_val_print_num): Remove language parameter and use Ada language
1197         definition instead.
1198         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1199         parameter.
1200         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1201         parameter and use Ada language definition instead.
1202         (ada_val_print_1): Update all ada_val_print_xxx calls.
1203         Remove language parameter.
1204         (ada_val_print): Update ada_val_print_1 call.
1205
1206 2019-05-08  Tom Tromey  <tromey@adacore.com>
1207
1208         * remote.c (remote_hw_watchpoint_limit)
1209         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1210         Now static.
1211
1212 2019-05-08  Tom Tromey  <tromey@adacore.com>
1213
1214         * maint.c (_initialize_maint_cmds): Move initialization code to
1215         remote.c.
1216         (watchdog, show_watchdog): Move to remote.c.
1217         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1218         "watchdog" static.
1219         (_initialize_remote): Move initialization code from maint.c.
1220         * defs.h (watchdog): Don't declare.
1221
1222 2019-05-08  Tom Tromey  <tromey@adacore.com>
1223
1224         * tui/tui-interp.c: Include main.h.
1225         * interps.c: Include main.h.
1226         * main.h (interpreter_p): Declare.
1227         * defs.h (interpreter_p): Don't declare.
1228
1229 2019-05-08  Tom Tromey  <tromey@adacore.com>
1230
1231         * dwarf2loc.c: Include dwarf2read.h.
1232         * defs.h (read_unsigned_leb128): Don't declare.
1233         * dwarf2read.h (read_unsigned_leb128): Declare.
1234
1235 2019-05-08  Tom Tromey  <tromey@adacore.com>
1236
1237         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1238         method.
1239
1240 2019-05-08  Tom Tromey  <tromey@adacore.com>
1241
1242         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1243         when no wrap column is set.
1244
1245 2019-05-08  Tom Tromey  <tromey@adacore.com>
1246
1247         * c-lang.c (c_get_string): Handle non-C-style arrays.
1248
1249 2019-05-08  Tom Tromey  <tromey@adacore.com>
1250
1251         * typeprint.c (print_offset_data::update): Print the bit offset,
1252         not the number of bits remaining.
1253
1254 2019-05-08  Tom Tromey  <tromey@adacore.com>
1255
1256         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1257         padding at end of comment.
1258
1259 2019-05-08  Tom Tromey  <tromey@adacore.com>
1260
1261         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1262         Compare main types.
1263
1264 2019-05-06  Tom Tromey  <tom@tromey.com>
1265
1266         * common/scoped_mmap.c: Include common-defs.h.
1267         * common/scoped_mmap.h: Don't include config.h.
1268
1269 2019-05-04  Tom Tromey  <tom@tromey.com>
1270
1271         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1272         (struct aarch64_call_info): Add initializers.
1273         <si>: Now a std::vector.
1274         (pass_on_stack, aarch64_push_dummy_call): Update.
1275
1276 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1277             Tom Tromey  <tom@tromey.com>
1278
1279         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1280         (ppc_threads): Now a std::vector.  Now static.
1281         (hwdebug_find_thread_points_by_tid)
1282         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1283         Update.
1284
1285 2019-05-04  Tom Tromey  <tom@tromey.com>
1286
1287         * arc-tdep.c (arc_tdesc_init): Return bool.
1288
1289 2019-05-04  Tom Tromey  <tom@tromey.com>
1290
1291         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1292         Use gdb_assert_not_reached.
1293
1294 2019-05-04  Tom Tromey  <tom@tromey.com>
1295
1296         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1297         "false".
1298
1299 2019-05-04  Tom Tromey  <tom@tromey.com>
1300
1301         * arc-tdep.c (arc_tdesc_init): Use bool.
1302
1303 2019-05-04  Tom Tromey  <tom@tromey.com>
1304
1305         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1306
1307 2019-05-04  Tom Tromey  <tom@tromey.com>
1308
1309         * cli/cli-cmds.c (valid_command_p): Return bool.
1310
1311 2019-05-04  Tom Tromey  <tom@tromey.com>
1312
1313         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1314         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1315
1316 2019-05-04  Raul Tambre  <raul@tambre.ee>
1317
1318         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1319         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1320         operator for comparison.
1321
1322 2019-05-04  Tom Tromey  <tom@tromey.com>
1323
1324         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1325         (lookup_partial_symbol, print_partial_symbols)
1326         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1327         (psymbol_compare): Update.
1328         (add_psymbol_to_bcache): Clear the entire psymbol.
1329         (maintenance_check_psymtabs): Update.
1330         * psympriv.h (struct partial_symbol): Don't derive from
1331         general_symbol_info.
1332         <obj_section, unrelocated_address, address,
1333         set_unrelocated_address>: Update.
1334         <ginfo>: New member.
1335         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1336         (debug_names::write_psymbols): Update.
1337
1338 2019-05-04  Tom de Vries  <tdevries@suse.de>
1339
1340         * contrib/cc-with-tweaks.sh: Support -n arg.
1341
1342 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1343
1344         * corelow.c (core_target::detach): Ensure frame cache and
1345         register caches are cleared.
1346         inferior.c (exit_inferior_1): Likewise.
1347
1348 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1349             Tom Tromey  <tom@tromey.com>
1350
1351         * dictionary.c (collate_pending_symbols_by_language): Remove
1352         "struct" from foreach.
1353         * symtab.c (lookup_global_symbol_from_objfile)
1354         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1355         foreach.
1356         * ser-tcp.c (net_open): Remove "struct" from foreach.
1357         * objfiles.c (objfile_relocate, objfile_rebase)
1358         (objfile_has_symbols): Remove "struct" from foreach.
1359         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1360         from foreach.
1361         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1362         foreach.
1363         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1364         "struct" from foreach.
1365         * ada-lang.c (create_excep_cond_exprs)
1366         (ada_exception_catchpoint_cond_string): Remove "struct" from
1367         foreach.
1368
1369 2019-05-03  Tom Tromey  <tromey@adacore.com>
1370
1371         * ada-exp.y (convert_char_literal): Check suffix of each
1372         enumerator.
1373
1374 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1375
1376         PR ada/21406:
1377         * ada-exp.y (yywrap): Don't define.
1378         * ada-lex.l (%option): Add noyywrap
1379         (yywrap): Remove.
1380
1381 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1382
1383         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1384         _WIN32_WINNT to the XP level, unless already defined to a higher
1385         level.
1386
1387         * unittests/parse-connection-spec-selftests.c:
1388         * ser-tcp.c:
1389         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1390         override.
1391
1392         * symfile.c (find_separate_debug_file): Remove colon from the
1393         drive spec of DOS/Windows file names of the target, so that the
1394         file name produced from DEBUGDIR and the target's directory will
1395         be valid on DOS/Windows systems.
1396
1397 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * rust-lang.c (val_print_struct): Handle printing structures
1400         containing strings.
1401
1402 2019-05-02  Tom Tromey  <tromey@adacore.com>
1403
1404         * valarith.c (_initialize_valarith): Remove.
1405
1406 2019-05-01  Tom Tromey  <tromey@adacore.com>
1407
1408         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1409         bitfields.
1410
1411 2019-05-01  Tom Tromey  <tromey@adacore.com>
1412
1413         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1414         for big-endian copies.
1415
1416 2019-04-30  Ali Tamur  <tamur@google.com>
1417         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1418         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1419         (read_3_bytes): New function.
1420
1421 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1422
1423         * windows-nat.c (main_thread_id): Delete.
1424         (handle_output_debug_string): Replace main_thread_id by
1425         current_event.dwThreadId.
1426         (fake_create_process): Likewise.
1427         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1428         Do not set main_thread_id.
1429         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1430         current_event.dwThreadId.
1431         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1432
1433 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1434
1435         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1436         Use current_event.dwThreadId instead of main_thread_id.
1437
1438 2019-04-30  Tom Tromey  <tromey@adacore.com>
1439
1440         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1441         (create_excep_cond_exprs): Iterate over program spaces.
1442         (ada_exception_catchpoint_cond_string): Examine all minimal
1443         symbols for exception types.
1444
1445 2019-04-30  Tom Tromey  <tromey@adacore.com>
1446
1447         PR c++/24470:
1448         * dwarf2read.c (process_structure_scope): Handle case where type
1449         has template parameters but no symbol was created.
1450
1451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1452             Chris January  <chris.january@arm.com>
1453
1454         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1455         qualifier.
1456         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1457
1458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1459
1460         * f-typeprint.c (f_print_type): Update rules for printing
1461         whitespace.
1462         (f_type_print_varspec_suffix): Likewise.
1463
1464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1465             Chris January  <chris.january@arm.com>
1466
1467         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1468         function arguments.
1469
1470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * f-lang.c (build_fortran_types): Change name of void type to
1473         lower case.
1474         * f-typeprint.c (f_type_print_base): Print the name of the void
1475         type, rather than a fixed string.
1476         * f-valprint.c (f_decorations): Use lower case void string.
1477
1478 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1479             Chris January  <chris.january@arm.com>
1480
1481         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1482         types for Fortran.
1483
1484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1485             Chris January  <chris.january@arm.com>
1486             David Lecomber  <david.lecomber@arm.com>
1487
1488         * f-exp.y (BINOP_INTRINSIC): New token.
1489         (exp): New parser rule handling BINOP_INTRINSIC.
1490         (f77_keywords): Add new builtin procedures.
1491         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1492         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1493         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1494         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1495         (print_unop_subexp_f): New function.
1496         (print_binop_subexp_f): New function.
1497         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1498         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1499         (dump_subexp_body_f): Likewise.
1500         (operator_check_f): Likewise.
1501         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1502         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1503
1504 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1507         UNOP_KIND.
1508         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1509         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1510         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1511         (operator_length_f): New fuction.
1512         (print_subexp_f): New function.
1513         (op_name_f): New function.
1514         (dump_subexp_body_f): New function.
1515         (operator_check_f): New function.
1516         (exp_descriptor_f): Replace standard expression handling functions
1517         with new functions.
1518         * gdb/fortran-operator.def: New file.
1519         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1520         * gdb/std-operator.def: Remove UNOP_KIND.
1521
1522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * std-operator.def: Remove unbalanced, stray double quote
1525         character.
1526
1527 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1528             Chris January  <chris.january@arm.com>
1529             Daniel Everett  <daniel.everett@arm.com>
1530             Nick Forrington  <nick.forrington@arm.com>
1531             Richard Bunt  <richard.bunt@arm.com>
1532
1533         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1534         of depth when printing anonymous structs or unions.
1535         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1536         Don't print either the top-level value, or the children if the
1537         max-depth is exceeded.
1538         (ppscm_print_children): When printing the key of a map, allow one
1539         extra level of depth.
1540         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1541         print either the top-level value, or the children if the max-depth
1542         is exceeded.
1543         (print_children): When printing the key of a map, allow one extra
1544         level of depth.
1545         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1546         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1547         (user_print_options): Initialise max_depth field.
1548         (val_print_scalar_or_string_type_p): New function.
1549         (val_print): Check to see if the max depth has been reached.
1550         (val_print_check_max_depth): Define new function.
1551         (show_print_max_depth): New function.
1552         (_initialize_valprint): Add 'print max-depth' option.
1553         * valprint.h (struct value_print_options) <max_depth>: New field.
1554         (val_print_check_max_depth): Declare new function.
1555         * NEWS: Document new feature.
1556
1557 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * ada-lang.c (ada_language_defn): Initialise new field.
1560         * c-lang.c (c_is_string_type_p): New function.
1561         (c_language_defn): Initialise new field.
1562         (cplus_language_defn): Initialise new field.
1563         (asm_language_defn): Initialise new field.
1564         (minimal_language_defn): Initialise new field.
1565         * c-lang.h (c_is_string_type_p): Declare new function.
1566         * d-lang.c (d_language_defn): Initialise new field.
1567         * f-lang.c (f_is_string_type_p): New function.
1568         (f_language_defn): Initialise new field.
1569         * go-lang.c (go_is_string_type_p): New function.
1570         (go_language_defn): Initialise new field.
1571         * language.c (default_is_string_type_p): New function.
1572         (unknown_language_defn): Initialise new field.
1573         (auto_language_defn): Initialise new field.
1574         * language.h (struct language_defn) <la_is_string_type_p>: New
1575         member variable.
1576         (default_is_string_type_p): Declare new function.
1577         * m2-lang.c (m2_language_defn): Initialise new field.
1578         * objc-lang.c (objc_language_defn): Initialise new field.
1579         * opencl-lang.c (opencl_language_defn): Initialise new field.
1580         * p-lang.c (pascal_is_string_type_p): New function.
1581         (pascal_language_defn): Initialise new field.
1582         * rust-lang.c (rust_is_string_type_p): New function.
1583         (rust_language_defn): Initialise new field.
1584
1585 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1588         New field.
1589         * ada-lang.c (ada_language_defn): Initialise new field.
1590         * c-lang.c (c_language_defn): Likewise.
1591         (cplus_language_defn): Likewise.
1592         (asm_language_defn): Likewise.
1593         (minimal_language_defn): Likewise.
1594         * d-lang.c (d_language_defn): Likewise.
1595         * f-lang.c (f_language_defn): Likewise.
1596         * go-lang.c (go_language_defn): Likewise.
1597         * language.c (unknown_language_defn): Likewise.
1598         (auto_language_defn): Likewise.
1599         * m2-lang.c (m2_language_defn): Likewise.
1600         * objc-lang.c (objc_language_defn): Likewise.
1601         * opencl-lang.c (opencl_language_defn): Likewise.
1602         * p-lang.c (pascal_language_defn): Likewise.
1603         * rust-lang.c (rust_language_defn): Likewise.
1604
1605 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * ada-lang.c (ada_is_character_type): Change return type to bool.
1608         (ada_is_string_type): Likewise.
1609         * ada-lang.h (ada_is_character_type): Update declaration
1610         (ada_is_string_type): Likewise.
1611
1612 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1613
1614         Support style in 'frame|thread apply'
1615
1616         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1617         * record.c (record_start, record_stop): Update callers of
1618         execute_command_to_string with false.
1619         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1620         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1621         methods.
1622         (class string_file): New constructor with term_out parameter.
1623         Override methods term_out and can_emit_style_escape.  New member
1624         term_out.
1625         (class stdio_file): Override can_emit_style_escape.
1626         (class tee_file): Override term_out and can_emit_style_escape.
1627         * utils.h (can_emit_style_escape): Remove.
1628         * utils.c (can_emit_style_escape): Likewise.
1629         Update all callers of can_emit_style_escape (SOMESTREAM) to
1630         SOMESTREAM->can_emit_style_escape.
1631         * source-cache.c (source_cache::get_source_lines): Likewise.
1632         * stack.c (frame_apply_command_count): Call execute_command_to_string
1633         passing the term_out characteristic of the current gdb_stdout.
1634         * thread.c (thr_try_catch_cmd): Likewise.
1635         * top.c (execute_command_to_string): pass term_out parameter
1636         to construct the string_file for the command output.
1637         * ui-file.c (term_cli_styling): New function (most code moved
1638         from utils.c can_emit_style_escape).
1639         (string_file::string_file, string_file::can_emit_style_escape,
1640         stdio_file::can_emit_style_escape, tee_file::term_out,
1641         tee_file::can_emit_style_escape): New functions.
1642
1643 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1644
1645         * NEWS: Mention the new set|show may-call-functions.
1646         * infcall.c (may_call_functions_p): New variable.
1647         (show_may_call_functions_p): New function.
1648         (call_function_by_hand_dummy): Throws an error if not
1649         may-call-functions.
1650         (_initialize_infcall): Call add_setshow_boolean_cmd for
1651         may-call-functions.
1652
1653 2019-04-25  Keith Seitz  <keiths@redhat.com>
1654
1655         PR c++/24367
1656         * cp-support.c (inspect_type): Don't attempt substitutions
1657         of symbol with the same name.
1658
1659 2019-04-25  Tom Tromey  <tromey@adacore.com>
1660
1661         PR gdb/24475:
1662         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1663         static.
1664
1665 2019-04-25  Tom Tromey  <tromey@adacore.com>
1666
1667         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1668         rvalue reference.
1669         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1670         (gdb_xml_parser::parse): Use std::move.
1671         * python/python-internal.h (gdbpy_convert_exception): Take a const
1672         reference.
1673         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1674         std::move.
1675         * python/py-utils.c (gdbpy_convert_exception): Take a const
1676         reference.
1677         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1678         Use std::move.
1679         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1680         Use std::move.
1681         * mi/mi-main.c (mi_print_exception): Take a const reference.
1682         * main.c (handle_command_errors): Take a const reference.
1683         * linespec.c (parse_linespec): Use std::move.
1684         * infcall.c (run_inferior_call): Use std::move.
1685         (call_function_by_hand_dummy): Use std::move.
1686         * exec.c (try_open_exec_file): Use std::move.
1687         * exceptions.h (exception_print, exception_fprintf)
1688         (exception_print_same): Update.
1689         * exceptions.c (print_exception, exception_print)
1690         (exception_fprintf, exception_print_same): Change parameters to
1691         const reference.
1692         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1693         * common/new-op.c: Use std::move.
1694         * common/common-exceptions.h (struct gdb_exception): Add move
1695         constructor.
1696         (struct gdb_exception_error, struct gdb_exception_quit, struct
1697         gdb_quit_bad_alloc): Change constructor to move constructor.
1698         (throw_exception): Change parameter to rvalue reference.
1699         * common/common-exceptions.c (throw_exception): Take rvalue
1700         reference.
1701         * cli/cli-interp.c (safe_execute_command): Use std::move.
1702         * breakpoint.c (insert_bp_location, location_to_sals): Use
1703         std::move.
1704
1705 2019-04-25  Tom Tromey  <tromey@adacore.com>
1706
1707         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1708         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1709         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1710         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1711         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1712         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1713         guile/scm-value.c: Use unpack.
1714         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1715         gdbscm_gdb_exception.
1716         (gdbscm_throw_gdb_exception): Likewise.
1717         (struct gdbscm_gdb_exception): New.
1718         (unpack): New function.
1719         (gdbscm_wrap): Use unpack.
1720
1721 2019-04-25  Tom Tromey  <tromey@adacore.com>
1722
1723         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1724         (gdb_rl_callback_handler): Use std::move.
1725         * common/common-exceptions.h (struct gdb_exception): Add move
1726         assignment operator.
1727         (throw_exception_sjlj): Change "exception" to const reference.
1728         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1729         (throw_exception_sjlj): Change "exception" to const reference.
1730
1731 2019-04-25  Tom Tromey  <tromey@adacore.com>
1732
1733         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1734         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1735         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1736         Update.
1737         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1738         Update.
1739         * mi/mi-interp.c (mi_interp::exec): Update.
1740         * linespec.c (parse_linespec): Update.
1741         * infcall.c (run_inferior_call): Update.
1742         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1743         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1744         (gdbscm_lookup_global_symbol): Update.
1745         * guile/scm-param.c (gdbscm_parameter_value): Update.
1746         * guile/scm-frame.c (gdbscm_frame_read_register)
1747         (gdbscm_frame_read_var): Update.
1748         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1749         * exec.c (try_open_exec_file): Update.
1750         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1751         (gdb_rl_callback_handler): Update.
1752         * common/common-exceptions.h (exception_none): Don't declare.
1753         * common/common-exceptions.c (exception_none): Don't define.
1754         (struct catcher) <exception>: Update.
1755         * cli/cli-interp.c (safe_execute_command): Update.
1756         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1757
1758 2019-04-25  Ali Tamur  <tamur@google.com>
1759
1760         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1761         (read_attribute_value): Likewise.
1762         (dwarf2_read_addr_index): Update comment.
1763         (read_str_index): Add DW_FORM_strx.
1764         (dwarf2_string_attr): Likewise.
1765         (dwarf2_const_value_attr): Likewise.
1766         (dump_die_shallow): Likewise.
1767         (dwarf2_fetch_constant_bytes): Likewise.
1768         (skip_form_bytes): Likewise.
1769         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1770
1771 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1772
1773         PR corefiles/11608
1774         PR corefiles/18187
1775         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1776         OFFSET.  Verify if current mapping contains an ELF header.
1777         (linux_find_memory_regions_full): Adjust call to
1778         dump_mapping_p.
1779
1780 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1781             Kang Li <kanglictf@gmail.com>
1782
1783         PR gdb/21600
1784
1785         * dwarf2-frame.c (read_initial_length): Be consistent about using
1786         unsigned representation of length.
1787         (decode_frame_entry_1): Likewise.  Check for wraparound of
1788         end pointer as well as buffer overflow.
1789
1790 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1791
1792         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1793         "vq".
1794
1795 2019-04-24  Tom Tromey  <tromey@adacore.com>
1796
1797         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1798
1799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1800
1801         * s12z-tdep.c (s12z_unwind_pc): Delete.
1802         (s12z_unwind_sp): Delete.
1803         (s12z_gdbarch_init): Don't register deleted functions with
1804         gdbarch.
1805
1806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * rl78-tdep.c (rl78_unwind_sp): Delete.
1809         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1810
1811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1814         (xstormy16_unwind_pc): Delete.
1815         (xstormy16_dummy_id): Delete.
1816         (xstormy16_gdbarch_init): Don't register deleted functions with
1817         gdbarch.
1818
1819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1820
1821         * vax-tdep.c (vax_unwind_pc): Delete.
1822         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1823
1824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * v850-tdep.c (v850_unwind_sp): Delete.
1827         (v850_unwind_pc): Delete.
1828         (v850_dummy_id): Delete.
1829         (v850_gdbarch_init): Don't register deleted functions with
1830         gdbarch.
1831
1832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1835         (tilegx_unwind_pc): Delete.
1836         (tilegx_unwind_dummy_id): Delete.
1837         (tilegx_gdbarch_init): Don't register deleted functions with
1838         gdbarch.
1839
1840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1843         (tic6x_dummy_id): Delete.
1844         (tic6x_gdbarch_init): Don't register deleted functions with
1845         gdbarch.
1846
1847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1848
1849         * sparc-tdep.c (sparc_unwind_pc): Delete.
1850         (sparc32_gdbarch_init): Don't register deleted function with
1851         gdbarch.
1852
1853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * sh-tdep.c (sh_unwind_sp): Delete.
1856         (sh_unwind_pc): Delete.
1857         (sh_dummy_id): Delete.
1858         (sh_gdbarch_init): Don't register deleted functions with
1859         gdbarch.
1860
1861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1862
1863         * score-tdep.c (score_unwind_sp): Delete.
1864         (score_unwind_pc): Delete.
1865         (score_dummy_id): Delete.
1866         (score_gdbarch_init): Don't register deleted functions with
1867         gdbarch.
1868
1869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * rx-tdep.c (rx_unwind_pc): Delete.
1872         (rx_unwind_sp): Delete.
1873         (rx_dummy_id): Delete.
1874         (rx_gdbarch_init): Don't register deleted functions with
1875         gdbarch.  Update comment.
1876
1877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1880         (rs6000_dummy_id): Delete.
1881         (rs6000_gdbarch_init): Don't register deleted functions with
1882         gdbarch.
1883
1884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * or1k-tdep.c (or1k_dummy_id): Delete.
1887         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1888
1889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1890
1891         * nios2-tdep.c (nios2_dummy_id): Delete.
1892         (nios2_unwind_sp): Delete.
1893         (nios2_gdbarch_init): Don't register deleted functions with
1894         gdbarch.
1895
1896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * nds32-tdep.c (nds32_dummy_id): Delete.
1899         (nds32_unwind_pc): Delete.
1900         (nds32_unwind_sp): Delete.
1901         (nds32_gdbarch_init): Don't register deleted functions with
1902         gdbarch.
1903
1904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         * msp430-tdep.c (msp430_unwind_pc): Delete.
1907         (msp430_unwind_sp): Delete.
1908         (msp430_dummy_id): Delete.
1909         (msp430_gdbarch_init): Don't register deleted functions with
1910         gdbarch.
1911
1912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * moxie-tdep.c (moxie_unwind_sp): Delete.
1915         (moxie_unwind_pc): Delete.
1916         (moxie_dummy_id): Delete.
1917         (moxie_gdbarch_init): Don't register deleted functions with
1918         gdbarch.
1919
1920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1921
1922         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1923         (mn10300_unwind_pc): Delete.
1924         (mn10300_unwind_sp): Delete.
1925         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1926         mn10300_unwind_sp.
1927         (mn10300_frame_unwind_init): Don't register deleted functions with
1928         gdbarch.
1929
1930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * mep-tdep.c (mep_unwind_pc): Delete.
1933         (mep_unwind_sp): Delete.
1934         (mep_dummy_id): Delete.
1935         (mep_gdbarch_init): Don't register deleted functions with
1936         gdbarch.
1937
1938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1941         (m68hc11_unwind_sp): Delete.
1942         (m68hc11_gdbarch_init): Don't register deleted functions with
1943         gdbarch.
1944
1945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * m32r-tdep.c (m32r_unwind_sp): Delete.
1948         (m32r_unwind_pc): Delete.
1949         (m32r_dummy_id): Delete.
1950         (m32r_gdbarch_init): Don't register deleted functions with
1951         gdbarch.
1952
1953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1954
1955         * m32c-tdep.c (m32c_unwind_pc): Delete.
1956         (m32c_unwind_sp): Delete.
1957         (m32c_dummy_id): Delete.
1958         (m32c_gdbarch_init): Don't register deleted functions with
1959         gdbarch.
1960
1961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1964         (lm32_unwind_pc): Delete.
1965         (lm32_dummy_id): Delete.
1966         (lm32_gdbarch_init): Don't register deleted functions with
1967         gdbarch.
1968
1969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1972         (iq2000_unwind_pc): Delete.
1973         (iq2000_dummy_id): Delete.
1974         (iq2000_gdbarch_init): Don't register deleted functions with
1975         gdbarch.
1976
1977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * nds32-tdep.c (nds32_type_align): Delete.
1980         (nds32_push_dummy_call): Use type_align instead.
1981
1982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * arm-tdep.c (arm_type_align): Only handle vector override case.
1985         (arm_push_dummy_call): Use type_align.
1986         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1987
1988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1991         case.
1992         (pass_on_stack): Use type_align.
1993         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1994         function.
1995
1996 2019-04-23  Tom Tromey  <tromey@adacore.com>
1997
1998         * dwarf2read.c (line_header::file_name_at): Remove unused
1999         overload.
2000
2001 2019-04-23  Tom de Vries  <tdevries@suse.de>
2002
2003         PR gdb/24438
2004         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2005         invocation.
2006
2007
2008 2019-03-27  Ali Tamur  <tamur@google.com>
2009
2010         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2011         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2012         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2013         (dwarf_expr_context::get_addr_index): Likewise
2014         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2015         (symbol_needs_eval_context::get_addr_index): Likewise
2016         (disassemble_dwarf_expression): Add DW_OP_addrx
2017         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2018         (read_cutu_die_from_dwo): Update comment
2019         (skip_one_die): Add DW_FORM_addrx
2020         (read_attribute_value): Likewise
2021         (var_decode_location): Add DW_OP_addrx
2022         (dwarf2_const_value_attr): Add DW_FORM_addrx
2023         (dump_die_shallow): Likewise
2024         (dwarf2_fetch_constant_bytes): Likewise
2025         (decode_locdesc): Add DW_OP_addrx
2026         (skip_form_bytes): Add DW_FORM_addrx
2027
2028 2019-04-22  Ali Tamur  <tamur@google.com>
2029
2030         * MAINTAINERS (Write After Approval): Add self.
2031
2032 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2033
2034         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2035         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2036         (open_symbol_file_object): Likewise.
2037         (svr4_default_sos): Add info parameter.
2038         (svr4_read_so_list): Likewise.
2039         (svr4_current_sos_direct): Adjust functions calls to pass down
2040         info.
2041         (svr4_current_sos_1): Add info parameter.
2042         (svr4_current_sos): Call get_svr4_info, pass info down to
2043         svr4_current_sos_1.
2044         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2045         get_svr4_info.
2046         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2047         get_svr4_info.
2048         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2049         to get_svr4_info.
2050         (probes_table_remove_objfile_probes): Likewise.
2051         (register_solib_event_probe): Add info parameter.
2052         (solist_update_incremental): Pass info parameter down to
2053         svr4_read_so_list.
2054         (disable_probes_interface): Add info parameter.
2055         (svr4_handle_solib_event): Pass current_program_space to
2056         get_svr4_info.  Adjust disable_probes_interface cleanup.
2057         (svr4_create_probe_breakpoints): Add info parameter, pass it
2058         down to register_solib_event_probe.
2059         (svr4_create_solib_event_breakpoints): Add info parameter,
2060         pass it down to svr4_create_probe_breakpoints.
2061         (enable_break): Pass info down to
2062         svr4_create_solib_event_breakpoints.
2063         (svr4_solib_create_inferior_hook): Pass current_program_space to
2064         get_svr4_info.
2065         (svr4_clear_solib): Likewise.
2066
2067 2019-04-22  Pedro Alves  <palves@redhat.com>
2068
2069         * solib-svr4.c (svr4_free_objfile_observer): New.
2070         (probe_and_action::objfile): New field.
2071         (probes_table_htab_remove_objfile_probes)
2072         (probes_table_remove_objfile_probes): New functions.
2073         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2074         in the new probe_and_action.  Don't store the probe in 'lookup'.
2075         (svr4_create_probe_breakpoints): Pass objfile to
2076         register_solib_event_probe.
2077         (_initialize_svr4_solib): Register a free_objfile observer.
2078
2079 2019-04-19  Tom Tromey  <tom@tromey.com>
2080
2081         * common/queue.h: Remove.
2082
2083 2019-04-19  Tom Tromey  <tom@tromey.com>
2084
2085         * event-loop.c: Don't include "common/queue.h".
2086
2087 2019-04-19  Tom Tromey  <tom@tromey.com>
2088
2089         * remote.c (remote_target): Use delete.
2090         * remote-notif.h: Include <list>, not "common/queue.h".
2091         (notif_client_p): Remove typedef.
2092         (remote_notif_state): Add constructor, destructor, initializer.
2093         <notif_queue>: Now a std::list.
2094         (remote_notif_state_xfree): Don't declare.
2095         * remote-notif.c (remote_notif_process, handle_notification)
2096         (remote_notif_state_allocate): Update.
2097         (~remote_notif_state): Rename from remote_notif_state_xfree.
2098
2099 2019-04-19  Tom Tromey  <tom@tromey.com>
2100
2101         * symfile.c (reread_symbols): Update.
2102         * objfiles.c (objfile_register_static_link)
2103         (objfile_lookup_static_link): Update
2104         (~objfile) Don't delete static_links.
2105         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2106
2107 2019-04-19  Tom Tromey  <tom@tromey.com>
2108
2109         * type-stack.h (struct type_stack) <insert>: Constify string.
2110         * type-stack.c (type_stack::insert): Constify string.
2111         * gdbtypes.h (lookup_template_type): Update.
2112         (address_space_name_to_int): Update.
2113         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2114         const.
2115         (lookup_template_type): Make name const.
2116         * c-exp.y: Update rules.
2117         (lex_one_token, classify_name, classify_inner_name)
2118         (c_print_token): Update.
2119         * p-exp.y: Update rules.
2120         (yylex): Update.
2121         * f-exp.y: Update rules.
2122         (yylex): Update.
2123         * d-exp.y: Update rules.
2124         (lex_one_token, classify_name, classify_inner_name): Update.
2125         * parse.c (write_dollar_variable, copy_name): Return std::string.
2126         * parser-defs.h (copy_name): Change return type.
2127         * m2-exp.y: Update rules.
2128         (yylex): Update.
2129         * go-exp.y (lex_one_token): Update.
2130         Update rules.
2131         (classify_unsafe_function, classify_packaged_name)
2132         (classify_name, yylex): Update.
2133
2134 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2135
2136         * configure.ac: add --enable-source-highlight switch.
2137         * configure: Regenerate.
2138         * top.c (print_gdb_version): plumb --enable-source-highlight
2139         status to "show configuration".
2140
2141 2019-04-19  Tom Tromey  <tromey@adacore.com>
2142
2143         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2144         Check ADA_TYPE_P.
2145         (empty_record, ada_template_to_fixed_record_type_1)
2146         (template_to_static_fixed_type)
2147         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2148         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2149         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2150         macros.
2151
2152 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2153
2154         PR symtab/24423:
2155         * source.c (print_source_lines_base): Advance "iter" when a
2156         control character is seen.
2157
2158 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2159
2160         * inferior.h (struct infcall_suspend_state_deleter):
2161         Catch exception in destructor to avoid crash.
2162
2163 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2164
2165         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2166         close to the add_com "shell".
2167
2168 2019-04-18  Tom Tromey  <tromey@adacore.com>
2169
2170         * process-stratum-target.h (class process_stratum_target)
2171         <stratum>: Add "final".
2172
2173 2019-04-17  Tom Tromey  <tromey@adacore.com>
2174
2175         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2176         against nullptr before use.
2177
2178 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2179
2180         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2181
2182 2019-04-17  Jim Wilson  <jimw@sifive.com>
2183             Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2186         code read might fail, assume 4-byte breakpoint in that case.
2187
2188 2019-04-15  Leszek Swirski  <leszeks@google.com>
2189
2190         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2191         rather than a hand-rolled POD check when checking for forced MEMORY
2192         classification.
2193
2194 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2197         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2198         function.
2199         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2200         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2201         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2202         declaration.
2203
2204 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2205
2206         * aarch64-linux-nat.c
2207         (aarch64_linux_nat_target::thread_architecture): Add override.
2208         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2209         each VQ.
2210
2211 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2212
2213         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2214
2215 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2218         target types of size 96-bits, add some additional comments, and
2219         check that the builtin type we found was the correct size.
2220
2221 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2222
2223         * utils.c (prompt_for_continue): Don't restore the styling at the
2224         end, as applied_style has the wrong value.  This fixes styling in
2225         long lists of file names that are interrupted by the "Continue?"
2226         prompt.
2227
2228 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2231         * c-lang.c (c_language_defn): Likewise.
2232         (cplus_language_defn): Likewise.
2233         (asm_language_defn): Likewise.
2234         (minimal_language_defn): Likewise.
2235         * d-lang.c (d_language_defn): Likewise.
2236         * f-lang.c (f_language_defn): Likewise.
2237         * go-lang.c (go_language_defn): Likewise.
2238         * language.c (unknown_language_defn): Likewise.
2239         (auto_language_defn): Likewise.
2240         * language.h (struct language_defn): Remove la_magic field.
2241         (LANG_MAGIC): Delete.
2242         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2243         * objc-lang.c (objc_language_defn): Likewise.
2244         * opencl-lang.c (opencl_language_defn): Likewise.
2245         * p-lang.c (pascal_language_defn): Likewise.
2246         * rust-lang.c (rust_language_defn): Likewise.
2247
2248 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * riscv-tdep.c (riscv_type_align): New function.
2251         (riscv_type_alignment): Delete.
2252         (riscv_arg_location): Use 'type_align'.
2253         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2254
2255 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * gdbtypes.c (type_align): A struct with no non-static fields also
2258         has alignment of 1.
2259
2260 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2261
2262         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2263         component to 0.
2264         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2265         member.
2266         (riscv_struct_info::analyse): New implementation using new
2267         analyse_inner member function.
2268         (riscv_struct_info::field_offset): New member function.
2269         (riscv_struct_info::m_offsets): New member variable.
2270         (riscv_struct_info::analyse_inner): New private member function,
2271         takes the old implementation of riscv_struct_info::analyse but
2272         extended to track field offsets.
2273         (riscv_call_arg_struct): Update the struct folding special cases
2274         to handle cases where empty C++ structs, which are non-zero
2275         length, are found.
2276         (riscv_arg_location): Initialise the length of each location, a
2277         non-zero length now indicates the location is in use.
2278         (riscv_push_dummy_call): Allow for the first location having a
2279         non-zero offset when setting up arguments.
2280         (riscv_return_value): Likewise, but for return values.
2281
2282 2019-04-11  Tom Tromey  <tromey@adacore.com>
2283
2284         * utils.c (internal_vproblem): Make "msg" const.
2285
2286 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2287
2288         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2289         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2290         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2291         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2292
2293 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2294
2295         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2296         function.
2297         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2298         of amd64_collect_native_gregset.
2299         (amd64_linux_nat_target::store_registers): Likewise.
2300
2301 2019-04-10  Tom Tromey  <tom@tromey.com>
2302
2303         * symtab.c (lookup_global_symbol_from_objfile)
2304         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2305         * objfiles.h (class separate_debug_iterator): New.
2306         (class separate_debug_range): New.
2307         (struct objfile) <separate_debug_objfiles>: New method.
2308         (objfile_separate_debug_iterate): Don't declare.
2309         * objfiles.c (separate_debug_iterator::operator++): Rename from
2310         objfile_separate_debug_iterate.
2311         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2312         iterator.
2313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2314         iterator.
2315
2316 2019-04-10  Tom Tromey  <tom@tromey.com>
2317
2318         * symfile.c (reread_symbols): Remove old comment.
2319         * objfiles.c (free_all_objfiles): Fix a typo.
2320
2321 2019-04-10  Tom Tromey  <tom@tromey.com>
2322
2323         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2324         * minsyms.c (lookup_minimal_symbol): Use foreach.
2325         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2326         (lookup_minimal_symbol_solib_trampoline): Likewise.
2327         * symfile.c (reread_symbols): Use foreach.
2328
2329 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2330             Tom Tromey  <tromey@adacore.com>
2331
2332         PR rust/24414:
2333         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2334         (rust_lex_int_test): Change "value" to be LONGEST.
2335         (rust_lex_tests): Add test for long integer literal.
2336
2337 2019-04-09  Tom Tromey  <tromey@adacore.com>
2338
2339         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2340         to bool.
2341         (extended_remote_target::attach): Update.
2342         (remote_target::remote_notice_new_inferior): Update.
2343         (remote_target::add_current_inferior_and_thread): Update.
2344         * inferior.c (exit_inferior_1): Use "false".
2345         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2346
2347 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2348
2349         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2350         the "start" command.
2351
2352 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2353
2354         * python/py-inferior.c (infpy_thread_from_thread_handle):
2355         Adjust comments to reflect renaming of thread_from_thread_handle
2356         to thread_from_handle.  Adjust keywords.  Fix type error message.
2357         (inferior_object_methods): Add thread_from_handle.  Retain
2358         thread_from_thread_handle, but mark it as deprecated.
2359
2360 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2361
2362         * gdbthread.h (find_thread_by_handle): Revise declaration.
2363         * thread.c (find_thread_by_handle): Likewise.  Adjust
2364         implementation too.
2365         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2366         support for buffer objects as handles.
2367
2368 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2369
2370         * python/py-infthread.c (thpy_thread_handle): New function.
2371         (thread_object_methods): Register thpy_thread_handle.
2372
2373 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2374
2375         * gdbthread.h (thread_to_thread_handle): Declare.
2376         * thread.c (gdbtypes.h): Include.
2377         (thread_to_thread_handle): New function.
2378
2379         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2380         (target_thread_info_to_thread_handle): Declare.
2381         * target.c (target_thread_info_to_thread_handle): New function.
2382         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2383         * target-delegates.c: Regenerate.
2384
2385         * linux-thread-db.c (class thread_db_target): Add method
2386         thread_info_to_thread_handle.
2387         (thread_db_target::thread_info_to_thread_handle): Define.
2388         * remote.c (class remote_target): Add new method
2389         thread_info_to_thread_handle.
2390         (remote_target::thread_info_to_thread_handle): Define.
2391
2392 2019-04-08  Pedro Alves  <palves@redhat.com>
2393
2394         * common/common-exceptions.c (throw_exception): Don't create
2395         named object to throw; throw directly.
2396         (throw_it): Likewise.  Don't initialize gdb_exception::message
2397         here, with new; pass FMT and AP to the ctor instead.
2398         * common/common-exceptions.h: Include <string>.
2399         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2400         const char *, va_list)): New ctor.  Use std::make_shared.
2401         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2402         errors)): Delete.
2403         (gdb_exception_error::gdb_exception_error(enum errors, const char
2404         *, va_list)): New.
2405         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2406         Add assertion.
2407         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2408         errors)): Delete.
2409         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2410         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2411         Add assertion.
2412
2413 2019-04-08  Tom Tromey  <tom@tromey.com>
2414
2415         * valops.c (value_rtti_indirect_type): Replace throw_exception
2416         with throw.
2417         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2418         with throw.
2419         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2420         throw.
2421         * target.c (target_translate_tls_address): Replace throw_exception
2422         with throw.
2423         * stack.c (frame_apply_command_count): Replace throw_exception
2424         with throw.
2425         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2426         throw.
2427         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2428         with throw.
2429         * rs6000-tdep.c (rs6000_frame_cache)
2430         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2431         * remote.c: Replace throw_exception with throw.
2432         * record-full.c (record_full_message, record_full_wait_1)
2433         (record_full_restore): Replace throw_exception with throw.
2434         * record-btrace.c:
2435         (get_thread_current_frame_id, record_btrace_start_replaying)
2436         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2437         (cmd_record_btrace_start): Replace throw_exception with throw.
2438         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2439         throw.
2440         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2441         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2442         * linespec.c:
2443         (find_linespec_symbols): Replace throw_exception with throw.
2444         * infrun.c (displaced_step_prepare, resume): Replace
2445         throw_exception with throw.
2446         * infcmd.c (post_create_inferior): Replace throw_exception with
2447         throw.
2448         * inf-loop.c (inferior_event_handler): Replace throw_exception
2449         with throw.
2450         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2451         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2452         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2453         (get_prev_frame_always, get_frame_pc_if_available)
2454         (get_frame_address_in_block_if_available, get_frame_language):
2455         Replace throw_exception with throw.
2456         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2457         throw_exception with throw.
2458         * eval.c (fetch_subexp_value, evaluate_var_value)
2459         (evaluate_funcall, evaluate_subexp_standard): Replace
2460         throw_exception with throw.
2461         * dwarf2loc.c (call_site_find_chain)
2462         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2463         Replace throw_exception with throw.
2464         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2465         with throw.
2466         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2467         throw.
2468         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2469         * completer.c (complete_line_internal): Replace throw_exception
2470         with throw.
2471         * compile/compile-object-run.c (compile_object_run): Replace
2472         throw_exception with throw.
2473         * cli/cli-script.c (process_next_line): Replace throw_exception
2474         with throw.
2475         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2476         (btrace_enable, btrace_maint_update_pt_packets): Replace
2477         throw_exception with throw.
2478         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2479         throw_exception with throw.
2480         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2481         throw_exception with throw.
2482         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2483         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2484         * aarch64-tdep.c (aarch64_make_prologue_cache)
2485         (aarch64_make_stub_cache): Replace throw_exception with throw.
2486
2487 2019-04-08  Tom Tromey  <tom@tromey.com>
2488
2489         * common/common-exceptions.c (throw_exception): Rename from
2490         throw_exception_cxx.  Remove old copy.  Make argument const.
2491         (throw_it): Create and throw exception objects directly.
2492         * common/common-exceptions.h (throw_exception): Make argument
2493         const.
2494         (struct gdb_exception_error): Add constructor.
2495         (struct gdb_exception_quit): Add constructor.
2496
2497 2019-04-08  Tom Tromey  <tom@tromey.com>
2498
2499         * common/common-exceptions.h (exception_rethrow): Don't declare.
2500         (TRY_SJLJ): Update comment.
2501         (TRY, CATCH, END_CATCH): Remove.
2502         * common/common-exceptions.c (exception_rethrow): Remove.
2503
2504 2019-04-08  Tom Tromey  <tom@tromey.com>
2505
2506         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2507         Remove.
2508         (gdb_exception_error): Rename from
2509         gdb_exception_RETURN_MASK_ERROR.
2510         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2511         (gdb_quit_bad_alloc): Update.
2512         * aarch64-tdep.c: Update.
2513         * ada-lang.c: Update.
2514         * ada-typeprint.c: Update.
2515         * ada-valprint.c: Update.
2516         * amd64-tdep.c: Update.
2517         * arch-utils.c: Update.
2518         * break-catch-throw.c: Update.
2519         * breakpoint.c: Update.
2520         * btrace.c: Update.
2521         * c-varobj.c: Update.
2522         * cli/cli-cmds.c: Update.
2523         * cli/cli-interp.c: Update.
2524         * cli/cli-script.c: Update.
2525         * common/common-exceptions.c: Update.
2526         * common/new-op.c: Update.
2527         * common/selftest.c: Update.
2528         * compile/compile-c-symbols.c: Update.
2529         * compile/compile-cplus-symbols.c: Update.
2530         * compile/compile-object-load.c: Update.
2531         * compile/compile-object-run.c: Update.
2532         * completer.c: Update.
2533         * corelow.c: Update.
2534         * cp-abi.c: Update.
2535         * cp-support.c: Update.
2536         * cp-valprint.c: Update.
2537         * darwin-nat.c: Update.
2538         * disasm-selftests.c: Update.
2539         * dtrace-probe.c: Update.
2540         * dwarf-index-cache.c: Update.
2541         * dwarf-index-write.c: Update.
2542         * dwarf2-frame-tailcall.c: Update.
2543         * dwarf2-frame.c: Update.
2544         * dwarf2loc.c: Update.
2545         * dwarf2read.c: Update.
2546         * eval.c: Update.
2547         * event-loop.c: Update.
2548         * event-top.c: Update.
2549         * exec.c: Update.
2550         * f-valprint.c: Update.
2551         * fbsd-tdep.c: Update.
2552         * frame-unwind.c: Update.
2553         * frame.c: Update.
2554         * gdbtypes.c: Update.
2555         * gnu-v3-abi.c: Update.
2556         * guile/guile-internal.h: Update.
2557         * guile/scm-block.c: Update.
2558         * guile/scm-breakpoint.c: Update.
2559         * guile/scm-cmd.c: Update.
2560         * guile/scm-disasm.c: Update.
2561         * guile/scm-frame.c: Update.
2562         * guile/scm-lazy-string.c: Update.
2563         * guile/scm-math.c: Update.
2564         * guile/scm-param.c: Update.
2565         * guile/scm-ports.c: Update.
2566         * guile/scm-pretty-print.c: Update.
2567         * guile/scm-symbol.c: Update.
2568         * guile/scm-symtab.c: Update.
2569         * guile/scm-type.c: Update.
2570         * guile/scm-value.c: Update.
2571         * i386-linux-tdep.c: Update.
2572         * i386-tdep.c: Update.
2573         * inf-loop.c: Update.
2574         * infcall.c: Update.
2575         * infcmd.c: Update.
2576         * infrun.c: Update.
2577         * jit.c: Update.
2578         * language.c: Update.
2579         * linespec.c: Update.
2580         * linux-fork.c: Update.
2581         * linux-nat.c: Update.
2582         * linux-tdep.c: Update.
2583         * linux-thread-db.c: Update.
2584         * main.c: Update.
2585         * mi/mi-cmd-break.c: Update.
2586         * mi/mi-cmd-stack.c: Update.
2587         * mi/mi-interp.c: Update.
2588         * mi/mi-main.c: Update.
2589         * objc-lang.c: Update.
2590         * p-valprint.c: Update.
2591         * parse.c: Update.
2592         * ppc-linux-tdep.c: Update.
2593         * printcmd.c: Update.
2594         * python/py-arch.c: Update.
2595         * python/py-breakpoint.c: Update.
2596         * python/py-cmd.c: Update.
2597         * python/py-finishbreakpoint.c: Update.
2598         * python/py-frame.c: Update.
2599         * python/py-framefilter.c: Update.
2600         * python/py-gdb-readline.c: Update.
2601         * python/py-inferior.c: Update.
2602         * python/py-infthread.c: Update.
2603         * python/py-lazy-string.c: Update.
2604         * python/py-linetable.c: Update.
2605         * python/py-objfile.c: Update.
2606         * python/py-param.c: Update.
2607         * python/py-prettyprint.c: Update.
2608         * python/py-progspace.c: Update.
2609         * python/py-record-btrace.c: Update.
2610         * python/py-record.c: Update.
2611         * python/py-symbol.c: Update.
2612         * python/py-type.c: Update.
2613         * python/py-unwind.c: Update.
2614         * python/py-utils.c: Update.
2615         * python/py-value.c: Update.
2616         * python/python.c: Update.
2617         * record-btrace.c: Update.
2618         * record-full.c: Update.
2619         * remote-fileio.c: Update.
2620         * remote.c: Update.
2621         * riscv-tdep.c: Update.
2622         * rs6000-aix-tdep.c: Update.
2623         * rs6000-tdep.c: Update.
2624         * rust-exp.y: Update.
2625         * rust-lang.c: Update.
2626         * s390-tdep.c: Update.
2627         * selftest-arch.c: Update.
2628         * solib-dsbt.c: Update.
2629         * solib-frv.c: Update.
2630         * solib-spu.c: Update.
2631         * solib-svr4.c: Update.
2632         * solib.c: Update.
2633         * sparc64-linux-tdep.c: Update.
2634         * stack.c: Update.
2635         * symfile-mem.c: Update.
2636         * symmisc.c: Update.
2637         * target.c: Update.
2638         * thread.c: Update.
2639         * top.c: Update.
2640         * tracefile-tfile.c: Update.
2641         * tui/tui.c: Update.
2642         * typeprint.c: Update.
2643         * unittests/cli-utils-selftests.c: Update.
2644         * unittests/parse-connection-spec-selftests.c: Update.
2645         * valops.c: Update.
2646         * valprint.c: Update.
2647         * value.c: Update.
2648         * varobj.c: Update.
2649         * windows-nat.c: Update.
2650         * x86-linux-nat.c: Update.
2651         * xml-support.c: Update.
2652
2653 2019-04-08  Tom Tromey  <tom@tromey.com>
2654
2655         * xml-support.c: Use C++ exception handling.
2656         * x86-linux-nat.c: Use C++ exception handling.
2657         * windows-nat.c: Use C++ exception handling.
2658         * varobj.c: Use C++ exception handling.
2659         * value.c: Use C++ exception handling.
2660         * valprint.c: Use C++ exception handling.
2661         * valops.c: Use C++ exception handling.
2662         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2663         handling.
2664         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2665         * typeprint.c: Use C++ exception handling.
2666         * tui/tui.c: Use C++ exception handling.
2667         * tracefile-tfile.c: Use C++ exception handling.
2668         * top.c: Use C++ exception handling.
2669         * thread.c: Use C++ exception handling.
2670         * target.c: Use C++ exception handling.
2671         * symmisc.c: Use C++ exception handling.
2672         * symfile-mem.c: Use C++ exception handling.
2673         * stack.c: Use C++ exception handling.
2674         * sparc64-linux-tdep.c: Use C++ exception handling.
2675         * solib.c: Use C++ exception handling.
2676         * solib-svr4.c: Use C++ exception handling.
2677         * solib-spu.c: Use C++ exception handling.
2678         * solib-frv.c: Use C++ exception handling.
2679         * solib-dsbt.c: Use C++ exception handling.
2680         * selftest-arch.c: Use C++ exception handling.
2681         * s390-tdep.c: Use C++ exception handling.
2682         * rust-lang.c: Use C++ exception handling.
2683         * rust-exp.y: Use C++ exception handling.
2684         * rs6000-tdep.c: Use C++ exception handling.
2685         * rs6000-aix-tdep.c: Use C++ exception handling.
2686         * riscv-tdep.c: Use C++ exception handling.
2687         * remote.c: Use C++ exception handling.
2688         * remote-fileio.c: Use C++ exception handling.
2689         * record-full.c: Use C++ exception handling.
2690         * record-btrace.c: Use C++ exception handling.
2691         * python/python.c: Use C++ exception handling.
2692         * python/py-value.c: Use C++ exception handling.
2693         * python/py-utils.c: Use C++ exception handling.
2694         * python/py-unwind.c: Use C++ exception handling.
2695         * python/py-type.c: Use C++ exception handling.
2696         * python/py-symbol.c: Use C++ exception handling.
2697         * python/py-record.c: Use C++ exception handling.
2698         * python/py-record-btrace.c: Use C++ exception handling.
2699         * python/py-progspace.c: Use C++ exception handling.
2700         * python/py-prettyprint.c: Use C++ exception handling.
2701         * python/py-param.c: Use C++ exception handling.
2702         * python/py-objfile.c: Use C++ exception handling.
2703         * python/py-linetable.c: Use C++ exception handling.
2704         * python/py-lazy-string.c: Use C++ exception handling.
2705         * python/py-infthread.c: Use C++ exception handling.
2706         * python/py-inferior.c: Use C++ exception handling.
2707         * python/py-gdb-readline.c: Use C++ exception handling.
2708         * python/py-framefilter.c: Use C++ exception handling.
2709         * python/py-frame.c: Use C++ exception handling.
2710         * python/py-finishbreakpoint.c: Use C++ exception handling.
2711         * python/py-cmd.c: Use C++ exception handling.
2712         * python/py-breakpoint.c: Use C++ exception handling.
2713         * python/py-arch.c: Use C++ exception handling.
2714         * printcmd.c: Use C++ exception handling.
2715         * ppc-linux-tdep.c: Use C++ exception handling.
2716         * parse.c: Use C++ exception handling.
2717         * p-valprint.c: Use C++ exception handling.
2718         * objc-lang.c: Use C++ exception handling.
2719         * mi/mi-main.c: Use C++ exception handling.
2720         * mi/mi-interp.c: Use C++ exception handling.
2721         * mi/mi-cmd-stack.c: Use C++ exception handling.
2722         * mi/mi-cmd-break.c: Use C++ exception handling.
2723         * main.c: Use C++ exception handling.
2724         * linux-thread-db.c: Use C++ exception handling.
2725         * linux-tdep.c: Use C++ exception handling.
2726         * linux-nat.c: Use C++ exception handling.
2727         * linux-fork.c: Use C++ exception handling.
2728         * linespec.c: Use C++ exception handling.
2729         * language.c: Use C++ exception handling.
2730         * jit.c: Use C++ exception handling.
2731         * infrun.c: Use C++ exception handling.
2732         * infcmd.c: Use C++ exception handling.
2733         * infcall.c: Use C++ exception handling.
2734         * inf-loop.c: Use C++ exception handling.
2735         * i386-tdep.c: Use C++ exception handling.
2736         * i386-linux-tdep.c: Use C++ exception handling.
2737         * guile/scm-value.c: Use C++ exception handling.
2738         * guile/scm-type.c: Use C++ exception handling.
2739         * guile/scm-symtab.c: Use C++ exception handling.
2740         * guile/scm-symbol.c: Use C++ exception handling.
2741         * guile/scm-pretty-print.c: Use C++ exception handling.
2742         * guile/scm-ports.c: Use C++ exception handling.
2743         * guile/scm-param.c: Use C++ exception handling.
2744         * guile/scm-math.c: Use C++ exception handling.
2745         * guile/scm-lazy-string.c: Use C++ exception handling.
2746         * guile/scm-frame.c: Use C++ exception handling.
2747         * guile/scm-disasm.c: Use C++ exception handling.
2748         * guile/scm-cmd.c: Use C++ exception handling.
2749         * guile/scm-breakpoint.c: Use C++ exception handling.
2750         * guile/scm-block.c: Use C++ exception handling.
2751         * guile/guile-internal.h: Use C++ exception handling.
2752         * gnu-v3-abi.c: Use C++ exception handling.
2753         * gdbtypes.c: Use C++ exception handling.
2754         * frame.c: Use C++ exception handling.
2755         * frame-unwind.c: Use C++ exception handling.
2756         * fbsd-tdep.c: Use C++ exception handling.
2757         * f-valprint.c: Use C++ exception handling.
2758         * exec.c: Use C++ exception handling.
2759         * event-top.c: Use C++ exception handling.
2760         * event-loop.c: Use C++ exception handling.
2761         * eval.c: Use C++ exception handling.
2762         * dwarf2read.c: Use C++ exception handling.
2763         * dwarf2loc.c: Use C++ exception handling.
2764         * dwarf2-frame.c: Use C++ exception handling.
2765         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2766         * dwarf-index-write.c: Use C++ exception handling.
2767         * dwarf-index-cache.c: Use C++ exception handling.
2768         * dtrace-probe.c: Use C++ exception handling.
2769         * disasm-selftests.c: Use C++ exception handling.
2770         * darwin-nat.c: Use C++ exception handling.
2771         * cp-valprint.c: Use C++ exception handling.
2772         * cp-support.c: Use C++ exception handling.
2773         * cp-abi.c: Use C++ exception handling.
2774         * corelow.c: Use C++ exception handling.
2775         * completer.c: Use C++ exception handling.
2776         * compile/compile-object-run.c: Use C++ exception handling.
2777         * compile/compile-object-load.c: Use C++ exception handling.
2778         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2779         * compile/compile-c-symbols.c: Use C++ exception handling.
2780         * common/selftest.c: Use C++ exception handling.
2781         * common/new-op.c: Use C++ exception handling.
2782         * cli/cli-script.c: Use C++ exception handling.
2783         * cli/cli-interp.c: Use C++ exception handling.
2784         * cli/cli-cmds.c: Use C++ exception handling.
2785         * c-varobj.c: Use C++ exception handling.
2786         * btrace.c: Use C++ exception handling.
2787         * breakpoint.c: Use C++ exception handling.
2788         * break-catch-throw.c: Use C++ exception handling.
2789         * arch-utils.c: Use C++ exception handling.
2790         * amd64-tdep.c: Use C++ exception handling.
2791         * ada-valprint.c: Use C++ exception handling.
2792         * ada-typeprint.c: Use C++ exception handling.
2793         * ada-lang.c: Use C++ exception handling.
2794         * aarch64-tdep.c: Use C++ exception handling.
2795
2796 2019-04-08  Tom Tromey  <tom@tromey.com>
2797
2798         * xml-support.c (gdb_xml_parser::parse): Update.
2799         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2800         * value.c (show_convenience): Update.
2801         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2802         (test_parse_flags_qcs): Update.
2803         * thread.c (thr_try_catch_cmd): Update.
2804         * target.c (target_translate_tls_address): Update.
2805         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2806         (info_frame_command_core, frame_apply_command_count): Update.
2807         * rust-exp.y (rust_lex_exception_test): Update.
2808         * riscv-tdep.c (riscv_print_one_register_info): Update.
2809         * remote.c (remote_target::enable_btrace): Update.
2810         * record-btrace.c (record_btrace_enable_warn): Update.
2811         * python/py-utils.c (gdbpy_convert_exception): Update.
2812         * printcmd.c (do_one_display, print_variable_and_value): Update.
2813         * mi/mi-main.c (mi_print_exception): Update.
2814         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2815         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2816         * linux-nat.c (linux_nat_target::attach): Update.
2817         * linux-fork.c (class scoped_switch_fork_info): Update.
2818         * infrun.c (displaced_step_prepare): Update.
2819         * infcall.c (call_function_by_hand_dummy): Update.
2820         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2821         * gnu-v3-abi.c (print_one_vtable): Update.
2822         * frame.c (get_prev_frame_always): Update.
2823         * f-valprint.c (info_common_command_for_block): Update.
2824         * exec.c (try_open_exec_file): Update.
2825         * exceptions.c (print_exception, exception_print)
2826         (exception_fprintf, exception_print_same): Update.
2827         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2828         * dwarf-index-cache.c (index_cache::store)
2829         (index_cache::lookup_gdb_index): Update.
2830         * darwin-nat.c (maybe_cache_shell): Update.
2831         * cp-valprint.c (cp_print_value_fields): Update.
2832         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2833         (gcc_cplus_symbol_address): Update.
2834         * compile/compile-c-symbols.c (gcc_convert_symbol)
2835         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2836         * common/selftest.c: Update.
2837         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2838         a std::string.
2839         (exception_try_scope_entry, exception_try_scope_exit): Don't
2840         declare.
2841         (struct exception_try_scope): Remove.
2842         (TRY): Don't use exception_try_scope.
2843         (struct gdb_exception): Add constructor, operator=.
2844         <what>: New method.
2845         (struct gdb_exception_RETURN_MASK_ALL)
2846         (struct gdb_exception_RETURN_MASK_ERROR)
2847         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2848         (struct gdb_quit_bad_alloc): Update.
2849         * common/common-exceptions.c (exception_none): Change
2850         initializer.
2851         (struct catcher) <state, exception>: Initialize inline.
2852         <prev>: Remove member.
2853         (current_catcher): Remove.
2854         (catchers): New global.
2855         (exceptions_state_mc_init): Simplify.
2856         (catcher_pop): Remove.
2857         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2858         (try_scope_depth, exception_try_scope_entry)
2859         (exception_try_scope_exit): Remove.
2860         (throw_exception_sjlj): Update.
2861         (exception_messages, exception_messages_size): Remove.
2862         (throw_it): Simplify.
2863         (gdb_exception_sliced_copy): Remove.
2864         (throw_exception_cxx): Update.
2865         * cli/cli-script.c (script_from_file): Update.
2866         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2867         Update.
2868         * ada-valprint.c (ada_val_print): Update.
2869         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2870         (create_excep_cond_exprs): Update.
2871
2872 2019-04-08  Tom Tromey  <tom@tromey.com>
2873
2874         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2875         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2876         (TRY, CATCH, END_CATCH): Remove some definitions.
2877         * common/common-exceptions.c: Don't use GDB_XCPT.
2878         (catcher_list_size): Remove.
2879         (throw_exception, throw_it): Simplify.
2880
2881 2019-04-05  Tom Tromey  <tom@tromey.com>
2882
2883         Revert the header-sorting patch.
2884         * ft32-tdep.c: Revert.
2885         * frv-tdep.c: Revert.
2886         * frv-linux-tdep.c: Revert.
2887         * frame.c: Revert.
2888         * frame-unwind.c: Revert.
2889         * frame-base.c: Revert.
2890         * fork-child.c: Revert.
2891         * findvar.c: Revert.
2892         * findcmd.c: Revert.
2893         * filesystem.c: Revert.
2894         * filename-seen-cache.h: Revert.
2895         * filename-seen-cache.c: Revert.
2896         * fbsd-tdep.c: Revert.
2897         * fbsd-nat.h: Revert.
2898         * fbsd-nat.c: Revert.
2899         * f-valprint.c: Revert.
2900         * f-typeprint.c: Revert.
2901         * f-lang.c: Revert.
2902         * extension.h: Revert.
2903         * extension.c: Revert.
2904         * extension-priv.h: Revert.
2905         * expprint.c: Revert.
2906         * exec.h: Revert.
2907         * exec.c: Revert.
2908         * exceptions.c: Revert.
2909         * event-top.c: Revert.
2910         * event-loop.c: Revert.
2911         * eval.c: Revert.
2912         * elfread.c: Revert.
2913         * dwarf2read.h: Revert.
2914         * dwarf2read.c: Revert.
2915         * dwarf2loc.c: Revert.
2916         * dwarf2expr.h: Revert.
2917         * dwarf2expr.c: Revert.
2918         * dwarf2-frame.c: Revert.
2919         * dwarf2-frame-tailcall.c: Revert.
2920         * dwarf-index-write.h: Revert.
2921         * dwarf-index-write.c: Revert.
2922         * dwarf-index-common.c: Revert.
2923         * dwarf-index-cache.h: Revert.
2924         * dwarf-index-cache.c: Revert.
2925         * dummy-frame.c: Revert.
2926         * dtrace-probe.c: Revert.
2927         * disasm.h: Revert.
2928         * disasm.c: Revert.
2929         * disasm-selftests.c: Revert.
2930         * dictionary.c: Revert.
2931         * dicos-tdep.c: Revert.
2932         * demangle.c: Revert.
2933         * dcache.h: Revert.
2934         * dcache.c: Revert.
2935         * darwin-nat.h: Revert.
2936         * darwin-nat.c: Revert.
2937         * darwin-nat-info.c: Revert.
2938         * d-valprint.c: Revert.
2939         * d-namespace.c: Revert.
2940         * d-lang.c: Revert.
2941         * ctf.c: Revert.
2942         * csky-tdep.c: Revert.
2943         * csky-linux-tdep.c: Revert.
2944         * cris-tdep.c: Revert.
2945         * cris-linux-tdep.c: Revert.
2946         * cp-valprint.c: Revert.
2947         * cp-support.c: Revert.
2948         * cp-namespace.c: Revert.
2949         * cp-abi.c: Revert.
2950         * corelow.c: Revert.
2951         * corefile.c: Revert.
2952         * continuations.c: Revert.
2953         * completer.h: Revert.
2954         * completer.c: Revert.
2955         * complaints.c: Revert.
2956         * coffread.c: Revert.
2957         * coff-pe-read.c: Revert.
2958         * cli-out.h: Revert.
2959         * cli-out.c: Revert.
2960         * charset.c: Revert.
2961         * c-varobj.c: Revert.
2962         * c-valprint.c: Revert.
2963         * c-typeprint.c: Revert.
2964         * c-lang.c: Revert.
2965         * buildsym.c: Revert.
2966         * buildsym-legacy.c: Revert.
2967         * build-id.h: Revert.
2968         * build-id.c: Revert.
2969         * btrace.c: Revert.
2970         * bsd-uthread.c: Revert.
2971         * breakpoint.h: Revert.
2972         * breakpoint.c: Revert.
2973         * break-catch-throw.c: Revert.
2974         * break-catch-syscall.c: Revert.
2975         * break-catch-sig.c: Revert.
2976         * blockframe.c: Revert.
2977         * block.c: Revert.
2978         * bfin-tdep.c: Revert.
2979         * bfin-linux-tdep.c: Revert.
2980         * bfd-target.c: Revert.
2981         * bcache.c: Revert.
2982         * ax-general.c: Revert.
2983         * ax-gdb.h: Revert.
2984         * ax-gdb.c: Revert.
2985         * avr-tdep.c: Revert.
2986         * auxv.c: Revert.
2987         * auto-load.c: Revert.
2988         * arm-wince-tdep.c: Revert.
2989         * arm-tdep.c: Revert.
2990         * arm-symbian-tdep.c: Revert.
2991         * arm-pikeos-tdep.c: Revert.
2992         * arm-obsd-tdep.c: Revert.
2993         * arm-nbsd-tdep.c: Revert.
2994         * arm-nbsd-nat.c: Revert.
2995         * arm-linux-tdep.c: Revert.
2996         * arm-linux-nat.c: Revert.
2997         * arm-fbsd-tdep.c: Revert.
2998         * arm-fbsd-nat.c: Revert.
2999         * arm-bsd-tdep.c: Revert.
3000         * arch-utils.c: Revert.
3001         * arc-tdep.c: Revert.
3002         * arc-newlib-tdep.c: Revert.
3003         * annotate.h: Revert.
3004         * annotate.c: Revert.
3005         * amd64-windows-tdep.c: Revert.
3006         * amd64-windows-nat.c: Revert.
3007         * amd64-tdep.c: Revert.
3008         * amd64-sol2-tdep.c: Revert.
3009         * amd64-obsd-tdep.c: Revert.
3010         * amd64-obsd-nat.c: Revert.
3011         * amd64-nbsd-tdep.c: Revert.
3012         * amd64-nbsd-nat.c: Revert.
3013         * amd64-nat.c: Revert.
3014         * amd64-linux-tdep.c: Revert.
3015         * amd64-linux-nat.c: Revert.
3016         * amd64-fbsd-tdep.c: Revert.
3017         * amd64-fbsd-nat.c: Revert.
3018         * amd64-dicos-tdep.c: Revert.
3019         * amd64-darwin-tdep.c: Revert.
3020         * amd64-bsd-nat.c: Revert.
3021         * alpha-tdep.c: Revert.
3022         * alpha-obsd-tdep.c: Revert.
3023         * alpha-nbsd-tdep.c: Revert.
3024         * alpha-mdebug-tdep.c: Revert.
3025         * alpha-linux-tdep.c: Revert.
3026         * alpha-linux-nat.c: Revert.
3027         * alpha-bsd-tdep.c: Revert.
3028         * alpha-bsd-nat.c: Revert.
3029         * aix-thread.c: Revert.
3030         * agent.c: Revert.
3031         * addrmap.c: Revert.
3032         * ada-varobj.c: Revert.
3033         * ada-valprint.c: Revert.
3034         * ada-typeprint.c: Revert.
3035         * ada-tasks.c: Revert.
3036         * ada-lang.c: Revert.
3037         * aarch64-tdep.c: Revert.
3038         * aarch64-ravenscar-thread.c: Revert.
3039         * aarch64-newlib-tdep.c: Revert.
3040         * aarch64-linux-tdep.c: Revert.
3041         * aarch64-linux-nat.c: Revert.
3042         * aarch64-fbsd-tdep.c: Revert.
3043         * aarch64-fbsd-nat.c: Revert.
3044         * aarch32-linux-nat.c: Revert.
3045
3046 2019-04-05  Tom Tromey  <tom@tromey.com>
3047
3048         * ft32-tdep.c: Sort headers.
3049         * frv-tdep.c: Sort headers.
3050         * frv-linux-tdep.c: Sort headers.
3051         * frame.c: Sort headers.
3052         * frame-unwind.c: Sort headers.
3053         * frame-base.c: Sort headers.
3054         * fork-child.c: Sort headers.
3055         * findvar.c: Sort headers.
3056         * findcmd.c: Sort headers.
3057         * filesystem.c: Sort headers.
3058         * filename-seen-cache.h: Sort headers.
3059         * filename-seen-cache.c: Sort headers.
3060         * fbsd-tdep.c: Sort headers.
3061         * fbsd-nat.h: Sort headers.
3062         * fbsd-nat.c: Sort headers.
3063         * f-valprint.c: Sort headers.
3064         * f-typeprint.c: Sort headers.
3065         * f-lang.c: Sort headers.
3066         * extension.h: Sort headers.
3067         * extension.c: Sort headers.
3068         * extension-priv.h: Sort headers.
3069         * expprint.c: Sort headers.
3070         * exec.h: Sort headers.
3071         * exec.c: Sort headers.
3072         * exceptions.c: Sort headers.
3073         * event-top.c: Sort headers.
3074         * event-loop.c: Sort headers.
3075         * eval.c: Sort headers.
3076         * elfread.c: Sort headers.
3077         * dwarf2read.h: Sort headers.
3078         * dwarf2read.c: Sort headers.
3079         * dwarf2loc.c: Sort headers.
3080         * dwarf2expr.h: Sort headers.
3081         * dwarf2expr.c: Sort headers.
3082         * dwarf2-frame.c: Sort headers.
3083         * dwarf2-frame-tailcall.c: Sort headers.
3084         * dwarf-index-write.h: Sort headers.
3085         * dwarf-index-write.c: Sort headers.
3086         * dwarf-index-common.c: Sort headers.
3087         * dwarf-index-cache.h: Sort headers.
3088         * dwarf-index-cache.c: Sort headers.
3089         * dummy-frame.c: Sort headers.
3090         * dtrace-probe.c: Sort headers.
3091         * disasm.h: Sort headers.
3092         * disasm.c: Sort headers.
3093         * disasm-selftests.c: Sort headers.
3094         * dictionary.c: Sort headers.
3095         * dicos-tdep.c: Sort headers.
3096         * demangle.c: Sort headers.
3097         * dcache.h: Sort headers.
3098         * dcache.c: Sort headers.
3099         * darwin-nat.h: Sort headers.
3100         * darwin-nat.c: Sort headers.
3101         * darwin-nat-info.c: Sort headers.
3102         * d-valprint.c: Sort headers.
3103         * d-namespace.c: Sort headers.
3104         * d-lang.c: Sort headers.
3105         * ctf.c: Sort headers.
3106         * csky-tdep.c: Sort headers.
3107         * csky-linux-tdep.c: Sort headers.
3108         * cris-tdep.c: Sort headers.
3109         * cris-linux-tdep.c: Sort headers.
3110         * cp-valprint.c: Sort headers.
3111         * cp-support.c: Sort headers.
3112         * cp-namespace.c: Sort headers.
3113         * cp-abi.c: Sort headers.
3114         * corelow.c: Sort headers.
3115         * corefile.c: Sort headers.
3116         * continuations.c: Sort headers.
3117         * completer.h: Sort headers.
3118         * completer.c: Sort headers.
3119         * complaints.c: Sort headers.
3120         * coffread.c: Sort headers.
3121         * coff-pe-read.c: Sort headers.
3122         * cli-out.h: Sort headers.
3123         * cli-out.c: Sort headers.
3124         * charset.c: Sort headers.
3125         * c-varobj.c: Sort headers.
3126         * c-valprint.c: Sort headers.
3127         * c-typeprint.c: Sort headers.
3128         * c-lang.c: Sort headers.
3129         * buildsym.c: Sort headers.
3130         * buildsym-legacy.c: Sort headers.
3131         * build-id.h: Sort headers.
3132         * build-id.c: Sort headers.
3133         * btrace.c: Sort headers.
3134         * bsd-uthread.c: Sort headers.
3135         * breakpoint.h: Sort headers.
3136         * breakpoint.c: Sort headers.
3137         * break-catch-throw.c: Sort headers.
3138         * break-catch-syscall.c: Sort headers.
3139         * break-catch-sig.c: Sort headers.
3140         * blockframe.c: Sort headers.
3141         * block.c: Sort headers.
3142         * bfin-tdep.c: Sort headers.
3143         * bfin-linux-tdep.c: Sort headers.
3144         * bfd-target.c: Sort headers.
3145         * bcache.c: Sort headers.
3146         * ax-general.c: Sort headers.
3147         * ax-gdb.h: Sort headers.
3148         * ax-gdb.c: Sort headers.
3149         * avr-tdep.c: Sort headers.
3150         * auxv.c: Sort headers.
3151         * auto-load.c: Sort headers.
3152         * arm-wince-tdep.c: Sort headers.
3153         * arm-tdep.c: Sort headers.
3154         * arm-symbian-tdep.c: Sort headers.
3155         * arm-pikeos-tdep.c: Sort headers.
3156         * arm-obsd-tdep.c: Sort headers.
3157         * arm-nbsd-tdep.c: Sort headers.
3158         * arm-nbsd-nat.c: Sort headers.
3159         * arm-linux-tdep.c: Sort headers.
3160         * arm-linux-nat.c: Sort headers.
3161         * arm-fbsd-tdep.c: Sort headers.
3162         * arm-fbsd-nat.c: Sort headers.
3163         * arm-bsd-tdep.c: Sort headers.
3164         * arch-utils.c: Sort headers.
3165         * arc-tdep.c: Sort headers.
3166         * arc-newlib-tdep.c: Sort headers.
3167         * annotate.h: Sort headers.
3168         * annotate.c: Sort headers.
3169         * amd64-windows-tdep.c: Sort headers.
3170         * amd64-windows-nat.c: Sort headers.
3171         * amd64-tdep.c: Sort headers.
3172         * amd64-sol2-tdep.c: Sort headers.
3173         * amd64-obsd-tdep.c: Sort headers.
3174         * amd64-obsd-nat.c: Sort headers.
3175         * amd64-nbsd-tdep.c: Sort headers.
3176         * amd64-nbsd-nat.c: Sort headers.
3177         * amd64-nat.c: Sort headers.
3178         * amd64-linux-tdep.c: Sort headers.
3179         * amd64-linux-nat.c: Sort headers.
3180         * amd64-fbsd-tdep.c: Sort headers.
3181         * amd64-fbsd-nat.c: Sort headers.
3182         * amd64-dicos-tdep.c: Sort headers.
3183         * amd64-darwin-tdep.c: Sort headers.
3184         * amd64-bsd-nat.c: Sort headers.
3185         * alpha-tdep.c: Sort headers.
3186         * alpha-obsd-tdep.c: Sort headers.
3187         * alpha-nbsd-tdep.c: Sort headers.
3188         * alpha-mdebug-tdep.c: Sort headers.
3189         * alpha-linux-tdep.c: Sort headers.
3190         * alpha-linux-nat.c: Sort headers.
3191         * alpha-bsd-tdep.c: Sort headers.
3192         * alpha-bsd-nat.c: Sort headers.
3193         * aix-thread.c: Sort headers.
3194         * agent.c: Sort headers.
3195         * addrmap.c: Sort headers.
3196         * ada-varobj.c: Sort headers.
3197         * ada-valprint.c: Sort headers.
3198         * ada-typeprint.c: Sort headers.
3199         * ada-tasks.c: Sort headers.
3200         * ada-lang.c: Sort headers.
3201         * aarch64-tdep.c: Sort headers.
3202         * aarch64-ravenscar-thread.c: Sort headers.
3203         * aarch64-newlib-tdep.c: Sort headers.
3204         * aarch64-linux-tdep.c: Sort headers.
3205         * aarch64-linux-nat.c: Sort headers.
3206         * aarch64-fbsd-tdep.c: Sort headers.
3207         * aarch64-fbsd-nat.c: Sort headers.
3208         * aarch32-linux-nat.c: Sort headers.
3209
3210 2019-04-04  Tom Tromey  <tom@tromey.com>
3211
3212         * varobj.c (varobj_create): Update.
3213         * rust-exp.y (struct rust_parser) <update_innermost_block,
3214         lookup_symbol>: New methods.
3215         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3216         Rename.
3217         (rust_parser::rust_lookup_type)
3218         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3219         * printcmd.c (display_command, do_one_display): Update.
3220         * parser-defs.h (struct parser_state) <parser_state>: Add
3221         "tracker" parameter.
3222         (block_tracker): New member.
3223         (class innermost_block_tracker) <innermost_block_tracker>: Add
3224         "types" parameter.
3225         <reset>: Remove method.
3226         (innermost_block): Don't declare.
3227         (null_post_parser): Update.
3228         * parse.c (innermost_block): Remove global.
3229         (write_dollar_variable): Update.
3230         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3231         Remove "tracker_types" parameter.
3232         (parse_expression): Add "tracker" parameter.
3233         (parse_expression_for_completion): Update.
3234         (null_post_parser): Add "tracker" parameter.
3235         * p-exp.y: Update rules.
3236         * m2-exp.y: Update rules.
3237         * language.h (struct language_defn) <la_post_parser>: Add
3238         "tracker" parameter.
3239         * go-exp.y: Update rules.
3240         * f-exp.y: Update rules.
3241         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3242         parameter.
3243         * d-exp.y: Update rules.
3244         * c-exp.y: Update rules.
3245         * breakpoint.c (set_breakpoint_condition): Create an
3246         innermost_block_tracker.
3247         (watch_command_1): Likewise.
3248         * ada-lang.c (resolve): Add "tracker" parameter.
3249         (resolve_subexp): Likewise.
3250         * ada-exp.y (write_var_from_sym): Update.
3251
3252 2019-04-04  Tom Tromey  <tom@tromey.com>
3253
3254         * type-stack.h: New file.
3255         * type-stack.c: New file.
3256         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3257         type-stack.h.
3258         (insert_into_type_stack, insert_type, push_type, push_type_int)
3259         (insert_type_address_space, pop_type, pop_type_int)
3260         (pop_typelist, pop_type_stack, append_type_stack)
3261         (push_type_stack, get_type_stack, push_typelist)
3262         (follow_type_instance_flags, follow_types): Don't declare.
3263         * parse.c (type_stack): Remove global.
3264         (parse_exp_in_context): Update.
3265         (insert_into_type_stack, insert_type, push_type, push_type_int)
3266         (insert_type_address_space, pop_type, pop_type_int)
3267         (pop_typelist, pop_type_stack, append_type_stack)
3268         (push_type_stack, get_type_stack, push_typelist)
3269         (follow_type_instance_flags, follow_types): Remove (moved to
3270         type-stack.c).
3271         * f-exp.y (type_stack): New global.
3272         Update rules.
3273         (push_kind_type, f_parse): Update.
3274         * d-exp.y (type_stack): New global.
3275         Update rules.
3276         (d_parse): Update.
3277         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3278         Update rules.
3279         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3280         (HFILES_NO_SRCDIR): Add type-stack.h.
3281
3282 2019-04-04  Tom Tromey  <tom@tromey.com>
3283
3284         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3285         (rust_parser::convert_ast_to_expression, rust_parse)
3286         (rust_lex_test_completion, rust_lex_tests): Update.
3287         * parser-defs.h (struct expr_completion_state): New.
3288         (struct parser_state) <parser_state>: Add completion parameter.
3289         <mark_struct_expression, mark_completion_tag>: New methods.
3290         <parse_completion, m_completion_state>: New members.
3291         (prefixify_expression, null_post_parser): Update.
3292         (mark_struct_expression, mark_completion_tag): Don't declare.
3293         * parse.c (parse_completion, expout_last_struct)
3294         (expout_tag_completion_type, expout_completion_name): Remove
3295         globals.
3296         (parser_state::mark_struct_expression)
3297         (parser_state::mark_completion_tag): Now methods.
3298         (prefixify_expression): Add last_struct parameter.
3299         (prefixify_subexp): Likewise.
3300         (parse_exp_1): Update.
3301         (parse_exp_in_context): Add cstate parameter.  Update.
3302         (parse_expression_for_completion): Create an
3303         expr_completion_state.
3304         (null_post_parser): Add "completion" parameter.
3305         * p-exp.y: Update rules.
3306         (yylex): Update.
3307         * language.h (struct language_defn) <la_post_parser>: Add
3308         "completing" parameter.
3309         * go-exp.y: Update rules.
3310         (lex_one_token): Update.
3311         * expression.h (parse_completion): Don't declare.
3312         * d-exp.y: Update rules.
3313         (lex_one_token): Update rules.
3314         * c-exp.y: Update rules.
3315         (lex_one_token): Update.
3316         * ada-lang.c (resolve): Add "parse_completion" parameter.
3317         (resolve_subexp): Likewise.
3318         (ada_resolve_function): Likewise.
3319
3320 2019-04-04  Tom Tromey  <tom@tromey.com>
3321
3322         * parser-defs.h (struct parser_state) <start_arglist,
3323         end_arglist>: New methods.
3324         <arglist_len, m_funcall_chain>: New members.
3325         (arglist_len, start_arglist, end_arglist): Don't declare.
3326         * parse.c (arglist_len, funcall_chain): Remove global.
3327         (start_arglist, end_arglist): Remove functions.
3328         (parse_exp_in_context): Update.
3329         * p-exp.y: Update rules.
3330         * m2-exp.y: Update rules.
3331         * go-exp.y: Update rules.
3332         * f-exp.y: Update rules.
3333         * d-exp.y: Update rules.
3334         * c-exp.y: Update rules.
3335
3336 2019-04-04  Tom Tromey  <tom@tromey.com>
3337
3338         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3339         lex_operator, push_back>: New methods.
3340         Update all rules.
3341         (rust_parser::lex_hex, lex_escape): Rename and update.
3342         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3343         (rust_parser::lex_operator): Rename and update.
3344         (rust_parser::lex_number, rustyylex, rustyyerror)
3345         (rust_lex_test_init, rust_lex_test_sequence)
3346         (rust_lex_test_push_back, rust_lex_tests): Update.
3347         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3348         parameter.
3349         <lexptr, prev_lexptr>: New members.
3350         (lexptr, prev_lexptr): Don't declare.
3351         * parse.c (lexptr, prev_lexptr): Remove globals.
3352         (parse_exp_in_context): Update.
3353         * p-exp.y (yylex, yyerror): Update.
3354         * m2-exp.y (parse_number, yylex, yyerror): Update.
3355         * go-exp.y (lex_one_token, yyerror): Update.
3356         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3357         * d-exp.y (lex_one_token, yyerror): Update.
3358         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3359         (lex_one_token, yyerror): Update.
3360         * ada-lex.l (YY_INPUT): Update.
3361         (rewind_to_char): Update.
3362         * ada-exp.y (yyerror): Update.
3363
3364 2019-04-04  Tom Tromey  <tom@tromey.com>
3365
3366         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3367         * parser-defs.h (struct parser_state) <parser_state>: Add new
3368         parameter.
3369         <comma_terminates>: New member.
3370         (comma_terminates): Don't declare global.
3371         * parse.c (comma_terminates): Remove global.
3372         (parse_exp_in_context): Update.
3373         * p-exp.y (yylex): Update.
3374         * m2-exp.y (yylex): Update.
3375         * go-exp.y (lex_one_token): Update.
3376         * f-exp.y (yylex): Update.
3377         * d-exp.y (lex_one_token): Update.
3378         * c-exp.y (lex_one_token): Update.
3379         * ada-lex.l: Update.
3380
3381 2019-04-04  Tom Tromey  <tom@tromey.com>
3382
3383         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3384         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3385         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3386         * parser-defs.h (paren_depth): Don't declare.
3387         * parse.c (paren_depth): Remove global.
3388         (parse_exp_in_context): Update.
3389         * p-exp.y (paren_depth): New global.
3390         (pascal_parse): Initialize it.
3391         * m2-exp.y (paren_depth): New global.
3392         (m2_parse): Initialize it.
3393         * go-exp.y (paren_depth): New global.
3394         (go_parse): Initialize it.
3395         * f-exp.y (paren_depth): New global.
3396         (f_parse): Initialize it.
3397         * d-exp.y (paren_depth): New global.
3398         (d_parse): Initialize it.
3399         * c-exp.y (paren_depth): New global.
3400         (c_parse): Initialize it.
3401         * ada-lex.l (paren_depth): New global.
3402         (lexer_init): Initialize it.
3403
3404 2019-04-04  Tom Tromey  <tom@tromey.com>
3405
3406         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3407         (rust_parser::convert_ast_to_type)
3408         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3409         * parser-defs.h (struct parser_state) <parser_state>: Add
3410         parameters.  Initialize new members.
3411         <expression_context_block, expression_context_pc>: New members.
3412         * parse.c (expression_context_block, expression_context_pc):
3413         Remove globals.
3414         (parse_exp_in_context): Update.
3415         * p-exp.y: Update all rules.
3416         (yylex): Update.
3417         * m2-exp.y: Update all rules.
3418         (yylex): Update.
3419         * go-exp.y (yylex): Update.
3420         * f-exp.y (yylex): Update.
3421         * d-exp.y: Update all rules.
3422         (yylex): Update.
3423         * c-exp.y: Update all rules.
3424         (lex_one_token, classify_name, yylex, c_parse): Update.
3425         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3426
3427 2019-04-04  Tom Tromey  <tom@tromey.com>
3428
3429         * gdbarch.h, gdbarch.c: Rebuild.
3430         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3431         * stap-probe.h:
3432         (struct stap_parse_info): Replace "parser_state" with
3433         "expr_builder".
3434         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3435         (parser_state): New class.
3436         * parse.c (expr_builder): Rename.
3437         (expr_builder::release): Rename.
3438         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3439         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3440         (write_exp_elt_longcst, write_exp_elt_floatcst)
3441         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3442         (write_exp_string_vector, write_exp_bitstring)
3443         (write_exp_msymbol, mark_struct_expression)
3444         (write_dollar_variable)
3445         (insert_type_address_space, increase_expout_size): Replace
3446         "parser_state" with "expr_builder".
3447         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3448         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3449         "parser_state" with "expr_builder".
3450
3451 2019-04-04  Tom Tromey  <tom@tromey.com>
3452
3453         * rust-exp.y: Replace "parse_language" with method call.
3454         * p-exp.y:
3455         (yylex): Replace "parse_language" with method call.
3456         * m2-exp.y:
3457         (yylex): Replace "parse_language" with method call.
3458         * go-exp.y (classify_name): Replace "parse_language" with method
3459         call.
3460         * f-exp.y (yylex): Replace "parse_language" with method call.
3461         * d-exp.y (lex_one_token): Replace "parse_language" with method
3462         call.
3463         * c-exp.y:
3464         (lex_one_token, classify_name, yylex): Replace "parse_language"
3465         with method call.
3466         * ada-exp.y (find_primitive_type, type_char)
3467         (type_system_address): Replace "parse_language" with method call.
3468
3469 2019-04-04  Tom Tromey  <tom@tromey.com>
3470
3471         * rust-exp.y: Replace "parse_gdbarch" with method call.
3472         * parse.c (write_dollar_variable, insert_type_address_space):
3473         Replace "parse_gdbarch" with method call.
3474         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3475         call.
3476         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3477         call.
3478         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3479         "parse_gdbarch" with method call.
3480         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3481         with method call.
3482         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3483         "parse_gdbarch" with method call.
3484         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3485         "parse_gdbarch" with method call.
3486         * c-exp.y (parse_type, parse_number, classify_name): Replace
3487         "parse_gdbarch" with method call.
3488         * ada-lex.l: Replace "parse_gdbarch" with method call.
3489         * ada-exp.y (parse_type, find_primitive_type, type_char)
3490         (type_system_address): Replace "parse_gdbarch" with method call.
3491
3492 2019-04-04  Tom Tromey  <tom@tromey.com>
3493
3494         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3495         * stap-probe.c (stap_parse_argument): Update.
3496         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3497         initial_size parameter.
3498         * rust-exp.y (rust_lex_tests): Update.
3499         * parse.c (parser_state): Update.
3500         (parse_exp_in_context): Update.
3501         * parser-defs.h (struct parser_state) <parser_state>: Remove
3502         "initial_size" parameter.
3503
3504 2019-04-04  Tom Tromey  <tom@tromey.com>
3505
3506         * parser-defs.h (increase_expout_size): Don't declare.
3507         * parse.c (increase_expout_size): Now static.
3508
3509 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3510
3511         * gnu-nat.c (gnu_nat_target::wait): Fix
3512         target_waitstatus_to_string call.
3513
3514 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * eval.c (evaluate_subexp_standard): Handle internal functions
3517         during Fortran function call handling.
3518
3519 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * NEWS: Mention new internal functions.
3522         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3523         (read_base_type): Use dwarf2_init_complex_target_type.
3524         * value.c (creal_internal_fn): New function.
3525         (cimag_internal_fn): New function.
3526         (_initialize_values): Register new internal functions.
3527
3528 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * infrun.c (stop_all_threads): If debug_infrun, always
3531         trace the wait status after wait_one, using
3532         target_waitstatus_to_string and target_pid_to_str.
3533         (handle_inferior_event): Replace various trace of
3534         wait status kind by a single trace.
3535         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3536         wait status kind image by target_waitstatus_to_string.
3537         * target/waitstatus.c (target_waitstatus_to_string): Fix
3538         obsolete comment.
3539
3540 2019-04-01  Tom Tromey  <tromey@adacore.com>
3541
3542         PR symtab/23331:
3543         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3544
3545 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3546             Pedro Alves  <palves@redhat.com>
3547
3548         * top.c (quit_force): Call 'finalize_values'.
3549         * value.c (finalize_values): New function.
3550         * value.h (finalize_values): Declare.
3551
3552 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3553
3554         * NEWS: Announce $_gdb_major and $_gdb_minor.
3555
3556         * top.c (init_gdb_version_vars): New function.
3557         (gdb_init): Call init_gdb_version_vars.
3558
3559 2019-03-29  Tom Tromey  <tromey@adacore.com>
3560
3561         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3562         help text.  Remove dead code.
3563
3564 2019-03-29  Keith Seitz  <keiths@redhat.com>
3565
3566         From Siddhesh Poyarekar:
3567         * f-lang.h (f77_get_upperbound): Return LONGEST.
3568         (f77_get_lowerbound): Likewise.
3569         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3570         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3571         print them.
3572         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3573         plongest to format print it.
3574         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3575         (f77_get_upperbound): Likewise.
3576         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3577         LOWER_BOUND to LONGEST.
3578         (f77_create_arrayprint_offset_tbl): Likewise.
3579
3580 2019-03-29  Keith Seitz  <keiths@redhat.com>
3581
3582         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3583         %s/pulongest for TYPE_LENGTH instead of %d in format
3584         strings.
3585         * ada-typerint.c (ada_print_type): Likewise.
3586         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3587         * compile/compile-c-support.c (generate_register_struct): Likewise.
3588         * gdbtypes.c (recursive_dump_type): Likewise.
3589         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3590         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3591         instead of %d in format strings.
3592         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3593         to std::min to ULONGEST.
3594         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3595         instead of %d in format strings.
3596         * tracepoint.c (info_scope_command): Likewise.
3597         * typeprint.c (print_offset_data::update)
3598         (print_offset_data::finish): Likewise.
3599         * xtensa-tdep.c (xtensa_store_return_value)
3600         (xtensa_push_dummy_call): Likewise.
3601
3602 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3603
3604         * windows-nat.c (display_selector): Fixed format specifications
3605         for 64-bit Cygwin.
3606
3607 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3608
3609         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3610
3611 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3612
3613         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3614         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3615         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3616         (nios2_linux_init_abi): Install it.
3617
3618 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3619
3620         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3621
3622 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3623
3624         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3625
3626 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3627             Tom Tromey  <tromey@adacore.com>
3628
3629         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3630
3631 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3632
3633         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3634         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3635         method to compute the bounds of range types. Also print "[evaluated]"
3636         if the bounds' values come from a dynamic evaluation.
3637
3638 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3641         whitespace when pretty printing is on.
3642
3643 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3644
3645         * ppc-linux-nat.c: Add include.
3646
3647 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3648
3649         * NEWS: Mention AArch64 Pointer Authentication.
3650
3651 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3652
3653         * arm-linux-nat.c: Add include.
3654
3655 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3656
3657         * source-cache.c (source_cache::get_source_lines): Re-read
3658         fullname after calling open_source_file.
3659
3660 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3661
3662         * NEWS: Mention TLS support for FreeBSD.
3663
3664 2019-03-25  Tom Tromey  <tromey@adacore.com>
3665
3666         * minsyms.c (BUNCH_SIZE): Update comment.
3667         (~minimal_symbol_reader): Remove old comment.
3668         (compact_minimal_symbols): Update comment.
3669         (minimal_symbol_reader::install): Remove old comment.  Update
3670         other comments.
3671
3672 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * s390-linux-nat.c: Add include.
3675
3676 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3677
3678         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3679         Call linux_get_hwcap.
3680         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3681         Likewise.
3682         (aarch64_linux_get_hwcap): Remove function.
3683         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3684         declaration.
3685         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3686         linux_get_hwcap.
3687         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3688         * linux-tdep.c (linux_get_hwcap): Add function.
3689         (linux_get_hwcap2): Likewise.
3690         * linux-tdep.h (linux_get_hwcap): Add declaration.
3691         (linux_get_hwcap2): Likewise.
3692         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3693         (ppc_linux_get_hwcap2): Likewise.
3694         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3695         linux_get_hwcap.
3696         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3697         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3698         (ppc_linux_nat_target::read_description): Likewise.
3699         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3700         * s390-linux-nat.c: Likewise.
3701         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3702
3703 2019-03-24  Tom Tromey  <tom@tromey.com>
3704
3705         * ada-lang.c (standard_lookup): Simplify initialization.
3706         (ada_lookup_symbol_nonlocal): Simplify return.
3707         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3708         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3709         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3710         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3711         initialization.
3712         * solib.c (solib_global_lookup): Simplify.
3713         * symtab.c (null_block_symbol): Remove.
3714         (symbol_cache_lookup): Simplify returns.
3715         (lookup_language_this): Simplify returns.
3716         (lookup_symbol_aux): Simplify return.
3717         (lookup_local_symbol): Simplify returns.
3718         (lookup_global_symbol_from_objfile): Simplify return.
3719         (lookup_symbol_in_objfile_symtabs)
3720         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3721         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3722         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3723         * cp-namespace.c (cp_lookup_bare_symbol)
3724         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3725         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3726         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3727         (cp_lookup_symbol_via_imports): Simplify initialization.
3728         (find_symbol_in_baseclass): Likewise.
3729         * symtab.h (null_block_symbol): Remove.
3730         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3731         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3732         (d_lookup_symbol_module): Likewise.
3733         (find_symbol_in_baseclass): Simplify initialization.
3734
3735 2019-03-24  Tom Tromey  <tom@tromey.com>
3736
3737         * expression.h: Don't include symtab.h.
3738         (struct block): Forward declare.
3739
3740 2019-03-24  Tom Tromey  <tom@tromey.com>
3741
3742         * c-exp.y (typebase): Remove casts.
3743         * gdbtypes.c (lookup_unsigned_typename, )
3744         (lookup_signed_typename): Remove cast.
3745         * eval.c (parse_to_comma_and_eval): Remove cast.
3746         * parse.c (write_dollar_variable): Remove cast.
3747         * block.h (struct block) <superblock>: Now const.
3748         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3749         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3750         (map_block): Make "block" const.
3751         * symfile.h (struct quick_symbol_functions)
3752         <map_matching_symbols>: Constify block argument to "callback".
3753         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3754         const.
3755         (find_pc_sect_compunit_symtab): Make "b" const.
3756         (find_symbol_at_address): Likewise.
3757         (search_symbols): Likewise.
3758         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3759         (dw2_debug_names_lookup_symbol): Likewise.
3760         (dw2_map_matching_symbols): Update.
3761         * p-valprint.c (pascal_val_print): Remove "block".
3762         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3763         (aux_add_nonlocal_symbols): Make "block" const.
3764         (resolve_subexp): Remove cast.
3765         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3766         const.
3767         (iterate_over_file_blocks): Likewise.
3768         * f-exp.y (%union) <bval>: Remove.
3769         * coffread.c (patch_opaque_types): Make "b" const.
3770         * spu-tdep.c (spu_catch_start): Make "block" const.
3771         * c-valprint.c (print_unpacked_pointer): Remove "block".
3772         * symmisc.c (dump_symtab_1): Make "b" const.
3773         (block_depth): Make "block" const.
3774         * d-exp.y (%union) <bval>: Remove.
3775         * cp-support.h (cp_lookup_rtti_type): Update.
3776         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3777         * psymtab.c (psym_lookup_symbol): Make "block" const.
3778         (maintenance_check_psymtabs): Make "b" const.
3779         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3780         (enumerate_locals, enumerate_args): Update.
3781         * python/py-symtab.c (stpy_global_block): Make "block" const.
3782         (stpy_static_block): Likewise.
3783         * inline-frame.c (block_starting_point_at): Make "new_block"
3784         const.
3785         * block.c (find_block_in_blockvector): Make return type const.
3786         (blockvector_for_pc_sect): Make "b" const.
3787         (find_block_in_blockvector): Make "b" const.
3788
3789 2019-03-23  Tom Tromey  <tom@tromey.com>
3790
3791         * varobj.c (varobj_create): Update.
3792         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3793         * printcmd.c (display_command, do_one_display): Don't reset
3794         innermost_block.
3795         * parser-defs.h (enum innermost_block_tracker_type): Move to
3796         expression.h.
3797         (innermost_block): Update comment.
3798         * parse.c (parse_exp_1): Add tracker_types parameter.
3799         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3800         tracker_types parameter.  Reset innermost_block.
3801         (parse_exp_in_context): Remove.
3802         (parse_expression_for_completion): Update.
3803         * objfiles.c (~objfile): Don't reset expression_context_block or
3804         innermost_block.
3805         * expression.h (enum innermost_block_tracker_type): Move from
3806         parser-defs.h.
3807         (parse_exp_1): Add tracker_types parameter.
3808         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3809         reset innermost_block.
3810
3811 2019-03-23  Tom Tromey  <tom@tromey.com>
3812
3813         * objfiles.h: Include bcache.h.
3814
3815 2019-03-23  Tom Tromey  <tom@tromey.com>
3816
3817         * linespec.c (get_current_search_block): Use
3818         scoped_restore_current_language.
3819         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3820
3821 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3822             Jiong Wang  <jiong.wang@arm.com>
3823
3824         * aarch64-linux-tdep.c
3825         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3826         section.
3827         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3828
3829 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3830             Jiong Wang  <jiong.wang@arm.com>
3831
3832         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3833         instructions.
3834         (aarch64_analyze_prologue_test): Add PACIASP test.
3835         (aarch64_prologue_prev_register): Unmask PC value.
3836
3837 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3838             Jiong Wang  <jiong.wang@arm.com>
3839
3840         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3841         (aarch64_dwarf2_prev_register): Unmask PC value.
3842         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3843         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3844         DW_CFA_AARCH64_negate_ra_state.
3845         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3846
3847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3848             Jiong Wang  <jiong.wang@arm.com>
3849
3850         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3851         registers.
3852         (aarch64_pseudo_register_name): Likewise.
3853         (aarch64_pseudo_register_type): Likewise.
3854         (aarch64_pseudo_register_reggroup_p): Likewise.
3855         (aarch64_gdbarch_init): Add pauth registers.
3856         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3857         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3858         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3859         (struct gdbarch_tdep): Add regnum for ra_state.
3860
3861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3862             Jiong Wang  <jiong.wang@arm.com>
3863
3864         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3865
3866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3867             Jiong Wang  <jiong.wang@arm.com>
3868
3869         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3870         function.
3871         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3872         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3873         (aarch64_gdbarch_init): Add puth registers.
3874         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3875         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3876         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3877
3878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3879             Jiong Wang  <jiong.wang@arm.com>
3880
3881         * aarch64-linux-nat.c
3882         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3883         * aarch64-linux-tdep.c
3884         (aarch64_linux_core_read_description): Likewise.
3885         (aarch64_linux_get_hwcap): New function.
3886         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3887         (aarch64_linux_get_hwcap): New declaration.
3888
3889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3890             Jiong Wang  <jiong.wang@arm.com>
3891
3892         * aarch64-linux-nat.c
3893         (aarch64_linux_nat_target::read_description): Add pauth param.
3894         * aarch64-linux-tdep.c
3895         (aarch64_linux_core_read_description): Likewise.
3896         * aarch64-tdep.c (struct target_desc): Add in pauth.
3897         (aarch64_read_description): Add pauth param.
3898         (aarch64_gdbarch_init): Likewise.
3899         * aarch64-tdep.h (aarch64_read_description): Likewise.
3900         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3901         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3902         * features/Makefile: Add new files.
3903         * features/aarch64-pauth.c: New file.
3904         * features/aarch64-pauth.xml: New file.
3905
3906 2019-03-20  Tom Tromey  <tromey@adacore.com>
3907
3908         * infrun.c (handle_inferior_event): Rename from
3909         handle_inferior_event_1.  Create a scoped_value_mark.
3910         (handle_inferior_event): Remove.
3911
3912 2019-03-19  Tom Tromey  <tromey@adacore.com>
3913
3914         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3915         * infrun.h (print_stop_event): Add "displays" parameter.
3916         * infrun.c (print_stop_event): Add "displays" parameter.
3917
3918 2019-03-19  Pedro Alves  <palves@redhat.com>
3919
3920         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3921         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3922         to -1.  Fix TABs vs spaces.
3923         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3924         * tui/tui-out.h (tui_ui_out) Add intro comments.
3925         <m_line, m_start_of_line>: In-class initialize, and add describing
3926         comment.
3927
3928 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3931         variable names.
3932         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3933
3934 2019-03-18  Pedro Alves  <palves@redhat.com>
3935             Eli Zaretskii <eliz@gnu.org>
3936
3937         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3938         m_line and m_start_of_line.
3939
3940 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3941
3942         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3943         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3944         it returns a newline.  This fixes a regression in TU mode, whereby
3945         the next line is output on the same screen line as the user input.
3946
3947 2019-03-18  Tom Tromey  <tromey@adacore.com>
3948
3949         * minsyms.c (minimal_symbol_reader::install): Remove call to
3950         obstack_blank.
3951
3952 2019-03-18  Pedro Alves  <palves@redhat.com>
3953
3954         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3955         New globals.
3956         (apply_style): New, factored out from ...
3957         (apply_ansi_escape): ... this.  Handle reverse video mode.
3958         (tui_set_reverse_mode): New function.
3959         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3960         * tui/tui-winsource.c (tui_show_source_line): Use
3961         tui_set_reverse_mode instead of setting A_STANDOUT.
3962         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3963         New setter methods.
3964
3965 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3966
3967         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3968         Handle tabs.
3969
3970 2019-03-18  Tom Tromey  <tromey@adacore.com>
3971
3972         * ada-lang.c (empty_array): Add "high" parameter.
3973         (ada_evaluate_subexp): Update.
3974
3975 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3976
3977         * unittests/string_view-selftests.c: Define
3978         _initialize_string_view_selftests unconditionally.
3979
3980 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3981
3982         PR gdb/24350
3983         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3984
3985 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3986
3987         PR gdb/24351
3988         * windows-nat.c (display_selector): Fix format specifiers.
3989
3990 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3991
3992         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3993         tui_refill_source_window instead of tui_refresh_win, to update the
3994         current execution line.  This fixes redisplay of the current line
3995         when stepping through the code with "next" or "step".
3996
3997 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3998
3999         * source-cache.c (source_cache::get_source_lines): Call
4000         find_source_lines to initialize s->nlines.  This fixes vertical
4001         scrolling of TUI source window when the DOWN arrow is pressed.
4002
4003 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4004
4005         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4006         linux-thread-db.c (_initialize_thread_db): Likewise.
4007
4008 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4009
4010         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4011         wclrtoeol in tui_show_source_line".  This reverts changes made in
4012         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4013
4014 2019-03-15  Tom Tromey  <tom@tromey.com>
4015
4016         * symtab.h (struct minimal_symbol): Derive from
4017         general_symbol_info.
4018         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4019         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4020         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4021         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4022         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4023         (MSYMBOL_SEARCH_NAME): Update.
4024         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4025         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4026         * minsyms.c (minimal_symbol_reader::record_full): Update.
4027
4028 2019-03-15  Tom Tromey  <tom@tromey.com>
4029
4030         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4031
4032 2019-03-15  Tom Tromey  <tom@tromey.com>
4033
4034         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4035         unique_xmalloc_ptr.
4036         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4037         Update.
4038         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4039         (build_minimal_symbol_hash_tables)
4040         (minimal_symbol_reader::install): Update.
4041
4042 2019-03-15  Tom Tromey  <tom@tromey.com>
4043
4044         * symtab.c (create_demangled_names_hash): Update.
4045         (symbol_set_names): Update.
4046         * objfiles.h (struct objfile_per_bfd_storage)
4047         <demangled_names_hash>: Now an htab_up.
4048         * objfiles.c (objfile_per_bfd_storage): Simplify.
4049
4050 2019-03-15  Tom Tromey  <tom@tromey.com>
4051
4052         * objfiles.h (struct objfile_per_bfd_storage): Declare
4053         destructor.
4054         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4055         New.
4056         (get_objfile_bfd_data): Use new.  Don't initialize
4057         language_of_main.
4058         (free_objfile_per_bfd_storage): Remove.
4059         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4060
4061 2019-03-15  Tom Tromey  <tom@tromey.com>
4062
4063         * symfile.c (reread_symbols): Update.
4064         * objfiles.c (objfile::objfile): Update.
4065         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4066         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4067         comment.
4068         (minimal_symbol_reader::install): Update.
4069         (terminate_minimal_symbol_table): Remove.
4070         * jit.c (jit_object_close_impl): Update.
4071
4072 2019-03-15  Tom Tromey  <tom@tromey.com>
4073
4074         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4075         initializations.
4076
4077 2019-03-15  Tom Tromey  <tom@tromey.com>
4078
4079         * objfiles.h (struct objfile_per_bfd_storage)
4080         <demangled_hash_languages>: Now a bitset.
4081         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4082         (lookup_minimal_symbol): Update.
4083
4084 2019-03-15  Tom Tromey  <tom@tromey.com>
4085
4086         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4087         Don't return the symbol.
4088         * coffread.c (record_minimal_symbol): Use record_full.
4089
4090 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4091
4092         The MS-Windows port of ncurses fails to switch to a color pair if
4093         one or both of the colors are the implicit default colors.  This
4094         change records the default colors when TUI is initialized, and
4095         then specifies them explicitly when a color pair uses the default
4096         colors.  This allows color styling in TUI mode on MS-Windows.
4097
4098         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4099         ncurses_norm_attr.
4100         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4101         colors in ncurses_norm_attr.
4102         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4103         "none", replace it with the default color recorded in
4104         ncurses_norm_attr.
4105
4106 2019-03-14  Tom Tromey  <tromey@adacore.com>
4107
4108         * source-cache.h (class source_cache) <get_source_lines>: Return
4109         std::string.
4110         * source-cache.c (source_cache::extract_lines): Handle case where
4111         first_pos==npos.  Return std::string.
4112         (source_cache::get_source_lines): Update.
4113
4114 2019-03-14  Tom Tromey  <tromey@adacore.com>
4115
4116         * NEWS: Add item for "style sources" commands.
4117         * source-cache.c (source_cache::get_source_lines): Check
4118         source_styling.
4119         * cli/cli-style.c (source_styling): New global.
4120         (_initialize_cli_style): Add "style sources" commands.
4121         (show_style_sources): New function.
4122         * cli/cli-style.h (source_styling): Declare.
4123
4124 2019-03-14  Pedro Alves  <palves@redhat.com>
4125             Tom Tromey  <tromey@adacore.com>
4126
4127         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4128         * tui/tui-winsource.c (tui_refill_source_window): New function,
4129         from...
4130         (tui_horizontal_source_scroll): ... here.  Move some logic.
4131         * cli/cli-style.c (set_style_enabled): Notify new observable.
4132         * tui/tui-hooks.c (tui_redisplay_source): New function.
4133         (tui_attach_detach_observers): Attach or detach
4134         tui_redisplay_source.
4135         * observable.h (source_styling_changed): New observable.
4136         * observable.c: Define source_styling_changed observable.
4137
4138 2019-03-13  Tom Tromey  <tromey@adacore.com>
4139
4140         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4141         (i386_gnu_nat_target::store_registers): Update.
4142         * target-debug.h (target_debug_print_std_string): New macro.
4143         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4144         * windows-tdep.c (display_one_tib): Update.
4145         * tui/tui-stack.c (tui_make_status_line): Update.
4146         * top.c (print_inferior_quit_action): Update.
4147         * thread.c (thr_try_catch_cmd): Update.
4148         (add_thread_with_info): Update.
4149         (thread_target_id_str): Update.
4150         (thr_try_catch_cmd): Update.
4151         (thread_command): Update.
4152         (thread_find_command): Update.
4153         * record-btrace.c (record_btrace_target::info_record)
4154         (record_btrace_resume_thread, record_btrace_target::resume)
4155         (record_btrace_cancel_resume, record_btrace_step_thread)
4156         (record_btrace_target::wait, record_btrace_target::wait)
4157         (record_btrace_target::wait, record_btrace_target::stop): Update.
4158         * progspace.c (print_program_space): Update.
4159         * process-stratum-target.c
4160         (process_stratum_target::thread_address_space): Update.
4161         * linux-fork.c (linux_fork_mourn_inferior)
4162         (detach_checkpoint_command, info_checkpoints_command)
4163         (linux_fork_context): Update.
4164         (linux_fork_detach): Update.
4165         (class scoped_switch_fork_info): Update.
4166         (delete_checkpoint_command): Update.
4167         * infrun.c (follow_fork_inferior): Update.
4168         (follow_fork_inferior): Update.
4169         (proceed_after_vfork_done): Update.
4170         (handle_vfork_child_exec_or_exit): Update.
4171         (follow_exec): Update.
4172         (displaced_step_prepare_throw): Update.
4173         (displaced_step_restore): Update.
4174         (start_step_over): Update.
4175         (resume_1): Update.
4176         (clear_proceed_status_thread): Update.
4177         (proceed): Update.
4178         (print_target_wait_results): Update.
4179         (do_target_wait): Update.
4180         (context_switch): Update.
4181         (stop_all_threads): Update.
4182         (restart_threads): Update.
4183         (finish_step_over): Update.
4184         (handle_signal_stop): Update.
4185         (switch_back_to_stepped_thread): Update.
4186         (keep_going_pass_signal): Update.
4187         (print_exited_reason): Update.
4188         (normal_stop): Update.
4189         * inferior.c (inferior_pid_to_str): Change return type.
4190         (print_selected_inferior): Update.
4191         (add_inferior): Update.
4192         (detach_inferior): Update.
4193         * dummy-frame.c (fprint_dummy_frames): Update.
4194         * dcache.c (dcache_info_1): Update.
4195         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4196         (btrace_fetch, btrace_clear): Update.
4197         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4198         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4199         type.
4200         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4201         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4202         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4203         * gdbarch.c, gdbarch.h: Rebuild.
4204         * gdbarch.sh (core_pid_to_str): Change return type.
4205         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4206         return type.
4207         (windows_nat_target::pid_to_str): Change return type.
4208         (windows_delete_thread): Update.
4209         (windows_nat_target::attach): Update.
4210         (windows_nat_target::files_info): Update.
4211         * target-delegates.c: Rebuild.
4212         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4213         return type.
4214         (sol_thread_target::pid_to_str): Change return type.
4215         * remote.c (class remote_target) <pid_to_str>: Change return
4216         type.
4217         (remote_target::pid_to_str): Change return type.
4218         (extended_remote_target::attach, remote_target::remote_stop_ns)
4219         (remote_target::remote_notif_remove_queued_reply)
4220         (remote_target::push_stop_reply, remote_target::disable_btrace):
4221         Update.
4222         (extended_remote_target::attach): Update.
4223         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4224         type.
4225         (gdbsim_target::pid_to_str): Change return type.
4226         * ravenscar-thread.c (struct ravenscar_thread_target)
4227         <pid_to_str>: Change return type.
4228         (ravenscar_thread_target::pid_to_str): Change return type.
4229         * procfs.c (class procfs_target) <pid_to_str>: Change return
4230         type.
4231         (procfs_target::pid_to_str): Change return type.
4232         (procfs_target::attach): Update.
4233         (procfs_target::detach): Update.
4234         (procfs_target::fetch_registers): Update.
4235         (procfs_target::store_registers): Update.
4236         (procfs_target::wait): Update.
4237         (procfs_target::files_info): Update.
4238         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4239         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4240         return type.
4241         (nto_procfs_target::pid_to_str): Change return type.
4242         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4243         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4244         return type.
4245         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4246         (exit_lwp): Update.
4247         (attach_proc_task_lwp_callback, get_detach_signal)
4248         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4249         (linux_nat_target::resume, wait_lwp, stop_callback)
4250         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4251         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4252         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4253         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4254         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4255         type.
4256         (inf_ptrace_target::attach): Update.
4257         (inf_ptrace_target::files_info): Update.
4258         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4259         type.
4260         (go32_nat_target::pid_to_str): Change return type.
4261         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4262         (gnu_nat_target::wait): Update.
4263         (gnu_nat_target::wait): Update.
4264         (gnu_nat_target::resume): Update.
4265         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4266         (fbsd_nat_target::wait): Update.
4267         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4268         type.
4269         (darwin_nat_target::attach): Update.
4270         * corelow.c (class core_target) <pid_to_str>: Change return type.
4271         (core_target::pid_to_str): Change return type.
4272         * target.c (normal_pid_to_str): Change return type.
4273         (default_pid_to_str): Likewise.
4274         (target_pid_to_str): Change return type.
4275         (target_translate_tls_address): Update.
4276         (target_announce_detach): Update.
4277         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4278         return type.
4279         (bsd_uthread_target::pid_to_str): Change return type.
4280         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4281         type.
4282         (bsd_kvm_target::pid_to_str): Change return type.
4283         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4284         return type.
4285         (aix_thread_target::pid_to_str): Change return type.
4286         * target.h (struct target_ops) <pid_to_str>: Change return type.
4287         (target_pid_to_str, normal_pid_to_str): Likewise.
4288         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4289         type.
4290         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4291         type.
4292         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4293         return type.
4294         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4295         type.
4296         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4297         type.
4298         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4299         return type.
4300
4301 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4302
4303         * NEWS: Mention that the new default MI version is 3.  Mention
4304         changes to the output of commands and events that deal with
4305         multi-location breakpoints.
4306         * breakpoint.c: Include "mi/mi-out.h".
4307         (print_one_breakpoint): Change output syntax if using MI version
4308         >= 3.
4309         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4310         New.
4311         (mi_multi_location_breakpoint_output_fixed): New.
4312         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4313         (mi_cmd_fix_multi_location_breakpoint_output): New.
4314         (mi_multi_location_breakpoint_output_fixed): New.
4315         * mi/mi-cmds.c (mi_cmds): Register command
4316         -fix-multi-location-breakpoint-output.
4317         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4318         interpreter "mi".
4319
4320 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4321
4322         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4323         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4324         instantiate mi_ui_out based on interpreter name.
4325         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4326         * mi/mi-main.c (mi_load_progress): Likewise.
4327
4328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4329
4330         * NEWS: Combine separate "New targets" sections for 8.3.
4331
4332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4333
4334         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4335         (ppcfbsd_init_abi): Install gdbarch
4336         "fetch_tls_load_module_address" and "get_thread_local_address"
4337         methods.
4338
4339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4340
4341         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4342         (riscv_fbsd_init_abi): Install gdbarch
4343         "fetch_tls_load_module_address" and "get_thread_local_address"
4344         methods.
4345
4346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4347
4348         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4349         (i386fbsd_init_abi): Install gdbarch
4350         "fetch_tls_load_module_address" and "get_thread_local_address"
4351         methods.
4352
4353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4354
4355         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4356         (amd64fbsd_init_abi): Install gdbarch
4357         "fetch_tls_load_module_address" and "get_thread_local_address"
4358         methods.
4359
4360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4361
4362         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4363         (struct fbsd_pspace_data): New type.
4364         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4365         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4366         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4367         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4368         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4369
4370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4371
4372         * gdbtypes.c (lookup_struct_elt): New function.
4373         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4374         * gdbtypes.h (struct struct_elt): New type.
4375         (lookup_struct_elt): New prototype.
4376
4377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4378
4379         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4380         remove disabled code block.
4381
4382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4383
4384         * gdbarch.sh (get_thread_local_address): New method.
4385         * gdbarch.h, gdbarch.c: Regenerate.
4386         * target.c (target_translate_tls_address): Use
4387         gdbarch_get_thread_local_address if present instead of
4388         target::get_thread_local_address.
4389
4390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4391
4392         * target.h (target::get_thread_local_address): Update comment.
4393
4394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4395
4396         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4397         objfile->separate_debug_objfile_backlink if not NULL.
4398
4399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4400
4401         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4402         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4403         (amd64bsd_store_inferior_registers): Likewise.
4404         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4405         Enable segment base registers.
4406         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4407         PT_GETFSBASE and PT_GETGSBASE.
4408         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4409         PT_SETGSBASE.
4410         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4411         segment base registers.
4412         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4413
4414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4415
4416         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4417         Update calls to i386_target_description to add 'segments'
4418         parameter.
4419         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4420         add segment base registers.
4421         * arch/i386.c (i386_create_target_description): Add 'segments'
4422         parameter to enable segment base registers.
4423         * arch/i386.h (i386_create_target_description): Likewise.
4424         * features/i386/32bit-segments.xml: New file.
4425         * features/i386/32bit-segments.c: Generate.
4426         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4427         call to i386_target_description to add 'segments' parameter.
4428         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4429         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4430         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4431         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4432         if feature is present.
4433         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4434         Add 'segments' parameter to call to i386_target_description.
4435         (i386_target_description): Add 'segments' parameter to enable
4436         segment base registers.
4437         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4438         to call to i386_target_description.
4439         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4440         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4441         Define I386_NUM_REGS.
4442         (i386_target_description): Add 'segments' parameter to enable
4443         segment base registers.
4444
4445 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4446
4447         PR/24325
4448         * source-cache.c: #undef open and close, to avoid unresolved
4449         externals during linking.
4450
4451 2019-03-12  Tom Tromey  <tromey@adacore.com>
4452
4453         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4454         const.  Add initializers.
4455         (_initialize_remote): Don't initialize ptid globals.
4456
4457 2019-03-12  Pedro Alves  <palves@redhat.com>
4458
4459         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4460
4461 2019-03-12  Pedro Alves  <palves@redhat.com>
4462
4463         * cp-name-parser.y (main): Remove unused 'len' variable.
4464
4465 2019-03-12  Tom Tromey  <tromey@adacore.com>
4466
4467         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4468         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4469
4470 2019-03-12  Tom Tromey  <tromey@adacore.com>
4471
4472         * linux-nat.c (iterate_over_lwps): Update.
4473         (stop_callback): Remove parameter.
4474         (stop_wait_callback, detach_callback, resume_set_callback)
4475         (select_singlestep_lwp_callback, set_ignore_sigint)
4476         (status_callback, resumed_callback, resume_clear_callback)
4477         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4478         data parameter.
4479         (linux_nat_target::detach, linux_nat_target::resume)
4480         (linux_stop_and_wait_all_lwps, select_event_lwp)
4481         (linux_nat_filter_event, linux_nat_wait_1)
4482         (linux_nat_target::kill, linux_nat_target::stop)
4483         (linux_nat_target::stop): Update.
4484         (linux_nat_resume_callback): Change type.
4485         (resume_stopped_resumed_lwps, count_events_callback)
4486         (select_event_lwp_callback): Likewise.
4487         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4488         * arm-linux-nat.c (struct update_registers_data): Remove.
4489         (update_registers_callback): Change type.
4490         (arm_linux_insert_hw_breakpoint1): Update.
4491         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4492         parameter.
4493         (x86_linux_dr_set_addr): Update.
4494         (x86_linux_dr_set_control): Update.
4495         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4496         (iterate_over_lwps): Use gdb::function_view.
4497         * nat/aarch64-linux-hw-point.c (struct
4498         aarch64_dr_update_callback_param): Remove.
4499         (debug_reg_change_callback): Change type.
4500         (aarch64_notify_debug_reg_change): Update.
4501         * s390-linux-nat.c (s390_refresh_per_info): Update.
4502
4503 2019-03-11  Tom Tromey  <tromey@adacore.com>
4504
4505         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4506         redundant assignment to "this_cu".
4507
4508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4509
4510         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4511
4512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4513
4514         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4515         from...
4516         (rank_one_type): ... this.
4517
4518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4519
4520         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4521         from...
4522         (rank_one_type): ... this.
4523
4524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4525
4526         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4527         from...
4528         (rank_one_type): ... this.
4529
4530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4531
4532         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4533         from...
4534         (rank_one_type): ... this.
4535
4536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4537
4538         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4539         from...
4540         (rank_one_type): ... this.
4541
4542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4543
4544         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4545         from...
4546         (rank_one_type): ... this.
4547
4548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4549
4550         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4551         from...
4552         (rank_one_type): ... this.
4553
4554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4555
4556         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4557         from...
4558         (rank_one_type): ... this.
4559
4560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4561
4562         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4563         from...
4564         (rank_one_type): ... this.
4565
4566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4567
4568         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4569         from...
4570         (rank_one_type): ... this.
4571
4572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4573
4574         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4575         from...
4576         (rank_one_type): ... this.
4577
4578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4579
4580         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4581         from...
4582         (rank_one_type): ... this.
4583
4584 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4585
4586         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4587         inferior-events' shows the example events.
4588
4589 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4590
4591         Support styling on native MS-Windows console
4592
4593         PR/24315
4594         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4595         on MS-Windows if $TERM is not defined.
4596
4597         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4598
4599         * posix-hdep.c (gdb_console_fputs):
4600         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4601         functions.
4602         * ui-file.h (gdb_console_fputs): Add prototype.
4603
4604         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4605         back to fputs only if the former returns zero.
4606
4607 2019-03-07  Tom Tromey  <tom@tromey.com>
4608
4609         * symmisc.c (print_symbol_bcache_statistics): Update.
4610         (print_objfile_statistics): Update.
4611         * symfile.c (allocate_symtab): Update.
4612         * stabsread.c: Don't include bcache.h.
4613         * psymtab.h (struct psymbol_bcache): Don't declare.
4614         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4615         (psymbol_bcache_init, psymbol_bcache_free)
4616         (psymbol_bcache_get_bcache): Don't declare.
4617         * psymtab.c (struct psymbol_bcache): Remove.
4618         (psymtab_storage::psymtab_storage): Update.
4619         (psymtab_storage::~psymtab_storage): Update.
4620         (psymbol_bcache_init, psymbol_bcache_free)
4621         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4622         (add_psymbol_to_bcache): Update.
4623         (allocate_psymtab): Update.
4624         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4625         macro_cache>: No longer pointers.
4626         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4627         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4628         * macrotab.c (macro_bcache): Update.
4629         * macroexp.c: Don't include bcache.h.
4630         * gdbtypes.c (check_types_worklist): Update.
4631         (types_deeply_equal): Remove TRY/CATCH.  Update.
4632         * elfread.c (elf_symtab_read): Update.
4633         * dwarf2read.c: Don't include bcache.h.
4634         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4635         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4636         (print_bcache_statistics, bcache_memory_used): Don't declare.
4637         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4638         methods.  Rename all data members.
4639         * bcache.c (struct bcache): Move to bcache.h.
4640         (bcache::expand_hash_table): Rename from expand_hash_table.
4641         (bcache): Remove.
4642         (bcache::insert): Rename from bcache_full.
4643         (bcache::compare): Rename from bcache_compare.
4644         (bcache_xmalloc): Remove.
4645         (bcache::~bcache): Rename from bcache_xfree.
4646         (bcache::print_statistics): Rename from print_bcache_statistics.
4647         (bcache::memory_used): Rename from bcache_memory_used.
4648
4649 2019-03-07  Pedro Alves  <palves@redhat.com>
4650
4651         * infrun.c (normal_stop): Also check for
4652         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4653
4654 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * f-lang.c (value_from_host_double): Moved to...
4657         * value.c (value_from_host_double): ...here.
4658         * value.h (value_from_host_double): Declare.
4659         * guile/scm-math.c (vlscm_convert_typed_number): Use
4660         value_from_host_double.
4661         (vlscm_convert_number): Likewise.
4662         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4663         * python/py-value.c (convert_value_from_python): Likewise.
4664
4665 2019-03-06  Tom Tromey  <tom@tromey.com>
4666
4667         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4668
4669 2019-03-06  Tom Tromey  <tom@tromey.com>
4670
4671         * utils.h (free_current_contents): Don't declare.
4672         * utils.c (free_current_contents): Remove.
4673
4674 2019-03-06  Tom Tromey  <tom@tromey.com>
4675
4676         * top.c (quit_force): Update.
4677         * main.c (captured_command_loop): Update.
4678         * common/new-op.c (operator new): Update.
4679         * common/common-exceptions.c (struct catcher)
4680         <save_cleanup_chain>: Remove member.
4681         (exceptions_state_mc_init): Update.
4682         (exception_try_scope_entry): Return nullptr.
4683         (exception_try_scope_exit, exception_rethrow)
4684         (throw_exception_sjlj, throw_exception_cxx): Update.
4685         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4686         (all_cleanups, do_cleanups, discard_cleanups)
4687         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4688         (restore_cleanups, restore_final_cleanups): Don't declare.
4689         (do_final_cleanups): Remove parameter.
4690         * common/cleanups.c (cleanup_chain, make_cleanup)
4691         (make_cleanup_dtor, all_cleanups, do_cleanups)
4692         (discard_my_cleanups, discard_cleanups)
4693         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4694         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4695         (null_cleanup): Remove.
4696         (do_final_cleanups): Remove parameter.
4697
4698 2019-03-06  Tom Tromey  <tom@tromey.com>
4699
4700         * remote.c (remote_target::remote_parse_stop_reply): Use
4701         unique_xmalloc_ptr.
4702
4703 2019-03-06  Tom Tromey  <tom@tromey.com>
4704
4705         * stabsread.c (struct stabs_field_info): Rename from field_info.
4706         <list, fnlist>: Add initializers.
4707         <obstack>: New member.
4708         (read_member_functions, read_struct_fields, read_baseclasses):
4709         Allocate on obstack.  Don't use cleanups.
4710         (read_one_struct_field, read_member_functions, read_struct_fields)
4711         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4712         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4713         (read_struct_type): Update.
4714
4715 2019-03-06  Tom Tromey  <tom@tromey.com>
4716
4717         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4718         * common/filestuff.h (make_cleanup_close): Don't declare.
4719         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4720         Remove.
4721
4722 2019-03-06  Tom Tromey  <tom@tromey.com>
4723
4724         * solib-aix.c: Use make_scope_exit.
4725
4726 2019-03-06  Tom Tromey  <tom@tromey.com>
4727
4728         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4729         Use make_scope_exit.
4730
4731 2019-03-06  Tom Tromey  <tom@tromey.com>
4732
4733         * solib-svr4.c (disable_probes_interface): Remove parameter.
4734         (svr4_handle_solib_event): Use make_scope_exit.
4735
4736 2019-03-06  Tom Tromey  <tom@tromey.com>
4737
4738         * remote.c (struct stop_reply_deleter): Remove.
4739         (stop_reply_up): Update.
4740         (struct stop_reply): Derive from notif_event.  Don't typedef.
4741         <regcache>: Now a std::vector.
4742         (stop_reply_xfree): Remove.
4743         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4744         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4745         (remote_target::discard_pending_stop_replies): Use delete.
4746         (remote_target::remote_parse_stop_reply): Update.
4747         (remote_target::process_stop_reply): Update.
4748         * remote-notif.h (struct notif_event): Add virtual destructor.
4749         Remove "dtr" member.
4750         (struct notif_client) <alloc_event>: Return a unique_ptr.
4751         (notif_event_xfree): Don't declare.
4752         (notif_event_up): New typedef.
4753         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4754         (notif_event_xfree, do_notif_event_xfree): Remove.
4755         (remote_notif_state_xfree): Update.
4756
4757 2019-03-06  Tom Tromey  <tom@tromey.com>
4758
4759         * infrun.c (displaced_step_clear_cleanup): Now a
4760         forward_scope_exit type.
4761         (displaced_step_prepare_throw): Update.
4762         (displaced_step_fixup): Update.
4763
4764 2019-03-06  Tom Tromey  <tom@tromey.com>
4765
4766         * inferior.h (class inferior): Update comment.
4767         * gdbthread.h (class thread_info): Update comment.
4768
4769 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4770             Tom Tromey  <tom@tromey.com>
4771
4772         * stabsread.h (struct stab_section_list): Remove.
4773         (coffstab_build_psymtabs): Update.
4774         * dbxread.c (symbuf_sections): Now a std::vector.
4775         (sect_idx): New global.
4776         (fill_symbuf): Update.
4777         (coffstab_build_psymtabs): Change type of stabsects parameter.
4778         Update.
4779         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4780         std::vector.
4781         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4782         (coff_locate_sections): Update.
4783         (coff_symfile_read): Remove cleanups.  Update.
4784         (init_stringtab): Add storage parameter.
4785         (free_stringtab, free_stringtab_cleanup): Remove.
4786         (init_lineno): Add storage parameter.
4787         (free_linetab, free_linetab_cleanup): Remove.
4788
4789 2019-03-06  Pedro Alves  <palves@redhat.com>
4790
4791         * linux-fork.c (fork_info::clobber_regs): Delete.
4792         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4793         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4794         comment.  Adjust.
4795         (scoped_switch_fork_info::scoped_switch_fork_info)
4796         (checkpoint_command, linux_fork_context): Adjust
4797         fork_save_infrun_state calls.
4798
4799 2019-03-06  Pedro Alves  <palves@redhat.com>
4800
4801         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4802         (inf_has_multiple_threads): Return 'bool' and rewrite using
4803         inferior_info::threads().
4804
4805 2019-03-06  Pedro Alves  <palves@redhat.com>
4806
4807         * linux-fork.c: Include <list>.
4808         (fork_list): Now a std::list instance.
4809         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4810         (forks_exist_p, find_last_fork): Adjust.
4811         (new_fork): Delete.
4812         (one_fork_p): New.
4813         (add_fork): Adjust.
4814         (free_fork): Delete, folded into fork_info::~fork_info().
4815         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4816         Adjust.
4817         (init_fork_list): Delete.
4818         (linux_fork_killall, linux_fork_mourn_inferior)
4819         (linux_fork_detach, info_checkpoints_command): Adjust.
4820         (_initialize_linux_fork): No longer call init_fork_list.
4821
4822 2019-03-06  Pedro Alves  <palves@redhat.com>
4823
4824         * linux-fork.c (new_fork): New, split out of ...
4825         (add_fork): ... this.  Return void.  Move "first fork" special
4826         case from here, to ...
4827         (checkpoint_command): ... here.
4828         * linux-linux.h (add_fork): Return void.
4829
4830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4833
4834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4835             Chris January  <chris.january@arm.com>
4836             David Lecomber  <david.lecomber@arm.com>
4837
4838         * f-exp.y: New token, UNOP_INTRINSIC.
4839         (exp): New pattern using UNOP_INTRINSIC token.
4840         (f77_keywords): Add 'abs' keyword.
4841         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4842         (value_from_host_double): New function.
4843         (evaluate_subexp_f): Support UNOP_ABS.
4844
4845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4848         types.
4849
4850 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4853         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4854         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4855
4856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4857
4858         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4859
4860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4861             Chris January  <chris.january@arm.com>
4862
4863         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4864         * f-exp.y: Define 'KIND' token.
4865         (exp): New pattern for KIND expressions.
4866         (ptype): Handle types with a kind extension.
4867         (direct_abs_decl): Extend to spot kind extensions.
4868         (f77_keywords): Add 'kind' to the list.
4869         (push_kind_type): New function.
4870         (convert_to_kind_type): New function.
4871         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4872         * parse.c (operator_length_standard): Likewise.
4873         * parser-defs.h (enum type_pieces): Add tp_kind.
4874         * std-operator.def: Add UNOP_KIND.
4875
4876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * f-exp.y (f_parse): Set yydebug.
4879
4880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * f-lang.c (evaluate_subexp_f): New function.
4883         (exp_descriptor_f): New global.
4884         (f_language_defn): Use exp_descriptor_f instead of
4885         exp_descriptor_standard.
4886
4887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * f-exp.y (struct token): Add comments.
4890         (dot_ops): Remove uppercase versions and the end marker.
4891         (f77_keywords): Likewise.
4892         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4893         entries in the dot_ops array are case insensitive, and use
4894         strncasecmp to compare strings.  Also some whitespace cleanup in
4895         this area.  Similar for the f77_keywords array, except entries in
4896         this list might be case sensitive.
4897
4898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * f-exp.y (struct f77_boolean_val): Add comments.
4901         (boolean_values): Remove uppercase versions, and end marker.
4902         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4903         and use strncasecmp to achieve case insensitivity.  Additionally,
4904         perform whitespace cleanup around this code.
4905
4906 2019-03-06  Tom Tromey  <tromey@adacore.com>
4907
4908         * remote-sim.c (gdbsim_target_open): Use result of
4909         gdb_argv::release.
4910
4911 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4912         Dirk Schubert  <dirk.schubert@arm.com>
4913         Chris January  <chris.january@arm.com>
4914
4915         * eval.c (evaluate_subexp_standard): Call Fortran argument
4916         wrapping logic.
4917         * f-lang.c (struct value): A value which can be passed into a
4918         Fortran function call.
4919         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4920         where appropriate.
4921         (struct type): Value ready for a Fortran function call.
4922         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4923         is needed.
4924         * f-lang.h (fortran_argument_convert): Declaration.
4925         (fortran_preserve_arg_pointer): Declaration.
4926         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4927
4928 2019-03-05  Tom Tromey  <tromey@adacore.com>
4929
4930         * python/py-prettyprint.c (print_string_repr): Remove #if.
4931         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4932
4933 2019-03-05  Tom Tromey  <tromey@adacore.com>
4934
4935         * target.c (the_dummy_target): Move later.  Change type to
4936         "dummy_target".
4937         (initialize_targets): Don't initialize the_dummy_target.
4938
4939 2019-03-05  Tom Tromey  <tromey@adacore.com>
4940
4941         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4942         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4943
4944 2019-03-05  Tom Tromey  <tromey@adacore.com>
4945
4946         * windows-nat.c (windows_nat_target::attach)
4947         (windows_nat_target::detach): Don't call gdb_flush.
4948         * valprint.c (generic_val_print, val_print, val_print_string):
4949         Don't call gdb_flush.
4950         * utils.c (defaulted_query): Don't call gdb_flush.
4951         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4952         * target.c (target_announce_detach): Don't call gdb_flush.
4953         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4954         * remote.c (extended_remote_target::attach): Don't call
4955         gdb_flush.
4956         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4957         * printcmd.c (do_examine): Don't call gdb_flush.
4958         (info_display_command): Don't call gdb_flush.
4959         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4960         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4961         * memattr.c (info_mem_command): Don't call gdb_flush.
4962         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4963         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4964         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4965         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4966         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4967         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4968         (gnu_nat_target::detach): Don't call gdb_flush.
4969         * f-valprint.c (f_val_print): Don't call gdb_flush.
4970         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4971         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4972         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4973         gdb_flush.
4974         * c-valprint.c (c_val_print): Don't call gdb_flush.
4975         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4976
4977 2019-03-05  Tom Tromey  <tromey@adacore.com>
4978
4979         * varobj.c (update_dynamic_varobj_children): Update.
4980         (install_default_visualizer): Use reset, not release.
4981         * value.c (set_internalvar): Update.
4982         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4983         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4984         ATTRIBUTE_UNUSED_RESULT.
4985
4986 2019-03-05  Tom Tromey  <tromey@adacore.com>
4987
4988         * remote.c (class scoped_remote_fd) <release>: Add
4989         ATTRIBUTE_UNUSED_RESULT.
4990
4991 2019-03-05  Tom Tromey  <tromey@adacore.com>
4992
4993         * macroexp.c (struct macro_buffer) <release>: Add
4994         ATTRIBUTE_UNUSED_RESULT.
4995
4996 2019-03-05  Tom Tromey  <tromey@adacore.com>
4997
4998         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4999         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5000         ATTRIBUTE_UNUSED_RESULT.
5001
5002 2019-03-05  Tom Tromey  <tromey@adacore.com>
5003
5004         * common/scoped_fd.h (class scoped_fd) <release>: Add
5005         ATTRIBUTE_UNUSED_RESULT.
5006
5007 2019-03-05  Tom Tromey  <tromey@adacore.com>
5008
5009         * parser-defs.h (struct parser_state) <release>: Add
5010         ATTRIBUTE_UNUSED_RESULT.
5011
5012 2019-03-05  Tom Tromey  <tromey@adacore.com>
5013
5014         * utils.h (class gdb_argv) <release>: Add
5015         ATTRIBUTE_UNUSED_RESULT.
5016         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5017
5018 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5019
5020         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5021         for-loop range, to avoid compiler warnings.
5022
5023         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5024         avoid compiler warnings about unused variables.
5025
5026         * NEWS: Mention end of support for native debugging on MS-Windows
5027         before XP.
5028
5029         PR gdb/24292
5030         * common/netstuff.c:
5031         * gdbserver/gdbreplay.c
5032         * gdbserver/remote-utils.c:
5033         * ser-tcp.c:
5034         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5035         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5036         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5037         'getaddrinfo' and 'freeaddrinfo' were not available before
5038         Windows XP, and mingw.org's MinGW headers by default define
5039         _WIN32_WINNT to 0x500.
5040
5041 2019-03-01  Gary Benson <gbenson@redhat.com>
5042
5043         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5044
5045 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5046             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5047
5048         PR gdb/8527
5049         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5050         set_sigint_trap, clear_sigint_trap.
5051
5052 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5053
5054         * target.c (target_detach): Clear the regcache and the
5055         frame cache.
5056
5057 2019-02-27  Pedro Alves  <palves@redhat.com>
5058
5059         * utils.c (set_screen_size): When we cap the height/width sizes,
5060         tweak the corresponding command variable to show "unlimited":
5061
5062 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5063             Pedro Alves  <palves@redhat.com>
5064
5065         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5066         before calling rl_set_screen_size.
5067
5068 2019-02-27  Tom Tromey  <tromey@adacore.com>
5069
5070         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5071         define.
5072         * python/py-value.c: Remove Python 2.4 workaround.
5073         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5074         workaround.
5075         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5076         Python 2.4 workaround.
5077         * python/python-internal.h: Remove Python 2.4 comment.
5078         (Py_ssize_t): Don't define.
5079         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5080         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5081         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5082         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5083         * python/python.c (do_start_initialization): Remove Python 2.4
5084         workaround.
5085         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5086         (print_children): Remove Python 2.4 workaround.
5087         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5088         workaround.
5089         (CHARBUFFERPROC_NAME): Remove.
5090         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5091         Python 2.4 workaround.
5092
5093 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5094
5095         * NEWS: Note minimum Python version.
5096
5097 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5098
5099         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5100         code from these functions.  Remove corresponding ifdefs.  Use
5101         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5102         Remove gotos and target of gotos.
5103         (infpy_search_memory): Likewise.
5104
5105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5106
5107         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5108         (hppa_gdbarch_init): Don't register deleted functions with
5109         gdbarch.
5110
5111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5114         (h8300_unwind_sp): Delete.
5115         (h8300_dummy_id): Delete.
5116         (h8300_gdbarch_init): Don't register deleted functions with
5117         gdbarch.
5118
5119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5122         (ft32_unwind_pc): Delete.
5123         (ft32_unwind_sp): Delete.
5124         (ft32_gdbarch_init): Don't register deleted functions with
5125         gdbarch.
5126
5127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5130         (frv_unwind_pc): Delete.
5131         (frv_unwind_sp): Delete.
5132         (frv_gdbarch_init): Don't register deleted functions with
5133         gdbarch.
5134
5135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5138         (riscv_unwind_pc): Delete.
5139         (riscv_unwind_sp): Delete.
5140         (riscv_gdbarch_init): Don't register deleted functions with
5141         gdbarch.
5142
5143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5146         (csky_unwind_pc): Delete.
5147         (csky_unwind_sp): Delete.
5148         (csky_gdbarch_init): Don't register deleted functions with
5149         gdbarch.
5150
5151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5152
5153         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5154         (cris_unwind_pc): Delete.
5155         (cris_unwind_sp): Delete.
5156         (cris_gdbarch_init): Don't register deleted functions with
5157         gdbarch.
5158
5159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5162         (bfin_unwind_pc): Delete.
5163         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5164
5165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5168         (arm_unwind_pc): Delete.
5169         (arm_unwind_sp): Delete.
5170         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5171
5172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5175         (arc_unwind_pc): Delete.
5176         (arc_unwind_sp): Delete.
5177         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5178
5179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5182         (alpha_unwind_pc): Delete.
5183         (alpha_gdbarch_init): Don't register deleted functions with
5184         gdbarch.
5185
5186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5187
5188         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5189         (aarch64_unwind_pc): Delete.
5190         (aarch64_unwind_sp): Delete.
5191         (aarch64_gdbarch_init): Don't register deleted functions with
5192         gdbarch.
5193
5194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5195
5196         * gdbtypes.c (type_align): Don't consider static members when
5197         computing structure alignment.
5198
5199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5202         return 0 for other types.
5203         * arch-utils.c (default_type_align): Always return 0.
5204         * gdbarch.h: Regenerate.
5205         * gdbarch.sh (type_align): Extend comment.
5206         * gdbtypes.c (type_align): Add additional comments, always call
5207         gdbarch_type_align before applying the default rules.
5208         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5209         generic code will then apply a suitable default.
5210         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5211         types, return 0 for other types.
5212
5213 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5214
5215         * NEWS: Create a new section for the next release branch.
5216         Rename the section of the current branch, now that it has
5217         been cut.
5218
5219 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5220
5221         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5222         * version.in: Bump version to 8.3.50.DATE-git.
5223
5224 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5225
5226         * aix-thread.c (ptid_cmp): Remove unused variable.
5227         (get_signaled_thread): Likewise.
5228         (store_regs_user_thread): Likewise.
5229         (store_regs_kernel_thread): Likewise.
5230         (fetch_regs_kernel_thread): Remove shadowed variable.
5231
5232 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * features/riscv/32bit-cpu.xml: Add register numbers.
5235         * features/riscv/32bit-fpu.c: Regenerate.
5236         * features/riscv/32bit-fpu.xml: Add register numbers.
5237         * features/riscv/64bit-cpu.xml: Add register numbers.
5238         * features/riscv/64bit-fpu.c: Regenerate.
5239         * features/riscv/64bit-fpu.xml: Add register numbers.
5240
5241 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5242
5243         * NEWS: Mention two argument form of gdb.Value constructor.
5244         * python/py-value.c (convert_buffer_and_type_to_value): New
5245         function.
5246         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5247         Add support for handling an optional second argument.  Call
5248         convert_buffer_and_type_to_value as appropriate.
5249         * python/python-internal.h (Py_buffer_deleter): New struct.
5250         (Py_buffer_up): New typedef.
5251
5252 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5253
5254         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5255         instead of releasing ownership.
5256
5257 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5258
5259         * dwarf2read.c (open_and_init_dwp_file): Call
5260         elf_numsections instead of bfd_count_sections to initialize
5261         dwp_file->num_sections.
5262
5263 2019-02-25  Tom Tromey  <tromey@adacore.com>
5264
5265         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5266
5267 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5268
5269         * gcore.in: Add '--readnever' option when invoking GDB.
5270
5271 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5272
5273         * MAINTAINERS: Update my email address.
5274
5275 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5276
5277         * build-id.c (build_id_to_debug_bfd_1): New function.
5278         (build_id_to_debug_bfd): Look for separate debug file in
5279         sysroot.
5280
5281 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5282
5283         * gdbarch.sh: Update the copyright year range that is placed into
5284         generated files.
5285
5286 2019-02-22  Keith Seitz  <keiths@redhat.com>
5287
5288         PR symtab/23853
5289         * linespec.c (create_sals_line_offset): Search for the default
5290         symtab's filename instead of its fullname.
5291
5292 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * NEWS: Update style defaults.
5295
5296 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5297
5298         * main.c (captured_main_1): Disable styling in batch mode.
5299
5300 2019-02-20  Tom Tromey  <tom@tromey.com>
5301
5302         * symtab.c (symtab_symbol_info): Fix typos.
5303
5304 2019-02-20  Tom Tromey  <tromey@adacore.com>
5305
5306         * findcmd.c (_initialize_mem_search): Use upper case for
5307         metasyntactic variables.
5308
5309 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5312         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5313
5314 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5315
5316         * top.h (source_file_name): Change to std::string.
5317         * top.c (source_file_name): Likewise.
5318         (command_line_input): Adjust.
5319         * cli/cli-script.c (script_from_file): Adjust.
5320
5321 2019-02-19  Tom Tromey  <tromey@adacore.com>
5322
5323         * ravenscar-thread.c
5324         (ravenscar_thread_target::update_thread_list): Don't call
5325         ada_build_task_list.
5326         * ada-lang.h (ada_build_task_list): Don't declare.
5327         * ada-tasks.c (struct ada_tasks_inferior_data)
5328         <task_list_valid_p>: Now bool.
5329         (read_known_tasks, ada_task_list_changed)
5330         (ada_tasks_invalidate_inferior_data): Update.
5331         (read_known_tasks_array): Return bool.
5332         (read_known_tasks_list): Likewise.
5333         (read_known_tasks): Return void.
5334         (ada_build_task_list): Now static.
5335
5336 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5339         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5340
5341 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5342
5343         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5344         variant for ada_tasks_pspace_data_handle and
5345         ada_tasks_inferior_data_handle.
5346         (ada_tasks_pspace_data_cleanup): New function.
5347         (ada_tasks_inferior_data_cleanup): New function.
5348
5349 2019-02-17  Tom Tromey  <tom@tromey.com>
5350
5351         * macrotab.h (macro_source_fullname): Return a std::string.
5352         * macrotab.c (macro_include, check_for_redefinition)
5353         (macro_undef, macro_lookup_definition, foreach_macro)
5354         (foreach_macro_in_scope): Update.
5355         (macro_source_fullname): Return a std::string.
5356         * macrocmd.c (show_pp_source_pos): Update.
5357
5358 2019-02-17  Tom Tromey  <tom@tromey.com>
5359
5360         * macrocmd.c (show_pp_source_pos): Style the file names.
5361
5362 2019-02-17  Tom Tromey  <tom@tromey.com>
5363
5364         PR tui/24197:
5365         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5366
5367 2019-02-17  Tom Tromey  <tom@tromey.com>
5368
5369         * ada-lang.c (user_select_syms): Use filtered printing.
5370         * utils.c (wrap_style): New global.
5371         (desired_style): Remove.
5372         (emit_style_escape): Add stream parameter.
5373         (set_output_style, reset_terminal_style, prompt_for_continue):
5374         Update.
5375         (flush_wrap_buffer): Only flush gdb_stdout.
5376         (wrap_here): Set wrap_style.
5377         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5378         treat escape sequences as a character.  Change when wrap buffer is
5379         flushed.
5380         (fputs_styled): Do not set the output style when the default is
5381         requested.
5382         * ui-style.h (struct ui_file_style) <is_default>: New method.
5383         * source.c (print_source_lines_base): Emit escape sequences in one
5384         piece.
5385
5386 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5387
5388         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5389         integers and enumeration types.
5390
5391 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5392
5393         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5394         instead of lookup_symbol_in_language
5395         (do_exact_match): New function.
5396         (ada_get_symbol_name_matcher): Return do_exact_match when
5397         doing a verbatim match.
5398
5399 2019-02-15  Tom Tromey  <tromey@adacore.com>
5400
5401         * ravenscar-thread.c (ravenscar_thread_target::resume)
5402         (ravenscar_thread_target::wait): Special case wildcard requests.
5403
5404 2019-02-15  Tom Tromey  <tromey@adacore.com>
5405
5406         * ravenscar-thread.c (base_ptid): Remove.
5407         (struct ravenscar_thread_target) <close>: New method.
5408         <m_base_ptid>: New member.
5409         <update_inferior_ptid, active_task, task_is_currently_active,
5410         runtime_initialized>: Declare methods.
5411         <ravenscar_thread_target>: Add constructor.
5412         (ravenscar_thread_target::task_is_currently_active)
5413         (ravenscar_thread_target::update_inferior_ptid)
5414         (ravenscar_runtime_initialized): Rename.  Now methods.
5415         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5416         (ravenscar_thread_target::update_thread_list): Update.
5417         (ravenscar_thread_target::active_task): Now method.
5418         (ravenscar_thread_target::store_registers)
5419         (ravenscar_thread_target::prepare_to_store)
5420         (ravenscar_thread_target::prepare_to_store)
5421         (ravenscar_thread_target::mourn_inferior): Update.
5422         (ravenscar_inferior_created): Use "new" to create target.
5423         (ravenscar_thread_target::get_ada_task_ptid): Update.
5424         (_initialize_ravenscar): Don't initialize base_ptid.
5425         (ravenscar_ops): Remove global.
5426
5427 2019-02-15  Tom Tromey  <tromey@adacore.com>
5428
5429         * target.h (push_target): Declare new overload.
5430         * target.c (push_target): New overload, taking an rvalue reference.
5431         * remote.c (remote_target::open_1): Use push_target overload.
5432         * corelow.c (core_target_open): Use push_target overload.
5433
5434 2019-02-15  Tom Tromey  <tromey@adacore.com>
5435
5436         * ravenscar-thread.c (is_ravenscar_task)
5437         (ravenscar_task_is_currently_active): Return bool.
5438         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5439         (_initialize_ravenscar): Remove "(void)".
5440         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5441         Return bool.
5442
5443 2019-02-15  Tom Tromey  <tromey@adacore.com>
5444
5445         * ravenscar-thread.c (ravenscar_runtime_initializer)
5446         (has_ravenscar_runtime, get_running_thread_id)
5447         (ravenscar_thread_target::resume): Fix indentation.
5448
5449 2019-02-15  Tom Tromey  <tromey@adacore.com>
5450
5451         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5452         from ravenscar_arch_ops.
5453         (sparc_ravenscar_ops::fetch_registers)
5454         (sparc_ravenscar_ops::store_registers): Now methods.
5455         (sparc_ravenscar_prepare_to_store): Remove.
5456         (sparc_ravenscar_ops): Redefine.
5457         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5458         methods and destructor.  Remove members.
5459         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5460         (ravenscar_thread_target::store_registers)
5461         (ravenscar_thread_target::prepare_to_store): Update.
5462         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5463         Remove.
5464         (struct ppc_ravenscar_powerpc_ops): Derive from
5465         ravenscar_arch_ops.
5466         (ppc_ravenscar_powerpc_ops::fetch_registers)
5467         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5468         (ppc_ravenscar_powerpc_ops): Redefine.
5469         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5470         (ppc_ravenscar_e500_ops::fetch_registers)
5471         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5472         (ppc_ravenscar_e500_ops): Redefine.
5473         * aarch64-ravenscar-thread.c
5474         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5475         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5476         (aarch64_ravenscar_fetch_registers)
5477         (aarch64_ravenscar_store_registers): Now methods.
5478         (aarch64_ravenscar_ops): Redefine.
5479
5480 2019-02-15  Tom Tromey  <tromey@adacore.com>
5481
5482         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5483         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5484         (ravenscar_thread_target::stopped_by_watchpoint)
5485         (ravenscar_thread_target::stopped_data_address)
5486         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5487
5488 2019-02-15  Tom Tromey  <tromey@adacore.com>
5489
5490         * ravenscar-thread.c: Fix some typos.
5491
5492 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5493             Tom Tromey  <tromey@adacore.com>
5494
5495         * ada-lang.c (ada_exception_sal): Change addr_string to a
5496         std::string.
5497         (create_ada_exception_catchpoint): Update.
5498
5499 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5500             Tom Tromey  <tromey@adacore.com>
5501
5502         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5503         (bp_location_ops): Remove.
5504         (base_breakpoint_allocate_location): Update.
5505         (free_bp_location): Update.
5506         * ada-lang.c (class ada_catchpoint_location)
5507         <ada_catchpoint_location>: Remove ops parameter.
5508         (ada_catchpoint_location_dtor): Remove.
5509         (ada_catchpoint_location_ops): Remove.
5510         (allocate_location_exception): Update.
5511         * breakpoint.h (struct bp_location_ops): Remove.
5512         (class bp_location) <bp_location>: Remove bp_location_ops
5513         parameter.
5514         <~bp_location>: Add destructor.
5515         <ops>: Remove.
5516
5517 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5518             Pedro Alves  <palves@redhat.com>
5519
5520         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5521         'PATH_MAX'.
5522
5523 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5524             Samuel Thibault  <samuel.thibault@gnu.org>
5525             Thomas Schwinge  <thomas@codesourcery.com>
5526
5527         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5528         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5529
5530 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5531
5532         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5533         (check_empty): Use "const char *".
5534
5535         * gnu-nat.c (gnu_nat_target::detach): Instead of
5536         'detach_inferior (pid)' call
5537         'detach_inferior (find_inferior_pid (pid))'.
5538
5539         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5540         'nat/fork-inferior.o'.
5541         * gnu-nat.c: #include "nat/fork-inferior.h".
5542
5543         * gnu-nat.c (gnu_nat_target::detach): Instead of
5544         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5545         * gnu-nat.h: #include "inf-child.h".
5546         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5547         'i386_gnu_nat_target::fetch_registers'.
5548         (gnu_store_registers): Rename/move to
5549         'i386_gnu_nat_target::store_registers'.
5550
5551         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5552         * gnu-nat.h (mach_thread_info): New function.
5553         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5554
5555         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5556
5557 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5558
5559         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5560
5561 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5562
5563         * windows-nat.c (windows_add_thread): Add new parameter
5564         "main_thread_p" with default value set to false.  Update
5565         function documentation as well as all callers.
5566         (windows_delete_thread): Likewise.
5567         (fake_create_process): Update call to windows_add_thread.
5568         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5569         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5570         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5571         call to windows_delete_thread.
5572
5573 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5574
5575         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5576
5577 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5578
5579         * symfile.c (find_separate_debug_file): Use canonical path of
5580         sysroot with child_path instead of gdb_sysroot if it is valid.
5581
5582 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5583
5584         * symfile.c (find_separate_debug_file): Use child_path to
5585         determine if an object file is under a sysroot.
5586
5587 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5588
5589         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5590         unittests/child-path-selftests.c.
5591         * common/pathstuff.c (child_path): New function.
5592         * common/pathstuff.h (child_path): New prototype.
5593         * unittests/child-path-selftests.c: New file.
5594
5595 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5596
5597         * symfile.c (find_separate_debug_file): Look for separate debug
5598         files in debug directories under the sysroot.
5599
5600 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5601
5602         * symtab.h (struct minimal_symbol data_p): New const method.
5603         (struct minimal_symbol text_p): Likewise.
5604         * symtab.c (output_source_filename): Use file name style
5605         to print file name.
5606         (print_symbol_info): Likewise.
5607         (print_msymbol_info): Use address style to print addresses.
5608         Use function name style to print executable text symbols.
5609         (expand_symtab_containing_pc): Use data_p.
5610         (find_pc_sect_compunit_symtab): Likewise.
5611
5612 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5613
5614         * breakpoint.c (describe_other_breakpoints): Use address style
5615         to print addresses.
5616         (say_where): Likewise.
5617
5618 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5619
5620         * ada-typeprint.c (print_func_type): Print function name
5621         style to print function name.
5622         * c-typeprint.c (c_print_type_1): Likewise.
5623
5624 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5625
5626         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5627         for execve.
5628
5629 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5630
5631         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5632         type_stack.
5633
5634 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5635
5636         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5637         TYPE_CODE_REF types.
5638
5639 2019-02-08  Jim Wilson  <jimw@sifive.com>
5640
5641         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5642         (riscv_linux_fregset): New.
5643         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5644
5645 2019-02-07  Tom Tromey  <tom@tromey.com>
5646
5647         * thread.c (thread_cancel_execution_command): Update.
5648         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5649         methods.
5650         (struct thread_fsm_ops): Remove.
5651         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5652         (thread_fsm_should_stop, thread_fsm_return_value)
5653         (thread_fsm_set_finished, thread_fsm_finished_p)
5654         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5655         Don't declare.
5656         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5657         * infrun.c (clear_proceed_status_thread)
5658         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5659         (print_stop_event): Update.
5660         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5661         Add constructor.
5662         (step_command_fsm_ops): Remove.
5663         (new_step_command_fsm): Remove.
5664         (step_1): Update.
5665         (step_command_fsm::should_stop): Rename from
5666         step_command_fsm_should_stop.
5667         (step_command_fsm::clean_up): Rename from
5668         step_command_fsm_clean_up.
5669         (step_command_fsm::do_async_reply_reason): Rename from
5670         step_command_fsm_async_reply_reason.
5671         (struct until_next_fsm): Inherit from thread_fsm.  Add
5672         constructor.
5673         (until_next_fsm_ops): Remove.
5674         (new_until_next_fsm): Remove.
5675         (until_next_fsm::should_stop): Rename from
5676         until_next_fsm_should_stop.
5677         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5678         (until_next_fsm::do_async_reply_reason): Rename from
5679         until_next_fsm_async_reply_reason.
5680         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5681         constructor.  Change type of breakpoint.
5682         (finish_command_fsm_ops): Remove.
5683         (new_finish_command_fsm): Remove.
5684         (finish_command_fsm::should_stop): Rename from
5685         finish_command_fsm_should_stop.
5686         (finish_command_fsm::clean_up): Rename from
5687         finish_command_fsm_clean_up.
5688         (finish_command_fsm::return_value): Rename from
5689         finish_command_fsm_return_value.
5690         (finish_command_fsm::do_async_reply_reason): Rename from
5691         finish_command_fsm_async_reply_reason.
5692         (finish_command): Update.
5693         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5694         Add constructor.
5695         (call_thread_fsm_ops): Remove.
5696         (call_thread_fsm::call_thread_fsm): Rename from
5697         new_call_thread_fsm.
5698         (call_thread_fsm::should_stop): Rename from
5699         call_thread_fsm_should_stop.
5700         (call_thread_fsm::should_notify_stop): Rename from
5701         call_thread_fsm_should_notify_stop.
5702         (run_inferior_call, call_function_by_hand_dummy): Update.
5703         * cli/cli-interp.c (should_print_stop_to_console): Update.
5704         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5705         Add constructor.  Change type of location_breakpoint,
5706         caller_breakpoint.
5707         (until_break_fsm_ops): Remove.
5708         (new_until_break_fsm): Remove.
5709         (until_break_fsm::should_stop): Rename from
5710         until_break_fsm_should_stop.
5711         (until_break_fsm::clean_up): Rename from
5712         until_break_fsm_clean_up.
5713         (until_break_fsm::do_async_reply_reason): Rename from
5714         until_break_fsm_async_reply_reason.
5715         (until_break_command): Update.
5716         * thread-fsm.c: Remove.
5717         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5718
5719 2019-02-07  Tom Tromey  <tom@tromey.com>
5720
5721         * yy-remap.h: Add include guard.
5722         * xtensa-tdep.h: Add include guard.
5723         * xcoffread.h: Rename include guard.
5724         * varobj-iter.h: Add include guard.
5725         * tui/tui.h: Rename include guard.
5726         * tui/tui-winsource.h: Rename include guard.
5727         * tui/tui-wingeneral.h: Rename include guard.
5728         * tui/tui-windata.h: Rename include guard.
5729         * tui/tui-win.h: Rename include guard.
5730         * tui/tui-stack.h: Rename include guard.
5731         * tui/tui-source.h: Rename include guard.
5732         * tui/tui-regs.h: Rename include guard.
5733         * tui/tui-out.h: Rename include guard.
5734         * tui/tui-layout.h: Rename include guard.
5735         * tui/tui-io.h: Rename include guard.
5736         * tui/tui-hooks.h: Rename include guard.
5737         * tui/tui-file.h: Rename include guard.
5738         * tui/tui-disasm.h: Rename include guard.
5739         * tui/tui-data.h: Rename include guard.
5740         * tui/tui-command.h: Rename include guard.
5741         * tic6x-tdep.h: Add include guard.
5742         * target/waitstatus.h: Rename include guard.
5743         * target/wait.h: Rename include guard.
5744         * target/target.h: Rename include guard.
5745         * target/resume.h: Rename include guard.
5746         * target-float.h: Rename include guard.
5747         * stabsread.h: Add include guard.
5748         * rs6000-tdep.h: Add include guard.
5749         * riscv-fbsd-tdep.h: Add include guard.
5750         * regformats/regdef.h: Rename include guard.
5751         * record.h: Rename include guard.
5752         * python/python.h: Rename include guard.
5753         * python/python-internal.h: Rename include guard.
5754         * python/py-stopevent.h: Rename include guard.
5755         * python/py-ref.h: Rename include guard.
5756         * python/py-record.h: Rename include guard.
5757         * python/py-record-full.h: Rename include guard.
5758         * python/py-record-btrace.h: Rename include guard.
5759         * python/py-instruction.h: Rename include guard.
5760         * python/py-events.h: Rename include guard.
5761         * python/py-event.h: Rename include guard.
5762         * procfs.h: Add include guard.
5763         * proc-utils.h: Add include guard.
5764         * p-lang.h: Add include guard.
5765         * or1k-tdep.h: Rename include guard.
5766         * observable.h: Rename include guard.
5767         * nto-tdep.h: Rename include guard.
5768         * nat/x86-linux.h: Rename include guard.
5769         * nat/x86-linux-dregs.h: Rename include guard.
5770         * nat/x86-gcc-cpuid.h: Add include guard.
5771         * nat/x86-dregs.h: Rename include guard.
5772         * nat/x86-cpuid.h: Rename include guard.
5773         * nat/ppc-linux.h: Rename include guard.
5774         * nat/mips-linux-watch.h: Rename include guard.
5775         * nat/linux-waitpid.h: Rename include guard.
5776         * nat/linux-ptrace.h: Rename include guard.
5777         * nat/linux-procfs.h: Rename include guard.
5778         * nat/linux-osdata.h: Rename include guard.
5779         * nat/linux-nat.h: Rename include guard.
5780         * nat/linux-namespaces.h: Rename include guard.
5781         * nat/linux-btrace.h: Rename include guard.
5782         * nat/glibc_thread_db.h: Rename include guard.
5783         * nat/gdb_thread_db.h: Rename include guard.
5784         * nat/gdb_ptrace.h: Rename include guard.
5785         * nat/fork-inferior.h: Rename include guard.
5786         * nat/amd64-linux-siginfo.h: Rename include guard.
5787         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5788         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5789         * nat/aarch64-linux.h: Rename include guard.
5790         * nat/aarch64-linux-hw-point.h: Rename include guard.
5791         * mn10300-tdep.h: Add include guard.
5792         * mips-linux-tdep.h: Add include guard.
5793         * mi/mi-parse.h: Rename include guard.
5794         * mi/mi-out.h: Rename include guard.
5795         * mi/mi-main.h: Rename include guard.
5796         * mi/mi-interp.h: Rename include guard.
5797         * mi/mi-getopt.h: Rename include guard.
5798         * mi/mi-console.h: Rename include guard.
5799         * mi/mi-common.h: Rename include guard.
5800         * mi/mi-cmds.h: Rename include guard.
5801         * mi/mi-cmd-break.h: Rename include guard.
5802         * m2-lang.h: Add include guard.
5803         * location.h: Rename include guard.
5804         * linux-record.h: Rename include guard.
5805         * linux-nat.h: Add include guard.
5806         * linux-fork.h: Add include guard.
5807         * i386-darwin-tdep.h: Rename include guard.
5808         * hppa-linux-offsets.h: Add include guard.
5809         * guile/guile.h: Rename include guard.
5810         * guile/guile-internal.h: Rename include guard.
5811         * gnu-nat.h: Rename include guard.
5812         * gdb-stabs.h: Rename include guard.
5813         * frv-tdep.h: Add include guard.
5814         * f-lang.h: Add include guard.
5815         * event-loop.h: Add include guard.
5816         * darwin-nat.h: Rename include guard.
5817         * cp-abi.h: Rename include guard.
5818         * config/sparc/nm-sol2.h: Rename include guard.
5819         * config/nm-nto.h: Rename include guard.
5820         * config/nm-linux.h: Add include guard.
5821         * config/i386/nm-i386gnu.h: Rename include guard.
5822         * config/djgpp/nl_types.h: Rename include guard.
5823         * config/djgpp/langinfo.h: Rename include guard.
5824         * compile/gcc-cp-plugin.h: Add include guard.
5825         * compile/gcc-c-plugin.h: Add include guard.
5826         * compile/compile.h: Rename include guard.
5827         * compile/compile-object-run.h: Rename include guard.
5828         * compile/compile-object-load.h: Rename include guard.
5829         * compile/compile-internal.h: Rename include guard.
5830         * compile/compile-cplus.h: Rename include guard.
5831         * compile/compile-c.h: Rename include guard.
5832         * common/xml-utils.h: Rename include guard.
5833         * common/x86-xstate.h: Rename include guard.
5834         * common/version.h: Rename include guard.
5835         * common/vec.h: Rename include guard.
5836         * common/tdesc.h: Rename include guard.
5837         * common/selftest.h: Rename include guard.
5838         * common/scoped_restore.h: Rename include guard.
5839         * common/scoped_mmap.h: Rename include guard.
5840         * common/scoped_fd.h: Rename include guard.
5841         * common/safe-iterator.h: Rename include guard.
5842         * common/run-time-clock.h: Rename include guard.
5843         * common/refcounted-object.h: Rename include guard.
5844         * common/queue.h: Rename include guard.
5845         * common/ptid.h: Rename include guard.
5846         * common/print-utils.h: Rename include guard.
5847         * common/preprocessor.h: Rename include guard.
5848         * common/pathstuff.h: Rename include guard.
5849         * common/observable.h: Rename include guard.
5850         * common/netstuff.h: Rename include guard.
5851         * common/job-control.h: Rename include guard.
5852         * common/host-defs.h: Rename include guard.
5853         * common/gdb_wait.h: Rename include guard.
5854         * common/gdb_vecs.h: Rename include guard.
5855         * common/gdb_unlinker.h: Rename include guard.
5856         * common/gdb_unique_ptr.h: Rename include guard.
5857         * common/gdb_tilde_expand.h: Rename include guard.
5858         * common/gdb_sys_time.h: Rename include guard.
5859         * common/gdb_string_view.h: Rename include guard.
5860         * common/gdb_splay_tree.h: Rename include guard.
5861         * common/gdb_setjmp.h: Rename include guard.
5862         * common/gdb_ref_ptr.h: Rename include guard.
5863         * common/gdb_optional.h: Rename include guard.
5864         * common/gdb_locale.h: Rename include guard.
5865         * common/gdb_assert.h: Rename include guard.
5866         * common/filtered-iterator.h: Rename include guard.
5867         * common/filestuff.h: Rename include guard.
5868         * common/fileio.h: Rename include guard.
5869         * common/environ.h: Rename include guard.
5870         * common/common-utils.h: Rename include guard.
5871         * common/common-types.h: Rename include guard.
5872         * common/common-regcache.h: Rename include guard.
5873         * common/common-inferior.h: Rename include guard.
5874         * common/common-gdbthread.h: Rename include guard.
5875         * common/common-exceptions.h: Rename include guard.
5876         * common/common-defs.h: Rename include guard.
5877         * common/common-debug.h: Rename include guard.
5878         * common/cleanups.h: Rename include guard.
5879         * common/buffer.h: Rename include guard.
5880         * common/btrace-common.h: Rename include guard.
5881         * common/break-common.h: Rename include guard.
5882         * cli/cli-utils.h: Rename include guard.
5883         * cli/cli-style.h: Rename include guard.
5884         * cli/cli-setshow.h: Rename include guard.
5885         * cli/cli-script.h: Rename include guard.
5886         * cli/cli-interp.h: Rename include guard.
5887         * cli/cli-decode.h: Rename include guard.
5888         * cli/cli-cmds.h: Rename include guard.
5889         * charset-list.h: Add include guard.
5890         * buildsym-legacy.h: Rename include guard.
5891         * bfin-tdep.h: Add include guard.
5892         * ax.h: Rename include guard.
5893         * arm-linux-tdep.h: Add include guard.
5894         * arm-fbsd-tdep.h: Add include guard.
5895         * arch/xtensa.h: Rename include guard.
5896         * arch/tic6x.h: Add include guard.
5897         * arch/i386.h: Add include guard.
5898         * arch/arm.h: Rename include guard.
5899         * arch/arm-linux.h: Rename include guard.
5900         * arch/arm-get-next-pcs.h: Rename include guard.
5901         * arch/amd64.h: Add include guard.
5902         * arch/aarch64-insn.h: Rename include guard.
5903         * arch-utils.h: Rename include guard.
5904         * annotate.h: Add include guard.
5905         * amd64-darwin-tdep.h: Rename include guard.
5906         * aarch64-linux-tdep.h: Add include guard.
5907         * aarch64-fbsd-tdep.h: Add include guard.
5908         * aarch32-linux-nat.h: Add include guard.
5909
5910 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5911
5912         * macrotab.c (macro_define_internal): New function that
5913         factorizes macro_define_object_internal and macro_define_function
5914         code.
5915         (macro_define_object_internal): Use macro_define_internal.
5916         (macro_define_function): Likewise.
5917
5918 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5919
5920         * macrocmd.c (extract_identifier): Return
5921         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5922         callers.
5923
5924 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5925
5926         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5927
5928 2019-02-05  Tom Tromey  <tom@tromey.com>
5929
5930         * target.c (target_stack::unpush): Move assertion earlier.
5931
5932 2019-01-30  Tom Tromey  <tom@tromey.com>
5933
5934         PR python/23615:
5935         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5936         (gdbpy_parse_and_eval): Likewise.
5937         * python/python-internal.h (gdbpy_allow_threads): New class.
5938
5939 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5940
5941         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5942         (aarch64_fbsd_fpregmap): Move earlier.
5943         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5944         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5945         instead of individual calls to trad_frame_set_reg_addr.
5946         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5947         earlier.
5948         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5949         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5950         instead of individual calls to trad_frame_set_reg_addr.
5951
5952 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5953
5954         * CONTRIBUTE: Replace contribution list with wiki link.
5955
5956 2019-01-25  Tom Tromey  <tom@tromey.com>
5957
5958         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5959
5960 2019-01-25  Tom Tromey  <tom@tromey.com>
5961
5962         * xtensa-linux-nat.c: Fix common/ includes.
5963         * xml-support.h: Fix common/ includes.
5964         * xml-support.c: Fix common/ includes.
5965         * x86-linux-nat.c: Fix common/ includes.
5966         * windows-nat.c: Fix common/ includes.
5967         * varobj.h: Fix common/ includes.
5968         * varobj.c: Fix common/ includes.
5969         * value.c: Fix common/ includes.
5970         * valops.c: Fix common/ includes.
5971         * utils.c: Fix common/ includes.
5972         * unittests/xml-utils-selftests.c: Fix common/ includes.
5973         * unittests/utils-selftests.c: Fix common/ includes.
5974         * unittests/unpack-selftests.c: Fix common/ includes.
5975         * unittests/tracepoint-selftests.c: Fix common/ includes.
5976         * unittests/style-selftests.c: Fix common/ includes.
5977         * unittests/string_view-selftests.c: Fix common/ includes.
5978         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5979         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5980         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5981         * unittests/rsp-low-selftests.c: Fix common/ includes.
5982         * unittests/parse-connection-spec-selftests.c: Fix common/
5983         includes.
5984         * unittests/optional-selftests.c: Fix common/ includes.
5985         * unittests/offset-type-selftests.c: Fix common/ includes.
5986         * unittests/observable-selftests.c: Fix common/ includes.
5987         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5988         * unittests/memrange-selftests.c: Fix common/ includes.
5989         * unittests/memory-map-selftests.c: Fix common/ includes.
5990         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5991         * unittests/function-view-selftests.c: Fix common/ includes.
5992         * unittests/environ-selftests.c: Fix common/ includes.
5993         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5994         * unittests/common-utils-selftests.c: Fix common/ includes.
5995         * unittests/cli-utils-selftests.c: Fix common/ includes.
5996         * unittests/array-view-selftests.c: Fix common/ includes.
5997         * ui-file.c: Fix common/ includes.
5998         * tui/tui-io.c: Fix common/ includes.
5999         * tracepoint.h: Fix common/ includes.
6000         * tracepoint.c: Fix common/ includes.
6001         * tracefile-tfile.c: Fix common/ includes.
6002         * top.h: Fix common/ includes.
6003         * top.c: Fix common/ includes.
6004         * thread.c: Fix common/ includes.
6005         * target/waitstatus.h: Fix common/ includes.
6006         * target/waitstatus.c: Fix common/ includes.
6007         * target.h: Fix common/ includes.
6008         * target.c: Fix common/ includes.
6009         * target-memory.c: Fix common/ includes.
6010         * target-descriptions.c: Fix common/ includes.
6011         * symtab.h: Fix common/ includes.
6012         * symfile.c: Fix common/ includes.
6013         * stap-probe.c: Fix common/ includes.
6014         * spu-linux-nat.c: Fix common/ includes.
6015         * sparc-nat.c: Fix common/ includes.
6016         * source.c: Fix common/ includes.
6017         * solib.c: Fix common/ includes.
6018         * solib-target.c: Fix common/ includes.
6019         * ser-unix.c: Fix common/ includes.
6020         * ser-tcp.c: Fix common/ includes.
6021         * ser-pipe.c: Fix common/ includes.
6022         * ser-base.c: Fix common/ includes.
6023         * selftest-arch.c: Fix common/ includes.
6024         * s12z-tdep.c: Fix common/ includes.
6025         * rust-exp.y: Fix common/ includes.
6026         * rs6000-aix-tdep.c: Fix common/ includes.
6027         * riscv-tdep.c: Fix common/ includes.
6028         * remote.c: Fix common/ includes.
6029         * remote-notif.h: Fix common/ includes.
6030         * remote-fileio.h: Fix common/ includes.
6031         * remote-fileio.c: Fix common/ includes.
6032         * regcache.h: Fix common/ includes.
6033         * regcache.c: Fix common/ includes.
6034         * record-btrace.c: Fix common/ includes.
6035         * python/python.c: Fix common/ includes.
6036         * python/py-type.c: Fix common/ includes.
6037         * python/py-inferior.c: Fix common/ includes.
6038         * progspace.h: Fix common/ includes.
6039         * producer.c: Fix common/ includes.
6040         * procfs.c: Fix common/ includes.
6041         * proc-api.c: Fix common/ includes.
6042         * printcmd.c: Fix common/ includes.
6043         * ppc-linux-nat.c: Fix common/ includes.
6044         * parser-defs.h: Fix common/ includes.
6045         * osdata.c: Fix common/ includes.
6046         * obsd-nat.c: Fix common/ includes.
6047         * nat/x86-linux.c: Fix common/ includes.
6048         * nat/x86-linux-dregs.c: Fix common/ includes.
6049         * nat/x86-dregs.h: Fix common/ includes.
6050         * nat/x86-dregs.c: Fix common/ includes.
6051         * nat/ppc-linux.c: Fix common/ includes.
6052         * nat/mips-linux-watch.h: Fix common/ includes.
6053         * nat/mips-linux-watch.c: Fix common/ includes.
6054         * nat/linux-waitpid.c: Fix common/ includes.
6055         * nat/linux-ptrace.h: Fix common/ includes.
6056         * nat/linux-ptrace.c: Fix common/ includes.
6057         * nat/linux-procfs.c: Fix common/ includes.
6058         * nat/linux-personality.c: Fix common/ includes.
6059         * nat/linux-osdata.c: Fix common/ includes.
6060         * nat/linux-namespaces.c: Fix common/ includes.
6061         * nat/linux-btrace.h: Fix common/ includes.
6062         * nat/linux-btrace.c: Fix common/ includes.
6063         * nat/fork-inferior.c: Fix common/ includes.
6064         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6065         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6066         * nat/aarch64-linux.c: Fix common/ includes.
6067         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6068         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6069         * namespace.h: Fix common/ includes.
6070         * mips-linux-tdep.c: Fix common/ includes.
6071         * minsyms.c: Fix common/ includes.
6072         * mi/mi-parse.h: Fix common/ includes.
6073         * mi/mi-main.c: Fix common/ includes.
6074         * mi/mi-cmd-env.c: Fix common/ includes.
6075         * memrange.h: Fix common/ includes.
6076         * memattr.c: Fix common/ includes.
6077         * maint.h: Fix common/ includes.
6078         * maint.c: Fix common/ includes.
6079         * main.c: Fix common/ includes.
6080         * machoread.c: Fix common/ includes.
6081         * location.c: Fix common/ includes.
6082         * linux-thread-db.c: Fix common/ includes.
6083         * linux-nat.c: Fix common/ includes.
6084         * linux-fork.c: Fix common/ includes.
6085         * inline-frame.c: Fix common/ includes.
6086         * infrun.c: Fix common/ includes.
6087         * inflow.c: Fix common/ includes.
6088         * inferior.h: Fix common/ includes.
6089         * inferior.c: Fix common/ includes.
6090         * infcmd.c: Fix common/ includes.
6091         * inf-ptrace.c: Fix common/ includes.
6092         * inf-child.c: Fix common/ includes.
6093         * ia64-linux-nat.c: Fix common/ includes.
6094         * i387-tdep.c: Fix common/ includes.
6095         * i386-tdep.c: Fix common/ includes.
6096         * i386-linux-tdep.c: Fix common/ includes.
6097         * i386-linux-nat.c: Fix common/ includes.
6098         * i386-go32-tdep.c: Fix common/ includes.
6099         * i386-fbsd-tdep.c: Fix common/ includes.
6100         * i386-fbsd-nat.c: Fix common/ includes.
6101         * guile/scm-type.c: Fix common/ includes.
6102         * guile/guile.c: Fix common/ includes.
6103         * go32-nat.c: Fix common/ includes.
6104         * gnu-nat.c: Fix common/ includes.
6105         * gdbthread.h: Fix common/ includes.
6106         * gdbarch-selftests.c: Fix common/ includes.
6107         * gdb_usleep.c: Fix common/ includes.
6108         * gdb_select.h: Fix common/ includes.
6109         * gdb_bfd.c: Fix common/ includes.
6110         * gcore.c: Fix common/ includes.
6111         * fork-child.c: Fix common/ includes.
6112         * findvar.c: Fix common/ includes.
6113         * fbsd-nat.c: Fix common/ includes.
6114         * event-top.c: Fix common/ includes.
6115         * event-loop.c: Fix common/ includes.
6116         * dwarf2read.c: Fix common/ includes.
6117         * dwarf2loc.c: Fix common/ includes.
6118         * dwarf2-frame.c: Fix common/ includes.
6119         * dwarf-index-cache.c: Fix common/ includes.
6120         * dtrace-probe.c: Fix common/ includes.
6121         * disasm-selftests.c: Fix common/ includes.
6122         * defs.h: Fix common/ includes.
6123         * csky-tdep.c: Fix common/ includes.
6124         * cp-valprint.c: Fix common/ includes.
6125         * cp-support.h: Fix common/ includes.
6126         * cp-support.c: Fix common/ includes.
6127         * corelow.c: Fix common/ includes.
6128         * completer.h: Fix common/ includes.
6129         * completer.c: Fix common/ includes.
6130         * compile/compile.c: Fix common/ includes.
6131         * compile/compile-loc2c.c: Fix common/ includes.
6132         * compile/compile-cplus-types.c: Fix common/ includes.
6133         * compile/compile-cplus-symbols.c: Fix common/ includes.
6134         * command.h: Fix common/ includes.
6135         * cli/cli-dump.c: Fix common/ includes.
6136         * cli/cli-cmds.c: Fix common/ includes.
6137         * charset.c: Fix common/ includes.
6138         * build-id.c: Fix common/ includes.
6139         * btrace.h: Fix common/ includes.
6140         * btrace.c: Fix common/ includes.
6141         * breakpoint.h: Fix common/ includes.
6142         * breakpoint.c: Fix common/ includes.
6143         * ax.h:
6144         (enum agent_op): Fix common/ includes.
6145         * ax-general.c (struct aop_map): Fix common/ includes.
6146         * ax-gdb.c: Fix common/ includes.
6147         * auxv.c: Fix common/ includes.
6148         * auto-load.c: Fix common/ includes.
6149         * arm-tdep.c: Fix common/ includes.
6150         * arch/riscv.c: Fix common/ includes.
6151         * arch/ppc-linux-common.c: Fix common/ includes.
6152         * arch/i386.c: Fix common/ includes.
6153         * arch/arm.c: Fix common/ includes.
6154         * arch/arm-linux.c: Fix common/ includes.
6155         * arch/arm-get-next-pcs.c: Fix common/ includes.
6156         * arch/amd64.c: Fix common/ includes.
6157         * arch/aarch64.c: Fix common/ includes.
6158         * arch/aarch64-insn.c: Fix common/ includes.
6159         * arch-utils.c: Fix common/ includes.
6160         * amd64-windows-tdep.c: Fix common/ includes.
6161         * amd64-tdep.c: Fix common/ includes.
6162         * amd64-sol2-tdep.c: Fix common/ includes.
6163         * amd64-obsd-tdep.c: Fix common/ includes.
6164         * amd64-nbsd-tdep.c: Fix common/ includes.
6165         * amd64-linux-tdep.c: Fix common/ includes.
6166         * amd64-linux-nat.c: Fix common/ includes.
6167         * amd64-fbsd-tdep.c: Fix common/ includes.
6168         * amd64-fbsd-nat.c: Fix common/ includes.
6169         * amd64-dicos-tdep.c: Fix common/ includes.
6170         * amd64-darwin-tdep.c: Fix common/ includes.
6171         * agent.c: Fix common/ includes.
6172         * ada-lang.h: Fix common/ includes.
6173         * ada-lang.c: Fix common/ includes.
6174         * aarch64-tdep.c: Fix common/ includes.
6175
6176 2019-01-25  Tom Tromey  <tom@tromey.com>
6177
6178         * common/create-version.sh: Use common/version.h.
6179
6180 2019-01-24  Pedro Alves  <palves@redhat.com>
6181
6182         * infrun.c (signal_stop, signal_print, signal_program)
6183         (signal_catch, signal_pass): Now arrays instead of pointers.
6184         (update_signals_program_target, do_target_resume)
6185         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6186         * linux-nat.c (linux_nat_target::pass_signals)
6187         (linux_nat_target::create_inferior, linux_nat_target::attach):
6188         Adjust.
6189         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6190         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6191         * procfs.c (procfs_target::pass_signals): Adjust.
6192         * record-full.c (record_full_target::resume): Adjust.
6193         * remote.c (remote_target::pass_signals)
6194         (remote_target::program_signals): Adjust.
6195         * target-debug.h (target_debug_print_signals): Now takes a
6196         gdb::array_view as parameter.  Adjust.
6197         * target.h (target_ops) <pass_signals, program_signals>: Replace
6198         pointer and length parameters with gdb::array_view.
6199         (target_pass_signals, target_program_signals): Likewise.
6200         * target-delegates.c: Regenerate.
6201
6202 2019-01-24  Pedro Alves  <palves@redhat.com>
6203
6204         * common/forward-scope-exit.h
6205         (forward_scope_exit::forward_scope_exit): Pass arguments to
6206         m_bind_function directly, instead of creating a std::bind and
6207         copying that.
6208
6209 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6210
6211         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6212         for static members.
6213         (pass_in_v_vfp_candidate): Likewise.
6214
6215 2019-01-23  Tom Tromey  <tom@tromey.com>
6216             Pedro Alves  <palves@redhat.com>
6217
6218         * regcache.c (class regcache_invalidator): Remove.
6219         (regcache::raw_write): Use make_scope_exit.
6220
6221 2019-01-23  Tom Tromey  <tom@tromey.com>
6222
6223         * ui-out.h (class ui_out_emit_type): Update comment.
6224
6225 2019-01-23  Tom Tromey  <tom@tromey.com>
6226
6227         * infrun.c (fetch_inferior_event): Update comment.
6228
6229 2019-01-23  Tom Tromey  <tom@tromey.com>
6230             Pedro Alves  <palves@redhat.com>
6231
6232         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6233         parameter.
6234         (fetch_inferior_event): Use SCOPE_EXIT.
6235
6236
6237 2019-01-23  Tom Tromey  <tom@tromey.com>
6238             Pedro Alves  <palves@redhat.com>
6239
6240         * infrun.c (disable_thread_events): Delete.
6241         (stop_all_threads): Use SCOPE_EXIT.
6242
6243 2019-01-23  Tom Tromey  <tom@tromey.com>
6244             Pedro Alves  <palves@redhat.com>
6245
6246         * symfile.c: Include forward-scope-exit.h.
6247         (clear_symtab_users_cleanup): Replace forward declaration with
6248         a FORWARD_SCOPE_EXIT.
6249         (syms_from_objfile_1): Use the forward_scope_exit and
6250         gdb::optional instead of cleanup_function.
6251         (reread_symbols): Use the forward_scope_exit instead of
6252         cleanup_function.
6253         (clear_symtab_users_cleanup): Remove function.
6254
6255 2019-01-23  Tom Tromey  <tom@tromey.com>
6256             Pedro Alves  <palves@redhat.com>
6257
6258         * linux-nat.c: Include scope-exit.h.
6259         (cleanup_target_stop): Remove.
6260         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6261         SCOPE_EXIT.
6262
6263 2019-01-23  Tom Tromey  <tom@tromey.com>
6264             Pedro Alves  <palves@redhat.com>
6265
6266         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6267         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6268
6269 2019-01-23  Tom Tromey  <tom@tromey.com>
6270             Andrew Burgess  <andrew.burgess@embecosm.com>
6271             Pedro Alves  <palves@redhat.com>
6272
6273         * infrun.c (fetch_inferior_event): Use scope_exit.
6274         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6275         * top.c (execute_command): Use scope_exit.
6276         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6277         * utils.c (do_bpstat_clear_actions_cleanup)
6278         (make_bpstat_clear_actions_cleanup): Remove.
6279
6280 2019-01-23  Tom Tromey  <tom@tromey.com>
6281             Pedro Alves  <palves@redhat.com>
6282
6283         * infrun.c: Include "common/scope-exit.h"
6284         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6285         (wait_for_inferior): Use SCOPE_EXIT.
6286         (fetch_inferior_event): Use scope_exit.
6287
6288 2019-01-23  Tom Tromey  <tom@tromey.com>
6289             Pedro Alves  <palves@redhat.com>
6290
6291         * breakpoint.c (create_breakpoint): Remove cleanup.
6292
6293 2019-01-23  Tom Tromey  <tom@tromey.com>
6294             Andrew Burgess  <andrew.burgess@embecosm.com>
6295             Pedro Alves  <palves@redhat.com>
6296
6297 2019-01-23  Pedro Alves  <palves@redhat.com>
6298
6299         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6300
6301 2019-01-23  Pedro Alves  <palves@redhat.com>
6302             Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * gdbthread.h: Include "common/forward-scope-exit.h".
6305         (scoped_finish_thread_state): Redefine custom class in terms of
6306         forward_scope_exit.
6307
6308 2019-01-23  Pedro Alves  <palves@redhat.com>
6309             Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * common/forward-scope-exit.h: New file.
6312
6313 2019-01-23  Pedro Alves  <palves@redhat.com>
6314             Andrew Burgess  <andrew.burgess@embecosm.com>
6315             Tom Tromey  <tom@tromey.com>
6316
6317         * common/scope-exit.h: New file.
6318
6319 2019-01-23  Pedro Alves  <palves@redhat.com>
6320
6321         * common/preprocessor.h (ESC): Rename to ...
6322         (ESC_PARENS): ... this.
6323         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6324         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6325
6326 2019-01-23  Tom Tromey  <tom@tromey.com>
6327
6328         * language.h (class scoped_switch_to_sym_language_if_auto):
6329         Initialize m_lang in both cases.
6330
6331 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6332
6333         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6334         with XCNEW.
6335
6336 2019-01-22  Tom Tromey  <tom@tromey.com>
6337
6338         * corelow.c: Do not include sys/file.h.
6339
6340 2019-01-22  Tom Tromey  <tom@tromey.com>
6341
6342         * tui/tui-wingeneral.h: Include gdb_curses.h.
6343
6344 2019-01-22  Tom Tromey  <tom@tromey.com>
6345
6346         * source-cache.h (class source_cache) <get_source_lines,
6347         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6348
6349 2019-01-22  Tom Tromey  <tom@tromey.com>
6350
6351         * remote-fileio.h (struct remote_target): Declare.
6352
6353 2019-01-22  Tom Tromey  <tom@tromey.com>
6354
6355         * python/py-arch.c: Do not include py-ref.h.
6356         * python/py-bpevent.c: Do not include py-ref.h.
6357         * python/py-cmd.c: Do not include py-ref.h.
6358         * python/py-continueevent.c: Do not include py-ref.h.
6359         * python/py-event.h: Do not include py-ref.h.
6360         * python/py-evtregistry.c: Do not include py-ref.h.
6361         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6362         * python/py-frame.c: Do not include py-ref.h.
6363         * python/py-framefilter.c: Do not include py-ref.h.
6364         * python/py-function.c: Do not include py-ref.h.
6365         * python/py-infevents.c: Do not include py-ref.h.
6366         * python/py-linetable.c: Do not include py-ref.h.
6367         * python/py-objfile.c: Do not include py-ref.h.
6368         * python/py-param.c: Do not include py-ref.h.
6369         * python/py-prettyprint.c: Do not include py-ref.h.
6370         * python/py-progspace.c: Do not include py-ref.h.
6371         * python/py-symbol.c: Do not include py-ref.h.
6372         * python/py-symtab.c: Do not include py-ref.h.
6373         * python/py-type.c: Do not include py-ref.h.
6374         * python/py-unwind.c: Do not include py-ref.h.
6375         * python/py-utils.c: Do not include py-ref.h.
6376         * python/py-value.c: Do not include py-ref.h.
6377         * python/py-varobj.c: Do not include py-ref.h.
6378         * python/py-xmethods.c: Do not include py-ref.h.
6379         * python/python.c: Do not include py-ref.h.
6380         * varobj.c: Do not include py-ref.h.
6381
6382 2019-01-22  Tom Tromey  <tom@tromey.com>
6383
6384         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6385         keyword for bcache.
6386
6387 2019-01-22  Tom Tromey  <tom@tromey.com>
6388
6389         * compile/compile-cplus-types.c: Remove a comment by #include.
6390
6391 2019-01-22  Tom Tromey  <tom@tromey.com>
6392
6393         * compile/gcc-c-plugin.h: Include compile-internal.h.
6394
6395 2019-01-22  Tom Tromey  <tom@tromey.com>
6396
6397         * stabsread.c (EXTERN): Do not define.
6398         (symnum, next_symbol_text_func, processing_gcc_compilation)
6399         (within_function, global_sym_chain, global_stabs)
6400         (previous_stab_code, this_object_header_files)
6401         (n_this_object_header_files)
6402         (n_allocated_this_object_header_files): Define.
6403         * stabsread.h (EXTERN): Never define.  Use "extern".
6404
6405 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6406
6407         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6408         history_value.
6409
6410 2019-01-21  Tom Tromey  <tom@tromey.com>
6411
6412         * ui-out.c: Fix includes.
6413         * tui/tui-source.c: Fix includes.
6414         * target.c: Fix includes.
6415         * remote.c: Fix includes.
6416         * regcache.c: Fix includes.
6417         * python/py-block.c: Fix includes.
6418         * printcmd.c: Fix includes.
6419         * or1k-tdep.c: Fix includes.
6420         * mi/mi-main.c: Fix includes.
6421         * m32r-tdep.c: Fix includes.
6422         * csky-tdep.c: Fix includes.
6423         * compile/compile-cplus-types.c: Fix includes.
6424         * cli/cli-interp.c: Fix includes.
6425
6426 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6427
6428         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6429         for padding.
6430
6431 2019-01-16  Tom Tromey  <tom@tromey.com>
6432
6433         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6434         earlier.
6435         (struct objfile) <msymbols_range>: Move from top level.
6436         <msymbols>: New method.
6437         (class objfile_msymbols): Remove.
6438         * symtab.c (default_collect_symbol_completion_matches_break_on):
6439         Update.
6440         * symmisc.c (dump_msymbols): Update.
6441         * stabsread.c (scan_file_globals): Update.
6442         * objc-lang.c (info_selectors_command, info_classes_command)
6443         (find_methods): Update.
6444         * minsyms.c (find_solib_trampoline_target): Update.
6445         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6446         * coffread.c (coff_symfile_read): Update.
6447         * ada-lang.c (ada_lookup_simple_minsym)
6448         (ada_collect_symbol_completion_matches): Update.
6449
6450 2019-01-16  Tom Tromey  <tom@tromey.com>
6451
6452         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6453         type.  Remove no-argument constructor.
6454         <iterator::operator++>: Simplify.
6455         <begin>: Update.
6456         <end>: Use minimal_symbol_count.
6457
6458 2019-01-16  Tom Tromey  <tom@tromey.com>
6459
6460         * objfiles.h (struct objfile) <psymtabs>: New method.
6461         (class objfile_psymtabs): Remove.
6462         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6463         typedef.
6464         <range>: New method.
6465         (require_partial_symbols): Change return type.
6466         * psymtab.c (require_partial_symbols)
6467         (psym_expand_symtabs_matching): Update.
6468         * mdebugread.c (parse_partial_symbols): Update.
6469         * dbxread.c (dbx_end_psymtab): Update.
6470
6471 2019-01-15  Tom Tromey  <tom@tromey.com>
6472
6473         * symtab.c (lookup_objfile_from_block)
6474         (lookup_symbol_in_objfile_symtabs)
6475         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6476         (find_line_symtab, info_sources_command)
6477         (default_collect_symbol_completion_matches_break_on)
6478         (make_source_files_completion_list): Update.
6479         * symmisc.c (print_objfile_statistics, dump_objfile)
6480         (maintenance_print_symbols, maintenance_info_symtabs)
6481         (maintenance_check_symtabs, maintenance_info_line_tables):
6482         Update.
6483         * source.c (select_source_symtab)
6484         (forget_cached_source_info_for_objfile): Update.
6485         * objfiles.h (class objfile_compunits): Remove.
6486         (struct objfile) <compunits_range>: New typedef.
6487         (compunits): New method.
6488         * objfiles.c (objfile_relocate1): Update.
6489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6490         * maint.c (count_symtabs_and_blocks): Update.
6491         * linespec.c (iterate_over_all_matching_symtabs): Update.
6492         * cp-support.c (add_symbol_overload_list_qualified): Update.
6493         * coffread.c (coff_symtab_read): Update.
6494         * ada-lang.c (add_nonlocal_symbols)
6495         (ada_collect_symbol_completion_matches)
6496         (ada_add_global_exceptions): Update.
6497
6498 2019-01-15  Tom Tromey  <tom@tromey.com>
6499
6500         * progspace.h (program_space) <objfiles_safe_range>: New
6501         typedef.
6502         <objfiles_safe>: New method.
6503         * objfiles.h (class all_objfiles_safe): Remove.
6504         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6505         * jit.c (jit_inferior_exit_hook): Update.
6506
6507 2019-01-17  Tom Tromey  <tom@tromey.com>
6508
6509         * progspace.h (program_space) <objfiles_range>: New typedef.
6510         <objfiles>: New method.
6511         <objfiles_head>: Rename from objfiles.
6512         (object_files): Update.
6513         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6514         * guile/scm-pretty-print.c
6515         (ppscm_find_pretty_printer_from_objfiles): Update.
6516         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6517         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6518         Update.
6519         * python/py-progspace.c (pspy_get_objfiles): Update.
6520         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6521         Update.
6522         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6523         (objfpy_lookup_objfile_by_build_id): Update.
6524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6525         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6526         Update.
6527         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6528         (expand_symtab_containing_pc, lookup_objfile_from_block)
6529         (lookup_static_symbol, basic_lookup_transparent_type)
6530         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6531         (find_line_symtab, info_sources_command)
6532         (default_collect_symbol_completion_matches_break_on)
6533         (make_source_files_completion_list, find_main_name): Update.
6534         * symmisc.c (print_symbol_bcache_statistics)
6535         (print_objfile_statistics, maintenance_print_symbols)
6536         (maintenance_print_msymbols, maintenance_print_objfiles)
6537         (maintenance_info_symtabs, maintenance_check_symtabs)
6538         (maintenance_expand_symtabs, maintenance_info_line_tables):
6539         Update.
6540         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6541         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6542         (map_overlay_command, unmap_overlay_command)
6543         (simple_overlay_update, expand_symtabs_matching)
6544         (map_symbol_filenames): Update.
6545         * symfile-debug.c (set_debug_symfile): Update.
6546         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6547         Update.
6548         * source.c (select_source_symtab, forget_cached_source_info):
6549         Update.
6550         * solib.c (solib_read_symbols): Update.
6551         * solib-spu.c (append_ocl_sos): Update.
6552         * psymtab.c (maintenance_print_psymbols)
6553         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6554         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6555         * printcmd.c (info_symbol_command): Update.
6556         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6557         Update.
6558         * objfiles.h (class all_objfiles): Remove.
6559         * objfiles.c (have_partial_symbols, have_full_symbols)
6560         (have_minimal_symbols, qsort_cmp, update_section_map)
6561         (shared_objfile_contains_address_p)
6562         (default_iterate_over_objfiles_in_search_order): Update.
6563         * objc-lang.c (info_selectors_command, info_classes_command)
6564         (find_methods): Update.
6565         * minsyms.c (find_solib_trampoline_target): Update.
6566         * maint.c (maintenance_info_sections)
6567         (maintenance_translate_address, count_symtabs_and_blocks):
6568         Update.
6569         * main.c (captured_main_1): Update.
6570         * linux-thread-db.c (try_thread_db_load_from_pdir)
6571         (has_libpthread): Update.
6572         * linespec.c (iterate_over_all_matching_symtabs)
6573         (search_minsyms_for_name): Update.
6574         * jit.c (jit_find_objf_with_entry_addr): Update.
6575         * hppa-tdep.c (find_unwind_entry)
6576         (hppa_lookup_stub_minimal_symbol): Update.
6577         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6578         Update.
6579         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6580         (elf_gnu_ifunc_resolve_by_got): Update.
6581         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6582         * dwarf-index-write.c (save_gdb_index_command): Update.
6583         * cp-support.c (add_symbol_overload_list_qualified): Update.
6584         * breakpoint.c (create_overlay_event_breakpoint)
6585         (create_longjmp_master_breakpoint)
6586         (create_std_terminate_master_breakpoint)
6587         (create_exception_master_breakpoint): Update.
6588         * blockframe.c (find_pc_partial_function): Update.
6589         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6590         (ada_collect_symbol_completion_matches)
6591         (ada_add_global_exceptions): Update.
6592
6593 2019-01-17  Tom Tromey  <tom@tromey.com>
6594
6595         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6596         declare VEC.
6597         (solib_target_parse_libraries): Change return type.
6598         (library_list_start_segment, library_list_start_section)
6599         (library_list_end_library, library_list_start_library); Update.
6600         (solib_target_free_library_list): Remove.
6601         (solib_target_parse_libraries): Remove cleanup.  Change return
6602         type.
6603         (solib_target_current_sos): Update.
6604
6605 2019-01-17  Tom Tromey  <tromey@bapiya>
6606
6607         * valprint.c: Replace "the the" with "the".
6608         * symtab.c: Replace "the the" with "the".
6609         * solib.c: Replace "the the" with "the".
6610         * solib-dsbt.c: Replace "the the" with "the".
6611         * linespec.c: Replace "the the" with "the".
6612         * dwarf2loc.h: Replace "the the" with "the".
6613         * amd64-windows-tdep.c: Replace "the the" with "the".
6614         * aarch64-tdep.c: Replace "the the" with "the".
6615
6616 2019-01-16  Keith Seitz  <keiths@redhat.com>
6617
6618         PR gdb/23773
6619         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6620         <builder>: Rename to ..
6621         <m_builder>: ... this and make private.
6622         (dwarf2_cu::get_builder): New method.  Change all users of
6623         `builder' to use this method.
6624         (dwarf2_start_symtab): Move to ...
6625         (dwarf2_cu::start_symtab): ... here.  Update all callers
6626         (setup_type_unit_groups): Move to ...
6627         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6628         callers.
6629         (dwarf2_cu::reset_builder): New method.
6630         (process_full_compunit, process_full_type_unit): Use
6631         dwarf2_cu::reset_builder.
6632         (follow_die_offset): Record the ancestor CU if it is different
6633         from the followed DIE's CU.
6634         (follow_die_sig_1): Likewise.
6635
6636 2019-01-15  Tom Tromey  <tom@tromey.com>
6637
6638         * remote.c (class remote_state) <buf>: Now a char_vector.
6639         <buf_size>: Remove.
6640         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6641         parameter.
6642         (remote_target::getpkt_or_notif_sane_1)
6643         (remote_target::getpkt_sane)
6644         (remote_target::getpkt_or_notif_sane): Likewise.
6645         (class remote_target) <putpkt>: New overload.
6646         (remote_target::read_frame): Change type of "buf_p".  Remove
6647         sizeof_p parameter.
6648         (packet_ok): New overload.
6649         (packet_check_result): New overload.
6650         Update all uses.
6651
6652 2019-01-14  Tom Tromey  <tom@tromey.com>
6653
6654         * remote-notif.c (handle_notification, remote_notif_ack)
6655         (remote_notif_parse): Make "buf" const.
6656         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6657         const.
6658         (remote_notif_parse, remote_notif_ack, handle_notification):
6659         Likewise.
6660         * remote.c (remote_notif_stop_parse): Make "buf" const.
6661         (remote_target::remote_parse_stop_reply): Make "buf" const.
6662         (remote_notif_stop_ack): Make "buf" const.
6663
6664 2019-01-14  Tom Tromey  <tom@tromey.com>
6665
6666         * remote.c (remote_console_output): Make parameter const.
6667
6668 2019-01-14  Tom Tromey  <tom@tromey.com>
6669
6670         * target-debug.h (target_debug_print_signals): Constify.
6671         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6672         * procfs.c (procfs_target::pass_signals): Update.
6673         * linux-nat.c (linux_nat_target::pass_signals): Update.
6674         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6675         * target-delegates.c: Rebuild.
6676         * remote.c (remote_target::program_signals): Update.
6677         (remote_target::pass_signals): Update.
6678         * target.c (target_pass_signals): Constify argument.
6679         (target_program_signals): Likewise.
6680         * target.h (struct target_ops) <pass_signals, program_signals>:
6681         Constify argument.
6682         (target_pass_signals, target_program_signals): Constify argument.
6683
6684 2019-01-14  Tom Tromey  <tom@tromey.com>
6685
6686         PR tui/28819:
6687         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6688
6689 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6690
6691         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6692         field.
6693         * rs6000-tdep.c: Include reggroups.h.
6694         (IS_V_ALIAS_PSEUDOREG): Define.
6695         (rs6000_register_name): Return names for the "vX" aliases.
6696         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6697         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6698         aliases.  Call default_register_reggroup_p for all other
6699         pseudo-registers.
6700         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6701         New functions.
6702         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6703         Handle "vX" aliases.
6704         (v_alias_pseudo_register_collect): New function.
6705         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6706         (rs6000_gdbarch_init): Initialize "vX" aliases as
6707         pseudo-registers.  Restore registration of
6708         rs6000_pseudo_register_reggroup_p with
6709         set_tdesc_pseudo_register_reggroup_p.
6710
6711 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6712
6713         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6714         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6715         set_gdbarch_num_pseudo_regs.
6716
6717 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6718
6719         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6720         Remove arg prefixname, add do_set and do_show.
6721         Add member functions set_list and show_list.
6722         * cli/cli-style.c (class cli_style_option): Update accordingly.
6723         (style_set_list): Move to file scope.
6724         (style_show_list): Likewise.
6725         (set_style): Call help_list.
6726         (show_style): Call cmd_show_list.
6727         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6728         Update to use the new macro.
6729
6730 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6731
6732         * ada-lang.c (_initialize_ada_language): Expand the help text
6733         for the "catch exception" command.
6734
6735 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6736
6737         * symtab.c (matching_obj_sections): Initialize obj,
6738         declare it closer to its usage.
6739
6740 2019-01-10  Tom Tromey  <tom@tromey.com>
6741
6742         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6743         (basic_inf_threads_range): Remove.
6744         (inf_threads_range, inf_non_exited_threads_range)
6745         (safe_inf_threads_range): Use next_adapter.
6746
6747 2019-01-10  Keith Seitz  <keiths@redhat.com>
6748
6749         PR gdb/23712
6750         PR symtab/23010
6751         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6752         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6753
6754 2019-01-10  Keith Seitz  <keiths@redhat.com>
6755
6756         PR gdb/23712
6757         PR symtab/23010
6758         * dictionary.c (pending_to_vector): Remove.
6759         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6760         Remove _1 suffix, replacing functions of the same name.  Update
6761         all callers.
6762         (dict_create_hashed, dict_create_hashed_expandable)
6763         (dict_create_linear, dict_create_linear_expandable, dict_free)
6764         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6765         Make functions static.
6766
6767 2019-01-10  Keith Seitz  <keiths@redhat.com>
6768
6769         PR gdb/23712
6770         PR symtab/23010
6771         * dictionary.h (struct dictionary): Replace declaration with
6772         multidictionary.
6773         (dict_create_hashed, dict_create_hashed_expandable)
6774         (dict_create_linear, dict_create_linear_expandable)
6775         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6776         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6777         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6778         taking multidictionary argument.
6779         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6780         * block.h (struct block) <dict>: Change to multidictionary
6781         and rename `multidict'.
6782         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6783         symmisc.c: Update all dictionary references to multidictionary.
6784
6785 2019-01-10  Keith Seitz  <keiths@redhat.com>
6786
6787         PR gdb/23712
6788         PR symtab/23010
6789         * dictionary.c: Include unordered_map.
6790         (pending_to_vector): New function.
6791         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6792         Rewrite the non-"_1" functions to take vector instead
6793         of linked list.
6794         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6795         "new" _1 versions of the same name.
6796         (multidictionary): Define.
6797         (std::hash<enum language): New definition.
6798         (collate_pending_symbols_by_language, mdict_create_hashed)
6799         (mdict_create_hashed_expandable, mdict_create_linear)
6800         (mdict_create_linear_expandable, mdict_free)
6801         (find_language_dictionary, create_new_language_dictionary)
6802         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6803         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6804         (mdict_size, mdict_empty): New functions.
6805         * dictionary.h (mdict_iterator): Define.
6806
6807 2019-01-10  Pedro Alves  <palves@redhat.com>
6808
6809         * breakpoint.c (read_uploaded_action)
6810         (create_tracepoint_from_upload): Adjust to use
6811         gdb::unique_xmalloc_ptr.
6812         * ctf.c (ctf_write_uploaded_tp):
6813         (SET_ARRAY_FIELD): Use emplace_back.
6814         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6815         * tracefile-tfile.c (tfile_write_uploaded_tp):
6816         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6817         gdb::unique_xmalloc_ptr.
6818         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6819         at_string, cond_string, cmd_strings>: Replace char pointers
6820         with gdb::unique_xmalloc_ptr.
6821
6822 2019-01-10  Pedro Alves  <palves@redhat.com>
6823
6824         * solib-target.c (library_list_start_library): Don't xstrdup name.
6825
6826 2019-01-10  Pedro Alves  <palves@redhat.com>
6827
6828         * mdebugread.c (parse_partial_symbols): Use
6829         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6830
6831 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6832
6833         * linux-fork.c (scoped_switch_fork_info)
6834         <~scoped_switch_fork_info>: Fix incorrect variable name.
6835
6836 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6837
6838         * linux-fork.c (scoped_switch_fork_info)
6839         <scoped_switch_fork_info>: Make explicit.
6840         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6841
6842 2019-01-10  Tom Tromey  <tom@tromey.com>
6843
6844         * objfiles.h (objfile::reset_psymtabs): Update.
6845         * objfiles.c (objfile::objfile): Update.
6846         * psymtab.h (psymtab_storage::obstack): Update.
6847         (psymtab_storage::m_obstack): Use gdb::optional.
6848         (class psymtab_storage): Update comment.  Remove objfile
6849         parameter.
6850         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6851
6852 2019-01-10  Tom Tromey  <tom@tromey.com>
6853
6854         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6855         <free_psymtabs>: Now private.
6856         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6857         (allocate_psymtab): Use new method.
6858
6859 2019-01-10  Tom Tromey  <tom@tromey.com>
6860
6861         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6862         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6863         * mdebugread.c (parse_partial_symbols): Use
6864         allocate_dependencies.
6865         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6866         allocate_dependencies.
6867         (process_psymtab_comp_unit_reader)
6868         (build_type_psymtab_dependencies): Likewise.
6869         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6870
6871 2019-01-10  Tom Tromey  <tom@tromey.com>
6872
6873         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6874         PSYMBOL_SET_LANGUAGE.
6875         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6876
6877 2019-01-10  Tom Tromey  <tom@tromey.com>
6878
6879         * psymtab.h (psymtab_storage::obstack): New method.
6880         <m_obstack>: Rename from obstack; now private.
6881         * psymtab.c (psymtab_storage): Update.
6882         * dwarf2read.c (create_addrmap_from_index)
6883         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6884         Update.
6885
6886 2019-01-10  Tom Tromey  <tom@tromey.com>
6887
6888         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6889         * objfiles.h (objfile::reset_psymtabs): New method.
6890
6891 2019-01-10  Tom Tromey  <tom@tromey.com>
6892
6893         * symmisc.c (print_symbol_bcache_statistics): Update.
6894         (print_objfile_statistics): Update.
6895         * symfile.c (reread_symbols): Update.
6896         * psymtab.h (class psymtab_storage): New.
6897         * psymtab.c (psymtab_storage): New constructor.
6898         (~psymtab_storage): New destructor.
6899         (require_partial_symbols): Update.
6900         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6901         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6902         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6903         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6904         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6905         (start_psymtab_common, end_psymtab_common)
6906         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6907         (allocate_psymtab): Update.
6908         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6909         Update.
6910         (dump_psymtab_addrmap, maintenance_print_psymbols)
6911         (maintenance_check_psymtabs): Update.
6912         (class objfile_psymtabs): Move to objfiles.h.
6913         * psympriv.h (discard_psymtab): Now inline.
6914         (psymtab_discarder::psymtab_discarder): Update.
6915         (psymtab_discarder::~psymtab_discarder): Update.
6916         (ALL_OBJFILE_PSYMTABS): Rewrite.
6917         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6918         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6919         Remove fields.
6920         <partial_symtabs>: New field.
6921         (class objfile_psymtabs): Move from psymtab.h.  Update.
6922         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6923         psymbol_cache.
6924         (objfile::~objfile): Don't destroy psymbol_cache.
6925         * mdebugread.c (parse_partial_symbols): Update.
6926         * dwarf2read.c (create_addrmap_from_index)
6927         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6928         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6929         (add_partial_subprogram, dwarf2_ranges_read): Update.
6930         * dwarf-index-write.c (write_address_map)
6931         (write_one_signatured_type, recursively_write_psymbols)
6932         (class debug_names, class debug_names, write_psymtabs_to_index):
6933         Update.
6934
6935 2019-01-10  Tom Tromey  <tom@tromey.com>
6936
6937         * symtab.h (SYMBOL_SET_NAMES): Update.
6938         (symbol_set_names): Update.
6939         (MSYMBOL_SET_NAMES): Update.
6940         * symtab.c (symbol_set_names): Change argument to be an
6941         objfile_per_bfd_storage.
6942         * psymtab.c (add_psymbol_to_bcache): Update.
6943         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6944
6945 2019-01-10  Tom Tromey  <tom@tromey.com>
6946
6947         * symtab.c (create_demangled_names_hash): Change argument to be an
6948         objfile_per_bfd_storage.
6949         (symbol_set_names): Update.
6950
6951 2019-01-10  Tom Tromey  <tom@tromey.com>
6952
6953         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6954         init_psymbol_list.
6955         * psymtab.c (init_psymbol_list): Do nothing if already called.
6956         * psympriv.h (init_psymbol_list): Add comment.
6957         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6958         init_psymbol_list.
6959         * dbxread.c (dbx_symfile_read): Unconditionally call
6960         init_psymbol_list.
6961
6962 2019-01-10  Tom Tromey  <tom@tromey.com>
6963
6964         * xcoffread.c (scan_xcoff_symtab): Update.
6965         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6966         "where".
6967         * mdebugread.c (parse_partial_symbols)
6968         (handle_psymbol_enumerators): Update.
6969         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6970         * dbxread.c (read_dbx_symtab): Update.
6971         * psympriv.h (psymbol_placement): New enum.
6972         (add_psymbol_to_list): Update.
6973
6974 2019-01-10  Tom Tromey  <tom@tromey.com>
6975
6976         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6977         static_psymbols parameters.
6978         (scan_xcoff_symtab): Update.
6979         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6980         static_psymbols parameters.
6981         * psympriv.h (start_psymtab_common): Update.
6982         * mdebugread.c (parse_partial_symbols): Update.
6983         * dwarf2read.c (create_partial_symtab): Update.
6984         * dbxread.c (read_dbx_symtab): Update.
6985         (start_psymtab): Remove global_psymbols and static_psymbols
6986         parameters.
6987
6988 2019-01-10  Tom Tromey  <tom@tromey.com>
6989
6990         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6991         * psymtab.c (allocate_psymtab): Add comment.
6992         * psympriv.h (allocate_psymtab): Add comment.
6993         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6994         initializations.
6995         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6996
6997 2019-01-10  Tom Tromey  <tom@tromey.com>
6998
6999         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7000         Don't declare.
7001         * mipsread.c: Include mdebugread.h.
7002         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7003         Declare.
7004         * elfread.c: Include mdebugread.h.
7005
7006 2019-01-09  Tom Tromey  <tom@tromey.com>
7007
7008         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7009         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7010         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7011         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7012         (psym_lookup_symbol, psym_find_last_source_symtab)
7013         (psym_forget_cached_source_info, psym_print_stats)
7014         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7015         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7016         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7017         (psym_find_compunit_symtab_by_address)
7018         (maintenance_print_psymbols, maintenance_info_psymtabs)
7019         (maintenance_check_psymtabs): Use ranged for.
7020         * psymtab.h (class objfile_psymtabs): New.
7021         (require_partial_symbols): Return objfile_psymtabs.
7022         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7023
7024 2019-01-09  Tom Tromey  <tom@tromey.com>
7025
7026         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7027         (find_pc_mapped_section, list_overlays_command)
7028         (map_overlay_command, unmap_overlay_command)
7029         (simple_overlay_update): Use all_objfiles.
7030         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7031         * printcmd.c (info_symbol_command): Use all_objfiles.
7032         * objfiles.h (ALL_OBJSECTIONS): Remove.
7033         * maint.c (maintenance_translate_address): Use all_objfiles.
7034         * gcore.c (gcore_create_callback): Use all_objfiles.
7035         (objfile_find_memory_regions): Likewise.
7036
7037 2019-01-09  Tom Tromey  <tom@tromey.com>
7038
7039         * symtab.c (find_line_symtab, info_sources_command)
7040         (make_source_files_completion_list): Use objfile_compunits.
7041         * source.c (select_source_symtab): Use objfile_compunits.
7042         * objfiles.h (struct objfile): Update comment.
7043         (ALL_OBJFILES): Remove.
7044         (ALL_FILETABS): Remove.
7045         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7046         objfile_compunits.
7047
7048 2019-01-09  Tom Tromey  <tom@tromey.com>
7049
7050         * symmisc.c (print_objfile_statistics, dump_objfile)
7051         (maintenance_print_symbols): Use compunit_filetabs.
7052         * source.c (forget_cached_source_info_for_objfile): Use
7053         compunit_filetabs.
7054         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7055         (ALL_FILETABS): Use compunit_filetabs.
7056         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7057         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7058
7059 2019-01-09  Tom Tromey  <tom@tromey.com>
7060
7061         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7062         (compunit_filetabs): New.
7063         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7064         compunit_filetabs.
7065         (info_sources_command, make_source_files_completion_list): Remove
7066         declaration.
7067         * symmisc.c (print_objfile_statistics, dump_objfile)
7068         (maintenance_print_symbols): Remove declaration.
7069         (maintenance_info_symtabs): Use compunit_filetabs.
7070         (maintenance_info_line_tables): Likewise.
7071         * source.c (select_source_symtab): Change local variable name.
7072         (forget_cached_source_info_for_objfile): Remove declaration.
7073         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7074         * objfiles.c (objfile_relocate1): Remove declaration.
7075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7076         declaration.
7077         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7078         * coffread.c (coff_symtab_read): Remove declaration.
7079         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7080         compunit_filetabs.
7081
7082 2019-01-09  Tom Tromey  <tom@tromey.com>
7083
7084         * symtab.c (lookup_objfile_from_block)
7085         (find_pc_sect_compunit_symtab, search_symbols)
7086         (default_collect_symbol_completion_matches_break_on): Use
7087         objfile_compunits.
7088         * objfiles.h (ALL_COMPUNITS): Remove.
7089         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7090         * cp-support.c (add_symbol_overload_list_qualified): Use
7091         objfile_compunits.
7092         * ada-lang.c (ada_collect_symbol_completion_matches)
7093         (ada_add_global_exceptions): Use objfile_compunits.
7094
7095 2019-01-09  Tom Tromey  <tom@tromey.com>
7096
7097         * source.c (select_source_symtab)
7098         (forget_cached_source_info_for_objfile): Remove declaration.
7099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7100         declaration.
7101         * maint.c (count_symtabs_and_blocks): Remove declaration.
7102         * cp-support.c (add_symbol_overload_list_qualified): Remove
7103         declaration.
7104         * coffread.c (coff_symtab_read): Remove declaration.
7105         * symtab.c (lookup_symbol_in_objfile_symtabs)
7106         (basic_lookup_transparent_type_1): Use objfile_compunits.
7107         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7108         (info_sources_command, search_symbols)
7109         (default_collect_symbol_completion_matches_break_on)
7110         (make_source_files_completion_list): Remove declaration.
7111         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7112         (ada_collect_symbol_completion_matches)
7113         (ada_add_global_exceptions): Remove declaration.
7114         * linespec.c (iterate_over_all_matching_symtabs): Use
7115         objfile_compunits.
7116         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7117         (class objfile_compunits): New.
7118         (ALL_COMPUNITS): Use objfile_compunits.
7119         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7120         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7121         objfile_compunits.
7122         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7123
7124 2019-01-09  Tom Tromey  <tom@tromey.com>
7125
7126         * symtab.c (search_symbols)
7127         (default_collect_symbol_completion_matches_break_on): Use
7128         objfile_msymbols.
7129         * ada-lang.c (ada_lookup_simple_minsym)
7130         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7131         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7132         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7133         objfile_msymbols.
7134         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7135         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7136         * objc-lang.c (find_methods): Use objfile_msymbols.
7137         (info_selectors_command, info_classes_command): Likewise.
7138         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7139         * objfiles.h (class objfile_msymbols): New.
7140         (ALL_OBJFILE_MSYMBOLS): Remove.
7141         (ALL_MSYMBOLS): Remove.
7142
7143 2019-01-09  Tom Tromey  <tom@tromey.com>
7144
7145         * common/next-iterator.h (next_adapter): Add Iterator template
7146         parameter.
7147         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7148         (class all_objfiles_safe): New.
7149         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7150         * objfiles.c (put_objfile_before): Update comment.
7151         (add_separate_debug_objfile): Likewise.
7152         (free_all_objfiles): Use all_objfiles_safe.
7153         (objfile_purge_solibs): Likewise.
7154
7155 2019-01-09  Tom Tromey  <tom@tromey.com>
7156
7157         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7158         (expand_symtab_containing_pc, lookup_static_symbol)
7159         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7160         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7161         all_objfiles.
7162         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7163         * breakpoint.c (create_overlay_event_breakpoint)
7164         (create_longjmp_master_breakpoint)
7165         (create_std_terminate_master_breakpoint)
7166         (create_exception_master_breakpoint): Use all_objfiles.
7167         * linux-thread-db.c (try_thread_db_load_from_pdir)
7168         (has_libpthread): Use all_objfiles.
7169         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7170         * linespec.c (iterate_over_all_matching_symtabs)
7171         (search_minsyms_for_name): Use all_objfiles.
7172         * maint.c (maintenance_info_sections): Use all_objfiles.
7173         * main.c (captured_main_1): Use all_objfiles.
7174         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7175         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7176         * guile/scm-pretty-print.c
7177         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7178         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7179         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7180         (maintenance_print_msymbols): Use all_objfiles.
7181         * source.c (select_source_symtab): Use all_objfiles.
7182         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7183         * symfile.c (remove_symbol_file_command)
7184         (expand_symtabs_matching, map_symbol_filenames): Use
7185         all_objfiles.
7186         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7187         all_objfiles.
7188         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7189         * objc-lang.c (find_methods): Use all_objfiles.
7190         * objfiles.c (have_partial_symbols, have_full_symbols)
7191         (have_minimal_symbols, qsort_cmp)
7192         (default_iterate_over_objfiles_in_search_order): Use
7193         all_objfiles.
7194         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7195         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7196         (maintenance_check_psymtabs): Use all_objfiles.
7197         (ALL_PSYMTABS): Remove.
7198         * compile/compile-object-run.c (do_module_cleanup): Use
7199         all_objfiles.
7200         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7201         * cp-support.c (add_symbol_overload_list_qualified): Use
7202         all_objfiles.
7203         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7204         Use all_objfiles.
7205         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7206         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7207         all_objfiles.
7208         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7209         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7210         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7211         Uses all_objfiles.
7212         * solib.c (solib_read_symbols): Use all_objfiles
7213
7214 2019-01-09  Tom Tromey  <tom@tromey.com>
7215
7216         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7217         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7218         all_objfiles.
7219         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7220         * symmisc.c (print_symbol_bcache_statistics)
7221         (print_objfile_statistics, maintenance_print_objfiles)
7222         (maintenance_info_symtabs, maintenance_check_symtabs)
7223         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7224         all_objfiles.
7225         * source.c (forget_cached_source_info): Use all_objfiles.
7226         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7227         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7228         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7229         * objfiles.c (update_section_map): Use all_objfiles.
7230         (shared_objfile_contains_address_p): Likewise.
7231         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7232         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7233
7234 2019-01-09  Tom Tromey  <tom@tromey.com>
7235
7236         * common/next-iterator.h: New file.
7237         * objfiles.h (class all_objfiles): New.
7238         (struct objfile_iterator): New.
7239
7240 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7241
7242         * NEWS: Move the description of the changed "frame", "select-frame",
7243          and "info frame" commands to the Changed commands section.
7244
7245 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7246
7247         * gdbtypes.c (check_stub_method_group): Remove handling of old
7248         mangling schemes.
7249         * linespec.c (find_methods): Likewise.
7250         * stabsread.c (read_member_functions): Likewise.
7251         * valops.c (search_struct_method): Likewise.
7252         (value_struct_elt_for_reference): Likewise.
7253         * NEWS: Mention this change.
7254
7255 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7258         print_source_lines.
7259         * source.c (print_source_lines_base): Update line number check.
7260         (print_source_lines): New function.
7261         (source_lines_range::source_lines_range): New function.
7262         * source.h (class source_lines_range): New class.
7263         (print_source_lines): New declaration.
7264
7265 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7266
7267         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7268
7269 2019-01-08  Tom Tromey  <tom@tromey.com>
7270             Simon Marchi  <simon.marchi@ericsson.com>
7271
7272         PR gdb/24060
7273         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7274         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7275         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7276         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7277         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7278         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7279
7280 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * source.c (select_source_symtab): Move header comment to
7283         declaration in source.h.
7284         (forget_cached_source_info_for_objfile): Likewise.
7285         (forget_cached_source_info): Likewise.
7286         (identify_source_line): Likewise.
7287         * source.h (identify_source_line): Move declaration from symtab.h
7288         and add comment from source.c
7289         (print_source_lines): Likewise.
7290         (forget_cached_source_info_for_objfile): Likewise.
7291         (forget_cached_source_info): Likewise.
7292         (select_source_symtab): Likewise.
7293         (enum print_source_lines_flag): Move definition from symtab.h.
7294         * symtab.h (identify_source_line): Move declaration to source.h.
7295         (print_source_lines): Likewise.
7296         (forget_cached_source_info_for_objfile): Likewise.
7297         (forget_cached_source_info): Likewise.
7298         (select_source_symtab): Likewise.
7299         (enum print_source_lines_flag): Move definition to source.h.
7300         * tui/tui-hooks.c: Add 'source.h' include.
7301
7302 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7303
7304         * source.c (print_source_lines_base): Handle requests to print
7305         reverse line number sequences, and guard against empty lines
7306         string.
7307
7308 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7309
7310         * source.c (print_source_lines_base): Fix skip of '\r' if next
7311         character is '\n'.
7312
7313 2019-01-06  Tom Tromey  <tom@tromey.com>
7314
7315         * c-exp.y (struct c_parse_state) <macro_original_text,
7316         expansion_obstack>: New member.
7317         (macro_original_text, expansion_obstack): Remove globals.
7318         (scan_macro_expansion, scanning_macro_expansion)
7319         (finished_macro_expansion): Update.
7320         (scan_macro_cleanup): Remove.
7321         (yylex, c_parse): Update.
7322
7323 2019-01-06  Tom Tromey  <tom@tromey.com>
7324
7325         * c-exp.y (struct c_parse_state) <strings>: New member.
7326         (operator_stoken): Update.
7327
7328 2019-01-06  Tom Tromey  <tom@tromey.com>
7329
7330         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7331         (union type_stack_elt) <typelist_val>: Now a pointer to
7332         std::vector.
7333         (type_stack_cleanup): Don't declare.
7334         (push_typelist): Update.
7335         * parse.c (pop_typelist): Return a std::vector.
7336         (push_typelist): Take a std::vector.
7337         (follow_types): Update.  Do not free args.
7338         (type_stack_cleanup): Remove.
7339         * c-exp.y (struct c_parse_state): New.
7340         (cpstate): New global.
7341         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7342         (nonempty_typelist): Update.
7343         (func_mod): Create a new vector.
7344         (c_parse): Create a c_parse_state.
7345         (check_parameter_typelist): Do not delete params.
7346         (function_method): Update.  Do not delete type_list.
7347
7348 2019-01-06  Tom Tromey  <tom@tromey.com>
7349
7350         PR gdb/28155:
7351         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7352         check_typedef.
7353         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7354         (print_return_value): Likewise.
7355
7356 2019-01-05  Tom Tromey  <tom@tromey.com>
7357
7358         * contrib/cleanup_check.py: Remove.
7359         * contrib/gcc-with-excheck: Remove.
7360         * contrib/exsummary.py: Remove.
7361         * contrib/excheck.py: Remove.
7362
7363 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7364
7365         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7366         NULL. Initialize tpprev to NULL instead of assigning it
7367         to NULL on the next statement.
7368         * windows-nat.c (windows_delete_thread): Remove check for
7369         main_thread_id before printing thread exit notifications.
7370         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7371         Remove thread ID check against main_thread_id.
7372         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7373         windows_delete_thread.
7374         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7375
7376 2019-01-04  Tom Tromey  <tom@tromey.com>
7377
7378         * compile/compile.c (_initialize_compile): Use upper case for
7379         metasyntactic variables.
7380         * symmisc.c (_initialize_symmisc): Use upper case for
7381         metasyntactic variables.
7382         * psymtab.c (_initialize_psymtab): Use upper case for
7383         metasyntactic variables.
7384         * demangle.c (demangle_command): Use upper case for metasyntactic
7385         variables.
7386         (_initialize_demangler): Likewise.
7387         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7388         variables.
7389
7390 2019-01-03  Tom Tromey  <tom@tromey.com>
7391
7392         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7393
7394 2019-01-03  Tom Tromey  <tom@tromey.com>
7395
7396         * python/py-symtab.c (salpy_str): Update.
7397         (struct salpy_sal_object) <symtab>: Now a PyObject.
7398         (salpy_dealloc): Update.
7399         (del_objfile_sal): Use gdbpy_ref.
7400
7401 2019-01-03  Tom Tromey  <tom@tromey.com>
7402
7403         * python/py-type.c (convert_field): Use new_reference.  Return
7404         gdbpy_ref.
7405         (make_fielditem): Return gdbpy_ref.
7406         (typy_fields): Update.
7407         (typy_getitem): Update.
7408         (field_name): Return gdbpy_ref.  Use new_reference.
7409         (typy_iterator_iternext): Update.
7410
7411 2019-01-03  Tom Tromey  <tom@tromey.com>
7412
7413         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7414
7415 2019-01-03  Tom Tromey  <tom@tromey.com>
7416
7417         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7418         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7419         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7420         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7421         (pspy_set_type_printers): Likewise.
7422         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7423         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7424         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7425         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7426         (objfpy_set_type_printers): Likewise.
7427
7428 2019-01-03  Tom Tromey  <tom@tromey.com>
7429
7430         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7431         (gdbpy_print_stack): Use gdbpy_err_fetch.
7432         * python/python-internal.h (class gdbpy_err_fetch): New class.
7433         (class gdbpy_enter) <m_error_type, m_error_value,
7434         m_error_traceback>: Remove.
7435         <m_error>: New member.
7436         (gdbpy_exception_to_string): Don't declare.
7437         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7438         * python/py-value.c (convert_value_from_python): Use
7439         gdbpy_err_fetch.
7440         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7441         gdbpy_exception_to_string.
7442         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7443         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7444         gdbpy_err_fetch.
7445
7446 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * linux-nat.c (delete_lwp_cleanup): Delete.
7449         (struct lwp_deleter): New struct.
7450         (lwp_info_up): New typedef.
7451         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7452         lwp_info_up.
7453
7454 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * linux-fork.c (class scoped_switch_fork_info): New class.
7457         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7458
7459 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7460
7461         * valops.c (find_overload_match): Remove use of null_cleanup, and
7462         calls to do_cleanups.
7463
7464 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * compile/compile-cplus-types.c
7467         (compile_cplus_instance::decl_name): Handle changes to
7468         cp_func_name.
7469         * cp-support.c (cp_func_name): Update header comment, update
7470         return type.
7471         * cp-support.h (cp_func_name): Update return type in declaration.
7472         * valops.c (find_overload_match): Move temp_func local to top
7473         level of function and change its type.  Use temp_func to hold and
7474         delete temporary string obtained from cp_func_name.
7475
7476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7479         gdb::char_vector, remove cleanup, and update uses of `msg`.
7480
7481 2019-01-03  Jim Wilson  <jimw@sifive.com>
7482
7483         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7484
7485 2019-01-02  Tom Tromey  <tom@tromey.com>
7486
7487         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7488         (tdesc_parse_xml): Remove cleanups.
7489         * target-descriptions.h (make_cleanup_free_target_description):
7490         Don't declare.
7491         (target_desc_deleter): New struct.
7492         (target_desc_up): New typedef.
7493         * target-descriptions.c (target_desc_deleter::operator()): Rename
7494         from free_target_description.
7495         (make_cleanup_free_target_description): Remove.
7496
7497 2019-01-02  Tom Tromey  <tom@tromey.com>
7498
7499         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7500         constructor, destructor.
7501         (linespec_parser): Remove typedef.
7502         (~linespec_parser): Rename from linespec_parser_delete.
7503         (linespec_lex_to_end, linespec_complete_label)
7504         (linespec_complete): Update.
7505         (decode_line_full): Remove cleanups.
7506         (decode_line_1): Update.
7507
7508 2019-01-02  Tom Tromey  <tom@tromey.com>
7509
7510         * python/python-internal.h (inferior_to_inferior_object): Change
7511         return type.
7512         * python/py-exitedevent.c (create_exited_event_object): Update.
7513         * python/py-inferior.c (inferior_to_inferior_object): Return
7514         gdbpy_ref.
7515         (python_new_inferior, python_inferior_deleted)
7516         (thread_to_thread_object, delete_thread_object)
7517         (build_inferior_list, gdbpy_selected_inferior): Update.
7518         * python/py-infthread.c (create_thread_object): Update.  Also fail
7519         if inferior_to_inferior_object fails.
7520
7521 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7522
7523         * inferior.h (class inferior) <displaced_step_state>: New field.
7524         * infrun.h (struct displaced_step_state): Move here from
7525         infrun.c.  Initialize fields, add constructor.
7526         <inf>: Remove field.
7527         <reset>: New method.
7528         * infrun.c (struct displaced_step_inferior_state): Move to
7529         infrun.h.
7530         (displaced_step_inferior_states): Remove.
7531         (get_displaced_stepping_state): Adust.
7532         (displaced_step_in_progress_any_inferior): Adjust.
7533         (displaced_step_in_progress_thread): Adjust.
7534         (displaced_step_in_progress): Adjust.
7535         (add_displaced_stepping_state): Remove.
7536         (get_displaced_step_closure_by_addr): Adjust.
7537         (remove_displaced_stepping_state): Remove.
7538         (infrun_inferior_exit): Call displaced_step_state.reset.
7539         (use_displaced_stepping): Don't check for NULL.
7540         (displaced_step_prepare_throw): Call
7541         get_displaced_stepping_state.
7542         (displaced_step_fixup): Don't check for NULL.
7543         (prepare_for_detach): Don't check for NULL.
7544
7545 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7546
7547         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7548          in case of call that did not complete.
7549
7550 2019-01-02  Andrey Utkin  <autkin@undo.io>
7551
7552         * symfile.c (find_separate_debug_file): Fix search of debug files for
7553         remote debuggee.
7554
7555 2019-01-02  Tom Tromey  <tom@tromey.com>
7556
7557         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7558         indentation.
7559         * python/py-frame.c (frapy_older): Remove cast.
7560         (frapy_newer): Likewise.
7561         * python/py-breakpoint.c (local_setattro): Remove cast.
7562         * python/py-arch.c (archpy_name): Remove local variable.
7563         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7564
7565 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7566
7567         * unittests/basic_string_view/element_access/char/empty.cc:
7568         Fix year range in copyright header.
7569
7570 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7573         Delete.
7574         <operator==>: Update with for removed field.
7575         <hash>: Likewise.
7576         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7577         <isa_features>: ...this.
7578         <abi_features>: New field.
7579         (riscv_isa_flen): Update comment.
7580         (riscv_abi_xlen): New declaration.
7581         (riscv_abi_flen): New declaration.
7582         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7583         isa_features.
7584         (riscv_abi_xlen): New function.
7585         (riscv_isa_flen): Update to get answer from isa_features.
7586         (riscv_abi_flen): New function.
7587         (riscv_has_fp_abi): Update to get answer from abi_features.
7588         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7589         xlen and flen.
7590         (riscv_call_info) <xlen, flen>: Update comment.
7591         (riscv_call_arg_struct): Remove invalid assertions
7592         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7593         is removed.
7594         (riscv_gdbarch_init): Gather isa features and abi features
7595         separately, ensure both match on the gdbarch when reusing an old
7596         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7597         a target with 64-bit float hardware.
7598
7599 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7600
7601         * source.c (search_command_helper): Stop reverse search
7602         when line 1 has been searched.
7603
7604 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7605
7606         * record-full.c (record_full_base_target::close): Rewrite
7607         record_full_core_buf_list free logic.
7608
7609 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7610
7611         * break-catch-syscall.c (print_one_catch_syscall): xfree
7612         the last text.
7613
7614 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7615
7616         * top.c (print_gdb_version): Update Copyright year in version
7617         message.
7618
7619 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7620
7621         Update copyright year range in all GDB files.
7622
7623 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7624
7625         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7626
7627 For older changes see ChangeLog-2018.
7628 \f
7629 Local Variables:
7630 mode: change-log
7631 left-margin: 8
7632 fill-column: 74
7633 version-control: never
7634 coding: utf-8
7635 End:
7636