gdb/ChangeLog

   1 2019-11-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * windows-nat.c (windows_nat_target::attach): Include GetLastError
   4         result in error when DebugActiveProcess fails.
   5
   6 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
   7             Pedro Alves  <palves@redhat.com>
   8
   9         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
  10         * target.c (target_stack::push): Call 'unpush' if there's a
  11         target on top of the stack.
  12
  13 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  14
  15         * python/py-block.c (blpy_dealloc): Call tp_free.
  16         (blpy_block_syms_dealloc): Likewise.
  17         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
  18         * python/py-inferior.c (infpy_dealloc): Likewise.
  19         * python/py-lazy-string.c (stpy_dealloc): Likewise.
  20         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
  21         * python/py-symbol.c (sympy_dealloc): Likewise.
  22         * python/py-symtab.c (stpy_dealloc): Likewise.
  23         * python/py-type.c (typy_iterator_dealloc): Likewise.
  24
  25 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
  26
  27         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
  28         constructor instead of using a class initializer.
  29
  30 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  31
  32         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
  33         * configure: Regenerate.
  34         * configure.ac: Don't source common.host.
  35         * gdbsupport/common.host: Remove.
  36         * gdbsupport/mingw-strerror.c: Remove.
  37         * gdbsupport/posix-strerror.c: Rename to...
  38         * gdbsupport/safe-strerror.c: ...this.
  39
  40 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  41
  42         * maint.c (scoped_command_stats::print_time): Use localtime_r
  43         instead of localtime (provided through gnulib if necessary).
  44         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
  45         of ctime.
  46
  47 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  50         avoid compile errors.
  51
  52 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  53
  54         * config.in: Regenerate.
  55         * configure: Regenerate.
  56         * gdbsupport/common.m4: No longer check for strerror_r.
  57         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  58         POSIX version of strerror_r, now that gnulib provides it if
  59         necessary.
  60
  61 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  62
  63         * README (`configure' options): Update.
  64
  65 2019-11-14  Tom Tromey  <tromey@adacore.com>
  66
  67         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  68         expected type for the RHS if the LHS is a convenience variable.
  69
  70 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  71
  72         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  73         Provide explicit default and copy constructor.
  74
  75 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  76
  77         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  78         only call Py_INCREF (newbp) in the bppy_pending_object case.
  79
  80 2019-11-13  Tom Tromey  <tromey@adacore.com>
  81
  82         PR build/25182:
  83         * psympriv.h (partial_symbol): Remove static assert.
  84         * symtab.h (general_symbol_info, symbol): Remove static assert.
  85
  86 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  87
  88         * gdbsupport/format.c (format_pieces::format_pieces): Support
  89         printf 'z' size modifier.
  90         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  91         * printcmd.c (ui_printf):  Handle size_t_arg.
  92         * ui-out.c (ui_out::vmessage): Likewise.
  93         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  94         function.
  95         (run_tests): Call test_format_int_sizes.
  96
  97 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * ada-exp.y (write_ambiguous_var): Update.
 100         * buildsym.c (add_symbol_to_list): Update.
 101         * dwarf2read.c (read_variable): Update.
 102         (new_symbol): Update.
 103         * jit.c (finalize_symtab): Update.
 104         * language.c (language_alloc_type_symbol): Update.
 105         * symtab.c (fixup_symbol_section): Update.
 106         (initialize_objfile_symbol_1): Move code to...
 107         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 108         (allocate_symbol): Update.
 109         (allocate_template_symbol): Update.
 110         (get_symbol_address): Update.
 111         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 112         of having as a field, and add a constructor.
 113         (SYMBOL_VALUE): Update.
 114         (SYMBOL_VALUE_ADDRESS): Update.
 115         (SET_SYMBOL_VALUE_ADDRESS): Update.
 116         (SYMBOL_VALUE_BYTES): Update.
 117         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 118         (SYMBOL_BLOCK_VALUE): Update.
 119         (SYMBOL_VALUE_CHAIN): Update.
 120         (SYMBOL_LANGUAGE): Update.
 121         (SYMBOL_SECTION): Update.
 122         (SYMBOL_OBJ_SECTION): Update.
 123         (SYMBOL_SET_LANGUAGE): Update.
 124         (SYMBOL_SET_LINKAGE_NAME): Update.
 125         (SYMBOL_SET_NAMES): Update.
 126         (SYMBOL_NATURAL_NAME): Update.
 127         (SYMBOL_LINKAGE_NAME): Update.
 128         (SYMBOL_DEMANGLED_NAME): Update.
 129         (SYMBOL_SEARCH_NAME): Update.
 130         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 131         (struct symbol): Update.
 132         (struct template_symbol): Update.
 133         (struct rust_vtable_symbol): Update.
 134         * xcoffread.c (SYMBOL_DUP): Update.
 135
 136 2019-11-12  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-layout.c (show_layout): Set current_layout.
 139         (show_source_disasm_command, show_data)
 140         (show_source_or_disasm_and_command): Don't set current_layout.
 141
 142 2019-11-12  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 145
 146 2019-11-12  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-win.c (resize_message): New global.
 149         (show_tui_resize_message): New function.
 150         (tui_async_resize_screen): Print message if requested.
 151         (_initialize_tui_win): Add tui-resize-message setting.
 152         * NEWS: Add entry for new commands.
 153
 154 2019-11-11  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 157         functions.
 158
 159 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 160
 161         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 162
 163 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 166         function.
 167         * python/python-internal.h (gdbpy_lookup_static_symbols):
 168         Declare new function.
 169         * python/python.c (python_GdbMethods): Add
 170         gdb.lookup_static_symbols method.
 171         * NEWS: Mention gdb.lookup_static_symbols.
 172
 173 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 174
 175         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 176         static block of current object file first.  Also fix typo in
 177         header comment.
 178
 179 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * stack.c (set_last_displayed_sal): Delete.
 182         (last_displayed_sal_valid): Delete.
 183         (last_displayed_pspace): Delete.
 184         (last_displayed_addr): Delete.
 185         (last_displayed_symtab): Delete.
 186         (last_displayed_line): Delete.
 187         (class last_displayed_symtab_info_type): New.
 188         (last_displayed_symtab_info): New static global variable.
 189         (print_frame_info): Call methods on last_displayed_symtab_info.
 190         (clear_last_displayed_sal): Update header comment, and make use of
 191         last_displayed_symtab_info.
 192         (last_displayed_sal_is_valid): Likewise.
 193         (get_last_displayed_pspace): Likewise.
 194         (get_last_displayed_addr): Likewise.
 195         (get_last_displayed_symtab): Likewise.
 196         (get_last_displayed_line): Likewise.
 197         (get_last_displayed_sal): Likewise.
 198         * stack.h (clear_last_displayed_sal): Update header comment.
 199         (last_displayed_sal_is_valid): Likewise.
 200         (get_last_displayed_pspace): Likewise.
 201         (get_last_displayed_addr): Likewise.
 202         (get_last_displayed_symtab): Likewise.
 203         (get_last_displayed_line): Likewise.
 204         (get_last_displayed_sal): Likewise.
 205
 206 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * stack.c (frame_show_address): Convert return type to bool.
 209         * stack.h (frame_show_address): Likewise, and update header
 210         comment.
 211
 212 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 215         * unittests/vec-utils-selftests.c: New file.
 216         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 217
 218 2019-11-10  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 221         (tui_highlight_win): Likewise.
 222         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 223         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 224         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 225         Don't set can_highlight.
 226
 227 2019-11-10  Tom Tromey  <tom@tromey.com>
 228
 229         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 230         Remove unused declaration.
 231
 232 2019-11-08  Tom Tromey  <tromey@adacore.com>
 233
 234         * top.c (read_command_file): Update.
 235         (command_line_input): Make return type const.
 236         * python/py-gdb-readline.c: Update.
 237         * linespec.c (decode_line_2): Update.
 238         * defs.h (command_line_input): Make return type const.
 239         * cli/cli-script.c (read_next_line): Make return type const.
 240         * ada-lang.c (get_selections): Update.
 241
 242 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 243
 244         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 245         * mi/mi-main.c (output_cores): Likewise.
 246         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 247         (linux_xfer_osdata_modules): Likewise.
 248         * remote.c (register_remote_support_xml): Likewise.
 249         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 250         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 251
 252 2019-11-06  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-interp.c: Don't include readline.h.
 255         * tui/tui-hooks.c: Don't include readline.h.
 256         * symmisc.c: Include tilde.h, not readline.h.
 257         * symfile.c: Include tilde.h, not readline.h.
 258         * source.c: Include tilde.h, not readline.h.
 259         * solib.c: Include tilde.h, not readline.h.
 260         * psymtab.c: Include tilde.h, not readline.h.
 261         * exec.c: Include tilde.h, not readline.h.
 262         * corelow.c: Include tilde.h, not readline.h.
 263         * cli/cli-dump.c: Include tilde.h, not readline.h.
 264         * cli/cli-cmds.c: Don't include readline.h.
 265
 266 2019-11-05  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 269         (tui_disassemble): Set addr_size.
 270         (tui_disasm_window::set_contents): Use addr_size.
 271
 272 2019-11-05  Tom Tromey  <tom@tromey.com>
 273
 274         * rust-lang.c (rust_language_defn): Update.
 275         * python/py-value.c (valpy_string): Call c_get_string.
 276         * p-lang.c (pascal_language_defn): Update.
 277         * opencl-lang.c (opencl_language_defn): Update.
 278         * objc-lang.c (objc_language_defn): Update.
 279         * m2-lang.c (m2_language_defn): Update.
 280         * language.c (unknown_language_defn, auto_language_defn): Update.
 281         (default_get_string): Remove.
 282         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 283         * go-lang.c (go_language_defn): Update.
 284         * f-lang.c (f_language_defn): Update.
 285         * d-lang.c (d_language_defn): Update.
 286         * c-lang.c (c_language_defn, cplus_language_defn)
 287         (asm_language_defn, minimal_language_defn): Update.
 288         * ada-lang.c (ada_language_defn): Update.
 289         * language.h (struct language_defn) <la_get_string>: Remove.
 290         (LA_GET_STRING): Remove.
 291         (default_get_string): Don't declare.
 292
 293 2019-11-05  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-source.h (struct tui_source_window): Inline
 296         constructor.  Remove destructor.
 297         <style_changed, m_observable>: Move to superclass.
 298         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 299         (struct tui_source_window_base): Move private members to end.
 300         <style_changed, m_observable>: Move from tui_source_window.
 301         * tui/tui-winsource.c (tui_copy_source_line): Move from
 302         tui-source.c.  Rename from copy_source_line.  Add special handling
 303         for negative line number.
 304         (tui_source_window_base::style_changed): Move from
 305         tui_source_window.
 306         (tui_source_window_base): Register observer.
 307         (~tui_source_window_base): New.
 308         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 309         rename.
 310         (tui_source_window::set_contents): Use tui_copy_source_line.
 311         (tui_source_window::tui_source_window): Move to tui-source.h.
 312         (tui_source_window::~tui_source_window): Remove.
 313         (tui_source_window::style_changed): Move to superclass.
 314         * tui/tui-disasm.c (tui_disassemble): Create string file with
 315         styling, when possible.  Add "addr_size" parameter.
 316         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 317         Don't compute maximum size.
 318         (len_without_escapes): New function
 319
 320 2019-11-05  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 323         std::string.
 324         * tui/tui-winsource.c (tui_show_source_line): Update.
 325         * tui/tui-source.c (tui_source_window::set_contents): Update.
 326         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 327
 328 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 329
 330         * symtab.h (gdb_static_assert): Put && operator at the beginning
 331         of the line instead of the end.
 332
 333 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 334
 335         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 336         and sizeof (symbol).
 337         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 338
 339 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 340
 341         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 342         * configure.host: Mark *-*-solaris2.10* obsolete.
 343         * configure.tgt: Mark Solaris < 11 obsolete.
 344         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 345         Update target triplet.
 346
 347 2019-11-01  Tom Tromey  <tromey@adacore.com>
 348
 349         * utils.c (print_sys_errmsg): Simplify.
 350
 351 2019-11-01  Tom Tromey  <tromey@adacore.com>
 352
 353         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 354
 355 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 356
 357         * configure: Regenerate.
 358         * configure.ac: Remove check for strerror_r.
 359         * gdbsupport/common.m4: Check for strerror_r.
 360
 361 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 362
 363         PR gdb/25124
 364
 365         * arm-tdep.c (arm_per_objfile): Rename to ...
 366         (arm_per_bfd): ... this.
 367         (arm_objfile_data_key): Rename to ...
 368         (arm_bfd_data_key): ... this.
 369         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 370         data.
 371         (arm_record_special_symbol): Likewise.
 372
 373 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 376         end.
 377         * c-typeprint.c (c_print_typedef): Likewise.
 378         * f-typeprint.c (f_print_typedef): Likewise.
 379         * m2-typeprint.c (m2_print_typedef): Likewise.
 380         * p-typeprint.c (pascal_print_typedef): Likewise.
 381         * rust-lang.c (rust_print_typedef): Likewise.
 382         * symtab.c (print_symbol_info): Print a newline after calling
 383         typedef_print.
 384
 385 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 386
 387         * symtab.c (info_module_cmdlist): New variable.
 388         (info_module_command): New function.
 389         (search_module_symbols): New function.
 390         (info_module_subcommand): New function.
 391         (struct info_modules_var_func_options): New struct.
 392         (info_modules_var_func_options_defs): New variable.
 393         (make_info_modules_var_func_options_def_group): New function.
 394         (info_module_functions_command): New function.
 395         (info_module_variables_command): New function.
 396         (info_module_var_func_command_completer): New function.
 397         (_initialize_symtab): Register new 'info module functions' and
 398         'info module variables' commands.
 399         * symtab.h (typedef symbol_search_in_module): New typedef.
 400         (search_module_symbols): Declare new function.
 401         * NEWS: Mention new commands.
 402
 403 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 406         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 407         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 408         MODULES_DOMAIN.
 409         (scan_partial_symbols): Only create partial module symbols for non
 410         declarations.
 411         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 412         and MODULES_DOMAIN.
 413         * symtab.c (search_domain_name): Likewise.
 414         (search_symbols): Likewise.
 415         (print_symbol_info): Likewise.
 416         (symtab_symbol_info): Likewise.
 417         (info_modules_command): New function.
 418         (_initialize_symtab): Register 'info modules' command.
 419         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 420         * NEWS: Mention new 'info modules' command.
 421
 422 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 423
 424         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 425         and $_gdb_maint_setting_str.
 426
 427 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 428
 429         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 430         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 431         (str_value_from_setting, gdb_setting_str_internal_fn)
 432         (gdb_maint_setting_str_internal_fn): New functions.
 433         (_initialize_cli_cmds): Define the new convenience functions.
 434         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 435         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 436
 437 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 438
 439         * agent.c (set_can_use_agent): When the setting is turned on,
 440         look up agent symbols if we don't have them yet.
 441         (agent_new_objfile): Don't look up agent symbols when the agent
 442         setting is off.
 443
 444 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 445
 446         * config.in: Regenerate.
 447
 448 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * configure: Regenerate.
 451         * configure.ac: Check for strerror_r.
 452         * gdbsupport/common-utils.h (safe_strerror): Change return value
 453         to const char * and document that this function is now threadsafe.
 454         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 455         thread_local and call strerror_r, if available.
 456         * utils.c (perror_string): Update.
 457         (print_sys_errmsg): Update.
 458
 459 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 460
 461         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 462         objfile_key.
 463         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 464         objfile to fetch per-bfd data.
 465         (arm_find_exidx_entry): Likewise.
 466
 467 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 468
 469         * gdbsupport/agent.c (debug_agent): Change type to bool.
 470         (use_agent): Likewise.
 471         (all_agent_symbols_look_up): Likewise.
 472         (agent_loaded_p): Change return value to bool.
 473         (agent_look_up_symbols): Update.
 474         (agent_capability_check): Change return value to bool.
 475         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 476         (debug_agent): Change type to bool.
 477         (use_agent): Likewise.
 478         (agent_capability_check): Change return value to bool.
 479
 480 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 481
 482         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 483         (build_minimal_symbol_hash_tables): Code to clear the table moved
 484         to clear_minimal_symbol_hash_tables.
 485         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 486         when needed.
 487
 488 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 489
 490         * infcmd.c: Remove includes.
 491         * infrun.c: Remove includes.
 492
 493 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 494
 495         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 496         (grow_vect): Remove declaration.
 497         (ada_type_of_array): Remove declaration.
 498         (ada_update_initial_language): Remove declaration.
 499         (ada_fold_name): Remove declaration.
 500         (ada_fill_in_ada_prototype): Remove declaration.
 501         (user_select_syms): Remove declaration.
 502         (get_selections): Remove declaration.
 503         (ada_tag_type): Remove declaration.
 504         (ada_value_tag): Remove declaration.
 505         (ada_is_others_clause): Remove declaration.
 506         (ada_in_variant): Remove declaration.
 507         (ada_value_struct_elt): Remove declaration.
 508         (ada_attribute_name): Remove declaration.
 509         (ada_system_address_type): Remove declaration.
 510         * ada-lang.c (ada_watch_location_expression): Make static.
 511         (GROW_VECT): Move here from ada-lang.h.
 512         (grow_vect): Make static.
 513         (ada_update_initial_language): Make static.
 514         (ada_fold_name): Make static.
 515         (ada_type_of_array): Make static.
 516         (encoded_ordered_before): Move up.
 517         (sort_choices): Move up.
 518         (print_signatures): Move up.
 519         (ada_print_symbol_signature): Move up.
 520         (get_selections): Move up and make static.
 521         (user_select_syms): Move up and make static.
 522         (ada_value_struct_elt): Move up and make static.
 523         (ada_tag_type): Make static.
 524         (ada_value_tag): Make static.
 525         (ada_is_others_clause): Make static.
 526         (ada_in_variant): Make static.
 527         (ada_attribute_name): Make static.
 528
 529 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 530
 531         * ada-lang.c: Remove includes.
 532         * ada-typeprint.c: Remove includes.
 533         * ada-valprint.c: Remove includes.
 534
 535 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 536
 537         * addrmap.c: Add static assertions of type size, moved from
 538         _initialize_addrmap.
 539         (_initialize_addrmap): Remove.
 540
 541 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 542
 543         * coffread.c (record_minimal_symbol): Update.
 544         (process_coff_symbol): Update.
 545         * dbxread.c (read_dbx_symtab): Update.
 546         * dwarf2read.c (add_partial_symbol): Update.
 547         (fixup_go_packaging): Update.
 548         (load_partial_dies): Update.
 549         (new_symbol): Update.
 550         * elfread.c (record_minimal_symbol): Change signature to use
 551         gdb::string_view instead of name+len.
 552         (elf_symtab_read): Update.
 553         (elf_rel_plt_read): Update.
 554         * mdebugread.c (parse_partial_symbols): Update.
 555         (handle_psymbol_enumerators): Update.
 556         (new_symbol): Update.
 557         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 558         to use gdb::string_view instead of name+len.
 559         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 560         * psympriv.h (add_psymbol_to_list): Likewise.
 561         * psymtab.c (add_psymbol_to_bcache): Likewise.
 562         (add_psymbol_to_list): Likewise.
 563         * stabsread.c (define_symbol): Update.
 564         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 565         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 566         (symbol_set_names): Likewise.
 567         * xcoffread.c (scan_xcoff_symtab): Update.
 568
 569 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 570
 571         * symtab.h (symbol_set_names): Document that copy_name must be
 572         set to true for non-nullterminated strings.
 573         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 574         linkage_name if the entry was not found and we need to demangle.
 575
 576 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 577
 578         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 579         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 580         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 581         * gdbsupport/gdb_binary_search.h: New file.
 582
 583 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 584
 585         * NEWS: Mention new --with-system-gdbinit-dir option.
 586         * config.in: Regenerate.
 587         * configure: Regenerate.
 588         * configure.ac: Add new option --with-system-gdbinit-dir.
 589         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 590         for a ".gdb" suffix.
 591         * main.c (get_init_files): Change system_gdbinit argument to
 592         a vector and return the files in SYSTEM_GDBINIT_DIR in
 593         addition to SYSTEM_GDBINIT.
 594         (captured_main_1): Update.
 595         (print_gdb_help): Update.
 596         * top.c (print_gdb_configuration): Also print the value of
 597         SYSTEM_GDBINIT_DIR.
 598
 599 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 600
 601         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 602         that takes gdb::string_view arguments.
 603
 604 2019-10-26  Tom de Vries  <tdevries@suse.de>
 605
 606         * aarch64-linux-tdep.c: Fix typos in comments.
 607         * aarch64-tdep.c: Same.
 608         * ada-lang.c: Same.
 609         * amd64-nat.c: Same.
 610         * arc-tdep.c: Same.
 611         * arch/aarch64-insn.c: Same.
 612         * block.c: Same.
 613         * breakpoint.h: Same.
 614         * btrace.h: Same.
 615         * c-varobj.c: Same.
 616         * cli/cli-decode.c: Same.
 617         * cli/cli-script.c: Same.
 618         * cli/cli-utils.h: Same.
 619         * coff-pe-read.c: Same.
 620         * coffread.c: Same.
 621         * compile/compile-cplus-symbols.c: Same.
 622         * compile/compile-object-run.c: Same.
 623         * completer.c: Same.
 624         * corelow.c: Same.
 625         * cp-support.c: Same.
 626         * demangle.c: Same.
 627         * dwarf-index-write.c: Same.
 628         * dwarf2-frame.c: Same.
 629         * dwarf2-frame.h: Same.
 630         * eval.c: Same.
 631         * frame-base.h: Same.
 632         * frame.h: Same.
 633         * gdbcmd.h: Same.
 634         * gdbtypes.h: Same.
 635         * gnu-nat.c: Same.
 636         * guile/scm-objfile.c: Same.
 637         * i386-tdep.c: Same.
 638         * i386-tdep.h: Same.
 639         * infcall.c: Same.
 640         * infcall.h: Same.
 641         * linux-nat.c: Same.
 642         * m68k-tdep.c: Same.
 643         * macroexp.c: Same.
 644         * memattr.c: Same.
 645         * mi/mi-cmd-disas.c: Same.
 646         * mi/mi-getopt.h: Same.
 647         * mi/mi-main.c: Same.
 648         * minsyms.c: Same.
 649         * nat/aarch64-sve-linux-sigcontext.h: Same.
 650         * objfiles.h: Same.
 651         * ppc-linux-nat.c: Same.
 652         * ppc-linux-tdep.c: Same.
 653         * ppc-tdep.h: Same.
 654         * progspace.h: Same.
 655         * prologue-value.h: Same.
 656         * python/py-evtregistry.c: Same.
 657         * python/py-instruction.h: Same.
 658         * record-btrace.c: Same.
 659         * record-full.c: Same.
 660         * remote.c: Same.
 661         * rs6000-tdep.c: Same.
 662         * ser-tcp.c: Same.
 663         * sol-thread.c: Same.
 664         * sparc-sol2-tdep.c: Same.
 665         * sparc64-tdep.c: Same.
 666         * stabsread.c: Same.
 667         * symfile.c: Same.
 668         * symtab.h: Same.
 669         * target.c: Same.
 670         * tracepoint.c: Same.
 671         * tui/tui-data.h: Same.
 672         * tui/tui-io.c: Same.
 673         * tui/tui-win.c: Same.
 674         * tui/tui.c: Same.
 675         * unittests/rsp-low-selftests.c: Same.
 676         * user-regs.h: Same.
 677         * utils.c: Same.
 678         * utils.h: Same.
 679         * valarith.c: Same.
 680         * valops.c: Same.
 681         * valprint.c: Same.
 682         * valprint.h: Same.
 683         * value.c: Same.
 684         * value.h: Same.
 685         * varobj.c: Same.
 686         * x86-nat.h: Same.
 687         * xtensa-tdep.c: Same.
 688
 689 2019-10-25  Ali Tamur <tamur@google.com>
 690
 691         * charset.c (find_charset_names): Reflect API change.
 692
 693 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 694
 695         * symtab.c (struct demangled_name_entry): Change demangled name
 696         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 697         part of the struct anymore.
 698         (symbol_set_names): No longer obstack allocate + copy the demangled
 699         name, just store the allocated name from bfd.
 700
 701 2019-10-25  Tom Tromey  <tromey@adacore.com>
 702
 703         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 704         (bsearch_cie_cmp, add_cie): Remove.
 705         (find_cie): Reimplement.
 706         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 707         (dwarf2_build_frame_info): Update.
 708
 709 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 710
 711         PR gdb/25126
 712         * symfile.c (reread_symbols): Call forget_cached_source_info to
 713         clear the stale source cache.
 714
 715 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * configure: Regenerate.
 718         * configure.ac: Remove code that sets python_has_threads.
 719
 720 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 721
 722         * config.in: Regenerate.
 723         * configure: Regenerate.
 724         * configure.ac: Remove the code that uses sed to get the python
 725         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 726
 727 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 730         error paths.
 731
 732 2019-10-23  Tom Tromey  <tom@tromey.com>
 733
 734         * arc-tdep.c: Remove ".." from include.
 735         * frv-tdep.c: Remove ".." from include.
 736         * lm32-tdep.c: Remove ".." from include.
 737         * microblaze-tdep.c: Remove ".." from include.
 738         * or1k-tdep.h: Remove ".." from include.
 739         * s12z-tdep.c: Remove ".." from include.
 740         * Makefile.in (OPCODES_CFLAGS): Add comment.
 741         (TOP_CFLAGS): New variable.
 742         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 743
 744 2019-10-23  Tom Tromey  <tom@tromey.com>
 745
 746         * Makefile.in (READLINE_DIR): Update.
 747
 748 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 749
 750         * infcall.c (call_function_by_hand_dummy): Fix the function
 751         comment.  And extract out a code section into...
 752         (reserve_stack_space): ...this new function.
 753
 754 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 755
 756         * infcall.c (value_arg_coerce): Remove an unused parameter.
 757         (call_function_by_hand_dummy): Update the call to
 758         'value_arg_coerce'.
 759
 760 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 761
 762         * infcall.c (call_function_by_hand_dummy): Refactor.
 763
 764 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 765
 766         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 767
 768 2019-10-23  Tom Tromey  <tom@tromey.com>
 769
 770         * configure: Rebuild.
 771         * configure.ac: Don't check for sigprocmask.
 772         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 773
 774 2019-10-23  Tom Tromey  <tom@tromey.com>
 775
 776         * configure: Rebuild.
 777         * acinclude.m4: Use m4_include, not sinclude.
 778
 779 2019-10-23  Tom de Vries  <tdevries@suse.de>
 780
 781         PR breakpoints/24687
 782         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 783
 784 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 785
 786         * symtab.c (struct demangled_name_entry) <language>: Change from
 787         bitfield to regular variable.
 788
 789 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 790
 791         * symtab.c (struct demangled_name_entry): Add a constructor.
 792         (free_demangled_name_entry): New function to call the destructor
 793         for demangled_name_entry.
 794         (create_demangled_names_hash): Pass free_demangled_name_entry to
 795         htab_create_alloc.
 796         (symbol_set_names): Call placement new for demangled_name_entry.
 797         * utils.c: No longer include xxhash.h here, now that fast_hash
 798         is inlined in the header.
 799         * utils.h: Instead, include it here.
 800
 801 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 802
 803         * Makefile.in: Link with libxxhash.
 804         * config.in: Regenerate.
 805         * configure: Regenerate.
 806         * configure.ac: Search for libxxhash.
 807         * utils.c (fast_hash): Use xxhash if present.
 808
 809 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 810
 811         * utils.h (fast_hash): New function.
 812         * symtab.c (hash_demangled_name_entry): Call new function
 813         fast_hash.
 814
 815 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 816
 817         * symtab.c (struct demangled_name_entry): Change type of mangled
 818         to gdb::string_view. Also adds a constructor that takes the
 819         mangled name.
 820         (hash_demangled_name_entry): Update.
 821         (eq_demangled_name_entry): Update.
 822         (free_demangled_name_entry): New function to call the destructor
 823         now that this is not a POD anymore.
 824         (create_demangled_names_hash): Pass free_demangled_name_entry to
 825         htab_create_alloc.
 826         (symbol_set_names): Update.
 827
 828 2019-10-21  Ali Tamur  <tamu@google.com>
 829
 830         * dwarf2read.c (dir_index): Change type.
 831         (file_name_index): Likewise.
 832         (line_header::include_dir_at): Change comment and implementation on
 833         whether it is DWARF 5.
 834         (line_header::is_valid_file_index): New function.
 835         (line_header::file_name_at): Change comment and implementation on
 836         whether it is DWARF 5.
 837         (line_header::file_names): Change to private field renamed as
 838         m_file_names and introduce a new accessor method.
 839         (line_header::file_names_size): New method.
 840         (line_header::include_dirs): Change to private field and rename as
 841         m_include_dirs.
 842         (dw2_get_file_names_reader): Define local var at a smaller scope and
 843         reflect API change.
 844         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 845         (process_structure_scope): Likewise.
 846         (line_header::add_include_dir): Change message and reflect renaming.
 847         (line_header::add_file_name): Likewise.
 848         (read_formatted_entries): Handle DW_FORM_data16.
 849         (dwarf_decode_line_header): Fix line header length calculation.
 850         (psymtab_include_file_name): Change comment and API.
 851         (lnp_state_machine::m_file): Update comment and reflect type change.
 852         (lnp_state_machine::record_line): Reflect type change.
 853         (dwarf_decode_lines): Reflect API change.
 854         (file_file_name): Likewise.
 855         (file_full_name): Likewise.
 856
 857 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 860
 861 2019-10-21  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 864
 865 2019-10-21  Tom Tromey  <tom@tromey.com>
 866
 867         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 868         NM_H.   Use AC_CONFIG_LINKS.
 869         * configure: Rebuild.
 870         * Makefile.in (NM_H): New variable.
 871         (generated_files): Add NM_H.  Remove gcore.
 872         (nm.h, stamp-nmh): New targets.
 873
 874 2019-10-20  Tom Tromey  <tom@tromey.com>
 875
 876         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 877         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 878         obsolete comment.
 879         (put_objfile_before): Now static.
 880
 881 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 882
 883         * gdbsupport/common-utils.h (startswith): Change return type to
 884         bool.
 885
 886 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 887
 888         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 889         * breakpoint.c (bp_locations_compare): Rename to...
 890         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 891         (update_global_location_list): Use std::sort instead of qsort.
 892         * buildsym.c (compare_line_numbers): Rename to...
 893         (lte_is_less_than): ...this, and change to std::sort semantics.
 894         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 895         instead of qsort.
 896         * disasm.c (compare_lines): Rename to...
 897         (line_is_less_than): ...this, and change to std::sort semantics.
 898         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 899         of qsort.
 900         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 901         (fde_is_less_than): ...this, and change to std::sort semantics.
 902         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 903         * mdebugread.c (compare_blocks):
 904         (block_is_less_than): ...this, and change to std::sort semantics.
 905         (sort_blocks): Call std::sort instead of qsort.
 906         * objfiles.c (qsort_cmp): Rename to...
 907         (sort_cmp): ...this, and change to std::sort semantics.
 908         (update_section_map): Call std::sort instead of qsort.
 909         * remote.c (compare_pnums): Remove.
 910         (map_regcache_remote_table): Call std::sort instead of qsort.
 911         * utils.c (compare_positive_ints): Remove.
 912         * utils.h (compare_positive_ints): Remove.
 913         * xcoffread.c (compare_lte): Remove.
 914         (arrange_linetable): Call std::sort instead of qsort.
 915
 916 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 917
 918         * symfile.c (init_entry_point_info): Fix typo.
 919         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 920
 921 2019-10-18  Tom de Vries  <tdevries@suse.de>
 922
 923         * aarch64-tdep.c: Fix typos in comments.
 924         * ada-lang.c: Same.
 925         * ada-tasks.c: Same.
 926         * alpha-tdep.c: Same.
 927         * alpha-tdep.h: Same.
 928         * amd64-nat.c: Same.
 929         * amd64-windows-tdep.c: Same.
 930         * arc-tdep.c: Same.
 931         * arc-tdep.h: Same.
 932         * arch-utils.c: Same.
 933         * arm-nbsd-tdep.c: Same.
 934         * arm-tdep.c: Same.
 935         * ax-gdb.c: Same.
 936         * blockframe.c: Same.
 937         * btrace.c: Same.
 938         * c-varobj.c: Same.
 939         * coff-pe-read.c: Same.
 940         * coffread.c: Same.
 941         * cris-tdep.c: Same.
 942         * darwin-nat.c: Same.
 943         * dbxread.c: Same.
 944         * dcache.c: Same.
 945         * disasm.c: Same.
 946         * dtrace-probe.c: Same.
 947         * dwarf-index-write.c: Same.
 948         * dwarf2-frame-tailcall.c: Same.
 949         * dwarf2-frame.c: Same.
 950         * dwarf2read.c: Same.
 951         * eval.c: Same.
 952         * exceptions.c: Same.
 953         * fbsd-tdep.c: Same.
 954         * findvar.c: Same.
 955         * frame.c: Same.
 956         * frv-tdep.c: Same.
 957         * gnu-v3-abi.c: Same.
 958         * go32-nat.c: Same.
 959         * h8300-tdep.c: Same.
 960         * hppa-tdep.c: Same.
 961         * i386-linux-tdep.c: Same.
 962         * i386-tdep.c: Same.
 963         * ia64-libunwind-tdep.c: Same.
 964         * ia64-tdep.c: Same.
 965         * infcmd.c: Same.
 966         * infrun.c: Same.
 967         * linespec.c: Same.
 968         * linux-nat.c: Same.
 969         * linux-thread-db.c: Same.
 970         * machoread.c: Same.
 971         * mdebugread.c: Same.
 972         * mep-tdep.c: Same.
 973         * mn10300-tdep.c: Same.
 974         * namespace.c: Same.
 975         * objfiles.c: Same.
 976         * opencl-lang.c: Same.
 977         * or1k-tdep.c: Same.
 978         * osabi.c: Same.
 979         * ppc-linux-nat.c: Same.
 980         * ppc-linux-tdep.c: Same.
 981         * ppc-sysv-tdep.c: Same.
 982         * printcmd.c: Same.
 983         * procfs.c: Same.
 984         * record-btrace.c: Same.
 985         * record-full.c: Same.
 986         * remote-fileio.c: Same.
 987         * remote.c: Same.
 988         * rs6000-tdep.c: Same.
 989         * s12z-tdep.c: Same.
 990         * score-tdep.c: Same.
 991         * ser-base.c: Same.
 992         * ser-go32.c: Same.
 993         * skip.c: Same.
 994         * sol-thread.c: Same.
 995         * solib-svr4.c: Same.
 996         * solib.c: Same.
 997         * source.c: Same.
 998         * sparc-nat.c: Same.
 999         * sparc-sol2-tdep.c: Same.
1000         * sparc-tdep.c: Same.
1001         * sparc64-tdep.c: Same.
1002         * stabsread.c: Same.
1003         * stack.c: Same.
1004         * symfile.c: Same.
1005         * symtab.c: Same.
1006         * target-descriptions.c: Same.
1007         * target-float.c: Same.
1008         * thread.c: Same.
1009         * utils.c: Same.
1010         * valops.c: Same.
1011         * valprint.c: Same.
1012         * value.c: Same.
1013         * varobj.c: Same.
1014         * windows-nat.c: Same.
1015         * xcoffread.c: Same.
1016         * xstormy16-tdep.c: Same.
1017         * xtensa-tdep.c: Same.
1018
1019 2019-10-17  Tom Tromey  <tromey@adacore.com>
1020
1021         * configure: Rebuild.
1022         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1023         in AC_CONFIG_FILES invocation.
1024         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1025         new-style config.status invocation.
1026
1027 2019-10-17  Tom de Vries  <tdevries@suse.de>
1028
1029         * arm-nbsd-nat.c: Fix typos in comments.
1030         * arm-tdep.c: Same.
1031         * darwin-nat-info.c: Same.
1032         * dwarf2read.c: Same.
1033         * elfread.c: Same.
1034         * event-top.c: Same.
1035         * findvar.c: Same.
1036         * gdbtypes.c: Same.
1037         * hppa-tdep.c: Same.
1038         * i386-tdep.c: Same.
1039         * jit.c: Same.
1040         * main.c: Same.
1041         * mdebugread.c: Same.
1042         * moxie-tdep.c: Same.
1043         * nto-procfs.c: Same.
1044         * osabi.c: Same.
1045         * ppc-linux-tdep.c: Same.
1046         * remote.c: Same.
1047         * riscv-tdep.c: Same.
1048         * s390-tdep.c: Same.
1049         * sh-tdep.c: Same.
1050         * sparc-linux-tdep.c: Same.
1051         * sparc-nat.c: Same.
1052         * stack.c: Same.
1053         * target-descriptions.c: Same.
1054         * top.c: Same.
1055         * varobj.c: Same.
1056
1057 2019-10-16  Tom Tromey  <tom@tromey.com>
1058
1059         * objfiles.h (struct objfile) <original_name>: Now const.
1060
1061 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1062
1063         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1064         pass on to sigsetjmp's second argument.
1065         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1066
1067 2019-10-16  Keith Seitz  <keiths@redhat.com>
1068
1069         PR gdb/23567
1070         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1071         sections whose size is greater than the file size.
1072
1073 2019-10-16  Jim Wilson  <jimw@sifive.com>
1074
1075         * riscv-tdep.c (riscv_gcc_target_options): New.
1076         (riscv_gnu_triplet_regexp): New.
1077         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1078         set_gdbarch_gnu_triplet_regexp.
1079
1080 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1081
1082         * Makefile.in: Add xml-builtin.h.
1083         * features/feature_to_c.sh: Add an include for xml-builtin.h
1084         to ensure that the compiler checks that the types match.
1085         * xml-builtin.h: New file.
1086         * xml-support.c (fetch_xml_builtin): Add missing const.
1087         * xml-support.h: Remove declaration of xml_builtins.
1088
1089 2019-10-16  Tom de Vries  <tdevries@suse.de>
1090
1091         PR tdep/25096
1092         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1093         (amd64_classify_aggregate): ... here.
1094         (amd64_classify_aggregate_field): Handled fiels of nested structs
1095         recursively.
1096
1097 2019-10-16  Tom de Vries  <tdevries@suse.de>
1098
1099         PR tdep/24104
1100         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1101         that handles 'theclass'.
1102
1103 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * linespec.c (decode_digits_ordinary): Update comment.
1106         * make-target-delegates: No longer need to handle VEC case.
1107         * memrange.c (normalize_mem_ranges): Update comment.
1108         * namespace.c (add_using_directive): Update comment.
1109         * objc-lang.c (uniquify_strings): Update comment.
1110         * ppc-linux-nat.c (struct thread_points): Update comment.
1111         * probe.h (find_probes_in_objfile): Update comment.
1112         * target.h (enum flash_preserve_mode): Update comment.
1113         * varobj.c (varobj_restrict_range): Update comment.
1114         * varobj.h (varobj_list_children): Update comment.
1115
1116 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * Makefile.in: Remove references to vec.h and vec.c.
1119         * aarch64-tdep.c: No longer include vec.h.
1120         * ada-lang.c: Likewise.
1121         * ada-lang.h: Likewise.
1122         * arm-tdep.c: Likewise.
1123         * ax.h: Likewise.
1124         * breakpoint.h: Likewise.
1125         * charset.c: Likewise.
1126         * cp-support.h: Likewise.
1127         * dtrace-probe.c: Likewise.
1128         * dwarf2read.c: Likewise.
1129         * extension.h: Likewise.
1130         * gdb_bfd.c: Likewise.
1131         * gdbsupport/gdb_vecs.h: Likewise.
1132         * gdbsupport/vec.c: Remove.
1133         * gdbsupport/vec.h: Remove.
1134         * gdbthread.h: Likewise.
1135         * guile/scm-type.c: Likewise.
1136         * inline-frame.c: Likewise.
1137         * machoread.c: Likewise.
1138         * memattr.c: Likewise.
1139         * memrange.h: Likewise.
1140         * namespace.h: Likewise.
1141         * nat/linux-btrace.h: Likewise.
1142         * osdata.c: Likewise.
1143         * parser-defs.h: Likewise.
1144         * progspace.h: Likewise.
1145         * python/py-type.c: Likewise.
1146         * record-btrace.c: Likewise.
1147         * rust-exp.y: Likewise.
1148         * solib-target.c: Likewise.
1149         * stap-probe.c: Likewise.
1150         * target-descriptions.c: Likewise.
1151         * target-memory.c: Likewise.
1152         * target.h: Likewise.
1153         * varobj.c: Likewise.
1154         * varobj.h: Likewise.
1155         * xml-support.h: Likewise.
1156
1157 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1160         Update for new std::vector based implementation.
1161         (process_psymtab_comp_unit_reader): Likewise.
1162         (scan_partial_symbols): Likewise.
1163         (recursively_compute_inclusions): Likewise.
1164         (compute_compunit_symtab_includes): Likewise.
1165         (process_imported_unit_die): Likewise.
1166         (queue_and_load_dwo_tu): Likewise.
1167         (follow_die_sig_1): Likewise.
1168         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1169         (typedef dwarf2_per_cu_ptr): Remove.
1170         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1171         function.
1172         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1173         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1174         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1175         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1176         std::vector.
1177
1178 2019-10-15  Tom Tromey  <tromey@adacore.com>
1179
1180         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1181         TID.
1182
1183 2019-10-15  Tom Tromey  <tromey@adacore.com>
1184
1185         * windows-nat.c (windows_nat_target::fetch_registers)
1186         (windows_nat_target::store_registers): Rename "pid" to "tid".
1187
1188 2019-10-15  Tom Tromey  <tromey@adacore.com>
1189
1190         * gdbarch.h, gdbarch.c: Rebuild.
1191         * gdbarch.sh (gcc_target_options): Change return type to
1192         std::string.
1193         * compile/compile.c (get_args): Update.
1194         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1195         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1196         std::string.
1197         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1198         std::string.
1199         * arch-utils.c (default_gcc_target_options): Return std::string.
1200         * arch-utils.h (default_gcc_target_options): Return std::string.
1201         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1202
1203 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1204
1205         * breakpoint.c (breakpoint_chain): Make static.
1206         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1207         of accessing breakpoint_chain.
1208
1209 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1212         to a gdb::function_view and return value to bool.
1213         * breakpoint.h (iterate_over_breakpoints): Likewise.
1214         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1215         (pop_dummy_frame): Update.
1216         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1217         (gdbscm_breakpoints): Update.
1218         * python/py-breakpoint.c (build_bp_list): Update.
1219         (gdbpy_breakpoints): Update.
1220         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1221         Update.
1222         (bpfinishpy_handle_stop): Update.
1223         (bpfinishpy_handle_exit): Update.
1224         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1225         (svr4_update_solib_event_breakpoints): Update.
1226
1227 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1228
1229         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1230         when unwrapping single-field structs.
1231
1232 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1233
1234         * dwarf2read.c: Remove includes.
1235
1236 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1237
1238         * ui-out.c (ui_out::call_do_message): Silence
1239         -Wformat-nonliteral warning.
1240
1241 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1242
1243         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1244         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1245         include: readline/tilde.h.
1246
1247 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1248
1249         * remote.c (remote_target::get_trace_status): Remove declaration of
1250         trace_regblock_size.
1251
1252 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1253
1254         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1255         (show_user): Remove declaration of cmdlist.
1256         * cli/cli-cmds.h (max_user_call_depth): Declare.
1257         * cli/cli-script.c (execute_user_command): Remove declaration
1258         of max_user_call_depth.
1259
1260 2019-10-11  Jim Wilson  <jimw@sifive.com>
1261
1262         * gdbsupport/print-utils.h (pulongest): Fix comment.
1263         (plongest): Likewise.
1264         (phex): Add missing comment, mention leading zeros.
1265         (phex_nz): Add mention of no leading zeros to comment.
1266
1267         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1268         plongest instead of unsigned long long cast.
1269
1270 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1273         for external_editor_command and gdbtk_test.
1274
1275 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1276
1277         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1278         * varobj.c (varobjdebug): Move comment to...
1279         * varobj.h (varobjdebug): ...here, and declare.
1280
1281 2019-10-09  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1284         erase_data_content.
1285
1286 2019-10-09  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1289         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1290         * tui/tui-command.c (tui_cmd_window::resize)
1291         (tui_refresh_cmd_win): Update.
1292         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1293         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1294         * tui/tui-data.c (~tui_gen_win_info): Remove.
1295         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1296         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1297         (tui_redisplay_readline, tui_mld_flush)
1298         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1299         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1300         (tui_data_window::erase_data_content)
1301         (tui_data_item_window::rerender)
1302         (tui_data_item_window::refresh_window): Update.
1303         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1304         (box_win, tui_gen_win_info::make_window)
1305         (tui_gen_win_info::make_visible): Update.
1306         (tui_delete_win): Remove.
1307         * tui/tui-winsource.c
1308         (tui_source_window_base::do_erase_source_content): Update.
1309         (tui_show_source_line, tui_source_window_base::update_tab_width)
1310         (tui_source_window_base::update_exec_info): Update.
1311         * tui/tui-data.h (struct curses_deleter): New.
1312         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1313         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1314
1315 2019-10-09  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1318
1319 2019-10-09  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1322         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1323
1324 2019-10-09  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1327         window height directly.
1328         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1329         declare.
1330         * tui/tui-layout.c (tui_default_win_height): Remove.
1331         (tui_default_win_viewport_height): Remove.
1332
1333 2019-10-09  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui.h: Remove comments.
1336
1337 2019-10-09  Tom de Vries  <tdevries@suse.de>
1338
1339         * python/lib/gdb/printer/bound_registers.py: Use
1340         '^builtin_type_bound128' as regexp argument for
1341         add_builtin_pretty_printer.
1342
1343 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1344
1345         * guile/guile.c (guile_extension_script_ops): Remove forward
1346         declaration and mark as static.
1347         (guile_script_ops): Likewise.
1348         (extension_language_guile): Move further down in the file so
1349         it can reference the definitions for guile_{extension_,}script_ops.
1350
1351 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1352
1353         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1354         except SORTL, DFLTCC, and KDSA.
1355
1356 2019-10-08  Tom Tromey  <tromey@adacore.com>
1357
1358         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1359         (struct safe_symbol_file_add_args): Remove.
1360
1361 2019-10-08  Tom Tromey  <tromey@adacore.com>
1362
1363         * windows-nat.c: Don't include buildsym-legacy.h.
1364
1365 2019-10-08  Tom Tromey  <tromey@adacore.com>
1366
1367         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1368
1369 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1370
1371         * gdbtypes.c (overload_debug): Move comment to header.
1372         * gdbtypes.h (overload_debug): Declare.
1373         * valops.c: Remove declaration of overload_debug, instead
1374         include gdbtypes.h.
1375
1376 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1377
1378         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1379         through _().
1380         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1381         move comment...
1382         * language.h (lang_frame_mismatch_warn): ... here. Also add
1383         declaration.
1384         * top.c (lang_frame_mismatch_warn): Remove declaration.
1385         (check_frame_language_change): Pass lang_frame_mismatch_warn
1386         through _().
1387
1388 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1389
1390         * c-lang.h (vtbl_ptr_name): Declare.
1391         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1392         it from the header.
1393         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1394
1395 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1398         gdb_static_assert.
1399
1400 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1401
1402         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1403         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1404         * ctfread.c: New file.
1405         * ctfread.h: New file.
1406         * elfread.c: Include ctfread.h.
1407         (struct elfinfo text_p): New member ctfsect.
1408         (elf_locate_sections): Mark CTF section.
1409         (elf_symfile_read): Call elfctf_build_psymtabs.
1410         * Makefile.in (LIBCTF): Add.
1411         (CLIBS): Use it.
1412         (CDEPS): Likewise.
1413         (DIST): Add ctfread.c.
1414
1415 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * ctfread.c (struct nextfield): Renamed to ...
1418         (struct ctf_nextfield): ... this.
1419         (struct field_info): Renamed to ...
1420         (strut ctf_field_info): ... this.
1421         (attach_fields_to_type): Update for renamed structures.
1422         (ctf_add_member_cb): Likewise.
1423         (ctf_add_enum_member_cb): Likewise.
1424         (process_struct_members): Likewise.
1425         (process_enum_type): Likewise.
1426
1427 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1428
1429         * tracectf.h: Rename, was ctf.h.
1430         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1431         * tracefile.c: Likewise.
1432         * tracepoint.c: Remove unused include ctf.h.
1433         * mi/mi-main.c: Likewise.
1434         * Makefile.in Replace ctf.c with tracectf.c.
1435
1436 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1437
1438         * version.in: Change version number to "9.0.50.DATE-git".
1439
1440 2019-10-03  Tom Tromey  <tom@tromey.com>
1441
1442         PR rust/24976:
1443         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1444
1445 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1448         cp_search_name_hash.
1449         * NEWS: Add entry about nested function support.
1450
1451 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1452             Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1455         for nested static variables when searchin VAR_DOMAIN.
1456         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1457         global scope, update comment.
1458         (add_partial_subprogram): Call add_partial_subprogram recursively
1459         for nested subroutines when processinng Fortran.
1460         (load_partial_dies): Process the child entities of a subprogram
1461         when processing Fortran.
1462         (partial_die_parent_scope): Handle building scope
1463         for Fortran nested functions.
1464         (process_die): Record that nested functions have a scope.
1465         (new_symbol): Always record Fortran subprograms on the global
1466         symbol list.
1467         (determine_prefix): How to build the prefix for Fortran
1468         subprograms.
1469
1470 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1473         have just sent the thread a SIGSTOP and are waiting for it to
1474         arrive.
1475
1476 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * btrace.c (btrace_add_pc): Remove whitespace before the template
1479         parameter in 'std::vector <...>'.
1480         (parse_xml_btrace_block): Likewise.
1481         (btrace_maint_decode_pt): Likewise.
1482         (btrace_maint_update_packets): Likewise.
1483         (btrace_maint_print_packets): Likewise.
1484         * btrace.h (struct btrace_maint_info): Likewise.
1485         * dwarf2read.c (struct type_unit_group): Likewise.
1486         (build_type_psymtabs_reader): Likewise.
1487         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1488         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1489         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1490
1491 2019-10-03  Tom de Vries  <tdevries@suse.de>
1492
1493         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1494         the first line of the help text for set/show style metadata.
1495
1496 2019-10-02  Tom Tromey  <tromey@adacore.com>
1497
1498         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1499         * gdbsupport/common-inferior.c: New file.
1500         * infcmd.c (startup_with_shell): Don't define.
1501         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1502         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1503         * inferior.h (startup_with_shell): Don't declare.
1504
1505 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1506
1507         * gdbsupport/gdb_assert.h: Include errors.h.
1508         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1509
1510 2019-10-02  Tom Tromey  <tromey@adacore.com>
1511
1512         * NEWS: Add $_ada_exception entry.
1513         * ada-lang.c (struct ada_catchpoint): Add constructor.
1514         <m_kind>: New member.
1515         (allocate_location_exception, re_set_exception): Remove
1516         "ex" parameter.
1517         (should_stop_exception): Compute $_ada_exception.
1518         (check_status_exception, print_it_exception)
1519         (print_one_exception, print_mention_exception): Remove
1520         "ex" parameter.
1521         (allocate_location_catch_exception, re_set_catch_exception)
1522         (check_status_exception, print_it_catch_exception)
1523         (print_one_catch_exception, print_mention_catch_exception)
1524         (print_recreate_catch_exception)
1525         (allocate_location_catch_exception_unhandled)
1526         (re_set_catch_exception_unhandled)
1527         (check_status_exception, print_it_catch_exception_unhandled)
1528         (print_one_catch_exception_unhandled)
1529         (print_mention_catch_exception_unhandled)
1530         (print_recreate_catch_exception_unhandled)
1531         (allocate_location_catch_assert, re_set_catch_assert)
1532         (check_status_assert, print_it_catch_assert)
1533         (print_one_catch_assert, print_mention_catch_assert)
1534         (print_recreate_catch_assert)
1535         (allocate_location_catch_handlers, re_set_catch_handlers)
1536         (check_status_handlers, print_it_catch_handlers)
1537         (print_one_catch_handlers, print_mention_catch_handlers)
1538         (print_recreate_catch_handlers): Remove.
1539         (create_ada_exception_catchpoint): Update.
1540         (initialize_ada_catchpoint_ops): Update.
1541
1542 2019-10-02  Tom Tromey  <tromey@adacore.com>
1543
1544         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1545         (create_excep_cond_exprs): Simplify exception string computation.
1546         (ada_exception_catchpoint_cond_string): Likewise.
1547
1548 2019-10-02  Tom Tromey  <tromey@adacore.com>
1549
1550         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1551         * ada-lang.c (lesseq_defined_than): Handle
1552         LOC_STATIC.
1553         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1554         parameter.
1555         (dwarf2_has_info): Likewise.
1556         (new_symbol): Set maybe_copied on symbol when
1557         appropriate.
1558         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1559         parameter.
1560         <can_copy>: New member.
1561         * elfread.c (record_minimal_symbol): Set maybe_copied
1562         on symbol when appropriate.
1563         (elf_symfile_read): Update call to dwarf2_has_info.
1564         * minsyms.c (lookup_minimal_symbol_linkage): New
1565         function.
1566         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1567         * symtab.c (get_symbol_address, get_msymbol_address):
1568         New functions.
1569         * symtab.h (get_symbol_address, get_msymbol_address):
1570         Declare.
1571         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1572         maybe_copied.
1573         (struct symbol, struct minimal_symbol) <maybe_copied>:
1574         New member.
1575
1576 2019-10-02  Tom Tromey  <tromey@adacore.com>
1577
1578         * source.c (struct current_source_location): New.
1579         (current_source_key): New global.
1580         (current_source_symtab, current_source_line)
1581         (current_source_pspace): Remove.
1582         (get_source_location): New function.
1583         (get_current_source_symtab_and_line)
1584         (set_default_source_symtab_and_line)
1585         (set_current_source_symtab_and_line)
1586         (clear_current_source_symtab_and_line, select_source_symtab)
1587         (info_source_command, print_source_lines_base)
1588         (info_line_command, search_command_helper, _initialize_source):
1589         Update.
1590
1591 2019-10-02  Tom Tromey  <tromey@adacore.com>
1592
1593         * source.c (select_source_symtab): Don't call
1594         decode_line_with_current_source.
1595
1596 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * symtab.c (lookup_global_symbol): Search global block.
1599
1600 2019-10-02  Tom Tromey  <tromey@adacore.com>
1601
1602         * coffread.c (process_coff_symbol): Update.
1603         * dwarf2read.c (var_decode_location, new_symbol): Update.
1604         * mdebugread.c (parse_symbol): Update.
1605         * objfiles.c (relocate_one_symbol): Update.
1606         * stabsread.c (define_symbol, fix_common_block)
1607         (scan_file_globals): Update.
1608         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1609         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1610         * xcoffread.c (process_xcoff_symbol): Update.
1611
1612 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1613
1614         * MAINTAINERS: Update my email address.
1615
1616 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1619         std::vector.
1620         (build_type_psymtabs_reader): Update for std::vector.
1621         (build_type_psymtab_dependencies): Likewise.
1622         * dwarf2read.h: Remove use of DEF_VEC_P.
1623         (typedef sig_type_ptr): Delete.
1624
1625 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1628         to std::vector.
1629         (btrace_maint_decode_pt): Likewise, and move allocation of the
1630         vector outside of the loop.
1631         (btrace_maint_update_packets): Update to handle change from VEC to
1632         std::vector.
1633         (btrace_maint_print_packets): Likewise.
1634         (maint_info_btrace_cmd): Likewise.
1635         * btrace.h: Remove use of DEF_VEC_O.
1636         (typedef btrace_pt_packet_s): Delete.
1637         (struct btrace_maint_info) <packets>: Change fromm VEC to
1638         std::vector.
1639         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1640
1641 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1644         make accesses into the vector constant references.
1645         (btrace_add_pc): Update for std::vector.
1646         (btrace_stitch_bts): Likewise.
1647         (parse_xml_btrace_block): Likewise.
1648         (btrace_maint_update_packets): Likewise.
1649         (btrace_maint_print_packets): Likewise.
1650         (maint_info_btrace_cmd): Likewise.
1651         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1652         std::vector.
1653         (btrace_data::empty): Likewise.
1654         (btrace_data_append): Likewise.
1655         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1656         (typedef btrace_block_s): Delete.
1657         (struct btrace_block): Add constructor.
1658         (struct btrace_data_bts) <blocks>: Change to std::vector.
1659         * nat/linux-btrace.c (perf_event_read_bts): Update for
1660         std::vector.
1661         (linux_read_bts): Likewise.
1662
1663 2019-10-01  Tom Tromey  <tom@tromey.com>
1664
1665         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1666
1667 2019-10-01  Tom Tromey  <tom@tromey.com>
1668
1669         * stack.c (print_frame, info_frame_command_core): Use
1670         styled_string.
1671         * linux-thread-db.c (try_thread_db_load_1)
1672         (try_thread_db_load_from_pdir_1): Use styled_string.
1673         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1674         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1675         (maybe_print_unsupported_script_warning)
1676         (maybe_print_script_not_found_warning): Use styled_string.
1677         * ada-lang.c (user_select_syms): Use styled_string.
1678
1679 2019-10-01  Tom Tromey  <tom@tromey.com>
1680
1681         * p-lang.c (pascal_printstr): Use metadata style.
1682         * value.c (show_convenience): Use metadata style.
1683         * valprint.c (valprint_check_validity, val_print_optimized_out)
1684         (val_print_not_saved, val_print_unavailable)
1685         (val_print_invalid_address, generic_val_print, val_print)
1686         (value_check_printable, val_print_array_elements): Use metadata
1687         style.
1688         * ui-out.h (class ui_out) <field_fmt>: New overload.
1689         <do_field_fmt>: Add style parameter.
1690         * ui-out.c (ui_out::field_fmt): New overload.
1691         * typeprint.c (type_print_unknown_return_type)
1692         (val_print_not_allocated, val_print_not_associated): Use metadata
1693         style.
1694         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1695         parameter.
1696         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1697         * tracepoint.c (tvariables_info_1): Use metadata style.
1698         * stack.c (print_frame_arg, print_frame_info, print_frame)
1699         (info_frame_command_core): Use metadata style.
1700         * skip.c (info_skip_command): Use metadata style.
1701         * rust-lang.c (rust_print_enum): Use metadata style.
1702         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1703         metadata style.
1704         * python/py-framefilter.c (py_print_single_arg): Use metadata
1705         style.
1706         * printcmd.c (do_one_display, print_variable_and_value): Use
1707         metadata style.
1708         * p-valprint.c (pascal_val_print)
1709         (pascal_object_print_value_fields): Use metadata style.
1710         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1711         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1712         parameter.
1713         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1714         * m2-valprint.c (m2_print_long_set): Use metadata style.
1715         * m2-typeprint.c (m2_print_type): Use metadata style.
1716         * infcmd.c (print_return_value_1): Use metadata style.
1717         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1718         * f-valprint.c (info_common_command_for_block): Use metadata
1719         style.
1720         * f-typeprint.c (f_type_print_base): Use metadata style.
1721         * expprint.c (print_subexp_standard): Use metadata style.
1722         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1723         * cli/cli-style.h (class cli_style_option): Add constructor.
1724         (metadata_style): Declare.
1725         * cli/cli-style.c (metadata_style): New global.
1726         (_initialize_cli_style): Register metadata style.
1727         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1728         parameter.
1729         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1730         * c-typeprint.c (c_type_print_base_struct_union)
1731         (c_type_print_base_1): Use metadata style.
1732         * breakpoint.c (watchpoint_value_print)
1733         (print_one_breakpoint_location): Use metadata style.
1734         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1735         style.
1736         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1737         style.
1738         * ada-valprint.c (val_print_packed_array_elements, printstr)
1739         (print_field_values, ada_val_print_ref, ada_val_print): Use
1740         metadata style.
1741         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1742         style.
1743         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1744         style.
1745         * ada-lang.c (user_select_syms): Use metadata style.
1746
1747 2019-10-01  Tom Tromey  <tom@tromey.com>
1748
1749         * cli/cli-cmds.c (pwd_command): Style output.
1750
1751 2019-10-01  Pedro Alves  <palves@redhat.com>
1752             Tom Tromey  <tom@tromey.com>
1753
1754         * symtab.c (print_symbol_info): Use %ps.
1755         (print_msymbol_info): Use %ps.
1756         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1757         * printcmd.c (print_variable_and_value): Use %ps.
1758         * macrocmd.c (show_pp_source_pos): Use %ps.
1759         * infrun.c (print_exited_reason): Use ui_out::message.
1760         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1761         (describe_other_breakpoints): Use ui_out::message and new
1762         formats.
1763         (say_where): Use new formats.
1764         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1765         and new formats.
1766
1767 2019-10-01  Pedro Alves  <palves@redhat.com>
1768             Tom Tromey  <tom@tromey.com>
1769
1770         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1771         (test_gdb_formats): New function.
1772         (run_tests): Call it.
1773         (test_format_specifier): Update.
1774         * utils.h (fputs_filtered): Update comment.
1775         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1776         (fputs_styled_unfiltered): Declare.
1777         * utils.c (fputs_styled_unfiltered): New function.
1778         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1779         (vfprintf_filtered): Update.
1780         (vfprintf_unfiltered, vprintf_filtered): Update.
1781         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1782         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1783         disallow_ui_out_field>: New constants.
1784         (enum class field_kind): New.
1785         (struct base_field_s, struct signed_field_s): New.
1786         (signed_field): New function.
1787         (struct string_field_s): New.
1788         (string_field): New function.
1789         (struct styled_string_s): New.
1790         (styled_string): New function.
1791         (class ui_out) <message>: Add comment.
1792         <vmessage, call_do_message>: New methods.
1793         <do_message>: Add style parameter.
1794         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1795         methods.
1796         (ui_out::message): Rewrite.
1797         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1798         parameter.
1799         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1800         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1801         gdb_extensions parameter.
1802         (class format_piece): Add parameter to constructor.
1803         (n_int_args): New field.
1804         * gdbsupport/format.c (format_pieces::format_pieces): Add
1805         gdb_extensions parameter.  Handle '*'.
1806         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1807         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1808         vfprintf_styled_no_gdbfmt.
1809         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1810         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1811         unfiltered output.
1812         * ui-style.h (struct ui_file_style) <ptr>: New method.
1813
1814 2019-10-01  Tom Tromey  <tom@tromey.com>
1815
1816         * unittests/format_pieces-selftests.c: Update.  Add final format.
1817         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1818         empty literal pieces.
1819
1820 2019-10-01  Tom Tromey  <tom@tromey.com>
1821
1822         * ui-out.h (enum class ui_out_style_kind): Remove.
1823         (class ui_out) <field_string, field_stsream, do_field_string>:
1824         Change type of "style".
1825         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1826         (ui_out::field_string): Update.
1827         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1828         of "style".
1829         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1830         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1831         * stack.c (print_frame_arg, print_frame_info, print_frame):
1832         Update.
1833         * source.c (print_source_lines_base): Update.
1834         * solib.c (info_sharedlibrary_command): Update.
1835         * skip.c (info_skip_command): Update.
1836         * record-btrace.c (btrace_call_history_src_line)
1837         (btrace_call_history): Update.
1838         * python/py-framefilter.c (py_print_frame): Update.
1839         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1840         "style".
1841         * mi/mi-out.c (mi_ui_out::do_table_header)
1842         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1843         (mi_ui_out::do_field_string): Update.
1844         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1845         Update.
1846         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1847         "style".
1848         * cli-out.c (cli_ui_out::do_table_header)
1849         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1850         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1851         (cli_ui_out::do_field_fmt): Update.
1852         * breakpoint.c (print_breakpoint_location): Update.
1853         (update_static_tracepoint): Update.
1854
1855 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1856
1857         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1858         conversion of gdb_datadir.
1859         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1860         remove not needed c_str ().
1861
1862 2019-09-30  Ali Tamur <tamur@google.com>
1863
1864         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1865         (dwarf2_string_attr): Likewise.
1866
1867 2019-09-30  Ali Tamur <tamur@google.com>
1868
1869         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1870         (process_full_type_unit): Likewise.
1871         (dump_die_shallow): Likewise.
1872         (cu_debug_loc_section): Likewise.
1873
1874 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1875
1876         * minsyms.c (compare_minimal_symbols): Rename to...
1877         (minimal_symbol_is_less_than): ...this, and adjust to STL
1878         conventions (return bool, take arguments as references)
1879         (minimal_symbol_reader::install): Call std::sort instead
1880         of qsort.
1881
1882 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1883
1884         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1885         hash and why.
1886         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1887         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1888
1889 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1890
1891         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1892         * psympriv.h (add_psymbol_to_list): Move comment here and update
1893         it.
1894
1895 2019-09-29  Tom de Vries  <tdevries@suse.de>
1896
1897         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1898         Use $tmpdir/$(basename "$output_file").dwz instead of
1899         "${output_file}.dwz".
1900
1901 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1902
1903         PR gdb/25045
1904         * hppa-linux-nat.c: Include gdbarch.h.
1905
1906 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1907
1908         * blockframe.c (find_pc_partial_function): Change return type to bool.
1909         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1910         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1911         (stub_gnu_ifunc_resolve_name): Likewise.
1912         * symtab.c (compare_filenames_for_search): Likewise.
1913         (compare_glob_filenames_for_search): Likewise.
1914         (matching_obj_sections): Likewise.
1915         (symbol_matches_domain): Likewise.
1916         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1917         (find_line_pc): Change return type to bool.
1918         (find_line_pc_range): Likewise.
1919         (producer_is_realview): Likewise.
1920         * symtab.h (symbol_matches_domain): Likewise.
1921         (find_pc_partial_function): Likewise.
1922         (find_pc_line_pc_range): Likewise.
1923         (in_gnu_ifunc_stub): Likewise.
1924         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1925         (find_line_pc): Likewise.
1926         (find_line_pc_range): Likewise.
1927         (matching_obj_sections): Likewise.
1928         (find_line_symtab): Change out parameter to bool.
1929         (producer_is_realview): Change return type to bool.
1930         (compare_filenames_for_search): Likewise.
1931         (compare_glob_filenames_for_search): Likewise.
1932
1933 2019-09-26  Tom Tromey  <tom@tromey.com>
1934
1935         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1936         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1937         * gdb_usleep.h: Remove.
1938         * gdb_usleep.c: Remove.
1939         * utils.c: Don't include gdb_usleep.h.
1940
1941 2019-09-26  Tom Tromey  <tromey@adacore.com>
1942
1943         * python/py-type.c (type_to_type_object): Call check_typedef
1944         for stub types.
1945
1946 2019-09-26  Tom Tromey  <tom@tromey.com>
1947
1948         * utils.h (initialize_utils): Don't declare.
1949         * top.c (gdb_init): Don't call initialize_utils.
1950         * utils.c (initialize_utils): Remove.  Move contents...
1951         (_initialize_utils): ... here.
1952
1953 2019-09-25  Tom Tromey  <tom@tromey.com>
1954
1955         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1956         * utils.h (make_hex_string): Don't declare.
1957         * utils.c (make_hex_string): Remove.
1958
1959 2019-09-24  Tom de Vries  <tdevries@suse.de>
1960
1961         PR gdb/23815
1962         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1963         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1964
1965 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1966
1967         * NEWS: Mention new simulator port for PRU.
1968
1969 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1970
1971         * ada-exp.y (write_object_remaining): Update.
1972         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1973         and eliminate the static buffer.
1974         (ada_decode_symbol): Update.
1975         (ada_la_decode): Update.
1976         (ada_sniff_from_mangled_name): Update.
1977         (is_valid_name_for_wild_match): Update.
1978         (ada_lookup_name_info::matches): Update and simplify.
1979         (name_matches_regex): Update.
1980         (ada_add_global_exceptions): Update.
1981         * ada-lang.h (ada_decode): Update signature.
1982         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1983         * dwarf-index-write.c (debug_names::insert): Update.
1984
1985 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1986
1987         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1988         formatting.
1989
1990 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1993         Change "nonzero" to "true" in documentation.
1994
1995 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1996
1997         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1998         (_initialize_darwin_solib): Don't set
1999         darwin_so_ops.lookup_lib_global_symbol.
2000         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2001         set_gdbarch_iterate_over_objfiles_in_search_order.
2002         (elf_lookup_lib_symbol): Rename to...
2003         (svr4_iterate_over_objfiles_in_search_order): this, and update
2004         to iterate semantics.
2005         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2006         * solib.c (solib_global_lookup): Remove.
2007         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2008         (solib_global_lookup): Remove.
2009         * symtab.c (lookup_global_or_static_symbol): Remove call to
2010         solib_global_lookup.
2011
2012 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2013
2014         * NEWS: Move entries about default MI version now being
2015         version 3, and about the GDB/MI fix for multi-location
2016         breakpoints to the "since GDB 8.3" section.
2017
2018 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2019
2020         GDB 8.3.1 released.
2021
2022 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2023
2024         * NEWS: Mention that Cell/B.E. debugging support was removed.
2025         * MAINTAINERS: Remove spu target.
2026
2027         * config/djgpp/fnchange.lst: Remove entries for removed files.
2028
2029         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2030         spu-multiarch.o, and spu-tdep.o.
2031         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2032         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2033         spu-multiarch.c, and spu-tdep.c.
2034         * spu-linux-nat.c: Remove file.
2035         * spu-multiarch.c: Remove file.
2036         * spu-tdep.c: Remove file.
2037         * spu-tdep.h: Remove file.
2038         * solib-spu.c: Remove file.
2039         * solib-spu.h: Remove file.
2040
2041         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2042         * configure.nat (spu-linux): Remove.
2043         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2044         solib-multiarch.o from gdb_target_obs.
2045         (spu*-*-*): Remove.
2046
2047         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2048         feature flag.
2049         (ppc_linux_no_features): Update.
2050         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2051         Cell/B.E. support.
2052         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2053         (tdesc_powerpc_cell64l): Likewise.
2054         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2055         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2056         Cell/B.E. support.
2057         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2058         Do not include "features/rs6000/powerpc-cell32l.c" or
2059         "features/rs6000/powerpc-cell64l.c".
2060         (ppc_linux_spu_section): Remove.
2061         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2062         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2063         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2064         (ppc_linux_spe_context_lookup): Remove.
2065         (ppc_linux_spe_context_inferior_created): Remove.
2066         (ppc_linux_spe_context_solib_loaded): Remove.
2067         (ppc_linux_spe_context_solib_unloaded): Remove.
2068         (ppc_linux_spe_context): Remove.
2069         (struct ppu2spu_cache): Remove.
2070         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2071         (struct ppu2spu_data): Remove.
2072         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2073         ppu2spu_unwind): Remove.
2074         (ppc_linux_init_abi): Remove Cell/B.E. support.
2075         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2076
2077         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2078         (rs6000/powerpc-cell64l-expedite): Likewise
2079         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2080         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2081         rs6000/powerpc-cell64l.xml.
2082         * features/rs6000/powerpc-cell32l.xml: Remove.
2083         * features/rs6000/powerpc-cell64l.xml: Likewise.
2084         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2085         * features/rs6000/powerpc-cell64l.c: Likewise.
2086         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2087         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2088         * regformats/reg-spu.dat: Remove.
2089
2090         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2091         * corelow.c (struct spuid_list): Remove.
2092         (add_to_spuid_list): Remove.
2093         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2094         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2095         (remote_protocol_features): Remove associated entries.
2096         (_initialize_remote): No longer initialize them.
2097         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2098         * linux-nat.c (SPUFS_MAGIC): Remove.
2099         (linux_proc_xfer_spu): Remove.
2100         (spu_enumerate_spu_ids): Remove.
2101         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2102         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2103         (linux_make_corefile_notes): No longer call it.
2104
2105         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2106         (cooked_write_test): Likewise.
2107
2108 2019-09-20  Tom Tromey  <tom@tromey.com>
2109
2110         * NEWS: Mention case-sensitivity of TUI commands.
2111         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2112         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2113         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2114
2115 2019-09-20  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-source.c (tui_source_window::set_contents): Use
2118         make_unique_xstrdup.
2119         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2120         make_unique_xstrdup.
2121
2122 2019-09-20  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.c: Remove separator comments.
2125         * tui/tui-layout.c: Remove separator comments.
2126         * tui/tui-win.c: Remove separator comments.
2127         * tui/tui-wingeneral.c: Remove separator comments.
2128
2129 2019-09-20  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui.h (strcat_to_buf): Don't declare.
2132         * tui/tui.c (strcat_to_buf): Remove.
2133
2134 2019-09-20  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2137         from "fullname".
2138         * tui/tui-source.c (tui_source_window::set_contents)
2139         (tui_source_window::location_matches_p)
2140         (tui_source_window::maybe_update): Update.
2141
2142 2019-09-20  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2145         Update.
2146         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2147         prefix.
2148         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2149         (tui_data_window::line_from_reg_element_no)
2150         (tui_data_window::first_reg_element_no_inline)
2151         (tui_data_window::show_registers)
2152         (tui_data_window::show_register_group)
2153         (tui_data_window::display_registers_from)
2154         (tui_data_window::display_registers_from_line)
2155         (tui_data_window::first_data_item_displayed)
2156         (tui_data_window::delete_data_content_windows)
2157         (tui_data_window::erase_data_content)
2158         (tui_data_window::do_scroll_vertical)
2159         (tui_data_window::refresh_window)
2160         (tui_data_window::check_register_values): Update.
2161
2162 2019-09-20  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2165         (struct tui_locator_window) <full_name, proc_name>: Now
2166         std::string.
2167         * tui/tui-stack.c (tui_locator_window::make_status_line)
2168         (tui_locator_window::set_locator_fullname)
2169         (tui_locator_window::set_locator_info): Update.
2170         * tui/tui-source.c (tui_source_window::set_contents)
2171         (tui_source_window::showing_source_p): Update.
2172
2173 2019-09-20  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2176         Don't call tui_locator_win_info_ptr.
2177
2178 2019-09-20  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2181
2182 2019-09-20  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2185         height for locator.
2186         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2187         * tui/tui-layout.c (show_source_disasm_command, show_data)
2188         (show_source_or_disasm_and_command): Use 1 as height for locator.
2189
2190 2019-09-20  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui.c (tui_enable): Update.
2193         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2194         Update.
2195         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2196         Update.
2197         * tui/tui-data.c (win_resized): Now bool.
2198         (tui_win_resized): Return bool.
2199         (tui_set_win_resized_to): Accept a bool.
2200
2201 2019-09-20  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2204         Change type of "refresh_values_only".
2205         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2206         type of "refresh_values_only".
2207
2208 2019-09-20  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2211         std::string.
2212         (tui_disassemble): Add "pos" parameter.
2213         (tui_disasm_window::set_contents): Simplify.
2214
2215 2019-09-20  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (struct tui_source_window_base)
2218         <show_source_content>: Now private.
2219         * tui/tui-winsource.c
2220         (tui_source_window_base::show_source_content): Don't handle empty
2221         content case.
2222
2223 2019-09-20  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-layout.c (show_source_disasm_command)
2226         (show_source_or_disasm_and_command): Don't call
2227         show_source_content.
2228
2229 2019-09-20  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2232         Declare.
2233         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2234         from tui_make_status_line.
2235         (tui_locator_window::rerender): Update.
2236
2237 2019-09-20  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2240         (tui_locator_window::rerender): Update.
2241
2242 2019-09-20  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.h (struct tui_source_window_base)
2245         <~tui_source_window_base>: Don't declare.
2246         <fullname>: Remove.
2247         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2248         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2249         member.
2250         * tui/tui-source.c (tui_source_window::set_contents): Update.
2251         (tui_source_window::location_matches_p)
2252         (tui_source_window::maybe_update): Update.
2253
2254 2019-09-20  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.h (~tui_source_element): Remove.
2257         (tui_source_element): Update.
2258         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2259         * tui/tui-winsource.c (tui_show_source_line): Update.
2260         * tui/tui-source.c (tui_source_window::set_contents): Update.
2261         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2262
2263 2019-09-20  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2266         declare.
2267         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2268         tui_clear_source_windows_detail.
2269         * tui/tui-winsource.h (struct tui_source_window_base)
2270         <clear_detail>: Don't declare.
2271         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2272         Remove.
2273         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2274
2275 2019-09-20  Tom Tromey  <tromey@adacore.com>
2276
2277         PR ada/24919:
2278         * block.c (contained_in): Fix final return value.
2279
2280 2019-09-20  Alan Modra  <amodra@gmail.com>
2281
2282         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2283         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2284         (read_indirect_string_from_dwz): Use bfd accessor.
2285         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2286         * machoread.c (macho_symfile_read_all_oso): Likewise.
2287         * solib.c (solib_bfd_open): Likewise.
2288
2289 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2290
2291         * eval.c: Move declaration of overload_resolution to...
2292         * value.h: ...here.
2293
2294 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2297         * arm-linux-tdep.c: Likewise.
2298         * arm-nbsd-nat.c: Likewise.
2299         * arm-tdep.h: Declare arm_apcs_32.
2300         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2301
2302 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2303
2304         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2305         * dwarf2read.h: Declare dwarf_always_disassemble.
2306
2307 2019-09-19  Tom de Vries  <tdevries@suse.de>
2308
2309         PR gdb/25009
2310         * source-cache.c (source_cache::ensure): Catch exception thrown during
2311         construction of the highlighter.
2312
2313 2019-09-18  Alan Modra  <amodra@gmail.com>
2314
2315         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2316         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2317         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2318         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2319         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2320         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2321         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2322         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2323         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2324         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2325         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2326         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2327         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2328         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2329         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2330         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2331         * mi/mi-interp.c: Update throughout for bfd section macro and
2332         function changes.
2333         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2334         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2335
2336 2019-09-18  Tom Tromey  <tom@tromey.com>
2337
2338         * NEWS: Add entry.
2339         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2340         call rl_initialize.
2341         (tui_enable): Do not call rl_initialize.
2342
2343 2019-09-18  Christian Groessler  <chris@groessler.org>
2344
2345         * alpha-linux-nat.c: Include gdbarch.h.
2346
2347 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2348
2349         * ui-file.c: Include cli/cli-style.h.
2350         (term_cli_styling): Remove cli_styling declaration.
2351
2352 2019-09-18  Alan Modra  <amodra@gmail.com>
2353
2354         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2355         to bfd_asymbol_section.
2356
2357 2019-09-18  Alan Modra  <amodra@gmail.com>
2358
2359         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2360         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2361         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2362
2363 2019-09-18  Alan Modra  <amodra@gmail.com>
2364
2365         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2366         * spu-linux-nat.c (spu_bfd_open): Likewise.
2367
2368 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2369
2370         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2371         to bool to match definition in dwarf2read.c.
2372
2373 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2374
2375         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2376         (print_signatures): Likewise.
2377         (trust_pad_over_xvs): Likewise.
2378         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2379         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2380         * arm-linux-nat.c (arm_apcs_32): Likewise.
2381         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2382         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2383         * arm-tdep.c (arm_debug): Likewise.
2384         (arm_apcs_32): Likewise.
2385         * auto-load.c (debug_auto_load): Likewise.
2386         (auto_load_gdb_scripts): Likewise.
2387         (global_auto_load): Likewise.
2388         (auto_load_local_gdbinit): Likewise.
2389         (auto_load_local_gdbinit_loaded): Likewise.
2390         * auto-load.h (global_auto_load): Likewise.
2391         (auto_load_local_gdbinit): Likewise.
2392         (auto_load_local_gdbinit_loaded): Likewise.
2393         * breakpoint.c (disconnected_dprintf): Likewise.
2394         (breakpoint_proceeded): Likewise.
2395         (automatic_hardware_breakpoints): Likewise.
2396         (always_inserted_mode): Likewise.
2397         (target_exact_watchpoints): Likewise.
2398         (_initialize_breakpoint): Update.
2399         * breakpoint.h (target_exact_watchpoints): Change to bool.
2400         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2401         * cli/cli-cmds.c (trace_commands): Likewise.
2402         * cli/cli-cmds.h (trace_commands): Likewise.
2403         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2404         to bool*.
2405         * cli/cli-logging.c (logging_overwrite): Change to bool.
2406         (logging_redirect): Likewise.
2407         (debug_redirect): Likewise.
2408         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2409         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2410         to bool.
2411         <boolean_option_def>: Update.
2412         (struct flag_option_def): Change default type of Context to bool
2413         from int.
2414         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2415         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2416         (get_setshow_command_value_string): Likewise.
2417         * cli/cli-style.c (cli_styling): Change to bool.
2418         (source_styling): Likewise.
2419         * cli/cli-style.h (source_styling): Likewise.
2420         (cli_styling): Likewise.
2421         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2422         to bool.
2423         * command.h (var_types): Update comment.
2424         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2425         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2426         bool.
2427         (debug_compile_cplus_scopes): Likewise.
2428         * compile/compile-internal.h (compile_debug): Likewise.
2429         * compile/compile.c (compile_debug): Likewise.
2430         (struct compile_options) <raw>: Likewise.
2431         * cp-support.c (catch_demangler_crashes): Likewise.
2432         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2433         (usr_cmd_cris_dwarf2_cfi): Likewise.
2434         * csky-tdep.c (csky_debug): Likewise.
2435         * darwin-nat.c (enable_mach_exceptions): Likewise.
2436         * dcache.c (dcache_enabled_p): Likewise.
2437         * defs.h (info_verbose): Likewise.
2438         * demangle.c (demangle): Likewise.
2439         (asm_demangle): Likewise.
2440         * dwarf-index-cache.c (debug_index_cache): Likewise.
2441         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2442         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2443         * dwarf2read.c (check_physname): Likewise.
2444         (use_deprecated_index_sections): Likewise.
2445         (dwarf_always_disassemble): Likewise.
2446         * eval.c (overload_resolution): Likewise.
2447         * event-top.c (set_editing_cmd_var): Likewise.
2448         (exec_done_display_p): Likewise.
2449         * event-top.h (set_editing_cmd_var): Likewise.
2450         (exec_done_display_p): Likewise.
2451         * exec.c (write_files): Likewise.
2452         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2453         (debug_fbsd_nat): Likewise.
2454         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2455         Likewise.
2456         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2457         <backtrace_past_entry> Likewise.
2458         * gdb-demangle.h (demangle): Likewise.
2459         (asm_demangle): Likewise.
2460         * gdb_bfd.c (bfd_sharing): Likewise.
2461         * gdbcore.h (write_files): Likewise.
2462         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2463         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2464         * gdbthread.h (print_thread_events): Likewise.
2465         * gdbtypes.c (opaque_type_resolution): Likewise.
2466         (strict_type_checking): Likewise.
2467         * gnu-nat.c (gnu_debug_flag): Likewise.
2468         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2469         * guile/scm-param.c (pascm_variable): Add boolval.
2470         (add_setshow_generic): Update.
2471         (pascm_param_value): Update.
2472         (pascm_set_param_value_x): Update.
2473         * hppa-tdep.c (hppa_debug): Change to bool..
2474         * infcall.c (may_call_functions_p): Likewise.
2475         (coerce_float_to_double_p): Likewise.
2476         (unwind_on_signal_p): Likewise.
2477         (unwind_on_terminating_exception_p): Likewise.
2478         * infcmd.c (startup_with_shell): Likewise.
2479         * inferior.c (print_inferior_events): Likewise.
2480         * inferior.h (startup_with_shell): Likewise.
2481         (print_inferior_events): Likewise.
2482         * infrun.c (step_stop_if_no_debug): Likewise.
2483         (detach_fork): Likewise.
2484         (debug_displaced): Likewise.
2485         (disable_randomization): Likewise.
2486         (non_stop): Likewise.
2487         (non_stop_1): Likewise.
2488         (observer_mode): Likewise.
2489         (observer_mode_1): Likewise.
2490         (set_observer_mode): Update.
2491         (sched_multi): Change to bool.
2492         * infrun.h (debug_displaced): Likewise.
2493         (sched_multi): Likewise.
2494         (step_stop_if_no_debug): Likewise.
2495         (non_stop): Likewise.
2496         (disable_randomization): Likewise.
2497         * linux-tdep.c (use_coredump_filter): Likewise.
2498         (dump_excluded_mappings): Likewise.
2499         * linux-thread-db.c (auto_load_thread_db): Likewise.
2500         (check_thread_db_on_load): Likewise.
2501         * main.c (captured_main_1): Update.
2502         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2503         xx2_opt, boolean_opt>: Change to bool.
2504         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2505         * maint.c (maintenance_profile_p): Likewise.
2506         (per_command_time): Likewise.
2507         (per_command_space): Likewise.
2508         (per_command_symtab): Likewise.
2509         * memattr.c (inaccessible_by_default): Likewise.
2510         * mi/mi-main.c (mi_async): Likewise.
2511         (mi_async_1): Likewise.
2512         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2513         * nat/fork-inferior.h (startup_with_shell): Likewise.
2514         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2515         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2516         * nios2-tdep.c (nios2_debug): Likewise.
2517         * or1k-tdep.c (or1k_debug): Likewise.
2518         * parse.c (parser_debug): Likewise.
2519         * parser-defs.h (parser_debug): Likewise.
2520         * printcmd.c (print_symbol_filename): Likewise.
2521         * proc-api.c (procfs_trace): Likewise.
2522         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2523         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2524         (set_parameter_value): Update.
2525         (add_setshow_generic): Update.
2526         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2527         to bool*.
2528         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2529         int*.
2530         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2531         * record-btrace.c (record_btrace_target::store_registers): Update.
2532         * record-full.c (record_full_memory_query): Change to bool.
2533         (record_full_stop_at_limit): Likewise.
2534         * record-full.h (record_full_memory_query): Likewise.
2535         * remote-notif.c (notif_debug): Likewise.
2536         * remote-notif.h (notif_debug): Likewise.
2537         * remote.c (use_range_stepping): Likewise.
2538         (interrupt_on_connect): Likewise.
2539         (remote_break): Likewise.
2540         * ser-tcp.c (tcp_auto_retry): Likewise.
2541         * ser-unix.c (serial_hwflow): Likewise.
2542         * skip.c (debug_skip): Likewise.
2543         * solib-aix.c (solib_aix_debug): Likewise.
2544         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2545         (spu_auto_flush_cache_p): Likewise.
2546         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2547         Likewise.
2548         (struct info_print_options) <quiet>: Likewise.
2549         * symfile-debug.c (debug_symfile): Likewise.
2550         * symfile.c (auto_solib_add): Likewise.
2551         (separate_debug_file_debug): Likewise.
2552         * symfile.h (auto_solib_add): Likewise.
2553         (separate_debug_file_debug): Likewise.
2554         * symtab.c (basenames_may_differ): Likewise.
2555         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2556         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2557         (struct info_types_options) <quiet>: Likewise.
2558         * symtab.h (demangle): Likewise.
2559         (basenames_may_differ): Likewise.
2560         * target-dcache.c (stack_cache_enabled_1): Likewise.
2561         (code_cache_enabled_1): Likewise.
2562         * target.c (trust_readonly): Likewise.
2563         (may_write_registers): Likewise.
2564         (may_write_memory): Likewise.
2565         (may_insert_breakpoints): Likewise.
2566         (may_insert_tracepoints): Likewise.
2567         (may_insert_fast_tracepoints): Likewise.
2568         (may_stop): Likewise.
2569         (auto_connect_native_target): Likewise.
2570         (target_stop_and_wait): Update.
2571         (target_async_permitted): Change to bool.
2572         (target_async_permitted_1): Likewise.
2573         (may_write_registers_1): Likewise.
2574         (may_write_memory_1): Likewise.
2575         (may_insert_breakpoints_1): Likewise.
2576         (may_insert_tracepoints_1): Likewise.
2577         (may_insert_fast_tracepoints_1): Likewise.
2578         (may_stop_1): Likewise.
2579         * target.h (target_async_permitted): Likewise.
2580         (may_write_registers): Likewise.
2581         (may_write_memory): Likewise.
2582         (may_insert_breakpoints): Likewise.
2583         (may_insert_tracepoints): Likewise.
2584         (may_insert_fast_tracepoints): Likewise.
2585         (may_stop): Likewise.
2586         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2587         (make_thread_apply_all_options_def_group): Change argument from int*
2588         to bool*.
2589         (thread_apply_all_command): Update.
2590         (print_thread_events): Change to bool.
2591         * top.c (confirm): Likewise.
2592         (command_editing_p): Likewise.
2593         (history_expansion_p): Likewise.
2594         (write_history_p): Likewise.
2595         (info_verbose): Likewise.
2596         * top.h (confirm): Likewise.
2597         (history_expansion_p): Likewise.
2598         * tracepoint.c (disconnected_tracing): Likewise.
2599         (circular_trace_buffer): Likewise.
2600         * typeprint.c (print_methods): Likewise.
2601         (print_typedefs): Likewise.
2602         * utils.c (debug_timestamp): Likewise.
2603         (sevenbit_strings): Likewise.
2604         (pagination_enabled): Likewise.
2605         * utils.h (sevenbit_strings): Likewise.
2606         (pagination_enabled): Likewise.
2607         * valops.c (overload_resolution): Likewise.
2608         * valprint.h (struct value_print_options) <prettyformat_arrays,
2609         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2610         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2611         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2612         Likewise.
2613         * windows-nat.c (new_console): Likewise.
2614         (cygwin_exceptions): Likewise.
2615         (new_group): Likewise.
2616         (debug_exec): Likewise.
2617         (debug_events): Likewise.
2618         (debug_memory): Likewise.
2619         (debug_exceptions): Likewise.
2620         (useshell): Likewise.
2621         * windows-tdep.c (maint_display_all_tib): Likewise.
2622         * xml-support.c (debug_xml): Likewise.
2623
2624 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2625
2626         * source.c (prepare_path_for_appending): New function.
2627         (openp): Make use of new function.
2628         (find_and_open_source): Search for the compilation directory and
2629         source file as a relative path beneath the directory search path.
2630
2631 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * source-cache.c (source_cache::get_line_charpos): Catch
2634         exceptions and return false, this matches the behaviour documented
2635         in the header file.
2636
2637 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2638
2639         * ada-tasks.c (info_task): Remove quoting of the task's name.
2640
2641 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2642
2643         * symfile.c (auto_solib_add): Replace comment with a reference
2644         to the header file.
2645
2646 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2647
2648         * NEWS: Mention that gdb can now be compiled with Python 3
2649         on Windows.
2650
2651 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * maint.c (maint_print_section_data::maint_print_section_data):
2654         Force use of 'float log10 (float)' by casting the argument to
2655         float.
2656
2657 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * maint.c: Add 'cmath' include.
2660         (struct maint_print_section_data): New structure.
2661         (print_section_index): New function.
2662         (print_bfd_section_info): Add header comment, small whitespace
2663         cleanup, and update to call new print_section_index function.
2664         (print_objfile_section_info): Likewise.
2665         (maint_obj_section_from_bfd_section): New function.
2666         (print_bfd_section_info_maybe_relocated): New function.
2667         (maintenance_info_sections): Add header comment, always use
2668         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2669
2670 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2673         inner scope, add check that the objfile has psymtabs before
2674         checking psymtabs_addrmap.
2675         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2676
2677 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2678
2679         * NEWS: Announce that Ada task names are now shown at more places,
2680         and between quotes (except in info task output).
2681         * gdb/ada-tasks.c (task_to_str): New function.
2682         (display_current_task_id): Call task_to_str.
2683         (task_command_1): Likewise.
2684         (print_ada_task_info): In non-mi mode, Properly align headers and data
2685         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2686
2687 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2688
2689         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2690         prstatus.pr_lwp.pr_info instead of making it up.
2691
2692 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * auto-load.c (auto_load_expand_dir_vars): Update.
2695         * defs.h (gdb_datadir): Change to std::string.
2696         (python_libdir): Likewise.
2697         (relocate_gdb_directory): Change return type to std::string.
2698         * guile/guile.c (gdbscm_data_directory): Update.
2699         (initialize_scheme_side): Update.
2700         * jit.c (jit_reader_dir): Change to std::string.
2701         (jit_reader_load_command): Update.
2702         * main.c (gdb_datadir): Change to std::string.
2703         (python_libdir): Likewise.
2704         (set_gdb_data_directory): Update.
2705         (relocate_path): Change to return std::string.
2706         (relocate_gdb_directory): Change to return std::string.
2707         (relocate_gdbinit_path_maybe_in_datadir): Update.
2708         (captured_main_1): Update.
2709         * python/python.c (do_start_initialization): Update.
2710         * top.c (show_gdb_datadir): Update.
2711         * xml-syscall.c (xml_init_syscalls_info): Update.
2712         (init_syscalls_info): Update.
2713
2714 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2715
2716         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2717         out of get_init_files.
2718         (get_init_files): Update.
2719
2720 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2721
2722         * main.c (get_init_files): Change to use std::string.
2723         (captured_main_1): Update.
2724         (print_gdb_help): Update.
2725
2726 2019-09-11  Ali Tamur  <tamur@google.com>
2727
2728         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2729         implementation.
2730
2731 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2732
2733         * dbxread.c (read_dbx_symtab): Update.
2734         * dwarf2read.c (load_partial_dies): Update.
2735         * mdebugread.c (parse_partial_symbols): Update.
2736         (handle_psymbol_enumerators): Update.
2737         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2738         * psymtab.c (add_psymbol_to_bcache): Likewise.
2739         (add_psymbol_to_list): Likewise.
2740         * symtab.c (symbol_set_names): Likewise.
2741         * symtab.h (symbol_set_names): Likewise.
2742         * xcoffread.c (scan_xcoff_symtab): Update.
2743
2744 2019-09-11  Tom Tromey  <tom@tromey.com>
2745
2746         * symfile-mem.c (symbol_file_add_from_memory): Use
2747         bfd_set_filename.
2748         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2749         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2750
2751 2019-09-10  Tom Tromey  <tromey@adacore.com>
2752
2753         * dwarf-index-write.c (write_psymbols): Extend error message.
2754         (debug_names::insert): Add Ada code.
2755         (debug_names::write_psymbols): Remove Ada check.
2756         (debug_names) <m_string_obstack>: New member.
2757         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2758         (gdb_index_symbol_name_matcher::matches): Remove.
2759         (mapped_index_base::find_name_components_bounds): Add "lang"
2760         parameter.
2761         (mapped_index_base::build_name_components): Also split names
2762         according to Ada syntax.
2763         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2764         type of "match_callback".
2765         (check_match, check_find_bounds_finds)
2766         (dw2_expand_symtabs_matching): Update.
2767         (dw2_debug_names_iterator): Add new constructor.
2768         (dw2_debug_names_map_matching_symbols): New function.
2769         (dw2_debug_names_expand_symtabs_matching): Update.
2770         (dwarf2_debug_names_functions): Use
2771         dw2_debug_names_map_matching_symbols.
2772
2773 2019-09-10  Tom Tromey  <tromey@adacore.com>
2774
2775         * dwarf2read.c (dw2_get_file_names_reader): Add the
2776         CU's file name to the results.
2777
2778 2019-09-10  Tom Tromey  <tromey@adacore.com>
2779
2780         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2781         map_matching_symbols.  Update.
2782         * dwarf2read.c (dw2_map_matching_symbols): Update.
2783         * psymtab.c (match_partial_symbol): Change type; update.
2784         (psym_map_matching_symbols): Likewise.
2785         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2786         type; update.
2787         * symfile.h (struct quick_symbol_functions)
2788         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2789         Remove "match".
2790
2791 2019-09-10  Tom Tromey  <tromey@adacore.com>
2792
2793         * psymtab.c (map_block): Remove.
2794         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2795         * symtab.c (iterate_over_symbols_terminated): New function.
2796         * symtab.c (iterate_over_symbols_terminated): Declare.
2797
2798 2019-09-10  Tom Tromey  <tromey@adacore.com>
2799
2800         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2801         * language.h (struct language_defn) <la_iterate_over_symbols>:
2802         Return bool.
2803         * symtab.c (iterate_over_symbols): Return bool.
2804         * symtab.h (iterate_over_symbols): Return bool.
2805
2806 2019-09-10  Tom Tromey  <tromey@adacore.com>
2807
2808         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2809         (add_nonlocal_symbols): Update.
2810         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2811         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2812         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2813         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2814         Change type of "callback".  Remove "data".
2815
2816
2817 2019-09-09  Ali Tamur  <tamur@google.com>
2818
2819         * dwarf2read.c (comp_unit_head): Update comment.
2820         (dwarf2_dwo_name): New function declaration.
2821         (dwarf_unit_type_name): New function declaration.
2822         (read_comp_unit_head): Add support for new compilation units,
2823         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2824         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2825         (currently named as "signature") in their header. Also clarify error
2826         messages.
2827         (lookup_dwo_id): New function. Returns the dwo id of the given
2828         compile unit.
2829         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2830         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2831         functions.
2832         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2833         (dwarf2_dwo_name): Get the dwo name if present.
2834         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2835         purposes.
2836
2837 2019-09-09  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2840
2841 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2842
2843         * python/python.c (do_start_initialization): Make progname_copy static,
2844         to avoid a leak report.
2845
2846 2019-09-08  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2849
2850 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2851
2852         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2853         Change type to gdb::optional<block_enum>.
2854         (dw2_symtab_iter_init): Change block_index parameter type
2855         to gdb::optional<block_enum>.
2856         (dw2_lookup_symbol): Change block_index parameter
2857         type to block_enum.c
2858         (dw2_debug_names_lookup_symbol): Likewise.
2859         * psymtab.c (psym_lookup_symbol): Likewise.
2860         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2861         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2862         Likewise.
2863
2864 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2865
2866         * defs.h (relocate_gdb_directory): Change int to bool in
2867         signature and rename flag to relocatable.
2868         * main.c (relocate_path): Likewise.
2869         (relocate_gdb_directory): Likewise.
2870
2871 2019-09-06  Alan Modra  <amodra@gmail.com>
2872
2873         * coffread.c (coff_symfile_read): Constify filename variable.
2874         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2875         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2876         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2877         * solib.c (reload_shared_libraries_1): Likewise.
2878         * symfile.c (reread_symbols): Likewise.
2879         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2880         * solib-darwin.c (darwin_bfd_open): Likewise.
2881         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2882
2883 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2884
2885         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2886         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2887
2888 2019-09-03  Tom Tromey  <tromey@adacore.com>
2889
2890         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2891         types.
2892         (has_negatives): Unbias a range type bound.
2893         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2894         * gdbtypes.c (operator==): Handle new field.
2895         (create_range_type): Add "bias" parameter.
2896         (create_static_range_type, resolve_dynamic_range): Update.
2897         * gdbtypes.h (struct range_bounds) <bias>: New member.
2898         (create_range_type): Add bias parameter.
2899         * printcmd.c (print_scalar_formatted): Unbias range types.
2900         * value.c (unpack_long): Unbias range types.
2901         (pack_long): Bias range types.
2902
2903 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2904
2905         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2906         probe arguments.
2907
2908 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2909
2910         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2911         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2912         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2913         (compile_probe_arg): Likewise.
2914         * probe.h (get_argument_count): Likewise.
2915         * solib-svr4.c (solib_event_probe_action): Likewise.
2916         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2917
2918 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2919
2920         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2921         code to here...
2922         (svr4_create_solib_event_breakpoints): ...from here.
2923
2924 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2925
2926         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2927         suffix from warning message.
2928
2929 2019-08-30  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-winsource.h (struct tui_source_window_base)
2932         <refresh_all>: Don't declare.
2933         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2934         Remove.
2935         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2936         tui_show_locator_content.
2937         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2938         declare.
2939         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2940         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2941         declare.
2942
2943 2019-08-30  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2946
2947 2019-08-30  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2950         Remove unnecessary forward declarations.
2951
2952 2019-08-30  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2955         rerender.
2956         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2957         tui_show_locator_content.
2958
2959 2019-08-30  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2962         (tui_locator_window::rerender): Rewrite using body of previous
2963         tui_show_locator_content.
2964
2965 2019-08-30  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2968         set_locator_fullname>: New methods.
2969         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2970         Rename from tui_set_locator_fullname.
2971         (tui_locator_window::set_locator_info): Rename from
2972         tui_set_locator_info.  Return bool.
2973         (tui_update_locator_fullname, tui_show_frame_info): Update.
2974
2975 2019-08-30  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2978
2979 2019-08-30  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2982         call touchwin.
2983
2984 2019-08-30  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-wingeneral.c (box_win): Assume win_info and
2987         win_info->handle cannot be NULL.
2988
2989 2019-08-30  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2992         refresh_window>: Declare.
2993         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2994         resize.
2995         (tui_data_item_window::rerender): Rename from
2996         tui_display_register.
2997         (tui_data_item_window::refresh_window): New method.
2998         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2999         no-op.
3000
3001 2019-08-30  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3004         regs_column_count, current_group>: Move later.  Now private.
3005         <get_current_group>: New method.
3006         * tui/tui-regs.c (tui_reg_command): Update.
3007         * tui/tui-layout.c (tui_set_layout): Update.
3008
3009 2019-08-30  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3012         (tui_data_window::rerender): Don't call
3013         check_and_display_highlight_if_needed.
3014         (tui_data_window::refresh_all): Remove call to
3015         erase_data_content.
3016
3017 2019-08-30  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3020         (tui_data_window::display_registers_from)
3021         (tui_data_window::display_reg_element_at_line)
3022         (tui_data_window::display_registers_from_line): Remove checks of
3023         "empty".
3024
3025 2019-08-30  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3028         Don't declare.
3029         * tui/tui-regs.c (tui_data_window::show_registers): Call
3030         rerender.
3031         (tui_data_window::rerender): Rename from display_all_data.
3032         (tui_data_window::rerender): Remove old implementation.
3033
3034 2019-08-30  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3037         text.
3038         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3039
3040 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3041             Sergio Durigan Junior  <sergiodj@redhat.com>
3042
3043         PR win32/24284
3044         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3045
3046 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3049         when searching for types.
3050
3051 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * f-lang.c (f_language_defn): Use f_print_typedef.
3054         * f-lang.h (f_print_typedef): Declare.
3055         * f-typeprint.c (f_print_typedef): Define.
3056
3057 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3058
3059         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3060
3061 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * cli/cli-utils.c (info_print_options_defs): Delete.
3064         (make_info_print_options_def_group): Delete.
3065         (extract_info_print_options): Delete.
3066         (info_print_command_completer): Delete.
3067         (info_print_args_help): Add extra parameter, and optionally
3068         include text about -n flag.
3069         * cli/cli-utils.h (struct info_print_options): Delete.
3070         (extract_info_print_options): Delete declaration.
3071         (info_print_command_completer): Delete declaration.
3072         (info_print_args_help): Add extra parameter, extend header
3073         comment.
3074         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3075         search_symbols.
3076         * stack.c (struct info_print_options): New type.
3077         (info_print_options_defs): New file scoped variable.
3078         (make_info_print_options_def_group): New static function.
3079         (info_print_command_completer): New static function.
3080         (info_locals_command): Update to use new local functions.
3081         (info_args_command): Likewise.
3082         (_initialize_stack): Add extra parameter to calls to
3083         info_print_args_help.
3084         * symtab.c (search_symbols): Add extra parameter, use this to
3085         possibly excluse non-debug symbols.
3086         (symtab_symbol_info): Add extra parameter, which is passed on to
3087         search_symbols.
3088         (struct info_print_options): New type.
3089         (info_print_options_defs): New file scoped variable.
3090         (make_info_print_options_def_group): New static function.
3091         (info_print_command_completer): New static function.
3092         (info_variables_command): Update to use local functions, and pass
3093         extra parameter through to symtab_symbol_info.
3094         (info_functions_command): Likewise.
3095         (info_types_command): Pass additional argument through to
3096         symtab_symbol_info.
3097         (rbreak_command): Pass extra argument to search_symbols.
3098         (_initialize_symtab): Add extra arguments for calls to
3099         info_print_args_help, and update help text for 'info variables',
3100         'whereis', and 'info functions' commands.
3101         * symtab.h (search_symbols): Add extra argument to declaration.
3102         * NEWS: Mention new flags.
3103
3104 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3105
3106         * symtab.c (lookup_static_symbol): Call the new function (and move
3107         it down to be next to lookup_global_symbol).
3108         (struct global_sym_lookup_data): Add block_enum member and rename to...
3109         (struct global_or_static_sym_lookup_data): ...this.
3110         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3111         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3112         (lookup_symbol_global_or_static_iterator_cb): ...this.
3113         (lookup_global_or_static_symbol): New function.
3114         (lookup_global_symbol): Call new function.
3115
3116 2019-08-26  Tom de Vries  <tdevries@suse.de>
3117
3118         PR c++/24852
3119         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3120         when pc_probe.prob == NULL.
3121
3122 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3125         variable symbol_linkage to symbol_linkage_.
3126
3127 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3128
3129         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3130         represent whether the symbol is static, dynamic, or we don't
3131         know.
3132
3133 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3134
3135         * gdb/rx-tdep.c (rx_register_names): New.
3136         (rx_register_name): Delete.
3137         (rx_psw_type): Delete.
3138         (rx_fpsw_type): Delete.
3139         (rx_register_type): Delete.
3140         (rx_gdbarch_init): Convert target-descriptions.
3141         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3142         * gdb/features/Makefile: Add rx.xml.
3143         * gdb/features/rx.xml: New.
3144         * gdb/features/rx.c: Generated.
3145         * gdb/NEWS: Mention target description support.
3146
3147 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3148
3149         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3150         *slot_ptr.
3151
3152 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3153
3154         * configure.ac: Don't check for 'dlfcn.h' (moved to
3155         gdbsupport/common.m4).
3156         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3157         'gdbsupport/'.
3158         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3159         * compile/compile-c-support.c: Include
3160         'gdbsupport/gdb-dlfcn.h'.
3161         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3162         * gdb-dlfcn.c: Move to...
3163         * gdbsupport/gdb-dlfcn.c: ... here.
3164         * gdb-dlfcn.h: Move to...
3165         * gdbsupport/gdb-dlfcn.h: ... here.
3166
3167 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3168
3169         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3170         the offset field signed.
3171
3172 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3173
3174         * python/lib/gdb/__init__.py (_execute_file): New function.
3175         * python/python.c (python_run_simple_file): Call gdb._execute_file
3176         on Windows.
3177
3178 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3181         all uses as this was never set to anything but a zero value.
3182
3183 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3184
3185         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3186
3187 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3188
3189         * tui/tui-data.h (tui_gen_win_info): Add an =default
3190         move constructor, required by some GCC versions.
3191
3192 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3193
3194         * go32-nat.c (go32_sysinfo): Add hygon_p.
3195
3196 2019-08-20  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3199         line_from_reg_element_no, first_reg_element_no_inline,
3200         display_all_data, delete_data_content_windows,
3201         erase_data_content>: Now private.
3202
3203 2019-08-20  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3206         (tui_unhighlight_win, tui_highlight_win)
3207         (tui_win_info::make_window): Update.
3208         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3209
3210 2019-08-20  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3213         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3214         (MAX_PID_WIDTH): Move to tui-stack.c.
3215         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3216         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3217         (MAX_PID_WIDTH): Move from tui-data.h.
3218
3219 2019-08-20  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3222         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3223         (box_win): Update.
3224         (tui_gen_win_info::make_window): Rename from tui_make_window.
3225         (tui_win_info::make_window): New method.
3226         (tui_gen_win_info::make_visible): Update.
3227         * tui/tui-source.c (tui_source_window::set_contents): Update.
3228         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3229         (tui_data_window::display_registers_from): Update.
3230         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3231         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3232         Declare.
3233         <can_box>: Remove.
3234         <title>: Remove.
3235         (struct tui_win_info) <make_window>: Declare.
3236         <can_box>: Now virtual.
3237         <title>: New member.
3238         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3239         * tui/tui-command.c (tui_cmd_window::resize): Update.
3240
3241 2019-08-20  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3244         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3245         (tui_data_window::check_register_values): Update.
3246
3247 2019-08-20  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-regs.h (struct tui_data_window): Use
3250         DISABLE_COPY_AND_ASSIGN.
3251         <regs_content>: Change type, removing unique_ptr.
3252         <tui_data_window>: Add move constructor.
3253         * tui/tui-regs.c (tui_data_window::show_registers)
3254         (tui_data_window::show_register_group)
3255         (tui_data_window::display_registers_from)
3256         (tui_data_window::display_registers_from)
3257         (tui_data_window::first_data_item_displayed)
3258         (tui_data_window::delete_data_content_windows)
3259         (tui_data_window::rerender, tui_data_window::refresh_window)
3260         (tui_data_window::check_register_values): Update.
3261
3262 2019-08-20  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3265         show_register_group>: Declare.
3266         (tui_show_register_group): Don't declare.
3267         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3268         tui_show_registers.
3269         (tui_data_window::show_register_group): Rename from
3270         tui_show_register_group.
3271         (tui_data_window::check_register_values, tui_reg_command):
3272         Update.
3273         * tui/tui-layout.c (tui_set_layout): Update.
3274
3275 2019-08-20  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3278         Declare.
3279         (tui_check_register_values): Don't declare.
3280         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3281         from tui_check_register_values.
3282         * tui/tui-hooks.c (tui_register_changed): Update.
3283
3284 2019-08-20  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-regs.c (tui_reg_layout): Move later.
3287         (tui_show_registers): Don't enable TUI mode or change layout.
3288
3289 2019-08-20  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-regs.h (struct tui_data_item_window)
3292         <~tui_data_item_window>: Remove.
3293         <content>: Now a unique_xmalloc_ptr.
3294         * tui/tui-regs.c (tui_register_format): Return a
3295         unique_xmalloc_ptr.
3296         (tui_get_register): Update.
3297         (~tui_data_item_window): Remove.
3298         (tui_data_window::display_registers_from, tui_display_register):
3299         Update.
3300         * tui/tui-io.h (tui_expand_tabs): Update.
3301         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3302         Remove "col" parameter.
3303
3304 2019-08-20  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3307         field.
3308         * tui/tui-regs.c (~tui_data_item_window): Update.
3309
3310 2019-08-20  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3313         earlier.
3314
3315 2019-08-20  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3318
3319 2019-08-20  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-source.h (struct tui_source_window): Update.
3322         * tui/tui-regs.c (tui_show_registers): Update.
3323         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3324         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3325         (NO_REGS_STRING): Remove defines.
3326
3327 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3328
3329         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3330         unnecessary thread walk if remote doesn't support the packet.
3331
3332 2019-08-19  Tom Tromey  <tromey@adacore.com>
3333
3334         * python/py-value.c (value_has_field): Fix indentation.
3335
3336 2019-08-19  Tom Tromey  <tromey@adacore.com>
3337
3338         * printcmd.c (do_one_display, info_display_command): Update.
3339         * block.h (contained_in): Return bool.  Add allow_nested
3340         parameter.
3341         * block.c (contained_in): Return bool.  Add allow_nested
3342         parameter.
3343
3344 2019-08-19  Tom Tromey  <tom@tromey.com>
3345
3346         * configure: Rebuild.
3347         * configure.ac: Disallow the combination of -static-libstdc++ and
3348         source highlight.
3349         * source-cache.c (get_language_name): Handle rust.
3350         (source_cache::get_source_lines): Ignore highlighting exceptions.
3351
3352 2019-08-16  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3355         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3356         (struct tui_source_window_base) <make_visible, refresh_window,
3357         resize>: Remove methods.
3358         <execution_info>: Remove field.
3359         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3360         (tui_show_source_line, tui_source_window_base)
3361         (~tui_source_window_base): Update.
3362         (tui_source_window_base::resize)
3363         (tui_source_window_base::make_visible)
3364         (tui_source_window_base::refresh_window): Remove.
3365         (tui_source_window_base::update_exec_info): Update.
3366         * tui/tui-source.c (tui_source_window::set_contents): Update.
3367         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3368
3369 2019-08-16  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3372         deprecated_query_hook.
3373
3374 2019-08-16  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3377         (tui_update_source_windows_with_line): Update.
3378         * tui/tui-source.h (struct tui_source_window)
3379         <show_symtab_source>: Declare.
3380         (tui_show_symtab_source): Don't declare.
3381         * tui/tui-source.c (tui_show_symtab_source): Rename from
3382         tui_show_symtab_source.
3383
3384 2019-08-16  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-winsource.h (struct tui_source_window_base)
3387         <set_contents>: Declare.
3388         * tui/tui-winsource.c
3389         (tui_source_window_base::update_source_window_as_is): Update.
3390         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3391         Declare.
3392         (tui_set_source_content): Don't declare.
3393         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3394         tui_set_source_content.
3395         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3396         Declare.
3397         (tui_set_disassem_content): Don't declare.
3398         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3399         tui_set_disassem_content.
3400
3401 2019-08-16  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-winsource.h (struct tui_source_window_base)
3404         <update_breakpoint_info>: Declare.
3405         (tui_update_breakpoint_info): Don't declare.
3406         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3407         (tui_update_all_breakpoint_info): Update.
3408         (tui_source_window_base::update_breakpoint_info): Rename from
3409         tui_update_breakpoint_info.
3410         (tui_source_window_base::update_exec_info): Update.
3411
3412 2019-08-16  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-winsource.h (struct tui_source_window_base)
3415         <update_source_window>: Declare.
3416         (tui_update_source_window): Don't declare.
3417         * tui/tui-winsource.c
3418         (tui_source_window_base::update_source_window): Rename from
3419         tui_update_source_window.
3420         (tui_source_window_base::rerender): Update.
3421         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3422         * tui/tui-disasm.c (tui_show_disassem)
3423         (tui_show_disassem_and_update_source)
3424         (tui_disasm_window::maybe_update): Update.
3425
3426 2019-08-16  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-winsource.h (struct tui_source_window_base)
3429         <update_source_window_as_is>: Declare.
3430         (tui_update_source_window_as_is): Don't declare.
3431         * tui/tui-winsource.c (tui_update_source_window): Update
3432         (tui_source_window_base::update_source_window_as_is): Rename from
3433         tui_update_source_window_as_is.
3434         (tui_source_window_base::refill): Update.
3435         * tui/tui-source.c (tui_show_symtab_source): Update.
3436         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3437         Update.
3438
3439 2019-08-16  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-winsource.h (tui_update_source_window)
3442         (tui_update_source_window_as_is): Remove "noerror" parameter.
3443         * tui/tui-winsource.c (tui_update_source_window)
3444         (tui_update_source_window_as_is): Remove "noerror" parameter.
3445         (tui_update_source_windows_with_addr)
3446         (tui_update_source_windows_with_line)
3447         (tui_source_window_base::rerender)
3448         (tui_source_window_base::refill): Update.
3449         * tui/tui-source.h (tui_set_source_content)
3450         (tui_show_symtab_source): Remove "noerror" parameter.
3451         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3452         parameter.
3453         (tui_show_symtab_source): Likewise.
3454         (tui_source_window::maybe_update): Update.
3455         * tui/tui-disasm.c (tui_show_disassem)
3456         (tui_show_disassem_and_update_source)
3457         (tui_disasm_window::do_scroll_vertical)
3458         (tui_disasm_window::maybe_update): Update.
3459
3460 2019-08-16  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui.c (tui_is_window_visible): Update.
3463         * tui/tui-wingeneral.c (tui_make_window)
3464         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3465         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3466         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3467         (tui_set_win_height_command, parse_scrolling_args): Update.
3468         * tui/tui-source.c (tui_source_window::style_changed): Update.
3469         * tui/tui-regs.c (tui_show_registers)
3470         (tui_data_window::first_data_item_displayed)
3471         (tui_data_window::delete_data_content_windows)
3472         (tui_check_register_values, tui_reg_command): Update.
3473         * tui/tui-disasm.c (tui_show_disassem): Update.
3474         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3475         method.
3476         <is_visible>: Remove field.
3477         * tui/tui-data.c (tui_next_win, tui_prev_win)
3478         (tui_delete_invisible_windows): Update.
3479
3480 2019-08-16  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-winsource.h (struct tui_source_window_base)
3483         <m_has_locator>: Remove.
3484         * tui/tui-layout.c (show_source_disasm_command, show_data)
3485         (show_source_or_disasm_and_command): Update.
3486
3487 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3488
3489         * NEWS (Other MI changes): New subsection.
3490         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3491         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3492         * arch-utils.c (default_get_pc_address_flags): New function.
3493         * arch-utils.h (default_get_pc_address_flags): New declaration.
3494         * gdbarch.sh: Add get_pc_address_flags.
3495         * gdbarch.c: Regenerate.
3496         * gdbarch.h: Likewise.
3497         * stack.c (print_pc): New function.
3498         (print_frame_info) (print_frame): Call print_pc.
3499
3500 2019-08-16  Tom de Vries  <tdevries@suse.de>
3501
3502         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3503         print_objfile_section_info.
3504
3505 2019-08-15  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3508         calling update_cmdwin_start_line.
3509         * tui/tui-winsource.h (struct tui_source_window_base)
3510         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3511         <rerender>: Declare.
3512         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3513         Call rerender.
3514         (tui_source_window_base::set_new_height): Remove.
3515         (tui_source_window_base::rerender): Rename from
3516         do_make_visible_with_new_height.
3517         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3518         resize method.
3519         (tui_win_info::make_invisible_and_set_new_height)
3520         (tui_win_info::make_visible_with_new_height): Remove.
3521         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3522         Declare.
3523         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3524         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3525         do_make_visible_with_new_height>: Don't declare.
3526         <rerender>: Declare.
3527         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3528         set_new_height.
3529         (tui_data_window::do_make_visible_with_new_height): Remove.
3530         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3531         call tui_show_locator_content.
3532         (tui_gen_win_info::resize): Call rerender.
3533         (show_source_or_disasm_and_command): Don't call
3534         tui_show_locator_content.
3535         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3536         method.
3537         (struct tui_win_info) <rerender>: Declare.
3538         <set_new_height, make_invisible_and_set_new_height,
3539         make_visible_with_new_height>: Don't declare.
3540         * tui/tui-data.c (tui_win_list::rerender): New method.
3541         * tui/tui-command.h (struct tui_cmd_window)
3542         <do_make_visible_with_new_height>: Don't declare.
3543         * tui/tui-command.c
3544         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3545
3546 2019-08-15  Tom Tromey  <tromey@adacore.com>
3547
3548         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3549         * ada-lang.c (ada_enum_name): Likewise.
3550
3551 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3552
3553         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3554         leading underscore.
3555         (GdbOutputErrorFile): Likewise.
3556         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3557         accordingly.
3558         (execute_unwinders): Rename to have a leading underscore.
3559         (auto_load_packages): Likewise.
3560         (global scope): Adjust call to auto_load_packages accordingly.
3561         (GdbSetPythonDirectory): Likewise.
3562         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3563         instead of execute_unwinders.
3564
3565 2019-08-15  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3568         (show_data): Don't change window visibility.
3569         (tui_gen_win_info::resize): Remove special case for command
3570         window.  Use wresize, when available.
3571         (show_source_or_disasm_and_command): Don't change window
3572         visibility.
3573         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3574         <make_visible>: New method.
3575         * tui/tui-command.c (tui_cmd_window::resize): New method.
3576
3577 2019-08-15  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3580         (struct tui_source_windows): New.
3581         * tui/tui-winsource.c (tui_display_main): Update.
3582         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3583         (new_height_ok, parse_scrolling_args): Update.
3584         * tui/tui-layout.c (show_layout, show_data): Update.
3585         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3586         (tui_add_to_source_windows): Don't declare.
3587         * tui/tui-data.c (source_windows, tui_source_windows)
3588         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3589
3590 2019-08-15  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3593         Rename from reset.
3594         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3595         * tui/tui-layout.c (show_source_disasm_command, show_data):
3596         Update.
3597         (tui_gen_win_info::resize): Rename.
3598         (show_source_or_disasm_and_command): Update.
3599         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3600         reset.
3601
3602 2019-08-15  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3605         * tui/tui-interp.c (tui_interp::init): Don't call
3606         tui_initialize_static_data.
3607         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3608
3609 2019-08-15  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3612         examine tui_win_list.
3613
3614 2019-08-15  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3617         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3618         tui_clear_source_content.
3619         (tui_clear_source_content): Remove.
3620         (tui_source_window_base::do_erase_source_content): Hoist call to
3621         content.clear().
3622         * tui/tui-stack.c (tui_show_frame_info): Don't call
3623         tui_clear_source_content.
3624
3625 2019-08-15  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-winsource.h (struct tui_source_window_base)
3628         <do_erase_source_content>: New method.
3629         <erase_source_content>: New method.
3630         (tui_erase_source_content): Don't declare.
3631         * tui/tui-winsource.c (tui_clear_source_content): Update.
3632         (tui_source_window_base::do_erase_source_content): Rename from
3633         tui_erase_source_content.
3634         (tui_source_window_base::show_source_content): Update.
3635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3636         * tui/tui-source.h (struct tui_source_window)
3637         <erase_source_content>: New method.
3638         * tui/tui-disasm.h (struct tui_disasm_window)
3639         <erase_source_content>: New method.
3640
3641 2019-08-15  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3644         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3645         constructor.
3646         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3647         * tui/tui-source.c (tui_set_source_content): Update.
3648         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3649
3650 2019-08-15  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3653         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3654         tui-source.c.
3655         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3656         Declare.
3657         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3658         method.
3659         (tui_source_window::maybe_update): Update.
3660
3661 2019-08-15  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3664         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3665         tui-disasm.c.
3666         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3667         Declare.
3668         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3669         method.
3670         (tui_disasm_window::maybe_update): Update.
3671
3672 2019-08-15  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-winsource.h (struct tui_source_window_base)
3675         <maybe_update>: Declare.
3676         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3677         method.
3678         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3679         Declare.
3680         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3681         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3682         Declare.
3683         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3684
3685 2019-08-15  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3688
3689 2019-08-15  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-wingeneral.c: Include tui-stack.h.
3692         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3693         (struct tui_locator_window): Move from tui-data.h.
3694         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3695         (tui_initialize_static_data): Move from tui-data.c.
3696         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3697         (struct tui_locator_window): Move to tui-stack.c.
3698         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3699         (tui_initialize_static_data): Move to tui-stack.c.
3700
3701 2019-08-15  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-layout.c (show_source_disasm_command)
3704         (show_source_or_disasm_and_command): Use make_visible method, not
3705         tui_make_window.
3706         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3707         Remove.
3708
3709 2019-08-15  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-wingeneral.h (tui_make_window): Update.
3712         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3713         parameter.
3714         (tui_gen_win_info::make_visible): Update.
3715         * tui/tui-regs.c (tui_data_window::display_registers_from):
3716         Update.
3717         * tui/tui-layout.c (show_source_disasm_command)
3718         (show_source_or_disasm_and_command): Update.
3719         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3720         (enum tui_box): Remove.
3721         (struct tui_win_info) <can_box>: New method.
3722         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3723         method.
3724
3725 2019-08-15  Tom de Vries  <tdevries@suse.de>
3726
3727         * linux-nat-trad.c: Include gdbarch.h.
3728
3729 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3730
3731         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3732         register sizes.
3733
3734 2019-08-14  Tom Tromey  <tromey@adacore.com>
3735
3736         * darwin-nat.c: Include gdbarch.h.
3737         * darwin-nat-info.c: Include gdbarch.h.
3738
3739 2019-08-13  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3742         Remove.
3743         * tui/tui-data.c (tui_initialize_static_data): Update.
3744
3745 2019-08-13  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui-winsource.h (struct tui_exec_info_window)
3748         <~tui_exec_info_window, maybe_allocate_content, get_content,
3749         m_content>: Remove.
3750         (struct tui_source_window_base) <set_exec_info_content,
3751         show_exec_info_content>: Don't declare.
3752         * tui/tui-winsource.c
3753         (tui_exec_info_window::maybe_allocate_content): Remove.
3754         (tui_source_window_base::update_exec_info): Rename from
3755         set_exec_info_content.
3756         (tui_source_window_base::show_exec_info_content)
3757         (tui_source_window_base::update_exec_info): Remove.
3758
3759 2019-08-13  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3762         declare.
3763         * tui/tui-winsource.c (tui_update_source_window_as_is)
3764         (tui_update_source_windows_with_addr, tui_erase_source_content):
3765         Update.
3766         (tui_clear_exec_info_content): Remove.
3767
3768 2019-08-13  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3771         declare.
3772         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3773         call tui_erase_exec_info_content.
3774         (tui_clear_exec_info_content): Rename from
3775         tui_erase_exec_info_content.
3776         (tui_clear_exec_info_content): Delete.
3777
3778 2019-08-13  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-winsource.h (struct tui_source_window_base)
3781         <show_exec_info_content>: Declare.
3782         (tui_show_exec_info_content): Don't declare.
3783         * tui/tui-winsource.c
3784         (tui_source_window_base::show_exec_info_content): Rename from
3785         tui_show_exec_info_content.
3786         (tui_source_window_base::update_exec_info): Update.
3787
3788 2019-08-13  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3791         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3792         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3793         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3794         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3795         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3796         ... here.
3797
3798 2019-08-13  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-winsource.h (struct tui_source_window_base)
3801         <update_exec_info>: Declare.
3802         (tui_update_exec_info): Don't declare.
3803         * tui/tui-winsource.c (tui_update_source_window_as_is)
3804         (tui_source_window_base::refresh_all)
3805         (tui_update_all_breakpoint_info): Update.
3806         (tui_source_window_base::update_exec_info): Rename from
3807         tui_update_exec_info.
3808         * tui/tui-stack.c (tui_show_frame_info): Update.
3809
3810 2019-08-13  Tom Tromey  <tom@tromey.com>
3811
3812         * tui/tui-winsource.h (struct tui_source_window_base)
3813         <set_exec_info_content>: Declare.
3814         (tui_set_exec_info_content): Don't declare.
3815         * tui/tui-winsource.c
3816         (tui_source_window_base::set_exec_info_content): Rename from
3817         tui_set_exec_info_content.
3818         (tui_update_exec_info): Update.
3819
3820 2019-08-13  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-winsource.h (struct tui_source_window_base)
3823         <show_source_content>: Declare.
3824         (tui_show_source_content): Don't declare.
3825         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3826         (tui_source_window_base::show_source_content): Rename from
3827         tui_show_source_content.
3828         (tui_source_window_base::refresh_all): Update.
3829         * tui/tui-layout.c (show_source_disasm_command)
3830         (show_source_or_disasm_and_command): Update.
3831
3832 2019-08-13  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-winsource.c (tui_erase_source_content)
3835         (tui_show_source_content, tui_source_window_base::refresh_all):
3836         Update.
3837         * tui/tui-wingeneral.h
3838         (tui_check_and_display_highlight_if_needed): Don't declare.
3839         * tui/tui-wingeneral.c
3840         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3841         check_and_display_highlight_if_needed.
3842         * tui/tui-win.c (tui_rehighlight_all)
3843         (tui_win_info::make_visible_with_new_height): Update.
3844         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3845         (tui_data_window::erase_data_content)
3846         (tui_data_window::display_all_data): Update.
3847         * tui/tui-data.h (struct tui_win_info)
3848         <check_and_display_highlight_if_needed>: Declare.
3849
3850 2019-08-13  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui-win.c (tui_resize_all): Call
3853         tui_delete_invisible_windows.
3854         * tui/tui-layout.c (show_layout): Call
3855         tui_delete_invisible_windows.
3856         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3857         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3858
3859 2019-08-13  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3862         tui_add_win_to_layout.
3863
3864 2019-08-13  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3867         * tui/tui-layout.c (tui_default_win_height): Now static.
3868
3869 2019-08-13  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3872         single switch.
3873         (show_source_disasm_command, show_source_or_disasm_and_command):
3874         Don't check current layout.
3875
3876 2019-08-13  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-wingeneral.c (make_all_visible): Remove.
3879         (tui_make_all_invisible): Simplify.
3880         * tui/tui-layout.c (tui_make_all_invisible): Move from
3881         tui-wingeneral.c; simplify.
3882         (show_layout): Hoist call to tui_make_all_invisible.
3883         (show_data): Don't call tui_make_all_invisible.
3884
3885 2019-08-13  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3888         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3889
3890 2019-08-13  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3893         tui-data.c.
3894         (show_source_disasm_command, show_data)
3895         (show_source_or_disasm_and_command): Don't use
3896         tui_set_current_layout_to.
3897         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3898         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3899         tui-layout.c.
3900         (tui_set_current_layout_to): Remove.
3901
3902 2019-08-13  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-layout.c (tui_set_layout): Update.
3905         * tui/tui-data.h (struct tui_layout_def): Remove.
3906         (tui_layout_def): Don't declare.
3907         * tui/tui-data.c (layout_def): Remove.
3908         (tui_layout_def): Remove.
3909
3910 2019-08-13  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-winsource.h (struct tui_source_window_base)
3913         <clear_detail>: No longer "override".
3914         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3915         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3916         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3917         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3918         Remove.
3919         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3920
3921 2019-08-13  Tom Tromey  <tromey@adacore.com>
3922
3923         * tracepoint.c: Don't include readline.h or history.h.
3924
3925 2019-08-12  Tom Tromey  <tom@tromey.com>
3926
3927         * configure: Rebuild.
3928         * configure.ac: Check for readline 7.
3929         * NEWS: Mention readline 7 requirement.
3930         * README: Update.
3931
3932 2019-08-12  Tom Tromey  <tom@tromey.com>
3933
3934         * mingw-hdep.c (gdb_select): Remove readline hack.
3935
3936 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3937
3938         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3939         when the function fails.
3940
3941 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3942
3943         * s390-tdep.c (s390_type_align): New function.
3944         (s390_gdbarch_init): Set it as type_align gdbarch method.
3945
3946 2019-08-09  Tom de Vries  <tdevries@suse.de>
3947
3948         PR gdb/24591
3949         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3950         pc_low with relocation offset.
3951
3952 2019-08-07  Tom Tromey  <tromey@adacore.com>
3953
3954         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3955         (print_frame_args): Update.
3956         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3957         Update.
3958         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3959         * frame.h (struct frame_arg): Add initializers.
3960         <error>: Now a unique_xmalloc_ptr.
3961
3962 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3963
3964         * NEWS: Expand the Pointer Authentication entry.
3965         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3966         (aarch64_frame_unmask_lr): ... to this.
3967         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3968         Call aarch64_frame_unmask_lr.
3969         * frame.c (struct frame_info): Add "masked" variable.
3970         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3971         (fprint_frame): Check for masked pc.
3972         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3973         declarations.
3974         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3975         * stack.c (print_frame): Check for masked pc.
3976
3977 2019-08-06  Tom Tromey  <tom@tromey.com>
3978
3979         * stabsread.c (patch_block_stabs, read_one_struct_field)
3980         (read_enum_type): Use obstack_strndup.
3981         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3982         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3983         * dwarf2read.c (guess_full_die_structure_name)
3984         (anonymous_struct_prefix): Use obstack_strndup.
3985         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3986         * c-exp.y (yylex): Use obstack_strndup.
3987         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3988         (write_var_or_type): Use obstack_strndup.
3989
3990 2019-08-06  Tom Tromey  <tom@tromey.com>
3991
3992         * symfile.c (reread_symbols): Use obstack_strdup.
3993         * stabsread.c (read_type): Use obstack_strdup.
3994         * gdb_obstack.h (obstack_strdup): New overload.
3995         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3996         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3997         (dwarf2_canonicalize_name): Use obstack_strdup.
3998         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3999         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4000         Use obstack_strdup.
4001
4002 2019-08-06  Tom Tromey  <tom@tromey.com>
4003
4004         * gdb_obstack.h (obstack_strdup): Define.
4005         * gdb_obstack.c (obstack_strdup): Don't define.
4006
4007 2019-08-06  Tom Tromey  <tom@tromey.com>
4008
4009         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4010         obstack_strdup.
4011         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4012         obstack_strdup.
4013         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4014         * stabsread.c (common_block_start): Use obstack_strdup.
4015         * objfiles.c (set_objfile_main_name, objfile): Use
4016         obstack_strdup.
4017         * namespace.c (add_using_directive): Use obstack_strdup.
4018         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4019         * jit.c (finalize_symtab): Use obstack_strdup.
4020         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4021         (guess_partial_die_structure_name, partial_die_info::fixup)
4022         (dwarf2_name): Use obstack_strdup.
4023         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4024         obstack_strdup.
4025         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4026         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4027         obstack_strdup.
4028         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4029
4030 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * unittests/help-doc-selftests.c: New file.
4033         * Makefile.in: Add the new file.
4034
4035 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4036
4037         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4038         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4039         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4040         the trailing '.' is not output, and the first character is uppercased.
4041         (print_help_for_command): Update call to print_doc_line.
4042         (print_doc_of_command): Likewise.
4043         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4044         * cli/cli-option.c (append_indented_doc): Do not append newline.
4045         (build_help_option): Append newline after first appended_indented_doc
4046         only if a second call is done.
4047         (build_help): Append 2 new lines before each option, except the first
4048         one.
4049         * compile/compile.c (_initialize_compile): Add new lines after
4050         %OPTIONS%, when not at the end of the help.
4051         Change help doc or code
4052         producing the help doc to respect the invariants.
4053         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4054         Also removed the new line after 'Options:', as all other commands
4055         do not put an empty line between 'Options:' and the first option.
4056         * printcmd.c (_initialize_printcmd): Likewise.
4057         * stack.c (_initialize_stack): Likewise.
4058         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4059         incorrectly telling COMMAND is optional.
4060         * ada-lang.c (_initialize_ada_language): Change help doc or code
4061         producing the help doc to respect the invariants.
4062         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4063         * breakpoint.c (_initialize_breakpoint): Likewise.
4064         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4065         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4066         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4067         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4068         _initialize_cli_style): Likewise.
4069         * corelow.c (core_target_info): Likewise.
4070         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4071         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4072         * filesystem.c (_initialize_filesystem): Likewise.
4073         * frame.c (_initialize_frame): Likewise.
4074         * gnu-nat.c (add_task_commands): Likewise.
4075         * infcall.c (_initialize_infcall): Likewise.
4076         * infcmd.c (_initialize_infcmd): Likewise.
4077         * interps.c (_initialize_interpreter): Likewise.
4078         * language.c (_initialize_language): Likewise.
4079         * linux-fork.c (_initialize_linux_fork): Likewise.
4080         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4081         * maint.c (_initialize_maint_cmds): Likewise.
4082         * memattr.c (_initialize_mem): Likewise.
4083         * printcmd.c (_initialize_printcmd): Likewise.
4084         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4085         _RegEx): Likewise.
4086         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4087         * record-btrace.c (_initialize_record_btrace): Likewise.
4088         * record-full.c (_initialize_record_full): Likewise.
4089         * record.c (_initialize_record): Likewise.
4090         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4091         * regcache.c (_initialize_regcache): Likewise.
4092         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4093         _initialize_remote): Likewise.
4094         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4095         * serial.c (_initialize_serial): Likewise.
4096         * skip.c (_initialize_step_skip): Likewise.
4097         * source.c (_initialize_source): Likewise.
4098         * stack.c (_initialize_stack): Likewise.
4099         * symfile.c (_initialize_symfile): Likewise.
4100         * symtab.c (_initialize_symtab): Likewise.
4101         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4102         * top.c (init_main): Likewise.
4103         * tracefile-tfile.c (tfile_target_info): Likewise.
4104         * tracepoint.c (_initialize_tracepoint): Likewise.
4105         * tui/tui-win.c (_initialize_tui_win): Likewise.
4106         * utils.c (add_internal_problem_command): Likewise.
4107         * valprint.c (value_print_option_defs): Likewise.
4108
4109 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4110
4111         PR build/24886
4112         * configure.ac: Drop enable-libmcheck support.
4113         * configure, config.in: Rebuild.
4114         * libmcheck.m4: Remove.
4115         * acinclude.m4: Don't include it.
4116         * Makefile.in: Don't distribute it.
4117         * top.c (print_gdb_configuration): Don't mention it.
4118
4119 2019-08-06  Tom Tromey  <tom@tromey.com>
4120
4121         * utils.c (set_output_style): Sometimes pass stream to
4122         emit_style_escape.
4123         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4124         * record-btrace.c (btrace_insn_history): Update.
4125         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4126         method.
4127         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4128         Update initializers.
4129         <m_uiout>: New field.
4130         <m_di>: Move lower.
4131         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4132         Remove "uiout" parameter.
4133         (dump_insns): Update.
4134         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4135         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4136
4137 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4138
4139         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4140         (error_in_psymtab_expansion): Likewise.
4141         (lookup_symbol_via_quick_fns): Likewise.
4142         (basic_lookup_transparent_type_quick): Likewise.
4143         (basic_lookup_transparent_type_1): Likewise.
4144
4145 2019-08-06  Tom Tromey  <tromey@adacore.com>
4146
4147         * source.c (last_source_error): Now bool.
4148         (print_source_lines_base): Make "noprint" bool.  Only open
4149         source file when last_source_visited changes.
4150
4151 2019-08-06  Tom Tromey  <tromey@adacore.com>
4152
4153         * annotate.c (annotate_source_line): Use g_source_cache.
4154         * source-cache.c (source_cache::get_plain_source_lines): Change
4155         parameters.  Populate m_offset_cache.
4156         (source_cache::ensure): New method.
4157         (source_cache::get_line_charpos): New method.
4158         (extract_lines): Move lower.  Change parameters.
4159         (source_cache::get_source_lines): Move lower.
4160         * source-cache.h (class source_cache): Update comment.
4161         <get_line_charpos>: New method.
4162         <get_source_lines>: Update comment.
4163         <clear>: Clear m_offset_cache.
4164         <get_plain_source_lines>: Change parameters.
4165         <ensure>: New method
4166         <m_offset_cache>: New member.
4167         * source.c (forget_cached_source_info_for_objfile): Update.
4168         (info_source_command): Use g_source_cache.
4169         (find_source_lines, open_source_file_with_line_charpos): Remove.
4170         (print_source_lines_base, search_command_helper): Use g_source_cache.
4171         * source.h (open_source_file_with_line_charpos): Don't declare.
4172         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4173         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4174         Use g_source_cache.
4175
4176 2019-08-06  Tom Tromey  <tromey@adacore.com>
4177
4178         * source-cache.c (source_cache::get_plain_source_lines):
4179         Remove "first_line" and "last_line" parameters.
4180         (source_cache::get_source_lines): Cache plain text.
4181         * source-cache.h (class source_cache)
4182         <get_plain_source_lines>: Update.
4183
4184 2019-08-06  Tom Tromey  <tromey@adacore.com>
4185
4186         * source-cache.c (extract_lines): No longer a method.
4187         Changed type of parameter.  Include final newline.
4188         (selftests::extract_lines_test): New function.
4189         (_initialize_source_cache): Likewise.
4190         * source-cache.h (class source_cache)
4191         <extract_lines>: Don't declare.
4192
4193 2019-08-06  Tom Tromey  <tromey@adacore.com>
4194
4195         * breakpoint.c (init_breakpoint_sal): Update.
4196         (breakpoint): Update.
4197         * breakpoint.h (struct breakpoint) <filter>: Now a
4198         unique_xmalloc_ptr.
4199
4200 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4201
4202         * NEWS: Mention dictionary access on blocks.
4203         * python/py-block.c (blpy_getitem): New function.
4204         (block_object_as_mapping): New struct.
4205         (block_object_type): Use new struct for tp_as_mapping field.
4206
4207 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4208
4209         * objfiles.h (objfile): Add a comment describing partial symbols.
4210
4211 2019-08-05  Tom Tromey  <tromey@adacore.com>
4212
4213         * compile/compile.c (_initialize_compile): Use _(), not N_().
4214         * thread.c (_initialize_thread): Use _(), not N_().
4215         * stack.c (_initialize_stack): Use _(), not N_().
4216         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4217
4218 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4219
4220         * dwarf2read.c (struct dw2_symtab_iterator):
4221         <want_specific_block>: Remove.
4222         <block_index>: Change type to gdb::optional.
4223         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4224         change type of BLOCK_INDEX parameter to gdb::optional.
4225         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4226         (dw2_lookup_symbol): Don't pass argument for
4227         WANT_SPECIFIC_BLOCK.
4228         (dw2_expand_symtabs_for_function): Don't pass argument for
4229         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4230         (class dw2_debug_names_iterator)
4231         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4232         parameter, change BLOCK_INDEX type to gdb::optional.
4233         <m_want_specific_block>: Remove.
4234         <m_block_index>: Change type to gdb::optional.
4235         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4236         gdb::optional.  Re-write in function of gdb::optional.
4237         (dw2_debug_names_lookup_symbol): Don't pass argument for
4238         WANT_SPECIFIC_BLOCK.
4239         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4240         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4241         BLOCK_INDEX.
4242
4243 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4244
4245         * NEWS: Mention changes to "info sources" command.
4246
4247 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4248
4249         * symtab.c (filename_partial_match_opts): New struct type.
4250         (struct output_source_filename_data): New members
4251         regexp, c_regexp, partial_match.
4252         (output_source_filename): Use new members to decide to print file.
4253         (info_sources_option_defs): New variable.
4254         (make_info_sources_options_def_group, print_info_sources_header,
4255         info_sources_command_completer):
4256         New functions.
4257         (info_sources_command): Read new optional arguments.
4258         (_initialize_symtab): Update info sources help.
4259
4260 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4261
4262         * ada-lang.c (exception_support_info_v0): Renamed from...
4263         (default_exception_support_info): ... this.  Create new
4264         definition for v1.
4265         (ada_has_this_exception_support): Look up catch_handlers_sym.
4266         (ada_exception_support_info_sniffer): Try v0 after default.
4267
4268 2019-08-01  Tom Tromey  <tromey@adacore.com>
4269
4270         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4271         gdbarch.h.
4272
4273 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4274
4275         * s12z-tdep.c: Fix include path for s12z-opc.h.
4276
4277 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4278
4279         * NEWS: Require GNU make 3.82.
4280
4281 2019-07-16  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4284         declare.
4285
4286 2019-07-30  Tom Tromey  <tromey@adacore.com>
4287
4288         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4289
4290 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4291
4292         * printcmd.c (print_address_symbolic): Print negative offsets.
4293         (build_address_symbolic): Force signed arithmetic when computing
4294         offset.
4295
4296 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4297
4298         PR/24474: Add a function to lookup static variables.
4299         * NEWS: Mention this new function.
4300         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4301         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4302         * python/python.c (python_GdbMethods): Add new function.
4303
4304 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4305
4306         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4307         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4308         (objfpy_lookup_static_symbol): New function.
4309         (objfile_object_methods): Add new functions.
4310
4311 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4312
4313         * NEWS: Mention 'set|show print frame-info'.  Mention new
4314         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4315         backtrace argument.  Mention that python frame filtering code
4316         is now consistent with what 'backtrace' command prints.
4317
4318 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4319
4320         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4321         comments.
4322         (print_frame_info_auto, print_frame_info_source_line,
4323         print_frame_info_location, print_frame_info_source_and_location,
4324         print_frame_info_location_and_address, print_frame_info_short_location):
4325         New declarations.
4326         (struct frame_print_options): New member print_frame_info.
4327         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4328         * stack.h (get_user_print_what_frame_info): New declaration.
4329         (frame_show_address): New declaration.
4330         * stack.c (print_frame_arguments_choices): New value 'presence'.
4331         (print_frame_info_auto, print_frame_info_source_line,
4332         print_frame_info_location, print_frame_info_source_and_location,
4333         print_frame_info_location_and_address, print_frame_info_short_location,
4334         print_frame_info_choices, print_frame_info_print_what): New definitions.
4335         (print_frame_args): Only print dots for args if print frame-arguments
4336         is 'presence'.
4337         (frame_print_option_defs): New element for "frame-info".
4338         (get_user_print_what_frame_info): New function.
4339         (frame_show_address): Make non static.  Move comment to stack.h.
4340         (print_frame_info_to_print_what): New function.
4341         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4342         to decide what to print.
4343         (backtrace_command_1): Handle the new print_frame_arguments_presence
4344         value.
4345         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4346         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4347         (py_print_frame): In non-mi mode, use LOCATION as default for
4348         print_what, similarly to frame information printed directly by
4349         backtrace command. Handle frame-info user option in non MI mode.
4350
4351 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4352
4353         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4354         Add case for debugging 32-bit target on 64-bit host.  Revise
4355         comment.
4356
4357 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4358
4359         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4360         instead of find_function_entry_range_from_pc.
4361
4362 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4363
4364         * stack.c (find_frame_funname): Remove code which preferred
4365         minsym over symtab sym in "certain pathological cases".
4366
4367         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4368         parameter.  Change type of "do_demangle" to bool.
4369         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4370         Pass suitable "prefer_sym_over_minsym" flag to
4371         build_address_symbolic().  Don't output "+" for negative offsets.
4372         * printcmd.c (print_address_symbolic): Update invocation of
4373         build_address_symbolic to include a "prefer_sym_over_minsym"
4374         flag.
4375         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4376         Restrict cases in which use of minimal symbol is preferred to that
4377         of a found symbol.  Update comments.
4378
4379         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4380         for entry pc when entry pc is out of range for that FDE.
4381
4382 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4383
4384         PR gdb/24839:
4385         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4386         type.
4387
4388 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4389
4390         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4391         this function's Python signature.
4392
4393
4394 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4395
4396         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4397         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4398         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4399         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4400         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4401
4402
4403 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4404
4405         * h8300-tdep.c (h8300_register_name_common): New.
4406         h8300_register_name): Use h8300_register_name_common.
4407         (h8300s_register_name): Likewise.
4408         (h8300sx_register_name): Likewise.
4409         (h8300h_register_nam): New.
4410         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4411
4412
4413 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4414
4415         * arm-tdep.c (arm_skip_cmse_entry): New function.
4416         (arm_is_sgstubs_section): New function.
4417         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4418
4419 2019-07-22  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4422         Don't self-assign.
4423
4424 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4427         type_print.
4428
4429 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4432         so that GDB doesn't match any msymbols when searching in the
4433         TYPES_DOMAIN.
4434         (print_symbol_info): Print using typedef_print or type_print based
4435         on the type of the symbol.  Add updated FIXME comment moved from...
4436         (_initialize_symtab): ... move and update FIXME comment to above.
4437
4438 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * NEWS: Mention adding -q option to "info types".
4441         * symtab.c (struct info_types_options): New struct.
4442         (info_types_options_defs): New variable.
4443         (make_info_types_options_def_group): New function.
4444         (info_types_command): Use gdb::option framework to parse options.
4445         (info_types_command_completer): New function.
4446         (_initialize_symtab): Extend the help text on "info types" and
4447         register command completer.
4448
4449 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4450
4451         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4452         (lookup_symbol_in_objfile): Change int to block_enum and add a
4453         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4454
4455 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4456
4457         * MAINTAINERS (Write After Approval): Add self.
4458
4459 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4462         instruction to the dummy code region.
4463
4464 2019-07-19  Tom Tromey  <tromey@adacore.com>
4465
4466         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4467         (ARGSUSED, PARAMS, __func__): Remove rules.
4468
4469 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4470
4471         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4472         * features/arm/arm-with-iwmmxt.c: Remove.
4473         * features/arm/arm-with-iwmmxt.xml: Remove.
4474         * features/arm/arm-with-m-fpa-layout.c: Remove.
4475         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4476         * features/arm/arm-with-m-vfp-d16.c: Remove.
4477         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4478         * features/arm/arm-with-m.c: Remove.
4479         * features/arm/arm-with-m.xml: Remove.
4480         * features/arm/arm-with-neon.c: Remove.
4481         * features/arm/arm-with-neon.xml: Remove.
4482         * features/arm/arm-with-vfpv2.c: Remove.
4483         * features/arm/arm-with-vfpv2.xml: Remove.
4484         * features/arm/arm-with-vfpv3.c: Remove.
4485         * features/arm/arm-with-vfpv3.xml: Remove.
4486
4487 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4488
4489         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4490
4491 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * arch/aarch32.c (aarch32_create_target_description): Create
4494         target descriptions using features.
4495         * arch/arm.c (arm_create_target_description)
4496         (arm_create_mprofile_target_description): Likewise.
4497         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4498
4499 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4500
4501         * Makefile.in: Add new files.
4502         * aarch32-tdep.c: New file.
4503         * aarch32-tdep.h: New file.
4504         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4505         Call aarch32_read_description.
4506         * arch/aarch32.c: New file.
4507         * arch/aarch32.h: New file.
4508         * arch/arm.c (arm_create_target_description)
4509         (arm_create_mprofile_target_description): New function.
4510         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4511         (arm_create_target_description)
4512         (arm_create_mprofile_target_description): New declaration.
4513         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4514         read_description functions.
4515         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4516         Likewise.
4517         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4518         * arm-tdep.c (tdesc_arm_list): New variable.
4519         (arm_register_g_packet_guesses): Call create description functions.
4520         (arm_read_description) (arm_read_mprofile_description): New
4521         function.
4522         * arm-tdep.h (arm_read_description)
4523         (arm_read_mprofile_description): Add declaration.
4524         * configure.tgt: Add new files.
4525
4526 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4527
4528         * top.c (new_ui_command): Open specified terminal just once.
4529
4530 2019-07-18  Tom Tromey  <tromey@adacore.com>
4531
4532         * symtab.c (main_name): Constify return type.
4533         * symfile.c (set_initial_language): Update.
4534         * symtab.h (main_name): Constify return type.
4535
4536 2019-07-17  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-winsource.c (tui_update_source_window)
4539         (tui_update_source_window_as_is)
4540         (tui_update_source_windows_with_line): Remove return.
4541         * tui/tui-disasm.c (tui_show_disassem)
4542         (tui_show_disassem_and_update_source): Remove return.
4543         * tui/tui.c (tui_reset): Remove return.
4544         * tui/tui-wingeneral.c
4545         (tui_check_and_display_highlight_if_needed): Remove return.
4546
4547 2019-07-17  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4550
4551 2019-07-17  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-winsource.h (struct tui_exec_info_window)
4554         (struct tui_source_window_base): Move from tui-data.h.
4555         * tui/tui-winsource.c: Move many method definitions from
4556         elsewhere.  Remove "structuring" comments.
4557         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4558         (tui_source_window_base::refresh_window): Move to
4559         tui-winsource.c.
4560         * tui/tui-win.c (tui_source_window_base::refresh_all)
4561         (tui_source_window_base::update_tab_width)
4562         (tui_source_window_base::set_new_height)
4563         (tui_source_window_base::do_make_visible_with_new_height): Move to
4564         tui-winsource.c.
4565         * tui/tui-source.h: Update.
4566         * tui/tui-source.c (tui_source_window_base::reset): Move to
4567         tui-winsource.c.
4568         * tui/tui-disasm.h: Update.
4569         * tui/tui-data.h (struct tui_exec_info_window): Move to
4570         tui-winsource.h.
4571         (struct tui_source_window_base): Likewise.
4572         * tui/tui-data.c (tui_source_window_base::clear_detail)
4573         (tui_source_window_base, ~tui_source_window_base): Move to
4574         tui-winsource.c.
4575
4576 2019-07-17  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-win.c (tui_resize_all)
4579         (tui_source_window_base::update_tab_width)
4580         (tui_adjust_win_heights): Update.
4581         (tui_win_info::make_invisible_and_set_new_height): Rename from
4582         make_invisible_and_set_new_height.
4583         * tui/tui-data.h (struct tui_win_info)
4584         <make_invisible_and_set_new_height>: New method.
4585
4586 2019-07-17  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui.c: Update.
4589         * tui/tui-source.h (struct tui_source_window): Move from
4590         tui-data.h.
4591         * tui/tui-layout.c: Update.
4592         * tui/tui-disasm.c: Update.
4593         * tui/tui-data.h (struct tui_source_window): Move to
4594         tui-source.h.
4595
4596 2019-07-17  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4599         tui-data.h.
4600         * tui/tui-data.h (struct tui_disasm_window): Move to
4601         tui-disasm.h.
4602
4603 2019-07-17  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-regs.h (struct tui_data_item_window): Move from
4606         tui-data.h.
4607         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4608         * tui/tui-data.h (struct tui_data_item_window): Move to
4609         tui-regs.h.
4610         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4611
4612 2019-07-17  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui.c: Update.
4615         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4616         (tui_cmd_window::max_height): Move to tui-command.c.
4617         * tui/tui-layout.c: Update.
4618         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4619         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4620         tui-command.c.
4621         * tui/tui-command.h (struct tui_cmd_window): Move from
4622         tui-data.h.
4623         * tui/tui-command.c: Remove "structuring" comments.
4624         (tui_cmd_window::clear_detail)
4625         (tui_cmd_window::do_make_visible_with_new_height)
4626         (tui_cmd_window::max_height): Move from elsewhere.
4627
4628 2019-07-17  Tom Tromey  <tom@tromey.com>
4629
4630         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4631         Now static.
4632         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4633         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4634
4635 2019-07-17  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui.c: Update.
4638         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4639         tui-regs.c.
4640         * tui/tui-windata.h: Remove file.
4641         * tui/tui-windata.c: Remove file.
4642         * tui/tui-win.c (tui_data_window::set_new_height)
4643         (tui_data_window::do_make_visible_with_new_height): Move to
4644         tui-regs.c.
4645         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4646         * tui/tui-regs.c: Remove "structuring" comments.
4647         (tui_data_window::first_data_item_displayed)
4648         (tui_data_window::delete_data_content_windows)
4649         (tui_data_window::erase_data_content)
4650         (tui_data_window::display_all_data)
4651         (tui_data_window::refresh_all)
4652         (tui_data_window::do_scroll_vertical)
4653         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4654         (tui_data_window::do_make_visible_with_new_height)
4655         (tui_data_window::refresh_window): Move from elsewhere.
4656         (_initialize_tui_regs): Move to end of file.
4657         * tui/tui-layout.c: Update.
4658         * tui/tui-hooks.c: Update.
4659         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4660         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4661         tui-regs.c.
4662         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4663
4664 2019-07-17  Tom Tromey  <tom@tromey.com>
4665
4666         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4667         seen.
4668
4669 2019-07-17  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-win.c (tui_source_window_base::set_new_height)
4672         (tui_source_window_base::do_make_visible_with_new_height): Use
4673         m_has_locator field directly.
4674         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4675         method.
4676         (struct tui_source_window_base) <has_locator>: Likewise.
4677
4678 2019-07-17  Tom Tromey  <tom@tromey.com>
4679
4680         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4681         Don't declare.
4682         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4683         Remove.
4684         * tui/tui-win.c (tui_source_window_base::set_new_height)
4685         (tui_source_window_base::set_new_height)
4686         (make_invisible_and_set_new_height)
4687         (tui_source_window_base::do_make_visible_with_new_height)
4688         (tui_source_window_base::do_make_visible_with_new_height):
4689         Update.
4690         * tui/tui-layout.c (show_source_disasm_command, show_data)
4691         (show_source_or_disasm_and_command): Update.
4692         * tui/tui-layout.c (show_layout): Update.
4693
4694 2019-07-17  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-layout.c (make_data_window): Remove.
4697         (show_data): Unify creation and re-initialization cases.
4698
4699 2019-07-17  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-layout.c (make_source_window, make_disasm_window):
4702         Remove.
4703         (show_data): Unify creation and re-initialization cases.
4704
4705 2019-07-17  Tom Tromey  <tom@tromey.com>
4706
4707         * tui/tui-layout.c (make_command_window): Remove.
4708         (show_source_disasm_command, show_source_or_disasm_and_command):
4709         Unify creation and re-initialization cases.
4710
4711 2019-07-17  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4714         creation and re-initialization cases.
4715
4716 2019-07-17  Tom Tromey  <tom@tromey.com>
4717
4718         * tui/tui-regs.c (tui_get_register): Return void.
4719
4720 2019-07-17  Tom Tromey  <tom@tromey.com>
4721
4722         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4723         Simplify.
4724
4725 2019-07-17  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4728         resetting.
4729
4730 2019-07-17  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4733         * tui/tui-regs.c (tui_reg_layout): New function.
4734         (tui_show_registers, tui_reg_command): Use it.
4735         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4736         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4737         parameters.
4738         (tui_layout_command): Remove.
4739
4740 2019-07-17  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-layout.h (tui/tui-layout): Return void.
4743         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4744
4745 2019-07-17  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-layout.c (show_source_disasm_command, show_data):
4748         Update.
4749         (reset_locator): Remove.
4750         (show_source_or_disasm_and_command): Update.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-source.c (tui_source_window_base::reset): Remove
4755         win_type parameter.
4756         * tui/tui-layout.c (make_command_window, make_source_window)
4757         (make_disasm_window, make_data_window)
4758         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4759         (reset_locator, show_source_or_disasm_and_command): Update.
4760         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4761         win_type parameter.
4762         (struct tui_source_window_base) <reset>: Likewise.
4763
4764 2019-07-17  Tom Tromey  <tom@tromey.com>
4765
4766         * tui/tui-layout.c (show_source_disasm_command): Use
4767         reset_locator.
4768         (reset_locator): New function.
4769         (init_and_make_win): Remove.
4770         (show_source_or_disasm_and_command): Use reset_locator.
4771
4772 2019-07-17  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4775         condition.
4776         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4777         Remove condition.
4778         * tui/tui-source.c (tui_source_window_base::reset): New method.
4779         * tui/tui-layout.c (make_command_window): Don't call
4780         init_and_make_win.
4781         (make_source_window, make_disasm_window): Don't call
4782         make_source_or_disasm_window.
4783         (make_data_window): Don't call init_and_make_win.  Change calling
4784         convention.
4785         (show_source_disasm_command, show_data): Simplify.
4786         (make_source_or_disasm_window): Remove.
4787         (show_source_or_disasm_and_command): Simplify.
4788         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4789         (struct tui_source_window_base) <reset>: Likewise.
4790         <execution_info>: Remove initializer.
4791         * tui/tui-data.c (tui_source_window_base): Initialize
4792         execution_info.
4793
4794 2019-07-17  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4797         variable.
4798
4799 2019-07-17  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui.c (tui_rl_other_window): Update.
4802         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4803         superclass method first.  Always iterate over regs_content.
4804         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4805         method.
4806         * tui/tui-win.c (tui_set_focus_command): Update.
4807
4808 2019-07-17  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-win.c (tui_set_focus_command): Rename from
4811         tui_set_focus.  Call tui_enable.
4812         (tui_set_focus_command): Remove.
4813
4814 2019-07-17  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4817         refresh_window.
4818         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4819         touchwin.
4820         (tui_data_window::refresh_window): Call refresh_window on data
4821         items.  Always call superclass refresh_window.
4822         (tui_win_info::refresh): Remove.
4823         (tui_source_window_base::refresh_window): Update.
4824         (tui_refresh_all): Update.
4825         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4826         refresh_window.
4827         (show_source_or_disasm_and_command): Likewise.
4828         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4829         (struct tui_source_window_base) <refresh>: Likewise.
4830
4831 2019-07-17  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-winsource.c (tui_clear_source_content)
4834         (tui_show_source_content): Update.
4835         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4836         whether content is empty.
4837         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4838         Remove.
4839
4840 2019-07-17  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4843         window's contents.
4844         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4845         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4846
4847 2019-07-17  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4850         (struct tui_data_item_window): Update.
4851
4852 2019-07-17  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4855         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4856         defines.
4857
4858 2019-07-17  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-winsource.h (tui_erase_source_content)
4861         (tui_clear_source_content): Remove "display_prompt" parameter.
4862         * tui/tui-winsource.c (tui_update_source_window_as_is)
4863         (tui_update_source_windows_with_addr): Update.
4864         (tui_clear_source_content): Remove "display_prompt" parameter.
4865         (tui_erase_source_content): Likewise.  Simplify.
4866         (tui_show_source_content): Update.
4867         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4868         * tui/tui-stack.c (tui_show_frame_info): Update.
4869         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4870         Remove defines.
4871
4872 2019-07-17  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4875         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4876         parameter.
4877         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4878         parameter.
4879
4880 2019-07-17  Tom Tromey  <tom@tromey.com>
4881
4882         * tui/tui-winsource.c (tui_clear_source_content)
4883         (tui_show_source_content, tui_show_exec_info_content)
4884         (tui_clear_exec_info_content): Update.
4885         * tui/tui-stack.c (tui_show_locator_content): Update.
4886         (tui_show_frame_info): Update.
4887         * tui/tui-source.h (tui_source_window): Don't declare.
4888         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4889         from tui_source_is_displayed.
4890         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4891         Remove field.
4892         (struct tui_source_window_base) <content_in_use>: New field.  Now
4893         bool.
4894         (struct tui_source_window) <showing_source_p>: New method.
4895         (TUI_SRC_WIN): Change cast.
4896         * tui/tui-data.c (tui_initialize_static_data): Update.
4897
4898 2019-07-17  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4901         location_matches_p.
4902         * tui/tui-source.c (tui_source_window::location_matches_p): New
4903         method.
4904         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4905         method.
4906         * tui/tui-data.h (struct tui_source_window_base)
4907         <location_matches_p>: New method.
4908         (struct tui_source_window, struct tui_disasm_window)
4909         <location_matches_p>: Likewise.
4910
4911 2019-07-17  Tom Tromey  <tom@tromey.com>
4912
4913         * tui/tui-win.c (tui_set_win_height_command): Rename from
4914         tui_set_win_height.
4915         (tui_set_win_height_command): Remove.
4916
4917 2019-07-17  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-source.c (tui_source_window): New constructor.  Add
4920         observer.
4921         (~tui_source_window): New destructor.
4922         (tui_source_window::style_changed): New method.
4923         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4924         (tui_attach_detach_observers): Update.
4925         * tui/tui-data.h (struct tui_source_window): Make constructor not
4926         inline.  Add destructor.
4927         (struct tui_source_window) <style_changed>: New method.
4928         <m_observable>: New member.
4929
4930 2019-07-17  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4933         * tui/tui-win.c (tui_resize_all): Fix typo.
4934
4935 2019-07-17  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4938         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4939         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4940         * tui/tui-win.c (window_name_completer): Use foreach.
4941         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4942         (update_tab_width): Likewise.
4943         * tui/tui-layout.c (show_layout): Update.
4944         * tui/tui-data.h (class tui_window_iterator): New.
4945         (struct all_tui_windows): New.
4946         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4947
4948 2019-07-17  Tom Tromey  <tom@tromey.com>
4949
4950         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4951         parameter.  Don't reference globals.
4952         (tui_reg_command): Update.
4953
4954 2019-07-17  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-regs.c (tui_show_registers): Simplify.
4957
4958 2019-07-17  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-regs.c (tui_show_registers): Update.
4961         (tui_show_register_group): Add win_info parameter.
4962
4963 2019-07-17  Tom Tromey  <tom@tromey.com>
4964
4965         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4966         Rename from tui_display_reg_element_at_line.
4967         (tui_data_window::display_registers_from_line): Update.
4968         * tui/tui-data.h (struct tui_data_window)
4969         <display_reg_element_at_line>: New method.
4970
4971 2019-07-17  Tom Tromey  <tom@tromey.com>
4972
4973         * tui/tui-regs.h (tui_display_registers_from)
4974         (tui_display_registers_from_line): Don't declare.
4975         * tui/tui-windata.c (tui_data_window::display_all_data)
4976         (tui_data_window::refresh_all)
4977         (tui_data_window::do_scroll_vertical): Update.
4978         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4979         from tui_display_registers_from.
4980         (tui_display_reg_element_at_line): Update.
4981         (tui_data_window::display_registers_from_line): Rename from
4982         tui_display_registers_from_line.
4983         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4984         display_registers_from_line>: New methods.
4985
4986 2019-07-17  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4989         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4990         from tui_erase_data_content.
4991         (tui_data_window::display_all_data)
4992         (tui_data_window::refresh_all)
4993         (tui_data_window::do_scroll_vertical): Update.
4994         * tui/tui-regs.c (tui_show_registers): Update.
4995         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4996         New method.
4997
4998 2019-07-17  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5001         declare.
5002         * tui/tui-windata.c
5003         (tui_data_window::delete_data_content_windows): Rename from
5004         tui_delete_data_content_windows.
5005         (tui_data_window::display_all_data)
5006         (tui_data_window::do_scroll_vertical): Update.
5007         * tui/tui-data.h (struct tui_data_window)
5008         <delete_data_content_windows>: New method.
5009
5010 2019-07-17  Tom Tromey  <tom@tromey.com>
5011
5012         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5013         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5014
5015 2019-07-17  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5018         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5019         from tui_display_all_data.
5020         * tui/tui-win.c
5021         (tui_data_window::do_make_visible_with_new_height): Update.
5022         * tui/tui-regs.c (tui_show_registers): Update.
5023         * tui/tui-layout.c (tui_set_layout): Update.
5024         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5025         method.
5026
5027 2019-07-17  Tom Tromey  <tom@tromey.com>
5028
5029         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5030         * tui/tui-windata.c (tui_display_data_from): Remove.
5031         (tui_data_window::refresh_all): Update.
5032
5033 2019-07-17  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5036         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5037         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5038         tui_display_registers_from_line.
5039         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5040         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5041         "force_display" parameter.
5042
5043 2019-07-17  Tom Tromey  <tom@tromey.com>
5044
5045         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5046         declare.
5047         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5048         Rename from tui_first_reg_element_no_inline.
5049         (tui_display_reg_element_at_line)
5050         (tui_display_registers_from_line): Update.
5051         * tui/tui-data.h (struct tui_data_window)
5052         <first_reg_element_no_inline>: New method.
5053
5054 2019-07-17  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-windata.c (tui_display_data_from)
5057         (tui_data_window::do_scroll_vertical): Update.
5058         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5059         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5060         Rename from tui_line_from_reg_element_no.
5061         (tui_display_registers_from_line): Update.
5062         * tui/tui-data.h (struct tui_data_window)
5063         <line_from_reg_element_no>: New method.
5064
5065 2019-07-17  Tom Tromey  <tom@tromey.com>
5066
5067         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5068         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5069         tui_last_regs_line_no.
5070         (tui_display_reg_element_at_line)
5071         (tui_display_registers_from_line): Update.
5072         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5073         method.
5074
5075 2019-07-17  Tom Tromey  <tom@tromey.com>
5076
5077         PR tui/24722:
5078         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5079         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5080         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5081         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5082         (tui_update_breakpoint_info): Likewise.
5083         * tui/tui-hooks.c (tui_event_create_breakpoint)
5084         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5085         Update.
5086
5087 2019-07-17  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5090
5091 2019-07-17  Tom Tromey  <tom@tromey.com>
5092
5093         * tui/tui-winsource.c (tui_update_source_window_as_is)
5094         (tui_update_source_windows_with_addr): Update.
5095         * tui/tui-source.h (tui_set_source_content)
5096         (tui_show_symtab_source): Add "win_info" parameter.
5097         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5098         parameter.
5099         (tui_show_symtab_source): Likewise.
5100
5101 2019-07-17  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-wingeneral.c
5104         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5105
5106 2019-07-17  Tom Tromey  <tom@tromey.com>
5107
5108         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5109         (struct tui_cmd_window) <can_scroll>: New method.
5110         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5111         method.
5112
5113 2019-07-17  Tom Tromey  <tromey@adacore.com>
5114
5115         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5116         do_field_signed>: Rename.  Change type of "value".
5117         * ui-out.c (ui_out::field_signed): Rename from field_int.
5118         Change type of "value".
5119         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5120         type of "value".
5121         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5122         do_field_int.  Change type of "value".
5123         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5124         do_field_int.  Change type of "value".
5125         * tracepoint.c (trace_status_mi, tfind_1)
5126         (print_one_static_tracepoint_marker): Update.
5127         * thread.c (print_thread_info_1, print_selected_thread_frame):
5128         Update.
5129         * stack.c (print_frame, print_frame_info): Update.
5130         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5131         Update.
5132         * source.c (print_source_lines_base): Update.
5133         * skip.c (info_skip_command): Update.
5134         * record-btrace.c (btrace_ui_out_decode_error)
5135         (btrace_call_history_src_line): Update.
5136         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5137         Update.
5138         * progspace.c (print_program_space): Update.
5139         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5140         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5141         do_field_int.  Change type of "value".
5142         * mi/mi-out.c (mi_ui_out::do_table_begin)
5143         (mi_ui_out::do_table_header): Update.
5144         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5145         type of "value".
5146         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5147         (mi_cmd_data_list_changed_registers, output_register)
5148         (mi_cmd_data_read_memory, mi_load_progress)
5149         (mi_cmd_trace_frame_collected): Update.
5150         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5151         Update.
5152         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5153         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5154         (mi_cmd_var_list_children, varobj_update_one): Update.
5155         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5156         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5158         * inferior.c (print_inferior): Update.
5159         * gdb_bfd.c (print_one_bfd): Update.
5160         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5161         Update.
5162         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5163         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5164         do_field_int.  Change type of "value".
5165         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5166         do_field_int.  Change type of "value".
5167         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5168         (print_one_breakpoint_location, print_it_catch_fork)
5169         (print_one_catch_fork, print_it_catch_vfork)
5170         (print_one_catch_vfork, print_it_catch_solib)
5171         (print_it_catch_exec, print_it_ranged_breakpoint)
5172         (print_mention_watchpoint, print_mention_masked_watchpoint)
5173         (bkpt_print_it, update_static_tracepoint): Update.
5174         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5175         * break-catch-syscall.c (print_it_catch_syscall): Update.
5176         * ada-tasks.c (print_ada_task_info): Update.
5177         * ada-lang.c (print_it_exception, print_mention_exception):
5178         Update.
5179
5180 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5181
5182         PR breakpoints/24541
5183         * gdbarch.c: Regenerate.
5184         * gdbarch.h: Regenerate.
5185         * gdbarch.sh: Adjust return type and parameter types for
5186         'stap_adjust_register'.
5187         (i386_stap_adjust_register): Adjust signature and return new
5188         register name.
5189         * stap-probe.c (stap_parse_register_operand): Adjust use of
5190         'gdbarch_stap_adjust_register'.
5191
5192 2019-07-17  Tom Tromey  <tromey@adacore.com>
5193
5194         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5195         declare VEC.
5196         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5197         std::vector.
5198         (struct s390_process_info): Add initializers.
5199         (s390_add_process): Use new.
5200         (s390_linux_nat_target::low_forget_process): Use delete.
5201         (s390_linux_nat_target::low_new_fork)
5202         (s390_linux_nat_target::stopped_by_watchpoint)
5203         (s390_linux_nat_target::low_prepare_to_resume)
5204         (s390_linux_nat_target::insert_watchpoint)
5205         (s390_linux_nat_target::insert_hw_breakpoint)
5206         (s390_linux_nat_target::remove_watchpoint)
5207         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5208
5209 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5210
5211         * aarch64-fbsd-nat.c: Include regcache.h.
5212         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5213         argument.
5214         (aarch64_fbsd_nat_target::fetch_registers)
5215         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5216         variable.
5217         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5218
5219 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5220
5221         * fbsd-nat.c: Include gdbarch.h.
5222
5223 2019-07-15  Tom Tromey  <tromey@adacore.com>
5224
5225         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5226
5227 2019-07-15  Tom Tromey  <tromey@adacore.com>
5228
5229         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5230         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5231         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5232         * cli-out.c (cli_ui_out::do_field_int): New method.
5233         * ui-out.c (ui_out::field_unsigned): New method.
5234         * symfile.c (generic_load): Use field_unsigned.
5235         (print_transfer_performance): Likewise.
5236         * record-btrace.c (ui_out_field_uint): Remove.
5237         (btrace_call_history_insn_range, btrace_call_history): Use
5238         field_unsigned.
5239         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5240         field_unsigned.
5241         * ui-out.h (class ui_out) <field_unsigned>: New method.
5242         <do_field_unsigned>: Likewise.
5243
5244 2019-07-15  Tom Tromey  <tromey@adacore.com>
5245
5246         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5247         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5248         * target.c (flash_erase_command): Use field_string.
5249         * infrun.c (print_signal_received_reason): Use field_string.
5250         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5251         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5252         field_string.
5253         * ada-tasks.c (print_ada_task_info): Use field_string.
5254
5255 2019-07-15  Tom Tromey  <tromey@adacore.com>
5256
5257         * target.c (flash_erase_command): Use field_core_addr.
5258         * symfile.c (generic_load): Use field_core_addr.
5259         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5260         Use field_core_addr.
5261         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5262         field_core_addr.
5263
5264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5267         value if its desired type is smaller than a CORE_ADDR and signed.
5268
5269 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5272         of changes to field names, and use new is_reference field to
5273         decide if a property is a reference or not.
5274         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5275         field.
5276         (struct dwarf2_property_baton): Update header comment, rename
5277         'referenced_type' to 'property_type' and update comments.
5278         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5279         default property type, store in property baton, update to take
5280         accound of renamed field.
5281         (read_func_scope): Update call to attr_to_dynamic_prop.
5282         (read_array_type): Likewise.
5283         (dwarf2_per_cu_addr_sized_int_type): New function.
5284         (read_subrange_index_type): Move type finding code to
5285         dwarf2_per_cu_addr_sized_int_type.
5286         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5287         (dwarf2_per_cu_addr_type): New function.
5288         (set_die_type): Update calls to attr_to_dynamic_prop.
5289
5290 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * dwarf2read.c (read_subrange_index_type): New function.
5293         (read_subrange_type): Move code into new function and call it.
5294         * gdbtypes.c (create_range_type): Add some asserts.
5295
5296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5299         update return statements.
5300         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5301         declaration, and update comment to match.
5302         * gdbtypes.c (resolve_dynamic_array): Update call to
5303         dwarf2_evaluate_property to match new return type.
5304
5305 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5306
5307         * valarith.c (value_subscripted_rvalue): Change lowerbound
5308         parameter type from int to LONGEST.
5309         * value.h (value_subscripted_rvalue): Likewise in declaration.
5310
5311 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * cli/cli-utils.c (info_print_command_completer): New function.
5314         * cli/cli-utils.h: Add 'completer.h' include, and forward
5315         declaration for 'struct cmd_list_element'.
5316         (info_print_command_completer): Declare.
5317         * stack.c (_initialize_stack): Add completer for 'info locals' and
5318         'info args'.
5319         * symtab.c (_initialize_symtab): Add completer for 'info
5320         variables' and 'info functions'.
5321         * NEWS: Mention completion for additional info commands.
5322
5323 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * cli/cli-utils.c (extract_info_print_args): Delete.
5326         (extract_arg_maybe_quoted): Delete.
5327         (info_print_options_defs): New variable.
5328         (make_info_print_options_def_group): New function.
5329         (extract_info_print_options): Define new function.
5330         * cli/cli-utils.h (extract_info_print_args): Delete.
5331         (struct info_print_options): New structure.
5332         (extract_info_print_options): Declare new function.
5333         * stack.c (info_locals_command): Update to use new
5334         extract_info_print_options, also add a header comment.
5335         (info_args_command): Likewise.
5336         * symtab.c (info_variables_command): Likewise.
5337         (info_functions_command): Likewise.
5338
5339 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5342         to extract string arguments.
5343         * common/common-utils.c (extract_string_maybe_quoted): New function.
5344         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5345
5346 2019-07-11  Tom Tromey  <tromey@adacore.com>
5347
5348         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5349         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5350         * top.h (gdbinit): Don't declare.
5351         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5352         into...
5353         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5354         * top.c (gdb_init): Don't call init_cli_cmds.
5355         (gdbinit): Remove.
5356         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5357
5358 2019-07-11  Tom Tromey  <tromey@adacore.com>
5359
5360         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5361         after it has been moved.
5362
5363 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5364
5365         * valops.c (value_must_coerce_to_target): Change return type to
5366         bool.
5367         * value.h (value_must_coerce_to_target): Likewise.
5368
5369 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5370
5371         * breakpoint.c (is_hardware_watchpoint): Remove
5372         forward-declaration.
5373         (is_masked_watchpoint): Change return type to bool.
5374         (is_tracepoint): Likewise.
5375         (is_breakpoint): Likewise.
5376         (is_hardware_watchpoint): Likewise.
5377         (is_watchpoint): Likewise.
5378         (is_no_memory_software_watchpoint): Likewise.
5379         (is_catchpoint): Likewise.
5380         (breakpoint_1): Make FILTER parameter's return type bool.
5381         is_masked_watchpoint): Change return type to bool.
5382         (save_breakpoints): Make FILTER parameter's return type bool.
5383         * breakpoint.h (is_breakpoint): Change return type to bool.
5384         (is_watchpoint): Likewise.
5385         (is_catchpoint): Likewise.
5386         (is_tracepoint): Likewise.
5387
5388 2019-07-10  Tom Tromey  <tom@tromey.com>
5389
5390         * defs.h: Don't include gdbarch.h.
5391         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5392         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5393         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5394         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5395         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5396         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5397         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5398         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5399         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5400         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5401         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5402         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5403         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5404         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5405         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5406         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5407         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5408         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5409         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5410         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5411         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5412         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5413         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5414         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5415         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5416         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5417         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5418
5419 2019-07-10  Tom Tromey  <tromey@adacore.com>
5420
5421         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5422         * breakpoint.c (init_ada_exception_breakpoint): Register as
5423         bp_catchpoint.
5424         (print_one_breakpoint_location, print_one_breakpoint): Use
5425         is_ada_exception_catchpoint.
5426         * ada-lang.c (class ada_catchpoint_location): Pass
5427         bp_loc_software_breakpoint to bp_location constructor.
5428         (is_ada_exception_catchpoint): New function.
5429
5430 2019-07-10  Tom Tromey  <tromey@adacore.com>
5431
5432         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5433         VEC.
5434         (struct arm_exidx_entry): New method operator<.
5435         (struct arm_exidx_data) <section_maps>: Change type.
5436         (arm_exidx_data_free): Remove.
5437         (arm_exidx_data_key): Change type.  Move lower.
5438         (arm_exidx_new_objfile): Update.
5439         (arm_compare_exidx_entries): Remove.
5440         (arm_find_exidx_entry, _initialize_arm_tdep)
5441
5442 2019-07-10  Tom Tromey  <tromey@adacore.com>
5443
5444         * solib-spu.c (ocl_program_data_key): Change type.
5445         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5446         Update.
5447
5448 2019-07-10  Tom Tromey  <tromey@adacore.com>
5449
5450         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5451         (struct solib_aix_inferior_data) <library_list>: Change type.
5452         (solib_aix_inferior_data_handle): Change type.
5453         (get_solib_aix_inferior_data): Update.
5454         (solib_aix_free_library_list): Remove.
5455         (library_list_start_library): Update.
5456         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5457         return type.
5458         (solib_aix_get_library_list)
5459         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5460         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5461
5462 2019-07-10  Tom Tromey  <tromey@adacore.com>
5463
5464         * solib-dsbt.c (struct dsbt_info): Add initializers.
5465         (solib_dsbt_pspace_data): Change type.
5466         (dsbt_pspace_data_cleanup): Remove.
5467         (get_dsbt_info, _initialize_dsbt_solib): Update.
5468
5469 2019-07-10  Tom Tromey  <tromey@adacore.com>
5470
5471         * spu-tdep.c (spu_overlay_data): Change type.
5472         (spu_get_overlay_table, spu_overlay_new_objfile)
5473         (_initialize_spu_tdep): Update.
5474
5475 2019-07-10  Tom Tromey  <tromey@adacore.com>
5476
5477         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5478         destructor.
5479         (dbx_objfile_data_key): Change type and declare later.
5480         (DBX_SYMFILE_INFO): Rewrite.
5481         * dbxread.c (dbx_objfile_data_key): Change type.
5482         (dbx_symfile_init): Update.
5483         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5484         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5485         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5486
5487 2019-07-10  Tom Tromey  <tromey@adacore.com>
5488
5489         * jit.c (jit_program_space_key): Change type.  Move lower.
5490         (get_jit_program_space_data): Update.
5491         (jit_program_space_data_cleanup): Remove.
5492         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5493         Update.
5494         (struct jit_program_space_data): Add initializers.
5495
5496 2019-07-10  Tom Tromey  <tromey@adacore.com>
5497
5498         * solib-darwin.c (struct darwin_info): Add initializers.
5499         (solib_darwin_pspace_data): Change type.
5500         (darwin_pspace_data_cleanup): Remove.
5501         (get_darwin_info, _initialize_darwin_solib): Update.
5502
5503 2019-07-10  Tom Tromey  <tromey@adacore.com>
5504
5505         * remote-sim.c (struct sim_inferior_data): Add initializers,
5506         constructor, and destructor.
5507         (sim_inferior_data_key): Change type.  Move lower.
5508         (check_for_duplicate_sim_descriptor): Update.
5509         (get_sim_inferior_data): Use new.  Update.
5510         (~sim_inferior_data_cleanup): Rename from
5511         sim_inferior_data_cleanup.  Simplify.
5512         (gdbsim_close_inferior, simulator_command)
5513         (sim_command_completer, _initialize_remote_sim): Update.
5514         (next_pid, INITIAL_PID): Move earlier.
5515
5516 2019-07-10  Tom Tromey  <tromey@adacore.com>
5517
5518         * python/python-internal.h (create_thread_object): Return
5519         gdbpy_ref.
5520         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5521         * python/py-inferior.c (struct threadlist_entry): Add
5522         constructor.
5523         <thread_obj>: Now a gdbpy_ref.
5524         (thread_to_thread_object): Update.
5525         (add_thread_object): Use new.
5526         (delete_thread_object): Use delete.
5527         (infpy_threads): Update.
5528         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5529         GIL.
5530
5531 2019-07-10  Tom Tromey  <tromey@adacore.com>
5532
5533         * valops.c (value_cast): Specialize error message for Ada.
5534
5535 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5536
5537         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5538
5539 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5540
5541         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5542         bpstat_should_step): Return bool, adjust comments.
5543         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5544         bpstat_should_step): Likewise.
5545
5546 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5547
5548         * features/Makefile: Use feature target descriptions for Arm.
5549         * features/arm/arm-core.c: Generate new file.
5550         * features/arm/arm-fpa.c: Likewise.
5551         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5552         * features/arm/arm-m-profile.c: Likewise.
5553         * features/arm/arm-vfpv2.c: Likewise.
5554         * features/arm/arm-vfpv3.c: Likewise.
5555         * features/arm/xscale-iwmmxt.c: Likewise.
5556         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5557
5558 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5559
5560         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5561         ptrace earlier.
5562
5563 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5564
5565         * features/aarch64-pauth.c: Regenerate.
5566
5567 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5568
5569         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5570         bool.
5571         (bpstat_what): Use false instead of 0.
5572
5573 2019-07-09  Pedro Alves  <palves@redhat.com>
5574
5575         * break-catch-throw.c (is_exception_catchpoint): New.
5576         * breakpoint.c (print_one_breakpoint_location): New parameter
5577         'raw_loc'.  Handle it.  Use
5578         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5579         looking at the breakpoint's type.
5580         (print_one_breakpoint): If handling "maint info breakpoints", also
5581         print locations of exception catchpoints.
5582         * breakpoint.h (is_exception_catchpoint): Declare.
5583
5584 2019-07-09  Pedro Alves  <palves@redhat.com>
5585
5586         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5587         "addr" field.
5588         (allocate_location_exception_catchpoint): New.
5589         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5590         (initialize_throw_catchpoint_ops): Install
5591         allocate_location_exception_catchpoint as allocate_location
5592         method.
5593         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5594         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5595         bp_loc_other.
5596         (breakpoint_address_is_meaningful): Delete.
5597         (bl_address_is_meaningful): New.
5598         (breakpoint_locations_match): Adjust comment.
5599         (bp_location_from_bp_type): New, factored out of...
5600         (bp_location::bp_location(breakpoint *)): ... this.
5601         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5602         factored out of...
5603         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5604         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5605         breakpoint_address_is_meaningful.
5606         (bp_locations_compare): Adjust comment.
5607         (update_global_location_list): Use bl_address_is_meaningful
5608         instead of breakpoint_address_is_meaningful.
5609         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5610         explicit.
5611         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5612         * python/py-breakpoint.c (bppy_get_location): No longer check
5613         whether location is null.
5614
5615 2019-07-09  Pedro Alves  <palves@redhat.com>
5616
5617         PR c++/15468
5618         * breakpoint.c (print_one_breakpoint_location): Remove
5619         single-location assert.
5620
5621 2019-07-09  Tom Tromey  <tom@tromey.com>
5622
5623         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5624         * configure: Rebuild.
5625         * configure.ac: Change common to gdbsupport.
5626         * gdbsupport: Rename from common.
5627         * acinclude.m4: Change common to gdbsupport.
5628         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5629         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5630         gdbsupport.
5631         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5632         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5633         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5634         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5635         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5636         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5637         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5638         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5639         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5640         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5641         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5642         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5643         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5644         coff-pe-read.c, command.h, compile/compile-c-support.c,
5645         compile/compile-c.h, compile/compile-cplus-symbols.c,
5646         compile/compile-cplus-types.c, compile/compile-cplus.h,
5647         compile/compile-loc2c.c, compile/compile.c, completer.c,
5648         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5649         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5650         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5651         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5652         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5653         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5654         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5655         features/aarch64-core.c, features/aarch64-fpu.c,
5656         features/aarch64-pauth.c, features/aarch64-sve.c,
5657         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5658         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5659         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5660         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5661         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5662         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5663         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5664         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5665         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5666         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5667         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5668         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5669         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5670         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5671         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5672         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5673         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5674         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5675         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5676         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5677         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5678         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5679         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5680         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5681         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5682         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5683         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5684         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5685         minsyms.c, mips-linux-tdep.c, namespace.h,
5686         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5687         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5688         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5689         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5690         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5691         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5692         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5693         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5694         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5695         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5696         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5697         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5698         procfs.c, producer.c, progspace.h, psymtab.h,
5699         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5700         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5701         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5702         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5703         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5704         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5705         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5706         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5707         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5708         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5709         target-memory.c, target.c, target.h, target/waitstatus.c,
5710         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5711         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5712         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5713         unittests/array-view-selftests.c,
5714         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5715         unittests/common-utils-selftests.c,
5716         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5717         unittests/format_pieces-selftests.c,
5718         unittests/function-view-selftests.c,
5719         unittests/lookup_name_info-selftests.c,
5720         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5721         unittests/mkdir-recursive-selftests.c,
5722         unittests/observable-selftests.c,
5723         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5724         unittests/parse-connection-spec-selftests.c,
5725         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5726         unittests/scoped_fd-selftests.c,
5727         unittests/scoped_mmap-selftests.c,
5728         unittests/scoped_restore-selftests.c,
5729         unittests/string_view-selftests.c, unittests/style-selftests.c,
5730         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5731         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5732         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5733         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5734         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5735         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5736
5737 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5738
5739         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5740         bool value.
5741         (decode_digits_ordinary): Set explicit_line field in sal.
5742         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5743         symtab_and_line that was set on an explicit line number in
5744         assembler code.  Do always update the recorded symtab and line if
5745         we do skip the prologue.
5746
5747 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5748
5749         * breakpoint.c (set_breakpoint_location_function): Remove
5750         explicit_loc parameter.
5751         (momentary_breakpoint_from_master): Update call to
5752         set_breakpoint_location_function.
5753         (add_location_to_breakpoint): Likewise.
5754
5755 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5756
5757         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5758         required features based on default bfd type when no specific bfd
5759         is present.
5760
5761 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5762
5763         * NEWS: Mention that GDB printf and eval commands can now print
5764         C-style and Ada-style convenience var strings without
5765         calling the inferior.
5766         * printcmd.c (printf_c_string): Locally print GDB internal var
5767         instead of transiting via the inferior.
5768         (printf_wide_c_string): Likewise.
5769
5770 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5771
5772         PR breakpoints/25011
5773         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5774
5775 2019-07-04  Tom Tromey  <tom@tromey.com>
5776
5777         PR tui/24724:
5778         * tui/tui-winsource.c (tui_clear_source_content): Update.
5779         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5780         (tui_update_breakpoint_info): Update.
5781         (tui_set_exec_info_content): Update.
5782         * tui/tui-source.c (tui_set_source_content_nil): Update.
5783         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5784         has_break.
5785         * tui/tui-data.h (enum tui_bp_flag): New.
5786         (tui_bp_flags): New enum flags type.
5787         (struct tui_source_element) <break_mode>: Change type.  Rename
5788         from has_break.
5789         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5790         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5791         constants.
5792         * tui/tui-winsource.h: Fix comment.
5793
5794 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5795
5796         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5797         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5798         (store_fpregs_to_thread)
5799         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5800         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5801         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5802         (IWMMXT_REGS_SIZE): Add define.
5803         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5804         (fetch_vfp_regs, store_vfp_regs)
5805         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5806         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5807
5808 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5809
5810         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5811         defines.
5812         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5813         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5814         (ARM_INT_REGISTER_SIZE): ...to this.
5815         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5816         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5817         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5818         (arm_linux_collect_gregset, supply_nwfpe_register)
5819         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5820         defines.
5821         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5822         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5823         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5824         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5825         (arm_return_in_memory, arm_store_return_value)
5826         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5827         (arm_record_ld_st_multiple): Likewise.
5828         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5829         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5830
5831 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5832
5833         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5834         AARCH64_DISPLACED_MODIFIED_INSNS.
5835         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5836         (aarch64_displaced_step_copy_insn): Likewise.
5837         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5838         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5839         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5840         ARM_DISPLACED_MODIFIED_INSNS.
5841         * arm-tdep.c (arm_gdbarch_init): Likewise.
5842         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5843         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5844         (struct arm_displaced_step_closure): Use
5845         ARM_DISPLACED_MODIFIED_INSNS.
5846
5847 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5848
5849         * features/Makefile: Remove unused xml files.
5850         * features/aarch64.xml: Remove.
5851         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5852         * features/i386/amd64-avx-avx512.xml: Remove.
5853         * features/i386/amd64-avx-linux.xml: Remove.
5854         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5855         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5856         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5857         * features/i386/amd64-avx-mpx.xml: Remove.
5858         * features/i386/amd64-avx.xml: Remove.
5859         * features/i386/amd64-linux.xml: Remove.
5860         * features/i386/amd64-mpx-linux.xml: Remove.
5861         * features/i386/amd64-mpx.xml: Remove.
5862         * features/i386/amd64.xml: Remove.
5863         * features/i386/i386-avx-avx512-linux.xml: Remove.
5864         * features/i386/i386-avx-avx512.xml: Remove.
5865         * features/i386/i386-avx-linux.xml: Remove.
5866         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5867         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5868         * features/i386/i386-avx-mpx-linux.xml: Remove.
5869         * features/i386/i386-avx-mpx.xml: Remove.
5870         * features/i386/i386-avx.xml: Remove.
5871         * features/i386/i386-linux.xml: Remove.
5872         * features/i386/i386-mmx-linux.xml: Remove.
5873         * features/i386/i386-mmx.xml: Remove.
5874         * features/i386/i386-mpx-linux.xml: Remove.
5875         * features/i386/i386-mpx.xml: Remove.
5876         * features/i386/i386.xml: Remove.
5877         * features/i386/x32-avx-avx512-linux.xml: Remove.
5878         * features/i386/x32-avx-linux.xml: Remove.
5879         * features/i386/x32-linux.xml: Remove.
5880
5881 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5882
5883         * regformats/aarch64.dat: Remove.
5884         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5885         * regformats/i386/amd64-avx-linux.dat: Remove.
5886         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5887         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5888         * regformats/i386/amd64-linux.dat: Remove.
5889         * regformats/i386/amd64-mpx-linux.dat: Remove.
5890         * regformats/i386/amd64.dat: Remove.
5891         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5892         * regformats/i386/i386-avx-linux.dat: Remove.
5893         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5894         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5895         * regformats/i386/i386-linux.dat: Remove.
5896         * regformats/i386/i386-mmx-linux.dat: Remove.
5897         * regformats/i386/i386-mpx-linux.dat: Remove.
5898         * regformats/i386/i386.dat: Remove.
5899         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5900         * regformats/i386/x32-avx-linux.dat: Remove.
5901         * regformats/i386/x32-linux.dat: Remove.
5902
5903 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5904
5905         * aarch64-tdep.c: Remove xml self tests.
5906         * amd64-linux-tdep.c: Likewise.
5907         * amd64-tdep.c: Likewise.
5908         * i386-linux-tdep.c: Likewise.
5909         * i386-tdep.c: Likewise.
5910
5911 2019-07-03  Pedro Alves  <palves@redhat.com>
5912
5913         PR cli/24732
5914         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5915         (pipe_cmd_option_defs): New.
5916         (make_pipe_cmd_options_def_group): New.
5917         (pipe_command): Use gdb::option::process_options.
5918         (pipe_command_completer): New function.
5919         (_initialize_cli_cmds): Install completer for "pipe" command.
5920
5921 2019-07-03  Pedro Alves  <palves@redhat.com>
5922
5923         * cli/cli-option.c (union option_value) <string>: New field.
5924         (struct option_def_and_value): Add ctor, move ctor, dtor and
5925         use DISABLE_COPY_AND_ASSIGN.
5926         (option_def_and_value::clear_value): New.
5927         (parse_option, save_option_value_in_ctx, get_val_type_str)
5928         (add_setshow_cmds_for_options): Handle var_string.
5929         * cli-option.h (union option_def::var_address) <string>: New
5930         field.
5931         (struct string_option_def): New.
5932         * maint-test-options.c (struct test_options_opts): Add default
5933         ctor and use DISABLE_COPY_AND_ASSIGN.
5934         <string_opt>: New field.
5935         (test_options_opts::~test_options_opts): New.
5936         (test_options_opts::dump): Also dump "-string".
5937         (test_options_option_defs): Install "string.
5938
5939 2019-07-03  Pedro Alves  <palves@redhat.com>
5940
5941         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5942         option_value with a null enumeration.
5943         (complete_options): Save the option values in the context.
5944         (save_option_value_in_ctx): New, factored out from ...
5945         (process_options): ... here.
5946         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5947         of the function.
5948         * maint-test-options.c (test_options_opts::dump): New, factored
5949         out from ...
5950         (maintenance_test_options_command_mode): ... here.
5951         (maintenance_test_options_command_completion_result): Delete.
5952         (maintenance_test_options_command_completion_text): Update
5953         comment.
5954         (maintenance_show_test_options_completion_result): Change
5955         prototype.  Just print
5956         maintenance_test_options_command_completion_text.
5957         (save_completion_result): New.
5958         (maintenance_test_options_completer_mode): Pass options context to
5959         complete_options, and then save a dump.
5960         (_initialize_maint_test_options): Use add_cmd to install "maint
5961         show test-options-completion-result".
5962
5963 2019-07-03  Pedro Alves  <palves@redhat.com>
5964
5965         * NEWS (New commands): Mention "with" and "maint with".
5966         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5967         (with_command, with_command_completer): New.
5968         (pipe_command): Adjust to new repeat_previous
5969         interface.
5970         (_initialize_cli_cmds): Install the "with" command and its "w"
5971         alias.
5972         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5973         declarations.
5974         * cli/cli-setshow.c (parse_cli_var_uinteger)
5975         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5976         argument strings for all var_types.
5977         (get_setshow_command_value_string): New, factored out from ...
5978         (do_show_command): ... this.
5979         * cli/cli-setshow.h: Include <string>.
5980         (get_setshow_command_value_string): Declare.
5981         * command.h (repeat_previous): Now returns const char *.  Adjust
5982         comment.
5983         * maint.c: Include "cli/cli-cmds.h".
5984         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5985         (_initialize_maint_cmds): Register the "maintenance with" command.
5986         * top.c (repeat_previous): Move bits from pipe_command here:
5987         Return the saved command line, if any; error out if there's no
5988         command to relaunch.
5989
5990 2019-07-03  Pedro Alves  <palves@redhat.com>
5991
5992         * NEWS (New commands): Mention "maint set/show test-settings"
5993         instead of "maint test-settings".
5994         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5995         (maintenance_test_settings_set_list): Rename to ...
5996         (maintenance_set_test_settings_list): ... this.
5997         (maintenance_test_settings_show_list): Rename to  ...
5998         (maintenance_show_test_settings_list): ... this.
5999         (maintenance_test_settings_cmd): Delete.
6000         (maintenance_test_settings_set_cmd): ...
6001         (maintenance_set_test_settings_cmd): ... this.
6002         (maintenance_test_settings_show_cmd): ...
6003         (maintenance_show_test_settings_cmd): ... this.
6004         (maintenance_test_settings_show_value_cmd):
6005         (maintenance_show_test_settings_value_cmd): ... this.
6006         (_initialize_maint_test_settings): No longer install the "maint
6007         test-settings" prefix command.  Rename "maint test-settings set"
6008         to "maint set test-settings", and "maint test-settings show" to
6009         "maint show test-settings".  Adjust all subcommands.
6010
6011 2019-07-03  Pedro Alves  <palves@redhat.com>
6012
6013         * maint-test-settings.c: Fix file's intro comment.  Replace all
6014         references to "test-options" with references to "test-settings",
6015         in comments.
6016
6017 2019-07-03  Pedro Alves  <palves@redhat.com>
6018
6019         * maint-test-settings.c (maintenance_test_settings_xxx)
6020         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6021         New.
6022         (maintenance_test_settings_enums): Use them.
6023         (maintenance_test_settings_enum): Default to
6024         maintenance_test_settings_xxx.
6025         (_initialize_maint_test_settings): Initialize
6026         MAINTENANCE_TEST_SETTINGS_FILENAME.
6027
6028 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6029
6030         * breakpoint.h (remove_breakpoints_inf): Change return type to
6031         void, move function documentation here.
6032         * breakpoint.c (remove_breakpoints_inf): Change return type to
6033         void, move function documentation to header.
6034
6035 2019-07-02  Pedro Alves  <palves@redhat.com>
6036
6037         * NEWS (Completion improvements): Mention "info threads".
6038         * thread.c (struct info_threads_opts, info_threads_option_defs)
6039         (make_info_threads_options_def_group): New.
6040         (info_threads_command): Use gdb::option::process_options.
6041         (info_threads_command_completer): New.
6042         (_initialize_thread): Use gdb::option::build_help to build the
6043         help text for "info threads".
6044
6045 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6046
6047         * defs.h (generic_load): Move from here...
6048         * symfile.h (generic_load): ... to here.  Rename name parameter
6049         to args.
6050         * symfile.c (generic_load): Add comment.
6051
6052 2019-07-01  Tom Tromey  <tromey@adacore.com>
6053
6054         * dwarf2read.c
6055         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6056         declaration of without_params.  Fix formatting.
6057
6058 2019-07-01  Tom Tromey  <tromey@adacore.com>
6059
6060         * ada-exp.y (find_primitive_type): Update.
6061         * ada-lang.h (ada_lookup_symbol): Update.
6062         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6063         parameter.
6064         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6065
6066 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6067
6068         PR breakpoints/24541
6069         * gdbarch.c: Regenerate.
6070         * gdbarch.h: Regenerate.
6071         * gdbarch.sh: Add 'stap_adjust_register'.
6072         * i386-tdep.c: Include '<unordered_set>'.
6073         (i386_stap_adjust_register): New function.
6074         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6075         * stap-probe.c (stap_parse_register_operand): Call
6076         'gdbarch_stap_adjust_register'.
6077
6078 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6079
6080         PR python/24742
6081         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6082         * python/python.c (do_start_initialization): Use 'xmalloc'
6083         instead of 'PyMem_Malloc'.
6084
6085 2019-06-28  Tom Tromey  <tromey@adacore.com>
6086
6087         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6088         for Ada.
6089
6090 2019-06-27  Tom Tromey  <tromey@adacore.com>
6091
6092         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6093         objfile_key.
6094         (arm_find_mapping_symbol, arm_record_special_symbol)
6095         (_initialize_arm_tdep): Update.
6096         (arm_objfile_data_free): Remove.
6097
6098 2019-06-27  Tom Tromey  <tromey@adacore.com>
6099
6100         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6101         to cp_print_static_field.
6102
6103 2019-06-26  Tom Tromey  <tromey@adacore.com>
6104
6105         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6106         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6107         declare.
6108
6109 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6110
6111         * features/aarch64-core.c (create_feature_aarch64_core):
6112         Regenerate.
6113         * features/aarch64-core.xml: Add cpsr flags.
6114
6115 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6116
6117         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6118         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6119
6120 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6121
6122         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6123         field.
6124         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6125         use.
6126         (arm_record_special_symbol): Don't insert new symbol in sorted
6127         position, push it at the end.
6128
6129 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6130
6131         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6132         (arm_mapping_symbol_s): Remove.
6133         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6134         (arm_mapping_symbol_vec): New typedef.
6135         (struct arm_per_objfile): Add constructor.
6136         <section_maps>: Change type to
6137         std::unique_ptr<arm_mapping_symbol_vec[]>.
6138         (arm_compare_mapping_symbols): Remove.
6139         (arm_find_mapping_symbol): Adjust to section_maps type change.
6140         (arm_objfile_data_free): Call delete on arm_per_objfile.
6141         (arm_record_special_symbol): Adjust to section_maps type change.
6142         Allocate arm_per_objfile with new.
6143
6144 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6147         with the command prefix.
6148
6149 2019-06-25  Tom Tromey  <tom@tromey.com>
6150
6151         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6152         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6153
6154 2019-06-25  Tom Tromey  <tom@tromey.com>
6155
6156         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6157         type.
6158         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6159         protected.
6160
6161 2019-06-25  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-winsource.c
6164         (tui_source_window_base::set_is_exec_point_at): Add check against
6165         LOA_ADDRESS.
6166
6167 2019-06-25  Tom Tromey  <tom@tromey.com>
6168
6169         * tui/tui-source.c (tui_set_source_content): Don't check before
6170         xfree.
6171         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6172
6173 2019-06-25  Tom Tromey  <tom@tromey.com>
6174
6175         * tui/tui-winsource.h (tui_update_source_window_as_is)
6176         (tui_alloc_source_buffer, tui_line_is_displayed)
6177         (tui_addr_is_displayed): Change type of win_info.
6178         * tui/tui-winsource.c (tui_update_source_window_as_is)
6179         (tui_clear_source_content, tui_show_source_line)
6180         (tui_show_source_content, tui_source_window_base::refill)
6181         (tui_source_window_base::set_is_exec_point_at)
6182         (tui_source_window_base::set_is_exec_point_at)
6183         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6184         (tui_alloc_source_buffer, tui_line_is_displayed)
6185         (tui_addr_is_displayed): Change type of win_info.  Update.
6186         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6187         (tui_source_window_base::do_make_visible_with_new_height):
6188         Update.
6189         * tui/tui-source.c (tui_set_source_content)
6190         (tui_set_source_content_nil)
6191         (tui_source_window::do_scroll_vertical): Update.
6192         * tui/tui-layout.c (show_layout): Update.
6193         * tui/tui-disasm.c (tui_set_disassem_content)
6194         (tui_disasm_window::do_scroll_vertical): Update.
6195         * tui/tui-data.h (tui_win_content): Remove.
6196         (struct tui_gen_win_info) <content, content_size>: Remove.
6197         (struct tui_source_element): Add initializers and destructor.
6198         (union tui_which_element, struct tui_win_element): Remove.
6199         (struct tui_source_window_base) <content>: New field.
6200         (struct tui_data_window): Remove destructor.
6201         (tui_alloc_content, tui_free_win_content)
6202         (tui_free_all_source_wins_content): Don't declare.
6203         * tui/tui-data.c (tui_initialize_static_data): Update.
6204         (init_content_element, tui_alloc_content): Remove.
6205         (~tui_gen_win_info): Update.
6206         (~tui_data_window, tui_free_all_source_wins_content)
6207         (tui_free_win_content, free_content, free_content_elements):
6208         Remove.
6209
6210 2019-06-25  Tom Tromey  <tom@tromey.com>
6211
6212         * tui/tui-winsource.h (tui_clear_source_content)
6213         (tui_erase_source_content, tui_show_source_content): Change type
6214         of win_info.
6215         * tui/tui-winsource.c (tui_clear_source_content)
6216         (tui_erase_source_content, tui_show_source_content): Change type
6217         of win_info.
6218         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6219         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6220         win_info.
6221         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6222         win_info.
6223         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6224
6225 2019-06-25  Tom Tromey  <tom@tromey.com>
6226
6227         * tui/tui-winsource.c (tui_clear_source_content)
6228         (tui_source_window_base::set_is_exec_point_at): Update.
6229         * tui/tui-source.c (tui_set_source_content_nil): Update.
6230         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6231         a bool.
6232         * tui/tui-data.c (init_content_element): Update.
6233
6234 2019-06-25  Tom Tromey  <tom@tromey.com>
6235
6236         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6237         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6238         * tui/tui-layout.c (init_and_make_win): Update.
6239         * tui/tui.h (enum tui_win_type): Update.
6240         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6241         tui_win_is_auxillary.
6242         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6243         tui_win_is_auxillary.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6248         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6249         (tui_delete_data_content_windows, tui_display_all_data)
6250         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6251         Update.
6252         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6253         * tui/tui-regs.c (tui_last_regs_line_no)
6254         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6255         (tui_show_registers): Update.
6256         (tui_show_register_group): Return void.  Update.
6257         (tui_display_registers_from, tui_display_reg_element_at_line)
6258         (tui_display_registers_from_line, tui_check_register_values):
6259         Update.
6260         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6261         member.
6262         (struct tui_data_window) <regs_content>: Now a std::vector.
6263         <regs_content_count>: Remove.
6264         (tui_add_content_elements, tui_free_data_content): Don't declare.
6265         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6266         (init_content_element): Remove DATA_WIN case.  Add assert.
6267         (tui_add_content_elements): Remove.
6268         (tui_data_window): Update.
6269         (tui_free_data_content): Remove.
6270         (free_content_elements): Remove DATA_WIN case.
6271
6272 2019-06-25  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-data.c (tui_data_item_window): Update.
6275         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6276         * tui/tui-windata.c (tui_display_all_data)
6277         (tui_display_data_from_line): Update.
6278         (tui_check_data_values): Remove.
6279         * tui/tui-regs.c (tui_show_register_group)
6280         (tui_display_reg_element_at_line): Update.
6281         * tui/tui-hooks.c (tui_register_changed)
6282         (tui_refresh_frame_and_register_information): Call
6283         tui_check_register_values.
6284         * tui/tui-data.h (struct tui_data_window) <data_content,
6285         data_content_count, data_type>: Remove.
6286         (enum tui_data_type): Remove.
6287
6288         * tui/tui-data.c (tui_data_window::clear_detail)
6289         (~tui_data_window): Update.
6290
6291 2019-06-25  Tom Tromey  <tom@tromey.com>
6292
6293         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6294         declare.
6295         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6296         Rename from tui_first_data_item_displayed.  Update.
6297         (tui_data_window::refresh_all)
6298         (tui_data_window::do_scroll_vertical): Update.
6299         * tui/tui-data.h (struct tui_data_window)
6300         <first_data_item_displayed>: Declare new method.
6301
6302 2019-06-25  Tom Tromey  <tom@tromey.com>
6303
6304         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6305         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6306         contents...
6307         (tui_initialize_static_data): ...here.
6308
6309 2019-06-25  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6312         (tui_display_registers_from, tui_check_register_values): Update.
6313         (tui_display_register): Remove win_info parameter; update.
6314         (tui_get_register): Change type of parameters.
6315         * tui/tui-data.h (struct tui_data_element): Remove.
6316         (union tui_which_element) <data>: Remove.
6317         <data_window>: Change type.
6318         (struct tui_data_item_window): New.
6319         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6320         case.  Add assert.
6321         (~tui_data_item_window): New destructor.
6322         (free_content_elements): Remove DATA_ITEM_WIN case.
6323
6324 2019-06-25  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6327         Remove.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-data.h (struct tui_command_element): Remove.
6332         (union tui_which_element) <command>: Remove.
6333         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6334         assert.
6335         (free_content_elements): Remove CMD_WIN case.
6336
6337 2019-06-25  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-layout.c (tui_set_layout): Update.
6340         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6341         * tui/tui-data.c (layout_def): Update.
6342
6343 2019-06-25  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6346         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6347         (tui_source_window_base::set_new_height): Update.
6348         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6349         Update.
6350         (tui_set_locator_fullname, tui_set_locator_info)
6351         (tui_show_frame_info): Update.
6352         * tui/tui-source.c (tui_set_source_content)
6353         (tui_source_is_displayed): Update.
6354         * tui/tui-layout.c (show_source_disasm_command, show_data)
6355         (show_source_or_disasm_and_command): Update.
6356         * tui/tui-disasm.c (tui_set_disassem_content)
6357         (tui_get_begin_asm_address): Update.
6358         * tui/tui-data.h (struct tui_locator_element): Remove.
6359         (union tui_which_element) <locator>: Remove.
6360         (struct tui_locator_window): New.
6361         (tui_locator_win_info_ptr): Change return type.
6362         * tui/tui-data.c (_locator): Change type.
6363         (tui_locator_win_info_ptr): Change return type.
6364         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6365         (tui_alloc_content): Add assert.
6366
6367 2019-06-25  Tom Tromey  <tom@tromey.com>
6368
6369         * tui/tui-winsource.c
6370         (tui_exec_info_window::maybe_allocate_content): New method.
6371         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6372         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6373         (make_source_or_disasm_window): Add cast.
6374         * tui/tui-data.h (union tui_which_element) <simple_string>:
6375         Remove.
6376         (struct tui_source_info): New.
6377         (struct tui_source_window_base) <execution_info>: Change type.
6378         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6379         case, and add assert.
6380         (tui_alloc_content): Add assert.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6385         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6386         * tui/tui-data.c (tui_alloc_win_info): Remove.
6387
6388 2019-06-25  Tom Tromey  <tom@tromey.com>
6389
6390         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6391         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6392         can_highlight.
6393
6394 2019-06-25  Tom Tromey  <tom@tromey.com>
6395
6396         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6397         make_visible_with_new_height method.
6398         (tui_win_info::make_visible_with_new_height): New method.
6399         (tui_source_window_base::do_make_visible_with_new_height)
6400         (tui_data_window::do_make_visible_with_new_height)
6401         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6402         (make_visible_with_new_height): Remove.
6403         (tui_resize_all, tui_adjust_win_heights): Use
6404         make_visible_with_new_height method.
6405         * tui/tui-data.h (struct tui_win_info)
6406         <do_make_visible_with_new_height, make_visible_with_new_height>:
6407         New methods.
6408         (struct tui_source_window_base, struct tui_data_window)
6409         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6410         methods.
6411
6412 2019-06-25  Tom Tromey  <tom@tromey.com>
6413
6414         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6415         method.
6416         (update_tab_width): Call update_tab_width method.
6417         * tui/tui-data.h (struct tui_win_info)
6418         (struct tui_source_window_base) <update_tab_width>: New methods.
6419
6420 2019-06-25  Tom Tromey  <tom@tromey.com>
6421
6422         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6423         parameter.
6424         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6425         parameter.
6426         (tui_gen_win_info::make_visible): Update.
6427         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6428         parameter.
6429         * tui/tui-data.h (enum tui_box): New enum.
6430         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6431
6432 2019-06-25  Tom Tromey  <tom@tromey.com>
6433
6434         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6435         init_and_make_win for EXEC_INFO_WIN.
6436         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6437         longer inline.
6438         (struct tui_win_info) <~tui_win_info>: Inline.
6439         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6440         Don't declare.
6441         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6442         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6443         Remove.
6444         (tui_initialize_static_data): Update.
6445         (~tui_gen_win_info): Handle more cleanup here.
6446         (~tui_source_window_base): Delete "execution_info".
6447         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6448
6449 2019-06-25  Tom Tromey  <tom@tromey.com>
6450
6451         * tui/tui-layout.c (make_command_window): Don't set
6452         can_highlight.
6453         (show_source_disasm_command): Call the reset method.
6454         (show_data): Don't set can_highlight.  Call the reset method.
6455         (tui_gen_win_info::reset): Rename from init_gen_win_info
6456         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6457         (show_source_or_disasm_and_command): Call the reset method.
6458         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6459         (struct tui_cmd_window): Set can_highlight.
6460
6461 2019-06-25  Tom Tromey  <tom@tromey.com>
6462
6463         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6464         from make_visible.
6465         (tui_make_visible, tui_make_invisible): Rewrite.
6466         (tui_win_info::make_visible): Remove.
6467         (tui_source_window_base::make_visible): Update.
6468         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6469         method.  Moved from...
6470         (struct tui_win_info) <make_visible>: ...here.
6471
6472 2019-06-25  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-winsource.c
6475         (tui_source_window_base::do_scroll_horizontal): Remove direction
6476         parameter.
6477         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6478         direction parameter.
6479         * tui/tui-win.c (tui_win_info::forward_scroll)
6480         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6481         (tui_win_info::right_scroll): Update.
6482         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6483         direction parameter.
6484         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6485         direction parameter.
6486         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6487         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6488         Remove direction parameter.
6489         (struct tui_source_window_base, struct tui_source_window)
6490         (struct tui_disasm_window, struct tui_data_window)
6491         (struct tui_cmd_window): Update.
6492
6493 2019-06-25  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-winsource.h (tui_set_exec_info_content)
6496         (tui_show_exec_info_content, tui_erase_exec_info_content)
6497         (tui_clear_exec_info_content, tui_update_exec_info): Change
6498         argument to tui_source_window_base.
6499         * tui/tui-winsource.c (tui_set_exec_info_content)
6500         (tui_show_exec_info_content, tui_erase_exec_info_content)
6501         (tui_clear_exec_info_content, tui_update_exec_info): Change
6502         argument to tui_source_window_base.
6503
6504 2019-06-25  Tom Tromey  <tom@tromey.com>
6505
6506         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6507         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6508
6509 2019-06-25  Tom Tromey  <tom@tromey.com>
6510
6511         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6512         check.
6513
6514 2019-06-25  Tom Tromey  <tom@tromey.com>
6515
6516         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6517         type to void.
6518         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6519         type to void.
6520         * tui/tui-source.c (tui_set_source_content): Update.
6521         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6522
6523 2019-06-25  Tom Tromey  <tom@tromey.com>
6524
6525         * tui/tui-win.c (window_name_completer, tui_set_focus)
6526         (tui_all_windows_info): Use name method.
6527         * tui/tui-data.h (struct tui_gen_win_info)
6528         (struct tui_source_window, struct tui_disasm_window)
6529         (struct tui_data_window, struct tui_cmd_window) <name>: New
6530         method.
6531         (tui_win_name): Don't declare.
6532         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6533         (tui_win_name): Remove.
6534
6535 2019-06-25  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-winsource.h (tui_update_source_window)
6538         (tui_update_source_window_as_is): Change parameter type.
6539         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6540         to be a tui_source_window_base.
6541         (tui_update_source_window_as_is): Likewise.
6542         * tui/tui-win.c (make_visible_with_new_height): Update.
6543
6544 2019-06-25  Tom Tromey  <tom@tromey.com>
6545
6546         * tui/tui-winsource.c (tui_erase_source_content)
6547         (tui_show_source_content, tui_show_exec_info_content)
6548         (tui_erase_exec_info_content): Use refresh_window method.
6549         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6550         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6551         from tui_refresh_win.
6552         (tui_data_window::refresh_window): New method.
6553         (tui_win_info::refresh, tui_source_window_base::refresh)
6554         (tui_refresh_all): Use refresh_window method.
6555         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6556         method.
6557         * tui/tui-regs.c (tui_display_register): Call refresh_window
6558         method.
6559         * tui/tui-layout.c (show_source_disasm_command)
6560         (show_source_or_disasm_and_command): Call refresh_window method.
6561         * tui/tui-data.h (struct tui_gen_win_info)
6562         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6563         New method.
6564
6565 2019-06-25  Tom Tromey  <tom@tromey.com>
6566
6567         * tui/tui.c (tui_rl_other_window, tui_enable)
6568         (tui_is_window_visible, tui_get_command_dimension): Update.
6569         * tui/tui-winsource.c (tui_update_source_window_as_is)
6570         (tui_clear_source_content, tui_erase_source_content)
6571         (tui_show_source_line, tui_source_window_base::refill)
6572         (tui_source_window_base::do_scroll_horizontal)
6573         (tui_source_window_base::set_is_exec_point_at)
6574         (tui_update_breakpoint_info, tui_set_exec_info_content)
6575         (tui_alloc_source_buffer, tui_line_is_displayed)
6576         (tui_addr_is_displayed): Update.
6577         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6578         (tui_check_and_display_highlight_if_needed)
6579         (tui_win_info::make_visible, tui_win_info::refresh)
6580         (tui_refresh_all): Update.
6581         * tui/tui-windata.c (tui_first_data_item_displayed)
6582         (tui_delete_data_content_windows, tui_erase_data_content)
6583         (tui_display_all_data, tui_data_window::refresh_all)
6584         (tui_check_data_values): Update.
6585         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6586         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6587         (tui_win_info::backward_scroll, tui_refresh_all_win)
6588         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6589         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6590         (tui_source_window_base::set_new_height)
6591         (tui_data_window::set_new_height)
6592         (make_invisible_and_set_new_height)
6593         (make_visible_with_new_height, new_height_ok)
6594         (parse_scrolling_args): Update.
6595         * tui/tui-stack.c (tui_show_frame_info): Update.
6596         * tui/tui-source.c (tui_set_source_content)
6597         (tui_set_source_content_nil, tui_source_is_displayed)
6598         (tui_source_window::do_scroll_vertical): Update.
6599         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6600         (tui_display_registers_from, tui_display_reg_element_at_line)
6601         (tui_check_register_values, tui_reg_command): Update.
6602         * tui/tui-layout.c (tui_default_win_height)
6603         (show_source_disasm_command, show_data, init_and_make_win)
6604         (show_source_or_disasm_and_command): Update.
6605         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6606         (tui_redisplay_readline, tui_mld_flush)
6607         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6608         (tui_getc): Update.
6609         * tui/tui-disasm.c (tui_set_disassem_content)
6610         (tui_disasm_window::do_scroll_vertical): Update.
6611         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6612         Now virtual.
6613         (struct tui_win_info): Derive from tui_gen_win_info.
6614         <~tui_win_info>: Mark as override.
6615         <generic>: Remove member.
6616         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6617         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6618         (~tui_data_window, ~tui_win_info)
6619         (tui_free_all_source_wins_content): Update.
6620         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6621
6622 2019-06-25  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-layout.c (init_and_make_win): Use new.
6625         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6626         destructor, initializers.
6627         (tui_alloc_generic_win_info): Don't declare.
6628         * tui/tui-data.c (_locator): Add argument to constructor.
6629         (source_win, disasm_win): New globals.
6630         (exec_info): Remove.
6631         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6632         Update.
6633         (tui_alloc_generic_win_info): Remove.
6634         (init_content_element): Use new.
6635         (tui_win_info::tui_win_info): Update.
6636         (free_content_elements) <case DATA_WIN>: Use delete.
6637
6638 2019-06-25  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6641         * tui/tui-windata.c (tui_first_data_item_displayed)
6642         (tui_delete_data_content_windows): Update.
6643         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6644         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6645         (tui_display_registers_from, tui_check_register_values): Update.
6646         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6647         pointer.
6648         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6649         window.
6650         (tui_free_data_content): Update.
6651         (free_content_elements) <case DATA_WIN>: Free the window.
6652
6653 2019-06-25  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6656         Update.
6657         * tui/tui-layout.c (make_command_window)
6658         (show_source_disasm_command, show_data, init_and_make_win)
6659         (show_source_or_disasm_and_command): Update.
6660         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6661         method.
6662         <can_highight, is_highlighted>: Now bool.
6663         (tui_set_win_highlight): Don't declare.
6664         * tui/tui-data.c (tui_set_win_highlight): Remove.
6665
6666 2019-06-25  Tom Tromey  <tom@tromey.com>
6667
6668         * tui/tui-wingeneral.c (make_visible): Remove check of window
6669         type.
6670
6671 2019-06-25  Tom Tromey  <tom@tromey.com>
6672
6673         * tui/tui-win.c (tui_win_info::max_height)
6674         (tui_cmd_window::max_height): New methods.
6675         (new_height_ok): Call max_height.
6676         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6677         <max_height>: New method.
6678
6679 2019-06-25  Tom Tromey  <tom@tromey.com>
6680
6681         * tui/tui-win.c (tui_source_window_base::set_new_height)
6682         (tui_data_window::set_new_height): New methods.
6683         (make_invisible_and_set_new_height): Call set_new_height method.
6684         * tui/tui-data.h (struct tui_win_info)
6685         (struct tui_source_window_base, struct tui_data_window)
6686         <set_new_height>: New method.
6687
6688 2019-06-25  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6691         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6692         tui_refresh_data_win.
6693         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6694         method.
6695         (tui_refresh_all_win): Call the refresh_all method.
6696         (tui_set_focus): Likewise.
6697         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6698         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6699         Likewise.
6700
6701 2019-06-25  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui-winsource.h (tui_refill_source_window)
6704         (tui_set_is_exec_point_at): Don't declare.
6705         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6706         (tui_source_window_base::refill): Rename from
6707         tui_refill_source_window.
6708         (tui_source_window_base::do_scroll_horizontal): Update.
6709         (tui_source_window_base::set_is_exec_point_at): Rename from
6710         tui_set_is_exec_point_at.
6711         (tui_update_all_breakpoint_info): Update.
6712         * tui/tui-stack.c (tui_show_frame_info): Update.
6713         * tui/tui-layout.c (show_data): Add cast.
6714         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6715         * tui/tui-data.h (struct tui_source_window_base) <refill,
6716         set_is_exec_point_at>: New methods.
6717         (tui_source_windows, tui_add_to_source_windows): Update types.
6718         (tui_add_to_source_windows): Remove redundant declaration.
6719         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6720         (tui_source_windows): Change return type.
6721         (tui_clear_source_windows_detail): Update.
6722         (tui_add_to_source_windows): Change type of parameter.
6723         (tui_free_all_source_wins_content): Update.
6724
6725 2019-06-25  Tom Tromey  <tom@tromey.com>
6726
6727         * tui/tui-wingeneral.c (tui_win_info::refresh)
6728         (tui_source_window_base::refresh): New methods.
6729         (tui_refresh_all): Call the refresh method.
6730         * tui/tui-data.h (struct tui_win_info)
6731         (struct tui_source_window_base) <refresh>: New method.
6732
6733 2019-06-25  Tom Tromey  <tom@tromey.com>
6734
6735         * tui/tui.h (tui_is_window_visible): Return bool.
6736         * tui/tui.c (tui_is_window_visible): Return bool.
6737         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6738         (tui_make_visible, tui_make_invisible)
6739         (tui_win_info::make_visible)
6740         (tui_source_window_base::make_visible, make_all_visible)
6741         (tui_make_all_visible, tui_make_all_invisible): Update.
6742         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6743         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6744         bool.
6745         (struct tui_win_info, struct tui_source_window_base)
6746         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6747         * tui/tui-data.c (tui_init_generic_part): Update.
6748
6749 2019-06-25  Tom Tromey  <tom@tromey.com>
6750
6751         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6752         (tui_source_window_base::make_visible): New methods.
6753         (make_all_visible): Make method call.
6754         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6755         (struct tui_source_window_base, struct tui_cmd_window): Override
6756         make_visible.
6757         (tui_win_is_source_type): Don't declare.
6758         * tui/tui-data.c (tui_win_is_source_type): Remove.
6759
6760 2019-06-25  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6763         NULL check.
6764
6765 2019-06-25  Tom Tromey  <tom@tromey.com>
6766
6767         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6768         Inline constructor.  Add initializers for members.
6769         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6770         constructors; now inline in class.
6771
6772 2019-06-25  Tom Tromey  <tom@tromey.com>
6773
6774         * tui/tui-regs.c (tui_show_registers): Update.
6775         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6776         bool.
6777         * tui/tui-data.c (tui_data_window::clear_detail)
6778         (tui_data_window): Update.
6779
6780 2019-06-25  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-windata.c (tui_display_all_data)
6783         (tui_display_data_from_line, tui_display_data_from)
6784         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6785         Update.
6786         * tui/tui-regs.c (tui_last_regs_line_no)
6787         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6788         (tui_show_registers, tui_show_register_group)
6789         (tui_display_registers_from, tui_display_reg_element_at_line)
6790         (tui_display_registers_from_line, tui_check_register_values)
6791         (tui_reg_next, tui_reg_prev): Update.
6792         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6793         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6794         tui_data_window.
6795         (struct tui_win_info) <detail>: Remove.  Add new fields from
6796         tui_data_info.
6797         (TUI_DATA_WIN): Add cast.
6798         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6799         (~tui_data_window): Simplify.
6800
6801 2019-06-25  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-layout.c (show_source_disasm_command)
6804         (show_source_or_disasm_and_command): Update.
6805         * tui/tui-io.c (update_cmdwin_start_line)
6806         (tui_redisplay_readline): Update.
6807         * tui/tui-data.h (struct tui_command_info): Remove.
6808         (struct tui_win_info) <detail>: Remove command_info member.
6809         (struct tui_data_window) <start_line>: New member, from
6810         tui_command_info.
6811         (TUI_CMD_WIN): Add casts.
6812
6813 2019-06-25  Tom Tromey  <tom@tromey.com>
6814
6815         * tui/tui-winsource.c (tui_update_source_window)
6816         (tui_refill_source_window)
6817         (tui_source_window_base::do_scroll_horizontal)
6818         (tui_update_breakpoint_info, tui_set_exec_info_content)
6819         (tui_show_exec_info_content, tui_erase_exec_info_content)
6820         (tui_clear_exec_info_content): Update.
6821         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6822         Update.
6823         * tui/tui-win.c (make_invisible_and_set_new_height)
6824         (make_visible_with_new_height): Update.
6825         * tui/tui-source.c (tui_set_source_content)
6826         (tui_show_symtab_source): Update.
6827         * tui/tui-layout.c (extract_display_start_addr)
6828         (show_source_disasm_command, show_data)
6829         (make_source_or_disasm_window)
6830         (show_source_or_disasm_and_command): Update.
6831         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6832         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6833         "gdbarch".
6834         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6835         to tui_source_window_base.
6836         (struct tui_win_info) <detail>: Remove source_info member.
6837         (struct tui_source_window_base) <has_locator>: Inline.
6838         Move contents from tui_source_info; rename has_locator member to
6839         m_has_locator.
6840         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6841         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6842         header file.
6843         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6844         Simplify.
6845         (tui_free_all_source_wins_content): Cast to
6846         tui_source_window_base.
6847
6848 2019-06-25  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-win.c (make_invisible_and_set_new_height)
6851         (make_visible_with_new_height): Call has_locator method.
6852         * tui/tui-layout.c (show_source_disasm_command, show_data)
6853         (show_source_or_disasm_and_command): Update for bool change.
6854         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6855         (tui_win_info) <has_locator>: New method.
6856         (struct tui_source_window_base) <has_locator>: New method.
6857         (tui_win_has_locator): Don't declare.
6858         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6859         from tui_win_has_locator.
6860         (tui_source_window_base): Use false, not FALSE.
6861
6862 2019-06-25  Tom Tromey  <tom@tromey.com>
6863
6864         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6865         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6866         clear_detail method directly.
6867         (tui_clear_win_detail): Remove.
6868
6869 2019-06-25  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6872         "this", not TUI_DISASM_WIN.
6873
6874 2019-06-25  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6877         declare.
6878         * tui/tui-winsource.c
6879         (tui_source_window_base::do_scroll_horizontal): Rename from
6880         tui_horizontal_source_scroll.
6881         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6882         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6883         from tui_vertical_data_scroll.
6884         * tui/tui-win.h (tui_scroll): Don't declare.
6885         * tui/tui-win.c (tui_win_info::forward_scroll)
6886         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6887         (tui_win_info::right_scroll): Rename and update.
6888         (tui_scroll_forward_command, tui_scroll_backward_command)
6889         (tui_scroll_left_command, tui_scroll_right_command): Update.
6890         (tui_scroll): Remove.
6891         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6892         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6893         from tui_vertical_source_scroll.
6894         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6895         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6896         from tui_vertical_disassem_scroll.
6897         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6898         do_scroll_horizontal>: New methods.
6899         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6900         Likewise.
6901         (struct tui_source_window_base): Add do_scroll_horizontal.
6902         (struct tui_source_window, struct tui_disasm_window): Add
6903         do_scroll_vertical.
6904         (struct tui_data_window, struct tui_cmd_window): Add
6905         do_scroll_horizontal and do_scroll_vertical.
6906         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6907
6908 2019-06-25  Tom Tromey  <tom@tromey.com>
6909
6910         * tui/tui-data.h (struct tui_source_window_base): New struct.
6911         (struct tui_source_window): Derive from tui_source_window_base.
6912         (struct tui_disasm_window): New struct.
6913         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6914         from tui_source_window::clear_detail.
6915         (tui_source_window_base): Rename from tui_source_window.
6916         (~tui_source_window_base): Rename from ~tui_source_window.
6917         (tui_alloc_win_info): Create a tui_disasm_window.
6918
6919 2019-06-25  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-data.h (struct tui_source_window)
6922         (struct tui_data_window): Declare destructors.
6923         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6924         destructors.
6925         (tui_win_info): Simplify.
6926
6927 2019-06-25  Tom Tromey  <tom@tromey.com>
6928
6929         * tui/tui-winsource.c (tui_display_main)
6930         (tui_update_source_windows_with_addr)
6931         (tui_update_all_breakpoint_info): Update.
6932         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6933         (new_height_ok, parse_scrolling_args): Update.
6934         * tui/tui-stack.c (tui_show_frame_info): Update.
6935         * tui/tui-data.h (struct tui_list): Remove.
6936         (tui_source_windows): Return a reference to a std::vector.
6937         * tui/tui-data.c (source_windows): Now a std::vector.
6938         (tui_source_windows): Change return type.
6939         (tui_clear_source_windows): Rewrite.
6940         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6941         (tui_free_all_source_wins_content): Rewrite.
6942
6943 2019-06-25  Tom Tromey  <tom@tromey.com>
6944
6945         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6946         (struct tui_data_window, struct tui_cmd_window): Declare
6947         clear_detail method.
6948         * tui/tui-data.c (tui_source_window::clear_detail)
6949         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6950         methods.
6951         (tui_clear_win_detail): Simplify.
6952
6953 2019-06-25  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui-layout.c (make_source_window, make_disasm_window)
6956         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6957         Return the new window.
6958         (show_source_disasm_command, show_data)
6959         (show_source_or_disasm_and_command): Update.
6960
6961 2019-06-25  Tom Tromey  <tom@tromey.com>
6962
6963         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6964         parameter.  Return the new window.
6965         (show_source_disasm_command): Update and remove NULL check.
6966         (show_source_or_disasm_and_command): Update.
6967
6968 2019-06-25  Tom Tromey  <tom@tromey.com>
6969
6970         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6971
6972 2019-06-25  Tom Tromey  <tom@tromey.com>
6973
6974         * tui/tui-data.h (struct tui_win_info): Make constructor
6975         protected.  Make destructor virtual.  Add initializers.
6976         (tui_source_window, tui_data_window, tui_cmd_window): New
6977         classes.
6978         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6979         constructor.  Add "type" parameter.
6980         (tui_source_window, tui_data_window, tui_cmd_window): New
6981         constructors.
6982         (tui_alloc_win_info): Instantiate the appropriate subclass.
6983
6984 2019-06-25  Tom Tromey  <tom@tromey.com>
6985
6986         * tui/tui-win.c (tui_resize_all): Use delete.
6987         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6988         destructor.
6989         (tui_free_window): Don't declare.
6990         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6991         Update.
6992
6993 2019-06-25  Tom Tromey  <tom@tromey.com>
6994
6995         * tui/tui-data.h (struct tui_win_info): Add constructor.
6996         * tui/tui-data.c (tui_alloc_win_info): Use new.
6997         (tui_free_window): Use delete.
6998
6999 2019-06-22  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7002         declare.
7003         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7004
7005 2019-06-22  Tom Tromey  <tom@tromey.com>
7006
7007         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7008         declare.
7009         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7010
7011 2019-06-22  Tom de Vries  <tdevries@suse.de>
7012
7013         * dwarf2read.c (create_addrmap_from_aranges)
7014         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7015         instead of '%zu'.
7016
7017 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7018
7019         * dwarf2read.h (dwarf2_section_info_def): Remove.
7020         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7021         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7022         std::vector<dwarf2_section_info>.
7023         (struct dwo_file) <~dwo_file>: Remove.
7024         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7025         types field.
7026         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7027         (dwarf2_read_debug_names): Likewise.
7028         (create_debug_types_hash_table): Change parameter type to
7029         array_view, adjust code accordingly.
7030         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7031         (partial_die_info::fixup): Likewise.
7032         (determine_prefix): Likewise.
7033         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7034
7035 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7036
7037         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7038         gdb_bfd_ref_ptr.
7039         <~dwo_file>: Remove call to gdb_bfd_unref.
7040         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7041         gdb_bfd_ref_ptr::get.
7042
7043 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7044
7045         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7046         type to htab_up.
7047         * dwarf2read.c (struct dwo_file): Initialize fields.
7048         <~dwo_file>: New.
7049         (free_dwo_file): Remove, move content to ~dwo_file.
7050         (struct dwo_file_deleter): Remove.
7051         (dwo_file_up>: Remove custom deleter.
7052         (free_dwo_files): Remove.
7053         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7054         dwo_files.
7055         (process_skeletonless_type_units): Call unique_ptr::get.
7056         (allocate_dwo_file_hash_table): Add deleter to created hash
7057         table.  Change return type to htab_up.
7058         (lookup_dwo_file_slot): Don't memset dwo_file, call
7059         unique_ptr::get.
7060         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7061         (create_dwo_unit_in_dwp_v2): Likewise.
7062         (open_and_init_dwo_file): Likewise.
7063         (free_dwo_file_from_slot): Remove.
7064
7065 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7066
7067         * dwarf2read.h (struct dwarf2_section_info) <readin,
7068         is_virtual>: Change type to bool.
7069         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7070         true instead of 1.
7071
7072 2019-06-19  Tom Tromey  <tom@tromey.com>
7073
7074         * tui/tui-data.h (tui_init_content_element): Don't declare.
7075
7076 2019-06-19  Tom Tromey  <tom@tromey.com>
7077
7078         * tui/tui-data.h (tui_init_win_info): Don't declare.
7079
7080 2019-06-19  Tom de Vries  <tdevries@suse.de>
7081
7082         * dwarf2read.h (abstract_to_concrete): Change type to
7083         std::unordered_map<sect_offset, std::vector<sect_offset>,
7084         gdb::hash_enum<sect_offset>>.
7085
7086 2019-06-19  Tom Tromey  <tromey@adacore.com>
7087
7088         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7089         EVAL_AVOID_SIDE_EFFECTS specially.
7090
7091 2019-06-19  Tom Tromey  <tromey@adacore.com>
7092
7093         * source-cache.c (highlighter): New global.
7094         (source_cache::get_source_lines): Create a highlighter on demand.
7095
7096 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * defs.h (deprecated_interactive_hook): Delete declaration.
7099         * interps.c (clear_interpreter_hooks): Remove use of
7100         deprecated_interactive_hook.
7101         * top.c (deprecated_interactive_hook): Delete definition.
7102         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7103
7104 2019-06-18  Tom de Vries  <tdevries@suse.de>
7105
7106         PR gdb/24515
7107         * dwarf2read.h (abstract_to_concrete): Change type from
7108         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7109         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7110         * dwarf2read.c (read_variable): Update.
7111         (dwarf2_fetch_die_loc_sect_off): Update.
7112
7113 2019-06-17  Tom de Vries  <tdevries@suse.de>
7114
7115         PR gdb/24617
7116         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7117         accessing parent[parent_len - 1].
7118
7119 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7120
7121         PR gdb/24364
7122         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7123         call dtrace_process_dof with NULL dof.
7124
7125 2019-06-16  Tom de Vries  <tdevries@suse.de>
7126
7127         PR gdb/24445
7128         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7129
7130 2019-06-16  Tom Tromey  <tom@tromey.com>
7131
7132         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7133         (make_all_visible): Use address of member.
7134
7135 2019-06-16  Tom Tromey  <tom@tromey.com>
7136
7137         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7138         (tui_free_window, free_content, free_content_elements): Remove
7139         unnecessary cast.
7140         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7141         cast.
7142         * tui/tui-regs.c (tui_show_register_group)
7143         (tui_display_registers_from, tui_display_reg_element_at_line):
7144         Remove unnecessary cast.
7145
7146 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * linux-nat.c (normal_mask): Delete.
7149         (_initialize_linux_nat): Don't initialise normal_mask.
7150
7151 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7152
7153         PR gdb/24445
7154         * dwarf-index-write.h (write_psymtabs_to_index): Add
7155         dwz_basename parameter.
7156         * dwarf-index-write.c (write_gdbindex): Move file writing to
7157         write_gdbindex_1.  Change return type void.
7158         (assert_file_size): Move up, remove filename parameter.
7159         (write_gdbindex_1): New function.
7160         (write_debug_names): Change return type to void, call
7161         assert_file_size.
7162         (struct index_wip_file): New struct.
7163         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7164         file logic to index_wip_file.  Write index for dwz file if
7165         needed.
7166         (save_gdb_index_command): Pass basename of dwz file, if present.
7167         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7168         build-id of dwz file, if present.
7169         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7170         (dwarf2_get_dwz_file): Likewise.
7171         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7172         (dwarf2_get_dwz_file): Likewise.
7173
7174 2019-06-16  Tom Tromey  <tom@tromey.com>
7175
7176         * coffread.c (process_coff_symbol): Use xstrdup.
7177         * value.c (create_internalvar): Use xstrdup.
7178
7179 2019-06-16  Tom Tromey  <tom@tromey.com>
7180
7181         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7182         * breakpoint.c (stopin_command, stopat_command)
7183         (until_break_command, decode_location_default): Remove unnecessary
7184         cast.
7185         * utils.c (subset_compare): Remove unnecessary cast.
7186         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7187         cast.
7188         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7189         cast.
7190         * infcmd.c (path_command): Remove unnecessary cast.
7191         * coffread.c (decode_type): Remove unnecessary cast.
7192         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7193         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7194         * tui/tui-stack.c (tui_show_locator_content)
7195         (tui_show_frame_info): Remove unnecessary cast.
7196         * tui/tui-win.c (tui_scroll_forward_command)
7197         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7198         (parse_scrolling_args): Remove unnecessary cast.
7199         * tui/tui-data.c (init_win_info, tui_del_window)
7200         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7201         (free_content_elements): Remove unnecessary cast.
7202         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7203         unnecessary cast.
7204         * tui/tui-source.c (tui_set_source_content)
7205         (tui_vertical_source_scroll): Remove unnecessary cast.
7206         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7207         cast.
7208         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7209         * tui/tui-regs.c (tui_display_registers_from)
7210         (tui_display_register): Remove unnecessary cast.
7211         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7212         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7213         (make_visible): Remove unnecessary cast.
7214         * tui/tui-winsource.c (tui_erase_source_content)
7215         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7216         unnecessary cast.
7217         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7218         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7219         * stabsread.c (read_type, read_array_type, read_range_type):
7220         Remove unnecessary cast.
7221         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7222         (parse_symbol, parse_type, upgrade_type, parse_external)
7223         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7224         unnecessary cast.
7225         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7226
7227 2019-06-16  Tom Tromey  <tom@tromey.com>
7228
7229         * tui/tui-data.c (tui_alloc_generic_win_info)
7230         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7231         checks.
7232
7233 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7234             Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * f-typeprint.c (f_print_type): Don't return early for not
7237         associated or not allocated types.
7238         (f_type_print_varspec_suffix): Add print_rank parameter and print
7239         ranks of array types in case they dangling.
7240         (f_type_print_base): Add print_rank parameter.
7241
7242 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * NEWS: Mention new MI commands.
7245         * break-catch-throw.c (enum exception_event_kind): Move to
7246         breakpoint.h.
7247         (print_mention_exception_catchpoint): Output text as a single
7248         message.
7249         (catch_exception_command_1): Rename to...
7250         (catch_exception_event): ...this, make non-static, update header
7251         command, and change some parameter types.
7252         (catch_catch_command): Update for changes to
7253         catch_exception_command_1.
7254         (catch_throw_command): Likewise.
7255         (catch_rethrow_command): Likewise.
7256         * breakpoint.c (enum exception_event_kind): Delete.
7257         * breakpoint.h (enum exception_event_kind): Moved here from
7258         break-catch-throw.c.
7259         (catch_exception_event): Declare.
7260         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7261         (mi_cmd_catch_throw): New function.
7262         (mi_cmd_catch_rethrow): New function.
7263         (mi_cmd_catch_catch): New function.
7264         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7265         'catch-catch' entries.
7266         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7267         (mi_cmd_catch_rethrow): Declare.
7268         (mi_cmd_catch_catch): Declare.
7269
7270 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * annotate.c (annotate_source_line): Change return type to void,
7273         update implementation to match.
7274         * annotate.h (annotate_source_line): Change return type to void,
7275         update header comment.
7276         * stack.c (print_frame_info): Don't change what frame information
7277         is printed based on whether annotations are on or not.
7278
7279 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7280
7281         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7282         (annotate_source): Make static.
7283         (annotate_source_line): Moved from source.c and renamed from
7284         identify_source_line.  Update the return type.
7285         * annotate.h (annotate_source): Delete declaration.
7286         (annotate_source_line): Declaration moved from source.h, and
7287         renamed from identify_source_line.  Return type updated.
7288         * source.c (identify_source_line): Moved to annotate.c and renamed
7289         to annotate_source_line.
7290         (info_line_command): Remove check of annotation_level.
7291         * source.h (identify_source_line): Move declaration to annotate.h
7292         and rename to annotate_source_line.
7293         * stack.c: Add 'annotate.h' include.
7294         (print_frame_info): Remove check of annotation_level before
7295         calling annotate_source_line.
7296
7297 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * source-cache.c (source_cache::get_plain_source_lines): Use
7300         open_source_file_with_line_charpos instead of just
7301         open_source_file, remove call to find_source_lines.
7302         (source_cache::get_source_lines): Likewise.
7303         * source.c (find_source_lines): Make static.
7304         (get_filename_and_charpos): Renamed into...
7305         (open_source_file_with_line_charpos): ..this along with changes to
7306         return a scoped_fd, and some other minor clean ups.
7307         (identify_source_line): Use open_source_file_with_line_charpos.
7308         (search_command_helper): Use open_source_file_with_line_charpos
7309         instead of just open_source_file, remove call to
7310         find_source_lines.
7311         * source.h (open_source_file_with_line_charpos): Declare new
7312         function.
7313         (find_source_lines): Delete declaration.
7314
7315 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7316
7317         * source.c (get_filename_and_charpos): Remove fullname
7318         parameter.
7319         (identify_source_line): Update call to get_filename_and_charpos.
7320
7321 2019-06-14  Tom Tromey  <tromey@adacore.com>
7322
7323         PR gdb/24502:
7324         * ui-style.h (skip_ansi_escape): Update comment.
7325         * ui-file.h (class no_terminal_escape_file): New class.
7326         * ui-file.c (no_terminal_escape_file::write)
7327         (no_terminal_escape_file::puts): New methods.
7328         * cli/cli-logging.c (handle_redirections): Use
7329         no_terminal_escape_file.
7330
7331 2019-06-14  Tom Tromey  <tromey@adacore.com>
7332
7333         * NEWS: Move convenience variable news above Python news.
7334
7335 2019-06-14  Tom Tromey  <tom@tromey.com>
7336
7337         * gnulib: Move directory to top-level.
7338         * configure.ac: Don't configure gnulib.
7339         * configure: Rebuild.
7340         * common/common-defs.h: Use new path to gnulib.
7341         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7342         (GNULIB_H): Remove.
7343         (INCGNU): Look in new gnulib location.
7344         (HFILES_NO_SRCDIR): Remove gnulib files.
7345         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7346         (generated_files): Remove GNULIB_H.
7347         ($(LIBGNU), all-lib): Remove targets.
7348         (distclean): Don't mention GNULIB_BUILDDIR.
7349         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7350
7351 2019-06-14  Tom Tromey  <tromey@adacore.com>
7352
7353         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7354         Warn if symbol file does not provide any symbols.
7355
7356 2019-06-14  Tom Tromey  <tromey@adacore.com>
7357
7358         * source.c (find_and_open_source): Respect basenames_may_differ.
7359
7360 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * annotate.c (annotate_breakpoints_invalid): Make use of
7363         scoped_restore_terminal_state.
7364         (annotate_frames_invalid): Likewise.
7365
7366 2019-06-14  Tom Tromey  <tromey@adacore.com>
7367
7368         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7369         allow assignment to an internalvar.
7370
7371 2019-06-14  Tom Tromey  <tromey@adacore.com>
7372
7373         * ada-lex.l: Allow "_" in attribute names.
7374
7375 2019-06-14  Tom Tromey  <tromey@adacore.com>
7376
7377         PR gdb/24653:
7378         * regcache.c (registers_changed): Don't call alloca.
7379         * top.c (execute_command): Don't call alloca.
7380
7381 2019-06-13  Pedro Alves  <palves@redhat.com>
7382
7383         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7384         'expression'.  When parsing an expression, error out if there's
7385         junk after "unlimited".
7386         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7387         (do_set_command): Adjust calls to is_unlimited_literal.
7388
7389 2019-06-13  Pedro Alves  <palves@redhat.com>
7390
7391         * compile/compile.c (make_compile_options_def_group): Add braces
7392         around array_view initializer.
7393         * thread.c (make_thread_apply_all_options_def_group)
7394         (make_thread_apply_all_options_def_group): Likewise.
7395
7396 2019-06-13  Pedro Alves  <palves@redhat.com>
7397
7398         * NEWS (New commands): Mention "maint test-options
7399         require-delimiter", "maint test-options unknown-is-error", "maint
7400         test-options unknown-is-operand" and "maint show
7401         test-options-completion-result".
7402         (New command options, command completion): New section.
7403         (Completion improvements): New section.
7404         Mention that you can abbreviate "unlimited".
7405
7406 2019-06-13  Pedro Alves  <palves@redhat.com>
7407
7408         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7409         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7410         * unittests/cli-utils-selftests.c (test_parse_flags)
7411         (test_parse_flags_qcs): Delete.
7412         (test_cli_utils): Don't call deleted functions.
7413
7414 2019-06-13  Pedro Alves  <palves@redhat.com>
7415
7416         * thread.c: Include "cli/cli-option.h".
7417         (tp_array_compar_ascending): Global.
7418         (tp_array_compar): Delete function.
7419         (tp_array_compar_ascending, tp_array_compar_descending): New
7420         functions.
7421         (ascending_option_def, qcs_flag_option_def)
7422         (thr_qcs_flags_option_defs)
7423         (make_thread_apply_all_options_def_group)
7424         (make_thread_apply_options_def_group): New.
7425         (thread_apply_all_command): Use gdb::option::process_options.
7426         (thread_apply_command_completer)
7427         (thread_apply_all_command_completer): New.
7428         (thread_apply_command): Use gdb::option::process_options.
7429         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7430         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7431         to generate help text of "thread apply".  Adjust "taas"'s help.
7432         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7433         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7434
7435 2019-06-13  Pedro Alves  <palves@redhat.com>
7436
7437         * thread.c (thread_apply_command): Check for invalid TID with
7438         isdigit instead of !isalpha.
7439
7440 2019-06-13  Pedro Alves  <palves@redhat.com>
7441
7442         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7443         (validate_flags_qcs): New.
7444         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7445         (validate_flags_qcs): Declare.
7446         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7447         (make_frame_apply_options_def_group): New.
7448         (frame_apply_command_count): Process options with
7449         gdb::option::process_options.
7450         (frame_apply_completer): New.
7451         (frame_apply_level_completer, frame_apply_all_completer)
7452         (frame_apply_completer): New.
7453         (_initialize_stack): Update help of "frame apply", "frame apply
7454         level", "frame apply all" and "faas" to mention supported options
7455         and install command completers.
7456         * stack.h (frame_apply_all_completer): Declare.
7457         * thread.c: Include "stack.h".
7458         (tfaas_command): Add "--".
7459         (_initialize_thread): Update help "tfaas" to mention supported
7460         options and install command completer.
7461
7462 2019-06-13  Pedro Alves  <palves@redhat.com>
7463
7464         * completer.c (complete_nested_command_line): New.
7465         (gdb_completion_word_break_characters_throw): Add assertion.
7466         * completer.h (complete_nested_command_line): Declare.
7467
7468 2019-06-13  Pedro Alves  <palves@redhat.com>
7469
7470         * stack.c (parse_backtrace_qualifiers): New.
7471         (backtrace_command): Use it.
7472         (backtrace_command_completer): Complete on qualifiers.
7473
7474 2019-06-13  Pedro Alves  <palves@redhat.com>
7475
7476         * frame.c: Include "cli/cli-option.h.
7477         (user_set_backtrace_options): New.
7478         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7479         Delete.
7480         (get_prev_frame): Adjust.
7481         (boolean_option_def, uinteger_option_def)
7482         (set_backtrace_option_defs): New.
7483         (_initialize_frame): Adjust and use
7484         gdb::option::add_setshow_cmds_for_options to install "set
7485         backtrace past-main" and "set backtrace past-entry".
7486         * frame.h: Include "cli/cli-option.h".
7487         (struct frame_print_options): Forward declare.
7488         (print_frame_arguments_all, print_frame_arguments_scalars)
7489         (print_frame_arguments_none): Declare.
7490         (print_entry_values): Delete declaration.
7491         (struct frame_print_options, user_frame_print_options): New.
7492         (struct set_backtrace_options): New.
7493         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7494         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7495         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7496         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7497         (list_args_or_locals): Add frame_print_options parameter.
7498         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7499         * python/py-framefilter.c (enumerate_args): Pass down
7500         USER_FRAME_PRINT_OPTIONS.
7501         * stack.c: Include "cli/cli-option.h".
7502         (print_frame_arguments_all, print_frame_arguments_scalars)
7503         (print_frame_arguments_none): Declare.
7504         (print_raw_frame_arguments, print_entry_values): Delete.
7505         (user_frame_print_options): New.
7506         (boolean_option_def, enum_option_def, frame_print_option_defs):
7507         New.
7508         (struct backtrace_cmd_options): New.
7509         (bt_flag_option_def): New.
7510         (backtrace_command_option_defs): New.
7511         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7512         (print_frame_arg, read_frame_arg, print_frame_args)
7513         (print_frame_info, print_frame): Add frame_print_options parameter
7514         and use it.
7515         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7516         (backtrace_command_1): Add frame_print_options and
7517         backtrace_cmd_options parameters and use them.
7518         (make_backtrace_options_def_group): New.
7519         (backtrace_command): Process command options with
7520         gdb::option::process_options.
7521         (backtrace_command_completer): New.
7522         (_initialize_stack): Extend "backtrace"'s help to mention
7523         supported options.  Install completer for "backtrace".
7524         Install some settings commands with add_setshow_cmds_for_options.
7525
7526 2019-06-13  Pedro Alves  <palves@redhat.com>
7527
7528         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7529         and that "set/show print raw frame-arguments" are now deprecated.
7530
7531         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7532         command.
7533         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7534         * stack.c (_initialize_stack): Install "set/show print
7535         raw-frame-arguments", and deprecate "set/show print raw
7536         frame-arguments".
7537         * valprint.c (_initialize_valprint): Deprecate "set/show print
7538         raw".
7539
7540 2019-06-13  Pedro Alves  <palves@redhat.com>
7541
7542         * compile/compile.c (struct compile_options): New.
7543         (compile_flag_option_def, compile_command_option_defs)
7544         (make_compile_options_def_group): New.
7545         (compile_file_command): Handle options with
7546         gdb::option::process_options.
7547         (compile_file_command_completer): New function.
7548         (compile_code_command): Handle options with
7549         gdb::option::process_options.
7550         (compile_code_command_completer): New function.
7551         (_initialize_compiler): Install completers for "compile code" and
7552         "compile file".  Mention available options in "compile code" and
7553         "compile code"'s help.
7554         * completer.c (advance_to_completion_word): New, factored out from
7555         ...
7556         (advance_to_expression_complete_word_point): ... this.
7557         (advance_to_filename_complete_word_point): New.
7558         * completer.h (advance_to_filename_complete_word_point): New
7559         declaration.
7560
7561 2019-06-13  Pedro Alves  <palves@redhat.com>
7562
7563         * compile/compile.c: Include "cli/cli-option.h".
7564         (compile_print_value): Scope data pointer is now a
7565         value_print_options pointer; adjust.
7566         (compile_print_command): Process options.  Scope data pointer is
7567         now a value_print_options pointer; adjust.
7568         (_initialize_compile): Update "compile print"'s help to include
7569         supported options.  Install a completer for "compile print".
7570         * cp-valprint.c (show_vtblprint, show_objectprint)
7571         (show_static_field_print): Delete.
7572         (_initialize_cp_valprint): Don't install "set print
7573         static-members", "set print vtbl", "set print object" here.
7574         * printcmd.c: Include "cli/cli-option.h" and
7575         "common/gdb_optional.h".
7576         (print_command_parse_format): Rework to fill in a
7577         value_print_options instead of a format_data.
7578         (print_value): Change parameter type from format_data pointer to
7579         value_print_options reference.  Adjust.
7580         (print_command_1): Process options.  Adjust to pass down a
7581         value_print_options.
7582         (print_command_completer): New.
7583         (_initialize_printcmd): Install print_command_completer as
7584         handle_brkchars completer for the "print" command.  Update
7585         "print"'s help to include supported options.
7586         * valprint.c: Include "cli/cli-option.h".
7587         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7588         here from cp-valprint.c.
7589         (boolean_option_def, uinteger_option_def)
7590         (value_print_option_defs, make_value_print_options_def_group):
7591         New.  Use gdb::option::add_setshow_cmds_for_options to install
7592         "set print elements", "set print null-stop", "set print repeats",
7593         "set print pretty", "set print union", "set print array", "set
7594         print address", "set print symbol", "set print array-indexes".
7595         * valprint.h: Include <string> and "cli/cli-option.h".
7596         (make_value_print_options_def_group): Declare.
7597         (print_value): Change parameter type from format_data pointer to
7598         value_print_options reference.
7599         (print_command_completer): Declare.
7600
7601 2019-06-13  Pedro Alves  <palves@redhat.com>
7602
7603         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7604         (COMMON_SFILES): Add maint-test-settings.c.
7605         * cli/cli-decode.c (boolean_enums): New global, factored out from
7606         ...
7607         (add_setshow_boolean_cmd): ... here.
7608         * cli/cli-decode.h (boolean_enums): Declare.
7609         * cli/cli-option.c: New file.
7610         * cli/cli-option.h: New file.
7611         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7612         factored out from ...
7613         (parse_cli_boolean_value(const char *)): ... this.
7614         (is_unlimited_literal): Change parameter type to pointer to
7615         pointer.  Adjust and advance ARG pointer.
7616         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7617         (parse_cli_var_enum): New, factored out from ...
7618         (do_set_command): ... this.  Adjust.
7619         * cli/cli-setshow.h (parse_cli_boolean_value)
7620         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7621         (parse_cli_var_enum): Declare.
7622         * cli/cli-utils.c: Include "cli/cli-option.h".
7623         (get_ulongest): New.
7624         * cli/cli-utils.h (get_ulongest): Declare.
7625         (check_for_argument): New overloads.
7626         * maint-test-options.c: New file.
7627
7628 2019-06-13  Pedro Alves  <palves@redhat.com>
7629
7630         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7631         parse a range if "-" is at the end of the string.
7632
7633 2019-06-13  Pedro Alves  <palves@redhat.com>
7634
7635         * cli/cli-setshow.c (parse_auto_binary_operation)
7636         (parse_cli_boolean_value): Don't allow "o".
7637
7638 2019-06-13  Pedro Alves  <palves@redhat.com>
7639
7640         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7641         * NEWS: Mention maint test-settings KIND.
7642         * maint-test-settings.c: New file.
7643
7644 2019-06-13  Pedro Alves  <palves@redhat.com>
7645
7646         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7647         completer.
7648         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7649         "set" completers.
7650
7651 2019-06-13  Pedro Alves  <palves@redhat.com>
7652
7653         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7654         after item.
7655
7656 2019-06-13  Pedro Alves  <palves@redhat.com>
7657
7658         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7659
7660 2019-06-13  Pedro Alves <palves@redhat.com>
7661
7662         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7663         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7664         call.
7665         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7666         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7667         calls.
7668         (check_for_argument): Skip spaces after argument.
7669
7670 2019-06-13  Pedro Alves  <palves@redhat.com>
7671
7672         * thread.c (thread_apply_command): Adjust TID parsing.
7673         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7674         detected before end of string.
7675         (tid_is_in_list): Error out if LIST is invalid.
7676
7677 2019-06-13  Pedro Alves  <palves@redhat.com>
7678
7679         * completer.c (complete_line_internal_1): Rewind completion word
7680         point.
7681         (completion_tracker::advance_custom_word_point_by): Change
7682         parameter type to int.
7683         * completer.h (completion_tracker::advance_custom_word_point_by):
7684         Likewise.
7685
7686 2019-06-13  Pedro Alves  <palves@redhat.com>
7687
7688         * completer.c (advance_to_completion_word): Handle delimiters.
7689
7690 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7691
7692         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7693
7694 2019-06-11  Tom Tromey  <tom@tromey.com>
7695
7696         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7697         (xmalloc_failed): Move to alloc.c.
7698         * alloc.c: New file.
7699         * Makefile.in (COMMON_SFILES): Add alloc.c.
7700
7701 2019-06-11  Tom Tromey  <tom@tromey.com>
7702
7703         * nat/linux-waitpid.c: Don't include server.h.
7704         (linux_debug): Remove.
7705         (my_waitpid): Update.
7706
7707 2019-06-11  Tom Tromey  <tromey@adacore.com>
7708
7709         * infcall.c (_initialize_infcall): Remove trailing newline from
7710         help.
7711         * user-regs.c (_initialize_user_regs): Remove trailing newline
7712         from help.
7713         * typeprint.c (_initialize_typeprint): Remove trailing newline
7714         from help.
7715         * reverse.c (_initialize_reverse): Remove trailing newlines from
7716         help.
7717         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7718         from help.
7719         * language.c (add_set_language_command): Remove trailing newline
7720         from help.
7721         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7722         help.
7723         * disasm.c (_initialize_disasm): Remove trailing newline from
7724         help.
7725         * top.c (init_main): Remove trailing newline from help.
7726         * interps.c (_initialize_interpreter): Remove trailing newline
7727         from help.
7728         * btrace.c (_initialize_btrace): Remove trailing newlines from
7729         help.
7730         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7731         from help.
7732         * python/python.c (_initialize_python): Remove trailing newline
7733         from help.
7734         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7735         help.
7736         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7737         from help.  Reformat some text.
7738         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7739         from help.
7740         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7741         newline from help.
7742
7743 2019-06-11  Tom Tromey  <tromey@adacore.com>
7744
7745         * darwin-nat.c (darwin_decode_exception_message)
7746         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7747
7748 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * valops.c (value_slice): Check for not allocated or not
7751         associated values.
7752
7753 2019-06-10  Tom de Vries  <tdevries@suse.de>
7754
7755         PR gdb/24618
7756         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7757         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7758         invalid.
7759
7760 2019-06-10  Tom de Vries  <tdevries@suse.de>
7761
7762         PR gdb/24611
7763         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7764         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7765
7766 2019-06-10  Tom de Vries  <tdevries@suse.de>
7767
7768         PR symtab/24545
7769         * symtab.c (struct demangled_name_entry): Add language field.
7770         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7771         static minimal symbol".  Set and use language field.
7772
7773 2019-06-10  Tom Tromey  <tromey@adacore.com>
7774
7775         * ada-lang.c (_initialize_ada_language): Update help text.
7776
7777 2019-06-10  Tom Tromey  <tromey@adacore.com>
7778
7779         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7780         with a newline.
7781         * guile/guile.c (handle_boot_error): Don't end warning with a
7782         newline.
7783         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7784         warning with a newline.
7785         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7786         newline.
7787         (s12z_frame_cache): Likewise.
7788         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7789         a newline.
7790         * solib-svr4.c (disable_probes_interface): Don't end warning with
7791         a newline.
7792         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7793         newline.
7794         * python/python.c (do_finish_initialization): Don't end warning
7795         with a newline.
7796
7797 2019-06-10  Tom Tromey  <tom@tromey.com>
7798
7799         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7800         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7801         gdbpy_enter.
7802
7803 2019-06-10  Tom Tromey  <tromey@adacore.com>
7804
7805         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7806         data.
7807         (elf_new_init): Don't call stabsread_new_init.
7808         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7809         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7810         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7811
7812 2019-06-10  Tom de Vries  <tdevries@suse.de>
7813
7814         PR symtab/16264
7815         PR symtab/24517
7816         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7817
7818 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7819
7820         * source.c (find_and_open_source): Also rewrite relative file
7821         names.
7822
7823 2019-04-26  Amos Bird  <amosbird@gmail.com>
7824
7825         * annotate.c (annotate_thread_exited): Add "thread-exited"
7826         annotation.
7827
7828 2019-06-06  Tom Tromey  <tromey@adacore.com>
7829
7830         * maint.h (class scoped_command_stats): Use
7831         DISABLE_COPY_AND_ASSIGN.
7832         <print_time>: New method.
7833         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7834         print_time.
7835         (scoped_command_stats::print_time): New method.
7836
7837 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7840         instructions of lengths 6 or 8 bytes.
7841
7842 2019-06-04  Pedro Alves  <palves@redhat.com>
7843
7844         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7845
7846         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7847         * breakpoint.c (condition_completer): Likewise.
7848         * cli/cli-dump.c (scan_expression): Likewise.
7849         * common/filestuff.c (mkdir_recursive): Likewise.
7850         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7851         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7852         (gdb_abspath): Likewise.
7853         * compile/compile-cplus-types.c
7854         (compile_cplus_instance::decl_name): Likewise.
7855         * completer.c (complete_explicit_location):
7856         (signal_completer, reg_or_group_completer_1): Likewise.
7857         * cp-support.c (cp_remove_params_if_any): Likewise.
7858         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7859         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7860         * infcmd.c (strip_bg_char): Likewise.
7861         * linespec.c (copy_token_string): Likewise.
7862         * mi/mi-main.c (output_cores): Likewise.
7863         * psymtab.c (psymtab_search_name):
7864         * symfile.c (test_set_ext_lang_command): Likewise.
7865         * target.c (target_fileio_read_stralloc): Likewise.
7866         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7867         * value.c (complete_internalvar): Likewise.
7868
7869 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7870
7871         Add objfile property to gdb.Type.
7872         * NEWS: Mention Python API addition.
7873         * python/py-type.c (typy_get_objfile): New method.
7874
7875 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7876
7877         * NEWS: Mention the new set|show style [title|highlight].
7878         Mention changes to "show style", "help" and "apropos".
7879
7880 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7881
7882         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7883         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7884         instead of print_help_for_command.
7885         (print_doc_of_command): New function.
7886         (help_list): Add 'apropos -v word' suggestion.
7887         (print_help_for_command): Style the command name using title style.
7888         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7889         (_initialize_cli_cmds): Describe -v in apropos_command help.
7890
7891 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7892
7893         * cli/cli-style.h (cli_style_option): Add name in constructor,
7894         add m_name class member, add constructor with intensity,
7895         add name class function.
7896         (cli_style_option::add_setshow_commands): Remove name argument.
7897         (highlight_style, title_style): New styles.
7898         * cli/cli-style.c (do_show): New function that shows a style
7899         characteristic styling the style name with itself.
7900         (set_style_name): New function.
7901         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7902         Update all callers according to the changes in cli/cli-style.h.
7903         * utils.h (fputs_highlighted): New function.
7904         * utils.c (fputs_highlighted): Likewise.
7905
7906 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7907
7908         * NEWS: Mention new pipe command and new convenience variables.
7909
7910 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7911
7912         * cli/cli-cmds.c (pipe_command): New function.
7913         (_initialize_cli_cmds): Call add_com for pipe_command.
7914         Define | as an alias for pipe.
7915         (exit_status_set_internal_vars): New function.
7916         (shell_escape): Call exit_status_set_internal_vars.
7917         cli/cli-decode.c (find_command_name_length): Recognize | as
7918         a single character command.
7919
7920 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7921
7922         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7923         top.c (execute_command_to_ui_file): New function, mostly a copy
7924         of execute_command_to_string.
7925         (execute_command_to_string): Implement by calling
7926         execute_command_to_ui_file.
7927
7928 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7929
7930         * top.h (saved_command_line): Remove declaration.
7931         * top.c (previous_saved_command_line, previous_repeat_arguments):
7932         New variables.
7933         (saved_command_line): Make static, define together with other
7934         'repeat variables'.
7935         (dont_repeat): Clear repeat_arguments.
7936         (repeat_previous, get_saved_command_line, save_command_line):
7937         New functions.
7938         (gdb_init): Initialize saved_command_line
7939         and previous_saved_command_line.
7940         * main.c (captured_main_1): Remove saved_command_line initialization.
7941         * event-top.c (handle_line_of_input): Update to use
7942         the new 'repeat' related functions instead of direct access to
7943         saved_command_line.
7944         * command.h (repeat_previous, get_saved_command_line,
7945         save_command_line): New declarations.
7946         (dont_repeat): Add comment.
7947
7948 2019-05-30  Tom Tromey  <tromey@adacore.com>
7949
7950         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7951         Fix comment.
7952         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7953
7954 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7955
7956         PR cli/24587
7957         * completer.c (complete): Initialize variable word.
7958
7959 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7960
7961         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7962         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7963         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7964         'body' is NULL to the outter 'if', protecting the '!is_define'
7965         situation as well.
7966
7967 2019-05-29  Tom Tromey  <tromey@adacore.com>
7968
7969         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7970         (dwarf_unknown): New function.
7971         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7972         (dwarf_type_encoding_name): Use dwarf_unknown.
7973
7974 2019-05-29  Tom Tromey  <tromey@adacore.com>
7975
7976         PR c++/20020:
7977         * cp-valprint.c (cp_print_value_fields): Call
7978         cp_print_static_field inside "try".
7979
7980 2019-05-29  Tom Tromey  <tromey@adacore.com>
7981
7982         * inflow.c (struct terminal_info): Add default operator=.
7983         * configure: Rebuild.
7984         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7985         -Wdeprecated-copy-dtor, -Wredundant-move.
7986
7987 2019-05-29  Tom Tromey  <tromey@adacore.com>
7988
7989         * NEWS: Add entry.
7990         * infcmd.c (print_return_value_1): Handle finish_print
7991         option.
7992         (show_print_finish): New function.
7993         (_initialize_infcmd): Add "set/show print finish" commands.
7994         * valprint.c (user_print_options): Initialize new member.
7995         * valprint.h (struct value_print_options) <finish_print>: New
7996         member.
7997
7998 2019-05-28  Tom Tromey  <tromey@adacore.com>
7999
8000         * ada-lang.c (ada_remove_Xbn_suffix)
8001         (find_old_style_renaming_symbol)
8002         (parse_old_style_renaming): Remove.
8003         (ada_find_renaming_symbol): Don't call
8004         find_old_style_renaming_symbol.
8005         (ada_is_renaming_symbol): Rename from
8006         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8007         bool.  Now static.
8008         (ada_read_var_value): Update and simplify.
8009         * ada-exp.y (write_var_or_type): Remove old code.
8010
8011 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8012
8013         PR gdb/25010
8014         * event-top.c: Remove include comment.
8015         * inflow.c (class scoped_ignore_sigttou): Move from here...
8016         * inflow.h (class scoped_ignore_sigttou): ...to here.
8017         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8018         * top.c:  Remove include comment.
8019
8020 2019-05-27  Tom Tromey  <tom@tromey.com>
8021
8022         * NEWS: Fix typo.
8023
8024 2019-05-22  Tom Tromey  <tromey@adacore.com>
8025
8026         * target.c (target_follow_exec): Constify parameter.
8027         * target-delegates.c: Rebuild.
8028         * remote.c (remote_target::follow_exec): Constify parameter.
8029         * infrun.c (follow_exec): Constify parameter.
8030         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8031         (target_follow_exec): Likewise.
8032
8033 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8034
8035         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8036         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8037
8038 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8039
8040         * NEWS: Add debugredirect and testsuite sections.
8041
8042 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8043
8044         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8045         target descriptions using exclusively floating point register name
8046         aliases.
8047
8048 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         PR gdb/18644:
8051         * f-lang.c (build_fortran_types): Handle the case where
8052         gdbarch_floatformat_for_type returns a nullptr.
8053
8054 2019-05-21  Tom de Vries  <tdevries@suse.de>
8055
8056         PR cli/24587
8057         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8058
8059 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8060
8061         PR gdb/18644:
8062         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8063         16-byte floats.
8064         * i386-tdep.c (i386_floatformat_for_type): Use
8065         floatformats_ia64_quad for the 16-byte floating point component
8066         within a fortran 32-byte complex number.
8067
8068 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8071         delete default constructor.
8072         (find_partial_die): Update to return const struct.
8073         (partial_die_parent_scope): Move variable declaration into scope
8074         of its use and change its type to auto.
8075         (guess_partial_die_structure_name): Likewise.
8076         (partial_die_info::fixup): Likewise.
8077
8078 2019-05-17  Tom Tromey  <tromey@adacore.com>
8079
8080         * source.c (find_and_open_source): Remove cast.
8081
8082 2019-05-17  Tom Tromey  <tromey@adacore.com>
8083
8084         * annotate.c (annotate_source): Make "filename" const.
8085         * annotate.h (annotate_source): Use const.
8086
8087 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8088
8089         * disasm.c (set_disassembler_options): Send errors to stderr.
8090
8091 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8092
8093         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8094         (cli_interp_base::set_logging): Check debug_redirect.
8095         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8096         * cli/cli-logging.c (debug_redirect): Add static variable.
8097         (pop_output_files): Add default param.
8098         (handle_redirections): Print debug setting.
8099         (show_logging_command): Likewise.
8100         (_initialize_cli_logging): Add debugredirect command.
8101         * interps.c (current_interp_set_logging): Add debug_redirect
8102         parameter.
8103         * interps.h (set_logging): Add debug_redirect parameter.
8104         (current_interp_set_logging): Likewise.
8105         * mi/mi-common.h: Likewise.
8106         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8107
8108 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8109             Tom Tromey  <tromey@adacore.com>
8110
8111         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8112         directly.
8113         * cli/cli-interp.h (make_logging_output): Remove declaration.
8114         * cli/cli-logging.c (make_logging_output): Remove function.
8115         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8116         directly.
8117         * ui-file.c (tee_file::tee_file): Remove bools.
8118         (tee_file::~tee_file): Remove deletes.
8119         * ui-file.h (tee_file): Remove bools.
8120
8121 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8122
8123         * mi/mi-cmds.h (mi_cmd_complete): New function.
8124         * mi/mi-main.c (mi_cmd_complete): Likewise.
8125         * mi/mi-cmds.c: Define new MI command -complete.
8126         * NEWS: Mention new -complete command.
8127
8128 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8129
8130         * completer.h (complete): New function.
8131         * completer.c (complete): Likewise.
8132         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8133         function defined in completer.h.
8134
8135 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8136
8137         * MAINTAINERS (Write After Approval): Add myself.
8138
8139 2019-05-17  Tom de Vries  <tdevries@suse.de>
8140
8141         PR gdb/24094
8142         * dwarf2read.c (struct cu_partial_die_info): New struct.
8143         (find_partial_die): Return cu_partial_die_info.
8144         (partial_die_parent_scope, guess_partial_die_structure_name)
8145         (partial_die_info::fixup): Handle new return type of find_partial_die.
8146
8147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8148
8149         PR breakpoints/24541
8150         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8151         "std::string", simplifying the algorithm.
8152
8153 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8154
8155         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8156         (stap_static_probe_ops::get_probes): Likewise.
8157
8158 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8159
8160         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8161         '-')" and "else if".
8162         (stap_parse_single_operand): Join checks for
8163         "gdbarch_stap_parse_special_token_p" and
8164         "gdbarch_stap_parse_special_token" in the same "if" statement.
8165         Invert check when verifying for operation on register
8166         displacement.
8167
8168 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8169
8170         * stap-probe.c (stap_get_opcode): Update comment.
8171         (stap_get_expected_argument_type): Likewise.
8172         (handle_stap_probe): Likewise.
8173
8174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8175
8176         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8177         return type to 'bool'.  Adjust comment.  Use 'bool' when
8178         appropriate.
8179         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8180         * stap-probe.c (stap_parse_argument_1): Likewise.
8181         (stap_is_operator): Likewise.
8182         (stap_is_generic_prefix): Likewise.
8183         (stap_is_register_prefix): Likewise.
8184         (stap_is_register_indirection_prefix): Likewise.
8185         (stap_is_integer_prefix): Likewise.
8186         (stap_generic_check_suffix): Likewise.
8187         (stap_check_integer_suffix): Likewise.
8188         (stap_check_register_suffix): Likewise.
8189         (stap_check_register_indirection_suffix): Likewise.
8190         (stap_parse_register_operand): Likewise.
8191         (stap_parse_single_operand): Likewise.
8192         (stap_parse_argument_1): Likewise.
8193         (stap_probe::get_argument_count): Likewise.
8194         (stap_is_operator): Likewise.
8195
8196 2019-05-16  Tom Tromey  <tromey@adacore.com>
8197
8198         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8199         keyword to foreach.
8200
8201 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8202
8203         * linux-thread-db.c (try_thread_db_load_1): Change return type
8204         to bool.
8205         (try_thread_db_load): Likewise.
8206         (try_thread_db_load_from_pdir_1): Likewise.
8207         (try_thread_db_load_from_pdir): Likewise.
8208         (try_thread_db_load_from_sdir): Likewise.
8209         (try_thread_db_load_from_dir): Likewise.
8210         (thread_db_load_search): Likewise.
8211         (has_libpthread): Likewise.
8212         (thread_db_load): Likewise.
8213
8214 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8215
8216         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8217         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8218         NULL, and complain/return if that's the case.
8219
8220 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8221
8222         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8223         (advance, posn, abstract_read_memory): New functions.
8224         [struct mem_read_abstraction]: New struct.
8225         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8226
8227 2019-05-14  Tom Tromey  <tromey@adacore.com>
8228
8229         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8230         value is not lval_memory.
8231
8232 2019-05-14  Tom Tromey  <tromey@adacore.com>
8233
8234         * solib.c (info_sharedlibrary_command): Style the file name.
8235
8236 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8237
8238         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8239         (aarch64_vnv_type): Likewise.
8240         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8241         * common/tdesc.c: Likewise.
8242         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8243         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8244         * features/aarch64-fpu.xml: Add ieee half view.
8245         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8246         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8247         * gdbtypes.h (struct builtin_type): Likewise.
8248         (struct objfile_type): Likewise.
8249
8250 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8251
8252         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8253         typo.
8254         * location.h (string_to_event_location): Likewise.
8255
8256 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8257
8258         GDB 8.3 released.
8259
8260 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8261
8262         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8263         New variable declaration.
8264         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8265         New variable.
8266         (print_one_breakpoint): Use ui_out::test_flags and new global
8267         variable to compute use_fixed_output.
8268         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8269         Remove.
8270         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8271         (mi_multi_location_breakpoint_output_fixed): Remove.
8272         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8273         new variable.
8274         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8275         fix_multi_location_breakpoint_output flag if version >= 3.
8276         * ui-out.h (enum ui_out_flag)
8277         <fix_multi_location_breakpoint_output>: New enumerator.
8278
8279 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8280
8281         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8282
8283 2019-05-10  Tom Tromey  <tromey@adacore.com>
8284
8285         * ada-lang.c (catch_ada_completer): New function.
8286         (_initialize_ada_language): Use it.
8287
8288 2019-05-10  Tom Tromey  <tromey@adacore.com>
8289
8290         * thread.c (print_thread_info): Make "requested_threads" const.
8291         * gdbthread.h (print_thread_info): Make "requested_threads"
8292         const.
8293         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8294         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8295
8296 2019-05-08  Tom Tromey  <tom@tromey.com>
8297
8298         * gdbtypes.c (objfile_type_data): Change type.
8299         (objfile_type, _initialize_gdbtypes): Update.
8300
8301 2019-05-08  Tom Tromey  <tom@tromey.com>
8302
8303         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8304         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8305         (_initialize_dwarf2_frame): Update.
8306
8307 2019-05-08  Tom Tromey  <tom@tromey.com>
8308
8309         * objc-lang.c (objc_objfile_data): Change type.
8310         (find_methods): Update.
8311         (_initialize_objc_lang): Remove.
8312
8313 2019-05-08  Tom Tromey  <tom@tromey.com>
8314
8315         * stabsread.c (rs6000_builtin_type_data): Change type.
8316         (rs6000_builtin_type, _initialize_stabsread): Update.
8317
8318 2019-05-08  Tom Tromey  <tom@tromey.com>
8319
8320         * mips-tdep.c (mips_pdr_data): Remove.
8321         (_initialize_mips_tdep): Update.
8322
8323 2019-05-08  Tom Tromey  <tom@tromey.com>
8324
8325         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8326         (hppa_init_objfile_priv_data, read_unwind_info)
8327         (find_unwind_entry, _initialize_hppa_tdep): Update.
8328
8329 2019-05-08  Tom Tromey  <tom@tromey.com>
8330
8331         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8332         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8333         on obstack.
8334         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8335
8336 2019-05-08  Tom Tromey  <tom@tromey.com>
8337
8338         * mdebugread.c (basic_type_data): Change type.
8339         (basic_type, _initialize_mdebugread): Update.
8340
8341 2019-05-08  Tom Tromey  <tom@tromey.com>
8342
8343         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8344
8345 2019-05-08  Tom Tromey  <tom@tromey.com>
8346
8347         * nto-tdep.c (nto_inferior_data_reg): Change type.
8348         (nto_inferior_data): Update.
8349         (nto_inferior_data_cleanup, nto_new_inferior_data)
8350         (_initialize_nto_tdep): Remove.
8351         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8352
8353 2019-05-08  Tom Tromey  <tom@tromey.com>
8354
8355         * ada-lang.c (struct ada_inferior_data): Add initializers.
8356         (ada_inferior_data): Change type.
8357         (ada_inferior_data_cleanup): Remove.
8358         (get_ada_inferior_data, ada_inferior_exit)
8359         (struct ada_pspace_data): Add initializers, destructor.
8360         (ada_pspace_data_handle): Change type.
8361         (get_ada_pspace_data): Update.
8362         (ada_pspace_data_cleanup): Remove.
8363
8364 2019-05-08  Tom Tromey  <tom@tromey.com>
8365
8366         * coffread.c (struct coff_symfile_info): Add initializers.
8367         (coff_objfile_data_key): Move lower.  Change type.
8368         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8369         Update.
8370         (coff_free_info): Remove.
8371
8372 2019-05-08  Tom Tromey  <tom@tromey.com>
8373
8374         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8375         (fbsd_pspace_data_handle): Move lower.  Change type.
8376         (get_fbsd_pspace_data): Update.
8377         (fbsd_pspace_data_cleanup): Remove.
8378         (_initialize_fbsd_tdep): Update.
8379
8380 2019-05-08  Tom Tromey  <tom@tromey.com>
8381
8382         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8383         (get_ada_tasks_pspace_data): Update.
8384         (ada_tasks_pspace_data_cleanup): Remove.
8385         (_initialize_tasks): Update.
8386         (ada_tasks_inferior_data_handle): Change type.
8387         (get_ada_tasks_inferior_data): Update.
8388         (ada_tasks_inferior_data_cleanup): Remove.
8389         (struct ada_tasks_pspace_data): Add initializers.
8390
8391 2019-05-08  Tom Tromey  <tom@tromey.com>
8392
8393         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8394         * symfile-debug.c (debug_sym_get_probes): Change type.
8395         * stap-probe.c (handle_stap_probe):
8396         (stap_static_probe_ops::get_probes): Change type.
8397         * probe.h (class static_probe_ops) <get_probes>: Change type.
8398         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8399         (parse_probes_in_pspace): Update.
8400         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8401         Update.
8402         (any_static_probe_ops::get_probes): Change type.
8403         * elfread.c (elfread_data): New typedef.
8404         (probe_key): Change type.
8405         (elf_get_probes): Likewise.  Update.
8406         (probe_key_free): Remove.
8407         (_initialize_elfread): Update.
8408         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8409         Change type.
8410         (dtrace_process_dof_probe, dtrace_process_dof)
8411         (dtrace_static_probe_ops::get_probe): Change type.
8412
8413 2019-05-08  Tom Tromey  <tom@tromey.com>
8414
8415         * xcoffread.c (struct xcoff_symfile_info): Rename from
8416         coff_symfile_info.  Add initializers.
8417         (xcoff_objfile_data_key): Move lower.  Change type.
8418         (XCOFF_DATA): Rewrite.
8419         (xcoff_free_info): Remove.
8420         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8421         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8422         (xcoff_initial_scan): Update.
8423
8424 2019-05-08  Tom Tromey  <tom@tromey.com>
8425
8426         * solib-svr4.c (struct svr4_info): Add initializers and
8427         destructor.
8428         <probes_table>: Now an htab_up.
8429         (solib_svr4_pspace_data): Change type.
8430         (free_probes_table): Simplify.
8431         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8432         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8433         (probes_table_remove_objfile_probes, register_solib_event_probe)
8434         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8435         (_initialize_svr4_solib): Update.
8436
8437 2019-05-08  Tom Tromey  <tom@tromey.com>
8438
8439         * remote.c (remote_pspace_data): Change type.
8440         (remote_pspace_data_cleanup): Remove.
8441         (get_remote_exec_file, set_pspace_remote_exec_file)
8442         (_initialize_remote): Update.
8443
8444 2019-05-08  Tom Tromey  <tom@tromey.com>
8445
8446         * breakpoint.c (breakpoint_objfile_key): Change type.
8447         (get_breakpoint_objfile_data): Update.
8448         (free_breakpoint_objfile_data): Remove.
8449         (_initialize_breakpoint): Update.
8450
8451 2019-05-08  Tom Tromey  <tom@tromey.com>
8452
8453         * linux-tdep.c (struct linux_info): Add initializers.
8454         (linux_inferior_data): Move.  Change type.
8455         (invalidate_linux_cache_inf): Update.
8456         (linux_inferior_data_cleanup): Remove.
8457         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8458
8459 2019-05-08  Tom Tromey  <tom@tromey.com>
8460
8461         * auxv.c (auxv_inferior_data): Move.  Change type.
8462         (auxv_inferior_data_cleanup): Remove.
8463         (invalidate_auxv_cache_inf): Rewrite.
8464         (get_auxv_inferior_data, _initialize_auxv): Update.
8465
8466 2019-05-08  Tom Tromey  <tom@tromey.com>
8467
8468         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8469         (symfile_debug_objfile_data_key): Change type.
8470         (symfile_debug_installed, debug_qf_has_symbols)
8471         (debug_qf_find_last_source_symtab)
8472         (debug_qf_forget_cached_source_info)
8473         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8474         (debug_qf_print_stats, debug_qf_dump)
8475         (debug_qf_expand_symtabs_for_function)
8476         (debug_qf_expand_all_symtabs)
8477         (debug_qf_expand_symtabs_with_fullname)
8478         (debug_qf_map_matching_symbols)
8479         (debug_qf_expand_symtabs_matching)
8480         (debug_qf_find_pc_sect_compunit_symtab)
8481         (debug_qf_map_symbol_filenames)
8482         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8483         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8484         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8485         (debug_sym_read_linetable, debug_sym_relocate): Update.
8486         (symfile_debug_free_objfile): Remove.
8487         (install_symfile_debug_logging, _initialize_symfile_debug):
8488         Update.
8489
8490 2019-05-08  Tom Tromey  <tom@tromey.com>
8491
8492         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8493         allocate_on_obstack.
8494         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8495         (get_dwarf2_per_objfile): Update.
8496         (set_dwarf2_per_objfile): Remove.
8497         (dwarf2_has_info, dwarf2_get_section_info): Update.
8498         (dwarf2_free_objfile): Remove.
8499         (_initialize_dwarf2_read): Update.
8500
8501 2019-05-08  Tom Tromey  <tom@tromey.com>
8502
8503         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8504         initializers.
8505         <unsupported_script_warning_printed,
8506         script_not_found_warning_printed>: Now bool.
8507         (auto_load_pspace_data): Change type.
8508         (~auto_load_pspace_info): Rename from
8509         auto_load_pspace_data_cleanup.
8510         (get_auto_load_pspace_data, init_loaded_scripts_info)
8511         (clear_section_scripts, maybe_print_unsupported_script_warning)
8512         (maybe_print_script_not_found_warning, _initialize_auto_load):
8513         Update.
8514
8515 2019-05-08  Tom Tromey  <tom@tromey.com>
8516
8517         * objfiles.c (objfile_pspace_info): Add destructor and
8518         initializers.
8519         (objfiles_pspace_data): Change type.
8520         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8521         (get_objfile_pspace_data): Update.
8522         (objfiles_bfd_data): Change type.
8523         (get_objfile_bfd_data): Update.
8524         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8525
8526 2019-05-08  Tom Tromey  <tom@tromey.com>
8527
8528         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8529         Change type.
8530         (get_catch_syscall_inferior_data): Update.
8531         (catch_syscall_inferior_data_cleanup): Remove.
8532         (_initialize_break_catch_syscall): Update.
8533
8534 2019-05-08  Tom Tromey  <tom@tromey.com>
8535
8536         * inflow.c (struct terminal_info): Add destructor and
8537         initializers.
8538         (inflow_inferior_data): Change type.
8539         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8540         (get_inflow_inferior_data, inflow_inferior_exit)
8541         (swap_terminal_info, _initialize_inflow): Update.
8542
8543 2019-05-08  Tom Tromey  <tom@tromey.com>
8544
8545         * target-dcache.c (target_dcache_cleanup): Remove.
8546         (target_dcache_aspace_key): Change type.
8547         (target_dcache_init_p, target_dcache_invalidate)
8548         (target_dcache_get, target_dcache_get_or_init)
8549         (_initialize_target_dcache): Update.
8550         * dcache.h (struct dcache_deleter): New.
8551
8552 2019-05-08  Tom Tromey  <tom@tromey.com>
8553
8554         * symtab.c (struct symbol_cache): Add destructor and
8555         initializers.
8556         (symbol_cache_key): Move.  Change type.
8557         (make_symbol_cache, free_symbol_cache): Remove.
8558         (get_symbol_cache): Update.
8559         (symbol_cache_cleanup): Remove.
8560         (ALL_PSPACES, symbol_cache_flush)
8561         (maintenance_print_symbol_cache)
8562         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8563         Update.
8564
8565 2019-05-08  Tom Tromey  <tom@tromey.com>
8566
8567         * symtab.c (struct main_info): Add destructor and initializers.
8568         (main_progspace_key): Move.  Change type.
8569         (get_main_info): Update.
8570         (main_info_cleanup): Remove.
8571         (_initialize_symtab): Update.
8572
8573 2019-05-08  Tom Tromey  <tom@tromey.com>
8574
8575         * registry.h (DECLARE_REGISTRY): Define the _key class.
8576
8577 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * NEWS: Merge two 'New commands' sections.
8580
8581 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8582
8583         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8584         parameter and use Ada language definition instead.
8585         (ada_val_print_ptr): Remove unused language parameter.
8586         (ada_val_print_num): Remove language parameter and use Ada language
8587         definition instead.
8588         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8589         parameter.
8590         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8591         parameter and use Ada language definition instead.
8592         (ada_val_print_1): Update all ada_val_print_xxx calls.
8593         Remove language parameter.
8594         (ada_val_print): Update ada_val_print_1 call.
8595
8596 2019-05-08  Tom Tromey  <tromey@adacore.com>
8597
8598         * remote.c (remote_hw_watchpoint_limit)
8599         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8600         Now static.
8601
8602 2019-05-08  Tom Tromey  <tromey@adacore.com>
8603
8604         * maint.c (_initialize_maint_cmds): Move initialization code to
8605         remote.c.
8606         (watchdog, show_watchdog): Move to remote.c.
8607         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8608         "watchdog" static.
8609         (_initialize_remote): Move initialization code from maint.c.
8610         * defs.h (watchdog): Don't declare.
8611
8612 2019-05-08  Tom Tromey  <tromey@adacore.com>
8613
8614         * tui/tui-interp.c: Include main.h.
8615         * interps.c: Include main.h.
8616         * main.h (interpreter_p): Declare.
8617         * defs.h (interpreter_p): Don't declare.
8618
8619 2019-05-08  Tom Tromey  <tromey@adacore.com>
8620
8621         * dwarf2loc.c: Include dwarf2read.h.
8622         * defs.h (read_unsigned_leb128): Don't declare.
8623         * dwarf2read.h (read_unsigned_leb128): Declare.
8624
8625 2019-05-08  Tom Tromey  <tromey@adacore.com>
8626
8627         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8628         method.
8629
8630 2019-05-08  Tom Tromey  <tromey@adacore.com>
8631
8632         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8633         when no wrap column is set.
8634
8635 2019-05-08  Tom Tromey  <tromey@adacore.com>
8636
8637         * c-lang.c (c_get_string): Handle non-C-style arrays.
8638
8639 2019-05-08  Tom Tromey  <tromey@adacore.com>
8640
8641         * typeprint.c (print_offset_data::update): Print the bit offset,
8642         not the number of bits remaining.
8643
8644 2019-05-08  Tom Tromey  <tromey@adacore.com>
8645
8646         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8647         padding at end of comment.
8648
8649 2019-05-08  Tom Tromey  <tromey@adacore.com>
8650
8651         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8652         Compare main types.
8653
8654 2019-05-06  Tom Tromey  <tom@tromey.com>
8655
8656         * common/scoped_mmap.c: Include common-defs.h.
8657         * common/scoped_mmap.h: Don't include config.h.
8658
8659 2019-05-04  Tom Tromey  <tom@tromey.com>
8660
8661         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8662         (struct aarch64_call_info): Add initializers.
8663         <si>: Now a std::vector.
8664         (pass_on_stack, aarch64_push_dummy_call): Update.
8665
8666 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8667             Tom Tromey  <tom@tromey.com>
8668
8669         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8670         (ppc_threads): Now a std::vector.  Now static.
8671         (hwdebug_find_thread_points_by_tid)
8672         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8673         Update.
8674
8675 2019-05-04  Tom Tromey  <tom@tromey.com>
8676
8677         * arc-tdep.c (arc_tdesc_init): Return bool.
8678
8679 2019-05-04  Tom Tromey  <tom@tromey.com>
8680
8681         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8682         Use gdb_assert_not_reached.
8683
8684 2019-05-04  Tom Tromey  <tom@tromey.com>
8685
8686         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8687         "false".
8688
8689 2019-05-04  Tom Tromey  <tom@tromey.com>
8690
8691         * arc-tdep.c (arc_tdesc_init): Use bool.
8692
8693 2019-05-04  Tom Tromey  <tom@tromey.com>
8694
8695         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8696
8697 2019-05-04  Tom Tromey  <tom@tromey.com>
8698
8699         * cli/cli-cmds.c (valid_command_p): Return bool.
8700
8701 2019-05-04  Tom Tromey  <tom@tromey.com>
8702
8703         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8704         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8705
8706 2019-05-04  Raul Tambre  <raul@tambre.ee>
8707
8708         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8709         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8710         operator for comparison.
8711
8712 2019-05-04  Tom Tromey  <tom@tromey.com>
8713
8714         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8715         (lookup_partial_symbol, print_partial_symbols)
8716         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8717         (psymbol_compare): Update.
8718         (add_psymbol_to_bcache): Clear the entire psymbol.
8719         (maintenance_check_psymtabs): Update.
8720         * psympriv.h (struct partial_symbol): Don't derive from
8721         general_symbol_info.
8722         <obj_section, unrelocated_address, address,
8723         set_unrelocated_address>: Update.
8724         <ginfo>: New member.
8725         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8726         (debug_names::write_psymbols): Update.
8727
8728 2019-05-04  Tom de Vries  <tdevries@suse.de>
8729
8730         * contrib/cc-with-tweaks.sh: Support -n arg.
8731
8732 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8733
8734         * corelow.c (core_target::detach): Ensure frame cache and
8735         register caches are cleared.
8736         inferior.c (exit_inferior_1): Likewise.
8737
8738 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8739             Tom Tromey  <tom@tromey.com>
8740
8741         * dictionary.c (collate_pending_symbols_by_language): Remove
8742         "struct" from foreach.
8743         * symtab.c (lookup_global_symbol_from_objfile)
8744         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8745         foreach.
8746         * ser-tcp.c (net_open): Remove "struct" from foreach.
8747         * objfiles.c (objfile_relocate, objfile_rebase)
8748         (objfile_has_symbols): Remove "struct" from foreach.
8749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8750         from foreach.
8751         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8752         foreach.
8753         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8754         "struct" from foreach.
8755         * ada-lang.c (create_excep_cond_exprs)
8756         (ada_exception_catchpoint_cond_string): Remove "struct" from
8757         foreach.
8758
8759 2019-05-03  Tom Tromey  <tromey@adacore.com>
8760
8761         * ada-exp.y (convert_char_literal): Check suffix of each
8762         enumerator.
8763
8764 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8765
8766         PR ada/21406:
8767         * ada-exp.y (yywrap): Don't define.
8768         * ada-lex.l (%option): Add noyywrap
8769         (yywrap): Remove.
8770
8771 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8772
8773         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8774         _WIN32_WINNT to the XP level, unless already defined to a higher
8775         level.
8776
8777         * unittests/parse-connection-spec-selftests.c:
8778         * ser-tcp.c:
8779         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8780         override.
8781
8782         * symfile.c (find_separate_debug_file): Remove colon from the
8783         drive spec of DOS/Windows file names of the target, so that the
8784         file name produced from DEBUGDIR and the target's directory will
8785         be valid on DOS/Windows systems.
8786
8787 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8788
8789         * rust-lang.c (val_print_struct): Handle printing structures
8790         containing strings.
8791
8792 2019-05-02  Tom Tromey  <tromey@adacore.com>
8793
8794         * valarith.c (_initialize_valarith): Remove.
8795
8796 2019-05-01  Tom Tromey  <tromey@adacore.com>
8797
8798         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8799         bitfields.
8800
8801 2019-05-01  Tom Tromey  <tromey@adacore.com>
8802
8803         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8804         for big-endian copies.
8805
8806 2019-04-30  Ali Tamur  <tamur@google.com>
8807         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8808         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8809         (read_3_bytes): New function.
8810
8811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8812
8813         * windows-nat.c (main_thread_id): Delete.
8814         (handle_output_debug_string): Replace main_thread_id by
8815         current_event.dwThreadId.
8816         (fake_create_process): Likewise.
8817         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8818         Do not set main_thread_id.
8819         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8820         current_event.dwThreadId.
8821         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8822
8823 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8824
8825         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8826         Use current_event.dwThreadId instead of main_thread_id.
8827
8828 2019-04-30  Tom Tromey  <tromey@adacore.com>
8829
8830         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8831         (create_excep_cond_exprs): Iterate over program spaces.
8832         (ada_exception_catchpoint_cond_string): Examine all minimal
8833         symbols for exception types.
8834
8835 2019-04-30  Tom Tromey  <tromey@adacore.com>
8836
8837         PR c++/24470:
8838         * dwarf2read.c (process_structure_scope): Handle case where type
8839         has template parameters but no symbol was created.
8840
8841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8842             Chris January  <chris.january@arm.com>
8843
8844         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8845         qualifier.
8846         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8847
8848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * f-typeprint.c (f_print_type): Update rules for printing
8851         whitespace.
8852         (f_type_print_varspec_suffix): Likewise.
8853
8854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8855             Chris January  <chris.january@arm.com>
8856
8857         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8858         function arguments.
8859
8860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * f-lang.c (build_fortran_types): Change name of void type to
8863         lower case.
8864         * f-typeprint.c (f_type_print_base): Print the name of the void
8865         type, rather than a fixed string.
8866         * f-valprint.c (f_decorations): Use lower case void string.
8867
8868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8869             Chris January  <chris.january@arm.com>
8870
8871         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8872         types for Fortran.
8873
8874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8875             Chris January  <chris.january@arm.com>
8876             David Lecomber  <david.lecomber@arm.com>
8877
8878         * f-exp.y (BINOP_INTRINSIC): New token.
8879         (exp): New parser rule handling BINOP_INTRINSIC.
8880         (f77_keywords): Add new builtin procedures.
8881         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8882         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8883         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8884         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8885         (print_unop_subexp_f): New function.
8886         (print_binop_subexp_f): New function.
8887         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8888         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8889         (dump_subexp_body_f): Likewise.
8890         (operator_check_f): Likewise.
8891         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8892         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8893
8894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8897         UNOP_KIND.
8898         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8899         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8900         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8901         (operator_length_f): New fuction.
8902         (print_subexp_f): New function.
8903         (op_name_f): New function.
8904         (dump_subexp_body_f): New function.
8905         (operator_check_f): New function.
8906         (exp_descriptor_f): Replace standard expression handling functions
8907         with new functions.
8908         * gdb/fortran-operator.def: New file.
8909         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8910         * gdb/std-operator.def: Remove UNOP_KIND.
8911
8912 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * std-operator.def: Remove unbalanced, stray double quote
8915         character.
8916
8917 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8918             Chris January  <chris.january@arm.com>
8919             Daniel Everett  <daniel.everett@arm.com>
8920             Nick Forrington  <nick.forrington@arm.com>
8921             Richard Bunt  <richard.bunt@arm.com>
8922
8923         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8924         of depth when printing anonymous structs or unions.
8925         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8926         Don't print either the top-level value, or the children if the
8927         max-depth is exceeded.
8928         (ppscm_print_children): When printing the key of a map, allow one
8929         extra level of depth.
8930         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8931         print either the top-level value, or the children if the max-depth
8932         is exceeded.
8933         (print_children): When printing the key of a map, allow one extra
8934         level of depth.
8935         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8936         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8937         (user_print_options): Initialise max_depth field.
8938         (val_print_scalar_or_string_type_p): New function.
8939         (val_print): Check to see if the max depth has been reached.
8940         (val_print_check_max_depth): Define new function.
8941         (show_print_max_depth): New function.
8942         (_initialize_valprint): Add 'print max-depth' option.
8943         * valprint.h (struct value_print_options) <max_depth>: New field.
8944         (val_print_check_max_depth): Declare new function.
8945         * NEWS: Document new feature.
8946
8947 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8948
8949         * ada-lang.c (ada_language_defn): Initialise new field.
8950         * c-lang.c (c_is_string_type_p): New function.
8951         (c_language_defn): Initialise new field.
8952         (cplus_language_defn): Initialise new field.
8953         (asm_language_defn): Initialise new field.
8954         (minimal_language_defn): Initialise new field.
8955         * c-lang.h (c_is_string_type_p): Declare new function.
8956         * d-lang.c (d_language_defn): Initialise new field.
8957         * f-lang.c (f_is_string_type_p): New function.
8958         (f_language_defn): Initialise new field.
8959         * go-lang.c (go_is_string_type_p): New function.
8960         (go_language_defn): Initialise new field.
8961         * language.c (default_is_string_type_p): New function.
8962         (unknown_language_defn): Initialise new field.
8963         (auto_language_defn): Initialise new field.
8964         * language.h (struct language_defn) <la_is_string_type_p>: New
8965         member variable.
8966         (default_is_string_type_p): Declare new function.
8967         * m2-lang.c (m2_language_defn): Initialise new field.
8968         * objc-lang.c (objc_language_defn): Initialise new field.
8969         * opencl-lang.c (opencl_language_defn): Initialise new field.
8970         * p-lang.c (pascal_is_string_type_p): New function.
8971         (pascal_language_defn): Initialise new field.
8972         * rust-lang.c (rust_is_string_type_p): New function.
8973         (rust_language_defn): Initialise new field.
8974
8975 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8978         New field.
8979         * ada-lang.c (ada_language_defn): Initialise new field.
8980         * c-lang.c (c_language_defn): Likewise.
8981         (cplus_language_defn): Likewise.
8982         (asm_language_defn): Likewise.
8983         (minimal_language_defn): Likewise.
8984         * d-lang.c (d_language_defn): Likewise.
8985         * f-lang.c (f_language_defn): Likewise.
8986         * go-lang.c (go_language_defn): Likewise.
8987         * language.c (unknown_language_defn): Likewise.
8988         (auto_language_defn): Likewise.
8989         * m2-lang.c (m2_language_defn): Likewise.
8990         * objc-lang.c (objc_language_defn): Likewise.
8991         * opencl-lang.c (opencl_language_defn): Likewise.
8992         * p-lang.c (pascal_language_defn): Likewise.
8993         * rust-lang.c (rust_language_defn): Likewise.
8994
8995 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8996
8997         * ada-lang.c (ada_is_character_type): Change return type to bool.
8998         (ada_is_string_type): Likewise.
8999         * ada-lang.h (ada_is_character_type): Update declaration
9000         (ada_is_string_type): Likewise.
9001
9002 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9003
9004         Support style in 'frame|thread apply'
9005
9006         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9007         * record.c (record_start, record_stop): Update callers of
9008         execute_command_to_string with false.
9009         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9010         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9011         methods.
9012         (class string_file): New constructor with term_out parameter.
9013         Override methods term_out and can_emit_style_escape.  New member
9014         term_out.
9015         (class stdio_file): Override can_emit_style_escape.
9016         (class tee_file): Override term_out and can_emit_style_escape.
9017         * utils.h (can_emit_style_escape): Remove.
9018         * utils.c (can_emit_style_escape): Likewise.
9019         Update all callers of can_emit_style_escape (SOMESTREAM) to
9020         SOMESTREAM->can_emit_style_escape.
9021         * source-cache.c (source_cache::get_source_lines): Likewise.
9022         * stack.c (frame_apply_command_count): Call execute_command_to_string
9023         passing the term_out characteristic of the current gdb_stdout.
9024         * thread.c (thr_try_catch_cmd): Likewise.
9025         * top.c (execute_command_to_string): pass term_out parameter
9026         to construct the string_file for the command output.
9027         * ui-file.c (term_cli_styling): New function (most code moved
9028         from utils.c can_emit_style_escape).
9029         (string_file::string_file, string_file::can_emit_style_escape,
9030         stdio_file::can_emit_style_escape, tee_file::term_out,
9031         tee_file::can_emit_style_escape): New functions.
9032
9033 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9034
9035         * NEWS: Mention the new set|show may-call-functions.
9036         * infcall.c (may_call_functions_p): New variable.
9037         (show_may_call_functions_p): New function.
9038         (call_function_by_hand_dummy): Throws an error if not
9039         may-call-functions.
9040         (_initialize_infcall): Call add_setshow_boolean_cmd for
9041         may-call-functions.
9042
9043 2019-04-25  Keith Seitz  <keiths@redhat.com>
9044
9045         PR c++/24367
9046         * cp-support.c (inspect_type): Don't attempt substitutions
9047         of symbol with the same name.
9048
9049 2019-04-25  Tom Tromey  <tromey@adacore.com>
9050
9051         PR gdb/24475:
9052         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9053         static.
9054
9055 2019-04-25  Tom Tromey  <tromey@adacore.com>
9056
9057         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9058         rvalue reference.
9059         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9060         (gdb_xml_parser::parse): Use std::move.
9061         * python/python-internal.h (gdbpy_convert_exception): Take a const
9062         reference.
9063         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9064         std::move.
9065         * python/py-utils.c (gdbpy_convert_exception): Take a const
9066         reference.
9067         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9068         Use std::move.
9069         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9070         Use std::move.
9071         * mi/mi-main.c (mi_print_exception): Take a const reference.
9072         * main.c (handle_command_errors): Take a const reference.
9073         * linespec.c (parse_linespec): Use std::move.
9074         * infcall.c (run_inferior_call): Use std::move.
9075         (call_function_by_hand_dummy): Use std::move.
9076         * exec.c (try_open_exec_file): Use std::move.
9077         * exceptions.h (exception_print, exception_fprintf)
9078         (exception_print_same): Update.
9079         * exceptions.c (print_exception, exception_print)
9080         (exception_fprintf, exception_print_same): Change parameters to
9081         const reference.
9082         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9083         * common/new-op.c: Use std::move.
9084         * common/common-exceptions.h (struct gdb_exception): Add move
9085         constructor.
9086         (struct gdb_exception_error, struct gdb_exception_quit, struct
9087         gdb_quit_bad_alloc): Change constructor to move constructor.
9088         (throw_exception): Change parameter to rvalue reference.
9089         * common/common-exceptions.c (throw_exception): Take rvalue
9090         reference.
9091         * cli/cli-interp.c (safe_execute_command): Use std::move.
9092         * breakpoint.c (insert_bp_location, location_to_sals): Use
9093         std::move.
9094
9095 2019-04-25  Tom Tromey  <tromey@adacore.com>
9096
9097         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9098         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9099         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9100         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9101         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9102         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9103         guile/scm-value.c: Use unpack.
9104         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9105         gdbscm_gdb_exception.
9106         (gdbscm_throw_gdb_exception): Likewise.
9107         (struct gdbscm_gdb_exception): New.
9108         (unpack): New function.
9109         (gdbscm_wrap): Use unpack.
9110
9111 2019-04-25  Tom Tromey  <tromey@adacore.com>
9112
9113         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9114         (gdb_rl_callback_handler): Use std::move.
9115         * common/common-exceptions.h (struct gdb_exception): Add move
9116         assignment operator.
9117         (throw_exception_sjlj): Change "exception" to const reference.
9118         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9119         (throw_exception_sjlj): Change "exception" to const reference.
9120
9121 2019-04-25  Tom Tromey  <tromey@adacore.com>
9122
9123         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9124         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9125         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9126         Update.
9127         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9128         Update.
9129         * mi/mi-interp.c (mi_interp::exec): Update.
9130         * linespec.c (parse_linespec): Update.
9131         * infcall.c (run_inferior_call): Update.
9132         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9133         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9134         (gdbscm_lookup_global_symbol): Update.
9135         * guile/scm-param.c (gdbscm_parameter_value): Update.
9136         * guile/scm-frame.c (gdbscm_frame_read_register)
9137         (gdbscm_frame_read_var): Update.
9138         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9139         * exec.c (try_open_exec_file): Update.
9140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9141         (gdb_rl_callback_handler): Update.
9142         * common/common-exceptions.h (exception_none): Don't declare.
9143         * common/common-exceptions.c (exception_none): Don't define.
9144         (struct catcher) <exception>: Update.
9145         * cli/cli-interp.c (safe_execute_command): Update.
9146         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9147
9148 2019-04-25  Ali Tamur  <tamur@google.com>
9149
9150         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9151         (read_attribute_value): Likewise.
9152         (dwarf2_read_addr_index): Update comment.
9153         (read_str_index): Add DW_FORM_strx.
9154         (dwarf2_string_attr): Likewise.
9155         (dwarf2_const_value_attr): Likewise.
9156         (dump_die_shallow): Likewise.
9157         (dwarf2_fetch_constant_bytes): Likewise.
9158         (skip_form_bytes): Likewise.
9159         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9160
9161 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9162
9163         PR corefiles/11608
9164         PR corefiles/18187
9165         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9166         OFFSET.  Verify if current mapping contains an ELF header.
9167         (linux_find_memory_regions_full): Adjust call to
9168         dump_mapping_p.
9169
9170 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9171             Kang Li <kanglictf@gmail.com>
9172
9173         PR gdb/21600
9174
9175         * dwarf2-frame.c (read_initial_length): Be consistent about using
9176         unsigned representation of length.
9177         (decode_frame_entry_1): Likewise.  Check for wraparound of
9178         end pointer as well as buffer overflow.
9179
9180 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9181
9182         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9183         "vq".
9184
9185 2019-04-24  Tom Tromey  <tromey@adacore.com>
9186
9187         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9188
9189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9190
9191         * s12z-tdep.c (s12z_unwind_pc): Delete.
9192         (s12z_unwind_sp): Delete.
9193         (s12z_gdbarch_init): Don't register deleted functions with
9194         gdbarch.
9195
9196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9197
9198         * rl78-tdep.c (rl78_unwind_sp): Delete.
9199         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9200
9201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9202
9203         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9204         (xstormy16_unwind_pc): Delete.
9205         (xstormy16_dummy_id): Delete.
9206         (xstormy16_gdbarch_init): Don't register deleted functions with
9207         gdbarch.
9208
9209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * vax-tdep.c (vax_unwind_pc): Delete.
9212         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9213
9214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9215
9216         * v850-tdep.c (v850_unwind_sp): Delete.
9217         (v850_unwind_pc): Delete.
9218         (v850_dummy_id): Delete.
9219         (v850_gdbarch_init): Don't register deleted functions with
9220         gdbarch.
9221
9222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9223
9224         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9225         (tilegx_unwind_pc): Delete.
9226         (tilegx_unwind_dummy_id): Delete.
9227         (tilegx_gdbarch_init): Don't register deleted functions with
9228         gdbarch.
9229
9230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9231
9232         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9233         (tic6x_dummy_id): Delete.
9234         (tic6x_gdbarch_init): Don't register deleted functions with
9235         gdbarch.
9236
9237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9238
9239         * sparc-tdep.c (sparc_unwind_pc): Delete.
9240         (sparc32_gdbarch_init): Don't register deleted function with
9241         gdbarch.
9242
9243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * sh-tdep.c (sh_unwind_sp): Delete.
9246         (sh_unwind_pc): Delete.
9247         (sh_dummy_id): Delete.
9248         (sh_gdbarch_init): Don't register deleted functions with
9249         gdbarch.
9250
9251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * score-tdep.c (score_unwind_sp): Delete.
9254         (score_unwind_pc): Delete.
9255         (score_dummy_id): Delete.
9256         (score_gdbarch_init): Don't register deleted functions with
9257         gdbarch.
9258
9259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * rx-tdep.c (rx_unwind_pc): Delete.
9262         (rx_unwind_sp): Delete.
9263         (rx_dummy_id): Delete.
9264         (rx_gdbarch_init): Don't register deleted functions with
9265         gdbarch.  Update comment.
9266
9267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9270         (rs6000_dummy_id): Delete.
9271         (rs6000_gdbarch_init): Don't register deleted functions with
9272         gdbarch.
9273
9274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * or1k-tdep.c (or1k_dummy_id): Delete.
9277         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9278
9279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9280
9281         * nios2-tdep.c (nios2_dummy_id): Delete.
9282         (nios2_unwind_sp): Delete.
9283         (nios2_gdbarch_init): Don't register deleted functions with
9284         gdbarch.
9285
9286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * nds32-tdep.c (nds32_dummy_id): Delete.
9289         (nds32_unwind_pc): Delete.
9290         (nds32_unwind_sp): Delete.
9291         (nds32_gdbarch_init): Don't register deleted functions with
9292         gdbarch.
9293
9294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * msp430-tdep.c (msp430_unwind_pc): Delete.
9297         (msp430_unwind_sp): Delete.
9298         (msp430_dummy_id): Delete.
9299         (msp430_gdbarch_init): Don't register deleted functions with
9300         gdbarch.
9301
9302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9303
9304         * moxie-tdep.c (moxie_unwind_sp): Delete.
9305         (moxie_unwind_pc): Delete.
9306         (moxie_dummy_id): Delete.
9307         (moxie_gdbarch_init): Don't register deleted functions with
9308         gdbarch.
9309
9310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9311
9312         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9313         (mn10300_unwind_pc): Delete.
9314         (mn10300_unwind_sp): Delete.
9315         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9316         mn10300_unwind_sp.
9317         (mn10300_frame_unwind_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * mep-tdep.c (mep_unwind_pc): Delete.
9323         (mep_unwind_sp): Delete.
9324         (mep_dummy_id): Delete.
9325         (mep_gdbarch_init): Don't register deleted functions with
9326         gdbarch.
9327
9328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9331         (m68hc11_unwind_sp): Delete.
9332         (m68hc11_gdbarch_init): Don't register deleted functions with
9333         gdbarch.
9334
9335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * m32r-tdep.c (m32r_unwind_sp): Delete.
9338         (m32r_unwind_pc): Delete.
9339         (m32r_dummy_id): Delete.
9340         (m32r_gdbarch_init): Don't register deleted functions with
9341         gdbarch.
9342
9343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * m32c-tdep.c (m32c_unwind_pc): Delete.
9346         (m32c_unwind_sp): Delete.
9347         (m32c_dummy_id): Delete.
9348         (m32c_gdbarch_init): Don't register deleted functions with
9349         gdbarch.
9350
9351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9354         (lm32_unwind_pc): Delete.
9355         (lm32_dummy_id): Delete.
9356         (lm32_gdbarch_init): Don't register deleted functions with
9357         gdbarch.
9358
9359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9360
9361         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9362         (iq2000_unwind_pc): Delete.
9363         (iq2000_dummy_id): Delete.
9364         (iq2000_gdbarch_init): Don't register deleted functions with
9365         gdbarch.
9366
9367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9368
9369         * nds32-tdep.c (nds32_type_align): Delete.
9370         (nds32_push_dummy_call): Use type_align instead.
9371
9372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * arm-tdep.c (arm_type_align): Only handle vector override case.
9375         (arm_push_dummy_call): Use type_align.
9376         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9377
9378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9379
9380         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9381         case.
9382         (pass_on_stack): Use type_align.
9383         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9384         function.
9385
9386 2019-04-23  Tom Tromey  <tromey@adacore.com>
9387
9388         * dwarf2read.c (line_header::file_name_at): Remove unused
9389         overload.
9390
9391 2019-04-23  Tom de Vries  <tdevries@suse.de>
9392
9393         PR gdb/24438
9394         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9395         invocation.
9396
9397
9398 2019-03-27  Ali Tamur  <tamur@google.com>
9399
9400         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9401         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9402         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9403         (dwarf_expr_context::get_addr_index): Likewise
9404         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9405         (symbol_needs_eval_context::get_addr_index): Likewise
9406         (disassemble_dwarf_expression): Add DW_OP_addrx
9407         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9408         (read_cutu_die_from_dwo): Update comment
9409         (skip_one_die): Add DW_FORM_addrx
9410         (read_attribute_value): Likewise
9411         (var_decode_location): Add DW_OP_addrx
9412         (dwarf2_const_value_attr): Add DW_FORM_addrx
9413         (dump_die_shallow): Likewise
9414         (dwarf2_fetch_constant_bytes): Likewise
9415         (decode_locdesc): Add DW_OP_addrx
9416         (skip_form_bytes): Add DW_FORM_addrx
9417
9418 2019-04-22  Ali Tamur  <tamur@google.com>
9419
9420         * MAINTAINERS (Write After Approval): Add self.
9421
9422 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9423
9424         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9425         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9426         (open_symbol_file_object): Likewise.
9427         (svr4_default_sos): Add info parameter.
9428         (svr4_read_so_list): Likewise.
9429         (svr4_current_sos_direct): Adjust functions calls to pass down
9430         info.
9431         (svr4_current_sos_1): Add info parameter.
9432         (svr4_current_sos): Call get_svr4_info, pass info down to
9433         svr4_current_sos_1.
9434         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9435         get_svr4_info.
9436         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9437         get_svr4_info.
9438         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9439         to get_svr4_info.
9440         (probes_table_remove_objfile_probes): Likewise.
9441         (register_solib_event_probe): Add info parameter.
9442         (solist_update_incremental): Pass info parameter down to
9443         svr4_read_so_list.
9444         (disable_probes_interface): Add info parameter.
9445         (svr4_handle_solib_event): Pass current_program_space to
9446         get_svr4_info.  Adjust disable_probes_interface cleanup.
9447         (svr4_create_probe_breakpoints): Add info parameter, pass it
9448         down to register_solib_event_probe.
9449         (svr4_create_solib_event_breakpoints): Add info parameter,
9450         pass it down to svr4_create_probe_breakpoints.
9451         (enable_break): Pass info down to
9452         svr4_create_solib_event_breakpoints.
9453         (svr4_solib_create_inferior_hook): Pass current_program_space to
9454         get_svr4_info.
9455         (svr4_clear_solib): Likewise.
9456
9457 2019-04-22  Pedro Alves  <palves@redhat.com>
9458
9459         * solib-svr4.c (svr4_free_objfile_observer): New.
9460         (probe_and_action::objfile): New field.
9461         (probes_table_htab_remove_objfile_probes)
9462         (probes_table_remove_objfile_probes): New functions.
9463         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9464         in the new probe_and_action.  Don't store the probe in 'lookup'.
9465         (svr4_create_probe_breakpoints): Pass objfile to
9466         register_solib_event_probe.
9467         (_initialize_svr4_solib): Register a free_objfile observer.
9468
9469 2019-04-19  Tom Tromey  <tom@tromey.com>
9470
9471         * common/queue.h: Remove.
9472
9473 2019-04-19  Tom Tromey  <tom@tromey.com>
9474
9475         * event-loop.c: Don't include "common/queue.h".
9476
9477 2019-04-19  Tom Tromey  <tom@tromey.com>
9478
9479         * remote.c (remote_target): Use delete.
9480         * remote-notif.h: Include <list>, not "common/queue.h".
9481         (notif_client_p): Remove typedef.
9482         (remote_notif_state): Add constructor, destructor, initializer.
9483         <notif_queue>: Now a std::list.
9484         (remote_notif_state_xfree): Don't declare.
9485         * remote-notif.c (remote_notif_process, handle_notification)
9486         (remote_notif_state_allocate): Update.
9487         (~remote_notif_state): Rename from remote_notif_state_xfree.
9488
9489 2019-04-19  Tom Tromey  <tom@tromey.com>
9490
9491         * symfile.c (reread_symbols): Update.
9492         * objfiles.c (objfile_register_static_link)
9493         (objfile_lookup_static_link): Update
9494         (~objfile) Don't delete static_links.
9495         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9496
9497 2019-04-19  Tom Tromey  <tom@tromey.com>
9498
9499         * type-stack.h (struct type_stack) <insert>: Constify string.
9500         * type-stack.c (type_stack::insert): Constify string.
9501         * gdbtypes.h (lookup_template_type): Update.
9502         (address_space_name_to_int): Update.
9503         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9504         const.
9505         (lookup_template_type): Make name const.
9506         * c-exp.y: Update rules.
9507         (lex_one_token, classify_name, classify_inner_name)
9508         (c_print_token): Update.
9509         * p-exp.y: Update rules.
9510         (yylex): Update.
9511         * f-exp.y: Update rules.
9512         (yylex): Update.
9513         * d-exp.y: Update rules.
9514         (lex_one_token, classify_name, classify_inner_name): Update.
9515         * parse.c (write_dollar_variable, copy_name): Return std::string.
9516         * parser-defs.h (copy_name): Change return type.
9517         * m2-exp.y: Update rules.
9518         (yylex): Update.
9519         * go-exp.y (lex_one_token): Update.
9520         Update rules.
9521         (classify_unsafe_function, classify_packaged_name)
9522         (classify_name, yylex): Update.
9523
9524 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9525
9526         * configure.ac: add --enable-source-highlight switch.
9527         * configure: Regenerate.
9528         * top.c (print_gdb_version): plumb --enable-source-highlight
9529         status to "show configuration".
9530
9531 2019-04-19  Tom Tromey  <tromey@adacore.com>
9532
9533         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9534         Check ADA_TYPE_P.
9535         (empty_record, ada_template_to_fixed_record_type_1)
9536         (template_to_static_fixed_type)
9537         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9538         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9539         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9540         macros.
9541
9542 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9543
9544         PR symtab/24423:
9545         * source.c (print_source_lines_base): Advance "iter" when a
9546         control character is seen.
9547
9548 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9549
9550         * inferior.h (struct infcall_suspend_state_deleter):
9551         Catch exception in destructor to avoid crash.
9552
9553 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9554
9555         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9556         close to the add_com "shell".
9557
9558 2019-04-18  Tom Tromey  <tromey@adacore.com>
9559
9560         * process-stratum-target.h (class process_stratum_target)
9561         <stratum>: Add "final".
9562
9563 2019-04-17  Tom Tromey  <tromey@adacore.com>
9564
9565         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9566         against nullptr before use.
9567
9568 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9569
9570         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9571
9572 2019-04-17  Jim Wilson  <jimw@sifive.com>
9573             Andrew Burgess  <andrew.burgess@embecosm.com>
9574
9575         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9576         code read might fail, assume 4-byte breakpoint in that case.
9577
9578 2019-04-15  Leszek Swirski  <leszeks@google.com>
9579
9580         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9581         rather than a hand-rolled POD check when checking for forced MEMORY
9582         classification.
9583
9584 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9585
9586         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9587         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9588         function.
9589         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9590         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9591         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9592         declaration.
9593
9594 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9595
9596         * aarch64-linux-nat.c
9597         (aarch64_linux_nat_target::thread_architecture): Add override.
9598         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9599         each VQ.
9600
9601 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9602
9603         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9604
9605 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9606
9607         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9608         target types of size 96-bits, add some additional comments, and
9609         check that the builtin type we found was the correct size.
9610
9611 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9612
9613         * utils.c (prompt_for_continue): Don't restore the styling at the
9614         end, as applied_style has the wrong value.  This fixes styling in
9615         long lists of file names that are interrupted by the "Continue?"
9616         prompt.
9617
9618 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9619
9620         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9621         * c-lang.c (c_language_defn): Likewise.
9622         (cplus_language_defn): Likewise.
9623         (asm_language_defn): Likewise.
9624         (minimal_language_defn): Likewise.
9625         * d-lang.c (d_language_defn): Likewise.
9626         * f-lang.c (f_language_defn): Likewise.
9627         * go-lang.c (go_language_defn): Likewise.
9628         * language.c (unknown_language_defn): Likewise.
9629         (auto_language_defn): Likewise.
9630         * language.h (struct language_defn): Remove la_magic field.
9631         (LANG_MAGIC): Delete.
9632         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9633         * objc-lang.c (objc_language_defn): Likewise.
9634         * opencl-lang.c (opencl_language_defn): Likewise.
9635         * p-lang.c (pascal_language_defn): Likewise.
9636         * rust-lang.c (rust_language_defn): Likewise.
9637
9638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9639
9640         * riscv-tdep.c (riscv_type_align): New function.
9641         (riscv_type_alignment): Delete.
9642         (riscv_arg_location): Use 'type_align'.
9643         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9644
9645 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * gdbtypes.c (type_align): A struct with no non-static fields also
9648         has alignment of 1.
9649
9650 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9651
9652         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9653         component to 0.
9654         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9655         member.
9656         (riscv_struct_info::analyse): New implementation using new
9657         analyse_inner member function.
9658         (riscv_struct_info::field_offset): New member function.
9659         (riscv_struct_info::m_offsets): New member variable.
9660         (riscv_struct_info::analyse_inner): New private member function,
9661         takes the old implementation of riscv_struct_info::analyse but
9662         extended to track field offsets.
9663         (riscv_call_arg_struct): Update the struct folding special cases
9664         to handle cases where empty C++ structs, which are non-zero
9665         length, are found.
9666         (riscv_arg_location): Initialise the length of each location, a
9667         non-zero length now indicates the location is in use.
9668         (riscv_push_dummy_call): Allow for the first location having a
9669         non-zero offset when setting up arguments.
9670         (riscv_return_value): Likewise, but for return values.
9671
9672 2019-04-11  Tom Tromey  <tromey@adacore.com>
9673
9674         * utils.c (internal_vproblem): Make "msg" const.
9675
9676 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9677
9678         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9679         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9680         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9681         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9682
9683 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9684
9685         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9686         function.
9687         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9688         of amd64_collect_native_gregset.
9689         (amd64_linux_nat_target::store_registers): Likewise.
9690
9691 2019-04-10  Tom Tromey  <tom@tromey.com>
9692
9693         * symtab.c (lookup_global_symbol_from_objfile)
9694         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9695         * objfiles.h (class separate_debug_iterator): New.
9696         (class separate_debug_range): New.
9697         (struct objfile) <separate_debug_objfiles>: New method.
9698         (objfile_separate_debug_iterate): Don't declare.
9699         * objfiles.c (separate_debug_iterator::operator++): Rename from
9700         objfile_separate_debug_iterate.
9701         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9702         iterator.
9703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9704         iterator.
9705
9706 2019-04-10  Tom Tromey  <tom@tromey.com>
9707
9708         * symfile.c (reread_symbols): Remove old comment.
9709         * objfiles.c (free_all_objfiles): Fix a typo.
9710
9711 2019-04-10  Tom Tromey  <tom@tromey.com>
9712
9713         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9714         * minsyms.c (lookup_minimal_symbol): Use foreach.
9715         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9716         (lookup_minimal_symbol_solib_trampoline): Likewise.
9717         * symfile.c (reread_symbols): Use foreach.
9718
9719 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9720             Tom Tromey  <tromey@adacore.com>
9721
9722         PR rust/24414:
9723         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9724         (rust_lex_int_test): Change "value" to be LONGEST.
9725         (rust_lex_tests): Add test for long integer literal.
9726
9727 2019-04-09  Tom Tromey  <tromey@adacore.com>
9728
9729         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9730         to bool.
9731         (extended_remote_target::attach): Update.
9732         (remote_target::remote_notice_new_inferior): Update.
9733         (remote_target::add_current_inferior_and_thread): Update.
9734         * inferior.c (exit_inferior_1): Use "false".
9735         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9736
9737 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9738
9739         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9740         the "start" command.
9741
9742 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9743
9744         * python/py-inferior.c (infpy_thread_from_thread_handle):
9745         Adjust comments to reflect renaming of thread_from_thread_handle
9746         to thread_from_handle.  Adjust keywords.  Fix type error message.
9747         (inferior_object_methods): Add thread_from_handle.  Retain
9748         thread_from_thread_handle, but mark it as deprecated.
9749
9750 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9751
9752         * gdbthread.h (find_thread_by_handle): Revise declaration.
9753         * thread.c (find_thread_by_handle): Likewise.  Adjust
9754         implementation too.
9755         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9756         support for buffer objects as handles.
9757
9758 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9759
9760         * python/py-infthread.c (thpy_thread_handle): New function.
9761         (thread_object_methods): Register thpy_thread_handle.
9762
9763 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9764
9765         * gdbthread.h (thread_to_thread_handle): Declare.
9766         * thread.c (gdbtypes.h): Include.
9767         (thread_to_thread_handle): New function.
9768
9769         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9770         (target_thread_info_to_thread_handle): Declare.
9771         * target.c (target_thread_info_to_thread_handle): New function.
9772         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9773         * target-delegates.c: Regenerate.
9774
9775         * linux-thread-db.c (class thread_db_target): Add method
9776         thread_info_to_thread_handle.
9777         (thread_db_target::thread_info_to_thread_handle): Define.
9778         * remote.c (class remote_target): Add new method
9779         thread_info_to_thread_handle.
9780         (remote_target::thread_info_to_thread_handle): Define.
9781
9782 2019-04-08  Pedro Alves  <palves@redhat.com>
9783
9784         * common/common-exceptions.c (throw_exception): Don't create
9785         named object to throw; throw directly.
9786         (throw_it): Likewise.  Don't initialize gdb_exception::message
9787         here, with new; pass FMT and AP to the ctor instead.
9788         * common/common-exceptions.h: Include <string>.
9789         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9790         const char *, va_list)): New ctor.  Use std::make_shared.
9791         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9792         errors)): Delete.
9793         (gdb_exception_error::gdb_exception_error(enum errors, const char
9794         *, va_list)): New.
9795         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9796         Add assertion.
9797         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9798         errors)): Delete.
9799         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9800         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9801         Add assertion.
9802
9803 2019-04-08  Tom Tromey  <tom@tromey.com>
9804
9805         * valops.c (value_rtti_indirect_type): Replace throw_exception
9806         with throw.
9807         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9808         with throw.
9809         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9810         throw.
9811         * target.c (target_translate_tls_address): Replace throw_exception
9812         with throw.
9813         * stack.c (frame_apply_command_count): Replace throw_exception
9814         with throw.
9815         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9816         throw.
9817         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9818         with throw.
9819         * rs6000-tdep.c (rs6000_frame_cache)
9820         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9821         * remote.c: Replace throw_exception with throw.
9822         * record-full.c (record_full_message, record_full_wait_1)
9823         (record_full_restore): Replace throw_exception with throw.
9824         * record-btrace.c:
9825         (get_thread_current_frame_id, record_btrace_start_replaying)
9826         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9827         (cmd_record_btrace_start): Replace throw_exception with throw.
9828         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9829         throw.
9830         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9831         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9832         * linespec.c:
9833         (find_linespec_symbols): Replace throw_exception with throw.
9834         * infrun.c (displaced_step_prepare, resume): Replace
9835         throw_exception with throw.
9836         * infcmd.c (post_create_inferior): Replace throw_exception with
9837         throw.
9838         * inf-loop.c (inferior_event_handler): Replace throw_exception
9839         with throw.
9840         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9841         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9842         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9843         (get_prev_frame_always, get_frame_pc_if_available)
9844         (get_frame_address_in_block_if_available, get_frame_language):
9845         Replace throw_exception with throw.
9846         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9847         throw_exception with throw.
9848         * eval.c (fetch_subexp_value, evaluate_var_value)
9849         (evaluate_funcall, evaluate_subexp_standard): Replace
9850         throw_exception with throw.
9851         * dwarf2loc.c (call_site_find_chain)
9852         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9853         Replace throw_exception with throw.
9854         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9855         with throw.
9856         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9857         throw.
9858         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9859         * completer.c (complete_line_internal): Replace throw_exception
9860         with throw.
9861         * compile/compile-object-run.c (compile_object_run): Replace
9862         throw_exception with throw.
9863         * cli/cli-script.c (process_next_line): Replace throw_exception
9864         with throw.
9865         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9866         (btrace_enable, btrace_maint_update_pt_packets): Replace
9867         throw_exception with throw.
9868         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9869         throw_exception with throw.
9870         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9871         throw_exception with throw.
9872         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9873         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9874         * aarch64-tdep.c (aarch64_make_prologue_cache)
9875         (aarch64_make_stub_cache): Replace throw_exception with throw.
9876
9877 2019-04-08  Tom Tromey  <tom@tromey.com>
9878
9879         * common/common-exceptions.c (throw_exception): Rename from
9880         throw_exception_cxx.  Remove old copy.  Make argument const.
9881         (throw_it): Create and throw exception objects directly.
9882         * common/common-exceptions.h (throw_exception): Make argument
9883         const.
9884         (struct gdb_exception_error): Add constructor.
9885         (struct gdb_exception_quit): Add constructor.
9886
9887 2019-04-08  Tom Tromey  <tom@tromey.com>
9888
9889         * common/common-exceptions.h (exception_rethrow): Don't declare.
9890         (TRY_SJLJ): Update comment.
9891         (TRY, CATCH, END_CATCH): Remove.
9892         * common/common-exceptions.c (exception_rethrow): Remove.
9893
9894 2019-04-08  Tom Tromey  <tom@tromey.com>
9895
9896         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9897         Remove.
9898         (gdb_exception_error): Rename from
9899         gdb_exception_RETURN_MASK_ERROR.
9900         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9901         (gdb_quit_bad_alloc): Update.
9902         * aarch64-tdep.c: Update.
9903         * ada-lang.c: Update.
9904         * ada-typeprint.c: Update.
9905         * ada-valprint.c: Update.
9906         * amd64-tdep.c: Update.
9907         * arch-utils.c: Update.
9908         * break-catch-throw.c: Update.
9909         * breakpoint.c: Update.
9910         * btrace.c: Update.
9911         * c-varobj.c: Update.
9912         * cli/cli-cmds.c: Update.
9913         * cli/cli-interp.c: Update.
9914         * cli/cli-script.c: Update.
9915         * common/common-exceptions.c: Update.
9916         * common/new-op.c: Update.
9917         * common/selftest.c: Update.
9918         * compile/compile-c-symbols.c: Update.
9919         * compile/compile-cplus-symbols.c: Update.
9920         * compile/compile-object-load.c: Update.
9921         * compile/compile-object-run.c: Update.
9922         * completer.c: Update.
9923         * corelow.c: Update.
9924         * cp-abi.c: Update.
9925         * cp-support.c: Update.
9926         * cp-valprint.c: Update.
9927         * darwin-nat.c: Update.
9928         * disasm-selftests.c: Update.
9929         * dtrace-probe.c: Update.
9930         * dwarf-index-cache.c: Update.
9931         * dwarf-index-write.c: Update.
9932         * dwarf2-frame-tailcall.c: Update.
9933         * dwarf2-frame.c: Update.
9934         * dwarf2loc.c: Update.
9935         * dwarf2read.c: Update.
9936         * eval.c: Update.
9937         * event-loop.c: Update.
9938         * event-top.c: Update.
9939         * exec.c: Update.
9940         * f-valprint.c: Update.
9941         * fbsd-tdep.c: Update.
9942         * frame-unwind.c: Update.
9943         * frame.c: Update.
9944         * gdbtypes.c: Update.
9945         * gnu-v3-abi.c: Update.
9946         * guile/guile-internal.h: Update.
9947         * guile/scm-block.c: Update.
9948         * guile/scm-breakpoint.c: Update.
9949         * guile/scm-cmd.c: Update.
9950         * guile/scm-disasm.c: Update.
9951         * guile/scm-frame.c: Update.
9952         * guile/scm-lazy-string.c: Update.
9953         * guile/scm-math.c: Update.
9954         * guile/scm-param.c: Update.
9955         * guile/scm-ports.c: Update.
9956         * guile/scm-pretty-print.c: Update.
9957         * guile/scm-symbol.c: Update.
9958         * guile/scm-symtab.c: Update.
9959         * guile/scm-type.c: Update.
9960         * guile/scm-value.c: Update.
9961         * i386-linux-tdep.c: Update.
9962         * i386-tdep.c: Update.
9963         * inf-loop.c: Update.
9964         * infcall.c: Update.
9965         * infcmd.c: Update.
9966         * infrun.c: Update.
9967         * jit.c: Update.
9968         * language.c: Update.
9969         * linespec.c: Update.
9970         * linux-fork.c: Update.
9971         * linux-nat.c: Update.
9972         * linux-tdep.c: Update.
9973         * linux-thread-db.c: Update.
9974         * main.c: Update.
9975         * mi/mi-cmd-break.c: Update.
9976         * mi/mi-cmd-stack.c: Update.
9977         * mi/mi-interp.c: Update.
9978         * mi/mi-main.c: Update.
9979         * objc-lang.c: Update.
9980         * p-valprint.c: Update.
9981         * parse.c: Update.
9982         * ppc-linux-tdep.c: Update.
9983         * printcmd.c: Update.
9984         * python/py-arch.c: Update.
9985         * python/py-breakpoint.c: Update.
9986         * python/py-cmd.c: Update.
9987         * python/py-finishbreakpoint.c: Update.
9988         * python/py-frame.c: Update.
9989         * python/py-framefilter.c: Update.
9990         * python/py-gdb-readline.c: Update.
9991         * python/py-inferior.c: Update.
9992         * python/py-infthread.c: Update.
9993         * python/py-lazy-string.c: Update.
9994         * python/py-linetable.c: Update.
9995         * python/py-objfile.c: Update.
9996         * python/py-param.c: Update.
9997         * python/py-prettyprint.c: Update.
9998         * python/py-progspace.c: Update.
9999         * python/py-record-btrace.c: Update.
10000         * python/py-record.c: Update.
10001         * python/py-symbol.c: Update.
10002         * python/py-type.c: Update.
10003         * python/py-unwind.c: Update.
10004         * python/py-utils.c: Update.
10005         * python/py-value.c: Update.
10006         * python/python.c: Update.
10007         * record-btrace.c: Update.
10008         * record-full.c: Update.
10009         * remote-fileio.c: Update.
10010         * remote.c: Update.
10011         * riscv-tdep.c: Update.
10012         * rs6000-aix-tdep.c: Update.
10013         * rs6000-tdep.c: Update.
10014         * rust-exp.y: Update.
10015         * rust-lang.c: Update.
10016         * s390-tdep.c: Update.
10017         * selftest-arch.c: Update.
10018         * solib-dsbt.c: Update.
10019         * solib-frv.c: Update.
10020         * solib-spu.c: Update.
10021         * solib-svr4.c: Update.
10022         * solib.c: Update.
10023         * sparc64-linux-tdep.c: Update.
10024         * stack.c: Update.
10025         * symfile-mem.c: Update.
10026         * symmisc.c: Update.
10027         * target.c: Update.
10028         * thread.c: Update.
10029         * top.c: Update.
10030         * tracefile-tfile.c: Update.
10031         * tui/tui.c: Update.
10032         * typeprint.c: Update.
10033         * unittests/cli-utils-selftests.c: Update.
10034         * unittests/parse-connection-spec-selftests.c: Update.
10035         * valops.c: Update.
10036         * valprint.c: Update.
10037         * value.c: Update.
10038         * varobj.c: Update.
10039         * windows-nat.c: Update.
10040         * x86-linux-nat.c: Update.
10041         * xml-support.c: Update.
10042
10043 2019-04-08  Tom Tromey  <tom@tromey.com>
10044
10045         * xml-support.c: Use C++ exception handling.
10046         * x86-linux-nat.c: Use C++ exception handling.
10047         * windows-nat.c: Use C++ exception handling.
10048         * varobj.c: Use C++ exception handling.
10049         * value.c: Use C++ exception handling.
10050         * valprint.c: Use C++ exception handling.
10051         * valops.c: Use C++ exception handling.
10052         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10053         handling.
10054         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10055         * typeprint.c: Use C++ exception handling.
10056         * tui/tui.c: Use C++ exception handling.
10057         * tracefile-tfile.c: Use C++ exception handling.
10058         * top.c: Use C++ exception handling.
10059         * thread.c: Use C++ exception handling.
10060         * target.c: Use C++ exception handling.
10061         * symmisc.c: Use C++ exception handling.
10062         * symfile-mem.c: Use C++ exception handling.
10063         * stack.c: Use C++ exception handling.
10064         * sparc64-linux-tdep.c: Use C++ exception handling.
10065         * solib.c: Use C++ exception handling.
10066         * solib-svr4.c: Use C++ exception handling.
10067         * solib-spu.c: Use C++ exception handling.
10068         * solib-frv.c: Use C++ exception handling.
10069         * solib-dsbt.c: Use C++ exception handling.
10070         * selftest-arch.c: Use C++ exception handling.
10071         * s390-tdep.c: Use C++ exception handling.
10072         * rust-lang.c: Use C++ exception handling.
10073         * rust-exp.y: Use C++ exception handling.
10074         * rs6000-tdep.c: Use C++ exception handling.
10075         * rs6000-aix-tdep.c: Use C++ exception handling.
10076         * riscv-tdep.c: Use C++ exception handling.
10077         * remote.c: Use C++ exception handling.
10078         * remote-fileio.c: Use C++ exception handling.
10079         * record-full.c: Use C++ exception handling.
10080         * record-btrace.c: Use C++ exception handling.
10081         * python/python.c: Use C++ exception handling.
10082         * python/py-value.c: Use C++ exception handling.
10083         * python/py-utils.c: Use C++ exception handling.
10084         * python/py-unwind.c: Use C++ exception handling.
10085         * python/py-type.c: Use C++ exception handling.
10086         * python/py-symbol.c: Use C++ exception handling.
10087         * python/py-record.c: Use C++ exception handling.
10088         * python/py-record-btrace.c: Use C++ exception handling.
10089         * python/py-progspace.c: Use C++ exception handling.
10090         * python/py-prettyprint.c: Use C++ exception handling.
10091         * python/py-param.c: Use C++ exception handling.
10092         * python/py-objfile.c: Use C++ exception handling.
10093         * python/py-linetable.c: Use C++ exception handling.
10094         * python/py-lazy-string.c: Use C++ exception handling.
10095         * python/py-infthread.c: Use C++ exception handling.
10096         * python/py-inferior.c: Use C++ exception handling.
10097         * python/py-gdb-readline.c: Use C++ exception handling.
10098         * python/py-framefilter.c: Use C++ exception handling.
10099         * python/py-frame.c: Use C++ exception handling.
10100         * python/py-finishbreakpoint.c: Use C++ exception handling.
10101         * python/py-cmd.c: Use C++ exception handling.
10102         * python/py-breakpoint.c: Use C++ exception handling.
10103         * python/py-arch.c: Use C++ exception handling.
10104         * printcmd.c: Use C++ exception handling.
10105         * ppc-linux-tdep.c: Use C++ exception handling.
10106         * parse.c: Use C++ exception handling.
10107         * p-valprint.c: Use C++ exception handling.
10108         * objc-lang.c: Use C++ exception handling.
10109         * mi/mi-main.c: Use C++ exception handling.
10110         * mi/mi-interp.c: Use C++ exception handling.
10111         * mi/mi-cmd-stack.c: Use C++ exception handling.
10112         * mi/mi-cmd-break.c: Use C++ exception handling.
10113         * main.c: Use C++ exception handling.
10114         * linux-thread-db.c: Use C++ exception handling.
10115         * linux-tdep.c: Use C++ exception handling.
10116         * linux-nat.c: Use C++ exception handling.
10117         * linux-fork.c: Use C++ exception handling.
10118         * linespec.c: Use C++ exception handling.
10119         * language.c: Use C++ exception handling.
10120         * jit.c: Use C++ exception handling.
10121         * infrun.c: Use C++ exception handling.
10122         * infcmd.c: Use C++ exception handling.
10123         * infcall.c: Use C++ exception handling.
10124         * inf-loop.c: Use C++ exception handling.
10125         * i386-tdep.c: Use C++ exception handling.
10126         * i386-linux-tdep.c: Use C++ exception handling.
10127         * guile/scm-value.c: Use C++ exception handling.
10128         * guile/scm-type.c: Use C++ exception handling.
10129         * guile/scm-symtab.c: Use C++ exception handling.
10130         * guile/scm-symbol.c: Use C++ exception handling.
10131         * guile/scm-pretty-print.c: Use C++ exception handling.
10132         * guile/scm-ports.c: Use C++ exception handling.
10133         * guile/scm-param.c: Use C++ exception handling.
10134         * guile/scm-math.c: Use C++ exception handling.
10135         * guile/scm-lazy-string.c: Use C++ exception handling.
10136         * guile/scm-frame.c: Use C++ exception handling.
10137         * guile/scm-disasm.c: Use C++ exception handling.
10138         * guile/scm-cmd.c: Use C++ exception handling.
10139         * guile/scm-breakpoint.c: Use C++ exception handling.
10140         * guile/scm-block.c: Use C++ exception handling.
10141         * guile/guile-internal.h: Use C++ exception handling.
10142         * gnu-v3-abi.c: Use C++ exception handling.
10143         * gdbtypes.c: Use C++ exception handling.
10144         * frame.c: Use C++ exception handling.
10145         * frame-unwind.c: Use C++ exception handling.
10146         * fbsd-tdep.c: Use C++ exception handling.
10147         * f-valprint.c: Use C++ exception handling.
10148         * exec.c: Use C++ exception handling.
10149         * event-top.c: Use C++ exception handling.
10150         * event-loop.c: Use C++ exception handling.
10151         * eval.c: Use C++ exception handling.
10152         * dwarf2read.c: Use C++ exception handling.
10153         * dwarf2loc.c: Use C++ exception handling.
10154         * dwarf2-frame.c: Use C++ exception handling.
10155         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10156         * dwarf-index-write.c: Use C++ exception handling.
10157         * dwarf-index-cache.c: Use C++ exception handling.
10158         * dtrace-probe.c: Use C++ exception handling.
10159         * disasm-selftests.c: Use C++ exception handling.
10160         * darwin-nat.c: Use C++ exception handling.
10161         * cp-valprint.c: Use C++ exception handling.
10162         * cp-support.c: Use C++ exception handling.
10163         * cp-abi.c: Use C++ exception handling.
10164         * corelow.c: Use C++ exception handling.
10165         * completer.c: Use C++ exception handling.
10166         * compile/compile-object-run.c: Use C++ exception handling.
10167         * compile/compile-object-load.c: Use C++ exception handling.
10168         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10169         * compile/compile-c-symbols.c: Use C++ exception handling.
10170         * common/selftest.c: Use C++ exception handling.
10171         * common/new-op.c: Use C++ exception handling.
10172         * cli/cli-script.c: Use C++ exception handling.
10173         * cli/cli-interp.c: Use C++ exception handling.
10174         * cli/cli-cmds.c: Use C++ exception handling.
10175         * c-varobj.c: Use C++ exception handling.
10176         * btrace.c: Use C++ exception handling.
10177         * breakpoint.c: Use C++ exception handling.
10178         * break-catch-throw.c: Use C++ exception handling.
10179         * arch-utils.c: Use C++ exception handling.
10180         * amd64-tdep.c: Use C++ exception handling.
10181         * ada-valprint.c: Use C++ exception handling.
10182         * ada-typeprint.c: Use C++ exception handling.
10183         * ada-lang.c: Use C++ exception handling.
10184         * aarch64-tdep.c: Use C++ exception handling.
10185
10186 2019-04-08  Tom Tromey  <tom@tromey.com>
10187
10188         * xml-support.c (gdb_xml_parser::parse): Update.
10189         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10190         * value.c (show_convenience): Update.
10191         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10192         (test_parse_flags_qcs): Update.
10193         * thread.c (thr_try_catch_cmd): Update.
10194         * target.c (target_translate_tls_address): Update.
10195         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10196         (info_frame_command_core, frame_apply_command_count): Update.
10197         * rust-exp.y (rust_lex_exception_test): Update.
10198         * riscv-tdep.c (riscv_print_one_register_info): Update.
10199         * remote.c (remote_target::enable_btrace): Update.
10200         * record-btrace.c (record_btrace_enable_warn): Update.
10201         * python/py-utils.c (gdbpy_convert_exception): Update.
10202         * printcmd.c (do_one_display, print_variable_and_value): Update.
10203         * mi/mi-main.c (mi_print_exception): Update.
10204         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10205         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10206         * linux-nat.c (linux_nat_target::attach): Update.
10207         * linux-fork.c (class scoped_switch_fork_info): Update.
10208         * infrun.c (displaced_step_prepare): Update.
10209         * infcall.c (call_function_by_hand_dummy): Update.
10210         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10211         * gnu-v3-abi.c (print_one_vtable): Update.
10212         * frame.c (get_prev_frame_always): Update.
10213         * f-valprint.c (info_common_command_for_block): Update.
10214         * exec.c (try_open_exec_file): Update.
10215         * exceptions.c (print_exception, exception_print)
10216         (exception_fprintf, exception_print_same): Update.
10217         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10218         * dwarf-index-cache.c (index_cache::store)
10219         (index_cache::lookup_gdb_index): Update.
10220         * darwin-nat.c (maybe_cache_shell): Update.
10221         * cp-valprint.c (cp_print_value_fields): Update.
10222         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10223         (gcc_cplus_symbol_address): Update.
10224         * compile/compile-c-symbols.c (gcc_convert_symbol)
10225         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10226         * common/selftest.c: Update.
10227         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10228         a std::string.
10229         (exception_try_scope_entry, exception_try_scope_exit): Don't
10230         declare.
10231         (struct exception_try_scope): Remove.
10232         (TRY): Don't use exception_try_scope.
10233         (struct gdb_exception): Add constructor, operator=.
10234         <what>: New method.
10235         (struct gdb_exception_RETURN_MASK_ALL)
10236         (struct gdb_exception_RETURN_MASK_ERROR)
10237         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10238         (struct gdb_quit_bad_alloc): Update.
10239         * common/common-exceptions.c (exception_none): Change
10240         initializer.
10241         (struct catcher) <state, exception>: Initialize inline.
10242         <prev>: Remove member.
10243         (current_catcher): Remove.
10244         (catchers): New global.
10245         (exceptions_state_mc_init): Simplify.
10246         (catcher_pop): Remove.
10247         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10248         (try_scope_depth, exception_try_scope_entry)
10249         (exception_try_scope_exit): Remove.
10250         (throw_exception_sjlj): Update.
10251         (exception_messages, exception_messages_size): Remove.
10252         (throw_it): Simplify.
10253         (gdb_exception_sliced_copy): Remove.
10254         (throw_exception_cxx): Update.
10255         * cli/cli-script.c (script_from_file): Update.
10256         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10257         Update.
10258         * ada-valprint.c (ada_val_print): Update.
10259         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10260         (create_excep_cond_exprs): Update.
10261
10262 2019-04-08  Tom Tromey  <tom@tromey.com>
10263
10264         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10265         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10266         (TRY, CATCH, END_CATCH): Remove some definitions.
10267         * common/common-exceptions.c: Don't use GDB_XCPT.
10268         (catcher_list_size): Remove.
10269         (throw_exception, throw_it): Simplify.
10270
10271 2019-04-05  Tom Tromey  <tom@tromey.com>
10272
10273         Revert the header-sorting patch.
10274         * ft32-tdep.c: Revert.
10275         * frv-tdep.c: Revert.
10276         * frv-linux-tdep.c: Revert.
10277         * frame.c: Revert.
10278         * frame-unwind.c: Revert.
10279         * frame-base.c: Revert.
10280         * fork-child.c: Revert.
10281         * findvar.c: Revert.
10282         * findcmd.c: Revert.
10283         * filesystem.c: Revert.
10284         * filename-seen-cache.h: Revert.
10285         * filename-seen-cache.c: Revert.
10286         * fbsd-tdep.c: Revert.
10287         * fbsd-nat.h: Revert.
10288         * fbsd-nat.c: Revert.
10289         * f-valprint.c: Revert.
10290         * f-typeprint.c: Revert.
10291         * f-lang.c: Revert.
10292         * extension.h: Revert.
10293         * extension.c: Revert.
10294         * extension-priv.h: Revert.
10295         * expprint.c: Revert.
10296         * exec.h: Revert.
10297         * exec.c: Revert.
10298         * exceptions.c: Revert.
10299         * event-top.c: Revert.
10300         * event-loop.c: Revert.
10301         * eval.c: Revert.
10302         * elfread.c: Revert.
10303         * dwarf2read.h: Revert.
10304         * dwarf2read.c: Revert.
10305         * dwarf2loc.c: Revert.
10306         * dwarf2expr.h: Revert.
10307         * dwarf2expr.c: Revert.
10308         * dwarf2-frame.c: Revert.
10309         * dwarf2-frame-tailcall.c: Revert.
10310         * dwarf-index-write.h: Revert.
10311         * dwarf-index-write.c: Revert.
10312         * dwarf-index-common.c: Revert.
10313         * dwarf-index-cache.h: Revert.
10314         * dwarf-index-cache.c: Revert.
10315         * dummy-frame.c: Revert.
10316         * dtrace-probe.c: Revert.
10317         * disasm.h: Revert.
10318         * disasm.c: Revert.
10319         * disasm-selftests.c: Revert.
10320         * dictionary.c: Revert.
10321         * dicos-tdep.c: Revert.
10322         * demangle.c: Revert.
10323         * dcache.h: Revert.
10324         * dcache.c: Revert.
10325         * darwin-nat.h: Revert.
10326         * darwin-nat.c: Revert.
10327         * darwin-nat-info.c: Revert.
10328         * d-valprint.c: Revert.
10329         * d-namespace.c: Revert.
10330         * d-lang.c: Revert.
10331         * ctf.c: Revert.
10332         * csky-tdep.c: Revert.
10333         * csky-linux-tdep.c: Revert.
10334         * cris-tdep.c: Revert.
10335         * cris-linux-tdep.c: Revert.
10336         * cp-valprint.c: Revert.
10337         * cp-support.c: Revert.
10338         * cp-namespace.c: Revert.
10339         * cp-abi.c: Revert.
10340         * corelow.c: Revert.
10341         * corefile.c: Revert.
10342         * continuations.c: Revert.
10343         * completer.h: Revert.
10344         * completer.c: Revert.
10345         * complaints.c: Revert.
10346         * coffread.c: Revert.
10347         * coff-pe-read.c: Revert.
10348         * cli-out.h: Revert.
10349         * cli-out.c: Revert.
10350         * charset.c: Revert.
10351         * c-varobj.c: Revert.
10352         * c-valprint.c: Revert.
10353         * c-typeprint.c: Revert.
10354         * c-lang.c: Revert.
10355         * buildsym.c: Revert.
10356         * buildsym-legacy.c: Revert.
10357         * build-id.h: Revert.
10358         * build-id.c: Revert.
10359         * btrace.c: Revert.
10360         * bsd-uthread.c: Revert.
10361         * breakpoint.h: Revert.
10362         * breakpoint.c: Revert.
10363         * break-catch-throw.c: Revert.
10364         * break-catch-syscall.c: Revert.
10365         * break-catch-sig.c: Revert.
10366         * blockframe.c: Revert.
10367         * block.c: Revert.
10368         * bfin-tdep.c: Revert.
10369         * bfin-linux-tdep.c: Revert.
10370         * bfd-target.c: Revert.
10371         * bcache.c: Revert.
10372         * ax-general.c: Revert.
10373         * ax-gdb.h: Revert.
10374         * ax-gdb.c: Revert.
10375         * avr-tdep.c: Revert.
10376         * auxv.c: Revert.
10377         * auto-load.c: Revert.
10378         * arm-wince-tdep.c: Revert.
10379         * arm-tdep.c: Revert.
10380         * arm-symbian-tdep.c: Revert.
10381         * arm-pikeos-tdep.c: Revert.
10382         * arm-obsd-tdep.c: Revert.
10383         * arm-nbsd-tdep.c: Revert.
10384         * arm-nbsd-nat.c: Revert.
10385         * arm-linux-tdep.c: Revert.
10386         * arm-linux-nat.c: Revert.
10387         * arm-fbsd-tdep.c: Revert.
10388         * arm-fbsd-nat.c: Revert.
10389         * arm-bsd-tdep.c: Revert.
10390         * arch-utils.c: Revert.
10391         * arc-tdep.c: Revert.
10392         * arc-newlib-tdep.c: Revert.
10393         * annotate.h: Revert.
10394         * annotate.c: Revert.
10395         * amd64-windows-tdep.c: Revert.
10396         * amd64-windows-nat.c: Revert.
10397         * amd64-tdep.c: Revert.
10398         * amd64-sol2-tdep.c: Revert.
10399         * amd64-obsd-tdep.c: Revert.
10400         * amd64-obsd-nat.c: Revert.
10401         * amd64-nbsd-tdep.c: Revert.
10402         * amd64-nbsd-nat.c: Revert.
10403         * amd64-nat.c: Revert.
10404         * amd64-linux-tdep.c: Revert.
10405         * amd64-linux-nat.c: Revert.
10406         * amd64-fbsd-tdep.c: Revert.
10407         * amd64-fbsd-nat.c: Revert.
10408         * amd64-dicos-tdep.c: Revert.
10409         * amd64-darwin-tdep.c: Revert.
10410         * amd64-bsd-nat.c: Revert.
10411         * alpha-tdep.c: Revert.
10412         * alpha-obsd-tdep.c: Revert.
10413         * alpha-nbsd-tdep.c: Revert.
10414         * alpha-mdebug-tdep.c: Revert.
10415         * alpha-linux-tdep.c: Revert.
10416         * alpha-linux-nat.c: Revert.
10417         * alpha-bsd-tdep.c: Revert.
10418         * alpha-bsd-nat.c: Revert.
10419         * aix-thread.c: Revert.
10420         * agent.c: Revert.
10421         * addrmap.c: Revert.
10422         * ada-varobj.c: Revert.
10423         * ada-valprint.c: Revert.
10424         * ada-typeprint.c: Revert.
10425         * ada-tasks.c: Revert.
10426         * ada-lang.c: Revert.
10427         * aarch64-tdep.c: Revert.
10428         * aarch64-ravenscar-thread.c: Revert.
10429         * aarch64-newlib-tdep.c: Revert.
10430         * aarch64-linux-tdep.c: Revert.
10431         * aarch64-linux-nat.c: Revert.
10432         * aarch64-fbsd-tdep.c: Revert.
10433         * aarch64-fbsd-nat.c: Revert.
10434         * aarch32-linux-nat.c: Revert.
10435
10436 2019-04-05  Tom Tromey  <tom@tromey.com>
10437
10438         * ft32-tdep.c: Sort headers.
10439         * frv-tdep.c: Sort headers.
10440         * frv-linux-tdep.c: Sort headers.
10441         * frame.c: Sort headers.
10442         * frame-unwind.c: Sort headers.
10443         * frame-base.c: Sort headers.
10444         * fork-child.c: Sort headers.
10445         * findvar.c: Sort headers.
10446         * findcmd.c: Sort headers.
10447         * filesystem.c: Sort headers.
10448         * filename-seen-cache.h: Sort headers.
10449         * filename-seen-cache.c: Sort headers.
10450         * fbsd-tdep.c: Sort headers.
10451         * fbsd-nat.h: Sort headers.
10452         * fbsd-nat.c: Sort headers.
10453         * f-valprint.c: Sort headers.
10454         * f-typeprint.c: Sort headers.
10455         * f-lang.c: Sort headers.
10456         * extension.h: Sort headers.
10457         * extension.c: Sort headers.
10458         * extension-priv.h: Sort headers.
10459         * expprint.c: Sort headers.
10460         * exec.h: Sort headers.
10461         * exec.c: Sort headers.
10462         * exceptions.c: Sort headers.
10463         * event-top.c: Sort headers.
10464         * event-loop.c: Sort headers.
10465         * eval.c: Sort headers.
10466         * elfread.c: Sort headers.
10467         * dwarf2read.h: Sort headers.
10468         * dwarf2read.c: Sort headers.
10469         * dwarf2loc.c: Sort headers.
10470         * dwarf2expr.h: Sort headers.
10471         * dwarf2expr.c: Sort headers.
10472         * dwarf2-frame.c: Sort headers.
10473         * dwarf2-frame-tailcall.c: Sort headers.
10474         * dwarf-index-write.h: Sort headers.
10475         * dwarf-index-write.c: Sort headers.
10476         * dwarf-index-common.c: Sort headers.
10477         * dwarf-index-cache.h: Sort headers.
10478         * dwarf-index-cache.c: Sort headers.
10479         * dummy-frame.c: Sort headers.
10480         * dtrace-probe.c: Sort headers.
10481         * disasm.h: Sort headers.
10482         * disasm.c: Sort headers.
10483         * disasm-selftests.c: Sort headers.
10484         * dictionary.c: Sort headers.
10485         * dicos-tdep.c: Sort headers.
10486         * demangle.c: Sort headers.
10487         * dcache.h: Sort headers.
10488         * dcache.c: Sort headers.
10489         * darwin-nat.h: Sort headers.
10490         * darwin-nat.c: Sort headers.
10491         * darwin-nat-info.c: Sort headers.
10492         * d-valprint.c: Sort headers.
10493         * d-namespace.c: Sort headers.
10494         * d-lang.c: Sort headers.
10495         * ctf.c: Sort headers.
10496         * csky-tdep.c: Sort headers.
10497         * csky-linux-tdep.c: Sort headers.
10498         * cris-tdep.c: Sort headers.
10499         * cris-linux-tdep.c: Sort headers.
10500         * cp-valprint.c: Sort headers.
10501         * cp-support.c: Sort headers.
10502         * cp-namespace.c: Sort headers.
10503         * cp-abi.c: Sort headers.
10504         * corelow.c: Sort headers.
10505         * corefile.c: Sort headers.
10506         * continuations.c: Sort headers.
10507         * completer.h: Sort headers.
10508         * completer.c: Sort headers.
10509         * complaints.c: Sort headers.
10510         * coffread.c: Sort headers.
10511         * coff-pe-read.c: Sort headers.
10512         * cli-out.h: Sort headers.
10513         * cli-out.c: Sort headers.
10514         * charset.c: Sort headers.
10515         * c-varobj.c: Sort headers.
10516         * c-valprint.c: Sort headers.
10517         * c-typeprint.c: Sort headers.
10518         * c-lang.c: Sort headers.
10519         * buildsym.c: Sort headers.
10520         * buildsym-legacy.c: Sort headers.
10521         * build-id.h: Sort headers.
10522         * build-id.c: Sort headers.
10523         * btrace.c: Sort headers.
10524         * bsd-uthread.c: Sort headers.
10525         * breakpoint.h: Sort headers.
10526         * breakpoint.c: Sort headers.
10527         * break-catch-throw.c: Sort headers.
10528         * break-catch-syscall.c: Sort headers.
10529         * break-catch-sig.c: Sort headers.
10530         * blockframe.c: Sort headers.
10531         * block.c: Sort headers.
10532         * bfin-tdep.c: Sort headers.
10533         * bfin-linux-tdep.c: Sort headers.
10534         * bfd-target.c: Sort headers.
10535         * bcache.c: Sort headers.
10536         * ax-general.c: Sort headers.
10537         * ax-gdb.h: Sort headers.
10538         * ax-gdb.c: Sort headers.
10539         * avr-tdep.c: Sort headers.
10540         * auxv.c: Sort headers.
10541         * auto-load.c: Sort headers.
10542         * arm-wince-tdep.c: Sort headers.
10543         * arm-tdep.c: Sort headers.
10544         * arm-symbian-tdep.c: Sort headers.
10545         * arm-pikeos-tdep.c: Sort headers.
10546         * arm-obsd-tdep.c: Sort headers.
10547         * arm-nbsd-tdep.c: Sort headers.
10548         * arm-nbsd-nat.c: Sort headers.
10549         * arm-linux-tdep.c: Sort headers.
10550         * arm-linux-nat.c: Sort headers.
10551         * arm-fbsd-tdep.c: Sort headers.
10552         * arm-fbsd-nat.c: Sort headers.
10553         * arm-bsd-tdep.c: Sort headers.
10554         * arch-utils.c: Sort headers.
10555         * arc-tdep.c: Sort headers.
10556         * arc-newlib-tdep.c: Sort headers.
10557         * annotate.h: Sort headers.
10558         * annotate.c: Sort headers.
10559         * amd64-windows-tdep.c: Sort headers.
10560         * amd64-windows-nat.c: Sort headers.
10561         * amd64-tdep.c: Sort headers.
10562         * amd64-sol2-tdep.c: Sort headers.
10563         * amd64-obsd-tdep.c: Sort headers.
10564         * amd64-obsd-nat.c: Sort headers.
10565         * amd64-nbsd-tdep.c: Sort headers.
10566         * amd64-nbsd-nat.c: Sort headers.
10567         * amd64-nat.c: Sort headers.
10568         * amd64-linux-tdep.c: Sort headers.
10569         * amd64-linux-nat.c: Sort headers.
10570         * amd64-fbsd-tdep.c: Sort headers.
10571         * amd64-fbsd-nat.c: Sort headers.
10572         * amd64-dicos-tdep.c: Sort headers.
10573         * amd64-darwin-tdep.c: Sort headers.
10574         * amd64-bsd-nat.c: Sort headers.
10575         * alpha-tdep.c: Sort headers.
10576         * alpha-obsd-tdep.c: Sort headers.
10577         * alpha-nbsd-tdep.c: Sort headers.
10578         * alpha-mdebug-tdep.c: Sort headers.
10579         * alpha-linux-tdep.c: Sort headers.
10580         * alpha-linux-nat.c: Sort headers.
10581         * alpha-bsd-tdep.c: Sort headers.
10582         * alpha-bsd-nat.c: Sort headers.
10583         * aix-thread.c: Sort headers.
10584         * agent.c: Sort headers.
10585         * addrmap.c: Sort headers.
10586         * ada-varobj.c: Sort headers.
10587         * ada-valprint.c: Sort headers.
10588         * ada-typeprint.c: Sort headers.
10589         * ada-tasks.c: Sort headers.
10590         * ada-lang.c: Sort headers.
10591         * aarch64-tdep.c: Sort headers.
10592         * aarch64-ravenscar-thread.c: Sort headers.
10593         * aarch64-newlib-tdep.c: Sort headers.
10594         * aarch64-linux-tdep.c: Sort headers.
10595         * aarch64-linux-nat.c: Sort headers.
10596         * aarch64-fbsd-tdep.c: Sort headers.
10597         * aarch64-fbsd-nat.c: Sort headers.
10598         * aarch32-linux-nat.c: Sort headers.
10599
10600 2019-04-04  Tom Tromey  <tom@tromey.com>
10601
10602         * varobj.c (varobj_create): Update.
10603         * rust-exp.y (struct rust_parser) <update_innermost_block,
10604         lookup_symbol>: New methods.
10605         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10606         Rename.
10607         (rust_parser::rust_lookup_type)
10608         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10609         * printcmd.c (display_command, do_one_display): Update.
10610         * parser-defs.h (struct parser_state) <parser_state>: Add
10611         "tracker" parameter.
10612         (block_tracker): New member.
10613         (class innermost_block_tracker) <innermost_block_tracker>: Add
10614         "types" parameter.
10615         <reset>: Remove method.
10616         (innermost_block): Don't declare.
10617         (null_post_parser): Update.
10618         * parse.c (innermost_block): Remove global.
10619         (write_dollar_variable): Update.
10620         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10621         Remove "tracker_types" parameter.
10622         (parse_expression): Add "tracker" parameter.
10623         (parse_expression_for_completion): Update.
10624         (null_post_parser): Add "tracker" parameter.
10625         * p-exp.y: Update rules.
10626         * m2-exp.y: Update rules.
10627         * language.h (struct language_defn) <la_post_parser>: Add
10628         "tracker" parameter.
10629         * go-exp.y: Update rules.
10630         * f-exp.y: Update rules.
10631         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10632         parameter.
10633         * d-exp.y: Update rules.
10634         * c-exp.y: Update rules.
10635         * breakpoint.c (set_breakpoint_condition): Create an
10636         innermost_block_tracker.
10637         (watch_command_1): Likewise.
10638         * ada-lang.c (resolve): Add "tracker" parameter.
10639         (resolve_subexp): Likewise.
10640         * ada-exp.y (write_var_from_sym): Update.
10641
10642 2019-04-04  Tom Tromey  <tom@tromey.com>
10643
10644         * type-stack.h: New file.
10645         * type-stack.c: New file.
10646         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10647         type-stack.h.
10648         (insert_into_type_stack, insert_type, push_type, push_type_int)
10649         (insert_type_address_space, pop_type, pop_type_int)
10650         (pop_typelist, pop_type_stack, append_type_stack)
10651         (push_type_stack, get_type_stack, push_typelist)
10652         (follow_type_instance_flags, follow_types): Don't declare.
10653         * parse.c (type_stack): Remove global.
10654         (parse_exp_in_context): Update.
10655         (insert_into_type_stack, insert_type, push_type, push_type_int)
10656         (insert_type_address_space, pop_type, pop_type_int)
10657         (pop_typelist, pop_type_stack, append_type_stack)
10658         (push_type_stack, get_type_stack, push_typelist)
10659         (follow_type_instance_flags, follow_types): Remove (moved to
10660         type-stack.c).
10661         * f-exp.y (type_stack): New global.
10662         Update rules.
10663         (push_kind_type, f_parse): Update.
10664         * d-exp.y (type_stack): New global.
10665         Update rules.
10666         (d_parse): Update.
10667         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10668         Update rules.
10669         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10670         (HFILES_NO_SRCDIR): Add type-stack.h.
10671
10672 2019-04-04  Tom Tromey  <tom@tromey.com>
10673
10674         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10675         (rust_parser::convert_ast_to_expression, rust_parse)
10676         (rust_lex_test_completion, rust_lex_tests): Update.
10677         * parser-defs.h (struct expr_completion_state): New.
10678         (struct parser_state) <parser_state>: Add completion parameter.
10679         <mark_struct_expression, mark_completion_tag>: New methods.
10680         <parse_completion, m_completion_state>: New members.
10681         (prefixify_expression, null_post_parser): Update.
10682         (mark_struct_expression, mark_completion_tag): Don't declare.
10683         * parse.c (parse_completion, expout_last_struct)
10684         (expout_tag_completion_type, expout_completion_name): Remove
10685         globals.
10686         (parser_state::mark_struct_expression)
10687         (parser_state::mark_completion_tag): Now methods.
10688         (prefixify_expression): Add last_struct parameter.
10689         (prefixify_subexp): Likewise.
10690         (parse_exp_1): Update.
10691         (parse_exp_in_context): Add cstate parameter.  Update.
10692         (parse_expression_for_completion): Create an
10693         expr_completion_state.
10694         (null_post_parser): Add "completion" parameter.
10695         * p-exp.y: Update rules.
10696         (yylex): Update.
10697         * language.h (struct language_defn) <la_post_parser>: Add
10698         "completing" parameter.
10699         * go-exp.y: Update rules.
10700         (lex_one_token): Update.
10701         * expression.h (parse_completion): Don't declare.
10702         * d-exp.y: Update rules.
10703         (lex_one_token): Update rules.
10704         * c-exp.y: Update rules.
10705         (lex_one_token): Update.
10706         * ada-lang.c (resolve): Add "parse_completion" parameter.
10707         (resolve_subexp): Likewise.
10708         (ada_resolve_function): Likewise.
10709
10710 2019-04-04  Tom Tromey  <tom@tromey.com>
10711
10712         * parser-defs.h (struct parser_state) <start_arglist,
10713         end_arglist>: New methods.
10714         <arglist_len, m_funcall_chain>: New members.
10715         (arglist_len, start_arglist, end_arglist): Don't declare.
10716         * parse.c (arglist_len, funcall_chain): Remove global.
10717         (start_arglist, end_arglist): Remove functions.
10718         (parse_exp_in_context): Update.
10719         * p-exp.y: Update rules.
10720         * m2-exp.y: Update rules.
10721         * go-exp.y: Update rules.
10722         * f-exp.y: Update rules.
10723         * d-exp.y: Update rules.
10724         * c-exp.y: Update rules.
10725
10726 2019-04-04  Tom Tromey  <tom@tromey.com>
10727
10728         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10729         lex_operator, push_back>: New methods.
10730         Update all rules.
10731         (rust_parser::lex_hex, lex_escape): Rename and update.
10732         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10733         (rust_parser::lex_operator): Rename and update.
10734         (rust_parser::lex_number, rustyylex, rustyyerror)
10735         (rust_lex_test_init, rust_lex_test_sequence)
10736         (rust_lex_test_push_back, rust_lex_tests): Update.
10737         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10738         parameter.
10739         <lexptr, prev_lexptr>: New members.
10740         (lexptr, prev_lexptr): Don't declare.
10741         * parse.c (lexptr, prev_lexptr): Remove globals.
10742         (parse_exp_in_context): Update.
10743         * p-exp.y (yylex, yyerror): Update.
10744         * m2-exp.y (parse_number, yylex, yyerror): Update.
10745         * go-exp.y (lex_one_token, yyerror): Update.
10746         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10747         * d-exp.y (lex_one_token, yyerror): Update.
10748         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10749         (lex_one_token, yyerror): Update.
10750         * ada-lex.l (YY_INPUT): Update.
10751         (rewind_to_char): Update.
10752         * ada-exp.y (yyerror): Update.
10753
10754 2019-04-04  Tom Tromey  <tom@tromey.com>
10755
10756         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10757         * parser-defs.h (struct parser_state) <parser_state>: Add new
10758         parameter.
10759         <comma_terminates>: New member.
10760         (comma_terminates): Don't declare global.
10761         * parse.c (comma_terminates): Remove global.
10762         (parse_exp_in_context): Update.
10763         * p-exp.y (yylex): Update.
10764         * m2-exp.y (yylex): Update.
10765         * go-exp.y (lex_one_token): Update.
10766         * f-exp.y (yylex): Update.
10767         * d-exp.y (lex_one_token): Update.
10768         * c-exp.y (lex_one_token): Update.
10769         * ada-lex.l: Update.
10770
10771 2019-04-04  Tom Tromey  <tom@tromey.com>
10772
10773         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10774         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10775         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10776         * parser-defs.h (paren_depth): Don't declare.
10777         * parse.c (paren_depth): Remove global.
10778         (parse_exp_in_context): Update.
10779         * p-exp.y (paren_depth): New global.
10780         (pascal_parse): Initialize it.
10781         * m2-exp.y (paren_depth): New global.
10782         (m2_parse): Initialize it.
10783         * go-exp.y (paren_depth): New global.
10784         (go_parse): Initialize it.
10785         * f-exp.y (paren_depth): New global.
10786         (f_parse): Initialize it.
10787         * d-exp.y (paren_depth): New global.
10788         (d_parse): Initialize it.
10789         * c-exp.y (paren_depth): New global.
10790         (c_parse): Initialize it.
10791         * ada-lex.l (paren_depth): New global.
10792         (lexer_init): Initialize it.
10793
10794 2019-04-04  Tom Tromey  <tom@tromey.com>
10795
10796         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10797         (rust_parser::convert_ast_to_type)
10798         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10799         * parser-defs.h (struct parser_state) <parser_state>: Add
10800         parameters.  Initialize new members.
10801         <expression_context_block, expression_context_pc>: New members.
10802         * parse.c (expression_context_block, expression_context_pc):
10803         Remove globals.
10804         (parse_exp_in_context): Update.
10805         * p-exp.y: Update all rules.
10806         (yylex): Update.
10807         * m2-exp.y: Update all rules.
10808         (yylex): Update.
10809         * go-exp.y (yylex): Update.
10810         * f-exp.y (yylex): Update.
10811         * d-exp.y: Update all rules.
10812         (yylex): Update.
10813         * c-exp.y: Update all rules.
10814         (lex_one_token, classify_name, yylex, c_parse): Update.
10815         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10816
10817 2019-04-04  Tom Tromey  <tom@tromey.com>
10818
10819         * gdbarch.h, gdbarch.c: Rebuild.
10820         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10821         * stap-probe.h:
10822         (struct stap_parse_info): Replace "parser_state" with
10823         "expr_builder".
10824         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10825         (parser_state): New class.
10826         * parse.c (expr_builder): Rename.
10827         (expr_builder::release): Rename.
10828         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10829         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10830         (write_exp_elt_longcst, write_exp_elt_floatcst)
10831         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10832         (write_exp_string_vector, write_exp_bitstring)
10833         (write_exp_msymbol, mark_struct_expression)
10834         (write_dollar_variable)
10835         (insert_type_address_space, increase_expout_size): Replace
10836         "parser_state" with "expr_builder".
10837         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10838         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10839         "parser_state" with "expr_builder".
10840
10841 2019-04-04  Tom Tromey  <tom@tromey.com>
10842
10843         * rust-exp.y: Replace "parse_language" with method call.
10844         * p-exp.y:
10845         (yylex): Replace "parse_language" with method call.
10846         * m2-exp.y:
10847         (yylex): Replace "parse_language" with method call.
10848         * go-exp.y (classify_name): Replace "parse_language" with method
10849         call.
10850         * f-exp.y (yylex): Replace "parse_language" with method call.
10851         * d-exp.y (lex_one_token): Replace "parse_language" with method
10852         call.
10853         * c-exp.y:
10854         (lex_one_token, classify_name, yylex): Replace "parse_language"
10855         with method call.
10856         * ada-exp.y (find_primitive_type, type_char)
10857         (type_system_address): Replace "parse_language" with method call.
10858
10859 2019-04-04  Tom Tromey  <tom@tromey.com>
10860
10861         * rust-exp.y: Replace "parse_gdbarch" with method call.
10862         * parse.c (write_dollar_variable, insert_type_address_space):
10863         Replace "parse_gdbarch" with method call.
10864         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10865         call.
10866         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10867         call.
10868         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10869         "parse_gdbarch" with method call.
10870         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10871         with method call.
10872         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10873         "parse_gdbarch" with method call.
10874         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10875         "parse_gdbarch" with method call.
10876         * c-exp.y (parse_type, parse_number, classify_name): Replace
10877         "parse_gdbarch" with method call.
10878         * ada-lex.l: Replace "parse_gdbarch" with method call.
10879         * ada-exp.y (parse_type, find_primitive_type, type_char)
10880         (type_system_address): Replace "parse_gdbarch" with method call.
10881
10882 2019-04-04  Tom Tromey  <tom@tromey.com>
10883
10884         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10885         * stap-probe.c (stap_parse_argument): Update.
10886         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10887         initial_size parameter.
10888         * rust-exp.y (rust_lex_tests): Update.
10889         * parse.c (parser_state): Update.
10890         (parse_exp_in_context): Update.
10891         * parser-defs.h (struct parser_state) <parser_state>: Remove
10892         "initial_size" parameter.
10893
10894 2019-04-04  Tom Tromey  <tom@tromey.com>
10895
10896         * parser-defs.h (increase_expout_size): Don't declare.
10897         * parse.c (increase_expout_size): Now static.
10898
10899 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10900
10901         * gnu-nat.c (gnu_nat_target::wait): Fix
10902         target_waitstatus_to_string call.
10903
10904 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * eval.c (evaluate_subexp_standard): Handle internal functions
10907         during Fortran function call handling.
10908
10909 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10910
10911         * NEWS: Mention new internal functions.
10912         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10913         (read_base_type): Use dwarf2_init_complex_target_type.
10914         * value.c (creal_internal_fn): New function.
10915         (cimag_internal_fn): New function.
10916         (_initialize_values): Register new internal functions.
10917
10918 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10919
10920         * infrun.c (stop_all_threads): If debug_infrun, always
10921         trace the wait status after wait_one, using
10922         target_waitstatus_to_string and target_pid_to_str.
10923         (handle_inferior_event): Replace various trace of
10924         wait status kind by a single trace.
10925         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10926         wait status kind image by target_waitstatus_to_string.
10927         * target/waitstatus.c (target_waitstatus_to_string): Fix
10928         obsolete comment.
10929
10930 2019-04-01  Tom Tromey  <tromey@adacore.com>
10931
10932         PR symtab/23331:
10933         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10934
10935 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10936             Pedro Alves  <palves@redhat.com>
10937
10938         * top.c (quit_force): Call 'finalize_values'.
10939         * value.c (finalize_values): New function.
10940         * value.h (finalize_values): Declare.
10941
10942 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10943
10944         * NEWS: Announce $_gdb_major and $_gdb_minor.
10945
10946         * top.c (init_gdb_version_vars): New function.
10947         (gdb_init): Call init_gdb_version_vars.
10948
10949 2019-03-29  Tom Tromey  <tromey@adacore.com>
10950
10951         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10952         help text.  Remove dead code.
10953
10954 2019-03-29  Keith Seitz  <keiths@redhat.com>
10955
10956         From Siddhesh Poyarekar:
10957         * f-lang.h (f77_get_upperbound): Return LONGEST.
10958         (f77_get_lowerbound): Likewise.
10959         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10960         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10961         print them.
10962         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10963         plongest to format print it.
10964         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10965         (f77_get_upperbound): Likewise.
10966         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10967         LOWER_BOUND to LONGEST.
10968         (f77_create_arrayprint_offset_tbl): Likewise.
10969
10970 2019-03-29  Keith Seitz  <keiths@redhat.com>
10971
10972         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10973         %s/pulongest for TYPE_LENGTH instead of %d in format
10974         strings.
10975         * ada-typerint.c (ada_print_type): Likewise.
10976         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10977         * compile/compile-c-support.c (generate_register_struct): Likewise.
10978         * gdbtypes.c (recursive_dump_type): Likewise.
10979         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10980         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10981         instead of %d in format strings.
10982         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10983         to std::min to ULONGEST.
10984         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10985         instead of %d in format strings.
10986         * tracepoint.c (info_scope_command): Likewise.
10987         * typeprint.c (print_offset_data::update)
10988         (print_offset_data::finish): Likewise.
10989         * xtensa-tdep.c (xtensa_store_return_value)
10990         (xtensa_push_dummy_call): Likewise.
10991
10992 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10993
10994         * windows-nat.c (display_selector): Fixed format specifications
10995         for 64-bit Cygwin.
10996
10997 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10998
10999         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11000
11001 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11002
11003         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11004         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11005         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11006         (nios2_linux_init_abi): Install it.
11007
11008 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11009
11010         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11011
11012 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11013
11014         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11015
11016 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11017             Tom Tromey  <tromey@adacore.com>
11018
11019         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11020
11021 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11022
11023         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11024         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11025         method to compute the bounds of range types. Also print "[evaluated]"
11026         if the bounds' values come from a dynamic evaluation.
11027
11028 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11029
11030         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11031         whitespace when pretty printing is on.
11032
11033 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11034
11035         * ppc-linux-nat.c: Add include.
11036
11037 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11038
11039         * NEWS: Mention AArch64 Pointer Authentication.
11040
11041 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11042
11043         * arm-linux-nat.c: Add include.
11044
11045 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11046
11047         * source-cache.c (source_cache::get_source_lines): Re-read
11048         fullname after calling open_source_file.
11049
11050 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11051
11052         * NEWS: Mention TLS support for FreeBSD.
11053
11054 2019-03-25  Tom Tromey  <tromey@adacore.com>
11055
11056         * minsyms.c (BUNCH_SIZE): Update comment.
11057         (~minimal_symbol_reader): Remove old comment.
11058         (compact_minimal_symbols): Update comment.
11059         (minimal_symbol_reader::install): Remove old comment.  Update
11060         other comments.
11061
11062 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11063
11064         * s390-linux-nat.c: Add include.
11065
11066 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11067
11068         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11069         Call linux_get_hwcap.
11070         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11071         Likewise.
11072         (aarch64_linux_get_hwcap): Remove function.
11073         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11074         declaration.
11075         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11076         linux_get_hwcap.
11077         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11078         * linux-tdep.c (linux_get_hwcap): Add function.
11079         (linux_get_hwcap2): Likewise.
11080         * linux-tdep.h (linux_get_hwcap): Add declaration.
11081         (linux_get_hwcap2): Likewise.
11082         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11083         (ppc_linux_get_hwcap2): Likewise.
11084         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11085         linux_get_hwcap.
11086         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11087         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11088         (ppc_linux_nat_target::read_description): Likewise.
11089         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11090         * s390-linux-nat.c: Likewise.
11091         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11092
11093 2019-03-24  Tom Tromey  <tom@tromey.com>
11094
11095         * ada-lang.c (standard_lookup): Simplify initialization.
11096         (ada_lookup_symbol_nonlocal): Simplify return.
11097         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11098         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11099         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11100         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11101         initialization.
11102         * solib.c (solib_global_lookup): Simplify.
11103         * symtab.c (null_block_symbol): Remove.
11104         (symbol_cache_lookup): Simplify returns.
11105         (lookup_language_this): Simplify returns.
11106         (lookup_symbol_aux): Simplify return.
11107         (lookup_local_symbol): Simplify returns.
11108         (lookup_global_symbol_from_objfile): Simplify return.
11109         (lookup_symbol_in_objfile_symtabs)
11110         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11111         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11112         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11113         * cp-namespace.c (cp_lookup_bare_symbol)
11114         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11115         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11116         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11117         (cp_lookup_symbol_via_imports): Simplify initialization.
11118         (find_symbol_in_baseclass): Likewise.
11119         * symtab.h (null_block_symbol): Remove.
11120         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11121         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11122         (d_lookup_symbol_module): Likewise.
11123         (find_symbol_in_baseclass): Simplify initialization.
11124
11125 2019-03-24  Tom Tromey  <tom@tromey.com>
11126
11127         * expression.h: Don't include symtab.h.
11128         (struct block): Forward declare.
11129
11130 2019-03-24  Tom Tromey  <tom@tromey.com>
11131
11132         * c-exp.y (typebase): Remove casts.
11133         * gdbtypes.c (lookup_unsigned_typename, )
11134         (lookup_signed_typename): Remove cast.
11135         * eval.c (parse_to_comma_and_eval): Remove cast.
11136         * parse.c (write_dollar_variable): Remove cast.
11137         * block.h (struct block) <superblock>: Now const.
11138         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11139         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11140         (map_block): Make "block" const.
11141         * symfile.h (struct quick_symbol_functions)
11142         <map_matching_symbols>: Constify block argument to "callback".
11143         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11144         const.
11145         (find_pc_sect_compunit_symtab): Make "b" const.
11146         (find_symbol_at_address): Likewise.
11147         (search_symbols): Likewise.
11148         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11149         (dw2_debug_names_lookup_symbol): Likewise.
11150         (dw2_map_matching_symbols): Update.
11151         * p-valprint.c (pascal_val_print): Remove "block".
11152         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11153         (aux_add_nonlocal_symbols): Make "block" const.
11154         (resolve_subexp): Remove cast.
11155         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11156         const.
11157         (iterate_over_file_blocks): Likewise.
11158         * f-exp.y (%union) <bval>: Remove.
11159         * coffread.c (patch_opaque_types): Make "b" const.
11160         * spu-tdep.c (spu_catch_start): Make "block" const.
11161         * c-valprint.c (print_unpacked_pointer): Remove "block".
11162         * symmisc.c (dump_symtab_1): Make "b" const.
11163         (block_depth): Make "block" const.
11164         * d-exp.y (%union) <bval>: Remove.
11165         * cp-support.h (cp_lookup_rtti_type): Update.
11166         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11167         * psymtab.c (psym_lookup_symbol): Make "block" const.
11168         (maintenance_check_psymtabs): Make "b" const.
11169         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11170         (enumerate_locals, enumerate_args): Update.
11171         * python/py-symtab.c (stpy_global_block): Make "block" const.
11172         (stpy_static_block): Likewise.
11173         * inline-frame.c (block_starting_point_at): Make "new_block"
11174         const.
11175         * block.c (find_block_in_blockvector): Make return type const.
11176         (blockvector_for_pc_sect): Make "b" const.
11177         (find_block_in_blockvector): Make "b" const.
11178
11179 2019-03-23  Tom Tromey  <tom@tromey.com>
11180
11181         * varobj.c (varobj_create): Update.
11182         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11183         * printcmd.c (display_command, do_one_display): Don't reset
11184         innermost_block.
11185         * parser-defs.h (enum innermost_block_tracker_type): Move to
11186         expression.h.
11187         (innermost_block): Update comment.
11188         * parse.c (parse_exp_1): Add tracker_types parameter.
11189         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11190         tracker_types parameter.  Reset innermost_block.
11191         (parse_exp_in_context): Remove.
11192         (parse_expression_for_completion): Update.
11193         * objfiles.c (~objfile): Don't reset expression_context_block or
11194         innermost_block.
11195         * expression.h (enum innermost_block_tracker_type): Move from
11196         parser-defs.h.
11197         (parse_exp_1): Add tracker_types parameter.
11198         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11199         reset innermost_block.
11200
11201 2019-03-23  Tom Tromey  <tom@tromey.com>
11202
11203         * objfiles.h: Include bcache.h.
11204
11205 2019-03-23  Tom Tromey  <tom@tromey.com>
11206
11207         * linespec.c (get_current_search_block): Use
11208         scoped_restore_current_language.
11209         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11210
11211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11212             Jiong Wang  <jiong.wang@arm.com>
11213
11214         * aarch64-linux-tdep.c
11215         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11216         section.
11217         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11218
11219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11220             Jiong Wang  <jiong.wang@arm.com>
11221
11222         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11223         instructions.
11224         (aarch64_analyze_prologue_test): Add PACIASP test.
11225         (aarch64_prologue_prev_register): Unmask PC value.
11226
11227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11228             Jiong Wang  <jiong.wang@arm.com>
11229
11230         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11231         (aarch64_dwarf2_prev_register): Unmask PC value.
11232         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11233         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11234         DW_CFA_AARCH64_negate_ra_state.
11235         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11236
11237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11238             Jiong Wang  <jiong.wang@arm.com>
11239
11240         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11241         registers.
11242         (aarch64_pseudo_register_name): Likewise.
11243         (aarch64_pseudo_register_type): Likewise.
11244         (aarch64_pseudo_register_reggroup_p): Likewise.
11245         (aarch64_gdbarch_init): Add pauth registers.
11246         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11247         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11248         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11249         (struct gdbarch_tdep): Add regnum for ra_state.
11250
11251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11252             Jiong Wang  <jiong.wang@arm.com>
11253
11254         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11255
11256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11257             Jiong Wang  <jiong.wang@arm.com>
11258
11259         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11260         function.
11261         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11262         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11263         (aarch64_gdbarch_init): Add puth registers.
11264         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11265         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11266         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11267
11268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11269             Jiong Wang  <jiong.wang@arm.com>
11270
11271         * aarch64-linux-nat.c
11272         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11273         * aarch64-linux-tdep.c
11274         (aarch64_linux_core_read_description): Likewise.
11275         (aarch64_linux_get_hwcap): New function.
11276         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11277         (aarch64_linux_get_hwcap): New declaration.
11278
11279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11280             Jiong Wang  <jiong.wang@arm.com>
11281
11282         * aarch64-linux-nat.c
11283         (aarch64_linux_nat_target::read_description): Add pauth param.
11284         * aarch64-linux-tdep.c
11285         (aarch64_linux_core_read_description): Likewise.
11286         * aarch64-tdep.c (struct target_desc): Add in pauth.
11287         (aarch64_read_description): Add pauth param.
11288         (aarch64_gdbarch_init): Likewise.
11289         * aarch64-tdep.h (aarch64_read_description): Likewise.
11290         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11291         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11292         * features/Makefile: Add new files.
11293         * features/aarch64-pauth.c: New file.
11294         * features/aarch64-pauth.xml: New file.
11295
11296 2019-03-20  Tom Tromey  <tromey@adacore.com>
11297
11298         * infrun.c (handle_inferior_event): Rename from
11299         handle_inferior_event_1.  Create a scoped_value_mark.
11300         (handle_inferior_event): Remove.
11301
11302 2019-03-19  Tom Tromey  <tromey@adacore.com>
11303
11304         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11305         * infrun.h (print_stop_event): Add "displays" parameter.
11306         * infrun.c (print_stop_event): Add "displays" parameter.
11307
11308 2019-03-19  Pedro Alves  <palves@redhat.com>
11309
11310         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11311         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11312         to -1.  Fix TABs vs spaces.
11313         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11314         * tui/tui-out.h (tui_ui_out) Add intro comments.
11315         <m_line, m_start_of_line>: In-class initialize, and add describing
11316         comment.
11317
11318 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11319
11320         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11321         variable names.
11322         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11323
11324 2019-03-18  Pedro Alves  <palves@redhat.com>
11325             Eli Zaretskii <eliz@gnu.org>
11326
11327         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11328         m_line and m_start_of_line.
11329
11330 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11331
11332         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11333         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11334         it returns a newline.  This fixes a regression in TU mode, whereby
11335         the next line is output on the same screen line as the user input.
11336
11337 2019-03-18  Tom Tromey  <tromey@adacore.com>
11338
11339         * minsyms.c (minimal_symbol_reader::install): Remove call to
11340         obstack_blank.
11341
11342 2019-03-18  Pedro Alves  <palves@redhat.com>
11343
11344         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11345         New globals.
11346         (apply_style): New, factored out from ...
11347         (apply_ansi_escape): ... this.  Handle reverse video mode.
11348         (tui_set_reverse_mode): New function.
11349         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11350         * tui/tui-winsource.c (tui_show_source_line): Use
11351         tui_set_reverse_mode instead of setting A_STANDOUT.
11352         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11353         New setter methods.
11354
11355 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11356
11357         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11358         Handle tabs.
11359
11360 2019-03-18  Tom Tromey  <tromey@adacore.com>
11361
11362         * ada-lang.c (empty_array): Add "high" parameter.
11363         (ada_evaluate_subexp): Update.
11364
11365 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11366
11367         * unittests/string_view-selftests.c: Define
11368         _initialize_string_view_selftests unconditionally.
11369
11370 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11371
11372         PR gdb/24350
11373         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11374
11375 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11376
11377         PR gdb/24351
11378         * windows-nat.c (display_selector): Fix format specifiers.
11379
11380 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11381
11382         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11383         tui_refill_source_window instead of tui_refresh_win, to update the
11384         current execution line.  This fixes redisplay of the current line
11385         when stepping through the code with "next" or "step".
11386
11387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11388
11389         * source-cache.c (source_cache::get_source_lines): Call
11390         find_source_lines to initialize s->nlines.  This fixes vertical
11391         scrolling of TUI source window when the DOWN arrow is pressed.
11392
11393 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11394
11395         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11396         linux-thread-db.c (_initialize_thread_db): Likewise.
11397
11398 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11399
11400         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11401         wclrtoeol in tui_show_source_line".  This reverts changes made in
11402         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11403
11404 2019-03-15  Tom Tromey  <tom@tromey.com>
11405
11406         * symtab.h (struct minimal_symbol): Derive from
11407         general_symbol_info.
11408         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11409         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11410         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11411         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11412         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11413         (MSYMBOL_SEARCH_NAME): Update.
11414         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11415         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11416         * minsyms.c (minimal_symbol_reader::record_full): Update.
11417
11418 2019-03-15  Tom Tromey  <tom@tromey.com>
11419
11420         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11421
11422 2019-03-15  Tom Tromey  <tom@tromey.com>
11423
11424         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11425         unique_xmalloc_ptr.
11426         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11427         Update.
11428         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11429         (build_minimal_symbol_hash_tables)
11430         (minimal_symbol_reader::install): Update.
11431
11432 2019-03-15  Tom Tromey  <tom@tromey.com>
11433
11434         * symtab.c (create_demangled_names_hash): Update.
11435         (symbol_set_names): Update.
11436         * objfiles.h (struct objfile_per_bfd_storage)
11437         <demangled_names_hash>: Now an htab_up.
11438         * objfiles.c (objfile_per_bfd_storage): Simplify.
11439
11440 2019-03-15  Tom Tromey  <tom@tromey.com>
11441
11442         * objfiles.h (struct objfile_per_bfd_storage): Declare
11443         destructor.
11444         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11445         New.
11446         (get_objfile_bfd_data): Use new.  Don't initialize
11447         language_of_main.
11448         (free_objfile_per_bfd_storage): Remove.
11449         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11450
11451 2019-03-15  Tom Tromey  <tom@tromey.com>
11452
11453         * symfile.c (reread_symbols): Update.
11454         * objfiles.c (objfile::objfile): Update.
11455         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11456         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11457         comment.
11458         (minimal_symbol_reader::install): Update.
11459         (terminate_minimal_symbol_table): Remove.
11460         * jit.c (jit_object_close_impl): Update.
11461
11462 2019-03-15  Tom Tromey  <tom@tromey.com>
11463
11464         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11465         initializations.
11466
11467 2019-03-15  Tom Tromey  <tom@tromey.com>
11468
11469         * objfiles.h (struct objfile_per_bfd_storage)
11470         <demangled_hash_languages>: Now a bitset.
11471         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11472         (lookup_minimal_symbol): Update.
11473
11474 2019-03-15  Tom Tromey  <tom@tromey.com>
11475
11476         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11477         Don't return the symbol.
11478         * coffread.c (record_minimal_symbol): Use record_full.
11479
11480 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11481
11482         The MS-Windows port of ncurses fails to switch to a color pair if
11483         one or both of the colors are the implicit default colors.  This
11484         change records the default colors when TUI is initialized, and
11485         then specifies them explicitly when a color pair uses the default
11486         colors.  This allows color styling in TUI mode on MS-Windows.
11487
11488         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11489         ncurses_norm_attr.
11490         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11491         colors in ncurses_norm_attr.
11492         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11493         "none", replace it with the default color recorded in
11494         ncurses_norm_attr.
11495
11496 2019-03-14  Tom Tromey  <tromey@adacore.com>
11497
11498         * source-cache.h (class source_cache) <get_source_lines>: Return
11499         std::string.
11500         * source-cache.c (source_cache::extract_lines): Handle case where
11501         first_pos==npos.  Return std::string.
11502         (source_cache::get_source_lines): Update.
11503
11504 2019-03-14  Tom Tromey  <tromey@adacore.com>
11505
11506         * NEWS: Add item for "style sources" commands.
11507         * source-cache.c (source_cache::get_source_lines): Check
11508         source_styling.
11509         * cli/cli-style.c (source_styling): New global.
11510         (_initialize_cli_style): Add "style sources" commands.
11511         (show_style_sources): New function.
11512         * cli/cli-style.h (source_styling): Declare.
11513
11514 2019-03-14  Pedro Alves  <palves@redhat.com>
11515             Tom Tromey  <tromey@adacore.com>
11516
11517         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11518         * tui/tui-winsource.c (tui_refill_source_window): New function,
11519         from...
11520         (tui_horizontal_source_scroll): ... here.  Move some logic.
11521         * cli/cli-style.c (set_style_enabled): Notify new observable.
11522         * tui/tui-hooks.c (tui_redisplay_source): New function.
11523         (tui_attach_detach_observers): Attach or detach
11524         tui_redisplay_source.
11525         * observable.h (source_styling_changed): New observable.
11526         * observable.c: Define source_styling_changed observable.
11527
11528 2019-03-13  Tom Tromey  <tromey@adacore.com>
11529
11530         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11531         (i386_gnu_nat_target::store_registers): Update.
11532         * target-debug.h (target_debug_print_std_string): New macro.
11533         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11534         * windows-tdep.c (display_one_tib): Update.
11535         * tui/tui-stack.c (tui_make_status_line): Update.
11536         * top.c (print_inferior_quit_action): Update.
11537         * thread.c (thr_try_catch_cmd): Update.
11538         (add_thread_with_info): Update.
11539         (thread_target_id_str): Update.
11540         (thr_try_catch_cmd): Update.
11541         (thread_command): Update.
11542         (thread_find_command): Update.
11543         * record-btrace.c (record_btrace_target::info_record)
11544         (record_btrace_resume_thread, record_btrace_target::resume)
11545         (record_btrace_cancel_resume, record_btrace_step_thread)
11546         (record_btrace_target::wait, record_btrace_target::wait)
11547         (record_btrace_target::wait, record_btrace_target::stop): Update.
11548         * progspace.c (print_program_space): Update.
11549         * process-stratum-target.c
11550         (process_stratum_target::thread_address_space): Update.
11551         * linux-fork.c (linux_fork_mourn_inferior)
11552         (detach_checkpoint_command, info_checkpoints_command)
11553         (linux_fork_context): Update.
11554         (linux_fork_detach): Update.
11555         (class scoped_switch_fork_info): Update.
11556         (delete_checkpoint_command): Update.
11557         * infrun.c (follow_fork_inferior): Update.
11558         (follow_fork_inferior): Update.
11559         (proceed_after_vfork_done): Update.
11560         (handle_vfork_child_exec_or_exit): Update.
11561         (follow_exec): Update.
11562         (displaced_step_prepare_throw): Update.
11563         (displaced_step_restore): Update.
11564         (start_step_over): Update.
11565         (resume_1): Update.
11566         (clear_proceed_status_thread): Update.
11567         (proceed): Update.
11568         (print_target_wait_results): Update.
11569         (do_target_wait): Update.
11570         (context_switch): Update.
11571         (stop_all_threads): Update.
11572         (restart_threads): Update.
11573         (finish_step_over): Update.
11574         (handle_signal_stop): Update.
11575         (switch_back_to_stepped_thread): Update.
11576         (keep_going_pass_signal): Update.
11577         (print_exited_reason): Update.
11578         (normal_stop): Update.
11579         * inferior.c (inferior_pid_to_str): Change return type.
11580         (print_selected_inferior): Update.
11581         (add_inferior): Update.
11582         (detach_inferior): Update.
11583         * dummy-frame.c (fprint_dummy_frames): Update.
11584         * dcache.c (dcache_info_1): Update.
11585         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11586         (btrace_fetch, btrace_clear): Update.
11587         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11588         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11589         type.
11590         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11591         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11592         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11593         * gdbarch.c, gdbarch.h: Rebuild.
11594         * gdbarch.sh (core_pid_to_str): Change return type.
11595         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11596         return type.
11597         (windows_nat_target::pid_to_str): Change return type.
11598         (windows_delete_thread): Update.
11599         (windows_nat_target::attach): Update.
11600         (windows_nat_target::files_info): Update.
11601         * target-delegates.c: Rebuild.
11602         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11603         return type.
11604         (sol_thread_target::pid_to_str): Change return type.
11605         * remote.c (class remote_target) <pid_to_str>: Change return
11606         type.
11607         (remote_target::pid_to_str): Change return type.
11608         (extended_remote_target::attach, remote_target::remote_stop_ns)
11609         (remote_target::remote_notif_remove_queued_reply)
11610         (remote_target::push_stop_reply, remote_target::disable_btrace):
11611         Update.
11612         (extended_remote_target::attach): Update.
11613         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11614         type.
11615         (gdbsim_target::pid_to_str): Change return type.
11616         * ravenscar-thread.c (struct ravenscar_thread_target)
11617         <pid_to_str>: Change return type.
11618         (ravenscar_thread_target::pid_to_str): Change return type.
11619         * procfs.c (class procfs_target) <pid_to_str>: Change return
11620         type.
11621         (procfs_target::pid_to_str): Change return type.
11622         (procfs_target::attach): Update.
11623         (procfs_target::detach): Update.
11624         (procfs_target::fetch_registers): Update.
11625         (procfs_target::store_registers): Update.
11626         (procfs_target::wait): Update.
11627         (procfs_target::files_info): Update.
11628         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11629         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11630         return type.
11631         (nto_procfs_target::pid_to_str): Change return type.
11632         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11633         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11634         return type.
11635         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11636         (exit_lwp): Update.
11637         (attach_proc_task_lwp_callback, get_detach_signal)
11638         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11639         (linux_nat_target::resume, wait_lwp, stop_callback)
11640         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11641         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11642         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11643         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11644         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11645         type.
11646         (inf_ptrace_target::attach): Update.
11647         (inf_ptrace_target::files_info): Update.
11648         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11649         type.
11650         (go32_nat_target::pid_to_str): Change return type.
11651         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11652         (gnu_nat_target::wait): Update.
11653         (gnu_nat_target::wait): Update.
11654         (gnu_nat_target::resume): Update.
11655         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11656         (fbsd_nat_target::wait): Update.
11657         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11658         type.
11659         (darwin_nat_target::attach): Update.
11660         * corelow.c (class core_target) <pid_to_str>: Change return type.
11661         (core_target::pid_to_str): Change return type.
11662         * target.c (normal_pid_to_str): Change return type.
11663         (default_pid_to_str): Likewise.
11664         (target_pid_to_str): Change return type.
11665         (target_translate_tls_address): Update.
11666         (target_announce_detach): Update.
11667         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11668         return type.
11669         (bsd_uthread_target::pid_to_str): Change return type.
11670         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11671         type.
11672         (bsd_kvm_target::pid_to_str): Change return type.
11673         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11674         return type.
11675         (aix_thread_target::pid_to_str): Change return type.
11676         * target.h (struct target_ops) <pid_to_str>: Change return type.
11677         (target_pid_to_str, normal_pid_to_str): Likewise.
11678         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11679         type.
11680         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11681         type.
11682         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11683         return type.
11684         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11685         type.
11686         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11687         type.
11688         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11689         return type.
11690
11691 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11692
11693         * NEWS: Mention that the new default MI version is 3.  Mention
11694         changes to the output of commands and events that deal with
11695         multi-location breakpoints.
11696         * breakpoint.c: Include "mi/mi-out.h".
11697         (print_one_breakpoint): Change output syntax if using MI version
11698         >= 3.
11699         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11700         New.
11701         (mi_multi_location_breakpoint_output_fixed): New.
11702         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11703         (mi_cmd_fix_multi_location_breakpoint_output): New.
11704         (mi_multi_location_breakpoint_output_fixed): New.
11705         * mi/mi-cmds.c (mi_cmds): Register command
11706         -fix-multi-location-breakpoint-output.
11707         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11708         interpreter "mi".
11709
11710 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11711
11712         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11713         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11714         instantiate mi_ui_out based on interpreter name.
11715         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11716         * mi/mi-main.c (mi_load_progress): Likewise.
11717
11718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11719
11720         * NEWS: Combine separate "New targets" sections for 8.3.
11721
11722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11723
11724         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11725         (ppcfbsd_init_abi): Install gdbarch
11726         "fetch_tls_load_module_address" and "get_thread_local_address"
11727         methods.
11728
11729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11730
11731         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11732         (riscv_fbsd_init_abi): Install gdbarch
11733         "fetch_tls_load_module_address" and "get_thread_local_address"
11734         methods.
11735
11736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11737
11738         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11739         (i386fbsd_init_abi): Install gdbarch
11740         "fetch_tls_load_module_address" and "get_thread_local_address"
11741         methods.
11742
11743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11744
11745         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11746         (amd64fbsd_init_abi): Install gdbarch
11747         "fetch_tls_load_module_address" and "get_thread_local_address"
11748         methods.
11749
11750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11751
11752         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11753         (struct fbsd_pspace_data): New type.
11754         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11755         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11756         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11757         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11758         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11759
11760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11761
11762         * gdbtypes.c (lookup_struct_elt): New function.
11763         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11764         * gdbtypes.h (struct struct_elt): New type.
11765         (lookup_struct_elt): New prototype.
11766
11767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11768
11769         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11770         remove disabled code block.
11771
11772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11773
11774         * gdbarch.sh (get_thread_local_address): New method.
11775         * gdbarch.h, gdbarch.c: Regenerate.
11776         * target.c (target_translate_tls_address): Use
11777         gdbarch_get_thread_local_address if present instead of
11778         target::get_thread_local_address.
11779
11780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11781
11782         * target.h (target::get_thread_local_address): Update comment.
11783
11784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11785
11786         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11787         objfile->separate_debug_objfile_backlink if not NULL.
11788
11789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11790
11791         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11792         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11793         (amd64bsd_store_inferior_registers): Likewise.
11794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11795         Enable segment base registers.
11796         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11797         PT_GETFSBASE and PT_GETGSBASE.
11798         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11799         PT_SETGSBASE.
11800         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11801         segment base registers.
11802         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11803
11804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11805
11806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11807         Update calls to i386_target_description to add 'segments'
11808         parameter.
11809         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11810         add segment base registers.
11811         * arch/i386.c (i386_create_target_description): Add 'segments'
11812         parameter to enable segment base registers.
11813         * arch/i386.h (i386_create_target_description): Likewise.
11814         * features/i386/32bit-segments.xml: New file.
11815         * features/i386/32bit-segments.c: Generate.
11816         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11817         call to i386_target_description to add 'segments' parameter.
11818         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11819         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11820         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11821         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11822         if feature is present.
11823         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11824         Add 'segments' parameter to call to i386_target_description.
11825         (i386_target_description): Add 'segments' parameter to enable
11826         segment base registers.
11827         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11828         to call to i386_target_description.
11829         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11830         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11831         Define I386_NUM_REGS.
11832         (i386_target_description): Add 'segments' parameter to enable
11833         segment base registers.
11834
11835 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11836
11837         PR/24325
11838         * source-cache.c: #undef open and close, to avoid unresolved
11839         externals during linking.
11840
11841 2019-03-12  Tom Tromey  <tromey@adacore.com>
11842
11843         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11844         const.  Add initializers.
11845         (_initialize_remote): Don't initialize ptid globals.
11846
11847 2019-03-12  Pedro Alves  <palves@redhat.com>
11848
11849         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11850
11851 2019-03-12  Pedro Alves  <palves@redhat.com>
11852
11853         * cp-name-parser.y (main): Remove unused 'len' variable.
11854
11855 2019-03-12  Tom Tromey  <tromey@adacore.com>
11856
11857         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11858         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11859
11860 2019-03-12  Tom Tromey  <tromey@adacore.com>
11861
11862         * linux-nat.c (iterate_over_lwps): Update.
11863         (stop_callback): Remove parameter.
11864         (stop_wait_callback, detach_callback, resume_set_callback)
11865         (select_singlestep_lwp_callback, set_ignore_sigint)
11866         (status_callback, resumed_callback, resume_clear_callback)
11867         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11868         data parameter.
11869         (linux_nat_target::detach, linux_nat_target::resume)
11870         (linux_stop_and_wait_all_lwps, select_event_lwp)
11871         (linux_nat_filter_event, linux_nat_wait_1)
11872         (linux_nat_target::kill, linux_nat_target::stop)
11873         (linux_nat_target::stop): Update.
11874         (linux_nat_resume_callback): Change type.
11875         (resume_stopped_resumed_lwps, count_events_callback)
11876         (select_event_lwp_callback): Likewise.
11877         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11878         * arm-linux-nat.c (struct update_registers_data): Remove.
11879         (update_registers_callback): Change type.
11880         (arm_linux_insert_hw_breakpoint1): Update.
11881         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11882         parameter.
11883         (x86_linux_dr_set_addr): Update.
11884         (x86_linux_dr_set_control): Update.
11885         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11886         (iterate_over_lwps): Use gdb::function_view.
11887         * nat/aarch64-linux-hw-point.c (struct
11888         aarch64_dr_update_callback_param): Remove.
11889         (debug_reg_change_callback): Change type.
11890         (aarch64_notify_debug_reg_change): Update.
11891         * s390-linux-nat.c (s390_refresh_per_info): Update.
11892
11893 2019-03-11  Tom Tromey  <tromey@adacore.com>
11894
11895         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11896         redundant assignment to "this_cu".
11897
11898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11899
11900         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11901
11902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11903
11904         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11905         from...
11906         (rank_one_type): ... this.
11907
11908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11909
11910         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11911         from...
11912         (rank_one_type): ... this.
11913
11914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11915
11916         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11917         from...
11918         (rank_one_type): ... this.
11919
11920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11921
11922         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11923         from...
11924         (rank_one_type): ... this.
11925
11926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11927
11928         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11929         from...
11930         (rank_one_type): ... this.
11931
11932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11933
11934         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11935         from...
11936         (rank_one_type): ... this.
11937
11938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11939
11940         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11941         from...
11942         (rank_one_type): ... this.
11943
11944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11945
11946         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11947         from...
11948         (rank_one_type): ... this.
11949
11950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11951
11952         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11953         from...
11954         (rank_one_type): ... this.
11955
11956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11957
11958         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11959         from...
11960         (rank_one_type): ... this.
11961
11962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11963
11964         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11965         from...
11966         (rank_one_type): ... this.
11967
11968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11969
11970         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11971         from...
11972         (rank_one_type): ... this.
11973
11974 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11975
11976         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11977         inferior-events' shows the example events.
11978
11979 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11980
11981         Support styling on native MS-Windows console
11982
11983         PR/24315
11984         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11985         on MS-Windows if $TERM is not defined.
11986
11987         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11988
11989         * posix-hdep.c (gdb_console_fputs):
11990         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11991         functions.
11992         * ui-file.h (gdb_console_fputs): Add prototype.
11993
11994         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11995         back to fputs only if the former returns zero.
11996
11997 2019-03-07  Tom Tromey  <tom@tromey.com>
11998
11999         * symmisc.c (print_symbol_bcache_statistics): Update.
12000         (print_objfile_statistics): Update.
12001         * symfile.c (allocate_symtab): Update.
12002         * stabsread.c: Don't include bcache.h.
12003         * psymtab.h (struct psymbol_bcache): Don't declare.
12004         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12005         (psymbol_bcache_init, psymbol_bcache_free)
12006         (psymbol_bcache_get_bcache): Don't declare.
12007         * psymtab.c (struct psymbol_bcache): Remove.
12008         (psymtab_storage::psymtab_storage): Update.
12009         (psymtab_storage::~psymtab_storage): Update.
12010         (psymbol_bcache_init, psymbol_bcache_free)
12011         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12012         (add_psymbol_to_bcache): Update.
12013         (allocate_psymtab): Update.
12014         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12015         macro_cache>: No longer pointers.
12016         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12017         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12018         * macrotab.c (macro_bcache): Update.
12019         * macroexp.c: Don't include bcache.h.
12020         * gdbtypes.c (check_types_worklist): Update.
12021         (types_deeply_equal): Remove TRY/CATCH.  Update.
12022         * elfread.c (elf_symtab_read): Update.
12023         * dwarf2read.c: Don't include bcache.h.
12024         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12025         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12026         (print_bcache_statistics, bcache_memory_used): Don't declare.
12027         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12028         methods.  Rename all data members.
12029         * bcache.c (struct bcache): Move to bcache.h.
12030         (bcache::expand_hash_table): Rename from expand_hash_table.
12031         (bcache): Remove.
12032         (bcache::insert): Rename from bcache_full.
12033         (bcache::compare): Rename from bcache_compare.
12034         (bcache_xmalloc): Remove.
12035         (bcache::~bcache): Rename from bcache_xfree.
12036         (bcache::print_statistics): Rename from print_bcache_statistics.
12037         (bcache::memory_used): Rename from bcache_memory_used.
12038
12039 2019-03-07  Pedro Alves  <palves@redhat.com>
12040
12041         * infrun.c (normal_stop): Also check for
12042         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12043
12044 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12045
12046         * f-lang.c (value_from_host_double): Moved to...
12047         * value.c (value_from_host_double): ...here.
12048         * value.h (value_from_host_double): Declare.
12049         * guile/scm-math.c (vlscm_convert_typed_number): Use
12050         value_from_host_double.
12051         (vlscm_convert_number): Likewise.
12052         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12053         * python/py-value.c (convert_value_from_python): Likewise.
12054
12055 2019-03-06  Tom Tromey  <tom@tromey.com>
12056
12057         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12058
12059 2019-03-06  Tom Tromey  <tom@tromey.com>
12060
12061         * utils.h (free_current_contents): Don't declare.
12062         * utils.c (free_current_contents): Remove.
12063
12064 2019-03-06  Tom Tromey  <tom@tromey.com>
12065
12066         * top.c (quit_force): Update.
12067         * main.c (captured_command_loop): Update.
12068         * common/new-op.c (operator new): Update.
12069         * common/common-exceptions.c (struct catcher)
12070         <save_cleanup_chain>: Remove member.
12071         (exceptions_state_mc_init): Update.
12072         (exception_try_scope_entry): Return nullptr.
12073         (exception_try_scope_exit, exception_rethrow)
12074         (throw_exception_sjlj, throw_exception_cxx): Update.
12075         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12076         (all_cleanups, do_cleanups, discard_cleanups)
12077         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12078         (restore_cleanups, restore_final_cleanups): Don't declare.
12079         (do_final_cleanups): Remove parameter.
12080         * common/cleanups.c (cleanup_chain, make_cleanup)
12081         (make_cleanup_dtor, all_cleanups, do_cleanups)
12082         (discard_my_cleanups, discard_cleanups)
12083         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12084         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12085         (null_cleanup): Remove.
12086         (do_final_cleanups): Remove parameter.
12087
12088 2019-03-06  Tom Tromey  <tom@tromey.com>
12089
12090         * remote.c (remote_target::remote_parse_stop_reply): Use
12091         unique_xmalloc_ptr.
12092
12093 2019-03-06  Tom Tromey  <tom@tromey.com>
12094
12095         * stabsread.c (struct stabs_field_info): Rename from field_info.
12096         <list, fnlist>: Add initializers.
12097         <obstack>: New member.
12098         (read_member_functions, read_struct_fields, read_baseclasses):
12099         Allocate on obstack.  Don't use cleanups.
12100         (read_one_struct_field, read_member_functions, read_struct_fields)
12101         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12102         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12103         (read_struct_type): Update.
12104
12105 2019-03-06  Tom Tromey  <tom@tromey.com>
12106
12107         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12108         * common/filestuff.h (make_cleanup_close): Don't declare.
12109         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12110         Remove.
12111
12112 2019-03-06  Tom Tromey  <tom@tromey.com>
12113
12114         * solib-aix.c: Use make_scope_exit.
12115
12116 2019-03-06  Tom Tromey  <tom@tromey.com>
12117
12118         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12119         Use make_scope_exit.
12120
12121 2019-03-06  Tom Tromey  <tom@tromey.com>
12122
12123         * solib-svr4.c (disable_probes_interface): Remove parameter.
12124         (svr4_handle_solib_event): Use make_scope_exit.
12125
12126 2019-03-06  Tom Tromey  <tom@tromey.com>
12127
12128         * remote.c (struct stop_reply_deleter): Remove.
12129         (stop_reply_up): Update.
12130         (struct stop_reply): Derive from notif_event.  Don't typedef.
12131         <regcache>: Now a std::vector.
12132         (stop_reply_xfree): Remove.
12133         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12134         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12135         (remote_target::discard_pending_stop_replies): Use delete.
12136         (remote_target::remote_parse_stop_reply): Update.
12137         (remote_target::process_stop_reply): Update.
12138         * remote-notif.h (struct notif_event): Add virtual destructor.
12139         Remove "dtr" member.
12140         (struct notif_client) <alloc_event>: Return a unique_ptr.
12141         (notif_event_xfree): Don't declare.
12142         (notif_event_up): New typedef.
12143         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12144         (notif_event_xfree, do_notif_event_xfree): Remove.
12145         (remote_notif_state_xfree): Update.
12146
12147 2019-03-06  Tom Tromey  <tom@tromey.com>
12148
12149         * infrun.c (displaced_step_clear_cleanup): Now a
12150         forward_scope_exit type.
12151         (displaced_step_prepare_throw): Update.
12152         (displaced_step_fixup): Update.
12153
12154 2019-03-06  Tom Tromey  <tom@tromey.com>
12155
12156         * inferior.h (class inferior): Update comment.
12157         * gdbthread.h (class thread_info): Update comment.
12158
12159 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12160             Tom Tromey  <tom@tromey.com>
12161
12162         * stabsread.h (struct stab_section_list): Remove.
12163         (coffstab_build_psymtabs): Update.
12164         * dbxread.c (symbuf_sections): Now a std::vector.
12165         (sect_idx): New global.
12166         (fill_symbuf): Update.
12167         (coffstab_build_psymtabs): Change type of stabsects parameter.
12168         Update.
12169         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12170         std::vector.
12171         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12172         (coff_locate_sections): Update.
12173         (coff_symfile_read): Remove cleanups.  Update.
12174         (init_stringtab): Add storage parameter.
12175         (free_stringtab, free_stringtab_cleanup): Remove.
12176         (init_lineno): Add storage parameter.
12177         (free_linetab, free_linetab_cleanup): Remove.
12178
12179 2019-03-06  Pedro Alves  <palves@redhat.com>
12180
12181         * linux-fork.c (fork_info::clobber_regs): Delete.
12182         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12183         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12184         comment.  Adjust.
12185         (scoped_switch_fork_info::scoped_switch_fork_info)
12186         (checkpoint_command, linux_fork_context): Adjust
12187         fork_save_infrun_state calls.
12188
12189 2019-03-06  Pedro Alves  <palves@redhat.com>
12190
12191         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12192         (inf_has_multiple_threads): Return 'bool' and rewrite using
12193         inferior_info::threads().
12194
12195 2019-03-06  Pedro Alves  <palves@redhat.com>
12196
12197         * linux-fork.c: Include <list>.
12198         (fork_list): Now a std::list instance.
12199         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12200         (forks_exist_p, find_last_fork): Adjust.
12201         (new_fork): Delete.
12202         (one_fork_p): New.
12203         (add_fork): Adjust.
12204         (free_fork): Delete, folded into fork_info::~fork_info().
12205         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12206         Adjust.
12207         (init_fork_list): Delete.
12208         (linux_fork_killall, linux_fork_mourn_inferior)
12209         (linux_fork_detach, info_checkpoints_command): Adjust.
12210         (_initialize_linux_fork): No longer call init_fork_list.
12211
12212 2019-03-06  Pedro Alves  <palves@redhat.com>
12213
12214         * linux-fork.c (new_fork): New, split out of ...
12215         (add_fork): ... this.  Return void.  Move "first fork" special
12216         case from here, to ...
12217         (checkpoint_command): ... here.
12218         * linux-linux.h (add_fork): Return void.
12219
12220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12221
12222         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12223
12224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12225             Chris January  <chris.january@arm.com>
12226             David Lecomber  <david.lecomber@arm.com>
12227
12228         * f-exp.y: New token, UNOP_INTRINSIC.
12229         (exp): New pattern using UNOP_INTRINSIC token.
12230         (f77_keywords): Add 'abs' keyword.
12231         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12232         (value_from_host_double): New function.
12233         (evaluate_subexp_f): Support UNOP_ABS.
12234
12235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12236
12237         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12238         types.
12239
12240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12241
12242         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12243         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12244         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12245
12246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12247
12248         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12249
12250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12251             Chris January  <chris.january@arm.com>
12252
12253         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12254         * f-exp.y: Define 'KIND' token.
12255         (exp): New pattern for KIND expressions.
12256         (ptype): Handle types with a kind extension.
12257         (direct_abs_decl): Extend to spot kind extensions.
12258         (f77_keywords): Add 'kind' to the list.
12259         (push_kind_type): New function.
12260         (convert_to_kind_type): New function.
12261         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12262         * parse.c (operator_length_standard): Likewise.
12263         * parser-defs.h (enum type_pieces): Add tp_kind.
12264         * std-operator.def: Add UNOP_KIND.
12265
12266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12267
12268         * f-exp.y (f_parse): Set yydebug.
12269
12270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * f-lang.c (evaluate_subexp_f): New function.
12273         (exp_descriptor_f): New global.
12274         (f_language_defn): Use exp_descriptor_f instead of
12275         exp_descriptor_standard.
12276
12277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12278
12279         * f-exp.y (struct token): Add comments.
12280         (dot_ops): Remove uppercase versions and the end marker.
12281         (f77_keywords): Likewise.
12282         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12283         entries in the dot_ops array are case insensitive, and use
12284         strncasecmp to compare strings.  Also some whitespace cleanup in
12285         this area.  Similar for the f77_keywords array, except entries in
12286         this list might be case sensitive.
12287
12288 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12289
12290         * f-exp.y (struct f77_boolean_val): Add comments.
12291         (boolean_values): Remove uppercase versions, and end marker.
12292         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12293         and use strncasecmp to achieve case insensitivity.  Additionally,
12294         perform whitespace cleanup around this code.
12295
12296 2019-03-06  Tom Tromey  <tromey@adacore.com>
12297
12298         * remote-sim.c (gdbsim_target_open): Use result of
12299         gdb_argv::release.
12300
12301 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12302         Dirk Schubert  <dirk.schubert@arm.com>
12303         Chris January  <chris.january@arm.com>
12304
12305         * eval.c (evaluate_subexp_standard): Call Fortran argument
12306         wrapping logic.
12307         * f-lang.c (struct value): A value which can be passed into a
12308         Fortran function call.
12309         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12310         where appropriate.
12311         (struct type): Value ready for a Fortran function call.
12312         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12313         is needed.
12314         * f-lang.h (fortran_argument_convert): Declaration.
12315         (fortran_preserve_arg_pointer): Declaration.
12316         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12317
12318 2019-03-05  Tom Tromey  <tromey@adacore.com>
12319
12320         * python/py-prettyprint.c (print_string_repr): Remove #if.
12321         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12322
12323 2019-03-05  Tom Tromey  <tromey@adacore.com>
12324
12325         * target.c (the_dummy_target): Move later.  Change type to
12326         "dummy_target".
12327         (initialize_targets): Don't initialize the_dummy_target.
12328
12329 2019-03-05  Tom Tromey  <tromey@adacore.com>
12330
12331         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12332         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12333
12334 2019-03-05  Tom Tromey  <tromey@adacore.com>
12335
12336         * windows-nat.c (windows_nat_target::attach)
12337         (windows_nat_target::detach): Don't call gdb_flush.
12338         * valprint.c (generic_val_print, val_print, val_print_string):
12339         Don't call gdb_flush.
12340         * utils.c (defaulted_query): Don't call gdb_flush.
12341         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12342         * target.c (target_announce_detach): Don't call gdb_flush.
12343         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12344         * remote.c (extended_remote_target::attach): Don't call
12345         gdb_flush.
12346         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12347         * printcmd.c (do_examine): Don't call gdb_flush.
12348         (info_display_command): Don't call gdb_flush.
12349         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12350         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12351         * memattr.c (info_mem_command): Don't call gdb_flush.
12352         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12353         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12354         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12355         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12356         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12357         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12358         (gnu_nat_target::detach): Don't call gdb_flush.
12359         * f-valprint.c (f_val_print): Don't call gdb_flush.
12360         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12361         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12362         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12363         gdb_flush.
12364         * c-valprint.c (c_val_print): Don't call gdb_flush.
12365         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12366
12367 2019-03-05  Tom Tromey  <tromey@adacore.com>
12368
12369         * varobj.c (update_dynamic_varobj_children): Update.
12370         (install_default_visualizer): Use reset, not release.
12371         * value.c (set_internalvar): Update.
12372         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12373         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12374         ATTRIBUTE_UNUSED_RESULT.
12375
12376 2019-03-05  Tom Tromey  <tromey@adacore.com>
12377
12378         * remote.c (class scoped_remote_fd) <release>: Add
12379         ATTRIBUTE_UNUSED_RESULT.
12380
12381 2019-03-05  Tom Tromey  <tromey@adacore.com>
12382
12383         * macroexp.c (struct macro_buffer) <release>: Add
12384         ATTRIBUTE_UNUSED_RESULT.
12385
12386 2019-03-05  Tom Tromey  <tromey@adacore.com>
12387
12388         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12389         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12390         ATTRIBUTE_UNUSED_RESULT.
12391
12392 2019-03-05  Tom Tromey  <tromey@adacore.com>
12393
12394         * common/scoped_fd.h (class scoped_fd) <release>: Add
12395         ATTRIBUTE_UNUSED_RESULT.
12396
12397 2019-03-05  Tom Tromey  <tromey@adacore.com>
12398
12399         * parser-defs.h (struct parser_state) <release>: Add
12400         ATTRIBUTE_UNUSED_RESULT.
12401
12402 2019-03-05  Tom Tromey  <tromey@adacore.com>
12403
12404         * utils.h (class gdb_argv) <release>: Add
12405         ATTRIBUTE_UNUSED_RESULT.
12406         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12407
12408 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12409
12410         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12411         for-loop range, to avoid compiler warnings.
12412
12413         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12414         avoid compiler warnings about unused variables.
12415
12416         * NEWS: Mention end of support for native debugging on MS-Windows
12417         before XP.
12418
12419         PR gdb/24292
12420         * common/netstuff.c:
12421         * gdbserver/gdbreplay.c
12422         * gdbserver/remote-utils.c:
12423         * ser-tcp.c:
12424         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12425         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12426         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12427         'getaddrinfo' and 'freeaddrinfo' were not available before
12428         Windows XP, and mingw.org's MinGW headers by default define
12429         _WIN32_WINNT to 0x500.
12430
12431 2019-03-01  Gary Benson <gbenson@redhat.com>
12432
12433         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12434
12435 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12436             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12437
12438         PR gdb/8527
12439         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12440         set_sigint_trap, clear_sigint_trap.
12441
12442 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12443
12444         * target.c (target_detach): Clear the regcache and the
12445         frame cache.
12446
12447 2019-02-27  Pedro Alves  <palves@redhat.com>
12448
12449         * utils.c (set_screen_size): When we cap the height/width sizes,
12450         tweak the corresponding command variable to show "unlimited":
12451
12452 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12453             Pedro Alves  <palves@redhat.com>
12454
12455         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12456         before calling rl_set_screen_size.
12457
12458 2019-02-27  Tom Tromey  <tromey@adacore.com>
12459
12460         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12461         define.
12462         * python/py-value.c: Remove Python 2.4 workaround.
12463         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12464         workaround.
12465         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12466         Python 2.4 workaround.
12467         * python/python-internal.h: Remove Python 2.4 comment.
12468         (Py_ssize_t): Don't define.
12469         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12470         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12471         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12472         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12473         * python/python.c (do_start_initialization): Remove Python 2.4
12474         workaround.
12475         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12476         (print_children): Remove Python 2.4 workaround.
12477         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12478         workaround.
12479         (CHARBUFFERPROC_NAME): Remove.
12480         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12481         Python 2.4 workaround.
12482
12483 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12484
12485         * NEWS: Note minimum Python version.
12486
12487 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12488
12489         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12490         code from these functions.  Remove corresponding ifdefs.  Use
12491         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12492         Remove gotos and target of gotos.
12493         (infpy_search_memory): Likewise.
12494
12495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12496
12497         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12498         (hppa_gdbarch_init): Don't register deleted functions with
12499         gdbarch.
12500
12501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12502
12503         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12504         (h8300_unwind_sp): Delete.
12505         (h8300_dummy_id): Delete.
12506         (h8300_gdbarch_init): Don't register deleted functions with
12507         gdbarch.
12508
12509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12510
12511         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12512         (ft32_unwind_pc): Delete.
12513         (ft32_unwind_sp): Delete.
12514         (ft32_gdbarch_init): Don't register deleted functions with
12515         gdbarch.
12516
12517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12518
12519         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12520         (frv_unwind_pc): Delete.
12521         (frv_unwind_sp): Delete.
12522         (frv_gdbarch_init): Don't register deleted functions with
12523         gdbarch.
12524
12525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12526
12527         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12528         (riscv_unwind_pc): Delete.
12529         (riscv_unwind_sp): Delete.
12530         (riscv_gdbarch_init): Don't register deleted functions with
12531         gdbarch.
12532
12533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12534
12535         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12536         (csky_unwind_pc): Delete.
12537         (csky_unwind_sp): Delete.
12538         (csky_gdbarch_init): Don't register deleted functions with
12539         gdbarch.
12540
12541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12542
12543         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12544         (cris_unwind_pc): Delete.
12545         (cris_unwind_sp): Delete.
12546         (cris_gdbarch_init): Don't register deleted functions with
12547         gdbarch.
12548
12549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12550
12551         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12552         (bfin_unwind_pc): Delete.
12553         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12554
12555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12556
12557         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12558         (arm_unwind_pc): Delete.
12559         (arm_unwind_sp): Delete.
12560         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12561
12562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12563
12564         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12565         (arc_unwind_pc): Delete.
12566         (arc_unwind_sp): Delete.
12567         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12568
12569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12570
12571         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12572         (alpha_unwind_pc): Delete.
12573         (alpha_gdbarch_init): Don't register deleted functions with
12574         gdbarch.
12575
12576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12577
12578         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12579         (aarch64_unwind_pc): Delete.
12580         (aarch64_unwind_sp): Delete.
12581         (aarch64_gdbarch_init): Don't register deleted functions with
12582         gdbarch.
12583
12584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12585
12586         * gdbtypes.c (type_align): Don't consider static members when
12587         computing structure alignment.
12588
12589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12590
12591         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12592         return 0 for other types.
12593         * arch-utils.c (default_type_align): Always return 0.
12594         * gdbarch.h: Regenerate.
12595         * gdbarch.sh (type_align): Extend comment.
12596         * gdbtypes.c (type_align): Add additional comments, always call
12597         gdbarch_type_align before applying the default rules.
12598         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12599         generic code will then apply a suitable default.
12600         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12601         types, return 0 for other types.
12602
12603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12604
12605         * NEWS: Create a new section for the next release branch.
12606         Rename the section of the current branch, now that it has
12607         been cut.
12608
12609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12610
12611         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12612         * version.in: Bump version to 8.3.50.DATE-git.
12613
12614 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12615
12616         * aix-thread.c (ptid_cmp): Remove unused variable.
12617         (get_signaled_thread): Likewise.
12618         (store_regs_user_thread): Likewise.
12619         (store_regs_kernel_thread): Likewise.
12620         (fetch_regs_kernel_thread): Remove shadowed variable.
12621
12622 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12623
12624         * features/riscv/32bit-cpu.xml: Add register numbers.
12625         * features/riscv/32bit-fpu.c: Regenerate.
12626         * features/riscv/32bit-fpu.xml: Add register numbers.
12627         * features/riscv/64bit-cpu.xml: Add register numbers.
12628         * features/riscv/64bit-fpu.c: Regenerate.
12629         * features/riscv/64bit-fpu.xml: Add register numbers.
12630
12631 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12632
12633         * NEWS: Mention two argument form of gdb.Value constructor.
12634         * python/py-value.c (convert_buffer_and_type_to_value): New
12635         function.
12636         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12637         Add support for handling an optional second argument.  Call
12638         convert_buffer_and_type_to_value as appropriate.
12639         * python/python-internal.h (Py_buffer_deleter): New struct.
12640         (Py_buffer_up): New typedef.
12641
12642 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12643
12644         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12645         instead of releasing ownership.
12646
12647 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12648
12649         * dwarf2read.c (open_and_init_dwp_file): Call
12650         elf_numsections instead of bfd_count_sections to initialize
12651         dwp_file->num_sections.
12652
12653 2019-02-25  Tom Tromey  <tromey@adacore.com>
12654
12655         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12656
12657 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12658
12659         * gcore.in: Add '--readnever' option when invoking GDB.
12660
12661 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12662
12663         * MAINTAINERS: Update my email address.
12664
12665 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12666
12667         * build-id.c (build_id_to_debug_bfd_1): New function.
12668         (build_id_to_debug_bfd): Look for separate debug file in
12669         sysroot.
12670
12671 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12672
12673         * gdbarch.sh: Update the copyright year range that is placed into
12674         generated files.
12675
12676 2019-02-22  Keith Seitz  <keiths@redhat.com>
12677
12678         PR symtab/23853
12679         * linespec.c (create_sals_line_offset): Search for the default
12680         symtab's filename instead of its fullname.
12681
12682 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12683
12684         * NEWS: Update style defaults.
12685
12686 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12687
12688         * main.c (captured_main_1): Disable styling in batch mode.
12689
12690 2019-02-20  Tom Tromey  <tom@tromey.com>
12691
12692         * symtab.c (symtab_symbol_info): Fix typos.
12693
12694 2019-02-20  Tom Tromey  <tromey@adacore.com>
12695
12696         * findcmd.c (_initialize_mem_search): Use upper case for
12697         metasyntactic variables.
12698
12699 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12700
12701         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12702         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12703
12704 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12705
12706         * top.h (source_file_name): Change to std::string.
12707         * top.c (source_file_name): Likewise.
12708         (command_line_input): Adjust.
12709         * cli/cli-script.c (script_from_file): Adjust.
12710
12711 2019-02-19  Tom Tromey  <tromey@adacore.com>
12712
12713         * ravenscar-thread.c
12714         (ravenscar_thread_target::update_thread_list): Don't call
12715         ada_build_task_list.
12716         * ada-lang.h (ada_build_task_list): Don't declare.
12717         * ada-tasks.c (struct ada_tasks_inferior_data)
12718         <task_list_valid_p>: Now bool.
12719         (read_known_tasks, ada_task_list_changed)
12720         (ada_tasks_invalidate_inferior_data): Update.
12721         (read_known_tasks_array): Return bool.
12722         (read_known_tasks_list): Likewise.
12723         (read_known_tasks): Return void.
12724         (ada_build_task_list): Now static.
12725
12726 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12727
12728         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12729         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12730
12731 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12732
12733         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12734         variant for ada_tasks_pspace_data_handle and
12735         ada_tasks_inferior_data_handle.
12736         (ada_tasks_pspace_data_cleanup): New function.
12737         (ada_tasks_inferior_data_cleanup): New function.
12738
12739 2019-02-17  Tom Tromey  <tom@tromey.com>
12740
12741         * macrotab.h (macro_source_fullname): Return a std::string.
12742         * macrotab.c (macro_include, check_for_redefinition)
12743         (macro_undef, macro_lookup_definition, foreach_macro)
12744         (foreach_macro_in_scope): Update.
12745         (macro_source_fullname): Return a std::string.
12746         * macrocmd.c (show_pp_source_pos): Update.
12747
12748 2019-02-17  Tom Tromey  <tom@tromey.com>
12749
12750         * macrocmd.c (show_pp_source_pos): Style the file names.
12751
12752 2019-02-17  Tom Tromey  <tom@tromey.com>
12753
12754         PR tui/24197:
12755         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12756
12757 2019-02-17  Tom Tromey  <tom@tromey.com>
12758
12759         * ada-lang.c (user_select_syms): Use filtered printing.
12760         * utils.c (wrap_style): New global.
12761         (desired_style): Remove.
12762         (emit_style_escape): Add stream parameter.
12763         (set_output_style, reset_terminal_style, prompt_for_continue):
12764         Update.
12765         (flush_wrap_buffer): Only flush gdb_stdout.
12766         (wrap_here): Set wrap_style.
12767         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12768         treat escape sequences as a character.  Change when wrap buffer is
12769         flushed.
12770         (fputs_styled): Do not set the output style when the default is
12771         requested.
12772         * ui-style.h (struct ui_file_style) <is_default>: New method.
12773         * source.c (print_source_lines_base): Emit escape sequences in one
12774         piece.
12775
12776 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12777
12778         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12779         integers and enumeration types.
12780
12781 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12782
12783         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12784         instead of lookup_symbol_in_language
12785         (do_exact_match): New function.
12786         (ada_get_symbol_name_matcher): Return do_exact_match when
12787         doing a verbatim match.
12788
12789 2019-02-15  Tom Tromey  <tromey@adacore.com>
12790
12791         * ravenscar-thread.c (ravenscar_thread_target::resume)
12792         (ravenscar_thread_target::wait): Special case wildcard requests.
12793
12794 2019-02-15  Tom Tromey  <tromey@adacore.com>
12795
12796         * ravenscar-thread.c (base_ptid): Remove.
12797         (struct ravenscar_thread_target) <close>: New method.
12798         <m_base_ptid>: New member.
12799         <update_inferior_ptid, active_task, task_is_currently_active,
12800         runtime_initialized>: Declare methods.
12801         <ravenscar_thread_target>: Add constructor.
12802         (ravenscar_thread_target::task_is_currently_active)
12803         (ravenscar_thread_target::update_inferior_ptid)
12804         (ravenscar_runtime_initialized): Rename.  Now methods.
12805         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12806         (ravenscar_thread_target::update_thread_list): Update.
12807         (ravenscar_thread_target::active_task): Now method.
12808         (ravenscar_thread_target::store_registers)
12809         (ravenscar_thread_target::prepare_to_store)
12810         (ravenscar_thread_target::prepare_to_store)
12811         (ravenscar_thread_target::mourn_inferior): Update.
12812         (ravenscar_inferior_created): Use "new" to create target.
12813         (ravenscar_thread_target::get_ada_task_ptid): Update.
12814         (_initialize_ravenscar): Don't initialize base_ptid.
12815         (ravenscar_ops): Remove global.
12816
12817 2019-02-15  Tom Tromey  <tromey@adacore.com>
12818
12819         * target.h (push_target): Declare new overload.
12820         * target.c (push_target): New overload, taking an rvalue reference.
12821         * remote.c (remote_target::open_1): Use push_target overload.
12822         * corelow.c (core_target_open): Use push_target overload.
12823
12824 2019-02-15  Tom Tromey  <tromey@adacore.com>
12825
12826         * ravenscar-thread.c (is_ravenscar_task)
12827         (ravenscar_task_is_currently_active): Return bool.
12828         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12829         (_initialize_ravenscar): Remove "(void)".
12830         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12831         Return bool.
12832
12833 2019-02-15  Tom Tromey  <tromey@adacore.com>
12834
12835         * ravenscar-thread.c (ravenscar_runtime_initializer)
12836         (has_ravenscar_runtime, get_running_thread_id)
12837         (ravenscar_thread_target::resume): Fix indentation.
12838
12839 2019-02-15  Tom Tromey  <tromey@adacore.com>
12840
12841         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12842         from ravenscar_arch_ops.
12843         (sparc_ravenscar_ops::fetch_registers)
12844         (sparc_ravenscar_ops::store_registers): Now methods.
12845         (sparc_ravenscar_prepare_to_store): Remove.
12846         (sparc_ravenscar_ops): Redefine.
12847         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12848         methods and destructor.  Remove members.
12849         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12850         (ravenscar_thread_target::store_registers)
12851         (ravenscar_thread_target::prepare_to_store): Update.
12852         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12853         Remove.
12854         (struct ppc_ravenscar_powerpc_ops): Derive from
12855         ravenscar_arch_ops.
12856         (ppc_ravenscar_powerpc_ops::fetch_registers)
12857         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12858         (ppc_ravenscar_powerpc_ops): Redefine.
12859         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12860         (ppc_ravenscar_e500_ops::fetch_registers)
12861         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12862         (ppc_ravenscar_e500_ops): Redefine.
12863         * aarch64-ravenscar-thread.c
12864         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12865         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12866         (aarch64_ravenscar_fetch_registers)
12867         (aarch64_ravenscar_store_registers): Now methods.
12868         (aarch64_ravenscar_ops): Redefine.
12869
12870 2019-02-15  Tom Tromey  <tromey@adacore.com>
12871
12872         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12873         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12874         (ravenscar_thread_target::stopped_by_watchpoint)
12875         (ravenscar_thread_target::stopped_data_address)
12876         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12877
12878 2019-02-15  Tom Tromey  <tromey@adacore.com>
12879
12880         * ravenscar-thread.c: Fix some typos.
12881
12882 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12883             Tom Tromey  <tromey@adacore.com>
12884
12885         * ada-lang.c (ada_exception_sal): Change addr_string to a
12886         std::string.
12887         (create_ada_exception_catchpoint): Update.
12888
12889 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12890             Tom Tromey  <tromey@adacore.com>
12891
12892         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12893         (bp_location_ops): Remove.
12894         (base_breakpoint_allocate_location): Update.
12895         (free_bp_location): Update.
12896         * ada-lang.c (class ada_catchpoint_location)
12897         <ada_catchpoint_location>: Remove ops parameter.
12898         (ada_catchpoint_location_dtor): Remove.
12899         (ada_catchpoint_location_ops): Remove.
12900         (allocate_location_exception): Update.
12901         * breakpoint.h (struct bp_location_ops): Remove.
12902         (class bp_location) <bp_location>: Remove bp_location_ops
12903         parameter.
12904         <~bp_location>: Add destructor.
12905         <ops>: Remove.
12906
12907 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12908             Pedro Alves  <palves@redhat.com>
12909
12910         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12911         'PATH_MAX'.
12912
12913 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12914             Samuel Thibault  <samuel.thibault@gnu.org>
12915             Thomas Schwinge  <thomas@codesourcery.com>
12916
12917         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12918         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12919
12920 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12921
12922         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12923         (check_empty): Use "const char *".
12924
12925         * gnu-nat.c (gnu_nat_target::detach): Instead of
12926         'detach_inferior (pid)' call
12927         'detach_inferior (find_inferior_pid (pid))'.
12928
12929         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12930         'nat/fork-inferior.o'.
12931         * gnu-nat.c: #include "nat/fork-inferior.h".
12932
12933         * gnu-nat.c (gnu_nat_target::detach): Instead of
12934         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12935         * gnu-nat.h: #include "inf-child.h".
12936         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12937         'i386_gnu_nat_target::fetch_registers'.
12938         (gnu_store_registers): Rename/move to
12939         'i386_gnu_nat_target::store_registers'.
12940
12941         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12942         * gnu-nat.h (mach_thread_info): New function.
12943         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12944
12945         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12946
12947 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12948
12949         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12950
12951 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12952
12953         * windows-nat.c (windows_add_thread): Add new parameter
12954         "main_thread_p" with default value set to false.  Update
12955         function documentation as well as all callers.
12956         (windows_delete_thread): Likewise.
12957         (fake_create_process): Update call to windows_add_thread.
12958         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12959         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12960         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12961         call to windows_delete_thread.
12962
12963 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12964
12965         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12966
12967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12968
12969         * symfile.c (find_separate_debug_file): Use canonical path of
12970         sysroot with child_path instead of gdb_sysroot if it is valid.
12971
12972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12973
12974         * symfile.c (find_separate_debug_file): Use child_path to
12975         determine if an object file is under a sysroot.
12976
12977 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12978
12979         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12980         unittests/child-path-selftests.c.
12981         * common/pathstuff.c (child_path): New function.
12982         * common/pathstuff.h (child_path): New prototype.
12983         * unittests/child-path-selftests.c: New file.
12984
12985 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12986
12987         * symfile.c (find_separate_debug_file): Look for separate debug
12988         files in debug directories under the sysroot.
12989
12990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12991
12992         * symtab.h (struct minimal_symbol data_p): New const method.
12993         (struct minimal_symbol text_p): Likewise.
12994         * symtab.c (output_source_filename): Use file name style
12995         to print file name.
12996         (print_symbol_info): Likewise.
12997         (print_msymbol_info): Use address style to print addresses.
12998         Use function name style to print executable text symbols.
12999         (expand_symtab_containing_pc): Use data_p.
13000         (find_pc_sect_compunit_symtab): Likewise.
13001
13002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13003
13004         * breakpoint.c (describe_other_breakpoints): Use address style
13005         to print addresses.
13006         (say_where): Likewise.
13007
13008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13009
13010         * ada-typeprint.c (print_func_type): Print function name
13011         style to print function name.
13012         * c-typeprint.c (c_print_type_1): Likewise.
13013
13014 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13015
13016         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13017         for execve.
13018
13019 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13020
13021         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13022         type_stack.
13023
13024 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13025
13026         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13027         TYPE_CODE_REF types.
13028
13029 2019-02-08  Jim Wilson  <jimw@sifive.com>
13030
13031         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13032         (riscv_linux_fregset): New.
13033         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13034
13035 2019-02-07  Tom Tromey  <tom@tromey.com>
13036
13037         * thread.c (thread_cancel_execution_command): Update.
13038         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13039         methods.
13040         (struct thread_fsm_ops): Remove.
13041         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13042         (thread_fsm_should_stop, thread_fsm_return_value)
13043         (thread_fsm_set_finished, thread_fsm_finished_p)
13044         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13045         Don't declare.
13046         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13047         * infrun.c (clear_proceed_status_thread)
13048         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13049         (print_stop_event): Update.
13050         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13051         Add constructor.
13052         (step_command_fsm_ops): Remove.
13053         (new_step_command_fsm): Remove.
13054         (step_1): Update.
13055         (step_command_fsm::should_stop): Rename from
13056         step_command_fsm_should_stop.
13057         (step_command_fsm::clean_up): Rename from
13058         step_command_fsm_clean_up.
13059         (step_command_fsm::do_async_reply_reason): Rename from
13060         step_command_fsm_async_reply_reason.
13061         (struct until_next_fsm): Inherit from thread_fsm.  Add
13062         constructor.
13063         (until_next_fsm_ops): Remove.
13064         (new_until_next_fsm): Remove.
13065         (until_next_fsm::should_stop): Rename from
13066         until_next_fsm_should_stop.
13067         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13068         (until_next_fsm::do_async_reply_reason): Rename from
13069         until_next_fsm_async_reply_reason.
13070         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13071         constructor.  Change type of breakpoint.
13072         (finish_command_fsm_ops): Remove.
13073         (new_finish_command_fsm): Remove.
13074         (finish_command_fsm::should_stop): Rename from
13075         finish_command_fsm_should_stop.
13076         (finish_command_fsm::clean_up): Rename from
13077         finish_command_fsm_clean_up.
13078         (finish_command_fsm::return_value): Rename from
13079         finish_command_fsm_return_value.
13080         (finish_command_fsm::do_async_reply_reason): Rename from
13081         finish_command_fsm_async_reply_reason.
13082         (finish_command): Update.
13083         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13084         Add constructor.
13085         (call_thread_fsm_ops): Remove.
13086         (call_thread_fsm::call_thread_fsm): Rename from
13087         new_call_thread_fsm.
13088         (call_thread_fsm::should_stop): Rename from
13089         call_thread_fsm_should_stop.
13090         (call_thread_fsm::should_notify_stop): Rename from
13091         call_thread_fsm_should_notify_stop.
13092         (run_inferior_call, call_function_by_hand_dummy): Update.
13093         * cli/cli-interp.c (should_print_stop_to_console): Update.
13094         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13095         Add constructor.  Change type of location_breakpoint,
13096         caller_breakpoint.
13097         (until_break_fsm_ops): Remove.
13098         (new_until_break_fsm): Remove.
13099         (until_break_fsm::should_stop): Rename from
13100         until_break_fsm_should_stop.
13101         (until_break_fsm::clean_up): Rename from
13102         until_break_fsm_clean_up.
13103         (until_break_fsm::do_async_reply_reason): Rename from
13104         until_break_fsm_async_reply_reason.
13105         (until_break_command): Update.
13106         * thread-fsm.c: Remove.
13107         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13108
13109 2019-02-07  Tom Tromey  <tom@tromey.com>
13110
13111         * yy-remap.h: Add include guard.
13112         * xtensa-tdep.h: Add include guard.
13113         * xcoffread.h: Rename include guard.
13114         * varobj-iter.h: Add include guard.
13115         * tui/tui.h: Rename include guard.
13116         * tui/tui-winsource.h: Rename include guard.
13117         * tui/tui-wingeneral.h: Rename include guard.
13118         * tui/tui-windata.h: Rename include guard.
13119         * tui/tui-win.h: Rename include guard.
13120         * tui/tui-stack.h: Rename include guard.
13121         * tui/tui-source.h: Rename include guard.
13122         * tui/tui-regs.h: Rename include guard.
13123         * tui/tui-out.h: Rename include guard.
13124         * tui/tui-layout.h: Rename include guard.
13125         * tui/tui-io.h: Rename include guard.
13126         * tui/tui-hooks.h: Rename include guard.
13127         * tui/tui-file.h: Rename include guard.
13128         * tui/tui-disasm.h: Rename include guard.
13129         * tui/tui-data.h: Rename include guard.
13130         * tui/tui-command.h: Rename include guard.
13131         * tic6x-tdep.h: Add include guard.
13132         * target/waitstatus.h: Rename include guard.
13133         * target/wait.h: Rename include guard.
13134         * target/target.h: Rename include guard.
13135         * target/resume.h: Rename include guard.
13136         * target-float.h: Rename include guard.
13137         * stabsread.h: Add include guard.
13138         * rs6000-tdep.h: Add include guard.
13139         * riscv-fbsd-tdep.h: Add include guard.
13140         * regformats/regdef.h: Rename include guard.
13141         * record.h: Rename include guard.
13142         * python/python.h: Rename include guard.
13143         * python/python-internal.h: Rename include guard.
13144         * python/py-stopevent.h: Rename include guard.
13145         * python/py-ref.h: Rename include guard.
13146         * python/py-record.h: Rename include guard.
13147         * python/py-record-full.h: Rename include guard.
13148         * python/py-record-btrace.h: Rename include guard.
13149         * python/py-instruction.h: Rename include guard.
13150         * python/py-events.h: Rename include guard.
13151         * python/py-event.h: Rename include guard.
13152         * procfs.h: Add include guard.
13153         * proc-utils.h: Add include guard.
13154         * p-lang.h: Add include guard.
13155         * or1k-tdep.h: Rename include guard.
13156         * observable.h: Rename include guard.
13157         * nto-tdep.h: Rename include guard.
13158         * nat/x86-linux.h: Rename include guard.
13159         * nat/x86-linux-dregs.h: Rename include guard.
13160         * nat/x86-gcc-cpuid.h: Add include guard.
13161         * nat/x86-dregs.h: Rename include guard.
13162         * nat/x86-cpuid.h: Rename include guard.
13163         * nat/ppc-linux.h: Rename include guard.
13164         * nat/mips-linux-watch.h: Rename include guard.
13165         * nat/linux-waitpid.h: Rename include guard.
13166         * nat/linux-ptrace.h: Rename include guard.
13167         * nat/linux-procfs.h: Rename include guard.
13168         * nat/linux-osdata.h: Rename include guard.
13169         * nat/linux-nat.h: Rename include guard.
13170         * nat/linux-namespaces.h: Rename include guard.
13171         * nat/linux-btrace.h: Rename include guard.
13172         * nat/glibc_thread_db.h: Rename include guard.
13173         * nat/gdb_thread_db.h: Rename include guard.
13174         * nat/gdb_ptrace.h: Rename include guard.
13175         * nat/fork-inferior.h: Rename include guard.
13176         * nat/amd64-linux-siginfo.h: Rename include guard.
13177         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13178         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13179         * nat/aarch64-linux.h: Rename include guard.
13180         * nat/aarch64-linux-hw-point.h: Rename include guard.
13181         * mn10300-tdep.h: Add include guard.
13182         * mips-linux-tdep.h: Add include guard.
13183         * mi/mi-parse.h: Rename include guard.
13184         * mi/mi-out.h: Rename include guard.
13185         * mi/mi-main.h: Rename include guard.
13186         * mi/mi-interp.h: Rename include guard.
13187         * mi/mi-getopt.h: Rename include guard.
13188         * mi/mi-console.h: Rename include guard.
13189         * mi/mi-common.h: Rename include guard.
13190         * mi/mi-cmds.h: Rename include guard.
13191         * mi/mi-cmd-break.h: Rename include guard.
13192         * m2-lang.h: Add include guard.
13193         * location.h: Rename include guard.
13194         * linux-record.h: Rename include guard.
13195         * linux-nat.h: Add include guard.
13196         * linux-fork.h: Add include guard.
13197         * i386-darwin-tdep.h: Rename include guard.
13198         * hppa-linux-offsets.h: Add include guard.
13199         * guile/guile.h: Rename include guard.
13200         * guile/guile-internal.h: Rename include guard.
13201         * gnu-nat.h: Rename include guard.
13202         * gdb-stabs.h: Rename include guard.
13203         * frv-tdep.h: Add include guard.
13204         * f-lang.h: Add include guard.
13205         * event-loop.h: Add include guard.
13206         * darwin-nat.h: Rename include guard.
13207         * cp-abi.h: Rename include guard.
13208         * config/sparc/nm-sol2.h: Rename include guard.
13209         * config/nm-nto.h: Rename include guard.
13210         * config/nm-linux.h: Add include guard.
13211         * config/i386/nm-i386gnu.h: Rename include guard.
13212         * config/djgpp/nl_types.h: Rename include guard.
13213         * config/djgpp/langinfo.h: Rename include guard.
13214         * compile/gcc-cp-plugin.h: Add include guard.
13215         * compile/gcc-c-plugin.h: Add include guard.
13216         * compile/compile.h: Rename include guard.
13217         * compile/compile-object-run.h: Rename include guard.
13218         * compile/compile-object-load.h: Rename include guard.
13219         * compile/compile-internal.h: Rename include guard.
13220         * compile/compile-cplus.h: Rename include guard.
13221         * compile/compile-c.h: Rename include guard.
13222         * common/xml-utils.h: Rename include guard.
13223         * common/x86-xstate.h: Rename include guard.
13224         * common/version.h: Rename include guard.
13225         * common/vec.h: Rename include guard.
13226         * common/tdesc.h: Rename include guard.
13227         * common/selftest.h: Rename include guard.
13228         * common/scoped_restore.h: Rename include guard.
13229         * common/scoped_mmap.h: Rename include guard.
13230         * common/scoped_fd.h: Rename include guard.
13231         * common/safe-iterator.h: Rename include guard.
13232         * common/run-time-clock.h: Rename include guard.
13233         * common/refcounted-object.h: Rename include guard.
13234         * common/queue.h: Rename include guard.
13235         * common/ptid.h: Rename include guard.
13236         * common/print-utils.h: Rename include guard.
13237         * common/preprocessor.h: Rename include guard.
13238         * common/pathstuff.h: Rename include guard.
13239         * common/observable.h: Rename include guard.
13240         * common/netstuff.h: Rename include guard.
13241         * common/job-control.h: Rename include guard.
13242         * common/host-defs.h: Rename include guard.
13243         * common/gdb_wait.h: Rename include guard.
13244         * common/gdb_vecs.h: Rename include guard.
13245         * common/gdb_unlinker.h: Rename include guard.
13246         * common/gdb_unique_ptr.h: Rename include guard.
13247         * common/gdb_tilde_expand.h: Rename include guard.
13248         * common/gdb_sys_time.h: Rename include guard.
13249         * common/gdb_string_view.h: Rename include guard.
13250         * common/gdb_splay_tree.h: Rename include guard.
13251         * common/gdb_setjmp.h: Rename include guard.
13252         * common/gdb_ref_ptr.h: Rename include guard.
13253         * common/gdb_optional.h: Rename include guard.
13254         * common/gdb_locale.h: Rename include guard.
13255         * common/gdb_assert.h: Rename include guard.
13256         * common/filtered-iterator.h: Rename include guard.
13257         * common/filestuff.h: Rename include guard.
13258         * common/fileio.h: Rename include guard.
13259         * common/environ.h: Rename include guard.
13260         * common/common-utils.h: Rename include guard.
13261         * common/common-types.h: Rename include guard.
13262         * common/common-regcache.h: Rename include guard.
13263         * common/common-inferior.h: Rename include guard.
13264         * common/common-gdbthread.h: Rename include guard.
13265         * common/common-exceptions.h: Rename include guard.
13266         * common/common-defs.h: Rename include guard.
13267         * common/common-debug.h: Rename include guard.
13268         * common/cleanups.h: Rename include guard.
13269         * common/buffer.h: Rename include guard.
13270         * common/btrace-common.h: Rename include guard.
13271         * common/break-common.h: Rename include guard.
13272         * cli/cli-utils.h: Rename include guard.
13273         * cli/cli-style.h: Rename include guard.
13274         * cli/cli-setshow.h: Rename include guard.
13275         * cli/cli-script.h: Rename include guard.
13276         * cli/cli-interp.h: Rename include guard.
13277         * cli/cli-decode.h: Rename include guard.
13278         * cli/cli-cmds.h: Rename include guard.
13279         * charset-list.h: Add include guard.
13280         * buildsym-legacy.h: Rename include guard.
13281         * bfin-tdep.h: Add include guard.
13282         * ax.h: Rename include guard.
13283         * arm-linux-tdep.h: Add include guard.
13284         * arm-fbsd-tdep.h: Add include guard.
13285         * arch/xtensa.h: Rename include guard.
13286         * arch/tic6x.h: Add include guard.
13287         * arch/i386.h: Add include guard.
13288         * arch/arm.h: Rename include guard.
13289         * arch/arm-linux.h: Rename include guard.
13290         * arch/arm-get-next-pcs.h: Rename include guard.
13291         * arch/amd64.h: Add include guard.
13292         * arch/aarch64-insn.h: Rename include guard.
13293         * arch-utils.h: Rename include guard.
13294         * annotate.h: Add include guard.
13295         * amd64-darwin-tdep.h: Rename include guard.
13296         * aarch64-linux-tdep.h: Add include guard.
13297         * aarch64-fbsd-tdep.h: Add include guard.
13298         * aarch32-linux-nat.h: Add include guard.
13299
13300 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13301
13302         * macrotab.c (macro_define_internal): New function that
13303         factorizes macro_define_object_internal and macro_define_function
13304         code.
13305         (macro_define_object_internal): Use macro_define_internal.
13306         (macro_define_function): Likewise.
13307
13308 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13309
13310         * macrocmd.c (extract_identifier): Return
13311         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13312         callers.
13313
13314 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13315
13316         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13317
13318 2019-02-05  Tom Tromey  <tom@tromey.com>
13319
13320         * target.c (target_stack::unpush): Move assertion earlier.
13321
13322 2019-01-30  Tom Tromey  <tom@tromey.com>
13323
13324         PR python/23615:
13325         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13326         (gdbpy_parse_and_eval): Likewise.
13327         * python/python-internal.h (gdbpy_allow_threads): New class.
13328
13329 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13330
13331         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13332         (aarch64_fbsd_fpregmap): Move earlier.
13333         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13334         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13335         instead of individual calls to trad_frame_set_reg_addr.
13336         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13337         earlier.
13338         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13339         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13340         instead of individual calls to trad_frame_set_reg_addr.
13341
13342 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13343
13344         * CONTRIBUTE: Replace contribution list with wiki link.
13345
13346 2019-01-25  Tom Tromey  <tom@tromey.com>
13347
13348         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13349
13350 2019-01-25  Tom Tromey  <tom@tromey.com>
13351
13352         * xtensa-linux-nat.c: Fix common/ includes.
13353         * xml-support.h: Fix common/ includes.
13354         * xml-support.c: Fix common/ includes.
13355         * x86-linux-nat.c: Fix common/ includes.
13356         * windows-nat.c: Fix common/ includes.
13357         * varobj.h: Fix common/ includes.
13358         * varobj.c: Fix common/ includes.
13359         * value.c: Fix common/ includes.
13360         * valops.c: Fix common/ includes.
13361         * utils.c: Fix common/ includes.
13362         * unittests/xml-utils-selftests.c: Fix common/ includes.
13363         * unittests/utils-selftests.c: Fix common/ includes.
13364         * unittests/unpack-selftests.c: Fix common/ includes.
13365         * unittests/tracepoint-selftests.c: Fix common/ includes.
13366         * unittests/style-selftests.c: Fix common/ includes.
13367         * unittests/string_view-selftests.c: Fix common/ includes.
13368         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13369         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13370         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13371         * unittests/rsp-low-selftests.c: Fix common/ includes.
13372         * unittests/parse-connection-spec-selftests.c: Fix common/
13373         includes.
13374         * unittests/optional-selftests.c: Fix common/ includes.
13375         * unittests/offset-type-selftests.c: Fix common/ includes.
13376         * unittests/observable-selftests.c: Fix common/ includes.
13377         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13378         * unittests/memrange-selftests.c: Fix common/ includes.
13379         * unittests/memory-map-selftests.c: Fix common/ includes.
13380         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13381         * unittests/function-view-selftests.c: Fix common/ includes.
13382         * unittests/environ-selftests.c: Fix common/ includes.
13383         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13384         * unittests/common-utils-selftests.c: Fix common/ includes.
13385         * unittests/cli-utils-selftests.c: Fix common/ includes.
13386         * unittests/array-view-selftests.c: Fix common/ includes.
13387         * ui-file.c: Fix common/ includes.
13388         * tui/tui-io.c: Fix common/ includes.
13389         * tracepoint.h: Fix common/ includes.
13390         * tracepoint.c: Fix common/ includes.
13391         * tracefile-tfile.c: Fix common/ includes.
13392         * top.h: Fix common/ includes.
13393         * top.c: Fix common/ includes.
13394         * thread.c: Fix common/ includes.
13395         * target/waitstatus.h: Fix common/ includes.
13396         * target/waitstatus.c: Fix common/ includes.
13397         * target.h: Fix common/ includes.
13398         * target.c: Fix common/ includes.
13399         * target-memory.c: Fix common/ includes.
13400         * target-descriptions.c: Fix common/ includes.
13401         * symtab.h: Fix common/ includes.
13402         * symfile.c: Fix common/ includes.
13403         * stap-probe.c: Fix common/ includes.
13404         * spu-linux-nat.c: Fix common/ includes.
13405         * sparc-nat.c: Fix common/ includes.
13406         * source.c: Fix common/ includes.
13407         * solib.c: Fix common/ includes.
13408         * solib-target.c: Fix common/ includes.
13409         * ser-unix.c: Fix common/ includes.
13410         * ser-tcp.c: Fix common/ includes.
13411         * ser-pipe.c: Fix common/ includes.
13412         * ser-base.c: Fix common/ includes.
13413         * selftest-arch.c: Fix common/ includes.
13414         * s12z-tdep.c: Fix common/ includes.
13415         * rust-exp.y: Fix common/ includes.
13416         * rs6000-aix-tdep.c: Fix common/ includes.
13417         * riscv-tdep.c: Fix common/ includes.
13418         * remote.c: Fix common/ includes.
13419         * remote-notif.h: Fix common/ includes.
13420         * remote-fileio.h: Fix common/ includes.
13421         * remote-fileio.c: Fix common/ includes.
13422         * regcache.h: Fix common/ includes.
13423         * regcache.c: Fix common/ includes.
13424         * record-btrace.c: Fix common/ includes.
13425         * python/python.c: Fix common/ includes.
13426         * python/py-type.c: Fix common/ includes.
13427         * python/py-inferior.c: Fix common/ includes.
13428         * progspace.h: Fix common/ includes.
13429         * producer.c: Fix common/ includes.
13430         * procfs.c: Fix common/ includes.
13431         * proc-api.c: Fix common/ includes.
13432         * printcmd.c: Fix common/ includes.
13433         * ppc-linux-nat.c: Fix common/ includes.
13434         * parser-defs.h: Fix common/ includes.
13435         * osdata.c: Fix common/ includes.
13436         * obsd-nat.c: Fix common/ includes.
13437         * nat/x86-linux.c: Fix common/ includes.
13438         * nat/x86-linux-dregs.c: Fix common/ includes.
13439         * nat/x86-dregs.h: Fix common/ includes.
13440         * nat/x86-dregs.c: Fix common/ includes.
13441         * nat/ppc-linux.c: Fix common/ includes.
13442         * nat/mips-linux-watch.h: Fix common/ includes.
13443         * nat/mips-linux-watch.c: Fix common/ includes.
13444         * nat/linux-waitpid.c: Fix common/ includes.
13445         * nat/linux-ptrace.h: Fix common/ includes.
13446         * nat/linux-ptrace.c: Fix common/ includes.
13447         * nat/linux-procfs.c: Fix common/ includes.
13448         * nat/linux-personality.c: Fix common/ includes.
13449         * nat/linux-osdata.c: Fix common/ includes.
13450         * nat/linux-namespaces.c: Fix common/ includes.
13451         * nat/linux-btrace.h: Fix common/ includes.
13452         * nat/linux-btrace.c: Fix common/ includes.
13453         * nat/fork-inferior.c: Fix common/ includes.
13454         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13455         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13456         * nat/aarch64-linux.c: Fix common/ includes.
13457         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13458         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13459         * namespace.h: Fix common/ includes.
13460         * mips-linux-tdep.c: Fix common/ includes.
13461         * minsyms.c: Fix common/ includes.
13462         * mi/mi-parse.h: Fix common/ includes.
13463         * mi/mi-main.c: Fix common/ includes.
13464         * mi/mi-cmd-env.c: Fix common/ includes.
13465         * memrange.h: Fix common/ includes.
13466         * memattr.c: Fix common/ includes.
13467         * maint.h: Fix common/ includes.
13468         * maint.c: Fix common/ includes.
13469         * main.c: Fix common/ includes.
13470         * machoread.c: Fix common/ includes.
13471         * location.c: Fix common/ includes.
13472         * linux-thread-db.c: Fix common/ includes.
13473         * linux-nat.c: Fix common/ includes.
13474         * linux-fork.c: Fix common/ includes.
13475         * inline-frame.c: Fix common/ includes.
13476         * infrun.c: Fix common/ includes.
13477         * inflow.c: Fix common/ includes.
13478         * inferior.h: Fix common/ includes.
13479         * inferior.c: Fix common/ includes.
13480         * infcmd.c: Fix common/ includes.
13481         * inf-ptrace.c: Fix common/ includes.
13482         * inf-child.c: Fix common/ includes.
13483         * ia64-linux-nat.c: Fix common/ includes.
13484         * i387-tdep.c: Fix common/ includes.
13485         * i386-tdep.c: Fix common/ includes.
13486         * i386-linux-tdep.c: Fix common/ includes.
13487         * i386-linux-nat.c: Fix common/ includes.
13488         * i386-go32-tdep.c: Fix common/ includes.
13489         * i386-fbsd-tdep.c: Fix common/ includes.
13490         * i386-fbsd-nat.c: Fix common/ includes.
13491         * guile/scm-type.c: Fix common/ includes.
13492         * guile/guile.c: Fix common/ includes.
13493         * go32-nat.c: Fix common/ includes.
13494         * gnu-nat.c: Fix common/ includes.
13495         * gdbthread.h: Fix common/ includes.
13496         * gdbarch-selftests.c: Fix common/ includes.
13497         * gdb_usleep.c: Fix common/ includes.
13498         * gdb_select.h: Fix common/ includes.
13499         * gdb_bfd.c: Fix common/ includes.
13500         * gcore.c: Fix common/ includes.
13501         * fork-child.c: Fix common/ includes.
13502         * findvar.c: Fix common/ includes.
13503         * fbsd-nat.c: Fix common/ includes.
13504         * event-top.c: Fix common/ includes.
13505         * event-loop.c: Fix common/ includes.
13506         * dwarf2read.c: Fix common/ includes.
13507         * dwarf2loc.c: Fix common/ includes.
13508         * dwarf2-frame.c: Fix common/ includes.
13509         * dwarf-index-cache.c: Fix common/ includes.
13510         * dtrace-probe.c: Fix common/ includes.
13511         * disasm-selftests.c: Fix common/ includes.
13512         * defs.h: Fix common/ includes.
13513         * csky-tdep.c: Fix common/ includes.
13514         * cp-valprint.c: Fix common/ includes.
13515         * cp-support.h: Fix common/ includes.
13516         * cp-support.c: Fix common/ includes.
13517         * corelow.c: Fix common/ includes.
13518         * completer.h: Fix common/ includes.
13519         * completer.c: Fix common/ includes.
13520         * compile/compile.c: Fix common/ includes.
13521         * compile/compile-loc2c.c: Fix common/ includes.
13522         * compile/compile-cplus-types.c: Fix common/ includes.
13523         * compile/compile-cplus-symbols.c: Fix common/ includes.
13524         * command.h: Fix common/ includes.
13525         * cli/cli-dump.c: Fix common/ includes.
13526         * cli/cli-cmds.c: Fix common/ includes.
13527         * charset.c: Fix common/ includes.
13528         * build-id.c: Fix common/ includes.
13529         * btrace.h: Fix common/ includes.
13530         * btrace.c: Fix common/ includes.
13531         * breakpoint.h: Fix common/ includes.
13532         * breakpoint.c: Fix common/ includes.
13533         * ax.h:
13534         (enum agent_op): Fix common/ includes.
13535         * ax-general.c (struct aop_map): Fix common/ includes.
13536         * ax-gdb.c: Fix common/ includes.
13537         * auxv.c: Fix common/ includes.
13538         * auto-load.c: Fix common/ includes.
13539         * arm-tdep.c: Fix common/ includes.
13540         * arch/riscv.c: Fix common/ includes.
13541         * arch/ppc-linux-common.c: Fix common/ includes.
13542         * arch/i386.c: Fix common/ includes.
13543         * arch/arm.c: Fix common/ includes.
13544         * arch/arm-linux.c: Fix common/ includes.
13545         * arch/arm-get-next-pcs.c: Fix common/ includes.
13546         * arch/amd64.c: Fix common/ includes.
13547         * arch/aarch64.c: Fix common/ includes.
13548         * arch/aarch64-insn.c: Fix common/ includes.
13549         * arch-utils.c: Fix common/ includes.
13550         * amd64-windows-tdep.c: Fix common/ includes.
13551         * amd64-tdep.c: Fix common/ includes.
13552         * amd64-sol2-tdep.c: Fix common/ includes.
13553         * amd64-obsd-tdep.c: Fix common/ includes.
13554         * amd64-nbsd-tdep.c: Fix common/ includes.
13555         * amd64-linux-tdep.c: Fix common/ includes.
13556         * amd64-linux-nat.c: Fix common/ includes.
13557         * amd64-fbsd-tdep.c: Fix common/ includes.
13558         * amd64-fbsd-nat.c: Fix common/ includes.
13559         * amd64-dicos-tdep.c: Fix common/ includes.
13560         * amd64-darwin-tdep.c: Fix common/ includes.
13561         * agent.c: Fix common/ includes.
13562         * ada-lang.h: Fix common/ includes.
13563         * ada-lang.c: Fix common/ includes.
13564         * aarch64-tdep.c: Fix common/ includes.
13565
13566 2019-01-25  Tom Tromey  <tom@tromey.com>
13567
13568         * common/create-version.sh: Use common/version.h.
13569
13570 2019-01-24  Pedro Alves  <palves@redhat.com>
13571
13572         * infrun.c (signal_stop, signal_print, signal_program)
13573         (signal_catch, signal_pass): Now arrays instead of pointers.
13574         (update_signals_program_target, do_target_resume)
13575         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13576         * linux-nat.c (linux_nat_target::pass_signals)
13577         (linux_nat_target::create_inferior, linux_nat_target::attach):
13578         Adjust.
13579         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13580         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13581         * procfs.c (procfs_target::pass_signals): Adjust.
13582         * record-full.c (record_full_target::resume): Adjust.
13583         * remote.c (remote_target::pass_signals)
13584         (remote_target::program_signals): Adjust.
13585         * target-debug.h (target_debug_print_signals): Now takes a
13586         gdb::array_view as parameter.  Adjust.
13587         * target.h (target_ops) <pass_signals, program_signals>: Replace
13588         pointer and length parameters with gdb::array_view.
13589         (target_pass_signals, target_program_signals): Likewise.
13590         * target-delegates.c: Regenerate.
13591
13592 2019-01-24  Pedro Alves  <palves@redhat.com>
13593
13594         * common/forward-scope-exit.h
13595         (forward_scope_exit::forward_scope_exit): Pass arguments to
13596         m_bind_function directly, instead of creating a std::bind and
13597         copying that.
13598
13599 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13600
13601         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13602         for static members.
13603         (pass_in_v_vfp_candidate): Likewise.
13604
13605 2019-01-23  Tom Tromey  <tom@tromey.com>
13606             Pedro Alves  <palves@redhat.com>
13607
13608         * regcache.c (class regcache_invalidator): Remove.
13609         (regcache::raw_write): Use make_scope_exit.
13610
13611 2019-01-23  Tom Tromey  <tom@tromey.com>
13612
13613         * ui-out.h (class ui_out_emit_type): Update comment.
13614
13615 2019-01-23  Tom Tromey  <tom@tromey.com>
13616
13617         * infrun.c (fetch_inferior_event): Update comment.
13618
13619 2019-01-23  Tom Tromey  <tom@tromey.com>
13620             Pedro Alves  <palves@redhat.com>
13621
13622         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13623         parameter.
13624         (fetch_inferior_event): Use SCOPE_EXIT.
13625
13626
13627 2019-01-23  Tom Tromey  <tom@tromey.com>
13628             Pedro Alves  <palves@redhat.com>
13629
13630         * infrun.c (disable_thread_events): Delete.
13631         (stop_all_threads): Use SCOPE_EXIT.
13632
13633 2019-01-23  Tom Tromey  <tom@tromey.com>
13634             Pedro Alves  <palves@redhat.com>
13635
13636         * symfile.c: Include forward-scope-exit.h.
13637         (clear_symtab_users_cleanup): Replace forward declaration with
13638         a FORWARD_SCOPE_EXIT.
13639         (syms_from_objfile_1): Use the forward_scope_exit and
13640         gdb::optional instead of cleanup_function.
13641         (reread_symbols): Use the forward_scope_exit instead of
13642         cleanup_function.
13643         (clear_symtab_users_cleanup): Remove function.
13644
13645 2019-01-23  Tom Tromey  <tom@tromey.com>
13646             Pedro Alves  <palves@redhat.com>
13647
13648         * linux-nat.c: Include scope-exit.h.
13649         (cleanup_target_stop): Remove.
13650         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13651         SCOPE_EXIT.
13652
13653 2019-01-23  Tom Tromey  <tom@tromey.com>
13654             Pedro Alves  <palves@redhat.com>
13655
13656         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13657         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13658
13659 2019-01-23  Tom Tromey  <tom@tromey.com>
13660             Andrew Burgess  <andrew.burgess@embecosm.com>
13661             Pedro Alves  <palves@redhat.com>
13662
13663         * infrun.c (fetch_inferior_event): Use scope_exit.
13664         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13665         * top.c (execute_command): Use scope_exit.
13666         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13667         * utils.c (do_bpstat_clear_actions_cleanup)
13668         (make_bpstat_clear_actions_cleanup): Remove.
13669
13670 2019-01-23  Tom Tromey  <tom@tromey.com>
13671             Pedro Alves  <palves@redhat.com>
13672
13673         * infrun.c: Include "common/scope-exit.h"
13674         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13675         (wait_for_inferior): Use SCOPE_EXIT.
13676         (fetch_inferior_event): Use scope_exit.
13677
13678 2019-01-23  Tom Tromey  <tom@tromey.com>
13679             Pedro Alves  <palves@redhat.com>
13680
13681         * breakpoint.c (create_breakpoint): Remove cleanup.
13682
13683 2019-01-23  Tom Tromey  <tom@tromey.com>
13684             Andrew Burgess  <andrew.burgess@embecosm.com>
13685             Pedro Alves  <palves@redhat.com>
13686
13687 2019-01-23  Pedro Alves  <palves@redhat.com>
13688
13689         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13690
13691 2019-01-23  Pedro Alves  <palves@redhat.com>
13692             Andrew Burgess  <andrew.burgess@embecosm.com>
13693
13694         * gdbthread.h: Include "common/forward-scope-exit.h".
13695         (scoped_finish_thread_state): Redefine custom class in terms of
13696         forward_scope_exit.
13697
13698 2019-01-23  Pedro Alves  <palves@redhat.com>
13699             Andrew Burgess  <andrew.burgess@embecosm.com>
13700
13701         * common/forward-scope-exit.h: New file.
13702
13703 2019-01-23  Pedro Alves  <palves@redhat.com>
13704             Andrew Burgess  <andrew.burgess@embecosm.com>
13705             Tom Tromey  <tom@tromey.com>
13706
13707         * common/scope-exit.h: New file.
13708
13709 2019-01-23  Pedro Alves  <palves@redhat.com>
13710
13711         * common/preprocessor.h (ESC): Rename to ...
13712         (ESC_PARENS): ... this.
13713         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13714         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13715
13716 2019-01-23  Tom Tromey  <tom@tromey.com>
13717
13718         * language.h (class scoped_switch_to_sym_language_if_auto):
13719         Initialize m_lang in both cases.
13720
13721 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13722
13723         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13724         with XCNEW.
13725
13726 2019-01-22  Tom Tromey  <tom@tromey.com>
13727
13728         * corelow.c: Do not include sys/file.h.
13729
13730 2019-01-22  Tom Tromey  <tom@tromey.com>
13731
13732         * tui/tui-wingeneral.h: Include gdb_curses.h.
13733
13734 2019-01-22  Tom Tromey  <tom@tromey.com>
13735
13736         * source-cache.h (class source_cache) <get_source_lines,
13737         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13738
13739 2019-01-22  Tom Tromey  <tom@tromey.com>
13740
13741         * remote-fileio.h (struct remote_target): Declare.
13742
13743 2019-01-22  Tom Tromey  <tom@tromey.com>
13744
13745         * python/py-arch.c: Do not include py-ref.h.
13746         * python/py-bpevent.c: Do not include py-ref.h.
13747         * python/py-cmd.c: Do not include py-ref.h.
13748         * python/py-continueevent.c: Do not include py-ref.h.
13749         * python/py-event.h: Do not include py-ref.h.
13750         * python/py-evtregistry.c: Do not include py-ref.h.
13751         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13752         * python/py-frame.c: Do not include py-ref.h.
13753         * python/py-framefilter.c: Do not include py-ref.h.
13754         * python/py-function.c: Do not include py-ref.h.
13755         * python/py-infevents.c: Do not include py-ref.h.
13756         * python/py-linetable.c: Do not include py-ref.h.
13757         * python/py-objfile.c: Do not include py-ref.h.
13758         * python/py-param.c: Do not include py-ref.h.
13759         * python/py-prettyprint.c: Do not include py-ref.h.
13760         * python/py-progspace.c: Do not include py-ref.h.
13761         * python/py-symbol.c: Do not include py-ref.h.
13762         * python/py-symtab.c: Do not include py-ref.h.
13763         * python/py-type.c: Do not include py-ref.h.
13764         * python/py-unwind.c: Do not include py-ref.h.
13765         * python/py-utils.c: Do not include py-ref.h.
13766         * python/py-value.c: Do not include py-ref.h.
13767         * python/py-varobj.c: Do not include py-ref.h.
13768         * python/py-xmethods.c: Do not include py-ref.h.
13769         * python/python.c: Do not include py-ref.h.
13770         * varobj.c: Do not include py-ref.h.
13771
13772 2019-01-22  Tom Tromey  <tom@tromey.com>
13773
13774         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13775         keyword for bcache.
13776
13777 2019-01-22  Tom Tromey  <tom@tromey.com>
13778
13779         * compile/compile-cplus-types.c: Remove a comment by #include.
13780
13781 2019-01-22  Tom Tromey  <tom@tromey.com>
13782
13783         * compile/gcc-c-plugin.h: Include compile-internal.h.
13784
13785 2019-01-22  Tom Tromey  <tom@tromey.com>
13786
13787         * stabsread.c (EXTERN): Do not define.
13788         (symnum, next_symbol_text_func, processing_gcc_compilation)
13789         (within_function, global_sym_chain, global_stabs)
13790         (previous_stab_code, this_object_header_files)
13791         (n_this_object_header_files)
13792         (n_allocated_this_object_header_files): Define.
13793         * stabsread.h (EXTERN): Never define.  Use "extern".
13794
13795 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13796
13797         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13798         history_value.
13799
13800 2019-01-21  Tom Tromey  <tom@tromey.com>
13801
13802         * ui-out.c: Fix includes.
13803         * tui/tui-source.c: Fix includes.
13804         * target.c: Fix includes.
13805         * remote.c: Fix includes.
13806         * regcache.c: Fix includes.
13807         * python/py-block.c: Fix includes.
13808         * printcmd.c: Fix includes.
13809         * or1k-tdep.c: Fix includes.
13810         * mi/mi-main.c: Fix includes.
13811         * m32r-tdep.c: Fix includes.
13812         * csky-tdep.c: Fix includes.
13813         * compile/compile-cplus-types.c: Fix includes.
13814         * cli/cli-interp.c: Fix includes.
13815
13816 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13817
13818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13819         for padding.
13820
13821 2019-01-16  Tom Tromey  <tom@tromey.com>
13822
13823         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13824         earlier.
13825         (struct objfile) <msymbols_range>: Move from top level.
13826         <msymbols>: New method.
13827         (class objfile_msymbols): Remove.
13828         * symtab.c (default_collect_symbol_completion_matches_break_on):
13829         Update.
13830         * symmisc.c (dump_msymbols): Update.
13831         * stabsread.c (scan_file_globals): Update.
13832         * objc-lang.c (info_selectors_command, info_classes_command)
13833         (find_methods): Update.
13834         * minsyms.c (find_solib_trampoline_target): Update.
13835         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13836         * coffread.c (coff_symfile_read): Update.
13837         * ada-lang.c (ada_lookup_simple_minsym)
13838         (ada_collect_symbol_completion_matches): Update.
13839
13840 2019-01-16  Tom Tromey  <tom@tromey.com>
13841
13842         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13843         type.  Remove no-argument constructor.
13844         <iterator::operator++>: Simplify.
13845         <begin>: Update.
13846         <end>: Use minimal_symbol_count.
13847
13848 2019-01-16  Tom Tromey  <tom@tromey.com>
13849
13850         * objfiles.h (struct objfile) <psymtabs>: New method.
13851         (class objfile_psymtabs): Remove.
13852         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13853         typedef.
13854         <range>: New method.
13855         (require_partial_symbols): Change return type.
13856         * psymtab.c (require_partial_symbols)
13857         (psym_expand_symtabs_matching): Update.
13858         * mdebugread.c (parse_partial_symbols): Update.
13859         * dbxread.c (dbx_end_psymtab): Update.
13860
13861 2019-01-15  Tom Tromey  <tom@tromey.com>
13862
13863         * symtab.c (lookup_objfile_from_block)
13864         (lookup_symbol_in_objfile_symtabs)
13865         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13866         (find_line_symtab, info_sources_command)
13867         (default_collect_symbol_completion_matches_break_on)
13868         (make_source_files_completion_list): Update.
13869         * symmisc.c (print_objfile_statistics, dump_objfile)
13870         (maintenance_print_symbols, maintenance_info_symtabs)
13871         (maintenance_check_symtabs, maintenance_info_line_tables):
13872         Update.
13873         * source.c (select_source_symtab)
13874         (forget_cached_source_info_for_objfile): Update.
13875         * objfiles.h (class objfile_compunits): Remove.
13876         (struct objfile) <compunits_range>: New typedef.
13877         (compunits): New method.
13878         * objfiles.c (objfile_relocate1): Update.
13879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13880         * maint.c (count_symtabs_and_blocks): Update.
13881         * linespec.c (iterate_over_all_matching_symtabs): Update.
13882         * cp-support.c (add_symbol_overload_list_qualified): Update.
13883         * coffread.c (coff_symtab_read): Update.
13884         * ada-lang.c (add_nonlocal_symbols)
13885         (ada_collect_symbol_completion_matches)
13886         (ada_add_global_exceptions): Update.
13887
13888 2019-01-15  Tom Tromey  <tom@tromey.com>
13889
13890         * progspace.h (program_space) <objfiles_safe_range>: New
13891         typedef.
13892         <objfiles_safe>: New method.
13893         * objfiles.h (class all_objfiles_safe): Remove.
13894         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13895         * jit.c (jit_inferior_exit_hook): Update.
13896
13897 2019-01-17  Tom Tromey  <tom@tromey.com>
13898
13899         * progspace.h (program_space) <objfiles_range>: New typedef.
13900         <objfiles>: New method.
13901         <objfiles_head>: Rename from objfiles.
13902         (object_files): Update.
13903         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13904         * guile/scm-pretty-print.c
13905         (ppscm_find_pretty_printer_from_objfiles): Update.
13906         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13908         Update.
13909         * python/py-progspace.c (pspy_get_objfiles): Update.
13910         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13911         Update.
13912         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13913         (objfpy_lookup_objfile_by_build_id): Update.
13914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13915         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13916         Update.
13917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13918         (expand_symtab_containing_pc, lookup_objfile_from_block)
13919         (lookup_static_symbol, basic_lookup_transparent_type)
13920         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13921         (find_line_symtab, info_sources_command)
13922         (default_collect_symbol_completion_matches_break_on)
13923         (make_source_files_completion_list, find_main_name): Update.
13924         * symmisc.c (print_symbol_bcache_statistics)
13925         (print_objfile_statistics, maintenance_print_symbols)
13926         (maintenance_print_msymbols, maintenance_print_objfiles)
13927         (maintenance_info_symtabs, maintenance_check_symtabs)
13928         (maintenance_expand_symtabs, maintenance_info_line_tables):
13929         Update.
13930         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13931         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13932         (map_overlay_command, unmap_overlay_command)
13933         (simple_overlay_update, expand_symtabs_matching)
13934         (map_symbol_filenames): Update.
13935         * symfile-debug.c (set_debug_symfile): Update.
13936         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13937         Update.
13938         * source.c (select_source_symtab, forget_cached_source_info):
13939         Update.
13940         * solib.c (solib_read_symbols): Update.
13941         * solib-spu.c (append_ocl_sos): Update.
13942         * psymtab.c (maintenance_print_psymbols)
13943         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13944         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13945         * printcmd.c (info_symbol_command): Update.
13946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13947         Update.
13948         * objfiles.h (class all_objfiles): Remove.
13949         * objfiles.c (have_partial_symbols, have_full_symbols)
13950         (have_minimal_symbols, qsort_cmp, update_section_map)
13951         (shared_objfile_contains_address_p)
13952         (default_iterate_over_objfiles_in_search_order): Update.
13953         * objc-lang.c (info_selectors_command, info_classes_command)
13954         (find_methods): Update.
13955         * minsyms.c (find_solib_trampoline_target): Update.
13956         * maint.c (maintenance_info_sections)
13957         (maintenance_translate_address, count_symtabs_and_blocks):
13958         Update.
13959         * main.c (captured_main_1): Update.
13960         * linux-thread-db.c (try_thread_db_load_from_pdir)
13961         (has_libpthread): Update.
13962         * linespec.c (iterate_over_all_matching_symtabs)
13963         (search_minsyms_for_name): Update.
13964         * jit.c (jit_find_objf_with_entry_addr): Update.
13965         * hppa-tdep.c (find_unwind_entry)
13966         (hppa_lookup_stub_minimal_symbol): Update.
13967         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13968         Update.
13969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13970         (elf_gnu_ifunc_resolve_by_got): Update.
13971         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13972         * dwarf-index-write.c (save_gdb_index_command): Update.
13973         * cp-support.c (add_symbol_overload_list_qualified): Update.
13974         * breakpoint.c (create_overlay_event_breakpoint)
13975         (create_longjmp_master_breakpoint)
13976         (create_std_terminate_master_breakpoint)
13977         (create_exception_master_breakpoint): Update.
13978         * blockframe.c (find_pc_partial_function): Update.
13979         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13980         (ada_collect_symbol_completion_matches)
13981         (ada_add_global_exceptions): Update.
13982
13983 2019-01-17  Tom Tromey  <tom@tromey.com>
13984
13985         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13986         declare VEC.
13987         (solib_target_parse_libraries): Change return type.
13988         (library_list_start_segment, library_list_start_section)
13989         (library_list_end_library, library_list_start_library); Update.
13990         (solib_target_free_library_list): Remove.
13991         (solib_target_parse_libraries): Remove cleanup.  Change return
13992         type.
13993         (solib_target_current_sos): Update.
13994
13995 2019-01-17  Tom Tromey  <tromey@bapiya>
13996
13997         * valprint.c: Replace "the the" with "the".
13998         * symtab.c: Replace "the the" with "the".
13999         * solib.c: Replace "the the" with "the".
14000         * solib-dsbt.c: Replace "the the" with "the".
14001         * linespec.c: Replace "the the" with "the".
14002         * dwarf2loc.h: Replace "the the" with "the".
14003         * amd64-windows-tdep.c: Replace "the the" with "the".
14004         * aarch64-tdep.c: Replace "the the" with "the".
14005
14006 2019-01-16  Keith Seitz  <keiths@redhat.com>
14007
14008         PR gdb/23773
14009         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14010         <builder>: Rename to ..
14011         <m_builder>: ... this and make private.
14012         (dwarf2_cu::get_builder): New method.  Change all users of
14013         `builder' to use this method.
14014         (dwarf2_start_symtab): Move to ...
14015         (dwarf2_cu::start_symtab): ... here.  Update all callers
14016         (setup_type_unit_groups): Move to ...
14017         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14018         callers.
14019         (dwarf2_cu::reset_builder): New method.
14020         (process_full_compunit, process_full_type_unit): Use
14021         dwarf2_cu::reset_builder.
14022         (follow_die_offset): Record the ancestor CU if it is different
14023         from the followed DIE's CU.
14024         (follow_die_sig_1): Likewise.
14025
14026 2019-01-15  Tom Tromey  <tom@tromey.com>
14027
14028         * remote.c (class remote_state) <buf>: Now a char_vector.
14029         <buf_size>: Remove.
14030         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14031         parameter.
14032         (remote_target::getpkt_or_notif_sane_1)
14033         (remote_target::getpkt_sane)
14034         (remote_target::getpkt_or_notif_sane): Likewise.
14035         (class remote_target) <putpkt>: New overload.
14036         (remote_target::read_frame): Change type of "buf_p".  Remove
14037         sizeof_p parameter.
14038         (packet_ok): New overload.
14039         (packet_check_result): New overload.
14040         Update all uses.
14041
14042 2019-01-14  Tom Tromey  <tom@tromey.com>
14043
14044         * remote-notif.c (handle_notification, remote_notif_ack)
14045         (remote_notif_parse): Make "buf" const.
14046         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14047         const.
14048         (remote_notif_parse, remote_notif_ack, handle_notification):
14049         Likewise.
14050         * remote.c (remote_notif_stop_parse): Make "buf" const.
14051         (remote_target::remote_parse_stop_reply): Make "buf" const.
14052         (remote_notif_stop_ack): Make "buf" const.
14053
14054 2019-01-14  Tom Tromey  <tom@tromey.com>
14055
14056         * remote.c (remote_console_output): Make parameter const.
14057
14058 2019-01-14  Tom Tromey  <tom@tromey.com>
14059
14060         * target-debug.h (target_debug_print_signals): Constify.
14061         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14062         * procfs.c (procfs_target::pass_signals): Update.
14063         * linux-nat.c (linux_nat_target::pass_signals): Update.
14064         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14065         * target-delegates.c: Rebuild.
14066         * remote.c (remote_target::program_signals): Update.
14067         (remote_target::pass_signals): Update.
14068         * target.c (target_pass_signals): Constify argument.
14069         (target_program_signals): Likewise.
14070         * target.h (struct target_ops) <pass_signals, program_signals>:
14071         Constify argument.
14072         (target_pass_signals, target_program_signals): Constify argument.
14073
14074 2019-01-14  Tom Tromey  <tom@tromey.com>
14075
14076         PR tui/28819:
14077         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14078
14079 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14080
14081         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14082         field.
14083         * rs6000-tdep.c: Include reggroups.h.
14084         (IS_V_ALIAS_PSEUDOREG): Define.
14085         (rs6000_register_name): Return names for the "vX" aliases.
14086         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14087         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14088         aliases.  Call default_register_reggroup_p for all other
14089         pseudo-registers.
14090         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14091         New functions.
14092         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14093         Handle "vX" aliases.
14094         (v_alias_pseudo_register_collect): New function.
14095         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14096         (rs6000_gdbarch_init): Initialize "vX" aliases as
14097         pseudo-registers.  Restore registration of
14098         rs6000_pseudo_register_reggroup_p with
14099         set_tdesc_pseudo_register_reggroup_p.
14100
14101 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14102
14103         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14104         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14105         set_gdbarch_num_pseudo_regs.
14106
14107 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14108
14109         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14110         Remove arg prefixname, add do_set and do_show.
14111         Add member functions set_list and show_list.
14112         * cli/cli-style.c (class cli_style_option): Update accordingly.
14113         (style_set_list): Move to file scope.
14114         (style_show_list): Likewise.
14115         (set_style): Call help_list.
14116         (show_style): Call cmd_show_list.
14117         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14118         Update to use the new macro.
14119
14120 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14121
14122         * ada-lang.c (_initialize_ada_language): Expand the help text
14123         for the "catch exception" command.
14124
14125 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14126
14127         * symtab.c (matching_obj_sections): Initialize obj,
14128         declare it closer to its usage.
14129
14130 2019-01-10  Tom Tromey  <tom@tromey.com>
14131
14132         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14133         (basic_inf_threads_range): Remove.
14134         (inf_threads_range, inf_non_exited_threads_range)
14135         (safe_inf_threads_range): Use next_adapter.
14136
14137 2019-01-10  Keith Seitz  <keiths@redhat.com>
14138
14139         PR gdb/23712
14140         PR symtab/23010
14141         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14142         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14143
14144 2019-01-10  Keith Seitz  <keiths@redhat.com>
14145
14146         PR gdb/23712
14147         PR symtab/23010
14148         * dictionary.c (pending_to_vector): Remove.
14149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14150         Remove _1 suffix, replacing functions of the same name.  Update
14151         all callers.
14152         (dict_create_hashed, dict_create_hashed_expandable)
14153         (dict_create_linear, dict_create_linear_expandable, dict_free)
14154         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14155         Make functions static.
14156
14157 2019-01-10  Keith Seitz  <keiths@redhat.com>
14158
14159         PR gdb/23712
14160         PR symtab/23010
14161         * dictionary.h (struct dictionary): Replace declaration with
14162         multidictionary.
14163         (dict_create_hashed, dict_create_hashed_expandable)
14164         (dict_create_linear, dict_create_linear_expandable)
14165         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14166         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14167         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14168         taking multidictionary argument.
14169         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14170         * block.h (struct block) <dict>: Change to multidictionary
14171         and rename `multidict'.
14172         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14173         symmisc.c: Update all dictionary references to multidictionary.
14174
14175 2019-01-10  Keith Seitz  <keiths@redhat.com>
14176
14177         PR gdb/23712
14178         PR symtab/23010
14179         * dictionary.c: Include unordered_map.
14180         (pending_to_vector): New function.
14181         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14182         Rewrite the non-"_1" functions to take vector instead
14183         of linked list.
14184         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14185         "new" _1 versions of the same name.
14186         (multidictionary): Define.
14187         (std::hash<enum language): New definition.
14188         (collate_pending_symbols_by_language, mdict_create_hashed)
14189         (mdict_create_hashed_expandable, mdict_create_linear)
14190         (mdict_create_linear_expandable, mdict_free)
14191         (find_language_dictionary, create_new_language_dictionary)
14192         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14193         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14194         (mdict_size, mdict_empty): New functions.
14195         * dictionary.h (mdict_iterator): Define.
14196
14197 2019-01-10  Pedro Alves  <palves@redhat.com>
14198
14199         * breakpoint.c (read_uploaded_action)
14200         (create_tracepoint_from_upload): Adjust to use
14201         gdb::unique_xmalloc_ptr.
14202         * ctf.c (ctf_write_uploaded_tp):
14203         (SET_ARRAY_FIELD): Use emplace_back.
14204         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14205         * tracefile-tfile.c (tfile_write_uploaded_tp):
14206         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14207         gdb::unique_xmalloc_ptr.
14208         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14209         at_string, cond_string, cmd_strings>: Replace char pointers
14210         with gdb::unique_xmalloc_ptr.
14211
14212 2019-01-10  Pedro Alves  <palves@redhat.com>
14213
14214         * solib-target.c (library_list_start_library): Don't xstrdup name.
14215
14216 2019-01-10  Pedro Alves  <palves@redhat.com>
14217
14218         * mdebugread.c (parse_partial_symbols): Use
14219         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14220
14221 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14222
14223         * linux-fork.c (scoped_switch_fork_info)
14224         <~scoped_switch_fork_info>: Fix incorrect variable name.
14225
14226 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14227
14228         * linux-fork.c (scoped_switch_fork_info)
14229         <scoped_switch_fork_info>: Make explicit.
14230         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14231
14232 2019-01-10  Tom Tromey  <tom@tromey.com>
14233
14234         * objfiles.h (objfile::reset_psymtabs): Update.
14235         * objfiles.c (objfile::objfile): Update.
14236         * psymtab.h (psymtab_storage::obstack): Update.
14237         (psymtab_storage::m_obstack): Use gdb::optional.
14238         (class psymtab_storage): Update comment.  Remove objfile
14239         parameter.
14240         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14241
14242 2019-01-10  Tom Tromey  <tom@tromey.com>
14243
14244         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14245         <free_psymtabs>: Now private.
14246         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14247         (allocate_psymtab): Use new method.
14248
14249 2019-01-10  Tom Tromey  <tom@tromey.com>
14250
14251         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14252         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14253         * mdebugread.c (parse_partial_symbols): Use
14254         allocate_dependencies.
14255         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14256         allocate_dependencies.
14257         (process_psymtab_comp_unit_reader)
14258         (build_type_psymtab_dependencies): Likewise.
14259         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14260
14261 2019-01-10  Tom Tromey  <tom@tromey.com>
14262
14263         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14264         PSYMBOL_SET_LANGUAGE.
14265         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14266
14267 2019-01-10  Tom Tromey  <tom@tromey.com>
14268
14269         * psymtab.h (psymtab_storage::obstack): New method.
14270         <m_obstack>: Rename from obstack; now private.
14271         * psymtab.c (psymtab_storage): Update.
14272         * dwarf2read.c (create_addrmap_from_index)
14273         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14274         Update.
14275
14276 2019-01-10  Tom Tromey  <tom@tromey.com>
14277
14278         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14279         * objfiles.h (objfile::reset_psymtabs): New method.
14280
14281 2019-01-10  Tom Tromey  <tom@tromey.com>
14282
14283         * symmisc.c (print_symbol_bcache_statistics): Update.
14284         (print_objfile_statistics): Update.
14285         * symfile.c (reread_symbols): Update.
14286         * psymtab.h (class psymtab_storage): New.
14287         * psymtab.c (psymtab_storage): New constructor.
14288         (~psymtab_storage): New destructor.
14289         (require_partial_symbols): Update.
14290         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14291         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14292         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14293         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14294         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14295         (start_psymtab_common, end_psymtab_common)
14296         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14297         (allocate_psymtab): Update.
14298         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14299         Update.
14300         (dump_psymtab_addrmap, maintenance_print_psymbols)
14301         (maintenance_check_psymtabs): Update.
14302         (class objfile_psymtabs): Move to objfiles.h.
14303         * psympriv.h (discard_psymtab): Now inline.
14304         (psymtab_discarder::psymtab_discarder): Update.
14305         (psymtab_discarder::~psymtab_discarder): Update.
14306         (ALL_OBJFILE_PSYMTABS): Rewrite.
14307         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14308         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14309         Remove fields.
14310         <partial_symtabs>: New field.
14311         (class objfile_psymtabs): Move from psymtab.h.  Update.
14312         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14313         psymbol_cache.
14314         (objfile::~objfile): Don't destroy psymbol_cache.
14315         * mdebugread.c (parse_partial_symbols): Update.
14316         * dwarf2read.c (create_addrmap_from_index)
14317         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14318         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14319         (add_partial_subprogram, dwarf2_ranges_read): Update.
14320         * dwarf-index-write.c (write_address_map)
14321         (write_one_signatured_type, recursively_write_psymbols)
14322         (class debug_names, class debug_names, write_psymtabs_to_index):
14323         Update.
14324
14325 2019-01-10  Tom Tromey  <tom@tromey.com>
14326
14327         * symtab.h (SYMBOL_SET_NAMES): Update.
14328         (symbol_set_names): Update.
14329         (MSYMBOL_SET_NAMES): Update.
14330         * symtab.c (symbol_set_names): Change argument to be an
14331         objfile_per_bfd_storage.
14332         * psymtab.c (add_psymbol_to_bcache): Update.
14333         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14334
14335 2019-01-10  Tom Tromey  <tom@tromey.com>
14336
14337         * symtab.c (create_demangled_names_hash): Change argument to be an
14338         objfile_per_bfd_storage.
14339         (symbol_set_names): Update.
14340
14341 2019-01-10  Tom Tromey  <tom@tromey.com>
14342
14343         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14344         init_psymbol_list.
14345         * psymtab.c (init_psymbol_list): Do nothing if already called.
14346         * psympriv.h (init_psymbol_list): Add comment.
14347         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14348         init_psymbol_list.
14349         * dbxread.c (dbx_symfile_read): Unconditionally call
14350         init_psymbol_list.
14351
14352 2019-01-10  Tom Tromey  <tom@tromey.com>
14353
14354         * xcoffread.c (scan_xcoff_symtab): Update.
14355         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14356         "where".
14357         * mdebugread.c (parse_partial_symbols)
14358         (handle_psymbol_enumerators): Update.
14359         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14360         * dbxread.c (read_dbx_symtab): Update.
14361         * psympriv.h (psymbol_placement): New enum.
14362         (add_psymbol_to_list): Update.
14363
14364 2019-01-10  Tom Tromey  <tom@tromey.com>
14365
14366         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14367         static_psymbols parameters.
14368         (scan_xcoff_symtab): Update.
14369         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14370         static_psymbols parameters.
14371         * psympriv.h (start_psymtab_common): Update.
14372         * mdebugread.c (parse_partial_symbols): Update.
14373         * dwarf2read.c (create_partial_symtab): Update.
14374         * dbxread.c (read_dbx_symtab): Update.
14375         (start_psymtab): Remove global_psymbols and static_psymbols
14376         parameters.
14377
14378 2019-01-10  Tom Tromey  <tom@tromey.com>
14379
14380         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14381         * psymtab.c (allocate_psymtab): Add comment.
14382         * psympriv.h (allocate_psymtab): Add comment.
14383         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14384         initializations.
14385         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14386
14387 2019-01-10  Tom Tromey  <tom@tromey.com>
14388
14389         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14390         Don't declare.
14391         * mipsread.c: Include mdebugread.h.
14392         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14393         Declare.
14394         * elfread.c: Include mdebugread.h.
14395
14396 2019-01-09  Tom Tromey  <tom@tromey.com>
14397
14398         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14399         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14400         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14401         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14402         (psym_lookup_symbol, psym_find_last_source_symtab)
14403         (psym_forget_cached_source_info, psym_print_stats)
14404         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14405         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14406         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14407         (psym_find_compunit_symtab_by_address)
14408         (maintenance_print_psymbols, maintenance_info_psymtabs)
14409         (maintenance_check_psymtabs): Use ranged for.
14410         * psymtab.h (class objfile_psymtabs): New.
14411         (require_partial_symbols): Return objfile_psymtabs.
14412         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14413
14414 2019-01-09  Tom Tromey  <tom@tromey.com>
14415
14416         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14417         (find_pc_mapped_section, list_overlays_command)
14418         (map_overlay_command, unmap_overlay_command)
14419         (simple_overlay_update): Use all_objfiles.
14420         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14421         * printcmd.c (info_symbol_command): Use all_objfiles.
14422         * objfiles.h (ALL_OBJSECTIONS): Remove.
14423         * maint.c (maintenance_translate_address): Use all_objfiles.
14424         * gcore.c (gcore_create_callback): Use all_objfiles.
14425         (objfile_find_memory_regions): Likewise.
14426
14427 2019-01-09  Tom Tromey  <tom@tromey.com>
14428
14429         * symtab.c (find_line_symtab, info_sources_command)
14430         (make_source_files_completion_list): Use objfile_compunits.
14431         * source.c (select_source_symtab): Use objfile_compunits.
14432         * objfiles.h (struct objfile): Update comment.
14433         (ALL_OBJFILES): Remove.
14434         (ALL_FILETABS): Remove.
14435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14436         objfile_compunits.
14437
14438 2019-01-09  Tom Tromey  <tom@tromey.com>
14439
14440         * symmisc.c (print_objfile_statistics, dump_objfile)
14441         (maintenance_print_symbols): Use compunit_filetabs.
14442         * source.c (forget_cached_source_info_for_objfile): Use
14443         compunit_filetabs.
14444         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14445         (ALL_FILETABS): Use compunit_filetabs.
14446         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14447         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14448
14449 2019-01-09  Tom Tromey  <tom@tromey.com>
14450
14451         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14452         (compunit_filetabs): New.
14453         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14454         compunit_filetabs.
14455         (info_sources_command, make_source_files_completion_list): Remove
14456         declaration.
14457         * symmisc.c (print_objfile_statistics, dump_objfile)
14458         (maintenance_print_symbols): Remove declaration.
14459         (maintenance_info_symtabs): Use compunit_filetabs.
14460         (maintenance_info_line_tables): Likewise.
14461         * source.c (select_source_symtab): Change local variable name.
14462         (forget_cached_source_info_for_objfile): Remove declaration.
14463         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14464         * objfiles.c (objfile_relocate1): Remove declaration.
14465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14466         declaration.
14467         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14468         * coffread.c (coff_symtab_read): Remove declaration.
14469         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14470         compunit_filetabs.
14471
14472 2019-01-09  Tom Tromey  <tom@tromey.com>
14473
14474         * symtab.c (lookup_objfile_from_block)
14475         (find_pc_sect_compunit_symtab, search_symbols)
14476         (default_collect_symbol_completion_matches_break_on): Use
14477         objfile_compunits.
14478         * objfiles.h (ALL_COMPUNITS): Remove.
14479         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14480         * cp-support.c (add_symbol_overload_list_qualified): Use
14481         objfile_compunits.
14482         * ada-lang.c (ada_collect_symbol_completion_matches)
14483         (ada_add_global_exceptions): Use objfile_compunits.
14484
14485 2019-01-09  Tom Tromey  <tom@tromey.com>
14486
14487         * source.c (select_source_symtab)
14488         (forget_cached_source_info_for_objfile): Remove declaration.
14489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14490         declaration.
14491         * maint.c (count_symtabs_and_blocks): Remove declaration.
14492         * cp-support.c (add_symbol_overload_list_qualified): Remove
14493         declaration.
14494         * coffread.c (coff_symtab_read): Remove declaration.
14495         * symtab.c (lookup_symbol_in_objfile_symtabs)
14496         (basic_lookup_transparent_type_1): Use objfile_compunits.
14497         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14498         (info_sources_command, search_symbols)
14499         (default_collect_symbol_completion_matches_break_on)
14500         (make_source_files_completion_list): Remove declaration.
14501         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14502         (ada_collect_symbol_completion_matches)
14503         (ada_add_global_exceptions): Remove declaration.
14504         * linespec.c (iterate_over_all_matching_symtabs): Use
14505         objfile_compunits.
14506         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14507         (class objfile_compunits): New.
14508         (ALL_COMPUNITS): Use objfile_compunits.
14509         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14510         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14511         objfile_compunits.
14512         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14513
14514 2019-01-09  Tom Tromey  <tom@tromey.com>
14515
14516         * symtab.c (search_symbols)
14517         (default_collect_symbol_completion_matches_break_on): Use
14518         objfile_msymbols.
14519         * ada-lang.c (ada_lookup_simple_minsym)
14520         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14521         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14523         objfile_msymbols.
14524         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14525         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14526         * objc-lang.c (find_methods): Use objfile_msymbols.
14527         (info_selectors_command, info_classes_command): Likewise.
14528         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14529         * objfiles.h (class objfile_msymbols): New.
14530         (ALL_OBJFILE_MSYMBOLS): Remove.
14531         (ALL_MSYMBOLS): Remove.
14532
14533 2019-01-09  Tom Tromey  <tom@tromey.com>
14534
14535         * common/next-iterator.h (next_adapter): Add Iterator template
14536         parameter.
14537         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14538         (class all_objfiles_safe): New.
14539         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14540         * objfiles.c (put_objfile_before): Update comment.
14541         (add_separate_debug_objfile): Likewise.
14542         (free_all_objfiles): Use all_objfiles_safe.
14543         (objfile_purge_solibs): Likewise.
14544
14545 2019-01-09  Tom Tromey  <tom@tromey.com>
14546
14547         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14548         (expand_symtab_containing_pc, lookup_static_symbol)
14549         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14550         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14551         all_objfiles.
14552         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14553         * breakpoint.c (create_overlay_event_breakpoint)
14554         (create_longjmp_master_breakpoint)
14555         (create_std_terminate_master_breakpoint)
14556         (create_exception_master_breakpoint): Use all_objfiles.
14557         * linux-thread-db.c (try_thread_db_load_from_pdir)
14558         (has_libpthread): Use all_objfiles.
14559         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14560         * linespec.c (iterate_over_all_matching_symtabs)
14561         (search_minsyms_for_name): Use all_objfiles.
14562         * maint.c (maintenance_info_sections): Use all_objfiles.
14563         * main.c (captured_main_1): Use all_objfiles.
14564         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14565         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14566         * guile/scm-pretty-print.c
14567         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14568         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14569         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14570         (maintenance_print_msymbols): Use all_objfiles.
14571         * source.c (select_source_symtab): Use all_objfiles.
14572         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14573         * symfile.c (remove_symbol_file_command)
14574         (expand_symtabs_matching, map_symbol_filenames): Use
14575         all_objfiles.
14576         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14577         all_objfiles.
14578         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14579         * objc-lang.c (find_methods): Use all_objfiles.
14580         * objfiles.c (have_partial_symbols, have_full_symbols)
14581         (have_minimal_symbols, qsort_cmp)
14582         (default_iterate_over_objfiles_in_search_order): Use
14583         all_objfiles.
14584         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14585         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14586         (maintenance_check_psymtabs): Use all_objfiles.
14587         (ALL_PSYMTABS): Remove.
14588         * compile/compile-object-run.c (do_module_cleanup): Use
14589         all_objfiles.
14590         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14591         * cp-support.c (add_symbol_overload_list_qualified): Use
14592         all_objfiles.
14593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14594         Use all_objfiles.
14595         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14596         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14597         all_objfiles.
14598         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14599         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14600         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14601         Uses all_objfiles.
14602         * solib.c (solib_read_symbols): Use all_objfiles
14603
14604 2019-01-09  Tom Tromey  <tom@tromey.com>
14605
14606         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14607         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14608         all_objfiles.
14609         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14610         * symmisc.c (print_symbol_bcache_statistics)
14611         (print_objfile_statistics, maintenance_print_objfiles)
14612         (maintenance_info_symtabs, maintenance_check_symtabs)
14613         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14614         all_objfiles.
14615         * source.c (forget_cached_source_info): Use all_objfiles.
14616         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14617         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14618         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14619         * objfiles.c (update_section_map): Use all_objfiles.
14620         (shared_objfile_contains_address_p): Likewise.
14621         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14622         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14623
14624 2019-01-09  Tom Tromey  <tom@tromey.com>
14625
14626         * common/next-iterator.h: New file.
14627         * objfiles.h (class all_objfiles): New.
14628         (struct objfile_iterator): New.
14629
14630 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14631
14632         * NEWS: Move the description of the changed "frame", "select-frame",
14633          and "info frame" commands to the Changed commands section.
14634
14635 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14636
14637         * gdbtypes.c (check_stub_method_group): Remove handling of old
14638         mangling schemes.
14639         * linespec.c (find_methods): Likewise.
14640         * stabsread.c (read_member_functions): Likewise.
14641         * valops.c (search_struct_method): Likewise.
14642         (value_struct_elt_for_reference): Likewise.
14643         * NEWS: Mention this change.
14644
14645 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14646
14647         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14648         print_source_lines.
14649         * source.c (print_source_lines_base): Update line number check.
14650         (print_source_lines): New function.
14651         (source_lines_range::source_lines_range): New function.
14652         * source.h (class source_lines_range): New class.
14653         (print_source_lines): New declaration.
14654
14655 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14656
14657         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14658
14659 2019-01-08  Tom Tromey  <tom@tromey.com>
14660             Simon Marchi  <simon.marchi@ericsson.com>
14661
14662         PR gdb/24060
14663         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14664         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14665         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14666         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14667         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14668         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14669
14670 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14671
14672         * source.c (select_source_symtab): Move header comment to
14673         declaration in source.h.
14674         (forget_cached_source_info_for_objfile): Likewise.
14675         (forget_cached_source_info): Likewise.
14676         (identify_source_line): Likewise.
14677         * source.h (identify_source_line): Move declaration from symtab.h
14678         and add comment from source.c
14679         (print_source_lines): Likewise.
14680         (forget_cached_source_info_for_objfile): Likewise.
14681         (forget_cached_source_info): Likewise.
14682         (select_source_symtab): Likewise.
14683         (enum print_source_lines_flag): Move definition from symtab.h.
14684         * symtab.h (identify_source_line): Move declaration to source.h.
14685         (print_source_lines): Likewise.
14686         (forget_cached_source_info_for_objfile): Likewise.
14687         (forget_cached_source_info): Likewise.
14688         (select_source_symtab): Likewise.
14689         (enum print_source_lines_flag): Move definition to source.h.
14690         * tui/tui-hooks.c: Add 'source.h' include.
14691
14692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14693
14694         * source.c (print_source_lines_base): Handle requests to print
14695         reverse line number sequences, and guard against empty lines
14696         string.
14697
14698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14699
14700         * source.c (print_source_lines_base): Fix skip of '\r' if next
14701         character is '\n'.
14702
14703 2019-01-06  Tom Tromey  <tom@tromey.com>
14704
14705         * c-exp.y (struct c_parse_state) <macro_original_text,
14706         expansion_obstack>: New member.
14707         (macro_original_text, expansion_obstack): Remove globals.
14708         (scan_macro_expansion, scanning_macro_expansion)
14709         (finished_macro_expansion): Update.
14710         (scan_macro_cleanup): Remove.
14711         (yylex, c_parse): Update.
14712
14713 2019-01-06  Tom Tromey  <tom@tromey.com>
14714
14715         * c-exp.y (struct c_parse_state) <strings>: New member.
14716         (operator_stoken): Update.
14717
14718 2019-01-06  Tom Tromey  <tom@tromey.com>
14719
14720         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14721         (union type_stack_elt) <typelist_val>: Now a pointer to
14722         std::vector.
14723         (type_stack_cleanup): Don't declare.
14724         (push_typelist): Update.
14725         * parse.c (pop_typelist): Return a std::vector.
14726         (push_typelist): Take a std::vector.
14727         (follow_types): Update.  Do not free args.
14728         (type_stack_cleanup): Remove.
14729         * c-exp.y (struct c_parse_state): New.
14730         (cpstate): New global.
14731         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14732         (nonempty_typelist): Update.
14733         (func_mod): Create a new vector.
14734         (c_parse): Create a c_parse_state.
14735         (check_parameter_typelist): Do not delete params.
14736         (function_method): Update.  Do not delete type_list.
14737
14738 2019-01-06  Tom Tromey  <tom@tromey.com>
14739
14740         PR gdb/28155:
14741         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14742         check_typedef.
14743         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14744         (print_return_value): Likewise.
14745
14746 2019-01-05  Tom Tromey  <tom@tromey.com>
14747
14748         * contrib/cleanup_check.py: Remove.
14749         * contrib/gcc-with-excheck: Remove.
14750         * contrib/exsummary.py: Remove.
14751         * contrib/excheck.py: Remove.
14752
14753 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14754
14755         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14756         NULL. Initialize tpprev to NULL instead of assigning it
14757         to NULL on the next statement.
14758         * windows-nat.c (windows_delete_thread): Remove check for
14759         main_thread_id before printing thread exit notifications.
14760         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14761         Remove thread ID check against main_thread_id.
14762         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14763         windows_delete_thread.
14764         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14765
14766 2019-01-04  Tom Tromey  <tom@tromey.com>
14767
14768         * compile/compile.c (_initialize_compile): Use upper case for
14769         metasyntactic variables.
14770         * symmisc.c (_initialize_symmisc): Use upper case for
14771         metasyntactic variables.
14772         * psymtab.c (_initialize_psymtab): Use upper case for
14773         metasyntactic variables.
14774         * demangle.c (demangle_command): Use upper case for metasyntactic
14775         variables.
14776         (_initialize_demangler): Likewise.
14777         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14778         variables.
14779
14780 2019-01-03  Tom Tromey  <tom@tromey.com>
14781
14782         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14783
14784 2019-01-03  Tom Tromey  <tom@tromey.com>
14785
14786         * python/py-symtab.c (salpy_str): Update.
14787         (struct salpy_sal_object) <symtab>: Now a PyObject.
14788         (salpy_dealloc): Update.
14789         (del_objfile_sal): Use gdbpy_ref.
14790
14791 2019-01-03  Tom Tromey  <tom@tromey.com>
14792
14793         * python/py-type.c (convert_field): Use new_reference.  Return
14794         gdbpy_ref.
14795         (make_fielditem): Return gdbpy_ref.
14796         (typy_fields): Update.
14797         (typy_getitem): Update.
14798         (field_name): Return gdbpy_ref.  Use new_reference.
14799         (typy_iterator_iternext): Update.
14800
14801 2019-01-03  Tom Tromey  <tom@tromey.com>
14802
14803         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14804
14805 2019-01-03  Tom Tromey  <tom@tromey.com>
14806
14807         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14808         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14809         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14810         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14811         (pspy_set_type_printers): Likewise.
14812         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14813         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14814         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14815         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14816         (objfpy_set_type_printers): Likewise.
14817
14818 2019-01-03  Tom Tromey  <tom@tromey.com>
14819
14820         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14821         (gdbpy_print_stack): Use gdbpy_err_fetch.
14822         * python/python-internal.h (class gdbpy_err_fetch): New class.
14823         (class gdbpy_enter) <m_error_type, m_error_value,
14824         m_error_traceback>: Remove.
14825         <m_error>: New member.
14826         (gdbpy_exception_to_string): Don't declare.
14827         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14828         * python/py-value.c (convert_value_from_python): Use
14829         gdbpy_err_fetch.
14830         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14831         gdbpy_exception_to_string.
14832         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14833         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14834         gdbpy_err_fetch.
14835
14836 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14837
14838         * linux-nat.c (delete_lwp_cleanup): Delete.
14839         (struct lwp_deleter): New struct.
14840         (lwp_info_up): New typedef.
14841         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14842         lwp_info_up.
14843
14844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14845
14846         * linux-fork.c (class scoped_switch_fork_info): New class.
14847         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14848
14849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14850
14851         * valops.c (find_overload_match): Remove use of null_cleanup, and
14852         calls to do_cleanups.
14853
14854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14855
14856         * compile/compile-cplus-types.c
14857         (compile_cplus_instance::decl_name): Handle changes to
14858         cp_func_name.
14859         * cp-support.c (cp_func_name): Update header comment, update
14860         return type.
14861         * cp-support.h (cp_func_name): Update return type in declaration.
14862         * valops.c (find_overload_match): Move temp_func local to top
14863         level of function and change its type.  Use temp_func to hold and
14864         delete temporary string obtained from cp_func_name.
14865
14866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14867
14868         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14869         gdb::char_vector, remove cleanup, and update uses of `msg`.
14870
14871 2019-01-03  Jim Wilson  <jimw@sifive.com>
14872
14873         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14874
14875 2019-01-02  Tom Tromey  <tom@tromey.com>
14876
14877         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14878         (tdesc_parse_xml): Remove cleanups.
14879         * target-descriptions.h (make_cleanup_free_target_description):
14880         Don't declare.
14881         (target_desc_deleter): New struct.
14882         (target_desc_up): New typedef.
14883         * target-descriptions.c (target_desc_deleter::operator()): Rename
14884         from free_target_description.
14885         (make_cleanup_free_target_description): Remove.
14886
14887 2019-01-02  Tom Tromey  <tom@tromey.com>
14888
14889         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14890         constructor, destructor.
14891         (linespec_parser): Remove typedef.
14892         (~linespec_parser): Rename from linespec_parser_delete.
14893         (linespec_lex_to_end, linespec_complete_label)
14894         (linespec_complete): Update.
14895         (decode_line_full): Remove cleanups.
14896         (decode_line_1): Update.
14897
14898 2019-01-02  Tom Tromey  <tom@tromey.com>
14899
14900         * python/python-internal.h (inferior_to_inferior_object): Change
14901         return type.
14902         * python/py-exitedevent.c (create_exited_event_object): Update.
14903         * python/py-inferior.c (inferior_to_inferior_object): Return
14904         gdbpy_ref.
14905         (python_new_inferior, python_inferior_deleted)
14906         (thread_to_thread_object, delete_thread_object)
14907         (build_inferior_list, gdbpy_selected_inferior): Update.
14908         * python/py-infthread.c (create_thread_object): Update.  Also fail
14909         if inferior_to_inferior_object fails.
14910
14911 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14912
14913         * inferior.h (class inferior) <displaced_step_state>: New field.
14914         * infrun.h (struct displaced_step_state): Move here from
14915         infrun.c.  Initialize fields, add constructor.
14916         <inf>: Remove field.
14917         <reset>: New method.
14918         * infrun.c (struct displaced_step_inferior_state): Move to
14919         infrun.h.
14920         (displaced_step_inferior_states): Remove.
14921         (get_displaced_stepping_state): Adust.
14922         (displaced_step_in_progress_any_inferior): Adjust.
14923         (displaced_step_in_progress_thread): Adjust.
14924         (displaced_step_in_progress): Adjust.
14925         (add_displaced_stepping_state): Remove.
14926         (get_displaced_step_closure_by_addr): Adjust.
14927         (remove_displaced_stepping_state): Remove.
14928         (infrun_inferior_exit): Call displaced_step_state.reset.
14929         (use_displaced_stepping): Don't check for NULL.
14930         (displaced_step_prepare_throw): Call
14931         get_displaced_stepping_state.
14932         (displaced_step_fixup): Don't check for NULL.
14933         (prepare_for_detach): Don't check for NULL.
14934
14935 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14936
14937         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14938          in case of call that did not complete.
14939
14940 2019-01-02  Andrey Utkin  <autkin@undo.io>
14941
14942         * symfile.c (find_separate_debug_file): Fix search of debug files for
14943         remote debuggee.
14944
14945 2019-01-02  Tom Tromey  <tom@tromey.com>
14946
14947         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14948         indentation.
14949         * python/py-frame.c (frapy_older): Remove cast.
14950         (frapy_newer): Likewise.
14951         * python/py-breakpoint.c (local_setattro): Remove cast.
14952         * python/py-arch.c (archpy_name): Remove local variable.
14953         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14954
14955 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14956
14957         * unittests/basic_string_view/element_access/char/empty.cc:
14958         Fix year range in copyright header.
14959
14960 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14961
14962         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14963         Delete.
14964         <operator==>: Update with for removed field.
14965         <hash>: Likewise.
14966         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14967         <isa_features>: ...this.
14968         <abi_features>: New field.
14969         (riscv_isa_flen): Update comment.
14970         (riscv_abi_xlen): New declaration.
14971         (riscv_abi_flen): New declaration.
14972         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14973         isa_features.
14974         (riscv_abi_xlen): New function.
14975         (riscv_isa_flen): Update to get answer from isa_features.
14976         (riscv_abi_flen): New function.
14977         (riscv_has_fp_abi): Update to get answer from abi_features.
14978         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14979         xlen and flen.
14980         (riscv_call_info) <xlen, flen>: Update comment.
14981         (riscv_call_arg_struct): Remove invalid assertions
14982         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14983         is removed.
14984         (riscv_gdbarch_init): Gather isa features and abi features
14985         separately, ensure both match on the gdbarch when reusing an old
14986         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14987         a target with 64-bit float hardware.
14988
14989 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14990
14991         * source.c (search_command_helper): Stop reverse search
14992         when line 1 has been searched.
14993
14994 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14995
14996         * record-full.c (record_full_base_target::close): Rewrite
14997         record_full_core_buf_list free logic.
14998
14999 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15000
15001         * break-catch-syscall.c (print_one_catch_syscall): xfree
15002         the last text.
15003
15004 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15005
15006         * top.c (print_gdb_version): Update Copyright year in version
15007         message.
15008
15009 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15010
15011         Update copyright year range in all GDB files.
15012
15013 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15014
15015         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15016
15017 For older changes see ChangeLog-2018.
15018 \f
15019 Local Variables:
15020 mode: change-log
15021 left-margin: 8
15022 fill-column: 74
15023 version-control: never
15024 coding: utf-8
15025 End:
15026