gdb/ChangeLog

   1 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
   4         *slot_ptr.
   5
   6 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
   7
   8         * configure.ac: Don't check for 'dlfcn.h' (moved to
   9         gdbsupport/common.m4).
  10         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
  11         'gdbsupport/'.
  12         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
  13         * compile/compile-c-support.c: Include
  14         'gdbsupport/gdb-dlfcn.h'.
  15         * gdbsupport/common.m4: Check for 'dlfcn.h'.
  16         * gdb-dlfcn.c: Move to...
  17         * gdbsupport/gdb-dlfcn.c: ... here.
  18         * gdb-dlfcn.h: Move to...
  19         * gdbsupport/gdb-dlfcn.h: ... here.
  20
  21 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
  22
  23         * nios2-tdep.c (struct reg_value): Improve comments.  Make
  24         the offset field signed.
  25
  26 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * python/lib/gdb/__init__.py (_execute_file): New function.
  29         * python/python.c (python_run_simple_file): Call gdb._execute_file
  30         on Windows.
  31
  32 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  33
  34         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
  35         all uses as this was never set to anything but a zero value.
  36
  37 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
  38
  39         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
  40
  41 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
  42
  43         * tui/tui-data.h (tui_gen_win_info): Add an =default
  44         move constructor, required by some GCC versions.
  45
  46 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  47
  48         * go32-nat.c (go32_sysinfo): Add hygon_p.
  49
  50 2019-08-20  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  53         line_from_reg_element_no, first_reg_element_no_inline,
  54         display_all_data, delete_data_content_windows,
  55         erase_data_content>: Now private.
  56
  57 2019-08-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  60         (tui_unhighlight_win, tui_highlight_win)
  61         (tui_win_info::make_window): Update.
  62         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  63
  64 2019-08-20  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  67         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  68         (MAX_PID_WIDTH): Move to tui-stack.c.
  69         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  70         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  71         (MAX_PID_WIDTH): Move from tui-data.h.
  72
  73 2019-08-20  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  76         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  77         (box_win): Update.
  78         (tui_gen_win_info::make_window): Rename from tui_make_window.
  79         (tui_win_info::make_window): New method.
  80         (tui_gen_win_info::make_visible): Update.
  81         * tui/tui-source.c (tui_source_window::set_contents): Update.
  82         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  83         (tui_data_window::display_registers_from): Update.
  84         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  85         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  86         Declare.
  87         <can_box>: Remove.
  88         <title>: Remove.
  89         (struct tui_win_info) <make_window>: Declare.
  90         <can_box>: Now virtual.
  91         <title>: New member.
  92         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  93         * tui/tui-command.c (tui_cmd_window::resize): Update.
  94
  95 2019-08-20  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  98         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  99         (tui_data_window::check_register_values): Update.
 100
 101 2019-08-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-regs.h (struct tui_data_window): Use
 104         DISABLE_COPY_AND_ASSIGN.
 105         <regs_content>: Change type, removing unique_ptr.
 106         <tui_data_window>: Add move constructor.
 107         * tui/tui-regs.c (tui_data_window::show_registers)
 108         (tui_data_window::show_register_group)
 109         (tui_data_window::display_registers_from)
 110         (tui_data_window::display_registers_from)
 111         (tui_data_window::first_data_item_displayed)
 112         (tui_data_window::delete_data_content_windows)
 113         (tui_data_window::rerender, tui_data_window::refresh_window)
 114         (tui_data_window::check_register_values): Update.
 115
 116 2019-08-20  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 119         show_register_group>: Declare.
 120         (tui_show_register_group): Don't declare.
 121         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 122         tui_show_registers.
 123         (tui_data_window::show_register_group): Rename from
 124         tui_show_register_group.
 125         (tui_data_window::check_register_values, tui_reg_command):
 126         Update.
 127         * tui/tui-layout.c (tui_set_layout): Update.
 128
 129 2019-08-20  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 132         Declare.
 133         (tui_check_register_values): Don't declare.
 134         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 135         from tui_check_register_values.
 136         * tui/tui-hooks.c (tui_register_changed): Update.
 137
 138 2019-08-20  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-regs.c (tui_reg_layout): Move later.
 141         (tui_show_registers): Don't enable TUI mode or change layout.
 142
 143 2019-08-20  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-regs.h (struct tui_data_item_window)
 146         <~tui_data_item_window>: Remove.
 147         <content>: Now a unique_xmalloc_ptr.
 148         * tui/tui-regs.c (tui_register_format): Return a
 149         unique_xmalloc_ptr.
 150         (tui_get_register): Update.
 151         (~tui_data_item_window): Remove.
 152         (tui_data_window::display_registers_from, tui_display_register):
 153         Update.
 154         * tui/tui-io.h (tui_expand_tabs): Update.
 155         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 156         Remove "col" parameter.
 157
 158 2019-08-20  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 161         field.
 162         * tui/tui-regs.c (~tui_data_item_window): Update.
 163
 164 2019-08-20  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 167         earlier.
 168
 169 2019-08-20  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 172
 173 2019-08-20  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-source.h (struct tui_source_window): Update.
 176         * tui/tui-regs.c (tui_show_registers): Update.
 177         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 178         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 179         (NO_REGS_STRING): Remove defines.
 180
 181 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 182
 183         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 184         unnecessary thread walk if remote doesn't support the packet.
 185
 186 2019-08-19  Tom Tromey  <tromey@adacore.com>
 187
 188         * python/py-value.c (value_has_field): Fix indentation.
 189
 190 2019-08-19  Tom Tromey  <tromey@adacore.com>
 191
 192         * printcmd.c (do_one_display, info_display_command): Update.
 193         * block.h (contained_in): Return bool.  Add allow_nested
 194         parameter.
 195         * block.c (contained_in): Return bool.  Add allow_nested
 196         parameter.
 197
 198 2019-08-19  Tom Tromey  <tom@tromey.com>
 199
 200         * configure: Rebuild.
 201         * configure.ac: Disallow the combination of -static-libstdc++ and
 202         source highlight.
 203         * source-cache.c (get_language_name): Handle rust.
 204         (source_cache::get_source_lines): Ignore highlighting exceptions.
 205
 206 2019-08-16  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 209         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 210         (struct tui_source_window_base) <make_visible, refresh_window,
 211         resize>: Remove methods.
 212         <execution_info>: Remove field.
 213         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 214         (tui_show_source_line, tui_source_window_base)
 215         (~tui_source_window_base): Update.
 216         (tui_source_window_base::resize)
 217         (tui_source_window_base::make_visible)
 218         (tui_source_window_base::refresh_window): Remove.
 219         (tui_source_window_base::update_exec_info): Update.
 220         * tui/tui-source.c (tui_source_window::set_contents): Update.
 221         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 222
 223 2019-08-16  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 226         deprecated_query_hook.
 227
 228 2019-08-16  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 231         (tui_update_source_windows_with_line): Update.
 232         * tui/tui-source.h (struct tui_source_window)
 233         <show_symtab_source>: Declare.
 234         (tui_show_symtab_source): Don't declare.
 235         * tui/tui-source.c (tui_show_symtab_source): Rename from
 236         tui_show_symtab_source.
 237
 238 2019-08-16  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-winsource.h (struct tui_source_window_base)
 241         <set_contents>: Declare.
 242         * tui/tui-winsource.c
 243         (tui_source_window_base::update_source_window_as_is): Update.
 244         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 245         Declare.
 246         (tui_set_source_content): Don't declare.
 247         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 248         tui_set_source_content.
 249         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 250         Declare.
 251         (tui_set_disassem_content): Don't declare.
 252         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 253         tui_set_disassem_content.
 254
 255 2019-08-16  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-winsource.h (struct tui_source_window_base)
 258         <update_breakpoint_info>: Declare.
 259         (tui_update_breakpoint_info): Don't declare.
 260         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 261         (tui_update_all_breakpoint_info): Update.
 262         (tui_source_window_base::update_breakpoint_info): Rename from
 263         tui_update_breakpoint_info.
 264         (tui_source_window_base::update_exec_info): Update.
 265
 266 2019-08-16  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-winsource.h (struct tui_source_window_base)
 269         <update_source_window>: Declare.
 270         (tui_update_source_window): Don't declare.
 271         * tui/tui-winsource.c
 272         (tui_source_window_base::update_source_window): Rename from
 273         tui_update_source_window.
 274         (tui_source_window_base::rerender): Update.
 275         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 276         * tui/tui-disasm.c (tui_show_disassem)
 277         (tui_show_disassem_and_update_source)
 278         (tui_disasm_window::maybe_update): Update.
 279
 280 2019-08-16  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-winsource.h (struct tui_source_window_base)
 283         <update_source_window_as_is>: Declare.
 284         (tui_update_source_window_as_is): Don't declare.
 285         * tui/tui-winsource.c (tui_update_source_window): Update
 286         (tui_source_window_base::update_source_window_as_is): Rename from
 287         tui_update_source_window_as_is.
 288         (tui_source_window_base::refill): Update.
 289         * tui/tui-source.c (tui_show_symtab_source): Update.
 290         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 291         Update.
 292
 293 2019-08-16  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-winsource.h (tui_update_source_window)
 296         (tui_update_source_window_as_is): Remove "noerror" parameter.
 297         * tui/tui-winsource.c (tui_update_source_window)
 298         (tui_update_source_window_as_is): Remove "noerror" parameter.
 299         (tui_update_source_windows_with_addr)
 300         (tui_update_source_windows_with_line)
 301         (tui_source_window_base::rerender)
 302         (tui_source_window_base::refill): Update.
 303         * tui/tui-source.h (tui_set_source_content)
 304         (tui_show_symtab_source): Remove "noerror" parameter.
 305         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 306         parameter.
 307         (tui_show_symtab_source): Likewise.
 308         (tui_source_window::maybe_update): Update.
 309         * tui/tui-disasm.c (tui_show_disassem)
 310         (tui_show_disassem_and_update_source)
 311         (tui_disasm_window::do_scroll_vertical)
 312         (tui_disasm_window::maybe_update): Update.
 313
 314 2019-08-16  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui.c (tui_is_window_visible): Update.
 317         * tui/tui-wingeneral.c (tui_make_window)
 318         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 319         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 320         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 321         (tui_set_win_height_command, parse_scrolling_args): Update.
 322         * tui/tui-source.c (tui_source_window::style_changed): Update.
 323         * tui/tui-regs.c (tui_show_registers)
 324         (tui_data_window::first_data_item_displayed)
 325         (tui_data_window::delete_data_content_windows)
 326         (tui_check_register_values, tui_reg_command): Update.
 327         * tui/tui-disasm.c (tui_show_disassem): Update.
 328         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 329         method.
 330         <is_visible>: Remove field.
 331         * tui/tui-data.c (tui_next_win, tui_prev_win)
 332         (tui_delete_invisible_windows): Update.
 333
 334 2019-08-16  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (struct tui_source_window_base)
 337         <m_has_locator>: Remove.
 338         * tui/tui-layout.c (show_source_disasm_command, show_data)
 339         (show_source_or_disasm_and_command): Update.
 340
 341 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * NEWS (Other MI changes): New subsection.
 344         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 345         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 346         * arch-utils.c (default_get_pc_address_flags): New function.
 347         * arch-utils.h (default_get_pc_address_flags): New declaration.
 348         * gdbarch.sh: Add get_pc_address_flags.
 349         * gdbarch.c: Regenerate.
 350         * gdbarch.h: Likewise.
 351         * stack.c (print_pc): New function.
 352         (print_frame_info) (print_frame): Call print_pc.
 353
 354 2019-08-16  Tom de Vries  <tdevries@suse.de>
 355
 356         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 357         print_objfile_section_info.
 358
 359 2019-08-15  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 362         calling update_cmdwin_start_line.
 363         * tui/tui-winsource.h (struct tui_source_window_base)
 364         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 365         <rerender>: Declare.
 366         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 367         Call rerender.
 368         (tui_source_window_base::set_new_height): Remove.
 369         (tui_source_window_base::rerender): Rename from
 370         do_make_visible_with_new_height.
 371         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 372         resize method.
 373         (tui_win_info::make_invisible_and_set_new_height)
 374         (tui_win_info::make_visible_with_new_height): Remove.
 375         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 376         Declare.
 377         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 378         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 379         do_make_visible_with_new_height>: Don't declare.
 380         <rerender>: Declare.
 381         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 382         set_new_height.
 383         (tui_data_window::do_make_visible_with_new_height): Remove.
 384         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 385         call tui_show_locator_content.
 386         (tui_gen_win_info::resize): Call rerender.
 387         (show_source_or_disasm_and_command): Don't call
 388         tui_show_locator_content.
 389         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 390         method.
 391         (struct tui_win_info) <rerender>: Declare.
 392         <set_new_height, make_invisible_and_set_new_height,
 393         make_visible_with_new_height>: Don't declare.
 394         * tui/tui-data.c (tui_win_list::rerender): New method.
 395         * tui/tui-command.h (struct tui_cmd_window)
 396         <do_make_visible_with_new_height>: Don't declare.
 397         * tui/tui-command.c
 398         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 399
 400 2019-08-15  Tom Tromey  <tromey@adacore.com>
 401
 402         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 403         * ada-lang.c (ada_enum_name): Likewise.
 404
 405 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 408         leading underscore.
 409         (GdbOutputErrorFile): Likewise.
 410         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 411         accordingly.
 412         (execute_unwinders): Rename to have a leading underscore.
 413         (auto_load_packages): Likewise.
 414         (global scope): Adjust call to auto_load_packages accordingly.
 415         (GdbSetPythonDirectory): Likewise.
 416         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 417         instead of execute_unwinders.
 418
 419 2019-08-15  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 422         (show_data): Don't change window visibility.
 423         (tui_gen_win_info::resize): Remove special case for command
 424         window.  Use wresize, when available.
 425         (show_source_or_disasm_and_command): Don't change window
 426         visibility.
 427         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 428         <make_visible>: New method.
 429         * tui/tui-command.c (tui_cmd_window::resize): New method.
 430
 431 2019-08-15  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 434         (struct tui_source_windows): New.
 435         * tui/tui-winsource.c (tui_display_main): Update.
 436         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 437         (new_height_ok, parse_scrolling_args): Update.
 438         * tui/tui-layout.c (show_layout, show_data): Update.
 439         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 440         (tui_add_to_source_windows): Don't declare.
 441         * tui/tui-data.c (source_windows, tui_source_windows)
 442         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 443
 444 2019-08-15  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 447         Rename from reset.
 448         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 449         * tui/tui-layout.c (show_source_disasm_command, show_data):
 450         Update.
 451         (tui_gen_win_info::resize): Rename.
 452         (show_source_or_disasm_and_command): Update.
 453         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 454         reset.
 455
 456 2019-08-15  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 459         * tui/tui-interp.c (tui_interp::init): Don't call
 460         tui_initialize_static_data.
 461         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 462
 463 2019-08-15  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 466         examine tui_win_list.
 467
 468 2019-08-15  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 471         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 472         tui_clear_source_content.
 473         (tui_clear_source_content): Remove.
 474         (tui_source_window_base::do_erase_source_content): Hoist call to
 475         content.clear().
 476         * tui/tui-stack.c (tui_show_frame_info): Don't call
 477         tui_clear_source_content.
 478
 479 2019-08-15  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.h (struct tui_source_window_base)
 482         <do_erase_source_content>: New method.
 483         <erase_source_content>: New method.
 484         (tui_erase_source_content): Don't declare.
 485         * tui/tui-winsource.c (tui_clear_source_content): Update.
 486         (tui_source_window_base::do_erase_source_content): Rename from
 487         tui_erase_source_content.
 488         (tui_source_window_base::show_source_content): Update.
 489         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 490         * tui/tui-source.h (struct tui_source_window)
 491         <erase_source_content>: New method.
 492         * tui/tui-disasm.h (struct tui_disasm_window)
 493         <erase_source_content>: New method.
 494
 495 2019-08-15  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 498         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 499         constructor.
 500         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 501         * tui/tui-source.c (tui_set_source_content): Update.
 502         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 503
 504 2019-08-15  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 507         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 508         tui-source.c.
 509         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 510         Declare.
 511         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 512         method.
 513         (tui_source_window::maybe_update): Update.
 514
 515 2019-08-15  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 518         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 519         tui-disasm.c.
 520         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 521         Declare.
 522         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 523         method.
 524         (tui_disasm_window::maybe_update): Update.
 525
 526 2019-08-15  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-winsource.h (struct tui_source_window_base)
 529         <maybe_update>: Declare.
 530         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 531         method.
 532         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 533         Declare.
 534         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 535         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 536         Declare.
 537         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 538
 539 2019-08-15  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 542
 543 2019-08-15  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-wingeneral.c: Include tui-stack.h.
 546         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 547         (struct tui_locator_window): Move from tui-data.h.
 548         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 549         (tui_initialize_static_data): Move from tui-data.c.
 550         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 551         (struct tui_locator_window): Move to tui-stack.c.
 552         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 553         (tui_initialize_static_data): Move to tui-stack.c.
 554
 555 2019-08-15  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-layout.c (show_source_disasm_command)
 558         (show_source_or_disasm_and_command): Use make_visible method, not
 559         tui_make_window.
 560         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 561         Remove.
 562
 563 2019-08-15  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-wingeneral.h (tui_make_window): Update.
 566         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 567         parameter.
 568         (tui_gen_win_info::make_visible): Update.
 569         * tui/tui-regs.c (tui_data_window::display_registers_from):
 570         Update.
 571         * tui/tui-layout.c (show_source_disasm_command)
 572         (show_source_or_disasm_and_command): Update.
 573         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 574         (enum tui_box): Remove.
 575         (struct tui_win_info) <can_box>: New method.
 576         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 577         method.
 578
 579 2019-08-15  Tom de Vries  <tdevries@suse.de>
 580
 581         * linux-nat-trad.c: Include gdbarch.h.
 582
 583 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 584
 585         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 586         register sizes.
 587
 588 2019-08-14  Tom Tromey  <tromey@adacore.com>
 589
 590         * darwin-nat.c: Include gdbarch.h.
 591         * darwin-nat-info.c: Include gdbarch.h.
 592
 593 2019-08-13  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 596         Remove.
 597         * tui/tui-data.c (tui_initialize_static_data): Update.
 598
 599 2019-08-13  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.h (struct tui_exec_info_window)
 602         <~tui_exec_info_window, maybe_allocate_content, get_content,
 603         m_content>: Remove.
 604         (struct tui_source_window_base) <set_exec_info_content,
 605         show_exec_info_content>: Don't declare.
 606         * tui/tui-winsource.c
 607         (tui_exec_info_window::maybe_allocate_content): Remove.
 608         (tui_source_window_base::update_exec_info): Rename from
 609         set_exec_info_content.
 610         (tui_source_window_base::show_exec_info_content)
 611         (tui_source_window_base::update_exec_info): Remove.
 612
 613 2019-08-13  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 616         declare.
 617         * tui/tui-winsource.c (tui_update_source_window_as_is)
 618         (tui_update_source_windows_with_addr, tui_erase_source_content):
 619         Update.
 620         (tui_clear_exec_info_content): Remove.
 621
 622 2019-08-13  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 625         declare.
 626         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 627         call tui_erase_exec_info_content.
 628         (tui_clear_exec_info_content): Rename from
 629         tui_erase_exec_info_content.
 630         (tui_clear_exec_info_content): Delete.
 631
 632 2019-08-13  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-winsource.h (struct tui_source_window_base)
 635         <show_exec_info_content>: Declare.
 636         (tui_show_exec_info_content): Don't declare.
 637         * tui/tui-winsource.c
 638         (tui_source_window_base::show_exec_info_content): Rename from
 639         tui_show_exec_info_content.
 640         (tui_source_window_base::update_exec_info): Update.
 641
 642 2019-08-13  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 645         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 646         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 647         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 648         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 649         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 650         ... here.
 651
 652 2019-08-13  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.h (struct tui_source_window_base)
 655         <update_exec_info>: Declare.
 656         (tui_update_exec_info): Don't declare.
 657         * tui/tui-winsource.c (tui_update_source_window_as_is)
 658         (tui_source_window_base::refresh_all)
 659         (tui_update_all_breakpoint_info): Update.
 660         (tui_source_window_base::update_exec_info): Rename from
 661         tui_update_exec_info.
 662         * tui/tui-stack.c (tui_show_frame_info): Update.
 663
 664 2019-08-13  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.h (struct tui_source_window_base)
 667         <set_exec_info_content>: Declare.
 668         (tui_set_exec_info_content): Don't declare.
 669         * tui/tui-winsource.c
 670         (tui_source_window_base::set_exec_info_content): Rename from
 671         tui_set_exec_info_content.
 672         (tui_update_exec_info): Update.
 673
 674 2019-08-13  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-winsource.h (struct tui_source_window_base)
 677         <show_source_content>: Declare.
 678         (tui_show_source_content): Don't declare.
 679         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 680         (tui_source_window_base::show_source_content): Rename from
 681         tui_show_source_content.
 682         (tui_source_window_base::refresh_all): Update.
 683         * tui/tui-layout.c (show_source_disasm_command)
 684         (show_source_or_disasm_and_command): Update.
 685
 686 2019-08-13  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.c (tui_erase_source_content)
 689         (tui_show_source_content, tui_source_window_base::refresh_all):
 690         Update.
 691         * tui/tui-wingeneral.h
 692         (tui_check_and_display_highlight_if_needed): Don't declare.
 693         * tui/tui-wingeneral.c
 694         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 695         check_and_display_highlight_if_needed.
 696         * tui/tui-win.c (tui_rehighlight_all)
 697         (tui_win_info::make_visible_with_new_height): Update.
 698         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 699         (tui_data_window::erase_data_content)
 700         (tui_data_window::display_all_data): Update.
 701         * tui/tui-data.h (struct tui_win_info)
 702         <check_and_display_highlight_if_needed>: Declare.
 703
 704 2019-08-13  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-win.c (tui_resize_all): Call
 707         tui_delete_invisible_windows.
 708         * tui/tui-layout.c (show_layout): Call
 709         tui_delete_invisible_windows.
 710         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 711         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 712
 713 2019-08-13  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 716         tui_add_win_to_layout.
 717
 718 2019-08-13  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 721         * tui/tui-layout.c (tui_default_win_height): Now static.
 722
 723 2019-08-13  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 726         single switch.
 727         (show_source_disasm_command, show_source_or_disasm_and_command):
 728         Don't check current layout.
 729
 730 2019-08-13  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-wingeneral.c (make_all_visible): Remove.
 733         (tui_make_all_invisible): Simplify.
 734         * tui/tui-layout.c (tui_make_all_invisible): Move from
 735         tui-wingeneral.c; simplify.
 736         (show_layout): Hoist call to tui_make_all_invisible.
 737         (show_data): Don't call tui_make_all_invisible.
 738
 739 2019-08-13  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 742         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 743
 744 2019-08-13  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 747         tui-data.c.
 748         (show_source_disasm_command, show_data)
 749         (show_source_or_disasm_and_command): Don't use
 750         tui_set_current_layout_to.
 751         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 752         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 753         tui-layout.c.
 754         (tui_set_current_layout_to): Remove.
 755
 756 2019-08-13  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-layout.c (tui_set_layout): Update.
 759         * tui/tui-data.h (struct tui_layout_def): Remove.
 760         (tui_layout_def): Don't declare.
 761         * tui/tui-data.c (layout_def): Remove.
 762         (tui_layout_def): Remove.
 763
 764 2019-08-13  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-winsource.h (struct tui_source_window_base)
 767         <clear_detail>: No longer "override".
 768         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 769         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 770         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 771         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 772         Remove.
 773         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 774
 775 2019-08-13  Tom Tromey  <tromey@adacore.com>
 776
 777         * tracepoint.c: Don't include readline.h or history.h.
 778
 779 2019-08-12  Tom Tromey  <tom@tromey.com>
 780
 781         * configure: Rebuild.
 782         * configure.ac: Check for readline 7.
 783         * NEWS: Mention readline 7 requirement.
 784         * README: Update.
 785
 786 2019-08-12  Tom Tromey  <tom@tromey.com>
 787
 788         * mingw-hdep.c (gdb_select): Remove readline hack.
 789
 790 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 791
 792         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 793         when the function fails.
 794
 795 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 796
 797         * s390-tdep.c (s390_type_align): New function.
 798         (s390_gdbarch_init): Set it as type_align gdbarch method.
 799
 800 2019-08-09  Tom de Vries  <tdevries@suse.de>
 801
 802         PR gdb/24591
 803         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 804         pc_low with relocation offset.
 805
 806 2019-08-07  Tom Tromey  <tromey@adacore.com>
 807
 808         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 809         (print_frame_args): Update.
 810         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 811         Update.
 812         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 813         * frame.h (struct frame_arg): Add initializers.
 814         <error>: Now a unique_xmalloc_ptr.
 815
 816 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 817
 818         * NEWS: Expand the Pointer Authentication entry.
 819         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 820         (aarch64_frame_unmask_lr): ... to this.
 821         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 822         Call aarch64_frame_unmask_lr.
 823         * frame.c (struct frame_info): Add "masked" variable.
 824         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 825         (fprint_frame): Check for masked pc.
 826         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 827         declarations.
 828         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 829         * stack.c (print_frame): Check for masked pc.
 830
 831 2019-08-06  Tom Tromey  <tom@tromey.com>
 832
 833         * stabsread.c (patch_block_stabs, read_one_struct_field)
 834         (read_enum_type): Use obstack_strndup.
 835         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 836         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 837         * dwarf2read.c (guess_full_die_structure_name)
 838         (anonymous_struct_prefix): Use obstack_strndup.
 839         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 840         * c-exp.y (yylex): Use obstack_strndup.
 841         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 842         (write_var_or_type): Use obstack_strndup.
 843
 844 2019-08-06  Tom Tromey  <tom@tromey.com>
 845
 846         * symfile.c (reread_symbols): Use obstack_strdup.
 847         * stabsread.c (read_type): Use obstack_strdup.
 848         * gdb_obstack.h (obstack_strdup): New overload.
 849         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 850         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 851         (dwarf2_canonicalize_name): Use obstack_strdup.
 852         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 853         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 854         Use obstack_strdup.
 855
 856 2019-08-06  Tom Tromey  <tom@tromey.com>
 857
 858         * gdb_obstack.h (obstack_strdup): Define.
 859         * gdb_obstack.c (obstack_strdup): Don't define.
 860
 861 2019-08-06  Tom Tromey  <tom@tromey.com>
 862
 863         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 864         obstack_strdup.
 865         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 866         obstack_strdup.
 867         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 868         * stabsread.c (common_block_start): Use obstack_strdup.
 869         * objfiles.c (set_objfile_main_name, objfile): Use
 870         obstack_strdup.
 871         * namespace.c (add_using_directive): Use obstack_strdup.
 872         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 873         * jit.c (finalize_symtab): Use obstack_strdup.
 874         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 875         (guess_partial_die_structure_name, partial_die_info::fixup)
 876         (dwarf2_name): Use obstack_strdup.
 877         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 878         obstack_strdup.
 879         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 880         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 881         obstack_strdup.
 882         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 883
 884 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 885
 886         * unittests/help-doc-selftests.c: New file.
 887         * Makefile.in: Add the new file.
 888
 889 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 890
 891         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 892         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 893         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 894         the trailing '.' is not output, and the first character is uppercased.
 895         (print_help_for_command): Update call to print_doc_line.
 896         (print_doc_of_command): Likewise.
 897         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 898         * cli/cli-option.c (append_indented_doc): Do not append newline.
 899         (build_help_option): Append newline after first appended_indented_doc
 900         only if a second call is done.
 901         (build_help): Append 2 new lines before each option, except the first
 902         one.
 903         * compile/compile.c (_initialize_compile): Add new lines after
 904         %OPTIONS%, when not at the end of the help.
 905         Change help doc or code
 906         producing the help doc to respect the invariants.
 907         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 908         Also removed the new line after 'Options:', as all other commands
 909         do not put an empty line between 'Options:' and the first option.
 910         * printcmd.c (_initialize_printcmd): Likewise.
 911         * stack.c (_initialize_stack): Likewise.
 912         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 913         incorrectly telling COMMAND is optional.
 914         * ada-lang.c (_initialize_ada_language): Change help doc or code
 915         producing the help doc to respect the invariants.
 916         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 917         * breakpoint.c (_initialize_breakpoint): Likewise.
 918         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 919         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 920         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 921         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 922         _initialize_cli_style): Likewise.
 923         * corelow.c (core_target_info): Likewise.
 924         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 925         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 926         * filesystem.c (_initialize_filesystem): Likewise.
 927         * frame.c (_initialize_frame): Likewise.
 928         * gnu-nat.c (add_task_commands): Likewise.
 929         * infcall.c (_initialize_infcall): Likewise.
 930         * infcmd.c (_initialize_infcmd): Likewise.
 931         * interps.c (_initialize_interpreter): Likewise.
 932         * language.c (_initialize_language): Likewise.
 933         * linux-fork.c (_initialize_linux_fork): Likewise.
 934         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 935         * maint.c (_initialize_maint_cmds): Likewise.
 936         * memattr.c (_initialize_mem): Likewise.
 937         * printcmd.c (_initialize_printcmd): Likewise.
 938         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 939         _RegEx): Likewise.
 940         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 941         * record-btrace.c (_initialize_record_btrace): Likewise.
 942         * record-full.c (_initialize_record_full): Likewise.
 943         * record.c (_initialize_record): Likewise.
 944         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 945         * regcache.c (_initialize_regcache): Likewise.
 946         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 947         _initialize_remote): Likewise.
 948         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 949         * serial.c (_initialize_serial): Likewise.
 950         * skip.c (_initialize_step_skip): Likewise.
 951         * source.c (_initialize_source): Likewise.
 952         * stack.c (_initialize_stack): Likewise.
 953         * symfile.c (_initialize_symfile): Likewise.
 954         * symtab.c (_initialize_symtab): Likewise.
 955         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 956         * top.c (init_main): Likewise.
 957         * tracefile-tfile.c (tfile_target_info): Likewise.
 958         * tracepoint.c (_initialize_tracepoint): Likewise.
 959         * tui/tui-win.c (_initialize_tui_win): Likewise.
 960         * utils.c (add_internal_problem_command): Likewise.
 961         * valprint.c (value_print_option_defs): Likewise.
 962
 963 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 964
 965         PR build/24886
 966         * configure.ac: Drop enable-libmcheck support.
 967         * configure, config.in: Rebuild.
 968         * libmcheck.m4: Remove.
 969         * acinclude.m4: Don't include it.
 970         * Makefile.in: Don't distribute it.
 971         * top.c (print_gdb_configuration): Don't mention it.
 972
 973 2019-08-06  Tom Tromey  <tom@tromey.com>
 974
 975         * utils.c (set_output_style): Sometimes pass stream to
 976         emit_style_escape.
 977         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 978         * record-btrace.c (btrace_insn_history): Update.
 979         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 980         method.
 981         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 982         Update initializers.
 983         <m_uiout>: New field.
 984         <m_di>: Move lower.
 985         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 986         Remove "uiout" parameter.
 987         (dump_insns): Update.
 988         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 989         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 990
 991 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 994         (error_in_psymtab_expansion): Likewise.
 995         (lookup_symbol_via_quick_fns): Likewise.
 996         (basic_lookup_transparent_type_quick): Likewise.
 997         (basic_lookup_transparent_type_1): Likewise.
 998
 999 2019-08-06  Tom Tromey  <tromey@adacore.com>
1000
1001         * source.c (last_source_error): Now bool.
1002         (print_source_lines_base): Make "noprint" bool.  Only open
1003         source file when last_source_visited changes.
1004
1005 2019-08-06  Tom Tromey  <tromey@adacore.com>
1006
1007         * annotate.c (annotate_source_line): Use g_source_cache.
1008         * source-cache.c (source_cache::get_plain_source_lines): Change
1009         parameters.  Populate m_offset_cache.
1010         (source_cache::ensure): New method.
1011         (source_cache::get_line_charpos): New method.
1012         (extract_lines): Move lower.  Change parameters.
1013         (source_cache::get_source_lines): Move lower.
1014         * source-cache.h (class source_cache): Update comment.
1015         <get_line_charpos>: New method.
1016         <get_source_lines>: Update comment.
1017         <clear>: Clear m_offset_cache.
1018         <get_plain_source_lines>: Change parameters.
1019         <ensure>: New method
1020         <m_offset_cache>: New member.
1021         * source.c (forget_cached_source_info_for_objfile): Update.
1022         (info_source_command): Use g_source_cache.
1023         (find_source_lines, open_source_file_with_line_charpos): Remove.
1024         (print_source_lines_base, search_command_helper): Use g_source_cache.
1025         * source.h (open_source_file_with_line_charpos): Don't declare.
1026         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1027         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1028         Use g_source_cache.
1029
1030 2019-08-06  Tom Tromey  <tromey@adacore.com>
1031
1032         * source-cache.c (source_cache::get_plain_source_lines):
1033         Remove "first_line" and "last_line" parameters.
1034         (source_cache::get_source_lines): Cache plain text.
1035         * source-cache.h (class source_cache)
1036         <get_plain_source_lines>: Update.
1037
1038 2019-08-06  Tom Tromey  <tromey@adacore.com>
1039
1040         * source-cache.c (extract_lines): No longer a method.
1041         Changed type of parameter.  Include final newline.
1042         (selftests::extract_lines_test): New function.
1043         (_initialize_source_cache): Likewise.
1044         * source-cache.h (class source_cache)
1045         <extract_lines>: Don't declare.
1046
1047 2019-08-06  Tom Tromey  <tromey@adacore.com>
1048
1049         * breakpoint.c (init_breakpoint_sal): Update.
1050         (breakpoint): Update.
1051         * breakpoint.h (struct breakpoint) <filter>: Now a
1052         unique_xmalloc_ptr.
1053
1054 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1055
1056         * NEWS: Mention dictionary access on blocks.
1057         * python/py-block.c (blpy_getitem): New function.
1058         (block_object_as_mapping): New struct.
1059         (block_object_type): Use new struct for tp_as_mapping field.
1060
1061 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1062
1063         * objfiles.h (objfile): Add a comment describing partial symbols.
1064
1065 2019-08-05  Tom Tromey  <tromey@adacore.com>
1066
1067         * compile/compile.c (_initialize_compile): Use _(), not N_().
1068         * thread.c (_initialize_thread): Use _(), not N_().
1069         * stack.c (_initialize_stack): Use _(), not N_().
1070         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1071
1072 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1073
1074         * dwarf2read.c (struct dw2_symtab_iterator):
1075         <want_specific_block>: Remove.
1076         <block_index>: Change type to gdb::optional.
1077         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1078         change type of BLOCK_INDEX parameter to gdb::optional.
1079         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1080         (dw2_lookup_symbol): Don't pass argument for
1081         WANT_SPECIFIC_BLOCK.
1082         (dw2_expand_symtabs_for_function): Don't pass argument for
1083         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1084         (class dw2_debug_names_iterator)
1085         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1086         parameter, change BLOCK_INDEX type to gdb::optional.
1087         <m_want_specific_block>: Remove.
1088         <m_block_index>: Change type to gdb::optional.
1089         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1090         gdb::optional.  Re-write in function of gdb::optional.
1091         (dw2_debug_names_lookup_symbol): Don't pass argument for
1092         WANT_SPECIFIC_BLOCK.
1093         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1094         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1095         BLOCK_INDEX.
1096
1097 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1098
1099         * NEWS: Mention changes to "info sources" command.
1100
1101 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1102
1103         * symtab.c (filename_partial_match_opts): New struct type.
1104         (struct output_source_filename_data): New members
1105         regexp, c_regexp, partial_match.
1106         (output_source_filename): Use new members to decide to print file.
1107         (info_sources_option_defs): New variable.
1108         (make_info_sources_options_def_group, print_info_sources_header,
1109         info_sources_command_completer):
1110         New functions.
1111         (info_sources_command): Read new optional arguments.
1112         (_initialize_symtab): Update info sources help.
1113
1114 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1115
1116         * ada-lang.c (exception_support_info_v0): Renamed from...
1117         (default_exception_support_info): ... this.  Create new
1118         definition for v1.
1119         (ada_has_this_exception_support): Look up catch_handlers_sym.
1120         (ada_exception_support_info_sniffer): Try v0 after default.
1121
1122 2019-08-01  Tom Tromey  <tromey@adacore.com>
1123
1124         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1125         gdbarch.h.
1126
1127 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1128
1129         * s12z-tdep.c: Fix include path for s12z-opc.h.
1130
1131 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * NEWS: Require GNU make 3.82.
1134
1135 2019-07-16  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1138         declare.
1139
1140 2019-07-30  Tom Tromey  <tromey@adacore.com>
1141
1142         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1143
1144 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1145
1146         * printcmd.c (print_address_symbolic): Print negative offsets.
1147         (build_address_symbolic): Force signed arithmetic when computing
1148         offset.
1149
1150 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1151
1152         PR/24474: Add a function to lookup static variables.
1153         * NEWS: Mention this new function.
1154         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1155         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1156         * python/python.c (python_GdbMethods): Add new function.
1157
1158 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1159
1160         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1161         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1162         (objfpy_lookup_static_symbol): New function.
1163         (objfile_object_methods): Add new functions.
1164
1165 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1166
1167         * NEWS: Mention 'set|show print frame-info'.  Mention new
1168         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1169         backtrace argument.  Mention that python frame filtering code
1170         is now consistent with what 'backtrace' command prints.
1171
1172 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1173
1174         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1175         comments.
1176         (print_frame_info_auto, print_frame_info_source_line,
1177         print_frame_info_location, print_frame_info_source_and_location,
1178         print_frame_info_location_and_address, print_frame_info_short_location):
1179         New declarations.
1180         (struct frame_print_options): New member print_frame_info.
1181         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1182         * stack.h (get_user_print_what_frame_info): New declaration.
1183         (frame_show_address): New declaration.
1184         * stack.c (print_frame_arguments_choices): New value 'presence'.
1185         (print_frame_info_auto, print_frame_info_source_line,
1186         print_frame_info_location, print_frame_info_source_and_location,
1187         print_frame_info_location_and_address, print_frame_info_short_location,
1188         print_frame_info_choices, print_frame_info_print_what): New definitions.
1189         (print_frame_args): Only print dots for args if print frame-arguments
1190         is 'presence'.
1191         (frame_print_option_defs): New element for "frame-info".
1192         (get_user_print_what_frame_info): New function.
1193         (frame_show_address): Make non static.  Move comment to stack.h.
1194         (print_frame_info_to_print_what): New function.
1195         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1196         to decide what to print.
1197         (backtrace_command_1): Handle the new print_frame_arguments_presence
1198         value.
1199         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1200         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1201         (py_print_frame): In non-mi mode, use LOCATION as default for
1202         print_what, similarly to frame information printed directly by
1203         backtrace command. Handle frame-info user option in non MI mode.
1204
1205 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1206
1207         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1208         Add case for debugging 32-bit target on 64-bit host.  Revise
1209         comment.
1210
1211 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1212
1213         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1214         instead of find_function_entry_range_from_pc.
1215
1216 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1217
1218         * stack.c (find_frame_funname): Remove code which preferred
1219         minsym over symtab sym in "certain pathological cases".
1220
1221         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1222         parameter.  Change type of "do_demangle" to bool.
1223         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1224         Pass suitable "prefer_sym_over_minsym" flag to
1225         build_address_symbolic().  Don't output "+" for negative offsets.
1226         * printcmd.c (print_address_symbolic): Update invocation of
1227         build_address_symbolic to include a "prefer_sym_over_minsym"
1228         flag.
1229         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1230         Restrict cases in which use of minimal symbol is preferred to that
1231         of a found symbol.  Update comments.
1232
1233         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1234         for entry pc when entry pc is out of range for that FDE.
1235
1236 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1237
1238         PR gdb/24839:
1239         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1240         type.
1241
1242 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1243
1244         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1245         this function's Python signature.
1246
1247
1248 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1249
1250         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1251         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1252         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1253         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1254         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1255
1256
1257 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1258
1259         * h8300-tdep.c (h8300_register_name_common): New.
1260         h8300_register_name): Use h8300_register_name_common.
1261         (h8300s_register_name): Likewise.
1262         (h8300sx_register_name): Likewise.
1263         (h8300h_register_nam): New.
1264         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1265
1266
1267 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1268
1269         * arm-tdep.c (arm_skip_cmse_entry): New function.
1270         (arm_is_sgstubs_section): New function.
1271         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1272
1273 2019-07-22  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1276         Don't self-assign.
1277
1278 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1281         type_print.
1282
1283 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1286         so that GDB doesn't match any msymbols when searching in the
1287         TYPES_DOMAIN.
1288         (print_symbol_info): Print using typedef_print or type_print based
1289         on the type of the symbol.  Add updated FIXME comment moved from...
1290         (_initialize_symtab): ... move and update FIXME comment to above.
1291
1292 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * NEWS: Mention adding -q option to "info types".
1295         * symtab.c (struct info_types_options): New struct.
1296         (info_types_options_defs): New variable.
1297         (make_info_types_options_def_group): New function.
1298         (info_types_command): Use gdb::option framework to parse options.
1299         (info_types_command_completer): New function.
1300         (_initialize_symtab): Extend the help text on "info types" and
1301         register command completer.
1302
1303 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1304
1305         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1306         (lookup_symbol_in_objfile): Change int to block_enum and add a
1307         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1308
1309 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1310
1311         * MAINTAINERS (Write After Approval): Add self.
1312
1313 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1316         instruction to the dummy code region.
1317
1318 2019-07-19  Tom Tromey  <tromey@adacore.com>
1319
1320         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1321         (ARGSUSED, PARAMS, __func__): Remove rules.
1322
1323 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1324
1325         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1326         * features/arm/arm-with-iwmmxt.c: Remove.
1327         * features/arm/arm-with-iwmmxt.xml: Remove.
1328         * features/arm/arm-with-m-fpa-layout.c: Remove.
1329         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1330         * features/arm/arm-with-m-vfp-d16.c: Remove.
1331         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1332         * features/arm/arm-with-m.c: Remove.
1333         * features/arm/arm-with-m.xml: Remove.
1334         * features/arm/arm-with-neon.c: Remove.
1335         * features/arm/arm-with-neon.xml: Remove.
1336         * features/arm/arm-with-vfpv2.c: Remove.
1337         * features/arm/arm-with-vfpv2.xml: Remove.
1338         * features/arm/arm-with-vfpv3.c: Remove.
1339         * features/arm/arm-with-vfpv3.xml: Remove.
1340
1341 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1344
1345 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * arch/aarch32.c (aarch32_create_target_description): Create
1348         target descriptions using features.
1349         * arch/arm.c (arm_create_target_description)
1350         (arm_create_mprofile_target_description): Likewise.
1351         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1352
1353 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1354
1355         * Makefile.in: Add new files.
1356         * aarch32-tdep.c: New file.
1357         * aarch32-tdep.h: New file.
1358         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1359         Call aarch32_read_description.
1360         * arch/aarch32.c: New file.
1361         * arch/aarch32.h: New file.
1362         * arch/arm.c (arm_create_target_description)
1363         (arm_create_mprofile_target_description): New function.
1364         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1365         (arm_create_target_description)
1366         (arm_create_mprofile_target_description): New declaration.
1367         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1368         read_description functions.
1369         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1370         Likewise.
1371         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1372         * arm-tdep.c (tdesc_arm_list): New variable.
1373         (arm_register_g_packet_guesses): Call create description functions.
1374         (arm_read_description) (arm_read_mprofile_description): New
1375         function.
1376         * arm-tdep.h (arm_read_description)
1377         (arm_read_mprofile_description): Add declaration.
1378         * configure.tgt: Add new files.
1379
1380 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1381
1382         * top.c (new_ui_command): Open specified terminal just once.
1383
1384 2019-07-18  Tom Tromey  <tromey@adacore.com>
1385
1386         * symtab.c (main_name): Constify return type.
1387         * symfile.c (set_initial_language): Update.
1388         * symtab.h (main_name): Constify return type.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-winsource.c (tui_update_source_window)
1393         (tui_update_source_window_as_is)
1394         (tui_update_source_windows_with_line): Remove return.
1395         * tui/tui-disasm.c (tui_show_disassem)
1396         (tui_show_disassem_and_update_source): Remove return.
1397         * tui/tui.c (tui_reset): Remove return.
1398         * tui/tui-wingeneral.c
1399         (tui_check_and_display_highlight_if_needed): Remove return.
1400
1401 2019-07-17  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1404
1405 2019-07-17  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-winsource.h (struct tui_exec_info_window)
1408         (struct tui_source_window_base): Move from tui-data.h.
1409         * tui/tui-winsource.c: Move many method definitions from
1410         elsewhere.  Remove "structuring" comments.
1411         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1412         (tui_source_window_base::refresh_window): Move to
1413         tui-winsource.c.
1414         * tui/tui-win.c (tui_source_window_base::refresh_all)
1415         (tui_source_window_base::update_tab_width)
1416         (tui_source_window_base::set_new_height)
1417         (tui_source_window_base::do_make_visible_with_new_height): Move to
1418         tui-winsource.c.
1419         * tui/tui-source.h: Update.
1420         * tui/tui-source.c (tui_source_window_base::reset): Move to
1421         tui-winsource.c.
1422         * tui/tui-disasm.h: Update.
1423         * tui/tui-data.h (struct tui_exec_info_window): Move to
1424         tui-winsource.h.
1425         (struct tui_source_window_base): Likewise.
1426         * tui/tui-data.c (tui_source_window_base::clear_detail)
1427         (tui_source_window_base, ~tui_source_window_base): Move to
1428         tui-winsource.c.
1429
1430 2019-07-17  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-win.c (tui_resize_all)
1433         (tui_source_window_base::update_tab_width)
1434         (tui_adjust_win_heights): Update.
1435         (tui_win_info::make_invisible_and_set_new_height): Rename from
1436         make_invisible_and_set_new_height.
1437         * tui/tui-data.h (struct tui_win_info)
1438         <make_invisible_and_set_new_height>: New method.
1439
1440 2019-07-17  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui.c: Update.
1443         * tui/tui-source.h (struct tui_source_window): Move from
1444         tui-data.h.
1445         * tui/tui-layout.c: Update.
1446         * tui/tui-disasm.c: Update.
1447         * tui/tui-data.h (struct tui_source_window): Move to
1448         tui-source.h.
1449
1450 2019-07-17  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1453         tui-data.h.
1454         * tui/tui-data.h (struct tui_disasm_window): Move to
1455         tui-disasm.h.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-regs.h (struct tui_data_item_window): Move from
1460         tui-data.h.
1461         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1462         * tui/tui-data.h (struct tui_data_item_window): Move to
1463         tui-regs.h.
1464         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1465
1466 2019-07-17  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui.c: Update.
1469         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1470         (tui_cmd_window::max_height): Move to tui-command.c.
1471         * tui/tui-layout.c: Update.
1472         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1473         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1474         tui-command.c.
1475         * tui/tui-command.h (struct tui_cmd_window): Move from
1476         tui-data.h.
1477         * tui/tui-command.c: Remove "structuring" comments.
1478         (tui_cmd_window::clear_detail)
1479         (tui_cmd_window::do_make_visible_with_new_height)
1480         (tui_cmd_window::max_height): Move from elsewhere.
1481
1482 2019-07-17  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1485         Now static.
1486         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1487         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1488
1489 2019-07-17  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui.c: Update.
1492         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1493         tui-regs.c.
1494         * tui/tui-windata.h: Remove file.
1495         * tui/tui-windata.c: Remove file.
1496         * tui/tui-win.c (tui_data_window::set_new_height)
1497         (tui_data_window::do_make_visible_with_new_height): Move to
1498         tui-regs.c.
1499         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1500         * tui/tui-regs.c: Remove "structuring" comments.
1501         (tui_data_window::first_data_item_displayed)
1502         (tui_data_window::delete_data_content_windows)
1503         (tui_data_window::erase_data_content)
1504         (tui_data_window::display_all_data)
1505         (tui_data_window::refresh_all)
1506         (tui_data_window::do_scroll_vertical)
1507         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1508         (tui_data_window::do_make_visible_with_new_height)
1509         (tui_data_window::refresh_window): Move from elsewhere.
1510         (_initialize_tui_regs): Move to end of file.
1511         * tui/tui-layout.c: Update.
1512         * tui/tui-hooks.c: Update.
1513         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1514         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1515         tui-regs.c.
1516         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1517
1518 2019-07-17  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1521         seen.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-win.c (tui_source_window_base::set_new_height)
1526         (tui_source_window_base::do_make_visible_with_new_height): Use
1527         m_has_locator field directly.
1528         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1529         method.
1530         (struct tui_source_window_base) <has_locator>: Likewise.
1531
1532 2019-07-17  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1535         Don't declare.
1536         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1537         Remove.
1538         * tui/tui-win.c (tui_source_window_base::set_new_height)
1539         (tui_source_window_base::set_new_height)
1540         (make_invisible_and_set_new_height)
1541         (tui_source_window_base::do_make_visible_with_new_height)
1542         (tui_source_window_base::do_make_visible_with_new_height):
1543         Update.
1544         * tui/tui-layout.c (show_source_disasm_command, show_data)
1545         (show_source_or_disasm_and_command): Update.
1546         * tui/tui-layout.c (show_layout): Update.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-layout.c (make_data_window): Remove.
1551         (show_data): Unify creation and re-initialization cases.
1552
1553 2019-07-17  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-layout.c (make_source_window, make_disasm_window):
1556         Remove.
1557         (show_data): Unify creation and re-initialization cases.
1558
1559 2019-07-17  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-layout.c (make_command_window): Remove.
1562         (show_source_disasm_command, show_source_or_disasm_and_command):
1563         Unify creation and re-initialization cases.
1564
1565 2019-07-17  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1568         creation and re-initialization cases.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-regs.c (tui_get_register): Return void.
1573
1574 2019-07-17  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1577         Simplify.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1582         resetting.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1587         * tui/tui-regs.c (tui_reg_layout): New function.
1588         (tui_show_registers, tui_reg_command): Use it.
1589         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1590         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1591         parameters.
1592         (tui_layout_command): Remove.
1593
1594 2019-07-17  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-layout.h (tui/tui-layout): Return void.
1597         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-layout.c (show_source_disasm_command, show_data):
1602         Update.
1603         (reset_locator): Remove.
1604         (show_source_or_disasm_and_command): Update.
1605
1606 2019-07-17  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-source.c (tui_source_window_base::reset): Remove
1609         win_type parameter.
1610         * tui/tui-layout.c (make_command_window, make_source_window)
1611         (make_disasm_window, make_data_window)
1612         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1613         (reset_locator, show_source_or_disasm_and_command): Update.
1614         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1615         win_type parameter.
1616         (struct tui_source_window_base) <reset>: Likewise.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-layout.c (show_source_disasm_command): Use
1621         reset_locator.
1622         (reset_locator): New function.
1623         (init_and_make_win): Remove.
1624         (show_source_or_disasm_and_command): Use reset_locator.
1625
1626 2019-07-17  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1629         condition.
1630         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1631         Remove condition.
1632         * tui/tui-source.c (tui_source_window_base::reset): New method.
1633         * tui/tui-layout.c (make_command_window): Don't call
1634         init_and_make_win.
1635         (make_source_window, make_disasm_window): Don't call
1636         make_source_or_disasm_window.
1637         (make_data_window): Don't call init_and_make_win.  Change calling
1638         convention.
1639         (show_source_disasm_command, show_data): Simplify.
1640         (make_source_or_disasm_window): Remove.
1641         (show_source_or_disasm_and_command): Simplify.
1642         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1643         (struct tui_source_window_base) <reset>: Likewise.
1644         <execution_info>: Remove initializer.
1645         * tui/tui-data.c (tui_source_window_base): Initialize
1646         execution_info.
1647
1648 2019-07-17  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1651         variable.
1652
1653 2019-07-17  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui.c (tui_rl_other_window): Update.
1656         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1657         superclass method first.  Always iterate over regs_content.
1658         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1659         method.
1660         * tui/tui-win.c (tui_set_focus_command): Update.
1661
1662 2019-07-17  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-win.c (tui_set_focus_command): Rename from
1665         tui_set_focus.  Call tui_enable.
1666         (tui_set_focus_command): Remove.
1667
1668 2019-07-17  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1671         refresh_window.
1672         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1673         touchwin.
1674         (tui_data_window::refresh_window): Call refresh_window on data
1675         items.  Always call superclass refresh_window.
1676         (tui_win_info::refresh): Remove.
1677         (tui_source_window_base::refresh_window): Update.
1678         (tui_refresh_all): Update.
1679         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1680         refresh_window.
1681         (show_source_or_disasm_and_command): Likewise.
1682         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1683         (struct tui_source_window_base) <refresh>: Likewise.
1684
1685 2019-07-17  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-winsource.c (tui_clear_source_content)
1688         (tui_show_source_content): Update.
1689         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1690         whether content is empty.
1691         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1692         Remove.
1693
1694 2019-07-17  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1697         window's contents.
1698         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1699         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1704         (struct tui_data_item_window): Update.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1709         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1710         defines.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-winsource.h (tui_erase_source_content)
1715         (tui_clear_source_content): Remove "display_prompt" parameter.
1716         * tui/tui-winsource.c (tui_update_source_window_as_is)
1717         (tui_update_source_windows_with_addr): Update.
1718         (tui_clear_source_content): Remove "display_prompt" parameter.
1719         (tui_erase_source_content): Likewise.  Simplify.
1720         (tui_show_source_content): Update.
1721         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1722         * tui/tui-stack.c (tui_show_frame_info): Update.
1723         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1724         Remove defines.
1725
1726 2019-07-17  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1729         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1730         parameter.
1731         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1732         parameter.
1733
1734 2019-07-17  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-winsource.c (tui_clear_source_content)
1737         (tui_show_source_content, tui_show_exec_info_content)
1738         (tui_clear_exec_info_content): Update.
1739         * tui/tui-stack.c (tui_show_locator_content): Update.
1740         (tui_show_frame_info): Update.
1741         * tui/tui-source.h (tui_source_window): Don't declare.
1742         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1743         from tui_source_is_displayed.
1744         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1745         Remove field.
1746         (struct tui_source_window_base) <content_in_use>: New field.  Now
1747         bool.
1748         (struct tui_source_window) <showing_source_p>: New method.
1749         (TUI_SRC_WIN): Change cast.
1750         * tui/tui-data.c (tui_initialize_static_data): Update.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1755         location_matches_p.
1756         * tui/tui-source.c (tui_source_window::location_matches_p): New
1757         method.
1758         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1759         method.
1760         * tui/tui-data.h (struct tui_source_window_base)
1761         <location_matches_p>: New method.
1762         (struct tui_source_window, struct tui_disasm_window)
1763         <location_matches_p>: Likewise.
1764
1765 2019-07-17  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-win.c (tui_set_win_height_command): Rename from
1768         tui_set_win_height.
1769         (tui_set_win_height_command): Remove.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-source.c (tui_source_window): New constructor.  Add
1774         observer.
1775         (~tui_source_window): New destructor.
1776         (tui_source_window::style_changed): New method.
1777         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1778         (tui_attach_detach_observers): Update.
1779         * tui/tui-data.h (struct tui_source_window): Make constructor not
1780         inline.  Add destructor.
1781         (struct tui_source_window) <style_changed>: New method.
1782         <m_observable>: New member.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1787         * tui/tui-win.c (tui_resize_all): Fix typo.
1788
1789 2019-07-17  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1792         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1793         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1794         * tui/tui-win.c (window_name_completer): Use foreach.
1795         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1796         (update_tab_width): Likewise.
1797         * tui/tui-layout.c (show_layout): Update.
1798         * tui/tui-data.h (class tui_window_iterator): New.
1799         (struct all_tui_windows): New.
1800         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1801
1802 2019-07-17  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1805         parameter.  Don't reference globals.
1806         (tui_reg_command): Update.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-regs.c (tui_show_registers): Simplify.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-regs.c (tui_show_registers): Update.
1815         (tui_show_register_group): Add win_info parameter.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1820         Rename from tui_display_reg_element_at_line.
1821         (tui_data_window::display_registers_from_line): Update.
1822         * tui/tui-data.h (struct tui_data_window)
1823         <display_reg_element_at_line>: New method.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-regs.h (tui_display_registers_from)
1828         (tui_display_registers_from_line): Don't declare.
1829         * tui/tui-windata.c (tui_data_window::display_all_data)
1830         (tui_data_window::refresh_all)
1831         (tui_data_window::do_scroll_vertical): Update.
1832         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1833         from tui_display_registers_from.
1834         (tui_display_reg_element_at_line): Update.
1835         (tui_data_window::display_registers_from_line): Rename from
1836         tui_display_registers_from_line.
1837         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1838         display_registers_from_line>: New methods.
1839
1840 2019-07-17  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1843         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1844         from tui_erase_data_content.
1845         (tui_data_window::display_all_data)
1846         (tui_data_window::refresh_all)
1847         (tui_data_window::do_scroll_vertical): Update.
1848         * tui/tui-regs.c (tui_show_registers): Update.
1849         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1850         New method.
1851
1852 2019-07-17  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1855         declare.
1856         * tui/tui-windata.c
1857         (tui_data_window::delete_data_content_windows): Rename from
1858         tui_delete_data_content_windows.
1859         (tui_data_window::display_all_data)
1860         (tui_data_window::do_scroll_vertical): Update.
1861         * tui/tui-data.h (struct tui_data_window)
1862         <delete_data_content_windows>: New method.
1863
1864 2019-07-17  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1867         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1868
1869 2019-07-17  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1872         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1873         from tui_display_all_data.
1874         * tui/tui-win.c
1875         (tui_data_window::do_make_visible_with_new_height): Update.
1876         * tui/tui-regs.c (tui_show_registers): Update.
1877         * tui/tui-layout.c (tui_set_layout): Update.
1878         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1879         method.
1880
1881 2019-07-17  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1884         * tui/tui-windata.c (tui_display_data_from): Remove.
1885         (tui_data_window::refresh_all): Update.
1886
1887 2019-07-17  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1890         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1891         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1892         tui_display_registers_from_line.
1893         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1894         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1895         "force_display" parameter.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1900         declare.
1901         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1902         Rename from tui_first_reg_element_no_inline.
1903         (tui_display_reg_element_at_line)
1904         (tui_display_registers_from_line): Update.
1905         * tui/tui-data.h (struct tui_data_window)
1906         <first_reg_element_no_inline>: New method.
1907
1908 2019-07-17  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-windata.c (tui_display_data_from)
1911         (tui_data_window::do_scroll_vertical): Update.
1912         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1913         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1914         Rename from tui_line_from_reg_element_no.
1915         (tui_display_registers_from_line): Update.
1916         * tui/tui-data.h (struct tui_data_window)
1917         <line_from_reg_element_no>: New method.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1922         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1923         tui_last_regs_line_no.
1924         (tui_display_reg_element_at_line)
1925         (tui_display_registers_from_line): Update.
1926         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1927         method.
1928
1929 2019-07-17  Tom Tromey  <tom@tromey.com>
1930
1931         PR tui/24722:
1932         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1933         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1934         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1935         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1936         (tui_update_breakpoint_info): Likewise.
1937         * tui/tui-hooks.c (tui_event_create_breakpoint)
1938         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1939         Update.
1940
1941 2019-07-17  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1944
1945 2019-07-17  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-winsource.c (tui_update_source_window_as_is)
1948         (tui_update_source_windows_with_addr): Update.
1949         * tui/tui-source.h (tui_set_source_content)
1950         (tui_show_symtab_source): Add "win_info" parameter.
1951         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1952         parameter.
1953         (tui_show_symtab_source): Likewise.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-wingeneral.c
1958         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1959
1960 2019-07-17  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1963         (struct tui_cmd_window) <can_scroll>: New method.
1964         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1965         method.
1966
1967 2019-07-17  Tom Tromey  <tromey@adacore.com>
1968
1969         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1970         do_field_signed>: Rename.  Change type of "value".
1971         * ui-out.c (ui_out::field_signed): Rename from field_int.
1972         Change type of "value".
1973         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1974         type of "value".
1975         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1976         do_field_int.  Change type of "value".
1977         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1978         do_field_int.  Change type of "value".
1979         * tracepoint.c (trace_status_mi, tfind_1)
1980         (print_one_static_tracepoint_marker): Update.
1981         * thread.c (print_thread_info_1, print_selected_thread_frame):
1982         Update.
1983         * stack.c (print_frame, print_frame_info): Update.
1984         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1985         Update.
1986         * source.c (print_source_lines_base): Update.
1987         * skip.c (info_skip_command): Update.
1988         * record-btrace.c (btrace_ui_out_decode_error)
1989         (btrace_call_history_src_line): Update.
1990         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1991         Update.
1992         * progspace.c (print_program_space): Update.
1993         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1994         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1995         do_field_int.  Change type of "value".
1996         * mi/mi-out.c (mi_ui_out::do_table_begin)
1997         (mi_ui_out::do_table_header): Update.
1998         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1999         type of "value".
2000         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2001         (mi_cmd_data_list_changed_registers, output_register)
2002         (mi_cmd_data_read_memory, mi_load_progress)
2003         (mi_cmd_trace_frame_collected): Update.
2004         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2005         Update.
2006         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2007         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2008         (mi_cmd_var_list_children, varobj_update_one): Update.
2009         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2010         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2011         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2012         * inferior.c (print_inferior): Update.
2013         * gdb_bfd.c (print_one_bfd): Update.
2014         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2015         Update.
2016         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2017         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2018         do_field_int.  Change type of "value".
2019         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2020         do_field_int.  Change type of "value".
2021         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2022         (print_one_breakpoint_location, print_it_catch_fork)
2023         (print_one_catch_fork, print_it_catch_vfork)
2024         (print_one_catch_vfork, print_it_catch_solib)
2025         (print_it_catch_exec, print_it_ranged_breakpoint)
2026         (print_mention_watchpoint, print_mention_masked_watchpoint)
2027         (bkpt_print_it, update_static_tracepoint): Update.
2028         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2029         * break-catch-syscall.c (print_it_catch_syscall): Update.
2030         * ada-tasks.c (print_ada_task_info): Update.
2031         * ada-lang.c (print_it_exception, print_mention_exception):
2032         Update.
2033
2034 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         PR breakpoints/24541
2037         * gdbarch.c: Regenerate.
2038         * gdbarch.h: Regenerate.
2039         * gdbarch.sh: Adjust return type and parameter types for
2040         'stap_adjust_register'.
2041         (i386_stap_adjust_register): Adjust signature and return new
2042         register name.
2043         * stap-probe.c (stap_parse_register_operand): Adjust use of
2044         'gdbarch_stap_adjust_register'.
2045
2046 2019-07-17  Tom Tromey  <tromey@adacore.com>
2047
2048         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2049         declare VEC.
2050         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2051         std::vector.
2052         (struct s390_process_info): Add initializers.
2053         (s390_add_process): Use new.
2054         (s390_linux_nat_target::low_forget_process): Use delete.
2055         (s390_linux_nat_target::low_new_fork)
2056         (s390_linux_nat_target::stopped_by_watchpoint)
2057         (s390_linux_nat_target::low_prepare_to_resume)
2058         (s390_linux_nat_target::insert_watchpoint)
2059         (s390_linux_nat_target::insert_hw_breakpoint)
2060         (s390_linux_nat_target::remove_watchpoint)
2061         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2062
2063 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2064
2065         * aarch64-fbsd-nat.c: Include regcache.h.
2066         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2067         argument.
2068         (aarch64_fbsd_nat_target::fetch_registers)
2069         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2070         variable.
2071         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2072
2073 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2074
2075         * fbsd-nat.c: Include gdbarch.h.
2076
2077 2019-07-15  Tom Tromey  <tromey@adacore.com>
2078
2079         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2080
2081 2019-07-15  Tom Tromey  <tromey@adacore.com>
2082
2083         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2084         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2085         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2086         * cli-out.c (cli_ui_out::do_field_int): New method.
2087         * ui-out.c (ui_out::field_unsigned): New method.
2088         * symfile.c (generic_load): Use field_unsigned.
2089         (print_transfer_performance): Likewise.
2090         * record-btrace.c (ui_out_field_uint): Remove.
2091         (btrace_call_history_insn_range, btrace_call_history): Use
2092         field_unsigned.
2093         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2094         field_unsigned.
2095         * ui-out.h (class ui_out) <field_unsigned>: New method.
2096         <do_field_unsigned>: Likewise.
2097
2098 2019-07-15  Tom Tromey  <tromey@adacore.com>
2099
2100         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2101         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2102         * target.c (flash_erase_command): Use field_string.
2103         * infrun.c (print_signal_received_reason): Use field_string.
2104         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2105         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2106         field_string.
2107         * ada-tasks.c (print_ada_task_info): Use field_string.
2108
2109 2019-07-15  Tom Tromey  <tromey@adacore.com>
2110
2111         * target.c (flash_erase_command): Use field_core_addr.
2112         * symfile.c (generic_load): Use field_core_addr.
2113         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2114         Use field_core_addr.
2115         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2116         field_core_addr.
2117
2118 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2121         value if its desired type is smaller than a CORE_ADDR and signed.
2122
2123 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2126         of changes to field names, and use new is_reference field to
2127         decide if a property is a reference or not.
2128         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2129         field.
2130         (struct dwarf2_property_baton): Update header comment, rename
2131         'referenced_type' to 'property_type' and update comments.
2132         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2133         default property type, store in property baton, update to take
2134         accound of renamed field.
2135         (read_func_scope): Update call to attr_to_dynamic_prop.
2136         (read_array_type): Likewise.
2137         (dwarf2_per_cu_addr_sized_int_type): New function.
2138         (read_subrange_index_type): Move type finding code to
2139         dwarf2_per_cu_addr_sized_int_type.
2140         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2141         (dwarf2_per_cu_addr_type): New function.
2142         (set_die_type): Update calls to attr_to_dynamic_prop.
2143
2144 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * dwarf2read.c (read_subrange_index_type): New function.
2147         (read_subrange_type): Move code into new function and call it.
2148         * gdbtypes.c (create_range_type): Add some asserts.
2149
2150 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2153         update return statements.
2154         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2155         declaration, and update comment to match.
2156         * gdbtypes.c (resolve_dynamic_array): Update call to
2157         dwarf2_evaluate_property to match new return type.
2158
2159 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * valarith.c (value_subscripted_rvalue): Change lowerbound
2162         parameter type from int to LONGEST.
2163         * value.h (value_subscripted_rvalue): Likewise in declaration.
2164
2165 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * cli/cli-utils.c (info_print_command_completer): New function.
2168         * cli/cli-utils.h: Add 'completer.h' include, and forward
2169         declaration for 'struct cmd_list_element'.
2170         (info_print_command_completer): Declare.
2171         * stack.c (_initialize_stack): Add completer for 'info locals' and
2172         'info args'.
2173         * symtab.c (_initialize_symtab): Add completer for 'info
2174         variables' and 'info functions'.
2175         * NEWS: Mention completion for additional info commands.
2176
2177 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * cli/cli-utils.c (extract_info_print_args): Delete.
2180         (extract_arg_maybe_quoted): Delete.
2181         (info_print_options_defs): New variable.
2182         (make_info_print_options_def_group): New function.
2183         (extract_info_print_options): Define new function.
2184         * cli/cli-utils.h (extract_info_print_args): Delete.
2185         (struct info_print_options): New structure.
2186         (extract_info_print_options): Declare new function.
2187         * stack.c (info_locals_command): Update to use new
2188         extract_info_print_options, also add a header comment.
2189         (info_args_command): Likewise.
2190         * symtab.c (info_variables_command): Likewise.
2191         (info_functions_command): Likewise.
2192
2193 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2196         to extract string arguments.
2197         * common/common-utils.c (extract_string_maybe_quoted): New function.
2198         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2199
2200 2019-07-11  Tom Tromey  <tromey@adacore.com>
2201
2202         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2203         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2204         * top.h (gdbinit): Don't declare.
2205         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2206         into...
2207         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2208         * top.c (gdb_init): Don't call init_cli_cmds.
2209         (gdbinit): Remove.
2210         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2211
2212 2019-07-11  Tom Tromey  <tromey@adacore.com>
2213
2214         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2215         after it has been moved.
2216
2217 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2218
2219         * valops.c (value_must_coerce_to_target): Change return type to
2220         bool.
2221         * value.h (value_must_coerce_to_target): Likewise.
2222
2223 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2224
2225         * breakpoint.c (is_hardware_watchpoint): Remove
2226         forward-declaration.
2227         (is_masked_watchpoint): Change return type to bool.
2228         (is_tracepoint): Likewise.
2229         (is_breakpoint): Likewise.
2230         (is_hardware_watchpoint): Likewise.
2231         (is_watchpoint): Likewise.
2232         (is_no_memory_software_watchpoint): Likewise.
2233         (is_catchpoint): Likewise.
2234         (breakpoint_1): Make FILTER parameter's return type bool.
2235         is_masked_watchpoint): Change return type to bool.
2236         (save_breakpoints): Make FILTER parameter's return type bool.
2237         * breakpoint.h (is_breakpoint): Change return type to bool.
2238         (is_watchpoint): Likewise.
2239         (is_catchpoint): Likewise.
2240         (is_tracepoint): Likewise.
2241
2242 2019-07-10  Tom Tromey  <tom@tromey.com>
2243
2244         * defs.h: Don't include gdbarch.h.
2245         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2246         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2247         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2248         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2249         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2250         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2251         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2252         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2253         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2254         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2255         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2256         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2257         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2258         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2259         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2260         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2261         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2262         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2263         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2264         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2265         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2266         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2267         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2268         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2269         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2270         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2271         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2272
2273 2019-07-10  Tom Tromey  <tromey@adacore.com>
2274
2275         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2276         * breakpoint.c (init_ada_exception_breakpoint): Register as
2277         bp_catchpoint.
2278         (print_one_breakpoint_location, print_one_breakpoint): Use
2279         is_ada_exception_catchpoint.
2280         * ada-lang.c (class ada_catchpoint_location): Pass
2281         bp_loc_software_breakpoint to bp_location constructor.
2282         (is_ada_exception_catchpoint): New function.
2283
2284 2019-07-10  Tom Tromey  <tromey@adacore.com>
2285
2286         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2287         VEC.
2288         (struct arm_exidx_entry): New method operator<.
2289         (struct arm_exidx_data) <section_maps>: Change type.
2290         (arm_exidx_data_free): Remove.
2291         (arm_exidx_data_key): Change type.  Move lower.
2292         (arm_exidx_new_objfile): Update.
2293         (arm_compare_exidx_entries): Remove.
2294         (arm_find_exidx_entry, _initialize_arm_tdep)
2295
2296 2019-07-10  Tom Tromey  <tromey@adacore.com>
2297
2298         * solib-spu.c (ocl_program_data_key): Change type.
2299         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2300         Update.
2301
2302 2019-07-10  Tom Tromey  <tromey@adacore.com>
2303
2304         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2305         (struct solib_aix_inferior_data) <library_list>: Change type.
2306         (solib_aix_inferior_data_handle): Change type.
2307         (get_solib_aix_inferior_data): Update.
2308         (solib_aix_free_library_list): Remove.
2309         (library_list_start_library): Update.
2310         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2311         return type.
2312         (solib_aix_get_library_list)
2313         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2314         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2315
2316 2019-07-10  Tom Tromey  <tromey@adacore.com>
2317
2318         * solib-dsbt.c (struct dsbt_info): Add initializers.
2319         (solib_dsbt_pspace_data): Change type.
2320         (dsbt_pspace_data_cleanup): Remove.
2321         (get_dsbt_info, _initialize_dsbt_solib): Update.
2322
2323 2019-07-10  Tom Tromey  <tromey@adacore.com>
2324
2325         * spu-tdep.c (spu_overlay_data): Change type.
2326         (spu_get_overlay_table, spu_overlay_new_objfile)
2327         (_initialize_spu_tdep): Update.
2328
2329 2019-07-10  Tom Tromey  <tromey@adacore.com>
2330
2331         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2332         destructor.
2333         (dbx_objfile_data_key): Change type and declare later.
2334         (DBX_SYMFILE_INFO): Rewrite.
2335         * dbxread.c (dbx_objfile_data_key): Change type.
2336         (dbx_symfile_init): Update.
2337         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2338         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2339         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2340
2341 2019-07-10  Tom Tromey  <tromey@adacore.com>
2342
2343         * jit.c (jit_program_space_key): Change type.  Move lower.
2344         (get_jit_program_space_data): Update.
2345         (jit_program_space_data_cleanup): Remove.
2346         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2347         Update.
2348         (struct jit_program_space_data): Add initializers.
2349
2350 2019-07-10  Tom Tromey  <tromey@adacore.com>
2351
2352         * solib-darwin.c (struct darwin_info): Add initializers.
2353         (solib_darwin_pspace_data): Change type.
2354         (darwin_pspace_data_cleanup): Remove.
2355         (get_darwin_info, _initialize_darwin_solib): Update.
2356
2357 2019-07-10  Tom Tromey  <tromey@adacore.com>
2358
2359         * remote-sim.c (struct sim_inferior_data): Add initializers,
2360         constructor, and destructor.
2361         (sim_inferior_data_key): Change type.  Move lower.
2362         (check_for_duplicate_sim_descriptor): Update.
2363         (get_sim_inferior_data): Use new.  Update.
2364         (~sim_inferior_data_cleanup): Rename from
2365         sim_inferior_data_cleanup.  Simplify.
2366         (gdbsim_close_inferior, simulator_command)
2367         (sim_command_completer, _initialize_remote_sim): Update.
2368         (next_pid, INITIAL_PID): Move earlier.
2369
2370 2019-07-10  Tom Tromey  <tromey@adacore.com>
2371
2372         * python/python-internal.h (create_thread_object): Return
2373         gdbpy_ref.
2374         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2375         * python/py-inferior.c (struct threadlist_entry): Add
2376         constructor.
2377         <thread_obj>: Now a gdbpy_ref.
2378         (thread_to_thread_object): Update.
2379         (add_thread_object): Use new.
2380         (delete_thread_object): Use delete.
2381         (infpy_threads): Update.
2382         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2383         GIL.
2384
2385 2019-07-10  Tom Tromey  <tromey@adacore.com>
2386
2387         * valops.c (value_cast): Specialize error message for Ada.
2388
2389 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2390
2391         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2392
2393 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2394
2395         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2396         bpstat_should_step): Return bool, adjust comments.
2397         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2398         bpstat_should_step): Likewise.
2399
2400 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2401
2402         * features/Makefile: Use feature target descriptions for Arm.
2403         * features/arm/arm-core.c: Generate new file.
2404         * features/arm/arm-fpa.c: Likewise.
2405         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2406         * features/arm/arm-m-profile.c: Likewise.
2407         * features/arm/arm-vfpv2.c: Likewise.
2408         * features/arm/arm-vfpv3.c: Likewise.
2409         * features/arm/xscale-iwmmxt.c: Likewise.
2410         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2411
2412 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2413
2414         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2415         ptrace earlier.
2416
2417 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2418
2419         * features/aarch64-pauth.c: Regenerate.
2420
2421 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2422
2423         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2424         bool.
2425         (bpstat_what): Use false instead of 0.
2426
2427 2019-07-09  Pedro Alves  <palves@redhat.com>
2428
2429         * break-catch-throw.c (is_exception_catchpoint): New.
2430         * breakpoint.c (print_one_breakpoint_location): New parameter
2431         'raw_loc'.  Handle it.  Use
2432         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2433         looking at the breakpoint's type.
2434         (print_one_breakpoint): If handling "maint info breakpoints", also
2435         print locations of exception catchpoints.
2436         * breakpoint.h (is_exception_catchpoint): Declare.
2437
2438 2019-07-09  Pedro Alves  <palves@redhat.com>
2439
2440         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2441         "addr" field.
2442         (allocate_location_exception_catchpoint): New.
2443         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2444         (initialize_throw_catchpoint_ops): Install
2445         allocate_location_exception_catchpoint as allocate_location
2446         method.
2447         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2448         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2449         bp_loc_other.
2450         (breakpoint_address_is_meaningful): Delete.
2451         (bl_address_is_meaningful): New.
2452         (breakpoint_locations_match): Adjust comment.
2453         (bp_location_from_bp_type): New, factored out of...
2454         (bp_location::bp_location(breakpoint *)): ... this.
2455         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2456         factored out of...
2457         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2458         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2459         breakpoint_address_is_meaningful.
2460         (bp_locations_compare): Adjust comment.
2461         (update_global_location_list): Use bl_address_is_meaningful
2462         instead of breakpoint_address_is_meaningful.
2463         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2464         explicit.
2465         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2466         * python/py-breakpoint.c (bppy_get_location): No longer check
2467         whether location is null.
2468
2469 2019-07-09  Pedro Alves  <palves@redhat.com>
2470
2471         PR c++/15468
2472         * breakpoint.c (print_one_breakpoint_location): Remove
2473         single-location assert.
2474
2475 2019-07-09  Tom Tromey  <tom@tromey.com>
2476
2477         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2478         * configure: Rebuild.
2479         * configure.ac: Change common to gdbsupport.
2480         * gdbsupport: Rename from common.
2481         * acinclude.m4: Change common to gdbsupport.
2482         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2483         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2484         gdbsupport.
2485         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2486         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2487         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2488         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2489         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2490         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2491         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2492         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2493         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2494         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2495         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2496         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2497         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2498         coff-pe-read.c, command.h, compile/compile-c-support.c,
2499         compile/compile-c.h, compile/compile-cplus-symbols.c,
2500         compile/compile-cplus-types.c, compile/compile-cplus.h,
2501         compile/compile-loc2c.c, compile/compile.c, completer.c,
2502         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2503         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2504         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2505         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2506         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2507         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2508         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2509         features/aarch64-core.c, features/aarch64-fpu.c,
2510         features/aarch64-pauth.c, features/aarch64-sve.c,
2511         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2512         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2513         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2514         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2515         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2516         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2517         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2518         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2519         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2520         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2521         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2522         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2523         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2524         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2525         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2526         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2527         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2528         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2529         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2530         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2531         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2532         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2533         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2534         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2535         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2536         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2537         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2538         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2539         minsyms.c, mips-linux-tdep.c, namespace.h,
2540         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2541         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2542         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2543         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2544         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2545         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2546         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2547         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2548         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2549         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2550         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2551         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2552         procfs.c, producer.c, progspace.h, psymtab.h,
2553         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2554         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2555         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2556         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2557         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2558         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2559         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2560         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2561         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2562         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2563         target-memory.c, target.c, target.h, target/waitstatus.c,
2564         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2565         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2566         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2567         unittests/array-view-selftests.c,
2568         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2569         unittests/common-utils-selftests.c,
2570         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2571         unittests/format_pieces-selftests.c,
2572         unittests/function-view-selftests.c,
2573         unittests/lookup_name_info-selftests.c,
2574         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2575         unittests/mkdir-recursive-selftests.c,
2576         unittests/observable-selftests.c,
2577         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2578         unittests/parse-connection-spec-selftests.c,
2579         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2580         unittests/scoped_fd-selftests.c,
2581         unittests/scoped_mmap-selftests.c,
2582         unittests/scoped_restore-selftests.c,
2583         unittests/string_view-selftests.c, unittests/style-selftests.c,
2584         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2585         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2586         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2587         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2588         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2589         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2590
2591 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2592
2593         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2594         bool value.
2595         (decode_digits_ordinary): Set explicit_line field in sal.
2596         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2597         symtab_and_line that was set on an explicit line number in
2598         assembler code.  Do always update the recorded symtab and line if
2599         we do skip the prologue.
2600
2601 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * breakpoint.c (set_breakpoint_location_function): Remove
2604         explicit_loc parameter.
2605         (momentary_breakpoint_from_master): Update call to
2606         set_breakpoint_location_function.
2607         (add_location_to_breakpoint): Likewise.
2608
2609 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2612         required features based on default bfd type when no specific bfd
2613         is present.
2614
2615 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2616
2617         * NEWS: Mention that GDB printf and eval commands can now print
2618         C-style and Ada-style convenience var strings without
2619         calling the inferior.
2620         * printcmd.c (printf_c_string): Locally print GDB internal var
2621         instead of transiting via the inferior.
2622         (printf_wide_c_string): Likewise.
2623
2624 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2625
2626         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2627
2628 2019-07-04  Tom Tromey  <tom@tromey.com>
2629
2630         PR tui/24724:
2631         * tui/tui-winsource.c (tui_clear_source_content): Update.
2632         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2633         (tui_update_breakpoint_info): Update.
2634         (tui_set_exec_info_content): Update.
2635         * tui/tui-source.c (tui_set_source_content_nil): Update.
2636         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2637         has_break.
2638         * tui/tui-data.h (enum tui_bp_flag): New.
2639         (tui_bp_flags): New enum flags type.
2640         (struct tui_source_element) <break_mode>: Change type.  Rename
2641         from has_break.
2642         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2643         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2644         constants.
2645         * tui/tui-winsource.h: Fix comment.
2646
2647 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2648
2649         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2650         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2651         (store_fpregs_to_thread)
2652         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2653         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2654         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2655         (IWMMXT_REGS_SIZE): Add define.
2656         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2657         (fetch_vfp_regs, store_vfp_regs)
2658         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2659         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2660
2661 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2662
2663         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2664         defines.
2665         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2666         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2667         (ARM_INT_REGISTER_SIZE): ...to this.
2668         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2669         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2670         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2671         (arm_linux_collect_gregset, supply_nwfpe_register)
2672         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2673         defines.
2674         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2675         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2676         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2677         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2678         (arm_return_in_memory, arm_store_return_value)
2679         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2680         (arm_record_ld_st_multiple): Likewise.
2681         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2682         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2683
2684 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2685
2686         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2687         AARCH64_DISPLACED_MODIFIED_INSNS.
2688         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2689         (aarch64_displaced_step_copy_insn): Likewise.
2690         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2691         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2692         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2693         ARM_DISPLACED_MODIFIED_INSNS.
2694         * arm-tdep.c (arm_gdbarch_init): Likewise.
2695         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2696         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2697         (struct arm_displaced_step_closure): Use
2698         ARM_DISPLACED_MODIFIED_INSNS.
2699
2700 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2701
2702         * features/Makefile: Remove unused xml files.
2703         * features/aarch64.xml: Remove.
2704         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2705         * features/i386/amd64-avx-avx512.xml: Remove.
2706         * features/i386/amd64-avx-linux.xml: Remove.
2707         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2708         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2709         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2710         * features/i386/amd64-avx-mpx.xml: Remove.
2711         * features/i386/amd64-avx.xml: Remove.
2712         * features/i386/amd64-linux.xml: Remove.
2713         * features/i386/amd64-mpx-linux.xml: Remove.
2714         * features/i386/amd64-mpx.xml: Remove.
2715         * features/i386/amd64.xml: Remove.
2716         * features/i386/i386-avx-avx512-linux.xml: Remove.
2717         * features/i386/i386-avx-avx512.xml: Remove.
2718         * features/i386/i386-avx-linux.xml: Remove.
2719         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2720         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2721         * features/i386/i386-avx-mpx-linux.xml: Remove.
2722         * features/i386/i386-avx-mpx.xml: Remove.
2723         * features/i386/i386-avx.xml: Remove.
2724         * features/i386/i386-linux.xml: Remove.
2725         * features/i386/i386-mmx-linux.xml: Remove.
2726         * features/i386/i386-mmx.xml: Remove.
2727         * features/i386/i386-mpx-linux.xml: Remove.
2728         * features/i386/i386-mpx.xml: Remove.
2729         * features/i386/i386.xml: Remove.
2730         * features/i386/x32-avx-avx512-linux.xml: Remove.
2731         * features/i386/x32-avx-linux.xml: Remove.
2732         * features/i386/x32-linux.xml: Remove.
2733
2734 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2735
2736         * regformats/aarch64.dat: Remove.
2737         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2738         * regformats/i386/amd64-avx-linux.dat: Remove.
2739         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2740         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2741         * regformats/i386/amd64-linux.dat: Remove.
2742         * regformats/i386/amd64-mpx-linux.dat: Remove.
2743         * regformats/i386/amd64.dat: Remove.
2744         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2745         * regformats/i386/i386-avx-linux.dat: Remove.
2746         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2747         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2748         * regformats/i386/i386-linux.dat: Remove.
2749         * regformats/i386/i386-mmx-linux.dat: Remove.
2750         * regformats/i386/i386-mpx-linux.dat: Remove.
2751         * regformats/i386/i386.dat: Remove.
2752         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2753         * regformats/i386/x32-avx-linux.dat: Remove.
2754         * regformats/i386/x32-linux.dat: Remove.
2755
2756 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2757
2758         * aarch64-tdep.c: Remove xml self tests.
2759         * amd64-linux-tdep.c: Likewise.
2760         * amd64-tdep.c: Likewise.
2761         * i386-linux-tdep.c: Likewise.
2762         * i386-tdep.c: Likewise.
2763
2764 2019-07-03  Pedro Alves  <palves@redhat.com>
2765
2766         PR cli/24732
2767         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2768         (pipe_cmd_option_defs): New.
2769         (make_pipe_cmd_options_def_group): New.
2770         (pipe_command): Use gdb::option::process_options.
2771         (pipe_command_completer): New function.
2772         (_initialize_cli_cmds): Install completer for "pipe" command.
2773
2774 2019-07-03  Pedro Alves  <palves@redhat.com>
2775
2776         * cli/cli-option.c (union option_value) <string>: New field.
2777         (struct option_def_and_value): Add ctor, move ctor, dtor and
2778         use DISABLE_COPY_AND_ASSIGN.
2779         (option_def_and_value::clear_value): New.
2780         (parse_option, save_option_value_in_ctx, get_val_type_str)
2781         (add_setshow_cmds_for_options): Handle var_string.
2782         * cli-option.h (union option_def::var_address) <string>: New
2783         field.
2784         (struct string_option_def): New.
2785         * maint-test-options.c (struct test_options_opts): Add default
2786         ctor and use DISABLE_COPY_AND_ASSIGN.
2787         <string_opt>: New field.
2788         (test_options_opts::~test_options_opts): New.
2789         (test_options_opts::dump): Also dump "-string".
2790         (test_options_option_defs): Install "string.
2791
2792 2019-07-03  Pedro Alves  <palves@redhat.com>
2793
2794         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2795         option_value with a null enumeration.
2796         (complete_options): Save the option values in the context.
2797         (save_option_value_in_ctx): New, factored out from ...
2798         (process_options): ... here.
2799         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2800         of the function.
2801         * maint-test-options.c (test_options_opts::dump): New, factored
2802         out from ...
2803         (maintenance_test_options_command_mode): ... here.
2804         (maintenance_test_options_command_completion_result): Delete.
2805         (maintenance_test_options_command_completion_text): Update
2806         comment.
2807         (maintenance_show_test_options_completion_result): Change
2808         prototype.  Just print
2809         maintenance_test_options_command_completion_text.
2810         (save_completion_result): New.
2811         (maintenance_test_options_completer_mode): Pass options context to
2812         complete_options, and then save a dump.
2813         (_initialize_maint_test_options): Use add_cmd to install "maint
2814         show test-options-completion-result".
2815
2816 2019-07-03  Pedro Alves  <palves@redhat.com>
2817
2818         * NEWS (New commands): Mention "with" and "maint with".
2819         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2820         (with_command, with_command_completer): New.
2821         (pipe_command): Adjust to new repeat_previous
2822         interface.
2823         (_initialize_cli_cmds): Install the "with" command and its "w"
2824         alias.
2825         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2826         declarations.
2827         * cli/cli-setshow.c (parse_cli_var_uinteger)
2828         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2829         argument strings for all var_types.
2830         (get_setshow_command_value_string): New, factored out from ...
2831         (do_show_command): ... this.
2832         * cli/cli-setshow.h: Include <string>.
2833         (get_setshow_command_value_string): Declare.
2834         * command.h (repeat_previous): Now returns const char *.  Adjust
2835         comment.
2836         * maint.c: Include "cli/cli-cmds.h".
2837         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2838         (_initialize_maint_cmds): Register the "maintenance with" command.
2839         * top.c (repeat_previous): Move bits from pipe_command here:
2840         Return the saved command line, if any; error out if there's no
2841         command to relaunch.
2842
2843 2019-07-03  Pedro Alves  <palves@redhat.com>
2844
2845         * NEWS (New commands): Mention "maint set/show test-settings"
2846         instead of "maint test-settings".
2847         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2848         (maintenance_test_settings_set_list): Rename to ...
2849         (maintenance_set_test_settings_list): ... this.
2850         (maintenance_test_settings_show_list): Rename to  ...
2851         (maintenance_show_test_settings_list): ... this.
2852         (maintenance_test_settings_cmd): Delete.
2853         (maintenance_test_settings_set_cmd): ...
2854         (maintenance_set_test_settings_cmd): ... this.
2855         (maintenance_test_settings_show_cmd): ...
2856         (maintenance_show_test_settings_cmd): ... this.
2857         (maintenance_test_settings_show_value_cmd):
2858         (maintenance_show_test_settings_value_cmd): ... this.
2859         (_initialize_maint_test_settings): No longer install the "maint
2860         test-settings" prefix command.  Rename "maint test-settings set"
2861         to "maint set test-settings", and "maint test-settings show" to
2862         "maint show test-settings".  Adjust all subcommands.
2863
2864 2019-07-03  Pedro Alves  <palves@redhat.com>
2865
2866         * maint-test-settings.c: Fix file's intro comment.  Replace all
2867         references to "test-options" with references to "test-settings",
2868         in comments.
2869
2870 2019-07-03  Pedro Alves  <palves@redhat.com>
2871
2872         * maint-test-settings.c (maintenance_test_settings_xxx)
2873         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2874         New.
2875         (maintenance_test_settings_enums): Use them.
2876         (maintenance_test_settings_enum): Default to
2877         maintenance_test_settings_xxx.
2878         (_initialize_maint_test_settings): Initialize
2879         MAINTENANCE_TEST_SETTINGS_FILENAME.
2880
2881 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2882
2883         * breakpoint.h (remove_breakpoints_inf): Change return type to
2884         void, move function documentation here.
2885         * breakpoint.c (remove_breakpoints_inf): Change return type to
2886         void, move function documentation to header.
2887
2888 2019-07-02  Pedro Alves  <palves@redhat.com>
2889
2890         * NEWS (Completion improvements): Mention "info threads".
2891         * thread.c (struct info_threads_opts, info_threads_option_defs)
2892         (make_info_threads_options_def_group): New.
2893         (info_threads_command): Use gdb::option::process_options.
2894         (info_threads_command_completer): New.
2895         (_initialize_thread): Use gdb::option::build_help to build the
2896         help text for "info threads".
2897
2898 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2899
2900         * defs.h (generic_load): Move from here...
2901         * symfile.h (generic_load): ... to here.  Rename name parameter
2902         to args.
2903         * symfile.c (generic_load): Add comment.
2904
2905 2019-07-01  Tom Tromey  <tromey@adacore.com>
2906
2907         * dwarf2read.c
2908         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2909         declaration of without_params.  Fix formatting.
2910
2911 2019-07-01  Tom Tromey  <tromey@adacore.com>
2912
2913         * ada-exp.y (find_primitive_type): Update.
2914         * ada-lang.h (ada_lookup_symbol): Update.
2915         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2916         parameter.
2917         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2918
2919 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2920
2921         PR breakpoints/24541
2922         * gdbarch.c: Regenerate.
2923         * gdbarch.h: Regenerate.
2924         * gdbarch.sh: Add 'stap_adjust_register'.
2925         * i386-tdep.c: Include '<unordered_set>'.
2926         (i386_stap_adjust_register): New function.
2927         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2928         * stap-probe.c (stap_parse_register_operand): Call
2929         'gdbarch_stap_adjust_register'.
2930
2931 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2932
2933         PR python/24742
2934         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2935         * python/python.c (do_start_initialization): Use 'xmalloc'
2936         instead of 'PyMem_Malloc'.
2937
2938 2019-06-28  Tom Tromey  <tromey@adacore.com>
2939
2940         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2941         for Ada.
2942
2943 2019-06-27  Tom Tromey  <tromey@adacore.com>
2944
2945         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2946         objfile_key.
2947         (arm_find_mapping_symbol, arm_record_special_symbol)
2948         (_initialize_arm_tdep): Update.
2949         (arm_objfile_data_free): Remove.
2950
2951 2019-06-27  Tom Tromey  <tromey@adacore.com>
2952
2953         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2954         to cp_print_static_field.
2955
2956 2019-06-26  Tom Tromey  <tromey@adacore.com>
2957
2958         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2959         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2960         declare.
2961
2962 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2963
2964         * features/aarch64-core.c (create_feature_aarch64_core):
2965         Regenerate.
2966         * features/aarch64-core.xml: Add cpsr flags.
2967
2968 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2969
2970         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2971         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2972
2973 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2974
2975         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2976         field.
2977         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2978         use.
2979         (arm_record_special_symbol): Don't insert new symbol in sorted
2980         position, push it at the end.
2981
2982 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2983
2984         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2985         (arm_mapping_symbol_s): Remove.
2986         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2987         (arm_mapping_symbol_vec): New typedef.
2988         (struct arm_per_objfile): Add constructor.
2989         <section_maps>: Change type to
2990         std::unique_ptr<arm_mapping_symbol_vec[]>.
2991         (arm_compare_mapping_symbols): Remove.
2992         (arm_find_mapping_symbol): Adjust to section_maps type change.
2993         (arm_objfile_data_free): Call delete on arm_per_objfile.
2994         (arm_record_special_symbol): Adjust to section_maps type change.
2995         Allocate arm_per_objfile with new.
2996
2997 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2998
2999         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3000         with the command prefix.
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3005         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3006
3007 2019-06-25  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3010         type.
3011         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3012         protected.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-winsource.c
3017         (tui_source_window_base::set_is_exec_point_at): Add check against
3018         LOA_ADDRESS.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-source.c (tui_set_source_content): Don't check before
3023         xfree.
3024         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3025
3026 2019-06-25  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-winsource.h (tui_update_source_window_as_is)
3029         (tui_alloc_source_buffer, tui_line_is_displayed)
3030         (tui_addr_is_displayed): Change type of win_info.
3031         * tui/tui-winsource.c (tui_update_source_window_as_is)
3032         (tui_clear_source_content, tui_show_source_line)
3033         (tui_show_source_content, tui_source_window_base::refill)
3034         (tui_source_window_base::set_is_exec_point_at)
3035         (tui_source_window_base::set_is_exec_point_at)
3036         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3037         (tui_alloc_source_buffer, tui_line_is_displayed)
3038         (tui_addr_is_displayed): Change type of win_info.  Update.
3039         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3040         (tui_source_window_base::do_make_visible_with_new_height):
3041         Update.
3042         * tui/tui-source.c (tui_set_source_content)
3043         (tui_set_source_content_nil)
3044         (tui_source_window::do_scroll_vertical): Update.
3045         * tui/tui-layout.c (show_layout): Update.
3046         * tui/tui-disasm.c (tui_set_disassem_content)
3047         (tui_disasm_window::do_scroll_vertical): Update.
3048         * tui/tui-data.h (tui_win_content): Remove.
3049         (struct tui_gen_win_info) <content, content_size>: Remove.
3050         (struct tui_source_element): Add initializers and destructor.
3051         (union tui_which_element, struct tui_win_element): Remove.
3052         (struct tui_source_window_base) <content>: New field.
3053         (struct tui_data_window): Remove destructor.
3054         (tui_alloc_content, tui_free_win_content)
3055         (tui_free_all_source_wins_content): Don't declare.
3056         * tui/tui-data.c (tui_initialize_static_data): Update.
3057         (init_content_element, tui_alloc_content): Remove.
3058         (~tui_gen_win_info): Update.
3059         (~tui_data_window, tui_free_all_source_wins_content)
3060         (tui_free_win_content, free_content, free_content_elements):
3061         Remove.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-winsource.h (tui_clear_source_content)
3066         (tui_erase_source_content, tui_show_source_content): Change type
3067         of win_info.
3068         * tui/tui-winsource.c (tui_clear_source_content)
3069         (tui_erase_source_content, tui_show_source_content): Change type
3070         of win_info.
3071         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3072         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3073         win_info.
3074         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3075         win_info.
3076         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3077
3078 2019-06-25  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-winsource.c (tui_clear_source_content)
3081         (tui_source_window_base::set_is_exec_point_at): Update.
3082         * tui/tui-source.c (tui_set_source_content_nil): Update.
3083         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3084         a bool.
3085         * tui/tui-data.c (init_content_element): Update.
3086
3087 2019-06-25  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3090         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3091         * tui/tui-layout.c (init_and_make_win): Update.
3092         * tui/tui.h (enum tui_win_type): Update.
3093         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3094         tui_win_is_auxillary.
3095         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3096         tui_win_is_auxillary.
3097
3098 2019-06-25  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3101         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3102         (tui_delete_data_content_windows, tui_display_all_data)
3103         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3104         Update.
3105         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3106         * tui/tui-regs.c (tui_last_regs_line_no)
3107         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3108         (tui_show_registers): Update.
3109         (tui_show_register_group): Return void.  Update.
3110         (tui_display_registers_from, tui_display_reg_element_at_line)
3111         (tui_display_registers_from_line, tui_check_register_values):
3112         Update.
3113         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3114         member.
3115         (struct tui_data_window) <regs_content>: Now a std::vector.
3116         <regs_content_count>: Remove.
3117         (tui_add_content_elements, tui_free_data_content): Don't declare.
3118         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3119         (init_content_element): Remove DATA_WIN case.  Add assert.
3120         (tui_add_content_elements): Remove.
3121         (tui_data_window): Update.
3122         (tui_free_data_content): Remove.
3123         (free_content_elements): Remove DATA_WIN case.
3124
3125 2019-06-25  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-data.c (tui_data_item_window): Update.
3128         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3129         * tui/tui-windata.c (tui_display_all_data)
3130         (tui_display_data_from_line): Update.
3131         (tui_check_data_values): Remove.
3132         * tui/tui-regs.c (tui_show_register_group)
3133         (tui_display_reg_element_at_line): Update.
3134         * tui/tui-hooks.c (tui_register_changed)
3135         (tui_refresh_frame_and_register_information): Call
3136         tui_check_register_values.
3137         * tui/tui-data.h (struct tui_data_window) <data_content,
3138         data_content_count, data_type>: Remove.
3139         (enum tui_data_type): Remove.
3140
3141         * tui/tui-data.c (tui_data_window::clear_detail)
3142         (~tui_data_window): Update.
3143
3144 2019-06-25  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3147         declare.
3148         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3149         Rename from tui_first_data_item_displayed.  Update.
3150         (tui_data_window::refresh_all)
3151         (tui_data_window::do_scroll_vertical): Update.
3152         * tui/tui-data.h (struct tui_data_window)
3153         <first_data_item_displayed>: Declare new method.
3154
3155 2019-06-25  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3158         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3159         contents...
3160         (tui_initialize_static_data): ...here.
3161
3162 2019-06-25  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3165         (tui_display_registers_from, tui_check_register_values): Update.
3166         (tui_display_register): Remove win_info parameter; update.
3167         (tui_get_register): Change type of parameters.
3168         * tui/tui-data.h (struct tui_data_element): Remove.
3169         (union tui_which_element) <data>: Remove.
3170         <data_window>: Change type.
3171         (struct tui_data_item_window): New.
3172         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3173         case.  Add assert.
3174         (~tui_data_item_window): New destructor.
3175         (free_content_elements): Remove DATA_ITEM_WIN case.
3176
3177 2019-06-25  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3180         Remove.
3181
3182 2019-06-25  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-data.h (struct tui_command_element): Remove.
3185         (union tui_which_element) <command>: Remove.
3186         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3187         assert.
3188         (free_content_elements): Remove CMD_WIN case.
3189
3190 2019-06-25  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-layout.c (tui_set_layout): Update.
3193         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3194         * tui/tui-data.c (layout_def): Update.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3199         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3200         (tui_source_window_base::set_new_height): Update.
3201         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3202         Update.
3203         (tui_set_locator_fullname, tui_set_locator_info)
3204         (tui_show_frame_info): Update.
3205         * tui/tui-source.c (tui_set_source_content)
3206         (tui_source_is_displayed): Update.
3207         * tui/tui-layout.c (show_source_disasm_command, show_data)
3208         (show_source_or_disasm_and_command): Update.
3209         * tui/tui-disasm.c (tui_set_disassem_content)
3210         (tui_get_begin_asm_address): Update.
3211         * tui/tui-data.h (struct tui_locator_element): Remove.
3212         (union tui_which_element) <locator>: Remove.
3213         (struct tui_locator_window): New.
3214         (tui_locator_win_info_ptr): Change return type.
3215         * tui/tui-data.c (_locator): Change type.
3216         (tui_locator_win_info_ptr): Change return type.
3217         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3218         (tui_alloc_content): Add assert.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-winsource.c
3223         (tui_exec_info_window::maybe_allocate_content): New method.
3224         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3225         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3226         (make_source_or_disasm_window): Add cast.
3227         * tui/tui-data.h (union tui_which_element) <simple_string>:
3228         Remove.
3229         (struct tui_source_info): New.
3230         (struct tui_source_window_base) <execution_info>: Change type.
3231         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3232         case, and add assert.
3233         (tui_alloc_content): Add assert.
3234
3235 2019-06-25  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3238         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3239         * tui/tui-data.c (tui_alloc_win_info): Remove.
3240
3241 2019-06-25  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3244         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3245         can_highlight.
3246
3247 2019-06-25  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3250         make_visible_with_new_height method.
3251         (tui_win_info::make_visible_with_new_height): New method.
3252         (tui_source_window_base::do_make_visible_with_new_height)
3253         (tui_data_window::do_make_visible_with_new_height)
3254         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3255         (make_visible_with_new_height): Remove.
3256         (tui_resize_all, tui_adjust_win_heights): Use
3257         make_visible_with_new_height method.
3258         * tui/tui-data.h (struct tui_win_info)
3259         <do_make_visible_with_new_height, make_visible_with_new_height>:
3260         New methods.
3261         (struct tui_source_window_base, struct tui_data_window)
3262         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3263         methods.
3264
3265 2019-06-25  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3268         method.
3269         (update_tab_width): Call update_tab_width method.
3270         * tui/tui-data.h (struct tui_win_info)
3271         (struct tui_source_window_base) <update_tab_width>: New methods.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3276         parameter.
3277         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3278         parameter.
3279         (tui_gen_win_info::make_visible): Update.
3280         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3281         parameter.
3282         * tui/tui-data.h (enum tui_box): New enum.
3283         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3284
3285 2019-06-25  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3288         init_and_make_win for EXEC_INFO_WIN.
3289         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3290         longer inline.
3291         (struct tui_win_info) <~tui_win_info>: Inline.
3292         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3293         Don't declare.
3294         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3295         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3296         Remove.
3297         (tui_initialize_static_data): Update.
3298         (~tui_gen_win_info): Handle more cleanup here.
3299         (~tui_source_window_base): Delete "execution_info".
3300         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-layout.c (make_command_window): Don't set
3305         can_highlight.
3306         (show_source_disasm_command): Call the reset method.
3307         (show_data): Don't set can_highlight.  Call the reset method.
3308         (tui_gen_win_info::reset): Rename from init_gen_win_info
3309         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3310         (show_source_or_disasm_and_command): Call the reset method.
3311         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3312         (struct tui_cmd_window): Set can_highlight.
3313
3314 2019-06-25  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3317         from make_visible.
3318         (tui_make_visible, tui_make_invisible): Rewrite.
3319         (tui_win_info::make_visible): Remove.
3320         (tui_source_window_base::make_visible): Update.
3321         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3322         method.  Moved from...
3323         (struct tui_win_info) <make_visible>: ...here.
3324
3325 2019-06-25  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.c
3328         (tui_source_window_base::do_scroll_horizontal): Remove direction
3329         parameter.
3330         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3331         direction parameter.
3332         * tui/tui-win.c (tui_win_info::forward_scroll)
3333         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3334         (tui_win_info::right_scroll): Update.
3335         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3336         direction parameter.
3337         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3338         direction parameter.
3339         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3340         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3341         Remove direction parameter.
3342         (struct tui_source_window_base, struct tui_source_window)
3343         (struct tui_disasm_window, struct tui_data_window)
3344         (struct tui_cmd_window): Update.
3345
3346 2019-06-25  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-winsource.h (tui_set_exec_info_content)
3349         (tui_show_exec_info_content, tui_erase_exec_info_content)
3350         (tui_clear_exec_info_content, tui_update_exec_info): Change
3351         argument to tui_source_window_base.
3352         * tui/tui-winsource.c (tui_set_exec_info_content)
3353         (tui_show_exec_info_content, tui_erase_exec_info_content)
3354         (tui_clear_exec_info_content, tui_update_exec_info): Change
3355         argument to tui_source_window_base.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3360         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3365         check.
3366
3367 2019-06-25  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3370         type to void.
3371         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3372         type to void.
3373         * tui/tui-source.c (tui_set_source_content): Update.
3374         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-win.c (window_name_completer, tui_set_focus)
3379         (tui_all_windows_info): Use name method.
3380         * tui/tui-data.h (struct tui_gen_win_info)
3381         (struct tui_source_window, struct tui_disasm_window)
3382         (struct tui_data_window, struct tui_cmd_window) <name>: New
3383         method.
3384         (tui_win_name): Don't declare.
3385         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3386         (tui_win_name): Remove.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-winsource.h (tui_update_source_window)
3391         (tui_update_source_window_as_is): Change parameter type.
3392         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3393         to be a tui_source_window_base.
3394         (tui_update_source_window_as_is): Likewise.
3395         * tui/tui-win.c (make_visible_with_new_height): Update.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-winsource.c (tui_erase_source_content)
3400         (tui_show_source_content, tui_show_exec_info_content)
3401         (tui_erase_exec_info_content): Use refresh_window method.
3402         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3403         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3404         from tui_refresh_win.
3405         (tui_data_window::refresh_window): New method.
3406         (tui_win_info::refresh, tui_source_window_base::refresh)
3407         (tui_refresh_all): Use refresh_window method.
3408         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3409         method.
3410         * tui/tui-regs.c (tui_display_register): Call refresh_window
3411         method.
3412         * tui/tui-layout.c (show_source_disasm_command)
3413         (show_source_or_disasm_and_command): Call refresh_window method.
3414         * tui/tui-data.h (struct tui_gen_win_info)
3415         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3416         New method.
3417
3418 2019-06-25  Tom Tromey  <tom@tromey.com>
3419
3420         * tui/tui.c (tui_rl_other_window, tui_enable)
3421         (tui_is_window_visible, tui_get_command_dimension): Update.
3422         * tui/tui-winsource.c (tui_update_source_window_as_is)
3423         (tui_clear_source_content, tui_erase_source_content)
3424         (tui_show_source_line, tui_source_window_base::refill)
3425         (tui_source_window_base::do_scroll_horizontal)
3426         (tui_source_window_base::set_is_exec_point_at)
3427         (tui_update_breakpoint_info, tui_set_exec_info_content)
3428         (tui_alloc_source_buffer, tui_line_is_displayed)
3429         (tui_addr_is_displayed): Update.
3430         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3431         (tui_check_and_display_highlight_if_needed)
3432         (tui_win_info::make_visible, tui_win_info::refresh)
3433         (tui_refresh_all): Update.
3434         * tui/tui-windata.c (tui_first_data_item_displayed)
3435         (tui_delete_data_content_windows, tui_erase_data_content)
3436         (tui_display_all_data, tui_data_window::refresh_all)
3437         (tui_check_data_values): Update.
3438         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3439         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3440         (tui_win_info::backward_scroll, tui_refresh_all_win)
3441         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3442         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3443         (tui_source_window_base::set_new_height)
3444         (tui_data_window::set_new_height)
3445         (make_invisible_and_set_new_height)
3446         (make_visible_with_new_height, new_height_ok)
3447         (parse_scrolling_args): Update.
3448         * tui/tui-stack.c (tui_show_frame_info): Update.
3449         * tui/tui-source.c (tui_set_source_content)
3450         (tui_set_source_content_nil, tui_source_is_displayed)
3451         (tui_source_window::do_scroll_vertical): Update.
3452         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3453         (tui_display_registers_from, tui_display_reg_element_at_line)
3454         (tui_check_register_values, tui_reg_command): Update.
3455         * tui/tui-layout.c (tui_default_win_height)
3456         (show_source_disasm_command, show_data, init_and_make_win)
3457         (show_source_or_disasm_and_command): Update.
3458         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3459         (tui_redisplay_readline, tui_mld_flush)
3460         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3461         (tui_getc): Update.
3462         * tui/tui-disasm.c (tui_set_disassem_content)
3463         (tui_disasm_window::do_scroll_vertical): Update.
3464         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3465         Now virtual.
3466         (struct tui_win_info): Derive from tui_gen_win_info.
3467         <~tui_win_info>: Mark as override.
3468         <generic>: Remove member.
3469         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3470         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3471         (~tui_data_window, ~tui_win_info)
3472         (tui_free_all_source_wins_content): Update.
3473         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3474
3475 2019-06-25  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-layout.c (init_and_make_win): Use new.
3478         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3479         destructor, initializers.
3480         (tui_alloc_generic_win_info): Don't declare.
3481         * tui/tui-data.c (_locator): Add argument to constructor.
3482         (source_win, disasm_win): New globals.
3483         (exec_info): Remove.
3484         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3485         Update.
3486         (tui_alloc_generic_win_info): Remove.
3487         (init_content_element): Use new.
3488         (tui_win_info::tui_win_info): Update.
3489         (free_content_elements) <case DATA_WIN>: Use delete.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3494         * tui/tui-windata.c (tui_first_data_item_displayed)
3495         (tui_delete_data_content_windows): Update.
3496         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3497         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3498         (tui_display_registers_from, tui_check_register_values): Update.
3499         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3500         pointer.
3501         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3502         window.
3503         (tui_free_data_content): Update.
3504         (free_content_elements) <case DATA_WIN>: Free the window.
3505
3506 2019-06-25  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3509         Update.
3510         * tui/tui-layout.c (make_command_window)
3511         (show_source_disasm_command, show_data, init_and_make_win)
3512         (show_source_or_disasm_and_command): Update.
3513         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3514         method.
3515         <can_highight, is_highlighted>: Now bool.
3516         (tui_set_win_highlight): Don't declare.
3517         * tui/tui-data.c (tui_set_win_highlight): Remove.
3518
3519 2019-06-25  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-wingeneral.c (make_visible): Remove check of window
3522         type.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-win.c (tui_win_info::max_height)
3527         (tui_cmd_window::max_height): New methods.
3528         (new_height_ok): Call max_height.
3529         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3530         <max_height>: New method.
3531
3532 2019-06-25  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-win.c (tui_source_window_base::set_new_height)
3535         (tui_data_window::set_new_height): New methods.
3536         (make_invisible_and_set_new_height): Call set_new_height method.
3537         * tui/tui-data.h (struct tui_win_info)
3538         (struct tui_source_window_base, struct tui_data_window)
3539         <set_new_height>: New method.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3544         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3545         tui_refresh_data_win.
3546         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3547         method.
3548         (tui_refresh_all_win): Call the refresh_all method.
3549         (tui_set_focus): Likewise.
3550         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3551         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3552         Likewise.
3553
3554 2019-06-25  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-winsource.h (tui_refill_source_window)
3557         (tui_set_is_exec_point_at): Don't declare.
3558         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3559         (tui_source_window_base::refill): Rename from
3560         tui_refill_source_window.
3561         (tui_source_window_base::do_scroll_horizontal): Update.
3562         (tui_source_window_base::set_is_exec_point_at): Rename from
3563         tui_set_is_exec_point_at.
3564         (tui_update_all_breakpoint_info): Update.
3565         * tui/tui-stack.c (tui_show_frame_info): Update.
3566         * tui/tui-layout.c (show_data): Add cast.
3567         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3568         * tui/tui-data.h (struct tui_source_window_base) <refill,
3569         set_is_exec_point_at>: New methods.
3570         (tui_source_windows, tui_add_to_source_windows): Update types.
3571         (tui_add_to_source_windows): Remove redundant declaration.
3572         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3573         (tui_source_windows): Change return type.
3574         (tui_clear_source_windows_detail): Update.
3575         (tui_add_to_source_windows): Change type of parameter.
3576         (tui_free_all_source_wins_content): Update.
3577
3578 2019-06-25  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-wingeneral.c (tui_win_info::refresh)
3581         (tui_source_window_base::refresh): New methods.
3582         (tui_refresh_all): Call the refresh method.
3583         * tui/tui-data.h (struct tui_win_info)
3584         (struct tui_source_window_base) <refresh>: New method.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui.h (tui_is_window_visible): Return bool.
3589         * tui/tui.c (tui_is_window_visible): Return bool.
3590         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3591         (tui_make_visible, tui_make_invisible)
3592         (tui_win_info::make_visible)
3593         (tui_source_window_base::make_visible, make_all_visible)
3594         (tui_make_all_visible, tui_make_all_invisible): Update.
3595         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3596         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3597         bool.
3598         (struct tui_win_info, struct tui_source_window_base)
3599         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3600         * tui/tui-data.c (tui_init_generic_part): Update.
3601
3602 2019-06-25  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3605         (tui_source_window_base::make_visible): New methods.
3606         (make_all_visible): Make method call.
3607         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3608         (struct tui_source_window_base, struct tui_cmd_window): Override
3609         make_visible.
3610         (tui_win_is_source_type): Don't declare.
3611         * tui/tui-data.c (tui_win_is_source_type): Remove.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3616         NULL check.
3617
3618 2019-06-25  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3621         Inline constructor.  Add initializers for members.
3622         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3623         constructors; now inline in class.
3624
3625 2019-06-25  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-regs.c (tui_show_registers): Update.
3628         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3629         bool.
3630         * tui/tui-data.c (tui_data_window::clear_detail)
3631         (tui_data_window): Update.
3632
3633 2019-06-25  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-windata.c (tui_display_all_data)
3636         (tui_display_data_from_line, tui_display_data_from)
3637         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3638         Update.
3639         * tui/tui-regs.c (tui_last_regs_line_no)
3640         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3641         (tui_show_registers, tui_show_register_group)
3642         (tui_display_registers_from, tui_display_reg_element_at_line)
3643         (tui_display_registers_from_line, tui_check_register_values)
3644         (tui_reg_next, tui_reg_prev): Update.
3645         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3646         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3647         tui_data_window.
3648         (struct tui_win_info) <detail>: Remove.  Add new fields from
3649         tui_data_info.
3650         (TUI_DATA_WIN): Add cast.
3651         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3652         (~tui_data_window): Simplify.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-layout.c (show_source_disasm_command)
3657         (show_source_or_disasm_and_command): Update.
3658         * tui/tui-io.c (update_cmdwin_start_line)
3659         (tui_redisplay_readline): Update.
3660         * tui/tui-data.h (struct tui_command_info): Remove.
3661         (struct tui_win_info) <detail>: Remove command_info member.
3662         (struct tui_data_window) <start_line>: New member, from
3663         tui_command_info.
3664         (TUI_CMD_WIN): Add casts.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-winsource.c (tui_update_source_window)
3669         (tui_refill_source_window)
3670         (tui_source_window_base::do_scroll_horizontal)
3671         (tui_update_breakpoint_info, tui_set_exec_info_content)
3672         (tui_show_exec_info_content, tui_erase_exec_info_content)
3673         (tui_clear_exec_info_content): Update.
3674         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3675         Update.
3676         * tui/tui-win.c (make_invisible_and_set_new_height)
3677         (make_visible_with_new_height): Update.
3678         * tui/tui-source.c (tui_set_source_content)
3679         (tui_show_symtab_source): Update.
3680         * tui/tui-layout.c (extract_display_start_addr)
3681         (show_source_disasm_command, show_data)
3682         (make_source_or_disasm_window)
3683         (show_source_or_disasm_and_command): Update.
3684         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3685         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3686         "gdbarch".
3687         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3688         to tui_source_window_base.
3689         (struct tui_win_info) <detail>: Remove source_info member.
3690         (struct tui_source_window_base) <has_locator>: Inline.
3691         Move contents from tui_source_info; rename has_locator member to
3692         m_has_locator.
3693         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3694         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3695         header file.
3696         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3697         Simplify.
3698         (tui_free_all_source_wins_content): Cast to
3699         tui_source_window_base.
3700
3701 2019-06-25  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-win.c (make_invisible_and_set_new_height)
3704         (make_visible_with_new_height): Call has_locator method.
3705         * tui/tui-layout.c (show_source_disasm_command, show_data)
3706         (show_source_or_disasm_and_command): Update for bool change.
3707         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3708         (tui_win_info) <has_locator>: New method.
3709         (struct tui_source_window_base) <has_locator>: New method.
3710         (tui_win_has_locator): Don't declare.
3711         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3712         from tui_win_has_locator.
3713         (tui_source_window_base): Use false, not FALSE.
3714
3715 2019-06-25  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3718         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3719         clear_detail method directly.
3720         (tui_clear_win_detail): Remove.
3721
3722 2019-06-25  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3725         "this", not TUI_DISASM_WIN.
3726
3727 2019-06-25  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3730         declare.
3731         * tui/tui-winsource.c
3732         (tui_source_window_base::do_scroll_horizontal): Rename from
3733         tui_horizontal_source_scroll.
3734         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3735         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3736         from tui_vertical_data_scroll.
3737         * tui/tui-win.h (tui_scroll): Don't declare.
3738         * tui/tui-win.c (tui_win_info::forward_scroll)
3739         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3740         (tui_win_info::right_scroll): Rename and update.
3741         (tui_scroll_forward_command, tui_scroll_backward_command)
3742         (tui_scroll_left_command, tui_scroll_right_command): Update.
3743         (tui_scroll): Remove.
3744         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3745         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3746         from tui_vertical_source_scroll.
3747         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3748         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3749         from tui_vertical_disassem_scroll.
3750         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3751         do_scroll_horizontal>: New methods.
3752         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3753         Likewise.
3754         (struct tui_source_window_base): Add do_scroll_horizontal.
3755         (struct tui_source_window, struct tui_disasm_window): Add
3756         do_scroll_vertical.
3757         (struct tui_data_window, struct tui_cmd_window): Add
3758         do_scroll_horizontal and do_scroll_vertical.
3759         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3760
3761 2019-06-25  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-data.h (struct tui_source_window_base): New struct.
3764         (struct tui_source_window): Derive from tui_source_window_base.
3765         (struct tui_disasm_window): New struct.
3766         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3767         from tui_source_window::clear_detail.
3768         (tui_source_window_base): Rename from tui_source_window.
3769         (~tui_source_window_base): Rename from ~tui_source_window.
3770         (tui_alloc_win_info): Create a tui_disasm_window.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-data.h (struct tui_source_window)
3775         (struct tui_data_window): Declare destructors.
3776         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3777         destructors.
3778         (tui_win_info): Simplify.
3779
3780 2019-06-25  Tom Tromey  <tom@tromey.com>
3781
3782         * tui/tui-winsource.c (tui_display_main)
3783         (tui_update_source_windows_with_addr)
3784         (tui_update_all_breakpoint_info): Update.
3785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3786         (new_height_ok, parse_scrolling_args): Update.
3787         * tui/tui-stack.c (tui_show_frame_info): Update.
3788         * tui/tui-data.h (struct tui_list): Remove.
3789         (tui_source_windows): Return a reference to a std::vector.
3790         * tui/tui-data.c (source_windows): Now a std::vector.
3791         (tui_source_windows): Change return type.
3792         (tui_clear_source_windows): Rewrite.
3793         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3794         (tui_free_all_source_wins_content): Rewrite.
3795
3796 2019-06-25  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3799         (struct tui_data_window, struct tui_cmd_window): Declare
3800         clear_detail method.
3801         * tui/tui-data.c (tui_source_window::clear_detail)
3802         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3803         methods.
3804         (tui_clear_win_detail): Simplify.
3805
3806 2019-06-25  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-layout.c (make_source_window, make_disasm_window)
3809         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3810         Return the new window.
3811         (show_source_disasm_command, show_data)
3812         (show_source_or_disasm_and_command): Update.
3813
3814 2019-06-25  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3817         parameter.  Return the new window.
3818         (show_source_disasm_command): Update and remove NULL check.
3819         (show_source_or_disasm_and_command): Update.
3820
3821 2019-06-25  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-data.h (struct tui_win_info): Make constructor
3828         protected.  Make destructor virtual.  Add initializers.
3829         (tui_source_window, tui_data_window, tui_cmd_window): New
3830         classes.
3831         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3832         constructor.  Add "type" parameter.
3833         (tui_source_window, tui_data_window, tui_cmd_window): New
3834         constructors.
3835         (tui_alloc_win_info): Instantiate the appropriate subclass.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-win.c (tui_resize_all): Use delete.
3840         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3841         destructor.
3842         (tui_free_window): Don't declare.
3843         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3844         Update.
3845
3846 2019-06-25  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-data.h (struct tui_win_info): Add constructor.
3849         * tui/tui-data.c (tui_alloc_win_info): Use new.
3850         (tui_free_window): Use delete.
3851
3852 2019-06-22  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3855         declare.
3856         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3857
3858 2019-06-22  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3861         declare.
3862         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3863
3864 2019-06-22  Tom de Vries  <tdevries@suse.de>
3865
3866         * dwarf2read.c (create_addrmap_from_aranges)
3867         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3868         instead of '%zu'.
3869
3870 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3871
3872         * dwarf2read.h (dwarf2_section_info_def): Remove.
3873         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3874         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3875         std::vector<dwarf2_section_info>.
3876         (struct dwo_file) <~dwo_file>: Remove.
3877         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3878         types field.
3879         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3880         (dwarf2_read_debug_names): Likewise.
3881         (create_debug_types_hash_table): Change parameter type to
3882         array_view, adjust code accordingly.
3883         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3884         (partial_die_info::fixup): Likewise.
3885         (determine_prefix): Likewise.
3886         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3887
3888 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3889
3890         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3891         gdb_bfd_ref_ptr.
3892         <~dwo_file>: Remove call to gdb_bfd_unref.
3893         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3894         gdb_bfd_ref_ptr::get.
3895
3896 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3897
3898         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3899         type to htab_up.
3900         * dwarf2read.c (struct dwo_file): Initialize fields.
3901         <~dwo_file>: New.
3902         (free_dwo_file): Remove, move content to ~dwo_file.
3903         (struct dwo_file_deleter): Remove.
3904         (dwo_file_up>: Remove custom deleter.
3905         (free_dwo_files): Remove.
3906         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3907         dwo_files.
3908         (process_skeletonless_type_units): Call unique_ptr::get.
3909         (allocate_dwo_file_hash_table): Add deleter to created hash
3910         table.  Change return type to htab_up.
3911         (lookup_dwo_file_slot): Don't memset dwo_file, call
3912         unique_ptr::get.
3913         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3914         (create_dwo_unit_in_dwp_v2): Likewise.
3915         (open_and_init_dwo_file): Likewise.
3916         (free_dwo_file_from_slot): Remove.
3917
3918 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3919
3920         * dwarf2read.h (struct dwarf2_section_info) <readin,
3921         is_virtual>: Change type to bool.
3922         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3923         true instead of 1.
3924
3925 2019-06-19  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-data.h (tui_init_content_element): Don't declare.
3928
3929 2019-06-19  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-data.h (tui_init_win_info): Don't declare.
3932
3933 2019-06-19  Tom de Vries  <tdevries@suse.de>
3934
3935         * dwarf2read.h (abstract_to_concrete): Change type to
3936         std::unordered_map<sect_offset, std::vector<sect_offset>,
3937         gdb::hash_enum<sect_offset>>.
3938
3939 2019-06-19  Tom Tromey  <tromey@adacore.com>
3940
3941         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3942         EVAL_AVOID_SIDE_EFFECTS specially.
3943
3944 2019-06-19  Tom Tromey  <tromey@adacore.com>
3945
3946         * source-cache.c (highlighter): New global.
3947         (source_cache::get_source_lines): Create a highlighter on demand.
3948
3949 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * defs.h (deprecated_interactive_hook): Delete declaration.
3952         * interps.c (clear_interpreter_hooks): Remove use of
3953         deprecated_interactive_hook.
3954         * top.c (deprecated_interactive_hook): Delete definition.
3955         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3956
3957 2019-06-18  Tom de Vries  <tdevries@suse.de>
3958
3959         PR gdb/24515
3960         * dwarf2read.h (abstract_to_concrete): Change type from
3961         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3962         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3963         * dwarf2read.c (read_variable): Update.
3964         (dwarf2_fetch_die_loc_sect_off): Update.
3965
3966 2019-06-17  Tom de Vries  <tdevries@suse.de>
3967
3968         PR gdb/24617
3969         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3970         accessing parent[parent_len - 1].
3971
3972 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3973
3974         PR gdb/24364
3975         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3976         call dtrace_process_dof with NULL dof.
3977
3978 2019-06-16  Tom de Vries  <tdevries@suse.de>
3979
3980         PR gdb/24445
3981         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3982
3983 2019-06-16  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3986         (make_all_visible): Use address of member.
3987
3988 2019-06-16  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3991         (tui_free_window, free_content, free_content_elements): Remove
3992         unnecessary cast.
3993         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3994         cast.
3995         * tui/tui-regs.c (tui_show_register_group)
3996         (tui_display_registers_from, tui_display_reg_element_at_line):
3997         Remove unnecessary cast.
3998
3999 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * linux-nat.c (normal_mask): Delete.
4002         (_initialize_linux_nat): Don't initialise normal_mask.
4003
4004 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4005
4006         PR gdb/24445
4007         * dwarf-index-write.h (write_psymtabs_to_index): Add
4008         dwz_basename parameter.
4009         * dwarf-index-write.c (write_gdbindex): Move file writing to
4010         write_gdbindex_1.  Change return type void.
4011         (assert_file_size): Move up, remove filename parameter.
4012         (write_gdbindex_1): New function.
4013         (write_debug_names): Change return type to void, call
4014         assert_file_size.
4015         (struct index_wip_file): New struct.
4016         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4017         file logic to index_wip_file.  Write index for dwz file if
4018         needed.
4019         (save_gdb_index_command): Pass basename of dwz file, if present.
4020         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4021         build-id of dwz file, if present.
4022         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4023         (dwarf2_get_dwz_file): Likewise.
4024         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4025         (dwarf2_get_dwz_file): Likewise.
4026
4027 2019-06-16  Tom Tromey  <tom@tromey.com>
4028
4029         * coffread.c (process_coff_symbol): Use xstrdup.
4030         * value.c (create_internalvar): Use xstrdup.
4031
4032 2019-06-16  Tom Tromey  <tom@tromey.com>
4033
4034         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4035         * breakpoint.c (stopin_command, stopat_command)
4036         (until_break_command, decode_location_default): Remove unnecessary
4037         cast.
4038         * utils.c (subset_compare): Remove unnecessary cast.
4039         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4040         cast.
4041         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4042         cast.
4043         * infcmd.c (path_command): Remove unnecessary cast.
4044         * coffread.c (decode_type): Remove unnecessary cast.
4045         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4046         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4047         * tui/tui-stack.c (tui_show_locator_content)
4048         (tui_show_frame_info): Remove unnecessary cast.
4049         * tui/tui-win.c (tui_scroll_forward_command)
4050         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4051         (parse_scrolling_args): Remove unnecessary cast.
4052         * tui/tui-data.c (init_win_info, tui_del_window)
4053         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4054         (free_content_elements): Remove unnecessary cast.
4055         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4056         unnecessary cast.
4057         * tui/tui-source.c (tui_set_source_content)
4058         (tui_vertical_source_scroll): Remove unnecessary cast.
4059         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4060         cast.
4061         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4062         * tui/tui-regs.c (tui_display_registers_from)
4063         (tui_display_register): Remove unnecessary cast.
4064         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4065         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4066         (make_visible): Remove unnecessary cast.
4067         * tui/tui-winsource.c (tui_erase_source_content)
4068         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4069         unnecessary cast.
4070         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4071         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4072         * stabsread.c (read_type, read_array_type, read_range_type):
4073         Remove unnecessary cast.
4074         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4075         (parse_symbol, parse_type, upgrade_type, parse_external)
4076         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4077         unnecessary cast.
4078         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4079
4080 2019-06-16  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui-data.c (tui_alloc_generic_win_info)
4083         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4084         checks.
4085
4086 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4087             Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * f-typeprint.c (f_print_type): Don't return early for not
4090         associated or not allocated types.
4091         (f_type_print_varspec_suffix): Add print_rank parameter and print
4092         ranks of array types in case they dangling.
4093         (f_type_print_base): Add print_rank parameter.
4094
4095 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * NEWS: Mention new MI commands.
4098         * break-catch-throw.c (enum exception_event_kind): Move to
4099         breakpoint.h.
4100         (print_mention_exception_catchpoint): Output text as a single
4101         message.
4102         (catch_exception_command_1): Rename to...
4103         (catch_exception_event): ...this, make non-static, update header
4104         command, and change some parameter types.
4105         (catch_catch_command): Update for changes to
4106         catch_exception_command_1.
4107         (catch_throw_command): Likewise.
4108         (catch_rethrow_command): Likewise.
4109         * breakpoint.c (enum exception_event_kind): Delete.
4110         * breakpoint.h (enum exception_event_kind): Moved here from
4111         break-catch-throw.c.
4112         (catch_exception_event): Declare.
4113         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4114         (mi_cmd_catch_throw): New function.
4115         (mi_cmd_catch_rethrow): New function.
4116         (mi_cmd_catch_catch): New function.
4117         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4118         'catch-catch' entries.
4119         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4120         (mi_cmd_catch_rethrow): Declare.
4121         (mi_cmd_catch_catch): Declare.
4122
4123 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4124
4125         * annotate.c (annotate_source_line): Change return type to void,
4126         update implementation to match.
4127         * annotate.h (annotate_source_line): Change return type to void,
4128         update header comment.
4129         * stack.c (print_frame_info): Don't change what frame information
4130         is printed based on whether annotations are on or not.
4131
4132 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4135         (annotate_source): Make static.
4136         (annotate_source_line): Moved from source.c and renamed from
4137         identify_source_line.  Update the return type.
4138         * annotate.h (annotate_source): Delete declaration.
4139         (annotate_source_line): Declaration moved from source.h, and
4140         renamed from identify_source_line.  Return type updated.
4141         * source.c (identify_source_line): Moved to annotate.c and renamed
4142         to annotate_source_line.
4143         (info_line_command): Remove check of annotation_level.
4144         * source.h (identify_source_line): Move declaration to annotate.h
4145         and rename to annotate_source_line.
4146         * stack.c: Add 'annotate.h' include.
4147         (print_frame_info): Remove check of annotation_level before
4148         calling annotate_source_line.
4149
4150 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4151
4152         * source-cache.c (source_cache::get_plain_source_lines): Use
4153         open_source_file_with_line_charpos instead of just
4154         open_source_file, remove call to find_source_lines.
4155         (source_cache::get_source_lines): Likewise.
4156         * source.c (find_source_lines): Make static.
4157         (get_filename_and_charpos): Renamed into...
4158         (open_source_file_with_line_charpos): ..this along with changes to
4159         return a scoped_fd, and some other minor clean ups.
4160         (identify_source_line): Use open_source_file_with_line_charpos.
4161         (search_command_helper): Use open_source_file_with_line_charpos
4162         instead of just open_source_file, remove call to
4163         find_source_lines.
4164         * source.h (open_source_file_with_line_charpos): Declare new
4165         function.
4166         (find_source_lines): Delete declaration.
4167
4168 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * source.c (get_filename_and_charpos): Remove fullname
4171         parameter.
4172         (identify_source_line): Update call to get_filename_and_charpos.
4173
4174 2019-06-14  Tom Tromey  <tromey@adacore.com>
4175
4176         PR gdb/24502:
4177         * ui-style.h (skip_ansi_escape): Update comment.
4178         * ui-file.h (class no_terminal_escape_file): New class.
4179         * ui-file.c (no_terminal_escape_file::write)
4180         (no_terminal_escape_file::puts): New methods.
4181         * cli/cli-logging.c (handle_redirections): Use
4182         no_terminal_escape_file.
4183
4184 2019-06-14  Tom Tromey  <tromey@adacore.com>
4185
4186         * NEWS: Move convenience variable news above Python news.
4187
4188 2019-06-14  Tom Tromey  <tom@tromey.com>
4189
4190         * gnulib: Move directory to top-level.
4191         * configure.ac: Don't configure gnulib.
4192         * configure: Rebuild.
4193         * common/common-defs.h: Use new path to gnulib.
4194         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4195         (GNULIB_H): Remove.
4196         (INCGNU): Look in new gnulib location.
4197         (HFILES_NO_SRCDIR): Remove gnulib files.
4198         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4199         (generated_files): Remove GNULIB_H.
4200         ($(LIBGNU), all-lib): Remove targets.
4201         (distclean): Don't mention GNULIB_BUILDDIR.
4202         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4203
4204 2019-06-14  Tom Tromey  <tromey@adacore.com>
4205
4206         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4207         Warn if symbol file does not provide any symbols.
4208
4209 2019-06-14  Tom Tromey  <tromey@adacore.com>
4210
4211         * source.c (find_and_open_source): Respect basenames_may_differ.
4212
4213 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * annotate.c (annotate_breakpoints_invalid): Make use of
4216         scoped_restore_terminal_state.
4217         (annotate_frames_invalid): Likewise.
4218
4219 2019-06-14  Tom Tromey  <tromey@adacore.com>
4220
4221         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4222         allow assignment to an internalvar.
4223
4224 2019-06-14  Tom Tromey  <tromey@adacore.com>
4225
4226         * ada-lex.l: Allow "_" in attribute names.
4227
4228 2019-06-14  Tom Tromey  <tromey@adacore.com>
4229
4230         PR gdb/24653:
4231         * regcache.c (registers_changed): Don't call alloca.
4232         * top.c (execute_command): Don't call alloca.
4233
4234 2019-06-13  Pedro Alves  <palves@redhat.com>
4235
4236         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4237         'expression'.  When parsing an expression, error out if there's
4238         junk after "unlimited".
4239         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4240         (do_set_command): Adjust calls to is_unlimited_literal.
4241
4242 2019-06-13  Pedro Alves  <palves@redhat.com>
4243
4244         * compile/compile.c (make_compile_options_def_group): Add braces
4245         around array_view initializer.
4246         * thread.c (make_thread_apply_all_options_def_group)
4247         (make_thread_apply_all_options_def_group): Likewise.
4248
4249 2019-06-13  Pedro Alves  <palves@redhat.com>
4250
4251         * NEWS (New commands): Mention "maint test-options
4252         require-delimiter", "maint test-options unknown-is-error", "maint
4253         test-options unknown-is-operand" and "maint show
4254         test-options-completion-result".
4255         (New command options, command completion): New section.
4256         (Completion improvements): New section.
4257         Mention that you can abbreviate "unlimited".
4258
4259 2019-06-13  Pedro Alves  <palves@redhat.com>
4260
4261         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4262         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4263         * unittests/cli-utils-selftests.c (test_parse_flags)
4264         (test_parse_flags_qcs): Delete.
4265         (test_cli_utils): Don't call deleted functions.
4266
4267 2019-06-13  Pedro Alves  <palves@redhat.com>
4268
4269         * thread.c: Include "cli/cli-option.h".
4270         (tp_array_compar_ascending): Global.
4271         (tp_array_compar): Delete function.
4272         (tp_array_compar_ascending, tp_array_compar_descending): New
4273         functions.
4274         (ascending_option_def, qcs_flag_option_def)
4275         (thr_qcs_flags_option_defs)
4276         (make_thread_apply_all_options_def_group)
4277         (make_thread_apply_options_def_group): New.
4278         (thread_apply_all_command): Use gdb::option::process_options.
4279         (thread_apply_command_completer)
4280         (thread_apply_all_command_completer): New.
4281         (thread_apply_command): Use gdb::option::process_options.
4282         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4283         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4284         to generate help text of "thread apply".  Adjust "taas"'s help.
4285         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4286         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4287
4288 2019-06-13  Pedro Alves  <palves@redhat.com>
4289
4290         * thread.c (thread_apply_command): Check for invalid TID with
4291         isdigit instead of !isalpha.
4292
4293 2019-06-13  Pedro Alves  <palves@redhat.com>
4294
4295         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4296         (validate_flags_qcs): New.
4297         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4298         (validate_flags_qcs): Declare.
4299         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4300         (make_frame_apply_options_def_group): New.
4301         (frame_apply_command_count): Process options with
4302         gdb::option::process_options.
4303         (frame_apply_completer): New.
4304         (frame_apply_level_completer, frame_apply_all_completer)
4305         (frame_apply_completer): New.
4306         (_initialize_stack): Update help of "frame apply", "frame apply
4307         level", "frame apply all" and "faas" to mention supported options
4308         and install command completers.
4309         * stack.h (frame_apply_all_completer): Declare.
4310         * thread.c: Include "stack.h".
4311         (tfaas_command): Add "--".
4312         (_initialize_thread): Update help "tfaas" to mention supported
4313         options and install command completer.
4314
4315 2019-06-13  Pedro Alves  <palves@redhat.com>
4316
4317         * completer.c (complete_nested_command_line): New.
4318         (gdb_completion_word_break_characters_throw): Add assertion.
4319         * completer.h (complete_nested_command_line): Declare.
4320
4321 2019-06-13  Pedro Alves  <palves@redhat.com>
4322
4323         * stack.c (parse_backtrace_qualifiers): New.
4324         (backtrace_command): Use it.
4325         (backtrace_command_completer): Complete on qualifiers.
4326
4327 2019-06-13  Pedro Alves  <palves@redhat.com>
4328
4329         * frame.c: Include "cli/cli-option.h.
4330         (user_set_backtrace_options): New.
4331         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4332         Delete.
4333         (get_prev_frame): Adjust.
4334         (boolean_option_def, uinteger_option_def)
4335         (set_backtrace_option_defs): New.
4336         (_initialize_frame): Adjust and use
4337         gdb::option::add_setshow_cmds_for_options to install "set
4338         backtrace past-main" and "set backtrace past-entry".
4339         * frame.h: Include "cli/cli-option.h".
4340         (struct frame_print_options): Forward declare.
4341         (print_frame_arguments_all, print_frame_arguments_scalars)
4342         (print_frame_arguments_none): Declare.
4343         (print_entry_values): Delete declaration.
4344         (struct frame_print_options, user_frame_print_options): New.
4345         (struct set_backtrace_options): New.
4346         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4347         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4348         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4349         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4350         (list_args_or_locals): Add frame_print_options parameter.
4351         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4352         * python/py-framefilter.c (enumerate_args): Pass down
4353         USER_FRAME_PRINT_OPTIONS.
4354         * stack.c: Include "cli/cli-option.h".
4355         (print_frame_arguments_all, print_frame_arguments_scalars)
4356         (print_frame_arguments_none): Declare.
4357         (print_raw_frame_arguments, print_entry_values): Delete.
4358         (user_frame_print_options): New.
4359         (boolean_option_def, enum_option_def, frame_print_option_defs):
4360         New.
4361         (struct backtrace_cmd_options): New.
4362         (bt_flag_option_def): New.
4363         (backtrace_command_option_defs): New.
4364         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4365         (print_frame_arg, read_frame_arg, print_frame_args)
4366         (print_frame_info, print_frame): Add frame_print_options parameter
4367         and use it.
4368         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4369         (backtrace_command_1): Add frame_print_options and
4370         backtrace_cmd_options parameters and use them.
4371         (make_backtrace_options_def_group): New.
4372         (backtrace_command): Process command options with
4373         gdb::option::process_options.
4374         (backtrace_command_completer): New.
4375         (_initialize_stack): Extend "backtrace"'s help to mention
4376         supported options.  Install completer for "backtrace".
4377         Install some settings commands with add_setshow_cmds_for_options.
4378
4379 2019-06-13  Pedro Alves  <palves@redhat.com>
4380
4381         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4382         and that "set/show print raw frame-arguments" are now deprecated.
4383
4384         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4385         command.
4386         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4387         * stack.c (_initialize_stack): Install "set/show print
4388         raw-frame-arguments", and deprecate "set/show print raw
4389         frame-arguments".
4390         * valprint.c (_initialize_valprint): Deprecate "set/show print
4391         raw".
4392
4393 2019-06-13  Pedro Alves  <palves@redhat.com>
4394
4395         * compile/compile.c (struct compile_options): New.
4396         (compile_flag_option_def, compile_command_option_defs)
4397         (make_compile_options_def_group): New.
4398         (compile_file_command): Handle options with
4399         gdb::option::process_options.
4400         (compile_file_command_completer): New function.
4401         (compile_code_command): Handle options with
4402         gdb::option::process_options.
4403         (compile_code_command_completer): New function.
4404         (_initialize_compiler): Install completers for "compile code" and
4405         "compile file".  Mention available options in "compile code" and
4406         "compile code"'s help.
4407         * completer.c (advance_to_completion_word): New, factored out from
4408         ...
4409         (advance_to_expression_complete_word_point): ... this.
4410         (advance_to_filename_complete_word_point): New.
4411         * completer.h (advance_to_filename_complete_word_point): New
4412         declaration.
4413
4414 2019-06-13  Pedro Alves  <palves@redhat.com>
4415
4416         * compile/compile.c: Include "cli/cli-option.h".
4417         (compile_print_value): Scope data pointer is now a
4418         value_print_options pointer; adjust.
4419         (compile_print_command): Process options.  Scope data pointer is
4420         now a value_print_options pointer; adjust.
4421         (_initialize_compile): Update "compile print"'s help to include
4422         supported options.  Install a completer for "compile print".
4423         * cp-valprint.c (show_vtblprint, show_objectprint)
4424         (show_static_field_print): Delete.
4425         (_initialize_cp_valprint): Don't install "set print
4426         static-members", "set print vtbl", "set print object" here.
4427         * printcmd.c: Include "cli/cli-option.h" and
4428         "common/gdb_optional.h".
4429         (print_command_parse_format): Rework to fill in a
4430         value_print_options instead of a format_data.
4431         (print_value): Change parameter type from format_data pointer to
4432         value_print_options reference.  Adjust.
4433         (print_command_1): Process options.  Adjust to pass down a
4434         value_print_options.
4435         (print_command_completer): New.
4436         (_initialize_printcmd): Install print_command_completer as
4437         handle_brkchars completer for the "print" command.  Update
4438         "print"'s help to include supported options.
4439         * valprint.c: Include "cli/cli-option.h".
4440         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4441         here from cp-valprint.c.
4442         (boolean_option_def, uinteger_option_def)
4443         (value_print_option_defs, make_value_print_options_def_group):
4444         New.  Use gdb::option::add_setshow_cmds_for_options to install
4445         "set print elements", "set print null-stop", "set print repeats",
4446         "set print pretty", "set print union", "set print array", "set
4447         print address", "set print symbol", "set print array-indexes".
4448         * valprint.h: Include <string> and "cli/cli-option.h".
4449         (make_value_print_options_def_group): Declare.
4450         (print_value): Change parameter type from format_data pointer to
4451         value_print_options reference.
4452         (print_command_completer): Declare.
4453
4454 2019-06-13  Pedro Alves  <palves@redhat.com>
4455
4456         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4457         (COMMON_SFILES): Add maint-test-settings.c.
4458         * cli/cli-decode.c (boolean_enums): New global, factored out from
4459         ...
4460         (add_setshow_boolean_cmd): ... here.
4461         * cli/cli-decode.h (boolean_enums): Declare.
4462         * cli/cli-option.c: New file.
4463         * cli/cli-option.h: New file.
4464         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4465         factored out from ...
4466         (parse_cli_boolean_value(const char *)): ... this.
4467         (is_unlimited_literal): Change parameter type to pointer to
4468         pointer.  Adjust and advance ARG pointer.
4469         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4470         (parse_cli_var_enum): New, factored out from ...
4471         (do_set_command): ... this.  Adjust.
4472         * cli/cli-setshow.h (parse_cli_boolean_value)
4473         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4474         (parse_cli_var_enum): Declare.
4475         * cli/cli-utils.c: Include "cli/cli-option.h".
4476         (get_ulongest): New.
4477         * cli/cli-utils.h (get_ulongest): Declare.
4478         (check_for_argument): New overloads.
4479         * maint-test-options.c: New file.
4480
4481 2019-06-13  Pedro Alves  <palves@redhat.com>
4482
4483         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4484         parse a range if "-" is at the end of the string.
4485
4486 2019-06-13  Pedro Alves  <palves@redhat.com>
4487
4488         * cli/cli-setshow.c (parse_auto_binary_operation)
4489         (parse_cli_boolean_value): Don't allow "o".
4490
4491 2019-06-13  Pedro Alves  <palves@redhat.com>
4492
4493         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4494         * NEWS: Mention maint test-settings KIND.
4495         * maint-test-settings.c: New file.
4496
4497 2019-06-13  Pedro Alves  <palves@redhat.com>
4498
4499         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4500         completer.
4501         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4502         "set" completers.
4503
4504 2019-06-13  Pedro Alves  <palves@redhat.com>
4505
4506         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4507         after item.
4508
4509 2019-06-13  Pedro Alves  <palves@redhat.com>
4510
4511         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4512
4513 2019-06-13  Pedro Alves <palves@redhat.com>
4514
4515         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4516         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4517         call.
4518         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4519         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4520         calls.
4521         (check_for_argument): Skip spaces after argument.
4522
4523 2019-06-13  Pedro Alves  <palves@redhat.com>
4524
4525         * thread.c (thread_apply_command): Adjust TID parsing.
4526         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4527         detected before end of string.
4528         (tid_is_in_list): Error out if LIST is invalid.
4529
4530 2019-06-13  Pedro Alves  <palves@redhat.com>
4531
4532         * completer.c (complete_line_internal_1): Rewind completion word
4533         point.
4534         (completion_tracker::advance_custom_word_point_by): Change
4535         parameter type to int.
4536         * completer.h (completion_tracker::advance_custom_word_point_by):
4537         Likewise.
4538
4539 2019-06-13  Pedro Alves  <palves@redhat.com>
4540
4541         * completer.c (advance_to_completion_word): Handle delimiters.
4542
4543 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4544
4545         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4546
4547 2019-06-11  Tom Tromey  <tom@tromey.com>
4548
4549         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4550         (xmalloc_failed): Move to alloc.c.
4551         * alloc.c: New file.
4552         * Makefile.in (COMMON_SFILES): Add alloc.c.
4553
4554 2019-06-11  Tom Tromey  <tom@tromey.com>
4555
4556         * nat/linux-waitpid.c: Don't include server.h.
4557         (linux_debug): Remove.
4558         (my_waitpid): Update.
4559
4560 2019-06-11  Tom Tromey  <tromey@adacore.com>
4561
4562         * infcall.c (_initialize_infcall): Remove trailing newline from
4563         help.
4564         * user-regs.c (_initialize_user_regs): Remove trailing newline
4565         from help.
4566         * typeprint.c (_initialize_typeprint): Remove trailing newline
4567         from help.
4568         * reverse.c (_initialize_reverse): Remove trailing newlines from
4569         help.
4570         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4571         from help.
4572         * language.c (add_set_language_command): Remove trailing newline
4573         from help.
4574         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4575         help.
4576         * disasm.c (_initialize_disasm): Remove trailing newline from
4577         help.
4578         * top.c (init_main): Remove trailing newline from help.
4579         * interps.c (_initialize_interpreter): Remove trailing newline
4580         from help.
4581         * btrace.c (_initialize_btrace): Remove trailing newlines from
4582         help.
4583         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4584         from help.
4585         * python/python.c (_initialize_python): Remove trailing newline
4586         from help.
4587         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4588         help.
4589         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4590         from help.  Reformat some text.
4591         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4592         from help.
4593         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4594         newline from help.
4595
4596 2019-06-11  Tom Tromey  <tromey@adacore.com>
4597
4598         * darwin-nat.c (darwin_decode_exception_message)
4599         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4600
4601 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * valops.c (value_slice): Check for not allocated or not
4604         associated values.
4605
4606 2019-06-10  Tom de Vries  <tdevries@suse.de>
4607
4608         PR gdb/24618
4609         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4610         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4611         invalid.
4612
4613 2019-06-10  Tom de Vries  <tdevries@suse.de>
4614
4615         PR gdb/24611
4616         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4617         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4618
4619 2019-06-10  Tom de Vries  <tdevries@suse.de>
4620
4621         PR symtab/24545
4622         * symtab.c (struct demangled_name_entry): Add language field.
4623         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4624         static minimal symbol".  Set and use language field.
4625
4626 2019-06-10  Tom Tromey  <tromey@adacore.com>
4627
4628         * ada-lang.c (_initialize_ada_language): Update help text.
4629
4630 2019-06-10  Tom Tromey  <tromey@adacore.com>
4631
4632         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4633         with a newline.
4634         * guile/guile.c (handle_boot_error): Don't end warning with a
4635         newline.
4636         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4637         warning with a newline.
4638         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4639         newline.
4640         (s12z_frame_cache): Likewise.
4641         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4642         a newline.
4643         * solib-svr4.c (disable_probes_interface): Don't end warning with
4644         a newline.
4645         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4646         newline.
4647         * python/python.c (do_finish_initialization): Don't end warning
4648         with a newline.
4649
4650 2019-06-10  Tom Tromey  <tom@tromey.com>
4651
4652         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4653         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4654         gdbpy_enter.
4655
4656 2019-06-10  Tom Tromey  <tromey@adacore.com>
4657
4658         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4659         data.
4660         (elf_new_init): Don't call stabsread_new_init.
4661         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4662         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4663         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4664
4665 2019-06-10  Tom de Vries  <tdevries@suse.de>
4666
4667         PR symtab/16264
4668         PR symtab/24517
4669         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4670
4671 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4672
4673         * source.c (find_and_open_source): Also rewrite relative file
4674         names.
4675
4676 2019-04-26  Amos Bird  <amosbird@gmail.com>
4677
4678         * annotate.c (annotate_thread_exited): Add "thread-exited"
4679         annotation.
4680
4681 2019-06-06  Tom Tromey  <tromey@adacore.com>
4682
4683         * maint.h (class scoped_command_stats): Use
4684         DISABLE_COPY_AND_ASSIGN.
4685         <print_time>: New method.
4686         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4687         print_time.
4688         (scoped_command_stats::print_time): New method.
4689
4690 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4693         instructions of lengths 6 or 8 bytes.
4694
4695 2019-06-04  Pedro Alves  <palves@redhat.com>
4696
4697         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4698
4699         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4700         * breakpoint.c (condition_completer): Likewise.
4701         * cli/cli-dump.c (scan_expression): Likewise.
4702         * common/filestuff.c (mkdir_recursive): Likewise.
4703         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4704         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4705         (gdb_abspath): Likewise.
4706         * compile/compile-cplus-types.c
4707         (compile_cplus_instance::decl_name): Likewise.
4708         * completer.c (complete_explicit_location):
4709         (signal_completer, reg_or_group_completer_1): Likewise.
4710         * cp-support.c (cp_remove_params_if_any): Likewise.
4711         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4712         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4713         * infcmd.c (strip_bg_char): Likewise.
4714         * linespec.c (copy_token_string): Likewise.
4715         * mi/mi-main.c (output_cores): Likewise.
4716         * psymtab.c (psymtab_search_name):
4717         * symfile.c (test_set_ext_lang_command): Likewise.
4718         * target.c (target_fileio_read_stralloc): Likewise.
4719         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4720         * value.c (complete_internalvar): Likewise.
4721
4722 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4723
4724         Add objfile property to gdb.Type.
4725         * NEWS: Mention Python API addition.
4726         * python/py-type.c (typy_get_objfile): New method.
4727
4728 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4729
4730         * NEWS: Mention the new set|show style [title|highlight].
4731         Mention changes to "show style", "help" and "apropos".
4732
4733 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4734
4735         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4736         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4737         instead of print_help_for_command.
4738         (print_doc_of_command): New function.
4739         (help_list): Add 'apropos -v word' suggestion.
4740         (print_help_for_command): Style the command name using title style.
4741         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4742         (_initialize_cli_cmds): Describe -v in apropos_command help.
4743
4744 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4745
4746         * cli/cli-style.h (cli_style_option): Add name in constructor,
4747         add m_name class member, add constructor with intensity,
4748         add name class function.
4749         (cli_style_option::add_setshow_commands): Remove name argument.
4750         (highlight_style, title_style): New styles.
4751         * cli/cli-style.c (do_show): New function that shows a style
4752         characteristic styling the style name with itself.
4753         (set_style_name): New function.
4754         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4755         Update all callers according to the changes in cli/cli-style.h.
4756         * utils.h (fputs_highlighted): New function.
4757         * utils.c (fputs_highlighted): Likewise.
4758
4759 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4760
4761         * NEWS: Mention new pipe command and new convenience variables.
4762
4763 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4764
4765         * cli/cli-cmds.c (pipe_command): New function.
4766         (_initialize_cli_cmds): Call add_com for pipe_command.
4767         Define | as an alias for pipe.
4768         (exit_status_set_internal_vars): New function.
4769         (shell_escape): Call exit_status_set_internal_vars.
4770         cli/cli-decode.c (find_command_name_length): Recognize | as
4771         a single character command.
4772
4773 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4774
4775         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4776         top.c (execute_command_to_ui_file): New function, mostly a copy
4777         of execute_command_to_string.
4778         (execute_command_to_string): Implement by calling
4779         execute_command_to_ui_file.
4780
4781 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4782
4783         * top.h (saved_command_line): Remove declaration.
4784         * top.c (previous_saved_command_line, previous_repeat_arguments):
4785         New variables.
4786         (saved_command_line): Make static, define together with other
4787         'repeat variables'.
4788         (dont_repeat): Clear repeat_arguments.
4789         (repeat_previous, get_saved_command_line, save_command_line):
4790         New functions.
4791         (gdb_init): Initialize saved_command_line
4792         and previous_saved_command_line.
4793         * main.c (captured_main_1): Remove saved_command_line initialization.
4794         * event-top.c (handle_line_of_input): Update to use
4795         the new 'repeat' related functions instead of direct access to
4796         saved_command_line.
4797         * command.h (repeat_previous, get_saved_command_line,
4798         save_command_line): New declarations.
4799         (dont_repeat): Add comment.
4800
4801 2019-05-30  Tom Tromey  <tromey@adacore.com>
4802
4803         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4804         Fix comment.
4805         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4806
4807 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4808
4809         PR cli/24587
4810         * completer.c (complete): Initialize variable word.
4811
4812 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4813
4814         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4815         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4816         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4817         'body' is NULL to the outter 'if', protecting the '!is_define'
4818         situation as well.
4819
4820 2019-05-29  Tom Tromey  <tromey@adacore.com>
4821
4822         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4823         (dwarf_unknown): New function.
4824         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4825         (dwarf_type_encoding_name): Use dwarf_unknown.
4826
4827 2019-05-29  Tom Tromey  <tromey@adacore.com>
4828
4829         PR c++/20020:
4830         * cp-valprint.c (cp_print_value_fields): Call
4831         cp_print_static_field inside "try".
4832
4833 2019-05-29  Tom Tromey  <tromey@adacore.com>
4834
4835         * inflow.c (struct terminal_info): Add default operator=.
4836         * configure: Rebuild.
4837         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4838         -Wdeprecated-copy-dtor, -Wredundant-move.
4839
4840 2019-05-29  Tom Tromey  <tromey@adacore.com>
4841
4842         * NEWS: Add entry.
4843         * infcmd.c (print_return_value_1): Handle finish_print
4844         option.
4845         (show_print_finish): New function.
4846         (_initialize_infcmd): Add "set/show print finish" commands.
4847         * valprint.c (user_print_options): Initialize new member.
4848         * valprint.h (struct value_print_options) <finish_print>: New
4849         member.
4850
4851 2019-05-28  Tom Tromey  <tromey@adacore.com>
4852
4853         * ada-lang.c (ada_remove_Xbn_suffix)
4854         (find_old_style_renaming_symbol)
4855         (parse_old_style_renaming): Remove.
4856         (ada_find_renaming_symbol): Don't call
4857         find_old_style_renaming_symbol.
4858         (ada_is_renaming_symbol): Rename from
4859         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4860         bool.  Now static.
4861         (ada_read_var_value): Update and simplify.
4862         * ada-exp.y (write_var_or_type): Remove old code.
4863
4864 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4865
4866         * event-top.c: Remove include comment.
4867         * inflow.c (class scoped_ignore_sigttou): Move from here...
4868         * inflow.h (class scoped_ignore_sigttou): ...to here.
4869         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4870         * top.c:  Remove include comment.
4871
4872 2019-05-27  Tom Tromey  <tom@tromey.com>
4873
4874         * NEWS: Fix typo.
4875
4876 2019-05-22  Tom Tromey  <tromey@adacore.com>
4877
4878         * target.c (target_follow_exec): Constify parameter.
4879         * target-delegates.c: Rebuild.
4880         * remote.c (remote_target::follow_exec): Constify parameter.
4881         * infrun.c (follow_exec): Constify parameter.
4882         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4883         (target_follow_exec): Likewise.
4884
4885 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4886
4887         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4888         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4889
4890 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4891
4892         * NEWS: Add debugredirect and testsuite sections.
4893
4894 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4895
4896         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4897         target descriptions using exclusively floating point register name
4898         aliases.
4899
4900 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         PR gdb/18644:
4903         * f-lang.c (build_fortran_types): Handle the case where
4904         gdbarch_floatformat_for_type returns a nullptr.
4905
4906 2019-05-21  Tom de Vries  <tdevries@suse.de>
4907
4908         PR cli/24587
4909         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4910
4911 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         PR gdb/18644:
4914         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4915         16-byte floats.
4916         * i386-tdep.c (i386_floatformat_for_type): Use
4917         floatformats_ia64_quad for the 16-byte floating point component
4918         within a fortran 32-byte complex number.
4919
4920 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4923         delete default constructor.
4924         (find_partial_die): Update to return const struct.
4925         (partial_die_parent_scope): Move variable declaration into scope
4926         of its use and change its type to auto.
4927         (guess_partial_die_structure_name): Likewise.
4928         (partial_die_info::fixup): Likewise.
4929
4930 2019-05-17  Tom Tromey  <tromey@adacore.com>
4931
4932         * source.c (find_and_open_source): Remove cast.
4933
4934 2019-05-17  Tom Tromey  <tromey@adacore.com>
4935
4936         * annotate.c (annotate_source): Make "filename" const.
4937         * annotate.h (annotate_source): Use const.
4938
4939 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4940
4941         * disasm.c (set_disassembler_options): Send errors to stderr.
4942
4943 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4944
4945         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4946         (cli_interp_base::set_logging): Check debug_redirect.
4947         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4948         * cli/cli-logging.c (debug_redirect): Add static variable.
4949         (pop_output_files): Add default param.
4950         (handle_redirections): Print debug setting.
4951         (show_logging_command): Likewise.
4952         (_initialize_cli_logging): Add debugredirect command.
4953         * interps.c (current_interp_set_logging): Add debug_redirect
4954         parameter.
4955         * interps.h (set_logging): Add debug_redirect parameter.
4956         (current_interp_set_logging): Likewise.
4957         * mi/mi-common.h: Likewise.
4958         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4959
4960 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4961             Tom Tromey  <tromey@adacore.com>
4962
4963         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4964         directly.
4965         * cli/cli-interp.h (make_logging_output): Remove declaration.
4966         * cli/cli-logging.c (make_logging_output): Remove function.
4967         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4968         directly.
4969         * ui-file.c (tee_file::tee_file): Remove bools.
4970         (tee_file::~tee_file): Remove deletes.
4971         * ui-file.h (tee_file): Remove bools.
4972
4973 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4974
4975         * mi/mi-cmds.h (mi_cmd_complete): New function.
4976         * mi/mi-main.c (mi_cmd_complete): Likewise.
4977         * mi/mi-cmds.c: Define new MI command -complete.
4978         * NEWS: Mention new -complete command.
4979
4980 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4981
4982         * completer.h (complete): New function.
4983         * completer.c (complete): Likewise.
4984         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4985         function defined in completer.h.
4986
4987 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4988
4989         * MAINTAINERS (Write After Approval): Add myself.
4990
4991 2019-05-17  Tom de Vries  <tdevries@suse.de>
4992
4993         PR gdb/24094
4994         * dwarf2read.c (struct cu_partial_die_info): New struct.
4995         (find_partial_die): Return cu_partial_die_info.
4996         (partial_die_parent_scope, guess_partial_die_structure_name)
4997         (partial_die_info::fixup): Handle new return type of find_partial_die.
4998
4999 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5000
5001         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5002         "std::string", simplifying the algorithm.
5003
5004 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5005
5006         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5007         (stap_static_probe_ops::get_probes): Likewise.
5008
5009 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5010
5011         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5012         '-')" and "else if".
5013         (stap_parse_single_operand): Join checks for
5014         "gdbarch_stap_parse_special_token_p" and
5015         "gdbarch_stap_parse_special_token" in the same "if" statement.
5016         Invert check when verifying for operation on register
5017         displacement.
5018
5019 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5020
5021         * stap-probe.c (stap_get_opcode): Update comment.
5022         (stap_get_expected_argument_type): Likewise.
5023         (handle_stap_probe): Likewise.
5024
5025 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5026
5027         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5028         return type to 'bool'.  Adjust comment.  Use 'bool' when
5029         appropriate.
5030         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5031         * stap-probe.c (stap_parse_argument_1): Likewise.
5032         (stap_is_operator): Likewise.
5033         (stap_is_generic_prefix): Likewise.
5034         (stap_is_register_prefix): Likewise.
5035         (stap_is_register_indirection_prefix): Likewise.
5036         (stap_is_integer_prefix): Likewise.
5037         (stap_generic_check_suffix): Likewise.
5038         (stap_check_integer_suffix): Likewise.
5039         (stap_check_register_suffix): Likewise.
5040         (stap_check_register_indirection_suffix): Likewise.
5041         (stap_parse_register_operand): Likewise.
5042         (stap_parse_single_operand): Likewise.
5043         (stap_parse_argument_1): Likewise.
5044         (stap_probe::get_argument_count): Likewise.
5045         (stap_is_operator): Likewise.
5046
5047 2019-05-16  Tom Tromey  <tromey@adacore.com>
5048
5049         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5050         keyword to foreach.
5051
5052 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5053
5054         * linux-thread-db.c (try_thread_db_load_1): Change return type
5055         to bool.
5056         (try_thread_db_load): Likewise.
5057         (try_thread_db_load_from_pdir_1): Likewise.
5058         (try_thread_db_load_from_pdir): Likewise.
5059         (try_thread_db_load_from_sdir): Likewise.
5060         (try_thread_db_load_from_dir): Likewise.
5061         (thread_db_load_search): Likewise.
5062         (has_libpthread): Likewise.
5063         (thread_db_load): Likewise.
5064
5065 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5066
5067         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5068         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5069         NULL, and complain/return if that's the case.
5070
5071 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5072
5073         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5074         (advance, posn, abstract_read_memory): New functions.
5075         [struct mem_read_abstraction]: New struct.
5076         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5077
5078 2019-05-14  Tom Tromey  <tromey@adacore.com>
5079
5080         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5081         value is not lval_memory.
5082
5083 2019-05-14  Tom Tromey  <tromey@adacore.com>
5084
5085         * solib.c (info_sharedlibrary_command): Style the file name.
5086
5087 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5088
5089         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5090         (aarch64_vnv_type): Likewise.
5091         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5092         * common/tdesc.c: Likewise.
5093         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5094         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5095         * features/aarch64-fpu.xml: Add ieee half view.
5096         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5097         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5098         * gdbtypes.h (struct builtin_type): Likewise.
5099         (struct objfile_type): Likewise.
5100
5101 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5102
5103         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5104         typo.
5105         * location.h (string_to_event_location): Likewise.
5106
5107 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5108
5109         GDB 8.3 released.
5110
5111 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5112
5113         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5114         New variable declaration.
5115         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5116         New variable.
5117         (print_one_breakpoint): Use ui_out::test_flags and new global
5118         variable to compute use_fixed_output.
5119         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5120         Remove.
5121         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5122         (mi_multi_location_breakpoint_output_fixed): Remove.
5123         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5124         new variable.
5125         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5126         fix_multi_location_breakpoint_output flag if version >= 3.
5127         * ui-out.h (enum ui_out_flag)
5128         <fix_multi_location_breakpoint_output>: New enumerator.
5129
5130 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5131
5132         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5133
5134 2019-05-10  Tom Tromey  <tromey@adacore.com>
5135
5136         * ada-lang.c (catch_ada_completer): New function.
5137         (_initialize_ada_language): Use it.
5138
5139 2019-05-10  Tom Tromey  <tromey@adacore.com>
5140
5141         * thread.c (print_thread_info): Make "requested_threads" const.
5142         * gdbthread.h (print_thread_info): Make "requested_threads"
5143         const.
5144         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5145         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * gdbtypes.c (objfile_type_data): Change type.
5150         (objfile_type, _initialize_gdbtypes): Update.
5151
5152 2019-05-08  Tom Tromey  <tom@tromey.com>
5153
5154         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5155         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5156         (_initialize_dwarf2_frame): Update.
5157
5158 2019-05-08  Tom Tromey  <tom@tromey.com>
5159
5160         * objc-lang.c (objc_objfile_data): Change type.
5161         (find_methods): Update.
5162         (_initialize_objc_lang): Remove.
5163
5164 2019-05-08  Tom Tromey  <tom@tromey.com>
5165
5166         * stabsread.c (rs6000_builtin_type_data): Change type.
5167         (rs6000_builtin_type, _initialize_stabsread): Update.
5168
5169 2019-05-08  Tom Tromey  <tom@tromey.com>
5170
5171         * mips-tdep.c (mips_pdr_data): Remove.
5172         (_initialize_mips_tdep): Update.
5173
5174 2019-05-08  Tom Tromey  <tom@tromey.com>
5175
5176         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5177         (hppa_init_objfile_priv_data, read_unwind_info)
5178         (find_unwind_entry, _initialize_hppa_tdep): Update.
5179
5180 2019-05-08  Tom Tromey  <tom@tromey.com>
5181
5182         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5183         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5184         on obstack.
5185         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5186
5187 2019-05-08  Tom Tromey  <tom@tromey.com>
5188
5189         * mdebugread.c (basic_type_data): Change type.
5190         (basic_type, _initialize_mdebugread): Update.
5191
5192 2019-05-08  Tom Tromey  <tom@tromey.com>
5193
5194         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5195
5196 2019-05-08  Tom Tromey  <tom@tromey.com>
5197
5198         * nto-tdep.c (nto_inferior_data_reg): Change type.
5199         (nto_inferior_data): Update.
5200         (nto_inferior_data_cleanup, nto_new_inferior_data)
5201         (_initialize_nto_tdep): Remove.
5202         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5203
5204 2019-05-08  Tom Tromey  <tom@tromey.com>
5205
5206         * ada-lang.c (struct ada_inferior_data): Add initializers.
5207         (ada_inferior_data): Change type.
5208         (ada_inferior_data_cleanup): Remove.
5209         (get_ada_inferior_data, ada_inferior_exit)
5210         (struct ada_pspace_data): Add initializers, destructor.
5211         (ada_pspace_data_handle): Change type.
5212         (get_ada_pspace_data): Update.
5213         (ada_pspace_data_cleanup): Remove.
5214
5215 2019-05-08  Tom Tromey  <tom@tromey.com>
5216
5217         * coffread.c (struct coff_symfile_info): Add initializers.
5218         (coff_objfile_data_key): Move lower.  Change type.
5219         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5220         Update.
5221         (coff_free_info): Remove.
5222
5223 2019-05-08  Tom Tromey  <tom@tromey.com>
5224
5225         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5226         (fbsd_pspace_data_handle): Move lower.  Change type.
5227         (get_fbsd_pspace_data): Update.
5228         (fbsd_pspace_data_cleanup): Remove.
5229         (_initialize_fbsd_tdep): Update.
5230
5231 2019-05-08  Tom Tromey  <tom@tromey.com>
5232
5233         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5234         (get_ada_tasks_pspace_data): Update.
5235         (ada_tasks_pspace_data_cleanup): Remove.
5236         (_initialize_tasks): Update.
5237         (ada_tasks_inferior_data_handle): Change type.
5238         (get_ada_tasks_inferior_data): Update.
5239         (ada_tasks_inferior_data_cleanup): Remove.
5240         (struct ada_tasks_pspace_data): Add initializers.
5241
5242 2019-05-08  Tom Tromey  <tom@tromey.com>
5243
5244         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5245         * symfile-debug.c (debug_sym_get_probes): Change type.
5246         * stap-probe.c (handle_stap_probe):
5247         (stap_static_probe_ops::get_probes): Change type.
5248         * probe.h (class static_probe_ops) <get_probes>: Change type.
5249         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5250         (parse_probes_in_pspace): Update.
5251         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5252         Update.
5253         (any_static_probe_ops::get_probes): Change type.
5254         * elfread.c (elfread_data): New typedef.
5255         (probe_key): Change type.
5256         (elf_get_probes): Likewise.  Update.
5257         (probe_key_free): Remove.
5258         (_initialize_elfread): Update.
5259         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5260         Change type.
5261         (dtrace_process_dof_probe, dtrace_process_dof)
5262         (dtrace_static_probe_ops::get_probe): Change type.
5263
5264 2019-05-08  Tom Tromey  <tom@tromey.com>
5265
5266         * xcoffread.c (struct xcoff_symfile_info): Rename from
5267         coff_symfile_info.  Add initializers.
5268         (xcoff_objfile_data_key): Move lower.  Change type.
5269         (XCOFF_DATA): Rewrite.
5270         (xcoff_free_info): Remove.
5271         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5272         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5273         (xcoff_initial_scan): Update.
5274
5275 2019-05-08  Tom Tromey  <tom@tromey.com>
5276
5277         * solib-svr4.c (struct svr4_info): Add initializers and
5278         destructor.
5279         <probes_table>: Now an htab_up.
5280         (solib_svr4_pspace_data): Change type.
5281         (free_probes_table): Simplify.
5282         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5283         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5284         (probes_table_remove_objfile_probes, register_solib_event_probe)
5285         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5286         (_initialize_svr4_solib): Update.
5287
5288 2019-05-08  Tom Tromey  <tom@tromey.com>
5289
5290         * remote.c (remote_pspace_data): Change type.
5291         (remote_pspace_data_cleanup): Remove.
5292         (get_remote_exec_file, set_pspace_remote_exec_file)
5293         (_initialize_remote): Update.
5294
5295 2019-05-08  Tom Tromey  <tom@tromey.com>
5296
5297         * breakpoint.c (breakpoint_objfile_key): Change type.
5298         (get_breakpoint_objfile_data): Update.
5299         (free_breakpoint_objfile_data): Remove.
5300         (_initialize_breakpoint): Update.
5301
5302 2019-05-08  Tom Tromey  <tom@tromey.com>
5303
5304         * linux-tdep.c (struct linux_info): Add initializers.
5305         (linux_inferior_data): Move.  Change type.
5306         (invalidate_linux_cache_inf): Update.
5307         (linux_inferior_data_cleanup): Remove.
5308         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5309
5310 2019-05-08  Tom Tromey  <tom@tromey.com>
5311
5312         * auxv.c (auxv_inferior_data): Move.  Change type.
5313         (auxv_inferior_data_cleanup): Remove.
5314         (invalidate_auxv_cache_inf): Rewrite.
5315         (get_auxv_inferior_data, _initialize_auxv): Update.
5316
5317 2019-05-08  Tom Tromey  <tom@tromey.com>
5318
5319         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5320         (symfile_debug_objfile_data_key): Change type.
5321         (symfile_debug_installed, debug_qf_has_symbols)
5322         (debug_qf_find_last_source_symtab)
5323         (debug_qf_forget_cached_source_info)
5324         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5325         (debug_qf_print_stats, debug_qf_dump)
5326         (debug_qf_expand_symtabs_for_function)
5327         (debug_qf_expand_all_symtabs)
5328         (debug_qf_expand_symtabs_with_fullname)
5329         (debug_qf_map_matching_symbols)
5330         (debug_qf_expand_symtabs_matching)
5331         (debug_qf_find_pc_sect_compunit_symtab)
5332         (debug_qf_map_symbol_filenames)
5333         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5334         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5335         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5336         (debug_sym_read_linetable, debug_sym_relocate): Update.
5337         (symfile_debug_free_objfile): Remove.
5338         (install_symfile_debug_logging, _initialize_symfile_debug):
5339         Update.
5340
5341 2019-05-08  Tom Tromey  <tom@tromey.com>
5342
5343         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5344         allocate_on_obstack.
5345         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5346         (get_dwarf2_per_objfile): Update.
5347         (set_dwarf2_per_objfile): Remove.
5348         (dwarf2_has_info, dwarf2_get_section_info): Update.
5349         (dwarf2_free_objfile): Remove.
5350         (_initialize_dwarf2_read): Update.
5351
5352 2019-05-08  Tom Tromey  <tom@tromey.com>
5353
5354         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5355         initializers.
5356         <unsupported_script_warning_printed,
5357         script_not_found_warning_printed>: Now bool.
5358         (auto_load_pspace_data): Change type.
5359         (~auto_load_pspace_info): Rename from
5360         auto_load_pspace_data_cleanup.
5361         (get_auto_load_pspace_data, init_loaded_scripts_info)
5362         (clear_section_scripts, maybe_print_unsupported_script_warning)
5363         (maybe_print_script_not_found_warning, _initialize_auto_load):
5364         Update.
5365
5366 2019-05-08  Tom Tromey  <tom@tromey.com>
5367
5368         * objfiles.c (objfile_pspace_info): Add destructor and
5369         initializers.
5370         (objfiles_pspace_data): Change type.
5371         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5372         (get_objfile_pspace_data): Update.
5373         (objfiles_bfd_data): Change type.
5374         (get_objfile_bfd_data): Update.
5375         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5376
5377 2019-05-08  Tom Tromey  <tom@tromey.com>
5378
5379         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5380         Change type.
5381         (get_catch_syscall_inferior_data): Update.
5382         (catch_syscall_inferior_data_cleanup): Remove.
5383         (_initialize_break_catch_syscall): Update.
5384
5385 2019-05-08  Tom Tromey  <tom@tromey.com>
5386
5387         * inflow.c (struct terminal_info): Add destructor and
5388         initializers.
5389         (inflow_inferior_data): Change type.
5390         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5391         (get_inflow_inferior_data, inflow_inferior_exit)
5392         (swap_terminal_info, _initialize_inflow): Update.
5393
5394 2019-05-08  Tom Tromey  <tom@tromey.com>
5395
5396         * target-dcache.c (target_dcache_cleanup): Remove.
5397         (target_dcache_aspace_key): Change type.
5398         (target_dcache_init_p, target_dcache_invalidate)
5399         (target_dcache_get, target_dcache_get_or_init)
5400         (_initialize_target_dcache): Update.
5401         * dcache.h (struct dcache_deleter): New.
5402
5403 2019-05-08  Tom Tromey  <tom@tromey.com>
5404
5405         * symtab.c (struct symbol_cache): Add destructor and
5406         initializers.
5407         (symbol_cache_key): Move.  Change type.
5408         (make_symbol_cache, free_symbol_cache): Remove.
5409         (get_symbol_cache): Update.
5410         (symbol_cache_cleanup): Remove.
5411         (ALL_PSPACES, symbol_cache_flush)
5412         (maintenance_print_symbol_cache)
5413         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5414         Update.
5415
5416 2019-05-08  Tom Tromey  <tom@tromey.com>
5417
5418         * symtab.c (struct main_info): Add destructor and initializers.
5419         (main_progspace_key): Move.  Change type.
5420         (get_main_info): Update.
5421         (main_info_cleanup): Remove.
5422         (_initialize_symtab): Update.
5423
5424 2019-05-08  Tom Tromey  <tom@tromey.com>
5425
5426         * registry.h (DECLARE_REGISTRY): Define the _key class.
5427
5428 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * NEWS: Merge two 'New commands' sections.
5431
5432 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5433
5434         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5435         parameter and use Ada language definition instead.
5436         (ada_val_print_ptr): Remove unused language parameter.
5437         (ada_val_print_num): Remove language parameter and use Ada language
5438         definition instead.
5439         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5440         parameter.
5441         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5442         parameter and use Ada language definition instead.
5443         (ada_val_print_1): Update all ada_val_print_xxx calls.
5444         Remove language parameter.
5445         (ada_val_print): Update ada_val_print_1 call.
5446
5447 2019-05-08  Tom Tromey  <tromey@adacore.com>
5448
5449         * remote.c (remote_hw_watchpoint_limit)
5450         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5451         Now static.
5452
5453 2019-05-08  Tom Tromey  <tromey@adacore.com>
5454
5455         * maint.c (_initialize_maint_cmds): Move initialization code to
5456         remote.c.
5457         (watchdog, show_watchdog): Move to remote.c.
5458         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5459         "watchdog" static.
5460         (_initialize_remote): Move initialization code from maint.c.
5461         * defs.h (watchdog): Don't declare.
5462
5463 2019-05-08  Tom Tromey  <tromey@adacore.com>
5464
5465         * tui/tui-interp.c: Include main.h.
5466         * interps.c: Include main.h.
5467         * main.h (interpreter_p): Declare.
5468         * defs.h (interpreter_p): Don't declare.
5469
5470 2019-05-08  Tom Tromey  <tromey@adacore.com>
5471
5472         * dwarf2loc.c: Include dwarf2read.h.
5473         * defs.h (read_unsigned_leb128): Don't declare.
5474         * dwarf2read.h (read_unsigned_leb128): Declare.
5475
5476 2019-05-08  Tom Tromey  <tromey@adacore.com>
5477
5478         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5479         method.
5480
5481 2019-05-08  Tom Tromey  <tromey@adacore.com>
5482
5483         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5484         when no wrap column is set.
5485
5486 2019-05-08  Tom Tromey  <tromey@adacore.com>
5487
5488         * c-lang.c (c_get_string): Handle non-C-style arrays.
5489
5490 2019-05-08  Tom Tromey  <tromey@adacore.com>
5491
5492         * typeprint.c (print_offset_data::update): Print the bit offset,
5493         not the number of bits remaining.
5494
5495 2019-05-08  Tom Tromey  <tromey@adacore.com>
5496
5497         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5498         padding at end of comment.
5499
5500 2019-05-08  Tom Tromey  <tromey@adacore.com>
5501
5502         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5503         Compare main types.
5504
5505 2019-05-06  Tom Tromey  <tom@tromey.com>
5506
5507         * common/scoped_mmap.c: Include common-defs.h.
5508         * common/scoped_mmap.h: Don't include config.h.
5509
5510 2019-05-04  Tom Tromey  <tom@tromey.com>
5511
5512         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5513         (struct aarch64_call_info): Add initializers.
5514         <si>: Now a std::vector.
5515         (pass_on_stack, aarch64_push_dummy_call): Update.
5516
5517 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5518             Tom Tromey  <tom@tromey.com>
5519
5520         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5521         (ppc_threads): Now a std::vector.  Now static.
5522         (hwdebug_find_thread_points_by_tid)
5523         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5524         Update.
5525
5526 2019-05-04  Tom Tromey  <tom@tromey.com>
5527
5528         * arc-tdep.c (arc_tdesc_init): Return bool.
5529
5530 2019-05-04  Tom Tromey  <tom@tromey.com>
5531
5532         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5533         Use gdb_assert_not_reached.
5534
5535 2019-05-04  Tom Tromey  <tom@tromey.com>
5536
5537         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5538         "false".
5539
5540 2019-05-04  Tom Tromey  <tom@tromey.com>
5541
5542         * arc-tdep.c (arc_tdesc_init): Use bool.
5543
5544 2019-05-04  Tom Tromey  <tom@tromey.com>
5545
5546         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5547
5548 2019-05-04  Tom Tromey  <tom@tromey.com>
5549
5550         * cli/cli-cmds.c (valid_command_p): Return bool.
5551
5552 2019-05-04  Tom Tromey  <tom@tromey.com>
5553
5554         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5555         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5556
5557 2019-05-04  Raul Tambre  <raul@tambre.ee>
5558
5559         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5560         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5561         operator for comparison.
5562
5563 2019-05-04  Tom Tromey  <tom@tromey.com>
5564
5565         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5566         (lookup_partial_symbol, print_partial_symbols)
5567         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5568         (psymbol_compare): Update.
5569         (add_psymbol_to_bcache): Clear the entire psymbol.
5570         (maintenance_check_psymtabs): Update.
5571         * psympriv.h (struct partial_symbol): Don't derive from
5572         general_symbol_info.
5573         <obj_section, unrelocated_address, address,
5574         set_unrelocated_address>: Update.
5575         <ginfo>: New member.
5576         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5577         (debug_names::write_psymbols): Update.
5578
5579 2019-05-04  Tom de Vries  <tdevries@suse.de>
5580
5581         * contrib/cc-with-tweaks.sh: Support -n arg.
5582
5583 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5584
5585         * corelow.c (core_target::detach): Ensure frame cache and
5586         register caches are cleared.
5587         inferior.c (exit_inferior_1): Likewise.
5588
5589 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5590             Tom Tromey  <tom@tromey.com>
5591
5592         * dictionary.c (collate_pending_symbols_by_language): Remove
5593         "struct" from foreach.
5594         * symtab.c (lookup_global_symbol_from_objfile)
5595         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5596         foreach.
5597         * ser-tcp.c (net_open): Remove "struct" from foreach.
5598         * objfiles.c (objfile_relocate, objfile_rebase)
5599         (objfile_has_symbols): Remove "struct" from foreach.
5600         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5601         from foreach.
5602         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5603         foreach.
5604         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5605         "struct" from foreach.
5606         * ada-lang.c (create_excep_cond_exprs)
5607         (ada_exception_catchpoint_cond_string): Remove "struct" from
5608         foreach.
5609
5610 2019-05-03  Tom Tromey  <tromey@adacore.com>
5611
5612         * ada-exp.y (convert_char_literal): Check suffix of each
5613         enumerator.
5614
5615 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5616
5617         PR ada/21406:
5618         * ada-exp.y (yywrap): Don't define.
5619         * ada-lex.l (%option): Add noyywrap
5620         (yywrap): Remove.
5621
5622 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5623
5624         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5625         _WIN32_WINNT to the XP level, unless already defined to a higher
5626         level.
5627
5628         * unittests/parse-connection-spec-selftests.c:
5629         * ser-tcp.c:
5630         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5631         override.
5632
5633         * symfile.c (find_separate_debug_file): Remove colon from the
5634         drive spec of DOS/Windows file names of the target, so that the
5635         file name produced from DEBUGDIR and the target's directory will
5636         be valid on DOS/Windows systems.
5637
5638 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * rust-lang.c (val_print_struct): Handle printing structures
5641         containing strings.
5642
5643 2019-05-02  Tom Tromey  <tromey@adacore.com>
5644
5645         * valarith.c (_initialize_valarith): Remove.
5646
5647 2019-05-01  Tom Tromey  <tromey@adacore.com>
5648
5649         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5650         bitfields.
5651
5652 2019-05-01  Tom Tromey  <tromey@adacore.com>
5653
5654         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5655         for big-endian copies.
5656
5657 2019-04-30  Ali Tamur  <tamur@google.com>
5658         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5659         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5660         (read_3_bytes): New function.
5661
5662 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5663
5664         * windows-nat.c (main_thread_id): Delete.
5665         (handle_output_debug_string): Replace main_thread_id by
5666         current_event.dwThreadId.
5667         (fake_create_process): Likewise.
5668         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5669         Do not set main_thread_id.
5670         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5671         current_event.dwThreadId.
5672         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5673
5674 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5675
5676         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5677         Use current_event.dwThreadId instead of main_thread_id.
5678
5679 2019-04-30  Tom Tromey  <tromey@adacore.com>
5680
5681         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5682         (create_excep_cond_exprs): Iterate over program spaces.
5683         (ada_exception_catchpoint_cond_string): Examine all minimal
5684         symbols for exception types.
5685
5686 2019-04-30  Tom Tromey  <tromey@adacore.com>
5687
5688         PR c++/24470:
5689         * dwarf2read.c (process_structure_scope): Handle case where type
5690         has template parameters but no symbol was created.
5691
5692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5693             Chris January  <chris.january@arm.com>
5694
5695         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5696         qualifier.
5697         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5698
5699 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * f-typeprint.c (f_print_type): Update rules for printing
5702         whitespace.
5703         (f_type_print_varspec_suffix): Likewise.
5704
5705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5706             Chris January  <chris.january@arm.com>
5707
5708         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5709         function arguments.
5710
5711 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * f-lang.c (build_fortran_types): Change name of void type to
5714         lower case.
5715         * f-typeprint.c (f_type_print_base): Print the name of the void
5716         type, rather than a fixed string.
5717         * f-valprint.c (f_decorations): Use lower case void string.
5718
5719 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5720             Chris January  <chris.january@arm.com>
5721
5722         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5723         types for Fortran.
5724
5725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5726             Chris January  <chris.january@arm.com>
5727             David Lecomber  <david.lecomber@arm.com>
5728
5729         * f-exp.y (BINOP_INTRINSIC): New token.
5730         (exp): New parser rule handling BINOP_INTRINSIC.
5731         (f77_keywords): Add new builtin procedures.
5732         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5733         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5734         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5735         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5736         (print_unop_subexp_f): New function.
5737         (print_binop_subexp_f): New function.
5738         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5739         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5740         (dump_subexp_body_f): Likewise.
5741         (operator_check_f): Likewise.
5742         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5743         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5744
5745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5746
5747         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5748         UNOP_KIND.
5749         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5750         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5751         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5752         (operator_length_f): New fuction.
5753         (print_subexp_f): New function.
5754         (op_name_f): New function.
5755         (dump_subexp_body_f): New function.
5756         (operator_check_f): New function.
5757         (exp_descriptor_f): Replace standard expression handling functions
5758         with new functions.
5759         * gdb/fortran-operator.def: New file.
5760         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5761         * gdb/std-operator.def: Remove UNOP_KIND.
5762
5763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * std-operator.def: Remove unbalanced, stray double quote
5766         character.
5767
5768 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5769             Chris January  <chris.january@arm.com>
5770             Daniel Everett  <daniel.everett@arm.com>
5771             Nick Forrington  <nick.forrington@arm.com>
5772             Richard Bunt  <richard.bunt@arm.com>
5773
5774         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5775         of depth when printing anonymous structs or unions.
5776         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5777         Don't print either the top-level value, or the children if the
5778         max-depth is exceeded.
5779         (ppscm_print_children): When printing the key of a map, allow one
5780         extra level of depth.
5781         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5782         print either the top-level value, or the children if the max-depth
5783         is exceeded.
5784         (print_children): When printing the key of a map, allow one extra
5785         level of depth.
5786         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5787         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5788         (user_print_options): Initialise max_depth field.
5789         (val_print_scalar_or_string_type_p): New function.
5790         (val_print): Check to see if the max depth has been reached.
5791         (val_print_check_max_depth): Define new function.
5792         (show_print_max_depth): New function.
5793         (_initialize_valprint): Add 'print max-depth' option.
5794         * valprint.h (struct value_print_options) <max_depth>: New field.
5795         (val_print_check_max_depth): Declare new function.
5796         * NEWS: Document new feature.
5797
5798 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * ada-lang.c (ada_language_defn): Initialise new field.
5801         * c-lang.c (c_is_string_type_p): New function.
5802         (c_language_defn): Initialise new field.
5803         (cplus_language_defn): Initialise new field.
5804         (asm_language_defn): Initialise new field.
5805         (minimal_language_defn): Initialise new field.
5806         * c-lang.h (c_is_string_type_p): Declare new function.
5807         * d-lang.c (d_language_defn): Initialise new field.
5808         * f-lang.c (f_is_string_type_p): New function.
5809         (f_language_defn): Initialise new field.
5810         * go-lang.c (go_is_string_type_p): New function.
5811         (go_language_defn): Initialise new field.
5812         * language.c (default_is_string_type_p): New function.
5813         (unknown_language_defn): Initialise new field.
5814         (auto_language_defn): Initialise new field.
5815         * language.h (struct language_defn) <la_is_string_type_p>: New
5816         member variable.
5817         (default_is_string_type_p): Declare new function.
5818         * m2-lang.c (m2_language_defn): Initialise new field.
5819         * objc-lang.c (objc_language_defn): Initialise new field.
5820         * opencl-lang.c (opencl_language_defn): Initialise new field.
5821         * p-lang.c (pascal_is_string_type_p): New function.
5822         (pascal_language_defn): Initialise new field.
5823         * rust-lang.c (rust_is_string_type_p): New function.
5824         (rust_language_defn): Initialise new field.
5825
5826 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5827
5828         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5829         New field.
5830         * ada-lang.c (ada_language_defn): Initialise new field.
5831         * c-lang.c (c_language_defn): Likewise.
5832         (cplus_language_defn): Likewise.
5833         (asm_language_defn): Likewise.
5834         (minimal_language_defn): Likewise.
5835         * d-lang.c (d_language_defn): Likewise.
5836         * f-lang.c (f_language_defn): Likewise.
5837         * go-lang.c (go_language_defn): Likewise.
5838         * language.c (unknown_language_defn): Likewise.
5839         (auto_language_defn): Likewise.
5840         * m2-lang.c (m2_language_defn): Likewise.
5841         * objc-lang.c (objc_language_defn): Likewise.
5842         * opencl-lang.c (opencl_language_defn): Likewise.
5843         * p-lang.c (pascal_language_defn): Likewise.
5844         * rust-lang.c (rust_language_defn): Likewise.
5845
5846 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * ada-lang.c (ada_is_character_type): Change return type to bool.
5849         (ada_is_string_type): Likewise.
5850         * ada-lang.h (ada_is_character_type): Update declaration
5851         (ada_is_string_type): Likewise.
5852
5853 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5854
5855         Support style in 'frame|thread apply'
5856
5857         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5858         * record.c (record_start, record_stop): Update callers of
5859         execute_command_to_string with false.
5860         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5861         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5862         methods.
5863         (class string_file): New constructor with term_out parameter.
5864         Override methods term_out and can_emit_style_escape.  New member
5865         term_out.
5866         (class stdio_file): Override can_emit_style_escape.
5867         (class tee_file): Override term_out and can_emit_style_escape.
5868         * utils.h (can_emit_style_escape): Remove.
5869         * utils.c (can_emit_style_escape): Likewise.
5870         Update all callers of can_emit_style_escape (SOMESTREAM) to
5871         SOMESTREAM->can_emit_style_escape.
5872         * source-cache.c (source_cache::get_source_lines): Likewise.
5873         * stack.c (frame_apply_command_count): Call execute_command_to_string
5874         passing the term_out characteristic of the current gdb_stdout.
5875         * thread.c (thr_try_catch_cmd): Likewise.
5876         * top.c (execute_command_to_string): pass term_out parameter
5877         to construct the string_file for the command output.
5878         * ui-file.c (term_cli_styling): New function (most code moved
5879         from utils.c can_emit_style_escape).
5880         (string_file::string_file, string_file::can_emit_style_escape,
5881         stdio_file::can_emit_style_escape, tee_file::term_out,
5882         tee_file::can_emit_style_escape): New functions.
5883
5884 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * NEWS: Mention the new set|show may-call-functions.
5887         * infcall.c (may_call_functions_p): New variable.
5888         (show_may_call_functions_p): New function.
5889         (call_function_by_hand_dummy): Throws an error if not
5890         may-call-functions.
5891         (_initialize_infcall): Call add_setshow_boolean_cmd for
5892         may-call-functions.
5893
5894 2019-04-25  Keith Seitz  <keiths@redhat.com>
5895
5896         PR c++/24367
5897         * cp-support.c (inspect_type): Don't attempt substitutions
5898         of symbol with the same name.
5899
5900 2019-04-25  Tom Tromey  <tromey@adacore.com>
5901
5902         PR gdb/24475:
5903         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5904         static.
5905
5906 2019-04-25  Tom Tromey  <tromey@adacore.com>
5907
5908         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5909         rvalue reference.
5910         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5911         (gdb_xml_parser::parse): Use std::move.
5912         * python/python-internal.h (gdbpy_convert_exception): Take a const
5913         reference.
5914         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5915         std::move.
5916         * python/py-utils.c (gdbpy_convert_exception): Take a const
5917         reference.
5918         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5919         Use std::move.
5920         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5921         Use std::move.
5922         * mi/mi-main.c (mi_print_exception): Take a const reference.
5923         * main.c (handle_command_errors): Take a const reference.
5924         * linespec.c (parse_linespec): Use std::move.
5925         * infcall.c (run_inferior_call): Use std::move.
5926         (call_function_by_hand_dummy): Use std::move.
5927         * exec.c (try_open_exec_file): Use std::move.
5928         * exceptions.h (exception_print, exception_fprintf)
5929         (exception_print_same): Update.
5930         * exceptions.c (print_exception, exception_print)
5931         (exception_fprintf, exception_print_same): Change parameters to
5932         const reference.
5933         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5934         * common/new-op.c: Use std::move.
5935         * common/common-exceptions.h (struct gdb_exception): Add move
5936         constructor.
5937         (struct gdb_exception_error, struct gdb_exception_quit, struct
5938         gdb_quit_bad_alloc): Change constructor to move constructor.
5939         (throw_exception): Change parameter to rvalue reference.
5940         * common/common-exceptions.c (throw_exception): Take rvalue
5941         reference.
5942         * cli/cli-interp.c (safe_execute_command): Use std::move.
5943         * breakpoint.c (insert_bp_location, location_to_sals): Use
5944         std::move.
5945
5946 2019-04-25  Tom Tromey  <tromey@adacore.com>
5947
5948         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5949         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5950         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5951         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5952         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5953         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5954         guile/scm-value.c: Use unpack.
5955         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5956         gdbscm_gdb_exception.
5957         (gdbscm_throw_gdb_exception): Likewise.
5958         (struct gdbscm_gdb_exception): New.
5959         (unpack): New function.
5960         (gdbscm_wrap): Use unpack.
5961
5962 2019-04-25  Tom Tromey  <tromey@adacore.com>
5963
5964         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5965         (gdb_rl_callback_handler): Use std::move.
5966         * common/common-exceptions.h (struct gdb_exception): Add move
5967         assignment operator.
5968         (throw_exception_sjlj): Change "exception" to const reference.
5969         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5970         (throw_exception_sjlj): Change "exception" to const reference.
5971
5972 2019-04-25  Tom Tromey  <tromey@adacore.com>
5973
5974         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5975         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5976         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5977         Update.
5978         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5979         Update.
5980         * mi/mi-interp.c (mi_interp::exec): Update.
5981         * linespec.c (parse_linespec): Update.
5982         * infcall.c (run_inferior_call): Update.
5983         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5984         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5985         (gdbscm_lookup_global_symbol): Update.
5986         * guile/scm-param.c (gdbscm_parameter_value): Update.
5987         * guile/scm-frame.c (gdbscm_frame_read_register)
5988         (gdbscm_frame_read_var): Update.
5989         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5990         * exec.c (try_open_exec_file): Update.
5991         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5992         (gdb_rl_callback_handler): Update.
5993         * common/common-exceptions.h (exception_none): Don't declare.
5994         * common/common-exceptions.c (exception_none): Don't define.
5995         (struct catcher) <exception>: Update.
5996         * cli/cli-interp.c (safe_execute_command): Update.
5997         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5998
5999 2019-04-25  Ali Tamur  <tamur@google.com>
6000
6001         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6002         (read_attribute_value): Likewise.
6003         (dwarf2_read_addr_index): Update comment.
6004         (read_str_index): Add DW_FORM_strx.
6005         (dwarf2_string_attr): Likewise.
6006         (dwarf2_const_value_attr): Likewise.
6007         (dump_die_shallow): Likewise.
6008         (dwarf2_fetch_constant_bytes): Likewise.
6009         (skip_form_bytes): Likewise.
6010         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6011
6012 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6013
6014         PR corefiles/11608
6015         PR corefiles/18187
6016         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6017         OFFSET.  Verify if current mapping contains an ELF header.
6018         (linux_find_memory_regions_full): Adjust call to
6019         dump_mapping_p.
6020
6021 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6022             Kang Li <kanglictf@gmail.com>
6023
6024         PR gdb/21600
6025
6026         * dwarf2-frame.c (read_initial_length): Be consistent about using
6027         unsigned representation of length.
6028         (decode_frame_entry_1): Likewise.  Check for wraparound of
6029         end pointer as well as buffer overflow.
6030
6031 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6032
6033         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6034         "vq".
6035
6036 2019-04-24  Tom Tromey  <tromey@adacore.com>
6037
6038         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6039
6040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * s12z-tdep.c (s12z_unwind_pc): Delete.
6043         (s12z_unwind_sp): Delete.
6044         (s12z_gdbarch_init): Don't register deleted functions with
6045         gdbarch.
6046
6047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * rl78-tdep.c (rl78_unwind_sp): Delete.
6050         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6051
6052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6055         (xstormy16_unwind_pc): Delete.
6056         (xstormy16_dummy_id): Delete.
6057         (xstormy16_gdbarch_init): Don't register deleted functions with
6058         gdbarch.
6059
6060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * vax-tdep.c (vax_unwind_pc): Delete.
6063         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6064
6065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * v850-tdep.c (v850_unwind_sp): Delete.
6068         (v850_unwind_pc): Delete.
6069         (v850_dummy_id): Delete.
6070         (v850_gdbarch_init): Don't register deleted functions with
6071         gdbarch.
6072
6073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6076         (tilegx_unwind_pc): Delete.
6077         (tilegx_unwind_dummy_id): Delete.
6078         (tilegx_gdbarch_init): Don't register deleted functions with
6079         gdbarch.
6080
6081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6084         (tic6x_dummy_id): Delete.
6085         (tic6x_gdbarch_init): Don't register deleted functions with
6086         gdbarch.
6087
6088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6089
6090         * sparc-tdep.c (sparc_unwind_pc): Delete.
6091         (sparc32_gdbarch_init): Don't register deleted function with
6092         gdbarch.
6093
6094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         * sh-tdep.c (sh_unwind_sp): Delete.
6097         (sh_unwind_pc): Delete.
6098         (sh_dummy_id): Delete.
6099         (sh_gdbarch_init): Don't register deleted functions with
6100         gdbarch.
6101
6102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6103
6104         * score-tdep.c (score_unwind_sp): Delete.
6105         (score_unwind_pc): Delete.
6106         (score_dummy_id): Delete.
6107         (score_gdbarch_init): Don't register deleted functions with
6108         gdbarch.
6109
6110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         * rx-tdep.c (rx_unwind_pc): Delete.
6113         (rx_unwind_sp): Delete.
6114         (rx_dummy_id): Delete.
6115         (rx_gdbarch_init): Don't register deleted functions with
6116         gdbarch.  Update comment.
6117
6118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6121         (rs6000_dummy_id): Delete.
6122         (rs6000_gdbarch_init): Don't register deleted functions with
6123         gdbarch.
6124
6125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * or1k-tdep.c (or1k_dummy_id): Delete.
6128         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6129
6130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * nios2-tdep.c (nios2_dummy_id): Delete.
6133         (nios2_unwind_sp): Delete.
6134         (nios2_gdbarch_init): Don't register deleted functions with
6135         gdbarch.
6136
6137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6138
6139         * nds32-tdep.c (nds32_dummy_id): Delete.
6140         (nds32_unwind_pc): Delete.
6141         (nds32_unwind_sp): Delete.
6142         (nds32_gdbarch_init): Don't register deleted functions with
6143         gdbarch.
6144
6145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * msp430-tdep.c (msp430_unwind_pc): Delete.
6148         (msp430_unwind_sp): Delete.
6149         (msp430_dummy_id): Delete.
6150         (msp430_gdbarch_init): Don't register deleted functions with
6151         gdbarch.
6152
6153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * moxie-tdep.c (moxie_unwind_sp): Delete.
6156         (moxie_unwind_pc): Delete.
6157         (moxie_dummy_id): Delete.
6158         (moxie_gdbarch_init): Don't register deleted functions with
6159         gdbarch.
6160
6161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6164         (mn10300_unwind_pc): Delete.
6165         (mn10300_unwind_sp): Delete.
6166         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6167         mn10300_unwind_sp.
6168         (mn10300_frame_unwind_init): Don't register deleted functions with
6169         gdbarch.
6170
6171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * mep-tdep.c (mep_unwind_pc): Delete.
6174         (mep_unwind_sp): Delete.
6175         (mep_dummy_id): Delete.
6176         (mep_gdbarch_init): Don't register deleted functions with
6177         gdbarch.
6178
6179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6182         (m68hc11_unwind_sp): Delete.
6183         (m68hc11_gdbarch_init): Don't register deleted functions with
6184         gdbarch.
6185
6186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * m32r-tdep.c (m32r_unwind_sp): Delete.
6189         (m32r_unwind_pc): Delete.
6190         (m32r_dummy_id): Delete.
6191         (m32r_gdbarch_init): Don't register deleted functions with
6192         gdbarch.
6193
6194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6195
6196         * m32c-tdep.c (m32c_unwind_pc): Delete.
6197         (m32c_unwind_sp): Delete.
6198         (m32c_dummy_id): Delete.
6199         (m32c_gdbarch_init): Don't register deleted functions with
6200         gdbarch.
6201
6202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6205         (lm32_unwind_pc): Delete.
6206         (lm32_dummy_id): Delete.
6207         (lm32_gdbarch_init): Don't register deleted functions with
6208         gdbarch.
6209
6210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6213         (iq2000_unwind_pc): Delete.
6214         (iq2000_dummy_id): Delete.
6215         (iq2000_gdbarch_init): Don't register deleted functions with
6216         gdbarch.
6217
6218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * nds32-tdep.c (nds32_type_align): Delete.
6221         (nds32_push_dummy_call): Use type_align instead.
6222
6223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * arm-tdep.c (arm_type_align): Only handle vector override case.
6226         (arm_push_dummy_call): Use type_align.
6227         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6228
6229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6232         case.
6233         (pass_on_stack): Use type_align.
6234         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6235         function.
6236
6237 2019-04-23  Tom Tromey  <tromey@adacore.com>
6238
6239         * dwarf2read.c (line_header::file_name_at): Remove unused
6240         overload.
6241
6242 2019-04-23  Tom de Vries  <tdevries@suse.de>
6243
6244         PR gdb/24438
6245         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6246         invocation.
6247
6248
6249 2019-03-27  Ali Tamur  <tamur@google.com>
6250
6251         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6252         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6253         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6254         (dwarf_expr_context::get_addr_index): Likewise
6255         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6256         (symbol_needs_eval_context::get_addr_index): Likewise
6257         (disassemble_dwarf_expression): Add DW_OP_addrx
6258         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6259         (read_cutu_die_from_dwo): Update comment
6260         (skip_one_die): Add DW_FORM_addrx
6261         (read_attribute_value): Likewise
6262         (var_decode_location): Add DW_OP_addrx
6263         (dwarf2_const_value_attr): Add DW_FORM_addrx
6264         (dump_die_shallow): Likewise
6265         (dwarf2_fetch_constant_bytes): Likewise
6266         (decode_locdesc): Add DW_OP_addrx
6267         (skip_form_bytes): Add DW_FORM_addrx
6268
6269 2019-04-22  Ali Tamur  <tamur@google.com>
6270
6271         * MAINTAINERS (Write After Approval): Add self.
6272
6273 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6274
6275         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6276         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6277         (open_symbol_file_object): Likewise.
6278         (svr4_default_sos): Add info parameter.
6279         (svr4_read_so_list): Likewise.
6280         (svr4_current_sos_direct): Adjust functions calls to pass down
6281         info.
6282         (svr4_current_sos_1): Add info parameter.
6283         (svr4_current_sos): Call get_svr4_info, pass info down to
6284         svr4_current_sos_1.
6285         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6286         get_svr4_info.
6287         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6288         get_svr4_info.
6289         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6290         to get_svr4_info.
6291         (probes_table_remove_objfile_probes): Likewise.
6292         (register_solib_event_probe): Add info parameter.
6293         (solist_update_incremental): Pass info parameter down to
6294         svr4_read_so_list.
6295         (disable_probes_interface): Add info parameter.
6296         (svr4_handle_solib_event): Pass current_program_space to
6297         get_svr4_info.  Adjust disable_probes_interface cleanup.
6298         (svr4_create_probe_breakpoints): Add info parameter, pass it
6299         down to register_solib_event_probe.
6300         (svr4_create_solib_event_breakpoints): Add info parameter,
6301         pass it down to svr4_create_probe_breakpoints.
6302         (enable_break): Pass info down to
6303         svr4_create_solib_event_breakpoints.
6304         (svr4_solib_create_inferior_hook): Pass current_program_space to
6305         get_svr4_info.
6306         (svr4_clear_solib): Likewise.
6307
6308 2019-04-22  Pedro Alves  <palves@redhat.com>
6309
6310         * solib-svr4.c (svr4_free_objfile_observer): New.
6311         (probe_and_action::objfile): New field.
6312         (probes_table_htab_remove_objfile_probes)
6313         (probes_table_remove_objfile_probes): New functions.
6314         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6315         in the new probe_and_action.  Don't store the probe in 'lookup'.
6316         (svr4_create_probe_breakpoints): Pass objfile to
6317         register_solib_event_probe.
6318         (_initialize_svr4_solib): Register a free_objfile observer.
6319
6320 2019-04-19  Tom Tromey  <tom@tromey.com>
6321
6322         * common/queue.h: Remove.
6323
6324 2019-04-19  Tom Tromey  <tom@tromey.com>
6325
6326         * event-loop.c: Don't include "common/queue.h".
6327
6328 2019-04-19  Tom Tromey  <tom@tromey.com>
6329
6330         * remote.c (remote_target): Use delete.
6331         * remote-notif.h: Include <list>, not "common/queue.h".
6332         (notif_client_p): Remove typedef.
6333         (remote_notif_state): Add constructor, destructor, initializer.
6334         <notif_queue>: Now a std::list.
6335         (remote_notif_state_xfree): Don't declare.
6336         * remote-notif.c (remote_notif_process, handle_notification)
6337         (remote_notif_state_allocate): Update.
6338         (~remote_notif_state): Rename from remote_notif_state_xfree.
6339
6340 2019-04-19  Tom Tromey  <tom@tromey.com>
6341
6342         * symfile.c (reread_symbols): Update.
6343         * objfiles.c (objfile_register_static_link)
6344         (objfile_lookup_static_link): Update
6345         (~objfile) Don't delete static_links.
6346         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6347
6348 2019-04-19  Tom Tromey  <tom@tromey.com>
6349
6350         * type-stack.h (struct type_stack) <insert>: Constify string.
6351         * type-stack.c (type_stack::insert): Constify string.
6352         * gdbtypes.h (lookup_template_type): Update.
6353         (address_space_name_to_int): Update.
6354         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6355         const.
6356         (lookup_template_type): Make name const.
6357         * c-exp.y: Update rules.
6358         (lex_one_token, classify_name, classify_inner_name)
6359         (c_print_token): Update.
6360         * p-exp.y: Update rules.
6361         (yylex): Update.
6362         * f-exp.y: Update rules.
6363         (yylex): Update.
6364         * d-exp.y: Update rules.
6365         (lex_one_token, classify_name, classify_inner_name): Update.
6366         * parse.c (write_dollar_variable, copy_name): Return std::string.
6367         * parser-defs.h (copy_name): Change return type.
6368         * m2-exp.y: Update rules.
6369         (yylex): Update.
6370         * go-exp.y (lex_one_token): Update.
6371         Update rules.
6372         (classify_unsafe_function, classify_packaged_name)
6373         (classify_name, yylex): Update.
6374
6375 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6376
6377         * configure.ac: add --enable-source-highlight switch.
6378         * configure: Regenerate.
6379         * top.c (print_gdb_version): plumb --enable-source-highlight
6380         status to "show configuration".
6381
6382 2019-04-19  Tom Tromey  <tromey@adacore.com>
6383
6384         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6385         Check ADA_TYPE_P.
6386         (empty_record, ada_template_to_fixed_record_type_1)
6387         (template_to_static_fixed_type)
6388         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6389         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6390         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6391         macros.
6392
6393 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6394
6395         PR symtab/24423:
6396         * source.c (print_source_lines_base): Advance "iter" when a
6397         control character is seen.
6398
6399 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * inferior.h (struct infcall_suspend_state_deleter):
6402         Catch exception in destructor to avoid crash.
6403
6404 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6405
6406         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6407         close to the add_com "shell".
6408
6409 2019-04-18  Tom Tromey  <tromey@adacore.com>
6410
6411         * process-stratum-target.h (class process_stratum_target)
6412         <stratum>: Add "final".
6413
6414 2019-04-17  Tom Tromey  <tromey@adacore.com>
6415
6416         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6417         against nullptr before use.
6418
6419 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6420
6421         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6422
6423 2019-04-17  Jim Wilson  <jimw@sifive.com>
6424             Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6427         code read might fail, assume 4-byte breakpoint in that case.
6428
6429 2019-04-15  Leszek Swirski  <leszeks@google.com>
6430
6431         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6432         rather than a hand-rolled POD check when checking for forced MEMORY
6433         classification.
6434
6435 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6436
6437         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6438         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6439         function.
6440         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6441         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6442         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6443         declaration.
6444
6445 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6446
6447         * aarch64-linux-nat.c
6448         (aarch64_linux_nat_target::thread_architecture): Add override.
6449         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6450         each VQ.
6451
6452 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6453
6454         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6455
6456 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6459         target types of size 96-bits, add some additional comments, and
6460         check that the builtin type we found was the correct size.
6461
6462 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6463
6464         * utils.c (prompt_for_continue): Don't restore the styling at the
6465         end, as applied_style has the wrong value.  This fixes styling in
6466         long lists of file names that are interrupted by the "Continue?"
6467         prompt.
6468
6469 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6472         * c-lang.c (c_language_defn): Likewise.
6473         (cplus_language_defn): Likewise.
6474         (asm_language_defn): Likewise.
6475         (minimal_language_defn): Likewise.
6476         * d-lang.c (d_language_defn): Likewise.
6477         * f-lang.c (f_language_defn): Likewise.
6478         * go-lang.c (go_language_defn): Likewise.
6479         * language.c (unknown_language_defn): Likewise.
6480         (auto_language_defn): Likewise.
6481         * language.h (struct language_defn): Remove la_magic field.
6482         (LANG_MAGIC): Delete.
6483         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6484         * objc-lang.c (objc_language_defn): Likewise.
6485         * opencl-lang.c (opencl_language_defn): Likewise.
6486         * p-lang.c (pascal_language_defn): Likewise.
6487         * rust-lang.c (rust_language_defn): Likewise.
6488
6489 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * riscv-tdep.c (riscv_type_align): New function.
6492         (riscv_type_alignment): Delete.
6493         (riscv_arg_location): Use 'type_align'.
6494         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6495
6496 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * gdbtypes.c (type_align): A struct with no non-static fields also
6499         has alignment of 1.
6500
6501 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6504         component to 0.
6505         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6506         member.
6507         (riscv_struct_info::analyse): New implementation using new
6508         analyse_inner member function.
6509         (riscv_struct_info::field_offset): New member function.
6510         (riscv_struct_info::m_offsets): New member variable.
6511         (riscv_struct_info::analyse_inner): New private member function,
6512         takes the old implementation of riscv_struct_info::analyse but
6513         extended to track field offsets.
6514         (riscv_call_arg_struct): Update the struct folding special cases
6515         to handle cases where empty C++ structs, which are non-zero
6516         length, are found.
6517         (riscv_arg_location): Initialise the length of each location, a
6518         non-zero length now indicates the location is in use.
6519         (riscv_push_dummy_call): Allow for the first location having a
6520         non-zero offset when setting up arguments.
6521         (riscv_return_value): Likewise, but for return values.
6522
6523 2019-04-11  Tom Tromey  <tromey@adacore.com>
6524
6525         * utils.c (internal_vproblem): Make "msg" const.
6526
6527 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6528
6529         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6530         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6531         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6532         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6533
6534 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6535
6536         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6537         function.
6538         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6539         of amd64_collect_native_gregset.
6540         (amd64_linux_nat_target::store_registers): Likewise.
6541
6542 2019-04-10  Tom Tromey  <tom@tromey.com>
6543
6544         * symtab.c (lookup_global_symbol_from_objfile)
6545         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6546         * objfiles.h (class separate_debug_iterator): New.
6547         (class separate_debug_range): New.
6548         (struct objfile) <separate_debug_objfiles>: New method.
6549         (objfile_separate_debug_iterate): Don't declare.
6550         * objfiles.c (separate_debug_iterator::operator++): Rename from
6551         objfile_separate_debug_iterate.
6552         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6553         iterator.
6554         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6555         iterator.
6556
6557 2019-04-10  Tom Tromey  <tom@tromey.com>
6558
6559         * symfile.c (reread_symbols): Remove old comment.
6560         * objfiles.c (free_all_objfiles): Fix a typo.
6561
6562 2019-04-10  Tom Tromey  <tom@tromey.com>
6563
6564         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6565         * minsyms.c (lookup_minimal_symbol): Use foreach.
6566         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6567         (lookup_minimal_symbol_solib_trampoline): Likewise.
6568         * symfile.c (reread_symbols): Use foreach.
6569
6570 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6571             Tom Tromey  <tromey@adacore.com>
6572
6573         PR rust/24414:
6574         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6575         (rust_lex_int_test): Change "value" to be LONGEST.
6576         (rust_lex_tests): Add test for long integer literal.
6577
6578 2019-04-09  Tom Tromey  <tromey@adacore.com>
6579
6580         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6581         to bool.
6582         (extended_remote_target::attach): Update.
6583         (remote_target::remote_notice_new_inferior): Update.
6584         (remote_target::add_current_inferior_and_thread): Update.
6585         * inferior.c (exit_inferior_1): Use "false".
6586         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6587
6588 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6589
6590         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6591         the "start" command.
6592
6593 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6594
6595         * python/py-inferior.c (infpy_thread_from_thread_handle):
6596         Adjust comments to reflect renaming of thread_from_thread_handle
6597         to thread_from_handle.  Adjust keywords.  Fix type error message.
6598         (inferior_object_methods): Add thread_from_handle.  Retain
6599         thread_from_thread_handle, but mark it as deprecated.
6600
6601 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6602
6603         * gdbthread.h (find_thread_by_handle): Revise declaration.
6604         * thread.c (find_thread_by_handle): Likewise.  Adjust
6605         implementation too.
6606         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6607         support for buffer objects as handles.
6608
6609 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6610
6611         * python/py-infthread.c (thpy_thread_handle): New function.
6612         (thread_object_methods): Register thpy_thread_handle.
6613
6614 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6615
6616         * gdbthread.h (thread_to_thread_handle): Declare.
6617         * thread.c (gdbtypes.h): Include.
6618         (thread_to_thread_handle): New function.
6619
6620         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6621         (target_thread_info_to_thread_handle): Declare.
6622         * target.c (target_thread_info_to_thread_handle): New function.
6623         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6624         * target-delegates.c: Regenerate.
6625
6626         * linux-thread-db.c (class thread_db_target): Add method
6627         thread_info_to_thread_handle.
6628         (thread_db_target::thread_info_to_thread_handle): Define.
6629         * remote.c (class remote_target): Add new method
6630         thread_info_to_thread_handle.
6631         (remote_target::thread_info_to_thread_handle): Define.
6632
6633 2019-04-08  Pedro Alves  <palves@redhat.com>
6634
6635         * common/common-exceptions.c (throw_exception): Don't create
6636         named object to throw; throw directly.
6637         (throw_it): Likewise.  Don't initialize gdb_exception::message
6638         here, with new; pass FMT and AP to the ctor instead.
6639         * common/common-exceptions.h: Include <string>.
6640         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6641         const char *, va_list)): New ctor.  Use std::make_shared.
6642         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6643         errors)): Delete.
6644         (gdb_exception_error::gdb_exception_error(enum errors, const char
6645         *, va_list)): New.
6646         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6647         Add assertion.
6648         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6649         errors)): Delete.
6650         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6651         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6652         Add assertion.
6653
6654 2019-04-08  Tom Tromey  <tom@tromey.com>
6655
6656         * valops.c (value_rtti_indirect_type): Replace throw_exception
6657         with throw.
6658         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6659         with throw.
6660         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6661         throw.
6662         * target.c (target_translate_tls_address): Replace throw_exception
6663         with throw.
6664         * stack.c (frame_apply_command_count): Replace throw_exception
6665         with throw.
6666         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6667         throw.
6668         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6669         with throw.
6670         * rs6000-tdep.c (rs6000_frame_cache)
6671         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6672         * remote.c: Replace throw_exception with throw.
6673         * record-full.c (record_full_message, record_full_wait_1)
6674         (record_full_restore): Replace throw_exception with throw.
6675         * record-btrace.c:
6676         (get_thread_current_frame_id, record_btrace_start_replaying)
6677         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6678         (cmd_record_btrace_start): Replace throw_exception with throw.
6679         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6680         throw.
6681         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6682         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6683         * linespec.c:
6684         (find_linespec_symbols): Replace throw_exception with throw.
6685         * infrun.c (displaced_step_prepare, resume): Replace
6686         throw_exception with throw.
6687         * infcmd.c (post_create_inferior): Replace throw_exception with
6688         throw.
6689         * inf-loop.c (inferior_event_handler): Replace throw_exception
6690         with throw.
6691         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6692         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6693         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6694         (get_prev_frame_always, get_frame_pc_if_available)
6695         (get_frame_address_in_block_if_available, get_frame_language):
6696         Replace throw_exception with throw.
6697         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6698         throw_exception with throw.
6699         * eval.c (fetch_subexp_value, evaluate_var_value)
6700         (evaluate_funcall, evaluate_subexp_standard): Replace
6701         throw_exception with throw.
6702         * dwarf2loc.c (call_site_find_chain)
6703         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6704         Replace throw_exception with throw.
6705         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6706         with throw.
6707         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6708         throw.
6709         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6710         * completer.c (complete_line_internal): Replace throw_exception
6711         with throw.
6712         * compile/compile-object-run.c (compile_object_run): Replace
6713         throw_exception with throw.
6714         * cli/cli-script.c (process_next_line): Replace throw_exception
6715         with throw.
6716         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6717         (btrace_enable, btrace_maint_update_pt_packets): Replace
6718         throw_exception with throw.
6719         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6720         throw_exception with throw.
6721         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6722         throw_exception with throw.
6723         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6724         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6725         * aarch64-tdep.c (aarch64_make_prologue_cache)
6726         (aarch64_make_stub_cache): Replace throw_exception with throw.
6727
6728 2019-04-08  Tom Tromey  <tom@tromey.com>
6729
6730         * common/common-exceptions.c (throw_exception): Rename from
6731         throw_exception_cxx.  Remove old copy.  Make argument const.
6732         (throw_it): Create and throw exception objects directly.
6733         * common/common-exceptions.h (throw_exception): Make argument
6734         const.
6735         (struct gdb_exception_error): Add constructor.
6736         (struct gdb_exception_quit): Add constructor.
6737
6738 2019-04-08  Tom Tromey  <tom@tromey.com>
6739
6740         * common/common-exceptions.h (exception_rethrow): Don't declare.
6741         (TRY_SJLJ): Update comment.
6742         (TRY, CATCH, END_CATCH): Remove.
6743         * common/common-exceptions.c (exception_rethrow): Remove.
6744
6745 2019-04-08  Tom Tromey  <tom@tromey.com>
6746
6747         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6748         Remove.
6749         (gdb_exception_error): Rename from
6750         gdb_exception_RETURN_MASK_ERROR.
6751         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6752         (gdb_quit_bad_alloc): Update.
6753         * aarch64-tdep.c: Update.
6754         * ada-lang.c: Update.
6755         * ada-typeprint.c: Update.
6756         * ada-valprint.c: Update.
6757         * amd64-tdep.c: Update.
6758         * arch-utils.c: Update.
6759         * break-catch-throw.c: Update.
6760         * breakpoint.c: Update.
6761         * btrace.c: Update.
6762         * c-varobj.c: Update.
6763         * cli/cli-cmds.c: Update.
6764         * cli/cli-interp.c: Update.
6765         * cli/cli-script.c: Update.
6766         * common/common-exceptions.c: Update.
6767         * common/new-op.c: Update.
6768         * common/selftest.c: Update.
6769         * compile/compile-c-symbols.c: Update.
6770         * compile/compile-cplus-symbols.c: Update.
6771         * compile/compile-object-load.c: Update.
6772         * compile/compile-object-run.c: Update.
6773         * completer.c: Update.
6774         * corelow.c: Update.
6775         * cp-abi.c: Update.
6776         * cp-support.c: Update.
6777         * cp-valprint.c: Update.
6778         * darwin-nat.c: Update.
6779         * disasm-selftests.c: Update.
6780         * dtrace-probe.c: Update.
6781         * dwarf-index-cache.c: Update.
6782         * dwarf-index-write.c: Update.
6783         * dwarf2-frame-tailcall.c: Update.
6784         * dwarf2-frame.c: Update.
6785         * dwarf2loc.c: Update.
6786         * dwarf2read.c: Update.
6787         * eval.c: Update.
6788         * event-loop.c: Update.
6789         * event-top.c: Update.
6790         * exec.c: Update.
6791         * f-valprint.c: Update.
6792         * fbsd-tdep.c: Update.
6793         * frame-unwind.c: Update.
6794         * frame.c: Update.
6795         * gdbtypes.c: Update.
6796         * gnu-v3-abi.c: Update.
6797         * guile/guile-internal.h: Update.
6798         * guile/scm-block.c: Update.
6799         * guile/scm-breakpoint.c: Update.
6800         * guile/scm-cmd.c: Update.
6801         * guile/scm-disasm.c: Update.
6802         * guile/scm-frame.c: Update.
6803         * guile/scm-lazy-string.c: Update.
6804         * guile/scm-math.c: Update.
6805         * guile/scm-param.c: Update.
6806         * guile/scm-ports.c: Update.
6807         * guile/scm-pretty-print.c: Update.
6808         * guile/scm-symbol.c: Update.
6809         * guile/scm-symtab.c: Update.
6810         * guile/scm-type.c: Update.
6811         * guile/scm-value.c: Update.
6812         * i386-linux-tdep.c: Update.
6813         * i386-tdep.c: Update.
6814         * inf-loop.c: Update.
6815         * infcall.c: Update.
6816         * infcmd.c: Update.
6817         * infrun.c: Update.
6818         * jit.c: Update.
6819         * language.c: Update.
6820         * linespec.c: Update.
6821         * linux-fork.c: Update.
6822         * linux-nat.c: Update.
6823         * linux-tdep.c: Update.
6824         * linux-thread-db.c: Update.
6825         * main.c: Update.
6826         * mi/mi-cmd-break.c: Update.
6827         * mi/mi-cmd-stack.c: Update.
6828         * mi/mi-interp.c: Update.
6829         * mi/mi-main.c: Update.
6830         * objc-lang.c: Update.
6831         * p-valprint.c: Update.
6832         * parse.c: Update.
6833         * ppc-linux-tdep.c: Update.
6834         * printcmd.c: Update.
6835         * python/py-arch.c: Update.
6836         * python/py-breakpoint.c: Update.
6837         * python/py-cmd.c: Update.
6838         * python/py-finishbreakpoint.c: Update.
6839         * python/py-frame.c: Update.
6840         * python/py-framefilter.c: Update.
6841         * python/py-gdb-readline.c: Update.
6842         * python/py-inferior.c: Update.
6843         * python/py-infthread.c: Update.
6844         * python/py-lazy-string.c: Update.
6845         * python/py-linetable.c: Update.
6846         * python/py-objfile.c: Update.
6847         * python/py-param.c: Update.
6848         * python/py-prettyprint.c: Update.
6849         * python/py-progspace.c: Update.
6850         * python/py-record-btrace.c: Update.
6851         * python/py-record.c: Update.
6852         * python/py-symbol.c: Update.
6853         * python/py-type.c: Update.
6854         * python/py-unwind.c: Update.
6855         * python/py-utils.c: Update.
6856         * python/py-value.c: Update.
6857         * python/python.c: Update.
6858         * record-btrace.c: Update.
6859         * record-full.c: Update.
6860         * remote-fileio.c: Update.
6861         * remote.c: Update.
6862         * riscv-tdep.c: Update.
6863         * rs6000-aix-tdep.c: Update.
6864         * rs6000-tdep.c: Update.
6865         * rust-exp.y: Update.
6866         * rust-lang.c: Update.
6867         * s390-tdep.c: Update.
6868         * selftest-arch.c: Update.
6869         * solib-dsbt.c: Update.
6870         * solib-frv.c: Update.
6871         * solib-spu.c: Update.
6872         * solib-svr4.c: Update.
6873         * solib.c: Update.
6874         * sparc64-linux-tdep.c: Update.
6875         * stack.c: Update.
6876         * symfile-mem.c: Update.
6877         * symmisc.c: Update.
6878         * target.c: Update.
6879         * thread.c: Update.
6880         * top.c: Update.
6881         * tracefile-tfile.c: Update.
6882         * tui/tui.c: Update.
6883         * typeprint.c: Update.
6884         * unittests/cli-utils-selftests.c: Update.
6885         * unittests/parse-connection-spec-selftests.c: Update.
6886         * valops.c: Update.
6887         * valprint.c: Update.
6888         * value.c: Update.
6889         * varobj.c: Update.
6890         * windows-nat.c: Update.
6891         * x86-linux-nat.c: Update.
6892         * xml-support.c: Update.
6893
6894 2019-04-08  Tom Tromey  <tom@tromey.com>
6895
6896         * xml-support.c: Use C++ exception handling.
6897         * x86-linux-nat.c: Use C++ exception handling.
6898         * windows-nat.c: Use C++ exception handling.
6899         * varobj.c: Use C++ exception handling.
6900         * value.c: Use C++ exception handling.
6901         * valprint.c: Use C++ exception handling.
6902         * valops.c: Use C++ exception handling.
6903         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6904         handling.
6905         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6906         * typeprint.c: Use C++ exception handling.
6907         * tui/tui.c: Use C++ exception handling.
6908         * tracefile-tfile.c: Use C++ exception handling.
6909         * top.c: Use C++ exception handling.
6910         * thread.c: Use C++ exception handling.
6911         * target.c: Use C++ exception handling.
6912         * symmisc.c: Use C++ exception handling.
6913         * symfile-mem.c: Use C++ exception handling.
6914         * stack.c: Use C++ exception handling.
6915         * sparc64-linux-tdep.c: Use C++ exception handling.
6916         * solib.c: Use C++ exception handling.
6917         * solib-svr4.c: Use C++ exception handling.
6918         * solib-spu.c: Use C++ exception handling.
6919         * solib-frv.c: Use C++ exception handling.
6920         * solib-dsbt.c: Use C++ exception handling.
6921         * selftest-arch.c: Use C++ exception handling.
6922         * s390-tdep.c: Use C++ exception handling.
6923         * rust-lang.c: Use C++ exception handling.
6924         * rust-exp.y: Use C++ exception handling.
6925         * rs6000-tdep.c: Use C++ exception handling.
6926         * rs6000-aix-tdep.c: Use C++ exception handling.
6927         * riscv-tdep.c: Use C++ exception handling.
6928         * remote.c: Use C++ exception handling.
6929         * remote-fileio.c: Use C++ exception handling.
6930         * record-full.c: Use C++ exception handling.
6931         * record-btrace.c: Use C++ exception handling.
6932         * python/python.c: Use C++ exception handling.
6933         * python/py-value.c: Use C++ exception handling.
6934         * python/py-utils.c: Use C++ exception handling.
6935         * python/py-unwind.c: Use C++ exception handling.
6936         * python/py-type.c: Use C++ exception handling.
6937         * python/py-symbol.c: Use C++ exception handling.
6938         * python/py-record.c: Use C++ exception handling.
6939         * python/py-record-btrace.c: Use C++ exception handling.
6940         * python/py-progspace.c: Use C++ exception handling.
6941         * python/py-prettyprint.c: Use C++ exception handling.
6942         * python/py-param.c: Use C++ exception handling.
6943         * python/py-objfile.c: Use C++ exception handling.
6944         * python/py-linetable.c: Use C++ exception handling.
6945         * python/py-lazy-string.c: Use C++ exception handling.
6946         * python/py-infthread.c: Use C++ exception handling.
6947         * python/py-inferior.c: Use C++ exception handling.
6948         * python/py-gdb-readline.c: Use C++ exception handling.
6949         * python/py-framefilter.c: Use C++ exception handling.
6950         * python/py-frame.c: Use C++ exception handling.
6951         * python/py-finishbreakpoint.c: Use C++ exception handling.
6952         * python/py-cmd.c: Use C++ exception handling.
6953         * python/py-breakpoint.c: Use C++ exception handling.
6954         * python/py-arch.c: Use C++ exception handling.
6955         * printcmd.c: Use C++ exception handling.
6956         * ppc-linux-tdep.c: Use C++ exception handling.
6957         * parse.c: Use C++ exception handling.
6958         * p-valprint.c: Use C++ exception handling.
6959         * objc-lang.c: Use C++ exception handling.
6960         * mi/mi-main.c: Use C++ exception handling.
6961         * mi/mi-interp.c: Use C++ exception handling.
6962         * mi/mi-cmd-stack.c: Use C++ exception handling.
6963         * mi/mi-cmd-break.c: Use C++ exception handling.
6964         * main.c: Use C++ exception handling.
6965         * linux-thread-db.c: Use C++ exception handling.
6966         * linux-tdep.c: Use C++ exception handling.
6967         * linux-nat.c: Use C++ exception handling.
6968         * linux-fork.c: Use C++ exception handling.
6969         * linespec.c: Use C++ exception handling.
6970         * language.c: Use C++ exception handling.
6971         * jit.c: Use C++ exception handling.
6972         * infrun.c: Use C++ exception handling.
6973         * infcmd.c: Use C++ exception handling.
6974         * infcall.c: Use C++ exception handling.
6975         * inf-loop.c: Use C++ exception handling.
6976         * i386-tdep.c: Use C++ exception handling.
6977         * i386-linux-tdep.c: Use C++ exception handling.
6978         * guile/scm-value.c: Use C++ exception handling.
6979         * guile/scm-type.c: Use C++ exception handling.
6980         * guile/scm-symtab.c: Use C++ exception handling.
6981         * guile/scm-symbol.c: Use C++ exception handling.
6982         * guile/scm-pretty-print.c: Use C++ exception handling.
6983         * guile/scm-ports.c: Use C++ exception handling.
6984         * guile/scm-param.c: Use C++ exception handling.
6985         * guile/scm-math.c: Use C++ exception handling.
6986         * guile/scm-lazy-string.c: Use C++ exception handling.
6987         * guile/scm-frame.c: Use C++ exception handling.
6988         * guile/scm-disasm.c: Use C++ exception handling.
6989         * guile/scm-cmd.c: Use C++ exception handling.
6990         * guile/scm-breakpoint.c: Use C++ exception handling.
6991         * guile/scm-block.c: Use C++ exception handling.
6992         * guile/guile-internal.h: Use C++ exception handling.
6993         * gnu-v3-abi.c: Use C++ exception handling.
6994         * gdbtypes.c: Use C++ exception handling.
6995         * frame.c: Use C++ exception handling.
6996         * frame-unwind.c: Use C++ exception handling.
6997         * fbsd-tdep.c: Use C++ exception handling.
6998         * f-valprint.c: Use C++ exception handling.
6999         * exec.c: Use C++ exception handling.
7000         * event-top.c: Use C++ exception handling.
7001         * event-loop.c: Use C++ exception handling.
7002         * eval.c: Use C++ exception handling.
7003         * dwarf2read.c: Use C++ exception handling.
7004         * dwarf2loc.c: Use C++ exception handling.
7005         * dwarf2-frame.c: Use C++ exception handling.
7006         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7007         * dwarf-index-write.c: Use C++ exception handling.
7008         * dwarf-index-cache.c: Use C++ exception handling.
7009         * dtrace-probe.c: Use C++ exception handling.
7010         * disasm-selftests.c: Use C++ exception handling.
7011         * darwin-nat.c: Use C++ exception handling.
7012         * cp-valprint.c: Use C++ exception handling.
7013         * cp-support.c: Use C++ exception handling.
7014         * cp-abi.c: Use C++ exception handling.
7015         * corelow.c: Use C++ exception handling.
7016         * completer.c: Use C++ exception handling.
7017         * compile/compile-object-run.c: Use C++ exception handling.
7018         * compile/compile-object-load.c: Use C++ exception handling.
7019         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7020         * compile/compile-c-symbols.c: Use C++ exception handling.
7021         * common/selftest.c: Use C++ exception handling.
7022         * common/new-op.c: Use C++ exception handling.
7023         * cli/cli-script.c: Use C++ exception handling.
7024         * cli/cli-interp.c: Use C++ exception handling.
7025         * cli/cli-cmds.c: Use C++ exception handling.
7026         * c-varobj.c: Use C++ exception handling.
7027         * btrace.c: Use C++ exception handling.
7028         * breakpoint.c: Use C++ exception handling.
7029         * break-catch-throw.c: Use C++ exception handling.
7030         * arch-utils.c: Use C++ exception handling.
7031         * amd64-tdep.c: Use C++ exception handling.
7032         * ada-valprint.c: Use C++ exception handling.
7033         * ada-typeprint.c: Use C++ exception handling.
7034         * ada-lang.c: Use C++ exception handling.
7035         * aarch64-tdep.c: Use C++ exception handling.
7036
7037 2019-04-08  Tom Tromey  <tom@tromey.com>
7038
7039         * xml-support.c (gdb_xml_parser::parse): Update.
7040         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7041         * value.c (show_convenience): Update.
7042         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7043         (test_parse_flags_qcs): Update.
7044         * thread.c (thr_try_catch_cmd): Update.
7045         * target.c (target_translate_tls_address): Update.
7046         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7047         (info_frame_command_core, frame_apply_command_count): Update.
7048         * rust-exp.y (rust_lex_exception_test): Update.
7049         * riscv-tdep.c (riscv_print_one_register_info): Update.
7050         * remote.c (remote_target::enable_btrace): Update.
7051         * record-btrace.c (record_btrace_enable_warn): Update.
7052         * python/py-utils.c (gdbpy_convert_exception): Update.
7053         * printcmd.c (do_one_display, print_variable_and_value): Update.
7054         * mi/mi-main.c (mi_print_exception): Update.
7055         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7056         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7057         * linux-nat.c (linux_nat_target::attach): Update.
7058         * linux-fork.c (class scoped_switch_fork_info): Update.
7059         * infrun.c (displaced_step_prepare): Update.
7060         * infcall.c (call_function_by_hand_dummy): Update.
7061         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7062         * gnu-v3-abi.c (print_one_vtable): Update.
7063         * frame.c (get_prev_frame_always): Update.
7064         * f-valprint.c (info_common_command_for_block): Update.
7065         * exec.c (try_open_exec_file): Update.
7066         * exceptions.c (print_exception, exception_print)
7067         (exception_fprintf, exception_print_same): Update.
7068         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7069         * dwarf-index-cache.c (index_cache::store)
7070         (index_cache::lookup_gdb_index): Update.
7071         * darwin-nat.c (maybe_cache_shell): Update.
7072         * cp-valprint.c (cp_print_value_fields): Update.
7073         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7074         (gcc_cplus_symbol_address): Update.
7075         * compile/compile-c-symbols.c (gcc_convert_symbol)
7076         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7077         * common/selftest.c: Update.
7078         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7079         a std::string.
7080         (exception_try_scope_entry, exception_try_scope_exit): Don't
7081         declare.
7082         (struct exception_try_scope): Remove.
7083         (TRY): Don't use exception_try_scope.
7084         (struct gdb_exception): Add constructor, operator=.
7085         <what>: New method.
7086         (struct gdb_exception_RETURN_MASK_ALL)
7087         (struct gdb_exception_RETURN_MASK_ERROR)
7088         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7089         (struct gdb_quit_bad_alloc): Update.
7090         * common/common-exceptions.c (exception_none): Change
7091         initializer.
7092         (struct catcher) <state, exception>: Initialize inline.
7093         <prev>: Remove member.
7094         (current_catcher): Remove.
7095         (catchers): New global.
7096         (exceptions_state_mc_init): Simplify.
7097         (catcher_pop): Remove.
7098         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7099         (try_scope_depth, exception_try_scope_entry)
7100         (exception_try_scope_exit): Remove.
7101         (throw_exception_sjlj): Update.
7102         (exception_messages, exception_messages_size): Remove.
7103         (throw_it): Simplify.
7104         (gdb_exception_sliced_copy): Remove.
7105         (throw_exception_cxx): Update.
7106         * cli/cli-script.c (script_from_file): Update.
7107         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7108         Update.
7109         * ada-valprint.c (ada_val_print): Update.
7110         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7111         (create_excep_cond_exprs): Update.
7112
7113 2019-04-08  Tom Tromey  <tom@tromey.com>
7114
7115         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7116         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7117         (TRY, CATCH, END_CATCH): Remove some definitions.
7118         * common/common-exceptions.c: Don't use GDB_XCPT.
7119         (catcher_list_size): Remove.
7120         (throw_exception, throw_it): Simplify.
7121
7122 2019-04-05  Tom Tromey  <tom@tromey.com>
7123
7124         Revert the header-sorting patch.
7125         * ft32-tdep.c: Revert.
7126         * frv-tdep.c: Revert.
7127         * frv-linux-tdep.c: Revert.
7128         * frame.c: Revert.
7129         * frame-unwind.c: Revert.
7130         * frame-base.c: Revert.
7131         * fork-child.c: Revert.
7132         * findvar.c: Revert.
7133         * findcmd.c: Revert.
7134         * filesystem.c: Revert.
7135         * filename-seen-cache.h: Revert.
7136         * filename-seen-cache.c: Revert.
7137         * fbsd-tdep.c: Revert.
7138         * fbsd-nat.h: Revert.
7139         * fbsd-nat.c: Revert.
7140         * f-valprint.c: Revert.
7141         * f-typeprint.c: Revert.
7142         * f-lang.c: Revert.
7143         * extension.h: Revert.
7144         * extension.c: Revert.
7145         * extension-priv.h: Revert.
7146         * expprint.c: Revert.
7147         * exec.h: Revert.
7148         * exec.c: Revert.
7149         * exceptions.c: Revert.
7150         * event-top.c: Revert.
7151         * event-loop.c: Revert.
7152         * eval.c: Revert.
7153         * elfread.c: Revert.
7154         * dwarf2read.h: Revert.
7155         * dwarf2read.c: Revert.
7156         * dwarf2loc.c: Revert.
7157         * dwarf2expr.h: Revert.
7158         * dwarf2expr.c: Revert.
7159         * dwarf2-frame.c: Revert.
7160         * dwarf2-frame-tailcall.c: Revert.
7161         * dwarf-index-write.h: Revert.
7162         * dwarf-index-write.c: Revert.
7163         * dwarf-index-common.c: Revert.
7164         * dwarf-index-cache.h: Revert.
7165         * dwarf-index-cache.c: Revert.
7166         * dummy-frame.c: Revert.
7167         * dtrace-probe.c: Revert.
7168         * disasm.h: Revert.
7169         * disasm.c: Revert.
7170         * disasm-selftests.c: Revert.
7171         * dictionary.c: Revert.
7172         * dicos-tdep.c: Revert.
7173         * demangle.c: Revert.
7174         * dcache.h: Revert.
7175         * dcache.c: Revert.
7176         * darwin-nat.h: Revert.
7177         * darwin-nat.c: Revert.
7178         * darwin-nat-info.c: Revert.
7179         * d-valprint.c: Revert.
7180         * d-namespace.c: Revert.
7181         * d-lang.c: Revert.
7182         * ctf.c: Revert.
7183         * csky-tdep.c: Revert.
7184         * csky-linux-tdep.c: Revert.
7185         * cris-tdep.c: Revert.
7186         * cris-linux-tdep.c: Revert.
7187         * cp-valprint.c: Revert.
7188         * cp-support.c: Revert.
7189         * cp-namespace.c: Revert.
7190         * cp-abi.c: Revert.
7191         * corelow.c: Revert.
7192         * corefile.c: Revert.
7193         * continuations.c: Revert.
7194         * completer.h: Revert.
7195         * completer.c: Revert.
7196         * complaints.c: Revert.
7197         * coffread.c: Revert.
7198         * coff-pe-read.c: Revert.
7199         * cli-out.h: Revert.
7200         * cli-out.c: Revert.
7201         * charset.c: Revert.
7202         * c-varobj.c: Revert.
7203         * c-valprint.c: Revert.
7204         * c-typeprint.c: Revert.
7205         * c-lang.c: Revert.
7206         * buildsym.c: Revert.
7207         * buildsym-legacy.c: Revert.
7208         * build-id.h: Revert.
7209         * build-id.c: Revert.
7210         * btrace.c: Revert.
7211         * bsd-uthread.c: Revert.
7212         * breakpoint.h: Revert.
7213         * breakpoint.c: Revert.
7214         * break-catch-throw.c: Revert.
7215         * break-catch-syscall.c: Revert.
7216         * break-catch-sig.c: Revert.
7217         * blockframe.c: Revert.
7218         * block.c: Revert.
7219         * bfin-tdep.c: Revert.
7220         * bfin-linux-tdep.c: Revert.
7221         * bfd-target.c: Revert.
7222         * bcache.c: Revert.
7223         * ax-general.c: Revert.
7224         * ax-gdb.h: Revert.
7225         * ax-gdb.c: Revert.
7226         * avr-tdep.c: Revert.
7227         * auxv.c: Revert.
7228         * auto-load.c: Revert.
7229         * arm-wince-tdep.c: Revert.
7230         * arm-tdep.c: Revert.
7231         * arm-symbian-tdep.c: Revert.
7232         * arm-pikeos-tdep.c: Revert.
7233         * arm-obsd-tdep.c: Revert.
7234         * arm-nbsd-tdep.c: Revert.
7235         * arm-nbsd-nat.c: Revert.
7236         * arm-linux-tdep.c: Revert.
7237         * arm-linux-nat.c: Revert.
7238         * arm-fbsd-tdep.c: Revert.
7239         * arm-fbsd-nat.c: Revert.
7240         * arm-bsd-tdep.c: Revert.
7241         * arch-utils.c: Revert.
7242         * arc-tdep.c: Revert.
7243         * arc-newlib-tdep.c: Revert.
7244         * annotate.h: Revert.
7245         * annotate.c: Revert.
7246         * amd64-windows-tdep.c: Revert.
7247         * amd64-windows-nat.c: Revert.
7248         * amd64-tdep.c: Revert.
7249         * amd64-sol2-tdep.c: Revert.
7250         * amd64-obsd-tdep.c: Revert.
7251         * amd64-obsd-nat.c: Revert.
7252         * amd64-nbsd-tdep.c: Revert.
7253         * amd64-nbsd-nat.c: Revert.
7254         * amd64-nat.c: Revert.
7255         * amd64-linux-tdep.c: Revert.
7256         * amd64-linux-nat.c: Revert.
7257         * amd64-fbsd-tdep.c: Revert.
7258         * amd64-fbsd-nat.c: Revert.
7259         * amd64-dicos-tdep.c: Revert.
7260         * amd64-darwin-tdep.c: Revert.
7261         * amd64-bsd-nat.c: Revert.
7262         * alpha-tdep.c: Revert.
7263         * alpha-obsd-tdep.c: Revert.
7264         * alpha-nbsd-tdep.c: Revert.
7265         * alpha-mdebug-tdep.c: Revert.
7266         * alpha-linux-tdep.c: Revert.
7267         * alpha-linux-nat.c: Revert.
7268         * alpha-bsd-tdep.c: Revert.
7269         * alpha-bsd-nat.c: Revert.
7270         * aix-thread.c: Revert.
7271         * agent.c: Revert.
7272         * addrmap.c: Revert.
7273         * ada-varobj.c: Revert.
7274         * ada-valprint.c: Revert.
7275         * ada-typeprint.c: Revert.
7276         * ada-tasks.c: Revert.
7277         * ada-lang.c: Revert.
7278         * aarch64-tdep.c: Revert.
7279         * aarch64-ravenscar-thread.c: Revert.
7280         * aarch64-newlib-tdep.c: Revert.
7281         * aarch64-linux-tdep.c: Revert.
7282         * aarch64-linux-nat.c: Revert.
7283         * aarch64-fbsd-tdep.c: Revert.
7284         * aarch64-fbsd-nat.c: Revert.
7285         * aarch32-linux-nat.c: Revert.
7286
7287 2019-04-05  Tom Tromey  <tom@tromey.com>
7288
7289         * ft32-tdep.c: Sort headers.
7290         * frv-tdep.c: Sort headers.
7291         * frv-linux-tdep.c: Sort headers.
7292         * frame.c: Sort headers.
7293         * frame-unwind.c: Sort headers.
7294         * frame-base.c: Sort headers.
7295         * fork-child.c: Sort headers.
7296         * findvar.c: Sort headers.
7297         * findcmd.c: Sort headers.
7298         * filesystem.c: Sort headers.
7299         * filename-seen-cache.h: Sort headers.
7300         * filename-seen-cache.c: Sort headers.
7301         * fbsd-tdep.c: Sort headers.
7302         * fbsd-nat.h: Sort headers.
7303         * fbsd-nat.c: Sort headers.
7304         * f-valprint.c: Sort headers.
7305         * f-typeprint.c: Sort headers.
7306         * f-lang.c: Sort headers.
7307         * extension.h: Sort headers.
7308         * extension.c: Sort headers.
7309         * extension-priv.h: Sort headers.
7310         * expprint.c: Sort headers.
7311         * exec.h: Sort headers.
7312         * exec.c: Sort headers.
7313         * exceptions.c: Sort headers.
7314         * event-top.c: Sort headers.
7315         * event-loop.c: Sort headers.
7316         * eval.c: Sort headers.
7317         * elfread.c: Sort headers.
7318         * dwarf2read.h: Sort headers.
7319         * dwarf2read.c: Sort headers.
7320         * dwarf2loc.c: Sort headers.
7321         * dwarf2expr.h: Sort headers.
7322         * dwarf2expr.c: Sort headers.
7323         * dwarf2-frame.c: Sort headers.
7324         * dwarf2-frame-tailcall.c: Sort headers.
7325         * dwarf-index-write.h: Sort headers.
7326         * dwarf-index-write.c: Sort headers.
7327         * dwarf-index-common.c: Sort headers.
7328         * dwarf-index-cache.h: Sort headers.
7329         * dwarf-index-cache.c: Sort headers.
7330         * dummy-frame.c: Sort headers.
7331         * dtrace-probe.c: Sort headers.
7332         * disasm.h: Sort headers.
7333         * disasm.c: Sort headers.
7334         * disasm-selftests.c: Sort headers.
7335         * dictionary.c: Sort headers.
7336         * dicos-tdep.c: Sort headers.
7337         * demangle.c: Sort headers.
7338         * dcache.h: Sort headers.
7339         * dcache.c: Sort headers.
7340         * darwin-nat.h: Sort headers.
7341         * darwin-nat.c: Sort headers.
7342         * darwin-nat-info.c: Sort headers.
7343         * d-valprint.c: Sort headers.
7344         * d-namespace.c: Sort headers.
7345         * d-lang.c: Sort headers.
7346         * ctf.c: Sort headers.
7347         * csky-tdep.c: Sort headers.
7348         * csky-linux-tdep.c: Sort headers.
7349         * cris-tdep.c: Sort headers.
7350         * cris-linux-tdep.c: Sort headers.
7351         * cp-valprint.c: Sort headers.
7352         * cp-support.c: Sort headers.
7353         * cp-namespace.c: Sort headers.
7354         * cp-abi.c: Sort headers.
7355         * corelow.c: Sort headers.
7356         * corefile.c: Sort headers.
7357         * continuations.c: Sort headers.
7358         * completer.h: Sort headers.
7359         * completer.c: Sort headers.
7360         * complaints.c: Sort headers.
7361         * coffread.c: Sort headers.
7362         * coff-pe-read.c: Sort headers.
7363         * cli-out.h: Sort headers.
7364         * cli-out.c: Sort headers.
7365         * charset.c: Sort headers.
7366         * c-varobj.c: Sort headers.
7367         * c-valprint.c: Sort headers.
7368         * c-typeprint.c: Sort headers.
7369         * c-lang.c: Sort headers.
7370         * buildsym.c: Sort headers.
7371         * buildsym-legacy.c: Sort headers.
7372         * build-id.h: Sort headers.
7373         * build-id.c: Sort headers.
7374         * btrace.c: Sort headers.
7375         * bsd-uthread.c: Sort headers.
7376         * breakpoint.h: Sort headers.
7377         * breakpoint.c: Sort headers.
7378         * break-catch-throw.c: Sort headers.
7379         * break-catch-syscall.c: Sort headers.
7380         * break-catch-sig.c: Sort headers.
7381         * blockframe.c: Sort headers.
7382         * block.c: Sort headers.
7383         * bfin-tdep.c: Sort headers.
7384         * bfin-linux-tdep.c: Sort headers.
7385         * bfd-target.c: Sort headers.
7386         * bcache.c: Sort headers.
7387         * ax-general.c: Sort headers.
7388         * ax-gdb.h: Sort headers.
7389         * ax-gdb.c: Sort headers.
7390         * avr-tdep.c: Sort headers.
7391         * auxv.c: Sort headers.
7392         * auto-load.c: Sort headers.
7393         * arm-wince-tdep.c: Sort headers.
7394         * arm-tdep.c: Sort headers.
7395         * arm-symbian-tdep.c: Sort headers.
7396         * arm-pikeos-tdep.c: Sort headers.
7397         * arm-obsd-tdep.c: Sort headers.
7398         * arm-nbsd-tdep.c: Sort headers.
7399         * arm-nbsd-nat.c: Sort headers.
7400         * arm-linux-tdep.c: Sort headers.
7401         * arm-linux-nat.c: Sort headers.
7402         * arm-fbsd-tdep.c: Sort headers.
7403         * arm-fbsd-nat.c: Sort headers.
7404         * arm-bsd-tdep.c: Sort headers.
7405         * arch-utils.c: Sort headers.
7406         * arc-tdep.c: Sort headers.
7407         * arc-newlib-tdep.c: Sort headers.
7408         * annotate.h: Sort headers.
7409         * annotate.c: Sort headers.
7410         * amd64-windows-tdep.c: Sort headers.
7411         * amd64-windows-nat.c: Sort headers.
7412         * amd64-tdep.c: Sort headers.
7413         * amd64-sol2-tdep.c: Sort headers.
7414         * amd64-obsd-tdep.c: Sort headers.
7415         * amd64-obsd-nat.c: Sort headers.
7416         * amd64-nbsd-tdep.c: Sort headers.
7417         * amd64-nbsd-nat.c: Sort headers.
7418         * amd64-nat.c: Sort headers.
7419         * amd64-linux-tdep.c: Sort headers.
7420         * amd64-linux-nat.c: Sort headers.
7421         * amd64-fbsd-tdep.c: Sort headers.
7422         * amd64-fbsd-nat.c: Sort headers.
7423         * amd64-dicos-tdep.c: Sort headers.
7424         * amd64-darwin-tdep.c: Sort headers.
7425         * amd64-bsd-nat.c: Sort headers.
7426         * alpha-tdep.c: Sort headers.
7427         * alpha-obsd-tdep.c: Sort headers.
7428         * alpha-nbsd-tdep.c: Sort headers.
7429         * alpha-mdebug-tdep.c: Sort headers.
7430         * alpha-linux-tdep.c: Sort headers.
7431         * alpha-linux-nat.c: Sort headers.
7432         * alpha-bsd-tdep.c: Sort headers.
7433         * alpha-bsd-nat.c: Sort headers.
7434         * aix-thread.c: Sort headers.
7435         * agent.c: Sort headers.
7436         * addrmap.c: Sort headers.
7437         * ada-varobj.c: Sort headers.
7438         * ada-valprint.c: Sort headers.
7439         * ada-typeprint.c: Sort headers.
7440         * ada-tasks.c: Sort headers.
7441         * ada-lang.c: Sort headers.
7442         * aarch64-tdep.c: Sort headers.
7443         * aarch64-ravenscar-thread.c: Sort headers.
7444         * aarch64-newlib-tdep.c: Sort headers.
7445         * aarch64-linux-tdep.c: Sort headers.
7446         * aarch64-linux-nat.c: Sort headers.
7447         * aarch64-fbsd-tdep.c: Sort headers.
7448         * aarch64-fbsd-nat.c: Sort headers.
7449         * aarch32-linux-nat.c: Sort headers.
7450
7451 2019-04-04  Tom Tromey  <tom@tromey.com>
7452
7453         * varobj.c (varobj_create): Update.
7454         * rust-exp.y (struct rust_parser) <update_innermost_block,
7455         lookup_symbol>: New methods.
7456         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7457         Rename.
7458         (rust_parser::rust_lookup_type)
7459         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7460         * printcmd.c (display_command, do_one_display): Update.
7461         * parser-defs.h (struct parser_state) <parser_state>: Add
7462         "tracker" parameter.
7463         (block_tracker): New member.
7464         (class innermost_block_tracker) <innermost_block_tracker>: Add
7465         "types" parameter.
7466         <reset>: Remove method.
7467         (innermost_block): Don't declare.
7468         (null_post_parser): Update.
7469         * parse.c (innermost_block): Remove global.
7470         (write_dollar_variable): Update.
7471         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7472         Remove "tracker_types" parameter.
7473         (parse_expression): Add "tracker" parameter.
7474         (parse_expression_for_completion): Update.
7475         (null_post_parser): Add "tracker" parameter.
7476         * p-exp.y: Update rules.
7477         * m2-exp.y: Update rules.
7478         * language.h (struct language_defn) <la_post_parser>: Add
7479         "tracker" parameter.
7480         * go-exp.y: Update rules.
7481         * f-exp.y: Update rules.
7482         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7483         parameter.
7484         * d-exp.y: Update rules.
7485         * c-exp.y: Update rules.
7486         * breakpoint.c (set_breakpoint_condition): Create an
7487         innermost_block_tracker.
7488         (watch_command_1): Likewise.
7489         * ada-lang.c (resolve): Add "tracker" parameter.
7490         (resolve_subexp): Likewise.
7491         * ada-exp.y (write_var_from_sym): Update.
7492
7493 2019-04-04  Tom Tromey  <tom@tromey.com>
7494
7495         * type-stack.h: New file.
7496         * type-stack.c: New file.
7497         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7498         type-stack.h.
7499         (insert_into_type_stack, insert_type, push_type, push_type_int)
7500         (insert_type_address_space, pop_type, pop_type_int)
7501         (pop_typelist, pop_type_stack, append_type_stack)
7502         (push_type_stack, get_type_stack, push_typelist)
7503         (follow_type_instance_flags, follow_types): Don't declare.
7504         * parse.c (type_stack): Remove global.
7505         (parse_exp_in_context): Update.
7506         (insert_into_type_stack, insert_type, push_type, push_type_int)
7507         (insert_type_address_space, pop_type, pop_type_int)
7508         (pop_typelist, pop_type_stack, append_type_stack)
7509         (push_type_stack, get_type_stack, push_typelist)
7510         (follow_type_instance_flags, follow_types): Remove (moved to
7511         type-stack.c).
7512         * f-exp.y (type_stack): New global.
7513         Update rules.
7514         (push_kind_type, f_parse): Update.
7515         * d-exp.y (type_stack): New global.
7516         Update rules.
7517         (d_parse): Update.
7518         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7519         Update rules.
7520         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7521         (HFILES_NO_SRCDIR): Add type-stack.h.
7522
7523 2019-04-04  Tom Tromey  <tom@tromey.com>
7524
7525         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7526         (rust_parser::convert_ast_to_expression, rust_parse)
7527         (rust_lex_test_completion, rust_lex_tests): Update.
7528         * parser-defs.h (struct expr_completion_state): New.
7529         (struct parser_state) <parser_state>: Add completion parameter.
7530         <mark_struct_expression, mark_completion_tag>: New methods.
7531         <parse_completion, m_completion_state>: New members.
7532         (prefixify_expression, null_post_parser): Update.
7533         (mark_struct_expression, mark_completion_tag): Don't declare.
7534         * parse.c (parse_completion, expout_last_struct)
7535         (expout_tag_completion_type, expout_completion_name): Remove
7536         globals.
7537         (parser_state::mark_struct_expression)
7538         (parser_state::mark_completion_tag): Now methods.
7539         (prefixify_expression): Add last_struct parameter.
7540         (prefixify_subexp): Likewise.
7541         (parse_exp_1): Update.
7542         (parse_exp_in_context): Add cstate parameter.  Update.
7543         (parse_expression_for_completion): Create an
7544         expr_completion_state.
7545         (null_post_parser): Add "completion" parameter.
7546         * p-exp.y: Update rules.
7547         (yylex): Update.
7548         * language.h (struct language_defn) <la_post_parser>: Add
7549         "completing" parameter.
7550         * go-exp.y: Update rules.
7551         (lex_one_token): Update.
7552         * expression.h (parse_completion): Don't declare.
7553         * d-exp.y: Update rules.
7554         (lex_one_token): Update rules.
7555         * c-exp.y: Update rules.
7556         (lex_one_token): Update.
7557         * ada-lang.c (resolve): Add "parse_completion" parameter.
7558         (resolve_subexp): Likewise.
7559         (ada_resolve_function): Likewise.
7560
7561 2019-04-04  Tom Tromey  <tom@tromey.com>
7562
7563         * parser-defs.h (struct parser_state) <start_arglist,
7564         end_arglist>: New methods.
7565         <arglist_len, m_funcall_chain>: New members.
7566         (arglist_len, start_arglist, end_arglist): Don't declare.
7567         * parse.c (arglist_len, funcall_chain): Remove global.
7568         (start_arglist, end_arglist): Remove functions.
7569         (parse_exp_in_context): Update.
7570         * p-exp.y: Update rules.
7571         * m2-exp.y: Update rules.
7572         * go-exp.y: Update rules.
7573         * f-exp.y: Update rules.
7574         * d-exp.y: Update rules.
7575         * c-exp.y: Update rules.
7576
7577 2019-04-04  Tom Tromey  <tom@tromey.com>
7578
7579         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7580         lex_operator, push_back>: New methods.
7581         Update all rules.
7582         (rust_parser::lex_hex, lex_escape): Rename and update.
7583         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7584         (rust_parser::lex_operator): Rename and update.
7585         (rust_parser::lex_number, rustyylex, rustyyerror)
7586         (rust_lex_test_init, rust_lex_test_sequence)
7587         (rust_lex_test_push_back, rust_lex_tests): Update.
7588         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7589         parameter.
7590         <lexptr, prev_lexptr>: New members.
7591         (lexptr, prev_lexptr): Don't declare.
7592         * parse.c (lexptr, prev_lexptr): Remove globals.
7593         (parse_exp_in_context): Update.
7594         * p-exp.y (yylex, yyerror): Update.
7595         * m2-exp.y (parse_number, yylex, yyerror): Update.
7596         * go-exp.y (lex_one_token, yyerror): Update.
7597         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7598         * d-exp.y (lex_one_token, yyerror): Update.
7599         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7600         (lex_one_token, yyerror): Update.
7601         * ada-lex.l (YY_INPUT): Update.
7602         (rewind_to_char): Update.
7603         * ada-exp.y (yyerror): Update.
7604
7605 2019-04-04  Tom Tromey  <tom@tromey.com>
7606
7607         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7608         * parser-defs.h (struct parser_state) <parser_state>: Add new
7609         parameter.
7610         <comma_terminates>: New member.
7611         (comma_terminates): Don't declare global.
7612         * parse.c (comma_terminates): Remove global.
7613         (parse_exp_in_context): Update.
7614         * p-exp.y (yylex): Update.
7615         * m2-exp.y (yylex): Update.
7616         * go-exp.y (lex_one_token): Update.
7617         * f-exp.y (yylex): Update.
7618         * d-exp.y (lex_one_token): Update.
7619         * c-exp.y (lex_one_token): Update.
7620         * ada-lex.l: Update.
7621
7622 2019-04-04  Tom Tromey  <tom@tromey.com>
7623
7624         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7625         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7626         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7627         * parser-defs.h (paren_depth): Don't declare.
7628         * parse.c (paren_depth): Remove global.
7629         (parse_exp_in_context): Update.
7630         * p-exp.y (paren_depth): New global.
7631         (pascal_parse): Initialize it.
7632         * m2-exp.y (paren_depth): New global.
7633         (m2_parse): Initialize it.
7634         * go-exp.y (paren_depth): New global.
7635         (go_parse): Initialize it.
7636         * f-exp.y (paren_depth): New global.
7637         (f_parse): Initialize it.
7638         * d-exp.y (paren_depth): New global.
7639         (d_parse): Initialize it.
7640         * c-exp.y (paren_depth): New global.
7641         (c_parse): Initialize it.
7642         * ada-lex.l (paren_depth): New global.
7643         (lexer_init): Initialize it.
7644
7645 2019-04-04  Tom Tromey  <tom@tromey.com>
7646
7647         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7648         (rust_parser::convert_ast_to_type)
7649         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7650         * parser-defs.h (struct parser_state) <parser_state>: Add
7651         parameters.  Initialize new members.
7652         <expression_context_block, expression_context_pc>: New members.
7653         * parse.c (expression_context_block, expression_context_pc):
7654         Remove globals.
7655         (parse_exp_in_context): Update.
7656         * p-exp.y: Update all rules.
7657         (yylex): Update.
7658         * m2-exp.y: Update all rules.
7659         (yylex): Update.
7660         * go-exp.y (yylex): Update.
7661         * f-exp.y (yylex): Update.
7662         * d-exp.y: Update all rules.
7663         (yylex): Update.
7664         * c-exp.y: Update all rules.
7665         (lex_one_token, classify_name, yylex, c_parse): Update.
7666         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7667
7668 2019-04-04  Tom Tromey  <tom@tromey.com>
7669
7670         * gdbarch.h, gdbarch.c: Rebuild.
7671         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7672         * stap-probe.h:
7673         (struct stap_parse_info): Replace "parser_state" with
7674         "expr_builder".
7675         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7676         (parser_state): New class.
7677         * parse.c (expr_builder): Rename.
7678         (expr_builder::release): Rename.
7679         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7680         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7681         (write_exp_elt_longcst, write_exp_elt_floatcst)
7682         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7683         (write_exp_string_vector, write_exp_bitstring)
7684         (write_exp_msymbol, mark_struct_expression)
7685         (write_dollar_variable)
7686         (insert_type_address_space, increase_expout_size): Replace
7687         "parser_state" with "expr_builder".
7688         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7689         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7690         "parser_state" with "expr_builder".
7691
7692 2019-04-04  Tom Tromey  <tom@tromey.com>
7693
7694         * rust-exp.y: Replace "parse_language" with method call.
7695         * p-exp.y:
7696         (yylex): Replace "parse_language" with method call.
7697         * m2-exp.y:
7698         (yylex): Replace "parse_language" with method call.
7699         * go-exp.y (classify_name): Replace "parse_language" with method
7700         call.
7701         * f-exp.y (yylex): Replace "parse_language" with method call.
7702         * d-exp.y (lex_one_token): Replace "parse_language" with method
7703         call.
7704         * c-exp.y:
7705         (lex_one_token, classify_name, yylex): Replace "parse_language"
7706         with method call.
7707         * ada-exp.y (find_primitive_type, type_char)
7708         (type_system_address): Replace "parse_language" with method call.
7709
7710 2019-04-04  Tom Tromey  <tom@tromey.com>
7711
7712         * rust-exp.y: Replace "parse_gdbarch" with method call.
7713         * parse.c (write_dollar_variable, insert_type_address_space):
7714         Replace "parse_gdbarch" with method call.
7715         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7716         call.
7717         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7718         call.
7719         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7720         "parse_gdbarch" with method call.
7721         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7722         with method call.
7723         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7724         "parse_gdbarch" with method call.
7725         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7726         "parse_gdbarch" with method call.
7727         * c-exp.y (parse_type, parse_number, classify_name): Replace
7728         "parse_gdbarch" with method call.
7729         * ada-lex.l: Replace "parse_gdbarch" with method call.
7730         * ada-exp.y (parse_type, find_primitive_type, type_char)
7731         (type_system_address): Replace "parse_gdbarch" with method call.
7732
7733 2019-04-04  Tom Tromey  <tom@tromey.com>
7734
7735         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7736         * stap-probe.c (stap_parse_argument): Update.
7737         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7738         initial_size parameter.
7739         * rust-exp.y (rust_lex_tests): Update.
7740         * parse.c (parser_state): Update.
7741         (parse_exp_in_context): Update.
7742         * parser-defs.h (struct parser_state) <parser_state>: Remove
7743         "initial_size" parameter.
7744
7745 2019-04-04  Tom Tromey  <tom@tromey.com>
7746
7747         * parser-defs.h (increase_expout_size): Don't declare.
7748         * parse.c (increase_expout_size): Now static.
7749
7750 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7751
7752         * gnu-nat.c (gnu_nat_target::wait): Fix
7753         target_waitstatus_to_string call.
7754
7755 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * eval.c (evaluate_subexp_standard): Handle internal functions
7758         during Fortran function call handling.
7759
7760 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * NEWS: Mention new internal functions.
7763         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7764         (read_base_type): Use dwarf2_init_complex_target_type.
7765         * value.c (creal_internal_fn): New function.
7766         (cimag_internal_fn): New function.
7767         (_initialize_values): Register new internal functions.
7768
7769 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7770
7771         * infrun.c (stop_all_threads): If debug_infrun, always
7772         trace the wait status after wait_one, using
7773         target_waitstatus_to_string and target_pid_to_str.
7774         (handle_inferior_event): Replace various trace of
7775         wait status kind by a single trace.
7776         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7777         wait status kind image by target_waitstatus_to_string.
7778         * target/waitstatus.c (target_waitstatus_to_string): Fix
7779         obsolete comment.
7780
7781 2019-04-01  Tom Tromey  <tromey@adacore.com>
7782
7783         PR symtab/23331:
7784         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7785
7786 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7787             Pedro Alves  <palves@redhat.com>
7788
7789         * top.c (quit_force): Call 'finalize_values'.
7790         * value.c (finalize_values): New function.
7791         * value.h (finalize_values): Declare.
7792
7793 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7794
7795         * NEWS: Announce $_gdb_major and $_gdb_minor.
7796
7797         * top.c (init_gdb_version_vars): New function.
7798         (gdb_init): Call init_gdb_version_vars.
7799
7800 2019-03-29  Tom Tromey  <tromey@adacore.com>
7801
7802         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7803         help text.  Remove dead code.
7804
7805 2019-03-29  Keith Seitz  <keiths@redhat.com>
7806
7807         From Siddhesh Poyarekar:
7808         * f-lang.h (f77_get_upperbound): Return LONGEST.
7809         (f77_get_lowerbound): Likewise.
7810         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7811         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7812         print them.
7813         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7814         plongest to format print it.
7815         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7816         (f77_get_upperbound): Likewise.
7817         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7818         LOWER_BOUND to LONGEST.
7819         (f77_create_arrayprint_offset_tbl): Likewise.
7820
7821 2019-03-29  Keith Seitz  <keiths@redhat.com>
7822
7823         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7824         %s/pulongest for TYPE_LENGTH instead of %d in format
7825         strings.
7826         * ada-typerint.c (ada_print_type): Likewise.
7827         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7828         * compile/compile-c-support.c (generate_register_struct): Likewise.
7829         * gdbtypes.c (recursive_dump_type): Likewise.
7830         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7831         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7832         instead of %d in format strings.
7833         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7834         to std::min to ULONGEST.
7835         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7836         instead of %d in format strings.
7837         * tracepoint.c (info_scope_command): Likewise.
7838         * typeprint.c (print_offset_data::update)
7839         (print_offset_data::finish): Likewise.
7840         * xtensa-tdep.c (xtensa_store_return_value)
7841         (xtensa_push_dummy_call): Likewise.
7842
7843 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7844
7845         * windows-nat.c (display_selector): Fixed format specifications
7846         for 64-bit Cygwin.
7847
7848 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7849
7850         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7851
7852 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7853
7854         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7855         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7856         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7857         (nios2_linux_init_abi): Install it.
7858
7859 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7860
7861         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7862
7863 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7864
7865         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7866
7867 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7868             Tom Tromey  <tromey@adacore.com>
7869
7870         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7871
7872 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7873
7874         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7875         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7876         method to compute the bounds of range types. Also print "[evaluated]"
7877         if the bounds' values come from a dynamic evaluation.
7878
7879 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7882         whitespace when pretty printing is on.
7883
7884 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7885
7886         * ppc-linux-nat.c: Add include.
7887
7888 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7889
7890         * NEWS: Mention AArch64 Pointer Authentication.
7891
7892 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7893
7894         * arm-linux-nat.c: Add include.
7895
7896 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7897
7898         * source-cache.c (source_cache::get_source_lines): Re-read
7899         fullname after calling open_source_file.
7900
7901 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7902
7903         * NEWS: Mention TLS support for FreeBSD.
7904
7905 2019-03-25  Tom Tromey  <tromey@adacore.com>
7906
7907         * minsyms.c (BUNCH_SIZE): Update comment.
7908         (~minimal_symbol_reader): Remove old comment.
7909         (compact_minimal_symbols): Update comment.
7910         (minimal_symbol_reader::install): Remove old comment.  Update
7911         other comments.
7912
7913 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7914
7915         * s390-linux-nat.c: Add include.
7916
7917 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7918
7919         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7920         Call linux_get_hwcap.
7921         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7922         Likewise.
7923         (aarch64_linux_get_hwcap): Remove function.
7924         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7925         declaration.
7926         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7927         linux_get_hwcap.
7928         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7929         * linux-tdep.c (linux_get_hwcap): Add function.
7930         (linux_get_hwcap2): Likewise.
7931         * linux-tdep.h (linux_get_hwcap): Add declaration.
7932         (linux_get_hwcap2): Likewise.
7933         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7934         (ppc_linux_get_hwcap2): Likewise.
7935         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7936         linux_get_hwcap.
7937         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7938         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7939         (ppc_linux_nat_target::read_description): Likewise.
7940         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7941         * s390-linux-nat.c: Likewise.
7942         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7943
7944 2019-03-24  Tom Tromey  <tom@tromey.com>
7945
7946         * ada-lang.c (standard_lookup): Simplify initialization.
7947         (ada_lookup_symbol_nonlocal): Simplify return.
7948         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7949         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7950         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7951         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7952         initialization.
7953         * solib.c (solib_global_lookup): Simplify.
7954         * symtab.c (null_block_symbol): Remove.
7955         (symbol_cache_lookup): Simplify returns.
7956         (lookup_language_this): Simplify returns.
7957         (lookup_symbol_aux): Simplify return.
7958         (lookup_local_symbol): Simplify returns.
7959         (lookup_global_symbol_from_objfile): Simplify return.
7960         (lookup_symbol_in_objfile_symtabs)
7961         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7962         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7963         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7964         * cp-namespace.c (cp_lookup_bare_symbol)
7965         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7966         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7967         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7968         (cp_lookup_symbol_via_imports): Simplify initialization.
7969         (find_symbol_in_baseclass): Likewise.
7970         * symtab.h (null_block_symbol): Remove.
7971         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7972         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7973         (d_lookup_symbol_module): Likewise.
7974         (find_symbol_in_baseclass): Simplify initialization.
7975
7976 2019-03-24  Tom Tromey  <tom@tromey.com>
7977
7978         * expression.h: Don't include symtab.h.
7979         (struct block): Forward declare.
7980
7981 2019-03-24  Tom Tromey  <tom@tromey.com>
7982
7983         * c-exp.y (typebase): Remove casts.
7984         * gdbtypes.c (lookup_unsigned_typename, )
7985         (lookup_signed_typename): Remove cast.
7986         * eval.c (parse_to_comma_and_eval): Remove cast.
7987         * parse.c (write_dollar_variable): Remove cast.
7988         * block.h (struct block) <superblock>: Now const.
7989         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7990         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7991         (map_block): Make "block" const.
7992         * symfile.h (struct quick_symbol_functions)
7993         <map_matching_symbols>: Constify block argument to "callback".
7994         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7995         const.
7996         (find_pc_sect_compunit_symtab): Make "b" const.
7997         (find_symbol_at_address): Likewise.
7998         (search_symbols): Likewise.
7999         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8000         (dw2_debug_names_lookup_symbol): Likewise.
8001         (dw2_map_matching_symbols): Update.
8002         * p-valprint.c (pascal_val_print): Remove "block".
8003         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8004         (aux_add_nonlocal_symbols): Make "block" const.
8005         (resolve_subexp): Remove cast.
8006         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8007         const.
8008         (iterate_over_file_blocks): Likewise.
8009         * f-exp.y (%union) <bval>: Remove.
8010         * coffread.c (patch_opaque_types): Make "b" const.
8011         * spu-tdep.c (spu_catch_start): Make "block" const.
8012         * c-valprint.c (print_unpacked_pointer): Remove "block".
8013         * symmisc.c (dump_symtab_1): Make "b" const.
8014         (block_depth): Make "block" const.
8015         * d-exp.y (%union) <bval>: Remove.
8016         * cp-support.h (cp_lookup_rtti_type): Update.
8017         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8018         * psymtab.c (psym_lookup_symbol): Make "block" const.
8019         (maintenance_check_psymtabs): Make "b" const.
8020         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8021         (enumerate_locals, enumerate_args): Update.
8022         * python/py-symtab.c (stpy_global_block): Make "block" const.
8023         (stpy_static_block): Likewise.
8024         * inline-frame.c (block_starting_point_at): Make "new_block"
8025         const.
8026         * block.c (find_block_in_blockvector): Make return type const.
8027         (blockvector_for_pc_sect): Make "b" const.
8028         (find_block_in_blockvector): Make "b" const.
8029
8030 2019-03-23  Tom Tromey  <tom@tromey.com>
8031
8032         * varobj.c (varobj_create): Update.
8033         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8034         * printcmd.c (display_command, do_one_display): Don't reset
8035         innermost_block.
8036         * parser-defs.h (enum innermost_block_tracker_type): Move to
8037         expression.h.
8038         (innermost_block): Update comment.
8039         * parse.c (parse_exp_1): Add tracker_types parameter.
8040         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8041         tracker_types parameter.  Reset innermost_block.
8042         (parse_exp_in_context): Remove.
8043         (parse_expression_for_completion): Update.
8044         * objfiles.c (~objfile): Don't reset expression_context_block or
8045         innermost_block.
8046         * expression.h (enum innermost_block_tracker_type): Move from
8047         parser-defs.h.
8048         (parse_exp_1): Add tracker_types parameter.
8049         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8050         reset innermost_block.
8051
8052 2019-03-23  Tom Tromey  <tom@tromey.com>
8053
8054         * objfiles.h: Include bcache.h.
8055
8056 2019-03-23  Tom Tromey  <tom@tromey.com>
8057
8058         * linespec.c (get_current_search_block): Use
8059         scoped_restore_current_language.
8060         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8061
8062 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8063             Jiong Wang  <jiong.wang@arm.com>
8064
8065         * aarch64-linux-tdep.c
8066         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8067         section.
8068         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8069
8070 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8071             Jiong Wang  <jiong.wang@arm.com>
8072
8073         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8074         instructions.
8075         (aarch64_analyze_prologue_test): Add PACIASP test.
8076         (aarch64_prologue_prev_register): Unmask PC value.
8077
8078 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8079             Jiong Wang  <jiong.wang@arm.com>
8080
8081         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8082         (aarch64_dwarf2_prev_register): Unmask PC value.
8083         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8084         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8085         DW_CFA_AARCH64_negate_ra_state.
8086         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8087
8088 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8089             Jiong Wang  <jiong.wang@arm.com>
8090
8091         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8092         registers.
8093         (aarch64_pseudo_register_name): Likewise.
8094         (aarch64_pseudo_register_type): Likewise.
8095         (aarch64_pseudo_register_reggroup_p): Likewise.
8096         (aarch64_gdbarch_init): Add pauth registers.
8097         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8098         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8099         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8100         (struct gdbarch_tdep): Add regnum for ra_state.
8101
8102 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8103             Jiong Wang  <jiong.wang@arm.com>
8104
8105         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8106
8107 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8108             Jiong Wang  <jiong.wang@arm.com>
8109
8110         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8111         function.
8112         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8113         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8114         (aarch64_gdbarch_init): Add puth registers.
8115         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8116         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8117         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8118
8119 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8120             Jiong Wang  <jiong.wang@arm.com>
8121
8122         * aarch64-linux-nat.c
8123         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8124         * aarch64-linux-tdep.c
8125         (aarch64_linux_core_read_description): Likewise.
8126         (aarch64_linux_get_hwcap): New function.
8127         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8128         (aarch64_linux_get_hwcap): New declaration.
8129
8130 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8131             Jiong Wang  <jiong.wang@arm.com>
8132
8133         * aarch64-linux-nat.c
8134         (aarch64_linux_nat_target::read_description): Add pauth param.
8135         * aarch64-linux-tdep.c
8136         (aarch64_linux_core_read_description): Likewise.
8137         * aarch64-tdep.c (struct target_desc): Add in pauth.
8138         (aarch64_read_description): Add pauth param.
8139         (aarch64_gdbarch_init): Likewise.
8140         * aarch64-tdep.h (aarch64_read_description): Likewise.
8141         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8142         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8143         * features/Makefile: Add new files.
8144         * features/aarch64-pauth.c: New file.
8145         * features/aarch64-pauth.xml: New file.
8146
8147 2019-03-20  Tom Tromey  <tromey@adacore.com>
8148
8149         * infrun.c (handle_inferior_event): Rename from
8150         handle_inferior_event_1.  Create a scoped_value_mark.
8151         (handle_inferior_event): Remove.
8152
8153 2019-03-19  Tom Tromey  <tromey@adacore.com>
8154
8155         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8156         * infrun.h (print_stop_event): Add "displays" parameter.
8157         * infrun.c (print_stop_event): Add "displays" parameter.
8158
8159 2019-03-19  Pedro Alves  <palves@redhat.com>
8160
8161         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8162         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8163         to -1.  Fix TABs vs spaces.
8164         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8165         * tui/tui-out.h (tui_ui_out) Add intro comments.
8166         <m_line, m_start_of_line>: In-class initialize, and add describing
8167         comment.
8168
8169 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8170
8171         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8172         variable names.
8173         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8174
8175 2019-03-18  Pedro Alves  <palves@redhat.com>
8176             Eli Zaretskii <eliz@gnu.org>
8177
8178         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8179         m_line and m_start_of_line.
8180
8181 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8182
8183         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8184         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8185         it returns a newline.  This fixes a regression in TU mode, whereby
8186         the next line is output on the same screen line as the user input.
8187
8188 2019-03-18  Tom Tromey  <tromey@adacore.com>
8189
8190         * minsyms.c (minimal_symbol_reader::install): Remove call to
8191         obstack_blank.
8192
8193 2019-03-18  Pedro Alves  <palves@redhat.com>
8194
8195         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8196         New globals.
8197         (apply_style): New, factored out from ...
8198         (apply_ansi_escape): ... this.  Handle reverse video mode.
8199         (tui_set_reverse_mode): New function.
8200         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8201         * tui/tui-winsource.c (tui_show_source_line): Use
8202         tui_set_reverse_mode instead of setting A_STANDOUT.
8203         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8204         New setter methods.
8205
8206 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8207
8208         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8209         Handle tabs.
8210
8211 2019-03-18  Tom Tromey  <tromey@adacore.com>
8212
8213         * ada-lang.c (empty_array): Add "high" parameter.
8214         (ada_evaluate_subexp): Update.
8215
8216 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8217
8218         * unittests/string_view-selftests.c: Define
8219         _initialize_string_view_selftests unconditionally.
8220
8221 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8222
8223         PR gdb/24350
8224         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8225
8226 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8227
8228         PR gdb/24351
8229         * windows-nat.c (display_selector): Fix format specifiers.
8230
8231 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8232
8233         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8234         tui_refill_source_window instead of tui_refresh_win, to update the
8235         current execution line.  This fixes redisplay of the current line
8236         when stepping through the code with "next" or "step".
8237
8238 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8239
8240         * source-cache.c (source_cache::get_source_lines): Call
8241         find_source_lines to initialize s->nlines.  This fixes vertical
8242         scrolling of TUI source window when the DOWN arrow is pressed.
8243
8244 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8245
8246         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8247         linux-thread-db.c (_initialize_thread_db): Likewise.
8248
8249 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8250
8251         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8252         wclrtoeol in tui_show_source_line".  This reverts changes made in
8253         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8254
8255 2019-03-15  Tom Tromey  <tom@tromey.com>
8256
8257         * symtab.h (struct minimal_symbol): Derive from
8258         general_symbol_info.
8259         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8260         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8261         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8262         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8263         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8264         (MSYMBOL_SEARCH_NAME): Update.
8265         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8266         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8267         * minsyms.c (minimal_symbol_reader::record_full): Update.
8268
8269 2019-03-15  Tom Tromey  <tom@tromey.com>
8270
8271         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8272
8273 2019-03-15  Tom Tromey  <tom@tromey.com>
8274
8275         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8276         unique_xmalloc_ptr.
8277         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8278         Update.
8279         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8280         (build_minimal_symbol_hash_tables)
8281         (minimal_symbol_reader::install): Update.
8282
8283 2019-03-15  Tom Tromey  <tom@tromey.com>
8284
8285         * symtab.c (create_demangled_names_hash): Update.
8286         (symbol_set_names): Update.
8287         * objfiles.h (struct objfile_per_bfd_storage)
8288         <demangled_names_hash>: Now an htab_up.
8289         * objfiles.c (objfile_per_bfd_storage): Simplify.
8290
8291 2019-03-15  Tom Tromey  <tom@tromey.com>
8292
8293         * objfiles.h (struct objfile_per_bfd_storage): Declare
8294         destructor.
8295         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8296         New.
8297         (get_objfile_bfd_data): Use new.  Don't initialize
8298         language_of_main.
8299         (free_objfile_per_bfd_storage): Remove.
8300         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8301
8302 2019-03-15  Tom Tromey  <tom@tromey.com>
8303
8304         * symfile.c (reread_symbols): Update.
8305         * objfiles.c (objfile::objfile): Update.
8306         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8307         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8308         comment.
8309         (minimal_symbol_reader::install): Update.
8310         (terminate_minimal_symbol_table): Remove.
8311         * jit.c (jit_object_close_impl): Update.
8312
8313 2019-03-15  Tom Tromey  <tom@tromey.com>
8314
8315         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8316         initializations.
8317
8318 2019-03-15  Tom Tromey  <tom@tromey.com>
8319
8320         * objfiles.h (struct objfile_per_bfd_storage)
8321         <demangled_hash_languages>: Now a bitset.
8322         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8323         (lookup_minimal_symbol): Update.
8324
8325 2019-03-15  Tom Tromey  <tom@tromey.com>
8326
8327         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8328         Don't return the symbol.
8329         * coffread.c (record_minimal_symbol): Use record_full.
8330
8331 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8332
8333         The MS-Windows port of ncurses fails to switch to a color pair if
8334         one or both of the colors are the implicit default colors.  This
8335         change records the default colors when TUI is initialized, and
8336         then specifies them explicitly when a color pair uses the default
8337         colors.  This allows color styling in TUI mode on MS-Windows.
8338
8339         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8340         ncurses_norm_attr.
8341         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8342         colors in ncurses_norm_attr.
8343         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8344         "none", replace it with the default color recorded in
8345         ncurses_norm_attr.
8346
8347 2019-03-14  Tom Tromey  <tromey@adacore.com>
8348
8349         * source-cache.h (class source_cache) <get_source_lines>: Return
8350         std::string.
8351         * source-cache.c (source_cache::extract_lines): Handle case where
8352         first_pos==npos.  Return std::string.
8353         (source_cache::get_source_lines): Update.
8354
8355 2019-03-14  Tom Tromey  <tromey@adacore.com>
8356
8357         * NEWS: Add item for "style sources" commands.
8358         * source-cache.c (source_cache::get_source_lines): Check
8359         source_styling.
8360         * cli/cli-style.c (source_styling): New global.
8361         (_initialize_cli_style): Add "style sources" commands.
8362         (show_style_sources): New function.
8363         * cli/cli-style.h (source_styling): Declare.
8364
8365 2019-03-14  Pedro Alves  <palves@redhat.com>
8366             Tom Tromey  <tromey@adacore.com>
8367
8368         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8369         * tui/tui-winsource.c (tui_refill_source_window): New function,
8370         from...
8371         (tui_horizontal_source_scroll): ... here.  Move some logic.
8372         * cli/cli-style.c (set_style_enabled): Notify new observable.
8373         * tui/tui-hooks.c (tui_redisplay_source): New function.
8374         (tui_attach_detach_observers): Attach or detach
8375         tui_redisplay_source.
8376         * observable.h (source_styling_changed): New observable.
8377         * observable.c: Define source_styling_changed observable.
8378
8379 2019-03-13  Tom Tromey  <tromey@adacore.com>
8380
8381         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8382         (i386_gnu_nat_target::store_registers): Update.
8383         * target-debug.h (target_debug_print_std_string): New macro.
8384         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8385         * windows-tdep.c (display_one_tib): Update.
8386         * tui/tui-stack.c (tui_make_status_line): Update.
8387         * top.c (print_inferior_quit_action): Update.
8388         * thread.c (thr_try_catch_cmd): Update.
8389         (add_thread_with_info): Update.
8390         (thread_target_id_str): Update.
8391         (thr_try_catch_cmd): Update.
8392         (thread_command): Update.
8393         (thread_find_command): Update.
8394         * record-btrace.c (record_btrace_target::info_record)
8395         (record_btrace_resume_thread, record_btrace_target::resume)
8396         (record_btrace_cancel_resume, record_btrace_step_thread)
8397         (record_btrace_target::wait, record_btrace_target::wait)
8398         (record_btrace_target::wait, record_btrace_target::stop): Update.
8399         * progspace.c (print_program_space): Update.
8400         * process-stratum-target.c
8401         (process_stratum_target::thread_address_space): Update.
8402         * linux-fork.c (linux_fork_mourn_inferior)
8403         (detach_checkpoint_command, info_checkpoints_command)
8404         (linux_fork_context): Update.
8405         (linux_fork_detach): Update.
8406         (class scoped_switch_fork_info): Update.
8407         (delete_checkpoint_command): Update.
8408         * infrun.c (follow_fork_inferior): Update.
8409         (follow_fork_inferior): Update.
8410         (proceed_after_vfork_done): Update.
8411         (handle_vfork_child_exec_or_exit): Update.
8412         (follow_exec): Update.
8413         (displaced_step_prepare_throw): Update.
8414         (displaced_step_restore): Update.
8415         (start_step_over): Update.
8416         (resume_1): Update.
8417         (clear_proceed_status_thread): Update.
8418         (proceed): Update.
8419         (print_target_wait_results): Update.
8420         (do_target_wait): Update.
8421         (context_switch): Update.
8422         (stop_all_threads): Update.
8423         (restart_threads): Update.
8424         (finish_step_over): Update.
8425         (handle_signal_stop): Update.
8426         (switch_back_to_stepped_thread): Update.
8427         (keep_going_pass_signal): Update.
8428         (print_exited_reason): Update.
8429         (normal_stop): Update.
8430         * inferior.c (inferior_pid_to_str): Change return type.
8431         (print_selected_inferior): Update.
8432         (add_inferior): Update.
8433         (detach_inferior): Update.
8434         * dummy-frame.c (fprint_dummy_frames): Update.
8435         * dcache.c (dcache_info_1): Update.
8436         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8437         (btrace_fetch, btrace_clear): Update.
8438         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8439         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8440         type.
8441         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8442         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8443         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8444         * gdbarch.c, gdbarch.h: Rebuild.
8445         * gdbarch.sh (core_pid_to_str): Change return type.
8446         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8447         return type.
8448         (windows_nat_target::pid_to_str): Change return type.
8449         (windows_delete_thread): Update.
8450         (windows_nat_target::attach): Update.
8451         (windows_nat_target::files_info): Update.
8452         * target-delegates.c: Rebuild.
8453         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8454         return type.
8455         (sol_thread_target::pid_to_str): Change return type.
8456         * remote.c (class remote_target) <pid_to_str>: Change return
8457         type.
8458         (remote_target::pid_to_str): Change return type.
8459         (extended_remote_target::attach, remote_target::remote_stop_ns)
8460         (remote_target::remote_notif_remove_queued_reply)
8461         (remote_target::push_stop_reply, remote_target::disable_btrace):
8462         Update.
8463         (extended_remote_target::attach): Update.
8464         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8465         type.
8466         (gdbsim_target::pid_to_str): Change return type.
8467         * ravenscar-thread.c (struct ravenscar_thread_target)
8468         <pid_to_str>: Change return type.
8469         (ravenscar_thread_target::pid_to_str): Change return type.
8470         * procfs.c (class procfs_target) <pid_to_str>: Change return
8471         type.
8472         (procfs_target::pid_to_str): Change return type.
8473         (procfs_target::attach): Update.
8474         (procfs_target::detach): Update.
8475         (procfs_target::fetch_registers): Update.
8476         (procfs_target::store_registers): Update.
8477         (procfs_target::wait): Update.
8478         (procfs_target::files_info): Update.
8479         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8480         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8481         return type.
8482         (nto_procfs_target::pid_to_str): Change return type.
8483         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8484         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8485         return type.
8486         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8487         (exit_lwp): Update.
8488         (attach_proc_task_lwp_callback, get_detach_signal)
8489         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8490         (linux_nat_target::resume, wait_lwp, stop_callback)
8491         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8492         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8493         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8494         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8495         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8496         type.
8497         (inf_ptrace_target::attach): Update.
8498         (inf_ptrace_target::files_info): Update.
8499         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8500         type.
8501         (go32_nat_target::pid_to_str): Change return type.
8502         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8503         (gnu_nat_target::wait): Update.
8504         (gnu_nat_target::wait): Update.
8505         (gnu_nat_target::resume): Update.
8506         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8507         (fbsd_nat_target::wait): Update.
8508         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8509         type.
8510         (darwin_nat_target::attach): Update.
8511         * corelow.c (class core_target) <pid_to_str>: Change return type.
8512         (core_target::pid_to_str): Change return type.
8513         * target.c (normal_pid_to_str): Change return type.
8514         (default_pid_to_str): Likewise.
8515         (target_pid_to_str): Change return type.
8516         (target_translate_tls_address): Update.
8517         (target_announce_detach): Update.
8518         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8519         return type.
8520         (bsd_uthread_target::pid_to_str): Change return type.
8521         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8522         type.
8523         (bsd_kvm_target::pid_to_str): Change return type.
8524         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8525         return type.
8526         (aix_thread_target::pid_to_str): Change return type.
8527         * target.h (struct target_ops) <pid_to_str>: Change return type.
8528         (target_pid_to_str, normal_pid_to_str): Likewise.
8529         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8530         type.
8531         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8532         type.
8533         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8534         return type.
8535         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8536         type.
8537         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8538         type.
8539         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8540         return type.
8541
8542 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8543
8544         * NEWS: Mention that the new default MI version is 3.  Mention
8545         changes to the output of commands and events that deal with
8546         multi-location breakpoints.
8547         * breakpoint.c: Include "mi/mi-out.h".
8548         (print_one_breakpoint): Change output syntax if using MI version
8549         >= 3.
8550         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8551         New.
8552         (mi_multi_location_breakpoint_output_fixed): New.
8553         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8554         (mi_cmd_fix_multi_location_breakpoint_output): New.
8555         (mi_multi_location_breakpoint_output_fixed): New.
8556         * mi/mi-cmds.c (mi_cmds): Register command
8557         -fix-multi-location-breakpoint-output.
8558         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8559         interpreter "mi".
8560
8561 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8562
8563         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8564         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8565         instantiate mi_ui_out based on interpreter name.
8566         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8567         * mi/mi-main.c (mi_load_progress): Likewise.
8568
8569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8570
8571         * NEWS: Combine separate "New targets" sections for 8.3.
8572
8573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8574
8575         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8576         (ppcfbsd_init_abi): Install gdbarch
8577         "fetch_tls_load_module_address" and "get_thread_local_address"
8578         methods.
8579
8580 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8581
8582         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8583         (riscv_fbsd_init_abi): Install gdbarch
8584         "fetch_tls_load_module_address" and "get_thread_local_address"
8585         methods.
8586
8587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8588
8589         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8590         (i386fbsd_init_abi): Install gdbarch
8591         "fetch_tls_load_module_address" and "get_thread_local_address"
8592         methods.
8593
8594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8595
8596         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8597         (amd64fbsd_init_abi): Install gdbarch
8598         "fetch_tls_load_module_address" and "get_thread_local_address"
8599         methods.
8600
8601 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8602
8603         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8604         (struct fbsd_pspace_data): New type.
8605         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8606         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8607         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8608         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8609         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8610
8611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8612
8613         * gdbtypes.c (lookup_struct_elt): New function.
8614         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8615         * gdbtypes.h (struct struct_elt): New type.
8616         (lookup_struct_elt): New prototype.
8617
8618 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8619
8620         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8621         remove disabled code block.
8622
8623 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8624
8625         * gdbarch.sh (get_thread_local_address): New method.
8626         * gdbarch.h, gdbarch.c: Regenerate.
8627         * target.c (target_translate_tls_address): Use
8628         gdbarch_get_thread_local_address if present instead of
8629         target::get_thread_local_address.
8630
8631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8632
8633         * target.h (target::get_thread_local_address): Update comment.
8634
8635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8636
8637         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8638         objfile->separate_debug_objfile_backlink if not NULL.
8639
8640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8641
8642         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8643         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8644         (amd64bsd_store_inferior_registers): Likewise.
8645         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8646         Enable segment base registers.
8647         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8648         PT_GETFSBASE and PT_GETGSBASE.
8649         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8650         PT_SETGSBASE.
8651         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8652         segment base registers.
8653         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8654
8655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8656
8657         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8658         Update calls to i386_target_description to add 'segments'
8659         parameter.
8660         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8661         add segment base registers.
8662         * arch/i386.c (i386_create_target_description): Add 'segments'
8663         parameter to enable segment base registers.
8664         * arch/i386.h (i386_create_target_description): Likewise.
8665         * features/i386/32bit-segments.xml: New file.
8666         * features/i386/32bit-segments.c: Generate.
8667         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8668         call to i386_target_description to add 'segments' parameter.
8669         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8670         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8671         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8672         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8673         if feature is present.
8674         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8675         Add 'segments' parameter to call to i386_target_description.
8676         (i386_target_description): Add 'segments' parameter to enable
8677         segment base registers.
8678         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8679         to call to i386_target_description.
8680         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8681         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8682         Define I386_NUM_REGS.
8683         (i386_target_description): Add 'segments' parameter to enable
8684         segment base registers.
8685
8686 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8687
8688         PR/24325
8689         * source-cache.c: #undef open and close, to avoid unresolved
8690         externals during linking.
8691
8692 2019-03-12  Tom Tromey  <tromey@adacore.com>
8693
8694         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8695         const.  Add initializers.
8696         (_initialize_remote): Don't initialize ptid globals.
8697
8698 2019-03-12  Pedro Alves  <palves@redhat.com>
8699
8700         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8701
8702 2019-03-12  Pedro Alves  <palves@redhat.com>
8703
8704         * cp-name-parser.y (main): Remove unused 'len' variable.
8705
8706 2019-03-12  Tom Tromey  <tromey@adacore.com>
8707
8708         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8709         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8710
8711 2019-03-12  Tom Tromey  <tromey@adacore.com>
8712
8713         * linux-nat.c (iterate_over_lwps): Update.
8714         (stop_callback): Remove parameter.
8715         (stop_wait_callback, detach_callback, resume_set_callback)
8716         (select_singlestep_lwp_callback, set_ignore_sigint)
8717         (status_callback, resumed_callback, resume_clear_callback)
8718         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8719         data parameter.
8720         (linux_nat_target::detach, linux_nat_target::resume)
8721         (linux_stop_and_wait_all_lwps, select_event_lwp)
8722         (linux_nat_filter_event, linux_nat_wait_1)
8723         (linux_nat_target::kill, linux_nat_target::stop)
8724         (linux_nat_target::stop): Update.
8725         (linux_nat_resume_callback): Change type.
8726         (resume_stopped_resumed_lwps, count_events_callback)
8727         (select_event_lwp_callback): Likewise.
8728         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8729         * arm-linux-nat.c (struct update_registers_data): Remove.
8730         (update_registers_callback): Change type.
8731         (arm_linux_insert_hw_breakpoint1): Update.
8732         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8733         parameter.
8734         (x86_linux_dr_set_addr): Update.
8735         (x86_linux_dr_set_control): Update.
8736         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8737         (iterate_over_lwps): Use gdb::function_view.
8738         * nat/aarch64-linux-hw-point.c (struct
8739         aarch64_dr_update_callback_param): Remove.
8740         (debug_reg_change_callback): Change type.
8741         (aarch64_notify_debug_reg_change): Update.
8742         * s390-linux-nat.c (s390_refresh_per_info): Update.
8743
8744 2019-03-11  Tom Tromey  <tromey@adacore.com>
8745
8746         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8747         redundant assignment to "this_cu".
8748
8749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8750
8751         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8752
8753 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8754
8755         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8756         from...
8757         (rank_one_type): ... this.
8758
8759 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8760
8761         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8762         from...
8763         (rank_one_type): ... this.
8764
8765 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8766
8767         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8768         from...
8769         (rank_one_type): ... this.
8770
8771 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8772
8773         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8774         from...
8775         (rank_one_type): ... this.
8776
8777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8778
8779         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8780         from...
8781         (rank_one_type): ... this.
8782
8783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8784
8785         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8786         from...
8787         (rank_one_type): ... this.
8788
8789 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8790
8791         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8792         from...
8793         (rank_one_type): ... this.
8794
8795 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8796
8797         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8798         from...
8799         (rank_one_type): ... this.
8800
8801 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8802
8803         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8804         from...
8805         (rank_one_type): ... this.
8806
8807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8808
8809         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8810         from...
8811         (rank_one_type): ... this.
8812
8813 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8814
8815         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8816         from...
8817         (rank_one_type): ... this.
8818
8819 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8820
8821         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8822         from...
8823         (rank_one_type): ... this.
8824
8825 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8826
8827         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8828         inferior-events' shows the example events.
8829
8830 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8831
8832         Support styling on native MS-Windows console
8833
8834         PR/24315
8835         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8836         on MS-Windows if $TERM is not defined.
8837
8838         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8839
8840         * posix-hdep.c (gdb_console_fputs):
8841         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8842         functions.
8843         * ui-file.h (gdb_console_fputs): Add prototype.
8844
8845         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8846         back to fputs only if the former returns zero.
8847
8848 2019-03-07  Tom Tromey  <tom@tromey.com>
8849
8850         * symmisc.c (print_symbol_bcache_statistics): Update.
8851         (print_objfile_statistics): Update.
8852         * symfile.c (allocate_symtab): Update.
8853         * stabsread.c: Don't include bcache.h.
8854         * psymtab.h (struct psymbol_bcache): Don't declare.
8855         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8856         (psymbol_bcache_init, psymbol_bcache_free)
8857         (psymbol_bcache_get_bcache): Don't declare.
8858         * psymtab.c (struct psymbol_bcache): Remove.
8859         (psymtab_storage::psymtab_storage): Update.
8860         (psymtab_storage::~psymtab_storage): Update.
8861         (psymbol_bcache_init, psymbol_bcache_free)
8862         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8863         (add_psymbol_to_bcache): Update.
8864         (allocate_psymtab): Update.
8865         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8866         macro_cache>: No longer pointers.
8867         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8868         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8869         * macrotab.c (macro_bcache): Update.
8870         * macroexp.c: Don't include bcache.h.
8871         * gdbtypes.c (check_types_worklist): Update.
8872         (types_deeply_equal): Remove TRY/CATCH.  Update.
8873         * elfread.c (elf_symtab_read): Update.
8874         * dwarf2read.c: Don't include bcache.h.
8875         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8876         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8877         (print_bcache_statistics, bcache_memory_used): Don't declare.
8878         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8879         methods.  Rename all data members.
8880         * bcache.c (struct bcache): Move to bcache.h.
8881         (bcache::expand_hash_table): Rename from expand_hash_table.
8882         (bcache): Remove.
8883         (bcache::insert): Rename from bcache_full.
8884         (bcache::compare): Rename from bcache_compare.
8885         (bcache_xmalloc): Remove.
8886         (bcache::~bcache): Rename from bcache_xfree.
8887         (bcache::print_statistics): Rename from print_bcache_statistics.
8888         (bcache::memory_used): Rename from bcache_memory_used.
8889
8890 2019-03-07  Pedro Alves  <palves@redhat.com>
8891
8892         * infrun.c (normal_stop): Also check for
8893         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8894
8895 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * f-lang.c (value_from_host_double): Moved to...
8898         * value.c (value_from_host_double): ...here.
8899         * value.h (value_from_host_double): Declare.
8900         * guile/scm-math.c (vlscm_convert_typed_number): Use
8901         value_from_host_double.
8902         (vlscm_convert_number): Likewise.
8903         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8904         * python/py-value.c (convert_value_from_python): Likewise.
8905
8906 2019-03-06  Tom Tromey  <tom@tromey.com>
8907
8908         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8909
8910 2019-03-06  Tom Tromey  <tom@tromey.com>
8911
8912         * utils.h (free_current_contents): Don't declare.
8913         * utils.c (free_current_contents): Remove.
8914
8915 2019-03-06  Tom Tromey  <tom@tromey.com>
8916
8917         * top.c (quit_force): Update.
8918         * main.c (captured_command_loop): Update.
8919         * common/new-op.c (operator new): Update.
8920         * common/common-exceptions.c (struct catcher)
8921         <save_cleanup_chain>: Remove member.
8922         (exceptions_state_mc_init): Update.
8923         (exception_try_scope_entry): Return nullptr.
8924         (exception_try_scope_exit, exception_rethrow)
8925         (throw_exception_sjlj, throw_exception_cxx): Update.
8926         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8927         (all_cleanups, do_cleanups, discard_cleanups)
8928         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8929         (restore_cleanups, restore_final_cleanups): Don't declare.
8930         (do_final_cleanups): Remove parameter.
8931         * common/cleanups.c (cleanup_chain, make_cleanup)
8932         (make_cleanup_dtor, all_cleanups, do_cleanups)
8933         (discard_my_cleanups, discard_cleanups)
8934         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8935         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8936         (null_cleanup): Remove.
8937         (do_final_cleanups): Remove parameter.
8938
8939 2019-03-06  Tom Tromey  <tom@tromey.com>
8940
8941         * remote.c (remote_target::remote_parse_stop_reply): Use
8942         unique_xmalloc_ptr.
8943
8944 2019-03-06  Tom Tromey  <tom@tromey.com>
8945
8946         * stabsread.c (struct stabs_field_info): Rename from field_info.
8947         <list, fnlist>: Add initializers.
8948         <obstack>: New member.
8949         (read_member_functions, read_struct_fields, read_baseclasses):
8950         Allocate on obstack.  Don't use cleanups.
8951         (read_one_struct_field, read_member_functions, read_struct_fields)
8952         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8953         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8954         (read_struct_type): Update.
8955
8956 2019-03-06  Tom Tromey  <tom@tromey.com>
8957
8958         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8959         * common/filestuff.h (make_cleanup_close): Don't declare.
8960         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8961         Remove.
8962
8963 2019-03-06  Tom Tromey  <tom@tromey.com>
8964
8965         * solib-aix.c: Use make_scope_exit.
8966
8967 2019-03-06  Tom Tromey  <tom@tromey.com>
8968
8969         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8970         Use make_scope_exit.
8971
8972 2019-03-06  Tom Tromey  <tom@tromey.com>
8973
8974         * solib-svr4.c (disable_probes_interface): Remove parameter.
8975         (svr4_handle_solib_event): Use make_scope_exit.
8976
8977 2019-03-06  Tom Tromey  <tom@tromey.com>
8978
8979         * remote.c (struct stop_reply_deleter): Remove.
8980         (stop_reply_up): Update.
8981         (struct stop_reply): Derive from notif_event.  Don't typedef.
8982         <regcache>: Now a std::vector.
8983         (stop_reply_xfree): Remove.
8984         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8985         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8986         (remote_target::discard_pending_stop_replies): Use delete.
8987         (remote_target::remote_parse_stop_reply): Update.
8988         (remote_target::process_stop_reply): Update.
8989         * remote-notif.h (struct notif_event): Add virtual destructor.
8990         Remove "dtr" member.
8991         (struct notif_client) <alloc_event>: Return a unique_ptr.
8992         (notif_event_xfree): Don't declare.
8993         (notif_event_up): New typedef.
8994         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8995         (notif_event_xfree, do_notif_event_xfree): Remove.
8996         (remote_notif_state_xfree): Update.
8997
8998 2019-03-06  Tom Tromey  <tom@tromey.com>
8999
9000         * infrun.c (displaced_step_clear_cleanup): Now a
9001         forward_scope_exit type.
9002         (displaced_step_prepare_throw): Update.
9003         (displaced_step_fixup): Update.
9004
9005 2019-03-06  Tom Tromey  <tom@tromey.com>
9006
9007         * inferior.h (class inferior): Update comment.
9008         * gdbthread.h (class thread_info): Update comment.
9009
9010 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9011             Tom Tromey  <tom@tromey.com>
9012
9013         * stabsread.h (struct stab_section_list): Remove.
9014         (coffstab_build_psymtabs): Update.
9015         * dbxread.c (symbuf_sections): Now a std::vector.
9016         (sect_idx): New global.
9017         (fill_symbuf): Update.
9018         (coffstab_build_psymtabs): Change type of stabsects parameter.
9019         Update.
9020         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9021         std::vector.
9022         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9023         (coff_locate_sections): Update.
9024         (coff_symfile_read): Remove cleanups.  Update.
9025         (init_stringtab): Add storage parameter.
9026         (free_stringtab, free_stringtab_cleanup): Remove.
9027         (init_lineno): Add storage parameter.
9028         (free_linetab, free_linetab_cleanup): Remove.
9029
9030 2019-03-06  Pedro Alves  <palves@redhat.com>
9031
9032         * linux-fork.c (fork_info::clobber_regs): Delete.
9033         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9034         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9035         comment.  Adjust.
9036         (scoped_switch_fork_info::scoped_switch_fork_info)
9037         (checkpoint_command, linux_fork_context): Adjust
9038         fork_save_infrun_state calls.
9039
9040 2019-03-06  Pedro Alves  <palves@redhat.com>
9041
9042         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9043         (inf_has_multiple_threads): Return 'bool' and rewrite using
9044         inferior_info::threads().
9045
9046 2019-03-06  Pedro Alves  <palves@redhat.com>
9047
9048         * linux-fork.c: Include <list>.
9049         (fork_list): Now a std::list instance.
9050         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9051         (forks_exist_p, find_last_fork): Adjust.
9052         (new_fork): Delete.
9053         (one_fork_p): New.
9054         (add_fork): Adjust.
9055         (free_fork): Delete, folded into fork_info::~fork_info().
9056         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9057         Adjust.
9058         (init_fork_list): Delete.
9059         (linux_fork_killall, linux_fork_mourn_inferior)
9060         (linux_fork_detach, info_checkpoints_command): Adjust.
9061         (_initialize_linux_fork): No longer call init_fork_list.
9062
9063 2019-03-06  Pedro Alves  <palves@redhat.com>
9064
9065         * linux-fork.c (new_fork): New, split out of ...
9066         (add_fork): ... this.  Return void.  Move "first fork" special
9067         case from here, to ...
9068         (checkpoint_command): ... here.
9069         * linux-linux.h (add_fork): Return void.
9070
9071 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9072
9073         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9074
9075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9076             Chris January  <chris.january@arm.com>
9077             David Lecomber  <david.lecomber@arm.com>
9078
9079         * f-exp.y: New token, UNOP_INTRINSIC.
9080         (exp): New pattern using UNOP_INTRINSIC token.
9081         (f77_keywords): Add 'abs' keyword.
9082         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9083         (value_from_host_double): New function.
9084         (evaluate_subexp_f): Support UNOP_ABS.
9085
9086 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9089         types.
9090
9091 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9092
9093         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9094         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9095         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9096
9097 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9100
9101 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9102             Chris January  <chris.january@arm.com>
9103
9104         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9105         * f-exp.y: Define 'KIND' token.
9106         (exp): New pattern for KIND expressions.
9107         (ptype): Handle types with a kind extension.
9108         (direct_abs_decl): Extend to spot kind extensions.
9109         (f77_keywords): Add 'kind' to the list.
9110         (push_kind_type): New function.
9111         (convert_to_kind_type): New function.
9112         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9113         * parse.c (operator_length_standard): Likewise.
9114         * parser-defs.h (enum type_pieces): Add tp_kind.
9115         * std-operator.def: Add UNOP_KIND.
9116
9117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * f-exp.y (f_parse): Set yydebug.
9120
9121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9122
9123         * f-lang.c (evaluate_subexp_f): New function.
9124         (exp_descriptor_f): New global.
9125         (f_language_defn): Use exp_descriptor_f instead of
9126         exp_descriptor_standard.
9127
9128 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9129
9130         * f-exp.y (struct token): Add comments.
9131         (dot_ops): Remove uppercase versions and the end marker.
9132         (f77_keywords): Likewise.
9133         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9134         entries in the dot_ops array are case insensitive, and use
9135         strncasecmp to compare strings.  Also some whitespace cleanup in
9136         this area.  Similar for the f77_keywords array, except entries in
9137         this list might be case sensitive.
9138
9139 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9140
9141         * f-exp.y (struct f77_boolean_val): Add comments.
9142         (boolean_values): Remove uppercase versions, and end marker.
9143         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9144         and use strncasecmp to achieve case insensitivity.  Additionally,
9145         perform whitespace cleanup around this code.
9146
9147 2019-03-06  Tom Tromey  <tromey@adacore.com>
9148
9149         * remote-sim.c (gdbsim_target_open): Use result of
9150         gdb_argv::release.
9151
9152 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9153         Dirk Schubert  <dirk.schubert@arm.com>
9154         Chris January  <chris.january@arm.com>
9155
9156         * eval.c (evaluate_subexp_standard): Call Fortran argument
9157         wrapping logic.
9158         * f-lang.c (struct value): A value which can be passed into a
9159         Fortran function call.
9160         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9161         where appropriate.
9162         (struct type): Value ready for a Fortran function call.
9163         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9164         is needed.
9165         * f-lang.h (fortran_argument_convert): Declaration.
9166         (fortran_preserve_arg_pointer): Declaration.
9167         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9168
9169 2019-03-05  Tom Tromey  <tromey@adacore.com>
9170
9171         * python/py-prettyprint.c (print_string_repr): Remove #if.
9172         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9173
9174 2019-03-05  Tom Tromey  <tromey@adacore.com>
9175
9176         * target.c (the_dummy_target): Move later.  Change type to
9177         "dummy_target".
9178         (initialize_targets): Don't initialize the_dummy_target.
9179
9180 2019-03-05  Tom Tromey  <tromey@adacore.com>
9181
9182         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9183         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9184
9185 2019-03-05  Tom Tromey  <tromey@adacore.com>
9186
9187         * windows-nat.c (windows_nat_target::attach)
9188         (windows_nat_target::detach): Don't call gdb_flush.
9189         * valprint.c (generic_val_print, val_print, val_print_string):
9190         Don't call gdb_flush.
9191         * utils.c (defaulted_query): Don't call gdb_flush.
9192         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9193         * target.c (target_announce_detach): Don't call gdb_flush.
9194         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9195         * remote.c (extended_remote_target::attach): Don't call
9196         gdb_flush.
9197         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9198         * printcmd.c (do_examine): Don't call gdb_flush.
9199         (info_display_command): Don't call gdb_flush.
9200         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9201         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9202         * memattr.c (info_mem_command): Don't call gdb_flush.
9203         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9204         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9205         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9206         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9207         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9208         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9209         (gnu_nat_target::detach): Don't call gdb_flush.
9210         * f-valprint.c (f_val_print): Don't call gdb_flush.
9211         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9212         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9213         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9214         gdb_flush.
9215         * c-valprint.c (c_val_print): Don't call gdb_flush.
9216         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9217
9218 2019-03-05  Tom Tromey  <tromey@adacore.com>
9219
9220         * varobj.c (update_dynamic_varobj_children): Update.
9221         (install_default_visualizer): Use reset, not release.
9222         * value.c (set_internalvar): Update.
9223         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9224         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9225         ATTRIBUTE_UNUSED_RESULT.
9226
9227 2019-03-05  Tom Tromey  <tromey@adacore.com>
9228
9229         * remote.c (class scoped_remote_fd) <release>: Add
9230         ATTRIBUTE_UNUSED_RESULT.
9231
9232 2019-03-05  Tom Tromey  <tromey@adacore.com>
9233
9234         * macroexp.c (struct macro_buffer) <release>: Add
9235         ATTRIBUTE_UNUSED_RESULT.
9236
9237 2019-03-05  Tom Tromey  <tromey@adacore.com>
9238
9239         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9240         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9241         ATTRIBUTE_UNUSED_RESULT.
9242
9243 2019-03-05  Tom Tromey  <tromey@adacore.com>
9244
9245         * common/scoped_fd.h (class scoped_fd) <release>: Add
9246         ATTRIBUTE_UNUSED_RESULT.
9247
9248 2019-03-05  Tom Tromey  <tromey@adacore.com>
9249
9250         * parser-defs.h (struct parser_state) <release>: Add
9251         ATTRIBUTE_UNUSED_RESULT.
9252
9253 2019-03-05  Tom Tromey  <tromey@adacore.com>
9254
9255         * utils.h (class gdb_argv) <release>: Add
9256         ATTRIBUTE_UNUSED_RESULT.
9257         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9258
9259 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9260
9261         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9262         for-loop range, to avoid compiler warnings.
9263
9264         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9265         avoid compiler warnings about unused variables.
9266
9267         * NEWS: Mention end of support for native debugging on MS-Windows
9268         before XP.
9269
9270         PR gdb/24292
9271         * common/netstuff.c:
9272         * gdbserver/gdbreplay.c
9273         * gdbserver/remote-utils.c:
9274         * ser-tcp.c:
9275         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9276         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9277         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9278         'getaddrinfo' and 'freeaddrinfo' were not available before
9279         Windows XP, and mingw.org's MinGW headers by default define
9280         _WIN32_WINNT to 0x500.
9281
9282 2019-03-01  Gary Benson <gbenson@redhat.com>
9283
9284         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9285
9286 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9287             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9288
9289         PR gdb/8527
9290         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9291         set_sigint_trap, clear_sigint_trap.
9292
9293 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9294
9295         * target.c (target_detach): Clear the regcache and the
9296         frame cache.
9297
9298 2019-02-27  Pedro Alves  <palves@redhat.com>
9299
9300         * utils.c (set_screen_size): When we cap the height/width sizes,
9301         tweak the corresponding command variable to show "unlimited":
9302
9303 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9304             Pedro Alves  <palves@redhat.com>
9305
9306         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9307         before calling rl_set_screen_size.
9308
9309 2019-02-27  Tom Tromey  <tromey@adacore.com>
9310
9311         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9312         define.
9313         * python/py-value.c: Remove Python 2.4 workaround.
9314         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9315         workaround.
9316         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9317         Python 2.4 workaround.
9318         * python/python-internal.h: Remove Python 2.4 comment.
9319         (Py_ssize_t): Don't define.
9320         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9321         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9322         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9323         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9324         * python/python.c (do_start_initialization): Remove Python 2.4
9325         workaround.
9326         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9327         (print_children): Remove Python 2.4 workaround.
9328         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9329         workaround.
9330         (CHARBUFFERPROC_NAME): Remove.
9331         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9332         Python 2.4 workaround.
9333
9334 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9335
9336         * NEWS: Note minimum Python version.
9337
9338 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9339
9340         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9341         code from these functions.  Remove corresponding ifdefs.  Use
9342         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9343         Remove gotos and target of gotos.
9344         (infpy_search_memory): Likewise.
9345
9346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9349         (hppa_gdbarch_init): Don't register deleted functions with
9350         gdbarch.
9351
9352 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9353
9354         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9355         (h8300_unwind_sp): Delete.
9356         (h8300_dummy_id): Delete.
9357         (h8300_gdbarch_init): Don't register deleted functions with
9358         gdbarch.
9359
9360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9363         (ft32_unwind_pc): Delete.
9364         (ft32_unwind_sp): Delete.
9365         (ft32_gdbarch_init): Don't register deleted functions with
9366         gdbarch.
9367
9368 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9369
9370         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9371         (frv_unwind_pc): Delete.
9372         (frv_unwind_sp): Delete.
9373         (frv_gdbarch_init): Don't register deleted functions with
9374         gdbarch.
9375
9376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9377
9378         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9379         (riscv_unwind_pc): Delete.
9380         (riscv_unwind_sp): Delete.
9381         (riscv_gdbarch_init): Don't register deleted functions with
9382         gdbarch.
9383
9384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9385
9386         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9387         (csky_unwind_pc): Delete.
9388         (csky_unwind_sp): Delete.
9389         (csky_gdbarch_init): Don't register deleted functions with
9390         gdbarch.
9391
9392 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9395         (cris_unwind_pc): Delete.
9396         (cris_unwind_sp): Delete.
9397         (cris_gdbarch_init): Don't register deleted functions with
9398         gdbarch.
9399
9400 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9403         (bfin_unwind_pc): Delete.
9404         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9405
9406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9407
9408         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9409         (arm_unwind_pc): Delete.
9410         (arm_unwind_sp): Delete.
9411         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9412
9413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9414
9415         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9416         (arc_unwind_pc): Delete.
9417         (arc_unwind_sp): Delete.
9418         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9419
9420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9423         (alpha_unwind_pc): Delete.
9424         (alpha_gdbarch_init): Don't register deleted functions with
9425         gdbarch.
9426
9427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9430         (aarch64_unwind_pc): Delete.
9431         (aarch64_unwind_sp): Delete.
9432         (aarch64_gdbarch_init): Don't register deleted functions with
9433         gdbarch.
9434
9435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * gdbtypes.c (type_align): Don't consider static members when
9438         computing structure alignment.
9439
9440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9441
9442         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9443         return 0 for other types.
9444         * arch-utils.c (default_type_align): Always return 0.
9445         * gdbarch.h: Regenerate.
9446         * gdbarch.sh (type_align): Extend comment.
9447         * gdbtypes.c (type_align): Add additional comments, always call
9448         gdbarch_type_align before applying the default rules.
9449         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9450         generic code will then apply a suitable default.
9451         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9452         types, return 0 for other types.
9453
9454 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9455
9456         * NEWS: Create a new section for the next release branch.
9457         Rename the section of the current branch, now that it has
9458         been cut.
9459
9460 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9461
9462         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9463         * version.in: Bump version to 8.3.50.DATE-git.
9464
9465 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9466
9467         * aix-thread.c (ptid_cmp): Remove unused variable.
9468         (get_signaled_thread): Likewise.
9469         (store_regs_user_thread): Likewise.
9470         (store_regs_kernel_thread): Likewise.
9471         (fetch_regs_kernel_thread): Remove shadowed variable.
9472
9473 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * features/riscv/32bit-cpu.xml: Add register numbers.
9476         * features/riscv/32bit-fpu.c: Regenerate.
9477         * features/riscv/32bit-fpu.xml: Add register numbers.
9478         * features/riscv/64bit-cpu.xml: Add register numbers.
9479         * features/riscv/64bit-fpu.c: Regenerate.
9480         * features/riscv/64bit-fpu.xml: Add register numbers.
9481
9482 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9483
9484         * NEWS: Mention two argument form of gdb.Value constructor.
9485         * python/py-value.c (convert_buffer_and_type_to_value): New
9486         function.
9487         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9488         Add support for handling an optional second argument.  Call
9489         convert_buffer_and_type_to_value as appropriate.
9490         * python/python-internal.h (Py_buffer_deleter): New struct.
9491         (Py_buffer_up): New typedef.
9492
9493 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9494
9495         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9496         instead of releasing ownership.
9497
9498 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9499
9500         * dwarf2read.c (open_and_init_dwp_file): Call
9501         elf_numsections instead of bfd_count_sections to initialize
9502         dwp_file->num_sections.
9503
9504 2019-02-25  Tom Tromey  <tromey@adacore.com>
9505
9506         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9507
9508 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9509
9510         * gcore.in: Add '--readnever' option when invoking GDB.
9511
9512 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9513
9514         * MAINTAINERS: Update my email address.
9515
9516 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9517
9518         * build-id.c (build_id_to_debug_bfd_1): New function.
9519         (build_id_to_debug_bfd): Look for separate debug file in
9520         sysroot.
9521
9522 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * gdbarch.sh: Update the copyright year range that is placed into
9525         generated files.
9526
9527 2019-02-22  Keith Seitz  <keiths@redhat.com>
9528
9529         PR symtab/23853
9530         * linespec.c (create_sals_line_offset): Search for the default
9531         symtab's filename instead of its fullname.
9532
9533 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9534
9535         * NEWS: Update style defaults.
9536
9537 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9538
9539         * main.c (captured_main_1): Disable styling in batch mode.
9540
9541 2019-02-20  Tom Tromey  <tom@tromey.com>
9542
9543         * symtab.c (symtab_symbol_info): Fix typos.
9544
9545 2019-02-20  Tom Tromey  <tromey@adacore.com>
9546
9547         * findcmd.c (_initialize_mem_search): Use upper case for
9548         metasyntactic variables.
9549
9550 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9551
9552         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9553         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9554
9555 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9556
9557         * top.h (source_file_name): Change to std::string.
9558         * top.c (source_file_name): Likewise.
9559         (command_line_input): Adjust.
9560         * cli/cli-script.c (script_from_file): Adjust.
9561
9562 2019-02-19  Tom Tromey  <tromey@adacore.com>
9563
9564         * ravenscar-thread.c
9565         (ravenscar_thread_target::update_thread_list): Don't call
9566         ada_build_task_list.
9567         * ada-lang.h (ada_build_task_list): Don't declare.
9568         * ada-tasks.c (struct ada_tasks_inferior_data)
9569         <task_list_valid_p>: Now bool.
9570         (read_known_tasks, ada_task_list_changed)
9571         (ada_tasks_invalidate_inferior_data): Update.
9572         (read_known_tasks_array): Return bool.
9573         (read_known_tasks_list): Likewise.
9574         (read_known_tasks): Return void.
9575         (ada_build_task_list): Now static.
9576
9577 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9578
9579         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9580         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9581
9582 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9583
9584         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9585         variant for ada_tasks_pspace_data_handle and
9586         ada_tasks_inferior_data_handle.
9587         (ada_tasks_pspace_data_cleanup): New function.
9588         (ada_tasks_inferior_data_cleanup): New function.
9589
9590 2019-02-17  Tom Tromey  <tom@tromey.com>
9591
9592         * macrotab.h (macro_source_fullname): Return a std::string.
9593         * macrotab.c (macro_include, check_for_redefinition)
9594         (macro_undef, macro_lookup_definition, foreach_macro)
9595         (foreach_macro_in_scope): Update.
9596         (macro_source_fullname): Return a std::string.
9597         * macrocmd.c (show_pp_source_pos): Update.
9598
9599 2019-02-17  Tom Tromey  <tom@tromey.com>
9600
9601         * macrocmd.c (show_pp_source_pos): Style the file names.
9602
9603 2019-02-17  Tom Tromey  <tom@tromey.com>
9604
9605         PR tui/24197:
9606         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9607
9608 2019-02-17  Tom Tromey  <tom@tromey.com>
9609
9610         * ada-lang.c (user_select_syms): Use filtered printing.
9611         * utils.c (wrap_style): New global.
9612         (desired_style): Remove.
9613         (emit_style_escape): Add stream parameter.
9614         (set_output_style, reset_terminal_style, prompt_for_continue):
9615         Update.
9616         (flush_wrap_buffer): Only flush gdb_stdout.
9617         (wrap_here): Set wrap_style.
9618         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9619         treat escape sequences as a character.  Change when wrap buffer is
9620         flushed.
9621         (fputs_styled): Do not set the output style when the default is
9622         requested.
9623         * ui-style.h (struct ui_file_style) <is_default>: New method.
9624         * source.c (print_source_lines_base): Emit escape sequences in one
9625         piece.
9626
9627 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9628
9629         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9630         integers and enumeration types.
9631
9632 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9633
9634         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9635         instead of lookup_symbol_in_language
9636         (do_exact_match): New function.
9637         (ada_get_symbol_name_matcher): Return do_exact_match when
9638         doing a verbatim match.
9639
9640 2019-02-15  Tom Tromey  <tromey@adacore.com>
9641
9642         * ravenscar-thread.c (ravenscar_thread_target::resume)
9643         (ravenscar_thread_target::wait): Special case wildcard requests.
9644
9645 2019-02-15  Tom Tromey  <tromey@adacore.com>
9646
9647         * ravenscar-thread.c (base_ptid): Remove.
9648         (struct ravenscar_thread_target) <close>: New method.
9649         <m_base_ptid>: New member.
9650         <update_inferior_ptid, active_task, task_is_currently_active,
9651         runtime_initialized>: Declare methods.
9652         <ravenscar_thread_target>: Add constructor.
9653         (ravenscar_thread_target::task_is_currently_active)
9654         (ravenscar_thread_target::update_inferior_ptid)
9655         (ravenscar_runtime_initialized): Rename.  Now methods.
9656         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9657         (ravenscar_thread_target::update_thread_list): Update.
9658         (ravenscar_thread_target::active_task): Now method.
9659         (ravenscar_thread_target::store_registers)
9660         (ravenscar_thread_target::prepare_to_store)
9661         (ravenscar_thread_target::prepare_to_store)
9662         (ravenscar_thread_target::mourn_inferior): Update.
9663         (ravenscar_inferior_created): Use "new" to create target.
9664         (ravenscar_thread_target::get_ada_task_ptid): Update.
9665         (_initialize_ravenscar): Don't initialize base_ptid.
9666         (ravenscar_ops): Remove global.
9667
9668 2019-02-15  Tom Tromey  <tromey@adacore.com>
9669
9670         * target.h (push_target): Declare new overload.
9671         * target.c (push_target): New overload, taking an rvalue reference.
9672         * remote.c (remote_target::open_1): Use push_target overload.
9673         * corelow.c (core_target_open): Use push_target overload.
9674
9675 2019-02-15  Tom Tromey  <tromey@adacore.com>
9676
9677         * ravenscar-thread.c (is_ravenscar_task)
9678         (ravenscar_task_is_currently_active): Return bool.
9679         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9680         (_initialize_ravenscar): Remove "(void)".
9681         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9682         Return bool.
9683
9684 2019-02-15  Tom Tromey  <tromey@adacore.com>
9685
9686         * ravenscar-thread.c (ravenscar_runtime_initializer)
9687         (has_ravenscar_runtime, get_running_thread_id)
9688         (ravenscar_thread_target::resume): Fix indentation.
9689
9690 2019-02-15  Tom Tromey  <tromey@adacore.com>
9691
9692         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9693         from ravenscar_arch_ops.
9694         (sparc_ravenscar_ops::fetch_registers)
9695         (sparc_ravenscar_ops::store_registers): Now methods.
9696         (sparc_ravenscar_prepare_to_store): Remove.
9697         (sparc_ravenscar_ops): Redefine.
9698         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9699         methods and destructor.  Remove members.
9700         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9701         (ravenscar_thread_target::store_registers)
9702         (ravenscar_thread_target::prepare_to_store): Update.
9703         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9704         Remove.
9705         (struct ppc_ravenscar_powerpc_ops): Derive from
9706         ravenscar_arch_ops.
9707         (ppc_ravenscar_powerpc_ops::fetch_registers)
9708         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9709         (ppc_ravenscar_powerpc_ops): Redefine.
9710         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9711         (ppc_ravenscar_e500_ops::fetch_registers)
9712         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9713         (ppc_ravenscar_e500_ops): Redefine.
9714         * aarch64-ravenscar-thread.c
9715         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9716         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9717         (aarch64_ravenscar_fetch_registers)
9718         (aarch64_ravenscar_store_registers): Now methods.
9719         (aarch64_ravenscar_ops): Redefine.
9720
9721 2019-02-15  Tom Tromey  <tromey@adacore.com>
9722
9723         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9724         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9725         (ravenscar_thread_target::stopped_by_watchpoint)
9726         (ravenscar_thread_target::stopped_data_address)
9727         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9728
9729 2019-02-15  Tom Tromey  <tromey@adacore.com>
9730
9731         * ravenscar-thread.c: Fix some typos.
9732
9733 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9734             Tom Tromey  <tromey@adacore.com>
9735
9736         * ada-lang.c (ada_exception_sal): Change addr_string to a
9737         std::string.
9738         (create_ada_exception_catchpoint): Update.
9739
9740 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9741             Tom Tromey  <tromey@adacore.com>
9742
9743         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9744         (bp_location_ops): Remove.
9745         (base_breakpoint_allocate_location): Update.
9746         (free_bp_location): Update.
9747         * ada-lang.c (class ada_catchpoint_location)
9748         <ada_catchpoint_location>: Remove ops parameter.
9749         (ada_catchpoint_location_dtor): Remove.
9750         (ada_catchpoint_location_ops): Remove.
9751         (allocate_location_exception): Update.
9752         * breakpoint.h (struct bp_location_ops): Remove.
9753         (class bp_location) <bp_location>: Remove bp_location_ops
9754         parameter.
9755         <~bp_location>: Add destructor.
9756         <ops>: Remove.
9757
9758 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9759             Pedro Alves  <palves@redhat.com>
9760
9761         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9762         'PATH_MAX'.
9763
9764 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9765             Samuel Thibault  <samuel.thibault@gnu.org>
9766             Thomas Schwinge  <thomas@codesourcery.com>
9767
9768         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9769         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9770
9771 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9772
9773         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9774         (check_empty): Use "const char *".
9775
9776         * gnu-nat.c (gnu_nat_target::detach): Instead of
9777         'detach_inferior (pid)' call
9778         'detach_inferior (find_inferior_pid (pid))'.
9779
9780         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9781         'nat/fork-inferior.o'.
9782         * gnu-nat.c: #include "nat/fork-inferior.h".
9783
9784         * gnu-nat.c (gnu_nat_target::detach): Instead of
9785         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9786         * gnu-nat.h: #include "inf-child.h".
9787         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9788         'i386_gnu_nat_target::fetch_registers'.
9789         (gnu_store_registers): Rename/move to
9790         'i386_gnu_nat_target::store_registers'.
9791
9792         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9793         * gnu-nat.h (mach_thread_info): New function.
9794         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9795
9796         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9797
9798 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9799
9800         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9801
9802 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9803
9804         * windows-nat.c (windows_add_thread): Add new parameter
9805         "main_thread_p" with default value set to false.  Update
9806         function documentation as well as all callers.
9807         (windows_delete_thread): Likewise.
9808         (fake_create_process): Update call to windows_add_thread.
9809         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9810         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9811         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9812         call to windows_delete_thread.
9813
9814 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9815
9816         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9817
9818 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9819
9820         * symfile.c (find_separate_debug_file): Use canonical path of
9821         sysroot with child_path instead of gdb_sysroot if it is valid.
9822
9823 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9824
9825         * symfile.c (find_separate_debug_file): Use child_path to
9826         determine if an object file is under a sysroot.
9827
9828 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9829
9830         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9831         unittests/child-path-selftests.c.
9832         * common/pathstuff.c (child_path): New function.
9833         * common/pathstuff.h (child_path): New prototype.
9834         * unittests/child-path-selftests.c: New file.
9835
9836 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9837
9838         * symfile.c (find_separate_debug_file): Look for separate debug
9839         files in debug directories under the sysroot.
9840
9841 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9842
9843         * symtab.h (struct minimal_symbol data_p): New const method.
9844         (struct minimal_symbol text_p): Likewise.
9845         * symtab.c (output_source_filename): Use file name style
9846         to print file name.
9847         (print_symbol_info): Likewise.
9848         (print_msymbol_info): Use address style to print addresses.
9849         Use function name style to print executable text symbols.
9850         (expand_symtab_containing_pc): Use data_p.
9851         (find_pc_sect_compunit_symtab): Likewise.
9852
9853 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9854
9855         * breakpoint.c (describe_other_breakpoints): Use address style
9856         to print addresses.
9857         (say_where): Likewise.
9858
9859 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9860
9861         * ada-typeprint.c (print_func_type): Print function name
9862         style to print function name.
9863         * c-typeprint.c (c_print_type_1): Likewise.
9864
9865 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9866
9867         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9868         for execve.
9869
9870 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9871
9872         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9873         type_stack.
9874
9875 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9876
9877         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9878         TYPE_CODE_REF types.
9879
9880 2019-02-08  Jim Wilson  <jimw@sifive.com>
9881
9882         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9883         (riscv_linux_fregset): New.
9884         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9885
9886 2019-02-07  Tom Tromey  <tom@tromey.com>
9887
9888         * thread.c (thread_cancel_execution_command): Update.
9889         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9890         methods.
9891         (struct thread_fsm_ops): Remove.
9892         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9893         (thread_fsm_should_stop, thread_fsm_return_value)
9894         (thread_fsm_set_finished, thread_fsm_finished_p)
9895         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9896         Don't declare.
9897         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9898         * infrun.c (clear_proceed_status_thread)
9899         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9900         (print_stop_event): Update.
9901         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9902         Add constructor.
9903         (step_command_fsm_ops): Remove.
9904         (new_step_command_fsm): Remove.
9905         (step_1): Update.
9906         (step_command_fsm::should_stop): Rename from
9907         step_command_fsm_should_stop.
9908         (step_command_fsm::clean_up): Rename from
9909         step_command_fsm_clean_up.
9910         (step_command_fsm::do_async_reply_reason): Rename from
9911         step_command_fsm_async_reply_reason.
9912         (struct until_next_fsm): Inherit from thread_fsm.  Add
9913         constructor.
9914         (until_next_fsm_ops): Remove.
9915         (new_until_next_fsm): Remove.
9916         (until_next_fsm::should_stop): Rename from
9917         until_next_fsm_should_stop.
9918         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9919         (until_next_fsm::do_async_reply_reason): Rename from
9920         until_next_fsm_async_reply_reason.
9921         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9922         constructor.  Change type of breakpoint.
9923         (finish_command_fsm_ops): Remove.
9924         (new_finish_command_fsm): Remove.
9925         (finish_command_fsm::should_stop): Rename from
9926         finish_command_fsm_should_stop.
9927         (finish_command_fsm::clean_up): Rename from
9928         finish_command_fsm_clean_up.
9929         (finish_command_fsm::return_value): Rename from
9930         finish_command_fsm_return_value.
9931         (finish_command_fsm::do_async_reply_reason): Rename from
9932         finish_command_fsm_async_reply_reason.
9933         (finish_command): Update.
9934         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9935         Add constructor.
9936         (call_thread_fsm_ops): Remove.
9937         (call_thread_fsm::call_thread_fsm): Rename from
9938         new_call_thread_fsm.
9939         (call_thread_fsm::should_stop): Rename from
9940         call_thread_fsm_should_stop.
9941         (call_thread_fsm::should_notify_stop): Rename from
9942         call_thread_fsm_should_notify_stop.
9943         (run_inferior_call, call_function_by_hand_dummy): Update.
9944         * cli/cli-interp.c (should_print_stop_to_console): Update.
9945         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9946         Add constructor.  Change type of location_breakpoint,
9947         caller_breakpoint.
9948         (until_break_fsm_ops): Remove.
9949         (new_until_break_fsm): Remove.
9950         (until_break_fsm::should_stop): Rename from
9951         until_break_fsm_should_stop.
9952         (until_break_fsm::clean_up): Rename from
9953         until_break_fsm_clean_up.
9954         (until_break_fsm::do_async_reply_reason): Rename from
9955         until_break_fsm_async_reply_reason.
9956         (until_break_command): Update.
9957         * thread-fsm.c: Remove.
9958         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9959
9960 2019-02-07  Tom Tromey  <tom@tromey.com>
9961
9962         * yy-remap.h: Add include guard.
9963         * xtensa-tdep.h: Add include guard.
9964         * xcoffread.h: Rename include guard.
9965         * varobj-iter.h: Add include guard.
9966         * tui/tui.h: Rename include guard.
9967         * tui/tui-winsource.h: Rename include guard.
9968         * tui/tui-wingeneral.h: Rename include guard.
9969         * tui/tui-windata.h: Rename include guard.
9970         * tui/tui-win.h: Rename include guard.
9971         * tui/tui-stack.h: Rename include guard.
9972         * tui/tui-source.h: Rename include guard.
9973         * tui/tui-regs.h: Rename include guard.
9974         * tui/tui-out.h: Rename include guard.
9975         * tui/tui-layout.h: Rename include guard.
9976         * tui/tui-io.h: Rename include guard.
9977         * tui/tui-hooks.h: Rename include guard.
9978         * tui/tui-file.h: Rename include guard.
9979         * tui/tui-disasm.h: Rename include guard.
9980         * tui/tui-data.h: Rename include guard.
9981         * tui/tui-command.h: Rename include guard.
9982         * tic6x-tdep.h: Add include guard.
9983         * target/waitstatus.h: Rename include guard.
9984         * target/wait.h: Rename include guard.
9985         * target/target.h: Rename include guard.
9986         * target/resume.h: Rename include guard.
9987         * target-float.h: Rename include guard.
9988         * stabsread.h: Add include guard.
9989         * rs6000-tdep.h: Add include guard.
9990         * riscv-fbsd-tdep.h: Add include guard.
9991         * regformats/regdef.h: Rename include guard.
9992         * record.h: Rename include guard.
9993         * python/python.h: Rename include guard.
9994         * python/python-internal.h: Rename include guard.
9995         * python/py-stopevent.h: Rename include guard.
9996         * python/py-ref.h: Rename include guard.
9997         * python/py-record.h: Rename include guard.
9998         * python/py-record-full.h: Rename include guard.
9999         * python/py-record-btrace.h: Rename include guard.
10000         * python/py-instruction.h: Rename include guard.
10001         * python/py-events.h: Rename include guard.
10002         * python/py-event.h: Rename include guard.
10003         * procfs.h: Add include guard.
10004         * proc-utils.h: Add include guard.
10005         * p-lang.h: Add include guard.
10006         * or1k-tdep.h: Rename include guard.
10007         * observable.h: Rename include guard.
10008         * nto-tdep.h: Rename include guard.
10009         * nat/x86-linux.h: Rename include guard.
10010         * nat/x86-linux-dregs.h: Rename include guard.
10011         * nat/x86-gcc-cpuid.h: Add include guard.
10012         * nat/x86-dregs.h: Rename include guard.
10013         * nat/x86-cpuid.h: Rename include guard.
10014         * nat/ppc-linux.h: Rename include guard.
10015         * nat/mips-linux-watch.h: Rename include guard.
10016         * nat/linux-waitpid.h: Rename include guard.
10017         * nat/linux-ptrace.h: Rename include guard.
10018         * nat/linux-procfs.h: Rename include guard.
10019         * nat/linux-osdata.h: Rename include guard.
10020         * nat/linux-nat.h: Rename include guard.
10021         * nat/linux-namespaces.h: Rename include guard.
10022         * nat/linux-btrace.h: Rename include guard.
10023         * nat/glibc_thread_db.h: Rename include guard.
10024         * nat/gdb_thread_db.h: Rename include guard.
10025         * nat/gdb_ptrace.h: Rename include guard.
10026         * nat/fork-inferior.h: Rename include guard.
10027         * nat/amd64-linux-siginfo.h: Rename include guard.
10028         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10029         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10030         * nat/aarch64-linux.h: Rename include guard.
10031         * nat/aarch64-linux-hw-point.h: Rename include guard.
10032         * mn10300-tdep.h: Add include guard.
10033         * mips-linux-tdep.h: Add include guard.
10034         * mi/mi-parse.h: Rename include guard.
10035         * mi/mi-out.h: Rename include guard.
10036         * mi/mi-main.h: Rename include guard.
10037         * mi/mi-interp.h: Rename include guard.
10038         * mi/mi-getopt.h: Rename include guard.
10039         * mi/mi-console.h: Rename include guard.
10040         * mi/mi-common.h: Rename include guard.
10041         * mi/mi-cmds.h: Rename include guard.
10042         * mi/mi-cmd-break.h: Rename include guard.
10043         * m2-lang.h: Add include guard.
10044         * location.h: Rename include guard.
10045         * linux-record.h: Rename include guard.
10046         * linux-nat.h: Add include guard.
10047         * linux-fork.h: Add include guard.
10048         * i386-darwin-tdep.h: Rename include guard.
10049         * hppa-linux-offsets.h: Add include guard.
10050         * guile/guile.h: Rename include guard.
10051         * guile/guile-internal.h: Rename include guard.
10052         * gnu-nat.h: Rename include guard.
10053         * gdb-stabs.h: Rename include guard.
10054         * frv-tdep.h: Add include guard.
10055         * f-lang.h: Add include guard.
10056         * event-loop.h: Add include guard.
10057         * darwin-nat.h: Rename include guard.
10058         * cp-abi.h: Rename include guard.
10059         * config/sparc/nm-sol2.h: Rename include guard.
10060         * config/nm-nto.h: Rename include guard.
10061         * config/nm-linux.h: Add include guard.
10062         * config/i386/nm-i386gnu.h: Rename include guard.
10063         * config/djgpp/nl_types.h: Rename include guard.
10064         * config/djgpp/langinfo.h: Rename include guard.
10065         * compile/gcc-cp-plugin.h: Add include guard.
10066         * compile/gcc-c-plugin.h: Add include guard.
10067         * compile/compile.h: Rename include guard.
10068         * compile/compile-object-run.h: Rename include guard.
10069         * compile/compile-object-load.h: Rename include guard.
10070         * compile/compile-internal.h: Rename include guard.
10071         * compile/compile-cplus.h: Rename include guard.
10072         * compile/compile-c.h: Rename include guard.
10073         * common/xml-utils.h: Rename include guard.
10074         * common/x86-xstate.h: Rename include guard.
10075         * common/version.h: Rename include guard.
10076         * common/vec.h: Rename include guard.
10077         * common/tdesc.h: Rename include guard.
10078         * common/selftest.h: Rename include guard.
10079         * common/scoped_restore.h: Rename include guard.
10080         * common/scoped_mmap.h: Rename include guard.
10081         * common/scoped_fd.h: Rename include guard.
10082         * common/safe-iterator.h: Rename include guard.
10083         * common/run-time-clock.h: Rename include guard.
10084         * common/refcounted-object.h: Rename include guard.
10085         * common/queue.h: Rename include guard.
10086         * common/ptid.h: Rename include guard.
10087         * common/print-utils.h: Rename include guard.
10088         * common/preprocessor.h: Rename include guard.
10089         * common/pathstuff.h: Rename include guard.
10090         * common/observable.h: Rename include guard.
10091         * common/netstuff.h: Rename include guard.
10092         * common/job-control.h: Rename include guard.
10093         * common/host-defs.h: Rename include guard.
10094         * common/gdb_wait.h: Rename include guard.
10095         * common/gdb_vecs.h: Rename include guard.
10096         * common/gdb_unlinker.h: Rename include guard.
10097         * common/gdb_unique_ptr.h: Rename include guard.
10098         * common/gdb_tilde_expand.h: Rename include guard.
10099         * common/gdb_sys_time.h: Rename include guard.
10100         * common/gdb_string_view.h: Rename include guard.
10101         * common/gdb_splay_tree.h: Rename include guard.
10102         * common/gdb_setjmp.h: Rename include guard.
10103         * common/gdb_ref_ptr.h: Rename include guard.
10104         * common/gdb_optional.h: Rename include guard.
10105         * common/gdb_locale.h: Rename include guard.
10106         * common/gdb_assert.h: Rename include guard.
10107         * common/filtered-iterator.h: Rename include guard.
10108         * common/filestuff.h: Rename include guard.
10109         * common/fileio.h: Rename include guard.
10110         * common/environ.h: Rename include guard.
10111         * common/common-utils.h: Rename include guard.
10112         * common/common-types.h: Rename include guard.
10113         * common/common-regcache.h: Rename include guard.
10114         * common/common-inferior.h: Rename include guard.
10115         * common/common-gdbthread.h: Rename include guard.
10116         * common/common-exceptions.h: Rename include guard.
10117         * common/common-defs.h: Rename include guard.
10118         * common/common-debug.h: Rename include guard.
10119         * common/cleanups.h: Rename include guard.
10120         * common/buffer.h: Rename include guard.
10121         * common/btrace-common.h: Rename include guard.
10122         * common/break-common.h: Rename include guard.
10123         * cli/cli-utils.h: Rename include guard.
10124         * cli/cli-style.h: Rename include guard.
10125         * cli/cli-setshow.h: Rename include guard.
10126         * cli/cli-script.h: Rename include guard.
10127         * cli/cli-interp.h: Rename include guard.
10128         * cli/cli-decode.h: Rename include guard.
10129         * cli/cli-cmds.h: Rename include guard.
10130         * charset-list.h: Add include guard.
10131         * buildsym-legacy.h: Rename include guard.
10132         * bfin-tdep.h: Add include guard.
10133         * ax.h: Rename include guard.
10134         * arm-linux-tdep.h: Add include guard.
10135         * arm-fbsd-tdep.h: Add include guard.
10136         * arch/xtensa.h: Rename include guard.
10137         * arch/tic6x.h: Add include guard.
10138         * arch/i386.h: Add include guard.
10139         * arch/arm.h: Rename include guard.
10140         * arch/arm-linux.h: Rename include guard.
10141         * arch/arm-get-next-pcs.h: Rename include guard.
10142         * arch/amd64.h: Add include guard.
10143         * arch/aarch64-insn.h: Rename include guard.
10144         * arch-utils.h: Rename include guard.
10145         * annotate.h: Add include guard.
10146         * amd64-darwin-tdep.h: Rename include guard.
10147         * aarch64-linux-tdep.h: Add include guard.
10148         * aarch64-fbsd-tdep.h: Add include guard.
10149         * aarch32-linux-nat.h: Add include guard.
10150
10151 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10152
10153         * macrotab.c (macro_define_internal): New function that
10154         factorizes macro_define_object_internal and macro_define_function
10155         code.
10156         (macro_define_object_internal): Use macro_define_internal.
10157         (macro_define_function): Likewise.
10158
10159 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10160
10161         * macrocmd.c (extract_identifier): Return
10162         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10163         callers.
10164
10165 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10166
10167         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10168
10169 2019-02-05  Tom Tromey  <tom@tromey.com>
10170
10171         * target.c (target_stack::unpush): Move assertion earlier.
10172
10173 2019-01-30  Tom Tromey  <tom@tromey.com>
10174
10175         PR python/23615:
10176         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10177         (gdbpy_parse_and_eval): Likewise.
10178         * python/python-internal.h (gdbpy_allow_threads): New class.
10179
10180 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10181
10182         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10183         (aarch64_fbsd_fpregmap): Move earlier.
10184         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10185         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10186         instead of individual calls to trad_frame_set_reg_addr.
10187         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10188         earlier.
10189         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10190         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10191         instead of individual calls to trad_frame_set_reg_addr.
10192
10193 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10194
10195         * CONTRIBUTE: Replace contribution list with wiki link.
10196
10197 2019-01-25  Tom Tromey  <tom@tromey.com>
10198
10199         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10200
10201 2019-01-25  Tom Tromey  <tom@tromey.com>
10202
10203         * xtensa-linux-nat.c: Fix common/ includes.
10204         * xml-support.h: Fix common/ includes.
10205         * xml-support.c: Fix common/ includes.
10206         * x86-linux-nat.c: Fix common/ includes.
10207         * windows-nat.c: Fix common/ includes.
10208         * varobj.h: Fix common/ includes.
10209         * varobj.c: Fix common/ includes.
10210         * value.c: Fix common/ includes.
10211         * valops.c: Fix common/ includes.
10212         * utils.c: Fix common/ includes.
10213         * unittests/xml-utils-selftests.c: Fix common/ includes.
10214         * unittests/utils-selftests.c: Fix common/ includes.
10215         * unittests/unpack-selftests.c: Fix common/ includes.
10216         * unittests/tracepoint-selftests.c: Fix common/ includes.
10217         * unittests/style-selftests.c: Fix common/ includes.
10218         * unittests/string_view-selftests.c: Fix common/ includes.
10219         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10220         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10221         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10222         * unittests/rsp-low-selftests.c: Fix common/ includes.
10223         * unittests/parse-connection-spec-selftests.c: Fix common/
10224         includes.
10225         * unittests/optional-selftests.c: Fix common/ includes.
10226         * unittests/offset-type-selftests.c: Fix common/ includes.
10227         * unittests/observable-selftests.c: Fix common/ includes.
10228         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10229         * unittests/memrange-selftests.c: Fix common/ includes.
10230         * unittests/memory-map-selftests.c: Fix common/ includes.
10231         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10232         * unittests/function-view-selftests.c: Fix common/ includes.
10233         * unittests/environ-selftests.c: Fix common/ includes.
10234         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10235         * unittests/common-utils-selftests.c: Fix common/ includes.
10236         * unittests/cli-utils-selftests.c: Fix common/ includes.
10237         * unittests/array-view-selftests.c: Fix common/ includes.
10238         * ui-file.c: Fix common/ includes.
10239         * tui/tui-io.c: Fix common/ includes.
10240         * tracepoint.h: Fix common/ includes.
10241         * tracepoint.c: Fix common/ includes.
10242         * tracefile-tfile.c: Fix common/ includes.
10243         * top.h: Fix common/ includes.
10244         * top.c: Fix common/ includes.
10245         * thread.c: Fix common/ includes.
10246         * target/waitstatus.h: Fix common/ includes.
10247         * target/waitstatus.c: Fix common/ includes.
10248         * target.h: Fix common/ includes.
10249         * target.c: Fix common/ includes.
10250         * target-memory.c: Fix common/ includes.
10251         * target-descriptions.c: Fix common/ includes.
10252         * symtab.h: Fix common/ includes.
10253         * symfile.c: Fix common/ includes.
10254         * stap-probe.c: Fix common/ includes.
10255         * spu-linux-nat.c: Fix common/ includes.
10256         * sparc-nat.c: Fix common/ includes.
10257         * source.c: Fix common/ includes.
10258         * solib.c: Fix common/ includes.
10259         * solib-target.c: Fix common/ includes.
10260         * ser-unix.c: Fix common/ includes.
10261         * ser-tcp.c: Fix common/ includes.
10262         * ser-pipe.c: Fix common/ includes.
10263         * ser-base.c: Fix common/ includes.
10264         * selftest-arch.c: Fix common/ includes.
10265         * s12z-tdep.c: Fix common/ includes.
10266         * rust-exp.y: Fix common/ includes.
10267         * rs6000-aix-tdep.c: Fix common/ includes.
10268         * riscv-tdep.c: Fix common/ includes.
10269         * remote.c: Fix common/ includes.
10270         * remote-notif.h: Fix common/ includes.
10271         * remote-fileio.h: Fix common/ includes.
10272         * remote-fileio.c: Fix common/ includes.
10273         * regcache.h: Fix common/ includes.
10274         * regcache.c: Fix common/ includes.
10275         * record-btrace.c: Fix common/ includes.
10276         * python/python.c: Fix common/ includes.
10277         * python/py-type.c: Fix common/ includes.
10278         * python/py-inferior.c: Fix common/ includes.
10279         * progspace.h: Fix common/ includes.
10280         * producer.c: Fix common/ includes.
10281         * procfs.c: Fix common/ includes.
10282         * proc-api.c: Fix common/ includes.
10283         * printcmd.c: Fix common/ includes.
10284         * ppc-linux-nat.c: Fix common/ includes.
10285         * parser-defs.h: Fix common/ includes.
10286         * osdata.c: Fix common/ includes.
10287         * obsd-nat.c: Fix common/ includes.
10288         * nat/x86-linux.c: Fix common/ includes.
10289         * nat/x86-linux-dregs.c: Fix common/ includes.
10290         * nat/x86-dregs.h: Fix common/ includes.
10291         * nat/x86-dregs.c: Fix common/ includes.
10292         * nat/ppc-linux.c: Fix common/ includes.
10293         * nat/mips-linux-watch.h: Fix common/ includes.
10294         * nat/mips-linux-watch.c: Fix common/ includes.
10295         * nat/linux-waitpid.c: Fix common/ includes.
10296         * nat/linux-ptrace.h: Fix common/ includes.
10297         * nat/linux-ptrace.c: Fix common/ includes.
10298         * nat/linux-procfs.c: Fix common/ includes.
10299         * nat/linux-personality.c: Fix common/ includes.
10300         * nat/linux-osdata.c: Fix common/ includes.
10301         * nat/linux-namespaces.c: Fix common/ includes.
10302         * nat/linux-btrace.h: Fix common/ includes.
10303         * nat/linux-btrace.c: Fix common/ includes.
10304         * nat/fork-inferior.c: Fix common/ includes.
10305         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10306         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10307         * nat/aarch64-linux.c: Fix common/ includes.
10308         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10309         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10310         * namespace.h: Fix common/ includes.
10311         * mips-linux-tdep.c: Fix common/ includes.
10312         * minsyms.c: Fix common/ includes.
10313         * mi/mi-parse.h: Fix common/ includes.
10314         * mi/mi-main.c: Fix common/ includes.
10315         * mi/mi-cmd-env.c: Fix common/ includes.
10316         * memrange.h: Fix common/ includes.
10317         * memattr.c: Fix common/ includes.
10318         * maint.h: Fix common/ includes.
10319         * maint.c: Fix common/ includes.
10320         * main.c: Fix common/ includes.
10321         * machoread.c: Fix common/ includes.
10322         * location.c: Fix common/ includes.
10323         * linux-thread-db.c: Fix common/ includes.
10324         * linux-nat.c: Fix common/ includes.
10325         * linux-fork.c: Fix common/ includes.
10326         * inline-frame.c: Fix common/ includes.
10327         * infrun.c: Fix common/ includes.
10328         * inflow.c: Fix common/ includes.
10329         * inferior.h: Fix common/ includes.
10330         * inferior.c: Fix common/ includes.
10331         * infcmd.c: Fix common/ includes.
10332         * inf-ptrace.c: Fix common/ includes.
10333         * inf-child.c: Fix common/ includes.
10334         * ia64-linux-nat.c: Fix common/ includes.
10335         * i387-tdep.c: Fix common/ includes.
10336         * i386-tdep.c: Fix common/ includes.
10337         * i386-linux-tdep.c: Fix common/ includes.
10338         * i386-linux-nat.c: Fix common/ includes.
10339         * i386-go32-tdep.c: Fix common/ includes.
10340         * i386-fbsd-tdep.c: Fix common/ includes.
10341         * i386-fbsd-nat.c: Fix common/ includes.
10342         * guile/scm-type.c: Fix common/ includes.
10343         * guile/guile.c: Fix common/ includes.
10344         * go32-nat.c: Fix common/ includes.
10345         * gnu-nat.c: Fix common/ includes.
10346         * gdbthread.h: Fix common/ includes.
10347         * gdbarch-selftests.c: Fix common/ includes.
10348         * gdb_usleep.c: Fix common/ includes.
10349         * gdb_select.h: Fix common/ includes.
10350         * gdb_bfd.c: Fix common/ includes.
10351         * gcore.c: Fix common/ includes.
10352         * fork-child.c: Fix common/ includes.
10353         * findvar.c: Fix common/ includes.
10354         * fbsd-nat.c: Fix common/ includes.
10355         * event-top.c: Fix common/ includes.
10356         * event-loop.c: Fix common/ includes.
10357         * dwarf2read.c: Fix common/ includes.
10358         * dwarf2loc.c: Fix common/ includes.
10359         * dwarf2-frame.c: Fix common/ includes.
10360         * dwarf-index-cache.c: Fix common/ includes.
10361         * dtrace-probe.c: Fix common/ includes.
10362         * disasm-selftests.c: Fix common/ includes.
10363         * defs.h: Fix common/ includes.
10364         * csky-tdep.c: Fix common/ includes.
10365         * cp-valprint.c: Fix common/ includes.
10366         * cp-support.h: Fix common/ includes.
10367         * cp-support.c: Fix common/ includes.
10368         * corelow.c: Fix common/ includes.
10369         * completer.h: Fix common/ includes.
10370         * completer.c: Fix common/ includes.
10371         * compile/compile.c: Fix common/ includes.
10372         * compile/compile-loc2c.c: Fix common/ includes.
10373         * compile/compile-cplus-types.c: Fix common/ includes.
10374         * compile/compile-cplus-symbols.c: Fix common/ includes.
10375         * command.h: Fix common/ includes.
10376         * cli/cli-dump.c: Fix common/ includes.
10377         * cli/cli-cmds.c: Fix common/ includes.
10378         * charset.c: Fix common/ includes.
10379         * build-id.c: Fix common/ includes.
10380         * btrace.h: Fix common/ includes.
10381         * btrace.c: Fix common/ includes.
10382         * breakpoint.h: Fix common/ includes.
10383         * breakpoint.c: Fix common/ includes.
10384         * ax.h:
10385         (enum agent_op): Fix common/ includes.
10386         * ax-general.c (struct aop_map): Fix common/ includes.
10387         * ax-gdb.c: Fix common/ includes.
10388         * auxv.c: Fix common/ includes.
10389         * auto-load.c: Fix common/ includes.
10390         * arm-tdep.c: Fix common/ includes.
10391         * arch/riscv.c: Fix common/ includes.
10392         * arch/ppc-linux-common.c: Fix common/ includes.
10393         * arch/i386.c: Fix common/ includes.
10394         * arch/arm.c: Fix common/ includes.
10395         * arch/arm-linux.c: Fix common/ includes.
10396         * arch/arm-get-next-pcs.c: Fix common/ includes.
10397         * arch/amd64.c: Fix common/ includes.
10398         * arch/aarch64.c: Fix common/ includes.
10399         * arch/aarch64-insn.c: Fix common/ includes.
10400         * arch-utils.c: Fix common/ includes.
10401         * amd64-windows-tdep.c: Fix common/ includes.
10402         * amd64-tdep.c: Fix common/ includes.
10403         * amd64-sol2-tdep.c: Fix common/ includes.
10404         * amd64-obsd-tdep.c: Fix common/ includes.
10405         * amd64-nbsd-tdep.c: Fix common/ includes.
10406         * amd64-linux-tdep.c: Fix common/ includes.
10407         * amd64-linux-nat.c: Fix common/ includes.
10408         * amd64-fbsd-tdep.c: Fix common/ includes.
10409         * amd64-fbsd-nat.c: Fix common/ includes.
10410         * amd64-dicos-tdep.c: Fix common/ includes.
10411         * amd64-darwin-tdep.c: Fix common/ includes.
10412         * agent.c: Fix common/ includes.
10413         * ada-lang.h: Fix common/ includes.
10414         * ada-lang.c: Fix common/ includes.
10415         * aarch64-tdep.c: Fix common/ includes.
10416
10417 2019-01-25  Tom Tromey  <tom@tromey.com>
10418
10419         * common/create-version.sh: Use common/version.h.
10420
10421 2019-01-24  Pedro Alves  <palves@redhat.com>
10422
10423         * infrun.c (signal_stop, signal_print, signal_program)
10424         (signal_catch, signal_pass): Now arrays instead of pointers.
10425         (update_signals_program_target, do_target_resume)
10426         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10427         * linux-nat.c (linux_nat_target::pass_signals)
10428         (linux_nat_target::create_inferior, linux_nat_target::attach):
10429         Adjust.
10430         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10431         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10432         * procfs.c (procfs_target::pass_signals): Adjust.
10433         * record-full.c (record_full_target::resume): Adjust.
10434         * remote.c (remote_target::pass_signals)
10435         (remote_target::program_signals): Adjust.
10436         * target-debug.h (target_debug_print_signals): Now takes a
10437         gdb::array_view as parameter.  Adjust.
10438         * target.h (target_ops) <pass_signals, program_signals>: Replace
10439         pointer and length parameters with gdb::array_view.
10440         (target_pass_signals, target_program_signals): Likewise.
10441         * target-delegates.c: Regenerate.
10442
10443 2019-01-24  Pedro Alves  <palves@redhat.com>
10444
10445         * common/forward-scope-exit.h
10446         (forward_scope_exit::forward_scope_exit): Pass arguments to
10447         m_bind_function directly, instead of creating a std::bind and
10448         copying that.
10449
10450 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10451
10452         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10453         for static members.
10454         (pass_in_v_vfp_candidate): Likewise.
10455
10456 2019-01-23  Tom Tromey  <tom@tromey.com>
10457             Pedro Alves  <palves@redhat.com>
10458
10459         * regcache.c (class regcache_invalidator): Remove.
10460         (regcache::raw_write): Use make_scope_exit.
10461
10462 2019-01-23  Tom Tromey  <tom@tromey.com>
10463
10464         * ui-out.h (class ui_out_emit_type): Update comment.
10465
10466 2019-01-23  Tom Tromey  <tom@tromey.com>
10467
10468         * infrun.c (fetch_inferior_event): Update comment.
10469
10470 2019-01-23  Tom Tromey  <tom@tromey.com>
10471             Pedro Alves  <palves@redhat.com>
10472
10473         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10474         parameter.
10475         (fetch_inferior_event): Use SCOPE_EXIT.
10476
10477
10478 2019-01-23  Tom Tromey  <tom@tromey.com>
10479             Pedro Alves  <palves@redhat.com>
10480
10481         * infrun.c (disable_thread_events): Delete.
10482         (stop_all_threads): Use SCOPE_EXIT.
10483
10484 2019-01-23  Tom Tromey  <tom@tromey.com>
10485             Pedro Alves  <palves@redhat.com>
10486
10487         * symfile.c: Include forward-scope-exit.h.
10488         (clear_symtab_users_cleanup): Replace forward declaration with
10489         a FORWARD_SCOPE_EXIT.
10490         (syms_from_objfile_1): Use the forward_scope_exit and
10491         gdb::optional instead of cleanup_function.
10492         (reread_symbols): Use the forward_scope_exit instead of
10493         cleanup_function.
10494         (clear_symtab_users_cleanup): Remove function.
10495
10496 2019-01-23  Tom Tromey  <tom@tromey.com>
10497             Pedro Alves  <palves@redhat.com>
10498
10499         * linux-nat.c: Include scope-exit.h.
10500         (cleanup_target_stop): Remove.
10501         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10502         SCOPE_EXIT.
10503
10504 2019-01-23  Tom Tromey  <tom@tromey.com>
10505             Pedro Alves  <palves@redhat.com>
10506
10507         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10508         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10509
10510 2019-01-23  Tom Tromey  <tom@tromey.com>
10511             Andrew Burgess  <andrew.burgess@embecosm.com>
10512             Pedro Alves  <palves@redhat.com>
10513
10514         * infrun.c (fetch_inferior_event): Use scope_exit.
10515         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10516         * top.c (execute_command): Use scope_exit.
10517         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10518         * utils.c (do_bpstat_clear_actions_cleanup)
10519         (make_bpstat_clear_actions_cleanup): Remove.
10520
10521 2019-01-23  Tom Tromey  <tom@tromey.com>
10522             Pedro Alves  <palves@redhat.com>
10523
10524         * infrun.c: Include "common/scope-exit.h"
10525         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10526         (wait_for_inferior): Use SCOPE_EXIT.
10527         (fetch_inferior_event): Use scope_exit.
10528
10529 2019-01-23  Tom Tromey  <tom@tromey.com>
10530             Pedro Alves  <palves@redhat.com>
10531
10532         * breakpoint.c (create_breakpoint): Remove cleanup.
10533
10534 2019-01-23  Tom Tromey  <tom@tromey.com>
10535             Andrew Burgess  <andrew.burgess@embecosm.com>
10536             Pedro Alves  <palves@redhat.com>
10537
10538 2019-01-23  Pedro Alves  <palves@redhat.com>
10539
10540         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10541
10542 2019-01-23  Pedro Alves  <palves@redhat.com>
10543             Andrew Burgess  <andrew.burgess@embecosm.com>
10544
10545         * gdbthread.h: Include "common/forward-scope-exit.h".
10546         (scoped_finish_thread_state): Redefine custom class in terms of
10547         forward_scope_exit.
10548
10549 2019-01-23  Pedro Alves  <palves@redhat.com>
10550             Andrew Burgess  <andrew.burgess@embecosm.com>
10551
10552         * common/forward-scope-exit.h: New file.
10553
10554 2019-01-23  Pedro Alves  <palves@redhat.com>
10555             Andrew Burgess  <andrew.burgess@embecosm.com>
10556             Tom Tromey  <tom@tromey.com>
10557
10558         * common/scope-exit.h: New file.
10559
10560 2019-01-23  Pedro Alves  <palves@redhat.com>
10561
10562         * common/preprocessor.h (ESC): Rename to ...
10563         (ESC_PARENS): ... this.
10564         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10565         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10566
10567 2019-01-23  Tom Tromey  <tom@tromey.com>
10568
10569         * language.h (class scoped_switch_to_sym_language_if_auto):
10570         Initialize m_lang in both cases.
10571
10572 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10573
10574         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10575         with XCNEW.
10576
10577 2019-01-22  Tom Tromey  <tom@tromey.com>
10578
10579         * corelow.c: Do not include sys/file.h.
10580
10581 2019-01-22  Tom Tromey  <tom@tromey.com>
10582
10583         * tui/tui-wingeneral.h: Include gdb_curses.h.
10584
10585 2019-01-22  Tom Tromey  <tom@tromey.com>
10586
10587         * source-cache.h (class source_cache) <get_source_lines,
10588         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10589
10590 2019-01-22  Tom Tromey  <tom@tromey.com>
10591
10592         * remote-fileio.h (struct remote_target): Declare.
10593
10594 2019-01-22  Tom Tromey  <tom@tromey.com>
10595
10596         * python/py-arch.c: Do not include py-ref.h.
10597         * python/py-bpevent.c: Do not include py-ref.h.
10598         * python/py-cmd.c: Do not include py-ref.h.
10599         * python/py-continueevent.c: Do not include py-ref.h.
10600         * python/py-event.h: Do not include py-ref.h.
10601         * python/py-evtregistry.c: Do not include py-ref.h.
10602         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10603         * python/py-frame.c: Do not include py-ref.h.
10604         * python/py-framefilter.c: Do not include py-ref.h.
10605         * python/py-function.c: Do not include py-ref.h.
10606         * python/py-infevents.c: Do not include py-ref.h.
10607         * python/py-linetable.c: Do not include py-ref.h.
10608         * python/py-objfile.c: Do not include py-ref.h.
10609         * python/py-param.c: Do not include py-ref.h.
10610         * python/py-prettyprint.c: Do not include py-ref.h.
10611         * python/py-progspace.c: Do not include py-ref.h.
10612         * python/py-symbol.c: Do not include py-ref.h.
10613         * python/py-symtab.c: Do not include py-ref.h.
10614         * python/py-type.c: Do not include py-ref.h.
10615         * python/py-unwind.c: Do not include py-ref.h.
10616         * python/py-utils.c: Do not include py-ref.h.
10617         * python/py-value.c: Do not include py-ref.h.
10618         * python/py-varobj.c: Do not include py-ref.h.
10619         * python/py-xmethods.c: Do not include py-ref.h.
10620         * python/python.c: Do not include py-ref.h.
10621         * varobj.c: Do not include py-ref.h.
10622
10623 2019-01-22  Tom Tromey  <tom@tromey.com>
10624
10625         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10626         keyword for bcache.
10627
10628 2019-01-22  Tom Tromey  <tom@tromey.com>
10629
10630         * compile/compile-cplus-types.c: Remove a comment by #include.
10631
10632 2019-01-22  Tom Tromey  <tom@tromey.com>
10633
10634         * compile/gcc-c-plugin.h: Include compile-internal.h.
10635
10636 2019-01-22  Tom Tromey  <tom@tromey.com>
10637
10638         * stabsread.c (EXTERN): Do not define.
10639         (symnum, next_symbol_text_func, processing_gcc_compilation)
10640         (within_function, global_sym_chain, global_stabs)
10641         (previous_stab_code, this_object_header_files)
10642         (n_this_object_header_files)
10643         (n_allocated_this_object_header_files): Define.
10644         * stabsread.h (EXTERN): Never define.  Use "extern".
10645
10646 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10647
10648         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10649         history_value.
10650
10651 2019-01-21  Tom Tromey  <tom@tromey.com>
10652
10653         * ui-out.c: Fix includes.
10654         * tui/tui-source.c: Fix includes.
10655         * target.c: Fix includes.
10656         * remote.c: Fix includes.
10657         * regcache.c: Fix includes.
10658         * python/py-block.c: Fix includes.
10659         * printcmd.c: Fix includes.
10660         * or1k-tdep.c: Fix includes.
10661         * mi/mi-main.c: Fix includes.
10662         * m32r-tdep.c: Fix includes.
10663         * csky-tdep.c: Fix includes.
10664         * compile/compile-cplus-types.c: Fix includes.
10665         * cli/cli-interp.c: Fix includes.
10666
10667 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10668
10669         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10670         for padding.
10671
10672 2019-01-16  Tom Tromey  <tom@tromey.com>
10673
10674         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10675         earlier.
10676         (struct objfile) <msymbols_range>: Move from top level.
10677         <msymbols>: New method.
10678         (class objfile_msymbols): Remove.
10679         * symtab.c (default_collect_symbol_completion_matches_break_on):
10680         Update.
10681         * symmisc.c (dump_msymbols): Update.
10682         * stabsread.c (scan_file_globals): Update.
10683         * objc-lang.c (info_selectors_command, info_classes_command)
10684         (find_methods): Update.
10685         * minsyms.c (find_solib_trampoline_target): Update.
10686         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10687         * coffread.c (coff_symfile_read): Update.
10688         * ada-lang.c (ada_lookup_simple_minsym)
10689         (ada_collect_symbol_completion_matches): Update.
10690
10691 2019-01-16  Tom Tromey  <tom@tromey.com>
10692
10693         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10694         type.  Remove no-argument constructor.
10695         <iterator::operator++>: Simplify.
10696         <begin>: Update.
10697         <end>: Use minimal_symbol_count.
10698
10699 2019-01-16  Tom Tromey  <tom@tromey.com>
10700
10701         * objfiles.h (struct objfile) <psymtabs>: New method.
10702         (class objfile_psymtabs): Remove.
10703         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10704         typedef.
10705         <range>: New method.
10706         (require_partial_symbols): Change return type.
10707         * psymtab.c (require_partial_symbols)
10708         (psym_expand_symtabs_matching): Update.
10709         * mdebugread.c (parse_partial_symbols): Update.
10710         * dbxread.c (dbx_end_psymtab): Update.
10711
10712 2019-01-15  Tom Tromey  <tom@tromey.com>
10713
10714         * symtab.c (lookup_objfile_from_block)
10715         (lookup_symbol_in_objfile_symtabs)
10716         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10717         (find_line_symtab, info_sources_command)
10718         (default_collect_symbol_completion_matches_break_on)
10719         (make_source_files_completion_list): Update.
10720         * symmisc.c (print_objfile_statistics, dump_objfile)
10721         (maintenance_print_symbols, maintenance_info_symtabs)
10722         (maintenance_check_symtabs, maintenance_info_line_tables):
10723         Update.
10724         * source.c (select_source_symtab)
10725         (forget_cached_source_info_for_objfile): Update.
10726         * objfiles.h (class objfile_compunits): Remove.
10727         (struct objfile) <compunits_range>: New typedef.
10728         (compunits): New method.
10729         * objfiles.c (objfile_relocate1): Update.
10730         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10731         * maint.c (count_symtabs_and_blocks): Update.
10732         * linespec.c (iterate_over_all_matching_symtabs): Update.
10733         * cp-support.c (add_symbol_overload_list_qualified): Update.
10734         * coffread.c (coff_symtab_read): Update.
10735         * ada-lang.c (add_nonlocal_symbols)
10736         (ada_collect_symbol_completion_matches)
10737         (ada_add_global_exceptions): Update.
10738
10739 2019-01-15  Tom Tromey  <tom@tromey.com>
10740
10741         * progspace.h (program_space) <objfiles_safe_range>: New
10742         typedef.
10743         <objfiles_safe>: New method.
10744         * objfiles.h (class all_objfiles_safe): Remove.
10745         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10746         * jit.c (jit_inferior_exit_hook): Update.
10747
10748 2019-01-17  Tom Tromey  <tom@tromey.com>
10749
10750         * progspace.h (program_space) <objfiles_range>: New typedef.
10751         <objfiles>: New method.
10752         <objfiles_head>: Rename from objfiles.
10753         (object_files): Update.
10754         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10755         * guile/scm-pretty-print.c
10756         (ppscm_find_pretty_printer_from_objfiles): Update.
10757         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10758         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10759         Update.
10760         * python/py-progspace.c (pspy_get_objfiles): Update.
10761         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10762         Update.
10763         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10764         (objfpy_lookup_objfile_by_build_id): Update.
10765         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10766         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10767         Update.
10768         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10769         (expand_symtab_containing_pc, lookup_objfile_from_block)
10770         (lookup_static_symbol, basic_lookup_transparent_type)
10771         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10772         (find_line_symtab, info_sources_command)
10773         (default_collect_symbol_completion_matches_break_on)
10774         (make_source_files_completion_list, find_main_name): Update.
10775         * symmisc.c (print_symbol_bcache_statistics)
10776         (print_objfile_statistics, maintenance_print_symbols)
10777         (maintenance_print_msymbols, maintenance_print_objfiles)
10778         (maintenance_info_symtabs, maintenance_check_symtabs)
10779         (maintenance_expand_symtabs, maintenance_info_line_tables):
10780         Update.
10781         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10782         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10783         (map_overlay_command, unmap_overlay_command)
10784         (simple_overlay_update, expand_symtabs_matching)
10785         (map_symbol_filenames): Update.
10786         * symfile-debug.c (set_debug_symfile): Update.
10787         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10788         Update.
10789         * source.c (select_source_symtab, forget_cached_source_info):
10790         Update.
10791         * solib.c (solib_read_symbols): Update.
10792         * solib-spu.c (append_ocl_sos): Update.
10793         * psymtab.c (maintenance_print_psymbols)
10794         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10795         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10796         * printcmd.c (info_symbol_command): Update.
10797         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10798         Update.
10799         * objfiles.h (class all_objfiles): Remove.
10800         * objfiles.c (have_partial_symbols, have_full_symbols)
10801         (have_minimal_symbols, qsort_cmp, update_section_map)
10802         (shared_objfile_contains_address_p)
10803         (default_iterate_over_objfiles_in_search_order): Update.
10804         * objc-lang.c (info_selectors_command, info_classes_command)
10805         (find_methods): Update.
10806         * minsyms.c (find_solib_trampoline_target): Update.
10807         * maint.c (maintenance_info_sections)
10808         (maintenance_translate_address, count_symtabs_and_blocks):
10809         Update.
10810         * main.c (captured_main_1): Update.
10811         * linux-thread-db.c (try_thread_db_load_from_pdir)
10812         (has_libpthread): Update.
10813         * linespec.c (iterate_over_all_matching_symtabs)
10814         (search_minsyms_for_name): Update.
10815         * jit.c (jit_find_objf_with_entry_addr): Update.
10816         * hppa-tdep.c (find_unwind_entry)
10817         (hppa_lookup_stub_minimal_symbol): Update.
10818         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10819         Update.
10820         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10821         (elf_gnu_ifunc_resolve_by_got): Update.
10822         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10823         * dwarf-index-write.c (save_gdb_index_command): Update.
10824         * cp-support.c (add_symbol_overload_list_qualified): Update.
10825         * breakpoint.c (create_overlay_event_breakpoint)
10826         (create_longjmp_master_breakpoint)
10827         (create_std_terminate_master_breakpoint)
10828         (create_exception_master_breakpoint): Update.
10829         * blockframe.c (find_pc_partial_function): Update.
10830         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10831         (ada_collect_symbol_completion_matches)
10832         (ada_add_global_exceptions): Update.
10833
10834 2019-01-17  Tom Tromey  <tom@tromey.com>
10835
10836         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10837         declare VEC.
10838         (solib_target_parse_libraries): Change return type.
10839         (library_list_start_segment, library_list_start_section)
10840         (library_list_end_library, library_list_start_library); Update.
10841         (solib_target_free_library_list): Remove.
10842         (solib_target_parse_libraries): Remove cleanup.  Change return
10843         type.
10844         (solib_target_current_sos): Update.
10845
10846 2019-01-17  Tom Tromey  <tromey@bapiya>
10847
10848         * valprint.c: Replace "the the" with "the".
10849         * symtab.c: Replace "the the" with "the".
10850         * solib.c: Replace "the the" with "the".
10851         * solib-dsbt.c: Replace "the the" with "the".
10852         * linespec.c: Replace "the the" with "the".
10853         * dwarf2loc.h: Replace "the the" with "the".
10854         * amd64-windows-tdep.c: Replace "the the" with "the".
10855         * aarch64-tdep.c: Replace "the the" with "the".
10856
10857 2019-01-16  Keith Seitz  <keiths@redhat.com>
10858
10859         PR gdb/23773
10860         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10861         <builder>: Rename to ..
10862         <m_builder>: ... this and make private.
10863         (dwarf2_cu::get_builder): New method.  Change all users of
10864         `builder' to use this method.
10865         (dwarf2_start_symtab): Move to ...
10866         (dwarf2_cu::start_symtab): ... here.  Update all callers
10867         (setup_type_unit_groups): Move to ...
10868         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10869         callers.
10870         (dwarf2_cu::reset_builder): New method.
10871         (process_full_compunit, process_full_type_unit): Use
10872         dwarf2_cu::reset_builder.
10873         (follow_die_offset): Record the ancestor CU if it is different
10874         from the followed DIE's CU.
10875         (follow_die_sig_1): Likewise.
10876
10877 2019-01-15  Tom Tromey  <tom@tromey.com>
10878
10879         * remote.c (class remote_state) <buf>: Now a char_vector.
10880         <buf_size>: Remove.
10881         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10882         parameter.
10883         (remote_target::getpkt_or_notif_sane_1)
10884         (remote_target::getpkt_sane)
10885         (remote_target::getpkt_or_notif_sane): Likewise.
10886         (class remote_target) <putpkt>: New overload.
10887         (remote_target::read_frame): Change type of "buf_p".  Remove
10888         sizeof_p parameter.
10889         (packet_ok): New overload.
10890         (packet_check_result): New overload.
10891         Update all uses.
10892
10893 2019-01-14  Tom Tromey  <tom@tromey.com>
10894
10895         * remote-notif.c (handle_notification, remote_notif_ack)
10896         (remote_notif_parse): Make "buf" const.
10897         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10898         const.
10899         (remote_notif_parse, remote_notif_ack, handle_notification):
10900         Likewise.
10901         * remote.c (remote_notif_stop_parse): Make "buf" const.
10902         (remote_target::remote_parse_stop_reply): Make "buf" const.
10903         (remote_notif_stop_ack): Make "buf" const.
10904
10905 2019-01-14  Tom Tromey  <tom@tromey.com>
10906
10907         * remote.c (remote_console_output): Make parameter const.
10908
10909 2019-01-14  Tom Tromey  <tom@tromey.com>
10910
10911         * target-debug.h (target_debug_print_signals): Constify.
10912         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10913         * procfs.c (procfs_target::pass_signals): Update.
10914         * linux-nat.c (linux_nat_target::pass_signals): Update.
10915         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10916         * target-delegates.c: Rebuild.
10917         * remote.c (remote_target::program_signals): Update.
10918         (remote_target::pass_signals): Update.
10919         * target.c (target_pass_signals): Constify argument.
10920         (target_program_signals): Likewise.
10921         * target.h (struct target_ops) <pass_signals, program_signals>:
10922         Constify argument.
10923         (target_pass_signals, target_program_signals): Constify argument.
10924
10925 2019-01-14  Tom Tromey  <tom@tromey.com>
10926
10927         PR tui/28819:
10928         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10929
10930 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10931
10932         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10933         field.
10934         * rs6000-tdep.c: Include reggroups.h.
10935         (IS_V_ALIAS_PSEUDOREG): Define.
10936         (rs6000_register_name): Return names for the "vX" aliases.
10937         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10938         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10939         aliases.  Call default_register_reggroup_p for all other
10940         pseudo-registers.
10941         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10942         New functions.
10943         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10944         Handle "vX" aliases.
10945         (v_alias_pseudo_register_collect): New function.
10946         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10947         (rs6000_gdbarch_init): Initialize "vX" aliases as
10948         pseudo-registers.  Restore registration of
10949         rs6000_pseudo_register_reggroup_p with
10950         set_tdesc_pseudo_register_reggroup_p.
10951
10952 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10953
10954         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10955         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10956         set_gdbarch_num_pseudo_regs.
10957
10958 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10959
10960         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10961         Remove arg prefixname, add do_set and do_show.
10962         Add member functions set_list and show_list.
10963         * cli/cli-style.c (class cli_style_option): Update accordingly.
10964         (style_set_list): Move to file scope.
10965         (style_show_list): Likewise.
10966         (set_style): Call help_list.
10967         (show_style): Call cmd_show_list.
10968         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10969         Update to use the new macro.
10970
10971 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10972
10973         * ada-lang.c (_initialize_ada_language): Expand the help text
10974         for the "catch exception" command.
10975
10976 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10977
10978         * symtab.c (matching_obj_sections): Initialize obj,
10979         declare it closer to its usage.
10980
10981 2019-01-10  Tom Tromey  <tom@tromey.com>
10982
10983         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10984         (basic_inf_threads_range): Remove.
10985         (inf_threads_range, inf_non_exited_threads_range)
10986         (safe_inf_threads_range): Use next_adapter.
10987
10988 2019-01-10  Keith Seitz  <keiths@redhat.com>
10989
10990         PR gdb/23712
10991         PR symtab/23010
10992         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10993         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10994
10995 2019-01-10  Keith Seitz  <keiths@redhat.com>
10996
10997         PR gdb/23712
10998         PR symtab/23010
10999         * dictionary.c (pending_to_vector): Remove.
11000         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11001         Remove _1 suffix, replacing functions of the same name.  Update
11002         all callers.
11003         (dict_create_hashed, dict_create_hashed_expandable)
11004         (dict_create_linear, dict_create_linear_expandable, dict_free)
11005         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11006         Make functions static.
11007
11008 2019-01-10  Keith Seitz  <keiths@redhat.com>
11009
11010         PR gdb/23712
11011         PR symtab/23010
11012         * dictionary.h (struct dictionary): Replace declaration with
11013         multidictionary.
11014         (dict_create_hashed, dict_create_hashed_expandable)
11015         (dict_create_linear, dict_create_linear_expandable)
11016         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11017         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11018         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11019         taking multidictionary argument.
11020         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11021         * block.h (struct block) <dict>: Change to multidictionary
11022         and rename `multidict'.
11023         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11024         symmisc.c: Update all dictionary references to multidictionary.
11025
11026 2019-01-10  Keith Seitz  <keiths@redhat.com>
11027
11028         PR gdb/23712
11029         PR symtab/23010
11030         * dictionary.c: Include unordered_map.
11031         (pending_to_vector): New function.
11032         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11033         Rewrite the non-"_1" functions to take vector instead
11034         of linked list.
11035         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11036         "new" _1 versions of the same name.
11037         (multidictionary): Define.
11038         (std::hash<enum language): New definition.
11039         (collate_pending_symbols_by_language, mdict_create_hashed)
11040         (mdict_create_hashed_expandable, mdict_create_linear)
11041         (mdict_create_linear_expandable, mdict_free)
11042         (find_language_dictionary, create_new_language_dictionary)
11043         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11044         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11045         (mdict_size, mdict_empty): New functions.
11046         * dictionary.h (mdict_iterator): Define.
11047
11048 2019-01-10  Pedro Alves  <palves@redhat.com>
11049
11050         * breakpoint.c (read_uploaded_action)
11051         (create_tracepoint_from_upload): Adjust to use
11052         gdb::unique_xmalloc_ptr.
11053         * ctf.c (ctf_write_uploaded_tp):
11054         (SET_ARRAY_FIELD): Use emplace_back.
11055         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11056         * tracefile-tfile.c (tfile_write_uploaded_tp):
11057         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11058         gdb::unique_xmalloc_ptr.
11059         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11060         at_string, cond_string, cmd_strings>: Replace char pointers
11061         with gdb::unique_xmalloc_ptr.
11062
11063 2019-01-10  Pedro Alves  <palves@redhat.com>
11064
11065         * solib-target.c (library_list_start_library): Don't xstrdup name.
11066
11067 2019-01-10  Pedro Alves  <palves@redhat.com>
11068
11069         * mdebugread.c (parse_partial_symbols): Use
11070         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11071
11072 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11073
11074         * linux-fork.c (scoped_switch_fork_info)
11075         <~scoped_switch_fork_info>: Fix incorrect variable name.
11076
11077 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11078
11079         * linux-fork.c (scoped_switch_fork_info)
11080         <scoped_switch_fork_info>: Make explicit.
11081         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11082
11083 2019-01-10  Tom Tromey  <tom@tromey.com>
11084
11085         * objfiles.h (objfile::reset_psymtabs): Update.
11086         * objfiles.c (objfile::objfile): Update.
11087         * psymtab.h (psymtab_storage::obstack): Update.
11088         (psymtab_storage::m_obstack): Use gdb::optional.
11089         (class psymtab_storage): Update comment.  Remove objfile
11090         parameter.
11091         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11092
11093 2019-01-10  Tom Tromey  <tom@tromey.com>
11094
11095         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11096         <free_psymtabs>: Now private.
11097         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11098         (allocate_psymtab): Use new method.
11099
11100 2019-01-10  Tom Tromey  <tom@tromey.com>
11101
11102         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11103         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11104         * mdebugread.c (parse_partial_symbols): Use
11105         allocate_dependencies.
11106         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11107         allocate_dependencies.
11108         (process_psymtab_comp_unit_reader)
11109         (build_type_psymtab_dependencies): Likewise.
11110         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11111
11112 2019-01-10  Tom Tromey  <tom@tromey.com>
11113
11114         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11115         PSYMBOL_SET_LANGUAGE.
11116         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11117
11118 2019-01-10  Tom Tromey  <tom@tromey.com>
11119
11120         * psymtab.h (psymtab_storage::obstack): New method.
11121         <m_obstack>: Rename from obstack; now private.
11122         * psymtab.c (psymtab_storage): Update.
11123         * dwarf2read.c (create_addrmap_from_index)
11124         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11125         Update.
11126
11127 2019-01-10  Tom Tromey  <tom@tromey.com>
11128
11129         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11130         * objfiles.h (objfile::reset_psymtabs): New method.
11131
11132 2019-01-10  Tom Tromey  <tom@tromey.com>
11133
11134         * symmisc.c (print_symbol_bcache_statistics): Update.
11135         (print_objfile_statistics): Update.
11136         * symfile.c (reread_symbols): Update.
11137         * psymtab.h (class psymtab_storage): New.
11138         * psymtab.c (psymtab_storage): New constructor.
11139         (~psymtab_storage): New destructor.
11140         (require_partial_symbols): Update.
11141         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11142         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11143         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11144         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11145         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11146         (start_psymtab_common, end_psymtab_common)
11147         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11148         (allocate_psymtab): Update.
11149         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11150         Update.
11151         (dump_psymtab_addrmap, maintenance_print_psymbols)
11152         (maintenance_check_psymtabs): Update.
11153         (class objfile_psymtabs): Move to objfiles.h.
11154         * psympriv.h (discard_psymtab): Now inline.
11155         (psymtab_discarder::psymtab_discarder): Update.
11156         (psymtab_discarder::~psymtab_discarder): Update.
11157         (ALL_OBJFILE_PSYMTABS): Rewrite.
11158         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11159         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11160         Remove fields.
11161         <partial_symtabs>: New field.
11162         (class objfile_psymtabs): Move from psymtab.h.  Update.
11163         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11164         psymbol_cache.
11165         (objfile::~objfile): Don't destroy psymbol_cache.
11166         * mdebugread.c (parse_partial_symbols): Update.
11167         * dwarf2read.c (create_addrmap_from_index)
11168         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11169         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11170         (add_partial_subprogram, dwarf2_ranges_read): Update.
11171         * dwarf-index-write.c (write_address_map)
11172         (write_one_signatured_type, recursively_write_psymbols)
11173         (class debug_names, class debug_names, write_psymtabs_to_index):
11174         Update.
11175
11176 2019-01-10  Tom Tromey  <tom@tromey.com>
11177
11178         * symtab.h (SYMBOL_SET_NAMES): Update.
11179         (symbol_set_names): Update.
11180         (MSYMBOL_SET_NAMES): Update.
11181         * symtab.c (symbol_set_names): Change argument to be an
11182         objfile_per_bfd_storage.
11183         * psymtab.c (add_psymbol_to_bcache): Update.
11184         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11185
11186 2019-01-10  Tom Tromey  <tom@tromey.com>
11187
11188         * symtab.c (create_demangled_names_hash): Change argument to be an
11189         objfile_per_bfd_storage.
11190         (symbol_set_names): Update.
11191
11192 2019-01-10  Tom Tromey  <tom@tromey.com>
11193
11194         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11195         init_psymbol_list.
11196         * psymtab.c (init_psymbol_list): Do nothing if already called.
11197         * psympriv.h (init_psymbol_list): Add comment.
11198         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11199         init_psymbol_list.
11200         * dbxread.c (dbx_symfile_read): Unconditionally call
11201         init_psymbol_list.
11202
11203 2019-01-10  Tom Tromey  <tom@tromey.com>
11204
11205         * xcoffread.c (scan_xcoff_symtab): Update.
11206         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11207         "where".
11208         * mdebugread.c (parse_partial_symbols)
11209         (handle_psymbol_enumerators): Update.
11210         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11211         * dbxread.c (read_dbx_symtab): Update.
11212         * psympriv.h (psymbol_placement): New enum.
11213         (add_psymbol_to_list): Update.
11214
11215 2019-01-10  Tom Tromey  <tom@tromey.com>
11216
11217         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11218         static_psymbols parameters.
11219         (scan_xcoff_symtab): Update.
11220         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11221         static_psymbols parameters.
11222         * psympriv.h (start_psymtab_common): Update.
11223         * mdebugread.c (parse_partial_symbols): Update.
11224         * dwarf2read.c (create_partial_symtab): Update.
11225         * dbxread.c (read_dbx_symtab): Update.
11226         (start_psymtab): Remove global_psymbols and static_psymbols
11227         parameters.
11228
11229 2019-01-10  Tom Tromey  <tom@tromey.com>
11230
11231         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11232         * psymtab.c (allocate_psymtab): Add comment.
11233         * psympriv.h (allocate_psymtab): Add comment.
11234         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11235         initializations.
11236         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11237
11238 2019-01-10  Tom Tromey  <tom@tromey.com>
11239
11240         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11241         Don't declare.
11242         * mipsread.c: Include mdebugread.h.
11243         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11244         Declare.
11245         * elfread.c: Include mdebugread.h.
11246
11247 2019-01-09  Tom Tromey  <tom@tromey.com>
11248
11249         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11250         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11251         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11252         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11253         (psym_lookup_symbol, psym_find_last_source_symtab)
11254         (psym_forget_cached_source_info, psym_print_stats)
11255         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11256         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11257         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11258         (psym_find_compunit_symtab_by_address)
11259         (maintenance_print_psymbols, maintenance_info_psymtabs)
11260         (maintenance_check_psymtabs): Use ranged for.
11261         * psymtab.h (class objfile_psymtabs): New.
11262         (require_partial_symbols): Return objfile_psymtabs.
11263         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11264
11265 2019-01-09  Tom Tromey  <tom@tromey.com>
11266
11267         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11268         (find_pc_mapped_section, list_overlays_command)
11269         (map_overlay_command, unmap_overlay_command)
11270         (simple_overlay_update): Use all_objfiles.
11271         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11272         * printcmd.c (info_symbol_command): Use all_objfiles.
11273         * objfiles.h (ALL_OBJSECTIONS): Remove.
11274         * maint.c (maintenance_translate_address): Use all_objfiles.
11275         * gcore.c (gcore_create_callback): Use all_objfiles.
11276         (objfile_find_memory_regions): Likewise.
11277
11278 2019-01-09  Tom Tromey  <tom@tromey.com>
11279
11280         * symtab.c (find_line_symtab, info_sources_command)
11281         (make_source_files_completion_list): Use objfile_compunits.
11282         * source.c (select_source_symtab): Use objfile_compunits.
11283         * objfiles.h (struct objfile): Update comment.
11284         (ALL_OBJFILES): Remove.
11285         (ALL_FILETABS): Remove.
11286         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11287         objfile_compunits.
11288
11289 2019-01-09  Tom Tromey  <tom@tromey.com>
11290
11291         * symmisc.c (print_objfile_statistics, dump_objfile)
11292         (maintenance_print_symbols): Use compunit_filetabs.
11293         * source.c (forget_cached_source_info_for_objfile): Use
11294         compunit_filetabs.
11295         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11296         (ALL_FILETABS): Use compunit_filetabs.
11297         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11298         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11299
11300 2019-01-09  Tom Tromey  <tom@tromey.com>
11301
11302         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11303         (compunit_filetabs): New.
11304         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11305         compunit_filetabs.
11306         (info_sources_command, make_source_files_completion_list): Remove
11307         declaration.
11308         * symmisc.c (print_objfile_statistics, dump_objfile)
11309         (maintenance_print_symbols): Remove declaration.
11310         (maintenance_info_symtabs): Use compunit_filetabs.
11311         (maintenance_info_line_tables): Likewise.
11312         * source.c (select_source_symtab): Change local variable name.
11313         (forget_cached_source_info_for_objfile): Remove declaration.
11314         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11315         * objfiles.c (objfile_relocate1): Remove declaration.
11316         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11317         declaration.
11318         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11319         * coffread.c (coff_symtab_read): Remove declaration.
11320         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11321         compunit_filetabs.
11322
11323 2019-01-09  Tom Tromey  <tom@tromey.com>
11324
11325         * symtab.c (lookup_objfile_from_block)
11326         (find_pc_sect_compunit_symtab, search_symbols)
11327         (default_collect_symbol_completion_matches_break_on): Use
11328         objfile_compunits.
11329         * objfiles.h (ALL_COMPUNITS): Remove.
11330         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11331         * cp-support.c (add_symbol_overload_list_qualified): Use
11332         objfile_compunits.
11333         * ada-lang.c (ada_collect_symbol_completion_matches)
11334         (ada_add_global_exceptions): Use objfile_compunits.
11335
11336 2019-01-09  Tom Tromey  <tom@tromey.com>
11337
11338         * source.c (select_source_symtab)
11339         (forget_cached_source_info_for_objfile): Remove declaration.
11340         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11341         declaration.
11342         * maint.c (count_symtabs_and_blocks): Remove declaration.
11343         * cp-support.c (add_symbol_overload_list_qualified): Remove
11344         declaration.
11345         * coffread.c (coff_symtab_read): Remove declaration.
11346         * symtab.c (lookup_symbol_in_objfile_symtabs)
11347         (basic_lookup_transparent_type_1): Use objfile_compunits.
11348         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11349         (info_sources_command, search_symbols)
11350         (default_collect_symbol_completion_matches_break_on)
11351         (make_source_files_completion_list): Remove declaration.
11352         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11353         (ada_collect_symbol_completion_matches)
11354         (ada_add_global_exceptions): Remove declaration.
11355         * linespec.c (iterate_over_all_matching_symtabs): Use
11356         objfile_compunits.
11357         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11358         (class objfile_compunits): New.
11359         (ALL_COMPUNITS): Use objfile_compunits.
11360         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11361         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11362         objfile_compunits.
11363         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11364
11365 2019-01-09  Tom Tromey  <tom@tromey.com>
11366
11367         * symtab.c (search_symbols)
11368         (default_collect_symbol_completion_matches_break_on): Use
11369         objfile_msymbols.
11370         * ada-lang.c (ada_lookup_simple_minsym)
11371         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11372         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11373         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11374         objfile_msymbols.
11375         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11376         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11377         * objc-lang.c (find_methods): Use objfile_msymbols.
11378         (info_selectors_command, info_classes_command): Likewise.
11379         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11380         * objfiles.h (class objfile_msymbols): New.
11381         (ALL_OBJFILE_MSYMBOLS): Remove.
11382         (ALL_MSYMBOLS): Remove.
11383
11384 2019-01-09  Tom Tromey  <tom@tromey.com>
11385
11386         * common/next-iterator.h (next_adapter): Add Iterator template
11387         parameter.
11388         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11389         (class all_objfiles_safe): New.
11390         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11391         * objfiles.c (put_objfile_before): Update comment.
11392         (add_separate_debug_objfile): Likewise.
11393         (free_all_objfiles): Use all_objfiles_safe.
11394         (objfile_purge_solibs): Likewise.
11395
11396 2019-01-09  Tom Tromey  <tom@tromey.com>
11397
11398         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11399         (expand_symtab_containing_pc, lookup_static_symbol)
11400         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11401         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11402         all_objfiles.
11403         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11404         * breakpoint.c (create_overlay_event_breakpoint)
11405         (create_longjmp_master_breakpoint)
11406         (create_std_terminate_master_breakpoint)
11407         (create_exception_master_breakpoint): Use all_objfiles.
11408         * linux-thread-db.c (try_thread_db_load_from_pdir)
11409         (has_libpthread): Use all_objfiles.
11410         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11411         * linespec.c (iterate_over_all_matching_symtabs)
11412         (search_minsyms_for_name): Use all_objfiles.
11413         * maint.c (maintenance_info_sections): Use all_objfiles.
11414         * main.c (captured_main_1): Use all_objfiles.
11415         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11416         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11417         * guile/scm-pretty-print.c
11418         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11419         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11420         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11421         (maintenance_print_msymbols): Use all_objfiles.
11422         * source.c (select_source_symtab): Use all_objfiles.
11423         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11424         * symfile.c (remove_symbol_file_command)
11425         (expand_symtabs_matching, map_symbol_filenames): Use
11426         all_objfiles.
11427         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11428         all_objfiles.
11429         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11430         * objc-lang.c (find_methods): Use all_objfiles.
11431         * objfiles.c (have_partial_symbols, have_full_symbols)
11432         (have_minimal_symbols, qsort_cmp)
11433         (default_iterate_over_objfiles_in_search_order): Use
11434         all_objfiles.
11435         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11436         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11437         (maintenance_check_psymtabs): Use all_objfiles.
11438         (ALL_PSYMTABS): Remove.
11439         * compile/compile-object-run.c (do_module_cleanup): Use
11440         all_objfiles.
11441         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11442         * cp-support.c (add_symbol_overload_list_qualified): Use
11443         all_objfiles.
11444         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11445         Use all_objfiles.
11446         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11447         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11448         all_objfiles.
11449         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11450         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11451         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11452         Uses all_objfiles.
11453         * solib.c (solib_read_symbols): Use all_objfiles
11454
11455 2019-01-09  Tom Tromey  <tom@tromey.com>
11456
11457         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11458         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11459         all_objfiles.
11460         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11461         * symmisc.c (print_symbol_bcache_statistics)
11462         (print_objfile_statistics, maintenance_print_objfiles)
11463         (maintenance_info_symtabs, maintenance_check_symtabs)
11464         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11465         all_objfiles.
11466         * source.c (forget_cached_source_info): Use all_objfiles.
11467         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11468         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11469         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11470         * objfiles.c (update_section_map): Use all_objfiles.
11471         (shared_objfile_contains_address_p): Likewise.
11472         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11473         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11474
11475 2019-01-09  Tom Tromey  <tom@tromey.com>
11476
11477         * common/next-iterator.h: New file.
11478         * objfiles.h (class all_objfiles): New.
11479         (struct objfile_iterator): New.
11480
11481 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11482
11483         * NEWS: Move the description of the changed "frame", "select-frame",
11484          and "info frame" commands to the Changed commands section.
11485
11486 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11487
11488         * gdbtypes.c (check_stub_method_group): Remove handling of old
11489         mangling schemes.
11490         * linespec.c (find_methods): Likewise.
11491         * stabsread.c (read_member_functions): Likewise.
11492         * valops.c (search_struct_method): Likewise.
11493         (value_struct_elt_for_reference): Likewise.
11494         * NEWS: Mention this change.
11495
11496 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11497
11498         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11499         print_source_lines.
11500         * source.c (print_source_lines_base): Update line number check.
11501         (print_source_lines): New function.
11502         (source_lines_range::source_lines_range): New function.
11503         * source.h (class source_lines_range): New class.
11504         (print_source_lines): New declaration.
11505
11506 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11507
11508         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11509
11510 2019-01-08  Tom Tromey  <tom@tromey.com>
11511             Simon Marchi  <simon.marchi@ericsson.com>
11512
11513         PR gdb/24060
11514         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11515         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11516         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11517         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11518         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11519         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11520
11521 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11522
11523         * source.c (select_source_symtab): Move header comment to
11524         declaration in source.h.
11525         (forget_cached_source_info_for_objfile): Likewise.
11526         (forget_cached_source_info): Likewise.
11527         (identify_source_line): Likewise.
11528         * source.h (identify_source_line): Move declaration from symtab.h
11529         and add comment from source.c
11530         (print_source_lines): Likewise.
11531         (forget_cached_source_info_for_objfile): Likewise.
11532         (forget_cached_source_info): Likewise.
11533         (select_source_symtab): Likewise.
11534         (enum print_source_lines_flag): Move definition from symtab.h.
11535         * symtab.h (identify_source_line): Move declaration to source.h.
11536         (print_source_lines): Likewise.
11537         (forget_cached_source_info_for_objfile): Likewise.
11538         (forget_cached_source_info): Likewise.
11539         (select_source_symtab): Likewise.
11540         (enum print_source_lines_flag): Move definition to source.h.
11541         * tui/tui-hooks.c: Add 'source.h' include.
11542
11543 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11544
11545         * source.c (print_source_lines_base): Handle requests to print
11546         reverse line number sequences, and guard against empty lines
11547         string.
11548
11549 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11550
11551         * source.c (print_source_lines_base): Fix skip of '\r' if next
11552         character is '\n'.
11553
11554 2019-01-06  Tom Tromey  <tom@tromey.com>
11555
11556         * c-exp.y (struct c_parse_state) <macro_original_text,
11557         expansion_obstack>: New member.
11558         (macro_original_text, expansion_obstack): Remove globals.
11559         (scan_macro_expansion, scanning_macro_expansion)
11560         (finished_macro_expansion): Update.
11561         (scan_macro_cleanup): Remove.
11562         (yylex, c_parse): Update.
11563
11564 2019-01-06  Tom Tromey  <tom@tromey.com>
11565
11566         * c-exp.y (struct c_parse_state) <strings>: New member.
11567         (operator_stoken): Update.
11568
11569 2019-01-06  Tom Tromey  <tom@tromey.com>
11570
11571         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11572         (union type_stack_elt) <typelist_val>: Now a pointer to
11573         std::vector.
11574         (type_stack_cleanup): Don't declare.
11575         (push_typelist): Update.
11576         * parse.c (pop_typelist): Return a std::vector.
11577         (push_typelist): Take a std::vector.
11578         (follow_types): Update.  Do not free args.
11579         (type_stack_cleanup): Remove.
11580         * c-exp.y (struct c_parse_state): New.
11581         (cpstate): New global.
11582         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11583         (nonempty_typelist): Update.
11584         (func_mod): Create a new vector.
11585         (c_parse): Create a c_parse_state.
11586         (check_parameter_typelist): Do not delete params.
11587         (function_method): Update.  Do not delete type_list.
11588
11589 2019-01-06  Tom Tromey  <tom@tromey.com>
11590
11591         PR gdb/28155:
11592         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11593         check_typedef.
11594         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11595         (print_return_value): Likewise.
11596
11597 2019-01-05  Tom Tromey  <tom@tromey.com>
11598
11599         * contrib/cleanup_check.py: Remove.
11600         * contrib/gcc-with-excheck: Remove.
11601         * contrib/exsummary.py: Remove.
11602         * contrib/excheck.py: Remove.
11603
11604 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11605
11606         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11607         NULL. Initialize tpprev to NULL instead of assigning it
11608         to NULL on the next statement.
11609         * windows-nat.c (windows_delete_thread): Remove check for
11610         main_thread_id before printing thread exit notifications.
11611         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11612         Remove thread ID check against main_thread_id.
11613         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11614         windows_delete_thread.
11615         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11616
11617 2019-01-04  Tom Tromey  <tom@tromey.com>
11618
11619         * compile/compile.c (_initialize_compile): Use upper case for
11620         metasyntactic variables.
11621         * symmisc.c (_initialize_symmisc): Use upper case for
11622         metasyntactic variables.
11623         * psymtab.c (_initialize_psymtab): Use upper case for
11624         metasyntactic variables.
11625         * demangle.c (demangle_command): Use upper case for metasyntactic
11626         variables.
11627         (_initialize_demangler): Likewise.
11628         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11629         variables.
11630
11631 2019-01-03  Tom Tromey  <tom@tromey.com>
11632
11633         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11634
11635 2019-01-03  Tom Tromey  <tom@tromey.com>
11636
11637         * python/py-symtab.c (salpy_str): Update.
11638         (struct salpy_sal_object) <symtab>: Now a PyObject.
11639         (salpy_dealloc): Update.
11640         (del_objfile_sal): Use gdbpy_ref.
11641
11642 2019-01-03  Tom Tromey  <tom@tromey.com>
11643
11644         * python/py-type.c (convert_field): Use new_reference.  Return
11645         gdbpy_ref.
11646         (make_fielditem): Return gdbpy_ref.
11647         (typy_fields): Update.
11648         (typy_getitem): Update.
11649         (field_name): Return gdbpy_ref.  Use new_reference.
11650         (typy_iterator_iternext): Update.
11651
11652 2019-01-03  Tom Tromey  <tom@tromey.com>
11653
11654         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11655
11656 2019-01-03  Tom Tromey  <tom@tromey.com>
11657
11658         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11659         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11660         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11661         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11662         (pspy_set_type_printers): Likewise.
11663         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11664         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11665         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11666         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11667         (objfpy_set_type_printers): Likewise.
11668
11669 2019-01-03  Tom Tromey  <tom@tromey.com>
11670
11671         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11672         (gdbpy_print_stack): Use gdbpy_err_fetch.
11673         * python/python-internal.h (class gdbpy_err_fetch): New class.
11674         (class gdbpy_enter) <m_error_type, m_error_value,
11675         m_error_traceback>: Remove.
11676         <m_error>: New member.
11677         (gdbpy_exception_to_string): Don't declare.
11678         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11679         * python/py-value.c (convert_value_from_python): Use
11680         gdbpy_err_fetch.
11681         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11682         gdbpy_exception_to_string.
11683         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11684         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11685         gdbpy_err_fetch.
11686
11687 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11688
11689         * linux-nat.c (delete_lwp_cleanup): Delete.
11690         (struct lwp_deleter): New struct.
11691         (lwp_info_up): New typedef.
11692         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11693         lwp_info_up.
11694
11695 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11696
11697         * linux-fork.c (class scoped_switch_fork_info): New class.
11698         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11699
11700 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11701
11702         * valops.c (find_overload_match): Remove use of null_cleanup, and
11703         calls to do_cleanups.
11704
11705 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11706
11707         * compile/compile-cplus-types.c
11708         (compile_cplus_instance::decl_name): Handle changes to
11709         cp_func_name.
11710         * cp-support.c (cp_func_name): Update header comment, update
11711         return type.
11712         * cp-support.h (cp_func_name): Update return type in declaration.
11713         * valops.c (find_overload_match): Move temp_func local to top
11714         level of function and change its type.  Use temp_func to hold and
11715         delete temporary string obtained from cp_func_name.
11716
11717 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11718
11719         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11720         gdb::char_vector, remove cleanup, and update uses of `msg`.
11721
11722 2019-01-03  Jim Wilson  <jimw@sifive.com>
11723
11724         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11725
11726 2019-01-02  Tom Tromey  <tom@tromey.com>
11727
11728         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11729         (tdesc_parse_xml): Remove cleanups.
11730         * target-descriptions.h (make_cleanup_free_target_description):
11731         Don't declare.
11732         (target_desc_deleter): New struct.
11733         (target_desc_up): New typedef.
11734         * target-descriptions.c (target_desc_deleter::operator()): Rename
11735         from free_target_description.
11736         (make_cleanup_free_target_description): Remove.
11737
11738 2019-01-02  Tom Tromey  <tom@tromey.com>
11739
11740         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11741         constructor, destructor.
11742         (linespec_parser): Remove typedef.
11743         (~linespec_parser): Rename from linespec_parser_delete.
11744         (linespec_lex_to_end, linespec_complete_label)
11745         (linespec_complete): Update.
11746         (decode_line_full): Remove cleanups.
11747         (decode_line_1): Update.
11748
11749 2019-01-02  Tom Tromey  <tom@tromey.com>
11750
11751         * python/python-internal.h (inferior_to_inferior_object): Change
11752         return type.
11753         * python/py-exitedevent.c (create_exited_event_object): Update.
11754         * python/py-inferior.c (inferior_to_inferior_object): Return
11755         gdbpy_ref.
11756         (python_new_inferior, python_inferior_deleted)
11757         (thread_to_thread_object, delete_thread_object)
11758         (build_inferior_list, gdbpy_selected_inferior): Update.
11759         * python/py-infthread.c (create_thread_object): Update.  Also fail
11760         if inferior_to_inferior_object fails.
11761
11762 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11763
11764         * inferior.h (class inferior) <displaced_step_state>: New field.
11765         * infrun.h (struct displaced_step_state): Move here from
11766         infrun.c.  Initialize fields, add constructor.
11767         <inf>: Remove field.
11768         <reset>: New method.
11769         * infrun.c (struct displaced_step_inferior_state): Move to
11770         infrun.h.
11771         (displaced_step_inferior_states): Remove.
11772         (get_displaced_stepping_state): Adust.
11773         (displaced_step_in_progress_any_inferior): Adjust.
11774         (displaced_step_in_progress_thread): Adjust.
11775         (displaced_step_in_progress): Adjust.
11776         (add_displaced_stepping_state): Remove.
11777         (get_displaced_step_closure_by_addr): Adjust.
11778         (remove_displaced_stepping_state): Remove.
11779         (infrun_inferior_exit): Call displaced_step_state.reset.
11780         (use_displaced_stepping): Don't check for NULL.
11781         (displaced_step_prepare_throw): Call
11782         get_displaced_stepping_state.
11783         (displaced_step_fixup): Don't check for NULL.
11784         (prepare_for_detach): Don't check for NULL.
11785
11786 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11787
11788         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11789          in case of call that did not complete.
11790
11791 2019-01-02  Andrey Utkin  <autkin@undo.io>
11792
11793         * symfile.c (find_separate_debug_file): Fix search of debug files for
11794         remote debuggee.
11795
11796 2019-01-02  Tom Tromey  <tom@tromey.com>
11797
11798         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11799         indentation.
11800         * python/py-frame.c (frapy_older): Remove cast.
11801         (frapy_newer): Likewise.
11802         * python/py-breakpoint.c (local_setattro): Remove cast.
11803         * python/py-arch.c (archpy_name): Remove local variable.
11804         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11805
11806 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11807
11808         * unittests/basic_string_view/element_access/char/empty.cc:
11809         Fix year range in copyright header.
11810
11811 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11812
11813         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11814         Delete.
11815         <operator==>: Update with for removed field.
11816         <hash>: Likewise.
11817         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11818         <isa_features>: ...this.
11819         <abi_features>: New field.
11820         (riscv_isa_flen): Update comment.
11821         (riscv_abi_xlen): New declaration.
11822         (riscv_abi_flen): New declaration.
11823         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11824         isa_features.
11825         (riscv_abi_xlen): New function.
11826         (riscv_isa_flen): Update to get answer from isa_features.
11827         (riscv_abi_flen): New function.
11828         (riscv_has_fp_abi): Update to get answer from abi_features.
11829         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11830         xlen and flen.
11831         (riscv_call_info) <xlen, flen>: Update comment.
11832         (riscv_call_arg_struct): Remove invalid assertions
11833         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11834         is removed.
11835         (riscv_gdbarch_init): Gather isa features and abi features
11836         separately, ensure both match on the gdbarch when reusing an old
11837         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11838         a target with 64-bit float hardware.
11839
11840 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11841
11842         * source.c (search_command_helper): Stop reverse search
11843         when line 1 has been searched.
11844
11845 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11846
11847         * record-full.c (record_full_base_target::close): Rewrite
11848         record_full_core_buf_list free logic.
11849
11850 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11851
11852         * break-catch-syscall.c (print_one_catch_syscall): xfree
11853         the last text.
11854
11855 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11856
11857         * top.c (print_gdb_version): Update Copyright year in version
11858         message.
11859
11860 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11861
11862         Update copyright year range in all GDB files.
11863
11864 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11865
11866         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11867
11868 For older changes see ChangeLog-2018.
11869 \f
11870 Local Variables:
11871 mode: change-log
11872 left-margin: 8
11873 fill-column: 74
11874 version-control: never
11875 coding: utf-8
11876 End:
11877