gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * frame.c: Include "cli/cli-option.h.
   4         (user_set_backtrace_options): New.
   5         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
   6         Delete.
   7         (get_prev_frame): Adjust.
   8         (boolean_option_def, uinteger_option_def)
   9         (set_backtrace_option_defs): New.
  10         (_initialize_frame): Adjust and use
  11         gdb::option::add_setshow_cmds_for_options to install "set
  12         backtrace past-main" and "set backtrace past-entry".
  13         * frame.h: Include "cli/cli-option.h".
  14         (struct frame_print_options): Forward declare.
  15         (print_frame_arguments_all, print_frame_arguments_scalars)
  16         (print_frame_arguments_none): Declare.
  17         (print_entry_values): Delete declaration.
  18         (struct frame_print_options, user_frame_print_options): New.
  19         (struct set_backtrace_options): New.
  20         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  21         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
  22         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
  23         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
  24         (list_args_or_locals): Add frame_print_options parameter.
  25         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  26         * python/py-framefilter.c (enumerate_args): Pass down
  27         USER_FRAME_PRINT_OPTIONS.
  28         * stack.c: Include "cli/cli-option.h".
  29         (print_frame_arguments_all, print_frame_arguments_scalars)
  30         (print_frame_arguments_none): Declare.
  31         (print_raw_frame_arguments, print_entry_values): Delete.
  32         (user_frame_print_options): New.
  33         (boolean_option_def, enum_option_def, frame_print_option_defs):
  34         New.
  35         (struct backtrace_cmd_options): New.
  36         (bt_flag_option_def): New.
  37         (backtrace_command_option_defs): New.
  38         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  39         (print_frame_arg, read_frame_arg, print_frame_args)
  40         (print_frame_info, print_frame): Add frame_print_options parameter
  41         and use it.
  42         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
  43         (backtrace_command_1): Add frame_print_options and
  44         backtrace_cmd_options parameters and use them.
  45         (make_backtrace_options_def_group): New.
  46         (backtrace_command): Process command options with
  47         gdb::option::process_options.
  48         (backtrace_command_completer): New.
  49         (_initialize_stack): Extend "backtrace"'s help to mention
  50         supported options.  Install completer for "backtrace".
  51         Install some settings commands with add_setshow_cmds_for_options.
  52
  53 2019-06-13  Pedro Alves  <palves@redhat.com>
  54
  55         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
  56         and that "set/show print raw frame-arguments" are now deprecated.
  57
  58         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
  59         command.
  60         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
  61         * stack.c (_initialize_stack): Install "set/show print
  62         raw-frame-arguments", and deprecate "set/show print raw
  63         frame-arguments".
  64         * valprint.c (_initialize_valprint): Deprecate "set/show print
  65         raw".
  66
  67 2019-06-13  Pedro Alves  <palves@redhat.com>
  68
  69         * compile/compile.c (struct compile_options): New.
  70         (compile_flag_option_def, compile_command_option_defs)
  71         (make_compile_options_def_group): New.
  72         (compile_file_command): Handle options with
  73         gdb::option::process_options.
  74         (compile_file_command_completer): New function.
  75         (compile_code_command): Handle options with
  76         gdb::option::process_options.
  77         (compile_code_command_completer): New function.
  78         (_initialize_compiler): Install completers for "compile code" and
  79         "compile file".  Mention available options in "compile code" and
  80         "compile code"'s help.
  81         * completer.c (advance_to_completion_word): New, factored out from
  82         ...
  83         (advance_to_expression_complete_word_point): ... this.
  84         (advance_to_filename_complete_word_point): New.
  85         * completer.h (advance_to_filename_complete_word_point): New
  86         declaration.
  87
  88 2019-06-13  Pedro Alves  <palves@redhat.com>
  89
  90         * compile/compile.c: Include "cli/cli-option.h".
  91         (compile_print_value): Scope data pointer is now a
  92         value_print_options pointer; adjust.
  93         (compile_print_command): Process options.  Scope data pointer is
  94         now a value_print_options pointer; adjust.
  95         (_initialize_compile): Update "compile print"'s help to include
  96         supported options.  Install a completer for "compile print".
  97         * cp-valprint.c (show_vtblprint, show_objectprint)
  98         (show_static_field_print): Delete.
  99         (_initialize_cp_valprint): Don't install "set print
 100         static-members", "set print vtbl", "set print object" here.
 101         * printcmd.c: Include "cli/cli-option.h" and
 102         "common/gdb_optional.h".
 103         (print_command_parse_format): Rework to fill in a
 104         value_print_options instead of a format_data.
 105         (print_value): Change parameter type from format_data pointer to
 106         value_print_options reference.  Adjust.
 107         (print_command_1): Process options.  Adjust to pass down a
 108         value_print_options.
 109         (print_command_completer): New.
 110         (_initialize_printcmd): Install print_command_completer as
 111         handle_brkchars completer for the "print" command.  Update
 112         "print"'s help to include supported options.
 113         * valprint.c: Include "cli/cli-option.h".
 114         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 115         here from cp-valprint.c.
 116         (boolean_option_def, uinteger_option_def)
 117         (value_print_option_defs, make_value_print_options_def_group):
 118         New.  Use gdb::option::add_setshow_cmds_for_options to install
 119         "set print elements", "set print null-stop", "set print repeats",
 120         "set print pretty", "set print union", "set print array", "set
 121         print address", "set print symbol", "set print array-indexes".
 122         * valprint.h: Include <string> and "cli/cli-option.h".
 123         (make_value_print_options_def_group): Declare.
 124         (print_value): Change parameter type from format_data pointer to
 125         value_print_options reference.
 126         (print_command_completer): Declare.
 127
 128 2019-06-13  Pedro Alves  <palves@redhat.com>
 129
 130         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 131         (COMMON_SFILES): Add maint-test-settings.c.
 132         * cli/cli-decode.c (boolean_enums): New global, factored out from
 133         ...
 134         (add_setshow_boolean_cmd): ... here.
 135         * cli/cli-decode.h (boolean_enums): Declare.
 136         * cli/cli-option.c: New file.
 137         * cli/cli-option.h: New file.
 138         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 139         factored out from ...
 140         (parse_cli_boolean_value(const char *)): ... this.
 141         (is_unlimited_literal): Change parameter type to pointer to
 142         pointer.  Adjust and advance ARG pointer.
 143         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 144         (parse_cli_var_enum): New, factored out from ...
 145         (do_set_command): ... this.  Adjust.
 146         * cli/cli-setshow.h (parse_cli_boolean_value)
 147         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 148         (parse_cli_var_enum): Declare.
 149         * cli/cli-utils.c: Include "cli/cli-option.h".
 150         (get_ulongest): New.
 151         * cli/cli-utils.h (get_ulongest): Declare.
 152         (check_for_argument): New overloads.
 153         * maint-test-options.c: New file.
 154
 155 2019-06-13  Pedro Alves  <palves@redhat.com>
 156
 157         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 158         parse a range if "-" is at the end of the string.
 159
 160 2019-06-13  Pedro Alves  <palves@redhat.com>
 161
 162         * cli/cli-setshow.c (parse_auto_binary_operation)
 163         (parse_cli_boolean_value): Don't allow "o".
 164
 165 2019-06-13  Pedro Alves  <palves@redhat.com>
 166
 167         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 168         * NEWS: Mention maint test-settings KIND.
 169         * maint-test-settings.c: New file.
 170
 171 2019-06-13  Pedro Alves  <palves@redhat.com>
 172
 173         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 174         completer.
 175         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 176         "set" completers.
 177
 178 2019-06-13  Pedro Alves  <palves@redhat.com>
 179
 180         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 181         after item.
 182
 183 2019-06-13  Pedro Alves  <palves@redhat.com>
 184
 185         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 186
 187 2019-06-13  Pedro Alves <palves@redhat.com>
 188
 189         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 190         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 191         call.
 192         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 193         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 194         calls.
 195         (check_for_argument): Skip spaces after argument.
 196
 197 2019-06-13  Pedro Alves  <palves@redhat.com>
 198
 199         * thread.c (thread_apply_command): Adjust TID parsing.
 200         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 201         detected before end of string.
 202         (tid_is_in_list): Error out if LIST is invalid.
 203
 204 2019-06-13  Pedro Alves  <palves@redhat.com>
 205
 206         * completer.c (complete_line_internal_1): Rewind completion word
 207         point.
 208         (completion_tracker::advance_custom_word_point_by): Change
 209         parameter type to int.
 210         * completer.h (completion_tracker::advance_custom_word_point_by):
 211         Likewise.
 212
 213 2019-06-13  Pedro Alves  <palves@redhat.com>
 214
 215         * completer.c (advance_to_completion_word): Handle delimiters.
 216
 217 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 218
 219         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 220
 221 2019-06-11  Tom Tromey  <tom@tromey.com>
 222
 223         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 224         (xmalloc_failed): Move to alloc.c.
 225         * alloc.c: New file.
 226         * Makefile.in (COMMON_SFILES): Add alloc.c.
 227
 228 2019-06-11  Tom Tromey  <tom@tromey.com>
 229
 230         * nat/linux-waitpid.c: Don't include server.h.
 231         (linux_debug): Remove.
 232         (my_waitpid): Update.
 233
 234 2019-06-11  Tom Tromey  <tromey@adacore.com>
 235
 236         * infcall.c (_initialize_infcall): Remove trailing newline from
 237         help.
 238         * user-regs.c (_initialize_user_regs): Remove trailing newline
 239         from help.
 240         * typeprint.c (_initialize_typeprint): Remove trailing newline
 241         from help.
 242         * reverse.c (_initialize_reverse): Remove trailing newlines from
 243         help.
 244         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 245         from help.
 246         * language.c (add_set_language_command): Remove trailing newline
 247         from help.
 248         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 249         help.
 250         * disasm.c (_initialize_disasm): Remove trailing newline from
 251         help.
 252         * top.c (init_main): Remove trailing newline from help.
 253         * interps.c (_initialize_interpreter): Remove trailing newline
 254         from help.
 255         * btrace.c (_initialize_btrace): Remove trailing newlines from
 256         help.
 257         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 258         from help.
 259         * python/python.c (_initialize_python): Remove trailing newline
 260         from help.
 261         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 262         help.
 263         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 264         from help.  Reformat some text.
 265         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 266         from help.
 267         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 268         newline from help.
 269
 270 2019-06-11  Tom Tromey  <tromey@adacore.com>
 271
 272         * darwin-nat.c (darwin_decode_exception_message)
 273         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 274
 275 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * valops.c (value_slice): Check for not allocated or not
 278         associated values.
 279
 280 2019-06-10  Tom de Vries  <tdevries@suse.de>
 281
 282         PR gdb/24618
 283         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 284         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 285         invalid.
 286
 287 2019-06-10  Tom de Vries  <tdevries@suse.de>
 288
 289         PR gdb/24611
 290         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 291         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 292
 293 2019-06-10  Tom de Vries  <tdevries@suse.de>
 294
 295         PR symtab/24545
 296         * symtab.c (struct demangled_name_entry): Add language field.
 297         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 298         static minimal symbol".  Set and use language field.
 299
 300 2019-06-10  Tom Tromey  <tromey@adacore.com>
 301
 302         * ada-lang.c (_initialize_ada_language): Update help text.
 303
 304 2019-06-10  Tom Tromey  <tromey@adacore.com>
 305
 306         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 307         with a newline.
 308         * guile/guile.c (handle_boot_error): Don't end warning with a
 309         newline.
 310         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 311         warning with a newline.
 312         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 313         newline.
 314         (s12z_frame_cache): Likewise.
 315         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 316         a newline.
 317         * solib-svr4.c (disable_probes_interface): Don't end warning with
 318         a newline.
 319         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 320         newline.
 321         * python/python.c (do_finish_initialization): Don't end warning
 322         with a newline.
 323
 324 2019-06-10  Tom Tromey  <tom@tromey.com>
 325
 326         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 327         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 328         gdbpy_enter.
 329
 330 2019-06-10  Tom Tromey  <tromey@adacore.com>
 331
 332         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 333         data.
 334         (elf_new_init): Don't call stabsread_new_init.
 335         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 336         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 337         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 338
 339 2019-06-10  Tom de Vries  <tdevries@suse.de>
 340
 341         PR symtab/16264
 342         PR symtab/24517
 343         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 344
 345 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 346
 347         * source.c (find_and_open_source): Also rewrite relative file
 348         names.
 349
 350 2019-04-26  Amos Bird  <amosbird@gmail.com>
 351
 352         * annotate.c (annotate_thread_exited): Add "thread-exited"
 353         annotation.
 354
 355 2019-06-06  Tom Tromey  <tromey@adacore.com>
 356
 357         * maint.h (class scoped_command_stats): Use
 358         DISABLE_COPY_AND_ASSIGN.
 359         <print_time>: New method.
 360         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 361         print_time.
 362         (scoped_command_stats::print_time): New method.
 363
 364 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 367         instructions of lengths 6 or 8 bytes.
 368
 369 2019-06-04  Pedro Alves  <palves@redhat.com>
 370
 371         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 372
 373         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 374         * breakpoint.c (condition_completer): Likewise.
 375         * cli/cli-dump.c (scan_expression): Likewise.
 376         * common/filestuff.c (mkdir_recursive): Likewise.
 377         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 378         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 379         (gdb_abspath): Likewise.
 380         * compile/compile-cplus-types.c
 381         (compile_cplus_instance::decl_name): Likewise.
 382         * completer.c (complete_explicit_location):
 383         (signal_completer, reg_or_group_completer_1): Likewise.
 384         * cp-support.c (cp_remove_params_if_any): Likewise.
 385         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 386         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 387         * infcmd.c (strip_bg_char): Likewise.
 388         * linespec.c (copy_token_string): Likewise.
 389         * mi/mi-main.c (output_cores): Likewise.
 390         * psymtab.c (psymtab_search_name):
 391         * symfile.c (test_set_ext_lang_command): Likewise.
 392         * target.c (target_fileio_read_stralloc): Likewise.
 393         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 394         * value.c (complete_internalvar): Likewise.
 395
 396 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 397
 398         Add objfile property to gdb.Type.
 399         * NEWS: Mention Python API addition.
 400         * python/py-type.c (typy_get_objfile): New method.
 401
 402 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 403
 404         * NEWS: Mention the new set|show style [title|highlight].
 405         Mention changes to "show style", "help" and "apropos".
 406
 407 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 408
 409         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 410         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 411         instead of print_help_for_command.
 412         (print_doc_of_command): New function.
 413         (help_list): Add 'apropos -v word' suggestion.
 414         (print_help_for_command): Style the command name using title style.
 415         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 416         (_initialize_cli_cmds): Describe -v in apropos_command help.
 417
 418 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 419
 420         * cli/cli-style.h (cli_style_option): Add name in constructor,
 421         add m_name class member, add constructor with intensity,
 422         add name class function.
 423         (cli_style_option::add_setshow_commands): Remove name argument.
 424         (highlight_style, title_style): New styles.
 425         * cli/cli-style.c (do_show): New function that shows a style
 426         characteristic styling the style name with itself.
 427         (set_style_name): New function.
 428         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 429         Update all callers according to the changes in cli/cli-style.h.
 430         * utils.h (fputs_highlighted): New function.
 431         * utils.c (fputs_highlighted): Likewise.
 432
 433 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 434
 435         * NEWS: Mention new pipe command and new convenience variables.
 436
 437 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 438
 439         * cli/cli-cmds.c (pipe_command): New function.
 440         (_initialize_cli_cmds): Call add_com for pipe_command.
 441         Define | as an alias for pipe.
 442         (exit_status_set_internal_vars): New function.
 443         (shell_escape): Call exit_status_set_internal_vars.
 444         cli/cli-decode.c (find_command_name_length): Recognize | as
 445         a single character command.
 446
 447 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 448
 449         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 450         top.c (execute_command_to_ui_file): New function, mostly a copy
 451         of execute_command_to_string.
 452         (execute_command_to_string): Implement by calling
 453         execute_command_to_ui_file.
 454
 455 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 456
 457         * top.h (saved_command_line): Remove declaration.
 458         * top.c (previous_saved_command_line, previous_repeat_arguments):
 459         New variables.
 460         (saved_command_line): Make static, define together with other
 461         'repeat variables'.
 462         (dont_repeat): Clear repeat_arguments.
 463         (repeat_previous, get_saved_command_line, save_command_line):
 464         New functions.
 465         (gdb_init): Initialize saved_command_line
 466         and previous_saved_command_line.
 467         * main.c (captured_main_1): Remove saved_command_line initialization.
 468         * event-top.c (handle_line_of_input): Update to use
 469         the new 'repeat' related functions instead of direct access to
 470         saved_command_line.
 471         * command.h (repeat_previous, get_saved_command_line,
 472         save_command_line): New declarations.
 473         (dont_repeat): Add comment.
 474
 475 2019-05-30  Tom Tromey  <tromey@adacore.com>
 476
 477         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 478         Fix comment.
 479         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 480
 481 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 482
 483         PR cli/24587
 484         * completer.c (complete): Initialize variable word.
 485
 486 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 487
 488         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 489         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 490         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 491         'body' is NULL to the outter 'if', protecting the '!is_define'
 492         situation as well.
 493
 494 2019-05-29  Tom Tromey  <tromey@adacore.com>
 495
 496         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 497         (dwarf_unknown): New function.
 498         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 499         (dwarf_type_encoding_name): Use dwarf_unknown.
 500
 501 2019-05-29  Tom Tromey  <tromey@adacore.com>
 502
 503         PR c++/20020:
 504         * cp-valprint.c (cp_print_value_fields): Call
 505         cp_print_static_field inside "try".
 506
 507 2019-05-29  Tom Tromey  <tromey@adacore.com>
 508
 509         * inflow.c (struct terminal_info): Add default operator=.
 510         * configure: Rebuild.
 511         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 512         -Wdeprecated-copy-dtor, -Wredundant-move.
 513
 514 2019-05-29  Tom Tromey  <tromey@adacore.com>
 515
 516         * NEWS: Add entry.
 517         * infcmd.c (print_return_value_1): Handle finish_print
 518         option.
 519         (show_print_finish): New function.
 520         (_initialize_infcmd): Add "set/show print finish" commands.
 521         * valprint.c (user_print_options): Initialize new member.
 522         * valprint.h (struct value_print_options) <finish_print>: New
 523         member.
 524
 525 2019-05-28  Tom Tromey  <tromey@adacore.com>
 526
 527         * ada-lang.c (ada_remove_Xbn_suffix)
 528         (find_old_style_renaming_symbol)
 529         (parse_old_style_renaming): Remove.
 530         (ada_find_renaming_symbol): Don't call
 531         find_old_style_renaming_symbol.
 532         (ada_is_renaming_symbol): Rename from
 533         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 534         bool.  Now static.
 535         (ada_read_var_value): Update and simplify.
 536         * ada-exp.y (write_var_or_type): Remove old code.
 537
 538 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 539
 540         * event-top.c: Remove include comment.
 541         * inflow.c (class scoped_ignore_sigttou): Move from here...
 542         * inflow.h (class scoped_ignore_sigttou): ...to here.
 543         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 544         * top.c:  Remove include comment.
 545
 546 2019-05-27  Tom Tromey  <tom@tromey.com>
 547
 548         * NEWS: Fix typo.
 549
 550 2019-05-22  Tom Tromey  <tromey@adacore.com>
 551
 552         * target.c (target_follow_exec): Constify parameter.
 553         * target-delegates.c: Rebuild.
 554         * remote.c (remote_target::follow_exec): Constify parameter.
 555         * infrun.c (follow_exec): Constify parameter.
 556         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 557         (target_follow_exec): Likewise.
 558
 559 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 560
 561         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 562         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 563
 564 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 565
 566         * NEWS: Add debugredirect and testsuite sections.
 567
 568 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 569
 570         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 571         target descriptions using exclusively floating point register name
 572         aliases.
 573
 574 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         PR gdb/18644:
 577         * f-lang.c (build_fortran_types): Handle the case where
 578         gdbarch_floatformat_for_type returns a nullptr.
 579
 580 2019-05-21  Tom de Vries  <tdevries@suse.de>
 581
 582         PR cli/24587
 583         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 584
 585 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         PR gdb/18644:
 588         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 589         16-byte floats.
 590         * i386-tdep.c (i386_floatformat_for_type): Use
 591         floatformats_ia64_quad for the 16-byte floating point component
 592         within a fortran 32-byte complex number.
 593
 594 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 597         delete default constructor.
 598         (find_partial_die): Update to return const struct.
 599         (partial_die_parent_scope): Move variable declaration into scope
 600         of its use and change its type to auto.
 601         (guess_partial_die_structure_name): Likewise.
 602         (partial_die_info::fixup): Likewise.
 603
 604 2019-05-17  Tom Tromey  <tromey@adacore.com>
 605
 606         * source.c (find_and_open_source): Remove cast.
 607
 608 2019-05-17  Tom Tromey  <tromey@adacore.com>
 609
 610         * annotate.c (annotate_source): Make "filename" const.
 611         * annotate.h (annotate_source): Use const.
 612
 613 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 614
 615         * disasm.c (set_disassembler_options): Send errors to stderr.
 616
 617 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 618
 619         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 620         (cli_interp_base::set_logging): Check debug_redirect.
 621         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 622         * cli/cli-logging.c (debug_redirect): Add static variable.
 623         (pop_output_files): Add default param.
 624         (handle_redirections): Print debug setting.
 625         (show_logging_command): Likewise.
 626         (_initialize_cli_logging): Add debugredirect command.
 627         * interps.c (current_interp_set_logging): Add debug_redirect
 628         parameter.
 629         * interps.h (set_logging): Add debug_redirect parameter.
 630         (current_interp_set_logging): Likewise.
 631         * mi/mi-common.h: Likewise.
 632         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 633
 634 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 635             Tom Tromey  <tromey@adacore.com>
 636
 637         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 638         directly.
 639         * cli/cli-interp.h (make_logging_output): Remove declaration.
 640         * cli/cli-logging.c (make_logging_output): Remove function.
 641         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 642         directly.
 643         * ui-file.c (tee_file::tee_file): Remove bools.
 644         (tee_file::~tee_file): Remove deletes.
 645         * ui-file.h (tee_file): Remove bools.
 646
 647 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 648
 649         * mi/mi-cmds.h (mi_cmd_complete): New function.
 650         * mi/mi-main.c (mi_cmd_complete): Likewise.
 651         * mi/mi-cmds.c: Define new MI command -complete.
 652         * NEWS: Mention new -complete command.
 653
 654 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 655
 656         * completer.h (complete): New function.
 657         * completer.c (complete): Likewise.
 658         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 659         function defined in completer.h.
 660
 661 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 662
 663        * MAINTAINERS (Write After Approval): Add myself.
 664
 665 2019-05-17  Tom de Vries  <tdevries@suse.de>
 666
 667         PR gdb/24094
 668         * dwarf2read.c (struct cu_partial_die_info): New struct.
 669         (find_partial_die): Return cu_partial_die_info.
 670         (partial_die_parent_scope, guess_partial_die_structure_name)
 671         (partial_die_info::fixup): Handle new return type of find_partial_die.
 672
 673 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 674
 675         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 676         "std::string", simplifying the algorithm.
 677
 678 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 679
 680         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 681         (stap_static_probe_ops::get_probes): Likewise.
 682
 683 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 684
 685         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 686         '-')" and "else if".
 687         (stap_parse_single_operand): Join checks for
 688         "gdbarch_stap_parse_special_token_p" and
 689         "gdbarch_stap_parse_special_token" in the same "if" statement.
 690         Invert check when verifying for operation on register
 691         displacement.
 692
 693 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 694
 695         * stap-probe.c (stap_get_opcode): Update comment.
 696         (stap_get_expected_argument_type): Likewise.
 697         (handle_stap_probe): Likewise.
 698
 699 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 700
 701         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 702         return type to 'bool'.  Adjust comment.  Use 'bool' when
 703         appropriate.
 704         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 705         * stap-probe.c (stap_parse_argument_1): Likewise.
 706         (stap_is_operator): Likewise.
 707         (stap_is_generic_prefix): Likewise.
 708         (stap_is_register_prefix): Likewise.
 709         (stap_is_register_indirection_prefix): Likewise.
 710         (stap_is_integer_prefix): Likewise.
 711         (stap_generic_check_suffix): Likewise.
 712         (stap_check_integer_suffix): Likewise.
 713         (stap_check_register_suffix): Likewise.
 714         (stap_check_register_indirection_suffix): Likewise.
 715         (stap_parse_register_operand): Likewise.
 716         (stap_parse_single_operand): Likewise.
 717         (stap_parse_argument_1): Likewise.
 718         (stap_probe::get_argument_count): Likewise.
 719         (stap_is_operator): Likewise.
 720
 721 2019-05-16  Tom Tromey  <tromey@adacore.com>
 722
 723         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 724         keyword to foreach.
 725
 726 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 727
 728         * linux-thread-db.c (try_thread_db_load_1): Change return type
 729         to bool.
 730         (try_thread_db_load): Likewise.
 731         (try_thread_db_load_from_pdir_1): Likewise.
 732         (try_thread_db_load_from_pdir): Likewise.
 733         (try_thread_db_load_from_sdir): Likewise.
 734         (try_thread_db_load_from_dir): Likewise.
 735         (thread_db_load_search): Likewise.
 736         (has_libpthread): Likewise.
 737         (thread_db_load): Likewise.
 738
 739 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 740
 741         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 742         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 743         NULL, and complain/return if that's the case.
 744
 745 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 746
 747         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 748         (advance, posn, abstract_read_memory): New functions.
 749         [struct mem_read_abstraction]: New struct.
 750         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 751
 752 2019-05-14  Tom Tromey  <tromey@adacore.com>
 753
 754         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 755         value is not lval_memory.
 756
 757 2019-05-14  Tom Tromey  <tromey@adacore.com>
 758
 759         * solib.c (info_sharedlibrary_command): Style the file name.
 760
 761 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 762
 763         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 764         (aarch64_vnv_type): Likewise.
 765         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 766         * common/tdesc.c: Likewise.
 767         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 768         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 769         * features/aarch64-fpu.xml: Add ieee half view.
 770         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 771         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 772         * gdbtypes.h (struct builtin_type): Likewise.
 773         (struct objfile_type): Likewise.
 774
 775 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 776
 777         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 778         typo.
 779         * location.h (string_to_event_location): Likewise.
 780
 781 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 782
 783         GDB 8.3 released.
 784
 785 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 786
 787         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 788         New variable declaration.
 789         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 790         New variable.
 791         (print_one_breakpoint): Use ui_out::test_flags and new global
 792         variable to compute use_fixed_output.
 793         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 794         Remove.
 795         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 796         (mi_multi_location_breakpoint_output_fixed): Remove.
 797         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 798         new variable.
 799         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 800         fix_multi_location_breakpoint_output flag if version >= 3.
 801         * ui-out.h (enum ui_out_flag)
 802         <fix_multi_location_breakpoint_output>: New enumerator.
 803
 804 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 805
 806         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 807
 808 2019-05-10  Tom Tromey  <tromey@adacore.com>
 809
 810         * ada-lang.c (catch_ada_completer): New function.
 811         (_initialize_ada_language): Use it.
 812
 813 2019-05-10  Tom Tromey  <tromey@adacore.com>
 814
 815         * thread.c (print_thread_info): Make "requested_threads" const.
 816         * gdbthread.h (print_thread_info): Make "requested_threads"
 817         const.
 818         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 819         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 820
 821 2019-05-08  Tom Tromey  <tom@tromey.com>
 822
 823         * gdbtypes.c (objfile_type_data): Change type.
 824         (objfile_type, _initialize_gdbtypes): Update.
 825
 826 2019-05-08  Tom Tromey  <tom@tromey.com>
 827
 828         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 829         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 830         (_initialize_dwarf2_frame): Update.
 831
 832 2019-05-08  Tom Tromey  <tom@tromey.com>
 833
 834         * objc-lang.c (objc_objfile_data): Change type.
 835         (find_methods): Update.
 836         (_initialize_objc_lang): Remove.
 837
 838 2019-05-08  Tom Tromey  <tom@tromey.com>
 839
 840         * stabsread.c (rs6000_builtin_type_data): Change type.
 841         (rs6000_builtin_type, _initialize_stabsread): Update.
 842
 843 2019-05-08  Tom Tromey  <tom@tromey.com>
 844
 845         * mips-tdep.c (mips_pdr_data): Remove.
 846         (_initialize_mips_tdep): Update.
 847
 848 2019-05-08  Tom Tromey  <tom@tromey.com>
 849
 850         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 851         (hppa_init_objfile_priv_data, read_unwind_info)
 852         (find_unwind_entry, _initialize_hppa_tdep): Update.
 853
 854 2019-05-08  Tom Tromey  <tom@tromey.com>
 855
 856         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 857         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 858         on obstack.
 859         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 860
 861 2019-05-08  Tom Tromey  <tom@tromey.com>
 862
 863         * mdebugread.c (basic_type_data): Change type.
 864         (basic_type, _initialize_mdebugread): Update.
 865
 866 2019-05-08  Tom Tromey  <tom@tromey.com>
 867
 868         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 869
 870 2019-05-08  Tom Tromey  <tom@tromey.com>
 871
 872         * nto-tdep.c (nto_inferior_data_reg): Change type.
 873         (nto_inferior_data): Update.
 874         (nto_inferior_data_cleanup, nto_new_inferior_data)
 875         (_initialize_nto_tdep): Remove.
 876         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 877
 878 2019-05-08  Tom Tromey  <tom@tromey.com>
 879
 880         * ada-lang.c (struct ada_inferior_data): Add initializers.
 881         (ada_inferior_data): Change type.
 882         (ada_inferior_data_cleanup): Remove.
 883         (get_ada_inferior_data, ada_inferior_exit)
 884         (struct ada_pspace_data): Add initializers, destructor.
 885         (ada_pspace_data_handle): Change type.
 886         (get_ada_pspace_data): Update.
 887         (ada_pspace_data_cleanup): Remove.
 888
 889 2019-05-08  Tom Tromey  <tom@tromey.com>
 890
 891         * coffread.c (struct coff_symfile_info): Add initializers.
 892         (coff_objfile_data_key): Move lower.  Change type.
 893         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 894         Update.
 895         (coff_free_info): Remove.
 896
 897 2019-05-08  Tom Tromey  <tom@tromey.com>
 898
 899         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 900         (fbsd_pspace_data_handle): Move lower.  Change type.
 901         (get_fbsd_pspace_data): Update.
 902         (fbsd_pspace_data_cleanup): Remove.
 903         (_initialize_fbsd_tdep): Update.
 904
 905 2019-05-08  Tom Tromey  <tom@tromey.com>
 906
 907         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 908         (get_ada_tasks_pspace_data): Update.
 909         (ada_tasks_pspace_data_cleanup): Remove.
 910         (_initialize_tasks): Update.
 911         (ada_tasks_inferior_data_handle): Change type.
 912         (get_ada_tasks_inferior_data): Update.
 913         (ada_tasks_inferior_data_cleanup): Remove.
 914         (struct ada_tasks_pspace_data): Add initializers.
 915
 916 2019-05-08  Tom Tromey  <tom@tromey.com>
 917
 918         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 919         * symfile-debug.c (debug_sym_get_probes): Change type.
 920         * stap-probe.c (handle_stap_probe):
 921         (stap_static_probe_ops::get_probes): Change type.
 922         * probe.h (class static_probe_ops) <get_probes>: Change type.
 923         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 924         (parse_probes_in_pspace): Update.
 925         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 926         Update.
 927         (any_static_probe_ops::get_probes): Change type.
 928         * elfread.c (elfread_data): New typedef.
 929         (probe_key): Change type.
 930         (elf_get_probes): Likewise.  Update.
 931         (probe_key_free): Remove.
 932         (_initialize_elfread): Update.
 933         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 934         Change type.
 935         (dtrace_process_dof_probe, dtrace_process_dof)
 936         (dtrace_static_probe_ops::get_probe): Change type.
 937
 938 2019-05-08  Tom Tromey  <tom@tromey.com>
 939
 940         * xcoffread.c (struct xcoff_symfile_info): Rename from
 941         coff_symfile_info.  Add initializers.
 942         (xcoff_objfile_data_key): Move lower.  Change type.
 943         (XCOFF_DATA): Rewrite.
 944         (xcoff_free_info): Remove.
 945         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 946         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 947         (xcoff_initial_scan): Update.
 948
 949 2019-05-08  Tom Tromey  <tom@tromey.com>
 950
 951         * solib-svr4.c (struct svr4_info): Add initializers and
 952         destructor.
 953         <probes_table>: Now an htab_up.
 954         (solib_svr4_pspace_data): Change type.
 955         (free_probes_table): Simplify.
 956         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 957         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 958         (probes_table_remove_objfile_probes, register_solib_event_probe)
 959         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 960         (_initialize_svr4_solib): Update.
 961
 962 2019-05-08  Tom Tromey  <tom@tromey.com>
 963
 964         * remote.c (remote_pspace_data): Change type.
 965         (remote_pspace_data_cleanup): Remove.
 966         (get_remote_exec_file, set_pspace_remote_exec_file)
 967         (_initialize_remote): Update.
 968
 969 2019-05-08  Tom Tromey  <tom@tromey.com>
 970
 971         * breakpoint.c (breakpoint_objfile_key): Change type.
 972         (get_breakpoint_objfile_data): Update.
 973         (free_breakpoint_objfile_data): Remove.
 974         (_initialize_breakpoint): Update.
 975
 976 2019-05-08  Tom Tromey  <tom@tromey.com>
 977
 978         * linux-tdep.c (struct linux_info): Add initializers.
 979         (linux_inferior_data): Move.  Change type.
 980         (invalidate_linux_cache_inf): Update.
 981         (linux_inferior_data_cleanup): Remove.
 982         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 983
 984 2019-05-08  Tom Tromey  <tom@tromey.com>
 985
 986         * auxv.c (auxv_inferior_data): Move.  Change type.
 987         (auxv_inferior_data_cleanup): Remove.
 988         (invalidate_auxv_cache_inf): Rewrite.
 989         (get_auxv_inferior_data, _initialize_auxv): Update.
 990
 991 2019-05-08  Tom Tromey  <tom@tromey.com>
 992
 993         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 994         (symfile_debug_objfile_data_key): Change type.
 995         (symfile_debug_installed, debug_qf_has_symbols)
 996         (debug_qf_find_last_source_symtab)
 997         (debug_qf_forget_cached_source_info)
 998         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 999         (debug_qf_print_stats, debug_qf_dump)
1000         (debug_qf_expand_symtabs_for_function)
1001         (debug_qf_expand_all_symtabs)
1002         (debug_qf_expand_symtabs_with_fullname)
1003         (debug_qf_map_matching_symbols)
1004         (debug_qf_expand_symtabs_matching)
1005         (debug_qf_find_pc_sect_compunit_symtab)
1006         (debug_qf_map_symbol_filenames)
1007         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1008         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1009         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1010         (debug_sym_read_linetable, debug_sym_relocate): Update.
1011         (symfile_debug_free_objfile): Remove.
1012         (install_symfile_debug_logging, _initialize_symfile_debug):
1013         Update.
1014
1015 2019-05-08  Tom Tromey  <tom@tromey.com>
1016
1017         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1018         allocate_on_obstack.
1019         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1020         (get_dwarf2_per_objfile): Update.
1021         (set_dwarf2_per_objfile): Remove.
1022         (dwarf2_has_info, dwarf2_get_section_info): Update.
1023         (dwarf2_free_objfile): Remove.
1024         (_initialize_dwarf2_read): Update.
1025
1026 2019-05-08  Tom Tromey  <tom@tromey.com>
1027
1028         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1029         initializers.
1030         <unsupported_script_warning_printed,
1031         script_not_found_warning_printed>: Now bool.
1032         (auto_load_pspace_data): Change type.
1033         (~auto_load_pspace_info): Rename from
1034         auto_load_pspace_data_cleanup.
1035         (get_auto_load_pspace_data, init_loaded_scripts_info)
1036         (clear_section_scripts, maybe_print_unsupported_script_warning)
1037         (maybe_print_script_not_found_warning, _initialize_auto_load):
1038         Update.
1039
1040 2019-05-08  Tom Tromey  <tom@tromey.com>
1041
1042         * objfiles.c (objfile_pspace_info): Add destructor and
1043         initializers.
1044         (objfiles_pspace_data): Change type.
1045         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1046         (get_objfile_pspace_data): Update.
1047         (objfiles_bfd_data): Change type.
1048         (get_objfile_bfd_data): Update.
1049         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1050
1051 2019-05-08  Tom Tromey  <tom@tromey.com>
1052
1053         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1054         Change type.
1055         (get_catch_syscall_inferior_data): Update.
1056         (catch_syscall_inferior_data_cleanup): Remove.
1057         (_initialize_break_catch_syscall): Update.
1058
1059 2019-05-08  Tom Tromey  <tom@tromey.com>
1060
1061         * inflow.c (struct terminal_info): Add destructor and
1062         initializers.
1063         (inflow_inferior_data): Change type.
1064         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1065         (get_inflow_inferior_data, inflow_inferior_exit)
1066         (swap_terminal_info, _initialize_inflow): Update.
1067
1068 2019-05-08  Tom Tromey  <tom@tromey.com>
1069
1070         * target-dcache.c (target_dcache_cleanup): Remove.
1071         (target_dcache_aspace_key): Change type.
1072         (target_dcache_init_p, target_dcache_invalidate)
1073         (target_dcache_get, target_dcache_get_or_init)
1074         (_initialize_target_dcache): Update.
1075         * dcache.h (struct dcache_deleter): New.
1076
1077 2019-05-08  Tom Tromey  <tom@tromey.com>
1078
1079         * symtab.c (struct symbol_cache): Add destructor and
1080         initializers.
1081         (symbol_cache_key): Move.  Change type.
1082         (make_symbol_cache, free_symbol_cache): Remove.
1083         (get_symbol_cache): Update.
1084         (symbol_cache_cleanup): Remove.
1085         (ALL_PSPACES, symbol_cache_flush)
1086         (maintenance_print_symbol_cache)
1087         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1088         Update.
1089
1090 2019-05-08  Tom Tromey  <tom@tromey.com>
1091
1092         * symtab.c (struct main_info): Add destructor and initializers.
1093         (main_progspace_key): Move.  Change type.
1094         (get_main_info): Update.
1095         (main_info_cleanup): Remove.
1096         (_initialize_symtab): Update.
1097
1098 2019-05-08  Tom Tromey  <tom@tromey.com>
1099
1100         * registry.h (DECLARE_REGISTRY): Define the _key class.
1101
1102 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * NEWS: Merge two 'New commands' sections.
1105
1106 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1107
1108         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1109         parameter and use Ada language definition instead.
1110         (ada_val_print_ptr): Remove unused language parameter.
1111         (ada_val_print_num): Remove language parameter and use Ada language
1112         definition instead.
1113         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1114         parameter.
1115         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1116         parameter and use Ada language definition instead.
1117         (ada_val_print_1): Update all ada_val_print_xxx calls.
1118         Remove language parameter.
1119         (ada_val_print): Update ada_val_print_1 call.
1120
1121 2019-05-08  Tom Tromey  <tromey@adacore.com>
1122
1123         * remote.c (remote_hw_watchpoint_limit)
1124         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1125         Now static.
1126
1127 2019-05-08  Tom Tromey  <tromey@adacore.com>
1128
1129         * maint.c (_initialize_maint_cmds): Move initialization code to
1130         remote.c.
1131         (watchdog, show_watchdog): Move to remote.c.
1132         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1133         "watchdog" static.
1134         (_initialize_remote): Move initialization code from maint.c.
1135         * defs.h (watchdog): Don't declare.
1136
1137 2019-05-08  Tom Tromey  <tromey@adacore.com>
1138
1139         * tui/tui-interp.c: Include main.h.
1140         * interps.c: Include main.h.
1141         * main.h (interpreter_p): Declare.
1142         * defs.h (interpreter_p): Don't declare.
1143
1144 2019-05-08  Tom Tromey  <tromey@adacore.com>
1145
1146         * dwarf2loc.c: Include dwarf2read.h.
1147         * defs.h (read_unsigned_leb128): Don't declare.
1148         * dwarf2read.h (read_unsigned_leb128): Declare.
1149
1150 2019-05-08  Tom Tromey  <tromey@adacore.com>
1151
1152         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1153         method.
1154
1155 2019-05-08  Tom Tromey  <tromey@adacore.com>
1156
1157         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1158         when no wrap column is set.
1159
1160 2019-05-08  Tom Tromey  <tromey@adacore.com>
1161
1162         * c-lang.c (c_get_string): Handle non-C-style arrays.
1163
1164 2019-05-08  Tom Tromey  <tromey@adacore.com>
1165
1166         * typeprint.c (print_offset_data::update): Print the bit offset,
1167         not the number of bits remaining.
1168
1169 2019-05-08  Tom Tromey  <tromey@adacore.com>
1170
1171         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1172         padding at end of comment.
1173
1174 2019-05-08  Tom Tromey  <tromey@adacore.com>
1175
1176         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1177         Compare main types.
1178
1179 2019-05-06  Tom Tromey  <tom@tromey.com>
1180
1181         * common/scoped_mmap.c: Include common-defs.h.
1182         * common/scoped_mmap.h: Don't include config.h.
1183
1184 2019-05-04  Tom Tromey  <tom@tromey.com>
1185
1186         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1187         (struct aarch64_call_info): Add initializers.
1188         <si>: Now a std::vector.
1189         (pass_on_stack, aarch64_push_dummy_call): Update.
1190
1191 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1192             Tom Tromey  <tom@tromey.com>
1193
1194         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1195         (ppc_threads): Now a std::vector.  Now static.
1196         (hwdebug_find_thread_points_by_tid)
1197         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1198         Update.
1199
1200 2019-05-04  Tom Tromey  <tom@tromey.com>
1201
1202         * arc-tdep.c (arc_tdesc_init): Return bool.
1203
1204 2019-05-04  Tom Tromey  <tom@tromey.com>
1205
1206         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1207         Use gdb_assert_not_reached.
1208
1209 2019-05-04  Tom Tromey  <tom@tromey.com>
1210
1211         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1212         "false".
1213
1214 2019-05-04  Tom Tromey  <tom@tromey.com>
1215
1216         * arc-tdep.c (arc_tdesc_init): Use bool.
1217
1218 2019-05-04  Tom Tromey  <tom@tromey.com>
1219
1220         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1221
1222 2019-05-04  Tom Tromey  <tom@tromey.com>
1223
1224         * cli/cli-cmds.c (valid_command_p): Return bool.
1225
1226 2019-05-04  Tom Tromey  <tom@tromey.com>
1227
1228         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1229         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1230
1231 2019-05-04  Raul Tambre  <raul@tambre.ee>
1232
1233         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1234         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1235         operator for comparison.
1236
1237 2019-05-04  Tom Tromey  <tom@tromey.com>
1238
1239         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1240         (lookup_partial_symbol, print_partial_symbols)
1241         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1242         (psymbol_compare): Update.
1243         (add_psymbol_to_bcache): Clear the entire psymbol.
1244         (maintenance_check_psymtabs): Update.
1245         * psympriv.h (struct partial_symbol): Don't derive from
1246         general_symbol_info.
1247         <obj_section, unrelocated_address, address,
1248         set_unrelocated_address>: Update.
1249         <ginfo>: New member.
1250         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1251         (debug_names::write_psymbols): Update.
1252
1253 2019-05-04  Tom de Vries  <tdevries@suse.de>
1254
1255         * contrib/cc-with-tweaks.sh: Support -n arg.
1256
1257 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1258
1259         * corelow.c (core_target::detach): Ensure frame cache and
1260         register caches are cleared.
1261         inferior.c (exit_inferior_1): Likewise.
1262
1263 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1264             Tom Tromey  <tom@tromey.com>
1265
1266         * dictionary.c (collate_pending_symbols_by_language): Remove
1267         "struct" from foreach.
1268         * symtab.c (lookup_global_symbol_from_objfile)
1269         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1270         foreach.
1271         * ser-tcp.c (net_open): Remove "struct" from foreach.
1272         * objfiles.c (objfile_relocate, objfile_rebase)
1273         (objfile_has_symbols): Remove "struct" from foreach.
1274         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1275         from foreach.
1276         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1277         foreach.
1278         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1279         "struct" from foreach.
1280         * ada-lang.c (create_excep_cond_exprs)
1281         (ada_exception_catchpoint_cond_string): Remove "struct" from
1282         foreach.
1283
1284 2019-05-03  Tom Tromey  <tromey@adacore.com>
1285
1286         * ada-exp.y (convert_char_literal): Check suffix of each
1287         enumerator.
1288
1289 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1290
1291         PR ada/21406:
1292         * ada-exp.y (yywrap): Don't define.
1293         * ada-lex.l (%option): Add noyywrap
1294         (yywrap): Remove.
1295
1296 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1297
1298         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1299         _WIN32_WINNT to the XP level, unless already defined to a higher
1300         level.
1301
1302         * unittests/parse-connection-spec-selftests.c:
1303         * ser-tcp.c:
1304         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1305         override.
1306
1307         * symfile.c (find_separate_debug_file): Remove colon from the
1308         drive spec of DOS/Windows file names of the target, so that the
1309         file name produced from DEBUGDIR and the target's directory will
1310         be valid on DOS/Windows systems.
1311
1312 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * rust-lang.c (val_print_struct): Handle printing structures
1315         containing strings.
1316
1317 2019-05-02  Tom Tromey  <tromey@adacore.com>
1318
1319         * valarith.c (_initialize_valarith): Remove.
1320
1321 2019-05-01  Tom Tromey  <tromey@adacore.com>
1322
1323         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1324         bitfields.
1325
1326 2019-05-01  Tom Tromey  <tromey@adacore.com>
1327
1328         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1329         for big-endian copies.
1330
1331 2019-04-30  Ali Tamur  <tamur@google.com>
1332         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1333         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1334         (read_3_bytes): New function.
1335
1336 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1337
1338         * windows-nat.c (main_thread_id): Delete.
1339         (handle_output_debug_string): Replace main_thread_id by
1340         current_event.dwThreadId.
1341         (fake_create_process): Likewise.
1342         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1343         Do not set main_thread_id.
1344         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1345         current_event.dwThreadId.
1346         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1347
1348 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1349
1350         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1351         Use current_event.dwThreadId instead of main_thread_id.
1352
1353 2019-04-30  Tom Tromey  <tromey@adacore.com>
1354
1355         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1356         (create_excep_cond_exprs): Iterate over program spaces.
1357         (ada_exception_catchpoint_cond_string): Examine all minimal
1358         symbols for exception types.
1359
1360 2019-04-30  Tom Tromey  <tromey@adacore.com>
1361
1362         PR c++/24470:
1363         * dwarf2read.c (process_structure_scope): Handle case where type
1364         has template parameters but no symbol was created.
1365
1366 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1367             Chris January  <chris.january@arm.com>
1368
1369         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1370         qualifier.
1371         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1372
1373 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * f-typeprint.c (f_print_type): Update rules for printing
1376         whitespace.
1377         (f_type_print_varspec_suffix): Likewise.
1378
1379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1380             Chris January  <chris.january@arm.com>
1381
1382         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1383         function arguments.
1384
1385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * f-lang.c (build_fortran_types): Change name of void type to
1388         lower case.
1389         * f-typeprint.c (f_type_print_base): Print the name of the void
1390         type, rather than a fixed string.
1391         * f-valprint.c (f_decorations): Use lower case void string.
1392
1393 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1394             Chris January  <chris.january@arm.com>
1395
1396         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1397         types for Fortran.
1398
1399 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1400             Chris January  <chris.january@arm.com>
1401             David Lecomber  <david.lecomber@arm.com>
1402
1403         * f-exp.y (BINOP_INTRINSIC): New token.
1404         (exp): New parser rule handling BINOP_INTRINSIC.
1405         (f77_keywords): Add new builtin procedures.
1406         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1407         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1408         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1409         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1410         (print_unop_subexp_f): New function.
1411         (print_binop_subexp_f): New function.
1412         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1413         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1414         (dump_subexp_body_f): Likewise.
1415         (operator_check_f): Likewise.
1416         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1417         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1418
1419 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1422         UNOP_KIND.
1423         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1424         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1425         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1426         (operator_length_f): New fuction.
1427         (print_subexp_f): New function.
1428         (op_name_f): New function.
1429         (dump_subexp_body_f): New function.
1430         (operator_check_f): New function.
1431         (exp_descriptor_f): Replace standard expression handling functions
1432         with new functions.
1433         * gdb/fortran-operator.def: New file.
1434         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1435         * gdb/std-operator.def: Remove UNOP_KIND.
1436
1437 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * std-operator.def: Remove unbalanced, stray double quote
1440         character.
1441
1442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1443             Chris January  <chris.january@arm.com>
1444             Daniel Everett  <daniel.everett@arm.com>
1445             Nick Forrington  <nick.forrington@arm.com>
1446             Richard Bunt  <richard.bunt@arm.com>
1447
1448         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1449         of depth when printing anonymous structs or unions.
1450         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1451         Don't print either the top-level value, or the children if the
1452         max-depth is exceeded.
1453         (ppscm_print_children): When printing the key of a map, allow one
1454         extra level of depth.
1455         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1456         print either the top-level value, or the children if the max-depth
1457         is exceeded.
1458         (print_children): When printing the key of a map, allow one extra
1459         level of depth.
1460         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1461         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1462         (user_print_options): Initialise max_depth field.
1463         (val_print_scalar_or_string_type_p): New function.
1464         (val_print): Check to see if the max depth has been reached.
1465         (val_print_check_max_depth): Define new function.
1466         (show_print_max_depth): New function.
1467         (_initialize_valprint): Add 'print max-depth' option.
1468         * valprint.h (struct value_print_options) <max_depth>: New field.
1469         (val_print_check_max_depth): Declare new function.
1470         * NEWS: Document new feature.
1471
1472 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * ada-lang.c (ada_language_defn): Initialise new field.
1475         * c-lang.c (c_is_string_type_p): New function.
1476         (c_language_defn): Initialise new field.
1477         (cplus_language_defn): Initialise new field.
1478         (asm_language_defn): Initialise new field.
1479         (minimal_language_defn): Initialise new field.
1480         * c-lang.h (c_is_string_type_p): Declare new function.
1481         * d-lang.c (d_language_defn): Initialise new field.
1482         * f-lang.c (f_is_string_type_p): New function.
1483         (f_language_defn): Initialise new field.
1484         * go-lang.c (go_is_string_type_p): New function.
1485         (go_language_defn): Initialise new field.
1486         * language.c (default_is_string_type_p): New function.
1487         (unknown_language_defn): Initialise new field.
1488         (auto_language_defn): Initialise new field.
1489         * language.h (struct language_defn) <la_is_string_type_p>: New
1490         member variable.
1491         (default_is_string_type_p): Declare new function.
1492         * m2-lang.c (m2_language_defn): Initialise new field.
1493         * objc-lang.c (objc_language_defn): Initialise new field.
1494         * opencl-lang.c (opencl_language_defn): Initialise new field.
1495         * p-lang.c (pascal_is_string_type_p): New function.
1496         (pascal_language_defn): Initialise new field.
1497         * rust-lang.c (rust_is_string_type_p): New function.
1498         (rust_language_defn): Initialise new field.
1499
1500 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1503         New field.
1504         * ada-lang.c (ada_language_defn): Initialise new field.
1505         * c-lang.c (c_language_defn): Likewise.
1506         (cplus_language_defn): Likewise.
1507         (asm_language_defn): Likewise.
1508         (minimal_language_defn): Likewise.
1509         * d-lang.c (d_language_defn): Likewise.
1510         * f-lang.c (f_language_defn): Likewise.
1511         * go-lang.c (go_language_defn): Likewise.
1512         * language.c (unknown_language_defn): Likewise.
1513         (auto_language_defn): Likewise.
1514         * m2-lang.c (m2_language_defn): Likewise.
1515         * objc-lang.c (objc_language_defn): Likewise.
1516         * opencl-lang.c (opencl_language_defn): Likewise.
1517         * p-lang.c (pascal_language_defn): Likewise.
1518         * rust-lang.c (rust_language_defn): Likewise.
1519
1520 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1521
1522         * ada-lang.c (ada_is_character_type): Change return type to bool.
1523         (ada_is_string_type): Likewise.
1524         * ada-lang.h (ada_is_character_type): Update declaration
1525         (ada_is_string_type): Likewise.
1526
1527 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1528
1529         Support style in 'frame|thread apply'
1530
1531         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1532         * record.c (record_start, record_stop): Update callers of
1533         execute_command_to_string with false.
1534         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1535         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1536         methods.
1537         (class string_file): New constructor with term_out parameter.
1538         Override methods term_out and can_emit_style_escape.  New member
1539         term_out.
1540         (class stdio_file): Override can_emit_style_escape.
1541         (class tee_file): Override term_out and can_emit_style_escape.
1542         * utils.h (can_emit_style_escape): Remove.
1543         * utils.c (can_emit_style_escape): Likewise.
1544         Update all callers of can_emit_style_escape (SOMESTREAM) to
1545         SOMESTREAM->can_emit_style_escape.
1546         * source-cache.c (source_cache::get_source_lines): Likewise.
1547         * stack.c (frame_apply_command_count): Call execute_command_to_string
1548         passing the term_out characteristic of the current gdb_stdout.
1549         * thread.c (thr_try_catch_cmd): Likewise.
1550         * top.c (execute_command_to_string): pass term_out parameter
1551         to construct the string_file for the command output.
1552         * ui-file.c (term_cli_styling): New function (most code moved
1553         from utils.c can_emit_style_escape).
1554         (string_file::string_file, string_file::can_emit_style_escape,
1555         stdio_file::can_emit_style_escape, tee_file::term_out,
1556         tee_file::can_emit_style_escape): New functions.
1557
1558 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1559
1560         * NEWS: Mention the new set|show may-call-functions.
1561         * infcall.c (may_call_functions_p): New variable.
1562         (show_may_call_functions_p): New function.
1563         (call_function_by_hand_dummy): Throws an error if not
1564         may-call-functions.
1565         (_initialize_infcall): Call add_setshow_boolean_cmd for
1566         may-call-functions.
1567
1568 2019-04-25  Keith Seitz  <keiths@redhat.com>
1569
1570         PR c++/24367
1571         * cp-support.c (inspect_type): Don't attempt substitutions
1572         of symbol with the same name.
1573
1574 2019-04-25  Tom Tromey  <tromey@adacore.com>
1575
1576         PR gdb/24475:
1577         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1578         static.
1579
1580 2019-04-25  Tom Tromey  <tromey@adacore.com>
1581
1582         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1583         rvalue reference.
1584         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1585         (gdb_xml_parser::parse): Use std::move.
1586         * python/python-internal.h (gdbpy_convert_exception): Take a const
1587         reference.
1588         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1589         std::move.
1590         * python/py-utils.c (gdbpy_convert_exception): Take a const
1591         reference.
1592         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1593         Use std::move.
1594         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1595         Use std::move.
1596         * mi/mi-main.c (mi_print_exception): Take a const reference.
1597         * main.c (handle_command_errors): Take a const reference.
1598         * linespec.c (parse_linespec): Use std::move.
1599         * infcall.c (run_inferior_call): Use std::move.
1600         (call_function_by_hand_dummy): Use std::move.
1601         * exec.c (try_open_exec_file): Use std::move.
1602         * exceptions.h (exception_print, exception_fprintf)
1603         (exception_print_same): Update.
1604         * exceptions.c (print_exception, exception_print)
1605         (exception_fprintf, exception_print_same): Change parameters to
1606         const reference.
1607         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1608         * common/new-op.c: Use std::move.
1609         * common/common-exceptions.h (struct gdb_exception): Add move
1610         constructor.
1611         (struct gdb_exception_error, struct gdb_exception_quit, struct
1612         gdb_quit_bad_alloc): Change constructor to move constructor.
1613         (throw_exception): Change parameter to rvalue reference.
1614         * common/common-exceptions.c (throw_exception): Take rvalue
1615         reference.
1616         * cli/cli-interp.c (safe_execute_command): Use std::move.
1617         * breakpoint.c (insert_bp_location, location_to_sals): Use
1618         std::move.
1619
1620 2019-04-25  Tom Tromey  <tromey@adacore.com>
1621
1622         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1623         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1624         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1625         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1626         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1627         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1628         guile/scm-value.c: Use unpack.
1629         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1630         gdbscm_gdb_exception.
1631         (gdbscm_throw_gdb_exception): Likewise.
1632         (struct gdbscm_gdb_exception): New.
1633         (unpack): New function.
1634         (gdbscm_wrap): Use unpack.
1635
1636 2019-04-25  Tom Tromey  <tromey@adacore.com>
1637
1638         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1639         (gdb_rl_callback_handler): Use std::move.
1640         * common/common-exceptions.h (struct gdb_exception): Add move
1641         assignment operator.
1642         (throw_exception_sjlj): Change "exception" to const reference.
1643         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1644         (throw_exception_sjlj): Change "exception" to const reference.
1645
1646 2019-04-25  Tom Tromey  <tromey@adacore.com>
1647
1648         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1649         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1650         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1651         Update.
1652         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1653         Update.
1654         * mi/mi-interp.c (mi_interp::exec): Update.
1655         * linespec.c (parse_linespec): Update.
1656         * infcall.c (run_inferior_call): Update.
1657         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1658         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1659         (gdbscm_lookup_global_symbol): Update.
1660         * guile/scm-param.c (gdbscm_parameter_value): Update.
1661         * guile/scm-frame.c (gdbscm_frame_read_register)
1662         (gdbscm_frame_read_var): Update.
1663         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1664         * exec.c (try_open_exec_file): Update.
1665         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1666         (gdb_rl_callback_handler): Update.
1667         * common/common-exceptions.h (exception_none): Don't declare.
1668         * common/common-exceptions.c (exception_none): Don't define.
1669         (struct catcher) <exception>: Update.
1670         * cli/cli-interp.c (safe_execute_command): Update.
1671         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1672
1673 2019-04-25  Ali Tamur  <tamur@google.com>
1674
1675         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1676         (read_attribute_value): Likewise.
1677         (dwarf2_read_addr_index): Update comment.
1678         (read_str_index): Add DW_FORM_strx.
1679         (dwarf2_string_attr): Likewise.
1680         (dwarf2_const_value_attr): Likewise.
1681         (dump_die_shallow): Likewise.
1682         (dwarf2_fetch_constant_bytes): Likewise.
1683         (skip_form_bytes): Likewise.
1684         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1685
1686 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1687
1688         PR corefiles/11608
1689         PR corefiles/18187
1690         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1691         OFFSET.  Verify if current mapping contains an ELF header.
1692         (linux_find_memory_regions_full): Adjust call to
1693         dump_mapping_p.
1694
1695 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1696             Kang Li <kanglictf@gmail.com>
1697
1698         PR gdb/21600
1699
1700         * dwarf2-frame.c (read_initial_length): Be consistent about using
1701         unsigned representation of length.
1702         (decode_frame_entry_1): Likewise.  Check for wraparound of
1703         end pointer as well as buffer overflow.
1704
1705 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1706
1707         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1708         "vq".
1709
1710 2019-04-24  Tom Tromey  <tromey@adacore.com>
1711
1712         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1713
1714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * s12z-tdep.c (s12z_unwind_pc): Delete.
1717         (s12z_unwind_sp): Delete.
1718         (s12z_gdbarch_init): Don't register deleted functions with
1719         gdbarch.
1720
1721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * rl78-tdep.c (rl78_unwind_sp): Delete.
1724         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1725
1726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1729         (xstormy16_unwind_pc): Delete.
1730         (xstormy16_dummy_id): Delete.
1731         (xstormy16_gdbarch_init): Don't register deleted functions with
1732         gdbarch.
1733
1734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1735
1736         * vax-tdep.c (vax_unwind_pc): Delete.
1737         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1738
1739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * v850-tdep.c (v850_unwind_sp): Delete.
1742         (v850_unwind_pc): Delete.
1743         (v850_dummy_id): Delete.
1744         (v850_gdbarch_init): Don't register deleted functions with
1745         gdbarch.
1746
1747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1748
1749         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1750         (tilegx_unwind_pc): Delete.
1751         (tilegx_unwind_dummy_id): Delete.
1752         (tilegx_gdbarch_init): Don't register deleted functions with
1753         gdbarch.
1754
1755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1758         (tic6x_dummy_id): Delete.
1759         (tic6x_gdbarch_init): Don't register deleted functions with
1760         gdbarch.
1761
1762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * sparc-tdep.c (sparc_unwind_pc): Delete.
1765         (sparc32_gdbarch_init): Don't register deleted function with
1766         gdbarch.
1767
1768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * sh-tdep.c (sh_unwind_sp): Delete.
1771         (sh_unwind_pc): Delete.
1772         (sh_dummy_id): Delete.
1773         (sh_gdbarch_init): Don't register deleted functions with
1774         gdbarch.
1775
1776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * score-tdep.c (score_unwind_sp): Delete.
1779         (score_unwind_pc): Delete.
1780         (score_dummy_id): Delete.
1781         (score_gdbarch_init): Don't register deleted functions with
1782         gdbarch.
1783
1784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1785
1786         * rx-tdep.c (rx_unwind_pc): Delete.
1787         (rx_unwind_sp): Delete.
1788         (rx_dummy_id): Delete.
1789         (rx_gdbarch_init): Don't register deleted functions with
1790         gdbarch.  Update comment.
1791
1792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1795         (rs6000_dummy_id): Delete.
1796         (rs6000_gdbarch_init): Don't register deleted functions with
1797         gdbarch.
1798
1799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1800
1801         * or1k-tdep.c (or1k_dummy_id): Delete.
1802         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1803
1804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * nios2-tdep.c (nios2_dummy_id): Delete.
1807         (nios2_unwind_sp): Delete.
1808         (nios2_gdbarch_init): Don't register deleted functions with
1809         gdbarch.
1810
1811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * nds32-tdep.c (nds32_dummy_id): Delete.
1814         (nds32_unwind_pc): Delete.
1815         (nds32_unwind_sp): Delete.
1816         (nds32_gdbarch_init): Don't register deleted functions with
1817         gdbarch.
1818
1819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1820
1821         * msp430-tdep.c (msp430_unwind_pc): Delete.
1822         (msp430_unwind_sp): Delete.
1823         (msp430_dummy_id): Delete.
1824         (msp430_gdbarch_init): Don't register deleted functions with
1825         gdbarch.
1826
1827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * moxie-tdep.c (moxie_unwind_sp): Delete.
1830         (moxie_unwind_pc): Delete.
1831         (moxie_dummy_id): Delete.
1832         (moxie_gdbarch_init): Don't register deleted functions with
1833         gdbarch.
1834
1835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1838         (mn10300_unwind_pc): Delete.
1839         (mn10300_unwind_sp): Delete.
1840         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1841         mn10300_unwind_sp.
1842         (mn10300_frame_unwind_init): Don't register deleted functions with
1843         gdbarch.
1844
1845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * mep-tdep.c (mep_unwind_pc): Delete.
1848         (mep_unwind_sp): Delete.
1849         (mep_dummy_id): Delete.
1850         (mep_gdbarch_init): Don't register deleted functions with
1851         gdbarch.
1852
1853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1856         (m68hc11_unwind_sp): Delete.
1857         (m68hc11_gdbarch_init): Don't register deleted functions with
1858         gdbarch.
1859
1860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * m32r-tdep.c (m32r_unwind_sp): Delete.
1863         (m32r_unwind_pc): Delete.
1864         (m32r_dummy_id): Delete.
1865         (m32r_gdbarch_init): Don't register deleted functions with
1866         gdbarch.
1867
1868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * m32c-tdep.c (m32c_unwind_pc): Delete.
1871         (m32c_unwind_sp): Delete.
1872         (m32c_dummy_id): Delete.
1873         (m32c_gdbarch_init): Don't register deleted functions with
1874         gdbarch.
1875
1876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1879         (lm32_unwind_pc): Delete.
1880         (lm32_dummy_id): Delete.
1881         (lm32_gdbarch_init): Don't register deleted functions with
1882         gdbarch.
1883
1884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1887         (iq2000_unwind_pc): Delete.
1888         (iq2000_dummy_id): Delete.
1889         (iq2000_gdbarch_init): Don't register deleted functions with
1890         gdbarch.
1891
1892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         * nds32-tdep.c (nds32_type_align): Delete.
1895         (nds32_push_dummy_call): Use type_align instead.
1896
1897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * arm-tdep.c (arm_type_align): Only handle vector override case.
1900         (arm_push_dummy_call): Use type_align.
1901         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1902
1903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1906         case.
1907         (pass_on_stack): Use type_align.
1908         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1909         function.
1910
1911 2019-04-23  Tom Tromey  <tromey@adacore.com>
1912
1913         * dwarf2read.c (line_header::file_name_at): Remove unused
1914         overload.
1915
1916 2019-04-23  Tom de Vries  <tdevries@suse.de>
1917
1918         PR gdb/24438
1919         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1920         invocation.
1921
1922
1923 2019-03-27  Ali Tamur  <tamur@google.com>
1924
1925         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1926         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1927         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1928         (dwarf_expr_context::get_addr_index): Likewise
1929         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1930         (symbol_needs_eval_context::get_addr_index): Likewise
1931         (disassemble_dwarf_expression): Add DW_OP_addrx
1932         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1933         (read_cutu_die_from_dwo): Update comment
1934         (skip_one_die): Add DW_FORM_addrx
1935         (read_attribute_value): Likewise
1936         (var_decode_location): Add DW_OP_addrx
1937         (dwarf2_const_value_attr): Add DW_FORM_addrx
1938         (dump_die_shallow): Likewise
1939         (dwarf2_fetch_constant_bytes): Likewise
1940         (decode_locdesc): Add DW_OP_addrx
1941         (skip_form_bytes): Add DW_FORM_addrx
1942
1943 2019-04-22  Ali Tamur  <tamur@google.com>
1944
1945         * MAINTAINERS (Write After Approval): Add self.
1946
1947 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1948
1949         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1950         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1951         (open_symbol_file_object): Likewise.
1952         (svr4_default_sos): Add info parameter.
1953         (svr4_read_so_list): Likewise.
1954         (svr4_current_sos_direct): Adjust functions calls to pass down
1955         info.
1956         (svr4_current_sos_1): Add info parameter.
1957         (svr4_current_sos): Call get_svr4_info, pass info down to
1958         svr4_current_sos_1.
1959         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1960         get_svr4_info.
1961         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1962         get_svr4_info.
1963         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1964         to get_svr4_info.
1965         (probes_table_remove_objfile_probes): Likewise.
1966         (register_solib_event_probe): Add info parameter.
1967         (solist_update_incremental): Pass info parameter down to
1968         svr4_read_so_list.
1969         (disable_probes_interface): Add info parameter.
1970         (svr4_handle_solib_event): Pass current_program_space to
1971         get_svr4_info.  Adjust disable_probes_interface cleanup.
1972         (svr4_create_probe_breakpoints): Add info parameter, pass it
1973         down to register_solib_event_probe.
1974         (svr4_create_solib_event_breakpoints): Add info parameter,
1975         pass it down to svr4_create_probe_breakpoints.
1976         (enable_break): Pass info down to
1977         svr4_create_solib_event_breakpoints.
1978         (svr4_solib_create_inferior_hook): Pass current_program_space to
1979         get_svr4_info.
1980         (svr4_clear_solib): Likewise.
1981
1982 2019-04-22  Pedro Alves  <palves@redhat.com>
1983
1984         * solib-svr4.c (svr4_free_objfile_observer): New.
1985         (probe_and_action::objfile): New field.
1986         (probes_table_htab_remove_objfile_probes)
1987         (probes_table_remove_objfile_probes): New functions.
1988         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1989         in the new probe_and_action.  Don't store the probe in 'lookup'.
1990         (svr4_create_probe_breakpoints): Pass objfile to
1991         register_solib_event_probe.
1992         (_initialize_svr4_solib): Register a free_objfile observer.
1993
1994 2019-04-19  Tom Tromey  <tom@tromey.com>
1995
1996         * common/queue.h: Remove.
1997
1998 2019-04-19  Tom Tromey  <tom@tromey.com>
1999
2000         * event-loop.c: Don't include "common/queue.h".
2001
2002 2019-04-19  Tom Tromey  <tom@tromey.com>
2003
2004         * remote.c (remote_target): Use delete.
2005         * remote-notif.h: Include <list>, not "common/queue.h".
2006         (notif_client_p): Remove typedef.
2007         (remote_notif_state): Add constructor, destructor, initializer.
2008         <notif_queue>: Now a std::list.
2009         (remote_notif_state_xfree): Don't declare.
2010         * remote-notif.c (remote_notif_process, handle_notification)
2011         (remote_notif_state_allocate): Update.
2012         (~remote_notif_state): Rename from remote_notif_state_xfree.
2013
2014 2019-04-19  Tom Tromey  <tom@tromey.com>
2015
2016         * symfile.c (reread_symbols): Update.
2017         * objfiles.c (objfile_register_static_link)
2018         (objfile_lookup_static_link): Update
2019         (~objfile) Don't delete static_links.
2020         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2021
2022 2019-04-19  Tom Tromey  <tom@tromey.com>
2023
2024         * type-stack.h (struct type_stack) <insert>: Constify string.
2025         * type-stack.c (type_stack::insert): Constify string.
2026         * gdbtypes.h (lookup_template_type): Update.
2027         (address_space_name_to_int): Update.
2028         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2029         const.
2030         (lookup_template_type): Make name const.
2031         * c-exp.y: Update rules.
2032         (lex_one_token, classify_name, classify_inner_name)
2033         (c_print_token): Update.
2034         * p-exp.y: Update rules.
2035         (yylex): Update.
2036         * f-exp.y: Update rules.
2037         (yylex): Update.
2038         * d-exp.y: Update rules.
2039         (lex_one_token, classify_name, classify_inner_name): Update.
2040         * parse.c (write_dollar_variable, copy_name): Return std::string.
2041         * parser-defs.h (copy_name): Change return type.
2042         * m2-exp.y: Update rules.
2043         (yylex): Update.
2044         * go-exp.y (lex_one_token): Update.
2045         Update rules.
2046         (classify_unsafe_function, classify_packaged_name)
2047         (classify_name, yylex): Update.
2048
2049 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2050
2051         * configure.ac: add --enable-source-highlight switch.
2052         * configure: Regenerate.
2053         * top.c (print_gdb_version): plumb --enable-source-highlight
2054         status to "show configuration".
2055
2056 2019-04-19  Tom Tromey  <tromey@adacore.com>
2057
2058         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2059         Check ADA_TYPE_P.
2060         (empty_record, ada_template_to_fixed_record_type_1)
2061         (template_to_static_fixed_type)
2062         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2063         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2064         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2065         macros.
2066
2067 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2068
2069         PR symtab/24423:
2070         * source.c (print_source_lines_base): Advance "iter" when a
2071         control character is seen.
2072
2073 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074
2075         * inferior.h (struct infcall_suspend_state_deleter):
2076         Catch exception in destructor to avoid crash.
2077
2078 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2081         close to the add_com "shell".
2082
2083 2019-04-18  Tom Tromey  <tromey@adacore.com>
2084
2085         * process-stratum-target.h (class process_stratum_target)
2086         <stratum>: Add "final".
2087
2088 2019-04-17  Tom Tromey  <tromey@adacore.com>
2089
2090         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2091         against nullptr before use.
2092
2093 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2094
2095         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2096
2097 2019-04-17  Jim Wilson  <jimw@sifive.com>
2098             Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2101         code read might fail, assume 4-byte breakpoint in that case.
2102
2103 2019-04-15  Leszek Swirski  <leszeks@google.com>
2104
2105         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2106         rather than a hand-rolled POD check when checking for forced MEMORY
2107         classification.
2108
2109 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2110
2111         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2112         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2113         function.
2114         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2115         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2116         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2117         declaration.
2118
2119 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2120
2121         * aarch64-linux-nat.c
2122         (aarch64_linux_nat_target::thread_architecture): Add override.
2123         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2124         each VQ.
2125
2126 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2127
2128         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2129
2130 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2133         target types of size 96-bits, add some additional comments, and
2134         check that the builtin type we found was the correct size.
2135
2136 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2137
2138         * utils.c (prompt_for_continue): Don't restore the styling at the
2139         end, as applied_style has the wrong value.  This fixes styling in
2140         long lists of file names that are interrupted by the "Continue?"
2141         prompt.
2142
2143 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2146         * c-lang.c (c_language_defn): Likewise.
2147         (cplus_language_defn): Likewise.
2148         (asm_language_defn): Likewise.
2149         (minimal_language_defn): Likewise.
2150         * d-lang.c (d_language_defn): Likewise.
2151         * f-lang.c (f_language_defn): Likewise.
2152         * go-lang.c (go_language_defn): Likewise.
2153         * language.c (unknown_language_defn): Likewise.
2154         (auto_language_defn): Likewise.
2155         * language.h (struct language_defn): Remove la_magic field.
2156         (LANG_MAGIC): Delete.
2157         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2158         * objc-lang.c (objc_language_defn): Likewise.
2159         * opencl-lang.c (opencl_language_defn): Likewise.
2160         * p-lang.c (pascal_language_defn): Likewise.
2161         * rust-lang.c (rust_language_defn): Likewise.
2162
2163 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * riscv-tdep.c (riscv_type_align): New function.
2166         (riscv_type_alignment): Delete.
2167         (riscv_arg_location): Use 'type_align'.
2168         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2169
2170 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2171
2172         * gdbtypes.c (type_align): A struct with no non-static fields also
2173         has alignment of 1.
2174
2175 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2176
2177         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2178         component to 0.
2179         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2180         member.
2181         (riscv_struct_info::analyse): New implementation using new
2182         analyse_inner member function.
2183         (riscv_struct_info::field_offset): New member function.
2184         (riscv_struct_info::m_offsets): New member variable.
2185         (riscv_struct_info::analyse_inner): New private member function,
2186         takes the old implementation of riscv_struct_info::analyse but
2187         extended to track field offsets.
2188         (riscv_call_arg_struct): Update the struct folding special cases
2189         to handle cases where empty C++ structs, which are non-zero
2190         length, are found.
2191         (riscv_arg_location): Initialise the length of each location, a
2192         non-zero length now indicates the location is in use.
2193         (riscv_push_dummy_call): Allow for the first location having a
2194         non-zero offset when setting up arguments.
2195         (riscv_return_value): Likewise, but for return values.
2196
2197 2019-04-11  Tom Tromey  <tromey@adacore.com>
2198
2199         * utils.c (internal_vproblem): Make "msg" const.
2200
2201 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2202
2203         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2204         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2205         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2206         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2207
2208 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2209
2210         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2211         function.
2212         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2213         of amd64_collect_native_gregset.
2214         (amd64_linux_nat_target::store_registers): Likewise.
2215
2216 2019-04-10  Tom Tromey  <tom@tromey.com>
2217
2218         * symtab.c (lookup_global_symbol_from_objfile)
2219         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2220         * objfiles.h (class separate_debug_iterator): New.
2221         (class separate_debug_range): New.
2222         (struct objfile) <separate_debug_objfiles>: New method.
2223         (objfile_separate_debug_iterate): Don't declare.
2224         * objfiles.c (separate_debug_iterator::operator++): Rename from
2225         objfile_separate_debug_iterate.
2226         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2227         iterator.
2228         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2229         iterator.
2230
2231 2019-04-10  Tom Tromey  <tom@tromey.com>
2232
2233         * symfile.c (reread_symbols): Remove old comment.
2234         * objfiles.c (free_all_objfiles): Fix a typo.
2235
2236 2019-04-10  Tom Tromey  <tom@tromey.com>
2237
2238         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2239         * minsyms.c (lookup_minimal_symbol): Use foreach.
2240         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2241         (lookup_minimal_symbol_solib_trampoline): Likewise.
2242         * symfile.c (reread_symbols): Use foreach.
2243
2244 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2245             Tom Tromey  <tromey@adacore.com>
2246
2247         PR rust/24414:
2248         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2249         (rust_lex_int_test): Change "value" to be LONGEST.
2250         (rust_lex_tests): Add test for long integer literal.
2251
2252 2019-04-09  Tom Tromey  <tromey@adacore.com>
2253
2254         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2255         to bool.
2256         (extended_remote_target::attach): Update.
2257         (remote_target::remote_notice_new_inferior): Update.
2258         (remote_target::add_current_inferior_and_thread): Update.
2259         * inferior.c (exit_inferior_1): Use "false".
2260         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2261
2262 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2263
2264         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2265         the "start" command.
2266
2267 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2268
2269         * python/py-inferior.c (infpy_thread_from_thread_handle):
2270         Adjust comments to reflect renaming of thread_from_thread_handle
2271         to thread_from_handle.  Adjust keywords.  Fix type error message.
2272         (inferior_object_methods): Add thread_from_handle.  Retain
2273         thread_from_thread_handle, but mark it as deprecated.
2274
2275 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2276
2277         * gdbthread.h (find_thread_by_handle): Revise declaration.
2278         * thread.c (find_thread_by_handle): Likewise.  Adjust
2279         implementation too.
2280         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2281         support for buffer objects as handles.
2282
2283 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2284
2285         * python/py-infthread.c (thpy_thread_handle): New function.
2286         (thread_object_methods): Register thpy_thread_handle.
2287
2288 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2289
2290         * gdbthread.h (thread_to_thread_handle): Declare.
2291         * thread.c (gdbtypes.h): Include.
2292         (thread_to_thread_handle): New function.
2293
2294         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2295         (target_thread_info_to_thread_handle): Declare.
2296         * target.c (target_thread_info_to_thread_handle): New function.
2297         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2298         * target-delegates.c: Regenerate.
2299
2300         * linux-thread-db.c (class thread_db_target): Add method
2301         thread_info_to_thread_handle.
2302         (thread_db_target::thread_info_to_thread_handle): Define.
2303         * remote.c (class remote_target): Add new method
2304         thread_info_to_thread_handle.
2305         (remote_target::thread_info_to_thread_handle): Define.
2306
2307 2019-04-08  Pedro Alves  <palves@redhat.com>
2308
2309         * common/common-exceptions.c (throw_exception): Don't create
2310         named object to throw; throw directly.
2311         (throw_it): Likewise.  Don't initialize gdb_exception::message
2312         here, with new; pass FMT and AP to the ctor instead.
2313         * common/common-exceptions.h: Include <string>.
2314         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2315         const char *, va_list)): New ctor.  Use std::make_shared.
2316         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2317         errors)): Delete.
2318         (gdb_exception_error::gdb_exception_error(enum errors, const char
2319         *, va_list)): New.
2320         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2321         Add assertion.
2322         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2323         errors)): Delete.
2324         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2325         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2326         Add assertion.
2327
2328 2019-04-08  Tom Tromey  <tom@tromey.com>
2329
2330         * valops.c (value_rtti_indirect_type): Replace throw_exception
2331         with throw.
2332         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2333         with throw.
2334         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2335         throw.
2336         * target.c (target_translate_tls_address): Replace throw_exception
2337         with throw.
2338         * stack.c (frame_apply_command_count): Replace throw_exception
2339         with throw.
2340         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2341         throw.
2342         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2343         with throw.
2344         * rs6000-tdep.c (rs6000_frame_cache)
2345         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2346         * remote.c: Replace throw_exception with throw.
2347         * record-full.c (record_full_message, record_full_wait_1)
2348         (record_full_restore): Replace throw_exception with throw.
2349         * record-btrace.c:
2350         (get_thread_current_frame_id, record_btrace_start_replaying)
2351         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2352         (cmd_record_btrace_start): Replace throw_exception with throw.
2353         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2354         throw.
2355         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2356         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2357         * linespec.c:
2358         (find_linespec_symbols): Replace throw_exception with throw.
2359         * infrun.c (displaced_step_prepare, resume): Replace
2360         throw_exception with throw.
2361         * infcmd.c (post_create_inferior): Replace throw_exception with
2362         throw.
2363         * inf-loop.c (inferior_event_handler): Replace throw_exception
2364         with throw.
2365         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2366         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2367         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2368         (get_prev_frame_always, get_frame_pc_if_available)
2369         (get_frame_address_in_block_if_available, get_frame_language):
2370         Replace throw_exception with throw.
2371         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2372         throw_exception with throw.
2373         * eval.c (fetch_subexp_value, evaluate_var_value)
2374         (evaluate_funcall, evaluate_subexp_standard): Replace
2375         throw_exception with throw.
2376         * dwarf2loc.c (call_site_find_chain)
2377         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2378         Replace throw_exception with throw.
2379         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2380         with throw.
2381         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2382         throw.
2383         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2384         * completer.c (complete_line_internal): Replace throw_exception
2385         with throw.
2386         * compile/compile-object-run.c (compile_object_run): Replace
2387         throw_exception with throw.
2388         * cli/cli-script.c (process_next_line): Replace throw_exception
2389         with throw.
2390         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2391         (btrace_enable, btrace_maint_update_pt_packets): Replace
2392         throw_exception with throw.
2393         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2394         throw_exception with throw.
2395         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2396         throw_exception with throw.
2397         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2398         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2399         * aarch64-tdep.c (aarch64_make_prologue_cache)
2400         (aarch64_make_stub_cache): Replace throw_exception with throw.
2401
2402 2019-04-08  Tom Tromey  <tom@tromey.com>
2403
2404         * common/common-exceptions.c (throw_exception): Rename from
2405         throw_exception_cxx.  Remove old copy.  Make argument const.
2406         (throw_it): Create and throw exception objects directly.
2407         * common/common-exceptions.h (throw_exception): Make argument
2408         const.
2409         (struct gdb_exception_error): Add constructor.
2410         (struct gdb_exception_quit): Add constructor.
2411
2412 2019-04-08  Tom Tromey  <tom@tromey.com>
2413
2414         * common/common-exceptions.h (exception_rethrow): Don't declare.
2415         (TRY_SJLJ): Update comment.
2416         (TRY, CATCH, END_CATCH): Remove.
2417         * common/common-exceptions.c (exception_rethrow): Remove.
2418
2419 2019-04-08  Tom Tromey  <tom@tromey.com>
2420
2421         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2422         Remove.
2423         (gdb_exception_error): Rename from
2424         gdb_exception_RETURN_MASK_ERROR.
2425         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2426         (gdb_quit_bad_alloc): Update.
2427         * aarch64-tdep.c: Update.
2428         * ada-lang.c: Update.
2429         * ada-typeprint.c: Update.
2430         * ada-valprint.c: Update.
2431         * amd64-tdep.c: Update.
2432         * arch-utils.c: Update.
2433         * break-catch-throw.c: Update.
2434         * breakpoint.c: Update.
2435         * btrace.c: Update.
2436         * c-varobj.c: Update.
2437         * cli/cli-cmds.c: Update.
2438         * cli/cli-interp.c: Update.
2439         * cli/cli-script.c: Update.
2440         * common/common-exceptions.c: Update.
2441         * common/new-op.c: Update.
2442         * common/selftest.c: Update.
2443         * compile/compile-c-symbols.c: Update.
2444         * compile/compile-cplus-symbols.c: Update.
2445         * compile/compile-object-load.c: Update.
2446         * compile/compile-object-run.c: Update.
2447         * completer.c: Update.
2448         * corelow.c: Update.
2449         * cp-abi.c: Update.
2450         * cp-support.c: Update.
2451         * cp-valprint.c: Update.
2452         * darwin-nat.c: Update.
2453         * disasm-selftests.c: Update.
2454         * dtrace-probe.c: Update.
2455         * dwarf-index-cache.c: Update.
2456         * dwarf-index-write.c: Update.
2457         * dwarf2-frame-tailcall.c: Update.
2458         * dwarf2-frame.c: Update.
2459         * dwarf2loc.c: Update.
2460         * dwarf2read.c: Update.
2461         * eval.c: Update.
2462         * event-loop.c: Update.
2463         * event-top.c: Update.
2464         * exec.c: Update.
2465         * f-valprint.c: Update.
2466         * fbsd-tdep.c: Update.
2467         * frame-unwind.c: Update.
2468         * frame.c: Update.
2469         * gdbtypes.c: Update.
2470         * gnu-v3-abi.c: Update.
2471         * guile/guile-internal.h: Update.
2472         * guile/scm-block.c: Update.
2473         * guile/scm-breakpoint.c: Update.
2474         * guile/scm-cmd.c: Update.
2475         * guile/scm-disasm.c: Update.
2476         * guile/scm-frame.c: Update.
2477         * guile/scm-lazy-string.c: Update.
2478         * guile/scm-math.c: Update.
2479         * guile/scm-param.c: Update.
2480         * guile/scm-ports.c: Update.
2481         * guile/scm-pretty-print.c: Update.
2482         * guile/scm-symbol.c: Update.
2483         * guile/scm-symtab.c: Update.
2484         * guile/scm-type.c: Update.
2485         * guile/scm-value.c: Update.
2486         * i386-linux-tdep.c: Update.
2487         * i386-tdep.c: Update.
2488         * inf-loop.c: Update.
2489         * infcall.c: Update.
2490         * infcmd.c: Update.
2491         * infrun.c: Update.
2492         * jit.c: Update.
2493         * language.c: Update.
2494         * linespec.c: Update.
2495         * linux-fork.c: Update.
2496         * linux-nat.c: Update.
2497         * linux-tdep.c: Update.
2498         * linux-thread-db.c: Update.
2499         * main.c: Update.
2500         * mi/mi-cmd-break.c: Update.
2501         * mi/mi-cmd-stack.c: Update.
2502         * mi/mi-interp.c: Update.
2503         * mi/mi-main.c: Update.
2504         * objc-lang.c: Update.
2505         * p-valprint.c: Update.
2506         * parse.c: Update.
2507         * ppc-linux-tdep.c: Update.
2508         * printcmd.c: Update.
2509         * python/py-arch.c: Update.
2510         * python/py-breakpoint.c: Update.
2511         * python/py-cmd.c: Update.
2512         * python/py-finishbreakpoint.c: Update.
2513         * python/py-frame.c: Update.
2514         * python/py-framefilter.c: Update.
2515         * python/py-gdb-readline.c: Update.
2516         * python/py-inferior.c: Update.
2517         * python/py-infthread.c: Update.
2518         * python/py-lazy-string.c: Update.
2519         * python/py-linetable.c: Update.
2520         * python/py-objfile.c: Update.
2521         * python/py-param.c: Update.
2522         * python/py-prettyprint.c: Update.
2523         * python/py-progspace.c: Update.
2524         * python/py-record-btrace.c: Update.
2525         * python/py-record.c: Update.
2526         * python/py-symbol.c: Update.
2527         * python/py-type.c: Update.
2528         * python/py-unwind.c: Update.
2529         * python/py-utils.c: Update.
2530         * python/py-value.c: Update.
2531         * python/python.c: Update.
2532         * record-btrace.c: Update.
2533         * record-full.c: Update.
2534         * remote-fileio.c: Update.
2535         * remote.c: Update.
2536         * riscv-tdep.c: Update.
2537         * rs6000-aix-tdep.c: Update.
2538         * rs6000-tdep.c: Update.
2539         * rust-exp.y: Update.
2540         * rust-lang.c: Update.
2541         * s390-tdep.c: Update.
2542         * selftest-arch.c: Update.
2543         * solib-dsbt.c: Update.
2544         * solib-frv.c: Update.
2545         * solib-spu.c: Update.
2546         * solib-svr4.c: Update.
2547         * solib.c: Update.
2548         * sparc64-linux-tdep.c: Update.
2549         * stack.c: Update.
2550         * symfile-mem.c: Update.
2551         * symmisc.c: Update.
2552         * target.c: Update.
2553         * thread.c: Update.
2554         * top.c: Update.
2555         * tracefile-tfile.c: Update.
2556         * tui/tui.c: Update.
2557         * typeprint.c: Update.
2558         * unittests/cli-utils-selftests.c: Update.
2559         * unittests/parse-connection-spec-selftests.c: Update.
2560         * valops.c: Update.
2561         * valprint.c: Update.
2562         * value.c: Update.
2563         * varobj.c: Update.
2564         * windows-nat.c: Update.
2565         * x86-linux-nat.c: Update.
2566         * xml-support.c: Update.
2567
2568 2019-04-08  Tom Tromey  <tom@tromey.com>
2569
2570         * xml-support.c: Use C++ exception handling.
2571         * x86-linux-nat.c: Use C++ exception handling.
2572         * windows-nat.c: Use C++ exception handling.
2573         * varobj.c: Use C++ exception handling.
2574         * value.c: Use C++ exception handling.
2575         * valprint.c: Use C++ exception handling.
2576         * valops.c: Use C++ exception handling.
2577         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2578         handling.
2579         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2580         * typeprint.c: Use C++ exception handling.
2581         * tui/tui.c: Use C++ exception handling.
2582         * tracefile-tfile.c: Use C++ exception handling.
2583         * top.c: Use C++ exception handling.
2584         * thread.c: Use C++ exception handling.
2585         * target.c: Use C++ exception handling.
2586         * symmisc.c: Use C++ exception handling.
2587         * symfile-mem.c: Use C++ exception handling.
2588         * stack.c: Use C++ exception handling.
2589         * sparc64-linux-tdep.c: Use C++ exception handling.
2590         * solib.c: Use C++ exception handling.
2591         * solib-svr4.c: Use C++ exception handling.
2592         * solib-spu.c: Use C++ exception handling.
2593         * solib-frv.c: Use C++ exception handling.
2594         * solib-dsbt.c: Use C++ exception handling.
2595         * selftest-arch.c: Use C++ exception handling.
2596         * s390-tdep.c: Use C++ exception handling.
2597         * rust-lang.c: Use C++ exception handling.
2598         * rust-exp.y: Use C++ exception handling.
2599         * rs6000-tdep.c: Use C++ exception handling.
2600         * rs6000-aix-tdep.c: Use C++ exception handling.
2601         * riscv-tdep.c: Use C++ exception handling.
2602         * remote.c: Use C++ exception handling.
2603         * remote-fileio.c: Use C++ exception handling.
2604         * record-full.c: Use C++ exception handling.
2605         * record-btrace.c: Use C++ exception handling.
2606         * python/python.c: Use C++ exception handling.
2607         * python/py-value.c: Use C++ exception handling.
2608         * python/py-utils.c: Use C++ exception handling.
2609         * python/py-unwind.c: Use C++ exception handling.
2610         * python/py-type.c: Use C++ exception handling.
2611         * python/py-symbol.c: Use C++ exception handling.
2612         * python/py-record.c: Use C++ exception handling.
2613         * python/py-record-btrace.c: Use C++ exception handling.
2614         * python/py-progspace.c: Use C++ exception handling.
2615         * python/py-prettyprint.c: Use C++ exception handling.
2616         * python/py-param.c: Use C++ exception handling.
2617         * python/py-objfile.c: Use C++ exception handling.
2618         * python/py-linetable.c: Use C++ exception handling.
2619         * python/py-lazy-string.c: Use C++ exception handling.
2620         * python/py-infthread.c: Use C++ exception handling.
2621         * python/py-inferior.c: Use C++ exception handling.
2622         * python/py-gdb-readline.c: Use C++ exception handling.
2623         * python/py-framefilter.c: Use C++ exception handling.
2624         * python/py-frame.c: Use C++ exception handling.
2625         * python/py-finishbreakpoint.c: Use C++ exception handling.
2626         * python/py-cmd.c: Use C++ exception handling.
2627         * python/py-breakpoint.c: Use C++ exception handling.
2628         * python/py-arch.c: Use C++ exception handling.
2629         * printcmd.c: Use C++ exception handling.
2630         * ppc-linux-tdep.c: Use C++ exception handling.
2631         * parse.c: Use C++ exception handling.
2632         * p-valprint.c: Use C++ exception handling.
2633         * objc-lang.c: Use C++ exception handling.
2634         * mi/mi-main.c: Use C++ exception handling.
2635         * mi/mi-interp.c: Use C++ exception handling.
2636         * mi/mi-cmd-stack.c: Use C++ exception handling.
2637         * mi/mi-cmd-break.c: Use C++ exception handling.
2638         * main.c: Use C++ exception handling.
2639         * linux-thread-db.c: Use C++ exception handling.
2640         * linux-tdep.c: Use C++ exception handling.
2641         * linux-nat.c: Use C++ exception handling.
2642         * linux-fork.c: Use C++ exception handling.
2643         * linespec.c: Use C++ exception handling.
2644         * language.c: Use C++ exception handling.
2645         * jit.c: Use C++ exception handling.
2646         * infrun.c: Use C++ exception handling.
2647         * infcmd.c: Use C++ exception handling.
2648         * infcall.c: Use C++ exception handling.
2649         * inf-loop.c: Use C++ exception handling.
2650         * i386-tdep.c: Use C++ exception handling.
2651         * i386-linux-tdep.c: Use C++ exception handling.
2652         * guile/scm-value.c: Use C++ exception handling.
2653         * guile/scm-type.c: Use C++ exception handling.
2654         * guile/scm-symtab.c: Use C++ exception handling.
2655         * guile/scm-symbol.c: Use C++ exception handling.
2656         * guile/scm-pretty-print.c: Use C++ exception handling.
2657         * guile/scm-ports.c: Use C++ exception handling.
2658         * guile/scm-param.c: Use C++ exception handling.
2659         * guile/scm-math.c: Use C++ exception handling.
2660         * guile/scm-lazy-string.c: Use C++ exception handling.
2661         * guile/scm-frame.c: Use C++ exception handling.
2662         * guile/scm-disasm.c: Use C++ exception handling.
2663         * guile/scm-cmd.c: Use C++ exception handling.
2664         * guile/scm-breakpoint.c: Use C++ exception handling.
2665         * guile/scm-block.c: Use C++ exception handling.
2666         * guile/guile-internal.h: Use C++ exception handling.
2667         * gnu-v3-abi.c: Use C++ exception handling.
2668         * gdbtypes.c: Use C++ exception handling.
2669         * frame.c: Use C++ exception handling.
2670         * frame-unwind.c: Use C++ exception handling.
2671         * fbsd-tdep.c: Use C++ exception handling.
2672         * f-valprint.c: Use C++ exception handling.
2673         * exec.c: Use C++ exception handling.
2674         * event-top.c: Use C++ exception handling.
2675         * event-loop.c: Use C++ exception handling.
2676         * eval.c: Use C++ exception handling.
2677         * dwarf2read.c: Use C++ exception handling.
2678         * dwarf2loc.c: Use C++ exception handling.
2679         * dwarf2-frame.c: Use C++ exception handling.
2680         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2681         * dwarf-index-write.c: Use C++ exception handling.
2682         * dwarf-index-cache.c: Use C++ exception handling.
2683         * dtrace-probe.c: Use C++ exception handling.
2684         * disasm-selftests.c: Use C++ exception handling.
2685         * darwin-nat.c: Use C++ exception handling.
2686         * cp-valprint.c: Use C++ exception handling.
2687         * cp-support.c: Use C++ exception handling.
2688         * cp-abi.c: Use C++ exception handling.
2689         * corelow.c: Use C++ exception handling.
2690         * completer.c: Use C++ exception handling.
2691         * compile/compile-object-run.c: Use C++ exception handling.
2692         * compile/compile-object-load.c: Use C++ exception handling.
2693         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2694         * compile/compile-c-symbols.c: Use C++ exception handling.
2695         * common/selftest.c: Use C++ exception handling.
2696         * common/new-op.c: Use C++ exception handling.
2697         * cli/cli-script.c: Use C++ exception handling.
2698         * cli/cli-interp.c: Use C++ exception handling.
2699         * cli/cli-cmds.c: Use C++ exception handling.
2700         * c-varobj.c: Use C++ exception handling.
2701         * btrace.c: Use C++ exception handling.
2702         * breakpoint.c: Use C++ exception handling.
2703         * break-catch-throw.c: Use C++ exception handling.
2704         * arch-utils.c: Use C++ exception handling.
2705         * amd64-tdep.c: Use C++ exception handling.
2706         * ada-valprint.c: Use C++ exception handling.
2707         * ada-typeprint.c: Use C++ exception handling.
2708         * ada-lang.c: Use C++ exception handling.
2709         * aarch64-tdep.c: Use C++ exception handling.
2710
2711 2019-04-08  Tom Tromey  <tom@tromey.com>
2712
2713         * xml-support.c (gdb_xml_parser::parse): Update.
2714         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2715         * value.c (show_convenience): Update.
2716         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2717         (test_parse_flags_qcs): Update.
2718         * thread.c (thr_try_catch_cmd): Update.
2719         * target.c (target_translate_tls_address): Update.
2720         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2721         (info_frame_command_core, frame_apply_command_count): Update.
2722         * rust-exp.y (rust_lex_exception_test): Update.
2723         * riscv-tdep.c (riscv_print_one_register_info): Update.
2724         * remote.c (remote_target::enable_btrace): Update.
2725         * record-btrace.c (record_btrace_enable_warn): Update.
2726         * python/py-utils.c (gdbpy_convert_exception): Update.
2727         * printcmd.c (do_one_display, print_variable_and_value): Update.
2728         * mi/mi-main.c (mi_print_exception): Update.
2729         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2730         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2731         * linux-nat.c (linux_nat_target::attach): Update.
2732         * linux-fork.c (class scoped_switch_fork_info): Update.
2733         * infrun.c (displaced_step_prepare): Update.
2734         * infcall.c (call_function_by_hand_dummy): Update.
2735         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2736         * gnu-v3-abi.c (print_one_vtable): Update.
2737         * frame.c (get_prev_frame_always): Update.
2738         * f-valprint.c (info_common_command_for_block): Update.
2739         * exec.c (try_open_exec_file): Update.
2740         * exceptions.c (print_exception, exception_print)
2741         (exception_fprintf, exception_print_same): Update.
2742         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2743         * dwarf-index-cache.c (index_cache::store)
2744         (index_cache::lookup_gdb_index): Update.
2745         * darwin-nat.c (maybe_cache_shell): Update.
2746         * cp-valprint.c (cp_print_value_fields): Update.
2747         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2748         (gcc_cplus_symbol_address): Update.
2749         * compile/compile-c-symbols.c (gcc_convert_symbol)
2750         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2751         * common/selftest.c: Update.
2752         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2753         a std::string.
2754         (exception_try_scope_entry, exception_try_scope_exit): Don't
2755         declare.
2756         (struct exception_try_scope): Remove.
2757         (TRY): Don't use exception_try_scope.
2758         (struct gdb_exception): Add constructor, operator=.
2759         <what>: New method.
2760         (struct gdb_exception_RETURN_MASK_ALL)
2761         (struct gdb_exception_RETURN_MASK_ERROR)
2762         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2763         (struct gdb_quit_bad_alloc): Update.
2764         * common/common-exceptions.c (exception_none): Change
2765         initializer.
2766         (struct catcher) <state, exception>: Initialize inline.
2767         <prev>: Remove member.
2768         (current_catcher): Remove.
2769         (catchers): New global.
2770         (exceptions_state_mc_init): Simplify.
2771         (catcher_pop): Remove.
2772         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2773         (try_scope_depth, exception_try_scope_entry)
2774         (exception_try_scope_exit): Remove.
2775         (throw_exception_sjlj): Update.
2776         (exception_messages, exception_messages_size): Remove.
2777         (throw_it): Simplify.
2778         (gdb_exception_sliced_copy): Remove.
2779         (throw_exception_cxx): Update.
2780         * cli/cli-script.c (script_from_file): Update.
2781         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2782         Update.
2783         * ada-valprint.c (ada_val_print): Update.
2784         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2785         (create_excep_cond_exprs): Update.
2786
2787 2019-04-08  Tom Tromey  <tom@tromey.com>
2788
2789         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2790         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2791         (TRY, CATCH, END_CATCH): Remove some definitions.
2792         * common/common-exceptions.c: Don't use GDB_XCPT.
2793         (catcher_list_size): Remove.
2794         (throw_exception, throw_it): Simplify.
2795
2796 2019-04-05  Tom Tromey  <tom@tromey.com>
2797
2798         Revert the header-sorting patch.
2799         * ft32-tdep.c: Revert.
2800         * frv-tdep.c: Revert.
2801         * frv-linux-tdep.c: Revert.
2802         * frame.c: Revert.
2803         * frame-unwind.c: Revert.
2804         * frame-base.c: Revert.
2805         * fork-child.c: Revert.
2806         * findvar.c: Revert.
2807         * findcmd.c: Revert.
2808         * filesystem.c: Revert.
2809         * filename-seen-cache.h: Revert.
2810         * filename-seen-cache.c: Revert.
2811         * fbsd-tdep.c: Revert.
2812         * fbsd-nat.h: Revert.
2813         * fbsd-nat.c: Revert.
2814         * f-valprint.c: Revert.
2815         * f-typeprint.c: Revert.
2816         * f-lang.c: Revert.
2817         * extension.h: Revert.
2818         * extension.c: Revert.
2819         * extension-priv.h: Revert.
2820         * expprint.c: Revert.
2821         * exec.h: Revert.
2822         * exec.c: Revert.
2823         * exceptions.c: Revert.
2824         * event-top.c: Revert.
2825         * event-loop.c: Revert.
2826         * eval.c: Revert.
2827         * elfread.c: Revert.
2828         * dwarf2read.h: Revert.
2829         * dwarf2read.c: Revert.
2830         * dwarf2loc.c: Revert.
2831         * dwarf2expr.h: Revert.
2832         * dwarf2expr.c: Revert.
2833         * dwarf2-frame.c: Revert.
2834         * dwarf2-frame-tailcall.c: Revert.
2835         * dwarf-index-write.h: Revert.
2836         * dwarf-index-write.c: Revert.
2837         * dwarf-index-common.c: Revert.
2838         * dwarf-index-cache.h: Revert.
2839         * dwarf-index-cache.c: Revert.
2840         * dummy-frame.c: Revert.
2841         * dtrace-probe.c: Revert.
2842         * disasm.h: Revert.
2843         * disasm.c: Revert.
2844         * disasm-selftests.c: Revert.
2845         * dictionary.c: Revert.
2846         * dicos-tdep.c: Revert.
2847         * demangle.c: Revert.
2848         * dcache.h: Revert.
2849         * dcache.c: Revert.
2850         * darwin-nat.h: Revert.
2851         * darwin-nat.c: Revert.
2852         * darwin-nat-info.c: Revert.
2853         * d-valprint.c: Revert.
2854         * d-namespace.c: Revert.
2855         * d-lang.c: Revert.
2856         * ctf.c: Revert.
2857         * csky-tdep.c: Revert.
2858         * csky-linux-tdep.c: Revert.
2859         * cris-tdep.c: Revert.
2860         * cris-linux-tdep.c: Revert.
2861         * cp-valprint.c: Revert.
2862         * cp-support.c: Revert.
2863         * cp-namespace.c: Revert.
2864         * cp-abi.c: Revert.
2865         * corelow.c: Revert.
2866         * corefile.c: Revert.
2867         * continuations.c: Revert.
2868         * completer.h: Revert.
2869         * completer.c: Revert.
2870         * complaints.c: Revert.
2871         * coffread.c: Revert.
2872         * coff-pe-read.c: Revert.
2873         * cli-out.h: Revert.
2874         * cli-out.c: Revert.
2875         * charset.c: Revert.
2876         * c-varobj.c: Revert.
2877         * c-valprint.c: Revert.
2878         * c-typeprint.c: Revert.
2879         * c-lang.c: Revert.
2880         * buildsym.c: Revert.
2881         * buildsym-legacy.c: Revert.
2882         * build-id.h: Revert.
2883         * build-id.c: Revert.
2884         * btrace.c: Revert.
2885         * bsd-uthread.c: Revert.
2886         * breakpoint.h: Revert.
2887         * breakpoint.c: Revert.
2888         * break-catch-throw.c: Revert.
2889         * break-catch-syscall.c: Revert.
2890         * break-catch-sig.c: Revert.
2891         * blockframe.c: Revert.
2892         * block.c: Revert.
2893         * bfin-tdep.c: Revert.
2894         * bfin-linux-tdep.c: Revert.
2895         * bfd-target.c: Revert.
2896         * bcache.c: Revert.
2897         * ax-general.c: Revert.
2898         * ax-gdb.h: Revert.
2899         * ax-gdb.c: Revert.
2900         * avr-tdep.c: Revert.
2901         * auxv.c: Revert.
2902         * auto-load.c: Revert.
2903         * arm-wince-tdep.c: Revert.
2904         * arm-tdep.c: Revert.
2905         * arm-symbian-tdep.c: Revert.
2906         * arm-pikeos-tdep.c: Revert.
2907         * arm-obsd-tdep.c: Revert.
2908         * arm-nbsd-tdep.c: Revert.
2909         * arm-nbsd-nat.c: Revert.
2910         * arm-linux-tdep.c: Revert.
2911         * arm-linux-nat.c: Revert.
2912         * arm-fbsd-tdep.c: Revert.
2913         * arm-fbsd-nat.c: Revert.
2914         * arm-bsd-tdep.c: Revert.
2915         * arch-utils.c: Revert.
2916         * arc-tdep.c: Revert.
2917         * arc-newlib-tdep.c: Revert.
2918         * annotate.h: Revert.
2919         * annotate.c: Revert.
2920         * amd64-windows-tdep.c: Revert.
2921         * amd64-windows-nat.c: Revert.
2922         * amd64-tdep.c: Revert.
2923         * amd64-sol2-tdep.c: Revert.
2924         * amd64-obsd-tdep.c: Revert.
2925         * amd64-obsd-nat.c: Revert.
2926         * amd64-nbsd-tdep.c: Revert.
2927         * amd64-nbsd-nat.c: Revert.
2928         * amd64-nat.c: Revert.
2929         * amd64-linux-tdep.c: Revert.
2930         * amd64-linux-nat.c: Revert.
2931         * amd64-fbsd-tdep.c: Revert.
2932         * amd64-fbsd-nat.c: Revert.
2933         * amd64-dicos-tdep.c: Revert.
2934         * amd64-darwin-tdep.c: Revert.
2935         * amd64-bsd-nat.c: Revert.
2936         * alpha-tdep.c: Revert.
2937         * alpha-obsd-tdep.c: Revert.
2938         * alpha-nbsd-tdep.c: Revert.
2939         * alpha-mdebug-tdep.c: Revert.
2940         * alpha-linux-tdep.c: Revert.
2941         * alpha-linux-nat.c: Revert.
2942         * alpha-bsd-tdep.c: Revert.
2943         * alpha-bsd-nat.c: Revert.
2944         * aix-thread.c: Revert.
2945         * agent.c: Revert.
2946         * addrmap.c: Revert.
2947         * ada-varobj.c: Revert.
2948         * ada-valprint.c: Revert.
2949         * ada-typeprint.c: Revert.
2950         * ada-tasks.c: Revert.
2951         * ada-lang.c: Revert.
2952         * aarch64-tdep.c: Revert.
2953         * aarch64-ravenscar-thread.c: Revert.
2954         * aarch64-newlib-tdep.c: Revert.
2955         * aarch64-linux-tdep.c: Revert.
2956         * aarch64-linux-nat.c: Revert.
2957         * aarch64-fbsd-tdep.c: Revert.
2958         * aarch64-fbsd-nat.c: Revert.
2959         * aarch32-linux-nat.c: Revert.
2960
2961 2019-04-05  Tom Tromey  <tom@tromey.com>
2962
2963         * ft32-tdep.c: Sort headers.
2964         * frv-tdep.c: Sort headers.
2965         * frv-linux-tdep.c: Sort headers.
2966         * frame.c: Sort headers.
2967         * frame-unwind.c: Sort headers.
2968         * frame-base.c: Sort headers.
2969         * fork-child.c: Sort headers.
2970         * findvar.c: Sort headers.
2971         * findcmd.c: Sort headers.
2972         * filesystem.c: Sort headers.
2973         * filename-seen-cache.h: Sort headers.
2974         * filename-seen-cache.c: Sort headers.
2975         * fbsd-tdep.c: Sort headers.
2976         * fbsd-nat.h: Sort headers.
2977         * fbsd-nat.c: Sort headers.
2978         * f-valprint.c: Sort headers.
2979         * f-typeprint.c: Sort headers.
2980         * f-lang.c: Sort headers.
2981         * extension.h: Sort headers.
2982         * extension.c: Sort headers.
2983         * extension-priv.h: Sort headers.
2984         * expprint.c: Sort headers.
2985         * exec.h: Sort headers.
2986         * exec.c: Sort headers.
2987         * exceptions.c: Sort headers.
2988         * event-top.c: Sort headers.
2989         * event-loop.c: Sort headers.
2990         * eval.c: Sort headers.
2991         * elfread.c: Sort headers.
2992         * dwarf2read.h: Sort headers.
2993         * dwarf2read.c: Sort headers.
2994         * dwarf2loc.c: Sort headers.
2995         * dwarf2expr.h: Sort headers.
2996         * dwarf2expr.c: Sort headers.
2997         * dwarf2-frame.c: Sort headers.
2998         * dwarf2-frame-tailcall.c: Sort headers.
2999         * dwarf-index-write.h: Sort headers.
3000         * dwarf-index-write.c: Sort headers.
3001         * dwarf-index-common.c: Sort headers.
3002         * dwarf-index-cache.h: Sort headers.
3003         * dwarf-index-cache.c: Sort headers.
3004         * dummy-frame.c: Sort headers.
3005         * dtrace-probe.c: Sort headers.
3006         * disasm.h: Sort headers.
3007         * disasm.c: Sort headers.
3008         * disasm-selftests.c: Sort headers.
3009         * dictionary.c: Sort headers.
3010         * dicos-tdep.c: Sort headers.
3011         * demangle.c: Sort headers.
3012         * dcache.h: Sort headers.
3013         * dcache.c: Sort headers.
3014         * darwin-nat.h: Sort headers.
3015         * darwin-nat.c: Sort headers.
3016         * darwin-nat-info.c: Sort headers.
3017         * d-valprint.c: Sort headers.
3018         * d-namespace.c: Sort headers.
3019         * d-lang.c: Sort headers.
3020         * ctf.c: Sort headers.
3021         * csky-tdep.c: Sort headers.
3022         * csky-linux-tdep.c: Sort headers.
3023         * cris-tdep.c: Sort headers.
3024         * cris-linux-tdep.c: Sort headers.
3025         * cp-valprint.c: Sort headers.
3026         * cp-support.c: Sort headers.
3027         * cp-namespace.c: Sort headers.
3028         * cp-abi.c: Sort headers.
3029         * corelow.c: Sort headers.
3030         * corefile.c: Sort headers.
3031         * continuations.c: Sort headers.
3032         * completer.h: Sort headers.
3033         * completer.c: Sort headers.
3034         * complaints.c: Sort headers.
3035         * coffread.c: Sort headers.
3036         * coff-pe-read.c: Sort headers.
3037         * cli-out.h: Sort headers.
3038         * cli-out.c: Sort headers.
3039         * charset.c: Sort headers.
3040         * c-varobj.c: Sort headers.
3041         * c-valprint.c: Sort headers.
3042         * c-typeprint.c: Sort headers.
3043         * c-lang.c: Sort headers.
3044         * buildsym.c: Sort headers.
3045         * buildsym-legacy.c: Sort headers.
3046         * build-id.h: Sort headers.
3047         * build-id.c: Sort headers.
3048         * btrace.c: Sort headers.
3049         * bsd-uthread.c: Sort headers.
3050         * breakpoint.h: Sort headers.
3051         * breakpoint.c: Sort headers.
3052         * break-catch-throw.c: Sort headers.
3053         * break-catch-syscall.c: Sort headers.
3054         * break-catch-sig.c: Sort headers.
3055         * blockframe.c: Sort headers.
3056         * block.c: Sort headers.
3057         * bfin-tdep.c: Sort headers.
3058         * bfin-linux-tdep.c: Sort headers.
3059         * bfd-target.c: Sort headers.
3060         * bcache.c: Sort headers.
3061         * ax-general.c: Sort headers.
3062         * ax-gdb.h: Sort headers.
3063         * ax-gdb.c: Sort headers.
3064         * avr-tdep.c: Sort headers.
3065         * auxv.c: Sort headers.
3066         * auto-load.c: Sort headers.
3067         * arm-wince-tdep.c: Sort headers.
3068         * arm-tdep.c: Sort headers.
3069         * arm-symbian-tdep.c: Sort headers.
3070         * arm-pikeos-tdep.c: Sort headers.
3071         * arm-obsd-tdep.c: Sort headers.
3072         * arm-nbsd-tdep.c: Sort headers.
3073         * arm-nbsd-nat.c: Sort headers.
3074         * arm-linux-tdep.c: Sort headers.
3075         * arm-linux-nat.c: Sort headers.
3076         * arm-fbsd-tdep.c: Sort headers.
3077         * arm-fbsd-nat.c: Sort headers.
3078         * arm-bsd-tdep.c: Sort headers.
3079         * arch-utils.c: Sort headers.
3080         * arc-tdep.c: Sort headers.
3081         * arc-newlib-tdep.c: Sort headers.
3082         * annotate.h: Sort headers.
3083         * annotate.c: Sort headers.
3084         * amd64-windows-tdep.c: Sort headers.
3085         * amd64-windows-nat.c: Sort headers.
3086         * amd64-tdep.c: Sort headers.
3087         * amd64-sol2-tdep.c: Sort headers.
3088         * amd64-obsd-tdep.c: Sort headers.
3089         * amd64-obsd-nat.c: Sort headers.
3090         * amd64-nbsd-tdep.c: Sort headers.
3091         * amd64-nbsd-nat.c: Sort headers.
3092         * amd64-nat.c: Sort headers.
3093         * amd64-linux-tdep.c: Sort headers.
3094         * amd64-linux-nat.c: Sort headers.
3095         * amd64-fbsd-tdep.c: Sort headers.
3096         * amd64-fbsd-nat.c: Sort headers.
3097         * amd64-dicos-tdep.c: Sort headers.
3098         * amd64-darwin-tdep.c: Sort headers.
3099         * amd64-bsd-nat.c: Sort headers.
3100         * alpha-tdep.c: Sort headers.
3101         * alpha-obsd-tdep.c: Sort headers.
3102         * alpha-nbsd-tdep.c: Sort headers.
3103         * alpha-mdebug-tdep.c: Sort headers.
3104         * alpha-linux-tdep.c: Sort headers.
3105         * alpha-linux-nat.c: Sort headers.
3106         * alpha-bsd-tdep.c: Sort headers.
3107         * alpha-bsd-nat.c: Sort headers.
3108         * aix-thread.c: Sort headers.
3109         * agent.c: Sort headers.
3110         * addrmap.c: Sort headers.
3111         * ada-varobj.c: Sort headers.
3112         * ada-valprint.c: Sort headers.
3113         * ada-typeprint.c: Sort headers.
3114         * ada-tasks.c: Sort headers.
3115         * ada-lang.c: Sort headers.
3116         * aarch64-tdep.c: Sort headers.
3117         * aarch64-ravenscar-thread.c: Sort headers.
3118         * aarch64-newlib-tdep.c: Sort headers.
3119         * aarch64-linux-tdep.c: Sort headers.
3120         * aarch64-linux-nat.c: Sort headers.
3121         * aarch64-fbsd-tdep.c: Sort headers.
3122         * aarch64-fbsd-nat.c: Sort headers.
3123         * aarch32-linux-nat.c: Sort headers.
3124
3125 2019-04-04  Tom Tromey  <tom@tromey.com>
3126
3127         * varobj.c (varobj_create): Update.
3128         * rust-exp.y (struct rust_parser) <update_innermost_block,
3129         lookup_symbol>: New methods.
3130         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3131         Rename.
3132         (rust_parser::rust_lookup_type)
3133         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3134         * printcmd.c (display_command, do_one_display): Update.
3135         * parser-defs.h (struct parser_state) <parser_state>: Add
3136         "tracker" parameter.
3137         (block_tracker): New member.
3138         (class innermost_block_tracker) <innermost_block_tracker>: Add
3139         "types" parameter.
3140         <reset>: Remove method.
3141         (innermost_block): Don't declare.
3142         (null_post_parser): Update.
3143         * parse.c (innermost_block): Remove global.
3144         (write_dollar_variable): Update.
3145         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3146         Remove "tracker_types" parameter.
3147         (parse_expression): Add "tracker" parameter.
3148         (parse_expression_for_completion): Update.
3149         (null_post_parser): Add "tracker" parameter.
3150         * p-exp.y: Update rules.
3151         * m2-exp.y: Update rules.
3152         * language.h (struct language_defn) <la_post_parser>: Add
3153         "tracker" parameter.
3154         * go-exp.y: Update rules.
3155         * f-exp.y: Update rules.
3156         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3157         parameter.
3158         * d-exp.y: Update rules.
3159         * c-exp.y: Update rules.
3160         * breakpoint.c (set_breakpoint_condition): Create an
3161         innermost_block_tracker.
3162         (watch_command_1): Likewise.
3163         * ada-lang.c (resolve): Add "tracker" parameter.
3164         (resolve_subexp): Likewise.
3165         * ada-exp.y (write_var_from_sym): Update.
3166
3167 2019-04-04  Tom Tromey  <tom@tromey.com>
3168
3169         * type-stack.h: New file.
3170         * type-stack.c: New file.
3171         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3172         type-stack.h.
3173         (insert_into_type_stack, insert_type, push_type, push_type_int)
3174         (insert_type_address_space, pop_type, pop_type_int)
3175         (pop_typelist, pop_type_stack, append_type_stack)
3176         (push_type_stack, get_type_stack, push_typelist)
3177         (follow_type_instance_flags, follow_types): Don't declare.
3178         * parse.c (type_stack): Remove global.
3179         (parse_exp_in_context): Update.
3180         (insert_into_type_stack, insert_type, push_type, push_type_int)
3181         (insert_type_address_space, pop_type, pop_type_int)
3182         (pop_typelist, pop_type_stack, append_type_stack)
3183         (push_type_stack, get_type_stack, push_typelist)
3184         (follow_type_instance_flags, follow_types): Remove (moved to
3185         type-stack.c).
3186         * f-exp.y (type_stack): New global.
3187         Update rules.
3188         (push_kind_type, f_parse): Update.
3189         * d-exp.y (type_stack): New global.
3190         Update rules.
3191         (d_parse): Update.
3192         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3193         Update rules.
3194         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3195         (HFILES_NO_SRCDIR): Add type-stack.h.
3196
3197 2019-04-04  Tom Tromey  <tom@tromey.com>
3198
3199         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3200         (rust_parser::convert_ast_to_expression, rust_parse)
3201         (rust_lex_test_completion, rust_lex_tests): Update.
3202         * parser-defs.h (struct expr_completion_state): New.
3203         (struct parser_state) <parser_state>: Add completion parameter.
3204         <mark_struct_expression, mark_completion_tag>: New methods.
3205         <parse_completion, m_completion_state>: New members.
3206         (prefixify_expression, null_post_parser): Update.
3207         (mark_struct_expression, mark_completion_tag): Don't declare.
3208         * parse.c (parse_completion, expout_last_struct)
3209         (expout_tag_completion_type, expout_completion_name): Remove
3210         globals.
3211         (parser_state::mark_struct_expression)
3212         (parser_state::mark_completion_tag): Now methods.
3213         (prefixify_expression): Add last_struct parameter.
3214         (prefixify_subexp): Likewise.
3215         (parse_exp_1): Update.
3216         (parse_exp_in_context): Add cstate parameter.  Update.
3217         (parse_expression_for_completion): Create an
3218         expr_completion_state.
3219         (null_post_parser): Add "completion" parameter.
3220         * p-exp.y: Update rules.
3221         (yylex): Update.
3222         * language.h (struct language_defn) <la_post_parser>: Add
3223         "completing" parameter.
3224         * go-exp.y: Update rules.
3225         (lex_one_token): Update.
3226         * expression.h (parse_completion): Don't declare.
3227         * d-exp.y: Update rules.
3228         (lex_one_token): Update rules.
3229         * c-exp.y: Update rules.
3230         (lex_one_token): Update.
3231         * ada-lang.c (resolve): Add "parse_completion" parameter.
3232         (resolve_subexp): Likewise.
3233         (ada_resolve_function): Likewise.
3234
3235 2019-04-04  Tom Tromey  <tom@tromey.com>
3236
3237         * parser-defs.h (struct parser_state) <start_arglist,
3238         end_arglist>: New methods.
3239         <arglist_len, m_funcall_chain>: New members.
3240         (arglist_len, start_arglist, end_arglist): Don't declare.
3241         * parse.c (arglist_len, funcall_chain): Remove global.
3242         (start_arglist, end_arglist): Remove functions.
3243         (parse_exp_in_context): Update.
3244         * p-exp.y: Update rules.
3245         * m2-exp.y: Update rules.
3246         * go-exp.y: Update rules.
3247         * f-exp.y: Update rules.
3248         * d-exp.y: Update rules.
3249         * c-exp.y: Update rules.
3250
3251 2019-04-04  Tom Tromey  <tom@tromey.com>
3252
3253         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3254         lex_operator, push_back>: New methods.
3255         Update all rules.
3256         (rust_parser::lex_hex, lex_escape): Rename and update.
3257         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3258         (rust_parser::lex_operator): Rename and update.
3259         (rust_parser::lex_number, rustyylex, rustyyerror)
3260         (rust_lex_test_init, rust_lex_test_sequence)
3261         (rust_lex_test_push_back, rust_lex_tests): Update.
3262         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3263         parameter.
3264         <lexptr, prev_lexptr>: New members.
3265         (lexptr, prev_lexptr): Don't declare.
3266         * parse.c (lexptr, prev_lexptr): Remove globals.
3267         (parse_exp_in_context): Update.
3268         * p-exp.y (yylex, yyerror): Update.
3269         * m2-exp.y (parse_number, yylex, yyerror): Update.
3270         * go-exp.y (lex_one_token, yyerror): Update.
3271         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3272         * d-exp.y (lex_one_token, yyerror): Update.
3273         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3274         (lex_one_token, yyerror): Update.
3275         * ada-lex.l (YY_INPUT): Update.
3276         (rewind_to_char): Update.
3277         * ada-exp.y (yyerror): Update.
3278
3279 2019-04-04  Tom Tromey  <tom@tromey.com>
3280
3281         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3282         * parser-defs.h (struct parser_state) <parser_state>: Add new
3283         parameter.
3284         <comma_terminates>: New member.
3285         (comma_terminates): Don't declare global.
3286         * parse.c (comma_terminates): Remove global.
3287         (parse_exp_in_context): Update.
3288         * p-exp.y (yylex): Update.
3289         * m2-exp.y (yylex): Update.
3290         * go-exp.y (lex_one_token): Update.
3291         * f-exp.y (yylex): Update.
3292         * d-exp.y (lex_one_token): Update.
3293         * c-exp.y (lex_one_token): Update.
3294         * ada-lex.l: Update.
3295
3296 2019-04-04  Tom Tromey  <tom@tromey.com>
3297
3298         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3299         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3300         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3301         * parser-defs.h (paren_depth): Don't declare.
3302         * parse.c (paren_depth): Remove global.
3303         (parse_exp_in_context): Update.
3304         * p-exp.y (paren_depth): New global.
3305         (pascal_parse): Initialize it.
3306         * m2-exp.y (paren_depth): New global.
3307         (m2_parse): Initialize it.
3308         * go-exp.y (paren_depth): New global.
3309         (go_parse): Initialize it.
3310         * f-exp.y (paren_depth): New global.
3311         (f_parse): Initialize it.
3312         * d-exp.y (paren_depth): New global.
3313         (d_parse): Initialize it.
3314         * c-exp.y (paren_depth): New global.
3315         (c_parse): Initialize it.
3316         * ada-lex.l (paren_depth): New global.
3317         (lexer_init): Initialize it.
3318
3319 2019-04-04  Tom Tromey  <tom@tromey.com>
3320
3321         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3322         (rust_parser::convert_ast_to_type)
3323         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3324         * parser-defs.h (struct parser_state) <parser_state>: Add
3325         parameters.  Initialize new members.
3326         <expression_context_block, expression_context_pc>: New members.
3327         * parse.c (expression_context_block, expression_context_pc):
3328         Remove globals.
3329         (parse_exp_in_context): Update.
3330         * p-exp.y: Update all rules.
3331         (yylex): Update.
3332         * m2-exp.y: Update all rules.
3333         (yylex): Update.
3334         * go-exp.y (yylex): Update.
3335         * f-exp.y (yylex): Update.
3336         * d-exp.y: Update all rules.
3337         (yylex): Update.
3338         * c-exp.y: Update all rules.
3339         (lex_one_token, classify_name, yylex, c_parse): Update.
3340         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3341
3342 2019-04-04  Tom Tromey  <tom@tromey.com>
3343
3344         * gdbarch.h, gdbarch.c: Rebuild.
3345         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3346         * stap-probe.h:
3347         (struct stap_parse_info): Replace "parser_state" with
3348         "expr_builder".
3349         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3350         (parser_state): New class.
3351         * parse.c (expr_builder): Rename.
3352         (expr_builder::release): Rename.
3353         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3354         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3355         (write_exp_elt_longcst, write_exp_elt_floatcst)
3356         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3357         (write_exp_string_vector, write_exp_bitstring)
3358         (write_exp_msymbol, mark_struct_expression)
3359         (write_dollar_variable)
3360         (insert_type_address_space, increase_expout_size): Replace
3361         "parser_state" with "expr_builder".
3362         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3363         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3364         "parser_state" with "expr_builder".
3365
3366 2019-04-04  Tom Tromey  <tom@tromey.com>
3367
3368         * rust-exp.y: Replace "parse_language" with method call.
3369         * p-exp.y:
3370         (yylex): Replace "parse_language" with method call.
3371         * m2-exp.y:
3372         (yylex): Replace "parse_language" with method call.
3373         * go-exp.y (classify_name): Replace "parse_language" with method
3374         call.
3375         * f-exp.y (yylex): Replace "parse_language" with method call.
3376         * d-exp.y (lex_one_token): Replace "parse_language" with method
3377         call.
3378         * c-exp.y:
3379         (lex_one_token, classify_name, yylex): Replace "parse_language"
3380         with method call.
3381         * ada-exp.y (find_primitive_type, type_char)
3382         (type_system_address): Replace "parse_language" with method call.
3383
3384 2019-04-04  Tom Tromey  <tom@tromey.com>
3385
3386         * rust-exp.y: Replace "parse_gdbarch" with method call.
3387         * parse.c (write_dollar_variable, insert_type_address_space):
3388         Replace "parse_gdbarch" with method call.
3389         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3390         call.
3391         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3392         call.
3393         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3394         "parse_gdbarch" with method call.
3395         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3396         with method call.
3397         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3398         "parse_gdbarch" with method call.
3399         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3400         "parse_gdbarch" with method call.
3401         * c-exp.y (parse_type, parse_number, classify_name): Replace
3402         "parse_gdbarch" with method call.
3403         * ada-lex.l: Replace "parse_gdbarch" with method call.
3404         * ada-exp.y (parse_type, find_primitive_type, type_char)
3405         (type_system_address): Replace "parse_gdbarch" with method call.
3406
3407 2019-04-04  Tom Tromey  <tom@tromey.com>
3408
3409         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3410         * stap-probe.c (stap_parse_argument): Update.
3411         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3412         initial_size parameter.
3413         * rust-exp.y (rust_lex_tests): Update.
3414         * parse.c (parser_state): Update.
3415         (parse_exp_in_context): Update.
3416         * parser-defs.h (struct parser_state) <parser_state>: Remove
3417         "initial_size" parameter.
3418
3419 2019-04-04  Tom Tromey  <tom@tromey.com>
3420
3421         * parser-defs.h (increase_expout_size): Don't declare.
3422         * parse.c (increase_expout_size): Now static.
3423
3424 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3425
3426         * gnu-nat.c (gnu_nat_target::wait): Fix
3427         target_waitstatus_to_string call.
3428
3429 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * eval.c (evaluate_subexp_standard): Handle internal functions
3432         during Fortran function call handling.
3433
3434 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * NEWS: Mention new internal functions.
3437         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3438         (read_base_type): Use dwarf2_init_complex_target_type.
3439         * value.c (creal_internal_fn): New function.
3440         (cimag_internal_fn): New function.
3441         (_initialize_values): Register new internal functions.
3442
3443 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3444
3445         * infrun.c (stop_all_threads): If debug_infrun, always
3446         trace the wait status after wait_one, using
3447         target_waitstatus_to_string and target_pid_to_str.
3448         (handle_inferior_event): Replace various trace of
3449         wait status kind by a single trace.
3450         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3451         wait status kind image by target_waitstatus_to_string.
3452         * target/waitstatus.c (target_waitstatus_to_string): Fix
3453         obsolete comment.
3454
3455 2019-04-01  Tom Tromey  <tromey@adacore.com>
3456
3457         PR symtab/23331:
3458         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3459
3460 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3461             Pedro Alves  <palves@redhat.com>
3462
3463         * top.c (quit_force): Call 'finalize_values'.
3464         * value.c (finalize_values): New function.
3465         * value.h (finalize_values): Declare.
3466
3467 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3468
3469         * NEWS: Announce $_gdb_major and $_gdb_minor.
3470
3471         * top.c (init_gdb_version_vars): New function.
3472         (gdb_init): Call init_gdb_version_vars.
3473
3474 2019-03-29  Tom Tromey  <tromey@adacore.com>
3475
3476         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3477         help text.  Remove dead code.
3478
3479 2019-03-29  Keith Seitz  <keiths@redhat.com>
3480
3481         From Siddhesh Poyarekar:
3482         * f-lang.h (f77_get_upperbound): Return LONGEST.
3483         (f77_get_lowerbound): Likewise.
3484         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3485         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3486         print them.
3487         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3488         plongest to format print it.
3489         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3490         (f77_get_upperbound): Likewise.
3491         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3492         LOWER_BOUND to LONGEST.
3493         (f77_create_arrayprint_offset_tbl): Likewise.
3494
3495 2019-03-29  Keith Seitz  <keiths@redhat.com>
3496
3497         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3498         %s/pulongest for TYPE_LENGTH instead of %d in format
3499         strings.
3500         * ada-typerint.c (ada_print_type): Likewise.
3501         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3502         * compile/compile-c-support.c (generate_register_struct): Likewise.
3503         * gdbtypes.c (recursive_dump_type): Likewise.
3504         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3505         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3506         instead of %d in format strings.
3507         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3508         to std::min to ULONGEST.
3509         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3510         instead of %d in format strings.
3511         * tracepoint.c (info_scope_command): Likewise.
3512         * typeprint.c (print_offset_data::update)
3513         (print_offset_data::finish): Likewise.
3514         * xtensa-tdep.c (xtensa_store_return_value)
3515         (xtensa_push_dummy_call): Likewise.
3516
3517 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3518
3519         * windows-nat.c (display_selector): Fixed format specifications
3520         for 64-bit Cygwin.
3521
3522 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3523
3524         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3525
3526 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3527
3528         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3529         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3530         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3531         (nios2_linux_init_abi): Install it.
3532
3533 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3534
3535         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3536
3537 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3538
3539         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3540
3541 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3542             Tom Tromey  <tromey@adacore.com>
3543
3544         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3545
3546 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3547
3548         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3549         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3550         method to compute the bounds of range types. Also print "[evaluated]"
3551         if the bounds' values come from a dynamic evaluation.
3552
3553 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3556         whitespace when pretty printing is on.
3557
3558 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3559
3560         * ppc-linux-nat.c: Add include.
3561
3562 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3563
3564         * NEWS: Mention AArch64 Pointer Authentication.
3565
3566 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3567
3568         * arm-linux-nat.c: Add include.
3569
3570 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3571
3572         * source-cache.c (source_cache::get_source_lines): Re-read
3573         fullname after calling open_source_file.
3574
3575 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3576
3577         * NEWS: Mention TLS support for FreeBSD.
3578
3579 2019-03-25  Tom Tromey  <tromey@adacore.com>
3580
3581         * minsyms.c (BUNCH_SIZE): Update comment.
3582         (~minimal_symbol_reader): Remove old comment.
3583         (compact_minimal_symbols): Update comment.
3584         (minimal_symbol_reader::install): Remove old comment.  Update
3585         other comments.
3586
3587 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3588
3589         * s390-linux-nat.c: Add include.
3590
3591 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3592
3593         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3594         Call linux_get_hwcap.
3595         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3596         Likewise.
3597         (aarch64_linux_get_hwcap): Remove function.
3598         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3599         declaration.
3600         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3601         linux_get_hwcap.
3602         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3603         * linux-tdep.c (linux_get_hwcap): Add function.
3604         (linux_get_hwcap2): Likewise.
3605         * linux-tdep.h (linux_get_hwcap): Add declaration.
3606         (linux_get_hwcap2): Likewise.
3607         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3608         (ppc_linux_get_hwcap2): Likewise.
3609         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3610         linux_get_hwcap.
3611         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3612         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3613         (ppc_linux_nat_target::read_description): Likewise.
3614         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3615         * s390-linux-nat.c: Likewise.
3616         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3617
3618 2019-03-24  Tom Tromey  <tom@tromey.com>
3619
3620         * ada-lang.c (standard_lookup): Simplify initialization.
3621         (ada_lookup_symbol_nonlocal): Simplify return.
3622         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3623         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3624         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3625         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3626         initialization.
3627         * solib.c (solib_global_lookup): Simplify.
3628         * symtab.c (null_block_symbol): Remove.
3629         (symbol_cache_lookup): Simplify returns.
3630         (lookup_language_this): Simplify returns.
3631         (lookup_symbol_aux): Simplify return.
3632         (lookup_local_symbol): Simplify returns.
3633         (lookup_global_symbol_from_objfile): Simplify return.
3634         (lookup_symbol_in_objfile_symtabs)
3635         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3636         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3637         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3638         * cp-namespace.c (cp_lookup_bare_symbol)
3639         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3640         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3641         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3642         (cp_lookup_symbol_via_imports): Simplify initialization.
3643         (find_symbol_in_baseclass): Likewise.
3644         * symtab.h (null_block_symbol): Remove.
3645         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3646         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3647         (d_lookup_symbol_module): Likewise.
3648         (find_symbol_in_baseclass): Simplify initialization.
3649
3650 2019-03-24  Tom Tromey  <tom@tromey.com>
3651
3652         * expression.h: Don't include symtab.h.
3653         (struct block): Forward declare.
3654
3655 2019-03-24  Tom Tromey  <tom@tromey.com>
3656
3657         * c-exp.y (typebase): Remove casts.
3658         * gdbtypes.c (lookup_unsigned_typename, )
3659         (lookup_signed_typename): Remove cast.
3660         * eval.c (parse_to_comma_and_eval): Remove cast.
3661         * parse.c (write_dollar_variable): Remove cast.
3662         * block.h (struct block) <superblock>: Now const.
3663         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3664         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3665         (map_block): Make "block" const.
3666         * symfile.h (struct quick_symbol_functions)
3667         <map_matching_symbols>: Constify block argument to "callback".
3668         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3669         const.
3670         (find_pc_sect_compunit_symtab): Make "b" const.
3671         (find_symbol_at_address): Likewise.
3672         (search_symbols): Likewise.
3673         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3674         (dw2_debug_names_lookup_symbol): Likewise.
3675         (dw2_map_matching_symbols): Update.
3676         * p-valprint.c (pascal_val_print): Remove "block".
3677         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3678         (aux_add_nonlocal_symbols): Make "block" const.
3679         (resolve_subexp): Remove cast.
3680         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3681         const.
3682         (iterate_over_file_blocks): Likewise.
3683         * f-exp.y (%union) <bval>: Remove.
3684         * coffread.c (patch_opaque_types): Make "b" const.
3685         * spu-tdep.c (spu_catch_start): Make "block" const.
3686         * c-valprint.c (print_unpacked_pointer): Remove "block".
3687         * symmisc.c (dump_symtab_1): Make "b" const.
3688         (block_depth): Make "block" const.
3689         * d-exp.y (%union) <bval>: Remove.
3690         * cp-support.h (cp_lookup_rtti_type): Update.
3691         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3692         * psymtab.c (psym_lookup_symbol): Make "block" const.
3693         (maintenance_check_psymtabs): Make "b" const.
3694         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3695         (enumerate_locals, enumerate_args): Update.
3696         * python/py-symtab.c (stpy_global_block): Make "block" const.
3697         (stpy_static_block): Likewise.
3698         * inline-frame.c (block_starting_point_at): Make "new_block"
3699         const.
3700         * block.c (find_block_in_blockvector): Make return type const.
3701         (blockvector_for_pc_sect): Make "b" const.
3702         (find_block_in_blockvector): Make "b" const.
3703
3704 2019-03-23  Tom Tromey  <tom@tromey.com>
3705
3706         * varobj.c (varobj_create): Update.
3707         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3708         * printcmd.c (display_command, do_one_display): Don't reset
3709         innermost_block.
3710         * parser-defs.h (enum innermost_block_tracker_type): Move to
3711         expression.h.
3712         (innermost_block): Update comment.
3713         * parse.c (parse_exp_1): Add tracker_types parameter.
3714         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3715         tracker_types parameter.  Reset innermost_block.
3716         (parse_exp_in_context): Remove.
3717         (parse_expression_for_completion): Update.
3718         * objfiles.c (~objfile): Don't reset expression_context_block or
3719         innermost_block.
3720         * expression.h (enum innermost_block_tracker_type): Move from
3721         parser-defs.h.
3722         (parse_exp_1): Add tracker_types parameter.
3723         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3724         reset innermost_block.
3725
3726 2019-03-23  Tom Tromey  <tom@tromey.com>
3727
3728         * objfiles.h: Include bcache.h.
3729
3730 2019-03-23  Tom Tromey  <tom@tromey.com>
3731
3732         * linespec.c (get_current_search_block): Use
3733         scoped_restore_current_language.
3734         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3735
3736 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3737             Jiong Wang  <jiong.wang@arm.com>
3738
3739         * aarch64-linux-tdep.c
3740         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3741         section.
3742         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3743
3744 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3745             Jiong Wang  <jiong.wang@arm.com>
3746
3747         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3748         instructions.
3749         (aarch64_analyze_prologue_test): Add PACIASP test.
3750         (aarch64_prologue_prev_register): Unmask PC value.
3751
3752 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3753             Jiong Wang  <jiong.wang@arm.com>
3754
3755         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3756         (aarch64_dwarf2_prev_register): Unmask PC value.
3757         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3758         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3759         DW_CFA_AARCH64_negate_ra_state.
3760         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3761
3762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3763             Jiong Wang  <jiong.wang@arm.com>
3764
3765         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3766         registers.
3767         (aarch64_pseudo_register_name): Likewise.
3768         (aarch64_pseudo_register_type): Likewise.
3769         (aarch64_pseudo_register_reggroup_p): Likewise.
3770         (aarch64_gdbarch_init): Add pauth registers.
3771         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3772         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3773         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3774         (struct gdbarch_tdep): Add regnum for ra_state.
3775
3776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3777             Jiong Wang  <jiong.wang@arm.com>
3778
3779         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3780
3781 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3782             Jiong Wang  <jiong.wang@arm.com>
3783
3784         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3785         function.
3786         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3787         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3788         (aarch64_gdbarch_init): Add puth registers.
3789         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3790         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3791         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3792
3793 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3794             Jiong Wang  <jiong.wang@arm.com>
3795
3796         * aarch64-linux-nat.c
3797         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3798         * aarch64-linux-tdep.c
3799         (aarch64_linux_core_read_description): Likewise.
3800         (aarch64_linux_get_hwcap): New function.
3801         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3802         (aarch64_linux_get_hwcap): New declaration.
3803
3804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3805             Jiong Wang  <jiong.wang@arm.com>
3806
3807         * aarch64-linux-nat.c
3808         (aarch64_linux_nat_target::read_description): Add pauth param.
3809         * aarch64-linux-tdep.c
3810         (aarch64_linux_core_read_description): Likewise.
3811         * aarch64-tdep.c (struct target_desc): Add in pauth.
3812         (aarch64_read_description): Add pauth param.
3813         (aarch64_gdbarch_init): Likewise.
3814         * aarch64-tdep.h (aarch64_read_description): Likewise.
3815         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3816         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3817         * features/Makefile: Add new files.
3818         * features/aarch64-pauth.c: New file.
3819         * features/aarch64-pauth.xml: New file.
3820
3821 2019-03-20  Tom Tromey  <tromey@adacore.com>
3822
3823         * infrun.c (handle_inferior_event): Rename from
3824         handle_inferior_event_1.  Create a scoped_value_mark.
3825         (handle_inferior_event): Remove.
3826
3827 2019-03-19  Tom Tromey  <tromey@adacore.com>
3828
3829         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3830         * infrun.h (print_stop_event): Add "displays" parameter.
3831         * infrun.c (print_stop_event): Add "displays" parameter.
3832
3833 2019-03-19  Pedro Alves  <palves@redhat.com>
3834
3835         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3836         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3837         to -1.  Fix TABs vs spaces.
3838         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3839         * tui/tui-out.h (tui_ui_out) Add intro comments.
3840         <m_line, m_start_of_line>: In-class initialize, and add describing
3841         comment.
3842
3843 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3844
3845         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3846         variable names.
3847         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3848
3849 2019-03-18  Pedro Alves  <palves@redhat.com>
3850             Eli Zaretskii <eliz@gnu.org>
3851
3852         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3853         m_line and m_start_of_line.
3854
3855 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3856
3857         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3858         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3859         it returns a newline.  This fixes a regression in TU mode, whereby
3860         the next line is output on the same screen line as the user input.
3861
3862 2019-03-18  Tom Tromey  <tromey@adacore.com>
3863
3864         * minsyms.c (minimal_symbol_reader::install): Remove call to
3865         obstack_blank.
3866
3867 2019-03-18  Pedro Alves  <palves@redhat.com>
3868
3869         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3870         New globals.
3871         (apply_style): New, factored out from ...
3872         (apply_ansi_escape): ... this.  Handle reverse video mode.
3873         (tui_set_reverse_mode): New function.
3874         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3875         * tui/tui-winsource.c (tui_show_source_line): Use
3876         tui_set_reverse_mode instead of setting A_STANDOUT.
3877         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3878         New setter methods.
3879
3880 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3881
3882         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3883         Handle tabs.
3884
3885 2019-03-18  Tom Tromey  <tromey@adacore.com>
3886
3887         * ada-lang.c (empty_array): Add "high" parameter.
3888         (ada_evaluate_subexp): Update.
3889
3890 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3891
3892         * unittests/string_view-selftests.c: Define
3893         _initialize_string_view_selftests unconditionally.
3894
3895 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3896
3897         PR gdb/24350
3898         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3899
3900 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3901
3902         PR gdb/24351
3903         * windows-nat.c (display_selector): Fix format specifiers.
3904
3905 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3906
3907         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3908         tui_refill_source_window instead of tui_refresh_win, to update the
3909         current execution line.  This fixes redisplay of the current line
3910         when stepping through the code with "next" or "step".
3911
3912 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3913
3914         * source-cache.c (source_cache::get_source_lines): Call
3915         find_source_lines to initialize s->nlines.  This fixes vertical
3916         scrolling of TUI source window when the DOWN arrow is pressed.
3917
3918 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3919
3920         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3921         linux-thread-db.c (_initialize_thread_db): Likewise.
3922
3923 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3924
3925         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3926         wclrtoeol in tui_show_source_line".  This reverts changes made in
3927         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3928
3929 2019-03-15  Tom Tromey  <tom@tromey.com>
3930
3931         * symtab.h (struct minimal_symbol): Derive from
3932         general_symbol_info.
3933         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3934         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3935         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3936         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3937         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3938         (MSYMBOL_SEARCH_NAME): Update.
3939         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3940         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3941         * minsyms.c (minimal_symbol_reader::record_full): Update.
3942
3943 2019-03-15  Tom Tromey  <tom@tromey.com>
3944
3945         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3946
3947 2019-03-15  Tom Tromey  <tom@tromey.com>
3948
3949         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3950         unique_xmalloc_ptr.
3951         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3952         Update.
3953         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3954         (build_minimal_symbol_hash_tables)
3955         (minimal_symbol_reader::install): Update.
3956
3957 2019-03-15  Tom Tromey  <tom@tromey.com>
3958
3959         * symtab.c (create_demangled_names_hash): Update.
3960         (symbol_set_names): Update.
3961         * objfiles.h (struct objfile_per_bfd_storage)
3962         <demangled_names_hash>: Now an htab_up.
3963         * objfiles.c (objfile_per_bfd_storage): Simplify.
3964
3965 2019-03-15  Tom Tromey  <tom@tromey.com>
3966
3967         * objfiles.h (struct objfile_per_bfd_storage): Declare
3968         destructor.
3969         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3970         New.
3971         (get_objfile_bfd_data): Use new.  Don't initialize
3972         language_of_main.
3973         (free_objfile_per_bfd_storage): Remove.
3974         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3975
3976 2019-03-15  Tom Tromey  <tom@tromey.com>
3977
3978         * symfile.c (reread_symbols): Update.
3979         * objfiles.c (objfile::objfile): Update.
3980         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3981         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3982         comment.
3983         (minimal_symbol_reader::install): Update.
3984         (terminate_minimal_symbol_table): Remove.
3985         * jit.c (jit_object_close_impl): Update.
3986
3987 2019-03-15  Tom Tromey  <tom@tromey.com>
3988
3989         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3990         initializations.
3991
3992 2019-03-15  Tom Tromey  <tom@tromey.com>
3993
3994         * objfiles.h (struct objfile_per_bfd_storage)
3995         <demangled_hash_languages>: Now a bitset.
3996         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3997         (lookup_minimal_symbol): Update.
3998
3999 2019-03-15  Tom Tromey  <tom@tromey.com>
4000
4001         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4002         Don't return the symbol.
4003         * coffread.c (record_minimal_symbol): Use record_full.
4004
4005 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4006
4007         The MS-Windows port of ncurses fails to switch to a color pair if
4008         one or both of the colors are the implicit default colors.  This
4009         change records the default colors when TUI is initialized, and
4010         then specifies them explicitly when a color pair uses the default
4011         colors.  This allows color styling in TUI mode on MS-Windows.
4012
4013         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4014         ncurses_norm_attr.
4015         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4016         colors in ncurses_norm_attr.
4017         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4018         "none", replace it with the default color recorded in
4019         ncurses_norm_attr.
4020
4021 2019-03-14  Tom Tromey  <tromey@adacore.com>
4022
4023         * source-cache.h (class source_cache) <get_source_lines>: Return
4024         std::string.
4025         * source-cache.c (source_cache::extract_lines): Handle case where
4026         first_pos==npos.  Return std::string.
4027         (source_cache::get_source_lines): Update.
4028
4029 2019-03-14  Tom Tromey  <tromey@adacore.com>
4030
4031         * NEWS: Add item for "style sources" commands.
4032         * source-cache.c (source_cache::get_source_lines): Check
4033         source_styling.
4034         * cli/cli-style.c (source_styling): New global.
4035         (_initialize_cli_style): Add "style sources" commands.
4036         (show_style_sources): New function.
4037         * cli/cli-style.h (source_styling): Declare.
4038
4039 2019-03-14  Pedro Alves  <palves@redhat.com>
4040             Tom Tromey  <tromey@adacore.com>
4041
4042         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4043         * tui/tui-winsource.c (tui_refill_source_window): New function,
4044         from...
4045         (tui_horizontal_source_scroll): ... here.  Move some logic.
4046         * cli/cli-style.c (set_style_enabled): Notify new observable.
4047         * tui/tui-hooks.c (tui_redisplay_source): New function.
4048         (tui_attach_detach_observers): Attach or detach
4049         tui_redisplay_source.
4050         * observable.h (source_styling_changed): New observable.
4051         * observable.c: Define source_styling_changed observable.
4052
4053 2019-03-13  Tom Tromey  <tromey@adacore.com>
4054
4055         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4056         (i386_gnu_nat_target::store_registers): Update.
4057         * target-debug.h (target_debug_print_std_string): New macro.
4058         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4059         * windows-tdep.c (display_one_tib): Update.
4060         * tui/tui-stack.c (tui_make_status_line): Update.
4061         * top.c (print_inferior_quit_action): Update.
4062         * thread.c (thr_try_catch_cmd): Update.
4063         (add_thread_with_info): Update.
4064         (thread_target_id_str): Update.
4065         (thr_try_catch_cmd): Update.
4066         (thread_command): Update.
4067         (thread_find_command): Update.
4068         * record-btrace.c (record_btrace_target::info_record)
4069         (record_btrace_resume_thread, record_btrace_target::resume)
4070         (record_btrace_cancel_resume, record_btrace_step_thread)
4071         (record_btrace_target::wait, record_btrace_target::wait)
4072         (record_btrace_target::wait, record_btrace_target::stop): Update.
4073         * progspace.c (print_program_space): Update.
4074         * process-stratum-target.c
4075         (process_stratum_target::thread_address_space): Update.
4076         * linux-fork.c (linux_fork_mourn_inferior)
4077         (detach_checkpoint_command, info_checkpoints_command)
4078         (linux_fork_context): Update.
4079         (linux_fork_detach): Update.
4080         (class scoped_switch_fork_info): Update.
4081         (delete_checkpoint_command): Update.
4082         * infrun.c (follow_fork_inferior): Update.
4083         (follow_fork_inferior): Update.
4084         (proceed_after_vfork_done): Update.
4085         (handle_vfork_child_exec_or_exit): Update.
4086         (follow_exec): Update.
4087         (displaced_step_prepare_throw): Update.
4088         (displaced_step_restore): Update.
4089         (start_step_over): Update.
4090         (resume_1): Update.
4091         (clear_proceed_status_thread): Update.
4092         (proceed): Update.
4093         (print_target_wait_results): Update.
4094         (do_target_wait): Update.
4095         (context_switch): Update.
4096         (stop_all_threads): Update.
4097         (restart_threads): Update.
4098         (finish_step_over): Update.
4099         (handle_signal_stop): Update.
4100         (switch_back_to_stepped_thread): Update.
4101         (keep_going_pass_signal): Update.
4102         (print_exited_reason): Update.
4103         (normal_stop): Update.
4104         * inferior.c (inferior_pid_to_str): Change return type.
4105         (print_selected_inferior): Update.
4106         (add_inferior): Update.
4107         (detach_inferior): Update.
4108         * dummy-frame.c (fprint_dummy_frames): Update.
4109         * dcache.c (dcache_info_1): Update.
4110         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4111         (btrace_fetch, btrace_clear): Update.
4112         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4113         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4114         type.
4115         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4116         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4117         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4118         * gdbarch.c, gdbarch.h: Rebuild.
4119         * gdbarch.sh (core_pid_to_str): Change return type.
4120         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4121         return type.
4122         (windows_nat_target::pid_to_str): Change return type.
4123         (windows_delete_thread): Update.
4124         (windows_nat_target::attach): Update.
4125         (windows_nat_target::files_info): Update.
4126         * target-delegates.c: Rebuild.
4127         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4128         return type.
4129         (sol_thread_target::pid_to_str): Change return type.
4130         * remote.c (class remote_target) <pid_to_str>: Change return
4131         type.
4132         (remote_target::pid_to_str): Change return type.
4133         (extended_remote_target::attach, remote_target::remote_stop_ns)
4134         (remote_target::remote_notif_remove_queued_reply)
4135         (remote_target::push_stop_reply, remote_target::disable_btrace):
4136         Update.
4137         (extended_remote_target::attach): Update.
4138         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4139         type.
4140         (gdbsim_target::pid_to_str): Change return type.
4141         * ravenscar-thread.c (struct ravenscar_thread_target)
4142         <pid_to_str>: Change return type.
4143         (ravenscar_thread_target::pid_to_str): Change return type.
4144         * procfs.c (class procfs_target) <pid_to_str>: Change return
4145         type.
4146         (procfs_target::pid_to_str): Change return type.
4147         (procfs_target::attach): Update.
4148         (procfs_target::detach): Update.
4149         (procfs_target::fetch_registers): Update.
4150         (procfs_target::store_registers): Update.
4151         (procfs_target::wait): Update.
4152         (procfs_target::files_info): Update.
4153         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4154         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4155         return type.
4156         (nto_procfs_target::pid_to_str): Change return type.
4157         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4158         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4159         return type.
4160         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4161         (exit_lwp): Update.
4162         (attach_proc_task_lwp_callback, get_detach_signal)
4163         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4164         (linux_nat_target::resume, wait_lwp, stop_callback)
4165         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4166         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4167         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4168         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4169         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4170         type.
4171         (inf_ptrace_target::attach): Update.
4172         (inf_ptrace_target::files_info): Update.
4173         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4174         type.
4175         (go32_nat_target::pid_to_str): Change return type.
4176         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4177         (gnu_nat_target::wait): Update.
4178         (gnu_nat_target::wait): Update.
4179         (gnu_nat_target::resume): Update.
4180         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4181         (fbsd_nat_target::wait): Update.
4182         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4183         type.
4184         (darwin_nat_target::attach): Update.
4185         * corelow.c (class core_target) <pid_to_str>: Change return type.
4186         (core_target::pid_to_str): Change return type.
4187         * target.c (normal_pid_to_str): Change return type.
4188         (default_pid_to_str): Likewise.
4189         (target_pid_to_str): Change return type.
4190         (target_translate_tls_address): Update.
4191         (target_announce_detach): Update.
4192         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4193         return type.
4194         (bsd_uthread_target::pid_to_str): Change return type.
4195         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4196         type.
4197         (bsd_kvm_target::pid_to_str): Change return type.
4198         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4199         return type.
4200         (aix_thread_target::pid_to_str): Change return type.
4201         * target.h (struct target_ops) <pid_to_str>: Change return type.
4202         (target_pid_to_str, normal_pid_to_str): Likewise.
4203         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4204         type.
4205         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4206         type.
4207         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4208         return type.
4209         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4210         type.
4211         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4212         type.
4213         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4214         return type.
4215
4216 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4217
4218         * NEWS: Mention that the new default MI version is 3.  Mention
4219         changes to the output of commands and events that deal with
4220         multi-location breakpoints.
4221         * breakpoint.c: Include "mi/mi-out.h".
4222         (print_one_breakpoint): Change output syntax if using MI version
4223         >= 3.
4224         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4225         New.
4226         (mi_multi_location_breakpoint_output_fixed): New.
4227         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4228         (mi_cmd_fix_multi_location_breakpoint_output): New.
4229         (mi_multi_location_breakpoint_output_fixed): New.
4230         * mi/mi-cmds.c (mi_cmds): Register command
4231         -fix-multi-location-breakpoint-output.
4232         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4233         interpreter "mi".
4234
4235 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4236
4237         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4238         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4239         instantiate mi_ui_out based on interpreter name.
4240         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4241         * mi/mi-main.c (mi_load_progress): Likewise.
4242
4243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4244
4245         * NEWS: Combine separate "New targets" sections for 8.3.
4246
4247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4248
4249         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4250         (ppcfbsd_init_abi): Install gdbarch
4251         "fetch_tls_load_module_address" and "get_thread_local_address"
4252         methods.
4253
4254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4255
4256         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4257         (riscv_fbsd_init_abi): Install gdbarch
4258         "fetch_tls_load_module_address" and "get_thread_local_address"
4259         methods.
4260
4261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4262
4263         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4264         (i386fbsd_init_abi): Install gdbarch
4265         "fetch_tls_load_module_address" and "get_thread_local_address"
4266         methods.
4267
4268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4269
4270         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4271         (amd64fbsd_init_abi): Install gdbarch
4272         "fetch_tls_load_module_address" and "get_thread_local_address"
4273         methods.
4274
4275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4276
4277         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4278         (struct fbsd_pspace_data): New type.
4279         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4280         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4281         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4282         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4283         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4284
4285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4286
4287         * gdbtypes.c (lookup_struct_elt): New function.
4288         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4289         * gdbtypes.h (struct struct_elt): New type.
4290         (lookup_struct_elt): New prototype.
4291
4292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4293
4294         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4295         remove disabled code block.
4296
4297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4298
4299         * gdbarch.sh (get_thread_local_address): New method.
4300         * gdbarch.h, gdbarch.c: Regenerate.
4301         * target.c (target_translate_tls_address): Use
4302         gdbarch_get_thread_local_address if present instead of
4303         target::get_thread_local_address.
4304
4305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4306
4307         * target.h (target::get_thread_local_address): Update comment.
4308
4309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4310
4311         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4312         objfile->separate_debug_objfile_backlink if not NULL.
4313
4314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4315
4316         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4317         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4318         (amd64bsd_store_inferior_registers): Likewise.
4319         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4320         Enable segment base registers.
4321         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4322         PT_GETFSBASE and PT_GETGSBASE.
4323         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4324         PT_SETGSBASE.
4325         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4326         segment base registers.
4327         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4328
4329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4332         Update calls to i386_target_description to add 'segments'
4333         parameter.
4334         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4335         add segment base registers.
4336         * arch/i386.c (i386_create_target_description): Add 'segments'
4337         parameter to enable segment base registers.
4338         * arch/i386.h (i386_create_target_description): Likewise.
4339         * features/i386/32bit-segments.xml: New file.
4340         * features/i386/32bit-segments.c: Generate.
4341         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4342         call to i386_target_description to add 'segments' parameter.
4343         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4344         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4345         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4346         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4347         if feature is present.
4348         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4349         Add 'segments' parameter to call to i386_target_description.
4350         (i386_target_description): Add 'segments' parameter to enable
4351         segment base registers.
4352         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4353         to call to i386_target_description.
4354         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4355         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4356         Define I386_NUM_REGS.
4357         (i386_target_description): Add 'segments' parameter to enable
4358         segment base registers.
4359
4360 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4361
4362         PR/24325
4363         * source-cache.c: #undef open and close, to avoid unresolved
4364         externals during linking.
4365
4366 2019-03-12  Tom Tromey  <tromey@adacore.com>
4367
4368         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4369         const.  Add initializers.
4370         (_initialize_remote): Don't initialize ptid globals.
4371
4372 2019-03-12  Pedro Alves  <palves@redhat.com>
4373
4374         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4375
4376 2019-03-12  Pedro Alves  <palves@redhat.com>
4377
4378         * cp-name-parser.y (main): Remove unused 'len' variable.
4379
4380 2019-03-12  Tom Tromey  <tromey@adacore.com>
4381
4382         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4383         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4384
4385 2019-03-12  Tom Tromey  <tromey@adacore.com>
4386
4387         * linux-nat.c (iterate_over_lwps): Update.
4388         (stop_callback): Remove parameter.
4389         (stop_wait_callback, detach_callback, resume_set_callback)
4390         (select_singlestep_lwp_callback, set_ignore_sigint)
4391         (status_callback, resumed_callback, resume_clear_callback)
4392         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4393         data parameter.
4394         (linux_nat_target::detach, linux_nat_target::resume)
4395         (linux_stop_and_wait_all_lwps, select_event_lwp)
4396         (linux_nat_filter_event, linux_nat_wait_1)
4397         (linux_nat_target::kill, linux_nat_target::stop)
4398         (linux_nat_target::stop): Update.
4399         (linux_nat_resume_callback): Change type.
4400         (resume_stopped_resumed_lwps, count_events_callback)
4401         (select_event_lwp_callback): Likewise.
4402         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4403         * arm-linux-nat.c (struct update_registers_data): Remove.
4404         (update_registers_callback): Change type.
4405         (arm_linux_insert_hw_breakpoint1): Update.
4406         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4407         parameter.
4408         (x86_linux_dr_set_addr): Update.
4409         (x86_linux_dr_set_control): Update.
4410         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4411         (iterate_over_lwps): Use gdb::function_view.
4412         * nat/aarch64-linux-hw-point.c (struct
4413         aarch64_dr_update_callback_param): Remove.
4414         (debug_reg_change_callback): Change type.
4415         (aarch64_notify_debug_reg_change): Update.
4416         * s390-linux-nat.c (s390_refresh_per_info): Update.
4417
4418 2019-03-11  Tom Tromey  <tromey@adacore.com>
4419
4420         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4421         redundant assignment to "this_cu".
4422
4423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4424
4425         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4426
4427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4428
4429         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4430         from...
4431         (rank_one_type): ... this.
4432
4433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4434
4435         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4436         from...
4437         (rank_one_type): ... this.
4438
4439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4440
4441         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4442         from...
4443         (rank_one_type): ... this.
4444
4445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4446
4447         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4448         from...
4449         (rank_one_type): ... this.
4450
4451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4452
4453         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4454         from...
4455         (rank_one_type): ... this.
4456
4457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4460         from...
4461         (rank_one_type): ... this.
4462
4463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4464
4465         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4466         from...
4467         (rank_one_type): ... this.
4468
4469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4470
4471         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4472         from...
4473         (rank_one_type): ... this.
4474
4475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4476
4477         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4478         from...
4479         (rank_one_type): ... this.
4480
4481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4482
4483         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4484         from...
4485         (rank_one_type): ... this.
4486
4487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4488
4489         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4490         from...
4491         (rank_one_type): ... this.
4492
4493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4494
4495         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4496         from...
4497         (rank_one_type): ... this.
4498
4499 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4500
4501         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4502         inferior-events' shows the example events.
4503
4504 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4505
4506         Support styling on native MS-Windows console
4507
4508         PR/24315
4509         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4510         on MS-Windows if $TERM is not defined.
4511
4512         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4513
4514         * posix-hdep.c (gdb_console_fputs):
4515         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4516         functions.
4517         * ui-file.h (gdb_console_fputs): Add prototype.
4518
4519         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4520         back to fputs only if the former returns zero.
4521
4522 2019-03-07  Tom Tromey  <tom@tromey.com>
4523
4524         * symmisc.c (print_symbol_bcache_statistics): Update.
4525         (print_objfile_statistics): Update.
4526         * symfile.c (allocate_symtab): Update.
4527         * stabsread.c: Don't include bcache.h.
4528         * psymtab.h (struct psymbol_bcache): Don't declare.
4529         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4530         (psymbol_bcache_init, psymbol_bcache_free)
4531         (psymbol_bcache_get_bcache): Don't declare.
4532         * psymtab.c (struct psymbol_bcache): Remove.
4533         (psymtab_storage::psymtab_storage): Update.
4534         (psymtab_storage::~psymtab_storage): Update.
4535         (psymbol_bcache_init, psymbol_bcache_free)
4536         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4537         (add_psymbol_to_bcache): Update.
4538         (allocate_psymtab): Update.
4539         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4540         macro_cache>: No longer pointers.
4541         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4542         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4543         * macrotab.c (macro_bcache): Update.
4544         * macroexp.c: Don't include bcache.h.
4545         * gdbtypes.c (check_types_worklist): Update.
4546         (types_deeply_equal): Remove TRY/CATCH.  Update.
4547         * elfread.c (elf_symtab_read): Update.
4548         * dwarf2read.c: Don't include bcache.h.
4549         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4550         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4551         (print_bcache_statistics, bcache_memory_used): Don't declare.
4552         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4553         methods.  Rename all data members.
4554         * bcache.c (struct bcache): Move to bcache.h.
4555         (bcache::expand_hash_table): Rename from expand_hash_table.
4556         (bcache): Remove.
4557         (bcache::insert): Rename from bcache_full.
4558         (bcache::compare): Rename from bcache_compare.
4559         (bcache_xmalloc): Remove.
4560         (bcache::~bcache): Rename from bcache_xfree.
4561         (bcache::print_statistics): Rename from print_bcache_statistics.
4562         (bcache::memory_used): Rename from bcache_memory_used.
4563
4564 2019-03-07  Pedro Alves  <palves@redhat.com>
4565
4566         * infrun.c (normal_stop): Also check for
4567         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4568
4569 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * f-lang.c (value_from_host_double): Moved to...
4572         * value.c (value_from_host_double): ...here.
4573         * value.h (value_from_host_double): Declare.
4574         * guile/scm-math.c (vlscm_convert_typed_number): Use
4575         value_from_host_double.
4576         (vlscm_convert_number): Likewise.
4577         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4578         * python/py-value.c (convert_value_from_python): Likewise.
4579
4580 2019-03-06  Tom Tromey  <tom@tromey.com>
4581
4582         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4583
4584 2019-03-06  Tom Tromey  <tom@tromey.com>
4585
4586         * utils.h (free_current_contents): Don't declare.
4587         * utils.c (free_current_contents): Remove.
4588
4589 2019-03-06  Tom Tromey  <tom@tromey.com>
4590
4591         * top.c (quit_force): Update.
4592         * main.c (captured_command_loop): Update.
4593         * common/new-op.c (operator new): Update.
4594         * common/common-exceptions.c (struct catcher)
4595         <save_cleanup_chain>: Remove member.
4596         (exceptions_state_mc_init): Update.
4597         (exception_try_scope_entry): Return nullptr.
4598         (exception_try_scope_exit, exception_rethrow)
4599         (throw_exception_sjlj, throw_exception_cxx): Update.
4600         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4601         (all_cleanups, do_cleanups, discard_cleanups)
4602         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4603         (restore_cleanups, restore_final_cleanups): Don't declare.
4604         (do_final_cleanups): Remove parameter.
4605         * common/cleanups.c (cleanup_chain, make_cleanup)
4606         (make_cleanup_dtor, all_cleanups, do_cleanups)
4607         (discard_my_cleanups, discard_cleanups)
4608         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4609         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4610         (null_cleanup): Remove.
4611         (do_final_cleanups): Remove parameter.
4612
4613 2019-03-06  Tom Tromey  <tom@tromey.com>
4614
4615         * remote.c (remote_target::remote_parse_stop_reply): Use
4616         unique_xmalloc_ptr.
4617
4618 2019-03-06  Tom Tromey  <tom@tromey.com>
4619
4620         * stabsread.c (struct stabs_field_info): Rename from field_info.
4621         <list, fnlist>: Add initializers.
4622         <obstack>: New member.
4623         (read_member_functions, read_struct_fields, read_baseclasses):
4624         Allocate on obstack.  Don't use cleanups.
4625         (read_one_struct_field, read_member_functions, read_struct_fields)
4626         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4627         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4628         (read_struct_type): Update.
4629
4630 2019-03-06  Tom Tromey  <tom@tromey.com>
4631
4632         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4633         * common/filestuff.h (make_cleanup_close): Don't declare.
4634         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4635         Remove.
4636
4637 2019-03-06  Tom Tromey  <tom@tromey.com>
4638
4639         * solib-aix.c: Use make_scope_exit.
4640
4641 2019-03-06  Tom Tromey  <tom@tromey.com>
4642
4643         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4644         Use make_scope_exit.
4645
4646 2019-03-06  Tom Tromey  <tom@tromey.com>
4647
4648         * solib-svr4.c (disable_probes_interface): Remove parameter.
4649         (svr4_handle_solib_event): Use make_scope_exit.
4650
4651 2019-03-06  Tom Tromey  <tom@tromey.com>
4652
4653         * remote.c (struct stop_reply_deleter): Remove.
4654         (stop_reply_up): Update.
4655         (struct stop_reply): Derive from notif_event.  Don't typedef.
4656         <regcache>: Now a std::vector.
4657         (stop_reply_xfree): Remove.
4658         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4659         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4660         (remote_target::discard_pending_stop_replies): Use delete.
4661         (remote_target::remote_parse_stop_reply): Update.
4662         (remote_target::process_stop_reply): Update.
4663         * remote-notif.h (struct notif_event): Add virtual destructor.
4664         Remove "dtr" member.
4665         (struct notif_client) <alloc_event>: Return a unique_ptr.
4666         (notif_event_xfree): Don't declare.
4667         (notif_event_up): New typedef.
4668         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4669         (notif_event_xfree, do_notif_event_xfree): Remove.
4670         (remote_notif_state_xfree): Update.
4671
4672 2019-03-06  Tom Tromey  <tom@tromey.com>
4673
4674         * infrun.c (displaced_step_clear_cleanup): Now a
4675         forward_scope_exit type.
4676         (displaced_step_prepare_throw): Update.
4677         (displaced_step_fixup): Update.
4678
4679 2019-03-06  Tom Tromey  <tom@tromey.com>
4680
4681         * inferior.h (class inferior): Update comment.
4682         * gdbthread.h (class thread_info): Update comment.
4683
4684 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4685             Tom Tromey  <tom@tromey.com>
4686
4687         * stabsread.h (struct stab_section_list): Remove.
4688         (coffstab_build_psymtabs): Update.
4689         * dbxread.c (symbuf_sections): Now a std::vector.
4690         (sect_idx): New global.
4691         (fill_symbuf): Update.
4692         (coffstab_build_psymtabs): Change type of stabsects parameter.
4693         Update.
4694         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4695         std::vector.
4696         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4697         (coff_locate_sections): Update.
4698         (coff_symfile_read): Remove cleanups.  Update.
4699         (init_stringtab): Add storage parameter.
4700         (free_stringtab, free_stringtab_cleanup): Remove.
4701         (init_lineno): Add storage parameter.
4702         (free_linetab, free_linetab_cleanup): Remove.
4703
4704 2019-03-06  Pedro Alves  <palves@redhat.com>
4705
4706         * linux-fork.c (fork_info::clobber_regs): Delete.
4707         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4708         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4709         comment.  Adjust.
4710         (scoped_switch_fork_info::scoped_switch_fork_info)
4711         (checkpoint_command, linux_fork_context): Adjust
4712         fork_save_infrun_state calls.
4713
4714 2019-03-06  Pedro Alves  <palves@redhat.com>
4715
4716         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4717         (inf_has_multiple_threads): Return 'bool' and rewrite using
4718         inferior_info::threads().
4719
4720 2019-03-06  Pedro Alves  <palves@redhat.com>
4721
4722         * linux-fork.c: Include <list>.
4723         (fork_list): Now a std::list instance.
4724         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4725         (forks_exist_p, find_last_fork): Adjust.
4726         (new_fork): Delete.
4727         (one_fork_p): New.
4728         (add_fork): Adjust.
4729         (free_fork): Delete, folded into fork_info::~fork_info().
4730         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4731         Adjust.
4732         (init_fork_list): Delete.
4733         (linux_fork_killall, linux_fork_mourn_inferior)
4734         (linux_fork_detach, info_checkpoints_command): Adjust.
4735         (_initialize_linux_fork): No longer call init_fork_list.
4736
4737 2019-03-06  Pedro Alves  <palves@redhat.com>
4738
4739         * linux-fork.c (new_fork): New, split out of ...
4740         (add_fork): ... this.  Return void.  Move "first fork" special
4741         case from here, to ...
4742         (checkpoint_command): ... here.
4743         * linux-linux.h (add_fork): Return void.
4744
4745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4748
4749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4750             Chris January  <chris.january@arm.com>
4751             David Lecomber  <david.lecomber@arm.com>
4752
4753         * f-exp.y: New token, UNOP_INTRINSIC.
4754         (exp): New pattern using UNOP_INTRINSIC token.
4755         (f77_keywords): Add 'abs' keyword.
4756         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4757         (value_from_host_double): New function.
4758         (evaluate_subexp_f): Support UNOP_ABS.
4759
4760 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4761
4762         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4763         types.
4764
4765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4768         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4769         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4770
4771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4774
4775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4776             Chris January  <chris.january@arm.com>
4777
4778         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4779         * f-exp.y: Define 'KIND' token.
4780         (exp): New pattern for KIND expressions.
4781         (ptype): Handle types with a kind extension.
4782         (direct_abs_decl): Extend to spot kind extensions.
4783         (f77_keywords): Add 'kind' to the list.
4784         (push_kind_type): New function.
4785         (convert_to_kind_type): New function.
4786         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4787         * parse.c (operator_length_standard): Likewise.
4788         * parser-defs.h (enum type_pieces): Add tp_kind.
4789         * std-operator.def: Add UNOP_KIND.
4790
4791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4792
4793         * f-exp.y (f_parse): Set yydebug.
4794
4795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * f-lang.c (evaluate_subexp_f): New function.
4798         (exp_descriptor_f): New global.
4799         (f_language_defn): Use exp_descriptor_f instead of
4800         exp_descriptor_standard.
4801
4802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4803
4804         * f-exp.y (struct token): Add comments.
4805         (dot_ops): Remove uppercase versions and the end marker.
4806         (f77_keywords): Likewise.
4807         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4808         entries in the dot_ops array are case insensitive, and use
4809         strncasecmp to compare strings.  Also some whitespace cleanup in
4810         this area.  Similar for the f77_keywords array, except entries in
4811         this list might be case sensitive.
4812
4813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * f-exp.y (struct f77_boolean_val): Add comments.
4816         (boolean_values): Remove uppercase versions, and end marker.
4817         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4818         and use strncasecmp to achieve case insensitivity.  Additionally,
4819         perform whitespace cleanup around this code.
4820
4821 2019-03-06  Tom Tromey  <tromey@adacore.com>
4822
4823         * remote-sim.c (gdbsim_target_open): Use result of
4824         gdb_argv::release.
4825
4826 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4827         Dirk Schubert  <dirk.schubert@arm.com>
4828         Chris January  <chris.january@arm.com>
4829
4830         * eval.c (evaluate_subexp_standard): Call Fortran argument
4831         wrapping logic.
4832         * f-lang.c (struct value): A value which can be passed into a
4833         Fortran function call.
4834         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4835         where appropriate.
4836         (struct type): Value ready for a Fortran function call.
4837         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4838         is needed.
4839         * f-lang.h (fortran_argument_convert): Declaration.
4840         (fortran_preserve_arg_pointer): Declaration.
4841         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4842
4843 2019-03-05  Tom Tromey  <tromey@adacore.com>
4844
4845         * python/py-prettyprint.c (print_string_repr): Remove #if.
4846         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4847
4848 2019-03-05  Tom Tromey  <tromey@adacore.com>
4849
4850         * target.c (the_dummy_target): Move later.  Change type to
4851         "dummy_target".
4852         (initialize_targets): Don't initialize the_dummy_target.
4853
4854 2019-03-05  Tom Tromey  <tromey@adacore.com>
4855
4856         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4857         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4858
4859 2019-03-05  Tom Tromey  <tromey@adacore.com>
4860
4861         * windows-nat.c (windows_nat_target::attach)
4862         (windows_nat_target::detach): Don't call gdb_flush.
4863         * valprint.c (generic_val_print, val_print, val_print_string):
4864         Don't call gdb_flush.
4865         * utils.c (defaulted_query): Don't call gdb_flush.
4866         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4867         * target.c (target_announce_detach): Don't call gdb_flush.
4868         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4869         * remote.c (extended_remote_target::attach): Don't call
4870         gdb_flush.
4871         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4872         * printcmd.c (do_examine): Don't call gdb_flush.
4873         (info_display_command): Don't call gdb_flush.
4874         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4875         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4876         * memattr.c (info_mem_command): Don't call gdb_flush.
4877         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4878         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4879         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4880         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4881         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4882         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4883         (gnu_nat_target::detach): Don't call gdb_flush.
4884         * f-valprint.c (f_val_print): Don't call gdb_flush.
4885         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4886         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4887         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4888         gdb_flush.
4889         * c-valprint.c (c_val_print): Don't call gdb_flush.
4890         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4891
4892 2019-03-05  Tom Tromey  <tromey@adacore.com>
4893
4894         * varobj.c (update_dynamic_varobj_children): Update.
4895         (install_default_visualizer): Use reset, not release.
4896         * value.c (set_internalvar): Update.
4897         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4898         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4899         ATTRIBUTE_UNUSED_RESULT.
4900
4901 2019-03-05  Tom Tromey  <tromey@adacore.com>
4902
4903         * remote.c (class scoped_remote_fd) <release>: Add
4904         ATTRIBUTE_UNUSED_RESULT.
4905
4906 2019-03-05  Tom Tromey  <tromey@adacore.com>
4907
4908         * macroexp.c (struct macro_buffer) <release>: Add
4909         ATTRIBUTE_UNUSED_RESULT.
4910
4911 2019-03-05  Tom Tromey  <tromey@adacore.com>
4912
4913         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4914         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4915         ATTRIBUTE_UNUSED_RESULT.
4916
4917 2019-03-05  Tom Tromey  <tromey@adacore.com>
4918
4919         * common/scoped_fd.h (class scoped_fd) <release>: Add
4920         ATTRIBUTE_UNUSED_RESULT.
4921
4922 2019-03-05  Tom Tromey  <tromey@adacore.com>
4923
4924         * parser-defs.h (struct parser_state) <release>: Add
4925         ATTRIBUTE_UNUSED_RESULT.
4926
4927 2019-03-05  Tom Tromey  <tromey@adacore.com>
4928
4929         * utils.h (class gdb_argv) <release>: Add
4930         ATTRIBUTE_UNUSED_RESULT.
4931         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4932
4933 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4934
4935         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4936         for-loop range, to avoid compiler warnings.
4937
4938         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4939         avoid compiler warnings about unused variables.
4940
4941         * NEWS: Mention end of support for native debugging on MS-Windows
4942         before XP.
4943
4944         PR gdb/24292
4945         * common/netstuff.c:
4946         * gdbserver/gdbreplay.c
4947         * gdbserver/remote-utils.c:
4948         * ser-tcp.c:
4949         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4950         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4951         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4952         'getaddrinfo' and 'freeaddrinfo' were not available before
4953         Windows XP, and mingw.org's MinGW headers by default define
4954         _WIN32_WINNT to 0x500.
4955
4956 2019-03-01  Gary Benson <gbenson@redhat.com>
4957
4958         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4959
4960 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4961             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4962
4963         PR gdb/8527
4964         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4965         set_sigint_trap, clear_sigint_trap.
4966
4967 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4968
4969         * target.c (target_detach): Clear the regcache and the
4970         frame cache.
4971
4972 2019-02-27  Pedro Alves  <palves@redhat.com>
4973
4974         * utils.c (set_screen_size): When we cap the height/width sizes,
4975         tweak the corresponding command variable to show "unlimited":
4976
4977 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4978             Pedro Alves  <palves@redhat.com>
4979
4980         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4981         before calling rl_set_screen_size.
4982
4983 2019-02-27  Tom Tromey  <tromey@adacore.com>
4984
4985         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4986         define.
4987         * python/py-value.c: Remove Python 2.4 workaround.
4988         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4989         workaround.
4990         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4991         Python 2.4 workaround.
4992         * python/python-internal.h: Remove Python 2.4 comment.
4993         (Py_ssize_t): Don't define.
4994         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4995         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4996         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4997         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4998         * python/python.c (do_start_initialization): Remove Python 2.4
4999         workaround.
5000         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5001         (print_children): Remove Python 2.4 workaround.
5002         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5003         workaround.
5004         (CHARBUFFERPROC_NAME): Remove.
5005         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5006         Python 2.4 workaround.
5007
5008 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5009
5010         * NEWS: Note minimum Python version.
5011
5012 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5013
5014         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5015         code from these functions.  Remove corresponding ifdefs.  Use
5016         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5017         Remove gotos and target of gotos.
5018         (infpy_search_memory): Likewise.
5019
5020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5023         (hppa_gdbarch_init): Don't register deleted functions with
5024         gdbarch.
5025
5026 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5029         (h8300_unwind_sp): Delete.
5030         (h8300_dummy_id): Delete.
5031         (h8300_gdbarch_init): Don't register deleted functions with
5032         gdbarch.
5033
5034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5037         (ft32_unwind_pc): Delete.
5038         (ft32_unwind_sp): Delete.
5039         (ft32_gdbarch_init): Don't register deleted functions with
5040         gdbarch.
5041
5042 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5045         (frv_unwind_pc): Delete.
5046         (frv_unwind_sp): Delete.
5047         (frv_gdbarch_init): Don't register deleted functions with
5048         gdbarch.
5049
5050 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5053         (riscv_unwind_pc): Delete.
5054         (riscv_unwind_sp): Delete.
5055         (riscv_gdbarch_init): Don't register deleted functions with
5056         gdbarch.
5057
5058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5061         (csky_unwind_pc): Delete.
5062         (csky_unwind_sp): Delete.
5063         (csky_gdbarch_init): Don't register deleted functions with
5064         gdbarch.
5065
5066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5069         (cris_unwind_pc): Delete.
5070         (cris_unwind_sp): Delete.
5071         (cris_gdbarch_init): Don't register deleted functions with
5072         gdbarch.
5073
5074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5077         (bfin_unwind_pc): Delete.
5078         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5079
5080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5083         (arm_unwind_pc): Delete.
5084         (arm_unwind_sp): Delete.
5085         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5086
5087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5088
5089         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5090         (arc_unwind_pc): Delete.
5091         (arc_unwind_sp): Delete.
5092         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5093
5094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5097         (alpha_unwind_pc): Delete.
5098         (alpha_gdbarch_init): Don't register deleted functions with
5099         gdbarch.
5100
5101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5104         (aarch64_unwind_pc): Delete.
5105         (aarch64_unwind_sp): Delete.
5106         (aarch64_gdbarch_init): Don't register deleted functions with
5107         gdbarch.
5108
5109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5110
5111         * gdbtypes.c (type_align): Don't consider static members when
5112         computing structure alignment.
5113
5114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5117         return 0 for other types.
5118         * arch-utils.c (default_type_align): Always return 0.
5119         * gdbarch.h: Regenerate.
5120         * gdbarch.sh (type_align): Extend comment.
5121         * gdbtypes.c (type_align): Add additional comments, always call
5122         gdbarch_type_align before applying the default rules.
5123         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5124         generic code will then apply a suitable default.
5125         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5126         types, return 0 for other types.
5127
5128 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5129
5130         * NEWS: Create a new section for the next release branch.
5131         Rename the section of the current branch, now that it has
5132         been cut.
5133
5134 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5135
5136         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5137         * version.in: Bump version to 8.3.50.DATE-git.
5138
5139 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5140
5141         * aix-thread.c (ptid_cmp): Remove unused variable.
5142         (get_signaled_thread): Likewise.
5143         (store_regs_user_thread): Likewise.
5144         (store_regs_kernel_thread): Likewise.
5145         (fetch_regs_kernel_thread): Remove shadowed variable.
5146
5147 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * features/riscv/32bit-cpu.xml: Add register numbers.
5150         * features/riscv/32bit-fpu.c: Regenerate.
5151         * features/riscv/32bit-fpu.xml: Add register numbers.
5152         * features/riscv/64bit-cpu.xml: Add register numbers.
5153         * features/riscv/64bit-fpu.c: Regenerate.
5154         * features/riscv/64bit-fpu.xml: Add register numbers.
5155
5156 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5157
5158         * NEWS: Mention two argument form of gdb.Value constructor.
5159         * python/py-value.c (convert_buffer_and_type_to_value): New
5160         function.
5161         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5162         Add support for handling an optional second argument.  Call
5163         convert_buffer_and_type_to_value as appropriate.
5164         * python/python-internal.h (Py_buffer_deleter): New struct.
5165         (Py_buffer_up): New typedef.
5166
5167 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5168
5169         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5170         instead of releasing ownership.
5171
5172 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5173
5174         * dwarf2read.c (open_and_init_dwp_file): Call
5175         elf_numsections instead of bfd_count_sections to initialize
5176         dwp_file->num_sections.
5177
5178 2019-02-25  Tom Tromey  <tromey@adacore.com>
5179
5180         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5181
5182 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5183
5184         * gcore.in: Add '--readnever' option when invoking GDB.
5185
5186 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5187
5188         * MAINTAINERS: Update my email address.
5189
5190 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5191
5192         * build-id.c (build_id_to_debug_bfd_1): New function.
5193         (build_id_to_debug_bfd): Look for separate debug file in
5194         sysroot.
5195
5196 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * gdbarch.sh: Update the copyright year range that is placed into
5199         generated files.
5200
5201 2019-02-22  Keith Seitz  <keiths@redhat.com>
5202
5203         PR symtab/23853
5204         * linespec.c (create_sals_line_offset): Search for the default
5205         symtab's filename instead of its fullname.
5206
5207 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5208
5209         * NEWS: Update style defaults.
5210
5211 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5212
5213         * main.c (captured_main_1): Disable styling in batch mode.
5214
5215 2019-02-20  Tom Tromey  <tom@tromey.com>
5216
5217         * symtab.c (symtab_symbol_info): Fix typos.
5218
5219 2019-02-20  Tom Tromey  <tromey@adacore.com>
5220
5221         * findcmd.c (_initialize_mem_search): Use upper case for
5222         metasyntactic variables.
5223
5224 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5225
5226         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5227         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5228
5229 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5230
5231         * top.h (source_file_name): Change to std::string.
5232         * top.c (source_file_name): Likewise.
5233         (command_line_input): Adjust.
5234         * cli/cli-script.c (script_from_file): Adjust.
5235
5236 2019-02-19  Tom Tromey  <tromey@adacore.com>
5237
5238         * ravenscar-thread.c
5239         (ravenscar_thread_target::update_thread_list): Don't call
5240         ada_build_task_list.
5241         * ada-lang.h (ada_build_task_list): Don't declare.
5242         * ada-tasks.c (struct ada_tasks_inferior_data)
5243         <task_list_valid_p>: Now bool.
5244         (read_known_tasks, ada_task_list_changed)
5245         (ada_tasks_invalidate_inferior_data): Update.
5246         (read_known_tasks_array): Return bool.
5247         (read_known_tasks_list): Likewise.
5248         (read_known_tasks): Return void.
5249         (ada_build_task_list): Now static.
5250
5251 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5254         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5255
5256 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5257
5258         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5259         variant for ada_tasks_pspace_data_handle and
5260         ada_tasks_inferior_data_handle.
5261         (ada_tasks_pspace_data_cleanup): New function.
5262         (ada_tasks_inferior_data_cleanup): New function.
5263
5264 2019-02-17  Tom Tromey  <tom@tromey.com>
5265
5266         * macrotab.h (macro_source_fullname): Return a std::string.
5267         * macrotab.c (macro_include, check_for_redefinition)
5268         (macro_undef, macro_lookup_definition, foreach_macro)
5269         (foreach_macro_in_scope): Update.
5270         (macro_source_fullname): Return a std::string.
5271         * macrocmd.c (show_pp_source_pos): Update.
5272
5273 2019-02-17  Tom Tromey  <tom@tromey.com>
5274
5275         * macrocmd.c (show_pp_source_pos): Style the file names.
5276
5277 2019-02-17  Tom Tromey  <tom@tromey.com>
5278
5279         PR tui/24197:
5280         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5281
5282 2019-02-17  Tom Tromey  <tom@tromey.com>
5283
5284         * ada-lang.c (user_select_syms): Use filtered printing.
5285         * utils.c (wrap_style): New global.
5286         (desired_style): Remove.
5287         (emit_style_escape): Add stream parameter.
5288         (set_output_style, reset_terminal_style, prompt_for_continue):
5289         Update.
5290         (flush_wrap_buffer): Only flush gdb_stdout.
5291         (wrap_here): Set wrap_style.
5292         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5293         treat escape sequences as a character.  Change when wrap buffer is
5294         flushed.
5295         (fputs_styled): Do not set the output style when the default is
5296         requested.
5297         * ui-style.h (struct ui_file_style) <is_default>: New method.
5298         * source.c (print_source_lines_base): Emit escape sequences in one
5299         piece.
5300
5301 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5302
5303         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5304         integers and enumeration types.
5305
5306 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5307
5308         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5309         instead of lookup_symbol_in_language
5310         (do_exact_match): New function.
5311         (ada_get_symbol_name_matcher): Return do_exact_match when
5312         doing a verbatim match.
5313
5314 2019-02-15  Tom Tromey  <tromey@adacore.com>
5315
5316         * ravenscar-thread.c (ravenscar_thread_target::resume)
5317         (ravenscar_thread_target::wait): Special case wildcard requests.
5318
5319 2019-02-15  Tom Tromey  <tromey@adacore.com>
5320
5321         * ravenscar-thread.c (base_ptid): Remove.
5322         (struct ravenscar_thread_target) <close>: New method.
5323         <m_base_ptid>: New member.
5324         <update_inferior_ptid, active_task, task_is_currently_active,
5325         runtime_initialized>: Declare methods.
5326         <ravenscar_thread_target>: Add constructor.
5327         (ravenscar_thread_target::task_is_currently_active)
5328         (ravenscar_thread_target::update_inferior_ptid)
5329         (ravenscar_runtime_initialized): Rename.  Now methods.
5330         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5331         (ravenscar_thread_target::update_thread_list): Update.
5332         (ravenscar_thread_target::active_task): Now method.
5333         (ravenscar_thread_target::store_registers)
5334         (ravenscar_thread_target::prepare_to_store)
5335         (ravenscar_thread_target::prepare_to_store)
5336         (ravenscar_thread_target::mourn_inferior): Update.
5337         (ravenscar_inferior_created): Use "new" to create target.
5338         (ravenscar_thread_target::get_ada_task_ptid): Update.
5339         (_initialize_ravenscar): Don't initialize base_ptid.
5340         (ravenscar_ops): Remove global.
5341
5342 2019-02-15  Tom Tromey  <tromey@adacore.com>
5343
5344         * target.h (push_target): Declare new overload.
5345         * target.c (push_target): New overload, taking an rvalue reference.
5346         * remote.c (remote_target::open_1): Use push_target overload.
5347         * corelow.c (core_target_open): Use push_target overload.
5348
5349 2019-02-15  Tom Tromey  <tromey@adacore.com>
5350
5351         * ravenscar-thread.c (is_ravenscar_task)
5352         (ravenscar_task_is_currently_active): Return bool.
5353         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5354         (_initialize_ravenscar): Remove "(void)".
5355         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5356         Return bool.
5357
5358 2019-02-15  Tom Tromey  <tromey@adacore.com>
5359
5360         * ravenscar-thread.c (ravenscar_runtime_initializer)
5361         (has_ravenscar_runtime, get_running_thread_id)
5362         (ravenscar_thread_target::resume): Fix indentation.
5363
5364 2019-02-15  Tom Tromey  <tromey@adacore.com>
5365
5366         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5367         from ravenscar_arch_ops.
5368         (sparc_ravenscar_ops::fetch_registers)
5369         (sparc_ravenscar_ops::store_registers): Now methods.
5370         (sparc_ravenscar_prepare_to_store): Remove.
5371         (sparc_ravenscar_ops): Redefine.
5372         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5373         methods and destructor.  Remove members.
5374         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5375         (ravenscar_thread_target::store_registers)
5376         (ravenscar_thread_target::prepare_to_store): Update.
5377         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5378         Remove.
5379         (struct ppc_ravenscar_powerpc_ops): Derive from
5380         ravenscar_arch_ops.
5381         (ppc_ravenscar_powerpc_ops::fetch_registers)
5382         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5383         (ppc_ravenscar_powerpc_ops): Redefine.
5384         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5385         (ppc_ravenscar_e500_ops::fetch_registers)
5386         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5387         (ppc_ravenscar_e500_ops): Redefine.
5388         * aarch64-ravenscar-thread.c
5389         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5390         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5391         (aarch64_ravenscar_fetch_registers)
5392         (aarch64_ravenscar_store_registers): Now methods.
5393         (aarch64_ravenscar_ops): Redefine.
5394
5395 2019-02-15  Tom Tromey  <tromey@adacore.com>
5396
5397         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5398         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5399         (ravenscar_thread_target::stopped_by_watchpoint)
5400         (ravenscar_thread_target::stopped_data_address)
5401         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5402
5403 2019-02-15  Tom Tromey  <tromey@adacore.com>
5404
5405         * ravenscar-thread.c: Fix some typos.
5406
5407 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5408             Tom Tromey  <tromey@adacore.com>
5409
5410         * ada-lang.c (ada_exception_sal): Change addr_string to a
5411         std::string.
5412         (create_ada_exception_catchpoint): Update.
5413
5414 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5415             Tom Tromey  <tromey@adacore.com>
5416
5417         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5418         (bp_location_ops): Remove.
5419         (base_breakpoint_allocate_location): Update.
5420         (free_bp_location): Update.
5421         * ada-lang.c (class ada_catchpoint_location)
5422         <ada_catchpoint_location>: Remove ops parameter.
5423         (ada_catchpoint_location_dtor): Remove.
5424         (ada_catchpoint_location_ops): Remove.
5425         (allocate_location_exception): Update.
5426         * breakpoint.h (struct bp_location_ops): Remove.
5427         (class bp_location) <bp_location>: Remove bp_location_ops
5428         parameter.
5429         <~bp_location>: Add destructor.
5430         <ops>: Remove.
5431
5432 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5433             Pedro Alves  <palves@redhat.com>
5434
5435         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5436         'PATH_MAX'.
5437
5438 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5439             Samuel Thibault  <samuel.thibault@gnu.org>
5440             Thomas Schwinge  <thomas@codesourcery.com>
5441
5442         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5443         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5444
5445 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5446
5447         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5448         (check_empty): Use "const char *".
5449
5450         * gnu-nat.c (gnu_nat_target::detach): Instead of
5451         'detach_inferior (pid)' call
5452         'detach_inferior (find_inferior_pid (pid))'.
5453
5454         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5455         'nat/fork-inferior.o'.
5456         * gnu-nat.c: #include "nat/fork-inferior.h".
5457
5458         * gnu-nat.c (gnu_nat_target::detach): Instead of
5459         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5460         * gnu-nat.h: #include "inf-child.h".
5461         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5462         'i386_gnu_nat_target::fetch_registers'.
5463         (gnu_store_registers): Rename/move to
5464         'i386_gnu_nat_target::store_registers'.
5465
5466         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5467         * gnu-nat.h (mach_thread_info): New function.
5468         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5469
5470         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5471
5472 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5473
5474         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5475
5476 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5477
5478         * windows-nat.c (windows_add_thread): Add new parameter
5479         "main_thread_p" with default value set to false.  Update
5480         function documentation as well as all callers.
5481         (windows_delete_thread): Likewise.
5482         (fake_create_process): Update call to windows_add_thread.
5483         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5484         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5485         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5486         call to windows_delete_thread.
5487
5488 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5489
5490         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5491
5492 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5493
5494         * symfile.c (find_separate_debug_file): Use canonical path of
5495         sysroot with child_path instead of gdb_sysroot if it is valid.
5496
5497 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5498
5499         * symfile.c (find_separate_debug_file): Use child_path to
5500         determine if an object file is under a sysroot.
5501
5502 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5503
5504         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5505         unittests/child-path-selftests.c.
5506         * common/pathstuff.c (child_path): New function.
5507         * common/pathstuff.h (child_path): New prototype.
5508         * unittests/child-path-selftests.c: New file.
5509
5510 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5511
5512         * symfile.c (find_separate_debug_file): Look for separate debug
5513         files in debug directories under the sysroot.
5514
5515 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5516
5517         * symtab.h (struct minimal_symbol data_p): New const method.
5518         (struct minimal_symbol text_p): Likewise.
5519         * symtab.c (output_source_filename): Use file name style
5520         to print file name.
5521         (print_symbol_info): Likewise.
5522         (print_msymbol_info): Use address style to print addresses.
5523         Use function name style to print executable text symbols.
5524         (expand_symtab_containing_pc): Use data_p.
5525         (find_pc_sect_compunit_symtab): Likewise.
5526
5527 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5528
5529         * breakpoint.c (describe_other_breakpoints): Use address style
5530         to print addresses.
5531         (say_where): Likewise.
5532
5533 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * ada-typeprint.c (print_func_type): Print function name
5536         style to print function name.
5537         * c-typeprint.c (c_print_type_1): Likewise.
5538
5539 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5540
5541         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5542         for execve.
5543
5544 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5545
5546         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5547         type_stack.
5548
5549 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5550
5551         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5552         TYPE_CODE_REF types.
5553
5554 2019-02-08  Jim Wilson  <jimw@sifive.com>
5555
5556         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5557         (riscv_linux_fregset): New.
5558         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5559
5560 2019-02-07  Tom Tromey  <tom@tromey.com>
5561
5562         * thread.c (thread_cancel_execution_command): Update.
5563         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5564         methods.
5565         (struct thread_fsm_ops): Remove.
5566         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5567         (thread_fsm_should_stop, thread_fsm_return_value)
5568         (thread_fsm_set_finished, thread_fsm_finished_p)
5569         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5570         Don't declare.
5571         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5572         * infrun.c (clear_proceed_status_thread)
5573         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5574         (print_stop_event): Update.
5575         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5576         Add constructor.
5577         (step_command_fsm_ops): Remove.
5578         (new_step_command_fsm): Remove.
5579         (step_1): Update.
5580         (step_command_fsm::should_stop): Rename from
5581         step_command_fsm_should_stop.
5582         (step_command_fsm::clean_up): Rename from
5583         step_command_fsm_clean_up.
5584         (step_command_fsm::do_async_reply_reason): Rename from
5585         step_command_fsm_async_reply_reason.
5586         (struct until_next_fsm): Inherit from thread_fsm.  Add
5587         constructor.
5588         (until_next_fsm_ops): Remove.
5589         (new_until_next_fsm): Remove.
5590         (until_next_fsm::should_stop): Rename from
5591         until_next_fsm_should_stop.
5592         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5593         (until_next_fsm::do_async_reply_reason): Rename from
5594         until_next_fsm_async_reply_reason.
5595         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5596         constructor.  Change type of breakpoint.
5597         (finish_command_fsm_ops): Remove.
5598         (new_finish_command_fsm): Remove.
5599         (finish_command_fsm::should_stop): Rename from
5600         finish_command_fsm_should_stop.
5601         (finish_command_fsm::clean_up): Rename from
5602         finish_command_fsm_clean_up.
5603         (finish_command_fsm::return_value): Rename from
5604         finish_command_fsm_return_value.
5605         (finish_command_fsm::do_async_reply_reason): Rename from
5606         finish_command_fsm_async_reply_reason.
5607         (finish_command): Update.
5608         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5609         Add constructor.
5610         (call_thread_fsm_ops): Remove.
5611         (call_thread_fsm::call_thread_fsm): Rename from
5612         new_call_thread_fsm.
5613         (call_thread_fsm::should_stop): Rename from
5614         call_thread_fsm_should_stop.
5615         (call_thread_fsm::should_notify_stop): Rename from
5616         call_thread_fsm_should_notify_stop.
5617         (run_inferior_call, call_function_by_hand_dummy): Update.
5618         * cli/cli-interp.c (should_print_stop_to_console): Update.
5619         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5620         Add constructor.  Change type of location_breakpoint,
5621         caller_breakpoint.
5622         (until_break_fsm_ops): Remove.
5623         (new_until_break_fsm): Remove.
5624         (until_break_fsm::should_stop): Rename from
5625         until_break_fsm_should_stop.
5626         (until_break_fsm::clean_up): Rename from
5627         until_break_fsm_clean_up.
5628         (until_break_fsm::do_async_reply_reason): Rename from
5629         until_break_fsm_async_reply_reason.
5630         (until_break_command): Update.
5631         * thread-fsm.c: Remove.
5632         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5633
5634 2019-02-07  Tom Tromey  <tom@tromey.com>
5635
5636         * yy-remap.h: Add include guard.
5637         * xtensa-tdep.h: Add include guard.
5638         * xcoffread.h: Rename include guard.
5639         * varobj-iter.h: Add include guard.
5640         * tui/tui.h: Rename include guard.
5641         * tui/tui-winsource.h: Rename include guard.
5642         * tui/tui-wingeneral.h: Rename include guard.
5643         * tui/tui-windata.h: Rename include guard.
5644         * tui/tui-win.h: Rename include guard.
5645         * tui/tui-stack.h: Rename include guard.
5646         * tui/tui-source.h: Rename include guard.
5647         * tui/tui-regs.h: Rename include guard.
5648         * tui/tui-out.h: Rename include guard.
5649         * tui/tui-layout.h: Rename include guard.
5650         * tui/tui-io.h: Rename include guard.
5651         * tui/tui-hooks.h: Rename include guard.
5652         * tui/tui-file.h: Rename include guard.
5653         * tui/tui-disasm.h: Rename include guard.
5654         * tui/tui-data.h: Rename include guard.
5655         * tui/tui-command.h: Rename include guard.
5656         * tic6x-tdep.h: Add include guard.
5657         * target/waitstatus.h: Rename include guard.
5658         * target/wait.h: Rename include guard.
5659         * target/target.h: Rename include guard.
5660         * target/resume.h: Rename include guard.
5661         * target-float.h: Rename include guard.
5662         * stabsread.h: Add include guard.
5663         * rs6000-tdep.h: Add include guard.
5664         * riscv-fbsd-tdep.h: Add include guard.
5665         * regformats/regdef.h: Rename include guard.
5666         * record.h: Rename include guard.
5667         * python/python.h: Rename include guard.
5668         * python/python-internal.h: Rename include guard.
5669         * python/py-stopevent.h: Rename include guard.
5670         * python/py-ref.h: Rename include guard.
5671         * python/py-record.h: Rename include guard.
5672         * python/py-record-full.h: Rename include guard.
5673         * python/py-record-btrace.h: Rename include guard.
5674         * python/py-instruction.h: Rename include guard.
5675         * python/py-events.h: Rename include guard.
5676         * python/py-event.h: Rename include guard.
5677         * procfs.h: Add include guard.
5678         * proc-utils.h: Add include guard.
5679         * p-lang.h: Add include guard.
5680         * or1k-tdep.h: Rename include guard.
5681         * observable.h: Rename include guard.
5682         * nto-tdep.h: Rename include guard.
5683         * nat/x86-linux.h: Rename include guard.
5684         * nat/x86-linux-dregs.h: Rename include guard.
5685         * nat/x86-gcc-cpuid.h: Add include guard.
5686         * nat/x86-dregs.h: Rename include guard.
5687         * nat/x86-cpuid.h: Rename include guard.
5688         * nat/ppc-linux.h: Rename include guard.
5689         * nat/mips-linux-watch.h: Rename include guard.
5690         * nat/linux-waitpid.h: Rename include guard.
5691         * nat/linux-ptrace.h: Rename include guard.
5692         * nat/linux-procfs.h: Rename include guard.
5693         * nat/linux-osdata.h: Rename include guard.
5694         * nat/linux-nat.h: Rename include guard.
5695         * nat/linux-namespaces.h: Rename include guard.
5696         * nat/linux-btrace.h: Rename include guard.
5697         * nat/glibc_thread_db.h: Rename include guard.
5698         * nat/gdb_thread_db.h: Rename include guard.
5699         * nat/gdb_ptrace.h: Rename include guard.
5700         * nat/fork-inferior.h: Rename include guard.
5701         * nat/amd64-linux-siginfo.h: Rename include guard.
5702         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5703         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5704         * nat/aarch64-linux.h: Rename include guard.
5705         * nat/aarch64-linux-hw-point.h: Rename include guard.
5706         * mn10300-tdep.h: Add include guard.
5707         * mips-linux-tdep.h: Add include guard.
5708         * mi/mi-parse.h: Rename include guard.
5709         * mi/mi-out.h: Rename include guard.
5710         * mi/mi-main.h: Rename include guard.
5711         * mi/mi-interp.h: Rename include guard.
5712         * mi/mi-getopt.h: Rename include guard.
5713         * mi/mi-console.h: Rename include guard.
5714         * mi/mi-common.h: Rename include guard.
5715         * mi/mi-cmds.h: Rename include guard.
5716         * mi/mi-cmd-break.h: Rename include guard.
5717         * m2-lang.h: Add include guard.
5718         * location.h: Rename include guard.
5719         * linux-record.h: Rename include guard.
5720         * linux-nat.h: Add include guard.
5721         * linux-fork.h: Add include guard.
5722         * i386-darwin-tdep.h: Rename include guard.
5723         * hppa-linux-offsets.h: Add include guard.
5724         * guile/guile.h: Rename include guard.
5725         * guile/guile-internal.h: Rename include guard.
5726         * gnu-nat.h: Rename include guard.
5727         * gdb-stabs.h: Rename include guard.
5728         * frv-tdep.h: Add include guard.
5729         * f-lang.h: Add include guard.
5730         * event-loop.h: Add include guard.
5731         * darwin-nat.h: Rename include guard.
5732         * cp-abi.h: Rename include guard.
5733         * config/sparc/nm-sol2.h: Rename include guard.
5734         * config/nm-nto.h: Rename include guard.
5735         * config/nm-linux.h: Add include guard.
5736         * config/i386/nm-i386gnu.h: Rename include guard.
5737         * config/djgpp/nl_types.h: Rename include guard.
5738         * config/djgpp/langinfo.h: Rename include guard.
5739         * compile/gcc-cp-plugin.h: Add include guard.
5740         * compile/gcc-c-plugin.h: Add include guard.
5741         * compile/compile.h: Rename include guard.
5742         * compile/compile-object-run.h: Rename include guard.
5743         * compile/compile-object-load.h: Rename include guard.
5744         * compile/compile-internal.h: Rename include guard.
5745         * compile/compile-cplus.h: Rename include guard.
5746         * compile/compile-c.h: Rename include guard.
5747         * common/xml-utils.h: Rename include guard.
5748         * common/x86-xstate.h: Rename include guard.
5749         * common/version.h: Rename include guard.
5750         * common/vec.h: Rename include guard.
5751         * common/tdesc.h: Rename include guard.
5752         * common/selftest.h: Rename include guard.
5753         * common/scoped_restore.h: Rename include guard.
5754         * common/scoped_mmap.h: Rename include guard.
5755         * common/scoped_fd.h: Rename include guard.
5756         * common/safe-iterator.h: Rename include guard.
5757         * common/run-time-clock.h: Rename include guard.
5758         * common/refcounted-object.h: Rename include guard.
5759         * common/queue.h: Rename include guard.
5760         * common/ptid.h: Rename include guard.
5761         * common/print-utils.h: Rename include guard.
5762         * common/preprocessor.h: Rename include guard.
5763         * common/pathstuff.h: Rename include guard.
5764         * common/observable.h: Rename include guard.
5765         * common/netstuff.h: Rename include guard.
5766         * common/job-control.h: Rename include guard.
5767         * common/host-defs.h: Rename include guard.
5768         * common/gdb_wait.h: Rename include guard.
5769         * common/gdb_vecs.h: Rename include guard.
5770         * common/gdb_unlinker.h: Rename include guard.
5771         * common/gdb_unique_ptr.h: Rename include guard.
5772         * common/gdb_tilde_expand.h: Rename include guard.
5773         * common/gdb_sys_time.h: Rename include guard.
5774         * common/gdb_string_view.h: Rename include guard.
5775         * common/gdb_splay_tree.h: Rename include guard.
5776         * common/gdb_setjmp.h: Rename include guard.
5777         * common/gdb_ref_ptr.h: Rename include guard.
5778         * common/gdb_optional.h: Rename include guard.
5779         * common/gdb_locale.h: Rename include guard.
5780         * common/gdb_assert.h: Rename include guard.
5781         * common/filtered-iterator.h: Rename include guard.
5782         * common/filestuff.h: Rename include guard.
5783         * common/fileio.h: Rename include guard.
5784         * common/environ.h: Rename include guard.
5785         * common/common-utils.h: Rename include guard.
5786         * common/common-types.h: Rename include guard.
5787         * common/common-regcache.h: Rename include guard.
5788         * common/common-inferior.h: Rename include guard.
5789         * common/common-gdbthread.h: Rename include guard.
5790         * common/common-exceptions.h: Rename include guard.
5791         * common/common-defs.h: Rename include guard.
5792         * common/common-debug.h: Rename include guard.
5793         * common/cleanups.h: Rename include guard.
5794         * common/buffer.h: Rename include guard.
5795         * common/btrace-common.h: Rename include guard.
5796         * common/break-common.h: Rename include guard.
5797         * cli/cli-utils.h: Rename include guard.
5798         * cli/cli-style.h: Rename include guard.
5799         * cli/cli-setshow.h: Rename include guard.
5800         * cli/cli-script.h: Rename include guard.
5801         * cli/cli-interp.h: Rename include guard.
5802         * cli/cli-decode.h: Rename include guard.
5803         * cli/cli-cmds.h: Rename include guard.
5804         * charset-list.h: Add include guard.
5805         * buildsym-legacy.h: Rename include guard.
5806         * bfin-tdep.h: Add include guard.
5807         * ax.h: Rename include guard.
5808         * arm-linux-tdep.h: Add include guard.
5809         * arm-fbsd-tdep.h: Add include guard.
5810         * arch/xtensa.h: Rename include guard.
5811         * arch/tic6x.h: Add include guard.
5812         * arch/i386.h: Add include guard.
5813         * arch/arm.h: Rename include guard.
5814         * arch/arm-linux.h: Rename include guard.
5815         * arch/arm-get-next-pcs.h: Rename include guard.
5816         * arch/amd64.h: Add include guard.
5817         * arch/aarch64-insn.h: Rename include guard.
5818         * arch-utils.h: Rename include guard.
5819         * annotate.h: Add include guard.
5820         * amd64-darwin-tdep.h: Rename include guard.
5821         * aarch64-linux-tdep.h: Add include guard.
5822         * aarch64-fbsd-tdep.h: Add include guard.
5823         * aarch32-linux-nat.h: Add include guard.
5824
5825 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5826
5827         * macrotab.c (macro_define_internal): New function that
5828         factorizes macro_define_object_internal and macro_define_function
5829         code.
5830         (macro_define_object_internal): Use macro_define_internal.
5831         (macro_define_function): Likewise.
5832
5833 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5834
5835         * macrocmd.c (extract_identifier): Return
5836         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5837         callers.
5838
5839 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5840
5841         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5842
5843 2019-02-05  Tom Tromey  <tom@tromey.com>
5844
5845         * target.c (target_stack::unpush): Move assertion earlier.
5846
5847 2019-01-30  Tom Tromey  <tom@tromey.com>
5848
5849         PR python/23615:
5850         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5851         (gdbpy_parse_and_eval): Likewise.
5852         * python/python-internal.h (gdbpy_allow_threads): New class.
5853
5854 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5855
5856         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5857         (aarch64_fbsd_fpregmap): Move earlier.
5858         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5859         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5860         instead of individual calls to trad_frame_set_reg_addr.
5861         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5862         earlier.
5863         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5864         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5865         instead of individual calls to trad_frame_set_reg_addr.
5866
5867 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5868
5869         * CONTRIBUTE: Replace contribution list with wiki link.
5870
5871 2019-01-25  Tom Tromey  <tom@tromey.com>
5872
5873         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5874
5875 2019-01-25  Tom Tromey  <tom@tromey.com>
5876
5877         * xtensa-linux-nat.c: Fix common/ includes.
5878         * xml-support.h: Fix common/ includes.
5879         * xml-support.c: Fix common/ includes.
5880         * x86-linux-nat.c: Fix common/ includes.
5881         * windows-nat.c: Fix common/ includes.
5882         * varobj.h: Fix common/ includes.
5883         * varobj.c: Fix common/ includes.
5884         * value.c: Fix common/ includes.
5885         * valops.c: Fix common/ includes.
5886         * utils.c: Fix common/ includes.
5887         * unittests/xml-utils-selftests.c: Fix common/ includes.
5888         * unittests/utils-selftests.c: Fix common/ includes.
5889         * unittests/unpack-selftests.c: Fix common/ includes.
5890         * unittests/tracepoint-selftests.c: Fix common/ includes.
5891         * unittests/style-selftests.c: Fix common/ includes.
5892         * unittests/string_view-selftests.c: Fix common/ includes.
5893         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5894         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5895         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5896         * unittests/rsp-low-selftests.c: Fix common/ includes.
5897         * unittests/parse-connection-spec-selftests.c: Fix common/
5898         includes.
5899         * unittests/optional-selftests.c: Fix common/ includes.
5900         * unittests/offset-type-selftests.c: Fix common/ includes.
5901         * unittests/observable-selftests.c: Fix common/ includes.
5902         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5903         * unittests/memrange-selftests.c: Fix common/ includes.
5904         * unittests/memory-map-selftests.c: Fix common/ includes.
5905         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5906         * unittests/function-view-selftests.c: Fix common/ includes.
5907         * unittests/environ-selftests.c: Fix common/ includes.
5908         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5909         * unittests/common-utils-selftests.c: Fix common/ includes.
5910         * unittests/cli-utils-selftests.c: Fix common/ includes.
5911         * unittests/array-view-selftests.c: Fix common/ includes.
5912         * ui-file.c: Fix common/ includes.
5913         * tui/tui-io.c: Fix common/ includes.
5914         * tracepoint.h: Fix common/ includes.
5915         * tracepoint.c: Fix common/ includes.
5916         * tracefile-tfile.c: Fix common/ includes.
5917         * top.h: Fix common/ includes.
5918         * top.c: Fix common/ includes.
5919         * thread.c: Fix common/ includes.
5920         * target/waitstatus.h: Fix common/ includes.
5921         * target/waitstatus.c: Fix common/ includes.
5922         * target.h: Fix common/ includes.
5923         * target.c: Fix common/ includes.
5924         * target-memory.c: Fix common/ includes.
5925         * target-descriptions.c: Fix common/ includes.
5926         * symtab.h: Fix common/ includes.
5927         * symfile.c: Fix common/ includes.
5928         * stap-probe.c: Fix common/ includes.
5929         * spu-linux-nat.c: Fix common/ includes.
5930         * sparc-nat.c: Fix common/ includes.
5931         * source.c: Fix common/ includes.
5932         * solib.c: Fix common/ includes.
5933         * solib-target.c: Fix common/ includes.
5934         * ser-unix.c: Fix common/ includes.
5935         * ser-tcp.c: Fix common/ includes.
5936         * ser-pipe.c: Fix common/ includes.
5937         * ser-base.c: Fix common/ includes.
5938         * selftest-arch.c: Fix common/ includes.
5939         * s12z-tdep.c: Fix common/ includes.
5940         * rust-exp.y: Fix common/ includes.
5941         * rs6000-aix-tdep.c: Fix common/ includes.
5942         * riscv-tdep.c: Fix common/ includes.
5943         * remote.c: Fix common/ includes.
5944         * remote-notif.h: Fix common/ includes.
5945         * remote-fileio.h: Fix common/ includes.
5946         * remote-fileio.c: Fix common/ includes.
5947         * regcache.h: Fix common/ includes.
5948         * regcache.c: Fix common/ includes.
5949         * record-btrace.c: Fix common/ includes.
5950         * python/python.c: Fix common/ includes.
5951         * python/py-type.c: Fix common/ includes.
5952         * python/py-inferior.c: Fix common/ includes.
5953         * progspace.h: Fix common/ includes.
5954         * producer.c: Fix common/ includes.
5955         * procfs.c: Fix common/ includes.
5956         * proc-api.c: Fix common/ includes.
5957         * printcmd.c: Fix common/ includes.
5958         * ppc-linux-nat.c: Fix common/ includes.
5959         * parser-defs.h: Fix common/ includes.
5960         * osdata.c: Fix common/ includes.
5961         * obsd-nat.c: Fix common/ includes.
5962         * nat/x86-linux.c: Fix common/ includes.
5963         * nat/x86-linux-dregs.c: Fix common/ includes.
5964         * nat/x86-dregs.h: Fix common/ includes.
5965         * nat/x86-dregs.c: Fix common/ includes.
5966         * nat/ppc-linux.c: Fix common/ includes.
5967         * nat/mips-linux-watch.h: Fix common/ includes.
5968         * nat/mips-linux-watch.c: Fix common/ includes.
5969         * nat/linux-waitpid.c: Fix common/ includes.
5970         * nat/linux-ptrace.h: Fix common/ includes.
5971         * nat/linux-ptrace.c: Fix common/ includes.
5972         * nat/linux-procfs.c: Fix common/ includes.
5973         * nat/linux-personality.c: Fix common/ includes.
5974         * nat/linux-osdata.c: Fix common/ includes.
5975         * nat/linux-namespaces.c: Fix common/ includes.
5976         * nat/linux-btrace.h: Fix common/ includes.
5977         * nat/linux-btrace.c: Fix common/ includes.
5978         * nat/fork-inferior.c: Fix common/ includes.
5979         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5980         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5981         * nat/aarch64-linux.c: Fix common/ includes.
5982         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5983         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5984         * namespace.h: Fix common/ includes.
5985         * mips-linux-tdep.c: Fix common/ includes.
5986         * minsyms.c: Fix common/ includes.
5987         * mi/mi-parse.h: Fix common/ includes.
5988         * mi/mi-main.c: Fix common/ includes.
5989         * mi/mi-cmd-env.c: Fix common/ includes.
5990         * memrange.h: Fix common/ includes.
5991         * memattr.c: Fix common/ includes.
5992         * maint.h: Fix common/ includes.
5993         * maint.c: Fix common/ includes.
5994         * main.c: Fix common/ includes.
5995         * machoread.c: Fix common/ includes.
5996         * location.c: Fix common/ includes.
5997         * linux-thread-db.c: Fix common/ includes.
5998         * linux-nat.c: Fix common/ includes.
5999         * linux-fork.c: Fix common/ includes.
6000         * inline-frame.c: Fix common/ includes.
6001         * infrun.c: Fix common/ includes.
6002         * inflow.c: Fix common/ includes.
6003         * inferior.h: Fix common/ includes.
6004         * inferior.c: Fix common/ includes.
6005         * infcmd.c: Fix common/ includes.
6006         * inf-ptrace.c: Fix common/ includes.
6007         * inf-child.c: Fix common/ includes.
6008         * ia64-linux-nat.c: Fix common/ includes.
6009         * i387-tdep.c: Fix common/ includes.
6010         * i386-tdep.c: Fix common/ includes.
6011         * i386-linux-tdep.c: Fix common/ includes.
6012         * i386-linux-nat.c: Fix common/ includes.
6013         * i386-go32-tdep.c: Fix common/ includes.
6014         * i386-fbsd-tdep.c: Fix common/ includes.
6015         * i386-fbsd-nat.c: Fix common/ includes.
6016         * guile/scm-type.c: Fix common/ includes.
6017         * guile/guile.c: Fix common/ includes.
6018         * go32-nat.c: Fix common/ includes.
6019         * gnu-nat.c: Fix common/ includes.
6020         * gdbthread.h: Fix common/ includes.
6021         * gdbarch-selftests.c: Fix common/ includes.
6022         * gdb_usleep.c: Fix common/ includes.
6023         * gdb_select.h: Fix common/ includes.
6024         * gdb_bfd.c: Fix common/ includes.
6025         * gcore.c: Fix common/ includes.
6026         * fork-child.c: Fix common/ includes.
6027         * findvar.c: Fix common/ includes.
6028         * fbsd-nat.c: Fix common/ includes.
6029         * event-top.c: Fix common/ includes.
6030         * event-loop.c: Fix common/ includes.
6031         * dwarf2read.c: Fix common/ includes.
6032         * dwarf2loc.c: Fix common/ includes.
6033         * dwarf2-frame.c: Fix common/ includes.
6034         * dwarf-index-cache.c: Fix common/ includes.
6035         * dtrace-probe.c: Fix common/ includes.
6036         * disasm-selftests.c: Fix common/ includes.
6037         * defs.h: Fix common/ includes.
6038         * csky-tdep.c: Fix common/ includes.
6039         * cp-valprint.c: Fix common/ includes.
6040         * cp-support.h: Fix common/ includes.
6041         * cp-support.c: Fix common/ includes.
6042         * corelow.c: Fix common/ includes.
6043         * completer.h: Fix common/ includes.
6044         * completer.c: Fix common/ includes.
6045         * compile/compile.c: Fix common/ includes.
6046         * compile/compile-loc2c.c: Fix common/ includes.
6047         * compile/compile-cplus-types.c: Fix common/ includes.
6048         * compile/compile-cplus-symbols.c: Fix common/ includes.
6049         * command.h: Fix common/ includes.
6050         * cli/cli-dump.c: Fix common/ includes.
6051         * cli/cli-cmds.c: Fix common/ includes.
6052         * charset.c: Fix common/ includes.
6053         * build-id.c: Fix common/ includes.
6054         * btrace.h: Fix common/ includes.
6055         * btrace.c: Fix common/ includes.
6056         * breakpoint.h: Fix common/ includes.
6057         * breakpoint.c: Fix common/ includes.
6058         * ax.h:
6059         (enum agent_op): Fix common/ includes.
6060         * ax-general.c (struct aop_map): Fix common/ includes.
6061         * ax-gdb.c: Fix common/ includes.
6062         * auxv.c: Fix common/ includes.
6063         * auto-load.c: Fix common/ includes.
6064         * arm-tdep.c: Fix common/ includes.
6065         * arch/riscv.c: Fix common/ includes.
6066         * arch/ppc-linux-common.c: Fix common/ includes.
6067         * arch/i386.c: Fix common/ includes.
6068         * arch/arm.c: Fix common/ includes.
6069         * arch/arm-linux.c: Fix common/ includes.
6070         * arch/arm-get-next-pcs.c: Fix common/ includes.
6071         * arch/amd64.c: Fix common/ includes.
6072         * arch/aarch64.c: Fix common/ includes.
6073         * arch/aarch64-insn.c: Fix common/ includes.
6074         * arch-utils.c: Fix common/ includes.
6075         * amd64-windows-tdep.c: Fix common/ includes.
6076         * amd64-tdep.c: Fix common/ includes.
6077         * amd64-sol2-tdep.c: Fix common/ includes.
6078         * amd64-obsd-tdep.c: Fix common/ includes.
6079         * amd64-nbsd-tdep.c: Fix common/ includes.
6080         * amd64-linux-tdep.c: Fix common/ includes.
6081         * amd64-linux-nat.c: Fix common/ includes.
6082         * amd64-fbsd-tdep.c: Fix common/ includes.
6083         * amd64-fbsd-nat.c: Fix common/ includes.
6084         * amd64-dicos-tdep.c: Fix common/ includes.
6085         * amd64-darwin-tdep.c: Fix common/ includes.
6086         * agent.c: Fix common/ includes.
6087         * ada-lang.h: Fix common/ includes.
6088         * ada-lang.c: Fix common/ includes.
6089         * aarch64-tdep.c: Fix common/ includes.
6090
6091 2019-01-25  Tom Tromey  <tom@tromey.com>
6092
6093         * common/create-version.sh: Use common/version.h.
6094
6095 2019-01-24  Pedro Alves  <palves@redhat.com>
6096
6097         * infrun.c (signal_stop, signal_print, signal_program)
6098         (signal_catch, signal_pass): Now arrays instead of pointers.
6099         (update_signals_program_target, do_target_resume)
6100         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6101         * linux-nat.c (linux_nat_target::pass_signals)
6102         (linux_nat_target::create_inferior, linux_nat_target::attach):
6103         Adjust.
6104         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6105         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6106         * procfs.c (procfs_target::pass_signals): Adjust.
6107         * record-full.c (record_full_target::resume): Adjust.
6108         * remote.c (remote_target::pass_signals)
6109         (remote_target::program_signals): Adjust.
6110         * target-debug.h (target_debug_print_signals): Now takes a
6111         gdb::array_view as parameter.  Adjust.
6112         * target.h (target_ops) <pass_signals, program_signals>: Replace
6113         pointer and length parameters with gdb::array_view.
6114         (target_pass_signals, target_program_signals): Likewise.
6115         * target-delegates.c: Regenerate.
6116
6117 2019-01-24  Pedro Alves  <palves@redhat.com>
6118
6119         * common/forward-scope-exit.h
6120         (forward_scope_exit::forward_scope_exit): Pass arguments to
6121         m_bind_function directly, instead of creating a std::bind and
6122         copying that.
6123
6124 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6125
6126         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6127         for static members.
6128         (pass_in_v_vfp_candidate): Likewise.
6129
6130 2019-01-23  Tom Tromey  <tom@tromey.com>
6131             Pedro Alves  <palves@redhat.com>
6132
6133         * regcache.c (class regcache_invalidator): Remove.
6134         (regcache::raw_write): Use make_scope_exit.
6135
6136 2019-01-23  Tom Tromey  <tom@tromey.com>
6137
6138         * ui-out.h (class ui_out_emit_type): Update comment.
6139
6140 2019-01-23  Tom Tromey  <tom@tromey.com>
6141
6142         * infrun.c (fetch_inferior_event): Update comment.
6143
6144 2019-01-23  Tom Tromey  <tom@tromey.com>
6145             Pedro Alves  <palves@redhat.com>
6146
6147         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6148         parameter.
6149         (fetch_inferior_event): Use SCOPE_EXIT.
6150
6151
6152 2019-01-23  Tom Tromey  <tom@tromey.com>
6153             Pedro Alves  <palves@redhat.com>
6154
6155         * infrun.c (disable_thread_events): Delete.
6156         (stop_all_threads): Use SCOPE_EXIT.
6157
6158 2019-01-23  Tom Tromey  <tom@tromey.com>
6159             Pedro Alves  <palves@redhat.com>
6160
6161         * symfile.c: Include forward-scope-exit.h.
6162         (clear_symtab_users_cleanup): Replace forward declaration with
6163         a FORWARD_SCOPE_EXIT.
6164         (syms_from_objfile_1): Use the forward_scope_exit and
6165         gdb::optional instead of cleanup_function.
6166         (reread_symbols): Use the forward_scope_exit instead of
6167         cleanup_function.
6168         (clear_symtab_users_cleanup): Remove function.
6169
6170 2019-01-23  Tom Tromey  <tom@tromey.com>
6171             Pedro Alves  <palves@redhat.com>
6172
6173         * linux-nat.c: Include scope-exit.h.
6174         (cleanup_target_stop): Remove.
6175         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6176         SCOPE_EXIT.
6177
6178 2019-01-23  Tom Tromey  <tom@tromey.com>
6179             Pedro Alves  <palves@redhat.com>
6180
6181         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6182         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6183
6184 2019-01-23  Tom Tromey  <tom@tromey.com>
6185             Andrew Burgess  <andrew.burgess@embecosm.com>
6186             Pedro Alves  <palves@redhat.com>
6187
6188         * infrun.c (fetch_inferior_event): Use scope_exit.
6189         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6190         * top.c (execute_command): Use scope_exit.
6191         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6192         * utils.c (do_bpstat_clear_actions_cleanup)
6193         (make_bpstat_clear_actions_cleanup): Remove.
6194
6195 2019-01-23  Tom Tromey  <tom@tromey.com>
6196             Pedro Alves  <palves@redhat.com>
6197
6198         * infrun.c: Include "common/scope-exit.h"
6199         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6200         (wait_for_inferior): Use SCOPE_EXIT.
6201         (fetch_inferior_event): Use scope_exit.
6202
6203 2019-01-23  Tom Tromey  <tom@tromey.com>
6204             Pedro Alves  <palves@redhat.com>
6205
6206         * breakpoint.c (create_breakpoint): Remove cleanup.
6207
6208 2019-01-23  Tom Tromey  <tom@tromey.com>
6209             Andrew Burgess  <andrew.burgess@embecosm.com>
6210             Pedro Alves  <palves@redhat.com>
6211
6212 2019-01-23  Pedro Alves  <palves@redhat.com>
6213
6214         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6215
6216 2019-01-23  Pedro Alves  <palves@redhat.com>
6217             Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * gdbthread.h: Include "common/forward-scope-exit.h".
6220         (scoped_finish_thread_state): Redefine custom class in terms of
6221         forward_scope_exit.
6222
6223 2019-01-23  Pedro Alves  <palves@redhat.com>
6224             Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * common/forward-scope-exit.h: New file.
6227
6228 2019-01-23  Pedro Alves  <palves@redhat.com>
6229             Andrew Burgess  <andrew.burgess@embecosm.com>
6230             Tom Tromey  <tom@tromey.com>
6231
6232         * common/scope-exit.h: New file.
6233
6234 2019-01-23  Pedro Alves  <palves@redhat.com>
6235
6236         * common/preprocessor.h (ESC): Rename to ...
6237         (ESC_PARENS): ... this.
6238         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6239         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6240
6241 2019-01-23  Tom Tromey  <tom@tromey.com>
6242
6243         * language.h (class scoped_switch_to_sym_language_if_auto):
6244         Initialize m_lang in both cases.
6245
6246 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6247
6248         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6249         with XCNEW.
6250
6251 2019-01-22  Tom Tromey  <tom@tromey.com>
6252
6253         * corelow.c: Do not include sys/file.h.
6254
6255 2019-01-22  Tom Tromey  <tom@tromey.com>
6256
6257         * tui/tui-wingeneral.h: Include gdb_curses.h.
6258
6259 2019-01-22  Tom Tromey  <tom@tromey.com>
6260
6261         * source-cache.h (class source_cache) <get_source_lines,
6262         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6263
6264 2019-01-22  Tom Tromey  <tom@tromey.com>
6265
6266         * remote-fileio.h (struct remote_target): Declare.
6267
6268 2019-01-22  Tom Tromey  <tom@tromey.com>
6269
6270         * python/py-arch.c: Do not include py-ref.h.
6271         * python/py-bpevent.c: Do not include py-ref.h.
6272         * python/py-cmd.c: Do not include py-ref.h.
6273         * python/py-continueevent.c: Do not include py-ref.h.
6274         * python/py-event.h: Do not include py-ref.h.
6275         * python/py-evtregistry.c: Do not include py-ref.h.
6276         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6277         * python/py-frame.c: Do not include py-ref.h.
6278         * python/py-framefilter.c: Do not include py-ref.h.
6279         * python/py-function.c: Do not include py-ref.h.
6280         * python/py-infevents.c: Do not include py-ref.h.
6281         * python/py-linetable.c: Do not include py-ref.h.
6282         * python/py-objfile.c: Do not include py-ref.h.
6283         * python/py-param.c: Do not include py-ref.h.
6284         * python/py-prettyprint.c: Do not include py-ref.h.
6285         * python/py-progspace.c: Do not include py-ref.h.
6286         * python/py-symbol.c: Do not include py-ref.h.
6287         * python/py-symtab.c: Do not include py-ref.h.
6288         * python/py-type.c: Do not include py-ref.h.
6289         * python/py-unwind.c: Do not include py-ref.h.
6290         * python/py-utils.c: Do not include py-ref.h.
6291         * python/py-value.c: Do not include py-ref.h.
6292         * python/py-varobj.c: Do not include py-ref.h.
6293         * python/py-xmethods.c: Do not include py-ref.h.
6294         * python/python.c: Do not include py-ref.h.
6295         * varobj.c: Do not include py-ref.h.
6296
6297 2019-01-22  Tom Tromey  <tom@tromey.com>
6298
6299         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6300         keyword for bcache.
6301
6302 2019-01-22  Tom Tromey  <tom@tromey.com>
6303
6304         * compile/compile-cplus-types.c: Remove a comment by #include.
6305
6306 2019-01-22  Tom Tromey  <tom@tromey.com>
6307
6308         * compile/gcc-c-plugin.h: Include compile-internal.h.
6309
6310 2019-01-22  Tom Tromey  <tom@tromey.com>
6311
6312         * stabsread.c (EXTERN): Do not define.
6313         (symnum, next_symbol_text_func, processing_gcc_compilation)
6314         (within_function, global_sym_chain, global_stabs)
6315         (previous_stab_code, this_object_header_files)
6316         (n_this_object_header_files)
6317         (n_allocated_this_object_header_files): Define.
6318         * stabsread.h (EXTERN): Never define.  Use "extern".
6319
6320 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321
6322         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6323         history_value.
6324
6325 2019-01-21  Tom Tromey  <tom@tromey.com>
6326
6327         * ui-out.c: Fix includes.
6328         * tui/tui-source.c: Fix includes.
6329         * target.c: Fix includes.
6330         * remote.c: Fix includes.
6331         * regcache.c: Fix includes.
6332         * python/py-block.c: Fix includes.
6333         * printcmd.c: Fix includes.
6334         * or1k-tdep.c: Fix includes.
6335         * mi/mi-main.c: Fix includes.
6336         * m32r-tdep.c: Fix includes.
6337         * csky-tdep.c: Fix includes.
6338         * compile/compile-cplus-types.c: Fix includes.
6339         * cli/cli-interp.c: Fix includes.
6340
6341 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6344         for padding.
6345
6346 2019-01-16  Tom Tromey  <tom@tromey.com>
6347
6348         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6349         earlier.
6350         (struct objfile) <msymbols_range>: Move from top level.
6351         <msymbols>: New method.
6352         (class objfile_msymbols): Remove.
6353         * symtab.c (default_collect_symbol_completion_matches_break_on):
6354         Update.
6355         * symmisc.c (dump_msymbols): Update.
6356         * stabsread.c (scan_file_globals): Update.
6357         * objc-lang.c (info_selectors_command, info_classes_command)
6358         (find_methods): Update.
6359         * minsyms.c (find_solib_trampoline_target): Update.
6360         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6361         * coffread.c (coff_symfile_read): Update.
6362         * ada-lang.c (ada_lookup_simple_minsym)
6363         (ada_collect_symbol_completion_matches): Update.
6364
6365 2019-01-16  Tom Tromey  <tom@tromey.com>
6366
6367         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6368         type.  Remove no-argument constructor.
6369         <iterator::operator++>: Simplify.
6370         <begin>: Update.
6371         <end>: Use minimal_symbol_count.
6372
6373 2019-01-16  Tom Tromey  <tom@tromey.com>
6374
6375         * objfiles.h (struct objfile) <psymtabs>: New method.
6376         (class objfile_psymtabs): Remove.
6377         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6378         typedef.
6379         <range>: New method.
6380         (require_partial_symbols): Change return type.
6381         * psymtab.c (require_partial_symbols)
6382         (psym_expand_symtabs_matching): Update.
6383         * mdebugread.c (parse_partial_symbols): Update.
6384         * dbxread.c (dbx_end_psymtab): Update.
6385
6386 2019-01-15  Tom Tromey  <tom@tromey.com>
6387
6388         * symtab.c (lookup_objfile_from_block)
6389         (lookup_symbol_in_objfile_symtabs)
6390         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6391         (find_line_symtab, info_sources_command)
6392         (default_collect_symbol_completion_matches_break_on)
6393         (make_source_files_completion_list): Update.
6394         * symmisc.c (print_objfile_statistics, dump_objfile)
6395         (maintenance_print_symbols, maintenance_info_symtabs)
6396         (maintenance_check_symtabs, maintenance_info_line_tables):
6397         Update.
6398         * source.c (select_source_symtab)
6399         (forget_cached_source_info_for_objfile): Update.
6400         * objfiles.h (class objfile_compunits): Remove.
6401         (struct objfile) <compunits_range>: New typedef.
6402         (compunits): New method.
6403         * objfiles.c (objfile_relocate1): Update.
6404         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6405         * maint.c (count_symtabs_and_blocks): Update.
6406         * linespec.c (iterate_over_all_matching_symtabs): Update.
6407         * cp-support.c (add_symbol_overload_list_qualified): Update.
6408         * coffread.c (coff_symtab_read): Update.
6409         * ada-lang.c (add_nonlocal_symbols)
6410         (ada_collect_symbol_completion_matches)
6411         (ada_add_global_exceptions): Update.
6412
6413 2019-01-15  Tom Tromey  <tom@tromey.com>
6414
6415         * progspace.h (program_space) <objfiles_safe_range>: New
6416         typedef.
6417         <objfiles_safe>: New method.
6418         * objfiles.h (class all_objfiles_safe): Remove.
6419         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6420         * jit.c (jit_inferior_exit_hook): Update.
6421
6422 2019-01-17  Tom Tromey  <tom@tromey.com>
6423
6424         * progspace.h (program_space) <objfiles_range>: New typedef.
6425         <objfiles>: New method.
6426         <objfiles_head>: Rename from objfiles.
6427         (object_files): Update.
6428         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6429         * guile/scm-pretty-print.c
6430         (ppscm_find_pretty_printer_from_objfiles): Update.
6431         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6432         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6433         Update.
6434         * python/py-progspace.c (pspy_get_objfiles): Update.
6435         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6436         Update.
6437         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6438         (objfpy_lookup_objfile_by_build_id): Update.
6439         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6440         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6441         Update.
6442         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6443         (expand_symtab_containing_pc, lookup_objfile_from_block)
6444         (lookup_static_symbol, basic_lookup_transparent_type)
6445         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6446         (find_line_symtab, info_sources_command)
6447         (default_collect_symbol_completion_matches_break_on)
6448         (make_source_files_completion_list, find_main_name): Update.
6449         * symmisc.c (print_symbol_bcache_statistics)
6450         (print_objfile_statistics, maintenance_print_symbols)
6451         (maintenance_print_msymbols, maintenance_print_objfiles)
6452         (maintenance_info_symtabs, maintenance_check_symtabs)
6453         (maintenance_expand_symtabs, maintenance_info_line_tables):
6454         Update.
6455         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6456         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6457         (map_overlay_command, unmap_overlay_command)
6458         (simple_overlay_update, expand_symtabs_matching)
6459         (map_symbol_filenames): Update.
6460         * symfile-debug.c (set_debug_symfile): Update.
6461         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6462         Update.
6463         * source.c (select_source_symtab, forget_cached_source_info):
6464         Update.
6465         * solib.c (solib_read_symbols): Update.
6466         * solib-spu.c (append_ocl_sos): Update.
6467         * psymtab.c (maintenance_print_psymbols)
6468         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6469         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6470         * printcmd.c (info_symbol_command): Update.
6471         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6472         Update.
6473         * objfiles.h (class all_objfiles): Remove.
6474         * objfiles.c (have_partial_symbols, have_full_symbols)
6475         (have_minimal_symbols, qsort_cmp, update_section_map)
6476         (shared_objfile_contains_address_p)
6477         (default_iterate_over_objfiles_in_search_order): Update.
6478         * objc-lang.c (info_selectors_command, info_classes_command)
6479         (find_methods): Update.
6480         * minsyms.c (find_solib_trampoline_target): Update.
6481         * maint.c (maintenance_info_sections)
6482         (maintenance_translate_address, count_symtabs_and_blocks):
6483         Update.
6484         * main.c (captured_main_1): Update.
6485         * linux-thread-db.c (try_thread_db_load_from_pdir)
6486         (has_libpthread): Update.
6487         * linespec.c (iterate_over_all_matching_symtabs)
6488         (search_minsyms_for_name): Update.
6489         * jit.c (jit_find_objf_with_entry_addr): Update.
6490         * hppa-tdep.c (find_unwind_entry)
6491         (hppa_lookup_stub_minimal_symbol): Update.
6492         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6493         Update.
6494         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6495         (elf_gnu_ifunc_resolve_by_got): Update.
6496         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6497         * dwarf-index-write.c (save_gdb_index_command): Update.
6498         * cp-support.c (add_symbol_overload_list_qualified): Update.
6499         * breakpoint.c (create_overlay_event_breakpoint)
6500         (create_longjmp_master_breakpoint)
6501         (create_std_terminate_master_breakpoint)
6502         (create_exception_master_breakpoint): Update.
6503         * blockframe.c (find_pc_partial_function): Update.
6504         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6505         (ada_collect_symbol_completion_matches)
6506         (ada_add_global_exceptions): Update.
6507
6508 2019-01-17  Tom Tromey  <tom@tromey.com>
6509
6510         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6511         declare VEC.
6512         (solib_target_parse_libraries): Change return type.
6513         (library_list_start_segment, library_list_start_section)
6514         (library_list_end_library, library_list_start_library); Update.
6515         (solib_target_free_library_list): Remove.
6516         (solib_target_parse_libraries): Remove cleanup.  Change return
6517         type.
6518         (solib_target_current_sos): Update.
6519
6520 2019-01-17  Tom Tromey  <tromey@bapiya>
6521
6522         * valprint.c: Replace "the the" with "the".
6523         * symtab.c: Replace "the the" with "the".
6524         * solib.c: Replace "the the" with "the".
6525         * solib-dsbt.c: Replace "the the" with "the".
6526         * linespec.c: Replace "the the" with "the".
6527         * dwarf2loc.h: Replace "the the" with "the".
6528         * amd64-windows-tdep.c: Replace "the the" with "the".
6529         * aarch64-tdep.c: Replace "the the" with "the".
6530
6531 2019-01-16  Keith Seitz  <keiths@redhat.com>
6532
6533         PR gdb/23773
6534         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6535         <builder>: Rename to ..
6536         <m_builder>: ... this and make private.
6537         (dwarf2_cu::get_builder): New method.  Change all users of
6538         `builder' to use this method.
6539         (dwarf2_start_symtab): Move to ...
6540         (dwarf2_cu::start_symtab): ... here.  Update all callers
6541         (setup_type_unit_groups): Move to ...
6542         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6543         callers.
6544         (dwarf2_cu::reset_builder): New method.
6545         (process_full_compunit, process_full_type_unit): Use
6546         dwarf2_cu::reset_builder.
6547         (follow_die_offset): Record the ancestor CU if it is different
6548         from the followed DIE's CU.
6549         (follow_die_sig_1): Likewise.
6550
6551 2019-01-15  Tom Tromey  <tom@tromey.com>
6552
6553         * remote.c (class remote_state) <buf>: Now a char_vector.
6554         <buf_size>: Remove.
6555         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6556         parameter.
6557         (remote_target::getpkt_or_notif_sane_1)
6558         (remote_target::getpkt_sane)
6559         (remote_target::getpkt_or_notif_sane): Likewise.
6560         (class remote_target) <putpkt>: New overload.
6561         (remote_target::read_frame): Change type of "buf_p".  Remove
6562         sizeof_p parameter.
6563         (packet_ok): New overload.
6564         (packet_check_result): New overload.
6565         Update all uses.
6566
6567 2019-01-14  Tom Tromey  <tom@tromey.com>
6568
6569         * remote-notif.c (handle_notification, remote_notif_ack)
6570         (remote_notif_parse): Make "buf" const.
6571         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6572         const.
6573         (remote_notif_parse, remote_notif_ack, handle_notification):
6574         Likewise.
6575         * remote.c (remote_notif_stop_parse): Make "buf" const.
6576         (remote_target::remote_parse_stop_reply): Make "buf" const.
6577         (remote_notif_stop_ack): Make "buf" const.
6578
6579 2019-01-14  Tom Tromey  <tom@tromey.com>
6580
6581         * remote.c (remote_console_output): Make parameter const.
6582
6583 2019-01-14  Tom Tromey  <tom@tromey.com>
6584
6585         * target-debug.h (target_debug_print_signals): Constify.
6586         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6587         * procfs.c (procfs_target::pass_signals): Update.
6588         * linux-nat.c (linux_nat_target::pass_signals): Update.
6589         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6590         * target-delegates.c: Rebuild.
6591         * remote.c (remote_target::program_signals): Update.
6592         (remote_target::pass_signals): Update.
6593         * target.c (target_pass_signals): Constify argument.
6594         (target_program_signals): Likewise.
6595         * target.h (struct target_ops) <pass_signals, program_signals>:
6596         Constify argument.
6597         (target_pass_signals, target_program_signals): Constify argument.
6598
6599 2019-01-14  Tom Tromey  <tom@tromey.com>
6600
6601         PR tui/28819:
6602         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6603
6604 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6605
6606         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6607         field.
6608         * rs6000-tdep.c: Include reggroups.h.
6609         (IS_V_ALIAS_PSEUDOREG): Define.
6610         (rs6000_register_name): Return names for the "vX" aliases.
6611         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6612         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6613         aliases.  Call default_register_reggroup_p for all other
6614         pseudo-registers.
6615         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6616         New functions.
6617         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6618         Handle "vX" aliases.
6619         (v_alias_pseudo_register_collect): New function.
6620         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6621         (rs6000_gdbarch_init): Initialize "vX" aliases as
6622         pseudo-registers.  Restore registration of
6623         rs6000_pseudo_register_reggroup_p with
6624         set_tdesc_pseudo_register_reggroup_p.
6625
6626 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6627
6628         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6629         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6630         set_gdbarch_num_pseudo_regs.
6631
6632 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6633
6634         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6635         Remove arg prefixname, add do_set and do_show.
6636         Add member functions set_list and show_list.
6637         * cli/cli-style.c (class cli_style_option): Update accordingly.
6638         (style_set_list): Move to file scope.
6639         (style_show_list): Likewise.
6640         (set_style): Call help_list.
6641         (show_style): Call cmd_show_list.
6642         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6643         Update to use the new macro.
6644
6645 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6646
6647         * ada-lang.c (_initialize_ada_language): Expand the help text
6648         for the "catch exception" command.
6649
6650 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6651
6652         * symtab.c (matching_obj_sections): Initialize obj,
6653         declare it closer to its usage.
6654
6655 2019-01-10  Tom Tromey  <tom@tromey.com>
6656
6657         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6658         (basic_inf_threads_range): Remove.
6659         (inf_threads_range, inf_non_exited_threads_range)
6660         (safe_inf_threads_range): Use next_adapter.
6661
6662 2019-01-10  Keith Seitz  <keiths@redhat.com>
6663
6664         PR gdb/23712
6665         PR symtab/23010
6666         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6667         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6668
6669 2019-01-10  Keith Seitz  <keiths@redhat.com>
6670
6671         PR gdb/23712
6672         PR symtab/23010
6673         * dictionary.c (pending_to_vector): Remove.
6674         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6675         Remove _1 suffix, replacing functions of the same name.  Update
6676         all callers.
6677         (dict_create_hashed, dict_create_hashed_expandable)
6678         (dict_create_linear, dict_create_linear_expandable, dict_free)
6679         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6680         Make functions static.
6681
6682 2019-01-10  Keith Seitz  <keiths@redhat.com>
6683
6684         PR gdb/23712
6685         PR symtab/23010
6686         * dictionary.h (struct dictionary): Replace declaration with
6687         multidictionary.
6688         (dict_create_hashed, dict_create_hashed_expandable)
6689         (dict_create_linear, dict_create_linear_expandable)
6690         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6691         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6692         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6693         taking multidictionary argument.
6694         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6695         * block.h (struct block) <dict>: Change to multidictionary
6696         and rename `multidict'.
6697         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6698         symmisc.c: Update all dictionary references to multidictionary.
6699
6700 2019-01-10  Keith Seitz  <keiths@redhat.com>
6701
6702         PR gdb/23712
6703         PR symtab/23010
6704         * dictionary.c: Include unordered_map.
6705         (pending_to_vector): New function.
6706         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6707         Rewrite the non-"_1" functions to take vector instead
6708         of linked list.
6709         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6710         "new" _1 versions of the same name.
6711         (multidictionary): Define.
6712         (std::hash<enum language): New definition.
6713         (collate_pending_symbols_by_language, mdict_create_hashed)
6714         (mdict_create_hashed_expandable, mdict_create_linear)
6715         (mdict_create_linear_expandable, mdict_free)
6716         (find_language_dictionary, create_new_language_dictionary)
6717         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6718         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6719         (mdict_size, mdict_empty): New functions.
6720         * dictionary.h (mdict_iterator): Define.
6721
6722 2019-01-10  Pedro Alves  <palves@redhat.com>
6723
6724         * breakpoint.c (read_uploaded_action)
6725         (create_tracepoint_from_upload): Adjust to use
6726         gdb::unique_xmalloc_ptr.
6727         * ctf.c (ctf_write_uploaded_tp):
6728         (SET_ARRAY_FIELD): Use emplace_back.
6729         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6730         * tracefile-tfile.c (tfile_write_uploaded_tp):
6731         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6732         gdb::unique_xmalloc_ptr.
6733         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6734         at_string, cond_string, cmd_strings>: Replace char pointers
6735         with gdb::unique_xmalloc_ptr.
6736
6737 2019-01-10  Pedro Alves  <palves@redhat.com>
6738
6739         * solib-target.c (library_list_start_library): Don't xstrdup name.
6740
6741 2019-01-10  Pedro Alves  <palves@redhat.com>
6742
6743         * mdebugread.c (parse_partial_symbols): Use
6744         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6745
6746 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * linux-fork.c (scoped_switch_fork_info)
6749         <~scoped_switch_fork_info>: Fix incorrect variable name.
6750
6751 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * linux-fork.c (scoped_switch_fork_info)
6754         <scoped_switch_fork_info>: Make explicit.
6755         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6756
6757 2019-01-10  Tom Tromey  <tom@tromey.com>
6758
6759         * objfiles.h (objfile::reset_psymtabs): Update.
6760         * objfiles.c (objfile::objfile): Update.
6761         * psymtab.h (psymtab_storage::obstack): Update.
6762         (psymtab_storage::m_obstack): Use gdb::optional.
6763         (class psymtab_storage): Update comment.  Remove objfile
6764         parameter.
6765         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6766
6767 2019-01-10  Tom Tromey  <tom@tromey.com>
6768
6769         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6770         <free_psymtabs>: Now private.
6771         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6772         (allocate_psymtab): Use new method.
6773
6774 2019-01-10  Tom Tromey  <tom@tromey.com>
6775
6776         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6777         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6778         * mdebugread.c (parse_partial_symbols): Use
6779         allocate_dependencies.
6780         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6781         allocate_dependencies.
6782         (process_psymtab_comp_unit_reader)
6783         (build_type_psymtab_dependencies): Likewise.
6784         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6785
6786 2019-01-10  Tom Tromey  <tom@tromey.com>
6787
6788         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6789         PSYMBOL_SET_LANGUAGE.
6790         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6791
6792 2019-01-10  Tom Tromey  <tom@tromey.com>
6793
6794         * psymtab.h (psymtab_storage::obstack): New method.
6795         <m_obstack>: Rename from obstack; now private.
6796         * psymtab.c (psymtab_storage): Update.
6797         * dwarf2read.c (create_addrmap_from_index)
6798         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6799         Update.
6800
6801 2019-01-10  Tom Tromey  <tom@tromey.com>
6802
6803         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6804         * objfiles.h (objfile::reset_psymtabs): New method.
6805
6806 2019-01-10  Tom Tromey  <tom@tromey.com>
6807
6808         * symmisc.c (print_symbol_bcache_statistics): Update.
6809         (print_objfile_statistics): Update.
6810         * symfile.c (reread_symbols): Update.
6811         * psymtab.h (class psymtab_storage): New.
6812         * psymtab.c (psymtab_storage): New constructor.
6813         (~psymtab_storage): New destructor.
6814         (require_partial_symbols): Update.
6815         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6816         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6817         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6818         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6819         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6820         (start_psymtab_common, end_psymtab_common)
6821         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6822         (allocate_psymtab): Update.
6823         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6824         Update.
6825         (dump_psymtab_addrmap, maintenance_print_psymbols)
6826         (maintenance_check_psymtabs): Update.
6827         (class objfile_psymtabs): Move to objfiles.h.
6828         * psympriv.h (discard_psymtab): Now inline.
6829         (psymtab_discarder::psymtab_discarder): Update.
6830         (psymtab_discarder::~psymtab_discarder): Update.
6831         (ALL_OBJFILE_PSYMTABS): Rewrite.
6832         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6833         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6834         Remove fields.
6835         <partial_symtabs>: New field.
6836         (class objfile_psymtabs): Move from psymtab.h.  Update.
6837         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6838         psymbol_cache.
6839         (objfile::~objfile): Don't destroy psymbol_cache.
6840         * mdebugread.c (parse_partial_symbols): Update.
6841         * dwarf2read.c (create_addrmap_from_index)
6842         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6843         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6844         (add_partial_subprogram, dwarf2_ranges_read): Update.
6845         * dwarf-index-write.c (write_address_map)
6846         (write_one_signatured_type, recursively_write_psymbols)
6847         (class debug_names, class debug_names, write_psymtabs_to_index):
6848         Update.
6849
6850 2019-01-10  Tom Tromey  <tom@tromey.com>
6851
6852         * symtab.h (SYMBOL_SET_NAMES): Update.
6853         (symbol_set_names): Update.
6854         (MSYMBOL_SET_NAMES): Update.
6855         * symtab.c (symbol_set_names): Change argument to be an
6856         objfile_per_bfd_storage.
6857         * psymtab.c (add_psymbol_to_bcache): Update.
6858         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6859
6860 2019-01-10  Tom Tromey  <tom@tromey.com>
6861
6862         * symtab.c (create_demangled_names_hash): Change argument to be an
6863         objfile_per_bfd_storage.
6864         (symbol_set_names): Update.
6865
6866 2019-01-10  Tom Tromey  <tom@tromey.com>
6867
6868         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6869         init_psymbol_list.
6870         * psymtab.c (init_psymbol_list): Do nothing if already called.
6871         * psympriv.h (init_psymbol_list): Add comment.
6872         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6873         init_psymbol_list.
6874         * dbxread.c (dbx_symfile_read): Unconditionally call
6875         init_psymbol_list.
6876
6877 2019-01-10  Tom Tromey  <tom@tromey.com>
6878
6879         * xcoffread.c (scan_xcoff_symtab): Update.
6880         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6881         "where".
6882         * mdebugread.c (parse_partial_symbols)
6883         (handle_psymbol_enumerators): Update.
6884         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6885         * dbxread.c (read_dbx_symtab): Update.
6886         * psympriv.h (psymbol_placement): New enum.
6887         (add_psymbol_to_list): Update.
6888
6889 2019-01-10  Tom Tromey  <tom@tromey.com>
6890
6891         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6892         static_psymbols parameters.
6893         (scan_xcoff_symtab): Update.
6894         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6895         static_psymbols parameters.
6896         * psympriv.h (start_psymtab_common): Update.
6897         * mdebugread.c (parse_partial_symbols): Update.
6898         * dwarf2read.c (create_partial_symtab): Update.
6899         * dbxread.c (read_dbx_symtab): Update.
6900         (start_psymtab): Remove global_psymbols and static_psymbols
6901         parameters.
6902
6903 2019-01-10  Tom Tromey  <tom@tromey.com>
6904
6905         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6906         * psymtab.c (allocate_psymtab): Add comment.
6907         * psympriv.h (allocate_psymtab): Add comment.
6908         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6909         initializations.
6910         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6911
6912 2019-01-10  Tom Tromey  <tom@tromey.com>
6913
6914         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6915         Don't declare.
6916         * mipsread.c: Include mdebugread.h.
6917         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6918         Declare.
6919         * elfread.c: Include mdebugread.h.
6920
6921 2019-01-09  Tom Tromey  <tom@tromey.com>
6922
6923         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6924         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6925         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6926         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6927         (psym_lookup_symbol, psym_find_last_source_symtab)
6928         (psym_forget_cached_source_info, psym_print_stats)
6929         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6930         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6931         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6932         (psym_find_compunit_symtab_by_address)
6933         (maintenance_print_psymbols, maintenance_info_psymtabs)
6934         (maintenance_check_psymtabs): Use ranged for.
6935         * psymtab.h (class objfile_psymtabs): New.
6936         (require_partial_symbols): Return objfile_psymtabs.
6937         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6938
6939 2019-01-09  Tom Tromey  <tom@tromey.com>
6940
6941         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6942         (find_pc_mapped_section, list_overlays_command)
6943         (map_overlay_command, unmap_overlay_command)
6944         (simple_overlay_update): Use all_objfiles.
6945         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6946         * printcmd.c (info_symbol_command): Use all_objfiles.
6947         * objfiles.h (ALL_OBJSECTIONS): Remove.
6948         * maint.c (maintenance_translate_address): Use all_objfiles.
6949         * gcore.c (gcore_create_callback): Use all_objfiles.
6950         (objfile_find_memory_regions): Likewise.
6951
6952 2019-01-09  Tom Tromey  <tom@tromey.com>
6953
6954         * symtab.c (find_line_symtab, info_sources_command)
6955         (make_source_files_completion_list): Use objfile_compunits.
6956         * source.c (select_source_symtab): Use objfile_compunits.
6957         * objfiles.h (struct objfile): Update comment.
6958         (ALL_OBJFILES): Remove.
6959         (ALL_FILETABS): Remove.
6960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6961         objfile_compunits.
6962
6963 2019-01-09  Tom Tromey  <tom@tromey.com>
6964
6965         * symmisc.c (print_objfile_statistics, dump_objfile)
6966         (maintenance_print_symbols): Use compunit_filetabs.
6967         * source.c (forget_cached_source_info_for_objfile): Use
6968         compunit_filetabs.
6969         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6970         (ALL_FILETABS): Use compunit_filetabs.
6971         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6972         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6973
6974 2019-01-09  Tom Tromey  <tom@tromey.com>
6975
6976         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6977         (compunit_filetabs): New.
6978         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6979         compunit_filetabs.
6980         (info_sources_command, make_source_files_completion_list): Remove
6981         declaration.
6982         * symmisc.c (print_objfile_statistics, dump_objfile)
6983         (maintenance_print_symbols): Remove declaration.
6984         (maintenance_info_symtabs): Use compunit_filetabs.
6985         (maintenance_info_line_tables): Likewise.
6986         * source.c (select_source_symtab): Change local variable name.
6987         (forget_cached_source_info_for_objfile): Remove declaration.
6988         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6989         * objfiles.c (objfile_relocate1): Remove declaration.
6990         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6991         declaration.
6992         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6993         * coffread.c (coff_symtab_read): Remove declaration.
6994         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6995         compunit_filetabs.
6996
6997 2019-01-09  Tom Tromey  <tom@tromey.com>
6998
6999         * symtab.c (lookup_objfile_from_block)
7000         (find_pc_sect_compunit_symtab, search_symbols)
7001         (default_collect_symbol_completion_matches_break_on): Use
7002         objfile_compunits.
7003         * objfiles.h (ALL_COMPUNITS): Remove.
7004         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7005         * cp-support.c (add_symbol_overload_list_qualified): Use
7006         objfile_compunits.
7007         * ada-lang.c (ada_collect_symbol_completion_matches)
7008         (ada_add_global_exceptions): Use objfile_compunits.
7009
7010 2019-01-09  Tom Tromey  <tom@tromey.com>
7011
7012         * source.c (select_source_symtab)
7013         (forget_cached_source_info_for_objfile): Remove declaration.
7014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7015         declaration.
7016         * maint.c (count_symtabs_and_blocks): Remove declaration.
7017         * cp-support.c (add_symbol_overload_list_qualified): Remove
7018         declaration.
7019         * coffread.c (coff_symtab_read): Remove declaration.
7020         * symtab.c (lookup_symbol_in_objfile_symtabs)
7021         (basic_lookup_transparent_type_1): Use objfile_compunits.
7022         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7023         (info_sources_command, search_symbols)
7024         (default_collect_symbol_completion_matches_break_on)
7025         (make_source_files_completion_list): Remove declaration.
7026         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7027         (ada_collect_symbol_completion_matches)
7028         (ada_add_global_exceptions): Remove declaration.
7029         * linespec.c (iterate_over_all_matching_symtabs): Use
7030         objfile_compunits.
7031         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7032         (class objfile_compunits): New.
7033         (ALL_COMPUNITS): Use objfile_compunits.
7034         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7035         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7036         objfile_compunits.
7037         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7038
7039 2019-01-09  Tom Tromey  <tom@tromey.com>
7040
7041         * symtab.c (search_symbols)
7042         (default_collect_symbol_completion_matches_break_on): Use
7043         objfile_msymbols.
7044         * ada-lang.c (ada_lookup_simple_minsym)
7045         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7046         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7047         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7048         objfile_msymbols.
7049         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7050         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7051         * objc-lang.c (find_methods): Use objfile_msymbols.
7052         (info_selectors_command, info_classes_command): Likewise.
7053         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7054         * objfiles.h (class objfile_msymbols): New.
7055         (ALL_OBJFILE_MSYMBOLS): Remove.
7056         (ALL_MSYMBOLS): Remove.
7057
7058 2019-01-09  Tom Tromey  <tom@tromey.com>
7059
7060         * common/next-iterator.h (next_adapter): Add Iterator template
7061         parameter.
7062         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7063         (class all_objfiles_safe): New.
7064         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7065         * objfiles.c (put_objfile_before): Update comment.
7066         (add_separate_debug_objfile): Likewise.
7067         (free_all_objfiles): Use all_objfiles_safe.
7068         (objfile_purge_solibs): Likewise.
7069
7070 2019-01-09  Tom Tromey  <tom@tromey.com>
7071
7072         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7073         (expand_symtab_containing_pc, lookup_static_symbol)
7074         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7075         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7076         all_objfiles.
7077         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7078         * breakpoint.c (create_overlay_event_breakpoint)
7079         (create_longjmp_master_breakpoint)
7080         (create_std_terminate_master_breakpoint)
7081         (create_exception_master_breakpoint): Use all_objfiles.
7082         * linux-thread-db.c (try_thread_db_load_from_pdir)
7083         (has_libpthread): Use all_objfiles.
7084         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7085         * linespec.c (iterate_over_all_matching_symtabs)
7086         (search_minsyms_for_name): Use all_objfiles.
7087         * maint.c (maintenance_info_sections): Use all_objfiles.
7088         * main.c (captured_main_1): Use all_objfiles.
7089         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7090         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7091         * guile/scm-pretty-print.c
7092         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7093         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7094         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7095         (maintenance_print_msymbols): Use all_objfiles.
7096         * source.c (select_source_symtab): Use all_objfiles.
7097         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7098         * symfile.c (remove_symbol_file_command)
7099         (expand_symtabs_matching, map_symbol_filenames): Use
7100         all_objfiles.
7101         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7102         all_objfiles.
7103         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7104         * objc-lang.c (find_methods): Use all_objfiles.
7105         * objfiles.c (have_partial_symbols, have_full_symbols)
7106         (have_minimal_symbols, qsort_cmp)
7107         (default_iterate_over_objfiles_in_search_order): Use
7108         all_objfiles.
7109         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7110         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7111         (maintenance_check_psymtabs): Use all_objfiles.
7112         (ALL_PSYMTABS): Remove.
7113         * compile/compile-object-run.c (do_module_cleanup): Use
7114         all_objfiles.
7115         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7116         * cp-support.c (add_symbol_overload_list_qualified): Use
7117         all_objfiles.
7118         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7119         Use all_objfiles.
7120         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7121         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7122         all_objfiles.
7123         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7124         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7125         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7126         Uses all_objfiles.
7127         * solib.c (solib_read_symbols): Use all_objfiles
7128
7129 2019-01-09  Tom Tromey  <tom@tromey.com>
7130
7131         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7132         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7133         all_objfiles.
7134         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7135         * symmisc.c (print_symbol_bcache_statistics)
7136         (print_objfile_statistics, maintenance_print_objfiles)
7137         (maintenance_info_symtabs, maintenance_check_symtabs)
7138         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7139         all_objfiles.
7140         * source.c (forget_cached_source_info): Use all_objfiles.
7141         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7142         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7143         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7144         * objfiles.c (update_section_map): Use all_objfiles.
7145         (shared_objfile_contains_address_p): Likewise.
7146         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7147         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7148
7149 2019-01-09  Tom Tromey  <tom@tromey.com>
7150
7151         * common/next-iterator.h: New file.
7152         * objfiles.h (class all_objfiles): New.
7153         (struct objfile_iterator): New.
7154
7155 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7156
7157         * NEWS: Move the description of the changed "frame", "select-frame",
7158          and "info frame" commands to the Changed commands section.
7159
7160 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7161
7162         * gdbtypes.c (check_stub_method_group): Remove handling of old
7163         mangling schemes.
7164         * linespec.c (find_methods): Likewise.
7165         * stabsread.c (read_member_functions): Likewise.
7166         * valops.c (search_struct_method): Likewise.
7167         (value_struct_elt_for_reference): Likewise.
7168         * NEWS: Mention this change.
7169
7170 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7171
7172         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7173         print_source_lines.
7174         * source.c (print_source_lines_base): Update line number check.
7175         (print_source_lines): New function.
7176         (source_lines_range::source_lines_range): New function.
7177         * source.h (class source_lines_range): New class.
7178         (print_source_lines): New declaration.
7179
7180 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7181
7182         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7183
7184 2019-01-08  Tom Tromey  <tom@tromey.com>
7185             Simon Marchi  <simon.marchi@ericsson.com>
7186
7187         PR gdb/24060
7188         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7189         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7190         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7191         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7192         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7193         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7194
7195 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * source.c (select_source_symtab): Move header comment to
7198         declaration in source.h.
7199         (forget_cached_source_info_for_objfile): Likewise.
7200         (forget_cached_source_info): Likewise.
7201         (identify_source_line): Likewise.
7202         * source.h (identify_source_line): Move declaration from symtab.h
7203         and add comment from source.c
7204         (print_source_lines): Likewise.
7205         (forget_cached_source_info_for_objfile): Likewise.
7206         (forget_cached_source_info): Likewise.
7207         (select_source_symtab): Likewise.
7208         (enum print_source_lines_flag): Move definition from symtab.h.
7209         * symtab.h (identify_source_line): Move declaration to source.h.
7210         (print_source_lines): Likewise.
7211         (forget_cached_source_info_for_objfile): Likewise.
7212         (forget_cached_source_info): Likewise.
7213         (select_source_symtab): Likewise.
7214         (enum print_source_lines_flag): Move definition to source.h.
7215         * tui/tui-hooks.c: Add 'source.h' include.
7216
7217 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7218
7219         * source.c (print_source_lines_base): Handle requests to print
7220         reverse line number sequences, and guard against empty lines
7221         string.
7222
7223 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7224
7225         * source.c (print_source_lines_base): Fix skip of '\r' if next
7226         character is '\n'.
7227
7228 2019-01-06  Tom Tromey  <tom@tromey.com>
7229
7230         * c-exp.y (struct c_parse_state) <macro_original_text,
7231         expansion_obstack>: New member.
7232         (macro_original_text, expansion_obstack): Remove globals.
7233         (scan_macro_expansion, scanning_macro_expansion)
7234         (finished_macro_expansion): Update.
7235         (scan_macro_cleanup): Remove.
7236         (yylex, c_parse): Update.
7237
7238 2019-01-06  Tom Tromey  <tom@tromey.com>
7239
7240         * c-exp.y (struct c_parse_state) <strings>: New member.
7241         (operator_stoken): Update.
7242
7243 2019-01-06  Tom Tromey  <tom@tromey.com>
7244
7245         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7246         (union type_stack_elt) <typelist_val>: Now a pointer to
7247         std::vector.
7248         (type_stack_cleanup): Don't declare.
7249         (push_typelist): Update.
7250         * parse.c (pop_typelist): Return a std::vector.
7251         (push_typelist): Take a std::vector.
7252         (follow_types): Update.  Do not free args.
7253         (type_stack_cleanup): Remove.
7254         * c-exp.y (struct c_parse_state): New.
7255         (cpstate): New global.
7256         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7257         (nonempty_typelist): Update.
7258         (func_mod): Create a new vector.
7259         (c_parse): Create a c_parse_state.
7260         (check_parameter_typelist): Do not delete params.
7261         (function_method): Update.  Do not delete type_list.
7262
7263 2019-01-06  Tom Tromey  <tom@tromey.com>
7264
7265         PR gdb/28155:
7266         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7267         check_typedef.
7268         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7269         (print_return_value): Likewise.
7270
7271 2019-01-05  Tom Tromey  <tom@tromey.com>
7272
7273         * contrib/cleanup_check.py: Remove.
7274         * contrib/gcc-with-excheck: Remove.
7275         * contrib/exsummary.py: Remove.
7276         * contrib/excheck.py: Remove.
7277
7278 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7279
7280         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7281         NULL. Initialize tpprev to NULL instead of assigning it
7282         to NULL on the next statement.
7283         * windows-nat.c (windows_delete_thread): Remove check for
7284         main_thread_id before printing thread exit notifications.
7285         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7286         Remove thread ID check against main_thread_id.
7287         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7288         windows_delete_thread.
7289         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7290
7291 2019-01-04  Tom Tromey  <tom@tromey.com>
7292
7293         * compile/compile.c (_initialize_compile): Use upper case for
7294         metasyntactic variables.
7295         * symmisc.c (_initialize_symmisc): Use upper case for
7296         metasyntactic variables.
7297         * psymtab.c (_initialize_psymtab): Use upper case for
7298         metasyntactic variables.
7299         * demangle.c (demangle_command): Use upper case for metasyntactic
7300         variables.
7301         (_initialize_demangler): Likewise.
7302         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7303         variables.
7304
7305 2019-01-03  Tom Tromey  <tom@tromey.com>
7306
7307         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7308
7309 2019-01-03  Tom Tromey  <tom@tromey.com>
7310
7311         * python/py-symtab.c (salpy_str): Update.
7312         (struct salpy_sal_object) <symtab>: Now a PyObject.
7313         (salpy_dealloc): Update.
7314         (del_objfile_sal): Use gdbpy_ref.
7315
7316 2019-01-03  Tom Tromey  <tom@tromey.com>
7317
7318         * python/py-type.c (convert_field): Use new_reference.  Return
7319         gdbpy_ref.
7320         (make_fielditem): Return gdbpy_ref.
7321         (typy_fields): Update.
7322         (typy_getitem): Update.
7323         (field_name): Return gdbpy_ref.  Use new_reference.
7324         (typy_iterator_iternext): Update.
7325
7326 2019-01-03  Tom Tromey  <tom@tromey.com>
7327
7328         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7329
7330 2019-01-03  Tom Tromey  <tom@tromey.com>
7331
7332         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7333         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7334         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7335         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7336         (pspy_set_type_printers): Likewise.
7337         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7338         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7339         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7340         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7341         (objfpy_set_type_printers): Likewise.
7342
7343 2019-01-03  Tom Tromey  <tom@tromey.com>
7344
7345         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7346         (gdbpy_print_stack): Use gdbpy_err_fetch.
7347         * python/python-internal.h (class gdbpy_err_fetch): New class.
7348         (class gdbpy_enter) <m_error_type, m_error_value,
7349         m_error_traceback>: Remove.
7350         <m_error>: New member.
7351         (gdbpy_exception_to_string): Don't declare.
7352         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7353         * python/py-value.c (convert_value_from_python): Use
7354         gdbpy_err_fetch.
7355         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7356         gdbpy_exception_to_string.
7357         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7358         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7359         gdbpy_err_fetch.
7360
7361 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7362
7363         * linux-nat.c (delete_lwp_cleanup): Delete.
7364         (struct lwp_deleter): New struct.
7365         (lwp_info_up): New typedef.
7366         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7367         lwp_info_up.
7368
7369 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * linux-fork.c (class scoped_switch_fork_info): New class.
7372         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7373
7374 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7375
7376         * valops.c (find_overload_match): Remove use of null_cleanup, and
7377         calls to do_cleanups.
7378
7379 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7380
7381         * compile/compile-cplus-types.c
7382         (compile_cplus_instance::decl_name): Handle changes to
7383         cp_func_name.
7384         * cp-support.c (cp_func_name): Update header comment, update
7385         return type.
7386         * cp-support.h (cp_func_name): Update return type in declaration.
7387         * valops.c (find_overload_match): Move temp_func local to top
7388         level of function and change its type.  Use temp_func to hold and
7389         delete temporary string obtained from cp_func_name.
7390
7391 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7392
7393         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7394         gdb::char_vector, remove cleanup, and update uses of `msg`.
7395
7396 2019-01-03  Jim Wilson  <jimw@sifive.com>
7397
7398         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7399
7400 2019-01-02  Tom Tromey  <tom@tromey.com>
7401
7402         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7403         (tdesc_parse_xml): Remove cleanups.
7404         * target-descriptions.h (make_cleanup_free_target_description):
7405         Don't declare.
7406         (target_desc_deleter): New struct.
7407         (target_desc_up): New typedef.
7408         * target-descriptions.c (target_desc_deleter::operator()): Rename
7409         from free_target_description.
7410         (make_cleanup_free_target_description): Remove.
7411
7412 2019-01-02  Tom Tromey  <tom@tromey.com>
7413
7414         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7415         constructor, destructor.
7416         (linespec_parser): Remove typedef.
7417         (~linespec_parser): Rename from linespec_parser_delete.
7418         (linespec_lex_to_end, linespec_complete_label)
7419         (linespec_complete): Update.
7420         (decode_line_full): Remove cleanups.
7421         (decode_line_1): Update.
7422
7423 2019-01-02  Tom Tromey  <tom@tromey.com>
7424
7425         * python/python-internal.h (inferior_to_inferior_object): Change
7426         return type.
7427         * python/py-exitedevent.c (create_exited_event_object): Update.
7428         * python/py-inferior.c (inferior_to_inferior_object): Return
7429         gdbpy_ref.
7430         (python_new_inferior, python_inferior_deleted)
7431         (thread_to_thread_object, delete_thread_object)
7432         (build_inferior_list, gdbpy_selected_inferior): Update.
7433         * python/py-infthread.c (create_thread_object): Update.  Also fail
7434         if inferior_to_inferior_object fails.
7435
7436 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7437
7438         * inferior.h (class inferior) <displaced_step_state>: New field.
7439         * infrun.h (struct displaced_step_state): Move here from
7440         infrun.c.  Initialize fields, add constructor.
7441         <inf>: Remove field.
7442         <reset>: New method.
7443         * infrun.c (struct displaced_step_inferior_state): Move to
7444         infrun.h.
7445         (displaced_step_inferior_states): Remove.
7446         (get_displaced_stepping_state): Adust.
7447         (displaced_step_in_progress_any_inferior): Adjust.
7448         (displaced_step_in_progress_thread): Adjust.
7449         (displaced_step_in_progress): Adjust.
7450         (add_displaced_stepping_state): Remove.
7451         (get_displaced_step_closure_by_addr): Adjust.
7452         (remove_displaced_stepping_state): Remove.
7453         (infrun_inferior_exit): Call displaced_step_state.reset.
7454         (use_displaced_stepping): Don't check for NULL.
7455         (displaced_step_prepare_throw): Call
7456         get_displaced_stepping_state.
7457         (displaced_step_fixup): Don't check for NULL.
7458         (prepare_for_detach): Don't check for NULL.
7459
7460 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7461
7462         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7463          in case of call that did not complete.
7464
7465 2019-01-02  Andrey Utkin  <autkin@undo.io>
7466
7467         * symfile.c (find_separate_debug_file): Fix search of debug files for
7468         remote debuggee.
7469
7470 2019-01-02  Tom Tromey  <tom@tromey.com>
7471
7472         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7473         indentation.
7474         * python/py-frame.c (frapy_older): Remove cast.
7475         (frapy_newer): Likewise.
7476         * python/py-breakpoint.c (local_setattro): Remove cast.
7477         * python/py-arch.c (archpy_name): Remove local variable.
7478         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7479
7480 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7481
7482         * unittests/basic_string_view/element_access/char/empty.cc:
7483         Fix year range in copyright header.
7484
7485 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7486
7487         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7488         Delete.
7489         <operator==>: Update with for removed field.
7490         <hash>: Likewise.
7491         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7492         <isa_features>: ...this.
7493         <abi_features>: New field.
7494         (riscv_isa_flen): Update comment.
7495         (riscv_abi_xlen): New declaration.
7496         (riscv_abi_flen): New declaration.
7497         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7498         isa_features.
7499         (riscv_abi_xlen): New function.
7500         (riscv_isa_flen): Update to get answer from isa_features.
7501         (riscv_abi_flen): New function.
7502         (riscv_has_fp_abi): Update to get answer from abi_features.
7503         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7504         xlen and flen.
7505         (riscv_call_info) <xlen, flen>: Update comment.
7506         (riscv_call_arg_struct): Remove invalid assertions
7507         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7508         is removed.
7509         (riscv_gdbarch_init): Gather isa features and abi features
7510         separately, ensure both match on the gdbarch when reusing an old
7511         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7512         a target with 64-bit float hardware.
7513
7514 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7515
7516         * source.c (search_command_helper): Stop reverse search
7517         when line 1 has been searched.
7518
7519 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7520
7521         * record-full.c (record_full_base_target::close): Rewrite
7522         record_full_core_buf_list free logic.
7523
7524 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7525
7526         * break-catch-syscall.c (print_one_catch_syscall): xfree
7527         the last text.
7528
7529 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7530
7531         * top.c (print_gdb_version): Update Copyright year in version
7532         message.
7533
7534 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7535
7536         Update copyright year range in all GDB files.
7537
7538 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7539
7540         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7541
7542 For older changes see ChangeLog-2018.
7543 \f
7544 Local Variables:
7545 mode: change-log
7546 left-margin: 8
7547 fill-column: 74
7548 version-control: never
7549 coding: utf-8
7550 End:
7551