gdb/ChangeLog

   1 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
   2
   3         * windows-nat.c (display_selector): Fixed format specifications
   4         for 64-bit Cygwin.
   5
   6 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
   9
  10 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  11
  12         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  13         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  14         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  15         (nios2_linux_init_abi): Install it.
  16
  17 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  18
  19         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  20
  21 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  24
  25 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  26             Tom Tromey  <tromey@adacore.com>
  27
  28         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  29
  30 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  31
  32         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  33         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  34         method to compute the bounds of range types. Also print "[evaluated]"
  35         if the bounds' values come from a dynamic evaluation.
  36
  37 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  40         whitespace when pretty printing is on.
  41
  42 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  43
  44         * ppc-linux-nat.c: Add include.
  45
  46 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * NEWS: Mention AArch64 Pointer Authentication.
  49
  50 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * arm-linux-nat.c: Add include.
  53
  54 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  55
  56         * source-cache.c (source_cache::get_source_lines): Re-read
  57         fullname after calling open_source_file.
  58
  59 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  60
  61         * NEWS: Mention TLS support for FreeBSD.
  62
  63 2019-03-25  Tom Tromey  <tromey@adacore.com>
  64
  65         * minsyms.c (BUNCH_SIZE): Update comment.
  66         (~minimal_symbol_reader): Remove old comment.
  67         (compact_minimal_symbols): Update comment.
  68         (minimal_symbol_reader::install): Remove old comment.  Update
  69         other comments.
  70
  71 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  72
  73         * s390-linux-nat.c: Add include.
  74
  75 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  76
  77         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  78         Call linux_get_hwcap.
  79         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  80         Likewise.
  81         (aarch64_linux_get_hwcap): Remove function.
  82         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  83         declaration.
  84         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  85         linux_get_hwcap.
  86         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  87         * linux-tdep.c (linux_get_hwcap): Add function.
  88         (linux_get_hwcap2): Likewise.
  89         * linux-tdep.h (linux_get_hwcap): Add declaration.
  90         (linux_get_hwcap2): Likewise.
  91         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  92         (ppc_linux_get_hwcap2): Likewise.
  93         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  94         linux_get_hwcap.
  95         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  96         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  97         (ppc_linux_nat_target::read_description): Likewise.
  98         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  99         * s390-linux-nat.c: Likewise.
 100         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 101
 102 2019-03-24  Tom Tromey  <tom@tromey.com>
 103
 104         * ada-lang.c (standard_lookup): Simplify initialization.
 105         (ada_lookup_symbol_nonlocal): Simplify return.
 106         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 107         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 108         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 109         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 110         initialization.
 111         * solib.c (solib_global_lookup): Simplify.
 112         * symtab.c (null_block_symbol): Remove.
 113         (symbol_cache_lookup): Simplify returns.
 114         (lookup_language_this): Simplify returns.
 115         (lookup_symbol_aux): Simplify return.
 116         (lookup_local_symbol): Simplify returns.
 117         (lookup_global_symbol_from_objfile): Simplify return.
 118         (lookup_symbol_in_objfile_symtabs)
 119         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 120         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 121         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 122         * cp-namespace.c (cp_lookup_bare_symbol)
 123         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 124         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 125         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 126         (cp_lookup_symbol_via_imports): Simplify initialization.
 127         (find_symbol_in_baseclass): Likewise.
 128         * symtab.h (null_block_symbol): Remove.
 129         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 130         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 131         (d_lookup_symbol_module): Likewise.
 132         (find_symbol_in_baseclass): Simplify initialization.
 133
 134 2019-03-24  Tom Tromey  <tom@tromey.com>
 135
 136         * expression.h: Don't include symtab.h.
 137         (struct block): Forward declare.
 138
 139 2019-03-24  Tom Tromey  <tom@tromey.com>
 140
 141         * c-exp.y (typebase): Remove casts.
 142         * gdbtypes.c (lookup_unsigned_typename, )
 143         (lookup_signed_typename): Remove cast.
 144         * eval.c (parse_to_comma_and_eval): Remove cast.
 145         * parse.c (write_dollar_variable): Remove cast.
 146         * block.h (struct block) <superblock>: Now const.
 147         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 148         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 149         (map_block): Make "block" const.
 150         * symfile.h (struct quick_symbol_functions)
 151         <map_matching_symbols>: Constify block argument to "callback".
 152         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 153         const.
 154         (find_pc_sect_compunit_symtab): Make "b" const.
 155         (find_symbol_at_address): Likewise.
 156         (search_symbols): Likewise.
 157         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 158         (dw2_debug_names_lookup_symbol): Likewise.
 159         (dw2_map_matching_symbols): Update.
 160         * p-valprint.c (pascal_val_print): Remove "block".
 161         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 162         (aux_add_nonlocal_symbols): Make "block" const.
 163         (resolve_subexp): Remove cast.
 164         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 165         const.
 166         (iterate_over_file_blocks): Likewise.
 167         * f-exp.y (%union) <bval>: Remove.
 168         * coffread.c (patch_opaque_types): Make "b" const.
 169         * spu-tdep.c (spu_catch_start): Make "block" const.
 170         * c-valprint.c (print_unpacked_pointer): Remove "block".
 171         * symmisc.c (dump_symtab_1): Make "b" const.
 172         (block_depth): Make "block" const.
 173         * d-exp.y (%union) <bval>: Remove.
 174         * cp-support.h (cp_lookup_rtti_type): Update.
 175         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 176         * psymtab.c (psym_lookup_symbol): Make "block" const.
 177         (maintenance_check_psymtabs): Make "b" const.
 178         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 179         (enumerate_locals, enumerate_args): Update.
 180         * python/py-symtab.c (stpy_global_block): Make "block" const.
 181         (stpy_static_block): Likewise.
 182         * inline-frame.c (block_starting_point_at): Make "new_block"
 183         const.
 184         * block.c (find_block_in_blockvector): Make return type const.
 185         (blockvector_for_pc_sect): Make "b" const.
 186         (find_block_in_blockvector): Make "b" const.
 187
 188 2019-03-23  Tom Tromey  <tom@tromey.com>
 189
 190         * varobj.c (varobj_create): Update.
 191         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 192         * printcmd.c (display_command, do_one_display): Don't reset
 193         innermost_block.
 194         * parser-defs.h (enum innermost_block_tracker_type): Move to
 195         expression.h.
 196         (innermost_block): Update comment.
 197         * parse.c (parse_exp_1): Add tracker_types parameter.
 198         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 199         tracker_types parameter.  Reset innermost_block.
 200         (parse_exp_in_context): Remove.
 201         (parse_expression_for_completion): Update.
 202         * objfiles.c (~objfile): Don't reset expression_context_block or
 203         innermost_block.
 204         * expression.h (enum innermost_block_tracker_type): Move from
 205         parser-defs.h.
 206         (parse_exp_1): Add tracker_types parameter.
 207         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 208         reset innermost_block.
 209
 210 2019-03-23  Tom Tromey  <tom@tromey.com>
 211
 212         * objfiles.h: Include bcache.h.
 213
 214 2019-03-23  Tom Tromey  <tom@tromey.com>
 215
 216         * linespec.c (get_current_search_block): Use
 217         scoped_restore_current_language.
 218         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 219
 220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 221             Jiong Wang  <jiong.wang@arm.com>
 222
 223         * aarch64-linux-tdep.c
 224         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 225         section.
 226         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 227
 228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 229             Jiong Wang  <jiong.wang@arm.com>
 230
 231         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 232         instructions.
 233         (aarch64_analyze_prologue_test): Add PACIASP test.
 234         (aarch64_prologue_prev_register): Unmask PC value.
 235
 236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 237             Jiong Wang  <jiong.wang@arm.com>
 238
 239         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 240         (aarch64_dwarf2_prev_register): Unmask PC value.
 241         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 242         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 243         DW_CFA_AARCH64_negate_ra_state.
 244         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 245
 246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 247             Jiong Wang  <jiong.wang@arm.com>
 248
 249         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 250         registers.
 251         (aarch64_pseudo_register_name): Likewise.
 252         (aarch64_pseudo_register_type): Likewise.
 253         (aarch64_pseudo_register_reggroup_p): Likewise.
 254         (aarch64_gdbarch_init): Add pauth registers.
 255         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 256         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 257         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 258         (struct gdbarch_tdep): Add regnum for ra_state.
 259
 260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 261             Jiong Wang  <jiong.wang@arm.com>
 262
 263         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 264
 265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 266             Jiong Wang  <jiong.wang@arm.com>
 267
 268         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 269         function.
 270         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 271         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 272         (aarch64_gdbarch_init): Add puth registers.
 273         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 274         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 275         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 276
 277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 278             Jiong Wang  <jiong.wang@arm.com>
 279
 280         * aarch64-linux-nat.c
 281         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 282         * aarch64-linux-tdep.c
 283         (aarch64_linux_core_read_description): Likewise.
 284         (aarch64_linux_get_hwcap): New function.
 285         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 286         (aarch64_linux_get_hwcap): New declaration.
 287
 288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 289             Jiong Wang  <jiong.wang@arm.com>
 290
 291         * aarch64-linux-nat.c
 292         (aarch64_linux_nat_target::read_description): Add pauth param.
 293         * aarch64-linux-tdep.c
 294         (aarch64_linux_core_read_description): Likewise.
 295         * aarch64-tdep.c (struct target_desc): Add in pauth.
 296         (aarch64_read_description): Add pauth param.
 297         (aarch64_gdbarch_init): Likewise.
 298         * aarch64-tdep.h (aarch64_read_description): Likewise.
 299         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 300         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 301         * features/Makefile: Add new files.
 302         * features/aarch64-pauth.c: New file.
 303         * features/aarch64-pauth.xml: New file.
 304
 305 2019-03-20  Tom Tromey  <tromey@adacore.com>
 306
 307         * infrun.c (handle_inferior_event): Rename from
 308         handle_inferior_event_1.  Create a scoped_value_mark.
 309         (handle_inferior_event): Remove.
 310
 311 2019-03-19  Tom Tromey  <tromey@adacore.com>
 312
 313         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 314         * infrun.h (print_stop_event): Add "displays" parameter.
 315         * infrun.c (print_stop_event): Add "displays" parameter.
 316
 317 2019-03-19  Pedro Alves  <palves@redhat.com>
 318
 319         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 320         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 321         to -1.  Fix TABs vs spaces.
 322         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 323         * tui/tui-out.h (tui_ui_out) Add intro comments.
 324         <m_line, m_start_of_line>: In-class initialize, and add describing
 325         comment.
 326
 327 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 328
 329         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 330         variable names.
 331         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 332
 333 2019-03-18  Pedro Alves  <palves@redhat.com>
 334             Eli Zaretskii <eliz@gnu.org>
 335
 336         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 337         m_line and m_start_of_line.
 338
 339 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 340
 341         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 342         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 343         it returns a newline.  This fixes a regression in TU mode, whereby
 344         the next line is output on the same screen line as the user input.
 345
 346 2019-03-18  Tom Tromey  <tromey@adacore.com>
 347
 348         * minsyms.c (minimal_symbol_reader::install): Remove call to
 349         obstack_blank.
 350
 351 2019-03-18  Pedro Alves  <palves@redhat.com>
 352
 353         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 354         New globals.
 355         (apply_style): New, factored out from ...
 356         (apply_ansi_escape): ... this.  Handle reverse video mode.
 357         (tui_set_reverse_mode): New function.
 358         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 359         * tui/tui-winsource.c (tui_show_source_line): Use
 360         tui_set_reverse_mode instead of setting A_STANDOUT.
 361         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 362         New setter methods.
 363
 364 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 365
 366         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 367         Handle tabs.
 368
 369 2019-03-18  Tom Tromey  <tromey@adacore.com>
 370
 371         * ada-lang.c (empty_array): Add "high" parameter.
 372         (ada_evaluate_subexp): Update.
 373
 374 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 375
 376         * unittests/string_view-selftests.c: Define
 377         _initialize_string_view_selftests unconditionally.
 378
 379 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 380
 381         PR gdb/24350
 382         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 383
 384 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 385
 386         PR gdb/24351
 387         * windows-nat.c (display_selector): Fix format specifiers.
 388
 389 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 390
 391         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 392         tui_refill_source_window instead of tui_refresh_win, to update the
 393         current execution line.  This fixes redisplay of the current line
 394         when stepping through the code with "next" or "step".
 395
 396 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 397
 398         * source-cache.c (source_cache::get_source_lines): Call
 399         find_source_lines to initialize s->nlines.  This fixes vertical
 400         scrolling of TUI source window when the DOWN arrow is pressed.
 401
 402 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 403
 404         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 405         linux-thread-db.c (_initialize_thread_db): Likewise.
 406
 407 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 408
 409         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 410         wclrtoeol in tui_show_source_line".  This reverts changes made in
 411         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 412
 413 2019-03-15  Tom Tromey  <tom@tromey.com>
 414
 415         * symtab.h (struct minimal_symbol): Derive from
 416         general_symbol_info.
 417         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 418         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 419         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 420         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 421         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 422         (MSYMBOL_SEARCH_NAME): Update.
 423         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 424         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 425         * minsyms.c (minimal_symbol_reader::record_full): Update.
 426
 427 2019-03-15  Tom Tromey  <tom@tromey.com>
 428
 429         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 430
 431 2019-03-15  Tom Tromey  <tom@tromey.com>
 432
 433         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 434         unique_xmalloc_ptr.
 435         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 436         Update.
 437         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 438         (build_minimal_symbol_hash_tables)
 439         (minimal_symbol_reader::install): Update.
 440
 441 2019-03-15  Tom Tromey  <tom@tromey.com>
 442
 443         * symtab.c (create_demangled_names_hash): Update.
 444         (symbol_set_names): Update.
 445         * objfiles.h (struct objfile_per_bfd_storage)
 446         <demangled_names_hash>: Now an htab_up.
 447         * objfiles.c (objfile_per_bfd_storage): Simplify.
 448
 449 2019-03-15  Tom Tromey  <tom@tromey.com>
 450
 451         * objfiles.h (struct objfile_per_bfd_storage): Declare
 452         destructor.
 453         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 454         New.
 455         (get_objfile_bfd_data): Use new.  Don't initialize
 456         language_of_main.
 457         (free_objfile_per_bfd_storage): Remove.
 458         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 459
 460 2019-03-15  Tom Tromey  <tom@tromey.com>
 461
 462         * symfile.c (reread_symbols): Update.
 463         * objfiles.c (objfile::objfile): Update.
 464         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 465         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 466         comment.
 467         (minimal_symbol_reader::install): Update.
 468         (terminate_minimal_symbol_table): Remove.
 469         * jit.c (jit_object_close_impl): Update.
 470
 471 2019-03-15  Tom Tromey  <tom@tromey.com>
 472
 473         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 474         initializations.
 475
 476 2019-03-15  Tom Tromey  <tom@tromey.com>
 477
 478         * objfiles.h (struct objfile_per_bfd_storage)
 479         <demangled_hash_languages>: Now a bitset.
 480         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 481         (lookup_minimal_symbol): Update.
 482
 483 2019-03-15  Tom Tromey  <tom@tromey.com>
 484
 485         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 486         Don't return the symbol.
 487         * coffread.c (record_minimal_symbol): Use record_full.
 488
 489 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 490
 491         The MS-Windows port of ncurses fails to switch to a color pair if
 492         one or both of the colors are the implicit default colors.  This
 493         change records the default colors when TUI is initialized, and
 494         then specifies them explicitly when a color pair uses the default
 495         colors.  This allows color styling in TUI mode on MS-Windows.
 496
 497         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 498         ncurses_norm_attr.
 499         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 500         colors in ncurses_norm_attr.
 501         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 502         "none", replace it with the default color recorded in
 503         ncurses_norm_attr.
 504
 505 2019-03-14  Tom Tromey  <tromey@adacore.com>
 506
 507         * source-cache.h (class source_cache) <get_source_lines>: Return
 508         std::string.
 509         * source-cache.c (source_cache::extract_lines): Handle case where
 510         first_pos==npos.  Return std::string.
 511         (source_cache::get_source_lines): Update.
 512
 513 2019-03-14  Tom Tromey  <tromey@adacore.com>
 514
 515         * NEWS: Add item for "style sources" commands.
 516         * source-cache.c (source_cache::get_source_lines): Check
 517         source_styling.
 518         * cli/cli-style.c (source_styling): New global.
 519         (_initialize_cli_style): Add "style sources" commands.
 520         (show_style_sources): New function.
 521         * cli/cli-style.h (source_styling): Declare.
 522
 523 2019-03-14  Pedro Alves  <palves@redhat.com>
 524             Tom Tromey  <tromey@adacore.com>
 525
 526         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 527         * tui/tui-winsource.c (tui_refill_source_window): New function,
 528         from...
 529         (tui_horizontal_source_scroll): ... here.  Move some logic.
 530         * cli/cli-style.c (set_style_enabled): Notify new observable.
 531         * tui/tui-hooks.c (tui_redisplay_source): New function.
 532         (tui_attach_detach_observers): Attach or detach
 533         tui_redisplay_source.
 534         * observable.h (source_styling_changed): New observable.
 535         * observable.c: Define source_styling_changed observable.
 536
 537 2019-03-13  Tom Tromey  <tromey@adacore.com>
 538
 539         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 540         (i386_gnu_nat_target::store_registers): Update.
 541         * target-debug.h (target_debug_print_std_string): New macro.
 542         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 543         * windows-tdep.c (display_one_tib): Update.
 544         * tui/tui-stack.c (tui_make_status_line): Update.
 545         * top.c (print_inferior_quit_action): Update.
 546         * thread.c (thr_try_catch_cmd): Update.
 547         (add_thread_with_info): Update.
 548         (thread_target_id_str): Update.
 549         (thr_try_catch_cmd): Update.
 550         (thread_command): Update.
 551         (thread_find_command): Update.
 552         * record-btrace.c (record_btrace_target::info_record)
 553         (record_btrace_resume_thread, record_btrace_target::resume)
 554         (record_btrace_cancel_resume, record_btrace_step_thread)
 555         (record_btrace_target::wait, record_btrace_target::wait)
 556         (record_btrace_target::wait, record_btrace_target::stop): Update.
 557         * progspace.c (print_program_space): Update.
 558         * process-stratum-target.c
 559         (process_stratum_target::thread_address_space): Update.
 560         * linux-fork.c (linux_fork_mourn_inferior)
 561         (detach_checkpoint_command, info_checkpoints_command)
 562         (linux_fork_context): Update.
 563         (linux_fork_detach): Update.
 564         (class scoped_switch_fork_info): Update.
 565         (delete_checkpoint_command): Update.
 566         * infrun.c (follow_fork_inferior): Update.
 567         (follow_fork_inferior): Update.
 568         (proceed_after_vfork_done): Update.
 569         (handle_vfork_child_exec_or_exit): Update.
 570         (follow_exec): Update.
 571         (displaced_step_prepare_throw): Update.
 572         (displaced_step_restore): Update.
 573         (start_step_over): Update.
 574         (resume_1): Update.
 575         (clear_proceed_status_thread): Update.
 576         (proceed): Update.
 577         (print_target_wait_results): Update.
 578         (do_target_wait): Update.
 579         (context_switch): Update.
 580         (stop_all_threads): Update.
 581         (restart_threads): Update.
 582         (finish_step_over): Update.
 583         (handle_signal_stop): Update.
 584         (switch_back_to_stepped_thread): Update.
 585         (keep_going_pass_signal): Update.
 586         (print_exited_reason): Update.
 587         (normal_stop): Update.
 588         * inferior.c (inferior_pid_to_str): Change return type.
 589         (print_selected_inferior): Update.
 590         (add_inferior): Update.
 591         (detach_inferior): Update.
 592         * dummy-frame.c (fprint_dummy_frames): Update.
 593         * dcache.c (dcache_info_1): Update.
 594         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 595         (btrace_fetch, btrace_clear): Update.
 596         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 597         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 598         type.
 599         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 600         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 601         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 602         * gdbarch.c, gdbarch.h: Rebuild.
 603         * gdbarch.sh (core_pid_to_str): Change return type.
 604         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 605         return type.
 606         (windows_nat_target::pid_to_str): Change return type.
 607         (windows_delete_thread): Update.
 608         (windows_nat_target::attach): Update.
 609         (windows_nat_target::files_info): Update.
 610         * target-delegates.c: Rebuild.
 611         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 612         return type.
 613         (sol_thread_target::pid_to_str): Change return type.
 614         * remote.c (class remote_target) <pid_to_str>: Change return
 615         type.
 616         (remote_target::pid_to_str): Change return type.
 617         (extended_remote_target::attach, remote_target::remote_stop_ns)
 618         (remote_target::remote_notif_remove_queued_reply)
 619         (remote_target::push_stop_reply, remote_target::disable_btrace):
 620         Update.
 621         (extended_remote_target::attach): Update.
 622         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 623         type.
 624         (gdbsim_target::pid_to_str): Change return type.
 625         * ravenscar-thread.c (struct ravenscar_thread_target)
 626         <pid_to_str>: Change return type.
 627         (ravenscar_thread_target::pid_to_str): Change return type.
 628         * procfs.c (class procfs_target) <pid_to_str>: Change return
 629         type.
 630         (procfs_target::pid_to_str): Change return type.
 631         (procfs_target::attach): Update.
 632         (procfs_target::detach): Update.
 633         (procfs_target::fetch_registers): Update.
 634         (procfs_target::store_registers): Update.
 635         (procfs_target::wait): Update.
 636         (procfs_target::files_info): Update.
 637         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 638         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 639         return type.
 640         (nto_procfs_target::pid_to_str): Change return type.
 641         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 642         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 643         return type.
 644         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 645         (exit_lwp): Update.
 646         (attach_proc_task_lwp_callback, get_detach_signal)
 647         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 648         (linux_nat_target::resume, wait_lwp, stop_callback)
 649         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 650         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 651         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 652         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 653         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 654         type.
 655         (inf_ptrace_target::attach): Update.
 656         (inf_ptrace_target::files_info): Update.
 657         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 658         type.
 659         (go32_nat_target::pid_to_str): Change return type.
 660         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 661         (gnu_nat_target::wait): Update.
 662         (gnu_nat_target::wait): Update.
 663         (gnu_nat_target::resume): Update.
 664         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 665         (fbsd_nat_target::wait): Update.
 666         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 667         type.
 668         (darwin_nat_target::attach): Update.
 669         * corelow.c (class core_target) <pid_to_str>: Change return type.
 670         (core_target::pid_to_str): Change return type.
 671         * target.c (normal_pid_to_str): Change return type.
 672         (default_pid_to_str): Likewise.
 673         (target_pid_to_str): Change return type.
 674         (target_translate_tls_address): Update.
 675         (target_announce_detach): Update.
 676         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 677         return type.
 678         (bsd_uthread_target::pid_to_str): Change return type.
 679         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 680         type.
 681         (bsd_kvm_target::pid_to_str): Change return type.
 682         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 683         return type.
 684         (aix_thread_target::pid_to_str): Change return type.
 685         * target.h (struct target_ops) <pid_to_str>: Change return type.
 686         (target_pid_to_str, normal_pid_to_str): Likewise.
 687         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 688         type.
 689         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 690         type.
 691         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 692         return type.
 693         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 694         type.
 695         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 696         type.
 697         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 698         return type.
 699
 700 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 701
 702         * NEWS: Mention that the new default MI version is 3.  Mention
 703         changes to the output of commands and events that deal with
 704         multi-location breakpoints.
 705         * breakpoint.c: Include "mi/mi-out.h".
 706         (print_one_breakpoint): Change output syntax if using MI version
 707         >= 3.
 708         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 709         New.
 710         (mi_multi_location_breakpoint_output_fixed): New.
 711         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 712         (mi_cmd_fix_multi_location_breakpoint_output): New.
 713         (mi_multi_location_breakpoint_output_fixed): New.
 714         * mi/mi-cmds.c (mi_cmds): Register command
 715         -fix-multi-location-breakpoint-output.
 716         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 717         interpreter "mi".
 718
 719 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 720
 721         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 722         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 723         instantiate mi_ui_out based on interpreter name.
 724         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 725         * mi/mi-main.c (mi_load_progress): Likewise.
 726
 727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 728
 729         * NEWS: Combine separate "New targets" sections for 8.3.
 730
 731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 732
 733         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 734         (ppcfbsd_init_abi): Install gdbarch
 735         "fetch_tls_load_module_address" and "get_thread_local_address"
 736         methods.
 737
 738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 739
 740         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 741         (riscv_fbsd_init_abi): Install gdbarch
 742         "fetch_tls_load_module_address" and "get_thread_local_address"
 743         methods.
 744
 745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 746
 747         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 748         (i386fbsd_init_abi): Install gdbarch
 749         "fetch_tls_load_module_address" and "get_thread_local_address"
 750         methods.
 751
 752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 753
 754         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 755         (amd64fbsd_init_abi): Install gdbarch
 756         "fetch_tls_load_module_address" and "get_thread_local_address"
 757         methods.
 758
 759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 760
 761         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 762         (struct fbsd_pspace_data): New type.
 763         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 764         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 765         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 766         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 767         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 768
 769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 770
 771         * gdbtypes.c (lookup_struct_elt): New function.
 772         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 773         * gdbtypes.h (struct struct_elt): New type.
 774         (lookup_struct_elt): New prototype.
 775
 776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 777
 778         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 779         remove disabled code block.
 780
 781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 782
 783         * gdbarch.sh (get_thread_local_address): New method.
 784         * gdbarch.h, gdbarch.c: Regenerate.
 785         * target.c (target_translate_tls_address): Use
 786         gdbarch_get_thread_local_address if present instead of
 787         target::get_thread_local_address.
 788
 789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 790
 791         * target.h (target::get_thread_local_address): Update comment.
 792
 793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 794
 795         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 796         objfile->separate_debug_objfile_backlink if not NULL.
 797
 798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 799
 800         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 801         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 802         (amd64bsd_store_inferior_registers): Likewise.
 803         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 804         Enable segment base registers.
 805         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 806         PT_GETFSBASE and PT_GETGSBASE.
 807         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 808         PT_SETGSBASE.
 809         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 810         segment base registers.
 811         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 812
 813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 814
 815         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 816         Update calls to i386_target_description to add 'segments'
 817         parameter.
 818         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 819         add segment base registers.
 820         * arch/i386.c (i386_create_target_description): Add 'segments'
 821         parameter to enable segment base registers.
 822         * arch/i386.h (i386_create_target_description): Likewise.
 823         * features/i386/32bit-segments.xml: New file.
 824         * features/i386/32bit-segments.c: Generate.
 825         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 826         call to i386_target_description to add 'segments' parameter.
 827         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 828         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 829         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 830         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 831         if feature is present.
 832         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 833         Add 'segments' parameter to call to i386_target_description.
 834         (i386_target_description): Add 'segments' parameter to enable
 835         segment base registers.
 836         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 837         to call to i386_target_description.
 838         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 839         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 840         Define I386_NUM_REGS.
 841         (i386_target_description): Add 'segments' parameter to enable
 842         segment base registers.
 843
 844 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 845
 846         PR/24325
 847         * source-cache.c: #undef open and close, to avoid unresolved
 848         externals during linking.
 849
 850 2019-03-12  Tom Tromey  <tromey@adacore.com>
 851
 852         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 853         const.  Add initializers.
 854         (_initialize_remote): Don't initialize ptid globals.
 855
 856 2019-03-12  Pedro Alves  <palves@redhat.com>
 857
 858         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 859
 860 2019-03-12  Pedro Alves  <palves@redhat.com>
 861
 862         * cp-name-parser.y (main): Remove unused 'len' variable.
 863
 864 2019-03-12  Tom Tromey  <tromey@adacore.com>
 865
 866         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 867         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 868
 869 2019-03-12  Tom Tromey  <tromey@adacore.com>
 870
 871         * linux-nat.c (iterate_over_lwps): Update.
 872         (stop_callback): Remove parameter.
 873         (stop_wait_callback, detach_callback, resume_set_callback)
 874         (select_singlestep_lwp_callback, set_ignore_sigint)
 875         (status_callback, resumed_callback, resume_clear_callback)
 876         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 877         data parameter.
 878         (linux_nat_target::detach, linux_nat_target::resume)
 879         (linux_stop_and_wait_all_lwps, select_event_lwp)
 880         (linux_nat_filter_event, linux_nat_wait_1)
 881         (linux_nat_target::kill, linux_nat_target::stop)
 882         (linux_nat_target::stop): Update.
 883         (linux_nat_resume_callback): Change type.
 884         (resume_stopped_resumed_lwps, count_events_callback)
 885         (select_event_lwp_callback): Likewise.
 886         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 887         * arm-linux-nat.c (struct update_registers_data): Remove.
 888         (update_registers_callback): Change type.
 889         (arm_linux_insert_hw_breakpoint1): Update.
 890         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 891         parameter.
 892         (x86_linux_dr_set_addr): Update.
 893         (x86_linux_dr_set_control): Update.
 894         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 895         (iterate_over_lwps): Use gdb::function_view.
 896         * nat/aarch64-linux-hw-point.c (struct
 897         aarch64_dr_update_callback_param): Remove.
 898         (debug_reg_change_callback): Change type.
 899         (aarch64_notify_debug_reg_change): Update.
 900         * s390-linux-nat.c (s390_refresh_per_info): Update.
 901
 902 2019-03-11  Tom Tromey  <tromey@adacore.com>
 903
 904         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 905         redundant assignment to "this_cu".
 906
 907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 908
 909         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 910
 911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 912
 913         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 914         from...
 915         (rank_one_type): ... this.
 916
 917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 918
 919         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 920         from...
 921         (rank_one_type): ... this.
 922
 923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 924
 925         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 926         from...
 927         (rank_one_type): ... this.
 928
 929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 932         from...
 933         (rank_one_type): ... this.
 934
 935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 936
 937         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 938         from...
 939         (rank_one_type): ... this.
 940
 941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 942
 943         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 944         from...
 945         (rank_one_type): ... this.
 946
 947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 948
 949         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 950         from...
 951         (rank_one_type): ... this.
 952
 953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 954
 955         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 956         from...
 957         (rank_one_type): ... this.
 958
 959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 960
 961         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 962         from...
 963         (rank_one_type): ... this.
 964
 965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 966
 967         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 968         from...
 969         (rank_one_type): ... this.
 970
 971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 972
 973         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 974         from...
 975         (rank_one_type): ... this.
 976
 977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 978
 979         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 980         from...
 981         (rank_one_type): ... this.
 982
 983 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 984
 985         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 986         inferior-events' shows the example events.
 987
 988 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 989
 990         Support styling on native MS-Windows console
 991
 992         PR/24315
 993         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 994         on MS-Windows if $TERM is not defined.
 995
 996         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 997
 998         * posix-hdep.c (gdb_console_fputs):
 999         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1000         functions.
1001         * ui-file.h (gdb_console_fputs): Add prototype.
1002
1003         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1004         back to fputs only if the former returns zero.
1005
1006 2019-03-07  Tom Tromey  <tom@tromey.com>
1007
1008         * symmisc.c (print_symbol_bcache_statistics): Update.
1009         (print_objfile_statistics): Update.
1010         * symfile.c (allocate_symtab): Update.
1011         * stabsread.c: Don't include bcache.h.
1012         * psymtab.h (struct psymbol_bcache): Don't declare.
1013         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1014         (psymbol_bcache_init, psymbol_bcache_free)
1015         (psymbol_bcache_get_bcache): Don't declare.
1016         * psymtab.c (struct psymbol_bcache): Remove.
1017         (psymtab_storage::psymtab_storage): Update.
1018         (psymtab_storage::~psymtab_storage): Update.
1019         (psymbol_bcache_init, psymbol_bcache_free)
1020         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1021         (add_psymbol_to_bcache): Update.
1022         (allocate_psymtab): Update.
1023         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1024         macro_cache>: No longer pointers.
1025         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1026         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1027         * macrotab.c (macro_bcache): Update.
1028         * macroexp.c: Don't include bcache.h.
1029         * gdbtypes.c (check_types_worklist): Update.
1030         (types_deeply_equal): Remove TRY/CATCH.  Update.
1031         * elfread.c (elf_symtab_read): Update.
1032         * dwarf2read.c: Don't include bcache.h.
1033         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1034         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1035         (print_bcache_statistics, bcache_memory_used): Don't declare.
1036         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1037         methods.  Rename all data members.
1038         * bcache.c (struct bcache): Move to bcache.h.
1039         (bcache::expand_hash_table): Rename from expand_hash_table.
1040         (bcache): Remove.
1041         (bcache::insert): Rename from bcache_full.
1042         (bcache::compare): Rename from bcache_compare.
1043         (bcache_xmalloc): Remove.
1044         (bcache::~bcache): Rename from bcache_xfree.
1045         (bcache::print_statistics): Rename from print_bcache_statistics.
1046         (bcache::memory_used): Rename from bcache_memory_used.
1047
1048 2019-03-07  Pedro Alves  <palves@redhat.com>
1049
1050         * infrun.c (normal_stop): Also check for
1051         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1052
1053 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1054
1055         * f-lang.c (value_from_host_double): Moved to...
1056         * value.c (value_from_host_double): ...here.
1057         * value.h (value_from_host_double): Declare.
1058         * guile/scm-math.c (vlscm_convert_typed_number): Use
1059         value_from_host_double.
1060         (vlscm_convert_number): Likewise.
1061         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1062         * python/py-value.c (convert_value_from_python): Likewise.
1063
1064 2019-03-06  Tom Tromey  <tom@tromey.com>
1065
1066         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1067
1068 2019-03-06  Tom Tromey  <tom@tromey.com>
1069
1070         * utils.h (free_current_contents): Don't declare.
1071         * utils.c (free_current_contents): Remove.
1072
1073 2019-03-06  Tom Tromey  <tom@tromey.com>
1074
1075         * top.c (quit_force): Update.
1076         * main.c (captured_command_loop): Update.
1077         * common/new-op.c (operator new): Update.
1078         * common/common-exceptions.c (struct catcher)
1079         <save_cleanup_chain>: Remove member.
1080         (exceptions_state_mc_init): Update.
1081         (exception_try_scope_entry): Return nullptr.
1082         (exception_try_scope_exit, exception_rethrow)
1083         (throw_exception_sjlj, throw_exception_cxx): Update.
1084         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1085         (all_cleanups, do_cleanups, discard_cleanups)
1086         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1087         (restore_cleanups, restore_final_cleanups): Don't declare.
1088         (do_final_cleanups): Remove parameter.
1089         * common/cleanups.c (cleanup_chain, make_cleanup)
1090         (make_cleanup_dtor, all_cleanups, do_cleanups)
1091         (discard_my_cleanups, discard_cleanups)
1092         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1093         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1094         (null_cleanup): Remove.
1095         (do_final_cleanups): Remove parameter.
1096
1097 2019-03-06  Tom Tromey  <tom@tromey.com>
1098
1099         * remote.c (remote_target::remote_parse_stop_reply): Use
1100         unique_xmalloc_ptr.
1101
1102 2019-03-06  Tom Tromey  <tom@tromey.com>
1103
1104         * stabsread.c (struct stabs_field_info): Rename from field_info.
1105         <list, fnlist>: Add initializers.
1106         <obstack>: New member.
1107         (read_member_functions, read_struct_fields, read_baseclasses):
1108         Allocate on obstack.  Don't use cleanups.
1109         (read_one_struct_field, read_member_functions, read_struct_fields)
1110         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1111         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1112         (read_struct_type): Update.
1113
1114 2019-03-06  Tom Tromey  <tom@tromey.com>
1115
1116         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1117         * common/filestuff.h (make_cleanup_close): Don't declare.
1118         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1119         Remove.
1120
1121 2019-03-06  Tom Tromey  <tom@tromey.com>
1122
1123         * solib-aix.c: Use make_scope_exit.
1124
1125 2019-03-06  Tom Tromey  <tom@tromey.com>
1126
1127         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1128         Use make_scope_exit.
1129
1130 2019-03-06  Tom Tromey  <tom@tromey.com>
1131
1132         * solib-svr4.c (disable_probes_interface): Remove parameter.
1133         (svr4_handle_solib_event): Use make_scope_exit.
1134
1135 2019-03-06  Tom Tromey  <tom@tromey.com>
1136
1137         * remote.c (struct stop_reply_deleter): Remove.
1138         (stop_reply_up): Update.
1139         (struct stop_reply): Derive from notif_event.  Don't typedef.
1140         <regcache>: Now a std::vector.
1141         (stop_reply_xfree): Remove.
1142         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1143         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1144         (remote_target::discard_pending_stop_replies): Use delete.
1145         (remote_target::remote_parse_stop_reply): Update.
1146         (remote_target::process_stop_reply): Update.
1147         * remote-notif.h (struct notif_event): Add virtual destructor.
1148         Remove "dtr" member.
1149         (struct notif_client) <alloc_event>: Return a unique_ptr.
1150         (notif_event_xfree): Don't declare.
1151         (notif_event_up): New typedef.
1152         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1153         (notif_event_xfree, do_notif_event_xfree): Remove.
1154         (remote_notif_state_xfree): Update.
1155
1156 2019-03-06  Tom Tromey  <tom@tromey.com>
1157
1158         * infrun.c (displaced_step_clear_cleanup): Now a
1159         forward_scope_exit type.
1160         (displaced_step_prepare_throw): Update.
1161         (displaced_step_fixup): Update.
1162
1163 2019-03-06  Tom Tromey  <tom@tromey.com>
1164
1165         * inferior.h (class inferior): Update comment.
1166         * gdbthread.h (class thread_info): Update comment.
1167
1168 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1169             Tom Tromey  <tom@tromey.com>
1170
1171         * stabsread.h (struct stab_section_list): Remove.
1172         (coffstab_build_psymtabs): Update.
1173         * dbxread.c (symbuf_sections): Now a std::vector.
1174         (sect_idx): New global.
1175         (fill_symbuf): Update.
1176         (coffstab_build_psymtabs): Change type of stabsects parameter.
1177         Update.
1178         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1179         std::vector.
1180         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1181         (coff_locate_sections): Update.
1182         (coff_symfile_read): Remove cleanups.  Update.
1183         (init_stringtab): Add storage parameter.
1184         (free_stringtab, free_stringtab_cleanup): Remove.
1185         (init_lineno): Add storage parameter.
1186         (free_linetab, free_linetab_cleanup): Remove.
1187
1188 2019-03-06  Pedro Alves  <palves@redhat.com>
1189
1190         * linux-fork.c (fork_info::clobber_regs): Delete.
1191         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1192         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1193         comment.  Adjust.
1194         (scoped_switch_fork_info::scoped_switch_fork_info)
1195         (checkpoint_command, linux_fork_context): Adjust
1196         fork_save_infrun_state calls.
1197
1198 2019-03-06  Pedro Alves  <palves@redhat.com>
1199
1200         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1201         (inf_has_multiple_threads): Return 'bool' and rewrite using
1202         inferior_info::threads().
1203
1204 2019-03-06  Pedro Alves  <palves@redhat.com>
1205
1206         * linux-fork.c: Include <list>.
1207         (fork_list): Now a std::list instance.
1208         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1209         (forks_exist_p, find_last_fork): Adjust.
1210         (new_fork): Delete.
1211         (one_fork_p): New.
1212         (add_fork): Adjust.
1213         (free_fork): Delete, folded into fork_info::~fork_info().
1214         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1215         Adjust.
1216         (init_fork_list): Delete.
1217         (linux_fork_killall, linux_fork_mourn_inferior)
1218         (linux_fork_detach, info_checkpoints_command): Adjust.
1219         (_initialize_linux_fork): No longer call init_fork_list.
1220
1221 2019-03-06  Pedro Alves  <palves@redhat.com>
1222
1223         * linux-fork.c (new_fork): New, split out of ...
1224         (add_fork): ... this.  Return void.  Move "first fork" special
1225         case from here, to ...
1226         (checkpoint_command): ... here.
1227         * linux-linux.h (add_fork): Return void.
1228
1229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1232
1233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1234             Chris January  <chris.january@arm.com>
1235             David Lecomber  <david.lecomber@arm.com>
1236
1237         * f-exp.y: New token, UNOP_INTRINSIC.
1238         (exp): New pattern using UNOP_INTRINSIC token.
1239         (f77_keywords): Add 'abs' keyword.
1240         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1241         (value_from_host_double): New function.
1242         (evaluate_subexp_f): Support UNOP_ABS.
1243
1244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1247         types.
1248
1249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1252         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1253         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1254
1255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1258
1259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1260             Chris January  <chris.january@arm.com>
1261
1262         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1263         * f-exp.y: Define 'KIND' token.
1264         (exp): New pattern for KIND expressions.
1265         (ptype): Handle types with a kind extension.
1266         (direct_abs_decl): Extend to spot kind extensions.
1267         (f77_keywords): Add 'kind' to the list.
1268         (push_kind_type): New function.
1269         (convert_to_kind_type): New function.
1270         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1271         * parse.c (operator_length_standard): Likewise.
1272         * parser-defs.h (enum type_pieces): Add tp_kind.
1273         * std-operator.def: Add UNOP_KIND.
1274
1275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * f-exp.y (f_parse): Set yydebug.
1278
1279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * f-lang.c (evaluate_subexp_f): New function.
1282         (exp_descriptor_f): New global.
1283         (f_language_defn): Use exp_descriptor_f instead of
1284         exp_descriptor_standard.
1285
1286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * f-exp.y (struct token): Add comments.
1289         (dot_ops): Remove uppercase versions and the end marker.
1290         (f77_keywords): Likewise.
1291         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1292         entries in the dot_ops array are case insensitive, and use
1293         strncasecmp to compare strings.  Also some whitespace cleanup in
1294         this area.  Similar for the f77_keywords array, except entries in
1295         this list might be case sensitive.
1296
1297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * f-exp.y (struct f77_boolean_val): Add comments.
1300         (boolean_values): Remove uppercase versions, and end marker.
1301         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1302         and use strncasecmp to achieve case insensitivity.  Additionally,
1303         perform whitespace cleanup around this code.
1304
1305 2019-03-06  Tom Tromey  <tromey@adacore.com>
1306
1307         * remote-sim.c (gdbsim_target_open): Use result of
1308         gdb_argv::release.
1309
1310 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1311         Dirk Schubert  <dirk.schubert@arm.com>
1312         Chris January  <chris.january@arm.com>
1313
1314         * eval.c (evaluate_subexp_standard): Call Fortran argument
1315         wrapping logic.
1316         * f-lang.c (struct value): A value which can be passed into a
1317         Fortran function call.
1318         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1319         where appropriate.
1320         (struct type): Value ready for a Fortran function call.
1321         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1322         is needed.
1323         * f-lang.h (fortran_argument_convert): Declaration.
1324         (fortran_preserve_arg_pointer): Declaration.
1325         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1326
1327 2019-03-05  Tom Tromey  <tromey@adacore.com>
1328
1329         * python/py-prettyprint.c (print_string_repr): Remove #if.
1330         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1331
1332 2019-03-05  Tom Tromey  <tromey@adacore.com>
1333
1334         * target.c (the_dummy_target): Move later.  Change type to
1335         "dummy_target".
1336         (initialize_targets): Don't initialize the_dummy_target.
1337
1338 2019-03-05  Tom Tromey  <tromey@adacore.com>
1339
1340         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1341         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1342
1343 2019-03-05  Tom Tromey  <tromey@adacore.com>
1344
1345         * windows-nat.c (windows_nat_target::attach)
1346         (windows_nat_target::detach): Don't call gdb_flush.
1347         * valprint.c (generic_val_print, val_print, val_print_string):
1348         Don't call gdb_flush.
1349         * utils.c (defaulted_query): Don't call gdb_flush.
1350         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1351         * target.c (target_announce_detach): Don't call gdb_flush.
1352         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1353         * remote.c (extended_remote_target::attach): Don't call
1354         gdb_flush.
1355         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1356         * printcmd.c (do_examine): Don't call gdb_flush.
1357         (info_display_command): Don't call gdb_flush.
1358         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1359         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1360         * memattr.c (info_mem_command): Don't call gdb_flush.
1361         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1362         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1363         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1364         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1365         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1366         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1367         (gnu_nat_target::detach): Don't call gdb_flush.
1368         * f-valprint.c (f_val_print): Don't call gdb_flush.
1369         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1370         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1371         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1372         gdb_flush.
1373         * c-valprint.c (c_val_print): Don't call gdb_flush.
1374         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1375
1376 2019-03-05  Tom Tromey  <tromey@adacore.com>
1377
1378         * varobj.c (update_dynamic_varobj_children): Update.
1379         (install_default_visualizer): Use reset, not release.
1380         * value.c (set_internalvar): Update.
1381         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1382         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1383         ATTRIBUTE_UNUSED_RESULT.
1384
1385 2019-03-05  Tom Tromey  <tromey@adacore.com>
1386
1387         * remote.c (class scoped_remote_fd) <release>: Add
1388         ATTRIBUTE_UNUSED_RESULT.
1389
1390 2019-03-05  Tom Tromey  <tromey@adacore.com>
1391
1392         * macroexp.c (struct macro_buffer) <release>: Add
1393         ATTRIBUTE_UNUSED_RESULT.
1394
1395 2019-03-05  Tom Tromey  <tromey@adacore.com>
1396
1397         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1398         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1399         ATTRIBUTE_UNUSED_RESULT.
1400
1401 2019-03-05  Tom Tromey  <tromey@adacore.com>
1402
1403         * common/scoped_fd.h (class scoped_fd) <release>: Add
1404         ATTRIBUTE_UNUSED_RESULT.
1405
1406 2019-03-05  Tom Tromey  <tromey@adacore.com>
1407
1408         * parser-defs.h (struct parser_state) <release>: Add
1409         ATTRIBUTE_UNUSED_RESULT.
1410
1411 2019-03-05  Tom Tromey  <tromey@adacore.com>
1412
1413         * utils.h (class gdb_argv) <release>: Add
1414         ATTRIBUTE_UNUSED_RESULT.
1415         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1416
1417 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1418
1419         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1420         for-loop range, to avoid compiler warnings.
1421
1422         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1423         avoid compiler warnings about unused variables.
1424
1425         * NEWS: Mention end of support for native debugging on MS-Windows
1426         before XP.
1427
1428         PR gdb/24292
1429         * common/netstuff.c:
1430         * gdbserver/gdbreplay.c
1431         * gdbserver/remote-utils.c:
1432         * ser-tcp.c:
1433         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1434         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1435         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1436         'getaddrinfo' and 'freeaddrinfo' were not available before
1437         Windows XP, and mingw.org's MinGW headers by default define
1438         _WIN32_WINNT to 0x500.
1439
1440 2019-03-01  Gary Benson <gbenson@redhat.com>
1441
1442         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1443
1444 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1445             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1446
1447         PR gdb/8527
1448         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1449         set_sigint_trap, clear_sigint_trap.
1450
1451 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1452
1453         * target.c (target_detach): Clear the regcache and the
1454         frame cache.
1455
1456 2019-02-27  Pedro Alves  <palves@redhat.com>
1457
1458         * utils.c (set_screen_size): When we cap the height/width sizes,
1459         tweak the corresponding command variable to show "unlimited":
1460
1461 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1462             Pedro Alves  <palves@redhat.com>
1463
1464         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1465         before calling rl_set_screen_size.
1466
1467 2019-02-27  Tom Tromey  <tromey@adacore.com>
1468
1469         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1470         define.
1471         * python/py-value.c: Remove Python 2.4 workaround.
1472         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1473         workaround.
1474         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1475         Python 2.4 workaround.
1476         * python/python-internal.h: Remove Python 2.4 comment.
1477         (Py_ssize_t): Don't define.
1478         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1479         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1480         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1481         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1482         * python/python.c (do_start_initialization): Remove Python 2.4
1483         workaround.
1484         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1485         (print_children): Remove Python 2.4 workaround.
1486         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1487         workaround.
1488         (CHARBUFFERPROC_NAME): Remove.
1489         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1490         Python 2.4 workaround.
1491
1492 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1493
1494         * NEWS: Note minimum Python version.
1495
1496 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1497
1498         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1499         code from these functions.  Remove corresponding ifdefs.  Use
1500         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1501         Remove gotos and target of gotos.
1502         (infpy_search_memory): Likewise.
1503
1504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1507         (hppa_gdbarch_init): Don't register deleted functions with
1508         gdbarch.
1509
1510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1513         (h8300_unwind_sp): Delete.
1514         (h8300_dummy_id): Delete.
1515         (h8300_gdbarch_init): Don't register deleted functions with
1516         gdbarch.
1517
1518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1521         (ft32_unwind_pc): Delete.
1522         (ft32_unwind_sp): Delete.
1523         (ft32_gdbarch_init): Don't register deleted functions with
1524         gdbarch.
1525
1526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1529         (frv_unwind_pc): Delete.
1530         (frv_unwind_sp): Delete.
1531         (frv_gdbarch_init): Don't register deleted functions with
1532         gdbarch.
1533
1534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1535
1536         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1537         (riscv_unwind_pc): Delete.
1538         (riscv_unwind_sp): Delete.
1539         (riscv_gdbarch_init): Don't register deleted functions with
1540         gdbarch.
1541
1542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1545         (csky_unwind_pc): Delete.
1546         (csky_unwind_sp): Delete.
1547         (csky_gdbarch_init): Don't register deleted functions with
1548         gdbarch.
1549
1550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1553         (cris_unwind_pc): Delete.
1554         (cris_unwind_sp): Delete.
1555         (cris_gdbarch_init): Don't register deleted functions with
1556         gdbarch.
1557
1558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1559
1560         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1561         (bfin_unwind_pc): Delete.
1562         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1563
1564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1567         (arm_unwind_pc): Delete.
1568         (arm_unwind_sp): Delete.
1569         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1570
1571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1572
1573         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1574         (arc_unwind_pc): Delete.
1575         (arc_unwind_sp): Delete.
1576         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1577
1578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1581         (alpha_unwind_pc): Delete.
1582         (alpha_gdbarch_init): Don't register deleted functions with
1583         gdbarch.
1584
1585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1588         (aarch64_unwind_pc): Delete.
1589         (aarch64_unwind_sp): Delete.
1590         (aarch64_gdbarch_init): Don't register deleted functions with
1591         gdbarch.
1592
1593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * gdbtypes.c (type_align): Don't consider static members when
1596         computing structure alignment.
1597
1598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1601         return 0 for other types.
1602         * arch-utils.c (default_type_align): Always return 0.
1603         * gdbarch.h: Regenerate.
1604         * gdbarch.sh (type_align): Extend comment.
1605         * gdbtypes.c (type_align): Add additional comments, always call
1606         gdbarch_type_align before applying the default rules.
1607         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1608         generic code will then apply a suitable default.
1609         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1610         types, return 0 for other types.
1611
1612 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1613
1614         * NEWS: Create a new section for the next release branch.
1615         Rename the section of the current branch, now that it has
1616         been cut.
1617
1618 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1619
1620         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1621         * version.in: Bump version to 8.3.50.DATE-git.
1622
1623 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1624
1625         * aix-thread.c (ptid_cmp): Remove unused variable.
1626         (get_signaled_thread): Likewise.
1627         (store_regs_user_thread): Likewise.
1628         (store_regs_kernel_thread): Likewise.
1629         (fetch_regs_kernel_thread): Remove shadowed variable.
1630
1631 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * features/riscv/32bit-cpu.xml: Add register numbers.
1634         * features/riscv/32bit-fpu.c: Regenerate.
1635         * features/riscv/32bit-fpu.xml: Add register numbers.
1636         * features/riscv/64bit-cpu.xml: Add register numbers.
1637         * features/riscv/64bit-fpu.c: Regenerate.
1638         * features/riscv/64bit-fpu.xml: Add register numbers.
1639
1640 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1641
1642         * NEWS: Mention two argument form of gdb.Value constructor.
1643         * python/py-value.c (convert_buffer_and_type_to_value): New
1644         function.
1645         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1646         Add support for handling an optional second argument.  Call
1647         convert_buffer_and_type_to_value as appropriate.
1648         * python/python-internal.h (Py_buffer_deleter): New struct.
1649         (Py_buffer_up): New typedef.
1650
1651 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1652
1653         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1654         instead of releasing ownership.
1655
1656 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1657
1658         * dwarf2read.c (open_and_init_dwp_file): Call
1659         elf_numsections instead of bfd_count_sections to initialize
1660         dwp_file->num_sections.
1661
1662 2019-02-25  Tom Tromey  <tromey@adacore.com>
1663
1664         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1665
1666 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1667
1668         * gcore.in: Add '--readnever' option when invoking GDB.
1669
1670 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1671
1672         * MAINTAINERS: Update my email address.
1673
1674 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1675
1676         * build-id.c (build_id_to_debug_bfd_1): New function.
1677         (build_id_to_debug_bfd): Look for separate debug file in
1678         sysroot.
1679
1680 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1681
1682         * gdbarch.sh: Update the copyright year range that is placed into
1683         generated files.
1684
1685 2019-02-22  Keith Seitz  <keiths@redhat.com>
1686
1687         PR symtab/23853
1688         * linespec.c (create_sals_line_offset): Search for the default
1689         symtab's filename instead of its fullname.
1690
1691 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * NEWS: Update style defaults.
1694
1695 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1696
1697         * main.c (captured_main_1): Disable styling in batch mode.
1698
1699 2019-02-20  Tom Tromey  <tom@tromey.com>
1700
1701         * symtab.c (symtab_symbol_info): Fix typos.
1702
1703 2019-02-20  Tom Tromey  <tromey@adacore.com>
1704
1705         * findcmd.c (_initialize_mem_search): Use upper case for
1706         metasyntactic variables.
1707
1708 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1709
1710         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1711         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1712
1713 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1714
1715         * top.h (source_file_name): Change to std::string.
1716         * top.c (source_file_name): Likewise.
1717         (command_line_input): Adjust.
1718         * cli/cli-script.c (script_from_file): Adjust.
1719
1720 2019-02-19  Tom Tromey  <tromey@adacore.com>
1721
1722         * ravenscar-thread.c
1723         (ravenscar_thread_target::update_thread_list): Don't call
1724         ada_build_task_list.
1725         * ada-lang.h (ada_build_task_list): Don't declare.
1726         * ada-tasks.c (struct ada_tasks_inferior_data)
1727         <task_list_valid_p>: Now bool.
1728         (read_known_tasks, ada_task_list_changed)
1729         (ada_tasks_invalidate_inferior_data): Update.
1730         (read_known_tasks_array): Return bool.
1731         (read_known_tasks_list): Likewise.
1732         (read_known_tasks): Return void.
1733         (ada_build_task_list): Now static.
1734
1735 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1736
1737         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1738         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1739
1740 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1741
1742         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1743         variant for ada_tasks_pspace_data_handle and
1744         ada_tasks_inferior_data_handle.
1745         (ada_tasks_pspace_data_cleanup): New function.
1746         (ada_tasks_inferior_data_cleanup): New function.
1747
1748 2019-02-17  Tom Tromey  <tom@tromey.com>
1749
1750         * macrotab.h (macro_source_fullname): Return a std::string.
1751         * macrotab.c (macro_include, check_for_redefinition)
1752         (macro_undef, macro_lookup_definition, foreach_macro)
1753         (foreach_macro_in_scope): Update.
1754         (macro_source_fullname): Return a std::string.
1755         * macrocmd.c (show_pp_source_pos): Update.
1756
1757 2019-02-17  Tom Tromey  <tom@tromey.com>
1758
1759         * macrocmd.c (show_pp_source_pos): Style the file names.
1760
1761 2019-02-17  Tom Tromey  <tom@tromey.com>
1762
1763         PR tui/24197:
1764         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1765
1766 2019-02-17  Tom Tromey  <tom@tromey.com>
1767
1768         * ada-lang.c (user_select_syms): Use filtered printing.
1769         * utils.c (wrap_style): New global.
1770         (desired_style): Remove.
1771         (emit_style_escape): Add stream parameter.
1772         (set_output_style, reset_terminal_style, prompt_for_continue):
1773         Update.
1774         (flush_wrap_buffer): Only flush gdb_stdout.
1775         (wrap_here): Set wrap_style.
1776         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1777         treat escape sequences as a character.  Change when wrap buffer is
1778         flushed.
1779         (fputs_styled): Do not set the output style when the default is
1780         requested.
1781         * ui-style.h (struct ui_file_style) <is_default>: New method.
1782         * source.c (print_source_lines_base): Emit escape sequences in one
1783         piece.
1784
1785 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1786
1787         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1788         integers and enumeration types.
1789
1790 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1791
1792         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1793         instead of lookup_symbol_in_language
1794         (do_exact_match): New function.
1795         (ada_get_symbol_name_matcher): Return do_exact_match when
1796         doing a verbatim match.
1797
1798 2019-02-15  Tom Tromey  <tromey@adacore.com>
1799
1800         * ravenscar-thread.c (ravenscar_thread_target::resume)
1801         (ravenscar_thread_target::wait): Special case wildcard requests.
1802
1803 2019-02-15  Tom Tromey  <tromey@adacore.com>
1804
1805         * ravenscar-thread.c (base_ptid): Remove.
1806         (struct ravenscar_thread_target) <close>: New method.
1807         <m_base_ptid>: New member.
1808         <update_inferior_ptid, active_task, task_is_currently_active,
1809         runtime_initialized>: Declare methods.
1810         <ravenscar_thread_target>: Add constructor.
1811         (ravenscar_thread_target::task_is_currently_active)
1812         (ravenscar_thread_target::update_inferior_ptid)
1813         (ravenscar_runtime_initialized): Rename.  Now methods.
1814         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1815         (ravenscar_thread_target::update_thread_list): Update.
1816         (ravenscar_thread_target::active_task): Now method.
1817         (ravenscar_thread_target::store_registers)
1818         (ravenscar_thread_target::prepare_to_store)
1819         (ravenscar_thread_target::prepare_to_store)
1820         (ravenscar_thread_target::mourn_inferior): Update.
1821         (ravenscar_inferior_created): Use "new" to create target.
1822         (ravenscar_thread_target::get_ada_task_ptid): Update.
1823         (_initialize_ravenscar): Don't initialize base_ptid.
1824         (ravenscar_ops): Remove global.
1825
1826 2019-02-15  Tom Tromey  <tromey@adacore.com>
1827
1828         * target.h (push_target): Declare new overload.
1829         * target.c (push_target): New overload, taking an rvalue reference.
1830         * remote.c (remote_target::open_1): Use push_target overload.
1831         * corelow.c (core_target_open): Use push_target overload.
1832
1833 2019-02-15  Tom Tromey  <tromey@adacore.com>
1834
1835         * ravenscar-thread.c (is_ravenscar_task)
1836         (ravenscar_task_is_currently_active): Return bool.
1837         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1838         (_initialize_ravenscar): Remove "(void)".
1839         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1840         Return bool.
1841
1842 2019-02-15  Tom Tromey  <tromey@adacore.com>
1843
1844         * ravenscar-thread.c (ravenscar_runtime_initializer)
1845         (has_ravenscar_runtime, get_running_thread_id)
1846         (ravenscar_thread_target::resume): Fix indentation.
1847
1848 2019-02-15  Tom Tromey  <tromey@adacore.com>
1849
1850         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1851         from ravenscar_arch_ops.
1852         (sparc_ravenscar_ops::fetch_registers)
1853         (sparc_ravenscar_ops::store_registers): Now methods.
1854         (sparc_ravenscar_prepare_to_store): Remove.
1855         (sparc_ravenscar_ops): Redefine.
1856         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1857         methods and destructor.  Remove members.
1858         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1859         (ravenscar_thread_target::store_registers)
1860         (ravenscar_thread_target::prepare_to_store): Update.
1861         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1862         Remove.
1863         (struct ppc_ravenscar_powerpc_ops): Derive from
1864         ravenscar_arch_ops.
1865         (ppc_ravenscar_powerpc_ops::fetch_registers)
1866         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1867         (ppc_ravenscar_powerpc_ops): Redefine.
1868         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1869         (ppc_ravenscar_e500_ops::fetch_registers)
1870         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1871         (ppc_ravenscar_e500_ops): Redefine.
1872         * aarch64-ravenscar-thread.c
1873         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1874         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1875         (aarch64_ravenscar_fetch_registers)
1876         (aarch64_ravenscar_store_registers): Now methods.
1877         (aarch64_ravenscar_ops): Redefine.
1878
1879 2019-02-15  Tom Tromey  <tromey@adacore.com>
1880
1881         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1882         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1883         (ravenscar_thread_target::stopped_by_watchpoint)
1884         (ravenscar_thread_target::stopped_data_address)
1885         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1886
1887 2019-02-15  Tom Tromey  <tromey@adacore.com>
1888
1889         * ravenscar-thread.c: Fix some typos.
1890
1891 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1892             Tom Tromey  <tromey@adacore.com>
1893
1894         * ada-lang.c (ada_exception_sal): Change addr_string to a
1895         std::string.
1896         (create_ada_exception_catchpoint): Update.
1897
1898 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1899             Tom Tromey  <tromey@adacore.com>
1900
1901         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1902         (bp_location_ops): Remove.
1903         (base_breakpoint_allocate_location): Update.
1904         (free_bp_location): Update.
1905         * ada-lang.c (class ada_catchpoint_location)
1906         <ada_catchpoint_location>: Remove ops parameter.
1907         (ada_catchpoint_location_dtor): Remove.
1908         (ada_catchpoint_location_ops): Remove.
1909         (allocate_location_exception): Update.
1910         * breakpoint.h (struct bp_location_ops): Remove.
1911         (class bp_location) <bp_location>: Remove bp_location_ops
1912         parameter.
1913         <~bp_location>: Add destructor.
1914         <ops>: Remove.
1915
1916 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1917             Pedro Alves  <palves@redhat.com>
1918
1919         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1920         'PATH_MAX'.
1921
1922 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1923             Samuel Thibault  <samuel.thibault@gnu.org>
1924             Thomas Schwinge  <thomas@codesourcery.com>
1925
1926         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1927         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1928
1929 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1930
1931         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1932         (check_empty): Use "const char *".
1933
1934         * gnu-nat.c (gnu_nat_target::detach): Instead of
1935         'detach_inferior (pid)' call
1936         'detach_inferior (find_inferior_pid (pid))'.
1937
1938         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1939         'nat/fork-inferior.o'.
1940         * gnu-nat.c: #include "nat/fork-inferior.h".
1941
1942         * gnu-nat.c (gnu_nat_target::detach): Instead of
1943         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1944         * gnu-nat.h: #include "inf-child.h".
1945         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1946         'i386_gnu_nat_target::fetch_registers'.
1947         (gnu_store_registers): Rename/move to
1948         'i386_gnu_nat_target::store_registers'.
1949
1950         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1951         * gnu-nat.h (mach_thread_info): New function.
1952         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1953
1954         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1955
1956 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1957
1958         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1959
1960 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1961
1962         * windows-nat.c (windows_add_thread): Add new parameter
1963         "main_thread_p" with default value set to false.  Update
1964         function documentation as well as all callers.
1965         (windows_delete_thread): Likewise.
1966         (fake_create_process): Update call to windows_add_thread.
1967         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1968         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1969         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1970         call to windows_delete_thread.
1971
1972 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1973
1974         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1975
1976 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1977
1978         * symfile.c (find_separate_debug_file): Use canonical path of
1979         sysroot with child_path instead of gdb_sysroot if it is valid.
1980
1981 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1982
1983         * symfile.c (find_separate_debug_file): Use child_path to
1984         determine if an object file is under a sysroot.
1985
1986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1987
1988         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1989         unittests/child-path-selftests.c.
1990         * common/pathstuff.c (child_path): New function.
1991         * common/pathstuff.h (child_path): New prototype.
1992         * unittests/child-path-selftests.c: New file.
1993
1994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1995
1996         * symfile.c (find_separate_debug_file): Look for separate debug
1997         files in debug directories under the sysroot.
1998
1999 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2000
2001         * symtab.h (struct minimal_symbol data_p): New const method.
2002         (struct minimal_symbol text_p): Likewise.
2003         * symtab.c (output_source_filename): Use file name style
2004         to print file name.
2005         (print_symbol_info): Likewise.
2006         (print_msymbol_info): Use address style to print addresses.
2007         Use function name style to print executable text symbols.
2008         (expand_symtab_containing_pc): Use data_p.
2009         (find_pc_sect_compunit_symtab): Likewise.
2010
2011 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2012
2013         * breakpoint.c (describe_other_breakpoints): Use address style
2014         to print addresses.
2015         (say_where): Likewise.
2016
2017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2018
2019         * ada-typeprint.c (print_func_type): Print function name
2020         style to print function name.
2021         * c-typeprint.c (c_print_type_1): Likewise.
2022
2023 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2024
2025         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2026         for execve.
2027
2028 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2029
2030         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2031         type_stack.
2032
2033 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2034
2035         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2036         TYPE_CODE_REF types.
2037
2038 2019-02-08  Jim Wilson  <jimw@sifive.com>
2039
2040         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2041         (riscv_linux_fregset): New.
2042         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2043
2044 2019-02-07  Tom Tromey  <tom@tromey.com>
2045
2046         * thread.c (thread_cancel_execution_command): Update.
2047         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2048         methods.
2049         (struct thread_fsm_ops): Remove.
2050         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2051         (thread_fsm_should_stop, thread_fsm_return_value)
2052         (thread_fsm_set_finished, thread_fsm_finished_p)
2053         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2054         Don't declare.
2055         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2056         * infrun.c (clear_proceed_status_thread)
2057         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2058         (print_stop_event): Update.
2059         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2060         Add constructor.
2061         (step_command_fsm_ops): Remove.
2062         (new_step_command_fsm): Remove.
2063         (step_1): Update.
2064         (step_command_fsm::should_stop): Rename from
2065         step_command_fsm_should_stop.
2066         (step_command_fsm::clean_up): Rename from
2067         step_command_fsm_clean_up.
2068         (step_command_fsm::do_async_reply_reason): Rename from
2069         step_command_fsm_async_reply_reason.
2070         (struct until_next_fsm): Inherit from thread_fsm.  Add
2071         constructor.
2072         (until_next_fsm_ops): Remove.
2073         (new_until_next_fsm): Remove.
2074         (until_next_fsm::should_stop): Rename from
2075         until_next_fsm_should_stop.
2076         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2077         (until_next_fsm::do_async_reply_reason): Rename from
2078         until_next_fsm_async_reply_reason.
2079         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2080         constructor.  Change type of breakpoint.
2081         (finish_command_fsm_ops): Remove.
2082         (new_finish_command_fsm): Remove.
2083         (finish_command_fsm::should_stop): Rename from
2084         finish_command_fsm_should_stop.
2085         (finish_command_fsm::clean_up): Rename from
2086         finish_command_fsm_clean_up.
2087         (finish_command_fsm::return_value): Rename from
2088         finish_command_fsm_return_value.
2089         (finish_command_fsm::do_async_reply_reason): Rename from
2090         finish_command_fsm_async_reply_reason.
2091         (finish_command): Update.
2092         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2093         Add constructor.
2094         (call_thread_fsm_ops): Remove.
2095         (call_thread_fsm::call_thread_fsm): Rename from
2096         new_call_thread_fsm.
2097         (call_thread_fsm::should_stop): Rename from
2098         call_thread_fsm_should_stop.
2099         (call_thread_fsm::should_notify_stop): Rename from
2100         call_thread_fsm_should_notify_stop.
2101         (run_inferior_call, call_function_by_hand_dummy): Update.
2102         * cli/cli-interp.c (should_print_stop_to_console): Update.
2103         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2104         Add constructor.  Change type of location_breakpoint,
2105         caller_breakpoint.
2106         (until_break_fsm_ops): Remove.
2107         (new_until_break_fsm): Remove.
2108         (until_break_fsm::should_stop): Rename from
2109         until_break_fsm_should_stop.
2110         (until_break_fsm::clean_up): Rename from
2111         until_break_fsm_clean_up.
2112         (until_break_fsm::do_async_reply_reason): Rename from
2113         until_break_fsm_async_reply_reason.
2114         (until_break_command): Update.
2115         * thread-fsm.c: Remove.
2116         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2117
2118 2019-02-07  Tom Tromey  <tom@tromey.com>
2119
2120         * yy-remap.h: Add include guard.
2121         * xtensa-tdep.h: Add include guard.
2122         * xcoffread.h: Rename include guard.
2123         * varobj-iter.h: Add include guard.
2124         * tui/tui.h: Rename include guard.
2125         * tui/tui-winsource.h: Rename include guard.
2126         * tui/tui-wingeneral.h: Rename include guard.
2127         * tui/tui-windata.h: Rename include guard.
2128         * tui/tui-win.h: Rename include guard.
2129         * tui/tui-stack.h: Rename include guard.
2130         * tui/tui-source.h: Rename include guard.
2131         * tui/tui-regs.h: Rename include guard.
2132         * tui/tui-out.h: Rename include guard.
2133         * tui/tui-layout.h: Rename include guard.
2134         * tui/tui-io.h: Rename include guard.
2135         * tui/tui-hooks.h: Rename include guard.
2136         * tui/tui-file.h: Rename include guard.
2137         * tui/tui-disasm.h: Rename include guard.
2138         * tui/tui-data.h: Rename include guard.
2139         * tui/tui-command.h: Rename include guard.
2140         * tic6x-tdep.h: Add include guard.
2141         * target/waitstatus.h: Rename include guard.
2142         * target/wait.h: Rename include guard.
2143         * target/target.h: Rename include guard.
2144         * target/resume.h: Rename include guard.
2145         * target-float.h: Rename include guard.
2146         * stabsread.h: Add include guard.
2147         * rs6000-tdep.h: Add include guard.
2148         * riscv-fbsd-tdep.h: Add include guard.
2149         * regformats/regdef.h: Rename include guard.
2150         * record.h: Rename include guard.
2151         * python/python.h: Rename include guard.
2152         * python/python-internal.h: Rename include guard.
2153         * python/py-stopevent.h: Rename include guard.
2154         * python/py-ref.h: Rename include guard.
2155         * python/py-record.h: Rename include guard.
2156         * python/py-record-full.h: Rename include guard.
2157         * python/py-record-btrace.h: Rename include guard.
2158         * python/py-instruction.h: Rename include guard.
2159         * python/py-events.h: Rename include guard.
2160         * python/py-event.h: Rename include guard.
2161         * procfs.h: Add include guard.
2162         * proc-utils.h: Add include guard.
2163         * p-lang.h: Add include guard.
2164         * or1k-tdep.h: Rename include guard.
2165         * observable.h: Rename include guard.
2166         * nto-tdep.h: Rename include guard.
2167         * nat/x86-linux.h: Rename include guard.
2168         * nat/x86-linux-dregs.h: Rename include guard.
2169         * nat/x86-gcc-cpuid.h: Add include guard.
2170         * nat/x86-dregs.h: Rename include guard.
2171         * nat/x86-cpuid.h: Rename include guard.
2172         * nat/ppc-linux.h: Rename include guard.
2173         * nat/mips-linux-watch.h: Rename include guard.
2174         * nat/linux-waitpid.h: Rename include guard.
2175         * nat/linux-ptrace.h: Rename include guard.
2176         * nat/linux-procfs.h: Rename include guard.
2177         * nat/linux-osdata.h: Rename include guard.
2178         * nat/linux-nat.h: Rename include guard.
2179         * nat/linux-namespaces.h: Rename include guard.
2180         * nat/linux-btrace.h: Rename include guard.
2181         * nat/glibc_thread_db.h: Rename include guard.
2182         * nat/gdb_thread_db.h: Rename include guard.
2183         * nat/gdb_ptrace.h: Rename include guard.
2184         * nat/fork-inferior.h: Rename include guard.
2185         * nat/amd64-linux-siginfo.h: Rename include guard.
2186         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2187         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2188         * nat/aarch64-linux.h: Rename include guard.
2189         * nat/aarch64-linux-hw-point.h: Rename include guard.
2190         * mn10300-tdep.h: Add include guard.
2191         * mips-linux-tdep.h: Add include guard.
2192         * mi/mi-parse.h: Rename include guard.
2193         * mi/mi-out.h: Rename include guard.
2194         * mi/mi-main.h: Rename include guard.
2195         * mi/mi-interp.h: Rename include guard.
2196         * mi/mi-getopt.h: Rename include guard.
2197         * mi/mi-console.h: Rename include guard.
2198         * mi/mi-common.h: Rename include guard.
2199         * mi/mi-cmds.h: Rename include guard.
2200         * mi/mi-cmd-break.h: Rename include guard.
2201         * m2-lang.h: Add include guard.
2202         * location.h: Rename include guard.
2203         * linux-record.h: Rename include guard.
2204         * linux-nat.h: Add include guard.
2205         * linux-fork.h: Add include guard.
2206         * i386-darwin-tdep.h: Rename include guard.
2207         * hppa-linux-offsets.h: Add include guard.
2208         * guile/guile.h: Rename include guard.
2209         * guile/guile-internal.h: Rename include guard.
2210         * gnu-nat.h: Rename include guard.
2211         * gdb-stabs.h: Rename include guard.
2212         * frv-tdep.h: Add include guard.
2213         * f-lang.h: Add include guard.
2214         * event-loop.h: Add include guard.
2215         * darwin-nat.h: Rename include guard.
2216         * cp-abi.h: Rename include guard.
2217         * config/sparc/nm-sol2.h: Rename include guard.
2218         * config/nm-nto.h: Rename include guard.
2219         * config/nm-linux.h: Add include guard.
2220         * config/i386/nm-i386gnu.h: Rename include guard.
2221         * config/djgpp/nl_types.h: Rename include guard.
2222         * config/djgpp/langinfo.h: Rename include guard.
2223         * compile/gcc-cp-plugin.h: Add include guard.
2224         * compile/gcc-c-plugin.h: Add include guard.
2225         * compile/compile.h: Rename include guard.
2226         * compile/compile-object-run.h: Rename include guard.
2227         * compile/compile-object-load.h: Rename include guard.
2228         * compile/compile-internal.h: Rename include guard.
2229         * compile/compile-cplus.h: Rename include guard.
2230         * compile/compile-c.h: Rename include guard.
2231         * common/xml-utils.h: Rename include guard.
2232         * common/x86-xstate.h: Rename include guard.
2233         * common/version.h: Rename include guard.
2234         * common/vec.h: Rename include guard.
2235         * common/tdesc.h: Rename include guard.
2236         * common/selftest.h: Rename include guard.
2237         * common/scoped_restore.h: Rename include guard.
2238         * common/scoped_mmap.h: Rename include guard.
2239         * common/scoped_fd.h: Rename include guard.
2240         * common/safe-iterator.h: Rename include guard.
2241         * common/run-time-clock.h: Rename include guard.
2242         * common/refcounted-object.h: Rename include guard.
2243         * common/queue.h: Rename include guard.
2244         * common/ptid.h: Rename include guard.
2245         * common/print-utils.h: Rename include guard.
2246         * common/preprocessor.h: Rename include guard.
2247         * common/pathstuff.h: Rename include guard.
2248         * common/observable.h: Rename include guard.
2249         * common/netstuff.h: Rename include guard.
2250         * common/job-control.h: Rename include guard.
2251         * common/host-defs.h: Rename include guard.
2252         * common/gdb_wait.h: Rename include guard.
2253         * common/gdb_vecs.h: Rename include guard.
2254         * common/gdb_unlinker.h: Rename include guard.
2255         * common/gdb_unique_ptr.h: Rename include guard.
2256         * common/gdb_tilde_expand.h: Rename include guard.
2257         * common/gdb_sys_time.h: Rename include guard.
2258         * common/gdb_string_view.h: Rename include guard.
2259         * common/gdb_splay_tree.h: Rename include guard.
2260         * common/gdb_setjmp.h: Rename include guard.
2261         * common/gdb_ref_ptr.h: Rename include guard.
2262         * common/gdb_optional.h: Rename include guard.
2263         * common/gdb_locale.h: Rename include guard.
2264         * common/gdb_assert.h: Rename include guard.
2265         * common/filtered-iterator.h: Rename include guard.
2266         * common/filestuff.h: Rename include guard.
2267         * common/fileio.h: Rename include guard.
2268         * common/environ.h: Rename include guard.
2269         * common/common-utils.h: Rename include guard.
2270         * common/common-types.h: Rename include guard.
2271         * common/common-regcache.h: Rename include guard.
2272         * common/common-inferior.h: Rename include guard.
2273         * common/common-gdbthread.h: Rename include guard.
2274         * common/common-exceptions.h: Rename include guard.
2275         * common/common-defs.h: Rename include guard.
2276         * common/common-debug.h: Rename include guard.
2277         * common/cleanups.h: Rename include guard.
2278         * common/buffer.h: Rename include guard.
2279         * common/btrace-common.h: Rename include guard.
2280         * common/break-common.h: Rename include guard.
2281         * cli/cli-utils.h: Rename include guard.
2282         * cli/cli-style.h: Rename include guard.
2283         * cli/cli-setshow.h: Rename include guard.
2284         * cli/cli-script.h: Rename include guard.
2285         * cli/cli-interp.h: Rename include guard.
2286         * cli/cli-decode.h: Rename include guard.
2287         * cli/cli-cmds.h: Rename include guard.
2288         * charset-list.h: Add include guard.
2289         * buildsym-legacy.h: Rename include guard.
2290         * bfin-tdep.h: Add include guard.
2291         * ax.h: Rename include guard.
2292         * arm-linux-tdep.h: Add include guard.
2293         * arm-fbsd-tdep.h: Add include guard.
2294         * arch/xtensa.h: Rename include guard.
2295         * arch/tic6x.h: Add include guard.
2296         * arch/i386.h: Add include guard.
2297         * arch/arm.h: Rename include guard.
2298         * arch/arm-linux.h: Rename include guard.
2299         * arch/arm-get-next-pcs.h: Rename include guard.
2300         * arch/amd64.h: Add include guard.
2301         * arch/aarch64-insn.h: Rename include guard.
2302         * arch-utils.h: Rename include guard.
2303         * annotate.h: Add include guard.
2304         * amd64-darwin-tdep.h: Rename include guard.
2305         * aarch64-linux-tdep.h: Add include guard.
2306         * aarch64-fbsd-tdep.h: Add include guard.
2307         * aarch32-linux-nat.h: Add include guard.
2308
2309 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2310
2311         * macrotab.c (macro_define_internal): New function that
2312         factorizes macro_define_object_internal and macro_define_function
2313         code.
2314         (macro_define_object_internal): Use macro_define_internal.
2315         (macro_define_function): Likewise.
2316
2317 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2318
2319         * macrocmd.c (extract_identifier): Return
2320         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2321         callers.
2322
2323 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2324
2325         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2326
2327 2019-02-05  Tom Tromey  <tom@tromey.com>
2328
2329         * target.c (target_stack::unpush): Move assertion earlier.
2330
2331 2019-01-30  Tom Tromey  <tom@tromey.com>
2332
2333         PR python/23615:
2334         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2335         (gdbpy_parse_and_eval): Likewise.
2336         * python/python-internal.h (gdbpy_allow_threads): New class.
2337
2338 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2339
2340         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2341         (aarch64_fbsd_fpregmap): Move earlier.
2342         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2343         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2344         instead of individual calls to trad_frame_set_reg_addr.
2345         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2346         earlier.
2347         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2348         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2349         instead of individual calls to trad_frame_set_reg_addr.
2350
2351 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2352
2353         * CONTRIBUTE: Replace contribution list with wiki link.
2354
2355 2019-01-25  Tom Tromey  <tom@tromey.com>
2356
2357         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2358
2359 2019-01-25  Tom Tromey  <tom@tromey.com>
2360
2361         * xtensa-linux-nat.c: Fix common/ includes.
2362         * xml-support.h: Fix common/ includes.
2363         * xml-support.c: Fix common/ includes.
2364         * x86-linux-nat.c: Fix common/ includes.
2365         * windows-nat.c: Fix common/ includes.
2366         * varobj.h: Fix common/ includes.
2367         * varobj.c: Fix common/ includes.
2368         * value.c: Fix common/ includes.
2369         * valops.c: Fix common/ includes.
2370         * utils.c: Fix common/ includes.
2371         * unittests/xml-utils-selftests.c: Fix common/ includes.
2372         * unittests/utils-selftests.c: Fix common/ includes.
2373         * unittests/unpack-selftests.c: Fix common/ includes.
2374         * unittests/tracepoint-selftests.c: Fix common/ includes.
2375         * unittests/style-selftests.c: Fix common/ includes.
2376         * unittests/string_view-selftests.c: Fix common/ includes.
2377         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2378         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2379         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2380         * unittests/rsp-low-selftests.c: Fix common/ includes.
2381         * unittests/parse-connection-spec-selftests.c: Fix common/
2382         includes.
2383         * unittests/optional-selftests.c: Fix common/ includes.
2384         * unittests/offset-type-selftests.c: Fix common/ includes.
2385         * unittests/observable-selftests.c: Fix common/ includes.
2386         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2387         * unittests/memrange-selftests.c: Fix common/ includes.
2388         * unittests/memory-map-selftests.c: Fix common/ includes.
2389         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2390         * unittests/function-view-selftests.c: Fix common/ includes.
2391         * unittests/environ-selftests.c: Fix common/ includes.
2392         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2393         * unittests/common-utils-selftests.c: Fix common/ includes.
2394         * unittests/cli-utils-selftests.c: Fix common/ includes.
2395         * unittests/array-view-selftests.c: Fix common/ includes.
2396         * ui-file.c: Fix common/ includes.
2397         * tui/tui-io.c: Fix common/ includes.
2398         * tracepoint.h: Fix common/ includes.
2399         * tracepoint.c: Fix common/ includes.
2400         * tracefile-tfile.c: Fix common/ includes.
2401         * top.h: Fix common/ includes.
2402         * top.c: Fix common/ includes.
2403         * thread.c: Fix common/ includes.
2404         * target/waitstatus.h: Fix common/ includes.
2405         * target/waitstatus.c: Fix common/ includes.
2406         * target.h: Fix common/ includes.
2407         * target.c: Fix common/ includes.
2408         * target-memory.c: Fix common/ includes.
2409         * target-descriptions.c: Fix common/ includes.
2410         * symtab.h: Fix common/ includes.
2411         * symfile.c: Fix common/ includes.
2412         * stap-probe.c: Fix common/ includes.
2413         * spu-linux-nat.c: Fix common/ includes.
2414         * sparc-nat.c: Fix common/ includes.
2415         * source.c: Fix common/ includes.
2416         * solib.c: Fix common/ includes.
2417         * solib-target.c: Fix common/ includes.
2418         * ser-unix.c: Fix common/ includes.
2419         * ser-tcp.c: Fix common/ includes.
2420         * ser-pipe.c: Fix common/ includes.
2421         * ser-base.c: Fix common/ includes.
2422         * selftest-arch.c: Fix common/ includes.
2423         * s12z-tdep.c: Fix common/ includes.
2424         * rust-exp.y: Fix common/ includes.
2425         * rs6000-aix-tdep.c: Fix common/ includes.
2426         * riscv-tdep.c: Fix common/ includes.
2427         * remote.c: Fix common/ includes.
2428         * remote-notif.h: Fix common/ includes.
2429         * remote-fileio.h: Fix common/ includes.
2430         * remote-fileio.c: Fix common/ includes.
2431         * regcache.h: Fix common/ includes.
2432         * regcache.c: Fix common/ includes.
2433         * record-btrace.c: Fix common/ includes.
2434         * python/python.c: Fix common/ includes.
2435         * python/py-type.c: Fix common/ includes.
2436         * python/py-inferior.c: Fix common/ includes.
2437         * progspace.h: Fix common/ includes.
2438         * producer.c: Fix common/ includes.
2439         * procfs.c: Fix common/ includes.
2440         * proc-api.c: Fix common/ includes.
2441         * printcmd.c: Fix common/ includes.
2442         * ppc-linux-nat.c: Fix common/ includes.
2443         * parser-defs.h: Fix common/ includes.
2444         * osdata.c: Fix common/ includes.
2445         * obsd-nat.c: Fix common/ includes.
2446         * nat/x86-linux.c: Fix common/ includes.
2447         * nat/x86-linux-dregs.c: Fix common/ includes.
2448         * nat/x86-dregs.h: Fix common/ includes.
2449         * nat/x86-dregs.c: Fix common/ includes.
2450         * nat/ppc-linux.c: Fix common/ includes.
2451         * nat/mips-linux-watch.h: Fix common/ includes.
2452         * nat/mips-linux-watch.c: Fix common/ includes.
2453         * nat/linux-waitpid.c: Fix common/ includes.
2454         * nat/linux-ptrace.h: Fix common/ includes.
2455         * nat/linux-ptrace.c: Fix common/ includes.
2456         * nat/linux-procfs.c: Fix common/ includes.
2457         * nat/linux-personality.c: Fix common/ includes.
2458         * nat/linux-osdata.c: Fix common/ includes.
2459         * nat/linux-namespaces.c: Fix common/ includes.
2460         * nat/linux-btrace.h: Fix common/ includes.
2461         * nat/linux-btrace.c: Fix common/ includes.
2462         * nat/fork-inferior.c: Fix common/ includes.
2463         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2464         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2465         * nat/aarch64-linux.c: Fix common/ includes.
2466         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2467         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2468         * namespace.h: Fix common/ includes.
2469         * mips-linux-tdep.c: Fix common/ includes.
2470         * minsyms.c: Fix common/ includes.
2471         * mi/mi-parse.h: Fix common/ includes.
2472         * mi/mi-main.c: Fix common/ includes.
2473         * mi/mi-cmd-env.c: Fix common/ includes.
2474         * memrange.h: Fix common/ includes.
2475         * memattr.c: Fix common/ includes.
2476         * maint.h: Fix common/ includes.
2477         * maint.c: Fix common/ includes.
2478         * main.c: Fix common/ includes.
2479         * machoread.c: Fix common/ includes.
2480         * location.c: Fix common/ includes.
2481         * linux-thread-db.c: Fix common/ includes.
2482         * linux-nat.c: Fix common/ includes.
2483         * linux-fork.c: Fix common/ includes.
2484         * inline-frame.c: Fix common/ includes.
2485         * infrun.c: Fix common/ includes.
2486         * inflow.c: Fix common/ includes.
2487         * inferior.h: Fix common/ includes.
2488         * inferior.c: Fix common/ includes.
2489         * infcmd.c: Fix common/ includes.
2490         * inf-ptrace.c: Fix common/ includes.
2491         * inf-child.c: Fix common/ includes.
2492         * ia64-linux-nat.c: Fix common/ includes.
2493         * i387-tdep.c: Fix common/ includes.
2494         * i386-tdep.c: Fix common/ includes.
2495         * i386-linux-tdep.c: Fix common/ includes.
2496         * i386-linux-nat.c: Fix common/ includes.
2497         * i386-go32-tdep.c: Fix common/ includes.
2498         * i386-fbsd-tdep.c: Fix common/ includes.
2499         * i386-fbsd-nat.c: Fix common/ includes.
2500         * guile/scm-type.c: Fix common/ includes.
2501         * guile/guile.c: Fix common/ includes.
2502         * go32-nat.c: Fix common/ includes.
2503         * gnu-nat.c: Fix common/ includes.
2504         * gdbthread.h: Fix common/ includes.
2505         * gdbarch-selftests.c: Fix common/ includes.
2506         * gdb_usleep.c: Fix common/ includes.
2507         * gdb_select.h: Fix common/ includes.
2508         * gdb_bfd.c: Fix common/ includes.
2509         * gcore.c: Fix common/ includes.
2510         * fork-child.c: Fix common/ includes.
2511         * findvar.c: Fix common/ includes.
2512         * fbsd-nat.c: Fix common/ includes.
2513         * event-top.c: Fix common/ includes.
2514         * event-loop.c: Fix common/ includes.
2515         * dwarf2read.c: Fix common/ includes.
2516         * dwarf2loc.c: Fix common/ includes.
2517         * dwarf2-frame.c: Fix common/ includes.
2518         * dwarf-index-cache.c: Fix common/ includes.
2519         * dtrace-probe.c: Fix common/ includes.
2520         * disasm-selftests.c: Fix common/ includes.
2521         * defs.h: Fix common/ includes.
2522         * csky-tdep.c: Fix common/ includes.
2523         * cp-valprint.c: Fix common/ includes.
2524         * cp-support.h: Fix common/ includes.
2525         * cp-support.c: Fix common/ includes.
2526         * corelow.c: Fix common/ includes.
2527         * completer.h: Fix common/ includes.
2528         * completer.c: Fix common/ includes.
2529         * compile/compile.c: Fix common/ includes.
2530         * compile/compile-loc2c.c: Fix common/ includes.
2531         * compile/compile-cplus-types.c: Fix common/ includes.
2532         * compile/compile-cplus-symbols.c: Fix common/ includes.
2533         * command.h: Fix common/ includes.
2534         * cli/cli-dump.c: Fix common/ includes.
2535         * cli/cli-cmds.c: Fix common/ includes.
2536         * charset.c: Fix common/ includes.
2537         * build-id.c: Fix common/ includes.
2538         * btrace.h: Fix common/ includes.
2539         * btrace.c: Fix common/ includes.
2540         * breakpoint.h: Fix common/ includes.
2541         * breakpoint.c: Fix common/ includes.
2542         * ax.h:
2543         (enum agent_op): Fix common/ includes.
2544         * ax-general.c (struct aop_map): Fix common/ includes.
2545         * ax-gdb.c: Fix common/ includes.
2546         * auxv.c: Fix common/ includes.
2547         * auto-load.c: Fix common/ includes.
2548         * arm-tdep.c: Fix common/ includes.
2549         * arch/riscv.c: Fix common/ includes.
2550         * arch/ppc-linux-common.c: Fix common/ includes.
2551         * arch/i386.c: Fix common/ includes.
2552         * arch/arm.c: Fix common/ includes.
2553         * arch/arm-linux.c: Fix common/ includes.
2554         * arch/arm-get-next-pcs.c: Fix common/ includes.
2555         * arch/amd64.c: Fix common/ includes.
2556         * arch/aarch64.c: Fix common/ includes.
2557         * arch/aarch64-insn.c: Fix common/ includes.
2558         * arch-utils.c: Fix common/ includes.
2559         * amd64-windows-tdep.c: Fix common/ includes.
2560         * amd64-tdep.c: Fix common/ includes.
2561         * amd64-sol2-tdep.c: Fix common/ includes.
2562         * amd64-obsd-tdep.c: Fix common/ includes.
2563         * amd64-nbsd-tdep.c: Fix common/ includes.
2564         * amd64-linux-tdep.c: Fix common/ includes.
2565         * amd64-linux-nat.c: Fix common/ includes.
2566         * amd64-fbsd-tdep.c: Fix common/ includes.
2567         * amd64-fbsd-nat.c: Fix common/ includes.
2568         * amd64-dicos-tdep.c: Fix common/ includes.
2569         * amd64-darwin-tdep.c: Fix common/ includes.
2570         * agent.c: Fix common/ includes.
2571         * ada-lang.h: Fix common/ includes.
2572         * ada-lang.c: Fix common/ includes.
2573         * aarch64-tdep.c: Fix common/ includes.
2574
2575 2019-01-25  Tom Tromey  <tom@tromey.com>
2576
2577         * common/create-version.sh: Use common/version.h.
2578
2579 2019-01-24  Pedro Alves  <palves@redhat.com>
2580
2581         * infrun.c (signal_stop, signal_print, signal_program)
2582         (signal_catch, signal_pass): Now arrays instead of pointers.
2583         (update_signals_program_target, do_target_resume)
2584         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2585         * linux-nat.c (linux_nat_target::pass_signals)
2586         (linux_nat_target::create_inferior, linux_nat_target::attach):
2587         Adjust.
2588         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2589         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2590         * procfs.c (procfs_target::pass_signals): Adjust.
2591         * record-full.c (record_full_target::resume): Adjust.
2592         * remote.c (remote_target::pass_signals)
2593         (remote_target::program_signals): Adjust.
2594         * target-debug.h (target_debug_print_signals): Now takes a
2595         gdb::array_view as parameter.  Adjust.
2596         * target.h (target_ops) <pass_signals, program_signals>: Replace
2597         pointer and length parameters with gdb::array_view.
2598         (target_pass_signals, target_program_signals): Likewise.
2599         * target-delegates.c: Regenerate.
2600
2601 2019-01-24  Pedro Alves  <palves@redhat.com>
2602
2603         * common/forward-scope-exit.h
2604         (forward_scope_exit::forward_scope_exit): Pass arguments to
2605         m_bind_function directly, instead of creating a std::bind and
2606         copying that.
2607
2608 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2609
2610         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2611         for static members.
2612         (pass_in_v_vfp_candidate): Likewise.
2613
2614 2019-01-23  Tom Tromey  <tom@tromey.com>
2615             Pedro Alves  <palves@redhat.com>
2616
2617         * regcache.c (class regcache_invalidator): Remove.
2618         (regcache::raw_write): Use make_scope_exit.
2619
2620 2019-01-23  Tom Tromey  <tom@tromey.com>
2621
2622         * ui-out.h (class ui_out_emit_type): Update comment.
2623
2624 2019-01-23  Tom Tromey  <tom@tromey.com>
2625
2626         * infrun.c (fetch_inferior_event): Update comment.
2627
2628 2019-01-23  Tom Tromey  <tom@tromey.com>
2629             Pedro Alves  <palves@redhat.com>
2630
2631         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2632         parameter.
2633         (fetch_inferior_event): Use SCOPE_EXIT.
2634
2635
2636 2019-01-23  Tom Tromey  <tom@tromey.com>
2637             Pedro Alves  <palves@redhat.com>
2638
2639         * infrun.c (disable_thread_events): Delete.
2640         (stop_all_threads): Use SCOPE_EXIT.
2641
2642 2019-01-23  Tom Tromey  <tom@tromey.com>
2643             Pedro Alves  <palves@redhat.com>
2644
2645         * symfile.c: Include forward-scope-exit.h.
2646         (clear_symtab_users_cleanup): Replace forward declaration with
2647         a FORWARD_SCOPE_EXIT.
2648         (syms_from_objfile_1): Use the forward_scope_exit and
2649         gdb::optional instead of cleanup_function.
2650         (reread_symbols): Use the forward_scope_exit instead of
2651         cleanup_function.
2652         (clear_symtab_users_cleanup): Remove function.
2653
2654 2019-01-23  Tom Tromey  <tom@tromey.com>
2655             Pedro Alves  <palves@redhat.com>
2656
2657         * linux-nat.c: Include scope-exit.h.
2658         (cleanup_target_stop): Remove.
2659         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2660         SCOPE_EXIT.
2661
2662 2019-01-23  Tom Tromey  <tom@tromey.com>
2663             Pedro Alves  <palves@redhat.com>
2664
2665         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2666         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2667
2668 2019-01-23  Tom Tromey  <tom@tromey.com>
2669             Andrew Burgess  <andrew.burgess@embecosm.com>
2670             Pedro Alves  <palves@redhat.com>
2671
2672         * infrun.c (fetch_inferior_event): Use scope_exit.
2673         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2674         * top.c (execute_command): Use scope_exit.
2675         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2676         * utils.c (do_bpstat_clear_actions_cleanup)
2677         (make_bpstat_clear_actions_cleanup): Remove.
2678
2679 2019-01-23  Tom Tromey  <tom@tromey.com>
2680             Pedro Alves  <palves@redhat.com>
2681
2682         * infrun.c: Include "common/scope-exit.h"
2683         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2684         (wait_for_inferior): Use SCOPE_EXIT.
2685         (fetch_inferior_event): Use scope_exit.
2686
2687 2019-01-23  Tom Tromey  <tom@tromey.com>
2688             Pedro Alves  <palves@redhat.com>
2689
2690         * breakpoint.c (create_breakpoint): Remove cleanup.
2691
2692 2019-01-23  Tom Tromey  <tom@tromey.com>
2693             Andrew Burgess  <andrew.burgess@embecosm.com>
2694             Pedro Alves  <palves@redhat.com>
2695
2696 2019-01-23  Pedro Alves  <palves@redhat.com>
2697
2698         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2699
2700 2019-01-23  Pedro Alves  <palves@redhat.com>
2701             Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * gdbthread.h: Include "common/forward-scope-exit.h".
2704         (scoped_finish_thread_state): Redefine custom class in terms of
2705         forward_scope_exit.
2706
2707 2019-01-23  Pedro Alves  <palves@redhat.com>
2708             Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * common/forward-scope-exit.h: New file.
2711
2712 2019-01-23  Pedro Alves  <palves@redhat.com>
2713             Andrew Burgess  <andrew.burgess@embecosm.com>
2714             Tom Tromey  <tom@tromey.com>
2715
2716         * common/scope-exit.h: New file.
2717
2718 2019-01-23  Pedro Alves  <palves@redhat.com>
2719
2720         * common/preprocessor.h (ESC): Rename to ...
2721         (ESC_PARENS): ... this.
2722         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2723         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2724
2725 2019-01-23  Tom Tromey  <tom@tromey.com>
2726
2727         * language.h (class scoped_switch_to_sym_language_if_auto):
2728         Initialize m_lang in both cases.
2729
2730 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2731
2732         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2733         with XCNEW.
2734
2735 2019-01-22  Tom Tromey  <tom@tromey.com>
2736
2737         * corelow.c: Do not include sys/file.h.
2738
2739 2019-01-22  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-wingeneral.h: Include gdb_curses.h.
2742
2743 2019-01-22  Tom Tromey  <tom@tromey.com>
2744
2745         * source-cache.h (class source_cache) <get_source_lines,
2746         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2747
2748 2019-01-22  Tom Tromey  <tom@tromey.com>
2749
2750         * remote-fileio.h (struct remote_target): Declare.
2751
2752 2019-01-22  Tom Tromey  <tom@tromey.com>
2753
2754         * python/py-arch.c: Do not include py-ref.h.
2755         * python/py-bpevent.c: Do not include py-ref.h.
2756         * python/py-cmd.c: Do not include py-ref.h.
2757         * python/py-continueevent.c: Do not include py-ref.h.
2758         * python/py-event.h: Do not include py-ref.h.
2759         * python/py-evtregistry.c: Do not include py-ref.h.
2760         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2761         * python/py-frame.c: Do not include py-ref.h.
2762         * python/py-framefilter.c: Do not include py-ref.h.
2763         * python/py-function.c: Do not include py-ref.h.
2764         * python/py-infevents.c: Do not include py-ref.h.
2765         * python/py-linetable.c: Do not include py-ref.h.
2766         * python/py-objfile.c: Do not include py-ref.h.
2767         * python/py-param.c: Do not include py-ref.h.
2768         * python/py-prettyprint.c: Do not include py-ref.h.
2769         * python/py-progspace.c: Do not include py-ref.h.
2770         * python/py-symbol.c: Do not include py-ref.h.
2771         * python/py-symtab.c: Do not include py-ref.h.
2772         * python/py-type.c: Do not include py-ref.h.
2773         * python/py-unwind.c: Do not include py-ref.h.
2774         * python/py-utils.c: Do not include py-ref.h.
2775         * python/py-value.c: Do not include py-ref.h.
2776         * python/py-varobj.c: Do not include py-ref.h.
2777         * python/py-xmethods.c: Do not include py-ref.h.
2778         * python/python.c: Do not include py-ref.h.
2779         * varobj.c: Do not include py-ref.h.
2780
2781 2019-01-22  Tom Tromey  <tom@tromey.com>
2782
2783         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2784         keyword for bcache.
2785
2786 2019-01-22  Tom Tromey  <tom@tromey.com>
2787
2788         * compile/compile-cplus-types.c: Remove a comment by #include.
2789
2790 2019-01-22  Tom Tromey  <tom@tromey.com>
2791
2792         * compile/gcc-c-plugin.h: Include compile-internal.h.
2793
2794 2019-01-22  Tom Tromey  <tom@tromey.com>
2795
2796         * stabsread.c (EXTERN): Do not define.
2797         (symnum, next_symbol_text_func, processing_gcc_compilation)
2798         (within_function, global_sym_chain, global_stabs)
2799         (previous_stab_code, this_object_header_files)
2800         (n_this_object_header_files)
2801         (n_allocated_this_object_header_files): Define.
2802         * stabsread.h (EXTERN): Never define.  Use "extern".
2803
2804 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2805
2806         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2807         history_value.
2808
2809 2019-01-21  Tom Tromey  <tom@tromey.com>
2810
2811         * ui-out.c: Fix includes.
2812         * tui/tui-source.c: Fix includes.
2813         * target.c: Fix includes.
2814         * remote.c: Fix includes.
2815         * regcache.c: Fix includes.
2816         * python/py-block.c: Fix includes.
2817         * printcmd.c: Fix includes.
2818         * or1k-tdep.c: Fix includes.
2819         * mi/mi-main.c: Fix includes.
2820         * m32r-tdep.c: Fix includes.
2821         * csky-tdep.c: Fix includes.
2822         * compile/compile-cplus-types.c: Fix includes.
2823         * cli/cli-interp.c: Fix includes.
2824
2825 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2826
2827         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2828         for padding.
2829
2830 2019-01-16  Tom Tromey  <tom@tromey.com>
2831
2832         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2833         earlier.
2834         (struct objfile) <msymbols_range>: Move from top level.
2835         <msymbols>: New method.
2836         (class objfile_msymbols): Remove.
2837         * symtab.c (default_collect_symbol_completion_matches_break_on):
2838         Update.
2839         * symmisc.c (dump_msymbols): Update.
2840         * stabsread.c (scan_file_globals): Update.
2841         * objc-lang.c (info_selectors_command, info_classes_command)
2842         (find_methods): Update.
2843         * minsyms.c (find_solib_trampoline_target): Update.
2844         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2845         * coffread.c (coff_symfile_read): Update.
2846         * ada-lang.c (ada_lookup_simple_minsym)
2847         (ada_collect_symbol_completion_matches): Update.
2848
2849 2019-01-16  Tom Tromey  <tom@tromey.com>
2850
2851         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2852         type.  Remove no-argument constructor.
2853         <iterator::operator++>: Simplify.
2854         <begin>: Update.
2855         <end>: Use minimal_symbol_count.
2856
2857 2019-01-16  Tom Tromey  <tom@tromey.com>
2858
2859         * objfiles.h (struct objfile) <psymtabs>: New method.
2860         (class objfile_psymtabs): Remove.
2861         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2862         typedef.
2863         <range>: New method.
2864         (require_partial_symbols): Change return type.
2865         * psymtab.c (require_partial_symbols)
2866         (psym_expand_symtabs_matching): Update.
2867         * mdebugread.c (parse_partial_symbols): Update.
2868         * dbxread.c (dbx_end_psymtab): Update.
2869
2870 2019-01-15  Tom Tromey  <tom@tromey.com>
2871
2872         * symtab.c (lookup_objfile_from_block)
2873         (lookup_symbol_in_objfile_symtabs)
2874         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2875         (find_line_symtab, info_sources_command)
2876         (default_collect_symbol_completion_matches_break_on)
2877         (make_source_files_completion_list): Update.
2878         * symmisc.c (print_objfile_statistics, dump_objfile)
2879         (maintenance_print_symbols, maintenance_info_symtabs)
2880         (maintenance_check_symtabs, maintenance_info_line_tables):
2881         Update.
2882         * source.c (select_source_symtab)
2883         (forget_cached_source_info_for_objfile): Update.
2884         * objfiles.h (class objfile_compunits): Remove.
2885         (struct objfile) <compunits_range>: New typedef.
2886         (compunits): New method.
2887         * objfiles.c (objfile_relocate1): Update.
2888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2889         * maint.c (count_symtabs_and_blocks): Update.
2890         * linespec.c (iterate_over_all_matching_symtabs): Update.
2891         * cp-support.c (add_symbol_overload_list_qualified): Update.
2892         * coffread.c (coff_symtab_read): Update.
2893         * ada-lang.c (add_nonlocal_symbols)
2894         (ada_collect_symbol_completion_matches)
2895         (ada_add_global_exceptions): Update.
2896
2897 2019-01-15  Tom Tromey  <tom@tromey.com>
2898
2899         * progspace.h (program_space) <objfiles_safe_range>: New
2900         typedef.
2901         <objfiles_safe>: New method.
2902         * objfiles.h (class all_objfiles_safe): Remove.
2903         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2904         * jit.c (jit_inferior_exit_hook): Update.
2905
2906 2019-01-17  Tom Tromey  <tom@tromey.com>
2907
2908         * progspace.h (program_space) <objfiles_range>: New typedef.
2909         <objfiles>: New method.
2910         <objfiles_head>: Rename from objfiles.
2911         (object_files): Update.
2912         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2913         * guile/scm-pretty-print.c
2914         (ppscm_find_pretty_printer_from_objfiles): Update.
2915         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2917         Update.
2918         * python/py-progspace.c (pspy_get_objfiles): Update.
2919         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2920         Update.
2921         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2922         (objfpy_lookup_objfile_by_build_id): Update.
2923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2924         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2925         Update.
2926         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2927         (expand_symtab_containing_pc, lookup_objfile_from_block)
2928         (lookup_static_symbol, basic_lookup_transparent_type)
2929         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2930         (find_line_symtab, info_sources_command)
2931         (default_collect_symbol_completion_matches_break_on)
2932         (make_source_files_completion_list, find_main_name): Update.
2933         * symmisc.c (print_symbol_bcache_statistics)
2934         (print_objfile_statistics, maintenance_print_symbols)
2935         (maintenance_print_msymbols, maintenance_print_objfiles)
2936         (maintenance_info_symtabs, maintenance_check_symtabs)
2937         (maintenance_expand_symtabs, maintenance_info_line_tables):
2938         Update.
2939         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2940         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2941         (map_overlay_command, unmap_overlay_command)
2942         (simple_overlay_update, expand_symtabs_matching)
2943         (map_symbol_filenames): Update.
2944         * symfile-debug.c (set_debug_symfile): Update.
2945         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2946         Update.
2947         * source.c (select_source_symtab, forget_cached_source_info):
2948         Update.
2949         * solib.c (solib_read_symbols): Update.
2950         * solib-spu.c (append_ocl_sos): Update.
2951         * psymtab.c (maintenance_print_psymbols)
2952         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2953         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2954         * printcmd.c (info_symbol_command): Update.
2955         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2956         Update.
2957         * objfiles.h (class all_objfiles): Remove.
2958         * objfiles.c (have_partial_symbols, have_full_symbols)
2959         (have_minimal_symbols, qsort_cmp, update_section_map)
2960         (shared_objfile_contains_address_p)
2961         (default_iterate_over_objfiles_in_search_order): Update.
2962         * objc-lang.c (info_selectors_command, info_classes_command)
2963         (find_methods): Update.
2964         * minsyms.c (find_solib_trampoline_target): Update.
2965         * maint.c (maintenance_info_sections)
2966         (maintenance_translate_address, count_symtabs_and_blocks):
2967         Update.
2968         * main.c (captured_main_1): Update.
2969         * linux-thread-db.c (try_thread_db_load_from_pdir)
2970         (has_libpthread): Update.
2971         * linespec.c (iterate_over_all_matching_symtabs)
2972         (search_minsyms_for_name): Update.
2973         * jit.c (jit_find_objf_with_entry_addr): Update.
2974         * hppa-tdep.c (find_unwind_entry)
2975         (hppa_lookup_stub_minimal_symbol): Update.
2976         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2977         Update.
2978         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2979         (elf_gnu_ifunc_resolve_by_got): Update.
2980         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2981         * dwarf-index-write.c (save_gdb_index_command): Update.
2982         * cp-support.c (add_symbol_overload_list_qualified): Update.
2983         * breakpoint.c (create_overlay_event_breakpoint)
2984         (create_longjmp_master_breakpoint)
2985         (create_std_terminate_master_breakpoint)
2986         (create_exception_master_breakpoint): Update.
2987         * blockframe.c (find_pc_partial_function): Update.
2988         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2989         (ada_collect_symbol_completion_matches)
2990         (ada_add_global_exceptions): Update.
2991
2992 2019-01-17  Tom Tromey  <tom@tromey.com>
2993
2994         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2995         declare VEC.
2996         (solib_target_parse_libraries): Change return type.
2997         (library_list_start_segment, library_list_start_section)
2998         (library_list_end_library, library_list_start_library); Update.
2999         (solib_target_free_library_list): Remove.
3000         (solib_target_parse_libraries): Remove cleanup.  Change return
3001         type.
3002         (solib_target_current_sos): Update.
3003
3004 2019-01-17  Tom Tromey  <tromey@bapiya>
3005
3006         * valprint.c: Replace "the the" with "the".
3007         * symtab.c: Replace "the the" with "the".
3008         * solib.c: Replace "the the" with "the".
3009         * solib-dsbt.c: Replace "the the" with "the".
3010         * linespec.c: Replace "the the" with "the".
3011         * dwarf2loc.h: Replace "the the" with "the".
3012         * amd64-windows-tdep.c: Replace "the the" with "the".
3013         * aarch64-tdep.c: Replace "the the" with "the".
3014
3015 2019-01-16  Keith Seitz  <keiths@redhat.com>
3016
3017         PR gdb/23773
3018         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3019         <builder>: Rename to ..
3020         <m_builder>: ... this and make private.
3021         (dwarf2_cu::get_builder): New method.  Change all users of
3022         `builder' to use this method.
3023         (dwarf2_start_symtab): Move to ...
3024         (dwarf2_cu::start_symtab): ... here.  Update all callers
3025         (setup_type_unit_groups): Move to ...
3026         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3027         callers.
3028         (dwarf2_cu::reset_builder): New method.
3029         (process_full_compunit, process_full_type_unit): Use
3030         dwarf2_cu::reset_builder.
3031         (follow_die_offset): Record the ancestor CU if it is different
3032         from the followed DIE's CU.
3033         (follow_die_sig_1): Likewise.
3034
3035 2019-01-15  Tom Tromey  <tom@tromey.com>
3036
3037         * remote.c (class remote_state) <buf>: Now a char_vector.
3038         <buf_size>: Remove.
3039         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3040         parameter.
3041         (remote_target::getpkt_or_notif_sane_1)
3042         (remote_target::getpkt_sane)
3043         (remote_target::getpkt_or_notif_sane): Likewise.
3044         (class remote_target) <putpkt>: New overload.
3045         (remote_target::read_frame): Change type of "buf_p".  Remove
3046         sizeof_p parameter.
3047         (packet_ok): New overload.
3048         (packet_check_result): New overload.
3049         Update all uses.
3050
3051 2019-01-14  Tom Tromey  <tom@tromey.com>
3052
3053         * remote-notif.c (handle_notification, remote_notif_ack)
3054         (remote_notif_parse): Make "buf" const.
3055         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3056         const.
3057         (remote_notif_parse, remote_notif_ack, handle_notification):
3058         Likewise.
3059         * remote.c (remote_notif_stop_parse): Make "buf" const.
3060         (remote_target::remote_parse_stop_reply): Make "buf" const.
3061         (remote_notif_stop_ack): Make "buf" const.
3062
3063 2019-01-14  Tom Tromey  <tom@tromey.com>
3064
3065         * remote.c (remote_console_output): Make parameter const.
3066
3067 2019-01-14  Tom Tromey  <tom@tromey.com>
3068
3069         * target-debug.h (target_debug_print_signals): Constify.
3070         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3071         * procfs.c (procfs_target::pass_signals): Update.
3072         * linux-nat.c (linux_nat_target::pass_signals): Update.
3073         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3074         * target-delegates.c: Rebuild.
3075         * remote.c (remote_target::program_signals): Update.
3076         (remote_target::pass_signals): Update.
3077         * target.c (target_pass_signals): Constify argument.
3078         (target_program_signals): Likewise.
3079         * target.h (struct target_ops) <pass_signals, program_signals>:
3080         Constify argument.
3081         (target_pass_signals, target_program_signals): Constify argument.
3082
3083 2019-01-14  Tom Tromey  <tom@tromey.com>
3084
3085         PR tui/28819:
3086         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3087
3088 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3089
3090         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3091         field.
3092         * rs6000-tdep.c: Include reggroups.h.
3093         (IS_V_ALIAS_PSEUDOREG): Define.
3094         (rs6000_register_name): Return names for the "vX" aliases.
3095         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3096         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3097         aliases.  Call default_register_reggroup_p for all other
3098         pseudo-registers.
3099         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3100         New functions.
3101         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3102         Handle "vX" aliases.
3103         (v_alias_pseudo_register_collect): New function.
3104         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3105         (rs6000_gdbarch_init): Initialize "vX" aliases as
3106         pseudo-registers.  Restore registration of
3107         rs6000_pseudo_register_reggroup_p with
3108         set_tdesc_pseudo_register_reggroup_p.
3109
3110 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3111
3112         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3113         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3114         set_gdbarch_num_pseudo_regs.
3115
3116 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3119         Remove arg prefixname, add do_set and do_show.
3120         Add member functions set_list and show_list.
3121         * cli/cli-style.c (class cli_style_option): Update accordingly.
3122         (style_set_list): Move to file scope.
3123         (style_show_list): Likewise.
3124         (set_style): Call help_list.
3125         (show_style): Call cmd_show_list.
3126         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3127         Update to use the new macro.
3128
3129 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3130
3131         * ada-lang.c (_initialize_ada_language): Expand the help text
3132         for the "catch exception" command.
3133
3134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3135
3136         * symtab.c (matching_obj_sections): Initialize obj,
3137         declare it closer to its usage.
3138
3139 2019-01-10  Tom Tromey  <tom@tromey.com>
3140
3141         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3142         (basic_inf_threads_range): Remove.
3143         (inf_threads_range, inf_non_exited_threads_range)
3144         (safe_inf_threads_range): Use next_adapter.
3145
3146 2019-01-10  Keith Seitz  <keiths@redhat.com>
3147
3148         PR gdb/23712
3149         PR symtab/23010
3150         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3151         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3152
3153 2019-01-10  Keith Seitz  <keiths@redhat.com>
3154
3155         PR gdb/23712
3156         PR symtab/23010
3157         * dictionary.c (pending_to_vector): Remove.
3158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3159         Remove _1 suffix, replacing functions of the same name.  Update
3160         all callers.
3161         (dict_create_hashed, dict_create_hashed_expandable)
3162         (dict_create_linear, dict_create_linear_expandable, dict_free)
3163         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3164         Make functions static.
3165
3166 2019-01-10  Keith Seitz  <keiths@redhat.com>
3167
3168         PR gdb/23712
3169         PR symtab/23010
3170         * dictionary.h (struct dictionary): Replace declaration with
3171         multidictionary.
3172         (dict_create_hashed, dict_create_hashed_expandable)
3173         (dict_create_linear, dict_create_linear_expandable)
3174         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3175         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3176         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3177         taking multidictionary argument.
3178         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3179         * block.h (struct block) <dict>: Change to multidictionary
3180         and rename `multidict'.
3181         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3182         symmisc.c: Update all dictionary references to multidictionary.
3183
3184 2019-01-10  Keith Seitz  <keiths@redhat.com>
3185
3186         PR gdb/23712
3187         PR symtab/23010
3188         * dictionary.c: Include unordered_map.
3189         (pending_to_vector): New function.
3190         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3191         Rewrite the non-"_1" functions to take vector instead
3192         of linked list.
3193         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3194         "new" _1 versions of the same name.
3195         (multidictionary): Define.
3196         (std::hash<enum language): New definition.
3197         (collate_pending_symbols_by_language, mdict_create_hashed)
3198         (mdict_create_hashed_expandable, mdict_create_linear)
3199         (mdict_create_linear_expandable, mdict_free)
3200         (find_language_dictionary, create_new_language_dictionary)
3201         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3202         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3203         (mdict_size, mdict_empty): New functions.
3204         * dictionary.h (mdict_iterator): Define.
3205
3206 2019-01-10  Pedro Alves  <palves@redhat.com>
3207
3208         * breakpoint.c (read_uploaded_action)
3209         (create_tracepoint_from_upload): Adjust to use
3210         gdb::unique_xmalloc_ptr.
3211         * ctf.c (ctf_write_uploaded_tp):
3212         (SET_ARRAY_FIELD): Use emplace_back.
3213         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3214         * tracefile-tfile.c (tfile_write_uploaded_tp):
3215         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3216         gdb::unique_xmalloc_ptr.
3217         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3218         at_string, cond_string, cmd_strings>: Replace char pointers
3219         with gdb::unique_xmalloc_ptr.
3220
3221 2019-01-10  Pedro Alves  <palves@redhat.com>
3222
3223         * solib-target.c (library_list_start_library): Don't xstrdup name.
3224
3225 2019-01-10  Pedro Alves  <palves@redhat.com>
3226
3227         * mdebugread.c (parse_partial_symbols): Use
3228         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3229
3230 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * linux-fork.c (scoped_switch_fork_info)
3233         <~scoped_switch_fork_info>: Fix incorrect variable name.
3234
3235 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * linux-fork.c (scoped_switch_fork_info)
3238         <scoped_switch_fork_info>: Make explicit.
3239         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3240
3241 2019-01-10  Tom Tromey  <tom@tromey.com>
3242
3243         * objfiles.h (objfile::reset_psymtabs): Update.
3244         * objfiles.c (objfile::objfile): Update.
3245         * psymtab.h (psymtab_storage::obstack): Update.
3246         (psymtab_storage::m_obstack): Use gdb::optional.
3247         (class psymtab_storage): Update comment.  Remove objfile
3248         parameter.
3249         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3250
3251 2019-01-10  Tom Tromey  <tom@tromey.com>
3252
3253         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3254         <free_psymtabs>: Now private.
3255         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3256         (allocate_psymtab): Use new method.
3257
3258 2019-01-10  Tom Tromey  <tom@tromey.com>
3259
3260         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3261         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3262         * mdebugread.c (parse_partial_symbols): Use
3263         allocate_dependencies.
3264         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3265         allocate_dependencies.
3266         (process_psymtab_comp_unit_reader)
3267         (build_type_psymtab_dependencies): Likewise.
3268         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3269
3270 2019-01-10  Tom Tromey  <tom@tromey.com>
3271
3272         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3273         PSYMBOL_SET_LANGUAGE.
3274         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3275
3276 2019-01-10  Tom Tromey  <tom@tromey.com>
3277
3278         * psymtab.h (psymtab_storage::obstack): New method.
3279         <m_obstack>: Rename from obstack; now private.
3280         * psymtab.c (psymtab_storage): Update.
3281         * dwarf2read.c (create_addrmap_from_index)
3282         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3283         Update.
3284
3285 2019-01-10  Tom Tromey  <tom@tromey.com>
3286
3287         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3288         * objfiles.h (objfile::reset_psymtabs): New method.
3289
3290 2019-01-10  Tom Tromey  <tom@tromey.com>
3291
3292         * symmisc.c (print_symbol_bcache_statistics): Update.
3293         (print_objfile_statistics): Update.
3294         * symfile.c (reread_symbols): Update.
3295         * psymtab.h (class psymtab_storage): New.
3296         * psymtab.c (psymtab_storage): New constructor.
3297         (~psymtab_storage): New destructor.
3298         (require_partial_symbols): Update.
3299         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3300         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3301         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3302         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3303         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3304         (start_psymtab_common, end_psymtab_common)
3305         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3306         (allocate_psymtab): Update.
3307         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3308         Update.
3309         (dump_psymtab_addrmap, maintenance_print_psymbols)
3310         (maintenance_check_psymtabs): Update.
3311         (class objfile_psymtabs): Move to objfiles.h.
3312         * psympriv.h (discard_psymtab): Now inline.
3313         (psymtab_discarder::psymtab_discarder): Update.
3314         (psymtab_discarder::~psymtab_discarder): Update.
3315         (ALL_OBJFILE_PSYMTABS): Rewrite.
3316         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3317         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3318         Remove fields.
3319         <partial_symtabs>: New field.
3320         (class objfile_psymtabs): Move from psymtab.h.  Update.
3321         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3322         psymbol_cache.
3323         (objfile::~objfile): Don't destroy psymbol_cache.
3324         * mdebugread.c (parse_partial_symbols): Update.
3325         * dwarf2read.c (create_addrmap_from_index)
3326         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3327         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3328         (add_partial_subprogram, dwarf2_ranges_read): Update.
3329         * dwarf-index-write.c (write_address_map)
3330         (write_one_signatured_type, recursively_write_psymbols)
3331         (class debug_names, class debug_names, write_psymtabs_to_index):
3332         Update.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * symtab.h (SYMBOL_SET_NAMES): Update.
3337         (symbol_set_names): Update.
3338         (MSYMBOL_SET_NAMES): Update.
3339         * symtab.c (symbol_set_names): Change argument to be an
3340         objfile_per_bfd_storage.
3341         * psymtab.c (add_psymbol_to_bcache): Update.
3342         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3343
3344 2019-01-10  Tom Tromey  <tom@tromey.com>
3345
3346         * symtab.c (create_demangled_names_hash): Change argument to be an
3347         objfile_per_bfd_storage.
3348         (symbol_set_names): Update.
3349
3350 2019-01-10  Tom Tromey  <tom@tromey.com>
3351
3352         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3353         init_psymbol_list.
3354         * psymtab.c (init_psymbol_list): Do nothing if already called.
3355         * psympriv.h (init_psymbol_list): Add comment.
3356         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3357         init_psymbol_list.
3358         * dbxread.c (dbx_symfile_read): Unconditionally call
3359         init_psymbol_list.
3360
3361 2019-01-10  Tom Tromey  <tom@tromey.com>
3362
3363         * xcoffread.c (scan_xcoff_symtab): Update.
3364         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3365         "where".
3366         * mdebugread.c (parse_partial_symbols)
3367         (handle_psymbol_enumerators): Update.
3368         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3369         * dbxread.c (read_dbx_symtab): Update.
3370         * psympriv.h (psymbol_placement): New enum.
3371         (add_psymbol_to_list): Update.
3372
3373 2019-01-10  Tom Tromey  <tom@tromey.com>
3374
3375         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3376         static_psymbols parameters.
3377         (scan_xcoff_symtab): Update.
3378         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3379         static_psymbols parameters.
3380         * psympriv.h (start_psymtab_common): Update.
3381         * mdebugread.c (parse_partial_symbols): Update.
3382         * dwarf2read.c (create_partial_symtab): Update.
3383         * dbxread.c (read_dbx_symtab): Update.
3384         (start_psymtab): Remove global_psymbols and static_psymbols
3385         parameters.
3386
3387 2019-01-10  Tom Tromey  <tom@tromey.com>
3388
3389         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3390         * psymtab.c (allocate_psymtab): Add comment.
3391         * psympriv.h (allocate_psymtab): Add comment.
3392         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3393         initializations.
3394         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3395
3396 2019-01-10  Tom Tromey  <tom@tromey.com>
3397
3398         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3399         Don't declare.
3400         * mipsread.c: Include mdebugread.h.
3401         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3402         Declare.
3403         * elfread.c: Include mdebugread.h.
3404
3405 2019-01-09  Tom Tromey  <tom@tromey.com>
3406
3407         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3408         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3409         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3410         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3411         (psym_lookup_symbol, psym_find_last_source_symtab)
3412         (psym_forget_cached_source_info, psym_print_stats)
3413         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3414         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3415         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3416         (psym_find_compunit_symtab_by_address)
3417         (maintenance_print_psymbols, maintenance_info_psymtabs)
3418         (maintenance_check_psymtabs): Use ranged for.
3419         * psymtab.h (class objfile_psymtabs): New.
3420         (require_partial_symbols): Return objfile_psymtabs.
3421         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3422
3423 2019-01-09  Tom Tromey  <tom@tromey.com>
3424
3425         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3426         (find_pc_mapped_section, list_overlays_command)
3427         (map_overlay_command, unmap_overlay_command)
3428         (simple_overlay_update): Use all_objfiles.
3429         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3430         * printcmd.c (info_symbol_command): Use all_objfiles.
3431         * objfiles.h (ALL_OBJSECTIONS): Remove.
3432         * maint.c (maintenance_translate_address): Use all_objfiles.
3433         * gcore.c (gcore_create_callback): Use all_objfiles.
3434         (objfile_find_memory_regions): Likewise.
3435
3436 2019-01-09  Tom Tromey  <tom@tromey.com>
3437
3438         * symtab.c (find_line_symtab, info_sources_command)
3439         (make_source_files_completion_list): Use objfile_compunits.
3440         * source.c (select_source_symtab): Use objfile_compunits.
3441         * objfiles.h (struct objfile): Update comment.
3442         (ALL_OBJFILES): Remove.
3443         (ALL_FILETABS): Remove.
3444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3445         objfile_compunits.
3446
3447 2019-01-09  Tom Tromey  <tom@tromey.com>
3448
3449         * symmisc.c (print_objfile_statistics, dump_objfile)
3450         (maintenance_print_symbols): Use compunit_filetabs.
3451         * source.c (forget_cached_source_info_for_objfile): Use
3452         compunit_filetabs.
3453         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3454         (ALL_FILETABS): Use compunit_filetabs.
3455         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3456         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3457
3458 2019-01-09  Tom Tromey  <tom@tromey.com>
3459
3460         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3461         (compunit_filetabs): New.
3462         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3463         compunit_filetabs.
3464         (info_sources_command, make_source_files_completion_list): Remove
3465         declaration.
3466         * symmisc.c (print_objfile_statistics, dump_objfile)
3467         (maintenance_print_symbols): Remove declaration.
3468         (maintenance_info_symtabs): Use compunit_filetabs.
3469         (maintenance_info_line_tables): Likewise.
3470         * source.c (select_source_symtab): Change local variable name.
3471         (forget_cached_source_info_for_objfile): Remove declaration.
3472         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3473         * objfiles.c (objfile_relocate1): Remove declaration.
3474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3475         declaration.
3476         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3477         * coffread.c (coff_symtab_read): Remove declaration.
3478         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3479         compunit_filetabs.
3480
3481 2019-01-09  Tom Tromey  <tom@tromey.com>
3482
3483         * symtab.c (lookup_objfile_from_block)
3484         (find_pc_sect_compunit_symtab, search_symbols)
3485         (default_collect_symbol_completion_matches_break_on): Use
3486         objfile_compunits.
3487         * objfiles.h (ALL_COMPUNITS): Remove.
3488         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3489         * cp-support.c (add_symbol_overload_list_qualified): Use
3490         objfile_compunits.
3491         * ada-lang.c (ada_collect_symbol_completion_matches)
3492         (ada_add_global_exceptions): Use objfile_compunits.
3493
3494 2019-01-09  Tom Tromey  <tom@tromey.com>
3495
3496         * source.c (select_source_symtab)
3497         (forget_cached_source_info_for_objfile): Remove declaration.
3498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3499         declaration.
3500         * maint.c (count_symtabs_and_blocks): Remove declaration.
3501         * cp-support.c (add_symbol_overload_list_qualified): Remove
3502         declaration.
3503         * coffread.c (coff_symtab_read): Remove declaration.
3504         * symtab.c (lookup_symbol_in_objfile_symtabs)
3505         (basic_lookup_transparent_type_1): Use objfile_compunits.
3506         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3507         (info_sources_command, search_symbols)
3508         (default_collect_symbol_completion_matches_break_on)
3509         (make_source_files_completion_list): Remove declaration.
3510         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3511         (ada_collect_symbol_completion_matches)
3512         (ada_add_global_exceptions): Remove declaration.
3513         * linespec.c (iterate_over_all_matching_symtabs): Use
3514         objfile_compunits.
3515         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3516         (class objfile_compunits): New.
3517         (ALL_COMPUNITS): Use objfile_compunits.
3518         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3519         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3520         objfile_compunits.
3521         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3522
3523 2019-01-09  Tom Tromey  <tom@tromey.com>
3524
3525         * symtab.c (search_symbols)
3526         (default_collect_symbol_completion_matches_break_on): Use
3527         objfile_msymbols.
3528         * ada-lang.c (ada_lookup_simple_minsym)
3529         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3530         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3531         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3532         objfile_msymbols.
3533         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3534         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3535         * objc-lang.c (find_methods): Use objfile_msymbols.
3536         (info_selectors_command, info_classes_command): Likewise.
3537         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3538         * objfiles.h (class objfile_msymbols): New.
3539         (ALL_OBJFILE_MSYMBOLS): Remove.
3540         (ALL_MSYMBOLS): Remove.
3541
3542 2019-01-09  Tom Tromey  <tom@tromey.com>
3543
3544         * common/next-iterator.h (next_adapter): Add Iterator template
3545         parameter.
3546         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3547         (class all_objfiles_safe): New.
3548         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3549         * objfiles.c (put_objfile_before): Update comment.
3550         (add_separate_debug_objfile): Likewise.
3551         (free_all_objfiles): Use all_objfiles_safe.
3552         (objfile_purge_solibs): Likewise.
3553
3554 2019-01-09  Tom Tromey  <tom@tromey.com>
3555
3556         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3557         (expand_symtab_containing_pc, lookup_static_symbol)
3558         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3559         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3560         all_objfiles.
3561         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3562         * breakpoint.c (create_overlay_event_breakpoint)
3563         (create_longjmp_master_breakpoint)
3564         (create_std_terminate_master_breakpoint)
3565         (create_exception_master_breakpoint): Use all_objfiles.
3566         * linux-thread-db.c (try_thread_db_load_from_pdir)
3567         (has_libpthread): Use all_objfiles.
3568         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3569         * linespec.c (iterate_over_all_matching_symtabs)
3570         (search_minsyms_for_name): Use all_objfiles.
3571         * maint.c (maintenance_info_sections): Use all_objfiles.
3572         * main.c (captured_main_1): Use all_objfiles.
3573         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3574         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3575         * guile/scm-pretty-print.c
3576         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3577         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3578         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3579         (maintenance_print_msymbols): Use all_objfiles.
3580         * source.c (select_source_symtab): Use all_objfiles.
3581         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3582         * symfile.c (remove_symbol_file_command)
3583         (expand_symtabs_matching, map_symbol_filenames): Use
3584         all_objfiles.
3585         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3586         all_objfiles.
3587         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3588         * objc-lang.c (find_methods): Use all_objfiles.
3589         * objfiles.c (have_partial_symbols, have_full_symbols)
3590         (have_minimal_symbols, qsort_cmp)
3591         (default_iterate_over_objfiles_in_search_order): Use
3592         all_objfiles.
3593         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3594         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3595         (maintenance_check_psymtabs): Use all_objfiles.
3596         (ALL_PSYMTABS): Remove.
3597         * compile/compile-object-run.c (do_module_cleanup): Use
3598         all_objfiles.
3599         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3600         * cp-support.c (add_symbol_overload_list_qualified): Use
3601         all_objfiles.
3602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3603         Use all_objfiles.
3604         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3606         all_objfiles.
3607         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3608         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3609         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3610         Uses all_objfiles.
3611         * solib.c (solib_read_symbols): Use all_objfiles
3612
3613 2019-01-09  Tom Tromey  <tom@tromey.com>
3614
3615         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3617         all_objfiles.
3618         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3619         * symmisc.c (print_symbol_bcache_statistics)
3620         (print_objfile_statistics, maintenance_print_objfiles)
3621         (maintenance_info_symtabs, maintenance_check_symtabs)
3622         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3623         all_objfiles.
3624         * source.c (forget_cached_source_info): Use all_objfiles.
3625         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3626         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3627         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3628         * objfiles.c (update_section_map): Use all_objfiles.
3629         (shared_objfile_contains_address_p): Likewise.
3630         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3631         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3632
3633 2019-01-09  Tom Tromey  <tom@tromey.com>
3634
3635         * common/next-iterator.h: New file.
3636         * objfiles.h (class all_objfiles): New.
3637         (struct objfile_iterator): New.
3638
3639 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3640
3641         * NEWS: Move the description of the changed "frame", "select-frame",
3642          and "info frame" commands to the Changed commands section.
3643
3644 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3645
3646         * gdbtypes.c (check_stub_method_group): Remove handling of old
3647         mangling schemes.
3648         * linespec.c (find_methods): Likewise.
3649         * stabsread.c (read_member_functions): Likewise.
3650         * valops.c (search_struct_method): Likewise.
3651         (value_struct_elt_for_reference): Likewise.
3652         * NEWS: Mention this change.
3653
3654 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3657         print_source_lines.
3658         * source.c (print_source_lines_base): Update line number check.
3659         (print_source_lines): New function.
3660         (source_lines_range::source_lines_range): New function.
3661         * source.h (class source_lines_range): New class.
3662         (print_source_lines): New declaration.
3663
3664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3665
3666         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3667
3668 2019-01-08  Tom Tromey  <tom@tromey.com>
3669             Simon Marchi  <simon.marchi@ericsson.com>
3670
3671         PR gdb/24060
3672         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3673         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3674         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3675         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3676         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3677         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3678
3679 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         * source.c (select_source_symtab): Move header comment to
3682         declaration in source.h.
3683         (forget_cached_source_info_for_objfile): Likewise.
3684         (forget_cached_source_info): Likewise.
3685         (identify_source_line): Likewise.
3686         * source.h (identify_source_line): Move declaration from symtab.h
3687         and add comment from source.c
3688         (print_source_lines): Likewise.
3689         (forget_cached_source_info_for_objfile): Likewise.
3690         (forget_cached_source_info): Likewise.
3691         (select_source_symtab): Likewise.
3692         (enum print_source_lines_flag): Move definition from symtab.h.
3693         * symtab.h (identify_source_line): Move declaration to source.h.
3694         (print_source_lines): Likewise.
3695         (forget_cached_source_info_for_objfile): Likewise.
3696         (forget_cached_source_info): Likewise.
3697         (select_source_symtab): Likewise.
3698         (enum print_source_lines_flag): Move definition to source.h.
3699         * tui/tui-hooks.c: Add 'source.h' include.
3700
3701 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * source.c (print_source_lines_base): Handle requests to print
3704         reverse line number sequences, and guard against empty lines
3705         string.
3706
3707 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * source.c (print_source_lines_base): Fix skip of '\r' if next
3710         character is '\n'.
3711
3712 2019-01-06  Tom Tromey  <tom@tromey.com>
3713
3714         * c-exp.y (struct c_parse_state) <macro_original_text,
3715         expansion_obstack>: New member.
3716         (macro_original_text, expansion_obstack): Remove globals.
3717         (scan_macro_expansion, scanning_macro_expansion)
3718         (finished_macro_expansion): Update.
3719         (scan_macro_cleanup): Remove.
3720         (yylex, c_parse): Update.
3721
3722 2019-01-06  Tom Tromey  <tom@tromey.com>
3723
3724         * c-exp.y (struct c_parse_state) <strings>: New member.
3725         (operator_stoken): Update.
3726
3727 2019-01-06  Tom Tromey  <tom@tromey.com>
3728
3729         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3730         (union type_stack_elt) <typelist_val>: Now a pointer to
3731         std::vector.
3732         (type_stack_cleanup): Don't declare.
3733         (push_typelist): Update.
3734         * parse.c (pop_typelist): Return a std::vector.
3735         (push_typelist): Take a std::vector.
3736         (follow_types): Update.  Do not free args.
3737         (type_stack_cleanup): Remove.
3738         * c-exp.y (struct c_parse_state): New.
3739         (cpstate): New global.
3740         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3741         (nonempty_typelist): Update.
3742         (func_mod): Create a new vector.
3743         (c_parse): Create a c_parse_state.
3744         (check_parameter_typelist): Do not delete params.
3745         (function_method): Update.  Do not delete type_list.
3746
3747 2019-01-06  Tom Tromey  <tom@tromey.com>
3748
3749         PR gdb/28155:
3750         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3751         check_typedef.
3752         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3753         (print_return_value): Likewise.
3754
3755 2019-01-05  Tom Tromey  <tom@tromey.com>
3756
3757         * contrib/cleanup_check.py: Remove.
3758         * contrib/gcc-with-excheck: Remove.
3759         * contrib/exsummary.py: Remove.
3760         * contrib/excheck.py: Remove.
3761
3762 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3763
3764         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3765         NULL. Initialize tpprev to NULL instead of assigning it
3766         to NULL on the next statement.
3767         * windows-nat.c (windows_delete_thread): Remove check for
3768         main_thread_id before printing thread exit notifications.
3769         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3770         Remove thread ID check against main_thread_id.
3771         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3772         windows_delete_thread.
3773         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3774
3775 2019-01-04  Tom Tromey  <tom@tromey.com>
3776
3777         * compile/compile.c (_initialize_compile): Use upper case for
3778         metasyntactic variables.
3779         * symmisc.c (_initialize_symmisc): Use upper case for
3780         metasyntactic variables.
3781         * psymtab.c (_initialize_psymtab): Use upper case for
3782         metasyntactic variables.
3783         * demangle.c (demangle_command): Use upper case for metasyntactic
3784         variables.
3785         (_initialize_demangler): Likewise.
3786         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3787         variables.
3788
3789 2019-01-03  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3792
3793 2019-01-03  Tom Tromey  <tom@tromey.com>
3794
3795         * python/py-symtab.c (salpy_str): Update.
3796         (struct salpy_sal_object) <symtab>: Now a PyObject.
3797         (salpy_dealloc): Update.
3798         (del_objfile_sal): Use gdbpy_ref.
3799
3800 2019-01-03  Tom Tromey  <tom@tromey.com>
3801
3802         * python/py-type.c (convert_field): Use new_reference.  Return
3803         gdbpy_ref.
3804         (make_fielditem): Return gdbpy_ref.
3805         (typy_fields): Update.
3806         (typy_getitem): Update.
3807         (field_name): Return gdbpy_ref.  Use new_reference.
3808         (typy_iterator_iternext): Update.
3809
3810 2019-01-03  Tom Tromey  <tom@tromey.com>
3811
3812         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3813
3814 2019-01-03  Tom Tromey  <tom@tromey.com>
3815
3816         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3817         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3818         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3819         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3820         (pspy_set_type_printers): Likewise.
3821         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3822         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3823         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3824         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3825         (objfpy_set_type_printers): Likewise.
3826
3827 2019-01-03  Tom Tromey  <tom@tromey.com>
3828
3829         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3830         (gdbpy_print_stack): Use gdbpy_err_fetch.
3831         * python/python-internal.h (class gdbpy_err_fetch): New class.
3832         (class gdbpy_enter) <m_error_type, m_error_value,
3833         m_error_traceback>: Remove.
3834         <m_error>: New member.
3835         (gdbpy_exception_to_string): Don't declare.
3836         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3837         * python/py-value.c (convert_value_from_python): Use
3838         gdbpy_err_fetch.
3839         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3840         gdbpy_exception_to_string.
3841         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3842         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3843         gdbpy_err_fetch.
3844
3845 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * linux-nat.c (delete_lwp_cleanup): Delete.
3848         (struct lwp_deleter): New struct.
3849         (lwp_info_up): New typedef.
3850         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3851         lwp_info_up.
3852
3853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * linux-fork.c (class scoped_switch_fork_info): New class.
3856         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3857
3858 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * valops.c (find_overload_match): Remove use of null_cleanup, and
3861         calls to do_cleanups.
3862
3863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         * compile/compile-cplus-types.c
3866         (compile_cplus_instance::decl_name): Handle changes to
3867         cp_func_name.
3868         * cp-support.c (cp_func_name): Update header comment, update
3869         return type.
3870         * cp-support.h (cp_func_name): Update return type in declaration.
3871         * valops.c (find_overload_match): Move temp_func local to top
3872         level of function and change its type.  Use temp_func to hold and
3873         delete temporary string obtained from cp_func_name.
3874
3875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3878         gdb::char_vector, remove cleanup, and update uses of `msg`.
3879
3880 2019-01-03  Jim Wilson  <jimw@sifive.com>
3881
3882         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3883
3884 2019-01-02  Tom Tromey  <tom@tromey.com>
3885
3886         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3887         (tdesc_parse_xml): Remove cleanups.
3888         * target-descriptions.h (make_cleanup_free_target_description):
3889         Don't declare.
3890         (target_desc_deleter): New struct.
3891         (target_desc_up): New typedef.
3892         * target-descriptions.c (target_desc_deleter::operator()): Rename
3893         from free_target_description.
3894         (make_cleanup_free_target_description): Remove.
3895
3896 2019-01-02  Tom Tromey  <tom@tromey.com>
3897
3898         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3899         constructor, destructor.
3900         (linespec_parser): Remove typedef.
3901         (~linespec_parser): Rename from linespec_parser_delete.
3902         (linespec_lex_to_end, linespec_complete_label)
3903         (linespec_complete): Update.
3904         (decode_line_full): Remove cleanups.
3905         (decode_line_1): Update.
3906
3907 2019-01-02  Tom Tromey  <tom@tromey.com>
3908
3909         * python/python-internal.h (inferior_to_inferior_object): Change
3910         return type.
3911         * python/py-exitedevent.c (create_exited_event_object): Update.
3912         * python/py-inferior.c (inferior_to_inferior_object): Return
3913         gdbpy_ref.
3914         (python_new_inferior, python_inferior_deleted)
3915         (thread_to_thread_object, delete_thread_object)
3916         (build_inferior_list, gdbpy_selected_inferior): Update.
3917         * python/py-infthread.c (create_thread_object): Update.  Also fail
3918         if inferior_to_inferior_object fails.
3919
3920 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3921
3922         * inferior.h (class inferior) <displaced_step_state>: New field.
3923         * infrun.h (struct displaced_step_state): Move here from
3924         infrun.c.  Initialize fields, add constructor.
3925         <inf>: Remove field.
3926         <reset>: New method.
3927         * infrun.c (struct displaced_step_inferior_state): Move to
3928         infrun.h.
3929         (displaced_step_inferior_states): Remove.
3930         (get_displaced_stepping_state): Adust.
3931         (displaced_step_in_progress_any_inferior): Adjust.
3932         (displaced_step_in_progress_thread): Adjust.
3933         (displaced_step_in_progress): Adjust.
3934         (add_displaced_stepping_state): Remove.
3935         (get_displaced_step_closure_by_addr): Adjust.
3936         (remove_displaced_stepping_state): Remove.
3937         (infrun_inferior_exit): Call displaced_step_state.reset.
3938         (use_displaced_stepping): Don't check for NULL.
3939         (displaced_step_prepare_throw): Call
3940         get_displaced_stepping_state.
3941         (displaced_step_fixup): Don't check for NULL.
3942         (prepare_for_detach): Don't check for NULL.
3943
3944 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3945
3946         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3947          in case of call that did not complete.
3948
3949 2019-01-02  Andrey Utkin  <autkin@undo.io>
3950
3951         * symfile.c (find_separate_debug_file): Fix search of debug files for
3952         remote debuggee.
3953
3954 2019-01-02  Tom Tromey  <tom@tromey.com>
3955
3956         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3957         indentation.
3958         * python/py-frame.c (frapy_older): Remove cast.
3959         (frapy_newer): Likewise.
3960         * python/py-breakpoint.c (local_setattro): Remove cast.
3961         * python/py-arch.c (archpy_name): Remove local variable.
3962         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3963
3964 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3965
3966         * unittests/basic_string_view/element_access/char/empty.cc:
3967         Fix year range in copyright header.
3968
3969 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3972         Delete.
3973         <operator==>: Update with for removed field.
3974         <hash>: Likewise.
3975         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3976         <isa_features>: ...this.
3977         <abi_features>: New field.
3978         (riscv_isa_flen): Update comment.
3979         (riscv_abi_xlen): New declaration.
3980         (riscv_abi_flen): New declaration.
3981         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3982         isa_features.
3983         (riscv_abi_xlen): New function.
3984         (riscv_isa_flen): Update to get answer from isa_features.
3985         (riscv_abi_flen): New function.
3986         (riscv_has_fp_abi): Update to get answer from abi_features.
3987         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3988         xlen and flen.
3989         (riscv_call_info) <xlen, flen>: Update comment.
3990         (riscv_call_arg_struct): Remove invalid assertions
3991         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3992         is removed.
3993         (riscv_gdbarch_init): Gather isa features and abi features
3994         separately, ensure both match on the gdbarch when reusing an old
3995         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3996         a target with 64-bit float hardware.
3997
3998 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999
4000         * source.c (search_command_helper): Stop reverse search
4001         when line 1 has been searched.
4002
4003 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4004
4005         * record-full.c (record_full_base_target::close): Rewrite
4006         record_full_core_buf_list free logic.
4007
4008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4009
4010         * break-catch-syscall.c (print_one_catch_syscall): xfree
4011         the last text.
4012
4013 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4014
4015         * top.c (print_gdb_version): Update Copyright year in version
4016         message.
4017
4018 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4019
4020         Update copyright year range in all GDB files.
4021
4022 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4023
4024         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4025
4026 For older changes see ChangeLog-2018.
4027 \f
4028 Local Variables:
4029 mode: change-log
4030 left-margin: 8
4031 fill-column: 74
4032 version-control: never
4033 coding: utf-8
4034 End:
4035