Display "main" on initial TUI startup
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui.c (tui_enable): Call tui_display_main.
4
5 2019-12-20 Tom Tromey <tom@tromey.com>
6
7 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
8 get_current_source_symtab_and_line, and main_name.
9
10 2019-12-20 Tom Tromey <tom@tromey.com>
11
12 * tui/tui.c (tui_show_source): Update.
13 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
14 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
15 a symtab_symbol_info, not a separate symtab and line. Simplify.
16
17 2019-12-20 Tom Tromey <tom@tromey.com>
18
19 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
20 Simplify.
21
22 2019-12-20 Tom Tromey <tom@tromey.com>
23
24 * tui/tui-winsource.h (struct tui_source_window_base)
25 <set_contents, update_source_window_as_is, update_source_window>:
26 Take a sal, not a separate symtab and tui_line_or_address.
27 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
28 (tui_source_window_base::update_source_window_as_is): Take a sal,
29 not a separate symtab and tui_line_or_address.
30 (tui_update_source_windows_with_addr)
31 (tui_update_source_windows_with_line)
32 (tui_source_window_base::rerender)
33 (tui_source_window_base::refill): Update.
34 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
35 a sal, not a separate symtab and tui_line_or_address.
36 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
37 not a separate symtab and tui_line_or_address.
38 (tui_source_window::maybe_update): Update.
39 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
40 a sal, not a separate symtab and tui_line_or_address.
41 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
42 not a separate symtab and tui_line_or_address.
43 (tui_disasm_window::do_scroll_vertical)
44 (tui_disasm_window::maybe_update): Update.
45
46 2019-12-20 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-winsource.c (tui_source_window_base::refill): Use
49 start_line_or_addr.
50 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
51 start_line_or_addr.
52 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
53 start_line_or_addr.
54
55 2019-12-20 Tom Tromey <tom@tromey.com>
56
57 * tui/tui-winsource.h (struct tui_source_window_base)
58 <set_contents>: Return bool.
59 * tui/tui-winsource.c
60 (tui_source_window_base::update_source_window_as_is): Update.
61 * tui/tui-source.h (struct tui_source_window) <set_contents>:
62 Return bool.
63 * tui/tui-source.c (tui_source_window::set_contents): Return
64 bool. Simplify.
65 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
66 Return bool.
67 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
68 bool.
69
70 2019-12-20 Tom Tromey <tom@tromey.com>
71
72 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
73 (tui_update_source_windows_with_line): Call update_source_window.
74 * tui/tui-source.h (struct tui_source_window)
75 <show_symtab_source>: Don't declare.
76 * tui/tui-source.c (tui_source_window::show_symtab_source):
77 Remove.
78
79 2019-12-20 Tom Tromey <tom@tromey.com>
80
81 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
82 update_source_window directly.
83 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
84 * tui/tui-disasm.c (tui_show_disassem): Remove.
85
86 2019-12-20 Tom Tromey <tom@tromey.com>
87
88 * tui/tui-winsource.c
89 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
90 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
91
92 2019-12-20 Tom Tromey <tom@tromey.com>
93
94 * tui/tui-winsource.h (struct tui_source_window_base)
95 <maybe_update>: Remove line_no and addr parameters.
96 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
97 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
98 Update.
99 * tui/tui-source.c (tui_source_window::maybe_update): Remove
100 line_no and addr parameters.
101 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
102 Update.
103 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
104 line_no and addr parameters.
105
106 2019-12-20 Tom Tromey <tom@tromey.com>
107
108 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
109 (tui_source_window_base::update_breakpoint_info): Remove asserts.
110
111 2019-12-20 Tom Tromey <tom@tromey.com>
112
113 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
114 tui_show_disassem.
115 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
116 declare.
117 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
118
119 2019-12-20 Tom Tromey <tom@tromey.com>
120
121 * tui/tui.h (tui_show_source): Remove parameters.
122 * tui/tui.c (tui_show_source): Remove parameters.
123 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
124
125 2019-12-20 Tom Tromey <tom@tromey.com>
126
127 * tui/tui.c (tui_show_source): Update.
128 * tui/tui-winsource.c (tui_display_main): Update.
129 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
130 to symtab.
131 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
132 to symtab.
133 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
134
135 2019-12-20 Tom Tromey <tom@tromey.com>
136
137 PR tui/23619:
138 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
139 (tui_redisplay_readline): Use rl_display_prompt.
140 (tui_prep_terminal): Update.
141
142 2019-12-19 Christian Biesinger <cbiesinger@google.com>
143
144 * configure: Regenerate.
145 * configure.ac: Quote variable arguments of test.
146 * gdbsupport/common.m4: Likewise.
147
148 2019-12-19 Christian Biesinger <cbiesinger@google.com>
149
150 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
151 2 to pow ().
152
153 2019-12-19 Christian Biesinger <cbiesinger@google.com>
154
155 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
156 log10 to double to fix Solaris 11 with gcc 5.5.
157
158 2019-12-19 Christian Biesinger <cbiesinger@google.com>
159
160 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
161 "sun" to "saddr_un".
162
163 2019-12-19 Tom Tromey <tromey@adacore.com>
164
165 * ui-out.h (enum class field_kind): Fix comment.
166
167 2019-12-11 Tom Tromey <tromey@adacore.com>
168
169 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
170
171 2019-12-18 Tom Tromey <tromey@adacore.com>
172
173 PR build/25268:
174 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
175 type on macOS. Add comment.
176
177 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
178
179 * c-lang.c (c_get_string, asm_language_defn): Remove space
180 before tab.
181
182 2019-12-18 Tom Tromey <tromey@adacore.com>
183
184 PR build/25250:
185 * ui-out.c (ui_out::vmessage): Update.
186 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
187 Rename.
188 (string_field): Update.
189 (signed_field): Update.
190
191 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
192
193 * top.c (print_gdb_configuration): Adjust indentation.
194
195 2019-12-17 Christian Biesinger <cbiesinger@google.com>
196
197 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
198
199 2019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
200
201 * tui/tui-layout.h (class tui_layout_base): Add virtual
202 destructor.
203
204 2019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
205
206 * infcmd.c (prepare_one_step): Step over skipped inline functions.
207 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
208 (process_event_stop_test): Keep stepping over skipped inline functions.
209
210 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
211
212 * jit.c (struct gdb_block) <next>: Remove field.
213 (struct gdb_symtab) <~gdb_symtab>: Remove.
214 <blocks>: Change type to std::forward_list<gdb_block>.
215 (compare_block): Remove.
216 (jit_block_open_impl): Adjust to std::forward_list. Place the new
217 block at the beginning, don't mind about sorting.
218 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
219 before using it.
220
221 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
222
223 * jit.c (struct gdb_block): Add constructor, initialize
224 real_block and next fields.
225 <name>: Change type to gdb::unique_xmalloc_ptr.
226 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
227 (jit_block_open_impl): Allocate gdb_block with new.
228 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
229
230 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
231
232 * jit.c: Include forward_list.
233 (struct gdb_symtab) <next>: Remove field.
234 (struct gdb_object) <symtabs>: Change type to
235 std::forward_list<gdb_symtab>.
236 (jit_object_open_impl): Allocate gdb_object with new.
237 (jit_symtab_open_impl): Adjust to std::forward_list.
238 (finalize_symtab): Don't delete symtab.
239 (jit_object_close_impl): Adjust to std::forward_list. Free
240 gdb_object with delete.
241
242 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
243
244 * jit.c (struct gdb_symtab): Add constructor, destructor,
245 initialize fields.
246 <linetable>: Change type to unique_xmalloc_ptr.
247 <file_name>: Change type to std::string.
248 (jit_symtab_open_impl): Allocate gdb_symtab with new.
249 (jit_symtab_line_mapping_add_impl): Adjust.
250 (finalize_symtab): Adjust, call delete on stab.
251
252 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
253
254 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
255
256 2019-12-16 Tom Tromey <tromey@adacore.com>
257
258 * windows-nat.c (windows_nat_target::attach): Update.
259 * remote.c (extended_remote_target::attach): Update.
260 * procfs.c (procfs_target::attach): Update.
261 * nto-procfs.c (nto_procfs_target::attach): Update.
262 (nto_procfs_target::create_inferior): Update.
263 * inf-ptrace.c (inf_ptrace_target::attach): Update.
264 * gnu-nat.c (gnu_nat_target::attach): Update.
265 (gnu_nat_target::detach): Update.
266 * darwin-nat.c (darwin_nat_target::attach): Update.
267 * corefile.c (get_exec_file): Constify result. Remove extraneous
268 return.
269 * bsd-kvm.c (bsd_kvm_target_open): Update.
270 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
271
272 2019-12-16 Christian Biesinger <cbiesinger@google.com>
273
274 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
275 (we no longer need to include time.h before pathmax.h)
276
277 2019-12-15 Christian Biesinger <cbiesinger@google.com>
278
279 * ada-exp.y (write_ambiguous_var): Update.
280 * coffread.c (process_coff_symbol): Update.
281 * ctfread.c (ctf_add_enum_member_cb): Update.
282 (new_symbol): Update.
283 * dwarf2read.c (fixup_go_packaging): Update.
284 (new_symbol): Update.
285 * language.c (language_alloc_type_symbol): Update.
286 * mdebugread.c (new_symbol): Update.
287 * minsyms.c (minimal_symbol_reader::record_full): Update.
288 * psymtab.c (add_psymbol_to_bcache): Update.
289 * stabsread.c (define_symbol): Update.
290 (read_enum_type): Update.
291 * symtab.c (symbol_set_language): Make this a member function...
292 (general_symbol_info::set_language): ... here.
293 * symtab.h (struct general_symbol_info) <set_language>: New function.
294 (SYMBOL_SET_LANGUAGE): Remove.
295 (symbol_set_language): Remove.
296
297 2019-12-15 Christian Biesinger <cbiesinger@google.com>
298
299 * ada-lang.c (ada_add_block_symbols): Update.
300 (ada_collect_symbol_completion_matches): Update.
301 * ax-gdb.c (gen_expr): Update.
302 * block.c (block_lookup_symbol): Update.
303 (block_lookup_symbol_primary): Update.
304 (block_find_symbol): Update.
305 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
306 * dbxread.c (process_one_symbol): Update.
307 * dictionary.c (insert_symbol_hashed): Update.
308 (collate_pending_symbols_by_language): Update.
309 (mdict_add_symbol): Update.
310 * dwarf-index-write.c (write_psymbols): Update.
311 * dwarf2read.c (fixup_go_packaging): Update.
312 * findvar.c (read_var_value): Update.
313 * ft32-tdep.c (ft32_skip_prologue): Update.
314 * go-lang.c (go_symbol_package_name): Update.
315 * language.h (scoped_switch_to_sym_language_if_auto::
316 scoped_switch_to_sym_language_if_auto): Update.
317 * linespec.c (find_method): Update.
318 (find_label_symbols_in_block): Update.
319 * mdebugread.c (parse_symbol): Update.
320 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
321 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
322 (minimal_symbol_reader::install): Update.
323 * moxie-tdep.c (moxie_skip_prologue): Update.
324 * parse.c (parse_exp_in_context): Update.
325 * psymtab.c (psymbol_name_matches): Update.
326 (match_partial_symbol): Update.
327 (lookup_partial_symbol): Update.
328 (psymbol_hash): Update.
329 (psymbol_compare): Update.
330 * python/py-framefilter.c (extract_sym): Update.
331 (py_print_single_arg): Update.
332 * stabsread.c (define_symbol): Update.
333 * stack.c (print_frame_arg): Update.
334 (find_frame_funname): Update.
335 (info_frame_command_core): Update.
336 * symfile.c (set_initial_language): Update.
337 * symtab.c (symbol_set_demangled_name): Update.
338 (symbol_get_demangled_name): Update.
339 (symbol_set_language): Update.
340 (symbol_find_demangled_name): Update.
341 (symbol_set_names): Update.
342 (general_symbol_info::natural_name): Update.
343 (general_symbol_info::demangled_name): Update.
344 (general_symbol_info::search_name): Update.
345 (symbol_matches_search_name): Update.
346 (eq_symbol_entry): Update.
347 (iterate_over_symbols): Update.
348 (completion_list_add_symbol): Update.
349 (completion_list_add_msymbol): Update.
350 (completion_list_add_fields): Update.
351 * symtab.h (struct general_symbol_info) <language>: New function.
352 <language>: Rename to...
353 <m_language>: ...this.
354 (SYMBOL_LANGUAGE): Remove.
355 (MSYMBOL_LANGUAGE): Remove.
356 (struct symbol) <ctor>: Update.
357 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
358
359 2019-12-15 Christian Biesinger <cbiesinger@google.com>
360
361 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
362 set the language of sym.
363 * language.c (language_alloc_type_symbol): Likewise.
364
365 2019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
366
367 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
368 PR gdb/23613
369 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
370 * corelow.c: Include 'gdbsupport/pathstuff.h'.
371 (core_target_open): Use 'gdb_abspath'.
372 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
373 'current_directory == NULL' case.
374 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
375 explain what happens when 'current_directory' is NULL.
376 * go32-nat.c (go32_nat_target::wait): Check if
377 'current_directory' is NULL before call to 'chdir'.
378 * source.c (add_path): Use 'gdb_abspath'.
379 * top.c: Include 'gdbsupport/pathstuff.h'.
380 (init_history): Use 'gdb_abspath'.
381 (set_history_filename): Likewise.
382 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
383 (tfile_target_open): Use 'gdb_abspath'.
384
385 2019-12-13 Tom Tromey <tromey@adacore.com>
386
387 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
388 warning or error.
389
390 2019-12-13 Tom Tromey <tromey@adacore.com>
391
392 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
393
394 2019-12-13 Tom Tromey <tromey@adacore.com>
395
396 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
397
398 2019-12-13 Tom Tromey <tromey@adacore.com>
399
400 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
401
402 2019-12-13 Tom Tromey <tromey@adacore.com>
403
404 * gdbsupport/common-utils.c (string_printf, string_vprintf)
405 (string_vappendf): Add ARI comment.
406
407 2019-12-13 Tom Tromey <tromey@adacore.com>
408
409 * contrib/ari/gdb_ari.sh: Remove "fix" call for
410 floatformat_to_double.
411 * target-float.c (host_float_ops<T>::from_target): Add ARI
412 comment.
413
414 2019-12-13 Tom Tromey <tromey@adacore.com>
415
416 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
417 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
418 ARI marker to abort.
419 * event-top.c (handle_sigsegv): Add ARI marker to abort.
420
421 2019-12-13 Tom Tromey <tromey@adacore.com>
422
423 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
424
425 2019-12-13 Tom Tromey <tromey@adacore.com>
426
427 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
428
429 2019-12-13 Tom Tromey <tromey@adacore.com>
430
431 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
432 checks.
433
434 2019-12-13 Tom Tromey <tromey@adacore.com>
435
436 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
437 end>: No longer "const".
438
439 2019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
440
441 * jit.c: Fix indentation, replace spaces with tabs where
442 applicable.
443
444 2019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
445
446 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
447
448 2019-12-12 Tom Tromey <tom@tromey.com>
449
450 * objfiles.h (struct objfile) <partial_symtabs>: Now a
451 unique_ptr.
452
453 2019-12-12 Tom Tromey <tom@tromey.com>
454
455 * progspace.h (objfile_list): New typedef.
456 (class unwrapping_objfile_iterator)
457 (struct unwrapping_objfile_range): Newl
458 (struct program_space) <objfiles_range>: Change type.
459 <objfiles>: Change return type.
460 <add_objfile>: Change type of "objfile" parameter.
461 <objfiles_list>: Now a list of shared_ptr.
462 * progspace.c (program_space::add_objfile): Change type of
463 "objfile". Update.
464 (program_space::remove_objfile): Update.
465 * objfiles.h (struct objfile) <~objfile>: Make public.
466 * objfiles.c (objfile::make): Update.
467 (objfile::unlink): Don't call delete.
468
469 2019-12-12 Tom Tromey <tom@tromey.com>
470
471 * symfile.c (symbol_file_clear): Update.
472 * progspace.h (struct program_space) <free_all_objfiles>: Declare
473 method.
474 * progspace.c (program_space::free_all_objfiles): New method.
475 * objfiles.h (free_all_objfiles): Don't declare.
476 * objfiles.c (free_all_objfiles): Move to program_space.
477
478 2019-12-12 Tom Tromey <tom@tromey.com>
479
480 * progspace.c (program_space::add_objfile)
481 (program_space::remove_objfile): Update.
482 (program_space::multi_objfile_p): Remove.
483 * objfiles.h (struct objfile) <next>: Remove.
484 * objfiles.c (objfile::objfile): Update.
485 (put_objfile_before): Update.
486 (unlink_objfile): Update.
487 * progspace.h (object_files): Remove.
488 (struct program_space) <objfiles_head>: Remove.
489 <objfiles_list>: New member.
490 <objfiles_range, objfiles_safe_range>: Change type.
491 (objfiles): Change return type.
492 (objfiles_safe): Update.
493 (multi_objfile_p): Rewrite and inline.
494 (object_files): Remove macro.
495
496 2019-12-12 Tom Tromey <tom@tromey.com>
497
498 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
499 second constructor.
500 (basic_safe_range): New class.
501
502 2019-12-12 Tom Tromey <tom@tromey.com>
503
504 * progspace.c (program_space::multi_objfile_p): New method.
505 * printcmd.c (info_symbol_command): Update.
506 * maint.c (maintenance_translate_address): Update.
507 * objfiles.h (MULTI_OBJFILE_P): Remove.
508 * progspace.h (struct program_space) <multi_objfile_p>: New
509 method.
510
511 2019-12-12 Tom Tromey <tom@tromey.com>
512
513 * progspace.h (struct program_space) <remove_objfile>: Declare.
514 * progspace.c (program_space::remove_objfile): New method.
515 * objfiles.c (unlink_objfile): Remove.
516 (objfile::unlink): Call remove_objfile.
517 (objfile): Don't call unlink_objfile.
518
519 2019-12-12 Tom Tromey <tom@tromey.com>
520
521 * progspace.h (struct program_space) <add_objfile>: Declare
522 method.
523 * progspace.c (program_space::add_objfile): New method.
524 * objfiles.c (~objfile): Don't unlink objfile.
525 (put_objfile_before): Remove.
526 (add_separate_debug_objfile): Don't call put_objfile_before.
527 (objfile::make): Call add_objfile. Set new_objfiles_available on
528 the per-program-space data.
529
530 2019-12-12 Tom Tromey <tom@tromey.com>
531
532 * symfile.c (syms_from_objfile_1): Use objfile_up.
533 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
534 method.
535 (reread_symbols): Use objfile_up.
536 * solib.c (update_solib_list, reload_shared_libraries_1): Call
537 unlink method.
538 * objfiles.h (struct objfile) <~objfile>: Now private.
539 <unlink>: New method.
540 (struct objfile_deleter): New.
541 (objfile_up): New typedef.
542 * objfiles.c (objfile::unlink): New method.
543 (free_objfile_separate_debug, free_all_objfiles)
544 (objfile_purge_solibs): Use it.
545 * jit.c (jit_unregister_code): Remove.
546 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
547 objfile.
548 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
549 objfile.
550 * compile/compile-object-load.c (compile_object_load): Use
551 objfile_up.
552
553 2019-12-12 Tom Tromey <tom@tromey.com>
554
555 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
556 objfile::make.
557 * objfiles.h (struct objjfile) <make>: No longer inline.
558 (add_separate_debug_objfile): Don't declare.
559 * objfiles.c (add_separate_debug_objfile): Now static.
560 (objfile::make): Move from objfiles.h. Call
561 add_separate_debug_objfile. Add "parent" parameter.
562
563 2019-12-12 Tom Tromey <tom@tromey.com>
564
565 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
566 * objfiles.h (struct objfile): Make constructor private.
567 <make>: New static method.
568 * jit.c (jit_object_close_impl): Update.
569
570 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
571
572 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
573 gdb::byte_vector.
574
575 2019-12-12 Tom Tromey <tromey@adacore.com>
576
577 * xml-support.c (xml_fetch_content_from_file): Don't call
578 malloc_failure.
579 * utils.h (class gdb_argv): Remove malloc_failure comment.
580 * utils.c (gdb_argv::reset): Don't call malloc_failure.
581
582 2019-12-12 Tom Tromey <tromey@adacore.com>
583
584 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
585 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
586 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
587 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
588 * riscv-ravenscar-thread.c: New file.
589 * riscv-ravenscar-thread.h: New file.
590 * riscv-tdep.c (riscv_gdbarch_init): Call
591 register_riscv_ravenscar_ops.
592
593 2019-12-12 Tom Tromey <tromey@adacore.com>
594
595 * gdbsupport/thread-pool.c (set_thread_name): Use
596 ATTRIBUTE_UNUSED.
597
598 2019-12-12 Luis Machado <luis.machado@linaro.org>
599
600 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
601 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
602 macros.
603
604 2019-12-11 Tom Tromey <tom@tromey.com>
605
606 * tui/tui-win.c (tui_set_win_height_command): Call
607 tui_adjust_window_height.
608 (tui_adjust_win_heights, new_height_ok): Remove.
609 * tui/tui-layout.h (tui_adjust_window_height): Declare.
610 * tui/tui-layout.c (tui_adjust_window_height): New function.
611
612 2019-12-11 Tom Tromey <tom@tromey.com>
613
614 * tui/tui-win.c (tui_resize_all): Remove code, call
615 tui_apply_current_layout.
616
617 2019-12-11 Tom Tromey <tom@tromey.com>
618
619 * tui/tui-layout.h (tui_apply_current_layout): Declare.
620 * tui/tui-layout.c (standard_layouts, applied_layout): New
621 globals.
622 (tui_apply_current_layout): New function.
623 (show_layout): Set applied_layout. Call
624 tui_apply_current_layout.
625 (show_source_command, show_disasm_command)
626 (show_source_disasm_command, show_data)
627 (show_source_or_disasm_and_command): Remove.
628 (initialize_layouts): New function.
629 (_initialize_tui_layout): Call initialize_layouts.
630
631 2019-12-11 Tom Tromey <tom@tromey.com>
632
633 * tui/tui-layout.h (class tui_layout_base)
634 (class tui_layout_window, class tui_layout_split): New.
635 * tui/tui-layout.c (tui_get_window_by_name)
636 (tui_layout_window::clone, tui_layout_window::apply)
637 (tui_layout_window::get_sizes, tui_layout_window::add_split)
638 (tui_layout_split::add_window, tui_layout_split::clone)
639 (tui_layout_split::get_sizes)
640 (tui_layout_split::set_weights_from_heights)
641 (tui_layout_split::adjust_size, tui_layout_split::apply): New
642 functions.
643 (tui_layout_split::add_split, tui_layout_split::add_split)
644 (tui_layout_split::set_weights_from_heights)
645 (tui_layout_split::set_weights_from_heights): New functions.
646
647 2019-12-11 Tom Tromey <tom@tromey.com>
648
649 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
650 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
651 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
652 * tui/tui-data.h (struct tui_point): Remove.
653 (struct tui_gen_win_info) <origin>: Remove.
654 <x, y>: New fields.
655 * tui/tui-command.c (tui_cmd_window::resize): Update.
656
657 2019-12-11 Tom Tromey <tom@tromey.com>
658
659 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
660 Implement.
661 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
662 Implement.
663 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
664 method.
665 (struct tui_win_info) <min_height>: Implement.
666
667 2019-12-11 Tom Tromey <tom@tromey.com>
668
669 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
670 (struct tui_win_info) <can_box>: Update.
671
672 2019-12-11 Tom Tromey <tom@tromey.com>
673
674 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
675 method.
676 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
677 method.
678 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
679 method.
680 (struct tui_win_info) <max_height>: Now override.
681
682 2019-12-11 Joel Brobecker <brobecker@adacore.com>
683
684 * NEWS: Create a new section for the next release branch.
685 Rename the section of the current branch, now that it has
686 been cut.
687
688 2019-12-11 Joel Brobecker <brobecker@adacore.com>
689
690 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
691 * version.in: Bump version to 10.0.50.DATE-git.
692
693 2019-12-11 Tom Tromey <tromey@adacore.com>
694
695 PR build/25268:
696 * gdbsupport/thread-pool.c (set_thread_name): New function.
697 (thread_pool::set_thread_count): Don't call pthread_setname_np.
698 (thread_pool::thread_function): Call set_thread_name.
699
700 2019-12-11 Tom Tromey <tromey@adacore.com>
701
702 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
703 bfd_get_signed_8.
704
705 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
706
707 * NEWS: Document -raw-values option and the related setting commands.
708 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
709 only set it on when /r is given.
710 * valprint.c (value_print_option_defs): New element raw-values.
711 * Makefile.in: Add the new file.
712
713 2019-12-10 Christian Biesinger <cbiesinger@google.com>
714
715 * gdbsupport/safe-strerror.c: Supress the unused function warning
716 for select_strerror_r.
717
718 2019-12-10 Christian Biesinger <cbiesinger@google.com>
719
720 * config.in: Regenerate.
721 * configure: Regenerate.
722 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
723 safe_strerror instead of strerror.
724 * gdbsupport/common.m4: Don't check for strerror.
725 * gdbsupport/safe-strerror.c: Support both the glibc version
726 of strerror_r and the XSI version.
727
728 2019-12-10 Tom Tromey <tromey@adacore.com>
729
730 * ada-typeprint.c (print_choices): Use a single "?".
731 (print_variant_part): Print "?" if the discriminant name
732 is not known.
733
734 2019-12-10 George Barrett <bob@bob131.so>
735
736 Fix scripted probe breakpoints.
737 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
738 declaration forward.
739 (breakpoint_ops_for_event_location_type)
740 (breakpoint_ops_for_event_location): Add function definitions.
741 (break_command_1, trace_command): Use
742 breakpoint_ops_for_event_location.
743 * breakpoint.h (breakpoint_ops_for_event_location): Add function
744 declarations.
745 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
746 breakpoint_ops_for_event_location.
747 * python/py-breakpoint.c (bppy_init): Use
748 breakpoint_ops_for_event_location.
749
750 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
751
752 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
753 when ranking an lvalue argument for an rvalue parameter.
754
755 2019-12-08 Wataru Ashihara <wataash@wataash.com>
756
757 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
758 template argument for scoped_restore_tmpl from bool to int.
759
760 2019-12-07 Keith Seitz <keiths@redhat.com>
761
762 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
763 (build_id_to_debug_bfd): Make static, rewriting to use
764 build_id_to_bfd_suffix.
765 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
766 adding `suffix' parameter. Append SUFFIX to file names
767 when searching for matching files.
768 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
769 (build_id_to_exec_bfd): Likewise.
770 * build-id.h (build_id_to_debug_bfd): Clarify that function
771 searches for BFD of debug info file.
772 (build_id_to_exec_bfd): Declare.
773 * corelow.c: Include build-id.h.
774 (locate_exec_from_corefile_build_id): New function.
775 (core_target_open): If no executable BFD is found,
776 search for a core file BFD using build-id.
777
778 2019-12-06 Christian Biesinger <cbiesinger@google.com>
779
780 * bcache.c: Put in namespace gdb.
781 * bcache.h: Likewise.
782 * gdbtypes.c (check_types_worklist): Update.
783 (types_deeply_equal): Update.
784 * macrotab.c (struct macro_table) <bcache>: Update.
785 (new_macro_table): Update.
786 * macrotab.h (struct bcache): Put this forward declaration
787 inside namespace gdb.
788 (new_macro_table): Update.
789 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
790 Update.
791 <macro_cache>: Update.
792 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
793
794 2019-12-06 Tom de Vries <tdevries@suse.de>
795
796 PR symtab/24971
797 * block.c (best_symbol, better_symbol): New function.
798 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
799 decl.
800
801 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
802
803 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
804 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
805 for ranking see-through reference cases.
806
807 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
808 * stack.c (faas_command): Check a command is provided.
809 * thread.c (taas_command, tfaas_command): Likewise.
810
811 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
812 * inferior.c (prune_inferiors): Only call delete_inferior,
813 Do not modify the inferior list.
814
815 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
816
817 * c-exp.y: Update calls to lookup_typename,
818 lookup_signed_typename and lookup_unsigned_typename.
819 * c-lang.c (evaluate_subexp_c): Likewise.
820 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
821 Likewise.
822 * eval.c (binop_promote): Likewise.
823 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
824 (lookup_unsigned_typename): Likewise.
825 (lookup_signed_typename): Likewise.
826 * gdbtypes.h (lookup_unsigned_typename): Likewise.
827 (lookup_signed_typename): Likewise.
828 (lookup_typename): Likewise.
829 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
830 lookup_typename, lookup_signed_typename,
831 lookup_unsigned_typename.
832 * m2-exp.y: Likewise.
833 * printcmd.c (printf_wide_c_string): Likewise.
834 (ui_printf): Likewise.
835 * python/py-type.c (typy_lookup_typename): Likewise.
836 * python/py-xmethods.c (python_xmethod_worker::invoke):
837 Likewise.
838 * rust-exp.y: Likewise.
839
840 2019-12-04 Christian Biesinger <cbiesinger@google.com>
841
842 * configure.nat (obsd64): Add missing files x86-nat.o and
843 nat/x86-dregs.o.
844
845 2019-12-04 Tom Tromey <tom@tromey.com>
846
847 * valprint.c (val_print_string): Use metadata_style.
848 * go-valprint.c (print_go_string): Use metadata style.
849 * p-valprint.c (pascal_object_print_static_field): Use metadata
850 style.
851 * cp-valprint.c (cp_print_static_field): Use metadata style.
852
853 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
854 Chris January <chris.january@arm.com>
855
856 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
857 tokens.
858 (typebase): New patterns for complex, single/double precision, and
859 single/double complex.
860 (f77_keywords): Change token for complex keyword, and add single,
861 double, and precision keywords.
862
863 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
864
865 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
866 "info io_registers".
867
868 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
869
870 * regcache.c (cooked_read_test): Initialize thread list of
871 mock_inferior.
872
873 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
874
875 * aarch64-linux-tdep.c: Remove includes.
876
877 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
878
879 * aarch64-tdep.c: Remove includes.
880
881 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
882
883 * filtered-iterator.h (filtered_iterator) <operator==,
884 operator!=>: Compare wrapped iterators, not wrapped pointers.
885 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
886 unittests/filtered_iterator-selftests.c.
887 * unittests/filtered_iterator-selftests.c: New file.
888
889 2019-12-04 Tom Tromey <tromey@adacore.com>
890
891 * gdbtypes.c (create_range_type): Inherit endianity
892 from base type.
893
894 2019-12-04 Tom Tromey <tromey@adacore.com>
895
896 * ada-lang.c (decode_constrained_packed_array)
897 (ada_value_assign, value_assign_to_component): Update.
898 * dwarf2loc.c (rw_pieced_value, access_memory)
899 (dwarf2_compile_expr_to_ax): Update.
900 * dwarf2read.c (dwarf2_add_field): Update.
901 * eval.c (evaluate_subexp_standard): Update.
902 * gdbarch.c, gdbarch.h: Rebuild.
903 * gdbarch.sh (bits_big_endian): Remove.
904 * gdbtypes.h (union field_location): Update comment.
905 * target-descriptions.c (make_gdb_type): Update.
906 * valarith.c (value_bit_index): Update.
907 * value.c (struct value) <bitpos>: Update comment.
908 (unpack_bits_as_long, modify_field): Update.
909 * value.h (value_bitpos): Update comment.
910
911 2019-12-04 Tom Tromey <tromey@adacore.com>
912
913 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
914 endian-ness.
915
916 2019-12-04 Tom Tromey <tromey@adacore.com>
917
918 * dwarf2read.c (dwarf2_init_float_type)
919 (dwarf2_init_complex_target_type): Add byte_order parameter.
920 (read_base_type): Compute byte order earlier.
921 * gdbtypes.c (init_float_type): Add byte_order parameter.
922 * gdbtypes.h (init_float_type): Add byte_order parameter.
923
924 2019-12-04 Tom Tromey <tromey@adacore.com>
925
926 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
927
928 2019-12-04 Tom Tromey <tromey@adacore.com>
929
930 * dwarf2read.c (process_structure_scope): Initialize
931 "discr_offset".
932
933 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
934
935 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
936 add it into the search spec.
937 (parse_max_results_option): New function.
938 (mi_info_functions_or_variables): Parse -max-results flag and pass
939 it to mi_symbol_info.
940 (mi_cmd_symbol_info_modules): Likewise.
941 (mi_cmd_symbol_info_types): Likewise.
942 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
943 return type to bool, change result container into a set, and don't
944 add new results if we have enough already.
945 (global_symbol_searcher::add_matching_msymbols): Change return
946 type to bool, and don't add new results if we have enough already.
947 (sort_search_symbols_remove_dups): Delete.
948 (global_symbol_searcher::search): Early exit from search loop when
949 we have enough results. Use a std::set to collect the results
950 from calling add_matching_symbols.
951 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
952 member function.
953 (global_symbol_searcher) <m_max_search_results>: New member
954 variable.
955 (global_symbol_searcher) <add_matching_symbols>: Update header
956 comment and change return type to bool.
957 (global_symbol_searcher) <add_matching_msymbols>: Update header
958 comment and change return type to bool.
959
960 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
961
962 * symtab.c (symbol_search::compare_search_syms): Update header
963 comment.
964 (global_symbol_searcher::is_suitable_msymbol): New function.
965 (global_symbol_searcher::expand_symtabs): New function.
966 (global_symbol_searcher::add_matching_symbols): New function.
967 (global_symbol_searcher::add_matching_msymbols): New function.
968 (global_symbol_searcher::search): Move most of the content
969 into the new functions above, and call them as needed.
970 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
971 function.
972 (global_symbol_searcher) <add_matching_symbols>: New member
973 function.
974 (global_symbol_searcher) <add_matching_msymbols>: New member
975 function.
976 (global_symbol_searcher) <is_suitable_msymbol>: New member
977 function.
978
979 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
980
981 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
982 -symbol-info-module-variables entries.
983 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
984 (mi_cmd_symbol_info_module_variables): Declare.
985 * mi/mi-symbol-cmds.c
986 (module_symbol_search_iterator): New typedef.
987 (output_module_symbols_in_single_module_and_file): New function.
988 (output_module_symbols_in_single_module): New function.
989 (mi_info_module_functions_or_variables): New function.
990 (mi_cmd_symbol_info_module_functions): New function.
991 (mi_cmd_symbol_info_module_variables): New function.
992 * NEWS: Mention new MI command.
993
994 2019-12-03 Christian Biesinger <cbiesinger@google.com>
995
996 * bcache.c (hash): Remove.
997 (hash_continue): Remove.
998 * bcache.h (hash): Remove.
999 (hash_continue): Remove.
1000 (struct bcache) <ctor>: Update.
1001 * psymtab.c (psymbol_hash): Update.
1002 * stabsread.c (hashname): Update.
1003 * utils.h (fast_hash): Add an argument for a start value,
1004 defaulting to zero.
1005
1006 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1007 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1008 (destroy_block_symbol_cache): New function.
1009 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1010 (resize_symbol_cache): Likewise.
1011
1012 2019-12-02 Tom Tromey <tom@tromey.com>
1013
1014 * unittests/tui-selftests.c (run_tests): Make conditional.
1015 (_initialize_tui_selftest): Make conditional.
1016
1017 2019-12-02 Christian Biesinger <cbiesinger@google.com>
1018
1019 * aix-thread.c (debug_aix_thread): Change type to bool.
1020
1021 2019-12-02 Luis Machado <luis.machado@linaro.org>
1022
1023 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1024
1025 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1026
1027 * dwarf2read.c (read_tag_string_type): Read the fields required to
1028 make a dynamic string, and possibly create a dynamic range for the
1029 string.
1030 (attr_to_dynamic_prop): Setup is_reference based on the type of
1031 attribute being processed.
1032 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1033 (resolve_dynamic_array): Rename to...
1034 (resolve_dynamic_array_or_string): ...this, update header comment,
1035 and accept TYPE_CODE_STRING.
1036 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1037
1038 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1039
1040 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1041 of its implementation from...
1042 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1043 the new function.
1044
1045 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1046
1047 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1048 create a range with stride where appropriate.
1049 * f-valprint.c: Include 'gdbarch.h'.
1050 (f77_print_array_1): Take the stride into account when walking the
1051 array. Also convert the stride into addressable units.
1052 * gdbtypes.c (create_range_type): Initialise the stride to
1053 constant zero.
1054 (create_range_type_with_stride): New function, initialise the
1055 range as normal, and then setup the stride.
1056 (has_static_range): Include the stride here. Also change the
1057 return type to bool.
1058 (create_array_type_with_stride): Consider the range stride if the
1059 array isn't given its own stride.
1060 (resolve_dynamic_range): Resolve the stride if needed.
1061 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1062 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1063 (TYPE_BIT_STRIDE): Define.
1064 (TYPE_ARRAY_BIT_STRIDE): Define.
1065 (create_range_type_with_stride): Declare.
1066 * valarith.c (value_subscripted_rvalue): Take range stride into
1067 account when walking the array.
1068
1069 2019-12-01 Tom Tromey <tom@tromey.com>
1070
1071 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1072 specially.
1073
1074 2019-12-01 Tom Tromey <tom@tromey.com>
1075
1076 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1077 \0.
1078 * unittests/tui-selftests.c: New file.
1079 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1080
1081 2019-12-01 Tom Tromey <tom@tromey.com>
1082
1083 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1084
1085 2019-12-01 Tom Tromey <tom@tromey.com>
1086
1087 * NEWS: Document new settings.
1088 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1089 * tui/tui-win.c (_initialize_tui_win): Add border style
1090 observers.
1091 * tui/tui-io.h (tui_apply_style): Declare.
1092 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1093 longer static.
1094 (apply_ansi_escape, tui_set_reverse_mode): Update.
1095 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1096 Add "skip_intensity" parameter.
1097 <changed>: New member.
1098 <do_set_value>: Declare.
1099 (tui_border_style, tui_active_border_style): Declare.
1100 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1101 globals.
1102 (cli_style_option): Initialize "changed".
1103 (cli_style_option::do_set_value): New function.
1104 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1105 parameter. Update.
1106 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1107 (_initialize_cli_style): Update. Create TUI border style
1108 commands.
1109
1110 2019-12-01 Tom Tromey <tom@tromey.com>
1111
1112 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1113 parameter.
1114 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1115 parameter.
1116 * tui/tui-win.h (compact_source): Declare.
1117 * tui/tui-win.c (compact_source): New global.
1118 (tui_set_compact_source, tui_show_compact_source): New functions.
1119 (_initialize_tui_win): Add "compact-source" setting.
1120 * tui/tui-source.c (tui_source_window::set_contents): Handle
1121 compact_source setting.
1122 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1123 * NEWS: Document new setting.
1124
1125 2019-11-30 Tom Tromey <tom@tromey.com>
1126
1127 * dwarf2read.c (dwarf2_add_field): Include field offset when
1128 computing variant part length.
1129
1130 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1131 * NEWS: Mention define-prefix. Tell that command names can now
1132 contain a . character.
1133
1134 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1135
1136 * command.h (valid_cmd_char_p): Declare.
1137 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1138 the check of valid command char.
1139 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1140 valid_cmd_char_p.
1141 * cli/cli-script.c (validate_comname): Likewise.
1142 * completer.c (gdb_completer_command_word_break_characters):
1143 Do not remove . from the word break char, update comments.
1144 (complete_line_internal_1): Use valid_cmd_char_p.
1145 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1146 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1147
1148 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1149
1150 * cli/cli-script.c (do_define_command): Ensure a redefined
1151 prefix command is kept as a prefix command.
1152 (define_prefix_command): New function.
1153 (show_user_1): Report user defined prefixes.
1154 (_initialize_cli_script): Create the new 'define-prefix' command.
1155 Add completers for 'define' and 'document'.
1156 * top.c (execute_command): If command is a user-defined prefix only
1157 command, report the list of commands for this prefix command.
1158
1159 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1160
1161 * valops.c (find_oload_champ): Improve debug output.
1162
1163 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1164
1165 * valops.c (find_oload_champ): Print part of debug messages
1166 before the badness vector is std::move'd.
1167
1168 2019-11-28 Tom Tromey <tom@tromey.com>
1169
1170 * value.c (creal_internal_fn): Fix comment.
1171
1172 2019-11-28 Tom Tromey <tom@tromey.com>
1173
1174 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1175 flag_bound_evaluated>: Now unsigned.
1176
1177 2019-11-28 Tom Tromey <tom@tromey.com>
1178
1179 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1180 declare.
1181
1182 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1183
1184 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1185 debug output.
1186 * jit.c (jit_unregister_code): Add debug print to match
1187 `jit_register_code`.
1188
1189 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1190
1191 * NEWS: Mention the new multithreaded symbol loading.
1192
1193 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1194
1195 * maint.c (n_worker_threads): Default to 0.
1196 (worker_threads_disabled): New function.
1197 * maint.h (worker_threads_disabled): New function.
1198 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1199 here if worker_threads_disabled () is true.
1200 (minimal_symbol_reader::install): Skip all threading if
1201 worker_threads_disabled () is true.
1202
1203 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1204
1205 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1206 hash code if possible.
1207 (add_minsym_to_demangled_hash_table): Likewise.
1208 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1209 on the background thread.
1210 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1211 Add these fields.
1212
1213 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1214
1215 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1216 of the mangled name on the background thread.
1217 * symtab.c (symbol_set_names): Allow passing in the hash of the
1218 linkage_name.
1219 * symtab.h (symbol_set_names): Likewise.
1220
1221 2019-11-27 Kevin Buettner <kevinb@redhat.com>
1222
1223 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1224 physnames are computed for inherited DIEs.
1225
1226 2019-11-27 Tom Tromey <tromey@adacore.com>
1227
1228 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1229 backslashes.
1230 * cp-support.c: Remove unnecessary backslashes.
1231
1232 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1233
1234 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1235 with sym->set_linkage_name.
1236 * coffread.c (coff_read_enum_type): Likewise.
1237 * mdebugread.c (parse_symbol): Likewise.
1238 * stabsread.c (patch_block_stabs): Likewise.
1239 (define_symbol): Likewise.
1240 (read_enum_type): Likewise.
1241 (common_block_end): Likewise.
1242 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1243 function.
1244 (SYMBOL_SET_LINKAGE_NAME): Remove.
1245 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1246 with sym->set_linkage_name.
1247
1248 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1249
1250 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1251 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1252 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1253 * NEWS: Mention new MI command.
1254
1255 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1256
1257 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1258 '-symbol-info-types', and '-symbol-info-variables'.
1259 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1260 (mi_cmd_symbol_info_types): Declare.
1261 (mi_cmd_symbol_info_variables): Declare.
1262 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1263 (output_debug_symbol): New function.
1264 (output_nondebug_symbol): New function.
1265 (mi_symbol_info): New function.
1266 (mi_info_functions_or_variables): New function.
1267 (mi_cmd_symbol_info_functions): New function.
1268 (mi_cmd_symbol_info_types): New function.
1269 (mi_cmd_symbol_info_variables): New function.
1270 * NEWS: Mention new commands.
1271
1272 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1273
1274 * symtab.c (symbol_to_info_string): New function, most content
1275 moved from print_symbol_info, but updated to return a std::string.
1276 (print_symbol_info): Update to use symbol_to_info_string and print
1277 returned string.
1278 * symtab.h (symbol_to_info_string): Declare new function.
1279
1280 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1281
1282 * python/python.c (gdbpy_rbreak): Convert to using
1283 global_symbol_searcher.
1284 * symtab.c (file_matches): Convert return type to bool, change
1285 file list to std::vector, update header comment.
1286 (search_symbols): Rename to...
1287 (global_symbol_searcher::search): ...this and update now its
1288 a member function of global_symbol_searcher. Take account of the
1289 changes to file_matches.
1290 (symtab_symbol_info): Convert to using global_symbol_searcher.
1291 (rbreak_command): Likewise.
1292 (search_module_symbols): Likewise.
1293 * symtab.h (enum symbol_search): Update comment.
1294 (search_symbols): Remove declaration.
1295 (class global_symbol_searcher): New class.
1296
1297 2019-11-26 Tom Tromey <tromey@adacore.com>
1298
1299 * cp-support.c (_initialize_cp_support): Conditionally initialize
1300 gdb_demangle_attempt_core_dump.
1301
1302 2019-11-26 Tom Tromey <tom@tromey.com>
1303
1304 * python/py-function.c (fnpy_init): Update.
1305 * value.h (add_internal_function): Adjust declaration.
1306 * value.c (function_destroyer): Remove.
1307 (do_add_internal_function): Don't set destroyer or copy name.
1308 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1309 Set name_allocated.
1310 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1311 (cmdpy_init): Set name_allocated.
1312 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1313 member.
1314 (~cmd_list_element): Free "name" if needed.
1315
1316 2019-11-26 Tom Tromey <tom@tromey.com>
1317
1318 * value.h (add_internal_function): Add new overload. Move
1319 documentation from value.h.
1320 * value.c (do_add_internal_function): New function.
1321 (add_internal_function): Use it. Add new overload.
1322 (function_destroyer): Don't free doc.
1323 * python/py-function.c (fnpy_init): Update.
1324
1325 2019-11-26 Tom Tromey <tom@tromey.com>
1326
1327 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1328 (cmdpy_init): Set "doc_allocated".
1329
1330 2019-11-26 Tom Tromey <tom@tromey.com>
1331
1332 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1333 name of worker thread.
1334 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1335 pthread_setname_np.
1336 * configure, config.in: Rebuild.
1337
1338 2019-11-26 Tom Tromey <tom@tromey.com>
1339
1340 * python/python.c (class gdbpy_gil): New.
1341 (struct gdbpy_event): Add constructor, destructor, operator().
1342 (gdbpy_post_event): Use run_on_main_thread.
1343 (gdbpy_initialize_events): Remove.
1344 (do_start_initialization): Update.
1345
1346 2019-11-26 Tom Tromey <tom@tromey.com>
1347
1348 * NEWS: Add entry.
1349 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1350 commands. Call update_thread_pool_size.
1351 (update_thread_pool_size, maintenance_set_worker_threads): New
1352 functions.
1353 (n_worker_threads): New global.
1354
1355 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1356 Tom Tromey <tom@tromey.com>
1357
1358 * minsyms.c (minimal_symbol_reader::install): Use
1359 parallel_for_each.
1360 * gdbsupport/parallel-for.h: New file.
1361 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1362
1363 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1364 Tom Tromey <tom@tromey.com>
1365
1366 * gdbsupport/thread-pool.h: New file.
1367 * gdbsupport/thread-pool.c: New file.
1368 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1369 (HFILES_NO_SRCDIR): Add thread-pool.h.
1370
1371 2019-11-26 Tom Tromey <tom@tromey.com>
1372
1373 * event-top.h (thread_local_segv_handler): Declare.
1374 * event-top.c (thread_local_segv_handler): New global.
1375 (install_handle_sigsegv, handle_sigsegv): New functions.
1376 (async_init_signals): Install SIGSEGV handler.
1377 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1378 thread-local.
1379 (report_failed_demangle): New function.
1380 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1381 handler-setting code, instead use segv_handler. Run warning code
1382 on main thread.
1383
1384 2019-11-26 Tom Tromey <tom@tromey.com>
1385
1386 * run-on-main-thread.c: New file.
1387 * run-on-main-thread.h: New file.
1388 * unittests/main-thread-selftests.c: New file.
1389 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1390 main-thread-selftests.c.
1391 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1392 (COMMON_SFILES): Add run-on-main-thread.c.
1393
1394 2019-11-26 Tom Tromey <tom@tromey.com>
1395
1396 * main.c (setup_alternate_signal_stack): Remove.
1397 (captured_main_1): Use gdb::alternate_signal_stack.
1398 * gdbsupport/alt-stack.h: New file.
1399
1400 2019-11-26 Tom Tromey <tom@tromey.com>
1401
1402 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1403 Remove comment.
1404 (save_original_signals_state, restore_original_signals_state): Use
1405 gdb_sigmask.
1406 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1407 (_initialize_linux_nat): Use gdb_sigmask.
1408 * guile/guile.c (_initialize_guile): Use block_signals.
1409 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1410 * gdbsupport/gdb-sigmask.h: New file.
1411 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1412 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1413 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1414 pthread_sigmask.
1415 * configure, config.in: Rebuild.
1416 * gdbsupport/block-signals.h: New file.
1417
1418 2019-11-26 Tom Tromey <tom@tromey.com>
1419
1420 * acinclude.m4: Include ax_pthread.m4.
1421 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1422 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1423 (CLIBS): Use PTHREAD_LIBS.
1424 (aclocal_m4_deps): Add ax_pthread.m4.
1425 * config.in, configure: Rebuild.
1426 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1427
1428 2019-11-26 Tom Tromey <tom@tromey.com>
1429
1430 * symtab.h (struct minimal_symbol) <name_set>: New member.
1431 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1432 Don't call symbol_set_names.
1433 (minimal_symbol_reader::install): Call symbol_set_names.
1434
1435 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1436
1437 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1438 restore_active_ext_lang, as GIL is needed for (indirectly)
1439 called PyOS_InterruptOccurred.
1440
1441 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1442
1443 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1444 definition.
1445
1446 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1447
1448 * remote-sim.c (simulator_command): Make static, remove
1449 declaration.
1450
1451 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1452
1453 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1454 static.
1455 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1456 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1457 (main): Likewise.
1458 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1459 (main): Likewise.
1460 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1461 (main): Likewise.
1462 * unittests/basic_string_view/element_access/char/1.cc (test01):
1463 Likewise.
1464 (main): Likewise.
1465 * unittests/basic_string_view/element_access/char/empty.cc (main):
1466 Likewise.
1467 * unittests/basic_string_view/element_access/char/front_back.cc
1468 (test01): Likewise.
1469 (main): Likewise.
1470 * unittests/basic_string_view/inserters/char/2.cc (test05):
1471 Likewise.
1472 (main): Likewise.
1473 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1474 (test01): Likewise.
1475 (main): Likewise.
1476 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1477 (test01): Likewise.
1478 (main): Likewise.
1479 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1480 Likewise.
1481 * unittests/basic_string_view/operations/compare/char/1.cc
1482 (test01): Likewise.
1483 (main): Likewise.
1484 * unittests/basic_string_view/operations/compare/char/13650.cc
1485 (test01): Likewise.
1486 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1487 Likewise.
1488 (main): Likewise.
1489 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1490 Likewise.
1491 (main): Likewise.
1492 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1493 Likewise.
1494 (main): Likewise.
1495 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1496 Likewise.
1497 (main): Likewise.
1498 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1499 Likewise.
1500 (main): Likewise.
1501 * unittests/basic_string_view/operations/find/char/4.cc (main):
1502 Likewise.
1503 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1504 Likewise.
1505 (main): Likewise.
1506 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1507 Likewise.
1508 (main): Likewise.
1509 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1510 Likewise.
1511 (main): Likewise.
1512 * unittests/basic_string_view/operations/substr/char/1.cc
1513 (test01): Likewise.
1514 (main): Likewise.
1515 * unittests/basic_string_view/operators/char/2.cc (main):
1516 Likewise.
1517 * unittests/optional/assignment/1.cc (test): Likewise.
1518 * unittests/optional/assignment/2.cc (test): Likewise.
1519 * unittests/optional/assignment/3.cc (test): Likewise.
1520 * unittests/optional/assignment/4.cc (test): Likewise.
1521 * unittests/optional/assignment/5.cc (test): Likewise.
1522 * unittests/optional/assignment/6.cc (test): Likewise.
1523 * unittests/optional/assignment/7.cc (test): Likewise.
1524 * unittests/optional/cons/copy.cc (test): Likewise.
1525 * unittests/optional/cons/default.cc (test): Likewise.
1526 * unittests/optional/cons/move.cc (test): Likewise.
1527 * unittests/optional/cons/value.cc (test): Likewise.
1528 * unittests/optional/in_place.cc (test): Likewise.
1529 * unittests/optional/observers/1.cc (test): Likewise.
1530 * unittests/optional/observers/2.cc (test): Likewise.
1531
1532 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1533
1534 * tui-win.h (tui_set_var_cmd): Remove.
1535 * tui-win.c (tui_set_var_cmd): Make static.
1536
1537 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1538
1539 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1540 rbreak_command_wrapper): Remove.
1541 * symtab.c (rbreak_command_wrapper): Remove.
1542
1543 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1544
1545 * inferior.h (info_terminal_command): Remove declaration.
1546 * inflow.c (info_terminal_command): Make static.
1547
1548 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1549
1550 * inferior.c (exit_inferior_silent): Remove.
1551
1552 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1553
1554 * dictionary.c (dict_empty, mdict_empty): Remove.
1555 * dictionary.c (mdict_empty): Remove.
1556
1557 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1558
1559 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1560 (arc_insn_get_memory_offset): Likewise.
1561 (arc_insn_dump): Likewise.
1562 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1563 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1564 * dictionary.c (dict_iterator_next): Likewise.
1565 (dict_iter_match_first): Likewise.
1566 (dict_iter_match_next): Likewise.
1567 * f-lang.c (evaluate_subexp_f): Likewise.
1568 * hppa-tdep.c (hppa_read_pc): Likewise.
1569 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1570 * parse.c (write_exp_elt_msym): Likewise.
1571 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1572 * remote.c (remote_packet_size): Likewise.
1573 (remote_notif_stop_parse): Likewise.
1574 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1575 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1576 * source.c (prepare_path_for_appending): Likewise.
1577 * sparc64-linux-tdep.c
1578 (sparc64_linux_handle_segmentation_fault); Likewise.
1579 * stack.c (frame_selection_by_function_completer): Likewise.
1580
1581 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1582
1583 * completer.c (set_gdb_completion_word_break_characters):
1584 Remove.
1585
1586 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1587
1588 * dwarf-index-write.c: Include dwarf-index-write.h.
1589 * mi/mi-interp.c: Include mi/mi-interp.h.
1590
1591 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1592
1593 * aarch32-tdep.c: Include aarch32-tdep.h.
1594 * aarch32-tdep.h: Forward-declare struct target_desc.
1595
1596 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1597
1598 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1599 strerror.
1600 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1601 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1602
1603 2019-11-25 Tom de Vries <tdevries@suse.de>
1604
1605 * contrib/words.sh: Add -c option.
1606
1607 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1608
1609 * solib.c (solib_find_1): Change int to bool.
1610 (exec_file_find): Change int to bool.
1611 (solib_find): Change int to bool.
1612 (solib_read_symbols): Change int to bool.
1613 (solib_used): Change int to bool.
1614 (solib_add): Change int to bool.
1615 (info_sharedlibrary_command): Change int to bool.
1616 (solib_contains_address_p): Change int to bool.
1617 (solib_keep_data_in_core): Change int to bool.
1618 (in_solib_dynsym_resolve_code): Change int to bool.
1619 (reload_shared_libraries_1): Change int to bool.
1620 (gdb_sysroot_changed): Change int to bool.
1621 * solib.h (solib_read_symbols): Change int to bool.
1622 (solib_contains_address_p): Change int to bool.
1623 (solib_keep_data_in_core): Change int to bool.
1624 (in_solib_dynsym_resolve_code): Change int to bool.
1625 (libpthread_name_p): Change int to bool.
1626
1627 2019-11-25 Luis Machado <luis.machado@linaro.org>
1628
1629 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1630 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1631 (remote_packet_max_chars): New static global.
1632 (show_remote_packet_max_chars): New function.
1633 (remote_target::putpkt_binary): Adjust to use new
1634 remote_packet_max_chars option.
1635 (remote_target::getpkt_or_notif_sane_1): Likewise.
1636 (_initialize_remote): Register new remote-packet-max-chars option.
1637
1638 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1639
1640 * m68k-linux-nat.c: Include gdbarch.h.
1641
1642 2019-11-24 Tom Tromey <tom@tromey.com>
1643
1644 * symfile.c (read_symbols): Update.
1645 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1646 bool.
1647 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1648 (psym_lookup_symbol, psym_find_last_source_symtab)
1649 (psym_forget_cached_source_info, psym_print_stats)
1650 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1651 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1652 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1653 (psym_find_compunit_symtab_by_address)
1654 (maintenance_print_psymbols, maintenance_info_psymtabs)
1655 (maintenance_check_psymtabs): Update.
1656 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1657 bool.
1658
1659 2019-11-22 Tom Tromey <tom@tromey.com>
1660
1661 * observable.h: Update comments.
1662
1663 2019-11-22 Tom Tromey <tromey@adacore.com>
1664
1665 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1666 (print_ada_task_info): Don't try to fetch thread id if task is not
1667 alive.
1668
1669 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1670
1671 * ada-exp.y: Update.
1672 * ada-lang.c (sort_choices): Update.
1673 (ada_print_symbol_signature): Update.
1674 (resolve_subexp): Update.
1675 (ada_parse_renaming): Update.
1676 (ada_read_renaming_var_value): Update.
1677 (lesseq_defined_than): Update.
1678 (remove_extra_symbols): Update.
1679 (remove_irrelevant_renamings): Update.
1680 (ada_add_block_symbols): Update.
1681 (ada_collect_symbol_completion_matches): Update.
1682 (ada_is_renaming_symbol): Update.
1683 (aggregate_assign_from_choices): Update.
1684 (ada_evaluate_subexp): Update.
1685 (ada_has_this_exception_support): Update.
1686 (ada_is_non_standard_exception_sym): Update.
1687 (ada_add_exceptions_from_frame): Update.
1688 (ada_add_global_exceptions): Update.
1689 (ada_print_subexp): Update.
1690 * ax-gdb.c (gen_var_ref): Update.
1691 (gen_maybe_namespace_elt): Update.
1692 (gen_expr_for_cast): Update.
1693 (gen_expr): Update.
1694 * block.h: Update.
1695 * blockframe.c (find_pc_partial_function): Update.
1696 * breakpoint.c (print_breakpoint_location): Update.
1697 (update_static_tracepoint): Update.
1698 * btrace.c (ftrace_print_function_name): Update.
1699 (ftrace_function_switched): Update.
1700 * buildsym.c (find_symbol_in_list): Update.
1701 * c-exp.y: Update.
1702 * c-typeprint.c (c_print_typedef): Update.
1703 (c_type_print_template_args): Update.
1704 * cli/cli-cmds.c (edit_command): Update.
1705 (list_command): Update.
1706 (print_sal_location): Update.
1707 * coffread.c (patch_opaque_types): Update.
1708 (process_coff_symbol): Update.
1709 (coff_read_enum_type): Update.
1710 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1711 (convert_one_symbol): Update.
1712 (hash_symname): Update.
1713 (eq_symname): Update.
1714 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1715 * compile/compile-cplus-types.c (debug_print_scope): Update.
1716 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1717 * compile/compile-object-load.c (get_out_value_type): Update.
1718 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1719 (search_symbol_list): Update.
1720 (cp_lookup_symbol_imports_or_template): Update.
1721 * cp-support.c (overload_list_add_symbol): Update.
1722 * ctfread.c (psymtab_to_symtab): Update.
1723 * dbxread.c (cp_set_block_scope): Update.
1724 * dictionary.c (iter_match_first_hashed): Update.
1725 (iter_match_next_hashed): Update.
1726 (insert_symbol_hashed): Update.
1727 (iter_match_next_linear): Update.
1728 * dictionary.h: Update.
1729 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1730 (locexpr_describe_location_piece): Update.
1731 (locexpr_describe_location_1): Update.
1732 (locexpr_generate_c_location): Update.
1733 (loclist_describe_location): Update.
1734 (loclist_generate_c_location): Update.
1735 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1736 (read_func_scope): Update.
1737 (process_enumeration_scope): Update.
1738 (new_symbol): Update.
1739 (dwarf2_const_value): Update.
1740 (dwarf2_symbol_mark_computed): Update.
1741 * eval.c (evaluate_funcall): Update.
1742 (evaluate_subexp_standard): Update.
1743 * expprint.c (print_subexp_standard): Update.
1744 (dump_subexp_body_standard): Update.
1745 * f-valprint.c (info_common_command_for_block): Update.
1746 * findvar.c (get_hosting_frame): Update.
1747 (default_read_var_value): Update.
1748 * go-lang.c (go_symbol_package_name): Update.
1749 * guile/scm-block.c (bkscm_print_block_smob): Update.
1750 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1751 (gdbscm_symbol_name): Update.
1752 (gdbscm_symbol_linkage_name): Update.
1753 (gdbscm_symbol_print_name): Update.
1754 * infcall.c (get_function_name): Update.
1755 * infcmd.c (jump_command): Update.
1756 (finish_command): Update.
1757 * infrun.c (insert_exception_resume_breakpoint): Update.
1758 * linespec.c (canonicalize_linespec): Update.
1759 (create_sals_line_offset): Update.
1760 (convert_linespec_to_sals): Update.
1761 (complete_label): Update.
1762 (find_label_symbols_in_block): Update.
1763 * m2-typeprint.c (m2_print_typedef): Update.
1764 * mdebugread.c (mdebug_reg_to_regnum): Update.
1765 (parse_symbol): Update.
1766 (mylookup_symbol): Update.
1767 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1768 (list_args_or_locals): Update.
1769 * objc-lang.c (compare_selectors): Update.
1770 (info_selectors_command): Update.
1771 (compare_classes): Update.
1772 (info_classes_command): Update.
1773 (find_imps): Update.
1774 * p-typeprint.c (pascal_print_typedef): Update.
1775 * printcmd.c (build_address_symbolic): Update.
1776 (info_address_command): Update.
1777 (print_variable_and_value): Update.
1778 * python/py-framefilter.c (extract_sym): Update.
1779 (py_print_single_arg): Update.
1780 * python/py-symbol.c (sympy_str): Update.
1781 (sympy_get_name): Update.
1782 (sympy_get_linkage_name): Update.
1783 * python/python.c (gdbpy_rbreak): Update.
1784 * record-btrace.c (btrace_get_bfun_name): Update.
1785 (btrace_call_history): Update.
1786 * rust-lang.c (rust_print_typedef): Update.
1787 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1788 * stabsread.c (stab_reg_to_regnum): Update.
1789 (define_symbol): Update.
1790 (read_enum_type): Update.
1791 (common_block_end): Update.
1792 (cleanup_undefined_types_1): Update.
1793 (scan_file_globals): Update.
1794 * stack.c (print_frame_arg): Update.
1795 (print_frame_args): Update.
1796 (find_frame_funname): Update.
1797 (info_frame_command_core): Update.
1798 (iterate_over_block_locals): Update.
1799 (print_block_frame_labels): Update.
1800 (do_print_variable_and_value): Update.
1801 (iterate_over_block_arg_vars): Update.
1802 (return_command): Update.
1803 * symmisc.c (dump_symtab_1): Update.
1804 (print_symbol): Update.
1805 * symtab.c (eq_symbol_entry): Update.
1806 (symbol_cache_dump): Update.
1807 (lookup_language_this): Update.
1808 (find_pc_sect_line): Update.
1809 (skip_prologue_sal): Update.
1810 (symbol_search::compare_search_syms): Update.
1811 (treg_matches_sym_type_name): Update.
1812 (search_symbols): Update.
1813 (print_symbol_info): Update.
1814 (rbreak_command): Update.
1815 (completion_list_add_symbol): Update.
1816 (find_gnu_ifunc): Update.
1817 (get_symbol_address): Update.
1818 (search_module_symbols): Update.
1819 (info_module_subcommand): Update.
1820 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1821 (SYMBOL_LINKAGE_NAME): Remove.
1822 (SYMBOL_DEMANGLED_NAME): Remove.
1823 (SYMBOL_PRINT_NAME): Remove.
1824 (SYMBOL_SEARCH_NAME): Remove.
1825 * tracepoint.c (set_traceframe_context): Update.
1826 (validate_actionline): Update.
1827 (collection_list::collect_symbol): Update.
1828 (encode_actions_1): Update.
1829 (info_scope_command): Update.
1830 (print_one_static_tracepoint_marker): Update.
1831 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1832 * valops.c (address_of_variable): Update.
1833 (find_overload_match): Update.
1834 (find_oload_champ): Update.
1835
1836 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1837
1838 * ada-lang.c (ada_lookup_simple_minsym): Update.
1839 (ada_collect_symbol_completion_matches): Update.
1840 * ada-tasks.c (read_atcb): Update.
1841 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1842 (amd64_windows_skip_trampoline_code): Update.
1843 * arm-tdep.c (skip_prologue_function): Update.
1844 (arm_skip_stack_protector): Update.
1845 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1846 (arm_wince_skip_main_prologue): Update.
1847 * ax-gdb.c (gen_expr): Update.
1848 * block.c (call_site_for_pc): Update.
1849 * blockframe.c (find_pc_partial_function): Update.
1850 * breakpoint.c (set_breakpoint_location_function): Update.
1851 * btrace.c (ftrace_print_function_name): Update.
1852 (ftrace_function_switched): Update.
1853 * c-valprint.c (print_unpacked_pointer): Update.
1854 * coffread.c (coff_symfile_read): Update.
1855 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1856 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1857 * dwarf-index-write.c (write_psymbols): Update.
1858 * dwarf2loc.c (call_site_to_target_addr): Update.
1859 (func_verify_no_selftailcall): Update.
1860 (tailcall_dump): Update.
1861 (call_site_find_chain_1): Update.
1862 (dwarf_expr_reg_to_entry_parameter): Update.
1863 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1864 * eval.c (evaluate_funcall): Update.
1865 (evaluate_subexp_standard): Update.
1866 (evaluate_subexp_for_sizeof): Update.
1867 * expprint.c (print_subexp_standard): Update.
1868 (dump_subexp_body_standard): Update.
1869 * frame.c (get_prev_frame_always_1): Update.
1870 * frv-tdep.c (frv_skip_main_prologue): Update.
1871 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1872 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1873 (gnuv3_get_typename_from_type_info): Update.
1874 (gnuv3_skip_trampoline): Update.
1875 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1876 * i386-tdep.c (i386_skip_main_prologue): Update.
1877 (i386_pe_skip_trampoline_code): Update.
1878 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1879 * infcall.c (get_function_name): Update.
1880 * linespec.c (minsym_found): Update.
1881 * linux-fork.c (info_checkpoints_command): Update.
1882 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1883 (m32c_m16c_pointer_to_address): Update.
1884 * maint.c (maintenance_translate_address): Update.
1885 * minsyms.c (add_minsym_to_hash_table): Update.
1886 (add_minsym_to_demangled_hash_table): Update.
1887 (lookup_minimal_symbol_mangled): Update.
1888 (lookup_minimal_symbol_demangled): Update.
1889 (lookup_minimal_symbol_linkage): Update.
1890 (lookup_minimal_symbol_text): Update.
1891 (lookup_minimal_symbol_by_pc_name): Update.
1892 (minimal_symbol_is_less_than): Update.
1893 (compact_minimal_symbols): Update.
1894 (build_minimal_symbol_hash_tables): Update.
1895 (find_solib_trampoline_target): Update.
1896 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1897 (mips_skip_pic_trampoline_code): Update.
1898 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1899 * objc-lang.c (info_selectors_command): Update.
1900 (info_classes_command): Update.
1901 (find_methods): Update.
1902 (find_imps): Update.
1903 * p-valprint.c (pascal_val_print): Update.
1904 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1905 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1906 * printcmd.c (build_address_symbolic): Update.
1907 (info_symbol_command): Update.
1908 * psymtab.c (psymbol_name_matches): Update.
1909 (match_partial_symbol): Update.
1910 (lookup_partial_symbol): Update.
1911 (print_partial_symbols): Update.
1912 (sort_pst_symbols): Update.
1913 (maintenance_check_psymtabs): Update.
1914 * python/py-framefilter.c (py_print_frame): Update.
1915 * python/python.c (gdbpy_rbreak): Update.
1916 * record-btrace.c (btrace_get_bfun_name): Update.
1917 (btrace_call_history): Update.
1918 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1919 (rs6000_skip_trampoline_code): Update.
1920 * sol-thread.c (info_cb): Update.
1921 * stabsread.c (scan_file_globals): Update.
1922 * stack.c (find_frame_funname): Update.
1923 (info_frame_command_core): Update.
1924 * symmisc.c (dump_msymbols): Update.
1925 * symtab.c (symbol_natural_name): Rename to..,
1926 (general_symbol_info::natural_name): ...this.
1927 (symbol_demangled_name): Rename to...
1928 (general_symbol_info::demangled_name): ...this.
1929 (symbol_search_name): Rename to...
1930 (general_symbol_info::search_name): ...this.
1931 (symbol_matches_search_name): Update.
1932 (find_pc_sect_line): Update.
1933 (skip_prologue_sal): Update.
1934 (search_symbols): Update.
1935 (print_msymbol_info): Update.
1936 (rbreak_command): Update.
1937 (completion_list_add_msymbol): Update.
1938 (completion_list_objc_symbol): Update.
1939 (get_msymbol_address): Update.
1940 * symtab.h (struct general_symbol_info): Add member functions
1941 natural_name (), linkage_name (), print_name (), demangled_name (),
1942 and search_name ().
1943 (SYMBOL_NATURAL_NAME): Update.
1944 (symbol_natural_name): Move to a member function on general_symbol_info.
1945 (SYMBOL_DEMANGLED_NAME): Update.
1946 (symbol_demangled_name): Move to a member function on
1947 general_symbol_info.
1948 (SYMBOL_SEARCH_NAME): Update.
1949 (symbol_search_name): Move to a member function on general_symbol_info.
1950 (MSYMBOL_NATURAL_NAME): Remove.
1951 (MSYMBOL_LINKAGE_NAME): Remove.
1952 (MSYMBOL_PRINT_NAME): Remove.
1953 (MSYMBOL_DEMANGLED_NAME): Remove.
1954 (MSYMBOL_SEARCH_NAME): Remove.
1955 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1956
1957 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1958
1959 * symtab.c (create_demangled_names_hash): Use per_bfd->
1960 minimal_symbol_count for computing the initial size, if greater
1961 than our default size.
1962
1963 2019-11-22 Tom de Vries <tdevries@suse.de>
1964
1965 * contrib/words.sh: Improve words extraction.
1966
1967 2019-11-22 Tom de Vries <tdevries@suse.de>
1968
1969 * contrib/words.sh: Combine sed invocations.
1970
1971 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1972
1973 * Makefile.in: Update.
1974 * demangle.c: Rename to...
1975 * gdb-demangle.c: ..this.
1976 (is_cplus_marker): Change return type to bool.
1977 (_initialize_demangler): Rename to...
1978 (_initialize_gdb_demangle): ...this.
1979 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1980 * symtab.h (demangle): Remove declaration; instead include
1981 gdb-demangle.h.
1982
1983 2019-11-21 Tom Tromey <tromey@adacore.com>
1984
1985 * gdbsupport/format.c (format_pieces): Parse %I64d.
1986 * unittests/format_pieces-selftests.c (test_windows_formats): New
1987 function.
1988 (run_tests): Call it.
1989
1990 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1991
1992 Byte reverse display of variables with DW_END_big, DW_END_little
1993 (DW_AT_endianity) dwarf attributes if different than the native
1994 byte order.
1995 * ada-lang.c (ada_value_binop):
1996 Use type_byte_order instead of gdbarch_byte_order.
1997 * ada-valprint.c (printstr):
1998 (ada_val_print_string):
1999 * ada-lang.c (value_pointer):
2000 (ada_value_binop):
2001 Use type_byte_order instead of gdbarch_byte_order.
2002 * c-lang.c (c_get_string):
2003 Use type_byte_order instead of gdbarch_byte_order.
2004 * c-valprint.c (c_val_print_array):
2005 Use type_byte_order instead of gdbarch_byte_order.
2006 * cp-valprint.c (cp_print_class_member):
2007 Use type_byte_order instead of gdbarch_byte_order.
2008 * dwarf2loc.c (rw_pieced_value):
2009 Use type_byte_order instead of gdbarch_byte_order.
2010 * dwarf2read.c (read_base_type): Handle DW_END_big,
2011 DW_END_little
2012 * f-lang.c (f_get_encoding):
2013 Use type_byte_order instead of gdbarch_byte_order.
2014 * findvar.c (default_read_var_value):
2015 Use type_byte_order instead of gdbarch_byte_order.
2016 * gdbtypes.c (check_types_equal):
2017 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2018 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2019 and TYPE_ENDIANITY_LITTLE if set.
2020 (type_byte_order): new function.
2021 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2022 (struct main_type) <flag_endianity_not_default>:
2023 New field.
2024 (type_byte_order): New function.
2025 * infcmd.c (default_print_one_register_info):
2026 Use type_byte_order instead of gdbarch_byte_order.
2027 * p-lang.c (pascal_printstr):
2028 Use type_byte_order instead of gdbarch_byte_order.
2029 * p-valprint.c (pascal_val_print):
2030 Use type_byte_order instead of gdbarch_byte_order.
2031 * printcmd.c (print_scalar_formatted):
2032 Use type_byte_order instead of gdbarch_byte_order.
2033 * solib-darwin.c (darwin_current_sos):
2034 Use type_byte_order instead of gdbarch_byte_order.
2035 * solib-svr4.c (solib_svr4_r_ldsomap):
2036 Use type_byte_order instead of gdbarch_byte_order.
2037 * stap-probe.c (stap_modify_semaphore):
2038 Use type_byte_order instead of gdbarch_byte_order.
2039 * target-float.c (target_float_same_format_p):
2040 Use type_byte_order instead of gdbarch_byte_order.
2041 * valarith.c (scalar_binop):
2042 (value_bit_index):
2043 Use type_byte_order instead of gdbarch_byte_order.
2044 * valops.c (value_cast):
2045 Use type_byte_order instead of gdbarch_byte_order.
2046 * valprint.c (generic_emit_char):
2047 (generic_printstr):
2048 (val_print_string):
2049 Use type_byte_order instead of gdbarch_byte_order.
2050 * value.c (unpack_long):
2051 (unpack_bits_as_long):
2052 (unpack_value_bitfield):
2053 (modify_field):
2054 (pack_long):
2055 (pack_unsigned_long):
2056 Use type_byte_order instead of gdbarch_byte_order.
2057 * findvar.c (unsigned_pointer_to_address):
2058 (signed_pointer_to_address):
2059 (unsigned_address_to_pointer):
2060 (address_to_signed_pointer):
2061 (default_read_var_value):
2062 (default_value_from_register):
2063 Use type_byte_order instead of gdbarch_byte_order.
2064 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2065 Use type_byte_order instead of gdbarch_byte_order.
2066 * riscv-tdep.c (riscv_print_one_register_info):
2067 Use type_byte_order instead of gdbarch_byte_order.
2068
2069 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2070
2071 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2072 (current_ui_gdb_stdin_ptr): Likewise.
2073 (current_ui_gdb_stderr_ptr): Likewise.
2074 (current_ui_gdb_stdlog_ptr): Likewise.
2075 (current_ui_current_uiout_ptr): Likewise.
2076 (gen_ret_current_ui_field_ptr): Remove.
2077
2078 2019-11-21 Tom de Vries <tdevries@suse.de>
2079
2080 PR gdb/24956
2081 * cli/cli-script.c (execute_control_command): Only switch to
2082 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2083
2084 2019-11-19 Tom Tromey <tom@tromey.com>
2085
2086 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2087 Now static. Change type of "name".
2088 (tui_set_win_height_command): Don't copy "arg".
2089 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2090 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2091
2092 2019-11-19 Ali Tamur <tamur@google.com>
2093
2094 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2095 "if (attr != nullptr)".
2096 (dwarf2_find_base_address): Likewise.
2097 (dwarf2_build_include_psymtabs): Likewise.
2098 (read_cutu_die_from_dwo): Likewise.
2099 (read_func_scope): Likewise.
2100 (read_call_site_scope): Likewise.
2101 (dwarf2_get_pc_bounds): Likewise.
2102 (dwarf2_record_block_ranges): Likewise.
2103 (dwarf2_add_field): Likewise.
2104 (dwarf2_add_member_fn): Likewise.
2105 (read_structure_type): Likewise.
2106 (read_enumeration_type): Likewise.
2107 (read_array_type): Likewise.
2108 (read_array_order): Likewise.
2109 (read_set_type): Likewise.
2110 (read_common_block): Likewise.
2111 (read_tag_reference_type): Likewise.
2112 (read_tag_string_type): Likewise.
2113 (read_subroutine_type): Likewise.
2114 (read_base_type): Likewise.
2115 (read_subrange_type): Likewise.
2116 (new_symbol): Likewise.
2117 (prepare_one_comp_unit): Likewise.
2118
2119 2019-11-19 Tom Tromey <tromey@adacore.com>
2120
2121 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2122 result in error when DebugActiveProcess fails.
2123
2124 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2125 Pedro Alves <palves@redhat.com>
2126
2127 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2128 * target.c (target_stack::push): Call 'unpush' if there's a
2129 target on top of the stack.
2130
2131 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2132
2133 * python/py-block.c (blpy_dealloc): Call tp_free.
2134 (blpy_block_syms_dealloc): Likewise.
2135 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2136 * python/py-inferior.c (infpy_dealloc): Likewise.
2137 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2138 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2139 * python/py-symbol.c (sympy_dealloc): Likewise.
2140 * python/py-symtab.c (stpy_dealloc): Likewise.
2141 * python/py-type.c (typy_iterator_dealloc): Likewise.
2142
2143 2019-11-18 Christian Biesinger <cbiesinger@google.com>
2144
2145 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2146 constructor instead of using a class initializer.
2147
2148 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2149
2150 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2151 * configure: Regenerate.
2152 * configure.ac: Don't source common.host.
2153 * gdbsupport/common.host: Remove.
2154 * gdbsupport/mingw-strerror.c: Remove.
2155 * gdbsupport/posix-strerror.c: Rename to...
2156 * gdbsupport/safe-strerror.c: ...this.
2157
2158 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2159
2160 * maint.c (scoped_command_stats::print_time): Use localtime_r
2161 instead of localtime (provided through gnulib if necessary).
2162 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2163 of ctime.
2164
2165 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2166
2167 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2168 avoid compile errors.
2169
2170 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2171
2172 * config.in: Regenerate.
2173 * configure: Regenerate.
2174 * gdbsupport/common.m4: No longer check for strerror_r.
2175 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2176 POSIX version of strerror_r, now that gnulib provides it if
2177 necessary.
2178
2179 2019-11-14 Christian Biesinger <cbiesinger@google.com>
2180
2181 * README (`configure' options): Update.
2182
2183 2019-11-14 Tom Tromey <tromey@adacore.com>
2184
2185 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2186 expected type for the RHS if the LHS is a convenience variable.
2187
2188 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2189
2190 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2191 Provide explicit default and copy constructor.
2192
2193 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2194
2195 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2196 only call Py_INCREF (newbp) in the bppy_pending_object case.
2197
2198 2019-11-13 Tom Tromey <tromey@adacore.com>
2199
2200 PR build/25182:
2201 * psympriv.h (partial_symbol): Remove static assert.
2202 * symtab.h (general_symbol_info, symbol): Remove static assert.
2203
2204 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2205
2206 * gdbsupport/format.c (format_pieces::format_pieces): Support
2207 printf 'z' size modifier.
2208 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2209 * printcmd.c (ui_printf): Handle size_t_arg.
2210 * ui-out.c (ui_out::vmessage): Likewise.
2211 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2212 function.
2213 (run_tests): Call test_format_int_sizes.
2214
2215 2019-11-12 Christian Biesinger <cbiesinger@google.com>
2216
2217 * ada-exp.y (write_ambiguous_var): Update.
2218 * buildsym.c (add_symbol_to_list): Update.
2219 * dwarf2read.c (read_variable): Update.
2220 (new_symbol): Update.
2221 * jit.c (finalize_symtab): Update.
2222 * language.c (language_alloc_type_symbol): Update.
2223 * symtab.c (fixup_symbol_section): Update.
2224 (initialize_objfile_symbol_1): Move code to...
2225 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2226 (allocate_symbol): Update.
2227 (allocate_template_symbol): Update.
2228 (get_symbol_address): Update.
2229 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2230 of having as a field, and add a constructor.
2231 (SYMBOL_VALUE): Update.
2232 (SYMBOL_VALUE_ADDRESS): Update.
2233 (SET_SYMBOL_VALUE_ADDRESS): Update.
2234 (SYMBOL_VALUE_BYTES): Update.
2235 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2236 (SYMBOL_BLOCK_VALUE): Update.
2237 (SYMBOL_VALUE_CHAIN): Update.
2238 (SYMBOL_LANGUAGE): Update.
2239 (SYMBOL_SECTION): Update.
2240 (SYMBOL_OBJ_SECTION): Update.
2241 (SYMBOL_SET_LANGUAGE): Update.
2242 (SYMBOL_SET_LINKAGE_NAME): Update.
2243 (SYMBOL_SET_NAMES): Update.
2244 (SYMBOL_NATURAL_NAME): Update.
2245 (SYMBOL_LINKAGE_NAME): Update.
2246 (SYMBOL_DEMANGLED_NAME): Update.
2247 (SYMBOL_SEARCH_NAME): Update.
2248 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2249 (struct symbol): Update.
2250 (struct template_symbol): Update.
2251 (struct rust_vtable_symbol): Update.
2252 * xcoffread.c (SYMBOL_DUP): Update.
2253
2254 2019-11-12 Tom Tromey <tom@tromey.com>
2255
2256 * tui/tui-layout.c (show_layout): Set current_layout.
2257 (show_source_disasm_command, show_data)
2258 (show_source_or_disasm_and_command): Don't set current_layout.
2259
2260 2019-11-12 Tom Tromey <tom@tromey.com>
2261
2262 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2263
2264 2019-11-12 Tom Tromey <tom@tromey.com>
2265
2266 * tui/tui-win.c (resize_message): New global.
2267 (show_tui_resize_message): New function.
2268 (tui_async_resize_screen): Print message if requested.
2269 (_initialize_tui_win): Add tui-resize-message setting.
2270 * NEWS: Add entry for new commands.
2271
2272 2019-11-11 Tom Tromey <tom@tromey.com>
2273
2274 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2275 functions.
2276
2277 2019-11-11 Christian Biesinger <cbiesinger@google.com>
2278
2279 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2280
2281 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2282
2283 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2284 function.
2285 * python/python-internal.h (gdbpy_lookup_static_symbols):
2286 Declare new function.
2287 * python/python.c (python_GdbMethods): Add
2288 gdb.lookup_static_symbols method.
2289 * NEWS: Mention gdb.lookup_static_symbols.
2290
2291 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2292
2293 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2294 static block of current object file first. Also fix typo in
2295 header comment.
2296
2297 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2298
2299 * stack.c (set_last_displayed_sal): Delete.
2300 (last_displayed_sal_valid): Delete.
2301 (last_displayed_pspace): Delete.
2302 (last_displayed_addr): Delete.
2303 (last_displayed_symtab): Delete.
2304 (last_displayed_line): Delete.
2305 (class last_displayed_symtab_info_type): New.
2306 (last_displayed_symtab_info): New static global variable.
2307 (print_frame_info): Call methods on last_displayed_symtab_info.
2308 (clear_last_displayed_sal): Update header comment, and make use of
2309 last_displayed_symtab_info.
2310 (last_displayed_sal_is_valid): Likewise.
2311 (get_last_displayed_pspace): Likewise.
2312 (get_last_displayed_addr): Likewise.
2313 (get_last_displayed_symtab): Likewise.
2314 (get_last_displayed_line): Likewise.
2315 (get_last_displayed_sal): Likewise.
2316 * stack.h (clear_last_displayed_sal): Update header comment.
2317 (last_displayed_sal_is_valid): Likewise.
2318 (get_last_displayed_pspace): Likewise.
2319 (get_last_displayed_addr): Likewise.
2320 (get_last_displayed_symtab): Likewise.
2321 (get_last_displayed_line): Likewise.
2322 (get_last_displayed_sal): Likewise.
2323
2324 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2325
2326 * stack.c (frame_show_address): Convert return type to bool.
2327 * stack.h (frame_show_address): Likewise, and update header
2328 comment.
2329
2330 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2331
2332 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2333 * unittests/vec-utils-selftests.c: New file.
2334 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2335
2336 2019-11-10 Tom Tromey <tom@tromey.com>
2337
2338 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2339 (tui_highlight_win): Likewise.
2340 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2341 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2342 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2343 Don't set can_highlight.
2344
2345 2019-11-10 Tom Tromey <tom@tromey.com>
2346
2347 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2348 Remove unused declaration.
2349
2350 2019-11-08 Tom Tromey <tromey@adacore.com>
2351
2352 * top.c (read_command_file): Update.
2353 (command_line_input): Make return type const.
2354 * python/py-gdb-readline.c: Update.
2355 * linespec.c (decode_line_2): Update.
2356 * defs.h (command_line_input): Make return type const.
2357 * cli/cli-script.c (read_next_line): Make return type const.
2358 * ada-lang.c (get_selections): Update.
2359
2360 2019-11-06 Christian Biesinger <cbiesinger@google.com>
2361
2362 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2363 * mi/mi-main.c (output_cores): Likewise.
2364 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2365 (linux_xfer_osdata_modules): Likewise.
2366 * remote.c (register_remote_support_xml): Likewise.
2367 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2368 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2369
2370 2019-11-06 Tom Tromey <tom@tromey.com>
2371
2372 * tui/tui-interp.c: Don't include readline.h.
2373 * tui/tui-hooks.c: Don't include readline.h.
2374 * symmisc.c: Include tilde.h, not readline.h.
2375 * symfile.c: Include tilde.h, not readline.h.
2376 * source.c: Include tilde.h, not readline.h.
2377 * solib.c: Include tilde.h, not readline.h.
2378 * psymtab.c: Include tilde.h, not readline.h.
2379 * exec.c: Include tilde.h, not readline.h.
2380 * corelow.c: Include tilde.h, not readline.h.
2381 * cli/cli-dump.c: Include tilde.h, not readline.h.
2382 * cli/cli-cmds.c: Don't include readline.h.
2383
2384 2019-11-05 Tom Tromey <tom@tromey.com>
2385
2386 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2387 (tui_disassemble): Set addr_size.
2388 (tui_disasm_window::set_contents): Use addr_size.
2389
2390 2019-11-05 Tom Tromey <tom@tromey.com>
2391
2392 * rust-lang.c (rust_language_defn): Update.
2393 * python/py-value.c (valpy_string): Call c_get_string.
2394 * p-lang.c (pascal_language_defn): Update.
2395 * opencl-lang.c (opencl_language_defn): Update.
2396 * objc-lang.c (objc_language_defn): Update.
2397 * m2-lang.c (m2_language_defn): Update.
2398 * language.c (unknown_language_defn, auto_language_defn): Update.
2399 (default_get_string): Remove.
2400 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2401 * go-lang.c (go_language_defn): Update.
2402 * f-lang.c (f_language_defn): Update.
2403 * d-lang.c (d_language_defn): Update.
2404 * c-lang.c (c_language_defn, cplus_language_defn)
2405 (asm_language_defn, minimal_language_defn): Update.
2406 * ada-lang.c (ada_language_defn): Update.
2407 * language.h (struct language_defn) <la_get_string>: Remove.
2408 (LA_GET_STRING): Remove.
2409 (default_get_string): Don't declare.
2410
2411 2019-11-05 Tom Tromey <tom@tromey.com>
2412
2413 * tui/tui-source.h (struct tui_source_window): Inline
2414 constructor. Remove destructor.
2415 <style_changed, m_observable>: Move to superclass.
2416 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2417 (struct tui_source_window_base): Move private members to end.
2418 <style_changed, m_observable>: Move from tui_source_window.
2419 * tui/tui-winsource.c (tui_copy_source_line): Move from
2420 tui-source.c. Rename from copy_source_line. Add special handling
2421 for negative line number.
2422 (tui_source_window_base::style_changed): Move from
2423 tui_source_window.
2424 (tui_source_window_base): Register observer.
2425 (~tui_source_window_base): New.
2426 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2427 rename.
2428 (tui_source_window::set_contents): Use tui_copy_source_line.
2429 (tui_source_window::tui_source_window): Move to tui-source.h.
2430 (tui_source_window::~tui_source_window): Remove.
2431 (tui_source_window::style_changed): Move to superclass.
2432 * tui/tui-disasm.c (tui_disassemble): Create string file with
2433 styling, when possible. Add "addr_size" parameter.
2434 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2435 Don't compute maximum size.
2436 (len_without_escapes): New function
2437
2438 2019-11-05 Tom Tromey <tom@tromey.com>
2439
2440 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2441 std::string.
2442 * tui/tui-winsource.c (tui_show_source_line): Update.
2443 * tui/tui-source.c (tui_source_window::set_contents): Update.
2444 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2445
2446 2019-11-05 Christian Biesinger <cbiesinger@google.com>
2447
2448 * symtab.h (gdb_static_assert): Put && operator at the beginning
2449 of the line instead of the end.
2450
2451 2019-11-04 Christian Biesinger <cbiesinger@google.com>
2452
2453 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2454 and sizeof (symbol).
2455 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2456
2457 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2458
2459 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2460 * configure.host: Mark *-*-solaris2.10* obsolete.
2461 * configure.tgt: Mark Solaris < 11 obsolete.
2462 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2463 Update target triplet.
2464
2465 2019-11-01 Tom Tromey <tromey@adacore.com>
2466
2467 * utils.c (print_sys_errmsg): Simplify.
2468
2469 2019-11-01 Tom Tromey <tromey@adacore.com>
2470
2471 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2472
2473 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2474
2475 * configure: Regenerate.
2476 * configure.ac: Remove check for strerror_r.
2477 * gdbsupport/common.m4: Check for strerror_r.
2478
2479 2019-11-01 Luis Machado <luis.machado@linaro.org>
2480
2481 PR gdb/25124
2482
2483 * arm-tdep.c (arm_per_objfile): Rename to ...
2484 (arm_per_bfd): ... this.
2485 (arm_objfile_data_key): Rename to ...
2486 (arm_bfd_data_key): ... this.
2487 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2488 data.
2489 (arm_record_special_symbol): Likewise.
2490
2491 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2492
2493 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2494 end.
2495 * c-typeprint.c (c_print_typedef): Likewise.
2496 * f-typeprint.c (f_print_typedef): Likewise.
2497 * m2-typeprint.c (m2_print_typedef): Likewise.
2498 * p-typeprint.c (pascal_print_typedef): Likewise.
2499 * rust-lang.c (rust_print_typedef): Likewise.
2500 * symtab.c (print_symbol_info): Print a newline after calling
2501 typedef_print.
2502
2503 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2504
2505 * symtab.c (info_module_cmdlist): New variable.
2506 (info_module_command): New function.
2507 (search_module_symbols): New function.
2508 (info_module_subcommand): New function.
2509 (struct info_modules_var_func_options): New struct.
2510 (info_modules_var_func_options_defs): New variable.
2511 (make_info_modules_var_func_options_def_group): New function.
2512 (info_module_functions_command): New function.
2513 (info_module_variables_command): New function.
2514 (info_module_var_func_command_completer): New function.
2515 (_initialize_symtab): Register new 'info module functions' and
2516 'info module variables' commands.
2517 * symtab.h (typedef symbol_search_in_module): New typedef.
2518 (search_module_symbols): Declare new function.
2519 * NEWS: Mention new commands.
2520
2521 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2522
2523 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2524 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2525 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2526 MODULES_DOMAIN.
2527 (scan_partial_symbols): Only create partial module symbols for non
2528 declarations.
2529 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2530 and MODULES_DOMAIN.
2531 * symtab.c (search_domain_name): Likewise.
2532 (search_symbols): Likewise.
2533 (print_symbol_info): Likewise.
2534 (symtab_symbol_info): Likewise.
2535 (info_modules_command): New function.
2536 (_initialize_symtab): Register 'info modules' command.
2537 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2538 * NEWS: Mention new 'info modules' command.
2539
2540 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2541
2542 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2543 and $_gdb_maint_setting_str.
2544
2545 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2546
2547 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2548 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2549 (str_value_from_setting, gdb_setting_str_internal_fn)
2550 (gdb_maint_setting_str_internal_fn): New functions.
2551 (_initialize_cli_cmds): Define the new convenience functions.
2552 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2553 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2554
2555 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2556
2557 * agent.c (set_can_use_agent): When the setting is turned on,
2558 look up agent symbols if we don't have them yet.
2559 (agent_new_objfile): Don't look up agent symbols when the agent
2560 setting is off.
2561
2562 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2563
2564 * config.in: Regenerate.
2565
2566 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2567
2568 * configure: Regenerate.
2569 * configure.ac: Check for strerror_r.
2570 * gdbsupport/common-utils.h (safe_strerror): Change return value
2571 to const char * and document that this function is now threadsafe.
2572 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2573 thread_local and call strerror_r, if available.
2574 * utils.c (perror_string): Update.
2575 (print_sys_errmsg): Update.
2576
2577 2019-10-31 Luis Machado <luis.machado@linaro.org>
2578
2579 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2580 objfile_key.
2581 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2582 objfile to fetch per-bfd data.
2583 (arm_find_exidx_entry): Likewise.
2584
2585 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2586
2587 * gdbsupport/agent.c (debug_agent): Change type to bool.
2588 (use_agent): Likewise.
2589 (all_agent_symbols_look_up): Likewise.
2590 (agent_loaded_p): Change return value to bool.
2591 (agent_look_up_symbols): Update.
2592 (agent_capability_check): Change return value to bool.
2593 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2594 (debug_agent): Change type to bool.
2595 (use_agent): Likewise.
2596 (agent_capability_check): Change return value to bool.
2597
2598 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2599
2600 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2601 (build_minimal_symbol_hash_tables): Code to clear the table moved
2602 to clear_minimal_symbol_hash_tables.
2603 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2604 when needed.
2605
2606 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2607
2608 * infcmd.c: Remove includes.
2609 * infrun.c: Remove includes.
2610
2611 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2612
2613 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2614 (grow_vect): Remove declaration.
2615 (ada_type_of_array): Remove declaration.
2616 (ada_update_initial_language): Remove declaration.
2617 (ada_fold_name): Remove declaration.
2618 (ada_fill_in_ada_prototype): Remove declaration.
2619 (user_select_syms): Remove declaration.
2620 (get_selections): Remove declaration.
2621 (ada_tag_type): Remove declaration.
2622 (ada_value_tag): Remove declaration.
2623 (ada_is_others_clause): Remove declaration.
2624 (ada_in_variant): Remove declaration.
2625 (ada_value_struct_elt): Remove declaration.
2626 (ada_attribute_name): Remove declaration.
2627 (ada_system_address_type): Remove declaration.
2628 * ada-lang.c (ada_watch_location_expression): Make static.
2629 (GROW_VECT): Move here from ada-lang.h.
2630 (grow_vect): Make static.
2631 (ada_update_initial_language): Make static.
2632 (ada_fold_name): Make static.
2633 (ada_type_of_array): Make static.
2634 (encoded_ordered_before): Move up.
2635 (sort_choices): Move up.
2636 (print_signatures): Move up.
2637 (ada_print_symbol_signature): Move up.
2638 (get_selections): Move up and make static.
2639 (user_select_syms): Move up and make static.
2640 (ada_value_struct_elt): Move up and make static.
2641 (ada_tag_type): Make static.
2642 (ada_value_tag): Make static.
2643 (ada_is_others_clause): Make static.
2644 (ada_in_variant): Make static.
2645 (ada_attribute_name): Make static.
2646
2647 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2648
2649 * ada-lang.c: Remove includes.
2650 * ada-typeprint.c: Remove includes.
2651 * ada-valprint.c: Remove includes.
2652
2653 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2654
2655 * addrmap.c: Add static assertions of type size, moved from
2656 _initialize_addrmap.
2657 (_initialize_addrmap): Remove.
2658
2659 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2660
2661 * coffread.c (record_minimal_symbol): Update.
2662 (process_coff_symbol): Update.
2663 * dbxread.c (read_dbx_symtab): Update.
2664 * dwarf2read.c (add_partial_symbol): Update.
2665 (fixup_go_packaging): Update.
2666 (load_partial_dies): Update.
2667 (new_symbol): Update.
2668 * elfread.c (record_minimal_symbol): Change signature to use
2669 gdb::string_view instead of name+len.
2670 (elf_symtab_read): Update.
2671 (elf_rel_plt_read): Update.
2672 * mdebugread.c (parse_partial_symbols): Update.
2673 (handle_psymbol_enumerators): Update.
2674 (new_symbol): Update.
2675 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2676 to use gdb::string_view instead of name+len.
2677 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2678 * psympriv.h (add_psymbol_to_list): Likewise.
2679 * psymtab.c (add_psymbol_to_bcache): Likewise.
2680 (add_psymbol_to_list): Likewise.
2681 * stabsread.c (define_symbol): Update.
2682 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2683 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2684 (symbol_set_names): Likewise.
2685 * xcoffread.c (scan_xcoff_symtab): Update.
2686
2687 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2688
2689 * symtab.h (symbol_set_names): Document that copy_name must be
2690 set to true for non-nullterminated strings.
2691 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2692 linkage_name if the entry was not found and we need to demangle.
2693
2694 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2695
2696 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2697 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2698 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2699 * gdbsupport/gdb_binary_search.h: New file.
2700
2701 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2702
2703 * NEWS: Mention new --with-system-gdbinit-dir option.
2704 * config.in: Regenerate.
2705 * configure: Regenerate.
2706 * configure.ac: Add new option --with-system-gdbinit-dir.
2707 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2708 for a ".gdb" suffix.
2709 * main.c (get_init_files): Change system_gdbinit argument to
2710 a vector and return the files in SYSTEM_GDBINIT_DIR in
2711 addition to SYSTEM_GDBINIT.
2712 (captured_main_1): Update.
2713 (print_gdb_help): Update.
2714 * top.c (print_gdb_configuration): Also print the value of
2715 SYSTEM_GDBINIT_DIR.
2716
2717 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2718
2719 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2720 that takes gdb::string_view arguments.
2721
2722 2019-10-26 Tom de Vries <tdevries@suse.de>
2723
2724 * aarch64-linux-tdep.c: Fix typos in comments.
2725 * aarch64-tdep.c: Same.
2726 * ada-lang.c: Same.
2727 * amd64-nat.c: Same.
2728 * arc-tdep.c: Same.
2729 * arch/aarch64-insn.c: Same.
2730 * block.c: Same.
2731 * breakpoint.h: Same.
2732 * btrace.h: Same.
2733 * c-varobj.c: Same.
2734 * cli/cli-decode.c: Same.
2735 * cli/cli-script.c: Same.
2736 * cli/cli-utils.h: Same.
2737 * coff-pe-read.c: Same.
2738 * coffread.c: Same.
2739 * compile/compile-cplus-symbols.c: Same.
2740 * compile/compile-object-run.c: Same.
2741 * completer.c: Same.
2742 * corelow.c: Same.
2743 * cp-support.c: Same.
2744 * demangle.c: Same.
2745 * dwarf-index-write.c: Same.
2746 * dwarf2-frame.c: Same.
2747 * dwarf2-frame.h: Same.
2748 * eval.c: Same.
2749 * frame-base.h: Same.
2750 * frame.h: Same.
2751 * gdbcmd.h: Same.
2752 * gdbtypes.h: Same.
2753 * gnu-nat.c: Same.
2754 * guile/scm-objfile.c: Same.
2755 * i386-tdep.c: Same.
2756 * i386-tdep.h: Same.
2757 * infcall.c: Same.
2758 * infcall.h: Same.
2759 * linux-nat.c: Same.
2760 * m68k-tdep.c: Same.
2761 * macroexp.c: Same.
2762 * memattr.c: Same.
2763 * mi/mi-cmd-disas.c: Same.
2764 * mi/mi-getopt.h: Same.
2765 * mi/mi-main.c: Same.
2766 * minsyms.c: Same.
2767 * nat/aarch64-sve-linux-sigcontext.h: Same.
2768 * objfiles.h: Same.
2769 * ppc-linux-nat.c: Same.
2770 * ppc-linux-tdep.c: Same.
2771 * ppc-tdep.h: Same.
2772 * progspace.h: Same.
2773 * prologue-value.h: Same.
2774 * python/py-evtregistry.c: Same.
2775 * python/py-instruction.h: Same.
2776 * record-btrace.c: Same.
2777 * record-full.c: Same.
2778 * remote.c: Same.
2779 * rs6000-tdep.c: Same.
2780 * ser-tcp.c: Same.
2781 * sol-thread.c: Same.
2782 * sparc-sol2-tdep.c: Same.
2783 * sparc64-tdep.c: Same.
2784 * stabsread.c: Same.
2785 * symfile.c: Same.
2786 * symtab.h: Same.
2787 * target.c: Same.
2788 * tracepoint.c: Same.
2789 * tui/tui-data.h: Same.
2790 * tui/tui-io.c: Same.
2791 * tui/tui-win.c: Same.
2792 * tui/tui.c: Same.
2793 * unittests/rsp-low-selftests.c: Same.
2794 * user-regs.h: Same.
2795 * utils.c: Same.
2796 * utils.h: Same.
2797 * valarith.c: Same.
2798 * valops.c: Same.
2799 * valprint.c: Same.
2800 * valprint.h: Same.
2801 * value.c: Same.
2802 * value.h: Same.
2803 * varobj.c: Same.
2804 * x86-nat.h: Same.
2805 * xtensa-tdep.c: Same.
2806
2807 2019-10-25 Ali Tamur <tamur@google.com>
2808
2809 * charset.c (find_charset_names): Reflect API change.
2810
2811 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2812
2813 * symtab.c (struct demangled_name_entry): Change demangled name
2814 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2815 part of the struct anymore.
2816 (symbol_set_names): No longer obstack allocate + copy the demangled
2817 name, just store the allocated name from bfd.
2818
2819 2019-10-25 Tom Tromey <tromey@adacore.com>
2820
2821 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2822 (bsearch_cie_cmp, add_cie): Remove.
2823 (find_cie): Reimplement.
2824 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2825 (dwarf2_build_frame_info): Update.
2826
2827 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2828
2829 PR gdb/25126
2830 * symfile.c (reread_symbols): Call forget_cached_source_info to
2831 clear the stale source cache.
2832
2833 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2834
2835 * configure: Regenerate.
2836 * configure.ac: Remove code that sets python_has_threads.
2837
2838 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2839
2840 * config.in: Regenerate.
2841 * configure: Regenerate.
2842 * configure.ac: Remove the code that uses sed to get the python
2843 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2844
2845 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2846
2847 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2848 error paths.
2849
2850 2019-10-23 Tom Tromey <tom@tromey.com>
2851
2852 * arc-tdep.c: Remove ".." from include.
2853 * frv-tdep.c: Remove ".." from include.
2854 * lm32-tdep.c: Remove ".." from include.
2855 * microblaze-tdep.c: Remove ".." from include.
2856 * or1k-tdep.h: Remove ".." from include.
2857 * s12z-tdep.c: Remove ".." from include.
2858 * Makefile.in (OPCODES_CFLAGS): Add comment.
2859 (TOP_CFLAGS): New variable.
2860 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2861
2862 2019-10-23 Tom Tromey <tom@tromey.com>
2863
2864 * Makefile.in (READLINE_DIR): Update.
2865
2866 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2867
2868 * infcall.c (call_function_by_hand_dummy): Fix the function
2869 comment. And extract out a code section into...
2870 (reserve_stack_space): ...this new function.
2871
2872 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2873
2874 * infcall.c (value_arg_coerce): Remove an unused parameter.
2875 (call_function_by_hand_dummy): Update the call to
2876 'value_arg_coerce'.
2877
2878 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2879
2880 * infcall.c (call_function_by_hand_dummy): Refactor.
2881
2882 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2883
2884 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2885
2886 2019-10-23 Tom Tromey <tom@tromey.com>
2887
2888 * configure: Rebuild.
2889 * configure.ac: Don't check for sigprocmask.
2890 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2891
2892 2019-10-23 Tom Tromey <tom@tromey.com>
2893
2894 * configure: Rebuild.
2895 * acinclude.m4: Use m4_include, not sinclude.
2896
2897 2019-10-23 Tom de Vries <tdevries@suse.de>
2898
2899 PR breakpoints/24687
2900 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2901
2902 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2903
2904 * symtab.c (struct demangled_name_entry) <language>: Change from
2905 bitfield to regular variable.
2906
2907 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2908
2909 * symtab.c (struct demangled_name_entry): Add a constructor.
2910 (free_demangled_name_entry): New function to call the destructor
2911 for demangled_name_entry.
2912 (create_demangled_names_hash): Pass free_demangled_name_entry to
2913 htab_create_alloc.
2914 (symbol_set_names): Call placement new for demangled_name_entry.
2915 * utils.c: No longer include xxhash.h here, now that fast_hash
2916 is inlined in the header.
2917 * utils.h: Instead, include it here.
2918
2919 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2920
2921 * Makefile.in: Link with libxxhash.
2922 * config.in: Regenerate.
2923 * configure: Regenerate.
2924 * configure.ac: Search for libxxhash.
2925 * utils.c (fast_hash): Use xxhash if present.
2926
2927 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2928
2929 * utils.h (fast_hash): New function.
2930 * symtab.c (hash_demangled_name_entry): Call new function
2931 fast_hash.
2932
2933 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2934
2935 * symtab.c (struct demangled_name_entry): Change type of mangled
2936 to gdb::string_view. Also adds a constructor that takes the
2937 mangled name.
2938 (hash_demangled_name_entry): Update.
2939 (eq_demangled_name_entry): Update.
2940 (free_demangled_name_entry): New function to call the destructor
2941 now that this is not a POD anymore.
2942 (create_demangled_names_hash): Pass free_demangled_name_entry to
2943 htab_create_alloc.
2944 (symbol_set_names): Update.
2945
2946 2019-10-21 Ali Tamur <tamu@google.com>
2947
2948 * dwarf2read.c (dir_index): Change type.
2949 (file_name_index): Likewise.
2950 (line_header::include_dir_at): Change comment and implementation on
2951 whether it is DWARF 5.
2952 (line_header::is_valid_file_index): New function.
2953 (line_header::file_name_at): Change comment and implementation on
2954 whether it is DWARF 5.
2955 (line_header::file_names): Change to private field renamed as
2956 m_file_names and introduce a new accessor method.
2957 (line_header::file_names_size): New method.
2958 (line_header::include_dirs): Change to private field and rename as
2959 m_include_dirs.
2960 (dw2_get_file_names_reader): Define local var at a smaller scope and
2961 reflect API change.
2962 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2963 (process_structure_scope): Likewise.
2964 (line_header::add_include_dir): Change message and reflect renaming.
2965 (line_header::add_file_name): Likewise.
2966 (read_formatted_entries): Handle DW_FORM_data16.
2967 (dwarf_decode_line_header): Fix line header length calculation.
2968 (psymtab_include_file_name): Change comment and API.
2969 (lnp_state_machine::m_file): Update comment and reflect type change.
2970 (lnp_state_machine::record_line): Reflect type change.
2971 (dwarf_decode_lines): Reflect API change.
2972 (file_file_name): Likewise.
2973 (file_full_name): Likewise.
2974
2975 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2976
2977 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2978
2979 2019-10-21 Tom Tromey <tom@tromey.com>
2980
2981 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2982
2983 2019-10-21 Tom Tromey <tom@tromey.com>
2984
2985 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2986 NM_H. Use AC_CONFIG_LINKS.
2987 * configure: Rebuild.
2988 * Makefile.in (NM_H): New variable.
2989 (generated_files): Add NM_H. Remove gcore.
2990 (nm.h, stamp-nmh): New targets.
2991
2992 2019-10-20 Tom Tromey <tom@tromey.com>
2993
2994 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2995 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2996 obsolete comment.
2997 (put_objfile_before): Now static.
2998
2999 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3000
3001 * gdbsupport/common-utils.h (startswith): Change return type to
3002 bool.
3003
3004 2019-10-19 Christian Biesinger <cbiesinger@google.com>
3005
3006 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3007 * breakpoint.c (bp_locations_compare): Rename to...
3008 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3009 (update_global_location_list): Use std::sort instead of qsort.
3010 * buildsym.c (compare_line_numbers): Rename to...
3011 (lte_is_less_than): ...this, and change to std::sort semantics.
3012 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3013 instead of qsort.
3014 * disasm.c (compare_lines): Rename to...
3015 (line_is_less_than): ...this, and change to std::sort semantics.
3016 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3017 of qsort.
3018 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3019 (fde_is_less_than): ...this, and change to std::sort semantics.
3020 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3021 * mdebugread.c (compare_blocks):
3022 (block_is_less_than): ...this, and change to std::sort semantics.
3023 (sort_blocks): Call std::sort instead of qsort.
3024 * objfiles.c (qsort_cmp): Rename to...
3025 (sort_cmp): ...this, and change to std::sort semantics.
3026 (update_section_map): Call std::sort instead of qsort.
3027 * remote.c (compare_pnums): Remove.
3028 (map_regcache_remote_table): Call std::sort instead of qsort.
3029 * utils.c (compare_positive_ints): Remove.
3030 * utils.h (compare_positive_ints): Remove.
3031 * xcoffread.c (compare_lte): Remove.
3032 (arrange_linetable): Call std::sort instead of qsort.
3033
3034 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3035
3036 * symfile.c (init_entry_point_info): Fix typo.
3037 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3038
3039 2019-10-18 Tom de Vries <tdevries@suse.de>
3040
3041 * aarch64-tdep.c: Fix typos in comments.
3042 * ada-lang.c: Same.
3043 * ada-tasks.c: Same.
3044 * alpha-tdep.c: Same.
3045 * alpha-tdep.h: Same.
3046 * amd64-nat.c: Same.
3047 * amd64-windows-tdep.c: Same.
3048 * arc-tdep.c: Same.
3049 * arc-tdep.h: Same.
3050 * arch-utils.c: Same.
3051 * arm-nbsd-tdep.c: Same.
3052 * arm-tdep.c: Same.
3053 * ax-gdb.c: Same.
3054 * blockframe.c: Same.
3055 * btrace.c: Same.
3056 * c-varobj.c: Same.
3057 * coff-pe-read.c: Same.
3058 * coffread.c: Same.
3059 * cris-tdep.c: Same.
3060 * darwin-nat.c: Same.
3061 * dbxread.c: Same.
3062 * dcache.c: Same.
3063 * disasm.c: Same.
3064 * dtrace-probe.c: Same.
3065 * dwarf-index-write.c: Same.
3066 * dwarf2-frame-tailcall.c: Same.
3067 * dwarf2-frame.c: Same.
3068 * dwarf2read.c: Same.
3069 * eval.c: Same.
3070 * exceptions.c: Same.
3071 * fbsd-tdep.c: Same.
3072 * findvar.c: Same.
3073 * frame.c: Same.
3074 * frv-tdep.c: Same.
3075 * gnu-v3-abi.c: Same.
3076 * go32-nat.c: Same.
3077 * h8300-tdep.c: Same.
3078 * hppa-tdep.c: Same.
3079 * i386-linux-tdep.c: Same.
3080 * i386-tdep.c: Same.
3081 * ia64-libunwind-tdep.c: Same.
3082 * ia64-tdep.c: Same.
3083 * infcmd.c: Same.
3084 * infrun.c: Same.
3085 * linespec.c: Same.
3086 * linux-nat.c: Same.
3087 * linux-thread-db.c: Same.
3088 * machoread.c: Same.
3089 * mdebugread.c: Same.
3090 * mep-tdep.c: Same.
3091 * mn10300-tdep.c: Same.
3092 * namespace.c: Same.
3093 * objfiles.c: Same.
3094 * opencl-lang.c: Same.
3095 * or1k-tdep.c: Same.
3096 * osabi.c: Same.
3097 * ppc-linux-nat.c: Same.
3098 * ppc-linux-tdep.c: Same.
3099 * ppc-sysv-tdep.c: Same.
3100 * printcmd.c: Same.
3101 * procfs.c: Same.
3102 * record-btrace.c: Same.
3103 * record-full.c: Same.
3104 * remote-fileio.c: Same.
3105 * remote.c: Same.
3106 * rs6000-tdep.c: Same.
3107 * s12z-tdep.c: Same.
3108 * score-tdep.c: Same.
3109 * ser-base.c: Same.
3110 * ser-go32.c: Same.
3111 * skip.c: Same.
3112 * sol-thread.c: Same.
3113 * solib-svr4.c: Same.
3114 * solib.c: Same.
3115 * source.c: Same.
3116 * sparc-nat.c: Same.
3117 * sparc-sol2-tdep.c: Same.
3118 * sparc-tdep.c: Same.
3119 * sparc64-tdep.c: Same.
3120 * stabsread.c: Same.
3121 * stack.c: Same.
3122 * symfile.c: Same.
3123 * symtab.c: Same.
3124 * target-descriptions.c: Same.
3125 * target-float.c: Same.
3126 * thread.c: Same.
3127 * utils.c: Same.
3128 * valops.c: Same.
3129 * valprint.c: Same.
3130 * value.c: Same.
3131 * varobj.c: Same.
3132 * windows-nat.c: Same.
3133 * xcoffread.c: Same.
3134 * xstormy16-tdep.c: Same.
3135 * xtensa-tdep.c: Same.
3136
3137 2019-10-17 Tom Tromey <tromey@adacore.com>
3138
3139 * configure: Rebuild.
3140 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3141 in AC_CONFIG_FILES invocation.
3142 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3143 new-style config.status invocation.
3144
3145 2019-10-17 Tom de Vries <tdevries@suse.de>
3146
3147 * arm-nbsd-nat.c: Fix typos in comments.
3148 * arm-tdep.c: Same.
3149 * darwin-nat-info.c: Same.
3150 * dwarf2read.c: Same.
3151 * elfread.c: Same.
3152 * event-top.c: Same.
3153 * findvar.c: Same.
3154 * gdbtypes.c: Same.
3155 * hppa-tdep.c: Same.
3156 * i386-tdep.c: Same.
3157 * jit.c: Same.
3158 * main.c: Same.
3159 * mdebugread.c: Same.
3160 * moxie-tdep.c: Same.
3161 * nto-procfs.c: Same.
3162 * osabi.c: Same.
3163 * ppc-linux-tdep.c: Same.
3164 * remote.c: Same.
3165 * riscv-tdep.c: Same.
3166 * s390-tdep.c: Same.
3167 * sh-tdep.c: Same.
3168 * sparc-linux-tdep.c: Same.
3169 * sparc-nat.c: Same.
3170 * stack.c: Same.
3171 * target-descriptions.c: Same.
3172 * top.c: Same.
3173 * varobj.c: Same.
3174
3175 2019-10-16 Tom Tromey <tom@tromey.com>
3176
3177 * objfiles.h (struct objfile) <original_name>: Now const.
3178
3179 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3180
3181 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3182 pass on to sigsetjmp's second argument.
3183 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3184
3185 2019-10-16 Keith Seitz <keiths@redhat.com>
3186
3187 PR gdb/23567
3188 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3189 sections whose size is greater than the file size.
3190
3191 2019-10-16 Jim Wilson <jimw@sifive.com>
3192
3193 * riscv-tdep.c (riscv_gcc_target_options): New.
3194 (riscv_gnu_triplet_regexp): New.
3195 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3196 set_gdbarch_gnu_triplet_regexp.
3197
3198 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3199
3200 * Makefile.in: Add xml-builtin.h.
3201 * features/feature_to_c.sh: Add an include for xml-builtin.h
3202 to ensure that the compiler checks that the types match.
3203 * xml-builtin.h: New file.
3204 * xml-support.c (fetch_xml_builtin): Add missing const.
3205 * xml-support.h: Remove declaration of xml_builtins.
3206
3207 2019-10-16 Tom de Vries <tdevries@suse.de>
3208
3209 PR tdep/25096
3210 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3211 (amd64_classify_aggregate): ... here.
3212 (amd64_classify_aggregate_field): Handled fiels of nested structs
3213 recursively.
3214
3215 2019-10-16 Tom de Vries <tdevries@suse.de>
3216
3217 PR tdep/24104
3218 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3219 that handles 'theclass'.
3220
3221 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3222
3223 * linespec.c (decode_digits_ordinary): Update comment.
3224 * make-target-delegates: No longer need to handle VEC case.
3225 * memrange.c (normalize_mem_ranges): Update comment.
3226 * namespace.c (add_using_directive): Update comment.
3227 * objc-lang.c (uniquify_strings): Update comment.
3228 * ppc-linux-nat.c (struct thread_points): Update comment.
3229 * probe.h (find_probes_in_objfile): Update comment.
3230 * target.h (enum flash_preserve_mode): Update comment.
3231 * varobj.c (varobj_restrict_range): Update comment.
3232 * varobj.h (varobj_list_children): Update comment.
3233
3234 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3235
3236 * Makefile.in: Remove references to vec.h and vec.c.
3237 * aarch64-tdep.c: No longer include vec.h.
3238 * ada-lang.c: Likewise.
3239 * ada-lang.h: Likewise.
3240 * arm-tdep.c: Likewise.
3241 * ax.h: Likewise.
3242 * breakpoint.h: Likewise.
3243 * charset.c: Likewise.
3244 * cp-support.h: Likewise.
3245 * dtrace-probe.c: Likewise.
3246 * dwarf2read.c: Likewise.
3247 * extension.h: Likewise.
3248 * gdb_bfd.c: Likewise.
3249 * gdbsupport/gdb_vecs.h: Likewise.
3250 * gdbsupport/vec.c: Remove.
3251 * gdbsupport/vec.h: Remove.
3252 * gdbthread.h: Likewise.
3253 * guile/scm-type.c: Likewise.
3254 * inline-frame.c: Likewise.
3255 * machoread.c: Likewise.
3256 * memattr.c: Likewise.
3257 * memrange.h: Likewise.
3258 * namespace.h: Likewise.
3259 * nat/linux-btrace.h: Likewise.
3260 * osdata.c: Likewise.
3261 * parser-defs.h: Likewise.
3262 * progspace.h: Likewise.
3263 * python/py-type.c: Likewise.
3264 * record-btrace.c: Likewise.
3265 * rust-exp.y: Likewise.
3266 * solib-target.c: Likewise.
3267 * stap-probe.c: Likewise.
3268 * target-descriptions.c: Likewise.
3269 * target-memory.c: Likewise.
3270 * target.h: Likewise.
3271 * varobj.c: Likewise.
3272 * varobj.h: Likewise.
3273 * xml-support.h: Likewise.
3274
3275 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3276
3277 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3278 Update for new std::vector based implementation.
3279 (process_psymtab_comp_unit_reader): Likewise.
3280 (scan_partial_symbols): Likewise.
3281 (recursively_compute_inclusions): Likewise.
3282 (compute_compunit_symtab_includes): Likewise.
3283 (process_imported_unit_die): Likewise.
3284 (queue_and_load_dwo_tu): Likewise.
3285 (follow_die_sig_1): Likewise.
3286 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3287 (typedef dwarf2_per_cu_ptr): Remove.
3288 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3289 function.
3290 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3291 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3292 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3293 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3294 std::vector.
3295
3296 2019-10-15 Tom Tromey <tromey@adacore.com>
3297
3298 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3299 TID.
3300
3301 2019-10-15 Tom Tromey <tromey@adacore.com>
3302
3303 * windows-nat.c (windows_nat_target::fetch_registers)
3304 (windows_nat_target::store_registers): Rename "pid" to "tid".
3305
3306 2019-10-15 Tom Tromey <tromey@adacore.com>
3307
3308 * gdbarch.h, gdbarch.c: Rebuild.
3309 * gdbarch.sh (gcc_target_options): Change return type to
3310 std::string.
3311 * compile/compile.c (get_args): Update.
3312 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3313 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3314 std::string.
3315 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3316 std::string.
3317 * arch-utils.c (default_gcc_target_options): Return std::string.
3318 * arch-utils.h (default_gcc_target_options): Return std::string.
3319 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3320
3321 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3322
3323 * breakpoint.c (breakpoint_chain): Make static.
3324 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3325 of accessing breakpoint_chain.
3326
3327 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3328
3329 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3330 to a gdb::function_view and return value to bool.
3331 * breakpoint.h (iterate_over_breakpoints): Likewise.
3332 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3333 (pop_dummy_frame): Update.
3334 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3335 (gdbscm_breakpoints): Update.
3336 * python/py-breakpoint.c (build_bp_list): Update.
3337 (gdbpy_breakpoints): Update.
3338 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3339 Update.
3340 (bpfinishpy_handle_stop): Update.
3341 (bpfinishpy_handle_exit): Update.
3342 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3343 (svr4_update_solib_event_breakpoints): Update.
3344
3345 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3346
3347 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3348 when unwrapping single-field structs.
3349
3350 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3351
3352 * dwarf2read.c: Remove includes.
3353
3354 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3355
3356 * ui-out.c (ui_out::call_do_message): Silence
3357 -Wformat-nonliteral warning.
3358
3359 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3360
3361 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3362 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3363 include: readline/tilde.h.
3364
3365 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3366
3367 * remote.c (remote_target::get_trace_status): Remove declaration of
3368 trace_regblock_size.
3369
3370 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3371
3372 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3373 (show_user): Remove declaration of cmdlist.
3374 * cli/cli-cmds.h (max_user_call_depth): Declare.
3375 * cli/cli-script.c (execute_user_command): Remove declaration
3376 of max_user_call_depth.
3377
3378 2019-10-11 Jim Wilson <jimw@sifive.com>
3379
3380 * gdbsupport/print-utils.h (pulongest): Fix comment.
3381 (plongest): Likewise.
3382 (phex): Add missing comment, mention leading zeros.
3383 (phex_nz): Add mention of no leading zeros to comment.
3384
3385 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3386 plongest instead of unsigned long long cast.
3387
3388 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3389
3390 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3391 for external_editor_command and gdbtk_test.
3392
3393 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3394
3395 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3396 * varobj.c (varobjdebug): Move comment to...
3397 * varobj.h (varobjdebug): ...here, and declare.
3398
3399 2019-10-09 Tom Tromey <tom@tromey.com>
3400
3401 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3402 erase_data_content.
3403
3404 2019-10-09 Tom Tromey <tom@tromey.com>
3405
3406 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3407 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3408 * tui/tui-command.c (tui_cmd_window::resize)
3409 (tui_refresh_cmd_win): Update.
3410 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3411 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3412 * tui/tui-data.c (~tui_gen_win_info): Remove.
3413 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3414 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3415 (tui_redisplay_readline, tui_mld_flush)
3416 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3417 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3418 (tui_data_window::erase_data_content)
3419 (tui_data_item_window::rerender)
3420 (tui_data_item_window::refresh_window): Update.
3421 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3422 (box_win, tui_gen_win_info::make_window)
3423 (tui_gen_win_info::make_visible): Update.
3424 (tui_delete_win): Remove.
3425 * tui/tui-winsource.c
3426 (tui_source_window_base::do_erase_source_content): Update.
3427 (tui_show_source_line, tui_source_window_base::update_tab_width)
3428 (tui_source_window_base::update_exec_info): Update.
3429 * tui/tui-data.h (struct curses_deleter): New.
3430 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3431 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3432
3433 2019-10-09 Tom Tromey <tom@tromey.com>
3434
3435 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3436
3437 2019-10-09 Tom Tromey <tom@tromey.com>
3438
3439 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3440 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3441
3442 2019-10-09 Tom Tromey <tom@tromey.com>
3443
3444 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3445 window height directly.
3446 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3447 declare.
3448 * tui/tui-layout.c (tui_default_win_height): Remove.
3449 (tui_default_win_viewport_height): Remove.
3450
3451 2019-10-09 Tom Tromey <tom@tromey.com>
3452
3453 * tui/tui.h: Remove comments.
3454
3455 2019-10-09 Tom de Vries <tdevries@suse.de>
3456
3457 * python/lib/gdb/printer/bound_registers.py: Use
3458 '^builtin_type_bound128' as regexp argument for
3459 add_builtin_pretty_printer.
3460
3461 2019-10-09 Christian Biesinger <cbiesinger@google.com>
3462
3463 * guile/guile.c (guile_extension_script_ops): Remove forward
3464 declaration and mark as static.
3465 (guile_script_ops): Likewise.
3466 (extension_language_guile): Move further down in the file so
3467 it can reference the definitions for guile_{extension_,}script_ops.
3468
3469 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3470
3471 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3472 except SORTL, DFLTCC, and KDSA.
3473
3474 2019-10-08 Tom Tromey <tromey@adacore.com>
3475
3476 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3477 (struct safe_symbol_file_add_args): Remove.
3478
3479 2019-10-08 Tom Tromey <tromey@adacore.com>
3480
3481 * windows-nat.c: Don't include buildsym-legacy.h.
3482
3483 2019-10-08 Tom Tromey <tromey@adacore.com>
3484
3485 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3486
3487 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3488
3489 * gdbtypes.c (overload_debug): Move comment to header.
3490 * gdbtypes.h (overload_debug): Declare.
3491 * valops.c: Remove declaration of overload_debug, instead
3492 include gdbtypes.h.
3493
3494 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3495
3496 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3497 through _().
3498 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3499 move comment...
3500 * language.h (lang_frame_mismatch_warn): ... here. Also add
3501 declaration.
3502 * top.c (lang_frame_mismatch_warn): Remove declaration.
3503 (check_frame_language_change): Pass lang_frame_mismatch_warn
3504 through _().
3505
3506 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3507
3508 * c-lang.h (vtbl_ptr_name): Declare.
3509 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3510 it from the header.
3511 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3512
3513 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3514
3515 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3516 gdb_static_assert.
3517
3518 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3519
3520 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3521 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3522 * ctfread.c: New file.
3523 * ctfread.h: New file.
3524 * elfread.c: Include ctfread.h.
3525 (struct elfinfo text_p): New member ctfsect.
3526 (elf_locate_sections): Mark CTF section.
3527 (elf_symfile_read): Call elfctf_build_psymtabs.
3528 * Makefile.in (LIBCTF): Add.
3529 (CLIBS): Use it.
3530 (CDEPS): Likewise.
3531 (DIST): Add ctfread.c.
3532
3533 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3534
3535 * ctfread.c (struct nextfield): Renamed to ...
3536 (struct ctf_nextfield): ... this.
3537 (struct field_info): Renamed to ...
3538 (strut ctf_field_info): ... this.
3539 (attach_fields_to_type): Update for renamed structures.
3540 (ctf_add_member_cb): Likewise.
3541 (ctf_add_enum_member_cb): Likewise.
3542 (process_struct_members): Likewise.
3543 (process_enum_type): Likewise.
3544
3545 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3546
3547 * tracectf.h: Rename, was ctf.h.
3548 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3549 * tracefile.c: Likewise.
3550 * tracepoint.c: Remove unused include ctf.h.
3551 * mi/mi-main.c: Likewise.
3552 * Makefile.in Replace ctf.c with tracectf.c.
3553
3554 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3555
3556 * version.in: Change version number to "9.0.50.DATE-git".
3557
3558 2019-10-03 Tom Tromey <tom@tromey.com>
3559
3560 PR rust/24976:
3561 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3562
3563 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3564
3565 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3566 cp_search_name_hash.
3567 * NEWS: Add entry about nested function support.
3568
3569 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3570 Andrew Burgess <andrew.burgess@embecosm.com>
3571
3572 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3573 for nested static variables when searchin VAR_DOMAIN.
3574 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3575 global scope, update comment.
3576 (add_partial_subprogram): Call add_partial_subprogram recursively
3577 for nested subroutines when processinng Fortran.
3578 (load_partial_dies): Process the child entities of a subprogram
3579 when processing Fortran.
3580 (partial_die_parent_scope): Handle building scope
3581 for Fortran nested functions.
3582 (process_die): Record that nested functions have a scope.
3583 (new_symbol): Always record Fortran subprograms on the global
3584 symbol list.
3585 (determine_prefix): How to build the prefix for Fortran
3586 subprograms.
3587
3588 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3589
3590 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3591 have just sent the thread a SIGSTOP and are waiting for it to
3592 arrive.
3593
3594 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3595
3596 * btrace.c (btrace_add_pc): Remove whitespace before the template
3597 parameter in 'std::vector <...>'.
3598 (parse_xml_btrace_block): Likewise.
3599 (btrace_maint_decode_pt): Likewise.
3600 (btrace_maint_update_packets): Likewise.
3601 (btrace_maint_print_packets): Likewise.
3602 * btrace.h (struct btrace_maint_info): Likewise.
3603 * dwarf2read.c (struct type_unit_group): Likewise.
3604 (build_type_psymtabs_reader): Likewise.
3605 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3606 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3607 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3608
3609 2019-10-03 Tom de Vries <tdevries@suse.de>
3610
3611 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3612 the first line of the help text for set/show style metadata.
3613
3614 2019-10-02 Tom Tromey <tromey@adacore.com>
3615
3616 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3617 * gdbsupport/common-inferior.c: New file.
3618 * infcmd.c (startup_with_shell): Don't define.
3619 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3620 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3621 * inferior.h (startup_with_shell): Don't declare.
3622
3623 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3624
3625 * gdbsupport/gdb_assert.h: Include errors.h.
3626 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3627
3628 2019-10-02 Tom Tromey <tromey@adacore.com>
3629
3630 * NEWS: Add $_ada_exception entry.
3631 * ada-lang.c (struct ada_catchpoint): Add constructor.
3632 <m_kind>: New member.
3633 (allocate_location_exception, re_set_exception): Remove
3634 "ex" parameter.
3635 (should_stop_exception): Compute $_ada_exception.
3636 (check_status_exception, print_it_exception)
3637 (print_one_exception, print_mention_exception): Remove
3638 "ex" parameter.
3639 (allocate_location_catch_exception, re_set_catch_exception)
3640 (check_status_exception, print_it_catch_exception)
3641 (print_one_catch_exception, print_mention_catch_exception)
3642 (print_recreate_catch_exception)
3643 (allocate_location_catch_exception_unhandled)
3644 (re_set_catch_exception_unhandled)
3645 (check_status_exception, print_it_catch_exception_unhandled)
3646 (print_one_catch_exception_unhandled)
3647 (print_mention_catch_exception_unhandled)
3648 (print_recreate_catch_exception_unhandled)
3649 (allocate_location_catch_assert, re_set_catch_assert)
3650 (check_status_assert, print_it_catch_assert)
3651 (print_one_catch_assert, print_mention_catch_assert)
3652 (print_recreate_catch_assert)
3653 (allocate_location_catch_handlers, re_set_catch_handlers)
3654 (check_status_handlers, print_it_catch_handlers)
3655 (print_one_catch_handlers, print_mention_catch_handlers)
3656 (print_recreate_catch_handlers): Remove.
3657 (create_ada_exception_catchpoint): Update.
3658 (initialize_ada_catchpoint_ops): Update.
3659
3660 2019-10-02 Tom Tromey <tromey@adacore.com>
3661
3662 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3663 (create_excep_cond_exprs): Simplify exception string computation.
3664 (ada_exception_catchpoint_cond_string): Likewise.
3665
3666 2019-10-02 Tom Tromey <tromey@adacore.com>
3667
3668 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3669 * ada-lang.c (lesseq_defined_than): Handle
3670 LOC_STATIC.
3671 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3672 parameter.
3673 (dwarf2_has_info): Likewise.
3674 (new_symbol): Set maybe_copied on symbol when
3675 appropriate.
3676 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3677 parameter.
3678 <can_copy>: New member.
3679 * elfread.c (record_minimal_symbol): Set maybe_copied
3680 on symbol when appropriate.
3681 (elf_symfile_read): Update call to dwarf2_has_info.
3682 * minsyms.c (lookup_minimal_symbol_linkage): New
3683 function.
3684 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3685 * symtab.c (get_symbol_address, get_msymbol_address):
3686 New functions.
3687 * symtab.h (get_symbol_address, get_msymbol_address):
3688 Declare.
3689 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3690 maybe_copied.
3691 (struct symbol, struct minimal_symbol) <maybe_copied>:
3692 New member.
3693
3694 2019-10-02 Tom Tromey <tromey@adacore.com>
3695
3696 * source.c (struct current_source_location): New.
3697 (current_source_key): New global.
3698 (current_source_symtab, current_source_line)
3699 (current_source_pspace): Remove.
3700 (get_source_location): New function.
3701 (get_current_source_symtab_and_line)
3702 (set_default_source_symtab_and_line)
3703 (set_current_source_symtab_and_line)
3704 (clear_current_source_symtab_and_line, select_source_symtab)
3705 (info_source_command, print_source_lines_base)
3706 (info_line_command, search_command_helper, _initialize_source):
3707 Update.
3708
3709 2019-10-02 Tom Tromey <tromey@adacore.com>
3710
3711 * source.c (select_source_symtab): Don't call
3712 decode_line_with_current_source.
3713
3714 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3715
3716 * symtab.c (lookup_global_symbol): Search global block.
3717
3718 2019-10-02 Tom Tromey <tromey@adacore.com>
3719
3720 * coffread.c (process_coff_symbol): Update.
3721 * dwarf2read.c (var_decode_location, new_symbol): Update.
3722 * mdebugread.c (parse_symbol): Update.
3723 * objfiles.c (relocate_one_symbol): Update.
3724 * stabsread.c (define_symbol, fix_common_block)
3725 (scan_file_globals): Update.
3726 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3727 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3728 * xcoffread.c (process_xcoff_symbol): Update.
3729
3730 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3731
3732 * MAINTAINERS: Update my email address.
3733
3734 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3735
3736 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3737 std::vector.
3738 (build_type_psymtabs_reader): Update for std::vector.
3739 (build_type_psymtab_dependencies): Likewise.
3740 * dwarf2read.h: Remove use of DEF_VEC_P.
3741 (typedef sig_type_ptr): Delete.
3742
3743 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3744
3745 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3746 to std::vector.
3747 (btrace_maint_decode_pt): Likewise, and move allocation of the
3748 vector outside of the loop.
3749 (btrace_maint_update_packets): Update to handle change from VEC to
3750 std::vector.
3751 (btrace_maint_print_packets): Likewise.
3752 (maint_info_btrace_cmd): Likewise.
3753 * btrace.h: Remove use of DEF_VEC_O.
3754 (typedef btrace_pt_packet_s): Delete.
3755 (struct btrace_maint_info) <packets>: Change fromm VEC to
3756 std::vector.
3757 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3758
3759 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3760
3761 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3762 make accesses into the vector constant references.
3763 (btrace_add_pc): Update for std::vector.
3764 (btrace_stitch_bts): Likewise.
3765 (parse_xml_btrace_block): Likewise.
3766 (btrace_maint_update_packets): Likewise.
3767 (btrace_maint_print_packets): Likewise.
3768 (maint_info_btrace_cmd): Likewise.
3769 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3770 std::vector.
3771 (btrace_data::empty): Likewise.
3772 (btrace_data_append): Likewise.
3773 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3774 (typedef btrace_block_s): Delete.
3775 (struct btrace_block): Add constructor.
3776 (struct btrace_data_bts) <blocks>: Change to std::vector.
3777 * nat/linux-btrace.c (perf_event_read_bts): Update for
3778 std::vector.
3779 (linux_read_bts): Likewise.
3780
3781 2019-10-01 Tom Tromey <tom@tromey.com>
3782
3783 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3784
3785 2019-10-01 Tom Tromey <tom@tromey.com>
3786
3787 * stack.c (print_frame, info_frame_command_core): Use
3788 styled_string.
3789 * linux-thread-db.c (try_thread_db_load_1)
3790 (try_thread_db_load_from_pdir_1): Use styled_string.
3791 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3792 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3793 (maybe_print_unsupported_script_warning)
3794 (maybe_print_script_not_found_warning): Use styled_string.
3795 * ada-lang.c (user_select_syms): Use styled_string.
3796
3797 2019-10-01 Tom Tromey <tom@tromey.com>
3798
3799 * p-lang.c (pascal_printstr): Use metadata style.
3800 * value.c (show_convenience): Use metadata style.
3801 * valprint.c (valprint_check_validity, val_print_optimized_out)
3802 (val_print_not_saved, val_print_unavailable)
3803 (val_print_invalid_address, generic_val_print, val_print)
3804 (value_check_printable, val_print_array_elements): Use metadata
3805 style.
3806 * ui-out.h (class ui_out) <field_fmt>: New overload.
3807 <do_field_fmt>: Add style parameter.
3808 * ui-out.c (ui_out::field_fmt): New overload.
3809 * typeprint.c (type_print_unknown_return_type)
3810 (val_print_not_allocated, val_print_not_associated): Use metadata
3811 style.
3812 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3813 parameter.
3814 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3815 * tracepoint.c (tvariables_info_1): Use metadata style.
3816 * stack.c (print_frame_arg, print_frame_info, print_frame)
3817 (info_frame_command_core): Use metadata style.
3818 * skip.c (info_skip_command): Use metadata style.
3819 * rust-lang.c (rust_print_enum): Use metadata style.
3820 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3821 metadata style.
3822 * python/py-framefilter.c (py_print_single_arg): Use metadata
3823 style.
3824 * printcmd.c (do_one_display, print_variable_and_value): Use
3825 metadata style.
3826 * p-valprint.c (pascal_val_print)
3827 (pascal_object_print_value_fields): Use metadata style.
3828 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3829 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3830 parameter.
3831 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3832 * m2-valprint.c (m2_print_long_set): Use metadata style.
3833 * m2-typeprint.c (m2_print_type): Use metadata style.
3834 * infcmd.c (print_return_value_1): Use metadata style.
3835 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3836 * f-valprint.c (info_common_command_for_block): Use metadata
3837 style.
3838 * f-typeprint.c (f_type_print_base): Use metadata style.
3839 * expprint.c (print_subexp_standard): Use metadata style.
3840 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3841 * cli/cli-style.h (class cli_style_option): Add constructor.
3842 (metadata_style): Declare.
3843 * cli/cli-style.c (metadata_style): New global.
3844 (_initialize_cli_style): Register metadata style.
3845 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3846 parameter.
3847 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3848 * c-typeprint.c (c_type_print_base_struct_union)
3849 (c_type_print_base_1): Use metadata style.
3850 * breakpoint.c (watchpoint_value_print)
3851 (print_one_breakpoint_location): Use metadata style.
3852 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3853 style.
3854 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3855 style.
3856 * ada-valprint.c (val_print_packed_array_elements, printstr)
3857 (print_field_values, ada_val_print_ref, ada_val_print): Use
3858 metadata style.
3859 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3860 style.
3861 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3862 style.
3863 * ada-lang.c (user_select_syms): Use metadata style.
3864
3865 2019-10-01 Tom Tromey <tom@tromey.com>
3866
3867 * cli/cli-cmds.c (pwd_command): Style output.
3868
3869 2019-10-01 Pedro Alves <palves@redhat.com>
3870 Tom Tromey <tom@tromey.com>
3871
3872 * symtab.c (print_symbol_info): Use %ps.
3873 (print_msymbol_info): Use %ps.
3874 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3875 * printcmd.c (print_variable_and_value): Use %ps.
3876 * macrocmd.c (show_pp_source_pos): Use %ps.
3877 * infrun.c (print_exited_reason): Use ui_out::message.
3878 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3879 (describe_other_breakpoints): Use ui_out::message and new
3880 formats.
3881 (say_where): Use new formats.
3882 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3883 and new formats.
3884
3885 2019-10-01 Pedro Alves <palves@redhat.com>
3886 Tom Tromey <tom@tromey.com>
3887
3888 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3889 (test_gdb_formats): New function.
3890 (run_tests): Call it.
3891 (test_format_specifier): Update.
3892 * utils.h (fputs_filtered): Update comment.
3893 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3894 (fputs_styled_unfiltered): Declare.
3895 * utils.c (fputs_styled_unfiltered): New function.
3896 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3897 (vfprintf_filtered): Update.
3898 (vfprintf_unfiltered, vprintf_filtered): Update.
3899 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3900 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3901 disallow_ui_out_field>: New constants.
3902 (enum class field_kind): New.
3903 (struct base_field_s, struct signed_field_s): New.
3904 (signed_field): New function.
3905 (struct string_field_s): New.
3906 (string_field): New function.
3907 (struct styled_string_s): New.
3908 (styled_string): New function.
3909 (class ui_out) <message>: Add comment.
3910 <vmessage, call_do_message>: New methods.
3911 <do_message>: Add style parameter.
3912 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3913 methods.
3914 (ui_out::message): Rewrite.
3915 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3916 parameter.
3917 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3918 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3919 gdb_extensions parameter.
3920 (class format_piece): Add parameter to constructor.
3921 (n_int_args): New field.
3922 * gdbsupport/format.c (format_pieces::format_pieces): Add
3923 gdb_extensions parameter. Handle '*'.
3924 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3925 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3926 vfprintf_styled_no_gdbfmt.
3927 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3928 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3929 unfiltered output.
3930 * ui-style.h (struct ui_file_style) <ptr>: New method.
3931
3932 2019-10-01 Tom Tromey <tom@tromey.com>
3933
3934 * unittests/format_pieces-selftests.c: Update. Add final format.
3935 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3936 empty literal pieces.
3937
3938 2019-10-01 Tom Tromey <tom@tromey.com>
3939
3940 * ui-out.h (enum class ui_out_style_kind): Remove.
3941 (class ui_out) <field_string, field_stsream, do_field_string>:
3942 Change type of "style".
3943 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3944 (ui_out::field_string): Update.
3945 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3946 of "style".
3947 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3948 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3949 * stack.c (print_frame_arg, print_frame_info, print_frame):
3950 Update.
3951 * source.c (print_source_lines_base): Update.
3952 * solib.c (info_sharedlibrary_command): Update.
3953 * skip.c (info_skip_command): Update.
3954 * record-btrace.c (btrace_call_history_src_line)
3955 (btrace_call_history): Update.
3956 * python/py-framefilter.c (py_print_frame): Update.
3957 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3958 "style".
3959 * mi/mi-out.c (mi_ui_out::do_table_header)
3960 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3961 (mi_ui_out::do_field_string): Update.
3962 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3963 Update.
3964 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3965 "style".
3966 * cli-out.c (cli_ui_out::do_table_header)
3967 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3968 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3969 (cli_ui_out::do_field_fmt): Update.
3970 * breakpoint.c (print_breakpoint_location): Update.
3971 (update_static_tracepoint): Update.
3972
3973 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3974
3975 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3976 conversion of gdb_datadir.
3977 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3978 remove not needed c_str ().
3979
3980 2019-09-30 Ali Tamur <tamur@google.com>
3981
3982 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3983 (dwarf2_string_attr): Likewise.
3984
3985 2019-09-30 Ali Tamur <tamur@google.com>
3986
3987 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3988 (process_full_type_unit): Likewise.
3989 (dump_die_shallow): Likewise.
3990 (cu_debug_loc_section): Likewise.
3991
3992 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3993
3994 * minsyms.c (compare_minimal_symbols): Rename to...
3995 (minimal_symbol_is_less_than): ...this, and adjust to STL
3996 conventions (return bool, take arguments as references)
3997 (minimal_symbol_reader::install): Call std::sort instead
3998 of qsort.
3999
4000 2019-09-29 Christian Biesinger <cbiesinger@google.com>
4001
4002 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4003 hash and why.
4004 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4005 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4006
4007 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4008
4009 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4010 * psympriv.h (add_psymbol_to_list): Move comment here and update
4011 it.
4012
4013 2019-09-29 Tom de Vries <tdevries@suse.de>
4014
4015 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4016 Use $tmpdir/$(basename "$output_file").dwz instead of
4017 "${output_file}.dwz".
4018
4019 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4020
4021 PR gdb/25045
4022 * hppa-linux-nat.c: Include gdbarch.h.
4023
4024 2019-09-26 Christian Biesinger <cbiesinger@google.com>
4025
4026 * blockframe.c (find_pc_partial_function): Change return type to bool.
4027 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4028 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4029 (stub_gnu_ifunc_resolve_name): Likewise.
4030 * symtab.c (compare_filenames_for_search): Likewise.
4031 (compare_glob_filenames_for_search): Likewise.
4032 (matching_obj_sections): Likewise.
4033 (symbol_matches_domain): Likewise.
4034 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4035 (find_line_pc): Change return type to bool.
4036 (find_line_pc_range): Likewise.
4037 (producer_is_realview): Likewise.
4038 * symtab.h (symbol_matches_domain): Likewise.
4039 (find_pc_partial_function): Likewise.
4040 (find_pc_line_pc_range): Likewise.
4041 (in_gnu_ifunc_stub): Likewise.
4042 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4043 (find_line_pc): Likewise.
4044 (find_line_pc_range): Likewise.
4045 (matching_obj_sections): Likewise.
4046 (find_line_symtab): Change out parameter to bool.
4047 (producer_is_realview): Change return type to bool.
4048 (compare_filenames_for_search): Likewise.
4049 (compare_glob_filenames_for_search): Likewise.
4050
4051 2019-09-26 Tom Tromey <tom@tromey.com>
4052
4053 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4054 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4055 * gdb_usleep.h: Remove.
4056 * gdb_usleep.c: Remove.
4057 * utils.c: Don't include gdb_usleep.h.
4058
4059 2019-09-26 Tom Tromey <tromey@adacore.com>
4060
4061 * python/py-type.c (type_to_type_object): Call check_typedef
4062 for stub types.
4063
4064 2019-09-26 Tom Tromey <tom@tromey.com>
4065
4066 * utils.h (initialize_utils): Don't declare.
4067 * top.c (gdb_init): Don't call initialize_utils.
4068 * utils.c (initialize_utils): Remove. Move contents...
4069 (_initialize_utils): ... here.
4070
4071 2019-09-25 Tom Tromey <tom@tromey.com>
4072
4073 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4074 * utils.h (make_hex_string): Don't declare.
4075 * utils.c (make_hex_string): Remove.
4076
4077 2019-09-24 Tom de Vries <tdevries@suse.de>
4078
4079 PR gdb/23815
4080 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4081 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4082
4083 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4084
4085 * NEWS: Mention new simulator port for PRU.
4086
4087 2019-09-23 Christian Biesinger <cbiesinger@google.com>
4088
4089 * ada-exp.y (write_object_remaining): Update.
4090 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4091 and eliminate the static buffer.
4092 (ada_decode_symbol): Update.
4093 (ada_la_decode): Update.
4094 (ada_sniff_from_mangled_name): Update.
4095 (is_valid_name_for_wild_match): Update.
4096 (ada_lookup_name_info::matches): Update and simplify.
4097 (name_matches_regex): Update.
4098 (ada_add_global_exceptions): Update.
4099 * ada-lang.h (ada_decode): Update signature.
4100 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4101 * dwarf-index-write.c (debug_names::insert): Update.
4102
4103 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4104
4105 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4106 formatting.
4107
4108 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4109
4110 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4111 Change "nonzero" to "true" in documentation.
4112
4113 2019-09-20 Christian Biesinger <cbiesinger@google.com>
4114
4115 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4116 (_initialize_darwin_solib): Don't set
4117 darwin_so_ops.lookup_lib_global_symbol.
4118 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4119 set_gdbarch_iterate_over_objfiles_in_search_order.
4120 (elf_lookup_lib_symbol): Rename to...
4121 (svr4_iterate_over_objfiles_in_search_order): this, and update
4122 to iterate semantics.
4123 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4124 * solib.c (solib_global_lookup): Remove.
4125 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4126 (solib_global_lookup): Remove.
4127 * symtab.c (lookup_global_or_static_symbol): Remove call to
4128 solib_global_lookup.
4129
4130 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4131
4132 * NEWS: Move entries about default MI version now being
4133 version 3, and about the GDB/MI fix for multi-location
4134 breakpoints to the "since GDB 8.3" section.
4135
4136 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4137
4138 GDB 8.3.1 released.
4139
4140 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4141
4142 * NEWS: Mention that Cell/B.E. debugging support was removed.
4143 * MAINTAINERS: Remove spu target.
4144
4145 * config/djgpp/fnchange.lst: Remove entries for removed files.
4146
4147 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4148 spu-multiarch.o, and spu-tdep.o.
4149 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4150 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4151 spu-multiarch.c, and spu-tdep.c.
4152 * spu-linux-nat.c: Remove file.
4153 * spu-multiarch.c: Remove file.
4154 * spu-tdep.c: Remove file.
4155 * spu-tdep.h: Remove file.
4156 * solib-spu.c: Remove file.
4157 * solib-spu.h: Remove file.
4158
4159 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4160 * configure.nat (spu-linux): Remove.
4161 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4162 solib-multiarch.o from gdb_target_obs.
4163 (spu*-*-*): Remove.
4164
4165 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4166 feature flag.
4167 (ppc_linux_no_features): Update.
4168 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4169 Cell/B.E. support.
4170 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4171 (tdesc_powerpc_cell64l): Likewise.
4172 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4173 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4174 Cell/B.E. support.
4175 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4176 Do not include "features/rs6000/powerpc-cell32l.c" or
4177 "features/rs6000/powerpc-cell64l.c".
4178 (ppc_linux_spu_section): Remove.
4179 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4180 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4181 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4182 (ppc_linux_spe_context_lookup): Remove.
4183 (ppc_linux_spe_context_inferior_created): Remove.
4184 (ppc_linux_spe_context_solib_loaded): Remove.
4185 (ppc_linux_spe_context_solib_unloaded): Remove.
4186 (ppc_linux_spe_context): Remove.
4187 (struct ppu2spu_cache): Remove.
4188 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4189 (struct ppu2spu_data): Remove.
4190 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4191 ppu2spu_unwind): Remove.
4192 (ppc_linux_init_abi): Remove Cell/B.E. support.
4193 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4194
4195 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4196 (rs6000/powerpc-cell64l-expedite): Likewise
4197 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4198 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4199 rs6000/powerpc-cell64l.xml.
4200 * features/rs6000/powerpc-cell32l.xml: Remove.
4201 * features/rs6000/powerpc-cell64l.xml: Likewise.
4202 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4203 * features/rs6000/powerpc-cell64l.c: Likewise.
4204 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4205 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4206 * regformats/reg-spu.dat: Remove.
4207
4208 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4209 * corelow.c (struct spuid_list): Remove.
4210 (add_to_spuid_list): Remove.
4211 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4212 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4213 (remote_protocol_features): Remove associated entries.
4214 (_initialize_remote): No longer initialize them.
4215 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4216 * linux-nat.c (SPUFS_MAGIC): Remove.
4217 (linux_proc_xfer_spu): Remove.
4218 (spu_enumerate_spu_ids): Remove.
4219 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4220 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4221 (linux_make_corefile_notes): No longer call it.
4222
4223 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4224 (cooked_write_test): Likewise.
4225
4226 2019-09-20 Tom Tromey <tom@tromey.com>
4227
4228 * NEWS: Mention case-sensitivity of TUI commands.
4229 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4230 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4231 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4232
4233 2019-09-20 Tom Tromey <tom@tromey.com>
4234
4235 * tui/tui-source.c (tui_source_window::set_contents): Use
4236 make_unique_xstrdup.
4237 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4238 make_unique_xstrdup.
4239
4240 2019-09-20 Tom Tromey <tom@tromey.com>
4241
4242 * tui/tui-data.c: Remove separator comments.
4243 * tui/tui-layout.c: Remove separator comments.
4244 * tui/tui-win.c: Remove separator comments.
4245 * tui/tui-wingeneral.c: Remove separator comments.
4246
4247 2019-09-20 Tom Tromey <tom@tromey.com>
4248
4249 * tui/tui.h (strcat_to_buf): Don't declare.
4250 * tui/tui.c (strcat_to_buf): Remove.
4251
4252 2019-09-20 Tom Tromey <tom@tromey.com>
4253
4254 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4255 from "fullname".
4256 * tui/tui-source.c (tui_source_window::set_contents)
4257 (tui_source_window::location_matches_p)
4258 (tui_source_window::maybe_update): Update.
4259
4260 2019-09-20 Tom Tromey <tom@tromey.com>
4261
4262 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4263 Update.
4264 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4265 prefix.
4266 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4267 (tui_data_window::line_from_reg_element_no)
4268 (tui_data_window::first_reg_element_no_inline)
4269 (tui_data_window::show_registers)
4270 (tui_data_window::show_register_group)
4271 (tui_data_window::display_registers_from)
4272 (tui_data_window::display_registers_from_line)
4273 (tui_data_window::first_data_item_displayed)
4274 (tui_data_window::delete_data_content_windows)
4275 (tui_data_window::erase_data_content)
4276 (tui_data_window::do_scroll_vertical)
4277 (tui_data_window::refresh_window)
4278 (tui_data_window::check_register_values): Update.
4279
4280 2019-09-20 Tom Tromey <tom@tromey.com>
4281
4282 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4283 (struct tui_locator_window) <full_name, proc_name>: Now
4284 std::string.
4285 * tui/tui-stack.c (tui_locator_window::make_status_line)
4286 (tui_locator_window::set_locator_fullname)
4287 (tui_locator_window::set_locator_info): Update.
4288 * tui/tui-source.c (tui_source_window::set_contents)
4289 (tui_source_window::showing_source_p): Update.
4290
4291 2019-09-20 Tom Tromey <tom@tromey.com>
4292
4293 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4294 Don't call tui_locator_win_info_ptr.
4295
4296 2019-09-20 Tom Tromey <tom@tromey.com>
4297
4298 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4299
4300 2019-09-20 Tom Tromey <tom@tromey.com>
4301
4302 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4303 height for locator.
4304 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4305 * tui/tui-layout.c (show_source_disasm_command, show_data)
4306 (show_source_or_disasm_and_command): Use 1 as height for locator.
4307
4308 2019-09-20 Tom Tromey <tom@tromey.com>
4309
4310 * tui/tui.c (tui_enable): Update.
4311 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4312 Update.
4313 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4314 Update.
4315 * tui/tui-data.c (win_resized): Now bool.
4316 (tui_win_resized): Return bool.
4317 (tui_set_win_resized_to): Accept a bool.
4318
4319 2019-09-20 Tom Tromey <tom@tromey.com>
4320
4321 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4322 Change type of "refresh_values_only".
4323 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4324 type of "refresh_values_only".
4325
4326 2019-09-20 Tom Tromey <tom@tromey.com>
4327
4328 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4329 std::string.
4330 (tui_disassemble): Add "pos" parameter.
4331 (tui_disasm_window::set_contents): Simplify.
4332
4333 2019-09-20 Tom Tromey <tom@tromey.com>
4334
4335 * tui/tui-winsource.h (struct tui_source_window_base)
4336 <show_source_content>: Now private.
4337 * tui/tui-winsource.c
4338 (tui_source_window_base::show_source_content): Don't handle empty
4339 content case.
4340
4341 2019-09-20 Tom Tromey <tom@tromey.com>
4342
4343 * tui/tui-layout.c (show_source_disasm_command)
4344 (show_source_or_disasm_and_command): Don't call
4345 show_source_content.
4346
4347 2019-09-20 Tom Tromey <tom@tromey.com>
4348
4349 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4350 Declare.
4351 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4352 from tui_make_status_line.
4353 (tui_locator_window::rerender): Update.
4354
4355 2019-09-20 Tom Tromey <tom@tromey.com>
4356
4357 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4358 (tui_locator_window::rerender): Update.
4359
4360 2019-09-20 Tom Tromey <tom@tromey.com>
4361
4362 * tui/tui-winsource.h (struct tui_source_window_base)
4363 <~tui_source_window_base>: Don't declare.
4364 <fullname>: Remove.
4365 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4366 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4367 member.
4368 * tui/tui-source.c (tui_source_window::set_contents): Update.
4369 (tui_source_window::location_matches_p)
4370 (tui_source_window::maybe_update): Update.
4371
4372 2019-09-20 Tom Tromey <tom@tromey.com>
4373
4374 * tui/tui-winsource.h (~tui_source_element): Remove.
4375 (tui_source_element): Update.
4376 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4377 * tui/tui-winsource.c (tui_show_source_line): Update.
4378 * tui/tui-source.c (tui_source_window::set_contents): Update.
4379 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4380
4381 2019-09-20 Tom Tromey <tom@tromey.com>
4382
4383 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4384 declare.
4385 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4386 tui_clear_source_windows_detail.
4387 * tui/tui-winsource.h (struct tui_source_window_base)
4388 <clear_detail>: Don't declare.
4389 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4390 Remove.
4391 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4392
4393 2019-09-20 Tom Tromey <tromey@adacore.com>
4394
4395 PR ada/24919:
4396 * block.c (contained_in): Fix final return value.
4397
4398 2019-09-20 Alan Modra <amodra@gmail.com>
4399
4400 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4401 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4402 (read_indirect_string_from_dwz): Use bfd accessor.
4403 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4404 * machoread.c (macho_symfile_read_all_oso): Likewise.
4405 * solib.c (solib_bfd_open): Likewise.
4406
4407 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4408
4409 * eval.c: Move declaration of overload_resolution to...
4410 * value.h: ...here.
4411
4412 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4413
4414 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4415 * arm-linux-tdep.c: Likewise.
4416 * arm-nbsd-nat.c: Likewise.
4417 * arm-tdep.h: Declare arm_apcs_32.
4418 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4419
4420 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4421
4422 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4423 * dwarf2read.h: Declare dwarf_always_disassemble.
4424
4425 2019-09-19 Tom de Vries <tdevries@suse.de>
4426
4427 PR gdb/25009
4428 * source-cache.c (source_cache::ensure): Catch exception thrown during
4429 construction of the highlighter.
4430
4431 2019-09-18 Alan Modra <amodra@gmail.com>
4432
4433 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4434 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4435 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4436 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4437 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4438 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4439 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4440 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4441 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4442 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4443 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4444 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4445 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4446 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4447 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4448 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4449 * mi/mi-interp.c: Update throughout for bfd section macro and
4450 function changes.
4451 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4452 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4453
4454 2019-09-18 Tom Tromey <tom@tromey.com>
4455
4456 * NEWS: Add entry.
4457 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4458 call rl_initialize.
4459 (tui_enable): Do not call rl_initialize.
4460
4461 2019-09-18 Christian Groessler <chris@groessler.org>
4462
4463 * alpha-linux-nat.c: Include gdbarch.h.
4464
4465 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4466
4467 * ui-file.c: Include cli/cli-style.h.
4468 (term_cli_styling): Remove cli_styling declaration.
4469
4470 2019-09-18 Alan Modra <amodra@gmail.com>
4471
4472 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4473 to bfd_asymbol_section.
4474
4475 2019-09-18 Alan Modra <amodra@gmail.com>
4476
4477 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4478 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4479 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4480
4481 2019-09-18 Alan Modra <amodra@gmail.com>
4482
4483 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4484 * spu-linux-nat.c (spu_bfd_open): Likewise.
4485
4486 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4487
4488 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4489 to bool to match definition in dwarf2read.c.
4490
4491 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4492
4493 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4494 (print_signatures): Likewise.
4495 (trust_pad_over_xvs): Likewise.
4496 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4497 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4498 * arm-linux-nat.c (arm_apcs_32): Likewise.
4499 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4500 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4501 * arm-tdep.c (arm_debug): Likewise.
4502 (arm_apcs_32): Likewise.
4503 * auto-load.c (debug_auto_load): Likewise.
4504 (auto_load_gdb_scripts): Likewise.
4505 (global_auto_load): Likewise.
4506 (auto_load_local_gdbinit): Likewise.
4507 (auto_load_local_gdbinit_loaded): Likewise.
4508 * auto-load.h (global_auto_load): Likewise.
4509 (auto_load_local_gdbinit): Likewise.
4510 (auto_load_local_gdbinit_loaded): Likewise.
4511 * breakpoint.c (disconnected_dprintf): Likewise.
4512 (breakpoint_proceeded): Likewise.
4513 (automatic_hardware_breakpoints): Likewise.
4514 (always_inserted_mode): Likewise.
4515 (target_exact_watchpoints): Likewise.
4516 (_initialize_breakpoint): Update.
4517 * breakpoint.h (target_exact_watchpoints): Change to bool.
4518 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4519 * cli/cli-cmds.c (trace_commands): Likewise.
4520 * cli/cli-cmds.h (trace_commands): Likewise.
4521 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4522 to bool*.
4523 * cli/cli-logging.c (logging_overwrite): Change to bool.
4524 (logging_redirect): Likewise.
4525 (debug_redirect): Likewise.
4526 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4527 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4528 to bool.
4529 <boolean_option_def>: Update.
4530 (struct flag_option_def): Change default type of Context to bool
4531 from int.
4532 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4533 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4534 (get_setshow_command_value_string): Likewise.
4535 * cli/cli-style.c (cli_styling): Change to bool.
4536 (source_styling): Likewise.
4537 * cli/cli-style.h (source_styling): Likewise.
4538 (cli_styling): Likewise.
4539 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4540 to bool.
4541 * command.h (var_types): Update comment.
4542 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4543 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4544 bool.
4545 (debug_compile_cplus_scopes): Likewise.
4546 * compile/compile-internal.h (compile_debug): Likewise.
4547 * compile/compile.c (compile_debug): Likewise.
4548 (struct compile_options) <raw>: Likewise.
4549 * cp-support.c (catch_demangler_crashes): Likewise.
4550 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4551 (usr_cmd_cris_dwarf2_cfi): Likewise.
4552 * csky-tdep.c (csky_debug): Likewise.
4553 * darwin-nat.c (enable_mach_exceptions): Likewise.
4554 * dcache.c (dcache_enabled_p): Likewise.
4555 * defs.h (info_verbose): Likewise.
4556 * demangle.c (demangle): Likewise.
4557 (asm_demangle): Likewise.
4558 * dwarf-index-cache.c (debug_index_cache): Likewise.
4559 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4560 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4561 * dwarf2read.c (check_physname): Likewise.
4562 (use_deprecated_index_sections): Likewise.
4563 (dwarf_always_disassemble): Likewise.
4564 * eval.c (overload_resolution): Likewise.
4565 * event-top.c (set_editing_cmd_var): Likewise.
4566 (exec_done_display_p): Likewise.
4567 * event-top.h (set_editing_cmd_var): Likewise.
4568 (exec_done_display_p): Likewise.
4569 * exec.c (write_files): Likewise.
4570 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4571 (debug_fbsd_nat): Likewise.
4572 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4573 Likewise.
4574 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4575 <backtrace_past_entry> Likewise.
4576 * gdb-demangle.h (demangle): Likewise.
4577 (asm_demangle): Likewise.
4578 * gdb_bfd.c (bfd_sharing): Likewise.
4579 * gdbcore.h (write_files): Likewise.
4580 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4581 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4582 * gdbthread.h (print_thread_events): Likewise.
4583 * gdbtypes.c (opaque_type_resolution): Likewise.
4584 (strict_type_checking): Likewise.
4585 * gnu-nat.c (gnu_debug_flag): Likewise.
4586 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4587 * guile/scm-param.c (pascm_variable): Add boolval.
4588 (add_setshow_generic): Update.
4589 (pascm_param_value): Update.
4590 (pascm_set_param_value_x): Update.
4591 * hppa-tdep.c (hppa_debug): Change to bool..
4592 * infcall.c (may_call_functions_p): Likewise.
4593 (coerce_float_to_double_p): Likewise.
4594 (unwind_on_signal_p): Likewise.
4595 (unwind_on_terminating_exception_p): Likewise.
4596 * infcmd.c (startup_with_shell): Likewise.
4597 * inferior.c (print_inferior_events): Likewise.
4598 * inferior.h (startup_with_shell): Likewise.
4599 (print_inferior_events): Likewise.
4600 * infrun.c (step_stop_if_no_debug): Likewise.
4601 (detach_fork): Likewise.
4602 (debug_displaced): Likewise.
4603 (disable_randomization): Likewise.
4604 (non_stop): Likewise.
4605 (non_stop_1): Likewise.
4606 (observer_mode): Likewise.
4607 (observer_mode_1): Likewise.
4608 (set_observer_mode): Update.
4609 (sched_multi): Change to bool.
4610 * infrun.h (debug_displaced): Likewise.
4611 (sched_multi): Likewise.
4612 (step_stop_if_no_debug): Likewise.
4613 (non_stop): Likewise.
4614 (disable_randomization): Likewise.
4615 * linux-tdep.c (use_coredump_filter): Likewise.
4616 (dump_excluded_mappings): Likewise.
4617 * linux-thread-db.c (auto_load_thread_db): Likewise.
4618 (check_thread_db_on_load): Likewise.
4619 * main.c (captured_main_1): Update.
4620 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4621 xx2_opt, boolean_opt>: Change to bool.
4622 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4623 * maint.c (maintenance_profile_p): Likewise.
4624 (per_command_time): Likewise.
4625 (per_command_space): Likewise.
4626 (per_command_symtab): Likewise.
4627 * memattr.c (inaccessible_by_default): Likewise.
4628 * mi/mi-main.c (mi_async): Likewise.
4629 (mi_async_1): Likewise.
4630 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4631 * nat/fork-inferior.h (startup_with_shell): Likewise.
4632 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4633 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4634 * nios2-tdep.c (nios2_debug): Likewise.
4635 * or1k-tdep.c (or1k_debug): Likewise.
4636 * parse.c (parser_debug): Likewise.
4637 * parser-defs.h (parser_debug): Likewise.
4638 * printcmd.c (print_symbol_filename): Likewise.
4639 * proc-api.c (procfs_trace): Likewise.
4640 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4641 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4642 (set_parameter_value): Update.
4643 (add_setshow_generic): Update.
4644 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4645 to bool*.
4646 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4647 int*.
4648 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4649 * record-btrace.c (record_btrace_target::store_registers): Update.
4650 * record-full.c (record_full_memory_query): Change to bool.
4651 (record_full_stop_at_limit): Likewise.
4652 * record-full.h (record_full_memory_query): Likewise.
4653 * remote-notif.c (notif_debug): Likewise.
4654 * remote-notif.h (notif_debug): Likewise.
4655 * remote.c (use_range_stepping): Likewise.
4656 (interrupt_on_connect): Likewise.
4657 (remote_break): Likewise.
4658 * ser-tcp.c (tcp_auto_retry): Likewise.
4659 * ser-unix.c (serial_hwflow): Likewise.
4660 * skip.c (debug_skip): Likewise.
4661 * solib-aix.c (solib_aix_debug): Likewise.
4662 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4663 (spu_auto_flush_cache_p): Likewise.
4664 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4665 Likewise.
4666 (struct info_print_options) <quiet>: Likewise.
4667 * symfile-debug.c (debug_symfile): Likewise.
4668 * symfile.c (auto_solib_add): Likewise.
4669 (separate_debug_file_debug): Likewise.
4670 * symfile.h (auto_solib_add): Likewise.
4671 (separate_debug_file_debug): Likewise.
4672 * symtab.c (basenames_may_differ): Likewise.
4673 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4674 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4675 (struct info_types_options) <quiet>: Likewise.
4676 * symtab.h (demangle): Likewise.
4677 (basenames_may_differ): Likewise.
4678 * target-dcache.c (stack_cache_enabled_1): Likewise.
4679 (code_cache_enabled_1): Likewise.
4680 * target.c (trust_readonly): Likewise.
4681 (may_write_registers): Likewise.
4682 (may_write_memory): Likewise.
4683 (may_insert_breakpoints): Likewise.
4684 (may_insert_tracepoints): Likewise.
4685 (may_insert_fast_tracepoints): Likewise.
4686 (may_stop): Likewise.
4687 (auto_connect_native_target): Likewise.
4688 (target_stop_and_wait): Update.
4689 (target_async_permitted): Change to bool.
4690 (target_async_permitted_1): Likewise.
4691 (may_write_registers_1): Likewise.
4692 (may_write_memory_1): Likewise.
4693 (may_insert_breakpoints_1): Likewise.
4694 (may_insert_tracepoints_1): Likewise.
4695 (may_insert_fast_tracepoints_1): Likewise.
4696 (may_stop_1): Likewise.
4697 * target.h (target_async_permitted): Likewise.
4698 (may_write_registers): Likewise.
4699 (may_write_memory): Likewise.
4700 (may_insert_breakpoints): Likewise.
4701 (may_insert_tracepoints): Likewise.
4702 (may_insert_fast_tracepoints): Likewise.
4703 (may_stop): Likewise.
4704 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4705 (make_thread_apply_all_options_def_group): Change argument from int*
4706 to bool*.
4707 (thread_apply_all_command): Update.
4708 (print_thread_events): Change to bool.
4709 * top.c (confirm): Likewise.
4710 (command_editing_p): Likewise.
4711 (history_expansion_p): Likewise.
4712 (write_history_p): Likewise.
4713 (info_verbose): Likewise.
4714 * top.h (confirm): Likewise.
4715 (history_expansion_p): Likewise.
4716 * tracepoint.c (disconnected_tracing): Likewise.
4717 (circular_trace_buffer): Likewise.
4718 * typeprint.c (print_methods): Likewise.
4719 (print_typedefs): Likewise.
4720 * utils.c (debug_timestamp): Likewise.
4721 (sevenbit_strings): Likewise.
4722 (pagination_enabled): Likewise.
4723 * utils.h (sevenbit_strings): Likewise.
4724 (pagination_enabled): Likewise.
4725 * valops.c (overload_resolution): Likewise.
4726 * valprint.h (struct value_print_options) <prettyformat_arrays,
4727 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4728 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4729 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4730 Likewise.
4731 * windows-nat.c (new_console): Likewise.
4732 (cygwin_exceptions): Likewise.
4733 (new_group): Likewise.
4734 (debug_exec): Likewise.
4735 (debug_events): Likewise.
4736 (debug_memory): Likewise.
4737 (debug_exceptions): Likewise.
4738 (useshell): Likewise.
4739 * windows-tdep.c (maint_display_all_tib): Likewise.
4740 * xml-support.c (debug_xml): Likewise.
4741
4742 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4743
4744 * source.c (prepare_path_for_appending): New function.
4745 (openp): Make use of new function.
4746 (find_and_open_source): Search for the compilation directory and
4747 source file as a relative path beneath the directory search path.
4748
4749 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4750
4751 * source-cache.c (source_cache::get_line_charpos): Catch
4752 exceptions and return false, this matches the behaviour documented
4753 in the header file.
4754
4755 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4756
4757 * ada-tasks.c (info_task): Remove quoting of the task's name.
4758
4759 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4760
4761 * symfile.c (auto_solib_add): Replace comment with a reference
4762 to the header file.
4763
4764 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4765
4766 * NEWS: Mention that gdb can now be compiled with Python 3
4767 on Windows.
4768
4769 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4770
4771 * maint.c (maint_print_section_data::maint_print_section_data):
4772 Force use of 'float log10 (float)' by casting the argument to
4773 float.
4774
4775 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4776
4777 * maint.c: Add 'cmath' include.
4778 (struct maint_print_section_data): New structure.
4779 (print_section_index): New function.
4780 (print_bfd_section_info): Add header comment, small whitespace
4781 cleanup, and update to call new print_section_index function.
4782 (print_objfile_section_info): Likewise.
4783 (maint_obj_section_from_bfd_section): New function.
4784 (print_bfd_section_info_maybe_relocated): New function.
4785 (maintenance_info_sections): Add header comment, always use
4786 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4787
4788 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4789
4790 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4791 inner scope, add check that the objfile has psymtabs before
4792 checking psymtabs_addrmap.
4793 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4794
4795 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4796
4797 * NEWS: Announce that Ada task names are now shown at more places,
4798 and between quotes (except in info task output).
4799 * gdb/ada-tasks.c (task_to_str): New function.
4800 (display_current_task_id): Call task_to_str.
4801 (task_command_1): Likewise.
4802 (print_ada_task_info): In non-mi mode, Properly align headers and data
4803 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4804
4805 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4806
4807 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4808 prstatus.pr_lwp.pr_info instead of making it up.
4809
4810 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4811
4812 * auto-load.c (auto_load_expand_dir_vars): Update.
4813 * defs.h (gdb_datadir): Change to std::string.
4814 (python_libdir): Likewise.
4815 (relocate_gdb_directory): Change return type to std::string.
4816 * guile/guile.c (gdbscm_data_directory): Update.
4817 (initialize_scheme_side): Update.
4818 * jit.c (jit_reader_dir): Change to std::string.
4819 (jit_reader_load_command): Update.
4820 * main.c (gdb_datadir): Change to std::string.
4821 (python_libdir): Likewise.
4822 (set_gdb_data_directory): Update.
4823 (relocate_path): Change to return std::string.
4824 (relocate_gdb_directory): Change to return std::string.
4825 (relocate_gdbinit_path_maybe_in_datadir): Update.
4826 (captured_main_1): Update.
4827 * python/python.c (do_start_initialization): Update.
4828 * top.c (show_gdb_datadir): Update.
4829 * xml-syscall.c (xml_init_syscalls_info): Update.
4830 (init_syscalls_info): Update.
4831
4832 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4833
4834 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4835 out of get_init_files.
4836 (get_init_files): Update.
4837
4838 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4839
4840 * main.c (get_init_files): Change to use std::string.
4841 (captured_main_1): Update.
4842 (print_gdb_help): Update.
4843
4844 2019-09-11 Ali Tamur <tamur@google.com>
4845
4846 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4847 implementation.
4848
4849 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4850
4851 * dbxread.c (read_dbx_symtab): Update.
4852 * dwarf2read.c (load_partial_dies): Update.
4853 * mdebugread.c (parse_partial_symbols): Update.
4854 (handle_psymbol_enumerators): Update.
4855 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4856 * psymtab.c (add_psymbol_to_bcache): Likewise.
4857 (add_psymbol_to_list): Likewise.
4858 * symtab.c (symbol_set_names): Likewise.
4859 * symtab.h (symbol_set_names): Likewise.
4860 * xcoffread.c (scan_xcoff_symtab): Update.
4861
4862 2019-09-11 Tom Tromey <tom@tromey.com>
4863
4864 * symfile-mem.c (symbol_file_add_from_memory): Use
4865 bfd_set_filename.
4866 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4867 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4868
4869 2019-09-10 Tom Tromey <tromey@adacore.com>
4870
4871 * dwarf-index-write.c (write_psymbols): Extend error message.
4872 (debug_names::insert): Add Ada code.
4873 (debug_names::write_psymbols): Remove Ada check.
4874 (debug_names) <m_string_obstack>: New member.
4875 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4876 (gdb_index_symbol_name_matcher::matches): Remove.
4877 (mapped_index_base::find_name_components_bounds): Add "lang"
4878 parameter.
4879 (mapped_index_base::build_name_components): Also split names
4880 according to Ada syntax.
4881 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4882 type of "match_callback".
4883 (check_match, check_find_bounds_finds)
4884 (dw2_expand_symtabs_matching): Update.
4885 (dw2_debug_names_iterator): Add new constructor.
4886 (dw2_debug_names_map_matching_symbols): New function.
4887 (dw2_debug_names_expand_symtabs_matching): Update.
4888 (dwarf2_debug_names_functions): Use
4889 dw2_debug_names_map_matching_symbols.
4890
4891 2019-09-10 Tom Tromey <tromey@adacore.com>
4892
4893 * dwarf2read.c (dw2_get_file_names_reader): Add the
4894 CU's file name to the results.
4895
4896 2019-09-10 Tom Tromey <tromey@adacore.com>
4897
4898 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4899 map_matching_symbols. Update.
4900 * dwarf2read.c (dw2_map_matching_symbols): Update.
4901 * psymtab.c (match_partial_symbol): Change type; update.
4902 (psym_map_matching_symbols): Likewise.
4903 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4904 type; update.
4905 * symfile.h (struct quick_symbol_functions)
4906 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4907 Remove "match".
4908
4909 2019-09-10 Tom Tromey <tromey@adacore.com>
4910
4911 * psymtab.c (map_block): Remove.
4912 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4913 * symtab.c (iterate_over_symbols_terminated): New function.
4914 * symtab.c (iterate_over_symbols_terminated): Declare.
4915
4916 2019-09-10 Tom Tromey <tromey@adacore.com>
4917
4918 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4919 * language.h (struct language_defn) <la_iterate_over_symbols>:
4920 Return bool.
4921 * symtab.c (iterate_over_symbols): Return bool.
4922 * symtab.h (iterate_over_symbols): Return bool.
4923
4924 2019-09-10 Tom Tromey <tromey@adacore.com>
4925
4926 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4927 (add_nonlocal_symbols): Update.
4928 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4929 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4930 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4931 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4932 Change type of "callback". Remove "data".
4933
4934
4935 2019-09-09 Ali Tamur <tamur@google.com>
4936
4937 * dwarf2read.c (comp_unit_head): Update comment.
4938 (dwarf2_dwo_name): New function declaration.
4939 (dwarf_unit_type_name): New function declaration.
4940 (read_comp_unit_head): Add support for new compilation units,
4941 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4942 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4943 (currently named as "signature") in their header. Also clarify error
4944 messages.
4945 (lookup_dwo_id): New function. Returns the dwo id of the given
4946 compile unit.
4947 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4948 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4949 functions.
4950 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4951 (dwarf2_dwo_name): Get the dwo name if present.
4952 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4953 purposes.
4954
4955 2019-09-09 Tom Tromey <tom@tromey.com>
4956
4957 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4958
4959 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4960
4961 * python/python.c (do_start_initialization): Make progname_copy static,
4962 to avoid a leak report.
4963
4964 2019-09-08 Tom Tromey <tom@tromey.com>
4965
4966 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4967
4968 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4969
4970 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4971 Change type to gdb::optional<block_enum>.
4972 (dw2_symtab_iter_init): Change block_index parameter type
4973 to gdb::optional<block_enum>.
4974 (dw2_lookup_symbol): Change block_index parameter
4975 type to block_enum.c
4976 (dw2_debug_names_lookup_symbol): Likewise.
4977 * psymtab.c (psym_lookup_symbol): Likewise.
4978 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4979 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4980 Likewise.
4981
4982 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4983
4984 * defs.h (relocate_gdb_directory): Change int to bool in
4985 signature and rename flag to relocatable.
4986 * main.c (relocate_path): Likewise.
4987 (relocate_gdb_directory): Likewise.
4988
4989 2019-09-06 Alan Modra <amodra@gmail.com>
4990
4991 * coffread.c (coff_symfile_read): Constify filename variable.
4992 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4993 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4994 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4995 * solib.c (reload_shared_libraries_1): Likewise.
4996 * symfile.c (reread_symbols): Likewise.
4997 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4998 * solib-darwin.c (darwin_bfd_open): Likewise.
4999 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5000
5001 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5002
5003 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5004 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5005
5006 2019-09-03 Tom Tromey <tromey@adacore.com>
5007
5008 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5009 types.
5010 (has_negatives): Unbias a range type bound.
5011 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5012 * gdbtypes.c (operator==): Handle new field.
5013 (create_range_type): Add "bias" parameter.
5014 (create_static_range_type, resolve_dynamic_range): Update.
5015 * gdbtypes.h (struct range_bounds) <bias>: New member.
5016 (create_range_type): Add bias parameter.
5017 * printcmd.c (print_scalar_formatted): Unbias range types.
5018 * value.c (unpack_long): Unbias range types.
5019 (pack_long): Bias range types.
5020
5021 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5022
5023 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5024 probe arguments.
5025
5026 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5027
5028 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5029 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5030 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5031 (compile_probe_arg): Likewise.
5032 * probe.h (get_argument_count): Likewise.
5033 * solib-svr4.c (solib_event_probe_action): Likewise.
5034 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5035
5036 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5037
5038 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5039 code to here...
5040 (svr4_create_solib_event_breakpoints): ...from here.
5041
5042 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5043
5044 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5045 suffix from warning message.
5046
5047 2019-08-30 Tom Tromey <tom@tromey.com>
5048
5049 * tui/tui-winsource.h (struct tui_source_window_base)
5050 <refresh_all>: Don't declare.
5051 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5052 Remove.
5053 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5054 tui_show_locator_content.
5055 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5056 declare.
5057 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5058 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5059 declare.
5060
5061 2019-08-30 Tom Tromey <tom@tromey.com>
5062
5063 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5064
5065 2019-08-30 Tom Tromey <tom@tromey.com>
5066
5067 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5068 Remove unnecessary forward declarations.
5069
5070 2019-08-30 Tom Tromey <tom@tromey.com>
5071
5072 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5073 rerender.
5074 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5075 tui_show_locator_content.
5076
5077 2019-08-30 Tom Tromey <tom@tromey.com>
5078
5079 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5080 (tui_locator_window::rerender): Rewrite using body of previous
5081 tui_show_locator_content.
5082
5083 2019-08-30 Tom Tromey <tom@tromey.com>
5084
5085 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5086 set_locator_fullname>: New methods.
5087 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5088 Rename from tui_set_locator_fullname.
5089 (tui_locator_window::set_locator_info): Rename from
5090 tui_set_locator_info. Return bool.
5091 (tui_update_locator_fullname, tui_show_frame_info): Update.
5092
5093 2019-08-30 Tom Tromey <tom@tromey.com>
5094
5095 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5096
5097 2019-08-30 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5100 call touchwin.
5101
5102 2019-08-30 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-wingeneral.c (box_win): Assume win_info and
5105 win_info->handle cannot be NULL.
5106
5107 2019-08-30 Tom Tromey <tom@tromey.com>
5108
5109 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5110 refresh_window>: Declare.
5111 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5112 resize.
5113 (tui_data_item_window::rerender): Rename from
5114 tui_display_register.
5115 (tui_data_item_window::refresh_window): New method.
5116 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5117 no-op.
5118
5119 2019-08-30 Tom Tromey <tom@tromey.com>
5120
5121 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5122 regs_column_count, current_group>: Move later. Now private.
5123 <get_current_group>: New method.
5124 * tui/tui-regs.c (tui_reg_command): Update.
5125 * tui/tui-layout.c (tui_set_layout): Update.
5126
5127 2019-08-30 Tom Tromey <tom@tromey.com>
5128
5129 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5130 (tui_data_window::rerender): Don't call
5131 check_and_display_highlight_if_needed.
5132 (tui_data_window::refresh_all): Remove call to
5133 erase_data_content.
5134
5135 2019-08-30 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5138 (tui_data_window::display_registers_from)
5139 (tui_data_window::display_reg_element_at_line)
5140 (tui_data_window::display_registers_from_line): Remove checks of
5141 "empty".
5142
5143 2019-08-30 Tom Tromey <tom@tromey.com>
5144
5145 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5146 Don't declare.
5147 * tui/tui-regs.c (tui_data_window::show_registers): Call
5148 rerender.
5149 (tui_data_window::rerender): Rename from display_all_data.
5150 (tui_data_window::rerender): Remove old implementation.
5151
5152 2019-08-30 Tom Tromey <tom@tromey.com>
5153
5154 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5155 text.
5156 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5157
5158 2019-08-29 Bernhard Wodok <barto@gmx.net>
5159 Sergio Durigan Junior <sergiodj@redhat.com>
5160
5161 PR win32/24284
5162 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5163
5164 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5165
5166 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5167 when searching for types.
5168
5169 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5170
5171 * f-lang.c (f_language_defn): Use f_print_typedef.
5172 * f-lang.h (f_print_typedef): Declare.
5173 * f-typeprint.c (f_print_typedef): Define.
5174
5175 2019-08-27 Christian Biesinger <cbiesinger@google.com>
5176
5177 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5178
5179 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5180
5181 * cli/cli-utils.c (info_print_options_defs): Delete.
5182 (make_info_print_options_def_group): Delete.
5183 (extract_info_print_options): Delete.
5184 (info_print_command_completer): Delete.
5185 (info_print_args_help): Add extra parameter, and optionally
5186 include text about -n flag.
5187 * cli/cli-utils.h (struct info_print_options): Delete.
5188 (extract_info_print_options): Delete declaration.
5189 (info_print_command_completer): Delete declaration.
5190 (info_print_args_help): Add extra parameter, extend header
5191 comment.
5192 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5193 search_symbols.
5194 * stack.c (struct info_print_options): New type.
5195 (info_print_options_defs): New file scoped variable.
5196 (make_info_print_options_def_group): New static function.
5197 (info_print_command_completer): New static function.
5198 (info_locals_command): Update to use new local functions.
5199 (info_args_command): Likewise.
5200 (_initialize_stack): Add extra parameter to calls to
5201 info_print_args_help.
5202 * symtab.c (search_symbols): Add extra parameter, use this to
5203 possibly excluse non-debug symbols.
5204 (symtab_symbol_info): Add extra parameter, which is passed on to
5205 search_symbols.
5206 (struct info_print_options): New type.
5207 (info_print_options_defs): New file scoped variable.
5208 (make_info_print_options_def_group): New static function.
5209 (info_print_command_completer): New static function.
5210 (info_variables_command): Update to use local functions, and pass
5211 extra parameter through to symtab_symbol_info.
5212 (info_functions_command): Likewise.
5213 (info_types_command): Pass additional argument through to
5214 symtab_symbol_info.
5215 (rbreak_command): Pass extra argument to search_symbols.
5216 (_initialize_symtab): Add extra arguments for calls to
5217 info_print_args_help, and update help text for 'info variables',
5218 'whereis', and 'info functions' commands.
5219 * symtab.h (search_symbols): Add extra argument to declaration.
5220 * NEWS: Mention new flags.
5221
5222 2019-08-26 Christian Biesinger <cbiesinger@google.com>
5223
5224 * symtab.c (lookup_static_symbol): Call the new function (and move
5225 it down to be next to lookup_global_symbol).
5226 (struct global_sym_lookup_data): Add block_enum member and rename to...
5227 (struct global_or_static_sym_lookup_data): ...this.
5228 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5229 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5230 (lookup_symbol_global_or_static_iterator_cb): ...this.
5231 (lookup_global_or_static_symbol): New function.
5232 (lookup_global_symbol): Call new function.
5233
5234 2019-08-26 Tom de Vries <tdevries@suse.de>
5235
5236 PR c++/24852
5237 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5238 when pc_probe.prob == NULL.
5239
5240 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5241
5242 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5243 variable symbol_linkage to symbol_linkage_.
5244
5245 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5246
5247 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5248 represent whether the symbol is static, dynamic, or we don't
5249 know.
5250
5251 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5252
5253 * gdb/rx-tdep.c (rx_register_names): New.
5254 (rx_register_name): Delete.
5255 (rx_psw_type): Delete.
5256 (rx_fpsw_type): Delete.
5257 (rx_register_type): Delete.
5258 (rx_gdbarch_init): Convert target-descriptions.
5259 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5260 * gdb/features/Makefile: Add rx.xml.
5261 * gdb/features/rx.xml: New.
5262 * gdb/features/rx.c: Generated.
5263 * gdb/NEWS: Mention target description support.
5264
5265 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5266
5267 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5268 *slot_ptr.
5269
5270 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5271
5272 * configure.ac: Don't check for 'dlfcn.h' (moved to
5273 gdbsupport/common.m4).
5274 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5275 'gdbsupport/'.
5276 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5277 * compile/compile-c-support.c: Include
5278 'gdbsupport/gdb-dlfcn.h'.
5279 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5280 * gdb-dlfcn.c: Move to...
5281 * gdbsupport/gdb-dlfcn.c: ... here.
5282 * gdb-dlfcn.h: Move to...
5283 * gdbsupport/gdb-dlfcn.h: ... here.
5284
5285 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5286
5287 * nios2-tdep.c (struct reg_value): Improve comments. Make
5288 the offset field signed.
5289
5290 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5291
5292 * python/lib/gdb/__init__.py (_execute_file): New function.
5293 * python/python.c (python_run_simple_file): Call gdb._execute_file
5294 on Windows.
5295
5296 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5297
5298 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5299 all uses as this was never set to anything but a zero value.
5300
5301 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5302
5303 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5304
5305 2019-08-21 Christian Biesinger <cbiesinger@google.com>
5306
5307 * tui/tui-data.h (tui_gen_win_info): Add an =default
5308 move constructor, required by some GCC versions.
5309
5310 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
5311
5312 * go32-nat.c (go32_sysinfo): Add hygon_p.
5313
5314 2019-08-20 Tom Tromey <tom@tromey.com>
5315
5316 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5317 line_from_reg_element_no, first_reg_element_no_inline,
5318 display_all_data, delete_data_content_windows,
5319 erase_data_content>: Now private.
5320
5321 2019-08-20 Tom Tromey <tom@tromey.com>
5322
5323 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5324 (tui_unhighlight_win, tui_highlight_win)
5325 (tui_win_info::make_window): Update.
5326 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5327
5328 2019-08-20 Tom Tromey <tom@tromey.com>
5329
5330 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5331 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5332 (MAX_PID_WIDTH): Move to tui-stack.c.
5333 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5334 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5335 (MAX_PID_WIDTH): Move from tui-data.h.
5336
5337 2019-08-20 Tom Tromey <tom@tromey.com>
5338
5339 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5340 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5341 (box_win): Update.
5342 (tui_gen_win_info::make_window): Rename from tui_make_window.
5343 (tui_win_info::make_window): New method.
5344 (tui_gen_win_info::make_visible): Update.
5345 * tui/tui-source.c (tui_source_window::set_contents): Update.
5346 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5347 (tui_data_window::display_registers_from): Update.
5348 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5349 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5350 Declare.
5351 <can_box>: Remove.
5352 <title>: Remove.
5353 (struct tui_win_info) <make_window>: Declare.
5354 <can_box>: Now virtual.
5355 <title>: New member.
5356 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5357 * tui/tui-command.c (tui_cmd_window::resize): Update.
5358
5359 2019-08-20 Tom Tromey <tom@tromey.com>
5360
5361 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5362 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5363 (tui_data_window::check_register_values): Update.
5364
5365 2019-08-20 Tom Tromey <tom@tromey.com>
5366
5367 * tui/tui-regs.h (struct tui_data_window): Use
5368 DISABLE_COPY_AND_ASSIGN.
5369 <regs_content>: Change type, removing unique_ptr.
5370 <tui_data_window>: Add move constructor.
5371 * tui/tui-regs.c (tui_data_window::show_registers)
5372 (tui_data_window::show_register_group)
5373 (tui_data_window::display_registers_from)
5374 (tui_data_window::display_registers_from)
5375 (tui_data_window::first_data_item_displayed)
5376 (tui_data_window::delete_data_content_windows)
5377 (tui_data_window::rerender, tui_data_window::refresh_window)
5378 (tui_data_window::check_register_values): Update.
5379
5380 2019-08-20 Tom Tromey <tom@tromey.com>
5381
5382 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5383 show_register_group>: Declare.
5384 (tui_show_register_group): Don't declare.
5385 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5386 tui_show_registers.
5387 (tui_data_window::show_register_group): Rename from
5388 tui_show_register_group.
5389 (tui_data_window::check_register_values, tui_reg_command):
5390 Update.
5391 * tui/tui-layout.c (tui_set_layout): Update.
5392
5393 2019-08-20 Tom Tromey <tom@tromey.com>
5394
5395 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5396 Declare.
5397 (tui_check_register_values): Don't declare.
5398 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5399 from tui_check_register_values.
5400 * tui/tui-hooks.c (tui_register_changed): Update.
5401
5402 2019-08-20 Tom Tromey <tom@tromey.com>
5403
5404 * tui/tui-regs.c (tui_reg_layout): Move later.
5405 (tui_show_registers): Don't enable TUI mode or change layout.
5406
5407 2019-08-20 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui-regs.h (struct tui_data_item_window)
5410 <~tui_data_item_window>: Remove.
5411 <content>: Now a unique_xmalloc_ptr.
5412 * tui/tui-regs.c (tui_register_format): Return a
5413 unique_xmalloc_ptr.
5414 (tui_get_register): Update.
5415 (~tui_data_item_window): Remove.
5416 (tui_data_window::display_registers_from, tui_display_register):
5417 Update.
5418 * tui/tui-io.h (tui_expand_tabs): Update.
5419 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5420 Remove "col" parameter.
5421
5422 2019-08-20 Tom Tromey <tom@tromey.com>
5423
5424 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5425 field.
5426 * tui/tui-regs.c (~tui_data_item_window): Update.
5427
5428 2019-08-20 Tom Tromey <tom@tromey.com>
5429
5430 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5431 earlier.
5432
5433 2019-08-20 Tom Tromey <tom@tromey.com>
5434
5435 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5436
5437 2019-08-20 Tom Tromey <tom@tromey.com>
5438
5439 * tui/tui-source.h (struct tui_source_window): Update.
5440 * tui/tui-regs.c (tui_show_registers): Update.
5441 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5442 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5443 (NO_REGS_STRING): Remove defines.
5444
5445 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
5446
5447 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5448 unnecessary thread walk if remote doesn't support the packet.
5449
5450 2019-08-19 Tom Tromey <tromey@adacore.com>
5451
5452 * python/py-value.c (value_has_field): Fix indentation.
5453
5454 2019-08-19 Tom Tromey <tromey@adacore.com>
5455
5456 * printcmd.c (do_one_display, info_display_command): Update.
5457 * block.h (contained_in): Return bool. Add allow_nested
5458 parameter.
5459 * block.c (contained_in): Return bool. Add allow_nested
5460 parameter.
5461
5462 2019-08-19 Tom Tromey <tom@tromey.com>
5463
5464 * configure: Rebuild.
5465 * configure.ac: Disallow the combination of -static-libstdc++ and
5466 source highlight.
5467 * source-cache.c (get_language_name): Handle rust.
5468 (source_cache::get_source_lines): Ignore highlighting exceptions.
5469
5470 2019-08-16 Tom Tromey <tom@tromey.com>
5471
5472 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5473 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5474 (struct tui_source_window_base) <make_visible, refresh_window,
5475 resize>: Remove methods.
5476 <execution_info>: Remove field.
5477 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5478 (tui_show_source_line, tui_source_window_base)
5479 (~tui_source_window_base): Update.
5480 (tui_source_window_base::resize)
5481 (tui_source_window_base::make_visible)
5482 (tui_source_window_base::refresh_window): Remove.
5483 (tui_source_window_base::update_exec_info): Update.
5484 * tui/tui-source.c (tui_source_window::set_contents): Update.
5485 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5486
5487 2019-08-16 Tom Tromey <tom@tromey.com>
5488
5489 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5490 deprecated_query_hook.
5491
5492 2019-08-16 Tom Tromey <tom@tromey.com>
5493
5494 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5495 (tui_update_source_windows_with_line): Update.
5496 * tui/tui-source.h (struct tui_source_window)
5497 <show_symtab_source>: Declare.
5498 (tui_show_symtab_source): Don't declare.
5499 * tui/tui-source.c (tui_show_symtab_source): Rename from
5500 tui_show_symtab_source.
5501
5502 2019-08-16 Tom Tromey <tom@tromey.com>
5503
5504 * tui/tui-winsource.h (struct tui_source_window_base)
5505 <set_contents>: Declare.
5506 * tui/tui-winsource.c
5507 (tui_source_window_base::update_source_window_as_is): Update.
5508 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5509 Declare.
5510 (tui_set_source_content): Don't declare.
5511 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5512 tui_set_source_content.
5513 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5514 Declare.
5515 (tui_set_disassem_content): Don't declare.
5516 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5517 tui_set_disassem_content.
5518
5519 2019-08-16 Tom Tromey <tom@tromey.com>
5520
5521 * tui/tui-winsource.h (struct tui_source_window_base)
5522 <update_breakpoint_info>: Declare.
5523 (tui_update_breakpoint_info): Don't declare.
5524 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5525 (tui_update_all_breakpoint_info): Update.
5526 (tui_source_window_base::update_breakpoint_info): Rename from
5527 tui_update_breakpoint_info.
5528 (tui_source_window_base::update_exec_info): Update.
5529
5530 2019-08-16 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-winsource.h (struct tui_source_window_base)
5533 <update_source_window>: Declare.
5534 (tui_update_source_window): Don't declare.
5535 * tui/tui-winsource.c
5536 (tui_source_window_base::update_source_window): Rename from
5537 tui_update_source_window.
5538 (tui_source_window_base::rerender): Update.
5539 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5540 * tui/tui-disasm.c (tui_show_disassem)
5541 (tui_show_disassem_and_update_source)
5542 (tui_disasm_window::maybe_update): Update.
5543
5544 2019-08-16 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-winsource.h (struct tui_source_window_base)
5547 <update_source_window_as_is>: Declare.
5548 (tui_update_source_window_as_is): Don't declare.
5549 * tui/tui-winsource.c (tui_update_source_window): Update
5550 (tui_source_window_base::update_source_window_as_is): Rename from
5551 tui_update_source_window_as_is.
5552 (tui_source_window_base::refill): Update.
5553 * tui/tui-source.c (tui_show_symtab_source): Update.
5554 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5555 Update.
5556
5557 2019-08-16 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-winsource.h (tui_update_source_window)
5560 (tui_update_source_window_as_is): Remove "noerror" parameter.
5561 * tui/tui-winsource.c (tui_update_source_window)
5562 (tui_update_source_window_as_is): Remove "noerror" parameter.
5563 (tui_update_source_windows_with_addr)
5564 (tui_update_source_windows_with_line)
5565 (tui_source_window_base::rerender)
5566 (tui_source_window_base::refill): Update.
5567 * tui/tui-source.h (tui_set_source_content)
5568 (tui_show_symtab_source): Remove "noerror" parameter.
5569 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5570 parameter.
5571 (tui_show_symtab_source): Likewise.
5572 (tui_source_window::maybe_update): Update.
5573 * tui/tui-disasm.c (tui_show_disassem)
5574 (tui_show_disassem_and_update_source)
5575 (tui_disasm_window::do_scroll_vertical)
5576 (tui_disasm_window::maybe_update): Update.
5577
5578 2019-08-16 Tom Tromey <tom@tromey.com>
5579
5580 * tui/tui.c (tui_is_window_visible): Update.
5581 * tui/tui-wingeneral.c (tui_make_window)
5582 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5583 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5584 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5585 (tui_set_win_height_command, parse_scrolling_args): Update.
5586 * tui/tui-source.c (tui_source_window::style_changed): Update.
5587 * tui/tui-regs.c (tui_show_registers)
5588 (tui_data_window::first_data_item_displayed)
5589 (tui_data_window::delete_data_content_windows)
5590 (tui_check_register_values, tui_reg_command): Update.
5591 * tui/tui-disasm.c (tui_show_disassem): Update.
5592 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5593 method.
5594 <is_visible>: Remove field.
5595 * tui/tui-data.c (tui_next_win, tui_prev_win)
5596 (tui_delete_invisible_windows): Update.
5597
5598 2019-08-16 Tom Tromey <tom@tromey.com>
5599
5600 * tui/tui-winsource.h (struct tui_source_window_base)
5601 <m_has_locator>: Remove.
5602 * tui/tui-layout.c (show_source_disasm_command, show_data)
5603 (show_source_or_disasm_and_command): Update.
5604
5605 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5606
5607 * NEWS (Other MI changes): New subsection.
5608 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5609 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5610 * arch-utils.c (default_get_pc_address_flags): New function.
5611 * arch-utils.h (default_get_pc_address_flags): New declaration.
5612 * gdbarch.sh: Add get_pc_address_flags.
5613 * gdbarch.c: Regenerate.
5614 * gdbarch.h: Likewise.
5615 * stack.c (print_pc): New function.
5616 (print_frame_info) (print_frame): Call print_pc.
5617
5618 2019-08-16 Tom de Vries <tdevries@suse.de>
5619
5620 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5621 print_objfile_section_info.
5622
5623 2019-08-15 Tom Tromey <tom@tromey.com>
5624
5625 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5626 calling update_cmdwin_start_line.
5627 * tui/tui-winsource.h (struct tui_source_window_base)
5628 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5629 <rerender>: Declare.
5630 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5631 Call rerender.
5632 (tui_source_window_base::set_new_height): Remove.
5633 (tui_source_window_base::rerender): Rename from
5634 do_make_visible_with_new_height.
5635 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5636 resize method.
5637 (tui_win_info::make_invisible_and_set_new_height)
5638 (tui_win_info::make_visible_with_new_height): Remove.
5639 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5640 Declare.
5641 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5642 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5643 do_make_visible_with_new_height>: Don't declare.
5644 <rerender>: Declare.
5645 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5646 set_new_height.
5647 (tui_data_window::do_make_visible_with_new_height): Remove.
5648 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5649 call tui_show_locator_content.
5650 (tui_gen_win_info::resize): Call rerender.
5651 (show_source_or_disasm_and_command): Don't call
5652 tui_show_locator_content.
5653 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5654 method.
5655 (struct tui_win_info) <rerender>: Declare.
5656 <set_new_height, make_invisible_and_set_new_height,
5657 make_visible_with_new_height>: Don't declare.
5658 * tui/tui-data.c (tui_win_list::rerender): New method.
5659 * tui/tui-command.h (struct tui_cmd_window)
5660 <do_make_visible_with_new_height>: Don't declare.
5661 * tui/tui-command.c
5662 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5663
5664 2019-08-15 Tom Tromey <tromey@adacore.com>
5665
5666 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5667 * ada-lang.c (ada_enum_name): Likewise.
5668
5669 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5670
5671 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5672 leading underscore.
5673 (GdbOutputErrorFile): Likewise.
5674 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5675 accordingly.
5676 (execute_unwinders): Rename to have a leading underscore.
5677 (auto_load_packages): Likewise.
5678 (global scope): Adjust call to auto_load_packages accordingly.
5679 (GdbSetPythonDirectory): Likewise.
5680 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5681 instead of execute_unwinders.
5682
5683 2019-08-15 Tom Tromey <tom@tromey.com>
5684
5685 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5686 (show_data): Don't change window visibility.
5687 (tui_gen_win_info::resize): Remove special case for command
5688 window. Use wresize, when available.
5689 (show_source_or_disasm_and_command): Don't change window
5690 visibility.
5691 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5692 <make_visible>: New method.
5693 * tui/tui-command.c (tui_cmd_window::resize): New method.
5694
5695 2019-08-15 Tom Tromey <tom@tromey.com>
5696
5697 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5698 (struct tui_source_windows): New.
5699 * tui/tui-winsource.c (tui_display_main): Update.
5700 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5701 (new_height_ok, parse_scrolling_args): Update.
5702 * tui/tui-layout.c (show_layout, show_data): Update.
5703 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5704 (tui_add_to_source_windows): Don't declare.
5705 * tui/tui-data.c (source_windows, tui_source_windows)
5706 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5707
5708 2019-08-15 Tom Tromey <tom@tromey.com>
5709
5710 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5711 Rename from reset.
5712 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5713 * tui/tui-layout.c (show_source_disasm_command, show_data):
5714 Update.
5715 (tui_gen_win_info::resize): Rename.
5716 (show_source_or_disasm_and_command): Update.
5717 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5718 reset.
5719
5720 2019-08-15 Tom Tromey <tom@tromey.com>
5721
5722 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5723 * tui/tui-interp.c (tui_interp::init): Don't call
5724 tui_initialize_static_data.
5725 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5726
5727 2019-08-15 Tom Tromey <tom@tromey.com>
5728
5729 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5730 examine tui_win_list.
5731
5732 2019-08-15 Tom Tromey <tom@tromey.com>
5733
5734 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5735 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5736 tui_clear_source_content.
5737 (tui_clear_source_content): Remove.
5738 (tui_source_window_base::do_erase_source_content): Hoist call to
5739 content.clear().
5740 * tui/tui-stack.c (tui_show_frame_info): Don't call
5741 tui_clear_source_content.
5742
5743 2019-08-15 Tom Tromey <tom@tromey.com>
5744
5745 * tui/tui-winsource.h (struct tui_source_window_base)
5746 <do_erase_source_content>: New method.
5747 <erase_source_content>: New method.
5748 (tui_erase_source_content): Don't declare.
5749 * tui/tui-winsource.c (tui_clear_source_content): Update.
5750 (tui_source_window_base::do_erase_source_content): Rename from
5751 tui_erase_source_content.
5752 (tui_source_window_base::show_source_content): Update.
5753 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5754 * tui/tui-source.h (struct tui_source_window)
5755 <erase_source_content>: New method.
5756 * tui/tui-disasm.h (struct tui_disasm_window)
5757 <erase_source_content>: New method.
5758
5759 2019-08-15 Tom Tromey <tom@tromey.com>
5760
5761 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5762 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5763 constructor.
5764 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5765 * tui/tui-source.c (tui_set_source_content): Update.
5766 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5767
5768 2019-08-15 Tom Tromey <tom@tromey.com>
5769
5770 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5771 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5772 tui-source.c.
5773 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5774 Declare.
5775 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5776 method.
5777 (tui_source_window::maybe_update): Update.
5778
5779 2019-08-15 Tom Tromey <tom@tromey.com>
5780
5781 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5782 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5783 tui-disasm.c.
5784 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5785 Declare.
5786 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5787 method.
5788 (tui_disasm_window::maybe_update): Update.
5789
5790 2019-08-15 Tom Tromey <tom@tromey.com>
5791
5792 * tui/tui-winsource.h (struct tui_source_window_base)
5793 <maybe_update>: Declare.
5794 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5795 method.
5796 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5797 Declare.
5798 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5799 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5800 Declare.
5801 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5802
5803 2019-08-15 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5806
5807 2019-08-15 Tom Tromey <tom@tromey.com>
5808
5809 * tui/tui-wingeneral.c: Include tui-stack.h.
5810 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5811 (struct tui_locator_window): Move from tui-data.h.
5812 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5813 (tui_initialize_static_data): Move from tui-data.c.
5814 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5815 (struct tui_locator_window): Move to tui-stack.c.
5816 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5817 (tui_initialize_static_data): Move to tui-stack.c.
5818
5819 2019-08-15 Tom Tromey <tom@tromey.com>
5820
5821 * tui/tui-layout.c (show_source_disasm_command)
5822 (show_source_or_disasm_and_command): Use make_visible method, not
5823 tui_make_window.
5824 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5825 Remove.
5826
5827 2019-08-15 Tom Tromey <tom@tromey.com>
5828
5829 * tui/tui-wingeneral.h (tui_make_window): Update.
5830 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5831 parameter.
5832 (tui_gen_win_info::make_visible): Update.
5833 * tui/tui-regs.c (tui_data_window::display_registers_from):
5834 Update.
5835 * tui/tui-layout.c (show_source_disasm_command)
5836 (show_source_or_disasm_and_command): Update.
5837 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5838 (enum tui_box): Remove.
5839 (struct tui_win_info) <can_box>: New method.
5840 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5841 method.
5842
5843 2019-08-15 Tom de Vries <tdevries@suse.de>
5844
5845 * linux-nat-trad.c: Include gdbarch.h.
5846
5847 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5848
5849 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5850 register sizes.
5851
5852 2019-08-14 Tom Tromey <tromey@adacore.com>
5853
5854 * darwin-nat.c: Include gdbarch.h.
5855 * darwin-nat-info.c: Include gdbarch.h.
5856
5857 2019-08-13 Tom Tromey <tom@tromey.com>
5858
5859 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5860 Remove.
5861 * tui/tui-data.c (tui_initialize_static_data): Update.
5862
5863 2019-08-13 Tom Tromey <tom@tromey.com>
5864
5865 * tui/tui-winsource.h (struct tui_exec_info_window)
5866 <~tui_exec_info_window, maybe_allocate_content, get_content,
5867 m_content>: Remove.
5868 (struct tui_source_window_base) <set_exec_info_content,
5869 show_exec_info_content>: Don't declare.
5870 * tui/tui-winsource.c
5871 (tui_exec_info_window::maybe_allocate_content): Remove.
5872 (tui_source_window_base::update_exec_info): Rename from
5873 set_exec_info_content.
5874 (tui_source_window_base::show_exec_info_content)
5875 (tui_source_window_base::update_exec_info): Remove.
5876
5877 2019-08-13 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5880 declare.
5881 * tui/tui-winsource.c (tui_update_source_window_as_is)
5882 (tui_update_source_windows_with_addr, tui_erase_source_content):
5883 Update.
5884 (tui_clear_exec_info_content): Remove.
5885
5886 2019-08-13 Tom Tromey <tom@tromey.com>
5887
5888 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5889 declare.
5890 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5891 call tui_erase_exec_info_content.
5892 (tui_clear_exec_info_content): Rename from
5893 tui_erase_exec_info_content.
5894 (tui_clear_exec_info_content): Delete.
5895
5896 2019-08-13 Tom Tromey <tom@tromey.com>
5897
5898 * tui/tui-winsource.h (struct tui_source_window_base)
5899 <show_exec_info_content>: Declare.
5900 (tui_show_exec_info_content): Don't declare.
5901 * tui/tui-winsource.c
5902 (tui_source_window_base::show_exec_info_content): Rename from
5903 tui_show_exec_info_content.
5904 (tui_source_window_base::update_exec_info): Update.
5905
5906 2019-08-13 Tom Tromey <tom@tromey.com>
5907
5908 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5909 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5910 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5911 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5912 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5913 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5914 ... here.
5915
5916 2019-08-13 Tom Tromey <tom@tromey.com>
5917
5918 * tui/tui-winsource.h (struct tui_source_window_base)
5919 <update_exec_info>: Declare.
5920 (tui_update_exec_info): Don't declare.
5921 * tui/tui-winsource.c (tui_update_source_window_as_is)
5922 (tui_source_window_base::refresh_all)
5923 (tui_update_all_breakpoint_info): Update.
5924 (tui_source_window_base::update_exec_info): Rename from
5925 tui_update_exec_info.
5926 * tui/tui-stack.c (tui_show_frame_info): Update.
5927
5928 2019-08-13 Tom Tromey <tom@tromey.com>
5929
5930 * tui/tui-winsource.h (struct tui_source_window_base)
5931 <set_exec_info_content>: Declare.
5932 (tui_set_exec_info_content): Don't declare.
5933 * tui/tui-winsource.c
5934 (tui_source_window_base::set_exec_info_content): Rename from
5935 tui_set_exec_info_content.
5936 (tui_update_exec_info): Update.
5937
5938 2019-08-13 Tom Tromey <tom@tromey.com>
5939
5940 * tui/tui-winsource.h (struct tui_source_window_base)
5941 <show_source_content>: Declare.
5942 (tui_show_source_content): Don't declare.
5943 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5944 (tui_source_window_base::show_source_content): Rename from
5945 tui_show_source_content.
5946 (tui_source_window_base::refresh_all): Update.
5947 * tui/tui-layout.c (show_source_disasm_command)
5948 (show_source_or_disasm_and_command): Update.
5949
5950 2019-08-13 Tom Tromey <tom@tromey.com>
5951
5952 * tui/tui-winsource.c (tui_erase_source_content)
5953 (tui_show_source_content, tui_source_window_base::refresh_all):
5954 Update.
5955 * tui/tui-wingeneral.h
5956 (tui_check_and_display_highlight_if_needed): Don't declare.
5957 * tui/tui-wingeneral.c
5958 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5959 check_and_display_highlight_if_needed.
5960 * tui/tui-win.c (tui_rehighlight_all)
5961 (tui_win_info::make_visible_with_new_height): Update.
5962 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5963 (tui_data_window::erase_data_content)
5964 (tui_data_window::display_all_data): Update.
5965 * tui/tui-data.h (struct tui_win_info)
5966 <check_and_display_highlight_if_needed>: Declare.
5967
5968 2019-08-13 Tom Tromey <tom@tromey.com>
5969
5970 * tui/tui-win.c (tui_resize_all): Call
5971 tui_delete_invisible_windows.
5972 * tui/tui-layout.c (show_layout): Call
5973 tui_delete_invisible_windows.
5974 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5975 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5976
5977 2019-08-13 Tom Tromey <tom@tromey.com>
5978
5979 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5980 tui_add_win_to_layout.
5981
5982 2019-08-13 Tom Tromey <tom@tromey.com>
5983
5984 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5985 * tui/tui-layout.c (tui_default_win_height): Now static.
5986
5987 2019-08-13 Tom Tromey <tom@tromey.com>
5988
5989 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5990 single switch.
5991 (show_source_disasm_command, show_source_or_disasm_and_command):
5992 Don't check current layout.
5993
5994 2019-08-13 Tom Tromey <tom@tromey.com>
5995
5996 * tui/tui-wingeneral.c (make_all_visible): Remove.
5997 (tui_make_all_invisible): Simplify.
5998 * tui/tui-layout.c (tui_make_all_invisible): Move from
5999 tui-wingeneral.c; simplify.
6000 (show_layout): Hoist call to tui_make_all_invisible.
6001 (show_data): Don't call tui_make_all_invisible.
6002
6003 2019-08-13 Tom Tromey <tom@tromey.com>
6004
6005 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6006 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6007
6008 2019-08-13 Tom Tromey <tom@tromey.com>
6009
6010 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6011 tui-data.c.
6012 (show_source_disasm_command, show_data)
6013 (show_source_or_disasm_and_command): Don't use
6014 tui_set_current_layout_to.
6015 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6016 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6017 tui-layout.c.
6018 (tui_set_current_layout_to): Remove.
6019
6020 2019-08-13 Tom Tromey <tom@tromey.com>
6021
6022 * tui/tui-layout.c (tui_set_layout): Update.
6023 * tui/tui-data.h (struct tui_layout_def): Remove.
6024 (tui_layout_def): Don't declare.
6025 * tui/tui-data.c (layout_def): Remove.
6026 (tui_layout_def): Remove.
6027
6028 2019-08-13 Tom Tromey <tom@tromey.com>
6029
6030 * tui/tui-winsource.h (struct tui_source_window_base)
6031 <clear_detail>: No longer "override".
6032 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6033 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6034 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6035 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6036 Remove.
6037 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6038
6039 2019-08-13 Tom Tromey <tromey@adacore.com>
6040
6041 * tracepoint.c: Don't include readline.h or history.h.
6042
6043 2019-08-12 Tom Tromey <tom@tromey.com>
6044
6045 * configure: Rebuild.
6046 * configure.ac: Check for readline 7.
6047 * NEWS: Mention readline 7 requirement.
6048 * README: Update.
6049
6050 2019-08-12 Tom Tromey <tom@tromey.com>
6051
6052 * mingw-hdep.c (gdb_select): Remove readline hack.
6053
6054 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6055
6056 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6057 when the function fails.
6058
6059 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6060
6061 * s390-tdep.c (s390_type_align): New function.
6062 (s390_gdbarch_init): Set it as type_align gdbarch method.
6063
6064 2019-08-09 Tom de Vries <tdevries@suse.de>
6065
6066 PR gdb/24591
6067 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6068 pc_low with relocation offset.
6069
6070 2019-08-07 Tom Tromey <tromey@adacore.com>
6071
6072 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6073 (print_frame_args): Update.
6074 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6075 Update.
6076 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6077 * frame.h (struct frame_arg): Add initializers.
6078 <error>: Now a unique_xmalloc_ptr.
6079
6080 2019-08-07 Alan Hayward <alan.hayward@arm.com>
6081
6082 * NEWS: Expand the Pointer Authentication entry.
6083 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6084 (aarch64_frame_unmask_lr): ... to this.
6085 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6086 Call aarch64_frame_unmask_lr.
6087 * frame.c (struct frame_info): Add "masked" variable.
6088 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6089 (fprint_frame): Check for masked pc.
6090 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6091 declarations.
6092 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6093 * stack.c (print_frame): Check for masked pc.
6094
6095 2019-08-06 Tom Tromey <tom@tromey.com>
6096
6097 * stabsread.c (patch_block_stabs, read_one_struct_field)
6098 (read_enum_type): Use obstack_strndup.
6099 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6100 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6101 * dwarf2read.c (guess_full_die_structure_name)
6102 (anonymous_struct_prefix): Use obstack_strndup.
6103 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6104 * c-exp.y (yylex): Use obstack_strndup.
6105 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6106 (write_var_or_type): Use obstack_strndup.
6107
6108 2019-08-06 Tom Tromey <tom@tromey.com>
6109
6110 * symfile.c (reread_symbols): Use obstack_strdup.
6111 * stabsread.c (read_type): Use obstack_strdup.
6112 * gdb_obstack.h (obstack_strdup): New overload.
6113 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6114 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6115 (dwarf2_canonicalize_name): Use obstack_strdup.
6116 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6117 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6118 Use obstack_strdup.
6119
6120 2019-08-06 Tom Tromey <tom@tromey.com>
6121
6122 * gdb_obstack.h (obstack_strdup): Define.
6123 * gdb_obstack.c (obstack_strdup): Don't define.
6124
6125 2019-08-06 Tom Tromey <tom@tromey.com>
6126
6127 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6128 obstack_strdup.
6129 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6130 obstack_strdup.
6131 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6132 * stabsread.c (common_block_start): Use obstack_strdup.
6133 * objfiles.c (set_objfile_main_name, objfile): Use
6134 obstack_strdup.
6135 * namespace.c (add_using_directive): Use obstack_strdup.
6136 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6137 * jit.c (finalize_symtab): Use obstack_strdup.
6138 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6139 (guess_partial_die_structure_name, partial_die_info::fixup)
6140 (dwarf2_name): Use obstack_strdup.
6141 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6142 obstack_strdup.
6143 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6144 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6145 obstack_strdup.
6146 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6147
6148 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6149
6150 * unittests/help-doc-selftests.c: New file.
6151 * Makefile.in: Add the new file.
6152
6153 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6154
6155 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6156 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6157 the full first line, except when FOR_VALUE_PREFIX. In this case,
6158 the trailing '.' is not output, and the first character is uppercased.
6159 (print_help_for_command): Update call to print_doc_line.
6160 (print_doc_of_command): Likewise.
6161 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6162 * cli/cli-option.c (append_indented_doc): Do not append newline.
6163 (build_help_option): Append newline after first appended_indented_doc
6164 only if a second call is done.
6165 (build_help): Append 2 new lines before each option, except the first
6166 one.
6167 * compile/compile.c (_initialize_compile): Add new lines after
6168 %OPTIONS%, when not at the end of the help.
6169 Change help doc or code
6170 producing the help doc to respect the invariants.
6171 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6172 Also removed the new line after 'Options:', as all other commands
6173 do not put an empty line between 'Options:' and the first option.
6174 * printcmd.c (_initialize_printcmd): Likewise.
6175 * stack.c (_initialize_stack): Likewise.
6176 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6177 incorrectly telling COMMAND is optional.
6178 * ada-lang.c (_initialize_ada_language): Change help doc or code
6179 producing the help doc to respect the invariants.
6180 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6181 * breakpoint.c (_initialize_breakpoint): Likewise.
6182 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6183 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6184 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6185 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6186 _initialize_cli_style): Likewise.
6187 * corelow.c (core_target_info): Likewise.
6188 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6189 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6190 * filesystem.c (_initialize_filesystem): Likewise.
6191 * frame.c (_initialize_frame): Likewise.
6192 * gnu-nat.c (add_task_commands): Likewise.
6193 * infcall.c (_initialize_infcall): Likewise.
6194 * infcmd.c (_initialize_infcmd): Likewise.
6195 * interps.c (_initialize_interpreter): Likewise.
6196 * language.c (_initialize_language): Likewise.
6197 * linux-fork.c (_initialize_linux_fork): Likewise.
6198 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6199 * maint.c (_initialize_maint_cmds): Likewise.
6200 * memattr.c (_initialize_mem): Likewise.
6201 * printcmd.c (_initialize_printcmd): Likewise.
6202 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6203 _RegEx): Likewise.
6204 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6205 * record-btrace.c (_initialize_record_btrace): Likewise.
6206 * record-full.c (_initialize_record_full): Likewise.
6207 * record.c (_initialize_record): Likewise.
6208 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6209 * regcache.c (_initialize_regcache): Likewise.
6210 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6211 _initialize_remote): Likewise.
6212 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6213 * serial.c (_initialize_serial): Likewise.
6214 * skip.c (_initialize_step_skip): Likewise.
6215 * source.c (_initialize_source): Likewise.
6216 * stack.c (_initialize_stack): Likewise.
6217 * symfile.c (_initialize_symfile): Likewise.
6218 * symtab.c (_initialize_symtab): Likewise.
6219 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6220 * top.c (init_main): Likewise.
6221 * tracefile-tfile.c (tfile_target_info): Likewise.
6222 * tracepoint.c (_initialize_tracepoint): Likewise.
6223 * tui/tui-win.c (_initialize_tui_win): Likewise.
6224 * utils.c (add_internal_problem_command): Likewise.
6225 * valprint.c (value_print_option_defs): Likewise.
6226
6227 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
6228
6229 PR build/24886
6230 * configure.ac: Drop enable-libmcheck support.
6231 * configure, config.in: Rebuild.
6232 * libmcheck.m4: Remove.
6233 * acinclude.m4: Don't include it.
6234 * Makefile.in: Don't distribute it.
6235 * top.c (print_gdb_configuration): Don't mention it.
6236
6237 2019-08-06 Tom Tromey <tom@tromey.com>
6238
6239 * utils.c (set_output_style): Sometimes pass stream to
6240 emit_style_escape.
6241 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6242 * record-btrace.c (btrace_insn_history): Update.
6243 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6244 method.
6245 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6246 Update initializers.
6247 <m_uiout>: New field.
6248 <m_di>: Move lower.
6249 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6250 Remove "uiout" parameter.
6251 (dump_insns): Update.
6252 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6253 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6254
6255 2019-08-06 Christian Biesinger <cbiesinger@google.com>
6256
6257 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6258 (error_in_psymtab_expansion): Likewise.
6259 (lookup_symbol_via_quick_fns): Likewise.
6260 (basic_lookup_transparent_type_quick): Likewise.
6261 (basic_lookup_transparent_type_1): Likewise.
6262
6263 2019-08-06 Tom Tromey <tromey@adacore.com>
6264
6265 * source.c (last_source_error): Now bool.
6266 (print_source_lines_base): Make "noprint" bool. Only open
6267 source file when last_source_visited changes.
6268
6269 2019-08-06 Tom Tromey <tromey@adacore.com>
6270
6271 * annotate.c (annotate_source_line): Use g_source_cache.
6272 * source-cache.c (source_cache::get_plain_source_lines): Change
6273 parameters. Populate m_offset_cache.
6274 (source_cache::ensure): New method.
6275 (source_cache::get_line_charpos): New method.
6276 (extract_lines): Move lower. Change parameters.
6277 (source_cache::get_source_lines): Move lower.
6278 * source-cache.h (class source_cache): Update comment.
6279 <get_line_charpos>: New method.
6280 <get_source_lines>: Update comment.
6281 <clear>: Clear m_offset_cache.
6282 <get_plain_source_lines>: Change parameters.
6283 <ensure>: New method
6284 <m_offset_cache>: New member.
6285 * source.c (forget_cached_source_info_for_objfile): Update.
6286 (info_source_command): Use g_source_cache.
6287 (find_source_lines, open_source_file_with_line_charpos): Remove.
6288 (print_source_lines_base, search_command_helper): Use g_source_cache.
6289 * source.h (open_source_file_with_line_charpos): Don't declare.
6290 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6291 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6292 Use g_source_cache.
6293
6294 2019-08-06 Tom Tromey <tromey@adacore.com>
6295
6296 * source-cache.c (source_cache::get_plain_source_lines):
6297 Remove "first_line" and "last_line" parameters.
6298 (source_cache::get_source_lines): Cache plain text.
6299 * source-cache.h (class source_cache)
6300 <get_plain_source_lines>: Update.
6301
6302 2019-08-06 Tom Tromey <tromey@adacore.com>
6303
6304 * source-cache.c (extract_lines): No longer a method.
6305 Changed type of parameter. Include final newline.
6306 (selftests::extract_lines_test): New function.
6307 (_initialize_source_cache): Likewise.
6308 * source-cache.h (class source_cache)
6309 <extract_lines>: Don't declare.
6310
6311 2019-08-06 Tom Tromey <tromey@adacore.com>
6312
6313 * breakpoint.c (init_breakpoint_sal): Update.
6314 (breakpoint): Update.
6315 * breakpoint.h (struct breakpoint) <filter>: Now a
6316 unique_xmalloc_ptr.
6317
6318 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6319
6320 * NEWS: Mention dictionary access on blocks.
6321 * python/py-block.c (blpy_getitem): New function.
6322 (block_object_as_mapping): New struct.
6323 (block_object_type): Use new struct for tp_as_mapping field.
6324
6325 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6326
6327 * objfiles.h (objfile): Add a comment describing partial symbols.
6328
6329 2019-08-05 Tom Tromey <tromey@adacore.com>
6330
6331 * compile/compile.c (_initialize_compile): Use _(), not N_().
6332 * thread.c (_initialize_thread): Use _(), not N_().
6333 * stack.c (_initialize_stack): Use _(), not N_().
6334 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6335
6336 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6337
6338 * dwarf2read.c (struct dw2_symtab_iterator):
6339 <want_specific_block>: Remove.
6340 <block_index>: Change type to gdb::optional.
6341 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6342 change type of BLOCK_INDEX parameter to gdb::optional.
6343 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6344 (dw2_lookup_symbol): Don't pass argument for
6345 WANT_SPECIFIC_BLOCK.
6346 (dw2_expand_symtabs_for_function): Don't pass argument for
6347 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6348 (class dw2_debug_names_iterator)
6349 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6350 parameter, change BLOCK_INDEX type to gdb::optional.
6351 <m_want_specific_block>: Remove.
6352 <m_block_index>: Change type to gdb::optional.
6353 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6354 gdb::optional. Re-write in function of gdb::optional.
6355 (dw2_debug_names_lookup_symbol): Don't pass argument for
6356 WANT_SPECIFIC_BLOCK.
6357 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6358 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6359 BLOCK_INDEX.
6360
6361 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6362
6363 * NEWS: Mention changes to "info sources" command.
6364
6365 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6366
6367 * symtab.c (filename_partial_match_opts): New struct type.
6368 (struct output_source_filename_data): New members
6369 regexp, c_regexp, partial_match.
6370 (output_source_filename): Use new members to decide to print file.
6371 (info_sources_option_defs): New variable.
6372 (make_info_sources_options_def_group, print_info_sources_header,
6373 info_sources_command_completer):
6374 New functions.
6375 (info_sources_command): Read new optional arguments.
6376 (_initialize_symtab): Update info sources help.
6377
6378 2019-08-02 Alexandre Oliva <oliva@adacore.com>
6379
6380 * ada-lang.c (exception_support_info_v0): Renamed from...
6381 (default_exception_support_info): ... this. Create new
6382 definition for v1.
6383 (ada_has_this_exception_support): Look up catch_handlers_sym.
6384 (ada_exception_support_info_sniffer): Try v0 after default.
6385
6386 2019-08-01 Tom Tromey <tromey@adacore.com>
6387
6388 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6389 gdbarch.h.
6390
6391 2019-08-01 Christian Biesinger <cbiesinger@google.com>
6392
6393 * s12z-tdep.c: Fix include path for s12z-opc.h.
6394
6395 2019-08-01 Alan Hayward <alan.hayward@arm.com>
6396
6397 * NEWS: Require GNU make 3.82.
6398
6399 2019-07-16 Tom Tromey <tom@tromey.com>
6400
6401 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6402 declare.
6403
6404 2019-07-30 Tom Tromey <tromey@adacore.com>
6405
6406 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6407
6408 2019-07-30 Kevin Buettner <kevinb@redhat.com>
6409
6410 * printcmd.c (print_address_symbolic): Print negative offsets.
6411 (build_address_symbolic): Force signed arithmetic when computing
6412 offset.
6413
6414 2019-07-30 Christian Biesinger <cbiesinger@google.com>
6415
6416 PR/24474: Add a function to lookup static variables.
6417 * NEWS: Mention this new function.
6418 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6419 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6420 * python/python.c (python_GdbMethods): Add new function.
6421
6422 2019-07-29 Christian Biesinger <cbiesinger@google.com>
6423
6424 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6425 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6426 (objfpy_lookup_static_symbol): New function.
6427 (objfile_object_methods): Add new functions.
6428
6429 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6430
6431 * NEWS: Mention 'set|show print frame-info'. Mention new
6432 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6433 backtrace argument. Mention that python frame filtering code
6434 is now consistent with what 'backtrace' command prints.
6435
6436 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6437
6438 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6439 comments.
6440 (print_frame_info_auto, print_frame_info_source_line,
6441 print_frame_info_location, print_frame_info_source_and_location,
6442 print_frame_info_location_and_address, print_frame_info_short_location):
6443 New declarations.
6444 (struct frame_print_options): New member print_frame_info.
6445 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6446 * stack.h (get_user_print_what_frame_info): New declaration.
6447 (frame_show_address): New declaration.
6448 * stack.c (print_frame_arguments_choices): New value 'presence'.
6449 (print_frame_info_auto, print_frame_info_source_line,
6450 print_frame_info_location, print_frame_info_source_and_location,
6451 print_frame_info_location_and_address, print_frame_info_short_location,
6452 print_frame_info_choices, print_frame_info_print_what): New definitions.
6453 (print_frame_args): Only print dots for args if print frame-arguments
6454 is 'presence'.
6455 (frame_print_option_defs): New element for "frame-info".
6456 (get_user_print_what_frame_info): New function.
6457 (frame_show_address): Make non static. Move comment to stack.h.
6458 (print_frame_info_to_print_what): New function.
6459 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6460 to decide what to print.
6461 (backtrace_command_1): Handle the new print_frame_arguments_presence
6462 value.
6463 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6464 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6465 (py_print_frame): In non-mi mode, use LOCATION as default for
6466 print_what, similarly to frame information printed directly by
6467 backtrace command. Handle frame-info user option in non MI mode.
6468
6469 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6470
6471 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6472 Add case for debugging 32-bit target on 64-bit host. Revise
6473 comment.
6474
6475 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6476
6477 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6478 instead of find_function_entry_range_from_pc.
6479
6480 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6481
6482 * stack.c (find_frame_funname): Remove code which preferred
6483 minsym over symtab sym in "certain pathological cases".
6484
6485 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6486 parameter. Change type of "do_demangle" to bool.
6487 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6488 Pass suitable "prefer_sym_over_minsym" flag to
6489 build_address_symbolic(). Don't output "+" for negative offsets.
6490 * printcmd.c (print_address_symbolic): Update invocation of
6491 build_address_symbolic to include a "prefer_sym_over_minsym"
6492 flag.
6493 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6494 Restrict cases in which use of minimal symbol is preferred to that
6495 of a found symbol. Update comments.
6496
6497 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6498 for entry pc when entry pc is out of range for that FDE.
6499
6500 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6501
6502 PR gdb/24839:
6503 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6504 type.
6505
6506 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6507
6508 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6509 this function's Python signature.
6510
6511
6512 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6513
6514 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6515 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6516 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6517 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6518 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6519
6520
6521 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6522
6523 * h8300-tdep.c (h8300_register_name_common): New.
6524 h8300_register_name): Use h8300_register_name_common.
6525 (h8300s_register_name): Likewise.
6526 (h8300sx_register_name): Likewise.
6527 (h8300h_register_nam): New.
6528 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6529
6530
6531 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6532
6533 * arm-tdep.c (arm_skip_cmse_entry): New function.
6534 (arm_is_sgstubs_section): New function.
6535 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6536
6537 2019-07-22 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6540 Don't self-assign.
6541
6542 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6543
6544 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6545 type_print.
6546
6547 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6548
6549 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6550 so that GDB doesn't match any msymbols when searching in the
6551 TYPES_DOMAIN.
6552 (print_symbol_info): Print using typedef_print or type_print based
6553 on the type of the symbol. Add updated FIXME comment moved from...
6554 (_initialize_symtab): ... move and update FIXME comment to above.
6555
6556 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6557
6558 * NEWS: Mention adding -q option to "info types".
6559 * symtab.c (struct info_types_options): New struct.
6560 (info_types_options_defs): New variable.
6561 (make_info_types_options_def_group): New function.
6562 (info_types_command): Use gdb::option framework to parse options.
6563 (info_types_command_completer): New function.
6564 (_initialize_symtab): Extend the help text on "info types" and
6565 register command completer.
6566
6567 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6568
6569 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6570 (lookup_symbol_in_objfile): Change int to block_enum and add a
6571 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6572
6573 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6574
6575 * MAINTAINERS (Write After Approval): Add self.
6576
6577 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6578
6579 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6580 instruction to the dummy code region.
6581
6582 2019-07-19 Tom Tromey <tromey@adacore.com>
6583
6584 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6585 (ARGSUSED, PARAMS, __func__): Remove rules.
6586
6587 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6588
6589 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6590 * features/arm/arm-with-iwmmxt.c: Remove.
6591 * features/arm/arm-with-iwmmxt.xml: Remove.
6592 * features/arm/arm-with-m-fpa-layout.c: Remove.
6593 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6594 * features/arm/arm-with-m-vfp-d16.c: Remove.
6595 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6596 * features/arm/arm-with-m.c: Remove.
6597 * features/arm/arm-with-m.xml: Remove.
6598 * features/arm/arm-with-neon.c: Remove.
6599 * features/arm/arm-with-neon.xml: Remove.
6600 * features/arm/arm-with-vfpv2.c: Remove.
6601 * features/arm/arm-with-vfpv2.xml: Remove.
6602 * features/arm/arm-with-vfpv3.c: Remove.
6603 * features/arm/arm-with-vfpv3.xml: Remove.
6604
6605 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6606
6607 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6608
6609 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6610
6611 * arch/aarch32.c (aarch32_create_target_description): Create
6612 target descriptions using features.
6613 * arch/arm.c (arm_create_target_description)
6614 (arm_create_mprofile_target_description): Likewise.
6615 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6616
6617 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6618
6619 * Makefile.in: Add new files.
6620 * aarch32-tdep.c: New file.
6621 * aarch32-tdep.h: New file.
6622 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6623 Call aarch32_read_description.
6624 * arch/aarch32.c: New file.
6625 * arch/aarch32.h: New file.
6626 * arch/arm.c (arm_create_target_description)
6627 (arm_create_mprofile_target_description): New function.
6628 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6629 (arm_create_target_description)
6630 (arm_create_mprofile_target_description): New declaration.
6631 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6632 read_description functions.
6633 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6634 Likewise.
6635 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6636 * arm-tdep.c (tdesc_arm_list): New variable.
6637 (arm_register_g_packet_guesses): Call create description functions.
6638 (arm_read_description) (arm_read_mprofile_description): New
6639 function.
6640 * arm-tdep.h (arm_read_description)
6641 (arm_read_mprofile_description): Add declaration.
6642 * configure.tgt: Add new files.
6643
6644 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6645
6646 * top.c (new_ui_command): Open specified terminal just once.
6647
6648 2019-07-18 Tom Tromey <tromey@adacore.com>
6649
6650 * symtab.c (main_name): Constify return type.
6651 * symfile.c (set_initial_language): Update.
6652 * symtab.h (main_name): Constify return type.
6653
6654 2019-07-17 Tom Tromey <tom@tromey.com>
6655
6656 * tui/tui-winsource.c (tui_update_source_window)
6657 (tui_update_source_window_as_is)
6658 (tui_update_source_windows_with_line): Remove return.
6659 * tui/tui-disasm.c (tui_show_disassem)
6660 (tui_show_disassem_and_update_source): Remove return.
6661 * tui/tui.c (tui_reset): Remove return.
6662 * tui/tui-wingeneral.c
6663 (tui_check_and_display_highlight_if_needed): Remove return.
6664
6665 2019-07-17 Tom Tromey <tom@tromey.com>
6666
6667 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6668
6669 2019-07-17 Tom Tromey <tom@tromey.com>
6670
6671 * tui/tui-winsource.h (struct tui_exec_info_window)
6672 (struct tui_source_window_base): Move from tui-data.h.
6673 * tui/tui-winsource.c: Move many method definitions from
6674 elsewhere. Remove "structuring" comments.
6675 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6676 (tui_source_window_base::refresh_window): Move to
6677 tui-winsource.c.
6678 * tui/tui-win.c (tui_source_window_base::refresh_all)
6679 (tui_source_window_base::update_tab_width)
6680 (tui_source_window_base::set_new_height)
6681 (tui_source_window_base::do_make_visible_with_new_height): Move to
6682 tui-winsource.c.
6683 * tui/tui-source.h: Update.
6684 * tui/tui-source.c (tui_source_window_base::reset): Move to
6685 tui-winsource.c.
6686 * tui/tui-disasm.h: Update.
6687 * tui/tui-data.h (struct tui_exec_info_window): Move to
6688 tui-winsource.h.
6689 (struct tui_source_window_base): Likewise.
6690 * tui/tui-data.c (tui_source_window_base::clear_detail)
6691 (tui_source_window_base, ~tui_source_window_base): Move to
6692 tui-winsource.c.
6693
6694 2019-07-17 Tom Tromey <tom@tromey.com>
6695
6696 * tui/tui-win.c (tui_resize_all)
6697 (tui_source_window_base::update_tab_width)
6698 (tui_adjust_win_heights): Update.
6699 (tui_win_info::make_invisible_and_set_new_height): Rename from
6700 make_invisible_and_set_new_height.
6701 * tui/tui-data.h (struct tui_win_info)
6702 <make_invisible_and_set_new_height>: New method.
6703
6704 2019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui.c: Update.
6707 * tui/tui-source.h (struct tui_source_window): Move from
6708 tui-data.h.
6709 * tui/tui-layout.c: Update.
6710 * tui/tui-disasm.c: Update.
6711 * tui/tui-data.h (struct tui_source_window): Move to
6712 tui-source.h.
6713
6714 2019-07-17 Tom Tromey <tom@tromey.com>
6715
6716 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6717 tui-data.h.
6718 * tui/tui-data.h (struct tui_disasm_window): Move to
6719 tui-disasm.h.
6720
6721 2019-07-17 Tom Tromey <tom@tromey.com>
6722
6723 * tui/tui-regs.h (struct tui_data_item_window): Move from
6724 tui-data.h.
6725 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6726 * tui/tui-data.h (struct tui_data_item_window): Move to
6727 tui-regs.h.
6728 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6729
6730 2019-07-17 Tom Tromey <tom@tromey.com>
6731
6732 * tui/tui.c: Update.
6733 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6734 (tui_cmd_window::max_height): Move to tui-command.c.
6735 * tui/tui-layout.c: Update.
6736 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6737 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6738 tui-command.c.
6739 * tui/tui-command.h (struct tui_cmd_window): Move from
6740 tui-data.h.
6741 * tui/tui-command.c: Remove "structuring" comments.
6742 (tui_cmd_window::clear_detail)
6743 (tui_cmd_window::do_make_visible_with_new_height)
6744 (tui_cmd_window::max_height): Move from elsewhere.
6745
6746 2019-07-17 Tom Tromey <tom@tromey.com>
6747
6748 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6749 Now static.
6750 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6751 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6752
6753 2019-07-17 Tom Tromey <tom@tromey.com>
6754
6755 * tui/tui.c: Update.
6756 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6757 tui-regs.c.
6758 * tui/tui-windata.h: Remove file.
6759 * tui/tui-windata.c: Remove file.
6760 * tui/tui-win.c (tui_data_window::set_new_height)
6761 (tui_data_window::do_make_visible_with_new_height): Move to
6762 tui-regs.c.
6763 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6764 * tui/tui-regs.c: Remove "structuring" comments.
6765 (tui_data_window::first_data_item_displayed)
6766 (tui_data_window::delete_data_content_windows)
6767 (tui_data_window::erase_data_content)
6768 (tui_data_window::display_all_data)
6769 (tui_data_window::refresh_all)
6770 (tui_data_window::do_scroll_vertical)
6771 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6772 (tui_data_window::do_make_visible_with_new_height)
6773 (tui_data_window::refresh_window): Move from elsewhere.
6774 (_initialize_tui_regs): Move to end of file.
6775 * tui/tui-layout.c: Update.
6776 * tui/tui-hooks.c: Update.
6777 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6778 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6779 tui-regs.c.
6780 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6781
6782 2019-07-17 Tom Tromey <tom@tromey.com>
6783
6784 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6785 seen.
6786
6787 2019-07-17 Tom Tromey <tom@tromey.com>
6788
6789 * tui/tui-win.c (tui_source_window_base::set_new_height)
6790 (tui_source_window_base::do_make_visible_with_new_height): Use
6791 m_has_locator field directly.
6792 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6793 method.
6794 (struct tui_source_window_base) <has_locator>: Likewise.
6795
6796 2019-07-17 Tom Tromey <tom@tromey.com>
6797
6798 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6799 Don't declare.
6800 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6801 Remove.
6802 * tui/tui-win.c (tui_source_window_base::set_new_height)
6803 (tui_source_window_base::set_new_height)
6804 (make_invisible_and_set_new_height)
6805 (tui_source_window_base::do_make_visible_with_new_height)
6806 (tui_source_window_base::do_make_visible_with_new_height):
6807 Update.
6808 * tui/tui-layout.c (show_source_disasm_command, show_data)
6809 (show_source_or_disasm_and_command): Update.
6810 * tui/tui-layout.c (show_layout): Update.
6811
6812 2019-07-17 Tom Tromey <tom@tromey.com>
6813
6814 * tui/tui-layout.c (make_data_window): Remove.
6815 (show_data): Unify creation and re-initialization cases.
6816
6817 2019-07-17 Tom Tromey <tom@tromey.com>
6818
6819 * tui/tui-layout.c (make_source_window, make_disasm_window):
6820 Remove.
6821 (show_data): Unify creation and re-initialization cases.
6822
6823 2019-07-17 Tom Tromey <tom@tromey.com>
6824
6825 * tui/tui-layout.c (make_command_window): Remove.
6826 (show_source_disasm_command, show_source_or_disasm_and_command):
6827 Unify creation and re-initialization cases.
6828
6829 2019-07-17 Tom Tromey <tom@tromey.com>
6830
6831 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6832 creation and re-initialization cases.
6833
6834 2019-07-17 Tom Tromey <tom@tromey.com>
6835
6836 * tui/tui-regs.c (tui_get_register): Return void.
6837
6838 2019-07-17 Tom Tromey <tom@tromey.com>
6839
6840 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6841 Simplify.
6842
6843 2019-07-17 Tom Tromey <tom@tromey.com>
6844
6845 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6846 resetting.
6847
6848 2019-07-17 Tom Tromey <tom@tromey.com>
6849
6850 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6851 * tui/tui-regs.c (tui_reg_layout): New function.
6852 (tui_show_registers, tui_reg_command): Use it.
6853 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6854 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6855 parameters.
6856 (tui_layout_command): Remove.
6857
6858 2019-07-17 Tom Tromey <tom@tromey.com>
6859
6860 * tui/tui-layout.h (tui/tui-layout): Return void.
6861 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6862
6863 2019-07-17 Tom Tromey <tom@tromey.com>
6864
6865 * tui/tui-layout.c (show_source_disasm_command, show_data):
6866 Update.
6867 (reset_locator): Remove.
6868 (show_source_or_disasm_and_command): Update.
6869
6870 2019-07-17 Tom Tromey <tom@tromey.com>
6871
6872 * tui/tui-source.c (tui_source_window_base::reset): Remove
6873 win_type parameter.
6874 * tui/tui-layout.c (make_command_window, make_source_window)
6875 (make_disasm_window, make_data_window)
6876 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6877 (reset_locator, show_source_or_disasm_and_command): Update.
6878 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6879 win_type parameter.
6880 (struct tui_source_window_base) <reset>: Likewise.
6881
6882 2019-07-17 Tom Tromey <tom@tromey.com>
6883
6884 * tui/tui-layout.c (show_source_disasm_command): Use
6885 reset_locator.
6886 (reset_locator): New function.
6887 (init_and_make_win): Remove.
6888 (show_source_or_disasm_and_command): Use reset_locator.
6889
6890 2019-07-17 Tom Tromey <tom@tromey.com>
6891
6892 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6893 condition.
6894 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6895 Remove condition.
6896 * tui/tui-source.c (tui_source_window_base::reset): New method.
6897 * tui/tui-layout.c (make_command_window): Don't call
6898 init_and_make_win.
6899 (make_source_window, make_disasm_window): Don't call
6900 make_source_or_disasm_window.
6901 (make_data_window): Don't call init_and_make_win. Change calling
6902 convention.
6903 (show_source_disasm_command, show_data): Simplify.
6904 (make_source_or_disasm_window): Remove.
6905 (show_source_or_disasm_and_command): Simplify.
6906 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6907 (struct tui_source_window_base) <reset>: Likewise.
6908 <execution_info>: Remove initializer.
6909 * tui/tui-data.c (tui_source_window_base): Initialize
6910 execution_info.
6911
6912 2019-07-17 Tom Tromey <tom@tromey.com>
6913
6914 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6915 variable.
6916
6917 2019-07-17 Tom Tromey <tom@tromey.com>
6918
6919 * tui/tui.c (tui_rl_other_window): Update.
6920 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6921 superclass method first. Always iterate over regs_content.
6922 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6923 method.
6924 * tui/tui-win.c (tui_set_focus_command): Update.
6925
6926 2019-07-17 Tom Tromey <tom@tromey.com>
6927
6928 * tui/tui-win.c (tui_set_focus_command): Rename from
6929 tui_set_focus. Call tui_enable.
6930 (tui_set_focus_command): Remove.
6931
6932 2019-07-17 Tom Tromey <tom@tromey.com>
6933
6934 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6935 refresh_window.
6936 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6937 touchwin.
6938 (tui_data_window::refresh_window): Call refresh_window on data
6939 items. Always call superclass refresh_window.
6940 (tui_win_info::refresh): Remove.
6941 (tui_source_window_base::refresh_window): Update.
6942 (tui_refresh_all): Update.
6943 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6944 refresh_window.
6945 (show_source_or_disasm_and_command): Likewise.
6946 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6947 (struct tui_source_window_base) <refresh>: Likewise.
6948
6949 2019-07-17 Tom Tromey <tom@tromey.com>
6950
6951 * tui/tui-winsource.c (tui_clear_source_content)
6952 (tui_show_source_content): Update.
6953 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6954 whether content is empty.
6955 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6956 Remove.
6957
6958 2019-07-17 Tom Tromey <tom@tromey.com>
6959
6960 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6961 window's contents.
6962 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6963 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6964
6965 2019-07-17 Tom Tromey <tom@tromey.com>
6966
6967 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6968 (struct tui_data_item_window): Update.
6969
6970 2019-07-17 Tom Tromey <tom@tromey.com>
6971
6972 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6973 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6974 defines.
6975
6976 2019-07-17 Tom Tromey <tom@tromey.com>
6977
6978 * tui/tui-winsource.h (tui_erase_source_content)
6979 (tui_clear_source_content): Remove "display_prompt" parameter.
6980 * tui/tui-winsource.c (tui_update_source_window_as_is)
6981 (tui_update_source_windows_with_addr): Update.
6982 (tui_clear_source_content): Remove "display_prompt" parameter.
6983 (tui_erase_source_content): Likewise. Simplify.
6984 (tui_show_source_content): Update.
6985 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6986 * tui/tui-stack.c (tui_show_frame_info): Update.
6987 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6988 Remove defines.
6989
6990 2019-07-17 Tom Tromey <tom@tromey.com>
6991
6992 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6993 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6994 parameter.
6995 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6996 parameter.
6997
6998 2019-07-17 Tom Tromey <tom@tromey.com>
6999
7000 * tui/tui-winsource.c (tui_clear_source_content)
7001 (tui_show_source_content, tui_show_exec_info_content)
7002 (tui_clear_exec_info_content): Update.
7003 * tui/tui-stack.c (tui_show_locator_content): Update.
7004 (tui_show_frame_info): Update.
7005 * tui/tui-source.h (tui_source_window): Don't declare.
7006 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7007 from tui_source_is_displayed.
7008 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7009 Remove field.
7010 (struct tui_source_window_base) <content_in_use>: New field. Now
7011 bool.
7012 (struct tui_source_window) <showing_source_p>: New method.
7013 (TUI_SRC_WIN): Change cast.
7014 * tui/tui-data.c (tui_initialize_static_data): Update.
7015
7016 2019-07-17 Tom Tromey <tom@tromey.com>
7017
7018 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7019 location_matches_p.
7020 * tui/tui-source.c (tui_source_window::location_matches_p): New
7021 method.
7022 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7023 method.
7024 * tui/tui-data.h (struct tui_source_window_base)
7025 <location_matches_p>: New method.
7026 (struct tui_source_window, struct tui_disasm_window)
7027 <location_matches_p>: Likewise.
7028
7029 2019-07-17 Tom Tromey <tom@tromey.com>
7030
7031 * tui/tui-win.c (tui_set_win_height_command): Rename from
7032 tui_set_win_height.
7033 (tui_set_win_height_command): Remove.
7034
7035 2019-07-17 Tom Tromey <tom@tromey.com>
7036
7037 * tui/tui-source.c (tui_source_window): New constructor. Add
7038 observer.
7039 (~tui_source_window): New destructor.
7040 (tui_source_window::style_changed): New method.
7041 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7042 (tui_attach_detach_observers): Update.
7043 * tui/tui-data.h (struct tui_source_window): Make constructor not
7044 inline. Add destructor.
7045 (struct tui_source_window) <style_changed>: New method.
7046 <m_observable>: New member.
7047
7048 2019-07-17 Tom Tromey <tom@tromey.com>
7049
7050 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7051 * tui/tui-win.c (tui_resize_all): Fix typo.
7052
7053 2019-07-17 Tom Tromey <tom@tromey.com>
7054
7055 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7056 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7057 (tui_refresh_all): Remove "list" parameter. Use foreach.
7058 * tui/tui-win.c (window_name_completer): Use foreach.
7059 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7060 (update_tab_width): Likewise.
7061 * tui/tui-layout.c (show_layout): Update.
7062 * tui/tui-data.h (class tui_window_iterator): New.
7063 (struct all_tui_windows): New.
7064 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7065
7066 2019-07-17 Tom Tromey <tom@tromey.com>
7067
7068 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7069 parameter. Don't reference globals.
7070 (tui_reg_command): Update.
7071
7072 2019-07-17 Tom Tromey <tom@tromey.com>
7073
7074 * tui/tui-regs.c (tui_show_registers): Simplify.
7075
7076 2019-07-17 Tom Tromey <tom@tromey.com>
7077
7078 * tui/tui-regs.c (tui_show_registers): Update.
7079 (tui_show_register_group): Add win_info parameter.
7080
7081 2019-07-17 Tom Tromey <tom@tromey.com>
7082
7083 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7084 Rename from tui_display_reg_element_at_line.
7085 (tui_data_window::display_registers_from_line): Update.
7086 * tui/tui-data.h (struct tui_data_window)
7087 <display_reg_element_at_line>: New method.
7088
7089 2019-07-17 Tom Tromey <tom@tromey.com>
7090
7091 * tui/tui-regs.h (tui_display_registers_from)
7092 (tui_display_registers_from_line): Don't declare.
7093 * tui/tui-windata.c (tui_data_window::display_all_data)
7094 (tui_data_window::refresh_all)
7095 (tui_data_window::do_scroll_vertical): Update.
7096 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7097 from tui_display_registers_from.
7098 (tui_display_reg_element_at_line): Update.
7099 (tui_data_window::display_registers_from_line): Rename from
7100 tui_display_registers_from_line.
7101 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7102 display_registers_from_line>: New methods.
7103
7104 2019-07-17 Tom Tromey <tom@tromey.com>
7105
7106 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7107 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7108 from tui_erase_data_content.
7109 (tui_data_window::display_all_data)
7110 (tui_data_window::refresh_all)
7111 (tui_data_window::do_scroll_vertical): Update.
7112 * tui/tui-regs.c (tui_show_registers): Update.
7113 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7114 New method.
7115
7116 2019-07-17 Tom Tromey <tom@tromey.com>
7117
7118 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7119 declare.
7120 * tui/tui-windata.c
7121 (tui_data_window::delete_data_content_windows): Rename from
7122 tui_delete_data_content_windows.
7123 (tui_data_window::display_all_data)
7124 (tui_data_window::do_scroll_vertical): Update.
7125 * tui/tui-data.h (struct tui_data_window)
7126 <delete_data_content_windows>: New method.
7127
7128 2019-07-17 Tom Tromey <tom@tromey.com>
7129
7130 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7131 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7132
7133 2019-07-17 Tom Tromey <tom@tromey.com>
7134
7135 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7136 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7137 from tui_display_all_data.
7138 * tui/tui-win.c
7139 (tui_data_window::do_make_visible_with_new_height): Update.
7140 * tui/tui-regs.c (tui_show_registers): Update.
7141 * tui/tui-layout.c (tui_set_layout): Update.
7142 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7143 method.
7144
7145 2019-07-17 Tom Tromey <tom@tromey.com>
7146
7147 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7148 * tui/tui-windata.c (tui_display_data_from): Remove.
7149 (tui_data_window::refresh_all): Update.
7150
7151 2019-07-17 Tom Tromey <tom@tromey.com>
7152
7153 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7154 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7155 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7156 tui_display_registers_from_line.
7157 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7158 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7159 "force_display" parameter.
7160
7161 2019-07-17 Tom Tromey <tom@tromey.com>
7162
7163 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7164 declare.
7165 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7166 Rename from tui_first_reg_element_no_inline.
7167 (tui_display_reg_element_at_line)
7168 (tui_display_registers_from_line): Update.
7169 * tui/tui-data.h (struct tui_data_window)
7170 <first_reg_element_no_inline>: New method.
7171
7172 2019-07-17 Tom Tromey <tom@tromey.com>
7173
7174 * tui/tui-windata.c (tui_display_data_from)
7175 (tui_data_window::do_scroll_vertical): Update.
7176 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7177 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7178 Rename from tui_line_from_reg_element_no.
7179 (tui_display_registers_from_line): Update.
7180 * tui/tui-data.h (struct tui_data_window)
7181 <line_from_reg_element_no>: New method.
7182
7183 2019-07-17 Tom Tromey <tom@tromey.com>
7184
7185 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7186 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7187 tui_last_regs_line_no.
7188 (tui_display_reg_element_at_line)
7189 (tui_display_registers_from_line): Update.
7190 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7191 method.
7192
7193 2019-07-17 Tom Tromey <tom@tromey.com>
7194
7195 PR tui/24722:
7196 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7197 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7198 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7199 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7200 (tui_update_breakpoint_info): Likewise.
7201 * tui/tui-hooks.c (tui_event_create_breakpoint)
7202 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7203 Update.
7204
7205 2019-07-17 Tom Tromey <tom@tromey.com>
7206
7207 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7208
7209 2019-07-17 Tom Tromey <tom@tromey.com>
7210
7211 * tui/tui-winsource.c (tui_update_source_window_as_is)
7212 (tui_update_source_windows_with_addr): Update.
7213 * tui/tui-source.h (tui_set_source_content)
7214 (tui_show_symtab_source): Add "win_info" parameter.
7215 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7216 parameter.
7217 (tui_show_symtab_source): Likewise.
7218
7219 2019-07-17 Tom Tromey <tom@tromey.com>
7220
7221 * tui/tui-wingeneral.c
7222 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7223
7224 2019-07-17 Tom Tromey <tom@tromey.com>
7225
7226 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7227 (struct tui_cmd_window) <can_scroll>: New method.
7228 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7229 method.
7230
7231 2019-07-17 Tom Tromey <tromey@adacore.com>
7232
7233 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7234 do_field_signed>: Rename. Change type of "value".
7235 * ui-out.c (ui_out::field_signed): Rename from field_int.
7236 Change type of "value".
7237 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7238 type of "value".
7239 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7240 do_field_int. Change type of "value".
7241 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7242 do_field_int. Change type of "value".
7243 * tracepoint.c (trace_status_mi, tfind_1)
7244 (print_one_static_tracepoint_marker): Update.
7245 * thread.c (print_thread_info_1, print_selected_thread_frame):
7246 Update.
7247 * stack.c (print_frame, print_frame_info): Update.
7248 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7249 Update.
7250 * source.c (print_source_lines_base): Update.
7251 * skip.c (info_skip_command): Update.
7252 * record-btrace.c (btrace_ui_out_decode_error)
7253 (btrace_call_history_src_line): Update.
7254 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7255 Update.
7256 * progspace.c (print_program_space): Update.
7257 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7258 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7259 do_field_int. Change type of "value".
7260 * mi/mi-out.c (mi_ui_out::do_table_begin)
7261 (mi_ui_out::do_table_header): Update.
7262 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7263 type of "value".
7264 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7265 (mi_cmd_data_list_changed_registers, output_register)
7266 (mi_cmd_data_read_memory, mi_load_progress)
7267 (mi_cmd_trace_frame_collected): Update.
7268 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7269 Update.
7270 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7271 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7272 (mi_cmd_var_list_children, varobj_update_one): Update.
7273 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7274 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7275 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7276 * inferior.c (print_inferior): Update.
7277 * gdb_bfd.c (print_one_bfd): Update.
7278 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7279 Update.
7280 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7281 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7282 do_field_int. Change type of "value".
7283 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7284 do_field_int. Change type of "value".
7285 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7286 (print_one_breakpoint_location, print_it_catch_fork)
7287 (print_one_catch_fork, print_it_catch_vfork)
7288 (print_one_catch_vfork, print_it_catch_solib)
7289 (print_it_catch_exec, print_it_ranged_breakpoint)
7290 (print_mention_watchpoint, print_mention_masked_watchpoint)
7291 (bkpt_print_it, update_static_tracepoint): Update.
7292 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7293 * break-catch-syscall.c (print_it_catch_syscall): Update.
7294 * ada-tasks.c (print_ada_task_info): Update.
7295 * ada-lang.c (print_it_exception, print_mention_exception):
7296 Update.
7297
7298 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7299
7300 PR breakpoints/24541
7301 * gdbarch.c: Regenerate.
7302 * gdbarch.h: Regenerate.
7303 * gdbarch.sh: Adjust return type and parameter types for
7304 'stap_adjust_register'.
7305 (i386_stap_adjust_register): Adjust signature and return new
7306 register name.
7307 * stap-probe.c (stap_parse_register_operand): Adjust use of
7308 'gdbarch_stap_adjust_register'.
7309
7310 2019-07-17 Tom Tromey <tromey@adacore.com>
7311
7312 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7313 declare VEC.
7314 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7315 std::vector.
7316 (struct s390_process_info): Add initializers.
7317 (s390_add_process): Use new.
7318 (s390_linux_nat_target::low_forget_process): Use delete.
7319 (s390_linux_nat_target::low_new_fork)
7320 (s390_linux_nat_target::stopped_by_watchpoint)
7321 (s390_linux_nat_target::low_prepare_to_resume)
7322 (s390_linux_nat_target::insert_watchpoint)
7323 (s390_linux_nat_target::insert_hw_breakpoint)
7324 (s390_linux_nat_target::remove_watchpoint)
7325 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7326
7327 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7328
7329 * aarch64-fbsd-nat.c: Include regcache.h.
7330 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7331 argument.
7332 (aarch64_fbsd_nat_target::fetch_registers)
7333 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7334 variable.
7335 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7336
7337 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7338
7339 * fbsd-nat.c: Include gdbarch.h.
7340
7341 2019-07-15 Tom Tromey <tromey@adacore.com>
7342
7343 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7344
7345 2019-07-15 Tom Tromey <tromey@adacore.com>
7346
7347 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7348 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7349 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7350 * cli-out.c (cli_ui_out::do_field_int): New method.
7351 * ui-out.c (ui_out::field_unsigned): New method.
7352 * symfile.c (generic_load): Use field_unsigned.
7353 (print_transfer_performance): Likewise.
7354 * record-btrace.c (ui_out_field_uint): Remove.
7355 (btrace_call_history_insn_range, btrace_call_history): Use
7356 field_unsigned.
7357 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7358 field_unsigned.
7359 * ui-out.h (class ui_out) <field_unsigned>: New method.
7360 <do_field_unsigned>: Likewise.
7361
7362 2019-07-15 Tom Tromey <tromey@adacore.com>
7363
7364 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7365 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7366 * target.c (flash_erase_command): Use field_string.
7367 * infrun.c (print_signal_received_reason): Use field_string.
7368 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7369 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7370 field_string.
7371 * ada-tasks.c (print_ada_task_info): Use field_string.
7372
7373 2019-07-15 Tom Tromey <tromey@adacore.com>
7374
7375 * target.c (flash_erase_command): Use field_core_addr.
7376 * symfile.c (generic_load): Use field_core_addr.
7377 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7378 Use field_core_addr.
7379 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7380 field_core_addr.
7381
7382 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7383
7384 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7385 value if its desired type is smaller than a CORE_ADDR and signed.
7386
7387 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7388
7389 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7390 of changes to field names, and use new is_reference field to
7391 decide if a property is a reference or not.
7392 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7393 field.
7394 (struct dwarf2_property_baton): Update header comment, rename
7395 'referenced_type' to 'property_type' and update comments.
7396 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7397 default property type, store in property baton, update to take
7398 accound of renamed field.
7399 (read_func_scope): Update call to attr_to_dynamic_prop.
7400 (read_array_type): Likewise.
7401 (dwarf2_per_cu_addr_sized_int_type): New function.
7402 (read_subrange_index_type): Move type finding code to
7403 dwarf2_per_cu_addr_sized_int_type.
7404 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7405 (dwarf2_per_cu_addr_type): New function.
7406 (set_die_type): Update calls to attr_to_dynamic_prop.
7407
7408 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7409
7410 * dwarf2read.c (read_subrange_index_type): New function.
7411 (read_subrange_type): Move code into new function and call it.
7412 * gdbtypes.c (create_range_type): Add some asserts.
7413
7414 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7415
7416 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7417 update return statements.
7418 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7419 declaration, and update comment to match.
7420 * gdbtypes.c (resolve_dynamic_array): Update call to
7421 dwarf2_evaluate_property to match new return type.
7422
7423 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7424
7425 * valarith.c (value_subscripted_rvalue): Change lowerbound
7426 parameter type from int to LONGEST.
7427 * value.h (value_subscripted_rvalue): Likewise in declaration.
7428
7429 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7430
7431 * cli/cli-utils.c (info_print_command_completer): New function.
7432 * cli/cli-utils.h: Add 'completer.h' include, and forward
7433 declaration for 'struct cmd_list_element'.
7434 (info_print_command_completer): Declare.
7435 * stack.c (_initialize_stack): Add completer for 'info locals' and
7436 'info args'.
7437 * symtab.c (_initialize_symtab): Add completer for 'info
7438 variables' and 'info functions'.
7439 * NEWS: Mention completion for additional info commands.
7440
7441 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7442
7443 * cli/cli-utils.c (extract_info_print_args): Delete.
7444 (extract_arg_maybe_quoted): Delete.
7445 (info_print_options_defs): New variable.
7446 (make_info_print_options_def_group): New function.
7447 (extract_info_print_options): Define new function.
7448 * cli/cli-utils.h (extract_info_print_args): Delete.
7449 (struct info_print_options): New structure.
7450 (extract_info_print_options): Declare new function.
7451 * stack.c (info_locals_command): Update to use new
7452 extract_info_print_options, also add a header comment.
7453 (info_args_command): Likewise.
7454 * symtab.c (info_variables_command): Likewise.
7455 (info_functions_command): Likewise.
7456
7457 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7458
7459 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7460 to extract string arguments.
7461 * common/common-utils.c (extract_string_maybe_quoted): New function.
7462 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7463
7464 2019-07-11 Tom Tromey <tromey@adacore.com>
7465
7466 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7467 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7468 * top.h (gdbinit): Don't declare.
7469 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7470 into...
7471 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7472 * top.c (gdb_init): Don't call init_cli_cmds.
7473 (gdbinit): Remove.
7474 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7475
7476 2019-07-11 Tom Tromey <tromey@adacore.com>
7477
7478 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7479 after it has been moved.
7480
7481 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7482
7483 * valops.c (value_must_coerce_to_target): Change return type to
7484 bool.
7485 * value.h (value_must_coerce_to_target): Likewise.
7486
7487 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7488
7489 * breakpoint.c (is_hardware_watchpoint): Remove
7490 forward-declaration.
7491 (is_masked_watchpoint): Change return type to bool.
7492 (is_tracepoint): Likewise.
7493 (is_breakpoint): Likewise.
7494 (is_hardware_watchpoint): Likewise.
7495 (is_watchpoint): Likewise.
7496 (is_no_memory_software_watchpoint): Likewise.
7497 (is_catchpoint): Likewise.
7498 (breakpoint_1): Make FILTER parameter's return type bool.
7499 is_masked_watchpoint): Change return type to bool.
7500 (save_breakpoints): Make FILTER parameter's return type bool.
7501 * breakpoint.h (is_breakpoint): Change return type to bool.
7502 (is_watchpoint): Likewise.
7503 (is_catchpoint): Likewise.
7504 (is_tracepoint): Likewise.
7505
7506 2019-07-10 Tom Tromey <tom@tromey.com>
7507
7508 * defs.h: Don't include gdbarch.h.
7509 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7510 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7511 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7512 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7513 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7514 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7515 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7516 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7517 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7518 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7519 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7520 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7521 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7522 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7523 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7524 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7525 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7526 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7527 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7528 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7529 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7530 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7531 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7532 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7533 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7534 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7535 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7536
7537 2019-07-10 Tom Tromey <tromey@adacore.com>
7538
7539 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7540 * breakpoint.c (init_ada_exception_breakpoint): Register as
7541 bp_catchpoint.
7542 (print_one_breakpoint_location, print_one_breakpoint): Use
7543 is_ada_exception_catchpoint.
7544 * ada-lang.c (class ada_catchpoint_location): Pass
7545 bp_loc_software_breakpoint to bp_location constructor.
7546 (is_ada_exception_catchpoint): New function.
7547
7548 2019-07-10 Tom Tromey <tromey@adacore.com>
7549
7550 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7551 VEC.
7552 (struct arm_exidx_entry): New method operator<.
7553 (struct arm_exidx_data) <section_maps>: Change type.
7554 (arm_exidx_data_free): Remove.
7555 (arm_exidx_data_key): Change type. Move lower.
7556 (arm_exidx_new_objfile): Update.
7557 (arm_compare_exidx_entries): Remove.
7558 (arm_find_exidx_entry, _initialize_arm_tdep)
7559
7560 2019-07-10 Tom Tromey <tromey@adacore.com>
7561
7562 * solib-spu.c (ocl_program_data_key): Change type.
7563 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7564 Update.
7565
7566 2019-07-10 Tom Tromey <tromey@adacore.com>
7567
7568 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7569 (struct solib_aix_inferior_data) <library_list>: Change type.
7570 (solib_aix_inferior_data_handle): Change type.
7571 (get_solib_aix_inferior_data): Update.
7572 (solib_aix_free_library_list): Remove.
7573 (library_list_start_library): Update.
7574 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7575 return type.
7576 (solib_aix_get_library_list)
7577 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7578 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7579
7580 2019-07-10 Tom Tromey <tromey@adacore.com>
7581
7582 * solib-dsbt.c (struct dsbt_info): Add initializers.
7583 (solib_dsbt_pspace_data): Change type.
7584 (dsbt_pspace_data_cleanup): Remove.
7585 (get_dsbt_info, _initialize_dsbt_solib): Update.
7586
7587 2019-07-10 Tom Tromey <tromey@adacore.com>
7588
7589 * spu-tdep.c (spu_overlay_data): Change type.
7590 (spu_get_overlay_table, spu_overlay_new_objfile)
7591 (_initialize_spu_tdep): Update.
7592
7593 2019-07-10 Tom Tromey <tromey@adacore.com>
7594
7595 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7596 destructor.
7597 (dbx_objfile_data_key): Change type and declare later.
7598 (DBX_SYMFILE_INFO): Rewrite.
7599 * dbxread.c (dbx_objfile_data_key): Change type.
7600 (dbx_symfile_init): Update.
7601 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7602 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7603 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7604
7605 2019-07-10 Tom Tromey <tromey@adacore.com>
7606
7607 * jit.c (jit_program_space_key): Change type. Move lower.
7608 (get_jit_program_space_data): Update.
7609 (jit_program_space_data_cleanup): Remove.
7610 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7611 Update.
7612 (struct jit_program_space_data): Add initializers.
7613
7614 2019-07-10 Tom Tromey <tromey@adacore.com>
7615
7616 * solib-darwin.c (struct darwin_info): Add initializers.
7617 (solib_darwin_pspace_data): Change type.
7618 (darwin_pspace_data_cleanup): Remove.
7619 (get_darwin_info, _initialize_darwin_solib): Update.
7620
7621 2019-07-10 Tom Tromey <tromey@adacore.com>
7622
7623 * remote-sim.c (struct sim_inferior_data): Add initializers,
7624 constructor, and destructor.
7625 (sim_inferior_data_key): Change type. Move lower.
7626 (check_for_duplicate_sim_descriptor): Update.
7627 (get_sim_inferior_data): Use new. Update.
7628 (~sim_inferior_data_cleanup): Rename from
7629 sim_inferior_data_cleanup. Simplify.
7630 (gdbsim_close_inferior, simulator_command)
7631 (sim_command_completer, _initialize_remote_sim): Update.
7632 (next_pid, INITIAL_PID): Move earlier.
7633
7634 2019-07-10 Tom Tromey <tromey@adacore.com>
7635
7636 * python/python-internal.h (create_thread_object): Return
7637 gdbpy_ref.
7638 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7639 * python/py-inferior.c (struct threadlist_entry): Add
7640 constructor.
7641 <thread_obj>: Now a gdbpy_ref.
7642 (thread_to_thread_object): Update.
7643 (add_thread_object): Use new.
7644 (delete_thread_object): Use delete.
7645 (infpy_threads): Update.
7646 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7647 GIL.
7648
7649 2019-07-10 Tom Tromey <tromey@adacore.com>
7650
7651 * valops.c (value_cast): Specialize error message for Ada.
7652
7653 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7654
7655 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7656
7657 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7658
7659 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7660 bpstat_should_step): Return bool, adjust comments.
7661 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7662 bpstat_should_step): Likewise.
7663
7664 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7665
7666 * features/Makefile: Use feature target descriptions for Arm.
7667 * features/arm/arm-core.c: Generate new file.
7668 * features/arm/arm-fpa.c: Likewise.
7669 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7670 * features/arm/arm-m-profile.c: Likewise.
7671 * features/arm/arm-vfpv2.c: Likewise.
7672 * features/arm/arm-vfpv3.c: Likewise.
7673 * features/arm/xscale-iwmmxt.c: Likewise.
7674 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7675
7676 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7677
7678 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7679 ptrace earlier.
7680
7681 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7682
7683 * features/aarch64-pauth.c: Regenerate.
7684
7685 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7686
7687 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7688 bool.
7689 (bpstat_what): Use false instead of 0.
7690
7691 2019-07-09 Pedro Alves <palves@redhat.com>
7692
7693 * break-catch-throw.c (is_exception_catchpoint): New.
7694 * breakpoint.c (print_one_breakpoint_location): New parameter
7695 'raw_loc'. Handle it. Use
7696 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7697 looking at the breakpoint's type.
7698 (print_one_breakpoint): If handling "maint info breakpoints", also
7699 print locations of exception catchpoints.
7700 * breakpoint.h (is_exception_catchpoint): Declare.
7701
7702 2019-07-09 Pedro Alves <palves@redhat.com>
7703
7704 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7705 "addr" field.
7706 (allocate_location_exception_catchpoint): New.
7707 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7708 (initialize_throw_catchpoint_ops): Install
7709 allocate_location_exception_catchpoint as allocate_location
7710 method.
7711 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7712 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7713 bp_loc_other.
7714 (breakpoint_address_is_meaningful): Delete.
7715 (bl_address_is_meaningful): New.
7716 (breakpoint_locations_match): Adjust comment.
7717 (bp_location_from_bp_type): New, factored out of...
7718 (bp_location::bp_location(breakpoint *)): ... this.
7719 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7720 factored out of...
7721 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7722 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7723 breakpoint_address_is_meaningful.
7724 (bp_locations_compare): Adjust comment.
7725 (update_global_location_list): Use bl_address_is_meaningful
7726 instead of breakpoint_address_is_meaningful.
7727 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7728 explicit.
7729 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7730 * python/py-breakpoint.c (bppy_get_location): No longer check
7731 whether location is null.
7732
7733 2019-07-09 Pedro Alves <palves@redhat.com>
7734
7735 PR c++/15468
7736 * breakpoint.c (print_one_breakpoint_location): Remove
7737 single-location assert.
7738
7739 2019-07-09 Tom Tromey <tom@tromey.com>
7740
7741 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7742 * configure: Rebuild.
7743 * configure.ac: Change common to gdbsupport.
7744 * gdbsupport: Rename from common.
7745 * acinclude.m4: Change common to gdbsupport.
7746 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7747 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7748 gdbsupport.
7749 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7750 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7751 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7752 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7753 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7754 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7755 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7756 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7757 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7758 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7759 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7760 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7761 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7762 coff-pe-read.c, command.h, compile/compile-c-support.c,
7763 compile/compile-c.h, compile/compile-cplus-symbols.c,
7764 compile/compile-cplus-types.c, compile/compile-cplus.h,
7765 compile/compile-loc2c.c, compile/compile.c, completer.c,
7766 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7767 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7768 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7769 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7770 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7771 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7772 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7773 features/aarch64-core.c, features/aarch64-fpu.c,
7774 features/aarch64-pauth.c, features/aarch64-sve.c,
7775 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7776 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7777 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7778 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7779 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7780 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7781 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7782 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7783 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7784 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7785 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7786 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7787 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7788 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7789 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7790 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7791 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7792 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7793 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7794 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7795 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7796 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7797 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7798 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7799 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7800 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7801 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7802 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7803 minsyms.c, mips-linux-tdep.c, namespace.h,
7804 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7805 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7806 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7807 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7808 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7809 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7810 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7811 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7812 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7813 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7814 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7815 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7816 procfs.c, producer.c, progspace.h, psymtab.h,
7817 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7818 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7819 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7820 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7821 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7822 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7823 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7824 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7825 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7826 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7827 target-memory.c, target.c, target.h, target/waitstatus.c,
7828 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7829 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7830 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7831 unittests/array-view-selftests.c,
7832 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7833 unittests/common-utils-selftests.c,
7834 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7835 unittests/format_pieces-selftests.c,
7836 unittests/function-view-selftests.c,
7837 unittests/lookup_name_info-selftests.c,
7838 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7839 unittests/mkdir-recursive-selftests.c,
7840 unittests/observable-selftests.c,
7841 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7842 unittests/parse-connection-spec-selftests.c,
7843 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7844 unittests/scoped_fd-selftests.c,
7845 unittests/scoped_mmap-selftests.c,
7846 unittests/scoped_restore-selftests.c,
7847 unittests/string_view-selftests.c, unittests/style-selftests.c,
7848 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7849 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7850 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7851 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7852 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7853 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7854
7855 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7856
7857 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7858 bool value.
7859 (decode_digits_ordinary): Set explicit_line field in sal.
7860 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7861 symtab_and_line that was set on an explicit line number in
7862 assembler code. Do always update the recorded symtab and line if
7863 we do skip the prologue.
7864
7865 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7866
7867 * breakpoint.c (set_breakpoint_location_function): Remove
7868 explicit_loc parameter.
7869 (momentary_breakpoint_from_master): Update call to
7870 set_breakpoint_location_function.
7871 (add_location_to_breakpoint): Likewise.
7872
7873 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7874
7875 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7876 required features based on default bfd type when no specific bfd
7877 is present.
7878
7879 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7880
7881 * NEWS: Mention that GDB printf and eval commands can now print
7882 C-style and Ada-style convenience var strings without
7883 calling the inferior.
7884 * printcmd.c (printf_c_string): Locally print GDB internal var
7885 instead of transiting via the inferior.
7886 (printf_wide_c_string): Likewise.
7887
7888 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7889
7890 PR breakpoints/25011
7891 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7892
7893 2019-07-04 Tom Tromey <tom@tromey.com>
7894
7895 PR tui/24724:
7896 * tui/tui-winsource.c (tui_clear_source_content): Update.
7897 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7898 (tui_update_breakpoint_info): Update.
7899 (tui_set_exec_info_content): Update.
7900 * tui/tui-source.c (tui_set_source_content_nil): Update.
7901 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7902 has_break.
7903 * tui/tui-data.h (enum tui_bp_flag): New.
7904 (tui_bp_flags): New enum flags type.
7905 (struct tui_source_element) <break_mode>: Change type. Rename
7906 from has_break.
7907 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7908 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7909 constants.
7910 * tui/tui-winsource.h: Fix comment.
7911
7912 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7913
7914 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7915 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7916 (store_fpregs_to_thread)
7917 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7918 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7919 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7920 (IWMMXT_REGS_SIZE): Add define.
7921 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7922 (fetch_vfp_regs, store_vfp_regs)
7923 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7924 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7925
7926 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7927
7928 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7929 defines.
7930 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7931 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7932 (ARM_INT_REGISTER_SIZE): ...to this.
7933 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7934 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7935 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7936 (arm_linux_collect_gregset, supply_nwfpe_register)
7937 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7938 defines.
7939 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7940 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7941 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7942 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7943 (arm_return_in_memory, arm_store_return_value)
7944 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7945 (arm_record_ld_st_multiple): Likewise.
7946 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7947 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7948
7949 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7950
7951 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7952 AARCH64_DISPLACED_MODIFIED_INSNS.
7953 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7954 (aarch64_displaced_step_copy_insn): Likewise.
7955 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7956 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7957 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7958 ARM_DISPLACED_MODIFIED_INSNS.
7959 * arm-tdep.c (arm_gdbarch_init): Likewise.
7960 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7961 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7962 (struct arm_displaced_step_closure): Use
7963 ARM_DISPLACED_MODIFIED_INSNS.
7964
7965 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7966
7967 * features/Makefile: Remove unused xml files.
7968 * features/aarch64.xml: Remove.
7969 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7970 * features/i386/amd64-avx-avx512.xml: Remove.
7971 * features/i386/amd64-avx-linux.xml: Remove.
7972 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7973 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7974 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7975 * features/i386/amd64-avx-mpx.xml: Remove.
7976 * features/i386/amd64-avx.xml: Remove.
7977 * features/i386/amd64-linux.xml: Remove.
7978 * features/i386/amd64-mpx-linux.xml: Remove.
7979 * features/i386/amd64-mpx.xml: Remove.
7980 * features/i386/amd64.xml: Remove.
7981 * features/i386/i386-avx-avx512-linux.xml: Remove.
7982 * features/i386/i386-avx-avx512.xml: Remove.
7983 * features/i386/i386-avx-linux.xml: Remove.
7984 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7985 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7986 * features/i386/i386-avx-mpx-linux.xml: Remove.
7987 * features/i386/i386-avx-mpx.xml: Remove.
7988 * features/i386/i386-avx.xml: Remove.
7989 * features/i386/i386-linux.xml: Remove.
7990 * features/i386/i386-mmx-linux.xml: Remove.
7991 * features/i386/i386-mmx.xml: Remove.
7992 * features/i386/i386-mpx-linux.xml: Remove.
7993 * features/i386/i386-mpx.xml: Remove.
7994 * features/i386/i386.xml: Remove.
7995 * features/i386/x32-avx-avx512-linux.xml: Remove.
7996 * features/i386/x32-avx-linux.xml: Remove.
7997 * features/i386/x32-linux.xml: Remove.
7998
7999 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8000
8001 * regformats/aarch64.dat: Remove.
8002 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8003 * regformats/i386/amd64-avx-linux.dat: Remove.
8004 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8005 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8006 * regformats/i386/amd64-linux.dat: Remove.
8007 * regformats/i386/amd64-mpx-linux.dat: Remove.
8008 * regformats/i386/amd64.dat: Remove.
8009 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8010 * regformats/i386/i386-avx-linux.dat: Remove.
8011 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8012 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8013 * regformats/i386/i386-linux.dat: Remove.
8014 * regformats/i386/i386-mmx-linux.dat: Remove.
8015 * regformats/i386/i386-mpx-linux.dat: Remove.
8016 * regformats/i386/i386.dat: Remove.
8017 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8018 * regformats/i386/x32-avx-linux.dat: Remove.
8019 * regformats/i386/x32-linux.dat: Remove.
8020
8021 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8022
8023 * aarch64-tdep.c: Remove xml self tests.
8024 * amd64-linux-tdep.c: Likewise.
8025 * amd64-tdep.c: Likewise.
8026 * i386-linux-tdep.c: Likewise.
8027 * i386-tdep.c: Likewise.
8028
8029 2019-07-03 Pedro Alves <palves@redhat.com>
8030
8031 PR cli/24732
8032 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8033 (pipe_cmd_option_defs): New.
8034 (make_pipe_cmd_options_def_group): New.
8035 (pipe_command): Use gdb::option::process_options.
8036 (pipe_command_completer): New function.
8037 (_initialize_cli_cmds): Install completer for "pipe" command.
8038
8039 2019-07-03 Pedro Alves <palves@redhat.com>
8040
8041 * cli/cli-option.c (union option_value) <string>: New field.
8042 (struct option_def_and_value): Add ctor, move ctor, dtor and
8043 use DISABLE_COPY_AND_ASSIGN.
8044 (option_def_and_value::clear_value): New.
8045 (parse_option, save_option_value_in_ctx, get_val_type_str)
8046 (add_setshow_cmds_for_options): Handle var_string.
8047 * cli-option.h (union option_def::var_address) <string>: New
8048 field.
8049 (struct string_option_def): New.
8050 * maint-test-options.c (struct test_options_opts): Add default
8051 ctor and use DISABLE_COPY_AND_ASSIGN.
8052 <string_opt>: New field.
8053 (test_options_opts::~test_options_opts): New.
8054 (test_options_opts::dump): Also dump "-string".
8055 (test_options_option_defs): Install "string.
8056
8057 2019-07-03 Pedro Alves <palves@redhat.com>
8058
8059 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8060 option_value with a null enumeration.
8061 (complete_options): Save the option values in the context.
8062 (save_option_value_in_ctx): New, factored out from ...
8063 (process_options): ... here.
8064 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8065 of the function.
8066 * maint-test-options.c (test_options_opts::dump): New, factored
8067 out from ...
8068 (maintenance_test_options_command_mode): ... here.
8069 (maintenance_test_options_command_completion_result): Delete.
8070 (maintenance_test_options_command_completion_text): Update
8071 comment.
8072 (maintenance_show_test_options_completion_result): Change
8073 prototype. Just print
8074 maintenance_test_options_command_completion_text.
8075 (save_completion_result): New.
8076 (maintenance_test_options_completer_mode): Pass options context to
8077 complete_options, and then save a dump.
8078 (_initialize_maint_test_options): Use add_cmd to install "maint
8079 show test-options-completion-result".
8080
8081 2019-07-03 Pedro Alves <palves@redhat.com>
8082
8083 * NEWS (New commands): Mention "with" and "maint with".
8084 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8085 (with_command, with_command_completer): New.
8086 (pipe_command): Adjust to new repeat_previous
8087 interface.
8088 (_initialize_cli_cmds): Install the "with" command and its "w"
8089 alias.
8090 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8091 declarations.
8092 * cli/cli-setshow.c (parse_cli_var_uinteger)
8093 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8094 argument strings for all var_types.
8095 (get_setshow_command_value_string): New, factored out from ...
8096 (do_show_command): ... this.
8097 * cli/cli-setshow.h: Include <string>.
8098 (get_setshow_command_value_string): Declare.
8099 * command.h (repeat_previous): Now returns const char *. Adjust
8100 comment.
8101 * maint.c: Include "cli/cli-cmds.h".
8102 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8103 (_initialize_maint_cmds): Register the "maintenance with" command.
8104 * top.c (repeat_previous): Move bits from pipe_command here:
8105 Return the saved command line, if any; error out if there's no
8106 command to relaunch.
8107
8108 2019-07-03 Pedro Alves <palves@redhat.com>
8109
8110 * NEWS (New commands): Mention "maint set/show test-settings"
8111 instead of "maint test-settings".
8112 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8113 (maintenance_test_settings_set_list): Rename to ...
8114 (maintenance_set_test_settings_list): ... this.
8115 (maintenance_test_settings_show_list): Rename to ...
8116 (maintenance_show_test_settings_list): ... this.
8117 (maintenance_test_settings_cmd): Delete.
8118 (maintenance_test_settings_set_cmd): ...
8119 (maintenance_set_test_settings_cmd): ... this.
8120 (maintenance_test_settings_show_cmd): ...
8121 (maintenance_show_test_settings_cmd): ... this.
8122 (maintenance_test_settings_show_value_cmd):
8123 (maintenance_show_test_settings_value_cmd): ... this.
8124 (_initialize_maint_test_settings): No longer install the "maint
8125 test-settings" prefix command. Rename "maint test-settings set"
8126 to "maint set test-settings", and "maint test-settings show" to
8127 "maint show test-settings". Adjust all subcommands.
8128
8129 2019-07-03 Pedro Alves <palves@redhat.com>
8130
8131 * maint-test-settings.c: Fix file's intro comment. Replace all
8132 references to "test-options" with references to "test-settings",
8133 in comments.
8134
8135 2019-07-03 Pedro Alves <palves@redhat.com>
8136
8137 * maint-test-settings.c (maintenance_test_settings_xxx)
8138 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8139 New.
8140 (maintenance_test_settings_enums): Use them.
8141 (maintenance_test_settings_enum): Default to
8142 maintenance_test_settings_xxx.
8143 (_initialize_maint_test_settings): Initialize
8144 MAINTENANCE_TEST_SETTINGS_FILENAME.
8145
8146 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8147
8148 * breakpoint.h (remove_breakpoints_inf): Change return type to
8149 void, move function documentation here.
8150 * breakpoint.c (remove_breakpoints_inf): Change return type to
8151 void, move function documentation to header.
8152
8153 2019-07-02 Pedro Alves <palves@redhat.com>
8154
8155 * NEWS (Completion improvements): Mention "info threads".
8156 * thread.c (struct info_threads_opts, info_threads_option_defs)
8157 (make_info_threads_options_def_group): New.
8158 (info_threads_command): Use gdb::option::process_options.
8159 (info_threads_command_completer): New.
8160 (_initialize_thread): Use gdb::option::build_help to build the
8161 help text for "info threads".
8162
8163 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8164
8165 * defs.h (generic_load): Move from here...
8166 * symfile.h (generic_load): ... to here. Rename name parameter
8167 to args.
8168 * symfile.c (generic_load): Add comment.
8169
8170 2019-07-01 Tom Tromey <tromey@adacore.com>
8171
8172 * dwarf2read.c
8173 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8174 declaration of without_params. Fix formatting.
8175
8176 2019-07-01 Tom Tromey <tromey@adacore.com>
8177
8178 * ada-exp.y (find_primitive_type): Update.
8179 * ada-lang.h (ada_lookup_symbol): Update.
8180 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8181 parameter.
8182 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8183
8184 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8185
8186 PR breakpoints/24541
8187 * gdbarch.c: Regenerate.
8188 * gdbarch.h: Regenerate.
8189 * gdbarch.sh: Add 'stap_adjust_register'.
8190 * i386-tdep.c: Include '<unordered_set>'.
8191 (i386_stap_adjust_register): New function.
8192 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8193 * stap-probe.c (stap_parse_register_operand): Call
8194 'gdbarch_stap_adjust_register'.
8195
8196 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8197
8198 PR python/24742
8199 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8200 * python/python.c (do_start_initialization): Use 'xmalloc'
8201 instead of 'PyMem_Malloc'.
8202
8203 2019-06-28 Tom Tromey <tromey@adacore.com>
8204
8205 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8206 for Ada.
8207
8208 2019-06-27 Tom Tromey <tromey@adacore.com>
8209
8210 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8211 objfile_key.
8212 (arm_find_mapping_symbol, arm_record_special_symbol)
8213 (_initialize_arm_tdep): Update.
8214 (arm_objfile_data_free): Remove.
8215
8216 2019-06-27 Tom Tromey <tromey@adacore.com>
8217
8218 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8219 to cp_print_static_field.
8220
8221 2019-06-26 Tom Tromey <tromey@adacore.com>
8222
8223 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8224 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8225 declare.
8226
8227 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8228
8229 * features/aarch64-core.c (create_feature_aarch64_core):
8230 Regenerate.
8231 * features/aarch64-core.xml: Add cpsr flags.
8232
8233 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8234
8235 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8236 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8237
8238 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8239
8240 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8241 field.
8242 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8243 use.
8244 (arm_record_special_symbol): Don't insert new symbol in sorted
8245 position, push it at the end.
8246
8247 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8248
8249 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8250 (arm_mapping_symbol_s): Remove.
8251 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8252 (arm_mapping_symbol_vec): New typedef.
8253 (struct arm_per_objfile): Add constructor.
8254 <section_maps>: Change type to
8255 std::unique_ptr<arm_mapping_symbol_vec[]>.
8256 (arm_compare_mapping_symbols): Remove.
8257 (arm_find_mapping_symbol): Adjust to section_maps type change.
8258 (arm_objfile_data_free): Call delete on arm_per_objfile.
8259 (arm_record_special_symbol): Adjust to section_maps type change.
8260 Allocate arm_per_objfile with new.
8261
8262 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8263
8264 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8265 with the command prefix.
8266
8267 2019-06-25 Tom Tromey <tom@tromey.com>
8268
8269 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8270 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8271
8272 2019-06-25 Tom Tromey <tom@tromey.com>
8273
8274 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8275 type.
8276 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8277 protected.
8278
8279 2019-06-25 Tom Tromey <tom@tromey.com>
8280
8281 * tui/tui-winsource.c
8282 (tui_source_window_base::set_is_exec_point_at): Add check against
8283 LOA_ADDRESS.
8284
8285 2019-06-25 Tom Tromey <tom@tromey.com>
8286
8287 * tui/tui-source.c (tui_set_source_content): Don't check before
8288 xfree.
8289 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8290
8291 2019-06-25 Tom Tromey <tom@tromey.com>
8292
8293 * tui/tui-winsource.h (tui_update_source_window_as_is)
8294 (tui_alloc_source_buffer, tui_line_is_displayed)
8295 (tui_addr_is_displayed): Change type of win_info.
8296 * tui/tui-winsource.c (tui_update_source_window_as_is)
8297 (tui_clear_source_content, tui_show_source_line)
8298 (tui_show_source_content, tui_source_window_base::refill)
8299 (tui_source_window_base::set_is_exec_point_at)
8300 (tui_source_window_base::set_is_exec_point_at)
8301 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8302 (tui_alloc_source_buffer, tui_line_is_displayed)
8303 (tui_addr_is_displayed): Change type of win_info. Update.
8304 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8305 (tui_source_window_base::do_make_visible_with_new_height):
8306 Update.
8307 * tui/tui-source.c (tui_set_source_content)
8308 (tui_set_source_content_nil)
8309 (tui_source_window::do_scroll_vertical): Update.
8310 * tui/tui-layout.c (show_layout): Update.
8311 * tui/tui-disasm.c (tui_set_disassem_content)
8312 (tui_disasm_window::do_scroll_vertical): Update.
8313 * tui/tui-data.h (tui_win_content): Remove.
8314 (struct tui_gen_win_info) <content, content_size>: Remove.
8315 (struct tui_source_element): Add initializers and destructor.
8316 (union tui_which_element, struct tui_win_element): Remove.
8317 (struct tui_source_window_base) <content>: New field.
8318 (struct tui_data_window): Remove destructor.
8319 (tui_alloc_content, tui_free_win_content)
8320 (tui_free_all_source_wins_content): Don't declare.
8321 * tui/tui-data.c (tui_initialize_static_data): Update.
8322 (init_content_element, tui_alloc_content): Remove.
8323 (~tui_gen_win_info): Update.
8324 (~tui_data_window, tui_free_all_source_wins_content)
8325 (tui_free_win_content, free_content, free_content_elements):
8326 Remove.
8327
8328 2019-06-25 Tom Tromey <tom@tromey.com>
8329
8330 * tui/tui-winsource.h (tui_clear_source_content)
8331 (tui_erase_source_content, tui_show_source_content): Change type
8332 of win_info.
8333 * tui/tui-winsource.c (tui_clear_source_content)
8334 (tui_erase_source_content, tui_show_source_content): Change type
8335 of win_info.
8336 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8337 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8338 win_info.
8339 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8340 win_info.
8341 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8342
8343 2019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-winsource.c (tui_clear_source_content)
8346 (tui_source_window_base::set_is_exec_point_at): Update.
8347 * tui/tui-source.c (tui_set_source_content_nil): Update.
8348 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8349 a bool.
8350 * tui/tui-data.c (init_content_element): Update.
8351
8352 2019-06-25 Tom Tromey <tom@tromey.com>
8353
8354 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8355 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8356 * tui/tui-layout.c (init_and_make_win): Update.
8357 * tui/tui.h (enum tui_win_type): Update.
8358 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8359 tui_win_is_auxillary.
8360 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8361 tui_win_is_auxillary.
8362
8363 2019-06-25 Tom Tromey <tom@tromey.com>
8364
8365 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8366 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8367 (tui_delete_data_content_windows, tui_display_all_data)
8368 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8369 Update.
8370 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8371 * tui/tui-regs.c (tui_last_regs_line_no)
8372 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8373 (tui_show_registers): Update.
8374 (tui_show_register_group): Return void. Update.
8375 (tui_display_registers_from, tui_display_reg_element_at_line)
8376 (tui_display_registers_from_line, tui_check_register_values):
8377 Update.
8378 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8379 member.
8380 (struct tui_data_window) <regs_content>: Now a std::vector.
8381 <regs_content_count>: Remove.
8382 (tui_add_content_elements, tui_free_data_content): Don't declare.
8383 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8384 (init_content_element): Remove DATA_WIN case. Add assert.
8385 (tui_add_content_elements): Remove.
8386 (tui_data_window): Update.
8387 (tui_free_data_content): Remove.
8388 (free_content_elements): Remove DATA_WIN case.
8389
8390 2019-06-25 Tom Tromey <tom@tromey.com>
8391
8392 * tui/tui-data.c (tui_data_item_window): Update.
8393 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8394 * tui/tui-windata.c (tui_display_all_data)
8395 (tui_display_data_from_line): Update.
8396 (tui_check_data_values): Remove.
8397 * tui/tui-regs.c (tui_show_register_group)
8398 (tui_display_reg_element_at_line): Update.
8399 * tui/tui-hooks.c (tui_register_changed)
8400 (tui_refresh_frame_and_register_information): Call
8401 tui_check_register_values.
8402 * tui/tui-data.h (struct tui_data_window) <data_content,
8403 data_content_count, data_type>: Remove.
8404 (enum tui_data_type): Remove.
8405
8406 * tui/tui-data.c (tui_data_window::clear_detail)
8407 (~tui_data_window): Update.
8408
8409 2019-06-25 Tom Tromey <tom@tromey.com>
8410
8411 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8412 declare.
8413 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8414 Rename from tui_first_data_item_displayed. Update.
8415 (tui_data_window::refresh_all)
8416 (tui_data_window::do_scroll_vertical): Update.
8417 * tui/tui-data.h (struct tui_data_window)
8418 <first_data_item_displayed>: Declare new method.
8419
8420 2019-06-25 Tom Tromey <tom@tromey.com>
8421
8422 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8423 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8424 contents...
8425 (tui_initialize_static_data): ...here.
8426
8427 2019-06-25 Tom Tromey <tom@tromey.com>
8428
8429 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8430 (tui_display_registers_from, tui_check_register_values): Update.
8431 (tui_display_register): Remove win_info parameter; update.
8432 (tui_get_register): Change type of parameters.
8433 * tui/tui-data.h (struct tui_data_element): Remove.
8434 (union tui_which_element) <data>: Remove.
8435 <data_window>: Change type.
8436 (struct tui_data_item_window): New.
8437 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8438 case. Add assert.
8439 (~tui_data_item_window): New destructor.
8440 (free_content_elements): Remove DATA_ITEM_WIN case.
8441
8442 2019-06-25 Tom Tromey <tom@tromey.com>
8443
8444 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8445 Remove.
8446
8447 2019-06-25 Tom Tromey <tom@tromey.com>
8448
8449 * tui/tui-data.h (struct tui_command_element): Remove.
8450 (union tui_which_element) <command>: Remove.
8451 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8452 assert.
8453 (free_content_elements): Remove CMD_WIN case.
8454
8455 2019-06-25 Tom Tromey <tom@tromey.com>
8456
8457 * tui/tui-layout.c (tui_set_layout): Update.
8458 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8459 * tui/tui-data.c (layout_def): Update.
8460
8461 2019-06-25 Tom Tromey <tom@tromey.com>
8462
8463 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8464 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8465 (tui_source_window_base::set_new_height): Update.
8466 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8467 Update.
8468 (tui_set_locator_fullname, tui_set_locator_info)
8469 (tui_show_frame_info): Update.
8470 * tui/tui-source.c (tui_set_source_content)
8471 (tui_source_is_displayed): Update.
8472 * tui/tui-layout.c (show_source_disasm_command, show_data)
8473 (show_source_or_disasm_and_command): Update.
8474 * tui/tui-disasm.c (tui_set_disassem_content)
8475 (tui_get_begin_asm_address): Update.
8476 * tui/tui-data.h (struct tui_locator_element): Remove.
8477 (union tui_which_element) <locator>: Remove.
8478 (struct tui_locator_window): New.
8479 (tui_locator_win_info_ptr): Change return type.
8480 * tui/tui-data.c (_locator): Change type.
8481 (tui_locator_win_info_ptr): Change return type.
8482 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8483 (tui_alloc_content): Add assert.
8484
8485 2019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-winsource.c
8488 (tui_exec_info_window::maybe_allocate_content): New method.
8489 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8490 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8491 (make_source_or_disasm_window): Add cast.
8492 * tui/tui-data.h (union tui_which_element) <simple_string>:
8493 Remove.
8494 (struct tui_source_info): New.
8495 (struct tui_source_window_base) <execution_info>: Change type.
8496 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8497 case, and add assert.
8498 (tui_alloc_content): Add assert.
8499
8500 2019-06-25 Tom Tromey <tom@tromey.com>
8501
8502 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8503 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8504 * tui/tui-data.c (tui_alloc_win_info): Remove.
8505
8506 2019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8509 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8510 can_highlight.
8511
8512 2019-06-25 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8515 make_visible_with_new_height method.
8516 (tui_win_info::make_visible_with_new_height): New method.
8517 (tui_source_window_base::do_make_visible_with_new_height)
8518 (tui_data_window::do_make_visible_with_new_height)
8519 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8520 (make_visible_with_new_height): Remove.
8521 (tui_resize_all, tui_adjust_win_heights): Use
8522 make_visible_with_new_height method.
8523 * tui/tui-data.h (struct tui_win_info)
8524 <do_make_visible_with_new_height, make_visible_with_new_height>:
8525 New methods.
8526 (struct tui_source_window_base, struct tui_data_window)
8527 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8528 methods.
8529
8530 2019-06-25 Tom Tromey <tom@tromey.com>
8531
8532 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8533 method.
8534 (update_tab_width): Call update_tab_width method.
8535 * tui/tui-data.h (struct tui_win_info)
8536 (struct tui_source_window_base) <update_tab_width>: New methods.
8537
8538 2019-06-25 Tom Tromey <tom@tromey.com>
8539
8540 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8541 parameter.
8542 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8543 parameter.
8544 (tui_gen_win_info::make_visible): Update.
8545 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8546 parameter.
8547 * tui/tui-data.h (enum tui_box): New enum.
8548 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8549
8550 2019-06-25 Tom Tromey <tom@tromey.com>
8551
8552 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8553 init_and_make_win for EXEC_INFO_WIN.
8554 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8555 longer inline.
8556 (struct tui_win_info) <~tui_win_info>: Inline.
8557 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8558 Don't declare.
8559 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8560 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8561 Remove.
8562 (tui_initialize_static_data): Update.
8563 (~tui_gen_win_info): Handle more cleanup here.
8564 (~tui_source_window_base): Delete "execution_info".
8565 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8566
8567 2019-06-25 Tom Tromey <tom@tromey.com>
8568
8569 * tui/tui-layout.c (make_command_window): Don't set
8570 can_highlight.
8571 (show_source_disasm_command): Call the reset method.
8572 (show_data): Don't set can_highlight. Call the reset method.
8573 (tui_gen_win_info::reset): Rename from init_gen_win_info
8574 (init_and_make_win): Simplify. Return tui_gen_win_info.
8575 (show_source_or_disasm_and_command): Call the reset method.
8576 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8577 (struct tui_cmd_window): Set can_highlight.
8578
8579 2019-06-25 Tom Tromey <tom@tromey.com>
8580
8581 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8582 from make_visible.
8583 (tui_make_visible, tui_make_invisible): Rewrite.
8584 (tui_win_info::make_visible): Remove.
8585 (tui_source_window_base::make_visible): Update.
8586 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8587 method. Moved from...
8588 (struct tui_win_info) <make_visible>: ...here.
8589
8590 2019-06-25 Tom Tromey <tom@tromey.com>
8591
8592 * tui/tui-winsource.c
8593 (tui_source_window_base::do_scroll_horizontal): Remove direction
8594 parameter.
8595 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8596 direction parameter.
8597 * tui/tui-win.c (tui_win_info::forward_scroll)
8598 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8599 (tui_win_info::right_scroll): Update.
8600 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8601 direction parameter.
8602 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8603 direction parameter.
8604 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8605 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8606 Remove direction parameter.
8607 (struct tui_source_window_base, struct tui_source_window)
8608 (struct tui_disasm_window, struct tui_data_window)
8609 (struct tui_cmd_window): Update.
8610
8611 2019-06-25 Tom Tromey <tom@tromey.com>
8612
8613 * tui/tui-winsource.h (tui_set_exec_info_content)
8614 (tui_show_exec_info_content, tui_erase_exec_info_content)
8615 (tui_clear_exec_info_content, tui_update_exec_info): Change
8616 argument to tui_source_window_base.
8617 * tui/tui-winsource.c (tui_set_exec_info_content)
8618 (tui_show_exec_info_content, tui_erase_exec_info_content)
8619 (tui_clear_exec_info_content, tui_update_exec_info): Change
8620 argument to tui_source_window_base.
8621
8622 2019-06-25 Tom Tromey <tom@tromey.com>
8623
8624 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8625 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8626
8627 2019-06-25 Tom Tromey <tom@tromey.com>
8628
8629 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8630 check.
8631
8632 2019-06-25 Tom Tromey <tom@tromey.com>
8633
8634 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8635 type to void.
8636 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8637 type to void.
8638 * tui/tui-source.c (tui_set_source_content): Update.
8639 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8640
8641 2019-06-25 Tom Tromey <tom@tromey.com>
8642
8643 * tui/tui-win.c (window_name_completer, tui_set_focus)
8644 (tui_all_windows_info): Use name method.
8645 * tui/tui-data.h (struct tui_gen_win_info)
8646 (struct tui_source_window, struct tui_disasm_window)
8647 (struct tui_data_window, struct tui_cmd_window) <name>: New
8648 method.
8649 (tui_win_name): Don't declare.
8650 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8651 (tui_win_name): Remove.
8652
8653 2019-06-25 Tom Tromey <tom@tromey.com>
8654
8655 * tui/tui-winsource.h (tui_update_source_window)
8656 (tui_update_source_window_as_is): Change parameter type.
8657 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8658 to be a tui_source_window_base.
8659 (tui_update_source_window_as_is): Likewise.
8660 * tui/tui-win.c (make_visible_with_new_height): Update.
8661
8662 2019-06-25 Tom Tromey <tom@tromey.com>
8663
8664 * tui/tui-winsource.c (tui_erase_source_content)
8665 (tui_show_source_content, tui_show_exec_info_content)
8666 (tui_erase_exec_info_content): Use refresh_window method.
8667 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8668 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8669 from tui_refresh_win.
8670 (tui_data_window::refresh_window): New method.
8671 (tui_win_info::refresh, tui_source_window_base::refresh)
8672 (tui_refresh_all): Use refresh_window method.
8673 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8674 method.
8675 * tui/tui-regs.c (tui_display_register): Call refresh_window
8676 method.
8677 * tui/tui-layout.c (show_source_disasm_command)
8678 (show_source_or_disasm_and_command): Call refresh_window method.
8679 * tui/tui-data.h (struct tui_gen_win_info)
8680 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8681 New method.
8682
8683 2019-06-25 Tom Tromey <tom@tromey.com>
8684
8685 * tui/tui.c (tui_rl_other_window, tui_enable)
8686 (tui_is_window_visible, tui_get_command_dimension): Update.
8687 * tui/tui-winsource.c (tui_update_source_window_as_is)
8688 (tui_clear_source_content, tui_erase_source_content)
8689 (tui_show_source_line, tui_source_window_base::refill)
8690 (tui_source_window_base::do_scroll_horizontal)
8691 (tui_source_window_base::set_is_exec_point_at)
8692 (tui_update_breakpoint_info, tui_set_exec_info_content)
8693 (tui_alloc_source_buffer, tui_line_is_displayed)
8694 (tui_addr_is_displayed): Update.
8695 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8696 (tui_check_and_display_highlight_if_needed)
8697 (tui_win_info::make_visible, tui_win_info::refresh)
8698 (tui_refresh_all): Update.
8699 * tui/tui-windata.c (tui_first_data_item_displayed)
8700 (tui_delete_data_content_windows, tui_erase_data_content)
8701 (tui_display_all_data, tui_data_window::refresh_all)
8702 (tui_check_data_values): Update.
8703 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8704 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8705 (tui_win_info::backward_scroll, tui_refresh_all_win)
8706 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8707 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8708 (tui_source_window_base::set_new_height)
8709 (tui_data_window::set_new_height)
8710 (make_invisible_and_set_new_height)
8711 (make_visible_with_new_height, new_height_ok)
8712 (parse_scrolling_args): Update.
8713 * tui/tui-stack.c (tui_show_frame_info): Update.
8714 * tui/tui-source.c (tui_set_source_content)
8715 (tui_set_source_content_nil, tui_source_is_displayed)
8716 (tui_source_window::do_scroll_vertical): Update.
8717 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8718 (tui_display_registers_from, tui_display_reg_element_at_line)
8719 (tui_check_register_values, tui_reg_command): Update.
8720 * tui/tui-layout.c (tui_default_win_height)
8721 (show_source_disasm_command, show_data, init_and_make_win)
8722 (show_source_or_disasm_and_command): Update.
8723 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8724 (tui_redisplay_readline, tui_mld_flush)
8725 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8726 (tui_getc): Update.
8727 * tui/tui-disasm.c (tui_set_disassem_content)
8728 (tui_disasm_window::do_scroll_vertical): Update.
8729 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8730 Now virtual.
8731 (struct tui_win_info): Derive from tui_gen_win_info.
8732 <~tui_win_info>: Mark as override.
8733 <generic>: Remove member.
8734 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8735 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8736 (~tui_data_window, ~tui_win_info)
8737 (tui_free_all_source_wins_content): Update.
8738 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8739
8740 2019-06-25 Tom Tromey <tom@tromey.com>
8741
8742 * tui/tui-layout.c (init_and_make_win): Use new.
8743 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8744 destructor, initializers.
8745 (tui_alloc_generic_win_info): Don't declare.
8746 * tui/tui-data.c (_locator): Add argument to constructor.
8747 (source_win, disasm_win): New globals.
8748 (exec_info): Remove.
8749 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8750 Update.
8751 (tui_alloc_generic_win_info): Remove.
8752 (init_content_element): Use new.
8753 (tui_win_info::tui_win_info): Update.
8754 (free_content_elements) <case DATA_WIN>: Use delete.
8755
8756 2019-06-25 Tom Tromey <tom@tromey.com>
8757
8758 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8759 * tui/tui-windata.c (tui_first_data_item_displayed)
8760 (tui_delete_data_content_windows): Update.
8761 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8762 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8763 (tui_display_registers_from, tui_check_register_values): Update.
8764 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8765 pointer.
8766 * tui/tui-data.c (init_content_element): Update. Allocate the new
8767 window.
8768 (tui_free_data_content): Update.
8769 (free_content_elements) <case DATA_WIN>: Free the window.
8770
8771 2019-06-25 Tom Tromey <tom@tromey.com>
8772
8773 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8774 Update.
8775 * tui/tui-layout.c (make_command_window)
8776 (show_source_disasm_command, show_data, init_and_make_win)
8777 (show_source_or_disasm_and_command): Update.
8778 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8779 method.
8780 <can_highight, is_highlighted>: Now bool.
8781 (tui_set_win_highlight): Don't declare.
8782 * tui/tui-data.c (tui_set_win_highlight): Remove.
8783
8784 2019-06-25 Tom Tromey <tom@tromey.com>
8785
8786 * tui/tui-wingeneral.c (make_visible): Remove check of window
8787 type.
8788
8789 2019-06-25 Tom Tromey <tom@tromey.com>
8790
8791 * tui/tui-win.c (tui_win_info::max_height)
8792 (tui_cmd_window::max_height): New methods.
8793 (new_height_ok): Call max_height.
8794 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8795 <max_height>: New method.
8796
8797 2019-06-25 Tom Tromey <tom@tromey.com>
8798
8799 * tui/tui-win.c (tui_source_window_base::set_new_height)
8800 (tui_data_window::set_new_height): New methods.
8801 (make_invisible_and_set_new_height): Call set_new_height method.
8802 * tui/tui-data.h (struct tui_win_info)
8803 (struct tui_source_window_base, struct tui_data_window)
8804 <set_new_height>: New method.
8805
8806 2019-06-25 Tom Tromey <tom@tromey.com>
8807
8808 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8809 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8810 tui_refresh_data_win.
8811 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8812 method.
8813 (tui_refresh_all_win): Call the refresh_all method.
8814 (tui_set_focus): Likewise.
8815 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8816 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8817 Likewise.
8818
8819 2019-06-25 Tom Tromey <tom@tromey.com>
8820
8821 * tui/tui-winsource.h (tui_refill_source_window)
8822 (tui_set_is_exec_point_at): Don't declare.
8823 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8824 (tui_source_window_base::refill): Rename from
8825 tui_refill_source_window.
8826 (tui_source_window_base::do_scroll_horizontal): Update.
8827 (tui_source_window_base::set_is_exec_point_at): Rename from
8828 tui_set_is_exec_point_at.
8829 (tui_update_all_breakpoint_info): Update.
8830 * tui/tui-stack.c (tui_show_frame_info): Update.
8831 * tui/tui-layout.c (show_data): Add cast.
8832 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8833 * tui/tui-data.h (struct tui_source_window_base) <refill,
8834 set_is_exec_point_at>: New methods.
8835 (tui_source_windows, tui_add_to_source_windows): Update types.
8836 (tui_add_to_source_windows): Remove redundant declaration.
8837 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8838 (tui_source_windows): Change return type.
8839 (tui_clear_source_windows_detail): Update.
8840 (tui_add_to_source_windows): Change type of parameter.
8841 (tui_free_all_source_wins_content): Update.
8842
8843 2019-06-25 Tom Tromey <tom@tromey.com>
8844
8845 * tui/tui-wingeneral.c (tui_win_info::refresh)
8846 (tui_source_window_base::refresh): New methods.
8847 (tui_refresh_all): Call the refresh method.
8848 * tui/tui-data.h (struct tui_win_info)
8849 (struct tui_source_window_base) <refresh>: New method.
8850
8851 2019-06-25 Tom Tromey <tom@tromey.com>
8852
8853 * tui/tui.h (tui_is_window_visible): Return bool.
8854 * tui/tui.c (tui_is_window_visible): Return bool.
8855 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8856 (tui_make_visible, tui_make_invisible)
8857 (tui_win_info::make_visible)
8858 (tui_source_window_base::make_visible, make_all_visible)
8859 (tui_make_all_visible, tui_make_all_invisible): Update.
8860 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8861 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8862 bool.
8863 (struct tui_win_info, struct tui_source_window_base)
8864 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8865 * tui/tui-data.c (tui_init_generic_part): Update.
8866
8867 2019-06-25 Tom Tromey <tom@tromey.com>
8868
8869 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8870 (tui_source_window_base::make_visible): New methods.
8871 (make_all_visible): Make method call.
8872 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8873 (struct tui_source_window_base, struct tui_cmd_window): Override
8874 make_visible.
8875 (tui_win_is_source_type): Don't declare.
8876 * tui/tui-data.c (tui_win_is_source_type): Remove.
8877
8878 2019-06-25 Tom Tromey <tom@tromey.com>
8879
8880 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8881 NULL check.
8882
8883 2019-06-25 Tom Tromey <tom@tromey.com>
8884
8885 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8886 Inline constructor. Add initializers for members.
8887 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8888 constructors; now inline in class.
8889
8890 2019-06-25 Tom Tromey <tom@tromey.com>
8891
8892 * tui/tui-regs.c (tui_show_registers): Update.
8893 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8894 bool.
8895 * tui/tui-data.c (tui_data_window::clear_detail)
8896 (tui_data_window): Update.
8897
8898 2019-06-25 Tom Tromey <tom@tromey.com>
8899
8900 * tui/tui-windata.c (tui_display_all_data)
8901 (tui_display_data_from_line, tui_display_data_from)
8902 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8903 Update.
8904 * tui/tui-regs.c (tui_last_regs_line_no)
8905 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8906 (tui_show_registers, tui_show_register_group)
8907 (tui_display_registers_from, tui_display_reg_element_at_line)
8908 (tui_display_registers_from_line, tui_check_register_values)
8909 (tui_reg_next, tui_reg_prev): Update.
8910 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8911 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8912 tui_data_window.
8913 (struct tui_win_info) <detail>: Remove. Add new fields from
8914 tui_data_info.
8915 (TUI_DATA_WIN): Add cast.
8916 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8917 (~tui_data_window): Simplify.
8918
8919 2019-06-25 Tom Tromey <tom@tromey.com>
8920
8921 * tui/tui-layout.c (show_source_disasm_command)
8922 (show_source_or_disasm_and_command): Update.
8923 * tui/tui-io.c (update_cmdwin_start_line)
8924 (tui_redisplay_readline): Update.
8925 * tui/tui-data.h (struct tui_command_info): Remove.
8926 (struct tui_win_info) <detail>: Remove command_info member.
8927 (struct tui_data_window) <start_line>: New member, from
8928 tui_command_info.
8929 (TUI_CMD_WIN): Add casts.
8930
8931 2019-06-25 Tom Tromey <tom@tromey.com>
8932
8933 * tui/tui-winsource.c (tui_update_source_window)
8934 (tui_refill_source_window)
8935 (tui_source_window_base::do_scroll_horizontal)
8936 (tui_update_breakpoint_info, tui_set_exec_info_content)
8937 (tui_show_exec_info_content, tui_erase_exec_info_content)
8938 (tui_clear_exec_info_content): Update.
8939 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8940 Update.
8941 * tui/tui-win.c (make_invisible_and_set_new_height)
8942 (make_visible_with_new_height): Update.
8943 * tui/tui-source.c (tui_set_source_content)
8944 (tui_show_symtab_source): Update.
8945 * tui/tui-layout.c (extract_display_start_addr)
8946 (show_source_disasm_command, show_data)
8947 (make_source_or_disasm_window)
8948 (show_source_or_disasm_and_command): Update.
8949 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8950 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8951 "gdbarch".
8952 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8953 to tui_source_window_base.
8954 (struct tui_win_info) <detail>: Remove source_info member.
8955 (struct tui_source_window_base) <has_locator>: Inline.
8956 Move contents from tui_source_info; rename has_locator member to
8957 m_has_locator.
8958 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8959 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8960 header file.
8961 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8962 Simplify.
8963 (tui_free_all_source_wins_content): Cast to
8964 tui_source_window_base.
8965
8966 2019-06-25 Tom Tromey <tom@tromey.com>
8967
8968 * tui/tui-win.c (make_invisible_and_set_new_height)
8969 (make_visible_with_new_height): Call has_locator method.
8970 * tui/tui-layout.c (show_source_disasm_command, show_data)
8971 (show_source_or_disasm_and_command): Update for bool change.
8972 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8973 (tui_win_info) <has_locator>: New method.
8974 (struct tui_source_window_base) <has_locator>: New method.
8975 (tui_win_has_locator): Don't declare.
8976 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8977 from tui_win_has_locator.
8978 (tui_source_window_base): Use false, not FALSE.
8979
8980 2019-06-25 Tom Tromey <tom@tromey.com>
8981
8982 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8983 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8984 clear_detail method directly.
8985 (tui_clear_win_detail): Remove.
8986
8987 2019-06-25 Tom Tromey <tom@tromey.com>
8988
8989 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8990 "this", not TUI_DISASM_WIN.
8991
8992 2019-06-25 Tom Tromey <tom@tromey.com>
8993
8994 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8995 declare.
8996 * tui/tui-winsource.c
8997 (tui_source_window_base::do_scroll_horizontal): Rename from
8998 tui_horizontal_source_scroll.
8999 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9000 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9001 from tui_vertical_data_scroll.
9002 * tui/tui-win.h (tui_scroll): Don't declare.
9003 * tui/tui-win.c (tui_win_info::forward_scroll)
9004 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9005 (tui_win_info::right_scroll): Rename and update.
9006 (tui_scroll_forward_command, tui_scroll_backward_command)
9007 (tui_scroll_left_command, tui_scroll_right_command): Update.
9008 (tui_scroll): Remove.
9009 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9010 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9011 from tui_vertical_source_scroll.
9012 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9013 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9014 from tui_vertical_disassem_scroll.
9015 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9016 do_scroll_horizontal>: New methods.
9017 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9018 Likewise.
9019 (struct tui_source_window_base): Add do_scroll_horizontal.
9020 (struct tui_source_window, struct tui_disasm_window): Add
9021 do_scroll_vertical.
9022 (struct tui_data_window, struct tui_cmd_window): Add
9023 do_scroll_horizontal and do_scroll_vertical.
9024 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9025
9026 2019-06-25 Tom Tromey <tom@tromey.com>
9027
9028 * tui/tui-data.h (struct tui_source_window_base): New struct.
9029 (struct tui_source_window): Derive from tui_source_window_base.
9030 (struct tui_disasm_window): New struct.
9031 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9032 from tui_source_window::clear_detail.
9033 (tui_source_window_base): Rename from tui_source_window.
9034 (~tui_source_window_base): Rename from ~tui_source_window.
9035 (tui_alloc_win_info): Create a tui_disasm_window.
9036
9037 2019-06-25 Tom Tromey <tom@tromey.com>
9038
9039 * tui/tui-data.h (struct tui_source_window)
9040 (struct tui_data_window): Declare destructors.
9041 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9042 destructors.
9043 (tui_win_info): Simplify.
9044
9045 2019-06-25 Tom Tromey <tom@tromey.com>
9046
9047 * tui/tui-winsource.c (tui_display_main)
9048 (tui_update_source_windows_with_addr)
9049 (tui_update_all_breakpoint_info): Update.
9050 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9051 (new_height_ok, parse_scrolling_args): Update.
9052 * tui/tui-stack.c (tui_show_frame_info): Update.
9053 * tui/tui-data.h (struct tui_list): Remove.
9054 (tui_source_windows): Return a reference to a std::vector.
9055 * tui/tui-data.c (source_windows): Now a std::vector.
9056 (tui_source_windows): Change return type.
9057 (tui_clear_source_windows): Rewrite.
9058 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9059 (tui_free_all_source_wins_content): Rewrite.
9060
9061 2019-06-25 Tom Tromey <tom@tromey.com>
9062
9063 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9064 (struct tui_data_window, struct tui_cmd_window): Declare
9065 clear_detail method.
9066 * tui/tui-data.c (tui_source_window::clear_detail)
9067 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9068 methods.
9069 (tui_clear_win_detail): Simplify.
9070
9071 2019-06-25 Tom Tromey <tom@tromey.com>
9072
9073 * tui/tui-layout.c (make_source_window, make_disasm_window)
9074 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9075 Return the new window.
9076 (show_source_disasm_command, show_data)
9077 (show_source_or_disasm_and_command): Update.
9078
9079 2019-06-25 Tom Tromey <tom@tromey.com>
9080
9081 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9082 parameter. Return the new window.
9083 (show_source_disasm_command): Update and remove NULL check.
9084 (show_source_or_disasm_and_command): Update.
9085
9086 2019-06-25 Tom Tromey <tom@tromey.com>
9087
9088 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9089
9090 2019-06-25 Tom Tromey <tom@tromey.com>
9091
9092 * tui/tui-data.h (struct tui_win_info): Make constructor
9093 protected. Make destructor virtual. Add initializers.
9094 (tui_source_window, tui_data_window, tui_cmd_window): New
9095 classes.
9096 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9097 constructor. Add "type" parameter.
9098 (tui_source_window, tui_data_window, tui_cmd_window): New
9099 constructors.
9100 (tui_alloc_win_info): Instantiate the appropriate subclass.
9101
9102 2019-06-25 Tom Tromey <tom@tromey.com>
9103
9104 * tui/tui-win.c (tui_resize_all): Use delete.
9105 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9106 destructor.
9107 (tui_free_window): Don't declare.
9108 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9109 Update.
9110
9111 2019-06-25 Tom Tromey <tom@tromey.com>
9112
9113 * tui/tui-data.h (struct tui_win_info): Add constructor.
9114 * tui/tui-data.c (tui_alloc_win_info): Use new.
9115 (tui_free_window): Use delete.
9116
9117 2019-06-22 Tom Tromey <tom@tromey.com>
9118
9119 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9120 declare.
9121 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9122
9123 2019-06-22 Tom Tromey <tom@tromey.com>
9124
9125 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9126 declare.
9127 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9128
9129 2019-06-22 Tom de Vries <tdevries@suse.de>
9130
9131 * dwarf2read.c (create_addrmap_from_aranges)
9132 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9133 instead of '%zu'.
9134
9135 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
9136
9137 * dwarf2read.h (dwarf2_section_info_def): Remove.
9138 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9139 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9140 std::vector<dwarf2_section_info>.
9141 (struct dwo_file) <~dwo_file>: Remove.
9142 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9143 types field.
9144 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9145 (dwarf2_read_debug_names): Likewise.
9146 (create_debug_types_hash_table): Change parameter type to
9147 array_view, adjust code accordingly.
9148 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9149 (partial_die_info::fixup): Likewise.
9150 (determine_prefix): Likewise.
9151 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9152
9153 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9154
9155 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9156 gdb_bfd_ref_ptr.
9157 <~dwo_file>: Remove call to gdb_bfd_unref.
9158 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9159 gdb_bfd_ref_ptr::get.
9160
9161 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9162
9163 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9164 type to htab_up.
9165 * dwarf2read.c (struct dwo_file): Initialize fields.
9166 <~dwo_file>: New.
9167 (free_dwo_file): Remove, move content to ~dwo_file.
9168 (struct dwo_file_deleter): Remove.
9169 (dwo_file_up>: Remove custom deleter.
9170 (free_dwo_files): Remove.
9171 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9172 dwo_files.
9173 (process_skeletonless_type_units): Call unique_ptr::get.
9174 (allocate_dwo_file_hash_table): Add deleter to created hash
9175 table. Change return type to htab_up.
9176 (lookup_dwo_file_slot): Don't memset dwo_file, call
9177 unique_ptr::get.
9178 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9179 (create_dwo_unit_in_dwp_v2): Likewise.
9180 (open_and_init_dwo_file): Likewise.
9181 (free_dwo_file_from_slot): Remove.
9182
9183 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9184
9185 * dwarf2read.h (struct dwarf2_section_info) <readin,
9186 is_virtual>: Change type to bool.
9187 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9188 true instead of 1.
9189
9190 2019-06-19 Tom Tromey <tom@tromey.com>
9191
9192 * tui/tui-data.h (tui_init_content_element): Don't declare.
9193
9194 2019-06-19 Tom Tromey <tom@tromey.com>
9195
9196 * tui/tui-data.h (tui_init_win_info): Don't declare.
9197
9198 2019-06-19 Tom de Vries <tdevries@suse.de>
9199
9200 * dwarf2read.h (abstract_to_concrete): Change type to
9201 std::unordered_map<sect_offset, std::vector<sect_offset>,
9202 gdb::hash_enum<sect_offset>>.
9203
9204 2019-06-19 Tom Tromey <tromey@adacore.com>
9205
9206 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9207 EVAL_AVOID_SIDE_EFFECTS specially.
9208
9209 2019-06-19 Tom Tromey <tromey@adacore.com>
9210
9211 * source-cache.c (highlighter): New global.
9212 (source_cache::get_source_lines): Create a highlighter on demand.
9213
9214 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9215
9216 * defs.h (deprecated_interactive_hook): Delete declaration.
9217 * interps.c (clear_interpreter_hooks): Remove use of
9218 deprecated_interactive_hook.
9219 * top.c (deprecated_interactive_hook): Delete definition.
9220 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9221
9222 2019-06-18 Tom de Vries <tdevries@suse.de>
9223
9224 PR gdb/24515
9225 * dwarf2read.h (abstract_to_concrete): Change type from
9226 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9227 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9228 * dwarf2read.c (read_variable): Update.
9229 (dwarf2_fetch_die_loc_sect_off): Update.
9230
9231 2019-06-17 Tom de Vries <tdevries@suse.de>
9232
9233 PR gdb/24617
9234 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9235 accessing parent[parent_len - 1].
9236
9237 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9238
9239 PR gdb/24364
9240 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9241 call dtrace_process_dof with NULL dof.
9242
9243 2019-06-16 Tom de Vries <tdevries@suse.de>
9244
9245 PR gdb/24445
9246 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9247
9248 2019-06-16 Tom Tromey <tom@tromey.com>
9249
9250 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9251 (make_all_visible): Use address of member.
9252
9253 2019-06-16 Tom Tromey <tom@tromey.com>
9254
9255 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9256 (tui_free_window, free_content, free_content_elements): Remove
9257 unnecessary cast.
9258 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9259 cast.
9260 * tui/tui-regs.c (tui_show_register_group)
9261 (tui_display_registers_from, tui_display_reg_element_at_line):
9262 Remove unnecessary cast.
9263
9264 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9265
9266 * linux-nat.c (normal_mask): Delete.
9267 (_initialize_linux_nat): Don't initialise normal_mask.
9268
9269 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9270
9271 PR gdb/24445
9272 * dwarf-index-write.h (write_psymtabs_to_index): Add
9273 dwz_basename parameter.
9274 * dwarf-index-write.c (write_gdbindex): Move file writing to
9275 write_gdbindex_1. Change return type void.
9276 (assert_file_size): Move up, remove filename parameter.
9277 (write_gdbindex_1): New function.
9278 (write_debug_names): Change return type to void, call
9279 assert_file_size.
9280 (struct index_wip_file): New struct.
9281 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9282 file logic to index_wip_file. Write index for dwz file if
9283 needed.
9284 (save_gdb_index_command): Pass basename of dwz file, if present.
9285 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9286 build-id of dwz file, if present.
9287 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9288 (dwarf2_get_dwz_file): Likewise.
9289 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9290 (dwarf2_get_dwz_file): Likewise.
9291
9292 2019-06-16 Tom Tromey <tom@tromey.com>
9293
9294 * coffread.c (process_coff_symbol): Use xstrdup.
9295 * value.c (create_internalvar): Use xstrdup.
9296
9297 2019-06-16 Tom Tromey <tom@tromey.com>
9298
9299 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9300 * breakpoint.c (stopin_command, stopat_command)
9301 (until_break_command, decode_location_default): Remove unnecessary
9302 cast.
9303 * utils.c (subset_compare): Remove unnecessary cast.
9304 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9305 cast.
9306 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9307 cast.
9308 * infcmd.c (path_command): Remove unnecessary cast.
9309 * coffread.c (decode_type): Remove unnecessary cast.
9310 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9311 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9312 * tui/tui-stack.c (tui_show_locator_content)
9313 (tui_show_frame_info): Remove unnecessary cast.
9314 * tui/tui-win.c (tui_scroll_forward_command)
9315 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9316 (parse_scrolling_args): Remove unnecessary cast.
9317 * tui/tui-data.c (init_win_info, tui_del_window)
9318 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9319 (free_content_elements): Remove unnecessary cast.
9320 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9321 unnecessary cast.
9322 * tui/tui-source.c (tui_set_source_content)
9323 (tui_vertical_source_scroll): Remove unnecessary cast.
9324 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9325 cast.
9326 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9327 * tui/tui-regs.c (tui_display_registers_from)
9328 (tui_display_register): Remove unnecessary cast.
9329 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9330 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9331 (make_visible): Remove unnecessary cast.
9332 * tui/tui-winsource.c (tui_erase_source_content)
9333 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9334 unnecessary cast.
9335 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9336 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9337 * stabsread.c (read_type, read_array_type, read_range_type):
9338 Remove unnecessary cast.
9339 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9340 (parse_symbol, parse_type, upgrade_type, parse_external)
9341 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9342 unnecessary cast.
9343 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9344
9345 2019-06-16 Tom Tromey <tom@tromey.com>
9346
9347 * tui/tui-data.c (tui_alloc_generic_win_info)
9348 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9349 checks.
9350
9351 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9352 Andrew Burgess <andrew.burgess@embecosm.com>
9353
9354 * f-typeprint.c (f_print_type): Don't return early for not
9355 associated or not allocated types.
9356 (f_type_print_varspec_suffix): Add print_rank parameter and print
9357 ranks of array types in case they dangling.
9358 (f_type_print_base): Add print_rank parameter.
9359
9360 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9361
9362 * NEWS: Mention new MI commands.
9363 * break-catch-throw.c (enum exception_event_kind): Move to
9364 breakpoint.h.
9365 (print_mention_exception_catchpoint): Output text as a single
9366 message.
9367 (catch_exception_command_1): Rename to...
9368 (catch_exception_event): ...this, make non-static, update header
9369 command, and change some parameter types.
9370 (catch_catch_command): Update for changes to
9371 catch_exception_command_1.
9372 (catch_throw_command): Likewise.
9373 (catch_rethrow_command): Likewise.
9374 * breakpoint.c (enum exception_event_kind): Delete.
9375 * breakpoint.h (enum exception_event_kind): Moved here from
9376 break-catch-throw.c.
9377 (catch_exception_event): Declare.
9378 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9379 (mi_cmd_catch_throw): New function.
9380 (mi_cmd_catch_rethrow): New function.
9381 (mi_cmd_catch_catch): New function.
9382 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9383 'catch-catch' entries.
9384 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9385 (mi_cmd_catch_rethrow): Declare.
9386 (mi_cmd_catch_catch): Declare.
9387
9388 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9389
9390 * annotate.c (annotate_source_line): Change return type to void,
9391 update implementation to match.
9392 * annotate.h (annotate_source_line): Change return type to void,
9393 update header comment.
9394 * stack.c (print_frame_info): Don't change what frame information
9395 is printed based on whether annotations are on or not.
9396
9397 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9398
9399 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9400 (annotate_source): Make static.
9401 (annotate_source_line): Moved from source.c and renamed from
9402 identify_source_line. Update the return type.
9403 * annotate.h (annotate_source): Delete declaration.
9404 (annotate_source_line): Declaration moved from source.h, and
9405 renamed from identify_source_line. Return type updated.
9406 * source.c (identify_source_line): Moved to annotate.c and renamed
9407 to annotate_source_line.
9408 (info_line_command): Remove check of annotation_level.
9409 * source.h (identify_source_line): Move declaration to annotate.h
9410 and rename to annotate_source_line.
9411 * stack.c: Add 'annotate.h' include.
9412 (print_frame_info): Remove check of annotation_level before
9413 calling annotate_source_line.
9414
9415 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9416
9417 * source-cache.c (source_cache::get_plain_source_lines): Use
9418 open_source_file_with_line_charpos instead of just
9419 open_source_file, remove call to find_source_lines.
9420 (source_cache::get_source_lines): Likewise.
9421 * source.c (find_source_lines): Make static.
9422 (get_filename_and_charpos): Renamed into...
9423 (open_source_file_with_line_charpos): ..this along with changes to
9424 return a scoped_fd, and some other minor clean ups.
9425 (identify_source_line): Use open_source_file_with_line_charpos.
9426 (search_command_helper): Use open_source_file_with_line_charpos
9427 instead of just open_source_file, remove call to
9428 find_source_lines.
9429 * source.h (open_source_file_with_line_charpos): Declare new
9430 function.
9431 (find_source_lines): Delete declaration.
9432
9433 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9434
9435 * source.c (get_filename_and_charpos): Remove fullname
9436 parameter.
9437 (identify_source_line): Update call to get_filename_and_charpos.
9438
9439 2019-06-14 Tom Tromey <tromey@adacore.com>
9440
9441 PR gdb/24502:
9442 * ui-style.h (skip_ansi_escape): Update comment.
9443 * ui-file.h (class no_terminal_escape_file): New class.
9444 * ui-file.c (no_terminal_escape_file::write)
9445 (no_terminal_escape_file::puts): New methods.
9446 * cli/cli-logging.c (handle_redirections): Use
9447 no_terminal_escape_file.
9448
9449 2019-06-14 Tom Tromey <tromey@adacore.com>
9450
9451 * NEWS: Move convenience variable news above Python news.
9452
9453 2019-06-14 Tom Tromey <tom@tromey.com>
9454
9455 * gnulib: Move directory to top-level.
9456 * configure.ac: Don't configure gnulib.
9457 * configure: Rebuild.
9458 * common/common-defs.h: Use new path to gnulib.
9459 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9460 (GNULIB_H): Remove.
9461 (INCGNU): Look in new gnulib location.
9462 (HFILES_NO_SRCDIR): Remove gnulib files.
9463 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9464 (generated_files): Remove GNULIB_H.
9465 ($(LIBGNU), all-lib): Remove targets.
9466 (distclean): Don't mention GNULIB_BUILDDIR.
9467 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9468
9469 2019-06-14 Tom Tromey <tromey@adacore.com>
9470
9471 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9472 Warn if symbol file does not provide any symbols.
9473
9474 2019-06-14 Tom Tromey <tromey@adacore.com>
9475
9476 * source.c (find_and_open_source): Respect basenames_may_differ.
9477
9478 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9479
9480 * annotate.c (annotate_breakpoints_invalid): Make use of
9481 scoped_restore_terminal_state.
9482 (annotate_frames_invalid): Likewise.
9483
9484 2019-06-14 Tom Tromey <tromey@adacore.com>
9485
9486 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9487 allow assignment to an internalvar.
9488
9489 2019-06-14 Tom Tromey <tromey@adacore.com>
9490
9491 * ada-lex.l: Allow "_" in attribute names.
9492
9493 2019-06-14 Tom Tromey <tromey@adacore.com>
9494
9495 PR gdb/24653:
9496 * regcache.c (registers_changed): Don't call alloca.
9497 * top.c (execute_command): Don't call alloca.
9498
9499 2019-06-13 Pedro Alves <palves@redhat.com>
9500
9501 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9502 'expression'. When parsing an expression, error out if there's
9503 junk after "unlimited".
9504 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9505 (do_set_command): Adjust calls to is_unlimited_literal.
9506
9507 2019-06-13 Pedro Alves <palves@redhat.com>
9508
9509 * compile/compile.c (make_compile_options_def_group): Add braces
9510 around array_view initializer.
9511 * thread.c (make_thread_apply_all_options_def_group)
9512 (make_thread_apply_all_options_def_group): Likewise.
9513
9514 2019-06-13 Pedro Alves <palves@redhat.com>
9515
9516 * NEWS (New commands): Mention "maint test-options
9517 require-delimiter", "maint test-options unknown-is-error", "maint
9518 test-options unknown-is-operand" and "maint show
9519 test-options-completion-result".
9520 (New command options, command completion): New section.
9521 (Completion improvements): New section.
9522 Mention that you can abbreviate "unlimited".
9523
9524 2019-06-13 Pedro Alves <palves@redhat.com>
9525
9526 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9527 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9528 * unittests/cli-utils-selftests.c (test_parse_flags)
9529 (test_parse_flags_qcs): Delete.
9530 (test_cli_utils): Don't call deleted functions.
9531
9532 2019-06-13 Pedro Alves <palves@redhat.com>
9533
9534 * thread.c: Include "cli/cli-option.h".
9535 (tp_array_compar_ascending): Global.
9536 (tp_array_compar): Delete function.
9537 (tp_array_compar_ascending, tp_array_compar_descending): New
9538 functions.
9539 (ascending_option_def, qcs_flag_option_def)
9540 (thr_qcs_flags_option_defs)
9541 (make_thread_apply_all_options_def_group)
9542 (make_thread_apply_options_def_group): New.
9543 (thread_apply_all_command): Use gdb::option::process_options.
9544 (thread_apply_command_completer)
9545 (thread_apply_all_command_completer): New.
9546 (thread_apply_command): Use gdb::option::process_options.
9547 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9548 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9549 to generate help text of "thread apply". Adjust "taas"'s help.
9550 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9551 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9552
9553 2019-06-13 Pedro Alves <palves@redhat.com>
9554
9555 * thread.c (thread_apply_command): Check for invalid TID with
9556 isdigit instead of !isalpha.
9557
9558 2019-06-13 Pedro Alves <palves@redhat.com>
9559
9560 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9561 (validate_flags_qcs): New.
9562 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9563 (validate_flags_qcs): Declare.
9564 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9565 (make_frame_apply_options_def_group): New.
9566 (frame_apply_command_count): Process options with
9567 gdb::option::process_options.
9568 (frame_apply_completer): New.
9569 (frame_apply_level_completer, frame_apply_all_completer)
9570 (frame_apply_completer): New.
9571 (_initialize_stack): Update help of "frame apply", "frame apply
9572 level", "frame apply all" and "faas" to mention supported options
9573 and install command completers.
9574 * stack.h (frame_apply_all_completer): Declare.
9575 * thread.c: Include "stack.h".
9576 (tfaas_command): Add "--".
9577 (_initialize_thread): Update help "tfaas" to mention supported
9578 options and install command completer.
9579
9580 2019-06-13 Pedro Alves <palves@redhat.com>
9581
9582 * completer.c (complete_nested_command_line): New.
9583 (gdb_completion_word_break_characters_throw): Add assertion.
9584 * completer.h (complete_nested_command_line): Declare.
9585
9586 2019-06-13 Pedro Alves <palves@redhat.com>
9587
9588 * stack.c (parse_backtrace_qualifiers): New.
9589 (backtrace_command): Use it.
9590 (backtrace_command_completer): Complete on qualifiers.
9591
9592 2019-06-13 Pedro Alves <palves@redhat.com>
9593
9594 * frame.c: Include "cli/cli-option.h.
9595 (user_set_backtrace_options): New.
9596 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9597 Delete.
9598 (get_prev_frame): Adjust.
9599 (boolean_option_def, uinteger_option_def)
9600 (set_backtrace_option_defs): New.
9601 (_initialize_frame): Adjust and use
9602 gdb::option::add_setshow_cmds_for_options to install "set
9603 backtrace past-main" and "set backtrace past-entry".
9604 * frame.h: Include "cli/cli-option.h".
9605 (struct frame_print_options): Forward declare.
9606 (print_frame_arguments_all, print_frame_arguments_scalars)
9607 (print_frame_arguments_none): Declare.
9608 (print_entry_values): Delete declaration.
9609 (struct frame_print_options, user_frame_print_options): New.
9610 (struct set_backtrace_options): New.
9611 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9612 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9613 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9614 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9615 (list_args_or_locals): Add frame_print_options parameter.
9616 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9617 * python/py-framefilter.c (enumerate_args): Pass down
9618 USER_FRAME_PRINT_OPTIONS.
9619 * stack.c: Include "cli/cli-option.h".
9620 (print_frame_arguments_all, print_frame_arguments_scalars)
9621 (print_frame_arguments_none): Declare.
9622 (print_raw_frame_arguments, print_entry_values): Delete.
9623 (user_frame_print_options): New.
9624 (boolean_option_def, enum_option_def, frame_print_option_defs):
9625 New.
9626 (struct backtrace_cmd_options): New.
9627 (bt_flag_option_def): New.
9628 (backtrace_command_option_defs): New.
9629 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9630 (print_frame_arg, read_frame_arg, print_frame_args)
9631 (print_frame_info, print_frame): Add frame_print_options parameter
9632 and use it.
9633 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9634 (backtrace_command_1): Add frame_print_options and
9635 backtrace_cmd_options parameters and use them.
9636 (make_backtrace_options_def_group): New.
9637 (backtrace_command): Process command options with
9638 gdb::option::process_options.
9639 (backtrace_command_completer): New.
9640 (_initialize_stack): Extend "backtrace"'s help to mention
9641 supported options. Install completer for "backtrace".
9642 Install some settings commands with add_setshow_cmds_for_options.
9643
9644 2019-06-13 Pedro Alves <palves@redhat.com>
9645
9646 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9647 and that "set/show print raw frame-arguments" are now deprecated.
9648
9649 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9650 command.
9651 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9652 * stack.c (_initialize_stack): Install "set/show print
9653 raw-frame-arguments", and deprecate "set/show print raw
9654 frame-arguments".
9655 * valprint.c (_initialize_valprint): Deprecate "set/show print
9656 raw".
9657
9658 2019-06-13 Pedro Alves <palves@redhat.com>
9659
9660 * compile/compile.c (struct compile_options): New.
9661 (compile_flag_option_def, compile_command_option_defs)
9662 (make_compile_options_def_group): New.
9663 (compile_file_command): Handle options with
9664 gdb::option::process_options.
9665 (compile_file_command_completer): New function.
9666 (compile_code_command): Handle options with
9667 gdb::option::process_options.
9668 (compile_code_command_completer): New function.
9669 (_initialize_compiler): Install completers for "compile code" and
9670 "compile file". Mention available options in "compile code" and
9671 "compile code"'s help.
9672 * completer.c (advance_to_completion_word): New, factored out from
9673 ...
9674 (advance_to_expression_complete_word_point): ... this.
9675 (advance_to_filename_complete_word_point): New.
9676 * completer.h (advance_to_filename_complete_word_point): New
9677 declaration.
9678
9679 2019-06-13 Pedro Alves <palves@redhat.com>
9680
9681 * compile/compile.c: Include "cli/cli-option.h".
9682 (compile_print_value): Scope data pointer is now a
9683 value_print_options pointer; adjust.
9684 (compile_print_command): Process options. Scope data pointer is
9685 now a value_print_options pointer; adjust.
9686 (_initialize_compile): Update "compile print"'s help to include
9687 supported options. Install a completer for "compile print".
9688 * cp-valprint.c (show_vtblprint, show_objectprint)
9689 (show_static_field_print): Delete.
9690 (_initialize_cp_valprint): Don't install "set print
9691 static-members", "set print vtbl", "set print object" here.
9692 * printcmd.c: Include "cli/cli-option.h" and
9693 "common/gdb_optional.h".
9694 (print_command_parse_format): Rework to fill in a
9695 value_print_options instead of a format_data.
9696 (print_value): Change parameter type from format_data pointer to
9697 value_print_options reference. Adjust.
9698 (print_command_1): Process options. Adjust to pass down a
9699 value_print_options.
9700 (print_command_completer): New.
9701 (_initialize_printcmd): Install print_command_completer as
9702 handle_brkchars completer for the "print" command. Update
9703 "print"'s help to include supported options.
9704 * valprint.c: Include "cli/cli-option.h".
9705 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9706 here from cp-valprint.c.
9707 (boolean_option_def, uinteger_option_def)
9708 (value_print_option_defs, make_value_print_options_def_group):
9709 New. Use gdb::option::add_setshow_cmds_for_options to install
9710 "set print elements", "set print null-stop", "set print repeats",
9711 "set print pretty", "set print union", "set print array", "set
9712 print address", "set print symbol", "set print array-indexes".
9713 * valprint.h: Include <string> and "cli/cli-option.h".
9714 (make_value_print_options_def_group): Declare.
9715 (print_value): Change parameter type from format_data pointer to
9716 value_print_options reference.
9717 (print_command_completer): Declare.
9718
9719 2019-06-13 Pedro Alves <palves@redhat.com>
9720
9721 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9722 (COMMON_SFILES): Add maint-test-settings.c.
9723 * cli/cli-decode.c (boolean_enums): New global, factored out from
9724 ...
9725 (add_setshow_boolean_cmd): ... here.
9726 * cli/cli-decode.h (boolean_enums): Declare.
9727 * cli/cli-option.c: New file.
9728 * cli/cli-option.h: New file.
9729 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9730 factored out from ...
9731 (parse_cli_boolean_value(const char *)): ... this.
9732 (is_unlimited_literal): Change parameter type to pointer to
9733 pointer. Adjust and advance ARG pointer.
9734 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9735 (parse_cli_var_enum): New, factored out from ...
9736 (do_set_command): ... this. Adjust.
9737 * cli/cli-setshow.h (parse_cli_boolean_value)
9738 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9739 (parse_cli_var_enum): Declare.
9740 * cli/cli-utils.c: Include "cli/cli-option.h".
9741 (get_ulongest): New.
9742 * cli/cli-utils.h (get_ulongest): Declare.
9743 (check_for_argument): New overloads.
9744 * maint-test-options.c: New file.
9745
9746 2019-06-13 Pedro Alves <palves@redhat.com>
9747
9748 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9749 parse a range if "-" is at the end of the string.
9750
9751 2019-06-13 Pedro Alves <palves@redhat.com>
9752
9753 * cli/cli-setshow.c (parse_auto_binary_operation)
9754 (parse_cli_boolean_value): Don't allow "o".
9755
9756 2019-06-13 Pedro Alves <palves@redhat.com>
9757
9758 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9759 * NEWS: Mention maint test-settings KIND.
9760 * maint-test-settings.c: New file.
9761
9762 2019-06-13 Pedro Alves <palves@redhat.com>
9763
9764 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9765 completer.
9766 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9767 "set" completers.
9768
9769 2019-06-13 Pedro Alves <palves@redhat.com>
9770
9771 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9772 after item.
9773
9774 2019-06-13 Pedro Alves <palves@redhat.com>
9775
9776 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9777
9778 2019-06-13 Pedro Alves <palves@redhat.com>
9779
9780 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9781 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9782 call.
9783 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9784 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9785 calls.
9786 (check_for_argument): Skip spaces after argument.
9787
9788 2019-06-13 Pedro Alves <palves@redhat.com>
9789
9790 * thread.c (thread_apply_command): Adjust TID parsing.
9791 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9792 detected before end of string.
9793 (tid_is_in_list): Error out if LIST is invalid.
9794
9795 2019-06-13 Pedro Alves <palves@redhat.com>
9796
9797 * completer.c (complete_line_internal_1): Rewind completion word
9798 point.
9799 (completion_tracker::advance_custom_word_point_by): Change
9800 parameter type to int.
9801 * completer.h (completion_tracker::advance_custom_word_point_by):
9802 Likewise.
9803
9804 2019-06-13 Pedro Alves <palves@redhat.com>
9805
9806 * completer.c (advance_to_completion_word): Handle delimiters.
9807
9808 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9809
9810 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9811
9812 2019-06-11 Tom Tromey <tom@tromey.com>
9813
9814 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9815 (xmalloc_failed): Move to alloc.c.
9816 * alloc.c: New file.
9817 * Makefile.in (COMMON_SFILES): Add alloc.c.
9818
9819 2019-06-11 Tom Tromey <tom@tromey.com>
9820
9821 * nat/linux-waitpid.c: Don't include server.h.
9822 (linux_debug): Remove.
9823 (my_waitpid): Update.
9824
9825 2019-06-11 Tom Tromey <tromey@adacore.com>
9826
9827 * infcall.c (_initialize_infcall): Remove trailing newline from
9828 help.
9829 * user-regs.c (_initialize_user_regs): Remove trailing newline
9830 from help.
9831 * typeprint.c (_initialize_typeprint): Remove trailing newline
9832 from help.
9833 * reverse.c (_initialize_reverse): Remove trailing newlines from
9834 help.
9835 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9836 from help.
9837 * language.c (add_set_language_command): Remove trailing newline
9838 from help.
9839 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9840 help.
9841 * disasm.c (_initialize_disasm): Remove trailing newline from
9842 help.
9843 * top.c (init_main): Remove trailing newline from help.
9844 * interps.c (_initialize_interpreter): Remove trailing newline
9845 from help.
9846 * btrace.c (_initialize_btrace): Remove trailing newlines from
9847 help.
9848 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9849 from help.
9850 * python/python.c (_initialize_python): Remove trailing newline
9851 from help.
9852 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9853 help.
9854 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9855 from help. Reformat some text.
9856 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9857 from help.
9858 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9859 newline from help.
9860
9861 2019-06-11 Tom Tromey <tromey@adacore.com>
9862
9863 * darwin-nat.c (darwin_decode_exception_message)
9864 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9865
9866 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9867
9868 * valops.c (value_slice): Check for not allocated or not
9869 associated values.
9870
9871 2019-06-10 Tom de Vries <tdevries@suse.de>
9872
9873 PR gdb/24618
9874 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9875 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9876 invalid.
9877
9878 2019-06-10 Tom de Vries <tdevries@suse.de>
9879
9880 PR gdb/24611
9881 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9882 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9883
9884 2019-06-10 Tom de Vries <tdevries@suse.de>
9885
9886 PR symtab/24545
9887 * symtab.c (struct demangled_name_entry): Add language field.
9888 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9889 static minimal symbol". Set and use language field.
9890
9891 2019-06-10 Tom Tromey <tromey@adacore.com>
9892
9893 * ada-lang.c (_initialize_ada_language): Update help text.
9894
9895 2019-06-10 Tom Tromey <tromey@adacore.com>
9896
9897 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9898 with a newline.
9899 * guile/guile.c (handle_boot_error): Don't end warning with a
9900 newline.
9901 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9902 warning with a newline.
9903 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9904 newline.
9905 (s12z_frame_cache): Likewise.
9906 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9907 a newline.
9908 * solib-svr4.c (disable_probes_interface): Don't end warning with
9909 a newline.
9910 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9911 newline.
9912 * python/python.c (do_finish_initialization): Don't end warning
9913 with a newline.
9914
9915 2019-06-10 Tom Tromey <tom@tromey.com>
9916
9917 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9918 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9919 gdbpy_enter.
9920
9921 2019-06-10 Tom Tromey <tromey@adacore.com>
9922
9923 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9924 data.
9925 (elf_new_init): Don't call stabsread_new_init.
9926 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9927 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9928 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9929
9930 2019-06-10 Tom de Vries <tdevries@suse.de>
9931
9932 PR symtab/16264
9933 PR symtab/24517
9934 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9935
9936 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9937
9938 * source.c (find_and_open_source): Also rewrite relative file
9939 names.
9940
9941 2019-04-26 Amos Bird <amosbird@gmail.com>
9942
9943 * annotate.c (annotate_thread_exited): Add "thread-exited"
9944 annotation.
9945
9946 2019-06-06 Tom Tromey <tromey@adacore.com>
9947
9948 * maint.h (class scoped_command_stats): Use
9949 DISABLE_COPY_AND_ASSIGN.
9950 <print_time>: New method.
9951 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9952 print_time.
9953 (scoped_command_stats::print_time): New method.
9954
9955 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9956
9957 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9958 instructions of lengths 6 or 8 bytes.
9959
9960 2019-06-04 Pedro Alves <palves@redhat.com>
9961
9962 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9963
9964 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9965 * breakpoint.c (condition_completer): Likewise.
9966 * cli/cli-dump.c (scan_expression): Likewise.
9967 * common/filestuff.c (mkdir_recursive): Likewise.
9968 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9969 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9970 (gdb_abspath): Likewise.
9971 * compile/compile-cplus-types.c
9972 (compile_cplus_instance::decl_name): Likewise.
9973 * completer.c (complete_explicit_location):
9974 (signal_completer, reg_or_group_completer_1): Likewise.
9975 * cp-support.c (cp_remove_params_if_any): Likewise.
9976 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9977 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9978 * infcmd.c (strip_bg_char): Likewise.
9979 * linespec.c (copy_token_string): Likewise.
9980 * mi/mi-main.c (output_cores): Likewise.
9981 * psymtab.c (psymtab_search_name):
9982 * symfile.c (test_set_ext_lang_command): Likewise.
9983 * target.c (target_fileio_read_stralloc): Likewise.
9984 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9985 * value.c (complete_internalvar): Likewise.
9986
9987 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9988
9989 Add objfile property to gdb.Type.
9990 * NEWS: Mention Python API addition.
9991 * python/py-type.c (typy_get_objfile): New method.
9992
9993 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9994
9995 * NEWS: Mention the new set|show style [title|highlight].
9996 Mention changes to "show style", "help" and "apropos".
9997
9998 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9999
10000 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10001 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10002 instead of print_help_for_command.
10003 (print_doc_of_command): New function.
10004 (help_list): Add 'apropos -v word' suggestion.
10005 (print_help_for_command): Style the command name using title style.
10006 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10007 (_initialize_cli_cmds): Describe -v in apropos_command help.
10008
10009 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10010
10011 * cli/cli-style.h (cli_style_option): Add name in constructor,
10012 add m_name class member, add constructor with intensity,
10013 add name class function.
10014 (cli_style_option::add_setshow_commands): Remove name argument.
10015 (highlight_style, title_style): New styles.
10016 * cli/cli-style.c (do_show): New function that shows a style
10017 characteristic styling the style name with itself.
10018 (set_style_name): New function.
10019 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10020 Update all callers according to the changes in cli/cli-style.h.
10021 * utils.h (fputs_highlighted): New function.
10022 * utils.c (fputs_highlighted): Likewise.
10023
10024 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10025
10026 * NEWS: Mention new pipe command and new convenience variables.
10027
10028 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10029
10030 * cli/cli-cmds.c (pipe_command): New function.
10031 (_initialize_cli_cmds): Call add_com for pipe_command.
10032 Define | as an alias for pipe.
10033 (exit_status_set_internal_vars): New function.
10034 (shell_escape): Call exit_status_set_internal_vars.
10035 cli/cli-decode.c (find_command_name_length): Recognize | as
10036 a single character command.
10037
10038 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10039
10040 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10041 top.c (execute_command_to_ui_file): New function, mostly a copy
10042 of execute_command_to_string.
10043 (execute_command_to_string): Implement by calling
10044 execute_command_to_ui_file.
10045
10046 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10047
10048 * top.h (saved_command_line): Remove declaration.
10049 * top.c (previous_saved_command_line, previous_repeat_arguments):
10050 New variables.
10051 (saved_command_line): Make static, define together with other
10052 'repeat variables'.
10053 (dont_repeat): Clear repeat_arguments.
10054 (repeat_previous, get_saved_command_line, save_command_line):
10055 New functions.
10056 (gdb_init): Initialize saved_command_line
10057 and previous_saved_command_line.
10058 * main.c (captured_main_1): Remove saved_command_line initialization.
10059 * event-top.c (handle_line_of_input): Update to use
10060 the new 'repeat' related functions instead of direct access to
10061 saved_command_line.
10062 * command.h (repeat_previous, get_saved_command_line,
10063 save_command_line): New declarations.
10064 (dont_repeat): Add comment.
10065
10066 2019-05-30 Tom Tromey <tromey@adacore.com>
10067
10068 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10069 Fix comment.
10070 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10071
10072 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10073
10074 PR cli/24587
10075 * completer.c (complete): Initialize variable word.
10076
10077 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10078
10079 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10080 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10081 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10082 'body' is NULL to the outter 'if', protecting the '!is_define'
10083 situation as well.
10084
10085 2019-05-29 Tom Tromey <tromey@adacore.com>
10086
10087 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10088 (dwarf_unknown): New function.
10089 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10090 (dwarf_type_encoding_name): Use dwarf_unknown.
10091
10092 2019-05-29 Tom Tromey <tromey@adacore.com>
10093
10094 PR c++/20020:
10095 * cp-valprint.c (cp_print_value_fields): Call
10096 cp_print_static_field inside "try".
10097
10098 2019-05-29 Tom Tromey <tromey@adacore.com>
10099
10100 * inflow.c (struct terminal_info): Add default operator=.
10101 * configure: Rebuild.
10102 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10103 -Wdeprecated-copy-dtor, -Wredundant-move.
10104
10105 2019-05-29 Tom Tromey <tromey@adacore.com>
10106
10107 * NEWS: Add entry.
10108 * infcmd.c (print_return_value_1): Handle finish_print
10109 option.
10110 (show_print_finish): New function.
10111 (_initialize_infcmd): Add "set/show print finish" commands.
10112 * valprint.c (user_print_options): Initialize new member.
10113 * valprint.h (struct value_print_options) <finish_print>: New
10114 member.
10115
10116 2019-05-28 Tom Tromey <tromey@adacore.com>
10117
10118 * ada-lang.c (ada_remove_Xbn_suffix)
10119 (find_old_style_renaming_symbol)
10120 (parse_old_style_renaming): Remove.
10121 (ada_find_renaming_symbol): Don't call
10122 find_old_style_renaming_symbol.
10123 (ada_is_renaming_symbol): Rename from
10124 ada_find_renaming_symbol. Remove "block" parameter. Return
10125 bool. Now static.
10126 (ada_read_var_value): Update and simplify.
10127 * ada-exp.y (write_var_or_type): Remove old code.
10128
10129 2019-05-28 Alan Hayward <alan.hayward@arm.com>
10130
10131 PR gdb/25010
10132 * event-top.c: Remove include comment.
10133 * inflow.c (class scoped_ignore_sigttou): Move from here...
10134 * inflow.h (class scoped_ignore_sigttou): ...to here.
10135 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10136 * top.c: Remove include comment.
10137
10138 2019-05-27 Tom Tromey <tom@tromey.com>
10139
10140 * NEWS: Fix typo.
10141
10142 2019-05-22 Tom Tromey <tromey@adacore.com>
10143
10144 * target.c (target_follow_exec): Constify parameter.
10145 * target-delegates.c: Rebuild.
10146 * remote.c (remote_target::follow_exec): Constify parameter.
10147 * infrun.c (follow_exec): Constify parameter.
10148 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10149 (target_follow_exec): Likewise.
10150
10151 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10152
10153 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10154 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10155
10156 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10157
10158 * NEWS: Add debugredirect and testsuite sections.
10159
10160 2019-05-22 Simon Cook <simon.cook@embecosm.com>
10161
10162 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10163 target descriptions using exclusively floating point register name
10164 aliases.
10165
10166 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10167
10168 PR gdb/18644:
10169 * f-lang.c (build_fortran_types): Handle the case where
10170 gdbarch_floatformat_for_type returns a nullptr.
10171
10172 2019-05-21 Tom de Vries <tdevries@suse.de>
10173
10174 PR cli/24587
10175 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10176
10177 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10178
10179 PR gdb/18644:
10180 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10181 16-byte floats.
10182 * i386-tdep.c (i386_floatformat_for_type): Use
10183 floatformats_ia64_quad for the 16-byte floating point component
10184 within a fortran 32-byte complex number.
10185
10186 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10187
10188 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10189 delete default constructor.
10190 (find_partial_die): Update to return const struct.
10191 (partial_die_parent_scope): Move variable declaration into scope
10192 of its use and change its type to auto.
10193 (guess_partial_die_structure_name): Likewise.
10194 (partial_die_info::fixup): Likewise.
10195
10196 2019-05-17 Tom Tromey <tromey@adacore.com>
10197
10198 * source.c (find_and_open_source): Remove cast.
10199
10200 2019-05-17 Tom Tromey <tromey@adacore.com>
10201
10202 * annotate.c (annotate_source): Make "filename" const.
10203 * annotate.h (annotate_source): Use const.
10204
10205 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10206
10207 * disasm.c (set_disassembler_options): Send errors to stderr.
10208
10209 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10210
10211 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10212 (cli_interp_base::set_logging): Check debug_redirect.
10213 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10214 * cli/cli-logging.c (debug_redirect): Add static variable.
10215 (pop_output_files): Add default param.
10216 (handle_redirections): Print debug setting.
10217 (show_logging_command): Likewise.
10218 (_initialize_cli_logging): Add debugredirect command.
10219 * interps.c (current_interp_set_logging): Add debug_redirect
10220 parameter.
10221 * interps.h (set_logging): Add debug_redirect parameter.
10222 (current_interp_set_logging): Likewise.
10223 * mi/mi-common.h: Likewise.
10224 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10225
10226 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10227 Tom Tromey <tromey@adacore.com>
10228
10229 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10230 directly.
10231 * cli/cli-interp.h (make_logging_output): Remove declaration.
10232 * cli/cli-logging.c (make_logging_output): Remove function.
10233 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10234 directly.
10235 * ui-file.c (tee_file::tee_file): Remove bools.
10236 (tee_file::~tee_file): Remove deletes.
10237 * ui-file.h (tee_file): Remove bools.
10238
10239 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10240
10241 * mi/mi-cmds.h (mi_cmd_complete): New function.
10242 * mi/mi-main.c (mi_cmd_complete): Likewise.
10243 * mi/mi-cmds.c: Define new MI command -complete.
10244 * NEWS: Mention new -complete command.
10245
10246 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10247
10248 * completer.h (complete): New function.
10249 * completer.c (complete): Likewise.
10250 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10251 function defined in completer.h.
10252
10253 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10254
10255 * MAINTAINERS (Write After Approval): Add myself.
10256
10257 2019-05-17 Tom de Vries <tdevries@suse.de>
10258
10259 PR gdb/24094
10260 * dwarf2read.c (struct cu_partial_die_info): New struct.
10261 (find_partial_die): Return cu_partial_die_info.
10262 (partial_die_parent_scope, guess_partial_die_structure_name)
10263 (partial_die_info::fixup): Handle new return type of find_partial_die.
10264
10265 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10266
10267 PR breakpoints/24541
10268 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10269 "std::string", simplifying the algorithm.
10270
10271 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10272
10273 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10274 (stap_static_probe_ops::get_probes): Likewise.
10275
10276 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10277
10278 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10279 '-')" and "else if".
10280 (stap_parse_single_operand): Join checks for
10281 "gdbarch_stap_parse_special_token_p" and
10282 "gdbarch_stap_parse_special_token" in the same "if" statement.
10283 Invert check when verifying for operation on register
10284 displacement.
10285
10286 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10287
10288 * stap-probe.c (stap_get_opcode): Update comment.
10289 (stap_get_expected_argument_type): Likewise.
10290 (handle_stap_probe): Likewise.
10291
10292 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10293
10294 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10295 return type to 'bool'. Adjust comment. Use 'bool' when
10296 appropriate.
10297 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10298 * stap-probe.c (stap_parse_argument_1): Likewise.
10299 (stap_is_operator): Likewise.
10300 (stap_is_generic_prefix): Likewise.
10301 (stap_is_register_prefix): Likewise.
10302 (stap_is_register_indirection_prefix): Likewise.
10303 (stap_is_integer_prefix): Likewise.
10304 (stap_generic_check_suffix): Likewise.
10305 (stap_check_integer_suffix): Likewise.
10306 (stap_check_register_suffix): Likewise.
10307 (stap_check_register_indirection_suffix): Likewise.
10308 (stap_parse_register_operand): Likewise.
10309 (stap_parse_single_operand): Likewise.
10310 (stap_parse_argument_1): Likewise.
10311 (stap_probe::get_argument_count): Likewise.
10312 (stap_is_operator): Likewise.
10313
10314 2019-05-16 Tom Tromey <tromey@adacore.com>
10315
10316 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10317 keyword to foreach.
10318
10319 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
10320
10321 * linux-thread-db.c (try_thread_db_load_1): Change return type
10322 to bool.
10323 (try_thread_db_load): Likewise.
10324 (try_thread_db_load_from_pdir_1): Likewise.
10325 (try_thread_db_load_from_pdir): Likewise.
10326 (try_thread_db_load_from_sdir): Likewise.
10327 (try_thread_db_load_from_dir): Likewise.
10328 (thread_db_load_search): Likewise.
10329 (has_libpthread): Likewise.
10330 (thread_db_load): Likewise.
10331
10332 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10333
10334 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10335 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10336 NULL, and complain/return if that's the case.
10337
10338 2019-05-15 John Darrington <john@darrington.wattle.id.au>
10339
10340 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10341 (advance, posn, abstract_read_memory): New functions.
10342 [struct mem_read_abstraction]: New struct.
10343 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10344
10345 2019-05-14 Tom Tromey <tromey@adacore.com>
10346
10347 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10348 value is not lval_memory.
10349
10350 2019-05-14 Tom Tromey <tromey@adacore.com>
10351
10352 * solib.c (info_sharedlibrary_command): Style the file name.
10353
10354 2019-05-14 Alan Hayward <alan.hayward@arm.com>
10355
10356 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10357 (aarch64_vnv_type): Likewise.
10358 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10359 * common/tdesc.c: Likewise.
10360 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10361 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10362 * features/aarch64-fpu.xml: Add ieee half view.
10363 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10364 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10365 * gdbtypes.h (struct builtin_type): Likewise.
10366 (struct objfile_type): Likewise.
10367
10368 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
10369
10370 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10371 typo.
10372 * location.h (string_to_event_location): Likewise.
10373
10374 2019-05-11 Joel Brobecker <brobecker@adacore.com>
10375
10376 GDB 8.3 released.
10377
10378 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10379
10380 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10381 New variable declaration.
10382 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10383 New variable.
10384 (print_one_breakpoint): Use ui_out::test_flags and new global
10385 variable to compute use_fixed_output.
10386 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10387 Remove.
10388 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10389 (mi_multi_location_breakpoint_output_fixed): Remove.
10390 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10391 new variable.
10392 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10393 fix_multi_location_breakpoint_output flag if version >= 3.
10394 * ui-out.h (enum ui_out_flag)
10395 <fix_multi_location_breakpoint_output>: New enumerator.
10396
10397 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10398
10399 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10400
10401 2019-05-10 Tom Tromey <tromey@adacore.com>
10402
10403 * ada-lang.c (catch_ada_completer): New function.
10404 (_initialize_ada_language): Use it.
10405
10406 2019-05-10 Tom Tromey <tromey@adacore.com>
10407
10408 * thread.c (print_thread_info): Make "requested_threads" const.
10409 * gdbthread.h (print_thread_info): Make "requested_threads"
10410 const.
10411 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10412 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10413
10414 2019-05-08 Tom Tromey <tom@tromey.com>
10415
10416 * gdbtypes.c (objfile_type_data): Change type.
10417 (objfile_type, _initialize_gdbtypes): Update.
10418
10419 2019-05-08 Tom Tromey <tom@tromey.com>
10420
10421 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10422 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10423 (_initialize_dwarf2_frame): Update.
10424
10425 2019-05-08 Tom Tromey <tom@tromey.com>
10426
10427 * objc-lang.c (objc_objfile_data): Change type.
10428 (find_methods): Update.
10429 (_initialize_objc_lang): Remove.
10430
10431 2019-05-08 Tom Tromey <tom@tromey.com>
10432
10433 * stabsread.c (rs6000_builtin_type_data): Change type.
10434 (rs6000_builtin_type, _initialize_stabsread): Update.
10435
10436 2019-05-08 Tom Tromey <tom@tromey.com>
10437
10438 * mips-tdep.c (mips_pdr_data): Remove.
10439 (_initialize_mips_tdep): Update.
10440
10441 2019-05-08 Tom Tromey <tom@tromey.com>
10442
10443 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10444 (hppa_init_objfile_priv_data, read_unwind_info)
10445 (find_unwind_entry, _initialize_hppa_tdep): Update.
10446
10447 2019-05-08 Tom Tromey <tom@tromey.com>
10448
10449 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10450 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10451 on obstack.
10452 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10453
10454 2019-05-08 Tom Tromey <tom@tromey.com>
10455
10456 * mdebugread.c (basic_type_data): Change type.
10457 (basic_type, _initialize_mdebugread): Update.
10458
10459 2019-05-08 Tom Tromey <tom@tromey.com>
10460
10461 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10462
10463 2019-05-08 Tom Tromey <tom@tromey.com>
10464
10465 * nto-tdep.c (nto_inferior_data_reg): Change type.
10466 (nto_inferior_data): Update.
10467 (nto_inferior_data_cleanup, nto_new_inferior_data)
10468 (_initialize_nto_tdep): Remove.
10469 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10470
10471 2019-05-08 Tom Tromey <tom@tromey.com>
10472
10473 * ada-lang.c (struct ada_inferior_data): Add initializers.
10474 (ada_inferior_data): Change type.
10475 (ada_inferior_data_cleanup): Remove.
10476 (get_ada_inferior_data, ada_inferior_exit)
10477 (struct ada_pspace_data): Add initializers, destructor.
10478 (ada_pspace_data_handle): Change type.
10479 (get_ada_pspace_data): Update.
10480 (ada_pspace_data_cleanup): Remove.
10481
10482 2019-05-08 Tom Tromey <tom@tromey.com>
10483
10484 * coffread.c (struct coff_symfile_info): Add initializers.
10485 (coff_objfile_data_key): Move lower. Change type.
10486 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10487 Update.
10488 (coff_free_info): Remove.
10489
10490 2019-05-08 Tom Tromey <tom@tromey.com>
10491
10492 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10493 (fbsd_pspace_data_handle): Move lower. Change type.
10494 (get_fbsd_pspace_data): Update.
10495 (fbsd_pspace_data_cleanup): Remove.
10496 (_initialize_fbsd_tdep): Update.
10497
10498 2019-05-08 Tom Tromey <tom@tromey.com>
10499
10500 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10501 (get_ada_tasks_pspace_data): Update.
10502 (ada_tasks_pspace_data_cleanup): Remove.
10503 (_initialize_tasks): Update.
10504 (ada_tasks_inferior_data_handle): Change type.
10505 (get_ada_tasks_inferior_data): Update.
10506 (ada_tasks_inferior_data_cleanup): Remove.
10507 (struct ada_tasks_pspace_data): Add initializers.
10508
10509 2019-05-08 Tom Tromey <tom@tromey.com>
10510
10511 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10512 * symfile-debug.c (debug_sym_get_probes): Change type.
10513 * stap-probe.c (handle_stap_probe):
10514 (stap_static_probe_ops::get_probes): Change type.
10515 * probe.h (class static_probe_ops) <get_probes>: Change type.
10516 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10517 (parse_probes_in_pspace): Update.
10518 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10519 Update.
10520 (any_static_probe_ops::get_probes): Change type.
10521 * elfread.c (elfread_data): New typedef.
10522 (probe_key): Change type.
10523 (elf_get_probes): Likewise. Update.
10524 (probe_key_free): Remove.
10525 (_initialize_elfread): Update.
10526 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10527 Change type.
10528 (dtrace_process_dof_probe, dtrace_process_dof)
10529 (dtrace_static_probe_ops::get_probe): Change type.
10530
10531 2019-05-08 Tom Tromey <tom@tromey.com>
10532
10533 * xcoffread.c (struct xcoff_symfile_info): Rename from
10534 coff_symfile_info. Add initializers.
10535 (xcoff_objfile_data_key): Move lower. Change type.
10536 (XCOFF_DATA): Rewrite.
10537 (xcoff_free_info): Remove.
10538 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10539 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10540 (xcoff_initial_scan): Update.
10541
10542 2019-05-08 Tom Tromey <tom@tromey.com>
10543
10544 * solib-svr4.c (struct svr4_info): Add initializers and
10545 destructor.
10546 <probes_table>: Now an htab_up.
10547 (solib_svr4_pspace_data): Change type.
10548 (free_probes_table): Simplify.
10549 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10550 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10551 (probes_table_remove_objfile_probes, register_solib_event_probe)
10552 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10553 (_initialize_svr4_solib): Update.
10554
10555 2019-05-08 Tom Tromey <tom@tromey.com>
10556
10557 * remote.c (remote_pspace_data): Change type.
10558 (remote_pspace_data_cleanup): Remove.
10559 (get_remote_exec_file, set_pspace_remote_exec_file)
10560 (_initialize_remote): Update.
10561
10562 2019-05-08 Tom Tromey <tom@tromey.com>
10563
10564 * breakpoint.c (breakpoint_objfile_key): Change type.
10565 (get_breakpoint_objfile_data): Update.
10566 (free_breakpoint_objfile_data): Remove.
10567 (_initialize_breakpoint): Update.
10568
10569 2019-05-08 Tom Tromey <tom@tromey.com>
10570
10571 * linux-tdep.c (struct linux_info): Add initializers.
10572 (linux_inferior_data): Move. Change type.
10573 (invalidate_linux_cache_inf): Update.
10574 (linux_inferior_data_cleanup): Remove.
10575 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10576
10577 2019-05-08 Tom Tromey <tom@tromey.com>
10578
10579 * auxv.c (auxv_inferior_data): Move. Change type.
10580 (auxv_inferior_data_cleanup): Remove.
10581 (invalidate_auxv_cache_inf): Rewrite.
10582 (get_auxv_inferior_data, _initialize_auxv): Update.
10583
10584 2019-05-08 Tom Tromey <tom@tromey.com>
10585
10586 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10587 (symfile_debug_objfile_data_key): Change type.
10588 (symfile_debug_installed, debug_qf_has_symbols)
10589 (debug_qf_find_last_source_symtab)
10590 (debug_qf_forget_cached_source_info)
10591 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10592 (debug_qf_print_stats, debug_qf_dump)
10593 (debug_qf_expand_symtabs_for_function)
10594 (debug_qf_expand_all_symtabs)
10595 (debug_qf_expand_symtabs_with_fullname)
10596 (debug_qf_map_matching_symbols)
10597 (debug_qf_expand_symtabs_matching)
10598 (debug_qf_find_pc_sect_compunit_symtab)
10599 (debug_qf_map_symbol_filenames)
10600 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10601 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10602 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10603 (debug_sym_read_linetable, debug_sym_relocate): Update.
10604 (symfile_debug_free_objfile): Remove.
10605 (install_symfile_debug_logging, _initialize_symfile_debug):
10606 Update.
10607
10608 2019-05-08 Tom Tromey <tom@tromey.com>
10609
10610 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10611 allocate_on_obstack.
10612 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10613 (get_dwarf2_per_objfile): Update.
10614 (set_dwarf2_per_objfile): Remove.
10615 (dwarf2_has_info, dwarf2_get_section_info): Update.
10616 (dwarf2_free_objfile): Remove.
10617 (_initialize_dwarf2_read): Update.
10618
10619 2019-05-08 Tom Tromey <tom@tromey.com>
10620
10621 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10622 initializers.
10623 <unsupported_script_warning_printed,
10624 script_not_found_warning_printed>: Now bool.
10625 (auto_load_pspace_data): Change type.
10626 (~auto_load_pspace_info): Rename from
10627 auto_load_pspace_data_cleanup.
10628 (get_auto_load_pspace_data, init_loaded_scripts_info)
10629 (clear_section_scripts, maybe_print_unsupported_script_warning)
10630 (maybe_print_script_not_found_warning, _initialize_auto_load):
10631 Update.
10632
10633 2019-05-08 Tom Tromey <tom@tromey.com>
10634
10635 * objfiles.c (objfile_pspace_info): Add destructor and
10636 initializers.
10637 (objfiles_pspace_data): Change type.
10638 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10639 (get_objfile_pspace_data): Update.
10640 (objfiles_bfd_data): Change type.
10641 (get_objfile_bfd_data): Update.
10642 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10643
10644 2019-05-08 Tom Tromey <tom@tromey.com>
10645
10646 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10647 Change type.
10648 (get_catch_syscall_inferior_data): Update.
10649 (catch_syscall_inferior_data_cleanup): Remove.
10650 (_initialize_break_catch_syscall): Update.
10651
10652 2019-05-08 Tom Tromey <tom@tromey.com>
10653
10654 * inflow.c (struct terminal_info): Add destructor and
10655 initializers.
10656 (inflow_inferior_data): Change type.
10657 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10658 (get_inflow_inferior_data, inflow_inferior_exit)
10659 (swap_terminal_info, _initialize_inflow): Update.
10660
10661 2019-05-08 Tom Tromey <tom@tromey.com>
10662
10663 * target-dcache.c (target_dcache_cleanup): Remove.
10664 (target_dcache_aspace_key): Change type.
10665 (target_dcache_init_p, target_dcache_invalidate)
10666 (target_dcache_get, target_dcache_get_or_init)
10667 (_initialize_target_dcache): Update.
10668 * dcache.h (struct dcache_deleter): New.
10669
10670 2019-05-08 Tom Tromey <tom@tromey.com>
10671
10672 * symtab.c (struct symbol_cache): Add destructor and
10673 initializers.
10674 (symbol_cache_key): Move. Change type.
10675 (make_symbol_cache, free_symbol_cache): Remove.
10676 (get_symbol_cache): Update.
10677 (symbol_cache_cleanup): Remove.
10678 (ALL_PSPACES, symbol_cache_flush)
10679 (maintenance_print_symbol_cache)
10680 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10681 Update.
10682
10683 2019-05-08 Tom Tromey <tom@tromey.com>
10684
10685 * symtab.c (struct main_info): Add destructor and initializers.
10686 (main_progspace_key): Move. Change type.
10687 (get_main_info): Update.
10688 (main_info_cleanup): Remove.
10689 (_initialize_symtab): Update.
10690
10691 2019-05-08 Tom Tromey <tom@tromey.com>
10692
10693 * registry.h (DECLARE_REGISTRY): Define the _key class.
10694
10695 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10696
10697 * NEWS: Merge two 'New commands' sections.
10698
10699 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10700
10701 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10702 parameter and use Ada language definition instead.
10703 (ada_val_print_ptr): Remove unused language parameter.
10704 (ada_val_print_num): Remove language parameter and use Ada language
10705 definition instead.
10706 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10707 parameter.
10708 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10709 parameter and use Ada language definition instead.
10710 (ada_val_print_1): Update all ada_val_print_xxx calls.
10711 Remove language parameter.
10712 (ada_val_print): Update ada_val_print_1 call.
10713
10714 2019-05-08 Tom Tromey <tromey@adacore.com>
10715
10716 * remote.c (remote_hw_watchpoint_limit)
10717 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10718 Now static.
10719
10720 2019-05-08 Tom Tromey <tromey@adacore.com>
10721
10722 * maint.c (_initialize_maint_cmds): Move initialization code to
10723 remote.c.
10724 (watchdog, show_watchdog): Move to remote.c.
10725 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10726 "watchdog" static.
10727 (_initialize_remote): Move initialization code from maint.c.
10728 * defs.h (watchdog): Don't declare.
10729
10730 2019-05-08 Tom Tromey <tromey@adacore.com>
10731
10732 * tui/tui-interp.c: Include main.h.
10733 * interps.c: Include main.h.
10734 * main.h (interpreter_p): Declare.
10735 * defs.h (interpreter_p): Don't declare.
10736
10737 2019-05-08 Tom Tromey <tromey@adacore.com>
10738
10739 * dwarf2loc.c: Include dwarf2read.h.
10740 * defs.h (read_unsigned_leb128): Don't declare.
10741 * dwarf2read.h (read_unsigned_leb128): Declare.
10742
10743 2019-05-08 Tom Tromey <tromey@adacore.com>
10744
10745 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10746 method.
10747
10748 2019-05-08 Tom Tromey <tromey@adacore.com>
10749
10750 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10751 when no wrap column is set.
10752
10753 2019-05-08 Tom Tromey <tromey@adacore.com>
10754
10755 * c-lang.c (c_get_string): Handle non-C-style arrays.
10756
10757 2019-05-08 Tom Tromey <tromey@adacore.com>
10758
10759 * typeprint.c (print_offset_data::update): Print the bit offset,
10760 not the number of bits remaining.
10761
10762 2019-05-08 Tom Tromey <tromey@adacore.com>
10763
10764 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10765 padding at end of comment.
10766
10767 2019-05-08 Tom Tromey <tromey@adacore.com>
10768
10769 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10770 Compare main types.
10771
10772 2019-05-06 Tom Tromey <tom@tromey.com>
10773
10774 * common/scoped_mmap.c: Include common-defs.h.
10775 * common/scoped_mmap.h: Don't include config.h.
10776
10777 2019-05-04 Tom Tromey <tom@tromey.com>
10778
10779 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10780 (struct aarch64_call_info): Add initializers.
10781 <si>: Now a std::vector.
10782 (pass_on_stack, aarch64_push_dummy_call): Update.
10783
10784 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10785 Tom Tromey <tom@tromey.com>
10786
10787 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10788 (ppc_threads): Now a std::vector. Now static.
10789 (hwdebug_find_thread_points_by_tid)
10790 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10791 Update.
10792
10793 2019-05-04 Tom Tromey <tom@tromey.com>
10794
10795 * arc-tdep.c (arc_tdesc_init): Return bool.
10796
10797 2019-05-04 Tom Tromey <tom@tromey.com>
10798
10799 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10800 Use gdb_assert_not_reached.
10801
10802 2019-05-04 Tom Tromey <tom@tromey.com>
10803
10804 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10805 "false".
10806
10807 2019-05-04 Tom Tromey <tom@tromey.com>
10808
10809 * arc-tdep.c (arc_tdesc_init): Use bool.
10810
10811 2019-05-04 Tom Tromey <tom@tromey.com>
10812
10813 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10814
10815 2019-05-04 Tom Tromey <tom@tromey.com>
10816
10817 * cli/cli-cmds.c (valid_command_p): Return bool.
10818
10819 2019-05-04 Tom Tromey <tom@tromey.com>
10820
10821 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10822 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10823
10824 2019-05-04 Raul Tambre <raul@tambre.ee>
10825
10826 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10827 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10828 operator for comparison.
10829
10830 2019-05-04 Tom Tromey <tom@tromey.com>
10831
10832 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10833 (lookup_partial_symbol, print_partial_symbols)
10834 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10835 (psymbol_compare): Update.
10836 (add_psymbol_to_bcache): Clear the entire psymbol.
10837 (maintenance_check_psymtabs): Update.
10838 * psympriv.h (struct partial_symbol): Don't derive from
10839 general_symbol_info.
10840 <obj_section, unrelocated_address, address,
10841 set_unrelocated_address>: Update.
10842 <ginfo>: New member.
10843 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10844 (debug_names::write_psymbols): Update.
10845
10846 2019-05-04 Tom de Vries <tdevries@suse.de>
10847
10848 * contrib/cc-with-tweaks.sh: Support -n arg.
10849
10850 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10851
10852 * corelow.c (core_target::detach): Ensure frame cache and
10853 register caches are cleared.
10854 inferior.c (exit_inferior_1): Likewise.
10855
10856 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10857 Tom Tromey <tom@tromey.com>
10858
10859 * dictionary.c (collate_pending_symbols_by_language): Remove
10860 "struct" from foreach.
10861 * symtab.c (lookup_global_symbol_from_objfile)
10862 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10863 foreach.
10864 * ser-tcp.c (net_open): Remove "struct" from foreach.
10865 * objfiles.c (objfile_relocate, objfile_rebase)
10866 (objfile_has_symbols): Remove "struct" from foreach.
10867 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10868 from foreach.
10869 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10870 foreach.
10871 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10872 "struct" from foreach.
10873 * ada-lang.c (create_excep_cond_exprs)
10874 (ada_exception_catchpoint_cond_string): Remove "struct" from
10875 foreach.
10876
10877 2019-05-03 Tom Tromey <tromey@adacore.com>
10878
10879 * ada-exp.y (convert_char_literal): Check suffix of each
10880 enumerator.
10881
10882 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10883
10884 PR ada/21406:
10885 * ada-exp.y (yywrap): Don't define.
10886 * ada-lex.l (%option): Add noyywrap
10887 (yywrap): Remove.
10888
10889 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10890
10891 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10892 _WIN32_WINNT to the XP level, unless already defined to a higher
10893 level.
10894
10895 * unittests/parse-connection-spec-selftests.c:
10896 * ser-tcp.c:
10897 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10898 override.
10899
10900 * symfile.c (find_separate_debug_file): Remove colon from the
10901 drive spec of DOS/Windows file names of the target, so that the
10902 file name produced from DEBUGDIR and the target's directory will
10903 be valid on DOS/Windows systems.
10904
10905 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10906
10907 * rust-lang.c (val_print_struct): Handle printing structures
10908 containing strings.
10909
10910 2019-05-02 Tom Tromey <tromey@adacore.com>
10911
10912 * valarith.c (_initialize_valarith): Remove.
10913
10914 2019-05-01 Tom Tromey <tromey@adacore.com>
10915
10916 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10917 bitfields.
10918
10919 2019-05-01 Tom Tromey <tromey@adacore.com>
10920
10921 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10922 for big-endian copies.
10923
10924 2019-04-30 Ali Tamur <tamur@google.com>
10925 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10926 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10927 (read_3_bytes): New function.
10928
10929 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10930
10931 * windows-nat.c (main_thread_id): Delete.
10932 (handle_output_debug_string): Replace main_thread_id by
10933 current_event.dwThreadId.
10934 (fake_create_process): Likewise.
10935 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10936 Do not set main_thread_id.
10937 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10938 current_event.dwThreadId.
10939 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10940
10941 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10942
10943 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10944 Use current_event.dwThreadId instead of main_thread_id.
10945
10946 2019-04-30 Tom Tromey <tromey@adacore.com>
10947
10948 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10949 (create_excep_cond_exprs): Iterate over program spaces.
10950 (ada_exception_catchpoint_cond_string): Examine all minimal
10951 symbols for exception types.
10952
10953 2019-04-30 Tom Tromey <tromey@adacore.com>
10954
10955 PR c++/24470:
10956 * dwarf2read.c (process_structure_scope): Handle case where type
10957 has template parameters but no symbol was created.
10958
10959 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10960 Chris January <chris.january@arm.com>
10961
10962 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10963 qualifier.
10964 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10965
10966 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10967
10968 * f-typeprint.c (f_print_type): Update rules for printing
10969 whitespace.
10970 (f_type_print_varspec_suffix): Likewise.
10971
10972 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10973 Chris January <chris.january@arm.com>
10974
10975 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10976 function arguments.
10977
10978 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10979
10980 * f-lang.c (build_fortran_types): Change name of void type to
10981 lower case.
10982 * f-typeprint.c (f_type_print_base): Print the name of the void
10983 type, rather than a fixed string.
10984 * f-valprint.c (f_decorations): Use lower case void string.
10985
10986 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10987 Chris January <chris.january@arm.com>
10988
10989 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10990 types for Fortran.
10991
10992 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10993 Chris January <chris.january@arm.com>
10994 David Lecomber <david.lecomber@arm.com>
10995
10996 * f-exp.y (BINOP_INTRINSIC): New token.
10997 (exp): New parser rule handling BINOP_INTRINSIC.
10998 (f77_keywords): Add new builtin procedures.
10999 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11000 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11001 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11002 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11003 (print_unop_subexp_f): New function.
11004 (print_binop_subexp_f): New function.
11005 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11006 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11007 (dump_subexp_body_f): Likewise.
11008 (operator_check_f): Likewise.
11009 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11010 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11011
11012 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11013
11014 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11015 UNOP_KIND.
11016 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11017 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11018 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11019 (operator_length_f): New fuction.
11020 (print_subexp_f): New function.
11021 (op_name_f): New function.
11022 (dump_subexp_body_f): New function.
11023 (operator_check_f): New function.
11024 (exp_descriptor_f): Replace standard expression handling functions
11025 with new functions.
11026 * gdb/fortran-operator.def: New file.
11027 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11028 * gdb/std-operator.def: Remove UNOP_KIND.
11029
11030 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11031
11032 * std-operator.def: Remove unbalanced, stray double quote
11033 character.
11034
11035 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11036 Chris January <chris.january@arm.com>
11037 Daniel Everett <daniel.everett@arm.com>
11038 Nick Forrington <nick.forrington@arm.com>
11039 Richard Bunt <richard.bunt@arm.com>
11040
11041 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11042 of depth when printing anonymous structs or unions.
11043 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11044 Don't print either the top-level value, or the children if the
11045 max-depth is exceeded.
11046 (ppscm_print_children): When printing the key of a map, allow one
11047 extra level of depth.
11048 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11049 print either the top-level value, or the children if the max-depth
11050 is exceeded.
11051 (print_children): When printing the key of a map, allow one extra
11052 level of depth.
11053 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11054 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11055 (user_print_options): Initialise max_depth field.
11056 (val_print_scalar_or_string_type_p): New function.
11057 (val_print): Check to see if the max depth has been reached.
11058 (val_print_check_max_depth): Define new function.
11059 (show_print_max_depth): New function.
11060 (_initialize_valprint): Add 'print max-depth' option.
11061 * valprint.h (struct value_print_options) <max_depth>: New field.
11062 (val_print_check_max_depth): Declare new function.
11063 * NEWS: Document new feature.
11064
11065 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11066
11067 * ada-lang.c (ada_language_defn): Initialise new field.
11068 * c-lang.c (c_is_string_type_p): New function.
11069 (c_language_defn): Initialise new field.
11070 (cplus_language_defn): Initialise new field.
11071 (asm_language_defn): Initialise new field.
11072 (minimal_language_defn): Initialise new field.
11073 * c-lang.h (c_is_string_type_p): Declare new function.
11074 * d-lang.c (d_language_defn): Initialise new field.
11075 * f-lang.c (f_is_string_type_p): New function.
11076 (f_language_defn): Initialise new field.
11077 * go-lang.c (go_is_string_type_p): New function.
11078 (go_language_defn): Initialise new field.
11079 * language.c (default_is_string_type_p): New function.
11080 (unknown_language_defn): Initialise new field.
11081 (auto_language_defn): Initialise new field.
11082 * language.h (struct language_defn) <la_is_string_type_p>: New
11083 member variable.
11084 (default_is_string_type_p): Declare new function.
11085 * m2-lang.c (m2_language_defn): Initialise new field.
11086 * objc-lang.c (objc_language_defn): Initialise new field.
11087 * opencl-lang.c (opencl_language_defn): Initialise new field.
11088 * p-lang.c (pascal_is_string_type_p): New function.
11089 (pascal_language_defn): Initialise new field.
11090 * rust-lang.c (rust_is_string_type_p): New function.
11091 (rust_language_defn): Initialise new field.
11092
11093 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11094
11095 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11096 New field.
11097 * ada-lang.c (ada_language_defn): Initialise new field.
11098 * c-lang.c (c_language_defn): Likewise.
11099 (cplus_language_defn): Likewise.
11100 (asm_language_defn): Likewise.
11101 (minimal_language_defn): Likewise.
11102 * d-lang.c (d_language_defn): Likewise.
11103 * f-lang.c (f_language_defn): Likewise.
11104 * go-lang.c (go_language_defn): Likewise.
11105 * language.c (unknown_language_defn): Likewise.
11106 (auto_language_defn): Likewise.
11107 * m2-lang.c (m2_language_defn): Likewise.
11108 * objc-lang.c (objc_language_defn): Likewise.
11109 * opencl-lang.c (opencl_language_defn): Likewise.
11110 * p-lang.c (pascal_language_defn): Likewise.
11111 * rust-lang.c (rust_language_defn): Likewise.
11112
11113 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11114
11115 * ada-lang.c (ada_is_character_type): Change return type to bool.
11116 (ada_is_string_type): Likewise.
11117 * ada-lang.h (ada_is_character_type): Update declaration
11118 (ada_is_string_type): Likewise.
11119
11120 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11121
11122 Support style in 'frame|thread apply'
11123
11124 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11125 * record.c (record_start, record_stop): Update callers of
11126 execute_command_to_string with false.
11127 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11128 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11129 methods.
11130 (class string_file): New constructor with term_out parameter.
11131 Override methods term_out and can_emit_style_escape. New member
11132 term_out.
11133 (class stdio_file): Override can_emit_style_escape.
11134 (class tee_file): Override term_out and can_emit_style_escape.
11135 * utils.h (can_emit_style_escape): Remove.
11136 * utils.c (can_emit_style_escape): Likewise.
11137 Update all callers of can_emit_style_escape (SOMESTREAM) to
11138 SOMESTREAM->can_emit_style_escape.
11139 * source-cache.c (source_cache::get_source_lines): Likewise.
11140 * stack.c (frame_apply_command_count): Call execute_command_to_string
11141 passing the term_out characteristic of the current gdb_stdout.
11142 * thread.c (thr_try_catch_cmd): Likewise.
11143 * top.c (execute_command_to_string): pass term_out parameter
11144 to construct the string_file for the command output.
11145 * ui-file.c (term_cli_styling): New function (most code moved
11146 from utils.c can_emit_style_escape).
11147 (string_file::string_file, string_file::can_emit_style_escape,
11148 stdio_file::can_emit_style_escape, tee_file::term_out,
11149 tee_file::can_emit_style_escape): New functions.
11150
11151 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11152
11153 * NEWS: Mention the new set|show may-call-functions.
11154 * infcall.c (may_call_functions_p): New variable.
11155 (show_may_call_functions_p): New function.
11156 (call_function_by_hand_dummy): Throws an error if not
11157 may-call-functions.
11158 (_initialize_infcall): Call add_setshow_boolean_cmd for
11159 may-call-functions.
11160
11161 2019-04-25 Keith Seitz <keiths@redhat.com>
11162
11163 PR c++/24367
11164 * cp-support.c (inspect_type): Don't attempt substitutions
11165 of symbol with the same name.
11166
11167 2019-04-25 Tom Tromey <tromey@adacore.com>
11168
11169 PR gdb/24475:
11170 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11171 static.
11172
11173 2019-04-25 Tom Tromey <tromey@adacore.com>
11174
11175 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11176 rvalue reference.
11177 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11178 (gdb_xml_parser::parse): Use std::move.
11179 * python/python-internal.h (gdbpy_convert_exception): Take a const
11180 reference.
11181 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11182 std::move.
11183 * python/py-utils.c (gdbpy_convert_exception): Take a const
11184 reference.
11185 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11186 Use std::move.
11187 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11188 Use std::move.
11189 * mi/mi-main.c (mi_print_exception): Take a const reference.
11190 * main.c (handle_command_errors): Take a const reference.
11191 * linespec.c (parse_linespec): Use std::move.
11192 * infcall.c (run_inferior_call): Use std::move.
11193 (call_function_by_hand_dummy): Use std::move.
11194 * exec.c (try_open_exec_file): Use std::move.
11195 * exceptions.h (exception_print, exception_fprintf)
11196 (exception_print_same): Update.
11197 * exceptions.c (print_exception, exception_print)
11198 (exception_fprintf, exception_print_same): Change parameters to
11199 const reference.
11200 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11201 * common/new-op.c: Use std::move.
11202 * common/common-exceptions.h (struct gdb_exception): Add move
11203 constructor.
11204 (struct gdb_exception_error, struct gdb_exception_quit, struct
11205 gdb_quit_bad_alloc): Change constructor to move constructor.
11206 (throw_exception): Change parameter to rvalue reference.
11207 * common/common-exceptions.c (throw_exception): Take rvalue
11208 reference.
11209 * cli/cli-interp.c (safe_execute_command): Use std::move.
11210 * breakpoint.c (insert_bp_location, location_to_sals): Use
11211 std::move.
11212
11213 2019-04-25 Tom Tromey <tromey@adacore.com>
11214
11215 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11216 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11217 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11218 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11219 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11220 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11221 guile/scm-value.c: Use unpack.
11222 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11223 gdbscm_gdb_exception.
11224 (gdbscm_throw_gdb_exception): Likewise.
11225 (struct gdbscm_gdb_exception): New.
11226 (unpack): New function.
11227 (gdbscm_wrap): Use unpack.
11228
11229 2019-04-25 Tom Tromey <tromey@adacore.com>
11230
11231 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11232 (gdb_rl_callback_handler): Use std::move.
11233 * common/common-exceptions.h (struct gdb_exception): Add move
11234 assignment operator.
11235 (throw_exception_sjlj): Change "exception" to const reference.
11236 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11237 (throw_exception_sjlj): Change "exception" to const reference.
11238
11239 2019-04-25 Tom Tromey <tromey@adacore.com>
11240
11241 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11242 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11243 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11244 Update.
11245 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11246 Update.
11247 * mi/mi-interp.c (mi_interp::exec): Update.
11248 * linespec.c (parse_linespec): Update.
11249 * infcall.c (run_inferior_call): Update.
11250 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11251 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11252 (gdbscm_lookup_global_symbol): Update.
11253 * guile/scm-param.c (gdbscm_parameter_value): Update.
11254 * guile/scm-frame.c (gdbscm_frame_read_register)
11255 (gdbscm_frame_read_var): Update.
11256 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11257 * exec.c (try_open_exec_file): Update.
11258 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11259 (gdb_rl_callback_handler): Update.
11260 * common/common-exceptions.h (exception_none): Don't declare.
11261 * common/common-exceptions.c (exception_none): Don't define.
11262 (struct catcher) <exception>: Update.
11263 * cli/cli-interp.c (safe_execute_command): Update.
11264 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11265
11266 2019-04-25 Ali Tamur <tamur@google.com>
11267
11268 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11269 (read_attribute_value): Likewise.
11270 (dwarf2_read_addr_index): Update comment.
11271 (read_str_index): Add DW_FORM_strx.
11272 (dwarf2_string_attr): Likewise.
11273 (dwarf2_const_value_attr): Likewise.
11274 (dump_die_shallow): Likewise.
11275 (dwarf2_fetch_constant_bytes): Likewise.
11276 (skip_form_bytes): Likewise.
11277 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11278
11279 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11280
11281 PR corefiles/11608
11282 PR corefiles/18187
11283 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11284 OFFSET. Verify if current mapping contains an ELF header.
11285 (linux_find_memory_regions_full): Adjust call to
11286 dump_mapping_p.
11287
11288 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11289 Kang Li <kanglictf@gmail.com>
11290
11291 PR gdb/21600
11292
11293 * dwarf2-frame.c (read_initial_length): Be consistent about using
11294 unsigned representation of length.
11295 (decode_frame_entry_1): Likewise. Check for wraparound of
11296 end pointer as well as buffer overflow.
11297
11298 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11299
11300 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11301 "vq".
11302
11303 2019-04-24 Tom Tromey <tromey@adacore.com>
11304
11305 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11306
11307 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11308
11309 * s12z-tdep.c (s12z_unwind_pc): Delete.
11310 (s12z_unwind_sp): Delete.
11311 (s12z_gdbarch_init): Don't register deleted functions with
11312 gdbarch.
11313
11314 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11315
11316 * rl78-tdep.c (rl78_unwind_sp): Delete.
11317 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11318
11319 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11320
11321 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11322 (xstormy16_unwind_pc): Delete.
11323 (xstormy16_dummy_id): Delete.
11324 (xstormy16_gdbarch_init): Don't register deleted functions with
11325 gdbarch.
11326
11327 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11328
11329 * vax-tdep.c (vax_unwind_pc): Delete.
11330 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11331
11332 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11333
11334 * v850-tdep.c (v850_unwind_sp): Delete.
11335 (v850_unwind_pc): Delete.
11336 (v850_dummy_id): Delete.
11337 (v850_gdbarch_init): Don't register deleted functions with
11338 gdbarch.
11339
11340 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11341
11342 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11343 (tilegx_unwind_pc): Delete.
11344 (tilegx_unwind_dummy_id): Delete.
11345 (tilegx_gdbarch_init): Don't register deleted functions with
11346 gdbarch.
11347
11348 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11349
11350 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11351 (tic6x_dummy_id): Delete.
11352 (tic6x_gdbarch_init): Don't register deleted functions with
11353 gdbarch.
11354
11355 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11356
11357 * sparc-tdep.c (sparc_unwind_pc): Delete.
11358 (sparc32_gdbarch_init): Don't register deleted function with
11359 gdbarch.
11360
11361 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11362
11363 * sh-tdep.c (sh_unwind_sp): Delete.
11364 (sh_unwind_pc): Delete.
11365 (sh_dummy_id): Delete.
11366 (sh_gdbarch_init): Don't register deleted functions with
11367 gdbarch.
11368
11369 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11370
11371 * score-tdep.c (score_unwind_sp): Delete.
11372 (score_unwind_pc): Delete.
11373 (score_dummy_id): Delete.
11374 (score_gdbarch_init): Don't register deleted functions with
11375 gdbarch.
11376
11377 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11378
11379 * rx-tdep.c (rx_unwind_pc): Delete.
11380 (rx_unwind_sp): Delete.
11381 (rx_dummy_id): Delete.
11382 (rx_gdbarch_init): Don't register deleted functions with
11383 gdbarch. Update comment.
11384
11385 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11386
11387 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11388 (rs6000_dummy_id): Delete.
11389 (rs6000_gdbarch_init): Don't register deleted functions with
11390 gdbarch.
11391
11392 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11393
11394 * or1k-tdep.c (or1k_dummy_id): Delete.
11395 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11396
11397 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11398
11399 * nios2-tdep.c (nios2_dummy_id): Delete.
11400 (nios2_unwind_sp): Delete.
11401 (nios2_gdbarch_init): Don't register deleted functions with
11402 gdbarch.
11403
11404 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11405
11406 * nds32-tdep.c (nds32_dummy_id): Delete.
11407 (nds32_unwind_pc): Delete.
11408 (nds32_unwind_sp): Delete.
11409 (nds32_gdbarch_init): Don't register deleted functions with
11410 gdbarch.
11411
11412 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11413
11414 * msp430-tdep.c (msp430_unwind_pc): Delete.
11415 (msp430_unwind_sp): Delete.
11416 (msp430_dummy_id): Delete.
11417 (msp430_gdbarch_init): Don't register deleted functions with
11418 gdbarch.
11419
11420 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11421
11422 * moxie-tdep.c (moxie_unwind_sp): Delete.
11423 (moxie_unwind_pc): Delete.
11424 (moxie_dummy_id): Delete.
11425 (moxie_gdbarch_init): Don't register deleted functions with
11426 gdbarch.
11427
11428 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11429
11430 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11431 (mn10300_unwind_pc): Delete.
11432 (mn10300_unwind_sp): Delete.
11433 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11434 mn10300_unwind_sp.
11435 (mn10300_frame_unwind_init): Don't register deleted functions with
11436 gdbarch.
11437
11438 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11439
11440 * mep-tdep.c (mep_unwind_pc): Delete.
11441 (mep_unwind_sp): Delete.
11442 (mep_dummy_id): Delete.
11443 (mep_gdbarch_init): Don't register deleted functions with
11444 gdbarch.
11445
11446 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11447
11448 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11449 (m68hc11_unwind_sp): Delete.
11450 (m68hc11_gdbarch_init): Don't register deleted functions with
11451 gdbarch.
11452
11453 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11454
11455 * m32r-tdep.c (m32r_unwind_sp): Delete.
11456 (m32r_unwind_pc): Delete.
11457 (m32r_dummy_id): Delete.
11458 (m32r_gdbarch_init): Don't register deleted functions with
11459 gdbarch.
11460
11461 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11462
11463 * m32c-tdep.c (m32c_unwind_pc): Delete.
11464 (m32c_unwind_sp): Delete.
11465 (m32c_dummy_id): Delete.
11466 (m32c_gdbarch_init): Don't register deleted functions with
11467 gdbarch.
11468
11469 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11470
11471 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11472 (lm32_unwind_pc): Delete.
11473 (lm32_dummy_id): Delete.
11474 (lm32_gdbarch_init): Don't register deleted functions with
11475 gdbarch.
11476
11477 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11478
11479 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11480 (iq2000_unwind_pc): Delete.
11481 (iq2000_dummy_id): Delete.
11482 (iq2000_gdbarch_init): Don't register deleted functions with
11483 gdbarch.
11484
11485 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11486
11487 * nds32-tdep.c (nds32_type_align): Delete.
11488 (nds32_push_dummy_call): Use type_align instead.
11489
11490 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11491
11492 * arm-tdep.c (arm_type_align): Only handle vector override case.
11493 (arm_push_dummy_call): Use type_align.
11494 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11495
11496 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11497
11498 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11499 case.
11500 (pass_on_stack): Use type_align.
11501 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11502 function.
11503
11504 2019-04-23 Tom Tromey <tromey@adacore.com>
11505
11506 * dwarf2read.c (line_header::file_name_at): Remove unused
11507 overload.
11508
11509 2019-04-23 Tom de Vries <tdevries@suse.de>
11510
11511 PR gdb/24438
11512 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11513 invocation.
11514
11515
11516 2019-03-27 Ali Tamur <tamur@google.com>
11517
11518 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11519 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11520 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11521 (dwarf_expr_context::get_addr_index): Likewise
11522 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11523 (symbol_needs_eval_context::get_addr_index): Likewise
11524 (disassemble_dwarf_expression): Add DW_OP_addrx
11525 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11526 (read_cutu_die_from_dwo): Update comment
11527 (skip_one_die): Add DW_FORM_addrx
11528 (read_attribute_value): Likewise
11529 (var_decode_location): Add DW_OP_addrx
11530 (dwarf2_const_value_attr): Add DW_FORM_addrx
11531 (dump_die_shallow): Likewise
11532 (dwarf2_fetch_constant_bytes): Likewise
11533 (decode_locdesc): Add DW_OP_addrx
11534 (skip_form_bytes): Add DW_FORM_addrx
11535
11536 2019-04-22 Ali Tamur <tamur@google.com>
11537
11538 * MAINTAINERS (Write After Approval): Add self.
11539
11540 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11541
11542 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11543 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11544 (open_symbol_file_object): Likewise.
11545 (svr4_default_sos): Add info parameter.
11546 (svr4_read_so_list): Likewise.
11547 (svr4_current_sos_direct): Adjust functions calls to pass down
11548 info.
11549 (svr4_current_sos_1): Add info parameter.
11550 (svr4_current_sos): Call get_svr4_info, pass info down to
11551 svr4_current_sos_1.
11552 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11553 get_svr4_info.
11554 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11555 get_svr4_info.
11556 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11557 to get_svr4_info.
11558 (probes_table_remove_objfile_probes): Likewise.
11559 (register_solib_event_probe): Add info parameter.
11560 (solist_update_incremental): Pass info parameter down to
11561 svr4_read_so_list.
11562 (disable_probes_interface): Add info parameter.
11563 (svr4_handle_solib_event): Pass current_program_space to
11564 get_svr4_info. Adjust disable_probes_interface cleanup.
11565 (svr4_create_probe_breakpoints): Add info parameter, pass it
11566 down to register_solib_event_probe.
11567 (svr4_create_solib_event_breakpoints): Add info parameter,
11568 pass it down to svr4_create_probe_breakpoints.
11569 (enable_break): Pass info down to
11570 svr4_create_solib_event_breakpoints.
11571 (svr4_solib_create_inferior_hook): Pass current_program_space to
11572 get_svr4_info.
11573 (svr4_clear_solib): Likewise.
11574
11575 2019-04-22 Pedro Alves <palves@redhat.com>
11576
11577 * solib-svr4.c (svr4_free_objfile_observer): New.
11578 (probe_and_action::objfile): New field.
11579 (probes_table_htab_remove_objfile_probes)
11580 (probes_table_remove_objfile_probes): New functions.
11581 (register_solib_event_probe): Add 'objfile' parameter. Store it
11582 in the new probe_and_action. Don't store the probe in 'lookup'.
11583 (svr4_create_probe_breakpoints): Pass objfile to
11584 register_solib_event_probe.
11585 (_initialize_svr4_solib): Register a free_objfile observer.
11586
11587 2019-04-19 Tom Tromey <tom@tromey.com>
11588
11589 * common/queue.h: Remove.
11590
11591 2019-04-19 Tom Tromey <tom@tromey.com>
11592
11593 * event-loop.c: Don't include "common/queue.h".
11594
11595 2019-04-19 Tom Tromey <tom@tromey.com>
11596
11597 * remote.c (remote_target): Use delete.
11598 * remote-notif.h: Include <list>, not "common/queue.h".
11599 (notif_client_p): Remove typedef.
11600 (remote_notif_state): Add constructor, destructor, initializer.
11601 <notif_queue>: Now a std::list.
11602 (remote_notif_state_xfree): Don't declare.
11603 * remote-notif.c (remote_notif_process, handle_notification)
11604 (remote_notif_state_allocate): Update.
11605 (~remote_notif_state): Rename from remote_notif_state_xfree.
11606
11607 2019-04-19 Tom Tromey <tom@tromey.com>
11608
11609 * symfile.c (reread_symbols): Update.
11610 * objfiles.c (objfile_register_static_link)
11611 (objfile_lookup_static_link): Update
11612 (~objfile) Don't delete static_links.
11613 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11614
11615 2019-04-19 Tom Tromey <tom@tromey.com>
11616
11617 * type-stack.h (struct type_stack) <insert>: Constify string.
11618 * type-stack.c (type_stack::insert): Constify string.
11619 * gdbtypes.h (lookup_template_type): Update.
11620 (address_space_name_to_int): Update.
11621 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11622 const.
11623 (lookup_template_type): Make name const.
11624 * c-exp.y: Update rules.
11625 (lex_one_token, classify_name, classify_inner_name)
11626 (c_print_token): Update.
11627 * p-exp.y: Update rules.
11628 (yylex): Update.
11629 * f-exp.y: Update rules.
11630 (yylex): Update.
11631 * d-exp.y: Update rules.
11632 (lex_one_token, classify_name, classify_inner_name): Update.
11633 * parse.c (write_dollar_variable, copy_name): Return std::string.
11634 * parser-defs.h (copy_name): Change return type.
11635 * m2-exp.y: Update rules.
11636 (yylex): Update.
11637 * go-exp.y (lex_one_token): Update.
11638 Update rules.
11639 (classify_unsafe_function, classify_packaged_name)
11640 (classify_name, yylex): Update.
11641
11642 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11643
11644 * configure.ac: add --enable-source-highlight switch.
11645 * configure: Regenerate.
11646 * top.c (print_gdb_version): plumb --enable-source-highlight
11647 status to "show configuration".
11648
11649 2019-04-19 Tom Tromey <tromey@adacore.com>
11650
11651 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11652 Check ADA_TYPE_P.
11653 (empty_record, ada_template_to_fixed_record_type_1)
11654 (template_to_static_fixed_type)
11655 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11656 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11657 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11658 macros.
11659
11660 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11661
11662 PR symtab/24423:
11663 * source.c (print_source_lines_base): Advance "iter" when a
11664 control character is seen.
11665
11666 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11667
11668 * inferior.h (struct infcall_suspend_state_deleter):
11669 Catch exception in destructor to avoid crash.
11670
11671 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11672
11673 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11674 close to the add_com "shell".
11675
11676 2019-04-18 Tom Tromey <tromey@adacore.com>
11677
11678 * process-stratum-target.h (class process_stratum_target)
11679 <stratum>: Add "final".
11680
11681 2019-04-17 Tom Tromey <tromey@adacore.com>
11682
11683 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11684 against nullptr before use.
11685
11686 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11687
11688 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11689
11690 2019-04-17 Jim Wilson <jimw@sifive.com>
11691 Andrew Burgess <andrew.burgess@embecosm.com>
11692
11693 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11694 code read might fail, assume 4-byte breakpoint in that case.
11695
11696 2019-04-15 Leszek Swirski <leszeks@google.com>
11697
11698 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11699 rather than a hand-rolled POD check when checking for forced MEMORY
11700 classification.
11701
11702 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11703
11704 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11705 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11706 function.
11707 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11708 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11709 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11710 declaration.
11711
11712 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11713
11714 * aarch64-linux-nat.c
11715 (aarch64_linux_nat_target::thread_architecture): Add override.
11716 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11717 each VQ.
11718
11719 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11720
11721 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11722
11723 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11724
11725 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11726 target types of size 96-bits, add some additional comments, and
11727 check that the builtin type we found was the correct size.
11728
11729 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11730
11731 * utils.c (prompt_for_continue): Don't restore the styling at the
11732 end, as applied_style has the wrong value. This fixes styling in
11733 long lists of file names that are interrupted by the "Continue?"
11734 prompt.
11735
11736 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11737
11738 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11739 * c-lang.c (c_language_defn): Likewise.
11740 (cplus_language_defn): Likewise.
11741 (asm_language_defn): Likewise.
11742 (minimal_language_defn): Likewise.
11743 * d-lang.c (d_language_defn): Likewise.
11744 * f-lang.c (f_language_defn): Likewise.
11745 * go-lang.c (go_language_defn): Likewise.
11746 * language.c (unknown_language_defn): Likewise.
11747 (auto_language_defn): Likewise.
11748 * language.h (struct language_defn): Remove la_magic field.
11749 (LANG_MAGIC): Delete.
11750 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11751 * objc-lang.c (objc_language_defn): Likewise.
11752 * opencl-lang.c (opencl_language_defn): Likewise.
11753 * p-lang.c (pascal_language_defn): Likewise.
11754 * rust-lang.c (rust_language_defn): Likewise.
11755
11756 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11757
11758 * riscv-tdep.c (riscv_type_align): New function.
11759 (riscv_type_alignment): Delete.
11760 (riscv_arg_location): Use 'type_align'.
11761 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11762
11763 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11764
11765 * gdbtypes.c (type_align): A struct with no non-static fields also
11766 has alignment of 1.
11767
11768 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11769
11770 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11771 component to 0.
11772 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11773 member.
11774 (riscv_struct_info::analyse): New implementation using new
11775 analyse_inner member function.
11776 (riscv_struct_info::field_offset): New member function.
11777 (riscv_struct_info::m_offsets): New member variable.
11778 (riscv_struct_info::analyse_inner): New private member function,
11779 takes the old implementation of riscv_struct_info::analyse but
11780 extended to track field offsets.
11781 (riscv_call_arg_struct): Update the struct folding special cases
11782 to handle cases where empty C++ structs, which are non-zero
11783 length, are found.
11784 (riscv_arg_location): Initialise the length of each location, a
11785 non-zero length now indicates the location is in use.
11786 (riscv_push_dummy_call): Allow for the first location having a
11787 non-zero offset when setting up arguments.
11788 (riscv_return_value): Likewise, but for return values.
11789
11790 2019-04-11 Tom Tromey <tromey@adacore.com>
11791
11792 * utils.c (internal_vproblem): Make "msg" const.
11793
11794 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11795
11796 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11797 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11798 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11799 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11800
11801 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11802
11803 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11804 function.
11805 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11806 of amd64_collect_native_gregset.
11807 (amd64_linux_nat_target::store_registers): Likewise.
11808
11809 2019-04-10 Tom Tromey <tom@tromey.com>
11810
11811 * symtab.c (lookup_global_symbol_from_objfile)
11812 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11813 * objfiles.h (class separate_debug_iterator): New.
11814 (class separate_debug_range): New.
11815 (struct objfile) <separate_debug_objfiles>: New method.
11816 (objfile_separate_debug_iterate): Don't declare.
11817 * objfiles.c (separate_debug_iterator::operator++): Rename from
11818 objfile_separate_debug_iterate.
11819 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11820 iterator.
11821 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11822 iterator.
11823
11824 2019-04-10 Tom Tromey <tom@tromey.com>
11825
11826 * symfile.c (reread_symbols): Remove old comment.
11827 * objfiles.c (free_all_objfiles): Fix a typo.
11828
11829 2019-04-10 Tom Tromey <tom@tromey.com>
11830
11831 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11832 * minsyms.c (lookup_minimal_symbol): Use foreach.
11833 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11834 (lookup_minimal_symbol_solib_trampoline): Likewise.
11835 * symfile.c (reread_symbols): Use foreach.
11836
11837 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11838 Tom Tromey <tromey@adacore.com>
11839
11840 PR rust/24414:
11841 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11842 (rust_lex_int_test): Change "value" to be LONGEST.
11843 (rust_lex_tests): Add test for long integer literal.
11844
11845 2019-04-09 Tom Tromey <tromey@adacore.com>
11846
11847 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11848 to bool.
11849 (extended_remote_target::attach): Update.
11850 (remote_target::remote_notice_new_inferior): Update.
11851 (remote_target::add_current_inferior_and_thread): Update.
11852 * inferior.c (exit_inferior_1): Use "false".
11853 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11854
11855 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11856
11857 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11858 the "start" command.
11859
11860 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11861
11862 * python/py-inferior.c (infpy_thread_from_thread_handle):
11863 Adjust comments to reflect renaming of thread_from_thread_handle
11864 to thread_from_handle. Adjust keywords. Fix type error message.
11865 (inferior_object_methods): Add thread_from_handle. Retain
11866 thread_from_thread_handle, but mark it as deprecated.
11867
11868 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11869
11870 * gdbthread.h (find_thread_by_handle): Revise declaration.
11871 * thread.c (find_thread_by_handle): Likewise. Adjust
11872 implementation too.
11873 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11874 support for buffer objects as handles.
11875
11876 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11877
11878 * python/py-infthread.c (thpy_thread_handle): New function.
11879 (thread_object_methods): Register thpy_thread_handle.
11880
11881 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11882
11883 * gdbthread.h (thread_to_thread_handle): Declare.
11884 * thread.c (gdbtypes.h): Include.
11885 (thread_to_thread_handle): New function.
11886
11887 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11888 (target_thread_info_to_thread_handle): Declare.
11889 * target.c (target_thread_info_to_thread_handle): New function.
11890 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11891 * target-delegates.c: Regenerate.
11892
11893 * linux-thread-db.c (class thread_db_target): Add method
11894 thread_info_to_thread_handle.
11895 (thread_db_target::thread_info_to_thread_handle): Define.
11896 * remote.c (class remote_target): Add new method
11897 thread_info_to_thread_handle.
11898 (remote_target::thread_info_to_thread_handle): Define.
11899
11900 2019-04-08 Pedro Alves <palves@redhat.com>
11901
11902 * common/common-exceptions.c (throw_exception): Don't create
11903 named object to throw; throw directly.
11904 (throw_it): Likewise. Don't initialize gdb_exception::message
11905 here, with new; pass FMT and AP to the ctor instead.
11906 * common/common-exceptions.h: Include <string>.
11907 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11908 const char *, va_list)): New ctor. Use std::make_shared.
11909 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11910 errors)): Delete.
11911 (gdb_exception_error::gdb_exception_error(enum errors, const char
11912 *, va_list)): New.
11913 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11914 Add assertion.
11915 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11916 errors)): Delete.
11917 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11918 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11919 Add assertion.
11920
11921 2019-04-08 Tom Tromey <tom@tromey.com>
11922
11923 * valops.c (value_rtti_indirect_type): Replace throw_exception
11924 with throw.
11925 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11926 with throw.
11927 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11928 throw.
11929 * target.c (target_translate_tls_address): Replace throw_exception
11930 with throw.
11931 * stack.c (frame_apply_command_count): Replace throw_exception
11932 with throw.
11933 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11934 throw.
11935 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11936 with throw.
11937 * rs6000-tdep.c (rs6000_frame_cache)
11938 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11939 * remote.c: Replace throw_exception with throw.
11940 * record-full.c (record_full_message, record_full_wait_1)
11941 (record_full_restore): Replace throw_exception with throw.
11942 * record-btrace.c:
11943 (get_thread_current_frame_id, record_btrace_start_replaying)
11944 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11945 (cmd_record_btrace_start): Replace throw_exception with throw.
11946 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11947 throw.
11948 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11949 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11950 * linespec.c:
11951 (find_linespec_symbols): Replace throw_exception with throw.
11952 * infrun.c (displaced_step_prepare, resume): Replace
11953 throw_exception with throw.
11954 * infcmd.c (post_create_inferior): Replace throw_exception with
11955 throw.
11956 * inf-loop.c (inferior_event_handler): Replace throw_exception
11957 with throw.
11958 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11959 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11960 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11961 (get_prev_frame_always, get_frame_pc_if_available)
11962 (get_frame_address_in_block_if_available, get_frame_language):
11963 Replace throw_exception with throw.
11964 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11965 throw_exception with throw.
11966 * eval.c (fetch_subexp_value, evaluate_var_value)
11967 (evaluate_funcall, evaluate_subexp_standard): Replace
11968 throw_exception with throw.
11969 * dwarf2loc.c (call_site_find_chain)
11970 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11971 Replace throw_exception with throw.
11972 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11973 with throw.
11974 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11975 throw.
11976 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11977 * completer.c (complete_line_internal): Replace throw_exception
11978 with throw.
11979 * compile/compile-object-run.c (compile_object_run): Replace
11980 throw_exception with throw.
11981 * cli/cli-script.c (process_next_line): Replace throw_exception
11982 with throw.
11983 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11984 (btrace_enable, btrace_maint_update_pt_packets): Replace
11985 throw_exception with throw.
11986 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11987 throw_exception with throw.
11988 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11989 throw_exception with throw.
11990 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11991 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11992 * aarch64-tdep.c (aarch64_make_prologue_cache)
11993 (aarch64_make_stub_cache): Replace throw_exception with throw.
11994
11995 2019-04-08 Tom Tromey <tom@tromey.com>
11996
11997 * common/common-exceptions.c (throw_exception): Rename from
11998 throw_exception_cxx. Remove old copy. Make argument const.
11999 (throw_it): Create and throw exception objects directly.
12000 * common/common-exceptions.h (throw_exception): Make argument
12001 const.
12002 (struct gdb_exception_error): Add constructor.
12003 (struct gdb_exception_quit): Add constructor.
12004
12005 2019-04-08 Tom Tromey <tom@tromey.com>
12006
12007 * common/common-exceptions.h (exception_rethrow): Don't declare.
12008 (TRY_SJLJ): Update comment.
12009 (TRY, CATCH, END_CATCH): Remove.
12010 * common/common-exceptions.c (exception_rethrow): Remove.
12011
12012 2019-04-08 Tom Tromey <tom@tromey.com>
12013
12014 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12015 Remove.
12016 (gdb_exception_error): Rename from
12017 gdb_exception_RETURN_MASK_ERROR.
12018 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12019 (gdb_quit_bad_alloc): Update.
12020 * aarch64-tdep.c: Update.
12021 * ada-lang.c: Update.
12022 * ada-typeprint.c: Update.
12023 * ada-valprint.c: Update.
12024 * amd64-tdep.c: Update.
12025 * arch-utils.c: Update.
12026 * break-catch-throw.c: Update.
12027 * breakpoint.c: Update.
12028 * btrace.c: Update.
12029 * c-varobj.c: Update.
12030 * cli/cli-cmds.c: Update.
12031 * cli/cli-interp.c: Update.
12032 * cli/cli-script.c: Update.
12033 * common/common-exceptions.c: Update.
12034 * common/new-op.c: Update.
12035 * common/selftest.c: Update.
12036 * compile/compile-c-symbols.c: Update.
12037 * compile/compile-cplus-symbols.c: Update.
12038 * compile/compile-object-load.c: Update.
12039 * compile/compile-object-run.c: Update.
12040 * completer.c: Update.
12041 * corelow.c: Update.
12042 * cp-abi.c: Update.
12043 * cp-support.c: Update.
12044 * cp-valprint.c: Update.
12045 * darwin-nat.c: Update.
12046 * disasm-selftests.c: Update.
12047 * dtrace-probe.c: Update.
12048 * dwarf-index-cache.c: Update.
12049 * dwarf-index-write.c: Update.
12050 * dwarf2-frame-tailcall.c: Update.
12051 * dwarf2-frame.c: Update.
12052 * dwarf2loc.c: Update.
12053 * dwarf2read.c: Update.
12054 * eval.c: Update.
12055 * event-loop.c: Update.
12056 * event-top.c: Update.
12057 * exec.c: Update.
12058 * f-valprint.c: Update.
12059 * fbsd-tdep.c: Update.
12060 * frame-unwind.c: Update.
12061 * frame.c: Update.
12062 * gdbtypes.c: Update.
12063 * gnu-v3-abi.c: Update.
12064 * guile/guile-internal.h: Update.
12065 * guile/scm-block.c: Update.
12066 * guile/scm-breakpoint.c: Update.
12067 * guile/scm-cmd.c: Update.
12068 * guile/scm-disasm.c: Update.
12069 * guile/scm-frame.c: Update.
12070 * guile/scm-lazy-string.c: Update.
12071 * guile/scm-math.c: Update.
12072 * guile/scm-param.c: Update.
12073 * guile/scm-ports.c: Update.
12074 * guile/scm-pretty-print.c: Update.
12075 * guile/scm-symbol.c: Update.
12076 * guile/scm-symtab.c: Update.
12077 * guile/scm-type.c: Update.
12078 * guile/scm-value.c: Update.
12079 * i386-linux-tdep.c: Update.
12080 * i386-tdep.c: Update.
12081 * inf-loop.c: Update.
12082 * infcall.c: Update.
12083 * infcmd.c: Update.
12084 * infrun.c: Update.
12085 * jit.c: Update.
12086 * language.c: Update.
12087 * linespec.c: Update.
12088 * linux-fork.c: Update.
12089 * linux-nat.c: Update.
12090 * linux-tdep.c: Update.
12091 * linux-thread-db.c: Update.
12092 * main.c: Update.
12093 * mi/mi-cmd-break.c: Update.
12094 * mi/mi-cmd-stack.c: Update.
12095 * mi/mi-interp.c: Update.
12096 * mi/mi-main.c: Update.
12097 * objc-lang.c: Update.
12098 * p-valprint.c: Update.
12099 * parse.c: Update.
12100 * ppc-linux-tdep.c: Update.
12101 * printcmd.c: Update.
12102 * python/py-arch.c: Update.
12103 * python/py-breakpoint.c: Update.
12104 * python/py-cmd.c: Update.
12105 * python/py-finishbreakpoint.c: Update.
12106 * python/py-frame.c: Update.
12107 * python/py-framefilter.c: Update.
12108 * python/py-gdb-readline.c: Update.
12109 * python/py-inferior.c: Update.
12110 * python/py-infthread.c: Update.
12111 * python/py-lazy-string.c: Update.
12112 * python/py-linetable.c: Update.
12113 * python/py-objfile.c: Update.
12114 * python/py-param.c: Update.
12115 * python/py-prettyprint.c: Update.
12116 * python/py-progspace.c: Update.
12117 * python/py-record-btrace.c: Update.
12118 * python/py-record.c: Update.
12119 * python/py-symbol.c: Update.
12120 * python/py-type.c: Update.
12121 * python/py-unwind.c: Update.
12122 * python/py-utils.c: Update.
12123 * python/py-value.c: Update.
12124 * python/python.c: Update.
12125 * record-btrace.c: Update.
12126 * record-full.c: Update.
12127 * remote-fileio.c: Update.
12128 * remote.c: Update.
12129 * riscv-tdep.c: Update.
12130 * rs6000-aix-tdep.c: Update.
12131 * rs6000-tdep.c: Update.
12132 * rust-exp.y: Update.
12133 * rust-lang.c: Update.
12134 * s390-tdep.c: Update.
12135 * selftest-arch.c: Update.
12136 * solib-dsbt.c: Update.
12137 * solib-frv.c: Update.
12138 * solib-spu.c: Update.
12139 * solib-svr4.c: Update.
12140 * solib.c: Update.
12141 * sparc64-linux-tdep.c: Update.
12142 * stack.c: Update.
12143 * symfile-mem.c: Update.
12144 * symmisc.c: Update.
12145 * target.c: Update.
12146 * thread.c: Update.
12147 * top.c: Update.
12148 * tracefile-tfile.c: Update.
12149 * tui/tui.c: Update.
12150 * typeprint.c: Update.
12151 * unittests/cli-utils-selftests.c: Update.
12152 * unittests/parse-connection-spec-selftests.c: Update.
12153 * valops.c: Update.
12154 * valprint.c: Update.
12155 * value.c: Update.
12156 * varobj.c: Update.
12157 * windows-nat.c: Update.
12158 * x86-linux-nat.c: Update.
12159 * xml-support.c: Update.
12160
12161 2019-04-08 Tom Tromey <tom@tromey.com>
12162
12163 * xml-support.c: Use C++ exception handling.
12164 * x86-linux-nat.c: Use C++ exception handling.
12165 * windows-nat.c: Use C++ exception handling.
12166 * varobj.c: Use C++ exception handling.
12167 * value.c: Use C++ exception handling.
12168 * valprint.c: Use C++ exception handling.
12169 * valops.c: Use C++ exception handling.
12170 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12171 handling.
12172 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12173 * typeprint.c: Use C++ exception handling.
12174 * tui/tui.c: Use C++ exception handling.
12175 * tracefile-tfile.c: Use C++ exception handling.
12176 * top.c: Use C++ exception handling.
12177 * thread.c: Use C++ exception handling.
12178 * target.c: Use C++ exception handling.
12179 * symmisc.c: Use C++ exception handling.
12180 * symfile-mem.c: Use C++ exception handling.
12181 * stack.c: Use C++ exception handling.
12182 * sparc64-linux-tdep.c: Use C++ exception handling.
12183 * solib.c: Use C++ exception handling.
12184 * solib-svr4.c: Use C++ exception handling.
12185 * solib-spu.c: Use C++ exception handling.
12186 * solib-frv.c: Use C++ exception handling.
12187 * solib-dsbt.c: Use C++ exception handling.
12188 * selftest-arch.c: Use C++ exception handling.
12189 * s390-tdep.c: Use C++ exception handling.
12190 * rust-lang.c: Use C++ exception handling.
12191 * rust-exp.y: Use C++ exception handling.
12192 * rs6000-tdep.c: Use C++ exception handling.
12193 * rs6000-aix-tdep.c: Use C++ exception handling.
12194 * riscv-tdep.c: Use C++ exception handling.
12195 * remote.c: Use C++ exception handling.
12196 * remote-fileio.c: Use C++ exception handling.
12197 * record-full.c: Use C++ exception handling.
12198 * record-btrace.c: Use C++ exception handling.
12199 * python/python.c: Use C++ exception handling.
12200 * python/py-value.c: Use C++ exception handling.
12201 * python/py-utils.c: Use C++ exception handling.
12202 * python/py-unwind.c: Use C++ exception handling.
12203 * python/py-type.c: Use C++ exception handling.
12204 * python/py-symbol.c: Use C++ exception handling.
12205 * python/py-record.c: Use C++ exception handling.
12206 * python/py-record-btrace.c: Use C++ exception handling.
12207 * python/py-progspace.c: Use C++ exception handling.
12208 * python/py-prettyprint.c: Use C++ exception handling.
12209 * python/py-param.c: Use C++ exception handling.
12210 * python/py-objfile.c: Use C++ exception handling.
12211 * python/py-linetable.c: Use C++ exception handling.
12212 * python/py-lazy-string.c: Use C++ exception handling.
12213 * python/py-infthread.c: Use C++ exception handling.
12214 * python/py-inferior.c: Use C++ exception handling.
12215 * python/py-gdb-readline.c: Use C++ exception handling.
12216 * python/py-framefilter.c: Use C++ exception handling.
12217 * python/py-frame.c: Use C++ exception handling.
12218 * python/py-finishbreakpoint.c: Use C++ exception handling.
12219 * python/py-cmd.c: Use C++ exception handling.
12220 * python/py-breakpoint.c: Use C++ exception handling.
12221 * python/py-arch.c: Use C++ exception handling.
12222 * printcmd.c: Use C++ exception handling.
12223 * ppc-linux-tdep.c: Use C++ exception handling.
12224 * parse.c: Use C++ exception handling.
12225 * p-valprint.c: Use C++ exception handling.
12226 * objc-lang.c: Use C++ exception handling.
12227 * mi/mi-main.c: Use C++ exception handling.
12228 * mi/mi-interp.c: Use C++ exception handling.
12229 * mi/mi-cmd-stack.c: Use C++ exception handling.
12230 * mi/mi-cmd-break.c: Use C++ exception handling.
12231 * main.c: Use C++ exception handling.
12232 * linux-thread-db.c: Use C++ exception handling.
12233 * linux-tdep.c: Use C++ exception handling.
12234 * linux-nat.c: Use C++ exception handling.
12235 * linux-fork.c: Use C++ exception handling.
12236 * linespec.c: Use C++ exception handling.
12237 * language.c: Use C++ exception handling.
12238 * jit.c: Use C++ exception handling.
12239 * infrun.c: Use C++ exception handling.
12240 * infcmd.c: Use C++ exception handling.
12241 * infcall.c: Use C++ exception handling.
12242 * inf-loop.c: Use C++ exception handling.
12243 * i386-tdep.c: Use C++ exception handling.
12244 * i386-linux-tdep.c: Use C++ exception handling.
12245 * guile/scm-value.c: Use C++ exception handling.
12246 * guile/scm-type.c: Use C++ exception handling.
12247 * guile/scm-symtab.c: Use C++ exception handling.
12248 * guile/scm-symbol.c: Use C++ exception handling.
12249 * guile/scm-pretty-print.c: Use C++ exception handling.
12250 * guile/scm-ports.c: Use C++ exception handling.
12251 * guile/scm-param.c: Use C++ exception handling.
12252 * guile/scm-math.c: Use C++ exception handling.
12253 * guile/scm-lazy-string.c: Use C++ exception handling.
12254 * guile/scm-frame.c: Use C++ exception handling.
12255 * guile/scm-disasm.c: Use C++ exception handling.
12256 * guile/scm-cmd.c: Use C++ exception handling.
12257 * guile/scm-breakpoint.c: Use C++ exception handling.
12258 * guile/scm-block.c: Use C++ exception handling.
12259 * guile/guile-internal.h: Use C++ exception handling.
12260 * gnu-v3-abi.c: Use C++ exception handling.
12261 * gdbtypes.c: Use C++ exception handling.
12262 * frame.c: Use C++ exception handling.
12263 * frame-unwind.c: Use C++ exception handling.
12264 * fbsd-tdep.c: Use C++ exception handling.
12265 * f-valprint.c: Use C++ exception handling.
12266 * exec.c: Use C++ exception handling.
12267 * event-top.c: Use C++ exception handling.
12268 * event-loop.c: Use C++ exception handling.
12269 * eval.c: Use C++ exception handling.
12270 * dwarf2read.c: Use C++ exception handling.
12271 * dwarf2loc.c: Use C++ exception handling.
12272 * dwarf2-frame.c: Use C++ exception handling.
12273 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12274 * dwarf-index-write.c: Use C++ exception handling.
12275 * dwarf-index-cache.c: Use C++ exception handling.
12276 * dtrace-probe.c: Use C++ exception handling.
12277 * disasm-selftests.c: Use C++ exception handling.
12278 * darwin-nat.c: Use C++ exception handling.
12279 * cp-valprint.c: Use C++ exception handling.
12280 * cp-support.c: Use C++ exception handling.
12281 * cp-abi.c: Use C++ exception handling.
12282 * corelow.c: Use C++ exception handling.
12283 * completer.c: Use C++ exception handling.
12284 * compile/compile-object-run.c: Use C++ exception handling.
12285 * compile/compile-object-load.c: Use C++ exception handling.
12286 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12287 * compile/compile-c-symbols.c: Use C++ exception handling.
12288 * common/selftest.c: Use C++ exception handling.
12289 * common/new-op.c: Use C++ exception handling.
12290 * cli/cli-script.c: Use C++ exception handling.
12291 * cli/cli-interp.c: Use C++ exception handling.
12292 * cli/cli-cmds.c: Use C++ exception handling.
12293 * c-varobj.c: Use C++ exception handling.
12294 * btrace.c: Use C++ exception handling.
12295 * breakpoint.c: Use C++ exception handling.
12296 * break-catch-throw.c: Use C++ exception handling.
12297 * arch-utils.c: Use C++ exception handling.
12298 * amd64-tdep.c: Use C++ exception handling.
12299 * ada-valprint.c: Use C++ exception handling.
12300 * ada-typeprint.c: Use C++ exception handling.
12301 * ada-lang.c: Use C++ exception handling.
12302 * aarch64-tdep.c: Use C++ exception handling.
12303
12304 2019-04-08 Tom Tromey <tom@tromey.com>
12305
12306 * xml-support.c (gdb_xml_parser::parse): Update.
12307 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12308 * value.c (show_convenience): Update.
12309 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12310 (test_parse_flags_qcs): Update.
12311 * thread.c (thr_try_catch_cmd): Update.
12312 * target.c (target_translate_tls_address): Update.
12313 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12314 (info_frame_command_core, frame_apply_command_count): Update.
12315 * rust-exp.y (rust_lex_exception_test): Update.
12316 * riscv-tdep.c (riscv_print_one_register_info): Update.
12317 * remote.c (remote_target::enable_btrace): Update.
12318 * record-btrace.c (record_btrace_enable_warn): Update.
12319 * python/py-utils.c (gdbpy_convert_exception): Update.
12320 * printcmd.c (do_one_display, print_variable_and_value): Update.
12321 * mi/mi-main.c (mi_print_exception): Update.
12322 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12323 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12324 * linux-nat.c (linux_nat_target::attach): Update.
12325 * linux-fork.c (class scoped_switch_fork_info): Update.
12326 * infrun.c (displaced_step_prepare): Update.
12327 * infcall.c (call_function_by_hand_dummy): Update.
12328 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12329 * gnu-v3-abi.c (print_one_vtable): Update.
12330 * frame.c (get_prev_frame_always): Update.
12331 * f-valprint.c (info_common_command_for_block): Update.
12332 * exec.c (try_open_exec_file): Update.
12333 * exceptions.c (print_exception, exception_print)
12334 (exception_fprintf, exception_print_same): Update.
12335 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12336 * dwarf-index-cache.c (index_cache::store)
12337 (index_cache::lookup_gdb_index): Update.
12338 * darwin-nat.c (maybe_cache_shell): Update.
12339 * cp-valprint.c (cp_print_value_fields): Update.
12340 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12341 (gcc_cplus_symbol_address): Update.
12342 * compile/compile-c-symbols.c (gcc_convert_symbol)
12343 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12344 * common/selftest.c: Update.
12345 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12346 a std::string.
12347 (exception_try_scope_entry, exception_try_scope_exit): Don't
12348 declare.
12349 (struct exception_try_scope): Remove.
12350 (TRY): Don't use exception_try_scope.
12351 (struct gdb_exception): Add constructor, operator=.
12352 <what>: New method.
12353 (struct gdb_exception_RETURN_MASK_ALL)
12354 (struct gdb_exception_RETURN_MASK_ERROR)
12355 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12356 (struct gdb_quit_bad_alloc): Update.
12357 * common/common-exceptions.c (exception_none): Change
12358 initializer.
12359 (struct catcher) <state, exception>: Initialize inline.
12360 <prev>: Remove member.
12361 (current_catcher): Remove.
12362 (catchers): New global.
12363 (exceptions_state_mc_init): Simplify.
12364 (catcher_pop): Remove.
12365 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12366 (try_scope_depth, exception_try_scope_entry)
12367 (exception_try_scope_exit): Remove.
12368 (throw_exception_sjlj): Update.
12369 (exception_messages, exception_messages_size): Remove.
12370 (throw_it): Simplify.
12371 (gdb_exception_sliced_copy): Remove.
12372 (throw_exception_cxx): Update.
12373 * cli/cli-script.c (script_from_file): Update.
12374 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12375 Update.
12376 * ada-valprint.c (ada_val_print): Update.
12377 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12378 (create_excep_cond_exprs): Update.
12379
12380 2019-04-08 Tom Tromey <tom@tromey.com>
12381
12382 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12383 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12384 (TRY, CATCH, END_CATCH): Remove some definitions.
12385 * common/common-exceptions.c: Don't use GDB_XCPT.
12386 (catcher_list_size): Remove.
12387 (throw_exception, throw_it): Simplify.
12388
12389 2019-04-05 Tom Tromey <tom@tromey.com>
12390
12391 Revert the header-sorting patch.
12392 * ft32-tdep.c: Revert.
12393 * frv-tdep.c: Revert.
12394 * frv-linux-tdep.c: Revert.
12395 * frame.c: Revert.
12396 * frame-unwind.c: Revert.
12397 * frame-base.c: Revert.
12398 * fork-child.c: Revert.
12399 * findvar.c: Revert.
12400 * findcmd.c: Revert.
12401 * filesystem.c: Revert.
12402 * filename-seen-cache.h: Revert.
12403 * filename-seen-cache.c: Revert.
12404 * fbsd-tdep.c: Revert.
12405 * fbsd-nat.h: Revert.
12406 * fbsd-nat.c: Revert.
12407 * f-valprint.c: Revert.
12408 * f-typeprint.c: Revert.
12409 * f-lang.c: Revert.
12410 * extension.h: Revert.
12411 * extension.c: Revert.
12412 * extension-priv.h: Revert.
12413 * expprint.c: Revert.
12414 * exec.h: Revert.
12415 * exec.c: Revert.
12416 * exceptions.c: Revert.
12417 * event-top.c: Revert.
12418 * event-loop.c: Revert.
12419 * eval.c: Revert.
12420 * elfread.c: Revert.
12421 * dwarf2read.h: Revert.
12422 * dwarf2read.c: Revert.
12423 * dwarf2loc.c: Revert.
12424 * dwarf2expr.h: Revert.
12425 * dwarf2expr.c: Revert.
12426 * dwarf2-frame.c: Revert.
12427 * dwarf2-frame-tailcall.c: Revert.
12428 * dwarf-index-write.h: Revert.
12429 * dwarf-index-write.c: Revert.
12430 * dwarf-index-common.c: Revert.
12431 * dwarf-index-cache.h: Revert.
12432 * dwarf-index-cache.c: Revert.
12433 * dummy-frame.c: Revert.
12434 * dtrace-probe.c: Revert.
12435 * disasm.h: Revert.
12436 * disasm.c: Revert.
12437 * disasm-selftests.c: Revert.
12438 * dictionary.c: Revert.
12439 * dicos-tdep.c: Revert.
12440 * demangle.c: Revert.
12441 * dcache.h: Revert.
12442 * dcache.c: Revert.
12443 * darwin-nat.h: Revert.
12444 * darwin-nat.c: Revert.
12445 * darwin-nat-info.c: Revert.
12446 * d-valprint.c: Revert.
12447 * d-namespace.c: Revert.
12448 * d-lang.c: Revert.
12449 * ctf.c: Revert.
12450 * csky-tdep.c: Revert.
12451 * csky-linux-tdep.c: Revert.
12452 * cris-tdep.c: Revert.
12453 * cris-linux-tdep.c: Revert.
12454 * cp-valprint.c: Revert.
12455 * cp-support.c: Revert.
12456 * cp-namespace.c: Revert.
12457 * cp-abi.c: Revert.
12458 * corelow.c: Revert.
12459 * corefile.c: Revert.
12460 * continuations.c: Revert.
12461 * completer.h: Revert.
12462 * completer.c: Revert.
12463 * complaints.c: Revert.
12464 * coffread.c: Revert.
12465 * coff-pe-read.c: Revert.
12466 * cli-out.h: Revert.
12467 * cli-out.c: Revert.
12468 * charset.c: Revert.
12469 * c-varobj.c: Revert.
12470 * c-valprint.c: Revert.
12471 * c-typeprint.c: Revert.
12472 * c-lang.c: Revert.
12473 * buildsym.c: Revert.
12474 * buildsym-legacy.c: Revert.
12475 * build-id.h: Revert.
12476 * build-id.c: Revert.
12477 * btrace.c: Revert.
12478 * bsd-uthread.c: Revert.
12479 * breakpoint.h: Revert.
12480 * breakpoint.c: Revert.
12481 * break-catch-throw.c: Revert.
12482 * break-catch-syscall.c: Revert.
12483 * break-catch-sig.c: Revert.
12484 * blockframe.c: Revert.
12485 * block.c: Revert.
12486 * bfin-tdep.c: Revert.
12487 * bfin-linux-tdep.c: Revert.
12488 * bfd-target.c: Revert.
12489 * bcache.c: Revert.
12490 * ax-general.c: Revert.
12491 * ax-gdb.h: Revert.
12492 * ax-gdb.c: Revert.
12493 * avr-tdep.c: Revert.
12494 * auxv.c: Revert.
12495 * auto-load.c: Revert.
12496 * arm-wince-tdep.c: Revert.
12497 * arm-tdep.c: Revert.
12498 * arm-symbian-tdep.c: Revert.
12499 * arm-pikeos-tdep.c: Revert.
12500 * arm-obsd-tdep.c: Revert.
12501 * arm-nbsd-tdep.c: Revert.
12502 * arm-nbsd-nat.c: Revert.
12503 * arm-linux-tdep.c: Revert.
12504 * arm-linux-nat.c: Revert.
12505 * arm-fbsd-tdep.c: Revert.
12506 * arm-fbsd-nat.c: Revert.
12507 * arm-bsd-tdep.c: Revert.
12508 * arch-utils.c: Revert.
12509 * arc-tdep.c: Revert.
12510 * arc-newlib-tdep.c: Revert.
12511 * annotate.h: Revert.
12512 * annotate.c: Revert.
12513 * amd64-windows-tdep.c: Revert.
12514 * amd64-windows-nat.c: Revert.
12515 * amd64-tdep.c: Revert.
12516 * amd64-sol2-tdep.c: Revert.
12517 * amd64-obsd-tdep.c: Revert.
12518 * amd64-obsd-nat.c: Revert.
12519 * amd64-nbsd-tdep.c: Revert.
12520 * amd64-nbsd-nat.c: Revert.
12521 * amd64-nat.c: Revert.
12522 * amd64-linux-tdep.c: Revert.
12523 * amd64-linux-nat.c: Revert.
12524 * amd64-fbsd-tdep.c: Revert.
12525 * amd64-fbsd-nat.c: Revert.
12526 * amd64-dicos-tdep.c: Revert.
12527 * amd64-darwin-tdep.c: Revert.
12528 * amd64-bsd-nat.c: Revert.
12529 * alpha-tdep.c: Revert.
12530 * alpha-obsd-tdep.c: Revert.
12531 * alpha-nbsd-tdep.c: Revert.
12532 * alpha-mdebug-tdep.c: Revert.
12533 * alpha-linux-tdep.c: Revert.
12534 * alpha-linux-nat.c: Revert.
12535 * alpha-bsd-tdep.c: Revert.
12536 * alpha-bsd-nat.c: Revert.
12537 * aix-thread.c: Revert.
12538 * agent.c: Revert.
12539 * addrmap.c: Revert.
12540 * ada-varobj.c: Revert.
12541 * ada-valprint.c: Revert.
12542 * ada-typeprint.c: Revert.
12543 * ada-tasks.c: Revert.
12544 * ada-lang.c: Revert.
12545 * aarch64-tdep.c: Revert.
12546 * aarch64-ravenscar-thread.c: Revert.
12547 * aarch64-newlib-tdep.c: Revert.
12548 * aarch64-linux-tdep.c: Revert.
12549 * aarch64-linux-nat.c: Revert.
12550 * aarch64-fbsd-tdep.c: Revert.
12551 * aarch64-fbsd-nat.c: Revert.
12552 * aarch32-linux-nat.c: Revert.
12553
12554 2019-04-05 Tom Tromey <tom@tromey.com>
12555
12556 * ft32-tdep.c: Sort headers.
12557 * frv-tdep.c: Sort headers.
12558 * frv-linux-tdep.c: Sort headers.
12559 * frame.c: Sort headers.
12560 * frame-unwind.c: Sort headers.
12561 * frame-base.c: Sort headers.
12562 * fork-child.c: Sort headers.
12563 * findvar.c: Sort headers.
12564 * findcmd.c: Sort headers.
12565 * filesystem.c: Sort headers.
12566 * filename-seen-cache.h: Sort headers.
12567 * filename-seen-cache.c: Sort headers.
12568 * fbsd-tdep.c: Sort headers.
12569 * fbsd-nat.h: Sort headers.
12570 * fbsd-nat.c: Sort headers.
12571 * f-valprint.c: Sort headers.
12572 * f-typeprint.c: Sort headers.
12573 * f-lang.c: Sort headers.
12574 * extension.h: Sort headers.
12575 * extension.c: Sort headers.
12576 * extension-priv.h: Sort headers.
12577 * expprint.c: Sort headers.
12578 * exec.h: Sort headers.
12579 * exec.c: Sort headers.
12580 * exceptions.c: Sort headers.
12581 * event-top.c: Sort headers.
12582 * event-loop.c: Sort headers.
12583 * eval.c: Sort headers.
12584 * elfread.c: Sort headers.
12585 * dwarf2read.h: Sort headers.
12586 * dwarf2read.c: Sort headers.
12587 * dwarf2loc.c: Sort headers.
12588 * dwarf2expr.h: Sort headers.
12589 * dwarf2expr.c: Sort headers.
12590 * dwarf2-frame.c: Sort headers.
12591 * dwarf2-frame-tailcall.c: Sort headers.
12592 * dwarf-index-write.h: Sort headers.
12593 * dwarf-index-write.c: Sort headers.
12594 * dwarf-index-common.c: Sort headers.
12595 * dwarf-index-cache.h: Sort headers.
12596 * dwarf-index-cache.c: Sort headers.
12597 * dummy-frame.c: Sort headers.
12598 * dtrace-probe.c: Sort headers.
12599 * disasm.h: Sort headers.
12600 * disasm.c: Sort headers.
12601 * disasm-selftests.c: Sort headers.
12602 * dictionary.c: Sort headers.
12603 * dicos-tdep.c: Sort headers.
12604 * demangle.c: Sort headers.
12605 * dcache.h: Sort headers.
12606 * dcache.c: Sort headers.
12607 * darwin-nat.h: Sort headers.
12608 * darwin-nat.c: Sort headers.
12609 * darwin-nat-info.c: Sort headers.
12610 * d-valprint.c: Sort headers.
12611 * d-namespace.c: Sort headers.
12612 * d-lang.c: Sort headers.
12613 * ctf.c: Sort headers.
12614 * csky-tdep.c: Sort headers.
12615 * csky-linux-tdep.c: Sort headers.
12616 * cris-tdep.c: Sort headers.
12617 * cris-linux-tdep.c: Sort headers.
12618 * cp-valprint.c: Sort headers.
12619 * cp-support.c: Sort headers.
12620 * cp-namespace.c: Sort headers.
12621 * cp-abi.c: Sort headers.
12622 * corelow.c: Sort headers.
12623 * corefile.c: Sort headers.
12624 * continuations.c: Sort headers.
12625 * completer.h: Sort headers.
12626 * completer.c: Sort headers.
12627 * complaints.c: Sort headers.
12628 * coffread.c: Sort headers.
12629 * coff-pe-read.c: Sort headers.
12630 * cli-out.h: Sort headers.
12631 * cli-out.c: Sort headers.
12632 * charset.c: Sort headers.
12633 * c-varobj.c: Sort headers.
12634 * c-valprint.c: Sort headers.
12635 * c-typeprint.c: Sort headers.
12636 * c-lang.c: Sort headers.
12637 * buildsym.c: Sort headers.
12638 * buildsym-legacy.c: Sort headers.
12639 * build-id.h: Sort headers.
12640 * build-id.c: Sort headers.
12641 * btrace.c: Sort headers.
12642 * bsd-uthread.c: Sort headers.
12643 * breakpoint.h: Sort headers.
12644 * breakpoint.c: Sort headers.
12645 * break-catch-throw.c: Sort headers.
12646 * break-catch-syscall.c: Sort headers.
12647 * break-catch-sig.c: Sort headers.
12648 * blockframe.c: Sort headers.
12649 * block.c: Sort headers.
12650 * bfin-tdep.c: Sort headers.
12651 * bfin-linux-tdep.c: Sort headers.
12652 * bfd-target.c: Sort headers.
12653 * bcache.c: Sort headers.
12654 * ax-general.c: Sort headers.
12655 * ax-gdb.h: Sort headers.
12656 * ax-gdb.c: Sort headers.
12657 * avr-tdep.c: Sort headers.
12658 * auxv.c: Sort headers.
12659 * auto-load.c: Sort headers.
12660 * arm-wince-tdep.c: Sort headers.
12661 * arm-tdep.c: Sort headers.
12662 * arm-symbian-tdep.c: Sort headers.
12663 * arm-pikeos-tdep.c: Sort headers.
12664 * arm-obsd-tdep.c: Sort headers.
12665 * arm-nbsd-tdep.c: Sort headers.
12666 * arm-nbsd-nat.c: Sort headers.
12667 * arm-linux-tdep.c: Sort headers.
12668 * arm-linux-nat.c: Sort headers.
12669 * arm-fbsd-tdep.c: Sort headers.
12670 * arm-fbsd-nat.c: Sort headers.
12671 * arm-bsd-tdep.c: Sort headers.
12672 * arch-utils.c: Sort headers.
12673 * arc-tdep.c: Sort headers.
12674 * arc-newlib-tdep.c: Sort headers.
12675 * annotate.h: Sort headers.
12676 * annotate.c: Sort headers.
12677 * amd64-windows-tdep.c: Sort headers.
12678 * amd64-windows-nat.c: Sort headers.
12679 * amd64-tdep.c: Sort headers.
12680 * amd64-sol2-tdep.c: Sort headers.
12681 * amd64-obsd-tdep.c: Sort headers.
12682 * amd64-obsd-nat.c: Sort headers.
12683 * amd64-nbsd-tdep.c: Sort headers.
12684 * amd64-nbsd-nat.c: Sort headers.
12685 * amd64-nat.c: Sort headers.
12686 * amd64-linux-tdep.c: Sort headers.
12687 * amd64-linux-nat.c: Sort headers.
12688 * amd64-fbsd-tdep.c: Sort headers.
12689 * amd64-fbsd-nat.c: Sort headers.
12690 * amd64-dicos-tdep.c: Sort headers.
12691 * amd64-darwin-tdep.c: Sort headers.
12692 * amd64-bsd-nat.c: Sort headers.
12693 * alpha-tdep.c: Sort headers.
12694 * alpha-obsd-tdep.c: Sort headers.
12695 * alpha-nbsd-tdep.c: Sort headers.
12696 * alpha-mdebug-tdep.c: Sort headers.
12697 * alpha-linux-tdep.c: Sort headers.
12698 * alpha-linux-nat.c: Sort headers.
12699 * alpha-bsd-tdep.c: Sort headers.
12700 * alpha-bsd-nat.c: Sort headers.
12701 * aix-thread.c: Sort headers.
12702 * agent.c: Sort headers.
12703 * addrmap.c: Sort headers.
12704 * ada-varobj.c: Sort headers.
12705 * ada-valprint.c: Sort headers.
12706 * ada-typeprint.c: Sort headers.
12707 * ada-tasks.c: Sort headers.
12708 * ada-lang.c: Sort headers.
12709 * aarch64-tdep.c: Sort headers.
12710 * aarch64-ravenscar-thread.c: Sort headers.
12711 * aarch64-newlib-tdep.c: Sort headers.
12712 * aarch64-linux-tdep.c: Sort headers.
12713 * aarch64-linux-nat.c: Sort headers.
12714 * aarch64-fbsd-tdep.c: Sort headers.
12715 * aarch64-fbsd-nat.c: Sort headers.
12716 * aarch32-linux-nat.c: Sort headers.
12717
12718 2019-04-04 Tom Tromey <tom@tromey.com>
12719
12720 * varobj.c (varobj_create): Update.
12721 * rust-exp.y (struct rust_parser) <update_innermost_block,
12722 lookup_symbol>: New methods.
12723 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12724 Rename.
12725 (rust_parser::rust_lookup_type)
12726 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12727 * printcmd.c (display_command, do_one_display): Update.
12728 * parser-defs.h (struct parser_state) <parser_state>: Add
12729 "tracker" parameter.
12730 (block_tracker): New member.
12731 (class innermost_block_tracker) <innermost_block_tracker>: Add
12732 "types" parameter.
12733 <reset>: Remove method.
12734 (innermost_block): Don't declare.
12735 (null_post_parser): Update.
12736 * parse.c (innermost_block): Remove global.
12737 (write_dollar_variable): Update.
12738 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12739 Remove "tracker_types" parameter.
12740 (parse_expression): Add "tracker" parameter.
12741 (parse_expression_for_completion): Update.
12742 (null_post_parser): Add "tracker" parameter.
12743 * p-exp.y: Update rules.
12744 * m2-exp.y: Update rules.
12745 * language.h (struct language_defn) <la_post_parser>: Add
12746 "tracker" parameter.
12747 * go-exp.y: Update rules.
12748 * f-exp.y: Update rules.
12749 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12750 parameter.
12751 * d-exp.y: Update rules.
12752 * c-exp.y: Update rules.
12753 * breakpoint.c (set_breakpoint_condition): Create an
12754 innermost_block_tracker.
12755 (watch_command_1): Likewise.
12756 * ada-lang.c (resolve): Add "tracker" parameter.
12757 (resolve_subexp): Likewise.
12758 * ada-exp.y (write_var_from_sym): Update.
12759
12760 2019-04-04 Tom Tromey <tom@tromey.com>
12761
12762 * type-stack.h: New file.
12763 * type-stack.c: New file.
12764 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12765 type-stack.h.
12766 (insert_into_type_stack, insert_type, push_type, push_type_int)
12767 (insert_type_address_space, pop_type, pop_type_int)
12768 (pop_typelist, pop_type_stack, append_type_stack)
12769 (push_type_stack, get_type_stack, push_typelist)
12770 (follow_type_instance_flags, follow_types): Don't declare.
12771 * parse.c (type_stack): Remove global.
12772 (parse_exp_in_context): Update.
12773 (insert_into_type_stack, insert_type, push_type, push_type_int)
12774 (insert_type_address_space, pop_type, pop_type_int)
12775 (pop_typelist, pop_type_stack, append_type_stack)
12776 (push_type_stack, get_type_stack, push_typelist)
12777 (follow_type_instance_flags, follow_types): Remove (moved to
12778 type-stack.c).
12779 * f-exp.y (type_stack): New global.
12780 Update rules.
12781 (push_kind_type, f_parse): Update.
12782 * d-exp.y (type_stack): New global.
12783 Update rules.
12784 (d_parse): Update.
12785 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12786 Update rules.
12787 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12788 (HFILES_NO_SRCDIR): Add type-stack.h.
12789
12790 2019-04-04 Tom Tromey <tom@tromey.com>
12791
12792 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12793 (rust_parser::convert_ast_to_expression, rust_parse)
12794 (rust_lex_test_completion, rust_lex_tests): Update.
12795 * parser-defs.h (struct expr_completion_state): New.
12796 (struct parser_state) <parser_state>: Add completion parameter.
12797 <mark_struct_expression, mark_completion_tag>: New methods.
12798 <parse_completion, m_completion_state>: New members.
12799 (prefixify_expression, null_post_parser): Update.
12800 (mark_struct_expression, mark_completion_tag): Don't declare.
12801 * parse.c (parse_completion, expout_last_struct)
12802 (expout_tag_completion_type, expout_completion_name): Remove
12803 globals.
12804 (parser_state::mark_struct_expression)
12805 (parser_state::mark_completion_tag): Now methods.
12806 (prefixify_expression): Add last_struct parameter.
12807 (prefixify_subexp): Likewise.
12808 (parse_exp_1): Update.
12809 (parse_exp_in_context): Add cstate parameter. Update.
12810 (parse_expression_for_completion): Create an
12811 expr_completion_state.
12812 (null_post_parser): Add "completion" parameter.
12813 * p-exp.y: Update rules.
12814 (yylex): Update.
12815 * language.h (struct language_defn) <la_post_parser>: Add
12816 "completing" parameter.
12817 * go-exp.y: Update rules.
12818 (lex_one_token): Update.
12819 * expression.h (parse_completion): Don't declare.
12820 * d-exp.y: Update rules.
12821 (lex_one_token): Update rules.
12822 * c-exp.y: Update rules.
12823 (lex_one_token): Update.
12824 * ada-lang.c (resolve): Add "parse_completion" parameter.
12825 (resolve_subexp): Likewise.
12826 (ada_resolve_function): Likewise.
12827
12828 2019-04-04 Tom Tromey <tom@tromey.com>
12829
12830 * parser-defs.h (struct parser_state) <start_arglist,
12831 end_arglist>: New methods.
12832 <arglist_len, m_funcall_chain>: New members.
12833 (arglist_len, start_arglist, end_arglist): Don't declare.
12834 * parse.c (arglist_len, funcall_chain): Remove global.
12835 (start_arglist, end_arglist): Remove functions.
12836 (parse_exp_in_context): Update.
12837 * p-exp.y: Update rules.
12838 * m2-exp.y: Update rules.
12839 * go-exp.y: Update rules.
12840 * f-exp.y: Update rules.
12841 * d-exp.y: Update rules.
12842 * c-exp.y: Update rules.
12843
12844 2019-04-04 Tom Tromey <tom@tromey.com>
12845
12846 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12847 lex_operator, push_back>: New methods.
12848 Update all rules.
12849 (rust_parser::lex_hex, lex_escape): Rename and update.
12850 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12851 (rust_parser::lex_operator): Rename and update.
12852 (rust_parser::lex_number, rustyylex, rustyyerror)
12853 (rust_lex_test_init, rust_lex_test_sequence)
12854 (rust_lex_test_push_back, rust_lex_tests): Update.
12855 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12856 parameter.
12857 <lexptr, prev_lexptr>: New members.
12858 (lexptr, prev_lexptr): Don't declare.
12859 * parse.c (lexptr, prev_lexptr): Remove globals.
12860 (parse_exp_in_context): Update.
12861 * p-exp.y (yylex, yyerror): Update.
12862 * m2-exp.y (parse_number, yylex, yyerror): Update.
12863 * go-exp.y (lex_one_token, yyerror): Update.
12864 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12865 * d-exp.y (lex_one_token, yyerror): Update.
12866 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12867 (lex_one_token, yyerror): Update.
12868 * ada-lex.l (YY_INPUT): Update.
12869 (rewind_to_char): Update.
12870 * ada-exp.y (yyerror): Update.
12871
12872 2019-04-04 Tom Tromey <tom@tromey.com>
12873
12874 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12875 * parser-defs.h (struct parser_state) <parser_state>: Add new
12876 parameter.
12877 <comma_terminates>: New member.
12878 (comma_terminates): Don't declare global.
12879 * parse.c (comma_terminates): Remove global.
12880 (parse_exp_in_context): Update.
12881 * p-exp.y (yylex): Update.
12882 * m2-exp.y (yylex): Update.
12883 * go-exp.y (lex_one_token): Update.
12884 * f-exp.y (yylex): Update.
12885 * d-exp.y (lex_one_token): Update.
12886 * c-exp.y (lex_one_token): Update.
12887 * ada-lex.l: Update.
12888
12889 2019-04-04 Tom Tromey <tom@tromey.com>
12890
12891 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12892 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12893 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12894 * parser-defs.h (paren_depth): Don't declare.
12895 * parse.c (paren_depth): Remove global.
12896 (parse_exp_in_context): Update.
12897 * p-exp.y (paren_depth): New global.
12898 (pascal_parse): Initialize it.
12899 * m2-exp.y (paren_depth): New global.
12900 (m2_parse): Initialize it.
12901 * go-exp.y (paren_depth): New global.
12902 (go_parse): Initialize it.
12903 * f-exp.y (paren_depth): New global.
12904 (f_parse): Initialize it.
12905 * d-exp.y (paren_depth): New global.
12906 (d_parse): Initialize it.
12907 * c-exp.y (paren_depth): New global.
12908 (c_parse): Initialize it.
12909 * ada-lex.l (paren_depth): New global.
12910 (lexer_init): Initialize it.
12911
12912 2019-04-04 Tom Tromey <tom@tromey.com>
12913
12914 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12915 (rust_parser::convert_ast_to_type)
12916 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12917 * parser-defs.h (struct parser_state) <parser_state>: Add
12918 parameters. Initialize new members.
12919 <expression_context_block, expression_context_pc>: New members.
12920 * parse.c (expression_context_block, expression_context_pc):
12921 Remove globals.
12922 (parse_exp_in_context): Update.
12923 * p-exp.y: Update all rules.
12924 (yylex): Update.
12925 * m2-exp.y: Update all rules.
12926 (yylex): Update.
12927 * go-exp.y (yylex): Update.
12928 * f-exp.y (yylex): Update.
12929 * d-exp.y: Update all rules.
12930 (yylex): Update.
12931 * c-exp.y: Update all rules.
12932 (lex_one_token, classify_name, yylex, c_parse): Update.
12933 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12934
12935 2019-04-04 Tom Tromey <tom@tromey.com>
12936
12937 * gdbarch.h, gdbarch.c: Rebuild.
12938 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12939 * stap-probe.h:
12940 (struct stap_parse_info): Replace "parser_state" with
12941 "expr_builder".
12942 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12943 (parser_state): New class.
12944 * parse.c (expr_builder): Rename.
12945 (expr_builder::release): Rename.
12946 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12947 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12948 (write_exp_elt_longcst, write_exp_elt_floatcst)
12949 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12950 (write_exp_string_vector, write_exp_bitstring)
12951 (write_exp_msymbol, mark_struct_expression)
12952 (write_dollar_variable)
12953 (insert_type_address_space, increase_expout_size): Replace
12954 "parser_state" with "expr_builder".
12955 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12956 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12957 "parser_state" with "expr_builder".
12958
12959 2019-04-04 Tom Tromey <tom@tromey.com>
12960
12961 * rust-exp.y: Replace "parse_language" with method call.
12962 * p-exp.y:
12963 (yylex): Replace "parse_language" with method call.
12964 * m2-exp.y:
12965 (yylex): Replace "parse_language" with method call.
12966 * go-exp.y (classify_name): Replace "parse_language" with method
12967 call.
12968 * f-exp.y (yylex): Replace "parse_language" with method call.
12969 * d-exp.y (lex_one_token): Replace "parse_language" with method
12970 call.
12971 * c-exp.y:
12972 (lex_one_token, classify_name, yylex): Replace "parse_language"
12973 with method call.
12974 * ada-exp.y (find_primitive_type, type_char)
12975 (type_system_address): Replace "parse_language" with method call.
12976
12977 2019-04-04 Tom Tromey <tom@tromey.com>
12978
12979 * rust-exp.y: Replace "parse_gdbarch" with method call.
12980 * parse.c (write_dollar_variable, insert_type_address_space):
12981 Replace "parse_gdbarch" with method call.
12982 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12983 call.
12984 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12985 call.
12986 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12987 "parse_gdbarch" with method call.
12988 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12989 with method call.
12990 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12991 "parse_gdbarch" with method call.
12992 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12993 "parse_gdbarch" with method call.
12994 * c-exp.y (parse_type, parse_number, classify_name): Replace
12995 "parse_gdbarch" with method call.
12996 * ada-lex.l: Replace "parse_gdbarch" with method call.
12997 * ada-exp.y (parse_type, find_primitive_type, type_char)
12998 (type_system_address): Replace "parse_gdbarch" with method call.
12999
13000 2019-04-04 Tom Tromey <tom@tromey.com>
13001
13002 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13003 * stap-probe.c (stap_parse_argument): Update.
13004 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13005 initial_size parameter.
13006 * rust-exp.y (rust_lex_tests): Update.
13007 * parse.c (parser_state): Update.
13008 (parse_exp_in_context): Update.
13009 * parser-defs.h (struct parser_state) <parser_state>: Remove
13010 "initial_size" parameter.
13011
13012 2019-04-04 Tom Tromey <tom@tromey.com>
13013
13014 * parser-defs.h (increase_expout_size): Don't declare.
13015 * parse.c (increase_expout_size): Now static.
13016
13017 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13018
13019 * gnu-nat.c (gnu_nat_target::wait): Fix
13020 target_waitstatus_to_string call.
13021
13022 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13023
13024 * eval.c (evaluate_subexp_standard): Handle internal functions
13025 during Fortran function call handling.
13026
13027 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13028
13029 * NEWS: Mention new internal functions.
13030 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13031 (read_base_type): Use dwarf2_init_complex_target_type.
13032 * value.c (creal_internal_fn): New function.
13033 (cimag_internal_fn): New function.
13034 (_initialize_values): Register new internal functions.
13035
13036 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13037
13038 * infrun.c (stop_all_threads): If debug_infrun, always
13039 trace the wait status after wait_one, using
13040 target_waitstatus_to_string and target_pid_to_str.
13041 (handle_inferior_event): Replace various trace of
13042 wait status kind by a single trace.
13043 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13044 wait status kind image by target_waitstatus_to_string.
13045 * target/waitstatus.c (target_waitstatus_to_string): Fix
13046 obsolete comment.
13047
13048 2019-04-01 Tom Tromey <tromey@adacore.com>
13049
13050 PR symtab/23331:
13051 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13052
13053 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13054 Pedro Alves <palves@redhat.com>
13055
13056 * top.c (quit_force): Call 'finalize_values'.
13057 * value.c (finalize_values): New function.
13058 * value.h (finalize_values): Declare.
13059
13060 2019-03-30 Eli Zaretskii <eliz@gnu.org>
13061
13062 * NEWS: Announce $_gdb_major and $_gdb_minor.
13063
13064 * top.c (init_gdb_version_vars): New function.
13065 (gdb_init): Call init_gdb_version_vars.
13066
13067 2019-03-29 Tom Tromey <tromey@adacore.com>
13068
13069 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13070 help text. Remove dead code.
13071
13072 2019-03-29 Keith Seitz <keiths@redhat.com>
13073
13074 From Siddhesh Poyarekar:
13075 * f-lang.h (f77_get_upperbound): Return LONGEST.
13076 (f77_get_lowerbound): Likewise.
13077 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13078 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13079 print them.
13080 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13081 plongest to format print it.
13082 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13083 (f77_get_upperbound): Likewise.
13084 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13085 LOWER_BOUND to LONGEST.
13086 (f77_create_arrayprint_offset_tbl): Likewise.
13087
13088 2019-03-29 Keith Seitz <keiths@redhat.com>
13089
13090 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13091 %s/pulongest for TYPE_LENGTH instead of %d in format
13092 strings.
13093 * ada-typerint.c (ada_print_type): Likewise.
13094 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13095 * compile/compile-c-support.c (generate_register_struct): Likewise.
13096 * gdbtypes.c (recursive_dump_type): Likewise.
13097 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13098 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13099 instead of %d in format strings.
13100 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13101 to std::min to ULONGEST.
13102 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13103 instead of %d in format strings.
13104 * tracepoint.c (info_scope_command): Likewise.
13105 * typeprint.c (print_offset_data::update)
13106 (print_offset_data::finish): Likewise.
13107 * xtensa-tdep.c (xtensa_store_return_value)
13108 (xtensa_push_dummy_call): Likewise.
13109
13110 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13111
13112 * windows-nat.c (display_selector): Fixed format specifications
13113 for 64-bit Cygwin.
13114
13115 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13116
13117 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13118
13119 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13120
13121 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13122 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13123 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13124 (nios2_linux_init_abi): Install it.
13125
13126 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13127
13128 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13129
13130 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13131
13132 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13133
13134 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13135 Tom Tromey <tromey@adacore.com>
13136
13137 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13138
13139 2019-03-26 Joel Brobecker <brobecker@adacore.com>
13140
13141 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13142 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13143 method to compute the bounds of range types. Also print "[evaluated]"
13144 if the bounds' values come from a dynamic evaluation.
13145
13146 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13147
13148 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13149 whitespace when pretty printing is on.
13150
13151 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13152
13153 * ppc-linux-nat.c: Add include.
13154
13155 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13156
13157 * NEWS: Mention AArch64 Pointer Authentication.
13158
13159 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13160
13161 * arm-linux-nat.c: Add include.
13162
13163 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13164
13165 * source-cache.c (source_cache::get_source_lines): Re-read
13166 fullname after calling open_source_file.
13167
13168 2019-03-25 John Baldwin <jhb@FreeBSD.org>
13169
13170 * NEWS: Mention TLS support for FreeBSD.
13171
13172 2019-03-25 Tom Tromey <tromey@adacore.com>
13173
13174 * minsyms.c (BUNCH_SIZE): Update comment.
13175 (~minimal_symbol_reader): Remove old comment.
13176 (compact_minimal_symbols): Update comment.
13177 (minimal_symbol_reader::install): Remove old comment. Update
13178 other comments.
13179
13180 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13181
13182 * s390-linux-nat.c: Add include.
13183
13184 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13185
13186 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13187 Call linux_get_hwcap.
13188 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13189 Likewise.
13190 (aarch64_linux_get_hwcap): Remove function.
13191 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13192 declaration.
13193 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13194 linux_get_hwcap.
13195 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13196 * linux-tdep.c (linux_get_hwcap): Add function.
13197 (linux_get_hwcap2): Likewise.
13198 * linux-tdep.h (linux_get_hwcap): Add declaration.
13199 (linux_get_hwcap2): Likewise.
13200 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13201 (ppc_linux_get_hwcap2): Likewise.
13202 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13203 linux_get_hwcap.
13204 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13205 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13206 (ppc_linux_nat_target::read_description): Likewise.
13207 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13208 * s390-linux-nat.c: Likewise.
13209 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13210
13211 2019-03-24 Tom Tromey <tom@tromey.com>
13212
13213 * ada-lang.c (standard_lookup): Simplify initialization.
13214 (ada_lookup_symbol_nonlocal): Simplify return.
13215 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13216 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13217 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13218 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13219 initialization.
13220 * solib.c (solib_global_lookup): Simplify.
13221 * symtab.c (null_block_symbol): Remove.
13222 (symbol_cache_lookup): Simplify returns.
13223 (lookup_language_this): Simplify returns.
13224 (lookup_symbol_aux): Simplify return.
13225 (lookup_local_symbol): Simplify returns.
13226 (lookup_global_symbol_from_objfile): Simplify return.
13227 (lookup_symbol_in_objfile_symtabs)
13228 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13229 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13230 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13231 * cp-namespace.c (cp_lookup_bare_symbol)
13232 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13233 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13234 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13235 (cp_lookup_symbol_via_imports): Simplify initialization.
13236 (find_symbol_in_baseclass): Likewise.
13237 * symtab.h (null_block_symbol): Remove.
13238 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13239 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13240 (d_lookup_symbol_module): Likewise.
13241 (find_symbol_in_baseclass): Simplify initialization.
13242
13243 2019-03-24 Tom Tromey <tom@tromey.com>
13244
13245 * expression.h: Don't include symtab.h.
13246 (struct block): Forward declare.
13247
13248 2019-03-24 Tom Tromey <tom@tromey.com>
13249
13250 * c-exp.y (typebase): Remove casts.
13251 * gdbtypes.c (lookup_unsigned_typename, )
13252 (lookup_signed_typename): Remove cast.
13253 * eval.c (parse_to_comma_and_eval): Remove cast.
13254 * parse.c (write_dollar_variable): Remove cast.
13255 * block.h (struct block) <superblock>: Now const.
13256 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13257 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13258 (map_block): Make "block" const.
13259 * symfile.h (struct quick_symbol_functions)
13260 <map_matching_symbols>: Constify block argument to "callback".
13261 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13262 const.
13263 (find_pc_sect_compunit_symtab): Make "b" const.
13264 (find_symbol_at_address): Likewise.
13265 (search_symbols): Likewise.
13266 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13267 (dw2_debug_names_lookup_symbol): Likewise.
13268 (dw2_map_matching_symbols): Update.
13269 * p-valprint.c (pascal_val_print): Remove "block".
13270 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13271 (aux_add_nonlocal_symbols): Make "block" const.
13272 (resolve_subexp): Remove cast.
13273 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13274 const.
13275 (iterate_over_file_blocks): Likewise.
13276 * f-exp.y (%union) <bval>: Remove.
13277 * coffread.c (patch_opaque_types): Make "b" const.
13278 * spu-tdep.c (spu_catch_start): Make "block" const.
13279 * c-valprint.c (print_unpacked_pointer): Remove "block".
13280 * symmisc.c (dump_symtab_1): Make "b" const.
13281 (block_depth): Make "block" const.
13282 * d-exp.y (%union) <bval>: Remove.
13283 * cp-support.h (cp_lookup_rtti_type): Update.
13284 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13285 * psymtab.c (psym_lookup_symbol): Make "block" const.
13286 (maintenance_check_psymtabs): Make "b" const.
13287 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13288 (enumerate_locals, enumerate_args): Update.
13289 * python/py-symtab.c (stpy_global_block): Make "block" const.
13290 (stpy_static_block): Likewise.
13291 * inline-frame.c (block_starting_point_at): Make "new_block"
13292 const.
13293 * block.c (find_block_in_blockvector): Make return type const.
13294 (blockvector_for_pc_sect): Make "b" const.
13295 (find_block_in_blockvector): Make "b" const.
13296
13297 2019-03-23 Tom Tromey <tom@tromey.com>
13298
13299 * varobj.c (varobj_create): Update.
13300 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13301 * printcmd.c (display_command, do_one_display): Don't reset
13302 innermost_block.
13303 * parser-defs.h (enum innermost_block_tracker_type): Move to
13304 expression.h.
13305 (innermost_block): Update comment.
13306 * parse.c (parse_exp_1): Add tracker_types parameter.
13307 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13308 tracker_types parameter. Reset innermost_block.
13309 (parse_exp_in_context): Remove.
13310 (parse_expression_for_completion): Update.
13311 * objfiles.c (~objfile): Don't reset expression_context_block or
13312 innermost_block.
13313 * expression.h (enum innermost_block_tracker_type): Move from
13314 parser-defs.h.
13315 (parse_exp_1): Add tracker_types parameter.
13316 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13317 reset innermost_block.
13318
13319 2019-03-23 Tom Tromey <tom@tromey.com>
13320
13321 * objfiles.h: Include bcache.h.
13322
13323 2019-03-23 Tom Tromey <tom@tromey.com>
13324
13325 * linespec.c (get_current_search_block): Use
13326 scoped_restore_current_language.
13327 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13328
13329 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13330 Jiong Wang <jiong.wang@arm.com>
13331
13332 * aarch64-linux-tdep.c
13333 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13334 section.
13335 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13336
13337 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13338 Jiong Wang <jiong.wang@arm.com>
13339
13340 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13341 instructions.
13342 (aarch64_analyze_prologue_test): Add PACIASP test.
13343 (aarch64_prologue_prev_register): Unmask PC value.
13344
13345 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13346 Jiong Wang <jiong.wang@arm.com>
13347
13348 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13349 (aarch64_dwarf2_prev_register): Unmask PC value.
13350 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13351 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13352 DW_CFA_AARCH64_negate_ra_state.
13353 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13354
13355 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13356 Jiong Wang <jiong.wang@arm.com>
13357
13358 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13359 registers.
13360 (aarch64_pseudo_register_name): Likewise.
13361 (aarch64_pseudo_register_type): Likewise.
13362 (aarch64_pseudo_register_reggroup_p): Likewise.
13363 (aarch64_gdbarch_init): Add pauth registers.
13364 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13365 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13366 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13367 (struct gdbarch_tdep): Add regnum for ra_state.
13368
13369 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13370 Jiong Wang <jiong.wang@arm.com>
13371
13372 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13373
13374 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13375 Jiong Wang <jiong.wang@arm.com>
13376
13377 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13378 function.
13379 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13380 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13381 (aarch64_gdbarch_init): Add puth registers.
13382 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13383 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13384 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13385
13386 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13387 Jiong Wang <jiong.wang@arm.com>
13388
13389 * aarch64-linux-nat.c
13390 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13391 * aarch64-linux-tdep.c
13392 (aarch64_linux_core_read_description): Likewise.
13393 (aarch64_linux_get_hwcap): New function.
13394 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13395 (aarch64_linux_get_hwcap): New declaration.
13396
13397 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13398 Jiong Wang <jiong.wang@arm.com>
13399
13400 * aarch64-linux-nat.c
13401 (aarch64_linux_nat_target::read_description): Add pauth param.
13402 * aarch64-linux-tdep.c
13403 (aarch64_linux_core_read_description): Likewise.
13404 * aarch64-tdep.c (struct target_desc): Add in pauth.
13405 (aarch64_read_description): Add pauth param.
13406 (aarch64_gdbarch_init): Likewise.
13407 * aarch64-tdep.h (aarch64_read_description): Likewise.
13408 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13409 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13410 * features/Makefile: Add new files.
13411 * features/aarch64-pauth.c: New file.
13412 * features/aarch64-pauth.xml: New file.
13413
13414 2019-03-20 Tom Tromey <tromey@adacore.com>
13415
13416 * infrun.c (handle_inferior_event): Rename from
13417 handle_inferior_event_1. Create a scoped_value_mark.
13418 (handle_inferior_event): Remove.
13419
13420 2019-03-19 Tom Tromey <tromey@adacore.com>
13421
13422 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13423 * infrun.h (print_stop_event): Add "displays" parameter.
13424 * infrun.c (print_stop_event): Add "displays" parameter.
13425
13426 2019-03-19 Pedro Alves <palves@redhat.com>
13427
13428 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13429 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13430 to -1. Fix TABs vs spaces.
13431 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13432 * tui/tui-out.h (tui_ui_out) Add intro comments.
13433 <m_line, m_start_of_line>: In-class initialize, and add describing
13434 comment.
13435
13436 2019-03-18 Alan Hayward <alan.hayward@arm.com>
13437
13438 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13439 variable names.
13440 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13441
13442 2019-03-18 Pedro Alves <palves@redhat.com>
13443 Eli Zaretskii <eliz@gnu.org>
13444
13445 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13446 m_line and m_start_of_line.
13447
13448 2019-03-18 Eli Zaretskii <eliz@gnu.org>
13449
13450 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13451 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13452 it returns a newline. This fixes a regression in TU mode, whereby
13453 the next line is output on the same screen line as the user input.
13454
13455 2019-03-18 Tom Tromey <tromey@adacore.com>
13456
13457 * minsyms.c (minimal_symbol_reader::install): Remove call to
13458 obstack_blank.
13459
13460 2019-03-18 Pedro Alves <palves@redhat.com>
13461
13462 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13463 New globals.
13464 (apply_style): New, factored out from ...
13465 (apply_ansi_escape): ... this. Handle reverse video mode.
13466 (tui_set_reverse_mode): New function.
13467 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13468 * tui/tui-winsource.c (tui_show_source_line): Use
13469 tui_set_reverse_mode instead of setting A_STANDOUT.
13470 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13471 New setter methods.
13472
13473 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13474
13475 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13476 Handle tabs.
13477
13478 2019-03-18 Tom Tromey <tromey@adacore.com>
13479
13480 * ada-lang.c (empty_array): Add "high" parameter.
13481 (ada_evaluate_subexp): Update.
13482
13483 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13484
13485 * unittests/string_view-selftests.c: Define
13486 _initialize_string_view_selftests unconditionally.
13487
13488 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13489
13490 PR gdb/24350
13491 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13492
13493 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13494
13495 PR gdb/24351
13496 * windows-nat.c (display_selector): Fix format specifiers.
13497
13498 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13499
13500 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13501 tui_refill_source_window instead of tui_refresh_win, to update the
13502 current execution line. This fixes redisplay of the current line
13503 when stepping through the code with "next" or "step".
13504
13505 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13506
13507 * source-cache.c (source_cache::get_source_lines): Call
13508 find_source_lines to initialize s->nlines. This fixes vertical
13509 scrolling of TUI source window when the DOWN arrow is pressed.
13510
13511 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13512
13513 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13514 linux-thread-db.c (_initialize_thread_db): Likewise.
13515
13516 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13517
13518 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13519 wclrtoeol in tui_show_source_line". This reverts changes made in
13520 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13521
13522 2019-03-15 Tom Tromey <tom@tromey.com>
13523
13524 * symtab.h (struct minimal_symbol): Derive from
13525 general_symbol_info.
13526 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13527 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13528 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13529 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13530 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13531 (MSYMBOL_SEARCH_NAME): Update.
13532 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13533 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13534 * minsyms.c (minimal_symbol_reader::record_full): Update.
13535
13536 2019-03-15 Tom Tromey <tom@tromey.com>
13537
13538 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13539
13540 2019-03-15 Tom Tromey <tom@tromey.com>
13541
13542 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13543 unique_xmalloc_ptr.
13544 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13545 Update.
13546 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13547 (build_minimal_symbol_hash_tables)
13548 (minimal_symbol_reader::install): Update.
13549
13550 2019-03-15 Tom Tromey <tom@tromey.com>
13551
13552 * symtab.c (create_demangled_names_hash): Update.
13553 (symbol_set_names): Update.
13554 * objfiles.h (struct objfile_per_bfd_storage)
13555 <demangled_names_hash>: Now an htab_up.
13556 * objfiles.c (objfile_per_bfd_storage): Simplify.
13557
13558 2019-03-15 Tom Tromey <tom@tromey.com>
13559
13560 * objfiles.h (struct objfile_per_bfd_storage): Declare
13561 destructor.
13562 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13563 New.
13564 (get_objfile_bfd_data): Use new. Don't initialize
13565 language_of_main.
13566 (free_objfile_per_bfd_storage): Remove.
13567 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13568
13569 2019-03-15 Tom Tromey <tom@tromey.com>
13570
13571 * symfile.c (reread_symbols): Update.
13572 * objfiles.c (objfile::objfile): Update.
13573 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13574 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13575 comment.
13576 (minimal_symbol_reader::install): Update.
13577 (terminate_minimal_symbol_table): Remove.
13578 * jit.c (jit_object_close_impl): Update.
13579
13580 2019-03-15 Tom Tromey <tom@tromey.com>
13581
13582 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13583 initializations.
13584
13585 2019-03-15 Tom Tromey <tom@tromey.com>
13586
13587 * objfiles.h (struct objfile_per_bfd_storage)
13588 <demangled_hash_languages>: Now a bitset.
13589 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13590 (lookup_minimal_symbol): Update.
13591
13592 2019-03-15 Tom Tromey <tom@tromey.com>
13593
13594 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13595 Don't return the symbol.
13596 * coffread.c (record_minimal_symbol): Use record_full.
13597
13598 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13599
13600 The MS-Windows port of ncurses fails to switch to a color pair if
13601 one or both of the colors are the implicit default colors. This
13602 change records the default colors when TUI is initialized, and
13603 then specifies them explicitly when a color pair uses the default
13604 colors. This allows color styling in TUI mode on MS-Windows.
13605
13606 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13607 ncurses_norm_attr.
13608 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13609 colors in ncurses_norm_attr.
13610 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13611 "none", replace it with the default color recorded in
13612 ncurses_norm_attr.
13613
13614 2019-03-14 Tom Tromey <tromey@adacore.com>
13615
13616 * source-cache.h (class source_cache) <get_source_lines>: Return
13617 std::string.
13618 * source-cache.c (source_cache::extract_lines): Handle case where
13619 first_pos==npos. Return std::string.
13620 (source_cache::get_source_lines): Update.
13621
13622 2019-03-14 Tom Tromey <tromey@adacore.com>
13623
13624 * NEWS: Add item for "style sources" commands.
13625 * source-cache.c (source_cache::get_source_lines): Check
13626 source_styling.
13627 * cli/cli-style.c (source_styling): New global.
13628 (_initialize_cli_style): Add "style sources" commands.
13629 (show_style_sources): New function.
13630 * cli/cli-style.h (source_styling): Declare.
13631
13632 2019-03-14 Pedro Alves <palves@redhat.com>
13633 Tom Tromey <tromey@adacore.com>
13634
13635 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13636 * tui/tui-winsource.c (tui_refill_source_window): New function,
13637 from...
13638 (tui_horizontal_source_scroll): ... here. Move some logic.
13639 * cli/cli-style.c (set_style_enabled): Notify new observable.
13640 * tui/tui-hooks.c (tui_redisplay_source): New function.
13641 (tui_attach_detach_observers): Attach or detach
13642 tui_redisplay_source.
13643 * observable.h (source_styling_changed): New observable.
13644 * observable.c: Define source_styling_changed observable.
13645
13646 2019-03-13 Tom Tromey <tromey@adacore.com>
13647
13648 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13649 (i386_gnu_nat_target::store_registers): Update.
13650 * target-debug.h (target_debug_print_std_string): New macro.
13651 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13652 * windows-tdep.c (display_one_tib): Update.
13653 * tui/tui-stack.c (tui_make_status_line): Update.
13654 * top.c (print_inferior_quit_action): Update.
13655 * thread.c (thr_try_catch_cmd): Update.
13656 (add_thread_with_info): Update.
13657 (thread_target_id_str): Update.
13658 (thr_try_catch_cmd): Update.
13659 (thread_command): Update.
13660 (thread_find_command): Update.
13661 * record-btrace.c (record_btrace_target::info_record)
13662 (record_btrace_resume_thread, record_btrace_target::resume)
13663 (record_btrace_cancel_resume, record_btrace_step_thread)
13664 (record_btrace_target::wait, record_btrace_target::wait)
13665 (record_btrace_target::wait, record_btrace_target::stop): Update.
13666 * progspace.c (print_program_space): Update.
13667 * process-stratum-target.c
13668 (process_stratum_target::thread_address_space): Update.
13669 * linux-fork.c (linux_fork_mourn_inferior)
13670 (detach_checkpoint_command, info_checkpoints_command)
13671 (linux_fork_context): Update.
13672 (linux_fork_detach): Update.
13673 (class scoped_switch_fork_info): Update.
13674 (delete_checkpoint_command): Update.
13675 * infrun.c (follow_fork_inferior): Update.
13676 (follow_fork_inferior): Update.
13677 (proceed_after_vfork_done): Update.
13678 (handle_vfork_child_exec_or_exit): Update.
13679 (follow_exec): Update.
13680 (displaced_step_prepare_throw): Update.
13681 (displaced_step_restore): Update.
13682 (start_step_over): Update.
13683 (resume_1): Update.
13684 (clear_proceed_status_thread): Update.
13685 (proceed): Update.
13686 (print_target_wait_results): Update.
13687 (do_target_wait): Update.
13688 (context_switch): Update.
13689 (stop_all_threads): Update.
13690 (restart_threads): Update.
13691 (finish_step_over): Update.
13692 (handle_signal_stop): Update.
13693 (switch_back_to_stepped_thread): Update.
13694 (keep_going_pass_signal): Update.
13695 (print_exited_reason): Update.
13696 (normal_stop): Update.
13697 * inferior.c (inferior_pid_to_str): Change return type.
13698 (print_selected_inferior): Update.
13699 (add_inferior): Update.
13700 (detach_inferior): Update.
13701 * dummy-frame.c (fprint_dummy_frames): Update.
13702 * dcache.c (dcache_info_1): Update.
13703 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13704 (btrace_fetch, btrace_clear): Update.
13705 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13706 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13707 type.
13708 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13709 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13710 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13711 * gdbarch.c, gdbarch.h: Rebuild.
13712 * gdbarch.sh (core_pid_to_str): Change return type.
13713 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13714 return type.
13715 (windows_nat_target::pid_to_str): Change return type.
13716 (windows_delete_thread): Update.
13717 (windows_nat_target::attach): Update.
13718 (windows_nat_target::files_info): Update.
13719 * target-delegates.c: Rebuild.
13720 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13721 return type.
13722 (sol_thread_target::pid_to_str): Change return type.
13723 * remote.c (class remote_target) <pid_to_str>: Change return
13724 type.
13725 (remote_target::pid_to_str): Change return type.
13726 (extended_remote_target::attach, remote_target::remote_stop_ns)
13727 (remote_target::remote_notif_remove_queued_reply)
13728 (remote_target::push_stop_reply, remote_target::disable_btrace):
13729 Update.
13730 (extended_remote_target::attach): Update.
13731 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13732 type.
13733 (gdbsim_target::pid_to_str): Change return type.
13734 * ravenscar-thread.c (struct ravenscar_thread_target)
13735 <pid_to_str>: Change return type.
13736 (ravenscar_thread_target::pid_to_str): Change return type.
13737 * procfs.c (class procfs_target) <pid_to_str>: Change return
13738 type.
13739 (procfs_target::pid_to_str): Change return type.
13740 (procfs_target::attach): Update.
13741 (procfs_target::detach): Update.
13742 (procfs_target::fetch_registers): Update.
13743 (procfs_target::store_registers): Update.
13744 (procfs_target::wait): Update.
13745 (procfs_target::files_info): Update.
13746 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13747 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13748 return type.
13749 (nto_procfs_target::pid_to_str): Change return type.
13750 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13751 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13752 return type.
13753 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13754 (exit_lwp): Update.
13755 (attach_proc_task_lwp_callback, get_detach_signal)
13756 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13757 (linux_nat_target::resume, wait_lwp, stop_callback)
13758 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13759 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13760 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13761 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13762 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13763 type.
13764 (inf_ptrace_target::attach): Update.
13765 (inf_ptrace_target::files_info): Update.
13766 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13767 type.
13768 (go32_nat_target::pid_to_str): Change return type.
13769 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13770 (gnu_nat_target::wait): Update.
13771 (gnu_nat_target::wait): Update.
13772 (gnu_nat_target::resume): Update.
13773 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13774 (fbsd_nat_target::wait): Update.
13775 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13776 type.
13777 (darwin_nat_target::attach): Update.
13778 * corelow.c (class core_target) <pid_to_str>: Change return type.
13779 (core_target::pid_to_str): Change return type.
13780 * target.c (normal_pid_to_str): Change return type.
13781 (default_pid_to_str): Likewise.
13782 (target_pid_to_str): Change return type.
13783 (target_translate_tls_address): Update.
13784 (target_announce_detach): Update.
13785 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13786 return type.
13787 (bsd_uthread_target::pid_to_str): Change return type.
13788 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13789 type.
13790 (bsd_kvm_target::pid_to_str): Change return type.
13791 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13792 return type.
13793 (aix_thread_target::pid_to_str): Change return type.
13794 * target.h (struct target_ops) <pid_to_str>: Change return type.
13795 (target_pid_to_str, normal_pid_to_str): Likewise.
13796 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13797 type.
13798 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13799 type.
13800 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13801 return type.
13802 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13803 type.
13804 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13805 type.
13806 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13807 return type.
13808
13809 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13810
13811 * NEWS: Mention that the new default MI version is 3. Mention
13812 changes to the output of commands and events that deal with
13813 multi-location breakpoints.
13814 * breakpoint.c: Include "mi/mi-out.h".
13815 (print_one_breakpoint): Change output syntax if using MI version
13816 >= 3.
13817 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13818 New.
13819 (mi_multi_location_breakpoint_output_fixed): New.
13820 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13821 (mi_cmd_fix_multi_location_breakpoint_output): New.
13822 (mi_multi_location_breakpoint_output_fixed): New.
13823 * mi/mi-cmds.c (mi_cmds): Register command
13824 -fix-multi-location-breakpoint-output.
13825 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13826 interpreter "mi".
13827
13828 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13829
13830 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13831 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13832 instantiate mi_ui_out based on interpreter name.
13833 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13834 * mi/mi-main.c (mi_load_progress): Likewise.
13835
13836 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13837
13838 * NEWS: Combine separate "New targets" sections for 8.3.
13839
13840 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13841
13842 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13843 (ppcfbsd_init_abi): Install gdbarch
13844 "fetch_tls_load_module_address" and "get_thread_local_address"
13845 methods.
13846
13847 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13848
13849 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13850 (riscv_fbsd_init_abi): Install gdbarch
13851 "fetch_tls_load_module_address" and "get_thread_local_address"
13852 methods.
13853
13854 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13855
13856 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13857 (i386fbsd_init_abi): Install gdbarch
13858 "fetch_tls_load_module_address" and "get_thread_local_address"
13859 methods.
13860
13861 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13862
13863 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13864 (amd64fbsd_init_abi): Install gdbarch
13865 "fetch_tls_load_module_address" and "get_thread_local_address"
13866 methods.
13867
13868 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13869
13870 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13871 (struct fbsd_pspace_data): New type.
13872 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13873 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13874 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13875 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13876 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13877
13878 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13879
13880 * gdbtypes.c (lookup_struct_elt): New function.
13881 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13882 * gdbtypes.h (struct struct_elt): New type.
13883 (lookup_struct_elt): New prototype.
13884
13885 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13886
13887 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13888 remove disabled code block.
13889
13890 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13891
13892 * gdbarch.sh (get_thread_local_address): New method.
13893 * gdbarch.h, gdbarch.c: Regenerate.
13894 * target.c (target_translate_tls_address): Use
13895 gdbarch_get_thread_local_address if present instead of
13896 target::get_thread_local_address.
13897
13898 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13899
13900 * target.h (target::get_thread_local_address): Update comment.
13901
13902 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13903
13904 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13905 objfile->separate_debug_objfile_backlink if not NULL.
13906
13907 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13908
13909 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13910 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13911 (amd64bsd_store_inferior_registers): Likewise.
13912 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13913 Enable segment base registers.
13914 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13915 PT_GETFSBASE and PT_GETGSBASE.
13916 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13917 PT_SETGSBASE.
13918 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13919 segment base registers.
13920 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13921
13922 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13923
13924 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13925 Update calls to i386_target_description to add 'segments'
13926 parameter.
13927 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13928 add segment base registers.
13929 * arch/i386.c (i386_create_target_description): Add 'segments'
13930 parameter to enable segment base registers.
13931 * arch/i386.h (i386_create_target_description): Likewise.
13932 * features/i386/32bit-segments.xml: New file.
13933 * features/i386/32bit-segments.c: Generate.
13934 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13935 call to i386_target_description to add 'segments' parameter.
13936 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13937 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13938 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13939 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13940 if feature is present.
13941 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13942 Add 'segments' parameter to call to i386_target_description.
13943 (i386_target_description): Add 'segments' parameter to enable
13944 segment base registers.
13945 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13946 to call to i386_target_description.
13947 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13948 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13949 Define I386_NUM_REGS.
13950 (i386_target_description): Add 'segments' parameter to enable
13951 segment base registers.
13952
13953 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13954
13955 PR/24325
13956 * source-cache.c: #undef open and close, to avoid unresolved
13957 externals during linking.
13958
13959 2019-03-12 Tom Tromey <tromey@adacore.com>
13960
13961 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13962 const. Add initializers.
13963 (_initialize_remote): Don't initialize ptid globals.
13964
13965 2019-03-12 Pedro Alves <palves@redhat.com>
13966
13967 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13968
13969 2019-03-12 Pedro Alves <palves@redhat.com>
13970
13971 * cp-name-parser.y (main): Remove unused 'len' variable.
13972
13973 2019-03-12 Tom Tromey <tromey@adacore.com>
13974
13975 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13976 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13977
13978 2019-03-12 Tom Tromey <tromey@adacore.com>
13979
13980 * linux-nat.c (iterate_over_lwps): Update.
13981 (stop_callback): Remove parameter.
13982 (stop_wait_callback, detach_callback, resume_set_callback)
13983 (select_singlestep_lwp_callback, set_ignore_sigint)
13984 (status_callback, resumed_callback, resume_clear_callback)
13985 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13986 data parameter.
13987 (linux_nat_target::detach, linux_nat_target::resume)
13988 (linux_stop_and_wait_all_lwps, select_event_lwp)
13989 (linux_nat_filter_event, linux_nat_wait_1)
13990 (linux_nat_target::kill, linux_nat_target::stop)
13991 (linux_nat_target::stop): Update.
13992 (linux_nat_resume_callback): Change type.
13993 (resume_stopped_resumed_lwps, count_events_callback)
13994 (select_event_lwp_callback): Likewise.
13995 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13996 * arm-linux-nat.c (struct update_registers_data): Remove.
13997 (update_registers_callback): Change type.
13998 (arm_linux_insert_hw_breakpoint1): Update.
13999 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14000 parameter.
14001 (x86_linux_dr_set_addr): Update.
14002 (x86_linux_dr_set_control): Update.
14003 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14004 (iterate_over_lwps): Use gdb::function_view.
14005 * nat/aarch64-linux-hw-point.c (struct
14006 aarch64_dr_update_callback_param): Remove.
14007 (debug_reg_change_callback): Change type.
14008 (aarch64_notify_debug_reg_change): Update.
14009 * s390-linux-nat.c (s390_refresh_per_info): Update.
14010
14011 2019-03-11 Tom Tromey <tromey@adacore.com>
14012
14013 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14014 redundant assignment to "this_cu".
14015
14016 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14017
14018 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14019
14020 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14021
14022 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14023 from...
14024 (rank_one_type): ... this.
14025
14026 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14027
14028 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14029 from...
14030 (rank_one_type): ... this.
14031
14032 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14033
14034 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14035 from...
14036 (rank_one_type): ... this.
14037
14038 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14039
14040 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14041 from...
14042 (rank_one_type): ... this.
14043
14044 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14045
14046 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14047 from...
14048 (rank_one_type): ... this.
14049
14050 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14051
14052 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14053 from...
14054 (rank_one_type): ... this.
14055
14056 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14057
14058 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14059 from...
14060 (rank_one_type): ... this.
14061
14062 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14063
14064 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14065 from...
14066 (rank_one_type): ... this.
14067
14068 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14069
14070 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14071 from...
14072 (rank_one_type): ... this.
14073
14074 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14075
14076 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14077 from...
14078 (rank_one_type): ... this.
14079
14080 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14081
14082 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14083 from...
14084 (rank_one_type): ... this.
14085
14086 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14087
14088 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14089 from...
14090 (rank_one_type): ... this.
14091
14092 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14093
14094 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14095 inferior-events' shows the example events.
14096
14097 2019-03-08 Eli Zaretskii <eliz@gnu.org>
14098
14099 Support styling on native MS-Windows console
14100
14101 PR/24315
14102 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14103 on MS-Windows if $TERM is not defined.
14104
14105 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14106
14107 * posix-hdep.c (gdb_console_fputs):
14108 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14109 functions.
14110 * ui-file.h (gdb_console_fputs): Add prototype.
14111
14112 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14113 back to fputs only if the former returns zero.
14114
14115 2019-03-07 Tom Tromey <tom@tromey.com>
14116
14117 * symmisc.c (print_symbol_bcache_statistics): Update.
14118 (print_objfile_statistics): Update.
14119 * symfile.c (allocate_symtab): Update.
14120 * stabsread.c: Don't include bcache.h.
14121 * psymtab.h (struct psymbol_bcache): Don't declare.
14122 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14123 (psymbol_bcache_init, psymbol_bcache_free)
14124 (psymbol_bcache_get_bcache): Don't declare.
14125 * psymtab.c (struct psymbol_bcache): Remove.
14126 (psymtab_storage::psymtab_storage): Update.
14127 (psymtab_storage::~psymtab_storage): Update.
14128 (psymbol_bcache_init, psymbol_bcache_free)
14129 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14130 (add_psymbol_to_bcache): Update.
14131 (allocate_psymtab): Update.
14132 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14133 macro_cache>: No longer pointers.
14134 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14135 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14136 * macrotab.c (macro_bcache): Update.
14137 * macroexp.c: Don't include bcache.h.
14138 * gdbtypes.c (check_types_worklist): Update.
14139 (types_deeply_equal): Remove TRY/CATCH. Update.
14140 * elfread.c (elf_symtab_read): Update.
14141 * dwarf2read.c: Don't include bcache.h.
14142 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14143 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14144 (print_bcache_statistics, bcache_memory_used): Don't declare.
14145 (struct bcache): Move from bcache.c. Add constructor, destructor,
14146 methods. Rename all data members.
14147 * bcache.c (struct bcache): Move to bcache.h.
14148 (bcache::expand_hash_table): Rename from expand_hash_table.
14149 (bcache): Remove.
14150 (bcache::insert): Rename from bcache_full.
14151 (bcache::compare): Rename from bcache_compare.
14152 (bcache_xmalloc): Remove.
14153 (bcache::~bcache): Rename from bcache_xfree.
14154 (bcache::print_statistics): Rename from print_bcache_statistics.
14155 (bcache::memory_used): Rename from bcache_memory_used.
14156
14157 2019-03-07 Pedro Alves <palves@redhat.com>
14158
14159 * infrun.c (normal_stop): Also check for
14160 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14161
14162 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14163
14164 * f-lang.c (value_from_host_double): Moved to...
14165 * value.c (value_from_host_double): ...here.
14166 * value.h (value_from_host_double): Declare.
14167 * guile/scm-math.c (vlscm_convert_typed_number): Use
14168 value_from_host_double.
14169 (vlscm_convert_number): Likewise.
14170 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14171 * python/py-value.c (convert_value_from_python): Likewise.
14172
14173 2019-03-06 Tom Tromey <tom@tromey.com>
14174
14175 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14176
14177 2019-03-06 Tom Tromey <tom@tromey.com>
14178
14179 * utils.h (free_current_contents): Don't declare.
14180 * utils.c (free_current_contents): Remove.
14181
14182 2019-03-06 Tom Tromey <tom@tromey.com>
14183
14184 * top.c (quit_force): Update.
14185 * main.c (captured_command_loop): Update.
14186 * common/new-op.c (operator new): Update.
14187 * common/common-exceptions.c (struct catcher)
14188 <save_cleanup_chain>: Remove member.
14189 (exceptions_state_mc_init): Update.
14190 (exception_try_scope_entry): Return nullptr.
14191 (exception_try_scope_exit, exception_rethrow)
14192 (throw_exception_sjlj, throw_exception_cxx): Update.
14193 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14194 (all_cleanups, do_cleanups, discard_cleanups)
14195 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14196 (restore_cleanups, restore_final_cleanups): Don't declare.
14197 (do_final_cleanups): Remove parameter.
14198 * common/cleanups.c (cleanup_chain, make_cleanup)
14199 (make_cleanup_dtor, all_cleanups, do_cleanups)
14200 (discard_my_cleanups, discard_cleanups)
14201 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14202 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14203 (null_cleanup): Remove.
14204 (do_final_cleanups): Remove parameter.
14205
14206 2019-03-06 Tom Tromey <tom@tromey.com>
14207
14208 * remote.c (remote_target::remote_parse_stop_reply): Use
14209 unique_xmalloc_ptr.
14210
14211 2019-03-06 Tom Tromey <tom@tromey.com>
14212
14213 * stabsread.c (struct stabs_field_info): Rename from field_info.
14214 <list, fnlist>: Add initializers.
14215 <obstack>: New member.
14216 (read_member_functions, read_struct_fields, read_baseclasses):
14217 Allocate on obstack. Don't use cleanups.
14218 (read_one_struct_field, read_member_functions, read_struct_fields)
14219 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14220 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14221 (read_struct_type): Update.
14222
14223 2019-03-06 Tom Tromey <tom@tromey.com>
14224
14225 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14226 * common/filestuff.h (make_cleanup_close): Don't declare.
14227 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14228 Remove.
14229
14230 2019-03-06 Tom Tromey <tom@tromey.com>
14231
14232 * solib-aix.c: Use make_scope_exit.
14233
14234 2019-03-06 Tom Tromey <tom@tromey.com>
14235
14236 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14237 Use make_scope_exit.
14238
14239 2019-03-06 Tom Tromey <tom@tromey.com>
14240
14241 * solib-svr4.c (disable_probes_interface): Remove parameter.
14242 (svr4_handle_solib_event): Use make_scope_exit.
14243
14244 2019-03-06 Tom Tromey <tom@tromey.com>
14245
14246 * remote.c (struct stop_reply_deleter): Remove.
14247 (stop_reply_up): Update.
14248 (struct stop_reply): Derive from notif_event. Don't typedef.
14249 <regcache>: Now a std::vector.
14250 (stop_reply_xfree): Remove.
14251 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14252 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14253 (remote_target::discard_pending_stop_replies): Use delete.
14254 (remote_target::remote_parse_stop_reply): Update.
14255 (remote_target::process_stop_reply): Update.
14256 * remote-notif.h (struct notif_event): Add virtual destructor.
14257 Remove "dtr" member.
14258 (struct notif_client) <alloc_event>: Return a unique_ptr.
14259 (notif_event_xfree): Don't declare.
14260 (notif_event_up): New typedef.
14261 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14262 (notif_event_xfree, do_notif_event_xfree): Remove.
14263 (remote_notif_state_xfree): Update.
14264
14265 2019-03-06 Tom Tromey <tom@tromey.com>
14266
14267 * infrun.c (displaced_step_clear_cleanup): Now a
14268 forward_scope_exit type.
14269 (displaced_step_prepare_throw): Update.
14270 (displaced_step_fixup): Update.
14271
14272 2019-03-06 Tom Tromey <tom@tromey.com>
14273
14274 * inferior.h (class inferior): Update comment.
14275 * gdbthread.h (class thread_info): Update comment.
14276
14277 2019-03-06 Joel Brobecker <brobecker@adacore.com>
14278 Tom Tromey <tom@tromey.com>
14279
14280 * stabsread.h (struct stab_section_list): Remove.
14281 (coffstab_build_psymtabs): Update.
14282 * dbxread.c (symbuf_sections): Now a std::vector.
14283 (sect_idx): New global.
14284 (fill_symbuf): Update.
14285 (coffstab_build_psymtabs): Change type of stabsects parameter.
14286 Update.
14287 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14288 std::vector.
14289 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14290 (coff_locate_sections): Update.
14291 (coff_symfile_read): Remove cleanups. Update.
14292 (init_stringtab): Add storage parameter.
14293 (free_stringtab, free_stringtab_cleanup): Remove.
14294 (init_lineno): Add storage parameter.
14295 (free_linetab, free_linetab_cleanup): Remove.
14296
14297 2019-03-06 Pedro Alves <palves@redhat.com>
14298
14299 * linux-fork.c (fork_info::clobber_regs): Delete.
14300 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14301 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14302 comment. Adjust.
14303 (scoped_switch_fork_info::scoped_switch_fork_info)
14304 (checkpoint_command, linux_fork_context): Adjust
14305 fork_save_infrun_state calls.
14306
14307 2019-03-06 Pedro Alves <palves@redhat.com>
14308
14309 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14310 (inf_has_multiple_threads): Return 'bool' and rewrite using
14311 inferior_info::threads().
14312
14313 2019-03-06 Pedro Alves <palves@redhat.com>
14314
14315 * linux-fork.c: Include <list>.
14316 (fork_list): Now a std::list instance.
14317 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14318 (forks_exist_p, find_last_fork): Adjust.
14319 (new_fork): Delete.
14320 (one_fork_p): New.
14321 (add_fork): Adjust.
14322 (free_fork): Delete, folded into fork_info::~fork_info().
14323 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14324 Adjust.
14325 (init_fork_list): Delete.
14326 (linux_fork_killall, linux_fork_mourn_inferior)
14327 (linux_fork_detach, info_checkpoints_command): Adjust.
14328 (_initialize_linux_fork): No longer call init_fork_list.
14329
14330 2019-03-06 Pedro Alves <palves@redhat.com>
14331
14332 * linux-fork.c (new_fork): New, split out of ...
14333 (add_fork): ... this. Return void. Move "first fork" special
14334 case from here, to ...
14335 (checkpoint_command): ... here.
14336 * linux-linux.h (add_fork): Return void.
14337
14338 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14339
14340 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14341
14342 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14343 Chris January <chris.january@arm.com>
14344 David Lecomber <david.lecomber@arm.com>
14345
14346 * f-exp.y: New token, UNOP_INTRINSIC.
14347 (exp): New pattern using UNOP_INTRINSIC token.
14348 (f77_keywords): Add 'abs' keyword.
14349 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14350 (value_from_host_double): New function.
14351 (evaluate_subexp_f): Support UNOP_ABS.
14352
14353 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14354
14355 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14356 types.
14357
14358 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14359
14360 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14361 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14362 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14363
14364 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14365
14366 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14367
14368 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14369 Chris January <chris.january@arm.com>
14370
14371 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14372 * f-exp.y: Define 'KIND' token.
14373 (exp): New pattern for KIND expressions.
14374 (ptype): Handle types with a kind extension.
14375 (direct_abs_decl): Extend to spot kind extensions.
14376 (f77_keywords): Add 'kind' to the list.
14377 (push_kind_type): New function.
14378 (convert_to_kind_type): New function.
14379 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14380 * parse.c (operator_length_standard): Likewise.
14381 * parser-defs.h (enum type_pieces): Add tp_kind.
14382 * std-operator.def: Add UNOP_KIND.
14383
14384 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14385
14386 * f-exp.y (f_parse): Set yydebug.
14387
14388 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14389
14390 * f-lang.c (evaluate_subexp_f): New function.
14391 (exp_descriptor_f): New global.
14392 (f_language_defn): Use exp_descriptor_f instead of
14393 exp_descriptor_standard.
14394
14395 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14396
14397 * f-exp.y (struct token): Add comments.
14398 (dot_ops): Remove uppercase versions and the end marker.
14399 (f77_keywords): Likewise.
14400 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14401 entries in the dot_ops array are case insensitive, and use
14402 strncasecmp to compare strings. Also some whitespace cleanup in
14403 this area. Similar for the f77_keywords array, except entries in
14404 this list might be case sensitive.
14405
14406 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14407
14408 * f-exp.y (struct f77_boolean_val): Add comments.
14409 (boolean_values): Remove uppercase versions, and end marker.
14410 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14411 and use strncasecmp to achieve case insensitivity. Additionally,
14412 perform whitespace cleanup around this code.
14413
14414 2019-03-06 Tom Tromey <tromey@adacore.com>
14415
14416 * remote-sim.c (gdbsim_target_open): Use result of
14417 gdb_argv::release.
14418
14419 2019-03-06 Richard Bunt <richard.bunt@arm.com>
14420 Dirk Schubert <dirk.schubert@arm.com>
14421 Chris January <chris.january@arm.com>
14422
14423 * eval.c (evaluate_subexp_standard): Call Fortran argument
14424 wrapping logic.
14425 * f-lang.c (struct value): A value which can be passed into a
14426 Fortran function call.
14427 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14428 where appropriate.
14429 (struct type): Value ready for a Fortran function call.
14430 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14431 is needed.
14432 * f-lang.h (fortran_argument_convert): Declaration.
14433 (fortran_preserve_arg_pointer): Declaration.
14434 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14435
14436 2019-03-05 Tom Tromey <tromey@adacore.com>
14437
14438 * python/py-prettyprint.c (print_string_repr): Remove #if.
14439 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14440
14441 2019-03-05 Tom Tromey <tromey@adacore.com>
14442
14443 * target.c (the_dummy_target): Move later. Change type to
14444 "dummy_target".
14445 (initialize_targets): Don't initialize the_dummy_target.
14446
14447 2019-03-05 Tom Tromey <tromey@adacore.com>
14448
14449 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14450 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14451
14452 2019-03-05 Tom Tromey <tromey@adacore.com>
14453
14454 * windows-nat.c (windows_nat_target::attach)
14455 (windows_nat_target::detach): Don't call gdb_flush.
14456 * valprint.c (generic_val_print, val_print, val_print_string):
14457 Don't call gdb_flush.
14458 * utils.c (defaulted_query): Don't call gdb_flush.
14459 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14460 * target.c (target_announce_detach): Don't call gdb_flush.
14461 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14462 * remote.c (extended_remote_target::attach): Don't call
14463 gdb_flush.
14464 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14465 * printcmd.c (do_examine): Don't call gdb_flush.
14466 (info_display_command): Don't call gdb_flush.
14467 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14468 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14469 * memattr.c (info_mem_command): Don't call gdb_flush.
14470 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14471 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14472 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14473 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14474 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14475 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14476 (gnu_nat_target::detach): Don't call gdb_flush.
14477 * f-valprint.c (f_val_print): Don't call gdb_flush.
14478 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14479 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14480 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14481 gdb_flush.
14482 * c-valprint.c (c_val_print): Don't call gdb_flush.
14483 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14484
14485 2019-03-05 Tom Tromey <tromey@adacore.com>
14486
14487 * varobj.c (update_dynamic_varobj_children): Update.
14488 (install_default_visualizer): Use reset, not release.
14489 * value.c (set_internalvar): Update.
14490 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14491 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14492 ATTRIBUTE_UNUSED_RESULT.
14493
14494 2019-03-05 Tom Tromey <tromey@adacore.com>
14495
14496 * remote.c (class scoped_remote_fd) <release>: Add
14497 ATTRIBUTE_UNUSED_RESULT.
14498
14499 2019-03-05 Tom Tromey <tromey@adacore.com>
14500
14501 * macroexp.c (struct macro_buffer) <release>: Add
14502 ATTRIBUTE_UNUSED_RESULT.
14503
14504 2019-03-05 Tom Tromey <tromey@adacore.com>
14505
14506 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14507 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14508 ATTRIBUTE_UNUSED_RESULT.
14509
14510 2019-03-05 Tom Tromey <tromey@adacore.com>
14511
14512 * common/scoped_fd.h (class scoped_fd) <release>: Add
14513 ATTRIBUTE_UNUSED_RESULT.
14514
14515 2019-03-05 Tom Tromey <tromey@adacore.com>
14516
14517 * parser-defs.h (struct parser_state) <release>: Add
14518 ATTRIBUTE_UNUSED_RESULT.
14519
14520 2019-03-05 Tom Tromey <tromey@adacore.com>
14521
14522 * utils.h (class gdb_argv) <release>: Add
14523 ATTRIBUTE_UNUSED_RESULT.
14524 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14525
14526 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14527
14528 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14529 for-loop range, to avoid compiler warnings.
14530
14531 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14532 avoid compiler warnings about unused variables.
14533
14534 * NEWS: Mention end of support for native debugging on MS-Windows
14535 before XP.
14536
14537 PR gdb/24292
14538 * common/netstuff.c:
14539 * gdbserver/gdbreplay.c
14540 * gdbserver/remote-utils.c:
14541 * ser-tcp.c:
14542 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14543 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14544 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14545 'getaddrinfo' and 'freeaddrinfo' were not available before
14546 Windows XP, and mingw.org's MinGW headers by default define
14547 _WIN32_WINNT to 0x500.
14548
14549 2019-03-01 Gary Benson <gbenson@redhat.com>
14550
14551 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14552
14553 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14554 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14555
14556 PR gdb/8527
14557 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14558 set_sigint_trap, clear_sigint_trap.
14559
14560 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14561
14562 * target.c (target_detach): Clear the regcache and the
14563 frame cache.
14564
14565 2019-02-27 Pedro Alves <palves@redhat.com>
14566
14567 * utils.c (set_screen_size): When we cap the height/width sizes,
14568 tweak the corresponding command variable to show "unlimited":
14569
14570 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14571 Pedro Alves <palves@redhat.com>
14572
14573 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14574 before calling rl_set_screen_size.
14575
14576 2019-02-27 Tom Tromey <tromey@adacore.com>
14577
14578 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14579 define.
14580 * python/py-value.c: Remove Python 2.4 workaround.
14581 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14582 workaround.
14583 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14584 Python 2.4 workaround.
14585 * python/python-internal.h: Remove Python 2.4 comment.
14586 (Py_ssize_t): Don't define.
14587 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14588 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14589 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14590 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14591 * python/python.c (do_start_initialization): Remove Python 2.4
14592 workaround.
14593 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14594 (print_children): Remove Python 2.4 workaround.
14595 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14596 workaround.
14597 (CHARBUFFERPROC_NAME): Remove.
14598 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14599 Python 2.4 workaround.
14600
14601 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14602
14603 * NEWS: Note minimum Python version.
14604
14605 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14606
14607 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14608 code from these functions. Remove corresponding ifdefs. Use
14609 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14610 Remove gotos and target of gotos.
14611 (infpy_search_memory): Likewise.
14612
14613 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14614
14615 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14616 (hppa_gdbarch_init): Don't register deleted functions with
14617 gdbarch.
14618
14619 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14620
14621 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14622 (h8300_unwind_sp): Delete.
14623 (h8300_dummy_id): Delete.
14624 (h8300_gdbarch_init): Don't register deleted functions with
14625 gdbarch.
14626
14627 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14628
14629 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14630 (ft32_unwind_pc): Delete.
14631 (ft32_unwind_sp): Delete.
14632 (ft32_gdbarch_init): Don't register deleted functions with
14633 gdbarch.
14634
14635 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14636
14637 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14638 (frv_unwind_pc): Delete.
14639 (frv_unwind_sp): Delete.
14640 (frv_gdbarch_init): Don't register deleted functions with
14641 gdbarch.
14642
14643 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14644
14645 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14646 (riscv_unwind_pc): Delete.
14647 (riscv_unwind_sp): Delete.
14648 (riscv_gdbarch_init): Don't register deleted functions with
14649 gdbarch.
14650
14651 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14652
14653 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14654 (csky_unwind_pc): Delete.
14655 (csky_unwind_sp): Delete.
14656 (csky_gdbarch_init): Don't register deleted functions with
14657 gdbarch.
14658
14659 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14660
14661 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14662 (cris_unwind_pc): Delete.
14663 (cris_unwind_sp): Delete.
14664 (cris_gdbarch_init): Don't register deleted functions with
14665 gdbarch.
14666
14667 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14668
14669 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14670 (bfin_unwind_pc): Delete.
14671 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14672
14673 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14674
14675 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14676 (arm_unwind_pc): Delete.
14677 (arm_unwind_sp): Delete.
14678 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14679
14680 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14681
14682 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14683 (arc_unwind_pc): Delete.
14684 (arc_unwind_sp): Delete.
14685 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14686
14687 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14688
14689 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14690 (alpha_unwind_pc): Delete.
14691 (alpha_gdbarch_init): Don't register deleted functions with
14692 gdbarch.
14693
14694 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14695
14696 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14697 (aarch64_unwind_pc): Delete.
14698 (aarch64_unwind_sp): Delete.
14699 (aarch64_gdbarch_init): Don't register deleted functions with
14700 gdbarch.
14701
14702 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14703
14704 * gdbtypes.c (type_align): Don't consider static members when
14705 computing structure alignment.
14706
14707 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14708
14709 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14710 return 0 for other types.
14711 * arch-utils.c (default_type_align): Always return 0.
14712 * gdbarch.h: Regenerate.
14713 * gdbarch.sh (type_align): Extend comment.
14714 * gdbtypes.c (type_align): Add additional comments, always call
14715 gdbarch_type_align before applying the default rules.
14716 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14717 generic code will then apply a suitable default.
14718 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14719 types, return 0 for other types.
14720
14721 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14722
14723 * NEWS: Create a new section for the next release branch.
14724 Rename the section of the current branch, now that it has
14725 been cut.
14726
14727 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14728
14729 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14730 * version.in: Bump version to 8.3.50.DATE-git.
14731
14732 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14733
14734 * aix-thread.c (ptid_cmp): Remove unused variable.
14735 (get_signaled_thread): Likewise.
14736 (store_regs_user_thread): Likewise.
14737 (store_regs_kernel_thread): Likewise.
14738 (fetch_regs_kernel_thread): Remove shadowed variable.
14739
14740 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14741
14742 * features/riscv/32bit-cpu.xml: Add register numbers.
14743 * features/riscv/32bit-fpu.c: Regenerate.
14744 * features/riscv/32bit-fpu.xml: Add register numbers.
14745 * features/riscv/64bit-cpu.xml: Add register numbers.
14746 * features/riscv/64bit-fpu.c: Regenerate.
14747 * features/riscv/64bit-fpu.xml: Add register numbers.
14748
14749 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14750
14751 * NEWS: Mention two argument form of gdb.Value constructor.
14752 * python/py-value.c (convert_buffer_and_type_to_value): New
14753 function.
14754 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14755 Add support for handling an optional second argument. Call
14756 convert_buffer_and_type_to_value as appropriate.
14757 * python/python-internal.h (Py_buffer_deleter): New struct.
14758 (Py_buffer_up): New typedef.
14759
14760 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14761
14762 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14763 instead of releasing ownership.
14764
14765 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14766
14767 * dwarf2read.c (open_and_init_dwp_file): Call
14768 elf_numsections instead of bfd_count_sections to initialize
14769 dwp_file->num_sections.
14770
14771 2019-02-25 Tom Tromey <tromey@adacore.com>
14772
14773 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14774
14775 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14776
14777 * gcore.in: Add '--readnever' option when invoking GDB.
14778
14779 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14780
14781 * MAINTAINERS: Update my email address.
14782
14783 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14784
14785 * build-id.c (build_id_to_debug_bfd_1): New function.
14786 (build_id_to_debug_bfd): Look for separate debug file in
14787 sysroot.
14788
14789 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14790
14791 * gdbarch.sh: Update the copyright year range that is placed into
14792 generated files.
14793
14794 2019-02-22 Keith Seitz <keiths@redhat.com>
14795
14796 PR symtab/23853
14797 * linespec.c (create_sals_line_offset): Search for the default
14798 symtab's filename instead of its fullname.
14799
14800 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14801
14802 * NEWS: Update style defaults.
14803
14804 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14805
14806 * main.c (captured_main_1): Disable styling in batch mode.
14807
14808 2019-02-20 Tom Tromey <tom@tromey.com>
14809
14810 * symtab.c (symtab_symbol_info): Fix typos.
14811
14812 2019-02-20 Tom Tromey <tromey@adacore.com>
14813
14814 * findcmd.c (_initialize_mem_search): Use upper case for
14815 metasyntactic variables.
14816
14817 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14818
14819 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14820 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14821
14822 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14823
14824 * top.h (source_file_name): Change to std::string.
14825 * top.c (source_file_name): Likewise.
14826 (command_line_input): Adjust.
14827 * cli/cli-script.c (script_from_file): Adjust.
14828
14829 2019-02-19 Tom Tromey <tromey@adacore.com>
14830
14831 * ravenscar-thread.c
14832 (ravenscar_thread_target::update_thread_list): Don't call
14833 ada_build_task_list.
14834 * ada-lang.h (ada_build_task_list): Don't declare.
14835 * ada-tasks.c (struct ada_tasks_inferior_data)
14836 <task_list_valid_p>: Now bool.
14837 (read_known_tasks, ada_task_list_changed)
14838 (ada_tasks_invalidate_inferior_data): Update.
14839 (read_known_tasks_array): Return bool.
14840 (read_known_tasks_list): Likewise.
14841 (read_known_tasks): Return void.
14842 (ada_build_task_list): Now static.
14843
14844 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14845
14846 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14847 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14848
14849 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14850
14851 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14852 variant for ada_tasks_pspace_data_handle and
14853 ada_tasks_inferior_data_handle.
14854 (ada_tasks_pspace_data_cleanup): New function.
14855 (ada_tasks_inferior_data_cleanup): New function.
14856
14857 2019-02-17 Tom Tromey <tom@tromey.com>
14858
14859 * macrotab.h (macro_source_fullname): Return a std::string.
14860 * macrotab.c (macro_include, check_for_redefinition)
14861 (macro_undef, macro_lookup_definition, foreach_macro)
14862 (foreach_macro_in_scope): Update.
14863 (macro_source_fullname): Return a std::string.
14864 * macrocmd.c (show_pp_source_pos): Update.
14865
14866 2019-02-17 Tom Tromey <tom@tromey.com>
14867
14868 * macrocmd.c (show_pp_source_pos): Style the file names.
14869
14870 2019-02-17 Tom Tromey <tom@tromey.com>
14871
14872 PR tui/24197:
14873 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14874
14875 2019-02-17 Tom Tromey <tom@tromey.com>
14876
14877 * ada-lang.c (user_select_syms): Use filtered printing.
14878 * utils.c (wrap_style): New global.
14879 (desired_style): Remove.
14880 (emit_style_escape): Add stream parameter.
14881 (set_output_style, reset_terminal_style, prompt_for_continue):
14882 Update.
14883 (flush_wrap_buffer): Only flush gdb_stdout.
14884 (wrap_here): Set wrap_style.
14885 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14886 treat escape sequences as a character. Change when wrap buffer is
14887 flushed.
14888 (fputs_styled): Do not set the output style when the default is
14889 requested.
14890 * ui-style.h (struct ui_file_style) <is_default>: New method.
14891 * source.c (print_source_lines_base): Emit escape sequences in one
14892 piece.
14893
14894 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14895
14896 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14897 integers and enumeration types.
14898
14899 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14900
14901 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14902 instead of lookup_symbol_in_language
14903 (do_exact_match): New function.
14904 (ada_get_symbol_name_matcher): Return do_exact_match when
14905 doing a verbatim match.
14906
14907 2019-02-15 Tom Tromey <tromey@adacore.com>
14908
14909 * ravenscar-thread.c (ravenscar_thread_target::resume)
14910 (ravenscar_thread_target::wait): Special case wildcard requests.
14911
14912 2019-02-15 Tom Tromey <tromey@adacore.com>
14913
14914 * ravenscar-thread.c (base_ptid): Remove.
14915 (struct ravenscar_thread_target) <close>: New method.
14916 <m_base_ptid>: New member.
14917 <update_inferior_ptid, active_task, task_is_currently_active,
14918 runtime_initialized>: Declare methods.
14919 <ravenscar_thread_target>: Add constructor.
14920 (ravenscar_thread_target::task_is_currently_active)
14921 (ravenscar_thread_target::update_inferior_ptid)
14922 (ravenscar_runtime_initialized): Rename. Now methods.
14923 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14924 (ravenscar_thread_target::update_thread_list): Update.
14925 (ravenscar_thread_target::active_task): Now method.
14926 (ravenscar_thread_target::store_registers)
14927 (ravenscar_thread_target::prepare_to_store)
14928 (ravenscar_thread_target::prepare_to_store)
14929 (ravenscar_thread_target::mourn_inferior): Update.
14930 (ravenscar_inferior_created): Use "new" to create target.
14931 (ravenscar_thread_target::get_ada_task_ptid): Update.
14932 (_initialize_ravenscar): Don't initialize base_ptid.
14933 (ravenscar_ops): Remove global.
14934
14935 2019-02-15 Tom Tromey <tromey@adacore.com>
14936
14937 * target.h (push_target): Declare new overload.
14938 * target.c (push_target): New overload, taking an rvalue reference.
14939 * remote.c (remote_target::open_1): Use push_target overload.
14940 * corelow.c (core_target_open): Use push_target overload.
14941
14942 2019-02-15 Tom Tromey <tromey@adacore.com>
14943
14944 * ravenscar-thread.c (is_ravenscar_task)
14945 (ravenscar_task_is_currently_active): Return bool.
14946 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14947 (_initialize_ravenscar): Remove "(void)".
14948 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14949 Return bool.
14950
14951 2019-02-15 Tom Tromey <tromey@adacore.com>
14952
14953 * ravenscar-thread.c (ravenscar_runtime_initializer)
14954 (has_ravenscar_runtime, get_running_thread_id)
14955 (ravenscar_thread_target::resume): Fix indentation.
14956
14957 2019-02-15 Tom Tromey <tromey@adacore.com>
14958
14959 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14960 from ravenscar_arch_ops.
14961 (sparc_ravenscar_ops::fetch_registers)
14962 (sparc_ravenscar_ops::store_registers): Now methods.
14963 (sparc_ravenscar_prepare_to_store): Remove.
14964 (sparc_ravenscar_ops): Redefine.
14965 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14966 methods and destructor. Remove members.
14967 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14968 (ravenscar_thread_target::store_registers)
14969 (ravenscar_thread_target::prepare_to_store): Update.
14970 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14971 Remove.
14972 (struct ppc_ravenscar_powerpc_ops): Derive from
14973 ravenscar_arch_ops.
14974 (ppc_ravenscar_powerpc_ops::fetch_registers)
14975 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14976 (ppc_ravenscar_powerpc_ops): Redefine.
14977 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14978 (ppc_ravenscar_e500_ops::fetch_registers)
14979 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14980 (ppc_ravenscar_e500_ops): Redefine.
14981 * aarch64-ravenscar-thread.c
14982 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14983 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14984 (aarch64_ravenscar_fetch_registers)
14985 (aarch64_ravenscar_store_registers): Now methods.
14986 (aarch64_ravenscar_ops): Redefine.
14987
14988 2019-02-15 Tom Tromey <tromey@adacore.com>
14989
14990 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14991 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14992 (ravenscar_thread_target::stopped_by_watchpoint)
14993 (ravenscar_thread_target::stopped_data_address)
14994 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14995
14996 2019-02-15 Tom Tromey <tromey@adacore.com>
14997
14998 * ravenscar-thread.c: Fix some typos.
14999
15000 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15001 Tom Tromey <tromey@adacore.com>
15002
15003 * ada-lang.c (ada_exception_sal): Change addr_string to a
15004 std::string.
15005 (create_ada_exception_catchpoint): Update.
15006
15007 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15008 Tom Tromey <tromey@adacore.com>
15009
15010 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15011 (bp_location_ops): Remove.
15012 (base_breakpoint_allocate_location): Update.
15013 (free_bp_location): Update.
15014 * ada-lang.c (class ada_catchpoint_location)
15015 <ada_catchpoint_location>: Remove ops parameter.
15016 (ada_catchpoint_location_dtor): Remove.
15017 (ada_catchpoint_location_ops): Remove.
15018 (allocate_location_exception): Update.
15019 * breakpoint.h (struct bp_location_ops): Remove.
15020 (class bp_location) <bp_location>: Remove bp_location_ops
15021 parameter.
15022 <~bp_location>: Add destructor.
15023 <ops>: Remove.
15024
15025 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15026 Pedro Alves <palves@redhat.com>
15027
15028 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15029 'PATH_MAX'.
15030
15031 2019-02-14 David Michael <fedora.dm0@gmail.com>
15032 Samuel Thibault <samuel.thibault@gnu.org>
15033 Thomas Schwinge <thomas@codesourcery.com>
15034
15035 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15036 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15037
15038 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15039
15040 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15041 (check_empty): Use "const char *".
15042
15043 * gnu-nat.c (gnu_nat_target::detach): Instead of
15044 'detach_inferior (pid)' call
15045 'detach_inferior (find_inferior_pid (pid))'.
15046
15047 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15048 'nat/fork-inferior.o'.
15049 * gnu-nat.c: #include "nat/fork-inferior.h".
15050
15051 * gnu-nat.c (gnu_nat_target::detach): Instead of
15052 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15053 * gnu-nat.h: #include "inf-child.h".
15054 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15055 'i386_gnu_nat_target::fetch_registers'.
15056 (gnu_store_registers): Rename/move to
15057 'i386_gnu_nat_target::store_registers'.
15058
15059 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15060 * gnu-nat.h (mach_thread_info): New function.
15061 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15062
15063 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15064
15065 2019-02-14 Frederic Konrad <konrad@adacore.com>
15066
15067 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15068
15069 2019-02-14 Joel Brobecker <brobecker@adacore.com>
15070
15071 * windows-nat.c (windows_add_thread): Add new parameter
15072 "main_thread_p" with default value set to false. Update
15073 function documentation as well as all callers.
15074 (windows_delete_thread): Likewise.
15075 (fake_create_process): Update call to windows_add_thread.
15076 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15077 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15078 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15079 call to windows_delete_thread.
15080
15081 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15082
15083 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15084
15085 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15086
15087 * symfile.c (find_separate_debug_file): Use canonical path of
15088 sysroot with child_path instead of gdb_sysroot if it is valid.
15089
15090 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15091
15092 * symfile.c (find_separate_debug_file): Use child_path to
15093 determine if an object file is under a sysroot.
15094
15095 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15096
15097 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15098 unittests/child-path-selftests.c.
15099 * common/pathstuff.c (child_path): New function.
15100 * common/pathstuff.h (child_path): New prototype.
15101 * unittests/child-path-selftests.c: New file.
15102
15103 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15104
15105 * symfile.c (find_separate_debug_file): Look for separate debug
15106 files in debug directories under the sysroot.
15107
15108 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15109
15110 * symtab.h (struct minimal_symbol data_p): New const method.
15111 (struct minimal_symbol text_p): Likewise.
15112 * symtab.c (output_source_filename): Use file name style
15113 to print file name.
15114 (print_symbol_info): Likewise.
15115 (print_msymbol_info): Use address style to print addresses.
15116 Use function name style to print executable text symbols.
15117 (expand_symtab_containing_pc): Use data_p.
15118 (find_pc_sect_compunit_symtab): Likewise.
15119
15120 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15121
15122 * breakpoint.c (describe_other_breakpoints): Use address style
15123 to print addresses.
15124 (say_where): Likewise.
15125
15126 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15127
15128 * ada-typeprint.c (print_func_type): Print function name
15129 style to print function name.
15130 * c-typeprint.c (c_print_type_1): Likewise.
15131
15132 2019-02-11 Alan Hayward <alan.hayward@arm.com>
15133
15134 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15135 for execve.
15136
15137 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15138
15139 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15140 type_stack.
15141
15142 2019-02-10 Joel Brobecker <brobecker@adacore.com>
15143
15144 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15145 TYPE_CODE_REF types.
15146
15147 2019-02-08 Jim Wilson <jimw@sifive.com>
15148
15149 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15150 (riscv_linux_fregset): New.
15151 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15152
15153 2019-02-07 Tom Tromey <tom@tromey.com>
15154
15155 * thread.c (thread_cancel_execution_command): Update.
15156 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15157 methods.
15158 (struct thread_fsm_ops): Remove.
15159 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15160 (thread_fsm_should_stop, thread_fsm_return_value)
15161 (thread_fsm_set_finished, thread_fsm_finished_p)
15162 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15163 Don't declare.
15164 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15165 * infrun.c (clear_proceed_status_thread)
15166 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15167 (print_stop_event): Update.
15168 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15169 Add constructor.
15170 (step_command_fsm_ops): Remove.
15171 (new_step_command_fsm): Remove.
15172 (step_1): Update.
15173 (step_command_fsm::should_stop): Rename from
15174 step_command_fsm_should_stop.
15175 (step_command_fsm::clean_up): Rename from
15176 step_command_fsm_clean_up.
15177 (step_command_fsm::do_async_reply_reason): Rename from
15178 step_command_fsm_async_reply_reason.
15179 (struct until_next_fsm): Inherit from thread_fsm. Add
15180 constructor.
15181 (until_next_fsm_ops): Remove.
15182 (new_until_next_fsm): Remove.
15183 (until_next_fsm::should_stop): Rename from
15184 until_next_fsm_should_stop.
15185 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15186 (until_next_fsm::do_async_reply_reason): Rename from
15187 until_next_fsm_async_reply_reason.
15188 (struct finish_command_fsm): Inherit from thread_fsm. Add
15189 constructor. Change type of breakpoint.
15190 (finish_command_fsm_ops): Remove.
15191 (new_finish_command_fsm): Remove.
15192 (finish_command_fsm::should_stop): Rename from
15193 finish_command_fsm_should_stop.
15194 (finish_command_fsm::clean_up): Rename from
15195 finish_command_fsm_clean_up.
15196 (finish_command_fsm::return_value): Rename from
15197 finish_command_fsm_return_value.
15198 (finish_command_fsm::do_async_reply_reason): Rename from
15199 finish_command_fsm_async_reply_reason.
15200 (finish_command): Update.
15201 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15202 Add constructor.
15203 (call_thread_fsm_ops): Remove.
15204 (call_thread_fsm::call_thread_fsm): Rename from
15205 new_call_thread_fsm.
15206 (call_thread_fsm::should_stop): Rename from
15207 call_thread_fsm_should_stop.
15208 (call_thread_fsm::should_notify_stop): Rename from
15209 call_thread_fsm_should_notify_stop.
15210 (run_inferior_call, call_function_by_hand_dummy): Update.
15211 * cli/cli-interp.c (should_print_stop_to_console): Update.
15212 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15213 Add constructor. Change type of location_breakpoint,
15214 caller_breakpoint.
15215 (until_break_fsm_ops): Remove.
15216 (new_until_break_fsm): Remove.
15217 (until_break_fsm::should_stop): Rename from
15218 until_break_fsm_should_stop.
15219 (until_break_fsm::clean_up): Rename from
15220 until_break_fsm_clean_up.
15221 (until_break_fsm::do_async_reply_reason): Rename from
15222 until_break_fsm_async_reply_reason.
15223 (until_break_command): Update.
15224 * thread-fsm.c: Remove.
15225 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15226
15227 2019-02-07 Tom Tromey <tom@tromey.com>
15228
15229 * yy-remap.h: Add include guard.
15230 * xtensa-tdep.h: Add include guard.
15231 * xcoffread.h: Rename include guard.
15232 * varobj-iter.h: Add include guard.
15233 * tui/tui.h: Rename include guard.
15234 * tui/tui-winsource.h: Rename include guard.
15235 * tui/tui-wingeneral.h: Rename include guard.
15236 * tui/tui-windata.h: Rename include guard.
15237 * tui/tui-win.h: Rename include guard.
15238 * tui/tui-stack.h: Rename include guard.
15239 * tui/tui-source.h: Rename include guard.
15240 * tui/tui-regs.h: Rename include guard.
15241 * tui/tui-out.h: Rename include guard.
15242 * tui/tui-layout.h: Rename include guard.
15243 * tui/tui-io.h: Rename include guard.
15244 * tui/tui-hooks.h: Rename include guard.
15245 * tui/tui-file.h: Rename include guard.
15246 * tui/tui-disasm.h: Rename include guard.
15247 * tui/tui-data.h: Rename include guard.
15248 * tui/tui-command.h: Rename include guard.
15249 * tic6x-tdep.h: Add include guard.
15250 * target/waitstatus.h: Rename include guard.
15251 * target/wait.h: Rename include guard.
15252 * target/target.h: Rename include guard.
15253 * target/resume.h: Rename include guard.
15254 * target-float.h: Rename include guard.
15255 * stabsread.h: Add include guard.
15256 * rs6000-tdep.h: Add include guard.
15257 * riscv-fbsd-tdep.h: Add include guard.
15258 * regformats/regdef.h: Rename include guard.
15259 * record.h: Rename include guard.
15260 * python/python.h: Rename include guard.
15261 * python/python-internal.h: Rename include guard.
15262 * python/py-stopevent.h: Rename include guard.
15263 * python/py-ref.h: Rename include guard.
15264 * python/py-record.h: Rename include guard.
15265 * python/py-record-full.h: Rename include guard.
15266 * python/py-record-btrace.h: Rename include guard.
15267 * python/py-instruction.h: Rename include guard.
15268 * python/py-events.h: Rename include guard.
15269 * python/py-event.h: Rename include guard.
15270 * procfs.h: Add include guard.
15271 * proc-utils.h: Add include guard.
15272 * p-lang.h: Add include guard.
15273 * or1k-tdep.h: Rename include guard.
15274 * observable.h: Rename include guard.
15275 * nto-tdep.h: Rename include guard.
15276 * nat/x86-linux.h: Rename include guard.
15277 * nat/x86-linux-dregs.h: Rename include guard.
15278 * nat/x86-gcc-cpuid.h: Add include guard.
15279 * nat/x86-dregs.h: Rename include guard.
15280 * nat/x86-cpuid.h: Rename include guard.
15281 * nat/ppc-linux.h: Rename include guard.
15282 * nat/mips-linux-watch.h: Rename include guard.
15283 * nat/linux-waitpid.h: Rename include guard.
15284 * nat/linux-ptrace.h: Rename include guard.
15285 * nat/linux-procfs.h: Rename include guard.
15286 * nat/linux-osdata.h: Rename include guard.
15287 * nat/linux-nat.h: Rename include guard.
15288 * nat/linux-namespaces.h: Rename include guard.
15289 * nat/linux-btrace.h: Rename include guard.
15290 * nat/glibc_thread_db.h: Rename include guard.
15291 * nat/gdb_thread_db.h: Rename include guard.
15292 * nat/gdb_ptrace.h: Rename include guard.
15293 * nat/fork-inferior.h: Rename include guard.
15294 * nat/amd64-linux-siginfo.h: Rename include guard.
15295 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15296 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15297 * nat/aarch64-linux.h: Rename include guard.
15298 * nat/aarch64-linux-hw-point.h: Rename include guard.
15299 * mn10300-tdep.h: Add include guard.
15300 * mips-linux-tdep.h: Add include guard.
15301 * mi/mi-parse.h: Rename include guard.
15302 * mi/mi-out.h: Rename include guard.
15303 * mi/mi-main.h: Rename include guard.
15304 * mi/mi-interp.h: Rename include guard.
15305 * mi/mi-getopt.h: Rename include guard.
15306 * mi/mi-console.h: Rename include guard.
15307 * mi/mi-common.h: Rename include guard.
15308 * mi/mi-cmds.h: Rename include guard.
15309 * mi/mi-cmd-break.h: Rename include guard.
15310 * m2-lang.h: Add include guard.
15311 * location.h: Rename include guard.
15312 * linux-record.h: Rename include guard.
15313 * linux-nat.h: Add include guard.
15314 * linux-fork.h: Add include guard.
15315 * i386-darwin-tdep.h: Rename include guard.
15316 * hppa-linux-offsets.h: Add include guard.
15317 * guile/guile.h: Rename include guard.
15318 * guile/guile-internal.h: Rename include guard.
15319 * gnu-nat.h: Rename include guard.
15320 * gdb-stabs.h: Rename include guard.
15321 * frv-tdep.h: Add include guard.
15322 * f-lang.h: Add include guard.
15323 * event-loop.h: Add include guard.
15324 * darwin-nat.h: Rename include guard.
15325 * cp-abi.h: Rename include guard.
15326 * config/sparc/nm-sol2.h: Rename include guard.
15327 * config/nm-nto.h: Rename include guard.
15328 * config/nm-linux.h: Add include guard.
15329 * config/i386/nm-i386gnu.h: Rename include guard.
15330 * config/djgpp/nl_types.h: Rename include guard.
15331 * config/djgpp/langinfo.h: Rename include guard.
15332 * compile/gcc-cp-plugin.h: Add include guard.
15333 * compile/gcc-c-plugin.h: Add include guard.
15334 * compile/compile.h: Rename include guard.
15335 * compile/compile-object-run.h: Rename include guard.
15336 * compile/compile-object-load.h: Rename include guard.
15337 * compile/compile-internal.h: Rename include guard.
15338 * compile/compile-cplus.h: Rename include guard.
15339 * compile/compile-c.h: Rename include guard.
15340 * common/xml-utils.h: Rename include guard.
15341 * common/x86-xstate.h: Rename include guard.
15342 * common/version.h: Rename include guard.
15343 * common/vec.h: Rename include guard.
15344 * common/tdesc.h: Rename include guard.
15345 * common/selftest.h: Rename include guard.
15346 * common/scoped_restore.h: Rename include guard.
15347 * common/scoped_mmap.h: Rename include guard.
15348 * common/scoped_fd.h: Rename include guard.
15349 * common/safe-iterator.h: Rename include guard.
15350 * common/run-time-clock.h: Rename include guard.
15351 * common/refcounted-object.h: Rename include guard.
15352 * common/queue.h: Rename include guard.
15353 * common/ptid.h: Rename include guard.
15354 * common/print-utils.h: Rename include guard.
15355 * common/preprocessor.h: Rename include guard.
15356 * common/pathstuff.h: Rename include guard.
15357 * common/observable.h: Rename include guard.
15358 * common/netstuff.h: Rename include guard.
15359 * common/job-control.h: Rename include guard.
15360 * common/host-defs.h: Rename include guard.
15361 * common/gdb_wait.h: Rename include guard.
15362 * common/gdb_vecs.h: Rename include guard.
15363 * common/gdb_unlinker.h: Rename include guard.
15364 * common/gdb_unique_ptr.h: Rename include guard.
15365 * common/gdb_tilde_expand.h: Rename include guard.
15366 * common/gdb_sys_time.h: Rename include guard.
15367 * common/gdb_string_view.h: Rename include guard.
15368 * common/gdb_splay_tree.h: Rename include guard.
15369 * common/gdb_setjmp.h: Rename include guard.
15370 * common/gdb_ref_ptr.h: Rename include guard.
15371 * common/gdb_optional.h: Rename include guard.
15372 * common/gdb_locale.h: Rename include guard.
15373 * common/gdb_assert.h: Rename include guard.
15374 * common/filtered-iterator.h: Rename include guard.
15375 * common/filestuff.h: Rename include guard.
15376 * common/fileio.h: Rename include guard.
15377 * common/environ.h: Rename include guard.
15378 * common/common-utils.h: Rename include guard.
15379 * common/common-types.h: Rename include guard.
15380 * common/common-regcache.h: Rename include guard.
15381 * common/common-inferior.h: Rename include guard.
15382 * common/common-gdbthread.h: Rename include guard.
15383 * common/common-exceptions.h: Rename include guard.
15384 * common/common-defs.h: Rename include guard.
15385 * common/common-debug.h: Rename include guard.
15386 * common/cleanups.h: Rename include guard.
15387 * common/buffer.h: Rename include guard.
15388 * common/btrace-common.h: Rename include guard.
15389 * common/break-common.h: Rename include guard.
15390 * cli/cli-utils.h: Rename include guard.
15391 * cli/cli-style.h: Rename include guard.
15392 * cli/cli-setshow.h: Rename include guard.
15393 * cli/cli-script.h: Rename include guard.
15394 * cli/cli-interp.h: Rename include guard.
15395 * cli/cli-decode.h: Rename include guard.
15396 * cli/cli-cmds.h: Rename include guard.
15397 * charset-list.h: Add include guard.
15398 * buildsym-legacy.h: Rename include guard.
15399 * bfin-tdep.h: Add include guard.
15400 * ax.h: Rename include guard.
15401 * arm-linux-tdep.h: Add include guard.
15402 * arm-fbsd-tdep.h: Add include guard.
15403 * arch/xtensa.h: Rename include guard.
15404 * arch/tic6x.h: Add include guard.
15405 * arch/i386.h: Add include guard.
15406 * arch/arm.h: Rename include guard.
15407 * arch/arm-linux.h: Rename include guard.
15408 * arch/arm-get-next-pcs.h: Rename include guard.
15409 * arch/amd64.h: Add include guard.
15410 * arch/aarch64-insn.h: Rename include guard.
15411 * arch-utils.h: Rename include guard.
15412 * annotate.h: Add include guard.
15413 * amd64-darwin-tdep.h: Rename include guard.
15414 * aarch64-linux-tdep.h: Add include guard.
15415 * aarch64-fbsd-tdep.h: Add include guard.
15416 * aarch32-linux-nat.h: Add include guard.
15417
15418 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15419
15420 * macrotab.c (macro_define_internal): New function that
15421 factorizes macro_define_object_internal and macro_define_function
15422 code.
15423 (macro_define_object_internal): Use macro_define_internal.
15424 (macro_define_function): Likewise.
15425
15426 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15427
15428 * macrocmd.c (extract_identifier): Return
15429 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15430 callers.
15431
15432 2019-02-06 John Baldwin <jhb@FreeBSD.org>
15433
15434 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15435
15436 2019-02-05 Tom Tromey <tom@tromey.com>
15437
15438 * target.c (target_stack::unpush): Move assertion earlier.
15439
15440 2019-01-30 Tom Tromey <tom@tromey.com>
15441
15442 PR python/23615:
15443 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15444 (gdbpy_parse_and_eval): Likewise.
15445 * python/python-internal.h (gdbpy_allow_threads): New class.
15446
15447 2019-01-28 John Baldwin <jhb@FreeBSD.org>
15448
15449 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15450 (aarch64_fbsd_fpregmap): Move earlier.
15451 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15452 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15453 instead of individual calls to trad_frame_set_reg_addr.
15454 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15455 earlier.
15456 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15457 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15458 instead of individual calls to trad_frame_set_reg_addr.
15459
15460 2019-01-28 Alan Hayward <alan.hayward@arm.com>
15461
15462 * CONTRIBUTE: Replace contribution list with wiki link.
15463
15464 2019-01-25 Tom Tromey <tom@tromey.com>
15465
15466 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15467
15468 2019-01-25 Tom Tromey <tom@tromey.com>
15469
15470 * xtensa-linux-nat.c: Fix common/ includes.
15471 * xml-support.h: Fix common/ includes.
15472 * xml-support.c: Fix common/ includes.
15473 * x86-linux-nat.c: Fix common/ includes.
15474 * windows-nat.c: Fix common/ includes.
15475 * varobj.h: Fix common/ includes.
15476 * varobj.c: Fix common/ includes.
15477 * value.c: Fix common/ includes.
15478 * valops.c: Fix common/ includes.
15479 * utils.c: Fix common/ includes.
15480 * unittests/xml-utils-selftests.c: Fix common/ includes.
15481 * unittests/utils-selftests.c: Fix common/ includes.
15482 * unittests/unpack-selftests.c: Fix common/ includes.
15483 * unittests/tracepoint-selftests.c: Fix common/ includes.
15484 * unittests/style-selftests.c: Fix common/ includes.
15485 * unittests/string_view-selftests.c: Fix common/ includes.
15486 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15487 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15488 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15489 * unittests/rsp-low-selftests.c: Fix common/ includes.
15490 * unittests/parse-connection-spec-selftests.c: Fix common/
15491 includes.
15492 * unittests/optional-selftests.c: Fix common/ includes.
15493 * unittests/offset-type-selftests.c: Fix common/ includes.
15494 * unittests/observable-selftests.c: Fix common/ includes.
15495 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15496 * unittests/memrange-selftests.c: Fix common/ includes.
15497 * unittests/memory-map-selftests.c: Fix common/ includes.
15498 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15499 * unittests/function-view-selftests.c: Fix common/ includes.
15500 * unittests/environ-selftests.c: Fix common/ includes.
15501 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15502 * unittests/common-utils-selftests.c: Fix common/ includes.
15503 * unittests/cli-utils-selftests.c: Fix common/ includes.
15504 * unittests/array-view-selftests.c: Fix common/ includes.
15505 * ui-file.c: Fix common/ includes.
15506 * tui/tui-io.c: Fix common/ includes.
15507 * tracepoint.h: Fix common/ includes.
15508 * tracepoint.c: Fix common/ includes.
15509 * tracefile-tfile.c: Fix common/ includes.
15510 * top.h: Fix common/ includes.
15511 * top.c: Fix common/ includes.
15512 * thread.c: Fix common/ includes.
15513 * target/waitstatus.h: Fix common/ includes.
15514 * target/waitstatus.c: Fix common/ includes.
15515 * target.h: Fix common/ includes.
15516 * target.c: Fix common/ includes.
15517 * target-memory.c: Fix common/ includes.
15518 * target-descriptions.c: Fix common/ includes.
15519 * symtab.h: Fix common/ includes.
15520 * symfile.c: Fix common/ includes.
15521 * stap-probe.c: Fix common/ includes.
15522 * spu-linux-nat.c: Fix common/ includes.
15523 * sparc-nat.c: Fix common/ includes.
15524 * source.c: Fix common/ includes.
15525 * solib.c: Fix common/ includes.
15526 * solib-target.c: Fix common/ includes.
15527 * ser-unix.c: Fix common/ includes.
15528 * ser-tcp.c: Fix common/ includes.
15529 * ser-pipe.c: Fix common/ includes.
15530 * ser-base.c: Fix common/ includes.
15531 * selftest-arch.c: Fix common/ includes.
15532 * s12z-tdep.c: Fix common/ includes.
15533 * rust-exp.y: Fix common/ includes.
15534 * rs6000-aix-tdep.c: Fix common/ includes.
15535 * riscv-tdep.c: Fix common/ includes.
15536 * remote.c: Fix common/ includes.
15537 * remote-notif.h: Fix common/ includes.
15538 * remote-fileio.h: Fix common/ includes.
15539 * remote-fileio.c: Fix common/ includes.
15540 * regcache.h: Fix common/ includes.
15541 * regcache.c: Fix common/ includes.
15542 * record-btrace.c: Fix common/ includes.
15543 * python/python.c: Fix common/ includes.
15544 * python/py-type.c: Fix common/ includes.
15545 * python/py-inferior.c: Fix common/ includes.
15546 * progspace.h: Fix common/ includes.
15547 * producer.c: Fix common/ includes.
15548 * procfs.c: Fix common/ includes.
15549 * proc-api.c: Fix common/ includes.
15550 * printcmd.c: Fix common/ includes.
15551 * ppc-linux-nat.c: Fix common/ includes.
15552 * parser-defs.h: Fix common/ includes.
15553 * osdata.c: Fix common/ includes.
15554 * obsd-nat.c: Fix common/ includes.
15555 * nat/x86-linux.c: Fix common/ includes.
15556 * nat/x86-linux-dregs.c: Fix common/ includes.
15557 * nat/x86-dregs.h: Fix common/ includes.
15558 * nat/x86-dregs.c: Fix common/ includes.
15559 * nat/ppc-linux.c: Fix common/ includes.
15560 * nat/mips-linux-watch.h: Fix common/ includes.
15561 * nat/mips-linux-watch.c: Fix common/ includes.
15562 * nat/linux-waitpid.c: Fix common/ includes.
15563 * nat/linux-ptrace.h: Fix common/ includes.
15564 * nat/linux-ptrace.c: Fix common/ includes.
15565 * nat/linux-procfs.c: Fix common/ includes.
15566 * nat/linux-personality.c: Fix common/ includes.
15567 * nat/linux-osdata.c: Fix common/ includes.
15568 * nat/linux-namespaces.c: Fix common/ includes.
15569 * nat/linux-btrace.h: Fix common/ includes.
15570 * nat/linux-btrace.c: Fix common/ includes.
15571 * nat/fork-inferior.c: Fix common/ includes.
15572 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15573 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15574 * nat/aarch64-linux.c: Fix common/ includes.
15575 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15576 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15577 * namespace.h: Fix common/ includes.
15578 * mips-linux-tdep.c: Fix common/ includes.
15579 * minsyms.c: Fix common/ includes.
15580 * mi/mi-parse.h: Fix common/ includes.
15581 * mi/mi-main.c: Fix common/ includes.
15582 * mi/mi-cmd-env.c: Fix common/ includes.
15583 * memrange.h: Fix common/ includes.
15584 * memattr.c: Fix common/ includes.
15585 * maint.h: Fix common/ includes.
15586 * maint.c: Fix common/ includes.
15587 * main.c: Fix common/ includes.
15588 * machoread.c: Fix common/ includes.
15589 * location.c: Fix common/ includes.
15590 * linux-thread-db.c: Fix common/ includes.
15591 * linux-nat.c: Fix common/ includes.
15592 * linux-fork.c: Fix common/ includes.
15593 * inline-frame.c: Fix common/ includes.
15594 * infrun.c: Fix common/ includes.
15595 * inflow.c: Fix common/ includes.
15596 * inferior.h: Fix common/ includes.
15597 * inferior.c: Fix common/ includes.
15598 * infcmd.c: Fix common/ includes.
15599 * inf-ptrace.c: Fix common/ includes.
15600 * inf-child.c: Fix common/ includes.
15601 * ia64-linux-nat.c: Fix common/ includes.
15602 * i387-tdep.c: Fix common/ includes.
15603 * i386-tdep.c: Fix common/ includes.
15604 * i386-linux-tdep.c: Fix common/ includes.
15605 * i386-linux-nat.c: Fix common/ includes.
15606 * i386-go32-tdep.c: Fix common/ includes.
15607 * i386-fbsd-tdep.c: Fix common/ includes.
15608 * i386-fbsd-nat.c: Fix common/ includes.
15609 * guile/scm-type.c: Fix common/ includes.
15610 * guile/guile.c: Fix common/ includes.
15611 * go32-nat.c: Fix common/ includes.
15612 * gnu-nat.c: Fix common/ includes.
15613 * gdbthread.h: Fix common/ includes.
15614 * gdbarch-selftests.c: Fix common/ includes.
15615 * gdb_usleep.c: Fix common/ includes.
15616 * gdb_select.h: Fix common/ includes.
15617 * gdb_bfd.c: Fix common/ includes.
15618 * gcore.c: Fix common/ includes.
15619 * fork-child.c: Fix common/ includes.
15620 * findvar.c: Fix common/ includes.
15621 * fbsd-nat.c: Fix common/ includes.
15622 * event-top.c: Fix common/ includes.
15623 * event-loop.c: Fix common/ includes.
15624 * dwarf2read.c: Fix common/ includes.
15625 * dwarf2loc.c: Fix common/ includes.
15626 * dwarf2-frame.c: Fix common/ includes.
15627 * dwarf-index-cache.c: Fix common/ includes.
15628 * dtrace-probe.c: Fix common/ includes.
15629 * disasm-selftests.c: Fix common/ includes.
15630 * defs.h: Fix common/ includes.
15631 * csky-tdep.c: Fix common/ includes.
15632 * cp-valprint.c: Fix common/ includes.
15633 * cp-support.h: Fix common/ includes.
15634 * cp-support.c: Fix common/ includes.
15635 * corelow.c: Fix common/ includes.
15636 * completer.h: Fix common/ includes.
15637 * completer.c: Fix common/ includes.
15638 * compile/compile.c: Fix common/ includes.
15639 * compile/compile-loc2c.c: Fix common/ includes.
15640 * compile/compile-cplus-types.c: Fix common/ includes.
15641 * compile/compile-cplus-symbols.c: Fix common/ includes.
15642 * command.h: Fix common/ includes.
15643 * cli/cli-dump.c: Fix common/ includes.
15644 * cli/cli-cmds.c: Fix common/ includes.
15645 * charset.c: Fix common/ includes.
15646 * build-id.c: Fix common/ includes.
15647 * btrace.h: Fix common/ includes.
15648 * btrace.c: Fix common/ includes.
15649 * breakpoint.h: Fix common/ includes.
15650 * breakpoint.c: Fix common/ includes.
15651 * ax.h:
15652 (enum agent_op): Fix common/ includes.
15653 * ax-general.c (struct aop_map): Fix common/ includes.
15654 * ax-gdb.c: Fix common/ includes.
15655 * auxv.c: Fix common/ includes.
15656 * auto-load.c: Fix common/ includes.
15657 * arm-tdep.c: Fix common/ includes.
15658 * arch/riscv.c: Fix common/ includes.
15659 * arch/ppc-linux-common.c: Fix common/ includes.
15660 * arch/i386.c: Fix common/ includes.
15661 * arch/arm.c: Fix common/ includes.
15662 * arch/arm-linux.c: Fix common/ includes.
15663 * arch/arm-get-next-pcs.c: Fix common/ includes.
15664 * arch/amd64.c: Fix common/ includes.
15665 * arch/aarch64.c: Fix common/ includes.
15666 * arch/aarch64-insn.c: Fix common/ includes.
15667 * arch-utils.c: Fix common/ includes.
15668 * amd64-windows-tdep.c: Fix common/ includes.
15669 * amd64-tdep.c: Fix common/ includes.
15670 * amd64-sol2-tdep.c: Fix common/ includes.
15671 * amd64-obsd-tdep.c: Fix common/ includes.
15672 * amd64-nbsd-tdep.c: Fix common/ includes.
15673 * amd64-linux-tdep.c: Fix common/ includes.
15674 * amd64-linux-nat.c: Fix common/ includes.
15675 * amd64-fbsd-tdep.c: Fix common/ includes.
15676 * amd64-fbsd-nat.c: Fix common/ includes.
15677 * amd64-dicos-tdep.c: Fix common/ includes.
15678 * amd64-darwin-tdep.c: Fix common/ includes.
15679 * agent.c: Fix common/ includes.
15680 * ada-lang.h: Fix common/ includes.
15681 * ada-lang.c: Fix common/ includes.
15682 * aarch64-tdep.c: Fix common/ includes.
15683
15684 2019-01-25 Tom Tromey <tom@tromey.com>
15685
15686 * common/create-version.sh: Use common/version.h.
15687
15688 2019-01-24 Pedro Alves <palves@redhat.com>
15689
15690 * infrun.c (signal_stop, signal_print, signal_program)
15691 (signal_catch, signal_pass): Now arrays instead of pointers.
15692 (update_signals_program_target, do_target_resume)
15693 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15694 * linux-nat.c (linux_nat_target::pass_signals)
15695 (linux_nat_target::create_inferior, linux_nat_target::attach):
15696 Adjust.
15697 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15698 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15699 * procfs.c (procfs_target::pass_signals): Adjust.
15700 * record-full.c (record_full_target::resume): Adjust.
15701 * remote.c (remote_target::pass_signals)
15702 (remote_target::program_signals): Adjust.
15703 * target-debug.h (target_debug_print_signals): Now takes a
15704 gdb::array_view as parameter. Adjust.
15705 * target.h (target_ops) <pass_signals, program_signals>: Replace
15706 pointer and length parameters with gdb::array_view.
15707 (target_pass_signals, target_program_signals): Likewise.
15708 * target-delegates.c: Regenerate.
15709
15710 2019-01-24 Pedro Alves <palves@redhat.com>
15711
15712 * common/forward-scope-exit.h
15713 (forward_scope_exit::forward_scope_exit): Pass arguments to
15714 m_bind_function directly, instead of creating a std::bind and
15715 copying that.
15716
15717 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15718
15719 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15720 for static members.
15721 (pass_in_v_vfp_candidate): Likewise.
15722
15723 2019-01-23 Tom Tromey <tom@tromey.com>
15724 Pedro Alves <palves@redhat.com>
15725
15726 * regcache.c (class regcache_invalidator): Remove.
15727 (regcache::raw_write): Use make_scope_exit.
15728
15729 2019-01-23 Tom Tromey <tom@tromey.com>
15730
15731 * ui-out.h (class ui_out_emit_type): Update comment.
15732
15733 2019-01-23 Tom Tromey <tom@tromey.com>
15734
15735 * infrun.c (fetch_inferior_event): Update comment.
15736
15737 2019-01-23 Tom Tromey <tom@tromey.com>
15738 Pedro Alves <palves@redhat.com>
15739
15740 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15741 parameter.
15742 (fetch_inferior_event): Use SCOPE_EXIT.
15743
15744
15745 2019-01-23 Tom Tromey <tom@tromey.com>
15746 Pedro Alves <palves@redhat.com>
15747
15748 * infrun.c (disable_thread_events): Delete.
15749 (stop_all_threads): Use SCOPE_EXIT.
15750
15751 2019-01-23 Tom Tromey <tom@tromey.com>
15752 Pedro Alves <palves@redhat.com>
15753
15754 * symfile.c: Include forward-scope-exit.h.
15755 (clear_symtab_users_cleanup): Replace forward declaration with
15756 a FORWARD_SCOPE_EXIT.
15757 (syms_from_objfile_1): Use the forward_scope_exit and
15758 gdb::optional instead of cleanup_function.
15759 (reread_symbols): Use the forward_scope_exit instead of
15760 cleanup_function.
15761 (clear_symtab_users_cleanup): Remove function.
15762
15763 2019-01-23 Tom Tromey <tom@tromey.com>
15764 Pedro Alves <palves@redhat.com>
15765
15766 * linux-nat.c: Include scope-exit.h.
15767 (cleanup_target_stop): Remove.
15768 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15769 SCOPE_EXIT.
15770
15771 2019-01-23 Tom Tromey <tom@tromey.com>
15772 Pedro Alves <palves@redhat.com>
15773
15774 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15775 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15776
15777 2019-01-23 Tom Tromey <tom@tromey.com>
15778 Andrew Burgess <andrew.burgess@embecosm.com>
15779 Pedro Alves <palves@redhat.com>
15780
15781 * infrun.c (fetch_inferior_event): Use scope_exit.
15782 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15783 * top.c (execute_command): Use scope_exit.
15784 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15785 * utils.c (do_bpstat_clear_actions_cleanup)
15786 (make_bpstat_clear_actions_cleanup): Remove.
15787
15788 2019-01-23 Tom Tromey <tom@tromey.com>
15789 Pedro Alves <palves@redhat.com>
15790
15791 * infrun.c: Include "common/scope-exit.h"
15792 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15793 (wait_for_inferior): Use SCOPE_EXIT.
15794 (fetch_inferior_event): Use scope_exit.
15795
15796 2019-01-23 Tom Tromey <tom@tromey.com>
15797 Pedro Alves <palves@redhat.com>
15798
15799 * breakpoint.c (create_breakpoint): Remove cleanup.
15800
15801 2019-01-23 Tom Tromey <tom@tromey.com>
15802 Andrew Burgess <andrew.burgess@embecosm.com>
15803 Pedro Alves <palves@redhat.com>
15804
15805 2019-01-23 Pedro Alves <palves@redhat.com>
15806
15807 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15808
15809 2019-01-23 Pedro Alves <palves@redhat.com>
15810 Andrew Burgess <andrew.burgess@embecosm.com>
15811
15812 * gdbthread.h: Include "common/forward-scope-exit.h".
15813 (scoped_finish_thread_state): Redefine custom class in terms of
15814 forward_scope_exit.
15815
15816 2019-01-23 Pedro Alves <palves@redhat.com>
15817 Andrew Burgess <andrew.burgess@embecosm.com>
15818
15819 * common/forward-scope-exit.h: New file.
15820
15821 2019-01-23 Pedro Alves <palves@redhat.com>
15822 Andrew Burgess <andrew.burgess@embecosm.com>
15823 Tom Tromey <tom@tromey.com>
15824
15825 * common/scope-exit.h: New file.
15826
15827 2019-01-23 Pedro Alves <palves@redhat.com>
15828
15829 * common/preprocessor.h (ESC): Rename to ...
15830 (ESC_PARENS): ... this.
15831 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15832 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15833
15834 2019-01-23 Tom Tromey <tom@tromey.com>
15835
15836 * language.h (class scoped_switch_to_sym_language_if_auto):
15837 Initialize m_lang in both cases.
15838
15839 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15840
15841 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15842 with XCNEW.
15843
15844 2019-01-22 Tom Tromey <tom@tromey.com>
15845
15846 * corelow.c: Do not include sys/file.h.
15847
15848 2019-01-22 Tom Tromey <tom@tromey.com>
15849
15850 * tui/tui-wingeneral.h: Include gdb_curses.h.
15851
15852 2019-01-22 Tom Tromey <tom@tromey.com>
15853
15854 * source-cache.h (class source_cache) <get_source_lines,
15855 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15856
15857 2019-01-22 Tom Tromey <tom@tromey.com>
15858
15859 * remote-fileio.h (struct remote_target): Declare.
15860
15861 2019-01-22 Tom Tromey <tom@tromey.com>
15862
15863 * python/py-arch.c: Do not include py-ref.h.
15864 * python/py-bpevent.c: Do not include py-ref.h.
15865 * python/py-cmd.c: Do not include py-ref.h.
15866 * python/py-continueevent.c: Do not include py-ref.h.
15867 * python/py-event.h: Do not include py-ref.h.
15868 * python/py-evtregistry.c: Do not include py-ref.h.
15869 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15870 * python/py-frame.c: Do not include py-ref.h.
15871 * python/py-framefilter.c: Do not include py-ref.h.
15872 * python/py-function.c: Do not include py-ref.h.
15873 * python/py-infevents.c: Do not include py-ref.h.
15874 * python/py-linetable.c: Do not include py-ref.h.
15875 * python/py-objfile.c: Do not include py-ref.h.
15876 * python/py-param.c: Do not include py-ref.h.
15877 * python/py-prettyprint.c: Do not include py-ref.h.
15878 * python/py-progspace.c: Do not include py-ref.h.
15879 * python/py-symbol.c: Do not include py-ref.h.
15880 * python/py-symtab.c: Do not include py-ref.h.
15881 * python/py-type.c: Do not include py-ref.h.
15882 * python/py-unwind.c: Do not include py-ref.h.
15883 * python/py-utils.c: Do not include py-ref.h.
15884 * python/py-value.c: Do not include py-ref.h.
15885 * python/py-varobj.c: Do not include py-ref.h.
15886 * python/py-xmethods.c: Do not include py-ref.h.
15887 * python/python.c: Do not include py-ref.h.
15888 * varobj.c: Do not include py-ref.h.
15889
15890 2019-01-22 Tom Tromey <tom@tromey.com>
15891
15892 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15893 keyword for bcache.
15894
15895 2019-01-22 Tom Tromey <tom@tromey.com>
15896
15897 * compile/compile-cplus-types.c: Remove a comment by #include.
15898
15899 2019-01-22 Tom Tromey <tom@tromey.com>
15900
15901 * compile/gcc-c-plugin.h: Include compile-internal.h.
15902
15903 2019-01-22 Tom Tromey <tom@tromey.com>
15904
15905 * stabsread.c (EXTERN): Do not define.
15906 (symnum, next_symbol_text_func, processing_gcc_compilation)
15907 (within_function, global_sym_chain, global_stabs)
15908 (previous_stab_code, this_object_header_files)
15909 (n_this_object_header_files)
15910 (n_allocated_this_object_header_files): Define.
15911 * stabsread.h (EXTERN): Never define. Use "extern".
15912
15913 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15914
15915 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15916 history_value.
15917
15918 2019-01-21 Tom Tromey <tom@tromey.com>
15919
15920 * ui-out.c: Fix includes.
15921 * tui/tui-source.c: Fix includes.
15922 * target.c: Fix includes.
15923 * remote.c: Fix includes.
15924 * regcache.c: Fix includes.
15925 * python/py-block.c: Fix includes.
15926 * printcmd.c: Fix includes.
15927 * or1k-tdep.c: Fix includes.
15928 * mi/mi-main.c: Fix includes.
15929 * m32r-tdep.c: Fix includes.
15930 * csky-tdep.c: Fix includes.
15931 * compile/compile-cplus-types.c: Fix includes.
15932 * cli/cli-interp.c: Fix includes.
15933
15934 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15935
15936 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15937 for padding.
15938
15939 2019-01-16 Tom Tromey <tom@tromey.com>
15940
15941 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15942 earlier.
15943 (struct objfile) <msymbols_range>: Move from top level.
15944 <msymbols>: New method.
15945 (class objfile_msymbols): Remove.
15946 * symtab.c (default_collect_symbol_completion_matches_break_on):
15947 Update.
15948 * symmisc.c (dump_msymbols): Update.
15949 * stabsread.c (scan_file_globals): Update.
15950 * objc-lang.c (info_selectors_command, info_classes_command)
15951 (find_methods): Update.
15952 * minsyms.c (find_solib_trampoline_target): Update.
15953 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15954 * coffread.c (coff_symfile_read): Update.
15955 * ada-lang.c (ada_lookup_simple_minsym)
15956 (ada_collect_symbol_completion_matches): Update.
15957
15958 2019-01-16 Tom Tromey <tom@tromey.com>
15959
15960 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15961 type. Remove no-argument constructor.
15962 <iterator::operator++>: Simplify.
15963 <begin>: Update.
15964 <end>: Use minimal_symbol_count.
15965
15966 2019-01-16 Tom Tromey <tom@tromey.com>
15967
15968 * objfiles.h (struct objfile) <psymtabs>: New method.
15969 (class objfile_psymtabs): Remove.
15970 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15971 typedef.
15972 <range>: New method.
15973 (require_partial_symbols): Change return type.
15974 * psymtab.c (require_partial_symbols)
15975 (psym_expand_symtabs_matching): Update.
15976 * mdebugread.c (parse_partial_symbols): Update.
15977 * dbxread.c (dbx_end_psymtab): Update.
15978
15979 2019-01-15 Tom Tromey <tom@tromey.com>
15980
15981 * symtab.c (lookup_objfile_from_block)
15982 (lookup_symbol_in_objfile_symtabs)
15983 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15984 (find_line_symtab, info_sources_command)
15985 (default_collect_symbol_completion_matches_break_on)
15986 (make_source_files_completion_list): Update.
15987 * symmisc.c (print_objfile_statistics, dump_objfile)
15988 (maintenance_print_symbols, maintenance_info_symtabs)
15989 (maintenance_check_symtabs, maintenance_info_line_tables):
15990 Update.
15991 * source.c (select_source_symtab)
15992 (forget_cached_source_info_for_objfile): Update.
15993 * objfiles.h (class objfile_compunits): Remove.
15994 (struct objfile) <compunits_range>: New typedef.
15995 (compunits): New method.
15996 * objfiles.c (objfile_relocate1): Update.
15997 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15998 * maint.c (count_symtabs_and_blocks): Update.
15999 * linespec.c (iterate_over_all_matching_symtabs): Update.
16000 * cp-support.c (add_symbol_overload_list_qualified): Update.
16001 * coffread.c (coff_symtab_read): Update.
16002 * ada-lang.c (add_nonlocal_symbols)
16003 (ada_collect_symbol_completion_matches)
16004 (ada_add_global_exceptions): Update.
16005
16006 2019-01-15 Tom Tromey <tom@tromey.com>
16007
16008 * progspace.h (program_space) <objfiles_safe_range>: New
16009 typedef.
16010 <objfiles_safe>: New method.
16011 * objfiles.h (class all_objfiles_safe): Remove.
16012 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16013 * jit.c (jit_inferior_exit_hook): Update.
16014
16015 2019-01-17 Tom Tromey <tom@tromey.com>
16016
16017 * progspace.h (program_space) <objfiles_range>: New typedef.
16018 <objfiles>: New method.
16019 <objfiles_head>: Rename from objfiles.
16020 (object_files): Update.
16021 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16022 * guile/scm-pretty-print.c
16023 (ppscm_find_pretty_printer_from_objfiles): Update.
16024 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16025 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16026 Update.
16027 * python/py-progspace.c (pspy_get_objfiles): Update.
16028 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16029 Update.
16030 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16031 (objfpy_lookup_objfile_by_build_id): Update.
16032 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16033 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16034 Update.
16035 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16036 (expand_symtab_containing_pc, lookup_objfile_from_block)
16037 (lookup_static_symbol, basic_lookup_transparent_type)
16038 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16039 (find_line_symtab, info_sources_command)
16040 (default_collect_symbol_completion_matches_break_on)
16041 (make_source_files_completion_list, find_main_name): Update.
16042 * symmisc.c (print_symbol_bcache_statistics)
16043 (print_objfile_statistics, maintenance_print_symbols)
16044 (maintenance_print_msymbols, maintenance_print_objfiles)
16045 (maintenance_info_symtabs, maintenance_check_symtabs)
16046 (maintenance_expand_symtabs, maintenance_info_line_tables):
16047 Update.
16048 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16049 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16050 (map_overlay_command, unmap_overlay_command)
16051 (simple_overlay_update, expand_symtabs_matching)
16052 (map_symbol_filenames): Update.
16053 * symfile-debug.c (set_debug_symfile): Update.
16054 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16055 Update.
16056 * source.c (select_source_symtab, forget_cached_source_info):
16057 Update.
16058 * solib.c (solib_read_symbols): Update.
16059 * solib-spu.c (append_ocl_sos): Update.
16060 * psymtab.c (maintenance_print_psymbols)
16061 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16062 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16063 * printcmd.c (info_symbol_command): Update.
16064 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16065 Update.
16066 * objfiles.h (class all_objfiles): Remove.
16067 * objfiles.c (have_partial_symbols, have_full_symbols)
16068 (have_minimal_symbols, qsort_cmp, update_section_map)
16069 (shared_objfile_contains_address_p)
16070 (default_iterate_over_objfiles_in_search_order): Update.
16071 * objc-lang.c (info_selectors_command, info_classes_command)
16072 (find_methods): Update.
16073 * minsyms.c (find_solib_trampoline_target): Update.
16074 * maint.c (maintenance_info_sections)
16075 (maintenance_translate_address, count_symtabs_and_blocks):
16076 Update.
16077 * main.c (captured_main_1): Update.
16078 * linux-thread-db.c (try_thread_db_load_from_pdir)
16079 (has_libpthread): Update.
16080 * linespec.c (iterate_over_all_matching_symtabs)
16081 (search_minsyms_for_name): Update.
16082 * jit.c (jit_find_objf_with_entry_addr): Update.
16083 * hppa-tdep.c (find_unwind_entry)
16084 (hppa_lookup_stub_minimal_symbol): Update.
16085 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16086 Update.
16087 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16088 (elf_gnu_ifunc_resolve_by_got): Update.
16089 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16090 * dwarf-index-write.c (save_gdb_index_command): Update.
16091 * cp-support.c (add_symbol_overload_list_qualified): Update.
16092 * breakpoint.c (create_overlay_event_breakpoint)
16093 (create_longjmp_master_breakpoint)
16094 (create_std_terminate_master_breakpoint)
16095 (create_exception_master_breakpoint): Update.
16096 * blockframe.c (find_pc_partial_function): Update.
16097 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16098 (ada_collect_symbol_completion_matches)
16099 (ada_add_global_exceptions): Update.
16100
16101 2019-01-17 Tom Tromey <tom@tromey.com>
16102
16103 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16104 declare VEC.
16105 (solib_target_parse_libraries): Change return type.
16106 (library_list_start_segment, library_list_start_section)
16107 (library_list_end_library, library_list_start_library); Update.
16108 (solib_target_free_library_list): Remove.
16109 (solib_target_parse_libraries): Remove cleanup. Change return
16110 type.
16111 (solib_target_current_sos): Update.
16112
16113 2019-01-17 Tom Tromey <tromey@bapiya>
16114
16115 * valprint.c: Replace "the the" with "the".
16116 * symtab.c: Replace "the the" with "the".
16117 * solib.c: Replace "the the" with "the".
16118 * solib-dsbt.c: Replace "the the" with "the".
16119 * linespec.c: Replace "the the" with "the".
16120 * dwarf2loc.h: Replace "the the" with "the".
16121 * amd64-windows-tdep.c: Replace "the the" with "the".
16122 * aarch64-tdep.c: Replace "the the" with "the".
16123
16124 2019-01-16 Keith Seitz <keiths@redhat.com>
16125
16126 PR gdb/23773
16127 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16128 <builder>: Rename to ..
16129 <m_builder>: ... this and make private.
16130 (dwarf2_cu::get_builder): New method. Change all users of
16131 `builder' to use this method.
16132 (dwarf2_start_symtab): Move to ...
16133 (dwarf2_cu::start_symtab): ... here. Update all callers
16134 (setup_type_unit_groups): Move to ...
16135 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16136 callers.
16137 (dwarf2_cu::reset_builder): New method.
16138 (process_full_compunit, process_full_type_unit): Use
16139 dwarf2_cu::reset_builder.
16140 (follow_die_offset): Record the ancestor CU if it is different
16141 from the followed DIE's CU.
16142 (follow_die_sig_1): Likewise.
16143
16144 2019-01-15 Tom Tromey <tom@tromey.com>
16145
16146 * remote.c (class remote_state) <buf>: Now a char_vector.
16147 <buf_size>: Remove.
16148 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16149 parameter.
16150 (remote_target::getpkt_or_notif_sane_1)
16151 (remote_target::getpkt_sane)
16152 (remote_target::getpkt_or_notif_sane): Likewise.
16153 (class remote_target) <putpkt>: New overload.
16154 (remote_target::read_frame): Change type of "buf_p". Remove
16155 sizeof_p parameter.
16156 (packet_ok): New overload.
16157 (packet_check_result): New overload.
16158 Update all uses.
16159
16160 2019-01-14 Tom Tromey <tom@tromey.com>
16161
16162 * remote-notif.c (handle_notification, remote_notif_ack)
16163 (remote_notif_parse): Make "buf" const.
16164 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16165 const.
16166 (remote_notif_parse, remote_notif_ack, handle_notification):
16167 Likewise.
16168 * remote.c (remote_notif_stop_parse): Make "buf" const.
16169 (remote_target::remote_parse_stop_reply): Make "buf" const.
16170 (remote_notif_stop_ack): Make "buf" const.
16171
16172 2019-01-14 Tom Tromey <tom@tromey.com>
16173
16174 * remote.c (remote_console_output): Make parameter const.
16175
16176 2019-01-14 Tom Tromey <tom@tromey.com>
16177
16178 * target-debug.h (target_debug_print_signals): Constify.
16179 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16180 * procfs.c (procfs_target::pass_signals): Update.
16181 * linux-nat.c (linux_nat_target::pass_signals): Update.
16182 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16183 * target-delegates.c: Rebuild.
16184 * remote.c (remote_target::program_signals): Update.
16185 (remote_target::pass_signals): Update.
16186 * target.c (target_pass_signals): Constify argument.
16187 (target_program_signals): Likewise.
16188 * target.h (struct target_ops) <pass_signals, program_signals>:
16189 Constify argument.
16190 (target_pass_signals, target_program_signals): Constify argument.
16191
16192 2019-01-14 Tom Tromey <tom@tromey.com>
16193
16194 PR tui/28819:
16195 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16196
16197 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16198
16199 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16200 field.
16201 * rs6000-tdep.c: Include reggroups.h.
16202 (IS_V_ALIAS_PSEUDOREG): Define.
16203 (rs6000_register_name): Return names for the "vX" aliases.
16204 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16205 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16206 aliases. Call default_register_reggroup_p for all other
16207 pseudo-registers.
16208 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16209 New functions.
16210 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16211 Handle "vX" aliases.
16212 (v_alias_pseudo_register_collect): New function.
16213 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16214 (rs6000_gdbarch_init): Initialize "vX" aliases as
16215 pseudo-registers. Restore registration of
16216 rs6000_pseudo_register_reggroup_p with
16217 set_tdesc_pseudo_register_reggroup_p.
16218
16219 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16220
16221 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16222 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16223 set_gdbarch_num_pseudo_regs.
16224
16225 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16226
16227 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16228 Remove arg prefixname, add do_set and do_show.
16229 Add member functions set_list and show_list.
16230 * cli/cli-style.c (class cli_style_option): Update accordingly.
16231 (style_set_list): Move to file scope.
16232 (style_show_list): Likewise.
16233 (set_style): Call help_list.
16234 (show_style): Call cmd_show_list.
16235 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16236 Update to use the new macro.
16237
16238 2019-10-12 Joel Brobecker <brobecker@adacore.com>
16239
16240 * ada-lang.c (_initialize_ada_language): Expand the help text
16241 for the "catch exception" command.
16242
16243 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16244
16245 * symtab.c (matching_obj_sections): Initialize obj,
16246 declare it closer to its usage.
16247
16248 2019-01-10 Tom Tromey <tom@tromey.com>
16249
16250 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16251 (basic_inf_threads_range): Remove.
16252 (inf_threads_range, inf_non_exited_threads_range)
16253 (safe_inf_threads_range): Use next_adapter.
16254
16255 2019-01-10 Keith Seitz <keiths@redhat.com>
16256
16257 PR gdb/23712
16258 PR symtab/23010
16259 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16260 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16261
16262 2019-01-10 Keith Seitz <keiths@redhat.com>
16263
16264 PR gdb/23712
16265 PR symtab/23010
16266 * dictionary.c (pending_to_vector): Remove.
16267 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16268 Remove _1 suffix, replacing functions of the same name. Update
16269 all callers.
16270 (dict_create_hashed, dict_create_hashed_expandable)
16271 (dict_create_linear, dict_create_linear_expandable, dict_free)
16272 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16273 Make functions static.
16274
16275 2019-01-10 Keith Seitz <keiths@redhat.com>
16276
16277 PR gdb/23712
16278 PR symtab/23010
16279 * dictionary.h (struct dictionary): Replace declaration with
16280 multidictionary.
16281 (dict_create_hashed, dict_create_hashed_expandable)
16282 (dict_create_linear, dict_create_linear_expandable)
16283 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16284 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16285 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16286 taking multidictionary argument.
16287 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16288 * block.h (struct block) <dict>: Change to multidictionary
16289 and rename `multidict'.
16290 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16291 symmisc.c: Update all dictionary references to multidictionary.
16292
16293 2019-01-10 Keith Seitz <keiths@redhat.com>
16294
16295 PR gdb/23712
16296 PR symtab/23010
16297 * dictionary.c: Include unordered_map.
16298 (pending_to_vector): New function.
16299 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16300 Rewrite the non-"_1" functions to take vector instead
16301 of linked list.
16302 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16303 "new" _1 versions of the same name.
16304 (multidictionary): Define.
16305 (std::hash<enum language): New definition.
16306 (collate_pending_symbols_by_language, mdict_create_hashed)
16307 (mdict_create_hashed_expandable, mdict_create_linear)
16308 (mdict_create_linear_expandable, mdict_free)
16309 (find_language_dictionary, create_new_language_dictionary)
16310 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16311 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16312 (mdict_size, mdict_empty): New functions.
16313 * dictionary.h (mdict_iterator): Define.
16314
16315 2019-01-10 Pedro Alves <palves@redhat.com>
16316
16317 * breakpoint.c (read_uploaded_action)
16318 (create_tracepoint_from_upload): Adjust to use
16319 gdb::unique_xmalloc_ptr.
16320 * ctf.c (ctf_write_uploaded_tp):
16321 (SET_ARRAY_FIELD): Use emplace_back.
16322 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16323 * tracefile-tfile.c (tfile_write_uploaded_tp):
16324 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16325 gdb::unique_xmalloc_ptr.
16326 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16327 at_string, cond_string, cmd_strings>: Replace char pointers
16328 with gdb::unique_xmalloc_ptr.
16329
16330 2019-01-10 Pedro Alves <palves@redhat.com>
16331
16332 * solib-target.c (library_list_start_library): Don't xstrdup name.
16333
16334 2019-01-10 Pedro Alves <palves@redhat.com>
16335
16336 * mdebugread.c (parse_partial_symbols): Use
16337 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16338
16339 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16340
16341 * linux-fork.c (scoped_switch_fork_info)
16342 <~scoped_switch_fork_info>: Fix incorrect variable name.
16343
16344 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16345
16346 * linux-fork.c (scoped_switch_fork_info)
16347 <scoped_switch_fork_info>: Make explicit.
16348 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16349
16350 2019-01-10 Tom Tromey <tom@tromey.com>
16351
16352 * objfiles.h (objfile::reset_psymtabs): Update.
16353 * objfiles.c (objfile::objfile): Update.
16354 * psymtab.h (psymtab_storage::obstack): Update.
16355 (psymtab_storage::m_obstack): Use gdb::optional.
16356 (class psymtab_storage): Update comment. Remove objfile
16357 parameter.
16358 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16359
16360 2019-01-10 Tom Tromey <tom@tromey.com>
16361
16362 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16363 <free_psymtabs>: Now private.
16364 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16365 (allocate_psymtab): Use new method.
16366
16367 2019-01-10 Tom Tromey <tom@tromey.com>
16368
16369 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16370 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16371 * mdebugread.c (parse_partial_symbols): Use
16372 allocate_dependencies.
16373 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16374 allocate_dependencies.
16375 (process_psymtab_comp_unit_reader)
16376 (build_type_psymtab_dependencies): Likewise.
16377 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16378
16379 2019-01-10 Tom Tromey <tom@tromey.com>
16380
16381 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16382 PSYMBOL_SET_LANGUAGE.
16383 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16384
16385 2019-01-10 Tom Tromey <tom@tromey.com>
16386
16387 * psymtab.h (psymtab_storage::obstack): New method.
16388 <m_obstack>: Rename from obstack; now private.
16389 * psymtab.c (psymtab_storage): Update.
16390 * dwarf2read.c (create_addrmap_from_index)
16391 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16392 Update.
16393
16394 2019-01-10 Tom Tromey <tom@tromey.com>
16395
16396 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16397 * objfiles.h (objfile::reset_psymtabs): New method.
16398
16399 2019-01-10 Tom Tromey <tom@tromey.com>
16400
16401 * symmisc.c (print_symbol_bcache_statistics): Update.
16402 (print_objfile_statistics): Update.
16403 * symfile.c (reread_symbols): Update.
16404 * psymtab.h (class psymtab_storage): New.
16405 * psymtab.c (psymtab_storage): New constructor.
16406 (~psymtab_storage): New destructor.
16407 (require_partial_symbols): Update.
16408 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16409 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16410 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16411 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16412 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16413 (start_psymtab_common, end_psymtab_common)
16414 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16415 (allocate_psymtab): Update.
16416 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16417 Update.
16418 (dump_psymtab_addrmap, maintenance_print_psymbols)
16419 (maintenance_check_psymtabs): Update.
16420 (class objfile_psymtabs): Move to objfiles.h.
16421 * psympriv.h (discard_psymtab): Now inline.
16422 (psymtab_discarder::psymtab_discarder): Update.
16423 (psymtab_discarder::~psymtab_discarder): Update.
16424 (ALL_OBJFILE_PSYMTABS): Rewrite.
16425 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16426 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16427 Remove fields.
16428 <partial_symtabs>: New field.
16429 (class objfile_psymtabs): Move from psymtab.h. Update.
16430 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16431 psymbol_cache.
16432 (objfile::~objfile): Don't destroy psymbol_cache.
16433 * mdebugread.c (parse_partial_symbols): Update.
16434 * dwarf2read.c (create_addrmap_from_index)
16435 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16436 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16437 (add_partial_subprogram, dwarf2_ranges_read): Update.
16438 * dwarf-index-write.c (write_address_map)
16439 (write_one_signatured_type, recursively_write_psymbols)
16440 (class debug_names, class debug_names, write_psymtabs_to_index):
16441 Update.
16442
16443 2019-01-10 Tom Tromey <tom@tromey.com>
16444
16445 * symtab.h (SYMBOL_SET_NAMES): Update.
16446 (symbol_set_names): Update.
16447 (MSYMBOL_SET_NAMES): Update.
16448 * symtab.c (symbol_set_names): Change argument to be an
16449 objfile_per_bfd_storage.
16450 * psymtab.c (add_psymbol_to_bcache): Update.
16451 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16452
16453 2019-01-10 Tom Tromey <tom@tromey.com>
16454
16455 * symtab.c (create_demangled_names_hash): Change argument to be an
16456 objfile_per_bfd_storage.
16457 (symbol_set_names): Update.
16458
16459 2019-01-10 Tom Tromey <tom@tromey.com>
16460
16461 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16462 init_psymbol_list.
16463 * psymtab.c (init_psymbol_list): Do nothing if already called.
16464 * psympriv.h (init_psymbol_list): Add comment.
16465 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16466 init_psymbol_list.
16467 * dbxread.c (dbx_symfile_read): Unconditionally call
16468 init_psymbol_list.
16469
16470 2019-01-10 Tom Tromey <tom@tromey.com>
16471
16472 * xcoffread.c (scan_xcoff_symtab): Update.
16473 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16474 "where".
16475 * mdebugread.c (parse_partial_symbols)
16476 (handle_psymbol_enumerators): Update.
16477 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16478 * dbxread.c (read_dbx_symtab): Update.
16479 * psympriv.h (psymbol_placement): New enum.
16480 (add_psymbol_to_list): Update.
16481
16482 2019-01-10 Tom Tromey <tom@tromey.com>
16483
16484 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16485 static_psymbols parameters.
16486 (scan_xcoff_symtab): Update.
16487 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16488 static_psymbols parameters.
16489 * psympriv.h (start_psymtab_common): Update.
16490 * mdebugread.c (parse_partial_symbols): Update.
16491 * dwarf2read.c (create_partial_symtab): Update.
16492 * dbxread.c (read_dbx_symtab): Update.
16493 (start_psymtab): Remove global_psymbols and static_psymbols
16494 parameters.
16495
16496 2019-01-10 Tom Tromey <tom@tromey.com>
16497
16498 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16499 * psymtab.c (allocate_psymtab): Add comment.
16500 * psympriv.h (allocate_psymtab): Add comment.
16501 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16502 initializations.
16503 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16504
16505 2019-01-10 Tom Tromey <tom@tromey.com>
16506
16507 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16508 Don't declare.
16509 * mipsread.c: Include mdebugread.h.
16510 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16511 Declare.
16512 * elfread.c: Include mdebugread.h.
16513
16514 2019-01-09 Tom Tromey <tom@tromey.com>
16515
16516 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16517 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16518 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16519 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16520 (psym_lookup_symbol, psym_find_last_source_symtab)
16521 (psym_forget_cached_source_info, psym_print_stats)
16522 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16523 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16524 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16525 (psym_find_compunit_symtab_by_address)
16526 (maintenance_print_psymbols, maintenance_info_psymtabs)
16527 (maintenance_check_psymtabs): Use ranged for.
16528 * psymtab.h (class objfile_psymtabs): New.
16529 (require_partial_symbols): Return objfile_psymtabs.
16530 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16531
16532 2019-01-09 Tom Tromey <tom@tromey.com>
16533
16534 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16535 (find_pc_mapped_section, list_overlays_command)
16536 (map_overlay_command, unmap_overlay_command)
16537 (simple_overlay_update): Use all_objfiles.
16538 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16539 * printcmd.c (info_symbol_command): Use all_objfiles.
16540 * objfiles.h (ALL_OBJSECTIONS): Remove.
16541 * maint.c (maintenance_translate_address): Use all_objfiles.
16542 * gcore.c (gcore_create_callback): Use all_objfiles.
16543 (objfile_find_memory_regions): Likewise.
16544
16545 2019-01-09 Tom Tromey <tom@tromey.com>
16546
16547 * symtab.c (find_line_symtab, info_sources_command)
16548 (make_source_files_completion_list): Use objfile_compunits.
16549 * source.c (select_source_symtab): Use objfile_compunits.
16550 * objfiles.h (struct objfile): Update comment.
16551 (ALL_OBJFILES): Remove.
16552 (ALL_FILETABS): Remove.
16553 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16554 objfile_compunits.
16555
16556 2019-01-09 Tom Tromey <tom@tromey.com>
16557
16558 * symmisc.c (print_objfile_statistics, dump_objfile)
16559 (maintenance_print_symbols): Use compunit_filetabs.
16560 * source.c (forget_cached_source_info_for_objfile): Use
16561 compunit_filetabs.
16562 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16563 (ALL_FILETABS): Use compunit_filetabs.
16564 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16565 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16566
16567 2019-01-09 Tom Tromey <tom@tromey.com>
16568
16569 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16570 (compunit_filetabs): New.
16571 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16572 compunit_filetabs.
16573 (info_sources_command, make_source_files_completion_list): Remove
16574 declaration.
16575 * symmisc.c (print_objfile_statistics, dump_objfile)
16576 (maintenance_print_symbols): Remove declaration.
16577 (maintenance_info_symtabs): Use compunit_filetabs.
16578 (maintenance_info_line_tables): Likewise.
16579 * source.c (select_source_symtab): Change local variable name.
16580 (forget_cached_source_info_for_objfile): Remove declaration.
16581 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16582 * objfiles.c (objfile_relocate1): Remove declaration.
16583 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16584 declaration.
16585 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16586 * coffread.c (coff_symtab_read): Remove declaration.
16587 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16588 compunit_filetabs.
16589
16590 2019-01-09 Tom Tromey <tom@tromey.com>
16591
16592 * symtab.c (lookup_objfile_from_block)
16593 (find_pc_sect_compunit_symtab, search_symbols)
16594 (default_collect_symbol_completion_matches_break_on): Use
16595 objfile_compunits.
16596 * objfiles.h (ALL_COMPUNITS): Remove.
16597 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16598 * cp-support.c (add_symbol_overload_list_qualified): Use
16599 objfile_compunits.
16600 * ada-lang.c (ada_collect_symbol_completion_matches)
16601 (ada_add_global_exceptions): Use objfile_compunits.
16602
16603 2019-01-09 Tom Tromey <tom@tromey.com>
16604
16605 * source.c (select_source_symtab)
16606 (forget_cached_source_info_for_objfile): Remove declaration.
16607 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16608 declaration.
16609 * maint.c (count_symtabs_and_blocks): Remove declaration.
16610 * cp-support.c (add_symbol_overload_list_qualified): Remove
16611 declaration.
16612 * coffread.c (coff_symtab_read): Remove declaration.
16613 * symtab.c (lookup_symbol_in_objfile_symtabs)
16614 (basic_lookup_transparent_type_1): Use objfile_compunits.
16615 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16616 (info_sources_command, search_symbols)
16617 (default_collect_symbol_completion_matches_break_on)
16618 (make_source_files_completion_list): Remove declaration.
16619 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16620 (ada_collect_symbol_completion_matches)
16621 (ada_add_global_exceptions): Remove declaration.
16622 * linespec.c (iterate_over_all_matching_symtabs): Use
16623 objfile_compunits.
16624 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16625 (class objfile_compunits): New.
16626 (ALL_COMPUNITS): Use objfile_compunits.
16627 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16628 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16629 objfile_compunits.
16630 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16631
16632 2019-01-09 Tom Tromey <tom@tromey.com>
16633
16634 * symtab.c (search_symbols)
16635 (default_collect_symbol_completion_matches_break_on): Use
16636 objfile_msymbols.
16637 * ada-lang.c (ada_lookup_simple_minsym)
16638 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16639 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16640 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16641 objfile_msymbols.
16642 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16643 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16644 * objc-lang.c (find_methods): Use objfile_msymbols.
16645 (info_selectors_command, info_classes_command): Likewise.
16646 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16647 * objfiles.h (class objfile_msymbols): New.
16648 (ALL_OBJFILE_MSYMBOLS): Remove.
16649 (ALL_MSYMBOLS): Remove.
16650
16651 2019-01-09 Tom Tromey <tom@tromey.com>
16652
16653 * common/next-iterator.h (next_adapter): Add Iterator template
16654 parameter.
16655 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16656 (class all_objfiles_safe): New.
16657 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16658 * objfiles.c (put_objfile_before): Update comment.
16659 (add_separate_debug_objfile): Likewise.
16660 (free_all_objfiles): Use all_objfiles_safe.
16661 (objfile_purge_solibs): Likewise.
16662
16663 2019-01-09 Tom Tromey <tom@tromey.com>
16664
16665 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16666 (expand_symtab_containing_pc, lookup_static_symbol)
16667 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16668 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16669 all_objfiles.
16670 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16671 * breakpoint.c (create_overlay_event_breakpoint)
16672 (create_longjmp_master_breakpoint)
16673 (create_std_terminate_master_breakpoint)
16674 (create_exception_master_breakpoint): Use all_objfiles.
16675 * linux-thread-db.c (try_thread_db_load_from_pdir)
16676 (has_libpthread): Use all_objfiles.
16677 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16678 * linespec.c (iterate_over_all_matching_symtabs)
16679 (search_minsyms_for_name): Use all_objfiles.
16680 * maint.c (maintenance_info_sections): Use all_objfiles.
16681 * main.c (captured_main_1): Use all_objfiles.
16682 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16683 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16684 * guile/scm-pretty-print.c
16685 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16686 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16687 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16688 (maintenance_print_msymbols): Use all_objfiles.
16689 * source.c (select_source_symtab): Use all_objfiles.
16690 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16691 * symfile.c (remove_symbol_file_command)
16692 (expand_symtabs_matching, map_symbol_filenames): Use
16693 all_objfiles.
16694 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16695 all_objfiles.
16696 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16697 * objc-lang.c (find_methods): Use all_objfiles.
16698 * objfiles.c (have_partial_symbols, have_full_symbols)
16699 (have_minimal_symbols, qsort_cmp)
16700 (default_iterate_over_objfiles_in_search_order): Use
16701 all_objfiles.
16702 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16703 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16704 (maintenance_check_psymtabs): Use all_objfiles.
16705 (ALL_PSYMTABS): Remove.
16706 * compile/compile-object-run.c (do_module_cleanup): Use
16707 all_objfiles.
16708 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16709 * cp-support.c (add_symbol_overload_list_qualified): Use
16710 all_objfiles.
16711 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16712 Use all_objfiles.
16713 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16714 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16715 all_objfiles.
16716 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16717 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16718 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16719 Uses all_objfiles.
16720 * solib.c (solib_read_symbols): Use all_objfiles
16721
16722 2019-01-09 Tom Tromey <tom@tromey.com>
16723
16724 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16725 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16726 all_objfiles.
16727 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16728 * symmisc.c (print_symbol_bcache_statistics)
16729 (print_objfile_statistics, maintenance_print_objfiles)
16730 (maintenance_info_symtabs, maintenance_check_symtabs)
16731 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16732 all_objfiles.
16733 * source.c (forget_cached_source_info): Use all_objfiles.
16734 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16735 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16736 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16737 * objfiles.c (update_section_map): Use all_objfiles.
16738 (shared_objfile_contains_address_p): Likewise.
16739 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16740 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16741
16742 2019-01-09 Tom Tromey <tom@tromey.com>
16743
16744 * common/next-iterator.h: New file.
16745 * objfiles.h (class all_objfiles): New.
16746 (struct objfile_iterator): New.
16747
16748 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16749
16750 * NEWS: Move the description of the changed "frame", "select-frame",
16751 and "info frame" commands to the Changed commands section.
16752
16753 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16754
16755 * gdbtypes.c (check_stub_method_group): Remove handling of old
16756 mangling schemes.
16757 * linespec.c (find_methods): Likewise.
16758 * stabsread.c (read_member_functions): Likewise.
16759 * valops.c (search_struct_method): Likewise.
16760 (value_struct_elt_for_reference): Likewise.
16761 * NEWS: Mention this change.
16762
16763 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16764
16765 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16766 print_source_lines.
16767 * source.c (print_source_lines_base): Update line number check.
16768 (print_source_lines): New function.
16769 (source_lines_range::source_lines_range): New function.
16770 * source.h (class source_lines_range): New class.
16771 (print_source_lines): New declaration.
16772
16773 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16774
16775 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16776
16777 2019-01-08 Tom Tromey <tom@tromey.com>
16778 Simon Marchi <simon.marchi@ericsson.com>
16779
16780 PR gdb/24060
16781 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16782 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16783 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16784 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16785 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16786 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16787
16788 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16789
16790 * source.c (select_source_symtab): Move header comment to
16791 declaration in source.h.
16792 (forget_cached_source_info_for_objfile): Likewise.
16793 (forget_cached_source_info): Likewise.
16794 (identify_source_line): Likewise.
16795 * source.h (identify_source_line): Move declaration from symtab.h
16796 and add comment from source.c
16797 (print_source_lines): Likewise.
16798 (forget_cached_source_info_for_objfile): Likewise.
16799 (forget_cached_source_info): Likewise.
16800 (select_source_symtab): Likewise.
16801 (enum print_source_lines_flag): Move definition from symtab.h.
16802 * symtab.h (identify_source_line): Move declaration to source.h.
16803 (print_source_lines): Likewise.
16804 (forget_cached_source_info_for_objfile): Likewise.
16805 (forget_cached_source_info): Likewise.
16806 (select_source_symtab): Likewise.
16807 (enum print_source_lines_flag): Move definition to source.h.
16808 * tui/tui-hooks.c: Add 'source.h' include.
16809
16810 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16811
16812 * source.c (print_source_lines_base): Handle requests to print
16813 reverse line number sequences, and guard against empty lines
16814 string.
16815
16816 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16817
16818 * source.c (print_source_lines_base): Fix skip of '\r' if next
16819 character is '\n'.
16820
16821 2019-01-06 Tom Tromey <tom@tromey.com>
16822
16823 * c-exp.y (struct c_parse_state) <macro_original_text,
16824 expansion_obstack>: New member.
16825 (macro_original_text, expansion_obstack): Remove globals.
16826 (scan_macro_expansion, scanning_macro_expansion)
16827 (finished_macro_expansion): Update.
16828 (scan_macro_cleanup): Remove.
16829 (yylex, c_parse): Update.
16830
16831 2019-01-06 Tom Tromey <tom@tromey.com>
16832
16833 * c-exp.y (struct c_parse_state) <strings>: New member.
16834 (operator_stoken): Update.
16835
16836 2019-01-06 Tom Tromey <tom@tromey.com>
16837
16838 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16839 (union type_stack_elt) <typelist_val>: Now a pointer to
16840 std::vector.
16841 (type_stack_cleanup): Don't declare.
16842 (push_typelist): Update.
16843 * parse.c (pop_typelist): Return a std::vector.
16844 (push_typelist): Take a std::vector.
16845 (follow_types): Update. Do not free args.
16846 (type_stack_cleanup): Remove.
16847 * c-exp.y (struct c_parse_state): New.
16848 (cpstate): New global.
16849 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16850 (nonempty_typelist): Update.
16851 (func_mod): Create a new vector.
16852 (c_parse): Create a c_parse_state.
16853 (check_parameter_typelist): Do not delete params.
16854 (function_method): Update. Do not delete type_list.
16855
16856 2019-01-06 Tom Tromey <tom@tromey.com>
16857
16858 PR gdb/28155:
16859 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16860 check_typedef.
16861 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16862 (print_return_value): Likewise.
16863
16864 2019-01-05 Tom Tromey <tom@tromey.com>
16865
16866 * contrib/cleanup_check.py: Remove.
16867 * contrib/gcc-with-excheck: Remove.
16868 * contrib/exsummary.py: Remove.
16869 * contrib/excheck.py: Remove.
16870
16871 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16872
16873 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16874 NULL. Initialize tpprev to NULL instead of assigning it
16875 to NULL on the next statement.
16876 * windows-nat.c (windows_delete_thread): Remove check for
16877 main_thread_id before printing thread exit notifications.
16878 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16879 Remove thread ID check against main_thread_id.
16880 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16881 windows_delete_thread.
16882 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16883
16884 2019-01-04 Tom Tromey <tom@tromey.com>
16885
16886 * compile/compile.c (_initialize_compile): Use upper case for
16887 metasyntactic variables.
16888 * symmisc.c (_initialize_symmisc): Use upper case for
16889 metasyntactic variables.
16890 * psymtab.c (_initialize_psymtab): Use upper case for
16891 metasyntactic variables.
16892 * demangle.c (demangle_command): Use upper case for metasyntactic
16893 variables.
16894 (_initialize_demangler): Likewise.
16895 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16896 variables.
16897
16898 2019-01-03 Tom Tromey <tom@tromey.com>
16899
16900 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16901
16902 2019-01-03 Tom Tromey <tom@tromey.com>
16903
16904 * python/py-symtab.c (salpy_str): Update.
16905 (struct salpy_sal_object) <symtab>: Now a PyObject.
16906 (salpy_dealloc): Update.
16907 (del_objfile_sal): Use gdbpy_ref.
16908
16909 2019-01-03 Tom Tromey <tom@tromey.com>
16910
16911 * python/py-type.c (convert_field): Use new_reference. Return
16912 gdbpy_ref.
16913 (make_fielditem): Return gdbpy_ref.
16914 (typy_fields): Update.
16915 (typy_getitem): Update.
16916 (field_name): Return gdbpy_ref. Use new_reference.
16917 (typy_iterator_iternext): Update.
16918
16919 2019-01-03 Tom Tromey <tom@tromey.com>
16920
16921 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16922
16923 2019-01-03 Tom Tromey <tom@tromey.com>
16924
16925 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16926 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16927 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16928 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16929 (pspy_set_type_printers): Likewise.
16930 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16931 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16932 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16933 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16934 (objfpy_set_type_printers): Likewise.
16935
16936 2019-01-03 Tom Tromey <tom@tromey.com>
16937
16938 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16939 (gdbpy_print_stack): Use gdbpy_err_fetch.
16940 * python/python-internal.h (class gdbpy_err_fetch): New class.
16941 (class gdbpy_enter) <m_error_type, m_error_value,
16942 m_error_traceback>: Remove.
16943 <m_error>: New member.
16944 (gdbpy_exception_to_string): Don't declare.
16945 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16946 * python/py-value.c (convert_value_from_python): Use
16947 gdbpy_err_fetch.
16948 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16949 gdbpy_exception_to_string.
16950 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16951 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16952 gdbpy_err_fetch.
16953
16954 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16955
16956 * linux-nat.c (delete_lwp_cleanup): Delete.
16957 (struct lwp_deleter): New struct.
16958 (lwp_info_up): New typedef.
16959 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16960 lwp_info_up.
16961
16962 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16963
16964 * linux-fork.c (class scoped_switch_fork_info): New class.
16965 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16966
16967 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16968
16969 * valops.c (find_overload_match): Remove use of null_cleanup, and
16970 calls to do_cleanups.
16971
16972 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16973
16974 * compile/compile-cplus-types.c
16975 (compile_cplus_instance::decl_name): Handle changes to
16976 cp_func_name.
16977 * cp-support.c (cp_func_name): Update header comment, update
16978 return type.
16979 * cp-support.h (cp_func_name): Update return type in declaration.
16980 * valops.c (find_overload_match): Move temp_func local to top
16981 level of function and change its type. Use temp_func to hold and
16982 delete temporary string obtained from cp_func_name.
16983
16984 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16985
16986 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16987 gdb::char_vector, remove cleanup, and update uses of `msg`.
16988
16989 2019-01-03 Jim Wilson <jimw@sifive.com>
16990
16991 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16992
16993 2019-01-02 Tom Tromey <tom@tromey.com>
16994
16995 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16996 (tdesc_parse_xml): Remove cleanups.
16997 * target-descriptions.h (make_cleanup_free_target_description):
16998 Don't declare.
16999 (target_desc_deleter): New struct.
17000 (target_desc_up): New typedef.
17001 * target-descriptions.c (target_desc_deleter::operator()): Rename
17002 from free_target_description.
17003 (make_cleanup_free_target_description): Remove.
17004
17005 2019-01-02 Tom Tromey <tom@tromey.com>
17006
17007 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17008 constructor, destructor.
17009 (linespec_parser): Remove typedef.
17010 (~linespec_parser): Rename from linespec_parser_delete.
17011 (linespec_lex_to_end, linespec_complete_label)
17012 (linespec_complete): Update.
17013 (decode_line_full): Remove cleanups.
17014 (decode_line_1): Update.
17015
17016 2019-01-02 Tom Tromey <tom@tromey.com>
17017
17018 * python/python-internal.h (inferior_to_inferior_object): Change
17019 return type.
17020 * python/py-exitedevent.c (create_exited_event_object): Update.
17021 * python/py-inferior.c (inferior_to_inferior_object): Return
17022 gdbpy_ref.
17023 (python_new_inferior, python_inferior_deleted)
17024 (thread_to_thread_object, delete_thread_object)
17025 (build_inferior_list, gdbpy_selected_inferior): Update.
17026 * python/py-infthread.c (create_thread_object): Update. Also fail
17027 if inferior_to_inferior_object fails.
17028
17029 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17030
17031 * inferior.h (class inferior) <displaced_step_state>: New field.
17032 * infrun.h (struct displaced_step_state): Move here from
17033 infrun.c. Initialize fields, add constructor.
17034 <inf>: Remove field.
17035 <reset>: New method.
17036 * infrun.c (struct displaced_step_inferior_state): Move to
17037 infrun.h.
17038 (displaced_step_inferior_states): Remove.
17039 (get_displaced_stepping_state): Adust.
17040 (displaced_step_in_progress_any_inferior): Adjust.
17041 (displaced_step_in_progress_thread): Adjust.
17042 (displaced_step_in_progress): Adjust.
17043 (add_displaced_stepping_state): Remove.
17044 (get_displaced_step_closure_by_addr): Adjust.
17045 (remove_displaced_stepping_state): Remove.
17046 (infrun_inferior_exit): Call displaced_step_state.reset.
17047 (use_displaced_stepping): Don't check for NULL.
17048 (displaced_step_prepare_throw): Call
17049 get_displaced_stepping_state.
17050 (displaced_step_fixup): Don't check for NULL.
17051 (prepare_for_detach): Don't check for NULL.
17052
17053 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17054
17055 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17056 in case of call that did not complete.
17057
17058 2019-01-02 Andrey Utkin <autkin@undo.io>
17059
17060 * symfile.c (find_separate_debug_file): Fix search of debug files for
17061 remote debuggee.
17062
17063 2019-01-02 Tom Tromey <tom@tromey.com>
17064
17065 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17066 indentation.
17067 * python/py-frame.c (frapy_older): Remove cast.
17068 (frapy_newer): Likewise.
17069 * python/py-breakpoint.c (local_setattro): Remove cast.
17070 * python/py-arch.c (archpy_name): Remove local variable.
17071 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17072
17073 2019-01-02 Joel Brobecker <brobecker@adacore.com>
17074
17075 * unittests/basic_string_view/element_access/char/empty.cc:
17076 Fix year range in copyright header.
17077
17078 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17079
17080 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17081 Delete.
17082 <operator==>: Update with for removed field.
17083 <hash>: Likewise.
17084 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17085 <isa_features>: ...this.
17086 <abi_features>: New field.
17087 (riscv_isa_flen): Update comment.
17088 (riscv_abi_xlen): New declaration.
17089 (riscv_abi_flen): New declaration.
17090 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17091 isa_features.
17092 (riscv_abi_xlen): New function.
17093 (riscv_isa_flen): Update to get answer from isa_features.
17094 (riscv_abi_flen): New function.
17095 (riscv_has_fp_abi): Update to get answer from abi_features.
17096 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17097 xlen and flen.
17098 (riscv_call_info) <xlen, flen>: Update comment.
17099 (riscv_call_arg_struct): Remove invalid assertions
17100 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17101 is removed.
17102 (riscv_gdbarch_init): Gather isa features and abi features
17103 separately, ensure both match on the gdbarch when reusing an old
17104 gdbarch. Relax an error check to allow 32-bit abi float to run on
17105 a target with 64-bit float hardware.
17106
17107 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17108
17109 * source.c (search_command_helper): Stop reverse search
17110 when line 1 has been searched.
17111
17112 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17113
17114 * record-full.c (record_full_base_target::close): Rewrite
17115 record_full_core_buf_list free logic.
17116
17117 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17118
17119 * break-catch-syscall.c (print_one_catch_syscall): xfree
17120 the last text.
17121
17122 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17123
17124 * top.c (print_gdb_version): Update Copyright year in version
17125 message.
17126
17127 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17128
17129 Update copyright year range in all GDB files.
17130
17131 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
17132
17133 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17134
17135 For older changes see ChangeLog-2018.
17136 \f
17137 Local Variables:
17138 mode: change-log
17139 left-margin: 8
17140 fill-column: 74
17141 version-control: never
17142 coding: utf-8
17143 End:
17144
This page took 0.414669 seconds and 4 git commands to generate.