gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
   4         Change type of "refresh_values_only".
   5         * tui/tui-regs.c (tui_data_window::show_register_group): Change
   6         type of "refresh_values_only".
   7
   8 2019-09-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  11         std::string.
  12         (tui_disassemble): Add "pos" parameter.
  13         (tui_disasm_window::set_contents): Simplify.
  14
  15 2019-09-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-winsource.h (struct tui_source_window_base)
  18         <show_source_content>: Now private.
  19         * tui/tui-winsource.c
  20         (tui_source_window_base::show_source_content): Don't handle empty
  21         content case.
  22
  23 2019-09-20  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-layout.c (show_source_disasm_command)
  26         (show_source_or_disasm_and_command): Don't call
  27         show_source_content.
  28
  29 2019-09-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
  32         Declare.
  33         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
  34         from tui_make_status_line.
  35         (tui_locator_window::rerender): Update.
  36
  37 2019-09-20  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-stack.c (tui_make_status_line): Return std::string.
  40         (tui_locator_window::rerender): Update.
  41
  42 2019-09-20  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.h (struct tui_source_window_base)
  45         <~tui_source_window_base>: Don't declare.
  46         <fullname>: Remove.
  47         * tui/tui-winsource.c (~tui_source_window_base): Remove.
  48         * tui/tui-source.h (struct tui_source_window) <fullname>: New
  49         member.
  50         * tui/tui-source.c (tui_source_window::set_contents): Update.
  51         (tui_source_window::location_matches_p)
  52         (tui_source_window::maybe_update): Update.
  53
  54 2019-09-20  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.h (~tui_source_element): Remove.
  57         (tui_source_element): Update.
  58         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
  59         * tui/tui-winsource.c (tui_show_source_line): Update.
  60         * tui/tui-source.c (tui_source_window::set_contents): Update.
  61         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  62
  63 2019-09-20  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
  66         declare.
  67         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
  68         tui_clear_source_windows_detail.
  69         * tui/tui-winsource.h (struct tui_source_window_base)
  70         <clear_detail>: Don't declare.
  71         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
  72         Remove.
  73         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
  74
  75 2019-09-20  Tom Tromey  <tromey@adacore.com>
  76
  77         PR ada/24919:
  78         * block.c (contained_in): Fix final return value.
  79
  80 2019-09-20  Alan Modra  <amodra@gmail.com>
  81
  82         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
  83         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
  84         (read_indirect_string_from_dwz): Use bfd accessor.
  85         * dwarf2read.h (struct dwz_file <filename>): Likewise.
  86         * machoread.c (macho_symfile_read_all_oso): Likewise.
  87         * solib.c (solib_bfd_open): Likewise.
  88
  89 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  90
  91         * eval.c: Move declaration of overload_resolution to...
  92         * value.h: ...here.
  93
  94 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
  97         * arm-linux-tdep.c: Likewise.
  98         * arm-nbsd-nat.c: Likewise.
  99         * arm-tdep.h: Declare arm_apcs_32.
 100         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 101
 102 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 103
 104         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 105         * dwarf2read.h: Declare dwarf_always_disassemble.
 106
 107 2019-09-19  Tom de Vries  <tdevries@suse.de>
 108
 109         PR gdb/25009
 110         * source-cache.c (source_cache::ensure): Catch exception thrown during
 111         construction of the highlighter.
 112
 113 2019-09-18  Alan Modra  <amodra@gmail.com>
 114
 115         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 116         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 117         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 118         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 119         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 120         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 121         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 122         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 123         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 124         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 125         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 126         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 127         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 128         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 129         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 130         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 131         * mi/mi-interp.c: Update throughout for bfd section macro and
 132         function changes.
 133         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 134         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 135
 136 2019-09-18  Tom Tromey  <tom@tromey.com>
 137
 138         * NEWS: Add entry.
 139         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 140         call rl_initialize.
 141         (tui_enable): Do not call rl_initialize.
 142
 143 2019-09-18  Christian Groessler  <chris@groessler.org>
 144
 145         * alpha-linux-nat.c: Include gdbarch.h.
 146
 147 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 148
 149         * ui-file.c: Include cli/cli-style.h.
 150         (term_cli_styling): Remove cli_styling declaration.
 151
 152 2019-09-18  Alan Modra  <amodra@gmail.com>
 153
 154         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 155         to bfd_asymbol_section.
 156
 157 2019-09-18  Alan Modra  <amodra@gmail.com>
 158
 159         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 160         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 161         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 162
 163 2019-09-18  Alan Modra  <amodra@gmail.com>
 164
 165         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 166         * spu-linux-nat.c (spu_bfd_open): Likewise.
 167
 168 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 171         to bool to match definition in dwarf2read.c.
 172
 173 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 176         (print_signatures): Likewise.
 177         (trust_pad_over_xvs): Likewise.
 178         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 179         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 180         * arm-linux-nat.c (arm_apcs_32): Likewise.
 181         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 182         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 183         * arm-tdep.c (arm_debug): Likewise.
 184         (arm_apcs_32): Likewise.
 185         * auto-load.c (debug_auto_load): Likewise.
 186         (auto_load_gdb_scripts): Likewise.
 187         (global_auto_load): Likewise.
 188         (auto_load_local_gdbinit): Likewise.
 189         (auto_load_local_gdbinit_loaded): Likewise.
 190         * auto-load.h (global_auto_load): Likewise.
 191         (auto_load_local_gdbinit): Likewise.
 192         (auto_load_local_gdbinit_loaded): Likewise.
 193         * breakpoint.c (disconnected_dprintf): Likewise.
 194         (breakpoint_proceeded): Likewise.
 195         (automatic_hardware_breakpoints): Likewise.
 196         (always_inserted_mode): Likewise.
 197         (target_exact_watchpoints): Likewise.
 198         (_initialize_breakpoint): Update.
 199         * breakpoint.h (target_exact_watchpoints): Change to bool.
 200         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 201         * cli/cli-cmds.c (trace_commands): Likewise.
 202         * cli/cli-cmds.h (trace_commands): Likewise.
 203         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 204         to bool*.
 205         * cli/cli-logging.c (logging_overwrite): Change to bool.
 206         (logging_redirect): Likewise.
 207         (debug_redirect): Likewise.
 208         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 209         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 210         to bool.
 211         <boolean_option_def>: Update.
 212         (struct flag_option_def): Change default type of Context to bool
 213         from int.
 214         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 215         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 216         (get_setshow_command_value_string): Likewise.
 217         * cli/cli-style.c (cli_styling): Change to bool.
 218         (source_styling): Likewise.
 219         * cli/cli-style.h (source_styling): Likewise.
 220         (cli_styling): Likewise.
 221         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 222         to bool.
 223         * command.h (var_types): Update comment.
 224         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 225         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 226         bool.
 227         (debug_compile_cplus_scopes): Likewise.
 228         * compile/compile-internal.h (compile_debug): Likewise.
 229         * compile/compile.c (compile_debug): Likewise.
 230         (struct compile_options) <raw>: Likewise.
 231         * cp-support.c (catch_demangler_crashes): Likewise.
 232         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 233         (usr_cmd_cris_dwarf2_cfi): Likewise.
 234         * csky-tdep.c (csky_debug): Likewise.
 235         * darwin-nat.c (enable_mach_exceptions): Likewise.
 236         * dcache.c (dcache_enabled_p): Likewise.
 237         * defs.h (info_verbose): Likewise.
 238         * demangle.c (demangle): Likewise.
 239         (asm_demangle): Likewise.
 240         * dwarf-index-cache.c (debug_index_cache): Likewise.
 241         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 242         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 243         * dwarf2read.c (check_physname): Likewise.
 244         (use_deprecated_index_sections): Likewise.
 245         (dwarf_always_disassemble): Likewise.
 246         * eval.c (overload_resolution): Likewise.
 247         * event-top.c (set_editing_cmd_var): Likewise.
 248         (exec_done_display_p): Likewise.
 249         * event-top.h (set_editing_cmd_var): Likewise.
 250         (exec_done_display_p): Likewise.
 251         * exec.c (write_files): Likewise.
 252         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 253         (debug_fbsd_nat): Likewise.
 254         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 255         Likewise.
 256         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 257         <backtrace_past_entry> Likewise.
 258         * gdb-demangle.h (demangle): Likewise.
 259         (asm_demangle): Likewise.
 260         * gdb_bfd.c (bfd_sharing): Likewise.
 261         * gdbcore.h (write_files): Likewise.
 262         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 263         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 264         * gdbthread.h (print_thread_events): Likewise.
 265         * gdbtypes.c (opaque_type_resolution): Likewise.
 266         (strict_type_checking): Likewise.
 267         * gnu-nat.c (gnu_debug_flag): Likewise.
 268         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 269         * guile/scm-param.c (pascm_variable): Add boolval.
 270         (add_setshow_generic): Update.
 271         (pascm_param_value): Update.
 272         (pascm_set_param_value_x): Update.
 273         * hppa-tdep.c (hppa_debug): Change to bool..
 274         * infcall.c (may_call_functions_p): Likewise.
 275         (coerce_float_to_double_p): Likewise.
 276         (unwind_on_signal_p): Likewise.
 277         (unwind_on_terminating_exception_p): Likewise.
 278         * infcmd.c (startup_with_shell): Likewise.
 279         * inferior.c (print_inferior_events): Likewise.
 280         * inferior.h (startup_with_shell): Likewise.
 281         (print_inferior_events): Likewise.
 282         * infrun.c (step_stop_if_no_debug): Likewise.
 283         (detach_fork): Likewise.
 284         (debug_displaced): Likewise.
 285         (disable_randomization): Likewise.
 286         (non_stop): Likewise.
 287         (non_stop_1): Likewise.
 288         (observer_mode): Likewise.
 289         (observer_mode_1): Likewise.
 290         (set_observer_mode): Update.
 291         (sched_multi): Change to bool.
 292         * infrun.h (debug_displaced): Likewise.
 293         (sched_multi): Likewise.
 294         (step_stop_if_no_debug): Likewise.
 295         (non_stop): Likewise.
 296         (disable_randomization): Likewise.
 297         * linux-tdep.c (use_coredump_filter): Likewise.
 298         (dump_excluded_mappings): Likewise.
 299         * linux-thread-db.c (auto_load_thread_db): Likewise.
 300         (check_thread_db_on_load): Likewise.
 301         * main.c (captured_main_1): Update.
 302         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 303         xx2_opt, boolean_opt>: Change to bool.
 304         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 305         * maint.c (maintenance_profile_p): Likewise.
 306         (per_command_time): Likewise.
 307         (per_command_space): Likewise.
 308         (per_command_symtab): Likewise.
 309         * memattr.c (inaccessible_by_default): Likewise.
 310         * mi/mi-main.c (mi_async): Likewise.
 311         (mi_async_1): Likewise.
 312         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 313         * nat/fork-inferior.h (startup_with_shell): Likewise.
 314         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 315         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 316         * nios2-tdep.c (nios2_debug): Likewise.
 317         * or1k-tdep.c (or1k_debug): Likewise.
 318         * parse.c (parser_debug): Likewise.
 319         * parser-defs.h (parser_debug): Likewise.
 320         * printcmd.c (print_symbol_filename): Likewise.
 321         * proc-api.c (procfs_trace): Likewise.
 322         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 323         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 324         (set_parameter_value): Update.
 325         (add_setshow_generic): Update.
 326         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 327         to bool*.
 328         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 329         int*.
 330         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 331         * record-btrace.c (record_btrace_target::store_registers): Update.
 332         * record-full.c (record_full_memory_query): Change to bool.
 333         (record_full_stop_at_limit): Likewise.
 334         * record-full.h (record_full_memory_query): Likewise.
 335         * remote-notif.c (notif_debug): Likewise.
 336         * remote-notif.h (notif_debug): Likewise.
 337         * remote.c (use_range_stepping): Likewise.
 338         (interrupt_on_connect): Likewise.
 339         (remote_break): Likewise.
 340         * ser-tcp.c (tcp_auto_retry): Likewise.
 341         * ser-unix.c (serial_hwflow): Likewise.
 342         * skip.c (debug_skip): Likewise.
 343         * solib-aix.c (solib_aix_debug): Likewise.
 344         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 345         (spu_auto_flush_cache_p): Likewise.
 346         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 347         Likewise.
 348         (struct info_print_options) <quiet>: Likewise.
 349         * symfile-debug.c (debug_symfile): Likewise.
 350         * symfile.c (auto_solib_add): Likewise.
 351         (separate_debug_file_debug): Likewise.
 352         * symfile.h (auto_solib_add): Likewise.
 353         (separate_debug_file_debug): Likewise.
 354         * symtab.c (basenames_may_differ): Likewise.
 355         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 356         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 357         (struct info_types_options) <quiet>: Likewise.
 358         * symtab.h (demangle): Likewise.
 359         (basenames_may_differ): Likewise.
 360         * target-dcache.c (stack_cache_enabled_1): Likewise.
 361         (code_cache_enabled_1): Likewise.
 362         * target.c (trust_readonly): Likewise.
 363         (may_write_registers): Likewise.
 364         (may_write_memory): Likewise.
 365         (may_insert_breakpoints): Likewise.
 366         (may_insert_tracepoints): Likewise.
 367         (may_insert_fast_tracepoints): Likewise.
 368         (may_stop): Likewise.
 369         (auto_connect_native_target): Likewise.
 370         (target_stop_and_wait): Update.
 371         (target_async_permitted): Change to bool.
 372         (target_async_permitted_1): Likewise.
 373         (may_write_registers_1): Likewise.
 374         (may_write_memory_1): Likewise.
 375         (may_insert_breakpoints_1): Likewise.
 376         (may_insert_tracepoints_1): Likewise.
 377         (may_insert_fast_tracepoints_1): Likewise.
 378         (may_stop_1): Likewise.
 379         * target.h (target_async_permitted): Likewise.
 380         (may_write_registers): Likewise.
 381         (may_write_memory): Likewise.
 382         (may_insert_breakpoints): Likewise.
 383         (may_insert_tracepoints): Likewise.
 384         (may_insert_fast_tracepoints): Likewise.
 385         (may_stop): Likewise.
 386         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 387         (make_thread_apply_all_options_def_group): Change argument from int*
 388         to bool*.
 389         (thread_apply_all_command): Update.
 390         (print_thread_events): Change to bool.
 391         * top.c (confirm): Likewise.
 392         (command_editing_p): Likewise.
 393         (history_expansion_p): Likewise.
 394         (write_history_p): Likewise.
 395         (info_verbose): Likewise.
 396         * top.h (confirm): Likewise.
 397         (history_expansion_p): Likewise.
 398         * tracepoint.c (disconnected_tracing): Likewise.
 399         (circular_trace_buffer): Likewise.
 400         * typeprint.c (print_methods): Likewise.
 401         (print_typedefs): Likewise.
 402         * utils.c (debug_timestamp): Likewise.
 403         (sevenbit_strings): Likewise.
 404         (pagination_enabled): Likewise.
 405         * utils.h (sevenbit_strings): Likewise.
 406         (pagination_enabled): Likewise.
 407         * valops.c (overload_resolution): Likewise.
 408         * valprint.h (struct value_print_options) <prettyformat_arrays,
 409         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 410         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 411         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 412         Likewise.
 413         * windows-nat.c (new_console): Likewise.
 414         (cygwin_exceptions): Likewise.
 415         (new_group): Likewise.
 416         (debug_exec): Likewise.
 417         (debug_events): Likewise.
 418         (debug_memory): Likewise.
 419         (debug_exceptions): Likewise.
 420         (useshell): Likewise.
 421         * windows-tdep.c (maint_display_all_tib): Likewise.
 422         * xml-support.c (debug_xml): Likewise.
 423
 424 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 425
 426         * source.c (prepare_path_for_appending): New function.
 427         (openp): Make use of new function.
 428         (find_and_open_source): Search for the compilation directory and
 429         source file as a relative path beneath the directory search path.
 430
 431 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * source-cache.c (source_cache::get_line_charpos): Catch
 434         exceptions and return false, this matches the behaviour documented
 435         in the header file.
 436
 437 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 438
 439         * ada-tasks.c (info_task): Remove quoting of the task's name.
 440
 441 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 442
 443         * symfile.c (auto_solib_add): Replace comment with a reference
 444         to the header file.
 445
 446 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 447
 448         * NEWS: Mention that gdb can now be compiled with Python 3
 449         on Windows.
 450
 451 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * maint.c (maint_print_section_data::maint_print_section_data):
 454         Force use of 'float log10 (float)' by casting the argument to
 455         float.
 456
 457 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * maint.c: Add 'cmath' include.
 460         (struct maint_print_section_data): New structure.
 461         (print_section_index): New function.
 462         (print_bfd_section_info): Add header comment, small whitespace
 463         cleanup, and update to call new print_section_index function.
 464         (print_objfile_section_info): Likewise.
 465         (maint_obj_section_from_bfd_section): New function.
 466         (print_bfd_section_info_maybe_relocated): New function.
 467         (maintenance_info_sections): Add header comment, always use
 468         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 469
 470 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 473         inner scope, add check that the objfile has psymtabs before
 474         checking psymtabs_addrmap.
 475         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 476
 477 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 478
 479         * NEWS: Announce that Ada task names are now shown at more places,
 480         and between quotes (except in info task output).
 481         * gdb/ada-tasks.c (task_to_str): New function.
 482         (display_current_task_id): Call task_to_str.
 483         (task_command_1): Likewise.
 484         (print_ada_task_info): In non-mi mode, Properly align headers and data
 485         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 486
 487 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 488
 489         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 490         prstatus.pr_lwp.pr_info instead of making it up.
 491
 492 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * auto-load.c (auto_load_expand_dir_vars): Update.
 495         * defs.h (gdb_datadir): Change to std::string.
 496         (python_libdir): Likewise.
 497         (relocate_gdb_directory): Change return type to std::string.
 498         * guile/guile.c (gdbscm_data_directory): Update.
 499         (initialize_scheme_side): Update.
 500         * jit.c (jit_reader_dir): Change to std::string.
 501         (jit_reader_load_command): Update.
 502         * main.c (gdb_datadir): Change to std::string.
 503         (python_libdir): Likewise.
 504         (set_gdb_data_directory): Update.
 505         (relocate_path): Change to return std::string.
 506         (relocate_gdb_directory): Change to return std::string.
 507         (relocate_gdbinit_path_maybe_in_datadir): Update.
 508         (captured_main_1): Update.
 509         * python/python.c (do_start_initialization): Update.
 510         * top.c (show_gdb_datadir): Update.
 511         * xml-syscall.c (xml_init_syscalls_info): Update.
 512         (init_syscalls_info): Update.
 513
 514 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 515
 516         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 517         out of get_init_files.
 518         (get_init_files): Update.
 519
 520 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * main.c (get_init_files): Change to use std::string.
 523         (captured_main_1): Update.
 524         (print_gdb_help): Update.
 525
 526 2019-09-11  Ali Tamur  <tamur@google.com>
 527
 528         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 529         implementation.
 530
 531 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 532
 533         * dbxread.c (read_dbx_symtab): Update.
 534         * dwarf2read.c (load_partial_dies): Update.
 535         * mdebugread.c (parse_partial_symbols): Update.
 536         (handle_psymbol_enumerators): Update.
 537         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 538         * psymtab.c (add_psymbol_to_bcache): Likewise.
 539         (add_psymbol_to_list): Likewise.
 540         * symtab.c (symbol_set_names): Likewise.
 541         * symtab.h (symbol_set_names): Likewise.
 542         * xcoffread.c (scan_xcoff_symtab): Update.
 543
 544 2019-09-11  Tom Tromey  <tom@tromey.com>
 545
 546         * symfile-mem.c (symbol_file_add_from_memory): Use
 547         bfd_set_filename.
 548         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 549         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 550
 551 2019-09-10  Tom Tromey  <tromey@adacore.com>
 552
 553         * dwarf-index-write.c (write_psymbols): Extend error message.
 554         (debug_names::insert): Add Ada code.
 555         (debug_names::write_psymbols): Remove Ada check.
 556         (debug_names) <m_string_obstack>: New member.
 557         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 558         (gdb_index_symbol_name_matcher::matches): Remove.
 559         (mapped_index_base::find_name_components_bounds): Add "lang"
 560         parameter.
 561         (mapped_index_base::build_name_components): Also split names
 562         according to Ada syntax.
 563         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 564         type of "match_callback".
 565         (check_match, check_find_bounds_finds)
 566         (dw2_expand_symtabs_matching): Update.
 567         (dw2_debug_names_iterator): Add new constructor.
 568         (dw2_debug_names_map_matching_symbols): New function.
 569         (dw2_debug_names_expand_symtabs_matching): Update.
 570         (dwarf2_debug_names_functions): Use
 571         dw2_debug_names_map_matching_symbols.
 572
 573 2019-09-10  Tom Tromey  <tromey@adacore.com>
 574
 575         * dwarf2read.c (dw2_get_file_names_reader): Add the
 576         CU's file name to the results.
 577
 578 2019-09-10  Tom Tromey  <tromey@adacore.com>
 579
 580         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 581         map_matching_symbols.  Update.
 582         * dwarf2read.c (dw2_map_matching_symbols): Update.
 583         * psymtab.c (match_partial_symbol): Change type; update.
 584         (psym_map_matching_symbols): Likewise.
 585         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 586         type; update.
 587         * symfile.h (struct quick_symbol_functions)
 588         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 589         Remove "match".
 590
 591 2019-09-10  Tom Tromey  <tromey@adacore.com>
 592
 593         * psymtab.c (map_block): Remove.
 594         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 595         * symtab.c (iterate_over_symbols_terminated): New function.
 596         * symtab.c (iterate_over_symbols_terminated): Declare.
 597
 598 2019-09-10  Tom Tromey  <tromey@adacore.com>
 599
 600         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 601         * language.h (struct language_defn) <la_iterate_over_symbols>:
 602         Return bool.
 603         * symtab.c (iterate_over_symbols): Return bool.
 604         * symtab.h (iterate_over_symbols): Return bool.
 605
 606 2019-09-10  Tom Tromey  <tromey@adacore.com>
 607
 608         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 609         (add_nonlocal_symbols): Update.
 610         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 611         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 612         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 613         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 614         Change type of "callback".  Remove "data".
 615
 616
 617 2019-09-09  Ali Tamur  <tamur@google.com>
 618
 619         * dwarf2read.c (comp_unit_head): Update comment.
 620         (dwarf2_dwo_name): New function declaration.
 621         (dwarf_unit_type_name): New function declaration.
 622         (read_comp_unit_head): Add support for new compilation units,
 623         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 624         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 625         (currently named as "signature") in their header. Also clarify error
 626         messages.
 627         (lookup_dwo_id): New function. Returns the dwo id of the given
 628         compile unit.
 629         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 630         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 631         functions.
 632         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 633         (dwarf2_dwo_name): Get the dwo name if present.
 634         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 635         purposes.
 636
 637 2019-09-09  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 640
 641 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 642
 643         * python/python.c (do_start_initialization): Make progname_copy static,
 644         to avoid a leak report.
 645
 646 2019-09-08  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 649
 650 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 651
 652         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 653         Change type to gdb::optional<block_enum>.
 654         (dw2_symtab_iter_init): Change block_index parameter type
 655         to gdb::optional<block_enum>.
 656         (dw2_lookup_symbol): Change block_index parameter
 657         type to block_enum.c
 658         (dw2_debug_names_lookup_symbol): Likewise.
 659         * psymtab.c (psym_lookup_symbol): Likewise.
 660         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 661         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 662         Likewise.
 663
 664 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * defs.h (relocate_gdb_directory): Change int to bool in
 667         signature and rename flag to relocatable.
 668         * main.c (relocate_path): Likewise.
 669         (relocate_gdb_directory): Likewise.
 670
 671 2019-09-06  Alan Modra  <amodra@gmail.com>
 672
 673         * coffread.c (coff_symfile_read): Constify filename variable.
 674         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 675         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 676         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 677         * solib.c (reload_shared_libraries_1): Likewise.
 678         * symfile.c (reread_symbols): Likewise.
 679         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 680         * solib-darwin.c (darwin_bfd_open): Likewise.
 681         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 682
 683 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 684
 685         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 686         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 687
 688 2019-09-03  Tom Tromey  <tromey@adacore.com>
 689
 690         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 691         types.
 692         (has_negatives): Unbias a range type bound.
 693         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 694         * gdbtypes.c (operator==): Handle new field.
 695         (create_range_type): Add "bias" parameter.
 696         (create_static_range_type, resolve_dynamic_range): Update.
 697         * gdbtypes.h (struct range_bounds) <bias>: New member.
 698         (create_range_type): Add bias parameter.
 699         * printcmd.c (print_scalar_formatted): Unbias range types.
 700         * value.c (unpack_long): Unbias range types.
 701         (pack_long): Bias range types.
 702
 703 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 704
 705         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 706         probe arguments.
 707
 708 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 709
 710         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 711         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 712         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 713         (compile_probe_arg): Likewise.
 714         * probe.h (get_argument_count): Likewise.
 715         * solib-svr4.c (solib_event_probe_action): Likewise.
 716         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 717
 718 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 719
 720         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 721         code to here...
 722         (svr4_create_solib_event_breakpoints): ...from here.
 723
 724 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 725
 726         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 727         suffix from warning message.
 728
 729 2019-08-30  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.h (struct tui_source_window_base)
 732         <refresh_all>: Don't declare.
 733         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 734         Remove.
 735         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 736         tui_show_locator_content.
 737         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 738         declare.
 739         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 740         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 741         declare.
 742
 743 2019-08-30  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 746
 747 2019-08-30  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 750         Remove unnecessary forward declarations.
 751
 752 2019-08-30  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 755         rerender.
 756         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 757         tui_show_locator_content.
 758
 759 2019-08-30  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 762         (tui_locator_window::rerender): Rewrite using body of previous
 763         tui_show_locator_content.
 764
 765 2019-08-30  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 768         set_locator_fullname>: New methods.
 769         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 770         Rename from tui_set_locator_fullname.
 771         (tui_locator_window::set_locator_info): Rename from
 772         tui_set_locator_info.  Return bool.
 773         (tui_update_locator_fullname, tui_show_frame_info): Update.
 774
 775 2019-08-30  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 778
 779 2019-08-30  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 782         call touchwin.
 783
 784 2019-08-30  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-wingeneral.c (box_win): Assume win_info and
 787         win_info->handle cannot be NULL.
 788
 789 2019-08-30  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 792         refresh_window>: Declare.
 793         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 794         resize.
 795         (tui_data_item_window::rerender): Rename from
 796         tui_display_register.
 797         (tui_data_item_window::refresh_window): New method.
 798         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 799         no-op.
 800
 801 2019-08-30  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 804         regs_column_count, current_group>: Move later.  Now private.
 805         <get_current_group>: New method.
 806         * tui/tui-regs.c (tui_reg_command): Update.
 807         * tui/tui-layout.c (tui_set_layout): Update.
 808
 809 2019-08-30  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 812         (tui_data_window::rerender): Don't call
 813         check_and_display_highlight_if_needed.
 814         (tui_data_window::refresh_all): Remove call to
 815         erase_data_content.
 816
 817 2019-08-30  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 820         (tui_data_window::display_registers_from)
 821         (tui_data_window::display_reg_element_at_line)
 822         (tui_data_window::display_registers_from_line): Remove checks of
 823         "empty".
 824
 825 2019-08-30  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 828         Don't declare.
 829         * tui/tui-regs.c (tui_data_window::show_registers): Call
 830         rerender.
 831         (tui_data_window::rerender): Rename from display_all_data.
 832         (tui_data_window::rerender): Remove old implementation.
 833
 834 2019-08-30  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 837         text.
 838         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 839
 840 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 841             Sergio Durigan Junior  <sergiodj@redhat.com>
 842
 843         PR win32/24284
 844         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 845
 846 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 849         when searching for types.
 850
 851 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * f-lang.c (f_language_defn): Use f_print_typedef.
 854         * f-lang.h (f_print_typedef): Declare.
 855         * f-typeprint.c (f_print_typedef): Define.
 856
 857 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 858
 859         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 860
 861 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * cli/cli-utils.c (info_print_options_defs): Delete.
 864         (make_info_print_options_def_group): Delete.
 865         (extract_info_print_options): Delete.
 866         (info_print_command_completer): Delete.
 867         (info_print_args_help): Add extra parameter, and optionally
 868         include text about -n flag.
 869         * cli/cli-utils.h (struct info_print_options): Delete.
 870         (extract_info_print_options): Delete declaration.
 871         (info_print_command_completer): Delete declaration.
 872         (info_print_args_help): Add extra parameter, extend header
 873         comment.
 874         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 875         search_symbols.
 876         * stack.c (struct info_print_options): New type.
 877         (info_print_options_defs): New file scoped variable.
 878         (make_info_print_options_def_group): New static function.
 879         (info_print_command_completer): New static function.
 880         (info_locals_command): Update to use new local functions.
 881         (info_args_command): Likewise.
 882         (_initialize_stack): Add extra parameter to calls to
 883         info_print_args_help.
 884         * symtab.c (search_symbols): Add extra parameter, use this to
 885         possibly excluse non-debug symbols.
 886         (symtab_symbol_info): Add extra parameter, which is passed on to
 887         search_symbols.
 888         (struct info_print_options): New type.
 889         (info_print_options_defs): New file scoped variable.
 890         (make_info_print_options_def_group): New static function.
 891         (info_print_command_completer): New static function.
 892         (info_variables_command): Update to use local functions, and pass
 893         extra parameter through to symtab_symbol_info.
 894         (info_functions_command): Likewise.
 895         (info_types_command): Pass additional argument through to
 896         symtab_symbol_info.
 897         (rbreak_command): Pass extra argument to search_symbols.
 898         (_initialize_symtab): Add extra arguments for calls to
 899         info_print_args_help, and update help text for 'info variables',
 900         'whereis', and 'info functions' commands.
 901         * symtab.h (search_symbols): Add extra argument to declaration.
 902         * NEWS: Mention new flags.
 903
 904 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 905
 906         * symtab.c (lookup_static_symbol): Call the new function (and move
 907         it down to be next to lookup_global_symbol).
 908         (struct global_sym_lookup_data): Add block_enum member and rename to...
 909         (struct global_or_static_sym_lookup_data): ...this.
 910         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 911         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 912         (lookup_symbol_global_or_static_iterator_cb): ...this.
 913         (lookup_global_or_static_symbol): New function.
 914         (lookup_global_symbol): Call new function.
 915
 916 2019-08-26  Tom de Vries  <tdevries@suse.de>
 917
 918         PR c++/24852
 919         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 920         when pc_probe.prob == NULL.
 921
 922 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 923
 924         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 925         variable symbol_linkage to symbol_linkage_.
 926
 927 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 928
 929         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 930         represent whether the symbol is static, dynamic, or we don't
 931         know.
 932
 933 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 934
 935         * gdb/rx-tdep.c (rx_register_names): New.
 936         (rx_register_name): Delete.
 937         (rx_psw_type): Delete.
 938         (rx_fpsw_type): Delete.
 939         (rx_register_type): Delete.
 940         (rx_gdbarch_init): Convert target-descriptions.
 941         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 942         * gdb/features/Makefile: Add rx.xml.
 943         * gdb/features/rx.xml: New.
 944         * gdb/features/rx.c: Generated.
 945         * gdb/NEWS: Mention target description support.
 946
 947 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 948
 949         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 950         *slot_ptr.
 951
 952 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 953
 954         * configure.ac: Don't check for 'dlfcn.h' (moved to
 955         gdbsupport/common.m4).
 956         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 957         'gdbsupport/'.
 958         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 959         * compile/compile-c-support.c: Include
 960         'gdbsupport/gdb-dlfcn.h'.
 961         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 962         * gdb-dlfcn.c: Move to...
 963         * gdbsupport/gdb-dlfcn.c: ... here.
 964         * gdb-dlfcn.h: Move to...
 965         * gdbsupport/gdb-dlfcn.h: ... here.
 966
 967 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 968
 969         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 970         the offset field signed.
 971
 972 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 973
 974         * python/lib/gdb/__init__.py (_execute_file): New function.
 975         * python/python.c (python_run_simple_file): Call gdb._execute_file
 976         on Windows.
 977
 978 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 979
 980         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 981         all uses as this was never set to anything but a zero value.
 982
 983 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 984
 985         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 986
 987 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 988
 989         * tui/tui-data.h (tui_gen_win_info): Add an =default
 990         move constructor, required by some GCC versions.
 991
 992 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 993
 994         * go32-nat.c (go32_sysinfo): Add hygon_p.
 995
 996 2019-08-20  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 999         line_from_reg_element_no, first_reg_element_no_inline,
1000         display_all_data, delete_data_content_windows,
1001         erase_data_content>: Now private.
1002
1003 2019-08-20  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1006         (tui_unhighlight_win, tui_highlight_win)
1007         (tui_win_info::make_window): Update.
1008         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1009
1010 2019-08-20  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1013         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1014         (MAX_PID_WIDTH): Move to tui-stack.c.
1015         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1016         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1017         (MAX_PID_WIDTH): Move from tui-data.h.
1018
1019 2019-08-20  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1022         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1023         (box_win): Update.
1024         (tui_gen_win_info::make_window): Rename from tui_make_window.
1025         (tui_win_info::make_window): New method.
1026         (tui_gen_win_info::make_visible): Update.
1027         * tui/tui-source.c (tui_source_window::set_contents): Update.
1028         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1029         (tui_data_window::display_registers_from): Update.
1030         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1031         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1032         Declare.
1033         <can_box>: Remove.
1034         <title>: Remove.
1035         (struct tui_win_info) <make_window>: Declare.
1036         <can_box>: Now virtual.
1037         <title>: New member.
1038         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1039         * tui/tui-command.c (tui_cmd_window::resize): Update.
1040
1041 2019-08-20  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1044         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1045         (tui_data_window::check_register_values): Update.
1046
1047 2019-08-20  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-regs.h (struct tui_data_window): Use
1050         DISABLE_COPY_AND_ASSIGN.
1051         <regs_content>: Change type, removing unique_ptr.
1052         <tui_data_window>: Add move constructor.
1053         * tui/tui-regs.c (tui_data_window::show_registers)
1054         (tui_data_window::show_register_group)
1055         (tui_data_window::display_registers_from)
1056         (tui_data_window::display_registers_from)
1057         (tui_data_window::first_data_item_displayed)
1058         (tui_data_window::delete_data_content_windows)
1059         (tui_data_window::rerender, tui_data_window::refresh_window)
1060         (tui_data_window::check_register_values): Update.
1061
1062 2019-08-20  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1065         show_register_group>: Declare.
1066         (tui_show_register_group): Don't declare.
1067         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1068         tui_show_registers.
1069         (tui_data_window::show_register_group): Rename from
1070         tui_show_register_group.
1071         (tui_data_window::check_register_values, tui_reg_command):
1072         Update.
1073         * tui/tui-layout.c (tui_set_layout): Update.
1074
1075 2019-08-20  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1078         Declare.
1079         (tui_check_register_values): Don't declare.
1080         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1081         from tui_check_register_values.
1082         * tui/tui-hooks.c (tui_register_changed): Update.
1083
1084 2019-08-20  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-regs.c (tui_reg_layout): Move later.
1087         (tui_show_registers): Don't enable TUI mode or change layout.
1088
1089 2019-08-20  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-regs.h (struct tui_data_item_window)
1092         <~tui_data_item_window>: Remove.
1093         <content>: Now a unique_xmalloc_ptr.
1094         * tui/tui-regs.c (tui_register_format): Return a
1095         unique_xmalloc_ptr.
1096         (tui_get_register): Update.
1097         (~tui_data_item_window): Remove.
1098         (tui_data_window::display_registers_from, tui_display_register):
1099         Update.
1100         * tui/tui-io.h (tui_expand_tabs): Update.
1101         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1102         Remove "col" parameter.
1103
1104 2019-08-20  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1107         field.
1108         * tui/tui-regs.c (~tui_data_item_window): Update.
1109
1110 2019-08-20  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1113         earlier.
1114
1115 2019-08-20  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1118
1119 2019-08-20  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-source.h (struct tui_source_window): Update.
1122         * tui/tui-regs.c (tui_show_registers): Update.
1123         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1124         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1125         (NO_REGS_STRING): Remove defines.
1126
1127 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1128
1129         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1130         unnecessary thread walk if remote doesn't support the packet.
1131
1132 2019-08-19  Tom Tromey  <tromey@adacore.com>
1133
1134         * python/py-value.c (value_has_field): Fix indentation.
1135
1136 2019-08-19  Tom Tromey  <tromey@adacore.com>
1137
1138         * printcmd.c (do_one_display, info_display_command): Update.
1139         * block.h (contained_in): Return bool.  Add allow_nested
1140         parameter.
1141         * block.c (contained_in): Return bool.  Add allow_nested
1142         parameter.
1143
1144 2019-08-19  Tom Tromey  <tom@tromey.com>
1145
1146         * configure: Rebuild.
1147         * configure.ac: Disallow the combination of -static-libstdc++ and
1148         source highlight.
1149         * source-cache.c (get_language_name): Handle rust.
1150         (source_cache::get_source_lines): Ignore highlighting exceptions.
1151
1152 2019-08-16  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1155         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1156         (struct tui_source_window_base) <make_visible, refresh_window,
1157         resize>: Remove methods.
1158         <execution_info>: Remove field.
1159         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1160         (tui_show_source_line, tui_source_window_base)
1161         (~tui_source_window_base): Update.
1162         (tui_source_window_base::resize)
1163         (tui_source_window_base::make_visible)
1164         (tui_source_window_base::refresh_window): Remove.
1165         (tui_source_window_base::update_exec_info): Update.
1166         * tui/tui-source.c (tui_source_window::set_contents): Update.
1167         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1168
1169 2019-08-16  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1172         deprecated_query_hook.
1173
1174 2019-08-16  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1177         (tui_update_source_windows_with_line): Update.
1178         * tui/tui-source.h (struct tui_source_window)
1179         <show_symtab_source>: Declare.
1180         (tui_show_symtab_source): Don't declare.
1181         * tui/tui-source.c (tui_show_symtab_source): Rename from
1182         tui_show_symtab_source.
1183
1184 2019-08-16  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-winsource.h (struct tui_source_window_base)
1187         <set_contents>: Declare.
1188         * tui/tui-winsource.c
1189         (tui_source_window_base::update_source_window_as_is): Update.
1190         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1191         Declare.
1192         (tui_set_source_content): Don't declare.
1193         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1194         tui_set_source_content.
1195         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1196         Declare.
1197         (tui_set_disassem_content): Don't declare.
1198         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1199         tui_set_disassem_content.
1200
1201 2019-08-16  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-winsource.h (struct tui_source_window_base)
1204         <update_breakpoint_info>: Declare.
1205         (tui_update_breakpoint_info): Don't declare.
1206         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1207         (tui_update_all_breakpoint_info): Update.
1208         (tui_source_window_base::update_breakpoint_info): Rename from
1209         tui_update_breakpoint_info.
1210         (tui_source_window_base::update_exec_info): Update.
1211
1212 2019-08-16  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-winsource.h (struct tui_source_window_base)
1215         <update_source_window>: Declare.
1216         (tui_update_source_window): Don't declare.
1217         * tui/tui-winsource.c
1218         (tui_source_window_base::update_source_window): Rename from
1219         tui_update_source_window.
1220         (tui_source_window_base::rerender): Update.
1221         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1222         * tui/tui-disasm.c (tui_show_disassem)
1223         (tui_show_disassem_and_update_source)
1224         (tui_disasm_window::maybe_update): Update.
1225
1226 2019-08-16  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-winsource.h (struct tui_source_window_base)
1229         <update_source_window_as_is>: Declare.
1230         (tui_update_source_window_as_is): Don't declare.
1231         * tui/tui-winsource.c (tui_update_source_window): Update
1232         (tui_source_window_base::update_source_window_as_is): Rename from
1233         tui_update_source_window_as_is.
1234         (tui_source_window_base::refill): Update.
1235         * tui/tui-source.c (tui_show_symtab_source): Update.
1236         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1237         Update.
1238
1239 2019-08-16  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.h (tui_update_source_window)
1242         (tui_update_source_window_as_is): Remove "noerror" parameter.
1243         * tui/tui-winsource.c (tui_update_source_window)
1244         (tui_update_source_window_as_is): Remove "noerror" parameter.
1245         (tui_update_source_windows_with_addr)
1246         (tui_update_source_windows_with_line)
1247         (tui_source_window_base::rerender)
1248         (tui_source_window_base::refill): Update.
1249         * tui/tui-source.h (tui_set_source_content)
1250         (tui_show_symtab_source): Remove "noerror" parameter.
1251         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1252         parameter.
1253         (tui_show_symtab_source): Likewise.
1254         (tui_source_window::maybe_update): Update.
1255         * tui/tui-disasm.c (tui_show_disassem)
1256         (tui_show_disassem_and_update_source)
1257         (tui_disasm_window::do_scroll_vertical)
1258         (tui_disasm_window::maybe_update): Update.
1259
1260 2019-08-16  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui.c (tui_is_window_visible): Update.
1263         * tui/tui-wingeneral.c (tui_make_window)
1264         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1265         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1266         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1267         (tui_set_win_height_command, parse_scrolling_args): Update.
1268         * tui/tui-source.c (tui_source_window::style_changed): Update.
1269         * tui/tui-regs.c (tui_show_registers)
1270         (tui_data_window::first_data_item_displayed)
1271         (tui_data_window::delete_data_content_windows)
1272         (tui_check_register_values, tui_reg_command): Update.
1273         * tui/tui-disasm.c (tui_show_disassem): Update.
1274         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1275         method.
1276         <is_visible>: Remove field.
1277         * tui/tui-data.c (tui_next_win, tui_prev_win)
1278         (tui_delete_invisible_windows): Update.
1279
1280 2019-08-16  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-winsource.h (struct tui_source_window_base)
1283         <m_has_locator>: Remove.
1284         * tui/tui-layout.c (show_source_disasm_command, show_data)
1285         (show_source_or_disasm_and_command): Update.
1286
1287 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1288
1289         * NEWS (Other MI changes): New subsection.
1290         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1291         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1292         * arch-utils.c (default_get_pc_address_flags): New function.
1293         * arch-utils.h (default_get_pc_address_flags): New declaration.
1294         * gdbarch.sh: Add get_pc_address_flags.
1295         * gdbarch.c: Regenerate.
1296         * gdbarch.h: Likewise.
1297         * stack.c (print_pc): New function.
1298         (print_frame_info) (print_frame): Call print_pc.
1299
1300 2019-08-16  Tom de Vries  <tdevries@suse.de>
1301
1302         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1303         print_objfile_section_info.
1304
1305 2019-08-15  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1308         calling update_cmdwin_start_line.
1309         * tui/tui-winsource.h (struct tui_source_window_base)
1310         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1311         <rerender>: Declare.
1312         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1313         Call rerender.
1314         (tui_source_window_base::set_new_height): Remove.
1315         (tui_source_window_base::rerender): Rename from
1316         do_make_visible_with_new_height.
1317         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1318         resize method.
1319         (tui_win_info::make_invisible_and_set_new_height)
1320         (tui_win_info::make_visible_with_new_height): Remove.
1321         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1322         Declare.
1323         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1324         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1325         do_make_visible_with_new_height>: Don't declare.
1326         <rerender>: Declare.
1327         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1328         set_new_height.
1329         (tui_data_window::do_make_visible_with_new_height): Remove.
1330         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1331         call tui_show_locator_content.
1332         (tui_gen_win_info::resize): Call rerender.
1333         (show_source_or_disasm_and_command): Don't call
1334         tui_show_locator_content.
1335         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1336         method.
1337         (struct tui_win_info) <rerender>: Declare.
1338         <set_new_height, make_invisible_and_set_new_height,
1339         make_visible_with_new_height>: Don't declare.
1340         * tui/tui-data.c (tui_win_list::rerender): New method.
1341         * tui/tui-command.h (struct tui_cmd_window)
1342         <do_make_visible_with_new_height>: Don't declare.
1343         * tui/tui-command.c
1344         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1345
1346 2019-08-15  Tom Tromey  <tromey@adacore.com>
1347
1348         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1349         * ada-lang.c (ada_enum_name): Likewise.
1350
1351 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1352
1353         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1354         leading underscore.
1355         (GdbOutputErrorFile): Likewise.
1356         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1357         accordingly.
1358         (execute_unwinders): Rename to have a leading underscore.
1359         (auto_load_packages): Likewise.
1360         (global scope): Adjust call to auto_load_packages accordingly.
1361         (GdbSetPythonDirectory): Likewise.
1362         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1363         instead of execute_unwinders.
1364
1365 2019-08-15  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1368         (show_data): Don't change window visibility.
1369         (tui_gen_win_info::resize): Remove special case for command
1370         window.  Use wresize, when available.
1371         (show_source_or_disasm_and_command): Don't change window
1372         visibility.
1373         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1374         <make_visible>: New method.
1375         * tui/tui-command.c (tui_cmd_window::resize): New method.
1376
1377 2019-08-15  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1380         (struct tui_source_windows): New.
1381         * tui/tui-winsource.c (tui_display_main): Update.
1382         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1383         (new_height_ok, parse_scrolling_args): Update.
1384         * tui/tui-layout.c (show_layout, show_data): Update.
1385         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1386         (tui_add_to_source_windows): Don't declare.
1387         * tui/tui-data.c (source_windows, tui_source_windows)
1388         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1389
1390 2019-08-15  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1393         Rename from reset.
1394         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1395         * tui/tui-layout.c (show_source_disasm_command, show_data):
1396         Update.
1397         (tui_gen_win_info::resize): Rename.
1398         (show_source_or_disasm_and_command): Update.
1399         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1400         reset.
1401
1402 2019-08-15  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1405         * tui/tui-interp.c (tui_interp::init): Don't call
1406         tui_initialize_static_data.
1407         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1408
1409 2019-08-15  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1412         examine tui_win_list.
1413
1414 2019-08-15  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1417         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1418         tui_clear_source_content.
1419         (tui_clear_source_content): Remove.
1420         (tui_source_window_base::do_erase_source_content): Hoist call to
1421         content.clear().
1422         * tui/tui-stack.c (tui_show_frame_info): Don't call
1423         tui_clear_source_content.
1424
1425 2019-08-15  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-winsource.h (struct tui_source_window_base)
1428         <do_erase_source_content>: New method.
1429         <erase_source_content>: New method.
1430         (tui_erase_source_content): Don't declare.
1431         * tui/tui-winsource.c (tui_clear_source_content): Update.
1432         (tui_source_window_base::do_erase_source_content): Rename from
1433         tui_erase_source_content.
1434         (tui_source_window_base::show_source_content): Update.
1435         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1436         * tui/tui-source.h (struct tui_source_window)
1437         <erase_source_content>: New method.
1438         * tui/tui-disasm.h (struct tui_disasm_window)
1439         <erase_source_content>: New method.
1440
1441 2019-08-15  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1444         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1445         constructor.
1446         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1447         * tui/tui-source.c (tui_set_source_content): Update.
1448         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1449
1450 2019-08-15  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1453         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1454         tui-source.c.
1455         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1456         Declare.
1457         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1458         method.
1459         (tui_source_window::maybe_update): Update.
1460
1461 2019-08-15  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1464         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1465         tui-disasm.c.
1466         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1467         Declare.
1468         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1469         method.
1470         (tui_disasm_window::maybe_update): Update.
1471
1472 2019-08-15  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-winsource.h (struct tui_source_window_base)
1475         <maybe_update>: Declare.
1476         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1477         method.
1478         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1479         Declare.
1480         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1481         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1482         Declare.
1483         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1484
1485 2019-08-15  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1488
1489 2019-08-15  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-wingeneral.c: Include tui-stack.h.
1492         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1493         (struct tui_locator_window): Move from tui-data.h.
1494         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1495         (tui_initialize_static_data): Move from tui-data.c.
1496         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1497         (struct tui_locator_window): Move to tui-stack.c.
1498         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1499         (tui_initialize_static_data): Move to tui-stack.c.
1500
1501 2019-08-15  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-layout.c (show_source_disasm_command)
1504         (show_source_or_disasm_and_command): Use make_visible method, not
1505         tui_make_window.
1506         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1507         Remove.
1508
1509 2019-08-15  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-wingeneral.h (tui_make_window): Update.
1512         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1513         parameter.
1514         (tui_gen_win_info::make_visible): Update.
1515         * tui/tui-regs.c (tui_data_window::display_registers_from):
1516         Update.
1517         * tui/tui-layout.c (show_source_disasm_command)
1518         (show_source_or_disasm_and_command): Update.
1519         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1520         (enum tui_box): Remove.
1521         (struct tui_win_info) <can_box>: New method.
1522         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1523         method.
1524
1525 2019-08-15  Tom de Vries  <tdevries@suse.de>
1526
1527         * linux-nat-trad.c: Include gdbarch.h.
1528
1529 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1532         register sizes.
1533
1534 2019-08-14  Tom Tromey  <tromey@adacore.com>
1535
1536         * darwin-nat.c: Include gdbarch.h.
1537         * darwin-nat-info.c: Include gdbarch.h.
1538
1539 2019-08-13  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1542         Remove.
1543         * tui/tui-data.c (tui_initialize_static_data): Update.
1544
1545 2019-08-13  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (struct tui_exec_info_window)
1548         <~tui_exec_info_window, maybe_allocate_content, get_content,
1549         m_content>: Remove.
1550         (struct tui_source_window_base) <set_exec_info_content,
1551         show_exec_info_content>: Don't declare.
1552         * tui/tui-winsource.c
1553         (tui_exec_info_window::maybe_allocate_content): Remove.
1554         (tui_source_window_base::update_exec_info): Rename from
1555         set_exec_info_content.
1556         (tui_source_window_base::show_exec_info_content)
1557         (tui_source_window_base::update_exec_info): Remove.
1558
1559 2019-08-13  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1562         declare.
1563         * tui/tui-winsource.c (tui_update_source_window_as_is)
1564         (tui_update_source_windows_with_addr, tui_erase_source_content):
1565         Update.
1566         (tui_clear_exec_info_content): Remove.
1567
1568 2019-08-13  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1571         declare.
1572         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1573         call tui_erase_exec_info_content.
1574         (tui_clear_exec_info_content): Rename from
1575         tui_erase_exec_info_content.
1576         (tui_clear_exec_info_content): Delete.
1577
1578 2019-08-13  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-winsource.h (struct tui_source_window_base)
1581         <show_exec_info_content>: Declare.
1582         (tui_show_exec_info_content): Don't declare.
1583         * tui/tui-winsource.c
1584         (tui_source_window_base::show_exec_info_content): Rename from
1585         tui_show_exec_info_content.
1586         (tui_source_window_base::update_exec_info): Update.
1587
1588 2019-08-13  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1591         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1592         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1593         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1594         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1595         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1596         ... here.
1597
1598 2019-08-13  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-winsource.h (struct tui_source_window_base)
1601         <update_exec_info>: Declare.
1602         (tui_update_exec_info): Don't declare.
1603         * tui/tui-winsource.c (tui_update_source_window_as_is)
1604         (tui_source_window_base::refresh_all)
1605         (tui_update_all_breakpoint_info): Update.
1606         (tui_source_window_base::update_exec_info): Rename from
1607         tui_update_exec_info.
1608         * tui/tui-stack.c (tui_show_frame_info): Update.
1609
1610 2019-08-13  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-winsource.h (struct tui_source_window_base)
1613         <set_exec_info_content>: Declare.
1614         (tui_set_exec_info_content): Don't declare.
1615         * tui/tui-winsource.c
1616         (tui_source_window_base::set_exec_info_content): Rename from
1617         tui_set_exec_info_content.
1618         (tui_update_exec_info): Update.
1619
1620 2019-08-13  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-winsource.h (struct tui_source_window_base)
1623         <show_source_content>: Declare.
1624         (tui_show_source_content): Don't declare.
1625         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1626         (tui_source_window_base::show_source_content): Rename from
1627         tui_show_source_content.
1628         (tui_source_window_base::refresh_all): Update.
1629         * tui/tui-layout.c (show_source_disasm_command)
1630         (show_source_or_disasm_and_command): Update.
1631
1632 2019-08-13  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-winsource.c (tui_erase_source_content)
1635         (tui_show_source_content, tui_source_window_base::refresh_all):
1636         Update.
1637         * tui/tui-wingeneral.h
1638         (tui_check_and_display_highlight_if_needed): Don't declare.
1639         * tui/tui-wingeneral.c
1640         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1641         check_and_display_highlight_if_needed.
1642         * tui/tui-win.c (tui_rehighlight_all)
1643         (tui_win_info::make_visible_with_new_height): Update.
1644         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1645         (tui_data_window::erase_data_content)
1646         (tui_data_window::display_all_data): Update.
1647         * tui/tui-data.h (struct tui_win_info)
1648         <check_and_display_highlight_if_needed>: Declare.
1649
1650 2019-08-13  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-win.c (tui_resize_all): Call
1653         tui_delete_invisible_windows.
1654         * tui/tui-layout.c (show_layout): Call
1655         tui_delete_invisible_windows.
1656         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1657         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1658
1659 2019-08-13  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1662         tui_add_win_to_layout.
1663
1664 2019-08-13  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1667         * tui/tui-layout.c (tui_default_win_height): Now static.
1668
1669 2019-08-13  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1672         single switch.
1673         (show_source_disasm_command, show_source_or_disasm_and_command):
1674         Don't check current layout.
1675
1676 2019-08-13  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-wingeneral.c (make_all_visible): Remove.
1679         (tui_make_all_invisible): Simplify.
1680         * tui/tui-layout.c (tui_make_all_invisible): Move from
1681         tui-wingeneral.c; simplify.
1682         (show_layout): Hoist call to tui_make_all_invisible.
1683         (show_data): Don't call tui_make_all_invisible.
1684
1685 2019-08-13  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1688         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1689
1690 2019-08-13  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1693         tui-data.c.
1694         (show_source_disasm_command, show_data)
1695         (show_source_or_disasm_and_command): Don't use
1696         tui_set_current_layout_to.
1697         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1698         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1699         tui-layout.c.
1700         (tui_set_current_layout_to): Remove.
1701
1702 2019-08-13  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-layout.c (tui_set_layout): Update.
1705         * tui/tui-data.h (struct tui_layout_def): Remove.
1706         (tui_layout_def): Don't declare.
1707         * tui/tui-data.c (layout_def): Remove.
1708         (tui_layout_def): Remove.
1709
1710 2019-08-13  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-winsource.h (struct tui_source_window_base)
1713         <clear_detail>: No longer "override".
1714         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1715         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1716         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1717         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1718         Remove.
1719         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1720
1721 2019-08-13  Tom Tromey  <tromey@adacore.com>
1722
1723         * tracepoint.c: Don't include readline.h or history.h.
1724
1725 2019-08-12  Tom Tromey  <tom@tromey.com>
1726
1727         * configure: Rebuild.
1728         * configure.ac: Check for readline 7.
1729         * NEWS: Mention readline 7 requirement.
1730         * README: Update.
1731
1732 2019-08-12  Tom Tromey  <tom@tromey.com>
1733
1734         * mingw-hdep.c (gdb_select): Remove readline hack.
1735
1736 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1737
1738         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1739         when the function fails.
1740
1741 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1742
1743         * s390-tdep.c (s390_type_align): New function.
1744         (s390_gdbarch_init): Set it as type_align gdbarch method.
1745
1746 2019-08-09  Tom de Vries  <tdevries@suse.de>
1747
1748         PR gdb/24591
1749         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1750         pc_low with relocation offset.
1751
1752 2019-08-07  Tom Tromey  <tromey@adacore.com>
1753
1754         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1755         (print_frame_args): Update.
1756         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1757         Update.
1758         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1759         * frame.h (struct frame_arg): Add initializers.
1760         <error>: Now a unique_xmalloc_ptr.
1761
1762 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1763
1764         * NEWS: Expand the Pointer Authentication entry.
1765         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1766         (aarch64_frame_unmask_lr): ... to this.
1767         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1768         Call aarch64_frame_unmask_lr.
1769         * frame.c (struct frame_info): Add "masked" variable.
1770         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1771         (fprint_frame): Check for masked pc.
1772         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1773         declarations.
1774         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1775         * stack.c (print_frame): Check for masked pc.
1776
1777 2019-08-06  Tom Tromey  <tom@tromey.com>
1778
1779         * stabsread.c (patch_block_stabs, read_one_struct_field)
1780         (read_enum_type): Use obstack_strndup.
1781         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1782         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1783         * dwarf2read.c (guess_full_die_structure_name)
1784         (anonymous_struct_prefix): Use obstack_strndup.
1785         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1786         * c-exp.y (yylex): Use obstack_strndup.
1787         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1788         (write_var_or_type): Use obstack_strndup.
1789
1790 2019-08-06  Tom Tromey  <tom@tromey.com>
1791
1792         * symfile.c (reread_symbols): Use obstack_strdup.
1793         * stabsread.c (read_type): Use obstack_strdup.
1794         * gdb_obstack.h (obstack_strdup): New overload.
1795         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1796         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1797         (dwarf2_canonicalize_name): Use obstack_strdup.
1798         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1799         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1800         Use obstack_strdup.
1801
1802 2019-08-06  Tom Tromey  <tom@tromey.com>
1803
1804         * gdb_obstack.h (obstack_strdup): Define.
1805         * gdb_obstack.c (obstack_strdup): Don't define.
1806
1807 2019-08-06  Tom Tromey  <tom@tromey.com>
1808
1809         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1810         obstack_strdup.
1811         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1812         obstack_strdup.
1813         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1814         * stabsread.c (common_block_start): Use obstack_strdup.
1815         * objfiles.c (set_objfile_main_name, objfile): Use
1816         obstack_strdup.
1817         * namespace.c (add_using_directive): Use obstack_strdup.
1818         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1819         * jit.c (finalize_symtab): Use obstack_strdup.
1820         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1821         (guess_partial_die_structure_name, partial_die_info::fixup)
1822         (dwarf2_name): Use obstack_strdup.
1823         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1824         obstack_strdup.
1825         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1826         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1827         obstack_strdup.
1828         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1829
1830 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1831
1832         * unittests/help-doc-selftests.c: New file.
1833         * Makefile.in: Add the new file.
1834
1835 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1836
1837         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1838         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1839         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1840         the trailing '.' is not output, and the first character is uppercased.
1841         (print_help_for_command): Update call to print_doc_line.
1842         (print_doc_of_command): Likewise.
1843         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1844         * cli/cli-option.c (append_indented_doc): Do not append newline.
1845         (build_help_option): Append newline after first appended_indented_doc
1846         only if a second call is done.
1847         (build_help): Append 2 new lines before each option, except the first
1848         one.
1849         * compile/compile.c (_initialize_compile): Add new lines after
1850         %OPTIONS%, when not at the end of the help.
1851         Change help doc or code
1852         producing the help doc to respect the invariants.
1853         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1854         Also removed the new line after 'Options:', as all other commands
1855         do not put an empty line between 'Options:' and the first option.
1856         * printcmd.c (_initialize_printcmd): Likewise.
1857         * stack.c (_initialize_stack): Likewise.
1858         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1859         incorrectly telling COMMAND is optional.
1860         * ada-lang.c (_initialize_ada_language): Change help doc or code
1861         producing the help doc to respect the invariants.
1862         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1863         * breakpoint.c (_initialize_breakpoint): Likewise.
1864         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1865         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1866         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1867         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1868         _initialize_cli_style): Likewise.
1869         * corelow.c (core_target_info): Likewise.
1870         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1871         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1872         * filesystem.c (_initialize_filesystem): Likewise.
1873         * frame.c (_initialize_frame): Likewise.
1874         * gnu-nat.c (add_task_commands): Likewise.
1875         * infcall.c (_initialize_infcall): Likewise.
1876         * infcmd.c (_initialize_infcmd): Likewise.
1877         * interps.c (_initialize_interpreter): Likewise.
1878         * language.c (_initialize_language): Likewise.
1879         * linux-fork.c (_initialize_linux_fork): Likewise.
1880         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1881         * maint.c (_initialize_maint_cmds): Likewise.
1882         * memattr.c (_initialize_mem): Likewise.
1883         * printcmd.c (_initialize_printcmd): Likewise.
1884         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1885         _RegEx): Likewise.
1886         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1887         * record-btrace.c (_initialize_record_btrace): Likewise.
1888         * record-full.c (_initialize_record_full): Likewise.
1889         * record.c (_initialize_record): Likewise.
1890         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1891         * regcache.c (_initialize_regcache): Likewise.
1892         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1893         _initialize_remote): Likewise.
1894         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1895         * serial.c (_initialize_serial): Likewise.
1896         * skip.c (_initialize_step_skip): Likewise.
1897         * source.c (_initialize_source): Likewise.
1898         * stack.c (_initialize_stack): Likewise.
1899         * symfile.c (_initialize_symfile): Likewise.
1900         * symtab.c (_initialize_symtab): Likewise.
1901         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1902         * top.c (init_main): Likewise.
1903         * tracefile-tfile.c (tfile_target_info): Likewise.
1904         * tracepoint.c (_initialize_tracepoint): Likewise.
1905         * tui/tui-win.c (_initialize_tui_win): Likewise.
1906         * utils.c (add_internal_problem_command): Likewise.
1907         * valprint.c (value_print_option_defs): Likewise.
1908
1909 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1910
1911         PR build/24886
1912         * configure.ac: Drop enable-libmcheck support.
1913         * configure, config.in: Rebuild.
1914         * libmcheck.m4: Remove.
1915         * acinclude.m4: Don't include it.
1916         * Makefile.in: Don't distribute it.
1917         * top.c (print_gdb_configuration): Don't mention it.
1918
1919 2019-08-06  Tom Tromey  <tom@tromey.com>
1920
1921         * utils.c (set_output_style): Sometimes pass stream to
1922         emit_style_escape.
1923         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1924         * record-btrace.c (btrace_insn_history): Update.
1925         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1926         method.
1927         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1928         Update initializers.
1929         <m_uiout>: New field.
1930         <m_di>: Move lower.
1931         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1932         Remove "uiout" parameter.
1933         (dump_insns): Update.
1934         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1935         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1936
1937 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1938
1939         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1940         (error_in_psymtab_expansion): Likewise.
1941         (lookup_symbol_via_quick_fns): Likewise.
1942         (basic_lookup_transparent_type_quick): Likewise.
1943         (basic_lookup_transparent_type_1): Likewise.
1944
1945 2019-08-06  Tom Tromey  <tromey@adacore.com>
1946
1947         * source.c (last_source_error): Now bool.
1948         (print_source_lines_base): Make "noprint" bool.  Only open
1949         source file when last_source_visited changes.
1950
1951 2019-08-06  Tom Tromey  <tromey@adacore.com>
1952
1953         * annotate.c (annotate_source_line): Use g_source_cache.
1954         * source-cache.c (source_cache::get_plain_source_lines): Change
1955         parameters.  Populate m_offset_cache.
1956         (source_cache::ensure): New method.
1957         (source_cache::get_line_charpos): New method.
1958         (extract_lines): Move lower.  Change parameters.
1959         (source_cache::get_source_lines): Move lower.
1960         * source-cache.h (class source_cache): Update comment.
1961         <get_line_charpos>: New method.
1962         <get_source_lines>: Update comment.
1963         <clear>: Clear m_offset_cache.
1964         <get_plain_source_lines>: Change parameters.
1965         <ensure>: New method
1966         <m_offset_cache>: New member.
1967         * source.c (forget_cached_source_info_for_objfile): Update.
1968         (info_source_command): Use g_source_cache.
1969         (find_source_lines, open_source_file_with_line_charpos): Remove.
1970         (print_source_lines_base, search_command_helper): Use g_source_cache.
1971         * source.h (open_source_file_with_line_charpos): Don't declare.
1972         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1973         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1974         Use g_source_cache.
1975
1976 2019-08-06  Tom Tromey  <tromey@adacore.com>
1977
1978         * source-cache.c (source_cache::get_plain_source_lines):
1979         Remove "first_line" and "last_line" parameters.
1980         (source_cache::get_source_lines): Cache plain text.
1981         * source-cache.h (class source_cache)
1982         <get_plain_source_lines>: Update.
1983
1984 2019-08-06  Tom Tromey  <tromey@adacore.com>
1985
1986         * source-cache.c (extract_lines): No longer a method.
1987         Changed type of parameter.  Include final newline.
1988         (selftests::extract_lines_test): New function.
1989         (_initialize_source_cache): Likewise.
1990         * source-cache.h (class source_cache)
1991         <extract_lines>: Don't declare.
1992
1993 2019-08-06  Tom Tromey  <tromey@adacore.com>
1994
1995         * breakpoint.c (init_breakpoint_sal): Update.
1996         (breakpoint): Update.
1997         * breakpoint.h (struct breakpoint) <filter>: Now a
1998         unique_xmalloc_ptr.
1999
2000 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2001
2002         * NEWS: Mention dictionary access on blocks.
2003         * python/py-block.c (blpy_getitem): New function.
2004         (block_object_as_mapping): New struct.
2005         (block_object_type): Use new struct for tp_as_mapping field.
2006
2007 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2008
2009         * objfiles.h (objfile): Add a comment describing partial symbols.
2010
2011 2019-08-05  Tom Tromey  <tromey@adacore.com>
2012
2013         * compile/compile.c (_initialize_compile): Use _(), not N_().
2014         * thread.c (_initialize_thread): Use _(), not N_().
2015         * stack.c (_initialize_stack): Use _(), not N_().
2016         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2017
2018 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2019
2020         * dwarf2read.c (struct dw2_symtab_iterator):
2021         <want_specific_block>: Remove.
2022         <block_index>: Change type to gdb::optional.
2023         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2024         change type of BLOCK_INDEX parameter to gdb::optional.
2025         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2026         (dw2_lookup_symbol): Don't pass argument for
2027         WANT_SPECIFIC_BLOCK.
2028         (dw2_expand_symtabs_for_function): Don't pass argument for
2029         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2030         (class dw2_debug_names_iterator)
2031         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2032         parameter, change BLOCK_INDEX type to gdb::optional.
2033         <m_want_specific_block>: Remove.
2034         <m_block_index>: Change type to gdb::optional.
2035         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2036         gdb::optional.  Re-write in function of gdb::optional.
2037         (dw2_debug_names_lookup_symbol): Don't pass argument for
2038         WANT_SPECIFIC_BLOCK.
2039         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2040         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2041         BLOCK_INDEX.
2042
2043 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2044
2045         * NEWS: Mention changes to "info sources" command.
2046
2047 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2048
2049         * symtab.c (filename_partial_match_opts): New struct type.
2050         (struct output_source_filename_data): New members
2051         regexp, c_regexp, partial_match.
2052         (output_source_filename): Use new members to decide to print file.
2053         (info_sources_option_defs): New variable.
2054         (make_info_sources_options_def_group, print_info_sources_header,
2055         info_sources_command_completer):
2056         New functions.
2057         (info_sources_command): Read new optional arguments.
2058         (_initialize_symtab): Update info sources help.
2059
2060 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2061
2062         * ada-lang.c (exception_support_info_v0): Renamed from...
2063         (default_exception_support_info): ... this.  Create new
2064         definition for v1.
2065         (ada_has_this_exception_support): Look up catch_handlers_sym.
2066         (ada_exception_support_info_sniffer): Try v0 after default.
2067
2068 2019-08-01  Tom Tromey  <tromey@adacore.com>
2069
2070         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2071         gdbarch.h.
2072
2073 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2074
2075         * s12z-tdep.c: Fix include path for s12z-opc.h.
2076
2077 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2078
2079         * NEWS: Require GNU make 3.82.
2080
2081 2019-07-16  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2084         declare.
2085
2086 2019-07-30  Tom Tromey  <tromey@adacore.com>
2087
2088         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2089
2090 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2091
2092         * printcmd.c (print_address_symbolic): Print negative offsets.
2093         (build_address_symbolic): Force signed arithmetic when computing
2094         offset.
2095
2096 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2097
2098         PR/24474: Add a function to lookup static variables.
2099         * NEWS: Mention this new function.
2100         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2101         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2102         * python/python.c (python_GdbMethods): Add new function.
2103
2104 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2105
2106         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2107         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2108         (objfpy_lookup_static_symbol): New function.
2109         (objfile_object_methods): Add new functions.
2110
2111 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2112
2113         * NEWS: Mention 'set|show print frame-info'.  Mention new
2114         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2115         backtrace argument.  Mention that python frame filtering code
2116         is now consistent with what 'backtrace' command prints.
2117
2118 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2119
2120         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2121         comments.
2122         (print_frame_info_auto, print_frame_info_source_line,
2123         print_frame_info_location, print_frame_info_source_and_location,
2124         print_frame_info_location_and_address, print_frame_info_short_location):
2125         New declarations.
2126         (struct frame_print_options): New member print_frame_info.
2127         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2128         * stack.h (get_user_print_what_frame_info): New declaration.
2129         (frame_show_address): New declaration.
2130         * stack.c (print_frame_arguments_choices): New value 'presence'.
2131         (print_frame_info_auto, print_frame_info_source_line,
2132         print_frame_info_location, print_frame_info_source_and_location,
2133         print_frame_info_location_and_address, print_frame_info_short_location,
2134         print_frame_info_choices, print_frame_info_print_what): New definitions.
2135         (print_frame_args): Only print dots for args if print frame-arguments
2136         is 'presence'.
2137         (frame_print_option_defs): New element for "frame-info".
2138         (get_user_print_what_frame_info): New function.
2139         (frame_show_address): Make non static.  Move comment to stack.h.
2140         (print_frame_info_to_print_what): New function.
2141         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2142         to decide what to print.
2143         (backtrace_command_1): Handle the new print_frame_arguments_presence
2144         value.
2145         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2146         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2147         (py_print_frame): In non-mi mode, use LOCATION as default for
2148         print_what, similarly to frame information printed directly by
2149         backtrace command. Handle frame-info user option in non MI mode.
2150
2151 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2152
2153         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2154         Add case for debugging 32-bit target on 64-bit host.  Revise
2155         comment.
2156
2157 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2158
2159         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2160         instead of find_function_entry_range_from_pc.
2161
2162 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2163
2164         * stack.c (find_frame_funname): Remove code which preferred
2165         minsym over symtab sym in "certain pathological cases".
2166
2167         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2168         parameter.  Change type of "do_demangle" to bool.
2169         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2170         Pass suitable "prefer_sym_over_minsym" flag to
2171         build_address_symbolic().  Don't output "+" for negative offsets.
2172         * printcmd.c (print_address_symbolic): Update invocation of
2173         build_address_symbolic to include a "prefer_sym_over_minsym"
2174         flag.
2175         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2176         Restrict cases in which use of minimal symbol is preferred to that
2177         of a found symbol.  Update comments.
2178
2179         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2180         for entry pc when entry pc is out of range for that FDE.
2181
2182 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2183
2184         PR gdb/24839:
2185         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2186         type.
2187
2188 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2189
2190         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2191         this function's Python signature.
2192
2193
2194 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2195
2196         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2197         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2198         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2199         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2200         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2201
2202
2203 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2204
2205         * h8300-tdep.c (h8300_register_name_common): New.
2206         h8300_register_name): Use h8300_register_name_common.
2207         (h8300s_register_name): Likewise.
2208         (h8300sx_register_name): Likewise.
2209         (h8300h_register_nam): New.
2210         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2211
2212
2213 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2214
2215         * arm-tdep.c (arm_skip_cmse_entry): New function.
2216         (arm_is_sgstubs_section): New function.
2217         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2218
2219 2019-07-22  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2222         Don't self-assign.
2223
2224 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2227         type_print.
2228
2229 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2232         so that GDB doesn't match any msymbols when searching in the
2233         TYPES_DOMAIN.
2234         (print_symbol_info): Print using typedef_print or type_print based
2235         on the type of the symbol.  Add updated FIXME comment moved from...
2236         (_initialize_symtab): ... move and update FIXME comment to above.
2237
2238 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * NEWS: Mention adding -q option to "info types".
2241         * symtab.c (struct info_types_options): New struct.
2242         (info_types_options_defs): New variable.
2243         (make_info_types_options_def_group): New function.
2244         (info_types_command): Use gdb::option framework to parse options.
2245         (info_types_command_completer): New function.
2246         (_initialize_symtab): Extend the help text on "info types" and
2247         register command completer.
2248
2249 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2250
2251         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2252         (lookup_symbol_in_objfile): Change int to block_enum and add a
2253         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2254
2255 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * MAINTAINERS (Write After Approval): Add self.
2258
2259 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2262         instruction to the dummy code region.
2263
2264 2019-07-19  Tom Tromey  <tromey@adacore.com>
2265
2266         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2267         (ARGSUSED, PARAMS, __func__): Remove rules.
2268
2269 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2270
2271         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2272         * features/arm/arm-with-iwmmxt.c: Remove.
2273         * features/arm/arm-with-iwmmxt.xml: Remove.
2274         * features/arm/arm-with-m-fpa-layout.c: Remove.
2275         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2276         * features/arm/arm-with-m-vfp-d16.c: Remove.
2277         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2278         * features/arm/arm-with-m.c: Remove.
2279         * features/arm/arm-with-m.xml: Remove.
2280         * features/arm/arm-with-neon.c: Remove.
2281         * features/arm/arm-with-neon.xml: Remove.
2282         * features/arm/arm-with-vfpv2.c: Remove.
2283         * features/arm/arm-with-vfpv2.xml: Remove.
2284         * features/arm/arm-with-vfpv3.c: Remove.
2285         * features/arm/arm-with-vfpv3.xml: Remove.
2286
2287 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2288
2289         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2290
2291 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2292
2293         * arch/aarch32.c (aarch32_create_target_description): Create
2294         target descriptions using features.
2295         * arch/arm.c (arm_create_target_description)
2296         (arm_create_mprofile_target_description): Likewise.
2297         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2298
2299 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2300
2301         * Makefile.in: Add new files.
2302         * aarch32-tdep.c: New file.
2303         * aarch32-tdep.h: New file.
2304         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2305         Call aarch32_read_description.
2306         * arch/aarch32.c: New file.
2307         * arch/aarch32.h: New file.
2308         * arch/arm.c (arm_create_target_description)
2309         (arm_create_mprofile_target_description): New function.
2310         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2311         (arm_create_target_description)
2312         (arm_create_mprofile_target_description): New declaration.
2313         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2314         read_description functions.
2315         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2316         Likewise.
2317         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2318         * arm-tdep.c (tdesc_arm_list): New variable.
2319         (arm_register_g_packet_guesses): Call create description functions.
2320         (arm_read_description) (arm_read_mprofile_description): New
2321         function.
2322         * arm-tdep.h (arm_read_description)
2323         (arm_read_mprofile_description): Add declaration.
2324         * configure.tgt: Add new files.
2325
2326 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2327
2328         * top.c (new_ui_command): Open specified terminal just once.
2329
2330 2019-07-18  Tom Tromey  <tromey@adacore.com>
2331
2332         * symtab.c (main_name): Constify return type.
2333         * symfile.c (set_initial_language): Update.
2334         * symtab.h (main_name): Constify return type.
2335
2336 2019-07-17  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-winsource.c (tui_update_source_window)
2339         (tui_update_source_window_as_is)
2340         (tui_update_source_windows_with_line): Remove return.
2341         * tui/tui-disasm.c (tui_show_disassem)
2342         (tui_show_disassem_and_update_source): Remove return.
2343         * tui/tui.c (tui_reset): Remove return.
2344         * tui/tui-wingeneral.c
2345         (tui_check_and_display_highlight_if_needed): Remove return.
2346
2347 2019-07-17  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2350
2351 2019-07-17  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.h (struct tui_exec_info_window)
2354         (struct tui_source_window_base): Move from tui-data.h.
2355         * tui/tui-winsource.c: Move many method definitions from
2356         elsewhere.  Remove "structuring" comments.
2357         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2358         (tui_source_window_base::refresh_window): Move to
2359         tui-winsource.c.
2360         * tui/tui-win.c (tui_source_window_base::refresh_all)
2361         (tui_source_window_base::update_tab_width)
2362         (tui_source_window_base::set_new_height)
2363         (tui_source_window_base::do_make_visible_with_new_height): Move to
2364         tui-winsource.c.
2365         * tui/tui-source.h: Update.
2366         * tui/tui-source.c (tui_source_window_base::reset): Move to
2367         tui-winsource.c.
2368         * tui/tui-disasm.h: Update.
2369         * tui/tui-data.h (struct tui_exec_info_window): Move to
2370         tui-winsource.h.
2371         (struct tui_source_window_base): Likewise.
2372         * tui/tui-data.c (tui_source_window_base::clear_detail)
2373         (tui_source_window_base, ~tui_source_window_base): Move to
2374         tui-winsource.c.
2375
2376 2019-07-17  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-win.c (tui_resize_all)
2379         (tui_source_window_base::update_tab_width)
2380         (tui_adjust_win_heights): Update.
2381         (tui_win_info::make_invisible_and_set_new_height): Rename from
2382         make_invisible_and_set_new_height.
2383         * tui/tui-data.h (struct tui_win_info)
2384         <make_invisible_and_set_new_height>: New method.
2385
2386 2019-07-17  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui.c: Update.
2389         * tui/tui-source.h (struct tui_source_window): Move from
2390         tui-data.h.
2391         * tui/tui-layout.c: Update.
2392         * tui/tui-disasm.c: Update.
2393         * tui/tui-data.h (struct tui_source_window): Move to
2394         tui-source.h.
2395
2396 2019-07-17  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2399         tui-data.h.
2400         * tui/tui-data.h (struct tui_disasm_window): Move to
2401         tui-disasm.h.
2402
2403 2019-07-17  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-regs.h (struct tui_data_item_window): Move from
2406         tui-data.h.
2407         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2408         * tui/tui-data.h (struct tui_data_item_window): Move to
2409         tui-regs.h.
2410         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2411
2412 2019-07-17  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui.c: Update.
2415         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2416         (tui_cmd_window::max_height): Move to tui-command.c.
2417         * tui/tui-layout.c: Update.
2418         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2419         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2420         tui-command.c.
2421         * tui/tui-command.h (struct tui_cmd_window): Move from
2422         tui-data.h.
2423         * tui/tui-command.c: Remove "structuring" comments.
2424         (tui_cmd_window::clear_detail)
2425         (tui_cmd_window::do_make_visible_with_new_height)
2426         (tui_cmd_window::max_height): Move from elsewhere.
2427
2428 2019-07-17  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2431         Now static.
2432         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2433         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2434
2435 2019-07-17  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui.c: Update.
2438         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2439         tui-regs.c.
2440         * tui/tui-windata.h: Remove file.
2441         * tui/tui-windata.c: Remove file.
2442         * tui/tui-win.c (tui_data_window::set_new_height)
2443         (tui_data_window::do_make_visible_with_new_height): Move to
2444         tui-regs.c.
2445         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2446         * tui/tui-regs.c: Remove "structuring" comments.
2447         (tui_data_window::first_data_item_displayed)
2448         (tui_data_window::delete_data_content_windows)
2449         (tui_data_window::erase_data_content)
2450         (tui_data_window::display_all_data)
2451         (tui_data_window::refresh_all)
2452         (tui_data_window::do_scroll_vertical)
2453         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2454         (tui_data_window::do_make_visible_with_new_height)
2455         (tui_data_window::refresh_window): Move from elsewhere.
2456         (_initialize_tui_regs): Move to end of file.
2457         * tui/tui-layout.c: Update.
2458         * tui/tui-hooks.c: Update.
2459         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2460         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2461         tui-regs.c.
2462         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2463
2464 2019-07-17  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2467         seen.
2468
2469 2019-07-17  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-win.c (tui_source_window_base::set_new_height)
2472         (tui_source_window_base::do_make_visible_with_new_height): Use
2473         m_has_locator field directly.
2474         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2475         method.
2476         (struct tui_source_window_base) <has_locator>: Likewise.
2477
2478 2019-07-17  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2481         Don't declare.
2482         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2483         Remove.
2484         * tui/tui-win.c (tui_source_window_base::set_new_height)
2485         (tui_source_window_base::set_new_height)
2486         (make_invisible_and_set_new_height)
2487         (tui_source_window_base::do_make_visible_with_new_height)
2488         (tui_source_window_base::do_make_visible_with_new_height):
2489         Update.
2490         * tui/tui-layout.c (show_source_disasm_command, show_data)
2491         (show_source_or_disasm_and_command): Update.
2492         * tui/tui-layout.c (show_layout): Update.
2493
2494 2019-07-17  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-layout.c (make_data_window): Remove.
2497         (show_data): Unify creation and re-initialization cases.
2498
2499 2019-07-17  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-layout.c (make_source_window, make_disasm_window):
2502         Remove.
2503         (show_data): Unify creation and re-initialization cases.
2504
2505 2019-07-17  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-layout.c (make_command_window): Remove.
2508         (show_source_disasm_command, show_source_or_disasm_and_command):
2509         Unify creation and re-initialization cases.
2510
2511 2019-07-17  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2514         creation and re-initialization cases.
2515
2516 2019-07-17  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-regs.c (tui_get_register): Return void.
2519
2520 2019-07-17  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2523         Simplify.
2524
2525 2019-07-17  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2528         resetting.
2529
2530 2019-07-17  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2533         * tui/tui-regs.c (tui_reg_layout): New function.
2534         (tui_show_registers, tui_reg_command): Use it.
2535         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2536         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2537         parameters.
2538         (tui_layout_command): Remove.
2539
2540 2019-07-17  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-layout.h (tui/tui-layout): Return void.
2543         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2544
2545 2019-07-17  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-layout.c (show_source_disasm_command, show_data):
2548         Update.
2549         (reset_locator): Remove.
2550         (show_source_or_disasm_and_command): Update.
2551
2552 2019-07-17  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-source.c (tui_source_window_base::reset): Remove
2555         win_type parameter.
2556         * tui/tui-layout.c (make_command_window, make_source_window)
2557         (make_disasm_window, make_data_window)
2558         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2559         (reset_locator, show_source_or_disasm_and_command): Update.
2560         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2561         win_type parameter.
2562         (struct tui_source_window_base) <reset>: Likewise.
2563
2564 2019-07-17  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-layout.c (show_source_disasm_command): Use
2567         reset_locator.
2568         (reset_locator): New function.
2569         (init_and_make_win): Remove.
2570         (show_source_or_disasm_and_command): Use reset_locator.
2571
2572 2019-07-17  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2575         condition.
2576         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2577         Remove condition.
2578         * tui/tui-source.c (tui_source_window_base::reset): New method.
2579         * tui/tui-layout.c (make_command_window): Don't call
2580         init_and_make_win.
2581         (make_source_window, make_disasm_window): Don't call
2582         make_source_or_disasm_window.
2583         (make_data_window): Don't call init_and_make_win.  Change calling
2584         convention.
2585         (show_source_disasm_command, show_data): Simplify.
2586         (make_source_or_disasm_window): Remove.
2587         (show_source_or_disasm_and_command): Simplify.
2588         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2589         (struct tui_source_window_base) <reset>: Likewise.
2590         <execution_info>: Remove initializer.
2591         * tui/tui-data.c (tui_source_window_base): Initialize
2592         execution_info.
2593
2594 2019-07-17  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2597         variable.
2598
2599 2019-07-17  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui.c (tui_rl_other_window): Update.
2602         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2603         superclass method first.  Always iterate over regs_content.
2604         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2605         method.
2606         * tui/tui-win.c (tui_set_focus_command): Update.
2607
2608 2019-07-17  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-win.c (tui_set_focus_command): Rename from
2611         tui_set_focus.  Call tui_enable.
2612         (tui_set_focus_command): Remove.
2613
2614 2019-07-17  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2617         refresh_window.
2618         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2619         touchwin.
2620         (tui_data_window::refresh_window): Call refresh_window on data
2621         items.  Always call superclass refresh_window.
2622         (tui_win_info::refresh): Remove.
2623         (tui_source_window_base::refresh_window): Update.
2624         (tui_refresh_all): Update.
2625         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2626         refresh_window.
2627         (show_source_or_disasm_and_command): Likewise.
2628         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2629         (struct tui_source_window_base) <refresh>: Likewise.
2630
2631 2019-07-17  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-winsource.c (tui_clear_source_content)
2634         (tui_show_source_content): Update.
2635         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2636         whether content is empty.
2637         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2638         Remove.
2639
2640 2019-07-17  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2643         window's contents.
2644         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2645         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2646
2647 2019-07-17  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2650         (struct tui_data_item_window): Update.
2651
2652 2019-07-17  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2655         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2656         defines.
2657
2658 2019-07-17  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-winsource.h (tui_erase_source_content)
2661         (tui_clear_source_content): Remove "display_prompt" parameter.
2662         * tui/tui-winsource.c (tui_update_source_window_as_is)
2663         (tui_update_source_windows_with_addr): Update.
2664         (tui_clear_source_content): Remove "display_prompt" parameter.
2665         (tui_erase_source_content): Likewise.  Simplify.
2666         (tui_show_source_content): Update.
2667         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2668         * tui/tui-stack.c (tui_show_frame_info): Update.
2669         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2670         Remove defines.
2671
2672 2019-07-17  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2675         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2676         parameter.
2677         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2678         parameter.
2679
2680 2019-07-17  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-winsource.c (tui_clear_source_content)
2683         (tui_show_source_content, tui_show_exec_info_content)
2684         (tui_clear_exec_info_content): Update.
2685         * tui/tui-stack.c (tui_show_locator_content): Update.
2686         (tui_show_frame_info): Update.
2687         * tui/tui-source.h (tui_source_window): Don't declare.
2688         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2689         from tui_source_is_displayed.
2690         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2691         Remove field.
2692         (struct tui_source_window_base) <content_in_use>: New field.  Now
2693         bool.
2694         (struct tui_source_window) <showing_source_p>: New method.
2695         (TUI_SRC_WIN): Change cast.
2696         * tui/tui-data.c (tui_initialize_static_data): Update.
2697
2698 2019-07-17  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2701         location_matches_p.
2702         * tui/tui-source.c (tui_source_window::location_matches_p): New
2703         method.
2704         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2705         method.
2706         * tui/tui-data.h (struct tui_source_window_base)
2707         <location_matches_p>: New method.
2708         (struct tui_source_window, struct tui_disasm_window)
2709         <location_matches_p>: Likewise.
2710
2711 2019-07-17  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-win.c (tui_set_win_height_command): Rename from
2714         tui_set_win_height.
2715         (tui_set_win_height_command): Remove.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-source.c (tui_source_window): New constructor.  Add
2720         observer.
2721         (~tui_source_window): New destructor.
2722         (tui_source_window::style_changed): New method.
2723         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2724         (tui_attach_detach_observers): Update.
2725         * tui/tui-data.h (struct tui_source_window): Make constructor not
2726         inline.  Add destructor.
2727         (struct tui_source_window) <style_changed>: New method.
2728         <m_observable>: New member.
2729
2730 2019-07-17  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2733         * tui/tui-win.c (tui_resize_all): Fix typo.
2734
2735 2019-07-17  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2738         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2739         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2740         * tui/tui-win.c (window_name_completer): Use foreach.
2741         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2742         (update_tab_width): Likewise.
2743         * tui/tui-layout.c (show_layout): Update.
2744         * tui/tui-data.h (class tui_window_iterator): New.
2745         (struct all_tui_windows): New.
2746         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2747
2748 2019-07-17  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2751         parameter.  Don't reference globals.
2752         (tui_reg_command): Update.
2753
2754 2019-07-17  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-regs.c (tui_show_registers): Simplify.
2757
2758 2019-07-17  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-regs.c (tui_show_registers): Update.
2761         (tui_show_register_group): Add win_info parameter.
2762
2763 2019-07-17  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2766         Rename from tui_display_reg_element_at_line.
2767         (tui_data_window::display_registers_from_line): Update.
2768         * tui/tui-data.h (struct tui_data_window)
2769         <display_reg_element_at_line>: New method.
2770
2771 2019-07-17  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-regs.h (tui_display_registers_from)
2774         (tui_display_registers_from_line): Don't declare.
2775         * tui/tui-windata.c (tui_data_window::display_all_data)
2776         (tui_data_window::refresh_all)
2777         (tui_data_window::do_scroll_vertical): Update.
2778         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2779         from tui_display_registers_from.
2780         (tui_display_reg_element_at_line): Update.
2781         (tui_data_window::display_registers_from_line): Rename from
2782         tui_display_registers_from_line.
2783         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2784         display_registers_from_line>: New methods.
2785
2786 2019-07-17  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2789         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2790         from tui_erase_data_content.
2791         (tui_data_window::display_all_data)
2792         (tui_data_window::refresh_all)
2793         (tui_data_window::do_scroll_vertical): Update.
2794         * tui/tui-regs.c (tui_show_registers): Update.
2795         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2796         New method.
2797
2798 2019-07-17  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2801         declare.
2802         * tui/tui-windata.c
2803         (tui_data_window::delete_data_content_windows): Rename from
2804         tui_delete_data_content_windows.
2805         (tui_data_window::display_all_data)
2806         (tui_data_window::do_scroll_vertical): Update.
2807         * tui/tui-data.h (struct tui_data_window)
2808         <delete_data_content_windows>: New method.
2809
2810 2019-07-17  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2813         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2814
2815 2019-07-17  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2818         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2819         from tui_display_all_data.
2820         * tui/tui-win.c
2821         (tui_data_window::do_make_visible_with_new_height): Update.
2822         * tui/tui-regs.c (tui_show_registers): Update.
2823         * tui/tui-layout.c (tui_set_layout): Update.
2824         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2825         method.
2826
2827 2019-07-17  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2830         * tui/tui-windata.c (tui_display_data_from): Remove.
2831         (tui_data_window::refresh_all): Update.
2832
2833 2019-07-17  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2836         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2837         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2838         tui_display_registers_from_line.
2839         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2840         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2841         "force_display" parameter.
2842
2843 2019-07-17  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2846         declare.
2847         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2848         Rename from tui_first_reg_element_no_inline.
2849         (tui_display_reg_element_at_line)
2850         (tui_display_registers_from_line): Update.
2851         * tui/tui-data.h (struct tui_data_window)
2852         <first_reg_element_no_inline>: New method.
2853
2854 2019-07-17  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-windata.c (tui_display_data_from)
2857         (tui_data_window::do_scroll_vertical): Update.
2858         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2859         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2860         Rename from tui_line_from_reg_element_no.
2861         (tui_display_registers_from_line): Update.
2862         * tui/tui-data.h (struct tui_data_window)
2863         <line_from_reg_element_no>: New method.
2864
2865 2019-07-17  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2868         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2869         tui_last_regs_line_no.
2870         (tui_display_reg_element_at_line)
2871         (tui_display_registers_from_line): Update.
2872         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2873         method.
2874
2875 2019-07-17  Tom Tromey  <tom@tromey.com>
2876
2877         PR tui/24722:
2878         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2879         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2880         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2881         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2882         (tui_update_breakpoint_info): Likewise.
2883         * tui/tui-hooks.c (tui_event_create_breakpoint)
2884         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2885         Update.
2886
2887 2019-07-17  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2890
2891 2019-07-17  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-winsource.c (tui_update_source_window_as_is)
2894         (tui_update_source_windows_with_addr): Update.
2895         * tui/tui-source.h (tui_set_source_content)
2896         (tui_show_symtab_source): Add "win_info" parameter.
2897         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2898         parameter.
2899         (tui_show_symtab_source): Likewise.
2900
2901 2019-07-17  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-wingeneral.c
2904         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2909         (struct tui_cmd_window) <can_scroll>: New method.
2910         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2911         method.
2912
2913 2019-07-17  Tom Tromey  <tromey@adacore.com>
2914
2915         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2916         do_field_signed>: Rename.  Change type of "value".
2917         * ui-out.c (ui_out::field_signed): Rename from field_int.
2918         Change type of "value".
2919         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2920         type of "value".
2921         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2922         do_field_int.  Change type of "value".
2923         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2924         do_field_int.  Change type of "value".
2925         * tracepoint.c (trace_status_mi, tfind_1)
2926         (print_one_static_tracepoint_marker): Update.
2927         * thread.c (print_thread_info_1, print_selected_thread_frame):
2928         Update.
2929         * stack.c (print_frame, print_frame_info): Update.
2930         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2931         Update.
2932         * source.c (print_source_lines_base): Update.
2933         * skip.c (info_skip_command): Update.
2934         * record-btrace.c (btrace_ui_out_decode_error)
2935         (btrace_call_history_src_line): Update.
2936         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2937         Update.
2938         * progspace.c (print_program_space): Update.
2939         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2940         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2941         do_field_int.  Change type of "value".
2942         * mi/mi-out.c (mi_ui_out::do_table_begin)
2943         (mi_ui_out::do_table_header): Update.
2944         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2945         type of "value".
2946         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2947         (mi_cmd_data_list_changed_registers, output_register)
2948         (mi_cmd_data_read_memory, mi_load_progress)
2949         (mi_cmd_trace_frame_collected): Update.
2950         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2951         Update.
2952         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2953         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2954         (mi_cmd_var_list_children, varobj_update_one): Update.
2955         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2956         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2957         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2958         * inferior.c (print_inferior): Update.
2959         * gdb_bfd.c (print_one_bfd): Update.
2960         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2961         Update.
2962         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2963         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2964         do_field_int.  Change type of "value".
2965         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2966         do_field_int.  Change type of "value".
2967         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2968         (print_one_breakpoint_location, print_it_catch_fork)
2969         (print_one_catch_fork, print_it_catch_vfork)
2970         (print_one_catch_vfork, print_it_catch_solib)
2971         (print_it_catch_exec, print_it_ranged_breakpoint)
2972         (print_mention_watchpoint, print_mention_masked_watchpoint)
2973         (bkpt_print_it, update_static_tracepoint): Update.
2974         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2975         * break-catch-syscall.c (print_it_catch_syscall): Update.
2976         * ada-tasks.c (print_ada_task_info): Update.
2977         * ada-lang.c (print_it_exception, print_mention_exception):
2978         Update.
2979
2980 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         PR breakpoints/24541
2983         * gdbarch.c: Regenerate.
2984         * gdbarch.h: Regenerate.
2985         * gdbarch.sh: Adjust return type and parameter types for
2986         'stap_adjust_register'.
2987         (i386_stap_adjust_register): Adjust signature and return new
2988         register name.
2989         * stap-probe.c (stap_parse_register_operand): Adjust use of
2990         'gdbarch_stap_adjust_register'.
2991
2992 2019-07-17  Tom Tromey  <tromey@adacore.com>
2993
2994         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2995         declare VEC.
2996         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2997         std::vector.
2998         (struct s390_process_info): Add initializers.
2999         (s390_add_process): Use new.
3000         (s390_linux_nat_target::low_forget_process): Use delete.
3001         (s390_linux_nat_target::low_new_fork)
3002         (s390_linux_nat_target::stopped_by_watchpoint)
3003         (s390_linux_nat_target::low_prepare_to_resume)
3004         (s390_linux_nat_target::insert_watchpoint)
3005         (s390_linux_nat_target::insert_hw_breakpoint)
3006         (s390_linux_nat_target::remove_watchpoint)
3007         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3008
3009 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3010
3011         * aarch64-fbsd-nat.c: Include regcache.h.
3012         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3013         argument.
3014         (aarch64_fbsd_nat_target::fetch_registers)
3015         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3016         variable.
3017         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3018
3019 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3020
3021         * fbsd-nat.c: Include gdbarch.h.
3022
3023 2019-07-15  Tom Tromey  <tromey@adacore.com>
3024
3025         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3026
3027 2019-07-15  Tom Tromey  <tromey@adacore.com>
3028
3029         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3030         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3031         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3032         * cli-out.c (cli_ui_out::do_field_int): New method.
3033         * ui-out.c (ui_out::field_unsigned): New method.
3034         * symfile.c (generic_load): Use field_unsigned.
3035         (print_transfer_performance): Likewise.
3036         * record-btrace.c (ui_out_field_uint): Remove.
3037         (btrace_call_history_insn_range, btrace_call_history): Use
3038         field_unsigned.
3039         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3040         field_unsigned.
3041         * ui-out.h (class ui_out) <field_unsigned>: New method.
3042         <do_field_unsigned>: Likewise.
3043
3044 2019-07-15  Tom Tromey  <tromey@adacore.com>
3045
3046         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3047         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3048         * target.c (flash_erase_command): Use field_string.
3049         * infrun.c (print_signal_received_reason): Use field_string.
3050         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3051         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3052         field_string.
3053         * ada-tasks.c (print_ada_task_info): Use field_string.
3054
3055 2019-07-15  Tom Tromey  <tromey@adacore.com>
3056
3057         * target.c (flash_erase_command): Use field_core_addr.
3058         * symfile.c (generic_load): Use field_core_addr.
3059         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3060         Use field_core_addr.
3061         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3062         field_core_addr.
3063
3064 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3067         value if its desired type is smaller than a CORE_ADDR and signed.
3068
3069 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3072         of changes to field names, and use new is_reference field to
3073         decide if a property is a reference or not.
3074         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3075         field.
3076         (struct dwarf2_property_baton): Update header comment, rename
3077         'referenced_type' to 'property_type' and update comments.
3078         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3079         default property type, store in property baton, update to take
3080         accound of renamed field.
3081         (read_func_scope): Update call to attr_to_dynamic_prop.
3082         (read_array_type): Likewise.
3083         (dwarf2_per_cu_addr_sized_int_type): New function.
3084         (read_subrange_index_type): Move type finding code to
3085         dwarf2_per_cu_addr_sized_int_type.
3086         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3087         (dwarf2_per_cu_addr_type): New function.
3088         (set_die_type): Update calls to attr_to_dynamic_prop.
3089
3090 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3091
3092         * dwarf2read.c (read_subrange_index_type): New function.
3093         (read_subrange_type): Move code into new function and call it.
3094         * gdbtypes.c (create_range_type): Add some asserts.
3095
3096 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3097
3098         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3099         update return statements.
3100         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3101         declaration, and update comment to match.
3102         * gdbtypes.c (resolve_dynamic_array): Update call to
3103         dwarf2_evaluate_property to match new return type.
3104
3105 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * valarith.c (value_subscripted_rvalue): Change lowerbound
3108         parameter type from int to LONGEST.
3109         * value.h (value_subscripted_rvalue): Likewise in declaration.
3110
3111 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * cli/cli-utils.c (info_print_command_completer): New function.
3114         * cli/cli-utils.h: Add 'completer.h' include, and forward
3115         declaration for 'struct cmd_list_element'.
3116         (info_print_command_completer): Declare.
3117         * stack.c (_initialize_stack): Add completer for 'info locals' and
3118         'info args'.
3119         * symtab.c (_initialize_symtab): Add completer for 'info
3120         variables' and 'info functions'.
3121         * NEWS: Mention completion for additional info commands.
3122
3123 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * cli/cli-utils.c (extract_info_print_args): Delete.
3126         (extract_arg_maybe_quoted): Delete.
3127         (info_print_options_defs): New variable.
3128         (make_info_print_options_def_group): New function.
3129         (extract_info_print_options): Define new function.
3130         * cli/cli-utils.h (extract_info_print_args): Delete.
3131         (struct info_print_options): New structure.
3132         (extract_info_print_options): Declare new function.
3133         * stack.c (info_locals_command): Update to use new
3134         extract_info_print_options, also add a header comment.
3135         (info_args_command): Likewise.
3136         * symtab.c (info_variables_command): Likewise.
3137         (info_functions_command): Likewise.
3138
3139 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3142         to extract string arguments.
3143         * common/common-utils.c (extract_string_maybe_quoted): New function.
3144         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3145
3146 2019-07-11  Tom Tromey  <tromey@adacore.com>
3147
3148         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3149         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3150         * top.h (gdbinit): Don't declare.
3151         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3152         into...
3153         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3154         * top.c (gdb_init): Don't call init_cli_cmds.
3155         (gdbinit): Remove.
3156         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3157
3158 2019-07-11  Tom Tromey  <tromey@adacore.com>
3159
3160         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3161         after it has been moved.
3162
3163 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3164
3165         * valops.c (value_must_coerce_to_target): Change return type to
3166         bool.
3167         * value.h (value_must_coerce_to_target): Likewise.
3168
3169 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3170
3171         * breakpoint.c (is_hardware_watchpoint): Remove
3172         forward-declaration.
3173         (is_masked_watchpoint): Change return type to bool.
3174         (is_tracepoint): Likewise.
3175         (is_breakpoint): Likewise.
3176         (is_hardware_watchpoint): Likewise.
3177         (is_watchpoint): Likewise.
3178         (is_no_memory_software_watchpoint): Likewise.
3179         (is_catchpoint): Likewise.
3180         (breakpoint_1): Make FILTER parameter's return type bool.
3181         is_masked_watchpoint): Change return type to bool.
3182         (save_breakpoints): Make FILTER parameter's return type bool.
3183         * breakpoint.h (is_breakpoint): Change return type to bool.
3184         (is_watchpoint): Likewise.
3185         (is_catchpoint): Likewise.
3186         (is_tracepoint): Likewise.
3187
3188 2019-07-10  Tom Tromey  <tom@tromey.com>
3189
3190         * defs.h: Don't include gdbarch.h.
3191         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3192         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3193         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3194         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3195         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3196         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3197         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3198         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3199         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3200         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3201         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3202         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3203         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3204         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3205         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3206         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3207         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3208         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3209         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3210         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3211         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3212         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3213         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3214         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3215         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3216         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3217         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3218
3219 2019-07-10  Tom Tromey  <tromey@adacore.com>
3220
3221         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3222         * breakpoint.c (init_ada_exception_breakpoint): Register as
3223         bp_catchpoint.
3224         (print_one_breakpoint_location, print_one_breakpoint): Use
3225         is_ada_exception_catchpoint.
3226         * ada-lang.c (class ada_catchpoint_location): Pass
3227         bp_loc_software_breakpoint to bp_location constructor.
3228         (is_ada_exception_catchpoint): New function.
3229
3230 2019-07-10  Tom Tromey  <tromey@adacore.com>
3231
3232         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3233         VEC.
3234         (struct arm_exidx_entry): New method operator<.
3235         (struct arm_exidx_data) <section_maps>: Change type.
3236         (arm_exidx_data_free): Remove.
3237         (arm_exidx_data_key): Change type.  Move lower.
3238         (arm_exidx_new_objfile): Update.
3239         (arm_compare_exidx_entries): Remove.
3240         (arm_find_exidx_entry, _initialize_arm_tdep)
3241
3242 2019-07-10  Tom Tromey  <tromey@adacore.com>
3243
3244         * solib-spu.c (ocl_program_data_key): Change type.
3245         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3246         Update.
3247
3248 2019-07-10  Tom Tromey  <tromey@adacore.com>
3249
3250         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3251         (struct solib_aix_inferior_data) <library_list>: Change type.
3252         (solib_aix_inferior_data_handle): Change type.
3253         (get_solib_aix_inferior_data): Update.
3254         (solib_aix_free_library_list): Remove.
3255         (library_list_start_library): Update.
3256         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3257         return type.
3258         (solib_aix_get_library_list)
3259         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3260         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3261
3262 2019-07-10  Tom Tromey  <tromey@adacore.com>
3263
3264         * solib-dsbt.c (struct dsbt_info): Add initializers.
3265         (solib_dsbt_pspace_data): Change type.
3266         (dsbt_pspace_data_cleanup): Remove.
3267         (get_dsbt_info, _initialize_dsbt_solib): Update.
3268
3269 2019-07-10  Tom Tromey  <tromey@adacore.com>
3270
3271         * spu-tdep.c (spu_overlay_data): Change type.
3272         (spu_get_overlay_table, spu_overlay_new_objfile)
3273         (_initialize_spu_tdep): Update.
3274
3275 2019-07-10  Tom Tromey  <tromey@adacore.com>
3276
3277         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3278         destructor.
3279         (dbx_objfile_data_key): Change type and declare later.
3280         (DBX_SYMFILE_INFO): Rewrite.
3281         * dbxread.c (dbx_objfile_data_key): Change type.
3282         (dbx_symfile_init): Update.
3283         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3284         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3285         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3286
3287 2019-07-10  Tom Tromey  <tromey@adacore.com>
3288
3289         * jit.c (jit_program_space_key): Change type.  Move lower.
3290         (get_jit_program_space_data): Update.
3291         (jit_program_space_data_cleanup): Remove.
3292         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3293         Update.
3294         (struct jit_program_space_data): Add initializers.
3295
3296 2019-07-10  Tom Tromey  <tromey@adacore.com>
3297
3298         * solib-darwin.c (struct darwin_info): Add initializers.
3299         (solib_darwin_pspace_data): Change type.
3300         (darwin_pspace_data_cleanup): Remove.
3301         (get_darwin_info, _initialize_darwin_solib): Update.
3302
3303 2019-07-10  Tom Tromey  <tromey@adacore.com>
3304
3305         * remote-sim.c (struct sim_inferior_data): Add initializers,
3306         constructor, and destructor.
3307         (sim_inferior_data_key): Change type.  Move lower.
3308         (check_for_duplicate_sim_descriptor): Update.
3309         (get_sim_inferior_data): Use new.  Update.
3310         (~sim_inferior_data_cleanup): Rename from
3311         sim_inferior_data_cleanup.  Simplify.
3312         (gdbsim_close_inferior, simulator_command)
3313         (sim_command_completer, _initialize_remote_sim): Update.
3314         (next_pid, INITIAL_PID): Move earlier.
3315
3316 2019-07-10  Tom Tromey  <tromey@adacore.com>
3317
3318         * python/python-internal.h (create_thread_object): Return
3319         gdbpy_ref.
3320         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3321         * python/py-inferior.c (struct threadlist_entry): Add
3322         constructor.
3323         <thread_obj>: Now a gdbpy_ref.
3324         (thread_to_thread_object): Update.
3325         (add_thread_object): Use new.
3326         (delete_thread_object): Use delete.
3327         (infpy_threads): Update.
3328         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3329         GIL.
3330
3331 2019-07-10  Tom Tromey  <tromey@adacore.com>
3332
3333         * valops.c (value_cast): Specialize error message for Ada.
3334
3335 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3336
3337         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3338
3339 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3340
3341         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3342         bpstat_should_step): Return bool, adjust comments.
3343         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3344         bpstat_should_step): Likewise.
3345
3346 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3347
3348         * features/Makefile: Use feature target descriptions for Arm.
3349         * features/arm/arm-core.c: Generate new file.
3350         * features/arm/arm-fpa.c: Likewise.
3351         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3352         * features/arm/arm-m-profile.c: Likewise.
3353         * features/arm/arm-vfpv2.c: Likewise.
3354         * features/arm/arm-vfpv3.c: Likewise.
3355         * features/arm/xscale-iwmmxt.c: Likewise.
3356         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3357
3358 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3359
3360         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3361         ptrace earlier.
3362
3363 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3364
3365         * features/aarch64-pauth.c: Regenerate.
3366
3367 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3368
3369         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3370         bool.
3371         (bpstat_what): Use false instead of 0.
3372
3373 2019-07-09  Pedro Alves  <palves@redhat.com>
3374
3375         * break-catch-throw.c (is_exception_catchpoint): New.
3376         * breakpoint.c (print_one_breakpoint_location): New parameter
3377         'raw_loc'.  Handle it.  Use
3378         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3379         looking at the breakpoint's type.
3380         (print_one_breakpoint): If handling "maint info breakpoints", also
3381         print locations of exception catchpoints.
3382         * breakpoint.h (is_exception_catchpoint): Declare.
3383
3384 2019-07-09  Pedro Alves  <palves@redhat.com>
3385
3386         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3387         "addr" field.
3388         (allocate_location_exception_catchpoint): New.
3389         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3390         (initialize_throw_catchpoint_ops): Install
3391         allocate_location_exception_catchpoint as allocate_location
3392         method.
3393         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3394         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3395         bp_loc_other.
3396         (breakpoint_address_is_meaningful): Delete.
3397         (bl_address_is_meaningful): New.
3398         (breakpoint_locations_match): Adjust comment.
3399         (bp_location_from_bp_type): New, factored out of...
3400         (bp_location::bp_location(breakpoint *)): ... this.
3401         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3402         factored out of...
3403         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3404         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3405         breakpoint_address_is_meaningful.
3406         (bp_locations_compare): Adjust comment.
3407         (update_global_location_list): Use bl_address_is_meaningful
3408         instead of breakpoint_address_is_meaningful.
3409         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3410         explicit.
3411         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3412         * python/py-breakpoint.c (bppy_get_location): No longer check
3413         whether location is null.
3414
3415 2019-07-09  Pedro Alves  <palves@redhat.com>
3416
3417         PR c++/15468
3418         * breakpoint.c (print_one_breakpoint_location): Remove
3419         single-location assert.
3420
3421 2019-07-09  Tom Tromey  <tom@tromey.com>
3422
3423         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3424         * configure: Rebuild.
3425         * configure.ac: Change common to gdbsupport.
3426         * gdbsupport: Rename from common.
3427         * acinclude.m4: Change common to gdbsupport.
3428         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3429         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3430         gdbsupport.
3431         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3432         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3433         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3434         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3435         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3436         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3437         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3438         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3439         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3440         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3441         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3442         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3443         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3444         coff-pe-read.c, command.h, compile/compile-c-support.c,
3445         compile/compile-c.h, compile/compile-cplus-symbols.c,
3446         compile/compile-cplus-types.c, compile/compile-cplus.h,
3447         compile/compile-loc2c.c, compile/compile.c, completer.c,
3448         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3449         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3450         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3451         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3452         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3453         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3454         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3455         features/aarch64-core.c, features/aarch64-fpu.c,
3456         features/aarch64-pauth.c, features/aarch64-sve.c,
3457         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3458         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3459         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3460         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3461         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3462         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3463         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3464         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3465         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3466         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3467         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3468         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3469         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3470         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3471         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3472         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3473         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3474         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3475         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3476         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3477         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3478         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3479         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3480         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3481         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3482         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3483         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3484         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3485         minsyms.c, mips-linux-tdep.c, namespace.h,
3486         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3487         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3488         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3489         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3490         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3491         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3492         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3493         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3494         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3495         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3496         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3497         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3498         procfs.c, producer.c, progspace.h, psymtab.h,
3499         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3500         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3501         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3502         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3503         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3504         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3505         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3506         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3507         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3508         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3509         target-memory.c, target.c, target.h, target/waitstatus.c,
3510         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3511         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3512         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3513         unittests/array-view-selftests.c,
3514         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3515         unittests/common-utils-selftests.c,
3516         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3517         unittests/format_pieces-selftests.c,
3518         unittests/function-view-selftests.c,
3519         unittests/lookup_name_info-selftests.c,
3520         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3521         unittests/mkdir-recursive-selftests.c,
3522         unittests/observable-selftests.c,
3523         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3524         unittests/parse-connection-spec-selftests.c,
3525         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3526         unittests/scoped_fd-selftests.c,
3527         unittests/scoped_mmap-selftests.c,
3528         unittests/scoped_restore-selftests.c,
3529         unittests/string_view-selftests.c, unittests/style-selftests.c,
3530         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3531         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3532         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3533         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3534         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3535         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3536
3537 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3540         bool value.
3541         (decode_digits_ordinary): Set explicit_line field in sal.
3542         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3543         symtab_and_line that was set on an explicit line number in
3544         assembler code.  Do always update the recorded symtab and line if
3545         we do skip the prologue.
3546
3547 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * breakpoint.c (set_breakpoint_location_function): Remove
3550         explicit_loc parameter.
3551         (momentary_breakpoint_from_master): Update call to
3552         set_breakpoint_location_function.
3553         (add_location_to_breakpoint): Likewise.
3554
3555 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3558         required features based on default bfd type when no specific bfd
3559         is present.
3560
3561 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3562
3563         * NEWS: Mention that GDB printf and eval commands can now print
3564         C-style and Ada-style convenience var strings without
3565         calling the inferior.
3566         * printcmd.c (printf_c_string): Locally print GDB internal var
3567         instead of transiting via the inferior.
3568         (printf_wide_c_string): Likewise.
3569
3570 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3571
3572         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3573
3574 2019-07-04  Tom Tromey  <tom@tromey.com>
3575
3576         PR tui/24724:
3577         * tui/tui-winsource.c (tui_clear_source_content): Update.
3578         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3579         (tui_update_breakpoint_info): Update.
3580         (tui_set_exec_info_content): Update.
3581         * tui/tui-source.c (tui_set_source_content_nil): Update.
3582         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3583         has_break.
3584         * tui/tui-data.h (enum tui_bp_flag): New.
3585         (tui_bp_flags): New enum flags type.
3586         (struct tui_source_element) <break_mode>: Change type.  Rename
3587         from has_break.
3588         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3589         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3590         constants.
3591         * tui/tui-winsource.h: Fix comment.
3592
3593 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3594
3595         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3596         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3597         (store_fpregs_to_thread)
3598         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3599         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3600         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3601         (IWMMXT_REGS_SIZE): Add define.
3602         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3603         (fetch_vfp_regs, store_vfp_regs)
3604         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3605         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3606
3607 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3608
3609         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3610         defines.
3611         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3612         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3613         (ARM_INT_REGISTER_SIZE): ...to this.
3614         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3615         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3616         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3617         (arm_linux_collect_gregset, supply_nwfpe_register)
3618         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3619         defines.
3620         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3621         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3622         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3623         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3624         (arm_return_in_memory, arm_store_return_value)
3625         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3626         (arm_record_ld_st_multiple): Likewise.
3627         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3628         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3629
3630 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3631
3632         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3633         AARCH64_DISPLACED_MODIFIED_INSNS.
3634         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3635         (aarch64_displaced_step_copy_insn): Likewise.
3636         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3637         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3638         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3639         ARM_DISPLACED_MODIFIED_INSNS.
3640         * arm-tdep.c (arm_gdbarch_init): Likewise.
3641         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3642         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3643         (struct arm_displaced_step_closure): Use
3644         ARM_DISPLACED_MODIFIED_INSNS.
3645
3646 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3647
3648         * features/Makefile: Remove unused xml files.
3649         * features/aarch64.xml: Remove.
3650         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3651         * features/i386/amd64-avx-avx512.xml: Remove.
3652         * features/i386/amd64-avx-linux.xml: Remove.
3653         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3654         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3655         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3656         * features/i386/amd64-avx-mpx.xml: Remove.
3657         * features/i386/amd64-avx.xml: Remove.
3658         * features/i386/amd64-linux.xml: Remove.
3659         * features/i386/amd64-mpx-linux.xml: Remove.
3660         * features/i386/amd64-mpx.xml: Remove.
3661         * features/i386/amd64.xml: Remove.
3662         * features/i386/i386-avx-avx512-linux.xml: Remove.
3663         * features/i386/i386-avx-avx512.xml: Remove.
3664         * features/i386/i386-avx-linux.xml: Remove.
3665         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3666         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3667         * features/i386/i386-avx-mpx-linux.xml: Remove.
3668         * features/i386/i386-avx-mpx.xml: Remove.
3669         * features/i386/i386-avx.xml: Remove.
3670         * features/i386/i386-linux.xml: Remove.
3671         * features/i386/i386-mmx-linux.xml: Remove.
3672         * features/i386/i386-mmx.xml: Remove.
3673         * features/i386/i386-mpx-linux.xml: Remove.
3674         * features/i386/i386-mpx.xml: Remove.
3675         * features/i386/i386.xml: Remove.
3676         * features/i386/x32-avx-avx512-linux.xml: Remove.
3677         * features/i386/x32-avx-linux.xml: Remove.
3678         * features/i386/x32-linux.xml: Remove.
3679
3680 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3681
3682         * regformats/aarch64.dat: Remove.
3683         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3684         * regformats/i386/amd64-avx-linux.dat: Remove.
3685         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3686         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3687         * regformats/i386/amd64-linux.dat: Remove.
3688         * regformats/i386/amd64-mpx-linux.dat: Remove.
3689         * regformats/i386/amd64.dat: Remove.
3690         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3691         * regformats/i386/i386-avx-linux.dat: Remove.
3692         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3693         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3694         * regformats/i386/i386-linux.dat: Remove.
3695         * regformats/i386/i386-mmx-linux.dat: Remove.
3696         * regformats/i386/i386-mpx-linux.dat: Remove.
3697         * regformats/i386/i386.dat: Remove.
3698         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3699         * regformats/i386/x32-avx-linux.dat: Remove.
3700         * regformats/i386/x32-linux.dat: Remove.
3701
3702 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3703
3704         * aarch64-tdep.c: Remove xml self tests.
3705         * amd64-linux-tdep.c: Likewise.
3706         * amd64-tdep.c: Likewise.
3707         * i386-linux-tdep.c: Likewise.
3708         * i386-tdep.c: Likewise.
3709
3710 2019-07-03  Pedro Alves  <palves@redhat.com>
3711
3712         PR cli/24732
3713         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3714         (pipe_cmd_option_defs): New.
3715         (make_pipe_cmd_options_def_group): New.
3716         (pipe_command): Use gdb::option::process_options.
3717         (pipe_command_completer): New function.
3718         (_initialize_cli_cmds): Install completer for "pipe" command.
3719
3720 2019-07-03  Pedro Alves  <palves@redhat.com>
3721
3722         * cli/cli-option.c (union option_value) <string>: New field.
3723         (struct option_def_and_value): Add ctor, move ctor, dtor and
3724         use DISABLE_COPY_AND_ASSIGN.
3725         (option_def_and_value::clear_value): New.
3726         (parse_option, save_option_value_in_ctx, get_val_type_str)
3727         (add_setshow_cmds_for_options): Handle var_string.
3728         * cli-option.h (union option_def::var_address) <string>: New
3729         field.
3730         (struct string_option_def): New.
3731         * maint-test-options.c (struct test_options_opts): Add default
3732         ctor and use DISABLE_COPY_AND_ASSIGN.
3733         <string_opt>: New field.
3734         (test_options_opts::~test_options_opts): New.
3735         (test_options_opts::dump): Also dump "-string".
3736         (test_options_option_defs): Install "string.
3737
3738 2019-07-03  Pedro Alves  <palves@redhat.com>
3739
3740         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3741         option_value with a null enumeration.
3742         (complete_options): Save the option values in the context.
3743         (save_option_value_in_ctx): New, factored out from ...
3744         (process_options): ... here.
3745         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3746         of the function.
3747         * maint-test-options.c (test_options_opts::dump): New, factored
3748         out from ...
3749         (maintenance_test_options_command_mode): ... here.
3750         (maintenance_test_options_command_completion_result): Delete.
3751         (maintenance_test_options_command_completion_text): Update
3752         comment.
3753         (maintenance_show_test_options_completion_result): Change
3754         prototype.  Just print
3755         maintenance_test_options_command_completion_text.
3756         (save_completion_result): New.
3757         (maintenance_test_options_completer_mode): Pass options context to
3758         complete_options, and then save a dump.
3759         (_initialize_maint_test_options): Use add_cmd to install "maint
3760         show test-options-completion-result".
3761
3762 2019-07-03  Pedro Alves  <palves@redhat.com>
3763
3764         * NEWS (New commands): Mention "with" and "maint with".
3765         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3766         (with_command, with_command_completer): New.
3767         (pipe_command): Adjust to new repeat_previous
3768         interface.
3769         (_initialize_cli_cmds): Install the "with" command and its "w"
3770         alias.
3771         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3772         declarations.
3773         * cli/cli-setshow.c (parse_cli_var_uinteger)
3774         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3775         argument strings for all var_types.
3776         (get_setshow_command_value_string): New, factored out from ...
3777         (do_show_command): ... this.
3778         * cli/cli-setshow.h: Include <string>.
3779         (get_setshow_command_value_string): Declare.
3780         * command.h (repeat_previous): Now returns const char *.  Adjust
3781         comment.
3782         * maint.c: Include "cli/cli-cmds.h".
3783         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3784         (_initialize_maint_cmds): Register the "maintenance with" command.
3785         * top.c (repeat_previous): Move bits from pipe_command here:
3786         Return the saved command line, if any; error out if there's no
3787         command to relaunch.
3788
3789 2019-07-03  Pedro Alves  <palves@redhat.com>
3790
3791         * NEWS (New commands): Mention "maint set/show test-settings"
3792         instead of "maint test-settings".
3793         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3794         (maintenance_test_settings_set_list): Rename to ...
3795         (maintenance_set_test_settings_list): ... this.
3796         (maintenance_test_settings_show_list): Rename to  ...
3797         (maintenance_show_test_settings_list): ... this.
3798         (maintenance_test_settings_cmd): Delete.
3799         (maintenance_test_settings_set_cmd): ...
3800         (maintenance_set_test_settings_cmd): ... this.
3801         (maintenance_test_settings_show_cmd): ...
3802         (maintenance_show_test_settings_cmd): ... this.
3803         (maintenance_test_settings_show_value_cmd):
3804         (maintenance_show_test_settings_value_cmd): ... this.
3805         (_initialize_maint_test_settings): No longer install the "maint
3806         test-settings" prefix command.  Rename "maint test-settings set"
3807         to "maint set test-settings", and "maint test-settings show" to
3808         "maint show test-settings".  Adjust all subcommands.
3809
3810 2019-07-03  Pedro Alves  <palves@redhat.com>
3811
3812         * maint-test-settings.c: Fix file's intro comment.  Replace all
3813         references to "test-options" with references to "test-settings",
3814         in comments.
3815
3816 2019-07-03  Pedro Alves  <palves@redhat.com>
3817
3818         * maint-test-settings.c (maintenance_test_settings_xxx)
3819         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3820         New.
3821         (maintenance_test_settings_enums): Use them.
3822         (maintenance_test_settings_enum): Default to
3823         maintenance_test_settings_xxx.
3824         (_initialize_maint_test_settings): Initialize
3825         MAINTENANCE_TEST_SETTINGS_FILENAME.
3826
3827 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3828
3829         * breakpoint.h (remove_breakpoints_inf): Change return type to
3830         void, move function documentation here.
3831         * breakpoint.c (remove_breakpoints_inf): Change return type to
3832         void, move function documentation to header.
3833
3834 2019-07-02  Pedro Alves  <palves@redhat.com>
3835
3836         * NEWS (Completion improvements): Mention "info threads".
3837         * thread.c (struct info_threads_opts, info_threads_option_defs)
3838         (make_info_threads_options_def_group): New.
3839         (info_threads_command): Use gdb::option::process_options.
3840         (info_threads_command_completer): New.
3841         (_initialize_thread): Use gdb::option::build_help to build the
3842         help text for "info threads".
3843
3844 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3845
3846         * defs.h (generic_load): Move from here...
3847         * symfile.h (generic_load): ... to here.  Rename name parameter
3848         to args.
3849         * symfile.c (generic_load): Add comment.
3850
3851 2019-07-01  Tom Tromey  <tromey@adacore.com>
3852
3853         * dwarf2read.c
3854         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3855         declaration of without_params.  Fix formatting.
3856
3857 2019-07-01  Tom Tromey  <tromey@adacore.com>
3858
3859         * ada-exp.y (find_primitive_type): Update.
3860         * ada-lang.h (ada_lookup_symbol): Update.
3861         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3862         parameter.
3863         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3864
3865 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3866
3867         PR breakpoints/24541
3868         * gdbarch.c: Regenerate.
3869         * gdbarch.h: Regenerate.
3870         * gdbarch.sh: Add 'stap_adjust_register'.
3871         * i386-tdep.c: Include '<unordered_set>'.
3872         (i386_stap_adjust_register): New function.
3873         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3874         * stap-probe.c (stap_parse_register_operand): Call
3875         'gdbarch_stap_adjust_register'.
3876
3877 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3878
3879         PR python/24742
3880         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3881         * python/python.c (do_start_initialization): Use 'xmalloc'
3882         instead of 'PyMem_Malloc'.
3883
3884 2019-06-28  Tom Tromey  <tromey@adacore.com>
3885
3886         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3887         for Ada.
3888
3889 2019-06-27  Tom Tromey  <tromey@adacore.com>
3890
3891         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3892         objfile_key.
3893         (arm_find_mapping_symbol, arm_record_special_symbol)
3894         (_initialize_arm_tdep): Update.
3895         (arm_objfile_data_free): Remove.
3896
3897 2019-06-27  Tom Tromey  <tromey@adacore.com>
3898
3899         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3900         to cp_print_static_field.
3901
3902 2019-06-26  Tom Tromey  <tromey@adacore.com>
3903
3904         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3905         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3906         declare.
3907
3908 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3909
3910         * features/aarch64-core.c (create_feature_aarch64_core):
3911         Regenerate.
3912         * features/aarch64-core.xml: Add cpsr flags.
3913
3914 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3915
3916         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3917         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3918
3919 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3920
3921         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3922         field.
3923         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3924         use.
3925         (arm_record_special_symbol): Don't insert new symbol in sorted
3926         position, push it at the end.
3927
3928 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3929
3930         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3931         (arm_mapping_symbol_s): Remove.
3932         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3933         (arm_mapping_symbol_vec): New typedef.
3934         (struct arm_per_objfile): Add constructor.
3935         <section_maps>: Change type to
3936         std::unique_ptr<arm_mapping_symbol_vec[]>.
3937         (arm_compare_mapping_symbols): Remove.
3938         (arm_find_mapping_symbol): Adjust to section_maps type change.
3939         (arm_objfile_data_free): Call delete on arm_per_objfile.
3940         (arm_record_special_symbol): Adjust to section_maps type change.
3941         Allocate arm_per_objfile with new.
3942
3943 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944
3945         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3946         with the command prefix.
3947
3948 2019-06-25  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3951         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3952
3953 2019-06-25  Tom Tromey  <tom@tromey.com>
3954
3955         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3956         type.
3957         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3958         protected.
3959
3960 2019-06-25  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-winsource.c
3963         (tui_source_window_base::set_is_exec_point_at): Add check against
3964         LOA_ADDRESS.
3965
3966 2019-06-25  Tom Tromey  <tom@tromey.com>
3967
3968         * tui/tui-source.c (tui_set_source_content): Don't check before
3969         xfree.
3970         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-winsource.h (tui_update_source_window_as_is)
3975         (tui_alloc_source_buffer, tui_line_is_displayed)
3976         (tui_addr_is_displayed): Change type of win_info.
3977         * tui/tui-winsource.c (tui_update_source_window_as_is)
3978         (tui_clear_source_content, tui_show_source_line)
3979         (tui_show_source_content, tui_source_window_base::refill)
3980         (tui_source_window_base::set_is_exec_point_at)
3981         (tui_source_window_base::set_is_exec_point_at)
3982         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3983         (tui_alloc_source_buffer, tui_line_is_displayed)
3984         (tui_addr_is_displayed): Change type of win_info.  Update.
3985         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3986         (tui_source_window_base::do_make_visible_with_new_height):
3987         Update.
3988         * tui/tui-source.c (tui_set_source_content)
3989         (tui_set_source_content_nil)
3990         (tui_source_window::do_scroll_vertical): Update.
3991         * tui/tui-layout.c (show_layout): Update.
3992         * tui/tui-disasm.c (tui_set_disassem_content)
3993         (tui_disasm_window::do_scroll_vertical): Update.
3994         * tui/tui-data.h (tui_win_content): Remove.
3995         (struct tui_gen_win_info) <content, content_size>: Remove.
3996         (struct tui_source_element): Add initializers and destructor.
3997         (union tui_which_element, struct tui_win_element): Remove.
3998         (struct tui_source_window_base) <content>: New field.
3999         (struct tui_data_window): Remove destructor.
4000         (tui_alloc_content, tui_free_win_content)
4001         (tui_free_all_source_wins_content): Don't declare.
4002         * tui/tui-data.c (tui_initialize_static_data): Update.
4003         (init_content_element, tui_alloc_content): Remove.
4004         (~tui_gen_win_info): Update.
4005         (~tui_data_window, tui_free_all_source_wins_content)
4006         (tui_free_win_content, free_content, free_content_elements):
4007         Remove.
4008
4009 2019-06-25  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-winsource.h (tui_clear_source_content)
4012         (tui_erase_source_content, tui_show_source_content): Change type
4013         of win_info.
4014         * tui/tui-winsource.c (tui_clear_source_content)
4015         (tui_erase_source_content, tui_show_source_content): Change type
4016         of win_info.
4017         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4018         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4019         win_info.
4020         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4021         win_info.
4022         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-winsource.c (tui_clear_source_content)
4027         (tui_source_window_base::set_is_exec_point_at): Update.
4028         * tui/tui-source.c (tui_set_source_content_nil): Update.
4029         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4030         a bool.
4031         * tui/tui-data.c (init_content_element): Update.
4032
4033 2019-06-25  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4036         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4037         * tui/tui-layout.c (init_and_make_win): Update.
4038         * tui/tui.h (enum tui_win_type): Update.
4039         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4040         tui_win_is_auxillary.
4041         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4042         tui_win_is_auxillary.
4043
4044 2019-06-25  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4047         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4048         (tui_delete_data_content_windows, tui_display_all_data)
4049         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4050         Update.
4051         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4052         * tui/tui-regs.c (tui_last_regs_line_no)
4053         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4054         (tui_show_registers): Update.
4055         (tui_show_register_group): Return void.  Update.
4056         (tui_display_registers_from, tui_display_reg_element_at_line)
4057         (tui_display_registers_from_line, tui_check_register_values):
4058         Update.
4059         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4060         member.
4061         (struct tui_data_window) <regs_content>: Now a std::vector.
4062         <regs_content_count>: Remove.
4063         (tui_add_content_elements, tui_free_data_content): Don't declare.
4064         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4065         (init_content_element): Remove DATA_WIN case.  Add assert.
4066         (tui_add_content_elements): Remove.
4067         (tui_data_window): Update.
4068         (tui_free_data_content): Remove.
4069         (free_content_elements): Remove DATA_WIN case.
4070
4071 2019-06-25  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-data.c (tui_data_item_window): Update.
4074         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4075         * tui/tui-windata.c (tui_display_all_data)
4076         (tui_display_data_from_line): Update.
4077         (tui_check_data_values): Remove.
4078         * tui/tui-regs.c (tui_show_register_group)
4079         (tui_display_reg_element_at_line): Update.
4080         * tui/tui-hooks.c (tui_register_changed)
4081         (tui_refresh_frame_and_register_information): Call
4082         tui_check_register_values.
4083         * tui/tui-data.h (struct tui_data_window) <data_content,
4084         data_content_count, data_type>: Remove.
4085         (enum tui_data_type): Remove.
4086
4087         * tui/tui-data.c (tui_data_window::clear_detail)
4088         (~tui_data_window): Update.
4089
4090 2019-06-25  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4093         declare.
4094         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4095         Rename from tui_first_data_item_displayed.  Update.
4096         (tui_data_window::refresh_all)
4097         (tui_data_window::do_scroll_vertical): Update.
4098         * tui/tui-data.h (struct tui_data_window)
4099         <first_data_item_displayed>: Declare new method.
4100
4101 2019-06-25  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4104         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4105         contents...
4106         (tui_initialize_static_data): ...here.
4107
4108 2019-06-25  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4111         (tui_display_registers_from, tui_check_register_values): Update.
4112         (tui_display_register): Remove win_info parameter; update.
4113         (tui_get_register): Change type of parameters.
4114         * tui/tui-data.h (struct tui_data_element): Remove.
4115         (union tui_which_element) <data>: Remove.
4116         <data_window>: Change type.
4117         (struct tui_data_item_window): New.
4118         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4119         case.  Add assert.
4120         (~tui_data_item_window): New destructor.
4121         (free_content_elements): Remove DATA_ITEM_WIN case.
4122
4123 2019-06-25  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4126         Remove.
4127
4128 2019-06-25  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-data.h (struct tui_command_element): Remove.
4131         (union tui_which_element) <command>: Remove.
4132         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4133         assert.
4134         (free_content_elements): Remove CMD_WIN case.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-layout.c (tui_set_layout): Update.
4139         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4140         * tui/tui-data.c (layout_def): Update.
4141
4142 2019-06-25  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4145         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4146         (tui_source_window_base::set_new_height): Update.
4147         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4148         Update.
4149         (tui_set_locator_fullname, tui_set_locator_info)
4150         (tui_show_frame_info): Update.
4151         * tui/tui-source.c (tui_set_source_content)
4152         (tui_source_is_displayed): Update.
4153         * tui/tui-layout.c (show_source_disasm_command, show_data)
4154         (show_source_or_disasm_and_command): Update.
4155         * tui/tui-disasm.c (tui_set_disassem_content)
4156         (tui_get_begin_asm_address): Update.
4157         * tui/tui-data.h (struct tui_locator_element): Remove.
4158         (union tui_which_element) <locator>: Remove.
4159         (struct tui_locator_window): New.
4160         (tui_locator_win_info_ptr): Change return type.
4161         * tui/tui-data.c (_locator): Change type.
4162         (tui_locator_win_info_ptr): Change return type.
4163         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4164         (tui_alloc_content): Add assert.
4165
4166 2019-06-25  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-winsource.c
4169         (tui_exec_info_window::maybe_allocate_content): New method.
4170         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4171         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4172         (make_source_or_disasm_window): Add cast.
4173         * tui/tui-data.h (union tui_which_element) <simple_string>:
4174         Remove.
4175         (struct tui_source_info): New.
4176         (struct tui_source_window_base) <execution_info>: Change type.
4177         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4178         case, and add assert.
4179         (tui_alloc_content): Add assert.
4180
4181 2019-06-25  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4184         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4185         * tui/tui-data.c (tui_alloc_win_info): Remove.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4190         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4191         can_highlight.
4192
4193 2019-06-25  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4196         make_visible_with_new_height method.
4197         (tui_win_info::make_visible_with_new_height): New method.
4198         (tui_source_window_base::do_make_visible_with_new_height)
4199         (tui_data_window::do_make_visible_with_new_height)
4200         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4201         (make_visible_with_new_height): Remove.
4202         (tui_resize_all, tui_adjust_win_heights): Use
4203         make_visible_with_new_height method.
4204         * tui/tui-data.h (struct tui_win_info)
4205         <do_make_visible_with_new_height, make_visible_with_new_height>:
4206         New methods.
4207         (struct tui_source_window_base, struct tui_data_window)
4208         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4209         methods.
4210
4211 2019-06-25  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4214         method.
4215         (update_tab_width): Call update_tab_width method.
4216         * tui/tui-data.h (struct tui_win_info)
4217         (struct tui_source_window_base) <update_tab_width>: New methods.
4218
4219 2019-06-25  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4222         parameter.
4223         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4224         parameter.
4225         (tui_gen_win_info::make_visible): Update.
4226         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4227         parameter.
4228         * tui/tui-data.h (enum tui_box): New enum.
4229         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4230
4231 2019-06-25  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4234         init_and_make_win for EXEC_INFO_WIN.
4235         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4236         longer inline.
4237         (struct tui_win_info) <~tui_win_info>: Inline.
4238         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4239         Don't declare.
4240         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4241         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4242         Remove.
4243         (tui_initialize_static_data): Update.
4244         (~tui_gen_win_info): Handle more cleanup here.
4245         (~tui_source_window_base): Delete "execution_info".
4246         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4247
4248 2019-06-25  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-layout.c (make_command_window): Don't set
4251         can_highlight.
4252         (show_source_disasm_command): Call the reset method.
4253         (show_data): Don't set can_highlight.  Call the reset method.
4254         (tui_gen_win_info::reset): Rename from init_gen_win_info
4255         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4256         (show_source_or_disasm_and_command): Call the reset method.
4257         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4258         (struct tui_cmd_window): Set can_highlight.
4259
4260 2019-06-25  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4263         from make_visible.
4264         (tui_make_visible, tui_make_invisible): Rewrite.
4265         (tui_win_info::make_visible): Remove.
4266         (tui_source_window_base::make_visible): Update.
4267         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4268         method.  Moved from...
4269         (struct tui_win_info) <make_visible>: ...here.
4270
4271 2019-06-25  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-winsource.c
4274         (tui_source_window_base::do_scroll_horizontal): Remove direction
4275         parameter.
4276         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4277         direction parameter.
4278         * tui/tui-win.c (tui_win_info::forward_scroll)
4279         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4280         (tui_win_info::right_scroll): Update.
4281         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4282         direction parameter.
4283         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4284         direction parameter.
4285         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4286         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4287         Remove direction parameter.
4288         (struct tui_source_window_base, struct tui_source_window)
4289         (struct tui_disasm_window, struct tui_data_window)
4290         (struct tui_cmd_window): Update.
4291
4292 2019-06-25  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-winsource.h (tui_set_exec_info_content)
4295         (tui_show_exec_info_content, tui_erase_exec_info_content)
4296         (tui_clear_exec_info_content, tui_update_exec_info): Change
4297         argument to tui_source_window_base.
4298         * tui/tui-winsource.c (tui_set_exec_info_content)
4299         (tui_show_exec_info_content, tui_erase_exec_info_content)
4300         (tui_clear_exec_info_content, tui_update_exec_info): Change
4301         argument to tui_source_window_base.
4302
4303 2019-06-25  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4306         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4307
4308 2019-06-25  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4311         check.
4312
4313 2019-06-25  Tom Tromey  <tom@tromey.com>
4314
4315         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4316         type to void.
4317         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4318         type to void.
4319         * tui/tui-source.c (tui_set_source_content): Update.
4320         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4321
4322 2019-06-25  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-win.c (window_name_completer, tui_set_focus)
4325         (tui_all_windows_info): Use name method.
4326         * tui/tui-data.h (struct tui_gen_win_info)
4327         (struct tui_source_window, struct tui_disasm_window)
4328         (struct tui_data_window, struct tui_cmd_window) <name>: New
4329         method.
4330         (tui_win_name): Don't declare.
4331         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4332         (tui_win_name): Remove.
4333
4334 2019-06-25  Tom Tromey  <tom@tromey.com>
4335
4336         * tui/tui-winsource.h (tui_update_source_window)
4337         (tui_update_source_window_as_is): Change parameter type.
4338         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4339         to be a tui_source_window_base.
4340         (tui_update_source_window_as_is): Likewise.
4341         * tui/tui-win.c (make_visible_with_new_height): Update.
4342
4343 2019-06-25  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui-winsource.c (tui_erase_source_content)
4346         (tui_show_source_content, tui_show_exec_info_content)
4347         (tui_erase_exec_info_content): Use refresh_window method.
4348         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4349         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4350         from tui_refresh_win.
4351         (tui_data_window::refresh_window): New method.
4352         (tui_win_info::refresh, tui_source_window_base::refresh)
4353         (tui_refresh_all): Use refresh_window method.
4354         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4355         method.
4356         * tui/tui-regs.c (tui_display_register): Call refresh_window
4357         method.
4358         * tui/tui-layout.c (show_source_disasm_command)
4359         (show_source_or_disasm_and_command): Call refresh_window method.
4360         * tui/tui-data.h (struct tui_gen_win_info)
4361         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4362         New method.
4363
4364 2019-06-25  Tom Tromey  <tom@tromey.com>
4365
4366         * tui/tui.c (tui_rl_other_window, tui_enable)
4367         (tui_is_window_visible, tui_get_command_dimension): Update.
4368         * tui/tui-winsource.c (tui_update_source_window_as_is)
4369         (tui_clear_source_content, tui_erase_source_content)
4370         (tui_show_source_line, tui_source_window_base::refill)
4371         (tui_source_window_base::do_scroll_horizontal)
4372         (tui_source_window_base::set_is_exec_point_at)
4373         (tui_update_breakpoint_info, tui_set_exec_info_content)
4374         (tui_alloc_source_buffer, tui_line_is_displayed)
4375         (tui_addr_is_displayed): Update.
4376         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4377         (tui_check_and_display_highlight_if_needed)
4378         (tui_win_info::make_visible, tui_win_info::refresh)
4379         (tui_refresh_all): Update.
4380         * tui/tui-windata.c (tui_first_data_item_displayed)
4381         (tui_delete_data_content_windows, tui_erase_data_content)
4382         (tui_display_all_data, tui_data_window::refresh_all)
4383         (tui_check_data_values): Update.
4384         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4385         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4386         (tui_win_info::backward_scroll, tui_refresh_all_win)
4387         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4388         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4389         (tui_source_window_base::set_new_height)
4390         (tui_data_window::set_new_height)
4391         (make_invisible_and_set_new_height)
4392         (make_visible_with_new_height, new_height_ok)
4393         (parse_scrolling_args): Update.
4394         * tui/tui-stack.c (tui_show_frame_info): Update.
4395         * tui/tui-source.c (tui_set_source_content)
4396         (tui_set_source_content_nil, tui_source_is_displayed)
4397         (tui_source_window::do_scroll_vertical): Update.
4398         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4399         (tui_display_registers_from, tui_display_reg_element_at_line)
4400         (tui_check_register_values, tui_reg_command): Update.
4401         * tui/tui-layout.c (tui_default_win_height)
4402         (show_source_disasm_command, show_data, init_and_make_win)
4403         (show_source_or_disasm_and_command): Update.
4404         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4405         (tui_redisplay_readline, tui_mld_flush)
4406         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4407         (tui_getc): Update.
4408         * tui/tui-disasm.c (tui_set_disassem_content)
4409         (tui_disasm_window::do_scroll_vertical): Update.
4410         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4411         Now virtual.
4412         (struct tui_win_info): Derive from tui_gen_win_info.
4413         <~tui_win_info>: Mark as override.
4414         <generic>: Remove member.
4415         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4416         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4417         (~tui_data_window, ~tui_win_info)
4418         (tui_free_all_source_wins_content): Update.
4419         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4420
4421 2019-06-25  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-layout.c (init_and_make_win): Use new.
4424         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4425         destructor, initializers.
4426         (tui_alloc_generic_win_info): Don't declare.
4427         * tui/tui-data.c (_locator): Add argument to constructor.
4428         (source_win, disasm_win): New globals.
4429         (exec_info): Remove.
4430         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4431         Update.
4432         (tui_alloc_generic_win_info): Remove.
4433         (init_content_element): Use new.
4434         (tui_win_info::tui_win_info): Update.
4435         (free_content_elements) <case DATA_WIN>: Use delete.
4436
4437 2019-06-25  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4440         * tui/tui-windata.c (tui_first_data_item_displayed)
4441         (tui_delete_data_content_windows): Update.
4442         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4443         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4444         (tui_display_registers_from, tui_check_register_values): Update.
4445         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4446         pointer.
4447         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4448         window.
4449         (tui_free_data_content): Update.
4450         (free_content_elements) <case DATA_WIN>: Free the window.
4451
4452 2019-06-25  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4455         Update.
4456         * tui/tui-layout.c (make_command_window)
4457         (show_source_disasm_command, show_data, init_and_make_win)
4458         (show_source_or_disasm_and_command): Update.
4459         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4460         method.
4461         <can_highight, is_highlighted>: Now bool.
4462         (tui_set_win_highlight): Don't declare.
4463         * tui/tui-data.c (tui_set_win_highlight): Remove.
4464
4465 2019-06-25  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui-wingeneral.c (make_visible): Remove check of window
4468         type.
4469
4470 2019-06-25  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-win.c (tui_win_info::max_height)
4473         (tui_cmd_window::max_height): New methods.
4474         (new_height_ok): Call max_height.
4475         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4476         <max_height>: New method.
4477
4478 2019-06-25  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-win.c (tui_source_window_base::set_new_height)
4481         (tui_data_window::set_new_height): New methods.
4482         (make_invisible_and_set_new_height): Call set_new_height method.
4483         * tui/tui-data.h (struct tui_win_info)
4484         (struct tui_source_window_base, struct tui_data_window)
4485         <set_new_height>: New method.
4486
4487 2019-06-25  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4490         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4491         tui_refresh_data_win.
4492         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4493         method.
4494         (tui_refresh_all_win): Call the refresh_all method.
4495         (tui_set_focus): Likewise.
4496         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4497         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4498         Likewise.
4499
4500 2019-06-25  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-winsource.h (tui_refill_source_window)
4503         (tui_set_is_exec_point_at): Don't declare.
4504         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4505         (tui_source_window_base::refill): Rename from
4506         tui_refill_source_window.
4507         (tui_source_window_base::do_scroll_horizontal): Update.
4508         (tui_source_window_base::set_is_exec_point_at): Rename from
4509         tui_set_is_exec_point_at.
4510         (tui_update_all_breakpoint_info): Update.
4511         * tui/tui-stack.c (tui_show_frame_info): Update.
4512         * tui/tui-layout.c (show_data): Add cast.
4513         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4514         * tui/tui-data.h (struct tui_source_window_base) <refill,
4515         set_is_exec_point_at>: New methods.
4516         (tui_source_windows, tui_add_to_source_windows): Update types.
4517         (tui_add_to_source_windows): Remove redundant declaration.
4518         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4519         (tui_source_windows): Change return type.
4520         (tui_clear_source_windows_detail): Update.
4521         (tui_add_to_source_windows): Change type of parameter.
4522         (tui_free_all_source_wins_content): Update.
4523
4524 2019-06-25  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-wingeneral.c (tui_win_info::refresh)
4527         (tui_source_window_base::refresh): New methods.
4528         (tui_refresh_all): Call the refresh method.
4529         * tui/tui-data.h (struct tui_win_info)
4530         (struct tui_source_window_base) <refresh>: New method.
4531
4532 2019-06-25  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui.h (tui_is_window_visible): Return bool.
4535         * tui/tui.c (tui_is_window_visible): Return bool.
4536         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4537         (tui_make_visible, tui_make_invisible)
4538         (tui_win_info::make_visible)
4539         (tui_source_window_base::make_visible, make_all_visible)
4540         (tui_make_all_visible, tui_make_all_invisible): Update.
4541         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4542         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4543         bool.
4544         (struct tui_win_info, struct tui_source_window_base)
4545         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4546         * tui/tui-data.c (tui_init_generic_part): Update.
4547
4548 2019-06-25  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4551         (tui_source_window_base::make_visible): New methods.
4552         (make_all_visible): Make method call.
4553         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4554         (struct tui_source_window_base, struct tui_cmd_window): Override
4555         make_visible.
4556         (tui_win_is_source_type): Don't declare.
4557         * tui/tui-data.c (tui_win_is_source_type): Remove.
4558
4559 2019-06-25  Tom Tromey  <tom@tromey.com>
4560
4561         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4562         NULL check.
4563
4564 2019-06-25  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4567         Inline constructor.  Add initializers for members.
4568         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4569         constructors; now inline in class.
4570
4571 2019-06-25  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-regs.c (tui_show_registers): Update.
4574         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4575         bool.
4576         * tui/tui-data.c (tui_data_window::clear_detail)
4577         (tui_data_window): Update.
4578
4579 2019-06-25  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-windata.c (tui_display_all_data)
4582         (tui_display_data_from_line, tui_display_data_from)
4583         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4584         Update.
4585         * tui/tui-regs.c (tui_last_regs_line_no)
4586         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4587         (tui_show_registers, tui_show_register_group)
4588         (tui_display_registers_from, tui_display_reg_element_at_line)
4589         (tui_display_registers_from_line, tui_check_register_values)
4590         (tui_reg_next, tui_reg_prev): Update.
4591         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4592         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4593         tui_data_window.
4594         (struct tui_win_info) <detail>: Remove.  Add new fields from
4595         tui_data_info.
4596         (TUI_DATA_WIN): Add cast.
4597         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4598         (~tui_data_window): Simplify.
4599
4600 2019-06-25  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-layout.c (show_source_disasm_command)
4603         (show_source_or_disasm_and_command): Update.
4604         * tui/tui-io.c (update_cmdwin_start_line)
4605         (tui_redisplay_readline): Update.
4606         * tui/tui-data.h (struct tui_command_info): Remove.
4607         (struct tui_win_info) <detail>: Remove command_info member.
4608         (struct tui_data_window) <start_line>: New member, from
4609         tui_command_info.
4610         (TUI_CMD_WIN): Add casts.
4611
4612 2019-06-25  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-winsource.c (tui_update_source_window)
4615         (tui_refill_source_window)
4616         (tui_source_window_base::do_scroll_horizontal)
4617         (tui_update_breakpoint_info, tui_set_exec_info_content)
4618         (tui_show_exec_info_content, tui_erase_exec_info_content)
4619         (tui_clear_exec_info_content): Update.
4620         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4621         Update.
4622         * tui/tui-win.c (make_invisible_and_set_new_height)
4623         (make_visible_with_new_height): Update.
4624         * tui/tui-source.c (tui_set_source_content)
4625         (tui_show_symtab_source): Update.
4626         * tui/tui-layout.c (extract_display_start_addr)
4627         (show_source_disasm_command, show_data)
4628         (make_source_or_disasm_window)
4629         (show_source_or_disasm_and_command): Update.
4630         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4631         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4632         "gdbarch".
4633         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4634         to tui_source_window_base.
4635         (struct tui_win_info) <detail>: Remove source_info member.
4636         (struct tui_source_window_base) <has_locator>: Inline.
4637         Move contents from tui_source_info; rename has_locator member to
4638         m_has_locator.
4639         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4640         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4641         header file.
4642         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4643         Simplify.
4644         (tui_free_all_source_wins_content): Cast to
4645         tui_source_window_base.
4646
4647 2019-06-25  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-win.c (make_invisible_and_set_new_height)
4650         (make_visible_with_new_height): Call has_locator method.
4651         * tui/tui-layout.c (show_source_disasm_command, show_data)
4652         (show_source_or_disasm_and_command): Update for bool change.
4653         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4654         (tui_win_info) <has_locator>: New method.
4655         (struct tui_source_window_base) <has_locator>: New method.
4656         (tui_win_has_locator): Don't declare.
4657         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4658         from tui_win_has_locator.
4659         (tui_source_window_base): Use false, not FALSE.
4660
4661 2019-06-25  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4664         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4665         clear_detail method directly.
4666         (tui_clear_win_detail): Remove.
4667
4668 2019-06-25  Tom Tromey  <tom@tromey.com>
4669
4670         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4671         "this", not TUI_DISASM_WIN.
4672
4673 2019-06-25  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4676         declare.
4677         * tui/tui-winsource.c
4678         (tui_source_window_base::do_scroll_horizontal): Rename from
4679         tui_horizontal_source_scroll.
4680         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4681         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4682         from tui_vertical_data_scroll.
4683         * tui/tui-win.h (tui_scroll): Don't declare.
4684         * tui/tui-win.c (tui_win_info::forward_scroll)
4685         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4686         (tui_win_info::right_scroll): Rename and update.
4687         (tui_scroll_forward_command, tui_scroll_backward_command)
4688         (tui_scroll_left_command, tui_scroll_right_command): Update.
4689         (tui_scroll): Remove.
4690         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4691         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4692         from tui_vertical_source_scroll.
4693         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4694         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4695         from tui_vertical_disassem_scroll.
4696         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4697         do_scroll_horizontal>: New methods.
4698         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4699         Likewise.
4700         (struct tui_source_window_base): Add do_scroll_horizontal.
4701         (struct tui_source_window, struct tui_disasm_window): Add
4702         do_scroll_vertical.
4703         (struct tui_data_window, struct tui_cmd_window): Add
4704         do_scroll_horizontal and do_scroll_vertical.
4705         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4706
4707 2019-06-25  Tom Tromey  <tom@tromey.com>
4708
4709         * tui/tui-data.h (struct tui_source_window_base): New struct.
4710         (struct tui_source_window): Derive from tui_source_window_base.
4711         (struct tui_disasm_window): New struct.
4712         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4713         from tui_source_window::clear_detail.
4714         (tui_source_window_base): Rename from tui_source_window.
4715         (~tui_source_window_base): Rename from ~tui_source_window.
4716         (tui_alloc_win_info): Create a tui_disasm_window.
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-data.h (struct tui_source_window)
4721         (struct tui_data_window): Declare destructors.
4722         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4723         destructors.
4724         (tui_win_info): Simplify.
4725
4726 2019-06-25  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-winsource.c (tui_display_main)
4729         (tui_update_source_windows_with_addr)
4730         (tui_update_all_breakpoint_info): Update.
4731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4732         (new_height_ok, parse_scrolling_args): Update.
4733         * tui/tui-stack.c (tui_show_frame_info): Update.
4734         * tui/tui-data.h (struct tui_list): Remove.
4735         (tui_source_windows): Return a reference to a std::vector.
4736         * tui/tui-data.c (source_windows): Now a std::vector.
4737         (tui_source_windows): Change return type.
4738         (tui_clear_source_windows): Rewrite.
4739         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4740         (tui_free_all_source_wins_content): Rewrite.
4741
4742 2019-06-25  Tom Tromey  <tom@tromey.com>
4743
4744         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4745         (struct tui_data_window, struct tui_cmd_window): Declare
4746         clear_detail method.
4747         * tui/tui-data.c (tui_source_window::clear_detail)
4748         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4749         methods.
4750         (tui_clear_win_detail): Simplify.
4751
4752 2019-06-25  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-layout.c (make_source_window, make_disasm_window)
4755         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4756         Return the new window.
4757         (show_source_disasm_command, show_data)
4758         (show_source_or_disasm_and_command): Update.
4759
4760 2019-06-25  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4763         parameter.  Return the new window.
4764         (show_source_disasm_command): Update and remove NULL check.
4765         (show_source_or_disasm_and_command): Update.
4766
4767 2019-06-25  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-data.h (struct tui_win_info): Make constructor
4774         protected.  Make destructor virtual.  Add initializers.
4775         (tui_source_window, tui_data_window, tui_cmd_window): New
4776         classes.
4777         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4778         constructor.  Add "type" parameter.
4779         (tui_source_window, tui_data_window, tui_cmd_window): New
4780         constructors.
4781         (tui_alloc_win_info): Instantiate the appropriate subclass.
4782
4783 2019-06-25  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-win.c (tui_resize_all): Use delete.
4786         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4787         destructor.
4788         (tui_free_window): Don't declare.
4789         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4790         Update.
4791
4792 2019-06-25  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-data.h (struct tui_win_info): Add constructor.
4795         * tui/tui-data.c (tui_alloc_win_info): Use new.
4796         (tui_free_window): Use delete.
4797
4798 2019-06-22  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4801         declare.
4802         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4803
4804 2019-06-22  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4807         declare.
4808         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4809
4810 2019-06-22  Tom de Vries  <tdevries@suse.de>
4811
4812         * dwarf2read.c (create_addrmap_from_aranges)
4813         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4814         instead of '%zu'.
4815
4816 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4817
4818         * dwarf2read.h (dwarf2_section_info_def): Remove.
4819         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4820         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4821         std::vector<dwarf2_section_info>.
4822         (struct dwo_file) <~dwo_file>: Remove.
4823         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4824         types field.
4825         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4826         (dwarf2_read_debug_names): Likewise.
4827         (create_debug_types_hash_table): Change parameter type to
4828         array_view, adjust code accordingly.
4829         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4830         (partial_die_info::fixup): Likewise.
4831         (determine_prefix): Likewise.
4832         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4833
4834 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4835
4836         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4837         gdb_bfd_ref_ptr.
4838         <~dwo_file>: Remove call to gdb_bfd_unref.
4839         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4840         gdb_bfd_ref_ptr::get.
4841
4842 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4843
4844         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4845         type to htab_up.
4846         * dwarf2read.c (struct dwo_file): Initialize fields.
4847         <~dwo_file>: New.
4848         (free_dwo_file): Remove, move content to ~dwo_file.
4849         (struct dwo_file_deleter): Remove.
4850         (dwo_file_up>: Remove custom deleter.
4851         (free_dwo_files): Remove.
4852         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4853         dwo_files.
4854         (process_skeletonless_type_units): Call unique_ptr::get.
4855         (allocate_dwo_file_hash_table): Add deleter to created hash
4856         table.  Change return type to htab_up.
4857         (lookup_dwo_file_slot): Don't memset dwo_file, call
4858         unique_ptr::get.
4859         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4860         (create_dwo_unit_in_dwp_v2): Likewise.
4861         (open_and_init_dwo_file): Likewise.
4862         (free_dwo_file_from_slot): Remove.
4863
4864 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4865
4866         * dwarf2read.h (struct dwarf2_section_info) <readin,
4867         is_virtual>: Change type to bool.
4868         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4869         true instead of 1.
4870
4871 2019-06-19  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-data.h (tui_init_content_element): Don't declare.
4874
4875 2019-06-19  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-data.h (tui_init_win_info): Don't declare.
4878
4879 2019-06-19  Tom de Vries  <tdevries@suse.de>
4880
4881         * dwarf2read.h (abstract_to_concrete): Change type to
4882         std::unordered_map<sect_offset, std::vector<sect_offset>,
4883         gdb::hash_enum<sect_offset>>.
4884
4885 2019-06-19  Tom Tromey  <tromey@adacore.com>
4886
4887         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4888         EVAL_AVOID_SIDE_EFFECTS specially.
4889
4890 2019-06-19  Tom Tromey  <tromey@adacore.com>
4891
4892         * source-cache.c (highlighter): New global.
4893         (source_cache::get_source_lines): Create a highlighter on demand.
4894
4895 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * defs.h (deprecated_interactive_hook): Delete declaration.
4898         * interps.c (clear_interpreter_hooks): Remove use of
4899         deprecated_interactive_hook.
4900         * top.c (deprecated_interactive_hook): Delete definition.
4901         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4902
4903 2019-06-18  Tom de Vries  <tdevries@suse.de>
4904
4905         PR gdb/24515
4906         * dwarf2read.h (abstract_to_concrete): Change type from
4907         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4908         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4909         * dwarf2read.c (read_variable): Update.
4910         (dwarf2_fetch_die_loc_sect_off): Update.
4911
4912 2019-06-17  Tom de Vries  <tdevries@suse.de>
4913
4914         PR gdb/24617
4915         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4916         accessing parent[parent_len - 1].
4917
4918 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4919
4920         PR gdb/24364
4921         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4922         call dtrace_process_dof with NULL dof.
4923
4924 2019-06-16  Tom de Vries  <tdevries@suse.de>
4925
4926         PR gdb/24445
4927         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4928
4929 2019-06-16  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4932         (make_all_visible): Use address of member.
4933
4934 2019-06-16  Tom Tromey  <tom@tromey.com>
4935
4936         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4937         (tui_free_window, free_content, free_content_elements): Remove
4938         unnecessary cast.
4939         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4940         cast.
4941         * tui/tui-regs.c (tui_show_register_group)
4942         (tui_display_registers_from, tui_display_reg_element_at_line):
4943         Remove unnecessary cast.
4944
4945 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * linux-nat.c (normal_mask): Delete.
4948         (_initialize_linux_nat): Don't initialise normal_mask.
4949
4950 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4951
4952         PR gdb/24445
4953         * dwarf-index-write.h (write_psymtabs_to_index): Add
4954         dwz_basename parameter.
4955         * dwarf-index-write.c (write_gdbindex): Move file writing to
4956         write_gdbindex_1.  Change return type void.
4957         (assert_file_size): Move up, remove filename parameter.
4958         (write_gdbindex_1): New function.
4959         (write_debug_names): Change return type to void, call
4960         assert_file_size.
4961         (struct index_wip_file): New struct.
4962         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4963         file logic to index_wip_file.  Write index for dwz file if
4964         needed.
4965         (save_gdb_index_command): Pass basename of dwz file, if present.
4966         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4967         build-id of dwz file, if present.
4968         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4969         (dwarf2_get_dwz_file): Likewise.
4970         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4971         (dwarf2_get_dwz_file): Likewise.
4972
4973 2019-06-16  Tom Tromey  <tom@tromey.com>
4974
4975         * coffread.c (process_coff_symbol): Use xstrdup.
4976         * value.c (create_internalvar): Use xstrdup.
4977
4978 2019-06-16  Tom Tromey  <tom@tromey.com>
4979
4980         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4981         * breakpoint.c (stopin_command, stopat_command)
4982         (until_break_command, decode_location_default): Remove unnecessary
4983         cast.
4984         * utils.c (subset_compare): Remove unnecessary cast.
4985         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4986         cast.
4987         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4988         cast.
4989         * infcmd.c (path_command): Remove unnecessary cast.
4990         * coffread.c (decode_type): Remove unnecessary cast.
4991         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4992         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4993         * tui/tui-stack.c (tui_show_locator_content)
4994         (tui_show_frame_info): Remove unnecessary cast.
4995         * tui/tui-win.c (tui_scroll_forward_command)
4996         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4997         (parse_scrolling_args): Remove unnecessary cast.
4998         * tui/tui-data.c (init_win_info, tui_del_window)
4999         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5000         (free_content_elements): Remove unnecessary cast.
5001         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5002         unnecessary cast.
5003         * tui/tui-source.c (tui_set_source_content)
5004         (tui_vertical_source_scroll): Remove unnecessary cast.
5005         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5006         cast.
5007         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5008         * tui/tui-regs.c (tui_display_registers_from)
5009         (tui_display_register): Remove unnecessary cast.
5010         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5011         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5012         (make_visible): Remove unnecessary cast.
5013         * tui/tui-winsource.c (tui_erase_source_content)
5014         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5015         unnecessary cast.
5016         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5017         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5018         * stabsread.c (read_type, read_array_type, read_range_type):
5019         Remove unnecessary cast.
5020         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5021         (parse_symbol, parse_type, upgrade_type, parse_external)
5022         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5023         unnecessary cast.
5024         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5025
5026 2019-06-16  Tom Tromey  <tom@tromey.com>
5027
5028         * tui/tui-data.c (tui_alloc_generic_win_info)
5029         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5030         checks.
5031
5032 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5033             Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * f-typeprint.c (f_print_type): Don't return early for not
5036         associated or not allocated types.
5037         (f_type_print_varspec_suffix): Add print_rank parameter and print
5038         ranks of array types in case they dangling.
5039         (f_type_print_base): Add print_rank parameter.
5040
5041 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * NEWS: Mention new MI commands.
5044         * break-catch-throw.c (enum exception_event_kind): Move to
5045         breakpoint.h.
5046         (print_mention_exception_catchpoint): Output text as a single
5047         message.
5048         (catch_exception_command_1): Rename to...
5049         (catch_exception_event): ...this, make non-static, update header
5050         command, and change some parameter types.
5051         (catch_catch_command): Update for changes to
5052         catch_exception_command_1.
5053         (catch_throw_command): Likewise.
5054         (catch_rethrow_command): Likewise.
5055         * breakpoint.c (enum exception_event_kind): Delete.
5056         * breakpoint.h (enum exception_event_kind): Moved here from
5057         break-catch-throw.c.
5058         (catch_exception_event): Declare.
5059         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5060         (mi_cmd_catch_throw): New function.
5061         (mi_cmd_catch_rethrow): New function.
5062         (mi_cmd_catch_catch): New function.
5063         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5064         'catch-catch' entries.
5065         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5066         (mi_cmd_catch_rethrow): Declare.
5067         (mi_cmd_catch_catch): Declare.
5068
5069 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * annotate.c (annotate_source_line): Change return type to void,
5072         update implementation to match.
5073         * annotate.h (annotate_source_line): Change return type to void,
5074         update header comment.
5075         * stack.c (print_frame_info): Don't change what frame information
5076         is printed based on whether annotations are on or not.
5077
5078 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5081         (annotate_source): Make static.
5082         (annotate_source_line): Moved from source.c and renamed from
5083         identify_source_line.  Update the return type.
5084         * annotate.h (annotate_source): Delete declaration.
5085         (annotate_source_line): Declaration moved from source.h, and
5086         renamed from identify_source_line.  Return type updated.
5087         * source.c (identify_source_line): Moved to annotate.c and renamed
5088         to annotate_source_line.
5089         (info_line_command): Remove check of annotation_level.
5090         * source.h (identify_source_line): Move declaration to annotate.h
5091         and rename to annotate_source_line.
5092         * stack.c: Add 'annotate.h' include.
5093         (print_frame_info): Remove check of annotation_level before
5094         calling annotate_source_line.
5095
5096 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * source-cache.c (source_cache::get_plain_source_lines): Use
5099         open_source_file_with_line_charpos instead of just
5100         open_source_file, remove call to find_source_lines.
5101         (source_cache::get_source_lines): Likewise.
5102         * source.c (find_source_lines): Make static.
5103         (get_filename_and_charpos): Renamed into...
5104         (open_source_file_with_line_charpos): ..this along with changes to
5105         return a scoped_fd, and some other minor clean ups.
5106         (identify_source_line): Use open_source_file_with_line_charpos.
5107         (search_command_helper): Use open_source_file_with_line_charpos
5108         instead of just open_source_file, remove call to
5109         find_source_lines.
5110         * source.h (open_source_file_with_line_charpos): Declare new
5111         function.
5112         (find_source_lines): Delete declaration.
5113
5114 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * source.c (get_filename_and_charpos): Remove fullname
5117         parameter.
5118         (identify_source_line): Update call to get_filename_and_charpos.
5119
5120 2019-06-14  Tom Tromey  <tromey@adacore.com>
5121
5122         PR gdb/24502:
5123         * ui-style.h (skip_ansi_escape): Update comment.
5124         * ui-file.h (class no_terminal_escape_file): New class.
5125         * ui-file.c (no_terminal_escape_file::write)
5126         (no_terminal_escape_file::puts): New methods.
5127         * cli/cli-logging.c (handle_redirections): Use
5128         no_terminal_escape_file.
5129
5130 2019-06-14  Tom Tromey  <tromey@adacore.com>
5131
5132         * NEWS: Move convenience variable news above Python news.
5133
5134 2019-06-14  Tom Tromey  <tom@tromey.com>
5135
5136         * gnulib: Move directory to top-level.
5137         * configure.ac: Don't configure gnulib.
5138         * configure: Rebuild.
5139         * common/common-defs.h: Use new path to gnulib.
5140         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5141         (GNULIB_H): Remove.
5142         (INCGNU): Look in new gnulib location.
5143         (HFILES_NO_SRCDIR): Remove gnulib files.
5144         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5145         (generated_files): Remove GNULIB_H.
5146         ($(LIBGNU), all-lib): Remove targets.
5147         (distclean): Don't mention GNULIB_BUILDDIR.
5148         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5149
5150 2019-06-14  Tom Tromey  <tromey@adacore.com>
5151
5152         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5153         Warn if symbol file does not provide any symbols.
5154
5155 2019-06-14  Tom Tromey  <tromey@adacore.com>
5156
5157         * source.c (find_and_open_source): Respect basenames_may_differ.
5158
5159 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * annotate.c (annotate_breakpoints_invalid): Make use of
5162         scoped_restore_terminal_state.
5163         (annotate_frames_invalid): Likewise.
5164
5165 2019-06-14  Tom Tromey  <tromey@adacore.com>
5166
5167         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5168         allow assignment to an internalvar.
5169
5170 2019-06-14  Tom Tromey  <tromey@adacore.com>
5171
5172         * ada-lex.l: Allow "_" in attribute names.
5173
5174 2019-06-14  Tom Tromey  <tromey@adacore.com>
5175
5176         PR gdb/24653:
5177         * regcache.c (registers_changed): Don't call alloca.
5178         * top.c (execute_command): Don't call alloca.
5179
5180 2019-06-13  Pedro Alves  <palves@redhat.com>
5181
5182         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5183         'expression'.  When parsing an expression, error out if there's
5184         junk after "unlimited".
5185         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5186         (do_set_command): Adjust calls to is_unlimited_literal.
5187
5188 2019-06-13  Pedro Alves  <palves@redhat.com>
5189
5190         * compile/compile.c (make_compile_options_def_group): Add braces
5191         around array_view initializer.
5192         * thread.c (make_thread_apply_all_options_def_group)
5193         (make_thread_apply_all_options_def_group): Likewise.
5194
5195 2019-06-13  Pedro Alves  <palves@redhat.com>
5196
5197         * NEWS (New commands): Mention "maint test-options
5198         require-delimiter", "maint test-options unknown-is-error", "maint
5199         test-options unknown-is-operand" and "maint show
5200         test-options-completion-result".
5201         (New command options, command completion): New section.
5202         (Completion improvements): New section.
5203         Mention that you can abbreviate "unlimited".
5204
5205 2019-06-13  Pedro Alves  <palves@redhat.com>
5206
5207         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5208         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5209         * unittests/cli-utils-selftests.c (test_parse_flags)
5210         (test_parse_flags_qcs): Delete.
5211         (test_cli_utils): Don't call deleted functions.
5212
5213 2019-06-13  Pedro Alves  <palves@redhat.com>
5214
5215         * thread.c: Include "cli/cli-option.h".
5216         (tp_array_compar_ascending): Global.
5217         (tp_array_compar): Delete function.
5218         (tp_array_compar_ascending, tp_array_compar_descending): New
5219         functions.
5220         (ascending_option_def, qcs_flag_option_def)
5221         (thr_qcs_flags_option_defs)
5222         (make_thread_apply_all_options_def_group)
5223         (make_thread_apply_options_def_group): New.
5224         (thread_apply_all_command): Use gdb::option::process_options.
5225         (thread_apply_command_completer)
5226         (thread_apply_all_command_completer): New.
5227         (thread_apply_command): Use gdb::option::process_options.
5228         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5229         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5230         to generate help text of "thread apply".  Adjust "taas"'s help.
5231         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5232         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5233
5234 2019-06-13  Pedro Alves  <palves@redhat.com>
5235
5236         * thread.c (thread_apply_command): Check for invalid TID with
5237         isdigit instead of !isalpha.
5238
5239 2019-06-13  Pedro Alves  <palves@redhat.com>
5240
5241         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5242         (validate_flags_qcs): New.
5243         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5244         (validate_flags_qcs): Declare.
5245         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5246         (make_frame_apply_options_def_group): New.
5247         (frame_apply_command_count): Process options with
5248         gdb::option::process_options.
5249         (frame_apply_completer): New.
5250         (frame_apply_level_completer, frame_apply_all_completer)
5251         (frame_apply_completer): New.
5252         (_initialize_stack): Update help of "frame apply", "frame apply
5253         level", "frame apply all" and "faas" to mention supported options
5254         and install command completers.
5255         * stack.h (frame_apply_all_completer): Declare.
5256         * thread.c: Include "stack.h".
5257         (tfaas_command): Add "--".
5258         (_initialize_thread): Update help "tfaas" to mention supported
5259         options and install command completer.
5260
5261 2019-06-13  Pedro Alves  <palves@redhat.com>
5262
5263         * completer.c (complete_nested_command_line): New.
5264         (gdb_completion_word_break_characters_throw): Add assertion.
5265         * completer.h (complete_nested_command_line): Declare.
5266
5267 2019-06-13  Pedro Alves  <palves@redhat.com>
5268
5269         * stack.c (parse_backtrace_qualifiers): New.
5270         (backtrace_command): Use it.
5271         (backtrace_command_completer): Complete on qualifiers.
5272
5273 2019-06-13  Pedro Alves  <palves@redhat.com>
5274
5275         * frame.c: Include "cli/cli-option.h.
5276         (user_set_backtrace_options): New.
5277         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5278         Delete.
5279         (get_prev_frame): Adjust.
5280         (boolean_option_def, uinteger_option_def)
5281         (set_backtrace_option_defs): New.
5282         (_initialize_frame): Adjust and use
5283         gdb::option::add_setshow_cmds_for_options to install "set
5284         backtrace past-main" and "set backtrace past-entry".
5285         * frame.h: Include "cli/cli-option.h".
5286         (struct frame_print_options): Forward declare.
5287         (print_frame_arguments_all, print_frame_arguments_scalars)
5288         (print_frame_arguments_none): Declare.
5289         (print_entry_values): Delete declaration.
5290         (struct frame_print_options, user_frame_print_options): New.
5291         (struct set_backtrace_options): New.
5292         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5293         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5294         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5295         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5296         (list_args_or_locals): Add frame_print_options parameter.
5297         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5298         * python/py-framefilter.c (enumerate_args): Pass down
5299         USER_FRAME_PRINT_OPTIONS.
5300         * stack.c: Include "cli/cli-option.h".
5301         (print_frame_arguments_all, print_frame_arguments_scalars)
5302         (print_frame_arguments_none): Declare.
5303         (print_raw_frame_arguments, print_entry_values): Delete.
5304         (user_frame_print_options): New.
5305         (boolean_option_def, enum_option_def, frame_print_option_defs):
5306         New.
5307         (struct backtrace_cmd_options): New.
5308         (bt_flag_option_def): New.
5309         (backtrace_command_option_defs): New.
5310         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5311         (print_frame_arg, read_frame_arg, print_frame_args)
5312         (print_frame_info, print_frame): Add frame_print_options parameter
5313         and use it.
5314         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5315         (backtrace_command_1): Add frame_print_options and
5316         backtrace_cmd_options parameters and use them.
5317         (make_backtrace_options_def_group): New.
5318         (backtrace_command): Process command options with
5319         gdb::option::process_options.
5320         (backtrace_command_completer): New.
5321         (_initialize_stack): Extend "backtrace"'s help to mention
5322         supported options.  Install completer for "backtrace".
5323         Install some settings commands with add_setshow_cmds_for_options.
5324
5325 2019-06-13  Pedro Alves  <palves@redhat.com>
5326
5327         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5328         and that "set/show print raw frame-arguments" are now deprecated.
5329
5330         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5331         command.
5332         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5333         * stack.c (_initialize_stack): Install "set/show print
5334         raw-frame-arguments", and deprecate "set/show print raw
5335         frame-arguments".
5336         * valprint.c (_initialize_valprint): Deprecate "set/show print
5337         raw".
5338
5339 2019-06-13  Pedro Alves  <palves@redhat.com>
5340
5341         * compile/compile.c (struct compile_options): New.
5342         (compile_flag_option_def, compile_command_option_defs)
5343         (make_compile_options_def_group): New.
5344         (compile_file_command): Handle options with
5345         gdb::option::process_options.
5346         (compile_file_command_completer): New function.
5347         (compile_code_command): Handle options with
5348         gdb::option::process_options.
5349         (compile_code_command_completer): New function.
5350         (_initialize_compiler): Install completers for "compile code" and
5351         "compile file".  Mention available options in "compile code" and
5352         "compile code"'s help.
5353         * completer.c (advance_to_completion_word): New, factored out from
5354         ...
5355         (advance_to_expression_complete_word_point): ... this.
5356         (advance_to_filename_complete_word_point): New.
5357         * completer.h (advance_to_filename_complete_word_point): New
5358         declaration.
5359
5360 2019-06-13  Pedro Alves  <palves@redhat.com>
5361
5362         * compile/compile.c: Include "cli/cli-option.h".
5363         (compile_print_value): Scope data pointer is now a
5364         value_print_options pointer; adjust.
5365         (compile_print_command): Process options.  Scope data pointer is
5366         now a value_print_options pointer; adjust.
5367         (_initialize_compile): Update "compile print"'s help to include
5368         supported options.  Install a completer for "compile print".
5369         * cp-valprint.c (show_vtblprint, show_objectprint)
5370         (show_static_field_print): Delete.
5371         (_initialize_cp_valprint): Don't install "set print
5372         static-members", "set print vtbl", "set print object" here.
5373         * printcmd.c: Include "cli/cli-option.h" and
5374         "common/gdb_optional.h".
5375         (print_command_parse_format): Rework to fill in a
5376         value_print_options instead of a format_data.
5377         (print_value): Change parameter type from format_data pointer to
5378         value_print_options reference.  Adjust.
5379         (print_command_1): Process options.  Adjust to pass down a
5380         value_print_options.
5381         (print_command_completer): New.
5382         (_initialize_printcmd): Install print_command_completer as
5383         handle_brkchars completer for the "print" command.  Update
5384         "print"'s help to include supported options.
5385         * valprint.c: Include "cli/cli-option.h".
5386         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5387         here from cp-valprint.c.
5388         (boolean_option_def, uinteger_option_def)
5389         (value_print_option_defs, make_value_print_options_def_group):
5390         New.  Use gdb::option::add_setshow_cmds_for_options to install
5391         "set print elements", "set print null-stop", "set print repeats",
5392         "set print pretty", "set print union", "set print array", "set
5393         print address", "set print symbol", "set print array-indexes".
5394         * valprint.h: Include <string> and "cli/cli-option.h".
5395         (make_value_print_options_def_group): Declare.
5396         (print_value): Change parameter type from format_data pointer to
5397         value_print_options reference.
5398         (print_command_completer): Declare.
5399
5400 2019-06-13  Pedro Alves  <palves@redhat.com>
5401
5402         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5403         (COMMON_SFILES): Add maint-test-settings.c.
5404         * cli/cli-decode.c (boolean_enums): New global, factored out from
5405         ...
5406         (add_setshow_boolean_cmd): ... here.
5407         * cli/cli-decode.h (boolean_enums): Declare.
5408         * cli/cli-option.c: New file.
5409         * cli/cli-option.h: New file.
5410         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5411         factored out from ...
5412         (parse_cli_boolean_value(const char *)): ... this.
5413         (is_unlimited_literal): Change parameter type to pointer to
5414         pointer.  Adjust and advance ARG pointer.
5415         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5416         (parse_cli_var_enum): New, factored out from ...
5417         (do_set_command): ... this.  Adjust.
5418         * cli/cli-setshow.h (parse_cli_boolean_value)
5419         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5420         (parse_cli_var_enum): Declare.
5421         * cli/cli-utils.c: Include "cli/cli-option.h".
5422         (get_ulongest): New.
5423         * cli/cli-utils.h (get_ulongest): Declare.
5424         (check_for_argument): New overloads.
5425         * maint-test-options.c: New file.
5426
5427 2019-06-13  Pedro Alves  <palves@redhat.com>
5428
5429         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5430         parse a range if "-" is at the end of the string.
5431
5432 2019-06-13  Pedro Alves  <palves@redhat.com>
5433
5434         * cli/cli-setshow.c (parse_auto_binary_operation)
5435         (parse_cli_boolean_value): Don't allow "o".
5436
5437 2019-06-13  Pedro Alves  <palves@redhat.com>
5438
5439         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5440         * NEWS: Mention maint test-settings KIND.
5441         * maint-test-settings.c: New file.
5442
5443 2019-06-13  Pedro Alves  <palves@redhat.com>
5444
5445         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5446         completer.
5447         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5448         "set" completers.
5449
5450 2019-06-13  Pedro Alves  <palves@redhat.com>
5451
5452         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5453         after item.
5454
5455 2019-06-13  Pedro Alves  <palves@redhat.com>
5456
5457         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5458
5459 2019-06-13  Pedro Alves <palves@redhat.com>
5460
5461         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5462         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5463         call.
5464         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5465         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5466         calls.
5467         (check_for_argument): Skip spaces after argument.
5468
5469 2019-06-13  Pedro Alves  <palves@redhat.com>
5470
5471         * thread.c (thread_apply_command): Adjust TID parsing.
5472         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5473         detected before end of string.
5474         (tid_is_in_list): Error out if LIST is invalid.
5475
5476 2019-06-13  Pedro Alves  <palves@redhat.com>
5477
5478         * completer.c (complete_line_internal_1): Rewind completion word
5479         point.
5480         (completion_tracker::advance_custom_word_point_by): Change
5481         parameter type to int.
5482         * completer.h (completion_tracker::advance_custom_word_point_by):
5483         Likewise.
5484
5485 2019-06-13  Pedro Alves  <palves@redhat.com>
5486
5487         * completer.c (advance_to_completion_word): Handle delimiters.
5488
5489 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5490
5491         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5492
5493 2019-06-11  Tom Tromey  <tom@tromey.com>
5494
5495         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5496         (xmalloc_failed): Move to alloc.c.
5497         * alloc.c: New file.
5498         * Makefile.in (COMMON_SFILES): Add alloc.c.
5499
5500 2019-06-11  Tom Tromey  <tom@tromey.com>
5501
5502         * nat/linux-waitpid.c: Don't include server.h.
5503         (linux_debug): Remove.
5504         (my_waitpid): Update.
5505
5506 2019-06-11  Tom Tromey  <tromey@adacore.com>
5507
5508         * infcall.c (_initialize_infcall): Remove trailing newline from
5509         help.
5510         * user-regs.c (_initialize_user_regs): Remove trailing newline
5511         from help.
5512         * typeprint.c (_initialize_typeprint): Remove trailing newline
5513         from help.
5514         * reverse.c (_initialize_reverse): Remove trailing newlines from
5515         help.
5516         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5517         from help.
5518         * language.c (add_set_language_command): Remove trailing newline
5519         from help.
5520         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5521         help.
5522         * disasm.c (_initialize_disasm): Remove trailing newline from
5523         help.
5524         * top.c (init_main): Remove trailing newline from help.
5525         * interps.c (_initialize_interpreter): Remove trailing newline
5526         from help.
5527         * btrace.c (_initialize_btrace): Remove trailing newlines from
5528         help.
5529         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5530         from help.
5531         * python/python.c (_initialize_python): Remove trailing newline
5532         from help.
5533         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5534         help.
5535         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5536         from help.  Reformat some text.
5537         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5538         from help.
5539         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5540         newline from help.
5541
5542 2019-06-11  Tom Tromey  <tromey@adacore.com>
5543
5544         * darwin-nat.c (darwin_decode_exception_message)
5545         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5546
5547 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * valops.c (value_slice): Check for not allocated or not
5550         associated values.
5551
5552 2019-06-10  Tom de Vries  <tdevries@suse.de>
5553
5554         PR gdb/24618
5555         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5556         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5557         invalid.
5558
5559 2019-06-10  Tom de Vries  <tdevries@suse.de>
5560
5561         PR gdb/24611
5562         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5563         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5564
5565 2019-06-10  Tom de Vries  <tdevries@suse.de>
5566
5567         PR symtab/24545
5568         * symtab.c (struct demangled_name_entry): Add language field.
5569         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5570         static minimal symbol".  Set and use language field.
5571
5572 2019-06-10  Tom Tromey  <tromey@adacore.com>
5573
5574         * ada-lang.c (_initialize_ada_language): Update help text.
5575
5576 2019-06-10  Tom Tromey  <tromey@adacore.com>
5577
5578         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5579         with a newline.
5580         * guile/guile.c (handle_boot_error): Don't end warning with a
5581         newline.
5582         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5583         warning with a newline.
5584         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5585         newline.
5586         (s12z_frame_cache): Likewise.
5587         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5588         a newline.
5589         * solib-svr4.c (disable_probes_interface): Don't end warning with
5590         a newline.
5591         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5592         newline.
5593         * python/python.c (do_finish_initialization): Don't end warning
5594         with a newline.
5595
5596 2019-06-10  Tom Tromey  <tom@tromey.com>
5597
5598         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5599         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5600         gdbpy_enter.
5601
5602 2019-06-10  Tom Tromey  <tromey@adacore.com>
5603
5604         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5605         data.
5606         (elf_new_init): Don't call stabsread_new_init.
5607         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5608         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5609         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5610
5611 2019-06-10  Tom de Vries  <tdevries@suse.de>
5612
5613         PR symtab/16264
5614         PR symtab/24517
5615         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5616
5617 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5618
5619         * source.c (find_and_open_source): Also rewrite relative file
5620         names.
5621
5622 2019-04-26  Amos Bird  <amosbird@gmail.com>
5623
5624         * annotate.c (annotate_thread_exited): Add "thread-exited"
5625         annotation.
5626
5627 2019-06-06  Tom Tromey  <tromey@adacore.com>
5628
5629         * maint.h (class scoped_command_stats): Use
5630         DISABLE_COPY_AND_ASSIGN.
5631         <print_time>: New method.
5632         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5633         print_time.
5634         (scoped_command_stats::print_time): New method.
5635
5636 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5639         instructions of lengths 6 or 8 bytes.
5640
5641 2019-06-04  Pedro Alves  <palves@redhat.com>
5642
5643         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5644
5645         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5646         * breakpoint.c (condition_completer): Likewise.
5647         * cli/cli-dump.c (scan_expression): Likewise.
5648         * common/filestuff.c (mkdir_recursive): Likewise.
5649         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5650         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5651         (gdb_abspath): Likewise.
5652         * compile/compile-cplus-types.c
5653         (compile_cplus_instance::decl_name): Likewise.
5654         * completer.c (complete_explicit_location):
5655         (signal_completer, reg_or_group_completer_1): Likewise.
5656         * cp-support.c (cp_remove_params_if_any): Likewise.
5657         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5658         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5659         * infcmd.c (strip_bg_char): Likewise.
5660         * linespec.c (copy_token_string): Likewise.
5661         * mi/mi-main.c (output_cores): Likewise.
5662         * psymtab.c (psymtab_search_name):
5663         * symfile.c (test_set_ext_lang_command): Likewise.
5664         * target.c (target_fileio_read_stralloc): Likewise.
5665         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5666         * value.c (complete_internalvar): Likewise.
5667
5668 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5669
5670         Add objfile property to gdb.Type.
5671         * NEWS: Mention Python API addition.
5672         * python/py-type.c (typy_get_objfile): New method.
5673
5674 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5675
5676         * NEWS: Mention the new set|show style [title|highlight].
5677         Mention changes to "show style", "help" and "apropos".
5678
5679 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5680
5681         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5682         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5683         instead of print_help_for_command.
5684         (print_doc_of_command): New function.
5685         (help_list): Add 'apropos -v word' suggestion.
5686         (print_help_for_command): Style the command name using title style.
5687         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5688         (_initialize_cli_cmds): Describe -v in apropos_command help.
5689
5690 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5691
5692         * cli/cli-style.h (cli_style_option): Add name in constructor,
5693         add m_name class member, add constructor with intensity,
5694         add name class function.
5695         (cli_style_option::add_setshow_commands): Remove name argument.
5696         (highlight_style, title_style): New styles.
5697         * cli/cli-style.c (do_show): New function that shows a style
5698         characteristic styling the style name with itself.
5699         (set_style_name): New function.
5700         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5701         Update all callers according to the changes in cli/cli-style.h.
5702         * utils.h (fputs_highlighted): New function.
5703         * utils.c (fputs_highlighted): Likewise.
5704
5705 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5706
5707         * NEWS: Mention new pipe command and new convenience variables.
5708
5709 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5710
5711         * cli/cli-cmds.c (pipe_command): New function.
5712         (_initialize_cli_cmds): Call add_com for pipe_command.
5713         Define | as an alias for pipe.
5714         (exit_status_set_internal_vars): New function.
5715         (shell_escape): Call exit_status_set_internal_vars.
5716         cli/cli-decode.c (find_command_name_length): Recognize | as
5717         a single character command.
5718
5719 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5720
5721         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5722         top.c (execute_command_to_ui_file): New function, mostly a copy
5723         of execute_command_to_string.
5724         (execute_command_to_string): Implement by calling
5725         execute_command_to_ui_file.
5726
5727 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5728
5729         * top.h (saved_command_line): Remove declaration.
5730         * top.c (previous_saved_command_line, previous_repeat_arguments):
5731         New variables.
5732         (saved_command_line): Make static, define together with other
5733         'repeat variables'.
5734         (dont_repeat): Clear repeat_arguments.
5735         (repeat_previous, get_saved_command_line, save_command_line):
5736         New functions.
5737         (gdb_init): Initialize saved_command_line
5738         and previous_saved_command_line.
5739         * main.c (captured_main_1): Remove saved_command_line initialization.
5740         * event-top.c (handle_line_of_input): Update to use
5741         the new 'repeat' related functions instead of direct access to
5742         saved_command_line.
5743         * command.h (repeat_previous, get_saved_command_line,
5744         save_command_line): New declarations.
5745         (dont_repeat): Add comment.
5746
5747 2019-05-30  Tom Tromey  <tromey@adacore.com>
5748
5749         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5750         Fix comment.
5751         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5752
5753 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5754
5755         PR cli/24587
5756         * completer.c (complete): Initialize variable word.
5757
5758 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5759
5760         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5761         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5762         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5763         'body' is NULL to the outter 'if', protecting the '!is_define'
5764         situation as well.
5765
5766 2019-05-29  Tom Tromey  <tromey@adacore.com>
5767
5768         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5769         (dwarf_unknown): New function.
5770         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5771         (dwarf_type_encoding_name): Use dwarf_unknown.
5772
5773 2019-05-29  Tom Tromey  <tromey@adacore.com>
5774
5775         PR c++/20020:
5776         * cp-valprint.c (cp_print_value_fields): Call
5777         cp_print_static_field inside "try".
5778
5779 2019-05-29  Tom Tromey  <tromey@adacore.com>
5780
5781         * inflow.c (struct terminal_info): Add default operator=.
5782         * configure: Rebuild.
5783         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5784         -Wdeprecated-copy-dtor, -Wredundant-move.
5785
5786 2019-05-29  Tom Tromey  <tromey@adacore.com>
5787
5788         * NEWS: Add entry.
5789         * infcmd.c (print_return_value_1): Handle finish_print
5790         option.
5791         (show_print_finish): New function.
5792         (_initialize_infcmd): Add "set/show print finish" commands.
5793         * valprint.c (user_print_options): Initialize new member.
5794         * valprint.h (struct value_print_options) <finish_print>: New
5795         member.
5796
5797 2019-05-28  Tom Tromey  <tromey@adacore.com>
5798
5799         * ada-lang.c (ada_remove_Xbn_suffix)
5800         (find_old_style_renaming_symbol)
5801         (parse_old_style_renaming): Remove.
5802         (ada_find_renaming_symbol): Don't call
5803         find_old_style_renaming_symbol.
5804         (ada_is_renaming_symbol): Rename from
5805         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5806         bool.  Now static.
5807         (ada_read_var_value): Update and simplify.
5808         * ada-exp.y (write_var_or_type): Remove old code.
5809
5810 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5811
5812         * event-top.c: Remove include comment.
5813         * inflow.c (class scoped_ignore_sigttou): Move from here...
5814         * inflow.h (class scoped_ignore_sigttou): ...to here.
5815         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5816         * top.c:  Remove include comment.
5817
5818 2019-05-27  Tom Tromey  <tom@tromey.com>
5819
5820         * NEWS: Fix typo.
5821
5822 2019-05-22  Tom Tromey  <tromey@adacore.com>
5823
5824         * target.c (target_follow_exec): Constify parameter.
5825         * target-delegates.c: Rebuild.
5826         * remote.c (remote_target::follow_exec): Constify parameter.
5827         * infrun.c (follow_exec): Constify parameter.
5828         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5829         (target_follow_exec): Likewise.
5830
5831 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5832
5833         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5834         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5835
5836 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5837
5838         * NEWS: Add debugredirect and testsuite sections.
5839
5840 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5841
5842         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5843         target descriptions using exclusively floating point register name
5844         aliases.
5845
5846 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         PR gdb/18644:
5849         * f-lang.c (build_fortran_types): Handle the case where
5850         gdbarch_floatformat_for_type returns a nullptr.
5851
5852 2019-05-21  Tom de Vries  <tdevries@suse.de>
5853
5854         PR cli/24587
5855         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5856
5857 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         PR gdb/18644:
5860         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5861         16-byte floats.
5862         * i386-tdep.c (i386_floatformat_for_type): Use
5863         floatformats_ia64_quad for the 16-byte floating point component
5864         within a fortran 32-byte complex number.
5865
5866 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5869         delete default constructor.
5870         (find_partial_die): Update to return const struct.
5871         (partial_die_parent_scope): Move variable declaration into scope
5872         of its use and change its type to auto.
5873         (guess_partial_die_structure_name): Likewise.
5874         (partial_die_info::fixup): Likewise.
5875
5876 2019-05-17  Tom Tromey  <tromey@adacore.com>
5877
5878         * source.c (find_and_open_source): Remove cast.
5879
5880 2019-05-17  Tom Tromey  <tromey@adacore.com>
5881
5882         * annotate.c (annotate_source): Make "filename" const.
5883         * annotate.h (annotate_source): Use const.
5884
5885 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5886
5887         * disasm.c (set_disassembler_options): Send errors to stderr.
5888
5889 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5890
5891         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5892         (cli_interp_base::set_logging): Check debug_redirect.
5893         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5894         * cli/cli-logging.c (debug_redirect): Add static variable.
5895         (pop_output_files): Add default param.
5896         (handle_redirections): Print debug setting.
5897         (show_logging_command): Likewise.
5898         (_initialize_cli_logging): Add debugredirect command.
5899         * interps.c (current_interp_set_logging): Add debug_redirect
5900         parameter.
5901         * interps.h (set_logging): Add debug_redirect parameter.
5902         (current_interp_set_logging): Likewise.
5903         * mi/mi-common.h: Likewise.
5904         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5905
5906 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5907             Tom Tromey  <tromey@adacore.com>
5908
5909         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5910         directly.
5911         * cli/cli-interp.h (make_logging_output): Remove declaration.
5912         * cli/cli-logging.c (make_logging_output): Remove function.
5913         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5914         directly.
5915         * ui-file.c (tee_file::tee_file): Remove bools.
5916         (tee_file::~tee_file): Remove deletes.
5917         * ui-file.h (tee_file): Remove bools.
5918
5919 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5920
5921         * mi/mi-cmds.h (mi_cmd_complete): New function.
5922         * mi/mi-main.c (mi_cmd_complete): Likewise.
5923         * mi/mi-cmds.c: Define new MI command -complete.
5924         * NEWS: Mention new -complete command.
5925
5926 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5927
5928         * completer.h (complete): New function.
5929         * completer.c (complete): Likewise.
5930         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5931         function defined in completer.h.
5932
5933 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5934
5935         * MAINTAINERS (Write After Approval): Add myself.
5936
5937 2019-05-17  Tom de Vries  <tdevries@suse.de>
5938
5939         PR gdb/24094
5940         * dwarf2read.c (struct cu_partial_die_info): New struct.
5941         (find_partial_die): Return cu_partial_die_info.
5942         (partial_die_parent_scope, guess_partial_die_structure_name)
5943         (partial_die_info::fixup): Handle new return type of find_partial_die.
5944
5945 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5946
5947         PR breakpoints/24541
5948         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5949         "std::string", simplifying the algorithm.
5950
5951 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5952
5953         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5954         (stap_static_probe_ops::get_probes): Likewise.
5955
5956 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5957
5958         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5959         '-')" and "else if".
5960         (stap_parse_single_operand): Join checks for
5961         "gdbarch_stap_parse_special_token_p" and
5962         "gdbarch_stap_parse_special_token" in the same "if" statement.
5963         Invert check when verifying for operation on register
5964         displacement.
5965
5966 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5967
5968         * stap-probe.c (stap_get_opcode): Update comment.
5969         (stap_get_expected_argument_type): Likewise.
5970         (handle_stap_probe): Likewise.
5971
5972 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5973
5974         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5975         return type to 'bool'.  Adjust comment.  Use 'bool' when
5976         appropriate.
5977         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5978         * stap-probe.c (stap_parse_argument_1): Likewise.
5979         (stap_is_operator): Likewise.
5980         (stap_is_generic_prefix): Likewise.
5981         (stap_is_register_prefix): Likewise.
5982         (stap_is_register_indirection_prefix): Likewise.
5983         (stap_is_integer_prefix): Likewise.
5984         (stap_generic_check_suffix): Likewise.
5985         (stap_check_integer_suffix): Likewise.
5986         (stap_check_register_suffix): Likewise.
5987         (stap_check_register_indirection_suffix): Likewise.
5988         (stap_parse_register_operand): Likewise.
5989         (stap_parse_single_operand): Likewise.
5990         (stap_parse_argument_1): Likewise.
5991         (stap_probe::get_argument_count): Likewise.
5992         (stap_is_operator): Likewise.
5993
5994 2019-05-16  Tom Tromey  <tromey@adacore.com>
5995
5996         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5997         keyword to foreach.
5998
5999 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6000
6001         * linux-thread-db.c (try_thread_db_load_1): Change return type
6002         to bool.
6003         (try_thread_db_load): Likewise.
6004         (try_thread_db_load_from_pdir_1): Likewise.
6005         (try_thread_db_load_from_pdir): Likewise.
6006         (try_thread_db_load_from_sdir): Likewise.
6007         (try_thread_db_load_from_dir): Likewise.
6008         (thread_db_load_search): Likewise.
6009         (has_libpthread): Likewise.
6010         (thread_db_load): Likewise.
6011
6012 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6013
6014         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6015         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6016         NULL, and complain/return if that's the case.
6017
6018 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6019
6020         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6021         (advance, posn, abstract_read_memory): New functions.
6022         [struct mem_read_abstraction]: New struct.
6023         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6024
6025 2019-05-14  Tom Tromey  <tromey@adacore.com>
6026
6027         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6028         value is not lval_memory.
6029
6030 2019-05-14  Tom Tromey  <tromey@adacore.com>
6031
6032         * solib.c (info_sharedlibrary_command): Style the file name.
6033
6034 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6035
6036         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6037         (aarch64_vnv_type): Likewise.
6038         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6039         * common/tdesc.c: Likewise.
6040         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6041         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6042         * features/aarch64-fpu.xml: Add ieee half view.
6043         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6044         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6045         * gdbtypes.h (struct builtin_type): Likewise.
6046         (struct objfile_type): Likewise.
6047
6048 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6049
6050         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6051         typo.
6052         * location.h (string_to_event_location): Likewise.
6053
6054 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6055
6056         GDB 8.3 released.
6057
6058 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6059
6060         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6061         New variable declaration.
6062         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6063         New variable.
6064         (print_one_breakpoint): Use ui_out::test_flags and new global
6065         variable to compute use_fixed_output.
6066         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6067         Remove.
6068         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6069         (mi_multi_location_breakpoint_output_fixed): Remove.
6070         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6071         new variable.
6072         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6073         fix_multi_location_breakpoint_output flag if version >= 3.
6074         * ui-out.h (enum ui_out_flag)
6075         <fix_multi_location_breakpoint_output>: New enumerator.
6076
6077 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6078
6079         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6080
6081 2019-05-10  Tom Tromey  <tromey@adacore.com>
6082
6083         * ada-lang.c (catch_ada_completer): New function.
6084         (_initialize_ada_language): Use it.
6085
6086 2019-05-10  Tom Tromey  <tromey@adacore.com>
6087
6088         * thread.c (print_thread_info): Make "requested_threads" const.
6089         * gdbthread.h (print_thread_info): Make "requested_threads"
6090         const.
6091         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6092         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6093
6094 2019-05-08  Tom Tromey  <tom@tromey.com>
6095
6096         * gdbtypes.c (objfile_type_data): Change type.
6097         (objfile_type, _initialize_gdbtypes): Update.
6098
6099 2019-05-08  Tom Tromey  <tom@tromey.com>
6100
6101         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6102         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6103         (_initialize_dwarf2_frame): Update.
6104
6105 2019-05-08  Tom Tromey  <tom@tromey.com>
6106
6107         * objc-lang.c (objc_objfile_data): Change type.
6108         (find_methods): Update.
6109         (_initialize_objc_lang): Remove.
6110
6111 2019-05-08  Tom Tromey  <tom@tromey.com>
6112
6113         * stabsread.c (rs6000_builtin_type_data): Change type.
6114         (rs6000_builtin_type, _initialize_stabsread): Update.
6115
6116 2019-05-08  Tom Tromey  <tom@tromey.com>
6117
6118         * mips-tdep.c (mips_pdr_data): Remove.
6119         (_initialize_mips_tdep): Update.
6120
6121 2019-05-08  Tom Tromey  <tom@tromey.com>
6122
6123         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6124         (hppa_init_objfile_priv_data, read_unwind_info)
6125         (find_unwind_entry, _initialize_hppa_tdep): Update.
6126
6127 2019-05-08  Tom Tromey  <tom@tromey.com>
6128
6129         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6130         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6131         on obstack.
6132         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6133
6134 2019-05-08  Tom Tromey  <tom@tromey.com>
6135
6136         * mdebugread.c (basic_type_data): Change type.
6137         (basic_type, _initialize_mdebugread): Update.
6138
6139 2019-05-08  Tom Tromey  <tom@tromey.com>
6140
6141         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6142
6143 2019-05-08  Tom Tromey  <tom@tromey.com>
6144
6145         * nto-tdep.c (nto_inferior_data_reg): Change type.
6146         (nto_inferior_data): Update.
6147         (nto_inferior_data_cleanup, nto_new_inferior_data)
6148         (_initialize_nto_tdep): Remove.
6149         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6150
6151 2019-05-08  Tom Tromey  <tom@tromey.com>
6152
6153         * ada-lang.c (struct ada_inferior_data): Add initializers.
6154         (ada_inferior_data): Change type.
6155         (ada_inferior_data_cleanup): Remove.
6156         (get_ada_inferior_data, ada_inferior_exit)
6157         (struct ada_pspace_data): Add initializers, destructor.
6158         (ada_pspace_data_handle): Change type.
6159         (get_ada_pspace_data): Update.
6160         (ada_pspace_data_cleanup): Remove.
6161
6162 2019-05-08  Tom Tromey  <tom@tromey.com>
6163
6164         * coffread.c (struct coff_symfile_info): Add initializers.
6165         (coff_objfile_data_key): Move lower.  Change type.
6166         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6167         Update.
6168         (coff_free_info): Remove.
6169
6170 2019-05-08  Tom Tromey  <tom@tromey.com>
6171
6172         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6173         (fbsd_pspace_data_handle): Move lower.  Change type.
6174         (get_fbsd_pspace_data): Update.
6175         (fbsd_pspace_data_cleanup): Remove.
6176         (_initialize_fbsd_tdep): Update.
6177
6178 2019-05-08  Tom Tromey  <tom@tromey.com>
6179
6180         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6181         (get_ada_tasks_pspace_data): Update.
6182         (ada_tasks_pspace_data_cleanup): Remove.
6183         (_initialize_tasks): Update.
6184         (ada_tasks_inferior_data_handle): Change type.
6185         (get_ada_tasks_inferior_data): Update.
6186         (ada_tasks_inferior_data_cleanup): Remove.
6187         (struct ada_tasks_pspace_data): Add initializers.
6188
6189 2019-05-08  Tom Tromey  <tom@tromey.com>
6190
6191         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6192         * symfile-debug.c (debug_sym_get_probes): Change type.
6193         * stap-probe.c (handle_stap_probe):
6194         (stap_static_probe_ops::get_probes): Change type.
6195         * probe.h (class static_probe_ops) <get_probes>: Change type.
6196         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6197         (parse_probes_in_pspace): Update.
6198         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6199         Update.
6200         (any_static_probe_ops::get_probes): Change type.
6201         * elfread.c (elfread_data): New typedef.
6202         (probe_key): Change type.
6203         (elf_get_probes): Likewise.  Update.
6204         (probe_key_free): Remove.
6205         (_initialize_elfread): Update.
6206         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6207         Change type.
6208         (dtrace_process_dof_probe, dtrace_process_dof)
6209         (dtrace_static_probe_ops::get_probe): Change type.
6210
6211 2019-05-08  Tom Tromey  <tom@tromey.com>
6212
6213         * xcoffread.c (struct xcoff_symfile_info): Rename from
6214         coff_symfile_info.  Add initializers.
6215         (xcoff_objfile_data_key): Move lower.  Change type.
6216         (XCOFF_DATA): Rewrite.
6217         (xcoff_free_info): Remove.
6218         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6219         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6220         (xcoff_initial_scan): Update.
6221
6222 2019-05-08  Tom Tromey  <tom@tromey.com>
6223
6224         * solib-svr4.c (struct svr4_info): Add initializers and
6225         destructor.
6226         <probes_table>: Now an htab_up.
6227         (solib_svr4_pspace_data): Change type.
6228         (free_probes_table): Simplify.
6229         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6230         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6231         (probes_table_remove_objfile_probes, register_solib_event_probe)
6232         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6233         (_initialize_svr4_solib): Update.
6234
6235 2019-05-08  Tom Tromey  <tom@tromey.com>
6236
6237         * remote.c (remote_pspace_data): Change type.
6238         (remote_pspace_data_cleanup): Remove.
6239         (get_remote_exec_file, set_pspace_remote_exec_file)
6240         (_initialize_remote): Update.
6241
6242 2019-05-08  Tom Tromey  <tom@tromey.com>
6243
6244         * breakpoint.c (breakpoint_objfile_key): Change type.
6245         (get_breakpoint_objfile_data): Update.
6246         (free_breakpoint_objfile_data): Remove.
6247         (_initialize_breakpoint): Update.
6248
6249 2019-05-08  Tom Tromey  <tom@tromey.com>
6250
6251         * linux-tdep.c (struct linux_info): Add initializers.
6252         (linux_inferior_data): Move.  Change type.
6253         (invalidate_linux_cache_inf): Update.
6254         (linux_inferior_data_cleanup): Remove.
6255         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6256
6257 2019-05-08  Tom Tromey  <tom@tromey.com>
6258
6259         * auxv.c (auxv_inferior_data): Move.  Change type.
6260         (auxv_inferior_data_cleanup): Remove.
6261         (invalidate_auxv_cache_inf): Rewrite.
6262         (get_auxv_inferior_data, _initialize_auxv): Update.
6263
6264 2019-05-08  Tom Tromey  <tom@tromey.com>
6265
6266         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6267         (symfile_debug_objfile_data_key): Change type.
6268         (symfile_debug_installed, debug_qf_has_symbols)
6269         (debug_qf_find_last_source_symtab)
6270         (debug_qf_forget_cached_source_info)
6271         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6272         (debug_qf_print_stats, debug_qf_dump)
6273         (debug_qf_expand_symtabs_for_function)
6274         (debug_qf_expand_all_symtabs)
6275         (debug_qf_expand_symtabs_with_fullname)
6276         (debug_qf_map_matching_symbols)
6277         (debug_qf_expand_symtabs_matching)
6278         (debug_qf_find_pc_sect_compunit_symtab)
6279         (debug_qf_map_symbol_filenames)
6280         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6281         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6282         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6283         (debug_sym_read_linetable, debug_sym_relocate): Update.
6284         (symfile_debug_free_objfile): Remove.
6285         (install_symfile_debug_logging, _initialize_symfile_debug):
6286         Update.
6287
6288 2019-05-08  Tom Tromey  <tom@tromey.com>
6289
6290         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6291         allocate_on_obstack.
6292         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6293         (get_dwarf2_per_objfile): Update.
6294         (set_dwarf2_per_objfile): Remove.
6295         (dwarf2_has_info, dwarf2_get_section_info): Update.
6296         (dwarf2_free_objfile): Remove.
6297         (_initialize_dwarf2_read): Update.
6298
6299 2019-05-08  Tom Tromey  <tom@tromey.com>
6300
6301         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6302         initializers.
6303         <unsupported_script_warning_printed,
6304         script_not_found_warning_printed>: Now bool.
6305         (auto_load_pspace_data): Change type.
6306         (~auto_load_pspace_info): Rename from
6307         auto_load_pspace_data_cleanup.
6308         (get_auto_load_pspace_data, init_loaded_scripts_info)
6309         (clear_section_scripts, maybe_print_unsupported_script_warning)
6310         (maybe_print_script_not_found_warning, _initialize_auto_load):
6311         Update.
6312
6313 2019-05-08  Tom Tromey  <tom@tromey.com>
6314
6315         * objfiles.c (objfile_pspace_info): Add destructor and
6316         initializers.
6317         (objfiles_pspace_data): Change type.
6318         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6319         (get_objfile_pspace_data): Update.
6320         (objfiles_bfd_data): Change type.
6321         (get_objfile_bfd_data): Update.
6322         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6323
6324 2019-05-08  Tom Tromey  <tom@tromey.com>
6325
6326         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6327         Change type.
6328         (get_catch_syscall_inferior_data): Update.
6329         (catch_syscall_inferior_data_cleanup): Remove.
6330         (_initialize_break_catch_syscall): Update.
6331
6332 2019-05-08  Tom Tromey  <tom@tromey.com>
6333
6334         * inflow.c (struct terminal_info): Add destructor and
6335         initializers.
6336         (inflow_inferior_data): Change type.
6337         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6338         (get_inflow_inferior_data, inflow_inferior_exit)
6339         (swap_terminal_info, _initialize_inflow): Update.
6340
6341 2019-05-08  Tom Tromey  <tom@tromey.com>
6342
6343         * target-dcache.c (target_dcache_cleanup): Remove.
6344         (target_dcache_aspace_key): Change type.
6345         (target_dcache_init_p, target_dcache_invalidate)
6346         (target_dcache_get, target_dcache_get_or_init)
6347         (_initialize_target_dcache): Update.
6348         * dcache.h (struct dcache_deleter): New.
6349
6350 2019-05-08  Tom Tromey  <tom@tromey.com>
6351
6352         * symtab.c (struct symbol_cache): Add destructor and
6353         initializers.
6354         (symbol_cache_key): Move.  Change type.
6355         (make_symbol_cache, free_symbol_cache): Remove.
6356         (get_symbol_cache): Update.
6357         (symbol_cache_cleanup): Remove.
6358         (ALL_PSPACES, symbol_cache_flush)
6359         (maintenance_print_symbol_cache)
6360         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6361         Update.
6362
6363 2019-05-08  Tom Tromey  <tom@tromey.com>
6364
6365         * symtab.c (struct main_info): Add destructor and initializers.
6366         (main_progspace_key): Move.  Change type.
6367         (get_main_info): Update.
6368         (main_info_cleanup): Remove.
6369         (_initialize_symtab): Update.
6370
6371 2019-05-08  Tom Tromey  <tom@tromey.com>
6372
6373         * registry.h (DECLARE_REGISTRY): Define the _key class.
6374
6375 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * NEWS: Merge two 'New commands' sections.
6378
6379 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6380
6381         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6382         parameter and use Ada language definition instead.
6383         (ada_val_print_ptr): Remove unused language parameter.
6384         (ada_val_print_num): Remove language parameter and use Ada language
6385         definition instead.
6386         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6387         parameter.
6388         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6389         parameter and use Ada language definition instead.
6390         (ada_val_print_1): Update all ada_val_print_xxx calls.
6391         Remove language parameter.
6392         (ada_val_print): Update ada_val_print_1 call.
6393
6394 2019-05-08  Tom Tromey  <tromey@adacore.com>
6395
6396         * remote.c (remote_hw_watchpoint_limit)
6397         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6398         Now static.
6399
6400 2019-05-08  Tom Tromey  <tromey@adacore.com>
6401
6402         * maint.c (_initialize_maint_cmds): Move initialization code to
6403         remote.c.
6404         (watchdog, show_watchdog): Move to remote.c.
6405         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6406         "watchdog" static.
6407         (_initialize_remote): Move initialization code from maint.c.
6408         * defs.h (watchdog): Don't declare.
6409
6410 2019-05-08  Tom Tromey  <tromey@adacore.com>
6411
6412         * tui/tui-interp.c: Include main.h.
6413         * interps.c: Include main.h.
6414         * main.h (interpreter_p): Declare.
6415         * defs.h (interpreter_p): Don't declare.
6416
6417 2019-05-08  Tom Tromey  <tromey@adacore.com>
6418
6419         * dwarf2loc.c: Include dwarf2read.h.
6420         * defs.h (read_unsigned_leb128): Don't declare.
6421         * dwarf2read.h (read_unsigned_leb128): Declare.
6422
6423 2019-05-08  Tom Tromey  <tromey@adacore.com>
6424
6425         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6426         method.
6427
6428 2019-05-08  Tom Tromey  <tromey@adacore.com>
6429
6430         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6431         when no wrap column is set.
6432
6433 2019-05-08  Tom Tromey  <tromey@adacore.com>
6434
6435         * c-lang.c (c_get_string): Handle non-C-style arrays.
6436
6437 2019-05-08  Tom Tromey  <tromey@adacore.com>
6438
6439         * typeprint.c (print_offset_data::update): Print the bit offset,
6440         not the number of bits remaining.
6441
6442 2019-05-08  Tom Tromey  <tromey@adacore.com>
6443
6444         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6445         padding at end of comment.
6446
6447 2019-05-08  Tom Tromey  <tromey@adacore.com>
6448
6449         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6450         Compare main types.
6451
6452 2019-05-06  Tom Tromey  <tom@tromey.com>
6453
6454         * common/scoped_mmap.c: Include common-defs.h.
6455         * common/scoped_mmap.h: Don't include config.h.
6456
6457 2019-05-04  Tom Tromey  <tom@tromey.com>
6458
6459         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6460         (struct aarch64_call_info): Add initializers.
6461         <si>: Now a std::vector.
6462         (pass_on_stack, aarch64_push_dummy_call): Update.
6463
6464 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6465             Tom Tromey  <tom@tromey.com>
6466
6467         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6468         (ppc_threads): Now a std::vector.  Now static.
6469         (hwdebug_find_thread_points_by_tid)
6470         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6471         Update.
6472
6473 2019-05-04  Tom Tromey  <tom@tromey.com>
6474
6475         * arc-tdep.c (arc_tdesc_init): Return bool.
6476
6477 2019-05-04  Tom Tromey  <tom@tromey.com>
6478
6479         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6480         Use gdb_assert_not_reached.
6481
6482 2019-05-04  Tom Tromey  <tom@tromey.com>
6483
6484         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6485         "false".
6486
6487 2019-05-04  Tom Tromey  <tom@tromey.com>
6488
6489         * arc-tdep.c (arc_tdesc_init): Use bool.
6490
6491 2019-05-04  Tom Tromey  <tom@tromey.com>
6492
6493         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6494
6495 2019-05-04  Tom Tromey  <tom@tromey.com>
6496
6497         * cli/cli-cmds.c (valid_command_p): Return bool.
6498
6499 2019-05-04  Tom Tromey  <tom@tromey.com>
6500
6501         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6502         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6503
6504 2019-05-04  Raul Tambre  <raul@tambre.ee>
6505
6506         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6507         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6508         operator for comparison.
6509
6510 2019-05-04  Tom Tromey  <tom@tromey.com>
6511
6512         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6513         (lookup_partial_symbol, print_partial_symbols)
6514         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6515         (psymbol_compare): Update.
6516         (add_psymbol_to_bcache): Clear the entire psymbol.
6517         (maintenance_check_psymtabs): Update.
6518         * psympriv.h (struct partial_symbol): Don't derive from
6519         general_symbol_info.
6520         <obj_section, unrelocated_address, address,
6521         set_unrelocated_address>: Update.
6522         <ginfo>: New member.
6523         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6524         (debug_names::write_psymbols): Update.
6525
6526 2019-05-04  Tom de Vries  <tdevries@suse.de>
6527
6528         * contrib/cc-with-tweaks.sh: Support -n arg.
6529
6530 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6531
6532         * corelow.c (core_target::detach): Ensure frame cache and
6533         register caches are cleared.
6534         inferior.c (exit_inferior_1): Likewise.
6535
6536 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6537             Tom Tromey  <tom@tromey.com>
6538
6539         * dictionary.c (collate_pending_symbols_by_language): Remove
6540         "struct" from foreach.
6541         * symtab.c (lookup_global_symbol_from_objfile)
6542         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6543         foreach.
6544         * ser-tcp.c (net_open): Remove "struct" from foreach.
6545         * objfiles.c (objfile_relocate, objfile_rebase)
6546         (objfile_has_symbols): Remove "struct" from foreach.
6547         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6548         from foreach.
6549         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6550         foreach.
6551         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6552         "struct" from foreach.
6553         * ada-lang.c (create_excep_cond_exprs)
6554         (ada_exception_catchpoint_cond_string): Remove "struct" from
6555         foreach.
6556
6557 2019-05-03  Tom Tromey  <tromey@adacore.com>
6558
6559         * ada-exp.y (convert_char_literal): Check suffix of each
6560         enumerator.
6561
6562 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6563
6564         PR ada/21406:
6565         * ada-exp.y (yywrap): Don't define.
6566         * ada-lex.l (%option): Add noyywrap
6567         (yywrap): Remove.
6568
6569 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6570
6571         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6572         _WIN32_WINNT to the XP level, unless already defined to a higher
6573         level.
6574
6575         * unittests/parse-connection-spec-selftests.c:
6576         * ser-tcp.c:
6577         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6578         override.
6579
6580         * symfile.c (find_separate_debug_file): Remove colon from the
6581         drive spec of DOS/Windows file names of the target, so that the
6582         file name produced from DEBUGDIR and the target's directory will
6583         be valid on DOS/Windows systems.
6584
6585 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * rust-lang.c (val_print_struct): Handle printing structures
6588         containing strings.
6589
6590 2019-05-02  Tom Tromey  <tromey@adacore.com>
6591
6592         * valarith.c (_initialize_valarith): Remove.
6593
6594 2019-05-01  Tom Tromey  <tromey@adacore.com>
6595
6596         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6597         bitfields.
6598
6599 2019-05-01  Tom Tromey  <tromey@adacore.com>
6600
6601         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6602         for big-endian copies.
6603
6604 2019-04-30  Ali Tamur  <tamur@google.com>
6605         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6606         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6607         (read_3_bytes): New function.
6608
6609 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6610
6611         * windows-nat.c (main_thread_id): Delete.
6612         (handle_output_debug_string): Replace main_thread_id by
6613         current_event.dwThreadId.
6614         (fake_create_process): Likewise.
6615         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6616         Do not set main_thread_id.
6617         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6618         current_event.dwThreadId.
6619         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6620
6621 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6622
6623         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6624         Use current_event.dwThreadId instead of main_thread_id.
6625
6626 2019-04-30  Tom Tromey  <tromey@adacore.com>
6627
6628         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6629         (create_excep_cond_exprs): Iterate over program spaces.
6630         (ada_exception_catchpoint_cond_string): Examine all minimal
6631         symbols for exception types.
6632
6633 2019-04-30  Tom Tromey  <tromey@adacore.com>
6634
6635         PR c++/24470:
6636         * dwarf2read.c (process_structure_scope): Handle case where type
6637         has template parameters but no symbol was created.
6638
6639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6640             Chris January  <chris.january@arm.com>
6641
6642         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6643         qualifier.
6644         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6645
6646 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6647
6648         * f-typeprint.c (f_print_type): Update rules for printing
6649         whitespace.
6650         (f_type_print_varspec_suffix): Likewise.
6651
6652 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6653             Chris January  <chris.january@arm.com>
6654
6655         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6656         function arguments.
6657
6658 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6659
6660         * f-lang.c (build_fortran_types): Change name of void type to
6661         lower case.
6662         * f-typeprint.c (f_type_print_base): Print the name of the void
6663         type, rather than a fixed string.
6664         * f-valprint.c (f_decorations): Use lower case void string.
6665
6666 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6667             Chris January  <chris.january@arm.com>
6668
6669         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6670         types for Fortran.
6671
6672 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6673             Chris January  <chris.january@arm.com>
6674             David Lecomber  <david.lecomber@arm.com>
6675
6676         * f-exp.y (BINOP_INTRINSIC): New token.
6677         (exp): New parser rule handling BINOP_INTRINSIC.
6678         (f77_keywords): Add new builtin procedures.
6679         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6680         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6681         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6682         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6683         (print_unop_subexp_f): New function.
6684         (print_binop_subexp_f): New function.
6685         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6686         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6687         (dump_subexp_body_f): Likewise.
6688         (operator_check_f): Likewise.
6689         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6690         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6691
6692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6693
6694         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6695         UNOP_KIND.
6696         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6697         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6698         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6699         (operator_length_f): New fuction.
6700         (print_subexp_f): New function.
6701         (op_name_f): New function.
6702         (dump_subexp_body_f): New function.
6703         (operator_check_f): New function.
6704         (exp_descriptor_f): Replace standard expression handling functions
6705         with new functions.
6706         * gdb/fortran-operator.def: New file.
6707         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6708         * gdb/std-operator.def: Remove UNOP_KIND.
6709
6710 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * std-operator.def: Remove unbalanced, stray double quote
6713         character.
6714
6715 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6716             Chris January  <chris.january@arm.com>
6717             Daniel Everett  <daniel.everett@arm.com>
6718             Nick Forrington  <nick.forrington@arm.com>
6719             Richard Bunt  <richard.bunt@arm.com>
6720
6721         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6722         of depth when printing anonymous structs or unions.
6723         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6724         Don't print either the top-level value, or the children if the
6725         max-depth is exceeded.
6726         (ppscm_print_children): When printing the key of a map, allow one
6727         extra level of depth.
6728         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6729         print either the top-level value, or the children if the max-depth
6730         is exceeded.
6731         (print_children): When printing the key of a map, allow one extra
6732         level of depth.
6733         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6734         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6735         (user_print_options): Initialise max_depth field.
6736         (val_print_scalar_or_string_type_p): New function.
6737         (val_print): Check to see if the max depth has been reached.
6738         (val_print_check_max_depth): Define new function.
6739         (show_print_max_depth): New function.
6740         (_initialize_valprint): Add 'print max-depth' option.
6741         * valprint.h (struct value_print_options) <max_depth>: New field.
6742         (val_print_check_max_depth): Declare new function.
6743         * NEWS: Document new feature.
6744
6745 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6746
6747         * ada-lang.c (ada_language_defn): Initialise new field.
6748         * c-lang.c (c_is_string_type_p): New function.
6749         (c_language_defn): Initialise new field.
6750         (cplus_language_defn): Initialise new field.
6751         (asm_language_defn): Initialise new field.
6752         (minimal_language_defn): Initialise new field.
6753         * c-lang.h (c_is_string_type_p): Declare new function.
6754         * d-lang.c (d_language_defn): Initialise new field.
6755         * f-lang.c (f_is_string_type_p): New function.
6756         (f_language_defn): Initialise new field.
6757         * go-lang.c (go_is_string_type_p): New function.
6758         (go_language_defn): Initialise new field.
6759         * language.c (default_is_string_type_p): New function.
6760         (unknown_language_defn): Initialise new field.
6761         (auto_language_defn): Initialise new field.
6762         * language.h (struct language_defn) <la_is_string_type_p>: New
6763         member variable.
6764         (default_is_string_type_p): Declare new function.
6765         * m2-lang.c (m2_language_defn): Initialise new field.
6766         * objc-lang.c (objc_language_defn): Initialise new field.
6767         * opencl-lang.c (opencl_language_defn): Initialise new field.
6768         * p-lang.c (pascal_is_string_type_p): New function.
6769         (pascal_language_defn): Initialise new field.
6770         * rust-lang.c (rust_is_string_type_p): New function.
6771         (rust_language_defn): Initialise new field.
6772
6773 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6776         New field.
6777         * ada-lang.c (ada_language_defn): Initialise new field.
6778         * c-lang.c (c_language_defn): Likewise.
6779         (cplus_language_defn): Likewise.
6780         (asm_language_defn): Likewise.
6781         (minimal_language_defn): Likewise.
6782         * d-lang.c (d_language_defn): Likewise.
6783         * f-lang.c (f_language_defn): Likewise.
6784         * go-lang.c (go_language_defn): Likewise.
6785         * language.c (unknown_language_defn): Likewise.
6786         (auto_language_defn): Likewise.
6787         * m2-lang.c (m2_language_defn): Likewise.
6788         * objc-lang.c (objc_language_defn): Likewise.
6789         * opencl-lang.c (opencl_language_defn): Likewise.
6790         * p-lang.c (pascal_language_defn): Likewise.
6791         * rust-lang.c (rust_language_defn): Likewise.
6792
6793 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * ada-lang.c (ada_is_character_type): Change return type to bool.
6796         (ada_is_string_type): Likewise.
6797         * ada-lang.h (ada_is_character_type): Update declaration
6798         (ada_is_string_type): Likewise.
6799
6800 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6801
6802         Support style in 'frame|thread apply'
6803
6804         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6805         * record.c (record_start, record_stop): Update callers of
6806         execute_command_to_string with false.
6807         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6808         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6809         methods.
6810         (class string_file): New constructor with term_out parameter.
6811         Override methods term_out and can_emit_style_escape.  New member
6812         term_out.
6813         (class stdio_file): Override can_emit_style_escape.
6814         (class tee_file): Override term_out and can_emit_style_escape.
6815         * utils.h (can_emit_style_escape): Remove.
6816         * utils.c (can_emit_style_escape): Likewise.
6817         Update all callers of can_emit_style_escape (SOMESTREAM) to
6818         SOMESTREAM->can_emit_style_escape.
6819         * source-cache.c (source_cache::get_source_lines): Likewise.
6820         * stack.c (frame_apply_command_count): Call execute_command_to_string
6821         passing the term_out characteristic of the current gdb_stdout.
6822         * thread.c (thr_try_catch_cmd): Likewise.
6823         * top.c (execute_command_to_string): pass term_out parameter
6824         to construct the string_file for the command output.
6825         * ui-file.c (term_cli_styling): New function (most code moved
6826         from utils.c can_emit_style_escape).
6827         (string_file::string_file, string_file::can_emit_style_escape,
6828         stdio_file::can_emit_style_escape, tee_file::term_out,
6829         tee_file::can_emit_style_escape): New functions.
6830
6831 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6832
6833         * NEWS: Mention the new set|show may-call-functions.
6834         * infcall.c (may_call_functions_p): New variable.
6835         (show_may_call_functions_p): New function.
6836         (call_function_by_hand_dummy): Throws an error if not
6837         may-call-functions.
6838         (_initialize_infcall): Call add_setshow_boolean_cmd for
6839         may-call-functions.
6840
6841 2019-04-25  Keith Seitz  <keiths@redhat.com>
6842
6843         PR c++/24367
6844         * cp-support.c (inspect_type): Don't attempt substitutions
6845         of symbol with the same name.
6846
6847 2019-04-25  Tom Tromey  <tromey@adacore.com>
6848
6849         PR gdb/24475:
6850         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6851         static.
6852
6853 2019-04-25  Tom Tromey  <tromey@adacore.com>
6854
6855         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6856         rvalue reference.
6857         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6858         (gdb_xml_parser::parse): Use std::move.
6859         * python/python-internal.h (gdbpy_convert_exception): Take a const
6860         reference.
6861         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6862         std::move.
6863         * python/py-utils.c (gdbpy_convert_exception): Take a const
6864         reference.
6865         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6866         Use std::move.
6867         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6868         Use std::move.
6869         * mi/mi-main.c (mi_print_exception): Take a const reference.
6870         * main.c (handle_command_errors): Take a const reference.
6871         * linespec.c (parse_linespec): Use std::move.
6872         * infcall.c (run_inferior_call): Use std::move.
6873         (call_function_by_hand_dummy): Use std::move.
6874         * exec.c (try_open_exec_file): Use std::move.
6875         * exceptions.h (exception_print, exception_fprintf)
6876         (exception_print_same): Update.
6877         * exceptions.c (print_exception, exception_print)
6878         (exception_fprintf, exception_print_same): Change parameters to
6879         const reference.
6880         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6881         * common/new-op.c: Use std::move.
6882         * common/common-exceptions.h (struct gdb_exception): Add move
6883         constructor.
6884         (struct gdb_exception_error, struct gdb_exception_quit, struct
6885         gdb_quit_bad_alloc): Change constructor to move constructor.
6886         (throw_exception): Change parameter to rvalue reference.
6887         * common/common-exceptions.c (throw_exception): Take rvalue
6888         reference.
6889         * cli/cli-interp.c (safe_execute_command): Use std::move.
6890         * breakpoint.c (insert_bp_location, location_to_sals): Use
6891         std::move.
6892
6893 2019-04-25  Tom Tromey  <tromey@adacore.com>
6894
6895         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6896         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6897         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6898         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6899         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6900         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6901         guile/scm-value.c: Use unpack.
6902         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6903         gdbscm_gdb_exception.
6904         (gdbscm_throw_gdb_exception): Likewise.
6905         (struct gdbscm_gdb_exception): New.
6906         (unpack): New function.
6907         (gdbscm_wrap): Use unpack.
6908
6909 2019-04-25  Tom Tromey  <tromey@adacore.com>
6910
6911         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6912         (gdb_rl_callback_handler): Use std::move.
6913         * common/common-exceptions.h (struct gdb_exception): Add move
6914         assignment operator.
6915         (throw_exception_sjlj): Change "exception" to const reference.
6916         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6917         (throw_exception_sjlj): Change "exception" to const reference.
6918
6919 2019-04-25  Tom Tromey  <tromey@adacore.com>
6920
6921         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6922         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6923         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6924         Update.
6925         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6926         Update.
6927         * mi/mi-interp.c (mi_interp::exec): Update.
6928         * linespec.c (parse_linespec): Update.
6929         * infcall.c (run_inferior_call): Update.
6930         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6931         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6932         (gdbscm_lookup_global_symbol): Update.
6933         * guile/scm-param.c (gdbscm_parameter_value): Update.
6934         * guile/scm-frame.c (gdbscm_frame_read_register)
6935         (gdbscm_frame_read_var): Update.
6936         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6937         * exec.c (try_open_exec_file): Update.
6938         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6939         (gdb_rl_callback_handler): Update.
6940         * common/common-exceptions.h (exception_none): Don't declare.
6941         * common/common-exceptions.c (exception_none): Don't define.
6942         (struct catcher) <exception>: Update.
6943         * cli/cli-interp.c (safe_execute_command): Update.
6944         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6945
6946 2019-04-25  Ali Tamur  <tamur@google.com>
6947
6948         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6949         (read_attribute_value): Likewise.
6950         (dwarf2_read_addr_index): Update comment.
6951         (read_str_index): Add DW_FORM_strx.
6952         (dwarf2_string_attr): Likewise.
6953         (dwarf2_const_value_attr): Likewise.
6954         (dump_die_shallow): Likewise.
6955         (dwarf2_fetch_constant_bytes): Likewise.
6956         (skip_form_bytes): Likewise.
6957         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6958
6959 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6960
6961         PR corefiles/11608
6962         PR corefiles/18187
6963         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6964         OFFSET.  Verify if current mapping contains an ELF header.
6965         (linux_find_memory_regions_full): Adjust call to
6966         dump_mapping_p.
6967
6968 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6969             Kang Li <kanglictf@gmail.com>
6970
6971         PR gdb/21600
6972
6973         * dwarf2-frame.c (read_initial_length): Be consistent about using
6974         unsigned representation of length.
6975         (decode_frame_entry_1): Likewise.  Check for wraparound of
6976         end pointer as well as buffer overflow.
6977
6978 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6979
6980         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6981         "vq".
6982
6983 2019-04-24  Tom Tromey  <tromey@adacore.com>
6984
6985         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6986
6987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6988
6989         * s12z-tdep.c (s12z_unwind_pc): Delete.
6990         (s12z_unwind_sp): Delete.
6991         (s12z_gdbarch_init): Don't register deleted functions with
6992         gdbarch.
6993
6994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6995
6996         * rl78-tdep.c (rl78_unwind_sp): Delete.
6997         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6998
6999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7002         (xstormy16_unwind_pc): Delete.
7003         (xstormy16_dummy_id): Delete.
7004         (xstormy16_gdbarch_init): Don't register deleted functions with
7005         gdbarch.
7006
7007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * vax-tdep.c (vax_unwind_pc): Delete.
7010         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7011
7012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * v850-tdep.c (v850_unwind_sp): Delete.
7015         (v850_unwind_pc): Delete.
7016         (v850_dummy_id): Delete.
7017         (v850_gdbarch_init): Don't register deleted functions with
7018         gdbarch.
7019
7020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7023         (tilegx_unwind_pc): Delete.
7024         (tilegx_unwind_dummy_id): Delete.
7025         (tilegx_gdbarch_init): Don't register deleted functions with
7026         gdbarch.
7027
7028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7031         (tic6x_dummy_id): Delete.
7032         (tic6x_gdbarch_init): Don't register deleted functions with
7033         gdbarch.
7034
7035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * sparc-tdep.c (sparc_unwind_pc): Delete.
7038         (sparc32_gdbarch_init): Don't register deleted function with
7039         gdbarch.
7040
7041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * sh-tdep.c (sh_unwind_sp): Delete.
7044         (sh_unwind_pc): Delete.
7045         (sh_dummy_id): Delete.
7046         (sh_gdbarch_init): Don't register deleted functions with
7047         gdbarch.
7048
7049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * score-tdep.c (score_unwind_sp): Delete.
7052         (score_unwind_pc): Delete.
7053         (score_dummy_id): Delete.
7054         (score_gdbarch_init): Don't register deleted functions with
7055         gdbarch.
7056
7057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * rx-tdep.c (rx_unwind_pc): Delete.
7060         (rx_unwind_sp): Delete.
7061         (rx_dummy_id): Delete.
7062         (rx_gdbarch_init): Don't register deleted functions with
7063         gdbarch.  Update comment.
7064
7065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7066
7067         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7068         (rs6000_dummy_id): Delete.
7069         (rs6000_gdbarch_init): Don't register deleted functions with
7070         gdbarch.
7071
7072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * or1k-tdep.c (or1k_dummy_id): Delete.
7075         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7076
7077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * nios2-tdep.c (nios2_dummy_id): Delete.
7080         (nios2_unwind_sp): Delete.
7081         (nios2_gdbarch_init): Don't register deleted functions with
7082         gdbarch.
7083
7084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * nds32-tdep.c (nds32_dummy_id): Delete.
7087         (nds32_unwind_pc): Delete.
7088         (nds32_unwind_sp): Delete.
7089         (nds32_gdbarch_init): Don't register deleted functions with
7090         gdbarch.
7091
7092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7093
7094         * msp430-tdep.c (msp430_unwind_pc): Delete.
7095         (msp430_unwind_sp): Delete.
7096         (msp430_dummy_id): Delete.
7097         (msp430_gdbarch_init): Don't register deleted functions with
7098         gdbarch.
7099
7100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * moxie-tdep.c (moxie_unwind_sp): Delete.
7103         (moxie_unwind_pc): Delete.
7104         (moxie_dummy_id): Delete.
7105         (moxie_gdbarch_init): Don't register deleted functions with
7106         gdbarch.
7107
7108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7109
7110         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7111         (mn10300_unwind_pc): Delete.
7112         (mn10300_unwind_sp): Delete.
7113         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7114         mn10300_unwind_sp.
7115         (mn10300_frame_unwind_init): Don't register deleted functions with
7116         gdbarch.
7117
7118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7119
7120         * mep-tdep.c (mep_unwind_pc): Delete.
7121         (mep_unwind_sp): Delete.
7122         (mep_dummy_id): Delete.
7123         (mep_gdbarch_init): Don't register deleted functions with
7124         gdbarch.
7125
7126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7127
7128         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7129         (m68hc11_unwind_sp): Delete.
7130         (m68hc11_gdbarch_init): Don't register deleted functions with
7131         gdbarch.
7132
7133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7134
7135         * m32r-tdep.c (m32r_unwind_sp): Delete.
7136         (m32r_unwind_pc): Delete.
7137         (m32r_dummy_id): Delete.
7138         (m32r_gdbarch_init): Don't register deleted functions with
7139         gdbarch.
7140
7141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * m32c-tdep.c (m32c_unwind_pc): Delete.
7144         (m32c_unwind_sp): Delete.
7145         (m32c_dummy_id): Delete.
7146         (m32c_gdbarch_init): Don't register deleted functions with
7147         gdbarch.
7148
7149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7152         (lm32_unwind_pc): Delete.
7153         (lm32_dummy_id): Delete.
7154         (lm32_gdbarch_init): Don't register deleted functions with
7155         gdbarch.
7156
7157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7160         (iq2000_unwind_pc): Delete.
7161         (iq2000_dummy_id): Delete.
7162         (iq2000_gdbarch_init): Don't register deleted functions with
7163         gdbarch.
7164
7165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * nds32-tdep.c (nds32_type_align): Delete.
7168         (nds32_push_dummy_call): Use type_align instead.
7169
7170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7171
7172         * arm-tdep.c (arm_type_align): Only handle vector override case.
7173         (arm_push_dummy_call): Use type_align.
7174         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7175
7176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7179         case.
7180         (pass_on_stack): Use type_align.
7181         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7182         function.
7183
7184 2019-04-23  Tom Tromey  <tromey@adacore.com>
7185
7186         * dwarf2read.c (line_header::file_name_at): Remove unused
7187         overload.
7188
7189 2019-04-23  Tom de Vries  <tdevries@suse.de>
7190
7191         PR gdb/24438
7192         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7193         invocation.
7194
7195
7196 2019-03-27  Ali Tamur  <tamur@google.com>
7197
7198         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7199         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7200         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7201         (dwarf_expr_context::get_addr_index): Likewise
7202         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7203         (symbol_needs_eval_context::get_addr_index): Likewise
7204         (disassemble_dwarf_expression): Add DW_OP_addrx
7205         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7206         (read_cutu_die_from_dwo): Update comment
7207         (skip_one_die): Add DW_FORM_addrx
7208         (read_attribute_value): Likewise
7209         (var_decode_location): Add DW_OP_addrx
7210         (dwarf2_const_value_attr): Add DW_FORM_addrx
7211         (dump_die_shallow): Likewise
7212         (dwarf2_fetch_constant_bytes): Likewise
7213         (decode_locdesc): Add DW_OP_addrx
7214         (skip_form_bytes): Add DW_FORM_addrx
7215
7216 2019-04-22  Ali Tamur  <tamur@google.com>
7217
7218         * MAINTAINERS (Write After Approval): Add self.
7219
7220 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7221
7222         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7223         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7224         (open_symbol_file_object): Likewise.
7225         (svr4_default_sos): Add info parameter.
7226         (svr4_read_so_list): Likewise.
7227         (svr4_current_sos_direct): Adjust functions calls to pass down
7228         info.
7229         (svr4_current_sos_1): Add info parameter.
7230         (svr4_current_sos): Call get_svr4_info, pass info down to
7231         svr4_current_sos_1.
7232         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7233         get_svr4_info.
7234         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7235         get_svr4_info.
7236         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7237         to get_svr4_info.
7238         (probes_table_remove_objfile_probes): Likewise.
7239         (register_solib_event_probe): Add info parameter.
7240         (solist_update_incremental): Pass info parameter down to
7241         svr4_read_so_list.
7242         (disable_probes_interface): Add info parameter.
7243         (svr4_handle_solib_event): Pass current_program_space to
7244         get_svr4_info.  Adjust disable_probes_interface cleanup.
7245         (svr4_create_probe_breakpoints): Add info parameter, pass it
7246         down to register_solib_event_probe.
7247         (svr4_create_solib_event_breakpoints): Add info parameter,
7248         pass it down to svr4_create_probe_breakpoints.
7249         (enable_break): Pass info down to
7250         svr4_create_solib_event_breakpoints.
7251         (svr4_solib_create_inferior_hook): Pass current_program_space to
7252         get_svr4_info.
7253         (svr4_clear_solib): Likewise.
7254
7255 2019-04-22  Pedro Alves  <palves@redhat.com>
7256
7257         * solib-svr4.c (svr4_free_objfile_observer): New.
7258         (probe_and_action::objfile): New field.
7259         (probes_table_htab_remove_objfile_probes)
7260         (probes_table_remove_objfile_probes): New functions.
7261         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7262         in the new probe_and_action.  Don't store the probe in 'lookup'.
7263         (svr4_create_probe_breakpoints): Pass objfile to
7264         register_solib_event_probe.
7265         (_initialize_svr4_solib): Register a free_objfile observer.
7266
7267 2019-04-19  Tom Tromey  <tom@tromey.com>
7268
7269         * common/queue.h: Remove.
7270
7271 2019-04-19  Tom Tromey  <tom@tromey.com>
7272
7273         * event-loop.c: Don't include "common/queue.h".
7274
7275 2019-04-19  Tom Tromey  <tom@tromey.com>
7276
7277         * remote.c (remote_target): Use delete.
7278         * remote-notif.h: Include <list>, not "common/queue.h".
7279         (notif_client_p): Remove typedef.
7280         (remote_notif_state): Add constructor, destructor, initializer.
7281         <notif_queue>: Now a std::list.
7282         (remote_notif_state_xfree): Don't declare.
7283         * remote-notif.c (remote_notif_process, handle_notification)
7284         (remote_notif_state_allocate): Update.
7285         (~remote_notif_state): Rename from remote_notif_state_xfree.
7286
7287 2019-04-19  Tom Tromey  <tom@tromey.com>
7288
7289         * symfile.c (reread_symbols): Update.
7290         * objfiles.c (objfile_register_static_link)
7291         (objfile_lookup_static_link): Update
7292         (~objfile) Don't delete static_links.
7293         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7294
7295 2019-04-19  Tom Tromey  <tom@tromey.com>
7296
7297         * type-stack.h (struct type_stack) <insert>: Constify string.
7298         * type-stack.c (type_stack::insert): Constify string.
7299         * gdbtypes.h (lookup_template_type): Update.
7300         (address_space_name_to_int): Update.
7301         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7302         const.
7303         (lookup_template_type): Make name const.
7304         * c-exp.y: Update rules.
7305         (lex_one_token, classify_name, classify_inner_name)
7306         (c_print_token): Update.
7307         * p-exp.y: Update rules.
7308         (yylex): Update.
7309         * f-exp.y: Update rules.
7310         (yylex): Update.
7311         * d-exp.y: Update rules.
7312         (lex_one_token, classify_name, classify_inner_name): Update.
7313         * parse.c (write_dollar_variable, copy_name): Return std::string.
7314         * parser-defs.h (copy_name): Change return type.
7315         * m2-exp.y: Update rules.
7316         (yylex): Update.
7317         * go-exp.y (lex_one_token): Update.
7318         Update rules.
7319         (classify_unsafe_function, classify_packaged_name)
7320         (classify_name, yylex): Update.
7321
7322 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7323
7324         * configure.ac: add --enable-source-highlight switch.
7325         * configure: Regenerate.
7326         * top.c (print_gdb_version): plumb --enable-source-highlight
7327         status to "show configuration".
7328
7329 2019-04-19  Tom Tromey  <tromey@adacore.com>
7330
7331         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7332         Check ADA_TYPE_P.
7333         (empty_record, ada_template_to_fixed_record_type_1)
7334         (template_to_static_fixed_type)
7335         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7336         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7337         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7338         macros.
7339
7340 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7341
7342         PR symtab/24423:
7343         * source.c (print_source_lines_base): Advance "iter" when a
7344         control character is seen.
7345
7346 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7347
7348         * inferior.h (struct infcall_suspend_state_deleter):
7349         Catch exception in destructor to avoid crash.
7350
7351 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7352
7353         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7354         close to the add_com "shell".
7355
7356 2019-04-18  Tom Tromey  <tromey@adacore.com>
7357
7358         * process-stratum-target.h (class process_stratum_target)
7359         <stratum>: Add "final".
7360
7361 2019-04-17  Tom Tromey  <tromey@adacore.com>
7362
7363         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7364         against nullptr before use.
7365
7366 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7367
7368         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7369
7370 2019-04-17  Jim Wilson  <jimw@sifive.com>
7371             Andrew Burgess  <andrew.burgess@embecosm.com>
7372
7373         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7374         code read might fail, assume 4-byte breakpoint in that case.
7375
7376 2019-04-15  Leszek Swirski  <leszeks@google.com>
7377
7378         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7379         rather than a hand-rolled POD check when checking for forced MEMORY
7380         classification.
7381
7382 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7383
7384         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7385         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7386         function.
7387         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7388         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7389         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7390         declaration.
7391
7392 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7393
7394         * aarch64-linux-nat.c
7395         (aarch64_linux_nat_target::thread_architecture): Add override.
7396         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7397         each VQ.
7398
7399 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7400
7401         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7402
7403 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7406         target types of size 96-bits, add some additional comments, and
7407         check that the builtin type we found was the correct size.
7408
7409 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7410
7411         * utils.c (prompt_for_continue): Don't restore the styling at the
7412         end, as applied_style has the wrong value.  This fixes styling in
7413         long lists of file names that are interrupted by the "Continue?"
7414         prompt.
7415
7416 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7417
7418         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7419         * c-lang.c (c_language_defn): Likewise.
7420         (cplus_language_defn): Likewise.
7421         (asm_language_defn): Likewise.
7422         (minimal_language_defn): Likewise.
7423         * d-lang.c (d_language_defn): Likewise.
7424         * f-lang.c (f_language_defn): Likewise.
7425         * go-lang.c (go_language_defn): Likewise.
7426         * language.c (unknown_language_defn): Likewise.
7427         (auto_language_defn): Likewise.
7428         * language.h (struct language_defn): Remove la_magic field.
7429         (LANG_MAGIC): Delete.
7430         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7431         * objc-lang.c (objc_language_defn): Likewise.
7432         * opencl-lang.c (opencl_language_defn): Likewise.
7433         * p-lang.c (pascal_language_defn): Likewise.
7434         * rust-lang.c (rust_language_defn): Likewise.
7435
7436 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * riscv-tdep.c (riscv_type_align): New function.
7439         (riscv_type_alignment): Delete.
7440         (riscv_arg_location): Use 'type_align'.
7441         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7442
7443 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7444
7445         * gdbtypes.c (type_align): A struct with no non-static fields also
7446         has alignment of 1.
7447
7448 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7451         component to 0.
7452         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7453         member.
7454         (riscv_struct_info::analyse): New implementation using new
7455         analyse_inner member function.
7456         (riscv_struct_info::field_offset): New member function.
7457         (riscv_struct_info::m_offsets): New member variable.
7458         (riscv_struct_info::analyse_inner): New private member function,
7459         takes the old implementation of riscv_struct_info::analyse but
7460         extended to track field offsets.
7461         (riscv_call_arg_struct): Update the struct folding special cases
7462         to handle cases where empty C++ structs, which are non-zero
7463         length, are found.
7464         (riscv_arg_location): Initialise the length of each location, a
7465         non-zero length now indicates the location is in use.
7466         (riscv_push_dummy_call): Allow for the first location having a
7467         non-zero offset when setting up arguments.
7468         (riscv_return_value): Likewise, but for return values.
7469
7470 2019-04-11  Tom Tromey  <tromey@adacore.com>
7471
7472         * utils.c (internal_vproblem): Make "msg" const.
7473
7474 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7475
7476         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7477         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7478         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7479         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7480
7481 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7482
7483         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7484         function.
7485         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7486         of amd64_collect_native_gregset.
7487         (amd64_linux_nat_target::store_registers): Likewise.
7488
7489 2019-04-10  Tom Tromey  <tom@tromey.com>
7490
7491         * symtab.c (lookup_global_symbol_from_objfile)
7492         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7493         * objfiles.h (class separate_debug_iterator): New.
7494         (class separate_debug_range): New.
7495         (struct objfile) <separate_debug_objfiles>: New method.
7496         (objfile_separate_debug_iterate): Don't declare.
7497         * objfiles.c (separate_debug_iterator::operator++): Rename from
7498         objfile_separate_debug_iterate.
7499         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7500         iterator.
7501         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7502         iterator.
7503
7504 2019-04-10  Tom Tromey  <tom@tromey.com>
7505
7506         * symfile.c (reread_symbols): Remove old comment.
7507         * objfiles.c (free_all_objfiles): Fix a typo.
7508
7509 2019-04-10  Tom Tromey  <tom@tromey.com>
7510
7511         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7512         * minsyms.c (lookup_minimal_symbol): Use foreach.
7513         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7514         (lookup_minimal_symbol_solib_trampoline): Likewise.
7515         * symfile.c (reread_symbols): Use foreach.
7516
7517 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7518             Tom Tromey  <tromey@adacore.com>
7519
7520         PR rust/24414:
7521         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7522         (rust_lex_int_test): Change "value" to be LONGEST.
7523         (rust_lex_tests): Add test for long integer literal.
7524
7525 2019-04-09  Tom Tromey  <tromey@adacore.com>
7526
7527         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7528         to bool.
7529         (extended_remote_target::attach): Update.
7530         (remote_target::remote_notice_new_inferior): Update.
7531         (remote_target::add_current_inferior_and_thread): Update.
7532         * inferior.c (exit_inferior_1): Use "false".
7533         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7534
7535 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7536
7537         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7538         the "start" command.
7539
7540 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7541
7542         * python/py-inferior.c (infpy_thread_from_thread_handle):
7543         Adjust comments to reflect renaming of thread_from_thread_handle
7544         to thread_from_handle.  Adjust keywords.  Fix type error message.
7545         (inferior_object_methods): Add thread_from_handle.  Retain
7546         thread_from_thread_handle, but mark it as deprecated.
7547
7548 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7549
7550         * gdbthread.h (find_thread_by_handle): Revise declaration.
7551         * thread.c (find_thread_by_handle): Likewise.  Adjust
7552         implementation too.
7553         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7554         support for buffer objects as handles.
7555
7556 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7557
7558         * python/py-infthread.c (thpy_thread_handle): New function.
7559         (thread_object_methods): Register thpy_thread_handle.
7560
7561 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7562
7563         * gdbthread.h (thread_to_thread_handle): Declare.
7564         * thread.c (gdbtypes.h): Include.
7565         (thread_to_thread_handle): New function.
7566
7567         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7568         (target_thread_info_to_thread_handle): Declare.
7569         * target.c (target_thread_info_to_thread_handle): New function.
7570         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7571         * target-delegates.c: Regenerate.
7572
7573         * linux-thread-db.c (class thread_db_target): Add method
7574         thread_info_to_thread_handle.
7575         (thread_db_target::thread_info_to_thread_handle): Define.
7576         * remote.c (class remote_target): Add new method
7577         thread_info_to_thread_handle.
7578         (remote_target::thread_info_to_thread_handle): Define.
7579
7580 2019-04-08  Pedro Alves  <palves@redhat.com>
7581
7582         * common/common-exceptions.c (throw_exception): Don't create
7583         named object to throw; throw directly.
7584         (throw_it): Likewise.  Don't initialize gdb_exception::message
7585         here, with new; pass FMT and AP to the ctor instead.
7586         * common/common-exceptions.h: Include <string>.
7587         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7588         const char *, va_list)): New ctor.  Use std::make_shared.
7589         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7590         errors)): Delete.
7591         (gdb_exception_error::gdb_exception_error(enum errors, const char
7592         *, va_list)): New.
7593         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7594         Add assertion.
7595         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7596         errors)): Delete.
7597         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7598         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7599         Add assertion.
7600
7601 2019-04-08  Tom Tromey  <tom@tromey.com>
7602
7603         * valops.c (value_rtti_indirect_type): Replace throw_exception
7604         with throw.
7605         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7606         with throw.
7607         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7608         throw.
7609         * target.c (target_translate_tls_address): Replace throw_exception
7610         with throw.
7611         * stack.c (frame_apply_command_count): Replace throw_exception
7612         with throw.
7613         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7614         throw.
7615         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7616         with throw.
7617         * rs6000-tdep.c (rs6000_frame_cache)
7618         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7619         * remote.c: Replace throw_exception with throw.
7620         * record-full.c (record_full_message, record_full_wait_1)
7621         (record_full_restore): Replace throw_exception with throw.
7622         * record-btrace.c:
7623         (get_thread_current_frame_id, record_btrace_start_replaying)
7624         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7625         (cmd_record_btrace_start): Replace throw_exception with throw.
7626         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7627         throw.
7628         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7629         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7630         * linespec.c:
7631         (find_linespec_symbols): Replace throw_exception with throw.
7632         * infrun.c (displaced_step_prepare, resume): Replace
7633         throw_exception with throw.
7634         * infcmd.c (post_create_inferior): Replace throw_exception with
7635         throw.
7636         * inf-loop.c (inferior_event_handler): Replace throw_exception
7637         with throw.
7638         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7639         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7640         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7641         (get_prev_frame_always, get_frame_pc_if_available)
7642         (get_frame_address_in_block_if_available, get_frame_language):
7643         Replace throw_exception with throw.
7644         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7645         throw_exception with throw.
7646         * eval.c (fetch_subexp_value, evaluate_var_value)
7647         (evaluate_funcall, evaluate_subexp_standard): Replace
7648         throw_exception with throw.
7649         * dwarf2loc.c (call_site_find_chain)
7650         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7651         Replace throw_exception with throw.
7652         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7653         with throw.
7654         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7655         throw.
7656         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7657         * completer.c (complete_line_internal): Replace throw_exception
7658         with throw.
7659         * compile/compile-object-run.c (compile_object_run): Replace
7660         throw_exception with throw.
7661         * cli/cli-script.c (process_next_line): Replace throw_exception
7662         with throw.
7663         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7664         (btrace_enable, btrace_maint_update_pt_packets): Replace
7665         throw_exception with throw.
7666         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7667         throw_exception with throw.
7668         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7669         throw_exception with throw.
7670         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7671         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7672         * aarch64-tdep.c (aarch64_make_prologue_cache)
7673         (aarch64_make_stub_cache): Replace throw_exception with throw.
7674
7675 2019-04-08  Tom Tromey  <tom@tromey.com>
7676
7677         * common/common-exceptions.c (throw_exception): Rename from
7678         throw_exception_cxx.  Remove old copy.  Make argument const.
7679         (throw_it): Create and throw exception objects directly.
7680         * common/common-exceptions.h (throw_exception): Make argument
7681         const.
7682         (struct gdb_exception_error): Add constructor.
7683         (struct gdb_exception_quit): Add constructor.
7684
7685 2019-04-08  Tom Tromey  <tom@tromey.com>
7686
7687         * common/common-exceptions.h (exception_rethrow): Don't declare.
7688         (TRY_SJLJ): Update comment.
7689         (TRY, CATCH, END_CATCH): Remove.
7690         * common/common-exceptions.c (exception_rethrow): Remove.
7691
7692 2019-04-08  Tom Tromey  <tom@tromey.com>
7693
7694         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7695         Remove.
7696         (gdb_exception_error): Rename from
7697         gdb_exception_RETURN_MASK_ERROR.
7698         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7699         (gdb_quit_bad_alloc): Update.
7700         * aarch64-tdep.c: Update.
7701         * ada-lang.c: Update.
7702         * ada-typeprint.c: Update.
7703         * ada-valprint.c: Update.
7704         * amd64-tdep.c: Update.
7705         * arch-utils.c: Update.
7706         * break-catch-throw.c: Update.
7707         * breakpoint.c: Update.
7708         * btrace.c: Update.
7709         * c-varobj.c: Update.
7710         * cli/cli-cmds.c: Update.
7711         * cli/cli-interp.c: Update.
7712         * cli/cli-script.c: Update.
7713         * common/common-exceptions.c: Update.
7714         * common/new-op.c: Update.
7715         * common/selftest.c: Update.
7716         * compile/compile-c-symbols.c: Update.
7717         * compile/compile-cplus-symbols.c: Update.
7718         * compile/compile-object-load.c: Update.
7719         * compile/compile-object-run.c: Update.
7720         * completer.c: Update.
7721         * corelow.c: Update.
7722         * cp-abi.c: Update.
7723         * cp-support.c: Update.
7724         * cp-valprint.c: Update.
7725         * darwin-nat.c: Update.
7726         * disasm-selftests.c: Update.
7727         * dtrace-probe.c: Update.
7728         * dwarf-index-cache.c: Update.
7729         * dwarf-index-write.c: Update.
7730         * dwarf2-frame-tailcall.c: Update.
7731         * dwarf2-frame.c: Update.
7732         * dwarf2loc.c: Update.
7733         * dwarf2read.c: Update.
7734         * eval.c: Update.
7735         * event-loop.c: Update.
7736         * event-top.c: Update.
7737         * exec.c: Update.
7738         * f-valprint.c: Update.
7739         * fbsd-tdep.c: Update.
7740         * frame-unwind.c: Update.
7741         * frame.c: Update.
7742         * gdbtypes.c: Update.
7743         * gnu-v3-abi.c: Update.
7744         * guile/guile-internal.h: Update.
7745         * guile/scm-block.c: Update.
7746         * guile/scm-breakpoint.c: Update.
7747         * guile/scm-cmd.c: Update.
7748         * guile/scm-disasm.c: Update.
7749         * guile/scm-frame.c: Update.
7750         * guile/scm-lazy-string.c: Update.
7751         * guile/scm-math.c: Update.
7752         * guile/scm-param.c: Update.
7753         * guile/scm-ports.c: Update.
7754         * guile/scm-pretty-print.c: Update.
7755         * guile/scm-symbol.c: Update.
7756         * guile/scm-symtab.c: Update.
7757         * guile/scm-type.c: Update.
7758         * guile/scm-value.c: Update.
7759         * i386-linux-tdep.c: Update.
7760         * i386-tdep.c: Update.
7761         * inf-loop.c: Update.
7762         * infcall.c: Update.
7763         * infcmd.c: Update.
7764         * infrun.c: Update.
7765         * jit.c: Update.
7766         * language.c: Update.
7767         * linespec.c: Update.
7768         * linux-fork.c: Update.
7769         * linux-nat.c: Update.
7770         * linux-tdep.c: Update.
7771         * linux-thread-db.c: Update.
7772         * main.c: Update.
7773         * mi/mi-cmd-break.c: Update.
7774         * mi/mi-cmd-stack.c: Update.
7775         * mi/mi-interp.c: Update.
7776         * mi/mi-main.c: Update.
7777         * objc-lang.c: Update.
7778         * p-valprint.c: Update.
7779         * parse.c: Update.
7780         * ppc-linux-tdep.c: Update.
7781         * printcmd.c: Update.
7782         * python/py-arch.c: Update.
7783         * python/py-breakpoint.c: Update.
7784         * python/py-cmd.c: Update.
7785         * python/py-finishbreakpoint.c: Update.
7786         * python/py-frame.c: Update.
7787         * python/py-framefilter.c: Update.
7788         * python/py-gdb-readline.c: Update.
7789         * python/py-inferior.c: Update.
7790         * python/py-infthread.c: Update.
7791         * python/py-lazy-string.c: Update.
7792         * python/py-linetable.c: Update.
7793         * python/py-objfile.c: Update.
7794         * python/py-param.c: Update.
7795         * python/py-prettyprint.c: Update.
7796         * python/py-progspace.c: Update.
7797         * python/py-record-btrace.c: Update.
7798         * python/py-record.c: Update.
7799         * python/py-symbol.c: Update.
7800         * python/py-type.c: Update.
7801         * python/py-unwind.c: Update.
7802         * python/py-utils.c: Update.
7803         * python/py-value.c: Update.
7804         * python/python.c: Update.
7805         * record-btrace.c: Update.
7806         * record-full.c: Update.
7807         * remote-fileio.c: Update.
7808         * remote.c: Update.
7809         * riscv-tdep.c: Update.
7810         * rs6000-aix-tdep.c: Update.
7811         * rs6000-tdep.c: Update.
7812         * rust-exp.y: Update.
7813         * rust-lang.c: Update.
7814         * s390-tdep.c: Update.
7815         * selftest-arch.c: Update.
7816         * solib-dsbt.c: Update.
7817         * solib-frv.c: Update.
7818         * solib-spu.c: Update.
7819         * solib-svr4.c: Update.
7820         * solib.c: Update.
7821         * sparc64-linux-tdep.c: Update.
7822         * stack.c: Update.
7823         * symfile-mem.c: Update.
7824         * symmisc.c: Update.
7825         * target.c: Update.
7826         * thread.c: Update.
7827         * top.c: Update.
7828         * tracefile-tfile.c: Update.
7829         * tui/tui.c: Update.
7830         * typeprint.c: Update.
7831         * unittests/cli-utils-selftests.c: Update.
7832         * unittests/parse-connection-spec-selftests.c: Update.
7833         * valops.c: Update.
7834         * valprint.c: Update.
7835         * value.c: Update.
7836         * varobj.c: Update.
7837         * windows-nat.c: Update.
7838         * x86-linux-nat.c: Update.
7839         * xml-support.c: Update.
7840
7841 2019-04-08  Tom Tromey  <tom@tromey.com>
7842
7843         * xml-support.c: Use C++ exception handling.
7844         * x86-linux-nat.c: Use C++ exception handling.
7845         * windows-nat.c: Use C++ exception handling.
7846         * varobj.c: Use C++ exception handling.
7847         * value.c: Use C++ exception handling.
7848         * valprint.c: Use C++ exception handling.
7849         * valops.c: Use C++ exception handling.
7850         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7851         handling.
7852         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7853         * typeprint.c: Use C++ exception handling.
7854         * tui/tui.c: Use C++ exception handling.
7855         * tracefile-tfile.c: Use C++ exception handling.
7856         * top.c: Use C++ exception handling.
7857         * thread.c: Use C++ exception handling.
7858         * target.c: Use C++ exception handling.
7859         * symmisc.c: Use C++ exception handling.
7860         * symfile-mem.c: Use C++ exception handling.
7861         * stack.c: Use C++ exception handling.
7862         * sparc64-linux-tdep.c: Use C++ exception handling.
7863         * solib.c: Use C++ exception handling.
7864         * solib-svr4.c: Use C++ exception handling.
7865         * solib-spu.c: Use C++ exception handling.
7866         * solib-frv.c: Use C++ exception handling.
7867         * solib-dsbt.c: Use C++ exception handling.
7868         * selftest-arch.c: Use C++ exception handling.
7869         * s390-tdep.c: Use C++ exception handling.
7870         * rust-lang.c: Use C++ exception handling.
7871         * rust-exp.y: Use C++ exception handling.
7872         * rs6000-tdep.c: Use C++ exception handling.
7873         * rs6000-aix-tdep.c: Use C++ exception handling.
7874         * riscv-tdep.c: Use C++ exception handling.
7875         * remote.c: Use C++ exception handling.
7876         * remote-fileio.c: Use C++ exception handling.
7877         * record-full.c: Use C++ exception handling.
7878         * record-btrace.c: Use C++ exception handling.
7879         * python/python.c: Use C++ exception handling.
7880         * python/py-value.c: Use C++ exception handling.
7881         * python/py-utils.c: Use C++ exception handling.
7882         * python/py-unwind.c: Use C++ exception handling.
7883         * python/py-type.c: Use C++ exception handling.
7884         * python/py-symbol.c: Use C++ exception handling.
7885         * python/py-record.c: Use C++ exception handling.
7886         * python/py-record-btrace.c: Use C++ exception handling.
7887         * python/py-progspace.c: Use C++ exception handling.
7888         * python/py-prettyprint.c: Use C++ exception handling.
7889         * python/py-param.c: Use C++ exception handling.
7890         * python/py-objfile.c: Use C++ exception handling.
7891         * python/py-linetable.c: Use C++ exception handling.
7892         * python/py-lazy-string.c: Use C++ exception handling.
7893         * python/py-infthread.c: Use C++ exception handling.
7894         * python/py-inferior.c: Use C++ exception handling.
7895         * python/py-gdb-readline.c: Use C++ exception handling.
7896         * python/py-framefilter.c: Use C++ exception handling.
7897         * python/py-frame.c: Use C++ exception handling.
7898         * python/py-finishbreakpoint.c: Use C++ exception handling.
7899         * python/py-cmd.c: Use C++ exception handling.
7900         * python/py-breakpoint.c: Use C++ exception handling.
7901         * python/py-arch.c: Use C++ exception handling.
7902         * printcmd.c: Use C++ exception handling.
7903         * ppc-linux-tdep.c: Use C++ exception handling.
7904         * parse.c: Use C++ exception handling.
7905         * p-valprint.c: Use C++ exception handling.
7906         * objc-lang.c: Use C++ exception handling.
7907         * mi/mi-main.c: Use C++ exception handling.
7908         * mi/mi-interp.c: Use C++ exception handling.
7909         * mi/mi-cmd-stack.c: Use C++ exception handling.
7910         * mi/mi-cmd-break.c: Use C++ exception handling.
7911         * main.c: Use C++ exception handling.
7912         * linux-thread-db.c: Use C++ exception handling.
7913         * linux-tdep.c: Use C++ exception handling.
7914         * linux-nat.c: Use C++ exception handling.
7915         * linux-fork.c: Use C++ exception handling.
7916         * linespec.c: Use C++ exception handling.
7917         * language.c: Use C++ exception handling.
7918         * jit.c: Use C++ exception handling.
7919         * infrun.c: Use C++ exception handling.
7920         * infcmd.c: Use C++ exception handling.
7921         * infcall.c: Use C++ exception handling.
7922         * inf-loop.c: Use C++ exception handling.
7923         * i386-tdep.c: Use C++ exception handling.
7924         * i386-linux-tdep.c: Use C++ exception handling.
7925         * guile/scm-value.c: Use C++ exception handling.
7926         * guile/scm-type.c: Use C++ exception handling.
7927         * guile/scm-symtab.c: Use C++ exception handling.
7928         * guile/scm-symbol.c: Use C++ exception handling.
7929         * guile/scm-pretty-print.c: Use C++ exception handling.
7930         * guile/scm-ports.c: Use C++ exception handling.
7931         * guile/scm-param.c: Use C++ exception handling.
7932         * guile/scm-math.c: Use C++ exception handling.
7933         * guile/scm-lazy-string.c: Use C++ exception handling.
7934         * guile/scm-frame.c: Use C++ exception handling.
7935         * guile/scm-disasm.c: Use C++ exception handling.
7936         * guile/scm-cmd.c: Use C++ exception handling.
7937         * guile/scm-breakpoint.c: Use C++ exception handling.
7938         * guile/scm-block.c: Use C++ exception handling.
7939         * guile/guile-internal.h: Use C++ exception handling.
7940         * gnu-v3-abi.c: Use C++ exception handling.
7941         * gdbtypes.c: Use C++ exception handling.
7942         * frame.c: Use C++ exception handling.
7943         * frame-unwind.c: Use C++ exception handling.
7944         * fbsd-tdep.c: Use C++ exception handling.
7945         * f-valprint.c: Use C++ exception handling.
7946         * exec.c: Use C++ exception handling.
7947         * event-top.c: Use C++ exception handling.
7948         * event-loop.c: Use C++ exception handling.
7949         * eval.c: Use C++ exception handling.
7950         * dwarf2read.c: Use C++ exception handling.
7951         * dwarf2loc.c: Use C++ exception handling.
7952         * dwarf2-frame.c: Use C++ exception handling.
7953         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7954         * dwarf-index-write.c: Use C++ exception handling.
7955         * dwarf-index-cache.c: Use C++ exception handling.
7956         * dtrace-probe.c: Use C++ exception handling.
7957         * disasm-selftests.c: Use C++ exception handling.
7958         * darwin-nat.c: Use C++ exception handling.
7959         * cp-valprint.c: Use C++ exception handling.
7960         * cp-support.c: Use C++ exception handling.
7961         * cp-abi.c: Use C++ exception handling.
7962         * corelow.c: Use C++ exception handling.
7963         * completer.c: Use C++ exception handling.
7964         * compile/compile-object-run.c: Use C++ exception handling.
7965         * compile/compile-object-load.c: Use C++ exception handling.
7966         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7967         * compile/compile-c-symbols.c: Use C++ exception handling.
7968         * common/selftest.c: Use C++ exception handling.
7969         * common/new-op.c: Use C++ exception handling.
7970         * cli/cli-script.c: Use C++ exception handling.
7971         * cli/cli-interp.c: Use C++ exception handling.
7972         * cli/cli-cmds.c: Use C++ exception handling.
7973         * c-varobj.c: Use C++ exception handling.
7974         * btrace.c: Use C++ exception handling.
7975         * breakpoint.c: Use C++ exception handling.
7976         * break-catch-throw.c: Use C++ exception handling.
7977         * arch-utils.c: Use C++ exception handling.
7978         * amd64-tdep.c: Use C++ exception handling.
7979         * ada-valprint.c: Use C++ exception handling.
7980         * ada-typeprint.c: Use C++ exception handling.
7981         * ada-lang.c: Use C++ exception handling.
7982         * aarch64-tdep.c: Use C++ exception handling.
7983
7984 2019-04-08  Tom Tromey  <tom@tromey.com>
7985
7986         * xml-support.c (gdb_xml_parser::parse): Update.
7987         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7988         * value.c (show_convenience): Update.
7989         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7990         (test_parse_flags_qcs): Update.
7991         * thread.c (thr_try_catch_cmd): Update.
7992         * target.c (target_translate_tls_address): Update.
7993         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7994         (info_frame_command_core, frame_apply_command_count): Update.
7995         * rust-exp.y (rust_lex_exception_test): Update.
7996         * riscv-tdep.c (riscv_print_one_register_info): Update.
7997         * remote.c (remote_target::enable_btrace): Update.
7998         * record-btrace.c (record_btrace_enable_warn): Update.
7999         * python/py-utils.c (gdbpy_convert_exception): Update.
8000         * printcmd.c (do_one_display, print_variable_and_value): Update.
8001         * mi/mi-main.c (mi_print_exception): Update.
8002         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8003         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8004         * linux-nat.c (linux_nat_target::attach): Update.
8005         * linux-fork.c (class scoped_switch_fork_info): Update.
8006         * infrun.c (displaced_step_prepare): Update.
8007         * infcall.c (call_function_by_hand_dummy): Update.
8008         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8009         * gnu-v3-abi.c (print_one_vtable): Update.
8010         * frame.c (get_prev_frame_always): Update.
8011         * f-valprint.c (info_common_command_for_block): Update.
8012         * exec.c (try_open_exec_file): Update.
8013         * exceptions.c (print_exception, exception_print)
8014         (exception_fprintf, exception_print_same): Update.
8015         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8016         * dwarf-index-cache.c (index_cache::store)
8017         (index_cache::lookup_gdb_index): Update.
8018         * darwin-nat.c (maybe_cache_shell): Update.
8019         * cp-valprint.c (cp_print_value_fields): Update.
8020         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8021         (gcc_cplus_symbol_address): Update.
8022         * compile/compile-c-symbols.c (gcc_convert_symbol)
8023         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8024         * common/selftest.c: Update.
8025         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8026         a std::string.
8027         (exception_try_scope_entry, exception_try_scope_exit): Don't
8028         declare.
8029         (struct exception_try_scope): Remove.
8030         (TRY): Don't use exception_try_scope.
8031         (struct gdb_exception): Add constructor, operator=.
8032         <what>: New method.
8033         (struct gdb_exception_RETURN_MASK_ALL)
8034         (struct gdb_exception_RETURN_MASK_ERROR)
8035         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8036         (struct gdb_quit_bad_alloc): Update.
8037         * common/common-exceptions.c (exception_none): Change
8038         initializer.
8039         (struct catcher) <state, exception>: Initialize inline.
8040         <prev>: Remove member.
8041         (current_catcher): Remove.
8042         (catchers): New global.
8043         (exceptions_state_mc_init): Simplify.
8044         (catcher_pop): Remove.
8045         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8046         (try_scope_depth, exception_try_scope_entry)
8047         (exception_try_scope_exit): Remove.
8048         (throw_exception_sjlj): Update.
8049         (exception_messages, exception_messages_size): Remove.
8050         (throw_it): Simplify.
8051         (gdb_exception_sliced_copy): Remove.
8052         (throw_exception_cxx): Update.
8053         * cli/cli-script.c (script_from_file): Update.
8054         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8055         Update.
8056         * ada-valprint.c (ada_val_print): Update.
8057         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8058         (create_excep_cond_exprs): Update.
8059
8060 2019-04-08  Tom Tromey  <tom@tromey.com>
8061
8062         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8063         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8064         (TRY, CATCH, END_CATCH): Remove some definitions.
8065         * common/common-exceptions.c: Don't use GDB_XCPT.
8066         (catcher_list_size): Remove.
8067         (throw_exception, throw_it): Simplify.
8068
8069 2019-04-05  Tom Tromey  <tom@tromey.com>
8070
8071         Revert the header-sorting patch.
8072         * ft32-tdep.c: Revert.
8073         * frv-tdep.c: Revert.
8074         * frv-linux-tdep.c: Revert.
8075         * frame.c: Revert.
8076         * frame-unwind.c: Revert.
8077         * frame-base.c: Revert.
8078         * fork-child.c: Revert.
8079         * findvar.c: Revert.
8080         * findcmd.c: Revert.
8081         * filesystem.c: Revert.
8082         * filename-seen-cache.h: Revert.
8083         * filename-seen-cache.c: Revert.
8084         * fbsd-tdep.c: Revert.
8085         * fbsd-nat.h: Revert.
8086         * fbsd-nat.c: Revert.
8087         * f-valprint.c: Revert.
8088         * f-typeprint.c: Revert.
8089         * f-lang.c: Revert.
8090         * extension.h: Revert.
8091         * extension.c: Revert.
8092         * extension-priv.h: Revert.
8093         * expprint.c: Revert.
8094         * exec.h: Revert.
8095         * exec.c: Revert.
8096         * exceptions.c: Revert.
8097         * event-top.c: Revert.
8098         * event-loop.c: Revert.
8099         * eval.c: Revert.
8100         * elfread.c: Revert.
8101         * dwarf2read.h: Revert.
8102         * dwarf2read.c: Revert.
8103         * dwarf2loc.c: Revert.
8104         * dwarf2expr.h: Revert.
8105         * dwarf2expr.c: Revert.
8106         * dwarf2-frame.c: Revert.
8107         * dwarf2-frame-tailcall.c: Revert.
8108         * dwarf-index-write.h: Revert.
8109         * dwarf-index-write.c: Revert.
8110         * dwarf-index-common.c: Revert.
8111         * dwarf-index-cache.h: Revert.
8112         * dwarf-index-cache.c: Revert.
8113         * dummy-frame.c: Revert.
8114         * dtrace-probe.c: Revert.
8115         * disasm.h: Revert.
8116         * disasm.c: Revert.
8117         * disasm-selftests.c: Revert.
8118         * dictionary.c: Revert.
8119         * dicos-tdep.c: Revert.
8120         * demangle.c: Revert.
8121         * dcache.h: Revert.
8122         * dcache.c: Revert.
8123         * darwin-nat.h: Revert.
8124         * darwin-nat.c: Revert.
8125         * darwin-nat-info.c: Revert.
8126         * d-valprint.c: Revert.
8127         * d-namespace.c: Revert.
8128         * d-lang.c: Revert.
8129         * ctf.c: Revert.
8130         * csky-tdep.c: Revert.
8131         * csky-linux-tdep.c: Revert.
8132         * cris-tdep.c: Revert.
8133         * cris-linux-tdep.c: Revert.
8134         * cp-valprint.c: Revert.
8135         * cp-support.c: Revert.
8136         * cp-namespace.c: Revert.
8137         * cp-abi.c: Revert.
8138         * corelow.c: Revert.
8139         * corefile.c: Revert.
8140         * continuations.c: Revert.
8141         * completer.h: Revert.
8142         * completer.c: Revert.
8143         * complaints.c: Revert.
8144         * coffread.c: Revert.
8145         * coff-pe-read.c: Revert.
8146         * cli-out.h: Revert.
8147         * cli-out.c: Revert.
8148         * charset.c: Revert.
8149         * c-varobj.c: Revert.
8150         * c-valprint.c: Revert.
8151         * c-typeprint.c: Revert.
8152         * c-lang.c: Revert.
8153         * buildsym.c: Revert.
8154         * buildsym-legacy.c: Revert.
8155         * build-id.h: Revert.
8156         * build-id.c: Revert.
8157         * btrace.c: Revert.
8158         * bsd-uthread.c: Revert.
8159         * breakpoint.h: Revert.
8160         * breakpoint.c: Revert.
8161         * break-catch-throw.c: Revert.
8162         * break-catch-syscall.c: Revert.
8163         * break-catch-sig.c: Revert.
8164         * blockframe.c: Revert.
8165         * block.c: Revert.
8166         * bfin-tdep.c: Revert.
8167         * bfin-linux-tdep.c: Revert.
8168         * bfd-target.c: Revert.
8169         * bcache.c: Revert.
8170         * ax-general.c: Revert.
8171         * ax-gdb.h: Revert.
8172         * ax-gdb.c: Revert.
8173         * avr-tdep.c: Revert.
8174         * auxv.c: Revert.
8175         * auto-load.c: Revert.
8176         * arm-wince-tdep.c: Revert.
8177         * arm-tdep.c: Revert.
8178         * arm-symbian-tdep.c: Revert.
8179         * arm-pikeos-tdep.c: Revert.
8180         * arm-obsd-tdep.c: Revert.
8181         * arm-nbsd-tdep.c: Revert.
8182         * arm-nbsd-nat.c: Revert.
8183         * arm-linux-tdep.c: Revert.
8184         * arm-linux-nat.c: Revert.
8185         * arm-fbsd-tdep.c: Revert.
8186         * arm-fbsd-nat.c: Revert.
8187         * arm-bsd-tdep.c: Revert.
8188         * arch-utils.c: Revert.
8189         * arc-tdep.c: Revert.
8190         * arc-newlib-tdep.c: Revert.
8191         * annotate.h: Revert.
8192         * annotate.c: Revert.
8193         * amd64-windows-tdep.c: Revert.
8194         * amd64-windows-nat.c: Revert.
8195         * amd64-tdep.c: Revert.
8196         * amd64-sol2-tdep.c: Revert.
8197         * amd64-obsd-tdep.c: Revert.
8198         * amd64-obsd-nat.c: Revert.
8199         * amd64-nbsd-tdep.c: Revert.
8200         * amd64-nbsd-nat.c: Revert.
8201         * amd64-nat.c: Revert.
8202         * amd64-linux-tdep.c: Revert.
8203         * amd64-linux-nat.c: Revert.
8204         * amd64-fbsd-tdep.c: Revert.
8205         * amd64-fbsd-nat.c: Revert.
8206         * amd64-dicos-tdep.c: Revert.
8207         * amd64-darwin-tdep.c: Revert.
8208         * amd64-bsd-nat.c: Revert.
8209         * alpha-tdep.c: Revert.
8210         * alpha-obsd-tdep.c: Revert.
8211         * alpha-nbsd-tdep.c: Revert.
8212         * alpha-mdebug-tdep.c: Revert.
8213         * alpha-linux-tdep.c: Revert.
8214         * alpha-linux-nat.c: Revert.
8215         * alpha-bsd-tdep.c: Revert.
8216         * alpha-bsd-nat.c: Revert.
8217         * aix-thread.c: Revert.
8218         * agent.c: Revert.
8219         * addrmap.c: Revert.
8220         * ada-varobj.c: Revert.
8221         * ada-valprint.c: Revert.
8222         * ada-typeprint.c: Revert.
8223         * ada-tasks.c: Revert.
8224         * ada-lang.c: Revert.
8225         * aarch64-tdep.c: Revert.
8226         * aarch64-ravenscar-thread.c: Revert.
8227         * aarch64-newlib-tdep.c: Revert.
8228         * aarch64-linux-tdep.c: Revert.
8229         * aarch64-linux-nat.c: Revert.
8230         * aarch64-fbsd-tdep.c: Revert.
8231         * aarch64-fbsd-nat.c: Revert.
8232         * aarch32-linux-nat.c: Revert.
8233
8234 2019-04-05  Tom Tromey  <tom@tromey.com>
8235
8236         * ft32-tdep.c: Sort headers.
8237         * frv-tdep.c: Sort headers.
8238         * frv-linux-tdep.c: Sort headers.
8239         * frame.c: Sort headers.
8240         * frame-unwind.c: Sort headers.
8241         * frame-base.c: Sort headers.
8242         * fork-child.c: Sort headers.
8243         * findvar.c: Sort headers.
8244         * findcmd.c: Sort headers.
8245         * filesystem.c: Sort headers.
8246         * filename-seen-cache.h: Sort headers.
8247         * filename-seen-cache.c: Sort headers.
8248         * fbsd-tdep.c: Sort headers.
8249         * fbsd-nat.h: Sort headers.
8250         * fbsd-nat.c: Sort headers.
8251         * f-valprint.c: Sort headers.
8252         * f-typeprint.c: Sort headers.
8253         * f-lang.c: Sort headers.
8254         * extension.h: Sort headers.
8255         * extension.c: Sort headers.
8256         * extension-priv.h: Sort headers.
8257         * expprint.c: Sort headers.
8258         * exec.h: Sort headers.
8259         * exec.c: Sort headers.
8260         * exceptions.c: Sort headers.
8261         * event-top.c: Sort headers.
8262         * event-loop.c: Sort headers.
8263         * eval.c: Sort headers.
8264         * elfread.c: Sort headers.
8265         * dwarf2read.h: Sort headers.
8266         * dwarf2read.c: Sort headers.
8267         * dwarf2loc.c: Sort headers.
8268         * dwarf2expr.h: Sort headers.
8269         * dwarf2expr.c: Sort headers.
8270         * dwarf2-frame.c: Sort headers.
8271         * dwarf2-frame-tailcall.c: Sort headers.
8272         * dwarf-index-write.h: Sort headers.
8273         * dwarf-index-write.c: Sort headers.
8274         * dwarf-index-common.c: Sort headers.
8275         * dwarf-index-cache.h: Sort headers.
8276         * dwarf-index-cache.c: Sort headers.
8277         * dummy-frame.c: Sort headers.
8278         * dtrace-probe.c: Sort headers.
8279         * disasm.h: Sort headers.
8280         * disasm.c: Sort headers.
8281         * disasm-selftests.c: Sort headers.
8282         * dictionary.c: Sort headers.
8283         * dicos-tdep.c: Sort headers.
8284         * demangle.c: Sort headers.
8285         * dcache.h: Sort headers.
8286         * dcache.c: Sort headers.
8287         * darwin-nat.h: Sort headers.
8288         * darwin-nat.c: Sort headers.
8289         * darwin-nat-info.c: Sort headers.
8290         * d-valprint.c: Sort headers.
8291         * d-namespace.c: Sort headers.
8292         * d-lang.c: Sort headers.
8293         * ctf.c: Sort headers.
8294         * csky-tdep.c: Sort headers.
8295         * csky-linux-tdep.c: Sort headers.
8296         * cris-tdep.c: Sort headers.
8297         * cris-linux-tdep.c: Sort headers.
8298         * cp-valprint.c: Sort headers.
8299         * cp-support.c: Sort headers.
8300         * cp-namespace.c: Sort headers.
8301         * cp-abi.c: Sort headers.
8302         * corelow.c: Sort headers.
8303         * corefile.c: Sort headers.
8304         * continuations.c: Sort headers.
8305         * completer.h: Sort headers.
8306         * completer.c: Sort headers.
8307         * complaints.c: Sort headers.
8308         * coffread.c: Sort headers.
8309         * coff-pe-read.c: Sort headers.
8310         * cli-out.h: Sort headers.
8311         * cli-out.c: Sort headers.
8312         * charset.c: Sort headers.
8313         * c-varobj.c: Sort headers.
8314         * c-valprint.c: Sort headers.
8315         * c-typeprint.c: Sort headers.
8316         * c-lang.c: Sort headers.
8317         * buildsym.c: Sort headers.
8318         * buildsym-legacy.c: Sort headers.
8319         * build-id.h: Sort headers.
8320         * build-id.c: Sort headers.
8321         * btrace.c: Sort headers.
8322         * bsd-uthread.c: Sort headers.
8323         * breakpoint.h: Sort headers.
8324         * breakpoint.c: Sort headers.
8325         * break-catch-throw.c: Sort headers.
8326         * break-catch-syscall.c: Sort headers.
8327         * break-catch-sig.c: Sort headers.
8328         * blockframe.c: Sort headers.
8329         * block.c: Sort headers.
8330         * bfin-tdep.c: Sort headers.
8331         * bfin-linux-tdep.c: Sort headers.
8332         * bfd-target.c: Sort headers.
8333         * bcache.c: Sort headers.
8334         * ax-general.c: Sort headers.
8335         * ax-gdb.h: Sort headers.
8336         * ax-gdb.c: Sort headers.
8337         * avr-tdep.c: Sort headers.
8338         * auxv.c: Sort headers.
8339         * auto-load.c: Sort headers.
8340         * arm-wince-tdep.c: Sort headers.
8341         * arm-tdep.c: Sort headers.
8342         * arm-symbian-tdep.c: Sort headers.
8343         * arm-pikeos-tdep.c: Sort headers.
8344         * arm-obsd-tdep.c: Sort headers.
8345         * arm-nbsd-tdep.c: Sort headers.
8346         * arm-nbsd-nat.c: Sort headers.
8347         * arm-linux-tdep.c: Sort headers.
8348         * arm-linux-nat.c: Sort headers.
8349         * arm-fbsd-tdep.c: Sort headers.
8350         * arm-fbsd-nat.c: Sort headers.
8351         * arm-bsd-tdep.c: Sort headers.
8352         * arch-utils.c: Sort headers.
8353         * arc-tdep.c: Sort headers.
8354         * arc-newlib-tdep.c: Sort headers.
8355         * annotate.h: Sort headers.
8356         * annotate.c: Sort headers.
8357         * amd64-windows-tdep.c: Sort headers.
8358         * amd64-windows-nat.c: Sort headers.
8359         * amd64-tdep.c: Sort headers.
8360         * amd64-sol2-tdep.c: Sort headers.
8361         * amd64-obsd-tdep.c: Sort headers.
8362         * amd64-obsd-nat.c: Sort headers.
8363         * amd64-nbsd-tdep.c: Sort headers.
8364         * amd64-nbsd-nat.c: Sort headers.
8365         * amd64-nat.c: Sort headers.
8366         * amd64-linux-tdep.c: Sort headers.
8367         * amd64-linux-nat.c: Sort headers.
8368         * amd64-fbsd-tdep.c: Sort headers.
8369         * amd64-fbsd-nat.c: Sort headers.
8370         * amd64-dicos-tdep.c: Sort headers.
8371         * amd64-darwin-tdep.c: Sort headers.
8372         * amd64-bsd-nat.c: Sort headers.
8373         * alpha-tdep.c: Sort headers.
8374         * alpha-obsd-tdep.c: Sort headers.
8375         * alpha-nbsd-tdep.c: Sort headers.
8376         * alpha-mdebug-tdep.c: Sort headers.
8377         * alpha-linux-tdep.c: Sort headers.
8378         * alpha-linux-nat.c: Sort headers.
8379         * alpha-bsd-tdep.c: Sort headers.
8380         * alpha-bsd-nat.c: Sort headers.
8381         * aix-thread.c: Sort headers.
8382         * agent.c: Sort headers.
8383         * addrmap.c: Sort headers.
8384         * ada-varobj.c: Sort headers.
8385         * ada-valprint.c: Sort headers.
8386         * ada-typeprint.c: Sort headers.
8387         * ada-tasks.c: Sort headers.
8388         * ada-lang.c: Sort headers.
8389         * aarch64-tdep.c: Sort headers.
8390         * aarch64-ravenscar-thread.c: Sort headers.
8391         * aarch64-newlib-tdep.c: Sort headers.
8392         * aarch64-linux-tdep.c: Sort headers.
8393         * aarch64-linux-nat.c: Sort headers.
8394         * aarch64-fbsd-tdep.c: Sort headers.
8395         * aarch64-fbsd-nat.c: Sort headers.
8396         * aarch32-linux-nat.c: Sort headers.
8397
8398 2019-04-04  Tom Tromey  <tom@tromey.com>
8399
8400         * varobj.c (varobj_create): Update.
8401         * rust-exp.y (struct rust_parser) <update_innermost_block,
8402         lookup_symbol>: New methods.
8403         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8404         Rename.
8405         (rust_parser::rust_lookup_type)
8406         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8407         * printcmd.c (display_command, do_one_display): Update.
8408         * parser-defs.h (struct parser_state) <parser_state>: Add
8409         "tracker" parameter.
8410         (block_tracker): New member.
8411         (class innermost_block_tracker) <innermost_block_tracker>: Add
8412         "types" parameter.
8413         <reset>: Remove method.
8414         (innermost_block): Don't declare.
8415         (null_post_parser): Update.
8416         * parse.c (innermost_block): Remove global.
8417         (write_dollar_variable): Update.
8418         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8419         Remove "tracker_types" parameter.
8420         (parse_expression): Add "tracker" parameter.
8421         (parse_expression_for_completion): Update.
8422         (null_post_parser): Add "tracker" parameter.
8423         * p-exp.y: Update rules.
8424         * m2-exp.y: Update rules.
8425         * language.h (struct language_defn) <la_post_parser>: Add
8426         "tracker" parameter.
8427         * go-exp.y: Update rules.
8428         * f-exp.y: Update rules.
8429         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8430         parameter.
8431         * d-exp.y: Update rules.
8432         * c-exp.y: Update rules.
8433         * breakpoint.c (set_breakpoint_condition): Create an
8434         innermost_block_tracker.
8435         (watch_command_1): Likewise.
8436         * ada-lang.c (resolve): Add "tracker" parameter.
8437         (resolve_subexp): Likewise.
8438         * ada-exp.y (write_var_from_sym): Update.
8439
8440 2019-04-04  Tom Tromey  <tom@tromey.com>
8441
8442         * type-stack.h: New file.
8443         * type-stack.c: New file.
8444         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8445         type-stack.h.
8446         (insert_into_type_stack, insert_type, push_type, push_type_int)
8447         (insert_type_address_space, pop_type, pop_type_int)
8448         (pop_typelist, pop_type_stack, append_type_stack)
8449         (push_type_stack, get_type_stack, push_typelist)
8450         (follow_type_instance_flags, follow_types): Don't declare.
8451         * parse.c (type_stack): Remove global.
8452         (parse_exp_in_context): Update.
8453         (insert_into_type_stack, insert_type, push_type, push_type_int)
8454         (insert_type_address_space, pop_type, pop_type_int)
8455         (pop_typelist, pop_type_stack, append_type_stack)
8456         (push_type_stack, get_type_stack, push_typelist)
8457         (follow_type_instance_flags, follow_types): Remove (moved to
8458         type-stack.c).
8459         * f-exp.y (type_stack): New global.
8460         Update rules.
8461         (push_kind_type, f_parse): Update.
8462         * d-exp.y (type_stack): New global.
8463         Update rules.
8464         (d_parse): Update.
8465         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8466         Update rules.
8467         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8468         (HFILES_NO_SRCDIR): Add type-stack.h.
8469
8470 2019-04-04  Tom Tromey  <tom@tromey.com>
8471
8472         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8473         (rust_parser::convert_ast_to_expression, rust_parse)
8474         (rust_lex_test_completion, rust_lex_tests): Update.
8475         * parser-defs.h (struct expr_completion_state): New.
8476         (struct parser_state) <parser_state>: Add completion parameter.
8477         <mark_struct_expression, mark_completion_tag>: New methods.
8478         <parse_completion, m_completion_state>: New members.
8479         (prefixify_expression, null_post_parser): Update.
8480         (mark_struct_expression, mark_completion_tag): Don't declare.
8481         * parse.c (parse_completion, expout_last_struct)
8482         (expout_tag_completion_type, expout_completion_name): Remove
8483         globals.
8484         (parser_state::mark_struct_expression)
8485         (parser_state::mark_completion_tag): Now methods.
8486         (prefixify_expression): Add last_struct parameter.
8487         (prefixify_subexp): Likewise.
8488         (parse_exp_1): Update.
8489         (parse_exp_in_context): Add cstate parameter.  Update.
8490         (parse_expression_for_completion): Create an
8491         expr_completion_state.
8492         (null_post_parser): Add "completion" parameter.
8493         * p-exp.y: Update rules.
8494         (yylex): Update.
8495         * language.h (struct language_defn) <la_post_parser>: Add
8496         "completing" parameter.
8497         * go-exp.y: Update rules.
8498         (lex_one_token): Update.
8499         * expression.h (parse_completion): Don't declare.
8500         * d-exp.y: Update rules.
8501         (lex_one_token): Update rules.
8502         * c-exp.y: Update rules.
8503         (lex_one_token): Update.
8504         * ada-lang.c (resolve): Add "parse_completion" parameter.
8505         (resolve_subexp): Likewise.
8506         (ada_resolve_function): Likewise.
8507
8508 2019-04-04  Tom Tromey  <tom@tromey.com>
8509
8510         * parser-defs.h (struct parser_state) <start_arglist,
8511         end_arglist>: New methods.
8512         <arglist_len, m_funcall_chain>: New members.
8513         (arglist_len, start_arglist, end_arglist): Don't declare.
8514         * parse.c (arglist_len, funcall_chain): Remove global.
8515         (start_arglist, end_arglist): Remove functions.
8516         (parse_exp_in_context): Update.
8517         * p-exp.y: Update rules.
8518         * m2-exp.y: Update rules.
8519         * go-exp.y: Update rules.
8520         * f-exp.y: Update rules.
8521         * d-exp.y: Update rules.
8522         * c-exp.y: Update rules.
8523
8524 2019-04-04  Tom Tromey  <tom@tromey.com>
8525
8526         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8527         lex_operator, push_back>: New methods.
8528         Update all rules.
8529         (rust_parser::lex_hex, lex_escape): Rename and update.
8530         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8531         (rust_parser::lex_operator): Rename and update.
8532         (rust_parser::lex_number, rustyylex, rustyyerror)
8533         (rust_lex_test_init, rust_lex_test_sequence)
8534         (rust_lex_test_push_back, rust_lex_tests): Update.
8535         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8536         parameter.
8537         <lexptr, prev_lexptr>: New members.
8538         (lexptr, prev_lexptr): Don't declare.
8539         * parse.c (lexptr, prev_lexptr): Remove globals.
8540         (parse_exp_in_context): Update.
8541         * p-exp.y (yylex, yyerror): Update.
8542         * m2-exp.y (parse_number, yylex, yyerror): Update.
8543         * go-exp.y (lex_one_token, yyerror): Update.
8544         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8545         * d-exp.y (lex_one_token, yyerror): Update.
8546         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8547         (lex_one_token, yyerror): Update.
8548         * ada-lex.l (YY_INPUT): Update.
8549         (rewind_to_char): Update.
8550         * ada-exp.y (yyerror): Update.
8551
8552 2019-04-04  Tom Tromey  <tom@tromey.com>
8553
8554         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8555         * parser-defs.h (struct parser_state) <parser_state>: Add new
8556         parameter.
8557         <comma_terminates>: New member.
8558         (comma_terminates): Don't declare global.
8559         * parse.c (comma_terminates): Remove global.
8560         (parse_exp_in_context): Update.
8561         * p-exp.y (yylex): Update.
8562         * m2-exp.y (yylex): Update.
8563         * go-exp.y (lex_one_token): Update.
8564         * f-exp.y (yylex): Update.
8565         * d-exp.y (lex_one_token): Update.
8566         * c-exp.y (lex_one_token): Update.
8567         * ada-lex.l: Update.
8568
8569 2019-04-04  Tom Tromey  <tom@tromey.com>
8570
8571         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8572         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8573         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8574         * parser-defs.h (paren_depth): Don't declare.
8575         * parse.c (paren_depth): Remove global.
8576         (parse_exp_in_context): Update.
8577         * p-exp.y (paren_depth): New global.
8578         (pascal_parse): Initialize it.
8579         * m2-exp.y (paren_depth): New global.
8580         (m2_parse): Initialize it.
8581         * go-exp.y (paren_depth): New global.
8582         (go_parse): Initialize it.
8583         * f-exp.y (paren_depth): New global.
8584         (f_parse): Initialize it.
8585         * d-exp.y (paren_depth): New global.
8586         (d_parse): Initialize it.
8587         * c-exp.y (paren_depth): New global.
8588         (c_parse): Initialize it.
8589         * ada-lex.l (paren_depth): New global.
8590         (lexer_init): Initialize it.
8591
8592 2019-04-04  Tom Tromey  <tom@tromey.com>
8593
8594         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8595         (rust_parser::convert_ast_to_type)
8596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8597         * parser-defs.h (struct parser_state) <parser_state>: Add
8598         parameters.  Initialize new members.
8599         <expression_context_block, expression_context_pc>: New members.
8600         * parse.c (expression_context_block, expression_context_pc):
8601         Remove globals.
8602         (parse_exp_in_context): Update.
8603         * p-exp.y: Update all rules.
8604         (yylex): Update.
8605         * m2-exp.y: Update all rules.
8606         (yylex): Update.
8607         * go-exp.y (yylex): Update.
8608         * f-exp.y (yylex): Update.
8609         * d-exp.y: Update all rules.
8610         (yylex): Update.
8611         * c-exp.y: Update all rules.
8612         (lex_one_token, classify_name, yylex, c_parse): Update.
8613         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8614
8615 2019-04-04  Tom Tromey  <tom@tromey.com>
8616
8617         * gdbarch.h, gdbarch.c: Rebuild.
8618         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8619         * stap-probe.h:
8620         (struct stap_parse_info): Replace "parser_state" with
8621         "expr_builder".
8622         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8623         (parser_state): New class.
8624         * parse.c (expr_builder): Rename.
8625         (expr_builder::release): Rename.
8626         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8627         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8628         (write_exp_elt_longcst, write_exp_elt_floatcst)
8629         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8630         (write_exp_string_vector, write_exp_bitstring)
8631         (write_exp_msymbol, mark_struct_expression)
8632         (write_dollar_variable)
8633         (insert_type_address_space, increase_expout_size): Replace
8634         "parser_state" with "expr_builder".
8635         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8636         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8637         "parser_state" with "expr_builder".
8638
8639 2019-04-04  Tom Tromey  <tom@tromey.com>
8640
8641         * rust-exp.y: Replace "parse_language" with method call.
8642         * p-exp.y:
8643         (yylex): Replace "parse_language" with method call.
8644         * m2-exp.y:
8645         (yylex): Replace "parse_language" with method call.
8646         * go-exp.y (classify_name): Replace "parse_language" with method
8647         call.
8648         * f-exp.y (yylex): Replace "parse_language" with method call.
8649         * d-exp.y (lex_one_token): Replace "parse_language" with method
8650         call.
8651         * c-exp.y:
8652         (lex_one_token, classify_name, yylex): Replace "parse_language"
8653         with method call.
8654         * ada-exp.y (find_primitive_type, type_char)
8655         (type_system_address): Replace "parse_language" with method call.
8656
8657 2019-04-04  Tom Tromey  <tom@tromey.com>
8658
8659         * rust-exp.y: Replace "parse_gdbarch" with method call.
8660         * parse.c (write_dollar_variable, insert_type_address_space):
8661         Replace "parse_gdbarch" with method call.
8662         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8663         call.
8664         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8665         call.
8666         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8667         "parse_gdbarch" with method call.
8668         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8669         with method call.
8670         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8671         "parse_gdbarch" with method call.
8672         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8673         "parse_gdbarch" with method call.
8674         * c-exp.y (parse_type, parse_number, classify_name): Replace
8675         "parse_gdbarch" with method call.
8676         * ada-lex.l: Replace "parse_gdbarch" with method call.
8677         * ada-exp.y (parse_type, find_primitive_type, type_char)
8678         (type_system_address): Replace "parse_gdbarch" with method call.
8679
8680 2019-04-04  Tom Tromey  <tom@tromey.com>
8681
8682         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8683         * stap-probe.c (stap_parse_argument): Update.
8684         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8685         initial_size parameter.
8686         * rust-exp.y (rust_lex_tests): Update.
8687         * parse.c (parser_state): Update.
8688         (parse_exp_in_context): Update.
8689         * parser-defs.h (struct parser_state) <parser_state>: Remove
8690         "initial_size" parameter.
8691
8692 2019-04-04  Tom Tromey  <tom@tromey.com>
8693
8694         * parser-defs.h (increase_expout_size): Don't declare.
8695         * parse.c (increase_expout_size): Now static.
8696
8697 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8698
8699         * gnu-nat.c (gnu_nat_target::wait): Fix
8700         target_waitstatus_to_string call.
8701
8702 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8703
8704         * eval.c (evaluate_subexp_standard): Handle internal functions
8705         during Fortran function call handling.
8706
8707 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8708
8709         * NEWS: Mention new internal functions.
8710         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8711         (read_base_type): Use dwarf2_init_complex_target_type.
8712         * value.c (creal_internal_fn): New function.
8713         (cimag_internal_fn): New function.
8714         (_initialize_values): Register new internal functions.
8715
8716 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8717
8718         * infrun.c (stop_all_threads): If debug_infrun, always
8719         trace the wait status after wait_one, using
8720         target_waitstatus_to_string and target_pid_to_str.
8721         (handle_inferior_event): Replace various trace of
8722         wait status kind by a single trace.
8723         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8724         wait status kind image by target_waitstatus_to_string.
8725         * target/waitstatus.c (target_waitstatus_to_string): Fix
8726         obsolete comment.
8727
8728 2019-04-01  Tom Tromey  <tromey@adacore.com>
8729
8730         PR symtab/23331:
8731         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8732
8733 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8734             Pedro Alves  <palves@redhat.com>
8735
8736         * top.c (quit_force): Call 'finalize_values'.
8737         * value.c (finalize_values): New function.
8738         * value.h (finalize_values): Declare.
8739
8740 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8741
8742         * NEWS: Announce $_gdb_major and $_gdb_minor.
8743
8744         * top.c (init_gdb_version_vars): New function.
8745         (gdb_init): Call init_gdb_version_vars.
8746
8747 2019-03-29  Tom Tromey  <tromey@adacore.com>
8748
8749         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8750         help text.  Remove dead code.
8751
8752 2019-03-29  Keith Seitz  <keiths@redhat.com>
8753
8754         From Siddhesh Poyarekar:
8755         * f-lang.h (f77_get_upperbound): Return LONGEST.
8756         (f77_get_lowerbound): Likewise.
8757         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8758         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8759         print them.
8760         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8761         plongest to format print it.
8762         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8763         (f77_get_upperbound): Likewise.
8764         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8765         LOWER_BOUND to LONGEST.
8766         (f77_create_arrayprint_offset_tbl): Likewise.
8767
8768 2019-03-29  Keith Seitz  <keiths@redhat.com>
8769
8770         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8771         %s/pulongest for TYPE_LENGTH instead of %d in format
8772         strings.
8773         * ada-typerint.c (ada_print_type): Likewise.
8774         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8775         * compile/compile-c-support.c (generate_register_struct): Likewise.
8776         * gdbtypes.c (recursive_dump_type): Likewise.
8777         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8778         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8779         instead of %d in format strings.
8780         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8781         to std::min to ULONGEST.
8782         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8783         instead of %d in format strings.
8784         * tracepoint.c (info_scope_command): Likewise.
8785         * typeprint.c (print_offset_data::update)
8786         (print_offset_data::finish): Likewise.
8787         * xtensa-tdep.c (xtensa_store_return_value)
8788         (xtensa_push_dummy_call): Likewise.
8789
8790 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8791
8792         * windows-nat.c (display_selector): Fixed format specifications
8793         for 64-bit Cygwin.
8794
8795 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8798
8799 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8800
8801         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8802         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8803         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8804         (nios2_linux_init_abi): Install it.
8805
8806 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8807
8808         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8809
8810 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8811
8812         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8813
8814 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8815             Tom Tromey  <tromey@adacore.com>
8816
8817         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8818
8819 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8820
8821         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8822         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8823         method to compute the bounds of range types. Also print "[evaluated]"
8824         if the bounds' values come from a dynamic evaluation.
8825
8826 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8829         whitespace when pretty printing is on.
8830
8831 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8832
8833         * ppc-linux-nat.c: Add include.
8834
8835 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8836
8837         * NEWS: Mention AArch64 Pointer Authentication.
8838
8839 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8840
8841         * arm-linux-nat.c: Add include.
8842
8843 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8844
8845         * source-cache.c (source_cache::get_source_lines): Re-read
8846         fullname after calling open_source_file.
8847
8848 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8849
8850         * NEWS: Mention TLS support for FreeBSD.
8851
8852 2019-03-25  Tom Tromey  <tromey@adacore.com>
8853
8854         * minsyms.c (BUNCH_SIZE): Update comment.
8855         (~minimal_symbol_reader): Remove old comment.
8856         (compact_minimal_symbols): Update comment.
8857         (minimal_symbol_reader::install): Remove old comment.  Update
8858         other comments.
8859
8860 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8861
8862         * s390-linux-nat.c: Add include.
8863
8864 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8865
8866         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8867         Call linux_get_hwcap.
8868         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8869         Likewise.
8870         (aarch64_linux_get_hwcap): Remove function.
8871         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8872         declaration.
8873         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8874         linux_get_hwcap.
8875         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8876         * linux-tdep.c (linux_get_hwcap): Add function.
8877         (linux_get_hwcap2): Likewise.
8878         * linux-tdep.h (linux_get_hwcap): Add declaration.
8879         (linux_get_hwcap2): Likewise.
8880         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8881         (ppc_linux_get_hwcap2): Likewise.
8882         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8883         linux_get_hwcap.
8884         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8885         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8886         (ppc_linux_nat_target::read_description): Likewise.
8887         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8888         * s390-linux-nat.c: Likewise.
8889         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8890
8891 2019-03-24  Tom Tromey  <tom@tromey.com>
8892
8893         * ada-lang.c (standard_lookup): Simplify initialization.
8894         (ada_lookup_symbol_nonlocal): Simplify return.
8895         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8896         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8897         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8898         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8899         initialization.
8900         * solib.c (solib_global_lookup): Simplify.
8901         * symtab.c (null_block_symbol): Remove.
8902         (symbol_cache_lookup): Simplify returns.
8903         (lookup_language_this): Simplify returns.
8904         (lookup_symbol_aux): Simplify return.
8905         (lookup_local_symbol): Simplify returns.
8906         (lookup_global_symbol_from_objfile): Simplify return.
8907         (lookup_symbol_in_objfile_symtabs)
8908         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8909         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8910         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8911         * cp-namespace.c (cp_lookup_bare_symbol)
8912         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8913         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8914         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8915         (cp_lookup_symbol_via_imports): Simplify initialization.
8916         (find_symbol_in_baseclass): Likewise.
8917         * symtab.h (null_block_symbol): Remove.
8918         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8919         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8920         (d_lookup_symbol_module): Likewise.
8921         (find_symbol_in_baseclass): Simplify initialization.
8922
8923 2019-03-24  Tom Tromey  <tom@tromey.com>
8924
8925         * expression.h: Don't include symtab.h.
8926         (struct block): Forward declare.
8927
8928 2019-03-24  Tom Tromey  <tom@tromey.com>
8929
8930         * c-exp.y (typebase): Remove casts.
8931         * gdbtypes.c (lookup_unsigned_typename, )
8932         (lookup_signed_typename): Remove cast.
8933         * eval.c (parse_to_comma_and_eval): Remove cast.
8934         * parse.c (write_dollar_variable): Remove cast.
8935         * block.h (struct block) <superblock>: Now const.
8936         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8937         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8938         (map_block): Make "block" const.
8939         * symfile.h (struct quick_symbol_functions)
8940         <map_matching_symbols>: Constify block argument to "callback".
8941         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8942         const.
8943         (find_pc_sect_compunit_symtab): Make "b" const.
8944         (find_symbol_at_address): Likewise.
8945         (search_symbols): Likewise.
8946         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8947         (dw2_debug_names_lookup_symbol): Likewise.
8948         (dw2_map_matching_symbols): Update.
8949         * p-valprint.c (pascal_val_print): Remove "block".
8950         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8951         (aux_add_nonlocal_symbols): Make "block" const.
8952         (resolve_subexp): Remove cast.
8953         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8954         const.
8955         (iterate_over_file_blocks): Likewise.
8956         * f-exp.y (%union) <bval>: Remove.
8957         * coffread.c (patch_opaque_types): Make "b" const.
8958         * spu-tdep.c (spu_catch_start): Make "block" const.
8959         * c-valprint.c (print_unpacked_pointer): Remove "block".
8960         * symmisc.c (dump_symtab_1): Make "b" const.
8961         (block_depth): Make "block" const.
8962         * d-exp.y (%union) <bval>: Remove.
8963         * cp-support.h (cp_lookup_rtti_type): Update.
8964         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8965         * psymtab.c (psym_lookup_symbol): Make "block" const.
8966         (maintenance_check_psymtabs): Make "b" const.
8967         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8968         (enumerate_locals, enumerate_args): Update.
8969         * python/py-symtab.c (stpy_global_block): Make "block" const.
8970         (stpy_static_block): Likewise.
8971         * inline-frame.c (block_starting_point_at): Make "new_block"
8972         const.
8973         * block.c (find_block_in_blockvector): Make return type const.
8974         (blockvector_for_pc_sect): Make "b" const.
8975         (find_block_in_blockvector): Make "b" const.
8976
8977 2019-03-23  Tom Tromey  <tom@tromey.com>
8978
8979         * varobj.c (varobj_create): Update.
8980         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8981         * printcmd.c (display_command, do_one_display): Don't reset
8982         innermost_block.
8983         * parser-defs.h (enum innermost_block_tracker_type): Move to
8984         expression.h.
8985         (innermost_block): Update comment.
8986         * parse.c (parse_exp_1): Add tracker_types parameter.
8987         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8988         tracker_types parameter.  Reset innermost_block.
8989         (parse_exp_in_context): Remove.
8990         (parse_expression_for_completion): Update.
8991         * objfiles.c (~objfile): Don't reset expression_context_block or
8992         innermost_block.
8993         * expression.h (enum innermost_block_tracker_type): Move from
8994         parser-defs.h.
8995         (parse_exp_1): Add tracker_types parameter.
8996         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8997         reset innermost_block.
8998
8999 2019-03-23  Tom Tromey  <tom@tromey.com>
9000
9001         * objfiles.h: Include bcache.h.
9002
9003 2019-03-23  Tom Tromey  <tom@tromey.com>
9004
9005         * linespec.c (get_current_search_block): Use
9006         scoped_restore_current_language.
9007         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9008
9009 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9010             Jiong Wang  <jiong.wang@arm.com>
9011
9012         * aarch64-linux-tdep.c
9013         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9014         section.
9015         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9016
9017 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9018             Jiong Wang  <jiong.wang@arm.com>
9019
9020         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9021         instructions.
9022         (aarch64_analyze_prologue_test): Add PACIASP test.
9023         (aarch64_prologue_prev_register): Unmask PC value.
9024
9025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9026             Jiong Wang  <jiong.wang@arm.com>
9027
9028         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9029         (aarch64_dwarf2_prev_register): Unmask PC value.
9030         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9031         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9032         DW_CFA_AARCH64_negate_ra_state.
9033         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9034
9035 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9036             Jiong Wang  <jiong.wang@arm.com>
9037
9038         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9039         registers.
9040         (aarch64_pseudo_register_name): Likewise.
9041         (aarch64_pseudo_register_type): Likewise.
9042         (aarch64_pseudo_register_reggroup_p): Likewise.
9043         (aarch64_gdbarch_init): Add pauth registers.
9044         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9045         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9046         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9047         (struct gdbarch_tdep): Add regnum for ra_state.
9048
9049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9050             Jiong Wang  <jiong.wang@arm.com>
9051
9052         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9053
9054 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9055             Jiong Wang  <jiong.wang@arm.com>
9056
9057         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9058         function.
9059         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9060         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9061         (aarch64_gdbarch_init): Add puth registers.
9062         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9063         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9064         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9065
9066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9067             Jiong Wang  <jiong.wang@arm.com>
9068
9069         * aarch64-linux-nat.c
9070         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9071         * aarch64-linux-tdep.c
9072         (aarch64_linux_core_read_description): Likewise.
9073         (aarch64_linux_get_hwcap): New function.
9074         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9075         (aarch64_linux_get_hwcap): New declaration.
9076
9077 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9078             Jiong Wang  <jiong.wang@arm.com>
9079
9080         * aarch64-linux-nat.c
9081         (aarch64_linux_nat_target::read_description): Add pauth param.
9082         * aarch64-linux-tdep.c
9083         (aarch64_linux_core_read_description): Likewise.
9084         * aarch64-tdep.c (struct target_desc): Add in pauth.
9085         (aarch64_read_description): Add pauth param.
9086         (aarch64_gdbarch_init): Likewise.
9087         * aarch64-tdep.h (aarch64_read_description): Likewise.
9088         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9089         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9090         * features/Makefile: Add new files.
9091         * features/aarch64-pauth.c: New file.
9092         * features/aarch64-pauth.xml: New file.
9093
9094 2019-03-20  Tom Tromey  <tromey@adacore.com>
9095
9096         * infrun.c (handle_inferior_event): Rename from
9097         handle_inferior_event_1.  Create a scoped_value_mark.
9098         (handle_inferior_event): Remove.
9099
9100 2019-03-19  Tom Tromey  <tromey@adacore.com>
9101
9102         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9103         * infrun.h (print_stop_event): Add "displays" parameter.
9104         * infrun.c (print_stop_event): Add "displays" parameter.
9105
9106 2019-03-19  Pedro Alves  <palves@redhat.com>
9107
9108         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9109         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9110         to -1.  Fix TABs vs spaces.
9111         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9112         * tui/tui-out.h (tui_ui_out) Add intro comments.
9113         <m_line, m_start_of_line>: In-class initialize, and add describing
9114         comment.
9115
9116 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9117
9118         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9119         variable names.
9120         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9121
9122 2019-03-18  Pedro Alves  <palves@redhat.com>
9123             Eli Zaretskii <eliz@gnu.org>
9124
9125         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9126         m_line and m_start_of_line.
9127
9128 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9129
9130         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9131         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9132         it returns a newline.  This fixes a regression in TU mode, whereby
9133         the next line is output on the same screen line as the user input.
9134
9135 2019-03-18  Tom Tromey  <tromey@adacore.com>
9136
9137         * minsyms.c (minimal_symbol_reader::install): Remove call to
9138         obstack_blank.
9139
9140 2019-03-18  Pedro Alves  <palves@redhat.com>
9141
9142         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9143         New globals.
9144         (apply_style): New, factored out from ...
9145         (apply_ansi_escape): ... this.  Handle reverse video mode.
9146         (tui_set_reverse_mode): New function.
9147         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9148         * tui/tui-winsource.c (tui_show_source_line): Use
9149         tui_set_reverse_mode instead of setting A_STANDOUT.
9150         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9151         New setter methods.
9152
9153 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9154
9155         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9156         Handle tabs.
9157
9158 2019-03-18  Tom Tromey  <tromey@adacore.com>
9159
9160         * ada-lang.c (empty_array): Add "high" parameter.
9161         (ada_evaluate_subexp): Update.
9162
9163 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9164
9165         * unittests/string_view-selftests.c: Define
9166         _initialize_string_view_selftests unconditionally.
9167
9168 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9169
9170         PR gdb/24350
9171         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9172
9173 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9174
9175         PR gdb/24351
9176         * windows-nat.c (display_selector): Fix format specifiers.
9177
9178 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9179
9180         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9181         tui_refill_source_window instead of tui_refresh_win, to update the
9182         current execution line.  This fixes redisplay of the current line
9183         when stepping through the code with "next" or "step".
9184
9185 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9186
9187         * source-cache.c (source_cache::get_source_lines): Call
9188         find_source_lines to initialize s->nlines.  This fixes vertical
9189         scrolling of TUI source window when the DOWN arrow is pressed.
9190
9191 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9192
9193         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9194         linux-thread-db.c (_initialize_thread_db): Likewise.
9195
9196 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9197
9198         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9199         wclrtoeol in tui_show_source_line".  This reverts changes made in
9200         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9201
9202 2019-03-15  Tom Tromey  <tom@tromey.com>
9203
9204         * symtab.h (struct minimal_symbol): Derive from
9205         general_symbol_info.
9206         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9207         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9208         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9209         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9210         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9211         (MSYMBOL_SEARCH_NAME): Update.
9212         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9213         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9214         * minsyms.c (minimal_symbol_reader::record_full): Update.
9215
9216 2019-03-15  Tom Tromey  <tom@tromey.com>
9217
9218         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9219
9220 2019-03-15  Tom Tromey  <tom@tromey.com>
9221
9222         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9223         unique_xmalloc_ptr.
9224         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9225         Update.
9226         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9227         (build_minimal_symbol_hash_tables)
9228         (minimal_symbol_reader::install): Update.
9229
9230 2019-03-15  Tom Tromey  <tom@tromey.com>
9231
9232         * symtab.c (create_demangled_names_hash): Update.
9233         (symbol_set_names): Update.
9234         * objfiles.h (struct objfile_per_bfd_storage)
9235         <demangled_names_hash>: Now an htab_up.
9236         * objfiles.c (objfile_per_bfd_storage): Simplify.
9237
9238 2019-03-15  Tom Tromey  <tom@tromey.com>
9239
9240         * objfiles.h (struct objfile_per_bfd_storage): Declare
9241         destructor.
9242         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9243         New.
9244         (get_objfile_bfd_data): Use new.  Don't initialize
9245         language_of_main.
9246         (free_objfile_per_bfd_storage): Remove.
9247         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9248
9249 2019-03-15  Tom Tromey  <tom@tromey.com>
9250
9251         * symfile.c (reread_symbols): Update.
9252         * objfiles.c (objfile::objfile): Update.
9253         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9254         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9255         comment.
9256         (minimal_symbol_reader::install): Update.
9257         (terminate_minimal_symbol_table): Remove.
9258         * jit.c (jit_object_close_impl): Update.
9259
9260 2019-03-15  Tom Tromey  <tom@tromey.com>
9261
9262         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9263         initializations.
9264
9265 2019-03-15  Tom Tromey  <tom@tromey.com>
9266
9267         * objfiles.h (struct objfile_per_bfd_storage)
9268         <demangled_hash_languages>: Now a bitset.
9269         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9270         (lookup_minimal_symbol): Update.
9271
9272 2019-03-15  Tom Tromey  <tom@tromey.com>
9273
9274         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9275         Don't return the symbol.
9276         * coffread.c (record_minimal_symbol): Use record_full.
9277
9278 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9279
9280         The MS-Windows port of ncurses fails to switch to a color pair if
9281         one or both of the colors are the implicit default colors.  This
9282         change records the default colors when TUI is initialized, and
9283         then specifies them explicitly when a color pair uses the default
9284         colors.  This allows color styling in TUI mode on MS-Windows.
9285
9286         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9287         ncurses_norm_attr.
9288         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9289         colors in ncurses_norm_attr.
9290         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9291         "none", replace it with the default color recorded in
9292         ncurses_norm_attr.
9293
9294 2019-03-14  Tom Tromey  <tromey@adacore.com>
9295
9296         * source-cache.h (class source_cache) <get_source_lines>: Return
9297         std::string.
9298         * source-cache.c (source_cache::extract_lines): Handle case where
9299         first_pos==npos.  Return std::string.
9300         (source_cache::get_source_lines): Update.
9301
9302 2019-03-14  Tom Tromey  <tromey@adacore.com>
9303
9304         * NEWS: Add item for "style sources" commands.
9305         * source-cache.c (source_cache::get_source_lines): Check
9306         source_styling.
9307         * cli/cli-style.c (source_styling): New global.
9308         (_initialize_cli_style): Add "style sources" commands.
9309         (show_style_sources): New function.
9310         * cli/cli-style.h (source_styling): Declare.
9311
9312 2019-03-14  Pedro Alves  <palves@redhat.com>
9313             Tom Tromey  <tromey@adacore.com>
9314
9315         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9316         * tui/tui-winsource.c (tui_refill_source_window): New function,
9317         from...
9318         (tui_horizontal_source_scroll): ... here.  Move some logic.
9319         * cli/cli-style.c (set_style_enabled): Notify new observable.
9320         * tui/tui-hooks.c (tui_redisplay_source): New function.
9321         (tui_attach_detach_observers): Attach or detach
9322         tui_redisplay_source.
9323         * observable.h (source_styling_changed): New observable.
9324         * observable.c: Define source_styling_changed observable.
9325
9326 2019-03-13  Tom Tromey  <tromey@adacore.com>
9327
9328         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9329         (i386_gnu_nat_target::store_registers): Update.
9330         * target-debug.h (target_debug_print_std_string): New macro.
9331         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9332         * windows-tdep.c (display_one_tib): Update.
9333         * tui/tui-stack.c (tui_make_status_line): Update.
9334         * top.c (print_inferior_quit_action): Update.
9335         * thread.c (thr_try_catch_cmd): Update.
9336         (add_thread_with_info): Update.
9337         (thread_target_id_str): Update.
9338         (thr_try_catch_cmd): Update.
9339         (thread_command): Update.
9340         (thread_find_command): Update.
9341         * record-btrace.c (record_btrace_target::info_record)
9342         (record_btrace_resume_thread, record_btrace_target::resume)
9343         (record_btrace_cancel_resume, record_btrace_step_thread)
9344         (record_btrace_target::wait, record_btrace_target::wait)
9345         (record_btrace_target::wait, record_btrace_target::stop): Update.
9346         * progspace.c (print_program_space): Update.
9347         * process-stratum-target.c
9348         (process_stratum_target::thread_address_space): Update.
9349         * linux-fork.c (linux_fork_mourn_inferior)
9350         (detach_checkpoint_command, info_checkpoints_command)
9351         (linux_fork_context): Update.
9352         (linux_fork_detach): Update.
9353         (class scoped_switch_fork_info): Update.
9354         (delete_checkpoint_command): Update.
9355         * infrun.c (follow_fork_inferior): Update.
9356         (follow_fork_inferior): Update.
9357         (proceed_after_vfork_done): Update.
9358         (handle_vfork_child_exec_or_exit): Update.
9359         (follow_exec): Update.
9360         (displaced_step_prepare_throw): Update.
9361         (displaced_step_restore): Update.
9362         (start_step_over): Update.
9363         (resume_1): Update.
9364         (clear_proceed_status_thread): Update.
9365         (proceed): Update.
9366         (print_target_wait_results): Update.
9367         (do_target_wait): Update.
9368         (context_switch): Update.
9369         (stop_all_threads): Update.
9370         (restart_threads): Update.
9371         (finish_step_over): Update.
9372         (handle_signal_stop): Update.
9373         (switch_back_to_stepped_thread): Update.
9374         (keep_going_pass_signal): Update.
9375         (print_exited_reason): Update.
9376         (normal_stop): Update.
9377         * inferior.c (inferior_pid_to_str): Change return type.
9378         (print_selected_inferior): Update.
9379         (add_inferior): Update.
9380         (detach_inferior): Update.
9381         * dummy-frame.c (fprint_dummy_frames): Update.
9382         * dcache.c (dcache_info_1): Update.
9383         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9384         (btrace_fetch, btrace_clear): Update.
9385         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9386         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9387         type.
9388         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9389         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9390         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9391         * gdbarch.c, gdbarch.h: Rebuild.
9392         * gdbarch.sh (core_pid_to_str): Change return type.
9393         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9394         return type.
9395         (windows_nat_target::pid_to_str): Change return type.
9396         (windows_delete_thread): Update.
9397         (windows_nat_target::attach): Update.
9398         (windows_nat_target::files_info): Update.
9399         * target-delegates.c: Rebuild.
9400         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9401         return type.
9402         (sol_thread_target::pid_to_str): Change return type.
9403         * remote.c (class remote_target) <pid_to_str>: Change return
9404         type.
9405         (remote_target::pid_to_str): Change return type.
9406         (extended_remote_target::attach, remote_target::remote_stop_ns)
9407         (remote_target::remote_notif_remove_queued_reply)
9408         (remote_target::push_stop_reply, remote_target::disable_btrace):
9409         Update.
9410         (extended_remote_target::attach): Update.
9411         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9412         type.
9413         (gdbsim_target::pid_to_str): Change return type.
9414         * ravenscar-thread.c (struct ravenscar_thread_target)
9415         <pid_to_str>: Change return type.
9416         (ravenscar_thread_target::pid_to_str): Change return type.
9417         * procfs.c (class procfs_target) <pid_to_str>: Change return
9418         type.
9419         (procfs_target::pid_to_str): Change return type.
9420         (procfs_target::attach): Update.
9421         (procfs_target::detach): Update.
9422         (procfs_target::fetch_registers): Update.
9423         (procfs_target::store_registers): Update.
9424         (procfs_target::wait): Update.
9425         (procfs_target::files_info): Update.
9426         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9427         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9428         return type.
9429         (nto_procfs_target::pid_to_str): Change return type.
9430         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9431         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9432         return type.
9433         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9434         (exit_lwp): Update.
9435         (attach_proc_task_lwp_callback, get_detach_signal)
9436         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9437         (linux_nat_target::resume, wait_lwp, stop_callback)
9438         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9439         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9440         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9441         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9442         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9443         type.
9444         (inf_ptrace_target::attach): Update.
9445         (inf_ptrace_target::files_info): Update.
9446         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9447         type.
9448         (go32_nat_target::pid_to_str): Change return type.
9449         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9450         (gnu_nat_target::wait): Update.
9451         (gnu_nat_target::wait): Update.
9452         (gnu_nat_target::resume): Update.
9453         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9454         (fbsd_nat_target::wait): Update.
9455         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9456         type.
9457         (darwin_nat_target::attach): Update.
9458         * corelow.c (class core_target) <pid_to_str>: Change return type.
9459         (core_target::pid_to_str): Change return type.
9460         * target.c (normal_pid_to_str): Change return type.
9461         (default_pid_to_str): Likewise.
9462         (target_pid_to_str): Change return type.
9463         (target_translate_tls_address): Update.
9464         (target_announce_detach): Update.
9465         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9466         return type.
9467         (bsd_uthread_target::pid_to_str): Change return type.
9468         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9469         type.
9470         (bsd_kvm_target::pid_to_str): Change return type.
9471         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9472         return type.
9473         (aix_thread_target::pid_to_str): Change return type.
9474         * target.h (struct target_ops) <pid_to_str>: Change return type.
9475         (target_pid_to_str, normal_pid_to_str): Likewise.
9476         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9477         type.
9478         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9479         type.
9480         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9481         return type.
9482         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9483         type.
9484         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9485         type.
9486         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9487         return type.
9488
9489 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9490
9491         * NEWS: Mention that the new default MI version is 3.  Mention
9492         changes to the output of commands and events that deal with
9493         multi-location breakpoints.
9494         * breakpoint.c: Include "mi/mi-out.h".
9495         (print_one_breakpoint): Change output syntax if using MI version
9496         >= 3.
9497         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9498         New.
9499         (mi_multi_location_breakpoint_output_fixed): New.
9500         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9501         (mi_cmd_fix_multi_location_breakpoint_output): New.
9502         (mi_multi_location_breakpoint_output_fixed): New.
9503         * mi/mi-cmds.c (mi_cmds): Register command
9504         -fix-multi-location-breakpoint-output.
9505         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9506         interpreter "mi".
9507
9508 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9509
9510         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9511         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9512         instantiate mi_ui_out based on interpreter name.
9513         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9514         * mi/mi-main.c (mi_load_progress): Likewise.
9515
9516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9517
9518         * NEWS: Combine separate "New targets" sections for 8.3.
9519
9520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9521
9522         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9523         (ppcfbsd_init_abi): Install gdbarch
9524         "fetch_tls_load_module_address" and "get_thread_local_address"
9525         methods.
9526
9527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9528
9529         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9530         (riscv_fbsd_init_abi): Install gdbarch
9531         "fetch_tls_load_module_address" and "get_thread_local_address"
9532         methods.
9533
9534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9535
9536         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9537         (i386fbsd_init_abi): Install gdbarch
9538         "fetch_tls_load_module_address" and "get_thread_local_address"
9539         methods.
9540
9541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9542
9543         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9544         (amd64fbsd_init_abi): Install gdbarch
9545         "fetch_tls_load_module_address" and "get_thread_local_address"
9546         methods.
9547
9548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9549
9550         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9551         (struct fbsd_pspace_data): New type.
9552         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9553         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9554         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9555         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9556         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9557
9558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9559
9560         * gdbtypes.c (lookup_struct_elt): New function.
9561         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9562         * gdbtypes.h (struct struct_elt): New type.
9563         (lookup_struct_elt): New prototype.
9564
9565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9566
9567         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9568         remove disabled code block.
9569
9570 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9571
9572         * gdbarch.sh (get_thread_local_address): New method.
9573         * gdbarch.h, gdbarch.c: Regenerate.
9574         * target.c (target_translate_tls_address): Use
9575         gdbarch_get_thread_local_address if present instead of
9576         target::get_thread_local_address.
9577
9578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9579
9580         * target.h (target::get_thread_local_address): Update comment.
9581
9582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9583
9584         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9585         objfile->separate_debug_objfile_backlink if not NULL.
9586
9587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9588
9589         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9590         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9591         (amd64bsd_store_inferior_registers): Likewise.
9592         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9593         Enable segment base registers.
9594         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9595         PT_GETFSBASE and PT_GETGSBASE.
9596         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9597         PT_SETGSBASE.
9598         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9599         segment base registers.
9600         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9601
9602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9603
9604         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9605         Update calls to i386_target_description to add 'segments'
9606         parameter.
9607         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9608         add segment base registers.
9609         * arch/i386.c (i386_create_target_description): Add 'segments'
9610         parameter to enable segment base registers.
9611         * arch/i386.h (i386_create_target_description): Likewise.
9612         * features/i386/32bit-segments.xml: New file.
9613         * features/i386/32bit-segments.c: Generate.
9614         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9615         call to i386_target_description to add 'segments' parameter.
9616         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9617         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9618         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9619         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9620         if feature is present.
9621         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9622         Add 'segments' parameter to call to i386_target_description.
9623         (i386_target_description): Add 'segments' parameter to enable
9624         segment base registers.
9625         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9626         to call to i386_target_description.
9627         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9628         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9629         Define I386_NUM_REGS.
9630         (i386_target_description): Add 'segments' parameter to enable
9631         segment base registers.
9632
9633 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9634
9635         PR/24325
9636         * source-cache.c: #undef open and close, to avoid unresolved
9637         externals during linking.
9638
9639 2019-03-12  Tom Tromey  <tromey@adacore.com>
9640
9641         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9642         const.  Add initializers.
9643         (_initialize_remote): Don't initialize ptid globals.
9644
9645 2019-03-12  Pedro Alves  <palves@redhat.com>
9646
9647         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9648
9649 2019-03-12  Pedro Alves  <palves@redhat.com>
9650
9651         * cp-name-parser.y (main): Remove unused 'len' variable.
9652
9653 2019-03-12  Tom Tromey  <tromey@adacore.com>
9654
9655         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9656         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9657
9658 2019-03-12  Tom Tromey  <tromey@adacore.com>
9659
9660         * linux-nat.c (iterate_over_lwps): Update.
9661         (stop_callback): Remove parameter.
9662         (stop_wait_callback, detach_callback, resume_set_callback)
9663         (select_singlestep_lwp_callback, set_ignore_sigint)
9664         (status_callback, resumed_callback, resume_clear_callback)
9665         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9666         data parameter.
9667         (linux_nat_target::detach, linux_nat_target::resume)
9668         (linux_stop_and_wait_all_lwps, select_event_lwp)
9669         (linux_nat_filter_event, linux_nat_wait_1)
9670         (linux_nat_target::kill, linux_nat_target::stop)
9671         (linux_nat_target::stop): Update.
9672         (linux_nat_resume_callback): Change type.
9673         (resume_stopped_resumed_lwps, count_events_callback)
9674         (select_event_lwp_callback): Likewise.
9675         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9676         * arm-linux-nat.c (struct update_registers_data): Remove.
9677         (update_registers_callback): Change type.
9678         (arm_linux_insert_hw_breakpoint1): Update.
9679         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9680         parameter.
9681         (x86_linux_dr_set_addr): Update.
9682         (x86_linux_dr_set_control): Update.
9683         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9684         (iterate_over_lwps): Use gdb::function_view.
9685         * nat/aarch64-linux-hw-point.c (struct
9686         aarch64_dr_update_callback_param): Remove.
9687         (debug_reg_change_callback): Change type.
9688         (aarch64_notify_debug_reg_change): Update.
9689         * s390-linux-nat.c (s390_refresh_per_info): Update.
9690
9691 2019-03-11  Tom Tromey  <tromey@adacore.com>
9692
9693         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9694         redundant assignment to "this_cu".
9695
9696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9697
9698         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9699
9700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9701
9702         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9703         from...
9704         (rank_one_type): ... this.
9705
9706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9707
9708         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9709         from...
9710         (rank_one_type): ... this.
9711
9712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9713
9714         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9715         from...
9716         (rank_one_type): ... this.
9717
9718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9719
9720         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9721         from...
9722         (rank_one_type): ... this.
9723
9724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9725
9726         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9727         from...
9728         (rank_one_type): ... this.
9729
9730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9731
9732         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9733         from...
9734         (rank_one_type): ... this.
9735
9736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9737
9738         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9739         from...
9740         (rank_one_type): ... this.
9741
9742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9743
9744         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9745         from...
9746         (rank_one_type): ... this.
9747
9748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9749
9750         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9751         from...
9752         (rank_one_type): ... this.
9753
9754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9755
9756         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9757         from...
9758         (rank_one_type): ... this.
9759
9760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9761
9762         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9763         from...
9764         (rank_one_type): ... this.
9765
9766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9767
9768         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9769         from...
9770         (rank_one_type): ... this.
9771
9772 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9773
9774         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9775         inferior-events' shows the example events.
9776
9777 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9778
9779         Support styling on native MS-Windows console
9780
9781         PR/24315
9782         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9783         on MS-Windows if $TERM is not defined.
9784
9785         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9786
9787         * posix-hdep.c (gdb_console_fputs):
9788         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9789         functions.
9790         * ui-file.h (gdb_console_fputs): Add prototype.
9791
9792         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9793         back to fputs only if the former returns zero.
9794
9795 2019-03-07  Tom Tromey  <tom@tromey.com>
9796
9797         * symmisc.c (print_symbol_bcache_statistics): Update.
9798         (print_objfile_statistics): Update.
9799         * symfile.c (allocate_symtab): Update.
9800         * stabsread.c: Don't include bcache.h.
9801         * psymtab.h (struct psymbol_bcache): Don't declare.
9802         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9803         (psymbol_bcache_init, psymbol_bcache_free)
9804         (psymbol_bcache_get_bcache): Don't declare.
9805         * psymtab.c (struct psymbol_bcache): Remove.
9806         (psymtab_storage::psymtab_storage): Update.
9807         (psymtab_storage::~psymtab_storage): Update.
9808         (psymbol_bcache_init, psymbol_bcache_free)
9809         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9810         (add_psymbol_to_bcache): Update.
9811         (allocate_psymtab): Update.
9812         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9813         macro_cache>: No longer pointers.
9814         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9815         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9816         * macrotab.c (macro_bcache): Update.
9817         * macroexp.c: Don't include bcache.h.
9818         * gdbtypes.c (check_types_worklist): Update.
9819         (types_deeply_equal): Remove TRY/CATCH.  Update.
9820         * elfread.c (elf_symtab_read): Update.
9821         * dwarf2read.c: Don't include bcache.h.
9822         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9823         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9824         (print_bcache_statistics, bcache_memory_used): Don't declare.
9825         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9826         methods.  Rename all data members.
9827         * bcache.c (struct bcache): Move to bcache.h.
9828         (bcache::expand_hash_table): Rename from expand_hash_table.
9829         (bcache): Remove.
9830         (bcache::insert): Rename from bcache_full.
9831         (bcache::compare): Rename from bcache_compare.
9832         (bcache_xmalloc): Remove.
9833         (bcache::~bcache): Rename from bcache_xfree.
9834         (bcache::print_statistics): Rename from print_bcache_statistics.
9835         (bcache::memory_used): Rename from bcache_memory_used.
9836
9837 2019-03-07  Pedro Alves  <palves@redhat.com>
9838
9839         * infrun.c (normal_stop): Also check for
9840         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9841
9842 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * f-lang.c (value_from_host_double): Moved to...
9845         * value.c (value_from_host_double): ...here.
9846         * value.h (value_from_host_double): Declare.
9847         * guile/scm-math.c (vlscm_convert_typed_number): Use
9848         value_from_host_double.
9849         (vlscm_convert_number): Likewise.
9850         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9851         * python/py-value.c (convert_value_from_python): Likewise.
9852
9853 2019-03-06  Tom Tromey  <tom@tromey.com>
9854
9855         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9856
9857 2019-03-06  Tom Tromey  <tom@tromey.com>
9858
9859         * utils.h (free_current_contents): Don't declare.
9860         * utils.c (free_current_contents): Remove.
9861
9862 2019-03-06  Tom Tromey  <tom@tromey.com>
9863
9864         * top.c (quit_force): Update.
9865         * main.c (captured_command_loop): Update.
9866         * common/new-op.c (operator new): Update.
9867         * common/common-exceptions.c (struct catcher)
9868         <save_cleanup_chain>: Remove member.
9869         (exceptions_state_mc_init): Update.
9870         (exception_try_scope_entry): Return nullptr.
9871         (exception_try_scope_exit, exception_rethrow)
9872         (throw_exception_sjlj, throw_exception_cxx): Update.
9873         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9874         (all_cleanups, do_cleanups, discard_cleanups)
9875         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9876         (restore_cleanups, restore_final_cleanups): Don't declare.
9877         (do_final_cleanups): Remove parameter.
9878         * common/cleanups.c (cleanup_chain, make_cleanup)
9879         (make_cleanup_dtor, all_cleanups, do_cleanups)
9880         (discard_my_cleanups, discard_cleanups)
9881         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9882         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9883         (null_cleanup): Remove.
9884         (do_final_cleanups): Remove parameter.
9885
9886 2019-03-06  Tom Tromey  <tom@tromey.com>
9887
9888         * remote.c (remote_target::remote_parse_stop_reply): Use
9889         unique_xmalloc_ptr.
9890
9891 2019-03-06  Tom Tromey  <tom@tromey.com>
9892
9893         * stabsread.c (struct stabs_field_info): Rename from field_info.
9894         <list, fnlist>: Add initializers.
9895         <obstack>: New member.
9896         (read_member_functions, read_struct_fields, read_baseclasses):
9897         Allocate on obstack.  Don't use cleanups.
9898         (read_one_struct_field, read_member_functions, read_struct_fields)
9899         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9900         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9901         (read_struct_type): Update.
9902
9903 2019-03-06  Tom Tromey  <tom@tromey.com>
9904
9905         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9906         * common/filestuff.h (make_cleanup_close): Don't declare.
9907         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9908         Remove.
9909
9910 2019-03-06  Tom Tromey  <tom@tromey.com>
9911
9912         * solib-aix.c: Use make_scope_exit.
9913
9914 2019-03-06  Tom Tromey  <tom@tromey.com>
9915
9916         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9917         Use make_scope_exit.
9918
9919 2019-03-06  Tom Tromey  <tom@tromey.com>
9920
9921         * solib-svr4.c (disable_probes_interface): Remove parameter.
9922         (svr4_handle_solib_event): Use make_scope_exit.
9923
9924 2019-03-06  Tom Tromey  <tom@tromey.com>
9925
9926         * remote.c (struct stop_reply_deleter): Remove.
9927         (stop_reply_up): Update.
9928         (struct stop_reply): Derive from notif_event.  Don't typedef.
9929         <regcache>: Now a std::vector.
9930         (stop_reply_xfree): Remove.
9931         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9932         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9933         (remote_target::discard_pending_stop_replies): Use delete.
9934         (remote_target::remote_parse_stop_reply): Update.
9935         (remote_target::process_stop_reply): Update.
9936         * remote-notif.h (struct notif_event): Add virtual destructor.
9937         Remove "dtr" member.
9938         (struct notif_client) <alloc_event>: Return a unique_ptr.
9939         (notif_event_xfree): Don't declare.
9940         (notif_event_up): New typedef.
9941         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9942         (notif_event_xfree, do_notif_event_xfree): Remove.
9943         (remote_notif_state_xfree): Update.
9944
9945 2019-03-06  Tom Tromey  <tom@tromey.com>
9946
9947         * infrun.c (displaced_step_clear_cleanup): Now a
9948         forward_scope_exit type.
9949         (displaced_step_prepare_throw): Update.
9950         (displaced_step_fixup): Update.
9951
9952 2019-03-06  Tom Tromey  <tom@tromey.com>
9953
9954         * inferior.h (class inferior): Update comment.
9955         * gdbthread.h (class thread_info): Update comment.
9956
9957 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9958             Tom Tromey  <tom@tromey.com>
9959
9960         * stabsread.h (struct stab_section_list): Remove.
9961         (coffstab_build_psymtabs): Update.
9962         * dbxread.c (symbuf_sections): Now a std::vector.
9963         (sect_idx): New global.
9964         (fill_symbuf): Update.
9965         (coffstab_build_psymtabs): Change type of stabsects parameter.
9966         Update.
9967         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9968         std::vector.
9969         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9970         (coff_locate_sections): Update.
9971         (coff_symfile_read): Remove cleanups.  Update.
9972         (init_stringtab): Add storage parameter.
9973         (free_stringtab, free_stringtab_cleanup): Remove.
9974         (init_lineno): Add storage parameter.
9975         (free_linetab, free_linetab_cleanup): Remove.
9976
9977 2019-03-06  Pedro Alves  <palves@redhat.com>
9978
9979         * linux-fork.c (fork_info::clobber_regs): Delete.
9980         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9981         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9982         comment.  Adjust.
9983         (scoped_switch_fork_info::scoped_switch_fork_info)
9984         (checkpoint_command, linux_fork_context): Adjust
9985         fork_save_infrun_state calls.
9986
9987 2019-03-06  Pedro Alves  <palves@redhat.com>
9988
9989         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9990         (inf_has_multiple_threads): Return 'bool' and rewrite using
9991         inferior_info::threads().
9992
9993 2019-03-06  Pedro Alves  <palves@redhat.com>
9994
9995         * linux-fork.c: Include <list>.
9996         (fork_list): Now a std::list instance.
9997         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9998         (forks_exist_p, find_last_fork): Adjust.
9999         (new_fork): Delete.
10000         (one_fork_p): New.
10001         (add_fork): Adjust.
10002         (free_fork): Delete, folded into fork_info::~fork_info().
10003         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10004         Adjust.
10005         (init_fork_list): Delete.
10006         (linux_fork_killall, linux_fork_mourn_inferior)
10007         (linux_fork_detach, info_checkpoints_command): Adjust.
10008         (_initialize_linux_fork): No longer call init_fork_list.
10009
10010 2019-03-06  Pedro Alves  <palves@redhat.com>
10011
10012         * linux-fork.c (new_fork): New, split out of ...
10013         (add_fork): ... this.  Return void.  Move "first fork" special
10014         case from here, to ...
10015         (checkpoint_command): ... here.
10016         * linux-linux.h (add_fork): Return void.
10017
10018 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10019
10020         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10021
10022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10023             Chris January  <chris.january@arm.com>
10024             David Lecomber  <david.lecomber@arm.com>
10025
10026         * f-exp.y: New token, UNOP_INTRINSIC.
10027         (exp): New pattern using UNOP_INTRINSIC token.
10028         (f77_keywords): Add 'abs' keyword.
10029         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10030         (value_from_host_double): New function.
10031         (evaluate_subexp_f): Support UNOP_ABS.
10032
10033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10036         types.
10037
10038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10039
10040         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10041         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10042         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10043
10044 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10045
10046         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10047
10048 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10049             Chris January  <chris.january@arm.com>
10050
10051         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10052         * f-exp.y: Define 'KIND' token.
10053         (exp): New pattern for KIND expressions.
10054         (ptype): Handle types with a kind extension.
10055         (direct_abs_decl): Extend to spot kind extensions.
10056         (f77_keywords): Add 'kind' to the list.
10057         (push_kind_type): New function.
10058         (convert_to_kind_type): New function.
10059         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10060         * parse.c (operator_length_standard): Likewise.
10061         * parser-defs.h (enum type_pieces): Add tp_kind.
10062         * std-operator.def: Add UNOP_KIND.
10063
10064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10065
10066         * f-exp.y (f_parse): Set yydebug.
10067
10068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10069
10070         * f-lang.c (evaluate_subexp_f): New function.
10071         (exp_descriptor_f): New global.
10072         (f_language_defn): Use exp_descriptor_f instead of
10073         exp_descriptor_standard.
10074
10075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10076
10077         * f-exp.y (struct token): Add comments.
10078         (dot_ops): Remove uppercase versions and the end marker.
10079         (f77_keywords): Likewise.
10080         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10081         entries in the dot_ops array are case insensitive, and use
10082         strncasecmp to compare strings.  Also some whitespace cleanup in
10083         this area.  Similar for the f77_keywords array, except entries in
10084         this list might be case sensitive.
10085
10086 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10087
10088         * f-exp.y (struct f77_boolean_val): Add comments.
10089         (boolean_values): Remove uppercase versions, and end marker.
10090         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10091         and use strncasecmp to achieve case insensitivity.  Additionally,
10092         perform whitespace cleanup around this code.
10093
10094 2019-03-06  Tom Tromey  <tromey@adacore.com>
10095
10096         * remote-sim.c (gdbsim_target_open): Use result of
10097         gdb_argv::release.
10098
10099 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10100         Dirk Schubert  <dirk.schubert@arm.com>
10101         Chris January  <chris.january@arm.com>
10102
10103         * eval.c (evaluate_subexp_standard): Call Fortran argument
10104         wrapping logic.
10105         * f-lang.c (struct value): A value which can be passed into a
10106         Fortran function call.
10107         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10108         where appropriate.
10109         (struct type): Value ready for a Fortran function call.
10110         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10111         is needed.
10112         * f-lang.h (fortran_argument_convert): Declaration.
10113         (fortran_preserve_arg_pointer): Declaration.
10114         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10115
10116 2019-03-05  Tom Tromey  <tromey@adacore.com>
10117
10118         * python/py-prettyprint.c (print_string_repr): Remove #if.
10119         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10120
10121 2019-03-05  Tom Tromey  <tromey@adacore.com>
10122
10123         * target.c (the_dummy_target): Move later.  Change type to
10124         "dummy_target".
10125         (initialize_targets): Don't initialize the_dummy_target.
10126
10127 2019-03-05  Tom Tromey  <tromey@adacore.com>
10128
10129         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10130         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10131
10132 2019-03-05  Tom Tromey  <tromey@adacore.com>
10133
10134         * windows-nat.c (windows_nat_target::attach)
10135         (windows_nat_target::detach): Don't call gdb_flush.
10136         * valprint.c (generic_val_print, val_print, val_print_string):
10137         Don't call gdb_flush.
10138         * utils.c (defaulted_query): Don't call gdb_flush.
10139         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10140         * target.c (target_announce_detach): Don't call gdb_flush.
10141         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10142         * remote.c (extended_remote_target::attach): Don't call
10143         gdb_flush.
10144         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10145         * printcmd.c (do_examine): Don't call gdb_flush.
10146         (info_display_command): Don't call gdb_flush.
10147         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10148         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10149         * memattr.c (info_mem_command): Don't call gdb_flush.
10150         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10151         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10152         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10153         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10154         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10155         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10156         (gnu_nat_target::detach): Don't call gdb_flush.
10157         * f-valprint.c (f_val_print): Don't call gdb_flush.
10158         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10159         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10160         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10161         gdb_flush.
10162         * c-valprint.c (c_val_print): Don't call gdb_flush.
10163         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10164
10165 2019-03-05  Tom Tromey  <tromey@adacore.com>
10166
10167         * varobj.c (update_dynamic_varobj_children): Update.
10168         (install_default_visualizer): Use reset, not release.
10169         * value.c (set_internalvar): Update.
10170         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10171         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10172         ATTRIBUTE_UNUSED_RESULT.
10173
10174 2019-03-05  Tom Tromey  <tromey@adacore.com>
10175
10176         * remote.c (class scoped_remote_fd) <release>: Add
10177         ATTRIBUTE_UNUSED_RESULT.
10178
10179 2019-03-05  Tom Tromey  <tromey@adacore.com>
10180
10181         * macroexp.c (struct macro_buffer) <release>: Add
10182         ATTRIBUTE_UNUSED_RESULT.
10183
10184 2019-03-05  Tom Tromey  <tromey@adacore.com>
10185
10186         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10187         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10188         ATTRIBUTE_UNUSED_RESULT.
10189
10190 2019-03-05  Tom Tromey  <tromey@adacore.com>
10191
10192         * common/scoped_fd.h (class scoped_fd) <release>: Add
10193         ATTRIBUTE_UNUSED_RESULT.
10194
10195 2019-03-05  Tom Tromey  <tromey@adacore.com>
10196
10197         * parser-defs.h (struct parser_state) <release>: Add
10198         ATTRIBUTE_UNUSED_RESULT.
10199
10200 2019-03-05  Tom Tromey  <tromey@adacore.com>
10201
10202         * utils.h (class gdb_argv) <release>: Add
10203         ATTRIBUTE_UNUSED_RESULT.
10204         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10205
10206 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10207
10208         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10209         for-loop range, to avoid compiler warnings.
10210
10211         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10212         avoid compiler warnings about unused variables.
10213
10214         * NEWS: Mention end of support for native debugging on MS-Windows
10215         before XP.
10216
10217         PR gdb/24292
10218         * common/netstuff.c:
10219         * gdbserver/gdbreplay.c
10220         * gdbserver/remote-utils.c:
10221         * ser-tcp.c:
10222         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10223         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10224         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10225         'getaddrinfo' and 'freeaddrinfo' were not available before
10226         Windows XP, and mingw.org's MinGW headers by default define
10227         _WIN32_WINNT to 0x500.
10228
10229 2019-03-01  Gary Benson <gbenson@redhat.com>
10230
10231         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10232
10233 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10234             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10235
10236         PR gdb/8527
10237         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10238         set_sigint_trap, clear_sigint_trap.
10239
10240 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10241
10242         * target.c (target_detach): Clear the regcache and the
10243         frame cache.
10244
10245 2019-02-27  Pedro Alves  <palves@redhat.com>
10246
10247         * utils.c (set_screen_size): When we cap the height/width sizes,
10248         tweak the corresponding command variable to show "unlimited":
10249
10250 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10251             Pedro Alves  <palves@redhat.com>
10252
10253         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10254         before calling rl_set_screen_size.
10255
10256 2019-02-27  Tom Tromey  <tromey@adacore.com>
10257
10258         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10259         define.
10260         * python/py-value.c: Remove Python 2.4 workaround.
10261         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10262         workaround.
10263         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10264         Python 2.4 workaround.
10265         * python/python-internal.h: Remove Python 2.4 comment.
10266         (Py_ssize_t): Don't define.
10267         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10268         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10269         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10270         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10271         * python/python.c (do_start_initialization): Remove Python 2.4
10272         workaround.
10273         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10274         (print_children): Remove Python 2.4 workaround.
10275         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10276         workaround.
10277         (CHARBUFFERPROC_NAME): Remove.
10278         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10279         Python 2.4 workaround.
10280
10281 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10282
10283         * NEWS: Note minimum Python version.
10284
10285 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10286
10287         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10288         code from these functions.  Remove corresponding ifdefs.  Use
10289         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10290         Remove gotos and target of gotos.
10291         (infpy_search_memory): Likewise.
10292
10293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10294
10295         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10296         (hppa_gdbarch_init): Don't register deleted functions with
10297         gdbarch.
10298
10299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10300
10301         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10302         (h8300_unwind_sp): Delete.
10303         (h8300_dummy_id): Delete.
10304         (h8300_gdbarch_init): Don't register deleted functions with
10305         gdbarch.
10306
10307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10308
10309         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10310         (ft32_unwind_pc): Delete.
10311         (ft32_unwind_sp): Delete.
10312         (ft32_gdbarch_init): Don't register deleted functions with
10313         gdbarch.
10314
10315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10316
10317         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10318         (frv_unwind_pc): Delete.
10319         (frv_unwind_sp): Delete.
10320         (frv_gdbarch_init): Don't register deleted functions with
10321         gdbarch.
10322
10323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10324
10325         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10326         (riscv_unwind_pc): Delete.
10327         (riscv_unwind_sp): Delete.
10328         (riscv_gdbarch_init): Don't register deleted functions with
10329         gdbarch.
10330
10331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10332
10333         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10334         (csky_unwind_pc): Delete.
10335         (csky_unwind_sp): Delete.
10336         (csky_gdbarch_init): Don't register deleted functions with
10337         gdbarch.
10338
10339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10342         (cris_unwind_pc): Delete.
10343         (cris_unwind_sp): Delete.
10344         (cris_gdbarch_init): Don't register deleted functions with
10345         gdbarch.
10346
10347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10348
10349         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10350         (bfin_unwind_pc): Delete.
10351         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10352
10353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10354
10355         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10356         (arm_unwind_pc): Delete.
10357         (arm_unwind_sp): Delete.
10358         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10359
10360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10363         (arc_unwind_pc): Delete.
10364         (arc_unwind_sp): Delete.
10365         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10366
10367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10370         (alpha_unwind_pc): Delete.
10371         (alpha_gdbarch_init): Don't register deleted functions with
10372         gdbarch.
10373
10374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10375
10376         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10377         (aarch64_unwind_pc): Delete.
10378         (aarch64_unwind_sp): Delete.
10379         (aarch64_gdbarch_init): Don't register deleted functions with
10380         gdbarch.
10381
10382 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * gdbtypes.c (type_align): Don't consider static members when
10385         computing structure alignment.
10386
10387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10390         return 0 for other types.
10391         * arch-utils.c (default_type_align): Always return 0.
10392         * gdbarch.h: Regenerate.
10393         * gdbarch.sh (type_align): Extend comment.
10394         * gdbtypes.c (type_align): Add additional comments, always call
10395         gdbarch_type_align before applying the default rules.
10396         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10397         generic code will then apply a suitable default.
10398         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10399         types, return 0 for other types.
10400
10401 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10402
10403         * NEWS: Create a new section for the next release branch.
10404         Rename the section of the current branch, now that it has
10405         been cut.
10406
10407 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10408
10409         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10410         * version.in: Bump version to 8.3.50.DATE-git.
10411
10412 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10413
10414         * aix-thread.c (ptid_cmp): Remove unused variable.
10415         (get_signaled_thread): Likewise.
10416         (store_regs_user_thread): Likewise.
10417         (store_regs_kernel_thread): Likewise.
10418         (fetch_regs_kernel_thread): Remove shadowed variable.
10419
10420 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10421
10422         * features/riscv/32bit-cpu.xml: Add register numbers.
10423         * features/riscv/32bit-fpu.c: Regenerate.
10424         * features/riscv/32bit-fpu.xml: Add register numbers.
10425         * features/riscv/64bit-cpu.xml: Add register numbers.
10426         * features/riscv/64bit-fpu.c: Regenerate.
10427         * features/riscv/64bit-fpu.xml: Add register numbers.
10428
10429 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10430
10431         * NEWS: Mention two argument form of gdb.Value constructor.
10432         * python/py-value.c (convert_buffer_and_type_to_value): New
10433         function.
10434         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10435         Add support for handling an optional second argument.  Call
10436         convert_buffer_and_type_to_value as appropriate.
10437         * python/python-internal.h (Py_buffer_deleter): New struct.
10438         (Py_buffer_up): New typedef.
10439
10440 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10441
10442         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10443         instead of releasing ownership.
10444
10445 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10446
10447         * dwarf2read.c (open_and_init_dwp_file): Call
10448         elf_numsections instead of bfd_count_sections to initialize
10449         dwp_file->num_sections.
10450
10451 2019-02-25  Tom Tromey  <tromey@adacore.com>
10452
10453         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10454
10455 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10456
10457         * gcore.in: Add '--readnever' option when invoking GDB.
10458
10459 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10460
10461         * MAINTAINERS: Update my email address.
10462
10463 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10464
10465         * build-id.c (build_id_to_debug_bfd_1): New function.
10466         (build_id_to_debug_bfd): Look for separate debug file in
10467         sysroot.
10468
10469 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10470
10471         * gdbarch.sh: Update the copyright year range that is placed into
10472         generated files.
10473
10474 2019-02-22  Keith Seitz  <keiths@redhat.com>
10475
10476         PR symtab/23853
10477         * linespec.c (create_sals_line_offset): Search for the default
10478         symtab's filename instead of its fullname.
10479
10480 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10481
10482         * NEWS: Update style defaults.
10483
10484 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10485
10486         * main.c (captured_main_1): Disable styling in batch mode.
10487
10488 2019-02-20  Tom Tromey  <tom@tromey.com>
10489
10490         * symtab.c (symtab_symbol_info): Fix typos.
10491
10492 2019-02-20  Tom Tromey  <tromey@adacore.com>
10493
10494         * findcmd.c (_initialize_mem_search): Use upper case for
10495         metasyntactic variables.
10496
10497 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10498
10499         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10500         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10501
10502 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10503
10504         * top.h (source_file_name): Change to std::string.
10505         * top.c (source_file_name): Likewise.
10506         (command_line_input): Adjust.
10507         * cli/cli-script.c (script_from_file): Adjust.
10508
10509 2019-02-19  Tom Tromey  <tromey@adacore.com>
10510
10511         * ravenscar-thread.c
10512         (ravenscar_thread_target::update_thread_list): Don't call
10513         ada_build_task_list.
10514         * ada-lang.h (ada_build_task_list): Don't declare.
10515         * ada-tasks.c (struct ada_tasks_inferior_data)
10516         <task_list_valid_p>: Now bool.
10517         (read_known_tasks, ada_task_list_changed)
10518         (ada_tasks_invalidate_inferior_data): Update.
10519         (read_known_tasks_array): Return bool.
10520         (read_known_tasks_list): Likewise.
10521         (read_known_tasks): Return void.
10522         (ada_build_task_list): Now static.
10523
10524 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10525
10526         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10527         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10528
10529 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10530
10531         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10532         variant for ada_tasks_pspace_data_handle and
10533         ada_tasks_inferior_data_handle.
10534         (ada_tasks_pspace_data_cleanup): New function.
10535         (ada_tasks_inferior_data_cleanup): New function.
10536
10537 2019-02-17  Tom Tromey  <tom@tromey.com>
10538
10539         * macrotab.h (macro_source_fullname): Return a std::string.
10540         * macrotab.c (macro_include, check_for_redefinition)
10541         (macro_undef, macro_lookup_definition, foreach_macro)
10542         (foreach_macro_in_scope): Update.
10543         (macro_source_fullname): Return a std::string.
10544         * macrocmd.c (show_pp_source_pos): Update.
10545
10546 2019-02-17  Tom Tromey  <tom@tromey.com>
10547
10548         * macrocmd.c (show_pp_source_pos): Style the file names.
10549
10550 2019-02-17  Tom Tromey  <tom@tromey.com>
10551
10552         PR tui/24197:
10553         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10554
10555 2019-02-17  Tom Tromey  <tom@tromey.com>
10556
10557         * ada-lang.c (user_select_syms): Use filtered printing.
10558         * utils.c (wrap_style): New global.
10559         (desired_style): Remove.
10560         (emit_style_escape): Add stream parameter.
10561         (set_output_style, reset_terminal_style, prompt_for_continue):
10562         Update.
10563         (flush_wrap_buffer): Only flush gdb_stdout.
10564         (wrap_here): Set wrap_style.
10565         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10566         treat escape sequences as a character.  Change when wrap buffer is
10567         flushed.
10568         (fputs_styled): Do not set the output style when the default is
10569         requested.
10570         * ui-style.h (struct ui_file_style) <is_default>: New method.
10571         * source.c (print_source_lines_base): Emit escape sequences in one
10572         piece.
10573
10574 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10575
10576         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10577         integers and enumeration types.
10578
10579 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10580
10581         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10582         instead of lookup_symbol_in_language
10583         (do_exact_match): New function.
10584         (ada_get_symbol_name_matcher): Return do_exact_match when
10585         doing a verbatim match.
10586
10587 2019-02-15  Tom Tromey  <tromey@adacore.com>
10588
10589         * ravenscar-thread.c (ravenscar_thread_target::resume)
10590         (ravenscar_thread_target::wait): Special case wildcard requests.
10591
10592 2019-02-15  Tom Tromey  <tromey@adacore.com>
10593
10594         * ravenscar-thread.c (base_ptid): Remove.
10595         (struct ravenscar_thread_target) <close>: New method.
10596         <m_base_ptid>: New member.
10597         <update_inferior_ptid, active_task, task_is_currently_active,
10598         runtime_initialized>: Declare methods.
10599         <ravenscar_thread_target>: Add constructor.
10600         (ravenscar_thread_target::task_is_currently_active)
10601         (ravenscar_thread_target::update_inferior_ptid)
10602         (ravenscar_runtime_initialized): Rename.  Now methods.
10603         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10604         (ravenscar_thread_target::update_thread_list): Update.
10605         (ravenscar_thread_target::active_task): Now method.
10606         (ravenscar_thread_target::store_registers)
10607         (ravenscar_thread_target::prepare_to_store)
10608         (ravenscar_thread_target::prepare_to_store)
10609         (ravenscar_thread_target::mourn_inferior): Update.
10610         (ravenscar_inferior_created): Use "new" to create target.
10611         (ravenscar_thread_target::get_ada_task_ptid): Update.
10612         (_initialize_ravenscar): Don't initialize base_ptid.
10613         (ravenscar_ops): Remove global.
10614
10615 2019-02-15  Tom Tromey  <tromey@adacore.com>
10616
10617         * target.h (push_target): Declare new overload.
10618         * target.c (push_target): New overload, taking an rvalue reference.
10619         * remote.c (remote_target::open_1): Use push_target overload.
10620         * corelow.c (core_target_open): Use push_target overload.
10621
10622 2019-02-15  Tom Tromey  <tromey@adacore.com>
10623
10624         * ravenscar-thread.c (is_ravenscar_task)
10625         (ravenscar_task_is_currently_active): Return bool.
10626         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10627         (_initialize_ravenscar): Remove "(void)".
10628         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10629         Return bool.
10630
10631 2019-02-15  Tom Tromey  <tromey@adacore.com>
10632
10633         * ravenscar-thread.c (ravenscar_runtime_initializer)
10634         (has_ravenscar_runtime, get_running_thread_id)
10635         (ravenscar_thread_target::resume): Fix indentation.
10636
10637 2019-02-15  Tom Tromey  <tromey@adacore.com>
10638
10639         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10640         from ravenscar_arch_ops.
10641         (sparc_ravenscar_ops::fetch_registers)
10642         (sparc_ravenscar_ops::store_registers): Now methods.
10643         (sparc_ravenscar_prepare_to_store): Remove.
10644         (sparc_ravenscar_ops): Redefine.
10645         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10646         methods and destructor.  Remove members.
10647         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10648         (ravenscar_thread_target::store_registers)
10649         (ravenscar_thread_target::prepare_to_store): Update.
10650         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10651         Remove.
10652         (struct ppc_ravenscar_powerpc_ops): Derive from
10653         ravenscar_arch_ops.
10654         (ppc_ravenscar_powerpc_ops::fetch_registers)
10655         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10656         (ppc_ravenscar_powerpc_ops): Redefine.
10657         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10658         (ppc_ravenscar_e500_ops::fetch_registers)
10659         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10660         (ppc_ravenscar_e500_ops): Redefine.
10661         * aarch64-ravenscar-thread.c
10662         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10663         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10664         (aarch64_ravenscar_fetch_registers)
10665         (aarch64_ravenscar_store_registers): Now methods.
10666         (aarch64_ravenscar_ops): Redefine.
10667
10668 2019-02-15  Tom Tromey  <tromey@adacore.com>
10669
10670         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10671         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10672         (ravenscar_thread_target::stopped_by_watchpoint)
10673         (ravenscar_thread_target::stopped_data_address)
10674         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10675
10676 2019-02-15  Tom Tromey  <tromey@adacore.com>
10677
10678         * ravenscar-thread.c: Fix some typos.
10679
10680 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10681             Tom Tromey  <tromey@adacore.com>
10682
10683         * ada-lang.c (ada_exception_sal): Change addr_string to a
10684         std::string.
10685         (create_ada_exception_catchpoint): Update.
10686
10687 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10688             Tom Tromey  <tromey@adacore.com>
10689
10690         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10691         (bp_location_ops): Remove.
10692         (base_breakpoint_allocate_location): Update.
10693         (free_bp_location): Update.
10694         * ada-lang.c (class ada_catchpoint_location)
10695         <ada_catchpoint_location>: Remove ops parameter.
10696         (ada_catchpoint_location_dtor): Remove.
10697         (ada_catchpoint_location_ops): Remove.
10698         (allocate_location_exception): Update.
10699         * breakpoint.h (struct bp_location_ops): Remove.
10700         (class bp_location) <bp_location>: Remove bp_location_ops
10701         parameter.
10702         <~bp_location>: Add destructor.
10703         <ops>: Remove.
10704
10705 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10706             Pedro Alves  <palves@redhat.com>
10707
10708         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10709         'PATH_MAX'.
10710
10711 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10712             Samuel Thibault  <samuel.thibault@gnu.org>
10713             Thomas Schwinge  <thomas@codesourcery.com>
10714
10715         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10716         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10717
10718 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10719
10720         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10721         (check_empty): Use "const char *".
10722
10723         * gnu-nat.c (gnu_nat_target::detach): Instead of
10724         'detach_inferior (pid)' call
10725         'detach_inferior (find_inferior_pid (pid))'.
10726
10727         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10728         'nat/fork-inferior.o'.
10729         * gnu-nat.c: #include "nat/fork-inferior.h".
10730
10731         * gnu-nat.c (gnu_nat_target::detach): Instead of
10732         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10733         * gnu-nat.h: #include "inf-child.h".
10734         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10735         'i386_gnu_nat_target::fetch_registers'.
10736         (gnu_store_registers): Rename/move to
10737         'i386_gnu_nat_target::store_registers'.
10738
10739         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10740         * gnu-nat.h (mach_thread_info): New function.
10741         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10742
10743         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10744
10745 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10746
10747         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10748
10749 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10750
10751         * windows-nat.c (windows_add_thread): Add new parameter
10752         "main_thread_p" with default value set to false.  Update
10753         function documentation as well as all callers.
10754         (windows_delete_thread): Likewise.
10755         (fake_create_process): Update call to windows_add_thread.
10756         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10757         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10758         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10759         call to windows_delete_thread.
10760
10761 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10762
10763         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10764
10765 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10766
10767         * symfile.c (find_separate_debug_file): Use canonical path of
10768         sysroot with child_path instead of gdb_sysroot if it is valid.
10769
10770 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10771
10772         * symfile.c (find_separate_debug_file): Use child_path to
10773         determine if an object file is under a sysroot.
10774
10775 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10776
10777         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10778         unittests/child-path-selftests.c.
10779         * common/pathstuff.c (child_path): New function.
10780         * common/pathstuff.h (child_path): New prototype.
10781         * unittests/child-path-selftests.c: New file.
10782
10783 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10784
10785         * symfile.c (find_separate_debug_file): Look for separate debug
10786         files in debug directories under the sysroot.
10787
10788 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10789
10790         * symtab.h (struct minimal_symbol data_p): New const method.
10791         (struct minimal_symbol text_p): Likewise.
10792         * symtab.c (output_source_filename): Use file name style
10793         to print file name.
10794         (print_symbol_info): Likewise.
10795         (print_msymbol_info): Use address style to print addresses.
10796         Use function name style to print executable text symbols.
10797         (expand_symtab_containing_pc): Use data_p.
10798         (find_pc_sect_compunit_symtab): Likewise.
10799
10800 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10801
10802         * breakpoint.c (describe_other_breakpoints): Use address style
10803         to print addresses.
10804         (say_where): Likewise.
10805
10806 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10807
10808         * ada-typeprint.c (print_func_type): Print function name
10809         style to print function name.
10810         * c-typeprint.c (c_print_type_1): Likewise.
10811
10812 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10813
10814         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10815         for execve.
10816
10817 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10818
10819         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10820         type_stack.
10821
10822 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10823
10824         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10825         TYPE_CODE_REF types.
10826
10827 2019-02-08  Jim Wilson  <jimw@sifive.com>
10828
10829         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10830         (riscv_linux_fregset): New.
10831         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10832
10833 2019-02-07  Tom Tromey  <tom@tromey.com>
10834
10835         * thread.c (thread_cancel_execution_command): Update.
10836         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10837         methods.
10838         (struct thread_fsm_ops): Remove.
10839         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10840         (thread_fsm_should_stop, thread_fsm_return_value)
10841         (thread_fsm_set_finished, thread_fsm_finished_p)
10842         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10843         Don't declare.
10844         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10845         * infrun.c (clear_proceed_status_thread)
10846         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10847         (print_stop_event): Update.
10848         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10849         Add constructor.
10850         (step_command_fsm_ops): Remove.
10851         (new_step_command_fsm): Remove.
10852         (step_1): Update.
10853         (step_command_fsm::should_stop): Rename from
10854         step_command_fsm_should_stop.
10855         (step_command_fsm::clean_up): Rename from
10856         step_command_fsm_clean_up.
10857         (step_command_fsm::do_async_reply_reason): Rename from
10858         step_command_fsm_async_reply_reason.
10859         (struct until_next_fsm): Inherit from thread_fsm.  Add
10860         constructor.
10861         (until_next_fsm_ops): Remove.
10862         (new_until_next_fsm): Remove.
10863         (until_next_fsm::should_stop): Rename from
10864         until_next_fsm_should_stop.
10865         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10866         (until_next_fsm::do_async_reply_reason): Rename from
10867         until_next_fsm_async_reply_reason.
10868         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10869         constructor.  Change type of breakpoint.
10870         (finish_command_fsm_ops): Remove.
10871         (new_finish_command_fsm): Remove.
10872         (finish_command_fsm::should_stop): Rename from
10873         finish_command_fsm_should_stop.
10874         (finish_command_fsm::clean_up): Rename from
10875         finish_command_fsm_clean_up.
10876         (finish_command_fsm::return_value): Rename from
10877         finish_command_fsm_return_value.
10878         (finish_command_fsm::do_async_reply_reason): Rename from
10879         finish_command_fsm_async_reply_reason.
10880         (finish_command): Update.
10881         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10882         Add constructor.
10883         (call_thread_fsm_ops): Remove.
10884         (call_thread_fsm::call_thread_fsm): Rename from
10885         new_call_thread_fsm.
10886         (call_thread_fsm::should_stop): Rename from
10887         call_thread_fsm_should_stop.
10888         (call_thread_fsm::should_notify_stop): Rename from
10889         call_thread_fsm_should_notify_stop.
10890         (run_inferior_call, call_function_by_hand_dummy): Update.
10891         * cli/cli-interp.c (should_print_stop_to_console): Update.
10892         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10893         Add constructor.  Change type of location_breakpoint,
10894         caller_breakpoint.
10895         (until_break_fsm_ops): Remove.
10896         (new_until_break_fsm): Remove.
10897         (until_break_fsm::should_stop): Rename from
10898         until_break_fsm_should_stop.
10899         (until_break_fsm::clean_up): Rename from
10900         until_break_fsm_clean_up.
10901         (until_break_fsm::do_async_reply_reason): Rename from
10902         until_break_fsm_async_reply_reason.
10903         (until_break_command): Update.
10904         * thread-fsm.c: Remove.
10905         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10906
10907 2019-02-07  Tom Tromey  <tom@tromey.com>
10908
10909         * yy-remap.h: Add include guard.
10910         * xtensa-tdep.h: Add include guard.
10911         * xcoffread.h: Rename include guard.
10912         * varobj-iter.h: Add include guard.
10913         * tui/tui.h: Rename include guard.
10914         * tui/tui-winsource.h: Rename include guard.
10915         * tui/tui-wingeneral.h: Rename include guard.
10916         * tui/tui-windata.h: Rename include guard.
10917         * tui/tui-win.h: Rename include guard.
10918         * tui/tui-stack.h: Rename include guard.
10919         * tui/tui-source.h: Rename include guard.
10920         * tui/tui-regs.h: Rename include guard.
10921         * tui/tui-out.h: Rename include guard.
10922         * tui/tui-layout.h: Rename include guard.
10923         * tui/tui-io.h: Rename include guard.
10924         * tui/tui-hooks.h: Rename include guard.
10925         * tui/tui-file.h: Rename include guard.
10926         * tui/tui-disasm.h: Rename include guard.
10927         * tui/tui-data.h: Rename include guard.
10928         * tui/tui-command.h: Rename include guard.
10929         * tic6x-tdep.h: Add include guard.
10930         * target/waitstatus.h: Rename include guard.
10931         * target/wait.h: Rename include guard.
10932         * target/target.h: Rename include guard.
10933         * target/resume.h: Rename include guard.
10934         * target-float.h: Rename include guard.
10935         * stabsread.h: Add include guard.
10936         * rs6000-tdep.h: Add include guard.
10937         * riscv-fbsd-tdep.h: Add include guard.
10938         * regformats/regdef.h: Rename include guard.
10939         * record.h: Rename include guard.
10940         * python/python.h: Rename include guard.
10941         * python/python-internal.h: Rename include guard.
10942         * python/py-stopevent.h: Rename include guard.
10943         * python/py-ref.h: Rename include guard.
10944         * python/py-record.h: Rename include guard.
10945         * python/py-record-full.h: Rename include guard.
10946         * python/py-record-btrace.h: Rename include guard.
10947         * python/py-instruction.h: Rename include guard.
10948         * python/py-events.h: Rename include guard.
10949         * python/py-event.h: Rename include guard.
10950         * procfs.h: Add include guard.
10951         * proc-utils.h: Add include guard.
10952         * p-lang.h: Add include guard.
10953         * or1k-tdep.h: Rename include guard.
10954         * observable.h: Rename include guard.
10955         * nto-tdep.h: Rename include guard.
10956         * nat/x86-linux.h: Rename include guard.
10957         * nat/x86-linux-dregs.h: Rename include guard.
10958         * nat/x86-gcc-cpuid.h: Add include guard.
10959         * nat/x86-dregs.h: Rename include guard.
10960         * nat/x86-cpuid.h: Rename include guard.
10961         * nat/ppc-linux.h: Rename include guard.
10962         * nat/mips-linux-watch.h: Rename include guard.
10963         * nat/linux-waitpid.h: Rename include guard.
10964         * nat/linux-ptrace.h: Rename include guard.
10965         * nat/linux-procfs.h: Rename include guard.
10966         * nat/linux-osdata.h: Rename include guard.
10967         * nat/linux-nat.h: Rename include guard.
10968         * nat/linux-namespaces.h: Rename include guard.
10969         * nat/linux-btrace.h: Rename include guard.
10970         * nat/glibc_thread_db.h: Rename include guard.
10971         * nat/gdb_thread_db.h: Rename include guard.
10972         * nat/gdb_ptrace.h: Rename include guard.
10973         * nat/fork-inferior.h: Rename include guard.
10974         * nat/amd64-linux-siginfo.h: Rename include guard.
10975         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10976         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10977         * nat/aarch64-linux.h: Rename include guard.
10978         * nat/aarch64-linux-hw-point.h: Rename include guard.
10979         * mn10300-tdep.h: Add include guard.
10980         * mips-linux-tdep.h: Add include guard.
10981         * mi/mi-parse.h: Rename include guard.
10982         * mi/mi-out.h: Rename include guard.
10983         * mi/mi-main.h: Rename include guard.
10984         * mi/mi-interp.h: Rename include guard.
10985         * mi/mi-getopt.h: Rename include guard.
10986         * mi/mi-console.h: Rename include guard.
10987         * mi/mi-common.h: Rename include guard.
10988         * mi/mi-cmds.h: Rename include guard.
10989         * mi/mi-cmd-break.h: Rename include guard.
10990         * m2-lang.h: Add include guard.
10991         * location.h: Rename include guard.
10992         * linux-record.h: Rename include guard.
10993         * linux-nat.h: Add include guard.
10994         * linux-fork.h: Add include guard.
10995         * i386-darwin-tdep.h: Rename include guard.
10996         * hppa-linux-offsets.h: Add include guard.
10997         * guile/guile.h: Rename include guard.
10998         * guile/guile-internal.h: Rename include guard.
10999         * gnu-nat.h: Rename include guard.
11000         * gdb-stabs.h: Rename include guard.
11001         * frv-tdep.h: Add include guard.
11002         * f-lang.h: Add include guard.
11003         * event-loop.h: Add include guard.
11004         * darwin-nat.h: Rename include guard.
11005         * cp-abi.h: Rename include guard.
11006         * config/sparc/nm-sol2.h: Rename include guard.
11007         * config/nm-nto.h: Rename include guard.
11008         * config/nm-linux.h: Add include guard.
11009         * config/i386/nm-i386gnu.h: Rename include guard.
11010         * config/djgpp/nl_types.h: Rename include guard.
11011         * config/djgpp/langinfo.h: Rename include guard.
11012         * compile/gcc-cp-plugin.h: Add include guard.
11013         * compile/gcc-c-plugin.h: Add include guard.
11014         * compile/compile.h: Rename include guard.
11015         * compile/compile-object-run.h: Rename include guard.
11016         * compile/compile-object-load.h: Rename include guard.
11017         * compile/compile-internal.h: Rename include guard.
11018         * compile/compile-cplus.h: Rename include guard.
11019         * compile/compile-c.h: Rename include guard.
11020         * common/xml-utils.h: Rename include guard.
11021         * common/x86-xstate.h: Rename include guard.
11022         * common/version.h: Rename include guard.
11023         * common/vec.h: Rename include guard.
11024         * common/tdesc.h: Rename include guard.
11025         * common/selftest.h: Rename include guard.
11026         * common/scoped_restore.h: Rename include guard.
11027         * common/scoped_mmap.h: Rename include guard.
11028         * common/scoped_fd.h: Rename include guard.
11029         * common/safe-iterator.h: Rename include guard.
11030         * common/run-time-clock.h: Rename include guard.
11031         * common/refcounted-object.h: Rename include guard.
11032         * common/queue.h: Rename include guard.
11033         * common/ptid.h: Rename include guard.
11034         * common/print-utils.h: Rename include guard.
11035         * common/preprocessor.h: Rename include guard.
11036         * common/pathstuff.h: Rename include guard.
11037         * common/observable.h: Rename include guard.
11038         * common/netstuff.h: Rename include guard.
11039         * common/job-control.h: Rename include guard.
11040         * common/host-defs.h: Rename include guard.
11041         * common/gdb_wait.h: Rename include guard.
11042         * common/gdb_vecs.h: Rename include guard.
11043         * common/gdb_unlinker.h: Rename include guard.
11044         * common/gdb_unique_ptr.h: Rename include guard.
11045         * common/gdb_tilde_expand.h: Rename include guard.
11046         * common/gdb_sys_time.h: Rename include guard.
11047         * common/gdb_string_view.h: Rename include guard.
11048         * common/gdb_splay_tree.h: Rename include guard.
11049         * common/gdb_setjmp.h: Rename include guard.
11050         * common/gdb_ref_ptr.h: Rename include guard.
11051         * common/gdb_optional.h: Rename include guard.
11052         * common/gdb_locale.h: Rename include guard.
11053         * common/gdb_assert.h: Rename include guard.
11054         * common/filtered-iterator.h: Rename include guard.
11055         * common/filestuff.h: Rename include guard.
11056         * common/fileio.h: Rename include guard.
11057         * common/environ.h: Rename include guard.
11058         * common/common-utils.h: Rename include guard.
11059         * common/common-types.h: Rename include guard.
11060         * common/common-regcache.h: Rename include guard.
11061         * common/common-inferior.h: Rename include guard.
11062         * common/common-gdbthread.h: Rename include guard.
11063         * common/common-exceptions.h: Rename include guard.
11064         * common/common-defs.h: Rename include guard.
11065         * common/common-debug.h: Rename include guard.
11066         * common/cleanups.h: Rename include guard.
11067         * common/buffer.h: Rename include guard.
11068         * common/btrace-common.h: Rename include guard.
11069         * common/break-common.h: Rename include guard.
11070         * cli/cli-utils.h: Rename include guard.
11071         * cli/cli-style.h: Rename include guard.
11072         * cli/cli-setshow.h: Rename include guard.
11073         * cli/cli-script.h: Rename include guard.
11074         * cli/cli-interp.h: Rename include guard.
11075         * cli/cli-decode.h: Rename include guard.
11076         * cli/cli-cmds.h: Rename include guard.
11077         * charset-list.h: Add include guard.
11078         * buildsym-legacy.h: Rename include guard.
11079         * bfin-tdep.h: Add include guard.
11080         * ax.h: Rename include guard.
11081         * arm-linux-tdep.h: Add include guard.
11082         * arm-fbsd-tdep.h: Add include guard.
11083         * arch/xtensa.h: Rename include guard.
11084         * arch/tic6x.h: Add include guard.
11085         * arch/i386.h: Add include guard.
11086         * arch/arm.h: Rename include guard.
11087         * arch/arm-linux.h: Rename include guard.
11088         * arch/arm-get-next-pcs.h: Rename include guard.
11089         * arch/amd64.h: Add include guard.
11090         * arch/aarch64-insn.h: Rename include guard.
11091         * arch-utils.h: Rename include guard.
11092         * annotate.h: Add include guard.
11093         * amd64-darwin-tdep.h: Rename include guard.
11094         * aarch64-linux-tdep.h: Add include guard.
11095         * aarch64-fbsd-tdep.h: Add include guard.
11096         * aarch32-linux-nat.h: Add include guard.
11097
11098 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11099
11100         * macrotab.c (macro_define_internal): New function that
11101         factorizes macro_define_object_internal and macro_define_function
11102         code.
11103         (macro_define_object_internal): Use macro_define_internal.
11104         (macro_define_function): Likewise.
11105
11106 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11107
11108         * macrocmd.c (extract_identifier): Return
11109         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11110         callers.
11111
11112 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11113
11114         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11115
11116 2019-02-05  Tom Tromey  <tom@tromey.com>
11117
11118         * target.c (target_stack::unpush): Move assertion earlier.
11119
11120 2019-01-30  Tom Tromey  <tom@tromey.com>
11121
11122         PR python/23615:
11123         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11124         (gdbpy_parse_and_eval): Likewise.
11125         * python/python-internal.h (gdbpy_allow_threads): New class.
11126
11127 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11128
11129         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11130         (aarch64_fbsd_fpregmap): Move earlier.
11131         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11132         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11133         instead of individual calls to trad_frame_set_reg_addr.
11134         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11135         earlier.
11136         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11137         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11138         instead of individual calls to trad_frame_set_reg_addr.
11139
11140 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11141
11142         * CONTRIBUTE: Replace contribution list with wiki link.
11143
11144 2019-01-25  Tom Tromey  <tom@tromey.com>
11145
11146         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11147
11148 2019-01-25  Tom Tromey  <tom@tromey.com>
11149
11150         * xtensa-linux-nat.c: Fix common/ includes.
11151         * xml-support.h: Fix common/ includes.
11152         * xml-support.c: Fix common/ includes.
11153         * x86-linux-nat.c: Fix common/ includes.
11154         * windows-nat.c: Fix common/ includes.
11155         * varobj.h: Fix common/ includes.
11156         * varobj.c: Fix common/ includes.
11157         * value.c: Fix common/ includes.
11158         * valops.c: Fix common/ includes.
11159         * utils.c: Fix common/ includes.
11160         * unittests/xml-utils-selftests.c: Fix common/ includes.
11161         * unittests/utils-selftests.c: Fix common/ includes.
11162         * unittests/unpack-selftests.c: Fix common/ includes.
11163         * unittests/tracepoint-selftests.c: Fix common/ includes.
11164         * unittests/style-selftests.c: Fix common/ includes.
11165         * unittests/string_view-selftests.c: Fix common/ includes.
11166         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11167         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11168         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11169         * unittests/rsp-low-selftests.c: Fix common/ includes.
11170         * unittests/parse-connection-spec-selftests.c: Fix common/
11171         includes.
11172         * unittests/optional-selftests.c: Fix common/ includes.
11173         * unittests/offset-type-selftests.c: Fix common/ includes.
11174         * unittests/observable-selftests.c: Fix common/ includes.
11175         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11176         * unittests/memrange-selftests.c: Fix common/ includes.
11177         * unittests/memory-map-selftests.c: Fix common/ includes.
11178         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11179         * unittests/function-view-selftests.c: Fix common/ includes.
11180         * unittests/environ-selftests.c: Fix common/ includes.
11181         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11182         * unittests/common-utils-selftests.c: Fix common/ includes.
11183         * unittests/cli-utils-selftests.c: Fix common/ includes.
11184         * unittests/array-view-selftests.c: Fix common/ includes.
11185         * ui-file.c: Fix common/ includes.
11186         * tui/tui-io.c: Fix common/ includes.
11187         * tracepoint.h: Fix common/ includes.
11188         * tracepoint.c: Fix common/ includes.
11189         * tracefile-tfile.c: Fix common/ includes.
11190         * top.h: Fix common/ includes.
11191         * top.c: Fix common/ includes.
11192         * thread.c: Fix common/ includes.
11193         * target/waitstatus.h: Fix common/ includes.
11194         * target/waitstatus.c: Fix common/ includes.
11195         * target.h: Fix common/ includes.
11196         * target.c: Fix common/ includes.
11197         * target-memory.c: Fix common/ includes.
11198         * target-descriptions.c: Fix common/ includes.
11199         * symtab.h: Fix common/ includes.
11200         * symfile.c: Fix common/ includes.
11201         * stap-probe.c: Fix common/ includes.
11202         * spu-linux-nat.c: Fix common/ includes.
11203         * sparc-nat.c: Fix common/ includes.
11204         * source.c: Fix common/ includes.
11205         * solib.c: Fix common/ includes.
11206         * solib-target.c: Fix common/ includes.
11207         * ser-unix.c: Fix common/ includes.
11208         * ser-tcp.c: Fix common/ includes.
11209         * ser-pipe.c: Fix common/ includes.
11210         * ser-base.c: Fix common/ includes.
11211         * selftest-arch.c: Fix common/ includes.
11212         * s12z-tdep.c: Fix common/ includes.
11213         * rust-exp.y: Fix common/ includes.
11214         * rs6000-aix-tdep.c: Fix common/ includes.
11215         * riscv-tdep.c: Fix common/ includes.
11216         * remote.c: Fix common/ includes.
11217         * remote-notif.h: Fix common/ includes.
11218         * remote-fileio.h: Fix common/ includes.
11219         * remote-fileio.c: Fix common/ includes.
11220         * regcache.h: Fix common/ includes.
11221         * regcache.c: Fix common/ includes.
11222         * record-btrace.c: Fix common/ includes.
11223         * python/python.c: Fix common/ includes.
11224         * python/py-type.c: Fix common/ includes.
11225         * python/py-inferior.c: Fix common/ includes.
11226         * progspace.h: Fix common/ includes.
11227         * producer.c: Fix common/ includes.
11228         * procfs.c: Fix common/ includes.
11229         * proc-api.c: Fix common/ includes.
11230         * printcmd.c: Fix common/ includes.
11231         * ppc-linux-nat.c: Fix common/ includes.
11232         * parser-defs.h: Fix common/ includes.
11233         * osdata.c: Fix common/ includes.
11234         * obsd-nat.c: Fix common/ includes.
11235         * nat/x86-linux.c: Fix common/ includes.
11236         * nat/x86-linux-dregs.c: Fix common/ includes.
11237         * nat/x86-dregs.h: Fix common/ includes.
11238         * nat/x86-dregs.c: Fix common/ includes.
11239         * nat/ppc-linux.c: Fix common/ includes.
11240         * nat/mips-linux-watch.h: Fix common/ includes.
11241         * nat/mips-linux-watch.c: Fix common/ includes.
11242         * nat/linux-waitpid.c: Fix common/ includes.
11243         * nat/linux-ptrace.h: Fix common/ includes.
11244         * nat/linux-ptrace.c: Fix common/ includes.
11245         * nat/linux-procfs.c: Fix common/ includes.
11246         * nat/linux-personality.c: Fix common/ includes.
11247         * nat/linux-osdata.c: Fix common/ includes.
11248         * nat/linux-namespaces.c: Fix common/ includes.
11249         * nat/linux-btrace.h: Fix common/ includes.
11250         * nat/linux-btrace.c: Fix common/ includes.
11251         * nat/fork-inferior.c: Fix common/ includes.
11252         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11253         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11254         * nat/aarch64-linux.c: Fix common/ includes.
11255         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11256         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11257         * namespace.h: Fix common/ includes.
11258         * mips-linux-tdep.c: Fix common/ includes.
11259         * minsyms.c: Fix common/ includes.
11260         * mi/mi-parse.h: Fix common/ includes.
11261         * mi/mi-main.c: Fix common/ includes.
11262         * mi/mi-cmd-env.c: Fix common/ includes.
11263         * memrange.h: Fix common/ includes.
11264         * memattr.c: Fix common/ includes.
11265         * maint.h: Fix common/ includes.
11266         * maint.c: Fix common/ includes.
11267         * main.c: Fix common/ includes.
11268         * machoread.c: Fix common/ includes.
11269         * location.c: Fix common/ includes.
11270         * linux-thread-db.c: Fix common/ includes.
11271         * linux-nat.c: Fix common/ includes.
11272         * linux-fork.c: Fix common/ includes.
11273         * inline-frame.c: Fix common/ includes.
11274         * infrun.c: Fix common/ includes.
11275         * inflow.c: Fix common/ includes.
11276         * inferior.h: Fix common/ includes.
11277         * inferior.c: Fix common/ includes.
11278         * infcmd.c: Fix common/ includes.
11279         * inf-ptrace.c: Fix common/ includes.
11280         * inf-child.c: Fix common/ includes.
11281         * ia64-linux-nat.c: Fix common/ includes.
11282         * i387-tdep.c: Fix common/ includes.
11283         * i386-tdep.c: Fix common/ includes.
11284         * i386-linux-tdep.c: Fix common/ includes.
11285         * i386-linux-nat.c: Fix common/ includes.
11286         * i386-go32-tdep.c: Fix common/ includes.
11287         * i386-fbsd-tdep.c: Fix common/ includes.
11288         * i386-fbsd-nat.c: Fix common/ includes.
11289         * guile/scm-type.c: Fix common/ includes.
11290         * guile/guile.c: Fix common/ includes.
11291         * go32-nat.c: Fix common/ includes.
11292         * gnu-nat.c: Fix common/ includes.
11293         * gdbthread.h: Fix common/ includes.
11294         * gdbarch-selftests.c: Fix common/ includes.
11295         * gdb_usleep.c: Fix common/ includes.
11296         * gdb_select.h: Fix common/ includes.
11297         * gdb_bfd.c: Fix common/ includes.
11298         * gcore.c: Fix common/ includes.
11299         * fork-child.c: Fix common/ includes.
11300         * findvar.c: Fix common/ includes.
11301         * fbsd-nat.c: Fix common/ includes.
11302         * event-top.c: Fix common/ includes.
11303         * event-loop.c: Fix common/ includes.
11304         * dwarf2read.c: Fix common/ includes.
11305         * dwarf2loc.c: Fix common/ includes.
11306         * dwarf2-frame.c: Fix common/ includes.
11307         * dwarf-index-cache.c: Fix common/ includes.
11308         * dtrace-probe.c: Fix common/ includes.
11309         * disasm-selftests.c: Fix common/ includes.
11310         * defs.h: Fix common/ includes.
11311         * csky-tdep.c: Fix common/ includes.
11312         * cp-valprint.c: Fix common/ includes.
11313         * cp-support.h: Fix common/ includes.
11314         * cp-support.c: Fix common/ includes.
11315         * corelow.c: Fix common/ includes.
11316         * completer.h: Fix common/ includes.
11317         * completer.c: Fix common/ includes.
11318         * compile/compile.c: Fix common/ includes.
11319         * compile/compile-loc2c.c: Fix common/ includes.
11320         * compile/compile-cplus-types.c: Fix common/ includes.
11321         * compile/compile-cplus-symbols.c: Fix common/ includes.
11322         * command.h: Fix common/ includes.
11323         * cli/cli-dump.c: Fix common/ includes.
11324         * cli/cli-cmds.c: Fix common/ includes.
11325         * charset.c: Fix common/ includes.
11326         * build-id.c: Fix common/ includes.
11327         * btrace.h: Fix common/ includes.
11328         * btrace.c: Fix common/ includes.
11329         * breakpoint.h: Fix common/ includes.
11330         * breakpoint.c: Fix common/ includes.
11331         * ax.h:
11332         (enum agent_op): Fix common/ includes.
11333         * ax-general.c (struct aop_map): Fix common/ includes.
11334         * ax-gdb.c: Fix common/ includes.
11335         * auxv.c: Fix common/ includes.
11336         * auto-load.c: Fix common/ includes.
11337         * arm-tdep.c: Fix common/ includes.
11338         * arch/riscv.c: Fix common/ includes.
11339         * arch/ppc-linux-common.c: Fix common/ includes.
11340         * arch/i386.c: Fix common/ includes.
11341         * arch/arm.c: Fix common/ includes.
11342         * arch/arm-linux.c: Fix common/ includes.
11343         * arch/arm-get-next-pcs.c: Fix common/ includes.
11344         * arch/amd64.c: Fix common/ includes.
11345         * arch/aarch64.c: Fix common/ includes.
11346         * arch/aarch64-insn.c: Fix common/ includes.
11347         * arch-utils.c: Fix common/ includes.
11348         * amd64-windows-tdep.c: Fix common/ includes.
11349         * amd64-tdep.c: Fix common/ includes.
11350         * amd64-sol2-tdep.c: Fix common/ includes.
11351         * amd64-obsd-tdep.c: Fix common/ includes.
11352         * amd64-nbsd-tdep.c: Fix common/ includes.
11353         * amd64-linux-tdep.c: Fix common/ includes.
11354         * amd64-linux-nat.c: Fix common/ includes.
11355         * amd64-fbsd-tdep.c: Fix common/ includes.
11356         * amd64-fbsd-nat.c: Fix common/ includes.
11357         * amd64-dicos-tdep.c: Fix common/ includes.
11358         * amd64-darwin-tdep.c: Fix common/ includes.
11359         * agent.c: Fix common/ includes.
11360         * ada-lang.h: Fix common/ includes.
11361         * ada-lang.c: Fix common/ includes.
11362         * aarch64-tdep.c: Fix common/ includes.
11363
11364 2019-01-25  Tom Tromey  <tom@tromey.com>
11365
11366         * common/create-version.sh: Use common/version.h.
11367
11368 2019-01-24  Pedro Alves  <palves@redhat.com>
11369
11370         * infrun.c (signal_stop, signal_print, signal_program)
11371         (signal_catch, signal_pass): Now arrays instead of pointers.
11372         (update_signals_program_target, do_target_resume)
11373         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11374         * linux-nat.c (linux_nat_target::pass_signals)
11375         (linux_nat_target::create_inferior, linux_nat_target::attach):
11376         Adjust.
11377         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11378         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11379         * procfs.c (procfs_target::pass_signals): Adjust.
11380         * record-full.c (record_full_target::resume): Adjust.
11381         * remote.c (remote_target::pass_signals)
11382         (remote_target::program_signals): Adjust.
11383         * target-debug.h (target_debug_print_signals): Now takes a
11384         gdb::array_view as parameter.  Adjust.
11385         * target.h (target_ops) <pass_signals, program_signals>: Replace
11386         pointer and length parameters with gdb::array_view.
11387         (target_pass_signals, target_program_signals): Likewise.
11388         * target-delegates.c: Regenerate.
11389
11390 2019-01-24  Pedro Alves  <palves@redhat.com>
11391
11392         * common/forward-scope-exit.h
11393         (forward_scope_exit::forward_scope_exit): Pass arguments to
11394         m_bind_function directly, instead of creating a std::bind and
11395         copying that.
11396
11397 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11398
11399         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11400         for static members.
11401         (pass_in_v_vfp_candidate): Likewise.
11402
11403 2019-01-23  Tom Tromey  <tom@tromey.com>
11404             Pedro Alves  <palves@redhat.com>
11405
11406         * regcache.c (class regcache_invalidator): Remove.
11407         (regcache::raw_write): Use make_scope_exit.
11408
11409 2019-01-23  Tom Tromey  <tom@tromey.com>
11410
11411         * ui-out.h (class ui_out_emit_type): Update comment.
11412
11413 2019-01-23  Tom Tromey  <tom@tromey.com>
11414
11415         * infrun.c (fetch_inferior_event): Update comment.
11416
11417 2019-01-23  Tom Tromey  <tom@tromey.com>
11418             Pedro Alves  <palves@redhat.com>
11419
11420         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11421         parameter.
11422         (fetch_inferior_event): Use SCOPE_EXIT.
11423
11424
11425 2019-01-23  Tom Tromey  <tom@tromey.com>
11426             Pedro Alves  <palves@redhat.com>
11427
11428         * infrun.c (disable_thread_events): Delete.
11429         (stop_all_threads): Use SCOPE_EXIT.
11430
11431 2019-01-23  Tom Tromey  <tom@tromey.com>
11432             Pedro Alves  <palves@redhat.com>
11433
11434         * symfile.c: Include forward-scope-exit.h.
11435         (clear_symtab_users_cleanup): Replace forward declaration with
11436         a FORWARD_SCOPE_EXIT.
11437         (syms_from_objfile_1): Use the forward_scope_exit and
11438         gdb::optional instead of cleanup_function.
11439         (reread_symbols): Use the forward_scope_exit instead of
11440         cleanup_function.
11441         (clear_symtab_users_cleanup): Remove function.
11442
11443 2019-01-23  Tom Tromey  <tom@tromey.com>
11444             Pedro Alves  <palves@redhat.com>
11445
11446         * linux-nat.c: Include scope-exit.h.
11447         (cleanup_target_stop): Remove.
11448         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11449         SCOPE_EXIT.
11450
11451 2019-01-23  Tom Tromey  <tom@tromey.com>
11452             Pedro Alves  <palves@redhat.com>
11453
11454         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11455         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11456
11457 2019-01-23  Tom Tromey  <tom@tromey.com>
11458             Andrew Burgess  <andrew.burgess@embecosm.com>
11459             Pedro Alves  <palves@redhat.com>
11460
11461         * infrun.c (fetch_inferior_event): Use scope_exit.
11462         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11463         * top.c (execute_command): Use scope_exit.
11464         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11465         * utils.c (do_bpstat_clear_actions_cleanup)
11466         (make_bpstat_clear_actions_cleanup): Remove.
11467
11468 2019-01-23  Tom Tromey  <tom@tromey.com>
11469             Pedro Alves  <palves@redhat.com>
11470
11471         * infrun.c: Include "common/scope-exit.h"
11472         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11473         (wait_for_inferior): Use SCOPE_EXIT.
11474         (fetch_inferior_event): Use scope_exit.
11475
11476 2019-01-23  Tom Tromey  <tom@tromey.com>
11477             Pedro Alves  <palves@redhat.com>
11478
11479         * breakpoint.c (create_breakpoint): Remove cleanup.
11480
11481 2019-01-23  Tom Tromey  <tom@tromey.com>
11482             Andrew Burgess  <andrew.burgess@embecosm.com>
11483             Pedro Alves  <palves@redhat.com>
11484
11485 2019-01-23  Pedro Alves  <palves@redhat.com>
11486
11487         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11488
11489 2019-01-23  Pedro Alves  <palves@redhat.com>
11490             Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * gdbthread.h: Include "common/forward-scope-exit.h".
11493         (scoped_finish_thread_state): Redefine custom class in terms of
11494         forward_scope_exit.
11495
11496 2019-01-23  Pedro Alves  <palves@redhat.com>
11497             Andrew Burgess  <andrew.burgess@embecosm.com>
11498
11499         * common/forward-scope-exit.h: New file.
11500
11501 2019-01-23  Pedro Alves  <palves@redhat.com>
11502             Andrew Burgess  <andrew.burgess@embecosm.com>
11503             Tom Tromey  <tom@tromey.com>
11504
11505         * common/scope-exit.h: New file.
11506
11507 2019-01-23  Pedro Alves  <palves@redhat.com>
11508
11509         * common/preprocessor.h (ESC): Rename to ...
11510         (ESC_PARENS): ... this.
11511         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11512         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11513
11514 2019-01-23  Tom Tromey  <tom@tromey.com>
11515
11516         * language.h (class scoped_switch_to_sym_language_if_auto):
11517         Initialize m_lang in both cases.
11518
11519 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11520
11521         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11522         with XCNEW.
11523
11524 2019-01-22  Tom Tromey  <tom@tromey.com>
11525
11526         * corelow.c: Do not include sys/file.h.
11527
11528 2019-01-22  Tom Tromey  <tom@tromey.com>
11529
11530         * tui/tui-wingeneral.h: Include gdb_curses.h.
11531
11532 2019-01-22  Tom Tromey  <tom@tromey.com>
11533
11534         * source-cache.h (class source_cache) <get_source_lines,
11535         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11536
11537 2019-01-22  Tom Tromey  <tom@tromey.com>
11538
11539         * remote-fileio.h (struct remote_target): Declare.
11540
11541 2019-01-22  Tom Tromey  <tom@tromey.com>
11542
11543         * python/py-arch.c: Do not include py-ref.h.
11544         * python/py-bpevent.c: Do not include py-ref.h.
11545         * python/py-cmd.c: Do not include py-ref.h.
11546         * python/py-continueevent.c: Do not include py-ref.h.
11547         * python/py-event.h: Do not include py-ref.h.
11548         * python/py-evtregistry.c: Do not include py-ref.h.
11549         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11550         * python/py-frame.c: Do not include py-ref.h.
11551         * python/py-framefilter.c: Do not include py-ref.h.
11552         * python/py-function.c: Do not include py-ref.h.
11553         * python/py-infevents.c: Do not include py-ref.h.
11554         * python/py-linetable.c: Do not include py-ref.h.
11555         * python/py-objfile.c: Do not include py-ref.h.
11556         * python/py-param.c: Do not include py-ref.h.
11557         * python/py-prettyprint.c: Do not include py-ref.h.
11558         * python/py-progspace.c: Do not include py-ref.h.
11559         * python/py-symbol.c: Do not include py-ref.h.
11560         * python/py-symtab.c: Do not include py-ref.h.
11561         * python/py-type.c: Do not include py-ref.h.
11562         * python/py-unwind.c: Do not include py-ref.h.
11563         * python/py-utils.c: Do not include py-ref.h.
11564         * python/py-value.c: Do not include py-ref.h.
11565         * python/py-varobj.c: Do not include py-ref.h.
11566         * python/py-xmethods.c: Do not include py-ref.h.
11567         * python/python.c: Do not include py-ref.h.
11568         * varobj.c: Do not include py-ref.h.
11569
11570 2019-01-22  Tom Tromey  <tom@tromey.com>
11571
11572         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11573         keyword for bcache.
11574
11575 2019-01-22  Tom Tromey  <tom@tromey.com>
11576
11577         * compile/compile-cplus-types.c: Remove a comment by #include.
11578
11579 2019-01-22  Tom Tromey  <tom@tromey.com>
11580
11581         * compile/gcc-c-plugin.h: Include compile-internal.h.
11582
11583 2019-01-22  Tom Tromey  <tom@tromey.com>
11584
11585         * stabsread.c (EXTERN): Do not define.
11586         (symnum, next_symbol_text_func, processing_gcc_compilation)
11587         (within_function, global_sym_chain, global_stabs)
11588         (previous_stab_code, this_object_header_files)
11589         (n_this_object_header_files)
11590         (n_allocated_this_object_header_files): Define.
11591         * stabsread.h (EXTERN): Never define.  Use "extern".
11592
11593 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11594
11595         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11596         history_value.
11597
11598 2019-01-21  Tom Tromey  <tom@tromey.com>
11599
11600         * ui-out.c: Fix includes.
11601         * tui/tui-source.c: Fix includes.
11602         * target.c: Fix includes.
11603         * remote.c: Fix includes.
11604         * regcache.c: Fix includes.
11605         * python/py-block.c: Fix includes.
11606         * printcmd.c: Fix includes.
11607         * or1k-tdep.c: Fix includes.
11608         * mi/mi-main.c: Fix includes.
11609         * m32r-tdep.c: Fix includes.
11610         * csky-tdep.c: Fix includes.
11611         * compile/compile-cplus-types.c: Fix includes.
11612         * cli/cli-interp.c: Fix includes.
11613
11614 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11615
11616         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11617         for padding.
11618
11619 2019-01-16  Tom Tromey  <tom@tromey.com>
11620
11621         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11622         earlier.
11623         (struct objfile) <msymbols_range>: Move from top level.
11624         <msymbols>: New method.
11625         (class objfile_msymbols): Remove.
11626         * symtab.c (default_collect_symbol_completion_matches_break_on):
11627         Update.
11628         * symmisc.c (dump_msymbols): Update.
11629         * stabsread.c (scan_file_globals): Update.
11630         * objc-lang.c (info_selectors_command, info_classes_command)
11631         (find_methods): Update.
11632         * minsyms.c (find_solib_trampoline_target): Update.
11633         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11634         * coffread.c (coff_symfile_read): Update.
11635         * ada-lang.c (ada_lookup_simple_minsym)
11636         (ada_collect_symbol_completion_matches): Update.
11637
11638 2019-01-16  Tom Tromey  <tom@tromey.com>
11639
11640         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11641         type.  Remove no-argument constructor.
11642         <iterator::operator++>: Simplify.
11643         <begin>: Update.
11644         <end>: Use minimal_symbol_count.
11645
11646 2019-01-16  Tom Tromey  <tom@tromey.com>
11647
11648         * objfiles.h (struct objfile) <psymtabs>: New method.
11649         (class objfile_psymtabs): Remove.
11650         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11651         typedef.
11652         <range>: New method.
11653         (require_partial_symbols): Change return type.
11654         * psymtab.c (require_partial_symbols)
11655         (psym_expand_symtabs_matching): Update.
11656         * mdebugread.c (parse_partial_symbols): Update.
11657         * dbxread.c (dbx_end_psymtab): Update.
11658
11659 2019-01-15  Tom Tromey  <tom@tromey.com>
11660
11661         * symtab.c (lookup_objfile_from_block)
11662         (lookup_symbol_in_objfile_symtabs)
11663         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11664         (find_line_symtab, info_sources_command)
11665         (default_collect_symbol_completion_matches_break_on)
11666         (make_source_files_completion_list): Update.
11667         * symmisc.c (print_objfile_statistics, dump_objfile)
11668         (maintenance_print_symbols, maintenance_info_symtabs)
11669         (maintenance_check_symtabs, maintenance_info_line_tables):
11670         Update.
11671         * source.c (select_source_symtab)
11672         (forget_cached_source_info_for_objfile): Update.
11673         * objfiles.h (class objfile_compunits): Remove.
11674         (struct objfile) <compunits_range>: New typedef.
11675         (compunits): New method.
11676         * objfiles.c (objfile_relocate1): Update.
11677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11678         * maint.c (count_symtabs_and_blocks): Update.
11679         * linespec.c (iterate_over_all_matching_symtabs): Update.
11680         * cp-support.c (add_symbol_overload_list_qualified): Update.
11681         * coffread.c (coff_symtab_read): Update.
11682         * ada-lang.c (add_nonlocal_symbols)
11683         (ada_collect_symbol_completion_matches)
11684         (ada_add_global_exceptions): Update.
11685
11686 2019-01-15  Tom Tromey  <tom@tromey.com>
11687
11688         * progspace.h (program_space) <objfiles_safe_range>: New
11689         typedef.
11690         <objfiles_safe>: New method.
11691         * objfiles.h (class all_objfiles_safe): Remove.
11692         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11693         * jit.c (jit_inferior_exit_hook): Update.
11694
11695 2019-01-17  Tom Tromey  <tom@tromey.com>
11696
11697         * progspace.h (program_space) <objfiles_range>: New typedef.
11698         <objfiles>: New method.
11699         <objfiles_head>: Rename from objfiles.
11700         (object_files): Update.
11701         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11702         * guile/scm-pretty-print.c
11703         (ppscm_find_pretty_printer_from_objfiles): Update.
11704         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11705         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11706         Update.
11707         * python/py-progspace.c (pspy_get_objfiles): Update.
11708         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11709         Update.
11710         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11711         (objfpy_lookup_objfile_by_build_id): Update.
11712         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11713         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11714         Update.
11715         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11716         (expand_symtab_containing_pc, lookup_objfile_from_block)
11717         (lookup_static_symbol, basic_lookup_transparent_type)
11718         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11719         (find_line_symtab, info_sources_command)
11720         (default_collect_symbol_completion_matches_break_on)
11721         (make_source_files_completion_list, find_main_name): Update.
11722         * symmisc.c (print_symbol_bcache_statistics)
11723         (print_objfile_statistics, maintenance_print_symbols)
11724         (maintenance_print_msymbols, maintenance_print_objfiles)
11725         (maintenance_info_symtabs, maintenance_check_symtabs)
11726         (maintenance_expand_symtabs, maintenance_info_line_tables):
11727         Update.
11728         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11729         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11730         (map_overlay_command, unmap_overlay_command)
11731         (simple_overlay_update, expand_symtabs_matching)
11732         (map_symbol_filenames): Update.
11733         * symfile-debug.c (set_debug_symfile): Update.
11734         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11735         Update.
11736         * source.c (select_source_symtab, forget_cached_source_info):
11737         Update.
11738         * solib.c (solib_read_symbols): Update.
11739         * solib-spu.c (append_ocl_sos): Update.
11740         * psymtab.c (maintenance_print_psymbols)
11741         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11742         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11743         * printcmd.c (info_symbol_command): Update.
11744         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11745         Update.
11746         * objfiles.h (class all_objfiles): Remove.
11747         * objfiles.c (have_partial_symbols, have_full_symbols)
11748         (have_minimal_symbols, qsort_cmp, update_section_map)
11749         (shared_objfile_contains_address_p)
11750         (default_iterate_over_objfiles_in_search_order): Update.
11751         * objc-lang.c (info_selectors_command, info_classes_command)
11752         (find_methods): Update.
11753         * minsyms.c (find_solib_trampoline_target): Update.
11754         * maint.c (maintenance_info_sections)
11755         (maintenance_translate_address, count_symtabs_and_blocks):
11756         Update.
11757         * main.c (captured_main_1): Update.
11758         * linux-thread-db.c (try_thread_db_load_from_pdir)
11759         (has_libpthread): Update.
11760         * linespec.c (iterate_over_all_matching_symtabs)
11761         (search_minsyms_for_name): Update.
11762         * jit.c (jit_find_objf_with_entry_addr): Update.
11763         * hppa-tdep.c (find_unwind_entry)
11764         (hppa_lookup_stub_minimal_symbol): Update.
11765         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11766         Update.
11767         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11768         (elf_gnu_ifunc_resolve_by_got): Update.
11769         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11770         * dwarf-index-write.c (save_gdb_index_command): Update.
11771         * cp-support.c (add_symbol_overload_list_qualified): Update.
11772         * breakpoint.c (create_overlay_event_breakpoint)
11773         (create_longjmp_master_breakpoint)
11774         (create_std_terminate_master_breakpoint)
11775         (create_exception_master_breakpoint): Update.
11776         * blockframe.c (find_pc_partial_function): Update.
11777         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11778         (ada_collect_symbol_completion_matches)
11779         (ada_add_global_exceptions): Update.
11780
11781 2019-01-17  Tom Tromey  <tom@tromey.com>
11782
11783         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11784         declare VEC.
11785         (solib_target_parse_libraries): Change return type.
11786         (library_list_start_segment, library_list_start_section)
11787         (library_list_end_library, library_list_start_library); Update.
11788         (solib_target_free_library_list): Remove.
11789         (solib_target_parse_libraries): Remove cleanup.  Change return
11790         type.
11791         (solib_target_current_sos): Update.
11792
11793 2019-01-17  Tom Tromey  <tromey@bapiya>
11794
11795         * valprint.c: Replace "the the" with "the".
11796         * symtab.c: Replace "the the" with "the".
11797         * solib.c: Replace "the the" with "the".
11798         * solib-dsbt.c: Replace "the the" with "the".
11799         * linespec.c: Replace "the the" with "the".
11800         * dwarf2loc.h: Replace "the the" with "the".
11801         * amd64-windows-tdep.c: Replace "the the" with "the".
11802         * aarch64-tdep.c: Replace "the the" with "the".
11803
11804 2019-01-16  Keith Seitz  <keiths@redhat.com>
11805
11806         PR gdb/23773
11807         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11808         <builder>: Rename to ..
11809         <m_builder>: ... this and make private.
11810         (dwarf2_cu::get_builder): New method.  Change all users of
11811         `builder' to use this method.
11812         (dwarf2_start_symtab): Move to ...
11813         (dwarf2_cu::start_symtab): ... here.  Update all callers
11814         (setup_type_unit_groups): Move to ...
11815         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11816         callers.
11817         (dwarf2_cu::reset_builder): New method.
11818         (process_full_compunit, process_full_type_unit): Use
11819         dwarf2_cu::reset_builder.
11820         (follow_die_offset): Record the ancestor CU if it is different
11821         from the followed DIE's CU.
11822         (follow_die_sig_1): Likewise.
11823
11824 2019-01-15  Tom Tromey  <tom@tromey.com>
11825
11826         * remote.c (class remote_state) <buf>: Now a char_vector.
11827         <buf_size>: Remove.
11828         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11829         parameter.
11830         (remote_target::getpkt_or_notif_sane_1)
11831         (remote_target::getpkt_sane)
11832         (remote_target::getpkt_or_notif_sane): Likewise.
11833         (class remote_target) <putpkt>: New overload.
11834         (remote_target::read_frame): Change type of "buf_p".  Remove
11835         sizeof_p parameter.
11836         (packet_ok): New overload.
11837         (packet_check_result): New overload.
11838         Update all uses.
11839
11840 2019-01-14  Tom Tromey  <tom@tromey.com>
11841
11842         * remote-notif.c (handle_notification, remote_notif_ack)
11843         (remote_notif_parse): Make "buf" const.
11844         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11845         const.
11846         (remote_notif_parse, remote_notif_ack, handle_notification):
11847         Likewise.
11848         * remote.c (remote_notif_stop_parse): Make "buf" const.
11849         (remote_target::remote_parse_stop_reply): Make "buf" const.
11850         (remote_notif_stop_ack): Make "buf" const.
11851
11852 2019-01-14  Tom Tromey  <tom@tromey.com>
11853
11854         * remote.c (remote_console_output): Make parameter const.
11855
11856 2019-01-14  Tom Tromey  <tom@tromey.com>
11857
11858         * target-debug.h (target_debug_print_signals): Constify.
11859         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11860         * procfs.c (procfs_target::pass_signals): Update.
11861         * linux-nat.c (linux_nat_target::pass_signals): Update.
11862         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11863         * target-delegates.c: Rebuild.
11864         * remote.c (remote_target::program_signals): Update.
11865         (remote_target::pass_signals): Update.
11866         * target.c (target_pass_signals): Constify argument.
11867         (target_program_signals): Likewise.
11868         * target.h (struct target_ops) <pass_signals, program_signals>:
11869         Constify argument.
11870         (target_pass_signals, target_program_signals): Constify argument.
11871
11872 2019-01-14  Tom Tromey  <tom@tromey.com>
11873
11874         PR tui/28819:
11875         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11876
11877 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11878
11879         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11880         field.
11881         * rs6000-tdep.c: Include reggroups.h.
11882         (IS_V_ALIAS_PSEUDOREG): Define.
11883         (rs6000_register_name): Return names for the "vX" aliases.
11884         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11885         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11886         aliases.  Call default_register_reggroup_p for all other
11887         pseudo-registers.
11888         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11889         New functions.
11890         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11891         Handle "vX" aliases.
11892         (v_alias_pseudo_register_collect): New function.
11893         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11894         (rs6000_gdbarch_init): Initialize "vX" aliases as
11895         pseudo-registers.  Restore registration of
11896         rs6000_pseudo_register_reggroup_p with
11897         set_tdesc_pseudo_register_reggroup_p.
11898
11899 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11900
11901         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11902         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11903         set_gdbarch_num_pseudo_regs.
11904
11905 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11906
11907         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11908         Remove arg prefixname, add do_set and do_show.
11909         Add member functions set_list and show_list.
11910         * cli/cli-style.c (class cli_style_option): Update accordingly.
11911         (style_set_list): Move to file scope.
11912         (style_show_list): Likewise.
11913         (set_style): Call help_list.
11914         (show_style): Call cmd_show_list.
11915         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11916         Update to use the new macro.
11917
11918 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11919
11920         * ada-lang.c (_initialize_ada_language): Expand the help text
11921         for the "catch exception" command.
11922
11923 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11924
11925         * symtab.c (matching_obj_sections): Initialize obj,
11926         declare it closer to its usage.
11927
11928 2019-01-10  Tom Tromey  <tom@tromey.com>
11929
11930         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11931         (basic_inf_threads_range): Remove.
11932         (inf_threads_range, inf_non_exited_threads_range)
11933         (safe_inf_threads_range): Use next_adapter.
11934
11935 2019-01-10  Keith Seitz  <keiths@redhat.com>
11936
11937         PR gdb/23712
11938         PR symtab/23010
11939         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11940         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11941
11942 2019-01-10  Keith Seitz  <keiths@redhat.com>
11943
11944         PR gdb/23712
11945         PR symtab/23010
11946         * dictionary.c (pending_to_vector): Remove.
11947         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11948         Remove _1 suffix, replacing functions of the same name.  Update
11949         all callers.
11950         (dict_create_hashed, dict_create_hashed_expandable)
11951         (dict_create_linear, dict_create_linear_expandable, dict_free)
11952         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11953         Make functions static.
11954
11955 2019-01-10  Keith Seitz  <keiths@redhat.com>
11956
11957         PR gdb/23712
11958         PR symtab/23010
11959         * dictionary.h (struct dictionary): Replace declaration with
11960         multidictionary.
11961         (dict_create_hashed, dict_create_hashed_expandable)
11962         (dict_create_linear, dict_create_linear_expandable)
11963         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11964         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11965         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11966         taking multidictionary argument.
11967         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11968         * block.h (struct block) <dict>: Change to multidictionary
11969         and rename `multidict'.
11970         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11971         symmisc.c: Update all dictionary references to multidictionary.
11972
11973 2019-01-10  Keith Seitz  <keiths@redhat.com>
11974
11975         PR gdb/23712
11976         PR symtab/23010
11977         * dictionary.c: Include unordered_map.
11978         (pending_to_vector): New function.
11979         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11980         Rewrite the non-"_1" functions to take vector instead
11981         of linked list.
11982         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11983         "new" _1 versions of the same name.
11984         (multidictionary): Define.
11985         (std::hash<enum language): New definition.
11986         (collate_pending_symbols_by_language, mdict_create_hashed)
11987         (mdict_create_hashed_expandable, mdict_create_linear)
11988         (mdict_create_linear_expandable, mdict_free)
11989         (find_language_dictionary, create_new_language_dictionary)
11990         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11991         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11992         (mdict_size, mdict_empty): New functions.
11993         * dictionary.h (mdict_iterator): Define.
11994
11995 2019-01-10  Pedro Alves  <palves@redhat.com>
11996
11997         * breakpoint.c (read_uploaded_action)
11998         (create_tracepoint_from_upload): Adjust to use
11999         gdb::unique_xmalloc_ptr.
12000         * ctf.c (ctf_write_uploaded_tp):
12001         (SET_ARRAY_FIELD): Use emplace_back.
12002         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12003         * tracefile-tfile.c (tfile_write_uploaded_tp):
12004         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12005         gdb::unique_xmalloc_ptr.
12006         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12007         at_string, cond_string, cmd_strings>: Replace char pointers
12008         with gdb::unique_xmalloc_ptr.
12009
12010 2019-01-10  Pedro Alves  <palves@redhat.com>
12011
12012         * solib-target.c (library_list_start_library): Don't xstrdup name.
12013
12014 2019-01-10  Pedro Alves  <palves@redhat.com>
12015
12016         * mdebugread.c (parse_partial_symbols): Use
12017         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12018
12019 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12020
12021         * linux-fork.c (scoped_switch_fork_info)
12022         <~scoped_switch_fork_info>: Fix incorrect variable name.
12023
12024 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12025
12026         * linux-fork.c (scoped_switch_fork_info)
12027         <scoped_switch_fork_info>: Make explicit.
12028         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12029
12030 2019-01-10  Tom Tromey  <tom@tromey.com>
12031
12032         * objfiles.h (objfile::reset_psymtabs): Update.
12033         * objfiles.c (objfile::objfile): Update.
12034         * psymtab.h (psymtab_storage::obstack): Update.
12035         (psymtab_storage::m_obstack): Use gdb::optional.
12036         (class psymtab_storage): Update comment.  Remove objfile
12037         parameter.
12038         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12039
12040 2019-01-10  Tom Tromey  <tom@tromey.com>
12041
12042         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12043         <free_psymtabs>: Now private.
12044         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12045         (allocate_psymtab): Use new method.
12046
12047 2019-01-10  Tom Tromey  <tom@tromey.com>
12048
12049         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12050         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12051         * mdebugread.c (parse_partial_symbols): Use
12052         allocate_dependencies.
12053         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12054         allocate_dependencies.
12055         (process_psymtab_comp_unit_reader)
12056         (build_type_psymtab_dependencies): Likewise.
12057         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12058
12059 2019-01-10  Tom Tromey  <tom@tromey.com>
12060
12061         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12062         PSYMBOL_SET_LANGUAGE.
12063         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12064
12065 2019-01-10  Tom Tromey  <tom@tromey.com>
12066
12067         * psymtab.h (psymtab_storage::obstack): New method.
12068         <m_obstack>: Rename from obstack; now private.
12069         * psymtab.c (psymtab_storage): Update.
12070         * dwarf2read.c (create_addrmap_from_index)
12071         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12072         Update.
12073
12074 2019-01-10  Tom Tromey  <tom@tromey.com>
12075
12076         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12077         * objfiles.h (objfile::reset_psymtabs): New method.
12078
12079 2019-01-10  Tom Tromey  <tom@tromey.com>
12080
12081         * symmisc.c (print_symbol_bcache_statistics): Update.
12082         (print_objfile_statistics): Update.
12083         * symfile.c (reread_symbols): Update.
12084         * psymtab.h (class psymtab_storage): New.
12085         * psymtab.c (psymtab_storage): New constructor.
12086         (~psymtab_storage): New destructor.
12087         (require_partial_symbols): Update.
12088         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12089         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12090         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12091         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12092         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12093         (start_psymtab_common, end_psymtab_common)
12094         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12095         (allocate_psymtab): Update.
12096         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12097         Update.
12098         (dump_psymtab_addrmap, maintenance_print_psymbols)
12099         (maintenance_check_psymtabs): Update.
12100         (class objfile_psymtabs): Move to objfiles.h.
12101         * psympriv.h (discard_psymtab): Now inline.
12102         (psymtab_discarder::psymtab_discarder): Update.
12103         (psymtab_discarder::~psymtab_discarder): Update.
12104         (ALL_OBJFILE_PSYMTABS): Rewrite.
12105         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12106         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12107         Remove fields.
12108         <partial_symtabs>: New field.
12109         (class objfile_psymtabs): Move from psymtab.h.  Update.
12110         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12111         psymbol_cache.
12112         (objfile::~objfile): Don't destroy psymbol_cache.
12113         * mdebugread.c (parse_partial_symbols): Update.
12114         * dwarf2read.c (create_addrmap_from_index)
12115         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12116         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12117         (add_partial_subprogram, dwarf2_ranges_read): Update.
12118         * dwarf-index-write.c (write_address_map)
12119         (write_one_signatured_type, recursively_write_psymbols)
12120         (class debug_names, class debug_names, write_psymtabs_to_index):
12121         Update.
12122
12123 2019-01-10  Tom Tromey  <tom@tromey.com>
12124
12125         * symtab.h (SYMBOL_SET_NAMES): Update.
12126         (symbol_set_names): Update.
12127         (MSYMBOL_SET_NAMES): Update.
12128         * symtab.c (symbol_set_names): Change argument to be an
12129         objfile_per_bfd_storage.
12130         * psymtab.c (add_psymbol_to_bcache): Update.
12131         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12132
12133 2019-01-10  Tom Tromey  <tom@tromey.com>
12134
12135         * symtab.c (create_demangled_names_hash): Change argument to be an
12136         objfile_per_bfd_storage.
12137         (symbol_set_names): Update.
12138
12139 2019-01-10  Tom Tromey  <tom@tromey.com>
12140
12141         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12142         init_psymbol_list.
12143         * psymtab.c (init_psymbol_list): Do nothing if already called.
12144         * psympriv.h (init_psymbol_list): Add comment.
12145         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12146         init_psymbol_list.
12147         * dbxread.c (dbx_symfile_read): Unconditionally call
12148         init_psymbol_list.
12149
12150 2019-01-10  Tom Tromey  <tom@tromey.com>
12151
12152         * xcoffread.c (scan_xcoff_symtab): Update.
12153         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12154         "where".
12155         * mdebugread.c (parse_partial_symbols)
12156         (handle_psymbol_enumerators): Update.
12157         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12158         * dbxread.c (read_dbx_symtab): Update.
12159         * psympriv.h (psymbol_placement): New enum.
12160         (add_psymbol_to_list): Update.
12161
12162 2019-01-10  Tom Tromey  <tom@tromey.com>
12163
12164         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12165         static_psymbols parameters.
12166         (scan_xcoff_symtab): Update.
12167         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12168         static_psymbols parameters.
12169         * psympriv.h (start_psymtab_common): Update.
12170         * mdebugread.c (parse_partial_symbols): Update.
12171         * dwarf2read.c (create_partial_symtab): Update.
12172         * dbxread.c (read_dbx_symtab): Update.
12173         (start_psymtab): Remove global_psymbols and static_psymbols
12174         parameters.
12175
12176 2019-01-10  Tom Tromey  <tom@tromey.com>
12177
12178         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12179         * psymtab.c (allocate_psymtab): Add comment.
12180         * psympriv.h (allocate_psymtab): Add comment.
12181         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12182         initializations.
12183         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12184
12185 2019-01-10  Tom Tromey  <tom@tromey.com>
12186
12187         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12188         Don't declare.
12189         * mipsread.c: Include mdebugread.h.
12190         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12191         Declare.
12192         * elfread.c: Include mdebugread.h.
12193
12194 2019-01-09  Tom Tromey  <tom@tromey.com>
12195
12196         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12197         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12198         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12199         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12200         (psym_lookup_symbol, psym_find_last_source_symtab)
12201         (psym_forget_cached_source_info, psym_print_stats)
12202         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12203         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12204         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12205         (psym_find_compunit_symtab_by_address)
12206         (maintenance_print_psymbols, maintenance_info_psymtabs)
12207         (maintenance_check_psymtabs): Use ranged for.
12208         * psymtab.h (class objfile_psymtabs): New.
12209         (require_partial_symbols): Return objfile_psymtabs.
12210         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12211
12212 2019-01-09  Tom Tromey  <tom@tromey.com>
12213
12214         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12215         (find_pc_mapped_section, list_overlays_command)
12216         (map_overlay_command, unmap_overlay_command)
12217         (simple_overlay_update): Use all_objfiles.
12218         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12219         * printcmd.c (info_symbol_command): Use all_objfiles.
12220         * objfiles.h (ALL_OBJSECTIONS): Remove.
12221         * maint.c (maintenance_translate_address): Use all_objfiles.
12222         * gcore.c (gcore_create_callback): Use all_objfiles.
12223         (objfile_find_memory_regions): Likewise.
12224
12225 2019-01-09  Tom Tromey  <tom@tromey.com>
12226
12227         * symtab.c (find_line_symtab, info_sources_command)
12228         (make_source_files_completion_list): Use objfile_compunits.
12229         * source.c (select_source_symtab): Use objfile_compunits.
12230         * objfiles.h (struct objfile): Update comment.
12231         (ALL_OBJFILES): Remove.
12232         (ALL_FILETABS): Remove.
12233         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12234         objfile_compunits.
12235
12236 2019-01-09  Tom Tromey  <tom@tromey.com>
12237
12238         * symmisc.c (print_objfile_statistics, dump_objfile)
12239         (maintenance_print_symbols): Use compunit_filetabs.
12240         * source.c (forget_cached_source_info_for_objfile): Use
12241         compunit_filetabs.
12242         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12243         (ALL_FILETABS): Use compunit_filetabs.
12244         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12245         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12246
12247 2019-01-09  Tom Tromey  <tom@tromey.com>
12248
12249         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12250         (compunit_filetabs): New.
12251         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12252         compunit_filetabs.
12253         (info_sources_command, make_source_files_completion_list): Remove
12254         declaration.
12255         * symmisc.c (print_objfile_statistics, dump_objfile)
12256         (maintenance_print_symbols): Remove declaration.
12257         (maintenance_info_symtabs): Use compunit_filetabs.
12258         (maintenance_info_line_tables): Likewise.
12259         * source.c (select_source_symtab): Change local variable name.
12260         (forget_cached_source_info_for_objfile): Remove declaration.
12261         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12262         * objfiles.c (objfile_relocate1): Remove declaration.
12263         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12264         declaration.
12265         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12266         * coffread.c (coff_symtab_read): Remove declaration.
12267         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12268         compunit_filetabs.
12269
12270 2019-01-09  Tom Tromey  <tom@tromey.com>
12271
12272         * symtab.c (lookup_objfile_from_block)
12273         (find_pc_sect_compunit_symtab, search_symbols)
12274         (default_collect_symbol_completion_matches_break_on): Use
12275         objfile_compunits.
12276         * objfiles.h (ALL_COMPUNITS): Remove.
12277         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12278         * cp-support.c (add_symbol_overload_list_qualified): Use
12279         objfile_compunits.
12280         * ada-lang.c (ada_collect_symbol_completion_matches)
12281         (ada_add_global_exceptions): Use objfile_compunits.
12282
12283 2019-01-09  Tom Tromey  <tom@tromey.com>
12284
12285         * source.c (select_source_symtab)
12286         (forget_cached_source_info_for_objfile): Remove declaration.
12287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12288         declaration.
12289         * maint.c (count_symtabs_and_blocks): Remove declaration.
12290         * cp-support.c (add_symbol_overload_list_qualified): Remove
12291         declaration.
12292         * coffread.c (coff_symtab_read): Remove declaration.
12293         * symtab.c (lookup_symbol_in_objfile_symtabs)
12294         (basic_lookup_transparent_type_1): Use objfile_compunits.
12295         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12296         (info_sources_command, search_symbols)
12297         (default_collect_symbol_completion_matches_break_on)
12298         (make_source_files_completion_list): Remove declaration.
12299         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12300         (ada_collect_symbol_completion_matches)
12301         (ada_add_global_exceptions): Remove declaration.
12302         * linespec.c (iterate_over_all_matching_symtabs): Use
12303         objfile_compunits.
12304         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12305         (class objfile_compunits): New.
12306         (ALL_COMPUNITS): Use objfile_compunits.
12307         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12308         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12309         objfile_compunits.
12310         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12311
12312 2019-01-09  Tom Tromey  <tom@tromey.com>
12313
12314         * symtab.c (search_symbols)
12315         (default_collect_symbol_completion_matches_break_on): Use
12316         objfile_msymbols.
12317         * ada-lang.c (ada_lookup_simple_minsym)
12318         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12319         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12320         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12321         objfile_msymbols.
12322         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12323         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12324         * objc-lang.c (find_methods): Use objfile_msymbols.
12325         (info_selectors_command, info_classes_command): Likewise.
12326         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12327         * objfiles.h (class objfile_msymbols): New.
12328         (ALL_OBJFILE_MSYMBOLS): Remove.
12329         (ALL_MSYMBOLS): Remove.
12330
12331 2019-01-09  Tom Tromey  <tom@tromey.com>
12332
12333         * common/next-iterator.h (next_adapter): Add Iterator template
12334         parameter.
12335         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12336         (class all_objfiles_safe): New.
12337         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12338         * objfiles.c (put_objfile_before): Update comment.
12339         (add_separate_debug_objfile): Likewise.
12340         (free_all_objfiles): Use all_objfiles_safe.
12341         (objfile_purge_solibs): Likewise.
12342
12343 2019-01-09  Tom Tromey  <tom@tromey.com>
12344
12345         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12346         (expand_symtab_containing_pc, lookup_static_symbol)
12347         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12348         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12349         all_objfiles.
12350         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12351         * breakpoint.c (create_overlay_event_breakpoint)
12352         (create_longjmp_master_breakpoint)
12353         (create_std_terminate_master_breakpoint)
12354         (create_exception_master_breakpoint): Use all_objfiles.
12355         * linux-thread-db.c (try_thread_db_load_from_pdir)
12356         (has_libpthread): Use all_objfiles.
12357         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12358         * linespec.c (iterate_over_all_matching_symtabs)
12359         (search_minsyms_for_name): Use all_objfiles.
12360         * maint.c (maintenance_info_sections): Use all_objfiles.
12361         * main.c (captured_main_1): Use all_objfiles.
12362         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12363         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12364         * guile/scm-pretty-print.c
12365         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12366         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12367         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12368         (maintenance_print_msymbols): Use all_objfiles.
12369         * source.c (select_source_symtab): Use all_objfiles.
12370         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12371         * symfile.c (remove_symbol_file_command)
12372         (expand_symtabs_matching, map_symbol_filenames): Use
12373         all_objfiles.
12374         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12375         all_objfiles.
12376         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12377         * objc-lang.c (find_methods): Use all_objfiles.
12378         * objfiles.c (have_partial_symbols, have_full_symbols)
12379         (have_minimal_symbols, qsort_cmp)
12380         (default_iterate_over_objfiles_in_search_order): Use
12381         all_objfiles.
12382         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12383         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12384         (maintenance_check_psymtabs): Use all_objfiles.
12385         (ALL_PSYMTABS): Remove.
12386         * compile/compile-object-run.c (do_module_cleanup): Use
12387         all_objfiles.
12388         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12389         * cp-support.c (add_symbol_overload_list_qualified): Use
12390         all_objfiles.
12391         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12392         Use all_objfiles.
12393         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12394         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12395         all_objfiles.
12396         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12397         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12398         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12399         Uses all_objfiles.
12400         * solib.c (solib_read_symbols): Use all_objfiles
12401
12402 2019-01-09  Tom Tromey  <tom@tromey.com>
12403
12404         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12405         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12406         all_objfiles.
12407         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12408         * symmisc.c (print_symbol_bcache_statistics)
12409         (print_objfile_statistics, maintenance_print_objfiles)
12410         (maintenance_info_symtabs, maintenance_check_symtabs)
12411         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12412         all_objfiles.
12413         * source.c (forget_cached_source_info): Use all_objfiles.
12414         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12415         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12416         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12417         * objfiles.c (update_section_map): Use all_objfiles.
12418         (shared_objfile_contains_address_p): Likewise.
12419         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12420         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12421
12422 2019-01-09  Tom Tromey  <tom@tromey.com>
12423
12424         * common/next-iterator.h: New file.
12425         * objfiles.h (class all_objfiles): New.
12426         (struct objfile_iterator): New.
12427
12428 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12429
12430         * NEWS: Move the description of the changed "frame", "select-frame",
12431          and "info frame" commands to the Changed commands section.
12432
12433 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12434
12435         * gdbtypes.c (check_stub_method_group): Remove handling of old
12436         mangling schemes.
12437         * linespec.c (find_methods): Likewise.
12438         * stabsread.c (read_member_functions): Likewise.
12439         * valops.c (search_struct_method): Likewise.
12440         (value_struct_elt_for_reference): Likewise.
12441         * NEWS: Mention this change.
12442
12443 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12444
12445         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12446         print_source_lines.
12447         * source.c (print_source_lines_base): Update line number check.
12448         (print_source_lines): New function.
12449         (source_lines_range::source_lines_range): New function.
12450         * source.h (class source_lines_range): New class.
12451         (print_source_lines): New declaration.
12452
12453 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12454
12455         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12456
12457 2019-01-08  Tom Tromey  <tom@tromey.com>
12458             Simon Marchi  <simon.marchi@ericsson.com>
12459
12460         PR gdb/24060
12461         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12462         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12463         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12464         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12465         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12466         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12467
12468 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12469
12470         * source.c (select_source_symtab): Move header comment to
12471         declaration in source.h.
12472         (forget_cached_source_info_for_objfile): Likewise.
12473         (forget_cached_source_info): Likewise.
12474         (identify_source_line): Likewise.
12475         * source.h (identify_source_line): Move declaration from symtab.h
12476         and add comment from source.c
12477         (print_source_lines): Likewise.
12478         (forget_cached_source_info_for_objfile): Likewise.
12479         (forget_cached_source_info): Likewise.
12480         (select_source_symtab): Likewise.
12481         (enum print_source_lines_flag): Move definition from symtab.h.
12482         * symtab.h (identify_source_line): Move declaration to source.h.
12483         (print_source_lines): Likewise.
12484         (forget_cached_source_info_for_objfile): Likewise.
12485         (forget_cached_source_info): Likewise.
12486         (select_source_symtab): Likewise.
12487         (enum print_source_lines_flag): Move definition to source.h.
12488         * tui/tui-hooks.c: Add 'source.h' include.
12489
12490 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * source.c (print_source_lines_base): Handle requests to print
12493         reverse line number sequences, and guard against empty lines
12494         string.
12495
12496 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12497
12498         * source.c (print_source_lines_base): Fix skip of '\r' if next
12499         character is '\n'.
12500
12501 2019-01-06  Tom Tromey  <tom@tromey.com>
12502
12503         * c-exp.y (struct c_parse_state) <macro_original_text,
12504         expansion_obstack>: New member.
12505         (macro_original_text, expansion_obstack): Remove globals.
12506         (scan_macro_expansion, scanning_macro_expansion)
12507         (finished_macro_expansion): Update.
12508         (scan_macro_cleanup): Remove.
12509         (yylex, c_parse): Update.
12510
12511 2019-01-06  Tom Tromey  <tom@tromey.com>
12512
12513         * c-exp.y (struct c_parse_state) <strings>: New member.
12514         (operator_stoken): Update.
12515
12516 2019-01-06  Tom Tromey  <tom@tromey.com>
12517
12518         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12519         (union type_stack_elt) <typelist_val>: Now a pointer to
12520         std::vector.
12521         (type_stack_cleanup): Don't declare.
12522         (push_typelist): Update.
12523         * parse.c (pop_typelist): Return a std::vector.
12524         (push_typelist): Take a std::vector.
12525         (follow_types): Update.  Do not free args.
12526         (type_stack_cleanup): Remove.
12527         * c-exp.y (struct c_parse_state): New.
12528         (cpstate): New global.
12529         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12530         (nonempty_typelist): Update.
12531         (func_mod): Create a new vector.
12532         (c_parse): Create a c_parse_state.
12533         (check_parameter_typelist): Do not delete params.
12534         (function_method): Update.  Do not delete type_list.
12535
12536 2019-01-06  Tom Tromey  <tom@tromey.com>
12537
12538         PR gdb/28155:
12539         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12540         check_typedef.
12541         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12542         (print_return_value): Likewise.
12543
12544 2019-01-05  Tom Tromey  <tom@tromey.com>
12545
12546         * contrib/cleanup_check.py: Remove.
12547         * contrib/gcc-with-excheck: Remove.
12548         * contrib/exsummary.py: Remove.
12549         * contrib/excheck.py: Remove.
12550
12551 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12552
12553         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12554         NULL. Initialize tpprev to NULL instead of assigning it
12555         to NULL on the next statement.
12556         * windows-nat.c (windows_delete_thread): Remove check for
12557         main_thread_id before printing thread exit notifications.
12558         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12559         Remove thread ID check against main_thread_id.
12560         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12561         windows_delete_thread.
12562         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12563
12564 2019-01-04  Tom Tromey  <tom@tromey.com>
12565
12566         * compile/compile.c (_initialize_compile): Use upper case for
12567         metasyntactic variables.
12568         * symmisc.c (_initialize_symmisc): Use upper case for
12569         metasyntactic variables.
12570         * psymtab.c (_initialize_psymtab): Use upper case for
12571         metasyntactic variables.
12572         * demangle.c (demangle_command): Use upper case for metasyntactic
12573         variables.
12574         (_initialize_demangler): Likewise.
12575         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12576         variables.
12577
12578 2019-01-03  Tom Tromey  <tom@tromey.com>
12579
12580         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12581
12582 2019-01-03  Tom Tromey  <tom@tromey.com>
12583
12584         * python/py-symtab.c (salpy_str): Update.
12585         (struct salpy_sal_object) <symtab>: Now a PyObject.
12586         (salpy_dealloc): Update.
12587         (del_objfile_sal): Use gdbpy_ref.
12588
12589 2019-01-03  Tom Tromey  <tom@tromey.com>
12590
12591         * python/py-type.c (convert_field): Use new_reference.  Return
12592         gdbpy_ref.
12593         (make_fielditem): Return gdbpy_ref.
12594         (typy_fields): Update.
12595         (typy_getitem): Update.
12596         (field_name): Return gdbpy_ref.  Use new_reference.
12597         (typy_iterator_iternext): Update.
12598
12599 2019-01-03  Tom Tromey  <tom@tromey.com>
12600
12601         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12602
12603 2019-01-03  Tom Tromey  <tom@tromey.com>
12604
12605         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12606         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12607         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12608         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12609         (pspy_set_type_printers): Likewise.
12610         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12611         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12612         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12613         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12614         (objfpy_set_type_printers): Likewise.
12615
12616 2019-01-03  Tom Tromey  <tom@tromey.com>
12617
12618         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12619         (gdbpy_print_stack): Use gdbpy_err_fetch.
12620         * python/python-internal.h (class gdbpy_err_fetch): New class.
12621         (class gdbpy_enter) <m_error_type, m_error_value,
12622         m_error_traceback>: Remove.
12623         <m_error>: New member.
12624         (gdbpy_exception_to_string): Don't declare.
12625         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12626         * python/py-value.c (convert_value_from_python): Use
12627         gdbpy_err_fetch.
12628         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12629         gdbpy_exception_to_string.
12630         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12631         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12632         gdbpy_err_fetch.
12633
12634 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12635
12636         * linux-nat.c (delete_lwp_cleanup): Delete.
12637         (struct lwp_deleter): New struct.
12638         (lwp_info_up): New typedef.
12639         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12640         lwp_info_up.
12641
12642 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12643
12644         * linux-fork.c (class scoped_switch_fork_info): New class.
12645         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12646
12647 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12648
12649         * valops.c (find_overload_match): Remove use of null_cleanup, and
12650         calls to do_cleanups.
12651
12652 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12653
12654         * compile/compile-cplus-types.c
12655         (compile_cplus_instance::decl_name): Handle changes to
12656         cp_func_name.
12657         * cp-support.c (cp_func_name): Update header comment, update
12658         return type.
12659         * cp-support.h (cp_func_name): Update return type in declaration.
12660         * valops.c (find_overload_match): Move temp_func local to top
12661         level of function and change its type.  Use temp_func to hold and
12662         delete temporary string obtained from cp_func_name.
12663
12664 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12665
12666         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12667         gdb::char_vector, remove cleanup, and update uses of `msg`.
12668
12669 2019-01-03  Jim Wilson  <jimw@sifive.com>
12670
12671         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12672
12673 2019-01-02  Tom Tromey  <tom@tromey.com>
12674
12675         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12676         (tdesc_parse_xml): Remove cleanups.
12677         * target-descriptions.h (make_cleanup_free_target_description):
12678         Don't declare.
12679         (target_desc_deleter): New struct.
12680         (target_desc_up): New typedef.
12681         * target-descriptions.c (target_desc_deleter::operator()): Rename
12682         from free_target_description.
12683         (make_cleanup_free_target_description): Remove.
12684
12685 2019-01-02  Tom Tromey  <tom@tromey.com>
12686
12687         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12688         constructor, destructor.
12689         (linespec_parser): Remove typedef.
12690         (~linespec_parser): Rename from linespec_parser_delete.
12691         (linespec_lex_to_end, linespec_complete_label)
12692         (linespec_complete): Update.
12693         (decode_line_full): Remove cleanups.
12694         (decode_line_1): Update.
12695
12696 2019-01-02  Tom Tromey  <tom@tromey.com>
12697
12698         * python/python-internal.h (inferior_to_inferior_object): Change
12699         return type.
12700         * python/py-exitedevent.c (create_exited_event_object): Update.
12701         * python/py-inferior.c (inferior_to_inferior_object): Return
12702         gdbpy_ref.
12703         (python_new_inferior, python_inferior_deleted)
12704         (thread_to_thread_object, delete_thread_object)
12705         (build_inferior_list, gdbpy_selected_inferior): Update.
12706         * python/py-infthread.c (create_thread_object): Update.  Also fail
12707         if inferior_to_inferior_object fails.
12708
12709 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12710
12711         * inferior.h (class inferior) <displaced_step_state>: New field.
12712         * infrun.h (struct displaced_step_state): Move here from
12713         infrun.c.  Initialize fields, add constructor.
12714         <inf>: Remove field.
12715         <reset>: New method.
12716         * infrun.c (struct displaced_step_inferior_state): Move to
12717         infrun.h.
12718         (displaced_step_inferior_states): Remove.
12719         (get_displaced_stepping_state): Adust.
12720         (displaced_step_in_progress_any_inferior): Adjust.
12721         (displaced_step_in_progress_thread): Adjust.
12722         (displaced_step_in_progress): Adjust.
12723         (add_displaced_stepping_state): Remove.
12724         (get_displaced_step_closure_by_addr): Adjust.
12725         (remove_displaced_stepping_state): Remove.
12726         (infrun_inferior_exit): Call displaced_step_state.reset.
12727         (use_displaced_stepping): Don't check for NULL.
12728         (displaced_step_prepare_throw): Call
12729         get_displaced_stepping_state.
12730         (displaced_step_fixup): Don't check for NULL.
12731         (prepare_for_detach): Don't check for NULL.
12732
12733 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12734
12735         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12736          in case of call that did not complete.
12737
12738 2019-01-02  Andrey Utkin  <autkin@undo.io>
12739
12740         * symfile.c (find_separate_debug_file): Fix search of debug files for
12741         remote debuggee.
12742
12743 2019-01-02  Tom Tromey  <tom@tromey.com>
12744
12745         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12746         indentation.
12747         * python/py-frame.c (frapy_older): Remove cast.
12748         (frapy_newer): Likewise.
12749         * python/py-breakpoint.c (local_setattro): Remove cast.
12750         * python/py-arch.c (archpy_name): Remove local variable.
12751         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12752
12753 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12754
12755         * unittests/basic_string_view/element_access/char/empty.cc:
12756         Fix year range in copyright header.
12757
12758 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12759
12760         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12761         Delete.
12762         <operator==>: Update with for removed field.
12763         <hash>: Likewise.
12764         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12765         <isa_features>: ...this.
12766         <abi_features>: New field.
12767         (riscv_isa_flen): Update comment.
12768         (riscv_abi_xlen): New declaration.
12769         (riscv_abi_flen): New declaration.
12770         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12771         isa_features.
12772         (riscv_abi_xlen): New function.
12773         (riscv_isa_flen): Update to get answer from isa_features.
12774         (riscv_abi_flen): New function.
12775         (riscv_has_fp_abi): Update to get answer from abi_features.
12776         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12777         xlen and flen.
12778         (riscv_call_info) <xlen, flen>: Update comment.
12779         (riscv_call_arg_struct): Remove invalid assertions
12780         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12781         is removed.
12782         (riscv_gdbarch_init): Gather isa features and abi features
12783         separately, ensure both match on the gdbarch when reusing an old
12784         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12785         a target with 64-bit float hardware.
12786
12787 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12788
12789         * source.c (search_command_helper): Stop reverse search
12790         when line 1 has been searched.
12791
12792 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12793
12794         * record-full.c (record_full_base_target::close): Rewrite
12795         record_full_core_buf_list free logic.
12796
12797 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12798
12799         * break-catch-syscall.c (print_one_catch_syscall): xfree
12800         the last text.
12801
12802 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12803
12804         * top.c (print_gdb_version): Update Copyright year in version
12805         message.
12806
12807 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12808
12809         Update copyright year range in all GDB files.
12810
12811 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12812
12813         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12814
12815 For older changes see ChangeLog-2018.
12816 \f
12817 Local Variables:
12818 mode: change-log
12819 left-margin: 8
12820 fill-column: 74
12821 version-control: never
12822 coding: utf-8
12823 End:
12824