gdb/ChangeLog

   1 2019-01-24  Pedro Alves  <palves@redhat.com>
   2
   3         * infrun.c (signal_stop, signal_print, signal_program)
   4         (signal_catch, signal_pass): Now arrays instead of pointers.
   5         (update_signals_program_target, do_target_resume)
   6         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
   7         * linux-nat.c (linux_nat_target::pass_signals)
   8         (linux_nat_target::create_inferior, linux_nat_target::attach):
   9         Adjust.
  10         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
  11         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
  12         * procfs.c (procfs_target::pass_signals): Adjust.
  13         * record-full.c (record_full_target::resume): Adjust.
  14         * remote.c (remote_target::pass_signals)
  15         (remote_target::program_signals): Adjust.
  16         * target-debug.h (target_debug_print_signals): Now takes a
  17         gdb::array_view as parameter.  Adjust.
  18         * target.h (target_ops) <pass_signals, program_signals>: Replace
  19         pointer and length parameters with gdb::array_view.
  20         (target_pass_signals, target_program_signals): Likewise.
  21         * target-delegates.c: Regenerate.
  22
  23 2019-01-24  Pedro Alves  <palves@redhat.com>
  24
  25         * common/forward-scope-exit.h
  26         (forward_scope_exit::forward_scope_exit): Pass arguments to
  27         m_bind_function directly, instead of creating a std::bind and
  28         copying that.
  29
  30 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  33         for static members.
  34         (pass_in_v_vfp_candidate): Likewise.
  35
  36 2019-01-23  Tom Tromey  <tom@tromey.com>
  37             Pedro Alves  <palves@redhat.com>
  38
  39         * regcache.c (class regcache_invalidator): Remove.
  40         (regcache::raw_write): Use make_scope_exit.
  41
  42 2019-01-23  Tom Tromey  <tom@tromey.com>
  43
  44         * ui-out.h (class ui_out_emit_type): Update comment.
  45
  46 2019-01-23  Tom Tromey  <tom@tromey.com>
  47
  48         * infrun.c (fetch_inferior_event): Update comment.
  49
  50 2019-01-23  Tom Tromey  <tom@tromey.com>
  51             Pedro Alves  <palves@redhat.com>
  52
  53         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
  54         parameter.
  55         (fetch_inferior_event): Use SCOPE_EXIT.
  56
  57
  58 2019-01-23  Tom Tromey  <tom@tromey.com>
  59             Pedro Alves  <palves@redhat.com>
  60
  61         * infrun.c (disable_thread_events): Delete.
  62         (stop_all_threads): Use SCOPE_EXIT.
  63
  64 2019-01-23  Tom Tromey  <tom@tromey.com>
  65             Pedro Alves  <palves@redhat.com>
  66
  67         * symfile.c: Include forward-scope-exit.h.
  68         (clear_symtab_users_cleanup): Replace forward declaration with
  69         a FORWARD_SCOPE_EXIT.
  70         (syms_from_objfile_1): Use the forward_scope_exit and
  71         gdb::optional instead of cleanup_function.
  72         (reread_symbols): Use the forward_scope_exit instead of
  73         cleanup_function.
  74         (clear_symtab_users_cleanup): Remove function.
  75
  76 2019-01-23  Tom Tromey  <tom@tromey.com>
  77             Pedro Alves  <palves@redhat.com>
  78
  79         * linux-nat.c: Include scope-exit.h.
  80         (cleanup_target_stop): Remove.
  81         (linux_nat_target::static_tracepoint_markers_by_strid): Use
  82         SCOPE_EXIT.
  83
  84 2019-01-23  Tom Tromey  <tom@tromey.com>
  85             Pedro Alves  <palves@redhat.com>
  86
  87         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
  88         (call_function_by_hand_dummy): Use SCOPE_EXIT.
  89
  90 2019-01-23  Tom Tromey  <tom@tromey.com>
  91             Andrew Burgess  <andrew.burgess@embecosm.com>
  92             Pedro Alves  <palves@redhat.com>
  93
  94         * infrun.c (fetch_inferior_event): Use scope_exit.
  95         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
  96         * top.c (execute_command): Use scope_exit.
  97         * breakpoint.c (bpstat_do_actions): Use scope_exit.
  98         * utils.c (do_bpstat_clear_actions_cleanup)
  99         (make_bpstat_clear_actions_cleanup): Remove.
 100
 101 2019-01-23  Tom Tromey  <tom@tromey.com>
 102             Pedro Alves  <palves@redhat.com>
 103
 104         * infrun.c: Include "common/scope-exit.h"
 105         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 106         (wait_for_inferior): Use SCOPE_EXIT.
 107         (fetch_inferior_event): Use scope_exit.
 108
 109 2019-01-23  Tom Tromey  <tom@tromey.com>
 110             Pedro Alves  <palves@redhat.com>
 111
 112         * breakpoint.c (create_breakpoint): Remove cleanup.
 113
 114 2019-01-23  Tom Tromey  <tom@tromey.com>
 115             Andrew Burgess  <andrew.burgess@embecosm.com>
 116             Pedro Alves  <palves@redhat.com>
 117
 118 2019-01-23  Pedro Alves  <palves@redhat.com>
 119
 120         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 121
 122 2019-01-23  Pedro Alves  <palves@redhat.com>
 123             Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * gdbthread.h: Include "common/forward-scope-exit.h".
 126         (scoped_finish_thread_state): Redefine custom class in terms of
 127         forward_scope_exit.
 128
 129 2019-01-23  Pedro Alves  <palves@redhat.com>
 130             Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * common/forward-scope-exit.h: New file.
 133
 134 2019-01-23  Pedro Alves  <palves@redhat.com>
 135             Andrew Burgess  <andrew.burgess@embecosm.com>
 136             Tom Tromey  <tom@tromey.com>
 137
 138         * common/scope-exit.h: New file.
 139
 140 2019-01-23  Pedro Alves  <palves@redhat.com>
 141
 142         * common/preprocessor.h (ESC): Rename to ...
 143         (ESC_PARENS): ... this.
 144         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 145         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 146
 147 2019-01-23  Tom Tromey  <tom@tromey.com>
 148
 149         * language.h (class scoped_switch_to_sym_language_if_auto):
 150         Initialize m_lang in both cases.
 151
 152 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 153
 154         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 155         with XCNEW.
 156
 157 2019-01-22  Tom Tromey  <tom@tromey.com>
 158
 159         * corelow.c: Do not include sys/file.h.
 160
 161 2019-01-22  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-wingeneral.h: Include gdb_curses.h.
 164
 165 2019-01-22  Tom Tromey  <tom@tromey.com>
 166
 167         * source-cache.h (class source_cache) <get_source_lines,
 168         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 169
 170 2019-01-22  Tom Tromey  <tom@tromey.com>
 171
 172         * remote-fileio.h (struct remote_target): Declare.
 173
 174 2019-01-22  Tom Tromey  <tom@tromey.com>
 175
 176         * python/py-arch.c: Do not include py-ref.h.
 177         * python/py-bpevent.c: Do not include py-ref.h.
 178         * python/py-cmd.c: Do not include py-ref.h.
 179         * python/py-continueevent.c: Do not include py-ref.h.
 180         * python/py-event.h: Do not include py-ref.h.
 181         * python/py-evtregistry.c: Do not include py-ref.h.
 182         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 183         * python/py-frame.c: Do not include py-ref.h.
 184         * python/py-framefilter.c: Do not include py-ref.h.
 185         * python/py-function.c: Do not include py-ref.h.
 186         * python/py-infevents.c: Do not include py-ref.h.
 187         * python/py-linetable.c: Do not include py-ref.h.
 188         * python/py-objfile.c: Do not include py-ref.h.
 189         * python/py-param.c: Do not include py-ref.h.
 190         * python/py-prettyprint.c: Do not include py-ref.h.
 191         * python/py-progspace.c: Do not include py-ref.h.
 192         * python/py-symbol.c: Do not include py-ref.h.
 193         * python/py-symtab.c: Do not include py-ref.h.
 194         * python/py-type.c: Do not include py-ref.h.
 195         * python/py-unwind.c: Do not include py-ref.h.
 196         * python/py-utils.c: Do not include py-ref.h.
 197         * python/py-value.c: Do not include py-ref.h.
 198         * python/py-varobj.c: Do not include py-ref.h.
 199         * python/py-xmethods.c: Do not include py-ref.h.
 200         * python/python.c: Do not include py-ref.h.
 201         * varobj.c: Do not include py-ref.h.
 202
 203 2019-01-22  Tom Tromey  <tom@tromey.com>
 204
 205         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 206         keyword for bcache.
 207
 208 2019-01-22  Tom Tromey  <tom@tromey.com>
 209
 210         * compile/compile-cplus-types.c: Remove a comment by #include.
 211
 212 2019-01-22  Tom Tromey  <tom@tromey.com>
 213
 214         * compile/gcc-c-plugin.h: Include compile-internal.h.
 215
 216 2019-01-22  Tom Tromey  <tom@tromey.com>
 217
 218         * stabsread.c (EXTERN): Do not define.
 219         (symnum, next_symbol_text_func, processing_gcc_compilation)
 220         (within_function, global_sym_chain, global_stabs)
 221         (previous_stab_code, this_object_header_files)
 222         (n_this_object_header_files)
 223         (n_allocated_this_object_header_files): Define.
 224         * stabsread.h (EXTERN): Never define.  Use "extern".
 225
 226 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 227
 228         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 229         history_value.
 230
 231 2019-01-21  Tom Tromey  <tom@tromey.com>
 232
 233         * ui-out.c: Fix includes.
 234         * tui/tui-source.c: Fix includes.
 235         * target.c: Fix includes.
 236         * remote.c: Fix includes.
 237         * regcache.c: Fix includes.
 238         * python/py-block.c: Fix includes.
 239         * printcmd.c: Fix includes.
 240         * or1k-tdep.c: Fix includes.
 241         * mi/mi-main.c: Fix includes.
 242         * m32r-tdep.c: Fix includes.
 243         * csky-tdep.c: Fix includes.
 244         * compile/compile-cplus-types.c: Fix includes.
 245         * cli/cli-interp.c: Fix includes.
 246
 247 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 248
 249         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 250         for padding.
 251
 252 2019-01-16  Tom Tromey  <tom@tromey.com>
 253
 254         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 255         earlier.
 256         (struct objfile) <msymbols_range>: Move from top level.
 257         <msymbols>: New method.
 258         (class objfile_msymbols): Remove.
 259         * symtab.c (default_collect_symbol_completion_matches_break_on):
 260         Update.
 261         * symmisc.c (dump_msymbols): Update.
 262         * stabsread.c (scan_file_globals): Update.
 263         * objc-lang.c (info_selectors_command, info_classes_command)
 264         (find_methods): Update.
 265         * minsyms.c (find_solib_trampoline_target): Update.
 266         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 267         * coffread.c (coff_symfile_read): Update.
 268         * ada-lang.c (ada_lookup_simple_minsym)
 269         (ada_collect_symbol_completion_matches): Update.
 270
 271 2019-01-16  Tom Tromey  <tom@tromey.com>
 272
 273         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 274         type.  Remove no-argument constructor.
 275         <iterator::operator++>: Simplify.
 276         <begin>: Update.
 277         <end>: Use minimal_symbol_count.
 278
 279 2019-01-16  Tom Tromey  <tom@tromey.com>
 280
 281         * objfiles.h (struct objfile) <psymtabs>: New method.
 282         (class objfile_psymtabs): Remove.
 283         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 284         typedef.
 285         <range>: New method.
 286         (require_partial_symbols): Change return type.
 287         * psymtab.c (require_partial_symbols)
 288         (psym_expand_symtabs_matching): Update.
 289         * mdebugread.c (parse_partial_symbols): Update.
 290         * dbxread.c (dbx_end_psymtab): Update.
 291
 292 2019-01-15  Tom Tromey  <tom@tromey.com>
 293
 294         * symtab.c (lookup_objfile_from_block)
 295         (lookup_symbol_in_objfile_symtabs)
 296         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 297         (find_line_symtab, info_sources_command)
 298         (default_collect_symbol_completion_matches_break_on)
 299         (make_source_files_completion_list): Update.
 300         * symmisc.c (print_objfile_statistics, dump_objfile)
 301         (maintenance_print_symbols, maintenance_info_symtabs)
 302         (maintenance_check_symtabs, maintenance_info_line_tables):
 303         Update.
 304         * source.c (select_source_symtab)
 305         (forget_cached_source_info_for_objfile): Update.
 306         * objfiles.h (class objfile_compunits): Remove.
 307         (struct objfile) <compunits_range>: New typedef.
 308         (compunits): New method.
 309         * objfiles.c (objfile_relocate1): Update.
 310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 311         * maint.c (count_symtabs_and_blocks): Update.
 312         * linespec.c (iterate_over_all_matching_symtabs): Update.
 313         * cp-support.c (add_symbol_overload_list_qualified): Update.
 314         * coffread.c (coff_symtab_read): Update.
 315         * ada-lang.c (add_nonlocal_symbols)
 316         (ada_collect_symbol_completion_matches)
 317         (ada_add_global_exceptions): Update.
 318
 319 2019-01-15  Tom Tromey  <tom@tromey.com>
 320
 321         * progspace.h (program_space) <objfiles_safe_range>: New
 322         typedef.
 323         <objfiles_safe>: New method.
 324         * objfiles.h (class all_objfiles_safe): Remove.
 325         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 326         * jit.c (jit_inferior_exit_hook): Update.
 327
 328 2019-01-17  Tom Tromey  <tom@tromey.com>
 329
 330         * progspace.h (program_space) <objfiles_range>: New typedef.
 331         <objfiles>: New method.
 332         <objfiles_head>: Rename from objfiles.
 333         (object_files): Update.
 334         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 335         * guile/scm-pretty-print.c
 336         (ppscm_find_pretty_printer_from_objfiles): Update.
 337         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 338         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 339         Update.
 340         * python/py-progspace.c (pspy_get_objfiles): Update.
 341         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 342         Update.
 343         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 344         (objfpy_lookup_objfile_by_build_id): Update.
 345         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 346         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 347         Update.
 348         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 349         (expand_symtab_containing_pc, lookup_objfile_from_block)
 350         (lookup_static_symbol, basic_lookup_transparent_type)
 351         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 352         (find_line_symtab, info_sources_command)
 353         (default_collect_symbol_completion_matches_break_on)
 354         (make_source_files_completion_list, find_main_name): Update.
 355         * symmisc.c (print_symbol_bcache_statistics)
 356         (print_objfile_statistics, maintenance_print_symbols)
 357         (maintenance_print_msymbols, maintenance_print_objfiles)
 358         (maintenance_info_symtabs, maintenance_check_symtabs)
 359         (maintenance_expand_symtabs, maintenance_info_line_tables):
 360         Update.
 361         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 362         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 363         (map_overlay_command, unmap_overlay_command)
 364         (simple_overlay_update, expand_symtabs_matching)
 365         (map_symbol_filenames): Update.
 366         * symfile-debug.c (set_debug_symfile): Update.
 367         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 368         Update.
 369         * source.c (select_source_symtab, forget_cached_source_info):
 370         Update.
 371         * solib.c (solib_read_symbols): Update.
 372         * solib-spu.c (append_ocl_sos): Update.
 373         * psymtab.c (maintenance_print_psymbols)
 374         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 375         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 376         * printcmd.c (info_symbol_command): Update.
 377         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 378         Update.
 379         * objfiles.h (class all_objfiles): Remove.
 380         * objfiles.c (have_partial_symbols, have_full_symbols)
 381         (have_minimal_symbols, qsort_cmp, update_section_map)
 382         (shared_objfile_contains_address_p)
 383         (default_iterate_over_objfiles_in_search_order): Update.
 384         * objc-lang.c (info_selectors_command, info_classes_command)
 385         (find_methods): Update.
 386         * minsyms.c (find_solib_trampoline_target): Update.
 387         * maint.c (maintenance_info_sections)
 388         (maintenance_translate_address, count_symtabs_and_blocks):
 389         Update.
 390         * main.c (captured_main_1): Update.
 391         * linux-thread-db.c (try_thread_db_load_from_pdir)
 392         (has_libpthread): Update.
 393         * linespec.c (iterate_over_all_matching_symtabs)
 394         (search_minsyms_for_name): Update.
 395         * jit.c (jit_find_objf_with_entry_addr): Update.
 396         * hppa-tdep.c (find_unwind_entry)
 397         (hppa_lookup_stub_minimal_symbol): Update.
 398         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 399         Update.
 400         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 401         (elf_gnu_ifunc_resolve_by_got): Update.
 402         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 403         * dwarf-index-write.c (save_gdb_index_command): Update.
 404         * cp-support.c (add_symbol_overload_list_qualified): Update.
 405         * breakpoint.c (create_overlay_event_breakpoint)
 406         (create_longjmp_master_breakpoint)
 407         (create_std_terminate_master_breakpoint)
 408         (create_exception_master_breakpoint): Update.
 409         * blockframe.c (find_pc_partial_function): Update.
 410         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 411         (ada_collect_symbol_completion_matches)
 412         (ada_add_global_exceptions): Update.
 413
 414 2019-01-17  Tom Tromey  <tom@tromey.com>
 415
 416         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 417         declare VEC.
 418         (solib_target_parse_libraries): Change return type.
 419         (library_list_start_segment, library_list_start_section)
 420         (library_list_end_library, library_list_start_library); Update.
 421         (solib_target_free_library_list): Remove.
 422         (solib_target_parse_libraries): Remove cleanup.  Change return
 423         type.
 424         (solib_target_current_sos): Update.
 425
 426 2019-01-17  Tom Tromey  <tromey@bapiya>
 427
 428         * valprint.c: Replace "the the" with "the".
 429         * symtab.c: Replace "the the" with "the".
 430         * solib.c: Replace "the the" with "the".
 431         * solib-dsbt.c: Replace "the the" with "the".
 432         * linespec.c: Replace "the the" with "the".
 433         * dwarf2loc.h: Replace "the the" with "the".
 434         * amd64-windows-tdep.c: Replace "the the" with "the".
 435         * aarch64-tdep.c: Replace "the the" with "the".
 436
 437 2019-01-16  Keith Seitz  <keiths@redhat.com>
 438
 439         PR gdb/23773
 440         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 441         <builder>: Rename to ..
 442         <m_builder>: ... this and make private.
 443         (dwarf2_cu::get_builder): New method.  Change all users of
 444         `builder' to use this method.
 445         (dwarf2_start_symtab): Move to ...
 446         (dwarf2_cu::start_symtab): ... here.  Update all callers
 447         (setup_type_unit_groups): Move to ...
 448         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 449         callers.
 450         (dwarf2_cu::reset_builder): New method.
 451         (process_full_compunit, process_full_type_unit): Use
 452         dwarf2_cu::reset_builder.
 453         (follow_die_offset): Record the ancestor CU if it is different
 454         from the followed DIE's CU.
 455         (follow_die_sig_1): Likewise.
 456
 457 2019-01-15  Tom Tromey  <tom@tromey.com>
 458
 459         * remote.c (class remote_state) <buf>: Now a char_vector.
 460         <buf_size>: Remove.
 461         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 462         parameter.
 463         (remote_target::getpkt_or_notif_sane_1)
 464         (remote_target::getpkt_sane)
 465         (remote_target::getpkt_or_notif_sane): Likewise.
 466         (class remote_target) <putpkt>: New overload.
 467         (remote_target::read_frame): Change type of "buf_p".  Remove
 468         sizeof_p parameter.
 469         (packet_ok): New overload.
 470         (packet_check_result): New overload.
 471         Update all uses.
 472
 473 2019-01-14  Tom Tromey  <tom@tromey.com>
 474
 475         * remote-notif.c (handle_notification, remote_notif_ack)
 476         (remote_notif_parse): Make "buf" const.
 477         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 478         const.
 479         (remote_notif_parse, remote_notif_ack, handle_notification):
 480         Likewise.
 481         * remote.c (remote_notif_stop_parse): Make "buf" const.
 482         (remote_target::remote_parse_stop_reply): Make "buf" const.
 483         (remote_notif_stop_ack): Make "buf" const.
 484
 485 2019-01-14  Tom Tromey  <tom@tromey.com>
 486
 487         * remote.c (remote_console_output): Make parameter const.
 488
 489 2019-01-14  Tom Tromey  <tom@tromey.com>
 490
 491         * target-debug.h (target_debug_print_signals): Constify.
 492         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 493         * procfs.c (procfs_target::pass_signals): Update.
 494         * linux-nat.c (linux_nat_target::pass_signals): Update.
 495         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 496         * target-delegates.c: Rebuild.
 497         * remote.c (remote_target::program_signals): Update.
 498         (remote_target::pass_signals): Update.
 499         * target.c (target_pass_signals): Constify argument.
 500         (target_program_signals): Likewise.
 501         * target.h (struct target_ops) <pass_signals, program_signals>:
 502         Constify argument.
 503         (target_pass_signals, target_program_signals): Constify argument.
 504
 505 2019-01-14  Tom Tromey  <tom@tromey.com>
 506
 507         PR tui/28819:
 508         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 509
 510 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 511
 512         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 513         field.
 514         * rs6000-tdep.c: Include reggroups.h.
 515         (IS_V_ALIAS_PSEUDOREG): Define.
 516         (rs6000_register_name): Return names for the "vX" aliases.
 517         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 518         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 519         aliases.  Call default_register_reggroup_p for all other
 520         pseudo-registers.
 521         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 522         New functions.
 523         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 524         Handle "vX" aliases.
 525         (v_alias_pseudo_register_collect): New function.
 526         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 527         (rs6000_gdbarch_init): Initialize "vX" aliases as
 528         pseudo-registers.  Restore registration of
 529         rs6000_pseudo_register_reggroup_p with
 530         set_tdesc_pseudo_register_reggroup_p.
 531
 532 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 533
 534         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 535         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 536         set_gdbarch_num_pseudo_regs.
 537
 538 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 539
 540         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 541         Remove arg prefixname, add do_set and do_show.
 542         Add member functions set_list and show_list.
 543         * cli/cli-style.c (class cli_style_option): Update accordingly.
 544         (style_set_list): Move to file scope.
 545         (style_show_list): Likewise.
 546         (set_style): Call help_list.
 547         (show_style): Call cmd_show_list.
 548         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 549         Update to use the new macro.
 550
 551 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 552
 553         * ada-lang.c (_initialize_ada_language): Expand the help text
 554         for the "catch exception" command.
 555
 556 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * symtab.c (matching_obj_sections): Initialize obj,
 559         declare it closer to its usage.
 560
 561 2019-01-10  Tom Tromey  <tom@tromey.com>
 562
 563         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 564         (basic_inf_threads_range): Remove.
 565         (inf_threads_range, inf_non_exited_threads_range)
 566         (safe_inf_threads_range): Use next_adapter.
 567
 568 2019-01-10  Keith Seitz  <keiths@redhat.com>
 569
 570         PR gdb/23712
 571         PR symtab/23010
 572         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 573         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 574
 575 2019-01-10  Keith Seitz  <keiths@redhat.com>
 576
 577         PR gdb/23712
 578         PR symtab/23010
 579         * dictionary.c (pending_to_vector): Remove.
 580         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 581         Remove _1 suffix, replacing functions of the same name.  Update
 582         all callers.
 583         (dict_create_hashed, dict_create_hashed_expandable)
 584         (dict_create_linear, dict_create_linear_expandable, dict_free)
 585         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 586         Make functions static.
 587
 588 2019-01-10  Keith Seitz  <keiths@redhat.com>
 589
 590         PR gdb/23712
 591         PR symtab/23010
 592         * dictionary.h (struct dictionary): Replace declaration with
 593         multidictionary.
 594         (dict_create_hashed, dict_create_hashed_expandable)
 595         (dict_create_linear, dict_create_linear_expandable)
 596         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 597         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 598         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 599         taking multidictionary argument.
 600         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 601         * block.h (struct block) <dict>: Change to multidictionary
 602         and rename `multidict'.
 603         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 604         symmisc.c: Update all dictionary references to multidictionary.
 605
 606 2019-01-10  Keith Seitz  <keiths@redhat.com>
 607
 608         PR gdb/23712
 609         PR symtab/23010
 610         * dictionary.c: Include unordered_map.
 611         (pending_to_vector): New function.
 612         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 613         Rewrite the non-"_1" functions to take vector instead
 614         of linked list.
 615         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 616         "new" _1 versions of the same name.
 617         (multidictionary): Define.
 618         (std::hash<enum language): New definition.
 619         (collate_pending_symbols_by_language, mdict_create_hashed)
 620         (mdict_create_hashed_expandable, mdict_create_linear)
 621         (mdict_create_linear_expandable, mdict_free)
 622         (find_language_dictionary, create_new_language_dictionary)
 623         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 624         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 625         (mdict_size, mdict_empty): New functions.
 626         * dictionary.h (mdict_iterator): Define.
 627
 628 2019-01-10  Pedro Alves  <palves@redhat.com>
 629
 630         * breakpoint.c (read_uploaded_action)
 631         (create_tracepoint_from_upload): Adjust to use
 632         gdb::unique_xmalloc_ptr.
 633         * ctf.c (ctf_write_uploaded_tp):
 634         (SET_ARRAY_FIELD): Use emplace_back.
 635         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 636         * tracefile-tfile.c (tfile_write_uploaded_tp):
 637         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 638         gdb::unique_xmalloc_ptr.
 639         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 640         at_string, cond_string, cmd_strings>: Replace char pointers
 641         with gdb::unique_xmalloc_ptr.
 642
 643 2019-01-10  Pedro Alves  <palves@redhat.com>
 644
 645         * solib-target.c (library_list_start_library): Don't xstrdup name.
 646
 647 2019-01-10  Pedro Alves  <palves@redhat.com>
 648
 649         * mdebugread.c (parse_partial_symbols): Use
 650         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 651
 652 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * linux-fork.c (scoped_switch_fork_info)
 655         <~scoped_switch_fork_info>: Fix incorrect variable name.
 656
 657 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * linux-fork.c (scoped_switch_fork_info)
 660         <scoped_switch_fork_info>: Make explicit.
 661         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 662
 663 2019-01-10  Tom Tromey  <tom@tromey.com>
 664
 665         * objfiles.h (objfile::reset_psymtabs): Update.
 666         * objfiles.c (objfile::objfile): Update.
 667         * psymtab.h (psymtab_storage::obstack): Update.
 668         (psymtab_storage::m_obstack): Use gdb::optional.
 669         (class psymtab_storage): Update comment.  Remove objfile
 670         parameter.
 671         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 672
 673 2019-01-10  Tom Tromey  <tom@tromey.com>
 674
 675         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 676         <free_psymtabs>: Now private.
 677         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 678         (allocate_psymtab): Use new method.
 679
 680 2019-01-10  Tom Tromey  <tom@tromey.com>
 681
 682         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 683         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 684         * mdebugread.c (parse_partial_symbols): Use
 685         allocate_dependencies.
 686         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 687         allocate_dependencies.
 688         (process_psymtab_comp_unit_reader)
 689         (build_type_psymtab_dependencies): Likewise.
 690         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 691
 692 2019-01-10  Tom Tromey  <tom@tromey.com>
 693
 694         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 695         PSYMBOL_SET_LANGUAGE.
 696         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 697
 698 2019-01-10  Tom Tromey  <tom@tromey.com>
 699
 700         * psymtab.h (psymtab_storage::obstack): New method.
 701         <m_obstack>: Rename from obstack; now private.
 702         * psymtab.c (psymtab_storage): Update.
 703         * dwarf2read.c (create_addrmap_from_index)
 704         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 705         Update.
 706
 707 2019-01-10  Tom Tromey  <tom@tromey.com>
 708
 709         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 710         * objfiles.h (objfile::reset_psymtabs): New method.
 711
 712 2019-01-10  Tom Tromey  <tom@tromey.com>
 713
 714         * symmisc.c (print_symbol_bcache_statistics): Update.
 715         (print_objfile_statistics): Update.
 716         * symfile.c (reread_symbols): Update.
 717         * psymtab.h (class psymtab_storage): New.
 718         * psymtab.c (psymtab_storage): New constructor.
 719         (~psymtab_storage): New destructor.
 720         (require_partial_symbols): Update.
 721         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 722         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 723         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 724         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 725         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 726         (start_psymtab_common, end_psymtab_common)
 727         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 728         (allocate_psymtab): Update.
 729         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 730         Update.
 731         (dump_psymtab_addrmap, maintenance_print_psymbols)
 732         (maintenance_check_psymtabs): Update.
 733         (class objfile_psymtabs): Move to objfiles.h.
 734         * psympriv.h (discard_psymtab): Now inline.
 735         (psymtab_discarder::psymtab_discarder): Update.
 736         (psymtab_discarder::~psymtab_discarder): Update.
 737         (ALL_OBJFILE_PSYMTABS): Rewrite.
 738         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 739         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 740         Remove fields.
 741         <partial_symtabs>: New field.
 742         (class objfile_psymtabs): Move from psymtab.h.  Update.
 743         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 744         psymbol_cache.
 745         (objfile::~objfile): Don't destroy psymbol_cache.
 746         * mdebugread.c (parse_partial_symbols): Update.
 747         * dwarf2read.c (create_addrmap_from_index)
 748         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 749         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 750         (add_partial_subprogram, dwarf2_ranges_read): Update.
 751         * dwarf-index-write.c (write_address_map)
 752         (write_one_signatured_type, recursively_write_psymbols)
 753         (class debug_names, class debug_names, write_psymtabs_to_index):
 754         Update.
 755
 756 2019-01-10  Tom Tromey  <tom@tromey.com>
 757
 758         * symtab.h (SYMBOL_SET_NAMES): Update.
 759         (symbol_set_names): Update.
 760         (MSYMBOL_SET_NAMES): Update.
 761         * symtab.c (symbol_set_names): Change argument to be an
 762         objfile_per_bfd_storage.
 763         * psymtab.c (add_psymbol_to_bcache): Update.
 764         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 765
 766 2019-01-10  Tom Tromey  <tom@tromey.com>
 767
 768         * symtab.c (create_demangled_names_hash): Change argument to be an
 769         objfile_per_bfd_storage.
 770         (symbol_set_names): Update.
 771
 772 2019-01-10  Tom Tromey  <tom@tromey.com>
 773
 774         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 775         init_psymbol_list.
 776         * psymtab.c (init_psymbol_list): Do nothing if already called.
 777         * psympriv.h (init_psymbol_list): Add comment.
 778         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 779         init_psymbol_list.
 780         * dbxread.c (dbx_symfile_read): Unconditionally call
 781         init_psymbol_list.
 782
 783 2019-01-10  Tom Tromey  <tom@tromey.com>
 784
 785         * xcoffread.c (scan_xcoff_symtab): Update.
 786         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 787         "where".
 788         * mdebugread.c (parse_partial_symbols)
 789         (handle_psymbol_enumerators): Update.
 790         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 791         * dbxread.c (read_dbx_symtab): Update.
 792         * psympriv.h (psymbol_placement): New enum.
 793         (add_psymbol_to_list): Update.
 794
 795 2019-01-10  Tom Tromey  <tom@tromey.com>
 796
 797         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 798         static_psymbols parameters.
 799         (scan_xcoff_symtab): Update.
 800         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 801         static_psymbols parameters.
 802         * psympriv.h (start_psymtab_common): Update.
 803         * mdebugread.c (parse_partial_symbols): Update.
 804         * dwarf2read.c (create_partial_symtab): Update.
 805         * dbxread.c (read_dbx_symtab): Update.
 806         (start_psymtab): Remove global_psymbols and static_psymbols
 807         parameters.
 808
 809 2019-01-10  Tom Tromey  <tom@tromey.com>
 810
 811         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 812         * psymtab.c (allocate_psymtab): Add comment.
 813         * psympriv.h (allocate_psymtab): Add comment.
 814         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 815         initializations.
 816         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 817
 818 2019-01-10  Tom Tromey  <tom@tromey.com>
 819
 820         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 821         Don't declare.
 822         * mipsread.c: Include mdebugread.h.
 823         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 824         Declare.
 825         * elfread.c: Include mdebugread.h.
 826
 827 2019-01-09  Tom Tromey  <tom@tromey.com>
 828
 829         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 830         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 831         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 832         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 833         (psym_lookup_symbol, psym_find_last_source_symtab)
 834         (psym_forget_cached_source_info, psym_print_stats)
 835         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 836         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 837         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 838         (psym_find_compunit_symtab_by_address)
 839         (maintenance_print_psymbols, maintenance_info_psymtabs)
 840         (maintenance_check_psymtabs): Use ranged for.
 841         * psymtab.h (class objfile_psymtabs): New.
 842         (require_partial_symbols): Return objfile_psymtabs.
 843         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 844
 845 2019-01-09  Tom Tromey  <tom@tromey.com>
 846
 847         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 848         (find_pc_mapped_section, list_overlays_command)
 849         (map_overlay_command, unmap_overlay_command)
 850         (simple_overlay_update): Use all_objfiles.
 851         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 852         * printcmd.c (info_symbol_command): Use all_objfiles.
 853         * objfiles.h (ALL_OBJSECTIONS): Remove.
 854         * maint.c (maintenance_translate_address): Use all_objfiles.
 855         * gcore.c (gcore_create_callback): Use all_objfiles.
 856         (objfile_find_memory_regions): Likewise.
 857
 858 2019-01-09  Tom Tromey  <tom@tromey.com>
 859
 860         * symtab.c (find_line_symtab, info_sources_command)
 861         (make_source_files_completion_list): Use objfile_compunits.
 862         * source.c (select_source_symtab): Use objfile_compunits.
 863         * objfiles.h (struct objfile): Update comment.
 864         (ALL_OBJFILES): Remove.
 865         (ALL_FILETABS): Remove.
 866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 867         objfile_compunits.
 868
 869 2019-01-09  Tom Tromey  <tom@tromey.com>
 870
 871         * symmisc.c (print_objfile_statistics, dump_objfile)
 872         (maintenance_print_symbols): Use compunit_filetabs.
 873         * source.c (forget_cached_source_info_for_objfile): Use
 874         compunit_filetabs.
 875         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 876         (ALL_FILETABS): Use compunit_filetabs.
 877         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 878         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 879
 880 2019-01-09  Tom Tromey  <tom@tromey.com>
 881
 882         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 883         (compunit_filetabs): New.
 884         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 885         compunit_filetabs.
 886         (info_sources_command, make_source_files_completion_list): Remove
 887         declaration.
 888         * symmisc.c (print_objfile_statistics, dump_objfile)
 889         (maintenance_print_symbols): Remove declaration.
 890         (maintenance_info_symtabs): Use compunit_filetabs.
 891         (maintenance_info_line_tables): Likewise.
 892         * source.c (select_source_symtab): Change local variable name.
 893         (forget_cached_source_info_for_objfile): Remove declaration.
 894         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 895         * objfiles.c (objfile_relocate1): Remove declaration.
 896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 897         declaration.
 898         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 899         * coffread.c (coff_symtab_read): Remove declaration.
 900         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 901         compunit_filetabs.
 902
 903 2019-01-09  Tom Tromey  <tom@tromey.com>
 904
 905         * symtab.c (lookup_objfile_from_block)
 906         (find_pc_sect_compunit_symtab, search_symbols)
 907         (default_collect_symbol_completion_matches_break_on): Use
 908         objfile_compunits.
 909         * objfiles.h (ALL_COMPUNITS): Remove.
 910         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 911         * cp-support.c (add_symbol_overload_list_qualified): Use
 912         objfile_compunits.
 913         * ada-lang.c (ada_collect_symbol_completion_matches)
 914         (ada_add_global_exceptions): Use objfile_compunits.
 915
 916 2019-01-09  Tom Tromey  <tom@tromey.com>
 917
 918         * source.c (select_source_symtab)
 919         (forget_cached_source_info_for_objfile): Remove declaration.
 920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 921         declaration.
 922         * maint.c (count_symtabs_and_blocks): Remove declaration.
 923         * cp-support.c (add_symbol_overload_list_qualified): Remove
 924         declaration.
 925         * coffread.c (coff_symtab_read): Remove declaration.
 926         * symtab.c (lookup_symbol_in_objfile_symtabs)
 927         (basic_lookup_transparent_type_1): Use objfile_compunits.
 928         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 929         (info_sources_command, search_symbols)
 930         (default_collect_symbol_completion_matches_break_on)
 931         (make_source_files_completion_list): Remove declaration.
 932         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 933         (ada_collect_symbol_completion_matches)
 934         (ada_add_global_exceptions): Remove declaration.
 935         * linespec.c (iterate_over_all_matching_symtabs): Use
 936         objfile_compunits.
 937         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 938         (class objfile_compunits): New.
 939         (ALL_COMPUNITS): Use objfile_compunits.
 940         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 941         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 942         objfile_compunits.
 943         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 944
 945 2019-01-09  Tom Tromey  <tom@tromey.com>
 946
 947         * symtab.c (search_symbols)
 948         (default_collect_symbol_completion_matches_break_on): Use
 949         objfile_msymbols.
 950         * ada-lang.c (ada_lookup_simple_minsym)
 951         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 952         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 953         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 954         objfile_msymbols.
 955         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 956         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 957         * objc-lang.c (find_methods): Use objfile_msymbols.
 958         (info_selectors_command, info_classes_command): Likewise.
 959         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 960         * objfiles.h (class objfile_msymbols): New.
 961         (ALL_OBJFILE_MSYMBOLS): Remove.
 962         (ALL_MSYMBOLS): Remove.
 963
 964 2019-01-09  Tom Tromey  <tom@tromey.com>
 965
 966         * common/next-iterator.h (next_adapter): Add Iterator template
 967         parameter.
 968         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 969         (class all_objfiles_safe): New.
 970         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 971         * objfiles.c (put_objfile_before): Update comment.
 972         (add_separate_debug_objfile): Likewise.
 973         (free_all_objfiles): Use all_objfiles_safe.
 974         (objfile_purge_solibs): Likewise.
 975
 976 2019-01-09  Tom Tromey  <tom@tromey.com>
 977
 978         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 979         (expand_symtab_containing_pc, lookup_static_symbol)
 980         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 981         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 982         all_objfiles.
 983         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 984         * breakpoint.c (create_overlay_event_breakpoint)
 985         (create_longjmp_master_breakpoint)
 986         (create_std_terminate_master_breakpoint)
 987         (create_exception_master_breakpoint): Use all_objfiles.
 988         * linux-thread-db.c (try_thread_db_load_from_pdir)
 989         (has_libpthread): Use all_objfiles.
 990         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 991         * linespec.c (iterate_over_all_matching_symtabs)
 992         (search_minsyms_for_name): Use all_objfiles.
 993         * maint.c (maintenance_info_sections): Use all_objfiles.
 994         * main.c (captured_main_1): Use all_objfiles.
 995         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 996         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 997         * guile/scm-pretty-print.c
 998         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 999         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1000         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1001         (maintenance_print_msymbols): Use all_objfiles.
1002         * source.c (select_source_symtab): Use all_objfiles.
1003         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1004         * symfile.c (remove_symbol_file_command)
1005         (expand_symtabs_matching, map_symbol_filenames): Use
1006         all_objfiles.
1007         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1008         all_objfiles.
1009         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1010         * objc-lang.c (find_methods): Use all_objfiles.
1011         * objfiles.c (have_partial_symbols, have_full_symbols)
1012         (have_minimal_symbols, qsort_cmp)
1013         (default_iterate_over_objfiles_in_search_order): Use
1014         all_objfiles.
1015         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1016         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1017         (maintenance_check_psymtabs): Use all_objfiles.
1018         (ALL_PSYMTABS): Remove.
1019         * compile/compile-object-run.c (do_module_cleanup): Use
1020         all_objfiles.
1021         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1022         * cp-support.c (add_symbol_overload_list_qualified): Use
1023         all_objfiles.
1024         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1025         Use all_objfiles.
1026         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1027         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1028         all_objfiles.
1029         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1030         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1031         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1032         Uses all_objfiles.
1033         * solib.c (solib_read_symbols): Use all_objfiles
1034
1035 2019-01-09  Tom Tromey  <tom@tromey.com>
1036
1037         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1038         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1039         all_objfiles.
1040         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1041         * symmisc.c (print_symbol_bcache_statistics)
1042         (print_objfile_statistics, maintenance_print_objfiles)
1043         (maintenance_info_symtabs, maintenance_check_symtabs)
1044         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1045         all_objfiles.
1046         * source.c (forget_cached_source_info): Use all_objfiles.
1047         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1048         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1049         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1050         * objfiles.c (update_section_map): Use all_objfiles.
1051         (shared_objfile_contains_address_p): Likewise.
1052         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1053         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1054
1055 2019-01-09  Tom Tromey  <tom@tromey.com>
1056
1057         * common/next-iterator.h: New file.
1058         * objfiles.h (class all_objfiles): New.
1059         (struct objfile_iterator): New.
1060
1061 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * NEWS: Move the description of the changed "frame", "select-frame",
1064          and "info frame" commands to the Changed commands section.
1065
1066 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1067
1068         * gdbtypes.c (check_stub_method_group): Remove handling of old
1069         mangling schemes.
1070         * linespec.c (find_methods): Likewise.
1071         * stabsread.c (read_member_functions): Likewise.
1072         * valops.c (search_struct_method): Likewise.
1073         (value_struct_elt_for_reference): Likewise.
1074         * NEWS: Mention this change.
1075
1076 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1079         print_source_lines.
1080         * source.c (print_source_lines_base): Update line number check.
1081         (print_source_lines): New function.
1082         (source_lines_range::source_lines_range): New function.
1083         * source.h (class source_lines_range): New class.
1084         (print_source_lines): New declaration.
1085
1086 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1087
1088         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1089
1090 2019-01-08  Tom Tromey  <tom@tromey.com>
1091             Simon Marchi  <simon.marchi@ericsson.com>
1092
1093         PR gdb/24060
1094         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1095         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1096         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1097         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1098         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1099         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1100
1101 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * source.c (select_source_symtab): Move header comment to
1104         declaration in source.h.
1105         (forget_cached_source_info_for_objfile): Likewise.
1106         (forget_cached_source_info): Likewise.
1107         (identify_source_line): Likewise.
1108         * source.h (identify_source_line): Move declaration from symtab.h
1109         and add comment from source.c
1110         (print_source_lines): Likewise.
1111         (forget_cached_source_info_for_objfile): Likewise.
1112         (forget_cached_source_info): Likewise.
1113         (select_source_symtab): Likewise.
1114         (enum print_source_lines_flag): Move definition from symtab.h.
1115         * symtab.h (identify_source_line): Move declaration to source.h.
1116         (print_source_lines): Likewise.
1117         (forget_cached_source_info_for_objfile): Likewise.
1118         (forget_cached_source_info): Likewise.
1119         (select_source_symtab): Likewise.
1120         (enum print_source_lines_flag): Move definition to source.h.
1121         * tui/tui-hooks.c: Add 'source.h' include.
1122
1123 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * source.c (print_source_lines_base): Handle requests to print
1126         reverse line number sequences, and guard against empty lines
1127         string.
1128
1129 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * source.c (print_source_lines_base): Fix skip of '\r' if next
1132         character is '\n'.
1133
1134 2019-01-06  Tom Tromey  <tom@tromey.com>
1135
1136         * c-exp.y (struct c_parse_state) <macro_original_text,
1137         expansion_obstack>: New member.
1138         (macro_original_text, expansion_obstack): Remove globals.
1139         (scan_macro_expansion, scanning_macro_expansion)
1140         (finished_macro_expansion): Update.
1141         (scan_macro_cleanup): Remove.
1142         (yylex, c_parse): Update.
1143
1144 2019-01-06  Tom Tromey  <tom@tromey.com>
1145
1146         * c-exp.y (struct c_parse_state) <strings>: New member.
1147         (operator_stoken): Update.
1148
1149 2019-01-06  Tom Tromey  <tom@tromey.com>
1150
1151         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1152         (union type_stack_elt) <typelist_val>: Now a pointer to
1153         std::vector.
1154         (type_stack_cleanup): Don't declare.
1155         (push_typelist): Update.
1156         * parse.c (pop_typelist): Return a std::vector.
1157         (push_typelist): Take a std::vector.
1158         (follow_types): Update.  Do not free args.
1159         (type_stack_cleanup): Remove.
1160         * c-exp.y (struct c_parse_state): New.
1161         (cpstate): New global.
1162         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1163         (nonempty_typelist): Update.
1164         (func_mod): Create a new vector.
1165         (c_parse): Create a c_parse_state.
1166         (check_parameter_typelist): Do not delete params.
1167         (function_method): Update.  Do not delete type_list.
1168
1169 2019-01-06  Tom Tromey  <tom@tromey.com>
1170
1171         PR gdb/28155:
1172         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1173         check_typedef.
1174         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1175         (print_return_value): Likewise.
1176
1177 2019-01-05  Tom Tromey  <tom@tromey.com>
1178
1179         * contrib/cleanup_check.py: Remove.
1180         * contrib/gcc-with-excheck: Remove.
1181         * contrib/exsummary.py: Remove.
1182         * contrib/excheck.py: Remove.
1183
1184 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1185
1186         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1187         NULL. Initialize tpprev to NULL instead of assigning it
1188         to NULL on the next statement.
1189         * windows-nat.c (windows_delete_thread): Remove check for
1190         main_thread_id before printing thread exit notifications.
1191         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1192         Remove thread ID check against main_thread_id.
1193         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1194         windows_delete_thread.
1195         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1196
1197 2019-01-04  Tom Tromey  <tom@tromey.com>
1198
1199         * compile/compile.c (_initialize_compile): Use upper case for
1200         metasyntactic variables.
1201         * symmisc.c (_initialize_symmisc): Use upper case for
1202         metasyntactic variables.
1203         * psymtab.c (_initialize_psymtab): Use upper case for
1204         metasyntactic variables.
1205         * demangle.c (demangle_command): Use upper case for metasyntactic
1206         variables.
1207         (_initialize_demangler): Likewise.
1208         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1209         variables.
1210
1211 2019-01-03  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1214
1215 2019-01-03  Tom Tromey  <tom@tromey.com>
1216
1217         * python/py-symtab.c (salpy_str): Update.
1218         (struct salpy_sal_object) <symtab>: Now a PyObject.
1219         (salpy_dealloc): Update.
1220         (del_objfile_sal): Use gdbpy_ref.
1221
1222 2019-01-03  Tom Tromey  <tom@tromey.com>
1223
1224         * python/py-type.c (convert_field): Use new_reference.  Return
1225         gdbpy_ref.
1226         (make_fielditem): Return gdbpy_ref.
1227         (typy_fields): Update.
1228         (typy_getitem): Update.
1229         (field_name): Return gdbpy_ref.  Use new_reference.
1230         (typy_iterator_iternext): Update.
1231
1232 2019-01-03  Tom Tromey  <tom@tromey.com>
1233
1234         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1235
1236 2019-01-03  Tom Tromey  <tom@tromey.com>
1237
1238         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1239         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1240         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1241         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1242         (pspy_set_type_printers): Likewise.
1243         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1244         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1245         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1246         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1247         (objfpy_set_type_printers): Likewise.
1248
1249 2019-01-03  Tom Tromey  <tom@tromey.com>
1250
1251         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1252         (gdbpy_print_stack): Use gdbpy_err_fetch.
1253         * python/python-internal.h (class gdbpy_err_fetch): New class.
1254         (class gdbpy_enter) <m_error_type, m_error_value,
1255         m_error_traceback>: Remove.
1256         <m_error>: New member.
1257         (gdbpy_exception_to_string): Don't declare.
1258         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1259         * python/py-value.c (convert_value_from_python): Use
1260         gdbpy_err_fetch.
1261         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1262         gdbpy_exception_to_string.
1263         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1264         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1265         gdbpy_err_fetch.
1266
1267 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * linux-nat.c (delete_lwp_cleanup): Delete.
1270         (struct lwp_deleter): New struct.
1271         (lwp_info_up): New typedef.
1272         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1273         lwp_info_up.
1274
1275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * linux-fork.c (class scoped_switch_fork_info): New class.
1278         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1279
1280 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * valops.c (find_overload_match): Remove use of null_cleanup, and
1283         calls to do_cleanups.
1284
1285 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * compile/compile-cplus-types.c
1288         (compile_cplus_instance::decl_name): Handle changes to
1289         cp_func_name.
1290         * cp-support.c (cp_func_name): Update header comment, update
1291         return type.
1292         * cp-support.h (cp_func_name): Update return type in declaration.
1293         * valops.c (find_overload_match): Move temp_func local to top
1294         level of function and change its type.  Use temp_func to hold and
1295         delete temporary string obtained from cp_func_name.
1296
1297 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1300         gdb::char_vector, remove cleanup, and update uses of `msg`.
1301
1302 2019-01-03  Jim Wilson  <jimw@sifive.com>
1303
1304         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1305
1306 2019-01-02  Tom Tromey  <tom@tromey.com>
1307
1308         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1309         (tdesc_parse_xml): Remove cleanups.
1310         * target-descriptions.h (make_cleanup_free_target_description):
1311         Don't declare.
1312         (target_desc_deleter): New struct.
1313         (target_desc_up): New typedef.
1314         * target-descriptions.c (target_desc_deleter::operator()): Rename
1315         from free_target_description.
1316         (make_cleanup_free_target_description): Remove.
1317
1318 2019-01-02  Tom Tromey  <tom@tromey.com>
1319
1320         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1321         constructor, destructor.
1322         (linespec_parser): Remove typedef.
1323         (~linespec_parser): Rename from linespec_parser_delete.
1324         (linespec_lex_to_end, linespec_complete_label)
1325         (linespec_complete): Update.
1326         (decode_line_full): Remove cleanups.
1327         (decode_line_1): Update.
1328
1329 2019-01-02  Tom Tromey  <tom@tromey.com>
1330
1331         * python/python-internal.h (inferior_to_inferior_object): Change
1332         return type.
1333         * python/py-exitedevent.c (create_exited_event_object): Update.
1334         * python/py-inferior.c (inferior_to_inferior_object): Return
1335         gdbpy_ref.
1336         (python_new_inferior, python_inferior_deleted)
1337         (thread_to_thread_object, delete_thread_object)
1338         (build_inferior_list, gdbpy_selected_inferior): Update.
1339         * python/py-infthread.c (create_thread_object): Update.  Also fail
1340         if inferior_to_inferior_object fails.
1341
1342 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1343
1344         * inferior.h (class inferior) <displaced_step_state>: New field.
1345         * infrun.h (struct displaced_step_state): Move here from
1346         infrun.c.  Initialize fields, add constructor.
1347         <inf>: Remove field.
1348         <reset>: New method.
1349         * infrun.c (struct displaced_step_inferior_state): Move to
1350         infrun.h.
1351         (displaced_step_inferior_states): Remove.
1352         (get_displaced_stepping_state): Adust.
1353         (displaced_step_in_progress_any_inferior): Adjust.
1354         (displaced_step_in_progress_thread): Adjust.
1355         (displaced_step_in_progress): Adjust.
1356         (add_displaced_stepping_state): Remove.
1357         (get_displaced_step_closure_by_addr): Adjust.
1358         (remove_displaced_stepping_state): Remove.
1359         (infrun_inferior_exit): Call displaced_step_state.reset.
1360         (use_displaced_stepping): Don't check for NULL.
1361         (displaced_step_prepare_throw): Call
1362         get_displaced_stepping_state.
1363         (displaced_step_fixup): Don't check for NULL.
1364         (prepare_for_detach): Don't check for NULL.
1365
1366 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1367
1368         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1369          in case of call that did not complete.
1370
1371 2019-01-02  Andrey Utkin  <autkin@undo.io>
1372
1373         * symfile.c (find_separate_debug_file): Fix search of debug files for
1374         remote debuggee.
1375
1376 2019-01-02  Tom Tromey  <tom@tromey.com>
1377
1378         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1379         indentation.
1380         * python/py-frame.c (frapy_older): Remove cast.
1381         (frapy_newer): Likewise.
1382         * python/py-breakpoint.c (local_setattro): Remove cast.
1383         * python/py-arch.c (archpy_name): Remove local variable.
1384         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1385
1386 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1387
1388         * unittests/basic_string_view/element_access/char/empty.cc:
1389         Fix year range in copyright header.
1390
1391 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1394         Delete.
1395         <operator==>: Update with for removed field.
1396         <hash>: Likewise.
1397         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1398         <isa_features>: ...this.
1399         <abi_features>: New field.
1400         (riscv_isa_flen): Update comment.
1401         (riscv_abi_xlen): New declaration.
1402         (riscv_abi_flen): New declaration.
1403         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1404         isa_features.
1405         (riscv_abi_xlen): New function.
1406         (riscv_isa_flen): Update to get answer from isa_features.
1407         (riscv_abi_flen): New function.
1408         (riscv_has_fp_abi): Update to get answer from abi_features.
1409         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1410         xlen and flen.
1411         (riscv_call_info) <xlen, flen>: Update comment.
1412         (riscv_call_arg_struct): Remove invalid assertions
1413         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1414         is removed.
1415         (riscv_gdbarch_init): Gather isa features and abi features
1416         separately, ensure both match on the gdbarch when reusing an old
1417         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1418         a target with 64-bit float hardware.
1419
1420 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1421
1422         * source.c (search_command_helper): Stop reverse search
1423         when line 1 has been searched.
1424
1425 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1426
1427         * record-full.c (record_full_base_target::close): Rewrite
1428         record_full_core_buf_list free logic.
1429
1430 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1431
1432         * break-catch-syscall.c (print_one_catch_syscall): xfree
1433         the last text.
1434
1435 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1436
1437         * top.c (print_gdb_version): Update Copyright year in version
1438         message.
1439
1440 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1441
1442         Update copyright year range in all GDB files.
1443
1444 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1445
1446         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1447
1448 For older changes see ChangeLog-2018.
1449 \f
1450 Local Variables:
1451 mode: change-log
1452 left-margin: 8
1453 fill-column: 74
1454 version-control: never
1455 coding: utf-8
1456 End:
1457